Merge from emacs-24 branch; up to 2012-05-01T10:20:43Z!rgm@gnu.org
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9928463d
DA
12012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Add indirection counting to speed up Fkill_buffer.
4 * buffer.h (struct buffer): New member.
5 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
6 (Fmake_indirect_buffer): Set indirection counter to -1, increment
7 base buffer indirection counter.
8 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
9 (Fkill_buffer): Adjust indirection counters as needed, don't walk
10 through buffer list if indirection counter is 0.
11
f8643a6b
DA
122012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
13
14 Extend the value returned by Fgarbage_collect with heap statistics.
15 * alloc.c (Qheap): New symbol.
16 (syms_of_alloc): DEFSYM it.
17 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
18 (Fmemory_free): Remove.
19 (syms_of_alloc): Don't defsubr it.
20 * buffer.c (Fcompact_buffer): Remove.
21 (syms_of_buffer): Don't defsubr it.
22
dac616ff
DA
232012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
24
25 Make maybe_gc inline.
26 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
27 * lisp.h (consing_since_gc, gc_relative_threshold)
28 (memory_full_cons_threshold): Revert declaration.
29 (maybe_gc): Remove prototype, define as inline.
30 * alloc.c: Remove old commented-out code.
31 (consing_since_gc, gc_relative_threshold)
32 (memory_full_cons_threshold): Revert to global.
33 (maybe_gc): Remove.
34
d7ea76b4
DA
352012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
36
37 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
38 * lisp.h (build_unibyte_string): New function.
39 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
40 * sysdep.c, w32fns.c, xfns.c: Use it.
41 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
42 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
43 Adjust users accordingly.
44 * font.h (font_open_by_name): Adjust prototype.
45
765e61e3
DA
462012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
47
48 Cleanup calls to Fgarbage_collect.
49 * lisp.h (maybe_gc): New prototype.
50 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
51 Remove declarations.
52 * alloc.c (maybe_gc): New function.
53 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
54 Make them static.
55 * bytecode.c (MAYBE_GC): Use maybe_gc.
56 * eval.c (eval_sub, Ffuncall): Likewise.
57 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
58 to avoid dependency from auto-save feature.
59
52b852c7
PE
602012-07-19 Paul Eggert <eggert@cs.ucla.edu>
61
62 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
63 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
64 'for_each_per_buffer_object_at'.
65 All uses changed. It's better to use upper-case for macros that
66 cannot be implemented as functions, to give the reader a clue
67 that they're special.
68
5db81e33
SM
692012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
70
71 * alloc.c (Fgarbage_collect): Tweak docstring.
72
5b835e1d
DA
732012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
74
75 Tweak the value returned from Fgarbage_collect again.
76 * alloc.c (Fgarbage_collect): New return value, as confirmed in
77 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
78 Adjust documentation.
79 (total_vector_bytes): Rename to total_vector_slots, adjust
80 accounting.
81 (total_free_vector_bytes): Rename to total_free_vector_slots,
82 adjust accounting.
83 (Qstring_bytes, Qvector_slots): New symbols.
84 (syms_of_alloc): DEFSYM them.
85
9cd47b72
DA
862012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
87
88 Buffer compaction primitive which may be used from Lisp.
89 * buffer.c (compact_buffer, Fcompact_buffer): New function.
90 (syms_of_buffer): Register Fcompact_buffer.
91 * alloc.c (Fgarbage_collect): Use compact_buffer.
92 * buffer.h (compact_buffer): New prototype.
93 (struct buffer_text): New member.
94
d17337e5
DA
952012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
96
97 New macro to iterate over all buffers, miscellaneous cleanups.
98 * lisp.h (all_buffers): Remove declaration.
99 * buffer.h (all_buffers): Add declaration, with comment.
100 (for_each_buffer): New macro.
101 * alloc.c (Fgarbage_collect, mark_object): Use it.
102 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
103 (init_buffer): Likewise.
104 * data.c (Fset_default): Likewise.
105 * coding.c (code_conversion_restore): Remove redundant check
106 for dead buffer.
107 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
108
60cfd278
AS
1092012-07-18 Andreas Schwab <schwab@linux-m68k.org>
110
111 Fix bug that created negative-length intervals.
112 * intervals.c (merge_interval_right, merge_interval_left):
113 Do not zero out this interval if it is absorbed by its children,
114 as this interval's total length doesn't change in that case. See
115 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
116
d06714cb
PE
1172012-07-18 Paul Eggert <eggert@cs.ucla.edu>
118
83713154
PE
119 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
120 when invoking (make-bool-vector N t) and N is a positive
121 multiple of 8 -- the last 8 bits were mistakenly cleared.
122
d06714cb
PE
123 Remove some struct layout assumptions in bool vectors.
124 * alloc.c (bool_header_size): New constant.
125 (header_size, word_size): Move earlier, as they're now used earlier.
126 Use 'word_size' in a few more places, where it's appropriate.
127 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
128 padding before the data member of a bool vector.
129 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
130 than doing the check by hand with an abort ().
131
464d5a5e
SM
1322012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
133
5fbc0409
SM
134 * eval.c (Fdefvar): Don't check constants since we only set the var if
135 it's not yet defined anyway (bug#11904).
136
464d5a5e
SM
137 * lisp.h (last_undo_boundary): Declare new var.
138 * keyboard.c (command_loop_1): Set it.
139 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
140 were auto-added by the command loop (bug#11774).
141
8dc2e44a
AS
1422012-07-18 Andreas Schwab <schwab@linux-m68k.org>
143
144 * w32font.c (Qsymbol): Remove local definition.
145 (syms_of_w32font): Don't DEFSYM it.
146
169925ec
DA
1472012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
148
149 Fix sweep_vectors to handle large bool vectors correctly.
150 * alloc.c (sweep_vectors): Account total_vector_bytes for
151 bool vectors larger than VBLOCK_BYTES_MAX.
152
5fbfb018
CY
1532012-07-18 Chong Yidong <cyd@gnu.org>
154
155 * frame.c (x_set_frame_parameters): Revert bogus change introduced
156 in 2012-05-25 commit by Paul Eggert (Bug#11738).
157
3ab6e069
DA
1582012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
159
160 Return more descriptive data from Fgarbage_collect.
161 Suggested by Stefan Monnier in
162 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
163 * alloc.c (bounded_number): New function.
164 (total_buffers, total_vectors): New variable.
165 (total_string_size): Rename to total_string_bytes, adjust users.
166 (total_vector_size): Rename to total_vector_bytes, adjust users.
167 (sweep_vectors): Account total_vectors and total_vector_bytes.
168 (Fgarbage_collect): New return value. Adjust documentation.
169 (gc_sweep): Account total_buffers.
170 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
171 (VECTOR_SIZE): Remove.
172 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
173 (Qinterval, Qmisc): New symbols.
174 (syms_of_data): Initialize them.
175 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
176 (Qcons, Qbuffer): New declarations.
177
6d02fe5b
PE
1782012-07-17 Paul Eggert <eggert@cs.ucla.edu>
179
180 * alloc.c (Fmemory_free): Account for memory-free's own storage.
181 Round up, not down. Improve doc.
182
b7ffe040
DA
1832012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
184
185 Restore old code in allocate_string_data to avoid Faset breakage.
186 Reported by Julien Danjou <julien@danjou.info> in
187 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
188 * alloc.c (allocate_string_data): Restore old code with minor
189 adjustments, fix comment to explain this subtle issue.
190
4dc7c8d5
SM
1912012-07-17 Eli Zaretskii <eliz@gnu.org>
192
193 Remove FILE_SYSTEM_CASE.
194 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
195
196 * fileio.c (FILE_SYSTEM_CASE): Don't define.
197 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
198 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
199 call-process-region passes it through expand-file-name.
200
201 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
202
2032012-07-17 Andreas Schwab <schwab@linux-m68k.org>
204
205 Fix crash when creating indirect buffer (Bug#11917)
206 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
207 Don't handle unbound variables specially if non-zero.
208 (Fbuffer_local_variables): Pass zero.
209 (clone_per_buffer_values): Pass non-zero.
210
2112012-07-17 Andreas Schwab <schwab@linux-m68k.org>
212
213 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
214 to make the loop interruptible.
215
2162012-07-17 Andreas Schwab <schwab@linux-m68k.org>
217
218 * gnutls.c (emacs_gnutls_handshake): Only retry if
219 GNUTLS_E_INTERRUPTED.
220
cce7fefc
DA
2212012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
222
223 Cleanup and convert miscellaneous checks to eassert.
224 * alloc.c (mark_interval): Fix comment, partially rephrase
225 old comment from intervals.h (see below).
226 * intervals.c (find_interval, adjust_intervals_for_insertion)
227 (delete_interval, adjust_intervals_for_deletion)
228 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
229 Convert to eassert.
230 (adjust_intervals_for_insertion, make_new_interval):
231 Remove obsolete and unused code.
232 * intervals.h (struct interval): Remove obsolete comment.
233 * textprotp.c (erase_properties): Remove unused code.
234 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
235 (Fremove_list_of_text_properties): Convert to eassert.
236
9ea10cc3
CY
2372012-07-17 Chong Yidong <cyd@gnu.org>
238
239 * editfns.c (Finsert_char): Doc fix.
240
3900d5de
DA
2412012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
242
243 Fix previous change to make Fmemory_free always accurate.
244 * alloc.c (make_interval): Update total_free_intervals.
245 (make_float): Likewise for total_free_floats.
246 (free_cons, Fcons): Likewise for total_free_conses.
247 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
248 Likewise for total_free_vector_bytes.
249 (Fmake_symbol): Likewise for total_free_symbols.
250 (bytes_free): Remove.
251
7098646f
DA
2522012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
253
254 Simple free memory accounting feature.
255 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
256 (sweep_vectors): Accumulate size of free vectors.
257 (Fgarbage_collect): Setup bytes_free.
258 (Fmemory_free): New function.
259 (syms_of_alloc): Register it.
260
22657b40
DA
2612012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
262
263 Cleanup overlays checking.
264 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
265 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
266 eassert and OVERLAYP.
267 (sort_overlays): Change to use OVERLAYP.
268
ddfc8813
RK
2692012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
270
271 * editfns.c (Finsert_char): Make it interactive, and make the
272 second arg optional. Copy interactive spec and docstring from
273 ucs-insert.
274
7c26cf3c
PE
2752012-07-17 Paul Eggert <eggert@cs.ucla.edu>
276
277 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
278 Unlike the other wrapped functions, fabs has an unspecified
279 effect on errno.
280
5d127af9
JD
2812012-07-16 Jan Djärv <jan.h.d@swipnet.se>
282
283 * nsterm.m (keyDown): Interpret flags without left/right bits
284 as the left key (Bug#11670).
285
6a0dd1d7
DA
2862012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
287
288 Remove empty and useless init functions.
289 * lisp.h (init_character_once, init_fns, init_image)
290 (init_filelock, init_sound): Remove prototype.
291 * character.c (init_character_once): Remove.
292 * filelock.c (init_filelock): Likewise.
293 * fns.c (init_fns): Likewise.
294 * image.c (init_image): Likewise.
295 * sound.c (init_sound): Likewise.
296 * emacs.c (main): Adjust accordingly.
297
7a6136fd
DA
2982012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
299
300 * gtkutil.h: Tiny cleanups.
301 (use_old_gtk_file_dialog): Remove useless declaration.
302 (xg_uses_old_file_dialog): Add suggested const attribute.
303
ce811ad9
EZ
3042012-07-15 Eli Zaretskii <eliz@gnu.org>
305
306 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
307 (bidi_paragraph_init): Use it to limit search forward for a strong
308 directional character in abnormally large paragraphs full of
309 neutral or weak characters. (Bug#11943)
310
c9adfeaa
SF
3112012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
312
313 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
314 the toolbar (Bug#9451).
315 (xg_make_tool_item): Give the widget event box a transparent
316 background.
317
fff62aa9
DA
3182012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
319
320 Cleanup basic allocation variables and functions.
321 * alloc.c (ignore_warnings, init_intervals, init_float)
322 (init_cons, init_symbol, init_marker): Remove.
323 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
324 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
325 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
326 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
327 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
328 (staticidx, init_alloc_once, init_strings, free_ablock):
329 Remove redundant initialization.
330 * fns.c (init_weak_hash_tables): Remove.
331 * lisp.h (init_weak_hash_tables): Remove prototype.
332
9730daca
DA
3332012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
334
335 Use zero_vector where appropriate.
336 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
337 accordingly.
338 * lisp.h (zero_vector): New declaration.
339 * font.c (null_vector): Remove.
340 (syms_of_font): Remove initialization and staticpro.
341 (font_list_entities, font_find_for_lface): Change to use zero_vector.
342 * keymap.c (Faccessible_keymaps): Likewise.
343
2e2d2a13
LL
3442012-07-15 Leo Liu <sdl.web@gmail.com>
345
346 * fringe.c: Fix typo in comments.
347
cd276f6e
LL
3482012-07-14 Leo Liu <sdl.web@gmail.com>
349
350 * fringe.c: Add a new bitmap exclamation-mark.
351
5a1131d9
EZ
3522012-07-14 Eli Zaretskii <eliz@gnu.org>
353
354 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
355
356 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
357 (HAVE_MENUS): Don't define, defined by editing config.in with
358 msdos/sed2v2.inp.
359 (GMALLOC_INHIBIT_VALLOC): Don't define.
360 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
361
22e983b7
JB
3622012-07-14 Juanma Barranquero <lekktu@gmail.com>
363
364 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
365
5b3f250f
GM
3662012-07-14 Glenn Morris <rgm@gnu.org>
367
368 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
369 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
370 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
371
33d63ff4
GM
3722012-07-13 Glenn Morris <rgm@gnu.org>
373
5b633342
GM
374 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
375
33d63ff4
GM
376 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
377 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
378
b55b9f85
JD
3792012-07-13 Jan Djärv <jan.h.d@swipnet.se>
380
0dc8cf50
JD
381 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
382 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
383 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
384 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
385 where appropriate.
386 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
387 as boolean expression.
388 (x_set_window_size): Remove unused variable toolbar.
389 (ns_get_color_default, ns_mod_to_lisp): Remove.
390 (ns_mouse_position): Remove unused variables xchar and ychar.
391 (ns_compute_glyph_string_overhangs): Remove unused variable face.
392 (ns_set_vertical_scroll_bar): Remove unused variable count.
393 (ns_delete_terminal): Remove unused variable i.
394 (ns_term_init): Remove unused variables r, g and b.
395 (mouseDown): Remove unused variable window.
396 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
397 (initFrameFromEmacs): Remove unused variable vbextra.
398 (mouseEntered): Remove unused variables p and dpyinfo.
399 (mouseExited): Remove unused variables p and r.
400 (ns_define_frame_cursor, ns_clear_frame_area)
401 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
402 (menuDown): Assign [sender tag] to variable and cast the variable.
403
404 * nsterm.h (menuDown): Add id as type to argument sender.
405 (ns_display_info_for_name): Add Lisp_Object argument.
406 (ns_term_init): Add Lisp_Object argument.
407 (ns_map_event_to_object): Add void argument.
408 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
409 prototype with arguments and only declare if __OBJC__.
410 (nxatoms_of_nsselect): Add void argument.
411 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
412 (ns_alloc_autorelease_pool): Add void argument.
413 (ns_release_autorelease_pool): Add void* argument.
414 (ns_get_defaults_value): Add const char* argument.
415
416 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
417 (initFromContents): Use SSDATA where appropriate.
418 (ns_update_menubar): Add braces to ambigous if-else.
419 (initWithTitle): Put () around assignment in if statement.
420 (ns_menu_show): Remove unused variables window and keymap.
421 (update_frame_tool_bar): Remove unused variable selected_p.
422 (initWithContentRect): Remove unused variable this_cmd_name.
423
424 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
425 appropriate.
426 (setXBMColor): Remove unused variable len.
427 (setPixmapData): Put () around assignment in loop statement.
428
429 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
430 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
431 where appropriate.
432 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
433 around assignment in loop statement.
434 (nsfont_open): Remove unused variable i.
435 (nsfont_open): Remove unused variable len.
436 (nsfont_draw): Remove unused variable cs.
437
438 * nsfns.m (x_set_icon_name, ns_set_name_internal)
439 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
440 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
441 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
442 (Fns_font_name, Fns_perform_service)
443 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
444 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
445 (ns_set_name): Remove unused variable view.
446 (x_set_menu_bar_lines): Remove unused variable olines.
447 (x_set_tool_bar_lines): Remove unused variable root_window.
448 (Fns_list_colors): Put () around assignment in while statement.
449 (Fns_perform_service): Remove unused variable len.
450 (Fns_display_usable_bounds): Remove unused variable top.
451 (syms_of_nsfns): Remove unused variable i.
452
b55b9f85
JD
453 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
454 memcpy (Bug#11907).
455
ed9265fc 4562012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
457
458 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
459 and free it with DestroyExceptionInfo (Bug#11558).
460
ef099b57
JB
4612012-07-13 Juanma Barranquero <lekktu@gmail.com>
462
463 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
464 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
465 Set here, not in nt/config.nt.
466
ea814a5d
EZ
4672012-07-13 Eli Zaretskii <eliz@gnu.org>
468
469 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
470 cursor overflow into the last glyph on display line when the right
471 fringe is off. (Bug#11832)
472
1a952767
PE
4732012-07-13 Paul Eggert <eggert@cs.ucla.edu>
474
475 * xdisp.c (produce_special_glyphs): Now static.
476 * dispextern.h (produce_special_glyphs): Remove decl.
477
983188fd
GM
4782012-07-13 Glenn Morris <rgm@gnu.org>
479
32fb4bb6
GM
480 * s/bsd-common, s/cygwin.h: Remove empty files.
481 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
482
983188fd
GM
483 * s/usg5-4-common.h (USG, USG5):
484 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
485 * s/sol2-6.h (SOLARIS2):
486 * s/irix6-5.h (IRIX6_5):
487 * s/hpux10-20.h (USG, USG5, HPUX):
488 * s/gnu-linux.h (USG, GNU_LINUX):
489 * s/freebsd.h (BSD_SYSTEM):
490 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
491 * s/cygwin.h (CYGWIN):
492 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
493 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
494
d1e68667 4952012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
496
497 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 498
6de0e799
GM
4992012-07-13 Glenn Morris <rgm@gnu.org>
500
739ae010
GM
501 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
502
dbee5793
GM
503 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
504
6de0e799
GM
505 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
506 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
507
b82da769
GM
5082012-07-12 Glenn Morris <rgm@gnu.org>
509
4fae5a7a 510 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
511
512 * process.c (init_process_emacs): Rename from init_process.
513 The old name is also the name of a Mach system call.
514 * lisp.h, emacs.c: Update for this name change.
515 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
516 longer needed.
517
5a979817
EZ
5182012-07-12 Eli Zaretskii <eliz@gnu.org>
519
520 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
521 memmove call that removes glyphs covered by the left truncation
522 glyph. Improve commentary.
523 (display_line): Fix display of continuation glyphs on GUI frames
524 when the right fringe is turned off and variable-size fonts are
525 used in the window. Move the code that appends a stretch glyph to
526 produce_special_glyphs, so that it could be used for truncation
527 and continuation glyphs alike.
528 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
529 glyph of a suitably computed width, to align the special glyphs at
530 the window margin. Code moved from display_line. (Bug#11832)
531
3e91a053
GM
5322012-07-12 Glenn Morris <rgm@gnu.org>
533
ba9e4b84
GM
534 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
535
536 * s/gnu-linux.h, s/hpux10-20.h:
537 Do not unconditionally define HAVE_XRMSETDATABASE.
538
3e91a053
GM
539 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
540
b300b1f4
PE
5412012-07-12 Paul Eggert <eggert@cs.ucla.edu>
542
543 Fix typos that broke OS X build.
544 Reported by Randal L. Schwartz in
545 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
546 * nsterm.m (ns_timeout): Add missing local decl.
547 (ns_get_color): snprintf -> sprintf, to fix typo.
548
6e777848
GM
5492012-07-12 Glenn Morris <rgm@gnu.org>
550
3f922c37
GM
551 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
552 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
553 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
554 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
555
0ab7b23a
GM
556 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
557 Move PTY_OPEN to configure.
558
6e777848
GM
559 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
560 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
561 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
562
4a7edc24
DA
5632012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
564
565 Use empty_unibyte_string where applicable.
566 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
567 * lread.c (read1): Likewise.
568 * xsettings.c (syms_of_xsettings): Likewise.
569
308aab79
GM
5702012-07-12 Glenn Morris <rgm@gnu.org>
571
42bd1719
GM
572 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
573 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
574 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
575 * s/hpux10-20.h (RUN_TIME_REMAP):
576 * s/bsd-common.h (TABDLY): Move to configure.
577
578 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
579
580 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
581
ea0bbd17 582 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 583 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
584
585 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 586
308aab79
GM
587 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
588 * s/template.h: Move NARROWPROTO to configure.
589
ee1cf5cf
GM
5902012-07-11 Glenn Morris <rgm@gnu.org>
591
30fe9bf4
GM
592 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
593 unused since 2011-01-17 change to systty.h.
594
ee1cf5cf
GM
595 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
596 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
597 Move HAVE_PTYS and HAVE_SOCKETS to configure.
598
63e47e07
PE
5992012-07-11 Paul Eggert <eggert@cs.ucla.edu>
600
601 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
602
c43fb4c3
GM
6032012-07-11 Glenn Morris <rgm@gnu.org>
604
605 * s/darwin.h, s/gnu-linux.h, s/template.h:
606 Move INTERRUPT_INPUT to configure.
607
e8df9267
DA
6082012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
609
610 Minor adjustments to interning code.
611 * lisp.h (intern, intern_c_string): Redefine as static inline
612 wrappers for intern_1 and intern_c_string_1, respectively.
613 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
614 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
615 Vobarray checking.
e8df9267
DA
616 * font.c (font_intern_prop): Likewise. Adjust comment.
617 * w32font.c (intern_font_name): Likewise.
618
34348bd4
AS
6192012-07-11 Andreas Schwab <schwab@linux-m68k.org>
620
d96a1e0c
AS
621 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
622
34348bd4
AS
623 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
624 of Fcar/Fcdr if possible.
625 * font.c (check_otf_features): Likewise.
626 * fontset.c (Fnew_fontset): Likewise.
627 * gnutls.c (Fgnutls_boot): Likewise.
628 * minibuf.c (read_minibuf): Likewise.
629 * msdos.c (IT_set_frame_parameters): Likewise.
630 * xmenu.c (Fx_popup_dialog): Likewise.
631 * w32menu.c (Fx_popup_dialog): Likewise.
632
c8add24e
GM
6332012-07-11 Glenn Morris <rgm@gnu.org>
634
4b575b3c
GM
635 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
636 since nothing has defined it on these platforms.
637
09f4e3b0
GM
638 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
639 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
640
172bedef
GM
641 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
642 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
643 Move CLASH_DETECTION to configure.
644
249685df
GM
645 * s/gnu.h: Remove file, which is now empty.
646
c8add24e
GM
647 * s/gnu.h, s/gnu-linux.h:
648 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
649
b41253a3
JW
6502012-07-11 John Wiegley <johnw@newartisans.com>
651
652 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
653 function attribute, so we only use it if it exists in the
654 compiler.
655
d923b542
DA
6562012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
657
658 Avoid call to strlen in fast_c_string_match_ignore_case.
659 * search.c (fast_c_string_match_ignore_case): Change to use
660 length argument. Adjust users accordingly.
661 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
662
5ebbef1d
PE
6632012-07-11 Paul Eggert <eggert@cs.ucla.edu>
664
bb352260
PE
665 Assume mkdir, rmdir.
666 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
667 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
668
57054ddd
PE
669 Assume rename.
670 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
671
b747d3f7
PE
672 Assume perror.
673 * s/hpux10-20.h (HAVE_PERROR): Remove.
674 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
675 Remove dummy definition, as this problem was obsolete long ago.
676
5ebbef1d
PE
677 Assume strerror.
678 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
679
984e7f30
DA
6802012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
681
682 Avoid calls to strlen in font processing functions.
683 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 684 (font_open_by_name): Change to use length argument. Adjust
984e7f30 685 users accordingly.
d923b542
DA
686 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
687 Adjust prototypes.
688 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
689 Change to return ptrdiff_t.
984e7f30
DA
690 (xfont_list_pattern, xfont_match): Use length returned by
691 xfont_decode_coding_xlfd.
692 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
693
20e94fdd
GM
6942012-07-11 Glenn Morris <rgm@gnu.org>
695
9d596af3
GM
696 * s/darwin.h, s/freebsd.h, s/netbsd.h:
697 Move DONT_REOPEN_PTY to configure.
698
20e94fdd
GM
699 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
700 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
701
e99a530f
PE
7022012-07-10 Paul Eggert <eggert@cs.ucla.edu>
703
22ffb973
PE
704 Remove "#define unix" that is no longer needed (Bug#11905).
705 * s/aix4-2.h (unix): Remove; no longer needed.
706
e9a9ae03
PE
707 EMACS_TIME simplification (Bug#11875).
708 This replaces macros (which typically do not work in GDB)
709 with functions, typedefs and enums, making the code easier to debug.
710 The functional style also makes code easier to read and maintain.
711 * systime.h: Include <sys/time.h> on all hosts, not just if
712 WINDOWSNT, since 'struct timeval' is needed in general.
713 (EMACS_TIME): Now a typedef, not a macro.
714 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
715 not macros.
716 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
717 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
718 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
719 (EMACS_TIME_LE): Now functions, not macros.
720 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
721 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
722 which are not functions. All uses rewritten to use:
723 (make_emacs_time): New function.
724 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
725 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
726 not functions. All uses rewritten to use the following, respectively:
727 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
728 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 729 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
730 * fileio.c (Fcopy_file):
731 * xterm.c (XTflash): Get the current time closer to when it's used.
732 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
733
ffacb126
PE
734 * bytecode.c (targets): Suppress -Woverride-init warnings.
735
e99a530f
PE
736 Simplify by avoiding confusing use of strncpy etc.
737 * doc.c (Fsnarf_documentation):
738 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
739 * frame.c (Fmake_terminal_frame):
740 * gtkutil.c (get_utf8_string):
741 * lread.c (openp):
742 * nsmenu.m (ns_update_menubar):
743 * regex.c (regerror):
744 Prefer memcpy to strncpy and strncat when either will do.
745 * fileio.c (Fsubstitute_in_file_name):
746 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
747 (menu_separator_name_p):
748 * nsmenu.m (ns_update_menubar):
749 Prefer memcmp to strncmp when either will do.
750 * nsterm.m: Include <ftoastr.h>.
751 (ns_get_color):
752 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
753 Prefer snprintf to strncpy.
754 * nsterm.m (ns_term_init):
755 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
756 * nsterm.m (ns_term_init):
757 Avoid the need for strncpy, by using build_string or
758 make_unibyte_string directly. Use dtoastr, not snprintf.
759 * process.c (Fmake_network_process): Diagnose service names that
760 are too long, rather than silently truncating them or creating
761 non-null-terminated names.
762 (Fnetwork_interface_info): Likewise, for interface names.
763 * sysdep.c (system_process_attributes) [GNU_LINUX]:
764 Prefer sprintf to strncat.
765 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
766 Prefer vsnprintf to vsprintf + strncpy.
767
c59592b3
GM
7682012-07-10 Glenn Morris <rgm@gnu.org>
769
770 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
771 Clarify fallback case.
772
7d7bbefd
DA
7732012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
774
775 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
776 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
777 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 778 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
779 where argument type is known to be a Lisp_Cons.
780
3a4c8000
TT
7812012-07-10 Tom Tromey <tromey@redhat.com>
782
783 * bytecode.c (BYTE_CODE_THREADED): New macro.
784 (BYTE_CODES): New macro. Replaces all old byte-code defines.
785 (enum byte_code_op): New type.
786 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
787 (exec_byte_code): Use them. Use token threading when applicable.
788
2a0213a6
DA
7892012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
790
791 Optimize pure C strings initialization.
792 * lisp.h (make_pure_string): Fix prototype.
793 (build_pure_c_string): New function, defined as static inline. This
794 provides a better opportunity to optimize away calls to strlen when
795 the function is called with compile-time constant argument.
796 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
797 argument, adjust users accordingly. Use build_pure_c_string where
798 appropriate.
799 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
800 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
801 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
802
cb1caeaf
DA
8032012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
804
805 Avoid calls to strlen in miscellaneous functions.
806 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
807 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
808 * lread.c (openp): Likewise.
809
c293e30c
DA
8102012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
811
812 Avoid calls to strlen in path processing functions.
813 * fileio.c (file_name_as_directory): Add comment. Change to add
814 srclen argument and return the length of result. Adjust users
815 accordingly.
816 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 817 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
818 users accordingly.
819 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
820
9e059e3f
GM
8212012-07-10 Glenn Morris <rgm@gnu.org>
822
d02eb359
GM
823 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
824 Move PENDING_OUTPUT_COUNT definition to configure.
825
882cf227
GM
826 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
827 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
828 * s/gnu.h (DATA_START): Move definitions to configure.
829
af6e839f
GM
830 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
831 We include usg5-4-common.h, which defines them both.
832
40289a12
GM
833 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
834 O_RDONLY already includes it).
835
9e059e3f
GM
836 Stop ns builds setting the EMACSLOADPATH environment variable.
837 * nsterm.m (ns_load_path): Rename from ns_init_paths.
838 Now it does not set EMACSLOADPATH, just returns the load-path string.
839 * nsterm.h: Update accordingly.
840 * lread.c [HAVE_NS]: Include nsterm.h.
841 (init_lread) [HAVE_NS]: Use ns_load_path.
842 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
843
7c4e8ec0
GM
8442012-07-09 Glenn Morris <rgm@gnu.org>
845
d4f600ff
GM
846 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
847 since the included bsd-common.h does so.
848
cbb31951
GM
849 Stop ns builds setting the EMACSPATH environment variable.
850 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
851 (ns_init_paths): Do not set EMACSPATH.
852 * nsterm.h (ns_exec_path): Add it.
853 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
854 Use ns_exec_path.
855
7c4e8ec0
GM
856 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
857
26bccfae
PE
8582012-07-09 Paul Eggert <eggert@cs.ucla.edu>
859
a0bee46f
PE
860 * process.c (wait_reading_process_output): 'waitchannels' was unset
861 when read_kbd || !NILP (wait_for_cell); fix this.
862
5994c183
PE
863 Add GCC-style 'const' attribute to functions that can use it.
864 * character.h (char_resolve_modifier_mask):
865 * keyboard.h (make_ctrl_char):
866 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
867 (init_character_once, next_almost_prime, init_fns, init_image)
868 (flush_pending_output, init_sound):
869 * mem-limits.h (start_of_data):
870 * menu.h (finish_menu_items):
871 Add ATTRIBUTE_CONST.
872 * emacs.c (DEFINE_DUMMY_FUNCTION):
873 Declare the dummy function with ATTRIBUTE_CONST.
874 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
875 Add decls with ATTRIBUTE_CONST.
876
26bccfae
PE
877 Minor improvements to make_formatted_string.
878 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
879 where int is good enough, as vsprintf returns an int.
880 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
881
a8290ec3
DA
8822012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
883
884 Use make_formatted_string to avoid double length calculation.
885 * lisp.h (make_formatted_string): New prototype.
886 * alloc.c (make_formatted_string): New function.
887 * buffer.c (Fgenerate_new_buffer_name): Use it.
888 * dbus.c (syms_of_dbusbind): Likewise.
889 * editfns.c (Fcurrent_time_zone): Likewise.
890 * filelock.c (get_boot_time): Likewise.
891 * frame.c (make_terminal_frame, set_term_frame_name)
892 (x_report_frame_params): Likewise.
893 * image.c (gs_load): Likewise.
894 * minibuf.c (get_minibuffer): Likewise.
895 * msdos.c (dos_set_window_size): Likewise.
896 * process.c (make_process): Likewise.
897 * xdisp.c (ensure_echo_area_buffers): Likewise.
898 * xsettings.c (apply_xft_settings): Likewise.
899
d01ba2f1
GM
9002012-07-09 Glenn Morris <rgm@gnu.org>
901
902 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
903 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
904 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
905 * nsterm.h (ns_etc_directory): Add it.
906 * callproc.c [HAVE_NS]: Include nsterm.h.
907 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
908
f1f924b6
DA
9092012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
910
911 Move marker debugging code under MARKER_DEBUG.
912 * marker.c (MARKER_DEBUG): Move marker debugging code under
913 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
914 for bootstrap with --enable-checking (~3x slowdown reported
915 by Juanma Barranquero <lekktu@gmail.com>).
916 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
917
ab531b66
PE
9182012-07-08 Paul Eggert <eggert@cs.ucla.edu>
919
920 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
921 See <http://bugs.gnu.org/11825#29>.
922
c4b3bc8a
EZ
9232012-07-08 Eli Zaretskii <eliz@gnu.org>
924
925 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
926 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
927 (display_line): Add commentary about displaying truncation glyphs
928 on GUI frames.
929 (produce_special_glyphs): Move here from term.c.
930
931 * term.c (produce_special_glyphs): Move to xdisp.c.
932
933 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
934 section.
c4b3bc8a 935
b676b881
AS
9362012-07-07 Andreas Schwab <schwab@linux-m68k.org>
937
f17c5273
AS
938 * xdisp.c (display_line): Avoid warning about implicit declaration
939 of FRAME_FONT.
940
298819b9
AS
941 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
942
b676b881
AS
943 * lisp.h: Remove empty conditional.
944
6045c4fd
PE
9452012-07-07 Paul Eggert <eggert@cs.ucla.edu>
946
b3350bf9
PE
947 * lread.c (load_path_check): Now static.
948
6045c4fd
PE
949 Fix some minor --with-ns problems found by static checking.
950 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
951 (x_set_font) [!HAVE_X_WINDOWS]:
952 * image.c (xpm_load_image) [HAVE_NS]:
953 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
954 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
955 Remove unused local.
956 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
957 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
958 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
959 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
960 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
961 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
962 Fix pointer signedness problem.
963 * xfaces.c (FRAME_X_FONT_TABLE):
964 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
965
929e7845
GM
9662012-07-07 Glenn Morris <rgm@gnu.org>
967
968 * lread.c (load_path_check): New function, split from init_lread.
969 (init_lread): Reorganize. Motivation:
970 If EMACSLOADPATH is set, check/warn about that rather than the
971 defaults, which we are not going to use. Hence we can remove
972 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
973 Don't warn if site-lisp directories are missing.
974 If not installed, start from a blank load-path, since
975 PATH_LOADSEARCH refers to the eventual installation directories.
976
58dd0aa4
EZ
9772012-07-07 Eli Zaretskii <eliz@gnu.org>
978
979 Support truncation and continuation glyphs on GUI frames, when
980 fringes are disabled. (Bug#11832)
981 * xdisp.c (init_iterator): Get dimensions of truncation and
982 continuation glyphs even if on GUI frames. Adjust
983 it->last_visible_x on GUI frames when the left or right fringes,
984 or both, are absent.
985 (start_display, move_it_in_display_line_to): Handle the case of a
986 GUI frame without a fringe to display continuation or truncation
987 glyphs.
988 (insert_left_trunc_glyphs): Support GUI frames: make sure
989 truncation glyphs overwrite enough glyphs from the current line to
990 have sufficient space in pixels.
991 (display_line): Support truncation and continuation glyphs on GUI
992 frames. If some spare pixels are left on the line after inserting
993 the truncation glyphs, fill that space with a stretch glyph of a
994 suitably computed width.
995
996 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
997 produce_glyphs, to support GUI sessions.
998
31571fd7
PE
9992012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1000
5a16b9bc
PE
1001 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1002
f3047c75
PE
1003 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1004
31571fd7
PE
1005 Do not require float-time's arg to fit in time_t (Bug#11825).
1006 This works better on hosts where time_t is unsigned, and where
1007 float-time is applied to the (negative) difference between two times.
1008 * editfns.c (decode_time_components): Last arg is now double *,
1009 not int *, and means to store all the result as a double, without
1010 worrying about whether the seconds part fits in time_t.
1011 All callers changed.
1012 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1013 All callers changed.
1014 (Ffloat_time): Do not fail merely because the specified time falls
1015 outside of time_t range.
1016
4516fbef
GM
10172012-07-07 Glenn Morris <rgm@gnu.org>
1018
1019 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1020 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1021 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1022
07adc2c6
JB
10232012-07-07 Juanma Barranquero <lekktu@gmail.com>
1024
1025 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1026 Update dependencies.
1027
1028 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1029
fd573f31
PE
10302012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1031
fee5959d
PE
1032 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1033 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1034 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1035 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1036 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1037 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1038
fd573f31
PE
1039 * xfont.c (compare_font_names): Redo to omit the need for casts.
1040
ddadbc0e
AS
10412012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1042
fca8d6b6
AS
1043 * xfns.c (Fx_change_window_property): Doc fix.
1044 * w32fns.c (Fx_change_window_property): Doc fix.
1045
ddadbc0e
AS
1046 * w32fns.c (Fx_window_property): Accept the same arguments as the
1047 X Windows version. Doc fix.
1048 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1049
ed9265fc 10502012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1051 Eli Zaretskii <eliz@gnu.org>
1052
1053 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1054 Windows-specific code from nt/config.nt moved here.
1055 Obsolete settings removed.
1056
216ee680
PE
10572012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1058
1059 * process.c: Avoid unnecessary calls to gettime.
1060 (wait_reading_process_output): Don't get the time of day
1061 when gobbling data immediately and not waiting, as there's no need
1062 for it in that case. This removes a FIXME.
1063
bdd091e4
JD
10642012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1065
1066 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1067 is defined (Bug#11768).
1068
9d44f8ce
DA
10692012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1070
1071 Fix marker debugging code.
1072 * marker.c (byte_char_debug_check): Do not perform the check
1073 if buffer is not multibyte.
090bd7cb
JB
1074 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1075 Call byte_char_debug_check with correct arguments.
9d44f8ce 1076
90fc4786
DA
10772012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1078
1079 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1080 * marker.c (byte_char_debug_check, count_markers):
1081 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1082 (byte_debug_flag): Remove.
1083 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1084 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1085
7b7ae965
DA
10862012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1087
4e57b342
DA
1088 Avoid code repetition in marker-related functions.
1089 * marker.c (attach_marker): New function.
1090 (Fset_marker, set_marker_restricted, set_marker_both)
1091 (set_marker_restricted_both): Use it.
1092 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1093 Consistently rename charno to charpos.
1094 (marker_position): Add eassert.
1095 (marker_byte_position): Convert to eassert.
1096
10972012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1098
1099 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1100 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1101 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1102
657924ff
DA
11032012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1104
1105 Introduce fast path for the widely used marker operation.
1106 * alloc.c (build_marker): New function.
1107 * lisp.h (build_marker): New prototype.
1108 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1109 * composite.c (autocmp_chars): Likewise.
1110 * editfns.c (buildmark): Remove.
1111 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1112 (save_restriction_save): Use build_marker.
1113 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1114 * window.c (save_window_save): Likewise.
1115
041a49a6
DA
11162012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1117
1118 Do not use Fdelete_overlay in delete_all_overlays
1119 to avoid redundant calls to unchain_overlay.
1120 * buffer.c (drop_overlay): New function.
1121 (delete_all_overlays, Fdelete_overlay): Use it.
1122 * minibuf.c (get_minibuffer): Fix comment.
1123
7dca65a4
PE
11242012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1125
1126 Port to OpenBSD 5.1 amd64.
1127 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1128 This is needed for OpenBSD, and should be harmless on all BSD systems.
1129 Also, include <sys/sysctl.h>, as it should be available on all
1130 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1131 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1132 use p_pid member, not kp_proc.pid.
1133
8eb876e2
GM
11342012-07-06 Glenn Morris <rgm@gnu.org>
1135
1136 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1137
38182d90
PE
11382012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1139
1140 More xmalloc and related cleanup.
1141 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1142 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1143 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1144 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1145 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1146 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1147 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1148 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1149 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1150 * xterm.c:
1151 Omit needless casts involving void * pointers and allocation.
1152 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1153 as the former is more robust if P's type is changed.
1154 Prefer xzalloc to xmalloc + memset 0.
1155 Simplify malloc-or-realloc to realloc.
1156 Don't worry about xmalloc returning a null pointer.
1157 Prefer xstrdup to xmalloc + strcpy.
1158 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1159 growing it.
1160 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1161 alloca of a constant.
1162
6dd5a677
EZ
11632012-07-05 Eli Zaretskii <eliz@gnu.org>
1164
1165 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1166 hscroll is larger than the line width. Fixes long and futile
1167 looping inside extend_face_to_end_of_line (on a TTY) producing
1168 glyphs that are not needed and thrown away.
1169
6b312f0f
DA
11702012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1171
1172 * marker.c (set_marker_restricted_both): Simplify by using
1173 clip_to_bounds.
1174
f520ef9b
PE
11752012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1176
1177 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1178
383b7c95
JD
11792012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1180
1181 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1182 not defined (Bug#11768).
1183 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1184 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1185 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1186 followed by gtk_box_set_homogeneous (Bug#11768).
1187 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1188 (update_theme_scrollbar_width, xg_create_scroll_bar):
1189 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1190 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1191 (is_box_type): New function (Bug#11768).
1192 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1193 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1194 with default display (Bug#11768).
1195
d6e7bf45
EZ
11962012-07-05 Eli Zaretskii <eliz@gnu.org>
1197
1198 * xdisp.c (window_hscroll_limited): New function.
1199 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1200 coordinates when window's hscroll is set to insanely large
1201 values. (Bug#11857)
1202
431391ec
JB
12032012-07-05 Juanma Barranquero <lekktu@gmail.com>
1204
1205 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1206 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1207
23f86fce
DA
12082012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1209
1210 Cleanup xmalloc.
1211 * lisp.h (xzalloc): New prototype. Omit needless casts.
1212 * alloc.c (xzalloc): New function. Omit needless casts.
1213 * charset.c: Omit needless casts. Convert all calls to
1214 xmalloc with following memset to xzalloc.
1215 * dispnew.c: Likewise.
1216 * fringe.c: Likewise.
1217 * image.c: Likewise.
1218 * sound.c: Likewise.
1219 * term.c: Likewise.
1220 * w32fns.c: Likewise.
1221 * w32font.c: Likewise.
1222 * w32term.c: Likewise.
1223 * xfaces.c: Likewise.
1224 * xfns.c: Likewise.
1225 * xterm.c: Likewise.
1226 * atimer.c: Omit needless casts.
1227 * buffer.c: Likewise.
1228 * callproc.c: Likewise.
1229 * ccl.c: Likewise.
1230 * coding.c: Likewise.
1231 * composite.c: Likewise.
1232 * doc.c: Likewise.
1233 * doprnt.c: Likewise.
1234 * editfns.c: Likewise.
1235 * emacs.c: Likewise.
1236 * eval.c: Likewise.
1237 * filelock.c: Likewise.
1238 * fns.c: Likewise.
1239 * gtkutil.c: Likewise.
1240 * keyboard.c: Likewise.
1241 * lisp.h: Likewise.
1242 * lread.c: Likewise.
1243 * minibuf.c: Likewise.
1244 * msdos.c: Likewise.
1245 * print.c: Likewise.
1246 * process.c: Likewise.
1247 * region-cache.c: Likewise.
1248 * search.c: Likewise.
1249 * sysdep.c: Likewise.
1250 * termcap.c: Likewise.
1251 * terminal.c: Likewise.
1252 * tparam.c: Likewise.
1253 * w16select.c: Likewise.
1254 * w32.c: Likewise.
1255 * w32reg.c: Likewise.
1256 * w32select.c: Likewise.
1257 * w32uniscribe.c: Likewise.
1258 * widget.c: Likewise.
1259 * xdisp.c: Likewise.
1260 * xmenu.c: Likewise.
1261 * xrdb.c: Likewise.
1262 * xselect.c: Likewise.
1263
0497dc44
PE
12642012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1265
1266 * fileio.c (time_error_value): Check the right error number.
1267 Problem reported by Troels Nielsen in
1268 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1269
356e7178
PE
12702012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1271
4e71fd89
PE
1272 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1273 This should be fixed in a better way; see Eli Zaretskii in
1274 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1275 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1276
f0941253
PE
1277 * fileio.c (time_error_value): Rename from special_mtime.
1278 The old name's problems were noted by Eli Zaretskii in
1279 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1280
065c9eb4
PE
1281 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1282 This variable's comment says Emacs needs at least one GDB-visible
1283 symbol of type enum pvec_type, to work around GDB problems.
1284 The symbol's value doesn't matter.
1285
356e7178
PE
1286 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1287 that causes compilation to fail on pre-C99 compilers.
1288
ed9265fc 12892012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1290
1291 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1292 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1293
3884d954
DA
12942012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1295
d209e2fb 1296 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1297 headers for buffer_defaults and buffer_local_symbols.
1298 Reported by Juanma Barranquero <lekktu@gmail.com>.
1299
ee28be33
SM
13002012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1301
1302 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1303 * lisp.h (enum pvec_type): Use fewer bits.
1304 (PSEUDOVECTOR_SIZE_BITS): New constant.
1305 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1306 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1307 change in pvec_type.
1308 (PSEUDOVECTOR_TYPEP): New macro.
1309 (TYPED_PSEUDOVECTORP): Use it.
1310 * fns.c (internal_equal): Adapt code to extract pvectype.
1311 * emacs.c (gdb_pvec_type): Update type.
1312 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1313 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1314 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1315 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1316 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1317 abusing vector->header.next.nbytes.
1318 (live_vector_p): Use PVEC_TYPE.
1319 (mark_object): Adapt code to extract pvectype. Use switch.
1320
c7f2cd7f
PE
13212012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1322
1323 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1324 Tighten new eassert a bit.
1325
8ce70ed2
DA
13262012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1327
1328 Fix compilation with --enable-gcc-warnings and -O1
1329 optimization level.
1330 * doprnt.c (doprnt): Change type of tem to int, initialize
1331 to avoid compiler warning. Add eassert.
1332 * search.c (simple_search): Initialize match_byte to avoid
1333 compiler warning. Add eassert.
1334
dea7f1e5
PE
13352012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1336
24a212eb
PE
1337 Avoid weird behavior with large horizontal scrolls.
1338 Without this change, for example, large hscroll values would
1339 mess up Emacs's display on Fedora 15 x86, presumably due to
1340 overflows in int calculations in the display code.
1341 Also, if buffers had long lines, Emacs would freeze.
1342 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1343 (set_window_hscroll): New function, containing the old guts of
1344 Fset_window_hscroll. Return the clipped value.
1345 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1346 This avoids the need to check against PTRDIFF_MAX.
1347
dea7f1e5
PE
1348 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1349
76046526
DA
13502012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1351
1352 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1353
39adff0d
PE
13542012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1355
63807d47
PE
1356 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1357 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1358 since GCC 4.4.6 issues a bogus warning for them.
1359
39adff0d
PE
1360 Fix bugs in file timestamp newness comparisons.
1361 * fileio.c (Ffile_newer_than_file_p):
1362 * lread.c (Fload): Use full timestamp resolution of files,
1363 not just the 1-second resolution, so that files that are only
1364 slightly newer still count as newer.
1365 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1366 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1367
dbeed9a6
PE
13682012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1369
1370 * fileio.c: Improve handling of file time marker. (Bug#11852)
1371 (special_mtime): New function.
1372 (Finsert_file_contents, Fverify_visited_file_modtime):
1373 Use it to set special mtime values consistently.
1374
636334d6
AS
13752012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1376
1377 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1378 marker for non-existing file. (Bug#11852)
1379
e2017fe2
GM
13802012-07-03 Glenn Morris <rgm@gnu.org>
1381
1382 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1383 and did not make it into globals.h).
1384
404dbd37
TT
13852012-07-03 Tom Tromey <tromey@redhat.com>
1386
1387 * window.c (Fset_window_margins, Fset_window_fringes)
1388 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1389 * textprop.c (Fprevious_property_change): No longer static.
1390 * syntax.c (Fsyntax_table_p): No longer static.
1391 * process.c (Fget_process, Fprocess_datagram_address): No longer
1392 static.
1393 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1394 * keyboard.c (Fcommand_execute): No longer static.
1395 Remove EXFUN.
1396 * insdel.c (Fcombine_after_change_execute): No longer static.
1397 * image.c (Finit_image_library): No longer static.
1398 * fileio.c (Fmake_symbolic_link): No longer static.
1399 * eval.c (Ffetch_bytecode): No longer static.
1400 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1401 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1402 No longer static.
404dbd37
TT
1403 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1404 static.
1405 * dired.c (Ffile_attributes): No longer static.
1406 * composite.c (Fcomposition_get_gstring): No longer static.
1407 * callproc.c (Fgetenv_internal): No longer static.
1408
1409 * ccl.h: Remove EXFUNs.
1410 * buffer.h: Remove EXFUNs.
1411 * dispextern.h: Remove EXFUNs.
1412 * intervals.h: Remove EXFUNs.
1413 * fontset.h: Remove EXFUN.
1414 * font.h: Remove EXFUNs.
1415 * dosfns.c (system_process_attributes): Remove EXFUN.
1416 * keymap.h: Remove EXFUNs.
1417 * lisp.h: Remove EXFUNs.
1418 * w32term.h: Remove EXFUNs.
1419 * window.h: Remove EXFUNs.
1420 * xsettings.h: Remove EXFUN.
1421 * xterm.h: Remove EXFUN.
1422
8e4fd1e1
GM
14232012-07-03 Glenn Morris <rgm@gnu.org>
1424
1425 * lisp.h (Frandom): Make it visible to C.
1426 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1427 buffer for invisible buffers. (Bug#1229)
1428
ca95b3eb
DA
14292012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1430
1431 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1432 values which aren't power of 2.
1433 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1434 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1435 accordingly.
1436
7555c33f
SM
14372012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1438
1439 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1440
1441 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1442
d12e8f5a
DA
14432012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1444
1445 * alloc.c (allocate_vector_block): Remove redundant
1446 calls to mallopt if DOUG_LEA_MALLOC is defined.
1447 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1448 avoid calls to mallopt if zero_vector is returned.
1449
296094c3
DA
14502012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1451
1452 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1453 is enabled, avoid dereferencing NULL current_sblock if
1454 running undumped.
1455
36429c89
DA
14562012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1457
1458 Cleanup basic buffer management.
1459 * buffer.h (struct buffer): Change layout to use generic vector
1460 marking code. Fix some comments. Change type of 'clip_changed'
1461 to bitfield. Remove unused #ifndef old.
1462 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1463 (GET_OVERLAYS_AT): Fix indentation.
1464 (for_each_per_buffer_object_at): New macro.
1465 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1466 (Fbuffer_local_variables): Use it.
1467 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1468 * alloc.c (allocate_buffer): Adjust to match new layout of
1469 struct buffer. Fix comment.
1470 (mark_overlay): New function.
1471 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1472 Lisp area of struct buffer.
1473 (mark_object): Use it. Adjust marking of misc objects
1474 and related comments.
1475
3b3e4cac
PE
14762012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1477
1478 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1479 wrapper that is not needed because the wrapped code is a no-op (zero
1480 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1481 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1482
cf5c0175
DA
14832012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1484
1485 * alloc.c (mark_buffer): Simplify. Remove prototype.
1486 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1487 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1488 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1489 redundant calls to mark_vectorlike for bool vectors.
1490
ca26824c
GM
14912012-06-30 Glenn Morris <rgm@gnu.org>
1492
2e4c5312
GM
1493 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1494
ca26824c
GM
1495 * epaths.in (PATH_SITELOADSEARCH): New.
1496 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1497 This is rather than relying on --enable-locallisppath elements
1498 having "site-lisp" in their names. (Bug#10208#25, 11658)
1499
0d23c240
EZ
15002012-06-30 Eli Zaretskii <eliz@gnu.org>
1501
c9240d7a
EZ
1502 * w32proc.c (sys_select): Accept and ignore one more argument.
1503
1504 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1505
0d23c240 1506 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1507 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1508
1509 * sysdep.c: Don't include dos.h and dosfns.h.
1510
1511 * process.c (sys_select):
1512 * msdos.c (sys_select): Accept one more argument and ignore it.
1513
1514 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1515 adapt data types and code to that.
1516
1517 * dosfns.c:
1518 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1519 which clashes with the gnulib function of the same name.
1520
af5a5a98
AS
15212012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1522
c5e4379c
AS
1523 * font.c (font_style_to_value, font_style_symbolic)
1524 (font_prop_validate_style): Add type checks for values in
1525 font_style_table.
1526
af5a5a98
AS
1527 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1528 argument.
1529 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1530 uses.
1531
8d38f461
EZ
15322012-06-29 Eli Zaretskii <eliz@gnu.org>
1533
2e5a6631
EZ
1534 * xdisp.c (try_window_id): Undo last change.
1535
8d38f461
EZ
1536 * w32.c (getwd): Adjust commentary about startup_dir.
1537 (init_environment): Always call sys_access, even in non-MSVC
1538 builds. Don't chdir to the directory of the Emacs executable.
1539 This undoes code from 1997 which was justified by the need to
1540 "avoid conflicts when removing and renaming directories". But its
1541 downside was that every relative file name was being interpreted
1542 relative to the directory of the Emacs executable, which can never
1543 be TRT. In particular, it broke sys_access when called with
1544 relative file names.
1545 (sys_access): Map GetLastError to errno.
1546
2af3565e
DA
15472012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1548
1549 * window.h (struct window): Change type of 'fringes_outside_margins'
1550 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1551 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1552 Adjust comment.
1553 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1554 to ptrdiff_t.
1555
c8d3a25c 15562012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1557
c8d3a25c
GM
1558 * gnutls.c (emacs_gnutls_handshake):
1559 Add QUIT to make the loop interruptible.
57570cd3 1560
c8d3a25c 15612012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1562
c8d3a25c
GM
1563 * charset.c (init_charset): Make lack of etc/charsets fatal.
1564
3e984ee8
DA
15652012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1566
1567 * editfns.c (region_limit): Fix type mismatch.
1568
ef884f23
DA
15692012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1570
1571 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1572 undefined. Convert from xassert to eassert.
1573 * nsmenu.m: Convert from xassert to eassert.
1574 * nsterm.m: Likewise.
1575
7d7e0027
SM
15762012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1577
1578 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1579
aa754e6a
PE
15802012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1581
1582 Avoid integer overflow on scroll-left and scroll-right.
1583 * window.c (HSCROLL_MAX): New macro.
1584 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1585 overflow when requested scroll falls outside ptrdiff_t range.
1586
80b00b08
DA
15872012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1588
1589 * window.h (struct window): Change type of 'hscroll',
1590 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1591 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1592 Adjust users accordingly.
1593 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1594 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1595 from EMACS_INT to ptrdiff_t.
1596 (make_window): Omit redundant initialization.
1597
62b2bcf6
JB
15982012-06-28 Juanma Barranquero <lekktu@gmail.com>
1599
1600 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1601
45942c7d
DA
16022012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1603
1604 * window.h (struct window): Change type of 'use_time' and
1605 'sequence_number' from Lisp_Object to int.
1606 * frame.c (make_frame): Adjust users accordingly.
1607 * print.c (print_object): Likewise.
1608 * window.c (select_window, Fwindow_use_time, make_parent_window)
1609 (make_window): Likewise.
1610
e509cfa6
DA
16112012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1612
1613 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1614 enabled with --enable-checking=[all,glyphs] configure option.
1615 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1616 adjust comments accordingly.
1617 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1618 undefined, adjust comments accordingly.
1619 * image.c: Likewise.
1620 * scroll.c: Likewise.
1621 * w32fns.c: Likewise.
1622 * w32term.c: Likewise.
1623 * xdisp.c: Likewise.
1624 * xfaces.c: Likewise.
1625 * xfns.c: Likewise.
1626 * xterm.c: Likewise.
1627
a54e2c05
DA
16282012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1629
1630 Generalize run-time debugging checks.
1631 * dispextern.h (XASSERTS): Remove.
1632 * fontset.c (xassert): Remove.
1633 Convert from xassert to eassert.
1634 * alloc.c: Convert from xassert to eassert.
1635 * bidi.c: Likewise.
1636 * dispnew.c: Likewise.
1637 * fns.c: Likewise.
1638 * fringe.c: Likewise.
1639 * ftfont.c: Likewise.
1640 * gtkutil.c: Likewise.
1641 * image.c: Likewise.
1642 * keyboard.c: Likewise.
1643 * menu.c: Likewise.
1644 * process.c: Likewise.
1645 * scroll.c: Likewise.
1646 * sound.c: Likewise.
1647 * term.c: Likewise.
1648 * w32console.c: Likewise.
1649 * w32fns.c: Likewise.
1650 * w32term.c: Likewise.
1651 * window.c: Likewise.
1652 * xdisp.c: Likewise.
1653 * xfaces.c: Likewise.
1654 * xfns.c: Likewise.
1655 * xselect.c: Likewise.
1656 * xterm.c: Likewise.
1657
1ec4b7b2
SM
16582012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1659
1660 * fns.c (maybe_resize_hash_table): Output message when growing the
1661 purify-hashtable.
1662
2014308a
DA
16632012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1664
1665 * alloc.c (allocate_string_data): Remove dead code.
1666 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1667 avoid GCC warning about unused macro.
1668
246155eb
DA
16692012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1670
1671 * alloc.c (allocate_string): Omit intervals initialization.
1672 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1673 as in make_pure_string and make_pure_c_string.
1674
43184b7b
DA
16752012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1676
d209e2fb 1677 * alloc.c (allocate_string): Fix last change.
43184b7b 1678
3fe6dd74
DA
16792012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1680
d209e2fb 1681 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1682 to memset, add explicit initialization where appropriate.
1683
1ba6038a
GM
16842012-06-27 Glenn Morris <rgm@gnu.org>
1685
1686 * lisp.mk (lisp): Remove paths.elc.
1687
c89926a5
CY
16882012-06-27 Chong Yidong <cyd@gnu.org>
1689
1690 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1691
ed6b3510
JW
16922012-06-26 John Wiegley <johnw@newartisans.com>
1693
1ec4b7b2 1694 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1695 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1696
ed6b3510
JW
1697 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1698 when building with Clang.
1699
8edd4a2b
SM
17002012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1701
1702 * eval.c (Fapply): Allow calling it with a single argument.
1703
f6f62d1b
EZ
17042012-06-26 Eli Zaretskii <eliz@gnu.org>
1705
1706 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1707 _stricmp and _strnicmp.
1708 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1709
62efea5e
DA
17102012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1711
1712 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1713 allocated window.
1714 (allocate_process): Likewise for new process.
8edd4a2b 1715 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1716 (allocate_frame): Likewise.
1717 * frame.c (make_frame): Omit redundant initialization.
1718 * window.c (make_parent_window): Use memset.
1719 (make_window): Omit redundant initialization.
1720 * process.c (make_process): Omit redundant initialization.
1721 * terminal.c (create_terminal): Likewise.
1722
42997f4d
DA
17232012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1724
1725 * term.c (delete_tty): Remove redundant call to memset.
1726
1130ecfc
DA
17272012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1728
1729 * alloc.c: Remove build_string.
1730 * lisp.h: Define build_string as static inline. This provides
1731 a better opportunity to optimize away calls to strlen when the
1732 function is called with compile-time constant argument.
1733 * image.c (imagemagick_error): Convert to build_string.
1734 * w32proc.c (sys_spawnve): Likewise.
1735 * xterm.c (x_term_init): Likewise.
1736
cf38a720
PE
17372012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1738
99027bdd
PE
1739 Use sprintf return value instead of invoking strlen on result.
1740 In the old days this wasn't portable, since some sprintf
1741 implementations returned char *. But they died out years ago and
1742 Emacs already assumes sprintf returns int.
1743 Similarly for float_to_string.
1744 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1745 * ccl.c (ccl_driver):
1746 * character.c (string_escape_byte8):
1747 * data.c (Fnumber_to_string):
1748 * doprnt.c (doprnt):
1749 * print.c (print_object):
1750 * xdisp.c (message_dolog):
1751 * xfns.c (syms_of_xfns):
1752 Use sprintf or float_to_string result to avoid need to call strlen.
1753 * data.c (Fnumber_to_string):
1754 Use make_unibyte_string, since the string must be ASCII.
1755 * lisp.h, print.c (float_to_string): Now returns int length.
1756 * term.c (produce_glyphless_glyph):
1757 Use sprintf result rather than recomputing it.
1758
cf38a720
PE
1759 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1760 * Makefile.in (ALL_CFLAGS):
1761 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1762 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1763
3511c784
DA
17642012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1765
0a08eb21 1766 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1767 strcasecmp if available.
1768 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1769
fb7da12e
AS
17702012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1771
1772 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1773 Avoid comma operator.
1774 * menu.c (push_submenu_start, push_submenu_end)
1775 (push_left_right_boundary, push_menu_pane): Likewise.
1776 * msdos.c (dos_rawgetc): Likewise.
1777
afa2ffd8
DA
17782012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1779
1780 * xfns.c (xic_create_fontsetname): Remove redundant calls
1781 to memset.
1782
b3b4476b
PE
17832012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1784
4495ff38
PE
1785 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1786 sprintf already null-terminates its output.
1787
b3b4476b
PE
1788 * xfns.c (x_window): Remove redundant cast.
1789
b00876c9
DA
17902012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1791
1792 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1793 `const char *' to `char *' to avoid compiler warning.
1794
d188e26b
PE
17952012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1796
885d1d74
PE
1797 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1798 instead of truncating it to 63 (admittedly a generous limit).
1799
d188e26b
PE
1800 * process.c: Fix spelling and caps in comments.
1801
e2f560b1
DN
18022012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1803
e86db54b 1804 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1805 * sysdep.c (setpgrp): Remove definition, not used in this file.
1806
7583a3a1
JB
18072012-06-24 Juanma Barranquero <lekktu@gmail.com>
1808
1809 * makefile.w32-in: Update dependencies.
1810
696056c2
EZ
18112012-06-24 Eli Zaretskii <eliz@gnu.org>
1812
1813 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1814 (SYSTIME_H): Add nt/inc/sys/time.h.
1815
1816 * systime.h [WINDOWSNT]: Include sys/time.h.
1817
1818 * s/ms-w32.h (struct timespec): Definition moved from
1819 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1820
845ca893
PE
18212012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1822
1823 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1824 * buffer.h (buffer_slot_type_mismatch):
1825 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1826 * eval.c (unwind_to_catch):
1827 * image.c (my_png_error, my_error_exit):
1828 * keyboard.c (quit_throw_to_read_char, user_error)
1829 (Fexit_recursive_edit, Fabort_recursive_edit):
1830 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1831 (wrong_type_argument, buffer_overflow, __executable_start)
1832 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1833 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1834 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1835 (fatal):
1836 (child_setup) [!DOS_NT]:
1837 * lread.c (end_of_file_error, invalid_syntax):
1838 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1839 * puresize.h (pure_write_error):
1840 * search.c (matcher_overflow):
1841 * sound.c (sound_perror, alsa_sound_perror):
1842 * sysdep.c, syssignal.h (croak):
1843 * term.c (maybe_fatal, vfatal):
1844 * textprop.c (text_read_only):
1845 * undo.c (user_error):
1846 * unexmacosx.c (unexec_error):
1847 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1848 Use _Noreturn rather than NO_RETURN.
1849 No need for separate decl merely because of _Noreturn.
1850 * sound.c (sound_warning, parse_sound):
1851 Remove unnecessary forward decls.
1852
f1dd8073
PE
18532012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1854
1855 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1856 * lisp.h (WAIT_READING_MAX): New macro.
1857 * dispnew.c (Fsleep_for, sit_for):
1858 * keyboard.c (kbd_buffer_get_event):
1859 * process.c (Faccept_process_output):
1860 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1861 This improves on the previous patch, which introduced a bug
1862 when time_t is unsigned and as wide as intmax_t.
1863 See <http://bugs.gnu.org/9000#51>.
1864
b82c1755
EZ
18652012-06-23 Eli Zaretskii <eliz@gnu.org>
1866
1867 * dispnew.c (sit_for, Fsleep_for):
1868 * keyboard.c (kbd_buffer_get_event):
1869 * process.c (Faccept_process_output): Avoid compiler warnings when
1870 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1871
ca300656
JB
18722012-06-23 Juanma Barranquero <lekktu@gmail.com>
1873
049ec95b
JB
1874 * makefile.w32-in: Update dependencies.
1875
ca300656
JB
1876 * w32.c (ltime): Add return type and declare static.
1877 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1878
db7b8d06
PE
18792012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1880
1881 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1882 Privately reported by Herbert J. Skuhra.
1883 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1884 All uses changed.
1885 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1886 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1887
0bd8297f
EZ
18882012-06-23 Eli Zaretskii <eliz@gnu.org>
1889
96512555
EZ
1890 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1891 last argument of make_unibyte_string.
1892
0bd8297f
EZ
1893 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1894 language ID in the event parameters.
1895
1896 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1897 event.code, not the obscure "character set ID".
1898
63def6b6
CY
18992012-06-23 Chong Yidong <cyd@gnu.org>
1900
1901 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1902
e8a02204
EZ
19032012-06-23 Eli Zaretskii <eliz@gnu.org>
1904
388cdec0
EZ
1905 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1906 * w32.c (fdutimens): New function.
1907
1908 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1909
1910 * s/ms-w32.h (pselect): Redirect to sys_select.
1911
1912 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1913
e8a02204
EZ
1914 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1915 in the logic of incrementing and decrementing the value of
1916 use_relocatable_buffers.
1917
d054f3fb
PE
19182012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1919
1920 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1921 Privately reported by Herbert J. Skuhra.
1922 [__FreeBSD__]: Remove "*/" typo after "#include".
1923 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1924 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1925 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1926 Don't assume EMACS_TIME and struct timeval are the same type.
1927
d35af63c
PE
19282012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1929
1930 Support higher-resolution time stamps (Bug#9000).
1931 The time stamps are only nanosecond-resolution at the C level,
1932 since that's the best that any real-world system supports now.
1933 But they are picosecond-resolution at the Lisp level, as that's
1934 easy, and leaves room for future OS improvements.
1935
1936 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1937 (LIBES): Use it.
1938
1939 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1940 Don't get current time unless it's needed.
1941
1942 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1943 now provides it if it's absent.
1944 (start_atimer): Port to higher-res time stamps.
1945 Check for time stamp overflow. Don't get current time more
1946 often than is needed.
1947
1948 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1949 Include systime.h, not time.h.
1950 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1951
1952 * dired.c: Include stat-time.h.
1953 (Ffile-attributes): File times now have higher resolution.
1954
1955 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1956 (struct image): Timestamp now has higher resolution.
1957
1958 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1959 has at least microseconds now. All uses removed.
1960 (update_frame, update_single_window, update_window, update_frame_1)
1961 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1962
1963 * editfns.c (time_overflow): Now extern.
1964 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1965 (float-time, Fformat_time_string, Fcurrent_time_string)
1966 (Fcurrent_time_zone): Accept and generate higher-resolution
1967 time stamps.
1968 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1969 (decode_time_components, lisp_seconds_argument): New functions.
1970 (make_time): Now static.
1971 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1972 Report an error if the time is invalid, rather than having the caller
1973 do that.
1974
1975 * fileio.c: Include <stat-time.h>
1976 (Fcopy_file): Copy higher-resolution time stamps.
1977 Prefer to set the time stamp via a file descriptor if that works.
1978 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1979 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1980 (Fvisited_file_modtime, Fset_visited_file_modtime):
1981 Support higher-resolution time stamps.
1982
1983 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1984
1985 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1986
1987 * image.c (prepare_image_for_display, clear_image_cache)
1988 (lookup_image): Port to higer-resolution time stamps.
1989
1990 * keyboard.c (start_polling, bind_polling_period):
1991 Check for time stamp overflow.
1992 (read_char, kbd_buffer_get_event, timer_start_idle)
1993 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1994 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1995 Port to higher-resolution time stamps. Do not assume time_t is signed.
1996 (decode_timer): New function. Timers are now vectors of length 9,
1997 not 8, to accommodate the picosecond component.
1998 (timer_check_2): Use it.
1999
2000 * nsterm.m (select_timeout, timeval_subtract): Remove.
2001 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2002 as they're a bit more accurate and handle overflow better.
2003 (ns_select): Change prototype to be compatible with pselect.
2004 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2005 * nsterm.h (ns_select): Adjust prototype.
2006
2007 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2008 us-resolution time stamps.
2009 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2010
2011 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2012
2013 * lisp.h (time_overflow): New decl.
2014 (wait_reading_process_output): First arg is now intmax_t, not int,
2015 to accommodate larger waits.
2016
2017 * process.h (struct Lisp_Process.read_output_delay):
2018 Now counts nanoseconds, not microseconds.
2019 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2020 EMACS_HAS_USECS.
2021 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2022 (wait_reading_process_output):
2023 Port to ns-resolution time stamps.
2024 (Faccept_process_output, wait_reading_process_output):
2025 Check for time stamp overflow. Do not assume time_t is signed.
2026 (select_wrapper): Remove; we now use pselect.
2027 (Fprocess_attributes): Now generates ns-resolution time stamps.
2028
2029 * sysdep.c: Include utimens.h. Don't include utime.h
2030 or worry about struct utimbuf; gnulib does that for us now.
2031 (gettimeofday): Remove; gnulib provides a substitute.
2032 (make_timeval): New function.
2033 (set_file_times): Now sets ns-resolution time stamps.
2034 New arg FD; all uses changed.
2035 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2036 (system_process_attributes):
2037 Now returns ns-resolution time stamp. All uses changed.
2038 Check for time stamp overflow.
2039
2040 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2041 provides a substitute now.
2042
2043 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2044 since it guarantees struct timespec.
2045 (EMACS_TIME): Now struct timespec, so that we can support
2046 ns-resolution time stamps.
2047 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2048 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2049 (EMACS_USECS): Remove.
2050 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2051 so multiply the arg by 1000 before storing it.
2052 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2053 New macros.
2054 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2055 Port to ns-resolution time stamps.
2056 (EMACS_TIME_NEG_P): Remove; replaced by....
2057 (EMACS_TIME_SIGN): New macro.
2058 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2059 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2060 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2061 (make_timeval, make_lisp_time, decode_time_components): New decls.
2062 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2063 that it mishandled time_t overflow. You can't compare by subtracting!
2064 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2065 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2066
2067 * term.c: Include <sys/time.h>.
2068 (timeval_to_Time): New function, for proper overflow wraparound.
2069 (term_mouse_position, term_mouse_click): Use it.
2070
2071 * undo.c (record_first_change): Support higher-resolution time stamps
2072 in the undo buffer.
2073 (Fprimitive_undo): Use them when restoring time stamps.
2074
2075 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2076 (w32_get_internal_run_time):
2077 Port to higher-resolution Emacs time stamps.
2078 (ltime): Now accepts single 64-bit integer, as that's more convenient
2079 for callers.
2080
2081 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2082
2083 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2084 for compatibility with pselect. Support ns-resolution time stamps.
2085
2086 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2087
2088 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2089 Check for time stamp overflow, and support ns-resolution time stamps.
2090
2091 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2092 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2093 (timeval_subtract): Remove; no longer needed.
2094 (XTflash, XTring_bell, x_wait_for_event):
2095 Port to ns-resolution time stamps. Don't assume time_t is signed.
2096
b6a92dfe
CY
20972012-06-22 Chong Yidong <cyd@gnu.org>
2098
2099 * xdisp.c (x_consider_frame_title): Revert last change.
2100
d251c37c
EZ
21012012-06-22 Eli Zaretskii <eliz@gnu.org>
2102
2103 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2104 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2105 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2106 staticidx goes up to 1597 out of 1600 = 0x640.)
2107
f10deafb
PE
21082012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2109
2110 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2111 Otherwise, the umask might be mistakenly 0 while handling input signals.
2112
ec6de1e2
SM
21132012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2114
2115 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2116
28be1ada
DA
21172012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2118
2119 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2120 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2121 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2122 access to `contents' member of Lisp_Vector objects with AREF and ASET
2123 where appropriate.
2124
c6bf3022
CY
21252012-06-19 Chong Yidong <cyd@gnu.org>
2126
2127 * frame.c (delete_frame): When selecting a frame on a different
2128 text terminal, do not alter the terminal's top-frame.
2129
2130 * xdisp.c (format_mode_line_unwind_data): Record the target
2131 frame's selected window and its terminal's top-frame.
2132 (unwind_format_mode_line): Restore them.
2133 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2134 Callers changed.
2135 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2136 since tty frames can be explicitly named.
2137 (prepare_menu_bars): Likewise.
2138
2139 * term.c (Ftty_top_frame): New function.
2140
defd4196
PE
21412012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2142
2143 Port byte-code-meter to modern targets.
2144 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2145 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2146 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2147 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2148 (METER_1, METER_2): Simplify.
2149
1053a871
SM
21502012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2151
2152 * data.c (Fdefalias): Return `symbol' (bug#11686).
2153
b7e8d081
MR
21542012-06-18 Martin Rudalics <rudalics@gmx.at>
2155
2156 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2157 gets killed during executing of this function (Bug#11665).
2158 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2159 (Vkill_buffer_query_functions): In doc-string say that functions
2160 run by this hook should not change the current buffer.
2161
7ea2b339
PE
21622012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2163
2164 Fix recently-introduced process.c problems found by static checking.
2165 * process.c (write_queue_push, write_queue_pop, send_process):
2166 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2167 (write_queue_pop): Fix pointer signedness problem.
2168 (send_process): Remove unused local.
2169
96a313a1
CY
21702012-06-17 Chong Yidong <cyd@gnu.org>
2171
2172 * xdisp.c (redisplay_internal): No need to redisplay terminal
2173 frames that are not on top.
2174
20ca2e94
TN
21752012-06-17 Troels Nielsen <bn.troels@gmail.com>
2176
2177 * process.c (make_process): Initialize write_queue.
2178 (write_queue_push, write_queue_pop): New functions.
2179 (send_process): Use them to maintain correct ordering of process
2180 writes (Bug#10815).
2181
9a900ca9
PE
21822012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2183
310fbfa8
PE
2184 * lisp.h (eassert): Assume C89 or later.
2185 This removes the need for CHECK.
2186 (CHECK): Remove. Its comments about always evaluating its
2187 argument were confusing, as 'eassert' typically does not evaluate
2188 its argument.
2189
27bb1ca4
PE
2190 * coding.c (produce_chars): Use ptrdiff_t, not int.
2191
9a900ca9
PE
2192 * xterm.c (x_draw_underwave): Check for integer overflow.
2193 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2194
41b7f8bc 21952012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2196
2197 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2198 referenced (Bug#11583).
2199
9b0e3eba
AA
22002012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2201
2202 Implement wave-style variant of underlining.
2203 * dispextern.h (face_underline_type): New enum.
2204 (face): Add field for underline type.
2205 * nsterm.m (ns_draw_underwave): New function.
2206 (ns_draw_text_decoration): Use it.
2207 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2208 New functions.
2209 (x_draw_glyph_string): Use them.
2210 * xfaces.c (Qline, Qwave): New Lisp objects.
2211 (check_lface_attrs, merge_face_ref)
1053a871
SM
2212 (Finternal_set_lisp_face_attribute, realize_x_face):
2213 Handle wave-style underline face attributes.
9b0e3eba
AA
2214 * xterm.c (x_draw_underwave): New function.
2215 (x_draw_glyph_string): Use it.
2216
0fb52f11
JB
22172012-06-16 Juanma Barranquero <lekktu@gmail.com>
2218
2219 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2220 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2221 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2222 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2223 ($(BLD)/w32select.$(O)): Update dependencies.
2224
e5560ff7
AS
22252012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2226
2227 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2228 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2229 * character.c (_fetch_multibyte_char_p): Remove.
2230 * alloc.c: Include "character.h" before "buffer.h".
2231 * bidi.c: Likewise.
2232 * buffer.c: Likewise.
2233 * bytecode.c: Likewise.
2234 * callint.c: Likewise.
2235 * callproc.c: Likewise.
2236 * casefiddle.c: Likewise.
2237 * casetab.c: Likewise.
2238 * category.c: Likewise.
2239 * cmds.c: Likewise.
2240 * coding.c: Likewise.
2241 * composite.c: Likewise.
2242 * dired.c: Likewise.
2243 * dispnew.c: Likewise.
2244 * doc.c: Likewise.
2245 * dosfns.c: Likewise.
2246 * editfns.c: Likewise.
2247 * emacs.c: Likewise.
2248 * fileio.c: Likewise.
2249 * filelock.c: Likewise.
2250 * font.c: Likewise.
2251 * fontset.c: Likewise.
2252 * fringe.c: Likewise.
2253 * indent.c: Likewise.
2254 * insdel.c: Likewise.
2255 * intervals.c: Likewise.
2256 * keyboard.c: Likewise.
2257 * keymap.c: Likewise.
2258 * lread.c: Likewise.
2259 * macros.c: Likewise.
2260 * marker.c: Likewise.
2261 * minibuf.c: Likewise.
2262 * nsfns.m: Likewise.
2263 * nsmenu.m: Likewise.
2264 * print.c: Likewise.
2265 * process.c: Likewise.
2266 * regex.c: Likewise.
2267 * region-cache.c: Likewise.
2268 * search.c: Likewise.
2269 * syntax.c: Likewise.
2270 * term.c: Likewise.
2271 * textprop.c: Likewise.
2272 * undo.c: Likewise.
2273 * unexsol.c: Likewise.
2274 * w16select.c: Likewise.
2275 * w32fns.c: Likewise.
2276 * w32menu.c: Likewise.
2277 * window.c: Likewise.
2278 * xdisp.c: Likewise.
2279 * xfns.c: Likewise.
2280 * xmenu.c: Likewise.
2281 * xml.c: Likewise.
2282 * xselect.c: Likewise.
2283
2f07e6af
EZ
22842012-06-16 Eli Zaretskii <eliz@gnu.org>
2285
1053a871
SM
2286 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2287 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2288 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2289 row.
2290 (handle_face_prop): Use chunk-relative overlay string index when
2291 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2292 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2293 the rightmost. (Bug#11720)
2f07e6af 2294
29b83cec
AS
22952012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2296
2297 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2298 (CATEGORY_MEMBER): Enforce 1/0 value.
2299 * category.c (_temp_category_set): Remove.
2300
4c5501e9
EZ
23012012-06-16 Eli Zaretskii <eliz@gnu.org>
2302
2303 * window.c (Fdelete_other_windows_internal)
2304 (Fdelete_window_internal): Don't access frame's mouse highlight
2305 info of the initial frame. (Bug#11677)
2306
2b570124
PE
23072012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2308
e93864f9
PE
2309 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2310 Assume USE_2_TAGS_FOR_INTS.
2311 (xreload): Adjust $tagmask width to match recent lisp.h change.
2312
2b570124
PE
2313 Simplify lisp.h in minor ways that should not affect code.
2314 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2315 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2316 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2317 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2318 (INTTYPEBITS): New macro, for clarity.
2319 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2320 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2321 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2322 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2323 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2324
81755f69
JB
23252012-06-13 Juanma Barranquero <lekktu@gmail.com>
2326
2327 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2328
16192a57
GM
23292012-06-13 Glenn Morris <rgm@gnu.org>
2330
2331 * s/bsd-common.h (BSD4_3):
2332 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2333
646b5f55
AS
23342012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2335
2336 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2337 instead of union.
2338 (XLI, XIL): Define.
1053a871
SM
2339 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2340 Use them.
2341 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2342 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2343 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2344 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2345 * frame.c (delete_frame): Remove outdated comment.
2346 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2347 USE_LISP_UNION_TYPE.
2348 (Fw32_unregister_hot_key): Likewise.
2349 (Fw32_toggle_lock_key): Likewise.
2350 * w32menu.c (add_menu_item): Likewise.
2351 (w32_menu_display_help): Use XIL instead of checking
2352 USE_LISP_UNION_TYPE.
2353 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2354 (init_heap): Likewise.
2355 * w32term.c (w32_read_socket): Update comment.
2356
1d3823c9
GM
23572012-06-13 Glenn Morris <rgm@gnu.org>
2358
c62ff706
GM
2359 * s/usg5-4-common.h, src/s/unixware.h:
2360 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2361
1d3823c9
GM
2362 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2363
bfe3e0a2
PE
23642012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2365
2366 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2367 * alloc.c (make_number) [!defined make_number]:
2368 Remove, as lisp.h always defines this now.
2369 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2370 (roundup_size): Verify that it is a power of 2.
2371 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2372 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2373 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2374 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2375 USE_LSB_TAG now is always defined to be either 0 or 1.
2376 All uses changed.
2377 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2378 code works fine either way, and efficiency is not a concern here,
2379 as the union type is for debugging, not for production.
2380 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2381 Use an inline function on all platforms when using the union type,
2382 since this is simpler and 'static inline' can be used portably
2383 within Emacs now.
2384 (LISP_INITIALLY_ZERO): New macro.
2385 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2386 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2387
45fa9c0f
GM
23882012-06-12 Glenn Morris <rgm@gnu.org>
2389
b4492cba
GM
2390 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2391
2392 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2393
45fa9c0f
GM
2394 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2395 Move BROKEN_SIGIO to configure.
2396
2397 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2398 Move NO_TERMIO to configure.
2399
0e25d334
CY
24002012-06-12 Chong Yidong <cyd@gnu.org>
2401
2402 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2403 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2404 MagickExportImagePixels is undefined.
2405
43682bb6
PE
24062012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2407
2408 * image.c (imagemagick_load_image): Remove unused label.
2409
a9be7d2b
GM
24102012-06-11 Glenn Morris <rgm@gnu.org>
2411
2412 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2413 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2414 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2415 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2416
3017f87f
SM
24172012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2418
2419 * alloc.c (make_byte_code): New function.
2420 (Fmake_byte_code): Use it. Don't purify here.
2421 * lread.c (read1): Use it as well to avoid extra allocation.
2422
1b9b4cf4
CY
24232012-06-11 Chong Yidong <cyd@gnu.org>
2424
2425 * image.c (imagemagick_load_image): Implement transparency.
2426
95988fcf
AS
24272012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2428
2429 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2430 account for preceding backslashes. (Bug#11663)
2431
cd4eb164
CY
24322012-06-09 Chong Yidong <cyd@gnu.org>
2433
2434 * term.c: Support italics in capable terminals (Bug#9652).
2435 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2436 (turn_on_face): Output using TS_enter_italic_mode if available.
2437 Don't handle unused blinking and alt-charset cases.
2438 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2439 and tty_alt_charset_p cases.
2440 (tty_capable_p, init_tty): Support italics.
2441
2442 * termchar.h (struct tty_display_info): Add field for italics.
2443 Remove unused blink field.
2444
2445 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2446 Handle slant.
2447
2448 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2449 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2450 tty_alt_charset_p. Add tty_italic_p.
2451
ff88beb8
MA
24522012-06-09 Michael Albinus <michael.albinus@gmx.de>
2453
2454 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2455 dbus_type_is_basic if available.
2456 (xd_extract_signed, xd_extract_unsigned): Rename from
2457 extract_signed and extract_unsigned, respectively. Adapt callers.
2458
44286096
CY
24592012-06-09 Chong Yidong <cyd@gnu.org>
2460
1682701f
CY
2461 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2462
44286096
CY
2463 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2464 case (Bug#9752).
2465
d86feb17
PE
24662012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2467
2468 * xdisp.c (vmessage): Treat frame message as multibyte.
2469 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2470 would generate the diagnostic "Making \302\247 buffer-local while
2471 let-bound!".
2472
d5c20fe8
EZ
24732012-06-08 Eli Zaretskii <eliz@gnu.org>
2474
2475 * dispnew.c (showing_window_margins_p): Undo last change, which
2476 was done due to an inadvertent commit.
2477 (adjust_frame_glyphs_for_frame_redisplay): Do call
2478 showing_window_margins_p.
2479
513749ee
SM
24802012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2481
2482 * eval.c (Fmake_var_non_special): New primitive.
2483 (syms_of_eval): Defsubr it.
2484 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2485
d4a8f5c1
JB
24862012-06-08 Juanma Barranquero <lekktu@gmail.com>
2487
2488 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2489 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2490
8bbbc977
EZ
24912012-06-08 Eli Zaretskii <eliz@gnu.org>
2492
2493 * alloc.c (allocate_vectorlike): Fix last change.
2494
f3372c87
DA
24952012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2496
2497 Block-based vector allocation of small vectors.
2498 * lisp.h (struct vectorlike_header): New field `nbytes',
2499 adjust comment accordingly.
2500 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2501 to denote vector blocks. Adjust users (live_vector_p,
2502 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2503 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2504 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2505 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2506 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2507 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2508 (roundup_size): New constant.
2509 (struct vector_block): New data type.
2510 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2511 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2512 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2513 (sweep_vectors): New functions.
2514 (allocate_vectorlike): Return `zero_vector' as the only vector of
2515 0 items. Allocate new vector from block if vector size is less than
2516 or equal to VBLOCK_BYTES_MAX.
2517 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2518 (init_alloc_once): Add call to init_vectors.
2519
4f18a4ed
SM
25202012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2521
2522 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2523
86f158bc
PE
25242012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2525
2526 * doprnt.c (doprnt): Truncate multibyte char correctly.
2527 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2528 would mishandle a string argument "Xc" if X was a multibyte
2529 character of length 2: it would truncate after X's first byte
2530 rather than including all of X.
2531
c5cfcbe0
CY
25322012-06-06 Chong Yidong <cyd@gnu.org>
2533
2534 * buffer.c (word_wrap): Doc fix.
2535
c05cf390
PE
25362012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2537
2538 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2539
0c3461de
GM
25402012-06-03 Glenn Morris <rgm@gnu.org>
2541
2542 * xdisp.c (tool-bar-style): Doc fix.
2543
c71232db
UM
25442012-06-03 Ulrich Müller <ulm@gentoo.org>
2545
2546 * Makefile.in (PAXCTL): Define.
2547 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2548 binary via PaX flags if the paxctl utility is available.
2549 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2550 Restore PaX flags to their default. (Bug#11398)
2551
383f7350
CY
25522012-06-03 Chong Yidong <cyd@gnu.org>
2553
2554 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2555 buffer (Bug#11226).
2556
5f2c76c6
CY
25572012-06-03 Chong Yidong <cyd@gnu.org>
2558
2559 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2560 (note_mode_line_or_margin_highlight): If there is no help echo,
2561 use mode-line-default-help-echo. Handle the case where the mouse
2562 position is past the end of the mode line string.
2563
2564 * buffer.c (buffer_local_value_1): New function, split from
2565 Fbuffer_local_value; can return Qunbound.
2566 (Fbuffer_local_value): Use it.
2567 (Vmode_line_format): Docstring tweaks.
2568
773d47f6
PE
25692012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2570
2571 * sysdep.c (system_process_attributes): Improve comment.
2572
f2d6a3df
SM
25732012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2574
2575 * keyboard.c: Export real-this-command to Elisp.
2576 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2577 and DEFVAR it. Update all users.
2578
63810350
PE
25792012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2580
7bd5c1f4
PE
2581 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2582
63810350
PE
2583 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2584 Convert pctcpu and pctmem to Lisp float properly.
2585 Let the compiler fold better, as 100.0/0x8000 is exact.
2586
a2821611
AS
25872012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2588
2589 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2590 cons_block.
2591
5fceba1d
PE
25922012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2593
2594 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2595
c98ff5dd
DA
25962012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2597
2598 For a 'struct window', replace some Lisp_Object fields to
2599 bitfields where appropriate, remove unused fields.
2600 * window.h (struct window): Remove unused 'last_mark_x' and
2601 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2602 change it's type from Lisp_Object to bitfield.
2603 Change type of 'force_start', 'optional_new_start',
2604 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2605 fields from Lisp_Object to bitfield. Adjust users accordingly.
2606
ca34e0be
PE
26072012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2608
2609 Pacify gcc -Wdouble-precision when using Xaw.
2610 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2611 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2612 Use 'float' consistently, rather than 'float' in most places
2613 and 'double' in a couple of places.
2614
efc00ab1 26152012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2616
2617 * xdisp.c (handle_stop): Detect whether we have overlay strings
2618 loaded by testing it->current.overlay_string_index to be
2619 non-negative, instead of checking whether n_overlay_strings is
2620 positive. (Bug#11587)
2621
efc00ab1 26222012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2623
2624 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2625
2626 * doc.c (Fsubstitute_command_keys): Doc fix.
2627
efc00ab1 26282012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2629
2630 * search.c (search_buffer): Remove calls to
2631 r_alloc_inhibit_buffer_relocation, as it is now called by
2632 maybe_unify_char, which was the cause of relocation of buffer text
2633 in bug#11519.
2634
efc00ab1 26352012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2636
2637 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2638 for the duration of call to load_charset, to avoid problems with
2639 callers of maybe_unify_char that access buffer text through C
2640 pointers.
2641
2642 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2643 decrement the inhibition flag, instead of just setting or
2644 resetting it.
2645
ba93a187
PE
26462012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2647
2648 Remove obsolete '#define static' cruft.
2649 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2650 This #undef was "temporary" in 2000; it is no longer needed
2651 now that '#define static' has gone away.
2652 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2653 (gray_bitmap_bits): Remove; no longer needed.
2654 All uses replaced with definiens.
2655 * xterm.c: Include "bitmaps/gray.xbm".
2656
9e4bf381
PE
26572012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2658
2659 Clean up __executable_start, monstartup when --enable-profiling.
2660 The following changes affect the code only when profiling.
2661 * dispnew.c (__executable_start): Rename from safe_bcopy.
2662 Define only on platforms that need it.
2663 * emacs.c: Include <sys/gmon.h> when profiling.
2664 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2665 (__executable_start): Remove decl, since lisp.h does it now.
2666 (safe_bcopy): Remove decl; no longer has that name.
2667 (main): Coalesce #if into single bit of code, for simplicity.
2668 Cast pointers to uintptr_t, since standard libraries want integers
2669 and not pointers.
2670 * lisp.h (__executable_start): New decl.
2671
32d72c2f
GM
26722012-05-31 Glenn Morris <rgm@gnu.org>
2673
2674 * image.c (Fimagemagick_types): Doc fix.
2675
baac5bc7
JM
26762012-05-30 Jim Meyering <meyering@redhat.com>
2677
2678 * callproc.c (Fcall_process_region): Include directory component
2679 in mkstemp error message (Bug#11586).
2680
72cb32cf
PE
26812012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2682
2683 * alloc.c, lisp.h (make_pure_vector): Now static.
2684
61b108cc
SM
26852012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2686
2687 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2688 Move to byte-run.el.
2689 (Fautoload): Do the hash-doc more carefully.
2690 * data.c (Fdefalias): Purify definition, except for keymaps.
2691 (Qdefun): Move from eval.c.
2692 * lisp.h (Qdefun): Remove.
2693 * lread.c (read1): Tiny simplification.
2694
471fe23d
TN
26952012-05-29 Troels Nielsen <bn.troels@gmail.com>
2696
934f3f58 2697 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2698 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2699 Bug#9642, but explicitly check that the buffer the overlay would
2700 be moved to is live and rearrange lines to make sure that errors
2701 will not put the overlay in an inconsistent state.
2702 (Fdelete_overlay): Cosmetics.
2703
85d0efd1
EZ
27042012-05-28 Eli Zaretskii <eliz@gnu.org>
2705
2706 * w32term.c (my_bring_window_to_top): New function.
2707 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2708 could be different from the original one.
2709 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2710 (Bug#11513)
2711
2712 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2713 by calling BringWindowToTop.
2714
2715 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2716 (WM_EMACS_END): Increase by one.
2717
da92a98c
PE
27182012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2719
2720 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2721 This avoids undefined behavior that might cause the eassert
2722 to not catch an out-of-range value.
2723
74d1f848
JB
27242012-05-28 Juanma Barranquero <lekktu@gmail.com>
2725
2726 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2727 Update dependencies.
2728
9e1a06fc
EZ
27292012-05-27 Eli Zaretskii <eliz@gnu.org>
2730
2731 * bidi.c (bidi_mirror_char): Fix last change.
2732
f3dd7312
AS
27332012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2734
2735 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2736 when referring to sectname field in printf format.
2737
81899c91
PE
27382012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2739
57b81a9f
PE
2740 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2741 Only r_alloc_inhibit_buffer_relocation needed to be added;
2742 the others were already declared.
2743
81899c91
PE
2744 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2745 before checking whether it's out of range. Put the check inside
2746 eassert. See
2747 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2748
33017faf 27492012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2750
2751 * callproc.c (Fcall_process): Restore a line that was accidentally
2752 commented out in the 2011-02-13 change (bug#11547).
2753
33017faf 27542012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2755
2756 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2757 defined on ralloc.c.
2758
2759 * buffer.c [REL_ALLOC]: Remove prototypes of
2760 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2761 they are now on lisp.h.
2762
2763 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2764
2765 * search.c (search_buffer): Use it to inhibit relocation of buffer
2766 text while re_search_2 is doing its job, because re_search_2 is
2767 passed C pointers to buffer text. (Bug#11519)
2768
23415acf
EZ
2769 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2770 Update value to 24.
2771
44e27368
EZ
2772 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2773 state after an additional call to move_it_in_display_line_to, keep
2774 the values of it->max_ascent and it->max_descent found for the
2775 entire line.
2776 (pos_visible_p): Revert the comparison against bottom_y to what it
2777 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2778 (Bug#11464)
2779
c1892f11
PE
27802012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2781
2782 Fix coding-related core dumps with gcc -ftrapv.
2783 The code was computing A - B, where A and B are pointers, and B is
2784 random garbage. This can lead to core dumps on platforms that
2785 have special pointer registers, and it also leads to core dumps on
2786 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2787 A - B only when B is initialized properly.
2788 * coding.c (coding_set_source, coding_set_destination): Return void.
2789 (coding_change_source, coding_change_destinations): New functions,
2790 with the old behaviors of coding_set_source and coding_set_destination.
2791 All callers that need an offset changed to use these new functions.
2792
eb7afdad
GM
27932012-05-26 Glenn Morris <rgm@gnu.org>
2794
2795 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2796
f12fdf02
EZ
27972012-05-26 Eli Zaretskii <eliz@gnu.org>
2798
53a63be6 2799 Extend mouse support on W32 text-mode console.
61b108cc
SM
2800 * xdisp.c (draw_row_with_mouse_face):
2801 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2802
eb3f6f01 2803 * w32console.c: Include window.h.
61b108cc
SM
2804 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2805 New functions.
eb3f6f01
EZ
2806 (initialize_w32_display): Initialize mouse-highlight data.
2807
53a63be6
EZ
2808 * w32inevt.c: Include termchar.h and window.h.
2809 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2810 moves, call note_mouse_highlight. If help_echo changed, call
2811 gen_help_event to produce help-echo message in the echo area.
2812 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2813 highlight info.
2814
4cfd81f6
PE
28152012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2816
2817 * lread.c (read1): Simplify slightly to avoid an overflow warning
2818 with GCC 4.7.0 on x86-64.
2819
4446092a
EZ
28202012-05-26 Eli Zaretskii <eliz@gnu.org>
2821
2822 * bidi.c (bidi_mirror_char): Revert last change: an int is
2823 definitely wide enough here.
2824
42b2a986 28252012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2826
42b2a986 2827 Fix integer width and related bugs (Bug#9874).
eb106a49 2828 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2829 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2830 (string_bytes, check_sblock, allocate_string_data):
2831 (compact_small_strings, Fmake_bool_vector, make_string)
2832 (make_unibyte_string, make_multibyte_string)
2833 (make_string_from_bytes, make_specified_string)
2834 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2835 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2836 (mark_vectorlike):
2837 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2838 (allocate_pseudovector):
2839 Use int, not EMACS_INT, where int is wide enough.
2840 (inhibit_garbage_collection, Fgarbage_collect):
2841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2842 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2843 int might not be wide enough.
2844 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2845 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2846 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2847 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2848 (bidi_level_of_next_char, bidi_move_to_visually_next):
2849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2850 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2851 (Fkill_buffer, Fset_buffer_major_mode)
2852 (advance_to_char_boundary, Fbuffer_swap_text)
2853 (Fset_buffer_multibyte, overlays_at, overlays_in)
2854 (overlay_touches_p, struct sortvec, record_overlay_string)
2855 (overlay_strings, recenter_overlay_lists)
2856 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2857 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2858 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2859 (Foverlay_recenter, last_overlay_modification_hooks_used)
2860 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2862 (validate_region): Omit unnecessary test for b <= e,
2863 since that's guaranteed by the previous test.
d311d28c
PE
2864 (adjust_overlays_for_delete): Avoid pos + length overflow.
2865 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2866 (report_overlay_modification):
2867 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2868 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2869 Omit pointer cast, which isn't needed anyway, and doesn't work
2870 after the EMACS_INT -> ptrdiff_t change.
02481186 2871 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2872 * buffer.h: Adjust decls to match defn changes elsewhere.
2873 (struct buffer_text, struct buffer):
2874 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2875 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2876 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2877 not int, to avoid needless 32-bit limit on 64-bit hosts.
2878 (exec_byte_code): Use tighter memory-full test, one that checks
2879 for alloca overflow. Don't compute the address of the object just
2880 before an array, as that's not portable. Use EMACS_INT, not
2881 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2882 * callint.c (Fcall_interactively):
2883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2884 * callproc.c (call_process_kill, Fcall_process):
2885 Don't assume pid_t fits into an Emacs fixnum.
2886 (call_process_cleanup, Fcall_process, child_setup):
2887 Don't assume pid_t fits into int.
2888 (call_process_cleanup, Fcall_process, delete_temp_file)
2889 (Fcall_process_region):
2890 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2891 (Fcall_process): Simplify handling of volatile integers.
2892 Use int, not EMACS_INT, where int will do.
2893 * casefiddle.c (casify_object, casify_region, operate_on_word)
2894 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2895 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2896 (casify_object): Avoid integer overflow when overallocating buffer.
2897 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2898 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2899 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2900 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2901 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2902 integers are now checked earlier. All uses replaced with XINT.
2903 (ccl_driver):
2904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2905 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2906 (ccl_driver, Fregister_code_conversion_map):
2907 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2908 (resolve_symbol_ccl_program): Check that vector header is in range.
2909 Always copy the vector, so that we can check its contents reliably
2910 now rather than having to recheck each instruction as it's being
2911 executed. Check that vector words fit in 'int'.
2912 (ccl_get_compiled_code, Fregister_ccl_program)
2913 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2914 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2915 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2916 contents are in range.
2917 (Fccl_execute_on_string): Check that status is in range.
2918 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2919 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2920 Accept and return EMACS_INT, not int, because callers can pass values
2921 out of 'int' range.
2922 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2923 (multibyte_chars_in_text, parse_str_as_multibyte)
2924 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2925 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2926 (string_escape_byte8, Fget_byte):
2927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2928 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2929 avoid mishandling large integers.
2930 * character.h: Adjust decls to match defn changes elsewhere.
2931 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2932 (Ffind_charset_region):
2933 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2934 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2935 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2936 Don't assume fixnum fits in int.
d311d28c
PE
2937 (load_charset_map_from_vector, Fmap_charset_chars):
2938 Remove now-unnecessary CHECK_NATNUMs.
2939 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2940 Don't rely on undefined behavior with signed left shift overflow.
2941 Don't assume unsigned int fits into fixnum, or that fixnum fits
2942 into unsigned int. Don't require max_code to be a valid fixnum;
2943 that's not true for gb10830 4-byte on a 32-bit host. Allow
2944 invalid_code to be a cons, for the same reason. Require code_offset
2945 to be a character. Avoid int overflow if max_char is close
2946 to INT_MAX.
2947 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2948 this is intended anyway and avoids some undefined behavior.
2949 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2950 INDEX_TO_CODE_POINT, as that's what it expects.
2951 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2952 * charset.h (DECODE_CHAR): Return int, not unsigned;
2953 this is what was intended anyway, and it avoids undefined behavior.
2954 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2955 integer-overflow issues.
2956 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2957 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2958 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2959 * chartab.c (Fmake_char_table, Fset_char_table_range)
2960 (uniprop_get_decoder, uniprop_get_encoder):
2961 Don't assume fixnum fits in int.
2962 * cmds.c (move_point): New function, that does the gist of
2963 Fforward_char and Fbackward_char, but does so while checking
2964 for integer overflow more accurately.
c96e5d6a 2965 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2966 (Fforward_line, Fend_of_line, internal_self_insert)
2967 (internal_self_insert):
2968 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2969 Fix a FIXME, by checking for integer overflow when calculating
2970 target_clm and actual_clm.
2971 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2972 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2973 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2974 (coding_alloc_by_making_gap, alloc_destination)
2975 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2976 (encode_coding_utf_16, detect_coding_emacs_mule)
2977 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2978 (detect_coding_iso_2022, decode_coding_iso_2022)
2979 (encode_invocation_designation, encode_designation_at_bol)
2980 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2981 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2982 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2983 (encode_coding_ccl, encode_coding_raw_text)
2984 (detect_coding_charset, decode_coding_charset)
2985 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2986 (produce_composition, produce_charset, produce_annotation)
2987 (decode_coding, handle_composition_annotation)
2988 (handle_charset_annotation, consume_chars, decode_coding_gap)
2989 (decode_coding_object, encode_coding_object, detect_coding_system)
2990 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2991 (code_convert_region, code_convert_string)
8f50130c
PE
2992 (Fdefine_coding_system_internal)
2993 (coding_set_source, coding_set_destination):
d311d28c
PE
2994 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2995 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2996 (Fdefine_coding_system_internal):
2997 Don't assume fixnums fit in int.
2998 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2999 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3000 (Funencodable_char_position, Fcheck_coding_systems_region)
3001 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3002 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3003 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3004 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3005 Don't access memory outside of the args array.
d311d28c 3006 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3007 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3008 result of ENCODE_CHAR.
d311d28c
PE
3009 * coding.h: Adjust decls to match defn changes elsewhere.
3010 (struct coding_system):
3011 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3012 * composite.c (get_composition_id, find_composition)
3013 (run_composition_function, update_compositions)
3014 (compose_text, composition_gstring_put_cache)
3015 (composition_gstring_p, composition_gstring_width)
3016 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3017 (composition_compute_stop_pos, composition_reseat_it)
3018 (composition_update_it, struct position_record)
3019 (find_automatic_composition, composition_adjust_point)
3020 (Fcomposition_get_gstring, Ffind_composition_internal):
3021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3022 (update_compositions):
3023 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3024 * composite.h: Adjust decls to match defn changes elsewhere.
3025 (struct composition):
3026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3027 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3028 Do not attempt to compute the address of the object just before a
3029 buffer; this is not portable.
3030 (Faref, Faset):
3031 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3032 (Faset): Use int, not EMACS_INT, where int is wide enough.
3033 (Fstring_to_number): Don't assume fixnums fit in int.
3034 (Frem): Don't assume arg is nonnegative.
3035 * dbusbind.c (xd_append_arg): Check for integers out of range.
3036 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3037 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3038 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3039 (xd_get_connection_references): Return ptrdiff_t, not int.
3040 All uses changed.
3041 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3042 (xd_read_message_1):
3043 Use int, not unsigned, where the dbus API uses int.
3044 (Fdbus_message_internal): Don't overflow mtype.
3045 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3046 * dired.c (directory_files_internal, file_name_completion, scmp)
3047 (file_name_completion_stat):
3048 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3049 (file_name_completion): Don't overflow matchcount.
3050 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3051 * dispextern.h: Adjust decls to match defn changes elsewhere.
3052 (struct text_pos, struct glyph, struct bidi_saved_info)
3053 (struct bidi_string_data, struct bidi_it, struct composition_it)
3054 (struct it):
3055 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3056 (struct display_pos, struct composition_it, struct it):
3057 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3058 * dispnew.c (increment_matrix_positions)
3059 (increment_row_positions, mode_line_string)
3060 (marginal_area_string):
3061 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3062 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3063 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3064 (duration_to_sec_usec): New function, to check for overflow better.
3065 (Fsleep_for, sit_for): Use it.
3066 * doc.c (get_doc_string, store_function_docstring):
3067 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3068 (get_doc_string, Fsnarf_documentation):
3069 Use int, not EMACS_INT, where int is wide enough.
3070 (get_doc_string):
3071 Use SAFE_ALLOCA, not alloca.
3072 Check for overflow when converting EMACS_INT to off_t.
3073 * doprnt.c (doprnt):
3074 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3075 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3076 Don't assume uid_t fits into fixnum.
3077 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3078 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3079 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3080 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3081 (general_insert_function)
3082 (Finsert_char, make_buffer_string, make_buffer_string_both)
3083 (update_buffer_properties, Fbuffer_substring)
3084 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3085 (Fsubst_char_in_region, check_translation)
3086 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3087 (transpose_markers, Ftranspose_regions):
3088 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3089 (clip_to_bounds): Move to lisp.h as an inline function).
3090 (Fconstrain_to_field): Don't assume integers are nonnegative.
3091 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3092 (Fsubst_char_in_region, Fsave_restriction):
3093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3094 (Femacs_pid): Don't assume pid_t fits into fixnum.
3095 (lo_time): Use int, not EMACS_INT, when int suffices.
3096 (lisp_time_argument): Check for usec out of range.
3097 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3098 (Fuser_login_name, Fuser_full_name): Signal an error
3099 if a uid argument is out of range, rather than relying on
3100 undefined behavior.
c8d5c857
PE
3101 (Fformat_time_string): Remove now-unnecessary check.
3102 lisp_time_argument checks for out-of-range usec now.
243e0530 3103 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3104 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3105 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3106 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3107 (init_cmdargs, Fdump_emacs):
3108 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3109 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3110 the bottom (typically) 32 bits of the fixnum.
3111 * eval.c (specpdl_size, call_debugger):
3112 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3113 (when_entered_debugger, Fbacktrace_debug):
3114 Don't assume fixnum can fit in int.
3115 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3116 the object just before a buffer; this is not portable.
3117 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3118 (grow_specpdl, unbind_to):
3119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3120 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3121 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3122 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3123 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3124 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3125 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3126 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3127 (a_write, e_write):
3128 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3129 (Fcopy_file, non_regular_nbytes, read_non_regular)
3130 (Finsert_file_contents):
3131 Use int, not EMACS_INT, where int is wide enough.
3132 (READ_BUF_SIZE): Verify that it fits in int.
3133 (Finsert_file_contents): Check that counts are in proper range,
3134 rather than assuming fixnums fit into ptrdiff_t etc.
3135 Don't assume fixnums fit into int.
125b3835 3136 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3137 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3138 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3139 (string_char_to_byte, string_byte_to_char)
3140 (string_make_multibyte, string_to_multibyte)
3141 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3142 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3143 (substring_both, Fdelete, internal_equal, Ffillarray)
3144 (Fclear_string, mapcar1)
3145 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3146 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3147 (larger_vector, make_hash_table, maybe_resize_hash_table)
3148 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3149 (Fmaphash, secure_hash):
3150 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3151 (concat): Check for string index and length overflow.
3152 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3153 (Frequire):
3154 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3155 (larger_vector): New API (vec, incr_min, size_max) replaces old
3156 one (vec, new_size, init). This catches size overflow.
3157 INIT was removed because it was always Qnil.
3158 All callers changed.
3159 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3160 the upper bound on a hash table index size.
3161 (make_hash_table, maybe_resize_hash_table): Use it.
3162 (secure_hash): Computer start_byte and end_byte only after
3163 they're known to be in ptrdiff_t range.
3164 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3165 (Ffont_get_glyphs, Ffont_at):
3166 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3167 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3168 (Flist_fonts, Fopen_font):
3169 Don't assume fixnum can fit in int.
3170 (check_gstring): Don't assume index can fit in int.
3171 (font_match_p): Check that fixnum is a character, not a nonnegative
3172 fixnum, since the later code needs to stuff it into an int.
3173 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3174 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3175 conversion overflow issues.
3176 (Fopen_font): Check for integer out of range.
3177 (Ffont_get_glyphs): Don't assume index can fit in int.
3178 * font.h: Adjust decls to match defn changes elsewhere.
3179 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3180 integer overflow.
3181 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3182 printmax_t, where ptrdiff_t is wide enough.
3183 (Finternal_char_font):
3184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3185 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3186 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3187 (Fset_frame_position, x_set_frame_parameters)
3188 (x_set_line_spacing, x_set_border_width)
3189 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3190 Check that fixnums are in proper range for system types.
3191 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3193 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3194 Use SAFE_ALLOCA_LISP, not alloca.
3195 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3196 intptr_t is wide enough.
3197 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3198 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3199 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3200 Check for fixnum out of range.
3201 * ftfont.c (ftfont_list): Don't assume index fits in int.
3202 Check that fixnums are in proper range for system types.
3203 (ftfont_shape_by_flt):
3204 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3205 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3206 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3207 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3208 Check that fixnums are in proper range for system types.
3209 * gnutls.h: Adjust decls to match defn changes elsewhere.
3210 * gtkutil.c (xg_dialog_run):
3211 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3212 (update_frame_tool_bar):
3213 Check that fixnums are in proper range for system types.
3214 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3215 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3216 * indent.c (last_known_column, last_known_column_point):
3217 (current_column_bol_cache):
3218 (skip_invisible, current_column, check_display_width):
3219 (check_display_width, scan_for_column, current_column_1)
3220 (Findent_to, Fcurrent_indentation, position_indentation)
3221 (indented_beyond_p, Fmove_to_column, compute_motion):
3222 (Fcompute_motion, Fvertical_motion):
3223 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3224 (last_known_column_modified): Use EMACS_INT, not int.
3225 (check_display_width):
3226 (Fcompute_motion):
3227 Check that fixnums and floats are in proper range for system types.
3228 (compute_motion): Don't assume index or fixnum fits in int.
3229 (compute_motion, Fcompute_motion):
3230 Use int, not EMACS_INT, when it is wide enough.
3231 (vmotion): Omit local var start_hpos that is always 0; that way
3232 we don't need to worry about overflow in expressions involving it.
3233 * indent.h: Adjust decls to match defn changes elsewhere.
3234 (struct position):
3235 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3236 Use int, not EMACS_INT, where int is wide enough.
3237 Remove unused members ovstring_chars_done and tab_offset;
3238 all uses removed.
3239 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3240 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3241 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3242 (make_gap, copy_text, insert, insert_and_inherit)
3243 (insert_before_markers, insert_before_markers_and_inherit)
3244 (insert_1, count_combining_before, count_combining_after)
3245 (insert_1_both, insert_from_string)
3246 (insert_from_string_before_markers, insert_from_string_1)
3247 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3248 (adjust_after_replace, adjust_after_insert, replace_range)
3249 (replace_range_2, del_range, del_range_1, del_range_byte)
3250 (del_range_both, del_range_2, modify_region)
3251 (prepare_to_modify_buffer, signal_before_change)
3252 (signal_after_change, Fcombine_after_change_execute):
3253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3254 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3255 (balance_an_interval, split_interval_right, split_interval_left)
3256 (find_interval, next_interval, update_interval)
3257 (adjust_intervals_for_insertion, delete_node, delete_interval)
3258 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3259 (static_offset_intervals, offset_intervals)
3260 (merge_interval_right, merge_interval_left, make_new_interval)
3261 (graft_intervals_into_buffer, temp_set_point_both)
3262 (temp_set_point, set_point, adjust_for_invis_intang)
3263 (set_point_both, move_if_not_intangible, get_property_and_range)
3264 (get_local_map, copy_intervals, copy_intervals_to_string)
3265 (compare_string_intervals, set_intervals_multibyte_1):
3266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3267 * intervals.h: Adjust decls to match defn changes elsewhere.
3268 (struct interval):
3269 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3270 * keyboard.c (this_command_key_count, this_single_command_key_start)
3271 (before_command_key_count, before_command_echo_length, echo_now)
3272 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3273 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3274 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3275 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3276 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3277 (last_non_minibuf_size, last_point_position, echo_truncate)
3278 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3279 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3280 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3281 (stuff_buffered_input):
3282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3283 (last_auto_save, command_loop_1, read_char):
3284 Use EMACS_INT, not int, to avoid integer overflow.
3285 (record_char): Avoid overflow in total_keys computation.
3286 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3287 * keyboard.h: Adjust decls to match defn changes elsewhere.
3288 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3289 (Fkey_description, Fdescribe_vector, Flookup_key):
3290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3291 (click_position): New function, to check that positions are in range.
3292 (Fcurrent_active_maps):
3293 (describe_command):
3294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3295 (Faccessible_keymaps, Fkey_description):
3296 (preferred_sequence_p):
3297 Don't assume fixnum can fit into int.
3298 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3299 Check for integer overflow in size calculations.
3300 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3301 avoid mishandling large integers.
3302 * lisp.h: Adjust decls to match defn changes elsewhere.
3303 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3304 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3305 (struct Lisp_Marker):
3306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3307 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3308 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3309 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3310 All callers changed.
3311 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3312 Assume the arg has valid form, since it always does.
3313 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3314 unsigned integer system type.
3315 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3316 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3318 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3319 (duration_to_sec_usec): New decl.
3320 * lread.c (read_from_string_index, read_from_string_index_byte)
3321 (read_from_string_limit, readchar, unreadchar, openp)
3322 (read_internal_start, read1, oblookup):
3323 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3324 (Fload, readevalloop, Feval_buffer, Feval_region):
3325 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3326 (openp): Check for out-of-range argument to 'access'.
3327 (read1): Use int, not EMACS_INT, where int is wide enough.
3328 Don't assume fixnum fits into int.
6efdadfd 3329 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3330 (read_filtered_event): Use duration_to_sec_usec
3331 to do proper overflow checking on durations.
d311d28c
PE
3332 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3333 in size calculation.
3334 (Fexecute_kbd_macro):
3335 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3336 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3337 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3338 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3339 (set_marker_both, set_marker_restricted_both, marker_position)
3340 (marker_byte_position, Fbuffer_has_markers_at):
3341 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3342 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3343 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3344 It now merely ensures that the menu is large enough, without
3345 necessarily growing it, as this avoids some integer overflow issues.
3346 All callers changed.
3347 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3348 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3349 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3350 Use SAFE_ALLOCA_LISP, not alloca.
3351 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3352 to EMACS_INT. Check that fixnums are in proper range for system types.
3353 * minibuf.c (minibuf_prompt_width, string_to_object)
3354 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3355 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3356 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3357 (get_minibuffer, read_minibuf_unwind):
3358 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3359 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3360 this simplifies overflow checking. All callers changed.
3361 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3362 (Ftest_completion):
3363 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3364 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3365 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3366 Check that fixnums are in proper range for system types.
3367 (Fx_create_frame, Fx_show_tip):
3368 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3369 * nsfont.m (ns_findfonts, nsfont_list_family):
3370 Don't assume fixnum fits in long.
3371 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3372 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3373 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3374 wide enough.
17fdb222 3375 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3376 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3377 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3378 (PRINTDECLARE, PRINTPREPARE):
3379 (strout, print_string):
3380 (print, print_preprocess, print_check_string_charset_prop)
3381 (print_object):
3382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3383 (PRINTDECLARE):
3384 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3386 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3387 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3388 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3389 (print_error_message): Use SAFE_ALLOCA, not alloca.
3390 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3391 (print_depth, new_backquote_output, print_number_index):
3392 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3393 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3394 (Fset_process_window_size, Fformat_network_address)
3395 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3396 (sigchld_handler):
d311d28c 3397 Check that fixnums are in proper range for system types.
d44287d4 3398 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3399 Check for process-ids out of pid_t range rather than relying on
3400 undefined behavior.
e4d81efc 3401 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3402 (Fformat_network_address, read_process_output, send_process)
3403 (Fprocess_send_region, status_notify):
3404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3405 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3406 (wait_reading_process_output, read_process_output, exec_sentinel):
3407 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3408 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3409 (Faccept_process_output): Use duration_to_sec_usec to do proper
3410 overflow checking on durations.
dde14581
PE
3411 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3412 Don't assume pid_t fits in int.
02481186
PE
3413 * process.h (struct Lisp_Process): Members tick and update_tick
3414 are now of type EMACS_INT, not int.
b62b53e8
PE
3415 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3416 configured --with-wide-int.
d311d28c
PE
3417 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3418 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3419 * search.c (looking_at_1, string_match_1):
3420 (fast_string_match, fast_c_string_match_ignore_case)
3421 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3422 (scan_newline, find_before_next_newline, search_command)
3423 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3424 (set_search_regs, wordify):
3425 (Freplace_match):
3426 (Fmatch_data):
3427 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3428 (string_match_1, search_buffer, set_search_regs):
3429 (Fmatch_data):
3430 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3431 (wordify): Check for overflow in size calculation.
3432 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3433 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3434 Check that fixnums are in proper range for system types.
3435 * sound.c (struct sound_device)
3436 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3438 (Fplay_sound_internal):
3439 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3440 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3441 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3442 (Fparse_partial_sexp):
3443 Don't assume fixnums can fit in int.
3444 (struct lisp_parse_state, find_start_pos, find_start_value)
3445 (find_start_value_byte, find_start_begv)
3446 (update_syntax_table, char_quoted, dec_bytepos)
3447 (find_defun_start, prev_char_comend_first, back_comment):
3448 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3449 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3450 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3451 (Finternal_describe_syntax_value): Check that match_lisp is a
3452 character, not an integer, since the code stuffs it into int.
3453 (scan_words, scan_sexps_forward):
3454 Check that fixnums are in proper range for system types.
3455 (Fforward_word):
3456 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3457 (scan_sexps_forward):
3458 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3459 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3460 * syntax.h: Adjust decls to match defn changes elsewhere.
3461 (struct gl_state_s):
3462 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3463 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3464 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3465 * sysdep.c (wait_for_termination_1, wait_for_termination)
3466 (interruptible_wait_for_termination, mkdir):
3467 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3468 (emacs_read, emacs_write):
3469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3470 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3471 and double all fit in int.
d311d28c
PE
3472 * term.c (set_tty_color_mode):
3473 Check that fixnums are in proper range for system types.
3474 * termhooks.h (struct input_event):
3475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3476 * textprop.c (validate_interval_range, interval_of)
3477 (Fadd_text_properties, set_text_properties_1)
3478 (Fremove_text_properties, Fremove_list_of_text_properties)
3479 (Ftext_property_any, Ftext_property_not_all)
3480 (copy_text_properties, text_property_list, extend_property_ranges)
3481 (verify_interval_modification):
3482 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3483 (Fnext_single_char_property_change)
3484 (Fprevious_single_char_property_change):
3485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3486 (copy_text_properties):
3487 Check for integer overflow in index calculation.
d311d28c
PE
3488 * undo.c (last_boundary_position, record_point, record_insert)
3489 (record_delete, record_marker_adjustment, record_change)
3490 (record_property_change):
3491 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3492 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3493 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3494 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3495 (Fx_hide_tip, Fx_file_dialog):
3496 * w32menu.c (set_frame_menubar):
3497 Use ptrdiff_t, not int, for consistency with rest of code.
3498 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3499 (select_window, Fdelete_other_windows_internal)
3500 (window_scroll_pixel_based, window_scroll_line_based)
3501 (Frecenter, Fset_window_configuration):
3502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3503 (Fset_window_hscroll, run_window_configuration_change_hook)
3504 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3505 (Fscroll_other_window, Frecenter):
d311d28c
PE
3506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3507 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3508 Don't assume fixnum fits in int.
3509 (Fset_window_scroll_bars):
3510 Check that fixnums are in proper range for system types.
3511 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3512 (string_pos, c_string_pos, number_of_chars, init_iterator)
3513 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3514 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3515 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3516 (face_before_or_after_it_pos, handle_invisible_prop)
3517 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3518 (display_prop_intangible_p, string_buffer_position_lim)
3519 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3520 (get_overlay_strings_1, get_overlay_strings)
3521 (iterate_out_of_display_property, forward_to_next_line_start)
3522 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3523 (get_next_display_element, set_iterator_to_next)
3524 (get_visually_first_element, compute_stop_pos_backwards)
3525 (handle_stop_backwards, next_element_from_buffer)
3526 (move_it_in_display_line_to, move_it_in_display_line)
3527 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3528 (add_to_log, message_dolog, message_log_check_duplicate)
3529 (message2, message2_nolog, message3, message3_nolog
3530 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3531 (current_message_1, truncate_echo_area, truncate_message_1)
3532 (set_message, set_message_1, store_mode_line_noprop)
3533 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3534 (text_outside_line_unchanged_p, check_point_in_composition)
3535 (reconsider_clip_changes)
3536 (redisplay_internal, set_cursor_from_row, try_scrolling)
3537 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3538 (redisplay_window, find_last_unchanged_at_beg_row)
3539 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3540 (trailing_whitespace_p, find_row_edges, display_line)
3541 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3542 (display_mode_element, store_mode_line_string)
3543 (pint2str, pint2hrstr, decode_mode_spec)
3544 (display_count_lines, display_string, draw_glyphs)
3545 (x_produce_glyphs, x_insert_glyphs)
3546 (rows_from_pos_range, mouse_face_from_buffer_pos)
3547 (fast_find_string_pos, mouse_face_from_string_pos)
3548 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3550 (safe_call, init_from_display_pos, handle_fontified_prop)
3551 (handle_single_display_spec, load_overlay_strings)
3552 (with_echo_area_buffer, setup_echo_area_for_printing)
3553 (display_echo_area, echo_area_display)
3554 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3555 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3556 (redisplay_window, dump_glyph_row, display_mode_line)
3557 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3558 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3559 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3560 (handle_single_display_spec, build_desired_tool_bar_string)
3561 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3562 (get_specified_cursor_type):
3563 Check that fixnums are in proper range for system types.
3564 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3565 (Flookup_image_map):
3566 Don't assume fixnums fit in int.
3567 (compare_overlay_entries):
3568 Avoid mishandling comparisons due to subtraction overflow.
3569 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3570 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3571 (handle_tool_bar_click):
3572 Use int, not unsigned, since we prefer signed and the signedness
3573 doesn't matter here.
3574 (get_next_display_element, next_element_from_display_vector):
3575 Use int, not EMACS_INT, when int is wide enough.
3576 (start_hourglass): Use duration_to_sec_usec to do proper
3577 overflow checking on durations.
3578 * xfaces.c (Fbitmap_spec_p):
3579 Check that fixnums are in proper range for system types.
3580 (compare_fonts_by_sort_order):
3581 Avoid mishandling comparisons due to subtraction overflow.
3582 (Fx_family_fonts, realize_basic_faces):
3583 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3584 (Fx_family_fonts):
3585 Don't assume fixnum fits in int.
3586 Use SAFE_ALLOCA_LISP, not alloca.
3587 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3588 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3589 (face_at_buffer_position, face_for_overlay_string)
3590 (face_at_string_position):
3591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3592 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3593 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3594 (Fx_show_tip):
3595 Check that fixnums are in proper range for system types.
3596 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3597 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3598 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3599 (Fx_change_window_property): Don't assume fixnums fit in int.
3600 * xfont.c (xfont_chars_supported):
3601 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3602 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3603 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3604 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3605 * xml.c (parse_region):
3606 * xrdb.c (magic_file_p):
3607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3608 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3609 (x_get_local_selection, x_reply_selection_request)
3610 (x_handle_selection_request, wait_for_property_change):
3611 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3612 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3613 short is wide enough.
3614 (x_send_client_event): Don't assume fixnum fits in int.
3615 * xterm.c (x_x_to_emacs_modifiers):
3616 Don't assume EMACS_INT overflows nicely into int.
3617 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3618 may come from Lisp.
3619 (handle_one_xevent): NATNUMP can eval its arg twice.
3620 (x_connection_closed):
3621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3622 * xterm.h: Adjust decls to match defn changes elsewhere.
3623 (struct scroll_bar): Use struct vectorlike_header
3624 rather than rolling our own approximation.
3625 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3626
c6574eb5
GM
36272012-05-25 Glenn Morris <rgm@gnu.org>
3628
3629 * lisp.mk (lisp): Update for more files being compiled now.
3630
e8d32c7e
SM
36312012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3632
48def666
SM
3633 * lread.c: Remove `read_pure' which makes no difference.
3634 (read_pure): Remove var.
3635 (unreadpure): Remove function.
3636 (readevalloop): Don't call read_list with -1 flag.
3637 (read1, read_vector): Don't test read_pure any more.
3638 (read_list): Simplify.
3639
e8d32c7e
SM
3640 * fileio.c, character.h: Minor style tweaks.
3641
4b2addb7
DA
36422012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3643
3644 * window.h (clip_changed): Remove useless declaration.
3645
584461b2
JB
36462012-05-22 Juanma Barranquero <lekktu@gmail.com>
3647
3648 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3649 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3650
34374650
PE
36512012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3652
3653 Remove src/m/*.
3654 This directory predates autoconf and is no longer needed nowadays.
3655 Move its few remaining bits of functionality to where they're needed.
3656 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3657 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3658 * m/template.h: Remove.
3659 * Makefile.in (M_FILE): Remove. All uses removed.
3660 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3661 * lisp.h (USE_LSB_TAG):
3662 * mem-limits.h (EXCEEDS_LISP_PTR):
3663 Use VAL_MAX, not VALBITS, in #if.
3664 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3665 (EMACS_UINT): Define unconditionally now.
3666 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3667 (BITS_PER_EMACS_INT): New constants, replacing
3668 what used to be in config.h, but not useful in #if.
3669 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3670 define them any more.
3671 (VAL_MAX): New macro.
3672 (VALMASK): Use it.
3673 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3674 BITS_PER_EMACS_INT, in #if.
3675 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3676 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3677 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3678 * s/ms-w32.h (DATA_START):
3679 Move here from removed file m/intel386.h.
3680 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3681 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3682
261cb4bb
PE
36832012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3684
3685 Assume C89 or later.
3686 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3687 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3688 (xrealloc):
3689 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3690 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3691 * textprop.c, tparam.c (NULL): Remove.
3692 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3693 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3694 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3695 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3696 * xterm.c (input_signal_count): Assume volatile works.
3697
ff23cd9f
KB
36982012-05-21 Ken Brown <kbrown@cornell.edu>
3699
3700 * xgselect.c (xg_select): Fix first argument in call to 'select'
3701 (bug#11508).
3702
1b170bc6
KB
37032012-05-20 Ken Brown <kbrown@cornell.edu>
3704
3705 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3706 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3707
b2f4d39f
KB
37082012-05-19 Ken Brown <kbrown@cornell.edu>
3709
3710 * xfns.c (x_in_use): Remove `static' qualifier.
3711 * xterm.h (x_in_use): Declare.
3712 * xgselect.c: Include xterm.h.
3713 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3714 and `display_arg' (bug#9754).
3715
003fdae2
PE
37162012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3717
9232a6d9
PE
3718 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3719
003fdae2
PE
3720 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3721 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3722
784b56e2
EZ
37232012-05-18 Eli Zaretskii <eliz@gnu.org>
3724
3725 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3726
3727 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3728 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3729
3730 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3731 reference to image_cache->refcount.
3732 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3733
a0a79cde
JL
37342012-05-17 Juri Linkov <juri@jurta.org>
3735
3736 * search.c (Fword_search_regexp, Fword_search_backward)
3737 (Fword_search_forward, Fword_search_backward_lax)
3738 (Fword_search_forward_lax): Move functions to isearch.el
3739 (bug#10145, bug#11381).
3740
b0572523
PE
37412012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3742
3743 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3744
9660f5fc
SM
37452012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3746
3747 * lread.c (init_obarray): Declare Qt and Qnil as special.
3748
4374de83
GM
37492012-05-14 Glenn Morris <rgm@gnu.org>
3750
3751 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3752 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3753
dc44c39a
PE
37542012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3755
078c97cb
PE
3756 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3757
dc44c39a
PE
3758 * unexaix.c: Port to more-recent AIX compilers.
3759 (report_error, report_error_1, make_hdr, copy_sym)
3760 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3761 Make arguments const char *, not char *, to avoid violations of C
3762 standard and to fix some AIX warnings reported by Gilles Pion.
3763
e18afed7 37642012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3765
3766 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3767 already have overlays loaded.
3768 (handle_single_display_spec): Before returning without displaying
3769 fringe bitmap, synchronize the bidi iterator with the main display
3770 iterator, by calling iterate_out_of_display_property.
3771 (iterate_out_of_display_property): Detect buffer iteration by
3772 testing that it->string is a Lisp string.
3773 (get_next_display_element): When the current object is exhausted,
3774 and there's something on it->stack, call set_iterator_to_next to
3775 proceed with what's on the stack, instead of returning zero.
3776 (set_iterator_to_next): If called at the end of a Lisp string,
3777 proceed to consider_string_end without incrementing string
3778 position. Don't increment display vector index past the end of
3779 the display vector. (Bug#11417)
c8fb9dc6
EZ
3780 (pos_visible_p): Don't report a position visible when move_it_to
3781 stopped at the last line of window, which happens to be scanned
3782 backwards by the bidi iteration. (Bug#11464)
ac268e67 3783
e18afed7 37842012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3785
3786 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3787 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3788 are on a TTY, and thus unable to display on the fringes.
3789 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3790 so we need to signal to the caller that this is a "replacing"
3791 display spec. This fixes display when the spec is invalid or we
3792 are on a TTY.
3793
e18afed7 37942012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3795
3796 * unexaix.c (make_hdr): Fix typo in prototype.
3797 This bug broke the build on AIX. Problem reported by Gilles Pion.
3798
9d0a235a
MA
37992012-05-14 Michael Albinus <michael.albinus@gmx.de>
3800
3801 * keyboard.c (kbd_buffer_get_event): Read special events also in
3802 batch mode. (Bug#11415)
3803
9e6b06ed
GM
38042012-05-12 Glenn Morris <rgm@gnu.org>
3805
3806 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3807
c1a1d7a3
EZ
38082012-05-12 Eli Zaretskii <eliz@gnu.org>
3809
3810 * lisp.mk (lisp): Add newcomment.elc.
3811
3fe7cdc8
GM
38122012-05-12 Glenn Morris <rgm@gnu.org>
3813
3814 * Makefile.in (MKDIR_P): New, set by configure.
3815 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3816
53f7d2c0
PE
38172012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3818
3819 Remove unused function hourglass_started.
3820 * dispextern.h (hourglass_started):
3821 * w32fns.c (hourglass_started):
3822 * xdisp.c (hourglass_started): Remove.
3823
75aafb17
JB
38242012-05-10 Juanma Barranquero <lekktu@gmail.com>
3825
3826 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3827 Update dependencies.
3828
12959e8e
PE
38292012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3830
97107e2e
PE
3831 * xgselect.c (xg_select): Put maxfds+1 into a var.
3832 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3833
12959e8e
PE
3834 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3835
836d29b3
DA
38362012-05-10 Dave Abrahams <dave@boostpro.com>
3837
3838 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3839 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3840
5cb67954
MA
38412012-05-09 Michael Albinus <michael.albinus@gmx.de>
3842
3843 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3844 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3845 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3846 Initialize xd_registered_buses.
3847
3478ec45
PE
38482012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3849
b263a6b0
PE
3850 Untag more efficiently if USE_LSB_TAG.
3851 This is based on a proposal by YAMAMOTO Mitsuharu in
3852 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3853 For an admittedly artificial (nth 8000 longlist) benchmark on
3854 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3855 Emacs's overall text size by 1%.
3856 * lisp.h (XUNTAG): New macro.
3857 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3858 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3859 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3860 * eval.c (Fautoload):
3861 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3862 * frame.h (XFRAME): Use XUNTAG.
3863
3478ec45
PE
3864 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3865 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3866 Remove unportable assumptions about print widths of types like
3867 dbus_uint32_t.
3868 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3869 intptr_t when converting between pointer and integer, to avoid GCC
3870 warnings about wrong width.
3871
666b903b 38722012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3873
3874 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3875 stack for each reader_thread, instead of defaulting to 8MB
3876 determined by the linker. This avoids failures in creating
3877 subprocesses on Windows 7, see the discussion in this thread:
3878 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3879
b120cc17
JC
38802012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3881
3882 Fix up display of the *Minibuf-0* buffer in the mini window.
3883 * keyboard.c (read_char): Don't clear the echo area if there's no
3884 message to clear.
3885 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3886 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3887
9a4b36f8
MA
38882012-05-07 Michael Albinus <michael.albinus@gmx.de>
3889
3890 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3891 batch mode.
3892
e5f9458f
CY
38932012-05-06 Chong Yidong <cyd@gnu.org>
3894
3895 * lisp.mk (lisp): Update.
3896
eceeb5fc 38972012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3898
3899 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3900
71873e2b
SM
39012012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3902
3903 * data.c (PUT_ERROR): New macro.
3904 (syms_of_data): Use it. Add new error type `user-error'.
3905 * undo.c (user_error): New function.
3906 (Fprimitive_undo): Use it.
3907 * print.c (print_error_message): Adjust print style for `user-error'.
3908 * keyboard.c (user_error): New function.
3909 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3910
ab0fa4e4
PE
39112012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3912
3913 Do not limit current-time-string to years 1000..9999.
3914 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3915 (Fcurrent_time_string): Support any year that is supported by the
3916 underlying localtime representation. Don't use asctime, as it
3917 has undefined behavior for years outside the range -999..9999.
3918
7ed806a7
PE
39192012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3920
3921 Fix race conditions involving setenv, gmtime, localtime, asctime.
3922 Without this fix, interrupts could mess up code that uses these
3923 nonreentrant functions, since setting TZ invalidates existing
3924 tm_zone or tzname values, and since most of these functions return
3925 pointers to static storage.
3926 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3927 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3928 Grow the critical sections to include not just invoking
3929 localtime/gmtime, but also accessing these functions' results
3930 including their tm_zone values if any, and any related TZ setting.
3931 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3932 so that the struct tm is saved in the critical section.
3933 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3934 motivated by the fact that memory allocation needs to be outside
3935 the critical section.
3936
0c16dfed
DA
39372012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3938
3939 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3940 with RESET_INTERVAL.
3941
3942 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3943 Remove duplicated buffer name initialization.
3944
3f83ace8
JM
39452012-05-02 Jim Meyering <jim@meyering.net>
3946
3947 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3948
c7b8541e
JM
3949 * xfns.c (x_window): Use xstrdup (Bug#11375).
3950
90207a15 39512012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3952
3953 * xdisp.c (pos_visible_p): If already at a newline from the
3954 display string before the 'while' loop, don't walk back the glyphs
3955 from it3.glyph_row. Solves assertion violation when the display
3956 string begins with a newline (egg.el). (Bug#11367)
3957
b593d6a9
AH
39582012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3959
3960 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3961 Move to simple.el.
3962
4737362e
GM
39632012-05-01 Glenn Morris <rgm@gnu.org>
3964
99cf43f9
GM
3965 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3966 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3967 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3968 All were removed before 23.1.
3969
9311dcff
GM
3970 * dispnew.c: Remove HAVE_LIBNCURSES test;
3971 it is always true on relevant platforms.
3972
4d5c6349
GM
3973 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3974 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3975
4737362e
GM
3976 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3977
74dd3a6b
AS
39782012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3979
3980 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3981 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3982 Remove.
3983
13c379ee
PE
39842012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3985
3986 Do not avoid creating empty evaporating overlays (Bug#9642).
3987 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3988 That is, do not delete an evaporating overlay if it becomes
3989 empty after its bounds are adjusted to fit within its buffer.
3990 This fix caused other problems, and I'm reverting it until we get
3991 to the bottom of them.
3992
a8e7d6d7 39932012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3994
3995 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3996
a8e7d6d7 39972012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3998
3999 * xdisp.c (pos_visible_p): If the window start position is beyond
4000 ZV, start the display from buffer beginning. Prevents assertion
4001 violation in init_iterator when the minibuffer window is scrolled
4002 via the scroll bar.
4003
4004 * window.c (window_scroll_pixel_based): Likewise.
4005
a8e7d6d7 40062012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4007
4008 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4009
a8e7d6d7 40102012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4011
4012 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4013 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4014
a8e7d6d7 40152012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4016
b593d6a9
AH
4017 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4018 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4019
1c6900d9
EZ
40202012-04-26 Eli Zaretskii <eliz@gnu.org>
4021
4c3fa1d9
EZ
4022 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4023 display element, check also the underlying string or buffer
4024 character. (Bug#11341)
4025
1c6900d9
EZ
4026 * w32menu.c: Include w32heap.h.
4027 (add_menu_item): If the call to AppendMenuW (via
4028 unicode_append_menu) fails, disable Unicode menus only if we are
4029 running on Windows 9X/Me.
4030
42bf8205
AS
40312012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4032
4033 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4034 (xgetint): Add missing shift for LSB tags.
4035
b1bac16e
MR
40362012-04-24 Martin Rudalics <rudalics@gmx.at>
4037
4038 * keyboard.c (read_char): Don't wipe echo area for select window
4039 events: These might get delayed via `mouse-autoselect-window'
4040 (Bug#11304).
4041
d69621cc
JB
40422012-04-24 Juanma Barranquero <lekktu@gmail.com>
4043
4044 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4045 manipulation of :loaded-from data.
4046
02fd101b
JB
40472012-04-23 Juanma Barranquero <lekktu@gmail.com>
4048
4049 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4050 now a cons (bug#11311).
4051
888bec30
PE
40522012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4053
89a438bd
PE
4054 Do not create empty overlays with the evaporate property (Bug#9642).
4055 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4056 if it becomes empty after its bounds are adjusted to fit within
4057 its buffer. Without this fix, in a nonempty buffer (let ((o
4058 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4059 yields an empty overlay that has the evaporate property, which is
4060 not supposed to happen.
4061
1068fe4d
PE
4062 Fix minor GTK3 problems found by static checking.
4063 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4064 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4065 (struct _EmacsFixedClass, emacs_fixed_get_type):
4066 Move decls here from emacsgtkfixed.h, since they needn't be public.
4067 (emacs_fixed_get_type): Now static.
4068 (emacs_fixed_class_init): Omit unused local.
4069 (emacs_fixed_child_type): Remove; unused.
4070 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4071 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4072 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4073 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4074 (EMACS_FIXED_GET_CLASS): Remove; unused.
4075 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4076
888bec30
PE
4077 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4078 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4079
de85e130
PE
40802012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4081
d0baac98 4082 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4083 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4084 (__malloc_size_t, __malloc_ptrdiff_t):
4085 Remove. All uses removed, replaced by the definiens if needed,
4086 since we can assume C89 or better now.
4087 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4088 (protect_malloc_state, align, get_contiguous_space)
4089 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4090 (malloc_atfork_handler_child, malloc_enable_thread)
4091 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4092 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4093 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4094 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4095 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4096 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4097 Define using prototypes, not old style.
4098 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4099 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4100 (align): Don't assume that signed integer overflow wraps around.
4101 Omit unused local var.
4102 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4103 (_free_internal_nolock, memalign, mallochook, reallochook):
4104 Omit no-longer-needed casts.
4105 (valloc): Use getpagesize, not __getpagesize.
4106 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4107 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4108
de85e130
PE
4109 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4110
dcbf5805
MA
41112012-04-22 Michael Albinus <michael.albinus@gmx.de>
4112
4113 Move functions from C to Lisp. Make non-blocking method calls
4114 the default. Implement further D-Bus standard interfaces.
4115
4116 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4117 (QCdbus_request_name_allow_replacement)
4118 (QCdbus_request_name_replace_existing)
4119 (QCdbus_request_name_do_not_queue)
4120 (QCdbus_request_name_reply_primary_owner)
4121 (QCdbus_request_name_reply_in_queue)
4122 (QCdbus_request_name_reply_exists)
4123 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4124 (QCdbus_registered_serial, QCdbus_registered_method)
4125 (QCdbus_registered_signal): New Lisp objects.
4126 (XD_DEBUG_MESSAGE): Use sizeof.
4127 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4128 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4129 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4130 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4131 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4132 (xd_signature, xd_append_arg): Allow float for integer types.
4133 (xd_get_connection_references): New function.
b593d6a9
AH
4134 (xd_get_connection_address): Rename from xd_initialize.
4135 Return cached address.
dcbf5805
MA
4136 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4137 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4138 level.
4139 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4140 Return number of refcounts.
dcbf5805
MA
4141 (Fdbus_get_unique_name): Make stronger parameter check.
4142 (Fdbus_message_internal): New defun.
4143 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4144 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4145 (Fdbus_send_signal, Fdbus_register_service)
4146 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4147 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4148 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4149 (Vdbus_compiled_version, Vdbus_runtime_version)
4150 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4151 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4152 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4153 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4154 Adapt docstring.
dcbf5805 4155
52828e02
PE
41562012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4157
da05bc4c
PE
4158 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4159 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4160 Do not assume ptrdiff_t is the same width as 'int'.
4161
52828e02
PE
4162 * alloc.c: Handle unusual debugging option combinations.
4163 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4164 since the two debugging options are incompatible.
4165 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4166 is defined.
4167 (mem_init, mem_insert, mem_insert_fixup):
4168 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4169 (NEED_MEM_INSERT): Remove; no longer needed.
4170
f01769f9
LL
41712012-04-22 Leo Liu <sdl.web@gmail.com>
4172
4173 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4174
5790543d
PE
41752012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4176
4177 * sysdep.c [__FreeBSD__]: Minor cleanups.
4178 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4179 Use Emacs indenting style more consistently. Avoid some casts.
4180 Use 'double' consistently rather than mixing 'float' and 'double'.
4181
b91b7e4d
EW
41822012-04-21 Eduard Wiebe <usenet@pusto.de>
4183
b593d6a9
AH
4184 * sysdep.c (list_system_processes, system_process_attributes):
4185 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4186
6114eb15
AS
41872012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4188
4189 * lisp.mk (lisp): Update.
4190
2f38dff7
PE
41912012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4192
4193 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4194 It is never used otherwise.
4195
4ae29f89
SM
41962012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4197
4198 * print.c (print_preprocess): Only check print_depth if print-circle
4199 is nil.
4200 (print_object): Check for cycles even when print-circle is nil and
4201 print-gensym is t, but only check print_depth if print-circle is nil.
4202
f30d612a
CY
42032012-04-20 Chong Yidong <cyd@gnu.org>
4204
4205 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4206 set the status to "failed" and ensure that sentinel is run.
4207
c07a4c0b 42082012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4209
4210 * process.c (Fset_process_inherit_coding_system_flag)
4211 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4212 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4213
c07a4c0b 42142012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4215
4216 * xdisp.c (string_buffer_position_lim): Limit starting position to
4217 BEGV.
4218 (set_cursor_from_row): If called for a mode-line or header-line
4219 row, return zero immediately.
4220 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4221 farther than the first row after the header line, if any.
4222 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4223 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4224
c07a4c0b 42252012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4226
4ae29f89
SM
4227 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4228 (bug#11238).
ad3a2b41 4229
c07a4c0b 42302012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 42312012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4232
4233 configure: new option --enable-gcc-warnings (Bug#11207)
4234 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4235 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4236 (ALL_CFLAGS): Use new macros rather than old.
4237 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4238 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4239 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4240 -Wunused-result, -Wunused-variable. This should go away once
4241 the Emacs and Gnulib regex code is merged.
4242 (xmalloc, xrealloc): Now static.
4243
aba027e8
PE
42442012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4245
4246 * dired.c (Fsystem_groups): Remove unused local.
4247
e5a36063
GM
42482012-04-17 Glenn Morris <rgm@gnu.org>
4249
4250 * dired.c (Fsystem_users): Doc fix.
4251
316411f0
DA
42522012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4253
4254 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4255 (syms_of_dired): Add them.
4256
9426aba4
PE
42572012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4258
b62a57be
PE
4259 Fix minor alloc.c problems found by static checking.
4260 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4261 New extern decls, to avoid calling undeclared functions.
4262 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4263 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4264 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4265 (NEED_MEM_INSERT): New macro.
4266 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4267 Remove one incorrect comment and fix another.
b62a57be 4268
3539f31f
PE
4269 Fix minor ralloc.c problems found by static checking.
4270 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4271 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4272 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4273 (r_alloc_sbrk): Now static.
4274
a041960a
PE
4275 Improve ralloc.c interface checking.
4276 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4277 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4278 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4279 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4280 [REL_ALLOC]: ... to here, to check interface.
4281 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4282 Remove decls. This fixes an "It stinks!".
4283
9426aba4
PE
4284 * alloc.c (which_symbols): Fix alignment issue / type clash.
4285
d55c12ed
AS
42862012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4287
4288 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4289 (struct Lisp_Misc_Any): Likewise.
4290 (struct Lisp_Free): Likewise.
4291 * alloc.c (union aligned_Lisp_Symbol): Define.
4292 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4293 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4294 (union aligned_Lisp_Misc): Define.
4295 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4296 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4297 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4298
b948ce8b
PE
42992012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4300
4301 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4302 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4303 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4304 * s/netbsd.h, s/sol2-6.h:
4305 Remove definition of GC_MARK_STACK, since the default now works.
4306 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4307 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4308 no longer the default.
4309 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4310
35dc09a1 43112012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4312
35dc09a1
GM
4313 * lread.c (lisp_file_lexically_bound_p):
4314 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4315
35dc09a1
GM
43162012-04-14 Eli Zaretskii <eliz@gnu.org>
4317
4318 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4319 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4320
43212012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4322
4323 * nsterm.m (constrainFrameRect): Always constrain when there is only
4324 one screen (Bug#10962).
4325
bcd86815
KB
43262012-04-13 Ken Brown <kbrown@cornell.edu>
4327
4328 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4329
c25df26e
RT
43302012-04-13 Reuben Thomas <rrt@sc3d.org>
4331
4332 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4333
0fc59f1e
DC
43342012-04-11 Daniel Colascione <dancol@dancol.org>
4335
4336 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4337 against is gone. It's better to use vfork now so that when Cygwin
4338 gains a new, working vfork, we use it automatically (bug#10398).
4339
de8c03dc
SM
43402012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4341
4342 * window.c (save_window_save): Obey window-point-insertion-type.
4343
2f097256
GM
43442012-04-11 Glenn Morris <rgm@gnu.org>
4345
4346 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4347
453b951e
SM
43482012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4349
4350 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4351
75f1671a 43522012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4353
4354 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4355 (force_quit_count): New var.
4356 (handle_interrupt): Use it.
4357
2a8ce227
JB
43582012-04-10 Juanma Barranquero <lekktu@gmail.com>
4359
4360 * w32.c (w32_delayed_load): Record the full path of the library
4361 being loaded (bug#10424).
4362
935396c0
GM
43632012-04-09 Glenn Morris <rgm@gnu.org>
4364
05920a43
GM
4365 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4366 not just in the obarray, before snarfing them. (Bug#11036)
4367
935396c0
GM
4368 * Makefile.in ($(leimdir)/leim-list.el):
4369 Pass EMACS rather than BUILT_EMACS.
4370
a18ecafa
TZ
43712012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4372
4373 * process.c (make_process):
4374 * process.h: Add integer `gnutls_handshakes_tried' member to
4375 process struct.
4376
6bbef4e5
JC
4377 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4378 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4379
4380 * gnutls.c (gnutls_log_function2i): Convenience log function.
4381 (emacs_gnutls_read): Use new log functions,
4382 `gnutls_handshakes_tried' process member, and
4383 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4384 attempts per process (connection).
4385
b4d3bc10
CY
43862012-04-09 Chong Yidong <cyd@gnu.org>
4387
4388 * eval.c (Fuser_variable_p, user_variable_p_eh)
4389 (lisp_indirect_variable): Functions deleted.
4390 (Fdefvar): Caller changed.
4391
4392 * callint.c (Finteractive, Fcall_interactively):
4393 * minibuf.c (Fread_variable): Callers changed.
4394
70f4d973
EZ
43952012-04-09 Eli Zaretskii <eliz@gnu.org>
4396
4397 * xdisp.c (set_cursor_from_row): If the display string appears in
4398 the buffer at position that is closer to point than the position
4399 after the display string, display the cursor on the first glyph of
4400 the display string. Fixes cursor display when a 'display' text
4401 property immediately follows invisible text. (Bug#11094)
4402
cb3c2e3e
PE
44032012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4404
4405 composite.c: use 'double' consistently
4406 * composite.c (get_composition_id): Use 'double' consistently
4407 instead of converting 'float' to 'double' and vice versa; this is
4408 easier to understand and avoids a GCC warning.
4409
fd06db5d
GM
44102012-04-09 Glenn Morris <rgm@gnu.org>
4411
50fe702a
GM
4412 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4413 preparation for dumping it with emacs. (Bug#4789)
4414 (leimdir): New variable.
4415 ($(leimdir)/leim-list.el): New rule.
4416 (emacs$(EXEEXT)): Depend on leim-list.el.
4417
fd06db5d
GM
4418 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4419 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4420 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4421
55c131ee
AS
44222012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4423
4424 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4425 proper alignment.
4426
9209588f
JB
44272012-04-07 Juanma Barranquero <lekktu@gmail.com>
4428
4429 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4430 Remove unused local variable.
4431
e3fb2efb
PE
44322012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4433
4434 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4435 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4436 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4437 objects, as mark_maybe_pointer will catch them otherwise.
4438 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4439 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4440
b5385551
PE
44412012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4442
4443 Fix typo that broke non-Windows builds.
4444 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4445
9078ead6
EZ
44462012-04-07 Eli Zaretskii <eliz@gnu.org>
4447
4448 Support building on MS-Windows with libxml2.
4449
4450 * makefile.w32-in (OBJ2): Add xml.$(O).
4451 (GLOBAL_SOURCES): Add xml.c.
4452 ($(BLD)/xml.$(O)): New dependency list.
4453
4454 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4455 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4456 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4457 [!WINDOWSNT]: New macros.
4458 (init_libxml2_functions, libxml2_loaded_p): New functions.
4459 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4460 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4461 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4462 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4463 linked in).
6bbef4e5
JC
4464 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4465 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4466 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4467
4468 * emacs.c: Don't include libxml/parser.h.
4469 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4470 xmlCleanupParser directly.
4471
4472 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4473
3811fdf3
EZ
44742012-04-07 Eli Zaretskii <eliz@gnu.org>
4475
4476 * indent.c (Fvertical_motion): If there is a display string at
4477 point, use it.vpos to compute how many lines to backtrack after
4478 move_it_to point. (Bug#11133)
4479
2f8e16b2
EZ
44802012-04-06 Eli Zaretskii <eliz@gnu.org>
4481
4482 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4483 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4484 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4485 macros related to unification of CJK characters. For the details,
4486 see the discussion following the message here:
4487 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4488
3d439cd1
CY
44892012-04-04 Chong Yidong <cyd@gnu.org>
4490
4491 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4492
8bc53d00
EZ
44932012-04-01 Eli Zaretskii <eliz@gnu.org>
4494
4495 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4496 instead of alloca. (Bug#11138)
4497
3b0512a3
AS
44982012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4499
4500 * w32menu.c (is_simple_dialog): Properly check lisp types.
4501 (Bug#11141)
4502
8427ddd2
EZ
45032012-03-31 Eli Zaretskii <eliz@gnu.org>
4504
979022ef
EZ
4505 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4506 position we get to after a call to move_it_to fails the
4507 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4508 only if we wind up in a string from display property. (Bug#11063)
4509
a6b1c7cc
EZ
4510 * window.c (Fdelete_other_windows_internal): Invalidate the row
4511 and column information about mouse highlight, so that redisplay
4512 restores it after reallocating the glyph matrices. (Bug#7464)
4513
8427ddd2
EZ
4514 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4515 string comes from a `display' text property, use the buffer
4516 position of that property as if we actually saw that position in
4517 the row's glyphs.
697ba24b
EZ
4518 (move_it_by_lines): Remove the assertion that
4519 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4520 violated when there's a before-string at the beginning of a line.
4521 (Bug#11063)
8427ddd2 4522
65a0a738
EZ
45232012-03-30 Eli Zaretskii <eliz@gnu.org>
4524
4525 * xdisp.c (append_space_for_newline): If the default face was
4526 remapped, use the remapped face for the appended newline.
4527 (extend_face_to_end_of_line): Use the remapped default face for
4528 extending the face to the end of the line.
4529 (display_line): Call extend_face_to_end_of_line when the default
4530 face was remapped. (Bug#11068)
4531
581355cc
EZ
45322012-03-29 Eli Zaretskii <eliz@gnu.org>
4533
4534 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4535
e8fc049f
SM
45362012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4537
4538 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4539
4fb9a543
GM
45402012-03-27 Glenn Morris <rgm@gnu.org>
4541
4542 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4543 Doc fixes.
4544
679910f1
KH
45452012-03-26 Kenichi Handa <handa@m17n.org>
4546
4547 * dispextern.h (struct glyph): Fix previous change. Change the
4548 bit length of glyphless.ch to 25 (Bug#11082).
4549
90d49b7f
CY
45502012-03-26 Chong Yidong <cyd@gnu.org>
4551
4552 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4553 (command_loop_1): Use it; inhibit selection update for
4554 handle-select-window too (Bug#8996).
4555
f514f6f0
FP
45562012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4557
e8fc049f 4558 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4559
bf43fa51
KH
45602012-03-25 Kenichi Handa <handa@m17n.org>
4561
4562 * dispextern.h (struct glyph): Change the bit length of
4563 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4564
8a0c01dd
EZ
45652012-03-24 Eli Zaretskii <eliz@gnu.org>
4566
4567 * s/ms-w32.h (tzname): Include time.h before redirecting to
4568 _tzname. Fixes the MSVC build. (Bug#9960)
4569
7d1c3a76
AS
45702012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4571
8ed79523
AS
4572 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4573 characters.
4574
7d1c3a76
AS
4575 * xterm.c (XTread_socket): Only modify handling_signal if
4576 !SYNC_INPUT. (Bug#11080)
4577
e99a9b8b
EZ
45782012-03-23 Eli Zaretskii <eliz@gnu.org>
4579
4580 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4581 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4582 when fetching a multibyte character consumes more bytes than
4583 CHAR_BYTES returns, due to unification of CJK characters in
4584 string_char. (Bug#11073)
4585
5063c0e1
TN
45862012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4587
4588 * process.c (wait_reading_process_output): Handle pty disconnect
4589 by refraining from sending oneself a SIGCHLD (bug#10933).
4590
9f851fbd
CY
45912012-03-22 Chong Yidong <cyd@gnu.org>
4592
4593 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4594
5063c0e1 4595 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4596 Mark string as coming from a prefix property.
4597 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4598 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4599
fb5b8aca
CY
46002012-03-21 Chong Yidong <cyd@gnu.org>
4601
4602 * xfaces.c (Vface_remapping_alist): Doc fix.
4603
62356a1b
EZ
46042012-03-20 Eli Zaretskii <eliz@gnu.org>
4605
4606 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4607 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4608 Doc fixes.
62356a1b 4609
025de85b
CY
46102012-03-20 Chong Yidong <cyd@gnu.org>
4611
4612 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4613 to reflect default non-nil value of redisplay-dont-pause.
4614
4827f94e
KH
46152012-03-19 Kenichi Handa <handa@m17n.org>
4616
4617 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4618 it fit in a valid range (Bug#11003).
4619
e50a24a2
EZ
46202012-03-18 Eli Zaretskii <eliz@gnu.org>
4621
4622 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4623 that is not from display property, accept the row as a "cursor
4624 row" if one of the string's character has a non-nil `cursor'
4625 property. Fixes cursor positioning when there are newlines in
4626 overlay strings, e.g. in icomplete.el. (Bug#11035)
4627
9af5ed87
PE
46282012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4629
4630 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4631
d1f55f16
CY
46322012-03-12 Chong Yidong <cyd@gnu.org>
4633
4634 * eval.c (inhibit_lisp_code): Rename from
4635 inhibit_window_configuration_change_hook; move from window.c.
4636
4637 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4638 * window.c (run_window_configuration_change_hook)
4639 (syms_of_window): Callers changed.
4640
66c5eebd
CY
46412012-03-11 Chong Yidong <cyd@gnu.org>
4642
413df973
CY
4643 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4644
66c5eebd
CY
4645 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4646
1de11f56
CY
46472012-03-10 Chong Yidong <cyd@gnu.org>
4648
4649 * frame.c (other_visible_frames): Don't assume the selected frame
4650 is visible (Bug#10955).
4651
cae07000
SM
46522012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4653
4654 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4655
89c94350
JD
46562012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4657
4658 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4659 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4660 zero (Bug#10954).
4661
999dd333
GM
46622012-03-03 Glenn Morris <rgm@gnu.org>
4663
01a6dcc8 4664 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4665
de0100f2
EZ
46662012-03-02 Eli Zaretskii <eliz@gnu.org>
4667
4668 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4669 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4670 (redisplay_window, next_element_from_string): Fix typos in
4671 comments.
3e441275
EZ
4672 (redisplay_window): Pass to move_it_vertically the margin in
4673 pixels, not in screen lines.
de0100f2 4674
96a72ee9
GM
46752012-03-02 Glenn Morris <rgm@gnu.org>
4676
4677 * buffer.c (buffer-list-update-hook): Doc fix.
4678
312508d7
EZ
46792012-02-29 Eli Zaretskii <eliz@gnu.org>
4680
4681 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4682 push_it before setting up the iterator for the first overlay
4683 string, even if we have an empty string loaded.
4684 (next_overlay_string): If there's an empty string on the iterator
4685 stack, pop the stack. (Bug#10903)
4686
27f3c637
PE
46872012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4688
4689 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4690 Suggested by Stefan Monnier in
4691 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4692 * alloc.c (widen_to_Lisp_Object): New static function.
4693 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4694 and widening them to Lisp_Objects. This would work even if
4695 USE_LSB_TAG is defined and wide integers are used, which might
4696 happen in a future version of Emacs.
4697
3c9dfce6
CY
46982012-02-25 Chong Yidong <cyd@gnu.org>
4699
fa74b241
CY
4700 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4701 Doc fix.
4702
3c9dfce6
CY
4703 * xselect.c (Fx_selection_exists_p): Doc fix.
4704 (x_clipboard_manager_save_all): Print an informative message
4705 before saving to clipboard manager.
4706
9486df08
CY
47072012-02-24 Chong Yidong <cyd@gnu.org>
4708
4709 * keyboard.c (process_special_events): Handle all X selection
4710 requests in kbd_buffer, not just the next one (Bug#8869).
4711
f01d3321
CY
47122012-02-23 Chong Yidong <cyd@gnu.org>
4713
4714 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4715 call when setting menu-bar-lines and tool-bar-lines parameters.
4716 (unwind_create_frame_1): New helper function.
4717
4718 * window.c (inhibit_window_configuration_change_hook): New var.
4719 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4720 (syms_of_window): Initialize it.
f01d3321 4721
86b847b6
CY
47222012-02-22 Chong Yidong <cyd@gnu.org>
4723
4724 * xterm.c (x_draw_image_relief): Add missing type check for
4725 Vtool_bar_button_margin (Bug#10743).
4726
a59225b1
CY
47272012-02-21 Chong Yidong <cyd@gnu.org>
4728
4729 * fileio.c (Vfile_name_handler_alist): Doc fix.
4730
4731 * buffer.c (Fget_file_buffer): Protect against invalid file
4732 handler return value.
4733
310f5bd4
PE
47342012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4735
cb3a28cc
PE
4736 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4737 when computing $valmask.
4738
310f5bd4
PE
4739 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4740 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4741 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4742 It's useless in that case, and it can cause problems on hosts
4743 that allocate halves of EMACS_INT values separately.
4744 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4745 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4746 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4747 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4748 it avoids undefined behavior on hosts where shifting right by more
4749 than the word width has undefined behavior.
4750
2375c96a
CY
47512012-02-19 Chong Yidong <cyd@gnu.org>
4752
4753 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4754 (Funhandled_file_name_directory, Ffile_name_as_directory)
4755 (Fdirectory_file_name, Fexpand_file_name)
4756 (Fsubstitute_in_file_name): Protect against invalid file handler
4757 return values (Bug#10845).
4758
3eb49e71
EZ
47592012-02-18 Eli Zaretskii <eliz@gnu.org>
4760
4761 * .gdbinit (pitx): Fix incorrect references to fields of the
4762 iterator stack.
4763
7b926f3f
CY
47642012-02-17 Chong Yidong <cyd@gnu.org>
4765
4766 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4767
11273115
PE
47682012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4769
4770 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4771 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4772
c3a70e2b
CY
47732012-02-15 Chong Yidong <cyd@gnu.org>
4774
4775 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4776 marked as special. Also, starting docstrings with * is obsolete.
4777
0ca43699
AS
47782012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4779
4780 * gnutls.c (emacs_gnutls_write): Fix last change.
4781
2e8f3c56
LI
47822012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4783
4784 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4785 send_process.
4786
af70074f
SM
47872012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4788
4789 * keymap.c (Fsingle_key_description): Handle char ranges.
4790
95986d52
CY
47912012-02-12 Chong Yidong <cyd@gnu.org>
4792
afd83bd1
CY
4793 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4794 as that creates a dangerous corner case.
4795
95986d52
CY
4796 * window.c (Fdelete_window_internal): Invalidate the mouse
4797 highlight (Bug#9904).
4798
bd7da63e
GM
47992012-02-12 Glenn Morris <rgm@gnu.org>
4800
4801 * xselect.c (Fx_own_selection_internal)
4802 (Fx_get_selection_internal, Fx_disown_selection_internal)
4803 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4804 * nsselect.m (Fx_own_selection_internal)
4805 (Fx_disown_selection_internal, Fx_selection_exists_p)
4806 (Fx_selection_owner_p, Fx_get_selection_internal):
4807 Sync docs and argument specs with the xselect.c versions.
4808
77abcbc2
LI
48092012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4810
4811 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4812
90b671e2
EZ
48132012-02-11 Eli Zaretskii <eliz@gnu.org>
4814
1c0ca0b7
EZ
4815 * w32select.c (Fx_selection_exists_p): Sync doc string and
4816 argument list with xselect.c. (Bug#10783)
4817
4818 * w16select.c (Fx_selection_exists_p): Sync doc string and
4819 argument list with xselect.c. (Bug#10783)
90b671e2 4820
49241268
GM
48212012-02-10 Glenn Morris <rgm@gnu.org>
4822
4823 * fns.c (Fsecure_hash): Doc fix.
4824
f998bbe7 48252012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4826
4827 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4828
0992bd9c
CY
48292012-02-07 Chong Yidong <cyd@gnu.org>
4830
4831 * buffer.c (Fbuffer_local_variables)
4832 (buffer_lisp_local_variables): Handle unbound vars correctly;
4833 don't let Qunbound leak into Lisp.
4834
af008560
GM
48352012-02-07 Glenn Morris <rgm@gnu.org>
4836
dd605cc4
GM
4837 * image.c (Fimagemagick_types): Doc fix.
4838
af008560
GM
4839 * image.c (imagemagick-render-type): Change it from a lisp object
4840 to an integer. Move the doc here from the lisp manual.
4841 Treat all values not equal to 0 the same.
4842
1449fa1d
CY
48432012-02-06 Chong Yidong <cyd@gnu.org>
4844
4845 * doc.c (store_function_docstring): Avoid applying docstring of
4846 alias to base function (Bug#2603).
4847
3723ec07
AS
48482012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4849
4850 * .gdbinit (pp1, pv1): Remove redundant defines.
4851 (pr): Use pp.
4852
79c1cc1e
CY
48532012-02-04 Chong Yidong <cyd@gnu.org>
4854
4855 * nsterm.m: Declare a global (Bug#10694).
4856
d7f29f8e
EZ
48572012-02-04 Eli Zaretskii <eliz@gnu.org>
4858
cae07000
SM
4859 * w32.c (get_emacs_configuration_options):
4860 Include --enable-checking, if specified, in the return value.
d7f29f8e 4861
3b95a6f9
MR
48622012-02-04 Martin Rudalics <rudalics@gmx.at>
4863
4864 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4865 after rounding frame sizes. (Bug#9723)
4866
d6fa96a6
EZ
48672012-02-04 Eli Zaretskii <eliz@gnu.org>
4868
4869 * keyboard.c (adjust_point_for_property): Don't position point
4870 before BEGV. (Bug#10696)
4871
df0b2940
PE
48722012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4873
4874 Handle overflow when computing char display width (Bug#9496).
4875 * character.c (char_width): Return EMACS_INT, not int.
4876 (char_width, c_string_width): Check for overflow when
4877 computing the width; this is possible now that individual
4878 characters can have unbounded width. Problem introduced
4879 by merge from Emacs 23 on 2012-01-19.
4880
6bee44d6
MA
48812012-02-02 Michael Albinus <michael.albinus@gmx.de>
4882
4883 * dbusbind.c (Fdbus_register_method): Mention the return value
4884 :ignore in the docstring.
4885
44f92739
GM
48862012-02-02 Glenn Morris <rgm@gnu.org>
4887
1b9f60cc
GM
4888 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4889
44f92739
GM
4890 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4891 Unconditionally set to t. (Bug#10673)
4892 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4893 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4894 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4895
c5d3843c
KH
48962012-02-02 Kenichi Handa <handa@m17n.org>
4897
4898 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4899 0, do not call append_composite_glyph.
4900
159462d4 49012012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4902
4903 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4904 NULL (Bug#6988).
4905 (x_produce_glyphs): If the component of a composition is a null
4906 string, set it->pixel_width to 1 to avoid zero-width glyph.
4907
78cef877
EZ
49082012-02-01 Eli Zaretskii <eliz@gnu.org>
4909
4910 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4911 first 2 arguments are identical. This makes inserting large
4912 output from a subprocess an order of magnitude faster on
4913 MS-Windows, where all sbrk'ed memory is always contiguous.
4914
97897668
GM
49152012-01-31 Glenn Morris <rgm@gnu.org>
4916
4917 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4918 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4919 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4920
31fd3586
GM
49212012-01-29 Glenn Morris <rgm@gnu.org>
4922
4923 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4924
0e24a8b2
CY
49252012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4926
4927 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4928
cc0adcb0
CY
49292012-01-28 Chong Yidong <cyd@gnu.org>
4930
4931 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4932
acc28cb9
CY
49332012-01-26 Chong Yidong <cyd@gnu.org>
4934
9c69cfb7
CY
4935 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4936
acc28cb9
CY
4937 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4938 repeat counts (Bug#10507).
4939
48da7392
GM
49402012-01-26 Glenn Morris <rgm@gnu.org>
4941
4942 * lread.c (syms_of_lread): Doc fix.
4943
14af5f7f
CY
49442012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4945
4946 * coding.c (encode_designation_at_bol): Change return value to
4947 EMACS_INT.
4948
0b21c100
CY
49492012-01-25 Chong Yidong <cyd@gnu.org>
4950
4951 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4952
3c2907f7
CY
49532012-01-21 Chong Yidong <cyd@gnu.org>
4954
4955 * floatfns.c (Fcopysign): Make the second argument non-optional,
4956 since nil is not allowed anyway.
4957
959ad23f
AS
49582012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4959
4960 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4961 (send_process): Likewise.
4962
34a02f46
MR
49632012-01-19 Martin Rudalics <rudalics@gmx.at>
4964
4965 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4966 (Vwindow_persistent_parameters): Do not use Qstate.
4967 Rewrite doc-strings.
34a02f46 4968
1259009a 49692012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4970
4971 * character.c (char_width): New function.
70d4fdf6
GM
4972 (Fchar_width, c_string_width, lisp_string_width):
4973 Use char_width (Bug#9496).
25ed9e61 4974
6a6ee00d
MR
49752012-01-16 Martin Rudalics <rudalics@gmx.at>
4976
4977 * window.c (Vwindow_persistent_parameters): New variable.
4978 (Fset_window_configuration, save_window_save): Handle persistent
4979 window parameters.
4980
c85efaf7
EZ
49812012-01-14 Eli Zaretskii <eliz@gnu.org>
4982
4983 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4984 thrashing the stack of the thread. (Bug#9087)
4985
5944709e
PE
49862012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4987
4988 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4989
e71f5d99
EZ
49902012-01-11 Eli Zaretskii <eliz@gnu.org>
4991
4992 * xdisp.c (rows_from_pos_range): Handle the case where the
4993 highlight ends on a newline. (Bug#10464)
4994 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4995 he end column for display of highlight that ends on a newline
4996 before a R2L line.
4997
ce316182
GM
49982012-01-11 Glenn Morris <rgm@gnu.org>
4999
5000 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5001 from load-path also when installation-directory is nil. (Bug#10208)
5002
5b43da69
GM
50032012-01-10 Glenn Morris <rgm@gnu.org>
5004
74cc8ff9
GM
5005 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5006
7d8d6e4e
GM
5007 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5008 Update template values to be closer to their typical values these days.
5b43da69 5009
a0db8d43
EZ
50102012-01-09 Eli Zaretskii <eliz@gnu.org>
5011
5012 * xdisp.c (rows_from_pos_range): Accept additional argument
5013 DISP_STRING, and accept any glyph in a row whose object is that
5014 string as eligible for mouse highlight. Fixes mouse highlight of
5015 display strings from overlays. (Bug#10464)
5016
9a0115ab 50172012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5018
b9110d6a 5019 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5020 * fileio.c (auto_saving_dir_umask): New static var.
5021 (Fmake_directory_internal): Use it.
5022 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5023 creating the directory. The old code temporarily assigns
5024 too-generous permissions to the directory.
5025 (do_auto_save_eh): Clear it.
b9110d6a 5026 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5027 that the var is always cleared.
5028
6c1bd3f3
EZ
50292012-01-07 Eli Zaretskii <eliz@gnu.org>
5030
5031 * search.c (scan_buffer): Pass character positions to
5032 know_region_cache, not byte positions. (Bug#6540)
5033
069d2b50
L
50342012-01-07 LynX <_LynX@bk.ru> (tiny change)
5035
5036 * w32.c (sys_rename): Report EXDEV when rename of a directory
5037 fails because the target is on another logical disk. (Bug#10284)
5038
75bf0d33
DB
50392012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5040
5041 * xterm.c (x_embed_request_focus): New function.
5042
5043 * xterm.h: Add prototype.
5044
5045 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5046
1c6e5a32
GM
50472012-01-05 Glenn Morris <rgm@gnu.org>
5048
5049 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5050
651e947e
EZ
50512012-01-01 Eli Zaretskii <eliz@gnu.org>
5052
5053 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5054 Load gnutls_transport_set_lowat only if GnuTLS version is below
5055 2.11.1.
5056 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5057 GnuTLS versions below 2.11.1.
5058
3778cdd8
AL
50592011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5060
5061 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5062 to the doc string advising against its use for altering the way
5063 windows are scrolled.
5064
0e5317f7
KH
50652011-12-28 Kenichi Handa <handa@m17n.org>
5066
5067 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5068 coding-system ASCII compatible only when it does not produce BOM
5069 on encoding (Bug#10383).
5070
93d5ca1f
JD
50712011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5072
5073 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5074 can scroll.
5075 (create_and_show_popup_menu): Always use menu_position_func for
5076 Gtk3 (Bug#10361).
5077
ca22b785
AS
50782011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5079
5080 * callint.c (Fcall_interactively): Don't truncate prompt string.
5081
d048e1e6
EZ
50822011-12-23 Eli Zaretskii <eliz@gnu.org>
5083
5084 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5085 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5086 resumed from there (after widening). (Bug#10360)
d048e1e6 5087
5ccaba1f
JD
50882011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5089
5090 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5091
204ee57f
JD
50922011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5093
b81d40f0
JB
5094 * nsterm.m (x_free_frame_resources):
5095 Release f->output_data.ns->miniimage.
204ee57f
JD
5096 (ns_index_color): Fix indentation. Do not retain
5097 color_table->colors[i].
5098
5099 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5100 before returning.
5101
5102 * nsfns.m (x_set_background_color): Assign return value from
5103 ns_index_color to face-background instead of NSColor*.
5104 (ns_implicitly_set_icon_type): Fix indentation.
5105 Change assignment in for loop to comparison.
5106
5107 * emacs.c (ns_pool): New variable.
5108 (main): Assign ns_pool.
5109 (Fkill_emacs): Call ns_release_autorelease_pool.
5110
5111 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5112 autorelease fdesc, release fdAttrs and tdict.
5113 (ns_get_covering_families): Release charset.
5114 (ns_findfonts): Release NSFontDescriptor created with new.
5115 (ns_uni_to_glyphs): Fix indentation.
5116 (setString): Release attrStr before assigning new value.
5117
c803b2b7
JD
51182011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5119
678f4426
JD
5120 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5121 and NS_IMPL_COCOA.
5122 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5123 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5124
cd394be1 51252011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5126
5fecd5fc
JD
5127 * nsterm.m (ns_term_init): Subscribe for notifications
5128 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5129 to method trackingNotification in EmacsMenu.
5130
5131 * nsmenu.m (trackingMenu): New variable.
3771cb17 5132 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5133 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5134 from Aquamacs (Bug#7030).
678f4426
JD
5135
51362011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5137
c803b2b7
JD
5138 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5139 (symbol_to_nsstring): Fix indentation.
5140 (ns_symbol_to_pb): New function.
cae07000
SM
5141 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5142 (Fns_rotate_cut_buffers_internal): Remove.
5143 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5144 Fns_store_cut_buffer_internal.
5145 (ns_get_foreign_selection, Fx_own_selection_internal)
5146 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5147 (Fns_get_selection_internal, Fns_store_selection_internal):
5148 Use ns_symbol_to_pb and check if return value is nil.
5149 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5150 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5151 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5152 renamed to Sns_store_selection_internal.
5153 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5154 and remove this function.
5155 (ns_handle_selection_clear): Remove, never used.
5156 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5157 here.
5158
e1b01a3a
KB
51592011-12-17 Ken Brown <kbrown@cornell.edu>
5160
5161 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5162 GID is unknown (Bug#10257).
5163
2adb6e85
PE
51642011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5165
5166 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5167 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5168 which caused a build failure on GNU/Linux IA-64. This problem was
5169 introduced by my 2011-10-07 patch.
5170
d1d7b339
JL
51712011-12-15 Juri Linkov <juri@jurta.org>
5172
5173 * image.c (imagemagick_error): New function. (Bug#10112)
5174 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5175 Use `imagemagick_error' where ImageMagick functions return
5176 `MagickFalse'.
5177 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5178 proper order.
5179
100d5755
KH
51802011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5181
5182 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5183 fill background (Bug#8992).
5184
454592a6
MR
51852011-12-13 Martin Rudalics <rudalics@gmx.at>
5186
5187 * window.c (Vwindow_combination_resize)
5188 (Vwindow_combination_limit): Use t instead of non-nil in
5189 doc-strings.
61d4b438
MR
5190 (Vrecenter_redisplay): Add first sentence of doc-string on
5191 separate line.
53524d93 5192 (Frecenter): Fix doc-string typo.
454592a6 5193
3633e3aa
KH
51942011-12-11 Kenichi Handa <handa@m17n.org>
5195
5196 * coding.c (Funencodable_char_position): Pay attention to the
5197 buffer text relocation (Bug#9389).
5198
7b9d523a 51992011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5200
7b9d523a
JD
5201 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5202 gtk_init (Bug#10100).
5203
b73189c6
EZ
52042011-12-10 Eli Zaretskii <eliz@gnu.org>
5205
5206 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5207 IT->string is nil. (Bug#10263)
5208
f7dfe5d6
JD
52092011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5210
83faebb4
JD
5211 * nsterm.h (x_free_frame_resources): Declare.
5212
f7dfe5d6
JD
5213 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5214 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5215
5216 * nsterm.h (ns_get_defaults_value): Declare.
5217
5218 * nsterm.m (ns_default): Call ns_get_defaults_value.
5219
7cd4e72c
EZ
52202011-12-09 Eli Zaretskii <eliz@gnu.org>
5221
5222 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5223 (Bug#10170)
5224
b34d7317
YM
52252011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5226
5227 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5228 that where the value of an _OBJC_* symbol points to is in the .bss
5229 section (Bug#10240).
5230
76470ad1
KH
52312011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5232
5233 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5234 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5235
745fff94
KH
52362011-12-08 Kenichi Handa <handa@m17n.org>
5237
5238 * ftfont.c (get_adstyle_property): Fix previous change
5239 (Bug#10233).
5240
6e44397c
JB
52412011-12-07 Juanma Barranquero <lekktu@gmail.com>
5242
5243 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5244 dirs from the default value of EMACSLOADPATH (bug#10208).
5245
7efa6272
GM
52462011-12-07 Glenn Morris <rgm@gnu.org>
5247
5248 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5249 installation and source directories as well. (Bug#10208)
5250
f6fc4d87
CY
52512011-12-06 Chong Yidong <cyd@gnu.org>
5252
5253 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5254
2bf26180
GM
52552011-12-06 Glenn Morris <rgm@gnu.org>
5256
5257 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5258 as an error, not just -1. (Bug#10217)
5259
3a6ad4f0
CY
52602011-12-05 Chong Yidong <cyd@gnu.org>
5261
5262 * keyboard.c (process_special_events): New function.
5263 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5264
75a3b399
PE
52652011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5266
5267 * coding.c (encode_designation_at_bol): Don't use uninitialized
5268 local variable (Bug#9318).
5269
c3c9e25e
KH
52702011-12-05 Kenichi Handa <handa@m17n.org>
5271
5272 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5273 return Qnil (Bug#8046, Bug#10193).
5274
5eb05ea3
KH
52752011-12-05 Kenichi Handa <handa@m17n.org>
5276
5277 * coding.c (encode_designation_at_bol): New args charbuf_end and
5278 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5279 (coding_set_source): Return how many bytes coding->source was
5280 relocated.
5281 (coding_set_destination): Return how many bytes
5282 coding->destination was relocated.
5283 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5284 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5285
52862011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5287
5288 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5289 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5290 macro (Bug#9318).
5291
52922011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5293
5294 The following changes are to fix Bug#9318.
5295
a79703f5 5296 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5297 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5298 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5299 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5300
7dbda6df
JB
53012011-12-05 Juanma Barranquero <lekktu@gmail.com>
5302
5303 * lisp.h (process_quit_flag): Fix external declaration.
5304
6d5eb5b0
SM
53052011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5306
5307 Don't macro-inline non-performance-critical code.
5308 * eval.c (process_quit_flag): New function.
5309 * lisp.h (QUIT): Use it.
5310
a0c3fad0
JD
53112011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5312
5313 * nsfns.m (get_geometry_from_preferences): New function.
5314 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5315
6c07aac2
AS
53162011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5317
5318 * emacs.c (Qkill_emacs): Define.
5319 (syms_of_emacs): Initialize it.
5320 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5321 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5322 (quit_throw_to_read_char): Add parameter `from_signal'.
5323 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5324 * lisp.h (QUIT): Call Fkill_emacs if requested.
5325
c052ead4
JD
53262011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5327
5328 * widget.c (update_wm_hints): Return if wmshell is null.
5329 (widget_update_wm_size_hints): New function.
5330
5331 * widget.h (widget_update_wm_size_hints): Declare.
5332
5333 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5334 widget_update_wm_size_hints (Bug#10104).
5335
9e49252b
EZ
53362011-12-03 Eli Zaretskii <eliz@gnu.org>
5337
5338 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5339 before a newline, prepare the bidi iterator for consuming the
5340 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5341 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5342
02b16839
JL
53432011-12-02 Juri Linkov <juri@jurta.org>
5344
5345 * search.c (Fword_search_regexp): New Lisp function created from
5346 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5347 (Fword_search_backward, Fword_search_forward)
5348 (Fword_search_backward_lax, Fword_search_forward_lax):
5349 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5350 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5351
0068070e
SM
53522011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5353
5354 * fileio.c (Finsert_file_contents): Move after-change-function call
5355 to before the "handled:" label, since all "goto handled" appear in
5356 cases where the *-change-functions have already been properly called
5357 (bug#10117).
5358
3360a3fc
AS
53592011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5360
5361 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5362 waiting for input. (Bug#10169)
5363
73d6c093
EZ
53642011-11-30 Eli Zaretskii <eliz@gnu.org>
5365
5366 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5367 verifies glyph row's hash code--we have just reallocated the
5368 glyphs, so their contents can be complete garbage. (Bug#10164)
5369
febe6bea
JB
53702011-11-30 Juanma Barranquero <lekktu@gmail.com>
5371
5372 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5373
801a4313
EZ
53742011-11-30 Eli Zaretskii <eliz@gnu.org>
5375
5376 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5377 attributes are tested _before_ calling verify_row_hash, to protect
5378 against GCC re-ordering of the tests. (Bug#10164)
5379
2b56b87e
JD
53802011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5381
5382 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5383
5384 * xterm.c (handle_one_xevent): Only set async_visible and friends
5385 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5386 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5387 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5388
dbf31225
PE
53892011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5390
5391 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5392 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5393 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5394 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5395 All uses changed to use GCPRO1 etc.
5396 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5397 Revert to old implementation (i.e., before 2011-03-11).
5398
1305621b
YM
53992011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5400
5401 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5402 of scroll runs so as to avoid assigning disabled bogus rows and
5403 unnecessary graphics copy operations.
5404
8c9afb46
EZ
54052011-11-27 Eli Zaretskii <eliz@gnu.org>
5406
5407 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5408 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5409 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5410 (malloc, free, realloc, calloc): Redirect to e_* only when
5411 compiling Emacs.
5412
5413 * lisp.h (GCTYPEBITS): Move before first use.
5414 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5415 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5416 this macro definition.
5417
5418 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5419 _MSC_VER.
5420
54e9e3bf
JD
54212011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5422
6d5eb5b0
SM
5423 * gtkutil.c (xg_create_frame_widgets):
5424 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5425 present with Gtk+ 2.0.
5426
83aca1cb
PE
54272011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5428
5429 * fileio.c (Finsert_file_contents): Undo previous change; see
5430 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5431
5b76caa4
PE
54322011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5433
5434 Rename locals to avoid shadowing.
5435 * fileio.c (Finsert_file_contents):
5436 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5437 * process.c (wait_reading_process_output):
5438 Rename inner 'proc' to 'p' to avoid shadowing.
5439 Indent for consistency with usual Emacs style.
5440
8c535114
EZ
54412011-11-25 Eli Zaretskii <eliz@gnu.org>
5442
5443 * xdisp.c (redisplay_window): If cursor row is not fully visible
5444 after recentering, and scroll-conservatively is set to a large
5445 number, scroll window by a few more lines to make the cursor fully
5446 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5447 (start_display): Don't move to the next line if the display should
5448 start at a newline that is part of a display vector or an overlay
5449 string. (Bug#10119)
8c535114 5450
fa4fdb5c
JL
54512011-11-24 Juri Linkov <juri@jurta.org>
5452
5453 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5454 after the `MagickPingImage' call. (Bug#10112)
5455
90ec88df
CY
54562011-11-23 Chong Yidong <cyd@gnu.org>
5457
5458 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5459
56e2e794
MR
54602011-11-23 Martin Rudalics <rudalics@gmx.at>
5461
5462 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5463 making another buffer current. (Bug#10114)
5464
b6e64c41
GM
54652011-11-23 Glenn Morris <rgm@gnu.org>
5466
5467 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5468
6b21de18
CY
54692011-11-23 Chong Yidong <cyd@gnu.org>
5470
5471 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5472 using it (Bug#5984).
5473
b12cd789
EZ
54742011-11-22 Eli Zaretskii <eliz@gnu.org>
5475
5476 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5477 and header-lines, as they don't have one computed for them.
5478 (Bug#10098)
5479
5480 * .gdbinit (prow): Make displayed values more self-explaining.
5481 Add row's hash code.
5482
261b6fd4
LMI
54832011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5484
5485 * process.c (wait_reading_process_output): Fix asynchrounous
5486 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5487 (wait_reading_process_output): Add comment and URL.
261b6fd4 5488
e7cfd277
JD
54892011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5490
5491 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5492
a9b9b7f5
CY
54932011-11-21 Chong Yidong <cyd@gnu.org>
5494
5495 * window.c (Fnext_window, Fprevious_window): Doc fix.
5496
b0d15b4f
SM
54972011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5498
5499 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5500
fe7a3057
JB
55012011-11-20 Juanma Barranquero <lekktu@gmail.com>
5502
5503 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5504
d2999b1a
MR
55052011-11-20 Martin Rudalics <rudalics@gmx.at>
5506
5507 * window.c (Fset_window_combination_limit): Rename argument
5508 STATUS to LIMIT.
5509 (Vwindow_combination_limit): Remove "status" from doc-string.
5510
d5ff9cd0
AS
55112011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5512
5513 * m/ibms390.h: Remove.
5514 * m/ibms390x.h: Don't include "ibms390.h".
5515
a5bb9bd3
SM
55162011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5517
5518 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5519 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5520
cd1181db
JB
55212011-11-20 Juanma Barranquero <lekktu@gmail.com>
5522
5523 * casetab.c (Fset_case_table):
5524 * charset.c (Fcharset_after): Fix typos.
5525
615a3b8d 55262011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5527
17e845af
PE
5528 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5529 Otherwise, valgrind does not work on some platforms.
5530 Problem reported by Andreas Schwab in
6a0bf43d
PE
5531 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5532 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5533 is set, removing the need for VIRT_ADDRESS_VARIES.
5534 (PURE_P): Use a more-efficient implementation that needs just one
5535 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5536 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5537 to 4 (xorl, subq, cmpq, setbe).
5538 * alloc.c (pure): Always extern now, since that's the
5539 VIRT_ADDR_VARIES behavior.
5540 (PURE_POINTER_P): Use a single comparison, not two, for
5541 consistency with the new puresize.h.
5542 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5543 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5544 Remove VIRT_ADDR_VARIES no longer needed.
5545
f8fe6f96
EZ
55462011-11-19 Eli Zaretskii <eliz@gnu.org>
5547
5548 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5549 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5550 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5551 behave as if the cursor position were at the window margin.
5552
5553 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5554 and the cursor position is out of bounds, behave as if the cursor
5555 position were at the window margin. (Bug#10075)
5556
df05a53c
CY
55572011-11-18 Chong Yidong <cyd@gnu.org>
5558
5559 * window.c (Fwindow_combination_limit): Make first argument
5560 non-optional, since it is meaningless for live windows like the
5561 selected window.
61ccba97 5562
2071918e
DA
55632011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5564
5565 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5566
b50a28de
SM
55672011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5568
5569 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5570 (graft_intervals_into_buffer): Simplify.
5571
015137db
EZ
55722011-11-18 Eli Zaretskii <eliz@gnu.org>
5573
5574 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5575 hash values of the two rows.
5576 (copy_row_except_pointers): Preserve the used[] arrays and the
5577 hash values of the two rows. (Bug#10035)
68c95424 5578 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5579
5580 * xdisp.c (row_hash): New function, body extracted from
5581 compute_line_metrics.
5582 (compute_line_metrics): Call row_hash, instead of computing the
5583 hash code inline.
5584
5585 * dispnew.c (verify_row_hash): Call row_hash for computing the
5586 hash code of a row, instead of duplicating code from xdisp.c.
5587
5588 * dispextern.h (row_hash): Add prototype.
5589
a2addb04
TH
55902011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5591
5592 * frame.c (delete_frame): Don't delete the terminal when the last
5593 X frame is closed if emacs is built with GTK toolkit.
5594
df85d315
JB
55952011-11-17 Juanma Barranquero <lekktu@gmail.com>
5596
5597 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5598
a0c2d0ae
MR
55992011-11-17 Martin Rudalics <rudalics@gmx.at>
5600
5601 * window.c (Vwindow_splits): Rename to
5602 Vwindow_combination_resize. Suggested by Juri Linkov.
5603 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5604 of Vwindow_splits.
5605
58179cce
JB
56062011-11-16 Juanma Barranquero <lekktu@gmail.com>
5607
7877f373
JB
5608 * nsfns.m (Fns_font_name):
5609 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5610
b6f67890
MR
56112011-11-16 Martin Rudalics <rudalics@gmx.at>
5612
5613 * window.h (window): Rename slot "nest" to "combination_limit".
5614 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5615 (Fset_window_nest): Rename to Fset_window_combination_limit.
5616 (Vwindow_nest): Rename to Vwindow_combination_limit.
5617 (recombine_windows, make_parent_window, make_window)
5618 (Fsplit_window_internal, saved_window)
5619 (Fset_window_configuration, save_window_save): Rename all
5620 occurrences of window_nest to window_combination_limit.
5621
c7015153
JB
56222011-11-15 Juanma Barranquero <lekktu@gmail.com>
5623
5624 * image.c (imagemagick_load_image): Fix typo.
5625
322ad6ec
EZ
56262011-11-14 Eli Zaretskii <eliz@gnu.org>
5627
5628 * xdisp.c (display_line): Move the call to
5629 highlight_trailing_whitespace before the call to
5630 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5631 faces of all the glyphs to compute ROW's hash value.
5632 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5633
f067b8ec
JB
56342011-11-14 Juanma Barranquero <lekktu@gmail.com>
5635
5636 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5637 just return (bug#10044).
5638
1e5b2111
EZ
56392011-11-12 Eli Zaretskii <eliz@gnu.org>
5640
7ef3cbd5
EZ
5641 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5642 with user-defined heap size. Bump the default size of the temacs
5643 heap to 27MB, to avoid memory warning when running temacs.
5644 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5645
1e5b2111
EZ
5646 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5647 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5648 (verify_row_hash) [XASSERTS]: New function.
5649 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5650 that the hash value of glyph rows is correct.
1e5b2111 5651
89d61221
MR
56522011-11-12 Martin Rudalics <rudalics@gmx.at>
5653
5654 * window.h (window): Remove splits slot.
5655 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5656 (Fdelete_other_windows_internal, make_parent_window)
5657 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5658 (Fset_window_configuration, save_window_save): Don't deal with
5659 split status of windows.
5660 (saved_window): Remove splits slot.
5661 (Vwindow_splits): Rewrite doc-string.
5662
97f18cc8
JD
56632011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5664
5665 * xfns.c (unwind_create_frame):
5666 * nsfns.m (unwind_create_frame):
5667 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5668 Vframe_list (Bug#9999).
5669
22a648b4
DA
56702011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5671
0b381c7e 5672 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5673
659afede
KH
56742011-11-11 Kenichi Handa <handa@m17n.org>
5675
5676 * callproc.c (Fcall_process): Set the member dst_multibyte of
5677 process_coding.
5678
9ac0394b
KH
56792011-11-11 Johan Bockgård <bojohan@gnu.org>
5680
5681 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5682 avoid a crash (bug#9496).
5683
2fbdc249
CY
56842011-11-09 Chong Yidong <cyd@gnu.org>
5685
5686 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5687 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5688
ac6b1f81
PE
56892011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5690
5691 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5692
09db192c
PE
56932011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5694
5695 Avoid some portability problems by eschewing 'extern inline' functions.
5696 The trivial performance wins aren't worth the portability hassles; see
5697 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5698 et seq.
5699 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5700 (window_box_width, window_box_left, window_box_left_offset)
5701 (window_box_right, window_box_right_offset): Undo previous change,
5702 by removing the "extern"s.
5703 * intervals.c (adjust_intervals_for_insertion)
5704 (adjust_intervals_for_deletion): Undo previous change,
5705 making these static again.
5706 (offset_intervals, temp_set_point_both, temp_set_point)
5707 (copy_intervals_to_string): No longer inline.
5708 * xdisp.c (window_text_bottom_y, window_box_width)
5709 (window_box_height, window_box_left_offset)
5710 (window_box_right_offset, window_box_left, window_box_right)
5711 (window_box): No longer inline.
5712
105216ed
CY
57132011-11-08 Chong Yidong <cyd@gnu.org>
5714
5715 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5716 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5717 Signal an error if not a live window.
105216ed
CY
5718 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5719 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5720
ae9e237f
JB
57212011-11-07 Juanma Barranquero <lekktu@gmail.com>
5722
5723 * lisp.h (syms_of_abbrev): Remove declaration.
5724 Reported by CHENG Gao <chenggao@royau.me>.
5725
c7aa8333
EZ
57262011-11-07 Eli Zaretskii <eliz@gnu.org>
5727
5728 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5729 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5730 of temacs in GUI mode.
5731
be7f5545
MR
57322011-11-07 Martin Rudalics <rudalics@gmx.at>
5733
5734 * window.h: Declare delete_all_child_windows instead of
5735 delete_all_subwindows.
5736 * window.c (Fwindow_nest, Fset_window_nest)
5737 (Fset_window_new_total, Fset_window_new_normal)
5738 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5739 (delete_all_subwindows): Rename to delete_all_child_windows.
5740 (Fdelete_other_windows_internal, Fset_window_configuration):
5741 Call delete_all_child_windows instead of delete_all_subwindows.
5742 * frame.c (delete_frame): Call delete_all_child_windows instead
5743 of delete_all_subwindows.
5744
ca78dc43
PE
57452011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5746
5747 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5748 This is also needed for porting to any host where GC_MARK_STACK is
5749 not GC_MAKE_GCPROS_NOOPS.
5750 (which_symbols): Use it.
5751
a0241d01
KH
57522011-11-07 Kenichi Handa <handa@m17n.org>
5753
5754 * coding.c (coding_set_destination): Check coding->src_pos only
5755 when coding->src_object is a buffer (bug#9910).
5756
5757 * process.c (send_process): Set the member src_multibyte of coding
5758 to 0 (bug#9911) when sending a unibyte text.
5759
5760 * callproc.c (Fcall_process): Set the member src_multibyte of
5761 process_coding to 0 (bug#9912).
5762
a64bfdfa 57632011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5764
5765 * xmenu.c (cleanup_widget_value_tree): New function.
5766 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5767 calling free_menubar_widget_value_tree directly (Bug#9830).
5768
cb41b32a
PE
57692011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5770
5771 Fix some portability problems with 'inline'.
5772 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5773 (window_box_width, window_box_left, window_box_left_offset)
5774 (window_box_right, window_box_right_offset): Declare extern.
5775 Otherwise, these inline functions do not conform to C99 and
5776 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5777 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5778 * intervals.c (adjust_intervals_for_insertion)
5779 (adjust_intervals_for_deletion): Now extern, because otherwise the
5780 extern inline functions 'offset_intervals' couldn't refer to it.
5781 (static_offset_intervals): Remove.
5782 (offset_intervals): Rewrite using the old contents of
5783 static_offset_intervals. The old version didn't conform to C99
5784 because an extern inline function contained a reference to an
5785 identifier with static linkage.
5786
b7041366
AS
57872011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5788
5789 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5790 GC.
5791
88a37c4d
EZ
57922011-11-06 Eli Zaretskii <eliz@gnu.org>
5793
5794 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5795 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5796 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5797 return Qleft_to_right.
5798
49745b39
CY
57992011-11-06 Chong Yidong <cyd@gnu.org>
5800
5801 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5802 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5803 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5804 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5805 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5806 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5807 (Fwindow_vscroll): Doc fix.
5808 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5809 argument, since it makes no sense to pass a live window and for
5810 consistency with window-child.
5811
1f05cd82
CS
58122011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5813
5814 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5815 support MSVC.
5816
22610910
JR
58172011-11-05 Jason Rumney <jasonr@gnu.org>
5818
5819 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5820 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5821 fonts (Bug#6029).
5822 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5823 bitwise arithmetic preventing use of unicode-sip and non-truetype
5824 opentype fonts.
5825
a06776b2
EZ
58262011-11-05 Eli Zaretskii <eliz@gnu.org>
5827
3ad924ba
EZ
5828 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5829 "emacs"-only part.
5830
a06776b2
EZ
5831 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5832 initialization code to keep similarity to xfns.c after changes
5833 from 2011-11-05.
5834
c9e7db78
JD
58352011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5836
a97f8f3f
JD
5837 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5838 (unwind_create_frame): New function (Bug#9943).
5839 (Fx_create_frame): Restructure code to be more similar to the one in
5840 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5841 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5842 Move terminal->reference_count++ just before making the frame official
5843 (Bug#9943).
5844
5845 * nsterm.m (x_free_frame_resources): New function.
5846 (x_destroy_window): Move code to x_free_frame_resources.
5847
c9e7db78 5848 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5849 (Fx_create_frame, x_create_tip_frame):
5850 Move terminal->reference_count++ just before making the frame
75f1671a 5851 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5852 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5853
a6fc3b5c
EZ
58542011-11-05 Eli Zaretskii <eliz@gnu.org>
5855
5856 Support MSVC build with newer versions of Visual Studio.
5857 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5858 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5859 nt/gmake.defs.
5860
5861 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5862 which are not supported by MSVC.
5863 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5864 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5865 bitfields.
5866 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5867 types in bitfields.
5868 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5869
5870 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5871
58179cce 58722011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5873
5874 Support MSVC build with newer versions of Visual Studio.
5875 * w32.c: Don't include w32api.h for MSVC.
5876 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5877
5878 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5879 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5880 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5881 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5882 e_* cousins.
5883 (alloca) [_MSC_VER]: Define to _alloca.
5884
5885 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5886
5887 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5888
a58c13ed
EZ
58892011-11-04 Eli Zaretskii <eliz@gnu.org>
5890
5891 * xdisp.c (note_mouse_highlight): If either of
5892 previous/next-single-property-change returns nil, treat that as
5893 the beginning or the end of the buffer. (Bug#9955)
5894
fe0b6370
JD
58952011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5896
a58c13ed 5897 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5898 label is not null (Bug#9951).
5899 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5900 may be NULL.
5901
89bd5ee1
EZ
59022011-11-04 Eli Zaretskii <eliz@gnu.org>
5903
5904 * window.c (Fwindow_body_size): Mention in the doc string that the
5905 return value is in frame's canonical units. (Bug#9949)
5906
84c3edb9
EZ
59072011-11-03 Eli Zaretskii <eliz@gnu.org>
5908
4e2fb5c7
EZ
5909 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5910
84c3edb9 5911 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5912 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5913 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5914
bc17a887
EZ
59152011-11-01 Eli Zaretskii <eliz@gnu.org>
5916
5917 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5918 Don't stop backward scan on the continuation glyph, even though
5919 its CHARPOS is positive.
6d5eb5b0
SM
5920 (mouse_face_from_buffer_pos, note_mouse_highlight):
5921 Rename cover_string to disp_string.
bc17a887 5922
4ee88440
MR
59232011-11-01 Martin Rudalics <rudalics@gmx.at>
5924
5925 * window.c (temp_output_buffer_show): Don't use
5926 Vtemp_buffer_show_specifiers.
5927 (Vtemp_buffer_show_specifiers): Remove unused variable.
5928
c2ff3c02
EZ
59292011-10-30 Eli Zaretskii <eliz@gnu.org>
5930
5931 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5932 past the beginning of the current glyph matrix.
5933
58179cce 59342011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5935
5936 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5937 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5938 HAVE_GTK3 (Bug#9869).
b77a6a7f 5939
3b574623
JD
5940 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5941 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5942
b77a6a7f
JD
5943 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5944
5945 * xterm.c: Declare x_handle_net_wm_state to return int.
5946 (handle_one_xevent): Check if we are iconified but don't have
5947 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5948 (get_current_wm_state): Return non-zero if not hidden,
5949 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5950 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5951 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5952 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5953
196e41e4
PE
59542011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5955
5956 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5957 so that this new function doesn't get optimized away by a
5958 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5959
021f2e1a
AS
59602011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5961
5962 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5963
8b058d44
EZ
59642011-10-29 Eli Zaretskii <eliz@gnu.org>
5965
5966 Fix the `xbytecode' command.
5967 * .gdbinit (xprintbytestr): New command.
b50a28de 5968 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5969 (xbytecode): Print the byte-code string as well.
5970
4452fb80
EZ
59712011-10-29 Kim Storm <storm@cua.dk>
5972
8b058d44
EZ
5973 * alloc.c (which_symbols): New function.
5974
21b72067
AS
59752011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5976
5977 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5978 line. (Bug#9903)
5979
83ed7b5c
GM
59802011-10-29 Glenn Morris <rgm@gnu.org>
5981
5982 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5983 Not clear what it was for, and it causes various bugs. (Bug#9839)
5984
5a7a728b
EZ
59852011-10-28 Eli Zaretskii <eliz@gnu.org>
5986
5987 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5988 possible random value that matches one of those tested as
5989 condition to clear the mouse face.
5990
d3d0842f
CY
59912011-10-28 Chong Yidong <cyd@gnu.org>
5992
5993 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5994
31b39d13
DN
59952011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5996
5997 * window.c (make_window): Initialize phys_cursor_on_p.
5998
9aba6043
SM
59992011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6000
6001 * lisp.h (struct Lisp_Symbol): Update comments.
6002
c20992f4
JB
60032011-10-28 Juanma Barranquero <lekktu@gmail.com>
6004
6005 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6006
db4f02f2
EZ
60072011-10-28 Eli Zaretskii <eliz@gnu.org>
6008
6009 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6010 <oslsachem@gmail.com> for helping to debug this.
6011
6012 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6013 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6014 (g_b_init_get_glyph_outline_w): New static variables.
6015 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6016 (GetGlyphOutlineW_Proc): New typedefs.
6017 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6018 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6019 New functions.
6020 (w32font_open_internal, compute_metrics):
6021 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6022 instead of calling the "wide" APIs directly.
6023
6024 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6025
6026 * w32.h (syms_of_w32font): Add prototype.
6027
87e68db4
JB
60282011-10-27 Juanma Barranquero <lekktu@gmail.com>
6029
6030 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6031 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6032 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6033 (Fmove_to_window_line): Doc fix.
6034
435c1d67
CY
60352011-10-27 Chong Yidong <cyd@gnu.org>
6036
6037 * process.c (make_process): Set gnutls_state to NULL.
6038
6039 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6040 non-NULL, regardless of GNUTLS_INITSTAGE.
6041 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6042 an error. Set process slots as soon as we allocate them.
6043
6044 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6045
9c6c6f49
CY
60462011-10-27 Chong Yidong <cyd@gnu.org>
6047
9aba6043
SM
6048 * gnutls.c (emacs_gnutls_deinit): New function.
6049 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6050 (Fgnutls_deinit, Fgnutls_boot): Use it.
6051
6052 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6053 (deactivate_process): Call emacs_gnutls_deinit.
6054
657d08d3
JB
60552011-10-27 Juanma Barranquero <lekktu@gmail.com>
6056
6057 * image.c (x_create_x_image_and_pixmap):
6058 * w32.c (sys_rename, w32_delayed_load):
6059 * w32font.c (fill_in_logfont):
6060 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6061
5430d399
JB
60622011-10-26 Juanma Barranquero <lekktu@gmail.com>
6063
6064 * w32fns.c (w32_default_color_map): New function,
6065 extracted from Fw32_default_color_map.
a7ef684b 6066 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6067
fe0055fa
PE
60682011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6069
6070 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6071
e6346438
SM
60722011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6073
6074 * keyboard.c (test_undefined): New function (bug#9751).
6075 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6076
e112cc37
ET
60772011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6078
6079 * sysdep.c (init_sys_modes): Fix the check for the controlling
6080 terminal (Bug#6649).
6081
7b5d6677
EZ
60822011-10-20 Eli Zaretskii <eliz@gnu.org>
6083
6084 * dispextern.h (struct bidi_it): New member next_en_type.
6085
6086 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6087 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6088 current character, check also for next_en_type being WEAK_EN.
6089 (bidi_resolve_weak): Don't enter the expensive loop if the current
6090 position is before next_en_pos. Record the bidi type of the first
6091 non-ET, non-BN character we find, in addition to its position.
6092 (bidi_level_of_next_char): Invalidate next_en_type when
6093 next_en_pos is over-stepped.
6094
7da0b018
PE
60952011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6096
6097 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6098 * editfns.c: Rewrite current-time-zone so that it invokes
6099 the equivalent of (format-time-string "%Z") to get the time zone name.
6100 This fixes a bug when the time zone name contains characters that
6101 need converting from the system time locale to Emacs internal format.
6102 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6103 that patch fixed format-time-string to do the conversion, but
6104 I forgot to fix current-time-zone.
6105 (format_time_string): New function, containing most of
6106 what Fformat_time_string used to contain.
6107 (Fformat_time_string): Rewrite in terms of format_time_string.
6108 This doesn't change this function's behavior.
6109 (current-time-zone): Rewrite to use format_time_string.
6110 This fixes the bug reported by Michael Schierl in
6111 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6112 Jason Rumney's 2007-06-07 change worked around this bug, but
6113 didn't fix it.
6114 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6115
8547b010
EZ
61162011-10-19 Eli Zaretskii <eliz@gnu.org>
6117
6118 * xdisp.c (start_display): If the character at POS is displayed
6119 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6120 (try_window_reusing_current_matrix): If a line ends in a display
6121 vector or the next line starts in a display vector, continue
6122 redrawing the window even though the character position of
6123 start_row was reached.
8547b010
EZ
6124 (Bug#9771, part 2)
6125
4e948d15
CY
61262011-10-18 Chong Yidong <cyd@gnu.org>
6127
6128 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6129 with nobreak-char-display too.
6130
4787455f
EZ
61312011-10-18 Eli Zaretskii <eliz@gnu.org>
6132
6133 Fix part 3 of bug#9771.
6134 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6135 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6136 non-neutral characters if the current character is a paragraph
6137 separator (a.k.a. Newline). This avoids running the same
6138 expensive loop twice, once when we consume the preceding newline
6139 and the other time when the line actually needs to be displayed.
6140 Avoid the loop when we see neutrals on the base embedding level
6141 following a character whose directionality is the same as the
6142 paragraph's. This avoids running the expensive loop when a line
6143 ends in a long sequence of neutrals, like control characters.
6144 Add assertion against STRONG_AL type. Slightly rearrange code
6145 that determines the type of a neutral given the first non-neutral
6146 that follows it.
6147 (bidi_level_of_next_char): Set next_en_pos to zero when
6148 invalidating its info.
6149
2c91f553
EZ
61502011-10-17 Eli Zaretskii <eliz@gnu.org>
6151
6152 * xdisp.c (push_display_prop): Determine whether to record string
6153 or buffer position by IT->string, not by IT->method. Allow
6154 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6155 (move_it_vertically_backward): Don't look for character position
6156 immediately after the newline when in a continuation line.
6157 (Bug#9771, part 1)
2c91f553 6158
c7b08b0d
MR
61592011-10-15 Martin Rudalics <rudalics@gmx.at>
6160
6161 * window.c (coordinates_in_window): Rewrite and delabelize
6162 vertical border check. (Bug#5357) (Bug#9618)
6163
6b02f655
SM
61642011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6165
6166 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6167 errors in XSetWindowBorder (bug#9310).
6168
81d40c92
DA
61692011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6170
6171 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6172 avoid crash when xmalloc overrun checking is enabled.
6173
d4172c3b
EZ
61742011-10-13 Eli Zaretskii <eliz@gnu.org>
6175
6176 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6177 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6178 cursor motion with <left> and <right> arrow keys.
6179
6180 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6181 some callers set that themselves.
6182
b00eea75
EZ
61832011-10-12 Eli Zaretskii <eliz@gnu.org>
6184
6185 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6186 display string and the previous row comes from the same string and
6187 is empty. (Bug#9739) (Bug#9738)
6188
8fe012c4
SM
61892011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6190
6191 * doc.c (get_doc_string): Encode file name (bug#9735).
6192
0074aef2
EZ
61932011-10-12 Eli Zaretskii <eliz@gnu.org>
6194
79beb178
EZ
6195 * bidi.c (bidi_level_of_next_char):
6196 * xdisp.c (get_visually_first_element): Remove old incorrect
6197 comments regarding the Unicode Line Separator character.
6198
0074aef2
EZ
6199 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6200
6e4b3fbe
DA
62012011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6202
6203 * alloc.c (Fgc_status): Do not access beyond zombies array
6204 boundary if nzombies > MAX_ZOMBIES.
6205 * alloc.c (dump_zombies): Add missing format specifier.
6206
0324f3af
PE
62072011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6208
b5525cac
PE
6209 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6210 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6211
0324f3af
PE
6212 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6213 Some packages use them to denote characters with modifiers.
6214
e9b5f888
AS
62152011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6216
6217 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6218 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6219 matching a pp-number. Rename parameter var to var1.
6220
127827c0
SM
62212011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6222
6223 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6224
c8fd3bd0
GM
62252011-10-08 Glenn Morris <rgm@gnu.org>
6226
6227 * callint.c (Fcall_interactively): Give a more explicit error for the
6228 'c' case with a non-character input. (Bug#8479)
6229
352ec8ff
EZ
62302011-10-08 Eli Zaretskii <eliz@gnu.org>
6231
03669ccb
EZ
6232 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6233 lines.
7061c986
EZ
6234 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6235 lines that are hscrolled on the left.
03669ccb 6236
352ec8ff
EZ
6237 * dispnew.c (buffer_posn_from_coords): Account for a possible
6238 presence of header-line. (Bug#4426)
6239
a66cfb1c
SM
62402011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6241
6b02f655
SM
6242 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6243 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6244
7c5ee88e
PE
62452011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6246
6247 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6248 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6249 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6250 this makes Emacs dump core during garbage collection on rare
6251 occasions. sizeof is obviously inferior to offsetof here, so
6252 stick with offsetof.
6253 (GC_POINTER_ALIGNMENT): New macro.
6254 (mark_memory): Omit 3rd (offset) arg; caller changed.
6255 Don't assume EMACS_INT alignment is the same as pointer alignment.
6256
df1bbe5b
SM
62572011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6258
6259 * keyboard.c (read_key_sequence_remapped): New var.
6260 (read_key_sequence): Compute remapping in the right buffer.
6261 (command_loop_1): Use read_key_sequence's remapping directly.
6262
51553db6
SM
62632011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6264
32c1fffd
SM
6265 * dired.c (file_name_completion): Don't expand file name.
6266 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6267 before checking file name handler.
6268
51553db6
SM
6269 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6270 they've been requested explicitly (bug#9591).
6271
b6bd1599 62722011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6273
6274 * keymap.c (Fsingle_key_description): Use make_specified_string
6275 instead of build_string to build string from push_key_description.
6276 (Bug#5193)
6277
f701dc2a
PE
62782011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6279
4222c55d
PE
6280 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6281 This fixes a Y2038 bug on 64-bit hosts.
6282 * buffer.c (reset_buffer):
6283 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6284 (Fclear_buffer_auto_save_failure):
6285 Use 0, not -1, to represent an unset failure time, since time_t
6286 might not be signed.
6287
f701dc2a
PE
6288 Remove dependency on glibc malloc internals.
6289 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6290 Move back here from lisp.h, but with their new implementations.
6291 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6292 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6293 * charset.c (charset_table_init): New static var.
6294 (syms_of_charset): Use it instead of xmalloc. This removes a
6295 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6296 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6297 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6298 Move back to alloc.c.
6299 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6300 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6301
9ceebf39
JD
63022011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6303
6304 * nsterm.m (windowDidResize): Call x_set_window_size only when
6305 ns_in_resize is true. Otherwise set pixelwidth/height and
6306 call change_frame_size (Bug#9628).
6307
cb993c58
PE
63082011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6309
3930c88b
PE
6310 Port --enable-checking=all to Fedora 14 x86-64.
6311 * charset.c (syms_of_charset): Also account for glibc malloc's
6312 internal overhead when calculating the initial malloc maximum.
6313
cb993c58
PE
6314 Port --enable-checking=all to Fedora 14 x86.
6315 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6316 Move to lisp.h.
6317 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6318 (overrun_check_realloc, overrun_check_free):
6319 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6320 That way, xmalloc returns a properly-aligned pointer even if
6321 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6322 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6323 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6324 into account when calculating the initial malloc maximum.
6325 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6326 Move here from alloc.c, so that charset.c can use it too.
6327 Properly align; the old code wasn't right for common 32-bit hosts
6328 when configured with --enable-checking=all.
6329 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6330 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6331
31bed486
EZ
63322011-09-29 Eli Zaretskii <eliz@gnu.org>
6333
04c70788 6334 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6335 use EDOM.
6336
fbcaa2f3
EZ
63372011-09-28 Eli Zaretskii <eliz@gnu.org>
6338
6339 * xdisp.c (compute_display_string_end): If there's no display
6340 string at CHARPOS, return -1.
6341
6342 * bidi.c (bidi_fetch_char): When compute_display_string_end
6343 returns a negative value, treat the character as a normal
6344 character not covered by a display string. (Bug#9624)
6345
a239d4e9
JB
63462011-09-28 Juanma Barranquero <lekktu@gmail.com>
6347
6348 * lread.c (Fread_from_string): Fix typo in docstring.
6349
88652fd5
EZ
63502011-09-27 Eli Zaretskii <eliz@gnu.org>
6351
6352 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6353 newline, reseat the iterator instead of bidi-iterating there one
6354 character at a time. (Bug#9610)
32c1fffd
SM
6355 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6356 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6357
ed497dd4
AS
63582011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6359
6360 * lread.c (readevalloop): Use correct code for NBSP.
6361 (read1): Likewise. (Bug#9608)
6362
b2bf61aa
MA
63632011-09-25 Michael Albinus <michael.albinus@gmx.de>
6364
6365 * dbusbind.c (Fdbus_register_signal): When service is not
6366 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6367
32bbb17c
GM
63682011-09-25 Glenn Morris <rgm@gnu.org>
6369
6370 * buffer.c (truncate-lines): Doc fix.
6371
94e0933e
CY
63722011-09-24 Chong Yidong <cyd@stupidchicken.com>
6373
6374 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6375 (Fset_window_next_buffers): Doc fix.
6376
cddde921
GM
63772011-09-24 Glenn Morris <rgm@gnu.org>
6378
6379 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6380
1260aef1
PE
63812011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6382
25b4bfa0
PE
6383 Fix minor problems found by static checking.
6384 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6385 * indent.c (Fvertical_motion): Fix == vs = typo.
6386
e3cbd34b
EZ
63872011-09-24 Eli Zaretskii <eliz@gnu.org>
6388
a66cfb1c
SM
6389 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6390 Default value is now t. Doc fix.
6bf7006f 6391
e3cbd34b 6392 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6393 logic when moving up, not only when moving down. Fix the
e3cbd34b 6394 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6395 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6396
6397 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6398 CHARPOS is covered by a display string which includes newlines.
6399 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6400 is covered by a display string with embedded newlines.
6401
a3de0cbd
MA
64022011-09-24 Michael Albinus <michael.albinus@gmx.de>
6403
6404 * dbusbind.c (Fdbus_register_signal): Add match rule to
6405 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6406 (Fdbus_register_method, Vdbus_registered_objects_table):
6407 Fix docstring.
a3de0cbd 6408
b260039d
JM
64092011-09-24 Jim Meyering <meyering@redhat.com>
6410
32c1fffd 6411 do not ignore write error for any output size
b260039d
JM
6412 The previous change was incomplete.
6413 While it makes emacs --batch detect the vast majority of stdout
6414 write failures, errors were still ignored whenever the output size is
6415 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6416 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6417 && echo FAIL: ignored write error
6418 FAIL: ignored write error
6419 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6420 && echo FAIL: ignored write error
6421 FAIL: ignored write error
6422 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6423
8eca8a7c
AS
64242011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6425
6426 * emacs.c (Fkill_emacs): In noninteractive mode exit
6427 non-successfully if a write error occurred on stdout. (Bug#9574)
6428
3341db62
EZ
64292011-09-21 Eli Zaretskii <eliz@gnu.org>
6430
6431 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6432 the xassert test.
6433
6434 * dispextern.h (struct it): Update the comment documenting what
6435 can it->OBJECT be.
6436
8c203dbf
EZ
64372011-09-20 Eli Zaretskii <eliz@gnu.org>
6438
6439 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6440 a display string, extend search for cursor position to end of row.
6441 (find_row_edges): If the row ends in a newline from a display
6442 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6443 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6444 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6445 non-empty line. Fixes confusing cursor motion with arrow keys at
6446 the beginning of a line that starts with whitespace.
8c203dbf 6447
a4824228
LMI
64482011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6449
6450 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6451 (bug#9493).
6452
33ed493b
CY
64532011-09-18 Chong Yidong <cyd@stupidchicken.com>
6454
6455 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6456 boolean (Bug#9154).
6457
56cd55c8
EZ
64582011-09-18 Eli Zaretskii <eliz@gnu.org>
6459
6460 * xdisp.c (display_line): Record maximum and minimum buffer
6461 positions even if no glyphs were produced (e.g., by a zero-width
6462 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6463 buffer positions that will be removed from the glyph row because
6464 they don't fit.
c02dcedf
EZ
6465 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6466 column is beyond frame width: don't subtract 1 "pixel" when
6467 computing width of the stretch.
3e62b7e0
EZ
6468 (reseat_at_next_visible_line_start): Undo the change made on
6469 2011-09-17 that saved paragraph information and restored it after
6470 the call to `reseat'. (Bug#9545)
56cd55c8 6471
5ed99d36 64722011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6473
6474 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6475 and turn window cursor on if cleared (Bug#9415).
6476
5ed99d36 64772011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6478
6479 * search.c (boyer_moore): Take unibyte characters from pattern
6480 literally. (Bug#9458)
6481
9bade7b2
EZ
64822011-09-18 Eli Zaretskii <eliz@gnu.org>
6483
6484 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6485
e5e9d610
PE
64862011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6487
87e4427a
PE
6488 Fix minor problem found by static checking.
6489 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6490 initialized, to pacify gcc -Wuninitialized.
6491
e5e9d610
PE
6492 * fileio.c: Report proper errno when syscall falls.
6493 (Finsert_file_contents): Save and restore errno,
6494 so that report_file_error outputs the correct diagnostic.
6495 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6496
a1674f0b
EZ
64972011-09-18 Eli Zaretskii <eliz@gnu.org>
6498
6499 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6500
fbfb6dd4
EZ
65012011-09-17 Eli Zaretskii <eliz@gnu.org>
6502
6503 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6504 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6505
bb187662
EZ
65062011-09-17 Eli Zaretskii <eliz@gnu.org>
6507
1137e8b8 6508 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6509 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6510
6511 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6512 (bidi_find_paragraph_start): Search back for paragraph beginning
6513 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6514 (bidi_move_to_visually_next): Only trigger paragraph-related
6515 computations when the last character is a newline or at EOB, not
6516 just any NEUTRAL_B. (Bug#9470)
6517
bb187662
EZ
6518 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6519 truncated lines if point is covered by a display string. (Bug#9524)
6520
2e621251
PE
65212011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6522
6523 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6524 (cons_to_x_long): New function.
6525 (lisp_data_to_selection_data): Use it. Correct the test for
6526 short-versus-long data; it was negated. Break out of vector
6527 loop, for efficiency, when a long datum is discovered.
6528
91a15bc6
SM
65292011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6530
6531 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6532
b41c3a35
EZ
65332011-09-16 Eli Zaretskii <eliz@gnu.org>
6534
6535 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6536 GCC PR/17406) by declaring this function with external scope.
6537
7812ba2d
PE
65382011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6539
6540 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6541 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6542
cf7edc2a
AS
65432011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6544
6545 * editfns.c (Fformat): Correctly handle text properties on "%%".
6546
bd01620e
EZ
65472011-09-15 Eli Zaretskii <eliz@gnu.org>
6548
6549 * xterm.c (x_draw_composite_glyph_string_foreground):
6550 * w32term.c (x_draw_composite_glyph_string_foreground):
6551 * term.c (encode_terminal_code):
6552 * composite.c (composition_update_it, get_composition_id):
6553 * xdisp.c (get_next_display_element)
6554 (fill_composite_glyph_string): Add comments about special meaning
6555 of TAB characters in a composition.
6556
a02719a3
PE
65572011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6558
6559 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6560 This occurs when processing a multibyte format.
6561 Problem reported by Wolfgang Jenker.
a02719a3 6562
72589a3c
JB
65632011-09-15 Johan Bockgård <bojohan@gnu.org>
6564
6565 * xdisp.c (try_cursor_movement): Only check for exact match if
6566 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6567
1c14176c
PE
65682011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6569
6570 Remove unused external symbols.
6571 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6572 * xdisp.c (calc_pixel_width_or_height): Now static.
6573 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6574 * indent.c (check_display_width):
6575 * w32term.c: Fix comment to match code.
6576 * xterm.c, xterm.h (x_catching_errors): Remove.
6577
d2eea5b5
PE
65782011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6579
6580 * xselect.c: Use signed conversions more consistently (Bug#9498).
6581 (selection_data_to_lisp_data): Assume incoming selection data are
6582 signed integers, not unsigned. This is to be consistent with
6583 outgoing selection data, which was modified to use signed integers
6584 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6585 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6586 expects long, not unsigned long.
6587
46888499
EZ
65882011-09-14 Eli Zaretskii <eliz@gnu.org>
6589
6590 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6591 computation of loop end. Reported by Johan Bockgård
6592 <bojohan@gnu.org>.
6593
ef8ef9fb
CY
65942011-09-13 Chong Yidong <cyd@stupidchicken.com>
6595
6596 * frame.c (Fother_visible_frames_p): Function deleted.
6597
fa819fed
EZ
65982011-09-12 Eli Zaretskii <eliz@gnu.org>
6599
6600 * indent.c (compute_motion): Process display vector front to back
6601 rather than the other way around. (Bug#2496)
6602
2ba8e008
SM
66032011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6604
6605 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6606
20f53c69
CY
66072011-09-11 Chong Yidong <cyd@stupidchicken.com>
6608
6609 * minibuf.c (Fread_from_minibuffer): Doc fix.
6610
d562d7a4
EZ
66112011-09-11 Eli Zaretskii <eliz@gnu.org>
6612
6613 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6614 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6615
1c4d7f3d
LMI
66162011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6617
6618 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6619 value for non-existent files.
6620
b885bf36
EZ
66212011-09-11 Eli Zaretskii <eliz@gnu.org>
6622
6623 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6624 set its "size" to -1. This will set the modtime_size field of
6625 the corresponding buffer to -1, which is what
6626 verify-visited-file-modtime expects for files that do not exist.
6627 (Bug#9139)
6628
6612f0bf
PE
66292011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6630
6631 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6632 here ...
6633 * lisp.h: ... from here. push_key_description is no longer
6634 defined in keyboard.c, so its declaration should not be in
6635 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6636 logically belongs with push_key_description.
6637
dfb3f755
PE
66382011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6639
6640 * buffer.h: Include <sys/types.h> instead of <time.h>.
6641 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6642 Problem reported by Herbert J. Skuhra.
6643
3134906c
LMI
66442011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6645
6646 * xml.c (parse_region): Make the parsing work for
6647 non-comment-starting XML files again (bug#9144).
6648
8d903f4e
AS
66492011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6650
6651 * image.c (gif_load): Fix calculation of bottom and right corner.
6652 (Bug#9468)
6653
80ad64f4
EZ
66542011-09-10 Eli Zaretskii <eliz@gnu.org>
6655
6656 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6657 redisplay in small windows.
6658
208a048d
EZ
66592011-09-09 Eli Zaretskii <eliz@gnu.org>
6660
6661 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6662
9b1c252e
MR
66632011-09-08 Martin Rudalics <rudalics@gmx.at>
6664
6665 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6666 Operate on live windows only.
6667
2949f33b
JB
66682011-09-08 Juanma Barranquero <lekktu@gmail.com>
6669
6670 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6671
e08dcafd
EZ
66722011-09-07 Eli Zaretskii <eliz@gnu.org>
6673
6674 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6675 only under bidi iteration.
6676
115b96bd
JD
66772011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6678
6679 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6680
c8199d0f
PE
66812011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6682
6683 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6684 Without this fix, the command to link temacs failed due to an
6685 undefined symbol __builtin_isnan. This is because
6686 /usr/include/iso/math_c99.h #defines isnan(x) to
6687 __builtin_isnan(x), but the bundled gcc, which identifies itself
6688 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6689 a __builtin_isnan.
6690 * floatfns.c (isnan): #undef, and then #define to a clone of
6691 what's in data.c.
6692 (Fisnan): Always define, since it's always available now.
6693 (syms_of_floatfns): Always define isnan at the Lisp level.
6694
e39b275c 66952011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6696
6697 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6698
b2db44d9 66992011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6700
f4af5137 6701 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6702 The previous code assumed that file offsets (off_t values) fit in
6703 EMACS_INT variables, which is not true on typical 32-bit hosts.
6704 The code messed up by falsely reporting buffer overflow in cases
6705 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6706 when "big" contains more than 2**29 bytes, even though this
6707 inserts just one byte and does not overflow the buffer.
6708 (Finsert_file_contents): Store file offsets as off_t
6709 values, not as EMACS_INT values. Check for overflow when
6710 converting between EMACS_INT and off_t. When checking for
6711 buffer overflow or for overlap, take the offsets into account.
6712 Don't use EMACS_INT for small values where int suffices.
6713 When checking for overlap, fix a typo: ZV was used where
6714 ZV_BYTE was intended.
6715 (Fwrite_region): Don't assume off_t fits into 'long'.
6716 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6717
ecfc0a49
MA
67182011-09-05 Michael Albinus <michael.albinus@gmx.de>
6719
6720 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6721
6511acf2 67222011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6723
0999621a 6724 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6725
6726 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6727 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6728 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6729 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6730 (modify_event_symbol): Do not assume that the length of
6731 name_alist_or_stem is safe to alloca and fits in int.
6732 (Fexecute_extended_command): Likewise for function name and binding.
6733 (Frecursion_depth): Wrap around reliably on integer overflow.
6734 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6735 since some callers pass EMACS_INT values.
6736 (Fsingle_key_description): Don't crash if symbol name contains more
6737 than MAX_ALLOCA bytes.
6738 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6739 (get_minibuffer): Arg is now EMACS_INT, not int.
6740 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6741 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6742 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6743
2be7d702
PE
6744 * dbusbind.c (signature_cat): New function.
6745 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6746 Do not overrun buffer; instead, report string overflow.
6747
9d1df220
PE
6748 * dispnew.c (add_window_display_history): Don't overrun buffer.
6749 Truncate instead; this is OK since it's just a log.
6750
33ef5c64
PE
6751 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6752 even if the time zone offset is outlandishly large.
6753 Don't mishandle offset == INT_MIN.
6754
66c6fdd5
PE
6755 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6756 when creating daemon; the previous buffer-overflow check was incorrect.
6757
d749b01b
PE
6758 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6759 which has the guts of the old verror function.
6760
b5cd1905
PE
6761 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6762 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6763
6e1a67fb
PE
6764 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6765 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6766 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6767 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6768 length of string rather than counting it via multiple sprintfs;
6769 that's simpler and more reliable.
c21721cc
PE
6770 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6771 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6772 sprintf, in case result does not fit in int.
6773
c57b67fc
PE
6774 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6775 (fontset_from_font): Print it.
6776
8a401434
PE
6777 * frame.c (tty_frame_count): Now printmax_t, not int.
6778 (make_terminal_frame, set_term_frame_name): Print it.
6779 (x_report_frame_params): In X, window IDs are unsigned long,
6780 not signed long, so print them as unsigned.
6781 (validate_x_resource_name): Check for implausibly long names,
6782 and don't assume name length fits in 'int'.
6783 (x_get_resource_string): Don't blindly alloca invocation name;
6784 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6785 not fit in int.
6786
6e1a67fb
PE
6787 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6788 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6789 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6790
0df02bf3
PE
6791 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6792 Use esprintf, not sprintf, in case result does not fit in int.
6793
48e30793
PE
6794 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6795 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6796 it as a large positive number.
6797 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6798 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6799
a66ff6d8
PE
6800 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6801 in case result does not fit in int.
6802
aca216ff
PE
6803 * print.c (float_to_string): Detect width overflow more reliably.
6804 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6805 buffer overrun. Don't assume list length fits in 'int'. Treat
6806 print length of 0 as 0, not as infinity; to be consistent with other
6807 uses of print length in this function. Don't overflow print length
6808 index. Don't assume hash table size fits in 'long', or that
6809 vectorlike size fits in 'unsigned long'.
6810
31c286f7
PE
6811 * process.c (make_process): Use printmax_t, not int, to format
6812 process-name gensyms.
6813
55e5faa1
PE
6814 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6815
80f2e268
PE
6816 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6817 to avoid potential buffer overrun.
6818
670741ab
PE
6819 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6820 if X resource line is longer than 512 bytes.
6821
b7163a50
PE
6822 * xfns.c (x_window): Make sprintf buffer a bit bigger
6823 to avoid potential buffer overrun.
6824
ae58ff1f
PE
6825 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6826
c43c8a6a
PE
6827 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6828
3f8236f4
PE
68292011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6830
53e9fe90 6831 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6832 Without these, Emacs silently mishandles large integers sometimes.
6833 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6834 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6835
6511acf2
PE
6836 * xdisp.c (try_window_id): Check Emacs fixnum range before
6837 converting to 'int'.
806add1d 6838
6511acf2 6839 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6840 Check that an Emacs fixnum is in range before assigning it to 'int'.
6841 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6842 values converted from Emacs fixnums.
6843 (Frecenter): Don't wrap around a line count if it is out of 'int'
6844 range; instead, treat it as an extreme value.
6845 (Fset_window_configuration, compare_window_configurations):
6846 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6847
6511acf2
PE
6848 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6849 that can exceed INT_MAX. Check that EMACS_INT value is in range
6850 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6851 (match_limit): Don't assume that a fixnum can fit in 'int'.
6852
6511acf2 6853 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6854 exceed INT_MAX.
6855
6511acf2 6856 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6857 (Fvertical_motion): Don't wrap around LINES values that don't fit
6858 in 'int'. Instead, treat them as extreme values. This is good
6859 enough for windows, which can't have more than INT_MAX lines anyway.
6860
fcb901a7
LMI
68612011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6862
0f2f6b6d
LMI
6863 * Require libxml/parser.h to avoid compilation warning.
6864
fcb901a7
LMI
6865 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6866
6867 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6868 since this reportedly can destroy thread storage.
6869
6e20a0d4
CY
68702011-08-30 Chong Yidong <cyd@stupidchicken.com>
6871
6872 * syntax.c (find_defun_start): Update all cache variables if
6873 exiting early (Bug#9401).
6874
148ae00e
EZ
68752011-08-30 Eli Zaretskii <eliz@gnu.org>
6876
f6cfbd8f
EZ
6877 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6878
148ae00e
EZ
6879 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6880 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6881 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6882
6883 * term.c (tty_append_glyph): New function.
6884 (produce_stretch_glyph): Static function and its prototype deleted.
6885
a66cfb1c
SM
6886 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6887 Add prototypes.
148ae00e 6888
c4a07a4c
PE
68892011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6890
6891 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6892 when checking :margin (Bug#9390).
6893 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6894 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6895 so that the name doesn't mislead. All uses changed.
6896
6bc8cd65
JB
68972011-08-28 Johan Bockgård <bojohan@gnu.org>
6898
6899 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6900 set_tty_hooks.
6901
dca4927e
EZ
69022011-08-27 Eli Zaretskii <eliz@gnu.org>
6903
6904 * xdisp.c (move_it_to): Don't bail out early when reaching
6905 position beyond to_charpos, if we are scanning backwards.
6906 (move_it_vertically_backward): When DY == 0, make sure we get to
6907 the first character in the line after the newline.
6908
f2cad773
PE
69092011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6910
6911 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6912 (ccl_driver): Do not generate an out-of-range pointer.
6913 (Fccl_execute_on_string): Remove unnecessary check for
6914 integer overflow, noted by Stefan Monnier in
6915 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6916 Remove a FIXME that didn't need fixing.
6917 Simplify the newly-introduced buffer reallocation code.
6918
0cae2cdb
JB
69192011-08-27 Juanma Barranquero <lekktu@gmail.com>
6920
6921 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6922
5fc295a4 69232011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6924
70c60eb2 6925 Integer and memory overflow issues (Bug#9196).
726e0ab1 6926
d31850da
PE
6927 * doc.c (get_doc_string): Rework so that
6928 get_doc_string_buffer_size is the actual buffer size, rather than
6929 being 1 less than the actual buffer size; this makes xpalloc more
6930 convenient.
6931
a69fbedb
PE
6932 * image.c (x_allocate_bitmap_record, cache_image):
6933 * xselect.c (Fx_register_dnd_atom):
6934 Simplify previous changes by using xpalloc.
6935
fe5c5d37
PE
6936 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6937 since either will do and ptrdiff_t is convenient with xpalloc.
6938
0065d054
PE
6939 * charset.c (charset_table_size)
6940 (struct charset_sort_data.priority): Now ptrdiff_t.
6941 (charset_compare): Don't overflow if priorities differ greatly.
6942 (Fsort_charsets): Don't assume list length fits in int.
6943 Check for size-calculation overflow when allocating sort data.
6944 (syms_of_charset): Allocate an initial charset table that is
6945 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6946
6947 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6948
6949 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6950 The actual value is always <= INT_MAX, and leaving it unsigned made
6951 overflow checking harder.
6952
6953 * dispextern.h (struct glyph_matrix.rows_allocated)
6954 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6955 with xpalloc. The values are still always <= INT_MAX.
6956
6957 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6958
6959 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6960 (SAFE_NALLOCA): New macro.
6961
6962 * region-cache.c (struct boundary.pos, find_cache_boundary)
6963 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6964 (set_cache_region, invalidate_region_cache)
6965 (revalidate_region_cache, know_region_cache, region_cache_forward)
6966 (region_cache_backward, pp_cache):
6967 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6968 so that ptrdiff_t * can be passed to xpalloc.
6969 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6970 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6971 (pp_cache): Don't assume cache_len fits in int.
6972 * region-cache.h: Adjust extern decls to match.
6973
6974 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6975 EMACS_INT, since either will do, for xpalloc.
6976
6977 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6978 (xnmalloc, xnrealloc, xpalloc): New functions.
6979
726e0ab1
PE
6980 * bidi.c (bidi_shelve_header_size): New constant.
6981 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6982 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6983
51f30bc5 6984 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6985 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6986 (overlay_strings):
6987 Don't update size of array until after memory allocation succeeds,
6988 because xmalloc/xrealloc may not return.
0065d054
PE
6989 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6990 now that we have proper integer overflow checking.
6991 (record_overlay_string, overlay_strings): Catch overflows when
6992 calculating size of overlay_str_buf.
726e0ab1 6993
0065d054
PE
6994 * callproc.c (Fcall_process): Check for size overflow when
6995 calculating size of args2.
6996 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6997 Normally we prefer signed values, but sticking with ptrdiff_t would
6998 require adding more-complicated checks.
726e0ab1
PE
6999
7000 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7001 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7002 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7003 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7004
7005 * character.c (Fstring): Check for size-calculation overflow.
7006
7007 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7008 unnecessary integer overflow. Check for size overflow.
7009 (encode_coding_object): Don't update size until xmalloc succeeds.
7010
7011 * composite.c (get_composition_id): Check for overflow in glyph
7012 length calculations.
7013
7014 Integer and memory overflow fixes for display code.
7015 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7016 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7017 (scrolling_window): Check for overflow in size calculations.
7018 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7019 Don't assume glyph table len fits in int.
7020 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7021 (row_table_size): Now ptrdiff_t, not int.
7022 (scrolling_window): Avoid overflow in size calculations.
7023 Don't update size until allocation succeeds.
7024 * fns.c (concat): Check for overflow in size calculations.
7025 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7026 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7027 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7028
7029 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7030 (get_doc_string): Check for size calculation overflow.
7031 Don't update size until allocation succeeds.
7032 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7033 EMACS_INT, where ptrdiff_t will do.
7034 (Fsubstitute_command_keys): Check for string overflow.
7035
7036 * editfns.c (set_time_zone_rule): Don't assume environment length
7037 fits in int.
7038 (message_length): Now ptrdiff_t, not int.
7039 (Fmessage_box): Don't update size until allocation succeeds.
7040 Don't assume message length fits in int.
7041 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7042
0065d054
PE
7043 * emacs.c (main): Do not reallocate argv, since there is a null at
7044 the end that can be overwritten, and this way there's no need to
7045 worry about size-calculation overflow.
7046 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7047
7048 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7049 alloc succeeds.
7050 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7051
7052 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7053 (x_set_scroll_bar_width, x_figure_window_size):
7054 Check for integer overflow.
7055 (x_set_alpha): Do not assume XINT fits in int.
7056
7057 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7058 This is for the members text_lines, text_cols, total_lines, total_cols,
7059 where the system imposes an 'int' limit.
7060
7061 * fringe.c (Fdefine_fringe_bitmap):
7062 Don't update size until alloc works.
7063
7064 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7065 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7066
7067 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7068 Check for size-calculation overflow.
7069 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7070 do, as we prefer signed integers.
7071 (id_to_widget.max_size, id_to_widget.used)
7072 (xg_store_widget_in_map, xg_remove_widget_from_map)
7073 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7074 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7075 Use and return ptrdiff_t, not int.
7076 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7077 * gtkutil.h: Change prototypes to match the above.
7078
7079 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7080 are duplicate now that they've been promoted to lisp.h.
7081 (x_allocate_bitmap_record, x_alloc_image_color)
7082 (make_image_cache, cache_image, xpm_load):
7083 Don't update size until alloc is done.
7084 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7085 (x_detect_edges):
3256efce 7086 Check for size calculation overflow.
726e0ab1
PE
7087 (ct_colors_allocated_max): New constant.
7088 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7089 overflow.
3256efce 7090
726e0ab1
PE
7091 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7092 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7093 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7094 Use ptrdiff_t, not int, to count maps.
7095 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7096 calculations. Don't update size until allocation succeeds.
7097 Redo calculations to avoid overflow.
726e0ab1
PE
7098 * keyboard.h: Change prototypes to match the above.
7099
7100 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7101 to count maps.
7102 (current_minor_maps): Check for size calculation overflow.
7103 * keymap.h: Change prototypes to match the above.
7104
7105 * lread.c (read1, init_obarray): Don't update size until alloc done.
7106
7107 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7108 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7109
726e0ab1
PE
7110 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7111 Now ptrdiff_t, not int.
7112 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7113 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7114
7115 * process.c (Fnetwork_interface_list): Check for overflow
7116 in size calculation.
7117
7118 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7119
7120 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7121 overflow. Don't bother calling xmalloc when xrealloc will do.
7122
7123 * search.c (Freplace_match): Check for size calculation overflow.
7124 (Fset_match_data): Don't assume list lengths fit in 'int'.
7125
7126 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7127 for command line length. Do not attempt to address one before the
7128 beginning of an array, as that's not portable.
7129
7130 * term.c (max_frame_lines): Remove; unused.
7131 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7132 not int.
7133 (encode_terminal_code, calculate_costs): Check for size
7134 calculation overflow.
7135 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7136 table lengths and related sizes. Don't update size until alloc
7137 done. Redo calculations to avoid overflow.
7138 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7139
7140 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7141 subtracting pointers.
7142 (gobble_line): Check for overflow more carefully. Don't update size
7143 until alloc done.
7144
7145 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7146 Don't update size until alloc done.
7147 Redo size calculations to avoid overflow.
7148 Check for size calculation overflow.
0065d054 7149 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7150
7151 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7152 Use ptrdiff_t, not int, for sizes.
7153 (store_mode_line_noprop_char): Don't update size until alloc done.
7154
0065d054
PE
7155 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7156 Use ptrdiff_t, not int, for sizes.
7157 (Finternal_make_lisp_face, cache_face):
7158 Check for size calculation overflow.
7159 (cache_face): Treat size calculation overflows as if they were
7160 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7161
7162 * xfns.c (x_encode_text, x_set_name_internal)
7163 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7164 sizes, since they can exceed INT_MAX in size. Check for size
7165 calculation overflow.
7166
0065d054
PE
7167 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7168 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7169 Don't update size until alloc done.
7170
0065d054 7171 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7172 as sprintf is limited to int lengths.
1d526e2f 7173
252c5ee1
PE
7174 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7175 (X_LONG_MIN): New macros.
864d7ce7
PE
7176 Use them to make the following changes clearer.
7177 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7178 This change doesn't affect the value now, but it may help remind
7179 future maintainers not to raise the value too much later.
7180 (SELECTION_QUANTUM): Remove, replacing with ...
7181 (selection_quantum): ... new function, which avoids overflow.
7182 All uses changed.
7183 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7184 assumption that selection length fits in 'int'.
7185 (x_reply_selection_request, x_handle_selection_request)
7186 (x_get_window_property, receive_incremental_selection)
7187 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7188 (lisp_data_to_selection_data, clean_local_selection_data):
7189 Use ptrdiff_t, not int, to record length of selection.
7190 (x_reply_selection_request, x_get_window_property)
7191 (receive_incremental_selection, x_property_data_to_lisp):
7192 Redo calculations to avoid overflow.
7193 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7194 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7195 something.
7196 (x_get_window_property, receive_incremental_selection)
7197 (lisp_data_to_selection_data, x_property_data_to_lisp):
7198 Check for size-calculation overflow.
7199 (x_get_window_property, receive_incremental_selection)
7200 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7201 Don't store size until memory allocation succeeds.
7202 (x_get_window_property): Plug memory leak on memory exhaustion.
7203 Don't double-block input; malloc is safe here. Don't assume 2**34
7204 - 4 fits in unsigned long. Add an xassert to check
7205 XGetWindowProperty overflow. Be more careful about overflow
7206 calculations, and distinguish size from memory overflow better.
7207 (receive_incremental_selection): When tracing, don't assume
7208 unsigned int is less than INT_MAX.
7209 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7210 harmful) conversions of unsigned short to int.
7211 (lisp_data_to_selection_data): Don't assume that integers
7212 in the range -65535 through -1 fit in an X unsigned short.
7213 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7214 result parameters unless successful. Rely on cons_to_unsigned
7215 to report problems with elements; the old code wasn't right anyway.
7216 (x_check_property_data): Check for int overflow; we cannot use
7217 a wider type due to X limits.
7218 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7219
726e0ab1 7220 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7221
0065d054
PE
7222 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7223 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7224 (x_color_cells): Don't store size until memory allocation succeeds.
7225 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7226 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7227 (x_term_init): Don't assume length fits in int (sprintf is limited
7228 to int size).
bc18e09d 7229
ebfa62c0
PE
7230 Use ptrdiff_t for composition IDs.
7231 * character.c (lisp_string_width):
7232 * composite.c (composition_table_size, n_compositions)
7233 (get_composition_id, composition_gstring_from_id):
7234 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7235 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7236 * window.c (Frecenter):
7237 Use ptrdiff_t, not int, for composition IDs.
7238 * composite.c (get_composition_id): Check for integer overflow.
7239 * composite.h: Adjust prototypes to match the above changes.
7240
d3411f89
PE
7241 Use ptrdiff_t for hash table indexes.
7242 * category.c (hash_get_category_set):
7243 * ccl.c (ccl_driver):
7244 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7245 * coding.c (coding_system_charset_list, detect_coding_system):
7246 * coding.h (struct coding_system.id):
7247 * composite.c (get_composition_id, gstring_lookup_cache):
7248 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7249 * image.c (xpm_get_color_table_h):
7250 * lisp.h (hash_lookup, hash_put):
7251 * minibuf.c (Ftest_completion):
7252 Use ptrdiff_t for hash table indexes, not int (which is too
7253 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7254 32-bit --with-wide-int hosts).
7255
e097a6fa
PE
7256 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7257 Add a FIXME comment about memory leaks.
7258 (syms_of_charset): Don't assume xmalloc returns.
7259
5637687f
PE
7260 Don't assume that stated character widths fit in int.
7261 * character.c (Fchar_width, c_string_width, lisp_string_width):
7262 * character.h (CHAR_WIDTH):
7263 * indent.c (MULTIBYTE_BYTES_WIDTH):
7264 Use sanitize_char_width to avoid undefined and/or bad behavior
7265 with outlandish widths.
a66cfb1c 7266 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7267 now that we have two such functions. All uses changed.
7268 (sanitize_char_width): New inline function.
7269
a2271ba2
PE
7270 Don't assume that tab-width fits in int.
7271 * character.h (sanitize_width): New inline function.
7272 (SANE_TAB_WIDTH): New macro.
7273 (ASCII_CHAR_WIDTH): Use it.
7274 * indent.c (sane_tab_width): Remove. All uses replaced by
7275 SANE_TAB_WIDTH (current_buffer).
7276 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7277
18c52557
PE
7278 * fileio.c: Integer overflow issues with file modes.
7279 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7280
caeeedc1
PE
7281 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7282 Remove unreachable code.
7283 (read_hex, load_charset_map_from_file): Check for integer overflow.
7284
6df6ae42 7285 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7286 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7287 (x_send_scroll_bar_event): Likewise. Check that the size does not
7288 exceed limits imposed by XClientMessageEvent, as well as the usual
7289 ptrdiff_t and size_t limits.
7290
b13995db
PE
7291 * keyboard.c: Overflow, signedness and related fixes.
7292 (make_lispy_movement): Use same integer type in forward decl
7293 that is used in the definition.
7294 (read_key_sequence, keyremap_step):
7295 Change bufsize argument back to int, undoing my 2011-03-30 change.
7296 We prefer signed types, and int is wide enough here.
7297 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7298 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7299 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7300 length, not size_t. Use ptrdiff_t for index, not int.
7301 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7302 possibility of integer overflow.
7303
13464394
PE
7304 Overflow, signedness and related fixes for images.
7305
7306 * dispextern.h (struct it.stack[0].u.image.image_id)
7307 (struct_it.image_id, struct image.id, struct image_cache.size)
7308 (struct image_cache.used, struct image_cache.ref_count):
7309 * gtkutil.c (update_frame_tool_bar):
7310 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7311 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7312 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7313 * nsmenu.m (update_frame_tool_bar):
7314 * xdisp.c (calc_pixel_width_or_height):
7315 * xfns.c (image_cache_refcount):
7316 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7317 on typical 64-bit hosts.
7318
7319 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7320 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7321 Omit unnecessary casts to int.
7322 (parse_image_spec): Check that integers fall into 'int' range
7323 when the callers expect that.
7324 (image_ascent): Redo ascent calculation to avoid int overflow.
7325 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7326 (lookup_image): Remove unnecessary tests.
7327 (xbm_image_p): Locals are now of int, not EMACS_INT,
7328 since parse_image_check makes sure they fit into int.
7329 (png_load, gif_load, svg_load_image):
7330 Prefer int to unsigned where either will do.
7331 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7332 old tiff_error_handler and tiff_warning_handler.
7333 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7334 stack buffer overflows. It uses only the features of vsnprintf
7335 that are common to both POSIX and native Microsoft.
7336 (tiff_error_handler, tiff_warning_handler): Use it.
7337 (tiff_load, gif_load, imagemagick_load_image):
7338 Don't assume :index value fits in 'int'.
7339 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7340 (imagemagick_load_image): Check that crop parameters fit into
7341 the integer types that MagickCropImage accepts. Don't assume
7342 Vimagemagick_render_type has a nonnegative value. Don't assume
7343 size_t fits in 'long'.
7344 (gs_load): Use printmax_t to print the widest integers possible.
7345 Check for integer overflow when computing image height and width.
7346
c11821d4
EZ
73472011-08-26 Eli Zaretskii <eliz@gnu.org>
7348
7349 * xdisp.c (redisplay_window): Don't force window start if point
7350 will be invisible in the resulting window. (Bug#9324)
7351
0c95fcf7
EZ
73522011-08-25 Eli Zaretskii <eliz@gnu.org>
7353
7354 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7355 the display spec is of the form `(space ...)'.
7356 (handle_display_spec): Return the value returned by
7357 handle_single_display_spec, not just 1 or zero.
7358 (handle_single_display_spec): If the display spec is of the form
7359 `(space ...)', and specifies display in the text area, return 2
7360 rather than 1.
fee65a97 7361 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7362 accurately, and prefer exact match for point under bidi.
7363 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7364
7365 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7366 into disp_prop; all users changed.
7367
7368 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7369 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7370 for the text covered by the display property.
7371
e4ed06f1
CY
73722011-08-25 Chong Yidong <cyd@stupidchicken.com>
7373
7374 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7375 Change return value to nil.
7376 (Frecord_buffer): Delete unused function.
7377
f67cdd7f
EZ
73782011-08-24 Eli Zaretskii <eliz@gnu.org>
7379
5980d4c6
EZ
7380 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7381 buffers, return left-to-right.
8610fe8b
EZ
7382 (set_cursor_from_row): Consider candidate row a win if its glyph
7383 represents a newline and point is on that newline. Fixes cursor
7384 positioning on the newline at EOL of R2L text within L2R
7385 paragraph, and vice versa.
7386 (try_cursor_movement): Check continued rows, in addition to
7387 continuation rows. Fixes unwarranted scroll when point enters a
7388 continued line of R2L text within an L2R paragraph, or vice versa.
7389 (cursor_row_p): Consider the case of point being equal to
7390 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7391 from the end of a short line to the beginning of a continued line
7392 of R2L text within L2R paragraph.
7393 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7394 composed characters.
5980d4c6 7395
f67cdd7f
EZ
7396 * bidi.c (bidi_check_type): Use xassert.
7397 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7398 members.
7399
bca633fb
EZ
74002011-08-23 Eli Zaretskii <eliz@gnu.org>
7401
7402 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7403 a character.
7404
4a5885a7
CY
74052011-08-23 Chong Yidong <cyd@stupidchicken.com>
7406
7407 * nsfont.m (ns_otf_to_script): Fix typo.
7408
0902a04e
KH
74092011-08-22 Kenichi Handa <handa@m17n.org>
7410
7411 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7412 extra slot even if the purpose is char-code-property-table.
7413
1a2e6670
EZ
74142011-08-23 Eli Zaretskii <eliz@gnu.org>
7415
8ddde651
EZ
7416 * xdisp.c (redisplay_window): When computing centering_position,
7417 account for the height of the header line. (Bug#8874)
7418
425cc014
EZ
7419 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7420 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7421 candidate is selected by the mouse, and that candidate has a
7422 composed character under the mouse.
7423
1a2e6670
EZ
7424 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7425 coordinates reported by pos-visible-in-window-p for a composed
7426 character in column zero.
7427
8b76d6f8
SM
74282011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7429
7430 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7431
dac347dd
EZ
74322011-08-22 Eli Zaretskii <eliz@gnu.org>
7433
7434 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7435 consider it a hit if to_charpos is anywhere in the range of the
7436 composed buffer positions.
7437
e013fb34
CY
74382011-08-22 Chong Yidong <cyd@stupidchicken.com>
7439
7440 * image.c (gif_load): Don't assume that each subimage has the same
7441 dimensions as the base image. Handle disposal method that is
7442 "undefined" by the gif spec (Bug#9335).
7443
bd1ba3e8
CY
74442011-08-20 Chong Yidong <cyd@stupidchicken.com>
7445
7446 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7447 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7448
54a1215b
EZ
74492011-08-19 Eli Zaretskii <eliz@gnu.org>
7450
823564e5
EZ
7451 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7452 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7453 from an Org mode buffer to a Speedbar frame.
7454
54a1215b
EZ
7455 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7456 a composition, take its buffer position from IT->cmp_it.charpos.
7457 Fixes cursor positioning at the beginning of a line that begins
7458 with a composed character.
7459
9778ebcc
EZ
74602011-08-18 Eli Zaretskii <eliz@gnu.org>
7461
0be6ee06
EZ
7462 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7463 character bidirectional type, use STRONG_L instead. Fixes crashes
7464 in a buffer produced by `describe-categories'.
7465
9778ebcc
EZ
7466 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7467 members before the level stack, so they would be saved and
7468 restored when copying iterator state. Fixes incorrect reordering
7469 around TABs covered by display properties.
7470
156bffbe
AS
74712011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7472
6b02f655 7473 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7474
72ad093b
CY
74752011-08-17 Chong Yidong <cyd@stupidchicken.com>
7476
7477 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7478 (internal_condition_case_2, internal_condition_case_n):
7479 Remove unnecessary aborts (Bug#9081).
72ad093b 7480
35774242
EZ
74812011-08-17 Eli Zaretskii <eliz@gnu.org>
7482
7483 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7484 has no `load' handler, try opening the file locally. (Bug#9311)
7485
db76dd85
KB
74862011-08-16 Ken Brown <kbrown@cornell.edu>
7487
7488 * gmalloc.c: Expand comment.
7489
b215eee5
EZ
74902011-08-16 Eli Zaretskii <eliz@gnu.org>
7491
7492 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7493 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7494
a4579d33
KB
74952011-08-16 Ken Brown <kbrown@cornell.edu>
7496
7497 Fix memory allocation problems in Cygwin build (Bug#9273).
7498
7499 * unexcw.c ( __malloc_initialized): Declare external variable.
7500 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7501
8b76d6f8
SM
7502 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7503 New variables.
a4579d33
KB
7504 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7505 dumped emacs.
7506 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7507 in the static heap.
7508 [CYGWIN] (special_realloc): New function.
7509 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7510 requests to realloc storage in the static heap.
7511
3ebec551
PE
75122011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7513
7514 * bidi.c (bidi_initialize): Remove unused local.
7515
9fd8be00
EZ
75162011-08-15 Eli Zaretskii <eliz@gnu.org>
7517
6b02f655
SM
7518 * bidimirror.h:
7519 * biditype.h: Remove file.
7520 * makefile.w32-in ($(BLD)/bidi.$(O)):
7521 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7522
7523 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7524
7525 * chartab.c: Improve commentary for the uniprop_table API.
7526
32413314
EZ
7527 * bidi.c (bidi_paragraph_init): Support zero value of
7528 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7529 (bidi_initialize): Use uniprop_table instead of including
7530 biditype.h and bidimirror.h.
32413314 7531
9fd8be00
EZ
7532 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7533 coordinates of the iterator when restoring from ppos_it.
7534 (Bug#9296)
7535
5cf2b69b
KH
75362011-08-14 Kenichi Handa <handa@m17n.org>
7537
7538 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7539 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7540
daf17d00
EZ
75412011-08-14 Eli Zaretskii <eliz@gnu.org>
7542
7543 * xdisp.c (move_it_in_display_line_to): Don't invoke
7544 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7545 ppos_it. Fixes vertical cursor motion when line beginning is
7546 covered by an image. (Bug#9296)
7547
08e3161a
JD
75482011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7549
7550 * nsterm.h (ns_run_ascript): Declare.
7551 (NSAPP_DATA2_RUNASSCRIPT): Define.
7552
7553 * nsfns.m (as_script, as_result, as_status): New static variables.
7554 (ns_run_ascript): New function.
5e617bc2 7555 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7556 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7557 the event loop. Get status from as_status (Bug#7276).
7558
7559 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7560 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7561 the event loop (Bug#7276).
7562
a3720aa2
AS
75632011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7564
7565 * gnutls.c (QCgnutls_bootprop_priority)
7566 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7567 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7568 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7569 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7570 (QCgnutls_bootprop_verify_hostname_error)
7571 (QCgnutls_bootprop_callbacks_verify): Rename from
7572 Qgnutls_bootprop_..., all uses changed.
7573
7574 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7575 uses changed.
7576
0a0d27fb
PE
75772011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7578
19d5c50c
PE
7579 * xfaces.c (Qframe_set_background_mode): Now static.
7580 * dispextern.h (Qframe_set_background_mode): Remove decl.
7581
0a0d27fb
PE
7582 * process.c (Fnetwork_interface_info): Declare local only if needed.
7583
377538cb
JD
75842011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7585
7586 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7587 (Fnetwork_interface_list): Allocate in increments of bytes instead
7588 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7589 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7590 sockaddr.
7591 (struct ifflag_def): notrailers is smart on OSX.
7592 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7593 Get hardware address with getifaddrs if available.
7594
08fff70c
EZ
75952011-08-12 Eli Zaretskii <eliz@gnu.org>
7596
7597 * xdisp.c (iterate_out_of_display_property): xassert that
7598 IT->position is set to within IT->object's boundaries. Break from
7599 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7600 when IT->position is set up wrongly due to some bug.
7601 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7602 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7603 entry. Force push_it to save on the stack the current
7604 buffer/string position, to be restored by pop_it. Fix flags in
7605 the iterator structure wrt the object coming from a display
7606 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7607 properties. (Bug#9284)
7608
7be1c708 76092011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7610
7be1c708
CY
7611 * fontset.c (fontset_get_font_group): Add proper type checks.
7612 (Bug#9172)
aac0c6e3 7613
7be1c708 76142011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7615
7be1c708
CY
7616 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7617 and LC_VERSION_MIN_MACOSX.
7618 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7619 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7620
97bb72a6
EZ
76212011-08-08 Eli Zaretskii <eliz@gnu.org>
7622
7623 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7624 no-display-properties-and-no-overlays under bidi display.
7625 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7626 properties and overlays.
97bb72a6 7627
d5617611
CY
76282011-08-08 Chong Yidong <cyd@stupidchicken.com>
7629
37e11a63
CY
7630 * editfns.c (Fset_time_zone_rule): Document relationship with the
7631 setenv function.
7632
d5617611
CY
7633 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7634 the font entity extracted from the cache (Bug#8109).
7635
58872834
CY
76362011-08-07 Chong Yidong <cyd@stupidchicken.com>
7637
7638 * composite.c (autocmp_chars): Don't reset point. That is done by
7639 restore_point_unwind (Bug#5984).
7640
75bfc667
JL
76412011-08-07 Juri Linkov <juri@jurta.org>
7642
7643 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7644 to show the arg `TIME' instead of `TIMEVAL'.
7645
d1410150
EZ
76462011-08-06 Eli Zaretskii <eliz@gnu.org>
7647
7648 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7649 display property strides EOL and includes a newline, as in
7650 longlines-mode. (Bug#9254)
75b771e4
EZ
7651 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7652 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7653
7654 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7655 is non-zero, even if the data buffer is NULL. Fixes a crash in
7656 vertical-motion with longlines-mode. (Bug#9254)
7657
35928349
EZ
76582011-08-05 Eli Zaretskii <eliz@gnu.org>
7659
ec7cc85b
EZ
7660 * bidi.c <bidi_cache_total_alloc>: Now static.
7661 (bidi_initialize): Initialize bidi_cache_total_alloc.
7662
8b76d6f8 7663 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7664 cache. (Bug#9221)
7665
7666 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7667 amount allocated this far in `bidi_cache_total_alloc'.
7668 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7669 non-zero, only free the data buffer without restoring the cache
7670 contents. All callers changed.
7671
7672 * dispextern.h (bidi_unshelve_cache): Update prototype.
7673
7674 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7675 (move_it_in_display_line, move_it_to)
7676 (move_it_vertically_backward, move_it_by_lines): Replace the call
7677 to xfree to an equivalent call to bidi_unshelve_cache.
7678 (move_it_in_display_line_to): Fix logic of returning
412b6358 7679 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7680
e2e2423b
EZ
76812011-08-05 Eli Zaretskii <eliz@gnu.org>
7682
7683 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7684 came from a string character with a `cursor' property. (Bug#9229)
7685
ae9e757a
JD
76862011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7687
7688 * Makefile.in (LIB_PTHREAD): New variable.
7689 (LIBES): Add LIB_PTHREAD (Bug#9216).
7690
7691 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7692 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7693
213bd7f2
AS
76942011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7695
6b02f655 7696 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7697
99aaf75f
JD
76982011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7699
7700 * xterm.c (x_find_topmost_parent): New function.
7701 (x_set_frame_alpha): Find topmost parent window with
7702 x_find_topmost_parent and set the property there also (bug#9181).
7703 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7704
c74e9d86
PE
77052011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7706
7707 * callproc.c (Fcall_process): Avoid vfork clobbering
7708 the local vars buffer, coding_systems, current_dir.
7709
640c8776
SM
77102011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7711
7712 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7713
f26d0e4c
PE
77142011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7715
8a10d76c
PE
7716 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7717 so that it is not optimized away.
7718
f26d0e4c
PE
7719 * xdisp.c (compute_display_string_pos): Remove unused local.
7720
55439c61
EZ
77212011-08-02 Eli Zaretskii <eliz@gnu.org>
7722
7723 Fix slow cursor motion and scrolling in large buffers with
7724 selective display, like Org Mode buffers. (Bug#9218)
7725
7726 * dispextern.h (struct bidi_it): New member disp_prop_p.
7727
7728 * xdisp.c: Remove one-slot cache of display string positions.
7729 (compute_display_string_pos): Accept an additional argument
5e617bc2 7730 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7731 for a display string or property. If found, set DISP_PROP_P
7732 non-zero.
7733
7734 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7735 DISP_PROP_P, and pass it to compute_display_string_pos.
7736 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7737 non-zero. All callers of bidi_fetch_char changed.
7738
fb33fa43
SM
77392011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7740
7741 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7742
b099e063
DM
77432010-12-03 Don March <don@ohspite.net>
7744
7745 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7746 last character M-[char] is translated to ESC [char] (bug#7541).
7747
5cc7f7af
KH
77482011-08-02 Kenichi Handa <handa@m17n.org>
7749
d0fffa3f 7750 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7751
7752 * chartab.c (uniprop_table): Make it non-static.
7753
525d5e6e
EZ
77542011-08-01 Eli Zaretskii <eliz@gnu.org>
7755
7756 * xdisp.c (forward_to_next_line_start): Accept additional argument
7757 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7758 on the newline.
7759 (reseat_at_next_visible_line_start): Use the bidi iterator state
7760 returned by forward_to_next_line_start to restore the state of
7761 it->bidi_it after backing up to previous newline. (Bug#9212)
7762
31011111
AS
77632011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7764
7765 * regex.c (re_comp): Protoize.
7766 (re_exec): Fix return type.
7767 (regexec): Fix type of `ret'. (Bug#9203)
7768
476371c4
PE
77692011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7770
e5d76069
PE
7771 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7772 This is needed if max-image-size is a floating-point number.
7773
9a79b20c
AS
77742011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7775
7776 * print.c (print_object): Print empty symbol as ##.
7777
7778 * lread.c (read1): Read ## as empty symbol.
7779
d8c2fa78
AA
77802011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7781
7782 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7783 setting frame foreground color (Bug#9175).
7784 (x_set_background_color): Likewise.
7785
ffe57a7a
AA
7786 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7787 contents (Bug#9176).
7788 (EmacsTooltip -init): Remove bezels and add shadows to
7789 tooltip windows.
7790
bf3492a5
AA
7791 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7792 or scroll bar (Bug#8470).
7793
d55e9c53
AA
7794 * nsfont.m (nsfont_open): Remove assignment to voffset and
7795 unnecessary vars hshink, expand, hd, full_height, min_height.
7796 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7797
7798 * nsterm.h (nsfont_info): Remove voffset field.
7799
d8c2fa78 78002011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7801
7802 Implement strike-through and overline on NextStep (Bug#8863).
7803
7804 * nsfont.m (nsfont_open): Use underline position provided by font,
7805 instead of hard-coded value of 2.
7806 (nsfont_draw): Call ns_draw_text_decoration instead.
7807
7808 * nsterm.h: Add declaration for ns_draw_text_decoration.
7809
7810 * nsterm.m (ns_draw_text_decoration): New function for drawing
7811 underline, overline, and strike-through.
7812 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7813 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7814 accommodate underlining, etc.
4843aac3 7815
4cc60b9b
EZ
78162011-07-28 Eli Zaretskii <eliz@gnu.org>
7817
bc7ece87
EZ
7818 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7819 default.
4cc60b9b 7820
476371c4
PE
78212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7822
66606eea
PE
7823 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7824 Without this fix, if a signal arrives just after memory fills up,
7825 'malloc' might be invoked reentrantly.
7826
476371c4
PE
7827 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7828 In other words, assume that every image size is allowed, on non-X
7829 hosts. This assumption is probably wrong, but it lets Emacs compile.
7830
f3fcc40d
AS
78312011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7832
7833 * regex.c (re_iswctype): Convert return values to boolean.
7834
350c992f
EZ
78352011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7836
7837 * xdisp.c (compute_display_string_pos): Don't use cached display
7838 string position if the buffer had its restriction changed.
7839 (Bug#9184)
7840
5266b4bb
PE
78412011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7842
7843 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7844
2573a837 78452011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7846
41f55ccd 7847 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7848
39e378da
PE
7849 * bidi.c: Integer size and overflow fixes.
7850 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7851 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7852 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7853 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7854 (bidi_find_other_level_edge):
7855 Use ptrdiff_t instead of EMACS_INT where either will do.
7856 This works better on 32-bit hosts configured --with-wide-int.
7857 (bidi_cache_ensure_space): Check for size-calculation overflow.
7858 Use % rather than repeated addition, for better worst-case speed.
7859 Don't set bidi_cache_size until after xrealloc returns, because it
7860 might not return.
7861 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7862 (bidi_cache_ensure_space): Also check that the bidi cache size
7863 does not exceed that of the largest Lisp string or buffer. See Eli
7864 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7865
5e927815
PE
7866 * alloc.c (__malloc_size_t): Remove.
7867 All uses replaced by size_t. See Andreas Schwab's note
7868 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7869
ca4aa935
PE
7870 * image.c: Improve checking for integer overflow.
7871 (check_image_size): Assume that f is nonnull, since
7872 it is always nonnull in practice. This is one less thing to
7873 worry about when checking for integer overflow later.
7874 (x_check_image_size): New function, which checks for integer
7875 overflow issues inside X.
7876 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7877 This removes the need for a memory_full check.
7878 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7879 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7880 (xbm_read_bitmap_data): Change locals back to 'int', since
7881 their values must fit in 'int'.
7882 (xpm_load_image, png_load, tiff_load):
7883 Invoke x_create_x_image_and_pixmap earlier,
7884 to avoid much needless work if the image is too large.
7885 (tiff_load): Treat overly large images as if
7886 x_create_x_image_and_pixmap failed, not as malloc failures.
7887 (gs_load): Use x_check_image_size.
7888
5f8f9cc2
PE
7889 * gtkutil.c: Omit integer casts.
7890 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7891 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7892
5adf60bc
PE
7893 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7894
c8907a93
PE
7895 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7896 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7897 would wrongly return t on a 64-bit host.
7898
e3c25c68
PE
7899 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7900 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7901 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7902 and therefore cause GCC to emit a bogus diagnostic in some cases.
7903
3f791afe
PE
7904 * image.c: Integer signedness and overflow and related fixes.
7905 This is not an exhaustive set of fixes, but it's time to
7906 record what I've got.
7907 (lookup_pixel_color, check_image_size): Remove redundant decls.
7908 (check_image_size): Don't assume that arbitrary EMACS_INT values
7909 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7910 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7911 (tiff_load, imagemagick_load_image):
7912 Check for overflow in size calculations.
7913 (x_create_x_image_and_pixmap): Remove unnecessary test for
7914 xmalloc returning NULL; that can't happen.
7915 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7916 (xpm_color_bucket): Use better integer hashing function.
7917 (xpm_cache_color): Don't possibly over-allocate memory.
7918 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7919 (gif_memory_source):
7920 Use ptrdiff_t, not int or size_t, to record sizes.
7921 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7922 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7923 either works, as we prefer signed integers.
7924 (tiff_read_from_memory, tiff_write_from_memory):
7925 Return tsize_t, not size_t, since that's what the TIFF API wants.
7926 (tiff_read_from_memory): Don't fail simply because the read would
7927 go past EOF; instead, return a short read.
7928 (tiff_load): Omit no-longer-needed casts.
7929 (Fimagemagick_types): Don't assume size fits into 'int'.
7930
3cc5a532
PE
7931 Improve hashing quality when configured --with-wide-int.
7932 * fns.c (hash_string): New function, taken from sxhash_string.
7933 Do not discard information about ASCII character case; this
7934 discarding is no longer needed.
7935 (sxhash-string): Use it. Change sig to match it. Caller changed.
7936 * lisp.h: Declare it.
7937 * lread.c (hash_string): Remove, since we now use fns.c's version.
7938 The fns.c version returns a wider integer if --with-wide-int is
7939 specified, so this should help the quality of the hashing a bit.
7940
b312a492
PE
7941 * emacs.c: Integer overflow minor fix.
7942 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7943 Define only if GNU_LINUX.
7944 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7945
dfd153ae
PE
7946 * dispnew.c: Integer signedness and overflow fixes.
7947 Remove unnecessary forward decls, that were a maintenance hassle.
7948 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7949 All uses changed.
7950 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7951 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7952 (prepare_desired_row, line_draw_cost):
7953 Use int, not unsigned, where either works.
7954 (save_current_matrix, restore_current_matrix):
7955 Use ptrdiff_t, not size_t, where either works.
7956 (init_display): Check for overflow more accurately, and without
7957 relying on undefined behavior.
7958
a81d11a3
PE
7959 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7960 Remove, replacing with the new symbols in lisp.h. All uses changed.
7961 * fileio.c (make_temp_name):
7962 * filelock.c (lock_file_1, lock_file):
7963 * xdisp.c (message_dolog):
7964 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7965 Use pMd etc. instead.
7966 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7967 replacing the pWIDE etc. symbols removed from editfns.c.
7968
3300e6fd
PE
7969 * keyboard.h (num_input_events): Now uintmax_t.
7970 This is (very slightly) less likely to mess up due to wraparound.
7971 All uses changed.
7972
fd05c7e9
PE
7973 * buffer.c: Integer signedness fixes.
7974 (alloc_buffer_text, enlarge_buffer_text):
7975 Use ptrdiff_t rather than size_t when either will do, as we prefer
7976 signed integers.
7977
903fe15d
PE
7978 * alloc.c: Integer signedness and overflow fixes.
7979 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7980 (__malloc_size_t): Default to size_t, not to int.
7981 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7982 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7983 Prefer ptrdiff_t to size_t when either would do, as we prefer
7984 signed integers.
7985 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7986 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7987 Now const. Initialize with values that are in range even if char
7988 is signed.
7989 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7990 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7991 These functions do the right thing with sizes > 2**32.
7992 (check_depth): Now ptrdiff_t, not int.
7993 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7994 Adjust to new way of storing sizes. Check for size overflow bugs
7995 in rest of code.
7996 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7997 slightly wrong anyway, as it missed one instance of
7998 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7999 (refill_memory_reserve): Omit needless cast to size_t.
8000 (mark_object_loop_halt): Mark as externally visible.
8001
ac82cc6a
PE
8002 * xselect.c: Integer signedness and overflow fixes.
8003 (Fx_register_dnd_atom, x_handle_dnd_message):
8004 Use ptrdiff_t, not size_t, since we prefer signed.
8005 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8006 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8007 x_dnd_atoms_size and x_dnd_atoms_length.
8008
c2d1e36d
PE
8009 * doprnt.c: Prefer signed to unsigned when either works.
8010 * eval.c (verror):
8011 * doprnt.c (doprnt):
8012 * lisp.h (doprnt):
8013 * xdisp.c (vmessage):
8014 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8015 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8016 prefer signed arithmetic to avoid comparison confusion.
8017 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8018 but is a bit tricky.
8019
0e926e56
PE
8020 Assume freestanding C89 headers, string.h, stdlib.h.
8021 * data.c, doprnt.c, floatfns.c, print.c:
8022 Include float.h unconditionally.
8023 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8024 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8025 * regex.c: Likewise for stddef.h, string.h.
8026 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8027 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8028 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8029 (STDC_HEADERS): Remove obsolete defines.
8030 * sysdep.c: Include limits.h unconditionally.
8031
9cfdb3ec
PE
8032 Assume support for memcmp, memcpy, memmove, memset.
8033 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8034 * regex.c (memcmp, memcpy):
8035 Remove; we assume C89 now.
8036
8037 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8038 (__malloc_safe_bcopy): Remove; no longer needed.
8039
cf950e6b 8040 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8041 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8042 well either way, and we prefer signed to unsigned.
8043
dbf38e02
LMI
80442011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8045
8046 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8047 closes the connection while we're reading (bug#9182).
8048
d6f0886c 80492011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8050
d6f0886c
JD
8051 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8052 are specified (Bug#9168).
24e0f6b1 8053
2eb1f9e6
PE
80542011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8055
8056 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8057 Found by GCC static checking and --with-wide-int on a 32-bit host.
8058
22381272 80592011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8060
8061 * xdisp.c (compute_display_string_pos): Fix logic of caching
8062 previous display string position. Initialize cached_prev_pos to
8063 -1. Fixes slow-down at the beginning of a buffer.
8064
f25e39b4
EZ
80652011-07-24 Eli Zaretskii <eliz@gnu.org>
8066
8067 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8068 for attrs[LFACE_FONTSET_INDEX].
8069
04c4b52e
PE
80702011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8071
8072 * xml.c (parse_region): Remove unused local
8073 that was recently introduced.
8074
c1734fbd
EZ
80752011-07-23 Eli Zaretskii <eliz@gnu.org>
8076
be18c5a5
EZ
8077 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8078 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8079
c1734fbd
EZ
8080 * xdisp.c (move_it_in_display_line_to): Record the best matching
8081 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8082 exit if none of the characters scanned was an exact match.
8083 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8084 when exact match is impossible due to invisible text, and the
8085 lines are truncated.
8086
a258d627
JD
80872011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8088
8089 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8090 for OSX >= 10.7.
8091
b6d5a689
EZ
80922011-07-22 Eli Zaretskii <eliz@gnu.org>
8093
0f74f785
EZ
8094 Fix a significant slow-down of cursor motion with C-n, C-p,
8095 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8096 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8097 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8098 (next_element_from_buffer): Call compute_stop_pos_backwards to
8099 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8100 base_level_stop.
8101 (reseat): Don't look for prev_stop, as that could mean a very long
8102 run.
8103 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8104 <cached_disp_overlay_modiff>: Cache for last found display string
8105 position.
551918c1 8106 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8107 about the same buffer in the same area of character positions, and
8108 the buffer wasn't changed since the time the display string
8109 position was cached.
551918c1 8110
b2d0c91a
EZ
81112011-07-22 Eli Zaretskii <eliz@gnu.org>
8112
8113 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8114 is an integer, which is important for empty lines. (Bug#9149)
8115
043604ee
CY
81162011-07-22 Chong Yidong <cyd@stupidchicken.com>
8117
8118 * frame.c (Fmodify_frame_parameters): In tty case, update the
8119 default face if necessary (Bug#4238).
8120
da4adb04
CY
81212011-07-21 Chong Yidong <cyd@stupidchicken.com>
8122
8123 * editfns.c (Fstring_to_char): No need to explain what a character
8124 is in the docstring (Bug#6576).
8125
9abd0532
LMI
81262011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8127
8128 * xml.c (parse_region): Make sure we always return a tree.
8129
36881d16
HK
81302011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8131
8132 * xml.c (parse_region): If a document contains only comments,
8133 return that, too.
8134
1e98674d
LMI
81352011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8136
8137 * xml.c (make_dom): Return comments, too.
8138
590bd467
PE
81392011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8140
8141 Port to OpenBSD.
8142 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8143 and the surrounding thread.
8144 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8145 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8146 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8147 timer goes off.
8148 * s/openbsd.h (BROKEN_SIGIO): Define.
8149 * unexelf.c (unexec) [__OpenBSD__]:
8150 Don't update the .mdebug section of the Alpha COFF symbol table.
8151
f41628b2
LMI
81522011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8153
8154 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8155 (bug#8460).
8156
b59b67c5
PE
81572011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8158
15e3a074
PE
8159 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8160 This fixes some race conditions on the permissions of any newly
8161 created file.
8162
41bed37d
PE
8163 * alloc.c (valid_pointer_p): Use pipe, not open.
8164 This fixes some permissions issues when debugging.
8165
b59b67c5
PE
8166 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8167 If fchown fails to set both uid and gid, try to set just gid,
8168 as that is sometimes allowed. Adjust the file's mode to eliminate
8169 setuid or setgid bits that are inappropriate if fchown fails.
8170
925a6be7
SM
81712011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8172
8173 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8174 to compare Lisp_Objects.
8175 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8176 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8177 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8178
52968808
AS
81792011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8180
0a6a104b
AS
8181 * lread.c (read_integer): Unread even EOF character.
8182 (read1): Likewise. Properly record start position of symbol.
8183
52968808
AS
8184 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8185 symbol character follows.
8186
9e381cdd
PE
81872011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8188
8189 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8190 This works around a problem with the previous change to Fcopy_file.
8191 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8192 and without this change, GCC might complain about discarding
8193 fchown's return value.
8194
b5641435
JB
81952011-07-16 Juanma Barranquero <lekktu@gmail.com>
8196
8197 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8198
a8031457
PE
81992011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8200
8201 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8202
dd889327
LMI
82032011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8204
750c33f7
LMI
8205 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8206 it's used from the C level.
8207
dd889327
LMI
8208 * process.c: Use the same condition for POLL_FOR_INPUT in both
8209 keyboard.c and process.c (bug#1858).
8210
87e86684
LM
82112011-07-09 Lawrence Mitchell <wence@gmx.li>
8212
8213 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8214 (Fgnutls_boot): Use it.
8215
64348f40
AS
82162011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8217
8218 * doc.c (Fsubstitute_command_keys): Revert last change.
8219
1d698799
LMI
82202011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8221
f863868c
LMI
8222 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8223 quotes the next character, and doesn't affect other longer
8224 sequences (bug#8935).
8225
1d698799
LMI
8226 * lread.c (syms_of_lread): Clarify that is isn't only
8227 `eval-buffer' and `eval-defun' that's affected by
8228 `lexical-binding' (bug#8460).
8229
aa4b6df6
EZ
82302011-07-15 Eli Zaretskii <eliz@gnu.org>
8231
8232 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8233 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8234
5d856da6
PE
82352011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8236
ad6042bb
PE
8237 Fix minor problems found by static checking.
8238 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8239 (elsz): Now a signed constant, not a size_t var. We prefer signed
8240 types to unsigned, to avoid integer comparison confusion. Without
8241 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8242 "cannot optimize loop, the loop counter may overflow", a symptom
8243 of the confusion.
f00bbb22 8244 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8245 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8246
6468f31c
LMI
82472011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8248
49080b10
LMI
8249 * search.c (Fre_search_backward): Mention `case-fold-search' in
8250 all the re_search_* functions (bug#8138).
8251
6468f31c
LMI
8252 * keyboard.c (Fopen_dribble_file): Document when the file is
8253 closed (bug#8056).
8254
c965adc5
EZ
82552011-07-14 Eli Zaretskii <eliz@gnu.org>
8256
df9733bf
EZ
8257 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8258 bidi_cache_idx.
8259
0bb23927
EZ
8260 Support bidi reordering of display and overlay strings.
8261 * xdisp.c (compute_display_string_pos)
8262 (compute_display_string_end): Accept additional argument STRING.
8263 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8264 (reseat_to_string): Initialize bidi_it->string.s and
8265 bidi_it->string.schars.
8266 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8267 NULL (avoids a crash in bidi_paragraph_init).
8268 Initialize itb.string.lstring.
0bb23927
EZ
8269 (init_iterator): Call bidi_init_it only of a valid
8270 buffer position was specified. Initialize paragraph_embedding to
8271 L2R.
8272 (reseat_to_string): Initialize the bidi iterator.
8273 (display_string): If we need to ignore text properties of
8274 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8275 original value of -1 will not work with bidi.)
8276 (compute_display_string_pos): First arg is now struct
8277 `text_pos *'; all callers changed. Support display properties on
8278 Lisp strings.
8279 (compute_display_string_end): Support display properties on Lisp
8280 strings.
8281 (init_iterator, reseat_1, reseat_to_string): Initialize the
8282 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8283 when iterating on a string not from display properties).
640c8776
SM
8284 (compute_display_string_pos, compute_display_string_end):
8285 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8286 arrow keys.
8287 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8288 base_level_stop; instead, set base_level_stop to BEGV.
8289 Fixes crashes in vertical-motion.
0bb23927
EZ
8290 (next_element_from_buffer): Improve commentary for when
8291 the iterator is before prev_stop.
8292 (init_iterator): Initialize bidi_p from the default value of
8293 bidi-display-reordering, not from buffer-local value. Use the
8294 buffer-local value only if initializing for buffer iteration.
8295 (handle_invisible_prop): Support invisible properties on strings
8296 that are being bidi-reordered.
8297 (set_iterator_to_next): Support bidi reordering of C strings and
8298 Lisp strings.
8299 (next_element_from_string): Support bidi reordering of Lisp
8300 strings.
8301 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8302 (display_string): Support display of R2L glyph rows.
8303 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8304 (init_iterator): Don't initialize it->bidi_p for strings
8305 here.
8306 (reseat_to_string): Initialize it->bidi_p for strings here.
8307 (next_element_from_string, next_element_from_c_string)
8308 (next_element_from_buffer): Add xassert's for correspondence
8309 between IT's object being iterated and it->bidi_it.string
8310 structure.
8311 (face_before_or_after_it_pos): Support bidi iteration.
8312 (next_element_from_c_string): Handle the case of the first string
8313 character that is not the first one in the visual order.
8314 (get_visually_first_element): New function, refactored from common
8315 parts of next_element_from_buffer, next_element_from_string, and
8316 next_element_from_c_string.
8317 (tool_bar_lines_needed, redisplay_tool_bar)
8318 (display_menu_bar): Force left-to-right direction. Add a FIXME
8319 comment for making that be controlled by a user option.
8320 (push_it, pop_it): Save and restore the state of the
8321 bidi iterator. Save and restore the bidi_p flag.
8322 (pop_it): Iterate out of display property for string iteration as
8323 well.
8324 (iterate_out_of_display_property): Support iteration over strings.
8325 (handle_single_display_spec): Set up it->bidi_it for iteration
8326 over a display string, and call bidi_init_it.
8327 (handle_single_display_spec, next_overlay_string)
8328 (get_overlay_strings_1, push_display_prop): Set up the bidi
8329 iterator for displaying display or overlay strings.
8330 (forward_to_next_line_start): Don't use the shortcut if
8331 bidi-iterating.
8332 (back_to_previous_visible_line_start): If handle_display_prop
8333 pushed the iterator stack, restore the internal state of the bidi
8334 iterator by calling bidi_pop_it same number of times.
8335 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8336 and we are bidi-iterating, don't decrement the iterator position;
8337 instead, set the first_elt flag in the bidi iterator, to produce
8338 the same effect.
8339 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8340 (push_display_prop): xassert that we are iterating a buffer.
8341 (push_it, pop_it): Save and restore paragraph_embedding member.
8342 (handle_single_display_spec, next_overlay_string)
8343 (get_overlay_strings_1, reseat_1, reseat_to_string)
8344 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8345 correctly. Don't assume unibyte strings are not bidi-reordered.
8346 (compute_display_string_pos)
8347 (compute_display_string_end): Fix handling the case of C string.
8348 (push_it, pop_it): Save and restore from_disp_prop_p.
8349 (handle_single_display_spec, push_display_prop): Set the
8350 from_disp_prop_p flag.
8351 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8352 (pop_it): Call iterate_out_of_display_property only if we are
8353 popping after iteration over a string that came from a display
8354 property. Fix a typo in popping stretch info. Add an assertion
8355 for verifying that the iterator position is in sync with the bidi
8356 iterator.
8357 (handle_single_display_spec, get_overlay_strings_1)
8358 (push_display_prop): Fix initialization of paragraph direction for
8359 string when that of the parent object is not yet determined.
8360 (reseat_1): Call bidi_init_it to resync the bidi
8361 iterator with IT's position. (Bug#7616)
8362 (find_row_edges): If ROW->start.pos gives position
8363 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8364 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8365 Reset the from_disp_prop_p flag.
8366 (SAVE_IT, RESTORE_IT): New macros.
8367 (pos_visible_p, face_before_or_after_it_pos)
8368 (back_to_previous_visible_line_start)
8369 (move_it_in_display_line_to, move_it_in_display_line)
8370 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8371 (try_scrolling, redisplay_window, display_line): Use them when
8372 saving a temporary copy of the iterator and restoring it back.
8373 (back_to_previous_visible_line_start, reseat_1)
8374 (init_iterator): Empty the bidi cache "stack".
8375 (move_it_in_display_line_to): If iterator ended up at
8376 EOL, but we never saw any buffer positions smaller than
8377 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8378 motion in bidi-reordered lines.
8379 (move_it_in_display_line_to): Record prev_method and prev_pos
8380 immediately before the call to set_iterator_to_next. Fixes cursor
8381 motion in bidi-reordered lines with stretch glyphs and strings
8382 displayed in margins. (Bug#8133) (Bug#8867)
8383 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8384 TO_CHARPOS.
640c8776
SM
8385 (pos_visible_p): Support positions in bidi-reordered lines.
8386 Save and restore bidi cache.
0bb23927
EZ
8387
8388 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8389 (bidi_paragraph_info): Delete unused struct.
8390 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8391 (bidi_cache_start): New variable.
8392 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8393 to zero.
8394 (bidi_cache_fetch_state, bidi_cache_search)
8395 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8396 (bidi_cache_find, bidi_peek_at_next_level)
8397 (bidi_level_of_next_char, bidi_find_other_level_edge)
8398 (bidi_move_to_visually_next): Compare cache index with
8399 bidi_cache_start rather than with zero.
8400 (bidi_fetch_char): Accept new argument STRING; all callers
8401 changed. Support iteration over a string. Support strings with
8402 display properties. Support unibyte strings. Fix the type of
8403 `len' according to what STRING_CHAR_AND_LENGTH expects.
8404 (bidi_paragraph_init, bidi_resolve_explicit_1)
8405 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8406 (bidi_level_of_next_char, bidi_move_to_visually_next):
8407 Support iteration over a string.
0bb23927
EZ
8408 (bidi_set_sor_type, bidi_resolve_explicit_1)
8409 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8410 can now be zero (for strings); special values 0 and -1 were
8411 changed to -1 and -2, respectively.
8412 (bidi_char_at_pos): New function.
8413 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8414 Call it instead of FETCH_MULTIBYTE_CHAR.
8415 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8416 initialized to valid values.
8417 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8418 values.
8419 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8420 the test for valid cached positions. Fix the logic for looking up
8421 the sentinel state in the cache. GCPRO the Lisp string we are
8422 iterating.
8423 (bidi_push_it, bidi_pop_it): New functions.
8424 (bidi_initialize): Initialize the bidi cache start stack pointer.
8425 (bidi_cache_ensure_space): New function, refactored from part of
8426 bidi_cache_iterator_state. Don't assume the required size is just
8427 one BIDI_CACHE_CHUNK away.
8428 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8429 (bidi_count_bytes, bidi_char_at_pos): New functions.
8430 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8431 always valid if bidi_cache_idx is valid.
8432 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8433 is valid if it's going to be used.
8434 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8435 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8436 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8437 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8438 (bidi_find_other_level_edge, bidi_cache_start_stack):
8439 All variables related to cache indices are now EMACS_INT.
c965adc5 8440
0bb23927
EZ
8441 * dispextern.h (struct bidi_string_data): New structure.
8442 (struct bidi_it): New member `string'. Make flag members be 1-bit
8443 fields, and put them last in the struct.
640c8776
SM
8444 (compute_display_string_pos, compute_display_string_end):
8445 Update prototypes.
0bb23927
EZ
8446 (bidi_push_it, bidi_pop_it): Add prototypes.
8447 (struct iterator_stack_entry): New members bidi_p,
8448 paragraph_embedding, and from_disp_prop_p.
8449 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8450 (bidi_shelve_cache, bidi_unshelve_cache):
8451 Declare prototypes.
0bb23927
EZ
8452
8453 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8454 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8455 and vector-like objects.
8456
8457 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8458 cache around display iteration.
8459
8460 * window.c (Fwindow_end, window_scroll_pixel_based)
8461 (displayed_window_lines, Frecenter): Save and restore the bidi
8462 cache around display iteration.
8463
3bbd2265
LMI
84642011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8465
8466 * editfns.c (Fdelete_region): Clarify the use of the named
8467 parameters (bug#6788).
8468
adc47434
MR
84692011-07-14 Martin Rudalics <rudalics@gmx.at>
8470
8471 * indent.c (Fvertical_motion): Set and restore w->pointm when
8472 saving and restoring the window's buffer (Bug#9006).
8473
837c31f8
LMI
84742011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8475
8476 * editfns.c (Fstring_to_char): Clarify just what is returned
8477 (bug#6576). Text by Eli Zaretskii.
8478
ac389d0c
JB
84792011-07-13 Juanma Barranquero <lekktu@gmail.com>
8480
8481 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8482
0be0ce47
EZ
84832011-07-13 Eli Zaretskii <eliz@gnu.org>
8484
8485 * buffer.c (mmap_find): Fix a typo.
8486
cd18e7e3
JB
84872011-07-13 Johan Bockgård <bojohan@gnu.org>
8488
8489 Fix execution of x selection hooks.
8490 * xselect.c (Qx_lost_selection_functions)
8491 (Qx_sent_selection_functions): New vars.
8492 (syms_of_xselect): DEFSYM them.
8493 (x_handle_selection_request): Pass Qx_sent_selection_functions
8494 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8495 (x_handle_selection_clear,x_clear_frame_selections):
8496 Pass Qx_lost_selection_functions rather than
8497 Vx_lost_selection_functions to Frun_hook_with_args.
8498
47ea7f44
PE
84992011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8500
ac389d0c 8501 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8502 The old code sometimes used this field without initializing it.
8503
47ea7f44
PE
8504 * alloc.c (gc_sweep): Don't read past end of array.
8505 In theory, the old code could also have corrupted Emacs internals,
8506 though it'd be very unlikely.
8507
bc985c87
AS
85082011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8509
8510 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8511 argument. (Bug#4026)
bc985c87 8512
0cf34688
LMI
85132011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8514
b3dadd76
LMI
8515 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8516 key" (bug#4257).
8517
0cf34688
LMI
8518 * window.c (Fset_window_start): Doc fix (bug#4199).
8519 (Fset_window_hscroll): Ditto.
8520
270768cd
PE
85212011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8522
077e3dda 8523 Fix minor new problems caught by GCC 4.6.1.
270768cd 8524 * term.c (init_tty): Remove unused local.
490011a6 8525 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8526 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8527 not used otherwise.
270768cd 8528
b1f58454
CY
85292011-07-12 Chong Yidong <cyd@stupidchicken.com>
8530
8531 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8532
22b9578d
LMI
85332011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8534
6e70ab07
LMI
8535 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8536 are the mini-buffer and the echo area (bug#3320).
8537
22b9578d
LMI
8538 * term.c (init_tty): Remove support for supdup, c10 and perq
8539 terminals, which are no longer supported (bug#1482).
8540
8974cc9f
JB
85412011-07-10 Johan Bockgård <bojohan@gnu.org>
8542
8543 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8544
a560d974
JD
85452011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8546
8547 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8548 for non-popups (Bug#3642).
8549
1dae0f0a
AS
85502011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8551
268c2c36 8552 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8553 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8554 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8555 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8556 * data.c (fmod): Likewise.
8557 * dispnew.c (swap_glyphs_in_rows): Likewise.
8558 * emacs.c (memory_warning_signal): Likewise.
8559 * floatfns.c (float_error): Likewise.
8560 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8561 (otf_open, font_otf_capability, generate_otf_features)
8562 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8563 Likewise.
8564 * image.c (pbm_read_file): Likewise.
8565 * indent.c (string_display_width): Likewise.
8566 * intervals.c (check_for_interval, search_for_interval)
8567 (inc_interval_count, count_intervals, root_interval)
8568 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8569 * lread.c (defalias): Likewise.
268c2c36 8570 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8571 * regex.c (set_image_of_range_1, set_image_of_range)
8572 (regex_grow_registers): Likewise.
8573 * sysdep.c (strerror): Likewise.
8574 * termcap.c (valid_filename_p, tprint, main): Likewise.
8575 * tparam.c (main): Likewise.
8576 * unexhp9k800.c (run_time_remap, save_data_space)
8577 (update_file_ptrs, read_header, write_header, calculate_checksum)
8578 (copy_file, copy_rest, display_header): Likewise.
8579 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8580 Likewise.
8581 * xdisp.c (check_it): Likewise.
8582 * xfaces.c (register_color, unregister_color, unregister_colors):
8583 Likewise.
8584 * xfns.c (print_fontset_result): Likewise.
8585 * xrdb.c (member, fatal, main): Likewise.
8586
99033785
PE
85872011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8588
8589 Fix minor problems found by static checking (Bug#9031).
8590 * chartab.c (char_table_set_range, map_sub_char_table):
8591 Remove unused locals.
8592 (uniprop_table): Now static.
8593 * composite.c (_work_char): Remove unused static var.
8594
9cb2ac56
JB
85952011-07-09 Juanma Barranquero <lekktu@gmail.com>
8596
8597 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8598
f25661f0
JD
85992011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8600
8601 * gtkutil.c (qttip_cb): Remove code without function.
8602
8278c4fe
EZ
86032011-07-09 Eli Zaretskii <eliz@gnu.org>
8604
8605 * w32.c (pthread_sigmask): New stub.
8606
1692ae2d 86072011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8608
8a6ebd58 8609 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8610 sigprocmask is portable only for single-threaded applications, and
8611 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8612 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8613 (LIBES): Use it.
8614 * callproc.c (Fcall_process):
8615 * process.c (create_process):
8616 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8617 Use pthread_sigmask, not sigprocmask.
123403e4 8618
1b854618
JD
86192011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8620
8621 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8622 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8623 wrong (Bug#8591).
8624
3fe4b549
JD
86252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8626
0ce7e563
JD
8627 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8628 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8629 (xg_hide_tooltip): Fix comment.
8630
3fe4b549
JD
8631 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8632 in registerServicesMenuSendTypes.
8633 (validRequestorForSendType): Don't check ns_return_types.
8634
8635 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8636 ns_return_type.
8637
5df75e47
JR
86382011-07-08 Jason Rumney <jasonr@gnu.org>
8639
22610910
JR
8640 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8641 SH_SHOW for hidden windows (Bug#5482).
8642
5df75e47
JR
8643 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8644 frame struct members of non-existent frames (Bug#6284).
8645
699c10bd
JD
86462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8647
4393663b
JD
8648 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8649 variable firstTime not needed on OSX >= 10.6.
8650 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8651 >= 10.5. Use setKnobProportion, setDoubleValue.
8652
8653 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8654 (MAC_OS_X_VERSION_10_5): Define if not defined.
8655 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8656 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8657 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8658
8659 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8660 cString and lossyCString on OSX >= 10.4.
4393663b 8661
58179cce 8662 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8663 sizeToFit on OSX >= 10.2.
8664
8665 * nsimage.m (allocInitFromFile): Don't use deprecated method
8666 bestRepresentationForDevice on OSX >= 10.6.
8667
8668 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8669 to avoid warning.
8670
8671 * emacs.c: Declare unexec_init_emacs_zone.
8672
a63e0781
JD
8673 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8674
699c10bd
JD
8675 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8676
8677 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8678 on svcsMenu (Bug#8842).
8679
8680 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8681 ns_return_types.
8682 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8683
8684 * nsterm.m (QUTF8_STRING): Declare.
8685 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8686 (validRequestorForSendType): Return type is (id).
8687 Change indexOfObjectIdenticalTo to indexOfObject.
8688 Check if we have local selection before returning self (Bug#8842).
8689 (writeSelectionToPasteboard): Put local selection into paste board
8690 if we have a local selection (Bug#8842).
8691 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8692
8693 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8694 (ns_get_local_selection): Declare.
8695
54e10184
LMI
86962011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8697
9888ff71
LMI
8698 * keymap.c (describe_map_tree): Don't insert a double newline at
8699 the end of the buffer (bug#1169) and return whether we inserted
8700 something.
8701
54e10184
LMI
8702 * callint.c (Fcall_interactively): Change "reading args" to
8703 "providing args" to try to clarify what it does (bug#1010).
8704
15fa4783
KH
87052011-07-07 Kenichi Handa <handa@m17n.org>
8706
8707 * composite.c (composition_compute_stop_pos): Ignore a static
8708 composition starting before CHARPOS (Bug#8915).
8709
8710 * xdisp.c (handle_composition_prop): Likewise.
8711
a8815b00
EZ
87122011-07-07 Eli Zaretskii <eliz@gnu.org>
8713
8714 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8715 (Bug#9015)
8716
ef7b981d 87172011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8718
8719 * character.h (unicode_category_t): New enum type.
8720
8721 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8722 (Qchar_code_property_table): New variable.
8723 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8724 (UNIPROP_COMPRESSED_FORM_P): New macros.
8725 (char_table_ascii): Uncompress the compressed values.
8726 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8727 Uncompress the compressed values.
ac389d0c 8728 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8729 (char_table_ref_and_range): Uncompress the compressed values.
8730 (sub_char_table_set): New arg is_uniprop. Callers changed.
8731 Uncompress the compressed values.
8732 (sub_char_table_set_range): Args changed. Callers changed.
8733 (char_table_set_range): Adjuted for the above change.
8734 (map_sub_char_table): Delete args default_val and parent. Add arg
8735 top. Give decoded values to a Lisp function.
640c8776 8736 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8737 values to a Lisp function. Gcpro more variables.
8738 (uniprop_table_uncompress)
8739 (uniprop_decode_value_run_length): New functions.
8740 (uniprop_decoder, uniprop_decoder_count): New variables.
8741 (uniprop_get_decoder, uniprop_encode_value_character)
8742 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8743 New functions.
8744 (uniprop_encoder, uniprop_encoder_count): New variables.
8745 (uniprop_get_encoder, uniprop_table)
8746 (Funicode_property_table_internal, Fget_unicode_property_internal)
8747 (Fput_unicode_property_internal): New functions.
8748 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8749 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8750 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8751 char-code-property-alist.
8752
640c8776 8753 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8754 Vunicode_category_table.
8755
640c8776 8756 * font.c (font_range): Adjust for the change of
c805dec0
KH
8757 Vunicode_category_table.
8758
76b397fb
DN
87592011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8760
8761 * m/iris4d.h: Remove file, move contents ...
8762 * s/irix6-5.h: ... here.
8763
22b4128e
PE
87642011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8765
8766 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8767 * alloc.c (mark_buffer):
8768 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8769 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8770 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8771 This isn't true in general, and it's particularly not true
8772 if Emacs is configured with --with-wide-int.
8773 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8774 New macros, used in the buffer.c change.
8775
869795d6
JD
87762011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8777
8778 * xsettings.c: Use both GConf and GSettings if both are available.
8779 (store_config_changed_event): Add comment.
8780 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8781 (store_tool_bar_style_changed): New functions.
5e617bc2 8782 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8783 (struct xsettings): Move font inside HAVE_XFT.
8784 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8785 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8786 Move inside HAVE_XFT.
640c8776 8787 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8788 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8789 also.
8790 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8791 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8792 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8793 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8794 (parse_settings): Move check for font inside HAVE_XFT.
8795 (read_settings, apply_xft_settings): Add comment.
8796 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8797 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8798 call store_font_name_changed.
8799 (xft_settings_event): Add comment.
8800 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8801 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8802 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8803 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8804 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8805 (xsettings_get_system_font, xsettings_get_system_normal_font):
8806 Add comment.
869795d6 8807
d8ed26bd
PE
88082011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8809
8810 Random fixes. E.g., (random) never returned negative values.
8811 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8812 subseconds part to the entropy, as that's a bit more random.
8813 Prefer signed to unsigned, since the signedness doesn't matter and
8814 in general we prefer signed. When given a limit, use a
8815 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8816 latter isn't right if USE_2_TAGS_FOR_INTS.
8817 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8818 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8819
cabf1cac
SM
88202011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8821
8822 * textprop.c (text_property_stickiness):
8823 Obey Vtext_property_default_nonsticky.
8824 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8825 * w32fns.c (syms_of_w32fns):
8826 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8827
6e9b2be9
PE
88282011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8829
8830 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8831 This is more efficient than Ffile_directory_p and avoids a minor race.
8832
90186c68
LMI
88332011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8834
7c301272
LMI
8835 * buffer.c (Foverlay_put): Say what the return value is
8836 (bug#7835).
8837
c4f2d8d4
LMI
8838 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8839 is a directory before asking whether to use the file name
8840 (bug#7564).
ad637907
LMI
8841 (barf_or_query_if_file_exists): Make the "File is a directory"
8842 error be more correct.
c4f2d8d4 8843
90186c68
LMI
8844 * fns.c (Frequire): Remove the mention of the .gz files, since
8845 that's installation-specific, but keep the mention of
8846 `get-load-suffixes'.
8847
da64016e
PE
88482011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8849
8850 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8851 Report string overflow if the output is too long.
8852
7d47b580
JB
88532011-07-04 Juanma Barranquero <lekktu@gmail.com>
8854
a555cb87
JB
8855 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8856 (syms_of_gnutls): Remove duplicate DEFSYM for
8857 Qgnutls_bootprop_verify_hostname_error, an error for
8858 Qgnutls_bootprop_verify_error (which is no longer used).
8859
7d47b580
JB
8860 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8861 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8862 Also (re)move comments that are misplaced or no longer relevant.
8863
1e49bfab
LMI
88642011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8865
8866 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8867
1485f4c0
CY
88682011-07-03 Chong Yidong <cyd@stupidchicken.com>
8869
8870 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8871 and background color parameters if they have been changed.
8872
a9ab721e
LMI
88732011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8874
8875 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8876
cf7cff57
PE
88772011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8878
2e13213d
PE
8879 * xsettings.c (SYSTEM_FONT): Define only when used.
8880 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8881
cf7cff57
PE
8882 * keymap.c (access_keymap_1): Now static.
8883
7a8e04f7
CY
88842011-07-02 Chong Yidong <cyd@stupidchicken.com>
8885
8886 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8887 leave any prefix arg for the up event (Bug#1586).
8888
61352f62
LMI
88892011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8890
69bb1ef7
LMI
8891 * lread.c (syms_of_lread): Mention single symbols defined by
8892 `defvar' or `defconst' (bug#7154).
8893
61352f62 8894 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8895 (Frequire): Mention get-load-suffixes.
61352f62 8896
28545e04
MR
88972011-07-02 Martin Rudalics <rudalics@gmx.at>
8898
8899 * window.h (window): Remove clone_number slot.
8900 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8901 Remove.
8902 (make_parent_window, make_window, saved_window)
8903 (Fset_window_configuration, save_window_save): Don't deal with
8904 clone numbers.
8905 * buffer.c (Qclone_number): Remove declaration.
8906 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8907
3349e122
SM
89082011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8909
8910 Add multiple inheritance to keymaps.
8911 * keymap.c (Fmake_composed_keymap): New function.
8912 (Fset_keymap_parent): Simplify.
8913 (fix_submap_inheritance): Remove.
8914 (access_keymap_1): New function extracted from access_keymap to handle
8915 embedded parents and handle lists of maps.
8916 (access_keymap): Use it.
8917 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8918 (Fcopy_keymap): Handle embedded parents.
8919 (Fcommand_remapping, define_as_prefix): Simplify.
8920 (Fkey_binding): Simplify.
8921 (syms_of_keymap): Move minibuffer-local-completion-map,
8922 minibuffer-local-filename-completion-map,
8923 minibuffer-local-must-match-map, and
8924 minibuffer-local-filename-must-match-map to Elisp.
8925 (syms_of_keymap): Defsubr make-composed-keymap.
8926 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8927 (parse_menu_item): Trivial simplification.
8928
3279eb87
GM
89292011-07-01 Glenn Morris <rgm@gnu.org>
8930
8931 * Makefile.in (SETTINGS_LIBS): Fix typo.
8932
4550efdf
KI
89332011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8934
8935 * coding.c (Fencode_coding_string): Record the last coding system
8936 used, as the function doc string says (bug#8738).
8937
0949d2b6
JD
89382011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8939
8940 * xsettings.c (store_monospaced_changed): Take new font as arg and
8941 check for change against current_mono_font.
8942 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8943 (emacs_settings_constructor, emacs_settings_get_property)
8944 (emacs_settings_set_property, emacs_settings_class_init)
8945 (emacs_settings_init, gsettings_obj): Remove.
8946 (something_changedCB): New function for HAVE_GSETTINGS.
8947 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8948 with value as argument.
8949 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8950 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8951 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8952 "changed".
8953
8954 * xgselect.c: Add defined (HAVE_GSETTINGS).
8955 (xgselect_initialize): Ditto.
8956
8957 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8958 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8959 xg_select.
8960
bbc6b304
PE
89612011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8962
8963 * eval.c (struct backtrace): Simplify and port the data structure.
8964 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8965 signed bit field, as this assumption is not portable and it makes
8966 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8967 "char debug_on_exit : 1" as this is not portable either; instead,
8968 use the portable "unsigned int debug_on_exit : 1". Remove unused
8969 member evalargs. Remove obsolete comments about cc bombing out.
8970
9851bfc5
JD
89712011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8972
51bb811f 8973 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8974 Let HAVE_GSETTINGS override HAVE_GCONF.
8975 (store_monospaced_changed): New function.
8976 (EMACS_SETTINGS): A new type derived from GObject to handle
8977 GSettings notifications.
8978 (emacs_settings_constructor, emacs_settings_get_property)
8979 (emacs_settings_set_property, emacs_settings_class_init):
8980 New functions.
8981 (gsettings_client, gsettings_obj): New variables.
8982 (GSETTINGS_SCHEMA): New define.
8983 (something_changedCB): Call store_monospaced_changed.
8984 (init_gsettings): New function.
8985 (xsettings_initialize): Call init_gsettings.
8986 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8987 to NULL.
8988
640c8776 8989 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8990 GCONF_CFLAGS/LIBS.
8991
5386012d
MR
89922011-06-29 Martin Rudalics <rudalics@gmx.at>
8993
8994 * window.c (resize_root_window, grow_mini_window)
8995 (shrink_mini_window): Rename Qresize_root_window to
8996 Qwindow_resize_root_window and Qresize_root_window_vertically to
8997 Qwindow_resize_root_window_vertically.
8998
f13e0b08
PE
89992011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9000
9001 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9002
94515237
JB
90032011-06-27 Juanma Barranquero <lekktu@gmail.com>
9004
9005 * makefile.w32-in: Redesign dependencies so they reflect more
9006 clearly which files are directly included by each source file,
9007 and not through other includes.
9008
e43b6e43
MR
90092011-06-27 Martin Rudalics <rudalics@gmx.at>
9010
9011 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9012 (sort_overlays, overlay_strings): When an overlay's clone number
9013 matches the window's clone number process the overlay even if
9014 the overlay's window property doesn't match the current window.
9015
d68443dc
MR
9016 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9017 (Fwindow_hchild): Rename to Fwindow_left_child.
9018 (Fwindow_next): Rename to Fwindow_next_sibling.
9019 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9020 (resize_window_check): Rename to window_resize_check.
9021 (resize_window_apply): Rename to window_resize_apply.
9022 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9023 (Fdelete_other_windows_internal, resize_frame_windows)
9024 (Fsplit_window_internal, Fdelete_window_internal)
9025 (grow_mini_window, shrink_mini_window)
9026 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9027
c7e73be5
JD
90282011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9029
9030 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9031 (emacs_fixed_set_min_size): Remove.
9032 (emacs_fixed_new): Take frame as argument.
9033
9034 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9035 (_EmacsFixedPrivate): Remove minwidth/height.
9036 Add struct frame *f.
9037 (emacs_fixed_init): Initialize priv->f.
9038 (get_parent_class, emacs_fixed_set_min_size): Remove.
9039 (emacs_fixed_new): Set priv->f to argument.
9040 (emacs_fixed_get_preferred_width)
9041 (emacs_fixed_get_preferred_height): Use min_width/height from
9042 frames size_hint to set minimum and natural (Bug#8919).
9043 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9044 and use min_width/height from frames size_hint to set
9045 min_width/height (Bug#8919).
9046
9047 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9048 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9049 Fix indentation.
c7e73be5 9050
cf99dcf8
EZ
90512011-06-26 Eli Zaretskii <eliz@gnu.org>
9052
9053 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9054 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9055 called at ZV.
9056
029529ac
CY
90572011-06-26 Chong Yidong <cyd@stupidchicken.com>
9058
9059 * process.c (wait_reading_process_output): Bypass select if
9060 waiting for a cell while ignoring keyboard input, and input is
9061 pending. Suggested by Jan Djärv (Bug#8869).
9062
7a7ef429
PE
90632011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9064
9065 Use gnulib's dup2 module instead of rolling our own.
9066 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9067
11fdef7d 90682011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9069
9070 * dispnew.c (scrolling_window): Before scrolling, turn off a
9071 mouse-highlight in the window being scrolled.
9072
cd3520a4
JB
90732011-06-24 Juanma Barranquero <lekktu@gmail.com>
9074
9075 Move DEFSYM to lisp.h and use everywhere.
9076
9077 * character.h (DEFSYM): Move declaration...
9078 * lisp.h (DEFSYM): ...here.
9079
9080 * gnutls.c:
9081 * minibuf.c:
9082 * w32menu.c:
9083 * w32proc.c:
9084 * w32select.c: Don't include character.h.
9085
9086 * alloc.c (syms_of_alloc):
9087 * buffer.c (syms_of_buffer):
9088 * bytecode.c (syms_of_bytecode):
9089 * callint.c (syms_of_callint):
9090 * casefiddle.c (syms_of_casefiddle):
9091 * casetab.c (init_casetab_once):
9092 * category.c (init_category_once, syms_of_category):
9093 * ccl.c (syms_of_ccl):
9094 * cmds.c (syms_of_cmds):
9095 * composite.c (syms_of_composite):
9096 * dbusbind.c (syms_of_dbusbind):
9097 * dired.c (syms_of_dired):
9098 * dispnew.c (syms_of_display):
9099 * doc.c (syms_of_doc):
9100 * editfns.c (syms_of_editfns):
9101 * emacs.c (syms_of_emacs):
9102 * eval.c (syms_of_eval):
9103 * fileio.c (syms_of_fileio):
9104 * fns.c (syms_of_fns):
9105 * frame.c (syms_of_frame):
9106 * fringe.c (syms_of_fringe):
9107 * insdel.c (syms_of_insdel):
9108 * keymap.c (syms_of_keymap):
9109 * lread.c (init_obarray, syms_of_lread):
9110 * macros.c (syms_of_macros):
9111 * msdos.c (syms_of_msdos):
9112 * print.c (syms_of_print):
9113 * process.c (syms_of_process):
9114 * search.c (syms_of_search):
9115 * sound.c (syms_of_sound):
9116 * syntax.c (init_syntax_once, syms_of_syntax):
9117 * terminal.c (syms_of_terminal):
9118 * textprop.c (syms_of_textprop):
9119 * undo.c (syms_of_undo):
9120 * w32.c (globals_of_w32):
9121 * window.c (syms_of_window):
9122 * xdisp.c (syms_of_xdisp):
9123 * xfaces.c (syms_of_xfaces):
9124 * xfns.c (syms_of_xfns):
9125 * xmenu.c (syms_of_xmenu):
9126 * xsettings.c (syms_of_xsettings):
9127 * xterm.c (syms_of_xterm): Use DEFSYM.
9128
4228cf16
TZ
91292011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9130
cd3520a4 9131 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9132
7fcccf1e
PE
91332011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9134
7efb4e0e
PE
9135 Integer and buffer overflow fixes (Bug#8873).
9136
ff5844ad
PE
9137 * print.c (printchar, strout): Check for string overflow.
9138 (PRINTPREPARE, printchar, strout):
9139 Don't set size unless allocation succeeds.
9140
90532f02
PE
9141 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9142 for sizes. Check for string overflow more accurately.
9143 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9144
6d84508d
PE
9145 * macros.c: Integer and buffer overflow fixes.
9146 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9147 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9148 Use ptrdiff_t, not int, for sizes.
9149 Don't increment bufsize until after realloc succeeds.
9150 Check for size-calculation overflow.
9151 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9152
437b2cb4
PE
9153 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9154
8b9ac8b4
PE
9155 * lread.c: Integer overflow fixes.
9156 (read_integer): Radix is now EMACS_INT, not int,
9157 to improve quality of diagnostics for out-of-range radices.
9158 Calculate buffer size correctly for out-of-range radices.
9159 (read1): Check for integer overflow in radices, and in
9160 read-circle numbers.
82cb60d3
PE
9161 (read_escape): Avoid int overflow.
9162 (Fload, openp, read_buffer_size, read1)
9163 (substitute_object_recurse, read_vector, read_list, map_obarray):
9164 Use ptrdiff_t, not int, for sizes.
9165 (read1): Use EMACS_INT, not int, for sizes.
20270765 9166 Check for size overflow.
8b9ac8b4 9167
7fcccf1e
PE
9168 * image.c (cache_image): Check for size arithmetic overflow.
9169
bfbbd7e7
PE
9170 * lread.c: Integer overflow issues.
9171 (saved_doc_string_size, saved_doc_string_length)
9172 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9173 Now ptrdiff_t, not int.
9174 (read1): Don't assume doc string length fits in int. Check for
9175 out-of-range doc string lengths.
9176 (read_list): Don't assume file position fits in int.
39019e54 9177 (read_escape): Check for hex character overflow.
bfbbd7e7 9178
4e323265
LL
91792011-06-22 Leo Liu <sdl.web@gmail.com>
9180
9181 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9182 Move to minibuffer.el.
9183
85fece3e
PE
91842011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9185
20b84ce9 9186 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9187 The following patches are for when GLYPH_DEBUG && !XASSERT.
9188 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9189 * dispnew.c (flush_stdout):
9190 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9191 Mark as externally visible.
9192 * dispnew.c (check_window_matrix_pointers): Now static.
9193 * dispnew.c (window_to_frame_vpos):
9194 * xfns.c (unwind_create_frame):
9195 * xterm.c (x_check_font): Remove unused local.
9196 * scroll.c (CHECK_BOUNDS):
9197 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9198 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9199 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9200 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9201 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9202 Now static.
9203 (debug_method_add): Use va_list and vsprintf rather than relying
9204 on undefined behavior with wrong number of arguments.
9205 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9206 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9207 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9208 since we're not interested in debugging glyphs with old libraries.
9209 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9210 GCC 4.6.0's static checking.
9211
0766b489
PE
92122011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9213
31fd4b32
PE
9214 Integer overflow and signedness fixes (Bug#8873).
9215 A few related buffer overrun fixes, too.
9216
b79e8648
PE
9217 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9218
0766b489
PE
9219 * dispextern.h (struct face.stipple):
9220 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9221 (x_bitmap_mask, x_allocate_bitmap_record)
9222 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9223 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9224 (x_create_bitmap_from_xpm_data):
9225 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9226 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9227 (.bitmaps_last):
9228 * xfaces.c (load_pixmap):
9229 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9230 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9231 (.bitmaps_last, struct x_output.icon_bitmap):
9232 Use ptrdiff_t, not int, for bitmap indexes.
9233 (x_allocate_bitmap_record): Check for size overflow.
9234 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9235
b081724f
PE
9236 Use ptrdiff_t, not int, for overlay counts.
9237 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9238 * editfns.c (overlays_around, get_pos_property):
9239 * textprop.c (get_char_property_and_overlay):
9240 * xdisp.c (next_overlay_change, note_mouse_highlight):
9241 * xfaces.c (face_at_buffer_position):
21514da7
PE
9242 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9243 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9244 (Fnext_overlay_change, Fprevious_overlay_change)
9245 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9246 Use ptrdiff_t, not int, for sizes.
21514da7 9247 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9248
3de73e5e
PE
9249 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9250
2606c57b
PE
9251 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9252 (x_session_initialize): Do not assume string length fits in int.
9253
aaafe47a
PE
9254 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9255 This is unlikely, but can occur if DPI is outlandish.
9256
2674ddc8 9257 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9258 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9259
28154962
PE
9260 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9261 * xrdb.c (magic_file_p, search_magic_path):
9262 Omit last arg SUFFIX; it was always 0. All callers changed.
9263 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9264
7de51af5
PE
9265 * xfont.c (xfont_match): Avoid need for strlen.
9266
25ed6cc3
PE
9267 * xfns.c: Don't assume strlen fits in int.
9268 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9269
4eab31dd
PE
9270 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9271 not unsigned long, as we prefer signed integers. All callers changed.
9272 Detect integer overflow in repeat count.
9273 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9274 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9275
171e2a58
PE
9276 * termcap.c: Don't assume sizes fit in int and never overflow.
9277 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9278 (gobble_line): Check for size-calculation overflow.
9279
ad39faca 9280 * minibuf.c (Fread_buffer):
6e5bb2dc 9281 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9282 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9283 Don't assume string length fits in int.
9284
52c61c22 9285 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9286 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9287
b5b8c9e5
PE
9288 * font.c: Don't assume string length fits in int.
9289 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9290 Use ptrdiff_t, not int.
ccd6111c
PE
9291 (font_intern_prop): Don't assume string length fits in int.
9292 Don't assume integer property fits in fixnum.
9293 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9294
882f0d81 9295 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9296 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9297 Reformulate so as not to need the command string.
9298 Invoke gzip -cd rather than gunzip, as it's more portable.
9299 (lock_info_type, lock_file_1, lock_file):
9300 Don't assume pid_t and time_t fit in unsigned long.
9301 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9302 (current_lock_owner): Prefer signed type for sizes.
9303 Use memcpy, not strncpy, where memcpy is what is really wanted.
9304 Don't assume (via atoi) that time_t and pid_t fit in int.
9305 Check for time_t and/or pid_t out of range, e.g., via a network share.
9306 Don't alloca where an auto var works fine.
9307
93f4cf88
PE
9308 * fileio.c: Fix some integer overflow issues.
9309 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9310 Don't assume string length fits in int.
9311 (directory_file_name): Don't assume string length fits in long.
9312 (make_temp_name): Don't assume pid fits in int, or that its print
9313 length is less than 20.
9314
f3e92b69
PE
9315 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9316
1bfdaf10
PE
9317 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9318
35016e9a
PE
9319 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9320
3d1e65a1
PE
9321 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9322 We prefer signed integers, even for size calculations.
9323
0b963a93
PE
9324 * emacs.c: Don't assume string length fits in 'int'.
9325 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9326 (main): Don't invoke strlen when not needed.
9327
573f4b54
PE
9328 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9329 (XD_DEBUG_MESSAGE): Don't waste a byte.
9330
989f33ba
PE
9331 * callproc.c (getenv_internal_1, getenv_internal)
9332 (Fgetenv_internal):
965d34eb
PE
9333 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9334
e4d29b33
PE
9335 * lread.c (invalid_syntax): Omit length argument.
9336 All uses changed. This doesn't fix a bug, but it simplifies the
9337 code away from its former Hollerith-constant appearance, and it's
9338 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9339 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9340
eb49b136
PE
9341 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9342 This didn't break anything, but it didn't help either.
9343 It's confusing to put a bogus integer in a place where the actual
9344 value does not matter.
9f62aeb1 9345 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9346 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9347
15375a22
PE
9348 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9349 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9350 implementation.
b61cc01c
PE
9351 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9352 We prefer signed types, and the value cannot exceed the EMACS_INT
9353 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9354 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9355 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9356 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9357
53b2623d
PE
9358 * indent.c (sane_tab_width): New function.
9359 (current_column, scan_for_column, Findent_to, position_indentation)
9360 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9361 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9362
51cab52b 9363 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9364
f2ed8a70
PE
9365 * lisp.h (lint_assume): New macro.
9366 * composite.c (composition_gstring_put_cache):
9367 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9368
abe80cc6
PE
9369 * editfns.c, insdel.c:
9370 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9371
b02c740e
PE
9372 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9373
ebc96716
PE
9374 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9375
b4e50fa0 9376 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9377 Use much-faster test for byte-length change.
311d5d7c 9378 Don't assume string byte-length fits in 'int'.
a4cf38e4 9379 Check that character arg fits in 'int'.
85461888 9380 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9381
c0c1ee9f
PE
9382 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9383
a498d7f4
PE
9384 * fns.c (concat): Catch string overflow earlier.
9385 Do not rely on integer wraparound.
9386
51cab52b
PE
9387 * dispextern.h (struct it.overlay_strings_charpos)
9388 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9389 * xdisp.c (forward_to_next_line_start)
9390 (back_to_previous_visible_line_start)
9391 (reseat_at_next_visible_line_start, next_element_from_buffer):
9392 Don't arbitrarily truncate the value of 'selective' to int.
9393
76031fad
PE
9394 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9395
5eb55db9
PE
9396 * composite.c: Don't truncate sizes to 'int'.
9397 (composition_gstring_p, composition_reseat_it)
9398 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9399 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9400 not EMACS_UINT, for indexes.
5eb55db9 9401
0703a717
PE
9402 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9403
d6202519
PE
9404 * buffer.c: Include <verify.h>.
9405 (struct sortvec.priority, struct sortstr.priority):
8961a454 9406 Now EMACS_INT, not int.
c20998a7 9407 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9408 (struct sortstr.size, record_overlay_string)
9409 (struct sortstrlist.size, struct sortlist.used):
9410 Don't truncate size to int.
9411 (record_overlay_string): Check for size-calculation overflow.
d6202519 9412 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9413
d5a19415
JM
94142011-06-22 Jim Meyering <meyering@redhat.com>
9415
029529ac 9416 Don't leak an XBM-image-sized buffer
d5a19415
JM
9417 * image.c (xbm_load): Free the image buffer after using it.
9418
a9041e6c
PE
94192011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9420
9421 Port to Sun C.
9422 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9423 that Sun C diagnosed.
9424 * fns.c (secure_hash): Fix pointer signedness issue.
9425 * intervals.c (static_offset_intervals): New function.
9426 (offset_intervals): Use it.
9427
7f3f739f
LL
94282011-06-21 Leo Liu <sdl.web@gmail.com>
9429
9430 * deps.mk (fns.o):
9431 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9432 sha512.h.
9433
9434 * fns.c (secure_hash): Rename from crypto_hash_function and change
9435 the first arg to accept symbols.
5b66d427 9436 (Fsecure_hash): New primitive.
7f3f739f
LL
9437 (syms_of_fns): New symbols.
9438
76147d94
DD
94392011-06-20 Deniz Dogan <deniz@dogan.se>
9440
9441 * process.c (Fset_process_buffer): Clarify return value in
9442 docstring.
9443
7d7d0045
CY
94442011-06-18 Chong Yidong <cyd@stupidchicken.com>
9445
9446 * dispnew.c (add_window_display_history): Use BVAR.
9447
9448 * xdisp.c (debug_method_add): Use BVAR.
9449 (check_window_end, dump_glyph_matrix, dump_glyph)
9450 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9451
9452 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9453 Likewise.
9454
9455 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9456 check till after the cache is created in init_frame_faces.
9457
ff2bc410
SM
94582011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9459
9460 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9461
28177add
PE
94622011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9463
dd3482fe
PE
9464 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9465 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9466 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9467
393d71f3 9468 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9469 * fileio.c (Finsert_file_contents):
9470 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9471 Remove the old (too-loose) buffer overflow checks.
9472 They weren't needed, since make_gap checks for buffer overflow.
9473 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9474 The old code merely checked for Emacs fixnum overflow, and relied
9475 on undefined (wraparound) behavior. The new code avoids undefined
9476 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9477
2e6813b0 9478 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9479 Tune. Don't use wider integers than needed. Don't use alloca.
9480 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9481
599a9e4f
PE
9482 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9483
99561444
PE
9484 * insdel.c, lisp.h (buffer_overflow): New function.
9485 (insert_from_buffer_1, replace_range, replace_range_2):
9486 * insdel.c (make_gap_larger):
9487 * editfns.c (Finsert_char):
9488 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9489
28177add
PE
9490 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9491
e69dafad
PE
94922011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9493
4baa020d 9494 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9495
b1c46f02
PE
9496 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9497 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9498
e69dafad
PE
9499 * fileio.c: Don't assume EMACS_INT fits in off_t.
9500 (emacs_lseek): New static function.
9501 (Finsert_file_contents, Fwrite_region): Use it.
9502 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9503
566684ea
PE
9504 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9505
e6966cd6
PE
9506 * fns.c: Don't overflow int when computing a list length.
9507 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9508 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9509 truncation on 64-bit hosts. Check for QUIT every
9510 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9511 faster and is responsive enough.
9512 (Flength): Report an error instead of overflowing an integer.
9513 (Fsafe_length): Return a float if the value is not representable
9514 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9515 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9516 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9517
dd0b0efb
PE
9518 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9519 (header_size, word_size): New constants.
9520 (allocate_vectorlike): Don't check size overflow here.
9521 (allocate_vector): Check it here instead, since this is the only
9522 caller of allocate_vectorlike that could cause overflow.
9523 Check that the new vector's length is representable as a fixnum.
9524
86fe5cfe
PE
9525 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9526 The previous code was bogus. For example, next_almost_prime (32)
9527 returned 39, which is undesirable as it is a multiple of 3; and
9528 next_almost_prime (24) returned 25, which is a multiple of 5 so
9529 why was the code bothering to check for multiples of 7?
9530
80e88859
PE
9531 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9532
4a2f0ad6
PE
9533 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9534
f66c7cf8
PE
9535 Variadic C functions now count arguments with ptrdiff_t.
9536 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9537 Back then I didn't know that the Emacs coding style prefers signed int.
9538 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9539 were being counted with int, which may truncate counts on 64-bit
9540 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9541 * lisp.h (struct Lisp_Subr.function.aMANY)
9542 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9543 Arg counts are now ptrdiff_t, not size_t.
9544 All variadic functions and their callers changed accordingly.
9545 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9546 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9547 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9548 * callint.c (Fcall_interactively): Check arg count for overflow,
9549 to avoid potential buffer overrun. Use signed char, not 'int',
9550 for 'varies' array, so that we needn't bother to check its size
9551 calculation for overflow.
9552 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9553 * eval.c (apply_lambda):
9554 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9555 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9556 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9557
a1759b76
PE
9558 * callint.c (Fcall_interactively): Don't use index var as event count.
9559
d96be9fc
PE
9560 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9561 * mem-limits.h (SIZE): Remove; no longer used.
9562
a690a978 9563 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9564
578c21e6
PE
9565 Remove unnecessary casts.
9566 * xterm.c (x_term_init):
9567 * xfns.c (x_set_border_pixel):
9568 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9569 These aren't needed now that we assume ANSI C.
9570
96f53c6c
PE
9571 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9572 It's more likely to cause problems (due to unsigned overflow)
9573 than to cure them.
9574
83c77d31
PE
9575 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9576
ee2079f1
PE
9577 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9578
6da65536
PE
9579 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9580
7147c4a4
PE
9581 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9582
193e32d9
PE
9583 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9584
e5533da6
PE
9585 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9586
9910e595
PE
9587 GLYPH_CODE_FACE returns EMACS_INT, not int.
9588 * dispextern.h (merge_faces):
9589 * xfaces.c (merge_faces):
01103c44
PE
9590 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9591 Don't assume EMACS_INT fits in int.
9910e595 9592
2638320e
PE
9593 * character.h (CHAR_VALID_P): Remove unused parameter.
9594 * fontset.c, lisp.h, xdisp.c: All uses changed.
9595
045eb8d9
PE
9596 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9597
c1f134b5
PE
9598 * fns.c (concat): Minor tuning based on overflow analysis.
9599 This doesn't fix any bugs. Use int to hold character, instead
9600 of constantly refetching from Emacs object. Use XFASTINT, not
9601 XINT, for value known to be a character. Don't bother comparing
9602 a single byte to 0400, as it's always less.
9603
395fcb93 9604 * floatfns.c (Fexpt):
327eeec8
PE
9605 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9606
abbd3d23
PE
9607 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9608 for characters.
9609
684a03ef
PE
9610 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9611
0fed43f3
PE
9612 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9613 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9614 incorrectly succeed when S was a string, because 4294967386 was
9615 truncated before it was used.
9616
8fd02eb7
PE
9617 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9618 Otherwise, an out-of-range integer could cause undefined behavior
9619 on a 64-bit host.
9620
f8c86b69
PE
9621 * composite.c: Use int, not EMACS_INT, for characters.
9622 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9623 EMACS_INT, for values that are known to be in character range.
9624 This doesn't fix any bugs but is the usual style inside Emacs and
9625 may generate better code on 32-bit machines.
9626
34206dd2
PE
9627 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9628 This is for reasons similar to the recent CHAR_STRING fix.
9629 * charset.c (Fencode_char): Check that character arg is actually
9630 a character. Pass an int to ENCODE_CHAR.
9631 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9632 wider than 'int', as a compile-time check to prevent future regressions
9633 in this area.
9634
c5958d4c 9635 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9636
9637 Make sure a 64-bit char is never passed to CHAR_STRING.
9638 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9639 by silently ignoring the top 32 bits, allowing some values
9640 that were far too large to be valid characters.
9641 * character.h: Include <verify.h>.
9642 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9643 arguments are no wider than unsigned, as a compile-time check
9644 to prevent future regressions in this area.
9645 * data.c (Faset):
01103c44 9646 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9647 (Fsubst_char_in_region):
9648 * fns.c (concat):
9649 * xdisp.c (decode_mode_spec_coding):
9650 Adjust to CHAR_STRING's new requirement.
9651 * editfns.c (Finsert_char, Fsubst_char_in_region):
9652 * fns.c (concat): Check that character args are actually
9653 characters. Without this test, these functions did the wrong
9654 thing with wildly out-of-range values on 64-bit hosts.
9655
d37ca623
PE
9656 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9657 These casts should not be needed on 32-bit hosts, either.
9658 * keyboard.c (read_char):
9659 * lread.c (Fload): Remove casts to unsigned.
9660
ea204efb
PE
9661 * lisp.h (UNSIGNED_CMP): New macro.
9662 This fixes comparison bugs on 64-bit hosts.
9663 (ASCII_CHAR_P): Use it.
9664 * casefiddle.c (casify_object):
01103c44 9665 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9666 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9667 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9668 * dispextern.h (FACE_FROM_ID):
9669 * keyboard.c (read_char): Use UNSIGNED_CMP.
9670
41cb286c
PE
9671 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9672 not to EMACS_INT, to avoid GCC warning.
9673
4a1b9832
PE
9674 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9675
55daad71
PE
9676 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9677 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9678 isn't needed on 32-bit machines.
8f95c75c 9679
01103c44
PE
9680 * buffer.c (Fgenerate_new_buffer_name):
9681 Use EMACS_INT for count, not int.
0ceccced 9682 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9683
9684 * data.c (Qcompiled_function): Now static.
9685
c6f072e7
PE
9686 * window.c (window_body_lines): Now static.
9687
20ce5912
PE
9688 * image.c (gif_load): Rename local to avoid shadowing.
9689
9c4c5f81
PE
9690 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9691 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9692 * alloc.c (make_save_value): Integer argument is now of type
9693 ptrdiff_t, not int.
9694 (mark_object): Use ptrdiff_t, not int.
9695 * lisp.h (pD): New macro.
9696 * print.c (print_object): Use it.
9697
c0c5c8ae
PE
9698 * alloc.c: Use EMACS_INT, not int, to count objects.
9699 (total_conses, total_markers, total_symbols, total_vector_size)
9700 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9701 (total_free_floats, total_floats, total_free_intervals)
9702 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9703 Now EMACS_INT, not int. All uses changed.
9704 (Fgarbage_collect): Compute overall total using a double, so that
9705 integer overflow is less likely to be a problem. Check for overflow
9706 when converting back to an integer.
5a25e253
PE
9707 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9708 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9709 These were 'int' variables that could overflow on 64-bit hosts;
9710 they were never used, so remove them instead of repairing them.
211a0b2a 9711 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9712 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9713 Previously, this ceilinged at INT_MAX, but that doesn't work on
9714 64-bit machines.
e46bb31a 9715 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9716
c78baabf 9717 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9718 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9719 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9720 when a (possibly-narrower) signed value would do just as well.
9721 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9722
c9d624c6
PE
9723 * alloc.c: Catch some string size overflows that we were missing.
9724 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9725 for convenience in STRING_BYTES_MAX.
9726 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9727 The definition here is exact; the one in lisp.h was approximate.
9728 (allocate_string_data): Check for string overflow. This catches
9729 some instances we weren't catching before. Also, it catches
9730 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9731 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9732 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9733
c9d624c6
PE
9734 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9735 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9736 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9737
353032ce
PE
9738 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9739
2bccce07
PE
9740 * alloc.c (Fmake_string): Check for out-of-range init.
9741
0ac30604
SM
97422011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9743
9744 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9745
c195f2de
JD
97462011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9747
9748 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9749 xg_get_default_scrollbar_width.
9750
9751 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9752 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9753 (style_changed_cb): Call update_theme_scrollbar_width and call
9754 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9755 all frames (Bug#8505).
9756 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9757 Call gtk_window_set_resizable if HAVE_GTK3.
9758 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9759 and height if HAVE_GTK3 (Bug#8505).
9760 (scroll_bar_width_for_theme): New variable.
9761 (update_theme_scrollbar_width): New function.
9762 (xg_get_default_scrollbar_width): Move code to
9763 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9764 (xg_initialize): Call update_theme_scrollbar_width.
9765
9766 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9767
9768 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9769
e10ac9f1
MR
97702011-06-12 Martin Rudalics <rudalics@gmx.at>
9771
9772 * frame.c (make_frame): Call other_buffer_safely instead of
9773 other_buffer.
9774
9775 * window.c (temp_output_buffer_show): Call display_buffer with
9776 second argument Vtemp_buffer_show_specifiers and reset latter
9777 immediately after the call.
9778 (Vtemp_buffer_show_specifiers): New variable.
9779 (auto_window_vscroll_p, next_screen_context_lines)
9780 (Vscroll_preserve_screen_position): Remove leading asterisks from
9781 doc-strings.
9782
2d3c217e 97832011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9784
7b7f97e8 9785 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9786 * buffer.c (Qclone_number): Remove for now, as it's unused.
9787 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9788 (record_buffer): Remove unused local.
9789 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9790 (set_frame_buffer_list): Remove; unused.
9791 * frame.h (other_visible_frames): Remove decl.
9792 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9793 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9794 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9795 if HAVE_GPM.
9796 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9797 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9798 Define only if HAVE_GPM.
9799 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9800 (update_hints_inhibit): Remove; never set. All uses removed.
9801 * widgetprv.h (emacsFrameClassRec): Remove decl.
9802 * window.c (delete_deletable_window): Now returns void, since it
9803 wasn't returning anything.
9804 (compare_window_configurations): Remove unused locals.
9805 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9806 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9807 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9808 the same widths as pointers. This follows up on the 2011-05-06 patch.
9809 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9810 * xterm.h: Likewise.
9811 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9812
1384b89e
JB
98132011-06-12 Juanma Barranquero <lekktu@gmail.com>
9814
9815 * makefile.w32-in: Update dependencies.
9816 (LISP_H): Add lib/intprops.h.
9817
1100a63c
CY
98182011-06-11 Chong Yidong <cyd@stupidchicken.com>
9819
9820 * image.c (gif_load): Add animation frame delay to the metadata.
9821 (syms_of_image): Use DEFSYM. New symbol `delay'.
9822
6198ccd0
MR
98232011-06-11 Martin Rudalics <rudalics@gmx.at>
9824
9825 * window.c (delete_deletable_window): Re-add.
9826 (Fset_window_configuration): Rewrite to handle dead buffers and
9827 consequently deletable windows.
9828 (window_tree, Fwindow_tree): Remove. Supply functionality in
9829 window.el.
9830 (compare_window_configurations): Simplify code.
9831
b6e3633c
AS
98322011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9833
1ab0dee5
AS
9834 * image.c (imagemagick_load_image): Fix type mismatch.
9835 (Fimagemagick_types): Likewise.
9836
b6e3633c
AS
9837 * window.h (replace_buffer_in_windows): Declare.
9838
9397e56f
MR
98392011-06-11 Martin Rudalics <rudalics@gmx.at>
9840
9841 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9842 Qclone_number. Remove external declaration of Qdelete_window.
9843 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9844 code.
640c8776
SM
9845 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9846 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9847 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9848 buffer list implementation.
9849 (other_buffer_safely): New function.
9850 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9851 calls to replace_buffer_in_windows and
9852 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9853 if allowed.
9854 (record_buffer): Inhibit quitting and rewrite using quittable
9855 functions. Run Qbuffer_list_update_hook if allowed.
9856 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9857 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9858 Move switch-to-buffer to window.el.
9397e56f
MR
9859 (bury-buffer): Move to window.el.
9860 (Vbuffer_list_update_hook): New variable.
9861
9862 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9863 section.
9864
9865 * window.h (resize_frame_windows): Move up in code.
9866 (Fwindow_frame): Remove EXFUN.
9867 (replace_buffer_in_all_windows): Remove prototype.
9868 (replace_buffer_in_windows_safely): Add prototype.
9869
9870 * window.c: Declare Qdelete_window static again. Move down
9871 declaration of select_count.
9872 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9873 (Fother_window): Move to window.el.
9874 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9875 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9876 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9877 window.el.
9878 (replace_buffer_in_windows): Implement by calling
9879 Qreplace_buffer_in_windows.
9880 (replace_buffer_in_all_windows): Remove with some functionality
9881 moved into replace_buffer_in_windows_safely.
9882 (replace_buffer_in_windows_safely): New function.
9883 (select_window_norecord, select_frame_norecord): Move in front
9884 of run_window_configuration_change_hook. Remove now obsolete
9885 declarations.
640c8776
SM
9886 (Fset_window_buffer): Rewrite doc-string.
9887 Call Qrecord_window_buffer.
9397e56f
MR
9888 (keys_of_window): Move binding for other-window to window.el.
9889
b50691aa
CY
98902011-06-11 Chong Yidong <cyd@stupidchicken.com>
9891
9892 * dispextern.h (struct image): Replace data member, whose int_val
9893 and ptr_val fields were not used by anything, with a single
9894 lisp_val object.
9895
9896 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9897 (gif_clear_image, gif_load, imagemagick_load_image)
9898 (gs_clear_image, gs_load): Callers changed.
9899
3f754b86
PE
99002011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9901
cca69397
PE
9902 * buffer.h: Include <time.h>, for time_t.
9903 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9904
109e28d0
PE
9905 Fix minor problems found by static checking.
9906
60737f02
PE
9907 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9908
4b66faf3
PE
9909 Make identifiers static if they are not used in other modules.
9910 * data.c (Qcompiled_function, Qframe, Qvector):
9911 * image.c (QimageMagick, Qsvg):
9912 * minibuf.c (Qmetadata):
9913 * window.c (resize_window_check, resize_root_window): Now static.
9914 * window.h (resize_window_check, resize_root_window): Remove decls.
9915
109e28d0
PE
9916 * window.c (window_deletion_count, delete_deletable_window):
9917 Remove; unused.
46a4ce9e
PE
9918 (window_body_lines): Now static.
9919 (Fdelete_other_windows_internal): Mark vars as initialized.
9920 Make sure 'resize_failed' is initialized.
9921 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9922 (resize_window_apply): Remove unused local.
9923 * window.h (delete_deletable_window): Remove decl.
9924
109e28d0 9925 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9926 (imagemagick_load_image): Fix pointer signedness problem by changing
9927 last arg from unsigned char * to char *. All uses changed.
9928 Also, fix a local for similar reasons.
9929 Remove unused locals. Remove locals to avoid shadowing.
9930 (fn_rsvg_handle_free): Remove; unused.
9931 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9932 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9933
3f754b86
PE
9934 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9935
2547adb1
CY
99362011-06-10 Chong Yidong <cyd@stupidchicken.com>
9937
9938 * image.c (gif_load): Fix omitted cast error introduced by
9939 2011-06-06 change.
9940
2c8e37d4
MR
99412011-06-10 Martin Rudalics <rudalics@gmx.at>
9942
9943 * window.h (resize_proportionally, orig_total_lines)
9944 (orig_top_line): Remove from window structure.
9945 (set_window_height, set_window_width, change_window_heights)
9946 (Fdelete_window): Remove prototypes.
9947 (resize_frame_windows): Remove duplicate declaration.
9948
440a42e3
EZ
99492011-06-10 Eli Zaretskii <eliz@gnu.org>
9950
9951 * window.h (resize_frame_windows, resize_window_check)
9952 (delete_deletable_window, resize_root_window)
9953 (resize_frame_windows): Declare prototypes.
9954
9955 * window.c (resize_window_apply): Make definition be "static" to
9956 match the prototype.
9957
562dd5e9
MR
99582011-06-10 Martin Rudalics <rudalics@gmx.at>
9959
9960 * window.c: Remove declarations of Qwindow_size_fixed,
9961 window_min_size_1, window_min_size_2, window_min_size,
9962 size_window, window_fixed_size_p, enlarge_window, delete_window.
9963 Remove static from declaration of Qdelete_window, it's
9964 temporarily needed by Fbury_buffer.
9965 (replace_window): Don't assign orig_top_line and
9966 orig_total_lines.
9967 (Fdelete_window, delete_window): Remove. Window deletion is
9968 handled by window.el.
640c8776
SM
9969 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9970 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9971 (Fdelete_other_windows): Remove. Deleting other windows is
9972 handled by window.el.
9973 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9974 handled in window.el.
9975 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9976 Window minimum sizes are handled in window.el.
9977 (shrink_windows, size_window, set_window_height)
9978 (set_window_width, change_window_heights, window_height)
9979 (window_width, CURBEG, CURSIZE, enlarge_window)
9980 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9981 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9982 handled in window.el.
9983 (make_dummy_parent): Rename to make_parent_window and give it a
9984 second argument horflag.
9985 (make_window): Don't set resize_proportionally any more.
9986 (Fsplit_window): Remove. Windows are split in window.el.
9987 (save_restore_action, save_restore_orig_size)
9988 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9989 Resize mini windows in window.el.
9990 (grow_mini_window, shrink_mini_window): Implement by calling
9991 Qresize_root_window_vertically, resize_window_check and
9992 resize_window_apply.
640c8776
SM
9993 (saved_window, Fset_window_configuration, save_window_save):
9994 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9995 resize_proportionally.
9996 (window_min_height, window_min_width): Move to window.el.
9997 (keys_of_window): Move bindings for delete-other-windows,
9998 split-window, delete-window and enlarge-window to window.el.
9999
10000 * buffer.c: Temporarily extern Qdelete_window.
10001 (Fbury_buffer): Temporarily call Qdelete_window instead of
10002 Fdelete_window (Fbury_buffer will move to window.el soon).
10003
10004 * frame.c (set_menu_bar_lines_1): Remove code handling
10005 orig_top_line and orig_total_lines.
10006
10007 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10008 set_window_height but set heights directly.
10009 (change_frame_size_1): Use resize_frame_windows.
10010
10011 * xdisp.c (init_xdisp): Don't use set_window_height but set
10012 heights directly.
10013
640c8776
SM
10014 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10015 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10016 run_window_configuration_change_hook.
10017
10018 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10019 instead of change_window_heights and run
10020 run_window_configuration_change_hook.
10021
1a13852e
MR
100222011-06-09 Martin Rudalics <rudalics@gmx.at>
10023
10024 * window.c (replace_window): Rename second argument REPLACEMENT to
10025 NEW. New third argument SETFLAG. Rewrite.
10026 (delete_window, make_dummy_parent): Call replace_window with
10027 third argument 1.
10028 (window_list_1): Move down in code.
10029 (run_window_configuration_change_hook): Move set_buffer part
10030 before select_frame_norecord part in order to unwind correctly.
10031 Rename count1 to count.
10032 (recombine_windows, delete_deletable_window, resize_root_window)
10033 (Fdelete_other_windows_internal)
10034 (Frun_window_configuration_change_hook, make_parent_window)
10035 (resize_window_check, resize_window_apply, Fresize_window_apply)
10036 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10037 (Fdelete_window_internal, Fresize_mini_window_internal):
10038 New functions.
1a13852e
MR
10039 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10040
f3d1777e
MR
100412011-06-08 Martin Rudalics <rudalics@gmx.at>
10042
496e208e
MR
10043 * window.h (window): Add some new members to window structure -
10044 normal_lines, normal_cols, new_total, new_normal, clone_number,
10045 splits, nest, prev_buffers, next_buffers.
10046 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10047 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10048
f3d1777e
MR
10049 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10050 Remove.
496e208e
MR
10051 (make_dummy_parent): Set new members of windows structure.
10052 (make_window): Move down in code. Handle new members of window
10053 structure.
10054 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10055 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10056 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10057 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10058 (Fset_window_next_buffers, Fset_window_clone_number):
10059 New functions.
496e208e
MR
10060 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10061 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10062 Doc-string fixes.
10063 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10064 Argument WINDOW can be now internal window too.
10065 (Fwindow_use_time): Move up in code.
10066 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10067 Rewrite doc-string.
10068 (Fset_window_configuration, saved_window)
10069 (Fcurrent_window_configuration, save_window_save): Handle new
10070 members of window structure.
b9e809c2
MR
10071 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10072 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10073 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10074 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10075 Qget_mru_window, Qresize_root_window,
10076 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10077 Qauto_buffer_name; staticpro them.
f3d1777e 10078
abde8f8c
MR
100792011-06-07 Martin Rudalics <rudalics@gmx.at>
10080
10081 * window.c (Fwindow_total_size, Fwindow_left_column)
10082 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10083 (Fwindow_list_1): New functions.
10084 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10085 (Fwindow_width, Fscroll_left, Fscroll_right):
10086 Use window_body_cols instead of window_box_text_cols.
10087 (delete_window, Fset_window_configuration):
10088 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10089 (delete_all_subwindows): Take a window as argument and not a
10090 structure. Rewrite.
190b47e6
MR
10091 (window_loop): Remove handling of GET_LRU_WINDOW and
10092 GET_LARGEST_WINDOW.
10093 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10094
10095 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10096 window_box_text_cols. delete_all_subwindows now takes a
10097 Lisp_Object as argument.
abde8f8c 10098
640c8776
SM
10099 * indent.c (compute_motion, Fcompute_motion):
10100 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10101
fa8a67e6
MR
10102 * frame.c (delete_frame): Call delete_all_subwindows with root
10103 window as argument.
10104
a54e3482
DC
101052011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10106
10107 * fns.c (Fputhash): Document return value.
10108
60002bf5
CY
101092011-06-06 Chong Yidong <cyd@stupidchicken.com>
10110
10111 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10112
0c671da6 101132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10114
b862a52a 10115 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10116
be44ca6c
PE
10117 Check for overflow when converting integer to cons and back.
10118 * charset.c (Fdefine_charset_internal, Fdecode_char):
10119 Use cons_to_unsigned to catch overflow.
10120 (Fencode_char): Use INTEGER_TO_CONS.
10121 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10122 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10123 * data.c (long_to_cons, cons_to_long): Remove.
10124 (cons_to_unsigned, cons_to_signed): New functions.
10125 These signal an error for invalid or out-of-range values.
10126 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10127 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10128 * font.c (Ffont_variation_glyphs):
10129 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10130 * lisp.h: Include <intprops.h>.
10131 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10132 (cons_to_signed, cons_to_unsigned): New decls.
10133 (long_to_cons, cons_to_long): Remove decls.
10134 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10135 (Fprimitive_undo): Use CONS_TO_INTEGER.
10136 * xfns.c (Fx_window_property): Likewise.
10137 * xselect.c: Include <limits.h>.
10138 (x_own_selection, selection_data_to_lisp_data):
10139 Use INTEGER_TO_CONS.
10140 (x_handle_selection_request, x_handle_selection_clear)
10141 (x_get_foreign_selection, Fx_disown_selection_internal)
10142 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10143 (lisp_data_to_selection_data): Use cons_to_unsigned.
10144 (x_fill_property_data): Use cons_to_signed.
10145 Report values out of range.
10146
d1f3d2af
PE
10147 Check for buffer and string overflow more precisely.
10148 * buffer.h (BUF_BYTES_MAX): New macro.
10149 * lisp.h (STRING_BYTES_MAX): New macro.
10150 * alloc.c (Fmake_string):
10151 * character.c (string_escape_byte8):
10152 * coding.c (coding_alloc_by_realloc):
10153 * doprnt.c (doprnt):
10154 * editfns.c (Fformat):
10155 * eval.c (verror):
10156 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10157 since they may not be the same number.
10158 * editfns.c (Finsert_char):
10159 * fileio.c (Finsert_file_contents):
10160 Likewise for BUF_BYTES_MAX.
10161
dd52fcea
PE
10162 * image.c: Use ptrdiff_t, not int, for sizes.
10163 (slurp_file): Switch from int to ptrdiff_t.
10164 All uses changed.
10165 (slurp_file): Check that file size fits in both size_t (for
10166 malloc) and ptrdiff_t (for sanity and safety).
10167
7f9bbdbb
PE
10168 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10169 if b->modtime has its maximal value.
10170
dfe18f82
PE
10171 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10172
84acfcf0
PE
10173 Don't assume time_t can fit into int.
10174 * buffer.h (struct buffer.modtime): Now time_t, not int.
10175 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10176 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10177
ccd9a01a
PE
10178 Minor fixes for signed vs unsigned integers.
10179 * character.h (MAYBE_UNIFY_CHAR):
10180 * charset.c (maybe_unify_char):
10181 * keyboard.c (read_char, reorder_modifiers):
10182 XINT -> XFASTINT, since the integer must be nonnegative.
10183 * ftfont.c (ftfont_spec_pattern):
10184 * keymap.c (access_keymap, silly_event_symbol_error):
10185 XUINT -> XFASTINT, since the integer must be nonnegative.
10186 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10187 since it makes no difference and we prefer signed.
10188 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10189 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10190 nonnegative.
10191
d6d100dd
SM
101922011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10193
10194 * window.h (Fwindow_frame): Declare.
10195
2b6148e4
PE
101962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10197
10198 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10199 (SPARE_MEMORY): Always define.
10200 (LARGE_REQUEST): Remove.
10201 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10202
f230ecc9
MR
102032011-06-06 Martin Rudalics <rudalics@gmx.at>
10204
727e958e
MR
10205 * lisp.h: Move EXFUNS for Fframe_root_window,
10206 Fframe_first_window and Fset_frame_selected_window to window.h.
10207
10208 * window.h: Move EXFUNS for Fframe_root_window,
10209 Fframe_first_window and Fset_frame_selected_window here from
10210 lisp.h.
10211
10212 * frame.c (Fwindow_frame, Fframe_first_window)
10213 (Fframe_root_window, Fframe_selected_window)
10214 (Fset_frame_selected_window): Move to window.c.
10215 (Factive_minibuffer_window): Move to minibuf.c.
10216 (Fother_visible_frames_p): New function.
10217
10218 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10219
f230ecc9
MR
10220 * window.c (decode_window, decode_any_window): Move up in code.
10221 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10222 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10223 (Fwindow_buffer): Move up and rewrite doc-string.
10224 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10225 (Fwindow_prev): New functions.
727e958e
MR
10226 (Fwindow_frame): Move here from frame.c. Accept any window as
10227 argument.
10228 (Fframe_root_window, Fframe_first_window)
10229 (Fframe_selected_window): Move here from frame.c. Accept frame
10230 or arbitrary window as argument. Update doc-strings.
10231 (Fminibuffer_window): Move up in code.
10232 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10233 (Fset_frame_selected_window): Move here from frame.c.
10234 Marginal rewrite.
727e958e
MR
10235 (Fselected_window, select_window, Fselect_window): Move up in
10236 code. Minor doc-string fixes.
f230ecc9 10237
4d09bcf6
PE
102382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10239
10240 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10241 Do not assume that spare memory exists; that assumption is valid
10242 only if SYSTEM_MALLOC.
10243 (LARGE_REQUEST): New macro, so that the issue of large requests
10244 is separated from the issue of spare memory.
10245
810928a2
AS
102462011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10247
172418ad
AS
10248 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10249 format. (Bug#8806)
10250
43f862f7
AS
10251 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10252
810928a2
AS
10253 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10254 before statements.
10255
a059fe24
JD
102562011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10257
10258 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10259
10260 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10261
10262 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10263 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10264
989bf368
JB
102652011-06-05 Juanma Barranquero <lekktu@gmail.com>
10266
10267 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10268
4b80f674
CY
102692011-06-04 Chong Yidong <cyd@stupidchicken.com>
10270
10271 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10272 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10273 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10274 New error handlers.
4b80f674
CY
10275 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10276 Obey Vx_select_enable_clipboard_manager. Catch errors in
10277 x_clipboard_manager_save (Bug#8779).
10278 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10279 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10280
99a33b77 102812011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10282
10283 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10284
99a33b77 102852011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10286
10287 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10288 in the current matrix if keep_current_p is non-zero.
10289
8264569d
EZ
102902011-06-04 Eli Zaretskii <eliz@gnu.org>
10291
10292 * bidi.c (bidi_level_of_next_char): Fix last change.
10293
57f97249
EZ
102942011-06-03 Eli Zaretskii <eliz@gnu.org>
10295
fec2107c 10296 Support bidi reordering of text covered by display properties.
57f97249 10297
fec2107c
EZ
10298 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10299 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10300 (bidi_cache_search, bidi_cache_iterator_state)
10301 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10302 (bidi_level_of_next_char, bidi_move_to_visually_next):
10303 Support character positions inside a run of characters covered by a
fec2107c
EZ
10304 display string.
10305 (bidi_paragraph_init, bidi_resolve_explicit_1)
10306 (bidi_level_of_next_char): Call bidi_fetch_char and
10307 bidi_fetch_char_advance instead of FETCH_CHAR and
10308 FETCH_CHAR_ADVANCE.
10309 (bidi_init_it): Initialize new members.
10310 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10311 definitions.
10312 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10313 instead of using explicit *_CHAR codes.
d6d100dd
SM
10314 (bidi_resolve_explicit, bidi_resolve_weak):
10315 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10316 bidirectional text is supported only in multibyte buffers.
10317 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10318 it to initialize the frame_window_p member of struct bidi_it.
10319 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10320 (bidi_resolve_explicit, bidi_resolve_weak)
10321 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10322 bidi_it->nchars is non-positive.
10323 (bidi_level_of_next_char): Don't try to lookup the cache for the
10324 next/previous character if nothing is cached there yet, or if we
10325 were just reseat()'ed to a new position.
c40e2fb2 10326
0e14fe90
EZ
10327 * xdisp.c (set_cursor_from_row): Set start and stop points
10328 according to the row's direction when priming the loop that looks
10329 for the glyph on which to display cursor.
10330 (single_display_spec_intangible_p): Function deleted.
10331 (display_prop_intangible_p): Reimplement to call
10332 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10333 Accept 3 additional arguments needed by handle_display_spec.
10334 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10335 values: lists, `(when COND...)' forms, etc.
10336 (single_display_spec_string_p): Support property values that are
10337 lists with the argument STRING its top-level element.
10338 (display_prop_string_p): Fix the condition for processing a
10339 property that is a list to be consistent with handle_display_spec.
fec2107c 10340 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10341 last portion of handle_display_prop.
10342 (compute_display_string_pos): Accept additional argument
10343 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10344 value of a `display' property is a "replacing spec".
10345 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10346 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10347 the display property, but just return a value indicating whether
10348 the display property will replace the characters it covers.
10349 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10350 frame_window_p members of struct bidi_it.
d6d100dd
SM
10351 (compute_display_string_pos, compute_display_string_end):
10352 New functions.
fec2107c
EZ
10353 (push_it): Accept second argument POSITION, where pop_it should
10354 jump to continue iteration.
10355 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10356
fec2107c
EZ
10357 * keyboard.c (adjust_point_for_property): Adjust the call to
10358 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10359
10360 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10361 (bidi_init_it): Update prototypes.
10362 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10363 (compute_display_string_pos, compute_display_string_end):
10364 Declare prototypes.
fec2107c
EZ
10365 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10366 EMACS_INT.
fc6f18ce 10367
40087514 103682011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10369
57f53182
PE
10370 Malloc failure behavior now depends on size of allocation.
10371 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10372 * lisp.h: Change signatures accordingly.
10373 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10374 All callers changed. (Bug#8762)
10375
10376 * gnutls.c: Use Emacs's memory allocators.
10377 Without this change, the gnutls library would invoke malloc etc.
10378 directly, which causes problems on non-SYNC_INPUT hosts, and which
10379 runs afoul of improving memory_full behavior. (Bug#8761)
10380 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10381 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10382 xfree instead of the default malloc, realloc, free.
10383 (Fgnutls_boot): No need to check for memory allocation failure,
10384 since xmalloc does that for us.
10385
ac32cd99 10386 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10387 * category.c (hash_get_category_set):
10388 * ccl.c (ccl_driver):
10389 * charset.c (Fdefine_charset_internal):
10390 * charset.h (struct charset.hash_index):
10391 * composite.c (get_composition_id, gstring_lookup_cache)
10392 (composition_gstring_put_cache):
10393 * composite.h (struct composition.hash_index):
10394 * dispextern.h (struct image.hash):
10395 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10396 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10397 (hashfn_equal, hashfn_user_defined, make_hash_table)
10398 (maybe_resize_hash_table, hash_lookup, hash_put)
10399 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10400 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10401 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10402 * image.c (make_image, search_image_cache, lookup_image)
10403 (xpm_put_color_table_h):
10404 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10405 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10406 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10407 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10408 * alloc.c (allocate_vectorlike):
10409 Check for overflow in vector size calculations.
10410 * ccl.c (ccl_driver):
10411 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10412 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10413 need to be updated by these changes.
40087514
PE
10414 * fns.c (make_hash_table, maybe_resize_hash_table):
10415 Check for integer overflow with large hash tables.
0de4bb68
PE
10416 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10417 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10418 (SXHASH_REDUCE): New macro.
10419 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10420 Use it instead of discarding useful hash info with large hash values.
10421 (sxhash_float): New function.
10422 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10423 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10424 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10425 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10426 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10427 Adjust signatures to match updated version of code.
10428 (consing_since_gc): Now EMACS_INT, since a single hash table can
10429 use more than INT_MAX bytes.
10430
698d32e2
DN
104312011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10432
10433 Make it possible to build with GCC-4.6+ -O2 -flto.
10434
10435 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10436
fd6fa53f
SM
104372011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10438
10439 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10440 Call minibuffer-inactive-mode.
10441
864db017
JB
104422011-05-31 Juanma Barranquero <lekktu@gmail.com>
10443
10444 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10445 Update dependencies.
10446
2ad0baf4
DN
104472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10448
10449 * data.c (init_data): Remove code for UTS, this system is not
10450 supported anymore.
10451
4fcc2638
DN
104522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10453
10454 Don't force ./temacs to start in terminal mode.
10455
10456 * frame.c (make_initial_frame): Initialize faces in all cases, not
10457 only when CANNOT_DUMP is defined.
10458 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10459
c56e0fd5
DN
104602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10461
10462 * dispnew.c (add_window_display_history): Use const for the string
10463 pointer. Remove declaration, not needed.
10464
333d54da 104652011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10466
55d4c1b2 10467 Use 'inline', not 'INLINE'.
333d54da 10468 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10469 * alloc.c, fontset.c (INLINE): Remove.
10470 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10471 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10472 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10473 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10474 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10475
738db178
DN
104762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10477
10478 Make it possible to run ./temacs.
10479
10480 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10481 syms_of_callproc does the same thing. Remove test for
10482 "initialized", do it in the caller.
10483 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10484
620c53a6
SM
104852011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10486
10487 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10488 (read_minibuf): Use get_minibuffer.
10489 (syms_of_minibuf): Use DEFSYM.
10490 (Qmetadata): New var.
10491 * data.c (Qbuffer): Don't make it static.
10492 (syms_of_data): Use DEFSYM.
10493
e003a292
PE
104942011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10495
10496 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10497 (CCL_CODE_MIN): New macro.
10498
ed008a6d
PE
104992011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10500
3687c2ef
PE
10501 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10502
ed008a6d
PE
10503 * eval.c (Qdebug): Now static.
10504 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10505 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10506 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10507
d66c4c7c
CY
105082011-05-29 Chong Yidong <cyd@stupidchicken.com>
10509
10510 * image.c: Various fixes to ImageMagick code comments.
10511 (Fimagemagick_types): Doc fix.
10512
5fbc2025
PE
105132011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10514
0196f88a
PE
10515 Minor fixes prompted by GCC 4.6.0 warnings.
10516
10517 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10518
5fbc2025
PE
10519 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10520 (x_clipboard_manager_save_all): Move extern decl to ...
10521 * xterm.h: ... here, so that it can be checked for consistency.
10522
1dd3c2d9
CY
105232011-05-29 Chong Yidong <cyd@stupidchicken.com>
10524
10525 * xselect.c (x_clipboard_manager_save_frame)
10526 (x_clipboard_manager_save_all): New functions.
10527 (Fx_clipboard_manager_save): Lisp function deleted.
10528
10529 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10530 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10531
10532 * xterm.h: Update prototype.
10533
5ba6571d
WX
105342011-05-28 William Xu <william.xwl@gmail.com>
10535
10536 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10537 exiting (Bug#8239).
10538
3eaff834
JM
105392011-05-28 Jim Meyering <meyering@redhat.com>
10540
e1900994 10541 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10542 * fns.c (to_uchar): Define.
10543 (crypto_hash_function): Use it to convert some newly-signed
10544 variables to unsigned, to avoid sign-extension bugs. For example,
10545 without this change, (md5 "truc") would evaluate to
10546 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10547 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10548 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10549
0f6990a7
PE
105502011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10551
10552 Integer overflow fixes.
c8a9ca5a 10553
08686060
PE
10554 * dbusbind.c: Serial number integer overflow fixes.
10555 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10556 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10557 to hold a serial number that is too large for a fixnum.
10558 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10559 Check for serial numbers out of range. Decode any serial number
59568bf0 10560 that was so large that it became a float. (Bug#8722)
08686060 10561
2d1fc3c7
PE
10562 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10563 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10564 Use XFASTINT rather than XUINT when numbers are nonnegative.
10565 (xd_append_arg, Fdbus_method_return_internal):
10566 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10567 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10568 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10569 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10570 (Bug#8722)
2d1fc3c7 10571
c8a9ca5a
PE
10572 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10573
519e1d69
PE
10574 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10575
6df6ae42 10576 ccl: Add integer overflow checks.
30569699
PE
10577 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10578 (IN_INT_RANGE): New macros.
10579 (ccl_driver): Use them to check for integer overflow when
10580 decoding a CCL program. Many of the new checks are whether XINT (x)
10581 fits in int; it doesn't always, on 64-bit hosts. The new version
10582 doesn't catch all possible integer overflows, but it's an
847044ea 10583 improvement. (Bug#8719)
30569699 10584
c11285dc
PE
10585 * alloc.c (make_event_array): Use XINT, not XUINT.
10586 There's no need for unsigned here.
10587
fdccd48e
PE
10588 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10589 This follows up to the 2011-05-06 change that substituted uintptr_t
10590 for EMACS_INT. This case wasn't caught back then.
10591
37910ab2
PE
10592 Rework Fformat to avoid integer overflow issues.
10593 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10594 now (part of C89). Include <verify.h>.
10595 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10596 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10597 (Fformat): Avoid the prepass trying to compute sizes; it was only
10598 approximate and thus did not catch overflow reliably. Instead, walk
10599 through the format just once, formatting and computing sizes as we go,
10600 checking for integer overflow at every step, and allocating a larger
10601 buffer as needed. Keep track separately whether the format is
10602 multibyte. Keep only the most-recently calculated precision, rather
10603 than them all. Record whether each argument has been converted to
10604 string. Use EMACS_INT, not int, for byte and char and arg counts.
10605 Support field widths and precisions larger than INT_MAX. Avoid
10606 sprintf's undefined behavior with conversion specifications such as %#d
10607 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10608 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10609 formatting out-of-range floating point numbers with int
9173deec 10610 formats. (Bug#8668)
37910ab2 10611
2e6578fb
PE
10612 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10613
0ae6bdee
PE
10614 * data.c: Avoid integer truncation in expressions involving floats.
10615 * data.c: Include <intprops.h>.
10616 (arith_driver): When there's an integer overflow in an expression
10617 involving floating point, convert the integers to floating point
10618 so that the resulting value does not suffer from catastrophic
10619 integer truncation. For example, on a 64-bit host (* 4
10620 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10621 Do not rely on undefined behavior after integer overflow.
10622
de883a70
PE
10623 merge count_size_as_multibyte, parse_str_to_multibyte
10624 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10625 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10626 Check for integer overflow.
10627 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10628 since it's now a duplicate of the other. This is more of
10629 a character than a buffer op, so better that it's in character.c.
10630 * fns.c, print.c: Adjust to above changes.
10631
2ff916cb
PE
106322011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10633
10634 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10635
f1b54466
PE
106362011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10637
fb1ac845
PE
10638 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10639 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10640 (x_clipboard_manager_save): Now static.
10641 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10642
f1b54466
PE
10643 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10644 (crypto_hash_function): Now static.
10645 Fix pointer signedness problems. Avoid unnecessary initializations.
10646
a9f737ee
CY
106472011-05-27 Chong Yidong <cyd@stupidchicken.com>
10648
10649 * termhooks.h (Vselection_alist): Make it terminal-local.
10650
10651 * terminal.c (create_terminal): Initialize it.
10652
10653 * xselect.c: Support for clipboard managers.
10654 (Vselection_alist): Move to termhooks.h as terminal-local var.
10655 (LOCAL_SELECTION): New macro.
10656 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10657 (symbol_to_x_atom): Remove gratuitous arg.
10658 (x_handle_selection_request, lisp_data_to_selection_data)
10659 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10660 (x_own_selection, x_get_local_selection, x_convert_selection):
10661 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10662 (some_frame_on_display): Delete unused function.
10663 (Fx_own_selection_internal, Fx_get_selection_internal)
10664 (Fx_disown_selection_internal, Fx_selection_owner_p)
10665 (Fx_selection_exists_p): New optional frame arg.
10666 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10667 (x_handle_selection_clear): Don't treat other terminals with the
10668 same keyboard specially. Use the terminal-local Vselection_alist.
10669 (x_clear_frame_selections): Use Frun_hook_with_args.
10670
10671 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10672
10673 * xterm.h: Add support for those atoms.
10674
e067f0c1
CY
106752011-05-26 Chong Yidong <cyd@stupidchicken.com>
10676
10677 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10678 (converted_selections, conversion_fail_tag): New global variables.
10679 (x_selection_request_lisp_error): Free the above.
10680 (x_get_local_selection): Remove unnecessary code.
10681 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10682 of converted selections stored in converted_selections.
10683 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10684 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10685 (x_convert_selection): New function.
10686 (x_handle_selection_event): Simplify.
10687 (x_get_foreign_selection): Don't ignore incoming requests while
10688 waiting for an answer; this will fail when we implement
10689 SAVE_TARGETS, and seems unnecessary anyway.
10690 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10691 (Vx_sent_selection_functions): Doc fix.
10692
0f4aebc0
LL
106932011-05-26 Leo Liu <sdl.web@gmail.com>
10694
10695 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10696
e61124cd
YM
106972011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10698
10699 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10700
10701 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10702 for fringe update if it has periodic bitmap.
ac389d0c 10703 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10704 and fringe_bitmap_periodic_p.
10705
10706 * fringe.c (get_fringe_bitmap_data): New function.
10707 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10708 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10709 row. Mark glyph row for fringe update if periodicity changed.
10710
10711 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10712 for fringe update unless it has periodic bitmap.
10713
f16d9837
KH
107142011-05-25 Kenichi Handa <handa@m17n.org>
10715
10716 * xdisp.c (get_next_display_element): Set correct it->face_id for
10717 a static composition.
10718
e1b90ef6
LL
107192011-05-24 Leo Liu <sdl.web@gmail.com>
10720
10721 * deps.mk (fns.o):
10722 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10723
10724 * fns.c (crypto_hash_function, Fsha1): New function.
10725 (Fmd5): Use crypto_hash_function.
10726 (syms_of_fns): Add Ssha1.
10727
7400048f
PE
107282011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10729
10730 * gnutls.c: Remove unused macros.
10731 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10732 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10733 Remove macros that are defined and never used.
10734 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10735
abb71cf4
CY
107362011-05-22 Chong Yidong <cyd@stupidchicken.com>
10737
10738 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10739 (Fx_get_selection_internal): Minor cleanup.
10740 (Fx_own_selection_internal): Rename arguments for consistency with
10741 select.el.
10742
6307db39
PE
107432011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10744
10745 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10746
f3d4e0a4
CY
107472011-05-22 Chong Yidong <cyd@stupidchicken.com>
10748
10749 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10750
4d8ade89
YM
107512011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10752
10753 * dispnew.c (scrolling_window): Don't exclude the case that the
10754 last enabled row in the desired matrix touches the bottom boundary.
10755
32078c8d
GM
107562011-05-21 Glenn Morris <rgm@gnu.org>
10757
10758 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10759 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10760 and add some more files.
32078c8d 10761
7285dc67
EZ
107622011-05-20 Eli Zaretskii <eliz@gnu.org>
10763
10764 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10765 report_file_error introduced by the change from 2011-05-07.
10766
89d1bd22
PE
107672011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10768
10769 * systime.h (Time): Define only if emacs is defined.
10770 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10771 where the include path doesn't have X11/X.h by default. See
10772 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10773
cd394be1 107742011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10775
10776 * composite.c (find_automatic_composition): Fix previous change.
10777
b9704ad9
GM
107782011-05-20 Glenn Morris <rgm@gnu.org>
10779
10780 * lisp.mk: New file, split from Makefile.in.
10781 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10782 (shortlisp): Remove.
10783 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10784
4a720484
GM
107852011-05-19 Glenn Morris <rgm@gnu.org>
10786
10787 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10788 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10789 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10790 (lisp): Set the order to that of loadup.el.
10791 (shortlisp): Make it a copy of $lisp.
10792 (SOME_MACHINE_LISP): Remove.
10793 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10794 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10795
a28d4396
KH
107962011-05-18 Kenichi Handa <handa@m17n.org>
10797
10798 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10799 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10800 (find_automatic_composition): Mostly rewrite for efficiency.
10801
a2b1fa8e
JB
108022011-05-18 Juanma Barranquero <lekktu@gmail.com>
10803
10804 * makefile.w32-in: Update dependencies.
10805
8e1f5610
CS
108062011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10807
10808 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10809 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10810
7025ee00 108112011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10812
cdfa6eab
PE
10813 Fix some integer overflow issues, such as string length overflow.
10814
06d6db33
PE
10815 * insdel.c (count_size_as_multibyte): Check for string overflow.
10816
2b4560a8
PE
10817 * character.c (lisp_string_width): Check for string overflow.
10818 Use EMACS_INT, not int, for string indexes and lengths; in
10819 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10820 the resulting string length overflows an EMACS_INT; instead,
10821 report a string overflow if no precision given. When checking for
10822 precision exhaustion, use a check that cannot possibly have
10823 integer overflow. (Bug#8675)
10824 * character.h (lisp_string_width): Adjust to new signature.
10825
cb93f9be
PE
10826 * alloc.c (string_overflow): New function.
10827 (Fmake_string): Use it. This doesn't change behavior, but saves
10828 a few bytes and will simplify future changes.
10829 * character.c (string_escape_byte8): Likewise.
10830 * lisp.h (string_overflow): New decl.
10831
1a1f3366
PE
10832 Fixups, following up to the user-interface timestamp change.
10833 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10834 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10835 * msdos.c (mouse_get_pos): Likewise.
10836 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10837 * w32gui.h (Time): Define by including "systime.h" rather than by
10838 declaring it ourselves. (Bug#8664)
10839
d4e3e4d3
PE
10840 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10841 * image.c (clear_image_cache): Likewise.
10842
f6a24d19
PE
10843 * term.c (term_mouse_position): Don't assume time_t wraparound.
10844
08dc5ae6
PE
10845 Be more systematic about user-interface timestamps.
10846 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10847 and sometimes 'EMACS_UINT', to represent these timestamps.
10848 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10849 This makes the code easier to follow, and makes it easier to catch
10850 integer overflow bugs such as Bug#8664.
10851 * frame.c (Fmouse_position, Fmouse_pixel_position):
10852 Use Time, not unsigned long, for user-interface timestamps.
10853 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10854 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10855 * keyboard.h (last_event_timestamp): Likewise.
10856 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10857 * menu.h (xmenu_show): Likewise.
10858 * term.c (term_mouse_position): Likewise.
10859 * termhooks.h (struct input_event.timestamp): Likewise.
10860 (struct terminal.mouse_position_hook): Likewise.
10861 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10862 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10863 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10864 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10865 what it was before.
10866 * menu.h, termhooks.h: Include "systime.h", for Time.
10867
8e55734a
PE
10868 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10869 Don't assume that the difference between two unsigned long values
10870 can fit into an integer. At this point, we know button_down_time
10871 <= event->timestamp, so the difference must be nonnegative, so
10872 there's no need to cast the result if double-click-time is
10873 nonnegative, as it should be; check that it's nonnegative, just in
10874 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10875 apart (about 25 days). (Bug#8664)
8e55734a 10876
841f1b75 10877 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10878 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10879
3e26f69c
PE
10880 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10881 that always fit in int. Use a sentinel instead of a counter, to
10882 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10883 * frame.h (struct frame): Use int for menu_bar_items_used
10884 instead of EMACS_INT, since it always fits in int.
3e26f69c 10885
5cc152c0
PE
10886 * menu.c (grow_menu_items): Check for int overflow.
10887
d89eb65e
PE
10888 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10889
5235bd3e
PE
10890 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10891 Before, the code was not consistent. These values cannot exceed
10892 2**31 - 1 so there's no need to make them unsigned.
10893 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10894 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10895 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10896 as modifiers.
10897 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10898
bc827e23
PE
10899 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10900 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10901 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10902 presumably because the widths might not match.
10903
78eb494e
PE
10904 * window.c (size_window): Avoid needless test at loop start.
10905
04f2d78b
CB
109062011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10907
10908 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10909
d2fc7e3d 109102011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10911
10912 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10913
d2fc7e3d 109142011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10915
10916 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10917 `width' to `bar_area_x' and `bar_area_width', respectively.
10918 (x_scroll_run): Take account of fringe background extension.
10919
04f2d78b
CB
10920 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10921 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10922 `bar_area_width', respectively.
10923 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10924 background extension.
10925
79b70037
GM
109262011-05-10 Jim Meyering <meyering@redhat.com>
10927
10928 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10929
2f142cc5
JB
109302011-05-10 Juanma Barranquero <lekktu@gmail.com>
10931
10932 * image.c (Finit_image_library): Return t for built-in image types,
10933 like pbm and xbm. (Bug#8640)
10934
57679c86
AS
109352011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10936
10937 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10938
888c9e86
EZ
109392011-05-07 Eli Zaretskii <eliz@gnu.org>
10940
b0512a1d
EZ
10941 * w32console.c (Fset_screen_color): Doc fix.
10942 (Fget_screen_color): New function.
10943 (syms_of_ntterm): Defsubr it.
10944
7285dc67
EZ
10945 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10946 unlink the temporary file if Fcall_process didn't create it in the
10947 first place.
10948 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10949 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10950 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10951 cue to call_process_cleanup not to close that handle.
10952
4d3fcc8e
BK
109532011-05-07 Ben Key <bkey76@gmail.com>
10954
10955 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10956 one of two shell specific rules, either bootstrap-temacs-CMD or
10957 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10958 to the previous implementation of the bootstrap-temacs rule.
10959 The bootstrap-temacs-CMD rule is similar to the previous
10960 implementation of the bootstrap-temacs rule except that it
10961 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10962 variable.
10963
10964 These changes, along with some changes to nt/configure.bat,
10965 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10966 earlier fix to add support for --cflags and --ldflags options
10967 that include quotes so that it works whether make uses cmd or
10968 sh as the shell.
10969
b4289b64
MA
109702011-05-06 Michael Albinus <michael.albinus@gmx.de>
10971
10972 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10973 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10974 is a constant.
10975 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10976 a string. Handle both cases.
10977 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10978 (Fdbus_register_method): Use Qinvalid_function.
10979
af4c0e28
JB
109802011-05-06 Juanma Barranquero <lekktu@gmail.com>
10981
10982 * makefile.w32-in: Update dependencies.
10983 (LISP_H): Add inttypes.h and stdin.h.
10984 (PROCESS_H): Add unistd.h.
10985
c51453d9
EZ
109862011-05-06 Eli Zaretskii <eliz@gnu.org>
10987
10988 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10989 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10990
8ff0ac3c 109912011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10992
4c4b566b
PE
10993 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10994
aab2b9b5
PE
10995 * term.c (vfatal): Remove stray call to va_end.
10996 It's not needed and the C Standard doesn't allow it here anyway.
10997
c378da0b
PE
10998 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10999 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11000
288b08c7
PE
11001 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11002 bytes.
11003
e3601888
PE
11004 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11005
db6c0e74
PE
11006 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11007
dd5963ea
PE
11008 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11009
88c9450f
PE
11010 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11011
2f9442b8
PE
11012 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11013
c032b5f8
PE
11014 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11015 * charset.c (Fdefine_charset_internal): Don't initialize
11016 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11017 32-bit int (Bug#8600).
a108c10b
PE
11018
11019 * lread.c (read_integer): Be more consistent with string-to-number.
11020 Use string_to_number to do the actual conversion; this avoids
11021 rounding errors and fixes some other screwups. Without this fix,
11022 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11023 (digit_to_number): Move earlier, for benefit of read_integer.
11024 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11025 not a digit in any supported base. (Bug#8602)
a108c10b 11026
ad5f9eea
PE
11027 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11028
aec1708a
PE
11029 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11030 to match comment at start of function. This also removes a
11031 GCC warning about overflow in a 32+64-bit port.
11032
47be4ab5
PE
11033 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11034
371cac43
PE
11035 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11036 Reported by Stefan Monnier in
11037 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11038 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11039 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11040
d01a7826
PE
11041 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11042 (EMACS_UINTPTR): Likewise, with uintptr_t.
11043
7fd47d5c
PE
11044 * lisp.h: Prefer 64-bit EMACS_INT if available.
11045 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11046 on 32-bit hosts that have 64-bit int, so that they can access
11047 large files.
122b0c86
PE
11048 However, temporarily disable this change unless the temporary
11049 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11050
8727937b
PE
11051 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11052
8ac068ac
PE
11053 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11054 This removes an assumption that EMACS_INT and long are the same
11055 width as pointers. The assumption is true for Emacs porting targets
11056 now, but we want to make other targets possible.
11057 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11058 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11059 In the rest of the code, change types of integers that hold casted
11060 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11061 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11062 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11063 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11064 No need to cast type when ORing.
11065 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11066 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11067 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11068 assume EMACS_INT is the same width as char *.
11069 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11070 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11071 Remove no-longer-needed casts.
11072 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11073 (xg_tool_bar_help_callback, xg_make_tool_item):
11074 Use EMACS_INTPTR to hold an integer
11075 that will be cast to void *; this can avoid a GCC warning
11076 if EMACS_INT is not the same width as void *.
11077 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11078 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11079 (current_message_1, set_message_1):
11080 Use a local to convert to proper width without a cast.
11081 * xmenu.c (dialog_selection_callback): Likewise.
11082
ede49d71
PE
11083 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11084 Also, don't assume VALBITS / RAND_BITS is less than 5,
11085 and don't rely on undefined behavior when shifting a 1 left into
11086 the sign bit.
11087 * lisp.h (get_random): Change signature to match.
11088
2f30ecd0
PE
11089 * lread.c (hash_string): Use size_t, not int, for hash computation.
11090 Normally we prefer signed values; but hashing is special, because
11091 it's better to use unsigned division on hash table sizes so that
11092 the remainder is nonnegative. Also, size_t is the natural width
11093 for hashing into memory. The previous code used 'int', which doesn't
11094 retain enough info to hash well into very large tables.
11095 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11096
2a866e7b
PE
11097 * dbusbind.c: Don't possibly lose pointer info when converting.
11098 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11099 Use XPNTR rather than XHASH, so that the high-order bits of
11100 the pointer aren't lost when converting through void *.
11101
51639eac
PE
11102 * eval.c (Fautoload): Don't double-shift a pointer.
11103
92394119
PE
11104 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11105
dbdb9a7c
JB
111062011-05-06 Juanma Barranquero <lekktu@gmail.com>
11107
11108 * gnutls.c (DEF_GNUTLS_FN):
11109 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11110
db7a0b4f
AS
111112011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11112
11113 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11114 marker. (Bug#8610)
11115
cd394be1 111162011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11117
11118 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11119 New version that can reserve upto 2GB of heap space.
11120
f7ff1b0f 111212011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11122
11123 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11124
639c109b
TZ
111252011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11126
11127 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11128 `gnutls_certificate_set_x509_key_file'.
11129
d2127135
JB
111302011-05-05 Juanma Barranquero <lekktu@gmail.com>
11131
11132 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11133 Update dependencies.
11134
e968f4f3
JB
111352011-05-04 Juanma Barranquero <lekktu@gmail.com>
11136
11137 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11138 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11139 Remove unused parameter `fildes'.
11140 * process.c (read_process_output, send_process): Don't pass it.
11141
84d358f0
JB
111422011-05-04 Juanma Barranquero <lekktu@gmail.com>
11143
11144 Fix previous change: the library cache is defined in w32.c.
11145 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11146 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11147
0898ca10
JB
111482011-05-04 Juanma Barranquero <lekktu@gmail.com>
11149
11150 Implement dynamic loading of GnuTLS on Windows.
11151
11152 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11153 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11154 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11155 Declare.
11156
11157 * gnutls.c (Qgnutls_dll): Define.
11158 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11159 (gnutls_*): Declare function pointers.
11160 (init_gnutls_functions): New function to initialize function pointers.
11161 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11162 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11163 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11164 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11165 (emacs_gnutls_write, emacs_gnutls_read)
11166 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11167 (Fgnutls_available_p): New function.
11168 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11169 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11170 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11171
11172 * image.c: Include w32.h.
11173 (Vimage_type_cache): Delete.
11174 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11175 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11176 (w32_delayed_load): Move to w32.c.
11177
11178 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11179
11180 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11181 (w32_delayed_load): Move from image.c. When loading a library, record
11182 its filename in the :loaded-from property of the library id.
11183 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11184 Initialize and staticpro them.
11185 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11186
11187 * process.c: Include lisp.h before w32.h, not after.
11188 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11189 instead of gnutls_record_check_pending.
11190
11191 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11192
ff4de4aa
TZ
111932011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11194
11195 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11196 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11197 as passed in.
11198
abe95abb
JD
111992011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11200
11201 * xterm.c (x_set_frame_alpha): Do not set property on anything
11202 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11203
e16e55d4
JB
112042011-05-02 Juanma Barranquero <lekktu@gmail.com>
11205
11206 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11207
bafcf6a5
JB
112082011-05-02 Juanma Barranquero <lekktu@gmail.com>
11209
11210 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11211 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11212 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11213 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11214 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11215 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11216 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11217 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11218 (Qgnutls_bootprop_callbacks_verify): Make static.
11219
e7a6747f
AS
112202011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11221
19ed11ba
AS
11222 * callproc.c: Indentation fixup.
11223
e7a6747f 11224 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11225 (wait_for_termination, interruptible_wait_for_termination):
11226 Move after wait_for_termination_1.
e7a6747f 11227
1ef14cb4
LMI
112282011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11229
11230 * sysdep.c (interruptible_wait_for_termination): New function
11231 which is like wait_for_termination, but allows keyboard
11232 interruptions.
11233
11234 * callproc.c (Fcall_process): Add (:file "file") as an option for
11235 the STDOUT buffer.
11236 (Fcall_process_region): Ditto.
11237
330d880c
EZ
112382011-04-30 Eli Zaretskii <eliz@gnu.org>
11239
8db90b73
EZ
11240 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11241 rather than `XVECTOR (FOO)->size'.
11242
330d880c
EZ
11243 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11244 inttypes.h, as a gnulib replacement is used if it not available in
11245 system headers.
11246
15cbd324
EZ
112472011-04-21 Eli Zaretskii <eliz@gnu.org>
11248
11249 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11250 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11251 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11252
11253 * coding.c (coding_alloc_by_realloc): Error out if destination
11254 will grow beyond MOST_POSITIVE_FIXNUM.
11255 (decode_coding_emacs_mule): Abort if there isn't enough place in
11256 charbuf for the composition carryover bytes. Reserve an extra
11257 space for up to 2 characters produced in a loop.
11258 (decode_coding_iso_2022): Abort if there isn't enough place in
11259 charbuf for the composition carryover bytes.
11260
112612011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11262
ae940cca
EZ
11263 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11264 aborting when %lld or %lll format is passed.
11265 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11266 %llo or %llx format is passed. (Bug#8545)
11267
03ab8921
EZ
11268 * window.c (window_scroll_line_based): Use a marker instead of
11269 simple variables to record original value of point. (Bug#7952)
11270
afda1437
EZ
11271 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11272 produced by %s or %c overflows available buffer space. (Bug#8545)
11273
f76dee0c
PE
112742011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11275
11276 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11277 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11278
fdc5744d
JB
112792011-04-28 Juanma Barranquero <lekktu@gmail.com>
11280
11281 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11282
638f053a
JB
112832011-04-28 Juanma Barranquero <lekktu@gmail.com>
11284
11285 * keyboard.c (Qdelayed_warnings_hook): Define.
11286 (command_loop_1): Run `delayed-warnings-hook'
11287 if Vdelayed_warnings_list is non-nil.
11288 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11289 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11290
d178f871
EZ
112912011-04-28 Eli Zaretskii <eliz@gnu.org>
11292
11293 * doprnt.c (doprnt): Don't return value smaller than the buffer
11294 size if the message was truncated. (Bug#8545).
11295
b124fd93
JB
112962011-04-28 Juanma Barranquero <lekktu@gmail.com>
11297
11298 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11299 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11300
e810457d
PE
113012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11302
11303 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11304
ea51cceb
JB
113052011-04-27 Juanma Barranquero <lekktu@gmail.com>
11306
11307 * makefile.w32-in: Update dependencies.
11308
94dcfacf
EZ
113092011-04-27 Eli Zaretskii <eliz@gnu.org>
11310
11311 Improve `doprnt' and its usage. (Bug#8545)
11312 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11313 `format_end'. Remove support for %l as a conversion specifier.
11314 Don't use xrealloc. Improve diagnostics when the %l size modifier
11315 is used. Update the commentary.
11316
11317 * eval.c (verror): Simplify calculation of size_t.
11318
11319 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11320 messages.
11321
f61f41d7
PE
113222011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11323
11324 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11325 change.
11326
96fb4434
PE
113272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11328
11329 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11330 This makes this file independent of the recent pseudovector change.
11331
671875da 113322011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11333
69e9b5a3
PE
11334 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11335
b5f869a7 11336 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11337 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11338 Remove unused local.
c8926152 11339 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11340
841a1577 11341 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11342 GCC 4.6.0 optimizes based on type-based alias analysis.
11343 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11344 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11345 != &v->size, and therefore "v->size = 1; b->size = 2; return
11346 v->size;" must therefore return 1. This assumption is incorrect
11347 for Emacs, since it type-puns struct Lisp_Vector * with many other
11348 types. To fix this problem, this patch adds a new type struct
f904488f 11349 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11350 and pseudovectors, and helps optimizing compilers not get fooled
11351 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11352 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11353 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11354 the size member.
eab3844f
PE
11355 (XSETPVECTYPE): Rewrite in terms of new macro.
11356 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11357 This is a bit clearer, and further avoids the possibility of
11358 undesirable aliasing.
11359 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11360 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11361 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11362 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11363 (ASIZE): Now uses header.size rather than size.
11364 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11365 to avoid the hassle of writing XVECTOR (foo)->header.size.
11366 (struct vectorlike_header): New type.
eab3844f
PE
11367 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11368 object, to help avoid aliasing.
11369 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11370 (SUBRP): Likewise, since Lisp_Subr is a special case.
11371 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11372 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11373 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11374 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11375 changed to be "header.size" and "header.next".
11376 * buffer.h (struct buffer): Likewise.
11377 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11378 * frame.h (struct frame): Likewise.
11379 * process.h (struct Lisp_Process): Likewise.
11380 * termhooks.h (struct terminal): Likewise.
11381 * window.c (struct save_window_data, struct saved_window): Likewise.
11382 * window.h (struct window): Likewise.
11383 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11384 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11385 * buffer.c (init_buffer_once): Likewise.
11386 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11387 special case.
11388 * process.c (Fformat_network_address): Use local var for size,
11389 for brevity.
11390
0df1eac5
PE
11391 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11392
847ab9d1 11393 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11394 * data.c (atof): Remove decl; no longer used or needed.
11395 (digit_to_number): Move to lread.c.
11396 (Fstring_to_number): Use new string_to_number function, to be
11397 consistent with how the Lisp reader treats infinities and NaNs.
11398 Do not assume that floating-point numbers represent EMACS_INT
11399 without losing information; this is not true on most 64-bit hosts.
11400 Avoid double-rounding errors, by insisting on integers when
11401 parsing non-base-10 numbers, as the documentation specifies.
11402 * lisp.h (string_to_number): New decl, replacing ...
11403 (isfloat_string): Remove.
bc0a5c13 11404 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11405 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11406 appears to have been a coding error. Similarly, do not accept
11407 strings like +-1e0 as floating point numbers. Do not report
11408 overflow for integer overflows unless the base is not 10 which
11409 means we have no simple and reliable way to continue.
11410 Break out the floating-point parsing into a new
11411 function string_to_number, so that Fstring_to_number parses
11412 floating point numbers consistently with the Lisp reader.
04f2d78b 11413 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11414 (E_CHAR, EXP_INT): Remove, replacing with ...
11415 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11416 (string_to_number): New function, replacing isfloat_string.
11417 This function checks for valid syntax and produces the resulting
11418 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11419 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11420 so that overflow for non-base-10 numbers is reported only when
11421 there's no portable and simple way to convert to floating point.
452f4150 11422
67769ffc
PE
11423 * textprop.c (set_text_properties_1): Rewrite for clarity,
11424 and to avoid GCC warning about integer overflow.
11425
c20db43f
PE
11426 * intervals.h (struct interval): Use EMACS_INT for members
11427 where EMACS_UINT might cause problems. See
11428 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11429 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11430 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11431 All uses changed.
37aa2f85
PE
11432 (offset_intervals): Tell GCC not to worry about length overflow
11433 when negating a negative length.
c20db43f 11434
2538aa2f
PE
11435 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11436 (overrun_check_free): Likewise.
11437
f2d3008d
PE
11438 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11439 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11440 word size.
11441
ec8df744
PE
11442 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11443 (gnutls_make_error): Rename local to avoid shadowing.
11444 (gnutls_emacs_global_deinit): ifdef out; not used.
11445 (Fgnutls_boot): Use const for pointer to readonly storage.
11446 Comment out unused local. Fix pointer signedness problems.
11447
640ee02d
PE
11448 * lread.c (openp): Don't stuff size_t into an 'int'.
11449 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11450 about possible signed overflow.
11451
6048fb2a
PE
11452 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11453 (GDK_KEY_g): Don't define if already defined.
11454 (xg_prepare_tooltip): Avoid pointer signedness problem.
11455 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11456
fa3c87e1
PE
11457 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11458 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11459
2172544b
PE
11460 * xfns.c (Fx_window_property): Simplify a bit,
11461 to make a bit faster and to avoid GCC 4.6.0 warning.
11462 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11463
9b821a21
PE
11464 * fns.c (internal_equal): Don't assume size_t fits in int.
11465
3c616cfa
PE
11466 * alloc.c (compact_small_strings): Tighten assertion a little.
11467
c2982e87
PE
11468 Replace pEd with more-general pI, and fix some printf arg casts.
11469 * lisp.h (pI): New macro, generalizing old pEd macro to other
11470 conversion specifiers. For example, use "...%"pI"d..." rather
11471 than "...%"pEd"...".
11472 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11473 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11474 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11475 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11476 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11477 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11478 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11479 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11480 64-bit hosts.
11481 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11482 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11483 * print.c (safe_debug_print, print_object): Likewise.
11484 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11485 to int.
6f04d126
PE
11486 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11487 avoiding the 0 flag, which is not portable.
c2982e87
PE
11488 * process.c (Fmake_network_process): Use pI to avoid cast.
11489 * region-cache.c (pp_cache): Likewise.
11490 * xdisp.c (decode_mode_spec): Likewise.
11491 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11492 behavior on 64-bit hosts with printf arg.
6f04d126 11493 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11494 (x_stop_queuing_selection_requests): Likewise.
11495 (x_get_window_property): Don't truncate byte count to an 'int'
11496 when tracing.
0b432f21 11497
5e073ec7
PE
11498 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11499 here, since it parses constructs like leading '-' and spaces,
11500 which are not wanted; and it overflows with large numbers.
11501 Instead, simply match F[0-9]+, which is what is wanted anyway.
11502
36372bf9
PE
11503 * alloc.c: Remove unportable assumptions about struct layout.
11504 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11505 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11506 (allocate_vectorlike, make_pure_vector): Use the new macros,
11507 plus offsetof, to remove unportable assumptions about struct layout.
11508 These assumptions hold on all porting targets that I know of, but
11509 they are not guaranteed, they're easy to remove, and removing them
11510 makes further changes easier.
11511
0b432f21
PE
11512 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11513 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11514 (string_overrun_cookie): Now const. Use initializers that
11515 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11516 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11517 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11518 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11519 multiple of sizeof (EMACS_INT); it need not be, if
11520 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11521 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11522
895009e1
JB
115232011-04-26 Juanma Barranquero <lekktu@gmail.com>
11524
11525 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11526
6a7a1b0b
TZ
115272011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11528
11529 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11530 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11531 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11532
841a1577 115332011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11534
11535 * lisp.h (Qdebug): List symbol.
895009e1 11536 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11537 * keyboard.c (debug-on-event): New variable.
11538 (handle_user_signal): Break into debugger when debug-on-event
11539 matches the current signal symbol.
11540
f2d3ba6f
DN
115412011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11542
11543 * alloc.c (check_sblock, check_string_bytes)
11544 (check_string_free_list): Convert to standard C.
11545
42ce4c63
TZ
115462011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11547
11548 * w32.c (emacs_gnutls_push): Fix typo.
11549
825cd63c
EZ
115502011-04-25 Eli Zaretskii <eliz@gnu.org>
11551
fb11d64d
EZ
11552 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11553 "cast to pointer from integer of different size".
11554
825cd63c
EZ
11555 Improve doprnt and its use in verror. (Bug#8545)
11556 * doprnt.c (doprnt): Document the set of format control sequences
11557 supported by the function. Use SAFE_ALLOCA instead of always
11558 using `alloca'.
11559
11560 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11561 is one byte too soon. Don't use xrealloc; instead xfree and
11562 xmalloc anew.
11563
e061a11b
TZ
115642011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11565
11566 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11567 callbacks stage.
11568
11569 * gnutls.c: Renamed global_initialized to
11570 gnutls_global_initialized. Added internals for the
11571 :verify-hostname-error, :verify-error, and :verify-flags
11572 parameters of `gnutls-boot' and documented those parameters in the
11573 docstring. Start callback support.
9173deec
JB
11574 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11575 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11576 on error. Return error code.
e061a11b
TZ
11577 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11578 (emacs_gnutls_read): Likewise.
11579 (Fgnutls_boot): Return handshake error code.
11580 (emacs_gnutls_handle_error): New function.
11581 (wsaerror_to_errno): Likewise.
11582
11583 * w32.h (emacs_gnutls_pull): Add prototype.
11584 (emacs_gnutls_push): Likewise.
11585
11586 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11587 (emacs_gnutls_push): Likewise.
11588
115892011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11590
11591 * process.c (wait_reading_process_output): Check if GnuTLS
11592 buffered some data internally if no FDs are set for TLS
11593 connections.
11594
11595 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11596 (LIBS): Link to USER_LIBS.
11597 ($(BLD)/gnutls.$(0)): New target.
11598
fa6996bc
EZ
115992011-04-24 Eli Zaretskii <eliz@gnu.org>
11600
eb35682e
EZ
11601 * xdisp.c (handle_single_display_spec): Rename the
11602 display_replaced_before_p argument into display_replaced_p, to
11603 make it consistent with the commentary. Fix typos in the
11604 commentary.
11605
e2ad650c
EZ
11606 * textprop.c (syms_of_textprop): Remove dead code.
11607 (copy_text_properties): Delete obsolete commentary about an
11608 interface that was deleted long ago. Fix typos in the description
11609 of arguments.
11610
1b2de274
EZ
11611 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11612 to changes in oldXMenu/XMenu.h from 2011-04-16.
11613 <menu_help_message, prev_menu_help_message>: Constify.
11614 (IT_menu_make_room): menu->help_text is now `const char **';
11615 adjust.
11616
11617 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11618 to changes in oldXMenu/XMenu.h from 2011-04-16.
11619 (struct XMenu): Declare `help_text' `const char **'.
11620
11621 * xfaces.c <Qunspecified>: Make extern again.
11622
11623 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11624 required by POSIX.
1b2de274 11625
762b15be
EZ
11626 * doc.c (get_doc_string): Improve the format passed to `error'.
11627
11628 * doprnt.c (doprnt): Improve commentary.
11629
11630 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11631
11632 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11633 them with etags.
11634
f1052e5d
EZ
11635 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11636 changes in globals.h immediately force recompilation.
762b15be
EZ
11637 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11638 $(CURDIR)/s/ms-w32.h.
11639 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11640
fa6996bc
EZ
11641 * character.c (Fchar_direction): Function deleted.
11642 (syms_of_character): Don't defsubr it.
11643 <char-direction-table>: Deleted.
11644
e6c3da20
EZ
116452011-04-23 Eli Zaretskii <eliz@gnu.org>
11646
11647 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11648 * doprnt.c: Include limits.h.
11649 (SIZE_MAX): New macro.
04f2d78b
CB
11650 (doprnt): Return a size_t value. 2nd arg is now size_t.
11651 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11652 Improve overflow protection. Support `l' modifier for integer
11653 conversions. Support %l conversion. Don't assume an EMACS_INT
11654 argument for integer conversions and for %c.
11655
11656 * lisp.h (doprnt): Restore prototype.
11657
11658 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11659 $(SRC)/character.h.
11660
11661 * Makefile.in (base_obj): Add back doprnt.o.
11662
11663 * deps.mk (doprnt.o): Add back prerequisites.
11664 (callint.o): Depend on character.h.
11665
11666 * eval.c (internal_lisp_condition_case): Include the handler
11667 representation in the error message.
11668 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11669 when breaking from the loop.
11670
11671 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11672
11673 * callint.c (Fcall_interactively): When displaying error message
11674 about invalid control letter, pass the character's codepoint, not
11675 a pointer to its multibyte form. Improve display of the character
11676 in octal and display also its hex code.
11677
11678 * character.c (char_string): Use %x to display the (unsigned)
11679 codepoint of an invalid character, to avoid displaying a bogus
11680 negative value.
11681
11682 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11683 `error', not SYMBOL_NAME itself.
11684
11685 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11686 character arguments to `error'.
11687
11688 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11689 to `error' in error message about FINAL_CHAR argument. Make sure
11690 FINAL_CHAR is a character, and use %c when it is passed as
11691 argument to `error'.
11692
4ffd0d6b 116932011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11694
11695 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11696
11697 * w32.c: Include <time.h>.
11698 (sys_localtime): New function.
11699
4ffd0d6b 117002011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11701
11702 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11703
4ffd0d6b 11704 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11705
4ffd0d6b 117062011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11707
4ffd0d6b
GM
11708 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11709 zombies (Bug#8467).
aac0c6e3 11710
04c56954
EZ
117112011-04-19 Eli Zaretskii <eliz@gnu.org>
11712
11713 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11714 gl_state.e_property when gl_state.object is Qt.
11715
11716 * insdel.c (make_gap_larger): Remove limitation of buffer size
11717 to <= INT_MAX.
11718
16a43933
CY
117192011-04-18 Chong Yidong <cyd@stupidchicken.com>
11720
11721 * xdisp.c (lookup_glyphless_char_display)
11722 (produce_glyphless_glyph): Handle cons cell entry in
11723 glyphless-char-display.
11724 (Vglyphless_char_display): Document it.
11725
11726 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11727 glyphless-char-display.
11728
4581706e
CY
117292011-04-17 Chong Yidong <cyd@stupidchicken.com>
11730
11731 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11732
11733 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11734
11735 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11736 definition for no-X builds.
11737
4887c6e2 117382011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11739
fd35b6f9
PE
11740 Static checks with GCC 4.6.0 and non-default toolkits.
11741
5c1ccb01
PE
11742 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11743
006c5daa
PE
11744 * process.c (keyboard_bit_set): Define only if SIGIO.
11745 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11746 (send_process): Repair possible setjmp clobbering.
11747
efc736d3
PE
11748 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11749
4e2fe2e6
PE
11750 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11751
f97334a2
PE
11752 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11753
4e75f29d
PE
11754 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11755 Define only if needed.
11756
90efadd1
PE
11757 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11758 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11759 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11760
3c647824
PE
11761 * dispextern.h (struct redisplay_interface): Rename param
11762 to avoid shadowing.
e264f262 11763 * termhooks.h (struct terminal): Likewise.
761383f4 11764 * xterm.c (xembed_send_message): Likewise.
3c647824 11765
b58c5c4a
PE
11766 * insdel.c (make_gap_smaller): Define only if
11767 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11768
cad59032
PE
11769 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11770 it.
11771
c339dc2e
PE
11772 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11773 so that we aren't warned about unused symbols.
11774
91a3e27b
PE
11775 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11776
399c71d3 11777 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11778
8ffc96f5
PE
11779 * xfns.c (x_real_positions): Mark locals as initialized.
11780
eef9bc79
PE
11781 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11782
098db9dd
PE
11783 * xterm.c: Fix problems found by static analysis with other toolkits.
11784 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11785 (x_dispatch_event): Declare static if USE_GTK, and
11786 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11787 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11788 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11789 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11790 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11791
eb18f6cc
PE
11792 * xmenu.c (menu_help_callback): Pointer type fixes.
11793 Use const pointers when pointing at readonly data. Avoid pointer
11794 signedness clashes.
11795 (FALSE): Remove unused macro.
11796 (update_frame_menubar): Remove unused decl.
11797
1fe72bf8
PE
11798 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11799
60d9e1db
PE
11800 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11801 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11802 (single_menu_item): Rename local to avoid shadowing.
11803
39261c26
PE
11804 * keyboard.c (make_lispy_event): Remove unused local var.
11805
018c5e19
PE
11806 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11807 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11808
63d2b86e
PE
11809 * bitmaps: Change bitmaps from unsigned char back to the X11
11810 compatible char. Avoid the old compiler warnings about
11811 out-of-range initializers by using, for example, '\xab' rather
11812 than 0xab.
11813
aefd87e1
PE
11814 * xgselect.c (xgselect_initialize): Check vs interface
11815 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11816
bf501fb9
PE
11817 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11818
e9829fdf
PE
11819 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11820 to read-only memory.
11821
1086c095
PE
11822 * fns.c (vector): Remove; this old hack is no longer needed.
11823
2baccd04 11824 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11825 Remove unused var.
dde42981 11826 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11827
72391843 11828 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11829
436c16df 11830 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11831 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11832 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11833
92bb796d 11834 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11835 (x_term_init): Remove local to avoid shadowing.
92bb796d 11836
764430a3 11837 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11838
11839 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11840 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11841
d1dfb56c
EZ
118422011-04-16 Eli Zaretskii <eliz@gnu.org>
11843
c4354cb4
EZ
11844 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11845
d1dfb56c
EZ
11846 Fix regex.c, syntax.c and friends for buffers > 2GB.
11847 * syntax.h (struct gl_state_s): Declare character position members
11848 EMACS_INT.
11849
11850 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11851
04f2d78b
CB
11852 * textprop.c (verify_interval_modification, interval_of):
11853 Declare arguments EMACS_INT.
d1dfb56c
EZ
11854
11855 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11856 EMACS_INT.
11857
11858 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11859
11860 * indent.c (Fvertical_motion): Local variable it_start is now
11861 EMACS_INT.
11862
11863 * regex.c (re_match, re_match_2, re_match_2_internal)
11864 (bcmp_translate, regcomp, regexec, print_double_string)
11865 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11866 (re_compile_pattern, re_exec): Declare arguments and local
11867 variables `size_t' and `ssize_t' and return values `regoff_t', as
11868 appropriate.
11869 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11870 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11871 <compile_stack_type>: `size' and `avail' are now `size_t'.
11872
11873 * regex.h <regoff_t>: Use ssize_t, not int.
11874 (re_search, re_search_2, re_match, re_match_2): Arguments that
11875 specify buffer/string position and length are now ssize_t and
11876 size_t. Return type is regoff_t.
11877
613052cd
BK
118782011-04-16 Ben Key <bkey76@gmail.com>
11879
11880 * nsfont.m: Fixed bugs in ns_get_family and
11881 ns_descriptor_to_entity that were caused by using free to
11882 deallocate memory blocks that were allocated by xmalloc (via
11883 xstrdup). This caused Emacs to crash when compiled with
11884 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11885 --enable-checking=xmallocoverrun). xfree is now used to
11886 deallocate these memory blocks.
11887
4170f62f 118882011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11889
71b41406
PE
11890 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11891
9587a89d
PE
11892 emacs_write: Accept and return EMACS_INT for sizes.
11893 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11894 et seq.
11895 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11896 Accept and return EMACS_INT.
11897 (emacs_gnutls_write): Return the number of bytes written on
11898 partial writes.
11899 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11900 (emacs_read, emacs_write): Remove check for negative size, as the
11901 Emacs source code has been audited now.
9587a89d
PE
11902 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11903 (emacs_read, emacs_write): Use it.
273a5f82
PE
11904 * process.c (send_process): Adjust to the new signatures of
11905 emacs_write and emacs_gnutls_write. Do not attempt to store
11906 a byte offset into an 'int'; it might overflow.
9587a89d 11907 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11908
3e047f51
PE
11909 * sound.c: Don't assume sizes fit in 'int'.
11910 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11911 Return EMACS_INT, not int.
3e047f51 11912 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11913 Accept EMACS_INT, not int.
11914 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11915 record read return values.
11916
cc39a9db
BK
119172011-04-15 Ben Key <bkey76@gmail.com>
11918
c9d0ec6d
JB
11919 * keyboard.c (Qundefined): Don't declare static since it is used
11920 in nsfns.m.
11921 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11922 static since they are used in nsfont.m.
cc39a9db 11923
6c60eb9f
SM
119242011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11925
11926 * process.c (Qprocessp): Don't declare static.
11927 * lisp.h (Qprocessp): Declare again.
11928
7990b61a
JB
119292011-04-15 Juanma Barranquero <lekktu@gmail.com>
11930
11931 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11932
5d4cb038
PE
119332011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11934
8bd7b830 11935 Improve C-level modularity by making more things 'static'.
cd64ea1d 11936
e3b27b31
PE
11937 Don't publish debugger-only interfaces to other modules.
11938 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11939 (verify_bytepos, count_markers): Move decls to the only modules
11940 that need them.
11941 * region-cache.h (pp_cache): Likewise.
11942 * window.h (check_all_windows): Likewise.
11943 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11944
5d4cb038
PE
11945 * sysdep.c (croak): Now static, if
11946 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11947 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11948
11949 * alloc.c (refill_memory_reserve): Now static if
11950 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11951 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11952
e87b6180
PE
11953 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11954 Define only if USE_LUCID.
11955
ac64929e
PE
11956 * xrdb.c (x_customization_string, x_rm_string): Now static.
11957
6f37259d
PE
11958 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11959 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11960
1683e3ab
PE
11961 * xdisp.c (draw_row_with_mouse_face): Now static.
11962 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11963
de9c2632
PE
11964 * window.h (check_all_windows): Mark externally visible.
11965
2b96acb7
PE
11966 * window.c (window_deletion_count): Now static.
11967
11968 * undo.c: Make symbols static if they're not exported.
11969 (last_undo_buffer, last_boundary_position, pending_boundary):
11970 Now static.
11971
50436f33
PE
11972 * textprop.c (interval_insert_behind_hooks): Now static.
11973 (interval_insert_in_front_hooks): Likewise.
11974
64520e5c
PE
11975 * term.c: Make symbols static if they're not exported.
11976 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11977 (max_frame_lines, tty_set_terminal_modes):
11978 (tty_reset_terminal_modes, tty_turn_off_highlight):
11979 (get_tty_terminal): Now static.
11980 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11981 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11982 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11983 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11984 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11985
1fa53021
PE
11986 * sysdep.c: Make symbols static if they're not exported.
11987 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11988 Now static.
11989 (sigprocmask_set, full_mask): Remove; unused.
11990 (wait_debugging): Mark as visible.
11991 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11992 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11993
d4b43b22
PE
11994 * syntax.c (syntax_temp): Define only if !__GNUC__.
11995
b7c513d0
PE
11996 * sound.c (current_sound_device, current_sound): Now static.
11997
989b29ad
PE
11998 * search.c (searchbufs, searchbuf_head): Now static.
11999
13a55a78
PE
12000 * scroll.c (scroll_cost): Remove; unused.
12001 * dispextern.h (scroll_cost): Remove decl.
12002
de68a1fc
PE
12003 * region-cache.h (pp_cache): Mark as externally visible.
12004
40ccffa6
PE
12005 * process.c: Make symbols static if they're not exported.
12006 (process_tick, update_tick, create_process, chan_process):
12007 (Vprocess_alist, proc_buffered_char, datagram_access):
12008 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12009 (deactivate_process): Mark defn as static, as well as decl.
12010 * lisp.h (create_process): Remove decl.
12011 * process.h (chan_process, Vprocess_alist): Remove decls.
12012
ad64fc97
PE
12013 * print.c: Make symbols static if they're not exported.
12014 (print_depth, new_backquote_output, being_printed, print_buffer):
12015 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12016 (print_interval, print_number_index, initial_stderr_stream):
12017 Now static.
12018 * lisp.h (Fprinc): Remove decl.
12019 (debug_output_compilation_hack): Mark as externally visible.
12020
adddb265
PE
12021 * sysdep.c (croak): Move decl from here to syssignal.h.
12022 * syssignal.h (croak): Put it here, so the API can be checked when
12023 'croak' is called from dissociate_if_controlling_tty.
12024
1717ede2
PE
12025 * minibuf.c: Make symbols static if they're not exported.
12026 (minibuf_save_list, choose_minibuf_frame): Now static.
12027 * lisp.h (choose_minibuf_frame): Remove decl.
12028
fa5fb2bc
PE
12029 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12030
1e3890d1
PE
12031 * lread.c: Make symbols static if they're not exported.
12032 (read_objects, initial_obarray, oblookup_last_bucket_number):
12033 Now static.
12034 (make_symbol): Remove; unused.
12035 * lisp.h (initial_obarray, make_symbol): Remove decls.
12036
8a1414fa
PE
12037 * keyboard.c: Make symbols static if they're not exported.
12038 (single_kboard, recent_keys_index, total_keys, recent_keys):
12039 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12040 (this_single_command_key_start, echoing, last_auto_save):
12041 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12042 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12043 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12044 (Vlispy_mouse_stem, double_click_count):
12045 Now static.
12046 (force_auto_save_soon): Define only if SIGDANGER.
12047 (ignore_mouse_drag_p): Now static if
12048 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12049 (print_help): Remove; unused.
12050 (stop_character, last_timer_event): Mark as externally visible.
12051 * keyboard.h (ignore_mouse_drag_p): Declare only if
12052 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12053 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12054 * lisp.h (echoing): Remove decl.
12055 (force_auto_save_soon): Declare only if SIGDANGER.
12056 * xdisp.c (redisplay_window): Simplify code, to make it more
12057 obvious that ignore_mouse_drag_p is not accessed if !defined
12058 USE_GTK && !defined HAVE_NS.
12059
93ea6e8f
PE
12060 * intervals.c: Make symbols static if they're not exported.
12061 (merge_properties_sticky, merge_interval_right, delete_interval):
12062 Now static.
12063 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12064
77382fcc
PE
12065 * insdel.c: Make symbols static if they're not exported.
12066 However, leave prepare_to_modify_buffer alone. It's never
12067 called from outside this function, but that appears to be a bug.
12068 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12069 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12070 (adjust_after_replace_noundo): Remove; unused.
12071 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12072 (signal_before_change): Remove decls.
77382fcc 12073
9306c32e
PE
12074 * indent.c (val_compute_motion, val_vmotion): Now static.
12075
cd44d2eb
PE
12076 * image.c: Make symbols static if they're not exported.
12077 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12078 if USE_GTK.
12079 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12080 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12081
ad9a7a06
PE
12082 * fringe.c (standard_bitmaps): Now static.
12083 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12084
81626931
PE
12085 * frame.c: Make symbols static if they're not exported.
12086 (x_report_frame_params, make_terminal_frame): Now static.
12087 (get_frame_param): Now static, unless HAVE_NS.
12088 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12089 (x_get_resource_string): Remove; not used.
12090 * frame.h (make_terminal_frame, x_report_frame_params):
12091 (x_get_resource_string); Remove decls.
12092 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12093 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12094
239f9db9
PE
12095 * font.c, fontset.c: Make symbols static if they're not exported.
12096 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12097 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12098 * font.c (font_close_object): Now static.
12099 * font.h (font_close_object): Remove.
12100 * fontset.c (FONTSET_OBJLIST): Remove.
12101 (free_realized_fontset) #if-0 the body, which does nothing.
12102 (face_suitable_for_char_p): #if-0, as it's never called.
12103 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12104 * xfaces.c (face_at_string_position):
12105 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12106 since 0 is always ASCII.
12107
dfcf3579
PE
12108 * fns.c (weak_hash_tables): Now static.
12109
5045092b
PE
12110 * fileio.c: Make symbols static if they're not exported.
12111 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12112 (Vwrite_region_annotation_buffers): Now static.
12113
57a96f5c
PE
12114 * eval.c: Make symbols static if they're not exported.
12115 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12116 * lisp.h (backtrace_list): Remove decl.
12117
35f08c38
PE
12118 * emacs.c: Make symbols static if they're not exported.
12119 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12120 (fatal_error_code, fatal_error_signal_hook, standard_args):
12121 Now static.
12122 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12123 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12124 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12125 * lisp.h (fatal_error_signal_hook): Remove decl.
12126 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12127
f44bd759
PE
12128 * editfns.c: Move a (normally-unused) function to its only use.
12129 * editfns.c, lisp.h (get_operating_system_release): Remove.
12130 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12131 worth the hassle of breaking this out.
12132
b532497d
PE
12133 * xterm.c: Make symbols static if they're not exported.
12134 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12135 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12136 (x_destroy_window, x_delete_display):
12137 Now static.
12138 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12139 (x_mouse_leave): Remove; unused.
12140 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12141 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12142 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12143 Remove decls.
12144 (x_mouse_leave): Declare only if WINDOWSNT.
12145 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12146 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12147 USE_X_TOOLKIT.
12148
1675728f
PE
12149 * ftxfont.c: Make symbols static if they're not exported.
12150 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12151 HAVE_FREETYPE.
12152 * font.h (ftxfont_driver): Likewise.
12153
e4cebfca
PE
12154 * xfns.c: Make symbols static if they're not exported.
12155 (x_last_font_name, x_display_info_for_name):
12156 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12157 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12158 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12159 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12160 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12161 (last_show_tip_args): Now static.
12162 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12163 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12164 (x_screen_planes): Remove; unused.
12165 * dispextern.h (x_screen_planes): Remove decl.
12166
5bf46f05
PE
12167 * dispnew.c: Make symbols static if they're not exported.
12168 * dispextern.h (redraw_garbaged_frames, scrolling):
12169 (increment_row_positions): Remove.
12170 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12171 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12172 Now static.
12173 (redraw_garbaged_frames): Remove; unused.
12174
435f4c28
PE
12175 * xfaces.c: Make symbols static if they're not exported.
12176 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12177 Remove decls.
12178 * xterm.h (defined_color): Remove decls.
12179 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12180 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12181 (menu_face_changed_default, defined_color, free_realized_face):
12182 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12183 (ascii_face_of_lisp_face): Remove; unused.
12184
8524aef3
PE
12185 * xdisp.c: Make symbols static if they're not exported.
12186 * dispextern.h (scratch_glyph_row, window_box_edges):
12187 (glyph_to_pixel_coords, set_cursor_from_row):
12188 (get_next_display_element, set_iterator_to_next):
12189 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12190 (show_mouse_face): Remove decls
12191 * frame.h (message_buf_print): Likewise.
12192 * lisp.h (pop_message, set_message, check_point_in_composition):
12193 Likewise.
12194 * xterm.h (set_vertical_scroll_bar): Likewise.
12195 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12196 (message_buf_print, scratch_glyph_row, displayed_buffer):
12197 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12198 (get_next_display_element, show_mouse_face, window_box_edges):
12199 (frame_to_window_pixel_xy, check_point_in_composition):
12200 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12201 (glyph_to_pixel_coords): Remove; unused.
12202
16390cd2
PE
12203 * dired.c (file_name_completion): Now static.
12204
12205 * dbusbind.c (xd_in_read_queued_messages): Now static.
12206
a25f4dfa
PE
12207 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12208 * data.c (circular_list_error): Remove.
12209
14a9c8df
PE
12210 * commands.h (last_point_position, last_point_position_buffer):
12211 (last_point_position_window): Remove decls.
12212 * keyboard.c: Make these variables static.
12213
04f2d78b
CB
12214 * coding.h (coding, code_convert_region, encode_coding_gap):
12215 Remove decls.
74ab6df5
PE
12216 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12217 (iso_code_class, detect_coding, code_convert_region): Now static.
12218 (encode_coding_gap): Remove; unused.
12219
38dfbee1
PE
12220 * chartab.c (chartab_chars, chartab_bits): Now static.
12221
a2cb4e63
PE
12222 * charset.h (charset_iso_8859_1): Remove decl.
12223 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12224 Now static.
12225
127198fd
PE
12226 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12227 * ccl.c (Vccl_program_table): Now static.
12228 (check_ccl_update): Remove; unused.
12229
d85b608f
PE
12230 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12231 * category.h: ... from here.
12232 * category.c (check_category_table, set_category_set): Now static.
12233
31cd66f3
PE
12234 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12235 * lisp.h: Remove these decls.
12236
c358e587
PE
12237 * buffer.c (buffer_count): Remove unused var.
12238
e78aecca
PE
12239 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12240 so that it's not optimized away.
12241 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12242 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12243 exported only to the debugger.
12244
e192d7d3 12245 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12246 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12247
92470028
PE
12248 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12249 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12250 was inaccessible from Lisp.
12251 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12252 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12253
244ed907
PE
12254 alloc.c: Import and export fewer symbols, and remove unused items.
12255 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12256 is defined.
12257 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12258 it's not optimized away by whole-program optimization.
12259 (message_enable_multibyte, free_misc): Remove.
12260 (catchlist, handlerlist, mark_backtrace):
12261 Declare only if BYTE_MARK_STACK.
12262 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12263 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12264 (message_enable_multibyte): Remove decl.
12265 (free_misc, interval_free_list, float_block, float_block_index):
12266 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12267 (cons_free_list, last_marked_index):
12268 Now static.
12269 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12270 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12271 (mark_backtrace): Define only if BYTE_MARK_STACK.
12272 * xdisp.c (message_enable_multibyte): Now static.
12273
61c2b50e 12274 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12275 This makes it easier for human readers (and static analyzers)
12276 to see whether these variables are used from other modules.
12277 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12278 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12279 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12280 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12281 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12282 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12283 * xmenu.c, xselect.c:
12284 Declare Q* vars static if they are not used in other modules.
12285 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12286 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12287 Remove decls of unexported vars.
12288 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12289
95c82688
PE
12290 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12291
16a97296
PE
12292 Make Emacs functions such as Fatom 'static' by default.
12293 This makes it easier for human readers (and static analyzers)
12294 to see whether these functions can be called from other modules.
12295 DEFUN now defines a static function. To make the function external
12296 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12297 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12298 (Finit_image_library):
16a97296
PE
12299 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12300 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12301 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12302 Remove decls, since these functions are now static.
12303 (Funintern, Fget_internal_run_time): New decls, since these functions
12304 were already external.
95c82688 12305
16a97296
PE
12306 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12307 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12308 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12309 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12310 * keyboard.c, keymap.c, lread.c:
12311 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12312 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12313 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12314 Mark functions with DEFUE instead of DEFUN,
12315 if they are used in other modules.
12316 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12317 decls for now-static functions.
12318 * buffer.h (Fdelete_overlay): Remove decl.
12319 * callproc.c (Fgetenv_internal): Mark as internal.
12320 * composite.c (Fremove_list_of_text_properties): Remove decl.
12321 (Fcomposition_get_gstring): New forward static decl.
12322 * composite.h (Fcomposite_get_gstring): Remove decl.
12323 * dired.c (Ffile_attributes): New forward static decl.
12324 * doc.c (Fdocumntation_property): New forward static decl.
12325 * eval.c (Ffetch_bytecode): New forward static decl.
12326 (Funintern): Remove extern decl; now in .h file where it belongs.
12327 * fileio.c (Fmake_symbolic_link): New forward static decl.
12328 * image.c (Finit_image_library): New forward static decl.
12329 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12330 * intervals.h (Fprevious_property_change):
12331 (Fremove_list_of_text_properties): Remove decls.
12332 * keyboard.c (Fthis_command_keys): Remove decl.
12333 (Fcommand_execute): New forward static decl.
12334 * keymap.c (Flookup_key): New forward static decl.
12335 (Fcopy_keymap): Now static.
12336 * keymap.h (Flookup_key): Remove decl.
12337 * process.c (Fget_process): New forward static decl.
12338 (Fprocess_datagram_address): Mark as internal.
12339 * syntax.c (Fsyntax_table_p): New forward static decl.
12340 (skip_chars): Remove duplicate decl.
12341 * textprop.c (Fprevious_property_change): New forward static decl.
12342 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12343 Now internal.
12344 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12345 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12346
785bbd42
PE
12347 * editfns.c (Fformat): Remove unreachable code.
12348
8b913b57
AS
123492011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12350
12351 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12352 change. (Bug#8496)
12353
a6744a35
EZ
123542011-04-13 Eli Zaretskii <eliz@gnu.org>
12355
12356 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12357 when at ZV. (Bug#8487)
12358
e7974947
AS
123592011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12360
baad03f0
AS
12361 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12362 (Bug#8437)
12363 * keyboard.c (parse_tool_bar_item): Likewise.
12364 * sound.c (sound_cleanup, alsa_close): Likewise.
12365 * termcap.c (tgetent): Likewise.
12366 * xfns.c (x_default_font_parameter): Likewise.
12367 * xsettings.c (read_and_apply_settings): Likewise.
12368
e7974947
AS
12369 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12370 (overrun_check_free): Protoize.
12371
28272684
PE
123722011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12373
12374 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12375 since callers should never pass a negative size.
12376 Change the signature to match that of plain 'read' and 'write'; see
12377 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12378 * lisp.h: Update prototypes of emacs_write and emacs_read.
12379
11997c76
EZ
123802011-04-11 Eli Zaretskii <eliz@gnu.org>
12381
12382 * xdisp.c (redisplay_window): Don't try to determine the character
12383 position of the scroll margin if the window start point w->startp
e896f03c 12384 is outside the buffer's accessible region. (Bug#8468)
11997c76 12385
8a2cbd72
EZ
123862011-04-10 Eli Zaretskii <eliz@gnu.org>
12387
12388 Fix write-region and its subroutines for buffers > 2GB.
12389 * fileio.c (a_write, e_write): Modify declaration of arguments and
12390 local variables to support buffers larger than 2GB.
12391 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12392
12393 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12394 argument, local variables, and return value.
12395
12396 * lisp.h: Update prototypes of emacs_write and emacs_read.
12397
12398 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12399
4073e537 124002011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12401
1ebfdcb6
PE
12402 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12403
b2ded58d
PE
12404 Fix more problems found by GCC 4.6.0's static checks.
12405
7d66342c
PE
12406 * xdisp.c (vmessage): Use a better test for character truncation.
12407
bbf47d44
PE
12408 * charset.c (load_charset_map): <, not <=, for optimization,
12409 and to avoid potential problems with integer overflow.
9248994d 12410 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12411 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12412 * editfns.c (Fformat): Likewise.
1e69125e 12413 * syntax.c (skip_chars): Likewise.
3befa583 12414
e3019616
PE
12415 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12416 This also lets GCC 4.6.0 generate slightly better loop code.
12417
becfa255
PE
12418 * callint.c (Fcall_interactively): <, not <=, for optimization.
12419 (Fcall_interactively): Count the number of arguments produced,
12420 not the number of arguments given. This is simpler and lets GCC
12421 4.6.0 generate slightly better code.
12422
dae0cd48
PE
12423 * ftfont.c: Distingish more carefully between FcChar8 and char.
12424 The previous code passed unsigned char * to a functions like
12425 strlen and xstrcasecmp that expect char *, which does not
12426 conform to the C standard.
12427 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12428 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12429 char * when the C standard requires it.
12430
76032d70
PE
12431 * keyboard.c (read_char): Remove unused var.
12432
eb3f1cc8
PE
12433 * eval.c: Port to Windows vsnprintf (Bug#8435).
12434 Include <limits.h>.
12435 (SIZE_MAX): Define if the headers do not.
12436 (verror): Do not give up if vsnprintf returns a negative count.
12437 Instead, grow the buffer. This ports to Windows vsnprintf, which
12438 does not conform to C99. Problem reported by Eli Zaretskii.
12439 Also, simplify the allocation scheme, by avoiding the need for
12440 calling realloc, and removing the ALLOCATED variable.
12441
70476b54
PE
12442 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12443
12020a9e
PE
12444 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12445 But keep the doprint source code for now, as we might revamp it
12446 and use it again (Bug#8435).
ea6c7ae6
PE
12447 * lisp.h (doprnt): Remove.
12448 * Makefile.in (base_obj): Remove doprnt.o.
12449 * deps.mk (doprnt.o): Remove.
12450
5fdb398c
PE
12451 error: Print 32- and 64-bit integers portably (Bug#8435).
12452 Without this change, on typical 64-bit hosts error ("...%d...", N)
12453 was used to print both 32- and 64-bit integers N, which relied on
12454 undefined behavior.
61bdb816 12455 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12456 * lisp.h (error, verror): Mark as printf-like functions.
12457 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12458 Report overflow in size calculations when allocating printf buffer.
12459 Do not truncate output string at its first null byte.
12460 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12461 Truncate the output at a character boundary, since vsnprintf does not
12462 do that.
12463 * charset.c (check_iso_charset_parameter): Convert internal
12464 character to string before calling 'error', since %c now has the
12465 printf meaning.
12466 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12467 overflow when computing char to be passed to 'error'. Do not
12468 pass Lisp_Object to 'error'; pass the integer instead.
12469 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12470 formatted with plain %d.
12471
b189fa66
PE
12472 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12473
bff87ef0
PE
12474 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12475
7e2cac20
PE
12476 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12477
ce4d90b5
PE
12478 * xterm.c (x_catch_errors): Remove duplicate declaration.
12479
266c9547
PE
12480 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12481
79c49ad2
PE
12482 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12483
368f4090
JM
124842011-04-10 Jim Meyering <meyering@redhat.com>
12485
12486 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12487 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12488 return ssize_t not "int", and use size_t as the buffer length.
12489 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12490 * gnutls.h: Update declarations.
12491 * process.c (read_process_output): Use ssize_t, to match.
12492 (send_process): Likewise.
12493
a32d4040
CY
124942011-04-09 Chong Yidong <cyd@stupidchicken.com>
12495
12496 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12497
8546720e 124982011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12499
04f2d78b
CB
12500 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12501 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12502
8546720e
GM
12503 * xterm.c (handle_one_xevent):
12504 * xmenu.c (create_and_show_popup_menu):
12505 * xselect.c (x_decline_selection_request)
12506 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12507
0a2f5c1a 125082011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12509
12510 Fix some uses of `int' instead of EMACS_INT.
12511 * search.c (string_match_1, fast_string_match)
12512 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12513 (scan_buffer, find_next_newline_no_quit)
12514 (find_before_next_newline, search_command, Freplace_match)
12515 (Fmatch_data): Make some `int' variables be EMACS_INT.
12516
12517 * xdisp.c (display_count_lines): 3rd argument and return value now
12518 EMACS_INT. All callers changed.
12519 (pint2hrstr): Last argument is now EMACS_INT.
12520
12521 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12522 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12523 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12524 (decode_coding_utf_16, decode_coding_emacs_mule)
12525 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12526 (decode_coding_ccl, decode_coding_charset)
12527 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12528 (decode_coding_iso_2022, decode_coding_emacs_mule)
12529 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12530 <char_offset, last_offset>: Declare EMACS_INT.
12531 (encode_coding_utf_8, encode_coding_utf_16)
12532 (encode_coding_emacs_mule, encode_invocation_designation)
12533 (encode_designation_at_bol, encode_coding_iso_2022)
12534 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12535 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12536 Declare EMACS_INT.
12537 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12538 (encode_invocation_designation): Last argument P_NCHARS is now
12539 EMACS_INT.
12540 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12541 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12542
12543 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12544 All users changed.
12545
12546 * ccl.c (Fccl_execute_on_string): Declare some variables
12547 EMACS_INT.
12548
8546720e 125492011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12550
12551 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12552
4e19a977
CS
125532011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12554
12555 * process.c (Fformat_network_address): Doc fix.
12556
87302331
R
125572011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12558
ee7683eb 12559 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12560
cbb59342
CY
125612011-04-08 Chong Yidong <cyd@stupidchicken.com>
12562
12563 * keyboard.c (read_char): Call Lisp function help-form-show,
12564 instead of using internal_with_output_to_temp_buffer.
12565 (Qhelp_form_show): New var.
e0d38eeb 12566 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12567
12568 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12569
12570 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12571
e67a13ab
CY
125722011-04-06 Chong Yidong <cyd@stupidchicken.com>
12573
04f2d78b
CB
12574 * process.c (Flist_processes): Remove to Lisp.
12575 (list_processes_1): Delete.
e67a13ab 12576
973f782d
EZ
125772011-04-06 Eli Zaretskii <eliz@gnu.org>
12578
7c106b1e
EZ
12579 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12580
973f782d
EZ
12581 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12582
41cf7d1a 125832011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12584
ca23cc88
PE
12585 Fix more problems found by GCC 4.6.0's static checks.
12586
f390e2d5
PE
12587 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12588
42eea0d0
PE
12589 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12590
b69769da 12591 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12592
f9541e84
PE
12593 * xdisp.c (vmessage): Mark as a printf-like function.
12594
13841b55
PE
12595 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12596
c136c10f
PE
12597 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12598
5e2d4a30
PE
12599 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12600 printf-like functions.
12601 (tiff_load): Add casts to remove these marks before passing them
12602 to system-supplied API.
12603
583f48b9
PE
12604 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12605
b25d760e
PE
12606 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12607 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12608 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12609 directly, rather than having caller test rule sign. This avoids
12610 some unnecessary tests.
12611 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12612 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12613 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12614
bc7b6697 12615 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12616 (xfont_open): Avoid unnecessary tests.
bc7b6697 12617
27ccc379
PE
12618 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12619
dcd5c89a
PE
12620 * composite.h, composite.c (composition_gstring_put_cache):
12621 Use EMACS_INT, not int, for length.
12622
b13a45c6
PE
12623 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12624 breaking out part of COMPOSITION_DECODE_RULE.
12625 (COMPOSITION_DECODE_RULE): Use it.
12626 * composite.c (get_composition_id): Remove unused local vars,
12627 by using the new macro.
12628
1e792e4d
PE
12629 * textprop.c (set_text_properties_1): Change while to do-while,
12630 since the condition is always true at first.
12631
dc6c6455 12632 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12633 (interval_deletion_adjustment): Return unsigned value.
12634 All uses changed.
dc6c6455 12635
aba7731a
PE
12636 * process.c (list_processes_1, create_pty, read_process_output):
12637 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12638 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12639 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12640 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12641 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12642
fdfc4bf3
PE
12643 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12644
fca8fe46 12645 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12646 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12647
06a0259a 12648 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12649 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12650 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12651
e7b9e80f
PE
12652 * print.c (print_error_message): Avoid int overflow.
12653
56201685
PE
12654 * font.c (font_list_entities): Redo for clarity,
12655 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12656
78834453 12657 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12658 (font_score): Avoid potential overflow in diff calculation.
78834453 12659
0bc0b309 12660 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12661 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12662
e610eaca
PE
12663 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12664
b895abce
PE
12665 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12666 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12667 can always succeed if overflow has undefined behavior.
12668
1f1d9321 12669 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12670 (wordify): Omit three unnecessary tests.
1f1d9321 12671
c59478bc
PE
12672 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12673 All callers changed. This avoids the need for an unused var.
12674
79b73827
PE
12675 * casefiddle.c (casify_region): Remove var that is set but not used.
12676
a4db5dfe
PE
12677 * dired.c (file_name_completion): Remove var that is set but not used.
12678
43aae36e
PE
12679 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12680
2a47c44d 12681 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12682 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12683
a37c69bf
PE
12684 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12685 Check for integer overflow on size calculations.
12686
328ab8e7
PE
12687 * buffer.c (Fprevious_overlay_change): Remove var that is set
12688 but not used.
12689
e5a2a5cb
PE
12690 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12691 Remove vars that are set but not used.
8d84a6eb 12692 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12693 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12694
a60e5f68
PE
12695 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12696
f661cb61 12697 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12698 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12699
f0397f5a
PE
12700 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12701 that are set but not used.
12702
8664db06 12703 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12704 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12705
6abdaa4a
PE
12706 * xselect.c (x_get_local_selection, x_handle_property_notify):
12707 Remove vars that are set but not used.
12708
0ce7538d 12709 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12710 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12711
9ae848fc
PE
12712 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12713 Remove var that is set but not used.
0b918413
PE
12714 (scroll_bar_windows_size): Now size_t, not int.
12715 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12716 Check for overflow.
9ae848fc 12717
a5a62657
PE
12718 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12719 (map_tty_color) [!defined MSDOS]: Likewise.
12720
5c5cdd39
PE
12721 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12722
66ebf983
PE
12723 * coding.c: Remove vars that are set but not used.
12724 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12725 All callers changed.
12726 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12727 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12728 (decode_coding_charset): Remove vars that are set but not used.
12729
1be4d761
PE
12730 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12731 that is set but not used.
12732
47553fa8
PE
12733 * print.c (print_object): Remove var that is set but not used.
12734
1f7196bf 12735 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12736 The gnulib version avoids calling malloc in the usual case,
12737 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12738 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12739 * filelock.c (current_lock_owner): Likewise.
12740 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12741 * sysdep.c: Include allocator.h, careadlinkat.h.
12742 (emacs_no_realloc_allocator): New static constant.
12743 (emacs_readlink): New function.
fdb61804
PE
12744 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12745 ../lib/careadlinkat.h.
d1fdcab7 12746
f84c17c7
SM
127472011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12748
12749 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12750 first non-nil return value).
12751
ef3862ad
JD
127522011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12753
12754 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12755 if not defined (Bug#8403).
12756
376a7006
JB
127572011-04-02 Juanma Barranquero <lekktu@gmail.com>
12758
12759 * xdisp.c (display_count_lines): Remove parameter `start',
12760 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12761 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12762 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12763 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12764 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12765 and thereabouts. All callers changed.
12766 (get_per_char_metric): Remove parameter `f', unused since
12767 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12768
6ca3801d
JM
127692011-04-02 Jim Meyering <meyering@redhat.com>
12770
12771 do not dereference NULL upon failed strdup
12772 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12773 (ns_get_family): Likewise.
12774
d8e2b5ba
JB
127752011-04-02 Juanma Barranquero <lekktu@gmail.com>
12776
12777 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12778
8c74fcbd
JD
127792011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12780
12781 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12782 later (Bug#8403).
12783
7200d79c
SM
127842011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12785
03408648 12786 Add lexical binding.
7200d79c 12787
03408648
SM
12788 * window.c (Ftemp_output_buffer_show): New fun.
12789 (Fsave_window_excursion):
12790 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12791
12792 * lread.c (lisp_file_lexically_bound_p): New function.
12793 (Fload): Bind Qlexical_binding.
12794 (readevalloop): Remove `evalfun' arg.
12795 Bind Qinternal_interpreter_environment.
12796 (Feval_buffer): Bind Qlexical_binding.
12797 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12798 Mark as dynamic.
12799 (syms_of_lread): Declare `lexical-binding'.
12800
12801 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12802
12803 * keyboard.c (eval_dyn): New fun.
12804 (menu_item_eval_property): Use it.
ca105506
SM
12805
12806 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12807
03408648
SM
12808 * fns.c (concat, mapcar1): Accept byte-code-functions.
12809
12810 * eval.c (Fsetq): Handle lexical vars.
12811 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12812 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12813 (FletX, Flet): Obey lexical binding.
12814 (Fcommandp): Handle closures.
12815 (Feval): New `lexical' arg.
12816 (eval_sub): New function extracted from Feval. Use it almost
12817 everywhere where Feval was used. Look up vars in lexical env.
12818 Handle closures.
12819 (Ffunctionp): Move from subr.el.
12820 (Ffuncall): Handle closures.
12821 (apply_lambda): Remove `eval_flags'.
12822 (funcall_lambda): Handle closures and new byte-code-functions.
12823 (Fspecial_variable_p): New function.
12824 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12825 but without exporting it to Lisp.
23aba0ea 12826
23aba0ea 12827 * doc.c (Fdocumentation, store_function_docstring):
03408648 12828 * data.c (Finteractive_form): Handle closures.
23aba0ea 12829
03408648
SM
12830 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12831 interactive spec.
ba83908c 12832
04f2d78b
CB
12833 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12834 New byte-codes.
03408648
SM
12835 (exec_byte_code): New function extracted from Fbyte_code to handle new
12836 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12837
03408648 12838 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12839
03408648 12840 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12841
e2abce01
JB
128422011-03-31 Juanma Barranquero <lekktu@gmail.com>
12843
12844 * xdisp.c (redisplay_internal): Fix prototype.
12845
63696a73 128462011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12847
63696a73 12848 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12849 (try_scrolling): Use it when setting scroll_limit.
12850 Limit scrolling to 100 screen lines.
63696a73
EZ
12851 (redisplay_window): Even when falling back on "recentering",
12852 position point in the window according to scroll-conservatively,
12853 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12854
12855 (try_scrolling): When point is above the window, allow searching
12856 as far as scroll_max, or one screenful, to compute vertical
12857 distance from PT to the scroll margin position. This prevents
12858 try_scrolling from unnecessarily failing when
12859 scroll-conservatively is set to a value slightly larger than the
12860 window height. Clean up the case of PT below the margin at bottom
12861 of window: scroll_max can no longer be INT_MAX. When aggressive
12862 scrolling is in use, don't let point enter the opposite scroll
12863 margin as result of the scroll.
12864 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12865 threshold of 100 lines for never-recentering scrolling.
12866
e4cc2dfc
JB
128672011-03-31 Juanma Barranquero <lekktu@gmail.com>
12868
12869 * dispextern.h (move_it_by_lines):
12870 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12871 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12872 (message_log_check_duplicate): Remove parameters `prev_bol' and
12873 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12874 (redisplay_internal): Remove parameter `preserve_echo_area',
12875 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12876
12877 * indent.c (Fvertical_motion):
12878 * window.c (window_scroll_pixel_based, Frecenter):
12879 Don't pass `need_y_p' to `move_it_by_lines'.
12880
1c470562
SM
128812011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12882
44f230aa
SM
12883 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12884 steal a few bits to be more compact.
12885 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12886 Remove unneeded casts.
12887
1c470562
SM
12888 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12889
888adce9
ZK
128902011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12891
12892 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12893 binding" message (bug#7967).
12894
f838ed7b
PE
128952011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12896
77861b95
PE
12897 Fix more problems found by GCC 4.6.0's static checks.
12898
de6dbc14
PE
12899 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12900 Remove unused local var.
12901
f838ed7b
PE
12902 * editfns.c (Fmessage_box): Remove unused local var.
12903
792c7b2b
PE
12904 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12905 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12906 Omit unused local vars.
c499e557 12907 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12908 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12909 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12910 Omit unused local var.
12911
ba0165e1
PE
12912 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12913 Don't assume string length fits in int.
32ad8845 12914 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12915 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12916
3c59b4c9
PE
12917 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12918 instead of alloca (Bug#8344).
12919
a3eed478 12920 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12921 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12922
eb4d412d
PE
12923 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12924
1658b401
PE
12925 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12926 concerns.
12927
12928 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12929
12930 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12931
9a2c6e05
PE
12932 * keyboard.c (syms_of_keyboard): Use the same style as later
12933 in this function when indexing through an array. This also
12934 works around GCC bug 48267.
12935
03d0a109
PE
12936 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12937
44f730c8
PE
12938 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12939
fe75f926
PE
12940 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12941 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12942
ffa8c828
PE
12943 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12944 This avoids undefined behavior on integer overflow, and is a bit
12945 more convenient anyway since it is compared to a size_t variable.
12946
c5101a77
PE
12947 Variadic C functions now count arguments with size_t, not int.
12948 This avoids an unnecessary limitation on 64-bit machines, which
12949 caused (substring ...) to crash on large vectors (Bug#8344).
12950 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12951 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12952 All variadic functions and their callers changed accordingly.
c5101a77
PE
12953 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12954 * data.c (arith_driver, float_arith_driver): Likewise.
12955 * editfns.c (general_insert_function): Likewise.
12956 * eval.c (struct backtrace.nargs, interactive_p)
12957 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12958 (funcall_lambda, mark_backtrace): Likewise.
12959 * fns.c (concat): Likewise.
12960 * frame.c (x_set_frame_parameters): Likewise.
12961 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12962 0 if not found, not -1. All callers changed.
12963
dd3f25f7
PE
12964 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12965 (stack_copy_size): Now size_t, not int.
12966 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12967
461c2ab9
JB
129682011-03-28 Juanma Barranquero <lekktu@gmail.com>
12969
12970 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12971 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12972 All callers changed.
12973
12974 * lisp.h (multibyte_char_to_unibyte):
12975 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12976 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12977 * character.h (CHAR_TO_BYTE8):
12978 * cmds.c (internal_self_insert):
12979 * editfns.c (general_insert_function):
12980 * keymap.c (push_key_description):
12981 * search.c (Freplace_match):
12982 * xdisp.c (message_dolog, set_message_1): All callers changed.
12983
f6d62986
SM
129842011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12985
12986 * keyboard.c (safe_run_hook_funcall): New function.
12987 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12988 don't set the hook to nil, but remove the offending function instead.
12989 (Qcommand_hook_internal): Remove, unused.
12990 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12991 Vcommand_hook_internal.
12992
12993 * eval.c (enum run_hooks_condition): Remove.
12994 (funcall_nil, funcall_not): New functions.
12995 (run_hook_with_args): Call each function through a `funcall' argument.
12996 Remove `cond' argument, now redundant.
12997 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12998 (Frun_hook_with_args_until_failure): Adjust accordingly.
12999 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13000
1db5b1ad
JB
130012011-03-28 Juanma Barranquero <lekktu@gmail.com>
13002
13003 * dispextern.h (string_buffer_position): Remove declaration.
13004
13005 * print.c (strout): Remove parameter `multibyte', unused since
13006 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13007
13008 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13009 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13010 All callers changed.
13011
13012 * w32.c (_wsa_errlist): Use braces for struct initializers.
13013
13014 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13015 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13016 All callers changed.
13017 (string_buffer_position): Likewise. Also, make static (it's never
13018 used outside xdisp.c).
13019 (cursor_row_p): Remove parameter `w', unused since
13020 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13021 (decode_mode_spec): Remove parameter `precision', introduced during
13022 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13023 All callers changed.
13024
5ffb62aa
JD
130252011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13026
13027 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13028
461c2ab9 130292011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13030
13031 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13032 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13033 (ns_update_auto_hide_menu_bar): New functions.
13034 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13035 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13036 ns_constrain_all_frames.
13037 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13038 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13039
5c380ffb
JD
130402011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13041
13042 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13043
9af30bdf
GM
130442011-03-27 Glenn Morris <rgm@gnu.org>
13045
13046 * syssignal.h: Replace RETSIGTYPE with void.
13047 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13048 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13049 Replace SIGTYPE with void everywhere.
13050 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13051 * s/template.h (SIGTYPE): Remove commented out definition.
13052
e2abce01
JB
130532011-03-26 Eli Zaretskii <eliz@gnu.org>
13054
13055 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13056 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13057
f868cd8a
JB
130582011-03-26 Juanma Barranquero <lekktu@gmail.com>
13059
59eb0929
JB
13060 * w32.c (read_unc_volume): Use parameter `henum', instead of
13061 global variable `wget_enum_handle'.
13062
13063 * keymap.c (describe_vector): Remove parameters `indices' and
13064 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13065 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13066
f868cd8a
JB
13067 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13068
13069 * keyboard.c (timer_check): Remove parameter `do_it_now',
13070 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13071 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13072 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13073
13074 * keyboard.c (read_char):
13075 * w32menu.c (w32_menu_display_help):
13076 * xmenu.c (show_help_event, menu_help_callback):
13077 Adjust calls to `show_help_echo'.
13078
13079 * gtkutil.c (xg_maybe_add_timer):
13080 * keyboard.c (readable_events):
13081 * process.c (wait_reading_process_output):
13082 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13083
13084 * insdel.c (adjust_markers_gap_motion):
13085 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13086 (gap_left, gap_right): Don't call it.
13087
2ecf6fdb
CY
130882011-03-25 Chong Yidong <cyd@stupidchicken.com>
13089
13090 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13091 incurred during fontification.
13092
6b1f9ba4
JB
130932011-03-25 Juanma Barranquero <lekktu@gmail.com>
13094
13095 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13096 (DEFVAR_PER_BUFFER): Don't pass it.
13097
13098 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13099 (scrolling_window): Don't pass it.
13100
0f4a96b5
JB
131012011-03-25 Juanma Barranquero <lekktu@gmail.com>
13102
13103 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13104
13105 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13106 and `suffix'.
13107 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13108 of variables specific to SELinux and computation of `encoded_absname'.
13109
13110 * image.c (XPutPixel): Remove unused variable `height'.
13111
13112 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13113
13114 * unexw32.c (get_section_info): Remove unused variable `section'.
13115
13116 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13117 (system_process_attributes): Remove unused variable `sess'.
13118 (sys_read): Remove unused variable `err'.
13119
13120 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13121 (w32_wnd_proc): Remove unused variable `isdead'.
13122 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13123 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13124 (x_create_tip_frame): Remove unused variable `tem'.
13125
13126 * w32inevt.c (w32_console_read_socket):
13127 Remove unused variable `no_events'.
13128
13129 * w32term.c (x_draw_composite_glyph_string_foreground):
13130 Remove unused variable `width'.
13131
1149507c
JB
131322011-03-24 Juanma Barranquero <lekktu@gmail.com>
13133
13134 * w32term.c (x_set_glyph_string_clipping):
13135 Don't pass uninitialized region to CombineRgn.
13136
9c88f339
JB
131372011-03-23 Juanma Barranquero <lekktu@gmail.com>
13138
13139 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13140 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13141 (Fx_close_connection): Remove unused variable `i'.
13142
13143 * w32font.c (w32font_draw): Return number of glyphs.
13144 (w32font_open_internal): Remove unused variable `i'.
13145 (w32font_driver): Add missing initializer.
13146
13147 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13148 (fill_in_menu): Remove unused variable `items_added'.
13149
13150 * w32term.c (last_mouse_press_frame): Remove static global variable.
13151 (w32_clip_to_row): Remove unused variable `f'.
13152 (x_delete_terminal): Remove unused variable `i'.
13153
13154 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13155 (NOTHING): Remove unused static global variable.
13156 (uniscribe_check_otf): Remove unused variable `table'.
13157 (uniscribe_font_driver): Add missing initializers.
13158
dee091a3
JD
131592011-03-23 Julien Danjou <julien@danjou.info>
13160
13161 * term.c (Fsuspend_tty, Fresume_tty):
13162 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13163 * window.c (temp_output_buffer_show):
13164 * insdel.c (signal_before_change):
13165 * frame.c (Fhandle_switch_frame):
13166 * fileio.c (Fdo_auto_save):
13167 * emacs.c (Fkill_emacs):
13168 * editfns.c (save_excursion_restore):
13169 * cmds.c (internal_self_insert):
13170 * callint.c (Fcall_interactively):
13171 * buffer.c (Fkill_all_local_variables):
13172 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13173 Use Frun_hooks.
0f4a96b5 13174 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13175 unconditionally since it does the check itself.
dee091a3 13176
2c520ab5 131772011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13178
c9c49752
PE
13179 Fix more problems found by GCC 4.5.2's static checks.
13180
8abc3f12
PE
13181 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13182 the first time through the loop, since we know p0 < p1 then.
13183 This also avoids a gcc -Wstrict-overflow warning.
13184
a2d26660
PE
13185 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13186 leading to a memory leak, possible in functions like
13187 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13188 of objects (Bug#8318).
a2d26660 13189
916c72e9
PE
13190 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13191 that could (at least in theory) be that large.
13192
19ab8a18
PE
13193 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13194 This is less likely to overflow, and avoids undefined behavior if
13195 overflow does occur. All callers changed. Use strtoul to scan
13196 for the unsigned long integer.
b7cbbd6f
PE
13197 (pint2hrstr): Simplify and tune code slightly.
13198 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13199
f0641eff
PE
13200 * scroll.c (do_scrolling): Work around GCC bug 48228.
13201 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13202
7f650bb9
PE
13203 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13204 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13205 (validate_x_resource_name): Simplify count usage.
13206 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13207
37dd57d1
PE
13208 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13209 fail (Bug#8306).
81e56e61 13210
699979fc 13211 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13212
401bf9b4
PE
13213 * process.c (Fmake_network_process): Use socklen_t, not int,
13214 where POSIX says socklen_t is required in portable programs.
13215 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13216 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13217 (Fmake_network_process, server_accept_connection):
13218 (wait_reading_process_output, read_process_output):
13219 Likewise.
13220
b93aacde
PE
13221 * process.c: Rename or move locals to avoid shadowing.
13222 (list_processes_1, Fmake_network_process):
13223 (read_process_output_error_handler, exec_sentinel_error_handler):
13224 Rename or move locals.
4dc343ee 13225 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13226 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13227 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13228 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13229 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13230
af8a867c 13231 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13232 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13233 Include tparam.h instead, since it declares them.
af8a867c
PE
13234 * cm.h (PC): Remove extern decl; tparam.h now does this.
13235 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13236 * terminfo.c: Include tparam.h, to check interfaces.
13237 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13238 (tparam): Adjust signature to match interface in tparam.h;
13239 this removes some undefined behavior. Check that outstring and len
13240 are zero, which they always are with Emacs.
13241 * tparam.h (PC, BC, UP): New extern decls.
13242
0248044d 13243 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13244 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13245
8ff096c1 13246 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13247 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13248 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13249 (ftfont_list): Remove unused local.
49eaafba
PE
13250 (get_adstyle_property, ftfont_pattern_entity):
13251 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13252 Rename locals to avoid shadowing.
8ff096c1 13253
e2be39f6
PE
13254 * xfont.c (xfont_list_family): Mark var as initialized.
13255
c9735e30
PE
13256 * xml.c (make_dom): Now static.
13257
8f5201ae
PE
13258 * composite.c (composition_compute_stop_pos): Rename local to
13259 avoid shadowing.
b246f932
PE
13260 (composition_reseat_it): Remove unused locals.
13261 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13262 (composition_update_it): Mark var as initialized.
11b61122
PE
13263 (find_automatic_composition): Mark vars as initialized,
13264 with a FIXME (Bug#8290).
8f5201ae 13265
760fbc2c
PE
13266 character.h: Rename locals to avoid shadowing.
13267 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13268 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13269 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13270 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13271 to avoid shadowing.
13272
ff08eb85
PE
13273 * textprop.c (property_change_between_p): Remove; unused.
13274
fc7bf025
PE
13275 * intervals.c (interval_start_pos): Now static.
13276
235d7abc
PE
13277 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13278
44f230aa
SM
13279 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13280 Rename locals to avoid shadowing.
3e7d6594 13281
50060332
PE
13282 * sound.c (wav_play, au_play, Fplay_sound_internal):
13283 Fix pointer signedness.
d01f234b 13284 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13285 (wav_play): Initialize a variable to 0, to prevent undefined
13286 behavior (Bug#8278).
50060332 13287
c4fc4e30
PE
13288 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13289
918436ed
PE
13290 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13291
c939f91b
PE
13292 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13293 clobbering (Bug#8298).
b9c7f648
PE
13294 * sysdep.c (sys_subshell): Likewise.
13295 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13296
6bd8c144
PE
13297 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13298 This should get cleaned up, so that child_setup has the
13299 same signature on all platforms.
13300
7710357c 13301 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13302 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13303
c59da222
CY
133042011-03-22 Chong Yidong <cyd@stupidchicken.com>
13305
13306 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13307 not to be necessary, and produces flickering.
13308
66b87493
GM
133092011-03-20 Glenn Morris <rgm@gnu.org>
13310
13311 * config.in: Remove file.
13312
45b6f6d5
JB
133132011-03-20 Juanma Barranquero <lekktu@gmail.com>
13314
13315 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13316 are now in src/globals.h.
13317 (syms_of_minibuf): Remove spurious & from previous change.
13318
cd394be1 133192011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13320
13321 * minibuf.c (completing-read-function): New variable.
13322 (completing-read-default): Rename from completing-read.
13323 (completing-read): Call completing-read-function.
13324
b14e3e21
CY
133252011-03-19 Juanma Barranquero <lekktu@gmail.com>
13326
13327 * xfaces.c (Fx_load_color_file):
13328 Read color file from absolute filename (bug#8250).
13329
f2b726e6
JB
133302011-03-19 Juanma Barranquero <lekktu@gmail.com>
13331
13332 * makefile.w32-in: Update dependencies.
13333
09f6ff02
EZ
133342011-03-17 Eli Zaretskii <eliz@gnu.org>
13335
13336 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13337
29a6015a
PE
133382011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13339
a3a6c54e
PE
13340 Fix more problems found by GCC 4.5.2's static checks.
13341
b766f867
PE
13342 * process.c (make_serial_process_unwind, send_process_trap):
13343 (sigchld_handler): Now static.
13344
be02381c
PE
13345 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13346 That way, the code declares only the vars that it needs.
13347 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13348 * s/cygwin.h (PTY_ITERATION): Likewise.
13349 * s/darwin.h (PTY_ITERATION): Likewise.
13350 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13351
57048744
PE
13352 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13353 * process.c (allocate_pty): Don't declare stb unless it's needed.
13354
7914961c 13355 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13356 (CONSTANTLIM): Remove; unused.
13357 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13358 Define only if needed.
7914961c 13359
b3967b18
PE
13360 * unexelf.c (unexec): Name an expression,
13361 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13362 Use a different way to cause a compilation error if anyone uses
13363 n rather than nn, a way that does not involve shadowing.
73366a00 13364 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13365
29a6015a
PE
13366 * deps.mk (unexalpha.o): Remove; unused.
13367
43cfc33e 13368 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13369 * unexec.h: New file.
ce701a33
PE
13370 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13371 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13372 Depend on unexec.h.
13373 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13374 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13375 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13376 Change as necessary to match prototype in unexec.h.
ce701a33 13377
01f44d5a
PE
13378 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13379 shadowing.
4f63c6bb 13380 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13381
a6670b0b
PE
13382 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13383 Rename locals to avoid shadowing.
13384
cef2010d 13385 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13386 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13387
d4d7173a
PE
13388 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13389
f08b802a
PE
13390 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13391 warning when compiling print.c.
13392
3ddb0639
PE
13393 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13394 instead of using an uninitialized var.
5ad03b97 13395 (font_sort_entities): Mark var as initialized.
3ddb0639 13396
170a2692
PE
13397 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13398
e663c700
PE
13399 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13400 pointers to constants.
89bc529a 13401 (font_parse_fcname): Remove unused vars.
7b81e2d0 13402 (font_delete_unmatched): Now static.
ea838e10 13403 (font_get_spec): Remove; unused.
13a547c6
PE
13404 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13405 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13406 Rename or move locals to avoid shadowing.
e663c700 13407
2a80c887 13408 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13409 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13410
1384fa33 13411 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13412 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13413
8b2c52e9
PE
13414 * alloc.c (mark_backtrace): Move decl from here ...
13415 * lisp.h: ... to here, so that it can be checked.
13416
475545b5 13417 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13418 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13419 (lisp_indirect_variable): Name an expression,
13420 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13421 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13422
b1349114 13423 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13424 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13425 Use const pointer when appropriate.
b1349114 13426
a2928364
PE
13427 * lisp.h (get_system_name, get_operating_system_release):
13428 Move decls here, to check interfaces.
13429 * process.c (get_operating_system_release): Move decl to lisp.h.
13430 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13431 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13432 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13433 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13434 (Fformat_time_string, Fencode_time, Finsert_char):
13435 (Ftranslate_region_internal, Fformat):
13436 Rename or remove local vars to avoid shadowing.
9710023e 13437 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13438
a415e694
PE
13439 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13440 avoid shadowing.
13441
8ef4622d
PE
13442 * lisp.h (eassert): Check that the argument compiles, even if
13443 ENABLE_CHECKING is not defined.
13444
946f9a5b
PE
13445 * data.c (Findirect_variable): Name an expression, to avoid
13446 gcc -Wbad-function-cast warning.
112396d6 13447 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13448 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13449 (Fmake_variable_buffer_local, Fmake_local_variable):
13450 Mark variables as initialized.
52746918 13451 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13452
e5aab7e7 13453 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13454 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13455 Rename locals to avoid shadowing.
dff45157
PE
13456 (mark_stack): Move local variables into the #ifdef region where
13457 they're used.
7bc26fdb
PE
13458 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13459 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13460 needed otherwise.
13461 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13462 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13463 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13464
e5aab7e7
PE
13465 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13466 avoids undefined behavior in theory.
13467
4da60324
PE
13468 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13469
88043301
PE
13470 Use functions, not macros, for up- and down-casing (Bug#8254).
13471 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13472 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13473 to use the following functions instead of these macros.
13474 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13475 EMACS_INT, since callers assume the returned value fits in int.
13476 (upcase1): Likewise, for UPCASE_TABLE.
13477 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13478 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13479 the race-condition problem in the old DOWNCASE.
88043301 13480
19ed5445
PE
13481 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13482 Rename locals to avoid shadowing.
13483 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13484 (regex_compile, re_search_2, re_match_2_internal):
13485 Remove unused local vars.
952db0d7
PE
13486 (FREE_VAR): Rewrite so as not to use empty "else",
13487 which gcc can warn about.
da053e48 13488 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13489 (RETALLOC_IF): Define only if needed.
13490 (WORDCHAR_P): Likewise. This one is never needed, but is used
13491 only in a comment talking about a compiler bug, so put inside
13492 the #if 0 of that comment.
13493 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13494 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13495 Remove; unused.
19ed5445 13496
1f3561e4 13497 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13498 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13499 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13500
ded6f8f7
PE
13501 * search.c (simple_search): Remove unused var.
13502
dbd37a95
PE
13503 * dired.c (compile_pattern): Move decl from here ...
13504 * lisp.h: ... to here, so that it can be checked.
13505 (struct re_registers): New forward decl.
13506
7e47afad
PE
13507 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13508
85f24f61
PE
13509 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13510 All uses changed.
13511 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13512 Rename locals to avoid shadowing.
5671df8f 13513 (Fvertical_motion): Mark locals as initialized.
85f24f61 13514
181aa2be 13515 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13516 (casify_region): Mark local as initialized.
181aa2be 13517
930d429c
PE
13518 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13519
7082eac6
PE
13520 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13521 New macros, so that the caller can use some names other than
13522 gcpro1, gcpro2, etc.
13523 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13524 of the new macros.
13525 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13526 argument, for consistency with GCPRO2_VAR, etc: it is now the
13527 prefix of the variable, not the variable itself. All uses
13528 changed.
38b2c076
PE
13529 * dired.c (directory_files_internal, file_name_completion):
13530 Rename locals to avoid shadowing.
13531
15206ed9
PE
13532 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13533 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13534 dired.c's scmp function, had undefined behavior.
13535 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13536 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13537 * buffer.h: ... to here, because these macros use current_buffer,
13538 and the new implementation with inline functions needs to have
13539 current_buffer in scope now, rather than later when the macros
13540 are used.
13541 (downcase, upcase1): New static inline functions.
13542 (DOWNCASE, UPCASE1): Reimplement using these functions.
13543 This avoids undefined behavior in expressions like
13544 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13545 from race conditions in accessing the global variables
13546 case_temp1 and case_temp2.
13547 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13548 * lisp.h (case_temp1, case_temp2): Remove their decls.
13549 * character.h (ASCII_CHAR_P): Move from here ...
13550 * lisp.h: ... to here, so that the inline functions mentioned
13551 above can use them.
13552
4a6bea26
PE
13553 * dired.c (directory_files_internal_unwind): Now static.
13554
f14b7e14
PE
13555 * fileio.c (file_name_as_directory, directory_file_name):
13556 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13557 Now static.
2893f146
PE
13558 (file_name_as_directory): Use const pointers when appropriate.
13559 (Fexpand_file_name): Likewise. In particular, newdir might
13560 point at constant storage, so make it a const pointer.
fd4ead52 13561 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13562 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13563 signedness issues.
f839df0c
PE
13564 (Fset_file_times, Finsert_file_contents, auto_save_error):
13565 Rename locals to avoid shadowing.
f14b7e14 13566
5716756e 13567 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13568 (Ftry_completion, Fall_completions): Rename or remove locals
13569 to avoid shadowing.
5716756e 13570
b4c3046a
PE
13571 * marker.c (bytepos_to_charpos): Remove; unused.
13572
b45db522
PE
13573 * lisp.h (verify_bytepos, count_markers): New decls,
13574 so that gcc does not warn that these functions aren't declared.
13575
85876d07
PE
13576 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13577 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13578 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13579 (copy_text): Remove unused local var.
85876d07 13580
03d78a21 13581 * filelock.c (within_one_second): Now static.
b3dd38ab 13582 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13583
5df8f01b
PE
13584 * buffer.c (fix_overlays_before): Mark locals as initialized.
13585 (fix_start_end_in_overlays): Likewise. This function should be
13586 simplified by using pointers-to-pointers, but that's a different
13587 matter.
b1d876f1 13588 (switch_to_buffer_1): Now static.
8f54f30a
PE
13589 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13590 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13591
a70072c9 13592 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13593 Fix pointer signedness issue.
edced198
PE
13594 (sys_subshell): Mark local as volatile if checking for lint,
13595 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13596 (MAXPATHLEN): Define only if needed.
a70072c9 13597
a0977c44
PE
13598 * process.c (serial_open, serial_configure): Move decls from here ...
13599 * systty.h: ... to here, so that they can be checked.
13600
a884fdcc
PE
13601 * fns.c (get_random, seed_random): Move extern decls from here ...
13602 * lisp.h: ... to here, so that they can be checked.
13603
604efe86 13604 * sysdep.c (reset_io): Now static.
b8950c94 13605 (wait_for_termination_signal): Remove; unused.
604efe86 13606
38fc62d9
PE
13607 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13608 (copy_keymap_item, append_key, push_text_char_description):
13609 Now static.
1004a21a 13610 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13611 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13612 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13613 (describe_map_tree):
13614 Rename locals to avoid shadowing.
38fc62d9 13615
2f2650da
PE
13616 * keyboard.c: Declare functions static if they are not used elsewhere.
13617 (echo_char, echo_dash, cmd_error, top_level_2):
13618 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13619 (read_char, kbd_buffer_get_event, make_lispy_position):
13620 (make_lispy_event, make_lispy_movement, apply_modifiers):
13621 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13622 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13623 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13624 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13625 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13626
a053e86c 13627 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13628 (mark_kboards): Move decl here ...
13629 * alloc.c (mark_kboards): ... from here.
a053e86c 13630
4752793e
PE
13631 * lisp.h (force_auto_save_soon): New decl.
13632
74f10ca7 13633 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13634 (DEFINE_DUMMY_FUNCTION): New macro.
13635 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13636 Use it.
c03cd23f
PE
13637 (main): Add casts to avoid warnings
13638 if GCC considers string literals to be constants.
74f10ca7 13639
022e70d4
PE
13640 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13641
59d6fe83
PE
13642 * dbusbind.c: Pointer signedness fixes.
13643 (xd_signature, xd_append_arg, xd_initialize):
13644 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13645 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13646 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13647 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13648
78320123
PE
13649 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13650 if GCC considers string literals to be constants.
49cebcca 13651 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13652
35ac2a97
SM
136532011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13654
fb103ca9
SM
13655 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13656 (print_preprocess, print_object): New macro to fix last change.
13657
35ac2a97
SM
13658 * print.c (print_preprocess): Don't forget font objects.
13659
62973b41
JB
136602011-03-16 Juanma Barranquero <lekktu@gmail.com>
13661
13662 * emacs.c (USAGE3): Doc fixes.
13663
0e48bb22
AS
136642011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13665
13666 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13667 structure.
13668
7684e57b
JB
136692011-03-14 Juanma Barranquero <lekktu@gmail.com>
13670
13671 * lisp.h (VWindow_system, Qfile_name_history):
13672 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13673 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13674 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13675
13676 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13677 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13678
13679 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13680 * w32console.c (detect_input_pending, read_input_pending)
13681 (encode_terminal_code):
13682 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13683 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13684 (w32_system_caret_y, Qfile_name_history):
13685 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13686 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13687 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13688 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13689 * w32proc.c (Qlocal, report_file_error):
13690 * w32term.c (Vwindow_system, updating_frame):
13691 * w32uniscribe.c (initialized, uniscribe_font_driver):
13692 Remove unneeded extern declarations.
13693
2aa46d6c
CY
136942011-03-14 Chong Yidong <cyd@stupidchicken.com>
13695
c96bbc66 13696 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13697
cffc6f3b
CY
136982011-03-13 Chong Yidong <cyd@stupidchicken.com>
13699
13700 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13701 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13702 These macros can no longer be used for assignment.
13703
44f230aa
SM
13704 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13705 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13706 (record_buffer_markers, fetch_buffer_markers): New functions for
13707 recording and fetching special buffer markers.
13708 (set_buffer_internal_1, set_buffer_temp): Use them.
13709
13710 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13711
13712 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13713
13714 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13715 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13716
13717 * xdisp.c (hscroll_window_tree):
13718 (reconsider_clip_changes): Use PT instead of BUF_PT.
13719
d251f04b
EZ
137202011-03-13 Eli Zaretskii <eliz@gnu.org>
13721
13722 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13723 $(EMACS_ROOT)/lib/intprops.h.
13724
f0c77cd1
PE
137252011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13726
3eca4629
PE
13727 Fix more problems found by GCC 4.5.2's static checks.
13728
7c86ee98
PE
13729 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13730 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13731 (xg_free_frame_widgets): Make it clear that a local variable is
13732 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13733 (gdk_window_get_screen): Make it clear that this macro is needed
13734 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13735 (int_gtk_range_get_value): New function, which avoids a diagnostic
13736 from gcc -Wbad-function-cast.
13737 (xg_set_toolkit_scroll_bar_thumb): Use it.
13738 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13739 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13740 (get_utf8_string, xg_get_file_with_chooser):
13741 Rename locals to avoid shadowing.
13742 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13743
41729b81
PE
13744 * xgselect.c (xg_select): Remove unused var.
13745
f0c77cd1
PE
13746 * image.c (four_corners_best): Mark locals as initialized.
13747 (gif_load): Initialize transparent_p to zero (Bug#8238).
13748 Mark another local as initialized.
ec6cf4c6 13749 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13750
ce0ad53d 13751 * image.c (clear_image_cache): Now static.
d5d5a617 13752 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13753 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13754 (x_edge_detection): Remove unnecessary cast that
13755 gcc -Wbad-function-cast diagnoses.
2037898d 13756 (gif_load): Fix pointer signedness.
6ae141d6
PE
13757 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13758 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13759
33383987 137602011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13761
d32df629
PE
13762 Improve quality of tests for time stamp overflow.
13763 For example, without this patch (encode-time 0 0 0 1 1
13764 1152921504606846976) returns the obviously-bogus value (-948597
13765 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13766 reports time overflow. See
13767 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13768 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13769 * editfns.c: Include limits.h and intprops.h.
13770 (TIME_T_MIN, TIME_T_MAX): New macros.
13771 (time_overflow): Move earlier, to before first use.
13772 (hi_time, lo_time): New functions, for an accurate test for
13773 out-of-range times.
13774 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13775 (Fget_internal_run_time): Don't assume time_t fits in int.
13776 (make_time): Use list2 instead of Fcons twice.
13777 (Fdecode_time): More accurate test for out-of-range times.
13778 (check_tm_member): New function.
13779 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13780 (lisp_time_argument): Don't rely on undefined left-shift and
13781 right-shift behavior when checking for time stamp overflow.
8be6f318 13782
fe31d94c
PE
13783 * editfns.c (time_overflow): New function, refactoring common code.
13784 (Fformat_time_string, Fdecode_time, Fencode_time):
13785 (Fcurrent_time_string): Use it.
13786
8be6f318
PE
13787 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13788 * dired.c (make_time): Move to ...
13789 * editfns.c (make_time): ... here.
13790 * systime.h: Note the move.
13791
09d9db2c 137922011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13793
126bc0dc
YM
13794 * fringe.c (update_window_fringes): Remove unused variables.
13795
c47cbdfd
YM
13796 * unexmacosx.c (copy_data_segment): Also copy __got section.
13797 (Bug#8223)
13798
7ac80be9
EZ
137992011-03-12 Eli Zaretskii <eliz@gnu.org>
13800
c96bbc66 13801 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13802 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13803 Constify `char *' arguments and their references according to
13804 prototypes in tparam.h.
13805
ecb0f94d 13806 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13807
7ac80be9
EZ
13808 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13809 Adapt all references accordingly.
13810
13811 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13812
ef1fd07e
TT
138132011-03-11 Tom Tromey <tromey@redhat.com>
13814
13815 * buffer.c (syms_of_buffer): Remove obsolete comment.
13816
7ef4b50c
EZ
138172011-03-11 Eli Zaretskii <eliz@gnu.org>
13818
13819 * termhooks.h (encode_terminal_code): Declare prototype.
13820
13821 * msdos.c (encode_terminal_code): Don't declare prototype.
13822
13823 * term.c (encode_terminal_code): Now external again, used by
13824 w32console.c and msdos.c.
13825
44f230aa
SM
13826 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13827 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13828
4b1ec863 138292011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13830
1714f52b 13831 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13832
4b1ec863
PE
13833 * fringe.c (update_window_fringes): Mark locals as initialized
13834 (Bug#8227).
13835 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13836
524c7aa6
PE
13837 * alloc.c (mark_fringe_data): Move decl from here ...
13838 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13839 to check its interface.
13840 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13841
a5c0af81 13842 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13843 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13844 (fontset_font): Mark local as initialized.
a9a06e0b 13845 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13846
b4716021
PE
13847 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13848
811e9bac 13849 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13850 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13851 (x_own_selection, Fx_disown_selection_internal): Rename locals
13852 to avoid shadowing.
13853 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13854
7e3ab302
PE
13855 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13856 so that the caller can use some name other than gcpro1.
13857 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13858 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13859 (Fx_backspace_delete_keys_p):
13860 Use them to avoid shadowing, and rename vars to avoid shadowing.
13861 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13862 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13863 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13864 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13865 Remove unused locals.
7e3ab302
PE
13866 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13867 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13868 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13869 macros.
f78faa98 13870
e2b13473
PE
13871 * xterm.h (x_mouse_leave): New decl.
13872
77f23912
PE
13873 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13874 Remove unused functions.
cdf4ba58
PE
13875 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13876 (x_calc_absolute_position): Now static.
7411c686 13877 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13878 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13879 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13880 unless they are used.
38d0b34a
PE
13881 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13882 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13883 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13884 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13885 (x_error_catcher, x_connection_closed, x_error_handler):
13886 (x_error_quitter, xembed_send_message, x_iconify_frame):
13887 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13888 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13889 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13890
44f230aa
SM
13891 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13892 Rename or move locals to avoid shadowing.
6b463e58 13893 (tty_defined_color, merge_face_heights): Now static.
5967d051 13894 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13895 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13896 does not deduce is never used uninitialized.
73719eba
PE
13897 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13898 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13899
426994c3 13900 * terminal.c (store_terminal_param): Now static.
5489860b 13901
032f1620 13902 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13903 (set_frame_menubar): Remove unused local.
d4323972 13904 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13905 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13906 since they might point to immutable storage.
281585b0
PE
13907 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13908 since it's unused otherwise.
032f1620 13909
367c19e5 13910 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13911 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13912 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13913 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13914 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13915 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13916 does not deduce are never used uninitialized.
70739cbe 13917
07b48fa9
PE
13918 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13919
8868a238 13920 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13921 * window.c (window_loop, size_window):
13922 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13923
7e5cf297 13924 * window.c (display_buffer): Now static.
d6550a9f
PE
13925 (size_window): Mark variables that gcc -Wuninitialized
13926 does not deduce are never used uninitialized.
a586633d
PE
13927 * window.h (check_all_windows): New decl, to forestall
13928 gcc -Wmissing-prototypes diagnostic.
5b555da1 13929 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13930
f6095868
PE
13931 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13932 shadowing.
13933 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13934 Include <limits.h>.
13935 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13936 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13937 (load_charset_map): Mark variables that gcc -Wuninitialized
13938 does not deduce are never used uninitialized.
53df7c11 13939 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13940
f38b440c
PE
13941 * coding.c (coding_set_source, coding_set_destination):
13942 Use "else { /* comment */ }" rather than "else /* comment */;"
13943 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13944 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13945 a block, when the outer 'i' will do.
13946 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13947 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13948 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13949 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13950 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13951 Rename locals to avoid shadowing.
13952 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13953 * coding.c (emacs_mule_char, encode_invocation_designation):
13954 Now static, since they're not used elsewhere.
413bb2db 13955 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13956 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13957 (decode_coding_emacs_mule): Mark variables that gcc
13958 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13959 (detect_coding_iso_2022): Initialize a local variable that might
13960 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13961 this initialization is needed. (Bug#8211)
5f58e762
PE
13962 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13963 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13964 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13965 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13966 Remove unused macros.
f38b440c 13967
232b38b9 13968 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13969 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13970 * character.c (string_count_byte8): Likewise.
232b38b9 13971
fb90da1b
PE
13972 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13973 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13974
fb93dbc2
PE
13975 * chartab.c (copy_sub_char_table): Now static, since it's not used
13976 elsewhere.
5c156ace
PE
13977 (sub_char_table_ref_and_range, char_table_ref_and_range):
13978 Rename locals to avoid shadowing.
bbcd0949 13979 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13980
7d3b3862 13981 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13982 (BIDI_BOB): Remove unused macro.
7d3b3862 13983
6be7d3da
PE
13984 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13985 deduce are never used uninitialized.
c2ed9c8b 13986 * term.c (encode_terminal_code): Likewise.
6be7d3da 13987
75f8807f 13988 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13989
50938595
PE
13990 * tparam.h: New file.
13991 * term.c, tparam.h: Include it.
13992 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13993 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13994 Move these decls to tparam.h, and make them agree with what
13995 is actually in tparam.c. The previous trick of using incompatible
13996 decls in different modules does not conform to the C standard.
13997 All callers of tparam changed to use tparam's actual API.
13998 * tparam.c (tparam1, tparam, tgoto):
13999 Use const pointers where appropriate.
14000
fbceeba2
PE
14001 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14002 * cm.h (struct cm): Likewise.
14003 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14004 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14005 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14006 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14007 (turn_on_face, init_tty): Likewise.
14008 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14009
7f3f1250
PE
14010 * term.c (term_mouse_position): Rename local to avoid shadowing.
14011
e6ca6543
PE
14012 * alloc.c (mark_ttys): Move decl from here ...
14013 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14014
c40f8d15
AS
140152011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14016
14017 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14018
cfe0661d
JB
140192011-03-09 Juanma Barranquero <lekktu@gmail.com>
14020
14021 * search.c (compile_pattern_1): Remove argument regp, unused since
14022 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14023 (compile_pattern): Don't pass it.
14024
0afb4571
J
140252011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14026
14027 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14028 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14029 for ! HAVE_GTK3.
14030 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14031
14032 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14033
14034 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14035 gdk_window_get_screen, gdk_window_get_geometry,
14036 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14037 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14038 (xg_get_pixbuf_from_pixmap): New function.
14039 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14040 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14041 Call xg_get_pixbuf_from_pixmap instead of
14042 gdk_pixbuf_get_from_drawable.
14043 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14044 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14045 (xg_check_special_colors): Use GtkStyleContext and its functions
14046 for HAVE_GTK3.
14047 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14048 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14049 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14050 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14051 Call gtk_widget_get_preferred_size.
0afb4571
J
14052 (xg_frame_resized): gdk_window_get_geometry only takes 5
14053 parameters.
44f230aa
SM
14054 (xg_win_to_widget, xg_event_is_for_menubar):
14055 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14056 (xg_set_widget_bg): New function.
14057 (delete_cb): New function.
895009e1 14058 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14059 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14060 (xg_set_background_color): Call xg_set_widget_bg.
14061 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14062 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14063 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14064 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14065 if ! HAVE_GTK3.
14066 (update_frame_tool_bar): Call gtk_widget_hide.
14067 (xg_initialize): Use GDK_KEY_g.
14068
14069 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14070 if ! HAVE_GTK3
14071 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14072
14073 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14074 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14075 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14076
1c2cc4ef
JB
140772011-03-08 Juanma Barranquero <lekktu@gmail.com>
14078
14079 * w32xfns.c (select_palette): Check success of RealizePalette against
14080 GDI_ERROR, not zero.
14081
33383987 14082See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14083
14084;; Local Variables:
14085;; coding: utf-8
aac0c6e3
MR
14086;; End:
14087
2f097256 14088 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14089
14090 This file is part of GNU Emacs.
14091
14092 GNU Emacs is free software: you can redistribute it and/or modify
14093 it under the terms of the GNU General Public License as published by
14094 the Free Software Foundation, either version 3 of the License, or
14095 (at your option) any later version.
14096
14097 GNU Emacs is distributed in the hope that it will be useful,
14098 but WITHOUT ANY WARRANTY; without even the implied warranty of
14099 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14100 GNU General Public License for more details.
14101
14102 You should have received a copy of the GNU General Public License
14103 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.