* buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
76046526
DA
12012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
4
39adff0d
PE
52012-07-04 Paul Eggert <eggert@cs.ucla.edu>
6
63807d47
PE
7 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
8 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
9 since GCC 4.4.6 issues a bogus warning for them.
10
39adff0d
PE
11 Fix bugs in file timestamp newness comparisons.
12 * fileio.c (Ffile_newer_than_file_p):
13 * lread.c (Fload): Use full timestamp resolution of files,
14 not just the 1-second resolution, so that files that are only
15 slightly newer still count as newer.
16 * fileio.c (Ffile_newer_than_file_p): Don't assume file
17 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
18
dbeed9a6
PE
192012-07-03 Paul Eggert <eggert@cs.ucla.edu>
20
21 * fileio.c: Improve handling of file time marker. (Bug#11852)
22 (special_mtime): New function.
23 (Finsert_file_contents, Fverify_visited_file_modtime):
24 Use it to set special mtime values consistently.
25
636334d6
AS
262012-07-03 Andreas Schwab <schwab@linux-m68k.org>
27
28 * fileio.c (Finsert_file_contents): Properly handle st_mtime
29 marker for non-existing file. (Bug#11852)
30
e2017fe2
GM
312012-07-03 Glenn Morris <rgm@gnu.org>
32
33 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
34 and did not make it into globals.h).
35
404dbd37
TT
362012-07-03 Tom Tromey <tromey@redhat.com>
37
38 * window.c (Fset_window_margins, Fset_window_fringes)
39 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
40 * textprop.c (Fprevious_property_change): No longer static.
41 * syntax.c (Fsyntax_table_p): No longer static.
42 * process.c (Fget_process, Fprocess_datagram_address): No longer
43 static.
44 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
45 * keyboard.c (Fcommand_execute): No longer static.
46 Remove EXFUN.
47 * insdel.c (Fcombine_after_change_execute): No longer static.
48 * image.c (Finit_image_library): No longer static.
49 * fileio.c (Fmake_symbolic_link): No longer static.
50 * eval.c (Ffetch_bytecode): No longer static.
51 * editfns.c (Fuser_full_name): No longer static.
52 * doc.c: (Fdocumentation_property, Fsnarf_documentation): No
53 longer static.
54 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
55 static.
56 * dired.c (Ffile_attributes): No longer static.
57 * composite.c (Fcomposition_get_gstring): No longer static.
58 * callproc.c (Fgetenv_internal): No longer static.
59
60 * ccl.h: Remove EXFUNs.
61 * buffer.h: Remove EXFUNs.
62 * dispextern.h: Remove EXFUNs.
63 * intervals.h: Remove EXFUNs.
64 * fontset.h: Remove EXFUN.
65 * font.h: Remove EXFUNs.
66 * dosfns.c (system_process_attributes): Remove EXFUN.
67 * keymap.h: Remove EXFUNs.
68 * lisp.h: Remove EXFUNs.
69 * w32term.h: Remove EXFUNs.
70 * window.h: Remove EXFUNs.
71 * xsettings.h: Remove EXFUN.
72 * xterm.h: Remove EXFUN.
73
8e4fd1e1
GM
742012-07-03 Glenn Morris <rgm@gnu.org>
75
76 * lisp.h (Frandom): Make it visible to C.
77 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
78 buffer for invisible buffers. (Bug#1229)
79
ca95b3eb
DA
802012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
81
82 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
83 values which aren't power of 2.
84 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
85 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
86 accordingly.
87
7555c33f
SM
882012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
89
90 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
91
92 * alloc.c (mark_object): Revert part of last patch to use `switch'.
93
d12e8f5a
DA
942012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
95
96 * alloc.c (allocate_vector_block): Remove redundant
97 calls to mallopt if DOUG_LEA_MALLOC is defined.
98 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
99 avoid calls to mallopt if zero_vector is returned.
100
296094c3
DA
1012012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
102
103 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
104 is enabled, avoid dereferencing NULL current_sblock if
105 running undumped.
106
36429c89
DA
1072012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
108
109 Cleanup basic buffer management.
110 * buffer.h (struct buffer): Change layout to use generic vector
111 marking code. Fix some comments. Change type of 'clip_changed'
112 to bitfield. Remove unused #ifndef old.
113 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
114 (GET_OVERLAYS_AT): Fix indentation.
115 (for_each_per_buffer_object_at): New macro.
116 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
117 (Fbuffer_local_variables): Use it.
118 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
119 * alloc.c (allocate_buffer): Adjust to match new layout of
120 struct buffer. Fix comment.
121 (mark_overlay): New function.
122 (mark_buffer): Use it. Use mark_vectorlike to mark normal
123 Lisp area of struct buffer.
124 (mark_object): Use it. Adjust marking of misc objects
125 and related comments.
126
3b3e4cac
PE
1272012-07-02 Paul Eggert <eggert@cs.ucla.edu>
128
129 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
130 wrapper that is not needed because the wrapped code is a no-op (zero
131 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
132 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
133
cf5c0175
DA
1342012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
135
136 * alloc.c (mark_buffer): Simplify. Remove prototype.
137 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 138 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
139 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
140 redundant calls to mark_vectorlike for bool vectors.
141
ca26824c
GM
1422012-06-30 Glenn Morris <rgm@gnu.org>
143
2e4c5312
GM
144 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
145
ca26824c
GM
146 * epaths.in (PATH_SITELOADSEARCH): New.
147 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
148 This is rather than relying on --enable-locallisppath elements
149 having "site-lisp" in their names. (Bug#10208#25, 11658)
150
0d23c240
EZ
1512012-06-30 Eli Zaretskii <eliz@gnu.org>
152
c9240d7a
EZ
153 * w32proc.c (sys_select): Accept and ignore one more argument.
154
155 * w32.c (emacs_gnutls_pull): Call select with one more argument.
156
0d23c240 157 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 158 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
159
160 * sysdep.c: Don't include dos.h and dosfns.h.
161
162 * process.c (sys_select):
163 * msdos.c (sys_select): Accept one more argument and ignore it.
164
165 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
166 adapt data types and code to that.
167
168 * dosfns.c:
169 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
170 which clashes with the gnulib function of the same name.
171
af5a5a98
AS
1722012-06-30 Andreas Schwab <schwab@linux-m68k.org>
173
c5e4379c
AS
174 * font.c (font_style_to_value, font_style_symbolic)
175 (font_prop_validate_style): Add type checks for values in
176 font_style_table.
177
af5a5a98
AS
178 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
179 argument.
180 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
181 uses.
182
8d38f461
EZ
1832012-06-29 Eli Zaretskii <eliz@gnu.org>
184
2e5a6631
EZ
185 * xdisp.c (try_window_id): Undo last change.
186
8d38f461
EZ
187 * w32.c (getwd): Adjust commentary about startup_dir.
188 (init_environment): Always call sys_access, even in non-MSVC
189 builds. Don't chdir to the directory of the Emacs executable.
190 This undoes code from 1997 which was justified by the need to
191 "avoid conflicts when removing and renaming directories". But its
192 downside was that every relative file name was being interpreted
193 relative to the directory of the Emacs executable, which can never
194 be TRT. In particular, it broke sys_access when called with
195 relative file names.
196 (sys_access): Map GetLastError to errno.
197
2af3565e
DA
1982012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
199
200 * window.h (struct window): Change type of 'fringes_outside_margins'
201 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 202 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
203 Adjust comment.
204 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
205 to ptrdiff_t.
206
c8d3a25c 2072012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 208
c8d3a25c
GM
209 * gnutls.c (emacs_gnutls_handshake):
210 Add QUIT to make the loop interruptible.
57570cd3 211
c8d3a25c 2122012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 213
c8d3a25c
GM
214 * charset.c (init_charset): Make lack of etc/charsets fatal.
215
3e984ee8
DA
2162012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
217
218 * editfns.c (region_limit): Fix type mismatch.
219
ef884f23
DA
2202012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
221
222 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
223 undefined. Convert from xassert to eassert.
224 * nsmenu.m: Convert from xassert to eassert.
225 * nsterm.m: Likewise.
226
7d7e0027
SM
2272012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
228
229 * editfns.c (region_limit): Clip to narrowing (bug#11770).
230
aa754e6a
PE
2312012-06-28 Paul Eggert <eggert@cs.ucla.edu>
232
233 Avoid integer overflow on scroll-left and scroll-right.
234 * window.c (HSCROLL_MAX): New macro.
235 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
236 overflow when requested scroll falls outside ptrdiff_t range.
237
80b00b08
DA
2382012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
239
240 * window.h (struct window): Change type of 'hscroll',
241 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
242 'last_modified' and 'last_overlay_modified' to EMACS_INT.
243 Adjust users accordingly.
244 * xdisp.c (try_cursor_movement): Replace type check with eassert.
245 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
246 from EMACS_INT to ptrdiff_t.
247 (make_window): Omit redundant initialization.
248
62b2bcf6
JB
2492012-06-28 Juanma Barranquero <lekktu@gmail.com>
250
251 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
252
45942c7d
DA
2532012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
254
255 * window.h (struct window): Change type of 'use_time' and
256 'sequence_number' from Lisp_Object to int.
257 * frame.c (make_frame): Adjust users accordingly.
258 * print.c (print_object): Likewise.
259 * window.c (select_window, Fwindow_use_time, make_parent_window)
260 (make_window): Likewise.
261
e509cfa6
DA
2622012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
263
264 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
265 enabled with --enable-checking=[all,glyphs] configure option.
266 Fix GLYPH_DEBUG usage assuming that it may be undefined,
267 adjust comments accordingly.
268 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
269 undefined, adjust comments accordingly.
270 * image.c: Likewise.
271 * scroll.c: Likewise.
272 * w32fns.c: Likewise.
273 * w32term.c: Likewise.
274 * xdisp.c: Likewise.
275 * xfaces.c: Likewise.
276 * xfns.c: Likewise.
277 * xterm.c: Likewise.
278
a54e2c05
DA
2792012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
280
281 Generalize run-time debugging checks.
282 * dispextern.h (XASSERTS): Remove.
283 * fontset.c (xassert): Remove.
284 Convert from xassert to eassert.
285 * alloc.c: Convert from xassert to eassert.
286 * bidi.c: Likewise.
287 * dispnew.c: Likewise.
288 * fns.c: Likewise.
289 * fringe.c: Likewise.
290 * ftfont.c: Likewise.
291 * gtkutil.c: Likewise.
292 * image.c: Likewise.
293 * keyboard.c: Likewise.
294 * menu.c: Likewise.
295 * process.c: Likewise.
296 * scroll.c: Likewise.
297 * sound.c: Likewise.
298 * term.c: Likewise.
299 * w32console.c: Likewise.
300 * w32fns.c: Likewise.
301 * w32term.c: Likewise.
302 * window.c: Likewise.
303 * xdisp.c: Likewise.
304 * xfaces.c: Likewise.
305 * xfns.c: Likewise.
306 * xselect.c: Likewise.
307 * xterm.c: Likewise.
308
1ec4b7b2
SM
3092012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
310
311 * fns.c (maybe_resize_hash_table): Output message when growing the
312 purify-hashtable.
313
2014308a
DA
3142012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
315
316 * alloc.c (allocate_string_data): Remove dead code.
317 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
318 avoid GCC warning about unused macro.
319
246155eb
DA
3202012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
321
322 * alloc.c (allocate_string): Omit intervals initialization.
323 * alloc.c (make_uninit_multibyte_string): Initialize intervals
324 as in make_pure_string and make_pure_c_string.
325
43184b7b
DA
3262012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
327
328 * alloc.c (allocate_string): Fix last change.
329
3fe6dd74
DA
3302012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
331
332 * alloc.c (allocate_string): Remove two redundant calls
333 to memset, add explicit initialization where appropriate.
334
1ba6038a
GM
3352012-06-27 Glenn Morris <rgm@gnu.org>
336
337 * lisp.mk (lisp): Remove paths.elc.
338
c89926a5
CY
3392012-06-27 Chong Yidong <cyd@gnu.org>
340
341 * doc.c (Fsubstitute_command_keys): Fix punctuation.
342
ed6b3510
JW
3432012-06-26 John Wiegley <johnw@newartisans.com>
344
1ec4b7b2 345 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
346 on Mac OS X Lion: __mod_init_func and __mod_term_func.
347
ed6b3510
JW
348 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
349 when building with Clang.
350
8edd4a2b
SM
3512012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
352
353 * eval.c (Fapply): Allow calling it with a single argument.
354
f6f62d1b
EZ
3552012-06-26 Eli Zaretskii <eliz@gnu.org>
356
357 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
358 _stricmp and _strnicmp.
359 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
360
62efea5e
DA
3612012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
362
363 * alloc.c (allocate_window): Zero out non-Lisp part of newly
364 allocated window.
365 (allocate_process): Likewise for new process.
8edd4a2b 366 (allocate_terminal): Change to use offsetof.
62efea5e
DA
367 (allocate_frame): Likewise.
368 * frame.c (make_frame): Omit redundant initialization.
369 * window.c (make_parent_window): Use memset.
370 (make_window): Omit redundant initialization.
371 * process.c (make_process): Omit redundant initialization.
372 * terminal.c (create_terminal): Likewise.
373
42997f4d
DA
3742012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
375
376 * term.c (delete_tty): Remove redundant call to memset.
377
1130ecfc
DA
3782012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
379
380 * alloc.c: Remove build_string.
381 * lisp.h: Define build_string as static inline. This provides
382 a better opportunity to optimize away calls to strlen when the
383 function is called with compile-time constant argument.
384 * image.c (imagemagick_error): Convert to build_string.
385 * w32proc.c (sys_spawnve): Likewise.
386 * xterm.c (x_term_init): Likewise.
387
cf38a720
PE
3882012-06-26 Paul Eggert <eggert@cs.ucla.edu>
389
99027bdd
PE
390 Use sprintf return value instead of invoking strlen on result.
391 In the old days this wasn't portable, since some sprintf
392 implementations returned char *. But they died out years ago and
393 Emacs already assumes sprintf returns int.
394 Similarly for float_to_string.
395 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
396 * ccl.c (ccl_driver):
397 * character.c (string_escape_byte8):
398 * data.c (Fnumber_to_string):
399 * doprnt.c (doprnt):
400 * print.c (print_object):
401 * xdisp.c (message_dolog):
402 * xfns.c (syms_of_xfns):
403 Use sprintf or float_to_string result to avoid need to call strlen.
404 * data.c (Fnumber_to_string):
405 Use make_unibyte_string, since the string must be ASCII.
406 * lisp.h, print.c (float_to_string): Now returns int length.
407 * term.c (produce_glyphless_glyph):
408 Use sprintf result rather than recomputing it.
409
cf38a720
PE
410 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
411 * Makefile.in (ALL_CFLAGS):
412 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
413 * gmalloc.c, regex.c: Include <config.h> unconditionally.
414
3511c784
DA
4152012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
416
0a08eb21 417 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
418 strcasecmp if available.
419 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
420
fb7da12e
AS
4212012-06-25 Andreas Schwab <schwab@linux-m68k.org>
422
423 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
424 Avoid comma operator.
425 * menu.c (push_submenu_start, push_submenu_end)
426 (push_left_right_boundary, push_menu_pane): Likewise.
427 * msdos.c (dos_rawgetc): Likewise.
428
afa2ffd8
DA
4292012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
430
431 * xfns.c (xic_create_fontsetname): Remove redundant calls
432 to memset.
433
b3b4476b
PE
4342012-06-25 Paul Eggert <eggert@cs.ucla.edu>
435
4495ff38
PE
436 * gtkutil.c (get_utf8_string): Remove redundant assignment.
437 sprintf already null-terminates its output.
438
b3b4476b
PE
439 * xfns.c (x_window): Remove redundant cast.
440
b00876c9
DA
4412012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
442
443 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
444 `const char *' to `char *' to avoid compiler warning.
445
d188e26b
PE
4462012-06-24 Paul Eggert <eggert@cs.ucla.edu>
447
885d1d74
PE
448 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
449 instead of truncating it to 63 (admittedly a generous limit).
450
d188e26b
PE
451 * process.c: Fix spelling and caps in comments.
452
e2f560b1
DN
4532012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
454
e86db54b 455 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
456 * sysdep.c (setpgrp): Remove definition, not used in this file.
457
7583a3a1
JB
4582012-06-24 Juanma Barranquero <lekktu@gmail.com>
459
460 * makefile.w32-in: Update dependencies.
461
696056c2
EZ
4622012-06-24 Eli Zaretskii <eliz@gnu.org>
463
464 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
465 (SYSTIME_H): Add nt/inc/sys/time.h.
466
467 * systime.h [WINDOWSNT]: Include sys/time.h.
468
469 * s/ms-w32.h (struct timespec): Definition moved from
470 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
471
845ca893
PE
4722012-06-24 Paul Eggert <eggert@cs.ucla.edu>
473
474 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
475 * buffer.h (buffer_slot_type_mismatch):
476 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
477 * eval.c (unwind_to_catch):
478 * image.c (my_png_error, my_error_exit):
479 * keyboard.c (quit_throw_to_read_char, user_error)
480 (Fexit_recursive_edit, Fabort_recursive_edit):
481 * lisp.h (die, args_out_of_range, args_out_of_range_3)
482 (wrong_type_argument, buffer_overflow, __executable_start)
483 (memory_full, buffer_memory_full, string_overflow, Fthrow)
484 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
485 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
486 (fatal):
487 (child_setup) [!DOS_NT]:
488 * lread.c (end_of_file_error, invalid_syntax):
489 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
490 * puresize.h (pure_write_error):
491 * search.c (matcher_overflow):
492 * sound.c (sound_perror, alsa_sound_perror):
493 * sysdep.c, syssignal.h (croak):
494 * term.c (maybe_fatal, vfatal):
495 * textprop.c (text_read_only):
496 * undo.c (user_error):
497 * unexmacosx.c (unexec_error):
498 * xterm.c (x_ins_del_lines, x_delete_glyphs):
499 Use _Noreturn rather than NO_RETURN.
500 No need for separate decl merely because of _Noreturn.
501 * sound.c (sound_warning, parse_sound):
502 Remove unnecessary forward decls.
503
f1dd8073
PE
5042012-06-24 Paul Eggert <eggert@cs.ucla.edu>
505
506 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
507 * lisp.h (WAIT_READING_MAX): New macro.
508 * dispnew.c (Fsleep_for, sit_for):
509 * keyboard.c (kbd_buffer_get_event):
510 * process.c (Faccept_process_output):
511 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
512 This improves on the previous patch, which introduced a bug
513 when time_t is unsigned and as wide as intmax_t.
514 See <http://bugs.gnu.org/9000#51>.
515
b82c1755
EZ
5162012-06-23 Eli Zaretskii <eliz@gnu.org>
517
518 * dispnew.c (sit_for, Fsleep_for):
519 * keyboard.c (kbd_buffer_get_event):
520 * process.c (Faccept_process_output): Avoid compiler warnings when
521 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
522
ca300656
JB
5232012-06-23 Juanma Barranquero <lekktu@gmail.com>
524
049ec95b
JB
525 * makefile.w32-in: Update dependencies.
526
ca300656
JB
527 * w32.c (ltime): Add return type and declare static.
528 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
529
db7b8d06
PE
5302012-06-23 Paul Eggert <eggert@cs.ucla.edu>
531
532 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
533 Privately reported by Herbert J. Skuhra.
534 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
535 All uses changed.
536 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
537 not make_lisp_timeval, when the argument is of type EMACS_TIME.
538
0bd8297f
EZ
5392012-06-23 Eli Zaretskii <eliz@gnu.org>
540
96512555
EZ
541 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
542 last argument of make_unibyte_string.
543
0bd8297f
EZ
544 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
545 language ID in the event parameters.
546
547 * w32term.c (w32_read_socket): Put the new keyboard codepage into
548 event.code, not the obscure "character set ID".
549
63def6b6
CY
5502012-06-23 Chong Yidong <cyd@gnu.org>
551
552 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
553
e8a02204
EZ
5542012-06-23 Eli Zaretskii <eliz@gnu.org>
555
388cdec0
EZ
556 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
557 * w32.c (fdutimens): New function.
558
559 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
560
561 * s/ms-w32.h (pselect): Redirect to sys_select.
562
563 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
564
e8a02204
EZ
565 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
566 in the logic of incrementing and decrementing the value of
567 use_relocatable_buffers.
568
d054f3fb
PE
5692012-06-23 Paul Eggert <eggert@cs.ucla.edu>
570
571 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
572 Privately reported by Herbert J. Skuhra.
573 [__FreeBSD__]: Remove "*/" typo after "#include".
574 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
575 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
576 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
577 Don't assume EMACS_TIME and struct timeval are the same type.
578
d35af63c
PE
5792012-06-22 Paul Eggert <eggert@cs.ucla.edu>
580
581 Support higher-resolution time stamps (Bug#9000).
582 The time stamps are only nanosecond-resolution at the C level,
583 since that's the best that any real-world system supports now.
584 But they are picosecond-resolution at the Lisp level, as that's
585 easy, and leaves room for future OS improvements.
586
587 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
588 (LIBES): Use it.
589
590 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
591 Don't get current time unless it's needed.
592
593 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
594 now provides it if it's absent.
595 (start_atimer): Port to higher-res time stamps.
596 Check for time stamp overflow. Don't get current time more
597 often than is needed.
598
599 * buffer.h (struct buffer): Buffer modtime now has high resolution.
600 Include systime.h, not time.h.
601 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
602
603 * dired.c: Include stat-time.h.
604 (Ffile-attributes): File times now have higher resolution.
605
606 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
607 (struct image): Timestamp now has higher resolution.
608
609 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
610 has at least microseconds now. All uses removed.
611 (update_frame, update_single_window, update_window, update_frame_1)
612 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
613
614 * editfns.c (time_overflow): Now extern.
615 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
616 (float-time, Fformat_time_string, Fcurrent_time_string)
617 (Fcurrent_time_zone): Accept and generate higher-resolution
618 time stamps.
619 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
620 (decode_time_components, lisp_seconds_argument): New functions.
621 (make_time): Now static.
622 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
623 Report an error if the time is invalid, rather than having the caller
624 do that.
625
626 * fileio.c: Include <stat-time.h>
627 (Fcopy_file): Copy higher-resolution time stamps.
628 Prefer to set the time stamp via a file descriptor if that works.
629 (Fset_file_times, Finsert_file_contents, Fwrite_region)
630 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
631 (Fvisited_file_modtime, Fset_visited_file_modtime):
632 Support higher-resolution time stamps.
633
634 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
635
636 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
637
638 * image.c (prepare_image_for_display, clear_image_cache)
639 (lookup_image): Port to higer-resolution time stamps.
640
641 * keyboard.c (start_polling, bind_polling_period):
642 Check for time stamp overflow.
643 (read_char, kbd_buffer_get_event, timer_start_idle)
644 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
645 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
646 Port to higher-resolution time stamps. Do not assume time_t is signed.
647 (decode_timer): New function. Timers are now vectors of length 9,
648 not 8, to accommodate the picosecond component.
649 (timer_check_2): Use it.
650
651 * nsterm.m (select_timeout, timeval_subtract): Remove.
652 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
653 as they're a bit more accurate and handle overflow better.
654 (ns_select): Change prototype to be compatible with pselect.
655 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
656 * nsterm.h (ns_select): Adjust prototype.
657
658 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
659 us-resolution time stamps.
660 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
661
662 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
663
664 * lisp.h (time_overflow): New decl.
665 (wait_reading_process_output): First arg is now intmax_t, not int,
666 to accommodate larger waits.
667
668 * process.h (struct Lisp_Process.read_output_delay):
669 Now counts nanoseconds, not microseconds.
670 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
671 EMACS_HAS_USECS.
672 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
673 (wait_reading_process_output):
674 Port to ns-resolution time stamps.
675 (Faccept_process_output, wait_reading_process_output):
676 Check for time stamp overflow. Do not assume time_t is signed.
677 (select_wrapper): Remove; we now use pselect.
678 (Fprocess_attributes): Now generates ns-resolution time stamps.
679
680 * sysdep.c: Include utimens.h. Don't include utime.h
681 or worry about struct utimbuf; gnulib does that for us now.
682 (gettimeofday): Remove; gnulib provides a substitute.
683 (make_timeval): New function.
684 (set_file_times): Now sets ns-resolution time stamps.
685 New arg FD; all uses changed.
686 (time_from_jiffies, ltime_from_jiffies, get_up_time)
687 (system_process_attributes):
688 Now returns ns-resolution time stamp. All uses changed.
689 Check for time stamp overflow.
690
691 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
692 provides a substitute now.
693
694 * systime.h: Include timespec.h rather than sys/time.h and time.h,
695 since it guarantees struct timespec.
696 (EMACS_TIME): Now struct timespec, so that we can support
697 ns-resolution time stamps.
698 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
699 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
700 (EMACS_USECS): Remove.
701 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
702 so multiply the arg by 1000 before storing it.
703 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
704 New macros.
705 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
706 Port to ns-resolution time stamps.
707 (EMACS_TIME_NEG_P): Remove; replaced by....
708 (EMACS_TIME_SIGN): New macro.
709 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
710 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
711 (set_file_times, make_time, lisp_time_argument): Adjust signature.
712 (make_timeval, make_lisp_time, decode_time_components): New decls.
713 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
714 that it mishandled time_t overflow. You can't compare by subtracting!
715 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
716 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
717
718 * term.c: Include <sys/time.h>.
719 (timeval_to_Time): New function, for proper overflow wraparound.
720 (term_mouse_position, term_mouse_click): Use it.
721
722 * undo.c (record_first_change): Support higher-resolution time stamps
723 in the undo buffer.
724 (Fprimitive_undo): Use them when restoring time stamps.
725
726 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
727 (w32_get_internal_run_time):
728 Port to higher-resolution Emacs time stamps.
729 (ltime): Now accepts single 64-bit integer, as that's more convenient
730 for callers.
731
732 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
733
734 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
735 for compatibility with pselect. Support ns-resolution time stamps.
736
737 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
738
739 * xselect.c (wait_for_property_change, x_get_foreign_selection):
740 Check for time stamp overflow, and support ns-resolution time stamps.
741
742 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
743 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
744 (timeval_subtract): Remove; no longer needed.
745 (XTflash, XTring_bell, x_wait_for_event):
746 Port to ns-resolution time stamps. Don't assume time_t is signed.
747
b6a92dfe
CY
7482012-06-22 Chong Yidong <cyd@gnu.org>
749
750 * xdisp.c (x_consider_frame_title): Revert last change.
751
d251c37c
EZ
7522012-06-22 Eli Zaretskii <eliz@gnu.org>
753
754 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
755 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
756 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
757 staticidx goes up to 1597 out of 1600 = 0x640.)
758
f10deafb
PE
7592012-06-20 Paul Eggert <eggert@cs.ucla.edu>
760
761 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
762 Otherwise, the umask might be mistakenly 0 while handling input signals.
763
ec6de1e2
SM
7642012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
765
766 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
767
28be1ada
DA
7682012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
769
770 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
771 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
772 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
773 access to `contents' member of Lisp_Vector objects with AREF and ASET
774 where appropriate.
775
c6bf3022
CY
7762012-06-19 Chong Yidong <cyd@gnu.org>
777
778 * frame.c (delete_frame): When selecting a frame on a different
779 text terminal, do not alter the terminal's top-frame.
780
781 * xdisp.c (format_mode_line_unwind_data): Record the target
782 frame's selected window and its terminal's top-frame.
783 (unwind_format_mode_line): Restore them.
784 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
785 Callers changed.
786 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
787 since tty frames can be explicitly named.
788 (prepare_menu_bars): Likewise.
789
790 * term.c (Ftty_top_frame): New function.
791
defd4196
PE
7922012-06-18 Paul Eggert <eggert@cs.ucla.edu>
793
794 Port byte-code-meter to modern targets.
795 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
796 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 797 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
798 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
799 (METER_1, METER_2): Simplify.
800
1053a871
SM
8012012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
802
803 * data.c (Fdefalias): Return `symbol' (bug#11686).
804
b7e8d081
MR
8052012-06-18 Martin Rudalics <rudalics@gmx.at>
806
807 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
808 gets killed during executing of this function (Bug#11665).
809 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
810 (Vkill_buffer_query_functions): In doc-string say that functions
811 run by this hook should not change the current buffer.
812
7ea2b339
PE
8132012-06-18 Paul Eggert <eggert@cs.ucla.edu>
814
815 Fix recently-introduced process.c problems found by static checking.
816 * process.c (write_queue_push, write_queue_pop, send_process):
817 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
818 (write_queue_pop): Fix pointer signedness problem.
819 (send_process): Remove unused local.
820
96a313a1
CY
8212012-06-17 Chong Yidong <cyd@gnu.org>
822
823 * xdisp.c (redisplay_internal): No need to redisplay terminal
824 frames that are not on top.
825
20ca2e94
TN
8262012-06-17 Troels Nielsen <bn.troels@gmail.com>
827
828 * process.c (make_process): Initialize write_queue.
829 (write_queue_push, write_queue_pop): New functions.
830 (send_process): Use them to maintain correct ordering of process
831 writes (Bug#10815).
832
9a900ca9
PE
8332012-06-17 Paul Eggert <eggert@cs.ucla.edu>
834
310fbfa8
PE
835 * lisp.h (eassert): Assume C89 or later.
836 This removes the need for CHECK.
837 (CHECK): Remove. Its comments about always evaluating its
838 argument were confusing, as 'eassert' typically does not evaluate
839 its argument.
840
27bb1ca4
PE
841 * coding.c (produce_chars): Use ptrdiff_t, not int.
842
9a900ca9
PE
843 * xterm.c (x_draw_underwave): Check for integer overflow.
844 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
845
41b7f8bc 8462012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
847
848 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
849 referenced (Bug#11583).
850
9b0e3eba
AA
8512012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
852
853 Implement wave-style variant of underlining.
854 * dispextern.h (face_underline_type): New enum.
855 (face): Add field for underline type.
856 * nsterm.m (ns_draw_underwave): New function.
857 (ns_draw_text_decoration): Use it.
858 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
859 New functions.
860 (x_draw_glyph_string): Use them.
861 * xfaces.c (Qline, Qwave): New Lisp objects.
862 (check_lface_attrs, merge_face_ref)
1053a871
SM
863 (Finternal_set_lisp_face_attribute, realize_x_face):
864 Handle wave-style underline face attributes.
9b0e3eba
AA
865 * xterm.c (x_draw_underwave): New function.
866 (x_draw_glyph_string): Use it.
867
0fb52f11
JB
8682012-06-16 Juanma Barranquero <lekktu@gmail.com>
869
870 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
871 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
872 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
873 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
874 ($(BLD)/w32select.$(O)): Update dependencies.
875
e5560ff7
AS
8762012-06-16 Andreas Schwab <schwab@linux-m68k.org>
877
878 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
879 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
880 * character.c (_fetch_multibyte_char_p): Remove.
881 * alloc.c: Include "character.h" before "buffer.h".
882 * bidi.c: Likewise.
883 * buffer.c: Likewise.
884 * bytecode.c: Likewise.
885 * callint.c: Likewise.
886 * callproc.c: Likewise.
887 * casefiddle.c: Likewise.
888 * casetab.c: Likewise.
889 * category.c: Likewise.
890 * cmds.c: Likewise.
891 * coding.c: Likewise.
892 * composite.c: Likewise.
893 * dired.c: Likewise.
894 * dispnew.c: Likewise.
895 * doc.c: Likewise.
896 * dosfns.c: Likewise.
897 * editfns.c: Likewise.
898 * emacs.c: Likewise.
899 * fileio.c: Likewise.
900 * filelock.c: Likewise.
901 * font.c: Likewise.
902 * fontset.c: Likewise.
903 * fringe.c: Likewise.
904 * indent.c: Likewise.
905 * insdel.c: Likewise.
906 * intervals.c: Likewise.
907 * keyboard.c: Likewise.
908 * keymap.c: Likewise.
909 * lread.c: Likewise.
910 * macros.c: Likewise.
911 * marker.c: Likewise.
912 * minibuf.c: Likewise.
913 * nsfns.m: Likewise.
914 * nsmenu.m: Likewise.
915 * print.c: Likewise.
916 * process.c: Likewise.
917 * regex.c: Likewise.
918 * region-cache.c: Likewise.
919 * search.c: Likewise.
920 * syntax.c: Likewise.
921 * term.c: Likewise.
922 * textprop.c: Likewise.
923 * undo.c: Likewise.
924 * unexsol.c: Likewise.
925 * w16select.c: Likewise.
926 * w32fns.c: Likewise.
927 * w32menu.c: Likewise.
928 * window.c: Likewise.
929 * xdisp.c: Likewise.
930 * xfns.c: Likewise.
931 * xmenu.c: Likewise.
932 * xml.c: Likewise.
933 * xselect.c: Likewise.
934
2f07e6af
EZ
9352012-06-16 Eli Zaretskii <eliz@gnu.org>
936
1053a871
SM
937 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
938 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 939 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
940 row.
941 (handle_face_prop): Use chunk-relative overlay string index when
942 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
943 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
944 the rightmost. (Bug#11720)
2f07e6af 945
29b83cec
AS
9462012-06-16 Andreas Schwab <schwab@linux-m68k.org>
947
948 * category.h (CHAR_HAS_CATEGORY): Define as inline.
949 (CATEGORY_MEMBER): Enforce 1/0 value.
950 * category.c (_temp_category_set): Remove.
951
4c5501e9
EZ
9522012-06-16 Eli Zaretskii <eliz@gnu.org>
953
954 * window.c (Fdelete_other_windows_internal)
955 (Fdelete_window_internal): Don't access frame's mouse highlight
956 info of the initial frame. (Bug#11677)
957
2b570124
PE
9582012-06-14 Paul Eggert <eggert@cs.ucla.edu>
959
e93864f9
PE
960 * .gdbinit (xgetint): Fix recently-introduced paren typo.
961 Assume USE_2_TAGS_FOR_INTS.
962 (xreload): Adjust $tagmask width to match recent lisp.h change.
963
2b570124
PE
964 Simplify lisp.h in minor ways that should not affect code.
965 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
966 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
967 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
968 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
969 (INTTYPEBITS): New macro, for clarity.
970 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
971 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
972 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
973 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
974 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
975
81755f69
JB
9762012-06-13 Juanma Barranquero <lekktu@gmail.com>
977
978 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
979
16192a57
GM
9802012-06-13 Glenn Morris <rgm@gnu.org>
981
982 * s/bsd-common.h (BSD4_3):
983 * s/usg5-4-common.h (USG5_4): No longer define; unused.
984
646b5f55
AS
9852012-06-13 Andreas Schwab <schwab@linux-m68k.org>
986
987 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
988 instead of union.
989 (XLI, XIL): Define.
1053a871
SM
990 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
991 Use them.
992 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 993 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 994 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
995 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
996 * frame.c (delete_frame): Remove outdated comment.
997 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
998 USE_LISP_UNION_TYPE.
999 (Fw32_unregister_hot_key): Likewise.
1000 (Fw32_toggle_lock_key): Likewise.
1001 * w32menu.c (add_menu_item): Likewise.
1002 (w32_menu_display_help): Use XIL instead of checking
1003 USE_LISP_UNION_TYPE.
1004 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1005 (init_heap): Likewise.
1006 * w32term.c (w32_read_socket): Update comment.
1007
1d3823c9
GM
10082012-06-13 Glenn Morris <rgm@gnu.org>
1009
c62ff706
GM
1010 * s/usg5-4-common.h, src/s/unixware.h:
1011 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1012
1d3823c9
GM
1013 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1014
bfe3e0a2
PE
10152012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1016
1017 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1018 * alloc.c (make_number) [!defined make_number]:
1019 Remove, as lisp.h always defines this now.
1020 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1021 (roundup_size): Verify that it is a power of 2.
1022 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1023 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1024 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1025 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1026 USE_LSB_TAG now is always defined to be either 0 or 1.
1027 All uses changed.
1028 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1029 code works fine either way, and efficiency is not a concern here,
1030 as the union type is for debugging, not for production.
1031 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1032 Use an inline function on all platforms when using the union type,
1033 since this is simpler and 'static inline' can be used portably
1034 within Emacs now.
1035 (LISP_INITIALLY_ZERO): New macro.
1036 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1037 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1038
45fa9c0f
GM
10392012-06-12 Glenn Morris <rgm@gnu.org>
1040
b4492cba
GM
1041 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1042
1043 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1044
45fa9c0f
GM
1045 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1046 Move BROKEN_SIGIO to configure.
1047
1048 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1049 Move NO_TERMIO to configure.
1050
0e25d334
CY
10512012-06-12 Chong Yidong <cyd@gnu.org>
1052
1053 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1054 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1055 MagickExportImagePixels is undefined.
1056
43682bb6
PE
10572012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1058
1059 * image.c (imagemagick_load_image): Remove unused label.
1060
a9be7d2b
GM
10612012-06-11 Glenn Morris <rgm@gnu.org>
1062
1063 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1064 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1065 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1066 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1067
3017f87f
SM
10682012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1069
1070 * alloc.c (make_byte_code): New function.
1071 (Fmake_byte_code): Use it. Don't purify here.
1072 * lread.c (read1): Use it as well to avoid extra allocation.
1073
1b9b4cf4
CY
10742012-06-11 Chong Yidong <cyd@gnu.org>
1075
1076 * image.c (imagemagick_load_image): Implement transparency.
1077
95988fcf
AS
10782012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1079
1080 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1081 account for preceding backslashes. (Bug#11663)
1082
cd4eb164
CY
10832012-06-09 Chong Yidong <cyd@gnu.org>
1084
1085 * term.c: Support italics in capable terminals (Bug#9652).
1086 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1087 (turn_on_face): Output using TS_enter_italic_mode if available.
1088 Don't handle unused blinking and alt-charset cases.
1089 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1090 and tty_alt_charset_p cases.
1091 (tty_capable_p, init_tty): Support italics.
1092
1093 * termchar.h (struct tty_display_info): Add field for italics.
1094 Remove unused blink field.
1095
1096 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1097 Handle slant.
1098
1099 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1100 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1101 tty_alt_charset_p. Add tty_italic_p.
1102
ff88beb8
MA
11032012-06-09 Michael Albinus <michael.albinus@gmx.de>
1104
1105 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1106 dbus_type_is_basic if available.
1107 (xd_extract_signed, xd_extract_unsigned): Rename from
1108 extract_signed and extract_unsigned, respectively. Adapt callers.
1109
44286096
CY
11102012-06-09 Chong Yidong <cyd@gnu.org>
1111
1682701f
CY
1112 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1113
44286096
CY
1114 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1115 case (Bug#9752).
1116
d86feb17
PE
11172012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1118
1119 * xdisp.c (vmessage): Treat frame message as multibyte.
1120 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1121 would generate the diagnostic "Making \302\247 buffer-local while
1122 let-bound!".
1123
d5c20fe8
EZ
11242012-06-08 Eli Zaretskii <eliz@gnu.org>
1125
1126 * dispnew.c (showing_window_margins_p): Undo last change, which
1127 was done due to an inadvertent commit.
1128 (adjust_frame_glyphs_for_frame_redisplay): Do call
1129 showing_window_margins_p.
1130
513749ee
SM
11312012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1132
1133 * eval.c (Fmake_var_non_special): New primitive.
1134 (syms_of_eval): Defsubr it.
1135 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1136
d4a8f5c1
JB
11372012-06-08 Juanma Barranquero <lekktu@gmail.com>
1138
1139 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1140 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1141
8bbbc977
EZ
11422012-06-08 Eli Zaretskii <eliz@gnu.org>
1143
1144 * alloc.c (allocate_vectorlike): Fix last change.
1145
f3372c87
DA
11462012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1147
1148 Block-based vector allocation of small vectors.
1149 * lisp.h (struct vectorlike_header): New field `nbytes',
1150 adjust comment accordingly.
1151 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1152 to denote vector blocks. Adjust users (live_vector_p,
1153 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1154 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1155 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1156 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1157 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1158 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1159 (roundup_size): New constant.
1160 (struct vector_block): New data type.
1161 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1162 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1163 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1164 (sweep_vectors): New functions.
1165 (allocate_vectorlike): Return `zero_vector' as the only vector of
1166 0 items. Allocate new vector from block if vector size is less than
1167 or equal to VBLOCK_BYTES_MAX.
1168 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1169 (init_alloc_once): Add call to init_vectors.
1170
4f18a4ed
SM
11712012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1172
1173 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1174
86f158bc
PE
11752012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1176
1177 * doprnt.c (doprnt): Truncate multibyte char correctly.
1178 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1179 would mishandle a string argument "Xc" if X was a multibyte
1180 character of length 2: it would truncate after X's first byte
1181 rather than including all of X.
1182
c5cfcbe0
CY
11832012-06-06 Chong Yidong <cyd@gnu.org>
1184
1185 * buffer.c (word_wrap): Doc fix.
1186
c05cf390
PE
11872012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1188
1189 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1190
0c3461de
GM
11912012-06-03 Glenn Morris <rgm@gnu.org>
1192
1193 * xdisp.c (tool-bar-style): Doc fix.
1194
c71232db
UM
11952012-06-03 Ulrich Müller <ulm@gentoo.org>
1196
1197 * Makefile.in (PAXCTL): Define.
1198 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1199 binary via PaX flags if the paxctl utility is available.
1200 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1201 Restore PaX flags to their default. (Bug#11398)
1202
383f7350
CY
12032012-06-03 Chong Yidong <cyd@gnu.org>
1204
1205 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1206 buffer (Bug#11226).
1207
5f2c76c6
CY
12082012-06-03 Chong Yidong <cyd@gnu.org>
1209
1210 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1211 (note_mode_line_or_margin_highlight): If there is no help echo,
1212 use mode-line-default-help-echo. Handle the case where the mouse
1213 position is past the end of the mode line string.
1214
1215 * buffer.c (buffer_local_value_1): New function, split from
1216 Fbuffer_local_value; can return Qunbound.
1217 (Fbuffer_local_value): Use it.
1218 (Vmode_line_format): Docstring tweaks.
1219
773d47f6
PE
12202012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1221
1222 * sysdep.c (system_process_attributes): Improve comment.
1223
f2d6a3df
SM
12242012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1225
1226 * keyboard.c: Export real-this-command to Elisp.
1227 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1228 and DEFVAR it. Update all users.
1229
63810350
PE
12302012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1231
7bd5c1f4
PE
1232 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1233
63810350
PE
1234 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1235 Convert pctcpu and pctmem to Lisp float properly.
1236 Let the compiler fold better, as 100.0/0x8000 is exact.
1237
a2821611
AS
12382012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1239
1240 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1241 cons_block.
1242
5fceba1d
PE
12432012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1244
1245 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1246
c98ff5dd
DA
12472012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1248
1249 For a 'struct window', replace some Lisp_Object fields to
1250 bitfields where appropriate, remove unused fields.
1251 * window.h (struct window): Remove unused 'last_mark_x' and
1252 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1253 change it's type from Lisp_Object to bitfield.
1254 Change type of 'force_start', 'optional_new_start',
1255 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1256 fields from Lisp_Object to bitfield. Adjust users accordingly.
1257
ca34e0be
PE
12582012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1259
1260 Pacify gcc -Wdouble-precision when using Xaw.
1261 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1262 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1263 Use 'float' consistently, rather than 'float' in most places
1264 and 'double' in a couple of places.
1265
efc00ab1 12662012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1267
1268 * xdisp.c (handle_stop): Detect whether we have overlay strings
1269 loaded by testing it->current.overlay_string_index to be
1270 non-negative, instead of checking whether n_overlay_strings is
1271 positive. (Bug#11587)
1272
efc00ab1 12732012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1274
1275 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1276
1277 * doc.c (Fsubstitute_command_keys): Doc fix.
1278
efc00ab1 12792012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1280
1281 * search.c (search_buffer): Remove calls to
1282 r_alloc_inhibit_buffer_relocation, as it is now called by
1283 maybe_unify_char, which was the cause of relocation of buffer text
1284 in bug#11519.
1285
efc00ab1 12862012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1287
1288 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1289 for the duration of call to load_charset, to avoid problems with
1290 callers of maybe_unify_char that access buffer text through C
1291 pointers.
1292
1293 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1294 decrement the inhibition flag, instead of just setting or
1295 resetting it.
1296
ba93a187
PE
12972012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1298
1299 Remove obsolete '#define static' cruft.
1300 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1301 This #undef was "temporary" in 2000; it is no longer needed
1302 now that '#define static' has gone away.
1303 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1304 (gray_bitmap_bits): Remove; no longer needed.
1305 All uses replaced with definiens.
1306 * xterm.c: Include "bitmaps/gray.xbm".
1307
9e4bf381
PE
13082012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1309
1310 Clean up __executable_start, monstartup when --enable-profiling.
1311 The following changes affect the code only when profiling.
1312 * dispnew.c (__executable_start): Rename from safe_bcopy.
1313 Define only on platforms that need it.
1314 * emacs.c: Include <sys/gmon.h> when profiling.
1315 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1316 (__executable_start): Remove decl, since lisp.h does it now.
1317 (safe_bcopy): Remove decl; no longer has that name.
1318 (main): Coalesce #if into single bit of code, for simplicity.
1319 Cast pointers to uintptr_t, since standard libraries want integers
1320 and not pointers.
1321 * lisp.h (__executable_start): New decl.
1322
32d72c2f
GM
13232012-05-31 Glenn Morris <rgm@gnu.org>
1324
1325 * image.c (Fimagemagick_types): Doc fix.
1326
baac5bc7
JM
13272012-05-30 Jim Meyering <meyering@redhat.com>
1328
1329 * callproc.c (Fcall_process_region): Include directory component
1330 in mkstemp error message (Bug#11586).
1331
72cb32cf
PE
13322012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1333
1334 * alloc.c, lisp.h (make_pure_vector): Now static.
1335
61b108cc
SM
13362012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1337
1338 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1339 Move to byte-run.el.
1340 (Fautoload): Do the hash-doc more carefully.
1341 * data.c (Fdefalias): Purify definition, except for keymaps.
1342 (Qdefun): Move from eval.c.
1343 * lisp.h (Qdefun): Remove.
1344 * lread.c (read1): Tiny simplification.
1345
471fe23d
TN
13462012-05-29 Troels Nielsen <bn.troels@gmail.com>
1347
934f3f58 1348 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1349 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1350 Bug#9642, but explicitly check that the buffer the overlay would
1351 be moved to is live and rearrange lines to make sure that errors
1352 will not put the overlay in an inconsistent state.
1353 (Fdelete_overlay): Cosmetics.
1354
85d0efd1
EZ
13552012-05-28 Eli Zaretskii <eliz@gnu.org>
1356
1357 * w32term.c (my_bring_window_to_top): New function.
1358 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1359 could be different from the original one.
1360 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1361 (Bug#11513)
1362
1363 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1364 by calling BringWindowToTop.
1365
1366 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1367 (WM_EMACS_END): Increase by one.
1368
da92a98c
PE
13692012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1370
1371 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1372 This avoids undefined behavior that might cause the eassert
1373 to not catch an out-of-range value.
1374
74d1f848
JB
13752012-05-28 Juanma Barranquero <lekktu@gmail.com>
1376
1377 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1378 Update dependencies.
1379
9e1a06fc
EZ
13802012-05-27 Eli Zaretskii <eliz@gnu.org>
1381
1382 * bidi.c (bidi_mirror_char): Fix last change.
1383
f3dd7312
AS
13842012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1385
1386 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1387 when referring to sectname field in printf format.
1388
81899c91
PE
13892012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1390
57b81a9f
PE
1391 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1392 Only r_alloc_inhibit_buffer_relocation needed to be added;
1393 the others were already declared.
1394
81899c91
PE
1395 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1396 before checking whether it's out of range. Put the check inside
1397 eassert. See
1398 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1399
33017faf 14002012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1401
1402 * callproc.c (Fcall_process): Restore a line that was accidentally
1403 commented out in the 2011-02-13 change (bug#11547).
1404
33017faf 14052012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1406
1407 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1408 defined on ralloc.c.
1409
1410 * buffer.c [REL_ALLOC]: Remove prototypes of
1411 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1412 they are now on lisp.h.
1413
1414 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1415
1416 * search.c (search_buffer): Use it to inhibit relocation of buffer
1417 text while re_search_2 is doing its job, because re_search_2 is
1418 passed C pointers to buffer text. (Bug#11519)
1419
23415acf
EZ
1420 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1421 Update value to 24.
1422
44e27368
EZ
1423 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1424 state after an additional call to move_it_in_display_line_to, keep
1425 the values of it->max_ascent and it->max_descent found for the
1426 entire line.
1427 (pos_visible_p): Revert the comparison against bottom_y to what it
1428 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1429 (Bug#11464)
1430
c1892f11
PE
14312012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1432
1433 Fix coding-related core dumps with gcc -ftrapv.
1434 The code was computing A - B, where A and B are pointers, and B is
1435 random garbage. This can lead to core dumps on platforms that
1436 have special pointer registers, and it also leads to core dumps on
1437 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1438 A - B only when B is initialized properly.
1439 * coding.c (coding_set_source, coding_set_destination): Return void.
1440 (coding_change_source, coding_change_destinations): New functions,
1441 with the old behaviors of coding_set_source and coding_set_destination.
1442 All callers that need an offset changed to use these new functions.
1443
eb7afdad
GM
14442012-05-26 Glenn Morris <rgm@gnu.org>
1445
1446 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1447
f12fdf02
EZ
14482012-05-26 Eli Zaretskii <eliz@gnu.org>
1449
53a63be6 1450 Extend mouse support on W32 text-mode console.
61b108cc
SM
1451 * xdisp.c (draw_row_with_mouse_face):
1452 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1453
eb3f6f01 1454 * w32console.c: Include window.h.
61b108cc
SM
1455 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1456 New functions.
eb3f6f01
EZ
1457 (initialize_w32_display): Initialize mouse-highlight data.
1458
53a63be6
EZ
1459 * w32inevt.c: Include termchar.h and window.h.
1460 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1461 moves, call note_mouse_highlight. If help_echo changed, call
1462 gen_help_event to produce help-echo message in the echo area.
1463 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1464 highlight info.
1465
4cfd81f6
PE
14662012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1467
1468 * lread.c (read1): Simplify slightly to avoid an overflow warning
1469 with GCC 4.7.0 on x86-64.
1470
4446092a
EZ
14712012-05-26 Eli Zaretskii <eliz@gnu.org>
1472
1473 * bidi.c (bidi_mirror_char): Revert last change: an int is
1474 definitely wide enough here.
1475
42b2a986 14762012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1477
42b2a986 1478 Fix integer width and related bugs (Bug#9874).
eb106a49 1479 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1480 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1481 (string_bytes, check_sblock, allocate_string_data):
1482 (compact_small_strings, Fmake_bool_vector, make_string)
1483 (make_unibyte_string, make_multibyte_string)
1484 (make_string_from_bytes, make_specified_string)
1485 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1486 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1487 (mark_vectorlike):
1488 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1489 (allocate_pseudovector):
1490 Use int, not EMACS_INT, where int is wide enough.
1491 (inhibit_garbage_collection, Fgarbage_collect):
1492 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1493 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1494 int might not be wide enough.
1495 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1496 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1497 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1498 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1499 (bidi_level_of_next_char, bidi_move_to_visually_next):
1500 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1501 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1502 (Fkill_buffer, Fset_buffer_major_mode)
1503 (advance_to_char_boundary, Fbuffer_swap_text)
1504 (Fset_buffer_multibyte, overlays_at, overlays_in)
1505 (overlay_touches_p, struct sortvec, record_overlay_string)
1506 (overlay_strings, recenter_overlay_lists)
1507 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1508 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1509 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1510 (Foverlay_recenter, last_overlay_modification_hooks_used)
1511 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1513 (validate_region): Omit unnecessary test for b <= e,
1514 since that's guaranteed by the previous test.
d311d28c
PE
1515 (adjust_overlays_for_delete): Avoid pos + length overflow.
1516 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1517 (report_overlay_modification):
1518 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1519 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1520 Omit pointer cast, which isn't needed anyway, and doesn't work
1521 after the EMACS_INT -> ptrdiff_t change.
02481186 1522 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1523 * buffer.h: Adjust decls to match defn changes elsewhere.
1524 (struct buffer_text, struct buffer):
1525 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1526 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1527 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1528 not int, to avoid needless 32-bit limit on 64-bit hosts.
1529 (exec_byte_code): Use tighter memory-full test, one that checks
1530 for alloca overflow. Don't compute the address of the object just
1531 before an array, as that's not portable. Use EMACS_INT, not
1532 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1533 * callint.c (Fcall_interactively):
1534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1535 * callproc.c (call_process_kill, Fcall_process):
1536 Don't assume pid_t fits into an Emacs fixnum.
1537 (call_process_cleanup, Fcall_process, child_setup):
1538 Don't assume pid_t fits into int.
1539 (call_process_cleanup, Fcall_process, delete_temp_file)
1540 (Fcall_process_region):
1541 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1542 (Fcall_process): Simplify handling of volatile integers.
1543 Use int, not EMACS_INT, where int will do.
1544 * casefiddle.c (casify_object, casify_region, operate_on_word)
1545 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1547 (casify_object): Avoid integer overflow when overallocating buffer.
1548 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1549 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1550 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1551 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1552 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1553 integers are now checked earlier. All uses replaced with XINT.
1554 (ccl_driver):
1555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1556 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1557 (ccl_driver, Fregister_code_conversion_map):
1558 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1559 (resolve_symbol_ccl_program): Check that vector header is in range.
1560 Always copy the vector, so that we can check its contents reliably
1561 now rather than having to recheck each instruction as it's being
1562 executed. Check that vector words fit in 'int'.
1563 (ccl_get_compiled_code, Fregister_ccl_program)
1564 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1565 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1566 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1567 contents are in range.
1568 (Fccl_execute_on_string): Check that status is in range.
1569 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1570 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1571 Accept and return EMACS_INT, not int, because callers can pass values
1572 out of 'int' range.
1573 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1574 (multibyte_chars_in_text, parse_str_as_multibyte)
1575 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1576 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1577 (string_escape_byte8, Fget_byte):
1578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1579 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1580 avoid mishandling large integers.
1581 * character.h: Adjust decls to match defn changes elsewhere.
1582 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1583 (Ffind_charset_region):
1584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1585 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1586 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1587 Don't assume fixnum fits in int.
d311d28c
PE
1588 (load_charset_map_from_vector, Fmap_charset_chars):
1589 Remove now-unnecessary CHECK_NATNUMs.
1590 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1591 Don't rely on undefined behavior with signed left shift overflow.
1592 Don't assume unsigned int fits into fixnum, or that fixnum fits
1593 into unsigned int. Don't require max_code to be a valid fixnum;
1594 that's not true for gb10830 4-byte on a 32-bit host. Allow
1595 invalid_code to be a cons, for the same reason. Require code_offset
1596 to be a character. Avoid int overflow if max_char is close
1597 to INT_MAX.
1598 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1599 this is intended anyway and avoids some undefined behavior.
1600 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1601 INDEX_TO_CODE_POINT, as that's what it expects.
1602 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1603 * charset.h (DECODE_CHAR): Return int, not unsigned;
1604 this is what was intended anyway, and it avoids undefined behavior.
1605 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1606 integer-overflow issues.
1607 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1608 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1609 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1610 * chartab.c (Fmake_char_table, Fset_char_table_range)
1611 (uniprop_get_decoder, uniprop_get_encoder):
1612 Don't assume fixnum fits in int.
1613 * cmds.c (move_point): New function, that does the gist of
1614 Fforward_char and Fbackward_char, but does so while checking
1615 for integer overflow more accurately.
c96e5d6a 1616 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1617 (Fforward_line, Fend_of_line, internal_self_insert)
1618 (internal_self_insert):
1619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1620 Fix a FIXME, by checking for integer overflow when calculating
1621 target_clm and actual_clm.
1622 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1623 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1624 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1625 (coding_alloc_by_making_gap, alloc_destination)
1626 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1627 (encode_coding_utf_16, detect_coding_emacs_mule)
1628 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1629 (detect_coding_iso_2022, decode_coding_iso_2022)
1630 (encode_invocation_designation, encode_designation_at_bol)
1631 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1632 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1633 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1634 (encode_coding_ccl, encode_coding_raw_text)
1635 (detect_coding_charset, decode_coding_charset)
1636 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1637 (produce_composition, produce_charset, produce_annotation)
1638 (decode_coding, handle_composition_annotation)
1639 (handle_charset_annotation, consume_chars, decode_coding_gap)
1640 (decode_coding_object, encode_coding_object, detect_coding_system)
1641 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1642 (code_convert_region, code_convert_string)
8f50130c
PE
1643 (Fdefine_coding_system_internal)
1644 (coding_set_source, coding_set_destination):
d311d28c
PE
1645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1646 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1647 (Fdefine_coding_system_internal):
1648 Don't assume fixnums fit in int.
1649 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1650 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1651 (Funencodable_char_position, Fcheck_coding_systems_region)
1652 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1653 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1654 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1655 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1656 Don't access memory outside of the args array.
d311d28c 1657 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1658 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1659 result of ENCODE_CHAR.
d311d28c
PE
1660 * coding.h: Adjust decls to match defn changes elsewhere.
1661 (struct coding_system):
1662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1663 * composite.c (get_composition_id, find_composition)
1664 (run_composition_function, update_compositions)
1665 (compose_text, composition_gstring_put_cache)
1666 (composition_gstring_p, composition_gstring_width)
1667 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1668 (composition_compute_stop_pos, composition_reseat_it)
1669 (composition_update_it, struct position_record)
1670 (find_automatic_composition, composition_adjust_point)
1671 (Fcomposition_get_gstring, Ffind_composition_internal):
1672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1673 (update_compositions):
1674 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1675 * composite.h: Adjust decls to match defn changes elsewhere.
1676 (struct composition):
1677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1678 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1679 Do not attempt to compute the address of the object just before a
1680 buffer; this is not portable.
1681 (Faref, Faset):
1682 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1683 (Faset): Use int, not EMACS_INT, where int is wide enough.
1684 (Fstring_to_number): Don't assume fixnums fit in int.
1685 (Frem): Don't assume arg is nonnegative.
1686 * dbusbind.c (xd_append_arg): Check for integers out of range.
1687 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1688 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1689 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1690 (xd_get_connection_references): Return ptrdiff_t, not int.
1691 All uses changed.
1692 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1693 (xd_read_message_1):
1694 Use int, not unsigned, where the dbus API uses int.
1695 (Fdbus_message_internal): Don't overflow mtype.
1696 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1697 * dired.c (directory_files_internal, file_name_completion, scmp)
1698 (file_name_completion_stat):
1699 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1700 (file_name_completion): Don't overflow matchcount.
1701 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1702 * dispextern.h: Adjust decls to match defn changes elsewhere.
1703 (struct text_pos, struct glyph, struct bidi_saved_info)
1704 (struct bidi_string_data, struct bidi_it, struct composition_it)
1705 (struct it):
1706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1707 (struct display_pos, struct composition_it, struct it):
1708 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1709 * dispnew.c (increment_matrix_positions)
1710 (increment_row_positions, mode_line_string)
1711 (marginal_area_string):
1712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1713 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1715 (duration_to_sec_usec): New function, to check for overflow better.
1716 (Fsleep_for, sit_for): Use it.
1717 * doc.c (get_doc_string, store_function_docstring):
1718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1719 (get_doc_string, Fsnarf_documentation):
1720 Use int, not EMACS_INT, where int is wide enough.
1721 (get_doc_string):
1722 Use SAFE_ALLOCA, not alloca.
1723 Check for overflow when converting EMACS_INT to off_t.
1724 * doprnt.c (doprnt):
1725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1726 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1727 Don't assume uid_t fits into fixnum.
1728 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1729 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1730 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1731 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1732 (general_insert_function)
1733 (Finsert_char, make_buffer_string, make_buffer_string_both)
1734 (update_buffer_properties, Fbuffer_substring)
1735 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1736 (Fsubst_char_in_region, check_translation)
1737 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1738 (transpose_markers, Ftranspose_regions):
1739 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1740 (clip_to_bounds): Move to lisp.h as an inline function).
1741 (Fconstrain_to_field): Don't assume integers are nonnegative.
1742 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1743 (Fsubst_char_in_region, Fsave_restriction):
1744 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1745 (Femacs_pid): Don't assume pid_t fits into fixnum.
1746 (lo_time): Use int, not EMACS_INT, when int suffices.
1747 (lisp_time_argument): Check for usec out of range.
1748 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1749 (Fuser_login_name, Fuser_full_name): Signal an error
1750 if a uid argument is out of range, rather than relying on
1751 undefined behavior.
c8d5c857
PE
1752 (Fformat_time_string): Remove now-unnecessary check.
1753 lisp_time_argument checks for out-of-range usec now.
243e0530 1754 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1755 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1756 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1757 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1758 (init_cmdargs, Fdump_emacs):
1759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1760 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1761 the bottom (typically) 32 bits of the fixnum.
1762 * eval.c (specpdl_size, call_debugger):
1763 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1764 (when_entered_debugger, Fbacktrace_debug):
1765 Don't assume fixnum can fit in int.
1766 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1767 the object just before a buffer; this is not portable.
1768 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1769 (grow_specpdl, unbind_to):
1770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1771 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1772 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1773 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1774 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1775 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1777 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1778 (a_write, e_write):
1779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1780 (Fcopy_file, non_regular_nbytes, read_non_regular)
1781 (Finsert_file_contents):
1782 Use int, not EMACS_INT, where int is wide enough.
1783 (READ_BUF_SIZE): Verify that it fits in int.
1784 (Finsert_file_contents): Check that counts are in proper range,
1785 rather than assuming fixnums fit into ptrdiff_t etc.
1786 Don't assume fixnums fit into int.
125b3835 1787 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1788 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1789 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1790 (string_char_to_byte, string_byte_to_char)
1791 (string_make_multibyte, string_to_multibyte)
1792 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1793 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1794 (substring_both, Fdelete, internal_equal, Ffillarray)
1795 (Fclear_string, mapcar1)
1796 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1797 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1798 (larger_vector, make_hash_table, maybe_resize_hash_table)
1799 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1800 (Fmaphash, secure_hash):
1801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1802 (concat): Check for string index and length overflow.
1803 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1804 (Frequire):
1805 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1806 (larger_vector): New API (vec, incr_min, size_max) replaces old
1807 one (vec, new_size, init). This catches size overflow.
1808 INIT was removed because it was always Qnil.
1809 All callers changed.
1810 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1811 the upper bound on a hash table index size.
1812 (make_hash_table, maybe_resize_hash_table): Use it.
1813 (secure_hash): Computer start_byte and end_byte only after
1814 they're known to be in ptrdiff_t range.
1815 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1816 (Ffont_get_glyphs, Ffont_at):
1817 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1818 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1819 (Flist_fonts, Fopen_font):
1820 Don't assume fixnum can fit in int.
1821 (check_gstring): Don't assume index can fit in int.
1822 (font_match_p): Check that fixnum is a character, not a nonnegative
1823 fixnum, since the later code needs to stuff it into an int.
1824 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1825 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1826 conversion overflow issues.
1827 (Fopen_font): Check for integer out of range.
1828 (Ffont_get_glyphs): Don't assume index can fit in int.
1829 * font.h: Adjust decls to match defn changes elsewhere.
1830 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1831 integer overflow.
1832 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1833 printmax_t, where ptrdiff_t is wide enough.
1834 (Finternal_char_font):
1835 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1836 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1837 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1838 (Fset_frame_position, x_set_frame_parameters)
1839 (x_set_line_spacing, x_set_border_width)
1840 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1841 Check that fixnums are in proper range for system types.
1842 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1844 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1845 Use SAFE_ALLOCA_LISP, not alloca.
1846 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1847 intptr_t is wide enough.
1848 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1849 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1850 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1851 Check for fixnum out of range.
1852 * ftfont.c (ftfont_list): Don't assume index fits in int.
1853 Check that fixnums are in proper range for system types.
1854 (ftfont_shape_by_flt):
1855 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1856 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1857 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1858 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1859 Check that fixnums are in proper range for system types.
1860 * gnutls.h: Adjust decls to match defn changes elsewhere.
1861 * gtkutil.c (xg_dialog_run):
1862 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1863 (update_frame_tool_bar):
1864 Check that fixnums are in proper range for system types.
1865 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1866 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1867 * indent.c (last_known_column, last_known_column_point):
1868 (current_column_bol_cache):
1869 (skip_invisible, current_column, check_display_width):
1870 (check_display_width, scan_for_column, current_column_1)
1871 (Findent_to, Fcurrent_indentation, position_indentation)
1872 (indented_beyond_p, Fmove_to_column, compute_motion):
1873 (Fcompute_motion, Fvertical_motion):
1874 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1875 (last_known_column_modified): Use EMACS_INT, not int.
1876 (check_display_width):
1877 (Fcompute_motion):
1878 Check that fixnums and floats are in proper range for system types.
1879 (compute_motion): Don't assume index or fixnum fits in int.
1880 (compute_motion, Fcompute_motion):
1881 Use int, not EMACS_INT, when it is wide enough.
1882 (vmotion): Omit local var start_hpos that is always 0; that way
1883 we don't need to worry about overflow in expressions involving it.
1884 * indent.h: Adjust decls to match defn changes elsewhere.
1885 (struct position):
1886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1887 Use int, not EMACS_INT, where int is wide enough.
1888 Remove unused members ovstring_chars_done and tab_offset;
1889 all uses removed.
1890 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1891 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1892 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1893 (make_gap, copy_text, insert, insert_and_inherit)
1894 (insert_before_markers, insert_before_markers_and_inherit)
1895 (insert_1, count_combining_before, count_combining_after)
1896 (insert_1_both, insert_from_string)
1897 (insert_from_string_before_markers, insert_from_string_1)
1898 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1899 (adjust_after_replace, adjust_after_insert, replace_range)
1900 (replace_range_2, del_range, del_range_1, del_range_byte)
1901 (del_range_both, del_range_2, modify_region)
1902 (prepare_to_modify_buffer, signal_before_change)
1903 (signal_after_change, Fcombine_after_change_execute):
1904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1905 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1906 (balance_an_interval, split_interval_right, split_interval_left)
1907 (find_interval, next_interval, update_interval)
1908 (adjust_intervals_for_insertion, delete_node, delete_interval)
1909 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1910 (static_offset_intervals, offset_intervals)
1911 (merge_interval_right, merge_interval_left, make_new_interval)
1912 (graft_intervals_into_buffer, temp_set_point_both)
1913 (temp_set_point, set_point, adjust_for_invis_intang)
1914 (set_point_both, move_if_not_intangible, get_property_and_range)
1915 (get_local_map, copy_intervals, copy_intervals_to_string)
1916 (compare_string_intervals, set_intervals_multibyte_1):
1917 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1918 * intervals.h: Adjust decls to match defn changes elsewhere.
1919 (struct interval):
1920 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1921 * keyboard.c (this_command_key_count, this_single_command_key_start)
1922 (before_command_key_count, before_command_echo_length, echo_now)
1923 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1924 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1925 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1926 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1927 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1928 (last_non_minibuf_size, last_point_position, echo_truncate)
1929 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1930 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1931 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1932 (stuff_buffered_input):
1933 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1934 (last_auto_save, command_loop_1, read_char):
1935 Use EMACS_INT, not int, to avoid integer overflow.
1936 (record_char): Avoid overflow in total_keys computation.
1937 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1938 * keyboard.h: Adjust decls to match defn changes elsewhere.
1939 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1940 (Fkey_description, Fdescribe_vector, Flookup_key):
1941 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1942 (click_position): New function, to check that positions are in range.
1943 (Fcurrent_active_maps):
1944 (describe_command):
1945 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1946 (Faccessible_keymaps, Fkey_description):
1947 (preferred_sequence_p):
1948 Don't assume fixnum can fit into int.
1949 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1950 Check for integer overflow in size calculations.
1951 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1952 avoid mishandling large integers.
1953 * lisp.h: Adjust decls to match defn changes elsewhere.
1954 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1955 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1956 (struct Lisp_Marker):
1957 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1958 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1959 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1960 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1961 All callers changed.
1962 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1963 Assume the arg has valid form, since it always does.
1964 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1965 unsigned integer system type.
1966 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1967 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1968 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1969 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1970 (duration_to_sec_usec): New decl.
1971 * lread.c (read_from_string_index, read_from_string_index_byte)
1972 (read_from_string_limit, readchar, unreadchar, openp)
1973 (read_internal_start, read1, oblookup):
1974 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1975 (Fload, readevalloop, Feval_buffer, Feval_region):
1976 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1977 (openp): Check for out-of-range argument to 'access'.
1978 (read1): Use int, not EMACS_INT, where int is wide enough.
1979 Don't assume fixnum fits into int.
6efdadfd 1980 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1981 (read_filtered_event): Use duration_to_sec_usec
1982 to do proper overflow checking on durations.
d311d28c
PE
1983 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1984 in size calculation.
1985 (Fexecute_kbd_macro):
1986 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1987 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1988 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1989 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1990 (set_marker_both, set_marker_restricted_both, marker_position)
1991 (marker_byte_position, Fbuffer_has_markers_at):
1992 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1993 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1994 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1995 It now merely ensures that the menu is large enough, without
1996 necessarily growing it, as this avoids some integer overflow issues.
1997 All callers changed.
1998 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1999 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2000 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2001 Use SAFE_ALLOCA_LISP, not alloca.
2002 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2003 to EMACS_INT. Check that fixnums are in proper range for system types.
2004 * minibuf.c (minibuf_prompt_width, string_to_object)
2005 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2006 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2007 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2008 (get_minibuffer, read_minibuf_unwind):
2009 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2010 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2011 this simplifies overflow checking. All callers changed.
2012 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2013 (Ftest_completion):
2014 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2015 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2016 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2017 Check that fixnums are in proper range for system types.
2018 (Fx_create_frame, Fx_show_tip):
2019 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2020 * nsfont.m (ns_findfonts, nsfont_list_family):
2021 Don't assume fixnum fits in long.
2022 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2023 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2024 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2025 wide enough.
17fdb222 2026 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2027 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2028 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2029 (PRINTDECLARE, PRINTPREPARE):
2030 (strout, print_string):
2031 (print, print_preprocess, print_check_string_charset_prop)
2032 (print_object):
2033 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2034 (PRINTDECLARE):
2035 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2036 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2037 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2038 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2039 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2040 (print_error_message): Use SAFE_ALLOCA, not alloca.
2041 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2042 (print_depth, new_backquote_output, print_number_index):
2043 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2044 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2045 (Fset_process_window_size, Fformat_network_address)
2046 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2047 (sigchld_handler):
d311d28c 2048 Check that fixnums are in proper range for system types.
d44287d4 2049 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2050 Check for process-ids out of pid_t range rather than relying on
2051 undefined behavior.
e4d81efc 2052 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2053 (Fformat_network_address, read_process_output, send_process)
2054 (Fprocess_send_region, status_notify):
2055 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2056 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2057 (wait_reading_process_output, read_process_output, exec_sentinel):
2058 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2059 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2060 (Faccept_process_output): Use duration_to_sec_usec to do proper
2061 overflow checking on durations.
dde14581
PE
2062 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2063 Don't assume pid_t fits in int.
02481186
PE
2064 * process.h (struct Lisp_Process): Members tick and update_tick
2065 are now of type EMACS_INT, not int.
b62b53e8
PE
2066 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2067 configured --with-wide-int.
d311d28c
PE
2068 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2069 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2070 * search.c (looking_at_1, string_match_1):
2071 (fast_string_match, fast_c_string_match_ignore_case)
2072 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2073 (scan_newline, find_before_next_newline, search_command)
2074 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2075 (set_search_regs, wordify):
2076 (Freplace_match):
2077 (Fmatch_data):
2078 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2079 (string_match_1, search_buffer, set_search_regs):
2080 (Fmatch_data):
2081 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2082 (wordify): Check for overflow in size calculation.
2083 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2084 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2085 Check that fixnums are in proper range for system types.
2086 * sound.c (struct sound_device)
2087 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2088 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2089 (Fplay_sound_internal):
2090 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2091 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2092 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2093 (Fparse_partial_sexp):
2094 Don't assume fixnums can fit in int.
2095 (struct lisp_parse_state, find_start_pos, find_start_value)
2096 (find_start_value_byte, find_start_begv)
2097 (update_syntax_table, char_quoted, dec_bytepos)
2098 (find_defun_start, prev_char_comend_first, back_comment):
2099 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2100 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2101 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2102 (Finternal_describe_syntax_value): Check that match_lisp is a
2103 character, not an integer, since the code stuffs it into int.
2104 (scan_words, scan_sexps_forward):
2105 Check that fixnums are in proper range for system types.
2106 (Fforward_word):
2107 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2108 (scan_sexps_forward):
2109 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2110 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2111 * syntax.h: Adjust decls to match defn changes elsewhere.
2112 (struct gl_state_s):
2113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2114 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2115 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2116 * sysdep.c (wait_for_termination_1, wait_for_termination)
2117 (interruptible_wait_for_termination, mkdir):
2118 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2119 (emacs_read, emacs_write):
2120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2121 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2122 and double all fit in int.
d311d28c
PE
2123 * term.c (set_tty_color_mode):
2124 Check that fixnums are in proper range for system types.
2125 * termhooks.h (struct input_event):
2126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2127 * textprop.c (validate_interval_range, interval_of)
2128 (Fadd_text_properties, set_text_properties_1)
2129 (Fremove_text_properties, Fremove_list_of_text_properties)
2130 (Ftext_property_any, Ftext_property_not_all)
2131 (copy_text_properties, text_property_list, extend_property_ranges)
2132 (verify_interval_modification):
2133 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2134 (Fnext_single_char_property_change)
2135 (Fprevious_single_char_property_change):
2136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2137 (copy_text_properties):
2138 Check for integer overflow in index calculation.
d311d28c
PE
2139 * undo.c (last_boundary_position, record_point, record_insert)
2140 (record_delete, record_marker_adjustment, record_change)
2141 (record_property_change):
2142 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2143 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2144 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2145 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2146 (Fx_hide_tip, Fx_file_dialog):
2147 * w32menu.c (set_frame_menubar):
2148 Use ptrdiff_t, not int, for consistency with rest of code.
2149 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2150 (select_window, Fdelete_other_windows_internal)
2151 (window_scroll_pixel_based, window_scroll_line_based)
2152 (Frecenter, Fset_window_configuration):
2153 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2154 (Fset_window_hscroll, run_window_configuration_change_hook)
2155 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2156 (Fscroll_other_window, Frecenter):
d311d28c
PE
2157 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2158 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2159 Don't assume fixnum fits in int.
2160 (Fset_window_scroll_bars):
2161 Check that fixnums are in proper range for system types.
2162 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2163 (string_pos, c_string_pos, number_of_chars, init_iterator)
2164 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2165 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2166 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2167 (face_before_or_after_it_pos, handle_invisible_prop)
2168 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2169 (display_prop_intangible_p, string_buffer_position_lim)
2170 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2171 (get_overlay_strings_1, get_overlay_strings)
2172 (iterate_out_of_display_property, forward_to_next_line_start)
2173 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2174 (get_next_display_element, set_iterator_to_next)
2175 (get_visually_first_element, compute_stop_pos_backwards)
2176 (handle_stop_backwards, next_element_from_buffer)
2177 (move_it_in_display_line_to, move_it_in_display_line)
2178 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2179 (add_to_log, message_dolog, message_log_check_duplicate)
2180 (message2, message2_nolog, message3, message3_nolog
2181 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2182 (current_message_1, truncate_echo_area, truncate_message_1)
2183 (set_message, set_message_1, store_mode_line_noprop)
2184 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2185 (text_outside_line_unchanged_p, check_point_in_composition)
2186 (reconsider_clip_changes)
2187 (redisplay_internal, set_cursor_from_row, try_scrolling)
2188 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2189 (redisplay_window, find_last_unchanged_at_beg_row)
2190 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2191 (trailing_whitespace_p, find_row_edges, display_line)
2192 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2193 (display_mode_element, store_mode_line_string)
2194 (pint2str, pint2hrstr, decode_mode_spec)
2195 (display_count_lines, display_string, draw_glyphs)
2196 (x_produce_glyphs, x_insert_glyphs)
2197 (rows_from_pos_range, mouse_face_from_buffer_pos)
2198 (fast_find_string_pos, mouse_face_from_string_pos)
2199 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2200 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2201 (safe_call, init_from_display_pos, handle_fontified_prop)
2202 (handle_single_display_spec, load_overlay_strings)
2203 (with_echo_area_buffer, setup_echo_area_for_printing)
2204 (display_echo_area, echo_area_display)
2205 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2206 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2207 (redisplay_window, dump_glyph_row, display_mode_line)
2208 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2209 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2210 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2211 (handle_single_display_spec, build_desired_tool_bar_string)
2212 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2213 (get_specified_cursor_type):
2214 Check that fixnums are in proper range for system types.
2215 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2216 (Flookup_image_map):
2217 Don't assume fixnums fit in int.
2218 (compare_overlay_entries):
2219 Avoid mishandling comparisons due to subtraction overflow.
2220 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2221 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2222 (handle_tool_bar_click):
2223 Use int, not unsigned, since we prefer signed and the signedness
2224 doesn't matter here.
2225 (get_next_display_element, next_element_from_display_vector):
2226 Use int, not EMACS_INT, when int is wide enough.
2227 (start_hourglass): Use duration_to_sec_usec to do proper
2228 overflow checking on durations.
2229 * xfaces.c (Fbitmap_spec_p):
2230 Check that fixnums are in proper range for system types.
2231 (compare_fonts_by_sort_order):
2232 Avoid mishandling comparisons due to subtraction overflow.
2233 (Fx_family_fonts, realize_basic_faces):
2234 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2235 (Fx_family_fonts):
2236 Don't assume fixnum fits in int.
2237 Use SAFE_ALLOCA_LISP, not alloca.
2238 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2239 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2240 (face_at_buffer_position, face_for_overlay_string)
2241 (face_at_string_position):
2242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2243 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2244 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2245 (Fx_show_tip):
2246 Check that fixnums are in proper range for system types.
2247 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2248 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2249 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2250 (Fx_change_window_property): Don't assume fixnums fit in int.
2251 * xfont.c (xfont_chars_supported):
2252 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2253 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2254 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2255 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2256 * xml.c (parse_region):
2257 * xrdb.c (magic_file_p):
2258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2259 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2260 (x_get_local_selection, x_reply_selection_request)
2261 (x_handle_selection_request, wait_for_property_change):
2262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2263 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2264 short is wide enough.
2265 (x_send_client_event): Don't assume fixnum fits in int.
2266 * xterm.c (x_x_to_emacs_modifiers):
2267 Don't assume EMACS_INT overflows nicely into int.
2268 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2269 may come from Lisp.
2270 (handle_one_xevent): NATNUMP can eval its arg twice.
2271 (x_connection_closed):
2272 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2273 * xterm.h: Adjust decls to match defn changes elsewhere.
2274 (struct scroll_bar): Use struct vectorlike_header
2275 rather than rolling our own approximation.
2276 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2277
c6574eb5
GM
22782012-05-25 Glenn Morris <rgm@gnu.org>
2279
2280 * lisp.mk (lisp): Update for more files being compiled now.
2281
e8d32c7e
SM
22822012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2283
48def666
SM
2284 * lread.c: Remove `read_pure' which makes no difference.
2285 (read_pure): Remove var.
2286 (unreadpure): Remove function.
2287 (readevalloop): Don't call read_list with -1 flag.
2288 (read1, read_vector): Don't test read_pure any more.
2289 (read_list): Simplify.
2290
e8d32c7e
SM
2291 * fileio.c, character.h: Minor style tweaks.
2292
4b2addb7
DA
22932012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2294
2295 * window.h (clip_changed): Remove useless declaration.
2296
584461b2
JB
22972012-05-22 Juanma Barranquero <lekktu@gmail.com>
2298
2299 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2300 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2301
34374650
PE
23022012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2303
2304 Remove src/m/*.
2305 This directory predates autoconf and is no longer needed nowadays.
2306 Move its few remaining bits of functionality to where they're needed.
2307 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2308 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2309 * m/template.h: Remove.
2310 * Makefile.in (M_FILE): Remove. All uses removed.
2311 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2312 * lisp.h (USE_LSB_TAG):
2313 * mem-limits.h (EXCEEDS_LISP_PTR):
2314 Use VAL_MAX, not VALBITS, in #if.
2315 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2316 (EMACS_UINT): Define unconditionally now.
2317 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2318 (BITS_PER_EMACS_INT): New constants, replacing
2319 what used to be in config.h, but not useful in #if.
2320 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2321 define them any more.
2322 (VAL_MAX): New macro.
2323 (VALMASK): Use it.
2324 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2325 BITS_PER_EMACS_INT, in #if.
2326 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2327 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2328 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2329 * s/ms-w32.h (DATA_START):
2330 Move here from removed file m/intel386.h.
2331 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2332 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2333
261cb4bb
PE
23342012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2335
2336 Assume C89 or later.
2337 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2338 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2339 (xrealloc):
2340 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2341 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2342 * textprop.c, tparam.c (NULL): Remove.
2343 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2344 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2345 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2346 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2347 * xterm.c (input_signal_count): Assume volatile works.
2348
ff23cd9f
KB
23492012-05-21 Ken Brown <kbrown@cornell.edu>
2350
2351 * xgselect.c (xg_select): Fix first argument in call to 'select'
2352 (bug#11508).
2353
1b170bc6
KB
23542012-05-20 Ken Brown <kbrown@cornell.edu>
2355
2356 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2357 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2358
b2f4d39f
KB
23592012-05-19 Ken Brown <kbrown@cornell.edu>
2360
2361 * xfns.c (x_in_use): Remove `static' qualifier.
2362 * xterm.h (x_in_use): Declare.
2363 * xgselect.c: Include xterm.h.
2364 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2365 and `display_arg' (bug#9754).
2366
003fdae2
PE
23672012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2368
9232a6d9
PE
2369 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2370
003fdae2
PE
2371 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2372 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2373
784b56e2
EZ
23742012-05-18 Eli Zaretskii <eliz@gnu.org>
2375
2376 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2377
2378 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2379 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2380
2381 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2382 reference to image_cache->refcount.
2383 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2384
a0a79cde
JL
23852012-05-17 Juri Linkov <juri@jurta.org>
2386
2387 * search.c (Fword_search_regexp, Fword_search_backward)
2388 (Fword_search_forward, Fword_search_backward_lax)
2389 (Fword_search_forward_lax): Move functions to isearch.el
2390 (bug#10145, bug#11381).
2391
b0572523
PE
23922012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2393
2394 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2395
9660f5fc
SM
23962012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2397
2398 * lread.c (init_obarray): Declare Qt and Qnil as special.
2399
4374de83
GM
24002012-05-14 Glenn Morris <rgm@gnu.org>
2401
2402 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2403 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2404
dc44c39a
PE
24052012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2406
078c97cb
PE
2407 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2408
dc44c39a
PE
2409 * unexaix.c: Port to more-recent AIX compilers.
2410 (report_error, report_error_1, make_hdr, copy_sym)
2411 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2412 Make arguments const char *, not char *, to avoid violations of C
2413 standard and to fix some AIX warnings reported by Gilles Pion.
2414
e18afed7 24152012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2416
2417 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2418 already have overlays loaded.
2419 (handle_single_display_spec): Before returning without displaying
2420 fringe bitmap, synchronize the bidi iterator with the main display
2421 iterator, by calling iterate_out_of_display_property.
2422 (iterate_out_of_display_property): Detect buffer iteration by
2423 testing that it->string is a Lisp string.
2424 (get_next_display_element): When the current object is exhausted,
2425 and there's something on it->stack, call set_iterator_to_next to
2426 proceed with what's on the stack, instead of returning zero.
2427 (set_iterator_to_next): If called at the end of a Lisp string,
2428 proceed to consider_string_end without incrementing string
2429 position. Don't increment display vector index past the end of
2430 the display vector. (Bug#11417)
c8fb9dc6
EZ
2431 (pos_visible_p): Don't report a position visible when move_it_to
2432 stopped at the last line of window, which happens to be scanned
2433 backwards by the bidi iteration. (Bug#11464)
ac268e67 2434
e18afed7 24352012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2436
2437 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2438 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2439 are on a TTY, and thus unable to display on the fringes.
2440 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2441 so we need to signal to the caller that this is a "replacing"
2442 display spec. This fixes display when the spec is invalid or we
2443 are on a TTY.
2444
e18afed7 24452012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2446
2447 * unexaix.c (make_hdr): Fix typo in prototype.
2448 This bug broke the build on AIX. Problem reported by Gilles Pion.
2449
9d0a235a
MA
24502012-05-14 Michael Albinus <michael.albinus@gmx.de>
2451
2452 * keyboard.c (kbd_buffer_get_event): Read special events also in
2453 batch mode. (Bug#11415)
2454
9e6b06ed
GM
24552012-05-12 Glenn Morris <rgm@gnu.org>
2456
2457 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2458
c1a1d7a3
EZ
24592012-05-12 Eli Zaretskii <eliz@gnu.org>
2460
2461 * lisp.mk (lisp): Add newcomment.elc.
2462
3fe7cdc8
GM
24632012-05-12 Glenn Morris <rgm@gnu.org>
2464
2465 * Makefile.in (MKDIR_P): New, set by configure.
2466 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2467
53f7d2c0
PE
24682012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2469
2470 Remove unused function hourglass_started.
2471 * dispextern.h (hourglass_started):
2472 * w32fns.c (hourglass_started):
2473 * xdisp.c (hourglass_started): Remove.
2474
75aafb17
JB
24752012-05-10 Juanma Barranquero <lekktu@gmail.com>
2476
2477 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2478 Update dependencies.
2479
12959e8e
PE
24802012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2481
97107e2e
PE
2482 * xgselect.c (xg_select): Put maxfds+1 into a var.
2483 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2484
12959e8e
PE
2485 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2486
836d29b3
DA
24872012-05-10 Dave Abrahams <dave@boostpro.com>
2488
2489 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2490 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2491
5cb67954
MA
24922012-05-09 Michael Albinus <michael.albinus@gmx.de>
2493
2494 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2495 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2496 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2497 Initialize xd_registered_buses.
2498
3478ec45
PE
24992012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2500
b263a6b0
PE
2501 Untag more efficiently if USE_LSB_TAG.
2502 This is based on a proposal by YAMAMOTO Mitsuharu in
2503 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2504 For an admittedly artificial (nth 8000 longlist) benchmark on
2505 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2506 Emacs's overall text size by 1%.
2507 * lisp.h (XUNTAG): New macro.
2508 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2509 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2510 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2511 * eval.c (Fautoload):
2512 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2513 * frame.h (XFRAME): Use XUNTAG.
2514
3478ec45
PE
2515 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2516 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2517 Remove unportable assumptions about print widths of types like
2518 dbus_uint32_t.
2519 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2520 intptr_t when converting between pointer and integer, to avoid GCC
2521 warnings about wrong width.
2522
666b903b 25232012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2524
2525 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2526 stack for each reader_thread, instead of defaulting to 8MB
2527 determined by the linker. This avoids failures in creating
2528 subprocesses on Windows 7, see the discussion in this thread:
2529 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2530
b120cc17
JC
25312012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2532
2533 Fix up display of the *Minibuf-0* buffer in the mini window.
2534 * keyboard.c (read_char): Don't clear the echo area if there's no
2535 message to clear.
2536 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2537 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2538
9a4b36f8
MA
25392012-05-07 Michael Albinus <michael.albinus@gmx.de>
2540
2541 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2542 batch mode.
2543
e5f9458f
CY
25442012-05-06 Chong Yidong <cyd@gnu.org>
2545
2546 * lisp.mk (lisp): Update.
2547
eceeb5fc 25482012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2549
2550 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2551
71873e2b
SM
25522012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2553
2554 * data.c (PUT_ERROR): New macro.
2555 (syms_of_data): Use it. Add new error type `user-error'.
2556 * undo.c (user_error): New function.
2557 (Fprimitive_undo): Use it.
2558 * print.c (print_error_message): Adjust print style for `user-error'.
2559 * keyboard.c (user_error): New function.
2560 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2561
ab0fa4e4
PE
25622012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2563
2564 Do not limit current-time-string to years 1000..9999.
2565 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2566 (Fcurrent_time_string): Support any year that is supported by the
2567 underlying localtime representation. Don't use asctime, as it
2568 has undefined behavior for years outside the range -999..9999.
2569
7ed806a7
PE
25702012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2571
2572 Fix race conditions involving setenv, gmtime, localtime, asctime.
2573 Without this fix, interrupts could mess up code that uses these
2574 nonreentrant functions, since setting TZ invalidates existing
2575 tm_zone or tzname values, and since most of these functions return
2576 pointers to static storage.
2577 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2578 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2579 Grow the critical sections to include not just invoking
2580 localtime/gmtime, but also accessing these functions' results
2581 including their tm_zone values if any, and any related TZ setting.
2582 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2583 so that the struct tm is saved in the critical section.
2584 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2585 motivated by the fact that memory allocation needs to be outside
2586 the critical section.
2587
0c16dfed
DA
25882012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2589
2590 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2591 with RESET_INTERVAL.
2592
2593 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2594 Remove duplicated buffer name initialization.
2595
3f83ace8
JM
25962012-05-02 Jim Meyering <jim@meyering.net>
2597
2598 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2599
c7b8541e
JM
2600 * xfns.c (x_window): Use xstrdup (Bug#11375).
2601
90207a15 26022012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2603
2604 * xdisp.c (pos_visible_p): If already at a newline from the
2605 display string before the 'while' loop, don't walk back the glyphs
2606 from it3.glyph_row. Solves assertion violation when the display
2607 string begins with a newline (egg.el). (Bug#11367)
2608
b593d6a9
AH
26092012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2610
2611 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2612 Move to simple.el.
2613
4737362e
GM
26142012-05-01 Glenn Morris <rgm@gnu.org>
2615
99cf43f9
GM
2616 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2617 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2618 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2619 All were removed before 23.1.
2620
9311dcff
GM
2621 * dispnew.c: Remove HAVE_LIBNCURSES test;
2622 it is always true on relevant platforms.
2623
4d5c6349
GM
2624 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2625 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2626
4737362e
GM
2627 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2628
74dd3a6b
AS
26292012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2630
2631 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2632 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2633 Remove.
2634
13c379ee
PE
26352012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2636
2637 Do not avoid creating empty evaporating overlays (Bug#9642).
2638 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2639 That is, do not delete an evaporating overlay if it becomes
2640 empty after its bounds are adjusted to fit within its buffer.
2641 This fix caused other problems, and I'm reverting it until we get
2642 to the bottom of them.
2643
a8e7d6d7 26442012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2645
2646 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2647
a8e7d6d7 26482012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2649
2650 * xdisp.c (pos_visible_p): If the window start position is beyond
2651 ZV, start the display from buffer beginning. Prevents assertion
2652 violation in init_iterator when the minibuffer window is scrolled
2653 via the scroll bar.
2654
2655 * window.c (window_scroll_pixel_based): Likewise.
2656
a8e7d6d7 26572012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2658
2659 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2660
a8e7d6d7 26612012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2662
2663 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2664 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2665
a8e7d6d7 26662012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2667
b593d6a9
AH
2668 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2669 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2670
1c6900d9
EZ
26712012-04-26 Eli Zaretskii <eliz@gnu.org>
2672
4c3fa1d9
EZ
2673 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2674 display element, check also the underlying string or buffer
2675 character. (Bug#11341)
2676
1c6900d9
EZ
2677 * w32menu.c: Include w32heap.h.
2678 (add_menu_item): If the call to AppendMenuW (via
2679 unicode_append_menu) fails, disable Unicode menus only if we are
2680 running on Windows 9X/Me.
2681
42bf8205
AS
26822012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2683
2684 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2685 (xgetint): Add missing shift for LSB tags.
2686
b1bac16e
MR
26872012-04-24 Martin Rudalics <rudalics@gmx.at>
2688
2689 * keyboard.c (read_char): Don't wipe echo area for select window
2690 events: These might get delayed via `mouse-autoselect-window'
2691 (Bug#11304).
2692
d69621cc
JB
26932012-04-24 Juanma Barranquero <lekktu@gmail.com>
2694
2695 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2696 manipulation of :loaded-from data.
2697
02fd101b
JB
26982012-04-23 Juanma Barranquero <lekktu@gmail.com>
2699
2700 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2701 now a cons (bug#11311).
2702
888bec30
PE
27032012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2704
89a438bd
PE
2705 Do not create empty overlays with the evaporate property (Bug#9642).
2706 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2707 if it becomes empty after its bounds are adjusted to fit within
2708 its buffer. Without this fix, in a nonempty buffer (let ((o
2709 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2710 yields an empty overlay that has the evaporate property, which is
2711 not supposed to happen.
2712
1068fe4d
PE
2713 Fix minor GTK3 problems found by static checking.
2714 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2715 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2716 (struct _EmacsFixedClass, emacs_fixed_get_type):
2717 Move decls here from emacsgtkfixed.h, since they needn't be public.
2718 (emacs_fixed_get_type): Now static.
2719 (emacs_fixed_class_init): Omit unused local.
2720 (emacs_fixed_child_type): Remove; unused.
2721 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2722 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2723 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2724 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2725 (EMACS_FIXED_GET_CLASS): Remove; unused.
2726 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2727
888bec30
PE
2728 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2729 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2730
de85e130
PE
27312012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2732
d0baac98 2733 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2734 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2735 (__malloc_size_t, __malloc_ptrdiff_t):
2736 Remove. All uses removed, replaced by the definiens if needed,
2737 since we can assume C89 or better now.
2738 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2739 (protect_malloc_state, align, get_contiguous_space)
2740 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2741 (malloc_atfork_handler_child, malloc_enable_thread)
2742 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2743 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2744 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2745 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2746 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2747 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2748 Define using prototypes, not old style.
2749 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2750 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2751 (align): Don't assume that signed integer overflow wraps around.
2752 Omit unused local var.
2753 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2754 (_free_internal_nolock, memalign, mallochook, reallochook):
2755 Omit no-longer-needed casts.
2756 (valloc): Use getpagesize, not __getpagesize.
2757 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2758 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2759
de85e130
PE
2760 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2761
dcbf5805
MA
27622012-04-22 Michael Albinus <michael.albinus@gmx.de>
2763
2764 Move functions from C to Lisp. Make non-blocking method calls
2765 the default. Implement further D-Bus standard interfaces.
2766
2767 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2768 (QCdbus_request_name_allow_replacement)
2769 (QCdbus_request_name_replace_existing)
2770 (QCdbus_request_name_do_not_queue)
2771 (QCdbus_request_name_reply_primary_owner)
2772 (QCdbus_request_name_reply_in_queue)
2773 (QCdbus_request_name_reply_exists)
2774 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2775 (QCdbus_registered_serial, QCdbus_registered_method)
2776 (QCdbus_registered_signal): New Lisp objects.
2777 (XD_DEBUG_MESSAGE): Use sizeof.
2778 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2779 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2780 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2781 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2782 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2783 (xd_signature, xd_append_arg): Allow float for integer types.
2784 (xd_get_connection_references): New function.
b593d6a9
AH
2785 (xd_get_connection_address): Rename from xd_initialize.
2786 Return cached address.
dcbf5805
MA
2787 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2788 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2789 level.
2790 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2791 Return number of refcounts.
dcbf5805
MA
2792 (Fdbus_get_unique_name): Make stronger parameter check.
2793 (Fdbus_message_internal): New defun.
2794 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2795 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2796 (Fdbus_send_signal, Fdbus_register_service)
2797 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2798 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2799 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2800 (Vdbus_compiled_version, Vdbus_runtime_version)
2801 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2802 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2803 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2804 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2805 Adapt docstring.
dcbf5805 2806
52828e02
PE
28072012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2808
da05bc4c
PE
2809 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2810 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2811 Do not assume ptrdiff_t is the same width as 'int'.
2812
52828e02
PE
2813 * alloc.c: Handle unusual debugging option combinations.
2814 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2815 since the two debugging options are incompatible.
2816 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2817 is defined.
2818 (mem_init, mem_insert, mem_insert_fixup):
2819 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2820 (NEED_MEM_INSERT): Remove; no longer needed.
2821
f01769f9
LL
28222012-04-22 Leo Liu <sdl.web@gmail.com>
2823
2824 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2825
5790543d
PE
28262012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2827
2828 * sysdep.c [__FreeBSD__]: Minor cleanups.
2829 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2830 Use Emacs indenting style more consistently. Avoid some casts.
2831 Use 'double' consistently rather than mixing 'float' and 'double'.
2832
b91b7e4d
EW
28332012-04-21 Eduard Wiebe <usenet@pusto.de>
2834
b593d6a9
AH
2835 * sysdep.c (list_system_processes, system_process_attributes):
2836 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2837
6114eb15
AS
28382012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2839
2840 * lisp.mk (lisp): Update.
2841
2f38dff7
PE
28422012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2843
2844 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2845 It is never used otherwise.
2846
4ae29f89
SM
28472012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2848
2849 * print.c (print_preprocess): Only check print_depth if print-circle
2850 is nil.
2851 (print_object): Check for cycles even when print-circle is nil and
2852 print-gensym is t, but only check print_depth if print-circle is nil.
2853
f30d612a
CY
28542012-04-20 Chong Yidong <cyd@gnu.org>
2855
2856 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2857 set the status to "failed" and ensure that sentinel is run.
2858
c07a4c0b 28592012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2860
2861 * process.c (Fset_process_inherit_coding_system_flag)
2862 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2863 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2864
c07a4c0b 28652012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2866
2867 * xdisp.c (string_buffer_position_lim): Limit starting position to
2868 BEGV.
2869 (set_cursor_from_row): If called for a mode-line or header-line
2870 row, return zero immediately.
2871 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2872 farther than the first row after the header line, if any.
2873 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2874 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2875
c07a4c0b 28762012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2877
4ae29f89
SM
2878 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2879 (bug#11238).
ad3a2b41 2880
c07a4c0b 28812012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 28822012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2883
2884 configure: new option --enable-gcc-warnings (Bug#11207)
2885 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2886 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2887 (ALL_CFLAGS): Use new macros rather than old.
2888 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2889 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2890 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2891 -Wunused-result, -Wunused-variable. This should go away once
2892 the Emacs and Gnulib regex code is merged.
2893 (xmalloc, xrealloc): Now static.
2894
aba027e8
PE
28952012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2896
2897 * dired.c (Fsystem_groups): Remove unused local.
2898
e5a36063
GM
28992012-04-17 Glenn Morris <rgm@gnu.org>
2900
2901 * dired.c (Fsystem_users): Doc fix.
2902
316411f0
DA
29032012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2904
2905 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2906 (syms_of_dired): Add them.
2907
9426aba4
PE
29082012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2909
b62a57be
PE
2910 Fix minor alloc.c problems found by static checking.
2911 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2912 New extern decls, to avoid calling undeclared functions.
2913 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2914 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2915 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2916 (NEED_MEM_INSERT): New macro.
2917 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2918 Remove one incorrect comment and fix another.
b62a57be 2919
3539f31f
PE
2920 Fix minor ralloc.c problems found by static checking.
2921 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2922 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2923 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2924 (r_alloc_sbrk): Now static.
2925
a041960a
PE
2926 Improve ralloc.c interface checking.
2927 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2928 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2929 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2930 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2931 [REL_ALLOC]: ... to here, to check interface.
2932 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2933 Remove decls. This fixes an "It stinks!".
2934
9426aba4
PE
2935 * alloc.c (which_symbols): Fix alignment issue / type clash.
2936
d55c12ed
AS
29372012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2938
2939 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2940 (struct Lisp_Misc_Any): Likewise.
2941 (struct Lisp_Free): Likewise.
2942 * alloc.c (union aligned_Lisp_Symbol): Define.
2943 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2944 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2945 (union aligned_Lisp_Misc): Define.
2946 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2947 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2948 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2949
b948ce8b
PE
29502012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2951
2952 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2953 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2954 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2955 * s/netbsd.h, s/sol2-6.h:
2956 Remove definition of GC_MARK_STACK, since the default now works.
2957 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2958 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2959 no longer the default.
2960 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2961
35dc09a1 29622012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2963
35dc09a1
GM
2964 * lread.c (lisp_file_lexically_bound_p):
2965 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2966
35dc09a1
GM
29672012-04-14 Eli Zaretskii <eliz@gnu.org>
2968
2969 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2970 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2971
29722012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2973
2974 * nsterm.m (constrainFrameRect): Always constrain when there is only
2975 one screen (Bug#10962).
2976
bcd86815
KB
29772012-04-13 Ken Brown <kbrown@cornell.edu>
2978
2979 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2980
c25df26e
RT
29812012-04-13 Reuben Thomas <rrt@sc3d.org>
2982
2983 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2984
0fc59f1e
DC
29852012-04-11 Daniel Colascione <dancol@dancol.org>
2986
2987 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2988 against is gone. It's better to use vfork now so that when Cygwin
2989 gains a new, working vfork, we use it automatically (bug#10398).
2990
de8c03dc
SM
29912012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2992
2993 * window.c (save_window_save): Obey window-point-insertion-type.
2994
2f097256
GM
29952012-04-11 Glenn Morris <rgm@gnu.org>
2996
2997 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2998
453b951e
SM
29992012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3000
3001 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3002
75f1671a 30032012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3004
3005 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3006 (force_quit_count): New var.
3007 (handle_interrupt): Use it.
3008
2a8ce227
JB
30092012-04-10 Juanma Barranquero <lekktu@gmail.com>
3010
3011 * w32.c (w32_delayed_load): Record the full path of the library
3012 being loaded (bug#10424).
3013
935396c0
GM
30142012-04-09 Glenn Morris <rgm@gnu.org>
3015
05920a43
GM
3016 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3017 not just in the obarray, before snarfing them. (Bug#11036)
3018
935396c0
GM
3019 * Makefile.in ($(leimdir)/leim-list.el):
3020 Pass EMACS rather than BUILT_EMACS.
3021
a18ecafa
TZ
30222012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3023
3024 * process.c (make_process):
3025 * process.h: Add integer `gnutls_handshakes_tried' member to
3026 process struct.
3027
6bbef4e5
JC
3028 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3029 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3030
3031 * gnutls.c (gnutls_log_function2i): Convenience log function.
3032 (emacs_gnutls_read): Use new log functions,
3033 `gnutls_handshakes_tried' process member, and
3034 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3035 attempts per process (connection).
3036
b4d3bc10
CY
30372012-04-09 Chong Yidong <cyd@gnu.org>
3038
3039 * eval.c (Fuser_variable_p, user_variable_p_eh)
3040 (lisp_indirect_variable): Functions deleted.
3041 (Fdefvar): Caller changed.
3042
3043 * callint.c (Finteractive, Fcall_interactively):
3044 * minibuf.c (Fread_variable): Callers changed.
3045
70f4d973
EZ
30462012-04-09 Eli Zaretskii <eliz@gnu.org>
3047
3048 * xdisp.c (set_cursor_from_row): If the display string appears in
3049 the buffer at position that is closer to point than the position
3050 after the display string, display the cursor on the first glyph of
3051 the display string. Fixes cursor display when a 'display' text
3052 property immediately follows invisible text. (Bug#11094)
3053
cb3c2e3e
PE
30542012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3055
3056 composite.c: use 'double' consistently
3057 * composite.c (get_composition_id): Use 'double' consistently
3058 instead of converting 'float' to 'double' and vice versa; this is
3059 easier to understand and avoids a GCC warning.
3060
fd06db5d
GM
30612012-04-09 Glenn Morris <rgm@gnu.org>
3062
50fe702a
GM
3063 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3064 preparation for dumping it with emacs. (Bug#4789)
3065 (leimdir): New variable.
3066 ($(leimdir)/leim-list.el): New rule.
3067 (emacs$(EXEEXT)): Depend on leim-list.el.
3068
fd06db5d
GM
3069 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3070 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3071 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3072
55c131ee
AS
30732012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3074
3075 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3076 proper alignment.
3077
9209588f
JB
30782012-04-07 Juanma Barranquero <lekktu@gmail.com>
3079
3080 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3081 Remove unused local variable.
3082
e3fb2efb
PE
30832012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3084
3085 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3086 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3087 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3088 objects, as mark_maybe_pointer will catch them otherwise.
3089 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3090 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3091
b5385551
PE
30922012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3093
3094 Fix typo that broke non-Windows builds.
3095 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3096
9078ead6
EZ
30972012-04-07 Eli Zaretskii <eliz@gnu.org>
3098
3099 Support building on MS-Windows with libxml2.
3100
3101 * makefile.w32-in (OBJ2): Add xml.$(O).
3102 (GLOBAL_SOURCES): Add xml.c.
3103 ($(BLD)/xml.$(O)): New dependency list.
3104
3105 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3106 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3107 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3108 [!WINDOWSNT]: New macros.
3109 (init_libxml2_functions, libxml2_loaded_p): New functions.
3110 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3111 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3112 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3113 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3114 linked in).
6bbef4e5
JC
3115 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3116 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3117 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3118
3119 * emacs.c: Don't include libxml/parser.h.
3120 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3121 xmlCleanupParser directly.
3122
3123 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3124
3811fdf3
EZ
31252012-04-07 Eli Zaretskii <eliz@gnu.org>
3126
3127 * indent.c (Fvertical_motion): If there is a display string at
3128 point, use it.vpos to compute how many lines to backtrack after
3129 move_it_to point. (Bug#11133)
3130
2f8e16b2
EZ
31312012-04-06 Eli Zaretskii <eliz@gnu.org>
3132
3133 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3134 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3135 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3136 macros related to unification of CJK characters. For the details,
3137 see the discussion following the message here:
3138 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3139
3d439cd1
CY
31402012-04-04 Chong Yidong <cyd@gnu.org>
3141
3142 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3143
8bc53d00
EZ
31442012-04-01 Eli Zaretskii <eliz@gnu.org>
3145
3146 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3147 instead of alloca. (Bug#11138)
3148
3b0512a3
AS
31492012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3150
3151 * w32menu.c (is_simple_dialog): Properly check lisp types.
3152 (Bug#11141)
3153
8427ddd2
EZ
31542012-03-31 Eli Zaretskii <eliz@gnu.org>
3155
979022ef
EZ
3156 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3157 position we get to after a call to move_it_to fails the
3158 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3159 only if we wind up in a string from display property. (Bug#11063)
3160
a6b1c7cc
EZ
3161 * window.c (Fdelete_other_windows_internal): Invalidate the row
3162 and column information about mouse highlight, so that redisplay
3163 restores it after reallocating the glyph matrices. (Bug#7464)
3164
8427ddd2
EZ
3165 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3166 string comes from a `display' text property, use the buffer
3167 position of that property as if we actually saw that position in
3168 the row's glyphs.
697ba24b
EZ
3169 (move_it_by_lines): Remove the assertion that
3170 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3171 violated when there's a before-string at the beginning of a line.
3172 (Bug#11063)
8427ddd2 3173
65a0a738
EZ
31742012-03-30 Eli Zaretskii <eliz@gnu.org>
3175
3176 * xdisp.c (append_space_for_newline): If the default face was
3177 remapped, use the remapped face for the appended newline.
3178 (extend_face_to_end_of_line): Use the remapped default face for
3179 extending the face to the end of the line.
3180 (display_line): Call extend_face_to_end_of_line when the default
3181 face was remapped. (Bug#11068)
3182
581355cc
EZ
31832012-03-29 Eli Zaretskii <eliz@gnu.org>
3184
3185 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3186
e8fc049f
SM
31872012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3188
3189 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3190
4fb9a543
GM
31912012-03-27 Glenn Morris <rgm@gnu.org>
3192
3193 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3194 Doc fixes.
3195
679910f1
KH
31962012-03-26 Kenichi Handa <handa@m17n.org>
3197
3198 * dispextern.h (struct glyph): Fix previous change. Change the
3199 bit length of glyphless.ch to 25 (Bug#11082).
3200
90d49b7f
CY
32012012-03-26 Chong Yidong <cyd@gnu.org>
3202
3203 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3204 (command_loop_1): Use it; inhibit selection update for
3205 handle-select-window too (Bug#8996).
3206
f514f6f0
FP
32072012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3208
e8fc049f 3209 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3210
bf43fa51
KH
32112012-03-25 Kenichi Handa <handa@m17n.org>
3212
3213 * dispextern.h (struct glyph): Change the bit length of
3214 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3215
8a0c01dd
EZ
32162012-03-24 Eli Zaretskii <eliz@gnu.org>
3217
3218 * s/ms-w32.h (tzname): Include time.h before redirecting to
3219 _tzname. Fixes the MSVC build. (Bug#9960)
3220
7d1c3a76
AS
32212012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3222
8ed79523
AS
3223 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3224 characters.
3225
7d1c3a76
AS
3226 * xterm.c (XTread_socket): Only modify handling_signal if
3227 !SYNC_INPUT. (Bug#11080)
3228
e99a9b8b
EZ
32292012-03-23 Eli Zaretskii <eliz@gnu.org>
3230
3231 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3232 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3233 when fetching a multibyte character consumes more bytes than
3234 CHAR_BYTES returns, due to unification of CJK characters in
3235 string_char. (Bug#11073)
3236
5063c0e1
TN
32372012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3238
3239 * process.c (wait_reading_process_output): Handle pty disconnect
3240 by refraining from sending oneself a SIGCHLD (bug#10933).
3241
9f851fbd
CY
32422012-03-22 Chong Yidong <cyd@gnu.org>
3243
3244 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3245
5063c0e1 3246 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3247 Mark string as coming from a prefix property.
3248 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3249 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3250
fb5b8aca
CY
32512012-03-21 Chong Yidong <cyd@gnu.org>
3252
3253 * xfaces.c (Vface_remapping_alist): Doc fix.
3254
62356a1b
EZ
32552012-03-20 Eli Zaretskii <eliz@gnu.org>
3256
3257 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3258 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3259 Doc fixes.
62356a1b 3260
025de85b
CY
32612012-03-20 Chong Yidong <cyd@gnu.org>
3262
3263 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3264 to reflect default non-nil value of redisplay-dont-pause.
3265
4827f94e
KH
32662012-03-19 Kenichi Handa <handa@m17n.org>
3267
3268 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3269 it fit in a valid range (Bug#11003).
3270
e50a24a2
EZ
32712012-03-18 Eli Zaretskii <eliz@gnu.org>
3272
3273 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3274 that is not from display property, accept the row as a "cursor
3275 row" if one of the string's character has a non-nil `cursor'
3276 property. Fixes cursor positioning when there are newlines in
3277 overlay strings, e.g. in icomplete.el. (Bug#11035)
3278
9af5ed87
PE
32792012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3280
3281 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3282
d1f55f16
CY
32832012-03-12 Chong Yidong <cyd@gnu.org>
3284
3285 * eval.c (inhibit_lisp_code): Rename from
3286 inhibit_window_configuration_change_hook; move from window.c.
3287
3288 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3289 * window.c (run_window_configuration_change_hook)
3290 (syms_of_window): Callers changed.
3291
66c5eebd
CY
32922012-03-11 Chong Yidong <cyd@gnu.org>
3293
413df973
CY
3294 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3295
66c5eebd
CY
3296 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3297
1de11f56
CY
32982012-03-10 Chong Yidong <cyd@gnu.org>
3299
3300 * frame.c (other_visible_frames): Don't assume the selected frame
3301 is visible (Bug#10955).
3302
cae07000
SM
33032012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3304
3305 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3306
89c94350
JD
33072012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3308
3309 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3310 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3311 zero (Bug#10954).
3312
999dd333
GM
33132012-03-03 Glenn Morris <rgm@gnu.org>
3314
01a6dcc8 3315 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3316
de0100f2
EZ
33172012-03-02 Eli Zaretskii <eliz@gnu.org>
3318
3319 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3320 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3321 (redisplay_window, next_element_from_string): Fix typos in
3322 comments.
3e441275
EZ
3323 (redisplay_window): Pass to move_it_vertically the margin in
3324 pixels, not in screen lines.
de0100f2 3325
96a72ee9
GM
33262012-03-02 Glenn Morris <rgm@gnu.org>
3327
3328 * buffer.c (buffer-list-update-hook): Doc fix.
3329
312508d7
EZ
33302012-02-29 Eli Zaretskii <eliz@gnu.org>
3331
3332 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3333 push_it before setting up the iterator for the first overlay
3334 string, even if we have an empty string loaded.
3335 (next_overlay_string): If there's an empty string on the iterator
3336 stack, pop the stack. (Bug#10903)
3337
27f3c637
PE
33382012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3339
3340 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3341 Suggested by Stefan Monnier in
3342 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3343 * alloc.c (widen_to_Lisp_Object): New static function.
3344 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3345 and widening them to Lisp_Objects. This would work even if
3346 USE_LSB_TAG is defined and wide integers are used, which might
3347 happen in a future version of Emacs.
3348
3c9dfce6
CY
33492012-02-25 Chong Yidong <cyd@gnu.org>
3350
fa74b241
CY
3351 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3352 Doc fix.
3353
3c9dfce6
CY
3354 * xselect.c (Fx_selection_exists_p): Doc fix.
3355 (x_clipboard_manager_save_all): Print an informative message
3356 before saving to clipboard manager.
3357
9486df08
CY
33582012-02-24 Chong Yidong <cyd@gnu.org>
3359
3360 * keyboard.c (process_special_events): Handle all X selection
3361 requests in kbd_buffer, not just the next one (Bug#8869).
3362
f01d3321
CY
33632012-02-23 Chong Yidong <cyd@gnu.org>
3364
3365 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3366 call when setting menu-bar-lines and tool-bar-lines parameters.
3367 (unwind_create_frame_1): New helper function.
3368
3369 * window.c (inhibit_window_configuration_change_hook): New var.
3370 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3371 (syms_of_window): Initialize it.
f01d3321 3372
86b847b6
CY
33732012-02-22 Chong Yidong <cyd@gnu.org>
3374
3375 * xterm.c (x_draw_image_relief): Add missing type check for
3376 Vtool_bar_button_margin (Bug#10743).
3377
a59225b1
CY
33782012-02-21 Chong Yidong <cyd@gnu.org>
3379
3380 * fileio.c (Vfile_name_handler_alist): Doc fix.
3381
3382 * buffer.c (Fget_file_buffer): Protect against invalid file
3383 handler return value.
3384
310f5bd4
PE
33852012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3386
cb3a28cc
PE
3387 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3388 when computing $valmask.
3389
310f5bd4
PE
3390 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3391 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3392 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3393 It's useless in that case, and it can cause problems on hosts
3394 that allocate halves of EMACS_INT values separately.
3395 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3396 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3397 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3398 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3399 it avoids undefined behavior on hosts where shifting right by more
3400 than the word width has undefined behavior.
3401
2375c96a
CY
34022012-02-19 Chong Yidong <cyd@gnu.org>
3403
3404 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3405 (Funhandled_file_name_directory, Ffile_name_as_directory)
3406 (Fdirectory_file_name, Fexpand_file_name)
3407 (Fsubstitute_in_file_name): Protect against invalid file handler
3408 return values (Bug#10845).
3409
3eb49e71
EZ
34102012-02-18 Eli Zaretskii <eliz@gnu.org>
3411
3412 * .gdbinit (pitx): Fix incorrect references to fields of the
3413 iterator stack.
3414
7b926f3f
CY
34152012-02-17 Chong Yidong <cyd@gnu.org>
3416
3417 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3418
11273115
PE
34192012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3420
3421 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3422 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3423
c3a70e2b
CY
34242012-02-15 Chong Yidong <cyd@gnu.org>
3425
3426 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3427 marked as special. Also, starting docstrings with * is obsolete.
3428
0ca43699
AS
34292012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3430
3431 * gnutls.c (emacs_gnutls_write): Fix last change.
3432
2e8f3c56
LI
34332012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3434
3435 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3436 send_process.
3437
af70074f
SM
34382012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3439
3440 * keymap.c (Fsingle_key_description): Handle char ranges.
3441
95986d52
CY
34422012-02-12 Chong Yidong <cyd@gnu.org>
3443
afd83bd1
CY
3444 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3445 as that creates a dangerous corner case.
3446
95986d52
CY
3447 * window.c (Fdelete_window_internal): Invalidate the mouse
3448 highlight (Bug#9904).
3449
bd7da63e
GM
34502012-02-12 Glenn Morris <rgm@gnu.org>
3451
3452 * xselect.c (Fx_own_selection_internal)
3453 (Fx_get_selection_internal, Fx_disown_selection_internal)
3454 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3455 * nsselect.m (Fx_own_selection_internal)
3456 (Fx_disown_selection_internal, Fx_selection_exists_p)
3457 (Fx_selection_owner_p, Fx_get_selection_internal):
3458 Sync docs and argument specs with the xselect.c versions.
3459
77abcbc2
LI
34602012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3461
3462 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3463
90b671e2
EZ
34642012-02-11 Eli Zaretskii <eliz@gnu.org>
3465
1c0ca0b7
EZ
3466 * w32select.c (Fx_selection_exists_p): Sync doc string and
3467 argument list with xselect.c. (Bug#10783)
3468
3469 * w16select.c (Fx_selection_exists_p): Sync doc string and
3470 argument list with xselect.c. (Bug#10783)
90b671e2 3471
49241268
GM
34722012-02-10 Glenn Morris <rgm@gnu.org>
3473
3474 * fns.c (Fsecure_hash): Doc fix.
3475
f998bbe7 34762012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3477
3478 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3479
0992bd9c
CY
34802012-02-07 Chong Yidong <cyd@gnu.org>
3481
3482 * buffer.c (Fbuffer_local_variables)
3483 (buffer_lisp_local_variables): Handle unbound vars correctly;
3484 don't let Qunbound leak into Lisp.
3485
af008560
GM
34862012-02-07 Glenn Morris <rgm@gnu.org>
3487
dd605cc4
GM
3488 * image.c (Fimagemagick_types): Doc fix.
3489
af008560
GM
3490 * image.c (imagemagick-render-type): Change it from a lisp object
3491 to an integer. Move the doc here from the lisp manual.
3492 Treat all values not equal to 0 the same.
3493
1449fa1d
CY
34942012-02-06 Chong Yidong <cyd@gnu.org>
3495
3496 * doc.c (store_function_docstring): Avoid applying docstring of
3497 alias to base function (Bug#2603).
3498
3723ec07
AS
34992012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3500
3501 * .gdbinit (pp1, pv1): Remove redundant defines.
3502 (pr): Use pp.
3503
79c1cc1e
CY
35042012-02-04 Chong Yidong <cyd@gnu.org>
3505
3506 * nsterm.m: Declare a global (Bug#10694).
3507
d7f29f8e
EZ
35082012-02-04 Eli Zaretskii <eliz@gnu.org>
3509
cae07000
SM
3510 * w32.c (get_emacs_configuration_options):
3511 Include --enable-checking, if specified, in the return value.
d7f29f8e 3512
3b95a6f9
MR
35132012-02-04 Martin Rudalics <rudalics@gmx.at>
3514
3515 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3516 after rounding frame sizes. (Bug#9723)
3517
d6fa96a6
EZ
35182012-02-04 Eli Zaretskii <eliz@gnu.org>
3519
3520 * keyboard.c (adjust_point_for_property): Don't position point
3521 before BEGV. (Bug#10696)
3522
df0b2940
PE
35232012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3524
3525 Handle overflow when computing char display width (Bug#9496).
3526 * character.c (char_width): Return EMACS_INT, not int.
3527 (char_width, c_string_width): Check for overflow when
3528 computing the width; this is possible now that individual
3529 characters can have unbounded width. Problem introduced
3530 by merge from Emacs 23 on 2012-01-19.
3531
6bee44d6
MA
35322012-02-02 Michael Albinus <michael.albinus@gmx.de>
3533
3534 * dbusbind.c (Fdbus_register_method): Mention the return value
3535 :ignore in the docstring.
3536
44f92739
GM
35372012-02-02 Glenn Morris <rgm@gnu.org>
3538
1b9f60cc
GM
3539 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3540
44f92739
GM
3541 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3542 Unconditionally set to t. (Bug#10673)
3543 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3544 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3545 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3546
c5d3843c
KH
35472012-02-02 Kenichi Handa <handa@m17n.org>
3548
3549 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3550 0, do not call append_composite_glyph.
3551
159462d4 35522012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3553
3554 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3555 NULL (Bug#6988).
3556 (x_produce_glyphs): If the component of a composition is a null
3557 string, set it->pixel_width to 1 to avoid zero-width glyph.
3558
78cef877
EZ
35592012-02-01 Eli Zaretskii <eliz@gnu.org>
3560
3561 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3562 first 2 arguments are identical. This makes inserting large
3563 output from a subprocess an order of magnitude faster on
3564 MS-Windows, where all sbrk'ed memory is always contiguous.
3565
97897668
GM
35662012-01-31 Glenn Morris <rgm@gnu.org>
3567
3568 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3569 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3570 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3571
31fd3586
GM
35722012-01-29 Glenn Morris <rgm@gnu.org>
3573
3574 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3575
0e24a8b2
CY
35762012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3577
3578 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3579
cc0adcb0
CY
35802012-01-28 Chong Yidong <cyd@gnu.org>
3581
3582 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3583
acc28cb9
CY
35842012-01-26 Chong Yidong <cyd@gnu.org>
3585
9c69cfb7
CY
3586 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3587
acc28cb9
CY
3588 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3589 repeat counts (Bug#10507).
3590
48da7392
GM
35912012-01-26 Glenn Morris <rgm@gnu.org>
3592
3593 * lread.c (syms_of_lread): Doc fix.
3594
14af5f7f
CY
35952012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3596
3597 * coding.c (encode_designation_at_bol): Change return value to
3598 EMACS_INT.
3599
0b21c100
CY
36002012-01-25 Chong Yidong <cyd@gnu.org>
3601
3602 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3603
3c2907f7
CY
36042012-01-21 Chong Yidong <cyd@gnu.org>
3605
3606 * floatfns.c (Fcopysign): Make the second argument non-optional,
3607 since nil is not allowed anyway.
3608
959ad23f
AS
36092012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3610
3611 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3612 (send_process): Likewise.
3613
34a02f46
MR
36142012-01-19 Martin Rudalics <rudalics@gmx.at>
3615
3616 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3617 (Vwindow_persistent_parameters): Do not use Qstate.
3618 Rewrite doc-strings.
34a02f46 3619
1259009a 36202012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3621
3622 * character.c (char_width): New function.
70d4fdf6
GM
3623 (Fchar_width, c_string_width, lisp_string_width):
3624 Use char_width (Bug#9496).
25ed9e61 3625
6a6ee00d
MR
36262012-01-16 Martin Rudalics <rudalics@gmx.at>
3627
3628 * window.c (Vwindow_persistent_parameters): New variable.
3629 (Fset_window_configuration, save_window_save): Handle persistent
3630 window parameters.
3631
c85efaf7
EZ
36322012-01-14 Eli Zaretskii <eliz@gnu.org>
3633
3634 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3635 thrashing the stack of the thread. (Bug#9087)
3636
5944709e
PE
36372012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3638
3639 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3640
e71f5d99
EZ
36412012-01-11 Eli Zaretskii <eliz@gnu.org>
3642
3643 * xdisp.c (rows_from_pos_range): Handle the case where the
3644 highlight ends on a newline. (Bug#10464)
3645 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3646 he end column for display of highlight that ends on a newline
3647 before a R2L line.
3648
ce316182
GM
36492012-01-11 Glenn Morris <rgm@gnu.org>
3650
3651 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3652 from load-path also when installation-directory is nil. (Bug#10208)
3653
5b43da69
GM
36542012-01-10 Glenn Morris <rgm@gnu.org>
3655
74cc8ff9
GM
3656 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3657
7d8d6e4e
GM
3658 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3659 Update template values to be closer to their typical values these days.
5b43da69 3660
a0db8d43
EZ
36612012-01-09 Eli Zaretskii <eliz@gnu.org>
3662
3663 * xdisp.c (rows_from_pos_range): Accept additional argument
3664 DISP_STRING, and accept any glyph in a row whose object is that
3665 string as eligible for mouse highlight. Fixes mouse highlight of
3666 display strings from overlays. (Bug#10464)
3667
9a0115ab 36682012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3669
b9110d6a 3670 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3671 * fileio.c (auto_saving_dir_umask): New static var.
3672 (Fmake_directory_internal): Use it.
3673 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3674 creating the directory. The old code temporarily assigns
3675 too-generous permissions to the directory.
3676 (do_auto_save_eh): Clear it.
b9110d6a 3677 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3678 that the var is always cleared.
3679
6c1bd3f3
EZ
36802012-01-07 Eli Zaretskii <eliz@gnu.org>
3681
3682 * search.c (scan_buffer): Pass character positions to
3683 know_region_cache, not byte positions. (Bug#6540)
3684
069d2b50
L
36852012-01-07 LynX <_LynX@bk.ru> (tiny change)
3686
3687 * w32.c (sys_rename): Report EXDEV when rename of a directory
3688 fails because the target is on another logical disk. (Bug#10284)
3689
75bf0d33
DB
36902012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3691
3692 * xterm.c (x_embed_request_focus): New function.
3693
3694 * xterm.h: Add prototype.
3695
3696 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3697
1c6e5a32
GM
36982012-01-05 Glenn Morris <rgm@gnu.org>
3699
3700 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3701
651e947e
EZ
37022012-01-01 Eli Zaretskii <eliz@gnu.org>
3703
3704 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3705 Load gnutls_transport_set_lowat only if GnuTLS version is below
3706 2.11.1.
3707 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3708 GnuTLS versions below 2.11.1.
3709
3778cdd8
AL
37102011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3711
3712 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3713 to the doc string advising against its use for altering the way
3714 windows are scrolled.
3715
0e5317f7
KH
37162011-12-28 Kenichi Handa <handa@m17n.org>
3717
3718 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3719 coding-system ASCII compatible only when it does not produce BOM
3720 on encoding (Bug#10383).
3721
93d5ca1f
JD
37222011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3723
3724 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3725 can scroll.
3726 (create_and_show_popup_menu): Always use menu_position_func for
3727 Gtk3 (Bug#10361).
3728
ca22b785
AS
37292011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3730
3731 * callint.c (Fcall_interactively): Don't truncate prompt string.
3732
d048e1e6
EZ
37332011-12-23 Eli Zaretskii <eliz@gnu.org>
3734
3735 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3736 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3737 resumed from there (after widening). (Bug#10360)
d048e1e6 3738
5ccaba1f
JD
37392011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3740
3741 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3742
204ee57f
JD
37432011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3744
b81d40f0
JB
3745 * nsterm.m (x_free_frame_resources):
3746 Release f->output_data.ns->miniimage.
204ee57f
JD
3747 (ns_index_color): Fix indentation. Do not retain
3748 color_table->colors[i].
3749
3750 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3751 before returning.
3752
3753 * nsfns.m (x_set_background_color): Assign return value from
3754 ns_index_color to face-background instead of NSColor*.
3755 (ns_implicitly_set_icon_type): Fix indentation.
3756 Change assignment in for loop to comparison.
3757
3758 * emacs.c (ns_pool): New variable.
3759 (main): Assign ns_pool.
3760 (Fkill_emacs): Call ns_release_autorelease_pool.
3761
3762 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3763 autorelease fdesc, release fdAttrs and tdict.
3764 (ns_get_covering_families): Release charset.
3765 (ns_findfonts): Release NSFontDescriptor created with new.
3766 (ns_uni_to_glyphs): Fix indentation.
3767 (setString): Release attrStr before assigning new value.
3768
c803b2b7
JD
37692011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3770
678f4426
JD
3771 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3772 and NS_IMPL_COCOA.
3773 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3774 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3775
cd394be1 37762011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3777
5fecd5fc
JD
3778 * nsterm.m (ns_term_init): Subscribe for notifications
3779 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3780 to method trackingNotification in EmacsMenu.
3781
3782 * nsmenu.m (trackingMenu): New variable.
3771cb17 3783 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3784 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3785 from Aquamacs (Bug#7030).
678f4426
JD
3786
37872011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3788
c803b2b7
JD
3789 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3790 (symbol_to_nsstring): Fix indentation.
3791 (ns_symbol_to_pb): New function.
cae07000
SM
3792 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3793 (Fns_rotate_cut_buffers_internal): Remove.
3794 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3795 Fns_store_cut_buffer_internal.
3796 (ns_get_foreign_selection, Fx_own_selection_internal)
3797 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3798 (Fns_get_selection_internal, Fns_store_selection_internal):
3799 Use ns_symbol_to_pb and check if return value is nil.
3800 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3801 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3802 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3803 renamed to Sns_store_selection_internal.
3804 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3805 and remove this function.
3806 (ns_handle_selection_clear): Remove, never used.
3807 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3808 here.
3809
e1b01a3a
KB
38102011-12-17 Ken Brown <kbrown@cornell.edu>
3811
3812 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3813 GID is unknown (Bug#10257).
3814
2adb6e85
PE
38152011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3816
3817 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3818 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3819 which caused a build failure on GNU/Linux IA-64. This problem was
3820 introduced by my 2011-10-07 patch.
3821
d1d7b339
JL
38222011-12-15 Juri Linkov <juri@jurta.org>
3823
3824 * image.c (imagemagick_error): New function. (Bug#10112)
3825 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3826 Use `imagemagick_error' where ImageMagick functions return
3827 `MagickFalse'.
3828 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3829 proper order.
3830
100d5755
KH
38312011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3832
3833 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3834 fill background (Bug#8992).
3835
454592a6
MR
38362011-12-13 Martin Rudalics <rudalics@gmx.at>
3837
3838 * window.c (Vwindow_combination_resize)
3839 (Vwindow_combination_limit): Use t instead of non-nil in
3840 doc-strings.
61d4b438
MR
3841 (Vrecenter_redisplay): Add first sentence of doc-string on
3842 separate line.
53524d93 3843 (Frecenter): Fix doc-string typo.
454592a6 3844
3633e3aa
KH
38452011-12-11 Kenichi Handa <handa@m17n.org>
3846
3847 * coding.c (Funencodable_char_position): Pay attention to the
3848 buffer text relocation (Bug#9389).
3849
7b9d523a 38502011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3851
7b9d523a
JD
3852 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3853 gtk_init (Bug#10100).
3854
b73189c6
EZ
38552011-12-10 Eli Zaretskii <eliz@gnu.org>
3856
3857 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3858 IT->string is nil. (Bug#10263)
3859
f7dfe5d6
JD
38602011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3861
83faebb4
JD
3862 * nsterm.h (x_free_frame_resources): Declare.
3863
f7dfe5d6
JD
3864 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3865 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3866
3867 * nsterm.h (ns_get_defaults_value): Declare.
3868
3869 * nsterm.m (ns_default): Call ns_get_defaults_value.
3870
7cd4e72c
EZ
38712011-12-09 Eli Zaretskii <eliz@gnu.org>
3872
3873 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3874 (Bug#10170)
3875
b34d7317
YM
38762011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3877
3878 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3879 that where the value of an _OBJC_* symbol points to is in the .bss
3880 section (Bug#10240).
3881
76470ad1
KH
38822011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3883
3884 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3885 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3886
745fff94
KH
38872011-12-08 Kenichi Handa <handa@m17n.org>
3888
3889 * ftfont.c (get_adstyle_property): Fix previous change
3890 (Bug#10233).
3891
6e44397c
JB
38922011-12-07 Juanma Barranquero <lekktu@gmail.com>
3893
3894 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3895 dirs from the default value of EMACSLOADPATH (bug#10208).
3896
7efa6272
GM
38972011-12-07 Glenn Morris <rgm@gnu.org>
3898
3899 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3900 installation and source directories as well. (Bug#10208)
3901
f6fc4d87
CY
39022011-12-06 Chong Yidong <cyd@gnu.org>
3903
3904 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3905
2bf26180
GM
39062011-12-06 Glenn Morris <rgm@gnu.org>
3907
3908 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3909 as an error, not just -1. (Bug#10217)
3910
3a6ad4f0
CY
39112011-12-05 Chong Yidong <cyd@gnu.org>
3912
3913 * keyboard.c (process_special_events): New function.
3914 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3915
75a3b399
PE
39162011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3917
3918 * coding.c (encode_designation_at_bol): Don't use uninitialized
3919 local variable (Bug#9318).
3920
c3c9e25e
KH
39212011-12-05 Kenichi Handa <handa@m17n.org>
3922
3923 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3924 return Qnil (Bug#8046, Bug#10193).
3925
5eb05ea3
KH
39262011-12-05 Kenichi Handa <handa@m17n.org>
3927
3928 * coding.c (encode_designation_at_bol): New args charbuf_end and
3929 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3930 (coding_set_source): Return how many bytes coding->source was
3931 relocated.
3932 (coding_set_destination): Return how many bytes
3933 coding->destination was relocated.
3934 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3935 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3936
39372011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3938
3939 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3940 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3941 macro (Bug#9318).
3942
39432011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3944
3945 The following changes are to fix Bug#9318.
3946
a79703f5 3947 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3948 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3949 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3950 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3951
7dbda6df
JB
39522011-12-05 Juanma Barranquero <lekktu@gmail.com>
3953
3954 * lisp.h (process_quit_flag): Fix external declaration.
3955
6d5eb5b0
SM
39562011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3957
3958 Don't macro-inline non-performance-critical code.
3959 * eval.c (process_quit_flag): New function.
3960 * lisp.h (QUIT): Use it.
3961
a0c3fad0
JD
39622011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3963
3964 * nsfns.m (get_geometry_from_preferences): New function.
3965 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3966
6c07aac2
AS
39672011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3968
3969 * emacs.c (Qkill_emacs): Define.
3970 (syms_of_emacs): Initialize it.
3971 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3972 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3973 (quit_throw_to_read_char): Add parameter `from_signal'.
3974 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3975 * lisp.h (QUIT): Call Fkill_emacs if requested.
3976
c052ead4
JD
39772011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3978
3979 * widget.c (update_wm_hints): Return if wmshell is null.
3980 (widget_update_wm_size_hints): New function.
3981
3982 * widget.h (widget_update_wm_size_hints): Declare.
3983
3984 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3985 widget_update_wm_size_hints (Bug#10104).
3986
9e49252b
EZ
39872011-12-03 Eli Zaretskii <eliz@gnu.org>
3988
3989 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3990 before a newline, prepare the bidi iterator for consuming the
3991 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3992 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3993
02b16839
JL
39942011-12-02 Juri Linkov <juri@jurta.org>
3995
3996 * search.c (Fword_search_regexp): New Lisp function created from
3997 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3998 (Fword_search_backward, Fword_search_forward)
3999 (Fword_search_backward_lax, Fword_search_forward_lax):
4000 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4001 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4002
0068070e
SM
40032011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4004
4005 * fileio.c (Finsert_file_contents): Move after-change-function call
4006 to before the "handled:" label, since all "goto handled" appear in
4007 cases where the *-change-functions have already been properly called
4008 (bug#10117).
4009
3360a3fc
AS
40102011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4011
4012 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4013 waiting for input. (Bug#10169)
4014
73d6c093
EZ
40152011-11-30 Eli Zaretskii <eliz@gnu.org>
4016
4017 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4018 verifies glyph row's hash code--we have just reallocated the
4019 glyphs, so their contents can be complete garbage. (Bug#10164)
4020
febe6bea
JB
40212011-11-30 Juanma Barranquero <lekktu@gmail.com>
4022
4023 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4024
801a4313
EZ
40252011-11-30 Eli Zaretskii <eliz@gnu.org>
4026
4027 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4028 attributes are tested _before_ calling verify_row_hash, to protect
4029 against GCC re-ordering of the tests. (Bug#10164)
4030
2b56b87e
JD
40312011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4032
4033 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4034
4035 * xterm.c (handle_one_xevent): Only set async_visible and friends
4036 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4037 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4038 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4039
dbf31225
PE
40402011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4041
4042 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4043 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4044 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4045 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4046 All uses changed to use GCPRO1 etc.
4047 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4048 Revert to old implementation (i.e., before 2011-03-11).
4049
1305621b
YM
40502011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4051
4052 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4053 of scroll runs so as to avoid assigning disabled bogus rows and
4054 unnecessary graphics copy operations.
4055
8c9afb46
EZ
40562011-11-27 Eli Zaretskii <eliz@gnu.org>
4057
4058 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4059 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4060 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4061 (malloc, free, realloc, calloc): Redirect to e_* only when
4062 compiling Emacs.
4063
4064 * lisp.h (GCTYPEBITS): Move before first use.
4065 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4066 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4067 this macro definition.
4068
4069 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4070 _MSC_VER.
4071
54e9e3bf
JD
40722011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4073
6d5eb5b0
SM
4074 * gtkutil.c (xg_create_frame_widgets):
4075 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4076 present with Gtk+ 2.0.
4077
83aca1cb
PE
40782011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4079
4080 * fileio.c (Finsert_file_contents): Undo previous change; see
4081 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4082
5b76caa4
PE
40832011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4084
4085 Rename locals to avoid shadowing.
4086 * fileio.c (Finsert_file_contents):
4087 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4088 * process.c (wait_reading_process_output):
4089 Rename inner 'proc' to 'p' to avoid shadowing.
4090 Indent for consistency with usual Emacs style.
4091
8c535114
EZ
40922011-11-25 Eli Zaretskii <eliz@gnu.org>
4093
4094 * xdisp.c (redisplay_window): If cursor row is not fully visible
4095 after recentering, and scroll-conservatively is set to a large
4096 number, scroll window by a few more lines to make the cursor fully
4097 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4098 (start_display): Don't move to the next line if the display should
4099 start at a newline that is part of a display vector or an overlay
4100 string. (Bug#10119)
8c535114 4101
fa4fdb5c
JL
41022011-11-24 Juri Linkov <juri@jurta.org>
4103
4104 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4105 after the `MagickPingImage' call. (Bug#10112)
4106
90ec88df
CY
41072011-11-23 Chong Yidong <cyd@gnu.org>
4108
4109 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4110
56e2e794
MR
41112011-11-23 Martin Rudalics <rudalics@gmx.at>
4112
4113 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4114 making another buffer current. (Bug#10114)
4115
b6e64c41
GM
41162011-11-23 Glenn Morris <rgm@gnu.org>
4117
4118 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4119
6b21de18
CY
41202011-11-23 Chong Yidong <cyd@gnu.org>
4121
4122 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4123 using it (Bug#5984).
4124
b12cd789
EZ
41252011-11-22 Eli Zaretskii <eliz@gnu.org>
4126
4127 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4128 and header-lines, as they don't have one computed for them.
4129 (Bug#10098)
4130
4131 * .gdbinit (prow): Make displayed values more self-explaining.
4132 Add row's hash code.
4133
261b6fd4
LMI
41342011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4135
4136 * process.c (wait_reading_process_output): Fix asynchrounous
4137 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4138 (wait_reading_process_output): Add comment and URL.
261b6fd4 4139
e7cfd277
JD
41402011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4141
4142 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4143
a9b9b7f5
CY
41442011-11-21 Chong Yidong <cyd@gnu.org>
4145
4146 * window.c (Fnext_window, Fprevious_window): Doc fix.
4147
b0d15b4f
SM
41482011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4149
4150 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4151
fe7a3057
JB
41522011-11-20 Juanma Barranquero <lekktu@gmail.com>
4153
4154 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4155
d2999b1a
MR
41562011-11-20 Martin Rudalics <rudalics@gmx.at>
4157
4158 * window.c (Fset_window_combination_limit): Rename argument
4159 STATUS to LIMIT.
4160 (Vwindow_combination_limit): Remove "status" from doc-string.
4161
d5ff9cd0
AS
41622011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4163
4164 * m/ibms390.h: Remove.
4165 * m/ibms390x.h: Don't include "ibms390.h".
4166
a5bb9bd3
SM
41672011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4168
4169 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4170 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4171
cd1181db
JB
41722011-11-20 Juanma Barranquero <lekktu@gmail.com>
4173
4174 * casetab.c (Fset_case_table):
4175 * charset.c (Fcharset_after): Fix typos.
4176
615a3b8d 41772011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4178
17e845af
PE
4179 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4180 Otherwise, valgrind does not work on some platforms.
4181 Problem reported by Andreas Schwab in
6a0bf43d
PE
4182 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4183 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4184 is set, removing the need for VIRT_ADDRESS_VARIES.
4185 (PURE_P): Use a more-efficient implementation that needs just one
4186 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4187 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4188 to 4 (xorl, subq, cmpq, setbe).
4189 * alloc.c (pure): Always extern now, since that's the
4190 VIRT_ADDR_VARIES behavior.
4191 (PURE_POINTER_P): Use a single comparison, not two, for
4192 consistency with the new puresize.h.
4193 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4194 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4195 Remove VIRT_ADDR_VARIES no longer needed.
4196
f8fe6f96
EZ
41972011-11-19 Eli Zaretskii <eliz@gnu.org>
4198
4199 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4200 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4201 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4202 behave as if the cursor position were at the window margin.
4203
4204 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4205 and the cursor position is out of bounds, behave as if the cursor
4206 position were at the window margin. (Bug#10075)
4207
df05a53c
CY
42082011-11-18 Chong Yidong <cyd@gnu.org>
4209
4210 * window.c (Fwindow_combination_limit): Make first argument
4211 non-optional, since it is meaningless for live windows like the
4212 selected window.
61ccba97 4213
2071918e
DA
42142011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4215
4216 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4217
b50a28de
SM
42182011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4219
4220 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4221 (graft_intervals_into_buffer): Simplify.
4222
015137db
EZ
42232011-11-18 Eli Zaretskii <eliz@gnu.org>
4224
4225 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4226 hash values of the two rows.
4227 (copy_row_except_pointers): Preserve the used[] arrays and the
4228 hash values of the two rows. (Bug#10035)
68c95424 4229 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4230
4231 * xdisp.c (row_hash): New function, body extracted from
4232 compute_line_metrics.
4233 (compute_line_metrics): Call row_hash, instead of computing the
4234 hash code inline.
4235
4236 * dispnew.c (verify_row_hash): Call row_hash for computing the
4237 hash code of a row, instead of duplicating code from xdisp.c.
4238
4239 * dispextern.h (row_hash): Add prototype.
4240
a2addb04
TH
42412011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4242
4243 * frame.c (delete_frame): Don't delete the terminal when the last
4244 X frame is closed if emacs is built with GTK toolkit.
4245
df85d315
JB
42462011-11-17 Juanma Barranquero <lekktu@gmail.com>
4247
4248 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4249
a0c2d0ae
MR
42502011-11-17 Martin Rudalics <rudalics@gmx.at>
4251
4252 * window.c (Vwindow_splits): Rename to
4253 Vwindow_combination_resize. Suggested by Juri Linkov.
4254 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4255 of Vwindow_splits.
4256
58179cce
JB
42572011-11-16 Juanma Barranquero <lekktu@gmail.com>
4258
7877f373
JB
4259 * nsfns.m (Fns_font_name):
4260 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4261
b6f67890
MR
42622011-11-16 Martin Rudalics <rudalics@gmx.at>
4263
4264 * window.h (window): Rename slot "nest" to "combination_limit".
4265 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4266 (Fset_window_nest): Rename to Fset_window_combination_limit.
4267 (Vwindow_nest): Rename to Vwindow_combination_limit.
4268 (recombine_windows, make_parent_window, make_window)
4269 (Fsplit_window_internal, saved_window)
4270 (Fset_window_configuration, save_window_save): Rename all
4271 occurrences of window_nest to window_combination_limit.
4272
c7015153
JB
42732011-11-15 Juanma Barranquero <lekktu@gmail.com>
4274
4275 * image.c (imagemagick_load_image): Fix typo.
4276
322ad6ec
EZ
42772011-11-14 Eli Zaretskii <eliz@gnu.org>
4278
4279 * xdisp.c (display_line): Move the call to
4280 highlight_trailing_whitespace before the call to
4281 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4282 faces of all the glyphs to compute ROW's hash value.
4283 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4284
f067b8ec
JB
42852011-11-14 Juanma Barranquero <lekktu@gmail.com>
4286
4287 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4288 just return (bug#10044).
4289
1e5b2111
EZ
42902011-11-12 Eli Zaretskii <eliz@gnu.org>
4291
7ef3cbd5
EZ
4292 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4293 with user-defined heap size. Bump the default size of the temacs
4294 heap to 27MB, to avoid memory warning when running temacs.
4295 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4296
1e5b2111
EZ
4297 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4298 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4299 (verify_row_hash) [XASSERTS]: New function.
4300 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4301 that the hash value of glyph rows is correct.
1e5b2111 4302
89d61221
MR
43032011-11-12 Martin Rudalics <rudalics@gmx.at>
4304
4305 * window.h (window): Remove splits slot.
4306 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4307 (Fdelete_other_windows_internal, make_parent_window)
4308 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4309 (Fset_window_configuration, save_window_save): Don't deal with
4310 split status of windows.
4311 (saved_window): Remove splits slot.
4312 (Vwindow_splits): Rewrite doc-string.
4313
97f18cc8
JD
43142011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4315
4316 * xfns.c (unwind_create_frame):
4317 * nsfns.m (unwind_create_frame):
4318 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4319 Vframe_list (Bug#9999).
4320
22a648b4
DA
43212011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4322
0b381c7e 4323 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4324
659afede
KH
43252011-11-11 Kenichi Handa <handa@m17n.org>
4326
4327 * callproc.c (Fcall_process): Set the member dst_multibyte of
4328 process_coding.
4329
9ac0394b
KH
43302011-11-11 Johan Bockgård <bojohan@gnu.org>
4331
4332 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4333 avoid a crash (bug#9496).
4334
2fbdc249
CY
43352011-11-09 Chong Yidong <cyd@gnu.org>
4336
4337 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4338 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4339
ac6b1f81
PE
43402011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4341
4342 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4343
09db192c
PE
43442011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4345
4346 Avoid some portability problems by eschewing 'extern inline' functions.
4347 The trivial performance wins aren't worth the portability hassles; see
4348 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4349 et seq.
4350 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4351 (window_box_width, window_box_left, window_box_left_offset)
4352 (window_box_right, window_box_right_offset): Undo previous change,
4353 by removing the "extern"s.
4354 * intervals.c (adjust_intervals_for_insertion)
4355 (adjust_intervals_for_deletion): Undo previous change,
4356 making these static again.
4357 (offset_intervals, temp_set_point_both, temp_set_point)
4358 (copy_intervals_to_string): No longer inline.
4359 * xdisp.c (window_text_bottom_y, window_box_width)
4360 (window_box_height, window_box_left_offset)
4361 (window_box_right_offset, window_box_left, window_box_right)
4362 (window_box): No longer inline.
4363
105216ed
CY
43642011-11-08 Chong Yidong <cyd@gnu.org>
4365
4366 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4367 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4368 Signal an error if not a live window.
105216ed
CY
4369 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4370 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4371
ae9e237f
JB
43722011-11-07 Juanma Barranquero <lekktu@gmail.com>
4373
4374 * lisp.h (syms_of_abbrev): Remove declaration.
4375 Reported by CHENG Gao <chenggao@royau.me>.
4376
c7aa8333
EZ
43772011-11-07 Eli Zaretskii <eliz@gnu.org>
4378
4379 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4380 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4381 of temacs in GUI mode.
4382
be7f5545
MR
43832011-11-07 Martin Rudalics <rudalics@gmx.at>
4384
4385 * window.h: Declare delete_all_child_windows instead of
4386 delete_all_subwindows.
4387 * window.c (Fwindow_nest, Fset_window_nest)
4388 (Fset_window_new_total, Fset_window_new_normal)
4389 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4390 (delete_all_subwindows): Rename to delete_all_child_windows.
4391 (Fdelete_other_windows_internal, Fset_window_configuration):
4392 Call delete_all_child_windows instead of delete_all_subwindows.
4393 * frame.c (delete_frame): Call delete_all_child_windows instead
4394 of delete_all_subwindows.
4395
ca78dc43
PE
43962011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4397
4398 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4399 This is also needed for porting to any host where GC_MARK_STACK is
4400 not GC_MAKE_GCPROS_NOOPS.
4401 (which_symbols): Use it.
4402
a0241d01
KH
44032011-11-07 Kenichi Handa <handa@m17n.org>
4404
4405 * coding.c (coding_set_destination): Check coding->src_pos only
4406 when coding->src_object is a buffer (bug#9910).
4407
4408 * process.c (send_process): Set the member src_multibyte of coding
4409 to 0 (bug#9911) when sending a unibyte text.
4410
4411 * callproc.c (Fcall_process): Set the member src_multibyte of
4412 process_coding to 0 (bug#9912).
4413
a64bfdfa 44142011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4415
4416 * xmenu.c (cleanup_widget_value_tree): New function.
4417 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4418 calling free_menubar_widget_value_tree directly (Bug#9830).
4419
cb41b32a
PE
44202011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4421
4422 Fix some portability problems with 'inline'.
4423 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4424 (window_box_width, window_box_left, window_box_left_offset)
4425 (window_box_right, window_box_right_offset): Declare extern.
4426 Otherwise, these inline functions do not conform to C99 and
4427 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4428 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4429 * intervals.c (adjust_intervals_for_insertion)
4430 (adjust_intervals_for_deletion): Now extern, because otherwise the
4431 extern inline functions 'offset_intervals' couldn't refer to it.
4432 (static_offset_intervals): Remove.
4433 (offset_intervals): Rewrite using the old contents of
4434 static_offset_intervals. The old version didn't conform to C99
4435 because an extern inline function contained a reference to an
4436 identifier with static linkage.
4437
b7041366
AS
44382011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4439
4440 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4441 GC.
4442
88a37c4d
EZ
44432011-11-06 Eli Zaretskii <eliz@gnu.org>
4444
4445 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4446 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4447 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4448 return Qleft_to_right.
4449
49745b39
CY
44502011-11-06 Chong Yidong <cyd@gnu.org>
4451
4452 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4453 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4454 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4455 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4456 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4457 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4458 (Fwindow_vscroll): Doc fix.
4459 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4460 argument, since it makes no sense to pass a live window and for
4461 consistency with window-child.
4462
1f05cd82
CS
44632011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4464
4465 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4466 support MSVC.
4467
22610910
JR
44682011-11-05 Jason Rumney <jasonr@gnu.org>
4469
4470 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4471 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4472 fonts (Bug#6029).
4473 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4474 bitwise arithmetic preventing use of unicode-sip and non-truetype
4475 opentype fonts.
4476
a06776b2
EZ
44772011-11-05 Eli Zaretskii <eliz@gnu.org>
4478
3ad924ba
EZ
4479 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4480 "emacs"-only part.
4481
a06776b2
EZ
4482 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4483 initialization code to keep similarity to xfns.c after changes
4484 from 2011-11-05.
4485
c9e7db78
JD
44862011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4487
a97f8f3f
JD
4488 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4489 (unwind_create_frame): New function (Bug#9943).
4490 (Fx_create_frame): Restructure code to be more similar to the one in
4491 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4492 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4493 Move terminal->reference_count++ just before making the frame official
4494 (Bug#9943).
4495
4496 * nsterm.m (x_free_frame_resources): New function.
4497 (x_destroy_window): Move code to x_free_frame_resources.
4498
c9e7db78 4499 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4500 (Fx_create_frame, x_create_tip_frame):
4501 Move terminal->reference_count++ just before making the frame
75f1671a 4502 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4503 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4504
a6fc3b5c
EZ
45052011-11-05 Eli Zaretskii <eliz@gnu.org>
4506
4507 Support MSVC build with newer versions of Visual Studio.
4508 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4509 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4510 nt/gmake.defs.
4511
4512 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4513 which are not supported by MSVC.
4514 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4515 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4516 bitfields.
4517 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4518 types in bitfields.
4519 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4520
4521 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4522
58179cce 45232011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4524
4525 Support MSVC build with newer versions of Visual Studio.
4526 * w32.c: Don't include w32api.h for MSVC.
4527 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4528
4529 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4530 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4531 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4532 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4533 e_* cousins.
4534 (alloca) [_MSC_VER]: Define to _alloca.
4535
4536 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4537
4538 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4539
a58c13ed
EZ
45402011-11-04 Eli Zaretskii <eliz@gnu.org>
4541
4542 * xdisp.c (note_mouse_highlight): If either of
4543 previous/next-single-property-change returns nil, treat that as
4544 the beginning or the end of the buffer. (Bug#9955)
4545
fe0b6370
JD
45462011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4547
a58c13ed 4548 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4549 label is not null (Bug#9951).
4550 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4551 may be NULL.
4552
89bd5ee1
EZ
45532011-11-04 Eli Zaretskii <eliz@gnu.org>
4554
4555 * window.c (Fwindow_body_size): Mention in the doc string that the
4556 return value is in frame's canonical units. (Bug#9949)
4557
84c3edb9
EZ
45582011-11-03 Eli Zaretskii <eliz@gnu.org>
4559
4e2fb5c7
EZ
4560 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4561
84c3edb9 4562 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4563 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4564 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4565
bc17a887
EZ
45662011-11-01 Eli Zaretskii <eliz@gnu.org>
4567
4568 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4569 Don't stop backward scan on the continuation glyph, even though
4570 its CHARPOS is positive.
6d5eb5b0
SM
4571 (mouse_face_from_buffer_pos, note_mouse_highlight):
4572 Rename cover_string to disp_string.
bc17a887 4573
4ee88440
MR
45742011-11-01 Martin Rudalics <rudalics@gmx.at>
4575
4576 * window.c (temp_output_buffer_show): Don't use
4577 Vtemp_buffer_show_specifiers.
4578 (Vtemp_buffer_show_specifiers): Remove unused variable.
4579
c2ff3c02
EZ
45802011-10-30 Eli Zaretskii <eliz@gnu.org>
4581
4582 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4583 past the beginning of the current glyph matrix.
4584
58179cce 45852011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4586
4587 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4588 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4589 HAVE_GTK3 (Bug#9869).
b77a6a7f 4590
3b574623
JD
4591 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4592 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4593
b77a6a7f
JD
4594 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4595
4596 * xterm.c: Declare x_handle_net_wm_state to return int.
4597 (handle_one_xevent): Check if we are iconified but don't have
4598 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4599 (get_current_wm_state): Return non-zero if not hidden,
4600 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4601 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4602 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4603 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4604
196e41e4
PE
46052011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4606
4607 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4608 so that this new function doesn't get optimized away by a
4609 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4610
021f2e1a
AS
46112011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4612
4613 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4614
8b058d44
EZ
46152011-10-29 Eli Zaretskii <eliz@gnu.org>
4616
4617 Fix the `xbytecode' command.
4618 * .gdbinit (xprintbytestr): New command.
b50a28de 4619 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4620 (xbytecode): Print the byte-code string as well.
4621
4452fb80
EZ
46222011-10-29 Kim Storm <storm@cua.dk>
4623
8b058d44
EZ
4624 * alloc.c (which_symbols): New function.
4625
21b72067
AS
46262011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4627
4628 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4629 line. (Bug#9903)
4630
83ed7b5c
GM
46312011-10-29 Glenn Morris <rgm@gnu.org>
4632
4633 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4634 Not clear what it was for, and it causes various bugs. (Bug#9839)
4635
5a7a728b
EZ
46362011-10-28 Eli Zaretskii <eliz@gnu.org>
4637
4638 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4639 possible random value that matches one of those tested as
4640 condition to clear the mouse face.
4641
d3d0842f
CY
46422011-10-28 Chong Yidong <cyd@gnu.org>
4643
4644 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4645
31b39d13
DN
46462011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4647
4648 * window.c (make_window): Initialize phys_cursor_on_p.
4649
9aba6043
SM
46502011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4651
4652 * lisp.h (struct Lisp_Symbol): Update comments.
4653
c20992f4
JB
46542011-10-28 Juanma Barranquero <lekktu@gmail.com>
4655
4656 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4657
db4f02f2
EZ
46582011-10-28 Eli Zaretskii <eliz@gnu.org>
4659
4660 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4661 <oslsachem@gmail.com> for helping to debug this.
4662
4663 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4664 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4665 (g_b_init_get_glyph_outline_w): New static variables.
4666 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4667 (GetGlyphOutlineW_Proc): New typedefs.
4668 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4669 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4670 New functions.
4671 (w32font_open_internal, compute_metrics):
4672 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4673 instead of calling the "wide" APIs directly.
4674
4675 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4676
4677 * w32.h (syms_of_w32font): Add prototype.
4678
87e68db4
JB
46792011-10-27 Juanma Barranquero <lekktu@gmail.com>
4680
4681 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4682 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4683 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4684 (Fmove_to_window_line): Doc fix.
4685
435c1d67
CY
46862011-10-27 Chong Yidong <cyd@gnu.org>
4687
4688 * process.c (make_process): Set gnutls_state to NULL.
4689
4690 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4691 non-NULL, regardless of GNUTLS_INITSTAGE.
4692 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4693 an error. Set process slots as soon as we allocate them.
4694
4695 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4696
9c6c6f49
CY
46972011-10-27 Chong Yidong <cyd@gnu.org>
4698
9aba6043
SM
4699 * gnutls.c (emacs_gnutls_deinit): New function.
4700 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4701 (Fgnutls_deinit, Fgnutls_boot): Use it.
4702
4703 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4704 (deactivate_process): Call emacs_gnutls_deinit.
4705
657d08d3
JB
47062011-10-27 Juanma Barranquero <lekktu@gmail.com>
4707
4708 * image.c (x_create_x_image_and_pixmap):
4709 * w32.c (sys_rename, w32_delayed_load):
4710 * w32font.c (fill_in_logfont):
4711 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4712
5430d399
JB
47132011-10-26 Juanma Barranquero <lekktu@gmail.com>
4714
4715 * w32fns.c (w32_default_color_map): New function,
4716 extracted from Fw32_default_color_map.
a7ef684b 4717 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4718
fe0055fa
PE
47192011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4720
4721 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4722
e6346438
SM
47232011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4724
4725 * keyboard.c (test_undefined): New function (bug#9751).
4726 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4727
e112cc37
ET
47282011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4729
4730 * sysdep.c (init_sys_modes): Fix the check for the controlling
4731 terminal (Bug#6649).
4732
7b5d6677
EZ
47332011-10-20 Eli Zaretskii <eliz@gnu.org>
4734
4735 * dispextern.h (struct bidi_it): New member next_en_type.
4736
4737 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4738 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4739 current character, check also for next_en_type being WEAK_EN.
4740 (bidi_resolve_weak): Don't enter the expensive loop if the current
4741 position is before next_en_pos. Record the bidi type of the first
4742 non-ET, non-BN character we find, in addition to its position.
4743 (bidi_level_of_next_char): Invalidate next_en_type when
4744 next_en_pos is over-stepped.
4745
7da0b018
PE
47462011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4747
4748 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4749 * editfns.c: Rewrite current-time-zone so that it invokes
4750 the equivalent of (format-time-string "%Z") to get the time zone name.
4751 This fixes a bug when the time zone name contains characters that
4752 need converting from the system time locale to Emacs internal format.
4753 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4754 that patch fixed format-time-string to do the conversion, but
4755 I forgot to fix current-time-zone.
4756 (format_time_string): New function, containing most of
4757 what Fformat_time_string used to contain.
4758 (Fformat_time_string): Rewrite in terms of format_time_string.
4759 This doesn't change this function's behavior.
4760 (current-time-zone): Rewrite to use format_time_string.
4761 This fixes the bug reported by Michael Schierl in
4762 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4763 Jason Rumney's 2007-06-07 change worked around this bug, but
4764 didn't fix it.
4765 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4766
8547b010
EZ
47672011-10-19 Eli Zaretskii <eliz@gnu.org>
4768
4769 * xdisp.c (start_display): If the character at POS is displayed
4770 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4771 (try_window_reusing_current_matrix): If a line ends in a display
4772 vector or the next line starts in a display vector, continue
4773 redrawing the window even though the character position of
4774 start_row was reached.
8547b010
EZ
4775 (Bug#9771, part 2)
4776
4e948d15
CY
47772011-10-18 Chong Yidong <cyd@gnu.org>
4778
4779 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4780 with nobreak-char-display too.
4781
4787455f
EZ
47822011-10-18 Eli Zaretskii <eliz@gnu.org>
4783
4784 Fix part 3 of bug#9771.
4785 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4786 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4787 non-neutral characters if the current character is a paragraph
4788 separator (a.k.a. Newline). This avoids running the same
4789 expensive loop twice, once when we consume the preceding newline
4790 and the other time when the line actually needs to be displayed.
4791 Avoid the loop when we see neutrals on the base embedding level
4792 following a character whose directionality is the same as the
4793 paragraph's. This avoids running the expensive loop when a line
4794 ends in a long sequence of neutrals, like control characters.
4795 Add assertion against STRONG_AL type. Slightly rearrange code
4796 that determines the type of a neutral given the first non-neutral
4797 that follows it.
4798 (bidi_level_of_next_char): Set next_en_pos to zero when
4799 invalidating its info.
4800
2c91f553
EZ
48012011-10-17 Eli Zaretskii <eliz@gnu.org>
4802
4803 * xdisp.c (push_display_prop): Determine whether to record string
4804 or buffer position by IT->string, not by IT->method. Allow
4805 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4806 (move_it_vertically_backward): Don't look for character position
4807 immediately after the newline when in a continuation line.
4808 (Bug#9771, part 1)
2c91f553 4809
c7b08b0d
MR
48102011-10-15 Martin Rudalics <rudalics@gmx.at>
4811
4812 * window.c (coordinates_in_window): Rewrite and delabelize
4813 vertical border check. (Bug#5357) (Bug#9618)
4814
6b02f655
SM
48152011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4816
4817 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4818 errors in XSetWindowBorder (bug#9310).
4819
81d40c92
DA
48202011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4821
4822 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4823 avoid crash when xmalloc overrun checking is enabled.
4824
d4172c3b
EZ
48252011-10-13 Eli Zaretskii <eliz@gnu.org>
4826
4827 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4828 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4829 cursor motion with <left> and <right> arrow keys.
4830
4831 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4832 some callers set that themselves.
4833
b00eea75
EZ
48342011-10-12 Eli Zaretskii <eliz@gnu.org>
4835
4836 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4837 display string and the previous row comes from the same string and
4838 is empty. (Bug#9739) (Bug#9738)
4839
8fe012c4
SM
48402011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4841
4842 * doc.c (get_doc_string): Encode file name (bug#9735).
4843
0074aef2
EZ
48442011-10-12 Eli Zaretskii <eliz@gnu.org>
4845
79beb178
EZ
4846 * bidi.c (bidi_level_of_next_char):
4847 * xdisp.c (get_visually_first_element): Remove old incorrect
4848 comments regarding the Unicode Line Separator character.
4849
0074aef2
EZ
4850 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4851
6e4b3fbe
DA
48522011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4853
4854 * alloc.c (Fgc_status): Do not access beyond zombies array
4855 boundary if nzombies > MAX_ZOMBIES.
4856 * alloc.c (dump_zombies): Add missing format specifier.
4857
0324f3af
PE
48582011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4859
b5525cac
PE
4860 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4861 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4862
0324f3af
PE
4863 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4864 Some packages use them to denote characters with modifiers.
4865
e9b5f888
AS
48662011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4867
4868 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4869 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4870 matching a pp-number. Rename parameter var to var1.
4871
127827c0
SM
48722011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4873
4874 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4875
c8fd3bd0
GM
48762011-10-08 Glenn Morris <rgm@gnu.org>
4877
4878 * callint.c (Fcall_interactively): Give a more explicit error for the
4879 'c' case with a non-character input. (Bug#8479)
4880
352ec8ff
EZ
48812011-10-08 Eli Zaretskii <eliz@gnu.org>
4882
03669ccb
EZ
4883 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4884 lines.
7061c986
EZ
4885 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4886 lines that are hscrolled on the left.
03669ccb 4887
352ec8ff
EZ
4888 * dispnew.c (buffer_posn_from_coords): Account for a possible
4889 presence of header-line. (Bug#4426)
4890
a66cfb1c
SM
48912011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4892
6b02f655
SM
4893 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4894 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4895
7c5ee88e
PE
48962011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4897
4898 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4899 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4900 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4901 this makes Emacs dump core during garbage collection on rare
4902 occasions. sizeof is obviously inferior to offsetof here, so
4903 stick with offsetof.
4904 (GC_POINTER_ALIGNMENT): New macro.
4905 (mark_memory): Omit 3rd (offset) arg; caller changed.
4906 Don't assume EMACS_INT alignment is the same as pointer alignment.
4907
df1bbe5b
SM
49082011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4909
4910 * keyboard.c (read_key_sequence_remapped): New var.
4911 (read_key_sequence): Compute remapping in the right buffer.
4912 (command_loop_1): Use read_key_sequence's remapping directly.
4913
51553db6
SM
49142011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4915
32c1fffd
SM
4916 * dired.c (file_name_completion): Don't expand file name.
4917 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4918 before checking file name handler.
4919
51553db6
SM
4920 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4921 they've been requested explicitly (bug#9591).
4922
b6bd1599 49232011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4924
4925 * keymap.c (Fsingle_key_description): Use make_specified_string
4926 instead of build_string to build string from push_key_description.
4927 (Bug#5193)
4928
f701dc2a
PE
49292011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4930
4222c55d
PE
4931 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4932 This fixes a Y2038 bug on 64-bit hosts.
4933 * buffer.c (reset_buffer):
4934 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4935 (Fclear_buffer_auto_save_failure):
4936 Use 0, not -1, to represent an unset failure time, since time_t
4937 might not be signed.
4938
f701dc2a
PE
4939 Remove dependency on glibc malloc internals.
4940 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4941 Move back here from lisp.h, but with their new implementations.
4942 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4943 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4944 * charset.c (charset_table_init): New static var.
4945 (syms_of_charset): Use it instead of xmalloc. This removes a
4946 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4947 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4948 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4949 Move back to alloc.c.
4950 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4951 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4952
9ceebf39
JD
49532011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4954
4955 * nsterm.m (windowDidResize): Call x_set_window_size only when
4956 ns_in_resize is true. Otherwise set pixelwidth/height and
4957 call change_frame_size (Bug#9628).
4958
cb993c58
PE
49592011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4960
3930c88b
PE
4961 Port --enable-checking=all to Fedora 14 x86-64.
4962 * charset.c (syms_of_charset): Also account for glibc malloc's
4963 internal overhead when calculating the initial malloc maximum.
4964
cb993c58
PE
4965 Port --enable-checking=all to Fedora 14 x86.
4966 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4967 Move to lisp.h.
4968 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4969 (overrun_check_realloc, overrun_check_free):
4970 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4971 That way, xmalloc returns a properly-aligned pointer even if
4972 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4973 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4974 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4975 into account when calculating the initial malloc maximum.
4976 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4977 Move here from alloc.c, so that charset.c can use it too.
4978 Properly align; the old code wasn't right for common 32-bit hosts
4979 when configured with --enable-checking=all.
4980 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4981 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4982
31bed486
EZ
49832011-09-29 Eli Zaretskii <eliz@gnu.org>
4984
04c70788 4985 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4986 use EDOM.
4987
fbcaa2f3
EZ
49882011-09-28 Eli Zaretskii <eliz@gnu.org>
4989
4990 * xdisp.c (compute_display_string_end): If there's no display
4991 string at CHARPOS, return -1.
4992
4993 * bidi.c (bidi_fetch_char): When compute_display_string_end
4994 returns a negative value, treat the character as a normal
4995 character not covered by a display string. (Bug#9624)
4996
a239d4e9
JB
49972011-09-28 Juanma Barranquero <lekktu@gmail.com>
4998
4999 * lread.c (Fread_from_string): Fix typo in docstring.
5000
88652fd5
EZ
50012011-09-27 Eli Zaretskii <eliz@gnu.org>
5002
5003 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5004 newline, reseat the iterator instead of bidi-iterating there one
5005 character at a time. (Bug#9610)
32c1fffd
SM
5006 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5007 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5008
ed497dd4
AS
50092011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5010
5011 * lread.c (readevalloop): Use correct code for NBSP.
5012 (read1): Likewise. (Bug#9608)
5013
b2bf61aa
MA
50142011-09-25 Michael Albinus <michael.albinus@gmx.de>
5015
5016 * dbusbind.c (Fdbus_register_signal): When service is not
5017 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5018
32bbb17c
GM
50192011-09-25 Glenn Morris <rgm@gnu.org>
5020
5021 * buffer.c (truncate-lines): Doc fix.
5022
94e0933e
CY
50232011-09-24 Chong Yidong <cyd@stupidchicken.com>
5024
5025 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5026 (Fset_window_next_buffers): Doc fix.
5027
cddde921
GM
50282011-09-24 Glenn Morris <rgm@gnu.org>
5029
5030 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5031
1260aef1
PE
50322011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5033
25b4bfa0
PE
5034 Fix minor problems found by static checking.
5035 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5036 * indent.c (Fvertical_motion): Fix == vs = typo.
5037
e3cbd34b
EZ
50382011-09-24 Eli Zaretskii <eliz@gnu.org>
5039
a66cfb1c
SM
5040 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5041 Default value is now t. Doc fix.
6bf7006f 5042
e3cbd34b 5043 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5044 logic when moving up, not only when moving down. Fix the
e3cbd34b 5045 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5046 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5047
5048 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5049 CHARPOS is covered by a display string which includes newlines.
5050 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5051 is covered by a display string with embedded newlines.
5052
a3de0cbd
MA
50532011-09-24 Michael Albinus <michael.albinus@gmx.de>
5054
5055 * dbusbind.c (Fdbus_register_signal): Add match rule to
5056 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5057 (Fdbus_register_method, Vdbus_registered_objects_table):
5058 Fix docstring.
a3de0cbd 5059
b260039d
JM
50602011-09-24 Jim Meyering <meyering@redhat.com>
5061
32c1fffd 5062 do not ignore write error for any output size
b260039d
JM
5063 The previous change was incomplete.
5064 While it makes emacs --batch detect the vast majority of stdout
5065 write failures, errors were still ignored whenever the output size is
5066 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5067 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5068 && echo FAIL: ignored write error
5069 FAIL: ignored write error
5070 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5071 && echo FAIL: ignored write error
5072 FAIL: ignored write error
5073 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5074
8eca8a7c
AS
50752011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5076
5077 * emacs.c (Fkill_emacs): In noninteractive mode exit
5078 non-successfully if a write error occurred on stdout. (Bug#9574)
5079
3341db62
EZ
50802011-09-21 Eli Zaretskii <eliz@gnu.org>
5081
5082 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5083 the xassert test.
5084
5085 * dispextern.h (struct it): Update the comment documenting what
5086 can it->OBJECT be.
5087
8c203dbf
EZ
50882011-09-20 Eli Zaretskii <eliz@gnu.org>
5089
5090 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5091 a display string, extend search for cursor position to end of row.
5092 (find_row_edges): If the row ends in a newline from a display
5093 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5094 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5095 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5096 non-empty line. Fixes confusing cursor motion with arrow keys at
5097 the beginning of a line that starts with whitespace.
8c203dbf 5098
a4824228
LMI
50992011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5100
5101 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5102 (bug#9493).
5103
33ed493b
CY
51042011-09-18 Chong Yidong <cyd@stupidchicken.com>
5105
5106 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5107 boolean (Bug#9154).
5108
56cd55c8
EZ
51092011-09-18 Eli Zaretskii <eliz@gnu.org>
5110
5111 * xdisp.c (display_line): Record maximum and minimum buffer
5112 positions even if no glyphs were produced (e.g., by a zero-width
5113 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5114 buffer positions that will be removed from the glyph row because
5115 they don't fit.
c02dcedf
EZ
5116 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5117 column is beyond frame width: don't subtract 1 "pixel" when
5118 computing width of the stretch.
3e62b7e0
EZ
5119 (reseat_at_next_visible_line_start): Undo the change made on
5120 2011-09-17 that saved paragraph information and restored it after
5121 the call to `reseat'. (Bug#9545)
56cd55c8 5122
5ed99d36 51232011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5124
5125 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5126 and turn window cursor on if cleared (Bug#9415).
5127
5ed99d36 51282011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5129
5130 * search.c (boyer_moore): Take unibyte characters from pattern
5131 literally. (Bug#9458)
5132
9bade7b2
EZ
51332011-09-18 Eli Zaretskii <eliz@gnu.org>
5134
5135 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5136
e5e9d610
PE
51372011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5138
87e4427a
PE
5139 Fix minor problem found by static checking.
5140 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5141 initialized, to pacify gcc -Wuninitialized.
5142
e5e9d610
PE
5143 * fileio.c: Report proper errno when syscall falls.
5144 (Finsert_file_contents): Save and restore errno,
5145 so that report_file_error outputs the correct diagnostic.
5146 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5147
a1674f0b
EZ
51482011-09-18 Eli Zaretskii <eliz@gnu.org>
5149
5150 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5151
fbfb6dd4
EZ
51522011-09-17 Eli Zaretskii <eliz@gnu.org>
5153
5154 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5155 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5156
bb187662
EZ
51572011-09-17 Eli Zaretskii <eliz@gnu.org>
5158
1137e8b8 5159 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5160 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5161
5162 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5163 (bidi_find_paragraph_start): Search back for paragraph beginning
5164 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5165 (bidi_move_to_visually_next): Only trigger paragraph-related
5166 computations when the last character is a newline or at EOB, not
5167 just any NEUTRAL_B. (Bug#9470)
5168
bb187662
EZ
5169 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5170 truncated lines if point is covered by a display string. (Bug#9524)
5171
2e621251
PE
51722011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5173
5174 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5175 (cons_to_x_long): New function.
5176 (lisp_data_to_selection_data): Use it. Correct the test for
5177 short-versus-long data; it was negated. Break out of vector
5178 loop, for efficiency, when a long datum is discovered.
5179
91a15bc6
SM
51802011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5181
5182 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5183
b41c3a35
EZ
51842011-09-16 Eli Zaretskii <eliz@gnu.org>
5185
5186 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5187 GCC PR/17406) by declaring this function with external scope.
5188
7812ba2d
PE
51892011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5190
5191 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5192 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5193
cf7edc2a
AS
51942011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5195
5196 * editfns.c (Fformat): Correctly handle text properties on "%%".
5197
bd01620e
EZ
51982011-09-15 Eli Zaretskii <eliz@gnu.org>
5199
5200 * xterm.c (x_draw_composite_glyph_string_foreground):
5201 * w32term.c (x_draw_composite_glyph_string_foreground):
5202 * term.c (encode_terminal_code):
5203 * composite.c (composition_update_it, get_composition_id):
5204 * xdisp.c (get_next_display_element)
5205 (fill_composite_glyph_string): Add comments about special meaning
5206 of TAB characters in a composition.
5207
a02719a3
PE
52082011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5209
5210 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5211 This occurs when processing a multibyte format.
5212 Problem reported by Wolfgang Jenker.
a02719a3 5213
72589a3c
JB
52142011-09-15 Johan Bockgård <bojohan@gnu.org>
5215
5216 * xdisp.c (try_cursor_movement): Only check for exact match if
5217 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5218
1c14176c
PE
52192011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5220
5221 Remove unused external symbols.
5222 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5223 * xdisp.c (calc_pixel_width_or_height): Now static.
5224 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5225 * indent.c (check_display_width):
5226 * w32term.c: Fix comment to match code.
5227 * xterm.c, xterm.h (x_catching_errors): Remove.
5228
d2eea5b5
PE
52292011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5230
5231 * xselect.c: Use signed conversions more consistently (Bug#9498).
5232 (selection_data_to_lisp_data): Assume incoming selection data are
5233 signed integers, not unsigned. This is to be consistent with
5234 outgoing selection data, which was modified to use signed integers
5235 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5236 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5237 expects long, not unsigned long.
5238
46888499
EZ
52392011-09-14 Eli Zaretskii <eliz@gnu.org>
5240
5241 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5242 computation of loop end. Reported by Johan Bockgård
5243 <bojohan@gnu.org>.
5244
ef8ef9fb
CY
52452011-09-13 Chong Yidong <cyd@stupidchicken.com>
5246
5247 * frame.c (Fother_visible_frames_p): Function deleted.
5248
fa819fed
EZ
52492011-09-12 Eli Zaretskii <eliz@gnu.org>
5250
5251 * indent.c (compute_motion): Process display vector front to back
5252 rather than the other way around. (Bug#2496)
5253
2ba8e008
SM
52542011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5255
5256 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5257
20f53c69
CY
52582011-09-11 Chong Yidong <cyd@stupidchicken.com>
5259
5260 * minibuf.c (Fread_from_minibuffer): Doc fix.
5261
d562d7a4
EZ
52622011-09-11 Eli Zaretskii <eliz@gnu.org>
5263
5264 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5265 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5266
1c4d7f3d
LMI
52672011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5268
5269 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5270 value for non-existent files.
5271
b885bf36
EZ
52722011-09-11 Eli Zaretskii <eliz@gnu.org>
5273
5274 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5275 set its "size" to -1. This will set the modtime_size field of
5276 the corresponding buffer to -1, which is what
5277 verify-visited-file-modtime expects for files that do not exist.
5278 (Bug#9139)
5279
6612f0bf
PE
52802011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5281
5282 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5283 here ...
5284 * lisp.h: ... from here. push_key_description is no longer
5285 defined in keyboard.c, so its declaration should not be in
5286 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5287 logically belongs with push_key_description.
5288
dfb3f755
PE
52892011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5290
5291 * buffer.h: Include <sys/types.h> instead of <time.h>.
5292 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5293 Problem reported by Herbert J. Skuhra.
5294
3134906c
LMI
52952011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5296
5297 * xml.c (parse_region): Make the parsing work for
5298 non-comment-starting XML files again (bug#9144).
5299
8d903f4e
AS
53002011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5301
5302 * image.c (gif_load): Fix calculation of bottom and right corner.
5303 (Bug#9468)
5304
80ad64f4
EZ
53052011-09-10 Eli Zaretskii <eliz@gnu.org>
5306
5307 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5308 redisplay in small windows.
5309
208a048d
EZ
53102011-09-09 Eli Zaretskii <eliz@gnu.org>
5311
5312 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5313
9b1c252e
MR
53142011-09-08 Martin Rudalics <rudalics@gmx.at>
5315
5316 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5317 Operate on live windows only.
5318
2949f33b
JB
53192011-09-08 Juanma Barranquero <lekktu@gmail.com>
5320
5321 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5322
e08dcafd
EZ
53232011-09-07 Eli Zaretskii <eliz@gnu.org>
5324
5325 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5326 only under bidi iteration.
5327
115b96bd
JD
53282011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5329
5330 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5331
c8199d0f
PE
53322011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5333
5334 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5335 Without this fix, the command to link temacs failed due to an
5336 undefined symbol __builtin_isnan. This is because
5337 /usr/include/iso/math_c99.h #defines isnan(x) to
5338 __builtin_isnan(x), but the bundled gcc, which identifies itself
5339 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5340 a __builtin_isnan.
5341 * floatfns.c (isnan): #undef, and then #define to a clone of
5342 what's in data.c.
5343 (Fisnan): Always define, since it's always available now.
5344 (syms_of_floatfns): Always define isnan at the Lisp level.
5345
e39b275c 53462011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5347
5348 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5349
b2db44d9 53502011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5351
f4af5137 5352 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5353 The previous code assumed that file offsets (off_t values) fit in
5354 EMACS_INT variables, which is not true on typical 32-bit hosts.
5355 The code messed up by falsely reporting buffer overflow in cases
5356 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5357 when "big" contains more than 2**29 bytes, even though this
5358 inserts just one byte and does not overflow the buffer.
5359 (Finsert_file_contents): Store file offsets as off_t
5360 values, not as EMACS_INT values. Check for overflow when
5361 converting between EMACS_INT and off_t. When checking for
5362 buffer overflow or for overlap, take the offsets into account.
5363 Don't use EMACS_INT for small values where int suffices.
5364 When checking for overlap, fix a typo: ZV was used where
5365 ZV_BYTE was intended.
5366 (Fwrite_region): Don't assume off_t fits into 'long'.
5367 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5368
ecfc0a49
MA
53692011-09-05 Michael Albinus <michael.albinus@gmx.de>
5370
5371 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5372
6511acf2 53732011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5374
0999621a 5375 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5376
5377 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5378 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5379 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5380 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5381 (modify_event_symbol): Do not assume that the length of
5382 name_alist_or_stem is safe to alloca and fits in int.
5383 (Fexecute_extended_command): Likewise for function name and binding.
5384 (Frecursion_depth): Wrap around reliably on integer overflow.
5385 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5386 since some callers pass EMACS_INT values.
5387 (Fsingle_key_description): Don't crash if symbol name contains more
5388 than MAX_ALLOCA bytes.
5389 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5390 (get_minibuffer): Arg is now EMACS_INT, not int.
5391 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5392 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5393 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5394
2be7d702
PE
5395 * dbusbind.c (signature_cat): New function.
5396 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5397 Do not overrun buffer; instead, report string overflow.
5398
9d1df220
PE
5399 * dispnew.c (add_window_display_history): Don't overrun buffer.
5400 Truncate instead; this is OK since it's just a log.
5401
33ef5c64
PE
5402 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5403 even if the time zone offset is outlandishly large.
5404 Don't mishandle offset == INT_MIN.
5405
66c6fdd5
PE
5406 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5407 when creating daemon; the previous buffer-overflow check was incorrect.
5408
d749b01b
PE
5409 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5410 which has the guts of the old verror function.
5411
b5cd1905
PE
5412 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5413 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5414
6e1a67fb
PE
5415 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5416 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5417 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5418 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5419 length of string rather than counting it via multiple sprintfs;
5420 that's simpler and more reliable.
c21721cc
PE
5421 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5422 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5423 sprintf, in case result does not fit in int.
5424
c57b67fc
PE
5425 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5426 (fontset_from_font): Print it.
5427
8a401434
PE
5428 * frame.c (tty_frame_count): Now printmax_t, not int.
5429 (make_terminal_frame, set_term_frame_name): Print it.
5430 (x_report_frame_params): In X, window IDs are unsigned long,
5431 not signed long, so print them as unsigned.
5432 (validate_x_resource_name): Check for implausibly long names,
5433 and don't assume name length fits in 'int'.
5434 (x_get_resource_string): Don't blindly alloca invocation name;
5435 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5436 not fit in int.
5437
6e1a67fb
PE
5438 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5439 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5440 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5441
0df02bf3
PE
5442 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5443 Use esprintf, not sprintf, in case result does not fit in int.
5444
48e30793
PE
5445 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5446 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5447 it as a large positive number.
5448 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5449 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5450
a66ff6d8
PE
5451 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5452 in case result does not fit in int.
5453
aca216ff
PE
5454 * print.c (float_to_string): Detect width overflow more reliably.
5455 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5456 buffer overrun. Don't assume list length fits in 'int'. Treat
5457 print length of 0 as 0, not as infinity; to be consistent with other
5458 uses of print length in this function. Don't overflow print length
5459 index. Don't assume hash table size fits in 'long', or that
5460 vectorlike size fits in 'unsigned long'.
5461
31c286f7
PE
5462 * process.c (make_process): Use printmax_t, not int, to format
5463 process-name gensyms.
5464
55e5faa1
PE
5465 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5466
80f2e268
PE
5467 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5468 to avoid potential buffer overrun.
5469
670741ab
PE
5470 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5471 if X resource line is longer than 512 bytes.
5472
b7163a50
PE
5473 * xfns.c (x_window): Make sprintf buffer a bit bigger
5474 to avoid potential buffer overrun.
5475
ae58ff1f
PE
5476 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5477
c43c8a6a
PE
5478 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5479
3f8236f4
PE
54802011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5481
53e9fe90 5482 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5483 Without these, Emacs silently mishandles large integers sometimes.
5484 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5485 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5486
6511acf2
PE
5487 * xdisp.c (try_window_id): Check Emacs fixnum range before
5488 converting to 'int'.
806add1d 5489
6511acf2 5490 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5491 Check that an Emacs fixnum is in range before assigning it to 'int'.
5492 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5493 values converted from Emacs fixnums.
5494 (Frecenter): Don't wrap around a line count if it is out of 'int'
5495 range; instead, treat it as an extreme value.
5496 (Fset_window_configuration, compare_window_configurations):
5497 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5498
6511acf2
PE
5499 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5500 that can exceed INT_MAX. Check that EMACS_INT value is in range
5501 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5502 (match_limit): Don't assume that a fixnum can fit in 'int'.
5503
6511acf2 5504 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5505 exceed INT_MAX.
5506
6511acf2 5507 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5508 (Fvertical_motion): Don't wrap around LINES values that don't fit
5509 in 'int'. Instead, treat them as extreme values. This is good
5510 enough for windows, which can't have more than INT_MAX lines anyway.
5511
fcb901a7
LMI
55122011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5513
0f2f6b6d
LMI
5514 * Require libxml/parser.h to avoid compilation warning.
5515
fcb901a7
LMI
5516 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5517
5518 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5519 since this reportedly can destroy thread storage.
5520
6e20a0d4
CY
55212011-08-30 Chong Yidong <cyd@stupidchicken.com>
5522
5523 * syntax.c (find_defun_start): Update all cache variables if
5524 exiting early (Bug#9401).
5525
148ae00e
EZ
55262011-08-30 Eli Zaretskii <eliz@gnu.org>
5527
f6cfbd8f
EZ
5528 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5529
148ae00e
EZ
5530 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5531 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5532 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5533
5534 * term.c (tty_append_glyph): New function.
5535 (produce_stretch_glyph): Static function and its prototype deleted.
5536
a66cfb1c
SM
5537 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5538 Add prototypes.
148ae00e 5539
c4a07a4c
PE
55402011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5541
5542 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5543 when checking :margin (Bug#9390).
5544 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5545 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5546 so that the name doesn't mislead. All uses changed.
5547
6bc8cd65
JB
55482011-08-28 Johan Bockgård <bojohan@gnu.org>
5549
5550 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5551 set_tty_hooks.
5552
dca4927e
EZ
55532011-08-27 Eli Zaretskii <eliz@gnu.org>
5554
5555 * xdisp.c (move_it_to): Don't bail out early when reaching
5556 position beyond to_charpos, if we are scanning backwards.
5557 (move_it_vertically_backward): When DY == 0, make sure we get to
5558 the first character in the line after the newline.
5559
f2cad773
PE
55602011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5561
5562 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5563 (ccl_driver): Do not generate an out-of-range pointer.
5564 (Fccl_execute_on_string): Remove unnecessary check for
5565 integer overflow, noted by Stefan Monnier in
5566 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5567 Remove a FIXME that didn't need fixing.
5568 Simplify the newly-introduced buffer reallocation code.
5569
0cae2cdb
JB
55702011-08-27 Juanma Barranquero <lekktu@gmail.com>
5571
5572 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5573
5fc295a4 55742011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5575
70c60eb2 5576 Integer and memory overflow issues (Bug#9196).
726e0ab1 5577
d31850da
PE
5578 * doc.c (get_doc_string): Rework so that
5579 get_doc_string_buffer_size is the actual buffer size, rather than
5580 being 1 less than the actual buffer size; this makes xpalloc more
5581 convenient.
5582
a69fbedb
PE
5583 * image.c (x_allocate_bitmap_record, cache_image):
5584 * xselect.c (Fx_register_dnd_atom):
5585 Simplify previous changes by using xpalloc.
5586
fe5c5d37
PE
5587 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5588 since either will do and ptrdiff_t is convenient with xpalloc.
5589
0065d054
PE
5590 * charset.c (charset_table_size)
5591 (struct charset_sort_data.priority): Now ptrdiff_t.
5592 (charset_compare): Don't overflow if priorities differ greatly.
5593 (Fsort_charsets): Don't assume list length fits in int.
5594 Check for size-calculation overflow when allocating sort data.
5595 (syms_of_charset): Allocate an initial charset table that is
5596 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5597
5598 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5599
5600 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5601 The actual value is always <= INT_MAX, and leaving it unsigned made
5602 overflow checking harder.
5603
5604 * dispextern.h (struct glyph_matrix.rows_allocated)
5605 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5606 with xpalloc. The values are still always <= INT_MAX.
5607
5608 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5609
5610 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5611 (SAFE_NALLOCA): New macro.
5612
5613 * region-cache.c (struct boundary.pos, find_cache_boundary)
5614 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5615 (set_cache_region, invalidate_region_cache)
5616 (revalidate_region_cache, know_region_cache, region_cache_forward)
5617 (region_cache_backward, pp_cache):
5618 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5619 so that ptrdiff_t * can be passed to xpalloc.
5620 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5621 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5622 (pp_cache): Don't assume cache_len fits in int.
5623 * region-cache.h: Adjust extern decls to match.
5624
5625 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5626 EMACS_INT, since either will do, for xpalloc.
5627
5628 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5629 (xnmalloc, xnrealloc, xpalloc): New functions.
5630
726e0ab1
PE
5631 * bidi.c (bidi_shelve_header_size): New constant.
5632 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5633 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5634
51f30bc5 5635 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5636 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5637 (overlay_strings):
5638 Don't update size of array until after memory allocation succeeds,
5639 because xmalloc/xrealloc may not return.
0065d054
PE
5640 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5641 now that we have proper integer overflow checking.
5642 (record_overlay_string, overlay_strings): Catch overflows when
5643 calculating size of overlay_str_buf.
726e0ab1 5644
0065d054
PE
5645 * callproc.c (Fcall_process): Check for size overflow when
5646 calculating size of args2.
5647 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5648 Normally we prefer signed values, but sticking with ptrdiff_t would
5649 require adding more-complicated checks.
726e0ab1
PE
5650
5651 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5652 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5653 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5654 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5655
5656 * character.c (Fstring): Check for size-calculation overflow.
5657
5658 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5659 unnecessary integer overflow. Check for size overflow.
5660 (encode_coding_object): Don't update size until xmalloc succeeds.
5661
5662 * composite.c (get_composition_id): Check for overflow in glyph
5663 length calculations.
5664
5665 Integer and memory overflow fixes for display code.
5666 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5667 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5668 (scrolling_window): Check for overflow in size calculations.
5669 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5670 Don't assume glyph table len fits in int.
5671 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5672 (row_table_size): Now ptrdiff_t, not int.
5673 (scrolling_window): Avoid overflow in size calculations.
5674 Don't update size until allocation succeeds.
5675 * fns.c (concat): Check for overflow in size calculations.
5676 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5677 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5678 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5679
5680 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5681 (get_doc_string): Check for size calculation overflow.
5682 Don't update size until allocation succeeds.
5683 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5684 EMACS_INT, where ptrdiff_t will do.
5685 (Fsubstitute_command_keys): Check for string overflow.
5686
5687 * editfns.c (set_time_zone_rule): Don't assume environment length
5688 fits in int.
5689 (message_length): Now ptrdiff_t, not int.
5690 (Fmessage_box): Don't update size until allocation succeeds.
5691 Don't assume message length fits in int.
5692 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5693
0065d054
PE
5694 * emacs.c (main): Do not reallocate argv, since there is a null at
5695 the end that can be overwritten, and this way there's no need to
5696 worry about size-calculation overflow.
5697 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5698
5699 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5700 alloc succeeds.
5701 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5702
5703 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5704 (x_set_scroll_bar_width, x_figure_window_size):
5705 Check for integer overflow.
5706 (x_set_alpha): Do not assume XINT fits in int.
5707
5708 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5709 This is for the members text_lines, text_cols, total_lines, total_cols,
5710 where the system imposes an 'int' limit.
5711
5712 * fringe.c (Fdefine_fringe_bitmap):
5713 Don't update size until alloc works.
5714
5715 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5716 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5717
5718 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5719 Check for size-calculation overflow.
5720 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5721 do, as we prefer signed integers.
5722 (id_to_widget.max_size, id_to_widget.used)
5723 (xg_store_widget_in_map, xg_remove_widget_from_map)
5724 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5725 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5726 Use and return ptrdiff_t, not int.
5727 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5728 * gtkutil.h: Change prototypes to match the above.
5729
5730 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5731 are duplicate now that they've been promoted to lisp.h.
5732 (x_allocate_bitmap_record, x_alloc_image_color)
5733 (make_image_cache, cache_image, xpm_load):
5734 Don't update size until alloc is done.
5735 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5736 (x_detect_edges):
3256efce 5737 Check for size calculation overflow.
726e0ab1
PE
5738 (ct_colors_allocated_max): New constant.
5739 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5740 overflow.
3256efce 5741
726e0ab1
PE
5742 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5743 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5744 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5745 Use ptrdiff_t, not int, to count maps.
5746 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5747 calculations. Don't update size until allocation succeeds.
5748 Redo calculations to avoid overflow.
726e0ab1
PE
5749 * keyboard.h: Change prototypes to match the above.
5750
5751 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5752 to count maps.
5753 (current_minor_maps): Check for size calculation overflow.
5754 * keymap.h: Change prototypes to match the above.
5755
5756 * lread.c (read1, init_obarray): Don't update size until alloc done.
5757
5758 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5759 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5760
726e0ab1
PE
5761 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5762 Now ptrdiff_t, not int.
5763 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5764 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5765
5766 * process.c (Fnetwork_interface_list): Check for overflow
5767 in size calculation.
5768
5769 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5770
5771 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5772 overflow. Don't bother calling xmalloc when xrealloc will do.
5773
5774 * search.c (Freplace_match): Check for size calculation overflow.
5775 (Fset_match_data): Don't assume list lengths fit in 'int'.
5776
5777 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5778 for command line length. Do not attempt to address one before the
5779 beginning of an array, as that's not portable.
5780
5781 * term.c (max_frame_lines): Remove; unused.
5782 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5783 not int.
5784 (encode_terminal_code, calculate_costs): Check for size
5785 calculation overflow.
5786 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5787 table lengths and related sizes. Don't update size until alloc
5788 done. Redo calculations to avoid overflow.
5789 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5790
5791 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5792 subtracting pointers.
5793 (gobble_line): Check for overflow more carefully. Don't update size
5794 until alloc done.
5795
5796 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5797 Don't update size until alloc done.
5798 Redo size calculations to avoid overflow.
5799 Check for size calculation overflow.
0065d054 5800 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5801
5802 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5803 Use ptrdiff_t, not int, for sizes.
5804 (store_mode_line_noprop_char): Don't update size until alloc done.
5805
0065d054
PE
5806 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5807 Use ptrdiff_t, not int, for sizes.
5808 (Finternal_make_lisp_face, cache_face):
5809 Check for size calculation overflow.
5810 (cache_face): Treat size calculation overflows as if they were
5811 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5812
5813 * xfns.c (x_encode_text, x_set_name_internal)
5814 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5815 sizes, since they can exceed INT_MAX in size. Check for size
5816 calculation overflow.
5817
0065d054
PE
5818 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5819 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5820 Don't update size until alloc done.
5821
0065d054 5822 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5823 as sprintf is limited to int lengths.
1d526e2f 5824
252c5ee1
PE
5825 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5826 (X_LONG_MIN): New macros.
864d7ce7
PE
5827 Use them to make the following changes clearer.
5828 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5829 This change doesn't affect the value now, but it may help remind
5830 future maintainers not to raise the value too much later.
5831 (SELECTION_QUANTUM): Remove, replacing with ...
5832 (selection_quantum): ... new function, which avoids overflow.
5833 All uses changed.
5834 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5835 assumption that selection length fits in 'int'.
5836 (x_reply_selection_request, x_handle_selection_request)
5837 (x_get_window_property, receive_incremental_selection)
5838 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5839 (lisp_data_to_selection_data, clean_local_selection_data):
5840 Use ptrdiff_t, not int, to record length of selection.
5841 (x_reply_selection_request, x_get_window_property)
5842 (receive_incremental_selection, x_property_data_to_lisp):
5843 Redo calculations to avoid overflow.
5844 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5845 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5846 something.
5847 (x_get_window_property, receive_incremental_selection)
5848 (lisp_data_to_selection_data, x_property_data_to_lisp):
5849 Check for size-calculation overflow.
5850 (x_get_window_property, receive_incremental_selection)
5851 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5852 Don't store size until memory allocation succeeds.
5853 (x_get_window_property): Plug memory leak on memory exhaustion.
5854 Don't double-block input; malloc is safe here. Don't assume 2**34
5855 - 4 fits in unsigned long. Add an xassert to check
5856 XGetWindowProperty overflow. Be more careful about overflow
5857 calculations, and distinguish size from memory overflow better.
5858 (receive_incremental_selection): When tracing, don't assume
5859 unsigned int is less than INT_MAX.
5860 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5861 harmful) conversions of unsigned short to int.
5862 (lisp_data_to_selection_data): Don't assume that integers
5863 in the range -65535 through -1 fit in an X unsigned short.
5864 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5865 result parameters unless successful. Rely on cons_to_unsigned
5866 to report problems with elements; the old code wasn't right anyway.
5867 (x_check_property_data): Check for int overflow; we cannot use
5868 a wider type due to X limits.
5869 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5870
726e0ab1 5871 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5872
0065d054
PE
5873 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5874 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5875 (x_color_cells): Don't store size until memory allocation succeeds.
5876 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5877 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5878 (x_term_init): Don't assume length fits in int (sprintf is limited
5879 to int size).
bc18e09d 5880
ebfa62c0
PE
5881 Use ptrdiff_t for composition IDs.
5882 * character.c (lisp_string_width):
5883 * composite.c (composition_table_size, n_compositions)
5884 (get_composition_id, composition_gstring_from_id):
5885 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5886 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5887 * window.c (Frecenter):
5888 Use ptrdiff_t, not int, for composition IDs.
5889 * composite.c (get_composition_id): Check for integer overflow.
5890 * composite.h: Adjust prototypes to match the above changes.
5891
d3411f89
PE
5892 Use ptrdiff_t for hash table indexes.
5893 * category.c (hash_get_category_set):
5894 * ccl.c (ccl_driver):
5895 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5896 * coding.c (coding_system_charset_list, detect_coding_system):
5897 * coding.h (struct coding_system.id):
5898 * composite.c (get_composition_id, gstring_lookup_cache):
5899 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5900 * image.c (xpm_get_color_table_h):
5901 * lisp.h (hash_lookup, hash_put):
5902 * minibuf.c (Ftest_completion):
5903 Use ptrdiff_t for hash table indexes, not int (which is too
5904 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5905 32-bit --with-wide-int hosts).
5906
e097a6fa
PE
5907 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5908 Add a FIXME comment about memory leaks.
5909 (syms_of_charset): Don't assume xmalloc returns.
5910
5637687f
PE
5911 Don't assume that stated character widths fit in int.
5912 * character.c (Fchar_width, c_string_width, lisp_string_width):
5913 * character.h (CHAR_WIDTH):
5914 * indent.c (MULTIBYTE_BYTES_WIDTH):
5915 Use sanitize_char_width to avoid undefined and/or bad behavior
5916 with outlandish widths.
a66cfb1c 5917 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5918 now that we have two such functions. All uses changed.
5919 (sanitize_char_width): New inline function.
5920
a2271ba2
PE
5921 Don't assume that tab-width fits in int.
5922 * character.h (sanitize_width): New inline function.
5923 (SANE_TAB_WIDTH): New macro.
5924 (ASCII_CHAR_WIDTH): Use it.
5925 * indent.c (sane_tab_width): Remove. All uses replaced by
5926 SANE_TAB_WIDTH (current_buffer).
5927 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5928
18c52557
PE
5929 * fileio.c: Integer overflow issues with file modes.
5930 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5931
caeeedc1
PE
5932 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5933 Remove unreachable code.
5934 (read_hex, load_charset_map_from_file): Check for integer overflow.
5935
6df6ae42 5936 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5937 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5938 (x_send_scroll_bar_event): Likewise. Check that the size does not
5939 exceed limits imposed by XClientMessageEvent, as well as the usual
5940 ptrdiff_t and size_t limits.
5941
b13995db
PE
5942 * keyboard.c: Overflow, signedness and related fixes.
5943 (make_lispy_movement): Use same integer type in forward decl
5944 that is used in the definition.
5945 (read_key_sequence, keyremap_step):
5946 Change bufsize argument back to int, undoing my 2011-03-30 change.
5947 We prefer signed types, and int is wide enough here.
5948 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5949 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5950 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5951 length, not size_t. Use ptrdiff_t for index, not int.
5952 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5953 possibility of integer overflow.
5954
13464394
PE
5955 Overflow, signedness and related fixes for images.
5956
5957 * dispextern.h (struct it.stack[0].u.image.image_id)
5958 (struct_it.image_id, struct image.id, struct image_cache.size)
5959 (struct image_cache.used, struct image_cache.ref_count):
5960 * gtkutil.c (update_frame_tool_bar):
5961 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5962 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5963 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5964 * nsmenu.m (update_frame_tool_bar):
5965 * xdisp.c (calc_pixel_width_or_height):
5966 * xfns.c (image_cache_refcount):
5967 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5968 on typical 64-bit hosts.
5969
5970 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5971 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5972 Omit unnecessary casts to int.
5973 (parse_image_spec): Check that integers fall into 'int' range
5974 when the callers expect that.
5975 (image_ascent): Redo ascent calculation to avoid int overflow.
5976 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5977 (lookup_image): Remove unnecessary tests.
5978 (xbm_image_p): Locals are now of int, not EMACS_INT,
5979 since parse_image_check makes sure they fit into int.
5980 (png_load, gif_load, svg_load_image):
5981 Prefer int to unsigned where either will do.
5982 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5983 old tiff_error_handler and tiff_warning_handler.
5984 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5985 stack buffer overflows. It uses only the features of vsnprintf
5986 that are common to both POSIX and native Microsoft.
5987 (tiff_error_handler, tiff_warning_handler): Use it.
5988 (tiff_load, gif_load, imagemagick_load_image):
5989 Don't assume :index value fits in 'int'.
5990 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5991 (imagemagick_load_image): Check that crop parameters fit into
5992 the integer types that MagickCropImage accepts. Don't assume
5993 Vimagemagick_render_type has a nonnegative value. Don't assume
5994 size_t fits in 'long'.
5995 (gs_load): Use printmax_t to print the widest integers possible.
5996 Check for integer overflow when computing image height and width.
5997
c11821d4
EZ
59982011-08-26 Eli Zaretskii <eliz@gnu.org>
5999
6000 * xdisp.c (redisplay_window): Don't force window start if point
6001 will be invisible in the resulting window. (Bug#9324)
6002
0c95fcf7
EZ
60032011-08-25 Eli Zaretskii <eliz@gnu.org>
6004
6005 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6006 the display spec is of the form `(space ...)'.
6007 (handle_display_spec): Return the value returned by
6008 handle_single_display_spec, not just 1 or zero.
6009 (handle_single_display_spec): If the display spec is of the form
6010 `(space ...)', and specifies display in the text area, return 2
6011 rather than 1.
fee65a97 6012 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6013 accurately, and prefer exact match for point under bidi.
6014 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6015
6016 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6017 into disp_prop; all users changed.
6018
6019 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6020 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6021 for the text covered by the display property.
6022
e4ed06f1
CY
60232011-08-25 Chong Yidong <cyd@stupidchicken.com>
6024
6025 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6026 Change return value to nil.
6027 (Frecord_buffer): Delete unused function.
6028
f67cdd7f
EZ
60292011-08-24 Eli Zaretskii <eliz@gnu.org>
6030
5980d4c6
EZ
6031 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6032 buffers, return left-to-right.
8610fe8b
EZ
6033 (set_cursor_from_row): Consider candidate row a win if its glyph
6034 represents a newline and point is on that newline. Fixes cursor
6035 positioning on the newline at EOL of R2L text within L2R
6036 paragraph, and vice versa.
6037 (try_cursor_movement): Check continued rows, in addition to
6038 continuation rows. Fixes unwarranted scroll when point enters a
6039 continued line of R2L text within an L2R paragraph, or vice versa.
6040 (cursor_row_p): Consider the case of point being equal to
6041 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6042 from the end of a short line to the beginning of a continued line
6043 of R2L text within L2R paragraph.
6044 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6045 composed characters.
5980d4c6 6046
f67cdd7f
EZ
6047 * bidi.c (bidi_check_type): Use xassert.
6048 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6049 members.
6050
bca633fb
EZ
60512011-08-23 Eli Zaretskii <eliz@gnu.org>
6052
6053 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6054 a character.
6055
4a5885a7
CY
60562011-08-23 Chong Yidong <cyd@stupidchicken.com>
6057
6058 * nsfont.m (ns_otf_to_script): Fix typo.
6059
0902a04e
KH
60602011-08-22 Kenichi Handa <handa@m17n.org>
6061
6062 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6063 extra slot even if the purpose is char-code-property-table.
6064
1a2e6670
EZ
60652011-08-23 Eli Zaretskii <eliz@gnu.org>
6066
8ddde651
EZ
6067 * xdisp.c (redisplay_window): When computing centering_position,
6068 account for the height of the header line. (Bug#8874)
6069
425cc014
EZ
6070 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6071 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6072 candidate is selected by the mouse, and that candidate has a
6073 composed character under the mouse.
6074
1a2e6670
EZ
6075 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6076 coordinates reported by pos-visible-in-window-p for a composed
6077 character in column zero.
6078
8b76d6f8
SM
60792011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6080
6081 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6082
dac347dd
EZ
60832011-08-22 Eli Zaretskii <eliz@gnu.org>
6084
6085 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6086 consider it a hit if to_charpos is anywhere in the range of the
6087 composed buffer positions.
6088
e013fb34
CY
60892011-08-22 Chong Yidong <cyd@stupidchicken.com>
6090
6091 * image.c (gif_load): Don't assume that each subimage has the same
6092 dimensions as the base image. Handle disposal method that is
6093 "undefined" by the gif spec (Bug#9335).
6094
bd1ba3e8
CY
60952011-08-20 Chong Yidong <cyd@stupidchicken.com>
6096
6097 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6098 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6099
54a1215b
EZ
61002011-08-19 Eli Zaretskii <eliz@gnu.org>
6101
823564e5
EZ
6102 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6103 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6104 from an Org mode buffer to a Speedbar frame.
6105
54a1215b
EZ
6106 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6107 a composition, take its buffer position from IT->cmp_it.charpos.
6108 Fixes cursor positioning at the beginning of a line that begins
6109 with a composed character.
6110
9778ebcc
EZ
61112011-08-18 Eli Zaretskii <eliz@gnu.org>
6112
0be6ee06
EZ
6113 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6114 character bidirectional type, use STRONG_L instead. Fixes crashes
6115 in a buffer produced by `describe-categories'.
6116
9778ebcc
EZ
6117 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6118 members before the level stack, so they would be saved and
6119 restored when copying iterator state. Fixes incorrect reordering
6120 around TABs covered by display properties.
6121
156bffbe
AS
61222011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6123
6b02f655 6124 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6125
72ad093b
CY
61262011-08-17 Chong Yidong <cyd@stupidchicken.com>
6127
6128 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6129 (internal_condition_case_2, internal_condition_case_n):
6130 Remove unnecessary aborts (Bug#9081).
72ad093b 6131
35774242
EZ
61322011-08-17 Eli Zaretskii <eliz@gnu.org>
6133
6134 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6135 has no `load' handler, try opening the file locally. (Bug#9311)
6136
db76dd85
KB
61372011-08-16 Ken Brown <kbrown@cornell.edu>
6138
6139 * gmalloc.c: Expand comment.
6140
b215eee5
EZ
61412011-08-16 Eli Zaretskii <eliz@gnu.org>
6142
6143 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6144 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6145
a4579d33
KB
61462011-08-16 Ken Brown <kbrown@cornell.edu>
6147
6148 Fix memory allocation problems in Cygwin build (Bug#9273).
6149
6150 * unexcw.c ( __malloc_initialized): Declare external variable.
6151 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6152
8b76d6f8
SM
6153 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6154 New variables.
a4579d33
KB
6155 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6156 dumped emacs.
6157 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6158 in the static heap.
6159 [CYGWIN] (special_realloc): New function.
6160 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6161 requests to realloc storage in the static heap.
6162
3ebec551
PE
61632011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6164
6165 * bidi.c (bidi_initialize): Remove unused local.
6166
9fd8be00
EZ
61672011-08-15 Eli Zaretskii <eliz@gnu.org>
6168
6b02f655
SM
6169 * bidimirror.h:
6170 * biditype.h: Remove file.
6171 * makefile.w32-in ($(BLD)/bidi.$(O)):
6172 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6173
6174 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6175
6176 * chartab.c: Improve commentary for the uniprop_table API.
6177
32413314
EZ
6178 * bidi.c (bidi_paragraph_init): Support zero value of
6179 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6180 (bidi_initialize): Use uniprop_table instead of including
6181 biditype.h and bidimirror.h.
32413314 6182
9fd8be00
EZ
6183 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6184 coordinates of the iterator when restoring from ppos_it.
6185 (Bug#9296)
6186
5cf2b69b
KH
61872011-08-14 Kenichi Handa <handa@m17n.org>
6188
6189 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6190 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6191
daf17d00
EZ
61922011-08-14 Eli Zaretskii <eliz@gnu.org>
6193
6194 * xdisp.c (move_it_in_display_line_to): Don't invoke
6195 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6196 ppos_it. Fixes vertical cursor motion when line beginning is
6197 covered by an image. (Bug#9296)
6198
08e3161a
JD
61992011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6200
6201 * nsterm.h (ns_run_ascript): Declare.
6202 (NSAPP_DATA2_RUNASSCRIPT): Define.
6203
6204 * nsfns.m (as_script, as_result, as_status): New static variables.
6205 (ns_run_ascript): New function.
5e617bc2 6206 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6207 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6208 the event loop. Get status from as_status (Bug#7276).
6209
6210 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6211 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6212 the event loop (Bug#7276).
6213
a3720aa2
AS
62142011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6215
6216 * gnutls.c (QCgnutls_bootprop_priority)
6217 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6218 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6219 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6220 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6221 (QCgnutls_bootprop_verify_hostname_error)
6222 (QCgnutls_bootprop_callbacks_verify): Rename from
6223 Qgnutls_bootprop_..., all uses changed.
6224
6225 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6226 uses changed.
6227
0a0d27fb
PE
62282011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6229
19d5c50c
PE
6230 * xfaces.c (Qframe_set_background_mode): Now static.
6231 * dispextern.h (Qframe_set_background_mode): Remove decl.
6232
0a0d27fb
PE
6233 * process.c (Fnetwork_interface_info): Declare local only if needed.
6234
377538cb
JD
62352011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6236
6237 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6238 (Fnetwork_interface_list): Allocate in increments of bytes instead
6239 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6240 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6241 sockaddr.
6242 (struct ifflag_def): notrailers is smart on OSX.
6243 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6244 Get hardware address with getifaddrs if available.
6245
08fff70c
EZ
62462011-08-12 Eli Zaretskii <eliz@gnu.org>
6247
6248 * xdisp.c (iterate_out_of_display_property): xassert that
6249 IT->position is set to within IT->object's boundaries. Break from
6250 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6251 when IT->position is set up wrongly due to some bug.
6252 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6253 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6254 entry. Force push_it to save on the stack the current
6255 buffer/string position, to be restored by pop_it. Fix flags in
6256 the iterator structure wrt the object coming from a display
6257 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6258 properties. (Bug#9284)
6259
7be1c708 62602011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6261
7be1c708
CY
6262 * fontset.c (fontset_get_font_group): Add proper type checks.
6263 (Bug#9172)
aac0c6e3 6264
7be1c708 62652011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6266
7be1c708
CY
6267 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6268 and LC_VERSION_MIN_MACOSX.
6269 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6270 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6271
97bb72a6
EZ
62722011-08-08 Eli Zaretskii <eliz@gnu.org>
6273
6274 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6275 no-display-properties-and-no-overlays under bidi display.
6276 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6277 properties and overlays.
97bb72a6 6278
d5617611
CY
62792011-08-08 Chong Yidong <cyd@stupidchicken.com>
6280
37e11a63
CY
6281 * editfns.c (Fset_time_zone_rule): Document relationship with the
6282 setenv function.
6283
d5617611
CY
6284 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6285 the font entity extracted from the cache (Bug#8109).
6286
58872834
CY
62872011-08-07 Chong Yidong <cyd@stupidchicken.com>
6288
6289 * composite.c (autocmp_chars): Don't reset point. That is done by
6290 restore_point_unwind (Bug#5984).
6291
75bfc667
JL
62922011-08-07 Juri Linkov <juri@jurta.org>
6293
6294 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6295 to show the arg `TIME' instead of `TIMEVAL'.
6296
d1410150
EZ
62972011-08-06 Eli Zaretskii <eliz@gnu.org>
6298
6299 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6300 display property strides EOL and includes a newline, as in
6301 longlines-mode. (Bug#9254)
75b771e4
EZ
6302 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6303 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6304
6305 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6306 is non-zero, even if the data buffer is NULL. Fixes a crash in
6307 vertical-motion with longlines-mode. (Bug#9254)
6308
35928349
EZ
63092011-08-05 Eli Zaretskii <eliz@gnu.org>
6310
ec7cc85b
EZ
6311 * bidi.c <bidi_cache_total_alloc>: Now static.
6312 (bidi_initialize): Initialize bidi_cache_total_alloc.
6313
8b76d6f8 6314 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6315 cache. (Bug#9221)
6316
6317 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6318 amount allocated this far in `bidi_cache_total_alloc'.
6319 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6320 non-zero, only free the data buffer without restoring the cache
6321 contents. All callers changed.
6322
6323 * dispextern.h (bidi_unshelve_cache): Update prototype.
6324
6325 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6326 (move_it_in_display_line, move_it_to)
6327 (move_it_vertically_backward, move_it_by_lines): Replace the call
6328 to xfree to an equivalent call to bidi_unshelve_cache.
6329 (move_it_in_display_line_to): Fix logic of returning
412b6358 6330 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6331
e2e2423b
EZ
63322011-08-05 Eli Zaretskii <eliz@gnu.org>
6333
6334 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6335 came from a string character with a `cursor' property. (Bug#9229)
6336
ae9e757a
JD
63372011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6338
6339 * Makefile.in (LIB_PTHREAD): New variable.
6340 (LIBES): Add LIB_PTHREAD (Bug#9216).
6341
6342 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6343 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6344
213bd7f2
AS
63452011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6346
6b02f655 6347 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6348
99aaf75f
JD
63492011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6350
6351 * xterm.c (x_find_topmost_parent): New function.
6352 (x_set_frame_alpha): Find topmost parent window with
6353 x_find_topmost_parent and set the property there also (bug#9181).
6354 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6355
c74e9d86
PE
63562011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6357
6358 * callproc.c (Fcall_process): Avoid vfork clobbering
6359 the local vars buffer, coding_systems, current_dir.
6360
640c8776
SM
63612011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6362
6363 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6364
f26d0e4c
PE
63652011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6366
8a10d76c
PE
6367 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6368 so that it is not optimized away.
6369
f26d0e4c
PE
6370 * xdisp.c (compute_display_string_pos): Remove unused local.
6371
55439c61
EZ
63722011-08-02 Eli Zaretskii <eliz@gnu.org>
6373
6374 Fix slow cursor motion and scrolling in large buffers with
6375 selective display, like Org Mode buffers. (Bug#9218)
6376
6377 * dispextern.h (struct bidi_it): New member disp_prop_p.
6378
6379 * xdisp.c: Remove one-slot cache of display string positions.
6380 (compute_display_string_pos): Accept an additional argument
5e617bc2 6381 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6382 for a display string or property. If found, set DISP_PROP_P
6383 non-zero.
6384
6385 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6386 DISP_PROP_P, and pass it to compute_display_string_pos.
6387 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6388 non-zero. All callers of bidi_fetch_char changed.
6389
fb33fa43
SM
63902011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6391
6392 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6393
b099e063
DM
63942010-12-03 Don March <don@ohspite.net>
6395
6396 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6397 last character M-[char] is translated to ESC [char] (bug#7541).
6398
5cc7f7af
KH
63992011-08-02 Kenichi Handa <handa@m17n.org>
6400
d0fffa3f 6401 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6402
6403 * chartab.c (uniprop_table): Make it non-static.
6404
525d5e6e
EZ
64052011-08-01 Eli Zaretskii <eliz@gnu.org>
6406
6407 * xdisp.c (forward_to_next_line_start): Accept additional argument
6408 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6409 on the newline.
6410 (reseat_at_next_visible_line_start): Use the bidi iterator state
6411 returned by forward_to_next_line_start to restore the state of
6412 it->bidi_it after backing up to previous newline. (Bug#9212)
6413
31011111
AS
64142011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6415
6416 * regex.c (re_comp): Protoize.
6417 (re_exec): Fix return type.
6418 (regexec): Fix type of `ret'. (Bug#9203)
6419
476371c4
PE
64202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6421
e5d76069
PE
6422 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6423 This is needed if max-image-size is a floating-point number.
6424
9a79b20c
AS
64252011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6426
6427 * print.c (print_object): Print empty symbol as ##.
6428
6429 * lread.c (read1): Read ## as empty symbol.
6430
d8c2fa78
AA
64312011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6432
6433 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6434 setting frame foreground color (Bug#9175).
6435 (x_set_background_color): Likewise.
6436
ffe57a7a
AA
6437 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6438 contents (Bug#9176).
6439 (EmacsTooltip -init): Remove bezels and add shadows to
6440 tooltip windows.
6441
bf3492a5
AA
6442 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6443 or scroll bar (Bug#8470).
6444
d55e9c53
AA
6445 * nsfont.m (nsfont_open): Remove assignment to voffset and
6446 unnecessary vars hshink, expand, hd, full_height, min_height.
6447 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6448
6449 * nsterm.h (nsfont_info): Remove voffset field.
6450
d8c2fa78 64512011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6452
6453 Implement strike-through and overline on NextStep (Bug#8863).
6454
6455 * nsfont.m (nsfont_open): Use underline position provided by font,
6456 instead of hard-coded value of 2.
6457 (nsfont_draw): Call ns_draw_text_decoration instead.
6458
6459 * nsterm.h: Add declaration for ns_draw_text_decoration.
6460
6461 * nsterm.m (ns_draw_text_decoration): New function for drawing
6462 underline, overline, and strike-through.
6463 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6464 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6465 accommodate underlining, etc.
4843aac3 6466
4cc60b9b
EZ
64672011-07-28 Eli Zaretskii <eliz@gnu.org>
6468
bc7ece87
EZ
6469 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6470 default.
4cc60b9b 6471
476371c4
PE
64722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6473
66606eea
PE
6474 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6475 Without this fix, if a signal arrives just after memory fills up,
6476 'malloc' might be invoked reentrantly.
6477
476371c4
PE
6478 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6479 In other words, assume that every image size is allowed, on non-X
6480 hosts. This assumption is probably wrong, but it lets Emacs compile.
6481
f3fcc40d
AS
64822011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6483
6484 * regex.c (re_iswctype): Convert return values to boolean.
6485
350c992f
EZ
64862011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6487
6488 * xdisp.c (compute_display_string_pos): Don't use cached display
6489 string position if the buffer had its restriction changed.
6490 (Bug#9184)
6491
5266b4bb
PE
64922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6493
6494 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6495
2573a837 64962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6497
41f55ccd 6498 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6499
39e378da
PE
6500 * bidi.c: Integer size and overflow fixes.
6501 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6502 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6503 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6504 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6505 (bidi_find_other_level_edge):
6506 Use ptrdiff_t instead of EMACS_INT where either will do.
6507 This works better on 32-bit hosts configured --with-wide-int.
6508 (bidi_cache_ensure_space): Check for size-calculation overflow.
6509 Use % rather than repeated addition, for better worst-case speed.
6510 Don't set bidi_cache_size until after xrealloc returns, because it
6511 might not return.
6512 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6513 (bidi_cache_ensure_space): Also check that the bidi cache size
6514 does not exceed that of the largest Lisp string or buffer. See Eli
6515 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6516
5e927815
PE
6517 * alloc.c (__malloc_size_t): Remove.
6518 All uses replaced by size_t. See Andreas Schwab's note
6519 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6520
ca4aa935
PE
6521 * image.c: Improve checking for integer overflow.
6522 (check_image_size): Assume that f is nonnull, since
6523 it is always nonnull in practice. This is one less thing to
6524 worry about when checking for integer overflow later.
6525 (x_check_image_size): New function, which checks for integer
6526 overflow issues inside X.
6527 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6528 This removes the need for a memory_full check.
6529 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6530 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6531 (xbm_read_bitmap_data): Change locals back to 'int', since
6532 their values must fit in 'int'.
6533 (xpm_load_image, png_load, tiff_load):
6534 Invoke x_create_x_image_and_pixmap earlier,
6535 to avoid much needless work if the image is too large.
6536 (tiff_load): Treat overly large images as if
6537 x_create_x_image_and_pixmap failed, not as malloc failures.
6538 (gs_load): Use x_check_image_size.
6539
5f8f9cc2
PE
6540 * gtkutil.c: Omit integer casts.
6541 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6542 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6543
5adf60bc
PE
6544 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6545
c8907a93
PE
6546 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6547 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6548 would wrongly return t on a 64-bit host.
6549
e3c25c68
PE
6550 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6551 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6552 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6553 and therefore cause GCC to emit a bogus diagnostic in some cases.
6554
3f791afe
PE
6555 * image.c: Integer signedness and overflow and related fixes.
6556 This is not an exhaustive set of fixes, but it's time to
6557 record what I've got.
6558 (lookup_pixel_color, check_image_size): Remove redundant decls.
6559 (check_image_size): Don't assume that arbitrary EMACS_INT values
6560 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6561 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6562 (tiff_load, imagemagick_load_image):
6563 Check for overflow in size calculations.
6564 (x_create_x_image_and_pixmap): Remove unnecessary test for
6565 xmalloc returning NULL; that can't happen.
6566 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6567 (xpm_color_bucket): Use better integer hashing function.
6568 (xpm_cache_color): Don't possibly over-allocate memory.
6569 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6570 (gif_memory_source):
6571 Use ptrdiff_t, not int or size_t, to record sizes.
6572 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6573 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6574 either works, as we prefer signed integers.
6575 (tiff_read_from_memory, tiff_write_from_memory):
6576 Return tsize_t, not size_t, since that's what the TIFF API wants.
6577 (tiff_read_from_memory): Don't fail simply because the read would
6578 go past EOF; instead, return a short read.
6579 (tiff_load): Omit no-longer-needed casts.
6580 (Fimagemagick_types): Don't assume size fits into 'int'.
6581
3cc5a532
PE
6582 Improve hashing quality when configured --with-wide-int.
6583 * fns.c (hash_string): New function, taken from sxhash_string.
6584 Do not discard information about ASCII character case; this
6585 discarding is no longer needed.
6586 (sxhash-string): Use it. Change sig to match it. Caller changed.
6587 * lisp.h: Declare it.
6588 * lread.c (hash_string): Remove, since we now use fns.c's version.
6589 The fns.c version returns a wider integer if --with-wide-int is
6590 specified, so this should help the quality of the hashing a bit.
6591
b312a492
PE
6592 * emacs.c: Integer overflow minor fix.
6593 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6594 Define only if GNU_LINUX.
6595 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6596
dfd153ae
PE
6597 * dispnew.c: Integer signedness and overflow fixes.
6598 Remove unnecessary forward decls, that were a maintenance hassle.
6599 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6600 All uses changed.
6601 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6602 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6603 (prepare_desired_row, line_draw_cost):
6604 Use int, not unsigned, where either works.
6605 (save_current_matrix, restore_current_matrix):
6606 Use ptrdiff_t, not size_t, where either works.
6607 (init_display): Check for overflow more accurately, and without
6608 relying on undefined behavior.
6609
a81d11a3
PE
6610 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6611 Remove, replacing with the new symbols in lisp.h. All uses changed.
6612 * fileio.c (make_temp_name):
6613 * filelock.c (lock_file_1, lock_file):
6614 * xdisp.c (message_dolog):
6615 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6616 Use pMd etc. instead.
6617 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6618 replacing the pWIDE etc. symbols removed from editfns.c.
6619
3300e6fd
PE
6620 * keyboard.h (num_input_events): Now uintmax_t.
6621 This is (very slightly) less likely to mess up due to wraparound.
6622 All uses changed.
6623
fd05c7e9
PE
6624 * buffer.c: Integer signedness fixes.
6625 (alloc_buffer_text, enlarge_buffer_text):
6626 Use ptrdiff_t rather than size_t when either will do, as we prefer
6627 signed integers.
6628
903fe15d
PE
6629 * alloc.c: Integer signedness and overflow fixes.
6630 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6631 (__malloc_size_t): Default to size_t, not to int.
6632 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6633 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6634 Prefer ptrdiff_t to size_t when either would do, as we prefer
6635 signed integers.
6636 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6637 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6638 Now const. Initialize with values that are in range even if char
6639 is signed.
6640 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6641 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6642 These functions do the right thing with sizes > 2**32.
6643 (check_depth): Now ptrdiff_t, not int.
6644 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6645 Adjust to new way of storing sizes. Check for size overflow bugs
6646 in rest of code.
6647 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6648 slightly wrong anyway, as it missed one instance of
6649 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6650 (refill_memory_reserve): Omit needless cast to size_t.
6651 (mark_object_loop_halt): Mark as externally visible.
6652
ac82cc6a
PE
6653 * xselect.c: Integer signedness and overflow fixes.
6654 (Fx_register_dnd_atom, x_handle_dnd_message):
6655 Use ptrdiff_t, not size_t, since we prefer signed.
6656 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6657 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6658 x_dnd_atoms_size and x_dnd_atoms_length.
6659
c2d1e36d
PE
6660 * doprnt.c: Prefer signed to unsigned when either works.
6661 * eval.c (verror):
6662 * doprnt.c (doprnt):
6663 * lisp.h (doprnt):
6664 * xdisp.c (vmessage):
6665 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6666 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6667 prefer signed arithmetic to avoid comparison confusion.
6668 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6669 but is a bit tricky.
6670
0e926e56
PE
6671 Assume freestanding C89 headers, string.h, stdlib.h.
6672 * data.c, doprnt.c, floatfns.c, print.c:
6673 Include float.h unconditionally.
6674 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6675 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6676 * regex.c: Likewise for stddef.h, string.h.
6677 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6678 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6679 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6680 (STDC_HEADERS): Remove obsolete defines.
6681 * sysdep.c: Include limits.h unconditionally.
6682
9cfdb3ec
PE
6683 Assume support for memcmp, memcpy, memmove, memset.
6684 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6685 * regex.c (memcmp, memcpy):
6686 Remove; we assume C89 now.
6687
6688 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6689 (__malloc_safe_bcopy): Remove; no longer needed.
6690
cf950e6b 6691 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6692 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6693 well either way, and we prefer signed to unsigned.
6694
dbf38e02
LMI
66952011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6696
6697 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6698 closes the connection while we're reading (bug#9182).
6699
d6f0886c 67002011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6701
d6f0886c
JD
6702 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6703 are specified (Bug#9168).
24e0f6b1 6704
2eb1f9e6
PE
67052011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6706
6707 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6708 Found by GCC static checking and --with-wide-int on a 32-bit host.
6709
22381272 67102011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6711
6712 * xdisp.c (compute_display_string_pos): Fix logic of caching
6713 previous display string position. Initialize cached_prev_pos to
6714 -1. Fixes slow-down at the beginning of a buffer.
6715
f25e39b4
EZ
67162011-07-24 Eli Zaretskii <eliz@gnu.org>
6717
6718 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6719 for attrs[LFACE_FONTSET_INDEX].
6720
04c4b52e
PE
67212011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6722
6723 * xml.c (parse_region): Remove unused local
6724 that was recently introduced.
6725
c1734fbd
EZ
67262011-07-23 Eli Zaretskii <eliz@gnu.org>
6727
be18c5a5
EZ
6728 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6729 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6730
c1734fbd
EZ
6731 * xdisp.c (move_it_in_display_line_to): Record the best matching
6732 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6733 exit if none of the characters scanned was an exact match.
6734 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6735 when exact match is impossible due to invisible text, and the
6736 lines are truncated.
6737
a258d627
JD
67382011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6739
6740 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6741 for OSX >= 10.7.
6742
b6d5a689
EZ
67432011-07-22 Eli Zaretskii <eliz@gnu.org>
6744
0f74f785
EZ
6745 Fix a significant slow-down of cursor motion with C-n, C-p,
6746 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6747 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6748 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6749 (next_element_from_buffer): Call compute_stop_pos_backwards to
6750 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6751 base_level_stop.
6752 (reseat): Don't look for prev_stop, as that could mean a very long
6753 run.
6754 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6755 <cached_disp_overlay_modiff>: Cache for last found display string
6756 position.
551918c1 6757 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6758 about the same buffer in the same area of character positions, and
6759 the buffer wasn't changed since the time the display string
6760 position was cached.
551918c1 6761
b2d0c91a
EZ
67622011-07-22 Eli Zaretskii <eliz@gnu.org>
6763
6764 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6765 is an integer, which is important for empty lines. (Bug#9149)
6766
043604ee
CY
67672011-07-22 Chong Yidong <cyd@stupidchicken.com>
6768
6769 * frame.c (Fmodify_frame_parameters): In tty case, update the
6770 default face if necessary (Bug#4238).
6771
da4adb04
CY
67722011-07-21 Chong Yidong <cyd@stupidchicken.com>
6773
6774 * editfns.c (Fstring_to_char): No need to explain what a character
6775 is in the docstring (Bug#6576).
6776
9abd0532
LMI
67772011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6778
6779 * xml.c (parse_region): Make sure we always return a tree.
6780
36881d16
HK
67812011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6782
6783 * xml.c (parse_region): If a document contains only comments,
6784 return that, too.
6785
1e98674d
LMI
67862011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6787
6788 * xml.c (make_dom): Return comments, too.
6789
590bd467
PE
67902011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6791
6792 Port to OpenBSD.
6793 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6794 and the surrounding thread.
6795 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6796 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6797 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6798 timer goes off.
6799 * s/openbsd.h (BROKEN_SIGIO): Define.
6800 * unexelf.c (unexec) [__OpenBSD__]:
6801 Don't update the .mdebug section of the Alpha COFF symbol table.
6802
f41628b2
LMI
68032011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6804
6805 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6806 (bug#8460).
6807
b59b67c5
PE
68082011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6809
15e3a074
PE
6810 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6811 This fixes some race conditions on the permissions of any newly
6812 created file.
6813
41bed37d
PE
6814 * alloc.c (valid_pointer_p): Use pipe, not open.
6815 This fixes some permissions issues when debugging.
6816
b59b67c5
PE
6817 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6818 If fchown fails to set both uid and gid, try to set just gid,
6819 as that is sometimes allowed. Adjust the file's mode to eliminate
6820 setuid or setgid bits that are inappropriate if fchown fails.
6821
925a6be7
SM
68222011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6823
6824 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6825 to compare Lisp_Objects.
6826 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6827 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6828 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6829
52968808
AS
68302011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6831
0a6a104b
AS
6832 * lread.c (read_integer): Unread even EOF character.
6833 (read1): Likewise. Properly record start position of symbol.
6834
52968808
AS
6835 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6836 symbol character follows.
6837
9e381cdd
PE
68382011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6839
6840 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6841 This works around a problem with the previous change to Fcopy_file.
6842 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6843 and without this change, GCC might complain about discarding
6844 fchown's return value.
6845
b5641435
JB
68462011-07-16 Juanma Barranquero <lekktu@gmail.com>
6847
6848 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6849
a8031457
PE
68502011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6851
6852 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6853
dd889327
LMI
68542011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6855
750c33f7
LMI
6856 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6857 it's used from the C level.
6858
dd889327
LMI
6859 * process.c: Use the same condition for POLL_FOR_INPUT in both
6860 keyboard.c and process.c (bug#1858).
6861
87e86684
LM
68622011-07-09 Lawrence Mitchell <wence@gmx.li>
6863
6864 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6865 (Fgnutls_boot): Use it.
6866
64348f40
AS
68672011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6868
6869 * doc.c (Fsubstitute_command_keys): Revert last change.
6870
1d698799
LMI
68712011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6872
f863868c
LMI
6873 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6874 quotes the next character, and doesn't affect other longer
6875 sequences (bug#8935).
6876
1d698799
LMI
6877 * lread.c (syms_of_lread): Clarify that is isn't only
6878 `eval-buffer' and `eval-defun' that's affected by
6879 `lexical-binding' (bug#8460).
6880
aa4b6df6
EZ
68812011-07-15 Eli Zaretskii <eliz@gnu.org>
6882
6883 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6884 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6885
5d856da6
PE
68862011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6887
ad6042bb
PE
6888 Fix minor problems found by static checking.
6889 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6890 (elsz): Now a signed constant, not a size_t var. We prefer signed
6891 types to unsigned, to avoid integer comparison confusion. Without
6892 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6893 "cannot optimize loop, the loop counter may overflow", a symptom
6894 of the confusion.
f00bbb22 6895 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6896 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6897
6468f31c
LMI
68982011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6899
49080b10
LMI
6900 * search.c (Fre_search_backward): Mention `case-fold-search' in
6901 all the re_search_* functions (bug#8138).
6902
6468f31c
LMI
6903 * keyboard.c (Fopen_dribble_file): Document when the file is
6904 closed (bug#8056).
6905
c965adc5
EZ
69062011-07-14 Eli Zaretskii <eliz@gnu.org>
6907
df9733bf
EZ
6908 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6909 bidi_cache_idx.
6910
0bb23927
EZ
6911 Support bidi reordering of display and overlay strings.
6912 * xdisp.c (compute_display_string_pos)
6913 (compute_display_string_end): Accept additional argument STRING.
6914 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6915 (reseat_to_string): Initialize bidi_it->string.s and
6916 bidi_it->string.schars.
6917 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6918 NULL (avoids a crash in bidi_paragraph_init).
6919 Initialize itb.string.lstring.
0bb23927
EZ
6920 (init_iterator): Call bidi_init_it only of a valid
6921 buffer position was specified. Initialize paragraph_embedding to
6922 L2R.
6923 (reseat_to_string): Initialize the bidi iterator.
6924 (display_string): If we need to ignore text properties of
6925 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6926 original value of -1 will not work with bidi.)
6927 (compute_display_string_pos): First arg is now struct
6928 `text_pos *'; all callers changed. Support display properties on
6929 Lisp strings.
6930 (compute_display_string_end): Support display properties on Lisp
6931 strings.
6932 (init_iterator, reseat_1, reseat_to_string): Initialize the
6933 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6934 when iterating on a string not from display properties).
640c8776
SM
6935 (compute_display_string_pos, compute_display_string_end):
6936 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6937 arrow keys.
6938 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6939 base_level_stop; instead, set base_level_stop to BEGV.
6940 Fixes crashes in vertical-motion.
0bb23927
EZ
6941 (next_element_from_buffer): Improve commentary for when
6942 the iterator is before prev_stop.
6943 (init_iterator): Initialize bidi_p from the default value of
6944 bidi-display-reordering, not from buffer-local value. Use the
6945 buffer-local value only if initializing for buffer iteration.
6946 (handle_invisible_prop): Support invisible properties on strings
6947 that are being bidi-reordered.
6948 (set_iterator_to_next): Support bidi reordering of C strings and
6949 Lisp strings.
6950 (next_element_from_string): Support bidi reordering of Lisp
6951 strings.
6952 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6953 (display_string): Support display of R2L glyph rows.
6954 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6955 (init_iterator): Don't initialize it->bidi_p for strings
6956 here.
6957 (reseat_to_string): Initialize it->bidi_p for strings here.
6958 (next_element_from_string, next_element_from_c_string)
6959 (next_element_from_buffer): Add xassert's for correspondence
6960 between IT's object being iterated and it->bidi_it.string
6961 structure.
6962 (face_before_or_after_it_pos): Support bidi iteration.
6963 (next_element_from_c_string): Handle the case of the first string
6964 character that is not the first one in the visual order.
6965 (get_visually_first_element): New function, refactored from common
6966 parts of next_element_from_buffer, next_element_from_string, and
6967 next_element_from_c_string.
6968 (tool_bar_lines_needed, redisplay_tool_bar)
6969 (display_menu_bar): Force left-to-right direction. Add a FIXME
6970 comment for making that be controlled by a user option.
6971 (push_it, pop_it): Save and restore the state of the
6972 bidi iterator. Save and restore the bidi_p flag.
6973 (pop_it): Iterate out of display property for string iteration as
6974 well.
6975 (iterate_out_of_display_property): Support iteration over strings.
6976 (handle_single_display_spec): Set up it->bidi_it for iteration
6977 over a display string, and call bidi_init_it.
6978 (handle_single_display_spec, next_overlay_string)
6979 (get_overlay_strings_1, push_display_prop): Set up the bidi
6980 iterator for displaying display or overlay strings.
6981 (forward_to_next_line_start): Don't use the shortcut if
6982 bidi-iterating.
6983 (back_to_previous_visible_line_start): If handle_display_prop
6984 pushed the iterator stack, restore the internal state of the bidi
6985 iterator by calling bidi_pop_it same number of times.
6986 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6987 and we are bidi-iterating, don't decrement the iterator position;
6988 instead, set the first_elt flag in the bidi iterator, to produce
6989 the same effect.
6990 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6991 (push_display_prop): xassert that we are iterating a buffer.
6992 (push_it, pop_it): Save and restore paragraph_embedding member.
6993 (handle_single_display_spec, next_overlay_string)
6994 (get_overlay_strings_1, reseat_1, reseat_to_string)
6995 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6996 correctly. Don't assume unibyte strings are not bidi-reordered.
6997 (compute_display_string_pos)
6998 (compute_display_string_end): Fix handling the case of C string.
6999 (push_it, pop_it): Save and restore from_disp_prop_p.
7000 (handle_single_display_spec, push_display_prop): Set the
7001 from_disp_prop_p flag.
7002 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7003 (pop_it): Call iterate_out_of_display_property only if we are
7004 popping after iteration over a string that came from a display
7005 property. Fix a typo in popping stretch info. Add an assertion
7006 for verifying that the iterator position is in sync with the bidi
7007 iterator.
7008 (handle_single_display_spec, get_overlay_strings_1)
7009 (push_display_prop): Fix initialization of paragraph direction for
7010 string when that of the parent object is not yet determined.
7011 (reseat_1): Call bidi_init_it to resync the bidi
7012 iterator with IT's position. (Bug#7616)
7013 (find_row_edges): If ROW->start.pos gives position
7014 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7015 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7016 Reset the from_disp_prop_p flag.
7017 (SAVE_IT, RESTORE_IT): New macros.
7018 (pos_visible_p, face_before_or_after_it_pos)
7019 (back_to_previous_visible_line_start)
7020 (move_it_in_display_line_to, move_it_in_display_line)
7021 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7022 (try_scrolling, redisplay_window, display_line): Use them when
7023 saving a temporary copy of the iterator and restoring it back.
7024 (back_to_previous_visible_line_start, reseat_1)
7025 (init_iterator): Empty the bidi cache "stack".
7026 (move_it_in_display_line_to): If iterator ended up at
7027 EOL, but we never saw any buffer positions smaller than
7028 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7029 motion in bidi-reordered lines.
7030 (move_it_in_display_line_to): Record prev_method and prev_pos
7031 immediately before the call to set_iterator_to_next. Fixes cursor
7032 motion in bidi-reordered lines with stretch glyphs and strings
7033 displayed in margins. (Bug#8133) (Bug#8867)
7034 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7035 TO_CHARPOS.
640c8776
SM
7036 (pos_visible_p): Support positions in bidi-reordered lines.
7037 Save and restore bidi cache.
0bb23927
EZ
7038
7039 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7040 (bidi_paragraph_info): Delete unused struct.
7041 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7042 (bidi_cache_start): New variable.
7043 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7044 to zero.
7045 (bidi_cache_fetch_state, bidi_cache_search)
7046 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7047 (bidi_cache_find, bidi_peek_at_next_level)
7048 (bidi_level_of_next_char, bidi_find_other_level_edge)
7049 (bidi_move_to_visually_next): Compare cache index with
7050 bidi_cache_start rather than with zero.
7051 (bidi_fetch_char): Accept new argument STRING; all callers
7052 changed. Support iteration over a string. Support strings with
7053 display properties. Support unibyte strings. Fix the type of
7054 `len' according to what STRING_CHAR_AND_LENGTH expects.
7055 (bidi_paragraph_init, bidi_resolve_explicit_1)
7056 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7057 (bidi_level_of_next_char, bidi_move_to_visually_next):
7058 Support iteration over a string.
0bb23927
EZ
7059 (bidi_set_sor_type, bidi_resolve_explicit_1)
7060 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7061 can now be zero (for strings); special values 0 and -1 were
7062 changed to -1 and -2, respectively.
7063 (bidi_char_at_pos): New function.
7064 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7065 Call it instead of FETCH_MULTIBYTE_CHAR.
7066 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7067 initialized to valid values.
7068 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7069 values.
7070 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7071 the test for valid cached positions. Fix the logic for looking up
7072 the sentinel state in the cache. GCPRO the Lisp string we are
7073 iterating.
7074 (bidi_push_it, bidi_pop_it): New functions.
7075 (bidi_initialize): Initialize the bidi cache start stack pointer.
7076 (bidi_cache_ensure_space): New function, refactored from part of
7077 bidi_cache_iterator_state. Don't assume the required size is just
7078 one BIDI_CACHE_CHUNK away.
7079 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7080 (bidi_count_bytes, bidi_char_at_pos): New functions.
7081 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7082 always valid if bidi_cache_idx is valid.
7083 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7084 is valid if it's going to be used.
7085 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7086 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7087 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7088 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7089 (bidi_find_other_level_edge, bidi_cache_start_stack):
7090 All variables related to cache indices are now EMACS_INT.
c965adc5 7091
0bb23927
EZ
7092 * dispextern.h (struct bidi_string_data): New structure.
7093 (struct bidi_it): New member `string'. Make flag members be 1-bit
7094 fields, and put them last in the struct.
640c8776
SM
7095 (compute_display_string_pos, compute_display_string_end):
7096 Update prototypes.
0bb23927
EZ
7097 (bidi_push_it, bidi_pop_it): Add prototypes.
7098 (struct iterator_stack_entry): New members bidi_p,
7099 paragraph_embedding, and from_disp_prop_p.
7100 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7101 (bidi_shelve_cache, bidi_unshelve_cache):
7102 Declare prototypes.
0bb23927
EZ
7103
7104 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7105 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7106 and vector-like objects.
7107
7108 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7109 cache around display iteration.
7110
7111 * window.c (Fwindow_end, window_scroll_pixel_based)
7112 (displayed_window_lines, Frecenter): Save and restore the bidi
7113 cache around display iteration.
7114
3bbd2265
LMI
71152011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7116
7117 * editfns.c (Fdelete_region): Clarify the use of the named
7118 parameters (bug#6788).
7119
adc47434
MR
71202011-07-14 Martin Rudalics <rudalics@gmx.at>
7121
7122 * indent.c (Fvertical_motion): Set and restore w->pointm when
7123 saving and restoring the window's buffer (Bug#9006).
7124
837c31f8
LMI
71252011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7126
7127 * editfns.c (Fstring_to_char): Clarify just what is returned
7128 (bug#6576). Text by Eli Zaretskii.
7129
ac389d0c
JB
71302011-07-13 Juanma Barranquero <lekktu@gmail.com>
7131
7132 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7133
0be0ce47
EZ
71342011-07-13 Eli Zaretskii <eliz@gnu.org>
7135
7136 * buffer.c (mmap_find): Fix a typo.
7137
cd18e7e3
JB
71382011-07-13 Johan Bockgård <bojohan@gnu.org>
7139
7140 Fix execution of x selection hooks.
7141 * xselect.c (Qx_lost_selection_functions)
7142 (Qx_sent_selection_functions): New vars.
7143 (syms_of_xselect): DEFSYM them.
7144 (x_handle_selection_request): Pass Qx_sent_selection_functions
7145 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7146 (x_handle_selection_clear,x_clear_frame_selections):
7147 Pass Qx_lost_selection_functions rather than
7148 Vx_lost_selection_functions to Frun_hook_with_args.
7149
47ea7f44
PE
71502011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7151
ac389d0c 7152 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7153 The old code sometimes used this field without initializing it.
7154
47ea7f44
PE
7155 * alloc.c (gc_sweep): Don't read past end of array.
7156 In theory, the old code could also have corrupted Emacs internals,
7157 though it'd be very unlikely.
7158
bc985c87
AS
71592011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7160
7161 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7162 argument. (Bug#4026)
bc985c87 7163
0cf34688
LMI
71642011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7165
b3dadd76
LMI
7166 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7167 key" (bug#4257).
7168
0cf34688
LMI
7169 * window.c (Fset_window_start): Doc fix (bug#4199).
7170 (Fset_window_hscroll): Ditto.
7171
270768cd
PE
71722011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7173
077e3dda 7174 Fix minor new problems caught by GCC 4.6.1.
270768cd 7175 * term.c (init_tty): Remove unused local.
490011a6 7176 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7177 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7178 not used otherwise.
270768cd 7179
b1f58454
CY
71802011-07-12 Chong Yidong <cyd@stupidchicken.com>
7181
7182 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7183
22b9578d
LMI
71842011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7185
6e70ab07
LMI
7186 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7187 are the mini-buffer and the echo area (bug#3320).
7188
22b9578d
LMI
7189 * term.c (init_tty): Remove support for supdup, c10 and perq
7190 terminals, which are no longer supported (bug#1482).
7191
8974cc9f
JB
71922011-07-10 Johan Bockgård <bojohan@gnu.org>
7193
7194 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7195
a560d974
JD
71962011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7197
7198 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7199 for non-popups (Bug#3642).
7200
1dae0f0a
AS
72012011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7202
268c2c36 7203 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7204 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7205 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7206 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7207 * data.c (fmod): Likewise.
7208 * dispnew.c (swap_glyphs_in_rows): Likewise.
7209 * emacs.c (memory_warning_signal): Likewise.
7210 * floatfns.c (float_error): Likewise.
7211 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7212 (otf_open, font_otf_capability, generate_otf_features)
7213 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7214 Likewise.
7215 * image.c (pbm_read_file): Likewise.
7216 * indent.c (string_display_width): Likewise.
7217 * intervals.c (check_for_interval, search_for_interval)
7218 (inc_interval_count, count_intervals, root_interval)
7219 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7220 * lread.c (defalias): Likewise.
268c2c36 7221 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7222 * regex.c (set_image_of_range_1, set_image_of_range)
7223 (regex_grow_registers): Likewise.
7224 * sysdep.c (strerror): Likewise.
7225 * termcap.c (valid_filename_p, tprint, main): Likewise.
7226 * tparam.c (main): Likewise.
7227 * unexhp9k800.c (run_time_remap, save_data_space)
7228 (update_file_ptrs, read_header, write_header, calculate_checksum)
7229 (copy_file, copy_rest, display_header): Likewise.
7230 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7231 Likewise.
7232 * xdisp.c (check_it): Likewise.
7233 * xfaces.c (register_color, unregister_color, unregister_colors):
7234 Likewise.
7235 * xfns.c (print_fontset_result): Likewise.
7236 * xrdb.c (member, fatal, main): Likewise.
7237
99033785
PE
72382011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7239
7240 Fix minor problems found by static checking (Bug#9031).
7241 * chartab.c (char_table_set_range, map_sub_char_table):
7242 Remove unused locals.
7243 (uniprop_table): Now static.
7244 * composite.c (_work_char): Remove unused static var.
7245
9cb2ac56
JB
72462011-07-09 Juanma Barranquero <lekktu@gmail.com>
7247
7248 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7249
f25661f0
JD
72502011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7251
7252 * gtkutil.c (qttip_cb): Remove code without function.
7253
8278c4fe
EZ
72542011-07-09 Eli Zaretskii <eliz@gnu.org>
7255
7256 * w32.c (pthread_sigmask): New stub.
7257
1692ae2d 72582011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7259
8a6ebd58 7260 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7261 sigprocmask is portable only for single-threaded applications, and
7262 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7263 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7264 (LIBES): Use it.
7265 * callproc.c (Fcall_process):
7266 * process.c (create_process):
7267 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7268 Use pthread_sigmask, not sigprocmask.
123403e4 7269
1b854618
JD
72702011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7271
7272 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7273 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7274 wrong (Bug#8591).
7275
3fe4b549
JD
72762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7277
0ce7e563
JD
7278 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7279 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7280 (xg_hide_tooltip): Fix comment.
7281
3fe4b549
JD
7282 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7283 in registerServicesMenuSendTypes.
7284 (validRequestorForSendType): Don't check ns_return_types.
7285
7286 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7287 ns_return_type.
7288
5df75e47
JR
72892011-07-08 Jason Rumney <jasonr@gnu.org>
7290
22610910
JR
7291 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7292 SH_SHOW for hidden windows (Bug#5482).
7293
5df75e47
JR
7294 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7295 frame struct members of non-existent frames (Bug#6284).
7296
699c10bd
JD
72972011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7298
4393663b
JD
7299 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7300 variable firstTime not needed on OSX >= 10.6.
7301 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7302 >= 10.5. Use setKnobProportion, setDoubleValue.
7303
7304 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7305 (MAC_OS_X_VERSION_10_5): Define if not defined.
7306 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7307 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7308 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7309
7310 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7311 cString and lossyCString on OSX >= 10.4
7312
58179cce 7313 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7314 sizeToFit on OSX >= 10.2.
7315
7316 * nsimage.m (allocInitFromFile): Don't use deprecated method
7317 bestRepresentationForDevice on OSX >= 10.6.
7318
7319 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7320 to avoid warning.
7321
7322 * emacs.c: Declare unexec_init_emacs_zone.
7323
a63e0781
JD
7324 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7325
699c10bd
JD
7326 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7327
7328 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7329 on svcsMenu (Bug#8842).
7330
7331 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7332 ns_return_types.
7333 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7334
7335 * nsterm.m (QUTF8_STRING): Declare.
7336 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7337 (validRequestorForSendType): Return type is (id).
7338 Change indexOfObjectIdenticalTo to indexOfObject.
7339 Check if we have local selection before returning self (Bug#8842).
7340 (writeSelectionToPasteboard): Put local selection into paste board
7341 if we have a local selection (Bug#8842).
7342 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7343
7344 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7345 (ns_get_local_selection): Declare.
7346
54e10184
LMI
73472011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7348
9888ff71
LMI
7349 * keymap.c (describe_map_tree): Don't insert a double newline at
7350 the end of the buffer (bug#1169) and return whether we inserted
7351 something.
7352
54e10184
LMI
7353 * callint.c (Fcall_interactively): Change "reading args" to
7354 "providing args" to try to clarify what it does (bug#1010).
7355
15fa4783
KH
73562011-07-07 Kenichi Handa <handa@m17n.org>
7357
7358 * composite.c (composition_compute_stop_pos): Ignore a static
7359 composition starting before CHARPOS (Bug#8915).
7360
7361 * xdisp.c (handle_composition_prop): Likewise.
7362
a8815b00
EZ
73632011-07-07 Eli Zaretskii <eliz@gnu.org>
7364
7365 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7366 (Bug#9015)
7367
ef7b981d 73682011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7369
7370 * character.h (unicode_category_t): New enum type.
7371
7372 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7373 (Qchar_code_property_table): New variable.
7374 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7375 (UNIPROP_COMPRESSED_FORM_P): New macros.
7376 (char_table_ascii): Uncompress the compressed values.
7377 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7378 Uncompress the compressed values.
ac389d0c 7379 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7380 (char_table_ref_and_range): Uncompress the compressed values.
7381 (sub_char_table_set): New arg is_uniprop. Callers changed.
7382 Uncompress the compressed values.
7383 (sub_char_table_set_range): Args changed. Callers changed.
7384 (char_table_set_range): Adjuted for the above change.
7385 (map_sub_char_table): Delete args default_val and parent. Add arg
7386 top. Give decoded values to a Lisp function.
640c8776 7387 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7388 values to a Lisp function. Gcpro more variables.
7389 (uniprop_table_uncompress)
7390 (uniprop_decode_value_run_length): New functions.
7391 (uniprop_decoder, uniprop_decoder_count): New variables.
7392 (uniprop_get_decoder, uniprop_encode_value_character)
7393 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7394 New functions.
7395 (uniprop_encoder, uniprop_encoder_count): New variables.
7396 (uniprop_get_encoder, uniprop_table)
7397 (Funicode_property_table_internal, Fget_unicode_property_internal)
7398 (Fput_unicode_property_internal): New functions.
7399 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7400 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7401 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7402 char-code-property-alist.
7403
640c8776 7404 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7405 Vunicode_category_table.
7406
640c8776 7407 * font.c (font_range): Adjust for the change of
c805dec0
KH
7408 Vunicode_category_table.
7409
76b397fb
DN
74102011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7411
7412 * m/iris4d.h: Remove file, move contents ...
7413 * s/irix6-5.h: ... here.
7414
22b4128e
PE
74152011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7416
7417 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7418 * alloc.c (mark_buffer):
7419 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7420 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7421 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7422 This isn't true in general, and it's particularly not true
7423 if Emacs is configured with --with-wide-int.
7424 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7425 New macros, used in the buffer.c change.
7426
869795d6
JD
74272011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7428
7429 * xsettings.c: Use both GConf and GSettings if both are available.
7430 (store_config_changed_event): Add comment.
7431 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7432 (store_tool_bar_style_changed): New functions.
5e617bc2 7433 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7434 (struct xsettings): Move font inside HAVE_XFT.
7435 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7436 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7437 Move inside HAVE_XFT.
640c8776 7438 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7439 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7440 also.
7441 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7442 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7443 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7444 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7445 (parse_settings): Move check for font inside HAVE_XFT.
7446 (read_settings, apply_xft_settings): Add comment.
7447 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7448 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7449 call store_font_name_changed.
7450 (xft_settings_event): Add comment.
7451 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7452 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7453 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7454 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7455 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7456 (xsettings_get_system_font, xsettings_get_system_normal_font):
7457 Add comment.
869795d6 7458
d8ed26bd
PE
74592011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7460
7461 Random fixes. E.g., (random) never returned negative values.
7462 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7463 subseconds part to the entropy, as that's a bit more random.
7464 Prefer signed to unsigned, since the signedness doesn't matter and
7465 in general we prefer signed. When given a limit, use a
7466 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7467 latter isn't right if USE_2_TAGS_FOR_INTS.
7468 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7469 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7470
cabf1cac
SM
74712011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7472
7473 * textprop.c (text_property_stickiness):
7474 Obey Vtext_property_default_nonsticky.
7475 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7476 * w32fns.c (syms_of_w32fns):
7477 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7478
6e9b2be9
PE
74792011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7480
7481 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7482 This is more efficient than Ffile_directory_p and avoids a minor race.
7483
90186c68
LMI
74842011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7485
7c301272
LMI
7486 * buffer.c (Foverlay_put): Say what the return value is
7487 (bug#7835).
7488
c4f2d8d4
LMI
7489 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7490 is a directory before asking whether to use the file name
7491 (bug#7564).
ad637907
LMI
7492 (barf_or_query_if_file_exists): Make the "File is a directory"
7493 error be more correct.
c4f2d8d4 7494
90186c68
LMI
7495 * fns.c (Frequire): Remove the mention of the .gz files, since
7496 that's installation-specific, but keep the mention of
7497 `get-load-suffixes'.
7498
da64016e
PE
74992011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7500
7501 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7502 Report string overflow if the output is too long.
7503
7d47b580
JB
75042011-07-04 Juanma Barranquero <lekktu@gmail.com>
7505
a555cb87
JB
7506 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7507 (syms_of_gnutls): Remove duplicate DEFSYM for
7508 Qgnutls_bootprop_verify_hostname_error, an error for
7509 Qgnutls_bootprop_verify_error (which is no longer used).
7510
7d47b580
JB
7511 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7512 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7513 Also (re)move comments that are misplaced or no longer relevant.
7514
1e49bfab
LMI
75152011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7516
7517 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7518
1485f4c0
CY
75192011-07-03 Chong Yidong <cyd@stupidchicken.com>
7520
7521 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7522 and background color parameters if they have been changed.
7523
a9ab721e
LMI
75242011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7525
7526 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7527
cf7cff57
PE
75282011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7529
2e13213d
PE
7530 * xsettings.c (SYSTEM_FONT): Define only when used.
7531 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7532
cf7cff57
PE
7533 * keymap.c (access_keymap_1): Now static.
7534
7a8e04f7
CY
75352011-07-02 Chong Yidong <cyd@stupidchicken.com>
7536
7537 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7538 leave any prefix arg for the up event (Bug#1586).
7539
61352f62
LMI
75402011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7541
69bb1ef7
LMI
7542 * lread.c (syms_of_lread): Mention single symbols defined by
7543 `defvar' or `defconst' (bug#7154).
7544
61352f62 7545 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7546 (Frequire): Mention get-load-suffixes.
61352f62 7547
28545e04
MR
75482011-07-02 Martin Rudalics <rudalics@gmx.at>
7549
7550 * window.h (window): Remove clone_number slot.
7551 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7552 Remove.
7553 (make_parent_window, make_window, saved_window)
7554 (Fset_window_configuration, save_window_save): Don't deal with
7555 clone numbers.
7556 * buffer.c (Qclone_number): Remove declaration.
7557 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7558
3349e122
SM
75592011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7560
7561 Add multiple inheritance to keymaps.
7562 * keymap.c (Fmake_composed_keymap): New function.
7563 (Fset_keymap_parent): Simplify.
7564 (fix_submap_inheritance): Remove.
7565 (access_keymap_1): New function extracted from access_keymap to handle
7566 embedded parents and handle lists of maps.
7567 (access_keymap): Use it.
7568 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7569 (Fcopy_keymap): Handle embedded parents.
7570 (Fcommand_remapping, define_as_prefix): Simplify.
7571 (Fkey_binding): Simplify.
7572 (syms_of_keymap): Move minibuffer-local-completion-map,
7573 minibuffer-local-filename-completion-map,
7574 minibuffer-local-must-match-map, and
7575 minibuffer-local-filename-must-match-map to Elisp.
7576 (syms_of_keymap): Defsubr make-composed-keymap.
7577 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7578 (parse_menu_item): Trivial simplification.
7579
3279eb87
GM
75802011-07-01 Glenn Morris <rgm@gnu.org>
7581
7582 * Makefile.in (SETTINGS_LIBS): Fix typo.
7583
4550efdf
KI
75842011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7585
7586 * coding.c (Fencode_coding_string): Record the last coding system
7587 used, as the function doc string says (bug#8738).
7588
0949d2b6
JD
75892011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7590
7591 * xsettings.c (store_monospaced_changed): Take new font as arg and
7592 check for change against current_mono_font.
7593 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7594 (emacs_settings_constructor, emacs_settings_get_property)
7595 (emacs_settings_set_property, emacs_settings_class_init)
7596 (emacs_settings_init, gsettings_obj): Remove.
7597 (something_changedCB): New function for HAVE_GSETTINGS.
7598 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7599 with value as argument.
7600 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7601 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7602 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7603 "changed".
7604
7605 * xgselect.c: Add defined (HAVE_GSETTINGS).
7606 (xgselect_initialize): Ditto.
7607
7608 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7609 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7610 xg_select.
7611
bbc6b304
PE
76122011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7613
7614 * eval.c (struct backtrace): Simplify and port the data structure.
7615 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7616 signed bit field, as this assumption is not portable and it makes
7617 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7618 "char debug_on_exit : 1" as this is not portable either; instead,
7619 use the portable "unsigned int debug_on_exit : 1". Remove unused
7620 member evalargs. Remove obsolete comments about cc bombing out.
7621
9851bfc5
JD
76222011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7623
51bb811f 7624 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7625 Let HAVE_GSETTINGS override HAVE_GCONF.
7626 (store_monospaced_changed): New function.
7627 (EMACS_SETTINGS): A new type derived from GObject to handle
7628 GSettings notifications.
7629 (emacs_settings_constructor, emacs_settings_get_property)
7630 (emacs_settings_set_property, emacs_settings_class_init):
7631 New functions.
7632 (gsettings_client, gsettings_obj): New variables.
7633 (GSETTINGS_SCHEMA): New define.
7634 (something_changedCB): Call store_monospaced_changed.
7635 (init_gsettings): New function.
7636 (xsettings_initialize): Call init_gsettings.
7637 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7638 to NULL.
7639
640c8776 7640 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7641 GCONF_CFLAGS/LIBS.
7642
5386012d
MR
76432011-06-29 Martin Rudalics <rudalics@gmx.at>
7644
7645 * window.c (resize_root_window, grow_mini_window)
7646 (shrink_mini_window): Rename Qresize_root_window to
7647 Qwindow_resize_root_window and Qresize_root_window_vertically to
7648 Qwindow_resize_root_window_vertically.
7649
f13e0b08
PE
76502011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7651
7652 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7653
94515237
JB
76542011-06-27 Juanma Barranquero <lekktu@gmail.com>
7655
7656 * makefile.w32-in: Redesign dependencies so they reflect more
7657 clearly which files are directly included by each source file,
7658 and not through other includes.
7659
e43b6e43
MR
76602011-06-27 Martin Rudalics <rudalics@gmx.at>
7661
7662 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7663 (sort_overlays, overlay_strings): When an overlay's clone number
7664 matches the window's clone number process the overlay even if
7665 the overlay's window property doesn't match the current window.
7666
d68443dc
MR
7667 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7668 (Fwindow_hchild): Rename to Fwindow_left_child.
7669 (Fwindow_next): Rename to Fwindow_next_sibling.
7670 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7671 (resize_window_check): Rename to window_resize_check.
7672 (resize_window_apply): Rename to window_resize_apply.
7673 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7674 (Fdelete_other_windows_internal, resize_frame_windows)
7675 (Fsplit_window_internal, Fdelete_window_internal)
7676 (grow_mini_window, shrink_mini_window)
7677 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7678
c7e73be5
JD
76792011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7680
7681 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7682 (emacs_fixed_set_min_size): Remove.
7683 (emacs_fixed_new): Take frame as argument.
7684
7685 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7686 (_EmacsFixedPrivate): Remove minwidth/height.
7687 Add struct frame *f.
7688 (emacs_fixed_init): Initialize priv->f.
7689 (get_parent_class, emacs_fixed_set_min_size): Remove.
7690 (emacs_fixed_new): Set priv->f to argument.
7691 (emacs_fixed_get_preferred_width)
7692 (emacs_fixed_get_preferred_height): Use min_width/height from
7693 frames size_hint to set minimum and natural (Bug#8919).
7694 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7695 and use min_width/height from frames size_hint to set
7696 min_width/height (Bug#8919).
7697
7698 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7699 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7700 Fix indentation.
c7e73be5 7701
cf99dcf8
EZ
77022011-06-26 Eli Zaretskii <eliz@gnu.org>
7703
7704 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7705 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7706 called at ZV.
7707
029529ac
CY
77082011-06-26 Chong Yidong <cyd@stupidchicken.com>
7709
7710 * process.c (wait_reading_process_output): Bypass select if
7711 waiting for a cell while ignoring keyboard input, and input is
7712 pending. Suggested by Jan Djärv (Bug#8869).
7713
7a7ef429
PE
77142011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7715
7716 Use gnulib's dup2 module instead of rolling our own.
7717 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7718
11fdef7d 77192011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7720
7721 * dispnew.c (scrolling_window): Before scrolling, turn off a
7722 mouse-highlight in the window being scrolled.
7723
cd3520a4
JB
77242011-06-24 Juanma Barranquero <lekktu@gmail.com>
7725
7726 Move DEFSYM to lisp.h and use everywhere.
7727
7728 * character.h (DEFSYM): Move declaration...
7729 * lisp.h (DEFSYM): ...here.
7730
7731 * gnutls.c:
7732 * minibuf.c:
7733 * w32menu.c:
7734 * w32proc.c:
7735 * w32select.c: Don't include character.h.
7736
7737 * alloc.c (syms_of_alloc):
7738 * buffer.c (syms_of_buffer):
7739 * bytecode.c (syms_of_bytecode):
7740 * callint.c (syms_of_callint):
7741 * casefiddle.c (syms_of_casefiddle):
7742 * casetab.c (init_casetab_once):
7743 * category.c (init_category_once, syms_of_category):
7744 * ccl.c (syms_of_ccl):
7745 * cmds.c (syms_of_cmds):
7746 * composite.c (syms_of_composite):
7747 * dbusbind.c (syms_of_dbusbind):
7748 * dired.c (syms_of_dired):
7749 * dispnew.c (syms_of_display):
7750 * doc.c (syms_of_doc):
7751 * editfns.c (syms_of_editfns):
7752 * emacs.c (syms_of_emacs):
7753 * eval.c (syms_of_eval):
7754 * fileio.c (syms_of_fileio):
7755 * fns.c (syms_of_fns):
7756 * frame.c (syms_of_frame):
7757 * fringe.c (syms_of_fringe):
7758 * insdel.c (syms_of_insdel):
7759 * keymap.c (syms_of_keymap):
7760 * lread.c (init_obarray, syms_of_lread):
7761 * macros.c (syms_of_macros):
7762 * msdos.c (syms_of_msdos):
7763 * print.c (syms_of_print):
7764 * process.c (syms_of_process):
7765 * search.c (syms_of_search):
7766 * sound.c (syms_of_sound):
7767 * syntax.c (init_syntax_once, syms_of_syntax):
7768 * terminal.c (syms_of_terminal):
7769 * textprop.c (syms_of_textprop):
7770 * undo.c (syms_of_undo):
7771 * w32.c (globals_of_w32):
7772 * window.c (syms_of_window):
7773 * xdisp.c (syms_of_xdisp):
7774 * xfaces.c (syms_of_xfaces):
7775 * xfns.c (syms_of_xfns):
7776 * xmenu.c (syms_of_xmenu):
7777 * xsettings.c (syms_of_xsettings):
7778 * xterm.c (syms_of_xterm): Use DEFSYM.
7779
4228cf16
TZ
77802011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7781
cd3520a4 7782 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7783
7fcccf1e
PE
77842011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7785
7efb4e0e
PE
7786 Integer and buffer overflow fixes (Bug#8873).
7787
ff5844ad
PE
7788 * print.c (printchar, strout): Check for string overflow.
7789 (PRINTPREPARE, printchar, strout):
7790 Don't set size unless allocation succeeds.
7791
90532f02
PE
7792 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7793 for sizes. Check for string overflow more accurately.
7794 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7795
6d84508d
PE
7796 * macros.c: Integer and buffer overflow fixes.
7797 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7798 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7799 Use ptrdiff_t, not int, for sizes.
7800 Don't increment bufsize until after realloc succeeds.
7801 Check for size-calculation overflow.
7802 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7803
437b2cb4
PE
7804 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7805
8b9ac8b4
PE
7806 * lread.c: Integer overflow fixes.
7807 (read_integer): Radix is now EMACS_INT, not int,
7808 to improve quality of diagnostics for out-of-range radices.
7809 Calculate buffer size correctly for out-of-range radices.
7810 (read1): Check for integer overflow in radices, and in
7811 read-circle numbers.
82cb60d3
PE
7812 (read_escape): Avoid int overflow.
7813 (Fload, openp, read_buffer_size, read1)
7814 (substitute_object_recurse, read_vector, read_list, map_obarray):
7815 Use ptrdiff_t, not int, for sizes.
7816 (read1): Use EMACS_INT, not int, for sizes.
20270765 7817 Check for size overflow.
8b9ac8b4 7818
7fcccf1e
PE
7819 * image.c (cache_image): Check for size arithmetic overflow.
7820
bfbbd7e7
PE
7821 * lread.c: Integer overflow issues.
7822 (saved_doc_string_size, saved_doc_string_length)
7823 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7824 Now ptrdiff_t, not int.
7825 (read1): Don't assume doc string length fits in int. Check for
7826 out-of-range doc string lengths.
7827 (read_list): Don't assume file position fits in int.
39019e54 7828 (read_escape): Check for hex character overflow.
bfbbd7e7 7829
4e323265
LL
78302011-06-22 Leo Liu <sdl.web@gmail.com>
7831
7832 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7833 Move to minibuffer.el.
7834
85fece3e
PE
78352011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7836
20b84ce9 7837 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7838 The following patches are for when GLYPH_DEBUG && !XASSERT.
7839 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7840 * dispnew.c (flush_stdout):
7841 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7842 Mark as externally visible.
7843 * dispnew.c (check_window_matrix_pointers): Now static.
7844 * dispnew.c (window_to_frame_vpos):
7845 * xfns.c (unwind_create_frame):
7846 * xterm.c (x_check_font): Remove unused local.
7847 * scroll.c (CHECK_BOUNDS):
7848 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7849 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7850 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7851 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7852 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7853 Now static.
7854 (debug_method_add): Use va_list and vsprintf rather than relying
7855 on undefined behavior with wrong number of arguments.
7856 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7857 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7858 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7859 since we're not interested in debugging glyphs with old libraries.
7860 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7861 GCC 4.6.0's static checking.
7862
0766b489
PE
78632011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7864
31fd4b32
PE
7865 Integer overflow and signedness fixes (Bug#8873).
7866 A few related buffer overrun fixes, too.
7867
b79e8648
PE
7868 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7869
0766b489
PE
7870 * dispextern.h (struct face.stipple):
7871 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7872 (x_bitmap_mask, x_allocate_bitmap_record)
7873 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7874 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7875 (x_create_bitmap_from_xpm_data):
7876 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7877 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7878 (.bitmaps_last):
7879 * xfaces.c (load_pixmap):
7880 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7881 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7882 (.bitmaps_last, struct x_output.icon_bitmap):
7883 Use ptrdiff_t, not int, for bitmap indexes.
7884 (x_allocate_bitmap_record): Check for size overflow.
7885 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7886
b081724f
PE
7887 Use ptrdiff_t, not int, for overlay counts.
7888 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7889 * editfns.c (overlays_around, get_pos_property):
7890 * textprop.c (get_char_property_and_overlay):
7891 * xdisp.c (next_overlay_change, note_mouse_highlight):
7892 * xfaces.c (face_at_buffer_position):
21514da7
PE
7893 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7894 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7895 (Fnext_overlay_change, Fprevious_overlay_change)
7896 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7897 Use ptrdiff_t, not int, for sizes.
21514da7 7898 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7899
3de73e5e
PE
7900 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7901
2606c57b
PE
7902 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7903 (x_session_initialize): Do not assume string length fits in int.
7904
aaafe47a
PE
7905 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7906 This is unlikely, but can occur if DPI is outlandish.
7907
2674ddc8 7908 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7909 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7910
28154962
PE
7911 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7912 * xrdb.c (magic_file_p, search_magic_path):
7913 Omit last arg SUFFIX; it was always 0. All callers changed.
7914 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7915
7de51af5
PE
7916 * xfont.c (xfont_match): Avoid need for strlen.
7917
25ed6cc3
PE
7918 * xfns.c: Don't assume strlen fits in int.
7919 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7920
4eab31dd
PE
7921 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7922 not unsigned long, as we prefer signed integers. All callers changed.
7923 Detect integer overflow in repeat count.
7924 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7925 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7926
171e2a58
PE
7927 * termcap.c: Don't assume sizes fit in int and never overflow.
7928 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7929 (gobble_line): Check for size-calculation overflow.
7930
ad39faca 7931 * minibuf.c (Fread_buffer):
6e5bb2dc 7932 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7933 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7934 Don't assume string length fits in int.
7935
52c61c22 7936 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7937 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7938
b5b8c9e5
PE
7939 * font.c: Don't assume string length fits in int.
7940 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7941 Use ptrdiff_t, not int.
ccd6111c
PE
7942 (font_intern_prop): Don't assume string length fits in int.
7943 Don't assume integer property fits in fixnum.
7944 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7945
882f0d81 7946 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7947 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7948 Reformulate so as not to need the command string.
7949 Invoke gzip -cd rather than gunzip, as it's more portable.
7950 (lock_info_type, lock_file_1, lock_file):
7951 Don't assume pid_t and time_t fit in unsigned long.
7952 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7953 (current_lock_owner): Prefer signed type for sizes.
7954 Use memcpy, not strncpy, where memcpy is what is really wanted.
7955 Don't assume (via atoi) that time_t and pid_t fit in int.
7956 Check for time_t and/or pid_t out of range, e.g., via a network share.
7957 Don't alloca where an auto var works fine.
7958
93f4cf88
PE
7959 * fileio.c: Fix some integer overflow issues.
7960 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7961 Don't assume string length fits in int.
7962 (directory_file_name): Don't assume string length fits in long.
7963 (make_temp_name): Don't assume pid fits in int, or that its print
7964 length is less than 20.
7965
f3e92b69
PE
7966 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7967
1bfdaf10
PE
7968 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7969
35016e9a
PE
7970 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7971
3d1e65a1
PE
7972 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7973 We prefer signed integers, even for size calculations.
7974
0b963a93
PE
7975 * emacs.c: Don't assume string length fits in 'int'.
7976 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7977 (main): Don't invoke strlen when not needed.
7978
573f4b54
PE
7979 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7980 (XD_DEBUG_MESSAGE): Don't waste a byte.
7981
989f33ba
PE
7982 * callproc.c (getenv_internal_1, getenv_internal)
7983 (Fgetenv_internal):
965d34eb
PE
7984 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7985
e4d29b33
PE
7986 * lread.c (invalid_syntax): Omit length argument.
7987 All uses changed. This doesn't fix a bug, but it simplifies the
7988 code away from its former Hollerith-constant appearance, and it's
7989 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7990 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7991
eb49b136
PE
7992 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7993 This didn't break anything, but it didn't help either.
7994 It's confusing to put a bogus integer in a place where the actual
7995 value does not matter.
9f62aeb1 7996 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7997 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7998
15375a22
PE
7999 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8000 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8001 implementation.
b61cc01c
PE
8002 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8003 We prefer signed types, and the value cannot exceed the EMACS_INT
8004 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8005 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8006 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8007 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8008
53b2623d
PE
8009 * indent.c (sane_tab_width): New function.
8010 (current_column, scan_for_column, Findent_to, position_indentation)
8011 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8012 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8013
51cab52b 8014 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8015
f2ed8a70
PE
8016 * lisp.h (lint_assume): New macro.
8017 * composite.c (composition_gstring_put_cache):
8018 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8019
abe80cc6
PE
8020 * editfns.c, insdel.c:
8021 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8022
b02c740e
PE
8023 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8024
ebc96716
PE
8025 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8026
b4e50fa0 8027 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8028 Use much-faster test for byte-length change.
311d5d7c 8029 Don't assume string byte-length fits in 'int'.
a4cf38e4 8030 Check that character arg fits in 'int'.
85461888 8031 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8032
c0c1ee9f
PE
8033 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8034
a498d7f4
PE
8035 * fns.c (concat): Catch string overflow earlier.
8036 Do not rely on integer wraparound.
8037
51cab52b
PE
8038 * dispextern.h (struct it.overlay_strings_charpos)
8039 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8040 * xdisp.c (forward_to_next_line_start)
8041 (back_to_previous_visible_line_start)
8042 (reseat_at_next_visible_line_start, next_element_from_buffer):
8043 Don't arbitrarily truncate the value of 'selective' to int.
8044
76031fad
PE
8045 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8046
5eb55db9
PE
8047 * composite.c: Don't truncate sizes to 'int'.
8048 (composition_gstring_p, composition_reseat_it)
8049 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8050 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8051 not EMACS_UINT, for indexes.
5eb55db9 8052
0703a717
PE
8053 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8054
d6202519
PE
8055 * buffer.c: Include <verify.h>.
8056 (struct sortvec.priority, struct sortstr.priority):
8961a454 8057 Now EMACS_INT, not int.
c20998a7 8058 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8059 (struct sortstr.size, record_overlay_string)
8060 (struct sortstrlist.size, struct sortlist.used):
8061 Don't truncate size to int.
8062 (record_overlay_string): Check for size-calculation overflow.
d6202519 8063 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8064
d5a19415
JM
80652011-06-22 Jim Meyering <meyering@redhat.com>
8066
029529ac 8067 Don't leak an XBM-image-sized buffer
d5a19415
JM
8068 * image.c (xbm_load): Free the image buffer after using it.
8069
a9041e6c
PE
80702011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8071
8072 Port to Sun C.
8073 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8074 that Sun C diagnosed.
8075 * fns.c (secure_hash): Fix pointer signedness issue.
8076 * intervals.c (static_offset_intervals): New function.
8077 (offset_intervals): Use it.
8078
7f3f739f
LL
80792011-06-21 Leo Liu <sdl.web@gmail.com>
8080
8081 * deps.mk (fns.o):
8082 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8083 sha512.h.
8084
8085 * fns.c (secure_hash): Rename from crypto_hash_function and change
8086 the first arg to accept symbols.
5b66d427 8087 (Fsecure_hash): New primitive.
7f3f739f
LL
8088 (syms_of_fns): New symbols.
8089
76147d94
DD
80902011-06-20 Deniz Dogan <deniz@dogan.se>
8091
8092 * process.c (Fset_process_buffer): Clarify return value in
8093 docstring.
8094
7d7d0045
CY
80952011-06-18 Chong Yidong <cyd@stupidchicken.com>
8096
8097 * dispnew.c (add_window_display_history): Use BVAR.
8098
8099 * xdisp.c (debug_method_add): Use BVAR.
8100 (check_window_end, dump_glyph_matrix, dump_glyph)
8101 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8102
8103 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8104 Likewise.
8105
8106 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8107 check till after the cache is created in init_frame_faces.
8108
ff2bc410
SM
81092011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8110
8111 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8112
28177add
PE
81132011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8114
dd3482fe
PE
8115 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8116 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8117 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8118
393d71f3 8119 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8120 * fileio.c (Finsert_file_contents):
8121 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8122 Remove the old (too-loose) buffer overflow checks.
8123 They weren't needed, since make_gap checks for buffer overflow.
8124 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8125 The old code merely checked for Emacs fixnum overflow, and relied
8126 on undefined (wraparound) behavior. The new code avoids undefined
8127 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8128
2e6813b0 8129 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8130 Tune. Don't use wider integers than needed. Don't use alloca.
8131 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8132
599a9e4f
PE
8133 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8134
99561444
PE
8135 * insdel.c, lisp.h (buffer_overflow): New function.
8136 (insert_from_buffer_1, replace_range, replace_range_2):
8137 * insdel.c (make_gap_larger):
8138 * editfns.c (Finsert_char):
8139 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8140
28177add
PE
8141 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8142
e69dafad
PE
81432011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8144
4baa020d 8145 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8146
b1c46f02
PE
8147 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8148 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8149
e69dafad
PE
8150 * fileio.c: Don't assume EMACS_INT fits in off_t.
8151 (emacs_lseek): New static function.
8152 (Finsert_file_contents, Fwrite_region): Use it.
8153 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8154
566684ea
PE
8155 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8156
e6966cd6
PE
8157 * fns.c: Don't overflow int when computing a list length.
8158 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8159 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8160 truncation on 64-bit hosts. Check for QUIT every
8161 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8162 faster and is responsive enough.
8163 (Flength): Report an error instead of overflowing an integer.
8164 (Fsafe_length): Return a float if the value is not representable
8165 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8166 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8167 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8168
dd0b0efb
PE
8169 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8170 (header_size, word_size): New constants.
8171 (allocate_vectorlike): Don't check size overflow here.
8172 (allocate_vector): Check it here instead, since this is the only
8173 caller of allocate_vectorlike that could cause overflow.
8174 Check that the new vector's length is representable as a fixnum.
8175
86fe5cfe
PE
8176 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8177 The previous code was bogus. For example, next_almost_prime (32)
8178 returned 39, which is undesirable as it is a multiple of 3; and
8179 next_almost_prime (24) returned 25, which is a multiple of 5 so
8180 why was the code bothering to check for multiples of 7?
8181
80e88859
PE
8182 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8183
4a2f0ad6
PE
8184 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8185
f66c7cf8
PE
8186 Variadic C functions now count arguments with ptrdiff_t.
8187 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8188 Back then I didn't know that the Emacs coding style prefers signed int.
8189 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8190 were being counted with int, which may truncate counts on 64-bit
8191 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8192 * lisp.h (struct Lisp_Subr.function.aMANY)
8193 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8194 Arg counts are now ptrdiff_t, not size_t.
8195 All variadic functions and their callers changed accordingly.
8196 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8197 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8198 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8199 * callint.c (Fcall_interactively): Check arg count for overflow,
8200 to avoid potential buffer overrun. Use signed char, not 'int',
8201 for 'varies' array, so that we needn't bother to check its size
8202 calculation for overflow.
8203 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8204 * eval.c (apply_lambda):
8205 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8206 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8207 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8208
a1759b76
PE
8209 * callint.c (Fcall_interactively): Don't use index var as event count.
8210
d96be9fc
PE
8211 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8212 * mem-limits.h (SIZE): Remove; no longer used.
8213
a690a978 8214 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8215
578c21e6
PE
8216 Remove unnecessary casts.
8217 * xterm.c (x_term_init):
8218 * xfns.c (x_set_border_pixel):
8219 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8220 These aren't needed now that we assume ANSI C.
8221
96f53c6c
PE
8222 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8223 It's more likely to cause problems (due to unsigned overflow)
8224 than to cure them.
8225
83c77d31
PE
8226 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8227
ee2079f1
PE
8228 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8229
6da65536
PE
8230 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8231
7147c4a4
PE
8232 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8233
193e32d9
PE
8234 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8235
e5533da6
PE
8236 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8237
9910e595
PE
8238 GLYPH_CODE_FACE returns EMACS_INT, not int.
8239 * dispextern.h (merge_faces):
8240 * xfaces.c (merge_faces):
01103c44
PE
8241 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8242 Don't assume EMACS_INT fits in int.
9910e595 8243
2638320e
PE
8244 * character.h (CHAR_VALID_P): Remove unused parameter.
8245 * fontset.c, lisp.h, xdisp.c: All uses changed.
8246
045eb8d9
PE
8247 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8248
c1f134b5
PE
8249 * fns.c (concat): Minor tuning based on overflow analysis.
8250 This doesn't fix any bugs. Use int to hold character, instead
8251 of constantly refetching from Emacs object. Use XFASTINT, not
8252 XINT, for value known to be a character. Don't bother comparing
8253 a single byte to 0400, as it's always less.
8254
395fcb93 8255 * floatfns.c (Fexpt):
327eeec8
PE
8256 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8257
abbd3d23
PE
8258 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8259 for characters.
8260
684a03ef
PE
8261 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8262
0fed43f3
PE
8263 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8264 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8265 incorrectly succeed when S was a string, because 4294967386 was
8266 truncated before it was used.
8267
8fd02eb7
PE
8268 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8269 Otherwise, an out-of-range integer could cause undefined behavior
8270 on a 64-bit host.
8271
f8c86b69
PE
8272 * composite.c: Use int, not EMACS_INT, for characters.
8273 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8274 EMACS_INT, for values that are known to be in character range.
8275 This doesn't fix any bugs but is the usual style inside Emacs and
8276 may generate better code on 32-bit machines.
8277
34206dd2
PE
8278 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8279 This is for reasons similar to the recent CHAR_STRING fix.
8280 * charset.c (Fencode_char): Check that character arg is actually
8281 a character. Pass an int to ENCODE_CHAR.
8282 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8283 wider than 'int', as a compile-time check to prevent future regressions
8284 in this area.
8285
c5958d4c 8286 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8287
8288 Make sure a 64-bit char is never passed to CHAR_STRING.
8289 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8290 by silently ignoring the top 32 bits, allowing some values
8291 that were far too large to be valid characters.
8292 * character.h: Include <verify.h>.
8293 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8294 arguments are no wider than unsigned, as a compile-time check
8295 to prevent future regressions in this area.
8296 * data.c (Faset):
01103c44 8297 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8298 (Fsubst_char_in_region):
8299 * fns.c (concat):
8300 * xdisp.c (decode_mode_spec_coding):
8301 Adjust to CHAR_STRING's new requirement.
8302 * editfns.c (Finsert_char, Fsubst_char_in_region):
8303 * fns.c (concat): Check that character args are actually
8304 characters. Without this test, these functions did the wrong
8305 thing with wildly out-of-range values on 64-bit hosts.
8306
d37ca623
PE
8307 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8308 These casts should not be needed on 32-bit hosts, either.
8309 * keyboard.c (read_char):
8310 * lread.c (Fload): Remove casts to unsigned.
8311
ea204efb
PE
8312 * lisp.h (UNSIGNED_CMP): New macro.
8313 This fixes comparison bugs on 64-bit hosts.
8314 (ASCII_CHAR_P): Use it.
8315 * casefiddle.c (casify_object):
01103c44 8316 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8317 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8318 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8319 * dispextern.h (FACE_FROM_ID):
8320 * keyboard.c (read_char): Use UNSIGNED_CMP.
8321
41cb286c
PE
8322 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8323 not to EMACS_INT, to avoid GCC warning.
8324
4a1b9832
PE
8325 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8326
55daad71
PE
8327 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8328 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8329 isn't needed on 32-bit machines.
8f95c75c 8330
01103c44
PE
8331 * buffer.c (Fgenerate_new_buffer_name):
8332 Use EMACS_INT for count, not int.
0ceccced 8333 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8334
8335 * data.c (Qcompiled_function): Now static.
8336
c6f072e7
PE
8337 * window.c (window_body_lines): Now static.
8338
20ce5912
PE
8339 * image.c (gif_load): Rename local to avoid shadowing.
8340
9c4c5f81
PE
8341 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8342 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8343 * alloc.c (make_save_value): Integer argument is now of type
8344 ptrdiff_t, not int.
8345 (mark_object): Use ptrdiff_t, not int.
8346 * lisp.h (pD): New macro.
8347 * print.c (print_object): Use it.
8348
c0c5c8ae
PE
8349 * alloc.c: Use EMACS_INT, not int, to count objects.
8350 (total_conses, total_markers, total_symbols, total_vector_size)
8351 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8352 (total_free_floats, total_floats, total_free_intervals)
8353 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8354 Now EMACS_INT, not int. All uses changed.
8355 (Fgarbage_collect): Compute overall total using a double, so that
8356 integer overflow is less likely to be a problem. Check for overflow
8357 when converting back to an integer.
5a25e253
PE
8358 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8359 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8360 These were 'int' variables that could overflow on 64-bit hosts;
8361 they were never used, so remove them instead of repairing them.
211a0b2a 8362 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8363 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8364 Previously, this ceilinged at INT_MAX, but that doesn't work on
8365 64-bit machines.
e46bb31a 8366 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8367
c78baabf 8368 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8369 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8370 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8371 when a (possibly-narrower) signed value would do just as well.
8372 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8373
c9d624c6
PE
8374 * alloc.c: Catch some string size overflows that we were missing.
8375 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8376 for convenience in STRING_BYTES_MAX.
8377 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8378 The definition here is exact; the one in lisp.h was approximate.
8379 (allocate_string_data): Check for string overflow. This catches
8380 some instances we weren't catching before. Also, it catches
8381 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8382 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8383 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8384
c9d624c6
PE
8385 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8386 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8387 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8388
353032ce
PE
8389 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8390
2bccce07
PE
8391 * alloc.c (Fmake_string): Check for out-of-range init.
8392
0ac30604
SM
83932011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8394
8395 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8396
c195f2de
JD
83972011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8398
8399 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8400 xg_get_default_scrollbar_width.
8401
8402 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8403 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8404 (style_changed_cb): Call update_theme_scrollbar_width and call
8405 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8406 all frames (Bug#8505).
8407 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8408 Call gtk_window_set_resizable if HAVE_GTK3.
8409 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8410 and height if HAVE_GTK3 (Bug#8505).
8411 (scroll_bar_width_for_theme): New variable.
8412 (update_theme_scrollbar_width): New function.
8413 (xg_get_default_scrollbar_width): Move code to
8414 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8415 (xg_initialize): Call update_theme_scrollbar_width.
8416
8417 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8418
8419 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8420
e10ac9f1
MR
84212011-06-12 Martin Rudalics <rudalics@gmx.at>
8422
8423 * frame.c (make_frame): Call other_buffer_safely instead of
8424 other_buffer.
8425
8426 * window.c (temp_output_buffer_show): Call display_buffer with
8427 second argument Vtemp_buffer_show_specifiers and reset latter
8428 immediately after the call.
8429 (Vtemp_buffer_show_specifiers): New variable.
8430 (auto_window_vscroll_p, next_screen_context_lines)
8431 (Vscroll_preserve_screen_position): Remove leading asterisks from
8432 doc-strings.
8433
2d3c217e 84342011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8435
7b7f97e8 8436 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8437 * buffer.c (Qclone_number): Remove for now, as it's unused.
8438 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8439 (record_buffer): Remove unused local.
8440 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8441 (set_frame_buffer_list): Remove; unused.
8442 * frame.h (other_visible_frames): Remove decl.
8443 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8444 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8445 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8446 if HAVE_GPM.
8447 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8448 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8449 Define only if HAVE_GPM.
8450 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8451 (update_hints_inhibit): Remove; never set. All uses removed.
8452 * widgetprv.h (emacsFrameClassRec): Remove decl.
8453 * window.c (delete_deletable_window): Now returns void, since it
8454 wasn't returning anything.
8455 (compare_window_configurations): Remove unused locals.
8456 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8457 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8458 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8459 the same widths as pointers. This follows up on the 2011-05-06 patch.
8460 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8461 * xterm.h: Likewise.
8462 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8463
1384b89e
JB
84642011-06-12 Juanma Barranquero <lekktu@gmail.com>
8465
8466 * makefile.w32-in: Update dependencies.
8467 (LISP_H): Add lib/intprops.h.
8468
1100a63c
CY
84692011-06-11 Chong Yidong <cyd@stupidchicken.com>
8470
8471 * image.c (gif_load): Add animation frame delay to the metadata.
8472 (syms_of_image): Use DEFSYM. New symbol `delay'.
8473
6198ccd0
MR
84742011-06-11 Martin Rudalics <rudalics@gmx.at>
8475
8476 * window.c (delete_deletable_window): Re-add.
8477 (Fset_window_configuration): Rewrite to handle dead buffers and
8478 consequently deletable windows.
8479 (window_tree, Fwindow_tree): Remove. Supply functionality in
8480 window.el.
8481 (compare_window_configurations): Simplify code.
8482
b6e3633c
AS
84832011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8484
1ab0dee5
AS
8485 * image.c (imagemagick_load_image): Fix type mismatch.
8486 (Fimagemagick_types): Likewise.
8487
b6e3633c
AS
8488 * window.h (replace_buffer_in_windows): Declare.
8489
9397e56f
MR
84902011-06-11 Martin Rudalics <rudalics@gmx.at>
8491
8492 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8493 Qclone_number. Remove external declaration of Qdelete_window.
8494 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8495 code.
640c8776
SM
8496 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8497 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8498 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8499 buffer list implementation.
8500 (other_buffer_safely): New function.
8501 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8502 calls to replace_buffer_in_windows and
8503 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8504 if allowed.
8505 (record_buffer): Inhibit quitting and rewrite using quittable
8506 functions. Run Qbuffer_list_update_hook if allowed.
8507 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8508 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8509 Move switch-to-buffer to window.el.
9397e56f
MR
8510 (bury-buffer): Move to window.el.
8511 (Vbuffer_list_update_hook): New variable.
8512
8513 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8514 section.
8515
8516 * window.h (resize_frame_windows): Move up in code.
8517 (Fwindow_frame): Remove EXFUN.
8518 (replace_buffer_in_all_windows): Remove prototype.
8519 (replace_buffer_in_windows_safely): Add prototype.
8520
8521 * window.c: Declare Qdelete_window static again. Move down
8522 declaration of select_count.
8523 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8524 (Fother_window): Move to window.el.
8525 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8526 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8527 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8528 window.el.
8529 (replace_buffer_in_windows): Implement by calling
8530 Qreplace_buffer_in_windows.
8531 (replace_buffer_in_all_windows): Remove with some functionality
8532 moved into replace_buffer_in_windows_safely.
8533 (replace_buffer_in_windows_safely): New function.
8534 (select_window_norecord, select_frame_norecord): Move in front
8535 of run_window_configuration_change_hook. Remove now obsolete
8536 declarations.
640c8776
SM
8537 (Fset_window_buffer): Rewrite doc-string.
8538 Call Qrecord_window_buffer.
9397e56f
MR
8539 (keys_of_window): Move binding for other-window to window.el.
8540
b50691aa
CY
85412011-06-11 Chong Yidong <cyd@stupidchicken.com>
8542
8543 * dispextern.h (struct image): Replace data member, whose int_val
8544 and ptr_val fields were not used by anything, with a single
8545 lisp_val object.
8546
8547 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8548 (gif_clear_image, gif_load, imagemagick_load_image)
8549 (gs_clear_image, gs_load): Callers changed.
8550
3f754b86
PE
85512011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8552
cca69397
PE
8553 * buffer.h: Include <time.h>, for time_t.
8554 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8555
109e28d0
PE
8556 Fix minor problems found by static checking.
8557
60737f02
PE
8558 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8559
4b66faf3
PE
8560 Make identifiers static if they are not used in other modules.
8561 * data.c (Qcompiled_function, Qframe, Qvector):
8562 * image.c (QimageMagick, Qsvg):
8563 * minibuf.c (Qmetadata):
8564 * window.c (resize_window_check, resize_root_window): Now static.
8565 * window.h (resize_window_check, resize_root_window): Remove decls.
8566
109e28d0
PE
8567 * window.c (window_deletion_count, delete_deletable_window):
8568 Remove; unused.
46a4ce9e
PE
8569 (window_body_lines): Now static.
8570 (Fdelete_other_windows_internal): Mark vars as initialized.
8571 Make sure 'resize_failed' is initialized.
8572 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8573 (resize_window_apply): Remove unused local.
8574 * window.h (delete_deletable_window): Remove decl.
8575
109e28d0 8576 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8577 (imagemagick_load_image): Fix pointer signedness problem by changing
8578 last arg from unsigned char * to char *. All uses changed.
8579 Also, fix a local for similar reasons.
8580 Remove unused locals. Remove locals to avoid shadowing.
8581 (fn_rsvg_handle_free): Remove; unused.
8582 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8583 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8584
3f754b86
PE
8585 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8586
2547adb1
CY
85872011-06-10 Chong Yidong <cyd@stupidchicken.com>
8588
8589 * image.c (gif_load): Fix omitted cast error introduced by
8590 2011-06-06 change.
8591
2c8e37d4
MR
85922011-06-10 Martin Rudalics <rudalics@gmx.at>
8593
8594 * window.h (resize_proportionally, orig_total_lines)
8595 (orig_top_line): Remove from window structure.
8596 (set_window_height, set_window_width, change_window_heights)
8597 (Fdelete_window): Remove prototypes.
8598 (resize_frame_windows): Remove duplicate declaration.
8599
440a42e3
EZ
86002011-06-10 Eli Zaretskii <eliz@gnu.org>
8601
8602 * window.h (resize_frame_windows, resize_window_check)
8603 (delete_deletable_window, resize_root_window)
8604 (resize_frame_windows): Declare prototypes.
8605
8606 * window.c (resize_window_apply): Make definition be "static" to
8607 match the prototype.
8608
562dd5e9
MR
86092011-06-10 Martin Rudalics <rudalics@gmx.at>
8610
8611 * window.c: Remove declarations of Qwindow_size_fixed,
8612 window_min_size_1, window_min_size_2, window_min_size,
8613 size_window, window_fixed_size_p, enlarge_window, delete_window.
8614 Remove static from declaration of Qdelete_window, it's
8615 temporarily needed by Fbury_buffer.
8616 (replace_window): Don't assign orig_top_line and
8617 orig_total_lines.
8618 (Fdelete_window, delete_window): Remove. Window deletion is
8619 handled by window.el.
640c8776
SM
8620 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8621 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8622 (Fdelete_other_windows): Remove. Deleting other windows is
8623 handled by window.el.
8624 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8625 handled in window.el.
8626 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8627 Window minimum sizes are handled in window.el.
8628 (shrink_windows, size_window, set_window_height)
8629 (set_window_width, change_window_heights, window_height)
8630 (window_width, CURBEG, CURSIZE, enlarge_window)
8631 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8632 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8633 handled in window.el.
8634 (make_dummy_parent): Rename to make_parent_window and give it a
8635 second argument horflag.
8636 (make_window): Don't set resize_proportionally any more.
8637 (Fsplit_window): Remove. Windows are split in window.el.
8638 (save_restore_action, save_restore_orig_size)
8639 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8640 Resize mini windows in window.el.
8641 (grow_mini_window, shrink_mini_window): Implement by calling
8642 Qresize_root_window_vertically, resize_window_check and
8643 resize_window_apply.
640c8776
SM
8644 (saved_window, Fset_window_configuration, save_window_save):
8645 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8646 resize_proportionally.
8647 (window_min_height, window_min_width): Move to window.el.
8648 (keys_of_window): Move bindings for delete-other-windows,
8649 split-window, delete-window and enlarge-window to window.el.
8650
8651 * buffer.c: Temporarily extern Qdelete_window.
8652 (Fbury_buffer): Temporarily call Qdelete_window instead of
8653 Fdelete_window (Fbury_buffer will move to window.el soon).
8654
8655 * frame.c (set_menu_bar_lines_1): Remove code handling
8656 orig_top_line and orig_total_lines.
8657
8658 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8659 set_window_height but set heights directly.
8660 (change_frame_size_1): Use resize_frame_windows.
8661
8662 * xdisp.c (init_xdisp): Don't use set_window_height but set
8663 heights directly.
8664
640c8776
SM
8665 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8666 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8667 run_window_configuration_change_hook.
8668
8669 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8670 instead of change_window_heights and run
8671 run_window_configuration_change_hook.
8672
1a13852e
MR
86732011-06-09 Martin Rudalics <rudalics@gmx.at>
8674
8675 * window.c (replace_window): Rename second argument REPLACEMENT to
8676 NEW. New third argument SETFLAG. Rewrite.
8677 (delete_window, make_dummy_parent): Call replace_window with
8678 third argument 1.
8679 (window_list_1): Move down in code.
8680 (run_window_configuration_change_hook): Move set_buffer part
8681 before select_frame_norecord part in order to unwind correctly.
8682 Rename count1 to count.
8683 (recombine_windows, delete_deletable_window, resize_root_window)
8684 (Fdelete_other_windows_internal)
8685 (Frun_window_configuration_change_hook, make_parent_window)
8686 (resize_window_check, resize_window_apply, Fresize_window_apply)
8687 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8688 (Fdelete_window_internal, Fresize_mini_window_internal):
8689 New functions.
1a13852e
MR
8690 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8691
f3d1777e
MR
86922011-06-08 Martin Rudalics <rudalics@gmx.at>
8693
496e208e
MR
8694 * window.h (window): Add some new members to window structure -
8695 normal_lines, normal_cols, new_total, new_normal, clone_number,
8696 splits, nest, prev_buffers, next_buffers.
8697 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8698 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8699
f3d1777e
MR
8700 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8701 Remove.
496e208e
MR
8702 (make_dummy_parent): Set new members of windows structure.
8703 (make_window): Move down in code. Handle new members of window
8704 structure.
8705 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8706 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8707 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8708 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8709 (Fset_window_next_buffers, Fset_window_clone_number):
8710 New functions.
496e208e
MR
8711 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8712 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8713 Doc-string fixes.
8714 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8715 Argument WINDOW can be now internal window too.
8716 (Fwindow_use_time): Move up in code.
8717 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8718 Rewrite doc-string.
8719 (Fset_window_configuration, saved_window)
8720 (Fcurrent_window_configuration, save_window_save): Handle new
8721 members of window structure.
b9e809c2
MR
8722 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8723 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8724 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8725 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8726 Qget_mru_window, Qresize_root_window,
8727 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8728 Qauto_buffer_name; staticpro them.
f3d1777e 8729
abde8f8c
MR
87302011-06-07 Martin Rudalics <rudalics@gmx.at>
8731
8732 * window.c (Fwindow_total_size, Fwindow_left_column)
8733 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8734 (Fwindow_list_1): New functions.
8735 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8736 (Fwindow_width, Fscroll_left, Fscroll_right):
8737 Use window_body_cols instead of window_box_text_cols.
8738 (delete_window, Fset_window_configuration):
8739 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8740 (delete_all_subwindows): Take a window as argument and not a
8741 structure. Rewrite.
190b47e6
MR
8742 (window_loop): Remove handling of GET_LRU_WINDOW and
8743 GET_LARGEST_WINDOW.
8744 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8745
8746 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8747 window_box_text_cols. delete_all_subwindows now takes a
8748 Lisp_Object as argument.
abde8f8c 8749
640c8776
SM
8750 * indent.c (compute_motion, Fcompute_motion):
8751 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8752
fa8a67e6
MR
8753 * frame.c (delete_frame): Call delete_all_subwindows with root
8754 window as argument.
8755
a54e3482
DC
87562011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8757
8758 * fns.c (Fputhash): Document return value.
8759
60002bf5
CY
87602011-06-06 Chong Yidong <cyd@stupidchicken.com>
8761
8762 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8763
0c671da6 87642011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8765
b862a52a 8766 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8767
be44ca6c
PE
8768 Check for overflow when converting integer to cons and back.
8769 * charset.c (Fdefine_charset_internal, Fdecode_char):
8770 Use cons_to_unsigned to catch overflow.
8771 (Fencode_char): Use INTEGER_TO_CONS.
8772 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8773 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8774 * data.c (long_to_cons, cons_to_long): Remove.
8775 (cons_to_unsigned, cons_to_signed): New functions.
8776 These signal an error for invalid or out-of-range values.
8777 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8778 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8779 * font.c (Ffont_variation_glyphs):
8780 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8781 * lisp.h: Include <intprops.h>.
8782 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8783 (cons_to_signed, cons_to_unsigned): New decls.
8784 (long_to_cons, cons_to_long): Remove decls.
8785 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8786 (Fprimitive_undo): Use CONS_TO_INTEGER.
8787 * xfns.c (Fx_window_property): Likewise.
8788 * xselect.c: Include <limits.h>.
8789 (x_own_selection, selection_data_to_lisp_data):
8790 Use INTEGER_TO_CONS.
8791 (x_handle_selection_request, x_handle_selection_clear)
8792 (x_get_foreign_selection, Fx_disown_selection_internal)
8793 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8794 (lisp_data_to_selection_data): Use cons_to_unsigned.
8795 (x_fill_property_data): Use cons_to_signed.
8796 Report values out of range.
8797
d1f3d2af
PE
8798 Check for buffer and string overflow more precisely.
8799 * buffer.h (BUF_BYTES_MAX): New macro.
8800 * lisp.h (STRING_BYTES_MAX): New macro.
8801 * alloc.c (Fmake_string):
8802 * character.c (string_escape_byte8):
8803 * coding.c (coding_alloc_by_realloc):
8804 * doprnt.c (doprnt):
8805 * editfns.c (Fformat):
8806 * eval.c (verror):
8807 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8808 since they may not be the same number.
8809 * editfns.c (Finsert_char):
8810 * fileio.c (Finsert_file_contents):
8811 Likewise for BUF_BYTES_MAX.
8812
dd52fcea
PE
8813 * image.c: Use ptrdiff_t, not int, for sizes.
8814 (slurp_file): Switch from int to ptrdiff_t.
8815 All uses changed.
8816 (slurp_file): Check that file size fits in both size_t (for
8817 malloc) and ptrdiff_t (for sanity and safety).
8818
7f9bbdbb
PE
8819 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8820 if b->modtime has its maximal value.
8821
dfe18f82
PE
8822 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8823
84acfcf0
PE
8824 Don't assume time_t can fit into int.
8825 * buffer.h (struct buffer.modtime): Now time_t, not int.
8826 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8827 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8828
ccd9a01a
PE
8829 Minor fixes for signed vs unsigned integers.
8830 * character.h (MAYBE_UNIFY_CHAR):
8831 * charset.c (maybe_unify_char):
8832 * keyboard.c (read_char, reorder_modifiers):
8833 XINT -> XFASTINT, since the integer must be nonnegative.
8834 * ftfont.c (ftfont_spec_pattern):
8835 * keymap.c (access_keymap, silly_event_symbol_error):
8836 XUINT -> XFASTINT, since the integer must be nonnegative.
8837 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8838 since it makes no difference and we prefer signed.
8839 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8840 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8841 nonnegative.
8842
d6d100dd
SM
88432011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8844
8845 * window.h (Fwindow_frame): Declare.
8846
2b6148e4
PE
88472011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8848
8849 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8850 (SPARE_MEMORY): Always define.
8851 (LARGE_REQUEST): Remove.
8852 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8853
f230ecc9
MR
88542011-06-06 Martin Rudalics <rudalics@gmx.at>
8855
727e958e
MR
8856 * lisp.h: Move EXFUNS for Fframe_root_window,
8857 Fframe_first_window and Fset_frame_selected_window to window.h.
8858
8859 * window.h: Move EXFUNS for Fframe_root_window,
8860 Fframe_first_window and Fset_frame_selected_window here from
8861 lisp.h.
8862
8863 * frame.c (Fwindow_frame, Fframe_first_window)
8864 (Fframe_root_window, Fframe_selected_window)
8865 (Fset_frame_selected_window): Move to window.c.
8866 (Factive_minibuffer_window): Move to minibuf.c.
8867 (Fother_visible_frames_p): New function.
8868
8869 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8870
f230ecc9
MR
8871 * window.c (decode_window, decode_any_window): Move up in code.
8872 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8873 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8874 (Fwindow_buffer): Move up and rewrite doc-string.
8875 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8876 (Fwindow_prev): New functions.
727e958e
MR
8877 (Fwindow_frame): Move here from frame.c. Accept any window as
8878 argument.
8879 (Fframe_root_window, Fframe_first_window)
8880 (Fframe_selected_window): Move here from frame.c. Accept frame
8881 or arbitrary window as argument. Update doc-strings.
8882 (Fminibuffer_window): Move up in code.
8883 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8884 (Fset_frame_selected_window): Move here from frame.c.
8885 Marginal rewrite.
727e958e
MR
8886 (Fselected_window, select_window, Fselect_window): Move up in
8887 code. Minor doc-string fixes.
f230ecc9 8888
4d09bcf6
PE
88892011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8890
8891 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8892 Do not assume that spare memory exists; that assumption is valid
8893 only if SYSTEM_MALLOC.
8894 (LARGE_REQUEST): New macro, so that the issue of large requests
8895 is separated from the issue of spare memory.
8896
810928a2
AS
88972011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8898
172418ad
AS
8899 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8900 format. (Bug#8806)
8901
43f862f7
AS
8902 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8903
810928a2
AS
8904 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8905 before statements.
8906
a059fe24
JD
89072011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8908
8909 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8910
8911 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8912
8913 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8914 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8915
989bf368
JB
89162011-06-05 Juanma Barranquero <lekktu@gmail.com>
8917
8918 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8919
4b80f674
CY
89202011-06-04 Chong Yidong <cyd@stupidchicken.com>
8921
8922 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8923 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8924 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8925 New error handlers.
4b80f674
CY
8926 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8927 Obey Vx_select_enable_clipboard_manager. Catch errors in
8928 x_clipboard_manager_save (Bug#8779).
8929 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8930 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8931
99a33b77 89322011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8933
8934 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8935
99a33b77 89362011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8937
8938 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8939 in the current matrix if keep_current_p is non-zero.
8940
8264569d
EZ
89412011-06-04 Eli Zaretskii <eliz@gnu.org>
8942
8943 * bidi.c (bidi_level_of_next_char): Fix last change.
8944
57f97249
EZ
89452011-06-03 Eli Zaretskii <eliz@gnu.org>
8946
fec2107c 8947 Support bidi reordering of text covered by display properties.
57f97249 8948
fec2107c
EZ
8949 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8950 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8951 (bidi_cache_search, bidi_cache_iterator_state)
8952 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8953 (bidi_level_of_next_char, bidi_move_to_visually_next):
8954 Support character positions inside a run of characters covered by a
fec2107c
EZ
8955 display string.
8956 (bidi_paragraph_init, bidi_resolve_explicit_1)
8957 (bidi_level_of_next_char): Call bidi_fetch_char and
8958 bidi_fetch_char_advance instead of FETCH_CHAR and
8959 FETCH_CHAR_ADVANCE.
8960 (bidi_init_it): Initialize new members.
8961 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8962 definitions.
8963 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8964 instead of using explicit *_CHAR codes.
d6d100dd
SM
8965 (bidi_resolve_explicit, bidi_resolve_weak):
8966 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8967 bidirectional text is supported only in multibyte buffers.
8968 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8969 it to initialize the frame_window_p member of struct bidi_it.
8970 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8971 (bidi_resolve_explicit, bidi_resolve_weak)
8972 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8973 bidi_it->nchars is non-positive.
8974 (bidi_level_of_next_char): Don't try to lookup the cache for the
8975 next/previous character if nothing is cached there yet, or if we
8976 were just reseat()'ed to a new position.
c40e2fb2 8977
0e14fe90
EZ
8978 * xdisp.c (set_cursor_from_row): Set start and stop points
8979 according to the row's direction when priming the loop that looks
8980 for the glyph on which to display cursor.
8981 (single_display_spec_intangible_p): Function deleted.
8982 (display_prop_intangible_p): Reimplement to call
8983 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8984 Accept 3 additional arguments needed by handle_display_spec.
8985 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8986 values: lists, `(when COND...)' forms, etc.
8987 (single_display_spec_string_p): Support property values that are
8988 lists with the argument STRING its top-level element.
8989 (display_prop_string_p): Fix the condition for processing a
8990 property that is a list to be consistent with handle_display_spec.
fec2107c 8991 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8992 last portion of handle_display_prop.
8993 (compute_display_string_pos): Accept additional argument
8994 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8995 value of a `display' property is a "replacing spec".
8996 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8997 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8998 the display property, but just return a value indicating whether
8999 the display property will replace the characters it covers.
9000 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9001 frame_window_p members of struct bidi_it.
d6d100dd
SM
9002 (compute_display_string_pos, compute_display_string_end):
9003 New functions.
fec2107c
EZ
9004 (push_it): Accept second argument POSITION, where pop_it should
9005 jump to continue iteration.
9006 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9007
fec2107c
EZ
9008 * keyboard.c (adjust_point_for_property): Adjust the call to
9009 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9010
9011 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9012 (bidi_init_it): Update prototypes.
9013 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9014 (compute_display_string_pos, compute_display_string_end):
9015 Declare prototypes.
fec2107c
EZ
9016 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9017 EMACS_INT.
fc6f18ce 9018
40087514 90192011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9020
57f53182
PE
9021 Malloc failure behavior now depends on size of allocation.
9022 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9023 * lisp.h: Change signatures accordingly.
9024 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9025 All callers changed. (Bug#8762)
9026
9027 * gnutls.c: Use Emacs's memory allocators.
9028 Without this change, the gnutls library would invoke malloc etc.
9029 directly, which causes problems on non-SYNC_INPUT hosts, and which
9030 runs afoul of improving memory_full behavior. (Bug#8761)
9031 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9032 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9033 xfree instead of the default malloc, realloc, free.
9034 (Fgnutls_boot): No need to check for memory allocation failure,
9035 since xmalloc does that for us.
9036
ac32cd99 9037 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9038 * category.c (hash_get_category_set):
9039 * ccl.c (ccl_driver):
9040 * charset.c (Fdefine_charset_internal):
9041 * charset.h (struct charset.hash_index):
9042 * composite.c (get_composition_id, gstring_lookup_cache)
9043 (composition_gstring_put_cache):
9044 * composite.h (struct composition.hash_index):
9045 * dispextern.h (struct image.hash):
9046 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9047 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9048 (hashfn_equal, hashfn_user_defined, make_hash_table)
9049 (maybe_resize_hash_table, hash_lookup, hash_put)
9050 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9051 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9052 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9053 * image.c (make_image, search_image_cache, lookup_image)
9054 (xpm_put_color_table_h):
9055 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9056 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9057 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9058 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9059 * alloc.c (allocate_vectorlike):
9060 Check for overflow in vector size calculations.
9061 * ccl.c (ccl_driver):
9062 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9063 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9064 need to be updated by these changes.
40087514
PE
9065 * fns.c (make_hash_table, maybe_resize_hash_table):
9066 Check for integer overflow with large hash tables.
0de4bb68
PE
9067 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9068 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9069 (SXHASH_REDUCE): New macro.
9070 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9071 Use it instead of discarding useful hash info with large hash values.
9072 (sxhash_float): New function.
9073 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9074 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9075 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9076 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9077 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9078 Adjust signatures to match updated version of code.
9079 (consing_since_gc): Now EMACS_INT, since a single hash table can
9080 use more than INT_MAX bytes.
9081
698d32e2
DN
90822011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9083
9084 Make it possible to build with GCC-4.6+ -O2 -flto.
9085
9086 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9087
fd6fa53f
SM
90882011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9089
9090 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9091 Call minibuffer-inactive-mode.
9092
864db017
JB
90932011-05-31 Juanma Barranquero <lekktu@gmail.com>
9094
9095 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9096 Update dependencies.
9097
2ad0baf4
DN
90982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9099
9100 * data.c (init_data): Remove code for UTS, this system is not
9101 supported anymore.
9102
4fcc2638
DN
91032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9104
9105 Don't force ./temacs to start in terminal mode.
9106
9107 * frame.c (make_initial_frame): Initialize faces in all cases, not
9108 only when CANNOT_DUMP is defined.
9109 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9110
c56e0fd5
DN
91112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9112
9113 * dispnew.c (add_window_display_history): Use const for the string
9114 pointer. Remove declaration, not needed.
9115
333d54da 91162011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9117
55d4c1b2 9118 Use 'inline', not 'INLINE'.
333d54da 9119 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9120 * alloc.c, fontset.c (INLINE): Remove.
9121 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9122 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9123 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9124 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9125 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9126
738db178
DN
91272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9128
9129 Make it possible to run ./temacs.
9130
9131 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9132 syms_of_callproc does the same thing. Remove test for
9133 "initialized", do it in the caller.
9134 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9135
620c53a6
SM
91362011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9137
9138 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9139 (read_minibuf): Use get_minibuffer.
9140 (syms_of_minibuf): Use DEFSYM.
9141 (Qmetadata): New var.
9142 * data.c (Qbuffer): Don't make it static.
9143 (syms_of_data): Use DEFSYM.
9144
e003a292
PE
91452011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9146
9147 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9148 (CCL_CODE_MIN): New macro.
9149
ed008a6d
PE
91502011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9151
3687c2ef
PE
9152 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9153
ed008a6d
PE
9154 * eval.c (Qdebug): Now static.
9155 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9156 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9157 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9158
d66c4c7c
CY
91592011-05-29 Chong Yidong <cyd@stupidchicken.com>
9160
9161 * image.c: Various fixes to ImageMagick code comments.
9162 (Fimagemagick_types): Doc fix.
9163
5fbc2025
PE
91642011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9165
0196f88a
PE
9166 Minor fixes prompted by GCC 4.6.0 warnings.
9167
9168 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9169
5fbc2025
PE
9170 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9171 (x_clipboard_manager_save_all): Move extern decl to ...
9172 * xterm.h: ... here, so that it can be checked for consistency.
9173
1dd3c2d9
CY
91742011-05-29 Chong Yidong <cyd@stupidchicken.com>
9175
9176 * xselect.c (x_clipboard_manager_save_frame)
9177 (x_clipboard_manager_save_all): New functions.
9178 (Fx_clipboard_manager_save): Lisp function deleted.
9179
9180 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9181 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9182
9183 * xterm.h: Update prototype.
9184
5ba6571d
WX
91852011-05-28 William Xu <william.xwl@gmail.com>
9186
9187 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9188 exiting (Bug#8239).
9189
3eaff834
JM
91902011-05-28 Jim Meyering <meyering@redhat.com>
9191
e1900994 9192 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9193 * fns.c (to_uchar): Define.
9194 (crypto_hash_function): Use it to convert some newly-signed
9195 variables to unsigned, to avoid sign-extension bugs. For example,
9196 without this change, (md5 "truc") would evaluate to
9197 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9198 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9199 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9200
0f6990a7
PE
92012011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9202
9203 Integer overflow fixes.
c8a9ca5a 9204
08686060
PE
9205 * dbusbind.c: Serial number integer overflow fixes.
9206 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9207 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9208 to hold a serial number that is too large for a fixnum.
9209 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9210 Check for serial numbers out of range. Decode any serial number
59568bf0 9211 that was so large that it became a float. (Bug#8722)
08686060 9212
2d1fc3c7
PE
9213 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9214 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9215 Use XFASTINT rather than XUINT when numbers are nonnegative.
9216 (xd_append_arg, Fdbus_method_return_internal):
9217 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9218 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9219 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9220 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9221 (Bug#8722)
2d1fc3c7 9222
c8a9ca5a
PE
9223 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9224
519e1d69
PE
9225 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9226
6df6ae42 9227 ccl: Add integer overflow checks.
30569699
PE
9228 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9229 (IN_INT_RANGE): New macros.
9230 (ccl_driver): Use them to check for integer overflow when
9231 decoding a CCL program. Many of the new checks are whether XINT (x)
9232 fits in int; it doesn't always, on 64-bit hosts. The new version
9233 doesn't catch all possible integer overflows, but it's an
847044ea 9234 improvement. (Bug#8719)
30569699 9235
c11285dc
PE
9236 * alloc.c (make_event_array): Use XINT, not XUINT.
9237 There's no need for unsigned here.
9238
fdccd48e
PE
9239 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9240 This follows up to the 2011-05-06 change that substituted uintptr_t
9241 for EMACS_INT. This case wasn't caught back then.
9242
37910ab2
PE
9243 Rework Fformat to avoid integer overflow issues.
9244 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9245 now (part of C89). Include <verify.h>.
9246 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9247 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9248 (Fformat): Avoid the prepass trying to compute sizes; it was only
9249 approximate and thus did not catch overflow reliably. Instead, walk
9250 through the format just once, formatting and computing sizes as we go,
9251 checking for integer overflow at every step, and allocating a larger
9252 buffer as needed. Keep track separately whether the format is
9253 multibyte. Keep only the most-recently calculated precision, rather
9254 than them all. Record whether each argument has been converted to
9255 string. Use EMACS_INT, not int, for byte and char and arg counts.
9256 Support field widths and precisions larger than INT_MAX. Avoid
9257 sprintf's undefined behavior with conversion specifications such as %#d
9258 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9259 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9260 formatting out-of-range floating point numbers with int
9173deec 9261 formats. (Bug#8668)
37910ab2 9262
2e6578fb
PE
9263 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9264
0ae6bdee
PE
9265 * data.c: Avoid integer truncation in expressions involving floats.
9266 * data.c: Include <intprops.h>.
9267 (arith_driver): When there's an integer overflow in an expression
9268 involving floating point, convert the integers to floating point
9269 so that the resulting value does not suffer from catastrophic
9270 integer truncation. For example, on a 64-bit host (* 4
9271 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9272 Do not rely on undefined behavior after integer overflow.
9273
de883a70
PE
9274 merge count_size_as_multibyte, parse_str_to_multibyte
9275 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9276 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9277 Check for integer overflow.
9278 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9279 since it's now a duplicate of the other. This is more of
9280 a character than a buffer op, so better that it's in character.c.
9281 * fns.c, print.c: Adjust to above changes.
9282
2ff916cb
PE
92832011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9284
9285 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9286
f1b54466
PE
92872011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9288
fb1ac845
PE
9289 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9290 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9291 (x_clipboard_manager_save): Now static.
9292 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9293
f1b54466
PE
9294 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9295 (crypto_hash_function): Now static.
9296 Fix pointer signedness problems. Avoid unnecessary initializations.
9297
a9f737ee
CY
92982011-05-27 Chong Yidong <cyd@stupidchicken.com>
9299
9300 * termhooks.h (Vselection_alist): Make it terminal-local.
9301
9302 * terminal.c (create_terminal): Initialize it.
9303
9304 * xselect.c: Support for clipboard managers.
9305 (Vselection_alist): Move to termhooks.h as terminal-local var.
9306 (LOCAL_SELECTION): New macro.
9307 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9308 (symbol_to_x_atom): Remove gratuitous arg.
9309 (x_handle_selection_request, lisp_data_to_selection_data)
9310 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9311 (x_own_selection, x_get_local_selection, x_convert_selection):
9312 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9313 (some_frame_on_display): Delete unused function.
9314 (Fx_own_selection_internal, Fx_get_selection_internal)
9315 (Fx_disown_selection_internal, Fx_selection_owner_p)
9316 (Fx_selection_exists_p): New optional frame arg.
9317 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9318 (x_handle_selection_clear): Don't treat other terminals with the
9319 same keyboard specially. Use the terminal-local Vselection_alist.
9320 (x_clear_frame_selections): Use Frun_hook_with_args.
9321
9322 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9323
9324 * xterm.h: Add support for those atoms.
9325
e067f0c1
CY
93262011-05-26 Chong Yidong <cyd@stupidchicken.com>
9327
9328 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9329 (converted_selections, conversion_fail_tag): New global variables.
9330 (x_selection_request_lisp_error): Free the above.
9331 (x_get_local_selection): Remove unnecessary code.
9332 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9333 of converted selections stored in converted_selections.
9334 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9335 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9336 (x_convert_selection): New function.
9337 (x_handle_selection_event): Simplify.
9338 (x_get_foreign_selection): Don't ignore incoming requests while
9339 waiting for an answer; this will fail when we implement
9340 SAVE_TARGETS, and seems unnecessary anyway.
9341 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9342 (Vx_sent_selection_functions): Doc fix.
9343
0f4aebc0
LL
93442011-05-26 Leo Liu <sdl.web@gmail.com>
9345
9346 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9347
e61124cd
YM
93482011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9349
9350 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9351
9352 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9353 for fringe update if it has periodic bitmap.
ac389d0c 9354 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9355 and fringe_bitmap_periodic_p.
9356
9357 * fringe.c (get_fringe_bitmap_data): New function.
9358 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9359 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9360 row. Mark glyph row for fringe update if periodicity changed.
9361
9362 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9363 for fringe update unless it has periodic bitmap.
9364
f16d9837
KH
93652011-05-25 Kenichi Handa <handa@m17n.org>
9366
9367 * xdisp.c (get_next_display_element): Set correct it->face_id for
9368 a static composition.
9369
e1b90ef6
LL
93702011-05-24 Leo Liu <sdl.web@gmail.com>
9371
9372 * deps.mk (fns.o):
9373 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9374
9375 * fns.c (crypto_hash_function, Fsha1): New function.
9376 (Fmd5): Use crypto_hash_function.
9377 (syms_of_fns): Add Ssha1.
9378
7400048f
PE
93792011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9380
9381 * gnutls.c: Remove unused macros.
9382 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9383 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9384 Remove macros that are defined and never used.
9385 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9386
abb71cf4
CY
93872011-05-22 Chong Yidong <cyd@stupidchicken.com>
9388
9389 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9390 (Fx_get_selection_internal): Minor cleanup.
9391 (Fx_own_selection_internal): Rename arguments for consistency with
9392 select.el.
9393
6307db39
PE
93942011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9395
9396 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9397
f3d4e0a4
CY
93982011-05-22 Chong Yidong <cyd@stupidchicken.com>
9399
9400 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9401
4d8ade89
YM
94022011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9403
9404 * dispnew.c (scrolling_window): Don't exclude the case that the
9405 last enabled row in the desired matrix touches the bottom boundary.
9406
32078c8d
GM
94072011-05-21 Glenn Morris <rgm@gnu.org>
9408
9409 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9410 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9411 and add some more files.
32078c8d 9412
7285dc67
EZ
94132011-05-20 Eli Zaretskii <eliz@gnu.org>
9414
9415 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9416 report_file_error introduced by the change from 2011-05-07.
9417
89d1bd22
PE
94182011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9419
9420 * systime.h (Time): Define only if emacs is defined.
9421 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9422 where the include path doesn't have X11/X.h by default. See
9423 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9424
cd394be1 94252011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9426
9427 * composite.c (find_automatic_composition): Fix previous change.
9428
b9704ad9
GM
94292011-05-20 Glenn Morris <rgm@gnu.org>
9430
9431 * lisp.mk: New file, split from Makefile.in.
9432 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9433 (shortlisp): Remove.
9434 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9435
4a720484
GM
94362011-05-19 Glenn Morris <rgm@gnu.org>
9437
9438 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9439 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9440 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9441 (lisp): Set the order to that of loadup.el.
9442 (shortlisp): Make it a copy of $lisp.
9443 (SOME_MACHINE_LISP): Remove.
9444 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9445 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9446
a28d4396
KH
94472011-05-18 Kenichi Handa <handa@m17n.org>
9448
9449 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9450 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9451 (find_automatic_composition): Mostly rewrite for efficiency.
9452
a2b1fa8e
JB
94532011-05-18 Juanma Barranquero <lekktu@gmail.com>
9454
9455 * makefile.w32-in: Update dependencies.
9456
8e1f5610
CS
94572011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9458
9459 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9460 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9461
7025ee00 94622011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9463
cdfa6eab
PE
9464 Fix some integer overflow issues, such as string length overflow.
9465
06d6db33
PE
9466 * insdel.c (count_size_as_multibyte): Check for string overflow.
9467
2b4560a8
PE
9468 * character.c (lisp_string_width): Check for string overflow.
9469 Use EMACS_INT, not int, for string indexes and lengths; in
9470 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9471 the resulting string length overflows an EMACS_INT; instead,
9472 report a string overflow if no precision given. When checking for
9473 precision exhaustion, use a check that cannot possibly have
9474 integer overflow. (Bug#8675)
9475 * character.h (lisp_string_width): Adjust to new signature.
9476
cb93f9be
PE
9477 * alloc.c (string_overflow): New function.
9478 (Fmake_string): Use it. This doesn't change behavior, but saves
9479 a few bytes and will simplify future changes.
9480 * character.c (string_escape_byte8): Likewise.
9481 * lisp.h (string_overflow): New decl.
9482
1a1f3366
PE
9483 Fixups, following up to the user-interface timestamp change.
9484 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9485 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9486 * msdos.c (mouse_get_pos): Likewise.
9487 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9488 * w32gui.h (Time): Define by including "systime.h" rather than by
9489 declaring it ourselves. (Bug#8664)
9490
d4e3e4d3
PE
9491 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9492 * image.c (clear_image_cache): Likewise.
9493
f6a24d19
PE
9494 * term.c (term_mouse_position): Don't assume time_t wraparound.
9495
08dc5ae6
PE
9496 Be more systematic about user-interface timestamps.
9497 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9498 and sometimes 'EMACS_UINT', to represent these timestamps.
9499 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9500 This makes the code easier to follow, and makes it easier to catch
9501 integer overflow bugs such as Bug#8664.
9502 * frame.c (Fmouse_position, Fmouse_pixel_position):
9503 Use Time, not unsigned long, for user-interface timestamps.
9504 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9505 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9506 * keyboard.h (last_event_timestamp): Likewise.
9507 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9508 * menu.h (xmenu_show): Likewise.
9509 * term.c (term_mouse_position): Likewise.
9510 * termhooks.h (struct input_event.timestamp): Likewise.
9511 (struct terminal.mouse_position_hook): Likewise.
9512 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9513 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9514 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9515 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9516 what it was before.
9517 * menu.h, termhooks.h: Include "systime.h", for Time.
9518
8e55734a
PE
9519 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9520 Don't assume that the difference between two unsigned long values
9521 can fit into an integer. At this point, we know button_down_time
9522 <= event->timestamp, so the difference must be nonnegative, so
9523 there's no need to cast the result if double-click-time is
9524 nonnegative, as it should be; check that it's nonnegative, just in
9525 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9526 apart (about 25 days). (Bug#8664)
8e55734a 9527
841f1b75 9528 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9529 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9530
3e26f69c
PE
9531 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9532 that always fit in int. Use a sentinel instead of a counter, to
9533 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9534 * frame.h (struct frame): Use int for menu_bar_items_used
9535 instead of EMACS_INT, since it always fits in int.
3e26f69c 9536
5cc152c0
PE
9537 * menu.c (grow_menu_items): Check for int overflow.
9538
d89eb65e
PE
9539 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9540
5235bd3e
PE
9541 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9542 Before, the code was not consistent. These values cannot exceed
9543 2**31 - 1 so there's no need to make them unsigned.
9544 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9545 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9546 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9547 as modifiers.
9548 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9549
bc827e23
PE
9550 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9551 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9552 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9553 presumably because the widths might not match.
9554
78eb494e
PE
9555 * window.c (size_window): Avoid needless test at loop start.
9556
04f2d78b
CB
95572011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9558
9559 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9560
d2fc7e3d 95612011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9562
9563 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9564
d2fc7e3d 95652011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9566
9567 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9568 `width' to `bar_area_x' and `bar_area_width', respectively.
9569 (x_scroll_run): Take account of fringe background extension.
9570
04f2d78b
CB
9571 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9572 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9573 `bar_area_width', respectively.
9574 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9575 background extension.
9576
79b70037
GM
95772011-05-10 Jim Meyering <meyering@redhat.com>
9578
9579 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9580
2f142cc5
JB
95812011-05-10 Juanma Barranquero <lekktu@gmail.com>
9582
9583 * image.c (Finit_image_library): Return t for built-in image types,
9584 like pbm and xbm. (Bug#8640)
9585
57679c86
AS
95862011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9587
9588 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9589
888c9e86
EZ
95902011-05-07 Eli Zaretskii <eliz@gnu.org>
9591
b0512a1d
EZ
9592 * w32console.c (Fset_screen_color): Doc fix.
9593 (Fget_screen_color): New function.
9594 (syms_of_ntterm): Defsubr it.
9595
7285dc67
EZ
9596 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9597 unlink the temporary file if Fcall_process didn't create it in the
9598 first place.
9599 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9600 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9601 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9602 cue to call_process_cleanup not to close that handle.
9603
4d3fcc8e
BK
96042011-05-07 Ben Key <bkey76@gmail.com>
9605
9606 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9607 one of two shell specific rules, either bootstrap-temacs-CMD or
9608 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9609 to the previous implementation of the bootstrap-temacs rule.
9610 The bootstrap-temacs-CMD rule is similar to the previous
9611 implementation of the bootstrap-temacs rule except that it
9612 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9613 variable.
9614
9615 These changes, along with some changes to nt/configure.bat,
9616 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9617 earlier fix to add support for --cflags and --ldflags options
9618 that include quotes so that it works whether make uses cmd or
9619 sh as the shell.
9620
b4289b64
MA
96212011-05-06 Michael Albinus <michael.albinus@gmx.de>
9622
9623 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9624 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9625 is a constant.
9626 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9627 a string. Handle both cases.
9628 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9629 (Fdbus_register_method): Use Qinvalid_function.
9630
af4c0e28
JB
96312011-05-06 Juanma Barranquero <lekktu@gmail.com>
9632
9633 * makefile.w32-in: Update dependencies.
9634 (LISP_H): Add inttypes.h and stdin.h.
9635 (PROCESS_H): Add unistd.h.
9636
c51453d9
EZ
96372011-05-06 Eli Zaretskii <eliz@gnu.org>
9638
9639 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9640 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9641
8ff0ac3c 96422011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9643
4c4b566b
PE
9644 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9645
aab2b9b5
PE
9646 * term.c (vfatal): Remove stray call to va_end.
9647 It's not needed and the C Standard doesn't allow it here anyway.
9648
c378da0b
PE
9649 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9650 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9651
288b08c7
PE
9652 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9653 bytes.
9654
e3601888
PE
9655 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9656
db6c0e74
PE
9657 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9658
dd5963ea
PE
9659 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9660
88c9450f
PE
9661 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9662
2f9442b8
PE
9663 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9664
c032b5f8
PE
9665 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9666 * charset.c (Fdefine_charset_internal): Don't initialize
9667 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9668 32-bit int (Bug#8600).
a108c10b
PE
9669
9670 * lread.c (read_integer): Be more consistent with string-to-number.
9671 Use string_to_number to do the actual conversion; this avoids
9672 rounding errors and fixes some other screwups. Without this fix,
9673 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9674 (digit_to_number): Move earlier, for benefit of read_integer.
9675 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9676 not a digit in any supported base. (Bug#8602)
a108c10b 9677
ad5f9eea
PE
9678 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9679
aec1708a
PE
9680 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9681 to match comment at start of function. This also removes a
9682 GCC warning about overflow in a 32+64-bit port.
9683
47be4ab5
PE
9684 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9685
371cac43
PE
9686 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9687 Reported by Stefan Monnier in
9688 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9689 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9690 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9691
d01a7826
PE
9692 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9693 (EMACS_UINTPTR): Likewise, with uintptr_t.
9694
7fd47d5c
PE
9695 * lisp.h: Prefer 64-bit EMACS_INT if available.
9696 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9697 on 32-bit hosts that have 64-bit int, so that they can access
9698 large files.
122b0c86
PE
9699 However, temporarily disable this change unless the temporary
9700 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9701
8727937b
PE
9702 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9703
8ac068ac
PE
9704 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9705 This removes an assumption that EMACS_INT and long are the same
9706 width as pointers. The assumption is true for Emacs porting targets
9707 now, but we want to make other targets possible.
9708 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9709 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9710 In the rest of the code, change types of integers that hold casted
9711 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9712 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9713 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9714 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9715 No need to cast type when ORing.
9716 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9717 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9718 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9719 assume EMACS_INT is the same width as char *.
9720 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9721 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9722 Remove no-longer-needed casts.
9723 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9724 (xg_tool_bar_help_callback, xg_make_tool_item):
9725 Use EMACS_INTPTR to hold an integer
9726 that will be cast to void *; this can avoid a GCC warning
9727 if EMACS_INT is not the same width as void *.
9728 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9729 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9730 (current_message_1, set_message_1):
9731 Use a local to convert to proper width without a cast.
9732 * xmenu.c (dialog_selection_callback): Likewise.
9733
ede49d71
PE
9734 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9735 Also, don't assume VALBITS / RAND_BITS is less than 5,
9736 and don't rely on undefined behavior when shifting a 1 left into
9737 the sign bit.
9738 * lisp.h (get_random): Change signature to match.
9739
2f30ecd0
PE
9740 * lread.c (hash_string): Use size_t, not int, for hash computation.
9741 Normally we prefer signed values; but hashing is special, because
9742 it's better to use unsigned division on hash table sizes so that
9743 the remainder is nonnegative. Also, size_t is the natural width
9744 for hashing into memory. The previous code used 'int', which doesn't
9745 retain enough info to hash well into very large tables.
9746 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9747
2a866e7b
PE
9748 * dbusbind.c: Don't possibly lose pointer info when converting.
9749 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9750 Use XPNTR rather than XHASH, so that the high-order bits of
9751 the pointer aren't lost when converting through void *.
9752
51639eac
PE
9753 * eval.c (Fautoload): Don't double-shift a pointer.
9754
92394119
PE
9755 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9756
dbdb9a7c
JB
97572011-05-06 Juanma Barranquero <lekktu@gmail.com>
9758
9759 * gnutls.c (DEF_GNUTLS_FN):
9760 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9761
db7a0b4f
AS
97622011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9763
9764 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9765 marker. (Bug#8610)
9766
cd394be1 97672011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9768
9769 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9770 New version that can reserve upto 2GB of heap space.
9771
f7ff1b0f 97722011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9773
9774 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9775
639c109b
TZ
97762011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9777
9778 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9779 `gnutls_certificate_set_x509_key_file'.
9780
d2127135
JB
97812011-05-05 Juanma Barranquero <lekktu@gmail.com>
9782
9783 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9784 Update dependencies.
9785
e968f4f3
JB
97862011-05-04 Juanma Barranquero <lekktu@gmail.com>
9787
9788 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9789 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9790 Remove unused parameter `fildes'.
9791 * process.c (read_process_output, send_process): Don't pass it.
9792
84d358f0
JB
97932011-05-04 Juanma Barranquero <lekktu@gmail.com>
9794
9795 Fix previous change: the library cache is defined in w32.c.
9796 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9797 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9798
0898ca10
JB
97992011-05-04 Juanma Barranquero <lekktu@gmail.com>
9800
9801 Implement dynamic loading of GnuTLS on Windows.
9802
9803 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9804 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9805 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9806 Declare.
9807
9808 * gnutls.c (Qgnutls_dll): Define.
9809 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9810 (gnutls_*): Declare function pointers.
9811 (init_gnutls_functions): New function to initialize function pointers.
9812 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9813 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9814 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9815 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9816 (emacs_gnutls_write, emacs_gnutls_read)
9817 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9818 (Fgnutls_available_p): New function.
9819 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9820 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9821 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9822
9823 * image.c: Include w32.h.
9824 (Vimage_type_cache): Delete.
9825 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9826 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9827 (w32_delayed_load): Move to w32.c.
9828
9829 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9830
9831 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9832 (w32_delayed_load): Move from image.c. When loading a library, record
9833 its filename in the :loaded-from property of the library id.
9834 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9835 Initialize and staticpro them.
9836 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9837
9838 * process.c: Include lisp.h before w32.h, not after.
9839 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9840 instead of gnutls_record_check_pending.
9841
9842 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9843
ff4de4aa
TZ
98442011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9845
9846 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9847 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9848 as passed in.
9849
abe95abb
JD
98502011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9851
9852 * xterm.c (x_set_frame_alpha): Do not set property on anything
9853 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9854
e16e55d4
JB
98552011-05-02 Juanma Barranquero <lekktu@gmail.com>
9856
9857 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9858
bafcf6a5
JB
98592011-05-02 Juanma Barranquero <lekktu@gmail.com>
9860
9861 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9862 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9863 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9864 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9865 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9866 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9867 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9868 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9869 (Qgnutls_bootprop_callbacks_verify): Make static.
9870
e7a6747f
AS
98712011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9872
19ed11ba
AS
9873 * callproc.c: Indentation fixup.
9874
e7a6747f 9875 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9876 (wait_for_termination, interruptible_wait_for_termination):
9877 Move after wait_for_termination_1.
e7a6747f 9878
1ef14cb4
LMI
98792011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9880
9881 * sysdep.c (interruptible_wait_for_termination): New function
9882 which is like wait_for_termination, but allows keyboard
9883 interruptions.
9884
9885 * callproc.c (Fcall_process): Add (:file "file") as an option for
9886 the STDOUT buffer.
9887 (Fcall_process_region): Ditto.
9888
330d880c
EZ
98892011-04-30 Eli Zaretskii <eliz@gnu.org>
9890
8db90b73
EZ
9891 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9892 rather than `XVECTOR (FOO)->size'.
9893
330d880c
EZ
9894 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9895 inttypes.h, as a gnulib replacement is used if it not available in
9896 system headers.
9897
15cbd324
EZ
98982011-04-21 Eli Zaretskii <eliz@gnu.org>
9899
9900 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9901 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9902 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9903
9904 * coding.c (coding_alloc_by_realloc): Error out if destination
9905 will grow beyond MOST_POSITIVE_FIXNUM.
9906 (decode_coding_emacs_mule): Abort if there isn't enough place in
9907 charbuf for the composition carryover bytes. Reserve an extra
9908 space for up to 2 characters produced in a loop.
9909 (decode_coding_iso_2022): Abort if there isn't enough place in
9910 charbuf for the composition carryover bytes.
9911
99122011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9913
ae940cca
EZ
9914 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9915 aborting when %lld or %lll format is passed.
9916 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9917 %llo or %llx format is passed. (Bug#8545)
9918
03ab8921
EZ
9919 * window.c (window_scroll_line_based): Use a marker instead of
9920 simple variables to record original value of point. (Bug#7952)
9921
afda1437
EZ
9922 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9923 produced by %s or %c overflows available buffer space. (Bug#8545)
9924
f76dee0c
PE
99252011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9926
9927 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9928 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9929
fdc5744d
JB
99302011-04-28 Juanma Barranquero <lekktu@gmail.com>
9931
9932 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9933
638f053a
JB
99342011-04-28 Juanma Barranquero <lekktu@gmail.com>
9935
9936 * keyboard.c (Qdelayed_warnings_hook): Define.
9937 (command_loop_1): Run `delayed-warnings-hook'
9938 if Vdelayed_warnings_list is non-nil.
9939 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9940 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9941
d178f871
EZ
99422011-04-28 Eli Zaretskii <eliz@gnu.org>
9943
9944 * doprnt.c (doprnt): Don't return value smaller than the buffer
9945 size if the message was truncated. (Bug#8545).
9946
b124fd93
JB
99472011-04-28 Juanma Barranquero <lekktu@gmail.com>
9948
9949 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9950 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9951
e810457d
PE
99522011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9953
9954 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9955
ea51cceb
JB
99562011-04-27 Juanma Barranquero <lekktu@gmail.com>
9957
9958 * makefile.w32-in: Update dependencies.
9959
94dcfacf
EZ
99602011-04-27 Eli Zaretskii <eliz@gnu.org>
9961
9962 Improve `doprnt' and its usage. (Bug#8545)
9963 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9964 `format_end'. Remove support for %l as a conversion specifier.
9965 Don't use xrealloc. Improve diagnostics when the %l size modifier
9966 is used. Update the commentary.
9967
9968 * eval.c (verror): Simplify calculation of size_t.
9969
9970 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9971 messages.
9972
f61f41d7
PE
99732011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9974
9975 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9976 change.
9977
96fb4434
PE
99782011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9979
9980 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9981 This makes this file independent of the recent pseudovector change.
9982
671875da 99832011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9984
69e9b5a3
PE
9985 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9986
b5f869a7 9987 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9988 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9989 Remove unused local.
c8926152 9990 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9991
841a1577 9992 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9993 GCC 4.6.0 optimizes based on type-based alias analysis.
9994 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9995 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9996 != &v->size, and therefore "v->size = 1; b->size = 2; return
9997 v->size;" must therefore return 1. This assumption is incorrect
9998 for Emacs, since it type-puns struct Lisp_Vector * with many other
9999 types. To fix this problem, this patch adds a new type struct
f904488f 10000 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10001 and pseudovectors, and helps optimizing compilers not get fooled
10002 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10003 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10004 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10005 the size member.
eab3844f
PE
10006 (XSETPVECTYPE): Rewrite in terms of new macro.
10007 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10008 This is a bit clearer, and further avoids the possibility of
10009 undesirable aliasing.
10010 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10011 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10012 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10013 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10014 (ASIZE): Now uses header.size rather than size.
10015 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10016 to avoid the hassle of writing XVECTOR (foo)->header.size.
10017 (struct vectorlike_header): New type.
eab3844f
PE
10018 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10019 object, to help avoid aliasing.
10020 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10021 (SUBRP): Likewise, since Lisp_Subr is a special case.
10022 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10023 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10024 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10025 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10026 changed to be "header.size" and "header.next".
10027 * buffer.h (struct buffer): Likewise.
10028 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10029 * frame.h (struct frame): Likewise.
10030 * process.h (struct Lisp_Process): Likewise.
10031 * termhooks.h (struct terminal): Likewise.
10032 * window.c (struct save_window_data, struct saved_window): Likewise.
10033 * window.h (struct window): Likewise.
10034 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10035 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10036 * buffer.c (init_buffer_once): Likewise.
10037 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10038 special case.
10039 * process.c (Fformat_network_address): Use local var for size,
10040 for brevity.
10041
0df1eac5
PE
10042 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10043
847ab9d1 10044 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10045 * data.c (atof): Remove decl; no longer used or needed.
10046 (digit_to_number): Move to lread.c.
10047 (Fstring_to_number): Use new string_to_number function, to be
10048 consistent with how the Lisp reader treats infinities and NaNs.
10049 Do not assume that floating-point numbers represent EMACS_INT
10050 without losing information; this is not true on most 64-bit hosts.
10051 Avoid double-rounding errors, by insisting on integers when
10052 parsing non-base-10 numbers, as the documentation specifies.
10053 * lisp.h (string_to_number): New decl, replacing ...
10054 (isfloat_string): Remove.
bc0a5c13 10055 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10056 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10057 appears to have been a coding error. Similarly, do not accept
10058 strings like +-1e0 as floating point numbers. Do not report
10059 overflow for integer overflows unless the base is not 10 which
10060 means we have no simple and reliable way to continue.
10061 Break out the floating-point parsing into a new
10062 function string_to_number, so that Fstring_to_number parses
10063 floating point numbers consistently with the Lisp reader.
04f2d78b 10064 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10065 (E_CHAR, EXP_INT): Remove, replacing with ...
10066 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10067 (string_to_number): New function, replacing isfloat_string.
10068 This function checks for valid syntax and produces the resulting
10069 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10070 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10071 so that overflow for non-base-10 numbers is reported only when
10072 there's no portable and simple way to convert to floating point.
452f4150 10073
67769ffc
PE
10074 * textprop.c (set_text_properties_1): Rewrite for clarity,
10075 and to avoid GCC warning about integer overflow.
10076
c20db43f
PE
10077 * intervals.h (struct interval): Use EMACS_INT for members
10078 where EMACS_UINT might cause problems. See
10079 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10080 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10081 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10082 All uses changed.
37aa2f85
PE
10083 (offset_intervals): Tell GCC not to worry about length overflow
10084 when negating a negative length.
c20db43f 10085
2538aa2f
PE
10086 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10087 (overrun_check_free): Likewise.
10088
f2d3008d
PE
10089 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10090 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10091 word size.
10092
ec8df744
PE
10093 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10094 (gnutls_make_error): Rename local to avoid shadowing.
10095 (gnutls_emacs_global_deinit): ifdef out; not used.
10096 (Fgnutls_boot): Use const for pointer to readonly storage.
10097 Comment out unused local. Fix pointer signedness problems.
10098
640ee02d
PE
10099 * lread.c (openp): Don't stuff size_t into an 'int'.
10100 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10101 about possible signed overflow.
10102
6048fb2a
PE
10103 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10104 (GDK_KEY_g): Don't define if already defined.
10105 (xg_prepare_tooltip): Avoid pointer signedness problem.
10106 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10107
fa3c87e1
PE
10108 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10109 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10110
2172544b
PE
10111 * xfns.c (Fx_window_property): Simplify a bit,
10112 to make a bit faster and to avoid GCC 4.6.0 warning.
10113 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10114
9b821a21
PE
10115 * fns.c (internal_equal): Don't assume size_t fits in int.
10116
3c616cfa
PE
10117 * alloc.c (compact_small_strings): Tighten assertion a little.
10118
c2982e87
PE
10119 Replace pEd with more-general pI, and fix some printf arg casts.
10120 * lisp.h (pI): New macro, generalizing old pEd macro to other
10121 conversion specifiers. For example, use "...%"pI"d..." rather
10122 than "...%"pEd"...".
10123 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10124 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10125 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10126 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10127 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10128 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10129 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10130 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10131 64-bit hosts.
10132 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10133 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10134 * print.c (safe_debug_print, print_object): Likewise.
10135 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10136 to int.
6f04d126
PE
10137 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10138 avoiding the 0 flag, which is not portable.
c2982e87
PE
10139 * process.c (Fmake_network_process): Use pI to avoid cast.
10140 * region-cache.c (pp_cache): Likewise.
10141 * xdisp.c (decode_mode_spec): Likewise.
10142 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10143 behavior on 64-bit hosts with printf arg.
6f04d126 10144 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10145 (x_stop_queuing_selection_requests): Likewise.
10146 (x_get_window_property): Don't truncate byte count to an 'int'
10147 when tracing.
0b432f21 10148
5e073ec7
PE
10149 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10150 here, since it parses constructs like leading '-' and spaces,
10151 which are not wanted; and it overflows with large numbers.
10152 Instead, simply match F[0-9]+, which is what is wanted anyway.
10153
36372bf9
PE
10154 * alloc.c: Remove unportable assumptions about struct layout.
10155 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10156 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10157 (allocate_vectorlike, make_pure_vector): Use the new macros,
10158 plus offsetof, to remove unportable assumptions about struct layout.
10159 These assumptions hold on all porting targets that I know of, but
10160 they are not guaranteed, they're easy to remove, and removing them
10161 makes further changes easier.
10162
0b432f21
PE
10163 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10164 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10165 (string_overrun_cookie): Now const. Use initializers that
10166 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10167 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10168 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10169 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10170 multiple of sizeof (EMACS_INT); it need not be, if
10171 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10172 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10173
895009e1
JB
101742011-04-26 Juanma Barranquero <lekktu@gmail.com>
10175
10176 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10177
6a7a1b0b
TZ
101782011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10179
10180 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10181 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10182 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10183
841a1577 101842011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10185
10186 * lisp.h (Qdebug): List symbol.
895009e1 10187 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10188 * keyboard.c (debug-on-event): New variable.
10189 (handle_user_signal): Break into debugger when debug-on-event
10190 matches the current signal symbol.
10191
f2d3ba6f
DN
101922011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10193
10194 * alloc.c (check_sblock, check_string_bytes)
10195 (check_string_free_list): Convert to standard C.
10196
42ce4c63
TZ
101972011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10198
10199 * w32.c (emacs_gnutls_push): Fix typo.
10200
825cd63c
EZ
102012011-04-25 Eli Zaretskii <eliz@gnu.org>
10202
fb11d64d
EZ
10203 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10204 "cast to pointer from integer of different size".
10205
825cd63c
EZ
10206 Improve doprnt and its use in verror. (Bug#8545)
10207 * doprnt.c (doprnt): Document the set of format control sequences
10208 supported by the function. Use SAFE_ALLOCA instead of always
10209 using `alloca'.
10210
10211 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10212 is one byte too soon. Don't use xrealloc; instead xfree and
10213 xmalloc anew.
10214
e061a11b
TZ
102152011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10216
10217 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10218 callbacks stage.
10219
10220 * gnutls.c: Renamed global_initialized to
10221 gnutls_global_initialized. Added internals for the
10222 :verify-hostname-error, :verify-error, and :verify-flags
10223 parameters of `gnutls-boot' and documented those parameters in the
10224 docstring. Start callback support.
9173deec
JB
10225 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10226 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10227 on error. Return error code.
e061a11b
TZ
10228 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10229 (emacs_gnutls_read): Likewise.
10230 (Fgnutls_boot): Return handshake error code.
10231 (emacs_gnutls_handle_error): New function.
10232 (wsaerror_to_errno): Likewise.
10233
10234 * w32.h (emacs_gnutls_pull): Add prototype.
10235 (emacs_gnutls_push): Likewise.
10236
10237 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10238 (emacs_gnutls_push): Likewise.
10239
102402011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10241
10242 * process.c (wait_reading_process_output): Check if GnuTLS
10243 buffered some data internally if no FDs are set for TLS
10244 connections.
10245
10246 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10247 (LIBS): Link to USER_LIBS.
10248 ($(BLD)/gnutls.$(0)): New target.
10249
fa6996bc
EZ
102502011-04-24 Eli Zaretskii <eliz@gnu.org>
10251
eb35682e
EZ
10252 * xdisp.c (handle_single_display_spec): Rename the
10253 display_replaced_before_p argument into display_replaced_p, to
10254 make it consistent with the commentary. Fix typos in the
10255 commentary.
10256
e2ad650c
EZ
10257 * textprop.c (syms_of_textprop): Remove dead code.
10258 (copy_text_properties): Delete obsolete commentary about an
10259 interface that was deleted long ago. Fix typos in the description
10260 of arguments.
10261
1b2de274
EZ
10262 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10263 to changes in oldXMenu/XMenu.h from 2011-04-16.
10264 <menu_help_message, prev_menu_help_message>: Constify.
10265 (IT_menu_make_room): menu->help_text is now `const char **';
10266 adjust.
10267
10268 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10269 to changes in oldXMenu/XMenu.h from 2011-04-16.
10270 (struct XMenu): Declare `help_text' `const char **'.
10271
10272 * xfaces.c <Qunspecified>: Make extern again.
10273
10274 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10275 required by POSIX.
1b2de274 10276
762b15be
EZ
10277 * doc.c (get_doc_string): Improve the format passed to `error'.
10278
10279 * doprnt.c (doprnt): Improve commentary.
10280
10281 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10282
10283 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10284 them with etags.
10285
f1052e5d
EZ
10286 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10287 changes in globals.h immediately force recompilation.
762b15be
EZ
10288 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10289 $(CURDIR)/s/ms-w32.h.
10290 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10291
fa6996bc
EZ
10292 * character.c (Fchar_direction): Function deleted.
10293 (syms_of_character): Don't defsubr it.
10294 <char-direction-table>: Deleted.
10295
e6c3da20
EZ
102962011-04-23 Eli Zaretskii <eliz@gnu.org>
10297
10298 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10299 * doprnt.c: Include limits.h.
10300 (SIZE_MAX): New macro.
04f2d78b
CB
10301 (doprnt): Return a size_t value. 2nd arg is now size_t.
10302 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10303 Improve overflow protection. Support `l' modifier for integer
10304 conversions. Support %l conversion. Don't assume an EMACS_INT
10305 argument for integer conversions and for %c.
10306
10307 * lisp.h (doprnt): Restore prototype.
10308
10309 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10310 $(SRC)/character.h.
10311
10312 * Makefile.in (base_obj): Add back doprnt.o.
10313
10314 * deps.mk (doprnt.o): Add back prerequisites.
10315 (callint.o): Depend on character.h.
10316
10317 * eval.c (internal_lisp_condition_case): Include the handler
10318 representation in the error message.
10319 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10320 when breaking from the loop.
10321
10322 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10323
10324 * callint.c (Fcall_interactively): When displaying error message
10325 about invalid control letter, pass the character's codepoint, not
10326 a pointer to its multibyte form. Improve display of the character
10327 in octal and display also its hex code.
10328
10329 * character.c (char_string): Use %x to display the (unsigned)
10330 codepoint of an invalid character, to avoid displaying a bogus
10331 negative value.
10332
10333 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10334 `error', not SYMBOL_NAME itself.
10335
10336 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10337 character arguments to `error'.
10338
10339 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10340 to `error' in error message about FINAL_CHAR argument. Make sure
10341 FINAL_CHAR is a character, and use %c when it is passed as
10342 argument to `error'.
10343
4ffd0d6b 103442011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10345
10346 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10347
10348 * w32.c: Include <time.h>.
10349 (sys_localtime): New function.
10350
4ffd0d6b 103512011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10352
10353 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10354
4ffd0d6b 10355 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10356
4ffd0d6b 103572011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10358
4ffd0d6b
GM
10359 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10360 zombies (Bug#8467).
aac0c6e3 10361
04c56954
EZ
103622011-04-19 Eli Zaretskii <eliz@gnu.org>
10363
10364 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10365 gl_state.e_property when gl_state.object is Qt.
10366
10367 * insdel.c (make_gap_larger): Remove limitation of buffer size
10368 to <= INT_MAX.
10369
16a43933
CY
103702011-04-18 Chong Yidong <cyd@stupidchicken.com>
10371
10372 * xdisp.c (lookup_glyphless_char_display)
10373 (produce_glyphless_glyph): Handle cons cell entry in
10374 glyphless-char-display.
10375 (Vglyphless_char_display): Document it.
10376
10377 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10378 glyphless-char-display.
10379
4581706e
CY
103802011-04-17 Chong Yidong <cyd@stupidchicken.com>
10381
10382 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10383
10384 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10385
10386 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10387 definition for no-X builds.
10388
4887c6e2 103892011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10390
fd35b6f9
PE
10391 Static checks with GCC 4.6.0 and non-default toolkits.
10392
5c1ccb01
PE
10393 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10394
006c5daa
PE
10395 * process.c (keyboard_bit_set): Define only if SIGIO.
10396 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10397 (send_process): Repair possible setjmp clobbering.
10398
efc736d3
PE
10399 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10400
4e2fe2e6
PE
10401 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10402
f97334a2
PE
10403 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10404
4e75f29d
PE
10405 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10406 Define only if needed.
10407
90efadd1
PE
10408 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10409 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10410 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10411
3c647824
PE
10412 * dispextern.h (struct redisplay_interface): Rename param
10413 to avoid shadowing.
e264f262 10414 * termhooks.h (struct terminal): Likewise.
761383f4 10415 * xterm.c (xembed_send_message): Likewise.
3c647824 10416
b58c5c4a
PE
10417 * insdel.c (make_gap_smaller): Define only if
10418 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10419
cad59032
PE
10420 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10421 it.
10422
c339dc2e
PE
10423 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10424 so that we aren't warned about unused symbols.
10425
91a3e27b
PE
10426 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10427
399c71d3 10428 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10429
8ffc96f5
PE
10430 * xfns.c (x_real_positions): Mark locals as initialized.
10431
eef9bc79
PE
10432 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10433
098db9dd
PE
10434 * xterm.c: Fix problems found by static analysis with other toolkits.
10435 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10436 (x_dispatch_event): Declare static if USE_GTK, and
10437 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10438 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10439 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10440 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10441 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10442
eb18f6cc
PE
10443 * xmenu.c (menu_help_callback): Pointer type fixes.
10444 Use const pointers when pointing at readonly data. Avoid pointer
10445 signedness clashes.
10446 (FALSE): Remove unused macro.
10447 (update_frame_menubar): Remove unused decl.
10448
1fe72bf8
PE
10449 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10450
60d9e1db
PE
10451 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10452 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10453 (single_menu_item): Rename local to avoid shadowing.
10454
39261c26
PE
10455 * keyboard.c (make_lispy_event): Remove unused local var.
10456
018c5e19
PE
10457 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10458 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10459
63d2b86e
PE
10460 * bitmaps: Change bitmaps from unsigned char back to the X11
10461 compatible char. Avoid the old compiler warnings about
10462 out-of-range initializers by using, for example, '\xab' rather
10463 than 0xab.
10464
aefd87e1
PE
10465 * xgselect.c (xgselect_initialize): Check vs interface
10466 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10467
bf501fb9
PE
10468 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10469
e9829fdf
PE
10470 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10471 to read-only memory.
10472
1086c095
PE
10473 * fns.c (vector): Remove; this old hack is no longer needed.
10474
2baccd04 10475 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10476 Remove unused var.
dde42981 10477 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10478
72391843 10479 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10480
436c16df 10481 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10482 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10483 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10484
92bb796d 10485 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10486 (x_term_init): Remove local to avoid shadowing.
92bb796d 10487
764430a3 10488 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10489
10490 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10491 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10492
d1dfb56c
EZ
104932011-04-16 Eli Zaretskii <eliz@gnu.org>
10494
c4354cb4
EZ
10495 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10496
d1dfb56c
EZ
10497 Fix regex.c, syntax.c and friends for buffers > 2GB.
10498 * syntax.h (struct gl_state_s): Declare character position members
10499 EMACS_INT.
10500
10501 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10502
04f2d78b
CB
10503 * textprop.c (verify_interval_modification, interval_of):
10504 Declare arguments EMACS_INT.
d1dfb56c
EZ
10505
10506 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10507 EMACS_INT.
10508
10509 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10510
10511 * indent.c (Fvertical_motion): Local variable it_start is now
10512 EMACS_INT.
10513
10514 * regex.c (re_match, re_match_2, re_match_2_internal)
10515 (bcmp_translate, regcomp, regexec, print_double_string)
10516 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10517 (re_compile_pattern, re_exec): Declare arguments and local
10518 variables `size_t' and `ssize_t' and return values `regoff_t', as
10519 appropriate.
10520 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10521 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10522 <compile_stack_type>: `size' and `avail' are now `size_t'.
10523
10524 * regex.h <regoff_t>: Use ssize_t, not int.
10525 (re_search, re_search_2, re_match, re_match_2): Arguments that
10526 specify buffer/string position and length are now ssize_t and
10527 size_t. Return type is regoff_t.
10528
613052cd
BK
105292011-04-16 Ben Key <bkey76@gmail.com>
10530
10531 * nsfont.m: Fixed bugs in ns_get_family and
10532 ns_descriptor_to_entity that were caused by using free to
10533 deallocate memory blocks that were allocated by xmalloc (via
10534 xstrdup). This caused Emacs to crash when compiled with
10535 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10536 --enable-checking=xmallocoverrun). xfree is now used to
10537 deallocate these memory blocks.
10538
4170f62f 105392011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10540
71b41406
PE
10541 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10542
9587a89d
PE
10543 emacs_write: Accept and return EMACS_INT for sizes.
10544 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10545 et seq.
10546 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10547 Accept and return EMACS_INT.
10548 (emacs_gnutls_write): Return the number of bytes written on
10549 partial writes.
10550 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10551 (emacs_read, emacs_write): Remove check for negative size, as the
10552 Emacs source code has been audited now.
9587a89d
PE
10553 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10554 (emacs_read, emacs_write): Use it.
273a5f82
PE
10555 * process.c (send_process): Adjust to the new signatures of
10556 emacs_write and emacs_gnutls_write. Do not attempt to store
10557 a byte offset into an 'int'; it might overflow.
9587a89d 10558 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10559
3e047f51
PE
10560 * sound.c: Don't assume sizes fit in 'int'.
10561 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10562 Return EMACS_INT, not int.
3e047f51 10563 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10564 Accept EMACS_INT, not int.
10565 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10566 record read return values.
10567
cc39a9db
BK
105682011-04-15 Ben Key <bkey76@gmail.com>
10569
c9d0ec6d
JB
10570 * keyboard.c (Qundefined): Don't declare static since it is used
10571 in nsfns.m.
10572 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10573 static since they are used in nsfont.m.
cc39a9db 10574
6c60eb9f
SM
105752011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10576
10577 * process.c (Qprocessp): Don't declare static.
10578 * lisp.h (Qprocessp): Declare again.
10579
7990b61a
JB
105802011-04-15 Juanma Barranquero <lekktu@gmail.com>
10581
10582 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10583
5d4cb038
PE
105842011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10585
8bd7b830 10586 Improve C-level modularity by making more things 'static'.
cd64ea1d 10587
e3b27b31
PE
10588 Don't publish debugger-only interfaces to other modules.
10589 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10590 (verify_bytepos, count_markers): Move decls to the only modules
10591 that need them.
10592 * region-cache.h (pp_cache): Likewise.
10593 * window.h (check_all_windows): Likewise.
10594 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10595
5d4cb038
PE
10596 * sysdep.c (croak): Now static, if
10597 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10598 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10599
10600 * alloc.c (refill_memory_reserve): Now static if
10601 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10602 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10603
e87b6180
PE
10604 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10605 Define only if USE_LUCID.
10606
ac64929e
PE
10607 * xrdb.c (x_customization_string, x_rm_string): Now static.
10608
6f37259d
PE
10609 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10610 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10611
1683e3ab
PE
10612 * xdisp.c (draw_row_with_mouse_face): Now static.
10613 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10614
de9c2632
PE
10615 * window.h (check_all_windows): Mark externally visible.
10616
2b96acb7
PE
10617 * window.c (window_deletion_count): Now static.
10618
10619 * undo.c: Make symbols static if they're not exported.
10620 (last_undo_buffer, last_boundary_position, pending_boundary):
10621 Now static.
10622
50436f33
PE
10623 * textprop.c (interval_insert_behind_hooks): Now static.
10624 (interval_insert_in_front_hooks): Likewise.
10625
64520e5c
PE
10626 * term.c: Make symbols static if they're not exported.
10627 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10628 (max_frame_lines, tty_set_terminal_modes):
10629 (tty_reset_terminal_modes, tty_turn_off_highlight):
10630 (get_tty_terminal): Now static.
10631 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10632 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10633 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10634 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10635 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10636
1fa53021
PE
10637 * sysdep.c: Make symbols static if they're not exported.
10638 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10639 Now static.
10640 (sigprocmask_set, full_mask): Remove; unused.
10641 (wait_debugging): Mark as visible.
10642 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10643 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10644
d4b43b22
PE
10645 * syntax.c (syntax_temp): Define only if !__GNUC__.
10646
b7c513d0
PE
10647 * sound.c (current_sound_device, current_sound): Now static.
10648
989b29ad
PE
10649 * search.c (searchbufs, searchbuf_head): Now static.
10650
13a55a78
PE
10651 * scroll.c (scroll_cost): Remove; unused.
10652 * dispextern.h (scroll_cost): Remove decl.
10653
de68a1fc
PE
10654 * region-cache.h (pp_cache): Mark as externally visible.
10655
40ccffa6
PE
10656 * process.c: Make symbols static if they're not exported.
10657 (process_tick, update_tick, create_process, chan_process):
10658 (Vprocess_alist, proc_buffered_char, datagram_access):
10659 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10660 (deactivate_process): Mark defn as static, as well as decl.
10661 * lisp.h (create_process): Remove decl.
10662 * process.h (chan_process, Vprocess_alist): Remove decls.
10663
ad64fc97
PE
10664 * print.c: Make symbols static if they're not exported.
10665 (print_depth, new_backquote_output, being_printed, print_buffer):
10666 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10667 (print_interval, print_number_index, initial_stderr_stream):
10668 Now static.
10669 * lisp.h (Fprinc): Remove decl.
10670 (debug_output_compilation_hack): Mark as externally visible.
10671
adddb265
PE
10672 * sysdep.c (croak): Move decl from here to syssignal.h.
10673 * syssignal.h (croak): Put it here, so the API can be checked when
10674 'croak' is called from dissociate_if_controlling_tty.
10675
1717ede2
PE
10676 * minibuf.c: Make symbols static if they're not exported.
10677 (minibuf_save_list, choose_minibuf_frame): Now static.
10678 * lisp.h (choose_minibuf_frame): Remove decl.
10679
fa5fb2bc
PE
10680 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10681
1e3890d1
PE
10682 * lread.c: Make symbols static if they're not exported.
10683 (read_objects, initial_obarray, oblookup_last_bucket_number):
10684 Now static.
10685 (make_symbol): Remove; unused.
10686 * lisp.h (initial_obarray, make_symbol): Remove decls.
10687
8a1414fa
PE
10688 * keyboard.c: Make symbols static if they're not exported.
10689 (single_kboard, recent_keys_index, total_keys, recent_keys):
10690 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10691 (this_single_command_key_start, echoing, last_auto_save):
10692 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10693 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10694 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10695 (Vlispy_mouse_stem, double_click_count):
10696 Now static.
10697 (force_auto_save_soon): Define only if SIGDANGER.
10698 (ignore_mouse_drag_p): Now static if
10699 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10700 (print_help): Remove; unused.
10701 (stop_character, last_timer_event): Mark as externally visible.
10702 * keyboard.h (ignore_mouse_drag_p): Declare only if
10703 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10704 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10705 * lisp.h (echoing): Remove decl.
10706 (force_auto_save_soon): Declare only if SIGDANGER.
10707 * xdisp.c (redisplay_window): Simplify code, to make it more
10708 obvious that ignore_mouse_drag_p is not accessed if !defined
10709 USE_GTK && !defined HAVE_NS.
10710
93ea6e8f
PE
10711 * intervals.c: Make symbols static if they're not exported.
10712 (merge_properties_sticky, merge_interval_right, delete_interval):
10713 Now static.
10714 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10715
77382fcc
PE
10716 * insdel.c: Make symbols static if they're not exported.
10717 However, leave prepare_to_modify_buffer alone. It's never
10718 called from outside this function, but that appears to be a bug.
10719 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10720 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10721 (adjust_after_replace_noundo): Remove; unused.
10722 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10723 (signal_before_change): Remove decls.
77382fcc 10724
9306c32e
PE
10725 * indent.c (val_compute_motion, val_vmotion): Now static.
10726
cd44d2eb
PE
10727 * image.c: Make symbols static if they're not exported.
10728 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10729 if USE_GTK.
10730 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10731 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10732
ad9a7a06
PE
10733 * fringe.c (standard_bitmaps): Now static.
10734 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10735
81626931
PE
10736 * frame.c: Make symbols static if they're not exported.
10737 (x_report_frame_params, make_terminal_frame): Now static.
10738 (get_frame_param): Now static, unless HAVE_NS.
10739 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10740 (x_get_resource_string): Remove; not used.
10741 * frame.h (make_terminal_frame, x_report_frame_params):
10742 (x_get_resource_string); Remove decls.
10743 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10744 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10745
239f9db9
PE
10746 * font.c, fontset.c: Make symbols static if they're not exported.
10747 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10748 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10749 * font.c (font_close_object): Now static.
10750 * font.h (font_close_object): Remove.
10751 * fontset.c (FONTSET_OBJLIST): Remove.
10752 (free_realized_fontset) #if-0 the body, which does nothing.
10753 (face_suitable_for_char_p): #if-0, as it's never called.
10754 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10755 * xfaces.c (face_at_string_position):
10756 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10757 since 0 is always ASCII.
10758
dfcf3579
PE
10759 * fns.c (weak_hash_tables): Now static.
10760
5045092b
PE
10761 * fileio.c: Make symbols static if they're not exported.
10762 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10763 (Vwrite_region_annotation_buffers): Now static.
10764
57a96f5c
PE
10765 * eval.c: Make symbols static if they're not exported.
10766 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10767 * lisp.h (backtrace_list): Remove decl.
10768
35f08c38
PE
10769 * emacs.c: Make symbols static if they're not exported.
10770 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10771 (fatal_error_code, fatal_error_signal_hook, standard_args):
10772 Now static.
10773 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10774 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10775 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10776 * lisp.h (fatal_error_signal_hook): Remove decl.
10777 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10778
f44bd759
PE
10779 * editfns.c: Move a (normally-unused) function to its only use.
10780 * editfns.c, lisp.h (get_operating_system_release): Remove.
10781 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10782 worth the hassle of breaking this out.
10783
b532497d
PE
10784 * xterm.c: Make symbols static if they're not exported.
10785 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10786 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10787 (x_destroy_window, x_delete_display):
10788 Now static.
10789 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10790 (x_mouse_leave): Remove; unused.
10791 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10792 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10793 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10794 Remove decls.
10795 (x_mouse_leave): Declare only if WINDOWSNT.
10796 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10797 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10798 USE_X_TOOLKIT.
10799
1675728f
PE
10800 * ftxfont.c: Make symbols static if they're not exported.
10801 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10802 HAVE_FREETYPE.
10803 * font.h (ftxfont_driver): Likewise.
10804
e4cebfca
PE
10805 * xfns.c: Make symbols static if they're not exported.
10806 (x_last_font_name, x_display_info_for_name):
10807 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10808 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10809 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10810 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10811 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10812 (last_show_tip_args): Now static.
10813 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10814 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10815 (x_screen_planes): Remove; unused.
10816 * dispextern.h (x_screen_planes): Remove decl.
10817
5bf46f05
PE
10818 * dispnew.c: Make symbols static if they're not exported.
10819 * dispextern.h (redraw_garbaged_frames, scrolling):
10820 (increment_row_positions): Remove.
10821 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10822 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10823 Now static.
10824 (redraw_garbaged_frames): Remove; unused.
10825
435f4c28
PE
10826 * xfaces.c: Make symbols static if they're not exported.
10827 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10828 Remove decls.
10829 * xterm.h (defined_color): Remove decls.
10830 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10831 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10832 (menu_face_changed_default, defined_color, free_realized_face):
10833 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10834 (ascii_face_of_lisp_face): Remove; unused.
10835
8524aef3
PE
10836 * xdisp.c: Make symbols static if they're not exported.
10837 * dispextern.h (scratch_glyph_row, window_box_edges):
10838 (glyph_to_pixel_coords, set_cursor_from_row):
10839 (get_next_display_element, set_iterator_to_next):
10840 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10841 (show_mouse_face): Remove decls
10842 * frame.h (message_buf_print): Likewise.
10843 * lisp.h (pop_message, set_message, check_point_in_composition):
10844 Likewise.
10845 * xterm.h (set_vertical_scroll_bar): Likewise.
10846 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10847 (message_buf_print, scratch_glyph_row, displayed_buffer):
10848 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10849 (get_next_display_element, show_mouse_face, window_box_edges):
10850 (frame_to_window_pixel_xy, check_point_in_composition):
10851 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10852 (glyph_to_pixel_coords): Remove; unused.
10853
16390cd2
PE
10854 * dired.c (file_name_completion): Now static.
10855
10856 * dbusbind.c (xd_in_read_queued_messages): Now static.
10857
a25f4dfa
PE
10858 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10859 * data.c (circular_list_error): Remove.
10860
14a9c8df
PE
10861 * commands.h (last_point_position, last_point_position_buffer):
10862 (last_point_position_window): Remove decls.
10863 * keyboard.c: Make these variables static.
10864
04f2d78b
CB
10865 * coding.h (coding, code_convert_region, encode_coding_gap):
10866 Remove decls.
74ab6df5
PE
10867 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10868 (iso_code_class, detect_coding, code_convert_region): Now static.
10869 (encode_coding_gap): Remove; unused.
10870
38dfbee1
PE
10871 * chartab.c (chartab_chars, chartab_bits): Now static.
10872
a2cb4e63
PE
10873 * charset.h (charset_iso_8859_1): Remove decl.
10874 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10875 Now static.
10876
127198fd
PE
10877 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10878 * ccl.c (Vccl_program_table): Now static.
10879 (check_ccl_update): Remove; unused.
10880
d85b608f
PE
10881 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10882 * category.h: ... from here.
10883 * category.c (check_category_table, set_category_set): Now static.
10884
31cd66f3
PE
10885 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10886 * lisp.h: Remove these decls.
10887
c358e587
PE
10888 * buffer.c (buffer_count): Remove unused var.
10889
e78aecca
PE
10890 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10891 so that it's not optimized away.
10892 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10893 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10894 exported only to the debugger.
10895
e192d7d3 10896 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10897 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10898
92470028
PE
10899 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10900 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10901 was inaccessible from Lisp.
10902 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10903 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10904
244ed907
PE
10905 alloc.c: Import and export fewer symbols, and remove unused items.
10906 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10907 is defined.
10908 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10909 it's not optimized away by whole-program optimization.
10910 (message_enable_multibyte, free_misc): Remove.
10911 (catchlist, handlerlist, mark_backtrace):
10912 Declare only if BYTE_MARK_STACK.
10913 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10914 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10915 (message_enable_multibyte): Remove decl.
10916 (free_misc, interval_free_list, float_block, float_block_index):
10917 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10918 (cons_free_list, last_marked_index):
10919 Now static.
10920 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10921 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10922 (mark_backtrace): Define only if BYTE_MARK_STACK.
10923 * xdisp.c (message_enable_multibyte): Now static.
10924
61c2b50e 10925 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10926 This makes it easier for human readers (and static analyzers)
10927 to see whether these variables are used from other modules.
10928 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10929 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10930 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10931 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10932 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10933 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10934 * xmenu.c, xselect.c:
10935 Declare Q* vars static if they are not used in other modules.
10936 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10937 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10938 Remove decls of unexported vars.
10939 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10940
95c82688
PE
10941 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10942
16a97296
PE
10943 Make Emacs functions such as Fatom 'static' by default.
10944 This makes it easier for human readers (and static analyzers)
10945 to see whether these functions can be called from other modules.
10946 DEFUN now defines a static function. To make the function external
10947 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10948 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10949 (Finit_image_library):
16a97296
PE
10950 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10951 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10952 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10953 Remove decls, since these functions are now static.
10954 (Funintern, Fget_internal_run_time): New decls, since these functions
10955 were already external.
95c82688 10956
16a97296
PE
10957 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10958 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10959 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10960 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10961 * keyboard.c, keymap.c, lread.c:
10962 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10963 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10964 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10965 Mark functions with DEFUE instead of DEFUN,
10966 if they are used in other modules.
10967 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10968 decls for now-static functions.
10969 * buffer.h (Fdelete_overlay): Remove decl.
10970 * callproc.c (Fgetenv_internal): Mark as internal.
10971 * composite.c (Fremove_list_of_text_properties): Remove decl.
10972 (Fcomposition_get_gstring): New forward static decl.
10973 * composite.h (Fcomposite_get_gstring): Remove decl.
10974 * dired.c (Ffile_attributes): New forward static decl.
10975 * doc.c (Fdocumntation_property): New forward static decl.
10976 * eval.c (Ffetch_bytecode): New forward static decl.
10977 (Funintern): Remove extern decl; now in .h file where it belongs.
10978 * fileio.c (Fmake_symbolic_link): New forward static decl.
10979 * image.c (Finit_image_library): New forward static decl.
10980 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10981 * intervals.h (Fprevious_property_change):
10982 (Fremove_list_of_text_properties): Remove decls.
10983 * keyboard.c (Fthis_command_keys): Remove decl.
10984 (Fcommand_execute): New forward static decl.
10985 * keymap.c (Flookup_key): New forward static decl.
10986 (Fcopy_keymap): Now static.
10987 * keymap.h (Flookup_key): Remove decl.
10988 * process.c (Fget_process): New forward static decl.
10989 (Fprocess_datagram_address): Mark as internal.
10990 * syntax.c (Fsyntax_table_p): New forward static decl.
10991 (skip_chars): Remove duplicate decl.
10992 * textprop.c (Fprevious_property_change): New forward static decl.
10993 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10994 Now internal.
10995 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10996 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10997
785bbd42
PE
10998 * editfns.c (Fformat): Remove unreachable code.
10999
8b913b57
AS
110002011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11001
11002 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11003 change. (Bug#8496)
11004
a6744a35
EZ
110052011-04-13 Eli Zaretskii <eliz@gnu.org>
11006
11007 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11008 when at ZV. (Bug#8487)
11009
e7974947
AS
110102011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11011
baad03f0
AS
11012 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11013 (Bug#8437)
11014 * keyboard.c (parse_tool_bar_item): Likewise.
11015 * sound.c (sound_cleanup, alsa_close): Likewise.
11016 * termcap.c (tgetent): Likewise.
11017 * xfns.c (x_default_font_parameter): Likewise.
11018 * xsettings.c (read_and_apply_settings): Likewise.
11019
e7974947
AS
11020 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11021 (overrun_check_free): Protoize.
11022
28272684
PE
110232011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11024
11025 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11026 since callers should never pass a negative size.
11027 Change the signature to match that of plain 'read' and 'write'; see
11028 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11029 * lisp.h: Update prototypes of emacs_write and emacs_read.
11030
11997c76
EZ
110312011-04-11 Eli Zaretskii <eliz@gnu.org>
11032
11033 * xdisp.c (redisplay_window): Don't try to determine the character
11034 position of the scroll margin if the window start point w->startp
e896f03c 11035 is outside the buffer's accessible region. (Bug#8468)
11997c76 11036
8a2cbd72
EZ
110372011-04-10 Eli Zaretskii <eliz@gnu.org>
11038
11039 Fix write-region and its subroutines for buffers > 2GB.
11040 * fileio.c (a_write, e_write): Modify declaration of arguments and
11041 local variables to support buffers larger than 2GB.
11042 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11043
11044 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11045 argument, local variables, and return value.
11046
11047 * lisp.h: Update prototypes of emacs_write and emacs_read.
11048
11049 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11050
4073e537 110512011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11052
1ebfdcb6
PE
11053 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11054
b2ded58d
PE
11055 Fix more problems found by GCC 4.6.0's static checks.
11056
7d66342c
PE
11057 * xdisp.c (vmessage): Use a better test for character truncation.
11058
bbf47d44
PE
11059 * charset.c (load_charset_map): <, not <=, for optimization,
11060 and to avoid potential problems with integer overflow.
9248994d 11061 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11062 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11063 * editfns.c (Fformat): Likewise.
1e69125e 11064 * syntax.c (skip_chars): Likewise.
3befa583 11065
e3019616
PE
11066 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11067 This also lets GCC 4.6.0 generate slightly better loop code.
11068
becfa255
PE
11069 * callint.c (Fcall_interactively): <, not <=, for optimization.
11070 (Fcall_interactively): Count the number of arguments produced,
11071 not the number of arguments given. This is simpler and lets GCC
11072 4.6.0 generate slightly better code.
11073
dae0cd48
PE
11074 * ftfont.c: Distingish more carefully between FcChar8 and char.
11075 The previous code passed unsigned char * to a functions like
11076 strlen and xstrcasecmp that expect char *, which does not
11077 conform to the C standard.
11078 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11079 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11080 char * when the C standard requires it.
11081
76032d70
PE
11082 * keyboard.c (read_char): Remove unused var.
11083
eb3f1cc8
PE
11084 * eval.c: Port to Windows vsnprintf (Bug#8435).
11085 Include <limits.h>.
11086 (SIZE_MAX): Define if the headers do not.
11087 (verror): Do not give up if vsnprintf returns a negative count.
11088 Instead, grow the buffer. This ports to Windows vsnprintf, which
11089 does not conform to C99. Problem reported by Eli Zaretskii.
11090 Also, simplify the allocation scheme, by avoiding the need for
11091 calling realloc, and removing the ALLOCATED variable.
11092
70476b54
PE
11093 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11094
12020a9e
PE
11095 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11096 But keep the doprint source code for now, as we might revamp it
11097 and use it again (Bug#8435).
ea6c7ae6
PE
11098 * lisp.h (doprnt): Remove.
11099 * Makefile.in (base_obj): Remove doprnt.o.
11100 * deps.mk (doprnt.o): Remove.
11101
5fdb398c
PE
11102 error: Print 32- and 64-bit integers portably (Bug#8435).
11103 Without this change, on typical 64-bit hosts error ("...%d...", N)
11104 was used to print both 32- and 64-bit integers N, which relied on
11105 undefined behavior.
61bdb816 11106 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11107 * lisp.h (error, verror): Mark as printf-like functions.
11108 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11109 Report overflow in size calculations when allocating printf buffer.
11110 Do not truncate output string at its first null byte.
11111 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11112 Truncate the output at a character boundary, since vsnprintf does not
11113 do that.
11114 * charset.c (check_iso_charset_parameter): Convert internal
11115 character to string before calling 'error', since %c now has the
11116 printf meaning.
11117 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11118 overflow when computing char to be passed to 'error'. Do not
11119 pass Lisp_Object to 'error'; pass the integer instead.
11120 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11121 formatted with plain %d.
11122
b189fa66
PE
11123 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11124
bff87ef0
PE
11125 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11126
7e2cac20
PE
11127 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11128
ce4d90b5
PE
11129 * xterm.c (x_catch_errors): Remove duplicate declaration.
11130
266c9547
PE
11131 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11132
79c49ad2
PE
11133 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11134
368f4090
JM
111352011-04-10 Jim Meyering <meyering@redhat.com>
11136
11137 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11138 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11139 return ssize_t not "int", and use size_t as the buffer length.
11140 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11141 * gnutls.h: Update declarations.
11142 * process.c (read_process_output): Use ssize_t, to match.
11143 (send_process): Likewise.
11144
a32d4040
CY
111452011-04-09 Chong Yidong <cyd@stupidchicken.com>
11146
11147 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11148
8546720e 111492011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11150
04f2d78b
CB
11151 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11152 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11153
8546720e
GM
11154 * xterm.c (handle_one_xevent):
11155 * xmenu.c (create_and_show_popup_menu):
11156 * xselect.c (x_decline_selection_request)
11157 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11158
0a2f5c1a 111592011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11160
11161 Fix some uses of `int' instead of EMACS_INT.
11162 * search.c (string_match_1, fast_string_match)
11163 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11164 (scan_buffer, find_next_newline_no_quit)
11165 (find_before_next_newline, search_command, Freplace_match)
11166 (Fmatch_data): Make some `int' variables be EMACS_INT.
11167
11168 * xdisp.c (display_count_lines): 3rd argument and return value now
11169 EMACS_INT. All callers changed.
11170 (pint2hrstr): Last argument is now EMACS_INT.
11171
11172 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11173 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11174 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11175 (decode_coding_utf_16, decode_coding_emacs_mule)
11176 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11177 (decode_coding_ccl, decode_coding_charset)
11178 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11179 (decode_coding_iso_2022, decode_coding_emacs_mule)
11180 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11181 <char_offset, last_offset>: Declare EMACS_INT.
11182 (encode_coding_utf_8, encode_coding_utf_16)
11183 (encode_coding_emacs_mule, encode_invocation_designation)
11184 (encode_designation_at_bol, encode_coding_iso_2022)
11185 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11186 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11187 Declare EMACS_INT.
11188 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11189 (encode_invocation_designation): Last argument P_NCHARS is now
11190 EMACS_INT.
11191 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11192 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11193
11194 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11195 All users changed.
11196
11197 * ccl.c (Fccl_execute_on_string): Declare some variables
11198 EMACS_INT.
11199
8546720e 112002011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11201
11202 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11203
4e19a977
CS
112042011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11205
11206 * process.c (Fformat_network_address): Doc fix.
11207
87302331
R
112082011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11209
ee7683eb 11210 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11211
cbb59342
CY
112122011-04-08 Chong Yidong <cyd@stupidchicken.com>
11213
11214 * keyboard.c (read_char): Call Lisp function help-form-show,
11215 instead of using internal_with_output_to_temp_buffer.
11216 (Qhelp_form_show): New var.
e0d38eeb 11217 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11218
11219 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11220
11221 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11222
e67a13ab
CY
112232011-04-06 Chong Yidong <cyd@stupidchicken.com>
11224
04f2d78b
CB
11225 * process.c (Flist_processes): Remove to Lisp.
11226 (list_processes_1): Delete.
e67a13ab 11227
973f782d
EZ
112282011-04-06 Eli Zaretskii <eliz@gnu.org>
11229
7c106b1e
EZ
11230 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11231
973f782d
EZ
11232 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11233
41cf7d1a 112342011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11235
ca23cc88
PE
11236 Fix more problems found by GCC 4.6.0's static checks.
11237
f390e2d5
PE
11238 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11239
42eea0d0
PE
11240 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11241
b69769da 11242 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11243
f9541e84
PE
11244 * xdisp.c (vmessage): Mark as a printf-like function.
11245
13841b55
PE
11246 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11247
c136c10f
PE
11248 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11249
5e2d4a30
PE
11250 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11251 printf-like functions.
11252 (tiff_load): Add casts to remove these marks before passing them
11253 to system-supplied API.
11254
583f48b9
PE
11255 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11256
b25d760e
PE
11257 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11258 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11259 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11260 directly, rather than having caller test rule sign. This avoids
11261 some unnecessary tests.
11262 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11263 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11264 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11265
bc7b6697 11266 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11267 (xfont_open): Avoid unnecessary tests.
bc7b6697 11268
27ccc379
PE
11269 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11270
dcd5c89a
PE
11271 * composite.h, composite.c (composition_gstring_put_cache):
11272 Use EMACS_INT, not int, for length.
11273
b13a45c6
PE
11274 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11275 breaking out part of COMPOSITION_DECODE_RULE.
11276 (COMPOSITION_DECODE_RULE): Use it.
11277 * composite.c (get_composition_id): Remove unused local vars,
11278 by using the new macro.
11279
1e792e4d
PE
11280 * textprop.c (set_text_properties_1): Change while to do-while,
11281 since the condition is always true at first.
11282
dc6c6455 11283 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11284 (interval_deletion_adjustment): Return unsigned value.
11285 All uses changed.
dc6c6455 11286
aba7731a
PE
11287 * process.c (list_processes_1, create_pty, read_process_output):
11288 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11289 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11290 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11291 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11292 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11293
fdfc4bf3
PE
11294 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11295
fca8fe46 11296 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11297 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11298
06a0259a 11299 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11300 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11301 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11302
e7b9e80f
PE
11303 * print.c (print_error_message): Avoid int overflow.
11304
56201685
PE
11305 * font.c (font_list_entities): Redo for clarity,
11306 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11307
78834453 11308 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11309 (font_score): Avoid potential overflow in diff calculation.
78834453 11310
0bc0b309 11311 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11312 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11313
e610eaca
PE
11314 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11315
b895abce
PE
11316 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11317 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11318 can always succeed if overflow has undefined behavior.
11319
1f1d9321 11320 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11321 (wordify): Omit three unnecessary tests.
1f1d9321 11322
c59478bc
PE
11323 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11324 All callers changed. This avoids the need for an unused var.
11325
79b73827
PE
11326 * casefiddle.c (casify_region): Remove var that is set but not used.
11327
a4db5dfe
PE
11328 * dired.c (file_name_completion): Remove var that is set but not used.
11329
43aae36e
PE
11330 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11331
2a47c44d 11332 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11333 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11334
a37c69bf
PE
11335 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11336 Check for integer overflow on size calculations.
11337
328ab8e7
PE
11338 * buffer.c (Fprevious_overlay_change): Remove var that is set
11339 but not used.
11340
e5a2a5cb
PE
11341 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11342 Remove vars that are set but not used.
8d84a6eb 11343 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11344 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11345
a60e5f68
PE
11346 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11347
f661cb61 11348 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11349 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11350
f0397f5a
PE
11351 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11352 that are set but not used.
11353
8664db06 11354 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11355 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11356
6abdaa4a
PE
11357 * xselect.c (x_get_local_selection, x_handle_property_notify):
11358 Remove vars that are set but not used.
11359
0ce7538d 11360 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11361 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11362
9ae848fc
PE
11363 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11364 Remove var that is set but not used.
0b918413
PE
11365 (scroll_bar_windows_size): Now size_t, not int.
11366 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11367 Check for overflow.
9ae848fc 11368
a5a62657
PE
11369 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11370 (map_tty_color) [!defined MSDOS]: Likewise.
11371
5c5cdd39
PE
11372 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11373
66ebf983
PE
11374 * coding.c: Remove vars that are set but not used.
11375 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11376 All callers changed.
11377 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11378 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11379 (decode_coding_charset): Remove vars that are set but not used.
11380
1be4d761
PE
11381 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11382 that is set but not used.
11383
47553fa8
PE
11384 * print.c (print_object): Remove var that is set but not used.
11385
1f7196bf 11386 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11387 The gnulib version avoids calling malloc in the usual case,
11388 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11389 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11390 * filelock.c (current_lock_owner): Likewise.
11391 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11392 * sysdep.c: Include allocator.h, careadlinkat.h.
11393 (emacs_no_realloc_allocator): New static constant.
11394 (emacs_readlink): New function.
fdb61804
PE
11395 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11396 ../lib/careadlinkat.h.
d1fdcab7 11397
f84c17c7
SM
113982011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11399
11400 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11401 first non-nil return value).
11402
ef3862ad
JD
114032011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11404
11405 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11406 if not defined (Bug#8403).
11407
376a7006
JB
114082011-04-02 Juanma Barranquero <lekktu@gmail.com>
11409
11410 * xdisp.c (display_count_lines): Remove parameter `start',
11411 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11412 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11413 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11414 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11415 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11416 and thereabouts. All callers changed.
11417 (get_per_char_metric): Remove parameter `f', unused since
11418 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11419
6ca3801d
JM
114202011-04-02 Jim Meyering <meyering@redhat.com>
11421
11422 do not dereference NULL upon failed strdup
11423 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11424 (ns_get_family): Likewise.
11425
d8e2b5ba
JB
114262011-04-02 Juanma Barranquero <lekktu@gmail.com>
11427
11428 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11429
8c74fcbd
JD
114302011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11431
11432 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11433 later (Bug#8403).
11434
7200d79c
SM
114352011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11436
03408648 11437 Add lexical binding.
7200d79c 11438
03408648
SM
11439 * window.c (Ftemp_output_buffer_show): New fun.
11440 (Fsave_window_excursion):
11441 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11442
11443 * lread.c (lisp_file_lexically_bound_p): New function.
11444 (Fload): Bind Qlexical_binding.
11445 (readevalloop): Remove `evalfun' arg.
11446 Bind Qinternal_interpreter_environment.
11447 (Feval_buffer): Bind Qlexical_binding.
11448 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11449 Mark as dynamic.
11450 (syms_of_lread): Declare `lexical-binding'.
11451
11452 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11453
11454 * keyboard.c (eval_dyn): New fun.
11455 (menu_item_eval_property): Use it.
ca105506
SM
11456
11457 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11458
03408648
SM
11459 * fns.c (concat, mapcar1): Accept byte-code-functions.
11460
11461 * eval.c (Fsetq): Handle lexical vars.
11462 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11463 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11464 (FletX, Flet): Obey lexical binding.
11465 (Fcommandp): Handle closures.
11466 (Feval): New `lexical' arg.
11467 (eval_sub): New function extracted from Feval. Use it almost
11468 everywhere where Feval was used. Look up vars in lexical env.
11469 Handle closures.
11470 (Ffunctionp): Move from subr.el.
11471 (Ffuncall): Handle closures.
11472 (apply_lambda): Remove `eval_flags'.
11473 (funcall_lambda): Handle closures and new byte-code-functions.
11474 (Fspecial_variable_p): New function.
11475 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11476 but without exporting it to Lisp.
23aba0ea 11477
23aba0ea 11478 * doc.c (Fdocumentation, store_function_docstring):
03408648 11479 * data.c (Finteractive_form): Handle closures.
23aba0ea 11480
03408648
SM
11481 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11482 interactive spec.
ba83908c 11483
04f2d78b
CB
11484 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11485 New byte-codes.
03408648
SM
11486 (exec_byte_code): New function extracted from Fbyte_code to handle new
11487 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11488
03408648 11489 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11490
03408648 11491 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11492
e2abce01
JB
114932011-03-31 Juanma Barranquero <lekktu@gmail.com>
11494
11495 * xdisp.c (redisplay_internal): Fix prototype.
11496
63696a73 114972011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11498
63696a73 11499 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11500 (try_scrolling): Use it when setting scroll_limit.
11501 Limit scrolling to 100 screen lines.
63696a73
EZ
11502 (redisplay_window): Even when falling back on "recentering",
11503 position point in the window according to scroll-conservatively,
11504 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11505
11506 (try_scrolling): When point is above the window, allow searching
11507 as far as scroll_max, or one screenful, to compute vertical
11508 distance from PT to the scroll margin position. This prevents
11509 try_scrolling from unnecessarily failing when
11510 scroll-conservatively is set to a value slightly larger than the
11511 window height. Clean up the case of PT below the margin at bottom
11512 of window: scroll_max can no longer be INT_MAX. When aggressive
11513 scrolling is in use, don't let point enter the opposite scroll
11514 margin as result of the scroll.
11515 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11516 threshold of 100 lines for never-recentering scrolling.
11517
e4cc2dfc
JB
115182011-03-31 Juanma Barranquero <lekktu@gmail.com>
11519
11520 * dispextern.h (move_it_by_lines):
11521 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11522 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11523 (message_log_check_duplicate): Remove parameters `prev_bol' and
11524 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11525 (redisplay_internal): Remove parameter `preserve_echo_area',
11526 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11527
11528 * indent.c (Fvertical_motion):
11529 * window.c (window_scroll_pixel_based, Frecenter):
11530 Don't pass `need_y_p' to `move_it_by_lines'.
11531
1c470562
SM
115322011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11533
44f230aa
SM
11534 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11535 steal a few bits to be more compact.
11536 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11537 Remove unneeded casts.
11538
1c470562
SM
11539 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11540
888adce9
ZK
115412011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11542
11543 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11544 binding" message (bug#7967).
11545
f838ed7b
PE
115462011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11547
77861b95
PE
11548 Fix more problems found by GCC 4.6.0's static checks.
11549
de6dbc14
PE
11550 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11551 Remove unused local var.
11552
f838ed7b
PE
11553 * editfns.c (Fmessage_box): Remove unused local var.
11554
792c7b2b
PE
11555 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11556 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11557 Omit unused local vars.
c499e557 11558 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11559 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11560 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11561 Omit unused local var.
11562
ba0165e1
PE
11563 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11564 Don't assume string length fits in int.
32ad8845 11565 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11566 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11567
3c59b4c9
PE
11568 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11569 instead of alloca (Bug#8344).
11570
a3eed478 11571 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11572 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11573
eb4d412d
PE
11574 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11575
1658b401
PE
11576 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11577 concerns.
11578
11579 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11580
11581 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11582
9a2c6e05
PE
11583 * keyboard.c (syms_of_keyboard): Use the same style as later
11584 in this function when indexing through an array. This also
11585 works around GCC bug 48267.
11586
03d0a109
PE
11587 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11588
44f730c8
PE
11589 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11590
fe75f926
PE
11591 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11592 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11593
ffa8c828
PE
11594 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11595 This avoids undefined behavior on integer overflow, and is a bit
11596 more convenient anyway since it is compared to a size_t variable.
11597
c5101a77
PE
11598 Variadic C functions now count arguments with size_t, not int.
11599 This avoids an unnecessary limitation on 64-bit machines, which
11600 caused (substring ...) to crash on large vectors (Bug#8344).
11601 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11602 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11603 All variadic functions and their callers changed accordingly.
c5101a77
PE
11604 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11605 * data.c (arith_driver, float_arith_driver): Likewise.
11606 * editfns.c (general_insert_function): Likewise.
11607 * eval.c (struct backtrace.nargs, interactive_p)
11608 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11609 (funcall_lambda, mark_backtrace): Likewise.
11610 * fns.c (concat): Likewise.
11611 * frame.c (x_set_frame_parameters): Likewise.
11612 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11613 0 if not found, not -1. All callers changed.
11614
dd3f25f7
PE
11615 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11616 (stack_copy_size): Now size_t, not int.
11617 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11618
461c2ab9
JB
116192011-03-28 Juanma Barranquero <lekktu@gmail.com>
11620
11621 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11622 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11623 All callers changed.
11624
11625 * lisp.h (multibyte_char_to_unibyte):
11626 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11627 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11628 * character.h (CHAR_TO_BYTE8):
11629 * cmds.c (internal_self_insert):
11630 * editfns.c (general_insert_function):
11631 * keymap.c (push_key_description):
11632 * search.c (Freplace_match):
11633 * xdisp.c (message_dolog, set_message_1): All callers changed.
11634
f6d62986
SM
116352011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11636
11637 * keyboard.c (safe_run_hook_funcall): New function.
11638 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11639 don't set the hook to nil, but remove the offending function instead.
11640 (Qcommand_hook_internal): Remove, unused.
11641 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11642 Vcommand_hook_internal.
11643
11644 * eval.c (enum run_hooks_condition): Remove.
11645 (funcall_nil, funcall_not): New functions.
11646 (run_hook_with_args): Call each function through a `funcall' argument.
11647 Remove `cond' argument, now redundant.
11648 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11649 (Frun_hook_with_args_until_failure): Adjust accordingly.
11650 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11651
1db5b1ad
JB
116522011-03-28 Juanma Barranquero <lekktu@gmail.com>
11653
11654 * dispextern.h (string_buffer_position): Remove declaration.
11655
11656 * print.c (strout): Remove parameter `multibyte', unused since
11657 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11658
11659 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11660 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11661 All callers changed.
11662
11663 * w32.c (_wsa_errlist): Use braces for struct initializers.
11664
11665 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11666 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11667 All callers changed.
11668 (string_buffer_position): Likewise. Also, make static (it's never
11669 used outside xdisp.c).
11670 (cursor_row_p): Remove parameter `w', unused since
11671 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11672 (decode_mode_spec): Remove parameter `precision', introduced during
11673 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11674 All callers changed.
11675
5ffb62aa
JD
116762011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11677
11678 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11679
461c2ab9 116802011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11681
11682 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11683 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11684 (ns_update_auto_hide_menu_bar): New functions.
11685 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11686 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11687 ns_constrain_all_frames.
11688 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11689 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11690
5c380ffb
JD
116912011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11692
11693 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11694
9af30bdf
GM
116952011-03-27 Glenn Morris <rgm@gnu.org>
11696
11697 * syssignal.h: Replace RETSIGTYPE with void.
11698 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11699 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11700 Replace SIGTYPE with void everywhere.
11701 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11702 * s/template.h (SIGTYPE): Remove commented out definition.
11703
e2abce01
JB
117042011-03-26 Eli Zaretskii <eliz@gnu.org>
11705
11706 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11707 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11708
f868cd8a
JB
117092011-03-26 Juanma Barranquero <lekktu@gmail.com>
11710
59eb0929
JB
11711 * w32.c (read_unc_volume): Use parameter `henum', instead of
11712 global variable `wget_enum_handle'.
11713
11714 * keymap.c (describe_vector): Remove parameters `indices' and
11715 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11716 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11717
f868cd8a
JB
11718 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11719
11720 * keyboard.c (timer_check): Remove parameter `do_it_now',
11721 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11722 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11723 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11724
11725 * keyboard.c (read_char):
11726 * w32menu.c (w32_menu_display_help):
11727 * xmenu.c (show_help_event, menu_help_callback):
11728 Adjust calls to `show_help_echo'.
11729
11730 * gtkutil.c (xg_maybe_add_timer):
11731 * keyboard.c (readable_events):
11732 * process.c (wait_reading_process_output):
11733 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11734
11735 * insdel.c (adjust_markers_gap_motion):
11736 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11737 (gap_left, gap_right): Don't call it.
11738
2ecf6fdb
CY
117392011-03-25 Chong Yidong <cyd@stupidchicken.com>
11740
11741 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11742 incurred during fontification.
11743
6b1f9ba4
JB
117442011-03-25 Juanma Barranquero <lekktu@gmail.com>
11745
11746 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11747 (DEFVAR_PER_BUFFER): Don't pass it.
11748
11749 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11750 (scrolling_window): Don't pass it.
11751
0f4a96b5
JB
117522011-03-25 Juanma Barranquero <lekktu@gmail.com>
11753
11754 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11755
11756 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11757 and `suffix'.
11758 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11759 of variables specific to SELinux and computation of `encoded_absname'.
11760
11761 * image.c (XPutPixel): Remove unused variable `height'.
11762
11763 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11764
11765 * unexw32.c (get_section_info): Remove unused variable `section'.
11766
11767 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11768 (system_process_attributes): Remove unused variable `sess'.
11769 (sys_read): Remove unused variable `err'.
11770
11771 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11772 (w32_wnd_proc): Remove unused variable `isdead'.
11773 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11774 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11775 (x_create_tip_frame): Remove unused variable `tem'.
11776
11777 * w32inevt.c (w32_console_read_socket):
11778 Remove unused variable `no_events'.
11779
11780 * w32term.c (x_draw_composite_glyph_string_foreground):
11781 Remove unused variable `width'.
11782
1149507c
JB
117832011-03-24 Juanma Barranquero <lekktu@gmail.com>
11784
11785 * w32term.c (x_set_glyph_string_clipping):
11786 Don't pass uninitialized region to CombineRgn.
11787
9c88f339
JB
117882011-03-23 Juanma Barranquero <lekktu@gmail.com>
11789
11790 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11791 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11792 (Fx_close_connection): Remove unused variable `i'.
11793
11794 * w32font.c (w32font_draw): Return number of glyphs.
11795 (w32font_open_internal): Remove unused variable `i'.
11796 (w32font_driver): Add missing initializer.
11797
11798 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11799 (fill_in_menu): Remove unused variable `items_added'.
11800
11801 * w32term.c (last_mouse_press_frame): Remove static global variable.
11802 (w32_clip_to_row): Remove unused variable `f'.
11803 (x_delete_terminal): Remove unused variable `i'.
11804
11805 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11806 (NOTHING): Remove unused static global variable.
11807 (uniscribe_check_otf): Remove unused variable `table'.
11808 (uniscribe_font_driver): Add missing initializers.
11809
dee091a3
JD
118102011-03-23 Julien Danjou <julien@danjou.info>
11811
11812 * term.c (Fsuspend_tty, Fresume_tty):
11813 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11814 * window.c (temp_output_buffer_show):
11815 * insdel.c (signal_before_change):
11816 * frame.c (Fhandle_switch_frame):
11817 * fileio.c (Fdo_auto_save):
11818 * emacs.c (Fkill_emacs):
11819 * editfns.c (save_excursion_restore):
11820 * cmds.c (internal_self_insert):
11821 * callint.c (Fcall_interactively):
11822 * buffer.c (Fkill_all_local_variables):
11823 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11824 Use Frun_hooks.
0f4a96b5 11825 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11826 unconditionally since it does the check itself.
dee091a3 11827
2c520ab5 118282011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11829
c9c49752
PE
11830 Fix more problems found by GCC 4.5.2's static checks.
11831
8abc3f12
PE
11832 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11833 the first time through the loop, since we know p0 < p1 then.
11834 This also avoids a gcc -Wstrict-overflow warning.
11835
a2d26660
PE
11836 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11837 leading to a memory leak, possible in functions like
11838 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11839 of objects (Bug#8318).
a2d26660 11840
916c72e9
PE
11841 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11842 that could (at least in theory) be that large.
11843
19ab8a18
PE
11844 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11845 This is less likely to overflow, and avoids undefined behavior if
11846 overflow does occur. All callers changed. Use strtoul to scan
11847 for the unsigned long integer.
b7cbbd6f
PE
11848 (pint2hrstr): Simplify and tune code slightly.
11849 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11850
f0641eff
PE
11851 * scroll.c (do_scrolling): Work around GCC bug 48228.
11852 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11853
7f650bb9
PE
11854 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11855 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11856 (validate_x_resource_name): Simplify count usage.
11857 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11858
37dd57d1
PE
11859 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11860 fail (Bug#8306).
81e56e61 11861
699979fc 11862 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11863
401bf9b4
PE
11864 * process.c (Fmake_network_process): Use socklen_t, not int,
11865 where POSIX says socklen_t is required in portable programs.
11866 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11867 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11868 (Fmake_network_process, server_accept_connection):
11869 (wait_reading_process_output, read_process_output):
11870 Likewise.
11871
b93aacde
PE
11872 * process.c: Rename or move locals to avoid shadowing.
11873 (list_processes_1, Fmake_network_process):
11874 (read_process_output_error_handler, exec_sentinel_error_handler):
11875 Rename or move locals.
4dc343ee 11876 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11877 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11878 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11879 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11880 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11881
af8a867c 11882 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11883 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11884 Include tparam.h instead, since it declares them.
af8a867c
PE
11885 * cm.h (PC): Remove extern decl; tparam.h now does this.
11886 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11887 * terminfo.c: Include tparam.h, to check interfaces.
11888 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11889 (tparam): Adjust signature to match interface in tparam.h;
11890 this removes some undefined behavior. Check that outstring and len
11891 are zero, which they always are with Emacs.
11892 * tparam.h (PC, BC, UP): New extern decls.
11893
0248044d 11894 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11895 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11896
8ff096c1 11897 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11898 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11899 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11900 (ftfont_list): Remove unused local.
49eaafba
PE
11901 (get_adstyle_property, ftfont_pattern_entity):
11902 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11903 Rename locals to avoid shadowing.
8ff096c1 11904
e2be39f6
PE
11905 * xfont.c (xfont_list_family): Mark var as initialized.
11906
c9735e30
PE
11907 * xml.c (make_dom): Now static.
11908
8f5201ae
PE
11909 * composite.c (composition_compute_stop_pos): Rename local to
11910 avoid shadowing.
b246f932
PE
11911 (composition_reseat_it): Remove unused locals.
11912 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11913 (composition_update_it): Mark var as initialized.
11b61122
PE
11914 (find_automatic_composition): Mark vars as initialized,
11915 with a FIXME (Bug#8290).
8f5201ae 11916
760fbc2c
PE
11917 character.h: Rename locals to avoid shadowing.
11918 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11919 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11920 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11921 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11922 to avoid shadowing.
11923
ff08eb85
PE
11924 * textprop.c (property_change_between_p): Remove; unused.
11925
fc7bf025
PE
11926 * intervals.c (interval_start_pos): Now static.
11927
235d7abc
PE
11928 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11929
44f230aa
SM
11930 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11931 Rename locals to avoid shadowing.
3e7d6594 11932
50060332
PE
11933 * sound.c (wav_play, au_play, Fplay_sound_internal):
11934 Fix pointer signedness.
d01f234b 11935 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11936 (wav_play): Initialize a variable to 0, to prevent undefined
11937 behavior (Bug#8278).
50060332 11938
c4fc4e30
PE
11939 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11940
918436ed
PE
11941 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11942
c939f91b
PE
11943 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11944 clobbering (Bug#8298).
b9c7f648
PE
11945 * sysdep.c (sys_subshell): Likewise.
11946 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11947
6bd8c144
PE
11948 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11949 This should get cleaned up, so that child_setup has the
11950 same signature on all platforms.
11951
7710357c 11952 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11953 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11954
c59da222
CY
119552011-03-22 Chong Yidong <cyd@stupidchicken.com>
11956
11957 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11958 not to be necessary, and produces flickering.
11959
66b87493
GM
119602011-03-20 Glenn Morris <rgm@gnu.org>
11961
11962 * config.in: Remove file.
11963
45b6f6d5
JB
119642011-03-20 Juanma Barranquero <lekktu@gmail.com>
11965
11966 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11967 are now in src/globals.h.
11968 (syms_of_minibuf): Remove spurious & from previous change.
11969
cd394be1 119702011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11971
11972 * minibuf.c (completing-read-function): New variable.
11973 (completing-read-default): Rename from completing-read.
11974 (completing-read): Call completing-read-function.
11975
b14e3e21
CY
119762011-03-19 Juanma Barranquero <lekktu@gmail.com>
11977
11978 * xfaces.c (Fx_load_color_file):
11979 Read color file from absolute filename (bug#8250).
11980
f2b726e6
JB
119812011-03-19 Juanma Barranquero <lekktu@gmail.com>
11982
11983 * makefile.w32-in: Update dependencies.
11984
09f6ff02
EZ
119852011-03-17 Eli Zaretskii <eliz@gnu.org>
11986
11987 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11988
29a6015a
PE
119892011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11990
a3a6c54e
PE
11991 Fix more problems found by GCC 4.5.2's static checks.
11992
b766f867
PE
11993 * process.c (make_serial_process_unwind, send_process_trap):
11994 (sigchld_handler): Now static.
11995
be02381c
PE
11996 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11997 That way, the code declares only the vars that it needs.
11998 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11999 * s/cygwin.h (PTY_ITERATION): Likewise.
12000 * s/darwin.h (PTY_ITERATION): Likewise.
12001 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12002
57048744
PE
12003 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12004 * process.c (allocate_pty): Don't declare stb unless it's needed.
12005
7914961c 12006 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12007 (CONSTANTLIM): Remove; unused.
12008 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12009 Define only if needed.
7914961c 12010
b3967b18
PE
12011 * unexelf.c (unexec): Name an expression,
12012 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12013 Use a different way to cause a compilation error if anyone uses
12014 n rather than nn, a way that does not involve shadowing.
73366a00 12015 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12016
29a6015a
PE
12017 * deps.mk (unexalpha.o): Remove; unused.
12018
43cfc33e 12019 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12020 * unexec.h: New file.
ce701a33
PE
12021 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12022 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12023 Depend on unexec.h.
12024 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12025 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12026 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12027 Change as necessary to match prototype in unexec.h.
ce701a33 12028
01f44d5a
PE
12029 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12030 shadowing.
4f63c6bb 12031 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12032
a6670b0b
PE
12033 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12034 Rename locals to avoid shadowing.
12035
cef2010d 12036 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12037 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12038
d4d7173a
PE
12039 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12040
f08b802a
PE
12041 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12042 warning when compiling print.c.
12043
3ddb0639
PE
12044 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12045 instead of using an uninitialized var.
5ad03b97 12046 (font_sort_entities): Mark var as initialized.
3ddb0639 12047
170a2692
PE
12048 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12049
e663c700
PE
12050 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12051 pointers to constants.
89bc529a 12052 (font_parse_fcname): Remove unused vars.
7b81e2d0 12053 (font_delete_unmatched): Now static.
ea838e10 12054 (font_get_spec): Remove; unused.
13a547c6
PE
12055 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12056 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12057 Rename or move locals to avoid shadowing.
e663c700 12058
2a80c887 12059 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12060 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12061
1384fa33 12062 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12063 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12064
8b2c52e9
PE
12065 * alloc.c (mark_backtrace): Move decl from here ...
12066 * lisp.h: ... to here, so that it can be checked.
12067
475545b5 12068 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12069 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12070 (lisp_indirect_variable): Name an expression,
12071 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12072 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12073
b1349114 12074 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12075 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12076 Use const pointer when appropriate.
b1349114 12077
a2928364
PE
12078 * lisp.h (get_system_name, get_operating_system_release):
12079 Move decls here, to check interfaces.
12080 * process.c (get_operating_system_release): Move decl to lisp.h.
12081 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12082 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12083 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12084 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12085 (Fformat_time_string, Fencode_time, Finsert_char):
12086 (Ftranslate_region_internal, Fformat):
12087 Rename or remove local vars to avoid shadowing.
9710023e 12088 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12089
a415e694
PE
12090 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12091 avoid shadowing.
12092
8ef4622d
PE
12093 * lisp.h (eassert): Check that the argument compiles, even if
12094 ENABLE_CHECKING is not defined.
12095
946f9a5b
PE
12096 * data.c (Findirect_variable): Name an expression, to avoid
12097 gcc -Wbad-function-cast warning.
112396d6 12098 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12099 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12100 (Fmake_variable_buffer_local, Fmake_local_variable):
12101 Mark variables as initialized.
52746918 12102 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12103
e5aab7e7 12104 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12105 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12106 Rename locals to avoid shadowing.
dff45157
PE
12107 (mark_stack): Move local variables into the #ifdef region where
12108 they're used.
7bc26fdb
PE
12109 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12110 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12111 needed otherwise.
12112 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12113 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12114 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12115
e5aab7e7
PE
12116 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12117 avoids undefined behavior in theory.
12118
4da60324
PE
12119 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12120
88043301
PE
12121 Use functions, not macros, for up- and down-casing (Bug#8254).
12122 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12123 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12124 to use the following functions instead of these macros.
12125 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12126 EMACS_INT, since callers assume the returned value fits in int.
12127 (upcase1): Likewise, for UPCASE_TABLE.
12128 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12129 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12130 the race-condition problem in the old DOWNCASE.
88043301 12131
19ed5445
PE
12132 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12133 Rename locals to avoid shadowing.
12134 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12135 (regex_compile, re_search_2, re_match_2_internal):
12136 Remove unused local vars.
952db0d7
PE
12137 (FREE_VAR): Rewrite so as not to use empty "else",
12138 which gcc can warn about.
da053e48 12139 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12140 (RETALLOC_IF): Define only if needed.
12141 (WORDCHAR_P): Likewise. This one is never needed, but is used
12142 only in a comment talking about a compiler bug, so put inside
12143 the #if 0 of that comment.
12144 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12145 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12146 Remove; unused.
19ed5445 12147
1f3561e4 12148 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12149 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12150 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12151
ded6f8f7
PE
12152 * search.c (simple_search): Remove unused var.
12153
dbd37a95
PE
12154 * dired.c (compile_pattern): Move decl from here ...
12155 * lisp.h: ... to here, so that it can be checked.
12156 (struct re_registers): New forward decl.
12157
7e47afad
PE
12158 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12159
85f24f61
PE
12160 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12161 All uses changed.
12162 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12163 Rename locals to avoid shadowing.
5671df8f 12164 (Fvertical_motion): Mark locals as initialized.
85f24f61 12165
181aa2be 12166 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12167 (casify_region): Mark local as initialized.
181aa2be 12168
930d429c
PE
12169 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12170
7082eac6
PE
12171 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12172 New macros, so that the caller can use some names other than
12173 gcpro1, gcpro2, etc.
12174 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12175 of the new macros.
12176 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12177 argument, for consistency with GCPRO2_VAR, etc: it is now the
12178 prefix of the variable, not the variable itself. All uses
12179 changed.
38b2c076
PE
12180 * dired.c (directory_files_internal, file_name_completion):
12181 Rename locals to avoid shadowing.
12182
15206ed9
PE
12183 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12184 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12185 dired.c's scmp function, had undefined behavior.
12186 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12187 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12188 * buffer.h: ... to here, because these macros use current_buffer,
12189 and the new implementation with inline functions needs to have
12190 current_buffer in scope now, rather than later when the macros
12191 are used.
12192 (downcase, upcase1): New static inline functions.
12193 (DOWNCASE, UPCASE1): Reimplement using these functions.
12194 This avoids undefined behavior in expressions like
12195 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12196 from race conditions in accessing the global variables
12197 case_temp1 and case_temp2.
12198 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12199 * lisp.h (case_temp1, case_temp2): Remove their decls.
12200 * character.h (ASCII_CHAR_P): Move from here ...
12201 * lisp.h: ... to here, so that the inline functions mentioned
12202 above can use them.
12203
4a6bea26
PE
12204 * dired.c (directory_files_internal_unwind): Now static.
12205
f14b7e14
PE
12206 * fileio.c (file_name_as_directory, directory_file_name):
12207 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12208 Now static.
2893f146
PE
12209 (file_name_as_directory): Use const pointers when appropriate.
12210 (Fexpand_file_name): Likewise. In particular, newdir might
12211 point at constant storage, so make it a const pointer.
fd4ead52 12212 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12213 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12214 signedness issues.
f839df0c
PE
12215 (Fset_file_times, Finsert_file_contents, auto_save_error):
12216 Rename locals to avoid shadowing.
f14b7e14 12217
5716756e 12218 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12219 (Ftry_completion, Fall_completions): Rename or remove locals
12220 to avoid shadowing.
5716756e 12221
b4c3046a
PE
12222 * marker.c (bytepos_to_charpos): Remove; unused.
12223
b45db522
PE
12224 * lisp.h (verify_bytepos, count_markers): New decls,
12225 so that gcc does not warn that these functions aren't declared.
12226
85876d07
PE
12227 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12228 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12229 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12230 (copy_text): Remove unused local var.
85876d07 12231
03d78a21 12232 * filelock.c (within_one_second): Now static.
b3dd38ab 12233 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12234
5df8f01b
PE
12235 * buffer.c (fix_overlays_before): Mark locals as initialized.
12236 (fix_start_end_in_overlays): Likewise. This function should be
12237 simplified by using pointers-to-pointers, but that's a different
12238 matter.
b1d876f1 12239 (switch_to_buffer_1): Now static.
8f54f30a
PE
12240 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12241 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12242
a70072c9 12243 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12244 Fix pointer signedness issue.
edced198
PE
12245 (sys_subshell): Mark local as volatile if checking for lint,
12246 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12247 (MAXPATHLEN): Define only if needed.
a70072c9 12248
a0977c44
PE
12249 * process.c (serial_open, serial_configure): Move decls from here ...
12250 * systty.h: ... to here, so that they can be checked.
12251
a884fdcc
PE
12252 * fns.c (get_random, seed_random): Move extern decls from here ...
12253 * lisp.h: ... to here, so that they can be checked.
12254
604efe86 12255 * sysdep.c (reset_io): Now static.
b8950c94 12256 (wait_for_termination_signal): Remove; unused.
604efe86 12257
38fc62d9
PE
12258 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12259 (copy_keymap_item, append_key, push_text_char_description):
12260 Now static.
1004a21a 12261 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12262 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12263 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12264 (describe_map_tree):
12265 Rename locals to avoid shadowing.
38fc62d9 12266
2f2650da
PE
12267 * keyboard.c: Declare functions static if they are not used elsewhere.
12268 (echo_char, echo_dash, cmd_error, top_level_2):
12269 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12270 (read_char, kbd_buffer_get_event, make_lispy_position):
12271 (make_lispy_event, make_lispy_movement, apply_modifiers):
12272 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12273 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12274 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12275 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12276 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12277
a053e86c 12278 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12279 (mark_kboards): Move decl here ...
12280 * alloc.c (mark_kboards): ... from here.
a053e86c 12281
4752793e
PE
12282 * lisp.h (force_auto_save_soon): New decl.
12283
74f10ca7 12284 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12285 (DEFINE_DUMMY_FUNCTION): New macro.
12286 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12287 Use it.
c03cd23f
PE
12288 (main): Add casts to avoid warnings
12289 if GCC considers string literals to be constants.
74f10ca7 12290
022e70d4
PE
12291 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12292
59d6fe83
PE
12293 * dbusbind.c: Pointer signedness fixes.
12294 (xd_signature, xd_append_arg, xd_initialize):
12295 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12296 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12297 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12298 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12299
78320123
PE
12300 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12301 if GCC considers string literals to be constants.
49cebcca 12302 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12303
35ac2a97
SM
123042011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12305
fb103ca9
SM
12306 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12307 (print_preprocess, print_object): New macro to fix last change.
12308
35ac2a97
SM
12309 * print.c (print_preprocess): Don't forget font objects.
12310
62973b41
JB
123112011-03-16 Juanma Barranquero <lekktu@gmail.com>
12312
12313 * emacs.c (USAGE3): Doc fixes.
12314
0e48bb22
AS
123152011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12316
12317 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12318 structure.
12319
7684e57b
JB
123202011-03-14 Juanma Barranquero <lekktu@gmail.com>
12321
12322 * lisp.h (VWindow_system, Qfile_name_history):
12323 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12324 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12325 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12326
12327 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12328 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12329
12330 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12331 * w32console.c (detect_input_pending, read_input_pending)
12332 (encode_terminal_code):
12333 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12334 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12335 (w32_system_caret_y, Qfile_name_history):
12336 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12337 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12338 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12339 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12340 * w32proc.c (Qlocal, report_file_error):
12341 * w32term.c (Vwindow_system, updating_frame):
12342 * w32uniscribe.c (initialized, uniscribe_font_driver):
12343 Remove unneeded extern declarations.
12344
2aa46d6c
CY
123452011-03-14 Chong Yidong <cyd@stupidchicken.com>
12346
c96bbc66 12347 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12348
cffc6f3b
CY
123492011-03-13 Chong Yidong <cyd@stupidchicken.com>
12350
12351 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12352 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12353 These macros can no longer be used for assignment.
12354
44f230aa
SM
12355 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12356 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12357 (record_buffer_markers, fetch_buffer_markers): New functions for
12358 recording and fetching special buffer markers.
12359 (set_buffer_internal_1, set_buffer_temp): Use them.
12360
12361 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12362
12363 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12364
12365 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12366 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12367
12368 * xdisp.c (hscroll_window_tree):
12369 (reconsider_clip_changes): Use PT instead of BUF_PT.
12370
d251f04b
EZ
123712011-03-13 Eli Zaretskii <eliz@gnu.org>
12372
12373 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12374 $(EMACS_ROOT)/lib/intprops.h.
12375
f0c77cd1
PE
123762011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12377
3eca4629
PE
12378 Fix more problems found by GCC 4.5.2's static checks.
12379
7c86ee98
PE
12380 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12381 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12382 (xg_free_frame_widgets): Make it clear that a local variable is
12383 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12384 (gdk_window_get_screen): Make it clear that this macro is needed
12385 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12386 (int_gtk_range_get_value): New function, which avoids a diagnostic
12387 from gcc -Wbad-function-cast.
12388 (xg_set_toolkit_scroll_bar_thumb): Use it.
12389 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12390 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12391 (get_utf8_string, xg_get_file_with_chooser):
12392 Rename locals to avoid shadowing.
12393 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12394
41729b81
PE
12395 * xgselect.c (xg_select): Remove unused var.
12396
f0c77cd1
PE
12397 * image.c (four_corners_best): Mark locals as initialized.
12398 (gif_load): Initialize transparent_p to zero (Bug#8238).
12399 Mark another local as initialized.
ec6cf4c6 12400 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12401
ce0ad53d 12402 * image.c (clear_image_cache): Now static.
d5d5a617 12403 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12404 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12405 (x_edge_detection): Remove unnecessary cast that
12406 gcc -Wbad-function-cast diagnoses.
2037898d 12407 (gif_load): Fix pointer signedness.
6ae141d6
PE
12408 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12409 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12410
33383987 124112011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12412
d32df629
PE
12413 Improve quality of tests for time stamp overflow.
12414 For example, without this patch (encode-time 0 0 0 1 1
12415 1152921504606846976) returns the obviously-bogus value (-948597
12416 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12417 reports time overflow. See
12418 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12419 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12420 * editfns.c: Include limits.h and intprops.h.
12421 (TIME_T_MIN, TIME_T_MAX): New macros.
12422 (time_overflow): Move earlier, to before first use.
12423 (hi_time, lo_time): New functions, for an accurate test for
12424 out-of-range times.
12425 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12426 (Fget_internal_run_time): Don't assume time_t fits in int.
12427 (make_time): Use list2 instead of Fcons twice.
12428 (Fdecode_time): More accurate test for out-of-range times.
12429 (check_tm_member): New function.
12430 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12431 (lisp_time_argument): Don't rely on undefined left-shift and
12432 right-shift behavior when checking for time stamp overflow.
8be6f318 12433
fe31d94c
PE
12434 * editfns.c (time_overflow): New function, refactoring common code.
12435 (Fformat_time_string, Fdecode_time, Fencode_time):
12436 (Fcurrent_time_string): Use it.
12437
8be6f318
PE
12438 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12439 * dired.c (make_time): Move to ...
12440 * editfns.c (make_time): ... here.
12441 * systime.h: Note the move.
12442
09d9db2c 124432011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12444
126bc0dc
YM
12445 * fringe.c (update_window_fringes): Remove unused variables.
12446
c47cbdfd
YM
12447 * unexmacosx.c (copy_data_segment): Also copy __got section.
12448 (Bug#8223)
12449
7ac80be9
EZ
124502011-03-12 Eli Zaretskii <eliz@gnu.org>
12451
c96bbc66 12452 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12453 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12454 Constify `char *' arguments and their references according to
12455 prototypes in tparam.h.
12456
ecb0f94d 12457 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12458
7ac80be9
EZ
12459 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12460 Adapt all references accordingly.
12461
12462 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12463
ef1fd07e
TT
124642011-03-11 Tom Tromey <tromey@redhat.com>
12465
12466 * buffer.c (syms_of_buffer): Remove obsolete comment.
12467
7ef4b50c
EZ
124682011-03-11 Eli Zaretskii <eliz@gnu.org>
12469
12470 * termhooks.h (encode_terminal_code): Declare prototype.
12471
12472 * msdos.c (encode_terminal_code): Don't declare prototype.
12473
12474 * term.c (encode_terminal_code): Now external again, used by
12475 w32console.c and msdos.c.
12476
44f230aa
SM
12477 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12478 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12479
4b1ec863 124802011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12481
1714f52b 12482 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12483
4b1ec863
PE
12484 * fringe.c (update_window_fringes): Mark locals as initialized
12485 (Bug#8227).
12486 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12487
524c7aa6
PE
12488 * alloc.c (mark_fringe_data): Move decl from here ...
12489 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12490 to check its interface.
12491 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12492
a5c0af81 12493 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12494 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12495 (fontset_font): Mark local as initialized.
a9a06e0b 12496 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12497
b4716021
PE
12498 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12499
811e9bac 12500 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12501 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12502 (x_own_selection, Fx_disown_selection_internal): Rename locals
12503 to avoid shadowing.
12504 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12505
7e3ab302
PE
12506 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12507 so that the caller can use some name other than gcpro1.
12508 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12509 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12510 (Fx_backspace_delete_keys_p):
12511 Use them to avoid shadowing, and rename vars to avoid shadowing.
12512 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12513 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12514 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12515 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12516 Remove unused locals.
7e3ab302
PE
12517 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12518 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12519 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12520 macros.
f78faa98 12521
e2b13473
PE
12522 * xterm.h (x_mouse_leave): New decl.
12523
77f23912
PE
12524 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12525 Remove unused functions.
cdf4ba58
PE
12526 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12527 (x_calc_absolute_position): Now static.
7411c686 12528 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12529 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12530 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12531 unless they are used.
38d0b34a
PE
12532 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12533 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12534 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12535 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12536 (x_error_catcher, x_connection_closed, x_error_handler):
12537 (x_error_quitter, xembed_send_message, x_iconify_frame):
12538 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12539 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12540 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12541
44f230aa
SM
12542 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12543 Rename or move locals to avoid shadowing.
6b463e58 12544 (tty_defined_color, merge_face_heights): Now static.
5967d051 12545 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12546 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12547 does not deduce is never used uninitialized.
73719eba
PE
12548 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12549 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12550
426994c3 12551 * terminal.c (store_terminal_param): Now static.
5489860b 12552
032f1620 12553 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12554 (set_frame_menubar): Remove unused local.
d4323972 12555 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12556 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12557 since they might point to immutable storage.
281585b0
PE
12558 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12559 since it's unused otherwise.
032f1620 12560
367c19e5 12561 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12562 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12563 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12564 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12565 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12566 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12567 does not deduce are never used uninitialized.
70739cbe 12568
07b48fa9
PE
12569 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12570
8868a238 12571 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12572 * window.c (window_loop, size_window):
12573 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12574
7e5cf297 12575 * window.c (display_buffer): Now static.
d6550a9f
PE
12576 (size_window): Mark variables that gcc -Wuninitialized
12577 does not deduce are never used uninitialized.
a586633d
PE
12578 * window.h (check_all_windows): New decl, to forestall
12579 gcc -Wmissing-prototypes diagnostic.
5b555da1 12580 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12581
f6095868
PE
12582 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12583 shadowing.
12584 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12585 Include <limits.h>.
12586 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12587 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12588 (load_charset_map): Mark variables that gcc -Wuninitialized
12589 does not deduce are never used uninitialized.
53df7c11 12590 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12591
f38b440c
PE
12592 * coding.c (coding_set_source, coding_set_destination):
12593 Use "else { /* comment */ }" rather than "else /* comment */;"
12594 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12595 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12596 a block, when the outer 'i' will do.
12597 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12598 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12599 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12600 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12601 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12602 Rename locals to avoid shadowing.
12603 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12604 * coding.c (emacs_mule_char, encode_invocation_designation):
12605 Now static, since they're not used elsewhere.
413bb2db 12606 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12607 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12608 (decode_coding_emacs_mule): Mark variables that gcc
12609 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12610 (detect_coding_iso_2022): Initialize a local variable that might
12611 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12612 this initialization is needed. (Bug#8211)
5f58e762
PE
12613 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12614 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12615 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12616 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12617 Remove unused macros.
f38b440c 12618
232b38b9 12619 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12620 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12621 * character.c (string_count_byte8): Likewise.
232b38b9 12622
fb90da1b
PE
12623 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12624 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12625
fb93dbc2
PE
12626 * chartab.c (copy_sub_char_table): Now static, since it's not used
12627 elsewhere.
5c156ace
PE
12628 (sub_char_table_ref_and_range, char_table_ref_and_range):
12629 Rename locals to avoid shadowing.
bbcd0949 12630 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12631
7d3b3862 12632 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12633 (BIDI_BOB): Remove unused macro.
7d3b3862 12634
6be7d3da
PE
12635 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12636 deduce are never used uninitialized.
c2ed9c8b 12637 * term.c (encode_terminal_code): Likewise.
6be7d3da 12638
75f8807f 12639 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12640
50938595
PE
12641 * tparam.h: New file.
12642 * term.c, tparam.h: Include it.
12643 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12644 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12645 Move these decls to tparam.h, and make them agree with what
12646 is actually in tparam.c. The previous trick of using incompatible
12647 decls in different modules does not conform to the C standard.
12648 All callers of tparam changed to use tparam's actual API.
12649 * tparam.c (tparam1, tparam, tgoto):
12650 Use const pointers where appropriate.
12651
fbceeba2
PE
12652 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12653 * cm.h (struct cm): Likewise.
12654 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12655 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12656 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12657 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12658 (turn_on_face, init_tty): Likewise.
12659 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12660
7f3f1250
PE
12661 * term.c (term_mouse_position): Rename local to avoid shadowing.
12662
e6ca6543
PE
12663 * alloc.c (mark_ttys): Move decl from here ...
12664 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12665
c40f8d15
AS
126662011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12667
12668 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12669
cfe0661d
JB
126702011-03-09 Juanma Barranquero <lekktu@gmail.com>
12671
12672 * search.c (compile_pattern_1): Remove argument regp, unused since
12673 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12674 (compile_pattern): Don't pass it.
12675
0afb4571
J
126762011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12677
12678 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12679 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12680 for ! HAVE_GTK3.
12681 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12682
12683 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12684
12685 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12686 gdk_window_get_screen, gdk_window_get_geometry,
12687 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12688 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12689 (xg_get_pixbuf_from_pixmap): New function.
12690 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12691 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12692 Call xg_get_pixbuf_from_pixmap instead of
12693 gdk_pixbuf_get_from_drawable.
12694 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12695 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12696 (xg_check_special_colors): Use GtkStyleContext and its functions
12697 for HAVE_GTK3.
12698 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12699 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12700 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12701 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12702 Call gtk_widget_get_preferred_size.
0afb4571
J
12703 (xg_frame_resized): gdk_window_get_geometry only takes 5
12704 parameters.
44f230aa
SM
12705 (xg_win_to_widget, xg_event_is_for_menubar):
12706 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12707 (xg_set_widget_bg): New function.
12708 (delete_cb): New function.
895009e1 12709 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12710 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12711 (xg_set_background_color): Call xg_set_widget_bg.
12712 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12713 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12714 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12715 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12716 if ! HAVE_GTK3.
12717 (update_frame_tool_bar): Call gtk_widget_hide.
12718 (xg_initialize): Use GDK_KEY_g.
12719
12720 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12721 if ! HAVE_GTK3
12722 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12723
12724 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12725 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12726 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12727
1c2cc4ef
JB
127282011-03-08 Juanma Barranquero <lekktu@gmail.com>
12729
12730 * w32xfns.c (select_palette): Check success of RealizePalette against
12731 GDI_ERROR, not zero.
12732
33383987 12733See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12734
12735;; Local Variables:
12736;; coding: utf-8
aac0c6e3
MR
12737;; End:
12738
2f097256 12739 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12740
12741 This file is part of GNU Emacs.
12742
12743 GNU Emacs is free software: you can redistribute it and/or modify
12744 it under the terms of the GNU General Public License as published by
12745 the Free Software Foundation, either version 3 of the License, or
12746 (at your option) any later version.
12747
12748 GNU Emacs is distributed in the hope that it will be useful,
12749 but WITHOUT ANY WARRANTY; without even the implied warranty of
12750 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12751 GNU General Public License for more details.
12752
12753 You should have received a copy of the GNU General Public License
12754 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.