* termhooks.h (struct terminal): Likewise.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4887c6e2 12011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2
90efadd1
PE
3 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4 by pacifying GCC about it. Maybe it's time to retire it?
5
3c647824
PE
6 * dispextern.h (struct redisplay_interface): Rename param
7 to avoid shadowing.
e264f262 8 * termhooks.h (struct terminal): Likewise.
3c647824 9
b58c5c4a
PE
10 * insdel.c (make_gap_smaller): Define only if
11 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12
cad59032
PE
13 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
14 it.
15
c339dc2e
PE
16 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
17 so that we aren't warned about unused symbols.
18
91a3e27b
PE
19 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
20
94578f9c
PE
21 * xdisp.c (x_produce_glyphs): Avoid possibly-uninitialized
22 var (Bug#8512).
7a3fb125 23
8ffc96f5
PE
24 * xfns.c (x_real_positions): Mark locals as initialized.
25
eef9bc79
PE
26 * xmenu.c (xmenu_show): Don't use uninitialized vars.
27
098db9dd
PE
28 * xterm.c: Fix problems found by static analysis with other toolkits.
29 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
30 (x_dispatch_event): Declare static if USE_GTK, and
31 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 32 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 33 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
098db9dd
PE
34 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
35 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
36
eb18f6cc
PE
37 * xmenu.c (menu_help_callback): Pointer type fixes.
38 Use const pointers when pointing at readonly data. Avoid pointer
39 signedness clashes.
40 (FALSE): Remove unused macro.
41 (update_frame_menubar): Remove unused decl.
42
1fe72bf8
PE
43 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
44
60d9e1db
PE
45 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
46 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
47 (single_menu_item): Rename local to avoid shadowing.
48
39261c26
PE
49 * keyboard.c (make_lispy_event): Remove unused local var.
50
018c5e19
PE
51 * frame.c, frame.h (x_get_resource_string): Bring this back, but
52 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
53
63d2b86e
PE
54 * bitmaps: Change bitmaps from unsigned char back to the X11
55 compatible char. Avoid the old compiler warnings about
56 out-of-range initializers by using, for example, '\xab' rather
57 than 0xab.
58
aefd87e1
PE
59 * xgselect.c (xgselect_initialize): Check vs interface
60 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
61
bf501fb9
PE
62 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
63
e9829fdf
PE
64 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
65 to read-only memory.
66
1086c095
PE
67 * fns.c (vector): Remove; this old hack is no longer needed.
68
2baccd04 69 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 70 Remove unused var.
dde42981 71 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 72
72391843 73 * xrdb.c (x_load_resources): Omit unused local.
3565b346 74
436c16df 75 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 76 (x_window): Rename locals to avoid shadowing.
dc5ddd85 77 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 78
92bb796d 79 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 80 (x_term_init): Remove local to avoid shadowing.
92bb796d 81
764430a3 82 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
83
84 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
85 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
86
4170f62f 872011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 88
71b41406
PE
89 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
90
9587a89d
PE
91 emacs_write: Accept and return EMACS_INT for sizes.
92 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
93 et seq.
94 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
95 Accept and return EMACS_INT.
96 (emacs_gnutls_write): Return the number of bytes written on
97 partial writes.
98 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
99 (emacs_read, emacs_write): Remove check for negative size, as the
100 Emacs source code has been audited now.
9587a89d
PE
101 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
102 (emacs_read, emacs_write): Use it.
273a5f82
PE
103 * process.c (send_process): Adjust to the new signatures of
104 emacs_write and emacs_gnutls_write. Do not attempt to store
105 a byte offset into an 'int'; it might overflow.
9587a89d 106 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 107
3e047f51
PE
108 * sound.c: Don't assume sizes fit in 'int'.
109 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 110 Return EMACS_INT, not int.
3e047f51 111 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
112 Accept EMACS_INT, not int.
113 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
114 record read return values.
115
cc39a9db
BK
1162011-04-15 Ben Key <bkey76@gmail.com>
117
118 * keyboard.c (Qundefined): Don't declare static since it is
119 used in nsfns.m.
120 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't
121 declare static since they are used in nsfont.m.
122
6c60eb9f
SM
1232011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
124
125 * process.c (Qprocessp): Don't declare static.
126 * lisp.h (Qprocessp): Declare again.
127
7990b61a
JB
1282011-04-15 Juanma Barranquero <lekktu@gmail.com>
129
130 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
131
5d4cb038
PE
1322011-04-14 Paul Eggert <eggert@cs.ucla.edu>
133
8bd7b830 134 Improve C-level modularity by making more things 'static'.
cd64ea1d 135
e3b27b31
PE
136 Don't publish debugger-only interfaces to other modules.
137 * lisp.h (safe_debug_print, debug_output_compilation_hack):
138 (verify_bytepos, count_markers): Move decls to the only modules
139 that need them.
140 * region-cache.h (pp_cache): Likewise.
141 * window.h (check_all_windows): Likewise.
142 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
143
5d4cb038
PE
144 * sysdep.c (croak): Now static, if
145 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
146 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
147
148 * alloc.c (refill_memory_reserve): Now static if
149 !defined REL_ALLOC || defined SYSTEM_MALLOC.
150 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 151
e87b6180
PE
152 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
153 Define only if USE_LUCID.
154
ac64929e
PE
155 * xrdb.c (x_customization_string, x_rm_string): Now static.
156
6f37259d
PE
157 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
158 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
159
1683e3ab
PE
160 * xdisp.c (draw_row_with_mouse_face): Now static.
161 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
162
de9c2632
PE
163 * window.h (check_all_windows): Mark externally visible.
164
2b96acb7
PE
165 * window.c (window_deletion_count): Now static.
166
167 * undo.c: Make symbols static if they're not exported.
168 (last_undo_buffer, last_boundary_position, pending_boundary):
169 Now static.
170
50436f33
PE
171 * textprop.c (interval_insert_behind_hooks): Now static.
172 (interval_insert_in_front_hooks): Likewise.
173
64520e5c
PE
174 * term.c: Make symbols static if they're not exported.
175 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
176 (max_frame_lines, tty_set_terminal_modes):
177 (tty_reset_terminal_modes, tty_turn_off_highlight):
178 (get_tty_terminal): Now static.
179 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
180 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 181 HAVE_WINDOW_SYSTEM.
64520e5c
PE
182 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
183 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
184
1fa53021
PE
185 * sysdep.c: Make symbols static if they're not exported.
186 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
187 Now static.
188 (sigprocmask_set, full_mask): Remove; unused.
189 (wait_debugging): Mark as visible.
190 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
191 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
192
d4b43b22
PE
193 * syntax.c (syntax_temp): Define only if !__GNUC__.
194
b7c513d0
PE
195 * sound.c (current_sound_device, current_sound): Now static.
196
989b29ad
PE
197 * search.c (searchbufs, searchbuf_head): Now static.
198
13a55a78
PE
199 * scroll.c (scroll_cost): Remove; unused.
200 * dispextern.h (scroll_cost): Remove decl.
201
de68a1fc
PE
202 * region-cache.h (pp_cache): Mark as externally visible.
203
40ccffa6
PE
204 * process.c: Make symbols static if they're not exported.
205 (process_tick, update_tick, create_process, chan_process):
206 (Vprocess_alist, proc_buffered_char, datagram_access):
207 (fd_callback_data, send_process_frame, process_sent_to): Now static.
208 (deactivate_process): Mark defn as static, as well as decl.
209 * lisp.h (create_process): Remove decl.
210 * process.h (chan_process, Vprocess_alist): Remove decls.
211
ad64fc97
PE
212 * print.c: Make symbols static if they're not exported.
213 (print_depth, new_backquote_output, being_printed, print_buffer):
214 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
215 (print_interval, print_number_index, initial_stderr_stream):
216 Now static.
217 * lisp.h (Fprinc): Remove decl.
218 (debug_output_compilation_hack): Mark as externally visible.
219
adddb265
PE
220 * sysdep.c (croak): Move decl from here to syssignal.h.
221 * syssignal.h (croak): Put it here, so the API can be checked when
222 'croak' is called from dissociate_if_controlling_tty.
223
1717ede2
PE
224 * minibuf.c: Make symbols static if they're not exported.
225 (minibuf_save_list, choose_minibuf_frame): Now static.
226 * lisp.h (choose_minibuf_frame): Remove decl.
227
fa5fb2bc
PE
228 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
229
1e3890d1
PE
230 * lread.c: Make symbols static if they're not exported.
231 (read_objects, initial_obarray, oblookup_last_bucket_number):
232 Now static.
233 (make_symbol): Remove; unused.
234 * lisp.h (initial_obarray, make_symbol): Remove decls.
235
8a1414fa
PE
236 * keyboard.c: Make symbols static if they're not exported.
237 (single_kboard, recent_keys_index, total_keys, recent_keys):
238 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
239 (this_single_command_key_start, echoing, last_auto_save):
240 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
241 (command_loop, echo_now, keyboard_init_hook, help_char_p):
242 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
243 (Vlispy_mouse_stem, double_click_count):
244 Now static.
245 (force_auto_save_soon): Define only if SIGDANGER.
246 (ignore_mouse_drag_p): Now static if
247 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
248 (print_help): Remove; unused.
249 (stop_character, last_timer_event): Mark as externally visible.
250 * keyboard.h (ignore_mouse_drag_p): Declare only if
251 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
252 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
253 * lisp.h (echoing): Remove decl.
254 (force_auto_save_soon): Declare only if SIGDANGER.
255 * xdisp.c (redisplay_window): Simplify code, to make it more
256 obvious that ignore_mouse_drag_p is not accessed if !defined
257 USE_GTK && !defined HAVE_NS.
258
93ea6e8f
PE
259 * intervals.c: Make symbols static if they're not exported.
260 (merge_properties_sticky, merge_interval_right, delete_interval):
261 Now static.
262 * intervals.h (merge_interval_right, delete_interval): Remove decls.
263
77382fcc
PE
264 * insdel.c: Make symbols static if they're not exported.
265 However, leave prepare_to_modify_buffer alone. It's never
266 called from outside this function, but that appears to be a bug.
267 (combine_after_change_list, combine_after_change_buffer):
4889fc82 268 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
269 (adjust_after_replace_noundo): Remove; unused.
270 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 271 (signal_before_change): Remove decls.
77382fcc 272
9306c32e
PE
273 * indent.c (val_compute_motion, val_vmotion): Now static.
274
cd44d2eb
PE
275 * image.c: Make symbols static if they're not exported.
276 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
277 if USE_GTK.
278 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
279 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
280
ad9a7a06
PE
281 * fringe.c (standard_bitmaps): Now static.
282 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
283
81626931
PE
284 * frame.c: Make symbols static if they're not exported.
285 (x_report_frame_params, make_terminal_frame): Now static.
286 (get_frame_param): Now static, unless HAVE_NS.
287 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
288 (x_get_resource_string): Remove; not used.
289 * frame.h (make_terminal_frame, x_report_frame_params):
290 (x_get_resource_string); Remove decls.
291 (x_fullscreen_adjust): Declare only if WINDOWSNT.
292 * lisp.h (get_frame_param): Declare only if HAVE_NS.
293
239f9db9
PE
294 * font.c, fontset.c: Make symbols static if they're not exported.
295 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
296 (FACE_SUITABLE_FOR_CHAR_P): Use it.
297 * font.c (font_close_object): Now static.
298 * font.h (font_close_object): Remove.
299 * fontset.c (FONTSET_OBJLIST): Remove.
300 (free_realized_fontset) #if-0 the body, which does nothing.
301 (face_suitable_for_char_p): #if-0, as it's never called.
302 * fontset.h (face_suitable_for_char_p): Remove decl.
303 * xfaces.c (face_at_string_position): Use
304 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
305 since 0 is always ASCII.
306
dfcf3579
PE
307 * fns.c (weak_hash_tables): Now static.
308
5045092b
PE
309 * fileio.c: Make symbols static if they're not exported.
310 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
311 (Vwrite_region_annotation_buffers): Now static.
312
57a96f5c
PE
313 * eval.c: Make symbols static if they're not exported.
314 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
315 * lisp.h (backtrace_list): Remove decl.
316
35f08c38
PE
317 * emacs.c: Make symbols static if they're not exported.
318 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
319 (fatal_error_code, fatal_error_signal_hook, standard_args):
320 Now static.
321 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
322 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
323 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
324 * lisp.h (fatal_error_signal_hook): Remove decl.
325 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
326
f44bd759
PE
327 * editfns.c: Move a (normally-unused) function to its only use.
328 * editfns.c, lisp.h (get_operating_system_release): Remove.
329 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
330 worth the hassle of breaking this out.
331
b532497d
PE
332 * xterm.c: Make symbols static if they're not exported.
333 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
334 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
335 (x_destroy_window, x_delete_display):
336 Now static.
337 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
338 (x_mouse_leave): Remove; unused.
339 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
340 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
341 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
342 Remove decls.
343 (x_mouse_leave): Declare only if WINDOWSNT.
344 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
345 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
346 USE_X_TOOLKIT.
347
1675728f
PE
348 * ftxfont.c: Make symbols static if they're not exported.
349 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
350 HAVE_FREETYPE.
351 * font.h (ftxfont_driver): Likewise.
352
e4cebfca
PE
353 * xfns.c: Make symbols static if they're not exported.
354 (x_last_font_name, x_display_info_for_name):
355 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
356 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
357 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
358 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
359 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
360 (last_show_tip_args): Now static.
361 (xic_defaut_fontset, xic_create_fontsetname): Define only if
362 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
363 (x_screen_planes): Remove; unused.
364 * dispextern.h (x_screen_planes): Remove decl.
365
5bf46f05
PE
366 * dispnew.c: Make symbols static if they're not exported.
367 * dispextern.h (redraw_garbaged_frames, scrolling):
368 (increment_row_positions): Remove.
369 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
370 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
371 Now static.
372 (redraw_garbaged_frames): Remove; unused.
373
435f4c28
PE
374 * xfaces.c: Make symbols static if they're not exported.
375 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
376 Remove decls.
377 * xterm.h (defined_color): Remove decls.
378 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
379 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
380 (menu_face_changed_default, defined_color, free_realized_face):
381 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
382 (ascii_face_of_lisp_face): Remove; unused.
383
8524aef3
PE
384 * xdisp.c: Make symbols static if they're not exported.
385 * dispextern.h (scratch_glyph_row, window_box_edges):
386 (glyph_to_pixel_coords, set_cursor_from_row):
387 (get_next_display_element, set_iterator_to_next):
388 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
389 (show_mouse_face): Remove decls
390 * frame.h (message_buf_print): Likewise.
391 * lisp.h (pop_message, set_message, check_point_in_composition):
392 Likewise.
393 * xterm.h (set_vertical_scroll_bar): Likewise.
394 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
395 (message_buf_print, scratch_glyph_row, displayed_buffer):
396 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
397 (get_next_display_element, show_mouse_face, window_box_edges):
398 (frame_to_window_pixel_xy, check_point_in_composition):
399 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
400 (glyph_to_pixel_coords): Remove; unused.
401
16390cd2
PE
402 * dired.c (file_name_completion): Now static.
403
404 * dbusbind.c (xd_in_read_queued_messages): Now static.
405
a25f4dfa
PE
406 * lisp.h (circular_list_error, FOREACH): Remove; unused.
407 * data.c (circular_list_error): Remove.
408
14a9c8df
PE
409 * commands.h (last_point_position, last_point_position_buffer):
410 (last_point_position_window): Remove decls.
411 * keyboard.c: Make these variables static.
412
74ab6df5
PE
413 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
414 decls.
415 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
416 (iso_code_class, detect_coding, code_convert_region): Now static.
417 (encode_coding_gap): Remove; unused.
418
38dfbee1
PE
419 * chartab.c (chartab_chars, chartab_bits): Now static.
420
a2cb4e63
PE
421 * charset.h (charset_iso_8859_1): Remove decl.
422 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
423 Now static.
424
127198fd
PE
425 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
426 * ccl.c (Vccl_program_table): Now static.
427 (check_ccl_update): Remove; unused.
428
d85b608f
PE
429 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
430 * category.h: ... from here.
431 * category.c (check_category_table, set_category_set): Now static.
432
31cd66f3
PE
433 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
434 * lisp.h: Remove these decls.
435
c358e587
PE
436 * buffer.c (buffer_count): Remove unused var.
437
e78aecca
PE
438 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
439 so that it's not optimized away.
440 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
441 * dispextern.h (bidi_dump_cached_states): Remove, since it's
442 exported only to the debugger.
443
e192d7d3
PE
444 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
445 * atimer.h (run_all_atimers): Removed; not exported.
446
92470028
PE
447 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
448 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
449 was inaccessible from Lisp.
450 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
451 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
452
244ed907
PE
453 alloc.c: Import and export fewer symbols, and remove unused items.
454 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
455 is defined.
456 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
457 it's not optimized away by whole-program optimization.
458 (message_enable_multibyte, free_misc): Remove.
459 (catchlist, handlerlist, mark_backtrace):
460 Declare only if BYTE_MARK_STACK.
461 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
462 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
463 (message_enable_multibyte): Remove decl.
464 (free_misc, interval_free_list, float_block, float_block_index):
465 (n_float_blocks, float_free_list, cons_block, cons_block_index):
466 (cons_free_list, last_marked_index):
467 Now static.
468 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
469 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
470 (mark_backtrace): Define only if BYTE_MARK_STACK.
471 * xdisp.c (message_enable_multibyte): Now static.
472
955cbe7b
PE
473 Declare Lisp_Object Q* variables to be 'static' if not exproted.
474 This makes it easier for human readers (and static analyzers)
475 to see whether these variables are used from other modules.
476 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
477 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
478 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
479 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
480 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
481 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
482 * xmenu.c, xselect.c:
483 Declare Q* vars static if they are not used in other modules.
484 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
485 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
486 Remove decls of unexported vars.
487 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
488
95c82688
PE
489 * lisp.h (DEFINE_FUNC): Make sname 'static'.
490
16a97296
PE
491 Make Emacs functions such as Fatom 'static' by default.
492 This makes it easier for human readers (and static analyzers)
493 to see whether these functions can be called from other modules.
494 DEFUN now defines a static function. To make the function external
495 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
496 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
497 (Finit_image_library):
16a97296
PE
498 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
499 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
500 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
501 Remove decls, since these functions are now static.
502 (Funintern, Fget_internal_run_time): New decls, since these functions
503 were already external.
95c82688 504
16a97296
PE
505 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
506 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
507 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
508 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
509 * keyboard.c, keymap.c, lread.c:
510 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
511 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
512 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
513 Mark functions with DEFUE instead of DEFUN,
514 if they are used in other modules.
515 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
516 decls for now-static functions.
517 * buffer.h (Fdelete_overlay): Remove decl.
518 * callproc.c (Fgetenv_internal): Mark as internal.
519 * composite.c (Fremove_list_of_text_properties): Remove decl.
520 (Fcomposition_get_gstring): New forward static decl.
521 * composite.h (Fcomposite_get_gstring): Remove decl.
522 * dired.c (Ffile_attributes): New forward static decl.
523 * doc.c (Fdocumntation_property): New forward static decl.
524 * eval.c (Ffetch_bytecode): New forward static decl.
525 (Funintern): Remove extern decl; now in .h file where it belongs.
526 * fileio.c (Fmake_symbolic_link): New forward static decl.
527 * image.c (Finit_image_library): New forward static decl.
528 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
529 * intervals.h (Fprevious_property_change):
530 (Fremove_list_of_text_properties): Remove decls.
531 * keyboard.c (Fthis_command_keys): Remove decl.
532 (Fcommand_execute): New forward static decl.
533 * keymap.c (Flookup_key): New forward static decl.
534 (Fcopy_keymap): Now static.
535 * keymap.h (Flookup_key): Remove decl.
536 * process.c (Fget_process): New forward static decl.
537 (Fprocess_datagram_address): Mark as internal.
538 * syntax.c (Fsyntax_table_p): New forward static decl.
539 (skip_chars): Remove duplicate decl.
540 * textprop.c (Fprevious_property_change): New forward static decl.
541 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
542 Now internal.
543 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
544 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
545
785bbd42
PE
546 * editfns.c (Fformat): Remove unreachable code.
547
8b913b57
AS
5482011-04-14 Andreas Schwab <schwab@linux-m68k.org>
549
550 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
551 change. (Bug#8496)
552
a6744a35
EZ
5532011-04-13 Eli Zaretskii <eliz@gnu.org>
554
555 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
556 when at ZV. (Bug#8487)
557
e7974947
AS
5582011-04-12 Andreas Schwab <schwab@linux-m68k.org>
559
baad03f0
AS
560 * charset.c (Fclear_charset_maps): Use xfree instead of free.
561 (Bug#8437)
562 * keyboard.c (parse_tool_bar_item): Likewise.
563 * sound.c (sound_cleanup, alsa_close): Likewise.
564 * termcap.c (tgetent): Likewise.
565 * xfns.c (x_default_font_parameter): Likewise.
566 * xsettings.c (read_and_apply_settings): Likewise.
567
e7974947
AS
568 * alloc.c (overrun_check_malloc, overrun_check_realloc)
569 (overrun_check_free): Protoize.
570
28272684
PE
5712011-04-12 Paul Eggert <eggert@cs.ucla.edu>
572
573 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
574 since callers should never pass a negative size.
575 Change the signature to match that of plain 'read' and 'write'; see
576 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
577 * lisp.h: Update prototypes of emacs_write and emacs_read.
578
11997c76
EZ
5792011-04-11 Eli Zaretskii <eliz@gnu.org>
580
581 * xdisp.c (redisplay_window): Don't try to determine the character
582 position of the scroll margin if the window start point w->startp
e896f03c 583 is outside the buffer's accessible region. (Bug#8468)
11997c76 584
8a2cbd72
EZ
5852011-04-10 Eli Zaretskii <eliz@gnu.org>
586
587 Fix write-region and its subroutines for buffers > 2GB.
588 * fileio.c (a_write, e_write): Modify declaration of arguments and
589 local variables to support buffers larger than 2GB.
590 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
591
592 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
593 argument, local variables, and return value.
594
595 * lisp.h: Update prototypes of emacs_write and emacs_read.
596
597 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
598
4073e537 5992011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 600
1ebfdcb6
PE
601 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
602
b2ded58d
PE
603 Fix more problems found by GCC 4.6.0's static checks.
604
7d66342c
PE
605 * xdisp.c (vmessage): Use a better test for character truncation.
606
bbf47d44
PE
607 * charset.c (load_charset_map): <, not <=, for optimization,
608 and to avoid potential problems with integer overflow.
9248994d 609 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 610 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 611 * editfns.c (Fformat): Likewise.
1e69125e 612 * syntax.c (skip_chars): Likewise.
3befa583 613
e3019616
PE
614 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
615 This also lets GCC 4.6.0 generate slightly better loop code.
616
becfa255
PE
617 * callint.c (Fcall_interactively): <, not <=, for optimization.
618 (Fcall_interactively): Count the number of arguments produced,
619 not the number of arguments given. This is simpler and lets GCC
620 4.6.0 generate slightly better code.
621
dae0cd48
PE
622 * ftfont.c: Distingish more carefully between FcChar8 and char.
623 The previous code passed unsigned char * to a functions like
624 strlen and xstrcasecmp that expect char *, which does not
625 conform to the C standard.
626 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
627 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
628 char * when the C standard requires it.
629
76032d70
PE
630 * keyboard.c (read_char): Remove unused var.
631
eb3f1cc8
PE
632 * eval.c: Port to Windows vsnprintf (Bug#8435).
633 Include <limits.h>.
634 (SIZE_MAX): Define if the headers do not.
635 (verror): Do not give up if vsnprintf returns a negative count.
636 Instead, grow the buffer. This ports to Windows vsnprintf, which
637 does not conform to C99. Problem reported by Eli Zaretskii.
638 Also, simplify the allocation scheme, by avoiding the need for
639 calling realloc, and removing the ALLOCATED variable.
640
70476b54
PE
641 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
642
12020a9e
PE
643 Remove invocations of doprnt, as Emacs now uses vsnprintf.
644 But keep the doprint source code for now, as we might revamp it
645 and use it again (Bug#8435).
ea6c7ae6
PE
646 * lisp.h (doprnt): Remove.
647 * Makefile.in (base_obj): Remove doprnt.o.
648 * deps.mk (doprnt.o): Remove.
649
5fdb398c
PE
650 error: Print 32- and 64-bit integers portably (Bug#8435).
651 Without this change, on typical 64-bit hosts error ("...%d...", N)
652 was used to print both 32- and 64-bit integers N, which relied on
653 undefined behavior.
654 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
655 New macro.
656 * lisp.h (error, verror): Mark as printf-like functions.
657 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
658 Report overflow in size calculations when allocating printf buffer.
659 Do not truncate output string at its first null byte.
660 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
661 Truncate the output at a character boundary, since vsnprintf does not
662 do that.
663 * charset.c (check_iso_charset_parameter): Convert internal
664 character to string before calling 'error', since %c now has the
665 printf meaning.
666 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
667 overflow when computing char to be passed to 'error'. Do not
668 pass Lisp_Object to 'error'; pass the integer instead.
669 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
670 formatted with plain %d.
671
b189fa66
PE
672 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
673
bff87ef0
PE
674 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
675
7e2cac20
PE
676 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
677
ce4d90b5
PE
678 * xterm.c (x_catch_errors): Remove duplicate declaration.
679
266c9547
PE
680 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
681
79c49ad2
PE
682 * xdisp.c, lisp.h (message_nolog): Remove; unused.
683
368f4090
JM
6842011-04-10 Jim Meyering <meyering@redhat.com>
685
686 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
687 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
688 return ssize_t not "int", and use size_t as the buffer length.
689 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
690 * gnutls.h: Update declarations.
691 * process.c (read_process_output): Use ssize_t, to match.
692 (send_process): Likewise.
693
a32d4040
CY
6942011-04-09 Chong Yidong <cyd@stupidchicken.com>
695
696 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
697
8546720e 6982011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 699
8546720e
GM
700 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
701 unsigned char, to match FcChar8 type definition.
aac0c6e3 702
8546720e
GM
703 * xterm.c (handle_one_xevent):
704 * xmenu.c (create_and_show_popup_menu):
705 * xselect.c (x_decline_selection_request)
706 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 707
0a2f5c1a 7082011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
709
710 Fix some uses of `int' instead of EMACS_INT.
711 * search.c (string_match_1, fast_string_match)
712 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
713 (scan_buffer, find_next_newline_no_quit)
714 (find_before_next_newline, search_command, Freplace_match)
715 (Fmatch_data): Make some `int' variables be EMACS_INT.
716
717 * xdisp.c (display_count_lines): 3rd argument and return value now
718 EMACS_INT. All callers changed.
719 (pint2hrstr): Last argument is now EMACS_INT.
720
721 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
722 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
723 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
724 (decode_coding_utf_16, decode_coding_emacs_mule)
725 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
726 (decode_coding_ccl, decode_coding_charset)
727 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
728 (decode_coding_iso_2022, decode_coding_emacs_mule)
729 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
730 <char_offset, last_offset>: Declare EMACS_INT.
731 (encode_coding_utf_8, encode_coding_utf_16)
732 (encode_coding_emacs_mule, encode_invocation_designation)
733 (encode_designation_at_bol, encode_coding_iso_2022)
734 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
735 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
736 Declare EMACS_INT.
737 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
738 (encode_invocation_designation): Last argument P_NCHARS is now
739 EMACS_INT.
740 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
741 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
742
743 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
744 All users changed.
745
746 * ccl.c (Fccl_execute_on_string): Declare some variables
747 EMACS_INT.
748
8546720e 7492011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
750
751 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
752
4e19a977
CS
7532011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
754
755 * process.c (Fformat_network_address): Doc fix.
756
87302331
R
7572011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
758
759 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
760
cbb59342
CY
7612011-04-08 Chong Yidong <cyd@stupidchicken.com>
762
763 * keyboard.c (read_char): Call Lisp function help-form-show,
764 instead of using internal_with_output_to_temp_buffer.
765 (Qhelp_form_show): New var.
e0d38eeb 766 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
767
768 * print.c (internal_with_output_to_temp_buffer): Function deleted.
769
770 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
771
e67a13ab
CY
7722011-04-06 Chong Yidong <cyd@stupidchicken.com>
773
774 * process.c (Flist_processes): Removed to Lisp.
775 (list_processes_1): Deleted.
776
973f782d
EZ
7772011-04-06 Eli Zaretskii <eliz@gnu.org>
778
7c106b1e
EZ
779 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
780
973f782d
EZ
781 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
782
41cf7d1a 7832011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 784
ca23cc88
PE
785 Fix more problems found by GCC 4.6.0's static checks.
786
f390e2d5
PE
787 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
788
42eea0d0
PE
789 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
790
b69769da 791 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 792
f9541e84
PE
793 * xdisp.c (vmessage): Mark as a printf-like function.
794
13841b55
PE
795 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
796
c136c10f
PE
797 * sound.c (sound_warning): Don't crash if arg contains a printf format.
798
5e2d4a30
PE
799 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
800 printf-like functions.
801 (tiff_load): Add casts to remove these marks before passing them
802 to system-supplied API.
803
583f48b9
PE
804 * eval.c (Fsignal): Remove excess argument to 'fatal'.
805
b25d760e
PE
806 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
807 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
808 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
809 directly, rather than having caller test rule sign. This avoids
810 some unnecessary tests.
811 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
812 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
813 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 814
bc7b6697 815 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 816 (xfont_open): Avoid unnecessary tests.
bc7b6697 817
27ccc379
PE
818 * composite.c (composition_gstring_put_cache): Use unsigned integer.
819
dcd5c89a
PE
820 * composite.h, composite.c (composition_gstring_put_cache):
821 Use EMACS_INT, not int, for length.
822
b13a45c6
PE
823 * composite.h (COMPOSITION_DECODE_REFS): New macro,
824 breaking out part of COMPOSITION_DECODE_RULE.
825 (COMPOSITION_DECODE_RULE): Use it.
826 * composite.c (get_composition_id): Remove unused local vars,
827 by using the new macro.
828
1e792e4d
PE
829 * textprop.c (set_text_properties_1): Change while to do-while,
830 since the condition is always true at first.
831
dc6c6455 832 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
833 (interval_deletion_adjustment): Return unsigned value.
834 All uses changed.
dc6c6455 835
aba7731a
PE
836 * process.c (list_processes_1, create_pty, read_process_output):
837 (exec_sentinel): Remove vars that were set but not used.
afd4052b 838 (create_pty): Remove unnecessary "volatile"s.
bc57d757 839 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 840 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 841 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 842
fdfc4bf3
PE
843 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
844
fca8fe46 845 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 846 (update_syntax_table): Use unsigned instead of int.
fca8fe46 847
06a0259a 848 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 849 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 850 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 851
e7b9e80f
PE
852 * print.c (print_error_message): Avoid int overflow.
853
56201685
PE
854 * font.c (font_list_entities): Redo for clarity,
855 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
856
78834453 857 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 858 (font_score): Avoid potential overflow in diff calculation.
78834453 859
0bc0b309 860 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 861 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 862
e610eaca
PE
863 * eval.c (funcall_lambda): Rename local to avoid shadowing.
864
b895abce
PE
865 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
866 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
867 can always succeed if overflow has undefined behavior.
868
1f1d9321 869 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 870 (wordify): Omit three unnecessary tests.
1f1d9321 871
c59478bc
PE
872 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
873 All callers changed. This avoids the need for an unused var.
874
79b73827
PE
875 * casefiddle.c (casify_region): Remove var that is set but not used.
876
a4db5dfe
PE
877 * dired.c (file_name_completion): Remove var that is set but not used.
878
43aae36e
PE
879 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
880
2a47c44d 881 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 882 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 883
a37c69bf
PE
884 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
885 Check for integer overflow on size calculations.
886
328ab8e7
PE
887 * buffer.c (Fprevious_overlay_change): Remove var that is set
888 but not used.
889
e5a2a5cb
PE
890 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
891 Remove vars that are set but not used.
8d84a6eb 892 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 893 (timer_check_2): Mark vars as initialized.
e5a2a5cb 894
a60e5f68
PE
895 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
896
f661cb61 897 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 898 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 899
f0397f5a
PE
900 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
901 that are set but not used.
902
8664db06 903 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 904 if XCreateBitmapFromData fails (Bug#8410).
8664db06 905
6abdaa4a
PE
906 * xselect.c (x_get_local_selection, x_handle_property_notify):
907 Remove vars that are set but not used.
908
0ce7538d 909 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 910 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 911
9ae848fc
PE
912 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
913 Remove var that is set but not used.
0b918413
PE
914 (scroll_bar_windows_size): Now size_t, not int.
915 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
916 Check for overflow.
9ae848fc 917
a5a62657
PE
918 * xfaces.c (realize_named_face): Remove vars that are set but not used.
919 (map_tty_color) [!defined MSDOS]: Likewise.
920
5c5cdd39
PE
921 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
922
66ebf983
PE
923 * coding.c: Remove vars that are set but not used.
924 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
925 All callers changed.
926 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
927 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
928 (decode_coding_charset): Remove vars that are set but not used.
929
1be4d761
PE
930 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
931 that is set but not used.
932
47553fa8
PE
933 * print.c (print_object): Remove var that is set but not used.
934
1f7196bf 935 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
936 The gnulib version avoids calling malloc in the usual case,
937 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
938 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
939 * filelock.c (current_lock_owner): Likewise.
940 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
941 * sysdep.c: Include allocator.h, careadlinkat.h.
942 (emacs_no_realloc_allocator): New static constant.
943 (emacs_readlink): New function.
fdb61804
PE
944 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
945 ../lib/careadlinkat.h.
d1fdcab7 946
f84c17c7
SM
9472011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
948
949 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
950 first non-nil return value).
951
ef3862ad
JD
9522011-04-03 Jan Djärv <jan.h.d@swipnet.se>
953
954 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
955 if not defined (Bug#8403).
956
376a7006
JB
9572011-04-02 Juanma Barranquero <lekktu@gmail.com>
958
959 * xdisp.c (display_count_lines): Remove parameter `start',
960 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
961 (get_char_face_and_encoding): Remove parameter `multibyte_p',
962 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
963 (fill_stretch_glyph_string): Remove parameters `row' and `area',
964 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
965 and thereabouts. All callers changed.
966 (get_per_char_metric): Remove parameter `f', unused since
967 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
968
6ca3801d
JM
9692011-04-02 Jim Meyering <meyering@redhat.com>
970
971 do not dereference NULL upon failed strdup
972 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
973 (ns_get_family): Likewise.
974
d8e2b5ba
JB
9752011-04-02 Juanma Barranquero <lekktu@gmail.com>
976
977 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
978
8c74fcbd
JD
9792011-04-02 Jan Djärv <jan.h.d@swipnet.se>
980
981 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
982 later (Bug#8403).
983
7200d79c
SM
9842011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
985
03408648 986 Add lexical binding.
7200d79c 987
03408648
SM
988 * window.c (Ftemp_output_buffer_show): New fun.
989 (Fsave_window_excursion):
990 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
991
992 * lread.c (lisp_file_lexically_bound_p): New function.
993 (Fload): Bind Qlexical_binding.
994 (readevalloop): Remove `evalfun' arg.
995 Bind Qinternal_interpreter_environment.
996 (Feval_buffer): Bind Qlexical_binding.
997 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
998 Mark as dynamic.
999 (syms_of_lread): Declare `lexical-binding'.
1000
1001 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1002
1003 * keyboard.c (eval_dyn): New fun.
1004 (menu_item_eval_property): Use it.
ca105506
SM
1005
1006 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1007
03408648
SM
1008 * fns.c (concat, mapcar1): Accept byte-code-functions.
1009
1010 * eval.c (Fsetq): Handle lexical vars.
1011 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1012 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1013 (FletX, Flet): Obey lexical binding.
1014 (Fcommandp): Handle closures.
1015 (Feval): New `lexical' arg.
1016 (eval_sub): New function extracted from Feval. Use it almost
1017 everywhere where Feval was used. Look up vars in lexical env.
1018 Handle closures.
1019 (Ffunctionp): Move from subr.el.
1020 (Ffuncall): Handle closures.
1021 (apply_lambda): Remove `eval_flags'.
1022 (funcall_lambda): Handle closures and new byte-code-functions.
1023 (Fspecial_variable_p): New function.
1024 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1025 but without exporting it to Lisp.
23aba0ea 1026
23aba0ea 1027 * doc.c (Fdocumentation, store_function_docstring):
03408648 1028 * data.c (Finteractive_form): Handle closures.
23aba0ea 1029
03408648
SM
1030 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1031 interactive spec.
ba83908c 1032
03408648
SM
1033 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1034 byte-codes.
1035 (exec_byte_code): New function extracted from Fbyte_code to handle new
1036 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1037
03408648 1038 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1039
03408648 1040 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1041
e2abce01
JB
10422011-03-31 Juanma Barranquero <lekktu@gmail.com>
1043
1044 * xdisp.c (redisplay_internal): Fix prototype.
1045
63696a73 10462011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1047
63696a73
EZ
1048 * xdisp.c (SCROLL_LIMIT): New macro.
1049 (try_scrolling): Use it when setting scroll_limit. Limit
1050 scrolling to 100 screen lines.
1051 (redisplay_window): Even when falling back on "recentering",
1052 position point in the window according to scroll-conservatively,
1053 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1054
1055 (try_scrolling): When point is above the window, allow searching
1056 as far as scroll_max, or one screenful, to compute vertical
1057 distance from PT to the scroll margin position. This prevents
1058 try_scrolling from unnecessarily failing when
1059 scroll-conservatively is set to a value slightly larger than the
1060 window height. Clean up the case of PT below the margin at bottom
1061 of window: scroll_max can no longer be INT_MAX. When aggressive
1062 scrolling is in use, don't let point enter the opposite scroll
1063 margin as result of the scroll.
1064 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1065 threshold of 100 lines for never-recentering scrolling.
1066
e4cc2dfc
JB
10672011-03-31 Juanma Barranquero <lekktu@gmail.com>
1068
1069 * dispextern.h (move_it_by_lines):
1070 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1071 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1072 (message_log_check_duplicate): Remove parameters `prev_bol' and
1073 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1074 (redisplay_internal): Remove parameter `preserve_echo_area',
1075 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1076
1077 * indent.c (Fvertical_motion):
1078 * window.c (window_scroll_pixel_based, Frecenter):
1079 Don't pass `need_y_p' to `move_it_by_lines'.
1080
1c470562
SM
10812011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1082
44f230aa
SM
1083 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1084 steal a few bits to be more compact.
1085 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1086 Remove unneeded casts.
1087
1c470562
SM
1088 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1089
888adce9
ZK
10902011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1091
1092 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1093 binding" message (bug#7967).
1094
f838ed7b
PE
10952011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1096
77861b95
PE
1097 Fix more problems found by GCC 4.6.0's static checks.
1098
de6dbc14
PE
1099 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1100 Remove unused local var.
1101
f838ed7b
PE
1102 * editfns.c (Fmessage_box): Remove unused local var.
1103
792c7b2b
PE
1104 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1105 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1106 Omit unused local vars.
c499e557 1107 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1108 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1109 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1110 Omit unused local var.
1111
ba0165e1
PE
1112 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1113 Don't assume string length fits in int.
32ad8845 1114 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1115 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1116
3c59b4c9
PE
1117 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1118 instead of alloca (Bug#8344).
1119
a3eed478 1120 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1121 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1122
eb4d412d
PE
1123 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1124
1658b401
PE
1125 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1126 concerns.
1127
1128 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1129
1130 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1131
9a2c6e05
PE
1132 * keyboard.c (syms_of_keyboard): Use the same style as later
1133 in this function when indexing through an array. This also
1134 works around GCC bug 48267.
1135
03d0a109
PE
1136 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1137
44f730c8
PE
1138 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1139
fe75f926
PE
1140 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1141 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1142
ffa8c828
PE
1143 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1144 This avoids undefined behavior on integer overflow, and is a bit
1145 more convenient anyway since it is compared to a size_t variable.
1146
c5101a77
PE
1147 Variadic C functions now count arguments with size_t, not int.
1148 This avoids an unnecessary limitation on 64-bit machines, which
1149 caused (substring ...) to crash on large vectors (Bug#8344).
1150 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1151 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1152 All variadic functions and their callers changed accordingly.
c5101a77
PE
1153 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1154 * data.c (arith_driver, float_arith_driver): Likewise.
1155 * editfns.c (general_insert_function): Likewise.
1156 * eval.c (struct backtrace.nargs, interactive_p)
1157 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1158 (funcall_lambda, mark_backtrace): Likewise.
1159 * fns.c (concat): Likewise.
1160 * frame.c (x_set_frame_parameters): Likewise.
1161 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1162 0 if not found, not -1. All callers changed.
1163
dd3f25f7
PE
1164 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1165 (stack_copy_size): Now size_t, not int.
1166 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1167
461c2ab9
JB
11682011-03-28 Juanma Barranquero <lekktu@gmail.com>
1169
1170 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1171 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1172 All callers changed.
1173
1174 * lisp.h (multibyte_char_to_unibyte):
1175 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1176 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1177 * character.h (CHAR_TO_BYTE8):
1178 * cmds.c (internal_self_insert):
1179 * editfns.c (general_insert_function):
1180 * keymap.c (push_key_description):
1181 * search.c (Freplace_match):
1182 * xdisp.c (message_dolog, set_message_1): All callers changed.
1183
f6d62986
SM
11842011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1185
1186 * keyboard.c (safe_run_hook_funcall): New function.
1187 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1188 don't set the hook to nil, but remove the offending function instead.
1189 (Qcommand_hook_internal): Remove, unused.
1190 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1191 Vcommand_hook_internal.
1192
1193 * eval.c (enum run_hooks_condition): Remove.
1194 (funcall_nil, funcall_not): New functions.
1195 (run_hook_with_args): Call each function through a `funcall' argument.
1196 Remove `cond' argument, now redundant.
1197 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1198 (Frun_hook_with_args_until_failure): Adjust accordingly.
1199 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1200
1db5b1ad
JB
12012011-03-28 Juanma Barranquero <lekktu@gmail.com>
1202
1203 * dispextern.h (string_buffer_position): Remove declaration.
1204
1205 * print.c (strout): Remove parameter `multibyte', unused since
1206 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1207
1208 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1209 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1210 All callers changed.
1211
1212 * w32.c (_wsa_errlist): Use braces for struct initializers.
1213
1214 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1215 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1216 All callers changed.
1217 (string_buffer_position): Likewise. Also, make static (it's never
1218 used outside xdisp.c).
1219 (cursor_row_p): Remove parameter `w', unused since
1220 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1221 (decode_mode_spec): Remove parameter `precision', introduced during
1222 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1223 All callers changed.
1224
5ffb62aa
JD
12252011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1226
1227 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1228
461c2ab9 12292011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1230
1231 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1232 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1233 (ns_update_auto_hide_menu_bar): New functions.
1234 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1235 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1236 ns_constrain_all_frames.
1237 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1238 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1239
5c380ffb
JD
12402011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1241
1242 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1243
9af30bdf
GM
12442011-03-27 Glenn Morris <rgm@gnu.org>
1245
1246 * syssignal.h: Replace RETSIGTYPE with void.
1247 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1248 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1249 Replace SIGTYPE with void everywhere.
1250 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1251 * s/template.h (SIGTYPE): Remove commented out definition.
1252
e2abce01
JB
12532011-03-26 Eli Zaretskii <eliz@gnu.org>
1254
1255 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1256 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1257
f868cd8a
JB
12582011-03-26 Juanma Barranquero <lekktu@gmail.com>
1259
59eb0929
JB
1260 * w32.c (read_unc_volume): Use parameter `henum', instead of
1261 global variable `wget_enum_handle'.
1262
1263 * keymap.c (describe_vector): Remove parameters `indices' and
1264 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1265 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1266
f868cd8a
JB
1267 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1268
1269 * keyboard.c (timer_check): Remove parameter `do_it_now',
1270 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1271 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1272 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1273
1274 * keyboard.c (read_char):
1275 * w32menu.c (w32_menu_display_help):
1276 * xmenu.c (show_help_event, menu_help_callback):
1277 Adjust calls to `show_help_echo'.
1278
1279 * gtkutil.c (xg_maybe_add_timer):
1280 * keyboard.c (readable_events):
1281 * process.c (wait_reading_process_output):
1282 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1283
1284 * insdel.c (adjust_markers_gap_motion):
1285 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1286 (gap_left, gap_right): Don't call it.
1287
2ecf6fdb
CY
12882011-03-25 Chong Yidong <cyd@stupidchicken.com>
1289
1290 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1291 incurred during fontification.
1292
6b1f9ba4
JB
12932011-03-25 Juanma Barranquero <lekktu@gmail.com>
1294
1295 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1296 (DEFVAR_PER_BUFFER): Don't pass it.
1297
1298 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1299 (scrolling_window): Don't pass it.
1300
0f4a96b5
JB
13012011-03-25 Juanma Barranquero <lekktu@gmail.com>
1302
1303 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1304
1305 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1306 and `suffix'.
1307 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1308 of variables specific to SELinux and computation of `encoded_absname'.
1309
1310 * image.c (XPutPixel): Remove unused variable `height'.
1311
1312 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1313
1314 * unexw32.c (get_section_info): Remove unused variable `section'.
1315
1316 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1317 (system_process_attributes): Remove unused variable `sess'.
1318 (sys_read): Remove unused variable `err'.
1319
1320 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1321 (w32_wnd_proc): Remove unused variable `isdead'.
1322 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1323 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1324 (x_create_tip_frame): Remove unused variable `tem'.
1325
1326 * w32inevt.c (w32_console_read_socket):
1327 Remove unused variable `no_events'.
1328
1329 * w32term.c (x_draw_composite_glyph_string_foreground):
1330 Remove unused variable `width'.
1331
1149507c
JB
13322011-03-24 Juanma Barranquero <lekktu@gmail.com>
1333
1334 * w32term.c (x_set_glyph_string_clipping):
1335 Don't pass uninitialized region to CombineRgn.
1336
9c88f339
JB
13372011-03-23 Juanma Barranquero <lekktu@gmail.com>
1338
1339 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1340 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1341 (Fx_close_connection): Remove unused variable `i'.
1342
1343 * w32font.c (w32font_draw): Return number of glyphs.
1344 (w32font_open_internal): Remove unused variable `i'.
1345 (w32font_driver): Add missing initializer.
1346
1347 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1348 (fill_in_menu): Remove unused variable `items_added'.
1349
1350 * w32term.c (last_mouse_press_frame): Remove static global variable.
1351 (w32_clip_to_row): Remove unused variable `f'.
1352 (x_delete_terminal): Remove unused variable `i'.
1353
1354 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1355 (NOTHING): Remove unused static global variable.
1356 (uniscribe_check_otf): Remove unused variable `table'.
1357 (uniscribe_font_driver): Add missing initializers.
1358
dee091a3
JD
13592011-03-23 Julien Danjou <julien@danjou.info>
1360
1361 * term.c (Fsuspend_tty, Fresume_tty):
1362 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1363 * window.c (temp_output_buffer_show):
1364 * insdel.c (signal_before_change):
1365 * frame.c (Fhandle_switch_frame):
1366 * fileio.c (Fdo_auto_save):
1367 * emacs.c (Fkill_emacs):
1368 * editfns.c (save_excursion_restore):
1369 * cmds.c (internal_self_insert):
1370 * callint.c (Fcall_interactively):
1371 * buffer.c (Fkill_all_local_variables):
1372 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1373 Use Frun_hooks.
0f4a96b5 1374 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1375 unconditionnaly since it does the check itself.
1376
2c520ab5 13772011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1378
c9c49752
PE
1379 Fix more problems found by GCC 4.5.2's static checks.
1380
8abc3f12
PE
1381 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1382 the first time through the loop, since we know p0 < p1 then.
1383 This also avoids a gcc -Wstrict-overflow warning.
1384
a2d26660
PE
1385 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1386 leading to a memory leak, possible in functions like
1387 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1388 of objects (Bug#8318).
a2d26660 1389
916c72e9
PE
1390 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1391 that could (at least in theory) be that large.
1392
19ab8a18
PE
1393 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1394 This is less likely to overflow, and avoids undefined behavior if
1395 overflow does occur. All callers changed. Use strtoul to scan
1396 for the unsigned long integer.
b7cbbd6f
PE
1397 (pint2hrstr): Simplify and tune code slightly.
1398 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1399
f0641eff
PE
1400 * scroll.c (do_scrolling): Work around GCC bug 48228.
1401 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1402
7f650bb9
PE
1403 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1404 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1405 (validate_x_resource_name): Simplify count usage.
1406 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1407
37dd57d1
PE
1408 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1409 fail (Bug#8306).
81e56e61 1410
699979fc 1411 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1412
401bf9b4
PE
1413 * process.c (Fmake_network_process): Use socklen_t, not int,
1414 where POSIX says socklen_t is required in portable programs.
1415 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1416 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1417 (Fmake_network_process, server_accept_connection):
1418 (wait_reading_process_output, read_process_output):
1419 Likewise.
1420
b93aacde
PE
1421 * process.c: Rename or move locals to avoid shadowing.
1422 (list_processes_1, Fmake_network_process):
1423 (read_process_output_error_handler, exec_sentinel_error_handler):
1424 Rename or move locals.
4dc343ee 1425 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1426 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1427 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1428 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1429 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1430
af8a867c 1431 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1432 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1433 Include tparam.h instead, since it declares them.
af8a867c
PE
1434 * cm.h (PC): Remove extern decl; tparam.h now does this.
1435 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1436 * terminfo.c: Include tparam.h, to check interfaces.
1437 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1438 (tparam): Adjust signature to match interface in tparam.h;
1439 this removes some undefined behavior. Check that outstring and len
1440 are zero, which they always are with Emacs.
1441 * tparam.h (PC, BC, UP): New extern decls.
1442
0248044d 1443 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1444 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1445
8ff096c1 1446 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1447 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1448 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1449 (ftfont_list): Remove unused local.
49eaafba
PE
1450 (get_adstyle_property, ftfont_pattern_entity):
1451 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1452 Rename locals to avoid shadowing.
8ff096c1 1453
e2be39f6
PE
1454 * xfont.c (xfont_list_family): Mark var as initialized.
1455
c9735e30
PE
1456 * xml.c (make_dom): Now static.
1457
8f5201ae
PE
1458 * composite.c (composition_compute_stop_pos): Rename local to
1459 avoid shadowing.
b246f932
PE
1460 (composition_reseat_it): Remove unused locals.
1461 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1462 (composition_update_it): Mark var as initialized.
11b61122
PE
1463 (find_automatic_composition): Mark vars as initialized,
1464 with a FIXME (Bug#8290).
8f5201ae 1465
760fbc2c
PE
1466 character.h: Rename locals to avoid shadowing.
1467 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1468 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1469 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1470 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1471 to avoid shadowing.
1472
ff08eb85
PE
1473 * textprop.c (property_change_between_p): Remove; unused.
1474
fc7bf025
PE
1475 * intervals.c (interval_start_pos): Now static.
1476
235d7abc
PE
1477 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1478
44f230aa
SM
1479 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1480 Rename locals to avoid shadowing.
3e7d6594 1481
50060332
PE
1482 * sound.c (wav_play, au_play, Fplay_sound_internal):
1483 Fix pointer signedness.
d01f234b 1484 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1485 (wav_play): Initialize a variable to 0, to prevent undefined
1486 behavior (Bug#8278).
50060332 1487
c4fc4e30
PE
1488 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1489
918436ed
PE
1490 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1491
c939f91b
PE
1492 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1493 clobbering (Bug#8298).
b9c7f648
PE
1494 * sysdep.c (sys_subshell): Likewise.
1495 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1496
6bd8c144
PE
1497 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1498 This should get cleaned up, so that child_setup has the
1499 same signature on all platforms.
1500
7710357c 1501 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1502 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1503
c59da222
CY
15042011-03-22 Chong Yidong <cyd@stupidchicken.com>
1505
1506 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1507 not to be necessary, and produces flickering.
1508
66b87493
GM
15092011-03-20 Glenn Morris <rgm@gnu.org>
1510
1511 * config.in: Remove file.
1512
45b6f6d5
JB
15132011-03-20 Juanma Barranquero <lekktu@gmail.com>
1514
1515 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1516 are now in src/globals.h.
1517 (syms_of_minibuf): Remove spurious & from previous change.
1518
3ec03f7e
LL
15192011-03-20 Leo <sdl.web@gmail.com>
1520
1521 * minibuf.c (completing-read-function): New variable.
1522 (completing-read-default): Rename from completing-read.
1523 (completing-read): Call completing-read-function.
1524
b14e3e21
CY
15252011-03-19 Juanma Barranquero <lekktu@gmail.com>
1526
1527 * xfaces.c (Fx_load_color_file):
1528 Read color file from absolute filename (bug#8250).
1529
f2b726e6
JB
15302011-03-19 Juanma Barranquero <lekktu@gmail.com>
1531
1532 * makefile.w32-in: Update dependencies.
1533
09f6ff02
EZ
15342011-03-17 Eli Zaretskii <eliz@gnu.org>
1535
1536 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1537
29a6015a
PE
15382011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1539
a3a6c54e
PE
1540 Fix more problems found by GCC 4.5.2's static checks.
1541
b766f867
PE
1542 * process.c (make_serial_process_unwind, send_process_trap):
1543 (sigchld_handler): Now static.
1544
be02381c
PE
1545 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1546 That way, the code declares only the vars that it needs.
1547 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1548 * s/cygwin.h (PTY_ITERATION): Likewise.
1549 * s/darwin.h (PTY_ITERATION): Likewise.
1550 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1551
57048744
PE
1552 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1553 * process.c (allocate_pty): Don't declare stb unless it's needed.
1554
7914961c 1555 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1556 (CONSTANTLIM): Remove; unused.
1557 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1558 Define only if needed.
7914961c 1559
b3967b18
PE
1560 * unexelf.c (unexec): Name an expression,
1561 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1562 Use a different way to cause a compilation error if anyone uses
1563 n rather than nn, a way that does not involve shadowing.
73366a00 1564 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1565
29a6015a
PE
1566 * deps.mk (unexalpha.o): Remove; unused.
1567
43cfc33e 1568 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1569 * unexec.h: New file.
ce701a33
PE
1570 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1571 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1572 Depend on unexec.h.
1573 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1574 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1575 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1576 Change as necessary to match prototype in unexec.h.
ce701a33 1577
01f44d5a
PE
1578 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1579 shadowing.
4f63c6bb 1580 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1581
a6670b0b
PE
1582 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1583 Rename locals to avoid shadowing.
1584
cef2010d 1585 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1586 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1587
d4d7173a
PE
1588 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1589
f08b802a
PE
1590 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1591 warning when compiling print.c.
1592
3ddb0639
PE
1593 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1594 instead of using an uninitialized var.
5ad03b97 1595 (font_sort_entities): Mark var as initialized.
3ddb0639 1596
170a2692
PE
1597 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1598
e663c700
PE
1599 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1600 pointers to constants.
89bc529a 1601 (font_parse_fcname): Remove unused vars.
7b81e2d0 1602 (font_delete_unmatched): Now static.
ea838e10 1603 (font_get_spec): Remove; unused.
13a547c6
PE
1604 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1605 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1606 Rename or move locals to avoid shadowing.
e663c700 1607
2a80c887 1608 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1609 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1610
1384fa33 1611 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1612 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1613
8b2c52e9
PE
1614 * alloc.c (mark_backtrace): Move decl from here ...
1615 * lisp.h: ... to here, so that it can be checked.
1616
475545b5 1617 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1618 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1619 (lisp_indirect_variable): Name an expression,
1620 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1621 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1622
b1349114 1623 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1624 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1625 Use const pointer when appropriate.
b1349114 1626
a2928364
PE
1627 * lisp.h (get_system_name, get_operating_system_release):
1628 Move decls here, to check interfaces.
1629 * process.c (get_operating_system_release): Move decl to lisp.h.
1630 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1631 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1632 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1633 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1634 (Fformat_time_string, Fencode_time, Finsert_char):
1635 (Ftranslate_region_internal, Fformat):
1636 Rename or remove local vars to avoid shadowing.
9710023e 1637 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1638
a415e694
PE
1639 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1640 avoid shadowing.
1641
8ef4622d
PE
1642 * lisp.h (eassert): Check that the argument compiles, even if
1643 ENABLE_CHECKING is not defined.
1644
946f9a5b
PE
1645 * data.c (Findirect_variable): Name an expression, to avoid
1646 gcc -Wbad-function-cast warning.
112396d6 1647 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1648 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1649 (Fmake_variable_buffer_local, Fmake_local_variable):
1650 Mark variables as initialized.
52746918 1651 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1652
e5aab7e7 1653 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1654 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1655 Rename locals to avoid shadowing.
dff45157
PE
1656 (mark_stack): Move local variables into the #ifdef region where
1657 they're used.
7bc26fdb
PE
1658 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1659 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1660 needed otherwise.
1661 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1662 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1663 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1664
e5aab7e7
PE
1665 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1666 avoids undefined behavior in theory.
1667
4da60324
PE
1668 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1669
88043301
PE
1670 Use functions, not macros, for up- and down-casing (Bug#8254).
1671 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1672 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1673 to use the following functions instead of these macros.
1674 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1675 EMACS_INT, since callers assume the returned value fits in int.
1676 (upcase1): Likewise, for UPCASE_TABLE.
1677 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1678 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1679 the race-condition problem in the old DOWNCASE.
88043301 1680
19ed5445
PE
1681 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1682 Rename locals to avoid shadowing.
1683 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1684 (regex_compile, re_search_2, re_match_2_internal):
1685 Remove unused local vars.
952db0d7
PE
1686 (FREE_VAR): Rewrite so as not to use empty "else",
1687 which gcc can warn about.
da053e48 1688 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1689 (RETALLOC_IF): Define only if needed.
1690 (WORDCHAR_P): Likewise. This one is never needed, but is used
1691 only in a comment talking about a compiler bug, so put inside
1692 the #if 0 of that comment.
1693 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1694 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1695 Remove; unused.
19ed5445 1696
1f3561e4 1697 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1698 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1699 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1700
ded6f8f7
PE
1701 * search.c (simple_search): Remove unused var.
1702
dbd37a95
PE
1703 * dired.c (compile_pattern): Move decl from here ...
1704 * lisp.h: ... to here, so that it can be checked.
1705 (struct re_registers): New forward decl.
1706
7e47afad
PE
1707 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1708
85f24f61
PE
1709 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1710 All uses changed.
1711 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1712 Rename locals to avoid shadowing.
5671df8f 1713 (Fvertical_motion): Mark locals as initialized.
85f24f61 1714
181aa2be 1715 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1716 (casify_region): Mark local as initialized.
181aa2be 1717
930d429c
PE
1718 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1719
7082eac6
PE
1720 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1721 New macros, so that the caller can use some names other than
1722 gcpro1, gcpro2, etc.
1723 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1724 of the new macros.
1725 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1726 argument, for consistency with GCPRO2_VAR, etc: it is now the
1727 prefix of the variable, not the variable itself. All uses
1728 changed.
38b2c076
PE
1729 * dired.c (directory_files_internal, file_name_completion):
1730 Rename locals to avoid shadowing.
1731
15206ed9
PE
1732 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1733 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1734 dired.c's scmp function, had undefined behavior.
1735 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1736 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1737 * buffer.h: ... to here, because these macros use current_buffer,
1738 and the new implementation with inline functions needs to have
1739 current_buffer in scope now, rather than later when the macros
1740 are used.
1741 (downcase, upcase1): New static inline functions.
1742 (DOWNCASE, UPCASE1): Reimplement using these functions.
1743 This avoids undefined behavior in expressions like
1744 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1745 from race conditions in accessing the global variables
1746 case_temp1 and case_temp2.
1747 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1748 * lisp.h (case_temp1, case_temp2): Remove their decls.
1749 * character.h (ASCII_CHAR_P): Move from here ...
1750 * lisp.h: ... to here, so that the inline functions mentioned
1751 above can use them.
1752
4a6bea26
PE
1753 * dired.c (directory_files_internal_unwind): Now static.
1754
f14b7e14
PE
1755 * fileio.c (file_name_as_directory, directory_file_name):
1756 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1757 Now static.
2893f146
PE
1758 (file_name_as_directory): Use const pointers when appropriate.
1759 (Fexpand_file_name): Likewise. In particular, newdir might
1760 point at constant storage, so make it a const pointer.
fd4ead52 1761 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1762 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1763 signedness issues.
f839df0c
PE
1764 (Fset_file_times, Finsert_file_contents, auto_save_error):
1765 Rename locals to avoid shadowing.
f14b7e14 1766
5716756e 1767 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1768 (Ftry_completion, Fall_completions): Rename or remove locals
1769 to avoid shadowing.
5716756e 1770
b4c3046a
PE
1771 * marker.c (bytepos_to_charpos): Remove; unused.
1772
b45db522
PE
1773 * lisp.h (verify_bytepos, count_markers): New decls,
1774 so that gcc does not warn that these functions aren't declared.
1775
85876d07
PE
1776 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1777 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1778 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1779 (copy_text): Remove unused local var.
85876d07 1780
03d78a21 1781 * filelock.c (within_one_second): Now static.
b3dd38ab 1782 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1783
5df8f01b
PE
1784 * buffer.c (fix_overlays_before): Mark locals as initialized.
1785 (fix_start_end_in_overlays): Likewise. This function should be
1786 simplified by using pointers-to-pointers, but that's a different
1787 matter.
b1d876f1 1788 (switch_to_buffer_1): Now static.
8f54f30a
PE
1789 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1790 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1791
a70072c9 1792 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1793 Fix pointer signedness issue.
edced198
PE
1794 (sys_subshell): Mark local as volatile if checking for lint,
1795 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1796 (MAXPATHLEN): Define only if needed.
a70072c9 1797
a0977c44
PE
1798 * process.c (serial_open, serial_configure): Move decls from here ...
1799 * systty.h: ... to here, so that they can be checked.
1800
a884fdcc
PE
1801 * fns.c (get_random, seed_random): Move extern decls from here ...
1802 * lisp.h: ... to here, so that they can be checked.
1803
604efe86 1804 * sysdep.c (reset_io): Now static.
b8950c94 1805 (wait_for_termination_signal): Remove; unused.
604efe86 1806
38fc62d9
PE
1807 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1808 (copy_keymap_item, append_key, push_text_char_description):
1809 Now static.
1004a21a 1810 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1811 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1812 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1813 (describe_map_tree):
1814 Rename locals to avoid shadowing.
38fc62d9 1815
2f2650da
PE
1816 * keyboard.c: Declare functions static if they are not used elsewhere.
1817 (echo_char, echo_dash, cmd_error, top_level_2):
1818 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1819 (read_char, kbd_buffer_get_event, make_lispy_position):
1820 (make_lispy_event, make_lispy_movement, apply_modifiers):
1821 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1822 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1823 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1824 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1825 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1826
a053e86c 1827 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1828 (mark_kboards): Move decl here ...
1829 * alloc.c (mark_kboards): ... from here.
a053e86c 1830
4752793e
PE
1831 * lisp.h (force_auto_save_soon): New decl.
1832
74f10ca7 1833 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1834 (DEFINE_DUMMY_FUNCTION): New macro.
1835 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1836 Use it.
c03cd23f
PE
1837 (main): Add casts to avoid warnings
1838 if GCC considers string literals to be constants.
74f10ca7 1839
022e70d4
PE
1840 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1841
59d6fe83
PE
1842 * dbusbind.c: Pointer signedness fixes.
1843 (xd_signature, xd_append_arg, xd_initialize):
1844 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1845 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1846 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1847 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1848
78320123
PE
1849 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1850 if GCC considers string literals to be constants.
49cebcca 1851 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1852
35ac2a97
SM
18532011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1854
fb103ca9
SM
1855 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1856 (print_preprocess, print_object): New macro to fix last change.
1857
35ac2a97
SM
1858 * print.c (print_preprocess): Don't forget font objects.
1859
62973b41
JB
18602011-03-16 Juanma Barranquero <lekktu@gmail.com>
1861
1862 * emacs.c (USAGE3): Doc fixes.
1863
0e48bb22
AS
18642011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1865
1866 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1867 structure.
1868
7684e57b
JB
18692011-03-14 Juanma Barranquero <lekktu@gmail.com>
1870
1871 * lisp.h (VWindow_system, Qfile_name_history):
1872 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1873 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1874 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1875
1876 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1877 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1878
1879 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1880 * w32console.c (detect_input_pending, read_input_pending)
1881 (encode_terminal_code):
1882 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1883 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1884 (w32_system_caret_y, Qfile_name_history):
1885 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1886 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1887 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1888 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1889 * w32proc.c (Qlocal, report_file_error):
1890 * w32term.c (Vwindow_system, updating_frame):
1891 * w32uniscribe.c (initialized, uniscribe_font_driver):
1892 Remove unneeded extern declarations.
1893
2aa46d6c
CY
18942011-03-14 Chong Yidong <cyd@stupidchicken.com>
1895
c96bbc66 1896 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1897
cffc6f3b
CY
18982011-03-13 Chong Yidong <cyd@stupidchicken.com>
1899
1900 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1901 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1902 These macros can no longer be used for assignment.
1903
44f230aa
SM
1904 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1905 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1906 (record_buffer_markers, fetch_buffer_markers): New functions for
1907 recording and fetching special buffer markers.
1908 (set_buffer_internal_1, set_buffer_temp): Use them.
1909
1910 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1911
1912 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1913
1914 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1915 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1916
1917 * xdisp.c (hscroll_window_tree):
1918 (reconsider_clip_changes): Use PT instead of BUF_PT.
1919
d251f04b
EZ
19202011-03-13 Eli Zaretskii <eliz@gnu.org>
1921
1922 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1923 $(EMACS_ROOT)/lib/intprops.h.
1924
f0c77cd1
PE
19252011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1926
3eca4629
PE
1927 Fix more problems found by GCC 4.5.2's static checks.
1928
7c86ee98
PE
1929 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1930 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1931 (xg_free_frame_widgets): Make it clear that a local variable is
1932 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1933 (gdk_window_get_screen): Make it clear that this macro is needed
1934 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1935 (int_gtk_range_get_value): New function, which avoids a diagnostic
1936 from gcc -Wbad-function-cast.
1937 (xg_set_toolkit_scroll_bar_thumb): Use it.
1938 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1939 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1940 (get_utf8_string, xg_get_file_with_chooser):
1941 Rename locals to avoid shadowing.
1942 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1943
41729b81
PE
1944 * xgselect.c (xg_select): Remove unused var.
1945
f0c77cd1
PE
1946 * image.c (four_corners_best): Mark locals as initialized.
1947 (gif_load): Initialize transparent_p to zero (Bug#8238).
1948 Mark another local as initialized.
ec6cf4c6 1949 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1950
ce0ad53d 1951 * image.c (clear_image_cache): Now static.
d5d5a617 1952 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1953 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1954 (x_edge_detection): Remove unnecessary cast that
1955 gcc -Wbad-function-cast diagnoses.
2037898d 1956 (gif_load): Fix pointer signedness.
6ae141d6
PE
1957 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1958 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1959
33383987 19602011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1961
d32df629
PE
1962 Improve quality of tests for time stamp overflow.
1963 For example, without this patch (encode-time 0 0 0 1 1
1964 1152921504606846976) returns the obviously-bogus value (-948597
1965 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1966 reports time overflow. See
1967 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1968 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1969 * editfns.c: Include limits.h and intprops.h.
1970 (TIME_T_MIN, TIME_T_MAX): New macros.
1971 (time_overflow): Move earlier, to before first use.
1972 (hi_time, lo_time): New functions, for an accurate test for
1973 out-of-range times.
1974 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1975 (Fget_internal_run_time): Don't assume time_t fits in int.
1976 (make_time): Use list2 instead of Fcons twice.
1977 (Fdecode_time): More accurate test for out-of-range times.
1978 (check_tm_member): New function.
1979 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1980 (lisp_time_argument): Don't rely on undefined left-shift and
1981 right-shift behavior when checking for time stamp overflow.
8be6f318 1982
fe31d94c
PE
1983 * editfns.c (time_overflow): New function, refactoring common code.
1984 (Fformat_time_string, Fdecode_time, Fencode_time):
1985 (Fcurrent_time_string): Use it.
1986
8be6f318
PE
1987 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1988 * dired.c (make_time): Move to ...
1989 * editfns.c (make_time): ... here.
1990 * systime.h: Note the move.
1991
09d9db2c 19922011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1993
126bc0dc
YM
1994 * fringe.c (update_window_fringes): Remove unused variables.
1995
c47cbdfd
YM
1996 * unexmacosx.c (copy_data_segment): Also copy __got section.
1997 (Bug#8223)
1998
7ac80be9
EZ
19992011-03-12 Eli Zaretskii <eliz@gnu.org>
2000
c96bbc66 2001 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2002 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2003 Constify `char *' arguments and their references according to
2004 prototypes in tparam.h.
2005
ecb0f94d 2006 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2007
7ac80be9
EZ
2008 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2009 Adapt all references accordingly.
2010
2011 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2012
ef1fd07e
TT
20132011-03-11 Tom Tromey <tromey@redhat.com>
2014
2015 * buffer.c (syms_of_buffer): Remove obsolete comment.
2016
7ef4b50c
EZ
20172011-03-11 Eli Zaretskii <eliz@gnu.org>
2018
2019 * termhooks.h (encode_terminal_code): Declare prototype.
2020
2021 * msdos.c (encode_terminal_code): Don't declare prototype.
2022
2023 * term.c (encode_terminal_code): Now external again, used by
2024 w32console.c and msdos.c.
2025
44f230aa
SM
2026 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2027 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2028
4b1ec863 20292011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2030
1714f52b 2031 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2032
4b1ec863
PE
2033 * fringe.c (update_window_fringes): Mark locals as initialized
2034 (Bug#8227).
2035 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2036
524c7aa6
PE
2037 * alloc.c (mark_fringe_data): Move decl from here ...
2038 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2039 to check its interface.
2040 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2041
a5c0af81 2042 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2043 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2044 (fontset_font): Mark local as initialized.
a9a06e0b 2045 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2046
b4716021
PE
2047 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2048
811e9bac 2049 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2050 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2051 (x_own_selection, Fx_disown_selection_internal): Rename locals
2052 to avoid shadowing.
2053 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2054
7e3ab302
PE
2055 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2056 so that the caller can use some name other than gcpro1.
2057 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2058 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2059 (Fx_backspace_delete_keys_p):
2060 Use them to avoid shadowing, and rename vars to avoid shadowing.
2061 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2062 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2063 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2064 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2065 Remove unused locals.
7e3ab302
PE
2066 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2067 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2068 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2069 macros.
f78faa98 2070
e2b13473
PE
2071 * xterm.h (x_mouse_leave): New decl.
2072
77f23912
PE
2073 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2074 Remove unused functions.
cdf4ba58
PE
2075 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2076 (x_calc_absolute_position): Now static.
7411c686 2077 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2078 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2079 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2080 unless they are used.
38d0b34a
PE
2081 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2082 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2083 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2084 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2085 (x_error_catcher, x_connection_closed, x_error_handler):
2086 (x_error_quitter, xembed_send_message, x_iconify_frame):
2087 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2088 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2089 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2090
44f230aa
SM
2091 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2092 Rename or move locals to avoid shadowing.
6b463e58 2093 (tty_defined_color, merge_face_heights): Now static.
5967d051 2094 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2095 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2096 does not deduce is never used uninitialized.
73719eba
PE
2097 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2098 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2099
426994c3 2100 * terminal.c (store_terminal_param): Now static.
5489860b 2101
032f1620 2102 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2103 (set_frame_menubar): Remove unused local.
d4323972 2104 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2105 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2106 since they might point to immutable storage.
281585b0
PE
2107 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2108 since it's unused otherwise.
032f1620 2109
367c19e5 2110 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2111 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2112 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2113 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2114 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2115 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2116 does not deduce are never used uninitialized.
70739cbe 2117
07b48fa9
PE
2118 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2119
8868a238 2120 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2121 * window.c (window_loop, size_window):
2122 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2123
7e5cf297 2124 * window.c (display_buffer): Now static.
d6550a9f
PE
2125 (size_window): Mark variables that gcc -Wuninitialized
2126 does not deduce are never used uninitialized.
a586633d
PE
2127 * window.h (check_all_windows): New decl, to forestall
2128 gcc -Wmissing-prototypes diagnostic.
5b555da1 2129 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2130
f6095868
PE
2131 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2132 shadowing.
2133 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2134 Include <limits.h>.
2135 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2136 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2137 (load_charset_map): Mark variables that gcc -Wuninitialized
2138 does not deduce are never used uninitialized.
53df7c11 2139 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2140
f38b440c
PE
2141 * coding.c (coding_set_source, coding_set_destination):
2142 Use "else { /* comment */ }" rather than "else /* comment */;"
2143 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2144 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2145 a block, when the outer 'i' will do.
2146 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2147 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2148 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2149 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2150 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2151 Rename locals to avoid shadowing.
2152 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2153 * coding.c (emacs_mule_char, encode_invocation_designation):
2154 Now static, since they're not used elsewhere.
413bb2db 2155 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2156 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2157 (decode_coding_emacs_mule): Mark variables that gcc
2158 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2159 (detect_coding_iso_2022): Initialize a local variable that might
2160 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2161 this initialization is needed. (Bug#8211)
5f58e762
PE
2162 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2163 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2164 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2165 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2166 Remove unused macros.
f38b440c 2167
232b38b9 2168 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2169 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2170 * character.c (string_count_byte8): Likewise.
232b38b9 2171
fb90da1b
PE
2172 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2173 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2174
fb93dbc2
PE
2175 * chartab.c (copy_sub_char_table): Now static, since it's not used
2176 elsewhere.
5c156ace
PE
2177 (sub_char_table_ref_and_range, char_table_ref_and_range):
2178 Rename locals to avoid shadowing.
bbcd0949 2179 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2180
7d3b3862 2181 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2182 (BIDI_BOB): Remove unused macro.
7d3b3862 2183
6be7d3da
PE
2184 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2185 deduce are never used uninitialized.
c2ed9c8b 2186 * term.c (encode_terminal_code): Likewise.
6be7d3da 2187
75f8807f 2188 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2189
50938595
PE
2190 * tparam.h: New file.
2191 * term.c, tparam.h: Include it.
2192 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2193 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2194 Move these decls to tparam.h, and make them agree with what
2195 is actually in tparam.c. The previous trick of using incompatible
2196 decls in different modules does not conform to the C standard.
2197 All callers of tparam changed to use tparam's actual API.
2198 * tparam.c (tparam1, tparam, tgoto):
2199 Use const pointers where appropriate.
2200
fbceeba2
PE
2201 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2202 * cm.h (struct cm): Likewise.
2203 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2204 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2205 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2206 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2207 (turn_on_face, init_tty): Likewise.
2208 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2209
7f3f1250
PE
2210 * term.c (term_mouse_position): Rename local to avoid shadowing.
2211
e6ca6543
PE
2212 * alloc.c (mark_ttys): Move decl from here ...
2213 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2214
c40f8d15
AS
22152011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2216
2217 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2218
cfe0661d
JB
22192011-03-09 Juanma Barranquero <lekktu@gmail.com>
2220
2221 * search.c (compile_pattern_1): Remove argument regp, unused since
2222 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2223 (compile_pattern): Don't pass it.
2224
0afb4571
J
22252011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2226
2227 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2228 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2229 for ! HAVE_GTK3.
2230 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2231
2232 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2233
2234 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2235 gdk_window_get_screen, gdk_window_get_geometry,
2236 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2237 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2238 (xg_get_pixbuf_from_pixmap): New function.
2239 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2240 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2241 Call xg_get_pixbuf_from_pixmap instead of
2242 gdk_pixbuf_get_from_drawable.
2243 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2244 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2245 (xg_check_special_colors): Use GtkStyleContext and its functions
2246 for HAVE_GTK3.
2247 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2248 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2249 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2250 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2251 Call gtk_widget_get_preferred_size.
0afb4571
J
2252 (xg_frame_resized): gdk_window_get_geometry only takes 5
2253 parameters.
44f230aa
SM
2254 (xg_win_to_widget, xg_event_is_for_menubar):
2255 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2256 (xg_set_widget_bg): New function.
2257 (delete_cb): New function.
2258 (xg_create_frame_widgets): connect delete-event to delete_cb.
2259 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2260 (xg_set_background_color): Call xg_set_widget_bg.
2261 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2262 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2263 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2264 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2265 if ! HAVE_GTK3.
2266 (update_frame_tool_bar): Call gtk_widget_hide.
2267 (xg_initialize): Use GDK_KEY_g.
2268
2269 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2270 if ! HAVE_GTK3
2271 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2272
2273 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2274 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2275 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2276
1c2cc4ef
JB
22772011-03-08 Juanma Barranquero <lekktu@gmail.com>
2278
2279 * w32xfns.c (select_palette): Check success of RealizePalette against
2280 GDI_ERROR, not zero.
2281
33383987 2282See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2283
2284;; Local Variables:
2285;; coding: utf-8
aac0c6e3
MR
2286;; End:
2287
33383987 2288 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2289
2290 This file is part of GNU Emacs.
2291
2292 GNU Emacs is free software: you can redistribute it and/or modify
2293 it under the terms of the GNU General Public License as published by
2294 the Free Software Foundation, either version 3 of the License, or
2295 (at your option) any later version.
2296
2297 GNU Emacs is distributed in the hope that it will be useful,
2298 but WITHOUT ANY WARRANTY; without even the implied warranty of
2299 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2300 GNU General Public License for more details.
2301
2302 You should have received a copy of the GNU General Public License
2303 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.