Document display-buffer and other window changes in Lisp manual.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
cddde921
GM
12011-09-24 Glenn Morris <rgm@gnu.org>
2
3 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4
1260aef1
PE
52011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6
25b4bfa0
PE
7 Fix minor problems found by static checking.
8 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
9 * indent.c (Fvertical_motion): Fix == vs = typo.
10
e3cbd34b
EZ
112011-09-24 Eli Zaretskii <eliz@gnu.org>
12
6bf7006f
EZ
13 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
14 value is now t. Doc fix.
15
e3cbd34b
EZ
16 * indent.c (Fvertical_motion): Compute and apply the overshoot
17 logic when moving up, not only when moving down. Fix the
18 confusing name and values of the it_overshoot_expected variable;
19 logic changes accordingly. (Bug#9254) (Bug#9549)
20
21 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
22 CHARPOS is covered by a display string which includes newlines.
23 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
24 is covered by a display string with embedded newlines.
25
a3de0cbd
MA
262011-09-24 Michael Albinus <michael.albinus@gmx.de>
27
28 * dbusbind.c (Fdbus_register_signal): Add match rule to
29 Vdbus_registered_objects_table. (Bug#9581)
30 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
31 docstring.
32
b260039d
JM
332011-09-24 Jim Meyering <meyering@redhat.com>
34
35 do not ignore write error for any output size
36 The previous change was incomplete.
37 While it makes emacs --batch detect the vast majority of stdout
38 write failures, errors were still ignored whenever the output size is
39 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
40 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
41 && echo FAIL: ignored write error
42 FAIL: ignored write error
43 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
44 && echo FAIL: ignored write error
45 FAIL: ignored write error
46 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
47
8eca8a7c
AS
482011-09-23 Andreas Schwab <schwab@linux-m68k.org>
49
50 * emacs.c (Fkill_emacs): In noninteractive mode exit
51 non-successfully if a write error occurred on stdout. (Bug#9574)
52
3341db62
EZ
532011-09-21 Eli Zaretskii <eliz@gnu.org>
54
55 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
56 the xassert test.
57
58 * dispextern.h (struct it): Update the comment documenting what
59 can it->OBJECT be.
60
8c203dbf
EZ
612011-09-20 Eli Zaretskii <eliz@gnu.org>
62
63 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
64 a display string, extend search for cursor position to end of row.
65 (find_row_edges): If the row ends in a newline from a display
66 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
67 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
68 (Fcurrent_bidi_paragraph_direction): Fix search for previous
69 non-empty line. Fixes confusing cursor motion with arrow keys at
70 the beginning of a line that starts with whitespace.
8c203dbf 71
a4824228
LMI
722011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
73
74 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
75 (bug#9493).
76
33ed493b
CY
772011-09-18 Chong Yidong <cyd@stupidchicken.com>
78
79 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
80 boolean (Bug#9154).
81
56cd55c8
EZ
822011-09-18 Eli Zaretskii <eliz@gnu.org>
83
84 * xdisp.c (display_line): Record maximum and minimum buffer
85 positions even if no glyphs were produced (e.g., by a zero-width
86 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
87 buffer positions that will be removed from the glyph row because
88 they don't fit.
c02dcedf
EZ
89 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
90 column is beyond frame width: don't subtract 1 "pixel" when
91 computing width of the stretch.
3e62b7e0
EZ
92 (reseat_at_next_visible_line_start): Undo the change made on
93 2011-09-17 that saved paragraph information and restored it after
94 the call to `reseat'. (Bug#9545)
56cd55c8 95
5ed99d36 962011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
97
98 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
99 and turn window cursor on if cleared (Bug#9415).
100
5ed99d36 1012011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
102
103 * search.c (boyer_moore): Take unibyte characters from pattern
104 literally. (Bug#9458)
105
9bade7b2
EZ
1062011-09-18 Eli Zaretskii <eliz@gnu.org>
107
108 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
109
e5e9d610
PE
1102011-09-18 Paul Eggert <eggert@cs.ucla.edu>
111
87e4427a
PE
112 Fix minor problem found by static checking.
113 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
114 initialized, to pacify gcc -Wuninitialized.
115
e5e9d610
PE
116 * fileio.c: Report proper errno when syscall falls.
117 (Finsert_file_contents): Save and restore errno,
118 so that report_file_error outputs the correct diagnostic.
119 (Fwrite_region) [CLASH_DETECTION]: Likewise.
120
a1674f0b
EZ
1212011-09-18 Eli Zaretskii <eliz@gnu.org>
122
123 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
124
fbfb6dd4
EZ
1252011-09-17 Eli Zaretskii <eliz@gnu.org>
126
127 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
128 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
129
bb187662
EZ
1302011-09-17 Eli Zaretskii <eliz@gnu.org>
131
1137e8b8
EZ
132 * xdisp.c (reseat_at_next_visible_line_start): Keep information
133 about the current paragraph and restore it after the call to
134 reseat.
135
136 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
137 (bidi_find_paragraph_start): Search back for paragraph beginning
138 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
139 (bidi_move_to_visually_next): Only trigger paragraph-related
140 computations when the last character is a newline or at EOB, not
141 just any NEUTRAL_B. (Bug#9470)
142
bb187662
EZ
143 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
144 truncated lines if point is covered by a display string. (Bug#9524)
145
2e621251
PE
1462011-09-16 Paul Eggert <eggert@cs.ucla.edu>
147
148 * xselect.c: Relax test for outgoing X longs (Bug#9498).
149 (cons_to_x_long): New function.
150 (lisp_data_to_selection_data): Use it. Correct the test for
151 short-versus-long data; it was negated. Break out of vector
152 loop, for efficiency, when a long datum is discovered.
153
91a15bc6
SM
1542011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
155
156 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
157
b41c3a35
EZ
1582011-09-16 Eli Zaretskii <eliz@gnu.org>
159
160 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
161 GCC PR/17406) by declaring this function with external scope.
162
7812ba2d
PE
1632011-09-15 Paul Eggert <eggert@cs.ucla.edu>
164
165 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
166 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
167
cf7edc2a
AS
1682011-09-15 Andreas Schwab <schwab@linux-m68k.org>
169
170 * editfns.c (Fformat): Correctly handle text properties on "%%".
171
bd01620e
EZ
1722011-09-15 Eli Zaretskii <eliz@gnu.org>
173
174 * xterm.c (x_draw_composite_glyph_string_foreground):
175 * w32term.c (x_draw_composite_glyph_string_foreground):
176 * term.c (encode_terminal_code):
177 * composite.c (composition_update_it, get_composition_id):
178 * xdisp.c (get_next_display_element)
179 (fill_composite_glyph_string): Add comments about special meaning
180 of TAB characters in a composition.
181
a02719a3
PE
1822011-09-15 Paul Eggert <eggert@cs.ucla.edu>
183
184 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
185 This occurs when processing a multibyte format.
186 Problem reported by Wolfgang Jenker.
a02719a3 187
72589a3c
JB
1882011-09-15 Johan Bockgård <bojohan@gnu.org>
189
190 * xdisp.c (try_cursor_movement): Only check for exact match if
191 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
192
1c14176c
PE
1932011-09-14 Paul Eggert <eggert@cs.ucla.edu>
194
195 Remove unused external symbols.
196 * dispextern.h (calc_pixel_width_or_height): Remove decl.
197 * xdisp.c (calc_pixel_width_or_height): Now static.
198 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
199 * indent.c (check_display_width):
200 * w32term.c: Fix comment to match code.
201 * xterm.c, xterm.h (x_catching_errors): Remove.
202
d2eea5b5
PE
2032011-09-14 Paul Eggert <eggert@cs.ucla.edu>
204
205 * xselect.c: Use signed conversions more consistently (Bug#9498).
206 (selection_data_to_lisp_data): Assume incoming selection data are
207 signed integers, not unsigned. This is to be consistent with
208 outgoing selection data, which was modified to use signed integers
209 in as part of the fix to Bug#9196 in response to Jan D.'s comment
210 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
211 expects long, not unsigned long.
212
46888499
EZ
2132011-09-14 Eli Zaretskii <eliz@gnu.org>
214
215 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
216 computation of loop end. Reported by Johan Bockgård
217 <bojohan@gnu.org>.
218
ef8ef9fb
CY
2192011-09-13 Chong Yidong <cyd@stupidchicken.com>
220
221 * frame.c (Fother_visible_frames_p): Function deleted.
222
fa819fed
EZ
2232011-09-12 Eli Zaretskii <eliz@gnu.org>
224
225 * indent.c (compute_motion): Process display vector front to back
226 rather than the other way around. (Bug#2496)
227
2ba8e008
SM
2282011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
229
230 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
231
20f53c69
CY
2322011-09-11 Chong Yidong <cyd@stupidchicken.com>
233
234 * minibuf.c (Fread_from_minibuffer): Doc fix.
235
d562d7a4
EZ
2362011-09-11 Eli Zaretskii <eliz@gnu.org>
237
238 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
239 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
240
1c4d7f3d
LMI
2412011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
242
243 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
244 value for non-existent files.
245
b885bf36
EZ
2462011-09-11 Eli Zaretskii <eliz@gnu.org>
247
248 * fileio.c (Finsert_file_contents): If the file cannot be opened,
249 set its "size" to -1. This will set the modtime_size field of
250 the corresponding buffer to -1, which is what
251 verify-visited-file-modtime expects for files that do not exist.
252 (Bug#9139)
253
6612f0bf
PE
2542011-09-11 Paul Eggert <eggert@cs.ucla.edu>
255
256 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
257 here ...
258 * lisp.h: ... from here. push_key_description is no longer
259 defined in keyboard.c, so its declaration should not be in
260 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
261 logically belongs with push_key_description.
262
dfb3f755
PE
2632011-09-10 Paul Eggert <eggert@cs.ucla.edu>
264
265 * buffer.h: Include <sys/types.h> instead of <time.h>.
266 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
267 Problem reported by Herbert J. Skuhra.
268
3134906c
LMI
2692011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
270
271 * xml.c (parse_region): Make the parsing work for
272 non-comment-starting XML files again (bug#9144).
273
8d903f4e
AS
2742011-09-10 Andreas Schwab <schwab@linux-m68k.org>
275
276 * image.c (gif_load): Fix calculation of bottom and right corner.
277 (Bug#9468)
278
80ad64f4
EZ
2792011-09-10 Eli Zaretskii <eliz@gnu.org>
280
281 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
282 redisplay in small windows.
283
208a048d
EZ
2842011-09-09 Eli Zaretskii <eliz@gnu.org>
285
286 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
287
9b1c252e
MR
2882011-09-08 Martin Rudalics <rudalics@gmx.at>
289
290 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
291 Operate on live windows only.
292
2949f33b
JB
2932011-09-08 Juanma Barranquero <lekktu@gmail.com>
294
295 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
296
e08dcafd
EZ
2972011-09-07 Eli Zaretskii <eliz@gnu.org>
298
299 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
300 only under bidi iteration.
301
115b96bd
JD
3022011-09-07 Jan Djärv <jan.h.d@swipnet.se>
303
304 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
305
c8199d0f
PE
3062011-09-06 Paul Eggert <eggert@cs.ucla.edu>
307
308 isnan: Fix porting problem to Solaris 10 with bundled gcc.
309 Without this fix, the command to link temacs failed due to an
310 undefined symbol __builtin_isnan. This is because
311 /usr/include/iso/math_c99.h #defines isnan(x) to
312 __builtin_isnan(x), but the bundled gcc, which identifies itself
313 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
314 a __builtin_isnan.
315 * floatfns.c (isnan): #undef, and then #define to a clone of
316 what's in data.c.
317 (Fisnan): Always define, since it's always available now.
318 (syms_of_floatfns): Always define isnan at the Lisp level.
319
e39b275c 3202011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
321
322 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
323
b2db44d9 3242011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 325
f4af5137 326 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
327 The previous code assumed that file offsets (off_t values) fit in
328 EMACS_INT variables, which is not true on typical 32-bit hosts.
329 The code messed up by falsely reporting buffer overflow in cases
330 such as (insert-file-contents "big" nil 1 2) into an empty buffer
331 when "big" contains more than 2**29 bytes, even though this
332 inserts just one byte and does not overflow the buffer.
333 (Finsert_file_contents): Store file offsets as off_t
334 values, not as EMACS_INT values. Check for overflow when
335 converting between EMACS_INT and off_t. When checking for
336 buffer overflow or for overlap, take the offsets into account.
337 Don't use EMACS_INT for small values where int suffices.
338 When checking for overlap, fix a typo: ZV was used where
339 ZV_BYTE was intended.
340 (Fwrite_region): Don't assume off_t fits into 'long'.
341 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
342
ecfc0a49
MA
3432011-09-05 Michael Albinus <michael.albinus@gmx.de>
344
345 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
346
6511acf2 3472011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 348
0999621a 349 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
350
351 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 352 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
353 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
354 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
355 (modify_event_symbol): Do not assume that the length of
356 name_alist_or_stem is safe to alloca and fits in int.
357 (Fexecute_extended_command): Likewise for function name and binding.
358 (Frecursion_depth): Wrap around reliably on integer overflow.
359 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
360 since some callers pass EMACS_INT values.
361 (Fsingle_key_description): Don't crash if symbol name contains more
362 than MAX_ALLOCA bytes.
363 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
364 (get_minibuffer): Arg is now EMACS_INT, not int.
365 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 366 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
367 * window.h (command_loop_level, minibuf_level): Reflect API changes.
368
2be7d702
PE
369 * dbusbind.c (signature_cat): New function.
370 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
371 Do not overrun buffer; instead, report string overflow.
372
9d1df220
PE
373 * dispnew.c (add_window_display_history): Don't overrun buffer.
374 Truncate instead; this is OK since it's just a log.
375
33ef5c64
PE
376 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
377 even if the time zone offset is outlandishly large.
378 Don't mishandle offset == INT_MIN.
379
66c6fdd5
PE
380 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
381 when creating daemon; the previous buffer-overflow check was incorrect.
382
d749b01b
PE
383 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
384 which has the guts of the old verror function.
385
b5cd1905
PE
386 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
387 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
388
6e1a67fb
PE
389 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
390 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 391 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 392 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
393 length of string rather than counting it via multiple sprintfs;
394 that's simpler and more reliable.
c21721cc
PE
395 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
396 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
397 sprintf, in case result does not fit in int.
398
c57b67fc
PE
399 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
400 (fontset_from_font): Print it.
401
8a401434
PE
402 * frame.c (tty_frame_count): Now printmax_t, not int.
403 (make_terminal_frame, set_term_frame_name): Print it.
404 (x_report_frame_params): In X, window IDs are unsigned long,
405 not signed long, so print them as unsigned.
406 (validate_x_resource_name): Check for implausibly long names,
407 and don't assume name length fits in 'int'.
408 (x_get_resource_string): Don't blindly alloca invocation name;
409 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
410 not fit in int.
411
6e1a67fb
PE
412 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
413 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
414 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
415
0df02bf3
PE
416 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
417 Use esprintf, not sprintf, in case result does not fit in int.
418
48e30793
PE
419 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
420 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
421 it as a large positive number.
422 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
423 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
424
a66ff6d8
PE
425 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
426 in case result does not fit in int.
427
aca216ff
PE
428 * print.c (float_to_string): Detect width overflow more reliably.
429 (print_object): Make sprintf buffer a bit bigger, to avoid potential
430 buffer overrun. Don't assume list length fits in 'int'. Treat
431 print length of 0 as 0, not as infinity; to be consistent with other
432 uses of print length in this function. Don't overflow print length
433 index. Don't assume hash table size fits in 'long', or that
434 vectorlike size fits in 'unsigned long'.
435
31c286f7
PE
436 * process.c (make_process): Use printmax_t, not int, to format
437 process-name gensyms.
438
55e5faa1
PE
439 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
440
80f2e268
PE
441 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
442 to avoid potential buffer overrun.
443
670741ab
PE
444 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
445 if X resource line is longer than 512 bytes.
446
b7163a50
PE
447 * xfns.c (x_window): Make sprintf buffer a bit bigger
448 to avoid potential buffer overrun.
449
ae58ff1f
PE
450 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
451
c43c8a6a
PE
452 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
453
3f8236f4
PE
4542011-09-04 Paul Eggert <eggert@cs.ucla.edu>
455
53e9fe90 456 Integer overflow fixes for scrolling, etc.
6511acf2
PE
457 Without these, Emacs silently mishandles large integers sometimes.
458 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
459 it were "C-u 1 M-x recenter" on a typical 64-bit host.
460
6511acf2
PE
461 * xdisp.c (try_window_id): Check Emacs fixnum range before
462 converting to 'int'.
806add1d 463
6511acf2 464 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
465 Check that an Emacs fixnum is in range before assigning it to 'int'.
466 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
467 values converted from Emacs fixnums.
468 (Frecenter): Don't wrap around a line count if it is out of 'int'
469 range; instead, treat it as an extreme value.
470 (Fset_window_configuration, compare_window_configurations):
471 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
472
6511acf2
PE
473 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
474 that can exceed INT_MAX. Check that EMACS_INT value is in range
475 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
476 (match_limit): Don't assume that a fixnum can fit in 'int'.
477
6511acf2 478 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
479 exceed INT_MAX.
480
6511acf2 481 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
482 (Fvertical_motion): Don't wrap around LINES values that don't fit
483 in 'int'. Instead, treat them as extreme values. This is good
484 enough for windows, which can't have more than INT_MAX lines anyway.
485
fcb901a7
LMI
4862011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
487
0f2f6b6d
LMI
488 * Require libxml/parser.h to avoid compilation warning.
489
fcb901a7
LMI
490 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
491
492 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
493 since this reportedly can destroy thread storage.
494
6e20a0d4
CY
4952011-08-30 Chong Yidong <cyd@stupidchicken.com>
496
497 * syntax.c (find_defun_start): Update all cache variables if
498 exiting early (Bug#9401).
499
148ae00e
EZ
5002011-08-30 Eli Zaretskii <eliz@gnu.org>
501
f6cfbd8f
EZ
502 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
503
148ae00e
EZ
504 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
505 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
506 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
507
508 * term.c (tty_append_glyph): New function.
509 (produce_stretch_glyph): Static function and its prototype deleted.
510
511 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
512 prototypes.
513
c4a07a4c
PE
5142011-08-29 Paul Eggert <eggert@cs.ucla.edu>
515
516 * image.c (parse_image_spec): Check for nonnegative, not for positive,
517 when checking :margin (Bug#9390).
518 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
519 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
520 so that the name doesn't mislead. All uses changed.
521
6bc8cd65
JB
5222011-08-28 Johan Bockgård <bojohan@gnu.org>
523
524 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
525 set_tty_hooks.
526
dca4927e
EZ
5272011-08-27 Eli Zaretskii <eliz@gnu.org>
528
529 * xdisp.c (move_it_to): Don't bail out early when reaching
530 position beyond to_charpos, if we are scanning backwards.
531 (move_it_vertically_backward): When DY == 0, make sure we get to
532 the first character in the line after the newline.
533
f2cad773
PE
5342011-08-27 Paul Eggert <eggert@cs.ucla.edu>
535
536 * ccl.c: Improve and simplify overflow checking (Bug#9196).
537 (ccl_driver): Do not generate an out-of-range pointer.
538 (Fccl_execute_on_string): Remove unnecessary check for
539 integer overflow, noted by Stefan Monnier in
540 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
541 Remove a FIXME that didn't need fixing.
542 Simplify the newly-introduced buffer reallocation code.
543
0cae2cdb
JB
5442011-08-27 Juanma Barranquero <lekktu@gmail.com>
545
546 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
547
5fc295a4 5482011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 549
70c60eb2 550 Integer and memory overflow issues (Bug#9196).
726e0ab1 551
d31850da
PE
552 * doc.c (get_doc_string): Rework so that
553 get_doc_string_buffer_size is the actual buffer size, rather than
554 being 1 less than the actual buffer size; this makes xpalloc more
555 convenient.
556
a69fbedb
PE
557 * image.c (x_allocate_bitmap_record, cache_image):
558 * xselect.c (Fx_register_dnd_atom):
559 Simplify previous changes by using xpalloc.
560
fe5c5d37
PE
561 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
562 since either will do and ptrdiff_t is convenient with xpalloc.
563
0065d054
PE
564 * charset.c (charset_table_size)
565 (struct charset_sort_data.priority): Now ptrdiff_t.
566 (charset_compare): Don't overflow if priorities differ greatly.
567 (Fsort_charsets): Don't assume list length fits in int.
568 Check for size-calculation overflow when allocating sort data.
569 (syms_of_charset): Allocate an initial charset table that is
570 just under 64 KiB, to avoid problems with glibc malloc and mmap.
571
572 * cmds.c (internal_self_insert): Check for size-calculation overflow.
573
574 * composite.h (struct composition.glyph_len): Now int, not unsigned.
575 The actual value is always <= INT_MAX, and leaving it unsigned made
576 overflow checking harder.
577
578 * dispextern.h (struct glyph_matrix.rows_allocated)
579 (struct face_cache.size): Now ptrdiff_t, for convenience in use
580 with xpalloc. The values are still always <= INT_MAX.
581
582 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
583
584 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
585 (SAFE_NALLOCA): New macro.
586
587 * region-cache.c (struct boundary.pos, find_cache_boundary)
588 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
589 (set_cache_region, invalidate_region_cache)
590 (revalidate_region_cache, know_region_cache, region_cache_forward)
591 (region_cache_backward, pp_cache):
592 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
593 so that ptrdiff_t * can be passed to xpalloc.
594 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
595 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
596 (pp_cache): Don't assume cache_len fits in int.
597 * region-cache.h: Adjust extern decls to match.
598
599 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
600 EMACS_INT, since either will do, for xpalloc.
601
602 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
603 (xnmalloc, xnrealloc, xpalloc): New functions.
604
726e0ab1
PE
605 * bidi.c (bidi_shelve_header_size): New constant.
606 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
607 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
608
51f30bc5 609 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
610 * buffer.c (overlays_at, overlays_in, record_overlay_string)
611 (overlay_strings):
612 Don't update size of array until after memory allocation succeeds,
613 because xmalloc/xrealloc may not return.
0065d054
PE
614 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
615 now that we have proper integer overflow checking.
616 (record_overlay_string, overlay_strings): Catch overflows when
617 calculating size of overlay_str_buf.
726e0ab1 618
0065d054
PE
619 * callproc.c (Fcall_process): Check for size overflow when
620 calculating size of args2.
621 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
622 Normally we prefer signed values, but sticking with ptrdiff_t would
623 require adding more-complicated checks.
726e0ab1
PE
624
625 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
626 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
627 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 628 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
629
630 * character.c (Fstring): Check for size-calculation overflow.
631
632 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
633 unnecessary integer overflow. Check for size overflow.
634 (encode_coding_object): Don't update size until xmalloc succeeds.
635
636 * composite.c (get_composition_id): Check for overflow in glyph
637 length calculations.
638
639 Integer and memory overflow fixes for display code.
640 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
641 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
642 (scrolling_window): Check for overflow in size calculations.
643 (line_draw_cost, realloc_glyph_pool, add_row_entry):
644 Don't assume glyph table len fits in int.
645 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
646 (row_table_size): Now ptrdiff_t, not int.
647 (scrolling_window): Avoid overflow in size calculations.
648 Don't update size until allocation succeeds.
649 * fns.c (concat): Check for overflow in size calculations.
650 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
651 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
652 (NEXT_ALMOST_PRIME_LIMIT): New constant.
653
654 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
655 (get_doc_string): Check for size calculation overflow.
656 Don't update size until allocation succeeds.
657 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
658 EMACS_INT, where ptrdiff_t will do.
659 (Fsubstitute_command_keys): Check for string overflow.
660
661 * editfns.c (set_time_zone_rule): Don't assume environment length
662 fits in int.
663 (message_length): Now ptrdiff_t, not int.
664 (Fmessage_box): Don't update size until allocation succeeds.
665 Don't assume message length fits in int.
666 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
667
0065d054
PE
668 * emacs.c (main): Do not reallocate argv, since there is a null at
669 the end that can be overwritten, and this way there's no need to
670 worry about size-calculation overflow.
671 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
672
673 * eval.c (init_eval_once, grow_specpdl): Don't update size until
674 alloc succeeds.
675 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
676
677 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
678 (x_set_scroll_bar_width, x_figure_window_size):
679 Check for integer overflow.
680 (x_set_alpha): Do not assume XINT fits in int.
681
682 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
683 This is for the members text_lines, text_cols, total_lines, total_cols,
684 where the system imposes an 'int' limit.
685
686 * fringe.c (Fdefine_fringe_bitmap):
687 Don't update size until alloc works.
688
689 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
690 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
691
692 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
693 Check for size-calculation overflow.
694 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
695 do, as we prefer signed integers.
696 (id_to_widget.max_size, id_to_widget.used)
697 (xg_store_widget_in_map, xg_remove_widget_from_map)
698 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
699 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
700 Use and return ptrdiff_t, not int.
701 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
702 * gtkutil.h: Change prototypes to match the above.
703
704 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
705 are duplicate now that they've been promoted to lisp.h.
706 (x_allocate_bitmap_record, x_alloc_image_color)
707 (make_image_cache, cache_image, xpm_load):
708 Don't update size until alloc is done.
709 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
710 (x_detect_edges):
3256efce 711 Check for size calculation overflow.
726e0ab1
PE
712 (ct_colors_allocated_max): New constant.
713 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
714 overflow.
3256efce 715
726e0ab1
PE
716 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
717 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
718 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
719 Use ptrdiff_t, not int, to count maps.
720 (read_char_minibuf_menu_prompt): Check for overflow in size
721 calculations. Don't update size until allocation succeeds. Redo
722 calculations to avoid overflow.
723 * keyboard.h: Change prototypes to match the above.
724
725 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
726 to count maps.
727 (current_minor_maps): Check for size calculation overflow.
728 * keymap.h: Change prototypes to match the above.
729
730 * lread.c (read1, init_obarray): Don't update size until alloc done.
731
732 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
733 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
734
726e0ab1
PE
735 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
736 Now ptrdiff_t, not int.
737 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
738 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
739
740 * process.c (Fnetwork_interface_list): Check for overflow
741 in size calculation.
742
743 * region-cache.c (move_cache_gap): Check for size calculation overflow.
744
745 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
746 overflow. Don't bother calling xmalloc when xrealloc will do.
747
748 * search.c (Freplace_match): Check for size calculation overflow.
749 (Fset_match_data): Don't assume list lengths fit in 'int'.
750
751 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
752 for command line length. Do not attempt to address one before the
753 beginning of an array, as that's not portable.
754
755 * term.c (max_frame_lines): Remove; unused.
756 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
757 not int.
758 (encode_terminal_code, calculate_costs): Check for size
759 calculation overflow.
760 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
761 table lengths and related sizes. Don't update size until alloc
762 done. Redo calculations to avoid overflow.
763 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
764
765 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
766 subtracting pointers.
767 (gobble_line): Check for overflow more carefully. Don't update size
768 until alloc done.
769
770 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
771 Don't update size until alloc done.
772 Redo size calculations to avoid overflow.
773 Check for size calculation overflow.
0065d054 774 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
775
776 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
777 Use ptrdiff_t, not int, for sizes.
778 (store_mode_line_noprop_char): Don't update size until alloc done.
779
0065d054
PE
780 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
781 Use ptrdiff_t, not int, for sizes.
782 (Finternal_make_lisp_face, cache_face):
783 Check for size calculation overflow.
784 (cache_face): Treat size calculation overflows as if they were
785 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
786
787 * xfns.c (x_encode_text, x_set_name_internal)
788 (Fx_change_window_property): Use ptrdiff_t, not int, to count
789 sizes, since they can exceed INT_MAX in size. Check for size
790 calculation overflow.
791
0065d054
PE
792 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
793 (xg_select): Check for size calculation overflow.
726e0ab1
PE
794 Don't update size until alloc done.
795
0065d054 796 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 797 as sprintf is limited to int lengths.
1d526e2f 798
252c5ee1
PE
799 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
800 (X_LONG_MIN): New macros.
864d7ce7
PE
801 Use them to make the following changes clearer.
802 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
803 This change doesn't affect the value now, but it may help remind
804 future maintainers not to raise the value too much later.
805 (SELECTION_QUANTUM): Remove, replacing with ...
806 (selection_quantum): ... new function, which avoids overflow.
807 All uses changed.
808 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
809 assumption that selection length fits in 'int'.
810 (x_reply_selection_request, x_handle_selection_request)
811 (x_get_window_property, receive_incremental_selection)
812 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
813 (lisp_data_to_selection_data, clean_local_selection_data):
814 Use ptrdiff_t, not int, to record length of selection.
815 (x_reply_selection_request, x_get_window_property)
816 (receive_incremental_selection, x_property_data_to_lisp):
817 Redo calculations to avoid overflow.
818 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 819 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
820 something.
821 (x_get_window_property, receive_incremental_selection)
822 (lisp_data_to_selection_data, x_property_data_to_lisp):
823 Check for size-calculation overflow.
824 (x_get_window_property, receive_incremental_selection)
825 (lisp_data_to_selection_data, Fx_register_dnd_atom):
826 Don't store size until memory allocation succeeds.
827 (x_get_window_property): Plug memory leak on memory exhaustion.
828 Don't double-block input; malloc is safe here. Don't assume 2**34
829 - 4 fits in unsigned long. Add an xassert to check
830 XGetWindowProperty overflow. Be more careful about overflow
831 calculations, and distinguish size from memory overflow better.
832 (receive_incremental_selection): When tracing, don't assume
833 unsigned int is less than INT_MAX.
834 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
835 harmful) conversions of unsigned short to int.
836 (lisp_data_to_selection_data): Don't assume that integers
837 in the range -65535 through -1 fit in an X unsigned short.
838 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
839 result parameters unless successful. Rely on cons_to_unsigned
840 to report problems with elements; the old code wasn't right anyway.
841 (x_check_property_data): Check for int overflow; we cannot use
842 a wider type due to X limits.
843 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
844
726e0ab1 845 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 846
0065d054
PE
847 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
848 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
849 (x_color_cells): Don't store size until memory allocation succeeds.
850 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 851 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
852 (x_term_init): Don't assume length fits in int (sprintf is limited
853 to int size).
bc18e09d 854
ebfa62c0
PE
855 Use ptrdiff_t for composition IDs.
856 * character.c (lisp_string_width):
857 * composite.c (composition_table_size, n_compositions)
858 (get_composition_id, composition_gstring_from_id):
859 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
860 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
861 * window.c (Frecenter):
862 Use ptrdiff_t, not int, for composition IDs.
863 * composite.c (get_composition_id): Check for integer overflow.
864 * composite.h: Adjust prototypes to match the above changes.
865
d3411f89
PE
866 Use ptrdiff_t for hash table indexes.
867 * category.c (hash_get_category_set):
868 * ccl.c (ccl_driver):
869 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
870 * coding.c (coding_system_charset_list, detect_coding_system):
871 * coding.h (struct coding_system.id):
872 * composite.c (get_composition_id, gstring_lookup_cache):
873 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
874 * image.c (xpm_get_color_table_h):
875 * lisp.h (hash_lookup, hash_put):
876 * minibuf.c (Ftest_completion):
877 Use ptrdiff_t for hash table indexes, not int (which is too
878 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
879 32-bit --with-wide-int hosts).
880
e097a6fa
PE
881 * charset.c (Fdefine_charset_internal): Check for integer overflow.
882 Add a FIXME comment about memory leaks.
883 (syms_of_charset): Don't assume xmalloc returns.
884
5637687f
PE
885 Don't assume that stated character widths fit in int.
886 * character.c (Fchar_width, c_string_width, lisp_string_width):
887 * character.h (CHAR_WIDTH):
888 * indent.c (MULTIBYTE_BYTES_WIDTH):
889 Use sanitize_char_width to avoid undefined and/or bad behavior
890 with outlandish widths.
891 * character.h (sanitize_tab_width): Renamed from sanitize_width,
892 now that we have two such functions. All uses changed.
893 (sanitize_char_width): New inline function.
894
a2271ba2
PE
895 Don't assume that tab-width fits in int.
896 * character.h (sanitize_width): New inline function.
897 (SANE_TAB_WIDTH): New macro.
898 (ASCII_CHAR_WIDTH): Use it.
899 * indent.c (sane_tab_width): Remove. All uses replaced by
900 SANE_TAB_WIDTH (current_buffer).
901 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
902
18c52557
PE
903 * fileio.c: Integer overflow issues with file modes.
904 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
905
caeeedc1
PE
906 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
907 Remove unreachable code.
908 (read_hex, load_charset_map_from_file): Check for integer overflow.
909
50849c52
PE
910 * xterm.c: don't go over XClientMessageEvent limit
911 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
912 (x_send_scroll_bar_event): Likewise. Check that the size does not
913 exceed limits imposed by XClientMessageEvent, as well as the usual
914 ptrdiff_t and size_t limits.
915
b13995db
PE
916 * keyboard.c: Overflow, signedness and related fixes.
917 (make_lispy_movement): Use same integer type in forward decl
918 that is used in the definition.
919 (read_key_sequence, keyremap_step):
920 Change bufsize argument back to int, undoing my 2011-03-30 change.
921 We prefer signed types, and int is wide enough here.
922 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
923 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
924 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
925 length, not size_t. Use ptrdiff_t for index, not int.
926 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
927 possibility of integer overflow.
928
13464394
PE
929 Overflow, signedness and related fixes for images.
930
931 * dispextern.h (struct it.stack[0].u.image.image_id)
932 (struct_it.image_id, struct image.id, struct image_cache.size)
933 (struct image_cache.used, struct image_cache.ref_count):
934 * gtkutil.c (update_frame_tool_bar):
935 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
936 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
937 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
938 * nsmenu.m (update_frame_tool_bar):
939 * xdisp.c (calc_pixel_width_or_height):
940 * xfns.c (image_cache_refcount):
941 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
942 on typical 64-bit hosts.
943
944 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
945 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
946 Omit unnecessary casts to int.
947 (parse_image_spec): Check that integers fall into 'int' range
948 when the callers expect that.
949 (image_ascent): Redo ascent calculation to avoid int overflow.
950 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
951 (lookup_image): Remove unnecessary tests.
952 (xbm_image_p): Locals are now of int, not EMACS_INT,
953 since parse_image_check makes sure they fit into int.
954 (png_load, gif_load, svg_load_image):
955 Prefer int to unsigned where either will do.
956 (tiff_handler): New function, combining the cores of the
957 old tiff_error_handler and tiff_warning_handler. This
958 function is rewritten to use vsnprintf and thereby avoid
959 stack buffer overflows. It uses only the features of vsnprintf
960 that are common to both POSIX and native Microsoft.
961 (tiff_error_handler, tiff_warning_handler): Use it.
962 (tiff_load, gif_load, imagemagick_load_image):
963 Don't assume :index value fits in 'int'.
964 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
965 (imagemagick_load_image): Check that crop parameters fit into
966 the integer types that MagickCropImage accepts. Don't assume
967 Vimagemagick_render_type has a nonnegative value. Don't assume
968 size_t fits in 'long'.
969 (gs_load): Use printmax_t to print the widest integers possible.
970 Check for integer overflow when computing image height and width.
971
c11821d4
EZ
9722011-08-26 Eli Zaretskii <eliz@gnu.org>
973
974 * xdisp.c (redisplay_window): Don't force window start if point
975 will be invisible in the resulting window. (Bug#9324)
976
0c95fcf7
EZ
9772011-08-25 Eli Zaretskii <eliz@gnu.org>
978
979 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
980 the display spec is of the form `(space ...)'.
981 (handle_display_spec): Return the value returned by
982 handle_single_display_spec, not just 1 or zero.
983 (handle_single_display_spec): If the display spec is of the form
984 `(space ...)', and specifies display in the text area, return 2
985 rather than 1.
fee65a97 986 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
987 accurately, and prefer exact match for point under bidi. Don't
988 advance `row' beyond the last row of the window.
0c95fcf7
EZ
989
990 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
991 into disp_prop; all users changed.
992
993 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
994 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
995 for the text covered by the display property.
996
e4ed06f1
CY
9972011-08-25 Chong Yidong <cyd@stupidchicken.com>
998
999 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1000 Change return value to nil.
1001 (Frecord_buffer): Delete unused function.
1002
f67cdd7f
EZ
10032011-08-24 Eli Zaretskii <eliz@gnu.org>
1004
5980d4c6
EZ
1005 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1006 buffers, return left-to-right.
8610fe8b
EZ
1007 (set_cursor_from_row): Consider candidate row a win if its glyph
1008 represents a newline and point is on that newline. Fixes cursor
1009 positioning on the newline at EOL of R2L text within L2R
1010 paragraph, and vice versa.
1011 (try_cursor_movement): Check continued rows, in addition to
1012 continuation rows. Fixes unwarranted scroll when point enters a
1013 continued line of R2L text within an L2R paragraph, or vice versa.
1014 (cursor_row_p): Consider the case of point being equal to
1015 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1016 from the end of a short line to the beginning of a continued line
1017 of R2L text within L2R paragraph.
1018 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1019 composed characters.
5980d4c6 1020
f67cdd7f
EZ
1021 * bidi.c (bidi_check_type): Use xassert.
1022 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1023 members.
1024
bca633fb
EZ
10252011-08-23 Eli Zaretskii <eliz@gnu.org>
1026
1027 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1028 a character.
1029
4a5885a7
CY
10302011-08-23 Chong Yidong <cyd@stupidchicken.com>
1031
1032 * nsfont.m (ns_otf_to_script): Fix typo.
1033
0902a04e
KH
10342011-08-22 Kenichi Handa <handa@m17n.org>
1035
1036 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1037 extra slot even if the purpose is char-code-property-table.
1038
1a2e6670
EZ
10392011-08-23 Eli Zaretskii <eliz@gnu.org>
1040
8ddde651
EZ
1041 * xdisp.c (redisplay_window): When computing centering_position,
1042 account for the height of the header line. (Bug#8874)
1043
425cc014
EZ
1044 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1045 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1046 candidate is selected by the mouse, and that candidate has a
1047 composed character under the mouse.
1048
1a2e6670
EZ
1049 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1050 coordinates reported by pos-visible-in-window-p for a composed
1051 character in column zero.
1052
8b76d6f8
SM
10532011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1054
1055 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1056
dac347dd
EZ
10572011-08-22 Eli Zaretskii <eliz@gnu.org>
1058
1059 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1060 consider it a hit if to_charpos is anywhere in the range of the
1061 composed buffer positions.
1062
e013fb34
CY
10632011-08-22 Chong Yidong <cyd@stupidchicken.com>
1064
1065 * image.c (gif_load): Don't assume that each subimage has the same
1066 dimensions as the base image. Handle disposal method that is
1067 "undefined" by the gif spec (Bug#9335).
1068
bd1ba3e8
CY
10692011-08-20 Chong Yidong <cyd@stupidchicken.com>
1070
1071 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1072 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1073
54a1215b
EZ
10742011-08-19 Eli Zaretskii <eliz@gnu.org>
1075
823564e5
EZ
1076 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1077 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1078 from an Org mode buffer to a Speedbar frame.
1079
54a1215b
EZ
1080 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1081 a composition, take its buffer position from IT->cmp_it.charpos.
1082 Fixes cursor positioning at the beginning of a line that begins
1083 with a composed character.
1084
9778ebcc
EZ
10852011-08-18 Eli Zaretskii <eliz@gnu.org>
1086
0be6ee06
EZ
1087 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1088 character bidirectional type, use STRONG_L instead. Fixes crashes
1089 in a buffer produced by `describe-categories'.
1090
9778ebcc
EZ
1091 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1092 members before the level stack, so they would be saved and
1093 restored when copying iterator state. Fixes incorrect reordering
1094 around TABs covered by display properties.
1095
156bffbe
AS
10962011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1097
1098 * process.c (Fnetwork_interface_list): Correctly determine buffer
1099 size.
1100
72ad093b
CY
11012011-08-17 Chong Yidong <cyd@stupidchicken.com>
1102
1103 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1104 (internal_condition_case_2, internal_condition_case_n):
1105 Remove unnecessary aborts (Bug#9081).
72ad093b 1106
35774242
EZ
11072011-08-17 Eli Zaretskii <eliz@gnu.org>
1108
1109 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1110 has no `load' handler, try opening the file locally. (Bug#9311)
1111
db76dd85
KB
11122011-08-16 Ken Brown <kbrown@cornell.edu>
1113
1114 * gmalloc.c: Expand comment.
1115
b215eee5
EZ
11162011-08-16 Eli Zaretskii <eliz@gnu.org>
1117
1118 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1119 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1120
a4579d33
KB
11212011-08-16 Ken Brown <kbrown@cornell.edu>
1122
1123 Fix memory allocation problems in Cygwin build (Bug#9273).
1124
1125 * unexcw.c ( __malloc_initialized): Declare external variable.
1126 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1127
8b76d6f8
SM
1128 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1129 New variables.
a4579d33
KB
1130 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1131 dumped emacs.
1132 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1133 in the static heap.
1134 [CYGWIN] (special_realloc): New function.
1135 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1136 requests to realloc storage in the static heap.
1137
3ebec551
PE
11382011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1139
1140 * bidi.c (bidi_initialize): Remove unused local.
1141
9fd8be00
EZ
11422011-08-15 Eli Zaretskii <eliz@gnu.org>
1143
474a8465
EZ
1144 * biditype.h: File removed.
1145
1146 * bidimirror.h: File removed.
1147
1148 * deps.mk (bidi.o): Remove biditype.h and
1149 bidimirror.h.
1150
1151 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1152 bidimirror.h.
1153
1154 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1155
1156 * chartab.c: Improve commentary for the uniprop_table API.
1157
32413314
EZ
1158 * bidi.c (bidi_paragraph_init): Support zero value of
1159 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1160 (bidi_initialize): Use uniprop_table instead of including
1161 biditype.h and bidimirror.h.
32413314 1162
9fd8be00
EZ
1163 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1164 coordinates of the iterator when restoring from ppos_it.
1165 (Bug#9296)
1166
5cf2b69b
KH
11672011-08-14 Kenichi Handa <handa@m17n.org>
1168
1169 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1170 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1171
daf17d00
EZ
11722011-08-14 Eli Zaretskii <eliz@gnu.org>
1173
1174 * xdisp.c (move_it_in_display_line_to): Don't invoke
1175 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1176 ppos_it. Fixes vertical cursor motion when line beginning is
1177 covered by an image. (Bug#9296)
1178
08e3161a
JD
11792011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1180
1181 * nsterm.h (ns_run_ascript): Declare.
1182 (NSAPP_DATA2_RUNASSCRIPT): Define.
1183
1184 * nsfns.m (as_script, as_result, as_status): New static variables.
1185 (ns_run_ascript): New function.
5e617bc2 1186 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1187 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1188 the event loop. Get status from as_status (Bug#7276).
1189
1190 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1191 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1192 the event loop (Bug#7276).
1193
a3720aa2
AS
11942011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1195
1196 * gnutls.c (QCgnutls_bootprop_priority)
1197 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1198 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1199 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1200 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1201 (QCgnutls_bootprop_verify_hostname_error)
1202 (QCgnutls_bootprop_callbacks_verify): Rename from
1203 Qgnutls_bootprop_..., all uses changed.
1204
1205 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1206 uses changed.
1207
0a0d27fb
PE
12082011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1209
19d5c50c
PE
1210 * xfaces.c (Qframe_set_background_mode): Now static.
1211 * dispextern.h (Qframe_set_background_mode): Remove decl.
1212
0a0d27fb
PE
1213 * process.c (Fnetwork_interface_info): Declare local only if needed.
1214
377538cb
JD
12152011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1216
1217 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1218 (Fnetwork_interface_list): Allocate in increments of bytes instead
1219 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1220 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1221 sockaddr.
1222 (struct ifflag_def): notrailers is smart on OSX.
1223 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1224 Get hardware address with getifaddrs if available.
1225
08fff70c
EZ
12262011-08-12 Eli Zaretskii <eliz@gnu.org>
1227
1228 * xdisp.c (iterate_out_of_display_property): xassert that
1229 IT->position is set to within IT->object's boundaries. Break from
1230 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1231 when IT->position is set up wrongly due to some bug.
1232 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1233 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1234 entry. Force push_it to save on the stack the current
1235 buffer/string position, to be restored by pop_it. Fix flags in
1236 the iterator structure wrt the object coming from a display
1237 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1238 properties. (Bug#9284)
1239
7be1c708 12402011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1241
7be1c708
CY
1242 * fontset.c (fontset_get_font_group): Add proper type checks.
1243 (Bug#9172)
aac0c6e3 1244
7be1c708 12452011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1246
7be1c708
CY
1247 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1248 and LC_VERSION_MIN_MACOSX.
1249 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1250 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1251
97bb72a6
EZ
12522011-08-08 Eli Zaretskii <eliz@gnu.org>
1253
1254 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1255 no-display-properties-and-no-overlays under bidi display.
1256 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1257 properties and overlays.
97bb72a6 1258
d5617611
CY
12592011-08-08 Chong Yidong <cyd@stupidchicken.com>
1260
37e11a63
CY
1261 * editfns.c (Fset_time_zone_rule): Document relationship with the
1262 setenv function.
1263
d5617611
CY
1264 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1265 the font entity extracted from the cache (Bug#8109).
1266
58872834
CY
12672011-08-07 Chong Yidong <cyd@stupidchicken.com>
1268
1269 * composite.c (autocmp_chars): Don't reset point. That is done by
1270 restore_point_unwind (Bug#5984).
1271
75bfc667
JL
12722011-08-07 Juri Linkov <juri@jurta.org>
1273
1274 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1275 to show the arg `TIME' instead of `TIMEVAL'.
1276
d1410150
EZ
12772011-08-06 Eli Zaretskii <eliz@gnu.org>
1278
1279 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1280 display property strides EOL and includes a newline, as in
1281 longlines-mode. (Bug#9254)
75b771e4
EZ
1282 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1283 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1284
1285 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1286 is non-zero, even if the data buffer is NULL. Fixes a crash in
1287 vertical-motion with longlines-mode. (Bug#9254)
1288
35928349
EZ
12892011-08-05 Eli Zaretskii <eliz@gnu.org>
1290
ec7cc85b
EZ
1291 * bidi.c <bidi_cache_total_alloc>: Now static.
1292 (bidi_initialize): Initialize bidi_cache_total_alloc.
1293
8b76d6f8 1294 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1295 cache. (Bug#9221)
1296
1297 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1298 amount allocated this far in `bidi_cache_total_alloc'.
1299 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1300 non-zero, only free the data buffer without restoring the cache
1301 contents. All callers changed.
1302
1303 * dispextern.h (bidi_unshelve_cache): Update prototype.
1304
1305 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1306 (move_it_in_display_line, move_it_to)
1307 (move_it_vertically_backward, move_it_by_lines): Replace the call
1308 to xfree to an equivalent call to bidi_unshelve_cache.
1309 (move_it_in_display_line_to): Fix logic of returning
412b6358 1310 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1311
e2e2423b
EZ
13122011-08-05 Eli Zaretskii <eliz@gnu.org>
1313
1314 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1315 came from a string character with a `cursor' property. (Bug#9229)
1316
ae9e757a
JD
13172011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1318
1319 * Makefile.in (LIB_PTHREAD): New variable.
1320 (LIBES): Add LIB_PTHREAD (Bug#9216).
1321
1322 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1323 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1324
213bd7f2
AS
13252011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1326
1327 * regex.c (re_iswctype): Remove some redundant boolean
1328 conversions.
1329
99aaf75f
JD
13302011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1331
1332 * xterm.c (x_find_topmost_parent): New function.
1333 (x_set_frame_alpha): Find topmost parent window with
1334 x_find_topmost_parent and set the property there also (bug#9181).
1335 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1336
c74e9d86
PE
13372011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1338
1339 * callproc.c (Fcall_process): Avoid vfork clobbering
1340 the local vars buffer, coding_systems, current_dir.
1341
640c8776
SM
13422011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1343
1344 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1345
f26d0e4c
PE
13462011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1347
8a10d76c
PE
1348 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1349 so that it is not optimized away.
1350
f26d0e4c
PE
1351 * xdisp.c (compute_display_string_pos): Remove unused local.
1352
55439c61
EZ
13532011-08-02 Eli Zaretskii <eliz@gnu.org>
1354
1355 Fix slow cursor motion and scrolling in large buffers with
1356 selective display, like Org Mode buffers. (Bug#9218)
1357
1358 * dispextern.h (struct bidi_it): New member disp_prop_p.
1359
1360 * xdisp.c: Remove one-slot cache of display string positions.
1361 (compute_display_string_pos): Accept an additional argument
5e617bc2 1362 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1363 for a display string or property. If found, set DISP_PROP_P
1364 non-zero.
1365
1366 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1367 DISP_PROP_P, and pass it to compute_display_string_pos.
1368 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1369 non-zero. All callers of bidi_fetch_char changed.
1370
fb33fa43
SM
13712011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1372
1373 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1374
b099e063
DM
13752010-12-03 Don March <don@ohspite.net>
1376
1377 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1378 last character M-[char] is translated to ESC [char] (bug#7541).
1379
5cc7f7af
KH
13802011-08-02 Kenichi Handa <handa@m17n.org>
1381
d0fffa3f 1382 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1383
1384 * chartab.c (uniprop_table): Make it non-static.
1385
525d5e6e
EZ
13862011-08-01 Eli Zaretskii <eliz@gnu.org>
1387
1388 * xdisp.c (forward_to_next_line_start): Accept additional argument
1389 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1390 on the newline.
1391 (reseat_at_next_visible_line_start): Use the bidi iterator state
1392 returned by forward_to_next_line_start to restore the state of
1393 it->bidi_it after backing up to previous newline. (Bug#9212)
1394
31011111
AS
13952011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1396
1397 * regex.c (re_comp): Protoize.
1398 (re_exec): Fix return type.
1399 (regexec): Fix type of `ret'. (Bug#9203)
1400
476371c4
PE
14012011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1402
e5d76069
PE
1403 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1404 This is needed if max-image-size is a floating-point number.
1405
9a79b20c
AS
14062011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1407
1408 * print.c (print_object): Print empty symbol as ##.
1409
1410 * lread.c (read1): Read ## as empty symbol.
1411
d8c2fa78
AA
14122011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1413
1414 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1415 setting frame foreground color (Bug#9175).
1416 (x_set_background_color): Likewise.
1417
ffe57a7a
AA
1418 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1419 contents (Bug#9176).
1420 (EmacsTooltip -init): Remove bezels and add shadows to
1421 tooltip windows.
1422
bf3492a5
AA
1423 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1424 or scroll bar (Bug#8470).
1425
d55e9c53
AA
1426 * nsfont.m (nsfont_open): Remove assignment to voffset and
1427 unnecessary vars hshink, expand, hd, full_height, min_height.
1428 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1429
1430 * nsterm.h (nsfont_info): Remove voffset field.
1431
d8c2fa78 14322011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1433
1434 Implement strike-through and overline on NextStep (Bug#8863).
1435
1436 * nsfont.m (nsfont_open): Use underline position provided by font,
1437 instead of hard-coded value of 2.
1438 (nsfont_draw): Call ns_draw_text_decoration instead.
1439
1440 * nsterm.h: Add declaration for ns_draw_text_decoration.
1441
1442 * nsterm.m (ns_draw_text_decoration): New function for drawing
1443 underline, overline, and strike-through.
1444 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1445 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1446 accommodate underlining, etc.
4843aac3 1447
4cc60b9b
EZ
14482011-07-28 Eli Zaretskii <eliz@gnu.org>
1449
bc7ece87
EZ
1450 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1451 default.
4cc60b9b 1452
476371c4
PE
14532011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1454
66606eea
PE
1455 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1456 Without this fix, if a signal arrives just after memory fills up,
1457 'malloc' might be invoked reentrantly.
1458
476371c4
PE
1459 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1460 In other words, assume that every image size is allowed, on non-X
1461 hosts. This assumption is probably wrong, but it lets Emacs compile.
1462
f3fcc40d
AS
14632011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1464
1465 * regex.c (re_iswctype): Convert return values to boolean.
1466
350c992f
EZ
14672011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1468
1469 * xdisp.c (compute_display_string_pos): Don't use cached display
1470 string position if the buffer had its restriction changed.
1471 (Bug#9184)
1472
5266b4bb
PE
14732011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1474
1475 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1476
2573a837 14772011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1478
41f55ccd 1479 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1480
39e378da
PE
1481 * bidi.c: Integer size and overflow fixes.
1482 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1483 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1484 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1485 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1486 (bidi_find_other_level_edge):
1487 Use ptrdiff_t instead of EMACS_INT where either will do.
1488 This works better on 32-bit hosts configured --with-wide-int.
1489 (bidi_cache_ensure_space): Check for size-calculation overflow.
1490 Use % rather than repeated addition, for better worst-case speed.
1491 Don't set bidi_cache_size until after xrealloc returns, because it
1492 might not return.
1493 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1494 (bidi_cache_ensure_space): Also check that the bidi cache size
1495 does not exceed that of the largest Lisp string or buffer. See Eli
1496 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1497
5e927815
PE
1498 * alloc.c (__malloc_size_t): Remove.
1499 All uses replaced by size_t. See Andreas Schwab's note
1500 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1501
ca4aa935
PE
1502 * image.c: Improve checking for integer overflow.
1503 (check_image_size): Assume that f is nonnull, since
1504 it is always nonnull in practice. This is one less thing to
1505 worry about when checking for integer overflow later.
1506 (x_check_image_size): New function, which checks for integer
1507 overflow issues inside X.
1508 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1509 This removes the need for a memory_full check.
1510 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1511 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1512 (xbm_read_bitmap_data): Change locals back to 'int', since
1513 their values must fit in 'int'.
1514 (xpm_load_image, png_load, tiff_load):
1515 Invoke x_create_x_image_and_pixmap earlier,
1516 to avoid much needless work if the image is too large.
1517 (tiff_load): Treat overly large images as if
1518 x_create_x_image_and_pixmap failed, not as malloc failures.
1519 (gs_load): Use x_check_image_size.
1520
5f8f9cc2
PE
1521 * gtkutil.c: Omit integer casts.
1522 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1523 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1524
5adf60bc
PE
1525 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1526
c8907a93
PE
1527 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1528 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1529 would wrongly return t on a 64-bit host.
1530
e3c25c68
PE
1531 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1532 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1533 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1534 and therefore cause GCC to emit a bogus diagnostic in some cases.
1535
3f791afe
PE
1536 * image.c: Integer signedness and overflow and related fixes.
1537 This is not an exhaustive set of fixes, but it's time to
1538 record what I've got.
1539 (lookup_pixel_color, check_image_size): Remove redundant decls.
1540 (check_image_size): Don't assume that arbitrary EMACS_INT values
1541 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1542 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1543 (tiff_load, imagemagick_load_image):
1544 Check for overflow in size calculations.
1545 (x_create_x_image_and_pixmap): Remove unnecessary test for
1546 xmalloc returning NULL; that can't happen.
1547 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1548 (xpm_color_bucket): Use better integer hashing function.
1549 (xpm_cache_color): Don't possibly over-allocate memory.
1550 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1551 (gif_memory_source):
1552 Use ptrdiff_t, not int or size_t, to record sizes.
1553 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1554 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1555 either works, as we prefer signed integers.
1556 (tiff_read_from_memory, tiff_write_from_memory):
1557 Return tsize_t, not size_t, since that's what the TIFF API wants.
1558 (tiff_read_from_memory): Don't fail simply because the read would
1559 go past EOF; instead, return a short read.
1560 (tiff_load): Omit no-longer-needed casts.
1561 (Fimagemagick_types): Don't assume size fits into 'int'.
1562
3cc5a532
PE
1563 Improve hashing quality when configured --with-wide-int.
1564 * fns.c (hash_string): New function, taken from sxhash_string.
1565 Do not discard information about ASCII character case; this
1566 discarding is no longer needed.
1567 (sxhash-string): Use it. Change sig to match it. Caller changed.
1568 * lisp.h: Declare it.
1569 * lread.c (hash_string): Remove, since we now use fns.c's version.
1570 The fns.c version returns a wider integer if --with-wide-int is
1571 specified, so this should help the quality of the hashing a bit.
1572
b312a492
PE
1573 * emacs.c: Integer overflow minor fix.
1574 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1575 Define only if GNU_LINUX.
1576 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1577
dfd153ae
PE
1578 * dispnew.c: Integer signedness and overflow fixes.
1579 Remove unnecessary forward decls, that were a maintenance hassle.
1580 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1581 All uses changed.
1582 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1583 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1584 (prepare_desired_row, line_draw_cost):
1585 Use int, not unsigned, where either works.
1586 (save_current_matrix, restore_current_matrix):
1587 Use ptrdiff_t, not size_t, where either works.
1588 (init_display): Check for overflow more accurately, and without
1589 relying on undefined behavior.
1590
a81d11a3
PE
1591 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1592 Remove, replacing with the new symbols in lisp.h. All uses changed.
1593 * fileio.c (make_temp_name):
1594 * filelock.c (lock_file_1, lock_file):
1595 * xdisp.c (message_dolog):
1596 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1597 Use pMd etc. instead.
1598 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1599 replacing the pWIDE etc. symbols removed from editfns.c.
1600
3300e6fd
PE
1601 * keyboard.h (num_input_events): Now uintmax_t.
1602 This is (very slightly) less likely to mess up due to wraparound.
1603 All uses changed.
1604
fd05c7e9
PE
1605 * buffer.c: Integer signedness fixes.
1606 (alloc_buffer_text, enlarge_buffer_text):
1607 Use ptrdiff_t rather than size_t when either will do, as we prefer
1608 signed integers.
1609
903fe15d
PE
1610 * alloc.c: Integer signedness and overflow fixes.
1611 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1612 (__malloc_size_t): Default to size_t, not to int.
1613 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1614 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1615 Prefer ptrdiff_t to size_t when either would do, as we prefer
1616 signed integers.
1617 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1618 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1619 Now const. Initialize with values that are in range even if char
1620 is signed.
1621 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1622 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1623 These functions do the right thing with sizes > 2**32.
1624 (check_depth): Now ptrdiff_t, not int.
1625 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1626 Adjust to new way of storing sizes. Check for size overflow bugs
1627 in rest of code.
1628 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1629 slightly wrong anyway, as it missed one instance of
1630 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1631 (refill_memory_reserve): Omit needless cast to size_t.
1632 (mark_object_loop_halt): Mark as externally visible.
1633
ac82cc6a
PE
1634 * xselect.c: Integer signedness and overflow fixes.
1635 (Fx_register_dnd_atom, x_handle_dnd_message):
1636 Use ptrdiff_t, not size_t, since we prefer signed.
1637 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1638 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1639 x_dnd_atoms_size and x_dnd_atoms_length.
1640
c2d1e36d
PE
1641 * doprnt.c: Prefer signed to unsigned when either works.
1642 * eval.c (verror):
1643 * doprnt.c (doprnt):
1644 * lisp.h (doprnt):
1645 * xdisp.c (vmessage):
1646 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1647 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1648 prefer signed arithmetic to avoid comparison confusion.
1649 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1650 but is a bit tricky.
1651
0e926e56
PE
1652 Assume freestanding C89 headers, string.h, stdlib.h.
1653 * data.c, doprnt.c, floatfns.c, print.c:
1654 Include float.h unconditionally.
1655 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1656 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1657 * regex.c: Likewise for stddef.h, string.h.
1658 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1659 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1660 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1661 (STDC_HEADERS): Remove obsolete defines.
1662 * sysdep.c: Include limits.h unconditionally.
1663
9cfdb3ec
PE
1664 Assume support for memcmp, memcpy, memmove, memset.
1665 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1666 * regex.c (memcmp, memcpy):
1667 Remove; we assume C89 now.
1668
1669 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1670 (__malloc_safe_bcopy): Remove; no longer needed.
1671
cf950e6b 1672 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1673 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1674 well either way, and we prefer signed to unsigned.
1675
dbf38e02
LMI
16762011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1677
1678 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1679 closes the connection while we're reading (bug#9182).
1680
d6f0886c 16812011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1682
d6f0886c
JD
1683 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1684 are specified (Bug#9168).
24e0f6b1 1685
2eb1f9e6
PE
16862011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1687
1688 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1689 Found by GCC static checking and --with-wide-int on a 32-bit host.
1690
22381272 16912011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1692
1693 * xdisp.c (compute_display_string_pos): Fix logic of caching
1694 previous display string position. Initialize cached_prev_pos to
1695 -1. Fixes slow-down at the beginning of a buffer.
1696
f25e39b4
EZ
16972011-07-24 Eli Zaretskii <eliz@gnu.org>
1698
1699 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1700 for attrs[LFACE_FONTSET_INDEX].
1701
04c4b52e
PE
17022011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1703
1704 * xml.c (parse_region): Remove unused local
1705 that was recently introduced.
1706
c1734fbd
EZ
17072011-07-23 Eli Zaretskii <eliz@gnu.org>
1708
be18c5a5
EZ
1709 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1710 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1711
c1734fbd
EZ
1712 * xdisp.c (move_it_in_display_line_to): Record the best matching
1713 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1714 exit if none of the characters scanned was an exact match.
1715 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1716 when exact match is impossible due to invisible text, and the
1717 lines are truncated.
1718
a258d627
JD
17192011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1720
1721 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1722 for OSX >= 10.7.
1723
b6d5a689
EZ
17242011-07-22 Eli Zaretskii <eliz@gnu.org>
1725
0f74f785
EZ
1726 Fix a significant slow-down of cursor motion with C-n, C-p,
1727 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1728 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1729 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1730 (next_element_from_buffer): Call compute_stop_pos_backwards to
1731 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1732 base_level_stop.
1733 (reseat): Don't look for prev_stop, as that could mean a very long
1734 run.
1735 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1736 <cached_disp_overlay_modiff>: Cache for last found display string
1737 position.
551918c1 1738 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1739 about the same buffer in the same area of character positions, and
1740 the buffer wasn't changed since the time the display string
1741 position was cached.
551918c1 1742
b2d0c91a
EZ
17432011-07-22 Eli Zaretskii <eliz@gnu.org>
1744
1745 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1746 is an integer, which is important for empty lines. (Bug#9149)
1747
043604ee
CY
17482011-07-22 Chong Yidong <cyd@stupidchicken.com>
1749
1750 * frame.c (Fmodify_frame_parameters): In tty case, update the
1751 default face if necessary (Bug#4238).
1752
da4adb04
CY
17532011-07-21 Chong Yidong <cyd@stupidchicken.com>
1754
1755 * editfns.c (Fstring_to_char): No need to explain what a character
1756 is in the docstring (Bug#6576).
1757
9abd0532
LMI
17582011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1759
1760 * xml.c (parse_region): Make sure we always return a tree.
1761
36881d16
HK
17622011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1763
1764 * xml.c (parse_region): If a document contains only comments,
1765 return that, too.
1766
1e98674d
LMI
17672011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1768
1769 * xml.c (make_dom): Return comments, too.
1770
590bd467
PE
17712011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1772
1773 Port to OpenBSD.
1774 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1775 and the surrounding thread.
1776 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1777 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1778 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1779 timer goes off.
1780 * s/openbsd.h (BROKEN_SIGIO): Define.
1781 * unexelf.c (unexec) [__OpenBSD__]:
1782 Don't update the .mdebug section of the Alpha COFF symbol table.
1783
f41628b2
LMI
17842011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1785
1786 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1787 (bug#8460).
1788
b59b67c5
PE
17892011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1790
15e3a074
PE
1791 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1792 This fixes some race conditions on the permissions of any newly
1793 created file.
1794
41bed37d
PE
1795 * alloc.c (valid_pointer_p): Use pipe, not open.
1796 This fixes some permissions issues when debugging.
1797
b59b67c5
PE
1798 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1799 If fchown fails to set both uid and gid, try to set just gid,
1800 as that is sometimes allowed. Adjust the file's mode to eliminate
1801 setuid or setgid bits that are inappropriate if fchown fails.
1802
925a6be7
SM
18032011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1804
1805 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1806 to compare Lisp_Objects.
1807 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1808 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1809 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1810
52968808
AS
18112011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1812
0a6a104b
AS
1813 * lread.c (read_integer): Unread even EOF character.
1814 (read1): Likewise. Properly record start position of symbol.
1815
52968808
AS
1816 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1817 symbol character follows.
1818
9e381cdd
PE
18192011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1820
1821 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1822 This works around a problem with the previous change to Fcopy_file.
1823 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1824 and without this change, GCC might complain about discarding
1825 fchown's return value.
1826
b5641435
JB
18272011-07-16 Juanma Barranquero <lekktu@gmail.com>
1828
1829 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1830
a8031457
PE
18312011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1832
1833 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1834
dd889327
LMI
18352011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1836
750c33f7
LMI
1837 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1838 it's used from the C level.
1839
dd889327
LMI
1840 * process.c: Use the same condition for POLL_FOR_INPUT in both
1841 keyboard.c and process.c (bug#1858).
1842
87e86684
LM
18432011-07-09 Lawrence Mitchell <wence@gmx.li>
1844
1845 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1846 (Fgnutls_boot): Use it.
1847
64348f40
AS
18482011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1849
1850 * doc.c (Fsubstitute_command_keys): Revert last change.
1851
1d698799
LMI
18522011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1853
f863868c
LMI
1854 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1855 quotes the next character, and doesn't affect other longer
1856 sequences (bug#8935).
1857
1d698799
LMI
1858 * lread.c (syms_of_lread): Clarify that is isn't only
1859 `eval-buffer' and `eval-defun' that's affected by
1860 `lexical-binding' (bug#8460).
1861
aa4b6df6
EZ
18622011-07-15 Eli Zaretskii <eliz@gnu.org>
1863
1864 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1865 bidi redisplay when a line includes both an image and is
1866 truncated.
1867
5d856da6
PE
18682011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1869
ad6042bb
PE
1870 Fix minor problems found by static checking.
1871 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1872 (elsz): Now a signed constant, not a size_t var. We prefer signed
1873 types to unsigned, to avoid integer comparison confusion. Without
1874 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1875 "cannot optimize loop, the loop counter may overflow", a symptom
1876 of the confusion.
f00bbb22 1877 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1878 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1879
6468f31c
LMI
18802011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1881
49080b10
LMI
1882 * search.c (Fre_search_backward): Mention `case-fold-search' in
1883 all the re_search_* functions (bug#8138).
1884
6468f31c
LMI
1885 * keyboard.c (Fopen_dribble_file): Document when the file is
1886 closed (bug#8056).
1887
c965adc5
EZ
18882011-07-14 Eli Zaretskii <eliz@gnu.org>
1889
df9733bf
EZ
1890 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1891 bidi_cache_idx.
1892
0bb23927
EZ
1893 Support bidi reordering of display and overlay strings.
1894 * xdisp.c (compute_display_string_pos)
1895 (compute_display_string_end): Accept additional argument STRING.
1896 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1897 (reseat_to_string): Initialize bidi_it->string.s and
1898 bidi_it->string.schars.
1899 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1900 NULL (avoids a crash in bidi_paragraph_init).
1901 Initialize itb.string.lstring.
0bb23927
EZ
1902 (init_iterator): Call bidi_init_it only of a valid
1903 buffer position was specified. Initialize paragraph_embedding to
1904 L2R.
1905 (reseat_to_string): Initialize the bidi iterator.
1906 (display_string): If we need to ignore text properties of
1907 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1908 original value of -1 will not work with bidi.)
1909 (compute_display_string_pos): First arg is now struct
1910 `text_pos *'; all callers changed. Support display properties on
1911 Lisp strings.
1912 (compute_display_string_end): Support display properties on Lisp
1913 strings.
1914 (init_iterator, reseat_1, reseat_to_string): Initialize the
1915 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1916 when iterating on a string not from display properties).
640c8776
SM
1917 (compute_display_string_pos, compute_display_string_end):
1918 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1919 arrow keys.
1920 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1921 base_level_stop; instead, set base_level_stop to BEGV.
1922 Fixes crashes in vertical-motion.
0bb23927
EZ
1923 (next_element_from_buffer): Improve commentary for when
1924 the iterator is before prev_stop.
1925 (init_iterator): Initialize bidi_p from the default value of
1926 bidi-display-reordering, not from buffer-local value. Use the
1927 buffer-local value only if initializing for buffer iteration.
1928 (handle_invisible_prop): Support invisible properties on strings
1929 that are being bidi-reordered.
1930 (set_iterator_to_next): Support bidi reordering of C strings and
1931 Lisp strings.
1932 (next_element_from_string): Support bidi reordering of Lisp
1933 strings.
1934 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1935 (display_string): Support display of R2L glyph rows.
1936 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1937 (init_iterator): Don't initialize it->bidi_p for strings
1938 here.
1939 (reseat_to_string): Initialize it->bidi_p for strings here.
1940 (next_element_from_string, next_element_from_c_string)
1941 (next_element_from_buffer): Add xassert's for correspondence
1942 between IT's object being iterated and it->bidi_it.string
1943 structure.
1944 (face_before_or_after_it_pos): Support bidi iteration.
1945 (next_element_from_c_string): Handle the case of the first string
1946 character that is not the first one in the visual order.
1947 (get_visually_first_element): New function, refactored from common
1948 parts of next_element_from_buffer, next_element_from_string, and
1949 next_element_from_c_string.
1950 (tool_bar_lines_needed, redisplay_tool_bar)
1951 (display_menu_bar): Force left-to-right direction. Add a FIXME
1952 comment for making that be controlled by a user option.
1953 (push_it, pop_it): Save and restore the state of the
1954 bidi iterator. Save and restore the bidi_p flag.
1955 (pop_it): Iterate out of display property for string iteration as
1956 well.
1957 (iterate_out_of_display_property): Support iteration over strings.
1958 (handle_single_display_spec): Set up it->bidi_it for iteration
1959 over a display string, and call bidi_init_it.
1960 (handle_single_display_spec, next_overlay_string)
1961 (get_overlay_strings_1, push_display_prop): Set up the bidi
1962 iterator for displaying display or overlay strings.
1963 (forward_to_next_line_start): Don't use the shortcut if
1964 bidi-iterating.
1965 (back_to_previous_visible_line_start): If handle_display_prop
1966 pushed the iterator stack, restore the internal state of the bidi
1967 iterator by calling bidi_pop_it same number of times.
1968 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1969 and we are bidi-iterating, don't decrement the iterator position;
1970 instead, set the first_elt flag in the bidi iterator, to produce
1971 the same effect.
1972 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1973 (push_display_prop): xassert that we are iterating a buffer.
1974 (push_it, pop_it): Save and restore paragraph_embedding member.
1975 (handle_single_display_spec, next_overlay_string)
1976 (get_overlay_strings_1, reseat_1, reseat_to_string)
1977 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1978 correctly. Don't assume unibyte strings are not bidi-reordered.
1979 (compute_display_string_pos)
1980 (compute_display_string_end): Fix handling the case of C string.
1981 (push_it, pop_it): Save and restore from_disp_prop_p.
1982 (handle_single_display_spec, push_display_prop): Set the
1983 from_disp_prop_p flag.
1984 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1985 (pop_it): Call iterate_out_of_display_property only if we are
1986 popping after iteration over a string that came from a display
1987 property. Fix a typo in popping stretch info. Add an assertion
1988 for verifying that the iterator position is in sync with the bidi
1989 iterator.
1990 (handle_single_display_spec, get_overlay_strings_1)
1991 (push_display_prop): Fix initialization of paragraph direction for
1992 string when that of the parent object is not yet determined.
1993 (reseat_1): Call bidi_init_it to resync the bidi
1994 iterator with IT's position. (Bug#7616)
1995 (find_row_edges): If ROW->start.pos gives position
1996 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1997 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1998 Reset the from_disp_prop_p flag.
1999 (SAVE_IT, RESTORE_IT): New macros.
2000 (pos_visible_p, face_before_or_after_it_pos)
2001 (back_to_previous_visible_line_start)
2002 (move_it_in_display_line_to, move_it_in_display_line)
2003 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2004 (try_scrolling, redisplay_window, display_line): Use them when
2005 saving a temporary copy of the iterator and restoring it back.
2006 (back_to_previous_visible_line_start, reseat_1)
2007 (init_iterator): Empty the bidi cache "stack".
2008 (move_it_in_display_line_to): If iterator ended up at
2009 EOL, but we never saw any buffer positions smaller than
2010 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2011 motion in bidi-reordered lines.
2012 (move_it_in_display_line_to): Record prev_method and prev_pos
2013 immediately before the call to set_iterator_to_next. Fixes cursor
2014 motion in bidi-reordered lines with stretch glyphs and strings
2015 displayed in margins. (Bug#8133) (Bug#8867)
2016 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2017 TO_CHARPOS.
640c8776
SM
2018 (pos_visible_p): Support positions in bidi-reordered lines.
2019 Save and restore bidi cache.
0bb23927
EZ
2020
2021 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2022 (bidi_paragraph_info): Delete unused struct.
2023 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2024 (bidi_cache_start): New variable.
2025 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2026 to zero.
2027 (bidi_cache_fetch_state, bidi_cache_search)
2028 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2029 (bidi_cache_find, bidi_peek_at_next_level)
2030 (bidi_level_of_next_char, bidi_find_other_level_edge)
2031 (bidi_move_to_visually_next): Compare cache index with
2032 bidi_cache_start rather than with zero.
2033 (bidi_fetch_char): Accept new argument STRING; all callers
2034 changed. Support iteration over a string. Support strings with
2035 display properties. Support unibyte strings. Fix the type of
2036 `len' according to what STRING_CHAR_AND_LENGTH expects.
2037 (bidi_paragraph_init, bidi_resolve_explicit_1)
2038 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2039 (bidi_level_of_next_char, bidi_move_to_visually_next):
2040 Support iteration over a string.
0bb23927
EZ
2041 (bidi_set_sor_type, bidi_resolve_explicit_1)
2042 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2043 can now be zero (for strings); special values 0 and -1 were
2044 changed to -1 and -2, respectively.
2045 (bidi_char_at_pos): New function.
2046 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2047 Call it instead of FETCH_MULTIBYTE_CHAR.
2048 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2049 initialized to valid values.
2050 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2051 values.
2052 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2053 the test for valid cached positions. Fix the logic for looking up
2054 the sentinel state in the cache. GCPRO the Lisp string we are
2055 iterating.
2056 (bidi_push_it, bidi_pop_it): New functions.
2057 (bidi_initialize): Initialize the bidi cache start stack pointer.
2058 (bidi_cache_ensure_space): New function, refactored from part of
2059 bidi_cache_iterator_state. Don't assume the required size is just
2060 one BIDI_CACHE_CHUNK away.
2061 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2062 (bidi_count_bytes, bidi_char_at_pos): New functions.
2063 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2064 always valid if bidi_cache_idx is valid.
2065 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2066 is valid if it's going to be used.
2067 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2068 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2069 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2070 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2071 (bidi_find_other_level_edge, bidi_cache_start_stack):
2072 All variables related to cache indices are now EMACS_INT.
c965adc5 2073
0bb23927
EZ
2074 * dispextern.h (struct bidi_string_data): New structure.
2075 (struct bidi_it): New member `string'. Make flag members be 1-bit
2076 fields, and put them last in the struct.
640c8776
SM
2077 (compute_display_string_pos, compute_display_string_end):
2078 Update prototypes.
0bb23927
EZ
2079 (bidi_push_it, bidi_pop_it): Add prototypes.
2080 (struct iterator_stack_entry): New members bidi_p,
2081 paragraph_embedding, and from_disp_prop_p.
2082 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2083 (bidi_shelve_cache, bidi_unshelve_cache):
2084 Declare prototypes.
0bb23927
EZ
2085
2086 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2087 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2088 and vector-like objects.
2089
2090 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2091 cache around display iteration.
2092
2093 * window.c (Fwindow_end, window_scroll_pixel_based)
2094 (displayed_window_lines, Frecenter): Save and restore the bidi
2095 cache around display iteration.
2096
3bbd2265
LMI
20972011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2098
2099 * editfns.c (Fdelete_region): Clarify the use of the named
2100 parameters (bug#6788).
2101
adc47434
MR
21022011-07-14 Martin Rudalics <rudalics@gmx.at>
2103
2104 * indent.c (Fvertical_motion): Set and restore w->pointm when
2105 saving and restoring the window's buffer (Bug#9006).
2106
837c31f8
LMI
21072011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2108
2109 * editfns.c (Fstring_to_char): Clarify just what is returned
2110 (bug#6576). Text by Eli Zaretskii.
2111
ac389d0c
JB
21122011-07-13 Juanma Barranquero <lekktu@gmail.com>
2113
2114 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2115
0be0ce47
EZ
21162011-07-13 Eli Zaretskii <eliz@gnu.org>
2117
2118 * buffer.c (mmap_find): Fix a typo.
2119
cd18e7e3
JB
21202011-07-13 Johan Bockgård <bojohan@gnu.org>
2121
2122 Fix execution of x selection hooks.
2123 * xselect.c (Qx_lost_selection_functions)
2124 (Qx_sent_selection_functions): New vars.
2125 (syms_of_xselect): DEFSYM them.
2126 (x_handle_selection_request): Pass Qx_sent_selection_functions
2127 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2128 (x_handle_selection_clear,x_clear_frame_selections):
2129 Pass Qx_lost_selection_functions rather than
2130 Vx_lost_selection_functions to Frun_hook_with_args.
2131
47ea7f44
PE
21322011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2133
ac389d0c 2134 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2135 The old code sometimes used this field without initializing it.
2136
47ea7f44
PE
2137 * alloc.c (gc_sweep): Don't read past end of array.
2138 In theory, the old code could also have corrupted Emacs internals,
2139 though it'd be very unlikely.
2140
bc985c87
AS
21412011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2142
2143 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2144 argument. (Bug#4026)
bc985c87 2145
0cf34688
LMI
21462011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2147
b3dadd76
LMI
2148 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2149 key" (bug#4257).
2150
0cf34688
LMI
2151 * window.c (Fset_window_start): Doc fix (bug#4199).
2152 (Fset_window_hscroll): Ditto.
2153
270768cd
PE
21542011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2155
077e3dda 2156 Fix minor new problems caught by GCC 4.6.1.
270768cd 2157 * term.c (init_tty): Remove unused local.
490011a6 2158 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2159 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2160 not used otherwise.
270768cd 2161
b1f58454
CY
21622011-07-12 Chong Yidong <cyd@stupidchicken.com>
2163
2164 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2165
22b9578d
LMI
21662011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2167
6e70ab07
LMI
2168 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2169 are the mini-buffer and the echo area (bug#3320).
2170
22b9578d
LMI
2171 * term.c (init_tty): Remove support for supdup, c10 and perq
2172 terminals, which are no longer supported (bug#1482).
2173
8974cc9f
JB
21742011-07-10 Johan Bockgård <bojohan@gnu.org>
2175
2176 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2177
a560d974
JD
21782011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2179
2180 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2181 for non-popups (Bug#3642).
2182
1dae0f0a
AS
21832011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2184
268c2c36 2185 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2186 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2187 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2188 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2189 * data.c (fmod): Likewise.
2190 * dispnew.c (swap_glyphs_in_rows): Likewise.
2191 * emacs.c (memory_warning_signal): Likewise.
2192 * floatfns.c (float_error): Likewise.
2193 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2194 (otf_open, font_otf_capability, generate_otf_features)
2195 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2196 Likewise.
2197 * image.c (pbm_read_file): Likewise.
2198 * indent.c (string_display_width): Likewise.
2199 * intervals.c (check_for_interval, search_for_interval)
2200 (inc_interval_count, count_intervals, root_interval)
2201 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2202 * lread.c (defalias): Likewise.
268c2c36 2203 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2204 * regex.c (set_image_of_range_1, set_image_of_range)
2205 (regex_grow_registers): Likewise.
2206 * sysdep.c (strerror): Likewise.
2207 * termcap.c (valid_filename_p, tprint, main): Likewise.
2208 * tparam.c (main): Likewise.
2209 * unexhp9k800.c (run_time_remap, save_data_space)
2210 (update_file_ptrs, read_header, write_header, calculate_checksum)
2211 (copy_file, copy_rest, display_header): Likewise.
2212 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2213 Likewise.
2214 * xdisp.c (check_it): Likewise.
2215 * xfaces.c (register_color, unregister_color, unregister_colors):
2216 Likewise.
2217 * xfns.c (print_fontset_result): Likewise.
2218 * xrdb.c (member, fatal, main): Likewise.
2219
99033785
PE
22202011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2221
2222 Fix minor problems found by static checking (Bug#9031).
2223 * chartab.c (char_table_set_range, map_sub_char_table):
2224 Remove unused locals.
2225 (uniprop_table): Now static.
2226 * composite.c (_work_char): Remove unused static var.
2227
9cb2ac56
JB
22282011-07-09 Juanma Barranquero <lekktu@gmail.com>
2229
2230 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2231
f25661f0
JD
22322011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2233
2234 * gtkutil.c (qttip_cb): Remove code without function.
2235
8278c4fe
EZ
22362011-07-09 Eli Zaretskii <eliz@gnu.org>
2237
2238 * w32.c (pthread_sigmask): New stub.
2239
1692ae2d 22402011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2241
8a6ebd58 2242 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2243 sigprocmask is portable only for single-threaded applications, and
2244 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2245 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2246 (LIBES): Use it.
2247 * callproc.c (Fcall_process):
2248 * process.c (create_process):
2249 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2250 Use pthread_sigmask, not sigprocmask.
123403e4 2251
1b854618
JD
22522011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2253
2254 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2255 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2256 wrong (Bug#8591).
2257
3fe4b549
JD
22582011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2259
0ce7e563
JD
2260 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2261 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2262 (xg_hide_tooltip): Fix comment.
2263
3fe4b549
JD
2264 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2265 in registerServicesMenuSendTypes.
2266 (validRequestorForSendType): Don't check ns_return_types.
2267
2268 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2269 ns_return_type.
2270
5df75e47
JR
22712011-07-08 Jason Rumney <jasonr@gnu.org>
2272
2273 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2274 frame struct members of non-existent frames (Bug#6284).
2275
699c10bd
JD
22762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2277
4393663b
JD
2278 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2279 variable firstTime not needed on OSX >= 10.6.
2280 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2281 >= 10.5. Use setKnobProportion, setDoubleValue.
2282
2283 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2284 (MAC_OS_X_VERSION_10_5): Define if not defined.
2285 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2286 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2287 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2288
2289 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2290 cString and lossyCString on OSX >= 10.4
2291
2292 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2293 sizeToFit on OSX >= 10.2.
2294
2295 * nsimage.m (allocInitFromFile): Don't use deprecated method
2296 bestRepresentationForDevice on OSX >= 10.6.
2297
2298 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2299 to avoid warning.
2300
2301 * emacs.c: Declare unexec_init_emacs_zone.
2302
a63e0781
JD
2303 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2304
699c10bd
JD
2305 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2306
2307 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2308 on svcsMenu (Bug#8842).
2309
2310 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2311 ns_return_types.
2312 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2313
2314 * nsterm.m (QUTF8_STRING): Declare.
2315 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2316 (validRequestorForSendType): Return type is (id).
2317 Change indexOfObjectIdenticalTo to indexOfObject.
2318 Check if we have local selection before returning self (Bug#8842).
2319 (writeSelectionToPasteboard): Put local selection into paste board
2320 if we have a local selection (Bug#8842).
2321 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2322
2323 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2324 (ns_get_local_selection): Declare.
2325
54e10184
LMI
23262011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2327
9888ff71
LMI
2328 * keymap.c (describe_map_tree): Don't insert a double newline at
2329 the end of the buffer (bug#1169) and return whether we inserted
2330 something.
2331
54e10184
LMI
2332 * callint.c (Fcall_interactively): Change "reading args" to
2333 "providing args" to try to clarify what it does (bug#1010).
2334
15fa4783
KH
23352011-07-07 Kenichi Handa <handa@m17n.org>
2336
2337 * composite.c (composition_compute_stop_pos): Ignore a static
2338 composition starting before CHARPOS (Bug#8915).
2339
2340 * xdisp.c (handle_composition_prop): Likewise.
2341
a8815b00
EZ
23422011-07-07 Eli Zaretskii <eliz@gnu.org>
2343
2344 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2345 (Bug#9015)
2346
ef7b981d 23472011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2348
2349 * character.h (unicode_category_t): New enum type.
2350
2351 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2352 (Qchar_code_property_table): New variable.
2353 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2354 (UNIPROP_COMPRESSED_FORM_P): New macros.
2355 (char_table_ascii): Uncompress the compressed values.
2356 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2357 Uncompress the compressed values.
ac389d0c 2358 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2359 (char_table_ref_and_range): Uncompress the compressed values.
2360 (sub_char_table_set): New arg is_uniprop. Callers changed.
2361 Uncompress the compressed values.
2362 (sub_char_table_set_range): Args changed. Callers changed.
2363 (char_table_set_range): Adjuted for the above change.
2364 (map_sub_char_table): Delete args default_val and parent. Add arg
2365 top. Give decoded values to a Lisp function.
640c8776 2366 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2367 values to a Lisp function. Gcpro more variables.
2368 (uniprop_table_uncompress)
2369 (uniprop_decode_value_run_length): New functions.
2370 (uniprop_decoder, uniprop_decoder_count): New variables.
2371 (uniprop_get_decoder, uniprop_encode_value_character)
2372 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2373 New functions.
2374 (uniprop_encoder, uniprop_encoder_count): New variables.
2375 (uniprop_get_encoder, uniprop_table)
2376 (Funicode_property_table_internal, Fget_unicode_property_internal)
2377 (Fput_unicode_property_internal): New functions.
2378 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2379 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2380 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2381 char-code-property-alist.
2382
640c8776 2383 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2384 Vunicode_category_table.
2385
640c8776 2386 * font.c (font_range): Adjust for the change of
c805dec0
KH
2387 Vunicode_category_table.
2388
76b397fb
DN
23892011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2390
2391 * m/iris4d.h: Remove file, move contents ...
2392 * s/irix6-5.h: ... here.
2393
22b4128e
PE
23942011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2395
2396 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2397 * alloc.c (mark_buffer):
2398 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2399 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2400 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2401 This isn't true in general, and it's particularly not true
2402 if Emacs is configured with --with-wide-int.
2403 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2404 New macros, used in the buffer.c change.
2405
869795d6
JD
24062011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2407
2408 * xsettings.c: Use both GConf and GSettings if both are available.
2409 (store_config_changed_event): Add comment.
2410 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2411 (store_tool_bar_style_changed): New functions.
5e617bc2 2412 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2413 (struct xsettings): Move font inside HAVE_XFT.
2414 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2415 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2416 Move inside HAVE_XFT.
640c8776 2417 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2418 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2419 also.
2420 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2421 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2422 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2423 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2424 (parse_settings): Move check for font inside HAVE_XFT.
2425 (read_settings, apply_xft_settings): Add comment.
2426 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2427 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2428 call store_font_name_changed.
2429 (xft_settings_event): Add comment.
2430 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2431 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2432 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2433 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2434 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2435 (xsettings_get_system_font, xsettings_get_system_normal_font):
2436 Add comment.
869795d6 2437
d8ed26bd
PE
24382011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2439
2440 Random fixes. E.g., (random) never returned negative values.
2441 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2442 subseconds part to the entropy, as that's a bit more random.
2443 Prefer signed to unsigned, since the signedness doesn't matter and
2444 in general we prefer signed. When given a limit, use a
2445 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2446 latter isn't right if USE_2_TAGS_FOR_INTS.
2447 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2448 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2449
cabf1cac
SM
24502011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2451
2452 * textprop.c (text_property_stickiness):
2453 Obey Vtext_property_default_nonsticky.
2454 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2455 * w32fns.c (syms_of_w32fns):
2456 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2457
6e9b2be9
PE
24582011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2459
2460 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2461 This is more efficient than Ffile_directory_p and avoids a minor race.
2462
90186c68
LMI
24632011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2464
7c301272
LMI
2465 * buffer.c (Foverlay_put): Say what the return value is
2466 (bug#7835).
2467
c4f2d8d4
LMI
2468 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2469 is a directory before asking whether to use the file name
2470 (bug#7564).
ad637907
LMI
2471 (barf_or_query_if_file_exists): Make the "File is a directory"
2472 error be more correct.
c4f2d8d4 2473
90186c68
LMI
2474 * fns.c (Frequire): Remove the mention of the .gz files, since
2475 that's installation-specific, but keep the mention of
2476 `get-load-suffixes'.
2477
da64016e
PE
24782011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2479
2480 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2481 Report string overflow if the output is too long.
2482
7d47b580
JB
24832011-07-04 Juanma Barranquero <lekktu@gmail.com>
2484
a555cb87
JB
2485 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2486 (syms_of_gnutls): Remove duplicate DEFSYM for
2487 Qgnutls_bootprop_verify_hostname_error, an error for
2488 Qgnutls_bootprop_verify_error (which is no longer used).
2489
7d47b580
JB
2490 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2491 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2492 Also (re)move comments that are misplaced or no longer relevant.
2493
1e49bfab
LMI
24942011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2495
2496 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2497
1485f4c0
CY
24982011-07-03 Chong Yidong <cyd@stupidchicken.com>
2499
2500 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2501 and background color parameters if they have been changed.
2502
a9ab721e
LMI
25032011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2504
2505 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2506
cf7cff57
PE
25072011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2508
2e13213d
PE
2509 * xsettings.c (SYSTEM_FONT): Define only when used.
2510 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2511
cf7cff57
PE
2512 * keymap.c (access_keymap_1): Now static.
2513
7a8e04f7
CY
25142011-07-02 Chong Yidong <cyd@stupidchicken.com>
2515
2516 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2517 leave any prefix arg for the up event (Bug#1586).
2518
61352f62
LMI
25192011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2520
69bb1ef7
LMI
2521 * lread.c (syms_of_lread): Mention single symbols defined by
2522 `defvar' or `defconst' (bug#7154).
2523
61352f62 2524 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2525 (Frequire): Mention get-load-suffixes.
61352f62 2526
28545e04
MR
25272011-07-02 Martin Rudalics <rudalics@gmx.at>
2528
2529 * window.h (window): Remove clone_number slot.
2530 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2531 Remove.
2532 (make_parent_window, make_window, saved_window)
2533 (Fset_window_configuration, save_window_save): Don't deal with
2534 clone numbers.
2535 * buffer.c (Qclone_number): Remove declaration.
2536 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2537
3349e122
SM
25382011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2539
2540 Add multiple inheritance to keymaps.
2541 * keymap.c (Fmake_composed_keymap): New function.
2542 (Fset_keymap_parent): Simplify.
2543 (fix_submap_inheritance): Remove.
2544 (access_keymap_1): New function extracted from access_keymap to handle
2545 embedded parents and handle lists of maps.
2546 (access_keymap): Use it.
2547 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2548 (Fcopy_keymap): Handle embedded parents.
2549 (Fcommand_remapping, define_as_prefix): Simplify.
2550 (Fkey_binding): Simplify.
2551 (syms_of_keymap): Move minibuffer-local-completion-map,
2552 minibuffer-local-filename-completion-map,
2553 minibuffer-local-must-match-map, and
2554 minibuffer-local-filename-must-match-map to Elisp.
2555 (syms_of_keymap): Defsubr make-composed-keymap.
2556 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2557 (parse_menu_item): Trivial simplification.
2558
3279eb87
GM
25592011-07-01 Glenn Morris <rgm@gnu.org>
2560
2561 * Makefile.in (SETTINGS_LIBS): Fix typo.
2562
4550efdf
KI
25632011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2564
2565 * coding.c (Fencode_coding_string): Record the last coding system
2566 used, as the function doc string says (bug#8738).
2567
0949d2b6
JD
25682011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2569
2570 * xsettings.c (store_monospaced_changed): Take new font as arg and
2571 check for change against current_mono_font.
2572 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2573 (emacs_settings_constructor, emacs_settings_get_property)
2574 (emacs_settings_set_property, emacs_settings_class_init)
2575 (emacs_settings_init, gsettings_obj): Remove.
2576 (something_changedCB): New function for HAVE_GSETTINGS.
2577 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2578 with value as argument.
2579 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2580 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2581 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2582 "changed".
2583
2584 * xgselect.c: Add defined (HAVE_GSETTINGS).
2585 (xgselect_initialize): Ditto.
2586
2587 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2588 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2589 xg_select.
2590
bbc6b304
PE
25912011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2592
2593 * eval.c (struct backtrace): Simplify and port the data structure.
2594 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2595 signed bit field, as this assumption is not portable and it makes
2596 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2597 "char debug_on_exit : 1" as this is not portable either; instead,
2598 use the portable "unsigned int debug_on_exit : 1". Remove unused
2599 member evalargs. Remove obsolete comments about cc bombing out.
2600
9851bfc5
JD
26012011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2602
51bb811f 2603 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2604 Let HAVE_GSETTINGS override HAVE_GCONF.
2605 (store_monospaced_changed): New function.
2606 (EMACS_SETTINGS): A new type derived from GObject to handle
2607 GSettings notifications.
2608 (emacs_settings_constructor, emacs_settings_get_property)
2609 (emacs_settings_set_property, emacs_settings_class_init):
2610 New functions.
2611 (gsettings_client, gsettings_obj): New variables.
2612 (GSETTINGS_SCHEMA): New define.
2613 (something_changedCB): Call store_monospaced_changed.
2614 (init_gsettings): New function.
2615 (xsettings_initialize): Call init_gsettings.
2616 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2617 to NULL.
2618
640c8776 2619 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2620 GCONF_CFLAGS/LIBS.
2621
5386012d
MR
26222011-06-29 Martin Rudalics <rudalics@gmx.at>
2623
2624 * window.c (resize_root_window, grow_mini_window)
2625 (shrink_mini_window): Rename Qresize_root_window to
2626 Qwindow_resize_root_window and Qresize_root_window_vertically to
2627 Qwindow_resize_root_window_vertically.
2628
f13e0b08
PE
26292011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2630
2631 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2632
94515237
JB
26332011-06-27 Juanma Barranquero <lekktu@gmail.com>
2634
2635 * makefile.w32-in: Redesign dependencies so they reflect more
2636 clearly which files are directly included by each source file,
2637 and not through other includes.
2638
e43b6e43
MR
26392011-06-27 Martin Rudalics <rudalics@gmx.at>
2640
2641 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2642 (sort_overlays, overlay_strings): When an overlay's clone number
2643 matches the window's clone number process the overlay even if
2644 the overlay's window property doesn't match the current window.
2645
d68443dc
MR
2646 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2647 (Fwindow_hchild): Rename to Fwindow_left_child.
2648 (Fwindow_next): Rename to Fwindow_next_sibling.
2649 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2650 (resize_window_check): Rename to window_resize_check.
2651 (resize_window_apply): Rename to window_resize_apply.
2652 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2653 (Fdelete_other_windows_internal, resize_frame_windows)
2654 (Fsplit_window_internal, Fdelete_window_internal)
2655 (grow_mini_window, shrink_mini_window)
2656 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2657
c7e73be5
JD
26582011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2659
2660 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2661 (emacs_fixed_set_min_size): Remove.
2662 (emacs_fixed_new): Take frame as argument.
2663
2664 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2665 (_EmacsFixedPrivate): Remove minwidth/height.
2666 Add struct frame *f.
2667 (emacs_fixed_init): Initialize priv->f.
2668 (get_parent_class, emacs_fixed_set_min_size): Remove.
2669 (emacs_fixed_new): Set priv->f to argument.
2670 (emacs_fixed_get_preferred_width)
2671 (emacs_fixed_get_preferred_height): Use min_width/height from
2672 frames size_hint to set minimum and natural (Bug#8919).
2673 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2674 and use min_width/height from frames size_hint to set
2675 min_width/height (Bug#8919).
2676
2677 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2678 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2679 Fix indentation.
c7e73be5 2680
cf99dcf8
EZ
26812011-06-26 Eli Zaretskii <eliz@gnu.org>
2682
2683 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2684 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2685 called at ZV.
2686
029529ac
CY
26872011-06-26 Chong Yidong <cyd@stupidchicken.com>
2688
2689 * process.c (wait_reading_process_output): Bypass select if
2690 waiting for a cell while ignoring keyboard input, and input is
2691 pending. Suggested by Jan Djärv (Bug#8869).
2692
7a7ef429
PE
26932011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2694
2695 Use gnulib's dup2 module instead of rolling our own.
2696 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2697
11fdef7d 26982011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2699
2700 * dispnew.c (scrolling_window): Before scrolling, turn off a
2701 mouse-highlight in the window being scrolled.
2702
cd3520a4
JB
27032011-06-24 Juanma Barranquero <lekktu@gmail.com>
2704
2705 Move DEFSYM to lisp.h and use everywhere.
2706
2707 * character.h (DEFSYM): Move declaration...
2708 * lisp.h (DEFSYM): ...here.
2709
2710 * gnutls.c:
2711 * minibuf.c:
2712 * w32menu.c:
2713 * w32proc.c:
2714 * w32select.c: Don't include character.h.
2715
2716 * alloc.c (syms_of_alloc):
2717 * buffer.c (syms_of_buffer):
2718 * bytecode.c (syms_of_bytecode):
2719 * callint.c (syms_of_callint):
2720 * casefiddle.c (syms_of_casefiddle):
2721 * casetab.c (init_casetab_once):
2722 * category.c (init_category_once, syms_of_category):
2723 * ccl.c (syms_of_ccl):
2724 * cmds.c (syms_of_cmds):
2725 * composite.c (syms_of_composite):
2726 * dbusbind.c (syms_of_dbusbind):
2727 * dired.c (syms_of_dired):
2728 * dispnew.c (syms_of_display):
2729 * doc.c (syms_of_doc):
2730 * editfns.c (syms_of_editfns):
2731 * emacs.c (syms_of_emacs):
2732 * eval.c (syms_of_eval):
2733 * fileio.c (syms_of_fileio):
2734 * fns.c (syms_of_fns):
2735 * frame.c (syms_of_frame):
2736 * fringe.c (syms_of_fringe):
2737 * insdel.c (syms_of_insdel):
2738 * keymap.c (syms_of_keymap):
2739 * lread.c (init_obarray, syms_of_lread):
2740 * macros.c (syms_of_macros):
2741 * msdos.c (syms_of_msdos):
2742 * print.c (syms_of_print):
2743 * process.c (syms_of_process):
2744 * search.c (syms_of_search):
2745 * sound.c (syms_of_sound):
2746 * syntax.c (init_syntax_once, syms_of_syntax):
2747 * terminal.c (syms_of_terminal):
2748 * textprop.c (syms_of_textprop):
2749 * undo.c (syms_of_undo):
2750 * w32.c (globals_of_w32):
2751 * window.c (syms_of_window):
2752 * xdisp.c (syms_of_xdisp):
2753 * xfaces.c (syms_of_xfaces):
2754 * xfns.c (syms_of_xfns):
2755 * xmenu.c (syms_of_xmenu):
2756 * xsettings.c (syms_of_xsettings):
2757 * xterm.c (syms_of_xterm): Use DEFSYM.
2758
4228cf16
TZ
27592011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2760
cd3520a4 2761 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2762
7fcccf1e
PE
27632011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2764
7efb4e0e
PE
2765 Integer and buffer overflow fixes (Bug#8873).
2766
ff5844ad
PE
2767 * print.c (printchar, strout): Check for string overflow.
2768 (PRINTPREPARE, printchar, strout):
2769 Don't set size unless allocation succeeds.
2770
90532f02
PE
2771 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2772 for sizes. Check for string overflow more accurately.
2773 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2774
6d84508d
PE
2775 * macros.c: Integer and buffer overflow fixes.
2776 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2777 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2778 Use ptrdiff_t, not int, for sizes.
2779 Don't increment bufsize until after realloc succeeds.
2780 Check for size-calculation overflow.
2781 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2782
437b2cb4
PE
2783 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2784
8b9ac8b4
PE
2785 * lread.c: Integer overflow fixes.
2786 (read_integer): Radix is now EMACS_INT, not int,
2787 to improve quality of diagnostics for out-of-range radices.
2788 Calculate buffer size correctly for out-of-range radices.
2789 (read1): Check for integer overflow in radices, and in
2790 read-circle numbers.
82cb60d3
PE
2791 (read_escape): Avoid int overflow.
2792 (Fload, openp, read_buffer_size, read1)
2793 (substitute_object_recurse, read_vector, read_list, map_obarray):
2794 Use ptrdiff_t, not int, for sizes.
2795 (read1): Use EMACS_INT, not int, for sizes.
20270765 2796 Check for size overflow.
8b9ac8b4 2797
7fcccf1e
PE
2798 * image.c (cache_image): Check for size arithmetic overflow.
2799
bfbbd7e7
PE
2800 * lread.c: Integer overflow issues.
2801 (saved_doc_string_size, saved_doc_string_length)
2802 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2803 Now ptrdiff_t, not int.
2804 (read1): Don't assume doc string length fits in int. Check for
2805 out-of-range doc string lengths.
2806 (read_list): Don't assume file position fits in int.
39019e54 2807 (read_escape): Check for hex character overflow.
bfbbd7e7 2808
4e323265
LL
28092011-06-22 Leo Liu <sdl.web@gmail.com>
2810
2811 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2812 Move to minibuffer.el.
2813
85fece3e
PE
28142011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2815
20b84ce9 2816 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2817 The following patches are for when GLYPH_DEBUG && !XASSERT.
2818 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2819 * dispnew.c (flush_stdout):
2820 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2821 Mark as externally visible.
2822 * dispnew.c (check_window_matrix_pointers): Now static.
2823 * dispnew.c (window_to_frame_vpos):
2824 * xfns.c (unwind_create_frame):
2825 * xterm.c (x_check_font): Remove unused local.
2826 * scroll.c (CHECK_BOUNDS):
2827 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2828 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2829 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2830 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2831 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2832 Now static.
2833 (debug_method_add): Use va_list and vsprintf rather than relying
2834 on undefined behavior with wrong number of arguments.
2835 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2836 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2837 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2838 since we're not interested in debugging glyphs with old libraries.
2839 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2840 GCC 4.6.0's static checking.
2841
0766b489
PE
28422011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2843
31fd4b32
PE
2844 Integer overflow and signedness fixes (Bug#8873).
2845 A few related buffer overrun fixes, too.
2846
b79e8648
PE
2847 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2848
0766b489
PE
2849 * dispextern.h (struct face.stipple):
2850 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2851 (x_bitmap_mask, x_allocate_bitmap_record)
2852 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2853 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2854 (x_create_bitmap_from_xpm_data):
2855 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2856 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2857 (.bitmaps_last):
2858 * xfaces.c (load_pixmap):
2859 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2860 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2861 (.bitmaps_last, struct x_output.icon_bitmap):
2862 Use ptrdiff_t, not int, for bitmap indexes.
2863 (x_allocate_bitmap_record): Check for size overflow.
2864 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2865
b081724f
PE
2866 Use ptrdiff_t, not int, for overlay counts.
2867 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2868 * editfns.c (overlays_around, get_pos_property):
2869 * textprop.c (get_char_property_and_overlay):
2870 * xdisp.c (next_overlay_change, note_mouse_highlight):
2871 * xfaces.c (face_at_buffer_position):
21514da7
PE
2872 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2873 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2874 (Fnext_overlay_change, Fprevious_overlay_change)
2875 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2876 Use ptrdiff_t, not int, for sizes.
21514da7 2877 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2878
3de73e5e
PE
2879 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2880
2606c57b
PE
2881 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2882 (x_session_initialize): Do not assume string length fits in int.
2883
aaafe47a
PE
2884 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2885 This is unlikely, but can occur if DPI is outlandish.
2886
2674ddc8 2887 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2888 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2889
28154962
PE
2890 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2891 * xrdb.c (magic_file_p, search_magic_path):
2892 Omit last arg SUFFIX; it was always 0. All callers changed.
2893 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2894
7de51af5
PE
2895 * xfont.c (xfont_match): Avoid need for strlen.
2896
25ed6cc3
PE
2897 * xfns.c: Don't assume strlen fits in int.
2898 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2899
4eab31dd
PE
2900 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2901 not unsigned long, as we prefer signed integers. All callers changed.
2902 Detect integer overflow in repeat count.
2903 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2904 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2905
171e2a58
PE
2906 * termcap.c: Don't assume sizes fit in int and never overflow.
2907 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2908 (gobble_line): Check for size-calculation overflow.
2909
ad39faca 2910 * minibuf.c (Fread_buffer):
6e5bb2dc 2911 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2912 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2913 Don't assume string length fits in int.
2914
52c61c22 2915 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2916 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2917
b5b8c9e5
PE
2918 * font.c: Don't assume string length fits in int.
2919 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2920 Use ptrdiff_t, not int.
ccd6111c
PE
2921 (font_intern_prop): Don't assume string length fits in int.
2922 Don't assume integer property fits in fixnum.
2923 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2924
882f0d81 2925 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2926 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2927 Reformulate so as not to need the command string.
2928 Invoke gzip -cd rather than gunzip, as it's more portable.
2929 (lock_info_type, lock_file_1, lock_file):
2930 Don't assume pid_t and time_t fit in unsigned long.
2931 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2932 (current_lock_owner): Prefer signed type for sizes.
2933 Use memcpy, not strncpy, where memcpy is what is really wanted.
2934 Don't assume (via atoi) that time_t and pid_t fit in int.
2935 Check for time_t and/or pid_t out of range, e.g., via a network share.
2936 Don't alloca where an auto var works fine.
2937
93f4cf88
PE
2938 * fileio.c: Fix some integer overflow issues.
2939 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2940 Don't assume string length fits in int.
2941 (directory_file_name): Don't assume string length fits in long.
2942 (make_temp_name): Don't assume pid fits in int, or that its print
2943 length is less than 20.
2944
f3e92b69
PE
2945 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2946
1bfdaf10
PE
2947 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2948
35016e9a
PE
2949 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2950
3d1e65a1
PE
2951 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2952 We prefer signed integers, even for size calculations.
2953
0b963a93
PE
2954 * emacs.c: Don't assume string length fits in 'int'.
2955 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2956 (main): Don't invoke strlen when not needed.
2957
573f4b54
PE
2958 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2959 (XD_DEBUG_MESSAGE): Don't waste a byte.
2960
989f33ba
PE
2961 * callproc.c (getenv_internal_1, getenv_internal)
2962 (Fgetenv_internal):
965d34eb
PE
2963 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2964
e4d29b33
PE
2965 * lread.c (invalid_syntax): Omit length argument.
2966 All uses changed. This doesn't fix a bug, but it simplifies the
2967 code away from its former Hollerith-constant appearance, and it's
2968 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2969 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2970
eb49b136
PE
2971 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2972 This didn't break anything, but it didn't help either.
2973 It's confusing to put a bogus integer in a place where the actual
2974 value does not matter.
9f62aeb1 2975 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2976 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2977
15375a22
PE
2978 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2979 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2980 implementation.
b61cc01c
PE
2981 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2982 We prefer signed types, and the value cannot exceed the EMACS_INT
2983 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2984 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2985 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2986 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2987
53b2623d
PE
2988 * indent.c (sane_tab_width): New function.
2989 (current_column, scan_for_column, Findent_to, position_indentation)
2990 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2991 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2992
51cab52b 2993 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2994
f2ed8a70
PE
2995 * lisp.h (lint_assume): New macro.
2996 * composite.c (composition_gstring_put_cache):
2997 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2998
abe80cc6
PE
2999 * editfns.c, insdel.c:
3000 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3001
b02c740e
PE
3002 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3003
ebc96716
PE
3004 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3005
b4e50fa0 3006 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3007 Use much-faster test for byte-length change.
311d5d7c 3008 Don't assume string byte-length fits in 'int'.
a4cf38e4 3009 Check that character arg fits in 'int'.
85461888 3010 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3011
c0c1ee9f
PE
3012 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3013
a498d7f4
PE
3014 * fns.c (concat): Catch string overflow earlier.
3015 Do not rely on integer wraparound.
3016
51cab52b
PE
3017 * dispextern.h (struct it.overlay_strings_charpos)
3018 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3019 * xdisp.c (forward_to_next_line_start)
3020 (back_to_previous_visible_line_start)
3021 (reseat_at_next_visible_line_start, next_element_from_buffer):
3022 Don't arbitrarily truncate the value of 'selective' to int.
3023
76031fad
PE
3024 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3025
5eb55db9
PE
3026 * composite.c: Don't truncate sizes to 'int'.
3027 (composition_gstring_p, composition_reseat_it)
3028 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3029 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3030 not EMACS_UINT, for indexes.
5eb55db9 3031
0703a717
PE
3032 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3033
d6202519
PE
3034 * buffer.c: Include <verify.h>.
3035 (struct sortvec.priority, struct sortstr.priority):
8961a454 3036 Now EMACS_INT, not int.
c20998a7 3037 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3038 (struct sortstr.size, record_overlay_string)
3039 (struct sortstrlist.size, struct sortlist.used):
3040 Don't truncate size to int.
3041 (record_overlay_string): Check for size-calculation overflow.
d6202519 3042 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3043
d5a19415
JM
30442011-06-22 Jim Meyering <meyering@redhat.com>
3045
029529ac 3046 Don't leak an XBM-image-sized buffer
d5a19415
JM
3047 * image.c (xbm_load): Free the image buffer after using it.
3048
a9041e6c
PE
30492011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3050
3051 Port to Sun C.
3052 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3053 that Sun C diagnosed.
3054 * fns.c (secure_hash): Fix pointer signedness issue.
3055 * intervals.c (static_offset_intervals): New function.
3056 (offset_intervals): Use it.
3057
7f3f739f
LL
30582011-06-21 Leo Liu <sdl.web@gmail.com>
3059
3060 * deps.mk (fns.o):
3061 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3062 sha512.h.
3063
3064 * fns.c (secure_hash): Rename from crypto_hash_function and change
3065 the first arg to accept symbols.
5b66d427 3066 (Fsecure_hash): New primitive.
7f3f739f
LL
3067 (syms_of_fns): New symbols.
3068
76147d94
DD
30692011-06-20 Deniz Dogan <deniz@dogan.se>
3070
3071 * process.c (Fset_process_buffer): Clarify return value in
3072 docstring.
3073
7d7d0045
CY
30742011-06-18 Chong Yidong <cyd@stupidchicken.com>
3075
3076 * dispnew.c (add_window_display_history): Use BVAR.
3077
3078 * xdisp.c (debug_method_add): Use BVAR.
3079 (check_window_end, dump_glyph_matrix, dump_glyph)
3080 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3081
3082 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3083 Likewise.
3084
3085 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3086 check till after the cache is created in init_frame_faces.
3087
ff2bc410
SM
30882011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3089
3090 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3091
28177add
PE
30922011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3093
dd3482fe
PE
3094 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3095 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3096 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3097
393d71f3 3098 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3099 * fileio.c (Finsert_file_contents):
3100 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3101 Remove the old (too-loose) buffer overflow checks.
3102 They weren't needed, since make_gap checks for buffer overflow.
3103 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3104 The old code merely checked for Emacs fixnum overflow, and relied
3105 on undefined (wraparound) behavior. The new code avoids undefined
3106 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3107
2e6813b0 3108 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3109 Tune. Don't use wider integers than needed. Don't use alloca.
3110 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3111
599a9e4f
PE
3112 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3113
99561444
PE
3114 * insdel.c, lisp.h (buffer_overflow): New function.
3115 (insert_from_buffer_1, replace_range, replace_range_2):
3116 * insdel.c (make_gap_larger):
3117 * editfns.c (Finsert_char):
3118 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3119
28177add
PE
3120 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3121
e69dafad
PE
31222011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3123
a7af7fde 3124 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3125
b1c46f02
PE
3126 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3127 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3128
e69dafad
PE
3129 * fileio.c: Don't assume EMACS_INT fits in off_t.
3130 (emacs_lseek): New static function.
3131 (Finsert_file_contents, Fwrite_region): Use it.
3132 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3133
566684ea
PE
3134 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3135
e6966cd6
PE
3136 * fns.c: Don't overflow int when computing a list length.
3137 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3138 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3139 truncation on 64-bit hosts. Check for QUIT every
3140 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3141 faster and is responsive enough.
3142 (Flength): Report an error instead of overflowing an integer.
3143 (Fsafe_length): Return a float if the value is not representable
3144 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3145 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3146 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3147
dd0b0efb
PE
3148 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3149 (header_size, word_size): New constants.
3150 (allocate_vectorlike): Don't check size overflow here.
3151 (allocate_vector): Check it here instead, since this is the only
3152 caller of allocate_vectorlike that could cause overflow.
3153 Check that the new vector's length is representable as a fixnum.
3154
86fe5cfe
PE
3155 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3156 The previous code was bogus. For example, next_almost_prime (32)
3157 returned 39, which is undesirable as it is a multiple of 3; and
3158 next_almost_prime (24) returned 25, which is a multiple of 5 so
3159 why was the code bothering to check for multiples of 7?
3160
80e88859
PE
3161 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3162
4a2f0ad6
PE
3163 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3164
f66c7cf8
PE
3165 Variadic C functions now count arguments with ptrdiff_t.
3166 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3167 Back then I didn't know that the Emacs coding style prefers signed int.
3168 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3169 were being counted with int, which may truncate counts on 64-bit
3170 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3171 * lisp.h (struct Lisp_Subr.function.aMANY)
3172 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3173 Arg counts are now ptrdiff_t, not size_t.
3174 All variadic functions and their callers changed accordingly.
3175 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3176 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3177 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3178 * callint.c (Fcall_interactively): Check arg count for overflow,
3179 to avoid potential buffer overrun. Use signed char, not 'int',
3180 for 'varies' array, so that we needn't bother to check its size
3181 calculation for overflow.
3182 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3183 * eval.c (apply_lambda):
3184 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3185 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3186 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3187
a1759b76
PE
3188 * callint.c (Fcall_interactively): Don't use index var as event count.
3189
d96be9fc
PE
3190 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3191 * mem-limits.h (SIZE): Remove; no longer used.
3192
a690a978 3193 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3194
578c21e6
PE
3195 Remove unnecessary casts.
3196 * xterm.c (x_term_init):
3197 * xfns.c (x_set_border_pixel):
3198 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3199 These aren't needed now that we assume ANSI C.
3200
96f53c6c
PE
3201 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3202 It's more likely to cause problems (due to unsigned overflow)
3203 than to cure them.
3204
83c77d31
PE
3205 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3206
ee2079f1
PE
3207 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3208
6da65536
PE
3209 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3210
7147c4a4
PE
3211 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3212
193e32d9
PE
3213 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3214
e5533da6
PE
3215 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3216
9910e595
PE
3217 GLYPH_CODE_FACE returns EMACS_INT, not int.
3218 * dispextern.h (merge_faces):
3219 * xfaces.c (merge_faces):
01103c44
PE
3220 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3221 Don't assume EMACS_INT fits in int.
9910e595 3222
2638320e
PE
3223 * character.h (CHAR_VALID_P): Remove unused parameter.
3224 * fontset.c, lisp.h, xdisp.c: All uses changed.
3225
045eb8d9
PE
3226 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3227
c1f134b5
PE
3228 * fns.c (concat): Minor tuning based on overflow analysis.
3229 This doesn't fix any bugs. Use int to hold character, instead
3230 of constantly refetching from Emacs object. Use XFASTINT, not
3231 XINT, for value known to be a character. Don't bother comparing
3232 a single byte to 0400, as it's always less.
3233
395fcb93 3234 * floatfns.c (Fexpt):
327eeec8
PE
3235 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3236
abbd3d23
PE
3237 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3238 for characters.
3239
684a03ef
PE
3240 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3241
0fed43f3
PE
3242 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3243 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3244 incorrectly succeed when S was a string, because 4294967386 was
3245 truncated before it was used.
3246
8fd02eb7
PE
3247 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3248 Otherwise, an out-of-range integer could cause undefined behavior
3249 on a 64-bit host.
3250
f8c86b69
PE
3251 * composite.c: Use int, not EMACS_INT, for characters.
3252 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3253 EMACS_INT, for values that are known to be in character range.
3254 This doesn't fix any bugs but is the usual style inside Emacs and
3255 may generate better code on 32-bit machines.
3256
34206dd2
PE
3257 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3258 This is for reasons similar to the recent CHAR_STRING fix.
3259 * charset.c (Fencode_char): Check that character arg is actually
3260 a character. Pass an int to ENCODE_CHAR.
3261 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3262 wider than 'int', as a compile-time check to prevent future regressions
3263 in this area.
3264
c5958d4c 3265 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3266
3267 Make sure a 64-bit char is never passed to CHAR_STRING.
3268 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3269 by silently ignoring the top 32 bits, allowing some values
3270 that were far too large to be valid characters.
3271 * character.h: Include <verify.h>.
3272 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3273 arguments are no wider than unsigned, as a compile-time check
3274 to prevent future regressions in this area.
3275 * data.c (Faset):
01103c44 3276 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3277 (Fsubst_char_in_region):
3278 * fns.c (concat):
3279 * xdisp.c (decode_mode_spec_coding):
3280 Adjust to CHAR_STRING's new requirement.
3281 * editfns.c (Finsert_char, Fsubst_char_in_region):
3282 * fns.c (concat): Check that character args are actually
3283 characters. Without this test, these functions did the wrong
3284 thing with wildly out-of-range values on 64-bit hosts.
3285
d37ca623
PE
3286 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3287 These casts should not be needed on 32-bit hosts, either.
3288 * keyboard.c (read_char):
3289 * lread.c (Fload): Remove casts to unsigned.
3290
ea204efb
PE
3291 * lisp.h (UNSIGNED_CMP): New macro.
3292 This fixes comparison bugs on 64-bit hosts.
3293 (ASCII_CHAR_P): Use it.
3294 * casefiddle.c (casify_object):
01103c44 3295 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3296 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3297 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3298 * dispextern.h (FACE_FROM_ID):
3299 * keyboard.c (read_char): Use UNSIGNED_CMP.
3300
41cb286c
PE
3301 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3302 not to EMACS_INT, to avoid GCC warning.
3303
4a1b9832
PE
3304 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3305
55daad71
PE
3306 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3307 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3308 isn't needed on 32-bit machines.
8f95c75c 3309
01103c44
PE
3310 * buffer.c (Fgenerate_new_buffer_name):
3311 Use EMACS_INT for count, not int.
0ceccced 3312 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3313
3314 * data.c (Qcompiled_function): Now static.
3315
c6f072e7
PE
3316 * window.c (window_body_lines): Now static.
3317
20ce5912
PE
3318 * image.c (gif_load): Rename local to avoid shadowing.
3319
9c4c5f81
PE
3320 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3321 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3322 * alloc.c (make_save_value): Integer argument is now of type
3323 ptrdiff_t, not int.
3324 (mark_object): Use ptrdiff_t, not int.
3325 * lisp.h (pD): New macro.
3326 * print.c (print_object): Use it.
3327
c0c5c8ae
PE
3328 * alloc.c: Use EMACS_INT, not int, to count objects.
3329 (total_conses, total_markers, total_symbols, total_vector_size)
3330 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3331 (total_free_floats, total_floats, total_free_intervals)
3332 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3333 Now EMACS_INT, not int. All uses changed.
3334 (Fgarbage_collect): Compute overall total using a double, so that
3335 integer overflow is less likely to be a problem. Check for overflow
3336 when converting back to an integer.
5a25e253
PE
3337 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3338 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3339 These were 'int' variables that could overflow on 64-bit hosts;
3340 they were never used, so remove them instead of repairing them.
211a0b2a 3341 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3342 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3343 Previously, this ceilinged at INT_MAX, but that doesn't work on
3344 64-bit machines.
e46bb31a 3345 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3346
c78baabf 3347 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3348 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3349 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3350 when a (possibly-narrower) signed value would do just as well.
3351 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3352
c9d624c6
PE
3353 * alloc.c: Catch some string size overflows that we were missing.
3354 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3355 for convenience in STRING_BYTES_MAX.
3356 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3357 The definition here is exact; the one in lisp.h was approximate.
3358 (allocate_string_data): Check for string overflow. This catches
3359 some instances we weren't catching before. Also, it catches
3360 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3361 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3362 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3363
c9d624c6
PE
3364 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3365 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3366 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3367
353032ce
PE
3368 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3369
2bccce07
PE
3370 * alloc.c (Fmake_string): Check for out-of-range init.
3371
0ac30604
SM
33722011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3373
3374 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3375
c195f2de
JD
33762011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3377
3378 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3379 xg_get_default_scrollbar_width.
3380
3381 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3382 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3383 (style_changed_cb): Call update_theme_scrollbar_width and call
3384 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3385 all frames (Bug#8505).
3386 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3387 Call gtk_window_set_resizable if HAVE_GTK3.
3388 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3389 and height if HAVE_GTK3 (Bug#8505).
3390 (scroll_bar_width_for_theme): New variable.
3391 (update_theme_scrollbar_width): New function.
3392 (xg_get_default_scrollbar_width): Move code to
3393 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3394 (xg_initialize): Call update_theme_scrollbar_width.
3395
3396 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3397
3398 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3399
e10ac9f1
MR
34002011-06-12 Martin Rudalics <rudalics@gmx.at>
3401
3402 * frame.c (make_frame): Call other_buffer_safely instead of
3403 other_buffer.
3404
3405 * window.c (temp_output_buffer_show): Call display_buffer with
3406 second argument Vtemp_buffer_show_specifiers and reset latter
3407 immediately after the call.
3408 (Vtemp_buffer_show_specifiers): New variable.
3409 (auto_window_vscroll_p, next_screen_context_lines)
3410 (Vscroll_preserve_screen_position): Remove leading asterisks from
3411 doc-strings.
3412
2d3c217e 34132011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3414
7b7f97e8 3415 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3416 * buffer.c (Qclone_number): Remove for now, as it's unused.
3417 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3418 (record_buffer): Remove unused local.
3419 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3420 (set_frame_buffer_list): Remove; unused.
3421 * frame.h (other_visible_frames): Remove decl.
3422 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3423 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3424 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3425 if HAVE_GPM.
3426 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3427 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3428 Define only if HAVE_GPM.
3429 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3430 (update_hints_inhibit): Remove; never set. All uses removed.
3431 * widgetprv.h (emacsFrameClassRec): Remove decl.
3432 * window.c (delete_deletable_window): Now returns void, since it
3433 wasn't returning anything.
3434 (compare_window_configurations): Remove unused locals.
3435 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3436 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3437 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3438 the same widths as pointers. This follows up on the 2011-05-06 patch.
3439 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3440 * xterm.h: Likewise.
3441 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3442
1384b89e
JB
34432011-06-12 Juanma Barranquero <lekktu@gmail.com>
3444
3445 * makefile.w32-in: Update dependencies.
3446 (LISP_H): Add lib/intprops.h.
3447
1100a63c
CY
34482011-06-11 Chong Yidong <cyd@stupidchicken.com>
3449
3450 * image.c (gif_load): Add animation frame delay to the metadata.
3451 (syms_of_image): Use DEFSYM. New symbol `delay'.
3452
6198ccd0
MR
34532011-06-11 Martin Rudalics <rudalics@gmx.at>
3454
3455 * window.c (delete_deletable_window): Re-add.
3456 (Fset_window_configuration): Rewrite to handle dead buffers and
3457 consequently deletable windows.
3458 (window_tree, Fwindow_tree): Remove. Supply functionality in
3459 window.el.
3460 (compare_window_configurations): Simplify code.
3461
b6e3633c
AS
34622011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3463
1ab0dee5
AS
3464 * image.c (imagemagick_load_image): Fix type mismatch.
3465 (Fimagemagick_types): Likewise.
3466
b6e3633c
AS
3467 * window.h (replace_buffer_in_windows): Declare.
3468
9397e56f
MR
34692011-06-11 Martin Rudalics <rudalics@gmx.at>
3470
3471 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3472 Qclone_number. Remove external declaration of Qdelete_window.
3473 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3474 code.
640c8776
SM
3475 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3476 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3477 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3478 buffer list implementation.
3479 (other_buffer_safely): New function.
3480 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3481 calls to replace_buffer_in_windows and
3482 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3483 if allowed.
3484 (record_buffer): Inhibit quitting and rewrite using quittable
3485 functions. Run Qbuffer_list_update_hook if allowed.
3486 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3487 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3488 Move switch-to-buffer to window.el.
9397e56f
MR
3489 (bury-buffer): Move to window.el.
3490 (Vbuffer_list_update_hook): New variable.
3491
3492 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3493 section.
3494
3495 * window.h (resize_frame_windows): Move up in code.
3496 (Fwindow_frame): Remove EXFUN.
3497 (replace_buffer_in_all_windows): Remove prototype.
3498 (replace_buffer_in_windows_safely): Add prototype.
3499
3500 * window.c: Declare Qdelete_window static again. Move down
3501 declaration of select_count.
3502 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3503 (Fother_window): Move to window.el.
3504 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3505 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3506 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3507 window.el.
3508 (replace_buffer_in_windows): Implement by calling
3509 Qreplace_buffer_in_windows.
3510 (replace_buffer_in_all_windows): Remove with some functionality
3511 moved into replace_buffer_in_windows_safely.
3512 (replace_buffer_in_windows_safely): New function.
3513 (select_window_norecord, select_frame_norecord): Move in front
3514 of run_window_configuration_change_hook. Remove now obsolete
3515 declarations.
640c8776
SM
3516 (Fset_window_buffer): Rewrite doc-string.
3517 Call Qrecord_window_buffer.
9397e56f
MR
3518 (keys_of_window): Move binding for other-window to window.el.
3519
b50691aa
CY
35202011-06-11 Chong Yidong <cyd@stupidchicken.com>
3521
3522 * dispextern.h (struct image): Replace data member, whose int_val
3523 and ptr_val fields were not used by anything, with a single
3524 lisp_val object.
3525
3526 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3527 (gif_clear_image, gif_load, imagemagick_load_image)
3528 (gs_clear_image, gs_load): Callers changed.
3529
3f754b86
PE
35302011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3531
cca69397
PE
3532 * buffer.h: Include <time.h>, for time_t.
3533 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3534
109e28d0
PE
3535 Fix minor problems found by static checking.
3536
60737f02
PE
3537 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3538
4b66faf3
PE
3539 Make identifiers static if they are not used in other modules.
3540 * data.c (Qcompiled_function, Qframe, Qvector):
3541 * image.c (QimageMagick, Qsvg):
3542 * minibuf.c (Qmetadata):
3543 * window.c (resize_window_check, resize_root_window): Now static.
3544 * window.h (resize_window_check, resize_root_window): Remove decls.
3545
109e28d0
PE
3546 * window.c (window_deletion_count, delete_deletable_window):
3547 Remove; unused.
46a4ce9e
PE
3548 (window_body_lines): Now static.
3549 (Fdelete_other_windows_internal): Mark vars as initialized.
3550 Make sure 'resize_failed' is initialized.
3551 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3552 (resize_window_apply): Remove unused local.
3553 * window.h (delete_deletable_window): Remove decl.
3554
109e28d0 3555 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3556 (imagemagick_load_image): Fix pointer signedness problem by changing
3557 last arg from unsigned char * to char *. All uses changed.
3558 Also, fix a local for similar reasons.
3559 Remove unused locals. Remove locals to avoid shadowing.
3560 (fn_rsvg_handle_free): Remove; unused.
3561 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3562 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3563
3f754b86
PE
3564 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3565
2547adb1
CY
35662011-06-10 Chong Yidong <cyd@stupidchicken.com>
3567
3568 * image.c (gif_load): Fix omitted cast error introduced by
3569 2011-06-06 change.
3570
2c8e37d4
MR
35712011-06-10 Martin Rudalics <rudalics@gmx.at>
3572
3573 * window.h (resize_proportionally, orig_total_lines)
3574 (orig_top_line): Remove from window structure.
3575 (set_window_height, set_window_width, change_window_heights)
3576 (Fdelete_window): Remove prototypes.
3577 (resize_frame_windows): Remove duplicate declaration.
3578
440a42e3
EZ
35792011-06-10 Eli Zaretskii <eliz@gnu.org>
3580
3581 * window.h (resize_frame_windows, resize_window_check)
3582 (delete_deletable_window, resize_root_window)
3583 (resize_frame_windows): Declare prototypes.
3584
3585 * window.c (resize_window_apply): Make definition be "static" to
3586 match the prototype.
3587
562dd5e9
MR
35882011-06-10 Martin Rudalics <rudalics@gmx.at>
3589
3590 * window.c: Remove declarations of Qwindow_size_fixed,
3591 window_min_size_1, window_min_size_2, window_min_size,
3592 size_window, window_fixed_size_p, enlarge_window, delete_window.
3593 Remove static from declaration of Qdelete_window, it's
3594 temporarily needed by Fbury_buffer.
3595 (replace_window): Don't assign orig_top_line and
3596 orig_total_lines.
3597 (Fdelete_window, delete_window): Remove. Window deletion is
3598 handled by window.el.
640c8776
SM
3599 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3600 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3601 (Fdelete_other_windows): Remove. Deleting other windows is
3602 handled by window.el.
3603 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3604 handled in window.el.
3605 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3606 Window minimum sizes are handled in window.el.
3607 (shrink_windows, size_window, set_window_height)
3608 (set_window_width, change_window_heights, window_height)
3609 (window_width, CURBEG, CURSIZE, enlarge_window)
3610 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3611 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3612 handled in window.el.
3613 (make_dummy_parent): Rename to make_parent_window and give it a
3614 second argument horflag.
3615 (make_window): Don't set resize_proportionally any more.
3616 (Fsplit_window): Remove. Windows are split in window.el.
3617 (save_restore_action, save_restore_orig_size)
3618 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3619 Resize mini windows in window.el.
3620 (grow_mini_window, shrink_mini_window): Implement by calling
3621 Qresize_root_window_vertically, resize_window_check and
3622 resize_window_apply.
640c8776
SM
3623 (saved_window, Fset_window_configuration, save_window_save):
3624 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3625 resize_proportionally.
3626 (window_min_height, window_min_width): Move to window.el.
3627 (keys_of_window): Move bindings for delete-other-windows,
3628 split-window, delete-window and enlarge-window to window.el.
3629
3630 * buffer.c: Temporarily extern Qdelete_window.
3631 (Fbury_buffer): Temporarily call Qdelete_window instead of
3632 Fdelete_window (Fbury_buffer will move to window.el soon).
3633
3634 * frame.c (set_menu_bar_lines_1): Remove code handling
3635 orig_top_line and orig_total_lines.
3636
3637 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3638 set_window_height but set heights directly.
3639 (change_frame_size_1): Use resize_frame_windows.
3640
3641 * xdisp.c (init_xdisp): Don't use set_window_height but set
3642 heights directly.
3643
640c8776
SM
3644 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3645 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3646 run_window_configuration_change_hook.
3647
3648 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3649 instead of change_window_heights and run
3650 run_window_configuration_change_hook.
3651
1a13852e
MR
36522011-06-09 Martin Rudalics <rudalics@gmx.at>
3653
3654 * window.c (replace_window): Rename second argument REPLACEMENT to
3655 NEW. New third argument SETFLAG. Rewrite.
3656 (delete_window, make_dummy_parent): Call replace_window with
3657 third argument 1.
3658 (window_list_1): Move down in code.
3659 (run_window_configuration_change_hook): Move set_buffer part
3660 before select_frame_norecord part in order to unwind correctly.
3661 Rename count1 to count.
3662 (recombine_windows, delete_deletable_window, resize_root_window)
3663 (Fdelete_other_windows_internal)
3664 (Frun_window_configuration_change_hook, make_parent_window)
3665 (resize_window_check, resize_window_apply, Fresize_window_apply)
3666 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3667 (Fdelete_window_internal, Fresize_mini_window_internal):
3668 New functions.
1a13852e
MR
3669 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3670
f3d1777e
MR
36712011-06-08 Martin Rudalics <rudalics@gmx.at>
3672
496e208e
MR
3673 * window.h (window): Add some new members to window structure -
3674 normal_lines, normal_cols, new_total, new_normal, clone_number,
3675 splits, nest, prev_buffers, next_buffers.
3676 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3677 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3678
f3d1777e
MR
3679 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3680 Remove.
496e208e
MR
3681 (make_dummy_parent): Set new members of windows structure.
3682 (make_window): Move down in code. Handle new members of window
3683 structure.
3684 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3685 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3686 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3687 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3688 (Fset_window_next_buffers, Fset_window_clone_number):
3689 New functions.
496e208e
MR
3690 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3691 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3692 Doc-string fixes.
3693 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3694 Argument WINDOW can be now internal window too.
3695 (Fwindow_use_time): Move up in code.
3696 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3697 Rewrite doc-string.
3698 (Fset_window_configuration, saved_window)
3699 (Fcurrent_window_configuration, save_window_save): Handle new
3700 members of window structure.
b9e809c2
MR
3701 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3702 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3703 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3704 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3705 Qget_mru_window, Qresize_root_window,
3706 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3707 Qauto_buffer_name; staticpro them.
f3d1777e 3708
abde8f8c
MR
37092011-06-07 Martin Rudalics <rudalics@gmx.at>
3710
3711 * window.c (Fwindow_total_size, Fwindow_left_column)
3712 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3713 (Fwindow_list_1): New functions.
3714 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3715 (Fwindow_width, Fscroll_left, Fscroll_right):
3716 Use window_body_cols instead of window_box_text_cols.
3717 (delete_window, Fset_window_configuration):
3718 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3719 (delete_all_subwindows): Take a window as argument and not a
3720 structure. Rewrite.
190b47e6
MR
3721 (window_loop): Remove handling of GET_LRU_WINDOW and
3722 GET_LARGEST_WINDOW.
3723 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3724
3725 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3726 window_box_text_cols. delete_all_subwindows now takes a
3727 Lisp_Object as argument.
abde8f8c 3728
640c8776
SM
3729 * indent.c (compute_motion, Fcompute_motion):
3730 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3731
fa8a67e6
MR
3732 * frame.c (delete_frame): Call delete_all_subwindows with root
3733 window as argument.
3734
a54e3482
DC
37352011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3736
3737 * fns.c (Fputhash): Document return value.
3738
60002bf5
CY
37392011-06-06 Chong Yidong <cyd@stupidchicken.com>
3740
3741 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3742
0c671da6 37432011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3744
b862a52a 3745 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3746
be44ca6c
PE
3747 Check for overflow when converting integer to cons and back.
3748 * charset.c (Fdefine_charset_internal, Fdecode_char):
3749 Use cons_to_unsigned to catch overflow.
3750 (Fencode_char): Use INTEGER_TO_CONS.
3751 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3752 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3753 * data.c (long_to_cons, cons_to_long): Remove.
3754 (cons_to_unsigned, cons_to_signed): New functions.
3755 These signal an error for invalid or out-of-range values.
3756 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3757 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3758 * font.c (Ffont_variation_glyphs):
3759 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3760 * lisp.h: Include <intprops.h>.
3761 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3762 (cons_to_signed, cons_to_unsigned): New decls.
3763 (long_to_cons, cons_to_long): Remove decls.
3764 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3765 (Fprimitive_undo): Use CONS_TO_INTEGER.
3766 * xfns.c (Fx_window_property): Likewise.
3767 * xselect.c: Include <limits.h>.
3768 (x_own_selection, selection_data_to_lisp_data):
3769 Use INTEGER_TO_CONS.
3770 (x_handle_selection_request, x_handle_selection_clear)
3771 (x_get_foreign_selection, Fx_disown_selection_internal)
3772 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3773 (lisp_data_to_selection_data): Use cons_to_unsigned.
3774 (x_fill_property_data): Use cons_to_signed.
3775 Report values out of range.
3776
d1f3d2af
PE
3777 Check for buffer and string overflow more precisely.
3778 * buffer.h (BUF_BYTES_MAX): New macro.
3779 * lisp.h (STRING_BYTES_MAX): New macro.
3780 * alloc.c (Fmake_string):
3781 * character.c (string_escape_byte8):
3782 * coding.c (coding_alloc_by_realloc):
3783 * doprnt.c (doprnt):
3784 * editfns.c (Fformat):
3785 * eval.c (verror):
3786 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3787 since they may not be the same number.
3788 * editfns.c (Finsert_char):
3789 * fileio.c (Finsert_file_contents):
3790 Likewise for BUF_BYTES_MAX.
3791
dd52fcea
PE
3792 * image.c: Use ptrdiff_t, not int, for sizes.
3793 (slurp_file): Switch from int to ptrdiff_t.
3794 All uses changed.
3795 (slurp_file): Check that file size fits in both size_t (for
3796 malloc) and ptrdiff_t (for sanity and safety).
3797
7f9bbdbb
PE
3798 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3799 if b->modtime has its maximal value.
3800
dfe18f82
PE
3801 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3802
84acfcf0
PE
3803 Don't assume time_t can fit into int.
3804 * buffer.h (struct buffer.modtime): Now time_t, not int.
3805 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3806 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3807
ccd9a01a
PE
3808 Minor fixes for signed vs unsigned integers.
3809 * character.h (MAYBE_UNIFY_CHAR):
3810 * charset.c (maybe_unify_char):
3811 * keyboard.c (read_char, reorder_modifiers):
3812 XINT -> XFASTINT, since the integer must be nonnegative.
3813 * ftfont.c (ftfont_spec_pattern):
3814 * keymap.c (access_keymap, silly_event_symbol_error):
3815 XUINT -> XFASTINT, since the integer must be nonnegative.
3816 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3817 since it makes no difference and we prefer signed.
3818 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3819 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3820 nonnegative.
3821
d6d100dd
SM
38222011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3823
3824 * window.h (Fwindow_frame): Declare.
3825
2b6148e4
PE
38262011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3827
3828 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3829 (SPARE_MEMORY): Always define.
3830 (LARGE_REQUEST): Remove.
3831 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3832
f230ecc9
MR
38332011-06-06 Martin Rudalics <rudalics@gmx.at>
3834
727e958e
MR
3835 * lisp.h: Move EXFUNS for Fframe_root_window,
3836 Fframe_first_window and Fset_frame_selected_window to window.h.
3837
3838 * window.h: Move EXFUNS for Fframe_root_window,
3839 Fframe_first_window and Fset_frame_selected_window here from
3840 lisp.h.
3841
3842 * frame.c (Fwindow_frame, Fframe_first_window)
3843 (Fframe_root_window, Fframe_selected_window)
3844 (Fset_frame_selected_window): Move to window.c.
3845 (Factive_minibuffer_window): Move to minibuf.c.
3846 (Fother_visible_frames_p): New function.
3847
3848 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3849
f230ecc9
MR
3850 * window.c (decode_window, decode_any_window): Move up in code.
3851 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3852 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3853 (Fwindow_buffer): Move up and rewrite doc-string.
3854 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3855 (Fwindow_prev): New functions.
727e958e
MR
3856 (Fwindow_frame): Move here from frame.c. Accept any window as
3857 argument.
3858 (Fframe_root_window, Fframe_first_window)
3859 (Fframe_selected_window): Move here from frame.c. Accept frame
3860 or arbitrary window as argument. Update doc-strings.
3861 (Fminibuffer_window): Move up in code.
3862 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3863 (Fset_frame_selected_window): Move here from frame.c.
3864 Marginal rewrite.
727e958e
MR
3865 (Fselected_window, select_window, Fselect_window): Move up in
3866 code. Minor doc-string fixes.
f230ecc9 3867
4d09bcf6
PE
38682011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3869
3870 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3871 Do not assume that spare memory exists; that assumption is valid
3872 only if SYSTEM_MALLOC.
3873 (LARGE_REQUEST): New macro, so that the issue of large requests
3874 is separated from the issue of spare memory.
3875
810928a2
AS
38762011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3877
172418ad
AS
3878 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3879 format. (Bug#8806)
3880
43f862f7
AS
3881 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3882
810928a2
AS
3883 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3884 before statements.
3885
a059fe24
JD
38862011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3887
3888 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3889
3890 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3891
3892 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3893 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3894
989bf368
JB
38952011-06-05 Juanma Barranquero <lekktu@gmail.com>
3896
3897 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3898
4b80f674
CY
38992011-06-04 Chong Yidong <cyd@stupidchicken.com>
3900
3901 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3902 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3903 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3904 New error handlers.
4b80f674
CY
3905 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3906 Obey Vx_select_enable_clipboard_manager. Catch errors in
3907 x_clipboard_manager_save (Bug#8779).
3908 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3909 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3910
99a33b77 39112011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3912
3913 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3914
99a33b77 39152011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3916
3917 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3918 in the current matrix if keep_current_p is non-zero.
3919
8264569d
EZ
39202011-06-04 Eli Zaretskii <eliz@gnu.org>
3921
3922 * bidi.c (bidi_level_of_next_char): Fix last change.
3923
57f97249
EZ
39242011-06-03 Eli Zaretskii <eliz@gnu.org>
3925
fec2107c 3926 Support bidi reordering of text covered by display properties.
57f97249 3927
fec2107c
EZ
3928 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3929 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3930 (bidi_cache_search, bidi_cache_iterator_state)
3931 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3932 (bidi_level_of_next_char, bidi_move_to_visually_next):
3933 Support character positions inside a run of characters covered by a
fec2107c
EZ
3934 display string.
3935 (bidi_paragraph_init, bidi_resolve_explicit_1)
3936 (bidi_level_of_next_char): Call bidi_fetch_char and
3937 bidi_fetch_char_advance instead of FETCH_CHAR and
3938 FETCH_CHAR_ADVANCE.
3939 (bidi_init_it): Initialize new members.
3940 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3941 definitions.
3942 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3943 instead of using explicit *_CHAR codes.
d6d100dd
SM
3944 (bidi_resolve_explicit, bidi_resolve_weak):
3945 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3946 bidirectional text is supported only in multibyte buffers.
3947 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3948 it to initialize the frame_window_p member of struct bidi_it.
3949 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3950 (bidi_resolve_explicit, bidi_resolve_weak)
3951 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3952 bidi_it->nchars is non-positive.
3953 (bidi_level_of_next_char): Don't try to lookup the cache for the
3954 next/previous character if nothing is cached there yet, or if we
3955 were just reseat()'ed to a new position.
c40e2fb2 3956
0e14fe90
EZ
3957 * xdisp.c (set_cursor_from_row): Set start and stop points
3958 according to the row's direction when priming the loop that looks
3959 for the glyph on which to display cursor.
3960 (single_display_spec_intangible_p): Function deleted.
3961 (display_prop_intangible_p): Reimplement to call
3962 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3963 Accept 3 additional arguments needed by handle_display_spec.
3964 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3965 values: lists, `(when COND...)' forms, etc.
3966 (single_display_spec_string_p): Support property values that are
3967 lists with the argument STRING its top-level element.
3968 (display_prop_string_p): Fix the condition for processing a
3969 property that is a list to be consistent with handle_display_spec.
fec2107c 3970 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3971 last portion of handle_display_prop.
3972 (compute_display_string_pos): Accept additional argument
3973 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3974 value of a `display' property is a "replacing spec".
3975 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3976 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3977 the display property, but just return a value indicating whether
3978 the display property will replace the characters it covers.
3979 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3980 frame_window_p members of struct bidi_it.
d6d100dd
SM
3981 (compute_display_string_pos, compute_display_string_end):
3982 New functions.
fec2107c
EZ
3983 (push_it): Accept second argument POSITION, where pop_it should
3984 jump to continue iteration.
3985 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3986
fec2107c
EZ
3987 * keyboard.c (adjust_point_for_property): Adjust the call to
3988 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3989
3990 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3991 (bidi_init_it): Update prototypes.
3992 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3993 (compute_display_string_pos, compute_display_string_end):
3994 Declare prototypes.
fec2107c
EZ
3995 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3996 EMACS_INT.
fc6f18ce 3997
40087514 39982011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3999
57f53182
PE
4000 Malloc failure behavior now depends on size of allocation.
4001 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4002 * lisp.h: Change signatures accordingly.
4003 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4004 All callers changed. (Bug#8762)
4005
4006 * gnutls.c: Use Emacs's memory allocators.
4007 Without this change, the gnutls library would invoke malloc etc.
4008 directly, which causes problems on non-SYNC_INPUT hosts, and which
4009 runs afoul of improving memory_full behavior. (Bug#8761)
4010 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4011 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4012 xfree instead of the default malloc, realloc, free.
4013 (Fgnutls_boot): No need to check for memory allocation failure,
4014 since xmalloc does that for us.
4015
ac32cd99 4016 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4017 * category.c (hash_get_category_set):
4018 * ccl.c (ccl_driver):
4019 * charset.c (Fdefine_charset_internal):
4020 * charset.h (struct charset.hash_index):
4021 * composite.c (get_composition_id, gstring_lookup_cache)
4022 (composition_gstring_put_cache):
4023 * composite.h (struct composition.hash_index):
4024 * dispextern.h (struct image.hash):
4025 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4026 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4027 (hashfn_equal, hashfn_user_defined, make_hash_table)
4028 (maybe_resize_hash_table, hash_lookup, hash_put)
4029 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4030 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4031 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4032 * image.c (make_image, search_image_cache, lookup_image)
4033 (xpm_put_color_table_h):
4034 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4035 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4036 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4037 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4038 * alloc.c (allocate_vectorlike):
4039 Check for overflow in vector size calculations.
4040 * ccl.c (ccl_driver):
4041 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4042 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4043 need to be updated by these changes.
40087514
PE
4044 * fns.c (make_hash_table, maybe_resize_hash_table):
4045 Check for integer overflow with large hash tables.
0de4bb68
PE
4046 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4047 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4048 (SXHASH_REDUCE): New macro.
4049 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4050 Use it instead of discarding useful hash info with large hash values.
4051 (sxhash_float): New function.
4052 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4053 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4054 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4055 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4056 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4057 Adjust signatures to match updated version of code.
4058 (consing_since_gc): Now EMACS_INT, since a single hash table can
4059 use more than INT_MAX bytes.
4060
698d32e2
DN
40612011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4062
4063 Make it possible to build with GCC-4.6+ -O2 -flto.
4064
4065 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4066
fd6fa53f
SM
40672011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4068
4069 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4070 Call minibuffer-inactive-mode.
4071
864db017
JB
40722011-05-31 Juanma Barranquero <lekktu@gmail.com>
4073
4074 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4075 Update dependencies.
4076
2ad0baf4
DN
40772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4078
4079 * data.c (init_data): Remove code for UTS, this system is not
4080 supported anymore.
4081
4fcc2638
DN
40822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4083
4084 Don't force ./temacs to start in terminal mode.
4085
4086 * frame.c (make_initial_frame): Initialize faces in all cases, not
4087 only when CANNOT_DUMP is defined.
4088 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4089
c56e0fd5
DN
40902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4091
4092 * dispnew.c (add_window_display_history): Use const for the string
4093 pointer. Remove declaration, not needed.
4094
333d54da 40952011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4096
55d4c1b2 4097 Use 'inline', not 'INLINE'.
333d54da 4098 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4099 * alloc.c, fontset.c (INLINE): Remove.
4100 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4101 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4102 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4103 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4104 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4105
738db178
DN
41062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4107
4108 Make it possible to run ./temacs.
4109
4110 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4111 syms_of_callproc does the same thing. Remove test for
4112 "initialized", do it in the caller.
4113 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4114
620c53a6
SM
41152011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4116
4117 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4118 (read_minibuf): Use get_minibuffer.
4119 (syms_of_minibuf): Use DEFSYM.
4120 (Qmetadata): New var.
4121 * data.c (Qbuffer): Don't make it static.
4122 (syms_of_data): Use DEFSYM.
4123
e003a292
PE
41242011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4125
4126 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4127 (CCL_CODE_MIN): New macro.
4128
ed008a6d
PE
41292011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4130
3687c2ef
PE
4131 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4132
ed008a6d
PE
4133 * eval.c (Qdebug): Now static.
4134 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4135 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4136 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4137
d66c4c7c
CY
41382011-05-29 Chong Yidong <cyd@stupidchicken.com>
4139
4140 * image.c: Various fixes to ImageMagick code comments.
4141 (Fimagemagick_types): Doc fix.
4142
5fbc2025
PE
41432011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4144
0196f88a
PE
4145 Minor fixes prompted by GCC 4.6.0 warnings.
4146
4147 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4148
5fbc2025
PE
4149 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4150 (x_clipboard_manager_save_all): Move extern decl to ...
4151 * xterm.h: ... here, so that it can be checked for consistency.
4152
1dd3c2d9
CY
41532011-05-29 Chong Yidong <cyd@stupidchicken.com>
4154
4155 * xselect.c (x_clipboard_manager_save_frame)
4156 (x_clipboard_manager_save_all): New functions.
4157 (Fx_clipboard_manager_save): Lisp function deleted.
4158
4159 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4160 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4161
4162 * xterm.h: Update prototype.
4163
5ba6571d
WX
41642011-05-28 William Xu <william.xwl@gmail.com>
4165
4166 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4167 exiting (Bug#8239).
4168
3eaff834
JM
41692011-05-28 Jim Meyering <meyering@redhat.com>
4170
e1900994 4171 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4172 * fns.c (to_uchar): Define.
4173 (crypto_hash_function): Use it to convert some newly-signed
4174 variables to unsigned, to avoid sign-extension bugs. For example,
4175 without this change, (md5 "truc") would evaluate to
4176 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4177 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4178 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4179
0f6990a7
PE
41802011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4181
4182 Integer overflow fixes.
c8a9ca5a 4183
08686060
PE
4184 * dbusbind.c: Serial number integer overflow fixes.
4185 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4186 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4187 to hold a serial number that is too large for a fixnum.
4188 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4189 Check for serial numbers out of range. Decode any serial number
59568bf0 4190 that was so large that it became a float. (Bug#8722)
08686060 4191
2d1fc3c7
PE
4192 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4193 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4194 Use XFASTINT rather than XUINT when numbers are nonnegative.
4195 (xd_append_arg, Fdbus_method_return_internal):
4196 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4197 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4198 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4199 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4200 (Bug#8722)
2d1fc3c7 4201
c8a9ca5a
PE
4202 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4203
519e1d69
PE
4204 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4205
30569699
PE
4206 ccl: add integer overflow checks
4207 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4208 (IN_INT_RANGE): New macros.
4209 (ccl_driver): Use them to check for integer overflow when
4210 decoding a CCL program. Many of the new checks are whether XINT (x)
4211 fits in int; it doesn't always, on 64-bit hosts. The new version
4212 doesn't catch all possible integer overflows, but it's an
847044ea 4213 improvement. (Bug#8719)
30569699 4214
c11285dc
PE
4215 * alloc.c (make_event_array): Use XINT, not XUINT.
4216 There's no need for unsigned here.
4217
fdccd48e
PE
4218 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4219 This follows up to the 2011-05-06 change that substituted uintptr_t
4220 for EMACS_INT. This case wasn't caught back then.
4221
37910ab2
PE
4222 Rework Fformat to avoid integer overflow issues.
4223 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4224 now (part of C89). Include <verify.h>.
4225 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4226 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4227 (Fformat): Avoid the prepass trying to compute sizes; it was only
4228 approximate and thus did not catch overflow reliably. Instead, walk
4229 through the format just once, formatting and computing sizes as we go,
4230 checking for integer overflow at every step, and allocating a larger
4231 buffer as needed. Keep track separately whether the format is
4232 multibyte. Keep only the most-recently calculated precision, rather
4233 than them all. Record whether each argument has been converted to
4234 string. Use EMACS_INT, not int, for byte and char and arg counts.
4235 Support field widths and precisions larger than INT_MAX. Avoid
4236 sprintf's undefined behavior with conversion specifications such as %#d
4237 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4238 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4239 formatting out-of-range floating point numbers with int
9173deec 4240 formats. (Bug#8668)
37910ab2 4241
2e6578fb
PE
4242 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4243
0ae6bdee
PE
4244 * data.c: Avoid integer truncation in expressions involving floats.
4245 * data.c: Include <intprops.h>.
4246 (arith_driver): When there's an integer overflow in an expression
4247 involving floating point, convert the integers to floating point
4248 so that the resulting value does not suffer from catastrophic
4249 integer truncation. For example, on a 64-bit host (* 4
4250 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4251 Do not rely on undefined behavior after integer overflow.
4252
de883a70
PE
4253 merge count_size_as_multibyte, parse_str_to_multibyte
4254 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4255 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4256 Check for integer overflow.
4257 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4258 since it's now a duplicate of the other. This is more of
4259 a character than a buffer op, so better that it's in character.c.
4260 * fns.c, print.c: Adjust to above changes.
4261
2ff916cb
PE
42622011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4263
4264 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4265
f1b54466
PE
42662011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4267
fb1ac845
PE
4268 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4269 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4270 (x_clipboard_manager_save): Now static.
4271 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4272
f1b54466
PE
4273 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4274 (crypto_hash_function): Now static.
4275 Fix pointer signedness problems. Avoid unnecessary initializations.
4276
a9f737ee
CY
42772011-05-27 Chong Yidong <cyd@stupidchicken.com>
4278
4279 * termhooks.h (Vselection_alist): Make it terminal-local.
4280
4281 * terminal.c (create_terminal): Initialize it.
4282
4283 * xselect.c: Support for clipboard managers.
4284 (Vselection_alist): Move to termhooks.h as terminal-local var.
4285 (LOCAL_SELECTION): New macro.
4286 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4287 (symbol_to_x_atom): Remove gratuitous arg.
4288 (x_handle_selection_request, lisp_data_to_selection_data)
4289 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4290 (x_own_selection, x_get_local_selection, x_convert_selection):
4291 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4292 (some_frame_on_display): Delete unused function.
4293 (Fx_own_selection_internal, Fx_get_selection_internal)
4294 (Fx_disown_selection_internal, Fx_selection_owner_p)
4295 (Fx_selection_exists_p): New optional frame arg.
4296 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4297 (x_handle_selection_clear): Don't treat other terminals with the
4298 same keyboard specially. Use the terminal-local Vselection_alist.
4299 (x_clear_frame_selections): Use Frun_hook_with_args.
4300
4301 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4302
4303 * xterm.h: Add support for those atoms.
4304
e067f0c1
CY
43052011-05-26 Chong Yidong <cyd@stupidchicken.com>
4306
4307 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4308 (converted_selections, conversion_fail_tag): New global variables.
4309 (x_selection_request_lisp_error): Free the above.
4310 (x_get_local_selection): Remove unnecessary code.
4311 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4312 of converted selections stored in converted_selections.
4313 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4314 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4315 (x_convert_selection): New function.
4316 (x_handle_selection_event): Simplify.
4317 (x_get_foreign_selection): Don't ignore incoming requests while
4318 waiting for an answer; this will fail when we implement
4319 SAVE_TARGETS, and seems unnecessary anyway.
4320 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4321 (Vx_sent_selection_functions): Doc fix.
4322
0f4aebc0
LL
43232011-05-26 Leo Liu <sdl.web@gmail.com>
4324
4325 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4326
e61124cd
YM
43272011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4328
4329 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4330
4331 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4332 for fringe update if it has periodic bitmap.
ac389d0c 4333 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4334 and fringe_bitmap_periodic_p.
4335
4336 * fringe.c (get_fringe_bitmap_data): New function.
4337 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4338 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4339 row. Mark glyph row for fringe update if periodicity changed.
4340
4341 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4342 for fringe update unless it has periodic bitmap.
4343
f16d9837
KH
43442011-05-25 Kenichi Handa <handa@m17n.org>
4345
4346 * xdisp.c (get_next_display_element): Set correct it->face_id for
4347 a static composition.
4348
e1b90ef6
LL
43492011-05-24 Leo Liu <sdl.web@gmail.com>
4350
4351 * deps.mk (fns.o):
4352 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4353
4354 * fns.c (crypto_hash_function, Fsha1): New function.
4355 (Fmd5): Use crypto_hash_function.
4356 (syms_of_fns): Add Ssha1.
4357
7400048f
PE
43582011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4359
4360 * gnutls.c: Remove unused macros.
4361 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4362 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4363 Remove macros that are defined and never used.
4364 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4365
abb71cf4
CY
43662011-05-22 Chong Yidong <cyd@stupidchicken.com>
4367
4368 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4369 (Fx_get_selection_internal): Minor cleanup.
4370 (Fx_own_selection_internal): Rename arguments for consistency with
4371 select.el.
4372
6307db39
PE
43732011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4374
4375 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4376
f3d4e0a4
CY
43772011-05-22 Chong Yidong <cyd@stupidchicken.com>
4378
4379 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4380
4d8ade89
YM
43812011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4382
4383 * dispnew.c (scrolling_window): Don't exclude the case that the
4384 last enabled row in the desired matrix touches the bottom boundary.
4385
32078c8d
GM
43862011-05-21 Glenn Morris <rgm@gnu.org>
4387
4388 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4389 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4390 and add some more files.
32078c8d 4391
7285dc67
EZ
43922011-05-20 Eli Zaretskii <eliz@gnu.org>
4393
4394 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4395 report_file_error introduced by the change from 2011-05-07.
4396
89d1bd22
PE
43972011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4398
4399 * systime.h (Time): Define only if emacs is defined.
4400 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4401 where the include path doesn't have X11/X.h by default. See
4402 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4403
e23640bb 44042011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4405
4406 * composite.c (find_automatic_composition): Fix previous change.
4407
b9704ad9
GM
44082011-05-20 Glenn Morris <rgm@gnu.org>
4409
4410 * lisp.mk: New file, split from Makefile.in.
4411 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4412 (shortlisp): Remove.
4413 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4414
4a720484
GM
44152011-05-19 Glenn Morris <rgm@gnu.org>
4416
4417 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4418 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4419 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4420 (lisp): Set the order to that of loadup.el.
4421 (shortlisp): Make it a copy of $lisp.
4422 (SOME_MACHINE_LISP): Remove.
4423 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4424 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4425
a28d4396
KH
44262011-05-18 Kenichi Handa <handa@m17n.org>
4427
4428 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4429 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4430 (find_automatic_composition): Mostly rewrite for efficiency.
4431
a2b1fa8e
JB
44322011-05-18 Juanma Barranquero <lekktu@gmail.com>
4433
4434 * makefile.w32-in: Update dependencies.
4435
8e1f5610
CS
44362011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4437
4438 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4439 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4440
7025ee00 44412011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4442
cdfa6eab
PE
4443 Fix some integer overflow issues, such as string length overflow.
4444
06d6db33
PE
4445 * insdel.c (count_size_as_multibyte): Check for string overflow.
4446
2b4560a8
PE
4447 * character.c (lisp_string_width): Check for string overflow.
4448 Use EMACS_INT, not int, for string indexes and lengths; in
4449 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4450 the resulting string length overflows an EMACS_INT; instead,
4451 report a string overflow if no precision given. When checking for
4452 precision exhaustion, use a check that cannot possibly have
4453 integer overflow. (Bug#8675)
4454 * character.h (lisp_string_width): Adjust to new signature.
4455
cb93f9be
PE
4456 * alloc.c (string_overflow): New function.
4457 (Fmake_string): Use it. This doesn't change behavior, but saves
4458 a few bytes and will simplify future changes.
4459 * character.c (string_escape_byte8): Likewise.
4460 * lisp.h (string_overflow): New decl.
4461
1a1f3366
PE
4462 Fixups, following up to the user-interface timestamp change.
4463 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4464 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4465 * msdos.c (mouse_get_pos): Likewise.
4466 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4467 * w32gui.h (Time): Define by including "systime.h" rather than by
4468 declaring it ourselves. (Bug#8664)
4469
d4e3e4d3
PE
4470 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4471 * image.c (clear_image_cache): Likewise.
4472
f6a24d19
PE
4473 * term.c (term_mouse_position): Don't assume time_t wraparound.
4474
08dc5ae6
PE
4475 Be more systematic about user-interface timestamps.
4476 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4477 and sometimes 'EMACS_UINT', to represent these timestamps.
4478 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4479 This makes the code easier to follow, and makes it easier to catch
4480 integer overflow bugs such as Bug#8664.
4481 * frame.c (Fmouse_position, Fmouse_pixel_position):
4482 Use Time, not unsigned long, for user-interface timestamps.
4483 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4484 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4485 * keyboard.h (last_event_timestamp): Likewise.
4486 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4487 * menu.h (xmenu_show): Likewise.
4488 * term.c (term_mouse_position): Likewise.
4489 * termhooks.h (struct input_event.timestamp): Likewise.
4490 (struct terminal.mouse_position_hook): Likewise.
4491 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4492 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4493 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4494 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4495 what it was before.
4496 * menu.h, termhooks.h: Include "systime.h", for Time.
4497
8e55734a
PE
4498 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4499 Don't assume that the difference between two unsigned long values
4500 can fit into an integer. At this point, we know button_down_time
4501 <= event->timestamp, so the difference must be nonnegative, so
4502 there's no need to cast the result if double-click-time is
4503 nonnegative, as it should be; check that it's nonnegative, just in
4504 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4505 apart (about 25 days). (Bug#8664)
8e55734a 4506
841f1b75 4507 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4508 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4509
3e26f69c
PE
4510 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4511 that always fit in int. Use a sentinel instead of a counter, to
4512 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4513 * frame.h (struct frame): Use int for menu_bar_items_used
4514 instead of EMACS_INT, since it always fits in int.
3e26f69c 4515
5cc152c0
PE
4516 * menu.c (grow_menu_items): Check for int overflow.
4517
d89eb65e
PE
4518 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4519
5235bd3e
PE
4520 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4521 Before, the code was not consistent. These values cannot exceed
4522 2**31 - 1 so there's no need to make them unsigned.
4523 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4524 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4525 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4526 as modifiers.
4527 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4528
bc827e23
PE
4529 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4530 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4531 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4532 presumably because the widths might not match.
4533
78eb494e
PE
4534 * window.c (size_window): Avoid needless test at loop start.
4535
04f2d78b
CB
45362011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4537
4538 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4539
d2fc7e3d 45402011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4541
4542 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4543
d2fc7e3d 45442011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4545
4546 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4547 `width' to `bar_area_x' and `bar_area_width', respectively.
4548 (x_scroll_run): Take account of fringe background extension.
4549
04f2d78b
CB
4550 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4551 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4552 `bar_area_width', respectively.
4553 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4554 background extension.
4555
79b70037
GM
45562011-05-10 Jim Meyering <meyering@redhat.com>
4557
4558 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4559
2f142cc5
JB
45602011-05-10 Juanma Barranquero <lekktu@gmail.com>
4561
4562 * image.c (Finit_image_library): Return t for built-in image types,
4563 like pbm and xbm. (Bug#8640)
4564
57679c86
AS
45652011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4566
4567 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4568
888c9e86
EZ
45692011-05-07 Eli Zaretskii <eliz@gnu.org>
4570
b0512a1d
EZ
4571 * w32console.c (Fset_screen_color): Doc fix.
4572 (Fget_screen_color): New function.
4573 (syms_of_ntterm): Defsubr it.
4574
7285dc67
EZ
4575 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4576 unlink the temporary file if Fcall_process didn't create it in the
4577 first place.
4578 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4579 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4580 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4581 cue to call_process_cleanup not to close that handle.
4582
4d3fcc8e
BK
45832011-05-07 Ben Key <bkey76@gmail.com>
4584
4585 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4586 one of two shell specific rules, either bootstrap-temacs-CMD or
4587 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4588 to the previous implementation of the bootstrap-temacs rule.
4589 The bootstrap-temacs-CMD rule is similar to the previous
4590 implementation of the bootstrap-temacs rule except that it
4591 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4592 variable.
4593
4594 These changes, along with some changes to nt/configure.bat,
4595 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4596 earlier fix to add support for --cflags and --ldflags options
4597 that include quotes so that it works whether make uses cmd or
4598 sh as the shell.
4599
b4289b64
MA
46002011-05-06 Michael Albinus <michael.albinus@gmx.de>
4601
4602 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4603 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4604 is a constant.
4605 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4606 a string. Handle both cases.
4607 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4608 (Fdbus_register_method): Use Qinvalid_function.
4609
af4c0e28
JB
46102011-05-06 Juanma Barranquero <lekktu@gmail.com>
4611
4612 * makefile.w32-in: Update dependencies.
4613 (LISP_H): Add inttypes.h and stdin.h.
4614 (PROCESS_H): Add unistd.h.
4615
c51453d9
EZ
46162011-05-06 Eli Zaretskii <eliz@gnu.org>
4617
4618 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4619 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4620
8ff0ac3c 46212011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4622
4c4b566b
PE
4623 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4624
aab2b9b5
PE
4625 * term.c (vfatal): Remove stray call to va_end.
4626 It's not needed and the C Standard doesn't allow it here anyway.
4627
c378da0b
PE
4628 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4629 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4630
288b08c7
PE
4631 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4632 bytes.
4633
e3601888
PE
4634 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4635
db6c0e74
PE
4636 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4637
dd5963ea
PE
4638 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4639
88c9450f
PE
4640 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4641
2f9442b8
PE
4642 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4643
c032b5f8
PE
4644 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4645 * charset.c (Fdefine_charset_internal): Don't initialize
4646 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4647 32-bit int (Bug#8600).
a108c10b
PE
4648
4649 * lread.c (read_integer): Be more consistent with string-to-number.
4650 Use string_to_number to do the actual conversion; this avoids
4651 rounding errors and fixes some other screwups. Without this fix,
4652 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4653 (digit_to_number): Move earlier, for benefit of read_integer.
4654 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4655 not a digit in any supported base. (Bug#8602)
a108c10b 4656
ad5f9eea
PE
4657 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4658
aec1708a
PE
4659 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4660 to match comment at start of function. This also removes a
4661 GCC warning about overflow in a 32+64-bit port.
4662
47be4ab5
PE
4663 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4664
371cac43
PE
4665 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4666 Reported by Stefan Monnier in
4667 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4668 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4669 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4670
d01a7826
PE
4671 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4672 (EMACS_UINTPTR): Likewise, with uintptr_t.
4673
7fd47d5c
PE
4674 * lisp.h: Prefer 64-bit EMACS_INT if available.
4675 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4676 on 32-bit hosts that have 64-bit int, so that they can access
4677 large files.
122b0c86
PE
4678 However, temporarily disable this change unless the temporary
4679 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4680
8727937b
PE
4681 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4682
8ac068ac
PE
4683 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4684 This removes an assumption that EMACS_INT and long are the same
4685 width as pointers. The assumption is true for Emacs porting targets
4686 now, but we want to make other targets possible.
4687 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4688 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4689 In the rest of the code, change types of integers that hold casted
4690 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4691 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4692 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4693 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4694 No need to cast type when ORing.
4695 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4696 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4697 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4698 assume EMACS_INT is the same width as char *.
4699 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4700 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4701 Remove no-longer-needed casts.
4702 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4703 (xg_tool_bar_help_callback, xg_make_tool_item):
4704 Use EMACS_INTPTR to hold an integer
4705 that will be cast to void *; this can avoid a GCC warning
4706 if EMACS_INT is not the same width as void *.
4707 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4708 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4709 (current_message_1, set_message_1):
4710 Use a local to convert to proper width without a cast.
4711 * xmenu.c (dialog_selection_callback): Likewise.
4712
ede49d71
PE
4713 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4714 Also, don't assume VALBITS / RAND_BITS is less than 5,
4715 and don't rely on undefined behavior when shifting a 1 left into
4716 the sign bit.
4717 * lisp.h (get_random): Change signature to match.
4718
2f30ecd0
PE
4719 * lread.c (hash_string): Use size_t, not int, for hash computation.
4720 Normally we prefer signed values; but hashing is special, because
4721 it's better to use unsigned division on hash table sizes so that
4722 the remainder is nonnegative. Also, size_t is the natural width
4723 for hashing into memory. The previous code used 'int', which doesn't
4724 retain enough info to hash well into very large tables.
4725 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4726
2a866e7b
PE
4727 * dbusbind.c: Don't possibly lose pointer info when converting.
4728 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4729 Use XPNTR rather than XHASH, so that the high-order bits of
4730 the pointer aren't lost when converting through void *.
4731
51639eac
PE
4732 * eval.c (Fautoload): Don't double-shift a pointer.
4733
92394119
PE
4734 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4735
dbdb9a7c
JB
47362011-05-06 Juanma Barranquero <lekktu@gmail.com>
4737
4738 * gnutls.c (DEF_GNUTLS_FN):
4739 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4740
db7a0b4f
AS
47412011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4742
4743 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4744 marker. (Bug#8610)
4745
f7ff1b0f 47462011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4747
4748 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4749 New version that can reserve upto 2GB of heap space.
4750
f7ff1b0f 47512011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4752
4753 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4754
639c109b
TZ
47552011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4756
4757 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4758 `gnutls_certificate_set_x509_key_file'.
4759
d2127135
JB
47602011-05-05 Juanma Barranquero <lekktu@gmail.com>
4761
4762 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4763 Update dependencies.
4764
e968f4f3
JB
47652011-05-04 Juanma Barranquero <lekktu@gmail.com>
4766
4767 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4768 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4769 Remove unused parameter `fildes'.
4770 * process.c (read_process_output, send_process): Don't pass it.
4771
84d358f0
JB
47722011-05-04 Juanma Barranquero <lekktu@gmail.com>
4773
4774 Fix previous change: the library cache is defined in w32.c.
4775 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4776 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4777
0898ca10
JB
47782011-05-04 Juanma Barranquero <lekktu@gmail.com>
4779
4780 Implement dynamic loading of GnuTLS on Windows.
4781
4782 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4783 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4784 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4785 Declare.
4786
4787 * gnutls.c (Qgnutls_dll): Define.
4788 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4789 (gnutls_*): Declare function pointers.
4790 (init_gnutls_functions): New function to initialize function pointers.
4791 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4792 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4793 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4794 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4795 (emacs_gnutls_write, emacs_gnutls_read)
4796 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4797 (Fgnutls_available_p): New function.
4798 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4799 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4800 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4801
4802 * image.c: Include w32.h.
4803 (Vimage_type_cache): Delete.
4804 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4805 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4806 (w32_delayed_load): Move to w32.c.
4807
4808 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4809
4810 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4811 (w32_delayed_load): Move from image.c. When loading a library, record
4812 its filename in the :loaded-from property of the library id.
4813 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4814 Initialize and staticpro them.
4815 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4816
4817 * process.c: Include lisp.h before w32.h, not after.
4818 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4819 instead of gnutls_record_check_pending.
4820
4821 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4822
ff4de4aa
TZ
48232011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4824
4825 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4826 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4827 as passed in.
4828
abe95abb
JD
48292011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4830
4831 * xterm.c (x_set_frame_alpha): Do not set property on anything
4832 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4833
e16e55d4
JB
48342011-05-02 Juanma Barranquero <lekktu@gmail.com>
4835
4836 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4837
bafcf6a5
JB
48382011-05-02 Juanma Barranquero <lekktu@gmail.com>
4839
4840 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4841 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4842 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4843 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4844 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4845 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4846 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4847 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4848 (Qgnutls_bootprop_callbacks_verify): Make static.
4849
e7a6747f
AS
48502011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4851
19ed11ba
AS
4852 * callproc.c: Indentation fixup.
4853
e7a6747f 4854 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4855 (wait_for_termination, interruptible_wait_for_termination):
4856 Move after wait_for_termination_1.
e7a6747f 4857
1ef14cb4
LMI
48582011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4859
4860 * sysdep.c (interruptible_wait_for_termination): New function
4861 which is like wait_for_termination, but allows keyboard
4862 interruptions.
4863
4864 * callproc.c (Fcall_process): Add (:file "file") as an option for
4865 the STDOUT buffer.
4866 (Fcall_process_region): Ditto.
4867
330d880c
EZ
48682011-04-30 Eli Zaretskii <eliz@gnu.org>
4869
8db90b73
EZ
4870 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4871 rather than `XVECTOR (FOO)->size'.
4872
330d880c
EZ
4873 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4874 inttypes.h, as a gnulib replacement is used if it not available in
4875 system headers.
4876
15cbd324
EZ
48772011-04-21 Eli Zaretskii <eliz@gnu.org>
4878
4879 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4880 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4881 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4882
4883 * coding.c (coding_alloc_by_realloc): Error out if destination
4884 will grow beyond MOST_POSITIVE_FIXNUM.
4885 (decode_coding_emacs_mule): Abort if there isn't enough place in
4886 charbuf for the composition carryover bytes. Reserve an extra
4887 space for up to 2 characters produced in a loop.
4888 (decode_coding_iso_2022): Abort if there isn't enough place in
4889 charbuf for the composition carryover bytes.
4890
48912011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4892
ae940cca
EZ
4893 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4894 aborting when %lld or %lll format is passed.
4895 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4896 %llo or %llx format is passed. (Bug#8545)
4897
03ab8921
EZ
4898 * window.c (window_scroll_line_based): Use a marker instead of
4899 simple variables to record original value of point. (Bug#7952)
4900
afda1437
EZ
4901 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4902 produced by %s or %c overflows available buffer space. (Bug#8545)
4903
f76dee0c
PE
49042011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4905
4906 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4907 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4908
fdc5744d
JB
49092011-04-28 Juanma Barranquero <lekktu@gmail.com>
4910
4911 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4912
638f053a
JB
49132011-04-28 Juanma Barranquero <lekktu@gmail.com>
4914
4915 * keyboard.c (Qdelayed_warnings_hook): Define.
4916 (command_loop_1): Run `delayed-warnings-hook'
4917 if Vdelayed_warnings_list is non-nil.
4918 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4919 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4920
d178f871
EZ
49212011-04-28 Eli Zaretskii <eliz@gnu.org>
4922
4923 * doprnt.c (doprnt): Don't return value smaller than the buffer
4924 size if the message was truncated. (Bug#8545).
4925
b124fd93
JB
49262011-04-28 Juanma Barranquero <lekktu@gmail.com>
4927
4928 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4929 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4930
e810457d
PE
49312011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4932
4933 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4934
ea51cceb
JB
49352011-04-27 Juanma Barranquero <lekktu@gmail.com>
4936
4937 * makefile.w32-in: Update dependencies.
4938
94dcfacf
EZ
49392011-04-27 Eli Zaretskii <eliz@gnu.org>
4940
4941 Improve `doprnt' and its usage. (Bug#8545)
4942 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4943 `format_end'. Remove support for %l as a conversion specifier.
4944 Don't use xrealloc. Improve diagnostics when the %l size modifier
4945 is used. Update the commentary.
4946
4947 * eval.c (verror): Simplify calculation of size_t.
4948
4949 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4950 messages.
4951
f61f41d7
PE
49522011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4953
4954 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4955 change.
4956
96fb4434
PE
49572011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4958
4959 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4960 This makes this file independent of the recent pseudovector change.
4961
671875da 49622011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4963
69e9b5a3
PE
4964 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4965
b5f869a7 4966 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4967 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4968 Remove unused local.
c8926152 4969 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4970
841a1577 4971 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4972 GCC 4.6.0 optimizes based on type-based alias analysis.
4973 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4974 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4975 != &v->size, and therefore "v->size = 1; b->size = 2; return
4976 v->size;" must therefore return 1. This assumption is incorrect
4977 for Emacs, since it type-puns struct Lisp_Vector * with many other
4978 types. To fix this problem, this patch adds a new type struct
f904488f 4979 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4980 and pseudovectors, and helps optimizing compilers not get fooled
4981 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4982 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4983 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4984 the size member.
eab3844f
PE
4985 (XSETPVECTYPE): Rewrite in terms of new macro.
4986 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4987 This is a bit clearer, and further avoids the possibility of
4988 undesirable aliasing.
4989 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4990 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4991 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4992 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4993 (ASIZE): Now uses header.size rather than size.
4994 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4995 to avoid the hassle of writing XVECTOR (foo)->header.size.
4996 (struct vectorlike_header): New type.
eab3844f
PE
4997 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4998 object, to help avoid aliasing.
4999 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5000 (SUBRP): Likewise, since Lisp_Subr is a special case.
5001 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5002 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5003 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5004 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5005 changed to be "header.size" and "header.next".
5006 * buffer.h (struct buffer): Likewise.
5007 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5008 * frame.h (struct frame): Likewise.
5009 * process.h (struct Lisp_Process): Likewise.
5010 * termhooks.h (struct terminal): Likewise.
5011 * window.c (struct save_window_data, struct saved_window): Likewise.
5012 * window.h (struct window): Likewise.
5013 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5014 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5015 * buffer.c (init_buffer_once): Likewise.
5016 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5017 special case.
5018 * process.c (Fformat_network_address): Use local var for size,
5019 for brevity.
5020
0df1eac5
PE
5021 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5022
847ab9d1 5023 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5024 * data.c (atof): Remove decl; no longer used or needed.
5025 (digit_to_number): Move to lread.c.
5026 (Fstring_to_number): Use new string_to_number function, to be
5027 consistent with how the Lisp reader treats infinities and NaNs.
5028 Do not assume that floating-point numbers represent EMACS_INT
5029 without losing information; this is not true on most 64-bit hosts.
5030 Avoid double-rounding errors, by insisting on integers when
5031 parsing non-base-10 numbers, as the documentation specifies.
5032 * lisp.h (string_to_number): New decl, replacing ...
5033 (isfloat_string): Remove.
bc0a5c13 5034 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5035 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5036 appears to have been a coding error. Similarly, do not accept
5037 strings like +-1e0 as floating point numbers. Do not report
5038 overflow for integer overflows unless the base is not 10 which
5039 means we have no simple and reliable way to continue.
5040 Break out the floating-point parsing into a new
5041 function string_to_number, so that Fstring_to_number parses
5042 floating point numbers consistently with the Lisp reader.
04f2d78b 5043 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5044 (E_CHAR, EXP_INT): Remove, replacing with ...
5045 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5046 (string_to_number): New function, replacing isfloat_string.
5047 This function checks for valid syntax and produces the resulting
5048 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5049 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5050 so that overflow for non-base-10 numbers is reported only when
5051 there's no portable and simple way to convert to floating point.
452f4150 5052
67769ffc
PE
5053 * textprop.c (set_text_properties_1): Rewrite for clarity,
5054 and to avoid GCC warning about integer overflow.
5055
c20db43f
PE
5056 * intervals.h (struct interval): Use EMACS_INT for members
5057 where EMACS_UINT might cause problems. See
5058 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5059 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5060 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5061 All uses changed.
37aa2f85
PE
5062 (offset_intervals): Tell GCC not to worry about length overflow
5063 when negating a negative length.
c20db43f 5064
2538aa2f
PE
5065 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5066 (overrun_check_free): Likewise.
5067
f2d3008d
PE
5068 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5069 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5070 word size.
5071
ec8df744
PE
5072 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5073 (gnutls_make_error): Rename local to avoid shadowing.
5074 (gnutls_emacs_global_deinit): ifdef out; not used.
5075 (Fgnutls_boot): Use const for pointer to readonly storage.
5076 Comment out unused local. Fix pointer signedness problems.
5077
640ee02d
PE
5078 * lread.c (openp): Don't stuff size_t into an 'int'.
5079 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5080 about possible signed overflow.
5081
6048fb2a
PE
5082 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5083 (GDK_KEY_g): Don't define if already defined.
5084 (xg_prepare_tooltip): Avoid pointer signedness problem.
5085 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5086
fa3c87e1
PE
5087 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5088 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5089
2172544b
PE
5090 * xfns.c (Fx_window_property): Simplify a bit,
5091 to make a bit faster and to avoid GCC 4.6.0 warning.
5092 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5093
9b821a21
PE
5094 * fns.c (internal_equal): Don't assume size_t fits in int.
5095
3c616cfa
PE
5096 * alloc.c (compact_small_strings): Tighten assertion a little.
5097
c2982e87
PE
5098 Replace pEd with more-general pI, and fix some printf arg casts.
5099 * lisp.h (pI): New macro, generalizing old pEd macro to other
5100 conversion specifiers. For example, use "...%"pI"d..." rather
5101 than "...%"pEd"...".
5102 (pEd): Remove. All uses replaced with similar uses of pI.
5103 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5104 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5105 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5106 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5107 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5108 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5109 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5110 64-bit hosts.
5111 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5112 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5113 * print.c (safe_debug_print, print_object): Likewise.
5114 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5115 to int.
6f04d126
PE
5116 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5117 avoiding the 0 flag, which is not portable.
c2982e87
PE
5118 * process.c (Fmake_network_process): Use pI to avoid cast.
5119 * region-cache.c (pp_cache): Likewise.
5120 * xdisp.c (decode_mode_spec): Likewise.
5121 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5122 behavior on 64-bit hosts with printf arg.
6f04d126 5123 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5124 (x_stop_queuing_selection_requests): Likewise.
5125 (x_get_window_property): Don't truncate byte count to an 'int'
5126 when tracing.
0b432f21 5127
5e073ec7
PE
5128 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5129 here, since it parses constructs like leading '-' and spaces,
5130 which are not wanted; and it overflows with large numbers.
5131 Instead, simply match F[0-9]+, which is what is wanted anyway.
5132
36372bf9
PE
5133 * alloc.c: Remove unportable assumptions about struct layout.
5134 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5135 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5136 (allocate_vectorlike, make_pure_vector): Use the new macros,
5137 plus offsetof, to remove unportable assumptions about struct layout.
5138 These assumptions hold on all porting targets that I know of, but
5139 they are not guaranteed, they're easy to remove, and removing them
5140 makes further changes easier.
5141
0b432f21
PE
5142 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5143 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5144 (string_overrun_cookie): Now const. Use initializers that
5145 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5146 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5147 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5148 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5149 multiple of sizeof (EMACS_INT); it need not be, if
5150 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5151 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5152
895009e1
JB
51532011-04-26 Juanma Barranquero <lekktu@gmail.com>
5154
5155 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5156
6a7a1b0b
TZ
51572011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5158
5159 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5160 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5161 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5162
841a1577 51632011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5164
5165 * lisp.h (Qdebug): List symbol.
895009e1 5166 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5167 * keyboard.c (debug-on-event): New variable.
5168 (handle_user_signal): Break into debugger when debug-on-event
5169 matches the current signal symbol.
5170
f2d3ba6f
DN
51712011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5172
5173 * alloc.c (check_sblock, check_string_bytes)
5174 (check_string_free_list): Convert to standard C.
5175
42ce4c63
TZ
51762011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5177
5178 * w32.c (emacs_gnutls_push): Fix typo.
5179
825cd63c
EZ
51802011-04-25 Eli Zaretskii <eliz@gnu.org>
5181
fb11d64d
EZ
5182 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5183 "cast to pointer from integer of different size".
5184
825cd63c
EZ
5185 Improve doprnt and its use in verror. (Bug#8545)
5186 * doprnt.c (doprnt): Document the set of format control sequences
5187 supported by the function. Use SAFE_ALLOCA instead of always
5188 using `alloca'.
5189
5190 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5191 is one byte too soon. Don't use xrealloc; instead xfree and
5192 xmalloc anew.
5193
e061a11b
TZ
51942011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5195
5196 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5197 callbacks stage.
5198
5199 * gnutls.c: Renamed global_initialized to
5200 gnutls_global_initialized. Added internals for the
5201 :verify-hostname-error, :verify-error, and :verify-flags
5202 parameters of `gnutls-boot' and documented those parameters in the
5203 docstring. Start callback support.
9173deec
JB
5204 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5205 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5206 on error. Return error code.
e061a11b
TZ
5207 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5208 (emacs_gnutls_read): Likewise.
5209 (Fgnutls_boot): Return handshake error code.
5210 (emacs_gnutls_handle_error): New function.
5211 (wsaerror_to_errno): Likewise.
5212
5213 * w32.h (emacs_gnutls_pull): Add prototype.
5214 (emacs_gnutls_push): Likewise.
5215
5216 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5217 (emacs_gnutls_push): Likewise.
5218
52192011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5220
5221 * process.c (wait_reading_process_output): Check if GnuTLS
5222 buffered some data internally if no FDs are set for TLS
5223 connections.
5224
5225 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5226 (LIBS): Link to USER_LIBS.
5227 ($(BLD)/gnutls.$(0)): New target.
5228
fa6996bc
EZ
52292011-04-24 Eli Zaretskii <eliz@gnu.org>
5230
eb35682e
EZ
5231 * xdisp.c (handle_single_display_spec): Rename the
5232 display_replaced_before_p argument into display_replaced_p, to
5233 make it consistent with the commentary. Fix typos in the
5234 commentary.
5235
e2ad650c
EZ
5236 * textprop.c (syms_of_textprop): Remove dead code.
5237 (copy_text_properties): Delete obsolete commentary about an
5238 interface that was deleted long ago. Fix typos in the description
5239 of arguments.
5240
1b2de274
EZ
5241 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5242 to changes in oldXMenu/XMenu.h from 2011-04-16.
5243 <menu_help_message, prev_menu_help_message>: Constify.
5244 (IT_menu_make_room): menu->help_text is now `const char **';
5245 adjust.
5246
5247 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5248 to changes in oldXMenu/XMenu.h from 2011-04-16.
5249 (struct XMenu): Declare `help_text' `const char **'.
5250
5251 * xfaces.c <Qunspecified>: Make extern again.
5252
5253 * syntax.c: Include sys/types.h before including regex.h, as
5254 required by Posix.
5255
762b15be
EZ
5256 * doc.c (get_doc_string): Improve the format passed to `error'.
5257
5258 * doprnt.c (doprnt): Improve commentary.
5259
5260 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5261
5262 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5263 them with etags.
5264
f1052e5d
EZ
5265 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5266 changes in globals.h immediately force recompilation.
762b15be
EZ
5267 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5268 $(CURDIR)/s/ms-w32.h.
5269 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5270
fa6996bc
EZ
5271 * character.c (Fchar_direction): Function deleted.
5272 (syms_of_character): Don't defsubr it.
5273 <char-direction-table>: Deleted.
5274
e6c3da20
EZ
52752011-04-23 Eli Zaretskii <eliz@gnu.org>
5276
5277 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5278 * doprnt.c: Include limits.h.
5279 (SIZE_MAX): New macro.
04f2d78b
CB
5280 (doprnt): Return a size_t value. 2nd arg is now size_t.
5281 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5282 Improve overflow protection. Support `l' modifier for integer
5283 conversions. Support %l conversion. Don't assume an EMACS_INT
5284 argument for integer conversions and for %c.
5285
5286 * lisp.h (doprnt): Restore prototype.
5287
5288 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5289 $(SRC)/character.h.
5290
5291 * Makefile.in (base_obj): Add back doprnt.o.
5292
5293 * deps.mk (doprnt.o): Add back prerequisites.
5294 (callint.o): Depend on character.h.
5295
5296 * eval.c (internal_lisp_condition_case): Include the handler
5297 representation in the error message.
5298 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5299 when breaking from the loop.
5300
5301 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5302
5303 * callint.c (Fcall_interactively): When displaying error message
5304 about invalid control letter, pass the character's codepoint, not
5305 a pointer to its multibyte form. Improve display of the character
5306 in octal and display also its hex code.
5307
5308 * character.c (char_string): Use %x to display the (unsigned)
5309 codepoint of an invalid character, to avoid displaying a bogus
5310 negative value.
5311
5312 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5313 `error', not SYMBOL_NAME itself.
5314
5315 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5316 character arguments to `error'.
5317
5318 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5319 to `error' in error message about FINAL_CHAR argument. Make sure
5320 FINAL_CHAR is a character, and use %c when it is passed as
5321 argument to `error'.
5322
4ffd0d6b 53232011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5324
5325 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5326
5327 * w32.c: Include <time.h>.
5328 (sys_localtime): New function.
5329
4ffd0d6b 53302011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5331
5332 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5333
4ffd0d6b 5334 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5335
4ffd0d6b 53362011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5337
4ffd0d6b
GM
5338 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5339 zombies (Bug#8467).
aac0c6e3 5340
04c56954
EZ
53412011-04-19 Eli Zaretskii <eliz@gnu.org>
5342
5343 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5344 gl_state.e_property when gl_state.object is Qt.
5345
5346 * insdel.c (make_gap_larger): Remove limitation of buffer size
5347 to <= INT_MAX.
5348
16a43933
CY
53492011-04-18 Chong Yidong <cyd@stupidchicken.com>
5350
5351 * xdisp.c (lookup_glyphless_char_display)
5352 (produce_glyphless_glyph): Handle cons cell entry in
5353 glyphless-char-display.
5354 (Vglyphless_char_display): Document it.
5355
5356 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5357 glyphless-char-display.
5358
4581706e
CY
53592011-04-17 Chong Yidong <cyd@stupidchicken.com>
5360
5361 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5362
5363 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5364
5365 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5366 definition for no-X builds.
5367
4887c6e2 53682011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5369
fd35b6f9
PE
5370 Static checks with GCC 4.6.0 and non-default toolkits.
5371
5c1ccb01
PE
5372 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5373
006c5daa
PE
5374 * process.c (keyboard_bit_set): Define only if SIGIO.
5375 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5376 (send_process): Repair possible setjmp clobbering.
5377
efc736d3
PE
5378 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5379
4e2fe2e6
PE
5380 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5381
f97334a2
PE
5382 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5383
4e75f29d
PE
5384 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5385 Define only if needed.
5386
90efadd1
PE
5387 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5388 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5389 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5390
3c647824
PE
5391 * dispextern.h (struct redisplay_interface): Rename param
5392 to avoid shadowing.
e264f262 5393 * termhooks.h (struct terminal): Likewise.
761383f4 5394 * xterm.c (xembed_send_message): Likewise.
3c647824 5395
b58c5c4a
PE
5396 * insdel.c (make_gap_smaller): Define only if
5397 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5398
cad59032
PE
5399 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5400 it.
5401
c339dc2e
PE
5402 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5403 so that we aren't warned about unused symbols.
5404
91a3e27b
PE
5405 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5406
399c71d3 5407 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5408
8ffc96f5
PE
5409 * xfns.c (x_real_positions): Mark locals as initialized.
5410
eef9bc79
PE
5411 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5412
098db9dd
PE
5413 * xterm.c: Fix problems found by static analysis with other toolkits.
5414 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5415 (x_dispatch_event): Declare static if USE_GTK, and
5416 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5417 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5418 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5419 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5420 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5421
eb18f6cc
PE
5422 * xmenu.c (menu_help_callback): Pointer type fixes.
5423 Use const pointers when pointing at readonly data. Avoid pointer
5424 signedness clashes.
5425 (FALSE): Remove unused macro.
5426 (update_frame_menubar): Remove unused decl.
5427
1fe72bf8
PE
5428 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5429
60d9e1db
PE
5430 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5431 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5432 (single_menu_item): Rename local to avoid shadowing.
5433
39261c26
PE
5434 * keyboard.c (make_lispy_event): Remove unused local var.
5435
018c5e19
PE
5436 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5437 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5438
63d2b86e
PE
5439 * bitmaps: Change bitmaps from unsigned char back to the X11
5440 compatible char. Avoid the old compiler warnings about
5441 out-of-range initializers by using, for example, '\xab' rather
5442 than 0xab.
5443
aefd87e1
PE
5444 * xgselect.c (xgselect_initialize): Check vs interface
5445 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5446
bf501fb9
PE
5447 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5448
e9829fdf
PE
5449 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5450 to read-only memory.
5451
1086c095
PE
5452 * fns.c (vector): Remove; this old hack is no longer needed.
5453
2baccd04 5454 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5455 Remove unused var.
dde42981 5456 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5457
72391843 5458 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5459
436c16df 5460 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5461 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5462 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5463
92bb796d 5464 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5465 (x_term_init): Remove local to avoid shadowing.
92bb796d 5466
764430a3 5467 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5468
5469 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5470 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5471
d1dfb56c
EZ
54722011-04-16 Eli Zaretskii <eliz@gnu.org>
5473
c4354cb4
EZ
5474 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5475
d1dfb56c
EZ
5476 Fix regex.c, syntax.c and friends for buffers > 2GB.
5477 * syntax.h (struct gl_state_s): Declare character position members
5478 EMACS_INT.
5479
5480 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5481
04f2d78b
CB
5482 * textprop.c (verify_interval_modification, interval_of):
5483 Declare arguments EMACS_INT.
d1dfb56c
EZ
5484
5485 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5486 EMACS_INT.
5487
5488 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5489
5490 * indent.c (Fvertical_motion): Local variable it_start is now
5491 EMACS_INT.
5492
5493 * regex.c (re_match, re_match_2, re_match_2_internal)
5494 (bcmp_translate, regcomp, regexec, print_double_string)
5495 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5496 (re_compile_pattern, re_exec): Declare arguments and local
5497 variables `size_t' and `ssize_t' and return values `regoff_t', as
5498 appropriate.
5499 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5500 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5501 <compile_stack_type>: `size' and `avail' are now `size_t'.
5502
5503 * regex.h <regoff_t>: Use ssize_t, not int.
5504 (re_search, re_search_2, re_match, re_match_2): Arguments that
5505 specify buffer/string position and length are now ssize_t and
5506 size_t. Return type is regoff_t.
5507
613052cd
BK
55082011-04-16 Ben Key <bkey76@gmail.com>
5509
5510 * nsfont.m: Fixed bugs in ns_get_family and
5511 ns_descriptor_to_entity that were caused by using free to
5512 deallocate memory blocks that were allocated by xmalloc (via
5513 xstrdup). This caused Emacs to crash when compiled with
5514 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5515 --enable-checking=xmallocoverrun). xfree is now used to
5516 deallocate these memory blocks.
5517
4170f62f 55182011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5519
71b41406
PE
5520 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5521
9587a89d
PE
5522 emacs_write: Accept and return EMACS_INT for sizes.
5523 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5524 et seq.
5525 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5526 Accept and return EMACS_INT.
5527 (emacs_gnutls_write): Return the number of bytes written on
5528 partial writes.
5529 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5530 (emacs_read, emacs_write): Remove check for negative size, as the
5531 Emacs source code has been audited now.
9587a89d
PE
5532 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5533 (emacs_read, emacs_write): Use it.
273a5f82
PE
5534 * process.c (send_process): Adjust to the new signatures of
5535 emacs_write and emacs_gnutls_write. Do not attempt to store
5536 a byte offset into an 'int'; it might overflow.
9587a89d 5537 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5538
3e047f51
PE
5539 * sound.c: Don't assume sizes fit in 'int'.
5540 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5541 Return EMACS_INT, not int.
3e047f51 5542 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5543 Accept EMACS_INT, not int.
5544 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5545 record read return values.
5546
cc39a9db
BK
55472011-04-15 Ben Key <bkey76@gmail.com>
5548
c9d0ec6d
JB
5549 * keyboard.c (Qundefined): Don't declare static since it is used
5550 in nsfns.m.
5551 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5552 static since they are used in nsfont.m.
cc39a9db 5553
6c60eb9f
SM
55542011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5555
5556 * process.c (Qprocessp): Don't declare static.
5557 * lisp.h (Qprocessp): Declare again.
5558
7990b61a
JB
55592011-04-15 Juanma Barranquero <lekktu@gmail.com>
5560
5561 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5562
5d4cb038
PE
55632011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5564
8bd7b830 5565 Improve C-level modularity by making more things 'static'.
cd64ea1d 5566
e3b27b31
PE
5567 Don't publish debugger-only interfaces to other modules.
5568 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5569 (verify_bytepos, count_markers): Move decls to the only modules
5570 that need them.
5571 * region-cache.h (pp_cache): Likewise.
5572 * window.h (check_all_windows): Likewise.
5573 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5574
5d4cb038
PE
5575 * sysdep.c (croak): Now static, if
5576 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5577 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5578
5579 * alloc.c (refill_memory_reserve): Now static if
5580 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5581 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5582
e87b6180
PE
5583 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5584 Define only if USE_LUCID.
5585
ac64929e
PE
5586 * xrdb.c (x_customization_string, x_rm_string): Now static.
5587
6f37259d
PE
5588 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5589 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5590
1683e3ab
PE
5591 * xdisp.c (draw_row_with_mouse_face): Now static.
5592 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5593
de9c2632
PE
5594 * window.h (check_all_windows): Mark externally visible.
5595
2b96acb7
PE
5596 * window.c (window_deletion_count): Now static.
5597
5598 * undo.c: Make symbols static if they're not exported.
5599 (last_undo_buffer, last_boundary_position, pending_boundary):
5600 Now static.
5601
50436f33
PE
5602 * textprop.c (interval_insert_behind_hooks): Now static.
5603 (interval_insert_in_front_hooks): Likewise.
5604
64520e5c
PE
5605 * term.c: Make symbols static if they're not exported.
5606 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5607 (max_frame_lines, tty_set_terminal_modes):
5608 (tty_reset_terminal_modes, tty_turn_off_highlight):
5609 (get_tty_terminal): Now static.
5610 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5611 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5612 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5613 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5614 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5615
1fa53021
PE
5616 * sysdep.c: Make symbols static if they're not exported.
5617 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5618 Now static.
5619 (sigprocmask_set, full_mask): Remove; unused.
5620 (wait_debugging): Mark as visible.
5621 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5622 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5623
d4b43b22
PE
5624 * syntax.c (syntax_temp): Define only if !__GNUC__.
5625
b7c513d0
PE
5626 * sound.c (current_sound_device, current_sound): Now static.
5627
989b29ad
PE
5628 * search.c (searchbufs, searchbuf_head): Now static.
5629
13a55a78
PE
5630 * scroll.c (scroll_cost): Remove; unused.
5631 * dispextern.h (scroll_cost): Remove decl.
5632
de68a1fc
PE
5633 * region-cache.h (pp_cache): Mark as externally visible.
5634
40ccffa6
PE
5635 * process.c: Make symbols static if they're not exported.
5636 (process_tick, update_tick, create_process, chan_process):
5637 (Vprocess_alist, proc_buffered_char, datagram_access):
5638 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5639 (deactivate_process): Mark defn as static, as well as decl.
5640 * lisp.h (create_process): Remove decl.
5641 * process.h (chan_process, Vprocess_alist): Remove decls.
5642
ad64fc97
PE
5643 * print.c: Make symbols static if they're not exported.
5644 (print_depth, new_backquote_output, being_printed, print_buffer):
5645 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5646 (print_interval, print_number_index, initial_stderr_stream):
5647 Now static.
5648 * lisp.h (Fprinc): Remove decl.
5649 (debug_output_compilation_hack): Mark as externally visible.
5650
adddb265
PE
5651 * sysdep.c (croak): Move decl from here to syssignal.h.
5652 * syssignal.h (croak): Put it here, so the API can be checked when
5653 'croak' is called from dissociate_if_controlling_tty.
5654
1717ede2
PE
5655 * minibuf.c: Make symbols static if they're not exported.
5656 (minibuf_save_list, choose_minibuf_frame): Now static.
5657 * lisp.h (choose_minibuf_frame): Remove decl.
5658
fa5fb2bc
PE
5659 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5660
1e3890d1
PE
5661 * lread.c: Make symbols static if they're not exported.
5662 (read_objects, initial_obarray, oblookup_last_bucket_number):
5663 Now static.
5664 (make_symbol): Remove; unused.
5665 * lisp.h (initial_obarray, make_symbol): Remove decls.
5666
8a1414fa
PE
5667 * keyboard.c: Make symbols static if they're not exported.
5668 (single_kboard, recent_keys_index, total_keys, recent_keys):
5669 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5670 (this_single_command_key_start, echoing, last_auto_save):
5671 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5672 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5673 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5674 (Vlispy_mouse_stem, double_click_count):
5675 Now static.
5676 (force_auto_save_soon): Define only if SIGDANGER.
5677 (ignore_mouse_drag_p): Now static if
5678 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5679 (print_help): Remove; unused.
5680 (stop_character, last_timer_event): Mark as externally visible.
5681 * keyboard.h (ignore_mouse_drag_p): Declare only if
5682 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5683 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5684 * lisp.h (echoing): Remove decl.
5685 (force_auto_save_soon): Declare only if SIGDANGER.
5686 * xdisp.c (redisplay_window): Simplify code, to make it more
5687 obvious that ignore_mouse_drag_p is not accessed if !defined
5688 USE_GTK && !defined HAVE_NS.
5689
93ea6e8f
PE
5690 * intervals.c: Make symbols static if they're not exported.
5691 (merge_properties_sticky, merge_interval_right, delete_interval):
5692 Now static.
5693 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5694
77382fcc
PE
5695 * insdel.c: Make symbols static if they're not exported.
5696 However, leave prepare_to_modify_buffer alone. It's never
5697 called from outside this function, but that appears to be a bug.
5698 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5699 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5700 (adjust_after_replace_noundo): Remove; unused.
5701 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5702 (signal_before_change): Remove decls.
77382fcc 5703
9306c32e
PE
5704 * indent.c (val_compute_motion, val_vmotion): Now static.
5705
cd44d2eb
PE
5706 * image.c: Make symbols static if they're not exported.
5707 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5708 if USE_GTK.
5709 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5710 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5711
ad9a7a06
PE
5712 * fringe.c (standard_bitmaps): Now static.
5713 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5714
81626931
PE
5715 * frame.c: Make symbols static if they're not exported.
5716 (x_report_frame_params, make_terminal_frame): Now static.
5717 (get_frame_param): Now static, unless HAVE_NS.
5718 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5719 (x_get_resource_string): Remove; not used.
5720 * frame.h (make_terminal_frame, x_report_frame_params):
5721 (x_get_resource_string); Remove decls.
5722 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5723 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5724
239f9db9
PE
5725 * font.c, fontset.c: Make symbols static if they're not exported.
5726 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5727 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5728 * font.c (font_close_object): Now static.
5729 * font.h (font_close_object): Remove.
5730 * fontset.c (FONTSET_OBJLIST): Remove.
5731 (free_realized_fontset) #if-0 the body, which does nothing.
5732 (face_suitable_for_char_p): #if-0, as it's never called.
5733 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5734 * xfaces.c (face_at_string_position):
5735 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5736 since 0 is always ASCII.
5737
dfcf3579
PE
5738 * fns.c (weak_hash_tables): Now static.
5739
5045092b
PE
5740 * fileio.c: Make symbols static if they're not exported.
5741 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5742 (Vwrite_region_annotation_buffers): Now static.
5743
57a96f5c
PE
5744 * eval.c: Make symbols static if they're not exported.
5745 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5746 * lisp.h (backtrace_list): Remove decl.
5747
35f08c38
PE
5748 * emacs.c: Make symbols static if they're not exported.
5749 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5750 (fatal_error_code, fatal_error_signal_hook, standard_args):
5751 Now static.
5752 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5753 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5754 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5755 * lisp.h (fatal_error_signal_hook): Remove decl.
5756 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5757
f44bd759
PE
5758 * editfns.c: Move a (normally-unused) function to its only use.
5759 * editfns.c, lisp.h (get_operating_system_release): Remove.
5760 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5761 worth the hassle of breaking this out.
5762
b532497d
PE
5763 * xterm.c: Make symbols static if they're not exported.
5764 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5765 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5766 (x_destroy_window, x_delete_display):
5767 Now static.
5768 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5769 (x_mouse_leave): Remove; unused.
5770 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5771 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5772 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5773 Remove decls.
5774 (x_mouse_leave): Declare only if WINDOWSNT.
5775 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5776 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5777 USE_X_TOOLKIT.
5778
1675728f
PE
5779 * ftxfont.c: Make symbols static if they're not exported.
5780 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5781 HAVE_FREETYPE.
5782 * font.h (ftxfont_driver): Likewise.
5783
e4cebfca
PE
5784 * xfns.c: Make symbols static if they're not exported.
5785 (x_last_font_name, x_display_info_for_name):
5786 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5787 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5788 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5789 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5790 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5791 (last_show_tip_args): Now static.
5792 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5793 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5794 (x_screen_planes): Remove; unused.
5795 * dispextern.h (x_screen_planes): Remove decl.
5796
5bf46f05
PE
5797 * dispnew.c: Make symbols static if they're not exported.
5798 * dispextern.h (redraw_garbaged_frames, scrolling):
5799 (increment_row_positions): Remove.
5800 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5801 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5802 Now static.
5803 (redraw_garbaged_frames): Remove; unused.
5804
435f4c28
PE
5805 * xfaces.c: Make symbols static if they're not exported.
5806 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5807 Remove decls.
5808 * xterm.h (defined_color): Remove decls.
5809 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5810 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5811 (menu_face_changed_default, defined_color, free_realized_face):
5812 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5813 (ascii_face_of_lisp_face): Remove; unused.
5814
8524aef3
PE
5815 * xdisp.c: Make symbols static if they're not exported.
5816 * dispextern.h (scratch_glyph_row, window_box_edges):
5817 (glyph_to_pixel_coords, set_cursor_from_row):
5818 (get_next_display_element, set_iterator_to_next):
5819 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5820 (show_mouse_face): Remove decls
5821 * frame.h (message_buf_print): Likewise.
5822 * lisp.h (pop_message, set_message, check_point_in_composition):
5823 Likewise.
5824 * xterm.h (set_vertical_scroll_bar): Likewise.
5825 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5826 (message_buf_print, scratch_glyph_row, displayed_buffer):
5827 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5828 (get_next_display_element, show_mouse_face, window_box_edges):
5829 (frame_to_window_pixel_xy, check_point_in_composition):
5830 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5831 (glyph_to_pixel_coords): Remove; unused.
5832
16390cd2
PE
5833 * dired.c (file_name_completion): Now static.
5834
5835 * dbusbind.c (xd_in_read_queued_messages): Now static.
5836
a25f4dfa
PE
5837 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5838 * data.c (circular_list_error): Remove.
5839
14a9c8df
PE
5840 * commands.h (last_point_position, last_point_position_buffer):
5841 (last_point_position_window): Remove decls.
5842 * keyboard.c: Make these variables static.
5843
04f2d78b
CB
5844 * coding.h (coding, code_convert_region, encode_coding_gap):
5845 Remove decls.
74ab6df5
PE
5846 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5847 (iso_code_class, detect_coding, code_convert_region): Now static.
5848 (encode_coding_gap): Remove; unused.
5849
38dfbee1
PE
5850 * chartab.c (chartab_chars, chartab_bits): Now static.
5851
a2cb4e63
PE
5852 * charset.h (charset_iso_8859_1): Remove decl.
5853 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5854 Now static.
5855
127198fd
PE
5856 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5857 * ccl.c (Vccl_program_table): Now static.
5858 (check_ccl_update): Remove; unused.
5859
d85b608f
PE
5860 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5861 * category.h: ... from here.
5862 * category.c (check_category_table, set_category_set): Now static.
5863
31cd66f3
PE
5864 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5865 * lisp.h: Remove these decls.
5866
c358e587
PE
5867 * buffer.c (buffer_count): Remove unused var.
5868
e78aecca
PE
5869 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5870 so that it's not optimized away.
5871 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5872 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5873 exported only to the debugger.
5874
e192d7d3 5875 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5876 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5877
92470028
PE
5878 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5879 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5880 was inaccessible from Lisp.
5881 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5882 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5883
244ed907
PE
5884 alloc.c: Import and export fewer symbols, and remove unused items.
5885 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5886 is defined.
5887 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5888 it's not optimized away by whole-program optimization.
5889 (message_enable_multibyte, free_misc): Remove.
5890 (catchlist, handlerlist, mark_backtrace):
5891 Declare only if BYTE_MARK_STACK.
5892 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5893 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5894 (message_enable_multibyte): Remove decl.
5895 (free_misc, interval_free_list, float_block, float_block_index):
5896 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5897 (cons_free_list, last_marked_index):
5898 Now static.
5899 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5900 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5901 (mark_backtrace): Define only if BYTE_MARK_STACK.
5902 * xdisp.c (message_enable_multibyte): Now static.
5903
61c2b50e 5904 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5905 This makes it easier for human readers (and static analyzers)
5906 to see whether these variables are used from other modules.
5907 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5908 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5909 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5910 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5911 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5912 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5913 * xmenu.c, xselect.c:
5914 Declare Q* vars static if they are not used in other modules.
5915 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5916 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5917 Remove decls of unexported vars.
5918 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5919
95c82688
PE
5920 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5921
16a97296
PE
5922 Make Emacs functions such as Fatom 'static' by default.
5923 This makes it easier for human readers (and static analyzers)
5924 to see whether these functions can be called from other modules.
5925 DEFUN now defines a static function. To make the function external
5926 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5927 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5928 (Finit_image_library):
16a97296
PE
5929 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5930 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5931 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5932 Remove decls, since these functions are now static.
5933 (Funintern, Fget_internal_run_time): New decls, since these functions
5934 were already external.
95c82688 5935
16a97296
PE
5936 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5937 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5938 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5939 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5940 * keyboard.c, keymap.c, lread.c:
5941 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5942 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5943 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5944 Mark functions with DEFUE instead of DEFUN,
5945 if they are used in other modules.
5946 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5947 decls for now-static functions.
5948 * buffer.h (Fdelete_overlay): Remove decl.
5949 * callproc.c (Fgetenv_internal): Mark as internal.
5950 * composite.c (Fremove_list_of_text_properties): Remove decl.
5951 (Fcomposition_get_gstring): New forward static decl.
5952 * composite.h (Fcomposite_get_gstring): Remove decl.
5953 * dired.c (Ffile_attributes): New forward static decl.
5954 * doc.c (Fdocumntation_property): New forward static decl.
5955 * eval.c (Ffetch_bytecode): New forward static decl.
5956 (Funintern): Remove extern decl; now in .h file where it belongs.
5957 * fileio.c (Fmake_symbolic_link): New forward static decl.
5958 * image.c (Finit_image_library): New forward static decl.
5959 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5960 * intervals.h (Fprevious_property_change):
5961 (Fremove_list_of_text_properties): Remove decls.
5962 * keyboard.c (Fthis_command_keys): Remove decl.
5963 (Fcommand_execute): New forward static decl.
5964 * keymap.c (Flookup_key): New forward static decl.
5965 (Fcopy_keymap): Now static.
5966 * keymap.h (Flookup_key): Remove decl.
5967 * process.c (Fget_process): New forward static decl.
5968 (Fprocess_datagram_address): Mark as internal.
5969 * syntax.c (Fsyntax_table_p): New forward static decl.
5970 (skip_chars): Remove duplicate decl.
5971 * textprop.c (Fprevious_property_change): New forward static decl.
5972 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5973 Now internal.
5974 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5975 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5976
785bbd42
PE
5977 * editfns.c (Fformat): Remove unreachable code.
5978
8b913b57
AS
59792011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5980
5981 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5982 change. (Bug#8496)
5983
a6744a35
EZ
59842011-04-13 Eli Zaretskii <eliz@gnu.org>
5985
5986 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5987 when at ZV. (Bug#8487)
5988
e7974947
AS
59892011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5990
baad03f0
AS
5991 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5992 (Bug#8437)
5993 * keyboard.c (parse_tool_bar_item): Likewise.
5994 * sound.c (sound_cleanup, alsa_close): Likewise.
5995 * termcap.c (tgetent): Likewise.
5996 * xfns.c (x_default_font_parameter): Likewise.
5997 * xsettings.c (read_and_apply_settings): Likewise.
5998
e7974947
AS
5999 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6000 (overrun_check_free): Protoize.
6001
28272684
PE
60022011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6003
6004 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6005 since callers should never pass a negative size.
6006 Change the signature to match that of plain 'read' and 'write'; see
6007 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6008 * lisp.h: Update prototypes of emacs_write and emacs_read.
6009
11997c76
EZ
60102011-04-11 Eli Zaretskii <eliz@gnu.org>
6011
6012 * xdisp.c (redisplay_window): Don't try to determine the character
6013 position of the scroll margin if the window start point w->startp
e896f03c 6014 is outside the buffer's accessible region. (Bug#8468)
11997c76 6015
8a2cbd72
EZ
60162011-04-10 Eli Zaretskii <eliz@gnu.org>
6017
6018 Fix write-region and its subroutines for buffers > 2GB.
6019 * fileio.c (a_write, e_write): Modify declaration of arguments and
6020 local variables to support buffers larger than 2GB.
6021 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6022
6023 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6024 argument, local variables, and return value.
6025
6026 * lisp.h: Update prototypes of emacs_write and emacs_read.
6027
6028 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6029
4073e537 60302011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6031
1ebfdcb6
PE
6032 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6033
b2ded58d
PE
6034 Fix more problems found by GCC 4.6.0's static checks.
6035
7d66342c
PE
6036 * xdisp.c (vmessage): Use a better test for character truncation.
6037
bbf47d44
PE
6038 * charset.c (load_charset_map): <, not <=, for optimization,
6039 and to avoid potential problems with integer overflow.
9248994d 6040 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6041 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6042 * editfns.c (Fformat): Likewise.
1e69125e 6043 * syntax.c (skip_chars): Likewise.
3befa583 6044
e3019616
PE
6045 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6046 This also lets GCC 4.6.0 generate slightly better loop code.
6047
becfa255
PE
6048 * callint.c (Fcall_interactively): <, not <=, for optimization.
6049 (Fcall_interactively): Count the number of arguments produced,
6050 not the number of arguments given. This is simpler and lets GCC
6051 4.6.0 generate slightly better code.
6052
dae0cd48
PE
6053 * ftfont.c: Distingish more carefully between FcChar8 and char.
6054 The previous code passed unsigned char * to a functions like
6055 strlen and xstrcasecmp that expect char *, which does not
6056 conform to the C standard.
6057 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6058 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6059 char * when the C standard requires it.
6060
76032d70
PE
6061 * keyboard.c (read_char): Remove unused var.
6062
eb3f1cc8
PE
6063 * eval.c: Port to Windows vsnprintf (Bug#8435).
6064 Include <limits.h>.
6065 (SIZE_MAX): Define if the headers do not.
6066 (verror): Do not give up if vsnprintf returns a negative count.
6067 Instead, grow the buffer. This ports to Windows vsnprintf, which
6068 does not conform to C99. Problem reported by Eli Zaretskii.
6069 Also, simplify the allocation scheme, by avoiding the need for
6070 calling realloc, and removing the ALLOCATED variable.
6071
70476b54
PE
6072 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6073
12020a9e
PE
6074 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6075 But keep the doprint source code for now, as we might revamp it
6076 and use it again (Bug#8435).
ea6c7ae6
PE
6077 * lisp.h (doprnt): Remove.
6078 * Makefile.in (base_obj): Remove doprnt.o.
6079 * deps.mk (doprnt.o): Remove.
6080
5fdb398c
PE
6081 error: Print 32- and 64-bit integers portably (Bug#8435).
6082 Without this change, on typical 64-bit hosts error ("...%d...", N)
6083 was used to print both 32- and 64-bit integers N, which relied on
6084 undefined behavior.
6085 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6086 New macro.
6087 * lisp.h (error, verror): Mark as printf-like functions.
6088 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6089 Report overflow in size calculations when allocating printf buffer.
6090 Do not truncate output string at its first null byte.
6091 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6092 Truncate the output at a character boundary, since vsnprintf does not
6093 do that.
6094 * charset.c (check_iso_charset_parameter): Convert internal
6095 character to string before calling 'error', since %c now has the
6096 printf meaning.
6097 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6098 overflow when computing char to be passed to 'error'. Do not
6099 pass Lisp_Object to 'error'; pass the integer instead.
6100 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6101 formatted with plain %d.
6102
b189fa66
PE
6103 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6104
bff87ef0
PE
6105 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6106
7e2cac20
PE
6107 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6108
ce4d90b5
PE
6109 * xterm.c (x_catch_errors): Remove duplicate declaration.
6110
266c9547
PE
6111 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6112
79c49ad2
PE
6113 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6114
368f4090
JM
61152011-04-10 Jim Meyering <meyering@redhat.com>
6116
6117 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6118 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6119 return ssize_t not "int", and use size_t as the buffer length.
6120 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6121 * gnutls.h: Update declarations.
6122 * process.c (read_process_output): Use ssize_t, to match.
6123 (send_process): Likewise.
6124
a32d4040
CY
61252011-04-09 Chong Yidong <cyd@stupidchicken.com>
6126
6127 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6128
8546720e 61292011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6130
04f2d78b
CB
6131 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6132 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6133
8546720e
GM
6134 * xterm.c (handle_one_xevent):
6135 * xmenu.c (create_and_show_popup_menu):
6136 * xselect.c (x_decline_selection_request)
6137 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6138
0a2f5c1a 61392011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6140
6141 Fix some uses of `int' instead of EMACS_INT.
6142 * search.c (string_match_1, fast_string_match)
6143 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6144 (scan_buffer, find_next_newline_no_quit)
6145 (find_before_next_newline, search_command, Freplace_match)
6146 (Fmatch_data): Make some `int' variables be EMACS_INT.
6147
6148 * xdisp.c (display_count_lines): 3rd argument and return value now
6149 EMACS_INT. All callers changed.
6150 (pint2hrstr): Last argument is now EMACS_INT.
6151
6152 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6153 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6154 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6155 (decode_coding_utf_16, decode_coding_emacs_mule)
6156 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6157 (decode_coding_ccl, decode_coding_charset)
6158 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6159 (decode_coding_iso_2022, decode_coding_emacs_mule)
6160 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6161 <char_offset, last_offset>: Declare EMACS_INT.
6162 (encode_coding_utf_8, encode_coding_utf_16)
6163 (encode_coding_emacs_mule, encode_invocation_designation)
6164 (encode_designation_at_bol, encode_coding_iso_2022)
6165 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6166 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6167 Declare EMACS_INT.
6168 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6169 (encode_invocation_designation): Last argument P_NCHARS is now
6170 EMACS_INT.
6171 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6172 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6173
6174 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6175 All users changed.
6176
6177 * ccl.c (Fccl_execute_on_string): Declare some variables
6178 EMACS_INT.
6179
8546720e 61802011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6181
6182 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6183
4e19a977
CS
61842011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6185
6186 * process.c (Fformat_network_address): Doc fix.
6187
87302331
R
61882011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6189
6190 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6191
cbb59342
CY
61922011-04-08 Chong Yidong <cyd@stupidchicken.com>
6193
6194 * keyboard.c (read_char): Call Lisp function help-form-show,
6195 instead of using internal_with_output_to_temp_buffer.
6196 (Qhelp_form_show): New var.
e0d38eeb 6197 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6198
6199 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6200
6201 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6202
e67a13ab
CY
62032011-04-06 Chong Yidong <cyd@stupidchicken.com>
6204
04f2d78b
CB
6205 * process.c (Flist_processes): Remove to Lisp.
6206 (list_processes_1): Delete.
e67a13ab 6207
973f782d
EZ
62082011-04-06 Eli Zaretskii <eliz@gnu.org>
6209
7c106b1e
EZ
6210 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6211
973f782d
EZ
6212 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6213
41cf7d1a 62142011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6215
ca23cc88
PE
6216 Fix more problems found by GCC 4.6.0's static checks.
6217
f390e2d5
PE
6218 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6219
42eea0d0
PE
6220 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6221
b69769da 6222 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6223
f9541e84
PE
6224 * xdisp.c (vmessage): Mark as a printf-like function.
6225
13841b55
PE
6226 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6227
c136c10f
PE
6228 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6229
5e2d4a30
PE
6230 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6231 printf-like functions.
6232 (tiff_load): Add casts to remove these marks before passing them
6233 to system-supplied API.
6234
583f48b9
PE
6235 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6236
b25d760e
PE
6237 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6238 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6239 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6240 directly, rather than having caller test rule sign. This avoids
6241 some unnecessary tests.
6242 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6243 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6244 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6245
bc7b6697 6246 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6247 (xfont_open): Avoid unnecessary tests.
bc7b6697 6248
27ccc379
PE
6249 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6250
dcd5c89a
PE
6251 * composite.h, composite.c (composition_gstring_put_cache):
6252 Use EMACS_INT, not int, for length.
6253
b13a45c6
PE
6254 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6255 breaking out part of COMPOSITION_DECODE_RULE.
6256 (COMPOSITION_DECODE_RULE): Use it.
6257 * composite.c (get_composition_id): Remove unused local vars,
6258 by using the new macro.
6259
1e792e4d
PE
6260 * textprop.c (set_text_properties_1): Change while to do-while,
6261 since the condition is always true at first.
6262
dc6c6455 6263 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6264 (interval_deletion_adjustment): Return unsigned value.
6265 All uses changed.
dc6c6455 6266
aba7731a
PE
6267 * process.c (list_processes_1, create_pty, read_process_output):
6268 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6269 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6270 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6271 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6272 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6273
fdfc4bf3
PE
6274 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6275
fca8fe46 6276 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6277 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6278
06a0259a 6279 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6280 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6281 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6282
e7b9e80f
PE
6283 * print.c (print_error_message): Avoid int overflow.
6284
56201685
PE
6285 * font.c (font_list_entities): Redo for clarity,
6286 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6287
78834453 6288 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6289 (font_score): Avoid potential overflow in diff calculation.
78834453 6290
0bc0b309 6291 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6292 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6293
e610eaca
PE
6294 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6295
b895abce
PE
6296 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6297 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6298 can always succeed if overflow has undefined behavior.
6299
1f1d9321 6300 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6301 (wordify): Omit three unnecessary tests.
1f1d9321 6302
c59478bc
PE
6303 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6304 All callers changed. This avoids the need for an unused var.
6305
79b73827
PE
6306 * casefiddle.c (casify_region): Remove var that is set but not used.
6307
a4db5dfe
PE
6308 * dired.c (file_name_completion): Remove var that is set but not used.
6309
43aae36e
PE
6310 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6311
2a47c44d 6312 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6313 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6314
a37c69bf
PE
6315 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6316 Check for integer overflow on size calculations.
6317
328ab8e7
PE
6318 * buffer.c (Fprevious_overlay_change): Remove var that is set
6319 but not used.
6320
e5a2a5cb
PE
6321 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6322 Remove vars that are set but not used.
8d84a6eb 6323 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6324 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6325
a60e5f68
PE
6326 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6327
f661cb61 6328 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6329 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6330
f0397f5a
PE
6331 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6332 that are set but not used.
6333
8664db06 6334 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6335 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6336
6abdaa4a
PE
6337 * xselect.c (x_get_local_selection, x_handle_property_notify):
6338 Remove vars that are set but not used.
6339
0ce7538d 6340 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6341 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6342
9ae848fc
PE
6343 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6344 Remove var that is set but not used.
0b918413
PE
6345 (scroll_bar_windows_size): Now size_t, not int.
6346 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6347 Check for overflow.
9ae848fc 6348
a5a62657
PE
6349 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6350 (map_tty_color) [!defined MSDOS]: Likewise.
6351
5c5cdd39
PE
6352 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6353
66ebf983
PE
6354 * coding.c: Remove vars that are set but not used.
6355 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6356 All callers changed.
6357 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6358 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6359 (decode_coding_charset): Remove vars that are set but not used.
6360
1be4d761
PE
6361 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6362 that is set but not used.
6363
47553fa8
PE
6364 * print.c (print_object): Remove var that is set but not used.
6365
1f7196bf 6366 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6367 The gnulib version avoids calling malloc in the usual case,
6368 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6369 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6370 * filelock.c (current_lock_owner): Likewise.
6371 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6372 * sysdep.c: Include allocator.h, careadlinkat.h.
6373 (emacs_no_realloc_allocator): New static constant.
6374 (emacs_readlink): New function.
fdb61804
PE
6375 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6376 ../lib/careadlinkat.h.
d1fdcab7 6377
f84c17c7
SM
63782011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6379
6380 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6381 first non-nil return value).
6382
ef3862ad
JD
63832011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6384
6385 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6386 if not defined (Bug#8403).
6387
376a7006
JB
63882011-04-02 Juanma Barranquero <lekktu@gmail.com>
6389
6390 * xdisp.c (display_count_lines): Remove parameter `start',
6391 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6392 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6393 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6394 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6395 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6396 and thereabouts. All callers changed.
6397 (get_per_char_metric): Remove parameter `f', unused since
6398 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6399
6ca3801d
JM
64002011-04-02 Jim Meyering <meyering@redhat.com>
6401
6402 do not dereference NULL upon failed strdup
6403 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6404 (ns_get_family): Likewise.
6405
d8e2b5ba
JB
64062011-04-02 Juanma Barranquero <lekktu@gmail.com>
6407
6408 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6409
8c74fcbd
JD
64102011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6411
6412 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6413 later (Bug#8403).
6414
7200d79c
SM
64152011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6416
03408648 6417 Add lexical binding.
7200d79c 6418
03408648
SM
6419 * window.c (Ftemp_output_buffer_show): New fun.
6420 (Fsave_window_excursion):
6421 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6422
6423 * lread.c (lisp_file_lexically_bound_p): New function.
6424 (Fload): Bind Qlexical_binding.
6425 (readevalloop): Remove `evalfun' arg.
6426 Bind Qinternal_interpreter_environment.
6427 (Feval_buffer): Bind Qlexical_binding.
6428 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6429 Mark as dynamic.
6430 (syms_of_lread): Declare `lexical-binding'.
6431
6432 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6433
6434 * keyboard.c (eval_dyn): New fun.
6435 (menu_item_eval_property): Use it.
ca105506
SM
6436
6437 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6438
03408648
SM
6439 * fns.c (concat, mapcar1): Accept byte-code-functions.
6440
6441 * eval.c (Fsetq): Handle lexical vars.
6442 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6443 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6444 (FletX, Flet): Obey lexical binding.
6445 (Fcommandp): Handle closures.
6446 (Feval): New `lexical' arg.
6447 (eval_sub): New function extracted from Feval. Use it almost
6448 everywhere where Feval was used. Look up vars in lexical env.
6449 Handle closures.
6450 (Ffunctionp): Move from subr.el.
6451 (Ffuncall): Handle closures.
6452 (apply_lambda): Remove `eval_flags'.
6453 (funcall_lambda): Handle closures and new byte-code-functions.
6454 (Fspecial_variable_p): New function.
6455 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6456 but without exporting it to Lisp.
23aba0ea 6457
23aba0ea 6458 * doc.c (Fdocumentation, store_function_docstring):
03408648 6459 * data.c (Finteractive_form): Handle closures.
23aba0ea 6460
03408648
SM
6461 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6462 interactive spec.
ba83908c 6463
04f2d78b
CB
6464 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6465 New byte-codes.
03408648
SM
6466 (exec_byte_code): New function extracted from Fbyte_code to handle new
6467 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6468
03408648 6469 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6470
03408648 6471 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6472
e2abce01
JB
64732011-03-31 Juanma Barranquero <lekktu@gmail.com>
6474
6475 * xdisp.c (redisplay_internal): Fix prototype.
6476
63696a73 64772011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6478
63696a73 6479 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6480 (try_scrolling): Use it when setting scroll_limit.
6481 Limit scrolling to 100 screen lines.
63696a73
EZ
6482 (redisplay_window): Even when falling back on "recentering",
6483 position point in the window according to scroll-conservatively,
6484 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6485
6486 (try_scrolling): When point is above the window, allow searching
6487 as far as scroll_max, or one screenful, to compute vertical
6488 distance from PT to the scroll margin position. This prevents
6489 try_scrolling from unnecessarily failing when
6490 scroll-conservatively is set to a value slightly larger than the
6491 window height. Clean up the case of PT below the margin at bottom
6492 of window: scroll_max can no longer be INT_MAX. When aggressive
6493 scrolling is in use, don't let point enter the opposite scroll
6494 margin as result of the scroll.
6495 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6496 threshold of 100 lines for never-recentering scrolling.
6497
e4cc2dfc
JB
64982011-03-31 Juanma Barranquero <lekktu@gmail.com>
6499
6500 * dispextern.h (move_it_by_lines):
6501 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6502 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6503 (message_log_check_duplicate): Remove parameters `prev_bol' and
6504 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6505 (redisplay_internal): Remove parameter `preserve_echo_area',
6506 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6507
6508 * indent.c (Fvertical_motion):
6509 * window.c (window_scroll_pixel_based, Frecenter):
6510 Don't pass `need_y_p' to `move_it_by_lines'.
6511
1c470562
SM
65122011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6513
44f230aa
SM
6514 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6515 steal a few bits to be more compact.
6516 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6517 Remove unneeded casts.
6518
1c470562
SM
6519 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6520
888adce9
ZK
65212011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6522
6523 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6524 binding" message (bug#7967).
6525
f838ed7b
PE
65262011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6527
77861b95
PE
6528 Fix more problems found by GCC 4.6.0's static checks.
6529
de6dbc14
PE
6530 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6531 Remove unused local var.
6532
f838ed7b
PE
6533 * editfns.c (Fmessage_box): Remove unused local var.
6534
792c7b2b
PE
6535 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6536 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6537 Omit unused local vars.
c499e557 6538 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6539 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6540 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6541 Omit unused local var.
6542
ba0165e1
PE
6543 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6544 Don't assume string length fits in int.
32ad8845 6545 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6546 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6547
3c59b4c9
PE
6548 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6549 instead of alloca (Bug#8344).
6550
a3eed478 6551 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6552 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6553
eb4d412d
PE
6554 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6555
1658b401
PE
6556 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6557 concerns.
6558
6559 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6560
6561 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6562
9a2c6e05
PE
6563 * keyboard.c (syms_of_keyboard): Use the same style as later
6564 in this function when indexing through an array. This also
6565 works around GCC bug 48267.
6566
03d0a109
PE
6567 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6568
44f730c8
PE
6569 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6570
fe75f926
PE
6571 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6572 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6573
ffa8c828
PE
6574 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6575 This avoids undefined behavior on integer overflow, and is a bit
6576 more convenient anyway since it is compared to a size_t variable.
6577
c5101a77
PE
6578 Variadic C functions now count arguments with size_t, not int.
6579 This avoids an unnecessary limitation on 64-bit machines, which
6580 caused (substring ...) to crash on large vectors (Bug#8344).
6581 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6582 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6583 All variadic functions and their callers changed accordingly.
c5101a77
PE
6584 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6585 * data.c (arith_driver, float_arith_driver): Likewise.
6586 * editfns.c (general_insert_function): Likewise.
6587 * eval.c (struct backtrace.nargs, interactive_p)
6588 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6589 (funcall_lambda, mark_backtrace): Likewise.
6590 * fns.c (concat): Likewise.
6591 * frame.c (x_set_frame_parameters): Likewise.
6592 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6593 0 if not found, not -1. All callers changed.
6594
dd3f25f7
PE
6595 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6596 (stack_copy_size): Now size_t, not int.
6597 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6598
461c2ab9
JB
65992011-03-28 Juanma Barranquero <lekktu@gmail.com>
6600
6601 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6602 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6603 All callers changed.
6604
6605 * lisp.h (multibyte_char_to_unibyte):
6606 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6607 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6608 * character.h (CHAR_TO_BYTE8):
6609 * cmds.c (internal_self_insert):
6610 * editfns.c (general_insert_function):
6611 * keymap.c (push_key_description):
6612 * search.c (Freplace_match):
6613 * xdisp.c (message_dolog, set_message_1): All callers changed.
6614
f6d62986
SM
66152011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6616
6617 * keyboard.c (safe_run_hook_funcall): New function.
6618 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6619 don't set the hook to nil, but remove the offending function instead.
6620 (Qcommand_hook_internal): Remove, unused.
6621 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6622 Vcommand_hook_internal.
6623
6624 * eval.c (enum run_hooks_condition): Remove.
6625 (funcall_nil, funcall_not): New functions.
6626 (run_hook_with_args): Call each function through a `funcall' argument.
6627 Remove `cond' argument, now redundant.
6628 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6629 (Frun_hook_with_args_until_failure): Adjust accordingly.
6630 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6631
1db5b1ad
JB
66322011-03-28 Juanma Barranquero <lekktu@gmail.com>
6633
6634 * dispextern.h (string_buffer_position): Remove declaration.
6635
6636 * print.c (strout): Remove parameter `multibyte', unused since
6637 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6638
6639 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6640 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6641 All callers changed.
6642
6643 * w32.c (_wsa_errlist): Use braces for struct initializers.
6644
6645 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6646 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6647 All callers changed.
6648 (string_buffer_position): Likewise. Also, make static (it's never
6649 used outside xdisp.c).
6650 (cursor_row_p): Remove parameter `w', unused since
6651 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6652 (decode_mode_spec): Remove parameter `precision', introduced during
6653 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6654 All callers changed.
6655
5ffb62aa
JD
66562011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6657
6658 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6659
461c2ab9 66602011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6661
6662 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6663 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6664 (ns_update_auto_hide_menu_bar): New functions.
6665 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6666 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6667 ns_constrain_all_frames.
6668 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6669 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6670
5c380ffb
JD
66712011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6672
6673 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6674
9af30bdf
GM
66752011-03-27 Glenn Morris <rgm@gnu.org>
6676
6677 * syssignal.h: Replace RETSIGTYPE with void.
6678 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6679 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6680 Replace SIGTYPE with void everywhere.
6681 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6682 * s/template.h (SIGTYPE): Remove commented out definition.
6683
e2abce01
JB
66842011-03-26 Eli Zaretskii <eliz@gnu.org>
6685
6686 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6687 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6688
f868cd8a
JB
66892011-03-26 Juanma Barranquero <lekktu@gmail.com>
6690
59eb0929
JB
6691 * w32.c (read_unc_volume): Use parameter `henum', instead of
6692 global variable `wget_enum_handle'.
6693
6694 * keymap.c (describe_vector): Remove parameters `indices' and
6695 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6696 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6697
f868cd8a
JB
6698 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6699
6700 * keyboard.c (timer_check): Remove parameter `do_it_now',
6701 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6702 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6703 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6704
6705 * keyboard.c (read_char):
6706 * w32menu.c (w32_menu_display_help):
6707 * xmenu.c (show_help_event, menu_help_callback):
6708 Adjust calls to `show_help_echo'.
6709
6710 * gtkutil.c (xg_maybe_add_timer):
6711 * keyboard.c (readable_events):
6712 * process.c (wait_reading_process_output):
6713 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6714
6715 * insdel.c (adjust_markers_gap_motion):
6716 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6717 (gap_left, gap_right): Don't call it.
6718
2ecf6fdb
CY
67192011-03-25 Chong Yidong <cyd@stupidchicken.com>
6720
6721 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6722 incurred during fontification.
6723
6b1f9ba4
JB
67242011-03-25 Juanma Barranquero <lekktu@gmail.com>
6725
6726 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6727 (DEFVAR_PER_BUFFER): Don't pass it.
6728
6729 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6730 (scrolling_window): Don't pass it.
6731
0f4a96b5
JB
67322011-03-25 Juanma Barranquero <lekktu@gmail.com>
6733
6734 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6735
6736 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6737 and `suffix'.
6738 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6739 of variables specific to SELinux and computation of `encoded_absname'.
6740
6741 * image.c (XPutPixel): Remove unused variable `height'.
6742
6743 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6744
6745 * unexw32.c (get_section_info): Remove unused variable `section'.
6746
6747 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6748 (system_process_attributes): Remove unused variable `sess'.
6749 (sys_read): Remove unused variable `err'.
6750
6751 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6752 (w32_wnd_proc): Remove unused variable `isdead'.
6753 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6754 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6755 (x_create_tip_frame): Remove unused variable `tem'.
6756
6757 * w32inevt.c (w32_console_read_socket):
6758 Remove unused variable `no_events'.
6759
6760 * w32term.c (x_draw_composite_glyph_string_foreground):
6761 Remove unused variable `width'.
6762
1149507c
JB
67632011-03-24 Juanma Barranquero <lekktu@gmail.com>
6764
6765 * w32term.c (x_set_glyph_string_clipping):
6766 Don't pass uninitialized region to CombineRgn.
6767
9c88f339
JB
67682011-03-23 Juanma Barranquero <lekktu@gmail.com>
6769
6770 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6771 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6772 (Fx_close_connection): Remove unused variable `i'.
6773
6774 * w32font.c (w32font_draw): Return number of glyphs.
6775 (w32font_open_internal): Remove unused variable `i'.
6776 (w32font_driver): Add missing initializer.
6777
6778 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6779 (fill_in_menu): Remove unused variable `items_added'.
6780
6781 * w32term.c (last_mouse_press_frame): Remove static global variable.
6782 (w32_clip_to_row): Remove unused variable `f'.
6783 (x_delete_terminal): Remove unused variable `i'.
6784
6785 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6786 (NOTHING): Remove unused static global variable.
6787 (uniscribe_check_otf): Remove unused variable `table'.
6788 (uniscribe_font_driver): Add missing initializers.
6789
dee091a3
JD
67902011-03-23 Julien Danjou <julien@danjou.info>
6791
6792 * term.c (Fsuspend_tty, Fresume_tty):
6793 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6794 * window.c (temp_output_buffer_show):
6795 * insdel.c (signal_before_change):
6796 * frame.c (Fhandle_switch_frame):
6797 * fileio.c (Fdo_auto_save):
6798 * emacs.c (Fkill_emacs):
6799 * editfns.c (save_excursion_restore):
6800 * cmds.c (internal_self_insert):
6801 * callint.c (Fcall_interactively):
6802 * buffer.c (Fkill_all_local_variables):
6803 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6804 Use Frun_hooks.
0f4a96b5 6805 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6806 unconditionnaly since it does the check itself.
6807
2c520ab5 68082011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6809
c9c49752
PE
6810 Fix more problems found by GCC 4.5.2's static checks.
6811
8abc3f12
PE
6812 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6813 the first time through the loop, since we know p0 < p1 then.
6814 This also avoids a gcc -Wstrict-overflow warning.
6815
a2d26660
PE
6816 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6817 leading to a memory leak, possible in functions like
6818 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6819 of objects (Bug#8318).
a2d26660 6820
916c72e9
PE
6821 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6822 that could (at least in theory) be that large.
6823
19ab8a18
PE
6824 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6825 This is less likely to overflow, and avoids undefined behavior if
6826 overflow does occur. All callers changed. Use strtoul to scan
6827 for the unsigned long integer.
b7cbbd6f
PE
6828 (pint2hrstr): Simplify and tune code slightly.
6829 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6830
f0641eff
PE
6831 * scroll.c (do_scrolling): Work around GCC bug 48228.
6832 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6833
7f650bb9
PE
6834 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6835 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6836 (validate_x_resource_name): Simplify count usage.
6837 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6838
37dd57d1
PE
6839 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6840 fail (Bug#8306).
81e56e61 6841
699979fc 6842 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6843
401bf9b4
PE
6844 * process.c (Fmake_network_process): Use socklen_t, not int,
6845 where POSIX says socklen_t is required in portable programs.
6846 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6847 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6848 (Fmake_network_process, server_accept_connection):
6849 (wait_reading_process_output, read_process_output):
6850 Likewise.
6851
b93aacde
PE
6852 * process.c: Rename or move locals to avoid shadowing.
6853 (list_processes_1, Fmake_network_process):
6854 (read_process_output_error_handler, exec_sentinel_error_handler):
6855 Rename or move locals.
4dc343ee 6856 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6857 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6858 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6859 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6860 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6861
af8a867c 6862 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6863 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6864 Include tparam.h instead, since it declares them.
af8a867c
PE
6865 * cm.h (PC): Remove extern decl; tparam.h now does this.
6866 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6867 * terminfo.c: Include tparam.h, to check interfaces.
6868 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6869 (tparam): Adjust signature to match interface in tparam.h;
6870 this removes some undefined behavior. Check that outstring and len
6871 are zero, which they always are with Emacs.
6872 * tparam.h (PC, BC, UP): New extern decls.
6873
0248044d 6874 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6875 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6876
8ff096c1 6877 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6878 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6879 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6880 (ftfont_list): Remove unused local.
49eaafba
PE
6881 (get_adstyle_property, ftfont_pattern_entity):
6882 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6883 Rename locals to avoid shadowing.
8ff096c1 6884
e2be39f6
PE
6885 * xfont.c (xfont_list_family): Mark var as initialized.
6886
c9735e30
PE
6887 * xml.c (make_dom): Now static.
6888
8f5201ae
PE
6889 * composite.c (composition_compute_stop_pos): Rename local to
6890 avoid shadowing.
b246f932
PE
6891 (composition_reseat_it): Remove unused locals.
6892 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6893 (composition_update_it): Mark var as initialized.
11b61122
PE
6894 (find_automatic_composition): Mark vars as initialized,
6895 with a FIXME (Bug#8290).
8f5201ae 6896
760fbc2c
PE
6897 character.h: Rename locals to avoid shadowing.
6898 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6899 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6900 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6901 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6902 to avoid shadowing.
6903
ff08eb85
PE
6904 * textprop.c (property_change_between_p): Remove; unused.
6905
fc7bf025
PE
6906 * intervals.c (interval_start_pos): Now static.
6907
235d7abc
PE
6908 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6909
44f230aa
SM
6910 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6911 Rename locals to avoid shadowing.
3e7d6594 6912
50060332
PE
6913 * sound.c (wav_play, au_play, Fplay_sound_internal):
6914 Fix pointer signedness.
d01f234b 6915 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6916 (wav_play): Initialize a variable to 0, to prevent undefined
6917 behavior (Bug#8278).
50060332 6918
c4fc4e30
PE
6919 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6920
918436ed
PE
6921 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6922
c939f91b
PE
6923 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6924 clobbering (Bug#8298).
b9c7f648
PE
6925 * sysdep.c (sys_subshell): Likewise.
6926 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6927
6bd8c144
PE
6928 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6929 This should get cleaned up, so that child_setup has the
6930 same signature on all platforms.
6931
7710357c 6932 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6933 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6934
c59da222
CY
69352011-03-22 Chong Yidong <cyd@stupidchicken.com>
6936
6937 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6938 not to be necessary, and produces flickering.
6939
66b87493
GM
69402011-03-20 Glenn Morris <rgm@gnu.org>
6941
6942 * config.in: Remove file.
6943
45b6f6d5
JB
69442011-03-20 Juanma Barranquero <lekktu@gmail.com>
6945
6946 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6947 are now in src/globals.h.
6948 (syms_of_minibuf): Remove spurious & from previous change.
6949
3ec03f7e
LL
69502011-03-20 Leo <sdl.web@gmail.com>
6951
6952 * minibuf.c (completing-read-function): New variable.
6953 (completing-read-default): Rename from completing-read.
6954 (completing-read): Call completing-read-function.
6955
b14e3e21
CY
69562011-03-19 Juanma Barranquero <lekktu@gmail.com>
6957
6958 * xfaces.c (Fx_load_color_file):
6959 Read color file from absolute filename (bug#8250).
6960
f2b726e6
JB
69612011-03-19 Juanma Barranquero <lekktu@gmail.com>
6962
6963 * makefile.w32-in: Update dependencies.
6964
09f6ff02
EZ
69652011-03-17 Eli Zaretskii <eliz@gnu.org>
6966
6967 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6968
29a6015a
PE
69692011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6970
a3a6c54e
PE
6971 Fix more problems found by GCC 4.5.2's static checks.
6972
b766f867
PE
6973 * process.c (make_serial_process_unwind, send_process_trap):
6974 (sigchld_handler): Now static.
6975
be02381c
PE
6976 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6977 That way, the code declares only the vars that it needs.
6978 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6979 * s/cygwin.h (PTY_ITERATION): Likewise.
6980 * s/darwin.h (PTY_ITERATION): Likewise.
6981 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6982
57048744
PE
6983 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6984 * process.c (allocate_pty): Don't declare stb unless it's needed.
6985
7914961c 6986 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6987 (CONSTANTLIM): Remove; unused.
6988 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6989 Define only if needed.
7914961c 6990
b3967b18
PE
6991 * unexelf.c (unexec): Name an expression,
6992 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6993 Use a different way to cause a compilation error if anyone uses
6994 n rather than nn, a way that does not involve shadowing.
73366a00 6995 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6996
29a6015a
PE
6997 * deps.mk (unexalpha.o): Remove; unused.
6998
43cfc33e 6999 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7000 * unexec.h: New file.
ce701a33
PE
7001 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7002 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7003 Depend on unexec.h.
7004 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7005 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7006 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7007 Change as necessary to match prototype in unexec.h.
ce701a33 7008
01f44d5a
PE
7009 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7010 shadowing.
4f63c6bb 7011 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7012
a6670b0b
PE
7013 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7014 Rename locals to avoid shadowing.
7015
cef2010d 7016 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7017 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7018
d4d7173a
PE
7019 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7020
f08b802a
PE
7021 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7022 warning when compiling print.c.
7023
3ddb0639
PE
7024 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7025 instead of using an uninitialized var.
5ad03b97 7026 (font_sort_entities): Mark var as initialized.
3ddb0639 7027
170a2692
PE
7028 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7029
e663c700
PE
7030 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7031 pointers to constants.
89bc529a 7032 (font_parse_fcname): Remove unused vars.
7b81e2d0 7033 (font_delete_unmatched): Now static.
ea838e10 7034 (font_get_spec): Remove; unused.
13a547c6
PE
7035 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7036 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7037 Rename or move locals to avoid shadowing.
e663c700 7038
2a80c887 7039 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7040 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7041
1384fa33 7042 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7043 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7044
8b2c52e9
PE
7045 * alloc.c (mark_backtrace): Move decl from here ...
7046 * lisp.h: ... to here, so that it can be checked.
7047
475545b5 7048 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7049 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7050 (lisp_indirect_variable): Name an expression,
7051 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7052 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7053
b1349114 7054 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7055 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7056 Use const pointer when appropriate.
b1349114 7057
a2928364
PE
7058 * lisp.h (get_system_name, get_operating_system_release):
7059 Move decls here, to check interfaces.
7060 * process.c (get_operating_system_release): Move decl to lisp.h.
7061 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7062 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7063 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7064 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7065 (Fformat_time_string, Fencode_time, Finsert_char):
7066 (Ftranslate_region_internal, Fformat):
7067 Rename or remove local vars to avoid shadowing.
9710023e 7068 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7069
a415e694
PE
7070 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7071 avoid shadowing.
7072
8ef4622d
PE
7073 * lisp.h (eassert): Check that the argument compiles, even if
7074 ENABLE_CHECKING is not defined.
7075
946f9a5b
PE
7076 * data.c (Findirect_variable): Name an expression, to avoid
7077 gcc -Wbad-function-cast warning.
112396d6 7078 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7079 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7080 (Fmake_variable_buffer_local, Fmake_local_variable):
7081 Mark variables as initialized.
52746918 7082 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7083
e5aab7e7 7084 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7085 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7086 Rename locals to avoid shadowing.
dff45157
PE
7087 (mark_stack): Move local variables into the #ifdef region where
7088 they're used.
7bc26fdb
PE
7089 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7090 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7091 needed otherwise.
7092 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7093 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7094 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7095
e5aab7e7
PE
7096 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7097 avoids undefined behavior in theory.
7098
4da60324
PE
7099 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7100
88043301
PE
7101 Use functions, not macros, for up- and down-casing (Bug#8254).
7102 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7103 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7104 to use the following functions instead of these macros.
7105 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7106 EMACS_INT, since callers assume the returned value fits in int.
7107 (upcase1): Likewise, for UPCASE_TABLE.
7108 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7109 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7110 the race-condition problem in the old DOWNCASE.
88043301 7111
19ed5445
PE
7112 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7113 Rename locals to avoid shadowing.
7114 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7115 (regex_compile, re_search_2, re_match_2_internal):
7116 Remove unused local vars.
952db0d7
PE
7117 (FREE_VAR): Rewrite so as not to use empty "else",
7118 which gcc can warn about.
da053e48 7119 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7120 (RETALLOC_IF): Define only if needed.
7121 (WORDCHAR_P): Likewise. This one is never needed, but is used
7122 only in a comment talking about a compiler bug, so put inside
7123 the #if 0 of that comment.
7124 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7125 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7126 Remove; unused.
19ed5445 7127
1f3561e4 7128 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7129 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7130 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7131
ded6f8f7
PE
7132 * search.c (simple_search): Remove unused var.
7133
dbd37a95
PE
7134 * dired.c (compile_pattern): Move decl from here ...
7135 * lisp.h: ... to here, so that it can be checked.
7136 (struct re_registers): New forward decl.
7137
7e47afad
PE
7138 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7139
85f24f61
PE
7140 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7141 All uses changed.
7142 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7143 Rename locals to avoid shadowing.
5671df8f 7144 (Fvertical_motion): Mark locals as initialized.
85f24f61 7145
181aa2be 7146 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7147 (casify_region): Mark local as initialized.
181aa2be 7148
930d429c
PE
7149 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7150
7082eac6
PE
7151 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7152 New macros, so that the caller can use some names other than
7153 gcpro1, gcpro2, etc.
7154 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7155 of the new macros.
7156 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7157 argument, for consistency with GCPRO2_VAR, etc: it is now the
7158 prefix of the variable, not the variable itself. All uses
7159 changed.
38b2c076
PE
7160 * dired.c (directory_files_internal, file_name_completion):
7161 Rename locals to avoid shadowing.
7162
15206ed9
PE
7163 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7164 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7165 dired.c's scmp function, had undefined behavior.
7166 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7167 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7168 * buffer.h: ... to here, because these macros use current_buffer,
7169 and the new implementation with inline functions needs to have
7170 current_buffer in scope now, rather than later when the macros
7171 are used.
7172 (downcase, upcase1): New static inline functions.
7173 (DOWNCASE, UPCASE1): Reimplement using these functions.
7174 This avoids undefined behavior in expressions like
7175 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7176 from race conditions in accessing the global variables
7177 case_temp1 and case_temp2.
7178 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7179 * lisp.h (case_temp1, case_temp2): Remove their decls.
7180 * character.h (ASCII_CHAR_P): Move from here ...
7181 * lisp.h: ... to here, so that the inline functions mentioned
7182 above can use them.
7183
4a6bea26
PE
7184 * dired.c (directory_files_internal_unwind): Now static.
7185
f14b7e14
PE
7186 * fileio.c (file_name_as_directory, directory_file_name):
7187 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7188 Now static.
2893f146
PE
7189 (file_name_as_directory): Use const pointers when appropriate.
7190 (Fexpand_file_name): Likewise. In particular, newdir might
7191 point at constant storage, so make it a const pointer.
fd4ead52 7192 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7193 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7194 signedness issues.
f839df0c
PE
7195 (Fset_file_times, Finsert_file_contents, auto_save_error):
7196 Rename locals to avoid shadowing.
f14b7e14 7197
5716756e 7198 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7199 (Ftry_completion, Fall_completions): Rename or remove locals
7200 to avoid shadowing.
5716756e 7201
b4c3046a
PE
7202 * marker.c (bytepos_to_charpos): Remove; unused.
7203
b45db522
PE
7204 * lisp.h (verify_bytepos, count_markers): New decls,
7205 so that gcc does not warn that these functions aren't declared.
7206
85876d07
PE
7207 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7208 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7209 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7210 (copy_text): Remove unused local var.
85876d07 7211
03d78a21 7212 * filelock.c (within_one_second): Now static.
b3dd38ab 7213 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7214
5df8f01b
PE
7215 * buffer.c (fix_overlays_before): Mark locals as initialized.
7216 (fix_start_end_in_overlays): Likewise. This function should be
7217 simplified by using pointers-to-pointers, but that's a different
7218 matter.
b1d876f1 7219 (switch_to_buffer_1): Now static.
8f54f30a
PE
7220 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7221 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7222
a70072c9 7223 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7224 Fix pointer signedness issue.
edced198
PE
7225 (sys_subshell): Mark local as volatile if checking for lint,
7226 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7227 (MAXPATHLEN): Define only if needed.
a70072c9 7228
a0977c44
PE
7229 * process.c (serial_open, serial_configure): Move decls from here ...
7230 * systty.h: ... to here, so that they can be checked.
7231
a884fdcc
PE
7232 * fns.c (get_random, seed_random): Move extern decls from here ...
7233 * lisp.h: ... to here, so that they can be checked.
7234
604efe86 7235 * sysdep.c (reset_io): Now static.
b8950c94 7236 (wait_for_termination_signal): Remove; unused.
604efe86 7237
38fc62d9
PE
7238 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7239 (copy_keymap_item, append_key, push_text_char_description):
7240 Now static.
1004a21a 7241 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7242 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7243 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7244 (describe_map_tree):
7245 Rename locals to avoid shadowing.
38fc62d9 7246
2f2650da
PE
7247 * keyboard.c: Declare functions static if they are not used elsewhere.
7248 (echo_char, echo_dash, cmd_error, top_level_2):
7249 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7250 (read_char, kbd_buffer_get_event, make_lispy_position):
7251 (make_lispy_event, make_lispy_movement, apply_modifiers):
7252 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7253 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7254 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7255 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7256 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7257
a053e86c 7258 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7259 (mark_kboards): Move decl here ...
7260 * alloc.c (mark_kboards): ... from here.
a053e86c 7261
4752793e
PE
7262 * lisp.h (force_auto_save_soon): New decl.
7263
74f10ca7 7264 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7265 (DEFINE_DUMMY_FUNCTION): New macro.
7266 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7267 Use it.
c03cd23f
PE
7268 (main): Add casts to avoid warnings
7269 if GCC considers string literals to be constants.
74f10ca7 7270
022e70d4
PE
7271 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7272
59d6fe83
PE
7273 * dbusbind.c: Pointer signedness fixes.
7274 (xd_signature, xd_append_arg, xd_initialize):
7275 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7276 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7277 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7278 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7279
78320123
PE
7280 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7281 if GCC considers string literals to be constants.
49cebcca 7282 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7283
35ac2a97
SM
72842011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7285
fb103ca9
SM
7286 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7287 (print_preprocess, print_object): New macro to fix last change.
7288
35ac2a97
SM
7289 * print.c (print_preprocess): Don't forget font objects.
7290
62973b41
JB
72912011-03-16 Juanma Barranquero <lekktu@gmail.com>
7292
7293 * emacs.c (USAGE3): Doc fixes.
7294
0e48bb22
AS
72952011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7296
7297 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7298 structure.
7299
7684e57b
JB
73002011-03-14 Juanma Barranquero <lekktu@gmail.com>
7301
7302 * lisp.h (VWindow_system, Qfile_name_history):
7303 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7304 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7305 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7306
7307 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7308 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7309
7310 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7311 * w32console.c (detect_input_pending, read_input_pending)
7312 (encode_terminal_code):
7313 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7314 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7315 (w32_system_caret_y, Qfile_name_history):
7316 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7317 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7318 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7319 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7320 * w32proc.c (Qlocal, report_file_error):
7321 * w32term.c (Vwindow_system, updating_frame):
7322 * w32uniscribe.c (initialized, uniscribe_font_driver):
7323 Remove unneeded extern declarations.
7324
2aa46d6c
CY
73252011-03-14 Chong Yidong <cyd@stupidchicken.com>
7326
c96bbc66 7327 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7328
cffc6f3b
CY
73292011-03-13 Chong Yidong <cyd@stupidchicken.com>
7330
7331 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7332 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7333 These macros can no longer be used for assignment.
7334
44f230aa
SM
7335 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7336 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7337 (record_buffer_markers, fetch_buffer_markers): New functions for
7338 recording and fetching special buffer markers.
7339 (set_buffer_internal_1, set_buffer_temp): Use them.
7340
7341 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7342
7343 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7344
7345 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7346 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7347
7348 * xdisp.c (hscroll_window_tree):
7349 (reconsider_clip_changes): Use PT instead of BUF_PT.
7350
d251f04b
EZ
73512011-03-13 Eli Zaretskii <eliz@gnu.org>
7352
7353 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7354 $(EMACS_ROOT)/lib/intprops.h.
7355
f0c77cd1
PE
73562011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7357
3eca4629
PE
7358 Fix more problems found by GCC 4.5.2's static checks.
7359
7c86ee98
PE
7360 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7361 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7362 (xg_free_frame_widgets): Make it clear that a local variable is
7363 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7364 (gdk_window_get_screen): Make it clear that this macro is needed
7365 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7366 (int_gtk_range_get_value): New function, which avoids a diagnostic
7367 from gcc -Wbad-function-cast.
7368 (xg_set_toolkit_scroll_bar_thumb): Use it.
7369 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7370 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7371 (get_utf8_string, xg_get_file_with_chooser):
7372 Rename locals to avoid shadowing.
7373 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7374
41729b81
PE
7375 * xgselect.c (xg_select): Remove unused var.
7376
f0c77cd1
PE
7377 * image.c (four_corners_best): Mark locals as initialized.
7378 (gif_load): Initialize transparent_p to zero (Bug#8238).
7379 Mark another local as initialized.
ec6cf4c6 7380 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7381
ce0ad53d 7382 * image.c (clear_image_cache): Now static.
d5d5a617 7383 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7384 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7385 (x_edge_detection): Remove unnecessary cast that
7386 gcc -Wbad-function-cast diagnoses.
2037898d 7387 (gif_load): Fix pointer signedness.
6ae141d6
PE
7388 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7389 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7390
33383987 73912011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7392
d32df629
PE
7393 Improve quality of tests for time stamp overflow.
7394 For example, without this patch (encode-time 0 0 0 1 1
7395 1152921504606846976) returns the obviously-bogus value (-948597
7396 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7397 reports time overflow. See
7398 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7399 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7400 * editfns.c: Include limits.h and intprops.h.
7401 (TIME_T_MIN, TIME_T_MAX): New macros.
7402 (time_overflow): Move earlier, to before first use.
7403 (hi_time, lo_time): New functions, for an accurate test for
7404 out-of-range times.
7405 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7406 (Fget_internal_run_time): Don't assume time_t fits in int.
7407 (make_time): Use list2 instead of Fcons twice.
7408 (Fdecode_time): More accurate test for out-of-range times.
7409 (check_tm_member): New function.
7410 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7411 (lisp_time_argument): Don't rely on undefined left-shift and
7412 right-shift behavior when checking for time stamp overflow.
8be6f318 7413
fe31d94c
PE
7414 * editfns.c (time_overflow): New function, refactoring common code.
7415 (Fformat_time_string, Fdecode_time, Fencode_time):
7416 (Fcurrent_time_string): Use it.
7417
8be6f318
PE
7418 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7419 * dired.c (make_time): Move to ...
7420 * editfns.c (make_time): ... here.
7421 * systime.h: Note the move.
7422
09d9db2c 74232011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7424
126bc0dc
YM
7425 * fringe.c (update_window_fringes): Remove unused variables.
7426
c47cbdfd
YM
7427 * unexmacosx.c (copy_data_segment): Also copy __got section.
7428 (Bug#8223)
7429
7ac80be9
EZ
74302011-03-12 Eli Zaretskii <eliz@gnu.org>
7431
c96bbc66 7432 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7433 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7434 Constify `char *' arguments and their references according to
7435 prototypes in tparam.h.
7436
ecb0f94d 7437 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7438
7ac80be9
EZ
7439 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7440 Adapt all references accordingly.
7441
7442 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7443
ef1fd07e
TT
74442011-03-11 Tom Tromey <tromey@redhat.com>
7445
7446 * buffer.c (syms_of_buffer): Remove obsolete comment.
7447
7ef4b50c
EZ
74482011-03-11 Eli Zaretskii <eliz@gnu.org>
7449
7450 * termhooks.h (encode_terminal_code): Declare prototype.
7451
7452 * msdos.c (encode_terminal_code): Don't declare prototype.
7453
7454 * term.c (encode_terminal_code): Now external again, used by
7455 w32console.c and msdos.c.
7456
44f230aa
SM
7457 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7458 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7459
4b1ec863 74602011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7461
1714f52b 7462 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7463
4b1ec863
PE
7464 * fringe.c (update_window_fringes): Mark locals as initialized
7465 (Bug#8227).
7466 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7467
524c7aa6
PE
7468 * alloc.c (mark_fringe_data): Move decl from here ...
7469 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7470 to check its interface.
7471 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7472
a5c0af81 7473 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7474 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7475 (fontset_font): Mark local as initialized.
a9a06e0b 7476 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7477
b4716021
PE
7478 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7479
811e9bac 7480 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7481 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7482 (x_own_selection, Fx_disown_selection_internal): Rename locals
7483 to avoid shadowing.
7484 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7485
7e3ab302
PE
7486 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7487 so that the caller can use some name other than gcpro1.
7488 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7489 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7490 (Fx_backspace_delete_keys_p):
7491 Use them to avoid shadowing, and rename vars to avoid shadowing.
7492 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7493 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7494 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7495 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7496 Remove unused locals.
7e3ab302
PE
7497 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7498 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7499 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7500 macros.
f78faa98 7501
e2b13473
PE
7502 * xterm.h (x_mouse_leave): New decl.
7503
77f23912
PE
7504 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7505 Remove unused functions.
cdf4ba58
PE
7506 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7507 (x_calc_absolute_position): Now static.
7411c686 7508 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7509 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7510 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7511 unless they are used.
38d0b34a
PE
7512 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7513 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7514 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7515 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7516 (x_error_catcher, x_connection_closed, x_error_handler):
7517 (x_error_quitter, xembed_send_message, x_iconify_frame):
7518 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7519 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7520 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7521
44f230aa
SM
7522 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7523 Rename or move locals to avoid shadowing.
6b463e58 7524 (tty_defined_color, merge_face_heights): Now static.
5967d051 7525 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7526 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7527 does not deduce is never used uninitialized.
73719eba
PE
7528 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7529 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7530
426994c3 7531 * terminal.c (store_terminal_param): Now static.
5489860b 7532
032f1620 7533 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7534 (set_frame_menubar): Remove unused local.
d4323972 7535 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7536 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7537 since they might point to immutable storage.
281585b0
PE
7538 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7539 since it's unused otherwise.
032f1620 7540
367c19e5 7541 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7542 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7543 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7544 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7545 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7546 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7547 does not deduce are never used uninitialized.
70739cbe 7548
07b48fa9
PE
7549 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7550
8868a238 7551 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7552 * window.c (window_loop, size_window):
7553 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7554
7e5cf297 7555 * window.c (display_buffer): Now static.
d6550a9f
PE
7556 (size_window): Mark variables that gcc -Wuninitialized
7557 does not deduce are never used uninitialized.
a586633d
PE
7558 * window.h (check_all_windows): New decl, to forestall
7559 gcc -Wmissing-prototypes diagnostic.
5b555da1 7560 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7561
f6095868
PE
7562 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7563 shadowing.
7564 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7565 Include <limits.h>.
7566 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7567 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7568 (load_charset_map): Mark variables that gcc -Wuninitialized
7569 does not deduce are never used uninitialized.
53df7c11 7570 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7571
f38b440c
PE
7572 * coding.c (coding_set_source, coding_set_destination):
7573 Use "else { /* comment */ }" rather than "else /* comment */;"
7574 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7575 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7576 a block, when the outer 'i' will do.
7577 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7578 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7579 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7580 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7581 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7582 Rename locals to avoid shadowing.
7583 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7584 * coding.c (emacs_mule_char, encode_invocation_designation):
7585 Now static, since they're not used elsewhere.
413bb2db 7586 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7587 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7588 (decode_coding_emacs_mule): Mark variables that gcc
7589 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7590 (detect_coding_iso_2022): Initialize a local variable that might
7591 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7592 this initialization is needed. (Bug#8211)
5f58e762
PE
7593 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7594 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7595 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7596 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7597 Remove unused macros.
f38b440c 7598
232b38b9 7599 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7600 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7601 * character.c (string_count_byte8): Likewise.
232b38b9 7602
fb90da1b
PE
7603 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7604 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7605
fb93dbc2
PE
7606 * chartab.c (copy_sub_char_table): Now static, since it's not used
7607 elsewhere.
5c156ace
PE
7608 (sub_char_table_ref_and_range, char_table_ref_and_range):
7609 Rename locals to avoid shadowing.
bbcd0949 7610 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7611
7d3b3862 7612 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7613 (BIDI_BOB): Remove unused macro.
7d3b3862 7614
6be7d3da
PE
7615 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7616 deduce are never used uninitialized.
c2ed9c8b 7617 * term.c (encode_terminal_code): Likewise.
6be7d3da 7618
75f8807f 7619 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7620
50938595
PE
7621 * tparam.h: New file.
7622 * term.c, tparam.h: Include it.
7623 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7624 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7625 Move these decls to tparam.h, and make them agree with what
7626 is actually in tparam.c. The previous trick of using incompatible
7627 decls in different modules does not conform to the C standard.
7628 All callers of tparam changed to use tparam's actual API.
7629 * tparam.c (tparam1, tparam, tgoto):
7630 Use const pointers where appropriate.
7631
fbceeba2
PE
7632 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7633 * cm.h (struct cm): Likewise.
7634 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7635 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7636 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7637 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7638 (turn_on_face, init_tty): Likewise.
7639 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7640
7f3f1250
PE
7641 * term.c (term_mouse_position): Rename local to avoid shadowing.
7642
e6ca6543
PE
7643 * alloc.c (mark_ttys): Move decl from here ...
7644 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7645
c40f8d15
AS
76462011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7647
7648 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7649
cfe0661d
JB
76502011-03-09 Juanma Barranquero <lekktu@gmail.com>
7651
7652 * search.c (compile_pattern_1): Remove argument regp, unused since
7653 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7654 (compile_pattern): Don't pass it.
7655
0afb4571
J
76562011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7657
7658 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7659 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7660 for ! HAVE_GTK3.
7661 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7662
7663 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7664
7665 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7666 gdk_window_get_screen, gdk_window_get_geometry,
7667 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7668 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7669 (xg_get_pixbuf_from_pixmap): New function.
7670 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7671 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7672 Call xg_get_pixbuf_from_pixmap instead of
7673 gdk_pixbuf_get_from_drawable.
7674 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7675 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7676 (xg_check_special_colors): Use GtkStyleContext and its functions
7677 for HAVE_GTK3.
7678 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7679 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7680 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7681 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7682 Call gtk_widget_get_preferred_size.
0afb4571
J
7683 (xg_frame_resized): gdk_window_get_geometry only takes 5
7684 parameters.
44f230aa
SM
7685 (xg_win_to_widget, xg_event_is_for_menubar):
7686 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7687 (xg_set_widget_bg): New function.
7688 (delete_cb): New function.
895009e1 7689 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7690 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7691 (xg_set_background_color): Call xg_set_widget_bg.
7692 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7693 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7694 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7695 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7696 if ! HAVE_GTK3.
7697 (update_frame_tool_bar): Call gtk_widget_hide.
7698 (xg_initialize): Use GDK_KEY_g.
7699
7700 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7701 if ! HAVE_GTK3
7702 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7703
7704 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7705 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7706 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7707
1c2cc4ef
JB
77082011-03-08 Juanma Barranquero <lekktu@gmail.com>
7709
7710 * w32xfns.c (select_palette): Check success of RealizePalette against
7711 GDI_ERROR, not zero.
7712
33383987 7713See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7714
7715;; Local Variables:
7716;; coding: utf-8
aac0c6e3
MR
7717;; End:
7718
33383987 7719 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7720
7721 This file is part of GNU Emacs.
7722
7723 GNU Emacs is free software: you can redistribute it and/or modify
7724 it under the terms of the GNU General Public License as published by
7725 the Free Software Foundation, either version 3 of the License, or
7726 (at your option) any later version.
7727
7728 GNU Emacs is distributed in the hope that it will be useful,
7729 but WITHOUT ANY WARRANTY; without even the implied warranty of
7730 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7731 GNU General Public License for more details.
7732
7733 You should have received a copy of the GNU General Public License
7734 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.