* files.el (auto-mode-alist): Use js-mode for .json (Bug#8529).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e6c3da20
EZ
12011-04-23 Eli Zaretskii <eliz@gnu.org>
2
3 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4 * doprnt.c: Include limits.h.
5 (SIZE_MAX): New macro.
6 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
7 local variables are now size_t instead of int or unsigned.
8 Improve overflow protection. Support `l' modifier for integer
9 conversions. Support %l conversion. Don't assume an EMACS_INT
10 argument for integer conversions and for %c.
11
12 * lisp.h (doprnt): Restore prototype.
13
14 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
15 $(SRC)/character.h.
16
17 * Makefile.in (base_obj): Add back doprnt.o.
18
19 * deps.mk (doprnt.o): Add back prerequisites.
20 (callint.o): Depend on character.h.
21
22 * eval.c (internal_lisp_condition_case): Include the handler
23 representation in the error message.
24 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
25 when breaking from the loop.
26
27 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
28
29 * callint.c (Fcall_interactively): When displaying error message
30 about invalid control letter, pass the character's codepoint, not
31 a pointer to its multibyte form. Improve display of the character
32 in octal and display also its hex code.
33
34 * character.c (char_string): Use %x to display the (unsigned)
35 codepoint of an invalid character, to avoid displaying a bogus
36 negative value.
37
38 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
39 `error', not SYMBOL_NAME itself.
40
41 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
42 character arguments to `error'.
43
44 * charset.c (check_iso_charset_parameter): Fix incorrect argument
45 to `error' in error message about FINAL_CHAR argument. Make sure
46 FINAL_CHAR is a character, and use %c when it is passed as
47 argument to `error'.
48
4ffd0d6b 492011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
50
51 * s/ms-w32.h (localtime): Redirect to sys_localtime.
52
53 * w32.c: Include <time.h>.
54 (sys_localtime): New function.
55
4ffd0d6b 562011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
57
58 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
59
4ffd0d6b 60 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 61
4ffd0d6b 622011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 63
4ffd0d6b
GM
64 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
65 zombies (Bug#8467).
aac0c6e3 66
04c56954
EZ
672011-04-19 Eli Zaretskii <eliz@gnu.org>
68
69 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
70 gl_state.e_property when gl_state.object is Qt.
71
72 * insdel.c (make_gap_larger): Remove limitation of buffer size
73 to <= INT_MAX.
74
16a43933
CY
752011-04-18 Chong Yidong <cyd@stupidchicken.com>
76
77 * xdisp.c (lookup_glyphless_char_display)
78 (produce_glyphless_glyph): Handle cons cell entry in
79 glyphless-char-display.
80 (Vglyphless_char_display): Document it.
81
82 * term.c (produce_glyphless_glyph): Handle cons cell entry in
83 glyphless-char-display.
84
4581706e
CY
852011-04-17 Chong Yidong <cyd@stupidchicken.com>
86
87 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
88
89 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
90
91 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
92 definition for no-X builds.
93
4887c6e2 942011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 95
fd35b6f9
PE
96 Static checks with GCC 4.6.0 and non-default toolkits.
97
5c1ccb01
PE
98 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
99
006c5daa
PE
100 * process.c (keyboard_bit_set): Define only if SIGIO.
101 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
102 (send_process): Repair possible setjmp clobbering.
103
efc736d3
PE
104 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
105
4e2fe2e6
PE
106 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
107
f97334a2
PE
108 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
109
4e75f29d
PE
110 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
111 Define only if needed.
112
90efadd1
PE
113 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
114 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 115 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 116
3c647824
PE
117 * dispextern.h (struct redisplay_interface): Rename param
118 to avoid shadowing.
e264f262 119 * termhooks.h (struct terminal): Likewise.
761383f4 120 * xterm.c (xembed_send_message): Likewise.
3c647824 121
b58c5c4a
PE
122 * insdel.c (make_gap_smaller): Define only if
123 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
124
cad59032
PE
125 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
126 it.
127
c339dc2e
PE
128 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
129 so that we aren't warned about unused symbols.
130
91a3e27b
PE
131 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
132
399c71d3 133 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 134
8ffc96f5
PE
135 * xfns.c (x_real_positions): Mark locals as initialized.
136
eef9bc79
PE
137 * xmenu.c (xmenu_show): Don't use uninitialized vars.
138
098db9dd
PE
139 * xterm.c: Fix problems found by static analysis with other toolkits.
140 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
141 (x_dispatch_event): Declare static if USE_GTK, and
142 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 143 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 144 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
098db9dd
PE
145 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
146 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
147
eb18f6cc
PE
148 * xmenu.c (menu_help_callback): Pointer type fixes.
149 Use const pointers when pointing at readonly data. Avoid pointer
150 signedness clashes.
151 (FALSE): Remove unused macro.
152 (update_frame_menubar): Remove unused decl.
153
1fe72bf8
PE
154 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
155
60d9e1db
PE
156 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
157 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
158 (single_menu_item): Rename local to avoid shadowing.
159
39261c26
PE
160 * keyboard.c (make_lispy_event): Remove unused local var.
161
018c5e19
PE
162 * frame.c, frame.h (x_get_resource_string): Bring this back, but
163 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
164
63d2b86e
PE
165 * bitmaps: Change bitmaps from unsigned char back to the X11
166 compatible char. Avoid the old compiler warnings about
167 out-of-range initializers by using, for example, '\xab' rather
168 than 0xab.
169
aefd87e1
PE
170 * xgselect.c (xgselect_initialize): Check vs interface
171 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
172
bf501fb9
PE
173 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
174
e9829fdf
PE
175 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
176 to read-only memory.
177
1086c095
PE
178 * fns.c (vector): Remove; this old hack is no longer needed.
179
2baccd04 180 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 181 Remove unused var.
dde42981 182 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 183
72391843 184 * xrdb.c (x_load_resources): Omit unused local.
3565b346 185
436c16df 186 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 187 (x_window): Rename locals to avoid shadowing.
dc5ddd85 188 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 189
92bb796d 190 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 191 (x_term_init): Remove local to avoid shadowing.
92bb796d 192
764430a3 193 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
194
195 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
196 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
197
d1dfb56c
EZ
1982011-04-16 Eli Zaretskii <eliz@gnu.org>
199
c4354cb4
EZ
200 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
201
d1dfb56c
EZ
202 Fix regex.c, syntax.c and friends for buffers > 2GB.
203 * syntax.h (struct gl_state_s): Declare character position members
204 EMACS_INT.
205
206 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
207
208 * textprop.c (verify_interval_modification, interval_of): Declare
209 arguments EMACS_INT.
210
211 * intervals.c (adjust_intervals_for_insertion): Declare arguments
212 EMACS_INT.
213
214 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
215
216 * indent.c (Fvertical_motion): Local variable it_start is now
217 EMACS_INT.
218
219 * regex.c (re_match, re_match_2, re_match_2_internal)
220 (bcmp_translate, regcomp, regexec, print_double_string)
221 (group_in_compile_stack, re_search, re_search_2, regex_compile)
222 (re_compile_pattern, re_exec): Declare arguments and local
223 variables `size_t' and `ssize_t' and return values `regoff_t', as
224 appropriate.
225 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
226 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
227 <compile_stack_type>: `size' and `avail' are now `size_t'.
228
229 * regex.h <regoff_t>: Use ssize_t, not int.
230 (re_search, re_search_2, re_match, re_match_2): Arguments that
231 specify buffer/string position and length are now ssize_t and
232 size_t. Return type is regoff_t.
233
613052cd
BK
2342011-04-16 Ben Key <bkey76@gmail.com>
235
236 * nsfont.m: Fixed bugs in ns_get_family and
237 ns_descriptor_to_entity that were caused by using free to
238 deallocate memory blocks that were allocated by xmalloc (via
239 xstrdup). This caused Emacs to crash when compiled with
240 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
241 --enable-checking=xmallocoverrun). xfree is now used to
242 deallocate these memory blocks.
243
4170f62f 2442011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 245
71b41406
PE
246 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
247
9587a89d
PE
248 emacs_write: Accept and return EMACS_INT for sizes.
249 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
250 et seq.
251 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
252 Accept and return EMACS_INT.
253 (emacs_gnutls_write): Return the number of bytes written on
254 partial writes.
255 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
256 (emacs_read, emacs_write): Remove check for negative size, as the
257 Emacs source code has been audited now.
9587a89d
PE
258 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
259 (emacs_read, emacs_write): Use it.
273a5f82
PE
260 * process.c (send_process): Adjust to the new signatures of
261 emacs_write and emacs_gnutls_write. Do not attempt to store
262 a byte offset into an 'int'; it might overflow.
9587a89d 263 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 264
3e047f51
PE
265 * sound.c: Don't assume sizes fit in 'int'.
266 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 267 Return EMACS_INT, not int.
3e047f51 268 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
269 Accept EMACS_INT, not int.
270 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
271 record read return values.
272
cc39a9db
BK
2732011-04-15 Ben Key <bkey76@gmail.com>
274
c9d0ec6d
JB
275 * keyboard.c (Qundefined): Don't declare static since it is used
276 in nsfns.m.
277 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
278 static since they are used in nsfont.m.
cc39a9db 279
6c60eb9f
SM
2802011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
281
282 * process.c (Qprocessp): Don't declare static.
283 * lisp.h (Qprocessp): Declare again.
284
7990b61a
JB
2852011-04-15 Juanma Barranquero <lekktu@gmail.com>
286
287 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
288
5d4cb038
PE
2892011-04-14 Paul Eggert <eggert@cs.ucla.edu>
290
8bd7b830 291 Improve C-level modularity by making more things 'static'.
cd64ea1d 292
e3b27b31
PE
293 Don't publish debugger-only interfaces to other modules.
294 * lisp.h (safe_debug_print, debug_output_compilation_hack):
295 (verify_bytepos, count_markers): Move decls to the only modules
296 that need them.
297 * region-cache.h (pp_cache): Likewise.
298 * window.h (check_all_windows): Likewise.
299 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
300
5d4cb038
PE
301 * sysdep.c (croak): Now static, if
302 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
303 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
304
305 * alloc.c (refill_memory_reserve): Now static if
306 !defined REL_ALLOC || defined SYSTEM_MALLOC.
307 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 308
e87b6180
PE
309 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
310 Define only if USE_LUCID.
311
ac64929e
PE
312 * xrdb.c (x_customization_string, x_rm_string): Now static.
313
6f37259d
PE
314 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
315 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
316
1683e3ab
PE
317 * xdisp.c (draw_row_with_mouse_face): Now static.
318 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
319
de9c2632
PE
320 * window.h (check_all_windows): Mark externally visible.
321
2b96acb7
PE
322 * window.c (window_deletion_count): Now static.
323
324 * undo.c: Make symbols static if they're not exported.
325 (last_undo_buffer, last_boundary_position, pending_boundary):
326 Now static.
327
50436f33
PE
328 * textprop.c (interval_insert_behind_hooks): Now static.
329 (interval_insert_in_front_hooks): Likewise.
330
64520e5c
PE
331 * term.c: Make symbols static if they're not exported.
332 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
333 (max_frame_lines, tty_set_terminal_modes):
334 (tty_reset_terminal_modes, tty_turn_off_highlight):
335 (get_tty_terminal): Now static.
336 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
337 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 338 HAVE_WINDOW_SYSTEM.
64520e5c
PE
339 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
340 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
341
1fa53021
PE
342 * sysdep.c: Make symbols static if they're not exported.
343 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
344 Now static.
345 (sigprocmask_set, full_mask): Remove; unused.
346 (wait_debugging): Mark as visible.
347 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
348 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
349
d4b43b22
PE
350 * syntax.c (syntax_temp): Define only if !__GNUC__.
351
b7c513d0
PE
352 * sound.c (current_sound_device, current_sound): Now static.
353
989b29ad
PE
354 * search.c (searchbufs, searchbuf_head): Now static.
355
13a55a78
PE
356 * scroll.c (scroll_cost): Remove; unused.
357 * dispextern.h (scroll_cost): Remove decl.
358
de68a1fc
PE
359 * region-cache.h (pp_cache): Mark as externally visible.
360
40ccffa6
PE
361 * process.c: Make symbols static if they're not exported.
362 (process_tick, update_tick, create_process, chan_process):
363 (Vprocess_alist, proc_buffered_char, datagram_access):
364 (fd_callback_data, send_process_frame, process_sent_to): Now static.
365 (deactivate_process): Mark defn as static, as well as decl.
366 * lisp.h (create_process): Remove decl.
367 * process.h (chan_process, Vprocess_alist): Remove decls.
368
ad64fc97
PE
369 * print.c: Make symbols static if they're not exported.
370 (print_depth, new_backquote_output, being_printed, print_buffer):
371 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
372 (print_interval, print_number_index, initial_stderr_stream):
373 Now static.
374 * lisp.h (Fprinc): Remove decl.
375 (debug_output_compilation_hack): Mark as externally visible.
376
adddb265
PE
377 * sysdep.c (croak): Move decl from here to syssignal.h.
378 * syssignal.h (croak): Put it here, so the API can be checked when
379 'croak' is called from dissociate_if_controlling_tty.
380
1717ede2
PE
381 * minibuf.c: Make symbols static if they're not exported.
382 (minibuf_save_list, choose_minibuf_frame): Now static.
383 * lisp.h (choose_minibuf_frame): Remove decl.
384
fa5fb2bc
PE
385 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
386
1e3890d1
PE
387 * lread.c: Make symbols static if they're not exported.
388 (read_objects, initial_obarray, oblookup_last_bucket_number):
389 Now static.
390 (make_symbol): Remove; unused.
391 * lisp.h (initial_obarray, make_symbol): Remove decls.
392
8a1414fa
PE
393 * keyboard.c: Make symbols static if they're not exported.
394 (single_kboard, recent_keys_index, total_keys, recent_keys):
395 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
396 (this_single_command_key_start, echoing, last_auto_save):
397 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
398 (command_loop, echo_now, keyboard_init_hook, help_char_p):
399 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
400 (Vlispy_mouse_stem, double_click_count):
401 Now static.
402 (force_auto_save_soon): Define only if SIGDANGER.
403 (ignore_mouse_drag_p): Now static if
404 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
405 (print_help): Remove; unused.
406 (stop_character, last_timer_event): Mark as externally visible.
407 * keyboard.h (ignore_mouse_drag_p): Declare only if
408 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
409 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
410 * lisp.h (echoing): Remove decl.
411 (force_auto_save_soon): Declare only if SIGDANGER.
412 * xdisp.c (redisplay_window): Simplify code, to make it more
413 obvious that ignore_mouse_drag_p is not accessed if !defined
414 USE_GTK && !defined HAVE_NS.
415
93ea6e8f
PE
416 * intervals.c: Make symbols static if they're not exported.
417 (merge_properties_sticky, merge_interval_right, delete_interval):
418 Now static.
419 * intervals.h (merge_interval_right, delete_interval): Remove decls.
420
77382fcc
PE
421 * insdel.c: Make symbols static if they're not exported.
422 However, leave prepare_to_modify_buffer alone. It's never
423 called from outside this function, but that appears to be a bug.
424 (combine_after_change_list, combine_after_change_buffer):
4889fc82 425 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
426 (adjust_after_replace_noundo): Remove; unused.
427 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 428 (signal_before_change): Remove decls.
77382fcc 429
9306c32e
PE
430 * indent.c (val_compute_motion, val_vmotion): Now static.
431
cd44d2eb
PE
432 * image.c: Make symbols static if they're not exported.
433 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
434 if USE_GTK.
435 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
436 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
437
ad9a7a06
PE
438 * fringe.c (standard_bitmaps): Now static.
439 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
440
81626931
PE
441 * frame.c: Make symbols static if they're not exported.
442 (x_report_frame_params, make_terminal_frame): Now static.
443 (get_frame_param): Now static, unless HAVE_NS.
444 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
445 (x_get_resource_string): Remove; not used.
446 * frame.h (make_terminal_frame, x_report_frame_params):
447 (x_get_resource_string); Remove decls.
448 (x_fullscreen_adjust): Declare only if WINDOWSNT.
449 * lisp.h (get_frame_param): Declare only if HAVE_NS.
450
239f9db9
PE
451 * font.c, fontset.c: Make symbols static if they're not exported.
452 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
453 (FACE_SUITABLE_FOR_CHAR_P): Use it.
454 * font.c (font_close_object): Now static.
455 * font.h (font_close_object): Remove.
456 * fontset.c (FONTSET_OBJLIST): Remove.
457 (free_realized_fontset) #if-0 the body, which does nothing.
458 (face_suitable_for_char_p): #if-0, as it's never called.
459 * fontset.h (face_suitable_for_char_p): Remove decl.
460 * xfaces.c (face_at_string_position): Use
461 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
462 since 0 is always ASCII.
463
dfcf3579
PE
464 * fns.c (weak_hash_tables): Now static.
465
5045092b
PE
466 * fileio.c: Make symbols static if they're not exported.
467 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
468 (Vwrite_region_annotation_buffers): Now static.
469
57a96f5c
PE
470 * eval.c: Make symbols static if they're not exported.
471 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
472 * lisp.h (backtrace_list): Remove decl.
473
35f08c38
PE
474 * emacs.c: Make symbols static if they're not exported.
475 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
476 (fatal_error_code, fatal_error_signal_hook, standard_args):
477 Now static.
478 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
479 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
480 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
481 * lisp.h (fatal_error_signal_hook): Remove decl.
482 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
483
f44bd759
PE
484 * editfns.c: Move a (normally-unused) function to its only use.
485 * editfns.c, lisp.h (get_operating_system_release): Remove.
486 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
487 worth the hassle of breaking this out.
488
b532497d
PE
489 * xterm.c: Make symbols static if they're not exported.
490 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
491 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
492 (x_destroy_window, x_delete_display):
493 Now static.
494 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
495 (x_mouse_leave): Remove; unused.
496 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
497 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
498 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
499 Remove decls.
500 (x_mouse_leave): Declare only if WINDOWSNT.
501 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
502 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
503 USE_X_TOOLKIT.
504
1675728f
PE
505 * ftxfont.c: Make symbols static if they're not exported.
506 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
507 HAVE_FREETYPE.
508 * font.h (ftxfont_driver): Likewise.
509
e4cebfca
PE
510 * xfns.c: Make symbols static if they're not exported.
511 (x_last_font_name, x_display_info_for_name):
512 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
513 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
514 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
515 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
516 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
517 (last_show_tip_args): Now static.
518 (xic_defaut_fontset, xic_create_fontsetname): Define only if
519 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
520 (x_screen_planes): Remove; unused.
521 * dispextern.h (x_screen_planes): Remove decl.
522
5bf46f05
PE
523 * dispnew.c: Make symbols static if they're not exported.
524 * dispextern.h (redraw_garbaged_frames, scrolling):
525 (increment_row_positions): Remove.
526 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
527 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
528 Now static.
529 (redraw_garbaged_frames): Remove; unused.
530
435f4c28
PE
531 * xfaces.c: Make symbols static if they're not exported.
532 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
533 Remove decls.
534 * xterm.h (defined_color): Remove decls.
535 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
536 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
537 (menu_face_changed_default, defined_color, free_realized_face):
538 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
539 (ascii_face_of_lisp_face): Remove; unused.
540
8524aef3
PE
541 * xdisp.c: Make symbols static if they're not exported.
542 * dispextern.h (scratch_glyph_row, window_box_edges):
543 (glyph_to_pixel_coords, set_cursor_from_row):
544 (get_next_display_element, set_iterator_to_next):
545 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
546 (show_mouse_face): Remove decls
547 * frame.h (message_buf_print): Likewise.
548 * lisp.h (pop_message, set_message, check_point_in_composition):
549 Likewise.
550 * xterm.h (set_vertical_scroll_bar): Likewise.
551 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
552 (message_buf_print, scratch_glyph_row, displayed_buffer):
553 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
554 (get_next_display_element, show_mouse_face, window_box_edges):
555 (frame_to_window_pixel_xy, check_point_in_composition):
556 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
557 (glyph_to_pixel_coords): Remove; unused.
558
16390cd2
PE
559 * dired.c (file_name_completion): Now static.
560
561 * dbusbind.c (xd_in_read_queued_messages): Now static.
562
a25f4dfa
PE
563 * lisp.h (circular_list_error, FOREACH): Remove; unused.
564 * data.c (circular_list_error): Remove.
565
14a9c8df
PE
566 * commands.h (last_point_position, last_point_position_buffer):
567 (last_point_position_window): Remove decls.
568 * keyboard.c: Make these variables static.
569
74ab6df5
PE
570 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
571 decls.
572 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
573 (iso_code_class, detect_coding, code_convert_region): Now static.
574 (encode_coding_gap): Remove; unused.
575
38dfbee1
PE
576 * chartab.c (chartab_chars, chartab_bits): Now static.
577
a2cb4e63
PE
578 * charset.h (charset_iso_8859_1): Remove decl.
579 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
580 Now static.
581
127198fd
PE
582 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
583 * ccl.c (Vccl_program_table): Now static.
584 (check_ccl_update): Remove; unused.
585
d85b608f
PE
586 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
587 * category.h: ... from here.
588 * category.c (check_category_table, set_category_set): Now static.
589
31cd66f3
PE
590 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
591 * lisp.h: Remove these decls.
592
c358e587
PE
593 * buffer.c (buffer_count): Remove unused var.
594
e78aecca
PE
595 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
596 so that it's not optimized away.
597 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
598 * dispextern.h (bidi_dump_cached_states): Remove, since it's
599 exported only to the debugger.
600
e192d7d3
PE
601 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
602 * atimer.h (run_all_atimers): Removed; not exported.
603
92470028
PE
604 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
605 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
606 was inaccessible from Lisp.
607 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
608 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
609
244ed907
PE
610 alloc.c: Import and export fewer symbols, and remove unused items.
611 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
612 is defined.
613 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
614 it's not optimized away by whole-program optimization.
615 (message_enable_multibyte, free_misc): Remove.
616 (catchlist, handlerlist, mark_backtrace):
617 Declare only if BYTE_MARK_STACK.
618 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
619 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
620 (message_enable_multibyte): Remove decl.
621 (free_misc, interval_free_list, float_block, float_block_index):
622 (n_float_blocks, float_free_list, cons_block, cons_block_index):
623 (cons_free_list, last_marked_index):
624 Now static.
625 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
626 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
627 (mark_backtrace): Define only if BYTE_MARK_STACK.
628 * xdisp.c (message_enable_multibyte): Now static.
629
61c2b50e 630 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
631 This makes it easier for human readers (and static analyzers)
632 to see whether these variables are used from other modules.
633 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
634 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
635 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
636 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
637 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
638 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
639 * xmenu.c, xselect.c:
640 Declare Q* vars static if they are not used in other modules.
641 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
642 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
643 Remove decls of unexported vars.
644 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
645
95c82688
PE
646 * lisp.h (DEFINE_FUNC): Make sname 'static'.
647
16a97296
PE
648 Make Emacs functions such as Fatom 'static' by default.
649 This makes it easier for human readers (and static analyzers)
650 to see whether these functions can be called from other modules.
651 DEFUN now defines a static function. To make the function external
652 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
653 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
654 (Finit_image_library):
16a97296
PE
655 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
656 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
657 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
658 Remove decls, since these functions are now static.
659 (Funintern, Fget_internal_run_time): New decls, since these functions
660 were already external.
95c82688 661
16a97296
PE
662 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
663 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
664 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
665 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
666 * keyboard.c, keymap.c, lread.c:
667 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
668 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
669 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
670 Mark functions with DEFUE instead of DEFUN,
671 if they are used in other modules.
672 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
673 decls for now-static functions.
674 * buffer.h (Fdelete_overlay): Remove decl.
675 * callproc.c (Fgetenv_internal): Mark as internal.
676 * composite.c (Fremove_list_of_text_properties): Remove decl.
677 (Fcomposition_get_gstring): New forward static decl.
678 * composite.h (Fcomposite_get_gstring): Remove decl.
679 * dired.c (Ffile_attributes): New forward static decl.
680 * doc.c (Fdocumntation_property): New forward static decl.
681 * eval.c (Ffetch_bytecode): New forward static decl.
682 (Funintern): Remove extern decl; now in .h file where it belongs.
683 * fileio.c (Fmake_symbolic_link): New forward static decl.
684 * image.c (Finit_image_library): New forward static decl.
685 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
686 * intervals.h (Fprevious_property_change):
687 (Fremove_list_of_text_properties): Remove decls.
688 * keyboard.c (Fthis_command_keys): Remove decl.
689 (Fcommand_execute): New forward static decl.
690 * keymap.c (Flookup_key): New forward static decl.
691 (Fcopy_keymap): Now static.
692 * keymap.h (Flookup_key): Remove decl.
693 * process.c (Fget_process): New forward static decl.
694 (Fprocess_datagram_address): Mark as internal.
695 * syntax.c (Fsyntax_table_p): New forward static decl.
696 (skip_chars): Remove duplicate decl.
697 * textprop.c (Fprevious_property_change): New forward static decl.
698 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
699 Now internal.
700 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
701 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
702
785bbd42
PE
703 * editfns.c (Fformat): Remove unreachable code.
704
8b913b57
AS
7052011-04-14 Andreas Schwab <schwab@linux-m68k.org>
706
707 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
708 change. (Bug#8496)
709
a6744a35
EZ
7102011-04-13 Eli Zaretskii <eliz@gnu.org>
711
712 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
713 when at ZV. (Bug#8487)
714
e7974947
AS
7152011-04-12 Andreas Schwab <schwab@linux-m68k.org>
716
baad03f0
AS
717 * charset.c (Fclear_charset_maps): Use xfree instead of free.
718 (Bug#8437)
719 * keyboard.c (parse_tool_bar_item): Likewise.
720 * sound.c (sound_cleanup, alsa_close): Likewise.
721 * termcap.c (tgetent): Likewise.
722 * xfns.c (x_default_font_parameter): Likewise.
723 * xsettings.c (read_and_apply_settings): Likewise.
724
e7974947
AS
725 * alloc.c (overrun_check_malloc, overrun_check_realloc)
726 (overrun_check_free): Protoize.
727
28272684
PE
7282011-04-12 Paul Eggert <eggert@cs.ucla.edu>
729
730 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
731 since callers should never pass a negative size.
732 Change the signature to match that of plain 'read' and 'write'; see
733 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
734 * lisp.h: Update prototypes of emacs_write and emacs_read.
735
11997c76
EZ
7362011-04-11 Eli Zaretskii <eliz@gnu.org>
737
738 * xdisp.c (redisplay_window): Don't try to determine the character
739 position of the scroll margin if the window start point w->startp
e896f03c 740 is outside the buffer's accessible region. (Bug#8468)
11997c76 741
8a2cbd72
EZ
7422011-04-10 Eli Zaretskii <eliz@gnu.org>
743
744 Fix write-region and its subroutines for buffers > 2GB.
745 * fileio.c (a_write, e_write): Modify declaration of arguments and
746 local variables to support buffers larger than 2GB.
747 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
748
749 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
750 argument, local variables, and return value.
751
752 * lisp.h: Update prototypes of emacs_write and emacs_read.
753
754 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
755
4073e537 7562011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 757
1ebfdcb6
PE
758 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
759
b2ded58d
PE
760 Fix more problems found by GCC 4.6.0's static checks.
761
7d66342c
PE
762 * xdisp.c (vmessage): Use a better test for character truncation.
763
bbf47d44
PE
764 * charset.c (load_charset_map): <, not <=, for optimization,
765 and to avoid potential problems with integer overflow.
9248994d 766 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 767 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 768 * editfns.c (Fformat): Likewise.
1e69125e 769 * syntax.c (skip_chars): Likewise.
3befa583 770
e3019616
PE
771 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
772 This also lets GCC 4.6.0 generate slightly better loop code.
773
becfa255
PE
774 * callint.c (Fcall_interactively): <, not <=, for optimization.
775 (Fcall_interactively): Count the number of arguments produced,
776 not the number of arguments given. This is simpler and lets GCC
777 4.6.0 generate slightly better code.
778
dae0cd48
PE
779 * ftfont.c: Distingish more carefully between FcChar8 and char.
780 The previous code passed unsigned char * to a functions like
781 strlen and xstrcasecmp that expect char *, which does not
782 conform to the C standard.
783 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
784 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
785 char * when the C standard requires it.
786
76032d70
PE
787 * keyboard.c (read_char): Remove unused var.
788
eb3f1cc8
PE
789 * eval.c: Port to Windows vsnprintf (Bug#8435).
790 Include <limits.h>.
791 (SIZE_MAX): Define if the headers do not.
792 (verror): Do not give up if vsnprintf returns a negative count.
793 Instead, grow the buffer. This ports to Windows vsnprintf, which
794 does not conform to C99. Problem reported by Eli Zaretskii.
795 Also, simplify the allocation scheme, by avoiding the need for
796 calling realloc, and removing the ALLOCATED variable.
797
70476b54
PE
798 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
799
12020a9e
PE
800 Remove invocations of doprnt, as Emacs now uses vsnprintf.
801 But keep the doprint source code for now, as we might revamp it
802 and use it again (Bug#8435).
ea6c7ae6
PE
803 * lisp.h (doprnt): Remove.
804 * Makefile.in (base_obj): Remove doprnt.o.
805 * deps.mk (doprnt.o): Remove.
806
5fdb398c
PE
807 error: Print 32- and 64-bit integers portably (Bug#8435).
808 Without this change, on typical 64-bit hosts error ("...%d...", N)
809 was used to print both 32- and 64-bit integers N, which relied on
810 undefined behavior.
811 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
812 New macro.
813 * lisp.h (error, verror): Mark as printf-like functions.
814 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
815 Report overflow in size calculations when allocating printf buffer.
816 Do not truncate output string at its first null byte.
817 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
818 Truncate the output at a character boundary, since vsnprintf does not
819 do that.
820 * charset.c (check_iso_charset_parameter): Convert internal
821 character to string before calling 'error', since %c now has the
822 printf meaning.
823 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
824 overflow when computing char to be passed to 'error'. Do not
825 pass Lisp_Object to 'error'; pass the integer instead.
826 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
827 formatted with plain %d.
828
b189fa66
PE
829 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
830
bff87ef0
PE
831 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
832
7e2cac20
PE
833 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
834
ce4d90b5
PE
835 * xterm.c (x_catch_errors): Remove duplicate declaration.
836
266c9547
PE
837 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
838
79c49ad2
PE
839 * xdisp.c, lisp.h (message_nolog): Remove; unused.
840
368f4090
JM
8412011-04-10 Jim Meyering <meyering@redhat.com>
842
843 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
844 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
845 return ssize_t not "int", and use size_t as the buffer length.
846 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
847 * gnutls.h: Update declarations.
848 * process.c (read_process_output): Use ssize_t, to match.
849 (send_process): Likewise.
850
a32d4040
CY
8512011-04-09 Chong Yidong <cyd@stupidchicken.com>
852
853 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
854
8546720e 8552011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 856
8546720e
GM
857 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
858 unsigned char, to match FcChar8 type definition.
aac0c6e3 859
8546720e
GM
860 * xterm.c (handle_one_xevent):
861 * xmenu.c (create_and_show_popup_menu):
862 * xselect.c (x_decline_selection_request)
863 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 864
0a2f5c1a 8652011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
866
867 Fix some uses of `int' instead of EMACS_INT.
868 * search.c (string_match_1, fast_string_match)
869 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
870 (scan_buffer, find_next_newline_no_quit)
871 (find_before_next_newline, search_command, Freplace_match)
872 (Fmatch_data): Make some `int' variables be EMACS_INT.
873
874 * xdisp.c (display_count_lines): 3rd argument and return value now
875 EMACS_INT. All callers changed.
876 (pint2hrstr): Last argument is now EMACS_INT.
877
878 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
879 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
880 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
881 (decode_coding_utf_16, decode_coding_emacs_mule)
882 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
883 (decode_coding_ccl, decode_coding_charset)
884 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
885 (decode_coding_iso_2022, decode_coding_emacs_mule)
886 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
887 <char_offset, last_offset>: Declare EMACS_INT.
888 (encode_coding_utf_8, encode_coding_utf_16)
889 (encode_coding_emacs_mule, encode_invocation_designation)
890 (encode_designation_at_bol, encode_coding_iso_2022)
891 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
892 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
893 Declare EMACS_INT.
894 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
895 (encode_invocation_designation): Last argument P_NCHARS is now
896 EMACS_INT.
897 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
898 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
899
900 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
901 All users changed.
902
903 * ccl.c (Fccl_execute_on_string): Declare some variables
904 EMACS_INT.
905
8546720e 9062011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
907
908 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
909
4e19a977
CS
9102011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
911
912 * process.c (Fformat_network_address): Doc fix.
913
87302331
R
9142011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
915
916 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
917
cbb59342
CY
9182011-04-08 Chong Yidong <cyd@stupidchicken.com>
919
920 * keyboard.c (read_char): Call Lisp function help-form-show,
921 instead of using internal_with_output_to_temp_buffer.
922 (Qhelp_form_show): New var.
e0d38eeb 923 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
924
925 * print.c (internal_with_output_to_temp_buffer): Function deleted.
926
927 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
928
e67a13ab
CY
9292011-04-06 Chong Yidong <cyd@stupidchicken.com>
930
931 * process.c (Flist_processes): Removed to Lisp.
932 (list_processes_1): Deleted.
933
973f782d
EZ
9342011-04-06 Eli Zaretskii <eliz@gnu.org>
935
7c106b1e
EZ
936 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
937
973f782d
EZ
938 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
939
41cf7d1a 9402011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 941
ca23cc88
PE
942 Fix more problems found by GCC 4.6.0's static checks.
943
f390e2d5
PE
944 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
945
42eea0d0
PE
946 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
947
b69769da 948 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 949
f9541e84
PE
950 * xdisp.c (vmessage): Mark as a printf-like function.
951
13841b55
PE
952 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
953
c136c10f
PE
954 * sound.c (sound_warning): Don't crash if arg contains a printf format.
955
5e2d4a30
PE
956 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
957 printf-like functions.
958 (tiff_load): Add casts to remove these marks before passing them
959 to system-supplied API.
960
583f48b9
PE
961 * eval.c (Fsignal): Remove excess argument to 'fatal'.
962
b25d760e
PE
963 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
964 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
965 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
966 directly, rather than having caller test rule sign. This avoids
967 some unnecessary tests.
968 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
969 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
970 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 971
bc7b6697 972 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 973 (xfont_open): Avoid unnecessary tests.
bc7b6697 974
27ccc379
PE
975 * composite.c (composition_gstring_put_cache): Use unsigned integer.
976
dcd5c89a
PE
977 * composite.h, composite.c (composition_gstring_put_cache):
978 Use EMACS_INT, not int, for length.
979
b13a45c6
PE
980 * composite.h (COMPOSITION_DECODE_REFS): New macro,
981 breaking out part of COMPOSITION_DECODE_RULE.
982 (COMPOSITION_DECODE_RULE): Use it.
983 * composite.c (get_composition_id): Remove unused local vars,
984 by using the new macro.
985
1e792e4d
PE
986 * textprop.c (set_text_properties_1): Change while to do-while,
987 since the condition is always true at first.
988
dc6c6455 989 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
990 (interval_deletion_adjustment): Return unsigned value.
991 All uses changed.
dc6c6455 992
aba7731a
PE
993 * process.c (list_processes_1, create_pty, read_process_output):
994 (exec_sentinel): Remove vars that were set but not used.
afd4052b 995 (create_pty): Remove unnecessary "volatile"s.
bc57d757 996 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 997 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 998 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 999
fdfc4bf3
PE
1000 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1001
fca8fe46 1002 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1003 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1004
06a0259a 1005 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1006 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1007 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1008
e7b9e80f
PE
1009 * print.c (print_error_message): Avoid int overflow.
1010
56201685
PE
1011 * font.c (font_list_entities): Redo for clarity,
1012 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1013
78834453 1014 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1015 (font_score): Avoid potential overflow in diff calculation.
78834453 1016
0bc0b309 1017 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1018 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1019
e610eaca
PE
1020 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1021
b895abce
PE
1022 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1023 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1024 can always succeed if overflow has undefined behavior.
1025
1f1d9321 1026 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1027 (wordify): Omit three unnecessary tests.
1f1d9321 1028
c59478bc
PE
1029 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1030 All callers changed. This avoids the need for an unused var.
1031
79b73827
PE
1032 * casefiddle.c (casify_region): Remove var that is set but not used.
1033
a4db5dfe
PE
1034 * dired.c (file_name_completion): Remove var that is set but not used.
1035
43aae36e
PE
1036 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1037
2a47c44d 1038 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1039 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1040
a37c69bf
PE
1041 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1042 Check for integer overflow on size calculations.
1043
328ab8e7
PE
1044 * buffer.c (Fprevious_overlay_change): Remove var that is set
1045 but not used.
1046
e5a2a5cb
PE
1047 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1048 Remove vars that are set but not used.
8d84a6eb 1049 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1050 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1051
a60e5f68
PE
1052 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1053
f661cb61 1054 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1055 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1056
f0397f5a
PE
1057 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1058 that are set but not used.
1059
8664db06 1060 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1061 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1062
6abdaa4a
PE
1063 * xselect.c (x_get_local_selection, x_handle_property_notify):
1064 Remove vars that are set but not used.
1065
0ce7538d 1066 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1067 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1068
9ae848fc
PE
1069 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1070 Remove var that is set but not used.
0b918413
PE
1071 (scroll_bar_windows_size): Now size_t, not int.
1072 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1073 Check for overflow.
9ae848fc 1074
a5a62657
PE
1075 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1076 (map_tty_color) [!defined MSDOS]: Likewise.
1077
5c5cdd39
PE
1078 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1079
66ebf983
PE
1080 * coding.c: Remove vars that are set but not used.
1081 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1082 All callers changed.
1083 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1084 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1085 (decode_coding_charset): Remove vars that are set but not used.
1086
1be4d761
PE
1087 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1088 that is set but not used.
1089
47553fa8
PE
1090 * print.c (print_object): Remove var that is set but not used.
1091
1f7196bf 1092 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1093 The gnulib version avoids calling malloc in the usual case,
1094 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1095 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1096 * filelock.c (current_lock_owner): Likewise.
1097 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1098 * sysdep.c: Include allocator.h, careadlinkat.h.
1099 (emacs_no_realloc_allocator): New static constant.
1100 (emacs_readlink): New function.
fdb61804
PE
1101 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1102 ../lib/careadlinkat.h.
d1fdcab7 1103
f84c17c7
SM
11042011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1105
1106 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1107 first non-nil return value).
1108
ef3862ad
JD
11092011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1110
1111 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1112 if not defined (Bug#8403).
1113
376a7006
JB
11142011-04-02 Juanma Barranquero <lekktu@gmail.com>
1115
1116 * xdisp.c (display_count_lines): Remove parameter `start',
1117 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1118 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1119 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1120 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1121 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1122 and thereabouts. All callers changed.
1123 (get_per_char_metric): Remove parameter `f', unused since
1124 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1125
6ca3801d
JM
11262011-04-02 Jim Meyering <meyering@redhat.com>
1127
1128 do not dereference NULL upon failed strdup
1129 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1130 (ns_get_family): Likewise.
1131
d8e2b5ba
JB
11322011-04-02 Juanma Barranquero <lekktu@gmail.com>
1133
1134 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1135
8c74fcbd
JD
11362011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1137
1138 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1139 later (Bug#8403).
1140
7200d79c
SM
11412011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1142
03408648 1143 Add lexical binding.
7200d79c 1144
03408648
SM
1145 * window.c (Ftemp_output_buffer_show): New fun.
1146 (Fsave_window_excursion):
1147 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1148
1149 * lread.c (lisp_file_lexically_bound_p): New function.
1150 (Fload): Bind Qlexical_binding.
1151 (readevalloop): Remove `evalfun' arg.
1152 Bind Qinternal_interpreter_environment.
1153 (Feval_buffer): Bind Qlexical_binding.
1154 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1155 Mark as dynamic.
1156 (syms_of_lread): Declare `lexical-binding'.
1157
1158 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1159
1160 * keyboard.c (eval_dyn): New fun.
1161 (menu_item_eval_property): Use it.
ca105506
SM
1162
1163 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1164
03408648
SM
1165 * fns.c (concat, mapcar1): Accept byte-code-functions.
1166
1167 * eval.c (Fsetq): Handle lexical vars.
1168 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1169 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1170 (FletX, Flet): Obey lexical binding.
1171 (Fcommandp): Handle closures.
1172 (Feval): New `lexical' arg.
1173 (eval_sub): New function extracted from Feval. Use it almost
1174 everywhere where Feval was used. Look up vars in lexical env.
1175 Handle closures.
1176 (Ffunctionp): Move from subr.el.
1177 (Ffuncall): Handle closures.
1178 (apply_lambda): Remove `eval_flags'.
1179 (funcall_lambda): Handle closures and new byte-code-functions.
1180 (Fspecial_variable_p): New function.
1181 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1182 but without exporting it to Lisp.
23aba0ea 1183
23aba0ea 1184 * doc.c (Fdocumentation, store_function_docstring):
03408648 1185 * data.c (Finteractive_form): Handle closures.
23aba0ea 1186
03408648
SM
1187 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1188 interactive spec.
ba83908c 1189
03408648
SM
1190 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1191 byte-codes.
1192 (exec_byte_code): New function extracted from Fbyte_code to handle new
1193 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1194
03408648 1195 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1196
03408648 1197 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1198
e2abce01
JB
11992011-03-31 Juanma Barranquero <lekktu@gmail.com>
1200
1201 * xdisp.c (redisplay_internal): Fix prototype.
1202
63696a73 12032011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1204
63696a73
EZ
1205 * xdisp.c (SCROLL_LIMIT): New macro.
1206 (try_scrolling): Use it when setting scroll_limit. Limit
1207 scrolling to 100 screen lines.
1208 (redisplay_window): Even when falling back on "recentering",
1209 position point in the window according to scroll-conservatively,
1210 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1211
1212 (try_scrolling): When point is above the window, allow searching
1213 as far as scroll_max, or one screenful, to compute vertical
1214 distance from PT to the scroll margin position. This prevents
1215 try_scrolling from unnecessarily failing when
1216 scroll-conservatively is set to a value slightly larger than the
1217 window height. Clean up the case of PT below the margin at bottom
1218 of window: scroll_max can no longer be INT_MAX. When aggressive
1219 scrolling is in use, don't let point enter the opposite scroll
1220 margin as result of the scroll.
1221 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1222 threshold of 100 lines for never-recentering scrolling.
1223
e4cc2dfc
JB
12242011-03-31 Juanma Barranquero <lekktu@gmail.com>
1225
1226 * dispextern.h (move_it_by_lines):
1227 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1228 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1229 (message_log_check_duplicate): Remove parameters `prev_bol' and
1230 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1231 (redisplay_internal): Remove parameter `preserve_echo_area',
1232 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1233
1234 * indent.c (Fvertical_motion):
1235 * window.c (window_scroll_pixel_based, Frecenter):
1236 Don't pass `need_y_p' to `move_it_by_lines'.
1237
1c470562
SM
12382011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1239
44f230aa
SM
1240 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1241 steal a few bits to be more compact.
1242 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1243 Remove unneeded casts.
1244
1c470562
SM
1245 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1246
888adce9
ZK
12472011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1248
1249 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1250 binding" message (bug#7967).
1251
f838ed7b
PE
12522011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1253
77861b95
PE
1254 Fix more problems found by GCC 4.6.0's static checks.
1255
de6dbc14
PE
1256 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1257 Remove unused local var.
1258
f838ed7b
PE
1259 * editfns.c (Fmessage_box): Remove unused local var.
1260
792c7b2b
PE
1261 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1262 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1263 Omit unused local vars.
c499e557 1264 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1265 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1266 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1267 Omit unused local var.
1268
ba0165e1
PE
1269 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1270 Don't assume string length fits in int.
32ad8845 1271 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1272 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1273
3c59b4c9
PE
1274 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1275 instead of alloca (Bug#8344).
1276
a3eed478 1277 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1278 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1279
eb4d412d
PE
1280 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1281
1658b401
PE
1282 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1283 concerns.
1284
1285 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1286
1287 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1288
9a2c6e05
PE
1289 * keyboard.c (syms_of_keyboard): Use the same style as later
1290 in this function when indexing through an array. This also
1291 works around GCC bug 48267.
1292
03d0a109
PE
1293 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1294
44f730c8
PE
1295 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1296
fe75f926
PE
1297 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1298 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1299
ffa8c828
PE
1300 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1301 This avoids undefined behavior on integer overflow, and is a bit
1302 more convenient anyway since it is compared to a size_t variable.
1303
c5101a77
PE
1304 Variadic C functions now count arguments with size_t, not int.
1305 This avoids an unnecessary limitation on 64-bit machines, which
1306 caused (substring ...) to crash on large vectors (Bug#8344).
1307 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1308 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1309 All variadic functions and their callers changed accordingly.
c5101a77
PE
1310 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1311 * data.c (arith_driver, float_arith_driver): Likewise.
1312 * editfns.c (general_insert_function): Likewise.
1313 * eval.c (struct backtrace.nargs, interactive_p)
1314 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1315 (funcall_lambda, mark_backtrace): Likewise.
1316 * fns.c (concat): Likewise.
1317 * frame.c (x_set_frame_parameters): Likewise.
1318 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1319 0 if not found, not -1. All callers changed.
1320
dd3f25f7
PE
1321 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1322 (stack_copy_size): Now size_t, not int.
1323 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1324
461c2ab9
JB
13252011-03-28 Juanma Barranquero <lekktu@gmail.com>
1326
1327 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1328 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1329 All callers changed.
1330
1331 * lisp.h (multibyte_char_to_unibyte):
1332 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1333 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1334 * character.h (CHAR_TO_BYTE8):
1335 * cmds.c (internal_self_insert):
1336 * editfns.c (general_insert_function):
1337 * keymap.c (push_key_description):
1338 * search.c (Freplace_match):
1339 * xdisp.c (message_dolog, set_message_1): All callers changed.
1340
f6d62986
SM
13412011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1342
1343 * keyboard.c (safe_run_hook_funcall): New function.
1344 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1345 don't set the hook to nil, but remove the offending function instead.
1346 (Qcommand_hook_internal): Remove, unused.
1347 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1348 Vcommand_hook_internal.
1349
1350 * eval.c (enum run_hooks_condition): Remove.
1351 (funcall_nil, funcall_not): New functions.
1352 (run_hook_with_args): Call each function through a `funcall' argument.
1353 Remove `cond' argument, now redundant.
1354 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1355 (Frun_hook_with_args_until_failure): Adjust accordingly.
1356 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1357
1db5b1ad
JB
13582011-03-28 Juanma Barranquero <lekktu@gmail.com>
1359
1360 * dispextern.h (string_buffer_position): Remove declaration.
1361
1362 * print.c (strout): Remove parameter `multibyte', unused since
1363 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1364
1365 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1366 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1367 All callers changed.
1368
1369 * w32.c (_wsa_errlist): Use braces for struct initializers.
1370
1371 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1372 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1373 All callers changed.
1374 (string_buffer_position): Likewise. Also, make static (it's never
1375 used outside xdisp.c).
1376 (cursor_row_p): Remove parameter `w', unused since
1377 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1378 (decode_mode_spec): Remove parameter `precision', introduced during
1379 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1380 All callers changed.
1381
5ffb62aa
JD
13822011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1383
1384 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1385
461c2ab9 13862011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1387
1388 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1389 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1390 (ns_update_auto_hide_menu_bar): New functions.
1391 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1392 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1393 ns_constrain_all_frames.
1394 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1395 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1396
5c380ffb
JD
13972011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1398
1399 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1400
9af30bdf
GM
14012011-03-27 Glenn Morris <rgm@gnu.org>
1402
1403 * syssignal.h: Replace RETSIGTYPE with void.
1404 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1405 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1406 Replace SIGTYPE with void everywhere.
1407 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1408 * s/template.h (SIGTYPE): Remove commented out definition.
1409
e2abce01
JB
14102011-03-26 Eli Zaretskii <eliz@gnu.org>
1411
1412 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1413 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1414
f868cd8a
JB
14152011-03-26 Juanma Barranquero <lekktu@gmail.com>
1416
59eb0929
JB
1417 * w32.c (read_unc_volume): Use parameter `henum', instead of
1418 global variable `wget_enum_handle'.
1419
1420 * keymap.c (describe_vector): Remove parameters `indices' and
1421 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1422 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1423
f868cd8a
JB
1424 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1425
1426 * keyboard.c (timer_check): Remove parameter `do_it_now',
1427 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1428 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1429 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1430
1431 * keyboard.c (read_char):
1432 * w32menu.c (w32_menu_display_help):
1433 * xmenu.c (show_help_event, menu_help_callback):
1434 Adjust calls to `show_help_echo'.
1435
1436 * gtkutil.c (xg_maybe_add_timer):
1437 * keyboard.c (readable_events):
1438 * process.c (wait_reading_process_output):
1439 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1440
1441 * insdel.c (adjust_markers_gap_motion):
1442 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1443 (gap_left, gap_right): Don't call it.
1444
2ecf6fdb
CY
14452011-03-25 Chong Yidong <cyd@stupidchicken.com>
1446
1447 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1448 incurred during fontification.
1449
6b1f9ba4
JB
14502011-03-25 Juanma Barranquero <lekktu@gmail.com>
1451
1452 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1453 (DEFVAR_PER_BUFFER): Don't pass it.
1454
1455 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1456 (scrolling_window): Don't pass it.
1457
0f4a96b5
JB
14582011-03-25 Juanma Barranquero <lekktu@gmail.com>
1459
1460 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1461
1462 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1463 and `suffix'.
1464 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1465 of variables specific to SELinux and computation of `encoded_absname'.
1466
1467 * image.c (XPutPixel): Remove unused variable `height'.
1468
1469 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1470
1471 * unexw32.c (get_section_info): Remove unused variable `section'.
1472
1473 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1474 (system_process_attributes): Remove unused variable `sess'.
1475 (sys_read): Remove unused variable `err'.
1476
1477 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1478 (w32_wnd_proc): Remove unused variable `isdead'.
1479 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1480 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1481 (x_create_tip_frame): Remove unused variable `tem'.
1482
1483 * w32inevt.c (w32_console_read_socket):
1484 Remove unused variable `no_events'.
1485
1486 * w32term.c (x_draw_composite_glyph_string_foreground):
1487 Remove unused variable `width'.
1488
1149507c
JB
14892011-03-24 Juanma Barranquero <lekktu@gmail.com>
1490
1491 * w32term.c (x_set_glyph_string_clipping):
1492 Don't pass uninitialized region to CombineRgn.
1493
9c88f339
JB
14942011-03-23 Juanma Barranquero <lekktu@gmail.com>
1495
1496 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1497 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1498 (Fx_close_connection): Remove unused variable `i'.
1499
1500 * w32font.c (w32font_draw): Return number of glyphs.
1501 (w32font_open_internal): Remove unused variable `i'.
1502 (w32font_driver): Add missing initializer.
1503
1504 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1505 (fill_in_menu): Remove unused variable `items_added'.
1506
1507 * w32term.c (last_mouse_press_frame): Remove static global variable.
1508 (w32_clip_to_row): Remove unused variable `f'.
1509 (x_delete_terminal): Remove unused variable `i'.
1510
1511 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1512 (NOTHING): Remove unused static global variable.
1513 (uniscribe_check_otf): Remove unused variable `table'.
1514 (uniscribe_font_driver): Add missing initializers.
1515
dee091a3
JD
15162011-03-23 Julien Danjou <julien@danjou.info>
1517
1518 * term.c (Fsuspend_tty, Fresume_tty):
1519 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1520 * window.c (temp_output_buffer_show):
1521 * insdel.c (signal_before_change):
1522 * frame.c (Fhandle_switch_frame):
1523 * fileio.c (Fdo_auto_save):
1524 * emacs.c (Fkill_emacs):
1525 * editfns.c (save_excursion_restore):
1526 * cmds.c (internal_self_insert):
1527 * callint.c (Fcall_interactively):
1528 * buffer.c (Fkill_all_local_variables):
1529 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1530 Use Frun_hooks.
0f4a96b5 1531 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1532 unconditionnaly since it does the check itself.
1533
2c520ab5 15342011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1535
c9c49752
PE
1536 Fix more problems found by GCC 4.5.2's static checks.
1537
8abc3f12
PE
1538 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1539 the first time through the loop, since we know p0 < p1 then.
1540 This also avoids a gcc -Wstrict-overflow warning.
1541
a2d26660
PE
1542 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1543 leading to a memory leak, possible in functions like
1544 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1545 of objects (Bug#8318).
a2d26660 1546
916c72e9
PE
1547 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1548 that could (at least in theory) be that large.
1549
19ab8a18
PE
1550 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1551 This is less likely to overflow, and avoids undefined behavior if
1552 overflow does occur. All callers changed. Use strtoul to scan
1553 for the unsigned long integer.
b7cbbd6f
PE
1554 (pint2hrstr): Simplify and tune code slightly.
1555 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1556
f0641eff
PE
1557 * scroll.c (do_scrolling): Work around GCC bug 48228.
1558 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1559
7f650bb9
PE
1560 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1561 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1562 (validate_x_resource_name): Simplify count usage.
1563 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1564
37dd57d1
PE
1565 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1566 fail (Bug#8306).
81e56e61 1567
699979fc 1568 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1569
401bf9b4
PE
1570 * process.c (Fmake_network_process): Use socklen_t, not int,
1571 where POSIX says socklen_t is required in portable programs.
1572 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1573 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1574 (Fmake_network_process, server_accept_connection):
1575 (wait_reading_process_output, read_process_output):
1576 Likewise.
1577
b93aacde
PE
1578 * process.c: Rename or move locals to avoid shadowing.
1579 (list_processes_1, Fmake_network_process):
1580 (read_process_output_error_handler, exec_sentinel_error_handler):
1581 Rename or move locals.
4dc343ee 1582 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1583 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1584 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1585 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1586 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1587
af8a867c 1588 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1589 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1590 Include tparam.h instead, since it declares them.
af8a867c
PE
1591 * cm.h (PC): Remove extern decl; tparam.h now does this.
1592 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1593 * terminfo.c: Include tparam.h, to check interfaces.
1594 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1595 (tparam): Adjust signature to match interface in tparam.h;
1596 this removes some undefined behavior. Check that outstring and len
1597 are zero, which they always are with Emacs.
1598 * tparam.h (PC, BC, UP): New extern decls.
1599
0248044d 1600 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1601 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1602
8ff096c1 1603 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1604 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1605 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1606 (ftfont_list): Remove unused local.
49eaafba
PE
1607 (get_adstyle_property, ftfont_pattern_entity):
1608 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1609 Rename locals to avoid shadowing.
8ff096c1 1610
e2be39f6
PE
1611 * xfont.c (xfont_list_family): Mark var as initialized.
1612
c9735e30
PE
1613 * xml.c (make_dom): Now static.
1614
8f5201ae
PE
1615 * composite.c (composition_compute_stop_pos): Rename local to
1616 avoid shadowing.
b246f932
PE
1617 (composition_reseat_it): Remove unused locals.
1618 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1619 (composition_update_it): Mark var as initialized.
11b61122
PE
1620 (find_automatic_composition): Mark vars as initialized,
1621 with a FIXME (Bug#8290).
8f5201ae 1622
760fbc2c
PE
1623 character.h: Rename locals to avoid shadowing.
1624 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1625 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1626 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1627 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1628 to avoid shadowing.
1629
ff08eb85
PE
1630 * textprop.c (property_change_between_p): Remove; unused.
1631
fc7bf025
PE
1632 * intervals.c (interval_start_pos): Now static.
1633
235d7abc
PE
1634 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1635
44f230aa
SM
1636 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1637 Rename locals to avoid shadowing.
3e7d6594 1638
50060332
PE
1639 * sound.c (wav_play, au_play, Fplay_sound_internal):
1640 Fix pointer signedness.
d01f234b 1641 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1642 (wav_play): Initialize a variable to 0, to prevent undefined
1643 behavior (Bug#8278).
50060332 1644
c4fc4e30
PE
1645 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1646
918436ed
PE
1647 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1648
c939f91b
PE
1649 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1650 clobbering (Bug#8298).
b9c7f648
PE
1651 * sysdep.c (sys_subshell): Likewise.
1652 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1653
6bd8c144
PE
1654 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1655 This should get cleaned up, so that child_setup has the
1656 same signature on all platforms.
1657
7710357c 1658 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1659 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1660
c59da222
CY
16612011-03-22 Chong Yidong <cyd@stupidchicken.com>
1662
1663 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1664 not to be necessary, and produces flickering.
1665
66b87493
GM
16662011-03-20 Glenn Morris <rgm@gnu.org>
1667
1668 * config.in: Remove file.
1669
45b6f6d5
JB
16702011-03-20 Juanma Barranquero <lekktu@gmail.com>
1671
1672 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1673 are now in src/globals.h.
1674 (syms_of_minibuf): Remove spurious & from previous change.
1675
3ec03f7e
LL
16762011-03-20 Leo <sdl.web@gmail.com>
1677
1678 * minibuf.c (completing-read-function): New variable.
1679 (completing-read-default): Rename from completing-read.
1680 (completing-read): Call completing-read-function.
1681
b14e3e21
CY
16822011-03-19 Juanma Barranquero <lekktu@gmail.com>
1683
1684 * xfaces.c (Fx_load_color_file):
1685 Read color file from absolute filename (bug#8250).
1686
f2b726e6
JB
16872011-03-19 Juanma Barranquero <lekktu@gmail.com>
1688
1689 * makefile.w32-in: Update dependencies.
1690
09f6ff02
EZ
16912011-03-17 Eli Zaretskii <eliz@gnu.org>
1692
1693 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1694
29a6015a
PE
16952011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1696
a3a6c54e
PE
1697 Fix more problems found by GCC 4.5.2's static checks.
1698
b766f867
PE
1699 * process.c (make_serial_process_unwind, send_process_trap):
1700 (sigchld_handler): Now static.
1701
be02381c
PE
1702 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1703 That way, the code declares only the vars that it needs.
1704 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1705 * s/cygwin.h (PTY_ITERATION): Likewise.
1706 * s/darwin.h (PTY_ITERATION): Likewise.
1707 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1708
57048744
PE
1709 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1710 * process.c (allocate_pty): Don't declare stb unless it's needed.
1711
7914961c 1712 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1713 (CONSTANTLIM): Remove; unused.
1714 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1715 Define only if needed.
7914961c 1716
b3967b18
PE
1717 * unexelf.c (unexec): Name an expression,
1718 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1719 Use a different way to cause a compilation error if anyone uses
1720 n rather than nn, a way that does not involve shadowing.
73366a00 1721 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1722
29a6015a
PE
1723 * deps.mk (unexalpha.o): Remove; unused.
1724
43cfc33e 1725 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1726 * unexec.h: New file.
ce701a33
PE
1727 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1728 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1729 Depend on unexec.h.
1730 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1731 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1732 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1733 Change as necessary to match prototype in unexec.h.
ce701a33 1734
01f44d5a
PE
1735 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1736 shadowing.
4f63c6bb 1737 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1738
a6670b0b
PE
1739 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1740 Rename locals to avoid shadowing.
1741
cef2010d 1742 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1743 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1744
d4d7173a
PE
1745 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1746
f08b802a
PE
1747 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1748 warning when compiling print.c.
1749
3ddb0639
PE
1750 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1751 instead of using an uninitialized var.
5ad03b97 1752 (font_sort_entities): Mark var as initialized.
3ddb0639 1753
170a2692
PE
1754 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1755
e663c700
PE
1756 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1757 pointers to constants.
89bc529a 1758 (font_parse_fcname): Remove unused vars.
7b81e2d0 1759 (font_delete_unmatched): Now static.
ea838e10 1760 (font_get_spec): Remove; unused.
13a547c6
PE
1761 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1762 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1763 Rename or move locals to avoid shadowing.
e663c700 1764
2a80c887 1765 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1766 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1767
1384fa33 1768 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1769 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1770
8b2c52e9
PE
1771 * alloc.c (mark_backtrace): Move decl from here ...
1772 * lisp.h: ... to here, so that it can be checked.
1773
475545b5 1774 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1775 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1776 (lisp_indirect_variable): Name an expression,
1777 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1778 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1779
b1349114 1780 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1781 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1782 Use const pointer when appropriate.
b1349114 1783
a2928364
PE
1784 * lisp.h (get_system_name, get_operating_system_release):
1785 Move decls here, to check interfaces.
1786 * process.c (get_operating_system_release): Move decl to lisp.h.
1787 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1788 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1789 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1790 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1791 (Fformat_time_string, Fencode_time, Finsert_char):
1792 (Ftranslate_region_internal, Fformat):
1793 Rename or remove local vars to avoid shadowing.
9710023e 1794 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1795
a415e694
PE
1796 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1797 avoid shadowing.
1798
8ef4622d
PE
1799 * lisp.h (eassert): Check that the argument compiles, even if
1800 ENABLE_CHECKING is not defined.
1801
946f9a5b
PE
1802 * data.c (Findirect_variable): Name an expression, to avoid
1803 gcc -Wbad-function-cast warning.
112396d6 1804 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1805 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1806 (Fmake_variable_buffer_local, Fmake_local_variable):
1807 Mark variables as initialized.
52746918 1808 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1809
e5aab7e7 1810 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1811 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1812 Rename locals to avoid shadowing.
dff45157
PE
1813 (mark_stack): Move local variables into the #ifdef region where
1814 they're used.
7bc26fdb
PE
1815 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1816 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1817 needed otherwise.
1818 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1819 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1820 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1821
e5aab7e7
PE
1822 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1823 avoids undefined behavior in theory.
1824
4da60324
PE
1825 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1826
88043301
PE
1827 Use functions, not macros, for up- and down-casing (Bug#8254).
1828 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1829 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1830 to use the following functions instead of these macros.
1831 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1832 EMACS_INT, since callers assume the returned value fits in int.
1833 (upcase1): Likewise, for UPCASE_TABLE.
1834 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1835 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1836 the race-condition problem in the old DOWNCASE.
88043301 1837
19ed5445
PE
1838 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1839 Rename locals to avoid shadowing.
1840 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1841 (regex_compile, re_search_2, re_match_2_internal):
1842 Remove unused local vars.
952db0d7
PE
1843 (FREE_VAR): Rewrite so as not to use empty "else",
1844 which gcc can warn about.
da053e48 1845 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1846 (RETALLOC_IF): Define only if needed.
1847 (WORDCHAR_P): Likewise. This one is never needed, but is used
1848 only in a comment talking about a compiler bug, so put inside
1849 the #if 0 of that comment.
1850 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1851 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1852 Remove; unused.
19ed5445 1853
1f3561e4 1854 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1855 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1856 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1857
ded6f8f7
PE
1858 * search.c (simple_search): Remove unused var.
1859
dbd37a95
PE
1860 * dired.c (compile_pattern): Move decl from here ...
1861 * lisp.h: ... to here, so that it can be checked.
1862 (struct re_registers): New forward decl.
1863
7e47afad
PE
1864 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1865
85f24f61
PE
1866 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1867 All uses changed.
1868 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1869 Rename locals to avoid shadowing.
5671df8f 1870 (Fvertical_motion): Mark locals as initialized.
85f24f61 1871
181aa2be 1872 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1873 (casify_region): Mark local as initialized.
181aa2be 1874
930d429c
PE
1875 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1876
7082eac6
PE
1877 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1878 New macros, so that the caller can use some names other than
1879 gcpro1, gcpro2, etc.
1880 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1881 of the new macros.
1882 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1883 argument, for consistency with GCPRO2_VAR, etc: it is now the
1884 prefix of the variable, not the variable itself. All uses
1885 changed.
38b2c076
PE
1886 * dired.c (directory_files_internal, file_name_completion):
1887 Rename locals to avoid shadowing.
1888
15206ed9
PE
1889 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1890 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1891 dired.c's scmp function, had undefined behavior.
1892 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1893 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1894 * buffer.h: ... to here, because these macros use current_buffer,
1895 and the new implementation with inline functions needs to have
1896 current_buffer in scope now, rather than later when the macros
1897 are used.
1898 (downcase, upcase1): New static inline functions.
1899 (DOWNCASE, UPCASE1): Reimplement using these functions.
1900 This avoids undefined behavior in expressions like
1901 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1902 from race conditions in accessing the global variables
1903 case_temp1 and case_temp2.
1904 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1905 * lisp.h (case_temp1, case_temp2): Remove their decls.
1906 * character.h (ASCII_CHAR_P): Move from here ...
1907 * lisp.h: ... to here, so that the inline functions mentioned
1908 above can use them.
1909
4a6bea26
PE
1910 * dired.c (directory_files_internal_unwind): Now static.
1911
f14b7e14
PE
1912 * fileio.c (file_name_as_directory, directory_file_name):
1913 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1914 Now static.
2893f146
PE
1915 (file_name_as_directory): Use const pointers when appropriate.
1916 (Fexpand_file_name): Likewise. In particular, newdir might
1917 point at constant storage, so make it a const pointer.
fd4ead52 1918 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1919 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1920 signedness issues.
f839df0c
PE
1921 (Fset_file_times, Finsert_file_contents, auto_save_error):
1922 Rename locals to avoid shadowing.
f14b7e14 1923
5716756e 1924 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1925 (Ftry_completion, Fall_completions): Rename or remove locals
1926 to avoid shadowing.
5716756e 1927
b4c3046a
PE
1928 * marker.c (bytepos_to_charpos): Remove; unused.
1929
b45db522
PE
1930 * lisp.h (verify_bytepos, count_markers): New decls,
1931 so that gcc does not warn that these functions aren't declared.
1932
85876d07
PE
1933 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1934 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1935 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1936 (copy_text): Remove unused local var.
85876d07 1937
03d78a21 1938 * filelock.c (within_one_second): Now static.
b3dd38ab 1939 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1940
5df8f01b
PE
1941 * buffer.c (fix_overlays_before): Mark locals as initialized.
1942 (fix_start_end_in_overlays): Likewise. This function should be
1943 simplified by using pointers-to-pointers, but that's a different
1944 matter.
b1d876f1 1945 (switch_to_buffer_1): Now static.
8f54f30a
PE
1946 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1947 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1948
a70072c9 1949 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1950 Fix pointer signedness issue.
edced198
PE
1951 (sys_subshell): Mark local as volatile if checking for lint,
1952 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1953 (MAXPATHLEN): Define only if needed.
a70072c9 1954
a0977c44
PE
1955 * process.c (serial_open, serial_configure): Move decls from here ...
1956 * systty.h: ... to here, so that they can be checked.
1957
a884fdcc
PE
1958 * fns.c (get_random, seed_random): Move extern decls from here ...
1959 * lisp.h: ... to here, so that they can be checked.
1960
604efe86 1961 * sysdep.c (reset_io): Now static.
b8950c94 1962 (wait_for_termination_signal): Remove; unused.
604efe86 1963
38fc62d9
PE
1964 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1965 (copy_keymap_item, append_key, push_text_char_description):
1966 Now static.
1004a21a 1967 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1968 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1969 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1970 (describe_map_tree):
1971 Rename locals to avoid shadowing.
38fc62d9 1972
2f2650da
PE
1973 * keyboard.c: Declare functions static if they are not used elsewhere.
1974 (echo_char, echo_dash, cmd_error, top_level_2):
1975 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1976 (read_char, kbd_buffer_get_event, make_lispy_position):
1977 (make_lispy_event, make_lispy_movement, apply_modifiers):
1978 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1979 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1980 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1981 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1982 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1983
a053e86c 1984 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1985 (mark_kboards): Move decl here ...
1986 * alloc.c (mark_kboards): ... from here.
a053e86c 1987
4752793e
PE
1988 * lisp.h (force_auto_save_soon): New decl.
1989
74f10ca7 1990 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1991 (DEFINE_DUMMY_FUNCTION): New macro.
1992 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1993 Use it.
c03cd23f
PE
1994 (main): Add casts to avoid warnings
1995 if GCC considers string literals to be constants.
74f10ca7 1996
022e70d4
PE
1997 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1998
59d6fe83
PE
1999 * dbusbind.c: Pointer signedness fixes.
2000 (xd_signature, xd_append_arg, xd_initialize):
2001 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2002 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2003 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2004 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2005
78320123
PE
2006 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2007 if GCC considers string literals to be constants.
49cebcca 2008 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2009
35ac2a97
SM
20102011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2011
fb103ca9
SM
2012 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2013 (print_preprocess, print_object): New macro to fix last change.
2014
35ac2a97
SM
2015 * print.c (print_preprocess): Don't forget font objects.
2016
62973b41
JB
20172011-03-16 Juanma Barranquero <lekktu@gmail.com>
2018
2019 * emacs.c (USAGE3): Doc fixes.
2020
0e48bb22
AS
20212011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2022
2023 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2024 structure.
2025
7684e57b
JB
20262011-03-14 Juanma Barranquero <lekktu@gmail.com>
2027
2028 * lisp.h (VWindow_system, Qfile_name_history):
2029 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2030 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2031 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2032
2033 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2034 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2035
2036 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2037 * w32console.c (detect_input_pending, read_input_pending)
2038 (encode_terminal_code):
2039 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2040 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2041 (w32_system_caret_y, Qfile_name_history):
2042 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2043 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2044 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2045 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2046 * w32proc.c (Qlocal, report_file_error):
2047 * w32term.c (Vwindow_system, updating_frame):
2048 * w32uniscribe.c (initialized, uniscribe_font_driver):
2049 Remove unneeded extern declarations.
2050
2aa46d6c
CY
20512011-03-14 Chong Yidong <cyd@stupidchicken.com>
2052
c96bbc66 2053 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2054
cffc6f3b
CY
20552011-03-13 Chong Yidong <cyd@stupidchicken.com>
2056
2057 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2058 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2059 These macros can no longer be used for assignment.
2060
44f230aa
SM
2061 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2062 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2063 (record_buffer_markers, fetch_buffer_markers): New functions for
2064 recording and fetching special buffer markers.
2065 (set_buffer_internal_1, set_buffer_temp): Use them.
2066
2067 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2068
2069 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2070
2071 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2072 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2073
2074 * xdisp.c (hscroll_window_tree):
2075 (reconsider_clip_changes): Use PT instead of BUF_PT.
2076
d251f04b
EZ
20772011-03-13 Eli Zaretskii <eliz@gnu.org>
2078
2079 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2080 $(EMACS_ROOT)/lib/intprops.h.
2081
f0c77cd1
PE
20822011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2083
3eca4629
PE
2084 Fix more problems found by GCC 4.5.2's static checks.
2085
7c86ee98
PE
2086 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2087 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2088 (xg_free_frame_widgets): Make it clear that a local variable is
2089 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2090 (gdk_window_get_screen): Make it clear that this macro is needed
2091 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2092 (int_gtk_range_get_value): New function, which avoids a diagnostic
2093 from gcc -Wbad-function-cast.
2094 (xg_set_toolkit_scroll_bar_thumb): Use it.
2095 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2096 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2097 (get_utf8_string, xg_get_file_with_chooser):
2098 Rename locals to avoid shadowing.
2099 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2100
41729b81
PE
2101 * xgselect.c (xg_select): Remove unused var.
2102
f0c77cd1
PE
2103 * image.c (four_corners_best): Mark locals as initialized.
2104 (gif_load): Initialize transparent_p to zero (Bug#8238).
2105 Mark another local as initialized.
ec6cf4c6 2106 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2107
ce0ad53d 2108 * image.c (clear_image_cache): Now static.
d5d5a617 2109 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2110 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2111 (x_edge_detection): Remove unnecessary cast that
2112 gcc -Wbad-function-cast diagnoses.
2037898d 2113 (gif_load): Fix pointer signedness.
6ae141d6
PE
2114 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2115 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2116
33383987 21172011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2118
d32df629
PE
2119 Improve quality of tests for time stamp overflow.
2120 For example, without this patch (encode-time 0 0 0 1 1
2121 1152921504606846976) returns the obviously-bogus value (-948597
2122 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2123 reports time overflow. See
2124 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2125 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2126 * editfns.c: Include limits.h and intprops.h.
2127 (TIME_T_MIN, TIME_T_MAX): New macros.
2128 (time_overflow): Move earlier, to before first use.
2129 (hi_time, lo_time): New functions, for an accurate test for
2130 out-of-range times.
2131 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2132 (Fget_internal_run_time): Don't assume time_t fits in int.
2133 (make_time): Use list2 instead of Fcons twice.
2134 (Fdecode_time): More accurate test for out-of-range times.
2135 (check_tm_member): New function.
2136 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2137 (lisp_time_argument): Don't rely on undefined left-shift and
2138 right-shift behavior when checking for time stamp overflow.
8be6f318 2139
fe31d94c
PE
2140 * editfns.c (time_overflow): New function, refactoring common code.
2141 (Fformat_time_string, Fdecode_time, Fencode_time):
2142 (Fcurrent_time_string): Use it.
2143
8be6f318
PE
2144 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2145 * dired.c (make_time): Move to ...
2146 * editfns.c (make_time): ... here.
2147 * systime.h: Note the move.
2148
09d9db2c 21492011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2150
126bc0dc
YM
2151 * fringe.c (update_window_fringes): Remove unused variables.
2152
c47cbdfd
YM
2153 * unexmacosx.c (copy_data_segment): Also copy __got section.
2154 (Bug#8223)
2155
7ac80be9
EZ
21562011-03-12 Eli Zaretskii <eliz@gnu.org>
2157
c96bbc66 2158 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2159 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2160 Constify `char *' arguments and their references according to
2161 prototypes in tparam.h.
2162
ecb0f94d 2163 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2164
7ac80be9
EZ
2165 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2166 Adapt all references accordingly.
2167
2168 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2169
ef1fd07e
TT
21702011-03-11 Tom Tromey <tromey@redhat.com>
2171
2172 * buffer.c (syms_of_buffer): Remove obsolete comment.
2173
7ef4b50c
EZ
21742011-03-11 Eli Zaretskii <eliz@gnu.org>
2175
2176 * termhooks.h (encode_terminal_code): Declare prototype.
2177
2178 * msdos.c (encode_terminal_code): Don't declare prototype.
2179
2180 * term.c (encode_terminal_code): Now external again, used by
2181 w32console.c and msdos.c.
2182
44f230aa
SM
2183 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2184 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2185
4b1ec863 21862011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2187
1714f52b 2188 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2189
4b1ec863
PE
2190 * fringe.c (update_window_fringes): Mark locals as initialized
2191 (Bug#8227).
2192 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2193
524c7aa6
PE
2194 * alloc.c (mark_fringe_data): Move decl from here ...
2195 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2196 to check its interface.
2197 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2198
a5c0af81 2199 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2200 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2201 (fontset_font): Mark local as initialized.
a9a06e0b 2202 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2203
b4716021
PE
2204 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2205
811e9bac 2206 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2207 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2208 (x_own_selection, Fx_disown_selection_internal): Rename locals
2209 to avoid shadowing.
2210 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2211
7e3ab302
PE
2212 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2213 so that the caller can use some name other than gcpro1.
2214 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2215 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2216 (Fx_backspace_delete_keys_p):
2217 Use them to avoid shadowing, and rename vars to avoid shadowing.
2218 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2219 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2220 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2221 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2222 Remove unused locals.
7e3ab302
PE
2223 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2224 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2225 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2226 macros.
f78faa98 2227
e2b13473
PE
2228 * xterm.h (x_mouse_leave): New decl.
2229
77f23912
PE
2230 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2231 Remove unused functions.
cdf4ba58
PE
2232 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2233 (x_calc_absolute_position): Now static.
7411c686 2234 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2235 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2236 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2237 unless they are used.
38d0b34a
PE
2238 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2239 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2240 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2241 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2242 (x_error_catcher, x_connection_closed, x_error_handler):
2243 (x_error_quitter, xembed_send_message, x_iconify_frame):
2244 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2245 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2246 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2247
44f230aa
SM
2248 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2249 Rename or move locals to avoid shadowing.
6b463e58 2250 (tty_defined_color, merge_face_heights): Now static.
5967d051 2251 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2252 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2253 does not deduce is never used uninitialized.
73719eba
PE
2254 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2255 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2256
426994c3 2257 * terminal.c (store_terminal_param): Now static.
5489860b 2258
032f1620 2259 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2260 (set_frame_menubar): Remove unused local.
d4323972 2261 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2262 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2263 since they might point to immutable storage.
281585b0
PE
2264 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2265 since it's unused otherwise.
032f1620 2266
367c19e5 2267 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2268 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2269 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2270 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2271 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2272 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2273 does not deduce are never used uninitialized.
70739cbe 2274
07b48fa9
PE
2275 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2276
8868a238 2277 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2278 * window.c (window_loop, size_window):
2279 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2280
7e5cf297 2281 * window.c (display_buffer): Now static.
d6550a9f
PE
2282 (size_window): Mark variables that gcc -Wuninitialized
2283 does not deduce are never used uninitialized.
a586633d
PE
2284 * window.h (check_all_windows): New decl, to forestall
2285 gcc -Wmissing-prototypes diagnostic.
5b555da1 2286 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2287
f6095868
PE
2288 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2289 shadowing.
2290 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2291 Include <limits.h>.
2292 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2293 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2294 (load_charset_map): Mark variables that gcc -Wuninitialized
2295 does not deduce are never used uninitialized.
53df7c11 2296 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2297
f38b440c
PE
2298 * coding.c (coding_set_source, coding_set_destination):
2299 Use "else { /* comment */ }" rather than "else /* comment */;"
2300 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2301 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2302 a block, when the outer 'i' will do.
2303 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2304 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2305 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2306 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2307 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2308 Rename locals to avoid shadowing.
2309 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2310 * coding.c (emacs_mule_char, encode_invocation_designation):
2311 Now static, since they're not used elsewhere.
413bb2db 2312 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2313 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2314 (decode_coding_emacs_mule): Mark variables that gcc
2315 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2316 (detect_coding_iso_2022): Initialize a local variable that might
2317 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2318 this initialization is needed. (Bug#8211)
5f58e762
PE
2319 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2320 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2321 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2322 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2323 Remove unused macros.
f38b440c 2324
232b38b9 2325 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2326 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2327 * character.c (string_count_byte8): Likewise.
232b38b9 2328
fb90da1b
PE
2329 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2330 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2331
fb93dbc2
PE
2332 * chartab.c (copy_sub_char_table): Now static, since it's not used
2333 elsewhere.
5c156ace
PE
2334 (sub_char_table_ref_and_range, char_table_ref_and_range):
2335 Rename locals to avoid shadowing.
bbcd0949 2336 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2337
7d3b3862 2338 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2339 (BIDI_BOB): Remove unused macro.
7d3b3862 2340
6be7d3da
PE
2341 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2342 deduce are never used uninitialized.
c2ed9c8b 2343 * term.c (encode_terminal_code): Likewise.
6be7d3da 2344
75f8807f 2345 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2346
50938595
PE
2347 * tparam.h: New file.
2348 * term.c, tparam.h: Include it.
2349 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2350 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2351 Move these decls to tparam.h, and make them agree with what
2352 is actually in tparam.c. The previous trick of using incompatible
2353 decls in different modules does not conform to the C standard.
2354 All callers of tparam changed to use tparam's actual API.
2355 * tparam.c (tparam1, tparam, tgoto):
2356 Use const pointers where appropriate.
2357
fbceeba2
PE
2358 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2359 * cm.h (struct cm): Likewise.
2360 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2361 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2362 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2363 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2364 (turn_on_face, init_tty): Likewise.
2365 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2366
7f3f1250
PE
2367 * term.c (term_mouse_position): Rename local to avoid shadowing.
2368
e6ca6543
PE
2369 * alloc.c (mark_ttys): Move decl from here ...
2370 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2371
c40f8d15
AS
23722011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2373
2374 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2375
cfe0661d
JB
23762011-03-09 Juanma Barranquero <lekktu@gmail.com>
2377
2378 * search.c (compile_pattern_1): Remove argument regp, unused since
2379 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2380 (compile_pattern): Don't pass it.
2381
0afb4571
J
23822011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2383
2384 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2385 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2386 for ! HAVE_GTK3.
2387 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2388
2389 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2390
2391 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2392 gdk_window_get_screen, gdk_window_get_geometry,
2393 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2394 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2395 (xg_get_pixbuf_from_pixmap): New function.
2396 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2397 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2398 Call xg_get_pixbuf_from_pixmap instead of
2399 gdk_pixbuf_get_from_drawable.
2400 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2401 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2402 (xg_check_special_colors): Use GtkStyleContext and its functions
2403 for HAVE_GTK3.
2404 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2405 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2406 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2407 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2408 Call gtk_widget_get_preferred_size.
0afb4571
J
2409 (xg_frame_resized): gdk_window_get_geometry only takes 5
2410 parameters.
44f230aa
SM
2411 (xg_win_to_widget, xg_event_is_for_menubar):
2412 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2413 (xg_set_widget_bg): New function.
2414 (delete_cb): New function.
2415 (xg_create_frame_widgets): connect delete-event to delete_cb.
2416 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2417 (xg_set_background_color): Call xg_set_widget_bg.
2418 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2419 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2420 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2421 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2422 if ! HAVE_GTK3.
2423 (update_frame_tool_bar): Call gtk_widget_hide.
2424 (xg_initialize): Use GDK_KEY_g.
2425
2426 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2427 if ! HAVE_GTK3
2428 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2429
2430 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2431 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2432 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2433
1c2cc4ef
JB
24342011-03-08 Juanma Barranquero <lekktu@gmail.com>
2435
2436 * w32xfns.c (select_palette): Check success of RealizePalette against
2437 GDI_ERROR, not zero.
2438
33383987 2439See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2440
2441;; Local Variables:
2442;; coding: utf-8
aac0c6e3
MR
2443;; End:
2444
33383987 2445 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2446
2447 This file is part of GNU Emacs.
2448
2449 GNU Emacs is free software: you can redistribute it and/or modify
2450 it under the terms of the GNU General Public License as published by
2451 the Free Software Foundation, either version 3 of the License, or
2452 (at your option) any later version.
2453
2454 GNU Emacs is distributed in the hope that it will be useful,
2455 but WITHOUT ANY WARRANTY; without even the implied warranty of
2456 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2457 GNU General Public License for more details.
2458
2459 You should have received a copy of the GNU General Public License
2460 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.