* image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
852a74a5 12011-05-05 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2
4c4b566b
PE
3 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4
aab2b9b5
PE
5 * term.c (vfatal): Remove stray call to va_end.
6 It's not needed and the C Standard doesn't allow it here anyway.
7
c378da0b
PE
8 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10
288b08c7
PE
11 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12 bytes.
13
e3601888
PE
14 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
15
db6c0e74
PE
16 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
17
dd5963ea
PE
18 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
19
88c9450f
PE
20 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
21
2f9442b8
PE
22 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
23
c032b5f8
PE
24 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
25 * charset.c (Fdefine_charset_internal): Don't initialize
26 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 27 32-bit int (Bug#8600).
a108c10b
PE
28
29 * lread.c (read_integer): Be more consistent with string-to-number.
30 Use string_to_number to do the actual conversion; this avoids
31 rounding errors and fixes some other screwups. Without this fix,
32 for example, #x1fffffffffffffff was misread as -2305843009213693952.
33 (digit_to_number): Move earlier, for benefit of read_integer.
34 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 35 not a digit in any supported base. (Bug#8602)
a108c10b 36
ad5f9eea
PE
37 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
38
aec1708a
PE
39 * dispnew.c (scrolling_window): Return 1 if we scrolled,
40 to match comment at start of function. This also removes a
41 GCC warning about overflow in a 32+64-bit port.
42
47be4ab5
PE
43 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
44
371cac43
PE
45 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
46 Reported by Stefan Monnier in
47 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
48 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
49 SYMBOLP-guarded XSYMBOL, not XPNTR.
50
d01a7826
PE
51 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
52 (EMACS_UINTPTR): Likewise, with uintptr_t.
53
7fd47d5c
PE
54 * lisp.h: Prefer 64-bit EMACS_INT if available.
55 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
56 on 32-bit hosts that have 64-bit int, so that they can access
57 large files.
58
8727937b
PE
59 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
60
8ac068ac
PE
61 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
62 This removes an assumption that EMACS_INT and long are the same
63 width as pointers. The assumption is true for Emacs porting targets
64 now, but we want to make other targets possible.
65 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
66 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
67 In the rest of the code, change types of integers that hold casted
68 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
69 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
70 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
71 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
72 No need to cast type when ORing.
73 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
74 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
75 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
76 assume EMACS_INT is the same width as char *.
77 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
78 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
79 Remove no-longer-needed casts.
80 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
81 (xg_tool_bar_help_callback, xg_make_tool_item):
82 Use EMACS_INTPTR to hold an integer
83 that will be cast to void *; this can avoid a GCC warning
84 if EMACS_INT is not the same width as void *.
85 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
86 * xdisp.c (display_echo_area_1, resize_mini_window_1):
87 (current_message_1, set_message_1):
88 Use a local to convert to proper width without a cast.
89 * xmenu.c (dialog_selection_callback): Likewise.
90
ede49d71
PE
91 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
92 Also, don't assume VALBITS / RAND_BITS is less than 5,
93 and don't rely on undefined behavior when shifting a 1 left into
94 the sign bit.
95 * lisp.h (get_random): Change signature to match.
96
2f30ecd0
PE
97 * lread.c (hash_string): Use size_t, not int, for hash computation.
98 Normally we prefer signed values; but hashing is special, because
99 it's better to use unsigned division on hash table sizes so that
100 the remainder is nonnegative. Also, size_t is the natural width
101 for hashing into memory. The previous code used 'int', which doesn't
102 retain enough info to hash well into very large tables.
103 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
104
2a866e7b
PE
105 * dbusbind.c: Don't possibly lose pointer info when converting.
106 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
107 Use XPNTR rather than XHASH, so that the high-order bits of
108 the pointer aren't lost when converting through void *.
109
51639eac
PE
110 * eval.c (Fautoload): Don't double-shift a pointer.
111
92394119
PE
112 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
113
f7ff1b0f 1142011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
115
116 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
117 New version that can reserve upto 2GB of heap space.
118
f7ff1b0f 1192011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
120
121 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
122
639c109b
TZ
1232011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
124
125 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
126 `gnutls_certificate_set_x509_key_file'.
127
d2127135
JB
1282011-05-05 Juanma Barranquero <lekktu@gmail.com>
129
130 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
131 Update dependencies.
132
e968f4f3
JB
1332011-05-04 Juanma Barranquero <lekktu@gmail.com>
134
135 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
136 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
137 Remove unused parameter `fildes'.
138 * process.c (read_process_output, send_process): Don't pass it.
139
84d358f0
JB
1402011-05-04 Juanma Barranquero <lekktu@gmail.com>
141
142 Fix previous change: the library cache is defined in w32.c.
143 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
144 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
145
0898ca10
JB
1462011-05-04 Juanma Barranquero <lekktu@gmail.com>
147
148 Implement dynamic loading of GnuTLS on Windows.
149
150 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
151 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
152 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
153 Declare.
154
155 * gnutls.c (Qgnutls_dll): Define.
156 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
157 (gnutls_*): Declare function pointers.
158 (init_gnutls_functions): New function to initialize function pointers.
159 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
160 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
161 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
162 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
163 (emacs_gnutls_write, emacs_gnutls_read)
164 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
165 (Fgnutls_available_p): New function.
166 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
167 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
168 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
169
170 * image.c: Include w32.h.
171 (Vimage_type_cache): Delete.
172 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
173 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
174 (w32_delayed_load): Move to w32.c.
175
176 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
177
178 * w32.c (QCloaded_from, Vlibrary_cache): Define.
179 (w32_delayed_load): Move from image.c. When loading a library, record
180 its filename in the :loaded-from property of the library id.
181 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
182 Initialize and staticpro them.
183 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
184
185 * process.c: Include lisp.h before w32.h, not after.
186 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
187 instead of gnutls_record_check_pending.
188
189 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
190
ff4de4aa
TZ
1912011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
192
193 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
194 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
195 as passed in.
196
abe95abb
JD
1972011-05-03 Jan Djärv <jan.h.d@swipnet.se>
198
199 * xterm.c (x_set_frame_alpha): Do not set property on anything
200 else than FRAME_X_OUTER_WINDOW (Bug#8608).
201
e16e55d4
JB
2022011-05-02 Juanma Barranquero <lekktu@gmail.com>
203
204 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
205
bafcf6a5
JB
2062011-05-02 Juanma Barranquero <lekktu@gmail.com>
207
208 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
209 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
210 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
211 (gnutls_global_initialized, Qgnutls_bootprop_priority)
212 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
213 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
214 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
215 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
216 (Qgnutls_bootprop_callbacks_verify): Make static.
217
e7a6747f
AS
2182011-05-01 Andreas Schwab <schwab@linux-m68k.org>
219
19ed11ba
AS
220 * callproc.c: Indentation fixup.
221
e7a6747f
AS
222 * sysdep.c (wait_for_termination_1): Make static.
223 (wait_for_termination, interruptible_wait_for_termination): Move
224 after wait_for_termination_1.
225
1ef14cb4
LMI
2262011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
227
228 * sysdep.c (interruptible_wait_for_termination): New function
229 which is like wait_for_termination, but allows keyboard
230 interruptions.
231
232 * callproc.c (Fcall_process): Add (:file "file") as an option for
233 the STDOUT buffer.
234 (Fcall_process_region): Ditto.
235
330d880c
EZ
2362011-04-30 Eli Zaretskii <eliz@gnu.org>
237
8db90b73
EZ
238 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
239 rather than `XVECTOR (FOO)->size'.
240
330d880c
EZ
241 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
242 inttypes.h, as a gnulib replacement is used if it not available in
243 system headers.
244
15cbd324
EZ
2452011-04-21 Eli Zaretskii <eliz@gnu.org>
246
247 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
248 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
249 of MOST_POSITIVE_FIXNUM. (Bug#8528)
250
251 * coding.c (coding_alloc_by_realloc): Error out if destination
252 will grow beyond MOST_POSITIVE_FIXNUM.
253 (decode_coding_emacs_mule): Abort if there isn't enough place in
254 charbuf for the composition carryover bytes. Reserve an extra
255 space for up to 2 characters produced in a loop.
256 (decode_coding_iso_2022): Abort if there isn't enough place in
257 charbuf for the composition carryover bytes.
258
2592011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 260
ae940cca
EZ
261 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
262 aborting when %lld or %lll format is passed.
263 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
264 %llo or %llx format is passed. (Bug#8545)
265
03ab8921
EZ
266 * window.c (window_scroll_line_based): Use a marker instead of
267 simple variables to record original value of point. (Bug#7952)
268
afda1437
EZ
269 * doprnt.c (doprnt): Fix the case where a multibyte sequence
270 produced by %s or %c overflows available buffer space. (Bug#8545)
271
f76dee0c
PE
2722011-04-28 Paul Eggert <eggert@cs.ucla.edu>
273
274 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 275 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 276
fdc5744d
JB
2772011-04-28 Juanma Barranquero <lekktu@gmail.com>
278
279 * w32.c (init_environment): Warn about defaulting HOME to C:\.
280
638f053a
JB
2812011-04-28 Juanma Barranquero <lekktu@gmail.com>
282
283 * keyboard.c (Qdelayed_warnings_hook): Define.
284 (command_loop_1): Run `delayed-warnings-hook'
285 if Vdelayed_warnings_list is non-nil.
286 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
287 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
288
d178f871
EZ
2892011-04-28 Eli Zaretskii <eliz@gnu.org>
290
291 * doprnt.c (doprnt): Don't return value smaller than the buffer
292 size if the message was truncated. (Bug#8545).
293
b124fd93
JB
2942011-04-28 Juanma Barranquero <lekktu@gmail.com>
295
296 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
297 (Fx_window_property): #if-0 the whole functions, not just the bodies.
298
e810457d
PE
2992011-04-27 Paul Eggert <eggert@cs.ucla.edu>
300
301 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
302
ea51cceb
JB
3032011-04-27 Juanma Barranquero <lekktu@gmail.com>
304
305 * makefile.w32-in: Update dependencies.
306
94dcfacf
EZ
3072011-04-27 Eli Zaretskii <eliz@gnu.org>
308
309 Improve `doprnt' and its usage. (Bug#8545)
310 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
311 `format_end'. Remove support for %l as a conversion specifier.
312 Don't use xrealloc. Improve diagnostics when the %l size modifier
313 is used. Update the commentary.
314
315 * eval.c (verror): Simplify calculation of size_t.
316
317 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
318 messages.
319
f61f41d7
PE
3202011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
321
322 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
323 change.
324
96fb4434
PE
3252011-04-27 Paul Eggert <eggert@cs.ucla.edu>
326
327 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
328 This makes this file independent of the recent pseudovector change.
329
671875da 3302011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 331
69e9b5a3
PE
332 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
333
b5f869a7 334 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 335 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 336 Remove unused local.
c8926152 337 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 338
841a1577 339 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
340 GCC 4.6.0 optimizes based on type-based alias analysis. For
341 example, if b is of type struct buffer * and v of type struct
342 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
343 != &v->size, and therefore "v->size = 1; b->size = 2; return
344 v->size;" must therefore return 1. This assumption is incorrect
345 for Emacs, since it type-puns struct Lisp_Vector * with many other
346 types. To fix this problem, this patch adds a new type struct
f904488f 347 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
348 and pseudovectors, and helps optimizing compilers not get fooled
349 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
350 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
351 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
352 the size member.
eab3844f
PE
353 (XSETPVECTYPE): Rewrite in terms of new macro.
354 (XSETPVECTYPESIZE): New macro, specifying both type and size.
355 This is a bit clearer, and further avoids the possibility of
356 undesirable aliasing.
357 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 358 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
359 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
360 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
361 (ASIZE): Now uses header.size rather than size. All
362 previous uses of XVECTOR (foo)->size replaced to use this macro,
363 to avoid the hassle of writing XVECTOR (foo)->header.size.
364 (struct vectorlike_header): New type.
eab3844f
PE
365 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
366 object, to help avoid aliasing.
367 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
368 (SUBRP): Likewise, since Lisp_Subr is a special case.
369 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
370 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
371 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 372 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
373 changed to be "header.size" and "header.next".
374 * buffer.h (struct buffer): Likewise.
375 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
376 * frame.h (struct frame): Likewise.
377 * process.h (struct Lisp_Process): Likewise.
378 * termhooks.h (struct terminal): Likewise.
379 * window.c (struct save_window_data, struct saved_window): Likewise.
380 * window.h (struct window): Likewise.
381 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
382 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
383 * buffer.c (init_buffer_once): Likewise.
384 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
385 special case.
386 * process.c (Fformat_network_address): Use local var for size,
387 for brevity.
388
0df1eac5
PE
389 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
390
847ab9d1 391 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
392 * data.c (atof): Remove decl; no longer used or needed.
393 (digit_to_number): Move to lread.c.
394 (Fstring_to_number): Use new string_to_number function, to be
395 consistent with how the Lisp reader treats infinities and NaNs.
396 Do not assume that floating-point numbers represent EMACS_INT
397 without losing information; this is not true on most 64-bit hosts.
398 Avoid double-rounding errors, by insisting on integers when
399 parsing non-base-10 numbers, as the documentation specifies.
400 * lisp.h (string_to_number): New decl, replacing ...
401 (isfloat_string): Remove.
bc0a5c13 402 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 403 (read1): Do not accept +. and -. as integers; this
452f4150
PE
404 appears to have been a coding error. Similarly, do not accept
405 strings like +-1e0 as floating point numbers. Do not report
406 overflow for integer overflows unless the base is not 10 which
407 means we have no simple and reliable way to continue.
408 Break out the floating-point parsing into a new
409 function string_to_number, so that Fstring_to_number parses
410 floating point numbers consistently with the Lisp reader.
411 (digit_to_number): Moved here from data.c. Make it static inline.
412 (E_CHAR, EXP_INT): Remove, replacing with ...
413 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
414 (string_to_number): New function, replacing isfloat_string.
415 This function checks for valid syntax and produces the resulting
416 Lisp float number too. Rework it so that string-to-number
bc0a5c13 417 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
418 so that overflow for non-base-10 numbers is reported only when
419 there's no portable and simple way to convert to floating point.
452f4150 420
67769ffc
PE
421 * textprop.c (set_text_properties_1): Rewrite for clarity,
422 and to avoid GCC warning about integer overflow.
423
c20db43f
PE
424 * intervals.h (struct interval): Use EMACS_INT for members
425 where EMACS_UINT might cause problems. See
426 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
427 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
428 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
429 All uses changed.
37aa2f85
PE
430 (offset_intervals): Tell GCC not to worry about length overflow
431 when negating a negative length.
c20db43f 432
2538aa2f
PE
433 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
434 (overrun_check_free): Likewise.
435
f2d3008d
PE
436 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
437 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
438 word size.
439
ec8df744
PE
440 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
441 (gnutls_make_error): Rename local to avoid shadowing.
442 (gnutls_emacs_global_deinit): ifdef out; not used.
443 (Fgnutls_boot): Use const for pointer to readonly storage.
444 Comment out unused local. Fix pointer signedness problems.
445
640ee02d
PE
446 * lread.c (openp): Don't stuff size_t into an 'int'.
447 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
448 about possible signed overflow.
449
6048fb2a
PE
450 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
451 (GDK_KEY_g): Don't define if already defined.
452 (xg_prepare_tooltip): Avoid pointer signedness problem.
453 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
454
fa3c87e1
PE
455 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
456 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
457
2172544b
PE
458 * xfns.c (Fx_window_property): Simplify a bit,
459 to make a bit faster and to avoid GCC 4.6.0 warning.
460 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
461
9b821a21
PE
462 * fns.c (internal_equal): Don't assume size_t fits in int.
463
3c616cfa
PE
464 * alloc.c (compact_small_strings): Tighten assertion a little.
465
c2982e87
PE
466 Replace pEd with more-general pI, and fix some printf arg casts.
467 * lisp.h (pI): New macro, generalizing old pEd macro to other
468 conversion specifiers. For example, use "...%"pI"d..." rather
469 than "...%"pEd"...".
470 (pEd): Remove. All uses replaced with similar uses of pI.
471 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
472 * alloc.c (check_pure_size): Don't overflow by converting size to int.
473 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
474 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
475 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
476 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
477 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
478 64-bit hosts.
479 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
480 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
481 * print.c (safe_debug_print, print_object): Likewise.
482 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
483 to int.
6f04d126
PE
484 Use pI instead of if-then-else-abort. Use %p to avoid casts,
485 avoiding the 0 flag, which is not portable.
c2982e87
PE
486 * process.c (Fmake_network_process): Use pI to avoid cast.
487 * region-cache.c (pp_cache): Likewise.
488 * xdisp.c (decode_mode_spec): Likewise.
489 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
490 behavior on 64-bit hosts with printf arg.
6f04d126 491 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
492 (x_stop_queuing_selection_requests): Likewise.
493 (x_get_window_property): Don't truncate byte count to an 'int'
494 when tracing.
0b432f21 495
5e073ec7
PE
496 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
497 here, since it parses constructs like leading '-' and spaces,
498 which are not wanted; and it overflows with large numbers.
499 Instead, simply match F[0-9]+, which is what is wanted anyway.
500
36372bf9
PE
501 * alloc.c: Remove unportable assumptions about struct layout.
502 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
503 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
504 (allocate_vectorlike, make_pure_vector): Use the new macros,
505 plus offsetof, to remove unportable assumptions about struct layout.
506 These assumptions hold on all porting targets that I know of, but
507 they are not guaranteed, they're easy to remove, and removing them
508 makes further changes easier.
509
0b432f21
PE
510 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
511 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
512 (string_overrun_cookie): Now const. Use initializers that
513 don't formally overflow signed char, to avoid warnings.
000098c1
PE
514 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
515 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
516 (allocate_buffer): Don't assume sizeof (struct buffer) is a
517 multiple of sizeof (EMACS_INT); it need not be, if
518 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 519 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 520
895009e1
JB
5212011-04-26 Juanma Barranquero <lekktu@gmail.com>
522
523 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
524
6a7a1b0b
TZ
5252011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
526
527 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 528 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
529 Reported by Paul Eggert <eggert@cs.ucla.edu>.
530
841a1577 5312011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
532
533 * lisp.h (Qdebug): List symbol.
895009e1 534 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
535 * keyboard.c (debug-on-event): New variable.
536 (handle_user_signal): Break into debugger when debug-on-event
537 matches the current signal symbol.
538
f2d3ba6f
DN
5392011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
540
541 * alloc.c (check_sblock, check_string_bytes)
542 (check_string_free_list): Convert to standard C.
543
42ce4c63
TZ
5442011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
545
546 * w32.c (emacs_gnutls_push): Fix typo.
547
825cd63c
EZ
5482011-04-25 Eli Zaretskii <eliz@gnu.org>
549
fb11d64d
EZ
550 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
551 "cast to pointer from integer of different size".
552
825cd63c
EZ
553 Improve doprnt and its use in verror. (Bug#8545)
554 * doprnt.c (doprnt): Document the set of format control sequences
555 supported by the function. Use SAFE_ALLOCA instead of always
556 using `alloca'.
557
558 * eval.c (verror): Don't limit the buffer size at size_max-1, that
559 is one byte too soon. Don't use xrealloc; instead xfree and
560 xmalloc anew.
561
e061a11b
TZ
5622011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
563
564 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
565 callbacks stage.
566
567 * gnutls.c: Renamed global_initialized to
568 gnutls_global_initialized. Added internals for the
569 :verify-hostname-error, :verify-error, and :verify-flags
570 parameters of `gnutls-boot' and documented those parameters in the
571 docstring. Start callback support.
572 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
573 unless a fatal error occured. Call gnutls_alert_send_appropriate
574 on error. Return error code.
575 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
576 (emacs_gnutls_read): Likewise.
577 (Fgnutls_boot): Return handshake error code.
578 (emacs_gnutls_handle_error): New function.
579 (wsaerror_to_errno): Likewise.
580
581 * w32.h (emacs_gnutls_pull): Add prototype.
582 (emacs_gnutls_push): Likewise.
583
584 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
585 (emacs_gnutls_push): Likewise.
586
5872011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
588
589 * process.c (wait_reading_process_output): Check if GnuTLS
590 buffered some data internally if no FDs are set for TLS
591 connections.
592
593 * makefile.w32-in (OBJ2): Add gnutls.$(O).
594 (LIBS): Link to USER_LIBS.
595 ($(BLD)/gnutls.$(0)): New target.
596
fa6996bc
EZ
5972011-04-24 Eli Zaretskii <eliz@gnu.org>
598
eb35682e
EZ
599 * xdisp.c (handle_single_display_spec): Rename the
600 display_replaced_before_p argument into display_replaced_p, to
601 make it consistent with the commentary. Fix typos in the
602 commentary.
603
e2ad650c
EZ
604 * textprop.c (syms_of_textprop): Remove dead code.
605 (copy_text_properties): Delete obsolete commentary about an
606 interface that was deleted long ago. Fix typos in the description
607 of arguments.
608
1b2de274
EZ
609 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
610 to changes in oldXMenu/XMenu.h from 2011-04-16.
611 <menu_help_message, prev_menu_help_message>: Constify.
612 (IT_menu_make_room): menu->help_text is now `const char **';
613 adjust.
614
615 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
616 to changes in oldXMenu/XMenu.h from 2011-04-16.
617 (struct XMenu): Declare `help_text' `const char **'.
618
619 * xfaces.c <Qunspecified>: Make extern again.
620
621 * syntax.c: Include sys/types.h before including regex.h, as
622 required by Posix.
623
762b15be
EZ
624 * doc.c (get_doc_string): Improve the format passed to `error'.
625
626 * doprnt.c (doprnt): Improve commentary.
627
628 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
629
630 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
631 them with etags.
632
f1052e5d
EZ
633 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
634 changes in globals.h immediately force recompilation.
762b15be
EZ
635 (TAGS): Depend on $(CURDIR)/m/intel386.h and
636 $(CURDIR)/s/ms-w32.h.
637 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 638
fa6996bc
EZ
639 * character.c (Fchar_direction): Function deleted.
640 (syms_of_character): Don't defsubr it.
641 <char-direction-table>: Deleted.
642
e6c3da20
EZ
6432011-04-23 Eli Zaretskii <eliz@gnu.org>
644
645 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
646 * doprnt.c: Include limits.h.
647 (SIZE_MAX): New macro.
648 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
649 local variables are now size_t instead of int or unsigned.
650 Improve overflow protection. Support `l' modifier for integer
651 conversions. Support %l conversion. Don't assume an EMACS_INT
652 argument for integer conversions and for %c.
653
654 * lisp.h (doprnt): Restore prototype.
655
656 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
657 $(SRC)/character.h.
658
659 * Makefile.in (base_obj): Add back doprnt.o.
660
661 * deps.mk (doprnt.o): Add back prerequisites.
662 (callint.o): Depend on character.h.
663
664 * eval.c (internal_lisp_condition_case): Include the handler
665 representation in the error message.
666 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
667 when breaking from the loop.
668
669 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
670
671 * callint.c (Fcall_interactively): When displaying error message
672 about invalid control letter, pass the character's codepoint, not
673 a pointer to its multibyte form. Improve display of the character
674 in octal and display also its hex code.
675
676 * character.c (char_string): Use %x to display the (unsigned)
677 codepoint of an invalid character, to avoid displaying a bogus
678 negative value.
679
680 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
681 `error', not SYMBOL_NAME itself.
682
683 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
684 character arguments to `error'.
685
686 * charset.c (check_iso_charset_parameter): Fix incorrect argument
687 to `error' in error message about FINAL_CHAR argument. Make sure
688 FINAL_CHAR is a character, and use %c when it is passed as
689 argument to `error'.
690
4ffd0d6b 6912011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
692
693 * s/ms-w32.h (localtime): Redirect to sys_localtime.
694
695 * w32.c: Include <time.h>.
696 (sys_localtime): New function.
697
4ffd0d6b 6982011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
699
700 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
701
4ffd0d6b 702 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 703
4ffd0d6b 7042011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 705
4ffd0d6b
GM
706 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
707 zombies (Bug#8467).
aac0c6e3 708
04c56954
EZ
7092011-04-19 Eli Zaretskii <eliz@gnu.org>
710
711 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
712 gl_state.e_property when gl_state.object is Qt.
713
714 * insdel.c (make_gap_larger): Remove limitation of buffer size
715 to <= INT_MAX.
716
16a43933
CY
7172011-04-18 Chong Yidong <cyd@stupidchicken.com>
718
719 * xdisp.c (lookup_glyphless_char_display)
720 (produce_glyphless_glyph): Handle cons cell entry in
721 glyphless-char-display.
722 (Vglyphless_char_display): Document it.
723
724 * term.c (produce_glyphless_glyph): Handle cons cell entry in
725 glyphless-char-display.
726
4581706e
CY
7272011-04-17 Chong Yidong <cyd@stupidchicken.com>
728
729 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
730
731 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
732
733 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
734 definition for no-X builds.
735
4887c6e2 7362011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 737
fd35b6f9
PE
738 Static checks with GCC 4.6.0 and non-default toolkits.
739
5c1ccb01
PE
740 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
741
006c5daa
PE
742 * process.c (keyboard_bit_set): Define only if SIGIO.
743 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
744 (send_process): Repair possible setjmp clobbering.
745
efc736d3
PE
746 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
747
4e2fe2e6
PE
748 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
749
f97334a2
PE
750 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
751
4e75f29d
PE
752 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
753 Define only if needed.
754
90efadd1
PE
755 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
756 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 757 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 758
3c647824
PE
759 * dispextern.h (struct redisplay_interface): Rename param
760 to avoid shadowing.
e264f262 761 * termhooks.h (struct terminal): Likewise.
761383f4 762 * xterm.c (xembed_send_message): Likewise.
3c647824 763
b58c5c4a
PE
764 * insdel.c (make_gap_smaller): Define only if
765 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
766
cad59032
PE
767 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
768 it.
769
c339dc2e
PE
770 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
771 so that we aren't warned about unused symbols.
772
91a3e27b
PE
773 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
774
399c71d3 775 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 776
8ffc96f5
PE
777 * xfns.c (x_real_positions): Mark locals as initialized.
778
eef9bc79
PE
779 * xmenu.c (xmenu_show): Don't use uninitialized vars.
780
098db9dd
PE
781 * xterm.c: Fix problems found by static analysis with other toolkits.
782 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
783 (x_dispatch_event): Declare static if USE_GTK, and
784 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 785 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 786 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
787 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
788 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 789
eb18f6cc
PE
790 * xmenu.c (menu_help_callback): Pointer type fixes.
791 Use const pointers when pointing at readonly data. Avoid pointer
792 signedness clashes.
793 (FALSE): Remove unused macro.
794 (update_frame_menubar): Remove unused decl.
795
1fe72bf8
PE
796 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
797
60d9e1db
PE
798 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
799 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
800 (single_menu_item): Rename local to avoid shadowing.
801
39261c26
PE
802 * keyboard.c (make_lispy_event): Remove unused local var.
803
018c5e19
PE
804 * frame.c, frame.h (x_get_resource_string): Bring this back, but
805 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
806
63d2b86e
PE
807 * bitmaps: Change bitmaps from unsigned char back to the X11
808 compatible char. Avoid the old compiler warnings about
809 out-of-range initializers by using, for example, '\xab' rather
810 than 0xab.
811
aefd87e1
PE
812 * xgselect.c (xgselect_initialize): Check vs interface
813 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
814
bf501fb9
PE
815 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
816
e9829fdf
PE
817 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
818 to read-only memory.
819
1086c095
PE
820 * fns.c (vector): Remove; this old hack is no longer needed.
821
2baccd04 822 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 823 Remove unused var.
dde42981 824 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 825
72391843 826 * xrdb.c (x_load_resources): Omit unused local.
3565b346 827
436c16df 828 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 829 (x_window): Rename locals to avoid shadowing.
dc5ddd85 830 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 831
92bb796d 832 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 833 (x_term_init): Remove local to avoid shadowing.
92bb796d 834
764430a3 835 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
836
837 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
838 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
839
d1dfb56c
EZ
8402011-04-16 Eli Zaretskii <eliz@gnu.org>
841
c4354cb4
EZ
842 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
843
d1dfb56c
EZ
844 Fix regex.c, syntax.c and friends for buffers > 2GB.
845 * syntax.h (struct gl_state_s): Declare character position members
846 EMACS_INT.
847
848 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
849
850 * textprop.c (verify_interval_modification, interval_of): Declare
851 arguments EMACS_INT.
852
853 * intervals.c (adjust_intervals_for_insertion): Declare arguments
854 EMACS_INT.
855
856 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
857
858 * indent.c (Fvertical_motion): Local variable it_start is now
859 EMACS_INT.
860
861 * regex.c (re_match, re_match_2, re_match_2_internal)
862 (bcmp_translate, regcomp, regexec, print_double_string)
863 (group_in_compile_stack, re_search, re_search_2, regex_compile)
864 (re_compile_pattern, re_exec): Declare arguments and local
865 variables `size_t' and `ssize_t' and return values `regoff_t', as
866 appropriate.
867 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
868 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
869 <compile_stack_type>: `size' and `avail' are now `size_t'.
870
871 * regex.h <regoff_t>: Use ssize_t, not int.
872 (re_search, re_search_2, re_match, re_match_2): Arguments that
873 specify buffer/string position and length are now ssize_t and
874 size_t. Return type is regoff_t.
875
613052cd
BK
8762011-04-16 Ben Key <bkey76@gmail.com>
877
878 * nsfont.m: Fixed bugs in ns_get_family and
879 ns_descriptor_to_entity that were caused by using free to
880 deallocate memory blocks that were allocated by xmalloc (via
881 xstrdup). This caused Emacs to crash when compiled with
882 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
883 --enable-checking=xmallocoverrun). xfree is now used to
884 deallocate these memory blocks.
885
4170f62f 8862011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 887
71b41406
PE
888 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
889
9587a89d
PE
890 emacs_write: Accept and return EMACS_INT for sizes.
891 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
892 et seq.
893 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
894 Accept and return EMACS_INT.
895 (emacs_gnutls_write): Return the number of bytes written on
896 partial writes.
897 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
898 (emacs_read, emacs_write): Remove check for negative size, as the
899 Emacs source code has been audited now.
9587a89d
PE
900 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
901 (emacs_read, emacs_write): Use it.
273a5f82
PE
902 * process.c (send_process): Adjust to the new signatures of
903 emacs_write and emacs_gnutls_write. Do not attempt to store
904 a byte offset into an 'int'; it might overflow.
9587a89d 905 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 906
3e047f51
PE
907 * sound.c: Don't assume sizes fit in 'int'.
908 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 909 Return EMACS_INT, not int.
3e047f51 910 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
911 Accept EMACS_INT, not int.
912 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
913 record read return values.
914
cc39a9db
BK
9152011-04-15 Ben Key <bkey76@gmail.com>
916
c9d0ec6d
JB
917 * keyboard.c (Qundefined): Don't declare static since it is used
918 in nsfns.m.
919 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
920 static since they are used in nsfont.m.
cc39a9db 921
6c60eb9f
SM
9222011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
923
924 * process.c (Qprocessp): Don't declare static.
925 * lisp.h (Qprocessp): Declare again.
926
7990b61a
JB
9272011-04-15 Juanma Barranquero <lekktu@gmail.com>
928
929 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
930
5d4cb038
PE
9312011-04-14 Paul Eggert <eggert@cs.ucla.edu>
932
8bd7b830 933 Improve C-level modularity by making more things 'static'.
cd64ea1d 934
e3b27b31
PE
935 Don't publish debugger-only interfaces to other modules.
936 * lisp.h (safe_debug_print, debug_output_compilation_hack):
937 (verify_bytepos, count_markers): Move decls to the only modules
938 that need them.
939 * region-cache.h (pp_cache): Likewise.
940 * window.h (check_all_windows): Likewise.
941 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
942
5d4cb038
PE
943 * sysdep.c (croak): Now static, if
944 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
945 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
946
947 * alloc.c (refill_memory_reserve): Now static if
948 !defined REL_ALLOC || defined SYSTEM_MALLOC.
949 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 950
e87b6180
PE
951 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
952 Define only if USE_LUCID.
953
ac64929e
PE
954 * xrdb.c (x_customization_string, x_rm_string): Now static.
955
6f37259d
PE
956 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
957 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
958
1683e3ab
PE
959 * xdisp.c (draw_row_with_mouse_face): Now static.
960 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
961
de9c2632
PE
962 * window.h (check_all_windows): Mark externally visible.
963
2b96acb7
PE
964 * window.c (window_deletion_count): Now static.
965
966 * undo.c: Make symbols static if they're not exported.
967 (last_undo_buffer, last_boundary_position, pending_boundary):
968 Now static.
969
50436f33
PE
970 * textprop.c (interval_insert_behind_hooks): Now static.
971 (interval_insert_in_front_hooks): Likewise.
972
64520e5c
PE
973 * term.c: Make symbols static if they're not exported.
974 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
975 (max_frame_lines, tty_set_terminal_modes):
976 (tty_reset_terminal_modes, tty_turn_off_highlight):
977 (get_tty_terminal): Now static.
978 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
979 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 980 HAVE_WINDOW_SYSTEM.
64520e5c
PE
981 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
982 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
983
1fa53021
PE
984 * sysdep.c: Make symbols static if they're not exported.
985 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
986 Now static.
987 (sigprocmask_set, full_mask): Remove; unused.
988 (wait_debugging): Mark as visible.
989 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
990 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
991
d4b43b22
PE
992 * syntax.c (syntax_temp): Define only if !__GNUC__.
993
b7c513d0
PE
994 * sound.c (current_sound_device, current_sound): Now static.
995
989b29ad
PE
996 * search.c (searchbufs, searchbuf_head): Now static.
997
13a55a78
PE
998 * scroll.c (scroll_cost): Remove; unused.
999 * dispextern.h (scroll_cost): Remove decl.
1000
de68a1fc
PE
1001 * region-cache.h (pp_cache): Mark as externally visible.
1002
40ccffa6
PE
1003 * process.c: Make symbols static if they're not exported.
1004 (process_tick, update_tick, create_process, chan_process):
1005 (Vprocess_alist, proc_buffered_char, datagram_access):
1006 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1007 (deactivate_process): Mark defn as static, as well as decl.
1008 * lisp.h (create_process): Remove decl.
1009 * process.h (chan_process, Vprocess_alist): Remove decls.
1010
ad64fc97
PE
1011 * print.c: Make symbols static if they're not exported.
1012 (print_depth, new_backquote_output, being_printed, print_buffer):
1013 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1014 (print_interval, print_number_index, initial_stderr_stream):
1015 Now static.
1016 * lisp.h (Fprinc): Remove decl.
1017 (debug_output_compilation_hack): Mark as externally visible.
1018
adddb265
PE
1019 * sysdep.c (croak): Move decl from here to syssignal.h.
1020 * syssignal.h (croak): Put it here, so the API can be checked when
1021 'croak' is called from dissociate_if_controlling_tty.
1022
1717ede2
PE
1023 * minibuf.c: Make symbols static if they're not exported.
1024 (minibuf_save_list, choose_minibuf_frame): Now static.
1025 * lisp.h (choose_minibuf_frame): Remove decl.
1026
fa5fb2bc
PE
1027 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1028
1e3890d1
PE
1029 * lread.c: Make symbols static if they're not exported.
1030 (read_objects, initial_obarray, oblookup_last_bucket_number):
1031 Now static.
1032 (make_symbol): Remove; unused.
1033 * lisp.h (initial_obarray, make_symbol): Remove decls.
1034
8a1414fa
PE
1035 * keyboard.c: Make symbols static if they're not exported.
1036 (single_kboard, recent_keys_index, total_keys, recent_keys):
1037 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1038 (this_single_command_key_start, echoing, last_auto_save):
1039 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1040 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1041 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1042 (Vlispy_mouse_stem, double_click_count):
1043 Now static.
1044 (force_auto_save_soon): Define only if SIGDANGER.
1045 (ignore_mouse_drag_p): Now static if
1046 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1047 (print_help): Remove; unused.
1048 (stop_character, last_timer_event): Mark as externally visible.
1049 * keyboard.h (ignore_mouse_drag_p): Declare only if
1050 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1051 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1052 * lisp.h (echoing): Remove decl.
1053 (force_auto_save_soon): Declare only if SIGDANGER.
1054 * xdisp.c (redisplay_window): Simplify code, to make it more
1055 obvious that ignore_mouse_drag_p is not accessed if !defined
1056 USE_GTK && !defined HAVE_NS.
1057
93ea6e8f
PE
1058 * intervals.c: Make symbols static if they're not exported.
1059 (merge_properties_sticky, merge_interval_right, delete_interval):
1060 Now static.
1061 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1062
77382fcc
PE
1063 * insdel.c: Make symbols static if they're not exported.
1064 However, leave prepare_to_modify_buffer alone. It's never
1065 called from outside this function, but that appears to be a bug.
1066 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1067 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1068 (adjust_after_replace_noundo): Remove; unused.
1069 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1070 (signal_before_change): Remove decls.
77382fcc 1071
9306c32e
PE
1072 * indent.c (val_compute_motion, val_vmotion): Now static.
1073
cd44d2eb
PE
1074 * image.c: Make symbols static if they're not exported.
1075 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1076 if USE_GTK.
1077 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1078 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1079
ad9a7a06
PE
1080 * fringe.c (standard_bitmaps): Now static.
1081 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1082
81626931
PE
1083 * frame.c: Make symbols static if they're not exported.
1084 (x_report_frame_params, make_terminal_frame): Now static.
1085 (get_frame_param): Now static, unless HAVE_NS.
1086 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1087 (x_get_resource_string): Remove; not used.
1088 * frame.h (make_terminal_frame, x_report_frame_params):
1089 (x_get_resource_string); Remove decls.
1090 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1091 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1092
239f9db9
PE
1093 * font.c, fontset.c: Make symbols static if they're not exported.
1094 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1095 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1096 * font.c (font_close_object): Now static.
1097 * font.h (font_close_object): Remove.
1098 * fontset.c (FONTSET_OBJLIST): Remove.
1099 (free_realized_fontset) #if-0 the body, which does nothing.
1100 (face_suitable_for_char_p): #if-0, as it's never called.
1101 * fontset.h (face_suitable_for_char_p): Remove decl.
1102 * xfaces.c (face_at_string_position): Use
1103 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1104 since 0 is always ASCII.
1105
dfcf3579
PE
1106 * fns.c (weak_hash_tables): Now static.
1107
5045092b
PE
1108 * fileio.c: Make symbols static if they're not exported.
1109 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1110 (Vwrite_region_annotation_buffers): Now static.
1111
57a96f5c
PE
1112 * eval.c: Make symbols static if they're not exported.
1113 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1114 * lisp.h (backtrace_list): Remove decl.
1115
35f08c38
PE
1116 * emacs.c: Make symbols static if they're not exported.
1117 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1118 (fatal_error_code, fatal_error_signal_hook, standard_args):
1119 Now static.
1120 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1121 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1122 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1123 * lisp.h (fatal_error_signal_hook): Remove decl.
1124 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1125
f44bd759
PE
1126 * editfns.c: Move a (normally-unused) function to its only use.
1127 * editfns.c, lisp.h (get_operating_system_release): Remove.
1128 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1129 worth the hassle of breaking this out.
1130
b532497d
PE
1131 * xterm.c: Make symbols static if they're not exported.
1132 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1133 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1134 (x_destroy_window, x_delete_display):
1135 Now static.
1136 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1137 (x_mouse_leave): Remove; unused.
1138 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1139 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1140 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1141 Remove decls.
1142 (x_mouse_leave): Declare only if WINDOWSNT.
1143 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1144 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1145 USE_X_TOOLKIT.
1146
1675728f
PE
1147 * ftxfont.c: Make symbols static if they're not exported.
1148 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1149 HAVE_FREETYPE.
1150 * font.h (ftxfont_driver): Likewise.
1151
e4cebfca
PE
1152 * xfns.c: Make symbols static if they're not exported.
1153 (x_last_font_name, x_display_info_for_name):
1154 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1155 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1156 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1157 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1158 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1159 (last_show_tip_args): Now static.
1160 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1161 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1162 (x_screen_planes): Remove; unused.
1163 * dispextern.h (x_screen_planes): Remove decl.
1164
5bf46f05
PE
1165 * dispnew.c: Make symbols static if they're not exported.
1166 * dispextern.h (redraw_garbaged_frames, scrolling):
1167 (increment_row_positions): Remove.
1168 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1169 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1170 Now static.
1171 (redraw_garbaged_frames): Remove; unused.
1172
435f4c28
PE
1173 * xfaces.c: Make symbols static if they're not exported.
1174 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1175 Remove decls.
1176 * xterm.h (defined_color): Remove decls.
1177 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1178 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1179 (menu_face_changed_default, defined_color, free_realized_face):
1180 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1181 (ascii_face_of_lisp_face): Remove; unused.
1182
8524aef3
PE
1183 * xdisp.c: Make symbols static if they're not exported.
1184 * dispextern.h (scratch_glyph_row, window_box_edges):
1185 (glyph_to_pixel_coords, set_cursor_from_row):
1186 (get_next_display_element, set_iterator_to_next):
1187 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1188 (show_mouse_face): Remove decls
1189 * frame.h (message_buf_print): Likewise.
1190 * lisp.h (pop_message, set_message, check_point_in_composition):
1191 Likewise.
1192 * xterm.h (set_vertical_scroll_bar): Likewise.
1193 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1194 (message_buf_print, scratch_glyph_row, displayed_buffer):
1195 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1196 (get_next_display_element, show_mouse_face, window_box_edges):
1197 (frame_to_window_pixel_xy, check_point_in_composition):
1198 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1199 (glyph_to_pixel_coords): Remove; unused.
1200
16390cd2
PE
1201 * dired.c (file_name_completion): Now static.
1202
1203 * dbusbind.c (xd_in_read_queued_messages): Now static.
1204
a25f4dfa
PE
1205 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1206 * data.c (circular_list_error): Remove.
1207
14a9c8df
PE
1208 * commands.h (last_point_position, last_point_position_buffer):
1209 (last_point_position_window): Remove decls.
1210 * keyboard.c: Make these variables static.
1211
74ab6df5
PE
1212 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1213 decls.
1214 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1215 (iso_code_class, detect_coding, code_convert_region): Now static.
1216 (encode_coding_gap): Remove; unused.
1217
38dfbee1
PE
1218 * chartab.c (chartab_chars, chartab_bits): Now static.
1219
a2cb4e63
PE
1220 * charset.h (charset_iso_8859_1): Remove decl.
1221 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1222 Now static.
1223
127198fd
PE
1224 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1225 * ccl.c (Vccl_program_table): Now static.
1226 (check_ccl_update): Remove; unused.
1227
d85b608f
PE
1228 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1229 * category.h: ... from here.
1230 * category.c (check_category_table, set_category_set): Now static.
1231
31cd66f3
PE
1232 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1233 * lisp.h: Remove these decls.
1234
c358e587
PE
1235 * buffer.c (buffer_count): Remove unused var.
1236
e78aecca
PE
1237 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1238 so that it's not optimized away.
1239 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1240 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1241 exported only to the debugger.
1242
e192d7d3
PE
1243 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1244 * atimer.h (run_all_atimers): Removed; not exported.
1245
92470028
PE
1246 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1247 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1248 was inaccessible from Lisp.
1249 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1250 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1251
244ed907
PE
1252 alloc.c: Import and export fewer symbols, and remove unused items.
1253 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1254 is defined.
1255 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1256 it's not optimized away by whole-program optimization.
1257 (message_enable_multibyte, free_misc): Remove.
1258 (catchlist, handlerlist, mark_backtrace):
1259 Declare only if BYTE_MARK_STACK.
1260 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1261 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1262 (message_enable_multibyte): Remove decl.
1263 (free_misc, interval_free_list, float_block, float_block_index):
1264 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1265 (cons_free_list, last_marked_index):
1266 Now static.
1267 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1268 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1269 (mark_backtrace): Define only if BYTE_MARK_STACK.
1270 * xdisp.c (message_enable_multibyte): Now static.
1271
61c2b50e 1272 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1273 This makes it easier for human readers (and static analyzers)
1274 to see whether these variables are used from other modules.
1275 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1276 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1277 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1278 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1279 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1280 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1281 * xmenu.c, xselect.c:
1282 Declare Q* vars static if they are not used in other modules.
1283 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1284 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1285 Remove decls of unexported vars.
1286 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1287
95c82688
PE
1288 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1289
16a97296
PE
1290 Make Emacs functions such as Fatom 'static' by default.
1291 This makes it easier for human readers (and static analyzers)
1292 to see whether these functions can be called from other modules.
1293 DEFUN now defines a static function. To make the function external
1294 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1295 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1296 (Finit_image_library):
16a97296
PE
1297 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1298 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1299 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1300 Remove decls, since these functions are now static.
1301 (Funintern, Fget_internal_run_time): New decls, since these functions
1302 were already external.
95c82688 1303
16a97296
PE
1304 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1305 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1306 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1307 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1308 * keyboard.c, keymap.c, lread.c:
1309 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1310 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1311 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1312 Mark functions with DEFUE instead of DEFUN,
1313 if they are used in other modules.
1314 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1315 decls for now-static functions.
1316 * buffer.h (Fdelete_overlay): Remove decl.
1317 * callproc.c (Fgetenv_internal): Mark as internal.
1318 * composite.c (Fremove_list_of_text_properties): Remove decl.
1319 (Fcomposition_get_gstring): New forward static decl.
1320 * composite.h (Fcomposite_get_gstring): Remove decl.
1321 * dired.c (Ffile_attributes): New forward static decl.
1322 * doc.c (Fdocumntation_property): New forward static decl.
1323 * eval.c (Ffetch_bytecode): New forward static decl.
1324 (Funintern): Remove extern decl; now in .h file where it belongs.
1325 * fileio.c (Fmake_symbolic_link): New forward static decl.
1326 * image.c (Finit_image_library): New forward static decl.
1327 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1328 * intervals.h (Fprevious_property_change):
1329 (Fremove_list_of_text_properties): Remove decls.
1330 * keyboard.c (Fthis_command_keys): Remove decl.
1331 (Fcommand_execute): New forward static decl.
1332 * keymap.c (Flookup_key): New forward static decl.
1333 (Fcopy_keymap): Now static.
1334 * keymap.h (Flookup_key): Remove decl.
1335 * process.c (Fget_process): New forward static decl.
1336 (Fprocess_datagram_address): Mark as internal.
1337 * syntax.c (Fsyntax_table_p): New forward static decl.
1338 (skip_chars): Remove duplicate decl.
1339 * textprop.c (Fprevious_property_change): New forward static decl.
1340 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1341 Now internal.
1342 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1343 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1344
785bbd42
PE
1345 * editfns.c (Fformat): Remove unreachable code.
1346
8b913b57
AS
13472011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1348
1349 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1350 change. (Bug#8496)
1351
a6744a35
EZ
13522011-04-13 Eli Zaretskii <eliz@gnu.org>
1353
1354 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1355 when at ZV. (Bug#8487)
1356
e7974947
AS
13572011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1358
baad03f0
AS
1359 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1360 (Bug#8437)
1361 * keyboard.c (parse_tool_bar_item): Likewise.
1362 * sound.c (sound_cleanup, alsa_close): Likewise.
1363 * termcap.c (tgetent): Likewise.
1364 * xfns.c (x_default_font_parameter): Likewise.
1365 * xsettings.c (read_and_apply_settings): Likewise.
1366
e7974947
AS
1367 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1368 (overrun_check_free): Protoize.
1369
28272684
PE
13702011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1371
1372 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1373 since callers should never pass a negative size.
1374 Change the signature to match that of plain 'read' and 'write'; see
1375 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1376 * lisp.h: Update prototypes of emacs_write and emacs_read.
1377
11997c76
EZ
13782011-04-11 Eli Zaretskii <eliz@gnu.org>
1379
1380 * xdisp.c (redisplay_window): Don't try to determine the character
1381 position of the scroll margin if the window start point w->startp
e896f03c 1382 is outside the buffer's accessible region. (Bug#8468)
11997c76 1383
8a2cbd72
EZ
13842011-04-10 Eli Zaretskii <eliz@gnu.org>
1385
1386 Fix write-region and its subroutines for buffers > 2GB.
1387 * fileio.c (a_write, e_write): Modify declaration of arguments and
1388 local variables to support buffers larger than 2GB.
1389 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1390
1391 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1392 argument, local variables, and return value.
1393
1394 * lisp.h: Update prototypes of emacs_write and emacs_read.
1395
1396 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1397
4073e537 13982011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1399
1ebfdcb6
PE
1400 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1401
b2ded58d
PE
1402 Fix more problems found by GCC 4.6.0's static checks.
1403
7d66342c
PE
1404 * xdisp.c (vmessage): Use a better test for character truncation.
1405
bbf47d44
PE
1406 * charset.c (load_charset_map): <, not <=, for optimization,
1407 and to avoid potential problems with integer overflow.
9248994d 1408 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1409 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1410 * editfns.c (Fformat): Likewise.
1e69125e 1411 * syntax.c (skip_chars): Likewise.
3befa583 1412
e3019616
PE
1413 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1414 This also lets GCC 4.6.0 generate slightly better loop code.
1415
becfa255
PE
1416 * callint.c (Fcall_interactively): <, not <=, for optimization.
1417 (Fcall_interactively): Count the number of arguments produced,
1418 not the number of arguments given. This is simpler and lets GCC
1419 4.6.0 generate slightly better code.
1420
dae0cd48
PE
1421 * ftfont.c: Distingish more carefully between FcChar8 and char.
1422 The previous code passed unsigned char * to a functions like
1423 strlen and xstrcasecmp that expect char *, which does not
1424 conform to the C standard.
1425 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1426 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1427 char * when the C standard requires it.
1428
76032d70
PE
1429 * keyboard.c (read_char): Remove unused var.
1430
eb3f1cc8
PE
1431 * eval.c: Port to Windows vsnprintf (Bug#8435).
1432 Include <limits.h>.
1433 (SIZE_MAX): Define if the headers do not.
1434 (verror): Do not give up if vsnprintf returns a negative count.
1435 Instead, grow the buffer. This ports to Windows vsnprintf, which
1436 does not conform to C99. Problem reported by Eli Zaretskii.
1437 Also, simplify the allocation scheme, by avoiding the need for
1438 calling realloc, and removing the ALLOCATED variable.
1439
70476b54
PE
1440 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1441
12020a9e
PE
1442 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1443 But keep the doprint source code for now, as we might revamp it
1444 and use it again (Bug#8435).
ea6c7ae6
PE
1445 * lisp.h (doprnt): Remove.
1446 * Makefile.in (base_obj): Remove doprnt.o.
1447 * deps.mk (doprnt.o): Remove.
1448
5fdb398c
PE
1449 error: Print 32- and 64-bit integers portably (Bug#8435).
1450 Without this change, on typical 64-bit hosts error ("...%d...", N)
1451 was used to print both 32- and 64-bit integers N, which relied on
1452 undefined behavior.
1453 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1454 New macro.
1455 * lisp.h (error, verror): Mark as printf-like functions.
1456 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1457 Report overflow in size calculations when allocating printf buffer.
1458 Do not truncate output string at its first null byte.
1459 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1460 Truncate the output at a character boundary, since vsnprintf does not
1461 do that.
1462 * charset.c (check_iso_charset_parameter): Convert internal
1463 character to string before calling 'error', since %c now has the
1464 printf meaning.
1465 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1466 overflow when computing char to be passed to 'error'. Do not
1467 pass Lisp_Object to 'error'; pass the integer instead.
1468 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1469 formatted with plain %d.
1470
b189fa66
PE
1471 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1472
bff87ef0
PE
1473 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1474
7e2cac20
PE
1475 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1476
ce4d90b5
PE
1477 * xterm.c (x_catch_errors): Remove duplicate declaration.
1478
266c9547
PE
1479 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1480
79c49ad2
PE
1481 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1482
368f4090
JM
14832011-04-10 Jim Meyering <meyering@redhat.com>
1484
1485 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1486 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1487 return ssize_t not "int", and use size_t as the buffer length.
1488 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1489 * gnutls.h: Update declarations.
1490 * process.c (read_process_output): Use ssize_t, to match.
1491 (send_process): Likewise.
1492
a32d4040
CY
14932011-04-09 Chong Yidong <cyd@stupidchicken.com>
1494
1495 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1496
8546720e 14972011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1498
8546720e
GM
1499 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1500 unsigned char, to match FcChar8 type definition.
aac0c6e3 1501
8546720e
GM
1502 * xterm.c (handle_one_xevent):
1503 * xmenu.c (create_and_show_popup_menu):
1504 * xselect.c (x_decline_selection_request)
1505 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1506
0a2f5c1a 15072011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1508
1509 Fix some uses of `int' instead of EMACS_INT.
1510 * search.c (string_match_1, fast_string_match)
1511 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1512 (scan_buffer, find_next_newline_no_quit)
1513 (find_before_next_newline, search_command, Freplace_match)
1514 (Fmatch_data): Make some `int' variables be EMACS_INT.
1515
1516 * xdisp.c (display_count_lines): 3rd argument and return value now
1517 EMACS_INT. All callers changed.
1518 (pint2hrstr): Last argument is now EMACS_INT.
1519
1520 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1521 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1522 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1523 (decode_coding_utf_16, decode_coding_emacs_mule)
1524 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1525 (decode_coding_ccl, decode_coding_charset)
1526 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1527 (decode_coding_iso_2022, decode_coding_emacs_mule)
1528 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1529 <char_offset, last_offset>: Declare EMACS_INT.
1530 (encode_coding_utf_8, encode_coding_utf_16)
1531 (encode_coding_emacs_mule, encode_invocation_designation)
1532 (encode_designation_at_bol, encode_coding_iso_2022)
1533 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1534 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1535 Declare EMACS_INT.
1536 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1537 (encode_invocation_designation): Last argument P_NCHARS is now
1538 EMACS_INT.
1539 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1540 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1541
1542 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1543 All users changed.
1544
1545 * ccl.c (Fccl_execute_on_string): Declare some variables
1546 EMACS_INT.
1547
8546720e 15482011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1549
1550 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1551
4e19a977
CS
15522011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1553
1554 * process.c (Fformat_network_address): Doc fix.
1555
87302331
R
15562011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1557
1558 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1559
cbb59342
CY
15602011-04-08 Chong Yidong <cyd@stupidchicken.com>
1561
1562 * keyboard.c (read_char): Call Lisp function help-form-show,
1563 instead of using internal_with_output_to_temp_buffer.
1564 (Qhelp_form_show): New var.
e0d38eeb 1565 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1566
1567 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1568
1569 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1570
e67a13ab
CY
15712011-04-06 Chong Yidong <cyd@stupidchicken.com>
1572
1573 * process.c (Flist_processes): Removed to Lisp.
1574 (list_processes_1): Deleted.
1575
973f782d
EZ
15762011-04-06 Eli Zaretskii <eliz@gnu.org>
1577
7c106b1e
EZ
1578 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1579
973f782d
EZ
1580 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1581
41cf7d1a 15822011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1583
ca23cc88
PE
1584 Fix more problems found by GCC 4.6.0's static checks.
1585
f390e2d5
PE
1586 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1587
42eea0d0
PE
1588 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1589
b69769da 1590 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1591
f9541e84
PE
1592 * xdisp.c (vmessage): Mark as a printf-like function.
1593
13841b55
PE
1594 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1595
c136c10f
PE
1596 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1597
5e2d4a30
PE
1598 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1599 printf-like functions.
1600 (tiff_load): Add casts to remove these marks before passing them
1601 to system-supplied API.
1602
583f48b9
PE
1603 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1604
b25d760e
PE
1605 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1606 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1607 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1608 directly, rather than having caller test rule sign. This avoids
1609 some unnecessary tests.
1610 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1611 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1612 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1613
bc7b6697 1614 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1615 (xfont_open): Avoid unnecessary tests.
bc7b6697 1616
27ccc379
PE
1617 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1618
dcd5c89a
PE
1619 * composite.h, composite.c (composition_gstring_put_cache):
1620 Use EMACS_INT, not int, for length.
1621
b13a45c6
PE
1622 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1623 breaking out part of COMPOSITION_DECODE_RULE.
1624 (COMPOSITION_DECODE_RULE): Use it.
1625 * composite.c (get_composition_id): Remove unused local vars,
1626 by using the new macro.
1627
1e792e4d
PE
1628 * textprop.c (set_text_properties_1): Change while to do-while,
1629 since the condition is always true at first.
1630
dc6c6455 1631 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1632 (interval_deletion_adjustment): Return unsigned value.
1633 All uses changed.
dc6c6455 1634
aba7731a
PE
1635 * process.c (list_processes_1, create_pty, read_process_output):
1636 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1637 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1638 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1639 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1640 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1641
fdfc4bf3
PE
1642 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1643
fca8fe46 1644 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1645 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1646
06a0259a 1647 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1648 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1649 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1650
e7b9e80f
PE
1651 * print.c (print_error_message): Avoid int overflow.
1652
56201685
PE
1653 * font.c (font_list_entities): Redo for clarity,
1654 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1655
78834453 1656 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1657 (font_score): Avoid potential overflow in diff calculation.
78834453 1658
0bc0b309 1659 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1660 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1661
e610eaca
PE
1662 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1663
b895abce
PE
1664 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1665 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1666 can always succeed if overflow has undefined behavior.
1667
1f1d9321 1668 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1669 (wordify): Omit three unnecessary tests.
1f1d9321 1670
c59478bc
PE
1671 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1672 All callers changed. This avoids the need for an unused var.
1673
79b73827
PE
1674 * casefiddle.c (casify_region): Remove var that is set but not used.
1675
a4db5dfe
PE
1676 * dired.c (file_name_completion): Remove var that is set but not used.
1677
43aae36e
PE
1678 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1679
2a47c44d 1680 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1681 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1682
a37c69bf
PE
1683 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1684 Check for integer overflow on size calculations.
1685
328ab8e7
PE
1686 * buffer.c (Fprevious_overlay_change): Remove var that is set
1687 but not used.
1688
e5a2a5cb
PE
1689 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1690 Remove vars that are set but not used.
8d84a6eb 1691 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1692 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1693
a60e5f68
PE
1694 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1695
f661cb61 1696 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1697 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1698
f0397f5a
PE
1699 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1700 that are set but not used.
1701
8664db06 1702 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1703 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1704
6abdaa4a
PE
1705 * xselect.c (x_get_local_selection, x_handle_property_notify):
1706 Remove vars that are set but not used.
1707
0ce7538d 1708 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1709 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1710
9ae848fc
PE
1711 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1712 Remove var that is set but not used.
0b918413
PE
1713 (scroll_bar_windows_size): Now size_t, not int.
1714 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1715 Check for overflow.
9ae848fc 1716
a5a62657
PE
1717 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1718 (map_tty_color) [!defined MSDOS]: Likewise.
1719
5c5cdd39
PE
1720 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1721
66ebf983
PE
1722 * coding.c: Remove vars that are set but not used.
1723 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1724 All callers changed.
1725 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1726 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1727 (decode_coding_charset): Remove vars that are set but not used.
1728
1be4d761
PE
1729 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1730 that is set but not used.
1731
47553fa8
PE
1732 * print.c (print_object): Remove var that is set but not used.
1733
1f7196bf 1734 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1735 The gnulib version avoids calling malloc in the usual case,
1736 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1737 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1738 * filelock.c (current_lock_owner): Likewise.
1739 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1740 * sysdep.c: Include allocator.h, careadlinkat.h.
1741 (emacs_no_realloc_allocator): New static constant.
1742 (emacs_readlink): New function.
fdb61804
PE
1743 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1744 ../lib/careadlinkat.h.
d1fdcab7 1745
f84c17c7
SM
17462011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1747
1748 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1749 first non-nil return value).
1750
ef3862ad
JD
17512011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1752
1753 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1754 if not defined (Bug#8403).
1755
376a7006
JB
17562011-04-02 Juanma Barranquero <lekktu@gmail.com>
1757
1758 * xdisp.c (display_count_lines): Remove parameter `start',
1759 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1760 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1761 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1762 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1763 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1764 and thereabouts. All callers changed.
1765 (get_per_char_metric): Remove parameter `f', unused since
1766 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1767
6ca3801d
JM
17682011-04-02 Jim Meyering <meyering@redhat.com>
1769
1770 do not dereference NULL upon failed strdup
1771 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1772 (ns_get_family): Likewise.
1773
d8e2b5ba
JB
17742011-04-02 Juanma Barranquero <lekktu@gmail.com>
1775
1776 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1777
8c74fcbd
JD
17782011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1779
1780 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1781 later (Bug#8403).
1782
7200d79c
SM
17832011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1784
03408648 1785 Add lexical binding.
7200d79c 1786
03408648
SM
1787 * window.c (Ftemp_output_buffer_show): New fun.
1788 (Fsave_window_excursion):
1789 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1790
1791 * lread.c (lisp_file_lexically_bound_p): New function.
1792 (Fload): Bind Qlexical_binding.
1793 (readevalloop): Remove `evalfun' arg.
1794 Bind Qinternal_interpreter_environment.
1795 (Feval_buffer): Bind Qlexical_binding.
1796 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1797 Mark as dynamic.
1798 (syms_of_lread): Declare `lexical-binding'.
1799
1800 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1801
1802 * keyboard.c (eval_dyn): New fun.
1803 (menu_item_eval_property): Use it.
ca105506
SM
1804
1805 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1806
03408648
SM
1807 * fns.c (concat, mapcar1): Accept byte-code-functions.
1808
1809 * eval.c (Fsetq): Handle lexical vars.
1810 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1811 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1812 (FletX, Flet): Obey lexical binding.
1813 (Fcommandp): Handle closures.
1814 (Feval): New `lexical' arg.
1815 (eval_sub): New function extracted from Feval. Use it almost
1816 everywhere where Feval was used. Look up vars in lexical env.
1817 Handle closures.
1818 (Ffunctionp): Move from subr.el.
1819 (Ffuncall): Handle closures.
1820 (apply_lambda): Remove `eval_flags'.
1821 (funcall_lambda): Handle closures and new byte-code-functions.
1822 (Fspecial_variable_p): New function.
1823 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1824 but without exporting it to Lisp.
23aba0ea 1825
23aba0ea 1826 * doc.c (Fdocumentation, store_function_docstring):
03408648 1827 * data.c (Finteractive_form): Handle closures.
23aba0ea 1828
03408648
SM
1829 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1830 interactive spec.
ba83908c 1831
03408648
SM
1832 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1833 byte-codes.
1834 (exec_byte_code): New function extracted from Fbyte_code to handle new
1835 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1836
03408648 1837 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1838
03408648 1839 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1840
e2abce01
JB
18412011-03-31 Juanma Barranquero <lekktu@gmail.com>
1842
1843 * xdisp.c (redisplay_internal): Fix prototype.
1844
63696a73 18452011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1846
63696a73
EZ
1847 * xdisp.c (SCROLL_LIMIT): New macro.
1848 (try_scrolling): Use it when setting scroll_limit. Limit
1849 scrolling to 100 screen lines.
1850 (redisplay_window): Even when falling back on "recentering",
1851 position point in the window according to scroll-conservatively,
1852 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1853
1854 (try_scrolling): When point is above the window, allow searching
1855 as far as scroll_max, or one screenful, to compute vertical
1856 distance from PT to the scroll margin position. This prevents
1857 try_scrolling from unnecessarily failing when
1858 scroll-conservatively is set to a value slightly larger than the
1859 window height. Clean up the case of PT below the margin at bottom
1860 of window: scroll_max can no longer be INT_MAX. When aggressive
1861 scrolling is in use, don't let point enter the opposite scroll
1862 margin as result of the scroll.
1863 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1864 threshold of 100 lines for never-recentering scrolling.
1865
e4cc2dfc
JB
18662011-03-31 Juanma Barranquero <lekktu@gmail.com>
1867
1868 * dispextern.h (move_it_by_lines):
1869 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1870 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1871 (message_log_check_duplicate): Remove parameters `prev_bol' and
1872 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1873 (redisplay_internal): Remove parameter `preserve_echo_area',
1874 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1875
1876 * indent.c (Fvertical_motion):
1877 * window.c (window_scroll_pixel_based, Frecenter):
1878 Don't pass `need_y_p' to `move_it_by_lines'.
1879
1c470562
SM
18802011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1881
44f230aa
SM
1882 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1883 steal a few bits to be more compact.
1884 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1885 Remove unneeded casts.
1886
1c470562
SM
1887 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1888
888adce9
ZK
18892011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1890
1891 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1892 binding" message (bug#7967).
1893
f838ed7b
PE
18942011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1895
77861b95
PE
1896 Fix more problems found by GCC 4.6.0's static checks.
1897
de6dbc14
PE
1898 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1899 Remove unused local var.
1900
f838ed7b
PE
1901 * editfns.c (Fmessage_box): Remove unused local var.
1902
792c7b2b
PE
1903 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1904 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1905 Omit unused local vars.
c499e557 1906 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1907 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1908 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1909 Omit unused local var.
1910
ba0165e1
PE
1911 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1912 Don't assume string length fits in int.
32ad8845 1913 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1914 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1915
3c59b4c9
PE
1916 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1917 instead of alloca (Bug#8344).
1918
a3eed478 1919 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1920 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1921
eb4d412d
PE
1922 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1923
1658b401
PE
1924 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1925 concerns.
1926
1927 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1928
1929 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1930
9a2c6e05
PE
1931 * keyboard.c (syms_of_keyboard): Use the same style as later
1932 in this function when indexing through an array. This also
1933 works around GCC bug 48267.
1934
03d0a109
PE
1935 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1936
44f730c8
PE
1937 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1938
fe75f926
PE
1939 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1940 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1941
ffa8c828
PE
1942 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1943 This avoids undefined behavior on integer overflow, and is a bit
1944 more convenient anyway since it is compared to a size_t variable.
1945
c5101a77
PE
1946 Variadic C functions now count arguments with size_t, not int.
1947 This avoids an unnecessary limitation on 64-bit machines, which
1948 caused (substring ...) to crash on large vectors (Bug#8344).
1949 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1950 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1951 All variadic functions and their callers changed accordingly.
c5101a77
PE
1952 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1953 * data.c (arith_driver, float_arith_driver): Likewise.
1954 * editfns.c (general_insert_function): Likewise.
1955 * eval.c (struct backtrace.nargs, interactive_p)
1956 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1957 (funcall_lambda, mark_backtrace): Likewise.
1958 * fns.c (concat): Likewise.
1959 * frame.c (x_set_frame_parameters): Likewise.
1960 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1961 0 if not found, not -1. All callers changed.
1962
dd3f25f7
PE
1963 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1964 (stack_copy_size): Now size_t, not int.
1965 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1966
461c2ab9
JB
19672011-03-28 Juanma Barranquero <lekktu@gmail.com>
1968
1969 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1970 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1971 All callers changed.
1972
1973 * lisp.h (multibyte_char_to_unibyte):
1974 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1975 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1976 * character.h (CHAR_TO_BYTE8):
1977 * cmds.c (internal_self_insert):
1978 * editfns.c (general_insert_function):
1979 * keymap.c (push_key_description):
1980 * search.c (Freplace_match):
1981 * xdisp.c (message_dolog, set_message_1): All callers changed.
1982
f6d62986
SM
19832011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1984
1985 * keyboard.c (safe_run_hook_funcall): New function.
1986 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1987 don't set the hook to nil, but remove the offending function instead.
1988 (Qcommand_hook_internal): Remove, unused.
1989 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1990 Vcommand_hook_internal.
1991
1992 * eval.c (enum run_hooks_condition): Remove.
1993 (funcall_nil, funcall_not): New functions.
1994 (run_hook_with_args): Call each function through a `funcall' argument.
1995 Remove `cond' argument, now redundant.
1996 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1997 (Frun_hook_with_args_until_failure): Adjust accordingly.
1998 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1999
1db5b1ad
JB
20002011-03-28 Juanma Barranquero <lekktu@gmail.com>
2001
2002 * dispextern.h (string_buffer_position): Remove declaration.
2003
2004 * print.c (strout): Remove parameter `multibyte', unused since
2005 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2006
2007 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2008 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2009 All callers changed.
2010
2011 * w32.c (_wsa_errlist): Use braces for struct initializers.
2012
2013 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2014 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2015 All callers changed.
2016 (string_buffer_position): Likewise. Also, make static (it's never
2017 used outside xdisp.c).
2018 (cursor_row_p): Remove parameter `w', unused since
2019 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2020 (decode_mode_spec): Remove parameter `precision', introduced during
2021 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2022 All callers changed.
2023
5ffb62aa
JD
20242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2025
2026 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2027
461c2ab9 20282011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2029
2030 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2031 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2032 (ns_update_auto_hide_menu_bar): New functions.
2033 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2034 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2035 ns_constrain_all_frames.
2036 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2037 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2038
5c380ffb
JD
20392011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2040
2041 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2042
9af30bdf
GM
20432011-03-27 Glenn Morris <rgm@gnu.org>
2044
2045 * syssignal.h: Replace RETSIGTYPE with void.
2046 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2047 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2048 Replace SIGTYPE with void everywhere.
2049 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2050 * s/template.h (SIGTYPE): Remove commented out definition.
2051
e2abce01
JB
20522011-03-26 Eli Zaretskii <eliz@gnu.org>
2053
2054 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2055 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2056
f868cd8a
JB
20572011-03-26 Juanma Barranquero <lekktu@gmail.com>
2058
59eb0929
JB
2059 * w32.c (read_unc_volume): Use parameter `henum', instead of
2060 global variable `wget_enum_handle'.
2061
2062 * keymap.c (describe_vector): Remove parameters `indices' and
2063 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2064 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2065
f868cd8a
JB
2066 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2067
2068 * keyboard.c (timer_check): Remove parameter `do_it_now',
2069 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2070 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2071 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2072
2073 * keyboard.c (read_char):
2074 * w32menu.c (w32_menu_display_help):
2075 * xmenu.c (show_help_event, menu_help_callback):
2076 Adjust calls to `show_help_echo'.
2077
2078 * gtkutil.c (xg_maybe_add_timer):
2079 * keyboard.c (readable_events):
2080 * process.c (wait_reading_process_output):
2081 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2082
2083 * insdel.c (adjust_markers_gap_motion):
2084 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2085 (gap_left, gap_right): Don't call it.
2086
2ecf6fdb
CY
20872011-03-25 Chong Yidong <cyd@stupidchicken.com>
2088
2089 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2090 incurred during fontification.
2091
6b1f9ba4
JB
20922011-03-25 Juanma Barranquero <lekktu@gmail.com>
2093
2094 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2095 (DEFVAR_PER_BUFFER): Don't pass it.
2096
2097 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2098 (scrolling_window): Don't pass it.
2099
0f4a96b5
JB
21002011-03-25 Juanma Barranquero <lekktu@gmail.com>
2101
2102 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2103
2104 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2105 and `suffix'.
2106 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2107 of variables specific to SELinux and computation of `encoded_absname'.
2108
2109 * image.c (XPutPixel): Remove unused variable `height'.
2110
2111 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2112
2113 * unexw32.c (get_section_info): Remove unused variable `section'.
2114
2115 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2116 (system_process_attributes): Remove unused variable `sess'.
2117 (sys_read): Remove unused variable `err'.
2118
2119 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2120 (w32_wnd_proc): Remove unused variable `isdead'.
2121 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2122 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2123 (x_create_tip_frame): Remove unused variable `tem'.
2124
2125 * w32inevt.c (w32_console_read_socket):
2126 Remove unused variable `no_events'.
2127
2128 * w32term.c (x_draw_composite_glyph_string_foreground):
2129 Remove unused variable `width'.
2130
1149507c
JB
21312011-03-24 Juanma Barranquero <lekktu@gmail.com>
2132
2133 * w32term.c (x_set_glyph_string_clipping):
2134 Don't pass uninitialized region to CombineRgn.
2135
9c88f339
JB
21362011-03-23 Juanma Barranquero <lekktu@gmail.com>
2137
2138 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2139 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2140 (Fx_close_connection): Remove unused variable `i'.
2141
2142 * w32font.c (w32font_draw): Return number of glyphs.
2143 (w32font_open_internal): Remove unused variable `i'.
2144 (w32font_driver): Add missing initializer.
2145
2146 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2147 (fill_in_menu): Remove unused variable `items_added'.
2148
2149 * w32term.c (last_mouse_press_frame): Remove static global variable.
2150 (w32_clip_to_row): Remove unused variable `f'.
2151 (x_delete_terminal): Remove unused variable `i'.
2152
2153 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2154 (NOTHING): Remove unused static global variable.
2155 (uniscribe_check_otf): Remove unused variable `table'.
2156 (uniscribe_font_driver): Add missing initializers.
2157
dee091a3
JD
21582011-03-23 Julien Danjou <julien@danjou.info>
2159
2160 * term.c (Fsuspend_tty, Fresume_tty):
2161 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2162 * window.c (temp_output_buffer_show):
2163 * insdel.c (signal_before_change):
2164 * frame.c (Fhandle_switch_frame):
2165 * fileio.c (Fdo_auto_save):
2166 * emacs.c (Fkill_emacs):
2167 * editfns.c (save_excursion_restore):
2168 * cmds.c (internal_self_insert):
2169 * callint.c (Fcall_interactively):
2170 * buffer.c (Fkill_all_local_variables):
2171 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2172 Use Frun_hooks.
0f4a96b5 2173 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2174 unconditionnaly since it does the check itself.
2175
2c520ab5 21762011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2177
c9c49752
PE
2178 Fix more problems found by GCC 4.5.2's static checks.
2179
8abc3f12
PE
2180 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2181 the first time through the loop, since we know p0 < p1 then.
2182 This also avoids a gcc -Wstrict-overflow warning.
2183
a2d26660
PE
2184 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2185 leading to a memory leak, possible in functions like
2186 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2187 of objects (Bug#8318).
a2d26660 2188
916c72e9
PE
2189 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2190 that could (at least in theory) be that large.
2191
19ab8a18
PE
2192 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2193 This is less likely to overflow, and avoids undefined behavior if
2194 overflow does occur. All callers changed. Use strtoul to scan
2195 for the unsigned long integer.
b7cbbd6f
PE
2196 (pint2hrstr): Simplify and tune code slightly.
2197 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2198
f0641eff
PE
2199 * scroll.c (do_scrolling): Work around GCC bug 48228.
2200 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2201
7f650bb9
PE
2202 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2203 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2204 (validate_x_resource_name): Simplify count usage.
2205 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2206
37dd57d1
PE
2207 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2208 fail (Bug#8306).
81e56e61 2209
699979fc 2210 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2211
401bf9b4
PE
2212 * process.c (Fmake_network_process): Use socklen_t, not int,
2213 where POSIX says socklen_t is required in portable programs.
2214 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2215 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2216 (Fmake_network_process, server_accept_connection):
2217 (wait_reading_process_output, read_process_output):
2218 Likewise.
2219
b93aacde
PE
2220 * process.c: Rename or move locals to avoid shadowing.
2221 (list_processes_1, Fmake_network_process):
2222 (read_process_output_error_handler, exec_sentinel_error_handler):
2223 Rename or move locals.
4dc343ee 2224 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2225 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2226 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2227 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2228 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2229
af8a867c 2230 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2231 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2232 Include tparam.h instead, since it declares them.
af8a867c
PE
2233 * cm.h (PC): Remove extern decl; tparam.h now does this.
2234 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2235 * terminfo.c: Include tparam.h, to check interfaces.
2236 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2237 (tparam): Adjust signature to match interface in tparam.h;
2238 this removes some undefined behavior. Check that outstring and len
2239 are zero, which they always are with Emacs.
2240 * tparam.h (PC, BC, UP): New extern decls.
2241
0248044d 2242 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2243 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2244
8ff096c1 2245 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2246 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2247 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2248 (ftfont_list): Remove unused local.
49eaafba
PE
2249 (get_adstyle_property, ftfont_pattern_entity):
2250 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2251 Rename locals to avoid shadowing.
8ff096c1 2252
e2be39f6
PE
2253 * xfont.c (xfont_list_family): Mark var as initialized.
2254
c9735e30
PE
2255 * xml.c (make_dom): Now static.
2256
8f5201ae
PE
2257 * composite.c (composition_compute_stop_pos): Rename local to
2258 avoid shadowing.
b246f932
PE
2259 (composition_reseat_it): Remove unused locals.
2260 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2261 (composition_update_it): Mark var as initialized.
11b61122
PE
2262 (find_automatic_composition): Mark vars as initialized,
2263 with a FIXME (Bug#8290).
8f5201ae 2264
760fbc2c
PE
2265 character.h: Rename locals to avoid shadowing.
2266 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2267 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2268 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2269 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2270 to avoid shadowing.
2271
ff08eb85
PE
2272 * textprop.c (property_change_between_p): Remove; unused.
2273
fc7bf025
PE
2274 * intervals.c (interval_start_pos): Now static.
2275
235d7abc
PE
2276 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2277
44f230aa
SM
2278 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2279 Rename locals to avoid shadowing.
3e7d6594 2280
50060332
PE
2281 * sound.c (wav_play, au_play, Fplay_sound_internal):
2282 Fix pointer signedness.
d01f234b 2283 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2284 (wav_play): Initialize a variable to 0, to prevent undefined
2285 behavior (Bug#8278).
50060332 2286
c4fc4e30
PE
2287 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2288
918436ed
PE
2289 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2290
c939f91b
PE
2291 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2292 clobbering (Bug#8298).
b9c7f648
PE
2293 * sysdep.c (sys_subshell): Likewise.
2294 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2295
6bd8c144
PE
2296 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2297 This should get cleaned up, so that child_setup has the
2298 same signature on all platforms.
2299
7710357c 2300 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2301 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2302
c59da222
CY
23032011-03-22 Chong Yidong <cyd@stupidchicken.com>
2304
2305 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2306 not to be necessary, and produces flickering.
2307
66b87493
GM
23082011-03-20 Glenn Morris <rgm@gnu.org>
2309
2310 * config.in: Remove file.
2311
45b6f6d5
JB
23122011-03-20 Juanma Barranquero <lekktu@gmail.com>
2313
2314 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2315 are now in src/globals.h.
2316 (syms_of_minibuf): Remove spurious & from previous change.
2317
3ec03f7e
LL
23182011-03-20 Leo <sdl.web@gmail.com>
2319
2320 * minibuf.c (completing-read-function): New variable.
2321 (completing-read-default): Rename from completing-read.
2322 (completing-read): Call completing-read-function.
2323
b14e3e21
CY
23242011-03-19 Juanma Barranquero <lekktu@gmail.com>
2325
2326 * xfaces.c (Fx_load_color_file):
2327 Read color file from absolute filename (bug#8250).
2328
f2b726e6
JB
23292011-03-19 Juanma Barranquero <lekktu@gmail.com>
2330
2331 * makefile.w32-in: Update dependencies.
2332
09f6ff02
EZ
23332011-03-17 Eli Zaretskii <eliz@gnu.org>
2334
2335 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2336
29a6015a
PE
23372011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2338
a3a6c54e
PE
2339 Fix more problems found by GCC 4.5.2's static checks.
2340
b766f867
PE
2341 * process.c (make_serial_process_unwind, send_process_trap):
2342 (sigchld_handler): Now static.
2343
be02381c
PE
2344 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2345 That way, the code declares only the vars that it needs.
2346 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2347 * s/cygwin.h (PTY_ITERATION): Likewise.
2348 * s/darwin.h (PTY_ITERATION): Likewise.
2349 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2350
57048744
PE
2351 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2352 * process.c (allocate_pty): Don't declare stb unless it's needed.
2353
7914961c 2354 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2355 (CONSTANTLIM): Remove; unused.
2356 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2357 Define only if needed.
7914961c 2358
b3967b18
PE
2359 * unexelf.c (unexec): Name an expression,
2360 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2361 Use a different way to cause a compilation error if anyone uses
2362 n rather than nn, a way that does not involve shadowing.
73366a00 2363 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2364
29a6015a
PE
2365 * deps.mk (unexalpha.o): Remove; unused.
2366
43cfc33e 2367 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2368 * unexec.h: New file.
ce701a33
PE
2369 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2370 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2371 Depend on unexec.h.
2372 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2373 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2374 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2375 Change as necessary to match prototype in unexec.h.
ce701a33 2376
01f44d5a
PE
2377 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2378 shadowing.
4f63c6bb 2379 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2380
a6670b0b
PE
2381 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2382 Rename locals to avoid shadowing.
2383
cef2010d 2384 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2385 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2386
d4d7173a
PE
2387 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2388
f08b802a
PE
2389 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2390 warning when compiling print.c.
2391
3ddb0639
PE
2392 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2393 instead of using an uninitialized var.
5ad03b97 2394 (font_sort_entities): Mark var as initialized.
3ddb0639 2395
170a2692
PE
2396 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2397
e663c700
PE
2398 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2399 pointers to constants.
89bc529a 2400 (font_parse_fcname): Remove unused vars.
7b81e2d0 2401 (font_delete_unmatched): Now static.
ea838e10 2402 (font_get_spec): Remove; unused.
13a547c6
PE
2403 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2404 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2405 Rename or move locals to avoid shadowing.
e663c700 2406
2a80c887 2407 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2408 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2409
1384fa33 2410 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2411 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2412
8b2c52e9
PE
2413 * alloc.c (mark_backtrace): Move decl from here ...
2414 * lisp.h: ... to here, so that it can be checked.
2415
475545b5 2416 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2417 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2418 (lisp_indirect_variable): Name an expression,
2419 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2420 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2421
b1349114 2422 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2423 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2424 Use const pointer when appropriate.
b1349114 2425
a2928364
PE
2426 * lisp.h (get_system_name, get_operating_system_release):
2427 Move decls here, to check interfaces.
2428 * process.c (get_operating_system_release): Move decl to lisp.h.
2429 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2430 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2431 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2432 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2433 (Fformat_time_string, Fencode_time, Finsert_char):
2434 (Ftranslate_region_internal, Fformat):
2435 Rename or remove local vars to avoid shadowing.
9710023e 2436 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2437
a415e694
PE
2438 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2439 avoid shadowing.
2440
8ef4622d
PE
2441 * lisp.h (eassert): Check that the argument compiles, even if
2442 ENABLE_CHECKING is not defined.
2443
946f9a5b
PE
2444 * data.c (Findirect_variable): Name an expression, to avoid
2445 gcc -Wbad-function-cast warning.
112396d6 2446 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2447 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2448 (Fmake_variable_buffer_local, Fmake_local_variable):
2449 Mark variables as initialized.
52746918 2450 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2451
e5aab7e7 2452 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2453 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2454 Rename locals to avoid shadowing.
dff45157
PE
2455 (mark_stack): Move local variables into the #ifdef region where
2456 they're used.
7bc26fdb
PE
2457 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2458 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2459 needed otherwise.
2460 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2461 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2462 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2463
e5aab7e7
PE
2464 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2465 avoids undefined behavior in theory.
2466
4da60324
PE
2467 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2468
88043301
PE
2469 Use functions, not macros, for up- and down-casing (Bug#8254).
2470 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2471 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2472 to use the following functions instead of these macros.
2473 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2474 EMACS_INT, since callers assume the returned value fits in int.
2475 (upcase1): Likewise, for UPCASE_TABLE.
2476 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2477 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2478 the race-condition problem in the old DOWNCASE.
88043301 2479
19ed5445
PE
2480 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2481 Rename locals to avoid shadowing.
2482 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2483 (regex_compile, re_search_2, re_match_2_internal):
2484 Remove unused local vars.
952db0d7
PE
2485 (FREE_VAR): Rewrite so as not to use empty "else",
2486 which gcc can warn about.
da053e48 2487 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2488 (RETALLOC_IF): Define only if needed.
2489 (WORDCHAR_P): Likewise. This one is never needed, but is used
2490 only in a comment talking about a compiler bug, so put inside
2491 the #if 0 of that comment.
2492 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2493 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2494 Remove; unused.
19ed5445 2495
1f3561e4 2496 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2497 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2498 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2499
ded6f8f7
PE
2500 * search.c (simple_search): Remove unused var.
2501
dbd37a95
PE
2502 * dired.c (compile_pattern): Move decl from here ...
2503 * lisp.h: ... to here, so that it can be checked.
2504 (struct re_registers): New forward decl.
2505
7e47afad
PE
2506 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2507
85f24f61
PE
2508 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2509 All uses changed.
2510 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2511 Rename locals to avoid shadowing.
5671df8f 2512 (Fvertical_motion): Mark locals as initialized.
85f24f61 2513
181aa2be 2514 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2515 (casify_region): Mark local as initialized.
181aa2be 2516
930d429c
PE
2517 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2518
7082eac6
PE
2519 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2520 New macros, so that the caller can use some names other than
2521 gcpro1, gcpro2, etc.
2522 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2523 of the new macros.
2524 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2525 argument, for consistency with GCPRO2_VAR, etc: it is now the
2526 prefix of the variable, not the variable itself. All uses
2527 changed.
38b2c076
PE
2528 * dired.c (directory_files_internal, file_name_completion):
2529 Rename locals to avoid shadowing.
2530
15206ed9
PE
2531 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2532 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2533 dired.c's scmp function, had undefined behavior.
2534 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2535 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2536 * buffer.h: ... to here, because these macros use current_buffer,
2537 and the new implementation with inline functions needs to have
2538 current_buffer in scope now, rather than later when the macros
2539 are used.
2540 (downcase, upcase1): New static inline functions.
2541 (DOWNCASE, UPCASE1): Reimplement using these functions.
2542 This avoids undefined behavior in expressions like
2543 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2544 from race conditions in accessing the global variables
2545 case_temp1 and case_temp2.
2546 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2547 * lisp.h (case_temp1, case_temp2): Remove their decls.
2548 * character.h (ASCII_CHAR_P): Move from here ...
2549 * lisp.h: ... to here, so that the inline functions mentioned
2550 above can use them.
2551
4a6bea26
PE
2552 * dired.c (directory_files_internal_unwind): Now static.
2553
f14b7e14
PE
2554 * fileio.c (file_name_as_directory, directory_file_name):
2555 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2556 Now static.
2893f146
PE
2557 (file_name_as_directory): Use const pointers when appropriate.
2558 (Fexpand_file_name): Likewise. In particular, newdir might
2559 point at constant storage, so make it a const pointer.
fd4ead52 2560 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2561 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2562 signedness issues.
f839df0c
PE
2563 (Fset_file_times, Finsert_file_contents, auto_save_error):
2564 Rename locals to avoid shadowing.
f14b7e14 2565
5716756e 2566 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2567 (Ftry_completion, Fall_completions): Rename or remove locals
2568 to avoid shadowing.
5716756e 2569
b4c3046a
PE
2570 * marker.c (bytepos_to_charpos): Remove; unused.
2571
b45db522
PE
2572 * lisp.h (verify_bytepos, count_markers): New decls,
2573 so that gcc does not warn that these functions aren't declared.
2574
85876d07
PE
2575 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2576 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2577 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2578 (copy_text): Remove unused local var.
85876d07 2579
03d78a21 2580 * filelock.c (within_one_second): Now static.
b3dd38ab 2581 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2582
5df8f01b
PE
2583 * buffer.c (fix_overlays_before): Mark locals as initialized.
2584 (fix_start_end_in_overlays): Likewise. This function should be
2585 simplified by using pointers-to-pointers, but that's a different
2586 matter.
b1d876f1 2587 (switch_to_buffer_1): Now static.
8f54f30a
PE
2588 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2589 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2590
a70072c9 2591 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2592 Fix pointer signedness issue.
edced198
PE
2593 (sys_subshell): Mark local as volatile if checking for lint,
2594 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2595 (MAXPATHLEN): Define only if needed.
a70072c9 2596
a0977c44
PE
2597 * process.c (serial_open, serial_configure): Move decls from here ...
2598 * systty.h: ... to here, so that they can be checked.
2599
a884fdcc
PE
2600 * fns.c (get_random, seed_random): Move extern decls from here ...
2601 * lisp.h: ... to here, so that they can be checked.
2602
604efe86 2603 * sysdep.c (reset_io): Now static.
b8950c94 2604 (wait_for_termination_signal): Remove; unused.
604efe86 2605
38fc62d9
PE
2606 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2607 (copy_keymap_item, append_key, push_text_char_description):
2608 Now static.
1004a21a 2609 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2610 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2611 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2612 (describe_map_tree):
2613 Rename locals to avoid shadowing.
38fc62d9 2614
2f2650da
PE
2615 * keyboard.c: Declare functions static if they are not used elsewhere.
2616 (echo_char, echo_dash, cmd_error, top_level_2):
2617 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2618 (read_char, kbd_buffer_get_event, make_lispy_position):
2619 (make_lispy_event, make_lispy_movement, apply_modifiers):
2620 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2621 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2622 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2623 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2624 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2625
a053e86c 2626 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2627 (mark_kboards): Move decl here ...
2628 * alloc.c (mark_kboards): ... from here.
a053e86c 2629
4752793e
PE
2630 * lisp.h (force_auto_save_soon): New decl.
2631
74f10ca7 2632 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2633 (DEFINE_DUMMY_FUNCTION): New macro.
2634 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2635 Use it.
c03cd23f
PE
2636 (main): Add casts to avoid warnings
2637 if GCC considers string literals to be constants.
74f10ca7 2638
022e70d4
PE
2639 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2640
59d6fe83
PE
2641 * dbusbind.c: Pointer signedness fixes.
2642 (xd_signature, xd_append_arg, xd_initialize):
2643 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2644 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2645 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2646 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2647
78320123
PE
2648 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2649 if GCC considers string literals to be constants.
49cebcca 2650 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2651
35ac2a97
SM
26522011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2653
fb103ca9
SM
2654 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2655 (print_preprocess, print_object): New macro to fix last change.
2656
35ac2a97
SM
2657 * print.c (print_preprocess): Don't forget font objects.
2658
62973b41
JB
26592011-03-16 Juanma Barranquero <lekktu@gmail.com>
2660
2661 * emacs.c (USAGE3): Doc fixes.
2662
0e48bb22
AS
26632011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2664
2665 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2666 structure.
2667
7684e57b
JB
26682011-03-14 Juanma Barranquero <lekktu@gmail.com>
2669
2670 * lisp.h (VWindow_system, Qfile_name_history):
2671 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2672 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2673 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2674
2675 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2676 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2677
2678 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2679 * w32console.c (detect_input_pending, read_input_pending)
2680 (encode_terminal_code):
2681 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2682 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2683 (w32_system_caret_y, Qfile_name_history):
2684 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2685 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2686 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2687 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2688 * w32proc.c (Qlocal, report_file_error):
2689 * w32term.c (Vwindow_system, updating_frame):
2690 * w32uniscribe.c (initialized, uniscribe_font_driver):
2691 Remove unneeded extern declarations.
2692
2aa46d6c
CY
26932011-03-14 Chong Yidong <cyd@stupidchicken.com>
2694
c96bbc66 2695 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2696
cffc6f3b
CY
26972011-03-13 Chong Yidong <cyd@stupidchicken.com>
2698
2699 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2700 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2701 These macros can no longer be used for assignment.
2702
44f230aa
SM
2703 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2704 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2705 (record_buffer_markers, fetch_buffer_markers): New functions for
2706 recording and fetching special buffer markers.
2707 (set_buffer_internal_1, set_buffer_temp): Use them.
2708
2709 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2710
2711 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2712
2713 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2714 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2715
2716 * xdisp.c (hscroll_window_tree):
2717 (reconsider_clip_changes): Use PT instead of BUF_PT.
2718
d251f04b
EZ
27192011-03-13 Eli Zaretskii <eliz@gnu.org>
2720
2721 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2722 $(EMACS_ROOT)/lib/intprops.h.
2723
f0c77cd1
PE
27242011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2725
3eca4629
PE
2726 Fix more problems found by GCC 4.5.2's static checks.
2727
7c86ee98
PE
2728 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2729 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2730 (xg_free_frame_widgets): Make it clear that a local variable is
2731 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2732 (gdk_window_get_screen): Make it clear that this macro is needed
2733 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2734 (int_gtk_range_get_value): New function, which avoids a diagnostic
2735 from gcc -Wbad-function-cast.
2736 (xg_set_toolkit_scroll_bar_thumb): Use it.
2737 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2738 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2739 (get_utf8_string, xg_get_file_with_chooser):
2740 Rename locals to avoid shadowing.
2741 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2742
41729b81
PE
2743 * xgselect.c (xg_select): Remove unused var.
2744
f0c77cd1
PE
2745 * image.c (four_corners_best): Mark locals as initialized.
2746 (gif_load): Initialize transparent_p to zero (Bug#8238).
2747 Mark another local as initialized.
ec6cf4c6 2748 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2749
ce0ad53d 2750 * image.c (clear_image_cache): Now static.
d5d5a617 2751 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2752 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2753 (x_edge_detection): Remove unnecessary cast that
2754 gcc -Wbad-function-cast diagnoses.
2037898d 2755 (gif_load): Fix pointer signedness.
6ae141d6
PE
2756 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2757 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2758
33383987 27592011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2760
d32df629
PE
2761 Improve quality of tests for time stamp overflow.
2762 For example, without this patch (encode-time 0 0 0 1 1
2763 1152921504606846976) returns the obviously-bogus value (-948597
2764 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2765 reports time overflow. See
2766 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2767 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2768 * editfns.c: Include limits.h and intprops.h.
2769 (TIME_T_MIN, TIME_T_MAX): New macros.
2770 (time_overflow): Move earlier, to before first use.
2771 (hi_time, lo_time): New functions, for an accurate test for
2772 out-of-range times.
2773 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2774 (Fget_internal_run_time): Don't assume time_t fits in int.
2775 (make_time): Use list2 instead of Fcons twice.
2776 (Fdecode_time): More accurate test for out-of-range times.
2777 (check_tm_member): New function.
2778 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2779 (lisp_time_argument): Don't rely on undefined left-shift and
2780 right-shift behavior when checking for time stamp overflow.
8be6f318 2781
fe31d94c
PE
2782 * editfns.c (time_overflow): New function, refactoring common code.
2783 (Fformat_time_string, Fdecode_time, Fencode_time):
2784 (Fcurrent_time_string): Use it.
2785
8be6f318
PE
2786 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2787 * dired.c (make_time): Move to ...
2788 * editfns.c (make_time): ... here.
2789 * systime.h: Note the move.
2790
09d9db2c 27912011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2792
126bc0dc
YM
2793 * fringe.c (update_window_fringes): Remove unused variables.
2794
c47cbdfd
YM
2795 * unexmacosx.c (copy_data_segment): Also copy __got section.
2796 (Bug#8223)
2797
7ac80be9
EZ
27982011-03-12 Eli Zaretskii <eliz@gnu.org>
2799
c96bbc66 2800 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2801 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2802 Constify `char *' arguments and their references according to
2803 prototypes in tparam.h.
2804
ecb0f94d 2805 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2806
7ac80be9
EZ
2807 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2808 Adapt all references accordingly.
2809
2810 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2811
ef1fd07e
TT
28122011-03-11 Tom Tromey <tromey@redhat.com>
2813
2814 * buffer.c (syms_of_buffer): Remove obsolete comment.
2815
7ef4b50c
EZ
28162011-03-11 Eli Zaretskii <eliz@gnu.org>
2817
2818 * termhooks.h (encode_terminal_code): Declare prototype.
2819
2820 * msdos.c (encode_terminal_code): Don't declare prototype.
2821
2822 * term.c (encode_terminal_code): Now external again, used by
2823 w32console.c and msdos.c.
2824
44f230aa
SM
2825 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2826 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2827
4b1ec863 28282011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2829
1714f52b 2830 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2831
4b1ec863
PE
2832 * fringe.c (update_window_fringes): Mark locals as initialized
2833 (Bug#8227).
2834 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2835
524c7aa6
PE
2836 * alloc.c (mark_fringe_data): Move decl from here ...
2837 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2838 to check its interface.
2839 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2840
a5c0af81 2841 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2842 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2843 (fontset_font): Mark local as initialized.
a9a06e0b 2844 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2845
b4716021
PE
2846 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2847
811e9bac 2848 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2849 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2850 (x_own_selection, Fx_disown_selection_internal): Rename locals
2851 to avoid shadowing.
2852 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2853
7e3ab302
PE
2854 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2855 so that the caller can use some name other than gcpro1.
2856 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2857 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2858 (Fx_backspace_delete_keys_p):
2859 Use them to avoid shadowing, and rename vars to avoid shadowing.
2860 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2861 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2862 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2863 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2864 Remove unused locals.
7e3ab302
PE
2865 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2866 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2867 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2868 macros.
f78faa98 2869
e2b13473
PE
2870 * xterm.h (x_mouse_leave): New decl.
2871
77f23912
PE
2872 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2873 Remove unused functions.
cdf4ba58
PE
2874 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2875 (x_calc_absolute_position): Now static.
7411c686 2876 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2877 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2878 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2879 unless they are used.
38d0b34a
PE
2880 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2881 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2882 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2883 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2884 (x_error_catcher, x_connection_closed, x_error_handler):
2885 (x_error_quitter, xembed_send_message, x_iconify_frame):
2886 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2887 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2888 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2889
44f230aa
SM
2890 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2891 Rename or move locals to avoid shadowing.
6b463e58 2892 (tty_defined_color, merge_face_heights): Now static.
5967d051 2893 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2894 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2895 does not deduce is never used uninitialized.
73719eba
PE
2896 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2897 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2898
426994c3 2899 * terminal.c (store_terminal_param): Now static.
5489860b 2900
032f1620 2901 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2902 (set_frame_menubar): Remove unused local.
d4323972 2903 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2904 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2905 since they might point to immutable storage.
281585b0
PE
2906 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2907 since it's unused otherwise.
032f1620 2908
367c19e5 2909 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2910 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2911 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2912 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2913 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2914 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2915 does not deduce are never used uninitialized.
70739cbe 2916
07b48fa9
PE
2917 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2918
8868a238 2919 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2920 * window.c (window_loop, size_window):
2921 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2922
7e5cf297 2923 * window.c (display_buffer): Now static.
d6550a9f
PE
2924 (size_window): Mark variables that gcc -Wuninitialized
2925 does not deduce are never used uninitialized.
a586633d
PE
2926 * window.h (check_all_windows): New decl, to forestall
2927 gcc -Wmissing-prototypes diagnostic.
5b555da1 2928 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2929
f6095868
PE
2930 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2931 shadowing.
2932 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2933 Include <limits.h>.
2934 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2935 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2936 (load_charset_map): Mark variables that gcc -Wuninitialized
2937 does not deduce are never used uninitialized.
53df7c11 2938 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2939
f38b440c
PE
2940 * coding.c (coding_set_source, coding_set_destination):
2941 Use "else { /* comment */ }" rather than "else /* comment */;"
2942 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2943 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2944 a block, when the outer 'i' will do.
2945 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2946 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2947 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2948 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2949 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2950 Rename locals to avoid shadowing.
2951 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2952 * coding.c (emacs_mule_char, encode_invocation_designation):
2953 Now static, since they're not used elsewhere.
413bb2db 2954 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2955 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2956 (decode_coding_emacs_mule): Mark variables that gcc
2957 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2958 (detect_coding_iso_2022): Initialize a local variable that might
2959 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2960 this initialization is needed. (Bug#8211)
5f58e762
PE
2961 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2962 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2963 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2964 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2965 Remove unused macros.
f38b440c 2966
232b38b9 2967 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2968 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2969 * character.c (string_count_byte8): Likewise.
232b38b9 2970
fb90da1b
PE
2971 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2972 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2973
fb93dbc2
PE
2974 * chartab.c (copy_sub_char_table): Now static, since it's not used
2975 elsewhere.
5c156ace
PE
2976 (sub_char_table_ref_and_range, char_table_ref_and_range):
2977 Rename locals to avoid shadowing.
bbcd0949 2978 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2979
7d3b3862 2980 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2981 (BIDI_BOB): Remove unused macro.
7d3b3862 2982
6be7d3da
PE
2983 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2984 deduce are never used uninitialized.
c2ed9c8b 2985 * term.c (encode_terminal_code): Likewise.
6be7d3da 2986
75f8807f 2987 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2988
50938595
PE
2989 * tparam.h: New file.
2990 * term.c, tparam.h: Include it.
2991 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2992 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2993 Move these decls to tparam.h, and make them agree with what
2994 is actually in tparam.c. The previous trick of using incompatible
2995 decls in different modules does not conform to the C standard.
2996 All callers of tparam changed to use tparam's actual API.
2997 * tparam.c (tparam1, tparam, tgoto):
2998 Use const pointers where appropriate.
2999
fbceeba2
PE
3000 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3001 * cm.h (struct cm): Likewise.
3002 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3003 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3004 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3005 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3006 (turn_on_face, init_tty): Likewise.
3007 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3008
7f3f1250
PE
3009 * term.c (term_mouse_position): Rename local to avoid shadowing.
3010
e6ca6543
PE
3011 * alloc.c (mark_ttys): Move decl from here ...
3012 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3013
c40f8d15
AS
30142011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3015
3016 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3017
cfe0661d
JB
30182011-03-09 Juanma Barranquero <lekktu@gmail.com>
3019
3020 * search.c (compile_pattern_1): Remove argument regp, unused since
3021 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3022 (compile_pattern): Don't pass it.
3023
0afb4571
J
30242011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3025
3026 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3027 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3028 for ! HAVE_GTK3.
3029 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3030
3031 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3032
3033 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3034 gdk_window_get_screen, gdk_window_get_geometry,
3035 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3036 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3037 (xg_get_pixbuf_from_pixmap): New function.
3038 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3039 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3040 Call xg_get_pixbuf_from_pixmap instead of
3041 gdk_pixbuf_get_from_drawable.
3042 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3043 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3044 (xg_check_special_colors): Use GtkStyleContext and its functions
3045 for HAVE_GTK3.
3046 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3047 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3048 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3049 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3050 Call gtk_widget_get_preferred_size.
0afb4571
J
3051 (xg_frame_resized): gdk_window_get_geometry only takes 5
3052 parameters.
44f230aa
SM
3053 (xg_win_to_widget, xg_event_is_for_menubar):
3054 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3055 (xg_set_widget_bg): New function.
3056 (delete_cb): New function.
895009e1 3057 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3058 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3059 (xg_set_background_color): Call xg_set_widget_bg.
3060 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3061 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3062 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3063 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3064 if ! HAVE_GTK3.
3065 (update_frame_tool_bar): Call gtk_widget_hide.
3066 (xg_initialize): Use GDK_KEY_g.
3067
3068 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3069 if ! HAVE_GTK3
3070 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3071
3072 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3073 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3074 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3075
1c2cc4ef
JB
30762011-03-08 Juanma Barranquero <lekktu@gmail.com>
3077
3078 * w32xfns.c (select_palette): Check success of RealizePalette against
3079 GDI_ERROR, not zero.
3080
33383987 3081See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3082
3083;; Local Variables:
3084;; coding: utf-8
aac0c6e3
MR
3085;; End:
3086
33383987 3087 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3088
3089 This file is part of GNU Emacs.
3090
3091 GNU Emacs is free software: you can redistribute it and/or modify
3092 it under the terms of the GNU General Public License as published by
3093 the Free Software Foundation, either version 3 of the License, or
3094 (at your option) any later version.
3095
3096 GNU Emacs is distributed in the hope that it will be useful,
3097 but WITHOUT ANY WARRANTY; without even the implied warranty of
3098 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3099 GNU General Public License for more details.
3100
3101 You should have received a copy of the GNU General Public License
3102 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.