* vc/ediff-diff.el (ediff-same-file-contents): Fix it for remote
[bpt/emacs.git] / src / ChangeLog
CommitLineData
36429c89
DA
12012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Cleanup basic buffer management.
4 * buffer.h (struct buffer): Change layout to use generic vector
5 marking code. Fix some comments. Change type of 'clip_changed'
6 to bitfield. Remove unused #ifndef old.
7 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
8 (GET_OVERLAYS_AT): Fix indentation.
9 (for_each_per_buffer_object_at): New macro.
10 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
11 (Fbuffer_local_variables): Use it.
12 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
13 * alloc.c (allocate_buffer): Adjust to match new layout of
14 struct buffer. Fix comment.
15 (mark_overlay): New function.
16 (mark_buffer): Use it. Use mark_vectorlike to mark normal
17 Lisp area of struct buffer.
18 (mark_object): Use it. Adjust marking of misc objects
19 and related comments.
20
3b3e4cac
PE
212012-07-02 Paul Eggert <eggert@cs.ucla.edu>
22
23 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
24 wrapper that is not needed because the wrapped code is a no-op (zero
25 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
26 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
27
cf5c0175
DA
282012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
29
30 * alloc.c (mark_buffer): Simplify. Remove prototype.
31 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 32 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
33 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
34 redundant calls to mark_vectorlike for bool vectors.
35
ca26824c
GM
362012-06-30 Glenn Morris <rgm@gnu.org>
37
2e4c5312
GM
38 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
39
ca26824c
GM
40 * epaths.in (PATH_SITELOADSEARCH): New.
41 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
42 This is rather than relying on --enable-locallisppath elements
43 having "site-lisp" in their names. (Bug#10208#25, 11658)
44
0d23c240
EZ
452012-06-30 Eli Zaretskii <eliz@gnu.org>
46
c9240d7a
EZ
47 * w32proc.c (sys_select): Accept and ignore one more argument.
48
49 * w32.c (emacs_gnutls_pull): Call select with one more argument.
50
0d23c240 51 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 52 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
53
54 * sysdep.c: Don't include dos.h and dosfns.h.
55
56 * process.c (sys_select):
57 * msdos.c (sys_select): Accept one more argument and ignore it.
58
59 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
60 adapt data types and code to that.
61
62 * dosfns.c:
63 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
64 which clashes with the gnulib function of the same name.
65
af5a5a98
AS
662012-06-30 Andreas Schwab <schwab@linux-m68k.org>
67
c5e4379c
AS
68 * font.c (font_style_to_value, font_style_symbolic)
69 (font_prop_validate_style): Add type checks for values in
70 font_style_table.
71
af5a5a98
AS
72 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
73 argument.
74 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
75 uses.
76
8d38f461
EZ
772012-06-29 Eli Zaretskii <eliz@gnu.org>
78
2e5a6631
EZ
79 * xdisp.c (try_window_id): Undo last change.
80
8d38f461
EZ
81 * w32.c (getwd): Adjust commentary about startup_dir.
82 (init_environment): Always call sys_access, even in non-MSVC
83 builds. Don't chdir to the directory of the Emacs executable.
84 This undoes code from 1997 which was justified by the need to
85 "avoid conflicts when removing and renaming directories". But its
86 downside was that every relative file name was being interpreted
87 relative to the directory of the Emacs executable, which can never
88 be TRT. In particular, it broke sys_access when called with
89 relative file names.
90 (sys_access): Map GetLastError to errno.
91
2af3565e
DA
922012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
93
94 * window.h (struct window): Change type of 'fringes_outside_margins'
95 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 96 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
97 Adjust comment.
98 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
99 to ptrdiff_t.
100
c8d3a25c 1012012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 102
c8d3a25c
GM
103 * gnutls.c (emacs_gnutls_handshake):
104 Add QUIT to make the loop interruptible.
57570cd3 105
c8d3a25c 1062012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 107
c8d3a25c
GM
108 * charset.c (init_charset): Make lack of etc/charsets fatal.
109
3e984ee8
DA
1102012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
111
112 * editfns.c (region_limit): Fix type mismatch.
113
ef884f23
DA
1142012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
115
116 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
117 undefined. Convert from xassert to eassert.
118 * nsmenu.m: Convert from xassert to eassert.
119 * nsterm.m: Likewise.
120
7d7e0027
SM
1212012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
122
123 * editfns.c (region_limit): Clip to narrowing (bug#11770).
124
aa754e6a
PE
1252012-06-28 Paul Eggert <eggert@cs.ucla.edu>
126
127 Avoid integer overflow on scroll-left and scroll-right.
128 * window.c (HSCROLL_MAX): New macro.
129 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
130 overflow when requested scroll falls outside ptrdiff_t range.
131
80b00b08
DA
1322012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
133
134 * window.h (struct window): Change type of 'hscroll',
135 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
136 'last_modified' and 'last_overlay_modified' to EMACS_INT.
137 Adjust users accordingly.
138 * xdisp.c (try_cursor_movement): Replace type check with eassert.
139 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
140 from EMACS_INT to ptrdiff_t.
141 (make_window): Omit redundant initialization.
142
62b2bcf6
JB
1432012-06-28 Juanma Barranquero <lekktu@gmail.com>
144
145 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
146
45942c7d
DA
1472012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
148
149 * window.h (struct window): Change type of 'use_time' and
150 'sequence_number' from Lisp_Object to int.
151 * frame.c (make_frame): Adjust users accordingly.
152 * print.c (print_object): Likewise.
153 * window.c (select_window, Fwindow_use_time, make_parent_window)
154 (make_window): Likewise.
155
e509cfa6
DA
1562012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
157
158 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
159 enabled with --enable-checking=[all,glyphs] configure option.
160 Fix GLYPH_DEBUG usage assuming that it may be undefined,
161 adjust comments accordingly.
162 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
163 undefined, adjust comments accordingly.
164 * image.c: Likewise.
165 * scroll.c: Likewise.
166 * w32fns.c: Likewise.
167 * w32term.c: Likewise.
168 * xdisp.c: Likewise.
169 * xfaces.c: Likewise.
170 * xfns.c: Likewise.
171 * xterm.c: Likewise.
172
a54e2c05
DA
1732012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
174
175 Generalize run-time debugging checks.
176 * dispextern.h (XASSERTS): Remove.
177 * fontset.c (xassert): Remove.
178 Convert from xassert to eassert.
179 * alloc.c: Convert from xassert to eassert.
180 * bidi.c: Likewise.
181 * dispnew.c: Likewise.
182 * fns.c: Likewise.
183 * fringe.c: Likewise.
184 * ftfont.c: Likewise.
185 * gtkutil.c: Likewise.
186 * image.c: Likewise.
187 * keyboard.c: Likewise.
188 * menu.c: Likewise.
189 * process.c: Likewise.
190 * scroll.c: Likewise.
191 * sound.c: Likewise.
192 * term.c: Likewise.
193 * w32console.c: Likewise.
194 * w32fns.c: Likewise.
195 * w32term.c: Likewise.
196 * window.c: Likewise.
197 * xdisp.c: Likewise.
198 * xfaces.c: Likewise.
199 * xfns.c: Likewise.
200 * xselect.c: Likewise.
201 * xterm.c: Likewise.
202
1ec4b7b2
SM
2032012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
204
205 * fns.c (maybe_resize_hash_table): Output message when growing the
206 purify-hashtable.
207
2014308a
DA
2082012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
209
210 * alloc.c (allocate_string_data): Remove dead code.
211 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
212 avoid GCC warning about unused macro.
213
246155eb
DA
2142012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
215
216 * alloc.c (allocate_string): Omit intervals initialization.
217 * alloc.c (make_uninit_multibyte_string): Initialize intervals
218 as in make_pure_string and make_pure_c_string.
219
43184b7b
DA
2202012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
221
222 * alloc.c (allocate_string): Fix last change.
223
3fe6dd74
DA
2242012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
225
226 * alloc.c (allocate_string): Remove two redundant calls
227 to memset, add explicit initialization where appropriate.
228
1ba6038a
GM
2292012-06-27 Glenn Morris <rgm@gnu.org>
230
231 * lisp.mk (lisp): Remove paths.elc.
232
c89926a5
CY
2332012-06-27 Chong Yidong <cyd@gnu.org>
234
235 * doc.c (Fsubstitute_command_keys): Fix punctuation.
236
ed6b3510
JW
2372012-06-26 John Wiegley <johnw@newartisans.com>
238
1ec4b7b2 239 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
240 on Mac OS X Lion: __mod_init_func and __mod_term_func.
241
ed6b3510
JW
242 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
243 when building with Clang.
244
8edd4a2b
SM
2452012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
246
247 * eval.c (Fapply): Allow calling it with a single argument.
248
f6f62d1b
EZ
2492012-06-26 Eli Zaretskii <eliz@gnu.org>
250
251 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
252 _stricmp and _strnicmp.
253 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
254
62efea5e
DA
2552012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
256
257 * alloc.c (allocate_window): Zero out non-Lisp part of newly
258 allocated window.
259 (allocate_process): Likewise for new process.
8edd4a2b 260 (allocate_terminal): Change to use offsetof.
62efea5e
DA
261 (allocate_frame): Likewise.
262 * frame.c (make_frame): Omit redundant initialization.
263 * window.c (make_parent_window): Use memset.
264 (make_window): Omit redundant initialization.
265 * process.c (make_process): Omit redundant initialization.
266 * terminal.c (create_terminal): Likewise.
267
42997f4d
DA
2682012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
269
270 * term.c (delete_tty): Remove redundant call to memset.
271
1130ecfc
DA
2722012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
273
274 * alloc.c: Remove build_string.
275 * lisp.h: Define build_string as static inline. This provides
276 a better opportunity to optimize away calls to strlen when the
277 function is called with compile-time constant argument.
278 * image.c (imagemagick_error): Convert to build_string.
279 * w32proc.c (sys_spawnve): Likewise.
280 * xterm.c (x_term_init): Likewise.
281
cf38a720
PE
2822012-06-26 Paul Eggert <eggert@cs.ucla.edu>
283
99027bdd
PE
284 Use sprintf return value instead of invoking strlen on result.
285 In the old days this wasn't portable, since some sprintf
286 implementations returned char *. But they died out years ago and
287 Emacs already assumes sprintf returns int.
288 Similarly for float_to_string.
289 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
290 * ccl.c (ccl_driver):
291 * character.c (string_escape_byte8):
292 * data.c (Fnumber_to_string):
293 * doprnt.c (doprnt):
294 * print.c (print_object):
295 * xdisp.c (message_dolog):
296 * xfns.c (syms_of_xfns):
297 Use sprintf or float_to_string result to avoid need to call strlen.
298 * data.c (Fnumber_to_string):
299 Use make_unibyte_string, since the string must be ASCII.
300 * lisp.h, print.c (float_to_string): Now returns int length.
301 * term.c (produce_glyphless_glyph):
302 Use sprintf result rather than recomputing it.
303
cf38a720
PE
304 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
305 * Makefile.in (ALL_CFLAGS):
306 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
307 * gmalloc.c, regex.c: Include <config.h> unconditionally.
308
3511c784
DA
3092012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
310
0a08eb21 311 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
312 strcasecmp if available.
313 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
314
fb7da12e
AS
3152012-06-25 Andreas Schwab <schwab@linux-m68k.org>
316
317 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
318 Avoid comma operator.
319 * menu.c (push_submenu_start, push_submenu_end)
320 (push_left_right_boundary, push_menu_pane): Likewise.
321 * msdos.c (dos_rawgetc): Likewise.
322
afa2ffd8
DA
3232012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
324
325 * xfns.c (xic_create_fontsetname): Remove redundant calls
326 to memset.
327
b3b4476b
PE
3282012-06-25 Paul Eggert <eggert@cs.ucla.edu>
329
4495ff38
PE
330 * gtkutil.c (get_utf8_string): Remove redundant assignment.
331 sprintf already null-terminates its output.
332
b3b4476b
PE
333 * xfns.c (x_window): Remove redundant cast.
334
b00876c9
DA
3352012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
336
337 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
338 `const char *' to `char *' to avoid compiler warning.
339
d188e26b
PE
3402012-06-24 Paul Eggert <eggert@cs.ucla.edu>
341
885d1d74
PE
342 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
343 instead of truncating it to 63 (admittedly a generous limit).
344
d188e26b
PE
345 * process.c: Fix spelling and caps in comments.
346
e2f560b1
DN
3472012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
348
e86db54b 349 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
350 * sysdep.c (setpgrp): Remove definition, not used in this file.
351
7583a3a1
JB
3522012-06-24 Juanma Barranquero <lekktu@gmail.com>
353
354 * makefile.w32-in: Update dependencies.
355
696056c2
EZ
3562012-06-24 Eli Zaretskii <eliz@gnu.org>
357
358 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
359 (SYSTIME_H): Add nt/inc/sys/time.h.
360
361 * systime.h [WINDOWSNT]: Include sys/time.h.
362
363 * s/ms-w32.h (struct timespec): Definition moved from
364 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
365
845ca893
PE
3662012-06-24 Paul Eggert <eggert@cs.ucla.edu>
367
368 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
369 * buffer.h (buffer_slot_type_mismatch):
370 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
371 * eval.c (unwind_to_catch):
372 * image.c (my_png_error, my_error_exit):
373 * keyboard.c (quit_throw_to_read_char, user_error)
374 (Fexit_recursive_edit, Fabort_recursive_edit):
375 * lisp.h (die, args_out_of_range, args_out_of_range_3)
376 (wrong_type_argument, buffer_overflow, __executable_start)
377 (memory_full, buffer_memory_full, string_overflow, Fthrow)
378 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
379 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
380 (fatal):
381 (child_setup) [!DOS_NT]:
382 * lread.c (end_of_file_error, invalid_syntax):
383 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
384 * puresize.h (pure_write_error):
385 * search.c (matcher_overflow):
386 * sound.c (sound_perror, alsa_sound_perror):
387 * sysdep.c, syssignal.h (croak):
388 * term.c (maybe_fatal, vfatal):
389 * textprop.c (text_read_only):
390 * undo.c (user_error):
391 * unexmacosx.c (unexec_error):
392 * xterm.c (x_ins_del_lines, x_delete_glyphs):
393 Use _Noreturn rather than NO_RETURN.
394 No need for separate decl merely because of _Noreturn.
395 * sound.c (sound_warning, parse_sound):
396 Remove unnecessary forward decls.
397
f1dd8073
PE
3982012-06-24 Paul Eggert <eggert@cs.ucla.edu>
399
400 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
401 * lisp.h (WAIT_READING_MAX): New macro.
402 * dispnew.c (Fsleep_for, sit_for):
403 * keyboard.c (kbd_buffer_get_event):
404 * process.c (Faccept_process_output):
405 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
406 This improves on the previous patch, which introduced a bug
407 when time_t is unsigned and as wide as intmax_t.
408 See <http://bugs.gnu.org/9000#51>.
409
b82c1755
EZ
4102012-06-23 Eli Zaretskii <eliz@gnu.org>
411
412 * dispnew.c (sit_for, Fsleep_for):
413 * keyboard.c (kbd_buffer_get_event):
414 * process.c (Faccept_process_output): Avoid compiler warnings when
415 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
416
ca300656
JB
4172012-06-23 Juanma Barranquero <lekktu@gmail.com>
418
049ec95b
JB
419 * makefile.w32-in: Update dependencies.
420
ca300656
JB
421 * w32.c (ltime): Add return type and declare static.
422 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
423
db7b8d06
PE
4242012-06-23 Paul Eggert <eggert@cs.ucla.edu>
425
426 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
427 Privately reported by Herbert J. Skuhra.
428 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
429 All uses changed.
430 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
431 not make_lisp_timeval, when the argument is of type EMACS_TIME.
432
0bd8297f
EZ
4332012-06-23 Eli Zaretskii <eliz@gnu.org>
434
96512555
EZ
435 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
436 last argument of make_unibyte_string.
437
0bd8297f
EZ
438 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
439 language ID in the event parameters.
440
441 * w32term.c (w32_read_socket): Put the new keyboard codepage into
442 event.code, not the obscure "character set ID".
443
63def6b6
CY
4442012-06-23 Chong Yidong <cyd@gnu.org>
445
446 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
447
e8a02204
EZ
4482012-06-23 Eli Zaretskii <eliz@gnu.org>
449
388cdec0
EZ
450 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
451 * w32.c (fdutimens): New function.
452
453 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
454
455 * s/ms-w32.h (pselect): Redirect to sys_select.
456
457 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
458
e8a02204
EZ
459 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
460 in the logic of incrementing and decrementing the value of
461 use_relocatable_buffers.
462
d054f3fb
PE
4632012-06-23 Paul Eggert <eggert@cs.ucla.edu>
464
465 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
466 Privately reported by Herbert J. Skuhra.
467 [__FreeBSD__]: Remove "*/" typo after "#include".
468 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
469 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
470 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
471 Don't assume EMACS_TIME and struct timeval are the same type.
472
d35af63c
PE
4732012-06-22 Paul Eggert <eggert@cs.ucla.edu>
474
475 Support higher-resolution time stamps (Bug#9000).
476 The time stamps are only nanosecond-resolution at the C level,
477 since that's the best that any real-world system supports now.
478 But they are picosecond-resolution at the Lisp level, as that's
479 easy, and leaves room for future OS improvements.
480
481 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
482 (LIBES): Use it.
483
484 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
485 Don't get current time unless it's needed.
486
487 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
488 now provides it if it's absent.
489 (start_atimer): Port to higher-res time stamps.
490 Check for time stamp overflow. Don't get current time more
491 often than is needed.
492
493 * buffer.h (struct buffer): Buffer modtime now has high resolution.
494 Include systime.h, not time.h.
495 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
496
497 * dired.c: Include stat-time.h.
498 (Ffile-attributes): File times now have higher resolution.
499
500 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
501 (struct image): Timestamp now has higher resolution.
502
503 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
504 has at least microseconds now. All uses removed.
505 (update_frame, update_single_window, update_window, update_frame_1)
506 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
507
508 * editfns.c (time_overflow): Now extern.
509 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
510 (float-time, Fformat_time_string, Fcurrent_time_string)
511 (Fcurrent_time_zone): Accept and generate higher-resolution
512 time stamps.
513 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
514 (decode_time_components, lisp_seconds_argument): New functions.
515 (make_time): Now static.
516 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
517 Report an error if the time is invalid, rather than having the caller
518 do that.
519
520 * fileio.c: Include <stat-time.h>
521 (Fcopy_file): Copy higher-resolution time stamps.
522 Prefer to set the time stamp via a file descriptor if that works.
523 (Fset_file_times, Finsert_file_contents, Fwrite_region)
524 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
525 (Fvisited_file_modtime, Fset_visited_file_modtime):
526 Support higher-resolution time stamps.
527
528 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
529
530 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
531
532 * image.c (prepare_image_for_display, clear_image_cache)
533 (lookup_image): Port to higer-resolution time stamps.
534
535 * keyboard.c (start_polling, bind_polling_period):
536 Check for time stamp overflow.
537 (read_char, kbd_buffer_get_event, timer_start_idle)
538 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
539 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
540 Port to higher-resolution time stamps. Do not assume time_t is signed.
541 (decode_timer): New function. Timers are now vectors of length 9,
542 not 8, to accommodate the picosecond component.
543 (timer_check_2): Use it.
544
545 * nsterm.m (select_timeout, timeval_subtract): Remove.
546 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
547 as they're a bit more accurate and handle overflow better.
548 (ns_select): Change prototype to be compatible with pselect.
549 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
550 * nsterm.h (ns_select): Adjust prototype.
551
552 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
553 us-resolution time stamps.
554 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
555
556 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
557
558 * lisp.h (time_overflow): New decl.
559 (wait_reading_process_output): First arg is now intmax_t, not int,
560 to accommodate larger waits.
561
562 * process.h (struct Lisp_Process.read_output_delay):
563 Now counts nanoseconds, not microseconds.
564 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
565 EMACS_HAS_USECS.
566 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
567 (wait_reading_process_output):
568 Port to ns-resolution time stamps.
569 (Faccept_process_output, wait_reading_process_output):
570 Check for time stamp overflow. Do not assume time_t is signed.
571 (select_wrapper): Remove; we now use pselect.
572 (Fprocess_attributes): Now generates ns-resolution time stamps.
573
574 * sysdep.c: Include utimens.h. Don't include utime.h
575 or worry about struct utimbuf; gnulib does that for us now.
576 (gettimeofday): Remove; gnulib provides a substitute.
577 (make_timeval): New function.
578 (set_file_times): Now sets ns-resolution time stamps.
579 New arg FD; all uses changed.
580 (time_from_jiffies, ltime_from_jiffies, get_up_time)
581 (system_process_attributes):
582 Now returns ns-resolution time stamp. All uses changed.
583 Check for time stamp overflow.
584
585 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
586 provides a substitute now.
587
588 * systime.h: Include timespec.h rather than sys/time.h and time.h,
589 since it guarantees struct timespec.
590 (EMACS_TIME): Now struct timespec, so that we can support
591 ns-resolution time stamps.
592 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
593 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
594 (EMACS_USECS): Remove.
595 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
596 so multiply the arg by 1000 before storing it.
597 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
598 New macros.
599 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
600 Port to ns-resolution time stamps.
601 (EMACS_TIME_NEG_P): Remove; replaced by....
602 (EMACS_TIME_SIGN): New macro.
603 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
604 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
605 (set_file_times, make_time, lisp_time_argument): Adjust signature.
606 (make_timeval, make_lisp_time, decode_time_components): New decls.
607 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
608 that it mishandled time_t overflow. You can't compare by subtracting!
609 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
610 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
611
612 * term.c: Include <sys/time.h>.
613 (timeval_to_Time): New function, for proper overflow wraparound.
614 (term_mouse_position, term_mouse_click): Use it.
615
616 * undo.c (record_first_change): Support higher-resolution time stamps
617 in the undo buffer.
618 (Fprimitive_undo): Use them when restoring time stamps.
619
620 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
621 (w32_get_internal_run_time):
622 Port to higher-resolution Emacs time stamps.
623 (ltime): Now accepts single 64-bit integer, as that's more convenient
624 for callers.
625
626 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
627
628 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
629 for compatibility with pselect. Support ns-resolution time stamps.
630
631 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
632
633 * xselect.c (wait_for_property_change, x_get_foreign_selection):
634 Check for time stamp overflow, and support ns-resolution time stamps.
635
636 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
637 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
638 (timeval_subtract): Remove; no longer needed.
639 (XTflash, XTring_bell, x_wait_for_event):
640 Port to ns-resolution time stamps. Don't assume time_t is signed.
641
b6a92dfe
CY
6422012-06-22 Chong Yidong <cyd@gnu.org>
643
644 * xdisp.c (x_consider_frame_title): Revert last change.
645
d251c37c
EZ
6462012-06-22 Eli Zaretskii <eliz@gnu.org>
647
648 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
649 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
650 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
651 staticidx goes up to 1597 out of 1600 = 0x640.)
652
f10deafb
PE
6532012-06-20 Paul Eggert <eggert@cs.ucla.edu>
654
655 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
656 Otherwise, the umask might be mistakenly 0 while handling input signals.
657
ec6de1e2
SM
6582012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
659
660 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
661
28be1ada
DA
6622012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
663
664 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
665 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
666 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
667 access to `contents' member of Lisp_Vector objects with AREF and ASET
668 where appropriate.
669
c6bf3022
CY
6702012-06-19 Chong Yidong <cyd@gnu.org>
671
672 * frame.c (delete_frame): When selecting a frame on a different
673 text terminal, do not alter the terminal's top-frame.
674
675 * xdisp.c (format_mode_line_unwind_data): Record the target
676 frame's selected window and its terminal's top-frame.
677 (unwind_format_mode_line): Restore them.
678 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
679 Callers changed.
680 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
681 since tty frames can be explicitly named.
682 (prepare_menu_bars): Likewise.
683
684 * term.c (Ftty_top_frame): New function.
685
defd4196
PE
6862012-06-18 Paul Eggert <eggert@cs.ucla.edu>
687
688 Port byte-code-meter to modern targets.
689 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
690 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 691 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
692 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
693 (METER_1, METER_2): Simplify.
694
1053a871
SM
6952012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
696
697 * data.c (Fdefalias): Return `symbol' (bug#11686).
698
b7e8d081
MR
6992012-06-18 Martin Rudalics <rudalics@gmx.at>
700
701 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
702 gets killed during executing of this function (Bug#11665).
703 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
704 (Vkill_buffer_query_functions): In doc-string say that functions
705 run by this hook should not change the current buffer.
706
7ea2b339
PE
7072012-06-18 Paul Eggert <eggert@cs.ucla.edu>
708
709 Fix recently-introduced process.c problems found by static checking.
710 * process.c (write_queue_push, write_queue_pop, send_process):
711 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
712 (write_queue_pop): Fix pointer signedness problem.
713 (send_process): Remove unused local.
714
96a313a1
CY
7152012-06-17 Chong Yidong <cyd@gnu.org>
716
717 * xdisp.c (redisplay_internal): No need to redisplay terminal
718 frames that are not on top.
719
20ca2e94
TN
7202012-06-17 Troels Nielsen <bn.troels@gmail.com>
721
722 * process.c (make_process): Initialize write_queue.
723 (write_queue_push, write_queue_pop): New functions.
724 (send_process): Use them to maintain correct ordering of process
725 writes (Bug#10815).
726
9a900ca9
PE
7272012-06-17 Paul Eggert <eggert@cs.ucla.edu>
728
310fbfa8
PE
729 * lisp.h (eassert): Assume C89 or later.
730 This removes the need for CHECK.
731 (CHECK): Remove. Its comments about always evaluating its
732 argument were confusing, as 'eassert' typically does not evaluate
733 its argument.
734
27bb1ca4
PE
735 * coding.c (produce_chars): Use ptrdiff_t, not int.
736
9a900ca9
PE
737 * xterm.c (x_draw_underwave): Check for integer overflow.
738 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
739
41b7f8bc 7402012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
741
742 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
743 referenced (Bug#11583).
744
9b0e3eba
AA
7452012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
746
747 Implement wave-style variant of underlining.
748 * dispextern.h (face_underline_type): New enum.
749 (face): Add field for underline type.
750 * nsterm.m (ns_draw_underwave): New function.
751 (ns_draw_text_decoration): Use it.
752 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
753 New functions.
754 (x_draw_glyph_string): Use them.
755 * xfaces.c (Qline, Qwave): New Lisp objects.
756 (check_lface_attrs, merge_face_ref)
1053a871
SM
757 (Finternal_set_lisp_face_attribute, realize_x_face):
758 Handle wave-style underline face attributes.
9b0e3eba
AA
759 * xterm.c (x_draw_underwave): New function.
760 (x_draw_glyph_string): Use it.
761
0fb52f11
JB
7622012-06-16 Juanma Barranquero <lekktu@gmail.com>
763
764 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
765 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
766 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
767 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
768 ($(BLD)/w32select.$(O)): Update dependencies.
769
e5560ff7
AS
7702012-06-16 Andreas Schwab <schwab@linux-m68k.org>
771
772 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
773 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
774 * character.c (_fetch_multibyte_char_p): Remove.
775 * alloc.c: Include "character.h" before "buffer.h".
776 * bidi.c: Likewise.
777 * buffer.c: Likewise.
778 * bytecode.c: Likewise.
779 * callint.c: Likewise.
780 * callproc.c: Likewise.
781 * casefiddle.c: Likewise.
782 * casetab.c: Likewise.
783 * category.c: Likewise.
784 * cmds.c: Likewise.
785 * coding.c: Likewise.
786 * composite.c: Likewise.
787 * dired.c: Likewise.
788 * dispnew.c: Likewise.
789 * doc.c: Likewise.
790 * dosfns.c: Likewise.
791 * editfns.c: Likewise.
792 * emacs.c: Likewise.
793 * fileio.c: Likewise.
794 * filelock.c: Likewise.
795 * font.c: Likewise.
796 * fontset.c: Likewise.
797 * fringe.c: Likewise.
798 * indent.c: Likewise.
799 * insdel.c: Likewise.
800 * intervals.c: Likewise.
801 * keyboard.c: Likewise.
802 * keymap.c: Likewise.
803 * lread.c: Likewise.
804 * macros.c: Likewise.
805 * marker.c: Likewise.
806 * minibuf.c: Likewise.
807 * nsfns.m: Likewise.
808 * nsmenu.m: Likewise.
809 * print.c: Likewise.
810 * process.c: Likewise.
811 * regex.c: Likewise.
812 * region-cache.c: Likewise.
813 * search.c: Likewise.
814 * syntax.c: Likewise.
815 * term.c: Likewise.
816 * textprop.c: Likewise.
817 * undo.c: Likewise.
818 * unexsol.c: Likewise.
819 * w16select.c: Likewise.
820 * w32fns.c: Likewise.
821 * w32menu.c: Likewise.
822 * window.c: Likewise.
823 * xdisp.c: Likewise.
824 * xfns.c: Likewise.
825 * xmenu.c: Likewise.
826 * xml.c: Likewise.
827 * xselect.c: Likewise.
828
2f07e6af
EZ
8292012-06-16 Eli Zaretskii <eliz@gnu.org>
830
1053a871
SM
831 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
832 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 833 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
834 row.
835 (handle_face_prop): Use chunk-relative overlay string index when
836 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
837 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
838 the rightmost. (Bug#11720)
2f07e6af 839
29b83cec
AS
8402012-06-16 Andreas Schwab <schwab@linux-m68k.org>
841
842 * category.h (CHAR_HAS_CATEGORY): Define as inline.
843 (CATEGORY_MEMBER): Enforce 1/0 value.
844 * category.c (_temp_category_set): Remove.
845
4c5501e9
EZ
8462012-06-16 Eli Zaretskii <eliz@gnu.org>
847
848 * window.c (Fdelete_other_windows_internal)
849 (Fdelete_window_internal): Don't access frame's mouse highlight
850 info of the initial frame. (Bug#11677)
851
2b570124
PE
8522012-06-14 Paul Eggert <eggert@cs.ucla.edu>
853
e93864f9
PE
854 * .gdbinit (xgetint): Fix recently-introduced paren typo.
855 Assume USE_2_TAGS_FOR_INTS.
856 (xreload): Adjust $tagmask width to match recent lisp.h change.
857
2b570124
PE
858 Simplify lisp.h in minor ways that should not affect code.
859 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
860 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
861 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
862 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
863 (INTTYPEBITS): New macro, for clarity.
864 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
865 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
866 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
867 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
868 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
869
81755f69
JB
8702012-06-13 Juanma Barranquero <lekktu@gmail.com>
871
872 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
873
16192a57
GM
8742012-06-13 Glenn Morris <rgm@gnu.org>
875
876 * s/bsd-common.h (BSD4_3):
877 * s/usg5-4-common.h (USG5_4): No longer define; unused.
878
646b5f55
AS
8792012-06-13 Andreas Schwab <schwab@linux-m68k.org>
880
881 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
882 instead of union.
883 (XLI, XIL): Define.
1053a871
SM
884 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
885 Use them.
886 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 887 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 888 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
889 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
890 * frame.c (delete_frame): Remove outdated comment.
891 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
892 USE_LISP_UNION_TYPE.
893 (Fw32_unregister_hot_key): Likewise.
894 (Fw32_toggle_lock_key): Likewise.
895 * w32menu.c (add_menu_item): Likewise.
896 (w32_menu_display_help): Use XIL instead of checking
897 USE_LISP_UNION_TYPE.
898 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
899 (init_heap): Likewise.
900 * w32term.c (w32_read_socket): Update comment.
901
1d3823c9
GM
9022012-06-13 Glenn Morris <rgm@gnu.org>
903
c62ff706
GM
904 * s/usg5-4-common.h, src/s/unixware.h:
905 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
906
1d3823c9
GM
907 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
908
bfe3e0a2
PE
9092012-06-13 Paul Eggert <eggert@cs.ucla.edu>
910
911 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
912 * alloc.c (make_number) [!defined make_number]:
913 Remove, as lisp.h always defines this now.
914 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
915 (roundup_size): Verify that it is a power of 2.
916 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
917 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
918 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
919 -DUSE_LSB_TAG=0, to override the automatically-selected default.
920 USE_LSB_TAG now is always defined to be either 0 or 1.
921 All uses changed.
922 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
923 code works fine either way, and efficiency is not a concern here,
924 as the union type is for debugging, not for production.
925 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
926 Use an inline function on all platforms when using the union type,
927 since this is simpler and 'static inline' can be used portably
928 within Emacs now.
929 (LISP_INITIALLY_ZERO): New macro.
930 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
931 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
932
45fa9c0f
GM
9332012-06-12 Glenn Morris <rgm@gnu.org>
934
b4492cba
GM
935 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
936
937 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 938
45fa9c0f
GM
939 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
940 Move BROKEN_SIGIO to configure.
941
942 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
943 Move NO_TERMIO to configure.
944
0e25d334
CY
9452012-06-12 Chong Yidong <cyd@gnu.org>
946
947 * image.c (imagemagick_load_image): Use MagickFlattenImage if
948 MagickMergeImageLayers is undefined. Use pixel pusher loop if
949 MagickExportImagePixels is undefined.
950
43682bb6
PE
9512012-06-12 Paul Eggert <eggert@cs.ucla.edu>
952
953 * image.c (imagemagick_load_image): Remove unused label.
954
a9be7d2b
GM
9552012-06-11 Glenn Morris <rgm@gnu.org>
956
957 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
958 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
959 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
960 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
961
3017f87f
SM
9622012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
963
964 * alloc.c (make_byte_code): New function.
965 (Fmake_byte_code): Use it. Don't purify here.
966 * lread.c (read1): Use it as well to avoid extra allocation.
967
1b9b4cf4
CY
9682012-06-11 Chong Yidong <cyd@gnu.org>
969
970 * image.c (imagemagick_load_image): Implement transparency.
971
95988fcf
AS
9722012-06-10 Andreas Schwab <schwab@linux-m68k.org>
973
974 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
975 account for preceding backslashes. (Bug#11663)
976
cd4eb164
CY
9772012-06-09 Chong Yidong <cyd@gnu.org>
978
979 * term.c: Support italics in capable terminals (Bug#9652).
980 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
981 (turn_on_face): Output using TS_enter_italic_mode if available.
982 Don't handle unused blinking and alt-charset cases.
983 (turn_off_face): Handle italic case; discard unused tty_blinking_p
984 and tty_alt_charset_p cases.
985 (tty_capable_p, init_tty): Support italics.
986
987 * termchar.h (struct tty_display_info): Add field for italics.
988 Remove unused blink field.
989
990 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
991 Handle slant.
992
993 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
994 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
995 tty_alt_charset_p. Add tty_italic_p.
996
ff88beb8
MA
9972012-06-09 Michael Albinus <michael.albinus@gmx.de>
998
999 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1000 dbus_type_is_basic if available.
1001 (xd_extract_signed, xd_extract_unsigned): Rename from
1002 extract_signed and extract_unsigned, respectively. Adapt callers.
1003
44286096
CY
10042012-06-09 Chong Yidong <cyd@gnu.org>
1005
1682701f
CY
1006 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1007
44286096
CY
1008 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1009 case (Bug#9752).
1010
d86feb17
PE
10112012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1012
1013 * xdisp.c (vmessage): Treat frame message as multibyte.
1014 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1015 would generate the diagnostic "Making \302\247 buffer-local while
1016 let-bound!".
1017
d5c20fe8
EZ
10182012-06-08 Eli Zaretskii <eliz@gnu.org>
1019
1020 * dispnew.c (showing_window_margins_p): Undo last change, which
1021 was done due to an inadvertent commit.
1022 (adjust_frame_glyphs_for_frame_redisplay): Do call
1023 showing_window_margins_p.
1024
513749ee
SM
10252012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1026
1027 * eval.c (Fmake_var_non_special): New primitive.
1028 (syms_of_eval): Defsubr it.
1029 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1030
d4a8f5c1
JB
10312012-06-08 Juanma Barranquero <lekktu@gmail.com>
1032
1033 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1034 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1035
8bbbc977
EZ
10362012-06-08 Eli Zaretskii <eliz@gnu.org>
1037
1038 * alloc.c (allocate_vectorlike): Fix last change.
1039
f3372c87
DA
10402012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1041
1042 Block-based vector allocation of small vectors.
1043 * lisp.h (struct vectorlike_header): New field `nbytes',
1044 adjust comment accordingly.
1045 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1046 to denote vector blocks. Adjust users (live_vector_p,
1047 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1048 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1049 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1050 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1051 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1052 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1053 (roundup_size): New constant.
1054 (struct vector_block): New data type.
1055 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1056 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1057 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1058 (sweep_vectors): New functions.
1059 (allocate_vectorlike): Return `zero_vector' as the only vector of
1060 0 items. Allocate new vector from block if vector size is less than
1061 or equal to VBLOCK_BYTES_MAX.
1062 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1063 (init_alloc_once): Add call to init_vectors.
1064
4f18a4ed
SM
10652012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1066
1067 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1068
86f158bc
PE
10692012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1070
1071 * doprnt.c (doprnt): Truncate multibyte char correctly.
1072 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1073 would mishandle a string argument "Xc" if X was a multibyte
1074 character of length 2: it would truncate after X's first byte
1075 rather than including all of X.
1076
c5cfcbe0
CY
10772012-06-06 Chong Yidong <cyd@gnu.org>
1078
1079 * buffer.c (word_wrap): Doc fix.
1080
c05cf390
PE
10812012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1082
1083 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1084
0c3461de
GM
10852012-06-03 Glenn Morris <rgm@gnu.org>
1086
1087 * xdisp.c (tool-bar-style): Doc fix.
1088
c71232db
UM
10892012-06-03 Ulrich Müller <ulm@gentoo.org>
1090
1091 * Makefile.in (PAXCTL): Define.
1092 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1093 binary via PaX flags if the paxctl utility is available.
1094 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1095 Restore PaX flags to their default. (Bug#11398)
1096
383f7350
CY
10972012-06-03 Chong Yidong <cyd@gnu.org>
1098
1099 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1100 buffer (Bug#11226).
1101
5f2c76c6
CY
11022012-06-03 Chong Yidong <cyd@gnu.org>
1103
1104 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1105 (note_mode_line_or_margin_highlight): If there is no help echo,
1106 use mode-line-default-help-echo. Handle the case where the mouse
1107 position is past the end of the mode line string.
1108
1109 * buffer.c (buffer_local_value_1): New function, split from
1110 Fbuffer_local_value; can return Qunbound.
1111 (Fbuffer_local_value): Use it.
1112 (Vmode_line_format): Docstring tweaks.
1113
773d47f6
PE
11142012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1115
1116 * sysdep.c (system_process_attributes): Improve comment.
1117
f2d6a3df
SM
11182012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1119
1120 * keyboard.c: Export real-this-command to Elisp.
1121 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1122 and DEFVAR it. Update all users.
1123
63810350
PE
11242012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1125
7bd5c1f4
PE
1126 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1127
63810350
PE
1128 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1129 Convert pctcpu and pctmem to Lisp float properly.
1130 Let the compiler fold better, as 100.0/0x8000 is exact.
1131
a2821611
AS
11322012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1133
1134 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1135 cons_block.
1136
5fceba1d
PE
11372012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1138
1139 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1140
c98ff5dd
DA
11412012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1142
1143 For a 'struct window', replace some Lisp_Object fields to
1144 bitfields where appropriate, remove unused fields.
1145 * window.h (struct window): Remove unused 'last_mark_x' and
1146 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1147 change it's type from Lisp_Object to bitfield.
1148 Change type of 'force_start', 'optional_new_start',
1149 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1150 fields from Lisp_Object to bitfield. Adjust users accordingly.
1151
ca34e0be
PE
11522012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1153
1154 Pacify gcc -Wdouble-precision when using Xaw.
1155 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1156 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1157 Use 'float' consistently, rather than 'float' in most places
1158 and 'double' in a couple of places.
1159
efc00ab1 11602012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1161
1162 * xdisp.c (handle_stop): Detect whether we have overlay strings
1163 loaded by testing it->current.overlay_string_index to be
1164 non-negative, instead of checking whether n_overlay_strings is
1165 positive. (Bug#11587)
1166
efc00ab1 11672012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1168
1169 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1170
1171 * doc.c (Fsubstitute_command_keys): Doc fix.
1172
efc00ab1 11732012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1174
1175 * search.c (search_buffer): Remove calls to
1176 r_alloc_inhibit_buffer_relocation, as it is now called by
1177 maybe_unify_char, which was the cause of relocation of buffer text
1178 in bug#11519.
1179
efc00ab1 11802012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1181
1182 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1183 for the duration of call to load_charset, to avoid problems with
1184 callers of maybe_unify_char that access buffer text through C
1185 pointers.
1186
1187 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1188 decrement the inhibition flag, instead of just setting or
1189 resetting it.
1190
ba93a187
PE
11912012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1192
1193 Remove obsolete '#define static' cruft.
1194 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1195 This #undef was "temporary" in 2000; it is no longer needed
1196 now that '#define static' has gone away.
1197 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1198 (gray_bitmap_bits): Remove; no longer needed.
1199 All uses replaced with definiens.
1200 * xterm.c: Include "bitmaps/gray.xbm".
1201
9e4bf381
PE
12022012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 Clean up __executable_start, monstartup when --enable-profiling.
1205 The following changes affect the code only when profiling.
1206 * dispnew.c (__executable_start): Rename from safe_bcopy.
1207 Define only on platforms that need it.
1208 * emacs.c: Include <sys/gmon.h> when profiling.
1209 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1210 (__executable_start): Remove decl, since lisp.h does it now.
1211 (safe_bcopy): Remove decl; no longer has that name.
1212 (main): Coalesce #if into single bit of code, for simplicity.
1213 Cast pointers to uintptr_t, since standard libraries want integers
1214 and not pointers.
1215 * lisp.h (__executable_start): New decl.
1216
32d72c2f
GM
12172012-05-31 Glenn Morris <rgm@gnu.org>
1218
1219 * image.c (Fimagemagick_types): Doc fix.
1220
baac5bc7
JM
12212012-05-30 Jim Meyering <meyering@redhat.com>
1222
1223 * callproc.c (Fcall_process_region): Include directory component
1224 in mkstemp error message (Bug#11586).
1225
72cb32cf
PE
12262012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1227
1228 * alloc.c, lisp.h (make_pure_vector): Now static.
1229
61b108cc
SM
12302012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1231
1232 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1233 Move to byte-run.el.
1234 (Fautoload): Do the hash-doc more carefully.
1235 * data.c (Fdefalias): Purify definition, except for keymaps.
1236 (Qdefun): Move from eval.c.
1237 * lisp.h (Qdefun): Remove.
1238 * lread.c (read1): Tiny simplification.
1239
471fe23d
TN
12402012-05-29 Troels Nielsen <bn.troels@gmail.com>
1241
934f3f58 1242 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1243 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1244 Bug#9642, but explicitly check that the buffer the overlay would
1245 be moved to is live and rearrange lines to make sure that errors
1246 will not put the overlay in an inconsistent state.
1247 (Fdelete_overlay): Cosmetics.
1248
85d0efd1
EZ
12492012-05-28 Eli Zaretskii <eliz@gnu.org>
1250
1251 * w32term.c (my_bring_window_to_top): New function.
1252 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1253 could be different from the original one.
1254 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1255 (Bug#11513)
1256
1257 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1258 by calling BringWindowToTop.
1259
1260 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1261 (WM_EMACS_END): Increase by one.
1262
da92a98c
PE
12632012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1264
1265 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1266 This avoids undefined behavior that might cause the eassert
1267 to not catch an out-of-range value.
1268
74d1f848
JB
12692012-05-28 Juanma Barranquero <lekktu@gmail.com>
1270
1271 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1272 Update dependencies.
1273
9e1a06fc
EZ
12742012-05-27 Eli Zaretskii <eliz@gnu.org>
1275
1276 * bidi.c (bidi_mirror_char): Fix last change.
1277
f3dd7312
AS
12782012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1279
1280 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1281 when referring to sectname field in printf format.
1282
81899c91
PE
12832012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1284
57b81a9f
PE
1285 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1286 Only r_alloc_inhibit_buffer_relocation needed to be added;
1287 the others were already declared.
1288
81899c91
PE
1289 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1290 before checking whether it's out of range. Put the check inside
1291 eassert. See
1292 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1293
33017faf 12942012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1295
1296 * callproc.c (Fcall_process): Restore a line that was accidentally
1297 commented out in the 2011-02-13 change (bug#11547).
1298
33017faf 12992012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1300
1301 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1302 defined on ralloc.c.
1303
1304 * buffer.c [REL_ALLOC]: Remove prototypes of
1305 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1306 they are now on lisp.h.
1307
1308 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1309
1310 * search.c (search_buffer): Use it to inhibit relocation of buffer
1311 text while re_search_2 is doing its job, because re_search_2 is
1312 passed C pointers to buffer text. (Bug#11519)
1313
23415acf
EZ
1314 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1315 Update value to 24.
1316
44e27368
EZ
1317 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1318 state after an additional call to move_it_in_display_line_to, keep
1319 the values of it->max_ascent and it->max_descent found for the
1320 entire line.
1321 (pos_visible_p): Revert the comparison against bottom_y to what it
1322 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1323 (Bug#11464)
1324
c1892f11
PE
13252012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1326
1327 Fix coding-related core dumps with gcc -ftrapv.
1328 The code was computing A - B, where A and B are pointers, and B is
1329 random garbage. This can lead to core dumps on platforms that
1330 have special pointer registers, and it also leads to core dumps on
1331 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1332 A - B only when B is initialized properly.
1333 * coding.c (coding_set_source, coding_set_destination): Return void.
1334 (coding_change_source, coding_change_destinations): New functions,
1335 with the old behaviors of coding_set_source and coding_set_destination.
1336 All callers that need an offset changed to use these new functions.
1337
eb7afdad
GM
13382012-05-26 Glenn Morris <rgm@gnu.org>
1339
1340 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1341
f12fdf02
EZ
13422012-05-26 Eli Zaretskii <eliz@gnu.org>
1343
53a63be6 1344 Extend mouse support on W32 text-mode console.
61b108cc
SM
1345 * xdisp.c (draw_row_with_mouse_face):
1346 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1347
eb3f6f01 1348 * w32console.c: Include window.h.
61b108cc
SM
1349 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1350 New functions.
eb3f6f01
EZ
1351 (initialize_w32_display): Initialize mouse-highlight data.
1352
53a63be6
EZ
1353 * w32inevt.c: Include termchar.h and window.h.
1354 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1355 moves, call note_mouse_highlight. If help_echo changed, call
1356 gen_help_event to produce help-echo message in the echo area.
1357 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1358 highlight info.
1359
4cfd81f6
PE
13602012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1361
1362 * lread.c (read1): Simplify slightly to avoid an overflow warning
1363 with GCC 4.7.0 on x86-64.
1364
4446092a
EZ
13652012-05-26 Eli Zaretskii <eliz@gnu.org>
1366
1367 * bidi.c (bidi_mirror_char): Revert last change: an int is
1368 definitely wide enough here.
1369
42b2a986 13702012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1371
42b2a986 1372 Fix integer width and related bugs (Bug#9874).
eb106a49 1373 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1374 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1375 (string_bytes, check_sblock, allocate_string_data):
1376 (compact_small_strings, Fmake_bool_vector, make_string)
1377 (make_unibyte_string, make_multibyte_string)
1378 (make_string_from_bytes, make_specified_string)
1379 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1380 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1381 (mark_vectorlike):
1382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1383 (allocate_pseudovector):
1384 Use int, not EMACS_INT, where int is wide enough.
1385 (inhibit_garbage_collection, Fgarbage_collect):
1386 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1387 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1388 int might not be wide enough.
1389 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1390 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1391 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1392 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1393 (bidi_level_of_next_char, bidi_move_to_visually_next):
1394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1395 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1396 (Fkill_buffer, Fset_buffer_major_mode)
1397 (advance_to_char_boundary, Fbuffer_swap_text)
1398 (Fset_buffer_multibyte, overlays_at, overlays_in)
1399 (overlay_touches_p, struct sortvec, record_overlay_string)
1400 (overlay_strings, recenter_overlay_lists)
1401 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1402 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1403 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1404 (Foverlay_recenter, last_overlay_modification_hooks_used)
1405 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1406 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1407 (validate_region): Omit unnecessary test for b <= e,
1408 since that's guaranteed by the previous test.
d311d28c
PE
1409 (adjust_overlays_for_delete): Avoid pos + length overflow.
1410 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1411 (report_overlay_modification):
1412 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1413 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1414 Omit pointer cast, which isn't needed anyway, and doesn't work
1415 after the EMACS_INT -> ptrdiff_t change.
02481186 1416 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1417 * buffer.h: Adjust decls to match defn changes elsewhere.
1418 (struct buffer_text, struct buffer):
1419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1420 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1421 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1422 not int, to avoid needless 32-bit limit on 64-bit hosts.
1423 (exec_byte_code): Use tighter memory-full test, one that checks
1424 for alloca overflow. Don't compute the address of the object just
1425 before an array, as that's not portable. Use EMACS_INT, not
1426 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1427 * callint.c (Fcall_interactively):
1428 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1429 * callproc.c (call_process_kill, Fcall_process):
1430 Don't assume pid_t fits into an Emacs fixnum.
1431 (call_process_cleanup, Fcall_process, child_setup):
1432 Don't assume pid_t fits into int.
1433 (call_process_cleanup, Fcall_process, delete_temp_file)
1434 (Fcall_process_region):
1435 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1436 (Fcall_process): Simplify handling of volatile integers.
1437 Use int, not EMACS_INT, where int will do.
1438 * casefiddle.c (casify_object, casify_region, operate_on_word)
1439 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1440 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1441 (casify_object): Avoid integer overflow when overallocating buffer.
1442 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1443 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1444 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1445 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1446 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1447 integers are now checked earlier. All uses replaced with XINT.
1448 (ccl_driver):
1449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1450 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1451 (ccl_driver, Fregister_code_conversion_map):
1452 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1453 (resolve_symbol_ccl_program): Check that vector header is in range.
1454 Always copy the vector, so that we can check its contents reliably
1455 now rather than having to recheck each instruction as it's being
1456 executed. Check that vector words fit in 'int'.
1457 (ccl_get_compiled_code, Fregister_ccl_program)
1458 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1459 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1460 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1461 contents are in range.
1462 (Fccl_execute_on_string): Check that status is in range.
1463 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1464 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1465 Accept and return EMACS_INT, not int, because callers can pass values
1466 out of 'int' range.
1467 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1468 (multibyte_chars_in_text, parse_str_as_multibyte)
1469 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1470 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1471 (string_escape_byte8, Fget_byte):
1472 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1473 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1474 avoid mishandling large integers.
1475 * character.h: Adjust decls to match defn changes elsewhere.
1476 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1477 (Ffind_charset_region):
1478 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1479 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1480 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1481 Don't assume fixnum fits in int.
d311d28c
PE
1482 (load_charset_map_from_vector, Fmap_charset_chars):
1483 Remove now-unnecessary CHECK_NATNUMs.
1484 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1485 Don't rely on undefined behavior with signed left shift overflow.
1486 Don't assume unsigned int fits into fixnum, or that fixnum fits
1487 into unsigned int. Don't require max_code to be a valid fixnum;
1488 that's not true for gb10830 4-byte on a 32-bit host. Allow
1489 invalid_code to be a cons, for the same reason. Require code_offset
1490 to be a character. Avoid int overflow if max_char is close
1491 to INT_MAX.
1492 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1493 this is intended anyway and avoids some undefined behavior.
1494 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1495 INDEX_TO_CODE_POINT, as that's what it expects.
1496 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1497 * charset.h (DECODE_CHAR): Return int, not unsigned;
1498 this is what was intended anyway, and it avoids undefined behavior.
1499 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1500 integer-overflow issues.
1501 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1502 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1503 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1504 * chartab.c (Fmake_char_table, Fset_char_table_range)
1505 (uniprop_get_decoder, uniprop_get_encoder):
1506 Don't assume fixnum fits in int.
1507 * cmds.c (move_point): New function, that does the gist of
1508 Fforward_char and Fbackward_char, but does so while checking
1509 for integer overflow more accurately.
c96e5d6a 1510 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1511 (Fforward_line, Fend_of_line, internal_self_insert)
1512 (internal_self_insert):
1513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1514 Fix a FIXME, by checking for integer overflow when calculating
1515 target_clm and actual_clm.
1516 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1517 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1518 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1519 (coding_alloc_by_making_gap, alloc_destination)
1520 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1521 (encode_coding_utf_16, detect_coding_emacs_mule)
1522 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1523 (detect_coding_iso_2022, decode_coding_iso_2022)
1524 (encode_invocation_designation, encode_designation_at_bol)
1525 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1526 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1527 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1528 (encode_coding_ccl, encode_coding_raw_text)
1529 (detect_coding_charset, decode_coding_charset)
1530 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1531 (produce_composition, produce_charset, produce_annotation)
1532 (decode_coding, handle_composition_annotation)
1533 (handle_charset_annotation, consume_chars, decode_coding_gap)
1534 (decode_coding_object, encode_coding_object, detect_coding_system)
1535 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1536 (code_convert_region, code_convert_string)
8f50130c
PE
1537 (Fdefine_coding_system_internal)
1538 (coding_set_source, coding_set_destination):
d311d28c
PE
1539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1540 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1541 (Fdefine_coding_system_internal):
1542 Don't assume fixnums fit in int.
1543 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1544 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1545 (Funencodable_char_position, Fcheck_coding_systems_region)
1546 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1547 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1548 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1549 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1550 Don't access memory outside of the args array.
d311d28c 1551 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1552 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1553 result of ENCODE_CHAR.
d311d28c
PE
1554 * coding.h: Adjust decls to match defn changes elsewhere.
1555 (struct coding_system):
1556 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1557 * composite.c (get_composition_id, find_composition)
1558 (run_composition_function, update_compositions)
1559 (compose_text, composition_gstring_put_cache)
1560 (composition_gstring_p, composition_gstring_width)
1561 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1562 (composition_compute_stop_pos, composition_reseat_it)
1563 (composition_update_it, struct position_record)
1564 (find_automatic_composition, composition_adjust_point)
1565 (Fcomposition_get_gstring, Ffind_composition_internal):
1566 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1567 (update_compositions):
1568 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1569 * composite.h: Adjust decls to match defn changes elsewhere.
1570 (struct composition):
1571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1572 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1573 Do not attempt to compute the address of the object just before a
1574 buffer; this is not portable.
1575 (Faref, Faset):
1576 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1577 (Faset): Use int, not EMACS_INT, where int is wide enough.
1578 (Fstring_to_number): Don't assume fixnums fit in int.
1579 (Frem): Don't assume arg is nonnegative.
1580 * dbusbind.c (xd_append_arg): Check for integers out of range.
1581 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1582 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1583 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1584 (xd_get_connection_references): Return ptrdiff_t, not int.
1585 All uses changed.
1586 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1587 (xd_read_message_1):
1588 Use int, not unsigned, where the dbus API uses int.
1589 (Fdbus_message_internal): Don't overflow mtype.
1590 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1591 * dired.c (directory_files_internal, file_name_completion, scmp)
1592 (file_name_completion_stat):
1593 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1594 (file_name_completion): Don't overflow matchcount.
1595 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1596 * dispextern.h: Adjust decls to match defn changes elsewhere.
1597 (struct text_pos, struct glyph, struct bidi_saved_info)
1598 (struct bidi_string_data, struct bidi_it, struct composition_it)
1599 (struct it):
1600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1601 (struct display_pos, struct composition_it, struct it):
1602 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1603 * dispnew.c (increment_matrix_positions)
1604 (increment_row_positions, mode_line_string)
1605 (marginal_area_string):
1606 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1607 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1609 (duration_to_sec_usec): New function, to check for overflow better.
1610 (Fsleep_for, sit_for): Use it.
1611 * doc.c (get_doc_string, store_function_docstring):
1612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1613 (get_doc_string, Fsnarf_documentation):
1614 Use int, not EMACS_INT, where int is wide enough.
1615 (get_doc_string):
1616 Use SAFE_ALLOCA, not alloca.
1617 Check for overflow when converting EMACS_INT to off_t.
1618 * doprnt.c (doprnt):
1619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1620 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1621 Don't assume uid_t fits into fixnum.
1622 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1623 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1624 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1625 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1626 (general_insert_function)
1627 (Finsert_char, make_buffer_string, make_buffer_string_both)
1628 (update_buffer_properties, Fbuffer_substring)
1629 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1630 (Fsubst_char_in_region, check_translation)
1631 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1632 (transpose_markers, Ftranspose_regions):
1633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1634 (clip_to_bounds): Move to lisp.h as an inline function).
1635 (Fconstrain_to_field): Don't assume integers are nonnegative.
1636 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1637 (Fsubst_char_in_region, Fsave_restriction):
1638 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1639 (Femacs_pid): Don't assume pid_t fits into fixnum.
1640 (lo_time): Use int, not EMACS_INT, when int suffices.
1641 (lisp_time_argument): Check for usec out of range.
1642 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1643 (Fuser_login_name, Fuser_full_name): Signal an error
1644 if a uid argument is out of range, rather than relying on
1645 undefined behavior.
c8d5c857
PE
1646 (Fformat_time_string): Remove now-unnecessary check.
1647 lisp_time_argument checks for out-of-range usec now.
243e0530 1648 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1649 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1650 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1651 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1652 (init_cmdargs, Fdump_emacs):
1653 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1654 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1655 the bottom (typically) 32 bits of the fixnum.
1656 * eval.c (specpdl_size, call_debugger):
1657 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1658 (when_entered_debugger, Fbacktrace_debug):
1659 Don't assume fixnum can fit in int.
1660 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1661 the object just before a buffer; this is not portable.
1662 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1663 (grow_specpdl, unbind_to):
1664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1665 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1666 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1667 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1668 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1669 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1671 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1672 (a_write, e_write):
1673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1674 (Fcopy_file, non_regular_nbytes, read_non_regular)
1675 (Finsert_file_contents):
1676 Use int, not EMACS_INT, where int is wide enough.
1677 (READ_BUF_SIZE): Verify that it fits in int.
1678 (Finsert_file_contents): Check that counts are in proper range,
1679 rather than assuming fixnums fit into ptrdiff_t etc.
1680 Don't assume fixnums fit into int.
125b3835 1681 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1682 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1683 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1684 (string_char_to_byte, string_byte_to_char)
1685 (string_make_multibyte, string_to_multibyte)
1686 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1687 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1688 (substring_both, Fdelete, internal_equal, Ffillarray)
1689 (Fclear_string, mapcar1)
1690 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1691 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1692 (larger_vector, make_hash_table, maybe_resize_hash_table)
1693 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1694 (Fmaphash, secure_hash):
1695 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1696 (concat): Check for string index and length overflow.
1697 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1698 (Frequire):
1699 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1700 (larger_vector): New API (vec, incr_min, size_max) replaces old
1701 one (vec, new_size, init). This catches size overflow.
1702 INIT was removed because it was always Qnil.
1703 All callers changed.
1704 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1705 the upper bound on a hash table index size.
1706 (make_hash_table, maybe_resize_hash_table): Use it.
1707 (secure_hash): Computer start_byte and end_byte only after
1708 they're known to be in ptrdiff_t range.
1709 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1710 (Ffont_get_glyphs, Ffont_at):
1711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1712 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1713 (Flist_fonts, Fopen_font):
1714 Don't assume fixnum can fit in int.
1715 (check_gstring): Don't assume index can fit in int.
1716 (font_match_p): Check that fixnum is a character, not a nonnegative
1717 fixnum, since the later code needs to stuff it into an int.
1718 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1719 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1720 conversion overflow issues.
1721 (Fopen_font): Check for integer out of range.
1722 (Ffont_get_glyphs): Don't assume index can fit in int.
1723 * font.h: Adjust decls to match defn changes elsewhere.
1724 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1725 integer overflow.
1726 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1727 printmax_t, where ptrdiff_t is wide enough.
1728 (Finternal_char_font):
1729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1730 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1731 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1732 (Fset_frame_position, x_set_frame_parameters)
1733 (x_set_line_spacing, x_set_border_width)
1734 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1735 Check that fixnums are in proper range for system types.
1736 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1737 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1738 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1739 Use SAFE_ALLOCA_LISP, not alloca.
1740 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1741 intptr_t is wide enough.
1742 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1743 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1744 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1745 Check for fixnum out of range.
1746 * ftfont.c (ftfont_list): Don't assume index fits in int.
1747 Check that fixnums are in proper range for system types.
1748 (ftfont_shape_by_flt):
1749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1750 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1752 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1753 Check that fixnums are in proper range for system types.
1754 * gnutls.h: Adjust decls to match defn changes elsewhere.
1755 * gtkutil.c (xg_dialog_run):
1756 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1757 (update_frame_tool_bar):
1758 Check that fixnums are in proper range for system types.
1759 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1760 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1761 * indent.c (last_known_column, last_known_column_point):
1762 (current_column_bol_cache):
1763 (skip_invisible, current_column, check_display_width):
1764 (check_display_width, scan_for_column, current_column_1)
1765 (Findent_to, Fcurrent_indentation, position_indentation)
1766 (indented_beyond_p, Fmove_to_column, compute_motion):
1767 (Fcompute_motion, Fvertical_motion):
1768 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1769 (last_known_column_modified): Use EMACS_INT, not int.
1770 (check_display_width):
1771 (Fcompute_motion):
1772 Check that fixnums and floats are in proper range for system types.
1773 (compute_motion): Don't assume index or fixnum fits in int.
1774 (compute_motion, Fcompute_motion):
1775 Use int, not EMACS_INT, when it is wide enough.
1776 (vmotion): Omit local var start_hpos that is always 0; that way
1777 we don't need to worry about overflow in expressions involving it.
1778 * indent.h: Adjust decls to match defn changes elsewhere.
1779 (struct position):
1780 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1781 Use int, not EMACS_INT, where int is wide enough.
1782 Remove unused members ovstring_chars_done and tab_offset;
1783 all uses removed.
1784 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1785 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1786 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1787 (make_gap, copy_text, insert, insert_and_inherit)
1788 (insert_before_markers, insert_before_markers_and_inherit)
1789 (insert_1, count_combining_before, count_combining_after)
1790 (insert_1_both, insert_from_string)
1791 (insert_from_string_before_markers, insert_from_string_1)
1792 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1793 (adjust_after_replace, adjust_after_insert, replace_range)
1794 (replace_range_2, del_range, del_range_1, del_range_byte)
1795 (del_range_both, del_range_2, modify_region)
1796 (prepare_to_modify_buffer, signal_before_change)
1797 (signal_after_change, Fcombine_after_change_execute):
1798 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1799 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1800 (balance_an_interval, split_interval_right, split_interval_left)
1801 (find_interval, next_interval, update_interval)
1802 (adjust_intervals_for_insertion, delete_node, delete_interval)
1803 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1804 (static_offset_intervals, offset_intervals)
1805 (merge_interval_right, merge_interval_left, make_new_interval)
1806 (graft_intervals_into_buffer, temp_set_point_both)
1807 (temp_set_point, set_point, adjust_for_invis_intang)
1808 (set_point_both, move_if_not_intangible, get_property_and_range)
1809 (get_local_map, copy_intervals, copy_intervals_to_string)
1810 (compare_string_intervals, set_intervals_multibyte_1):
1811 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1812 * intervals.h: Adjust decls to match defn changes elsewhere.
1813 (struct interval):
1814 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1815 * keyboard.c (this_command_key_count, this_single_command_key_start)
1816 (before_command_key_count, before_command_echo_length, echo_now)
1817 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1818 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1819 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1820 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1821 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1822 (last_non_minibuf_size, last_point_position, echo_truncate)
1823 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1824 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1825 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1826 (stuff_buffered_input):
1827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1828 (last_auto_save, command_loop_1, read_char):
1829 Use EMACS_INT, not int, to avoid integer overflow.
1830 (record_char): Avoid overflow in total_keys computation.
1831 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1832 * keyboard.h: Adjust decls to match defn changes elsewhere.
1833 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1834 (Fkey_description, Fdescribe_vector, Flookup_key):
1835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1836 (click_position): New function, to check that positions are in range.
1837 (Fcurrent_active_maps):
1838 (describe_command):
1839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1840 (Faccessible_keymaps, Fkey_description):
1841 (preferred_sequence_p):
1842 Don't assume fixnum can fit into int.
1843 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1844 Check for integer overflow in size calculations.
1845 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1846 avoid mishandling large integers.
1847 * lisp.h: Adjust decls to match defn changes elsewhere.
1848 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1849 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1850 (struct Lisp_Marker):
1851 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1852 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1853 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1854 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1855 All callers changed.
1856 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1857 Assume the arg has valid form, since it always does.
1858 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1859 unsigned integer system type.
1860 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1861 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1862 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1863 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1864 (duration_to_sec_usec): New decl.
1865 * lread.c (read_from_string_index, read_from_string_index_byte)
1866 (read_from_string_limit, readchar, unreadchar, openp)
1867 (read_internal_start, read1, oblookup):
1868 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1869 (Fload, readevalloop, Feval_buffer, Feval_region):
1870 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1871 (openp): Check for out-of-range argument to 'access'.
1872 (read1): Use int, not EMACS_INT, where int is wide enough.
1873 Don't assume fixnum fits into int.
6efdadfd 1874 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1875 (read_filtered_event): Use duration_to_sec_usec
1876 to do proper overflow checking on durations.
d311d28c
PE
1877 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1878 in size calculation.
1879 (Fexecute_kbd_macro):
1880 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1881 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1882 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1883 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1884 (set_marker_both, set_marker_restricted_both, marker_position)
1885 (marker_byte_position, Fbuffer_has_markers_at):
1886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1887 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1888 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1889 It now merely ensures that the menu is large enough, without
1890 necessarily growing it, as this avoids some integer overflow issues.
1891 All callers changed.
1892 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1893 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1894 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1895 Use SAFE_ALLOCA_LISP, not alloca.
1896 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1897 to EMACS_INT. Check that fixnums are in proper range for system types.
1898 * minibuf.c (minibuf_prompt_width, string_to_object)
1899 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1900 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1902 (get_minibuffer, read_minibuf_unwind):
1903 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1904 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1905 this simplifies overflow checking. All callers changed.
1906 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1907 (Ftest_completion):
1908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1909 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1910 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1911 Check that fixnums are in proper range for system types.
1912 (Fx_create_frame, Fx_show_tip):
1913 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1914 * nsfont.m (ns_findfonts, nsfont_list_family):
1915 Don't assume fixnum fits in long.
1916 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1918 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1919 wide enough.
17fdb222 1920 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1921 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1922 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1923 (PRINTDECLARE, PRINTPREPARE):
1924 (strout, print_string):
1925 (print, print_preprocess, print_check_string_charset_prop)
1926 (print_object):
1927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1928 (PRINTDECLARE):
1929 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1931 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1932 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1933 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1934 (print_error_message): Use SAFE_ALLOCA, not alloca.
1935 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1936 (print_depth, new_backquote_output, print_number_index):
1937 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1938 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1939 (Fset_process_window_size, Fformat_network_address)
1940 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1941 (sigchld_handler):
d311d28c 1942 Check that fixnums are in proper range for system types.
d44287d4 1943 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1944 Check for process-ids out of pid_t range rather than relying on
1945 undefined behavior.
e4d81efc 1946 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1947 (Fformat_network_address, read_process_output, send_process)
1948 (Fprocess_send_region, status_notify):
1949 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1950 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1951 (wait_reading_process_output, read_process_output, exec_sentinel):
1952 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1953 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1954 (Faccept_process_output): Use duration_to_sec_usec to do proper
1955 overflow checking on durations.
dde14581
PE
1956 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1957 Don't assume pid_t fits in int.
02481186
PE
1958 * process.h (struct Lisp_Process): Members tick and update_tick
1959 are now of type EMACS_INT, not int.
b62b53e8
PE
1960 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1961 configured --with-wide-int.
d311d28c
PE
1962 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1963 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1964 * search.c (looking_at_1, string_match_1):
1965 (fast_string_match, fast_c_string_match_ignore_case)
1966 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1967 (scan_newline, find_before_next_newline, search_command)
1968 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1969 (set_search_regs, wordify):
1970 (Freplace_match):
1971 (Fmatch_data):
1972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1973 (string_match_1, search_buffer, set_search_regs):
1974 (Fmatch_data):
1975 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1976 (wordify): Check for overflow in size calculation.
1977 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1978 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1979 Check that fixnums are in proper range for system types.
1980 * sound.c (struct sound_device)
1981 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1982 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1983 (Fplay_sound_internal):
1984 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1985 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1986 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1987 (Fparse_partial_sexp):
1988 Don't assume fixnums can fit in int.
1989 (struct lisp_parse_state, find_start_pos, find_start_value)
1990 (find_start_value_byte, find_start_begv)
1991 (update_syntax_table, char_quoted, dec_bytepos)
1992 (find_defun_start, prev_char_comend_first, back_comment):
1993 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1994 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1996 (Finternal_describe_syntax_value): Check that match_lisp is a
1997 character, not an integer, since the code stuffs it into int.
1998 (scan_words, scan_sexps_forward):
1999 Check that fixnums are in proper range for system types.
2000 (Fforward_word):
2001 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2002 (scan_sexps_forward):
2003 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2004 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2005 * syntax.h: Adjust decls to match defn changes elsewhere.
2006 (struct gl_state_s):
2007 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2008 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2009 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2010 * sysdep.c (wait_for_termination_1, wait_for_termination)
2011 (interruptible_wait_for_termination, mkdir):
2012 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2013 (emacs_read, emacs_write):
2014 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2015 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2016 and double all fit in int.
d311d28c
PE
2017 * term.c (set_tty_color_mode):
2018 Check that fixnums are in proper range for system types.
2019 * termhooks.h (struct input_event):
2020 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2021 * textprop.c (validate_interval_range, interval_of)
2022 (Fadd_text_properties, set_text_properties_1)
2023 (Fremove_text_properties, Fremove_list_of_text_properties)
2024 (Ftext_property_any, Ftext_property_not_all)
2025 (copy_text_properties, text_property_list, extend_property_ranges)
2026 (verify_interval_modification):
2027 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2028 (Fnext_single_char_property_change)
2029 (Fprevious_single_char_property_change):
2030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2031 (copy_text_properties):
2032 Check for integer overflow in index calculation.
d311d28c
PE
2033 * undo.c (last_boundary_position, record_point, record_insert)
2034 (record_delete, record_marker_adjustment, record_change)
2035 (record_property_change):
2036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2037 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2038 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2039 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2040 (Fx_hide_tip, Fx_file_dialog):
2041 * w32menu.c (set_frame_menubar):
2042 Use ptrdiff_t, not int, for consistency with rest of code.
2043 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2044 (select_window, Fdelete_other_windows_internal)
2045 (window_scroll_pixel_based, window_scroll_line_based)
2046 (Frecenter, Fset_window_configuration):
2047 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2048 (Fset_window_hscroll, run_window_configuration_change_hook)
2049 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2050 (Fscroll_other_window, Frecenter):
d311d28c
PE
2051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2052 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2053 Don't assume fixnum fits in int.
2054 (Fset_window_scroll_bars):
2055 Check that fixnums are in proper range for system types.
2056 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2057 (string_pos, c_string_pos, number_of_chars, init_iterator)
2058 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2059 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2060 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2061 (face_before_or_after_it_pos, handle_invisible_prop)
2062 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2063 (display_prop_intangible_p, string_buffer_position_lim)
2064 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2065 (get_overlay_strings_1, get_overlay_strings)
2066 (iterate_out_of_display_property, forward_to_next_line_start)
2067 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2068 (get_next_display_element, set_iterator_to_next)
2069 (get_visually_first_element, compute_stop_pos_backwards)
2070 (handle_stop_backwards, next_element_from_buffer)
2071 (move_it_in_display_line_to, move_it_in_display_line)
2072 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2073 (add_to_log, message_dolog, message_log_check_duplicate)
2074 (message2, message2_nolog, message3, message3_nolog
2075 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2076 (current_message_1, truncate_echo_area, truncate_message_1)
2077 (set_message, set_message_1, store_mode_line_noprop)
2078 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2079 (text_outside_line_unchanged_p, check_point_in_composition)
2080 (reconsider_clip_changes)
2081 (redisplay_internal, set_cursor_from_row, try_scrolling)
2082 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2083 (redisplay_window, find_last_unchanged_at_beg_row)
2084 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2085 (trailing_whitespace_p, find_row_edges, display_line)
2086 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2087 (display_mode_element, store_mode_line_string)
2088 (pint2str, pint2hrstr, decode_mode_spec)
2089 (display_count_lines, display_string, draw_glyphs)
2090 (x_produce_glyphs, x_insert_glyphs)
2091 (rows_from_pos_range, mouse_face_from_buffer_pos)
2092 (fast_find_string_pos, mouse_face_from_string_pos)
2093 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2095 (safe_call, init_from_display_pos, handle_fontified_prop)
2096 (handle_single_display_spec, load_overlay_strings)
2097 (with_echo_area_buffer, setup_echo_area_for_printing)
2098 (display_echo_area, echo_area_display)
2099 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2100 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2101 (redisplay_window, dump_glyph_row, display_mode_line)
2102 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2103 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2104 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2105 (handle_single_display_spec, build_desired_tool_bar_string)
2106 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2107 (get_specified_cursor_type):
2108 Check that fixnums are in proper range for system types.
2109 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2110 (Flookup_image_map):
2111 Don't assume fixnums fit in int.
2112 (compare_overlay_entries):
2113 Avoid mishandling comparisons due to subtraction overflow.
2114 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2115 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2116 (handle_tool_bar_click):
2117 Use int, not unsigned, since we prefer signed and the signedness
2118 doesn't matter here.
2119 (get_next_display_element, next_element_from_display_vector):
2120 Use int, not EMACS_INT, when int is wide enough.
2121 (start_hourglass): Use duration_to_sec_usec to do proper
2122 overflow checking on durations.
2123 * xfaces.c (Fbitmap_spec_p):
2124 Check that fixnums are in proper range for system types.
2125 (compare_fonts_by_sort_order):
2126 Avoid mishandling comparisons due to subtraction overflow.
2127 (Fx_family_fonts, realize_basic_faces):
2128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2129 (Fx_family_fonts):
2130 Don't assume fixnum fits in int.
2131 Use SAFE_ALLOCA_LISP, not alloca.
2132 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2133 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2134 (face_at_buffer_position, face_for_overlay_string)
2135 (face_at_string_position):
2136 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2137 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2138 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2139 (Fx_show_tip):
2140 Check that fixnums are in proper range for system types.
2141 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2142 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2143 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2144 (Fx_change_window_property): Don't assume fixnums fit in int.
2145 * xfont.c (xfont_chars_supported):
2146 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2147 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2148 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2149 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2150 * xml.c (parse_region):
2151 * xrdb.c (magic_file_p):
2152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2153 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2154 (x_get_local_selection, x_reply_selection_request)
2155 (x_handle_selection_request, wait_for_property_change):
2156 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2157 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2158 short is wide enough.
2159 (x_send_client_event): Don't assume fixnum fits in int.
2160 * xterm.c (x_x_to_emacs_modifiers):
2161 Don't assume EMACS_INT overflows nicely into int.
2162 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2163 may come from Lisp.
2164 (handle_one_xevent): NATNUMP can eval its arg twice.
2165 (x_connection_closed):
2166 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2167 * xterm.h: Adjust decls to match defn changes elsewhere.
2168 (struct scroll_bar): Use struct vectorlike_header
2169 rather than rolling our own approximation.
2170 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2171
c6574eb5
GM
21722012-05-25 Glenn Morris <rgm@gnu.org>
2173
2174 * lisp.mk (lisp): Update for more files being compiled now.
2175
e8d32c7e
SM
21762012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2177
48def666
SM
2178 * lread.c: Remove `read_pure' which makes no difference.
2179 (read_pure): Remove var.
2180 (unreadpure): Remove function.
2181 (readevalloop): Don't call read_list with -1 flag.
2182 (read1, read_vector): Don't test read_pure any more.
2183 (read_list): Simplify.
2184
e8d32c7e
SM
2185 * fileio.c, character.h: Minor style tweaks.
2186
4b2addb7
DA
21872012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2188
2189 * window.h (clip_changed): Remove useless declaration.
2190
584461b2
JB
21912012-05-22 Juanma Barranquero <lekktu@gmail.com>
2192
2193 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2194 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2195
34374650
PE
21962012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2197
2198 Remove src/m/*.
2199 This directory predates autoconf and is no longer needed nowadays.
2200 Move its few remaining bits of functionality to where they're needed.
2201 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2202 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2203 * m/template.h: Remove.
2204 * Makefile.in (M_FILE): Remove. All uses removed.
2205 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2206 * lisp.h (USE_LSB_TAG):
2207 * mem-limits.h (EXCEEDS_LISP_PTR):
2208 Use VAL_MAX, not VALBITS, in #if.
2209 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2210 (EMACS_UINT): Define unconditionally now.
2211 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2212 (BITS_PER_EMACS_INT): New constants, replacing
2213 what used to be in config.h, but not useful in #if.
2214 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2215 define them any more.
2216 (VAL_MAX): New macro.
2217 (VALMASK): Use it.
2218 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2219 BITS_PER_EMACS_INT, in #if.
2220 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2221 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2222 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2223 * s/ms-w32.h (DATA_START):
2224 Move here from removed file m/intel386.h.
2225 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2226 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2227
261cb4bb
PE
22282012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2229
2230 Assume C89 or later.
2231 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2232 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2233 (xrealloc):
2234 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2235 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2236 * textprop.c, tparam.c (NULL): Remove.
2237 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2238 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2239 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2240 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2241 * xterm.c (input_signal_count): Assume volatile works.
2242
ff23cd9f
KB
22432012-05-21 Ken Brown <kbrown@cornell.edu>
2244
2245 * xgselect.c (xg_select): Fix first argument in call to 'select'
2246 (bug#11508).
2247
1b170bc6
KB
22482012-05-20 Ken Brown <kbrown@cornell.edu>
2249
2250 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2251 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2252
b2f4d39f
KB
22532012-05-19 Ken Brown <kbrown@cornell.edu>
2254
2255 * xfns.c (x_in_use): Remove `static' qualifier.
2256 * xterm.h (x_in_use): Declare.
2257 * xgselect.c: Include xterm.h.
2258 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2259 and `display_arg' (bug#9754).
2260
003fdae2
PE
22612012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2262
9232a6d9
PE
2263 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2264
003fdae2
PE
2265 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2266 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2267
784b56e2
EZ
22682012-05-18 Eli Zaretskii <eliz@gnu.org>
2269
2270 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2271
2272 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2273 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2274
2275 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2276 reference to image_cache->refcount.
2277 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2278
a0a79cde
JL
22792012-05-17 Juri Linkov <juri@jurta.org>
2280
2281 * search.c (Fword_search_regexp, Fword_search_backward)
2282 (Fword_search_forward, Fword_search_backward_lax)
2283 (Fword_search_forward_lax): Move functions to isearch.el
2284 (bug#10145, bug#11381).
2285
b0572523
PE
22862012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2287
2288 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2289
9660f5fc
SM
22902012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2291
2292 * lread.c (init_obarray): Declare Qt and Qnil as special.
2293
4374de83
GM
22942012-05-14 Glenn Morris <rgm@gnu.org>
2295
2296 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2297 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2298
dc44c39a
PE
22992012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2300
078c97cb
PE
2301 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2302
dc44c39a
PE
2303 * unexaix.c: Port to more-recent AIX compilers.
2304 (report_error, report_error_1, make_hdr, copy_sym)
2305 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2306 Make arguments const char *, not char *, to avoid violations of C
2307 standard and to fix some AIX warnings reported by Gilles Pion.
2308
e18afed7 23092012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2310
2311 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2312 already have overlays loaded.
2313 (handle_single_display_spec): Before returning without displaying
2314 fringe bitmap, synchronize the bidi iterator with the main display
2315 iterator, by calling iterate_out_of_display_property.
2316 (iterate_out_of_display_property): Detect buffer iteration by
2317 testing that it->string is a Lisp string.
2318 (get_next_display_element): When the current object is exhausted,
2319 and there's something on it->stack, call set_iterator_to_next to
2320 proceed with what's on the stack, instead of returning zero.
2321 (set_iterator_to_next): If called at the end of a Lisp string,
2322 proceed to consider_string_end without incrementing string
2323 position. Don't increment display vector index past the end of
2324 the display vector. (Bug#11417)
c8fb9dc6
EZ
2325 (pos_visible_p): Don't report a position visible when move_it_to
2326 stopped at the last line of window, which happens to be scanned
2327 backwards by the bidi iteration. (Bug#11464)
ac268e67 2328
e18afed7 23292012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2330
2331 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2332 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2333 are on a TTY, and thus unable to display on the fringes.
2334 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2335 so we need to signal to the caller that this is a "replacing"
2336 display spec. This fixes display when the spec is invalid or we
2337 are on a TTY.
2338
e18afed7 23392012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2340
2341 * unexaix.c (make_hdr): Fix typo in prototype.
2342 This bug broke the build on AIX. Problem reported by Gilles Pion.
2343
9d0a235a
MA
23442012-05-14 Michael Albinus <michael.albinus@gmx.de>
2345
2346 * keyboard.c (kbd_buffer_get_event): Read special events also in
2347 batch mode. (Bug#11415)
2348
9e6b06ed
GM
23492012-05-12 Glenn Morris <rgm@gnu.org>
2350
2351 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2352
c1a1d7a3
EZ
23532012-05-12 Eli Zaretskii <eliz@gnu.org>
2354
2355 * lisp.mk (lisp): Add newcomment.elc.
2356
3fe7cdc8
GM
23572012-05-12 Glenn Morris <rgm@gnu.org>
2358
2359 * Makefile.in (MKDIR_P): New, set by configure.
2360 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2361
53f7d2c0
PE
23622012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2363
2364 Remove unused function hourglass_started.
2365 * dispextern.h (hourglass_started):
2366 * w32fns.c (hourglass_started):
2367 * xdisp.c (hourglass_started): Remove.
2368
75aafb17
JB
23692012-05-10 Juanma Barranquero <lekktu@gmail.com>
2370
2371 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2372 Update dependencies.
2373
12959e8e
PE
23742012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2375
97107e2e
PE
2376 * xgselect.c (xg_select): Put maxfds+1 into a var.
2377 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2378
12959e8e
PE
2379 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2380
836d29b3
DA
23812012-05-10 Dave Abrahams <dave@boostpro.com>
2382
2383 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2384 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2385
5cb67954
MA
23862012-05-09 Michael Albinus <michael.albinus@gmx.de>
2387
2388 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2389 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2390 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2391 Initialize xd_registered_buses.
2392
3478ec45
PE
23932012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2394
b263a6b0
PE
2395 Untag more efficiently if USE_LSB_TAG.
2396 This is based on a proposal by YAMAMOTO Mitsuharu in
2397 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2398 For an admittedly artificial (nth 8000 longlist) benchmark on
2399 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2400 Emacs's overall text size by 1%.
2401 * lisp.h (XUNTAG): New macro.
2402 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2403 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2404 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2405 * eval.c (Fautoload):
2406 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2407 * frame.h (XFRAME): Use XUNTAG.
2408
3478ec45
PE
2409 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2410 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2411 Remove unportable assumptions about print widths of types like
2412 dbus_uint32_t.
2413 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2414 intptr_t when converting between pointer and integer, to avoid GCC
2415 warnings about wrong width.
2416
666b903b 24172012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2418
2419 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2420 stack for each reader_thread, instead of defaulting to 8MB
2421 determined by the linker. This avoids failures in creating
2422 subprocesses on Windows 7, see the discussion in this thread:
2423 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2424
b120cc17
JC
24252012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2426
2427 Fix up display of the *Minibuf-0* buffer in the mini window.
2428 * keyboard.c (read_char): Don't clear the echo area if there's no
2429 message to clear.
2430 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2431 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2432
9a4b36f8
MA
24332012-05-07 Michael Albinus <michael.albinus@gmx.de>
2434
2435 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2436 batch mode.
2437
e5f9458f
CY
24382012-05-06 Chong Yidong <cyd@gnu.org>
2439
2440 * lisp.mk (lisp): Update.
2441
eceeb5fc 24422012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2443
2444 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2445
71873e2b
SM
24462012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2447
2448 * data.c (PUT_ERROR): New macro.
2449 (syms_of_data): Use it. Add new error type `user-error'.
2450 * undo.c (user_error): New function.
2451 (Fprimitive_undo): Use it.
2452 * print.c (print_error_message): Adjust print style for `user-error'.
2453 * keyboard.c (user_error): New function.
2454 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2455
ab0fa4e4
PE
24562012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2457
2458 Do not limit current-time-string to years 1000..9999.
2459 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2460 (Fcurrent_time_string): Support any year that is supported by the
2461 underlying localtime representation. Don't use asctime, as it
2462 has undefined behavior for years outside the range -999..9999.
2463
7ed806a7
PE
24642012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2465
2466 Fix race conditions involving setenv, gmtime, localtime, asctime.
2467 Without this fix, interrupts could mess up code that uses these
2468 nonreentrant functions, since setting TZ invalidates existing
2469 tm_zone or tzname values, and since most of these functions return
2470 pointers to static storage.
2471 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2472 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2473 Grow the critical sections to include not just invoking
2474 localtime/gmtime, but also accessing these functions' results
2475 including their tm_zone values if any, and any related TZ setting.
2476 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2477 so that the struct tm is saved in the critical section.
2478 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2479 motivated by the fact that memory allocation needs to be outside
2480 the critical section.
2481
0c16dfed
DA
24822012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2483
2484 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2485 with RESET_INTERVAL.
2486
2487 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2488 Remove duplicated buffer name initialization.
2489
3f83ace8
JM
24902012-05-02 Jim Meyering <jim@meyering.net>
2491
2492 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2493
c7b8541e
JM
2494 * xfns.c (x_window): Use xstrdup (Bug#11375).
2495
90207a15 24962012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2497
2498 * xdisp.c (pos_visible_p): If already at a newline from the
2499 display string before the 'while' loop, don't walk back the glyphs
2500 from it3.glyph_row. Solves assertion violation when the display
2501 string begins with a newline (egg.el). (Bug#11367)
2502
b593d6a9
AH
25032012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2504
2505 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2506 Move to simple.el.
2507
4737362e
GM
25082012-05-01 Glenn Morris <rgm@gnu.org>
2509
99cf43f9
GM
2510 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2511 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2512 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2513 All were removed before 23.1.
2514
9311dcff
GM
2515 * dispnew.c: Remove HAVE_LIBNCURSES test;
2516 it is always true on relevant platforms.
2517
4d5c6349
GM
2518 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2519 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2520
4737362e
GM
2521 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2522
74dd3a6b
AS
25232012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2524
2525 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2526 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2527 Remove.
2528
13c379ee
PE
25292012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2530
2531 Do not avoid creating empty evaporating overlays (Bug#9642).
2532 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2533 That is, do not delete an evaporating overlay if it becomes
2534 empty after its bounds are adjusted to fit within its buffer.
2535 This fix caused other problems, and I'm reverting it until we get
2536 to the bottom of them.
2537
a8e7d6d7 25382012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2539
2540 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2541
a8e7d6d7 25422012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2543
2544 * xdisp.c (pos_visible_p): If the window start position is beyond
2545 ZV, start the display from buffer beginning. Prevents assertion
2546 violation in init_iterator when the minibuffer window is scrolled
2547 via the scroll bar.
2548
2549 * window.c (window_scroll_pixel_based): Likewise.
2550
a8e7d6d7 25512012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2552
2553 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2554
a8e7d6d7 25552012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2556
2557 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2558 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2559
a8e7d6d7 25602012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2561
b593d6a9
AH
2562 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2563 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2564
1c6900d9
EZ
25652012-04-26 Eli Zaretskii <eliz@gnu.org>
2566
4c3fa1d9
EZ
2567 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2568 display element, check also the underlying string or buffer
2569 character. (Bug#11341)
2570
1c6900d9
EZ
2571 * w32menu.c: Include w32heap.h.
2572 (add_menu_item): If the call to AppendMenuW (via
2573 unicode_append_menu) fails, disable Unicode menus only if we are
2574 running on Windows 9X/Me.
2575
42bf8205
AS
25762012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2577
2578 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2579 (xgetint): Add missing shift for LSB tags.
2580
b1bac16e
MR
25812012-04-24 Martin Rudalics <rudalics@gmx.at>
2582
2583 * keyboard.c (read_char): Don't wipe echo area for select window
2584 events: These might get delayed via `mouse-autoselect-window'
2585 (Bug#11304).
2586
d69621cc
JB
25872012-04-24 Juanma Barranquero <lekktu@gmail.com>
2588
2589 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2590 manipulation of :loaded-from data.
2591
02fd101b
JB
25922012-04-23 Juanma Barranquero <lekktu@gmail.com>
2593
2594 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2595 now a cons (bug#11311).
2596
888bec30
PE
25972012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2598
89a438bd
PE
2599 Do not create empty overlays with the evaporate property (Bug#9642).
2600 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2601 if it becomes empty after its bounds are adjusted to fit within
2602 its buffer. Without this fix, in a nonempty buffer (let ((o
2603 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2604 yields an empty overlay that has the evaporate property, which is
2605 not supposed to happen.
2606
1068fe4d
PE
2607 Fix minor GTK3 problems found by static checking.
2608 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2609 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2610 (struct _EmacsFixedClass, emacs_fixed_get_type):
2611 Move decls here from emacsgtkfixed.h, since they needn't be public.
2612 (emacs_fixed_get_type): Now static.
2613 (emacs_fixed_class_init): Omit unused local.
2614 (emacs_fixed_child_type): Remove; unused.
2615 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2616 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2617 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2618 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2619 (EMACS_FIXED_GET_CLASS): Remove; unused.
2620 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2621
888bec30
PE
2622 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2623 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2624
de85e130
PE
26252012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2626
d0baac98 2627 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2628 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2629 (__malloc_size_t, __malloc_ptrdiff_t):
2630 Remove. All uses removed, replaced by the definiens if needed,
2631 since we can assume C89 or better now.
2632 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2633 (protect_malloc_state, align, get_contiguous_space)
2634 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2635 (malloc_atfork_handler_child, malloc_enable_thread)
2636 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2637 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2638 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2639 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2640 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2641 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2642 Define using prototypes, not old style.
2643 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2644 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2645 (align): Don't assume that signed integer overflow wraps around.
2646 Omit unused local var.
2647 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2648 (_free_internal_nolock, memalign, mallochook, reallochook):
2649 Omit no-longer-needed casts.
2650 (valloc): Use getpagesize, not __getpagesize.
2651 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2652 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2653
de85e130
PE
2654 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2655
dcbf5805
MA
26562012-04-22 Michael Albinus <michael.albinus@gmx.de>
2657
2658 Move functions from C to Lisp. Make non-blocking method calls
2659 the default. Implement further D-Bus standard interfaces.
2660
2661 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2662 (QCdbus_request_name_allow_replacement)
2663 (QCdbus_request_name_replace_existing)
2664 (QCdbus_request_name_do_not_queue)
2665 (QCdbus_request_name_reply_primary_owner)
2666 (QCdbus_request_name_reply_in_queue)
2667 (QCdbus_request_name_reply_exists)
2668 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2669 (QCdbus_registered_serial, QCdbus_registered_method)
2670 (QCdbus_registered_signal): New Lisp objects.
2671 (XD_DEBUG_MESSAGE): Use sizeof.
2672 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2673 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2674 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2675 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2676 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2677 (xd_signature, xd_append_arg): Allow float for integer types.
2678 (xd_get_connection_references): New function.
b593d6a9
AH
2679 (xd_get_connection_address): Rename from xd_initialize.
2680 Return cached address.
dcbf5805
MA
2681 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2682 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2683 level.
2684 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2685 Return number of refcounts.
dcbf5805
MA
2686 (Fdbus_get_unique_name): Make stronger parameter check.
2687 (Fdbus_message_internal): New defun.
2688 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2689 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2690 (Fdbus_send_signal, Fdbus_register_service)
2691 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2692 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2693 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2694 (Vdbus_compiled_version, Vdbus_runtime_version)
2695 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2696 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2697 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2698 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2699 Adapt docstring.
dcbf5805 2700
52828e02
PE
27012012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2702
da05bc4c
PE
2703 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2704 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2705 Do not assume ptrdiff_t is the same width as 'int'.
2706
52828e02
PE
2707 * alloc.c: Handle unusual debugging option combinations.
2708 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2709 since the two debugging options are incompatible.
2710 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2711 is defined.
2712 (mem_init, mem_insert, mem_insert_fixup):
2713 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2714 (NEED_MEM_INSERT): Remove; no longer needed.
2715
f01769f9
LL
27162012-04-22 Leo Liu <sdl.web@gmail.com>
2717
2718 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2719
5790543d
PE
27202012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2721
2722 * sysdep.c [__FreeBSD__]: Minor cleanups.
2723 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2724 Use Emacs indenting style more consistently. Avoid some casts.
2725 Use 'double' consistently rather than mixing 'float' and 'double'.
2726
b91b7e4d
EW
27272012-04-21 Eduard Wiebe <usenet@pusto.de>
2728
b593d6a9
AH
2729 * sysdep.c (list_system_processes, system_process_attributes):
2730 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2731
6114eb15
AS
27322012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2733
2734 * lisp.mk (lisp): Update.
2735
2f38dff7
PE
27362012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2737
2738 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2739 It is never used otherwise.
2740
4ae29f89
SM
27412012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2742
2743 * print.c (print_preprocess): Only check print_depth if print-circle
2744 is nil.
2745 (print_object): Check for cycles even when print-circle is nil and
2746 print-gensym is t, but only check print_depth if print-circle is nil.
2747
f30d612a
CY
27482012-04-20 Chong Yidong <cyd@gnu.org>
2749
2750 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2751 set the status to "failed" and ensure that sentinel is run.
2752
c07a4c0b 27532012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2754
2755 * process.c (Fset_process_inherit_coding_system_flag)
2756 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2757 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2758
c07a4c0b 27592012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2760
2761 * xdisp.c (string_buffer_position_lim): Limit starting position to
2762 BEGV.
2763 (set_cursor_from_row): If called for a mode-line or header-line
2764 row, return zero immediately.
2765 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2766 farther than the first row after the header line, if any.
2767 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2768 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2769
c07a4c0b 27702012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2771
4ae29f89
SM
2772 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2773 (bug#11238).
ad3a2b41 2774
c07a4c0b 27752012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 27762012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2777
2778 configure: new option --enable-gcc-warnings (Bug#11207)
2779 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2780 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2781 (ALL_CFLAGS): Use new macros rather than old.
2782 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2783 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2784 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2785 -Wunused-result, -Wunused-variable. This should go away once
2786 the Emacs and Gnulib regex code is merged.
2787 (xmalloc, xrealloc): Now static.
2788
aba027e8
PE
27892012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2790
2791 * dired.c (Fsystem_groups): Remove unused local.
2792
e5a36063
GM
27932012-04-17 Glenn Morris <rgm@gnu.org>
2794
2795 * dired.c (Fsystem_users): Doc fix.
2796
316411f0
DA
27972012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2798
2799 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2800 (syms_of_dired): Add them.
2801
9426aba4
PE
28022012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2803
b62a57be
PE
2804 Fix minor alloc.c problems found by static checking.
2805 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2806 New extern decls, to avoid calling undeclared functions.
2807 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2808 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2809 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2810 (NEED_MEM_INSERT): New macro.
2811 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2812 Remove one incorrect comment and fix another.
b62a57be 2813
3539f31f
PE
2814 Fix minor ralloc.c problems found by static checking.
2815 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2816 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2817 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2818 (r_alloc_sbrk): Now static.
2819
a041960a
PE
2820 Improve ralloc.c interface checking.
2821 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2822 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2823 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2824 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2825 [REL_ALLOC]: ... to here, to check interface.
2826 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2827 Remove decls. This fixes an "It stinks!".
2828
9426aba4
PE
2829 * alloc.c (which_symbols): Fix alignment issue / type clash.
2830
d55c12ed
AS
28312012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2832
2833 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2834 (struct Lisp_Misc_Any): Likewise.
2835 (struct Lisp_Free): Likewise.
2836 * alloc.c (union aligned_Lisp_Symbol): Define.
2837 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2838 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2839 (union aligned_Lisp_Misc): Define.
2840 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2841 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2842 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2843
b948ce8b
PE
28442012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2845
2846 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2847 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2848 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2849 * s/netbsd.h, s/sol2-6.h:
2850 Remove definition of GC_MARK_STACK, since the default now works.
2851 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2852 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2853 no longer the default.
2854 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2855
35dc09a1 28562012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2857
35dc09a1
GM
2858 * lread.c (lisp_file_lexically_bound_p):
2859 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2860
35dc09a1
GM
28612012-04-14 Eli Zaretskii <eliz@gnu.org>
2862
2863 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2864 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2865
28662012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2867
2868 * nsterm.m (constrainFrameRect): Always constrain when there is only
2869 one screen (Bug#10962).
2870
bcd86815
KB
28712012-04-13 Ken Brown <kbrown@cornell.edu>
2872
2873 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2874
c25df26e
RT
28752012-04-13 Reuben Thomas <rrt@sc3d.org>
2876
2877 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2878
0fc59f1e
DC
28792012-04-11 Daniel Colascione <dancol@dancol.org>
2880
2881 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2882 against is gone. It's better to use vfork now so that when Cygwin
2883 gains a new, working vfork, we use it automatically (bug#10398).
2884
de8c03dc
SM
28852012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2886
2887 * window.c (save_window_save): Obey window-point-insertion-type.
2888
2f097256
GM
28892012-04-11 Glenn Morris <rgm@gnu.org>
2890
2891 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2892
453b951e
SM
28932012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2894
2895 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2896
75f1671a 28972012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2898
2899 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2900 (force_quit_count): New var.
2901 (handle_interrupt): Use it.
2902
2a8ce227
JB
29032012-04-10 Juanma Barranquero <lekktu@gmail.com>
2904
2905 * w32.c (w32_delayed_load): Record the full path of the library
2906 being loaded (bug#10424).
2907
935396c0
GM
29082012-04-09 Glenn Morris <rgm@gnu.org>
2909
05920a43
GM
2910 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2911 not just in the obarray, before snarfing them. (Bug#11036)
2912
935396c0
GM
2913 * Makefile.in ($(leimdir)/leim-list.el):
2914 Pass EMACS rather than BUILT_EMACS.
2915
a18ecafa
TZ
29162012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2917
2918 * process.c (make_process):
2919 * process.h: Add integer `gnutls_handshakes_tried' member to
2920 process struct.
2921
6bbef4e5
JC
2922 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2923 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2924
2925 * gnutls.c (gnutls_log_function2i): Convenience log function.
2926 (emacs_gnutls_read): Use new log functions,
2927 `gnutls_handshakes_tried' process member, and
2928 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2929 attempts per process (connection).
2930
b4d3bc10
CY
29312012-04-09 Chong Yidong <cyd@gnu.org>
2932
2933 * eval.c (Fuser_variable_p, user_variable_p_eh)
2934 (lisp_indirect_variable): Functions deleted.
2935 (Fdefvar): Caller changed.
2936
2937 * callint.c (Finteractive, Fcall_interactively):
2938 * minibuf.c (Fread_variable): Callers changed.
2939
70f4d973
EZ
29402012-04-09 Eli Zaretskii <eliz@gnu.org>
2941
2942 * xdisp.c (set_cursor_from_row): If the display string appears in
2943 the buffer at position that is closer to point than the position
2944 after the display string, display the cursor on the first glyph of
2945 the display string. Fixes cursor display when a 'display' text
2946 property immediately follows invisible text. (Bug#11094)
2947
cb3c2e3e
PE
29482012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2949
2950 composite.c: use 'double' consistently
2951 * composite.c (get_composition_id): Use 'double' consistently
2952 instead of converting 'float' to 'double' and vice versa; this is
2953 easier to understand and avoids a GCC warning.
2954
fd06db5d
GM
29552012-04-09 Glenn Morris <rgm@gnu.org>
2956
50fe702a
GM
2957 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2958 preparation for dumping it with emacs. (Bug#4789)
2959 (leimdir): New variable.
2960 ($(leimdir)/leim-list.el): New rule.
2961 (emacs$(EXEEXT)): Depend on leim-list.el.
2962
fd06db5d
GM
2963 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2964 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2965 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2966
55c131ee
AS
29672012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2968
2969 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2970 proper alignment.
2971
9209588f
JB
29722012-04-07 Juanma Barranquero <lekktu@gmail.com>
2973
2974 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2975 Remove unused local variable.
2976
e3fb2efb
PE
29772012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2978
2979 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2980 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2981 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2982 objects, as mark_maybe_pointer will catch them otherwise.
2983 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2984 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2985
b5385551
PE
29862012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2987
2988 Fix typo that broke non-Windows builds.
2989 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2990
9078ead6
EZ
29912012-04-07 Eli Zaretskii <eliz@gnu.org>
2992
2993 Support building on MS-Windows with libxml2.
2994
2995 * makefile.w32-in (OBJ2): Add xml.$(O).
2996 (GLOBAL_SOURCES): Add xml.c.
2997 ($(BLD)/xml.$(O)): New dependency list.
2998
2999 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3000 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3001 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3002 [!WINDOWSNT]: New macros.
3003 (init_libxml2_functions, libxml2_loaded_p): New functions.
3004 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3005 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3006 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3007 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3008 linked in).
6bbef4e5
JC
3009 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3010 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3011 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3012
3013 * emacs.c: Don't include libxml/parser.h.
3014 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3015 xmlCleanupParser directly.
3016
3017 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3018
3811fdf3
EZ
30192012-04-07 Eli Zaretskii <eliz@gnu.org>
3020
3021 * indent.c (Fvertical_motion): If there is a display string at
3022 point, use it.vpos to compute how many lines to backtrack after
3023 move_it_to point. (Bug#11133)
3024
2f8e16b2
EZ
30252012-04-06 Eli Zaretskii <eliz@gnu.org>
3026
3027 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3028 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3029 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3030 macros related to unification of CJK characters. For the details,
3031 see the discussion following the message here:
3032 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3033
3d439cd1
CY
30342012-04-04 Chong Yidong <cyd@gnu.org>
3035
3036 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3037
8bc53d00
EZ
30382012-04-01 Eli Zaretskii <eliz@gnu.org>
3039
3040 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3041 instead of alloca. (Bug#11138)
3042
3b0512a3
AS
30432012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3044
3045 * w32menu.c (is_simple_dialog): Properly check lisp types.
3046 (Bug#11141)
3047
8427ddd2
EZ
30482012-03-31 Eli Zaretskii <eliz@gnu.org>
3049
979022ef
EZ
3050 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3051 position we get to after a call to move_it_to fails the
3052 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3053 only if we wind up in a string from display property. (Bug#11063)
3054
a6b1c7cc
EZ
3055 * window.c (Fdelete_other_windows_internal): Invalidate the row
3056 and column information about mouse highlight, so that redisplay
3057 restores it after reallocating the glyph matrices. (Bug#7464)
3058
8427ddd2
EZ
3059 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3060 string comes from a `display' text property, use the buffer
3061 position of that property as if we actually saw that position in
3062 the row's glyphs.
697ba24b
EZ
3063 (move_it_by_lines): Remove the assertion that
3064 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3065 violated when there's a before-string at the beginning of a line.
3066 (Bug#11063)
8427ddd2 3067
65a0a738
EZ
30682012-03-30 Eli Zaretskii <eliz@gnu.org>
3069
3070 * xdisp.c (append_space_for_newline): If the default face was
3071 remapped, use the remapped face for the appended newline.
3072 (extend_face_to_end_of_line): Use the remapped default face for
3073 extending the face to the end of the line.
3074 (display_line): Call extend_face_to_end_of_line when the default
3075 face was remapped. (Bug#11068)
3076
581355cc
EZ
30772012-03-29 Eli Zaretskii <eliz@gnu.org>
3078
3079 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3080
e8fc049f
SM
30812012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3082
3083 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3084
4fb9a543
GM
30852012-03-27 Glenn Morris <rgm@gnu.org>
3086
3087 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3088 Doc fixes.
3089
679910f1
KH
30902012-03-26 Kenichi Handa <handa@m17n.org>
3091
3092 * dispextern.h (struct glyph): Fix previous change. Change the
3093 bit length of glyphless.ch to 25 (Bug#11082).
3094
90d49b7f
CY
30952012-03-26 Chong Yidong <cyd@gnu.org>
3096
3097 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3098 (command_loop_1): Use it; inhibit selection update for
3099 handle-select-window too (Bug#8996).
3100
f514f6f0
FP
31012012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3102
e8fc049f 3103 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3104
bf43fa51
KH
31052012-03-25 Kenichi Handa <handa@m17n.org>
3106
3107 * dispextern.h (struct glyph): Change the bit length of
3108 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3109
8a0c01dd
EZ
31102012-03-24 Eli Zaretskii <eliz@gnu.org>
3111
3112 * s/ms-w32.h (tzname): Include time.h before redirecting to
3113 _tzname. Fixes the MSVC build. (Bug#9960)
3114
7d1c3a76
AS
31152012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3116
8ed79523
AS
3117 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3118 characters.
3119
7d1c3a76
AS
3120 * xterm.c (XTread_socket): Only modify handling_signal if
3121 !SYNC_INPUT. (Bug#11080)
3122
e99a9b8b
EZ
31232012-03-23 Eli Zaretskii <eliz@gnu.org>
3124
3125 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3126 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3127 when fetching a multibyte character consumes more bytes than
3128 CHAR_BYTES returns, due to unification of CJK characters in
3129 string_char. (Bug#11073)
3130
5063c0e1
TN
31312012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3132
3133 * process.c (wait_reading_process_output): Handle pty disconnect
3134 by refraining from sending oneself a SIGCHLD (bug#10933).
3135
9f851fbd
CY
31362012-03-22 Chong Yidong <cyd@gnu.org>
3137
3138 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3139
5063c0e1 3140 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3141 Mark string as coming from a prefix property.
3142 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3143 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3144
fb5b8aca
CY
31452012-03-21 Chong Yidong <cyd@gnu.org>
3146
3147 * xfaces.c (Vface_remapping_alist): Doc fix.
3148
62356a1b
EZ
31492012-03-20 Eli Zaretskii <eliz@gnu.org>
3150
3151 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3152 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3153 Doc fixes.
62356a1b 3154
025de85b
CY
31552012-03-20 Chong Yidong <cyd@gnu.org>
3156
3157 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3158 to reflect default non-nil value of redisplay-dont-pause.
3159
4827f94e
KH
31602012-03-19 Kenichi Handa <handa@m17n.org>
3161
3162 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3163 it fit in a valid range (Bug#11003).
3164
e50a24a2
EZ
31652012-03-18 Eli Zaretskii <eliz@gnu.org>
3166
3167 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3168 that is not from display property, accept the row as a "cursor
3169 row" if one of the string's character has a non-nil `cursor'
3170 property. Fixes cursor positioning when there are newlines in
3171 overlay strings, e.g. in icomplete.el. (Bug#11035)
3172
9af5ed87
PE
31732012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3174
3175 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3176
d1f55f16
CY
31772012-03-12 Chong Yidong <cyd@gnu.org>
3178
3179 * eval.c (inhibit_lisp_code): Rename from
3180 inhibit_window_configuration_change_hook; move from window.c.
3181
3182 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3183 * window.c (run_window_configuration_change_hook)
3184 (syms_of_window): Callers changed.
3185
66c5eebd
CY
31862012-03-11 Chong Yidong <cyd@gnu.org>
3187
413df973
CY
3188 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3189
66c5eebd
CY
3190 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3191
1de11f56
CY
31922012-03-10 Chong Yidong <cyd@gnu.org>
3193
3194 * frame.c (other_visible_frames): Don't assume the selected frame
3195 is visible (Bug#10955).
3196
cae07000
SM
31972012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3198
3199 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3200
89c94350
JD
32012012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3202
3203 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3204 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3205 zero (Bug#10954).
3206
999dd333
GM
32072012-03-03 Glenn Morris <rgm@gnu.org>
3208
01a6dcc8 3209 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3210
de0100f2
EZ
32112012-03-02 Eli Zaretskii <eliz@gnu.org>
3212
3213 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3214 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3215 (redisplay_window, next_element_from_string): Fix typos in
3216 comments.
3e441275
EZ
3217 (redisplay_window): Pass to move_it_vertically the margin in
3218 pixels, not in screen lines.
de0100f2 3219
96a72ee9
GM
32202012-03-02 Glenn Morris <rgm@gnu.org>
3221
3222 * buffer.c (buffer-list-update-hook): Doc fix.
3223
312508d7
EZ
32242012-02-29 Eli Zaretskii <eliz@gnu.org>
3225
3226 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3227 push_it before setting up the iterator for the first overlay
3228 string, even if we have an empty string loaded.
3229 (next_overlay_string): If there's an empty string on the iterator
3230 stack, pop the stack. (Bug#10903)
3231
27f3c637
PE
32322012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3233
3234 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3235 Suggested by Stefan Monnier in
3236 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3237 * alloc.c (widen_to_Lisp_Object): New static function.
3238 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3239 and widening them to Lisp_Objects. This would work even if
3240 USE_LSB_TAG is defined and wide integers are used, which might
3241 happen in a future version of Emacs.
3242
3c9dfce6
CY
32432012-02-25 Chong Yidong <cyd@gnu.org>
3244
fa74b241
CY
3245 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3246 Doc fix.
3247
3c9dfce6
CY
3248 * xselect.c (Fx_selection_exists_p): Doc fix.
3249 (x_clipboard_manager_save_all): Print an informative message
3250 before saving to clipboard manager.
3251
9486df08
CY
32522012-02-24 Chong Yidong <cyd@gnu.org>
3253
3254 * keyboard.c (process_special_events): Handle all X selection
3255 requests in kbd_buffer, not just the next one (Bug#8869).
3256
f01d3321
CY
32572012-02-23 Chong Yidong <cyd@gnu.org>
3258
3259 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3260 call when setting menu-bar-lines and tool-bar-lines parameters.
3261 (unwind_create_frame_1): New helper function.
3262
3263 * window.c (inhibit_window_configuration_change_hook): New var.
3264 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3265 (syms_of_window): Initialize it.
f01d3321 3266
86b847b6
CY
32672012-02-22 Chong Yidong <cyd@gnu.org>
3268
3269 * xterm.c (x_draw_image_relief): Add missing type check for
3270 Vtool_bar_button_margin (Bug#10743).
3271
a59225b1
CY
32722012-02-21 Chong Yidong <cyd@gnu.org>
3273
3274 * fileio.c (Vfile_name_handler_alist): Doc fix.
3275
3276 * buffer.c (Fget_file_buffer): Protect against invalid file
3277 handler return value.
3278
310f5bd4
PE
32792012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3280
cb3a28cc
PE
3281 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3282 when computing $valmask.
3283
310f5bd4
PE
3284 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3285 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3286 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3287 It's useless in that case, and it can cause problems on hosts
3288 that allocate halves of EMACS_INT values separately.
3289 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3290 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3291 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3292 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3293 it avoids undefined behavior on hosts where shifting right by more
3294 than the word width has undefined behavior.
3295
2375c96a
CY
32962012-02-19 Chong Yidong <cyd@gnu.org>
3297
3298 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3299 (Funhandled_file_name_directory, Ffile_name_as_directory)
3300 (Fdirectory_file_name, Fexpand_file_name)
3301 (Fsubstitute_in_file_name): Protect against invalid file handler
3302 return values (Bug#10845).
3303
3eb49e71
EZ
33042012-02-18 Eli Zaretskii <eliz@gnu.org>
3305
3306 * .gdbinit (pitx): Fix incorrect references to fields of the
3307 iterator stack.
3308
7b926f3f
CY
33092012-02-17 Chong Yidong <cyd@gnu.org>
3310
3311 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3312
11273115
PE
33132012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3314
3315 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3316 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3317
c3a70e2b
CY
33182012-02-15 Chong Yidong <cyd@gnu.org>
3319
3320 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3321 marked as special. Also, starting docstrings with * is obsolete.
3322
0ca43699
AS
33232012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3324
3325 * gnutls.c (emacs_gnutls_write): Fix last change.
3326
2e8f3c56
LI
33272012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3328
3329 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3330 send_process.
3331
af70074f
SM
33322012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3333
3334 * keymap.c (Fsingle_key_description): Handle char ranges.
3335
95986d52
CY
33362012-02-12 Chong Yidong <cyd@gnu.org>
3337
afd83bd1
CY
3338 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3339 as that creates a dangerous corner case.
3340
95986d52
CY
3341 * window.c (Fdelete_window_internal): Invalidate the mouse
3342 highlight (Bug#9904).
3343
bd7da63e
GM
33442012-02-12 Glenn Morris <rgm@gnu.org>
3345
3346 * xselect.c (Fx_own_selection_internal)
3347 (Fx_get_selection_internal, Fx_disown_selection_internal)
3348 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3349 * nsselect.m (Fx_own_selection_internal)
3350 (Fx_disown_selection_internal, Fx_selection_exists_p)
3351 (Fx_selection_owner_p, Fx_get_selection_internal):
3352 Sync docs and argument specs with the xselect.c versions.
3353
77abcbc2
LI
33542012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3355
3356 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3357
90b671e2
EZ
33582012-02-11 Eli Zaretskii <eliz@gnu.org>
3359
1c0ca0b7
EZ
3360 * w32select.c (Fx_selection_exists_p): Sync doc string and
3361 argument list with xselect.c. (Bug#10783)
3362
3363 * w16select.c (Fx_selection_exists_p): Sync doc string and
3364 argument list with xselect.c. (Bug#10783)
90b671e2 3365
49241268
GM
33662012-02-10 Glenn Morris <rgm@gnu.org>
3367
3368 * fns.c (Fsecure_hash): Doc fix.
3369
f998bbe7 33702012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3371
3372 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3373
0992bd9c
CY
33742012-02-07 Chong Yidong <cyd@gnu.org>
3375
3376 * buffer.c (Fbuffer_local_variables)
3377 (buffer_lisp_local_variables): Handle unbound vars correctly;
3378 don't let Qunbound leak into Lisp.
3379
af008560
GM
33802012-02-07 Glenn Morris <rgm@gnu.org>
3381
dd605cc4
GM
3382 * image.c (Fimagemagick_types): Doc fix.
3383
af008560
GM
3384 * image.c (imagemagick-render-type): Change it from a lisp object
3385 to an integer. Move the doc here from the lisp manual.
3386 Treat all values not equal to 0 the same.
3387
1449fa1d
CY
33882012-02-06 Chong Yidong <cyd@gnu.org>
3389
3390 * doc.c (store_function_docstring): Avoid applying docstring of
3391 alias to base function (Bug#2603).
3392
3723ec07
AS
33932012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3394
3395 * .gdbinit (pp1, pv1): Remove redundant defines.
3396 (pr): Use pp.
3397
79c1cc1e
CY
33982012-02-04 Chong Yidong <cyd@gnu.org>
3399
3400 * nsterm.m: Declare a global (Bug#10694).
3401
d7f29f8e
EZ
34022012-02-04 Eli Zaretskii <eliz@gnu.org>
3403
cae07000
SM
3404 * w32.c (get_emacs_configuration_options):
3405 Include --enable-checking, if specified, in the return value.
d7f29f8e 3406
3b95a6f9
MR
34072012-02-04 Martin Rudalics <rudalics@gmx.at>
3408
3409 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3410 after rounding frame sizes. (Bug#9723)
3411
d6fa96a6
EZ
34122012-02-04 Eli Zaretskii <eliz@gnu.org>
3413
3414 * keyboard.c (adjust_point_for_property): Don't position point
3415 before BEGV. (Bug#10696)
3416
df0b2940
PE
34172012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3418
3419 Handle overflow when computing char display width (Bug#9496).
3420 * character.c (char_width): Return EMACS_INT, not int.
3421 (char_width, c_string_width): Check for overflow when
3422 computing the width; this is possible now that individual
3423 characters can have unbounded width. Problem introduced
3424 by merge from Emacs 23 on 2012-01-19.
3425
6bee44d6
MA
34262012-02-02 Michael Albinus <michael.albinus@gmx.de>
3427
3428 * dbusbind.c (Fdbus_register_method): Mention the return value
3429 :ignore in the docstring.
3430
44f92739
GM
34312012-02-02 Glenn Morris <rgm@gnu.org>
3432
1b9f60cc
GM
3433 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3434
44f92739
GM
3435 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3436 Unconditionally set to t. (Bug#10673)
3437 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3438 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3439 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3440
c5d3843c
KH
34412012-02-02 Kenichi Handa <handa@m17n.org>
3442
3443 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3444 0, do not call append_composite_glyph.
3445
159462d4 34462012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3447
3448 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3449 NULL (Bug#6988).
3450 (x_produce_glyphs): If the component of a composition is a null
3451 string, set it->pixel_width to 1 to avoid zero-width glyph.
3452
78cef877
EZ
34532012-02-01 Eli Zaretskii <eliz@gnu.org>
3454
3455 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3456 first 2 arguments are identical. This makes inserting large
3457 output from a subprocess an order of magnitude faster on
3458 MS-Windows, where all sbrk'ed memory is always contiguous.
3459
97897668
GM
34602012-01-31 Glenn Morris <rgm@gnu.org>
3461
3462 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3463 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3464 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3465
31fd3586
GM
34662012-01-29 Glenn Morris <rgm@gnu.org>
3467
3468 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3469
0e24a8b2
CY
34702012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3471
3472 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3473
cc0adcb0
CY
34742012-01-28 Chong Yidong <cyd@gnu.org>
3475
3476 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3477
acc28cb9
CY
34782012-01-26 Chong Yidong <cyd@gnu.org>
3479
9c69cfb7
CY
3480 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3481
acc28cb9
CY
3482 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3483 repeat counts (Bug#10507).
3484
48da7392
GM
34852012-01-26 Glenn Morris <rgm@gnu.org>
3486
3487 * lread.c (syms_of_lread): Doc fix.
3488
14af5f7f
CY
34892012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3490
3491 * coding.c (encode_designation_at_bol): Change return value to
3492 EMACS_INT.
3493
0b21c100
CY
34942012-01-25 Chong Yidong <cyd@gnu.org>
3495
3496 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3497
3c2907f7
CY
34982012-01-21 Chong Yidong <cyd@gnu.org>
3499
3500 * floatfns.c (Fcopysign): Make the second argument non-optional,
3501 since nil is not allowed anyway.
3502
959ad23f
AS
35032012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3504
3505 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3506 (send_process): Likewise.
3507
34a02f46
MR
35082012-01-19 Martin Rudalics <rudalics@gmx.at>
3509
3510 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3511 (Vwindow_persistent_parameters): Do not use Qstate.
3512 Rewrite doc-strings.
34a02f46 3513
1259009a 35142012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3515
3516 * character.c (char_width): New function.
70d4fdf6
GM
3517 (Fchar_width, c_string_width, lisp_string_width):
3518 Use char_width (Bug#9496).
25ed9e61 3519
6a6ee00d
MR
35202012-01-16 Martin Rudalics <rudalics@gmx.at>
3521
3522 * window.c (Vwindow_persistent_parameters): New variable.
3523 (Fset_window_configuration, save_window_save): Handle persistent
3524 window parameters.
3525
c85efaf7
EZ
35262012-01-14 Eli Zaretskii <eliz@gnu.org>
3527
3528 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3529 thrashing the stack of the thread. (Bug#9087)
3530
5944709e
PE
35312012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3532
3533 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3534
e71f5d99
EZ
35352012-01-11 Eli Zaretskii <eliz@gnu.org>
3536
3537 * xdisp.c (rows_from_pos_range): Handle the case where the
3538 highlight ends on a newline. (Bug#10464)
3539 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3540 he end column for display of highlight that ends on a newline
3541 before a R2L line.
3542
ce316182
GM
35432012-01-11 Glenn Morris <rgm@gnu.org>
3544
3545 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3546 from load-path also when installation-directory is nil. (Bug#10208)
3547
5b43da69
GM
35482012-01-10 Glenn Morris <rgm@gnu.org>
3549
74cc8ff9
GM
3550 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3551
7d8d6e4e
GM
3552 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3553 Update template values to be closer to their typical values these days.
5b43da69 3554
a0db8d43
EZ
35552012-01-09 Eli Zaretskii <eliz@gnu.org>
3556
3557 * xdisp.c (rows_from_pos_range): Accept additional argument
3558 DISP_STRING, and accept any glyph in a row whose object is that
3559 string as eligible for mouse highlight. Fixes mouse highlight of
3560 display strings from overlays. (Bug#10464)
3561
9a0115ab 35622012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3563
b9110d6a 3564 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3565 * fileio.c (auto_saving_dir_umask): New static var.
3566 (Fmake_directory_internal): Use it.
3567 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3568 creating the directory. The old code temporarily assigns
3569 too-generous permissions to the directory.
3570 (do_auto_save_eh): Clear it.
b9110d6a 3571 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3572 that the var is always cleared.
3573
6c1bd3f3
EZ
35742012-01-07 Eli Zaretskii <eliz@gnu.org>
3575
3576 * search.c (scan_buffer): Pass character positions to
3577 know_region_cache, not byte positions. (Bug#6540)
3578
069d2b50
L
35792012-01-07 LynX <_LynX@bk.ru> (tiny change)
3580
3581 * w32.c (sys_rename): Report EXDEV when rename of a directory
3582 fails because the target is on another logical disk. (Bug#10284)
3583
75bf0d33
DB
35842012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3585
3586 * xterm.c (x_embed_request_focus): New function.
3587
3588 * xterm.h: Add prototype.
3589
3590 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3591
1c6e5a32
GM
35922012-01-05 Glenn Morris <rgm@gnu.org>
3593
3594 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3595
651e947e
EZ
35962012-01-01 Eli Zaretskii <eliz@gnu.org>
3597
3598 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3599 Load gnutls_transport_set_lowat only if GnuTLS version is below
3600 2.11.1.
3601 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3602 GnuTLS versions below 2.11.1.
3603
3778cdd8
AL
36042011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3605
3606 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3607 to the doc string advising against its use for altering the way
3608 windows are scrolled.
3609
0e5317f7
KH
36102011-12-28 Kenichi Handa <handa@m17n.org>
3611
3612 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3613 coding-system ASCII compatible only when it does not produce BOM
3614 on encoding (Bug#10383).
3615
93d5ca1f
JD
36162011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3617
3618 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3619 can scroll.
3620 (create_and_show_popup_menu): Always use menu_position_func for
3621 Gtk3 (Bug#10361).
3622
ca22b785
AS
36232011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3624
3625 * callint.c (Fcall_interactively): Don't truncate prompt string.
3626
d048e1e6
EZ
36272011-12-23 Eli Zaretskii <eliz@gnu.org>
3628
3629 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3630 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3631 resumed from there (after widening). (Bug#10360)
d048e1e6 3632
5ccaba1f
JD
36332011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3634
3635 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3636
204ee57f
JD
36372011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3638
b81d40f0
JB
3639 * nsterm.m (x_free_frame_resources):
3640 Release f->output_data.ns->miniimage.
204ee57f
JD
3641 (ns_index_color): Fix indentation. Do not retain
3642 color_table->colors[i].
3643
3644 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3645 before returning.
3646
3647 * nsfns.m (x_set_background_color): Assign return value from
3648 ns_index_color to face-background instead of NSColor*.
3649 (ns_implicitly_set_icon_type): Fix indentation.
3650 Change assignment in for loop to comparison.
3651
3652 * emacs.c (ns_pool): New variable.
3653 (main): Assign ns_pool.
3654 (Fkill_emacs): Call ns_release_autorelease_pool.
3655
3656 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3657 autorelease fdesc, release fdAttrs and tdict.
3658 (ns_get_covering_families): Release charset.
3659 (ns_findfonts): Release NSFontDescriptor created with new.
3660 (ns_uni_to_glyphs): Fix indentation.
3661 (setString): Release attrStr before assigning new value.
3662
c803b2b7
JD
36632011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3664
678f4426
JD
3665 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3666 and NS_IMPL_COCOA.
3667 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3668 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3669
cd394be1 36702011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3671
5fecd5fc
JD
3672 * nsterm.m (ns_term_init): Subscribe for notifications
3673 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3674 to method trackingNotification in EmacsMenu.
3675
3676 * nsmenu.m (trackingMenu): New variable.
3771cb17 3677 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3678 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3679 from Aquamacs (Bug#7030).
678f4426
JD
3680
36812011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3682
c803b2b7
JD
3683 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3684 (symbol_to_nsstring): Fix indentation.
3685 (ns_symbol_to_pb): New function.
cae07000
SM
3686 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3687 (Fns_rotate_cut_buffers_internal): Remove.
3688 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3689 Fns_store_cut_buffer_internal.
3690 (ns_get_foreign_selection, Fx_own_selection_internal)
3691 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3692 (Fns_get_selection_internal, Fns_store_selection_internal):
3693 Use ns_symbol_to_pb and check if return value is nil.
3694 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3695 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3696 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3697 renamed to Sns_store_selection_internal.
3698 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3699 and remove this function.
3700 (ns_handle_selection_clear): Remove, never used.
3701 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3702 here.
3703
e1b01a3a
KB
37042011-12-17 Ken Brown <kbrown@cornell.edu>
3705
3706 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3707 GID is unknown (Bug#10257).
3708
2adb6e85
PE
37092011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3710
3711 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3712 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3713 which caused a build failure on GNU/Linux IA-64. This problem was
3714 introduced by my 2011-10-07 patch.
3715
d1d7b339
JL
37162011-12-15 Juri Linkov <juri@jurta.org>
3717
3718 * image.c (imagemagick_error): New function. (Bug#10112)
3719 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3720 Use `imagemagick_error' where ImageMagick functions return
3721 `MagickFalse'.
3722 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3723 proper order.
3724
100d5755
KH
37252011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3726
3727 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3728 fill background (Bug#8992).
3729
454592a6
MR
37302011-12-13 Martin Rudalics <rudalics@gmx.at>
3731
3732 * window.c (Vwindow_combination_resize)
3733 (Vwindow_combination_limit): Use t instead of non-nil in
3734 doc-strings.
61d4b438
MR
3735 (Vrecenter_redisplay): Add first sentence of doc-string on
3736 separate line.
53524d93 3737 (Frecenter): Fix doc-string typo.
454592a6 3738
3633e3aa
KH
37392011-12-11 Kenichi Handa <handa@m17n.org>
3740
3741 * coding.c (Funencodable_char_position): Pay attention to the
3742 buffer text relocation (Bug#9389).
3743
7b9d523a 37442011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3745
7b9d523a
JD
3746 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3747 gtk_init (Bug#10100).
3748
b73189c6
EZ
37492011-12-10 Eli Zaretskii <eliz@gnu.org>
3750
3751 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3752 IT->string is nil. (Bug#10263)
3753
f7dfe5d6
JD
37542011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3755
83faebb4
JD
3756 * nsterm.h (x_free_frame_resources): Declare.
3757
f7dfe5d6
JD
3758 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3759 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3760
3761 * nsterm.h (ns_get_defaults_value): Declare.
3762
3763 * nsterm.m (ns_default): Call ns_get_defaults_value.
3764
7cd4e72c
EZ
37652011-12-09 Eli Zaretskii <eliz@gnu.org>
3766
3767 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3768 (Bug#10170)
3769
b34d7317
YM
37702011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3771
3772 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3773 that where the value of an _OBJC_* symbol points to is in the .bss
3774 section (Bug#10240).
3775
76470ad1
KH
37762011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3777
3778 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3779 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3780
745fff94
KH
37812011-12-08 Kenichi Handa <handa@m17n.org>
3782
3783 * ftfont.c (get_adstyle_property): Fix previous change
3784 (Bug#10233).
3785
6e44397c
JB
37862011-12-07 Juanma Barranquero <lekktu@gmail.com>
3787
3788 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3789 dirs from the default value of EMACSLOADPATH (bug#10208).
3790
7efa6272
GM
37912011-12-07 Glenn Morris <rgm@gnu.org>
3792
3793 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3794 installation and source directories as well. (Bug#10208)
3795
f6fc4d87
CY
37962011-12-06 Chong Yidong <cyd@gnu.org>
3797
3798 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3799
2bf26180
GM
38002011-12-06 Glenn Morris <rgm@gnu.org>
3801
3802 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3803 as an error, not just -1. (Bug#10217)
3804
3a6ad4f0
CY
38052011-12-05 Chong Yidong <cyd@gnu.org>
3806
3807 * keyboard.c (process_special_events): New function.
3808 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3809
75a3b399
PE
38102011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3811
3812 * coding.c (encode_designation_at_bol): Don't use uninitialized
3813 local variable (Bug#9318).
3814
c3c9e25e
KH
38152011-12-05 Kenichi Handa <handa@m17n.org>
3816
3817 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3818 return Qnil (Bug#8046, Bug#10193).
3819
5eb05ea3
KH
38202011-12-05 Kenichi Handa <handa@m17n.org>
3821
3822 * coding.c (encode_designation_at_bol): New args charbuf_end and
3823 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3824 (coding_set_source): Return how many bytes coding->source was
3825 relocated.
3826 (coding_set_destination): Return how many bytes
3827 coding->destination was relocated.
3828 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3829 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3830
38312011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3832
3833 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3834 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3835 macro (Bug#9318).
3836
38372011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3838
3839 The following changes are to fix Bug#9318.
3840
a79703f5 3841 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3842 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3843 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3844 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3845
7dbda6df
JB
38462011-12-05 Juanma Barranquero <lekktu@gmail.com>
3847
3848 * lisp.h (process_quit_flag): Fix external declaration.
3849
6d5eb5b0
SM
38502011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3851
3852 Don't macro-inline non-performance-critical code.
3853 * eval.c (process_quit_flag): New function.
3854 * lisp.h (QUIT): Use it.
3855
a0c3fad0
JD
38562011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3857
3858 * nsfns.m (get_geometry_from_preferences): New function.
3859 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3860
6c07aac2
AS
38612011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3862
3863 * emacs.c (Qkill_emacs): Define.
3864 (syms_of_emacs): Initialize it.
3865 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3866 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3867 (quit_throw_to_read_char): Add parameter `from_signal'.
3868 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3869 * lisp.h (QUIT): Call Fkill_emacs if requested.
3870
c052ead4
JD
38712011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3872
3873 * widget.c (update_wm_hints): Return if wmshell is null.
3874 (widget_update_wm_size_hints): New function.
3875
3876 * widget.h (widget_update_wm_size_hints): Declare.
3877
3878 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3879 widget_update_wm_size_hints (Bug#10104).
3880
9e49252b
EZ
38812011-12-03 Eli Zaretskii <eliz@gnu.org>
3882
3883 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3884 before a newline, prepare the bidi iterator for consuming the
3885 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3886 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3887
02b16839
JL
38882011-12-02 Juri Linkov <juri@jurta.org>
3889
3890 * search.c (Fword_search_regexp): New Lisp function created from
3891 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3892 (Fword_search_backward, Fword_search_forward)
3893 (Fword_search_backward_lax, Fword_search_forward_lax):
3894 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3895 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3896
0068070e
SM
38972011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3898
3899 * fileio.c (Finsert_file_contents): Move after-change-function call
3900 to before the "handled:" label, since all "goto handled" appear in
3901 cases where the *-change-functions have already been properly called
3902 (bug#10117).
3903
3360a3fc
AS
39042011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3905
3906 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3907 waiting for input. (Bug#10169)
3908
73d6c093
EZ
39092011-11-30 Eli Zaretskii <eliz@gnu.org>
3910
3911 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3912 verifies glyph row's hash code--we have just reallocated the
3913 glyphs, so their contents can be complete garbage. (Bug#10164)
3914
febe6bea
JB
39152011-11-30 Juanma Barranquero <lekktu@gmail.com>
3916
3917 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3918
801a4313
EZ
39192011-11-30 Eli Zaretskii <eliz@gnu.org>
3920
3921 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3922 attributes are tested _before_ calling verify_row_hash, to protect
3923 against GCC re-ordering of the tests. (Bug#10164)
3924
2b56b87e
JD
39252011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3926
3927 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3928
3929 * xterm.c (handle_one_xevent): Only set async_visible and friends
3930 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3931 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3932 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3933
dbf31225
PE
39342011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3935
3936 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3937 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3938 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3939 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3940 All uses changed to use GCPRO1 etc.
3941 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3942 Revert to old implementation (i.e., before 2011-03-11).
3943
1305621b
YM
39442011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3945
3946 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3947 of scroll runs so as to avoid assigning disabled bogus rows and
3948 unnecessary graphics copy operations.
3949
8c9afb46
EZ
39502011-11-27 Eli Zaretskii <eliz@gnu.org>
3951
3952 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3953 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3954 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3955 (malloc, free, realloc, calloc): Redirect to e_* only when
3956 compiling Emacs.
3957
3958 * lisp.h (GCTYPEBITS): Move before first use.
3959 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3960 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3961 this macro definition.
3962
3963 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3964 _MSC_VER.
3965
54e9e3bf
JD
39662011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3967
6d5eb5b0
SM
3968 * gtkutil.c (xg_create_frame_widgets):
3969 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3970 present with Gtk+ 2.0.
3971
83aca1cb
PE
39722011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3973
3974 * fileio.c (Finsert_file_contents): Undo previous change; see
3975 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3976
5b76caa4
PE
39772011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3978
3979 Rename locals to avoid shadowing.
3980 * fileio.c (Finsert_file_contents):
3981 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3982 * process.c (wait_reading_process_output):
3983 Rename inner 'proc' to 'p' to avoid shadowing.
3984 Indent for consistency with usual Emacs style.
3985
8c535114
EZ
39862011-11-25 Eli Zaretskii <eliz@gnu.org>
3987
3988 * xdisp.c (redisplay_window): If cursor row is not fully visible
3989 after recentering, and scroll-conservatively is set to a large
3990 number, scroll window by a few more lines to make the cursor fully
3991 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3992 (start_display): Don't move to the next line if the display should
3993 start at a newline that is part of a display vector or an overlay
3994 string. (Bug#10119)
8c535114 3995
fa4fdb5c
JL
39962011-11-24 Juri Linkov <juri@jurta.org>
3997
3998 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3999 after the `MagickPingImage' call. (Bug#10112)
4000
90ec88df
CY
40012011-11-23 Chong Yidong <cyd@gnu.org>
4002
4003 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4004
56e2e794
MR
40052011-11-23 Martin Rudalics <rudalics@gmx.at>
4006
4007 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4008 making another buffer current. (Bug#10114)
4009
b6e64c41
GM
40102011-11-23 Glenn Morris <rgm@gnu.org>
4011
4012 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4013
6b21de18
CY
40142011-11-23 Chong Yidong <cyd@gnu.org>
4015
4016 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4017 using it (Bug#5984).
4018
b12cd789
EZ
40192011-11-22 Eli Zaretskii <eliz@gnu.org>
4020
4021 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4022 and header-lines, as they don't have one computed for them.
4023 (Bug#10098)
4024
4025 * .gdbinit (prow): Make displayed values more self-explaining.
4026 Add row's hash code.
4027
261b6fd4
LMI
40282011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4029
4030 * process.c (wait_reading_process_output): Fix asynchrounous
4031 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4032 (wait_reading_process_output): Add comment and URL.
261b6fd4 4033
e7cfd277
JD
40342011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4035
4036 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4037
a9b9b7f5
CY
40382011-11-21 Chong Yidong <cyd@gnu.org>
4039
4040 * window.c (Fnext_window, Fprevious_window): Doc fix.
4041
b0d15b4f
SM
40422011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4043
4044 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4045
fe7a3057
JB
40462011-11-20 Juanma Barranquero <lekktu@gmail.com>
4047
4048 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4049
d2999b1a
MR
40502011-11-20 Martin Rudalics <rudalics@gmx.at>
4051
4052 * window.c (Fset_window_combination_limit): Rename argument
4053 STATUS to LIMIT.
4054 (Vwindow_combination_limit): Remove "status" from doc-string.
4055
d5ff9cd0
AS
40562011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4057
4058 * m/ibms390.h: Remove.
4059 * m/ibms390x.h: Don't include "ibms390.h".
4060
a5bb9bd3
SM
40612011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4062
4063 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4064 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4065
cd1181db
JB
40662011-11-20 Juanma Barranquero <lekktu@gmail.com>
4067
4068 * casetab.c (Fset_case_table):
4069 * charset.c (Fcharset_after): Fix typos.
4070
615a3b8d 40712011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4072
17e845af
PE
4073 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4074 Otherwise, valgrind does not work on some platforms.
4075 Problem reported by Andreas Schwab in
6a0bf43d
PE
4076 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4077 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4078 is set, removing the need for VIRT_ADDRESS_VARIES.
4079 (PURE_P): Use a more-efficient implementation that needs just one
4080 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4081 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4082 to 4 (xorl, subq, cmpq, setbe).
4083 * alloc.c (pure): Always extern now, since that's the
4084 VIRT_ADDR_VARIES behavior.
4085 (PURE_POINTER_P): Use a single comparison, not two, for
4086 consistency with the new puresize.h.
4087 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4088 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4089 Remove VIRT_ADDR_VARIES no longer needed.
4090
f8fe6f96
EZ
40912011-11-19 Eli Zaretskii <eliz@gnu.org>
4092
4093 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4094 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4095 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4096 behave as if the cursor position were at the window margin.
4097
4098 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4099 and the cursor position is out of bounds, behave as if the cursor
4100 position were at the window margin. (Bug#10075)
4101
df05a53c
CY
41022011-11-18 Chong Yidong <cyd@gnu.org>
4103
4104 * window.c (Fwindow_combination_limit): Make first argument
4105 non-optional, since it is meaningless for live windows like the
4106 selected window.
61ccba97 4107
2071918e
DA
41082011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4109
4110 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4111
b50a28de
SM
41122011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4113
4114 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4115 (graft_intervals_into_buffer): Simplify.
4116
015137db
EZ
41172011-11-18 Eli Zaretskii <eliz@gnu.org>
4118
4119 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4120 hash values of the two rows.
4121 (copy_row_except_pointers): Preserve the used[] arrays and the
4122 hash values of the two rows. (Bug#10035)
68c95424 4123 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4124
4125 * xdisp.c (row_hash): New function, body extracted from
4126 compute_line_metrics.
4127 (compute_line_metrics): Call row_hash, instead of computing the
4128 hash code inline.
4129
4130 * dispnew.c (verify_row_hash): Call row_hash for computing the
4131 hash code of a row, instead of duplicating code from xdisp.c.
4132
4133 * dispextern.h (row_hash): Add prototype.
4134
a2addb04
TH
41352011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4136
4137 * frame.c (delete_frame): Don't delete the terminal when the last
4138 X frame is closed if emacs is built with GTK toolkit.
4139
df85d315
JB
41402011-11-17 Juanma Barranquero <lekktu@gmail.com>
4141
4142 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4143
a0c2d0ae
MR
41442011-11-17 Martin Rudalics <rudalics@gmx.at>
4145
4146 * window.c (Vwindow_splits): Rename to
4147 Vwindow_combination_resize. Suggested by Juri Linkov.
4148 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4149 of Vwindow_splits.
4150
58179cce
JB
41512011-11-16 Juanma Barranquero <lekktu@gmail.com>
4152
7877f373
JB
4153 * nsfns.m (Fns_font_name):
4154 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4155
b6f67890
MR
41562011-11-16 Martin Rudalics <rudalics@gmx.at>
4157
4158 * window.h (window): Rename slot "nest" to "combination_limit".
4159 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4160 (Fset_window_nest): Rename to Fset_window_combination_limit.
4161 (Vwindow_nest): Rename to Vwindow_combination_limit.
4162 (recombine_windows, make_parent_window, make_window)
4163 (Fsplit_window_internal, saved_window)
4164 (Fset_window_configuration, save_window_save): Rename all
4165 occurrences of window_nest to window_combination_limit.
4166
c7015153
JB
41672011-11-15 Juanma Barranquero <lekktu@gmail.com>
4168
4169 * image.c (imagemagick_load_image): Fix typo.
4170
322ad6ec
EZ
41712011-11-14 Eli Zaretskii <eliz@gnu.org>
4172
4173 * xdisp.c (display_line): Move the call to
4174 highlight_trailing_whitespace before the call to
4175 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4176 faces of all the glyphs to compute ROW's hash value.
4177 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4178
f067b8ec
JB
41792011-11-14 Juanma Barranquero <lekktu@gmail.com>
4180
4181 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4182 just return (bug#10044).
4183
1e5b2111
EZ
41842011-11-12 Eli Zaretskii <eliz@gnu.org>
4185
7ef3cbd5
EZ
4186 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4187 with user-defined heap size. Bump the default size of the temacs
4188 heap to 27MB, to avoid memory warning when running temacs.
4189 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4190
1e5b2111
EZ
4191 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4192 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4193 (verify_row_hash) [XASSERTS]: New function.
4194 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4195 that the hash value of glyph rows is correct.
1e5b2111 4196
89d61221
MR
41972011-11-12 Martin Rudalics <rudalics@gmx.at>
4198
4199 * window.h (window): Remove splits slot.
4200 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4201 (Fdelete_other_windows_internal, make_parent_window)
4202 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4203 (Fset_window_configuration, save_window_save): Don't deal with
4204 split status of windows.
4205 (saved_window): Remove splits slot.
4206 (Vwindow_splits): Rewrite doc-string.
4207
97f18cc8
JD
42082011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4209
4210 * xfns.c (unwind_create_frame):
4211 * nsfns.m (unwind_create_frame):
4212 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4213 Vframe_list (Bug#9999).
4214
22a648b4
DA
42152011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4216
0b381c7e 4217 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4218
659afede
KH
42192011-11-11 Kenichi Handa <handa@m17n.org>
4220
4221 * callproc.c (Fcall_process): Set the member dst_multibyte of
4222 process_coding.
4223
9ac0394b
KH
42242011-11-11 Johan Bockgård <bojohan@gnu.org>
4225
4226 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4227 avoid a crash (bug#9496).
4228
2fbdc249
CY
42292011-11-09 Chong Yidong <cyd@gnu.org>
4230
4231 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4232 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4233
ac6b1f81
PE
42342011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4235
4236 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4237
09db192c
PE
42382011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4239
4240 Avoid some portability problems by eschewing 'extern inline' functions.
4241 The trivial performance wins aren't worth the portability hassles; see
4242 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4243 et seq.
4244 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4245 (window_box_width, window_box_left, window_box_left_offset)
4246 (window_box_right, window_box_right_offset): Undo previous change,
4247 by removing the "extern"s.
4248 * intervals.c (adjust_intervals_for_insertion)
4249 (adjust_intervals_for_deletion): Undo previous change,
4250 making these static again.
4251 (offset_intervals, temp_set_point_both, temp_set_point)
4252 (copy_intervals_to_string): No longer inline.
4253 * xdisp.c (window_text_bottom_y, window_box_width)
4254 (window_box_height, window_box_left_offset)
4255 (window_box_right_offset, window_box_left, window_box_right)
4256 (window_box): No longer inline.
4257
105216ed
CY
42582011-11-08 Chong Yidong <cyd@gnu.org>
4259
4260 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4261 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4262 Signal an error if not a live window.
105216ed
CY
4263 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4264 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4265
ae9e237f
JB
42662011-11-07 Juanma Barranquero <lekktu@gmail.com>
4267
4268 * lisp.h (syms_of_abbrev): Remove declaration.
4269 Reported by CHENG Gao <chenggao@royau.me>.
4270
c7aa8333
EZ
42712011-11-07 Eli Zaretskii <eliz@gnu.org>
4272
4273 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4274 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4275 of temacs in GUI mode.
4276
be7f5545
MR
42772011-11-07 Martin Rudalics <rudalics@gmx.at>
4278
4279 * window.h: Declare delete_all_child_windows instead of
4280 delete_all_subwindows.
4281 * window.c (Fwindow_nest, Fset_window_nest)
4282 (Fset_window_new_total, Fset_window_new_normal)
4283 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4284 (delete_all_subwindows): Rename to delete_all_child_windows.
4285 (Fdelete_other_windows_internal, Fset_window_configuration):
4286 Call delete_all_child_windows instead of delete_all_subwindows.
4287 * frame.c (delete_frame): Call delete_all_child_windows instead
4288 of delete_all_subwindows.
4289
ca78dc43
PE
42902011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4291
4292 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4293 This is also needed for porting to any host where GC_MARK_STACK is
4294 not GC_MAKE_GCPROS_NOOPS.
4295 (which_symbols): Use it.
4296
a0241d01
KH
42972011-11-07 Kenichi Handa <handa@m17n.org>
4298
4299 * coding.c (coding_set_destination): Check coding->src_pos only
4300 when coding->src_object is a buffer (bug#9910).
4301
4302 * process.c (send_process): Set the member src_multibyte of coding
4303 to 0 (bug#9911) when sending a unibyte text.
4304
4305 * callproc.c (Fcall_process): Set the member src_multibyte of
4306 process_coding to 0 (bug#9912).
4307
a64bfdfa 43082011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4309
4310 * xmenu.c (cleanup_widget_value_tree): New function.
4311 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4312 calling free_menubar_widget_value_tree directly (Bug#9830).
4313
cb41b32a
PE
43142011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4315
4316 Fix some portability problems with 'inline'.
4317 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4318 (window_box_width, window_box_left, window_box_left_offset)
4319 (window_box_right, window_box_right_offset): Declare extern.
4320 Otherwise, these inline functions do not conform to C99 and
4321 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4322 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4323 * intervals.c (adjust_intervals_for_insertion)
4324 (adjust_intervals_for_deletion): Now extern, because otherwise the
4325 extern inline functions 'offset_intervals' couldn't refer to it.
4326 (static_offset_intervals): Remove.
4327 (offset_intervals): Rewrite using the old contents of
4328 static_offset_intervals. The old version didn't conform to C99
4329 because an extern inline function contained a reference to an
4330 identifier with static linkage.
4331
b7041366
AS
43322011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4333
4334 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4335 GC.
4336
88a37c4d
EZ
43372011-11-06 Eli Zaretskii <eliz@gnu.org>
4338
4339 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4340 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4341 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4342 return Qleft_to_right.
4343
49745b39
CY
43442011-11-06 Chong Yidong <cyd@gnu.org>
4345
4346 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4347 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4348 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4349 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4350 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4351 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4352 (Fwindow_vscroll): Doc fix.
4353 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4354 argument, since it makes no sense to pass a live window and for
4355 consistency with window-child.
4356
1f05cd82
CS
43572011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4358
4359 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4360 support MSVC.
4361
22610910
JR
43622011-11-05 Jason Rumney <jasonr@gnu.org>
4363
4364 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4365 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4366 fonts (Bug#6029).
4367 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4368 bitwise arithmetic preventing use of unicode-sip and non-truetype
4369 opentype fonts.
4370
a06776b2
EZ
43712011-11-05 Eli Zaretskii <eliz@gnu.org>
4372
3ad924ba
EZ
4373 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4374 "emacs"-only part.
4375
a06776b2
EZ
4376 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4377 initialization code to keep similarity to xfns.c after changes
4378 from 2011-11-05.
4379
c9e7db78
JD
43802011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4381
a97f8f3f
JD
4382 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4383 (unwind_create_frame): New function (Bug#9943).
4384 (Fx_create_frame): Restructure code to be more similar to the one in
4385 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4386 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4387 Move terminal->reference_count++ just before making the frame official
4388 (Bug#9943).
4389
4390 * nsterm.m (x_free_frame_resources): New function.
4391 (x_destroy_window): Move code to x_free_frame_resources.
4392
c9e7db78 4393 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4394 (Fx_create_frame, x_create_tip_frame):
4395 Move terminal->reference_count++ just before making the frame
75f1671a 4396 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4397 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4398
a6fc3b5c
EZ
43992011-11-05 Eli Zaretskii <eliz@gnu.org>
4400
4401 Support MSVC build with newer versions of Visual Studio.
4402 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4403 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4404 nt/gmake.defs.
4405
4406 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4407 which are not supported by MSVC.
4408 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4409 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4410 bitfields.
4411 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4412 types in bitfields.
4413 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4414
4415 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4416
58179cce 44172011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4418
4419 Support MSVC build with newer versions of Visual Studio.
4420 * w32.c: Don't include w32api.h for MSVC.
4421 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4422
4423 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4424 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4425 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4426 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4427 e_* cousins.
4428 (alloca) [_MSC_VER]: Define to _alloca.
4429
4430 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4431
4432 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4433
a58c13ed
EZ
44342011-11-04 Eli Zaretskii <eliz@gnu.org>
4435
4436 * xdisp.c (note_mouse_highlight): If either of
4437 previous/next-single-property-change returns nil, treat that as
4438 the beginning or the end of the buffer. (Bug#9955)
4439
fe0b6370
JD
44402011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4441
a58c13ed 4442 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4443 label is not null (Bug#9951).
4444 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4445 may be NULL.
4446
89bd5ee1
EZ
44472011-11-04 Eli Zaretskii <eliz@gnu.org>
4448
4449 * window.c (Fwindow_body_size): Mention in the doc string that the
4450 return value is in frame's canonical units. (Bug#9949)
4451
84c3edb9
EZ
44522011-11-03 Eli Zaretskii <eliz@gnu.org>
4453
4e2fb5c7
EZ
4454 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4455
84c3edb9 4456 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4457 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4458 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4459
bc17a887
EZ
44602011-11-01 Eli Zaretskii <eliz@gnu.org>
4461
4462 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4463 Don't stop backward scan on the continuation glyph, even though
4464 its CHARPOS is positive.
6d5eb5b0
SM
4465 (mouse_face_from_buffer_pos, note_mouse_highlight):
4466 Rename cover_string to disp_string.
bc17a887 4467
4ee88440
MR
44682011-11-01 Martin Rudalics <rudalics@gmx.at>
4469
4470 * window.c (temp_output_buffer_show): Don't use
4471 Vtemp_buffer_show_specifiers.
4472 (Vtemp_buffer_show_specifiers): Remove unused variable.
4473
c2ff3c02
EZ
44742011-10-30 Eli Zaretskii <eliz@gnu.org>
4475
4476 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4477 past the beginning of the current glyph matrix.
4478
58179cce 44792011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4480
4481 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4482 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4483 HAVE_GTK3 (Bug#9869).
b77a6a7f 4484
3b574623
JD
4485 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4486 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4487
b77a6a7f
JD
4488 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4489
4490 * xterm.c: Declare x_handle_net_wm_state to return int.
4491 (handle_one_xevent): Check if we are iconified but don't have
4492 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4493 (get_current_wm_state): Return non-zero if not hidden,
4494 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4495 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4496 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4497 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4498
196e41e4
PE
44992011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4500
4501 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4502 so that this new function doesn't get optimized away by a
4503 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4504
021f2e1a
AS
45052011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4506
4507 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4508
8b058d44
EZ
45092011-10-29 Eli Zaretskii <eliz@gnu.org>
4510
4511 Fix the `xbytecode' command.
4512 * .gdbinit (xprintbytestr): New command.
b50a28de 4513 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4514 (xbytecode): Print the byte-code string as well.
4515
4452fb80
EZ
45162011-10-29 Kim Storm <storm@cua.dk>
4517
8b058d44
EZ
4518 * alloc.c (which_symbols): New function.
4519
21b72067
AS
45202011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4521
4522 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4523 line. (Bug#9903)
4524
83ed7b5c
GM
45252011-10-29 Glenn Morris <rgm@gnu.org>
4526
4527 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4528 Not clear what it was for, and it causes various bugs. (Bug#9839)
4529
5a7a728b
EZ
45302011-10-28 Eli Zaretskii <eliz@gnu.org>
4531
4532 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4533 possible random value that matches one of those tested as
4534 condition to clear the mouse face.
4535
d3d0842f
CY
45362011-10-28 Chong Yidong <cyd@gnu.org>
4537
4538 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4539
31b39d13
DN
45402011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4541
4542 * window.c (make_window): Initialize phys_cursor_on_p.
4543
9aba6043
SM
45442011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4545
4546 * lisp.h (struct Lisp_Symbol): Update comments.
4547
c20992f4
JB
45482011-10-28 Juanma Barranquero <lekktu@gmail.com>
4549
4550 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4551
db4f02f2
EZ
45522011-10-28 Eli Zaretskii <eliz@gnu.org>
4553
4554 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4555 <oslsachem@gmail.com> for helping to debug this.
4556
4557 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4558 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4559 (g_b_init_get_glyph_outline_w): New static variables.
4560 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4561 (GetGlyphOutlineW_Proc): New typedefs.
4562 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4563 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4564 New functions.
4565 (w32font_open_internal, compute_metrics):
4566 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4567 instead of calling the "wide" APIs directly.
4568
4569 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4570
4571 * w32.h (syms_of_w32font): Add prototype.
4572
87e68db4
JB
45732011-10-27 Juanma Barranquero <lekktu@gmail.com>
4574
4575 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4576 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4577 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4578 (Fmove_to_window_line): Doc fix.
4579
435c1d67
CY
45802011-10-27 Chong Yidong <cyd@gnu.org>
4581
4582 * process.c (make_process): Set gnutls_state to NULL.
4583
4584 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4585 non-NULL, regardless of GNUTLS_INITSTAGE.
4586 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4587 an error. Set process slots as soon as we allocate them.
4588
4589 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4590
9c6c6f49
CY
45912011-10-27 Chong Yidong <cyd@gnu.org>
4592
9aba6043
SM
4593 * gnutls.c (emacs_gnutls_deinit): New function.
4594 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4595 (Fgnutls_deinit, Fgnutls_boot): Use it.
4596
4597 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4598 (deactivate_process): Call emacs_gnutls_deinit.
4599
657d08d3
JB
46002011-10-27 Juanma Barranquero <lekktu@gmail.com>
4601
4602 * image.c (x_create_x_image_and_pixmap):
4603 * w32.c (sys_rename, w32_delayed_load):
4604 * w32font.c (fill_in_logfont):
4605 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4606
5430d399
JB
46072011-10-26 Juanma Barranquero <lekktu@gmail.com>
4608
4609 * w32fns.c (w32_default_color_map): New function,
4610 extracted from Fw32_default_color_map.
a7ef684b 4611 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4612
fe0055fa
PE
46132011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4614
4615 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4616
e6346438
SM
46172011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4618
4619 * keyboard.c (test_undefined): New function (bug#9751).
4620 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4621
e112cc37
ET
46222011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4623
4624 * sysdep.c (init_sys_modes): Fix the check for the controlling
4625 terminal (Bug#6649).
4626
7b5d6677
EZ
46272011-10-20 Eli Zaretskii <eliz@gnu.org>
4628
4629 * dispextern.h (struct bidi_it): New member next_en_type.
4630
4631 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4632 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4633 current character, check also for next_en_type being WEAK_EN.
4634 (bidi_resolve_weak): Don't enter the expensive loop if the current
4635 position is before next_en_pos. Record the bidi type of the first
4636 non-ET, non-BN character we find, in addition to its position.
4637 (bidi_level_of_next_char): Invalidate next_en_type when
4638 next_en_pos is over-stepped.
4639
7da0b018
PE
46402011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4641
4642 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4643 * editfns.c: Rewrite current-time-zone so that it invokes
4644 the equivalent of (format-time-string "%Z") to get the time zone name.
4645 This fixes a bug when the time zone name contains characters that
4646 need converting from the system time locale to Emacs internal format.
4647 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4648 that patch fixed format-time-string to do the conversion, but
4649 I forgot to fix current-time-zone.
4650 (format_time_string): New function, containing most of
4651 what Fformat_time_string used to contain.
4652 (Fformat_time_string): Rewrite in terms of format_time_string.
4653 This doesn't change this function's behavior.
4654 (current-time-zone): Rewrite to use format_time_string.
4655 This fixes the bug reported by Michael Schierl in
4656 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4657 Jason Rumney's 2007-06-07 change worked around this bug, but
4658 didn't fix it.
4659 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4660
8547b010
EZ
46612011-10-19 Eli Zaretskii <eliz@gnu.org>
4662
4663 * xdisp.c (start_display): If the character at POS is displayed
4664 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4665 (try_window_reusing_current_matrix): If a line ends in a display
4666 vector or the next line starts in a display vector, continue
4667 redrawing the window even though the character position of
4668 start_row was reached.
8547b010
EZ
4669 (Bug#9771, part 2)
4670
4e948d15
CY
46712011-10-18 Chong Yidong <cyd@gnu.org>
4672
4673 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4674 with nobreak-char-display too.
4675
4787455f
EZ
46762011-10-18 Eli Zaretskii <eliz@gnu.org>
4677
4678 Fix part 3 of bug#9771.
4679 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4680 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4681 non-neutral characters if the current character is a paragraph
4682 separator (a.k.a. Newline). This avoids running the same
4683 expensive loop twice, once when we consume the preceding newline
4684 and the other time when the line actually needs to be displayed.
4685 Avoid the loop when we see neutrals on the base embedding level
4686 following a character whose directionality is the same as the
4687 paragraph's. This avoids running the expensive loop when a line
4688 ends in a long sequence of neutrals, like control characters.
4689 Add assertion against STRONG_AL type. Slightly rearrange code
4690 that determines the type of a neutral given the first non-neutral
4691 that follows it.
4692 (bidi_level_of_next_char): Set next_en_pos to zero when
4693 invalidating its info.
4694
2c91f553
EZ
46952011-10-17 Eli Zaretskii <eliz@gnu.org>
4696
4697 * xdisp.c (push_display_prop): Determine whether to record string
4698 or buffer position by IT->string, not by IT->method. Allow
4699 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4700 (move_it_vertically_backward): Don't look for character position
4701 immediately after the newline when in a continuation line.
4702 (Bug#9771, part 1)
2c91f553 4703
c7b08b0d
MR
47042011-10-15 Martin Rudalics <rudalics@gmx.at>
4705
4706 * window.c (coordinates_in_window): Rewrite and delabelize
4707 vertical border check. (Bug#5357) (Bug#9618)
4708
6b02f655
SM
47092011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4710
4711 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4712 errors in XSetWindowBorder (bug#9310).
4713
81d40c92
DA
47142011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4715
4716 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4717 avoid crash when xmalloc overrun checking is enabled.
4718
d4172c3b
EZ
47192011-10-13 Eli Zaretskii <eliz@gnu.org>
4720
4721 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4722 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4723 cursor motion with <left> and <right> arrow keys.
4724
4725 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4726 some callers set that themselves.
4727
b00eea75
EZ
47282011-10-12 Eli Zaretskii <eliz@gnu.org>
4729
4730 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4731 display string and the previous row comes from the same string and
4732 is empty. (Bug#9739) (Bug#9738)
4733
8fe012c4
SM
47342011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4735
4736 * doc.c (get_doc_string): Encode file name (bug#9735).
4737
0074aef2
EZ
47382011-10-12 Eli Zaretskii <eliz@gnu.org>
4739
79beb178
EZ
4740 * bidi.c (bidi_level_of_next_char):
4741 * xdisp.c (get_visually_first_element): Remove old incorrect
4742 comments regarding the Unicode Line Separator character.
4743
0074aef2
EZ
4744 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4745
6e4b3fbe
DA
47462011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4747
4748 * alloc.c (Fgc_status): Do not access beyond zombies array
4749 boundary if nzombies > MAX_ZOMBIES.
4750 * alloc.c (dump_zombies): Add missing format specifier.
4751
0324f3af
PE
47522011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4753
b5525cac
PE
4754 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4755 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4756
0324f3af
PE
4757 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4758 Some packages use them to denote characters with modifiers.
4759
e9b5f888
AS
47602011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4761
4762 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4763 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4764 matching a pp-number. Rename parameter var to var1.
4765
127827c0
SM
47662011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4767
4768 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4769
c8fd3bd0
GM
47702011-10-08 Glenn Morris <rgm@gnu.org>
4771
4772 * callint.c (Fcall_interactively): Give a more explicit error for the
4773 'c' case with a non-character input. (Bug#8479)
4774
352ec8ff
EZ
47752011-10-08 Eli Zaretskii <eliz@gnu.org>
4776
03669ccb
EZ
4777 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4778 lines.
7061c986
EZ
4779 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4780 lines that are hscrolled on the left.
03669ccb 4781
352ec8ff
EZ
4782 * dispnew.c (buffer_posn_from_coords): Account for a possible
4783 presence of header-line. (Bug#4426)
4784
a66cfb1c
SM
47852011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4786
6b02f655
SM
4787 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4788 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4789
7c5ee88e
PE
47902011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4791
4792 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4793 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4794 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4795 this makes Emacs dump core during garbage collection on rare
4796 occasions. sizeof is obviously inferior to offsetof here, so
4797 stick with offsetof.
4798 (GC_POINTER_ALIGNMENT): New macro.
4799 (mark_memory): Omit 3rd (offset) arg; caller changed.
4800 Don't assume EMACS_INT alignment is the same as pointer alignment.
4801
df1bbe5b
SM
48022011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4803
4804 * keyboard.c (read_key_sequence_remapped): New var.
4805 (read_key_sequence): Compute remapping in the right buffer.
4806 (command_loop_1): Use read_key_sequence's remapping directly.
4807
51553db6
SM
48082011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4809
32c1fffd
SM
4810 * dired.c (file_name_completion): Don't expand file name.
4811 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4812 before checking file name handler.
4813
51553db6
SM
4814 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4815 they've been requested explicitly (bug#9591).
4816
b6bd1599 48172011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4818
4819 * keymap.c (Fsingle_key_description): Use make_specified_string
4820 instead of build_string to build string from push_key_description.
4821 (Bug#5193)
4822
f701dc2a
PE
48232011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4824
4222c55d
PE
4825 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4826 This fixes a Y2038 bug on 64-bit hosts.
4827 * buffer.c (reset_buffer):
4828 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4829 (Fclear_buffer_auto_save_failure):
4830 Use 0, not -1, to represent an unset failure time, since time_t
4831 might not be signed.
4832
f701dc2a
PE
4833 Remove dependency on glibc malloc internals.
4834 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4835 Move back here from lisp.h, but with their new implementations.
4836 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4837 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4838 * charset.c (charset_table_init): New static var.
4839 (syms_of_charset): Use it instead of xmalloc. This removes a
4840 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4841 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4842 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4843 Move back to alloc.c.
4844 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4845 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4846
9ceebf39
JD
48472011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4848
4849 * nsterm.m (windowDidResize): Call x_set_window_size only when
4850 ns_in_resize is true. Otherwise set pixelwidth/height and
4851 call change_frame_size (Bug#9628).
4852
cb993c58
PE
48532011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4854
3930c88b
PE
4855 Port --enable-checking=all to Fedora 14 x86-64.
4856 * charset.c (syms_of_charset): Also account for glibc malloc's
4857 internal overhead when calculating the initial malloc maximum.
4858
cb993c58
PE
4859 Port --enable-checking=all to Fedora 14 x86.
4860 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4861 Move to lisp.h.
4862 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4863 (overrun_check_realloc, overrun_check_free):
4864 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4865 That way, xmalloc returns a properly-aligned pointer even if
4866 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4867 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4868 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4869 into account when calculating the initial malloc maximum.
4870 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4871 Move here from alloc.c, so that charset.c can use it too.
4872 Properly align; the old code wasn't right for common 32-bit hosts
4873 when configured with --enable-checking=all.
4874 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4875 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4876
31bed486
EZ
48772011-09-29 Eli Zaretskii <eliz@gnu.org>
4878
04c70788 4879 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4880 use EDOM.
4881
fbcaa2f3
EZ
48822011-09-28 Eli Zaretskii <eliz@gnu.org>
4883
4884 * xdisp.c (compute_display_string_end): If there's no display
4885 string at CHARPOS, return -1.
4886
4887 * bidi.c (bidi_fetch_char): When compute_display_string_end
4888 returns a negative value, treat the character as a normal
4889 character not covered by a display string. (Bug#9624)
4890
a239d4e9
JB
48912011-09-28 Juanma Barranquero <lekktu@gmail.com>
4892
4893 * lread.c (Fread_from_string): Fix typo in docstring.
4894
88652fd5
EZ
48952011-09-27 Eli Zaretskii <eliz@gnu.org>
4896
4897 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4898 newline, reseat the iterator instead of bidi-iterating there one
4899 character at a time. (Bug#9610)
32c1fffd
SM
4900 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4901 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4902
ed497dd4
AS
49032011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4904
4905 * lread.c (readevalloop): Use correct code for NBSP.
4906 (read1): Likewise. (Bug#9608)
4907
b2bf61aa
MA
49082011-09-25 Michael Albinus <michael.albinus@gmx.de>
4909
4910 * dbusbind.c (Fdbus_register_signal): When service is not
4911 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4912
32bbb17c
GM
49132011-09-25 Glenn Morris <rgm@gnu.org>
4914
4915 * buffer.c (truncate-lines): Doc fix.
4916
94e0933e
CY
49172011-09-24 Chong Yidong <cyd@stupidchicken.com>
4918
4919 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4920 (Fset_window_next_buffers): Doc fix.
4921
cddde921
GM
49222011-09-24 Glenn Morris <rgm@gnu.org>
4923
4924 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4925
1260aef1
PE
49262011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4927
25b4bfa0
PE
4928 Fix minor problems found by static checking.
4929 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4930 * indent.c (Fvertical_motion): Fix == vs = typo.
4931
e3cbd34b
EZ
49322011-09-24 Eli Zaretskii <eliz@gnu.org>
4933
a66cfb1c
SM
4934 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4935 Default value is now t. Doc fix.
6bf7006f 4936
e3cbd34b 4937 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4938 logic when moving up, not only when moving down. Fix the
e3cbd34b 4939 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4940 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4941
4942 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4943 CHARPOS is covered by a display string which includes newlines.
4944 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4945 is covered by a display string with embedded newlines.
4946
a3de0cbd
MA
49472011-09-24 Michael Albinus <michael.albinus@gmx.de>
4948
4949 * dbusbind.c (Fdbus_register_signal): Add match rule to
4950 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4951 (Fdbus_register_method, Vdbus_registered_objects_table):
4952 Fix docstring.
a3de0cbd 4953
b260039d
JM
49542011-09-24 Jim Meyering <meyering@redhat.com>
4955
32c1fffd 4956 do not ignore write error for any output size
b260039d
JM
4957 The previous change was incomplete.
4958 While it makes emacs --batch detect the vast majority of stdout
4959 write failures, errors were still ignored whenever the output size is
4960 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4961 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4962 && echo FAIL: ignored write error
4963 FAIL: ignored write error
4964 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4965 && echo FAIL: ignored write error
4966 FAIL: ignored write error
4967 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4968
8eca8a7c
AS
49692011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4970
4971 * emacs.c (Fkill_emacs): In noninteractive mode exit
4972 non-successfully if a write error occurred on stdout. (Bug#9574)
4973
3341db62
EZ
49742011-09-21 Eli Zaretskii <eliz@gnu.org>
4975
4976 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4977 the xassert test.
4978
4979 * dispextern.h (struct it): Update the comment documenting what
4980 can it->OBJECT be.
4981
8c203dbf
EZ
49822011-09-20 Eli Zaretskii <eliz@gnu.org>
4983
4984 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4985 a display string, extend search for cursor position to end of row.
4986 (find_row_edges): If the row ends in a newline from a display
4987 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4988 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4989 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4990 non-empty line. Fixes confusing cursor motion with arrow keys at
4991 the beginning of a line that starts with whitespace.
8c203dbf 4992
a4824228
LMI
49932011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4994
4995 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4996 (bug#9493).
4997
33ed493b
CY
49982011-09-18 Chong Yidong <cyd@stupidchicken.com>
4999
5000 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5001 boolean (Bug#9154).
5002
56cd55c8
EZ
50032011-09-18 Eli Zaretskii <eliz@gnu.org>
5004
5005 * xdisp.c (display_line): Record maximum and minimum buffer
5006 positions even if no glyphs were produced (e.g., by a zero-width
5007 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5008 buffer positions that will be removed from the glyph row because
5009 they don't fit.
c02dcedf
EZ
5010 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5011 column is beyond frame width: don't subtract 1 "pixel" when
5012 computing width of the stretch.
3e62b7e0
EZ
5013 (reseat_at_next_visible_line_start): Undo the change made on
5014 2011-09-17 that saved paragraph information and restored it after
5015 the call to `reseat'. (Bug#9545)
56cd55c8 5016
5ed99d36 50172011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5018
5019 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5020 and turn window cursor on if cleared (Bug#9415).
5021
5ed99d36 50222011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5023
5024 * search.c (boyer_moore): Take unibyte characters from pattern
5025 literally. (Bug#9458)
5026
9bade7b2
EZ
50272011-09-18 Eli Zaretskii <eliz@gnu.org>
5028
5029 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5030
e5e9d610
PE
50312011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5032
87e4427a
PE
5033 Fix minor problem found by static checking.
5034 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5035 initialized, to pacify gcc -Wuninitialized.
5036
e5e9d610
PE
5037 * fileio.c: Report proper errno when syscall falls.
5038 (Finsert_file_contents): Save and restore errno,
5039 so that report_file_error outputs the correct diagnostic.
5040 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5041
a1674f0b
EZ
50422011-09-18 Eli Zaretskii <eliz@gnu.org>
5043
5044 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5045
fbfb6dd4
EZ
50462011-09-17 Eli Zaretskii <eliz@gnu.org>
5047
5048 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5049 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5050
bb187662
EZ
50512011-09-17 Eli Zaretskii <eliz@gnu.org>
5052
1137e8b8 5053 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5054 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5055
5056 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5057 (bidi_find_paragraph_start): Search back for paragraph beginning
5058 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5059 (bidi_move_to_visually_next): Only trigger paragraph-related
5060 computations when the last character is a newline or at EOB, not
5061 just any NEUTRAL_B. (Bug#9470)
5062
bb187662
EZ
5063 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5064 truncated lines if point is covered by a display string. (Bug#9524)
5065
2e621251
PE
50662011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5067
5068 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5069 (cons_to_x_long): New function.
5070 (lisp_data_to_selection_data): Use it. Correct the test for
5071 short-versus-long data; it was negated. Break out of vector
5072 loop, for efficiency, when a long datum is discovered.
5073
91a15bc6
SM
50742011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5075
5076 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5077
b41c3a35
EZ
50782011-09-16 Eli Zaretskii <eliz@gnu.org>
5079
5080 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5081 GCC PR/17406) by declaring this function with external scope.
5082
7812ba2d
PE
50832011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5084
5085 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5086 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5087
cf7edc2a
AS
50882011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5089
5090 * editfns.c (Fformat): Correctly handle text properties on "%%".
5091
bd01620e
EZ
50922011-09-15 Eli Zaretskii <eliz@gnu.org>
5093
5094 * xterm.c (x_draw_composite_glyph_string_foreground):
5095 * w32term.c (x_draw_composite_glyph_string_foreground):
5096 * term.c (encode_terminal_code):
5097 * composite.c (composition_update_it, get_composition_id):
5098 * xdisp.c (get_next_display_element)
5099 (fill_composite_glyph_string): Add comments about special meaning
5100 of TAB characters in a composition.
5101
a02719a3
PE
51022011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5103
5104 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5105 This occurs when processing a multibyte format.
5106 Problem reported by Wolfgang Jenker.
a02719a3 5107
72589a3c
JB
51082011-09-15 Johan Bockgård <bojohan@gnu.org>
5109
5110 * xdisp.c (try_cursor_movement): Only check for exact match if
5111 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5112
1c14176c
PE
51132011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5114
5115 Remove unused external symbols.
5116 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5117 * xdisp.c (calc_pixel_width_or_height): Now static.
5118 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5119 * indent.c (check_display_width):
5120 * w32term.c: Fix comment to match code.
5121 * xterm.c, xterm.h (x_catching_errors): Remove.
5122
d2eea5b5
PE
51232011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5124
5125 * xselect.c: Use signed conversions more consistently (Bug#9498).
5126 (selection_data_to_lisp_data): Assume incoming selection data are
5127 signed integers, not unsigned. This is to be consistent with
5128 outgoing selection data, which was modified to use signed integers
5129 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5130 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5131 expects long, not unsigned long.
5132
46888499
EZ
51332011-09-14 Eli Zaretskii <eliz@gnu.org>
5134
5135 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5136 computation of loop end. Reported by Johan Bockgård
5137 <bojohan@gnu.org>.
5138
ef8ef9fb
CY
51392011-09-13 Chong Yidong <cyd@stupidchicken.com>
5140
5141 * frame.c (Fother_visible_frames_p): Function deleted.
5142
fa819fed
EZ
51432011-09-12 Eli Zaretskii <eliz@gnu.org>
5144
5145 * indent.c (compute_motion): Process display vector front to back
5146 rather than the other way around. (Bug#2496)
5147
2ba8e008
SM
51482011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5149
5150 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5151
20f53c69
CY
51522011-09-11 Chong Yidong <cyd@stupidchicken.com>
5153
5154 * minibuf.c (Fread_from_minibuffer): Doc fix.
5155
d562d7a4
EZ
51562011-09-11 Eli Zaretskii <eliz@gnu.org>
5157
5158 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5159 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5160
1c4d7f3d
LMI
51612011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5162
5163 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5164 value for non-existent files.
5165
b885bf36
EZ
51662011-09-11 Eli Zaretskii <eliz@gnu.org>
5167
5168 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5169 set its "size" to -1. This will set the modtime_size field of
5170 the corresponding buffer to -1, which is what
5171 verify-visited-file-modtime expects for files that do not exist.
5172 (Bug#9139)
5173
6612f0bf
PE
51742011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5175
5176 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5177 here ...
5178 * lisp.h: ... from here. push_key_description is no longer
5179 defined in keyboard.c, so its declaration should not be in
5180 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5181 logically belongs with push_key_description.
5182
dfb3f755
PE
51832011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5184
5185 * buffer.h: Include <sys/types.h> instead of <time.h>.
5186 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5187 Problem reported by Herbert J. Skuhra.
5188
3134906c
LMI
51892011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5190
5191 * xml.c (parse_region): Make the parsing work for
5192 non-comment-starting XML files again (bug#9144).
5193
8d903f4e
AS
51942011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5195
5196 * image.c (gif_load): Fix calculation of bottom and right corner.
5197 (Bug#9468)
5198
80ad64f4
EZ
51992011-09-10 Eli Zaretskii <eliz@gnu.org>
5200
5201 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5202 redisplay in small windows.
5203
208a048d
EZ
52042011-09-09 Eli Zaretskii <eliz@gnu.org>
5205
5206 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5207
9b1c252e
MR
52082011-09-08 Martin Rudalics <rudalics@gmx.at>
5209
5210 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5211 Operate on live windows only.
5212
2949f33b
JB
52132011-09-08 Juanma Barranquero <lekktu@gmail.com>
5214
5215 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5216
e08dcafd
EZ
52172011-09-07 Eli Zaretskii <eliz@gnu.org>
5218
5219 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5220 only under bidi iteration.
5221
115b96bd
JD
52222011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5223
5224 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5225
c8199d0f
PE
52262011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5227
5228 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5229 Without this fix, the command to link temacs failed due to an
5230 undefined symbol __builtin_isnan. This is because
5231 /usr/include/iso/math_c99.h #defines isnan(x) to
5232 __builtin_isnan(x), but the bundled gcc, which identifies itself
5233 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5234 a __builtin_isnan.
5235 * floatfns.c (isnan): #undef, and then #define to a clone of
5236 what's in data.c.
5237 (Fisnan): Always define, since it's always available now.
5238 (syms_of_floatfns): Always define isnan at the Lisp level.
5239
e39b275c 52402011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5241
5242 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5243
b2db44d9 52442011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5245
f4af5137 5246 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5247 The previous code assumed that file offsets (off_t values) fit in
5248 EMACS_INT variables, which is not true on typical 32-bit hosts.
5249 The code messed up by falsely reporting buffer overflow in cases
5250 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5251 when "big" contains more than 2**29 bytes, even though this
5252 inserts just one byte and does not overflow the buffer.
5253 (Finsert_file_contents): Store file offsets as off_t
5254 values, not as EMACS_INT values. Check for overflow when
5255 converting between EMACS_INT and off_t. When checking for
5256 buffer overflow or for overlap, take the offsets into account.
5257 Don't use EMACS_INT for small values where int suffices.
5258 When checking for overlap, fix a typo: ZV was used where
5259 ZV_BYTE was intended.
5260 (Fwrite_region): Don't assume off_t fits into 'long'.
5261 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5262
ecfc0a49
MA
52632011-09-05 Michael Albinus <michael.albinus@gmx.de>
5264
5265 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5266
6511acf2 52672011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5268
0999621a 5269 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5270
5271 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5272 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5273 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5274 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5275 (modify_event_symbol): Do not assume that the length of
5276 name_alist_or_stem is safe to alloca and fits in int.
5277 (Fexecute_extended_command): Likewise for function name and binding.
5278 (Frecursion_depth): Wrap around reliably on integer overflow.
5279 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5280 since some callers pass EMACS_INT values.
5281 (Fsingle_key_description): Don't crash if symbol name contains more
5282 than MAX_ALLOCA bytes.
5283 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5284 (get_minibuffer): Arg is now EMACS_INT, not int.
5285 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5286 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5287 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5288
2be7d702
PE
5289 * dbusbind.c (signature_cat): New function.
5290 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5291 Do not overrun buffer; instead, report string overflow.
5292
9d1df220
PE
5293 * dispnew.c (add_window_display_history): Don't overrun buffer.
5294 Truncate instead; this is OK since it's just a log.
5295
33ef5c64
PE
5296 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5297 even if the time zone offset is outlandishly large.
5298 Don't mishandle offset == INT_MIN.
5299
66c6fdd5
PE
5300 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5301 when creating daemon; the previous buffer-overflow check was incorrect.
5302
d749b01b
PE
5303 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5304 which has the guts of the old verror function.
5305
b5cd1905
PE
5306 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5307 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5308
6e1a67fb
PE
5309 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5310 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5311 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5312 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5313 length of string rather than counting it via multiple sprintfs;
5314 that's simpler and more reliable.
c21721cc
PE
5315 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5316 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5317 sprintf, in case result does not fit in int.
5318
c57b67fc
PE
5319 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5320 (fontset_from_font): Print it.
5321
8a401434
PE
5322 * frame.c (tty_frame_count): Now printmax_t, not int.
5323 (make_terminal_frame, set_term_frame_name): Print it.
5324 (x_report_frame_params): In X, window IDs are unsigned long,
5325 not signed long, so print them as unsigned.
5326 (validate_x_resource_name): Check for implausibly long names,
5327 and don't assume name length fits in 'int'.
5328 (x_get_resource_string): Don't blindly alloca invocation name;
5329 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5330 not fit in int.
5331
6e1a67fb
PE
5332 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5333 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5334 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5335
0df02bf3
PE
5336 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5337 Use esprintf, not sprintf, in case result does not fit in int.
5338
48e30793
PE
5339 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5340 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5341 it as a large positive number.
5342 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5343 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5344
a66ff6d8
PE
5345 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5346 in case result does not fit in int.
5347
aca216ff
PE
5348 * print.c (float_to_string): Detect width overflow more reliably.
5349 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5350 buffer overrun. Don't assume list length fits in 'int'. Treat
5351 print length of 0 as 0, not as infinity; to be consistent with other
5352 uses of print length in this function. Don't overflow print length
5353 index. Don't assume hash table size fits in 'long', or that
5354 vectorlike size fits in 'unsigned long'.
5355
31c286f7
PE
5356 * process.c (make_process): Use printmax_t, not int, to format
5357 process-name gensyms.
5358
55e5faa1
PE
5359 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5360
80f2e268
PE
5361 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5362 to avoid potential buffer overrun.
5363
670741ab
PE
5364 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5365 if X resource line is longer than 512 bytes.
5366
b7163a50
PE
5367 * xfns.c (x_window): Make sprintf buffer a bit bigger
5368 to avoid potential buffer overrun.
5369
ae58ff1f
PE
5370 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5371
c43c8a6a
PE
5372 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5373
3f8236f4
PE
53742011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5375
53e9fe90 5376 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5377 Without these, Emacs silently mishandles large integers sometimes.
5378 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5379 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5380
6511acf2
PE
5381 * xdisp.c (try_window_id): Check Emacs fixnum range before
5382 converting to 'int'.
806add1d 5383
6511acf2 5384 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5385 Check that an Emacs fixnum is in range before assigning it to 'int'.
5386 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5387 values converted from Emacs fixnums.
5388 (Frecenter): Don't wrap around a line count if it is out of 'int'
5389 range; instead, treat it as an extreme value.
5390 (Fset_window_configuration, compare_window_configurations):
5391 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5392
6511acf2
PE
5393 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5394 that can exceed INT_MAX. Check that EMACS_INT value is in range
5395 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5396 (match_limit): Don't assume that a fixnum can fit in 'int'.
5397
6511acf2 5398 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5399 exceed INT_MAX.
5400
6511acf2 5401 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5402 (Fvertical_motion): Don't wrap around LINES values that don't fit
5403 in 'int'. Instead, treat them as extreme values. This is good
5404 enough for windows, which can't have more than INT_MAX lines anyway.
5405
fcb901a7
LMI
54062011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5407
0f2f6b6d
LMI
5408 * Require libxml/parser.h to avoid compilation warning.
5409
fcb901a7
LMI
5410 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5411
5412 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5413 since this reportedly can destroy thread storage.
5414
6e20a0d4
CY
54152011-08-30 Chong Yidong <cyd@stupidchicken.com>
5416
5417 * syntax.c (find_defun_start): Update all cache variables if
5418 exiting early (Bug#9401).
5419
148ae00e
EZ
54202011-08-30 Eli Zaretskii <eliz@gnu.org>
5421
f6cfbd8f
EZ
5422 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5423
148ae00e
EZ
5424 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5425 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5426 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5427
5428 * term.c (tty_append_glyph): New function.
5429 (produce_stretch_glyph): Static function and its prototype deleted.
5430
a66cfb1c
SM
5431 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5432 Add prototypes.
148ae00e 5433
c4a07a4c
PE
54342011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5435
5436 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5437 when checking :margin (Bug#9390).
5438 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5439 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5440 so that the name doesn't mislead. All uses changed.
5441
6bc8cd65
JB
54422011-08-28 Johan Bockgård <bojohan@gnu.org>
5443
5444 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5445 set_tty_hooks.
5446
dca4927e
EZ
54472011-08-27 Eli Zaretskii <eliz@gnu.org>
5448
5449 * xdisp.c (move_it_to): Don't bail out early when reaching
5450 position beyond to_charpos, if we are scanning backwards.
5451 (move_it_vertically_backward): When DY == 0, make sure we get to
5452 the first character in the line after the newline.
5453
f2cad773
PE
54542011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5455
5456 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5457 (ccl_driver): Do not generate an out-of-range pointer.
5458 (Fccl_execute_on_string): Remove unnecessary check for
5459 integer overflow, noted by Stefan Monnier in
5460 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5461 Remove a FIXME that didn't need fixing.
5462 Simplify the newly-introduced buffer reallocation code.
5463
0cae2cdb
JB
54642011-08-27 Juanma Barranquero <lekktu@gmail.com>
5465
5466 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5467
5fc295a4 54682011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5469
70c60eb2 5470 Integer and memory overflow issues (Bug#9196).
726e0ab1 5471
d31850da
PE
5472 * doc.c (get_doc_string): Rework so that
5473 get_doc_string_buffer_size is the actual buffer size, rather than
5474 being 1 less than the actual buffer size; this makes xpalloc more
5475 convenient.
5476
a69fbedb
PE
5477 * image.c (x_allocate_bitmap_record, cache_image):
5478 * xselect.c (Fx_register_dnd_atom):
5479 Simplify previous changes by using xpalloc.
5480
fe5c5d37
PE
5481 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5482 since either will do and ptrdiff_t is convenient with xpalloc.
5483
0065d054
PE
5484 * charset.c (charset_table_size)
5485 (struct charset_sort_data.priority): Now ptrdiff_t.
5486 (charset_compare): Don't overflow if priorities differ greatly.
5487 (Fsort_charsets): Don't assume list length fits in int.
5488 Check for size-calculation overflow when allocating sort data.
5489 (syms_of_charset): Allocate an initial charset table that is
5490 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5491
5492 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5493
5494 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5495 The actual value is always <= INT_MAX, and leaving it unsigned made
5496 overflow checking harder.
5497
5498 * dispextern.h (struct glyph_matrix.rows_allocated)
5499 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5500 with xpalloc. The values are still always <= INT_MAX.
5501
5502 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5503
5504 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5505 (SAFE_NALLOCA): New macro.
5506
5507 * region-cache.c (struct boundary.pos, find_cache_boundary)
5508 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5509 (set_cache_region, invalidate_region_cache)
5510 (revalidate_region_cache, know_region_cache, region_cache_forward)
5511 (region_cache_backward, pp_cache):
5512 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5513 so that ptrdiff_t * can be passed to xpalloc.
5514 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5515 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5516 (pp_cache): Don't assume cache_len fits in int.
5517 * region-cache.h: Adjust extern decls to match.
5518
5519 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5520 EMACS_INT, since either will do, for xpalloc.
5521
5522 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5523 (xnmalloc, xnrealloc, xpalloc): New functions.
5524
726e0ab1
PE
5525 * bidi.c (bidi_shelve_header_size): New constant.
5526 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5527 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5528
51f30bc5 5529 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5530 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5531 (overlay_strings):
5532 Don't update size of array until after memory allocation succeeds,
5533 because xmalloc/xrealloc may not return.
0065d054
PE
5534 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5535 now that we have proper integer overflow checking.
5536 (record_overlay_string, overlay_strings): Catch overflows when
5537 calculating size of overlay_str_buf.
726e0ab1 5538
0065d054
PE
5539 * callproc.c (Fcall_process): Check for size overflow when
5540 calculating size of args2.
5541 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5542 Normally we prefer signed values, but sticking with ptrdiff_t would
5543 require adding more-complicated checks.
726e0ab1
PE
5544
5545 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5546 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5547 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5548 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5549
5550 * character.c (Fstring): Check for size-calculation overflow.
5551
5552 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5553 unnecessary integer overflow. Check for size overflow.
5554 (encode_coding_object): Don't update size until xmalloc succeeds.
5555
5556 * composite.c (get_composition_id): Check for overflow in glyph
5557 length calculations.
5558
5559 Integer and memory overflow fixes for display code.
5560 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5561 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5562 (scrolling_window): Check for overflow in size calculations.
5563 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5564 Don't assume glyph table len fits in int.
5565 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5566 (row_table_size): Now ptrdiff_t, not int.
5567 (scrolling_window): Avoid overflow in size calculations.
5568 Don't update size until allocation succeeds.
5569 * fns.c (concat): Check for overflow in size calculations.
5570 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5571 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5572 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5573
5574 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5575 (get_doc_string): Check for size calculation overflow.
5576 Don't update size until allocation succeeds.
5577 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5578 EMACS_INT, where ptrdiff_t will do.
5579 (Fsubstitute_command_keys): Check for string overflow.
5580
5581 * editfns.c (set_time_zone_rule): Don't assume environment length
5582 fits in int.
5583 (message_length): Now ptrdiff_t, not int.
5584 (Fmessage_box): Don't update size until allocation succeeds.
5585 Don't assume message length fits in int.
5586 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5587
0065d054
PE
5588 * emacs.c (main): Do not reallocate argv, since there is a null at
5589 the end that can be overwritten, and this way there's no need to
5590 worry about size-calculation overflow.
5591 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5592
5593 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5594 alloc succeeds.
5595 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5596
5597 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5598 (x_set_scroll_bar_width, x_figure_window_size):
5599 Check for integer overflow.
5600 (x_set_alpha): Do not assume XINT fits in int.
5601
5602 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5603 This is for the members text_lines, text_cols, total_lines, total_cols,
5604 where the system imposes an 'int' limit.
5605
5606 * fringe.c (Fdefine_fringe_bitmap):
5607 Don't update size until alloc works.
5608
5609 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5610 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5611
5612 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5613 Check for size-calculation overflow.
5614 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5615 do, as we prefer signed integers.
5616 (id_to_widget.max_size, id_to_widget.used)
5617 (xg_store_widget_in_map, xg_remove_widget_from_map)
5618 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5619 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5620 Use and return ptrdiff_t, not int.
5621 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5622 * gtkutil.h: Change prototypes to match the above.
5623
5624 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5625 are duplicate now that they've been promoted to lisp.h.
5626 (x_allocate_bitmap_record, x_alloc_image_color)
5627 (make_image_cache, cache_image, xpm_load):
5628 Don't update size until alloc is done.
5629 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5630 (x_detect_edges):
3256efce 5631 Check for size calculation overflow.
726e0ab1
PE
5632 (ct_colors_allocated_max): New constant.
5633 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5634 overflow.
3256efce 5635
726e0ab1
PE
5636 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5637 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5638 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5639 Use ptrdiff_t, not int, to count maps.
5640 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5641 calculations. Don't update size until allocation succeeds.
5642 Redo calculations to avoid overflow.
726e0ab1
PE
5643 * keyboard.h: Change prototypes to match the above.
5644
5645 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5646 to count maps.
5647 (current_minor_maps): Check for size calculation overflow.
5648 * keymap.h: Change prototypes to match the above.
5649
5650 * lread.c (read1, init_obarray): Don't update size until alloc done.
5651
5652 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5653 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5654
726e0ab1
PE
5655 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5656 Now ptrdiff_t, not int.
5657 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5658 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5659
5660 * process.c (Fnetwork_interface_list): Check for overflow
5661 in size calculation.
5662
5663 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5664
5665 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5666 overflow. Don't bother calling xmalloc when xrealloc will do.
5667
5668 * search.c (Freplace_match): Check for size calculation overflow.
5669 (Fset_match_data): Don't assume list lengths fit in 'int'.
5670
5671 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5672 for command line length. Do not attempt to address one before the
5673 beginning of an array, as that's not portable.
5674
5675 * term.c (max_frame_lines): Remove; unused.
5676 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5677 not int.
5678 (encode_terminal_code, calculate_costs): Check for size
5679 calculation overflow.
5680 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5681 table lengths and related sizes. Don't update size until alloc
5682 done. Redo calculations to avoid overflow.
5683 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5684
5685 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5686 subtracting pointers.
5687 (gobble_line): Check for overflow more carefully. Don't update size
5688 until alloc done.
5689
5690 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5691 Don't update size until alloc done.
5692 Redo size calculations to avoid overflow.
5693 Check for size calculation overflow.
0065d054 5694 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5695
5696 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5697 Use ptrdiff_t, not int, for sizes.
5698 (store_mode_line_noprop_char): Don't update size until alloc done.
5699
0065d054
PE
5700 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5701 Use ptrdiff_t, not int, for sizes.
5702 (Finternal_make_lisp_face, cache_face):
5703 Check for size calculation overflow.
5704 (cache_face): Treat size calculation overflows as if they were
5705 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5706
5707 * xfns.c (x_encode_text, x_set_name_internal)
5708 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5709 sizes, since they can exceed INT_MAX in size. Check for size
5710 calculation overflow.
5711
0065d054
PE
5712 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5713 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5714 Don't update size until alloc done.
5715
0065d054 5716 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5717 as sprintf is limited to int lengths.
1d526e2f 5718
252c5ee1
PE
5719 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5720 (X_LONG_MIN): New macros.
864d7ce7
PE
5721 Use them to make the following changes clearer.
5722 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5723 This change doesn't affect the value now, but it may help remind
5724 future maintainers not to raise the value too much later.
5725 (SELECTION_QUANTUM): Remove, replacing with ...
5726 (selection_quantum): ... new function, which avoids overflow.
5727 All uses changed.
5728 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5729 assumption that selection length fits in 'int'.
5730 (x_reply_selection_request, x_handle_selection_request)
5731 (x_get_window_property, receive_incremental_selection)
5732 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5733 (lisp_data_to_selection_data, clean_local_selection_data):
5734 Use ptrdiff_t, not int, to record length of selection.
5735 (x_reply_selection_request, x_get_window_property)
5736 (receive_incremental_selection, x_property_data_to_lisp):
5737 Redo calculations to avoid overflow.
5738 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5739 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5740 something.
5741 (x_get_window_property, receive_incremental_selection)
5742 (lisp_data_to_selection_data, x_property_data_to_lisp):
5743 Check for size-calculation overflow.
5744 (x_get_window_property, receive_incremental_selection)
5745 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5746 Don't store size until memory allocation succeeds.
5747 (x_get_window_property): Plug memory leak on memory exhaustion.
5748 Don't double-block input; malloc is safe here. Don't assume 2**34
5749 - 4 fits in unsigned long. Add an xassert to check
5750 XGetWindowProperty overflow. Be more careful about overflow
5751 calculations, and distinguish size from memory overflow better.
5752 (receive_incremental_selection): When tracing, don't assume
5753 unsigned int is less than INT_MAX.
5754 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5755 harmful) conversions of unsigned short to int.
5756 (lisp_data_to_selection_data): Don't assume that integers
5757 in the range -65535 through -1 fit in an X unsigned short.
5758 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5759 result parameters unless successful. Rely on cons_to_unsigned
5760 to report problems with elements; the old code wasn't right anyway.
5761 (x_check_property_data): Check for int overflow; we cannot use
5762 a wider type due to X limits.
5763 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5764
726e0ab1 5765 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5766
0065d054
PE
5767 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5768 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5769 (x_color_cells): Don't store size until memory allocation succeeds.
5770 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5771 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5772 (x_term_init): Don't assume length fits in int (sprintf is limited
5773 to int size).
bc18e09d 5774
ebfa62c0
PE
5775 Use ptrdiff_t for composition IDs.
5776 * character.c (lisp_string_width):
5777 * composite.c (composition_table_size, n_compositions)
5778 (get_composition_id, composition_gstring_from_id):
5779 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5780 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5781 * window.c (Frecenter):
5782 Use ptrdiff_t, not int, for composition IDs.
5783 * composite.c (get_composition_id): Check for integer overflow.
5784 * composite.h: Adjust prototypes to match the above changes.
5785
d3411f89
PE
5786 Use ptrdiff_t for hash table indexes.
5787 * category.c (hash_get_category_set):
5788 * ccl.c (ccl_driver):
5789 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5790 * coding.c (coding_system_charset_list, detect_coding_system):
5791 * coding.h (struct coding_system.id):
5792 * composite.c (get_composition_id, gstring_lookup_cache):
5793 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5794 * image.c (xpm_get_color_table_h):
5795 * lisp.h (hash_lookup, hash_put):
5796 * minibuf.c (Ftest_completion):
5797 Use ptrdiff_t for hash table indexes, not int (which is too
5798 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5799 32-bit --with-wide-int hosts).
5800
e097a6fa
PE
5801 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5802 Add a FIXME comment about memory leaks.
5803 (syms_of_charset): Don't assume xmalloc returns.
5804
5637687f
PE
5805 Don't assume that stated character widths fit in int.
5806 * character.c (Fchar_width, c_string_width, lisp_string_width):
5807 * character.h (CHAR_WIDTH):
5808 * indent.c (MULTIBYTE_BYTES_WIDTH):
5809 Use sanitize_char_width to avoid undefined and/or bad behavior
5810 with outlandish widths.
a66cfb1c 5811 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5812 now that we have two such functions. All uses changed.
5813 (sanitize_char_width): New inline function.
5814
a2271ba2
PE
5815 Don't assume that tab-width fits in int.
5816 * character.h (sanitize_width): New inline function.
5817 (SANE_TAB_WIDTH): New macro.
5818 (ASCII_CHAR_WIDTH): Use it.
5819 * indent.c (sane_tab_width): Remove. All uses replaced by
5820 SANE_TAB_WIDTH (current_buffer).
5821 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5822
18c52557
PE
5823 * fileio.c: Integer overflow issues with file modes.
5824 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5825
caeeedc1
PE
5826 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5827 Remove unreachable code.
5828 (read_hex, load_charset_map_from_file): Check for integer overflow.
5829
6df6ae42 5830 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5831 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5832 (x_send_scroll_bar_event): Likewise. Check that the size does not
5833 exceed limits imposed by XClientMessageEvent, as well as the usual
5834 ptrdiff_t and size_t limits.
5835
b13995db
PE
5836 * keyboard.c: Overflow, signedness and related fixes.
5837 (make_lispy_movement): Use same integer type in forward decl
5838 that is used in the definition.
5839 (read_key_sequence, keyremap_step):
5840 Change bufsize argument back to int, undoing my 2011-03-30 change.
5841 We prefer signed types, and int is wide enough here.
5842 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5843 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5844 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5845 length, not size_t. Use ptrdiff_t for index, not int.
5846 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5847 possibility of integer overflow.
5848
13464394
PE
5849 Overflow, signedness and related fixes for images.
5850
5851 * dispextern.h (struct it.stack[0].u.image.image_id)
5852 (struct_it.image_id, struct image.id, struct image_cache.size)
5853 (struct image_cache.used, struct image_cache.ref_count):
5854 * gtkutil.c (update_frame_tool_bar):
5855 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5856 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5857 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5858 * nsmenu.m (update_frame_tool_bar):
5859 * xdisp.c (calc_pixel_width_or_height):
5860 * xfns.c (image_cache_refcount):
5861 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5862 on typical 64-bit hosts.
5863
5864 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5865 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5866 Omit unnecessary casts to int.
5867 (parse_image_spec): Check that integers fall into 'int' range
5868 when the callers expect that.
5869 (image_ascent): Redo ascent calculation to avoid int overflow.
5870 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5871 (lookup_image): Remove unnecessary tests.
5872 (xbm_image_p): Locals are now of int, not EMACS_INT,
5873 since parse_image_check makes sure they fit into int.
5874 (png_load, gif_load, svg_load_image):
5875 Prefer int to unsigned where either will do.
5876 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5877 old tiff_error_handler and tiff_warning_handler.
5878 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5879 stack buffer overflows. It uses only the features of vsnprintf
5880 that are common to both POSIX and native Microsoft.
5881 (tiff_error_handler, tiff_warning_handler): Use it.
5882 (tiff_load, gif_load, imagemagick_load_image):
5883 Don't assume :index value fits in 'int'.
5884 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5885 (imagemagick_load_image): Check that crop parameters fit into
5886 the integer types that MagickCropImage accepts. Don't assume
5887 Vimagemagick_render_type has a nonnegative value. Don't assume
5888 size_t fits in 'long'.
5889 (gs_load): Use printmax_t to print the widest integers possible.
5890 Check for integer overflow when computing image height and width.
5891
c11821d4
EZ
58922011-08-26 Eli Zaretskii <eliz@gnu.org>
5893
5894 * xdisp.c (redisplay_window): Don't force window start if point
5895 will be invisible in the resulting window. (Bug#9324)
5896
0c95fcf7
EZ
58972011-08-25 Eli Zaretskii <eliz@gnu.org>
5898
5899 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5900 the display spec is of the form `(space ...)'.
5901 (handle_display_spec): Return the value returned by
5902 handle_single_display_spec, not just 1 or zero.
5903 (handle_single_display_spec): If the display spec is of the form
5904 `(space ...)', and specifies display in the text area, return 2
5905 rather than 1.
fee65a97 5906 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5907 accurately, and prefer exact match for point under bidi.
5908 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5909
5910 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5911 into disp_prop; all users changed.
5912
5913 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5914 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5915 for the text covered by the display property.
5916
e4ed06f1
CY
59172011-08-25 Chong Yidong <cyd@stupidchicken.com>
5918
5919 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5920 Change return value to nil.
5921 (Frecord_buffer): Delete unused function.
5922
f67cdd7f
EZ
59232011-08-24 Eli Zaretskii <eliz@gnu.org>
5924
5980d4c6
EZ
5925 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5926 buffers, return left-to-right.
8610fe8b
EZ
5927 (set_cursor_from_row): Consider candidate row a win if its glyph
5928 represents a newline and point is on that newline. Fixes cursor
5929 positioning on the newline at EOL of R2L text within L2R
5930 paragraph, and vice versa.
5931 (try_cursor_movement): Check continued rows, in addition to
5932 continuation rows. Fixes unwarranted scroll when point enters a
5933 continued line of R2L text within an L2R paragraph, or vice versa.
5934 (cursor_row_p): Consider the case of point being equal to
5935 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5936 from the end of a short line to the beginning of a continued line
5937 of R2L text within L2R paragraph.
5938 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5939 composed characters.
5980d4c6 5940
f67cdd7f
EZ
5941 * bidi.c (bidi_check_type): Use xassert.
5942 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5943 members.
5944
bca633fb
EZ
59452011-08-23 Eli Zaretskii <eliz@gnu.org>
5946
5947 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5948 a character.
5949
4a5885a7
CY
59502011-08-23 Chong Yidong <cyd@stupidchicken.com>
5951
5952 * nsfont.m (ns_otf_to_script): Fix typo.
5953
0902a04e
KH
59542011-08-22 Kenichi Handa <handa@m17n.org>
5955
5956 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5957 extra slot even if the purpose is char-code-property-table.
5958
1a2e6670
EZ
59592011-08-23 Eli Zaretskii <eliz@gnu.org>
5960
8ddde651
EZ
5961 * xdisp.c (redisplay_window): When computing centering_position,
5962 account for the height of the header line. (Bug#8874)
5963
425cc014
EZ
5964 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5965 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5966 candidate is selected by the mouse, and that candidate has a
5967 composed character under the mouse.
5968
1a2e6670
EZ
5969 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5970 coordinates reported by pos-visible-in-window-p for a composed
5971 character in column zero.
5972
8b76d6f8
SM
59732011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5974
5975 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5976
dac347dd
EZ
59772011-08-22 Eli Zaretskii <eliz@gnu.org>
5978
5979 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5980 consider it a hit if to_charpos is anywhere in the range of the
5981 composed buffer positions.
5982
e013fb34
CY
59832011-08-22 Chong Yidong <cyd@stupidchicken.com>
5984
5985 * image.c (gif_load): Don't assume that each subimage has the same
5986 dimensions as the base image. Handle disposal method that is
5987 "undefined" by the gif spec (Bug#9335).
5988
bd1ba3e8
CY
59892011-08-20 Chong Yidong <cyd@stupidchicken.com>
5990
5991 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5992 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5993
54a1215b
EZ
59942011-08-19 Eli Zaretskii <eliz@gnu.org>
5995
823564e5
EZ
5996 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5997 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5998 from an Org mode buffer to a Speedbar frame.
5999
54a1215b
EZ
6000 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6001 a composition, take its buffer position from IT->cmp_it.charpos.
6002 Fixes cursor positioning at the beginning of a line that begins
6003 with a composed character.
6004
9778ebcc
EZ
60052011-08-18 Eli Zaretskii <eliz@gnu.org>
6006
0be6ee06
EZ
6007 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6008 character bidirectional type, use STRONG_L instead. Fixes crashes
6009 in a buffer produced by `describe-categories'.
6010
9778ebcc
EZ
6011 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6012 members before the level stack, so they would be saved and
6013 restored when copying iterator state. Fixes incorrect reordering
6014 around TABs covered by display properties.
6015
156bffbe
AS
60162011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6017
6b02f655 6018 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6019
72ad093b
CY
60202011-08-17 Chong Yidong <cyd@stupidchicken.com>
6021
6022 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6023 (internal_condition_case_2, internal_condition_case_n):
6024 Remove unnecessary aborts (Bug#9081).
72ad093b 6025
35774242
EZ
60262011-08-17 Eli Zaretskii <eliz@gnu.org>
6027
6028 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6029 has no `load' handler, try opening the file locally. (Bug#9311)
6030
db76dd85
KB
60312011-08-16 Ken Brown <kbrown@cornell.edu>
6032
6033 * gmalloc.c: Expand comment.
6034
b215eee5
EZ
60352011-08-16 Eli Zaretskii <eliz@gnu.org>
6036
6037 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6038 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6039
a4579d33
KB
60402011-08-16 Ken Brown <kbrown@cornell.edu>
6041
6042 Fix memory allocation problems in Cygwin build (Bug#9273).
6043
6044 * unexcw.c ( __malloc_initialized): Declare external variable.
6045 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6046
8b76d6f8
SM
6047 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6048 New variables.
a4579d33
KB
6049 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6050 dumped emacs.
6051 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6052 in the static heap.
6053 [CYGWIN] (special_realloc): New function.
6054 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6055 requests to realloc storage in the static heap.
6056
3ebec551
PE
60572011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6058
6059 * bidi.c (bidi_initialize): Remove unused local.
6060
9fd8be00
EZ
60612011-08-15 Eli Zaretskii <eliz@gnu.org>
6062
6b02f655
SM
6063 * bidimirror.h:
6064 * biditype.h: Remove file.
6065 * makefile.w32-in ($(BLD)/bidi.$(O)):
6066 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6067
6068 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6069
6070 * chartab.c: Improve commentary for the uniprop_table API.
6071
32413314
EZ
6072 * bidi.c (bidi_paragraph_init): Support zero value of
6073 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6074 (bidi_initialize): Use uniprop_table instead of including
6075 biditype.h and bidimirror.h.
32413314 6076
9fd8be00
EZ
6077 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6078 coordinates of the iterator when restoring from ppos_it.
6079 (Bug#9296)
6080
5cf2b69b
KH
60812011-08-14 Kenichi Handa <handa@m17n.org>
6082
6083 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6084 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6085
daf17d00
EZ
60862011-08-14 Eli Zaretskii <eliz@gnu.org>
6087
6088 * xdisp.c (move_it_in_display_line_to): Don't invoke
6089 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6090 ppos_it. Fixes vertical cursor motion when line beginning is
6091 covered by an image. (Bug#9296)
6092
08e3161a
JD
60932011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6094
6095 * nsterm.h (ns_run_ascript): Declare.
6096 (NSAPP_DATA2_RUNASSCRIPT): Define.
6097
6098 * nsfns.m (as_script, as_result, as_status): New static variables.
6099 (ns_run_ascript): New function.
5e617bc2 6100 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6101 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6102 the event loop. Get status from as_status (Bug#7276).
6103
6104 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6105 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6106 the event loop (Bug#7276).
6107
a3720aa2
AS
61082011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6109
6110 * gnutls.c (QCgnutls_bootprop_priority)
6111 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6112 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6113 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6114 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6115 (QCgnutls_bootprop_verify_hostname_error)
6116 (QCgnutls_bootprop_callbacks_verify): Rename from
6117 Qgnutls_bootprop_..., all uses changed.
6118
6119 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6120 uses changed.
6121
0a0d27fb
PE
61222011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6123
19d5c50c
PE
6124 * xfaces.c (Qframe_set_background_mode): Now static.
6125 * dispextern.h (Qframe_set_background_mode): Remove decl.
6126
0a0d27fb
PE
6127 * process.c (Fnetwork_interface_info): Declare local only if needed.
6128
377538cb
JD
61292011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6130
6131 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6132 (Fnetwork_interface_list): Allocate in increments of bytes instead
6133 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6134 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6135 sockaddr.
6136 (struct ifflag_def): notrailers is smart on OSX.
6137 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6138 Get hardware address with getifaddrs if available.
6139
08fff70c
EZ
61402011-08-12 Eli Zaretskii <eliz@gnu.org>
6141
6142 * xdisp.c (iterate_out_of_display_property): xassert that
6143 IT->position is set to within IT->object's boundaries. Break from
6144 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6145 when IT->position is set up wrongly due to some bug.
6146 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6147 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6148 entry. Force push_it to save on the stack the current
6149 buffer/string position, to be restored by pop_it. Fix flags in
6150 the iterator structure wrt the object coming from a display
6151 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6152 properties. (Bug#9284)
6153
7be1c708 61542011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6155
7be1c708
CY
6156 * fontset.c (fontset_get_font_group): Add proper type checks.
6157 (Bug#9172)
aac0c6e3 6158
7be1c708 61592011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6160
7be1c708
CY
6161 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6162 and LC_VERSION_MIN_MACOSX.
6163 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6164 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6165
97bb72a6
EZ
61662011-08-08 Eli Zaretskii <eliz@gnu.org>
6167
6168 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6169 no-display-properties-and-no-overlays under bidi display.
6170 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6171 properties and overlays.
97bb72a6 6172
d5617611
CY
61732011-08-08 Chong Yidong <cyd@stupidchicken.com>
6174
37e11a63
CY
6175 * editfns.c (Fset_time_zone_rule): Document relationship with the
6176 setenv function.
6177
d5617611
CY
6178 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6179 the font entity extracted from the cache (Bug#8109).
6180
58872834
CY
61812011-08-07 Chong Yidong <cyd@stupidchicken.com>
6182
6183 * composite.c (autocmp_chars): Don't reset point. That is done by
6184 restore_point_unwind (Bug#5984).
6185
75bfc667
JL
61862011-08-07 Juri Linkov <juri@jurta.org>
6187
6188 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6189 to show the arg `TIME' instead of `TIMEVAL'.
6190
d1410150
EZ
61912011-08-06 Eli Zaretskii <eliz@gnu.org>
6192
6193 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6194 display property strides EOL and includes a newline, as in
6195 longlines-mode. (Bug#9254)
75b771e4
EZ
6196 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6197 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6198
6199 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6200 is non-zero, even if the data buffer is NULL. Fixes a crash in
6201 vertical-motion with longlines-mode. (Bug#9254)
6202
35928349
EZ
62032011-08-05 Eli Zaretskii <eliz@gnu.org>
6204
ec7cc85b
EZ
6205 * bidi.c <bidi_cache_total_alloc>: Now static.
6206 (bidi_initialize): Initialize bidi_cache_total_alloc.
6207
8b76d6f8 6208 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6209 cache. (Bug#9221)
6210
6211 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6212 amount allocated this far in `bidi_cache_total_alloc'.
6213 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6214 non-zero, only free the data buffer without restoring the cache
6215 contents. All callers changed.
6216
6217 * dispextern.h (bidi_unshelve_cache): Update prototype.
6218
6219 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6220 (move_it_in_display_line, move_it_to)
6221 (move_it_vertically_backward, move_it_by_lines): Replace the call
6222 to xfree to an equivalent call to bidi_unshelve_cache.
6223 (move_it_in_display_line_to): Fix logic of returning
412b6358 6224 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6225
e2e2423b
EZ
62262011-08-05 Eli Zaretskii <eliz@gnu.org>
6227
6228 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6229 came from a string character with a `cursor' property. (Bug#9229)
6230
ae9e757a
JD
62312011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6232
6233 * Makefile.in (LIB_PTHREAD): New variable.
6234 (LIBES): Add LIB_PTHREAD (Bug#9216).
6235
6236 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6237 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6238
213bd7f2
AS
62392011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6240
6b02f655 6241 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6242
99aaf75f
JD
62432011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6244
6245 * xterm.c (x_find_topmost_parent): New function.
6246 (x_set_frame_alpha): Find topmost parent window with
6247 x_find_topmost_parent and set the property there also (bug#9181).
6248 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6249
c74e9d86
PE
62502011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6251
6252 * callproc.c (Fcall_process): Avoid vfork clobbering
6253 the local vars buffer, coding_systems, current_dir.
6254
640c8776
SM
62552011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6256
6257 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6258
f26d0e4c
PE
62592011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6260
8a10d76c
PE
6261 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6262 so that it is not optimized away.
6263
f26d0e4c
PE
6264 * xdisp.c (compute_display_string_pos): Remove unused local.
6265
55439c61
EZ
62662011-08-02 Eli Zaretskii <eliz@gnu.org>
6267
6268 Fix slow cursor motion and scrolling in large buffers with
6269 selective display, like Org Mode buffers. (Bug#9218)
6270
6271 * dispextern.h (struct bidi_it): New member disp_prop_p.
6272
6273 * xdisp.c: Remove one-slot cache of display string positions.
6274 (compute_display_string_pos): Accept an additional argument
5e617bc2 6275 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6276 for a display string or property. If found, set DISP_PROP_P
6277 non-zero.
6278
6279 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6280 DISP_PROP_P, and pass it to compute_display_string_pos.
6281 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6282 non-zero. All callers of bidi_fetch_char changed.
6283
fb33fa43
SM
62842011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6285
6286 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6287
b099e063
DM
62882010-12-03 Don March <don@ohspite.net>
6289
6290 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6291 last character M-[char] is translated to ESC [char] (bug#7541).
6292
5cc7f7af
KH
62932011-08-02 Kenichi Handa <handa@m17n.org>
6294
d0fffa3f 6295 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6296
6297 * chartab.c (uniprop_table): Make it non-static.
6298
525d5e6e
EZ
62992011-08-01 Eli Zaretskii <eliz@gnu.org>
6300
6301 * xdisp.c (forward_to_next_line_start): Accept additional argument
6302 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6303 on the newline.
6304 (reseat_at_next_visible_line_start): Use the bidi iterator state
6305 returned by forward_to_next_line_start to restore the state of
6306 it->bidi_it after backing up to previous newline. (Bug#9212)
6307
31011111
AS
63082011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6309
6310 * regex.c (re_comp): Protoize.
6311 (re_exec): Fix return type.
6312 (regexec): Fix type of `ret'. (Bug#9203)
6313
476371c4
PE
63142011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6315
e5d76069
PE
6316 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6317 This is needed if max-image-size is a floating-point number.
6318
9a79b20c
AS
63192011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6320
6321 * print.c (print_object): Print empty symbol as ##.
6322
6323 * lread.c (read1): Read ## as empty symbol.
6324
d8c2fa78
AA
63252011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6326
6327 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6328 setting frame foreground color (Bug#9175).
6329 (x_set_background_color): Likewise.
6330
ffe57a7a
AA
6331 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6332 contents (Bug#9176).
6333 (EmacsTooltip -init): Remove bezels and add shadows to
6334 tooltip windows.
6335
bf3492a5
AA
6336 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6337 or scroll bar (Bug#8470).
6338
d55e9c53
AA
6339 * nsfont.m (nsfont_open): Remove assignment to voffset and
6340 unnecessary vars hshink, expand, hd, full_height, min_height.
6341 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6342
6343 * nsterm.h (nsfont_info): Remove voffset field.
6344
d8c2fa78 63452011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6346
6347 Implement strike-through and overline on NextStep (Bug#8863).
6348
6349 * nsfont.m (nsfont_open): Use underline position provided by font,
6350 instead of hard-coded value of 2.
6351 (nsfont_draw): Call ns_draw_text_decoration instead.
6352
6353 * nsterm.h: Add declaration for ns_draw_text_decoration.
6354
6355 * nsterm.m (ns_draw_text_decoration): New function for drawing
6356 underline, overline, and strike-through.
6357 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6358 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6359 accommodate underlining, etc.
4843aac3 6360
4cc60b9b
EZ
63612011-07-28 Eli Zaretskii <eliz@gnu.org>
6362
bc7ece87
EZ
6363 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6364 default.
4cc60b9b 6365
476371c4
PE
63662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6367
66606eea
PE
6368 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6369 Without this fix, if a signal arrives just after memory fills up,
6370 'malloc' might be invoked reentrantly.
6371
476371c4
PE
6372 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6373 In other words, assume that every image size is allowed, on non-X
6374 hosts. This assumption is probably wrong, but it lets Emacs compile.
6375
f3fcc40d
AS
63762011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6377
6378 * regex.c (re_iswctype): Convert return values to boolean.
6379
350c992f
EZ
63802011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6381
6382 * xdisp.c (compute_display_string_pos): Don't use cached display
6383 string position if the buffer had its restriction changed.
6384 (Bug#9184)
6385
5266b4bb
PE
63862011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6387
6388 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6389
2573a837 63902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6391
41f55ccd 6392 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6393
39e378da
PE
6394 * bidi.c: Integer size and overflow fixes.
6395 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6396 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6397 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6398 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6399 (bidi_find_other_level_edge):
6400 Use ptrdiff_t instead of EMACS_INT where either will do.
6401 This works better on 32-bit hosts configured --with-wide-int.
6402 (bidi_cache_ensure_space): Check for size-calculation overflow.
6403 Use % rather than repeated addition, for better worst-case speed.
6404 Don't set bidi_cache_size until after xrealloc returns, because it
6405 might not return.
6406 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6407 (bidi_cache_ensure_space): Also check that the bidi cache size
6408 does not exceed that of the largest Lisp string or buffer. See Eli
6409 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6410
5e927815
PE
6411 * alloc.c (__malloc_size_t): Remove.
6412 All uses replaced by size_t. See Andreas Schwab's note
6413 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6414
ca4aa935
PE
6415 * image.c: Improve checking for integer overflow.
6416 (check_image_size): Assume that f is nonnull, since
6417 it is always nonnull in practice. This is one less thing to
6418 worry about when checking for integer overflow later.
6419 (x_check_image_size): New function, which checks for integer
6420 overflow issues inside X.
6421 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6422 This removes the need for a memory_full check.
6423 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6424 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6425 (xbm_read_bitmap_data): Change locals back to 'int', since
6426 their values must fit in 'int'.
6427 (xpm_load_image, png_load, tiff_load):
6428 Invoke x_create_x_image_and_pixmap earlier,
6429 to avoid much needless work if the image is too large.
6430 (tiff_load): Treat overly large images as if
6431 x_create_x_image_and_pixmap failed, not as malloc failures.
6432 (gs_load): Use x_check_image_size.
6433
5f8f9cc2
PE
6434 * gtkutil.c: Omit integer casts.
6435 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6436 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6437
5adf60bc
PE
6438 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6439
c8907a93
PE
6440 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6441 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6442 would wrongly return t on a 64-bit host.
6443
e3c25c68
PE
6444 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6445 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6446 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6447 and therefore cause GCC to emit a bogus diagnostic in some cases.
6448
3f791afe
PE
6449 * image.c: Integer signedness and overflow and related fixes.
6450 This is not an exhaustive set of fixes, but it's time to
6451 record what I've got.
6452 (lookup_pixel_color, check_image_size): Remove redundant decls.
6453 (check_image_size): Don't assume that arbitrary EMACS_INT values
6454 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6455 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6456 (tiff_load, imagemagick_load_image):
6457 Check for overflow in size calculations.
6458 (x_create_x_image_and_pixmap): Remove unnecessary test for
6459 xmalloc returning NULL; that can't happen.
6460 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6461 (xpm_color_bucket): Use better integer hashing function.
6462 (xpm_cache_color): Don't possibly over-allocate memory.
6463 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6464 (gif_memory_source):
6465 Use ptrdiff_t, not int or size_t, to record sizes.
6466 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6467 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6468 either works, as we prefer signed integers.
6469 (tiff_read_from_memory, tiff_write_from_memory):
6470 Return tsize_t, not size_t, since that's what the TIFF API wants.
6471 (tiff_read_from_memory): Don't fail simply because the read would
6472 go past EOF; instead, return a short read.
6473 (tiff_load): Omit no-longer-needed casts.
6474 (Fimagemagick_types): Don't assume size fits into 'int'.
6475
3cc5a532
PE
6476 Improve hashing quality when configured --with-wide-int.
6477 * fns.c (hash_string): New function, taken from sxhash_string.
6478 Do not discard information about ASCII character case; this
6479 discarding is no longer needed.
6480 (sxhash-string): Use it. Change sig to match it. Caller changed.
6481 * lisp.h: Declare it.
6482 * lread.c (hash_string): Remove, since we now use fns.c's version.
6483 The fns.c version returns a wider integer if --with-wide-int is
6484 specified, so this should help the quality of the hashing a bit.
6485
b312a492
PE
6486 * emacs.c: Integer overflow minor fix.
6487 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6488 Define only if GNU_LINUX.
6489 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6490
dfd153ae
PE
6491 * dispnew.c: Integer signedness and overflow fixes.
6492 Remove unnecessary forward decls, that were a maintenance hassle.
6493 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6494 All uses changed.
6495 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6496 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6497 (prepare_desired_row, line_draw_cost):
6498 Use int, not unsigned, where either works.
6499 (save_current_matrix, restore_current_matrix):
6500 Use ptrdiff_t, not size_t, where either works.
6501 (init_display): Check for overflow more accurately, and without
6502 relying on undefined behavior.
6503
a81d11a3
PE
6504 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6505 Remove, replacing with the new symbols in lisp.h. All uses changed.
6506 * fileio.c (make_temp_name):
6507 * filelock.c (lock_file_1, lock_file):
6508 * xdisp.c (message_dolog):
6509 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6510 Use pMd etc. instead.
6511 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6512 replacing the pWIDE etc. symbols removed from editfns.c.
6513
3300e6fd
PE
6514 * keyboard.h (num_input_events): Now uintmax_t.
6515 This is (very slightly) less likely to mess up due to wraparound.
6516 All uses changed.
6517
fd05c7e9
PE
6518 * buffer.c: Integer signedness fixes.
6519 (alloc_buffer_text, enlarge_buffer_text):
6520 Use ptrdiff_t rather than size_t when either will do, as we prefer
6521 signed integers.
6522
903fe15d
PE
6523 * alloc.c: Integer signedness and overflow fixes.
6524 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6525 (__malloc_size_t): Default to size_t, not to int.
6526 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6527 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6528 Prefer ptrdiff_t to size_t when either would do, as we prefer
6529 signed integers.
6530 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6531 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6532 Now const. Initialize with values that are in range even if char
6533 is signed.
6534 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6535 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6536 These functions do the right thing with sizes > 2**32.
6537 (check_depth): Now ptrdiff_t, not int.
6538 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6539 Adjust to new way of storing sizes. Check for size overflow bugs
6540 in rest of code.
6541 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6542 slightly wrong anyway, as it missed one instance of
6543 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6544 (refill_memory_reserve): Omit needless cast to size_t.
6545 (mark_object_loop_halt): Mark as externally visible.
6546
ac82cc6a
PE
6547 * xselect.c: Integer signedness and overflow fixes.
6548 (Fx_register_dnd_atom, x_handle_dnd_message):
6549 Use ptrdiff_t, not size_t, since we prefer signed.
6550 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6551 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6552 x_dnd_atoms_size and x_dnd_atoms_length.
6553
c2d1e36d
PE
6554 * doprnt.c: Prefer signed to unsigned when either works.
6555 * eval.c (verror):
6556 * doprnt.c (doprnt):
6557 * lisp.h (doprnt):
6558 * xdisp.c (vmessage):
6559 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6560 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6561 prefer signed arithmetic to avoid comparison confusion.
6562 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6563 but is a bit tricky.
6564
0e926e56
PE
6565 Assume freestanding C89 headers, string.h, stdlib.h.
6566 * data.c, doprnt.c, floatfns.c, print.c:
6567 Include float.h unconditionally.
6568 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6569 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6570 * regex.c: Likewise for stddef.h, string.h.
6571 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6572 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6573 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6574 (STDC_HEADERS): Remove obsolete defines.
6575 * sysdep.c: Include limits.h unconditionally.
6576
9cfdb3ec
PE
6577 Assume support for memcmp, memcpy, memmove, memset.
6578 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6579 * regex.c (memcmp, memcpy):
6580 Remove; we assume C89 now.
6581
6582 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6583 (__malloc_safe_bcopy): Remove; no longer needed.
6584
cf950e6b 6585 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6586 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6587 well either way, and we prefer signed to unsigned.
6588
dbf38e02
LMI
65892011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6590
6591 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6592 closes the connection while we're reading (bug#9182).
6593
d6f0886c 65942011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6595
d6f0886c
JD
6596 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6597 are specified (Bug#9168).
24e0f6b1 6598
2eb1f9e6
PE
65992011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6600
6601 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6602 Found by GCC static checking and --with-wide-int on a 32-bit host.
6603
22381272 66042011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6605
6606 * xdisp.c (compute_display_string_pos): Fix logic of caching
6607 previous display string position. Initialize cached_prev_pos to
6608 -1. Fixes slow-down at the beginning of a buffer.
6609
f25e39b4
EZ
66102011-07-24 Eli Zaretskii <eliz@gnu.org>
6611
6612 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6613 for attrs[LFACE_FONTSET_INDEX].
6614
04c4b52e
PE
66152011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6616
6617 * xml.c (parse_region): Remove unused local
6618 that was recently introduced.
6619
c1734fbd
EZ
66202011-07-23 Eli Zaretskii <eliz@gnu.org>
6621
be18c5a5
EZ
6622 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6623 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6624
c1734fbd
EZ
6625 * xdisp.c (move_it_in_display_line_to): Record the best matching
6626 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6627 exit if none of the characters scanned was an exact match.
6628 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6629 when exact match is impossible due to invisible text, and the
6630 lines are truncated.
6631
a258d627
JD
66322011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6633
6634 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6635 for OSX >= 10.7.
6636
b6d5a689
EZ
66372011-07-22 Eli Zaretskii <eliz@gnu.org>
6638
0f74f785
EZ
6639 Fix a significant slow-down of cursor motion with C-n, C-p,
6640 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6641 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6642 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6643 (next_element_from_buffer): Call compute_stop_pos_backwards to
6644 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6645 base_level_stop.
6646 (reseat): Don't look for prev_stop, as that could mean a very long
6647 run.
6648 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6649 <cached_disp_overlay_modiff>: Cache for last found display string
6650 position.
551918c1 6651 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6652 about the same buffer in the same area of character positions, and
6653 the buffer wasn't changed since the time the display string
6654 position was cached.
551918c1 6655
b2d0c91a
EZ
66562011-07-22 Eli Zaretskii <eliz@gnu.org>
6657
6658 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6659 is an integer, which is important for empty lines. (Bug#9149)
6660
043604ee
CY
66612011-07-22 Chong Yidong <cyd@stupidchicken.com>
6662
6663 * frame.c (Fmodify_frame_parameters): In tty case, update the
6664 default face if necessary (Bug#4238).
6665
da4adb04
CY
66662011-07-21 Chong Yidong <cyd@stupidchicken.com>
6667
6668 * editfns.c (Fstring_to_char): No need to explain what a character
6669 is in the docstring (Bug#6576).
6670
9abd0532
LMI
66712011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6672
6673 * xml.c (parse_region): Make sure we always return a tree.
6674
36881d16
HK
66752011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6676
6677 * xml.c (parse_region): If a document contains only comments,
6678 return that, too.
6679
1e98674d
LMI
66802011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6681
6682 * xml.c (make_dom): Return comments, too.
6683
590bd467
PE
66842011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6685
6686 Port to OpenBSD.
6687 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6688 and the surrounding thread.
6689 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6690 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6691 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6692 timer goes off.
6693 * s/openbsd.h (BROKEN_SIGIO): Define.
6694 * unexelf.c (unexec) [__OpenBSD__]:
6695 Don't update the .mdebug section of the Alpha COFF symbol table.
6696
f41628b2
LMI
66972011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6698
6699 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6700 (bug#8460).
6701
b59b67c5
PE
67022011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6703
15e3a074
PE
6704 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6705 This fixes some race conditions on the permissions of any newly
6706 created file.
6707
41bed37d
PE
6708 * alloc.c (valid_pointer_p): Use pipe, not open.
6709 This fixes some permissions issues when debugging.
6710
b59b67c5
PE
6711 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6712 If fchown fails to set both uid and gid, try to set just gid,
6713 as that is sometimes allowed. Adjust the file's mode to eliminate
6714 setuid or setgid bits that are inappropriate if fchown fails.
6715
925a6be7
SM
67162011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6717
6718 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6719 to compare Lisp_Objects.
6720 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6721 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6722 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6723
52968808
AS
67242011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6725
0a6a104b
AS
6726 * lread.c (read_integer): Unread even EOF character.
6727 (read1): Likewise. Properly record start position of symbol.
6728
52968808
AS
6729 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6730 symbol character follows.
6731
9e381cdd
PE
67322011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6733
6734 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6735 This works around a problem with the previous change to Fcopy_file.
6736 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6737 and without this change, GCC might complain about discarding
6738 fchown's return value.
6739
b5641435
JB
67402011-07-16 Juanma Barranquero <lekktu@gmail.com>
6741
6742 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6743
a8031457
PE
67442011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6745
6746 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6747
dd889327
LMI
67482011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6749
750c33f7
LMI
6750 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6751 it's used from the C level.
6752
dd889327
LMI
6753 * process.c: Use the same condition for POLL_FOR_INPUT in both
6754 keyboard.c and process.c (bug#1858).
6755
87e86684
LM
67562011-07-09 Lawrence Mitchell <wence@gmx.li>
6757
6758 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6759 (Fgnutls_boot): Use it.
6760
64348f40
AS
67612011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6762
6763 * doc.c (Fsubstitute_command_keys): Revert last change.
6764
1d698799
LMI
67652011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6766
f863868c
LMI
6767 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6768 quotes the next character, and doesn't affect other longer
6769 sequences (bug#8935).
6770
1d698799
LMI
6771 * lread.c (syms_of_lread): Clarify that is isn't only
6772 `eval-buffer' and `eval-defun' that's affected by
6773 `lexical-binding' (bug#8460).
6774
aa4b6df6
EZ
67752011-07-15 Eli Zaretskii <eliz@gnu.org>
6776
6777 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6778 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6779
5d856da6
PE
67802011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6781
ad6042bb
PE
6782 Fix minor problems found by static checking.
6783 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6784 (elsz): Now a signed constant, not a size_t var. We prefer signed
6785 types to unsigned, to avoid integer comparison confusion. Without
6786 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6787 "cannot optimize loop, the loop counter may overflow", a symptom
6788 of the confusion.
f00bbb22 6789 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6790 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6791
6468f31c
LMI
67922011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6793
49080b10
LMI
6794 * search.c (Fre_search_backward): Mention `case-fold-search' in
6795 all the re_search_* functions (bug#8138).
6796
6468f31c
LMI
6797 * keyboard.c (Fopen_dribble_file): Document when the file is
6798 closed (bug#8056).
6799
c965adc5
EZ
68002011-07-14 Eli Zaretskii <eliz@gnu.org>
6801
df9733bf
EZ
6802 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6803 bidi_cache_idx.
6804
0bb23927
EZ
6805 Support bidi reordering of display and overlay strings.
6806 * xdisp.c (compute_display_string_pos)
6807 (compute_display_string_end): Accept additional argument STRING.
6808 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6809 (reseat_to_string): Initialize bidi_it->string.s and
6810 bidi_it->string.schars.
6811 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6812 NULL (avoids a crash in bidi_paragraph_init).
6813 Initialize itb.string.lstring.
0bb23927
EZ
6814 (init_iterator): Call bidi_init_it only of a valid
6815 buffer position was specified. Initialize paragraph_embedding to
6816 L2R.
6817 (reseat_to_string): Initialize the bidi iterator.
6818 (display_string): If we need to ignore text properties of
6819 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6820 original value of -1 will not work with bidi.)
6821 (compute_display_string_pos): First arg is now struct
6822 `text_pos *'; all callers changed. Support display properties on
6823 Lisp strings.
6824 (compute_display_string_end): Support display properties on Lisp
6825 strings.
6826 (init_iterator, reseat_1, reseat_to_string): Initialize the
6827 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6828 when iterating on a string not from display properties).
640c8776
SM
6829 (compute_display_string_pos, compute_display_string_end):
6830 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6831 arrow keys.
6832 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6833 base_level_stop; instead, set base_level_stop to BEGV.
6834 Fixes crashes in vertical-motion.
0bb23927
EZ
6835 (next_element_from_buffer): Improve commentary for when
6836 the iterator is before prev_stop.
6837 (init_iterator): Initialize bidi_p from the default value of
6838 bidi-display-reordering, not from buffer-local value. Use the
6839 buffer-local value only if initializing for buffer iteration.
6840 (handle_invisible_prop): Support invisible properties on strings
6841 that are being bidi-reordered.
6842 (set_iterator_to_next): Support bidi reordering of C strings and
6843 Lisp strings.
6844 (next_element_from_string): Support bidi reordering of Lisp
6845 strings.
6846 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6847 (display_string): Support display of R2L glyph rows.
6848 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6849 (init_iterator): Don't initialize it->bidi_p for strings
6850 here.
6851 (reseat_to_string): Initialize it->bidi_p for strings here.
6852 (next_element_from_string, next_element_from_c_string)
6853 (next_element_from_buffer): Add xassert's for correspondence
6854 between IT's object being iterated and it->bidi_it.string
6855 structure.
6856 (face_before_or_after_it_pos): Support bidi iteration.
6857 (next_element_from_c_string): Handle the case of the first string
6858 character that is not the first one in the visual order.
6859 (get_visually_first_element): New function, refactored from common
6860 parts of next_element_from_buffer, next_element_from_string, and
6861 next_element_from_c_string.
6862 (tool_bar_lines_needed, redisplay_tool_bar)
6863 (display_menu_bar): Force left-to-right direction. Add a FIXME
6864 comment for making that be controlled by a user option.
6865 (push_it, pop_it): Save and restore the state of the
6866 bidi iterator. Save and restore the bidi_p flag.
6867 (pop_it): Iterate out of display property for string iteration as
6868 well.
6869 (iterate_out_of_display_property): Support iteration over strings.
6870 (handle_single_display_spec): Set up it->bidi_it for iteration
6871 over a display string, and call bidi_init_it.
6872 (handle_single_display_spec, next_overlay_string)
6873 (get_overlay_strings_1, push_display_prop): Set up the bidi
6874 iterator for displaying display or overlay strings.
6875 (forward_to_next_line_start): Don't use the shortcut if
6876 bidi-iterating.
6877 (back_to_previous_visible_line_start): If handle_display_prop
6878 pushed the iterator stack, restore the internal state of the bidi
6879 iterator by calling bidi_pop_it same number of times.
6880 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6881 and we are bidi-iterating, don't decrement the iterator position;
6882 instead, set the first_elt flag in the bidi iterator, to produce
6883 the same effect.
6884 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6885 (push_display_prop): xassert that we are iterating a buffer.
6886 (push_it, pop_it): Save and restore paragraph_embedding member.
6887 (handle_single_display_spec, next_overlay_string)
6888 (get_overlay_strings_1, reseat_1, reseat_to_string)
6889 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6890 correctly. Don't assume unibyte strings are not bidi-reordered.
6891 (compute_display_string_pos)
6892 (compute_display_string_end): Fix handling the case of C string.
6893 (push_it, pop_it): Save and restore from_disp_prop_p.
6894 (handle_single_display_spec, push_display_prop): Set the
6895 from_disp_prop_p flag.
6896 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6897 (pop_it): Call iterate_out_of_display_property only if we are
6898 popping after iteration over a string that came from a display
6899 property. Fix a typo in popping stretch info. Add an assertion
6900 for verifying that the iterator position is in sync with the bidi
6901 iterator.
6902 (handle_single_display_spec, get_overlay_strings_1)
6903 (push_display_prop): Fix initialization of paragraph direction for
6904 string when that of the parent object is not yet determined.
6905 (reseat_1): Call bidi_init_it to resync the bidi
6906 iterator with IT's position. (Bug#7616)
6907 (find_row_edges): If ROW->start.pos gives position
6908 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6909 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6910 Reset the from_disp_prop_p flag.
6911 (SAVE_IT, RESTORE_IT): New macros.
6912 (pos_visible_p, face_before_or_after_it_pos)
6913 (back_to_previous_visible_line_start)
6914 (move_it_in_display_line_to, move_it_in_display_line)
6915 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6916 (try_scrolling, redisplay_window, display_line): Use them when
6917 saving a temporary copy of the iterator and restoring it back.
6918 (back_to_previous_visible_line_start, reseat_1)
6919 (init_iterator): Empty the bidi cache "stack".
6920 (move_it_in_display_line_to): If iterator ended up at
6921 EOL, but we never saw any buffer positions smaller than
6922 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6923 motion in bidi-reordered lines.
6924 (move_it_in_display_line_to): Record prev_method and prev_pos
6925 immediately before the call to set_iterator_to_next. Fixes cursor
6926 motion in bidi-reordered lines with stretch glyphs and strings
6927 displayed in margins. (Bug#8133) (Bug#8867)
6928 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6929 TO_CHARPOS.
640c8776
SM
6930 (pos_visible_p): Support positions in bidi-reordered lines.
6931 Save and restore bidi cache.
0bb23927
EZ
6932
6933 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6934 (bidi_paragraph_info): Delete unused struct.
6935 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6936 (bidi_cache_start): New variable.
6937 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6938 to zero.
6939 (bidi_cache_fetch_state, bidi_cache_search)
6940 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6941 (bidi_cache_find, bidi_peek_at_next_level)
6942 (bidi_level_of_next_char, bidi_find_other_level_edge)
6943 (bidi_move_to_visually_next): Compare cache index with
6944 bidi_cache_start rather than with zero.
6945 (bidi_fetch_char): Accept new argument STRING; all callers
6946 changed. Support iteration over a string. Support strings with
6947 display properties. Support unibyte strings. Fix the type of
6948 `len' according to what STRING_CHAR_AND_LENGTH expects.
6949 (bidi_paragraph_init, bidi_resolve_explicit_1)
6950 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6951 (bidi_level_of_next_char, bidi_move_to_visually_next):
6952 Support iteration over a string.
0bb23927
EZ
6953 (bidi_set_sor_type, bidi_resolve_explicit_1)
6954 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6955 can now be zero (for strings); special values 0 and -1 were
6956 changed to -1 and -2, respectively.
6957 (bidi_char_at_pos): New function.
6958 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6959 Call it instead of FETCH_MULTIBYTE_CHAR.
6960 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6961 initialized to valid values.
6962 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6963 values.
6964 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6965 the test for valid cached positions. Fix the logic for looking up
6966 the sentinel state in the cache. GCPRO the Lisp string we are
6967 iterating.
6968 (bidi_push_it, bidi_pop_it): New functions.
6969 (bidi_initialize): Initialize the bidi cache start stack pointer.
6970 (bidi_cache_ensure_space): New function, refactored from part of
6971 bidi_cache_iterator_state. Don't assume the required size is just
6972 one BIDI_CACHE_CHUNK away.
6973 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6974 (bidi_count_bytes, bidi_char_at_pos): New functions.
6975 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6976 always valid if bidi_cache_idx is valid.
6977 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6978 is valid if it's going to be used.
6979 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6980 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6981 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6982 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6983 (bidi_find_other_level_edge, bidi_cache_start_stack):
6984 All variables related to cache indices are now EMACS_INT.
c965adc5 6985
0bb23927
EZ
6986 * dispextern.h (struct bidi_string_data): New structure.
6987 (struct bidi_it): New member `string'. Make flag members be 1-bit
6988 fields, and put them last in the struct.
640c8776
SM
6989 (compute_display_string_pos, compute_display_string_end):
6990 Update prototypes.
0bb23927
EZ
6991 (bidi_push_it, bidi_pop_it): Add prototypes.
6992 (struct iterator_stack_entry): New members bidi_p,
6993 paragraph_embedding, and from_disp_prop_p.
6994 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6995 (bidi_shelve_cache, bidi_unshelve_cache):
6996 Declare prototypes.
0bb23927
EZ
6997
6998 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6999 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7000 and vector-like objects.
7001
7002 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7003 cache around display iteration.
7004
7005 * window.c (Fwindow_end, window_scroll_pixel_based)
7006 (displayed_window_lines, Frecenter): Save and restore the bidi
7007 cache around display iteration.
7008
3bbd2265
LMI
70092011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7010
7011 * editfns.c (Fdelete_region): Clarify the use of the named
7012 parameters (bug#6788).
7013
adc47434
MR
70142011-07-14 Martin Rudalics <rudalics@gmx.at>
7015
7016 * indent.c (Fvertical_motion): Set and restore w->pointm when
7017 saving and restoring the window's buffer (Bug#9006).
7018
837c31f8
LMI
70192011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7020
7021 * editfns.c (Fstring_to_char): Clarify just what is returned
7022 (bug#6576). Text by Eli Zaretskii.
7023
ac389d0c
JB
70242011-07-13 Juanma Barranquero <lekktu@gmail.com>
7025
7026 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7027
0be0ce47
EZ
70282011-07-13 Eli Zaretskii <eliz@gnu.org>
7029
7030 * buffer.c (mmap_find): Fix a typo.
7031
cd18e7e3
JB
70322011-07-13 Johan Bockgård <bojohan@gnu.org>
7033
7034 Fix execution of x selection hooks.
7035 * xselect.c (Qx_lost_selection_functions)
7036 (Qx_sent_selection_functions): New vars.
7037 (syms_of_xselect): DEFSYM them.
7038 (x_handle_selection_request): Pass Qx_sent_selection_functions
7039 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7040 (x_handle_selection_clear,x_clear_frame_selections):
7041 Pass Qx_lost_selection_functions rather than
7042 Vx_lost_selection_functions to Frun_hook_with_args.
7043
47ea7f44
PE
70442011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7045
ac389d0c 7046 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7047 The old code sometimes used this field without initializing it.
7048
47ea7f44
PE
7049 * alloc.c (gc_sweep): Don't read past end of array.
7050 In theory, the old code could also have corrupted Emacs internals,
7051 though it'd be very unlikely.
7052
bc985c87
AS
70532011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7054
7055 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7056 argument. (Bug#4026)
bc985c87 7057
0cf34688
LMI
70582011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7059
b3dadd76
LMI
7060 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7061 key" (bug#4257).
7062
0cf34688
LMI
7063 * window.c (Fset_window_start): Doc fix (bug#4199).
7064 (Fset_window_hscroll): Ditto.
7065
270768cd
PE
70662011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7067
077e3dda 7068 Fix minor new problems caught by GCC 4.6.1.
270768cd 7069 * term.c (init_tty): Remove unused local.
490011a6 7070 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7071 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7072 not used otherwise.
270768cd 7073
b1f58454
CY
70742011-07-12 Chong Yidong <cyd@stupidchicken.com>
7075
7076 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7077
22b9578d
LMI
70782011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7079
6e70ab07
LMI
7080 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7081 are the mini-buffer and the echo area (bug#3320).
7082
22b9578d
LMI
7083 * term.c (init_tty): Remove support for supdup, c10 and perq
7084 terminals, which are no longer supported (bug#1482).
7085
8974cc9f
JB
70862011-07-10 Johan Bockgård <bojohan@gnu.org>
7087
7088 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7089
a560d974
JD
70902011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7091
7092 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7093 for non-popups (Bug#3642).
7094
1dae0f0a
AS
70952011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7096
268c2c36 7097 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7098 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7099 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7100 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7101 * data.c (fmod): Likewise.
7102 * dispnew.c (swap_glyphs_in_rows): Likewise.
7103 * emacs.c (memory_warning_signal): Likewise.
7104 * floatfns.c (float_error): Likewise.
7105 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7106 (otf_open, font_otf_capability, generate_otf_features)
7107 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7108 Likewise.
7109 * image.c (pbm_read_file): Likewise.
7110 * indent.c (string_display_width): Likewise.
7111 * intervals.c (check_for_interval, search_for_interval)
7112 (inc_interval_count, count_intervals, root_interval)
7113 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7114 * lread.c (defalias): Likewise.
268c2c36 7115 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7116 * regex.c (set_image_of_range_1, set_image_of_range)
7117 (regex_grow_registers): Likewise.
7118 * sysdep.c (strerror): Likewise.
7119 * termcap.c (valid_filename_p, tprint, main): Likewise.
7120 * tparam.c (main): Likewise.
7121 * unexhp9k800.c (run_time_remap, save_data_space)
7122 (update_file_ptrs, read_header, write_header, calculate_checksum)
7123 (copy_file, copy_rest, display_header): Likewise.
7124 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7125 Likewise.
7126 * xdisp.c (check_it): Likewise.
7127 * xfaces.c (register_color, unregister_color, unregister_colors):
7128 Likewise.
7129 * xfns.c (print_fontset_result): Likewise.
7130 * xrdb.c (member, fatal, main): Likewise.
7131
99033785
PE
71322011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7133
7134 Fix minor problems found by static checking (Bug#9031).
7135 * chartab.c (char_table_set_range, map_sub_char_table):
7136 Remove unused locals.
7137 (uniprop_table): Now static.
7138 * composite.c (_work_char): Remove unused static var.
7139
9cb2ac56
JB
71402011-07-09 Juanma Barranquero <lekktu@gmail.com>
7141
7142 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7143
f25661f0
JD
71442011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7145
7146 * gtkutil.c (qttip_cb): Remove code without function.
7147
8278c4fe
EZ
71482011-07-09 Eli Zaretskii <eliz@gnu.org>
7149
7150 * w32.c (pthread_sigmask): New stub.
7151
1692ae2d 71522011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7153
8a6ebd58 7154 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7155 sigprocmask is portable only for single-threaded applications, and
7156 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7157 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7158 (LIBES): Use it.
7159 * callproc.c (Fcall_process):
7160 * process.c (create_process):
7161 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7162 Use pthread_sigmask, not sigprocmask.
123403e4 7163
1b854618
JD
71642011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7165
7166 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7167 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7168 wrong (Bug#8591).
7169
3fe4b549
JD
71702011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7171
0ce7e563
JD
7172 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7173 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7174 (xg_hide_tooltip): Fix comment.
7175
3fe4b549
JD
7176 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7177 in registerServicesMenuSendTypes.
7178 (validRequestorForSendType): Don't check ns_return_types.
7179
7180 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7181 ns_return_type.
7182
5df75e47
JR
71832011-07-08 Jason Rumney <jasonr@gnu.org>
7184
22610910
JR
7185 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7186 SH_SHOW for hidden windows (Bug#5482).
7187
5df75e47
JR
7188 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7189 frame struct members of non-existent frames (Bug#6284).
7190
699c10bd
JD
71912011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7192
4393663b
JD
7193 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7194 variable firstTime not needed on OSX >= 10.6.
7195 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7196 >= 10.5. Use setKnobProportion, setDoubleValue.
7197
7198 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7199 (MAC_OS_X_VERSION_10_5): Define if not defined.
7200 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7201 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7202 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7203
7204 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7205 cString and lossyCString on OSX >= 10.4
7206
58179cce 7207 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7208 sizeToFit on OSX >= 10.2.
7209
7210 * nsimage.m (allocInitFromFile): Don't use deprecated method
7211 bestRepresentationForDevice on OSX >= 10.6.
7212
7213 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7214 to avoid warning.
7215
7216 * emacs.c: Declare unexec_init_emacs_zone.
7217
a63e0781
JD
7218 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7219
699c10bd
JD
7220 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7221
7222 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7223 on svcsMenu (Bug#8842).
7224
7225 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7226 ns_return_types.
7227 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7228
7229 * nsterm.m (QUTF8_STRING): Declare.
7230 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7231 (validRequestorForSendType): Return type is (id).
7232 Change indexOfObjectIdenticalTo to indexOfObject.
7233 Check if we have local selection before returning self (Bug#8842).
7234 (writeSelectionToPasteboard): Put local selection into paste board
7235 if we have a local selection (Bug#8842).
7236 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7237
7238 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7239 (ns_get_local_selection): Declare.
7240
54e10184
LMI
72412011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7242
9888ff71
LMI
7243 * keymap.c (describe_map_tree): Don't insert a double newline at
7244 the end of the buffer (bug#1169) and return whether we inserted
7245 something.
7246
54e10184
LMI
7247 * callint.c (Fcall_interactively): Change "reading args" to
7248 "providing args" to try to clarify what it does (bug#1010).
7249
15fa4783
KH
72502011-07-07 Kenichi Handa <handa@m17n.org>
7251
7252 * composite.c (composition_compute_stop_pos): Ignore a static
7253 composition starting before CHARPOS (Bug#8915).
7254
7255 * xdisp.c (handle_composition_prop): Likewise.
7256
a8815b00
EZ
72572011-07-07 Eli Zaretskii <eliz@gnu.org>
7258
7259 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7260 (Bug#9015)
7261
ef7b981d 72622011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7263
7264 * character.h (unicode_category_t): New enum type.
7265
7266 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7267 (Qchar_code_property_table): New variable.
7268 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7269 (UNIPROP_COMPRESSED_FORM_P): New macros.
7270 (char_table_ascii): Uncompress the compressed values.
7271 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7272 Uncompress the compressed values.
ac389d0c 7273 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7274 (char_table_ref_and_range): Uncompress the compressed values.
7275 (sub_char_table_set): New arg is_uniprop. Callers changed.
7276 Uncompress the compressed values.
7277 (sub_char_table_set_range): Args changed. Callers changed.
7278 (char_table_set_range): Adjuted for the above change.
7279 (map_sub_char_table): Delete args default_val and parent. Add arg
7280 top. Give decoded values to a Lisp function.
640c8776 7281 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7282 values to a Lisp function. Gcpro more variables.
7283 (uniprop_table_uncompress)
7284 (uniprop_decode_value_run_length): New functions.
7285 (uniprop_decoder, uniprop_decoder_count): New variables.
7286 (uniprop_get_decoder, uniprop_encode_value_character)
7287 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7288 New functions.
7289 (uniprop_encoder, uniprop_encoder_count): New variables.
7290 (uniprop_get_encoder, uniprop_table)
7291 (Funicode_property_table_internal, Fget_unicode_property_internal)
7292 (Fput_unicode_property_internal): New functions.
7293 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7294 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7295 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7296 char-code-property-alist.
7297
640c8776 7298 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7299 Vunicode_category_table.
7300
640c8776 7301 * font.c (font_range): Adjust for the change of
c805dec0
KH
7302 Vunicode_category_table.
7303
76b397fb
DN
73042011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7305
7306 * m/iris4d.h: Remove file, move contents ...
7307 * s/irix6-5.h: ... here.
7308
22b4128e
PE
73092011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7310
7311 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7312 * alloc.c (mark_buffer):
7313 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7314 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7315 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7316 This isn't true in general, and it's particularly not true
7317 if Emacs is configured with --with-wide-int.
7318 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7319 New macros, used in the buffer.c change.
7320
869795d6
JD
73212011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7322
7323 * xsettings.c: Use both GConf and GSettings if both are available.
7324 (store_config_changed_event): Add comment.
7325 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7326 (store_tool_bar_style_changed): New functions.
5e617bc2 7327 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7328 (struct xsettings): Move font inside HAVE_XFT.
7329 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7330 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7331 Move inside HAVE_XFT.
640c8776 7332 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7333 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7334 also.
7335 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7336 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7337 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7338 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7339 (parse_settings): Move check for font inside HAVE_XFT.
7340 (read_settings, apply_xft_settings): Add comment.
7341 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7342 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7343 call store_font_name_changed.
7344 (xft_settings_event): Add comment.
7345 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7346 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7347 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7348 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7349 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7350 (xsettings_get_system_font, xsettings_get_system_normal_font):
7351 Add comment.
869795d6 7352
d8ed26bd
PE
73532011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7354
7355 Random fixes. E.g., (random) never returned negative values.
7356 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7357 subseconds part to the entropy, as that's a bit more random.
7358 Prefer signed to unsigned, since the signedness doesn't matter and
7359 in general we prefer signed. When given a limit, use a
7360 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7361 latter isn't right if USE_2_TAGS_FOR_INTS.
7362 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7363 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7364
cabf1cac
SM
73652011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7366
7367 * textprop.c (text_property_stickiness):
7368 Obey Vtext_property_default_nonsticky.
7369 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7370 * w32fns.c (syms_of_w32fns):
7371 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7372
6e9b2be9
PE
73732011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7374
7375 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7376 This is more efficient than Ffile_directory_p and avoids a minor race.
7377
90186c68
LMI
73782011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7379
7c301272
LMI
7380 * buffer.c (Foverlay_put): Say what the return value is
7381 (bug#7835).
7382
c4f2d8d4
LMI
7383 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7384 is a directory before asking whether to use the file name
7385 (bug#7564).
ad637907
LMI
7386 (barf_or_query_if_file_exists): Make the "File is a directory"
7387 error be more correct.
c4f2d8d4 7388
90186c68
LMI
7389 * fns.c (Frequire): Remove the mention of the .gz files, since
7390 that's installation-specific, but keep the mention of
7391 `get-load-suffixes'.
7392
da64016e
PE
73932011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7394
7395 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7396 Report string overflow if the output is too long.
7397
7d47b580
JB
73982011-07-04 Juanma Barranquero <lekktu@gmail.com>
7399
a555cb87
JB
7400 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7401 (syms_of_gnutls): Remove duplicate DEFSYM for
7402 Qgnutls_bootprop_verify_hostname_error, an error for
7403 Qgnutls_bootprop_verify_error (which is no longer used).
7404
7d47b580
JB
7405 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7406 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7407 Also (re)move comments that are misplaced or no longer relevant.
7408
1e49bfab
LMI
74092011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7410
7411 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7412
1485f4c0
CY
74132011-07-03 Chong Yidong <cyd@stupidchicken.com>
7414
7415 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7416 and background color parameters if they have been changed.
7417
a9ab721e
LMI
74182011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7419
7420 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7421
cf7cff57
PE
74222011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7423
2e13213d
PE
7424 * xsettings.c (SYSTEM_FONT): Define only when used.
7425 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7426
cf7cff57
PE
7427 * keymap.c (access_keymap_1): Now static.
7428
7a8e04f7
CY
74292011-07-02 Chong Yidong <cyd@stupidchicken.com>
7430
7431 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7432 leave any prefix arg for the up event (Bug#1586).
7433
61352f62
LMI
74342011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7435
69bb1ef7
LMI
7436 * lread.c (syms_of_lread): Mention single symbols defined by
7437 `defvar' or `defconst' (bug#7154).
7438
61352f62 7439 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7440 (Frequire): Mention get-load-suffixes.
61352f62 7441
28545e04
MR
74422011-07-02 Martin Rudalics <rudalics@gmx.at>
7443
7444 * window.h (window): Remove clone_number slot.
7445 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7446 Remove.
7447 (make_parent_window, make_window, saved_window)
7448 (Fset_window_configuration, save_window_save): Don't deal with
7449 clone numbers.
7450 * buffer.c (Qclone_number): Remove declaration.
7451 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7452
3349e122
SM
74532011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7454
7455 Add multiple inheritance to keymaps.
7456 * keymap.c (Fmake_composed_keymap): New function.
7457 (Fset_keymap_parent): Simplify.
7458 (fix_submap_inheritance): Remove.
7459 (access_keymap_1): New function extracted from access_keymap to handle
7460 embedded parents and handle lists of maps.
7461 (access_keymap): Use it.
7462 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7463 (Fcopy_keymap): Handle embedded parents.
7464 (Fcommand_remapping, define_as_prefix): Simplify.
7465 (Fkey_binding): Simplify.
7466 (syms_of_keymap): Move minibuffer-local-completion-map,
7467 minibuffer-local-filename-completion-map,
7468 minibuffer-local-must-match-map, and
7469 minibuffer-local-filename-must-match-map to Elisp.
7470 (syms_of_keymap): Defsubr make-composed-keymap.
7471 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7472 (parse_menu_item): Trivial simplification.
7473
3279eb87
GM
74742011-07-01 Glenn Morris <rgm@gnu.org>
7475
7476 * Makefile.in (SETTINGS_LIBS): Fix typo.
7477
4550efdf
KI
74782011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7479
7480 * coding.c (Fencode_coding_string): Record the last coding system
7481 used, as the function doc string says (bug#8738).
7482
0949d2b6
JD
74832011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7484
7485 * xsettings.c (store_monospaced_changed): Take new font as arg and
7486 check for change against current_mono_font.
7487 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7488 (emacs_settings_constructor, emacs_settings_get_property)
7489 (emacs_settings_set_property, emacs_settings_class_init)
7490 (emacs_settings_init, gsettings_obj): Remove.
7491 (something_changedCB): New function for HAVE_GSETTINGS.
7492 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7493 with value as argument.
7494 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7495 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7496 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7497 "changed".
7498
7499 * xgselect.c: Add defined (HAVE_GSETTINGS).
7500 (xgselect_initialize): Ditto.
7501
7502 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7503 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7504 xg_select.
7505
bbc6b304
PE
75062011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7507
7508 * eval.c (struct backtrace): Simplify and port the data structure.
7509 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7510 signed bit field, as this assumption is not portable and it makes
7511 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7512 "char debug_on_exit : 1" as this is not portable either; instead,
7513 use the portable "unsigned int debug_on_exit : 1". Remove unused
7514 member evalargs. Remove obsolete comments about cc bombing out.
7515
9851bfc5
JD
75162011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7517
51bb811f 7518 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7519 Let HAVE_GSETTINGS override HAVE_GCONF.
7520 (store_monospaced_changed): New function.
7521 (EMACS_SETTINGS): A new type derived from GObject to handle
7522 GSettings notifications.
7523 (emacs_settings_constructor, emacs_settings_get_property)
7524 (emacs_settings_set_property, emacs_settings_class_init):
7525 New functions.
7526 (gsettings_client, gsettings_obj): New variables.
7527 (GSETTINGS_SCHEMA): New define.
7528 (something_changedCB): Call store_monospaced_changed.
7529 (init_gsettings): New function.
7530 (xsettings_initialize): Call init_gsettings.
7531 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7532 to NULL.
7533
640c8776 7534 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7535 GCONF_CFLAGS/LIBS.
7536
5386012d
MR
75372011-06-29 Martin Rudalics <rudalics@gmx.at>
7538
7539 * window.c (resize_root_window, grow_mini_window)
7540 (shrink_mini_window): Rename Qresize_root_window to
7541 Qwindow_resize_root_window and Qresize_root_window_vertically to
7542 Qwindow_resize_root_window_vertically.
7543
f13e0b08
PE
75442011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7545
7546 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7547
94515237
JB
75482011-06-27 Juanma Barranquero <lekktu@gmail.com>
7549
7550 * makefile.w32-in: Redesign dependencies so they reflect more
7551 clearly which files are directly included by each source file,
7552 and not through other includes.
7553
e43b6e43
MR
75542011-06-27 Martin Rudalics <rudalics@gmx.at>
7555
7556 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7557 (sort_overlays, overlay_strings): When an overlay's clone number
7558 matches the window's clone number process the overlay even if
7559 the overlay's window property doesn't match the current window.
7560
d68443dc
MR
7561 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7562 (Fwindow_hchild): Rename to Fwindow_left_child.
7563 (Fwindow_next): Rename to Fwindow_next_sibling.
7564 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7565 (resize_window_check): Rename to window_resize_check.
7566 (resize_window_apply): Rename to window_resize_apply.
7567 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7568 (Fdelete_other_windows_internal, resize_frame_windows)
7569 (Fsplit_window_internal, Fdelete_window_internal)
7570 (grow_mini_window, shrink_mini_window)
7571 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7572
c7e73be5
JD
75732011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7574
7575 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7576 (emacs_fixed_set_min_size): Remove.
7577 (emacs_fixed_new): Take frame as argument.
7578
7579 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7580 (_EmacsFixedPrivate): Remove minwidth/height.
7581 Add struct frame *f.
7582 (emacs_fixed_init): Initialize priv->f.
7583 (get_parent_class, emacs_fixed_set_min_size): Remove.
7584 (emacs_fixed_new): Set priv->f to argument.
7585 (emacs_fixed_get_preferred_width)
7586 (emacs_fixed_get_preferred_height): Use min_width/height from
7587 frames size_hint to set minimum and natural (Bug#8919).
7588 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7589 and use min_width/height from frames size_hint to set
7590 min_width/height (Bug#8919).
7591
7592 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7593 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7594 Fix indentation.
c7e73be5 7595
cf99dcf8
EZ
75962011-06-26 Eli Zaretskii <eliz@gnu.org>
7597
7598 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7599 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7600 called at ZV.
7601
029529ac
CY
76022011-06-26 Chong Yidong <cyd@stupidchicken.com>
7603
7604 * process.c (wait_reading_process_output): Bypass select if
7605 waiting for a cell while ignoring keyboard input, and input is
7606 pending. Suggested by Jan Djärv (Bug#8869).
7607
7a7ef429
PE
76082011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7609
7610 Use gnulib's dup2 module instead of rolling our own.
7611 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7612
11fdef7d 76132011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7614
7615 * dispnew.c (scrolling_window): Before scrolling, turn off a
7616 mouse-highlight in the window being scrolled.
7617
cd3520a4
JB
76182011-06-24 Juanma Barranquero <lekktu@gmail.com>
7619
7620 Move DEFSYM to lisp.h and use everywhere.
7621
7622 * character.h (DEFSYM): Move declaration...
7623 * lisp.h (DEFSYM): ...here.
7624
7625 * gnutls.c:
7626 * minibuf.c:
7627 * w32menu.c:
7628 * w32proc.c:
7629 * w32select.c: Don't include character.h.
7630
7631 * alloc.c (syms_of_alloc):
7632 * buffer.c (syms_of_buffer):
7633 * bytecode.c (syms_of_bytecode):
7634 * callint.c (syms_of_callint):
7635 * casefiddle.c (syms_of_casefiddle):
7636 * casetab.c (init_casetab_once):
7637 * category.c (init_category_once, syms_of_category):
7638 * ccl.c (syms_of_ccl):
7639 * cmds.c (syms_of_cmds):
7640 * composite.c (syms_of_composite):
7641 * dbusbind.c (syms_of_dbusbind):
7642 * dired.c (syms_of_dired):
7643 * dispnew.c (syms_of_display):
7644 * doc.c (syms_of_doc):
7645 * editfns.c (syms_of_editfns):
7646 * emacs.c (syms_of_emacs):
7647 * eval.c (syms_of_eval):
7648 * fileio.c (syms_of_fileio):
7649 * fns.c (syms_of_fns):
7650 * frame.c (syms_of_frame):
7651 * fringe.c (syms_of_fringe):
7652 * insdel.c (syms_of_insdel):
7653 * keymap.c (syms_of_keymap):
7654 * lread.c (init_obarray, syms_of_lread):
7655 * macros.c (syms_of_macros):
7656 * msdos.c (syms_of_msdos):
7657 * print.c (syms_of_print):
7658 * process.c (syms_of_process):
7659 * search.c (syms_of_search):
7660 * sound.c (syms_of_sound):
7661 * syntax.c (init_syntax_once, syms_of_syntax):
7662 * terminal.c (syms_of_terminal):
7663 * textprop.c (syms_of_textprop):
7664 * undo.c (syms_of_undo):
7665 * w32.c (globals_of_w32):
7666 * window.c (syms_of_window):
7667 * xdisp.c (syms_of_xdisp):
7668 * xfaces.c (syms_of_xfaces):
7669 * xfns.c (syms_of_xfns):
7670 * xmenu.c (syms_of_xmenu):
7671 * xsettings.c (syms_of_xsettings):
7672 * xterm.c (syms_of_xterm): Use DEFSYM.
7673
4228cf16
TZ
76742011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7675
cd3520a4 7676 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7677
7fcccf1e
PE
76782011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7679
7efb4e0e
PE
7680 Integer and buffer overflow fixes (Bug#8873).
7681
ff5844ad
PE
7682 * print.c (printchar, strout): Check for string overflow.
7683 (PRINTPREPARE, printchar, strout):
7684 Don't set size unless allocation succeeds.
7685
90532f02
PE
7686 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7687 for sizes. Check for string overflow more accurately.
7688 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7689
6d84508d
PE
7690 * macros.c: Integer and buffer overflow fixes.
7691 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7692 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7693 Use ptrdiff_t, not int, for sizes.
7694 Don't increment bufsize until after realloc succeeds.
7695 Check for size-calculation overflow.
7696 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7697
437b2cb4
PE
7698 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7699
8b9ac8b4
PE
7700 * lread.c: Integer overflow fixes.
7701 (read_integer): Radix is now EMACS_INT, not int,
7702 to improve quality of diagnostics for out-of-range radices.
7703 Calculate buffer size correctly for out-of-range radices.
7704 (read1): Check for integer overflow in radices, and in
7705 read-circle numbers.
82cb60d3
PE
7706 (read_escape): Avoid int overflow.
7707 (Fload, openp, read_buffer_size, read1)
7708 (substitute_object_recurse, read_vector, read_list, map_obarray):
7709 Use ptrdiff_t, not int, for sizes.
7710 (read1): Use EMACS_INT, not int, for sizes.
20270765 7711 Check for size overflow.
8b9ac8b4 7712
7fcccf1e
PE
7713 * image.c (cache_image): Check for size arithmetic overflow.
7714
bfbbd7e7
PE
7715 * lread.c: Integer overflow issues.
7716 (saved_doc_string_size, saved_doc_string_length)
7717 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7718 Now ptrdiff_t, not int.
7719 (read1): Don't assume doc string length fits in int. Check for
7720 out-of-range doc string lengths.
7721 (read_list): Don't assume file position fits in int.
39019e54 7722 (read_escape): Check for hex character overflow.
bfbbd7e7 7723
4e323265
LL
77242011-06-22 Leo Liu <sdl.web@gmail.com>
7725
7726 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7727 Move to minibuffer.el.
7728
85fece3e
PE
77292011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7730
20b84ce9 7731 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7732 The following patches are for when GLYPH_DEBUG && !XASSERT.
7733 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7734 * dispnew.c (flush_stdout):
7735 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7736 Mark as externally visible.
7737 * dispnew.c (check_window_matrix_pointers): Now static.
7738 * dispnew.c (window_to_frame_vpos):
7739 * xfns.c (unwind_create_frame):
7740 * xterm.c (x_check_font): Remove unused local.
7741 * scroll.c (CHECK_BOUNDS):
7742 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7743 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7744 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7745 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7746 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7747 Now static.
7748 (debug_method_add): Use va_list and vsprintf rather than relying
7749 on undefined behavior with wrong number of arguments.
7750 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7751 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7752 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7753 since we're not interested in debugging glyphs with old libraries.
7754 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7755 GCC 4.6.0's static checking.
7756
0766b489
PE
77572011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7758
31fd4b32
PE
7759 Integer overflow and signedness fixes (Bug#8873).
7760 A few related buffer overrun fixes, too.
7761
b79e8648
PE
7762 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7763
0766b489
PE
7764 * dispextern.h (struct face.stipple):
7765 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7766 (x_bitmap_mask, x_allocate_bitmap_record)
7767 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7768 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7769 (x_create_bitmap_from_xpm_data):
7770 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7771 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7772 (.bitmaps_last):
7773 * xfaces.c (load_pixmap):
7774 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7775 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7776 (.bitmaps_last, struct x_output.icon_bitmap):
7777 Use ptrdiff_t, not int, for bitmap indexes.
7778 (x_allocate_bitmap_record): Check for size overflow.
7779 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7780
b081724f
PE
7781 Use ptrdiff_t, not int, for overlay counts.
7782 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7783 * editfns.c (overlays_around, get_pos_property):
7784 * textprop.c (get_char_property_and_overlay):
7785 * xdisp.c (next_overlay_change, note_mouse_highlight):
7786 * xfaces.c (face_at_buffer_position):
21514da7
PE
7787 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7788 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7789 (Fnext_overlay_change, Fprevious_overlay_change)
7790 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7791 Use ptrdiff_t, not int, for sizes.
21514da7 7792 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7793
3de73e5e
PE
7794 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7795
2606c57b
PE
7796 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7797 (x_session_initialize): Do not assume string length fits in int.
7798
aaafe47a
PE
7799 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7800 This is unlikely, but can occur if DPI is outlandish.
7801
2674ddc8 7802 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7803 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7804
28154962
PE
7805 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7806 * xrdb.c (magic_file_p, search_magic_path):
7807 Omit last arg SUFFIX; it was always 0. All callers changed.
7808 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7809
7de51af5
PE
7810 * xfont.c (xfont_match): Avoid need for strlen.
7811
25ed6cc3
PE
7812 * xfns.c: Don't assume strlen fits in int.
7813 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7814
4eab31dd
PE
7815 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7816 not unsigned long, as we prefer signed integers. All callers changed.
7817 Detect integer overflow in repeat count.
7818 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7819 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7820
171e2a58
PE
7821 * termcap.c: Don't assume sizes fit in int and never overflow.
7822 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7823 (gobble_line): Check for size-calculation overflow.
7824
ad39faca 7825 * minibuf.c (Fread_buffer):
6e5bb2dc 7826 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7827 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7828 Don't assume string length fits in int.
7829
52c61c22 7830 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7831 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7832
b5b8c9e5
PE
7833 * font.c: Don't assume string length fits in int.
7834 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7835 Use ptrdiff_t, not int.
ccd6111c
PE
7836 (font_intern_prop): Don't assume string length fits in int.
7837 Don't assume integer property fits in fixnum.
7838 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7839
882f0d81 7840 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7841 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7842 Reformulate so as not to need the command string.
7843 Invoke gzip -cd rather than gunzip, as it's more portable.
7844 (lock_info_type, lock_file_1, lock_file):
7845 Don't assume pid_t and time_t fit in unsigned long.
7846 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7847 (current_lock_owner): Prefer signed type for sizes.
7848 Use memcpy, not strncpy, where memcpy is what is really wanted.
7849 Don't assume (via atoi) that time_t and pid_t fit in int.
7850 Check for time_t and/or pid_t out of range, e.g., via a network share.
7851 Don't alloca where an auto var works fine.
7852
93f4cf88
PE
7853 * fileio.c: Fix some integer overflow issues.
7854 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7855 Don't assume string length fits in int.
7856 (directory_file_name): Don't assume string length fits in long.
7857 (make_temp_name): Don't assume pid fits in int, or that its print
7858 length is less than 20.
7859
f3e92b69
PE
7860 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7861
1bfdaf10
PE
7862 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7863
35016e9a
PE
7864 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7865
3d1e65a1
PE
7866 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7867 We prefer signed integers, even for size calculations.
7868
0b963a93
PE
7869 * emacs.c: Don't assume string length fits in 'int'.
7870 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7871 (main): Don't invoke strlen when not needed.
7872
573f4b54
PE
7873 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7874 (XD_DEBUG_MESSAGE): Don't waste a byte.
7875
989f33ba
PE
7876 * callproc.c (getenv_internal_1, getenv_internal)
7877 (Fgetenv_internal):
965d34eb
PE
7878 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7879
e4d29b33
PE
7880 * lread.c (invalid_syntax): Omit length argument.
7881 All uses changed. This doesn't fix a bug, but it simplifies the
7882 code away from its former Hollerith-constant appearance, and it's
7883 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7884 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7885
eb49b136
PE
7886 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7887 This didn't break anything, but it didn't help either.
7888 It's confusing to put a bogus integer in a place where the actual
7889 value does not matter.
9f62aeb1 7890 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7891 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7892
15375a22
PE
7893 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7894 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7895 implementation.
b61cc01c
PE
7896 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7897 We prefer signed types, and the value cannot exceed the EMACS_INT
7898 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7899 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7900 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7901 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7902
53b2623d
PE
7903 * indent.c (sane_tab_width): New function.
7904 (current_column, scan_for_column, Findent_to, position_indentation)
7905 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7906 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7907
51cab52b 7908 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7909
f2ed8a70
PE
7910 * lisp.h (lint_assume): New macro.
7911 * composite.c (composition_gstring_put_cache):
7912 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7913
abe80cc6
PE
7914 * editfns.c, insdel.c:
7915 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7916
b02c740e
PE
7917 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7918
ebc96716
PE
7919 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7920
b4e50fa0 7921 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7922 Use much-faster test for byte-length change.
311d5d7c 7923 Don't assume string byte-length fits in 'int'.
a4cf38e4 7924 Check that character arg fits in 'int'.
85461888 7925 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7926
c0c1ee9f
PE
7927 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7928
a498d7f4
PE
7929 * fns.c (concat): Catch string overflow earlier.
7930 Do not rely on integer wraparound.
7931
51cab52b
PE
7932 * dispextern.h (struct it.overlay_strings_charpos)
7933 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7934 * xdisp.c (forward_to_next_line_start)
7935 (back_to_previous_visible_line_start)
7936 (reseat_at_next_visible_line_start, next_element_from_buffer):
7937 Don't arbitrarily truncate the value of 'selective' to int.
7938
76031fad
PE
7939 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7940
5eb55db9
PE
7941 * composite.c: Don't truncate sizes to 'int'.
7942 (composition_gstring_p, composition_reseat_it)
7943 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7944 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7945 not EMACS_UINT, for indexes.
5eb55db9 7946
0703a717
PE
7947 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7948
d6202519
PE
7949 * buffer.c: Include <verify.h>.
7950 (struct sortvec.priority, struct sortstr.priority):
8961a454 7951 Now EMACS_INT, not int.
c20998a7 7952 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7953 (struct sortstr.size, record_overlay_string)
7954 (struct sortstrlist.size, struct sortlist.used):
7955 Don't truncate size to int.
7956 (record_overlay_string): Check for size-calculation overflow.
d6202519 7957 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7958
d5a19415
JM
79592011-06-22 Jim Meyering <meyering@redhat.com>
7960
029529ac 7961 Don't leak an XBM-image-sized buffer
d5a19415
JM
7962 * image.c (xbm_load): Free the image buffer after using it.
7963
a9041e6c
PE
79642011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7965
7966 Port to Sun C.
7967 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7968 that Sun C diagnosed.
7969 * fns.c (secure_hash): Fix pointer signedness issue.
7970 * intervals.c (static_offset_intervals): New function.
7971 (offset_intervals): Use it.
7972
7f3f739f
LL
79732011-06-21 Leo Liu <sdl.web@gmail.com>
7974
7975 * deps.mk (fns.o):
7976 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7977 sha512.h.
7978
7979 * fns.c (secure_hash): Rename from crypto_hash_function and change
7980 the first arg to accept symbols.
5b66d427 7981 (Fsecure_hash): New primitive.
7f3f739f
LL
7982 (syms_of_fns): New symbols.
7983
76147d94
DD
79842011-06-20 Deniz Dogan <deniz@dogan.se>
7985
7986 * process.c (Fset_process_buffer): Clarify return value in
7987 docstring.
7988
7d7d0045
CY
79892011-06-18 Chong Yidong <cyd@stupidchicken.com>
7990
7991 * dispnew.c (add_window_display_history): Use BVAR.
7992
7993 * xdisp.c (debug_method_add): Use BVAR.
7994 (check_window_end, dump_glyph_matrix, dump_glyph)
7995 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7996
7997 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7998 Likewise.
7999
8000 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8001 check till after the cache is created in init_frame_faces.
8002
ff2bc410
SM
80032011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8004
8005 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8006
28177add
PE
80072011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8008
dd3482fe
PE
8009 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8010 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8011 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8012
393d71f3 8013 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8014 * fileio.c (Finsert_file_contents):
8015 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8016 Remove the old (too-loose) buffer overflow checks.
8017 They weren't needed, since make_gap checks for buffer overflow.
8018 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8019 The old code merely checked for Emacs fixnum overflow, and relied
8020 on undefined (wraparound) behavior. The new code avoids undefined
8021 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8022
2e6813b0 8023 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8024 Tune. Don't use wider integers than needed. Don't use alloca.
8025 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8026
599a9e4f
PE
8027 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8028
99561444
PE
8029 * insdel.c, lisp.h (buffer_overflow): New function.
8030 (insert_from_buffer_1, replace_range, replace_range_2):
8031 * insdel.c (make_gap_larger):
8032 * editfns.c (Finsert_char):
8033 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8034
28177add
PE
8035 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8036
e69dafad
PE
80372011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8038
4baa020d 8039 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8040
b1c46f02
PE
8041 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8042 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8043
e69dafad
PE
8044 * fileio.c: Don't assume EMACS_INT fits in off_t.
8045 (emacs_lseek): New static function.
8046 (Finsert_file_contents, Fwrite_region): Use it.
8047 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8048
566684ea
PE
8049 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8050
e6966cd6
PE
8051 * fns.c: Don't overflow int when computing a list length.
8052 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8053 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8054 truncation on 64-bit hosts. Check for QUIT every
8055 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8056 faster and is responsive enough.
8057 (Flength): Report an error instead of overflowing an integer.
8058 (Fsafe_length): Return a float if the value is not representable
8059 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8060 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8061 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8062
dd0b0efb
PE
8063 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8064 (header_size, word_size): New constants.
8065 (allocate_vectorlike): Don't check size overflow here.
8066 (allocate_vector): Check it here instead, since this is the only
8067 caller of allocate_vectorlike that could cause overflow.
8068 Check that the new vector's length is representable as a fixnum.
8069
86fe5cfe
PE
8070 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8071 The previous code was bogus. For example, next_almost_prime (32)
8072 returned 39, which is undesirable as it is a multiple of 3; and
8073 next_almost_prime (24) returned 25, which is a multiple of 5 so
8074 why was the code bothering to check for multiples of 7?
8075
80e88859
PE
8076 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8077
4a2f0ad6
PE
8078 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8079
f66c7cf8
PE
8080 Variadic C functions now count arguments with ptrdiff_t.
8081 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8082 Back then I didn't know that the Emacs coding style prefers signed int.
8083 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8084 were being counted with int, which may truncate counts on 64-bit
8085 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8086 * lisp.h (struct Lisp_Subr.function.aMANY)
8087 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8088 Arg counts are now ptrdiff_t, not size_t.
8089 All variadic functions and their callers changed accordingly.
8090 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8091 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8092 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8093 * callint.c (Fcall_interactively): Check arg count for overflow,
8094 to avoid potential buffer overrun. Use signed char, not 'int',
8095 for 'varies' array, so that we needn't bother to check its size
8096 calculation for overflow.
8097 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8098 * eval.c (apply_lambda):
8099 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8100 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8101 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8102
a1759b76
PE
8103 * callint.c (Fcall_interactively): Don't use index var as event count.
8104
d96be9fc
PE
8105 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8106 * mem-limits.h (SIZE): Remove; no longer used.
8107
a690a978 8108 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8109
578c21e6
PE
8110 Remove unnecessary casts.
8111 * xterm.c (x_term_init):
8112 * xfns.c (x_set_border_pixel):
8113 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8114 These aren't needed now that we assume ANSI C.
8115
96f53c6c
PE
8116 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8117 It's more likely to cause problems (due to unsigned overflow)
8118 than to cure them.
8119
83c77d31
PE
8120 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8121
ee2079f1
PE
8122 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8123
6da65536
PE
8124 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8125
7147c4a4
PE
8126 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8127
193e32d9
PE
8128 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8129
e5533da6
PE
8130 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8131
9910e595
PE
8132 GLYPH_CODE_FACE returns EMACS_INT, not int.
8133 * dispextern.h (merge_faces):
8134 * xfaces.c (merge_faces):
01103c44
PE
8135 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8136 Don't assume EMACS_INT fits in int.
9910e595 8137
2638320e
PE
8138 * character.h (CHAR_VALID_P): Remove unused parameter.
8139 * fontset.c, lisp.h, xdisp.c: All uses changed.
8140
045eb8d9
PE
8141 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8142
c1f134b5
PE
8143 * fns.c (concat): Minor tuning based on overflow analysis.
8144 This doesn't fix any bugs. Use int to hold character, instead
8145 of constantly refetching from Emacs object. Use XFASTINT, not
8146 XINT, for value known to be a character. Don't bother comparing
8147 a single byte to 0400, as it's always less.
8148
395fcb93 8149 * floatfns.c (Fexpt):
327eeec8
PE
8150 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8151
abbd3d23
PE
8152 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8153 for characters.
8154
684a03ef
PE
8155 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8156
0fed43f3
PE
8157 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8158 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8159 incorrectly succeed when S was a string, because 4294967386 was
8160 truncated before it was used.
8161
8fd02eb7
PE
8162 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8163 Otherwise, an out-of-range integer could cause undefined behavior
8164 on a 64-bit host.
8165
f8c86b69
PE
8166 * composite.c: Use int, not EMACS_INT, for characters.
8167 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8168 EMACS_INT, for values that are known to be in character range.
8169 This doesn't fix any bugs but is the usual style inside Emacs and
8170 may generate better code on 32-bit machines.
8171
34206dd2
PE
8172 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8173 This is for reasons similar to the recent CHAR_STRING fix.
8174 * charset.c (Fencode_char): Check that character arg is actually
8175 a character. Pass an int to ENCODE_CHAR.
8176 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8177 wider than 'int', as a compile-time check to prevent future regressions
8178 in this area.
8179
c5958d4c 8180 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8181
8182 Make sure a 64-bit char is never passed to CHAR_STRING.
8183 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8184 by silently ignoring the top 32 bits, allowing some values
8185 that were far too large to be valid characters.
8186 * character.h: Include <verify.h>.
8187 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8188 arguments are no wider than unsigned, as a compile-time check
8189 to prevent future regressions in this area.
8190 * data.c (Faset):
01103c44 8191 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8192 (Fsubst_char_in_region):
8193 * fns.c (concat):
8194 * xdisp.c (decode_mode_spec_coding):
8195 Adjust to CHAR_STRING's new requirement.
8196 * editfns.c (Finsert_char, Fsubst_char_in_region):
8197 * fns.c (concat): Check that character args are actually
8198 characters. Without this test, these functions did the wrong
8199 thing with wildly out-of-range values on 64-bit hosts.
8200
d37ca623
PE
8201 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8202 These casts should not be needed on 32-bit hosts, either.
8203 * keyboard.c (read_char):
8204 * lread.c (Fload): Remove casts to unsigned.
8205
ea204efb
PE
8206 * lisp.h (UNSIGNED_CMP): New macro.
8207 This fixes comparison bugs on 64-bit hosts.
8208 (ASCII_CHAR_P): Use it.
8209 * casefiddle.c (casify_object):
01103c44 8210 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8211 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8212 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8213 * dispextern.h (FACE_FROM_ID):
8214 * keyboard.c (read_char): Use UNSIGNED_CMP.
8215
41cb286c
PE
8216 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8217 not to EMACS_INT, to avoid GCC warning.
8218
4a1b9832
PE
8219 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8220
55daad71
PE
8221 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8222 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8223 isn't needed on 32-bit machines.
8f95c75c 8224
01103c44
PE
8225 * buffer.c (Fgenerate_new_buffer_name):
8226 Use EMACS_INT for count, not int.
0ceccced 8227 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8228
8229 * data.c (Qcompiled_function): Now static.
8230
c6f072e7
PE
8231 * window.c (window_body_lines): Now static.
8232
20ce5912
PE
8233 * image.c (gif_load): Rename local to avoid shadowing.
8234
9c4c5f81
PE
8235 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8236 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8237 * alloc.c (make_save_value): Integer argument is now of type
8238 ptrdiff_t, not int.
8239 (mark_object): Use ptrdiff_t, not int.
8240 * lisp.h (pD): New macro.
8241 * print.c (print_object): Use it.
8242
c0c5c8ae
PE
8243 * alloc.c: Use EMACS_INT, not int, to count objects.
8244 (total_conses, total_markers, total_symbols, total_vector_size)
8245 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8246 (total_free_floats, total_floats, total_free_intervals)
8247 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8248 Now EMACS_INT, not int. All uses changed.
8249 (Fgarbage_collect): Compute overall total using a double, so that
8250 integer overflow is less likely to be a problem. Check for overflow
8251 when converting back to an integer.
5a25e253
PE
8252 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8253 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8254 These were 'int' variables that could overflow on 64-bit hosts;
8255 they were never used, so remove them instead of repairing them.
211a0b2a 8256 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8257 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8258 Previously, this ceilinged at INT_MAX, but that doesn't work on
8259 64-bit machines.
e46bb31a 8260 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8261
c78baabf 8262 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8263 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8264 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8265 when a (possibly-narrower) signed value would do just as well.
8266 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8267
c9d624c6
PE
8268 * alloc.c: Catch some string size overflows that we were missing.
8269 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8270 for convenience in STRING_BYTES_MAX.
8271 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8272 The definition here is exact; the one in lisp.h was approximate.
8273 (allocate_string_data): Check for string overflow. This catches
8274 some instances we weren't catching before. Also, it catches
8275 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8276 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8277 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8278
c9d624c6
PE
8279 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8280 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8281 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8282
353032ce
PE
8283 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8284
2bccce07
PE
8285 * alloc.c (Fmake_string): Check for out-of-range init.
8286
0ac30604
SM
82872011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8288
8289 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8290
c195f2de
JD
82912011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8292
8293 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8294 xg_get_default_scrollbar_width.
8295
8296 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8297 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8298 (style_changed_cb): Call update_theme_scrollbar_width and call
8299 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8300 all frames (Bug#8505).
8301 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8302 Call gtk_window_set_resizable if HAVE_GTK3.
8303 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8304 and height if HAVE_GTK3 (Bug#8505).
8305 (scroll_bar_width_for_theme): New variable.
8306 (update_theme_scrollbar_width): New function.
8307 (xg_get_default_scrollbar_width): Move code to
8308 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8309 (xg_initialize): Call update_theme_scrollbar_width.
8310
8311 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8312
8313 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8314
e10ac9f1
MR
83152011-06-12 Martin Rudalics <rudalics@gmx.at>
8316
8317 * frame.c (make_frame): Call other_buffer_safely instead of
8318 other_buffer.
8319
8320 * window.c (temp_output_buffer_show): Call display_buffer with
8321 second argument Vtemp_buffer_show_specifiers and reset latter
8322 immediately after the call.
8323 (Vtemp_buffer_show_specifiers): New variable.
8324 (auto_window_vscroll_p, next_screen_context_lines)
8325 (Vscroll_preserve_screen_position): Remove leading asterisks from
8326 doc-strings.
8327
2d3c217e 83282011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8329
7b7f97e8 8330 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8331 * buffer.c (Qclone_number): Remove for now, as it's unused.
8332 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8333 (record_buffer): Remove unused local.
8334 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8335 (set_frame_buffer_list): Remove; unused.
8336 * frame.h (other_visible_frames): Remove decl.
8337 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8338 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8339 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8340 if HAVE_GPM.
8341 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8342 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8343 Define only if HAVE_GPM.
8344 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8345 (update_hints_inhibit): Remove; never set. All uses removed.
8346 * widgetprv.h (emacsFrameClassRec): Remove decl.
8347 * window.c (delete_deletable_window): Now returns void, since it
8348 wasn't returning anything.
8349 (compare_window_configurations): Remove unused locals.
8350 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8351 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8352 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8353 the same widths as pointers. This follows up on the 2011-05-06 patch.
8354 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8355 * xterm.h: Likewise.
8356 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8357
1384b89e
JB
83582011-06-12 Juanma Barranquero <lekktu@gmail.com>
8359
8360 * makefile.w32-in: Update dependencies.
8361 (LISP_H): Add lib/intprops.h.
8362
1100a63c
CY
83632011-06-11 Chong Yidong <cyd@stupidchicken.com>
8364
8365 * image.c (gif_load): Add animation frame delay to the metadata.
8366 (syms_of_image): Use DEFSYM. New symbol `delay'.
8367
6198ccd0
MR
83682011-06-11 Martin Rudalics <rudalics@gmx.at>
8369
8370 * window.c (delete_deletable_window): Re-add.
8371 (Fset_window_configuration): Rewrite to handle dead buffers and
8372 consequently deletable windows.
8373 (window_tree, Fwindow_tree): Remove. Supply functionality in
8374 window.el.
8375 (compare_window_configurations): Simplify code.
8376
b6e3633c
AS
83772011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8378
1ab0dee5
AS
8379 * image.c (imagemagick_load_image): Fix type mismatch.
8380 (Fimagemagick_types): Likewise.
8381
b6e3633c
AS
8382 * window.h (replace_buffer_in_windows): Declare.
8383
9397e56f
MR
83842011-06-11 Martin Rudalics <rudalics@gmx.at>
8385
8386 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8387 Qclone_number. Remove external declaration of Qdelete_window.
8388 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8389 code.
640c8776
SM
8390 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8391 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8392 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8393 buffer list implementation.
8394 (other_buffer_safely): New function.
8395 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8396 calls to replace_buffer_in_windows and
8397 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8398 if allowed.
8399 (record_buffer): Inhibit quitting and rewrite using quittable
8400 functions. Run Qbuffer_list_update_hook if allowed.
8401 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8402 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8403 Move switch-to-buffer to window.el.
9397e56f
MR
8404 (bury-buffer): Move to window.el.
8405 (Vbuffer_list_update_hook): New variable.
8406
8407 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8408 section.
8409
8410 * window.h (resize_frame_windows): Move up in code.
8411 (Fwindow_frame): Remove EXFUN.
8412 (replace_buffer_in_all_windows): Remove prototype.
8413 (replace_buffer_in_windows_safely): Add prototype.
8414
8415 * window.c: Declare Qdelete_window static again. Move down
8416 declaration of select_count.
8417 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8418 (Fother_window): Move to window.el.
8419 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8420 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8421 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8422 window.el.
8423 (replace_buffer_in_windows): Implement by calling
8424 Qreplace_buffer_in_windows.
8425 (replace_buffer_in_all_windows): Remove with some functionality
8426 moved into replace_buffer_in_windows_safely.
8427 (replace_buffer_in_windows_safely): New function.
8428 (select_window_norecord, select_frame_norecord): Move in front
8429 of run_window_configuration_change_hook. Remove now obsolete
8430 declarations.
640c8776
SM
8431 (Fset_window_buffer): Rewrite doc-string.
8432 Call Qrecord_window_buffer.
9397e56f
MR
8433 (keys_of_window): Move binding for other-window to window.el.
8434
b50691aa
CY
84352011-06-11 Chong Yidong <cyd@stupidchicken.com>
8436
8437 * dispextern.h (struct image): Replace data member, whose int_val
8438 and ptr_val fields were not used by anything, with a single
8439 lisp_val object.
8440
8441 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8442 (gif_clear_image, gif_load, imagemagick_load_image)
8443 (gs_clear_image, gs_load): Callers changed.
8444
3f754b86
PE
84452011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8446
cca69397
PE
8447 * buffer.h: Include <time.h>, for time_t.
8448 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8449
109e28d0
PE
8450 Fix minor problems found by static checking.
8451
60737f02
PE
8452 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8453
4b66faf3
PE
8454 Make identifiers static if they are not used in other modules.
8455 * data.c (Qcompiled_function, Qframe, Qvector):
8456 * image.c (QimageMagick, Qsvg):
8457 * minibuf.c (Qmetadata):
8458 * window.c (resize_window_check, resize_root_window): Now static.
8459 * window.h (resize_window_check, resize_root_window): Remove decls.
8460
109e28d0
PE
8461 * window.c (window_deletion_count, delete_deletable_window):
8462 Remove; unused.
46a4ce9e
PE
8463 (window_body_lines): Now static.
8464 (Fdelete_other_windows_internal): Mark vars as initialized.
8465 Make sure 'resize_failed' is initialized.
8466 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8467 (resize_window_apply): Remove unused local.
8468 * window.h (delete_deletable_window): Remove decl.
8469
109e28d0 8470 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8471 (imagemagick_load_image): Fix pointer signedness problem by changing
8472 last arg from unsigned char * to char *. All uses changed.
8473 Also, fix a local for similar reasons.
8474 Remove unused locals. Remove locals to avoid shadowing.
8475 (fn_rsvg_handle_free): Remove; unused.
8476 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8477 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8478
3f754b86
PE
8479 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8480
2547adb1
CY
84812011-06-10 Chong Yidong <cyd@stupidchicken.com>
8482
8483 * image.c (gif_load): Fix omitted cast error introduced by
8484 2011-06-06 change.
8485
2c8e37d4
MR
84862011-06-10 Martin Rudalics <rudalics@gmx.at>
8487
8488 * window.h (resize_proportionally, orig_total_lines)
8489 (orig_top_line): Remove from window structure.
8490 (set_window_height, set_window_width, change_window_heights)
8491 (Fdelete_window): Remove prototypes.
8492 (resize_frame_windows): Remove duplicate declaration.
8493
440a42e3
EZ
84942011-06-10 Eli Zaretskii <eliz@gnu.org>
8495
8496 * window.h (resize_frame_windows, resize_window_check)
8497 (delete_deletable_window, resize_root_window)
8498 (resize_frame_windows): Declare prototypes.
8499
8500 * window.c (resize_window_apply): Make definition be "static" to
8501 match the prototype.
8502
562dd5e9
MR
85032011-06-10 Martin Rudalics <rudalics@gmx.at>
8504
8505 * window.c: Remove declarations of Qwindow_size_fixed,
8506 window_min_size_1, window_min_size_2, window_min_size,
8507 size_window, window_fixed_size_p, enlarge_window, delete_window.
8508 Remove static from declaration of Qdelete_window, it's
8509 temporarily needed by Fbury_buffer.
8510 (replace_window): Don't assign orig_top_line and
8511 orig_total_lines.
8512 (Fdelete_window, delete_window): Remove. Window deletion is
8513 handled by window.el.
640c8776
SM
8514 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8515 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8516 (Fdelete_other_windows): Remove. Deleting other windows is
8517 handled by window.el.
8518 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8519 handled in window.el.
8520 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8521 Window minimum sizes are handled in window.el.
8522 (shrink_windows, size_window, set_window_height)
8523 (set_window_width, change_window_heights, window_height)
8524 (window_width, CURBEG, CURSIZE, enlarge_window)
8525 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8526 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8527 handled in window.el.
8528 (make_dummy_parent): Rename to make_parent_window and give it a
8529 second argument horflag.
8530 (make_window): Don't set resize_proportionally any more.
8531 (Fsplit_window): Remove. Windows are split in window.el.
8532 (save_restore_action, save_restore_orig_size)
8533 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8534 Resize mini windows in window.el.
8535 (grow_mini_window, shrink_mini_window): Implement by calling
8536 Qresize_root_window_vertically, resize_window_check and
8537 resize_window_apply.
640c8776
SM
8538 (saved_window, Fset_window_configuration, save_window_save):
8539 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8540 resize_proportionally.
8541 (window_min_height, window_min_width): Move to window.el.
8542 (keys_of_window): Move bindings for delete-other-windows,
8543 split-window, delete-window and enlarge-window to window.el.
8544
8545 * buffer.c: Temporarily extern Qdelete_window.
8546 (Fbury_buffer): Temporarily call Qdelete_window instead of
8547 Fdelete_window (Fbury_buffer will move to window.el soon).
8548
8549 * frame.c (set_menu_bar_lines_1): Remove code handling
8550 orig_top_line and orig_total_lines.
8551
8552 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8553 set_window_height but set heights directly.
8554 (change_frame_size_1): Use resize_frame_windows.
8555
8556 * xdisp.c (init_xdisp): Don't use set_window_height but set
8557 heights directly.
8558
640c8776
SM
8559 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8560 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8561 run_window_configuration_change_hook.
8562
8563 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8564 instead of change_window_heights and run
8565 run_window_configuration_change_hook.
8566
1a13852e
MR
85672011-06-09 Martin Rudalics <rudalics@gmx.at>
8568
8569 * window.c (replace_window): Rename second argument REPLACEMENT to
8570 NEW. New third argument SETFLAG. Rewrite.
8571 (delete_window, make_dummy_parent): Call replace_window with
8572 third argument 1.
8573 (window_list_1): Move down in code.
8574 (run_window_configuration_change_hook): Move set_buffer part
8575 before select_frame_norecord part in order to unwind correctly.
8576 Rename count1 to count.
8577 (recombine_windows, delete_deletable_window, resize_root_window)
8578 (Fdelete_other_windows_internal)
8579 (Frun_window_configuration_change_hook, make_parent_window)
8580 (resize_window_check, resize_window_apply, Fresize_window_apply)
8581 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8582 (Fdelete_window_internal, Fresize_mini_window_internal):
8583 New functions.
1a13852e
MR
8584 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8585
f3d1777e
MR
85862011-06-08 Martin Rudalics <rudalics@gmx.at>
8587
496e208e
MR
8588 * window.h (window): Add some new members to window structure -
8589 normal_lines, normal_cols, new_total, new_normal, clone_number,
8590 splits, nest, prev_buffers, next_buffers.
8591 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8592 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8593
f3d1777e
MR
8594 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8595 Remove.
496e208e
MR
8596 (make_dummy_parent): Set new members of windows structure.
8597 (make_window): Move down in code. Handle new members of window
8598 structure.
8599 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8600 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8601 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8602 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8603 (Fset_window_next_buffers, Fset_window_clone_number):
8604 New functions.
496e208e
MR
8605 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8606 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8607 Doc-string fixes.
8608 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8609 Argument WINDOW can be now internal window too.
8610 (Fwindow_use_time): Move up in code.
8611 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8612 Rewrite doc-string.
8613 (Fset_window_configuration, saved_window)
8614 (Fcurrent_window_configuration, save_window_save): Handle new
8615 members of window structure.
b9e809c2
MR
8616 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8617 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8618 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8619 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8620 Qget_mru_window, Qresize_root_window,
8621 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8622 Qauto_buffer_name; staticpro them.
f3d1777e 8623
abde8f8c
MR
86242011-06-07 Martin Rudalics <rudalics@gmx.at>
8625
8626 * window.c (Fwindow_total_size, Fwindow_left_column)
8627 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8628 (Fwindow_list_1): New functions.
8629 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8630 (Fwindow_width, Fscroll_left, Fscroll_right):
8631 Use window_body_cols instead of window_box_text_cols.
8632 (delete_window, Fset_window_configuration):
8633 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8634 (delete_all_subwindows): Take a window as argument and not a
8635 structure. Rewrite.
190b47e6
MR
8636 (window_loop): Remove handling of GET_LRU_WINDOW and
8637 GET_LARGEST_WINDOW.
8638 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8639
8640 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8641 window_box_text_cols. delete_all_subwindows now takes a
8642 Lisp_Object as argument.
abde8f8c 8643
640c8776
SM
8644 * indent.c (compute_motion, Fcompute_motion):
8645 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8646
fa8a67e6
MR
8647 * frame.c (delete_frame): Call delete_all_subwindows with root
8648 window as argument.
8649
a54e3482
DC
86502011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8651
8652 * fns.c (Fputhash): Document return value.
8653
60002bf5
CY
86542011-06-06 Chong Yidong <cyd@stupidchicken.com>
8655
8656 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8657
0c671da6 86582011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8659
b862a52a 8660 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8661
be44ca6c
PE
8662 Check for overflow when converting integer to cons and back.
8663 * charset.c (Fdefine_charset_internal, Fdecode_char):
8664 Use cons_to_unsigned to catch overflow.
8665 (Fencode_char): Use INTEGER_TO_CONS.
8666 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8667 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8668 * data.c (long_to_cons, cons_to_long): Remove.
8669 (cons_to_unsigned, cons_to_signed): New functions.
8670 These signal an error for invalid or out-of-range values.
8671 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8672 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8673 * font.c (Ffont_variation_glyphs):
8674 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8675 * lisp.h: Include <intprops.h>.
8676 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8677 (cons_to_signed, cons_to_unsigned): New decls.
8678 (long_to_cons, cons_to_long): Remove decls.
8679 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8680 (Fprimitive_undo): Use CONS_TO_INTEGER.
8681 * xfns.c (Fx_window_property): Likewise.
8682 * xselect.c: Include <limits.h>.
8683 (x_own_selection, selection_data_to_lisp_data):
8684 Use INTEGER_TO_CONS.
8685 (x_handle_selection_request, x_handle_selection_clear)
8686 (x_get_foreign_selection, Fx_disown_selection_internal)
8687 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8688 (lisp_data_to_selection_data): Use cons_to_unsigned.
8689 (x_fill_property_data): Use cons_to_signed.
8690 Report values out of range.
8691
d1f3d2af
PE
8692 Check for buffer and string overflow more precisely.
8693 * buffer.h (BUF_BYTES_MAX): New macro.
8694 * lisp.h (STRING_BYTES_MAX): New macro.
8695 * alloc.c (Fmake_string):
8696 * character.c (string_escape_byte8):
8697 * coding.c (coding_alloc_by_realloc):
8698 * doprnt.c (doprnt):
8699 * editfns.c (Fformat):
8700 * eval.c (verror):
8701 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8702 since they may not be the same number.
8703 * editfns.c (Finsert_char):
8704 * fileio.c (Finsert_file_contents):
8705 Likewise for BUF_BYTES_MAX.
8706
dd52fcea
PE
8707 * image.c: Use ptrdiff_t, not int, for sizes.
8708 (slurp_file): Switch from int to ptrdiff_t.
8709 All uses changed.
8710 (slurp_file): Check that file size fits in both size_t (for
8711 malloc) and ptrdiff_t (for sanity and safety).
8712
7f9bbdbb
PE
8713 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8714 if b->modtime has its maximal value.
8715
dfe18f82
PE
8716 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8717
84acfcf0
PE
8718 Don't assume time_t can fit into int.
8719 * buffer.h (struct buffer.modtime): Now time_t, not int.
8720 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8721 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8722
ccd9a01a
PE
8723 Minor fixes for signed vs unsigned integers.
8724 * character.h (MAYBE_UNIFY_CHAR):
8725 * charset.c (maybe_unify_char):
8726 * keyboard.c (read_char, reorder_modifiers):
8727 XINT -> XFASTINT, since the integer must be nonnegative.
8728 * ftfont.c (ftfont_spec_pattern):
8729 * keymap.c (access_keymap, silly_event_symbol_error):
8730 XUINT -> XFASTINT, since the integer must be nonnegative.
8731 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8732 since it makes no difference and we prefer signed.
8733 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8734 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8735 nonnegative.
8736
d6d100dd
SM
87372011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8738
8739 * window.h (Fwindow_frame): Declare.
8740
2b6148e4
PE
87412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8742
8743 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8744 (SPARE_MEMORY): Always define.
8745 (LARGE_REQUEST): Remove.
8746 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8747
f230ecc9
MR
87482011-06-06 Martin Rudalics <rudalics@gmx.at>
8749
727e958e
MR
8750 * lisp.h: Move EXFUNS for Fframe_root_window,
8751 Fframe_first_window and Fset_frame_selected_window to window.h.
8752
8753 * window.h: Move EXFUNS for Fframe_root_window,
8754 Fframe_first_window and Fset_frame_selected_window here from
8755 lisp.h.
8756
8757 * frame.c (Fwindow_frame, Fframe_first_window)
8758 (Fframe_root_window, Fframe_selected_window)
8759 (Fset_frame_selected_window): Move to window.c.
8760 (Factive_minibuffer_window): Move to minibuf.c.
8761 (Fother_visible_frames_p): New function.
8762
8763 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8764
f230ecc9
MR
8765 * window.c (decode_window, decode_any_window): Move up in code.
8766 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8767 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8768 (Fwindow_buffer): Move up and rewrite doc-string.
8769 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8770 (Fwindow_prev): New functions.
727e958e
MR
8771 (Fwindow_frame): Move here from frame.c. Accept any window as
8772 argument.
8773 (Fframe_root_window, Fframe_first_window)
8774 (Fframe_selected_window): Move here from frame.c. Accept frame
8775 or arbitrary window as argument. Update doc-strings.
8776 (Fminibuffer_window): Move up in code.
8777 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8778 (Fset_frame_selected_window): Move here from frame.c.
8779 Marginal rewrite.
727e958e
MR
8780 (Fselected_window, select_window, Fselect_window): Move up in
8781 code. Minor doc-string fixes.
f230ecc9 8782
4d09bcf6
PE
87832011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8784
8785 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8786 Do not assume that spare memory exists; that assumption is valid
8787 only if SYSTEM_MALLOC.
8788 (LARGE_REQUEST): New macro, so that the issue of large requests
8789 is separated from the issue of spare memory.
8790
810928a2
AS
87912011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8792
172418ad
AS
8793 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8794 format. (Bug#8806)
8795
43f862f7
AS
8796 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8797
810928a2
AS
8798 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8799 before statements.
8800
a059fe24
JD
88012011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8802
8803 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8804
8805 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8806
8807 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8808 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8809
989bf368
JB
88102011-06-05 Juanma Barranquero <lekktu@gmail.com>
8811
8812 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8813
4b80f674
CY
88142011-06-04 Chong Yidong <cyd@stupidchicken.com>
8815
8816 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8817 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8818 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8819 New error handlers.
4b80f674
CY
8820 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8821 Obey Vx_select_enable_clipboard_manager. Catch errors in
8822 x_clipboard_manager_save (Bug#8779).
8823 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8824 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8825
99a33b77 88262011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8827
8828 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8829
99a33b77 88302011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8831
8832 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8833 in the current matrix if keep_current_p is non-zero.
8834
8264569d
EZ
88352011-06-04 Eli Zaretskii <eliz@gnu.org>
8836
8837 * bidi.c (bidi_level_of_next_char): Fix last change.
8838
57f97249
EZ
88392011-06-03 Eli Zaretskii <eliz@gnu.org>
8840
fec2107c 8841 Support bidi reordering of text covered by display properties.
57f97249 8842
fec2107c
EZ
8843 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8844 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8845 (bidi_cache_search, bidi_cache_iterator_state)
8846 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8847 (bidi_level_of_next_char, bidi_move_to_visually_next):
8848 Support character positions inside a run of characters covered by a
fec2107c
EZ
8849 display string.
8850 (bidi_paragraph_init, bidi_resolve_explicit_1)
8851 (bidi_level_of_next_char): Call bidi_fetch_char and
8852 bidi_fetch_char_advance instead of FETCH_CHAR and
8853 FETCH_CHAR_ADVANCE.
8854 (bidi_init_it): Initialize new members.
8855 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8856 definitions.
8857 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8858 instead of using explicit *_CHAR codes.
d6d100dd
SM
8859 (bidi_resolve_explicit, bidi_resolve_weak):
8860 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8861 bidirectional text is supported only in multibyte buffers.
8862 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8863 it to initialize the frame_window_p member of struct bidi_it.
8864 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8865 (bidi_resolve_explicit, bidi_resolve_weak)
8866 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8867 bidi_it->nchars is non-positive.
8868 (bidi_level_of_next_char): Don't try to lookup the cache for the
8869 next/previous character if nothing is cached there yet, or if we
8870 were just reseat()'ed to a new position.
c40e2fb2 8871
0e14fe90
EZ
8872 * xdisp.c (set_cursor_from_row): Set start and stop points
8873 according to the row's direction when priming the loop that looks
8874 for the glyph on which to display cursor.
8875 (single_display_spec_intangible_p): Function deleted.
8876 (display_prop_intangible_p): Reimplement to call
8877 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8878 Accept 3 additional arguments needed by handle_display_spec.
8879 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8880 values: lists, `(when COND...)' forms, etc.
8881 (single_display_spec_string_p): Support property values that are
8882 lists with the argument STRING its top-level element.
8883 (display_prop_string_p): Fix the condition for processing a
8884 property that is a list to be consistent with handle_display_spec.
fec2107c 8885 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8886 last portion of handle_display_prop.
8887 (compute_display_string_pos): Accept additional argument
8888 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8889 value of a `display' property is a "replacing spec".
8890 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8891 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8892 the display property, but just return a value indicating whether
8893 the display property will replace the characters it covers.
8894 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8895 frame_window_p members of struct bidi_it.
d6d100dd
SM
8896 (compute_display_string_pos, compute_display_string_end):
8897 New functions.
fec2107c
EZ
8898 (push_it): Accept second argument POSITION, where pop_it should
8899 jump to continue iteration.
8900 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8901
fec2107c
EZ
8902 * keyboard.c (adjust_point_for_property): Adjust the call to
8903 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8904
8905 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8906 (bidi_init_it): Update prototypes.
8907 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8908 (compute_display_string_pos, compute_display_string_end):
8909 Declare prototypes.
fec2107c
EZ
8910 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8911 EMACS_INT.
fc6f18ce 8912
40087514 89132011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8914
57f53182
PE
8915 Malloc failure behavior now depends on size of allocation.
8916 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8917 * lisp.h: Change signatures accordingly.
8918 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8919 All callers changed. (Bug#8762)
8920
8921 * gnutls.c: Use Emacs's memory allocators.
8922 Without this change, the gnutls library would invoke malloc etc.
8923 directly, which causes problems on non-SYNC_INPUT hosts, and which
8924 runs afoul of improving memory_full behavior. (Bug#8761)
8925 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8926 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8927 xfree instead of the default malloc, realloc, free.
8928 (Fgnutls_boot): No need to check for memory allocation failure,
8929 since xmalloc does that for us.
8930
ac32cd99 8931 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8932 * category.c (hash_get_category_set):
8933 * ccl.c (ccl_driver):
8934 * charset.c (Fdefine_charset_internal):
8935 * charset.h (struct charset.hash_index):
8936 * composite.c (get_composition_id, gstring_lookup_cache)
8937 (composition_gstring_put_cache):
8938 * composite.h (struct composition.hash_index):
8939 * dispextern.h (struct image.hash):
8940 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8941 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8942 (hashfn_equal, hashfn_user_defined, make_hash_table)
8943 (maybe_resize_hash_table, hash_lookup, hash_put)
8944 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8945 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8946 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8947 * image.c (make_image, search_image_cache, lookup_image)
8948 (xpm_put_color_table_h):
8949 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8950 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8951 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8952 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8953 * alloc.c (allocate_vectorlike):
8954 Check for overflow in vector size calculations.
8955 * ccl.c (ccl_driver):
8956 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8957 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8958 need to be updated by these changes.
40087514
PE
8959 * fns.c (make_hash_table, maybe_resize_hash_table):
8960 Check for integer overflow with large hash tables.
0de4bb68
PE
8961 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8962 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8963 (SXHASH_REDUCE): New macro.
8964 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8965 Use it instead of discarding useful hash info with large hash values.
8966 (sxhash_float): New function.
8967 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8968 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8969 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8970 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8971 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8972 Adjust signatures to match updated version of code.
8973 (consing_since_gc): Now EMACS_INT, since a single hash table can
8974 use more than INT_MAX bytes.
8975
698d32e2
DN
89762011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8977
8978 Make it possible to build with GCC-4.6+ -O2 -flto.
8979
8980 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8981
fd6fa53f
SM
89822011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8983
8984 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8985 Call minibuffer-inactive-mode.
8986
864db017
JB
89872011-05-31 Juanma Barranquero <lekktu@gmail.com>
8988
8989 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8990 Update dependencies.
8991
2ad0baf4
DN
89922011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8993
8994 * data.c (init_data): Remove code for UTS, this system is not
8995 supported anymore.
8996
4fcc2638
DN
89972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8998
8999 Don't force ./temacs to start in terminal mode.
9000
9001 * frame.c (make_initial_frame): Initialize faces in all cases, not
9002 only when CANNOT_DUMP is defined.
9003 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9004
c56e0fd5
DN
90052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9006
9007 * dispnew.c (add_window_display_history): Use const for the string
9008 pointer. Remove declaration, not needed.
9009
333d54da 90102011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9011
55d4c1b2 9012 Use 'inline', not 'INLINE'.
333d54da 9013 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9014 * alloc.c, fontset.c (INLINE): Remove.
9015 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9016 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9017 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9018 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9019 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9020
738db178
DN
90212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9022
9023 Make it possible to run ./temacs.
9024
9025 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9026 syms_of_callproc does the same thing. Remove test for
9027 "initialized", do it in the caller.
9028 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9029
620c53a6
SM
90302011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9031
9032 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9033 (read_minibuf): Use get_minibuffer.
9034 (syms_of_minibuf): Use DEFSYM.
9035 (Qmetadata): New var.
9036 * data.c (Qbuffer): Don't make it static.
9037 (syms_of_data): Use DEFSYM.
9038
e003a292
PE
90392011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9040
9041 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9042 (CCL_CODE_MIN): New macro.
9043
ed008a6d
PE
90442011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9045
3687c2ef
PE
9046 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9047
ed008a6d
PE
9048 * eval.c (Qdebug): Now static.
9049 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9050 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9051 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9052
d66c4c7c
CY
90532011-05-29 Chong Yidong <cyd@stupidchicken.com>
9054
9055 * image.c: Various fixes to ImageMagick code comments.
9056 (Fimagemagick_types): Doc fix.
9057
5fbc2025
PE
90582011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9059
0196f88a
PE
9060 Minor fixes prompted by GCC 4.6.0 warnings.
9061
9062 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9063
5fbc2025
PE
9064 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9065 (x_clipboard_manager_save_all): Move extern decl to ...
9066 * xterm.h: ... here, so that it can be checked for consistency.
9067
1dd3c2d9
CY
90682011-05-29 Chong Yidong <cyd@stupidchicken.com>
9069
9070 * xselect.c (x_clipboard_manager_save_frame)
9071 (x_clipboard_manager_save_all): New functions.
9072 (Fx_clipboard_manager_save): Lisp function deleted.
9073
9074 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9075 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9076
9077 * xterm.h: Update prototype.
9078
5ba6571d
WX
90792011-05-28 William Xu <william.xwl@gmail.com>
9080
9081 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9082 exiting (Bug#8239).
9083
3eaff834
JM
90842011-05-28 Jim Meyering <meyering@redhat.com>
9085
e1900994 9086 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9087 * fns.c (to_uchar): Define.
9088 (crypto_hash_function): Use it to convert some newly-signed
9089 variables to unsigned, to avoid sign-extension bugs. For example,
9090 without this change, (md5 "truc") would evaluate to
9091 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9092 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9093 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9094
0f6990a7
PE
90952011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9096
9097 Integer overflow fixes.
c8a9ca5a 9098
08686060
PE
9099 * dbusbind.c: Serial number integer overflow fixes.
9100 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9101 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9102 to hold a serial number that is too large for a fixnum.
9103 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9104 Check for serial numbers out of range. Decode any serial number
59568bf0 9105 that was so large that it became a float. (Bug#8722)
08686060 9106
2d1fc3c7
PE
9107 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9108 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9109 Use XFASTINT rather than XUINT when numbers are nonnegative.
9110 (xd_append_arg, Fdbus_method_return_internal):
9111 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9112 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9113 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9114 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9115 (Bug#8722)
2d1fc3c7 9116
c8a9ca5a
PE
9117 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9118
519e1d69
PE
9119 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9120
6df6ae42 9121 ccl: Add integer overflow checks.
30569699
PE
9122 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9123 (IN_INT_RANGE): New macros.
9124 (ccl_driver): Use them to check for integer overflow when
9125 decoding a CCL program. Many of the new checks are whether XINT (x)
9126 fits in int; it doesn't always, on 64-bit hosts. The new version
9127 doesn't catch all possible integer overflows, but it's an
847044ea 9128 improvement. (Bug#8719)
30569699 9129
c11285dc
PE
9130 * alloc.c (make_event_array): Use XINT, not XUINT.
9131 There's no need for unsigned here.
9132
fdccd48e
PE
9133 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9134 This follows up to the 2011-05-06 change that substituted uintptr_t
9135 for EMACS_INT. This case wasn't caught back then.
9136
37910ab2
PE
9137 Rework Fformat to avoid integer overflow issues.
9138 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9139 now (part of C89). Include <verify.h>.
9140 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9141 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9142 (Fformat): Avoid the prepass trying to compute sizes; it was only
9143 approximate and thus did not catch overflow reliably. Instead, walk
9144 through the format just once, formatting and computing sizes as we go,
9145 checking for integer overflow at every step, and allocating a larger
9146 buffer as needed. Keep track separately whether the format is
9147 multibyte. Keep only the most-recently calculated precision, rather
9148 than them all. Record whether each argument has been converted to
9149 string. Use EMACS_INT, not int, for byte and char and arg counts.
9150 Support field widths and precisions larger than INT_MAX. Avoid
9151 sprintf's undefined behavior with conversion specifications such as %#d
9152 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9153 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9154 formatting out-of-range floating point numbers with int
9173deec 9155 formats. (Bug#8668)
37910ab2 9156
2e6578fb
PE
9157 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9158
0ae6bdee
PE
9159 * data.c: Avoid integer truncation in expressions involving floats.
9160 * data.c: Include <intprops.h>.
9161 (arith_driver): When there's an integer overflow in an expression
9162 involving floating point, convert the integers to floating point
9163 so that the resulting value does not suffer from catastrophic
9164 integer truncation. For example, on a 64-bit host (* 4
9165 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9166 Do not rely on undefined behavior after integer overflow.
9167
de883a70
PE
9168 merge count_size_as_multibyte, parse_str_to_multibyte
9169 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9170 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9171 Check for integer overflow.
9172 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9173 since it's now a duplicate of the other. This is more of
9174 a character than a buffer op, so better that it's in character.c.
9175 * fns.c, print.c: Adjust to above changes.
9176
2ff916cb
PE
91772011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9178
9179 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9180
f1b54466
PE
91812011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9182
fb1ac845
PE
9183 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9184 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9185 (x_clipboard_manager_save): Now static.
9186 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9187
f1b54466
PE
9188 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9189 (crypto_hash_function): Now static.
9190 Fix pointer signedness problems. Avoid unnecessary initializations.
9191
a9f737ee
CY
91922011-05-27 Chong Yidong <cyd@stupidchicken.com>
9193
9194 * termhooks.h (Vselection_alist): Make it terminal-local.
9195
9196 * terminal.c (create_terminal): Initialize it.
9197
9198 * xselect.c: Support for clipboard managers.
9199 (Vselection_alist): Move to termhooks.h as terminal-local var.
9200 (LOCAL_SELECTION): New macro.
9201 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9202 (symbol_to_x_atom): Remove gratuitous arg.
9203 (x_handle_selection_request, lisp_data_to_selection_data)
9204 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9205 (x_own_selection, x_get_local_selection, x_convert_selection):
9206 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9207 (some_frame_on_display): Delete unused function.
9208 (Fx_own_selection_internal, Fx_get_selection_internal)
9209 (Fx_disown_selection_internal, Fx_selection_owner_p)
9210 (Fx_selection_exists_p): New optional frame arg.
9211 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9212 (x_handle_selection_clear): Don't treat other terminals with the
9213 same keyboard specially. Use the terminal-local Vselection_alist.
9214 (x_clear_frame_selections): Use Frun_hook_with_args.
9215
9216 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9217
9218 * xterm.h: Add support for those atoms.
9219
e067f0c1
CY
92202011-05-26 Chong Yidong <cyd@stupidchicken.com>
9221
9222 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9223 (converted_selections, conversion_fail_tag): New global variables.
9224 (x_selection_request_lisp_error): Free the above.
9225 (x_get_local_selection): Remove unnecessary code.
9226 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9227 of converted selections stored in converted_selections.
9228 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9229 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9230 (x_convert_selection): New function.
9231 (x_handle_selection_event): Simplify.
9232 (x_get_foreign_selection): Don't ignore incoming requests while
9233 waiting for an answer; this will fail when we implement
9234 SAVE_TARGETS, and seems unnecessary anyway.
9235 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9236 (Vx_sent_selection_functions): Doc fix.
9237
0f4aebc0
LL
92382011-05-26 Leo Liu <sdl.web@gmail.com>
9239
9240 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9241
e61124cd
YM
92422011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9243
9244 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9245
9246 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9247 for fringe update if it has periodic bitmap.
ac389d0c 9248 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9249 and fringe_bitmap_periodic_p.
9250
9251 * fringe.c (get_fringe_bitmap_data): New function.
9252 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9253 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9254 row. Mark glyph row for fringe update if periodicity changed.
9255
9256 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9257 for fringe update unless it has periodic bitmap.
9258
f16d9837
KH
92592011-05-25 Kenichi Handa <handa@m17n.org>
9260
9261 * xdisp.c (get_next_display_element): Set correct it->face_id for
9262 a static composition.
9263
e1b90ef6
LL
92642011-05-24 Leo Liu <sdl.web@gmail.com>
9265
9266 * deps.mk (fns.o):
9267 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9268
9269 * fns.c (crypto_hash_function, Fsha1): New function.
9270 (Fmd5): Use crypto_hash_function.
9271 (syms_of_fns): Add Ssha1.
9272
7400048f
PE
92732011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9274
9275 * gnutls.c: Remove unused macros.
9276 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9277 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9278 Remove macros that are defined and never used.
9279 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9280
abb71cf4
CY
92812011-05-22 Chong Yidong <cyd@stupidchicken.com>
9282
9283 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9284 (Fx_get_selection_internal): Minor cleanup.
9285 (Fx_own_selection_internal): Rename arguments for consistency with
9286 select.el.
9287
6307db39
PE
92882011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9289
9290 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9291
f3d4e0a4
CY
92922011-05-22 Chong Yidong <cyd@stupidchicken.com>
9293
9294 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9295
4d8ade89
YM
92962011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9297
9298 * dispnew.c (scrolling_window): Don't exclude the case that the
9299 last enabled row in the desired matrix touches the bottom boundary.
9300
32078c8d
GM
93012011-05-21 Glenn Morris <rgm@gnu.org>
9302
9303 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9304 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9305 and add some more files.
32078c8d 9306
7285dc67
EZ
93072011-05-20 Eli Zaretskii <eliz@gnu.org>
9308
9309 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9310 report_file_error introduced by the change from 2011-05-07.
9311
89d1bd22
PE
93122011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9313
9314 * systime.h (Time): Define only if emacs is defined.
9315 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9316 where the include path doesn't have X11/X.h by default. See
9317 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9318
cd394be1 93192011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9320
9321 * composite.c (find_automatic_composition): Fix previous change.
9322
b9704ad9
GM
93232011-05-20 Glenn Morris <rgm@gnu.org>
9324
9325 * lisp.mk: New file, split from Makefile.in.
9326 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9327 (shortlisp): Remove.
9328 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9329
4a720484
GM
93302011-05-19 Glenn Morris <rgm@gnu.org>
9331
9332 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9333 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9334 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9335 (lisp): Set the order to that of loadup.el.
9336 (shortlisp): Make it a copy of $lisp.
9337 (SOME_MACHINE_LISP): Remove.
9338 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9339 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9340
a28d4396
KH
93412011-05-18 Kenichi Handa <handa@m17n.org>
9342
9343 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9344 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9345 (find_automatic_composition): Mostly rewrite for efficiency.
9346
a2b1fa8e
JB
93472011-05-18 Juanma Barranquero <lekktu@gmail.com>
9348
9349 * makefile.w32-in: Update dependencies.
9350
8e1f5610
CS
93512011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9352
9353 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9354 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9355
7025ee00 93562011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9357
cdfa6eab
PE
9358 Fix some integer overflow issues, such as string length overflow.
9359
06d6db33
PE
9360 * insdel.c (count_size_as_multibyte): Check for string overflow.
9361
2b4560a8
PE
9362 * character.c (lisp_string_width): Check for string overflow.
9363 Use EMACS_INT, not int, for string indexes and lengths; in
9364 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9365 the resulting string length overflows an EMACS_INT; instead,
9366 report a string overflow if no precision given. When checking for
9367 precision exhaustion, use a check that cannot possibly have
9368 integer overflow. (Bug#8675)
9369 * character.h (lisp_string_width): Adjust to new signature.
9370
cb93f9be
PE
9371 * alloc.c (string_overflow): New function.
9372 (Fmake_string): Use it. This doesn't change behavior, but saves
9373 a few bytes and will simplify future changes.
9374 * character.c (string_escape_byte8): Likewise.
9375 * lisp.h (string_overflow): New decl.
9376
1a1f3366
PE
9377 Fixups, following up to the user-interface timestamp change.
9378 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9379 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9380 * msdos.c (mouse_get_pos): Likewise.
9381 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9382 * w32gui.h (Time): Define by including "systime.h" rather than by
9383 declaring it ourselves. (Bug#8664)
9384
d4e3e4d3
PE
9385 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9386 * image.c (clear_image_cache): Likewise.
9387
f6a24d19
PE
9388 * term.c (term_mouse_position): Don't assume time_t wraparound.
9389
08dc5ae6
PE
9390 Be more systematic about user-interface timestamps.
9391 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9392 and sometimes 'EMACS_UINT', to represent these timestamps.
9393 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9394 This makes the code easier to follow, and makes it easier to catch
9395 integer overflow bugs such as Bug#8664.
9396 * frame.c (Fmouse_position, Fmouse_pixel_position):
9397 Use Time, not unsigned long, for user-interface timestamps.
9398 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9399 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9400 * keyboard.h (last_event_timestamp): Likewise.
9401 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9402 * menu.h (xmenu_show): Likewise.
9403 * term.c (term_mouse_position): Likewise.
9404 * termhooks.h (struct input_event.timestamp): Likewise.
9405 (struct terminal.mouse_position_hook): Likewise.
9406 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9407 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9408 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9409 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9410 what it was before.
9411 * menu.h, termhooks.h: Include "systime.h", for Time.
9412
8e55734a
PE
9413 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9414 Don't assume that the difference between two unsigned long values
9415 can fit into an integer. At this point, we know button_down_time
9416 <= event->timestamp, so the difference must be nonnegative, so
9417 there's no need to cast the result if double-click-time is
9418 nonnegative, as it should be; check that it's nonnegative, just in
9419 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9420 apart (about 25 days). (Bug#8664)
8e55734a 9421
841f1b75 9422 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9423 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9424
3e26f69c
PE
9425 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9426 that always fit in int. Use a sentinel instead of a counter, to
9427 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9428 * frame.h (struct frame): Use int for menu_bar_items_used
9429 instead of EMACS_INT, since it always fits in int.
3e26f69c 9430
5cc152c0
PE
9431 * menu.c (grow_menu_items): Check for int overflow.
9432
d89eb65e
PE
9433 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9434
5235bd3e
PE
9435 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9436 Before, the code was not consistent. These values cannot exceed
9437 2**31 - 1 so there's no need to make them unsigned.
9438 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9439 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9440 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9441 as modifiers.
9442 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9443
bc827e23
PE
9444 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9445 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9446 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9447 presumably because the widths might not match.
9448
78eb494e
PE
9449 * window.c (size_window): Avoid needless test at loop start.
9450
04f2d78b
CB
94512011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9452
9453 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9454
d2fc7e3d 94552011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9456
9457 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9458
d2fc7e3d 94592011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9460
9461 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9462 `width' to `bar_area_x' and `bar_area_width', respectively.
9463 (x_scroll_run): Take account of fringe background extension.
9464
04f2d78b
CB
9465 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9466 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9467 `bar_area_width', respectively.
9468 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9469 background extension.
9470
79b70037
GM
94712011-05-10 Jim Meyering <meyering@redhat.com>
9472
9473 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9474
2f142cc5
JB
94752011-05-10 Juanma Barranquero <lekktu@gmail.com>
9476
9477 * image.c (Finit_image_library): Return t for built-in image types,
9478 like pbm and xbm. (Bug#8640)
9479
57679c86
AS
94802011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9481
9482 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9483
888c9e86
EZ
94842011-05-07 Eli Zaretskii <eliz@gnu.org>
9485
b0512a1d
EZ
9486 * w32console.c (Fset_screen_color): Doc fix.
9487 (Fget_screen_color): New function.
9488 (syms_of_ntterm): Defsubr it.
9489
7285dc67
EZ
9490 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9491 unlink the temporary file if Fcall_process didn't create it in the
9492 first place.
9493 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9494 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9495 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9496 cue to call_process_cleanup not to close that handle.
9497
4d3fcc8e
BK
94982011-05-07 Ben Key <bkey76@gmail.com>
9499
9500 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9501 one of two shell specific rules, either bootstrap-temacs-CMD or
9502 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9503 to the previous implementation of the bootstrap-temacs rule.
9504 The bootstrap-temacs-CMD rule is similar to the previous
9505 implementation of the bootstrap-temacs rule except that it
9506 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9507 variable.
9508
9509 These changes, along with some changes to nt/configure.bat,
9510 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9511 earlier fix to add support for --cflags and --ldflags options
9512 that include quotes so that it works whether make uses cmd or
9513 sh as the shell.
9514
b4289b64
MA
95152011-05-06 Michael Albinus <michael.albinus@gmx.de>
9516
9517 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9518 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9519 is a constant.
9520 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9521 a string. Handle both cases.
9522 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9523 (Fdbus_register_method): Use Qinvalid_function.
9524
af4c0e28
JB
95252011-05-06 Juanma Barranquero <lekktu@gmail.com>
9526
9527 * makefile.w32-in: Update dependencies.
9528 (LISP_H): Add inttypes.h and stdin.h.
9529 (PROCESS_H): Add unistd.h.
9530
c51453d9
EZ
95312011-05-06 Eli Zaretskii <eliz@gnu.org>
9532
9533 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9534 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9535
8ff0ac3c 95362011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9537
4c4b566b
PE
9538 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9539
aab2b9b5
PE
9540 * term.c (vfatal): Remove stray call to va_end.
9541 It's not needed and the C Standard doesn't allow it here anyway.
9542
c378da0b
PE
9543 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9544 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9545
288b08c7
PE
9546 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9547 bytes.
9548
e3601888
PE
9549 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9550
db6c0e74
PE
9551 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9552
dd5963ea
PE
9553 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9554
88c9450f
PE
9555 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9556
2f9442b8
PE
9557 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9558
c032b5f8
PE
9559 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9560 * charset.c (Fdefine_charset_internal): Don't initialize
9561 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9562 32-bit int (Bug#8600).
a108c10b
PE
9563
9564 * lread.c (read_integer): Be more consistent with string-to-number.
9565 Use string_to_number to do the actual conversion; this avoids
9566 rounding errors and fixes some other screwups. Without this fix,
9567 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9568 (digit_to_number): Move earlier, for benefit of read_integer.
9569 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9570 not a digit in any supported base. (Bug#8602)
a108c10b 9571
ad5f9eea
PE
9572 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9573
aec1708a
PE
9574 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9575 to match comment at start of function. This also removes a
9576 GCC warning about overflow in a 32+64-bit port.
9577
47be4ab5
PE
9578 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9579
371cac43
PE
9580 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9581 Reported by Stefan Monnier in
9582 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9583 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9584 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9585
d01a7826
PE
9586 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9587 (EMACS_UINTPTR): Likewise, with uintptr_t.
9588
7fd47d5c
PE
9589 * lisp.h: Prefer 64-bit EMACS_INT if available.
9590 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9591 on 32-bit hosts that have 64-bit int, so that they can access
9592 large files.
122b0c86
PE
9593 However, temporarily disable this change unless the temporary
9594 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9595
8727937b
PE
9596 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9597
8ac068ac
PE
9598 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9599 This removes an assumption that EMACS_INT and long are the same
9600 width as pointers. The assumption is true for Emacs porting targets
9601 now, but we want to make other targets possible.
9602 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9603 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9604 In the rest of the code, change types of integers that hold casted
9605 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9606 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9607 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9608 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9609 No need to cast type when ORing.
9610 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9611 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9612 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9613 assume EMACS_INT is the same width as char *.
9614 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9615 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9616 Remove no-longer-needed casts.
9617 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9618 (xg_tool_bar_help_callback, xg_make_tool_item):
9619 Use EMACS_INTPTR to hold an integer
9620 that will be cast to void *; this can avoid a GCC warning
9621 if EMACS_INT is not the same width as void *.
9622 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9623 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9624 (current_message_1, set_message_1):
9625 Use a local to convert to proper width without a cast.
9626 * xmenu.c (dialog_selection_callback): Likewise.
9627
ede49d71
PE
9628 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9629 Also, don't assume VALBITS / RAND_BITS is less than 5,
9630 and don't rely on undefined behavior when shifting a 1 left into
9631 the sign bit.
9632 * lisp.h (get_random): Change signature to match.
9633
2f30ecd0
PE
9634 * lread.c (hash_string): Use size_t, not int, for hash computation.
9635 Normally we prefer signed values; but hashing is special, because
9636 it's better to use unsigned division on hash table sizes so that
9637 the remainder is nonnegative. Also, size_t is the natural width
9638 for hashing into memory. The previous code used 'int', which doesn't
9639 retain enough info to hash well into very large tables.
9640 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9641
2a866e7b
PE
9642 * dbusbind.c: Don't possibly lose pointer info when converting.
9643 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9644 Use XPNTR rather than XHASH, so that the high-order bits of
9645 the pointer aren't lost when converting through void *.
9646
51639eac
PE
9647 * eval.c (Fautoload): Don't double-shift a pointer.
9648
92394119
PE
9649 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9650
dbdb9a7c
JB
96512011-05-06 Juanma Barranquero <lekktu@gmail.com>
9652
9653 * gnutls.c (DEF_GNUTLS_FN):
9654 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9655
db7a0b4f
AS
96562011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9657
9658 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9659 marker. (Bug#8610)
9660
cd394be1 96612011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9662
9663 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9664 New version that can reserve upto 2GB of heap space.
9665
f7ff1b0f 96662011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9667
9668 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9669
639c109b
TZ
96702011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9671
9672 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9673 `gnutls_certificate_set_x509_key_file'.
9674
d2127135
JB
96752011-05-05 Juanma Barranquero <lekktu@gmail.com>
9676
9677 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9678 Update dependencies.
9679
e968f4f3
JB
96802011-05-04 Juanma Barranquero <lekktu@gmail.com>
9681
9682 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9683 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9684 Remove unused parameter `fildes'.
9685 * process.c (read_process_output, send_process): Don't pass it.
9686
84d358f0
JB
96872011-05-04 Juanma Barranquero <lekktu@gmail.com>
9688
9689 Fix previous change: the library cache is defined in w32.c.
9690 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9691 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9692
0898ca10
JB
96932011-05-04 Juanma Barranquero <lekktu@gmail.com>
9694
9695 Implement dynamic loading of GnuTLS on Windows.
9696
9697 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9698 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9699 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9700 Declare.
9701
9702 * gnutls.c (Qgnutls_dll): Define.
9703 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9704 (gnutls_*): Declare function pointers.
9705 (init_gnutls_functions): New function to initialize function pointers.
9706 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9707 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9708 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9709 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9710 (emacs_gnutls_write, emacs_gnutls_read)
9711 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9712 (Fgnutls_available_p): New function.
9713 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9714 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9715 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9716
9717 * image.c: Include w32.h.
9718 (Vimage_type_cache): Delete.
9719 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9720 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9721 (w32_delayed_load): Move to w32.c.
9722
9723 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9724
9725 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9726 (w32_delayed_load): Move from image.c. When loading a library, record
9727 its filename in the :loaded-from property of the library id.
9728 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9729 Initialize and staticpro them.
9730 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9731
9732 * process.c: Include lisp.h before w32.h, not after.
9733 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9734 instead of gnutls_record_check_pending.
9735
9736 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9737
ff4de4aa
TZ
97382011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9739
9740 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9741 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9742 as passed in.
9743
abe95abb
JD
97442011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9745
9746 * xterm.c (x_set_frame_alpha): Do not set property on anything
9747 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9748
e16e55d4
JB
97492011-05-02 Juanma Barranquero <lekktu@gmail.com>
9750
9751 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9752
bafcf6a5
JB
97532011-05-02 Juanma Barranquero <lekktu@gmail.com>
9754
9755 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9756 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9757 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9758 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9759 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9760 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9761 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9762 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9763 (Qgnutls_bootprop_callbacks_verify): Make static.
9764
e7a6747f
AS
97652011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9766
19ed11ba
AS
9767 * callproc.c: Indentation fixup.
9768
e7a6747f 9769 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9770 (wait_for_termination, interruptible_wait_for_termination):
9771 Move after wait_for_termination_1.
e7a6747f 9772
1ef14cb4
LMI
97732011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9774
9775 * sysdep.c (interruptible_wait_for_termination): New function
9776 which is like wait_for_termination, but allows keyboard
9777 interruptions.
9778
9779 * callproc.c (Fcall_process): Add (:file "file") as an option for
9780 the STDOUT buffer.
9781 (Fcall_process_region): Ditto.
9782
330d880c
EZ
97832011-04-30 Eli Zaretskii <eliz@gnu.org>
9784
8db90b73
EZ
9785 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9786 rather than `XVECTOR (FOO)->size'.
9787
330d880c
EZ
9788 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9789 inttypes.h, as a gnulib replacement is used if it not available in
9790 system headers.
9791
15cbd324
EZ
97922011-04-21 Eli Zaretskii <eliz@gnu.org>
9793
9794 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9795 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9796 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9797
9798 * coding.c (coding_alloc_by_realloc): Error out if destination
9799 will grow beyond MOST_POSITIVE_FIXNUM.
9800 (decode_coding_emacs_mule): Abort if there isn't enough place in
9801 charbuf for the composition carryover bytes. Reserve an extra
9802 space for up to 2 characters produced in a loop.
9803 (decode_coding_iso_2022): Abort if there isn't enough place in
9804 charbuf for the composition carryover bytes.
9805
98062011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9807
ae940cca
EZ
9808 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9809 aborting when %lld or %lll format is passed.
9810 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9811 %llo or %llx format is passed. (Bug#8545)
9812
03ab8921
EZ
9813 * window.c (window_scroll_line_based): Use a marker instead of
9814 simple variables to record original value of point. (Bug#7952)
9815
afda1437
EZ
9816 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9817 produced by %s or %c overflows available buffer space. (Bug#8545)
9818
f76dee0c
PE
98192011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9820
9821 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9822 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9823
fdc5744d
JB
98242011-04-28 Juanma Barranquero <lekktu@gmail.com>
9825
9826 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9827
638f053a
JB
98282011-04-28 Juanma Barranquero <lekktu@gmail.com>
9829
9830 * keyboard.c (Qdelayed_warnings_hook): Define.
9831 (command_loop_1): Run `delayed-warnings-hook'
9832 if Vdelayed_warnings_list is non-nil.
9833 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9834 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9835
d178f871
EZ
98362011-04-28 Eli Zaretskii <eliz@gnu.org>
9837
9838 * doprnt.c (doprnt): Don't return value smaller than the buffer
9839 size if the message was truncated. (Bug#8545).
9840
b124fd93
JB
98412011-04-28 Juanma Barranquero <lekktu@gmail.com>
9842
9843 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9844 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9845
e810457d
PE
98462011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9847
9848 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9849
ea51cceb
JB
98502011-04-27 Juanma Barranquero <lekktu@gmail.com>
9851
9852 * makefile.w32-in: Update dependencies.
9853
94dcfacf
EZ
98542011-04-27 Eli Zaretskii <eliz@gnu.org>
9855
9856 Improve `doprnt' and its usage. (Bug#8545)
9857 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9858 `format_end'. Remove support for %l as a conversion specifier.
9859 Don't use xrealloc. Improve diagnostics when the %l size modifier
9860 is used. Update the commentary.
9861
9862 * eval.c (verror): Simplify calculation of size_t.
9863
9864 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9865 messages.
9866
f61f41d7
PE
98672011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9868
9869 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9870 change.
9871
96fb4434
PE
98722011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9873
9874 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9875 This makes this file independent of the recent pseudovector change.
9876
671875da 98772011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9878
69e9b5a3
PE
9879 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9880
b5f869a7 9881 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9882 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9883 Remove unused local.
c8926152 9884 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9885
841a1577 9886 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9887 GCC 4.6.0 optimizes based on type-based alias analysis.
9888 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9889 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9890 != &v->size, and therefore "v->size = 1; b->size = 2; return
9891 v->size;" must therefore return 1. This assumption is incorrect
9892 for Emacs, since it type-puns struct Lisp_Vector * with many other
9893 types. To fix this problem, this patch adds a new type struct
f904488f 9894 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9895 and pseudovectors, and helps optimizing compilers not get fooled
9896 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9897 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9898 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9899 the size member.
eab3844f
PE
9900 (XSETPVECTYPE): Rewrite in terms of new macro.
9901 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9902 This is a bit clearer, and further avoids the possibility of
9903 undesirable aliasing.
9904 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9905 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9906 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9907 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9908 (ASIZE): Now uses header.size rather than size.
9909 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9910 to avoid the hassle of writing XVECTOR (foo)->header.size.
9911 (struct vectorlike_header): New type.
eab3844f
PE
9912 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9913 object, to help avoid aliasing.
9914 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9915 (SUBRP): Likewise, since Lisp_Subr is a special case.
9916 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9917 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9918 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9919 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9920 changed to be "header.size" and "header.next".
9921 * buffer.h (struct buffer): Likewise.
9922 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9923 * frame.h (struct frame): Likewise.
9924 * process.h (struct Lisp_Process): Likewise.
9925 * termhooks.h (struct terminal): Likewise.
9926 * window.c (struct save_window_data, struct saved_window): Likewise.
9927 * window.h (struct window): Likewise.
9928 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9929 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9930 * buffer.c (init_buffer_once): Likewise.
9931 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9932 special case.
9933 * process.c (Fformat_network_address): Use local var for size,
9934 for brevity.
9935
0df1eac5
PE
9936 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9937
847ab9d1 9938 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9939 * data.c (atof): Remove decl; no longer used or needed.
9940 (digit_to_number): Move to lread.c.
9941 (Fstring_to_number): Use new string_to_number function, to be
9942 consistent with how the Lisp reader treats infinities and NaNs.
9943 Do not assume that floating-point numbers represent EMACS_INT
9944 without losing information; this is not true on most 64-bit hosts.
9945 Avoid double-rounding errors, by insisting on integers when
9946 parsing non-base-10 numbers, as the documentation specifies.
9947 * lisp.h (string_to_number): New decl, replacing ...
9948 (isfloat_string): Remove.
bc0a5c13 9949 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9950 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9951 appears to have been a coding error. Similarly, do not accept
9952 strings like +-1e0 as floating point numbers. Do not report
9953 overflow for integer overflows unless the base is not 10 which
9954 means we have no simple and reliable way to continue.
9955 Break out the floating-point parsing into a new
9956 function string_to_number, so that Fstring_to_number parses
9957 floating point numbers consistently with the Lisp reader.
04f2d78b 9958 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9959 (E_CHAR, EXP_INT): Remove, replacing with ...
9960 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9961 (string_to_number): New function, replacing isfloat_string.
9962 This function checks for valid syntax and produces the resulting
9963 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9964 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9965 so that overflow for non-base-10 numbers is reported only when
9966 there's no portable and simple way to convert to floating point.
452f4150 9967
67769ffc
PE
9968 * textprop.c (set_text_properties_1): Rewrite for clarity,
9969 and to avoid GCC warning about integer overflow.
9970
c20db43f
PE
9971 * intervals.h (struct interval): Use EMACS_INT for members
9972 where EMACS_UINT might cause problems. See
9973 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9974 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9975 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9976 All uses changed.
37aa2f85
PE
9977 (offset_intervals): Tell GCC not to worry about length overflow
9978 when negating a negative length.
c20db43f 9979
2538aa2f
PE
9980 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9981 (overrun_check_free): Likewise.
9982
f2d3008d
PE
9983 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9984 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9985 word size.
9986
ec8df744
PE
9987 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9988 (gnutls_make_error): Rename local to avoid shadowing.
9989 (gnutls_emacs_global_deinit): ifdef out; not used.
9990 (Fgnutls_boot): Use const for pointer to readonly storage.
9991 Comment out unused local. Fix pointer signedness problems.
9992
640ee02d
PE
9993 * lread.c (openp): Don't stuff size_t into an 'int'.
9994 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9995 about possible signed overflow.
9996
6048fb2a
PE
9997 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9998 (GDK_KEY_g): Don't define if already defined.
9999 (xg_prepare_tooltip): Avoid pointer signedness problem.
10000 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10001
fa3c87e1
PE
10002 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10003 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10004
2172544b
PE
10005 * xfns.c (Fx_window_property): Simplify a bit,
10006 to make a bit faster and to avoid GCC 4.6.0 warning.
10007 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10008
9b821a21
PE
10009 * fns.c (internal_equal): Don't assume size_t fits in int.
10010
3c616cfa
PE
10011 * alloc.c (compact_small_strings): Tighten assertion a little.
10012
c2982e87
PE
10013 Replace pEd with more-general pI, and fix some printf arg casts.
10014 * lisp.h (pI): New macro, generalizing old pEd macro to other
10015 conversion specifiers. For example, use "...%"pI"d..." rather
10016 than "...%"pEd"...".
10017 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10018 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10019 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10020 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10021 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10022 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10023 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10024 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10025 64-bit hosts.
10026 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10027 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10028 * print.c (safe_debug_print, print_object): Likewise.
10029 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10030 to int.
6f04d126
PE
10031 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10032 avoiding the 0 flag, which is not portable.
c2982e87
PE
10033 * process.c (Fmake_network_process): Use pI to avoid cast.
10034 * region-cache.c (pp_cache): Likewise.
10035 * xdisp.c (decode_mode_spec): Likewise.
10036 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10037 behavior on 64-bit hosts with printf arg.
6f04d126 10038 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10039 (x_stop_queuing_selection_requests): Likewise.
10040 (x_get_window_property): Don't truncate byte count to an 'int'
10041 when tracing.
0b432f21 10042
5e073ec7
PE
10043 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10044 here, since it parses constructs like leading '-' and spaces,
10045 which are not wanted; and it overflows with large numbers.
10046 Instead, simply match F[0-9]+, which is what is wanted anyway.
10047
36372bf9
PE
10048 * alloc.c: Remove unportable assumptions about struct layout.
10049 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10050 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10051 (allocate_vectorlike, make_pure_vector): Use the new macros,
10052 plus offsetof, to remove unportable assumptions about struct layout.
10053 These assumptions hold on all porting targets that I know of, but
10054 they are not guaranteed, they're easy to remove, and removing them
10055 makes further changes easier.
10056
0b432f21
PE
10057 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10058 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10059 (string_overrun_cookie): Now const. Use initializers that
10060 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10061 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10062 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10063 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10064 multiple of sizeof (EMACS_INT); it need not be, if
10065 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10066 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10067
895009e1
JB
100682011-04-26 Juanma Barranquero <lekktu@gmail.com>
10069
10070 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10071
6a7a1b0b
TZ
100722011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10073
10074 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10075 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10076 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10077
841a1577 100782011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10079
10080 * lisp.h (Qdebug): List symbol.
895009e1 10081 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10082 * keyboard.c (debug-on-event): New variable.
10083 (handle_user_signal): Break into debugger when debug-on-event
10084 matches the current signal symbol.
10085
f2d3ba6f
DN
100862011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10087
10088 * alloc.c (check_sblock, check_string_bytes)
10089 (check_string_free_list): Convert to standard C.
10090
42ce4c63
TZ
100912011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10092
10093 * w32.c (emacs_gnutls_push): Fix typo.
10094
825cd63c
EZ
100952011-04-25 Eli Zaretskii <eliz@gnu.org>
10096
fb11d64d
EZ
10097 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10098 "cast to pointer from integer of different size".
10099
825cd63c
EZ
10100 Improve doprnt and its use in verror. (Bug#8545)
10101 * doprnt.c (doprnt): Document the set of format control sequences
10102 supported by the function. Use SAFE_ALLOCA instead of always
10103 using `alloca'.
10104
10105 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10106 is one byte too soon. Don't use xrealloc; instead xfree and
10107 xmalloc anew.
10108
e061a11b
TZ
101092011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10110
10111 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10112 callbacks stage.
10113
10114 * gnutls.c: Renamed global_initialized to
10115 gnutls_global_initialized. Added internals for the
10116 :verify-hostname-error, :verify-error, and :verify-flags
10117 parameters of `gnutls-boot' and documented those parameters in the
10118 docstring. Start callback support.
9173deec
JB
10119 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10120 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10121 on error. Return error code.
e061a11b
TZ
10122 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10123 (emacs_gnutls_read): Likewise.
10124 (Fgnutls_boot): Return handshake error code.
10125 (emacs_gnutls_handle_error): New function.
10126 (wsaerror_to_errno): Likewise.
10127
10128 * w32.h (emacs_gnutls_pull): Add prototype.
10129 (emacs_gnutls_push): Likewise.
10130
10131 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10132 (emacs_gnutls_push): Likewise.
10133
101342011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10135
10136 * process.c (wait_reading_process_output): Check if GnuTLS
10137 buffered some data internally if no FDs are set for TLS
10138 connections.
10139
10140 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10141 (LIBS): Link to USER_LIBS.
10142 ($(BLD)/gnutls.$(0)): New target.
10143
fa6996bc
EZ
101442011-04-24 Eli Zaretskii <eliz@gnu.org>
10145
eb35682e
EZ
10146 * xdisp.c (handle_single_display_spec): Rename the
10147 display_replaced_before_p argument into display_replaced_p, to
10148 make it consistent with the commentary. Fix typos in the
10149 commentary.
10150
e2ad650c
EZ
10151 * textprop.c (syms_of_textprop): Remove dead code.
10152 (copy_text_properties): Delete obsolete commentary about an
10153 interface that was deleted long ago. Fix typos in the description
10154 of arguments.
10155
1b2de274
EZ
10156 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10157 to changes in oldXMenu/XMenu.h from 2011-04-16.
10158 <menu_help_message, prev_menu_help_message>: Constify.
10159 (IT_menu_make_room): menu->help_text is now `const char **';
10160 adjust.
10161
10162 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10163 to changes in oldXMenu/XMenu.h from 2011-04-16.
10164 (struct XMenu): Declare `help_text' `const char **'.
10165
10166 * xfaces.c <Qunspecified>: Make extern again.
10167
10168 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10169 required by POSIX.
1b2de274 10170
762b15be
EZ
10171 * doc.c (get_doc_string): Improve the format passed to `error'.
10172
10173 * doprnt.c (doprnt): Improve commentary.
10174
10175 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10176
10177 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10178 them with etags.
10179
f1052e5d
EZ
10180 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10181 changes in globals.h immediately force recompilation.
762b15be
EZ
10182 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10183 $(CURDIR)/s/ms-w32.h.
10184 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10185
fa6996bc
EZ
10186 * character.c (Fchar_direction): Function deleted.
10187 (syms_of_character): Don't defsubr it.
10188 <char-direction-table>: Deleted.
10189
e6c3da20
EZ
101902011-04-23 Eli Zaretskii <eliz@gnu.org>
10191
10192 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10193 * doprnt.c: Include limits.h.
10194 (SIZE_MAX): New macro.
04f2d78b
CB
10195 (doprnt): Return a size_t value. 2nd arg is now size_t.
10196 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10197 Improve overflow protection. Support `l' modifier for integer
10198 conversions. Support %l conversion. Don't assume an EMACS_INT
10199 argument for integer conversions and for %c.
10200
10201 * lisp.h (doprnt): Restore prototype.
10202
10203 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10204 $(SRC)/character.h.
10205
10206 * Makefile.in (base_obj): Add back doprnt.o.
10207
10208 * deps.mk (doprnt.o): Add back prerequisites.
10209 (callint.o): Depend on character.h.
10210
10211 * eval.c (internal_lisp_condition_case): Include the handler
10212 representation in the error message.
10213 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10214 when breaking from the loop.
10215
10216 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10217
10218 * callint.c (Fcall_interactively): When displaying error message
10219 about invalid control letter, pass the character's codepoint, not
10220 a pointer to its multibyte form. Improve display of the character
10221 in octal and display also its hex code.
10222
10223 * character.c (char_string): Use %x to display the (unsigned)
10224 codepoint of an invalid character, to avoid displaying a bogus
10225 negative value.
10226
10227 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10228 `error', not SYMBOL_NAME itself.
10229
10230 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10231 character arguments to `error'.
10232
10233 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10234 to `error' in error message about FINAL_CHAR argument. Make sure
10235 FINAL_CHAR is a character, and use %c when it is passed as
10236 argument to `error'.
10237
4ffd0d6b 102382011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10239
10240 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10241
10242 * w32.c: Include <time.h>.
10243 (sys_localtime): New function.
10244
4ffd0d6b 102452011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10246
10247 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10248
4ffd0d6b 10249 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10250
4ffd0d6b 102512011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10252
4ffd0d6b
GM
10253 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10254 zombies (Bug#8467).
aac0c6e3 10255
04c56954
EZ
102562011-04-19 Eli Zaretskii <eliz@gnu.org>
10257
10258 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10259 gl_state.e_property when gl_state.object is Qt.
10260
10261 * insdel.c (make_gap_larger): Remove limitation of buffer size
10262 to <= INT_MAX.
10263
16a43933
CY
102642011-04-18 Chong Yidong <cyd@stupidchicken.com>
10265
10266 * xdisp.c (lookup_glyphless_char_display)
10267 (produce_glyphless_glyph): Handle cons cell entry in
10268 glyphless-char-display.
10269 (Vglyphless_char_display): Document it.
10270
10271 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10272 glyphless-char-display.
10273
4581706e
CY
102742011-04-17 Chong Yidong <cyd@stupidchicken.com>
10275
10276 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10277
10278 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10279
10280 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10281 definition for no-X builds.
10282
4887c6e2 102832011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10284
fd35b6f9
PE
10285 Static checks with GCC 4.6.0 and non-default toolkits.
10286
5c1ccb01
PE
10287 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10288
006c5daa
PE
10289 * process.c (keyboard_bit_set): Define only if SIGIO.
10290 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10291 (send_process): Repair possible setjmp clobbering.
10292
efc736d3
PE
10293 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10294
4e2fe2e6
PE
10295 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10296
f97334a2
PE
10297 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10298
4e75f29d
PE
10299 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10300 Define only if needed.
10301
90efadd1
PE
10302 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10303 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10304 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10305
3c647824
PE
10306 * dispextern.h (struct redisplay_interface): Rename param
10307 to avoid shadowing.
e264f262 10308 * termhooks.h (struct terminal): Likewise.
761383f4 10309 * xterm.c (xembed_send_message): Likewise.
3c647824 10310
b58c5c4a
PE
10311 * insdel.c (make_gap_smaller): Define only if
10312 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10313
cad59032
PE
10314 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10315 it.
10316
c339dc2e
PE
10317 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10318 so that we aren't warned about unused symbols.
10319
91a3e27b
PE
10320 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10321
399c71d3 10322 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10323
8ffc96f5
PE
10324 * xfns.c (x_real_positions): Mark locals as initialized.
10325
eef9bc79
PE
10326 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10327
098db9dd
PE
10328 * xterm.c: Fix problems found by static analysis with other toolkits.
10329 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10330 (x_dispatch_event): Declare static if USE_GTK, and
10331 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10332 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10333 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10334 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10335 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10336
eb18f6cc
PE
10337 * xmenu.c (menu_help_callback): Pointer type fixes.
10338 Use const pointers when pointing at readonly data. Avoid pointer
10339 signedness clashes.
10340 (FALSE): Remove unused macro.
10341 (update_frame_menubar): Remove unused decl.
10342
1fe72bf8
PE
10343 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10344
60d9e1db
PE
10345 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10346 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10347 (single_menu_item): Rename local to avoid shadowing.
10348
39261c26
PE
10349 * keyboard.c (make_lispy_event): Remove unused local var.
10350
018c5e19
PE
10351 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10352 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10353
63d2b86e
PE
10354 * bitmaps: Change bitmaps from unsigned char back to the X11
10355 compatible char. Avoid the old compiler warnings about
10356 out-of-range initializers by using, for example, '\xab' rather
10357 than 0xab.
10358
aefd87e1
PE
10359 * xgselect.c (xgselect_initialize): Check vs interface
10360 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10361
bf501fb9
PE
10362 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10363
e9829fdf
PE
10364 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10365 to read-only memory.
10366
1086c095
PE
10367 * fns.c (vector): Remove; this old hack is no longer needed.
10368
2baccd04 10369 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10370 Remove unused var.
dde42981 10371 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10372
72391843 10373 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10374
436c16df 10375 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10376 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10377 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10378
92bb796d 10379 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10380 (x_term_init): Remove local to avoid shadowing.
92bb796d 10381
764430a3 10382 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10383
10384 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10385 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10386
d1dfb56c
EZ
103872011-04-16 Eli Zaretskii <eliz@gnu.org>
10388
c4354cb4
EZ
10389 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10390
d1dfb56c
EZ
10391 Fix regex.c, syntax.c and friends for buffers > 2GB.
10392 * syntax.h (struct gl_state_s): Declare character position members
10393 EMACS_INT.
10394
10395 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10396
04f2d78b
CB
10397 * textprop.c (verify_interval_modification, interval_of):
10398 Declare arguments EMACS_INT.
d1dfb56c
EZ
10399
10400 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10401 EMACS_INT.
10402
10403 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10404
10405 * indent.c (Fvertical_motion): Local variable it_start is now
10406 EMACS_INT.
10407
10408 * regex.c (re_match, re_match_2, re_match_2_internal)
10409 (bcmp_translate, regcomp, regexec, print_double_string)
10410 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10411 (re_compile_pattern, re_exec): Declare arguments and local
10412 variables `size_t' and `ssize_t' and return values `regoff_t', as
10413 appropriate.
10414 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10415 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10416 <compile_stack_type>: `size' and `avail' are now `size_t'.
10417
10418 * regex.h <regoff_t>: Use ssize_t, not int.
10419 (re_search, re_search_2, re_match, re_match_2): Arguments that
10420 specify buffer/string position and length are now ssize_t and
10421 size_t. Return type is regoff_t.
10422
613052cd
BK
104232011-04-16 Ben Key <bkey76@gmail.com>
10424
10425 * nsfont.m: Fixed bugs in ns_get_family and
10426 ns_descriptor_to_entity that were caused by using free to
10427 deallocate memory blocks that were allocated by xmalloc (via
10428 xstrdup). This caused Emacs to crash when compiled with
10429 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10430 --enable-checking=xmallocoverrun). xfree is now used to
10431 deallocate these memory blocks.
10432
4170f62f 104332011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10434
71b41406
PE
10435 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10436
9587a89d
PE
10437 emacs_write: Accept and return EMACS_INT for sizes.
10438 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10439 et seq.
10440 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10441 Accept and return EMACS_INT.
10442 (emacs_gnutls_write): Return the number of bytes written on
10443 partial writes.
10444 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10445 (emacs_read, emacs_write): Remove check for negative size, as the
10446 Emacs source code has been audited now.
9587a89d
PE
10447 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10448 (emacs_read, emacs_write): Use it.
273a5f82
PE
10449 * process.c (send_process): Adjust to the new signatures of
10450 emacs_write and emacs_gnutls_write. Do not attempt to store
10451 a byte offset into an 'int'; it might overflow.
9587a89d 10452 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10453
3e047f51
PE
10454 * sound.c: Don't assume sizes fit in 'int'.
10455 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10456 Return EMACS_INT, not int.
3e047f51 10457 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10458 Accept EMACS_INT, not int.
10459 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10460 record read return values.
10461
cc39a9db
BK
104622011-04-15 Ben Key <bkey76@gmail.com>
10463
c9d0ec6d
JB
10464 * keyboard.c (Qundefined): Don't declare static since it is used
10465 in nsfns.m.
10466 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10467 static since they are used in nsfont.m.
cc39a9db 10468
6c60eb9f
SM
104692011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10470
10471 * process.c (Qprocessp): Don't declare static.
10472 * lisp.h (Qprocessp): Declare again.
10473
7990b61a
JB
104742011-04-15 Juanma Barranquero <lekktu@gmail.com>
10475
10476 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10477
5d4cb038
PE
104782011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10479
8bd7b830 10480 Improve C-level modularity by making more things 'static'.
cd64ea1d 10481
e3b27b31
PE
10482 Don't publish debugger-only interfaces to other modules.
10483 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10484 (verify_bytepos, count_markers): Move decls to the only modules
10485 that need them.
10486 * region-cache.h (pp_cache): Likewise.
10487 * window.h (check_all_windows): Likewise.
10488 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10489
5d4cb038
PE
10490 * sysdep.c (croak): Now static, if
10491 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10492 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10493
10494 * alloc.c (refill_memory_reserve): Now static if
10495 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10496 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10497
e87b6180
PE
10498 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10499 Define only if USE_LUCID.
10500
ac64929e
PE
10501 * xrdb.c (x_customization_string, x_rm_string): Now static.
10502
6f37259d
PE
10503 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10504 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10505
1683e3ab
PE
10506 * xdisp.c (draw_row_with_mouse_face): Now static.
10507 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10508
de9c2632
PE
10509 * window.h (check_all_windows): Mark externally visible.
10510
2b96acb7
PE
10511 * window.c (window_deletion_count): Now static.
10512
10513 * undo.c: Make symbols static if they're not exported.
10514 (last_undo_buffer, last_boundary_position, pending_boundary):
10515 Now static.
10516
50436f33
PE
10517 * textprop.c (interval_insert_behind_hooks): Now static.
10518 (interval_insert_in_front_hooks): Likewise.
10519
64520e5c
PE
10520 * term.c: Make symbols static if they're not exported.
10521 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10522 (max_frame_lines, tty_set_terminal_modes):
10523 (tty_reset_terminal_modes, tty_turn_off_highlight):
10524 (get_tty_terminal): Now static.
10525 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10526 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10527 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10528 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10529 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10530
1fa53021
PE
10531 * sysdep.c: Make symbols static if they're not exported.
10532 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10533 Now static.
10534 (sigprocmask_set, full_mask): Remove; unused.
10535 (wait_debugging): Mark as visible.
10536 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10537 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10538
d4b43b22
PE
10539 * syntax.c (syntax_temp): Define only if !__GNUC__.
10540
b7c513d0
PE
10541 * sound.c (current_sound_device, current_sound): Now static.
10542
989b29ad
PE
10543 * search.c (searchbufs, searchbuf_head): Now static.
10544
13a55a78
PE
10545 * scroll.c (scroll_cost): Remove; unused.
10546 * dispextern.h (scroll_cost): Remove decl.
10547
de68a1fc
PE
10548 * region-cache.h (pp_cache): Mark as externally visible.
10549
40ccffa6
PE
10550 * process.c: Make symbols static if they're not exported.
10551 (process_tick, update_tick, create_process, chan_process):
10552 (Vprocess_alist, proc_buffered_char, datagram_access):
10553 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10554 (deactivate_process): Mark defn as static, as well as decl.
10555 * lisp.h (create_process): Remove decl.
10556 * process.h (chan_process, Vprocess_alist): Remove decls.
10557
ad64fc97
PE
10558 * print.c: Make symbols static if they're not exported.
10559 (print_depth, new_backquote_output, being_printed, print_buffer):
10560 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10561 (print_interval, print_number_index, initial_stderr_stream):
10562 Now static.
10563 * lisp.h (Fprinc): Remove decl.
10564 (debug_output_compilation_hack): Mark as externally visible.
10565
adddb265
PE
10566 * sysdep.c (croak): Move decl from here to syssignal.h.
10567 * syssignal.h (croak): Put it here, so the API can be checked when
10568 'croak' is called from dissociate_if_controlling_tty.
10569
1717ede2
PE
10570 * minibuf.c: Make symbols static if they're not exported.
10571 (minibuf_save_list, choose_minibuf_frame): Now static.
10572 * lisp.h (choose_minibuf_frame): Remove decl.
10573
fa5fb2bc
PE
10574 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10575
1e3890d1
PE
10576 * lread.c: Make symbols static if they're not exported.
10577 (read_objects, initial_obarray, oblookup_last_bucket_number):
10578 Now static.
10579 (make_symbol): Remove; unused.
10580 * lisp.h (initial_obarray, make_symbol): Remove decls.
10581
8a1414fa
PE
10582 * keyboard.c: Make symbols static if they're not exported.
10583 (single_kboard, recent_keys_index, total_keys, recent_keys):
10584 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10585 (this_single_command_key_start, echoing, last_auto_save):
10586 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10587 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10588 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10589 (Vlispy_mouse_stem, double_click_count):
10590 Now static.
10591 (force_auto_save_soon): Define only if SIGDANGER.
10592 (ignore_mouse_drag_p): Now static if
10593 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10594 (print_help): Remove; unused.
10595 (stop_character, last_timer_event): Mark as externally visible.
10596 * keyboard.h (ignore_mouse_drag_p): Declare only if
10597 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10598 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10599 * lisp.h (echoing): Remove decl.
10600 (force_auto_save_soon): Declare only if SIGDANGER.
10601 * xdisp.c (redisplay_window): Simplify code, to make it more
10602 obvious that ignore_mouse_drag_p is not accessed if !defined
10603 USE_GTK && !defined HAVE_NS.
10604
93ea6e8f
PE
10605 * intervals.c: Make symbols static if they're not exported.
10606 (merge_properties_sticky, merge_interval_right, delete_interval):
10607 Now static.
10608 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10609
77382fcc
PE
10610 * insdel.c: Make symbols static if they're not exported.
10611 However, leave prepare_to_modify_buffer alone. It's never
10612 called from outside this function, but that appears to be a bug.
10613 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10614 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10615 (adjust_after_replace_noundo): Remove; unused.
10616 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10617 (signal_before_change): Remove decls.
77382fcc 10618
9306c32e
PE
10619 * indent.c (val_compute_motion, val_vmotion): Now static.
10620
cd44d2eb
PE
10621 * image.c: Make symbols static if they're not exported.
10622 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10623 if USE_GTK.
10624 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10625 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10626
ad9a7a06
PE
10627 * fringe.c (standard_bitmaps): Now static.
10628 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10629
81626931
PE
10630 * frame.c: Make symbols static if they're not exported.
10631 (x_report_frame_params, make_terminal_frame): Now static.
10632 (get_frame_param): Now static, unless HAVE_NS.
10633 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10634 (x_get_resource_string): Remove; not used.
10635 * frame.h (make_terminal_frame, x_report_frame_params):
10636 (x_get_resource_string); Remove decls.
10637 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10638 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10639
239f9db9
PE
10640 * font.c, fontset.c: Make symbols static if they're not exported.
10641 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10642 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10643 * font.c (font_close_object): Now static.
10644 * font.h (font_close_object): Remove.
10645 * fontset.c (FONTSET_OBJLIST): Remove.
10646 (free_realized_fontset) #if-0 the body, which does nothing.
10647 (face_suitable_for_char_p): #if-0, as it's never called.
10648 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10649 * xfaces.c (face_at_string_position):
10650 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10651 since 0 is always ASCII.
10652
dfcf3579
PE
10653 * fns.c (weak_hash_tables): Now static.
10654
5045092b
PE
10655 * fileio.c: Make symbols static if they're not exported.
10656 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10657 (Vwrite_region_annotation_buffers): Now static.
10658
57a96f5c
PE
10659 * eval.c: Make symbols static if they're not exported.
10660 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10661 * lisp.h (backtrace_list): Remove decl.
10662
35f08c38
PE
10663 * emacs.c: Make symbols static if they're not exported.
10664 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10665 (fatal_error_code, fatal_error_signal_hook, standard_args):
10666 Now static.
10667 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10668 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10669 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10670 * lisp.h (fatal_error_signal_hook): Remove decl.
10671 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10672
f44bd759
PE
10673 * editfns.c: Move a (normally-unused) function to its only use.
10674 * editfns.c, lisp.h (get_operating_system_release): Remove.
10675 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10676 worth the hassle of breaking this out.
10677
b532497d
PE
10678 * xterm.c: Make symbols static if they're not exported.
10679 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10680 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10681 (x_destroy_window, x_delete_display):
10682 Now static.
10683 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10684 (x_mouse_leave): Remove; unused.
10685 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10686 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10687 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10688 Remove decls.
10689 (x_mouse_leave): Declare only if WINDOWSNT.
10690 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10691 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10692 USE_X_TOOLKIT.
10693
1675728f
PE
10694 * ftxfont.c: Make symbols static if they're not exported.
10695 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10696 HAVE_FREETYPE.
10697 * font.h (ftxfont_driver): Likewise.
10698
e4cebfca
PE
10699 * xfns.c: Make symbols static if they're not exported.
10700 (x_last_font_name, x_display_info_for_name):
10701 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10702 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10703 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10704 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10705 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10706 (last_show_tip_args): Now static.
10707 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10708 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10709 (x_screen_planes): Remove; unused.
10710 * dispextern.h (x_screen_planes): Remove decl.
10711
5bf46f05
PE
10712 * dispnew.c: Make symbols static if they're not exported.
10713 * dispextern.h (redraw_garbaged_frames, scrolling):
10714 (increment_row_positions): Remove.
10715 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10716 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10717 Now static.
10718 (redraw_garbaged_frames): Remove; unused.
10719
435f4c28
PE
10720 * xfaces.c: Make symbols static if they're not exported.
10721 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10722 Remove decls.
10723 * xterm.h (defined_color): Remove decls.
10724 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10725 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10726 (menu_face_changed_default, defined_color, free_realized_face):
10727 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10728 (ascii_face_of_lisp_face): Remove; unused.
10729
8524aef3
PE
10730 * xdisp.c: Make symbols static if they're not exported.
10731 * dispextern.h (scratch_glyph_row, window_box_edges):
10732 (glyph_to_pixel_coords, set_cursor_from_row):
10733 (get_next_display_element, set_iterator_to_next):
10734 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10735 (show_mouse_face): Remove decls
10736 * frame.h (message_buf_print): Likewise.
10737 * lisp.h (pop_message, set_message, check_point_in_composition):
10738 Likewise.
10739 * xterm.h (set_vertical_scroll_bar): Likewise.
10740 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10741 (message_buf_print, scratch_glyph_row, displayed_buffer):
10742 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10743 (get_next_display_element, show_mouse_face, window_box_edges):
10744 (frame_to_window_pixel_xy, check_point_in_composition):
10745 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10746 (glyph_to_pixel_coords): Remove; unused.
10747
16390cd2
PE
10748 * dired.c (file_name_completion): Now static.
10749
10750 * dbusbind.c (xd_in_read_queued_messages): Now static.
10751
a25f4dfa
PE
10752 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10753 * data.c (circular_list_error): Remove.
10754
14a9c8df
PE
10755 * commands.h (last_point_position, last_point_position_buffer):
10756 (last_point_position_window): Remove decls.
10757 * keyboard.c: Make these variables static.
10758
04f2d78b
CB
10759 * coding.h (coding, code_convert_region, encode_coding_gap):
10760 Remove decls.
74ab6df5
PE
10761 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10762 (iso_code_class, detect_coding, code_convert_region): Now static.
10763 (encode_coding_gap): Remove; unused.
10764
38dfbee1
PE
10765 * chartab.c (chartab_chars, chartab_bits): Now static.
10766
a2cb4e63
PE
10767 * charset.h (charset_iso_8859_1): Remove decl.
10768 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10769 Now static.
10770
127198fd
PE
10771 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10772 * ccl.c (Vccl_program_table): Now static.
10773 (check_ccl_update): Remove; unused.
10774
d85b608f
PE
10775 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10776 * category.h: ... from here.
10777 * category.c (check_category_table, set_category_set): Now static.
10778
31cd66f3
PE
10779 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10780 * lisp.h: Remove these decls.
10781
c358e587
PE
10782 * buffer.c (buffer_count): Remove unused var.
10783
e78aecca
PE
10784 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10785 so that it's not optimized away.
10786 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10787 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10788 exported only to the debugger.
10789
e192d7d3 10790 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10791 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10792
92470028
PE
10793 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10794 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10795 was inaccessible from Lisp.
10796 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10797 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10798
244ed907
PE
10799 alloc.c: Import and export fewer symbols, and remove unused items.
10800 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10801 is defined.
10802 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10803 it's not optimized away by whole-program optimization.
10804 (message_enable_multibyte, free_misc): Remove.
10805 (catchlist, handlerlist, mark_backtrace):
10806 Declare only if BYTE_MARK_STACK.
10807 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10808 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10809 (message_enable_multibyte): Remove decl.
10810 (free_misc, interval_free_list, float_block, float_block_index):
10811 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10812 (cons_free_list, last_marked_index):
10813 Now static.
10814 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10815 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10816 (mark_backtrace): Define only if BYTE_MARK_STACK.
10817 * xdisp.c (message_enable_multibyte): Now static.
10818
61c2b50e 10819 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10820 This makes it easier for human readers (and static analyzers)
10821 to see whether these variables are used from other modules.
10822 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10823 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10824 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10825 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10826 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10827 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10828 * xmenu.c, xselect.c:
10829 Declare Q* vars static if they are not used in other modules.
10830 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10831 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10832 Remove decls of unexported vars.
10833 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10834
95c82688
PE
10835 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10836
16a97296
PE
10837 Make Emacs functions such as Fatom 'static' by default.
10838 This makes it easier for human readers (and static analyzers)
10839 to see whether these functions can be called from other modules.
10840 DEFUN now defines a static function. To make the function external
10841 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10842 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10843 (Finit_image_library):
16a97296
PE
10844 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10845 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10846 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10847 Remove decls, since these functions are now static.
10848 (Funintern, Fget_internal_run_time): New decls, since these functions
10849 were already external.
95c82688 10850
16a97296
PE
10851 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10852 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10853 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10854 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10855 * keyboard.c, keymap.c, lread.c:
10856 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10857 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10858 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10859 Mark functions with DEFUE instead of DEFUN,
10860 if they are used in other modules.
10861 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10862 decls for now-static functions.
10863 * buffer.h (Fdelete_overlay): Remove decl.
10864 * callproc.c (Fgetenv_internal): Mark as internal.
10865 * composite.c (Fremove_list_of_text_properties): Remove decl.
10866 (Fcomposition_get_gstring): New forward static decl.
10867 * composite.h (Fcomposite_get_gstring): Remove decl.
10868 * dired.c (Ffile_attributes): New forward static decl.
10869 * doc.c (Fdocumntation_property): New forward static decl.
10870 * eval.c (Ffetch_bytecode): New forward static decl.
10871 (Funintern): Remove extern decl; now in .h file where it belongs.
10872 * fileio.c (Fmake_symbolic_link): New forward static decl.
10873 * image.c (Finit_image_library): New forward static decl.
10874 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10875 * intervals.h (Fprevious_property_change):
10876 (Fremove_list_of_text_properties): Remove decls.
10877 * keyboard.c (Fthis_command_keys): Remove decl.
10878 (Fcommand_execute): New forward static decl.
10879 * keymap.c (Flookup_key): New forward static decl.
10880 (Fcopy_keymap): Now static.
10881 * keymap.h (Flookup_key): Remove decl.
10882 * process.c (Fget_process): New forward static decl.
10883 (Fprocess_datagram_address): Mark as internal.
10884 * syntax.c (Fsyntax_table_p): New forward static decl.
10885 (skip_chars): Remove duplicate decl.
10886 * textprop.c (Fprevious_property_change): New forward static decl.
10887 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10888 Now internal.
10889 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10890 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10891
785bbd42
PE
10892 * editfns.c (Fformat): Remove unreachable code.
10893
8b913b57
AS
108942011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10895
10896 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10897 change. (Bug#8496)
10898
a6744a35
EZ
108992011-04-13 Eli Zaretskii <eliz@gnu.org>
10900
10901 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10902 when at ZV. (Bug#8487)
10903
e7974947
AS
109042011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10905
baad03f0
AS
10906 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10907 (Bug#8437)
10908 * keyboard.c (parse_tool_bar_item): Likewise.
10909 * sound.c (sound_cleanup, alsa_close): Likewise.
10910 * termcap.c (tgetent): Likewise.
10911 * xfns.c (x_default_font_parameter): Likewise.
10912 * xsettings.c (read_and_apply_settings): Likewise.
10913
e7974947
AS
10914 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10915 (overrun_check_free): Protoize.
10916
28272684
PE
109172011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10918
10919 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10920 since callers should never pass a negative size.
10921 Change the signature to match that of plain 'read' and 'write'; see
10922 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10923 * lisp.h: Update prototypes of emacs_write and emacs_read.
10924
11997c76
EZ
109252011-04-11 Eli Zaretskii <eliz@gnu.org>
10926
10927 * xdisp.c (redisplay_window): Don't try to determine the character
10928 position of the scroll margin if the window start point w->startp
e896f03c 10929 is outside the buffer's accessible region. (Bug#8468)
11997c76 10930
8a2cbd72
EZ
109312011-04-10 Eli Zaretskii <eliz@gnu.org>
10932
10933 Fix write-region and its subroutines for buffers > 2GB.
10934 * fileio.c (a_write, e_write): Modify declaration of arguments and
10935 local variables to support buffers larger than 2GB.
10936 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10937
10938 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10939 argument, local variables, and return value.
10940
10941 * lisp.h: Update prototypes of emacs_write and emacs_read.
10942
10943 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10944
4073e537 109452011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10946
1ebfdcb6
PE
10947 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10948
b2ded58d
PE
10949 Fix more problems found by GCC 4.6.0's static checks.
10950
7d66342c
PE
10951 * xdisp.c (vmessage): Use a better test for character truncation.
10952
bbf47d44
PE
10953 * charset.c (load_charset_map): <, not <=, for optimization,
10954 and to avoid potential problems with integer overflow.
9248994d 10955 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10956 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10957 * editfns.c (Fformat): Likewise.
1e69125e 10958 * syntax.c (skip_chars): Likewise.
3befa583 10959
e3019616
PE
10960 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10961 This also lets GCC 4.6.0 generate slightly better loop code.
10962
becfa255
PE
10963 * callint.c (Fcall_interactively): <, not <=, for optimization.
10964 (Fcall_interactively): Count the number of arguments produced,
10965 not the number of arguments given. This is simpler and lets GCC
10966 4.6.0 generate slightly better code.
10967
dae0cd48
PE
10968 * ftfont.c: Distingish more carefully between FcChar8 and char.
10969 The previous code passed unsigned char * to a functions like
10970 strlen and xstrcasecmp that expect char *, which does not
10971 conform to the C standard.
10972 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10973 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10974 char * when the C standard requires it.
10975
76032d70
PE
10976 * keyboard.c (read_char): Remove unused var.
10977
eb3f1cc8
PE
10978 * eval.c: Port to Windows vsnprintf (Bug#8435).
10979 Include <limits.h>.
10980 (SIZE_MAX): Define if the headers do not.
10981 (verror): Do not give up if vsnprintf returns a negative count.
10982 Instead, grow the buffer. This ports to Windows vsnprintf, which
10983 does not conform to C99. Problem reported by Eli Zaretskii.
10984 Also, simplify the allocation scheme, by avoiding the need for
10985 calling realloc, and removing the ALLOCATED variable.
10986
70476b54
PE
10987 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10988
12020a9e
PE
10989 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10990 But keep the doprint source code for now, as we might revamp it
10991 and use it again (Bug#8435).
ea6c7ae6
PE
10992 * lisp.h (doprnt): Remove.
10993 * Makefile.in (base_obj): Remove doprnt.o.
10994 * deps.mk (doprnt.o): Remove.
10995
5fdb398c
PE
10996 error: Print 32- and 64-bit integers portably (Bug#8435).
10997 Without this change, on typical 64-bit hosts error ("...%d...", N)
10998 was used to print both 32- and 64-bit integers N, which relied on
10999 undefined behavior.
61bdb816 11000 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11001 * lisp.h (error, verror): Mark as printf-like functions.
11002 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11003 Report overflow in size calculations when allocating printf buffer.
11004 Do not truncate output string at its first null byte.
11005 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11006 Truncate the output at a character boundary, since vsnprintf does not
11007 do that.
11008 * charset.c (check_iso_charset_parameter): Convert internal
11009 character to string before calling 'error', since %c now has the
11010 printf meaning.
11011 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11012 overflow when computing char to be passed to 'error'. Do not
11013 pass Lisp_Object to 'error'; pass the integer instead.
11014 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11015 formatted with plain %d.
11016
b189fa66
PE
11017 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11018
bff87ef0
PE
11019 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11020
7e2cac20
PE
11021 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11022
ce4d90b5
PE
11023 * xterm.c (x_catch_errors): Remove duplicate declaration.
11024
266c9547
PE
11025 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11026
79c49ad2
PE
11027 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11028
368f4090
JM
110292011-04-10 Jim Meyering <meyering@redhat.com>
11030
11031 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11032 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11033 return ssize_t not "int", and use size_t as the buffer length.
11034 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11035 * gnutls.h: Update declarations.
11036 * process.c (read_process_output): Use ssize_t, to match.
11037 (send_process): Likewise.
11038
a32d4040
CY
110392011-04-09 Chong Yidong <cyd@stupidchicken.com>
11040
11041 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11042
8546720e 110432011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11044
04f2d78b
CB
11045 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11046 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11047
8546720e
GM
11048 * xterm.c (handle_one_xevent):
11049 * xmenu.c (create_and_show_popup_menu):
11050 * xselect.c (x_decline_selection_request)
11051 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11052
0a2f5c1a 110532011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11054
11055 Fix some uses of `int' instead of EMACS_INT.
11056 * search.c (string_match_1, fast_string_match)
11057 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11058 (scan_buffer, find_next_newline_no_quit)
11059 (find_before_next_newline, search_command, Freplace_match)
11060 (Fmatch_data): Make some `int' variables be EMACS_INT.
11061
11062 * xdisp.c (display_count_lines): 3rd argument and return value now
11063 EMACS_INT. All callers changed.
11064 (pint2hrstr): Last argument is now EMACS_INT.
11065
11066 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11067 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11068 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11069 (decode_coding_utf_16, decode_coding_emacs_mule)
11070 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11071 (decode_coding_ccl, decode_coding_charset)
11072 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11073 (decode_coding_iso_2022, decode_coding_emacs_mule)
11074 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11075 <char_offset, last_offset>: Declare EMACS_INT.
11076 (encode_coding_utf_8, encode_coding_utf_16)
11077 (encode_coding_emacs_mule, encode_invocation_designation)
11078 (encode_designation_at_bol, encode_coding_iso_2022)
11079 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11080 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11081 Declare EMACS_INT.
11082 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11083 (encode_invocation_designation): Last argument P_NCHARS is now
11084 EMACS_INT.
11085 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11086 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11087
11088 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11089 All users changed.
11090
11091 * ccl.c (Fccl_execute_on_string): Declare some variables
11092 EMACS_INT.
11093
8546720e 110942011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11095
11096 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11097
4e19a977
CS
110982011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11099
11100 * process.c (Fformat_network_address): Doc fix.
11101
87302331
R
111022011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11103
ee7683eb 11104 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11105
cbb59342
CY
111062011-04-08 Chong Yidong <cyd@stupidchicken.com>
11107
11108 * keyboard.c (read_char): Call Lisp function help-form-show,
11109 instead of using internal_with_output_to_temp_buffer.
11110 (Qhelp_form_show): New var.
e0d38eeb 11111 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11112
11113 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11114
11115 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11116
e67a13ab
CY
111172011-04-06 Chong Yidong <cyd@stupidchicken.com>
11118
04f2d78b
CB
11119 * process.c (Flist_processes): Remove to Lisp.
11120 (list_processes_1): Delete.
e67a13ab 11121
973f782d
EZ
111222011-04-06 Eli Zaretskii <eliz@gnu.org>
11123
7c106b1e
EZ
11124 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11125
973f782d
EZ
11126 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11127
41cf7d1a 111282011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11129
ca23cc88
PE
11130 Fix more problems found by GCC 4.6.0's static checks.
11131
f390e2d5
PE
11132 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11133
42eea0d0
PE
11134 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11135
b69769da 11136 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11137
f9541e84
PE
11138 * xdisp.c (vmessage): Mark as a printf-like function.
11139
13841b55
PE
11140 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11141
c136c10f
PE
11142 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11143
5e2d4a30
PE
11144 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11145 printf-like functions.
11146 (tiff_load): Add casts to remove these marks before passing them
11147 to system-supplied API.
11148
583f48b9
PE
11149 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11150
b25d760e
PE
11151 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11152 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11153 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11154 directly, rather than having caller test rule sign. This avoids
11155 some unnecessary tests.
11156 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11157 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11158 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11159
bc7b6697 11160 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11161 (xfont_open): Avoid unnecessary tests.
bc7b6697 11162
27ccc379
PE
11163 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11164
dcd5c89a
PE
11165 * composite.h, composite.c (composition_gstring_put_cache):
11166 Use EMACS_INT, not int, for length.
11167
b13a45c6
PE
11168 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11169 breaking out part of COMPOSITION_DECODE_RULE.
11170 (COMPOSITION_DECODE_RULE): Use it.
11171 * composite.c (get_composition_id): Remove unused local vars,
11172 by using the new macro.
11173
1e792e4d
PE
11174 * textprop.c (set_text_properties_1): Change while to do-while,
11175 since the condition is always true at first.
11176
dc6c6455 11177 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11178 (interval_deletion_adjustment): Return unsigned value.
11179 All uses changed.
dc6c6455 11180
aba7731a
PE
11181 * process.c (list_processes_1, create_pty, read_process_output):
11182 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11183 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11184 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11185 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11186 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11187
fdfc4bf3
PE
11188 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11189
fca8fe46 11190 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11191 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11192
06a0259a 11193 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11194 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11195 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11196
e7b9e80f
PE
11197 * print.c (print_error_message): Avoid int overflow.
11198
56201685
PE
11199 * font.c (font_list_entities): Redo for clarity,
11200 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11201
78834453 11202 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11203 (font_score): Avoid potential overflow in diff calculation.
78834453 11204
0bc0b309 11205 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11206 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11207
e610eaca
PE
11208 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11209
b895abce
PE
11210 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11211 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11212 can always succeed if overflow has undefined behavior.
11213
1f1d9321 11214 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11215 (wordify): Omit three unnecessary tests.
1f1d9321 11216
c59478bc
PE
11217 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11218 All callers changed. This avoids the need for an unused var.
11219
79b73827
PE
11220 * casefiddle.c (casify_region): Remove var that is set but not used.
11221
a4db5dfe
PE
11222 * dired.c (file_name_completion): Remove var that is set but not used.
11223
43aae36e
PE
11224 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11225
2a47c44d 11226 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11227 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11228
a37c69bf
PE
11229 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11230 Check for integer overflow on size calculations.
11231
328ab8e7
PE
11232 * buffer.c (Fprevious_overlay_change): Remove var that is set
11233 but not used.
11234
e5a2a5cb
PE
11235 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11236 Remove vars that are set but not used.
8d84a6eb 11237 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11238 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11239
a60e5f68
PE
11240 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11241
f661cb61 11242 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11243 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11244
f0397f5a
PE
11245 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11246 that are set but not used.
11247
8664db06 11248 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11249 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11250
6abdaa4a
PE
11251 * xselect.c (x_get_local_selection, x_handle_property_notify):
11252 Remove vars that are set but not used.
11253
0ce7538d 11254 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11255 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11256
9ae848fc
PE
11257 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11258 Remove var that is set but not used.
0b918413
PE
11259 (scroll_bar_windows_size): Now size_t, not int.
11260 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11261 Check for overflow.
9ae848fc 11262
a5a62657
PE
11263 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11264 (map_tty_color) [!defined MSDOS]: Likewise.
11265
5c5cdd39
PE
11266 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11267
66ebf983
PE
11268 * coding.c: Remove vars that are set but not used.
11269 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11270 All callers changed.
11271 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11272 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11273 (decode_coding_charset): Remove vars that are set but not used.
11274
1be4d761
PE
11275 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11276 that is set but not used.
11277
47553fa8
PE
11278 * print.c (print_object): Remove var that is set but not used.
11279
1f7196bf 11280 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11281 The gnulib version avoids calling malloc in the usual case,
11282 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11283 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11284 * filelock.c (current_lock_owner): Likewise.
11285 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11286 * sysdep.c: Include allocator.h, careadlinkat.h.
11287 (emacs_no_realloc_allocator): New static constant.
11288 (emacs_readlink): New function.
fdb61804
PE
11289 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11290 ../lib/careadlinkat.h.
d1fdcab7 11291
f84c17c7
SM
112922011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11293
11294 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11295 first non-nil return value).
11296
ef3862ad
JD
112972011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11298
11299 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11300 if not defined (Bug#8403).
11301
376a7006
JB
113022011-04-02 Juanma Barranquero <lekktu@gmail.com>
11303
11304 * xdisp.c (display_count_lines): Remove parameter `start',
11305 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11306 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11307 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11308 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11309 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11310 and thereabouts. All callers changed.
11311 (get_per_char_metric): Remove parameter `f', unused since
11312 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11313
6ca3801d
JM
113142011-04-02 Jim Meyering <meyering@redhat.com>
11315
11316 do not dereference NULL upon failed strdup
11317 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11318 (ns_get_family): Likewise.
11319
d8e2b5ba
JB
113202011-04-02 Juanma Barranquero <lekktu@gmail.com>
11321
11322 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11323
8c74fcbd
JD
113242011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11325
11326 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11327 later (Bug#8403).
11328
7200d79c
SM
113292011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11330
03408648 11331 Add lexical binding.
7200d79c 11332
03408648
SM
11333 * window.c (Ftemp_output_buffer_show): New fun.
11334 (Fsave_window_excursion):
11335 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11336
11337 * lread.c (lisp_file_lexically_bound_p): New function.
11338 (Fload): Bind Qlexical_binding.
11339 (readevalloop): Remove `evalfun' arg.
11340 Bind Qinternal_interpreter_environment.
11341 (Feval_buffer): Bind Qlexical_binding.
11342 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11343 Mark as dynamic.
11344 (syms_of_lread): Declare `lexical-binding'.
11345
11346 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11347
11348 * keyboard.c (eval_dyn): New fun.
11349 (menu_item_eval_property): Use it.
ca105506
SM
11350
11351 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11352
03408648
SM
11353 * fns.c (concat, mapcar1): Accept byte-code-functions.
11354
11355 * eval.c (Fsetq): Handle lexical vars.
11356 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11357 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11358 (FletX, Flet): Obey lexical binding.
11359 (Fcommandp): Handle closures.
11360 (Feval): New `lexical' arg.
11361 (eval_sub): New function extracted from Feval. Use it almost
11362 everywhere where Feval was used. Look up vars in lexical env.
11363 Handle closures.
11364 (Ffunctionp): Move from subr.el.
11365 (Ffuncall): Handle closures.
11366 (apply_lambda): Remove `eval_flags'.
11367 (funcall_lambda): Handle closures and new byte-code-functions.
11368 (Fspecial_variable_p): New function.
11369 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11370 but without exporting it to Lisp.
23aba0ea 11371
23aba0ea 11372 * doc.c (Fdocumentation, store_function_docstring):
03408648 11373 * data.c (Finteractive_form): Handle closures.
23aba0ea 11374
03408648
SM
11375 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11376 interactive spec.
ba83908c 11377
04f2d78b
CB
11378 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11379 New byte-codes.
03408648
SM
11380 (exec_byte_code): New function extracted from Fbyte_code to handle new
11381 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11382
03408648 11383 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11384
03408648 11385 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11386
e2abce01
JB
113872011-03-31 Juanma Barranquero <lekktu@gmail.com>
11388
11389 * xdisp.c (redisplay_internal): Fix prototype.
11390
63696a73 113912011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11392
63696a73 11393 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11394 (try_scrolling): Use it when setting scroll_limit.
11395 Limit scrolling to 100 screen lines.
63696a73
EZ
11396 (redisplay_window): Even when falling back on "recentering",
11397 position point in the window according to scroll-conservatively,
11398 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11399
11400 (try_scrolling): When point is above the window, allow searching
11401 as far as scroll_max, or one screenful, to compute vertical
11402 distance from PT to the scroll margin position. This prevents
11403 try_scrolling from unnecessarily failing when
11404 scroll-conservatively is set to a value slightly larger than the
11405 window height. Clean up the case of PT below the margin at bottom
11406 of window: scroll_max can no longer be INT_MAX. When aggressive
11407 scrolling is in use, don't let point enter the opposite scroll
11408 margin as result of the scroll.
11409 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11410 threshold of 100 lines for never-recentering scrolling.
11411
e4cc2dfc
JB
114122011-03-31 Juanma Barranquero <lekktu@gmail.com>
11413
11414 * dispextern.h (move_it_by_lines):
11415 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11416 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11417 (message_log_check_duplicate): Remove parameters `prev_bol' and
11418 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11419 (redisplay_internal): Remove parameter `preserve_echo_area',
11420 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11421
11422 * indent.c (Fvertical_motion):
11423 * window.c (window_scroll_pixel_based, Frecenter):
11424 Don't pass `need_y_p' to `move_it_by_lines'.
11425
1c470562
SM
114262011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11427
44f230aa
SM
11428 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11429 steal a few bits to be more compact.
11430 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11431 Remove unneeded casts.
11432
1c470562
SM
11433 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11434
888adce9
ZK
114352011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11436
11437 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11438 binding" message (bug#7967).
11439
f838ed7b
PE
114402011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11441
77861b95
PE
11442 Fix more problems found by GCC 4.6.0's static checks.
11443
de6dbc14
PE
11444 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11445 Remove unused local var.
11446
f838ed7b
PE
11447 * editfns.c (Fmessage_box): Remove unused local var.
11448
792c7b2b
PE
11449 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11450 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11451 Omit unused local vars.
c499e557 11452 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11453 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11454 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11455 Omit unused local var.
11456
ba0165e1
PE
11457 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11458 Don't assume string length fits in int.
32ad8845 11459 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11460 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11461
3c59b4c9
PE
11462 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11463 instead of alloca (Bug#8344).
11464
a3eed478 11465 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11466 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11467
eb4d412d
PE
11468 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11469
1658b401
PE
11470 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11471 concerns.
11472
11473 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11474
11475 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11476
9a2c6e05
PE
11477 * keyboard.c (syms_of_keyboard): Use the same style as later
11478 in this function when indexing through an array. This also
11479 works around GCC bug 48267.
11480
03d0a109
PE
11481 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11482
44f730c8
PE
11483 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11484
fe75f926
PE
11485 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11486 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11487
ffa8c828
PE
11488 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11489 This avoids undefined behavior on integer overflow, and is a bit
11490 more convenient anyway since it is compared to a size_t variable.
11491
c5101a77
PE
11492 Variadic C functions now count arguments with size_t, not int.
11493 This avoids an unnecessary limitation on 64-bit machines, which
11494 caused (substring ...) to crash on large vectors (Bug#8344).
11495 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11496 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11497 All variadic functions and their callers changed accordingly.
c5101a77
PE
11498 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11499 * data.c (arith_driver, float_arith_driver): Likewise.
11500 * editfns.c (general_insert_function): Likewise.
11501 * eval.c (struct backtrace.nargs, interactive_p)
11502 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11503 (funcall_lambda, mark_backtrace): Likewise.
11504 * fns.c (concat): Likewise.
11505 * frame.c (x_set_frame_parameters): Likewise.
11506 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11507 0 if not found, not -1. All callers changed.
11508
dd3f25f7
PE
11509 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11510 (stack_copy_size): Now size_t, not int.
11511 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11512
461c2ab9
JB
115132011-03-28 Juanma Barranquero <lekktu@gmail.com>
11514
11515 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11516 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11517 All callers changed.
11518
11519 * lisp.h (multibyte_char_to_unibyte):
11520 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11521 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11522 * character.h (CHAR_TO_BYTE8):
11523 * cmds.c (internal_self_insert):
11524 * editfns.c (general_insert_function):
11525 * keymap.c (push_key_description):
11526 * search.c (Freplace_match):
11527 * xdisp.c (message_dolog, set_message_1): All callers changed.
11528
f6d62986
SM
115292011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11530
11531 * keyboard.c (safe_run_hook_funcall): New function.
11532 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11533 don't set the hook to nil, but remove the offending function instead.
11534 (Qcommand_hook_internal): Remove, unused.
11535 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11536 Vcommand_hook_internal.
11537
11538 * eval.c (enum run_hooks_condition): Remove.
11539 (funcall_nil, funcall_not): New functions.
11540 (run_hook_with_args): Call each function through a `funcall' argument.
11541 Remove `cond' argument, now redundant.
11542 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11543 (Frun_hook_with_args_until_failure): Adjust accordingly.
11544 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11545
1db5b1ad
JB
115462011-03-28 Juanma Barranquero <lekktu@gmail.com>
11547
11548 * dispextern.h (string_buffer_position): Remove declaration.
11549
11550 * print.c (strout): Remove parameter `multibyte', unused since
11551 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11552
11553 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11554 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11555 All callers changed.
11556
11557 * w32.c (_wsa_errlist): Use braces for struct initializers.
11558
11559 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11560 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11561 All callers changed.
11562 (string_buffer_position): Likewise. Also, make static (it's never
11563 used outside xdisp.c).
11564 (cursor_row_p): Remove parameter `w', unused since
11565 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11566 (decode_mode_spec): Remove parameter `precision', introduced during
11567 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11568 All callers changed.
11569
5ffb62aa
JD
115702011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11571
11572 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11573
461c2ab9 115742011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11575
11576 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11577 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11578 (ns_update_auto_hide_menu_bar): New functions.
11579 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11580 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11581 ns_constrain_all_frames.
11582 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11583 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11584
5c380ffb
JD
115852011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11586
11587 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11588
9af30bdf
GM
115892011-03-27 Glenn Morris <rgm@gnu.org>
11590
11591 * syssignal.h: Replace RETSIGTYPE with void.
11592 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11593 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11594 Replace SIGTYPE with void everywhere.
11595 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11596 * s/template.h (SIGTYPE): Remove commented out definition.
11597
e2abce01
JB
115982011-03-26 Eli Zaretskii <eliz@gnu.org>
11599
11600 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11601 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11602
f868cd8a
JB
116032011-03-26 Juanma Barranquero <lekktu@gmail.com>
11604
59eb0929
JB
11605 * w32.c (read_unc_volume): Use parameter `henum', instead of
11606 global variable `wget_enum_handle'.
11607
11608 * keymap.c (describe_vector): Remove parameters `indices' and
11609 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11610 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11611
f868cd8a
JB
11612 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11613
11614 * keyboard.c (timer_check): Remove parameter `do_it_now',
11615 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11616 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11617 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11618
11619 * keyboard.c (read_char):
11620 * w32menu.c (w32_menu_display_help):
11621 * xmenu.c (show_help_event, menu_help_callback):
11622 Adjust calls to `show_help_echo'.
11623
11624 * gtkutil.c (xg_maybe_add_timer):
11625 * keyboard.c (readable_events):
11626 * process.c (wait_reading_process_output):
11627 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11628
11629 * insdel.c (adjust_markers_gap_motion):
11630 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11631 (gap_left, gap_right): Don't call it.
11632
2ecf6fdb
CY
116332011-03-25 Chong Yidong <cyd@stupidchicken.com>
11634
11635 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11636 incurred during fontification.
11637
6b1f9ba4
JB
116382011-03-25 Juanma Barranquero <lekktu@gmail.com>
11639
11640 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11641 (DEFVAR_PER_BUFFER): Don't pass it.
11642
11643 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11644 (scrolling_window): Don't pass it.
11645
0f4a96b5
JB
116462011-03-25 Juanma Barranquero <lekktu@gmail.com>
11647
11648 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11649
11650 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11651 and `suffix'.
11652 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11653 of variables specific to SELinux and computation of `encoded_absname'.
11654
11655 * image.c (XPutPixel): Remove unused variable `height'.
11656
11657 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11658
11659 * unexw32.c (get_section_info): Remove unused variable `section'.
11660
11661 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11662 (system_process_attributes): Remove unused variable `sess'.
11663 (sys_read): Remove unused variable `err'.
11664
11665 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11666 (w32_wnd_proc): Remove unused variable `isdead'.
11667 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11668 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11669 (x_create_tip_frame): Remove unused variable `tem'.
11670
11671 * w32inevt.c (w32_console_read_socket):
11672 Remove unused variable `no_events'.
11673
11674 * w32term.c (x_draw_composite_glyph_string_foreground):
11675 Remove unused variable `width'.
11676
1149507c
JB
116772011-03-24 Juanma Barranquero <lekktu@gmail.com>
11678
11679 * w32term.c (x_set_glyph_string_clipping):
11680 Don't pass uninitialized region to CombineRgn.
11681
9c88f339
JB
116822011-03-23 Juanma Barranquero <lekktu@gmail.com>
11683
11684 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11685 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11686 (Fx_close_connection): Remove unused variable `i'.
11687
11688 * w32font.c (w32font_draw): Return number of glyphs.
11689 (w32font_open_internal): Remove unused variable `i'.
11690 (w32font_driver): Add missing initializer.
11691
11692 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11693 (fill_in_menu): Remove unused variable `items_added'.
11694
11695 * w32term.c (last_mouse_press_frame): Remove static global variable.
11696 (w32_clip_to_row): Remove unused variable `f'.
11697 (x_delete_terminal): Remove unused variable `i'.
11698
11699 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11700 (NOTHING): Remove unused static global variable.
11701 (uniscribe_check_otf): Remove unused variable `table'.
11702 (uniscribe_font_driver): Add missing initializers.
11703
dee091a3
JD
117042011-03-23 Julien Danjou <julien@danjou.info>
11705
11706 * term.c (Fsuspend_tty, Fresume_tty):
11707 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11708 * window.c (temp_output_buffer_show):
11709 * insdel.c (signal_before_change):
11710 * frame.c (Fhandle_switch_frame):
11711 * fileio.c (Fdo_auto_save):
11712 * emacs.c (Fkill_emacs):
11713 * editfns.c (save_excursion_restore):
11714 * cmds.c (internal_self_insert):
11715 * callint.c (Fcall_interactively):
11716 * buffer.c (Fkill_all_local_variables):
11717 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11718 Use Frun_hooks.
0f4a96b5 11719 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11720 unconditionally since it does the check itself.
dee091a3 11721
2c520ab5 117222011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11723
c9c49752
PE
11724 Fix more problems found by GCC 4.5.2's static checks.
11725
8abc3f12
PE
11726 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11727 the first time through the loop, since we know p0 < p1 then.
11728 This also avoids a gcc -Wstrict-overflow warning.
11729
a2d26660
PE
11730 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11731 leading to a memory leak, possible in functions like
11732 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11733 of objects (Bug#8318).
a2d26660 11734
916c72e9
PE
11735 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11736 that could (at least in theory) be that large.
11737
19ab8a18
PE
11738 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11739 This is less likely to overflow, and avoids undefined behavior if
11740 overflow does occur. All callers changed. Use strtoul to scan
11741 for the unsigned long integer.
b7cbbd6f
PE
11742 (pint2hrstr): Simplify and tune code slightly.
11743 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11744
f0641eff
PE
11745 * scroll.c (do_scrolling): Work around GCC bug 48228.
11746 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11747
7f650bb9
PE
11748 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11749 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11750 (validate_x_resource_name): Simplify count usage.
11751 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11752
37dd57d1
PE
11753 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11754 fail (Bug#8306).
81e56e61 11755
699979fc 11756 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11757
401bf9b4
PE
11758 * process.c (Fmake_network_process): Use socklen_t, not int,
11759 where POSIX says socklen_t is required in portable programs.
11760 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11761 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11762 (Fmake_network_process, server_accept_connection):
11763 (wait_reading_process_output, read_process_output):
11764 Likewise.
11765
b93aacde
PE
11766 * process.c: Rename or move locals to avoid shadowing.
11767 (list_processes_1, Fmake_network_process):
11768 (read_process_output_error_handler, exec_sentinel_error_handler):
11769 Rename or move locals.
4dc343ee 11770 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11771 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11772 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11773 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11774 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11775
af8a867c 11776 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11777 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11778 Include tparam.h instead, since it declares them.
af8a867c
PE
11779 * cm.h (PC): Remove extern decl; tparam.h now does this.
11780 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11781 * terminfo.c: Include tparam.h, to check interfaces.
11782 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11783 (tparam): Adjust signature to match interface in tparam.h;
11784 this removes some undefined behavior. Check that outstring and len
11785 are zero, which they always are with Emacs.
11786 * tparam.h (PC, BC, UP): New extern decls.
11787
0248044d 11788 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11789 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11790
8ff096c1 11791 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11792 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11793 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11794 (ftfont_list): Remove unused local.
49eaafba
PE
11795 (get_adstyle_property, ftfont_pattern_entity):
11796 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11797 Rename locals to avoid shadowing.
8ff096c1 11798
e2be39f6
PE
11799 * xfont.c (xfont_list_family): Mark var as initialized.
11800
c9735e30
PE
11801 * xml.c (make_dom): Now static.
11802
8f5201ae
PE
11803 * composite.c (composition_compute_stop_pos): Rename local to
11804 avoid shadowing.
b246f932
PE
11805 (composition_reseat_it): Remove unused locals.
11806 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11807 (composition_update_it): Mark var as initialized.
11b61122
PE
11808 (find_automatic_composition): Mark vars as initialized,
11809 with a FIXME (Bug#8290).
8f5201ae 11810
760fbc2c
PE
11811 character.h: Rename locals to avoid shadowing.
11812 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11813 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11814 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11815 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11816 to avoid shadowing.
11817
ff08eb85
PE
11818 * textprop.c (property_change_between_p): Remove; unused.
11819
fc7bf025
PE
11820 * intervals.c (interval_start_pos): Now static.
11821
235d7abc
PE
11822 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11823
44f230aa
SM
11824 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11825 Rename locals to avoid shadowing.
3e7d6594 11826
50060332
PE
11827 * sound.c (wav_play, au_play, Fplay_sound_internal):
11828 Fix pointer signedness.
d01f234b 11829 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11830 (wav_play): Initialize a variable to 0, to prevent undefined
11831 behavior (Bug#8278).
50060332 11832
c4fc4e30
PE
11833 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11834
918436ed
PE
11835 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11836
c939f91b
PE
11837 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11838 clobbering (Bug#8298).
b9c7f648
PE
11839 * sysdep.c (sys_subshell): Likewise.
11840 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11841
6bd8c144
PE
11842 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11843 This should get cleaned up, so that child_setup has the
11844 same signature on all platforms.
11845
7710357c 11846 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11847 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11848
c59da222
CY
118492011-03-22 Chong Yidong <cyd@stupidchicken.com>
11850
11851 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11852 not to be necessary, and produces flickering.
11853
66b87493
GM
118542011-03-20 Glenn Morris <rgm@gnu.org>
11855
11856 * config.in: Remove file.
11857
45b6f6d5
JB
118582011-03-20 Juanma Barranquero <lekktu@gmail.com>
11859
11860 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11861 are now in src/globals.h.
11862 (syms_of_minibuf): Remove spurious & from previous change.
11863
cd394be1 118642011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11865
11866 * minibuf.c (completing-read-function): New variable.
11867 (completing-read-default): Rename from completing-read.
11868 (completing-read): Call completing-read-function.
11869
b14e3e21
CY
118702011-03-19 Juanma Barranquero <lekktu@gmail.com>
11871
11872 * xfaces.c (Fx_load_color_file):
11873 Read color file from absolute filename (bug#8250).
11874
f2b726e6
JB
118752011-03-19 Juanma Barranquero <lekktu@gmail.com>
11876
11877 * makefile.w32-in: Update dependencies.
11878
09f6ff02
EZ
118792011-03-17 Eli Zaretskii <eliz@gnu.org>
11880
11881 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11882
29a6015a
PE
118832011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11884
a3a6c54e
PE
11885 Fix more problems found by GCC 4.5.2's static checks.
11886
b766f867
PE
11887 * process.c (make_serial_process_unwind, send_process_trap):
11888 (sigchld_handler): Now static.
11889
be02381c
PE
11890 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11891 That way, the code declares only the vars that it needs.
11892 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11893 * s/cygwin.h (PTY_ITERATION): Likewise.
11894 * s/darwin.h (PTY_ITERATION): Likewise.
11895 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11896
57048744
PE
11897 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11898 * process.c (allocate_pty): Don't declare stb unless it's needed.
11899
7914961c 11900 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11901 (CONSTANTLIM): Remove; unused.
11902 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11903 Define only if needed.
7914961c 11904
b3967b18
PE
11905 * unexelf.c (unexec): Name an expression,
11906 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11907 Use a different way to cause a compilation error if anyone uses
11908 n rather than nn, a way that does not involve shadowing.
73366a00 11909 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11910
29a6015a
PE
11911 * deps.mk (unexalpha.o): Remove; unused.
11912
43cfc33e 11913 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11914 * unexec.h: New file.
ce701a33
PE
11915 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11916 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11917 Depend on unexec.h.
11918 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11919 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11920 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11921 Change as necessary to match prototype in unexec.h.
ce701a33 11922
01f44d5a
PE
11923 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11924 shadowing.
4f63c6bb 11925 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11926
a6670b0b
PE
11927 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11928 Rename locals to avoid shadowing.
11929
cef2010d 11930 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11931 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11932
d4d7173a
PE
11933 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11934
f08b802a
PE
11935 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11936 warning when compiling print.c.
11937
3ddb0639
PE
11938 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11939 instead of using an uninitialized var.
5ad03b97 11940 (font_sort_entities): Mark var as initialized.
3ddb0639 11941
170a2692
PE
11942 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11943
e663c700
PE
11944 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11945 pointers to constants.
89bc529a 11946 (font_parse_fcname): Remove unused vars.
7b81e2d0 11947 (font_delete_unmatched): Now static.
ea838e10 11948 (font_get_spec): Remove; unused.
13a547c6
PE
11949 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11950 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11951 Rename or move locals to avoid shadowing.
e663c700 11952
2a80c887 11953 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11954 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11955
1384fa33 11956 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11957 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11958
8b2c52e9
PE
11959 * alloc.c (mark_backtrace): Move decl from here ...
11960 * lisp.h: ... to here, so that it can be checked.
11961
475545b5 11962 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11963 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11964 (lisp_indirect_variable): Name an expression,
11965 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11966 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11967
b1349114 11968 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11969 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11970 Use const pointer when appropriate.
b1349114 11971
a2928364
PE
11972 * lisp.h (get_system_name, get_operating_system_release):
11973 Move decls here, to check interfaces.
11974 * process.c (get_operating_system_release): Move decl to lisp.h.
11975 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11976 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11977 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11978 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11979 (Fformat_time_string, Fencode_time, Finsert_char):
11980 (Ftranslate_region_internal, Fformat):
11981 Rename or remove local vars to avoid shadowing.
9710023e 11982 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11983
a415e694
PE
11984 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11985 avoid shadowing.
11986
8ef4622d
PE
11987 * lisp.h (eassert): Check that the argument compiles, even if
11988 ENABLE_CHECKING is not defined.
11989
946f9a5b
PE
11990 * data.c (Findirect_variable): Name an expression, to avoid
11991 gcc -Wbad-function-cast warning.
112396d6 11992 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11993 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11994 (Fmake_variable_buffer_local, Fmake_local_variable):
11995 Mark variables as initialized.
52746918 11996 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11997
e5aab7e7 11998 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11999 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12000 Rename locals to avoid shadowing.
dff45157
PE
12001 (mark_stack): Move local variables into the #ifdef region where
12002 they're used.
7bc26fdb
PE
12003 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12004 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12005 needed otherwise.
12006 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12007 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12008 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12009
e5aab7e7
PE
12010 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12011 avoids undefined behavior in theory.
12012
4da60324
PE
12013 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12014
88043301
PE
12015 Use functions, not macros, for up- and down-casing (Bug#8254).
12016 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12017 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12018 to use the following functions instead of these macros.
12019 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12020 EMACS_INT, since callers assume the returned value fits in int.
12021 (upcase1): Likewise, for UPCASE_TABLE.
12022 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12023 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12024 the race-condition problem in the old DOWNCASE.
88043301 12025
19ed5445
PE
12026 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12027 Rename locals to avoid shadowing.
12028 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12029 (regex_compile, re_search_2, re_match_2_internal):
12030 Remove unused local vars.
952db0d7
PE
12031 (FREE_VAR): Rewrite so as not to use empty "else",
12032 which gcc can warn about.
da053e48 12033 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12034 (RETALLOC_IF): Define only if needed.
12035 (WORDCHAR_P): Likewise. This one is never needed, but is used
12036 only in a comment talking about a compiler bug, so put inside
12037 the #if 0 of that comment.
12038 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12039 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12040 Remove; unused.
19ed5445 12041
1f3561e4 12042 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12043 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12044 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12045
ded6f8f7
PE
12046 * search.c (simple_search): Remove unused var.
12047
dbd37a95
PE
12048 * dired.c (compile_pattern): Move decl from here ...
12049 * lisp.h: ... to here, so that it can be checked.
12050 (struct re_registers): New forward decl.
12051
7e47afad
PE
12052 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12053
85f24f61
PE
12054 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12055 All uses changed.
12056 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12057 Rename locals to avoid shadowing.
5671df8f 12058 (Fvertical_motion): Mark locals as initialized.
85f24f61 12059
181aa2be 12060 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12061 (casify_region): Mark local as initialized.
181aa2be 12062
930d429c
PE
12063 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12064
7082eac6
PE
12065 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12066 New macros, so that the caller can use some names other than
12067 gcpro1, gcpro2, etc.
12068 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12069 of the new macros.
12070 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12071 argument, for consistency with GCPRO2_VAR, etc: it is now the
12072 prefix of the variable, not the variable itself. All uses
12073 changed.
38b2c076
PE
12074 * dired.c (directory_files_internal, file_name_completion):
12075 Rename locals to avoid shadowing.
12076
15206ed9
PE
12077 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12078 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12079 dired.c's scmp function, had undefined behavior.
12080 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12081 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12082 * buffer.h: ... to here, because these macros use current_buffer,
12083 and the new implementation with inline functions needs to have
12084 current_buffer in scope now, rather than later when the macros
12085 are used.
12086 (downcase, upcase1): New static inline functions.
12087 (DOWNCASE, UPCASE1): Reimplement using these functions.
12088 This avoids undefined behavior in expressions like
12089 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12090 from race conditions in accessing the global variables
12091 case_temp1 and case_temp2.
12092 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12093 * lisp.h (case_temp1, case_temp2): Remove their decls.
12094 * character.h (ASCII_CHAR_P): Move from here ...
12095 * lisp.h: ... to here, so that the inline functions mentioned
12096 above can use them.
12097
4a6bea26
PE
12098 * dired.c (directory_files_internal_unwind): Now static.
12099
f14b7e14
PE
12100 * fileio.c (file_name_as_directory, directory_file_name):
12101 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12102 Now static.
2893f146
PE
12103 (file_name_as_directory): Use const pointers when appropriate.
12104 (Fexpand_file_name): Likewise. In particular, newdir might
12105 point at constant storage, so make it a const pointer.
fd4ead52 12106 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12107 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12108 signedness issues.
f839df0c
PE
12109 (Fset_file_times, Finsert_file_contents, auto_save_error):
12110 Rename locals to avoid shadowing.
f14b7e14 12111
5716756e 12112 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12113 (Ftry_completion, Fall_completions): Rename or remove locals
12114 to avoid shadowing.
5716756e 12115
b4c3046a
PE
12116 * marker.c (bytepos_to_charpos): Remove; unused.
12117
b45db522
PE
12118 * lisp.h (verify_bytepos, count_markers): New decls,
12119 so that gcc does not warn that these functions aren't declared.
12120
85876d07
PE
12121 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12122 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12123 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12124 (copy_text): Remove unused local var.
85876d07 12125
03d78a21 12126 * filelock.c (within_one_second): Now static.
b3dd38ab 12127 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12128
5df8f01b
PE
12129 * buffer.c (fix_overlays_before): Mark locals as initialized.
12130 (fix_start_end_in_overlays): Likewise. This function should be
12131 simplified by using pointers-to-pointers, but that's a different
12132 matter.
b1d876f1 12133 (switch_to_buffer_1): Now static.
8f54f30a
PE
12134 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12135 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12136
a70072c9 12137 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12138 Fix pointer signedness issue.
edced198
PE
12139 (sys_subshell): Mark local as volatile if checking for lint,
12140 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12141 (MAXPATHLEN): Define only if needed.
a70072c9 12142
a0977c44
PE
12143 * process.c (serial_open, serial_configure): Move decls from here ...
12144 * systty.h: ... to here, so that they can be checked.
12145
a884fdcc
PE
12146 * fns.c (get_random, seed_random): Move extern decls from here ...
12147 * lisp.h: ... to here, so that they can be checked.
12148
604efe86 12149 * sysdep.c (reset_io): Now static.
b8950c94 12150 (wait_for_termination_signal): Remove; unused.
604efe86 12151
38fc62d9
PE
12152 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12153 (copy_keymap_item, append_key, push_text_char_description):
12154 Now static.
1004a21a 12155 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12156 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12157 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12158 (describe_map_tree):
12159 Rename locals to avoid shadowing.
38fc62d9 12160
2f2650da
PE
12161 * keyboard.c: Declare functions static if they are not used elsewhere.
12162 (echo_char, echo_dash, cmd_error, top_level_2):
12163 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12164 (read_char, kbd_buffer_get_event, make_lispy_position):
12165 (make_lispy_event, make_lispy_movement, apply_modifiers):
12166 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12167 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12168 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12169 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12170 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12171
a053e86c 12172 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12173 (mark_kboards): Move decl here ...
12174 * alloc.c (mark_kboards): ... from here.
a053e86c 12175
4752793e
PE
12176 * lisp.h (force_auto_save_soon): New decl.
12177
74f10ca7 12178 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12179 (DEFINE_DUMMY_FUNCTION): New macro.
12180 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12181 Use it.
c03cd23f
PE
12182 (main): Add casts to avoid warnings
12183 if GCC considers string literals to be constants.
74f10ca7 12184
022e70d4
PE
12185 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12186
59d6fe83
PE
12187 * dbusbind.c: Pointer signedness fixes.
12188 (xd_signature, xd_append_arg, xd_initialize):
12189 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12190 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12191 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12192 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12193
78320123
PE
12194 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12195 if GCC considers string literals to be constants.
49cebcca 12196 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12197
35ac2a97
SM
121982011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12199
fb103ca9
SM
12200 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12201 (print_preprocess, print_object): New macro to fix last change.
12202
35ac2a97
SM
12203 * print.c (print_preprocess): Don't forget font objects.
12204
62973b41
JB
122052011-03-16 Juanma Barranquero <lekktu@gmail.com>
12206
12207 * emacs.c (USAGE3): Doc fixes.
12208
0e48bb22
AS
122092011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12210
12211 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12212 structure.
12213
7684e57b
JB
122142011-03-14 Juanma Barranquero <lekktu@gmail.com>
12215
12216 * lisp.h (VWindow_system, Qfile_name_history):
12217 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12218 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12219 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12220
12221 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12222 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12223
12224 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12225 * w32console.c (detect_input_pending, read_input_pending)
12226 (encode_terminal_code):
12227 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12228 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12229 (w32_system_caret_y, Qfile_name_history):
12230 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12231 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12232 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12233 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12234 * w32proc.c (Qlocal, report_file_error):
12235 * w32term.c (Vwindow_system, updating_frame):
12236 * w32uniscribe.c (initialized, uniscribe_font_driver):
12237 Remove unneeded extern declarations.
12238
2aa46d6c
CY
122392011-03-14 Chong Yidong <cyd@stupidchicken.com>
12240
c96bbc66 12241 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12242
cffc6f3b
CY
122432011-03-13 Chong Yidong <cyd@stupidchicken.com>
12244
12245 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12246 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12247 These macros can no longer be used for assignment.
12248
44f230aa
SM
12249 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12250 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12251 (record_buffer_markers, fetch_buffer_markers): New functions for
12252 recording and fetching special buffer markers.
12253 (set_buffer_internal_1, set_buffer_temp): Use them.
12254
12255 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12256
12257 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12258
12259 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12260 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12261
12262 * xdisp.c (hscroll_window_tree):
12263 (reconsider_clip_changes): Use PT instead of BUF_PT.
12264
d251f04b
EZ
122652011-03-13 Eli Zaretskii <eliz@gnu.org>
12266
12267 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12268 $(EMACS_ROOT)/lib/intprops.h.
12269
f0c77cd1
PE
122702011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12271
3eca4629
PE
12272 Fix more problems found by GCC 4.5.2's static checks.
12273
7c86ee98
PE
12274 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12275 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12276 (xg_free_frame_widgets): Make it clear that a local variable is
12277 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12278 (gdk_window_get_screen): Make it clear that this macro is needed
12279 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12280 (int_gtk_range_get_value): New function, which avoids a diagnostic
12281 from gcc -Wbad-function-cast.
12282 (xg_set_toolkit_scroll_bar_thumb): Use it.
12283 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12284 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12285 (get_utf8_string, xg_get_file_with_chooser):
12286 Rename locals to avoid shadowing.
12287 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12288
41729b81
PE
12289 * xgselect.c (xg_select): Remove unused var.
12290
f0c77cd1
PE
12291 * image.c (four_corners_best): Mark locals as initialized.
12292 (gif_load): Initialize transparent_p to zero (Bug#8238).
12293 Mark another local as initialized.
ec6cf4c6 12294 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12295
ce0ad53d 12296 * image.c (clear_image_cache): Now static.
d5d5a617 12297 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12298 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12299 (x_edge_detection): Remove unnecessary cast that
12300 gcc -Wbad-function-cast diagnoses.
2037898d 12301 (gif_load): Fix pointer signedness.
6ae141d6
PE
12302 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12303 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12304
33383987 123052011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12306
d32df629
PE
12307 Improve quality of tests for time stamp overflow.
12308 For example, without this patch (encode-time 0 0 0 1 1
12309 1152921504606846976) returns the obviously-bogus value (-948597
12310 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12311 reports time overflow. See
12312 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12313 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12314 * editfns.c: Include limits.h and intprops.h.
12315 (TIME_T_MIN, TIME_T_MAX): New macros.
12316 (time_overflow): Move earlier, to before first use.
12317 (hi_time, lo_time): New functions, for an accurate test for
12318 out-of-range times.
12319 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12320 (Fget_internal_run_time): Don't assume time_t fits in int.
12321 (make_time): Use list2 instead of Fcons twice.
12322 (Fdecode_time): More accurate test for out-of-range times.
12323 (check_tm_member): New function.
12324 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12325 (lisp_time_argument): Don't rely on undefined left-shift and
12326 right-shift behavior when checking for time stamp overflow.
8be6f318 12327
fe31d94c
PE
12328 * editfns.c (time_overflow): New function, refactoring common code.
12329 (Fformat_time_string, Fdecode_time, Fencode_time):
12330 (Fcurrent_time_string): Use it.
12331
8be6f318
PE
12332 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12333 * dired.c (make_time): Move to ...
12334 * editfns.c (make_time): ... here.
12335 * systime.h: Note the move.
12336
09d9db2c 123372011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12338
126bc0dc
YM
12339 * fringe.c (update_window_fringes): Remove unused variables.
12340
c47cbdfd
YM
12341 * unexmacosx.c (copy_data_segment): Also copy __got section.
12342 (Bug#8223)
12343
7ac80be9
EZ
123442011-03-12 Eli Zaretskii <eliz@gnu.org>
12345
c96bbc66 12346 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12347 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12348 Constify `char *' arguments and their references according to
12349 prototypes in tparam.h.
12350
ecb0f94d 12351 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12352
7ac80be9
EZ
12353 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12354 Adapt all references accordingly.
12355
12356 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12357
ef1fd07e
TT
123582011-03-11 Tom Tromey <tromey@redhat.com>
12359
12360 * buffer.c (syms_of_buffer): Remove obsolete comment.
12361
7ef4b50c
EZ
123622011-03-11 Eli Zaretskii <eliz@gnu.org>
12363
12364 * termhooks.h (encode_terminal_code): Declare prototype.
12365
12366 * msdos.c (encode_terminal_code): Don't declare prototype.
12367
12368 * term.c (encode_terminal_code): Now external again, used by
12369 w32console.c and msdos.c.
12370
44f230aa
SM
12371 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12372 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12373
4b1ec863 123742011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12375
1714f52b 12376 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12377
4b1ec863
PE
12378 * fringe.c (update_window_fringes): Mark locals as initialized
12379 (Bug#8227).
12380 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12381
524c7aa6
PE
12382 * alloc.c (mark_fringe_data): Move decl from here ...
12383 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12384 to check its interface.
12385 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12386
a5c0af81 12387 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12388 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12389 (fontset_font): Mark local as initialized.
a9a06e0b 12390 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12391
b4716021
PE
12392 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12393
811e9bac 12394 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12395 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12396 (x_own_selection, Fx_disown_selection_internal): Rename locals
12397 to avoid shadowing.
12398 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12399
7e3ab302
PE
12400 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12401 so that the caller can use some name other than gcpro1.
12402 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12403 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12404 (Fx_backspace_delete_keys_p):
12405 Use them to avoid shadowing, and rename vars to avoid shadowing.
12406 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12407 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12408 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12409 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12410 Remove unused locals.
7e3ab302
PE
12411 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12412 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12413 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12414 macros.
f78faa98 12415
e2b13473
PE
12416 * xterm.h (x_mouse_leave): New decl.
12417
77f23912
PE
12418 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12419 Remove unused functions.
cdf4ba58
PE
12420 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12421 (x_calc_absolute_position): Now static.
7411c686 12422 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12423 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12424 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12425 unless they are used.
38d0b34a
PE
12426 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12427 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12428 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12429 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12430 (x_error_catcher, x_connection_closed, x_error_handler):
12431 (x_error_quitter, xembed_send_message, x_iconify_frame):
12432 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12433 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12434 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12435
44f230aa
SM
12436 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12437 Rename or move locals to avoid shadowing.
6b463e58 12438 (tty_defined_color, merge_face_heights): Now static.
5967d051 12439 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12440 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12441 does not deduce is never used uninitialized.
73719eba
PE
12442 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12443 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12444
426994c3 12445 * terminal.c (store_terminal_param): Now static.
5489860b 12446
032f1620 12447 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12448 (set_frame_menubar): Remove unused local.
d4323972 12449 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12450 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12451 since they might point to immutable storage.
281585b0
PE
12452 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12453 since it's unused otherwise.
032f1620 12454
367c19e5 12455 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12456 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12457 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12458 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12459 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12460 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12461 does not deduce are never used uninitialized.
70739cbe 12462
07b48fa9
PE
12463 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12464
8868a238 12465 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12466 * window.c (window_loop, size_window):
12467 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12468
7e5cf297 12469 * window.c (display_buffer): Now static.
d6550a9f
PE
12470 (size_window): Mark variables that gcc -Wuninitialized
12471 does not deduce are never used uninitialized.
a586633d
PE
12472 * window.h (check_all_windows): New decl, to forestall
12473 gcc -Wmissing-prototypes diagnostic.
5b555da1 12474 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12475
f6095868
PE
12476 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12477 shadowing.
12478 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12479 Include <limits.h>.
12480 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12481 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12482 (load_charset_map): Mark variables that gcc -Wuninitialized
12483 does not deduce are never used uninitialized.
53df7c11 12484 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12485
f38b440c
PE
12486 * coding.c (coding_set_source, coding_set_destination):
12487 Use "else { /* comment */ }" rather than "else /* comment */;"
12488 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12489 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12490 a block, when the outer 'i' will do.
12491 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12492 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12493 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12494 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12495 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12496 Rename locals to avoid shadowing.
12497 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12498 * coding.c (emacs_mule_char, encode_invocation_designation):
12499 Now static, since they're not used elsewhere.
413bb2db 12500 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12501 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12502 (decode_coding_emacs_mule): Mark variables that gcc
12503 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12504 (detect_coding_iso_2022): Initialize a local variable that might
12505 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12506 this initialization is needed. (Bug#8211)
5f58e762
PE
12507 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12508 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12509 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12510 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12511 Remove unused macros.
f38b440c 12512
232b38b9 12513 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12514 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12515 * character.c (string_count_byte8): Likewise.
232b38b9 12516
fb90da1b
PE
12517 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12518 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12519
fb93dbc2
PE
12520 * chartab.c (copy_sub_char_table): Now static, since it's not used
12521 elsewhere.
5c156ace
PE
12522 (sub_char_table_ref_and_range, char_table_ref_and_range):
12523 Rename locals to avoid shadowing.
bbcd0949 12524 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12525
7d3b3862 12526 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12527 (BIDI_BOB): Remove unused macro.
7d3b3862 12528
6be7d3da
PE
12529 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12530 deduce are never used uninitialized.
c2ed9c8b 12531 * term.c (encode_terminal_code): Likewise.
6be7d3da 12532
75f8807f 12533 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12534
50938595
PE
12535 * tparam.h: New file.
12536 * term.c, tparam.h: Include it.
12537 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12538 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12539 Move these decls to tparam.h, and make them agree with what
12540 is actually in tparam.c. The previous trick of using incompatible
12541 decls in different modules does not conform to the C standard.
12542 All callers of tparam changed to use tparam's actual API.
12543 * tparam.c (tparam1, tparam, tgoto):
12544 Use const pointers where appropriate.
12545
fbceeba2
PE
12546 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12547 * cm.h (struct cm): Likewise.
12548 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12549 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12550 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12551 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12552 (turn_on_face, init_tty): Likewise.
12553 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12554
7f3f1250
PE
12555 * term.c (term_mouse_position): Rename local to avoid shadowing.
12556
e6ca6543
PE
12557 * alloc.c (mark_ttys): Move decl from here ...
12558 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12559
c40f8d15
AS
125602011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12561
12562 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12563
cfe0661d
JB
125642011-03-09 Juanma Barranquero <lekktu@gmail.com>
12565
12566 * search.c (compile_pattern_1): Remove argument regp, unused since
12567 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12568 (compile_pattern): Don't pass it.
12569
0afb4571
J
125702011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12571
12572 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12573 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12574 for ! HAVE_GTK3.
12575 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12576
12577 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12578
12579 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12580 gdk_window_get_screen, gdk_window_get_geometry,
12581 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12582 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12583 (xg_get_pixbuf_from_pixmap): New function.
12584 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12585 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12586 Call xg_get_pixbuf_from_pixmap instead of
12587 gdk_pixbuf_get_from_drawable.
12588 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12589 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12590 (xg_check_special_colors): Use GtkStyleContext and its functions
12591 for HAVE_GTK3.
12592 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12593 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12594 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12595 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12596 Call gtk_widget_get_preferred_size.
0afb4571
J
12597 (xg_frame_resized): gdk_window_get_geometry only takes 5
12598 parameters.
44f230aa
SM
12599 (xg_win_to_widget, xg_event_is_for_menubar):
12600 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12601 (xg_set_widget_bg): New function.
12602 (delete_cb): New function.
895009e1 12603 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12604 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12605 (xg_set_background_color): Call xg_set_widget_bg.
12606 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12607 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12608 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12609 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12610 if ! HAVE_GTK3.
12611 (update_frame_tool_bar): Call gtk_widget_hide.
12612 (xg_initialize): Use GDK_KEY_g.
12613
12614 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12615 if ! HAVE_GTK3
12616 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12617
12618 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12619 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12620 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12621
1c2cc4ef
JB
126222011-03-08 Juanma Barranquero <lekktu@gmail.com>
12623
12624 * w32xfns.c (select_palette): Check success of RealizePalette against
12625 GDI_ERROR, not zero.
12626
33383987 12627See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12628
12629;; Local Variables:
12630;; coding: utf-8
aac0c6e3
MR
12631;; End:
12632
2f097256 12633 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12634
12635 This file is part of GNU Emacs.
12636
12637 GNU Emacs is free software: you can redistribute it and/or modify
12638 it under the terms of the GNU General Public License as published by
12639 the Free Software Foundation, either version 3 of the License, or
12640 (at your option) any later version.
12641
12642 GNU Emacs is distributed in the hope that it will be useful,
12643 but WITHOUT ANY WARRANTY; without even the implied warranty of
12644 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12645 GNU General Public License for more details.
12646
12647 You should have received a copy of the GNU General Public License
12648 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.