* process.c (read_process_output): Use p instead of XPROCESS (proc).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
959ad23f
AS
12012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2
3 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4 (send_process): Likewise.
5
34a02f46
MR
62012-01-19 Martin Rudalics <rudalics@gmx.at>
7
8 * window.c (save_window_save, Fcurrent_window_configuration)
9 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
10 doc-strings.
11
1259009a 122012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
13
14 * character.c (char_width): New function.
70d4fdf6
GM
15 (Fchar_width, c_string_width, lisp_string_width):
16 Use char_width (Bug#9496).
25ed9e61 17
6a6ee00d
MR
182012-01-16 Martin Rudalics <rudalics@gmx.at>
19
20 * window.c (Vwindow_persistent_parameters): New variable.
21 (Fset_window_configuration, save_window_save): Handle persistent
22 window parameters.
23
c85efaf7
EZ
242012-01-14 Eli Zaretskii <eliz@gnu.org>
25
26 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
27 thrashing the stack of the thread. (Bug#9087)
28
5944709e
PE
292012-01-12 Paul Eggert <eggert@cs.ucla.edu>
30
31 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
32
e71f5d99
EZ
332012-01-11 Eli Zaretskii <eliz@gnu.org>
34
35 * xdisp.c (rows_from_pos_range): Handle the case where the
36 highlight ends on a newline. (Bug#10464)
37 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
38 he end column for display of highlight that ends on a newline
39 before a R2L line.
40
ce316182
GM
412012-01-11 Glenn Morris <rgm@gnu.org>
42
43 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
44 from load-path also when installation-directory is nil. (Bug#10208)
45
5b43da69
GM
462012-01-10 Glenn Morris <rgm@gnu.org>
47
74cc8ff9
GM
48 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
49
7d8d6e4e
GM
50 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
51 Update template values to be closer to their typical values these days.
5b43da69 52
a0db8d43
EZ
532012-01-09 Eli Zaretskii <eliz@gnu.org>
54
55 * xdisp.c (rows_from_pos_range): Accept additional argument
56 DISP_STRING, and accept any glyph in a row whose object is that
57 string as eligible for mouse highlight. Fixes mouse highlight of
58 display strings from overlays. (Bug#10464)
59
9a0115ab 602012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 61
b9110d6a 62 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
63 * fileio.c (auto_saving_dir_umask): New static var.
64 (Fmake_directory_internal): Use it.
65 (do_auto_save_make_dir): Set it, instead of invoking chmod after
66 creating the directory. The old code temporarily assigns
67 too-generous permissions to the directory.
68 (do_auto_save_eh): Clear it.
b9110d6a 69 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
70 that the var is always cleared.
71
6c1bd3f3
EZ
722012-01-07 Eli Zaretskii <eliz@gnu.org>
73
74 * search.c (scan_buffer): Pass character positions to
75 know_region_cache, not byte positions. (Bug#6540)
76
069d2b50
L
772012-01-07 LynX <_LynX@bk.ru> (tiny change)
78
79 * w32.c (sys_rename): Report EXDEV when rename of a directory
80 fails because the target is on another logical disk. (Bug#10284)
81
75bf0d33
DB
822012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
83
84 * xterm.c (x_embed_request_focus): New function.
85
86 * xterm.h: Add prototype.
87
88 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
89
1c6e5a32
GM
902012-01-05 Glenn Morris <rgm@gnu.org>
91
92 * emacs.c (emacs_copyright): Update short copyright year to 2012.
93
651e947e
EZ
942012-01-01 Eli Zaretskii <eliz@gnu.org>
95
96 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
97 Load gnutls_transport_set_lowat only if GnuTLS version is below
98 2.11.1.
99 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
100 GnuTLS versions below 2.11.1.
101
3778cdd8
AL
1022011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
103
104 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
105 to the doc string advising against its use for altering the way
106 windows are scrolled.
107
0e5317f7
KH
1082011-12-28 Kenichi Handa <handa@m17n.org>
109
110 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
111 coding-system ASCII compatible only when it does not produce BOM
112 on encoding (Bug#10383).
113
93d5ca1f
JD
1142011-12-26 Jan Djärv <jan.h.d@swipnet.se>
115
116 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
117 can scroll.
118 (create_and_show_popup_menu): Always use menu_position_func for
119 Gtk3 (Bug#10361).
120
ca22b785
AS
1212011-12-24 Andreas Schwab <schwab@linux-m68k.org>
122
123 * callint.c (Fcall_interactively): Don't truncate prompt string.
124
d048e1e6
EZ
1252011-12-23 Eli Zaretskii <eliz@gnu.org>
126
127 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
128 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 129 resumed from there (after widening). (Bug#10360)
d048e1e6 130
5ccaba1f
JD
1312011-12-22 Jan Djärv <jan.h.d@swipnet.se>
132
133 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
134
204ee57f
JD
1352011-12-21 Jan Djärv <jan.h.d@swipnet.se>
136
b81d40f0
JB
137 * nsterm.m (x_free_frame_resources):
138 Release f->output_data.ns->miniimage.
204ee57f
JD
139 (ns_index_color): Fix indentation. Do not retain
140 color_table->colors[i].
141
142 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
143 before returning.
144
145 * nsfns.m (x_set_background_color): Assign return value from
146 ns_index_color to face-background instead of NSColor*.
147 (ns_implicitly_set_icon_type): Fix indentation.
148 Change assignment in for loop to comparison.
149
150 * emacs.c (ns_pool): New variable.
151 (main): Assign ns_pool.
152 (Fkill_emacs): Call ns_release_autorelease_pool.
153
154 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
155 autorelease fdesc, release fdAttrs and tdict.
156 (ns_get_covering_families): Release charset.
157 (ns_findfonts): Release NSFontDescriptor created with new.
158 (ns_uni_to_glyphs): Fix indentation.
159 (setString): Release attrStr before assigning new value.
160
c803b2b7
JD
1612011-12-18 Jan Djärv <jan.h.d@swipnet.se>
162
678f4426
JD
163 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
164 and NS_IMPL_COCOA.
165 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
166 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
167
cd394be1 1682011-12-18 David Reitter <reitter@cmu.edu>
678f4426 169
5fecd5fc
JD
170 * nsterm.m (ns_term_init): Subscribe for notifications
171 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
172 to method trackingNotification in EmacsMenu.
173
174 * nsmenu.m (trackingMenu): New variable.
3771cb17 175 (trackingNotification): New method (from Aquamacs).
5fecd5fc 176 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 177 from Aquamacs (Bug#7030).
678f4426
JD
178
1792011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 180
c803b2b7
JD
181 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
182 (symbol_to_nsstring): Fix indentation.
183 (ns_symbol_to_pb): New function.
184 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
185 (Fns_rotate_cut_buffers_internal): Removed.
186 (Fns_store_selection_internal): Renamed from
187 Fns_store_cut_buffer_internal.
188 (ns_get_foreign_selection, Fx_own_selection_internal)
189 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
190 (Fns_get_selection_internal, Fns_store_selection_internal):
191 Use ns_symbol_to_pb and check if return value is nil.
192 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
193 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
194 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
195 renamed to Sns_store_selection_internal.
196 (ns_handle_selection_request): Move code to Fx_own_selection_internal
197 and remove this function.
198 (ns_handle_selection_clear): Remove, never used.
199 (Fx_own_selection_internal): Move code from ns_handle_selection_request
200 here.
201
e1b01a3a
KB
2022011-12-17 Ken Brown <kbrown@cornell.edu>
203
204 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
205 GID is unknown (Bug#10257).
206
2adb6e85
PE
2072011-12-17 Paul Eggert <eggert@cs.ucla.edu>
208
209 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
210 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
211 which caused a build failure on GNU/Linux IA-64. This problem was
212 introduced by my 2011-10-07 patch.
213
d1d7b339
JL
2142011-12-15 Juri Linkov <juri@jurta.org>
215
216 * image.c (imagemagick_error): New function. (Bug#10112)
217 (imagemagick_load_image): Comment out `MagickSetResolution' call.
218 Use `imagemagick_error' where ImageMagick functions return
219 `MagickFalse'.
220 (Fimagemagick_types): Add `Fnreverse' to return the list in the
221 proper order.
222
100d5755
KH
2232011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
224
225 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
226 fill background (Bug#8992).
227
454592a6
MR
2282011-12-13 Martin Rudalics <rudalics@gmx.at>
229
230 * window.c (Vwindow_combination_resize)
231 (Vwindow_combination_limit): Use t instead of non-nil in
232 doc-strings.
61d4b438
MR
233 (Vrecenter_redisplay): Add first sentence of doc-string on
234 separate line.
53524d93 235 (Frecenter): Fix doc-string typo.
454592a6 236
3633e3aa
KH
2372011-12-11 Kenichi Handa <handa@m17n.org>
238
239 * coding.c (Funencodable_char_position): Pay attention to the
240 buffer text relocation (Bug#9389).
241
7b9d523a
JD
2422011-12-10 Jan Djärv <jan.h.d@swipnet.se>
243
244 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
245 gtk_init (Bug#10100).
246
b73189c6
EZ
2472011-12-10 Eli Zaretskii <eliz@gnu.org>
248
249 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
250 IT->string is nil. (Bug#10263)
251
f7dfe5d6
JD
2522011-12-10 Jan Djärv <jan.h.d@swipnet.se>
253
83faebb4
JD
254 * nsterm.h (x_free_frame_resources): Declare.
255
f7dfe5d6
JD
256 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
257 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
258
259 * nsterm.h (ns_get_defaults_value): Declare.
260
261 * nsterm.m (ns_default): Call ns_get_defaults_value.
262
7cd4e72c
EZ
2632011-12-09 Eli Zaretskii <eliz@gnu.org>
264
265 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
266 (Bug#10170)
267
b34d7317
YM
2682011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
269
270 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
271 that where the value of an _OBJC_* symbol points to is in the .bss
272 section (Bug#10240).
273
76470ad1
KH
2742011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
275
276 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 277 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 278
745fff94
KH
2792011-12-08 Kenichi Handa <handa@m17n.org>
280
281 * ftfont.c (get_adstyle_property): Fix previous change
282 (Bug#10233).
283
6e44397c
JB
2842011-12-07 Juanma Barranquero <lekktu@gmail.com>
285
286 * w32.c (init_environment): If no_site_lisp, remove site-lisp
287 dirs from the default value of EMACSLOADPATH (bug#10208).
288
7efa6272
GM
2892011-12-07 Glenn Morris <rgm@gnu.org>
290
291 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
292 installation and source directories as well. (Bug#10208)
293
f6fc4d87
CY
2942011-12-06 Chong Yidong <cyd@gnu.org>
295
296 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
297
2bf26180
GM
2982011-12-06 Glenn Morris <rgm@gnu.org>
299
300 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
301 as an error, not just -1. (Bug#10217)
302
3a6ad4f0
CY
3032011-12-05 Chong Yidong <cyd@gnu.org>
304
305 * keyboard.c (process_special_events): New function.
306 (swallow_events, Finput_pending_p): Use it (Bug#10195).
307
75a3b399
PE
3082011-12-05 Paul Eggert <eggert@cs.ucla.edu>
309
310 * coding.c (encode_designation_at_bol): Don't use uninitialized
311 local variable (Bug#9318).
312
c3c9e25e
KH
3132011-12-05 Kenichi Handa <handa@m17n.org>
314
315 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
316 return Qnil (Bug#8046, Bug#10193).
317
5eb05ea3
KH
3182011-12-05 Kenichi Handa <handa@m17n.org>
319
320 * coding.c (encode_designation_at_bol): New args charbuf_end and
321 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
322 (coding_set_source): Return how many bytes coding->source was
323 relocated.
324 (coding_set_destination): Return how many bytes
325 coding->destination was relocated.
326 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
327 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
328
3292011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
330
331 * coding.c (CODING_CHAR_CHARSET_P): New macro.
332 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
333 macro (Bug#9318).
334
3352011-12-05 Andreas Schwab <schwab@linux-m68k.org>
336
337 The following changes are to fix Bug#9318.
338
a79703f5 339 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
340 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
341 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 342 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 343
7dbda6df
JB
3442011-12-05 Juanma Barranquero <lekktu@gmail.com>
345
346 * lisp.h (process_quit_flag): Fix external declaration.
347
6d5eb5b0
SM
3482011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
349
350 Don't macro-inline non-performance-critical code.
351 * eval.c (process_quit_flag): New function.
352 * lisp.h (QUIT): Use it.
353
a0c3fad0
JD
3542011-12-04 Jan Djärv <jan.h.d@swipnet.se>
355
356 * nsfns.m (get_geometry_from_preferences): New function.
357 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
358
6c07aac2
AS
3592011-12-04 Andreas Schwab <schwab@linux-m68k.org>
360
361 * emacs.c (Qkill_emacs): Define.
362 (syms_of_emacs): Initialize it.
363 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
364 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
365 (quit_throw_to_read_char): Add parameter `from_signal'.
366 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
367 * lisp.h (QUIT): Call Fkill_emacs if requested.
368
c052ead4
JD
3692011-12-03 Jan Djärv <jan.h.d@swipnet.se>
370
371 * widget.c (update_wm_hints): Return if wmshell is null.
372 (widget_update_wm_size_hints): New function.
373
374 * widget.h (widget_update_wm_size_hints): Declare.
375
376 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
377 widget_update_wm_size_hints (Bug#10104).
378
9e49252b
EZ
3792011-12-03 Eli Zaretskii <eliz@gnu.org>
380
381 * xdisp.c (handle_invisible_prop): If the invisible text ends just
382 before a newline, prepare the bidi iterator for consuming the
383 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 384 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 385
02b16839
JL
3862011-12-02 Juri Linkov <juri@jurta.org>
387
388 * search.c (Fword_search_regexp): New Lisp function created from
389 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
390 (Fword_search_backward, Fword_search_forward)
391 (Fword_search_backward_lax, Fword_search_forward_lax):
392 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
393 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
394
0068070e
SM
3952011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
396
397 * fileio.c (Finsert_file_contents): Move after-change-function call
398 to before the "handled:" label, since all "goto handled" appear in
399 cases where the *-change-functions have already been properly called
400 (bug#10117).
401
3360a3fc
AS
4022011-12-01 Andreas Schwab <schwab@linux-m68k.org>
403
404 * keyboard.c (interrupt_signal): Don't call kill-emacs when
405 waiting for input. (Bug#10169)
406
73d6c093
EZ
4072011-11-30 Eli Zaretskii <eliz@gnu.org>
408
409 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
410 verifies glyph row's hash code--we have just reallocated the
411 glyphs, so their contents can be complete garbage. (Bug#10164)
412
febe6bea
JB
4132011-11-30 Juanma Barranquero <lekktu@gmail.com>
414
415 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
416
801a4313
EZ
4172011-11-30 Eli Zaretskii <eliz@gnu.org>
418
419 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
420 attributes are tested _before_ calling verify_row_hash, to protect
421 against GCC re-ordering of the tests. (Bug#10164)
422
2b56b87e
JD
4232011-11-29 Jan Djärv <jan.h.d@swipnet.se>
424
425 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
426
427 * xterm.c (handle_one_xevent): Only set async_visible and friends
428 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 429 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
430 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
431
dbf31225
PE
4322011-11-28 Paul Eggert <eggert@cs.ucla.edu>
433
434 Remove GCPRO-related macros that exist only to avoid shadowing locals.
435 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
436 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
437 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
438 All uses changed to use GCPRO1 etc.
439 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
440 Revert to old implementation (i.e., before 2011-03-11).
441
1305621b
YM
4422011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
443
444 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
445 of scroll runs so as to avoid assigning disabled bogus rows and
446 unnecessary graphics copy operations.
447
8c9afb46
EZ
4482011-11-27 Eli Zaretskii <eliz@gnu.org>
449
450 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
451 (snprintf) [_MSC_VER]: Redirect to _snprintf.
452 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
453 (malloc, free, realloc, calloc): Redirect to e_* only when
454 compiling Emacs.
455
456 * lisp.h (GCTYPEBITS): Move before first use.
457 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
458 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
459 this macro definition.
460
461 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
462 _MSC_VER.
463
54e9e3bf
JD
4642011-11-27 Jan Djärv <jan.h.d@swipnet.se>
465
6d5eb5b0
SM
466 * gtkutil.c (xg_create_frame_widgets):
467 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
468 present with Gtk+ 2.0.
469
83aca1cb
PE
4702011-11-26 Paul Eggert <eggert@cs.ucla.edu>
471
472 * fileio.c (Finsert_file_contents): Undo previous change; see
473 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
474
5b76caa4
PE
4752011-11-26 Paul Eggert <eggert@cs.ucla.edu>
476
477 Rename locals to avoid shadowing.
478 * fileio.c (Finsert_file_contents):
479 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
480 * process.c (wait_reading_process_output):
481 Rename inner 'proc' to 'p' to avoid shadowing.
482 Indent for consistency with usual Emacs style.
483
8c535114
EZ
4842011-11-25 Eli Zaretskii <eliz@gnu.org>
485
486 * xdisp.c (redisplay_window): If cursor row is not fully visible
487 after recentering, and scroll-conservatively is set to a large
488 number, scroll window by a few more lines to make the cursor fully
489 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
490 (start_display): Don't move to the next line if the display should
491 start at a newline that is part of a display vector or an overlay
492 string. (Bug#10119)
8c535114 493
fa4fdb5c
JL
4942011-11-24 Juri Linkov <juri@jurta.org>
495
496 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
497 after the `MagickPingImage' call. (Bug#10112)
498
90ec88df
CY
4992011-11-23 Chong Yidong <cyd@gnu.org>
500
501 * window.c (Fcoordinates_in_window_p): Accept only live windows.
502
56e2e794
MR
5032011-11-23 Martin Rudalics <rudalics@gmx.at>
504
505 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
506 making another buffer current. (Bug#10114)
507
b6e64c41
GM
5082011-11-23 Glenn Morris <rgm@gnu.org>
509
510 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
511
6b21de18
CY
5122011-11-23 Chong Yidong <cyd@gnu.org>
513
514 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
515 using it (Bug#5984).
516
b12cd789
EZ
5172011-11-22 Eli Zaretskii <eliz@gnu.org>
518
519 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
520 and header-lines, as they don't have one computed for them.
521 (Bug#10098)
522
523 * .gdbinit (prow): Make displayed values more self-explaining.
524 Add row's hash code.
525
261b6fd4
LMI
5262011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
527
528 * process.c (wait_reading_process_output): Fix asynchrounous
529 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 530 (wait_reading_process_output): Add comment and URL.
261b6fd4 531
e7cfd277
JD
5322011-11-21 Jan Djärv <jan.h.d@swipnet.se>
533
534 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
535
a9b9b7f5
CY
5362011-11-21 Chong Yidong <cyd@gnu.org>
537
538 * window.c (Fnext_window, Fprevious_window): Doc fix.
539
b0d15b4f
SM
5402011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
541
542 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
543
fe7a3057
JB
5442011-11-20 Juanma Barranquero <lekktu@gmail.com>
545
546 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
547
d2999b1a
MR
5482011-11-20 Martin Rudalics <rudalics@gmx.at>
549
550 * window.c (Fset_window_combination_limit): Rename argument
551 STATUS to LIMIT.
552 (Vwindow_combination_limit): Remove "status" from doc-string.
553
d5ff9cd0
AS
5542011-11-20 Andreas Schwab <schwab@linux-m68k.org>
555
556 * m/ibms390.h: Remove.
557 * m/ibms390x.h: Don't include "ibms390.h".
558
a5bb9bd3
SM
5592011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
560
561 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
562 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
563
cd1181db
JB
5642011-11-20 Juanma Barranquero <lekktu@gmail.com>
565
566 * casetab.c (Fset_case_table):
567 * charset.c (Fcharset_after): Fix typos.
568
615a3b8d 5692011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 570
17e845af
PE
571 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
572 Otherwise, valgrind does not work on some platforms.
573 Problem reported by Andreas Schwab in
6a0bf43d
PE
574 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
575 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
576 is set, removing the need for VIRT_ADDRESS_VARIES.
577 (PURE_P): Use a more-efficient implementation that needs just one
578 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
579 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
580 to 4 (xorl, subq, cmpq, setbe).
581 * alloc.c (pure): Always extern now, since that's the
582 VIRT_ADDR_VARIES behavior.
583 (PURE_POINTER_P): Use a single comparison, not two, for
584 consistency with the new puresize.h.
585 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
586 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
587 Remove VIRT_ADDR_VARIES no longer needed.
588
f8fe6f96
EZ
5892011-11-19 Eli Zaretskii <eliz@gnu.org>
590
591 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
592 (erase_phys_cursor, update_window_cursor, show_mouse_face)
593 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
594 behave as if the cursor position were at the window margin.
595
596 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
597 and the cursor position is out of bounds, behave as if the cursor
598 position were at the window margin. (Bug#10075)
599
df05a53c
CY
6002011-11-18 Chong Yidong <cyd@gnu.org>
601
602 * window.c (Fwindow_combination_limit): Make first argument
603 non-optional, since it is meaningless for live windows like the
604 selected window.
605
2071918e
DA
6062011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
607
608 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
609
b50a28de
SM
6102011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
611
612 * intervals.c: Fix grafting over the whole buffer (bug#10071).
613 (graft_intervals_into_buffer): Simplify.
614
015137db
EZ
6152011-11-18 Eli Zaretskii <eliz@gnu.org>
616
617 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
618 hash values of the two rows.
619 (copy_row_except_pointers): Preserve the used[] arrays and the
620 hash values of the two rows. (Bug#10035)
68c95424 621 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
622
623 * xdisp.c (row_hash): New function, body extracted from
624 compute_line_metrics.
625 (compute_line_metrics): Call row_hash, instead of computing the
626 hash code inline.
627
628 * dispnew.c (verify_row_hash): Call row_hash for computing the
629 hash code of a row, instead of duplicating code from xdisp.c.
630
631 * dispextern.h (row_hash): Add prototype.
632
a2addb04
TH
6332011-11-18 Tassilo Horn <tassilo@member.fsf.org>
634
635 * frame.c (delete_frame): Don't delete the terminal when the last
636 X frame is closed if emacs is built with GTK toolkit.
637
df85d315
JB
6382011-11-17 Juanma Barranquero <lekktu@gmail.com>
639
640 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
641
a0c2d0ae
MR
6422011-11-17 Martin Rudalics <rudalics@gmx.at>
643
644 * window.c (Vwindow_splits): Rename to
645 Vwindow_combination_resize. Suggested by Juri Linkov.
646 (Fsplit_window_internal): Use Vwindow_combination_resize instead
647 of Vwindow_splits.
648
58179cce
JB
6492011-11-16 Juanma Barranquero <lekktu@gmail.com>
650
7877f373
JB
651 * nsfns.m (Fns_font_name):
652 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 653
b6f67890
MR
6542011-11-16 Martin Rudalics <rudalics@gmx.at>
655
656 * window.h (window): Rename slot "nest" to "combination_limit".
657 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
658 (Fset_window_nest): Rename to Fset_window_combination_limit.
659 (Vwindow_nest): Rename to Vwindow_combination_limit.
660 (recombine_windows, make_parent_window, make_window)
661 (Fsplit_window_internal, saved_window)
662 (Fset_window_configuration, save_window_save): Rename all
663 occurrences of window_nest to window_combination_limit.
664
c7015153
JB
6652011-11-15 Juanma Barranquero <lekktu@gmail.com>
666
667 * image.c (imagemagick_load_image): Fix typo.
668
322ad6ec
EZ
6692011-11-14 Eli Zaretskii <eliz@gnu.org>
670
671 * xdisp.c (display_line): Move the call to
672 highlight_trailing_whitespace before the call to
673 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
674 faces of all the glyphs to compute ROW's hash value.
675 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 676
f067b8ec
JB
6772011-11-14 Juanma Barranquero <lekktu@gmail.com>
678
679 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
680 just return (bug#10044).
681
1e5b2111
EZ
6822011-11-12 Eli Zaretskii <eliz@gnu.org>
683
7ef3cbd5
EZ
684 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
685 with user-defined heap size. Bump the default size of the temacs
686 heap to 27MB, to avoid memory warning when running temacs.
687 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
688
1e5b2111
EZ
689 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
690 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
691 (verify_row_hash) [XASSERTS]: New function.
692 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
693 that the hash value of glyph rows is correct.
1e5b2111 694
89d61221
MR
6952011-11-12 Martin Rudalics <rudalics@gmx.at>
696
697 * window.h (window): Remove splits slot.
698 * window.c (Fwindow_splits, Fset_window_splits): Remove.
699 (Fdelete_other_windows_internal, make_parent_window)
700 (make_window, Fsplit_window_internal, Fdelete_window_internal)
701 (Fset_window_configuration, save_window_save): Don't deal with
702 split status of windows.
703 (saved_window): Remove splits slot.
704 (Vwindow_splits): Rewrite doc-string.
705
97f18cc8
JD
7062011-11-11 Jan Djärv <jan.h.d@swipnet.se>
707
708 * xfns.c (unwind_create_frame):
709 * nsfns.m (unwind_create_frame):
710 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
711 Vframe_list (Bug#9999).
712
22a648b4
DA
7132011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
714
0b381c7e 715 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 716
659afede
KH
7172011-11-11 Kenichi Handa <handa@m17n.org>
718
719 * callproc.c (Fcall_process): Set the member dst_multibyte of
720 process_coding.
721
9ac0394b
KH
7222011-11-11 Johan Bockgård <bojohan@gnu.org>
723
724 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
725 avoid a crash (bug#9496).
726
2fbdc249
CY
7272011-11-09 Chong Yidong <cyd@gnu.org>
728
729 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
730 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
731
ac6b1f81
PE
7322011-11-08 Paul Eggert <eggert@cs.ucla.edu>
733
734 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
735
09db192c
PE
7362011-11-08 Paul Eggert <eggert@cs.ucla.edu>
737
738 Avoid some portability problems by eschewing 'extern inline' functions.
739 The trivial performance wins aren't worth the portability hassles; see
740 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
741 et seq.
742 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
743 (window_box_width, window_box_left, window_box_left_offset)
744 (window_box_right, window_box_right_offset): Undo previous change,
745 by removing the "extern"s.
746 * intervals.c (adjust_intervals_for_insertion)
747 (adjust_intervals_for_deletion): Undo previous change,
748 making these static again.
749 (offset_intervals, temp_set_point_both, temp_set_point)
750 (copy_intervals_to_string): No longer inline.
751 * xdisp.c (window_text_bottom_y, window_box_width)
752 (window_box_height, window_box_left_offset)
753 (window_box_right_offset, window_box_left, window_box_right)
754 (window_box): No longer inline.
755
105216ed
CY
7562011-11-08 Chong Yidong <cyd@gnu.org>
757
758 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
759 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
760 Signal an error if not a live window.
105216ed
CY
761 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
762 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
763
ae9e237f
JB
7642011-11-07 Juanma Barranquero <lekktu@gmail.com>
765
766 * lisp.h (syms_of_abbrev): Remove declaration.
767 Reported by CHENG Gao <chenggao@royau.me>.
768
c7aa8333
EZ
7692011-11-07 Eli Zaretskii <eliz@gnu.org>
770
771 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
772 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
773 of temacs in GUI mode.
774
be7f5545
MR
7752011-11-07 Martin Rudalics <rudalics@gmx.at>
776
777 * window.h: Declare delete_all_child_windows instead of
778 delete_all_subwindows.
779 * window.c (Fwindow_nest, Fset_window_nest)
780 (Fset_window_new_total, Fset_window_new_normal)
781 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
782 (delete_all_subwindows): Rename to delete_all_child_windows.
783 (Fdelete_other_windows_internal, Fset_window_configuration):
784 Call delete_all_child_windows instead of delete_all_subwindows.
785 * frame.c (delete_frame): Call delete_all_child_windows instead
786 of delete_all_subwindows.
787
ca78dc43
PE
7882011-11-07 Paul Eggert <eggert@cs.ucla.edu>
789
790 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
791 This is also needed for porting to any host where GC_MARK_STACK is
792 not GC_MAKE_GCPROS_NOOPS.
793 (which_symbols): Use it.
794
a0241d01
KH
7952011-11-07 Kenichi Handa <handa@m17n.org>
796
797 * coding.c (coding_set_destination): Check coding->src_pos only
798 when coding->src_object is a buffer (bug#9910).
799
800 * process.c (send_process): Set the member src_multibyte of coding
801 to 0 (bug#9911) when sending a unibyte text.
802
803 * callproc.c (Fcall_process): Set the member src_multibyte of
804 process_coding to 0 (bug#9912).
805
a64bfdfa 8062011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
807
808 * xmenu.c (cleanup_widget_value_tree): New function.
809 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
810 calling free_menubar_widget_value_tree directly (Bug#9830).
811
cb41b32a
PE
8122011-11-06 Paul Eggert <eggert@cs.ucla.edu>
813
814 Fix some portability problems with 'inline'.
815 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
816 (window_box_width, window_box_left, window_box_left_offset)
817 (window_box_right, window_box_right_offset): Declare extern.
818 Otherwise, these inline functions do not conform to C99 and
819 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
820 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
821 * intervals.c (adjust_intervals_for_insertion)
822 (adjust_intervals_for_deletion): Now extern, because otherwise the
823 extern inline functions 'offset_intervals' couldn't refer to it.
824 (static_offset_intervals): Remove.
825 (offset_intervals): Rewrite using the old contents of
826 static_offset_intervals. The old version didn't conform to C99
827 because an extern inline function contained a reference to an
828 identifier with static linkage.
829
b7041366
AS
8302011-11-06 Andreas Schwab <schwab@linux-m68k.org>
831
832 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
833 GC.
834
88a37c4d
EZ
8352011-11-06 Eli Zaretskii <eliz@gnu.org>
836
837 * xdisp.c (init_iterator, reseat_to_string): Don't set the
838 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
839 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
840 return Qleft_to_right.
841
49745b39
CY
8422011-11-06 Chong Yidong <cyd@gnu.org>
843
844 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
845 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
846 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
847 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
848 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
849 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
850 (Fwindow_vscroll): Doc fix.
851 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
852 argument, since it makes no sense to pass a live window and for
853 consistency with window-child.
854
1f05cd82
CS
8552011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
856
857 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
858 support MSVC.
859
22610910
JR
8602011-11-05 Jason Rumney <jasonr@gnu.org>
861
862 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
863 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
864 fonts (Bug#6029).
865 (add_font_entity_to_list): Fix logic errors in mixed boolean and
866 bitwise arithmetic preventing use of unicode-sip and non-truetype
867 opentype fonts.
868
a06776b2
EZ
8692011-11-05 Eli Zaretskii <eliz@gnu.org>
870
3ad924ba
EZ
871 * s/ms-w32.h (fstat, stat, utime): Move redirections to
872 "emacs"-only part.
873
a06776b2
EZ
874 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
875 initialization code to keep similarity to xfns.c after changes
876 from 2011-11-05.
877
c9e7db78
JD
8782011-11-05 Jan Djärv <jan.h.d@swipnet.se>
879
a97f8f3f
JD
880 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
881 (unwind_create_frame): New function (Bug#9943).
882 (Fx_create_frame): Restructure code to be more similar to the one in
883 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
884 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
885 Move terminal->reference_count++ just before making the frame official
886 (Bug#9943).
887
888 * nsterm.m (x_free_frame_resources): New function.
889 (x_destroy_window): Move code to x_free_frame_resources.
890
c9e7db78 891 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
892 (Fx_create_frame, x_create_tip_frame):
893 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
894 official. Move initialization of image_cache_refcount and
895 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
896
a6fc3b5c
EZ
8972011-11-05 Eli Zaretskii <eliz@gnu.org>
898
899 Support MSVC build with newer versions of Visual Studio.
900 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
901 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
902 nt/gmake.defs.
903
904 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
905 which are not supported by MSVC.
906 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
907 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
908 bitfields.
909 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
910 types in bitfields.
911 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
912
913 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
914
58179cce 9152011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
916
917 Support MSVC build with newer versions of Visual Studio.
918 * w32.c: Don't include w32api.h for MSVC.
919 (init_environment) [_MSC_VER]: Call sys_access, not _access.
920
921 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
922 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
923 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
924 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
925 e_* cousins.
926 (alloca) [_MSC_VER]: Define to _alloca.
927
928 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
929
930 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
931
a58c13ed
EZ
9322011-11-04 Eli Zaretskii <eliz@gnu.org>
933
934 * xdisp.c (note_mouse_highlight): If either of
935 previous/next-single-property-change returns nil, treat that as
936 the beginning or the end of the buffer. (Bug#9955)
937
fe0b6370
JD
9382011-11-04 Jan Djärv <jan.h.d@swipnet.se>
939
a58c13ed 940 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
941 label is not null (Bug#9951).
942 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
943 may be NULL.
944
89bd5ee1
EZ
9452011-11-04 Eli Zaretskii <eliz@gnu.org>
946
947 * window.c (Fwindow_body_size): Mention in the doc string that the
948 return value is in frame's canonical units. (Bug#9949)
949
84c3edb9
EZ
9502011-11-03 Eli Zaretskii <eliz@gnu.org>
951
4e2fb5c7
EZ
952 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
953
84c3edb9 954 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 955 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 956 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 957
bc17a887
EZ
9582011-11-01 Eli Zaretskii <eliz@gnu.org>
959
960 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
961 Don't stop backward scan on the continuation glyph, even though
962 its CHARPOS is positive.
6d5eb5b0
SM
963 (mouse_face_from_buffer_pos, note_mouse_highlight):
964 Rename cover_string to disp_string.
bc17a887 965
4ee88440
MR
9662011-11-01 Martin Rudalics <rudalics@gmx.at>
967
968 * window.c (temp_output_buffer_show): Don't use
969 Vtemp_buffer_show_specifiers.
970 (Vtemp_buffer_show_specifiers): Remove unused variable.
971
c2ff3c02
EZ
9722011-10-30 Eli Zaretskii <eliz@gnu.org>
973
974 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
975 past the beginning of the current glyph matrix.
976
58179cce 9772011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
978
979 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
980 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
981 HAVE_GTK3 (Bug#9869).
b77a6a7f 982
3b574623
JD
983 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
984 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
985
b77a6a7f
JD
986 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
987
988 * xterm.c: Declare x_handle_net_wm_state to return int.
989 (handle_one_xevent): Check if we are iconified but don't have
990 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
991 (get_current_wm_state): Return non-zero if not hidden,
992 check for _NET_WM_STATE_HIDDEN (Bug#9893).
993 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
994 (x_handle_net_wm_state): Return what get_current_wm_state returns.
995 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
996
196e41e4
PE
9972011-10-29 Paul Eggert <eggert@cs.ucla.edu>
998
999 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1000 so that this new function doesn't get optimized away by a
1001 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1002
021f2e1a
AS
10032011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1004
1005 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1006
8b058d44
EZ
10072011-10-29 Eli Zaretskii <eliz@gnu.org>
1008
1009 Fix the `xbytecode' command.
1010 * .gdbinit (xprintbytestr): New command.
b50a28de 1011 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1012 (xbytecode): Print the byte-code string as well.
1013
4452fb80
EZ
10142011-10-29 Kim Storm <storm@cua.dk>
1015
8b058d44
EZ
1016 * alloc.c (which_symbols): New function.
1017
21b72067
AS
10182011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1019
1020 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1021 line. (Bug#9903)
1022
83ed7b5c
GM
10232011-10-29 Glenn Morris <rgm@gnu.org>
1024
1025 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1026 Not clear what it was for, and it causes various bugs. (Bug#9839)
1027
5a7a728b
EZ
10282011-10-28 Eli Zaretskii <eliz@gnu.org>
1029
1030 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1031 possible random value that matches one of those tested as
1032 condition to clear the mouse face.
1033
d3d0842f
CY
10342011-10-28 Chong Yidong <cyd@gnu.org>
1035
1036 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1037
31b39d13
DN
10382011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1039
1040 * window.c (make_window): Initialize phys_cursor_on_p.
1041
9aba6043
SM
10422011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1043
1044 * lisp.h (struct Lisp_Symbol): Update comments.
1045
c20992f4
JB
10462011-10-28 Juanma Barranquero <lekktu@gmail.com>
1047
1048 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1049
db4f02f2
EZ
10502011-10-28 Eli Zaretskii <eliz@gnu.org>
1051
1052 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1053 <oslsachem@gmail.com> for helping to debug this.
1054
1055 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1056 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1057 (g_b_init_get_glyph_outline_w): New static variables.
1058 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1059 (GetGlyphOutlineW_Proc): New typedefs.
1060 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1061 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1062 New functions.
1063 (w32font_open_internal, compute_metrics):
1064 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1065 instead of calling the "wide" APIs directly.
1066
1067 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1068
1069 * w32.h (syms_of_w32font): Add prototype.
1070
87e68db4
JB
10712011-10-27 Juanma Barranquero <lekktu@gmail.com>
1072
1073 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1074 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1075 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1076 (Fmove_to_window_line): Doc fix.
1077
435c1d67
CY
10782011-10-27 Chong Yidong <cyd@gnu.org>
1079
1080 * process.c (make_process): Set gnutls_state to NULL.
1081
1082 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1083 non-NULL, regardless of GNUTLS_INITSTAGE.
1084 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1085 an error. Set process slots as soon as we allocate them.
1086
1087 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1088
9c6c6f49
CY
10892011-10-27 Chong Yidong <cyd@gnu.org>
1090
9aba6043
SM
1091 * gnutls.c (emacs_gnutls_deinit): New function.
1092 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1093 (Fgnutls_deinit, Fgnutls_boot): Use it.
1094
1095 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1096 (deactivate_process): Call emacs_gnutls_deinit.
1097
657d08d3
JB
10982011-10-27 Juanma Barranquero <lekktu@gmail.com>
1099
1100 * image.c (x_create_x_image_and_pixmap):
1101 * w32.c (sys_rename, w32_delayed_load):
1102 * w32font.c (fill_in_logfont):
1103 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1104
5430d399
JB
11052011-10-26 Juanma Barranquero <lekktu@gmail.com>
1106
1107 * w32fns.c (w32_default_color_map): New function,
1108 extracted from Fw32_default_color_map.
a7ef684b 1109 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1110
fe0055fa
PE
11112011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1112
1113 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1114
e6346438
SM
11152011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1116
1117 * keyboard.c (test_undefined): New function (bug#9751).
1118 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1119
e112cc37
ET
11202011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1121
1122 * sysdep.c (init_sys_modes): Fix the check for the controlling
1123 terminal (Bug#6649).
1124
7b5d6677
EZ
11252011-10-20 Eli Zaretskii <eliz@gnu.org>
1126
1127 * dispextern.h (struct bidi_it): New member next_en_type.
1128
1129 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1130 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1131 current character, check also for next_en_type being WEAK_EN.
1132 (bidi_resolve_weak): Don't enter the expensive loop if the current
1133 position is before next_en_pos. Record the bidi type of the first
1134 non-ET, non-BN character we find, in addition to its position.
1135 (bidi_level_of_next_char): Invalidate next_en_type when
1136 next_en_pos is over-stepped.
1137
7da0b018
PE
11382011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1139
1140 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1141 * editfns.c: Rewrite current-time-zone so that it invokes
1142 the equivalent of (format-time-string "%Z") to get the time zone name.
1143 This fixes a bug when the time zone name contains characters that
1144 need converting from the system time locale to Emacs internal format.
1145 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1146 that patch fixed format-time-string to do the conversion, but
1147 I forgot to fix current-time-zone.
1148 (format_time_string): New function, containing most of
1149 what Fformat_time_string used to contain.
1150 (Fformat_time_string): Rewrite in terms of format_time_string.
1151 This doesn't change this function's behavior.
1152 (current-time-zone): Rewrite to use format_time_string.
1153 This fixes the bug reported by Michael Schierl in
1154 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1155 Jason Rumney's 2007-06-07 change worked around this bug, but
1156 didn't fix it.
1157 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1158
8547b010
EZ
11592011-10-19 Eli Zaretskii <eliz@gnu.org>
1160
1161 * xdisp.c (start_display): If the character at POS is displayed
1162 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1163 (try_window_reusing_current_matrix): If a line ends in a display
1164 vector or the next line starts in a display vector, continue
1165 redrawing the window even though the character position of
1166 start_row was reached.
8547b010
EZ
1167 (Bug#9771, part 2)
1168
4e948d15
CY
11692011-10-18 Chong Yidong <cyd@gnu.org>
1170
1171 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1172 with nobreak-char-display too.
1173
4787455f
EZ
11742011-10-18 Eli Zaretskii <eliz@gnu.org>
1175
1176 Fix part 3 of bug#9771.
1177 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1178 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1179 non-neutral characters if the current character is a paragraph
1180 separator (a.k.a. Newline). This avoids running the same
1181 expensive loop twice, once when we consume the preceding newline
1182 and the other time when the line actually needs to be displayed.
1183 Avoid the loop when we see neutrals on the base embedding level
1184 following a character whose directionality is the same as the
1185 paragraph's. This avoids running the expensive loop when a line
1186 ends in a long sequence of neutrals, like control characters.
1187 Add assertion against STRONG_AL type. Slightly rearrange code
1188 that determines the type of a neutral given the first non-neutral
1189 that follows it.
1190 (bidi_level_of_next_char): Set next_en_pos to zero when
1191 invalidating its info.
1192
2c91f553
EZ
11932011-10-17 Eli Zaretskii <eliz@gnu.org>
1194
1195 * xdisp.c (push_display_prop): Determine whether to record string
1196 or buffer position by IT->string, not by IT->method. Allow
1197 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1198 (move_it_vertically_backward): Don't look for character position
1199 immediately after the newline when in a continuation line.
1200 (Bug#9771, part 1)
2c91f553 1201
c7b08b0d
MR
12022011-10-15 Martin Rudalics <rudalics@gmx.at>
1203
1204 * window.c (coordinates_in_window): Rewrite and delabelize
1205 vertical border check. (Bug#5357) (Bug#9618)
1206
6b02f655
SM
12072011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1208
1209 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1210 errors in XSetWindowBorder (bug#9310).
1211
81d40c92
DA
12122011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1213
1214 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1215 avoid crash when xmalloc overrun checking is enabled.
1216
d4172c3b
EZ
12172011-10-13 Eli Zaretskii <eliz@gnu.org>
1218
1219 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1220 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1221 cursor motion with <left> and <right> arrow keys.
1222
1223 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1224 some callers set that themselves.
1225
b00eea75
EZ
12262011-10-12 Eli Zaretskii <eliz@gnu.org>
1227
1228 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1229 display string and the previous row comes from the same string and
1230 is empty. (Bug#9739) (Bug#9738)
1231
8fe012c4
SM
12322011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1233
1234 * doc.c (get_doc_string): Encode file name (bug#9735).
1235
0074aef2
EZ
12362011-10-12 Eli Zaretskii <eliz@gnu.org>
1237
79beb178
EZ
1238 * bidi.c (bidi_level_of_next_char):
1239 * xdisp.c (get_visually_first_element): Remove old incorrect
1240 comments regarding the Unicode Line Separator character.
1241
0074aef2
EZ
1242 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1243
6e4b3fbe
DA
12442011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1245
1246 * alloc.c (Fgc_status): Do not access beyond zombies array
1247 boundary if nzombies > MAX_ZOMBIES.
1248 * alloc.c (dump_zombies): Add missing format specifier.
1249
0324f3af
PE
12502011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1251
b5525cac
PE
1252 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1253 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1254
0324f3af
PE
1255 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1256 Some packages use them to denote characters with modifiers.
1257
e9b5f888
AS
12582011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1259
1260 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1261 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1262 matching a pp-number. Rename parameter var to var1.
1263
127827c0
SM
12642011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1265
1266 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1267
c8fd3bd0
GM
12682011-10-08 Glenn Morris <rgm@gnu.org>
1269
1270 * callint.c (Fcall_interactively): Give a more explicit error for the
1271 'c' case with a non-character input. (Bug#8479)
1272
352ec8ff
EZ
12732011-10-08 Eli Zaretskii <eliz@gnu.org>
1274
03669ccb
EZ
1275 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1276 lines.
7061c986
EZ
1277 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1278 lines that are hscrolled on the left.
03669ccb 1279
352ec8ff
EZ
1280 * dispnew.c (buffer_posn_from_coords): Account for a possible
1281 presence of header-line. (Bug#4426)
1282
a66cfb1c
SM
12832011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1284
6b02f655
SM
1285 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1286 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1287
7c5ee88e
PE
12882011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1289
1290 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1291 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1292 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1293 this makes Emacs dump core during garbage collection on rare
1294 occasions. sizeof is obviously inferior to offsetof here, so
1295 stick with offsetof.
1296 (GC_POINTER_ALIGNMENT): New macro.
1297 (mark_memory): Omit 3rd (offset) arg; caller changed.
1298 Don't assume EMACS_INT alignment is the same as pointer alignment.
1299
df1bbe5b
SM
13002011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1301
1302 * keyboard.c (read_key_sequence_remapped): New var.
1303 (read_key_sequence): Compute remapping in the right buffer.
1304 (command_loop_1): Use read_key_sequence's remapping directly.
1305
51553db6
SM
13062011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1307
32c1fffd
SM
1308 * dired.c (file_name_completion): Don't expand file name.
1309 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1310 before checking file name handler.
1311
51553db6
SM
1312 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1313 they've been requested explicitly (bug#9591).
1314
b6bd1599 13152011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1316
1317 * keymap.c (Fsingle_key_description): Use make_specified_string
1318 instead of build_string to build string from push_key_description.
1319 (Bug#5193)
1320
f701dc2a
PE
13212011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1322
4222c55d
PE
1323 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1324 This fixes a Y2038 bug on 64-bit hosts.
1325 * buffer.c (reset_buffer):
1326 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1327 (Fclear_buffer_auto_save_failure):
1328 Use 0, not -1, to represent an unset failure time, since time_t
1329 might not be signed.
1330
f701dc2a
PE
1331 Remove dependency on glibc malloc internals.
1332 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1333 Move back here from lisp.h, but with their new implementations.
1334 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1335 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1336 * charset.c (charset_table_init): New static var.
1337 (syms_of_charset): Use it instead of xmalloc. This removes a
1338 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1339 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1340 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1341 Move back to alloc.c.
1342 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1343 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1344
9ceebf39
JD
13452011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1346
1347 * nsterm.m (windowDidResize): Call x_set_window_size only when
1348 ns_in_resize is true. Otherwise set pixelwidth/height and
1349 call change_frame_size (Bug#9628).
1350
cb993c58
PE
13512011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1352
3930c88b
PE
1353 Port --enable-checking=all to Fedora 14 x86-64.
1354 * charset.c (syms_of_charset): Also account for glibc malloc's
1355 internal overhead when calculating the initial malloc maximum.
1356
cb993c58
PE
1357 Port --enable-checking=all to Fedora 14 x86.
1358 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1359 Move to lisp.h.
1360 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1361 (overrun_check_realloc, overrun_check_free):
1362 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1363 That way, xmalloc returns a properly-aligned pointer even if
1364 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1365 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1366 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1367 into account when calculating the initial malloc maximum.
1368 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1369 Move here from alloc.c, so that charset.c can use it too.
1370 Properly align; the old code wasn't right for common 32-bit hosts
1371 when configured with --enable-checking=all.
1372 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1373 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1374
31bed486
EZ
13752011-09-29 Eli Zaretskii <eliz@gnu.org>
1376
04c70788 1377 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1378 use EDOM.
1379
fbcaa2f3
EZ
13802011-09-28 Eli Zaretskii <eliz@gnu.org>
1381
1382 * xdisp.c (compute_display_string_end): If there's no display
1383 string at CHARPOS, return -1.
1384
1385 * bidi.c (bidi_fetch_char): When compute_display_string_end
1386 returns a negative value, treat the character as a normal
1387 character not covered by a display string. (Bug#9624)
1388
a239d4e9
JB
13892011-09-28 Juanma Barranquero <lekktu@gmail.com>
1390
1391 * lread.c (Fread_from_string): Fix typo in docstring.
1392
88652fd5
EZ
13932011-09-27 Eli Zaretskii <eliz@gnu.org>
1394
1395 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1396 newline, reseat the iterator instead of bidi-iterating there one
1397 character at a time. (Bug#9610)
32c1fffd
SM
1398 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1399 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1400
ed497dd4
AS
14012011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1402
1403 * lread.c (readevalloop): Use correct code for NBSP.
1404 (read1): Likewise. (Bug#9608)
1405
b2bf61aa
MA
14062011-09-25 Michael Albinus <michael.albinus@gmx.de>
1407
1408 * dbusbind.c (Fdbus_register_signal): When service is not
1409 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1410
32bbb17c
GM
14112011-09-25 Glenn Morris <rgm@gnu.org>
1412
1413 * buffer.c (truncate-lines): Doc fix.
1414
94e0933e
CY
14152011-09-24 Chong Yidong <cyd@stupidchicken.com>
1416
1417 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1418 (Fset_window_next_buffers): Doc fix.
1419
cddde921
GM
14202011-09-24 Glenn Morris <rgm@gnu.org>
1421
1422 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1423
1260aef1
PE
14242011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1425
25b4bfa0
PE
1426 Fix minor problems found by static checking.
1427 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1428 * indent.c (Fvertical_motion): Fix == vs = typo.
1429
e3cbd34b
EZ
14302011-09-24 Eli Zaretskii <eliz@gnu.org>
1431
a66cfb1c
SM
1432 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1433 Default value is now t. Doc fix.
6bf7006f 1434
e3cbd34b 1435 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1436 logic when moving up, not only when moving down. Fix the
e3cbd34b 1437 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1438 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1439
1440 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1441 CHARPOS is covered by a display string which includes newlines.
1442 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1443 is covered by a display string with embedded newlines.
1444
a3de0cbd
MA
14452011-09-24 Michael Albinus <michael.albinus@gmx.de>
1446
1447 * dbusbind.c (Fdbus_register_signal): Add match rule to
1448 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1449 (Fdbus_register_method, Vdbus_registered_objects_table):
1450 Fix docstring.
a3de0cbd 1451
b260039d
JM
14522011-09-24 Jim Meyering <meyering@redhat.com>
1453
32c1fffd 1454 do not ignore write error for any output size
b260039d
JM
1455 The previous change was incomplete.
1456 While it makes emacs --batch detect the vast majority of stdout
1457 write failures, errors were still ignored whenever the output size is
1458 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1459 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1460 && echo FAIL: ignored write error
1461 FAIL: ignored write error
1462 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1463 && echo FAIL: ignored write error
1464 FAIL: ignored write error
1465 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1466
8eca8a7c
AS
14672011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1468
1469 * emacs.c (Fkill_emacs): In noninteractive mode exit
1470 non-successfully if a write error occurred on stdout. (Bug#9574)
1471
3341db62
EZ
14722011-09-21 Eli Zaretskii <eliz@gnu.org>
1473
1474 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1475 the xassert test.
1476
1477 * dispextern.h (struct it): Update the comment documenting what
1478 can it->OBJECT be.
1479
8c203dbf
EZ
14802011-09-20 Eli Zaretskii <eliz@gnu.org>
1481
1482 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1483 a display string, extend search for cursor position to end of row.
1484 (find_row_edges): If the row ends in a newline from a display
1485 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1486 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1487 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1488 non-empty line. Fixes confusing cursor motion with arrow keys at
1489 the beginning of a line that starts with whitespace.
8c203dbf 1490
a4824228
LMI
14912011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1492
1493 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1494 (bug#9493).
1495
33ed493b
CY
14962011-09-18 Chong Yidong <cyd@stupidchicken.com>
1497
1498 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1499 boolean (Bug#9154).
1500
56cd55c8
EZ
15012011-09-18 Eli Zaretskii <eliz@gnu.org>
1502
1503 * xdisp.c (display_line): Record maximum and minimum buffer
1504 positions even if no glyphs were produced (e.g., by a zero-width
1505 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1506 buffer positions that will be removed from the glyph row because
1507 they don't fit.
c02dcedf
EZ
1508 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1509 column is beyond frame width: don't subtract 1 "pixel" when
1510 computing width of the stretch.
3e62b7e0
EZ
1511 (reseat_at_next_visible_line_start): Undo the change made on
1512 2011-09-17 that saved paragraph information and restored it after
1513 the call to `reseat'. (Bug#9545)
56cd55c8 1514
5ed99d36 15152011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1516
1517 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1518 and turn window cursor on if cleared (Bug#9415).
1519
5ed99d36 15202011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1521
1522 * search.c (boyer_moore): Take unibyte characters from pattern
1523 literally. (Bug#9458)
1524
9bade7b2
EZ
15252011-09-18 Eli Zaretskii <eliz@gnu.org>
1526
1527 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1528
e5e9d610
PE
15292011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1530
87e4427a
PE
1531 Fix minor problem found by static checking.
1532 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1533 initialized, to pacify gcc -Wuninitialized.
1534
e5e9d610
PE
1535 * fileio.c: Report proper errno when syscall falls.
1536 (Finsert_file_contents): Save and restore errno,
1537 so that report_file_error outputs the correct diagnostic.
1538 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1539
a1674f0b
EZ
15402011-09-18 Eli Zaretskii <eliz@gnu.org>
1541
1542 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1543
fbfb6dd4
EZ
15442011-09-17 Eli Zaretskii <eliz@gnu.org>
1545
1546 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1547 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1548
bb187662
EZ
15492011-09-17 Eli Zaretskii <eliz@gnu.org>
1550
1137e8b8 1551 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1552 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1553
1554 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1555 (bidi_find_paragraph_start): Search back for paragraph beginning
1556 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1557 (bidi_move_to_visually_next): Only trigger paragraph-related
1558 computations when the last character is a newline or at EOB, not
1559 just any NEUTRAL_B. (Bug#9470)
1560
bb187662
EZ
1561 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1562 truncated lines if point is covered by a display string. (Bug#9524)
1563
2e621251
PE
15642011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1565
1566 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1567 (cons_to_x_long): New function.
1568 (lisp_data_to_selection_data): Use it. Correct the test for
1569 short-versus-long data; it was negated. Break out of vector
1570 loop, for efficiency, when a long datum is discovered.
1571
91a15bc6
SM
15722011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1573
1574 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1575
b41c3a35
EZ
15762011-09-16 Eli Zaretskii <eliz@gnu.org>
1577
1578 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1579 GCC PR/17406) by declaring this function with external scope.
1580
7812ba2d
PE
15812011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1582
1583 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1584 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1585
cf7edc2a
AS
15862011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1587
1588 * editfns.c (Fformat): Correctly handle text properties on "%%".
1589
bd01620e
EZ
15902011-09-15 Eli Zaretskii <eliz@gnu.org>
1591
1592 * xterm.c (x_draw_composite_glyph_string_foreground):
1593 * w32term.c (x_draw_composite_glyph_string_foreground):
1594 * term.c (encode_terminal_code):
1595 * composite.c (composition_update_it, get_composition_id):
1596 * xdisp.c (get_next_display_element)
1597 (fill_composite_glyph_string): Add comments about special meaning
1598 of TAB characters in a composition.
1599
a02719a3
PE
16002011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1601
1602 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1603 This occurs when processing a multibyte format.
1604 Problem reported by Wolfgang Jenker.
a02719a3 1605
72589a3c
JB
16062011-09-15 Johan Bockgård <bojohan@gnu.org>
1607
1608 * xdisp.c (try_cursor_movement): Only check for exact match if
1609 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1610
1c14176c
PE
16112011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1612
1613 Remove unused external symbols.
1614 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1615 * xdisp.c (calc_pixel_width_or_height): Now static.
1616 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1617 * indent.c (check_display_width):
1618 * w32term.c: Fix comment to match code.
1619 * xterm.c, xterm.h (x_catching_errors): Remove.
1620
d2eea5b5
PE
16212011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1622
1623 * xselect.c: Use signed conversions more consistently (Bug#9498).
1624 (selection_data_to_lisp_data): Assume incoming selection data are
1625 signed integers, not unsigned. This is to be consistent with
1626 outgoing selection data, which was modified to use signed integers
1627 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1628 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1629 expects long, not unsigned long.
1630
46888499
EZ
16312011-09-14 Eli Zaretskii <eliz@gnu.org>
1632
1633 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1634 computation of loop end. Reported by Johan Bockgård
1635 <bojohan@gnu.org>.
1636
ef8ef9fb
CY
16372011-09-13 Chong Yidong <cyd@stupidchicken.com>
1638
1639 * frame.c (Fother_visible_frames_p): Function deleted.
1640
fa819fed
EZ
16412011-09-12 Eli Zaretskii <eliz@gnu.org>
1642
1643 * indent.c (compute_motion): Process display vector front to back
1644 rather than the other way around. (Bug#2496)
1645
2ba8e008
SM
16462011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1647
1648 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1649
20f53c69
CY
16502011-09-11 Chong Yidong <cyd@stupidchicken.com>
1651
1652 * minibuf.c (Fread_from_minibuffer): Doc fix.
1653
d562d7a4
EZ
16542011-09-11 Eli Zaretskii <eliz@gnu.org>
1655
1656 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1657 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1658
1c4d7f3d
LMI
16592011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1660
1661 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1662 value for non-existent files.
1663
b885bf36
EZ
16642011-09-11 Eli Zaretskii <eliz@gnu.org>
1665
1666 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1667 set its "size" to -1. This will set the modtime_size field of
1668 the corresponding buffer to -1, which is what
1669 verify-visited-file-modtime expects for files that do not exist.
1670 (Bug#9139)
1671
6612f0bf
PE
16722011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1673
1674 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1675 here ...
1676 * lisp.h: ... from here. push_key_description is no longer
1677 defined in keyboard.c, so its declaration should not be in
1678 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1679 logically belongs with push_key_description.
1680
dfb3f755
PE
16812011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1682
1683 * buffer.h: Include <sys/types.h> instead of <time.h>.
1684 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1685 Problem reported by Herbert J. Skuhra.
1686
3134906c
LMI
16872011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1688
1689 * xml.c (parse_region): Make the parsing work for
1690 non-comment-starting XML files again (bug#9144).
1691
8d903f4e
AS
16922011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1693
1694 * image.c (gif_load): Fix calculation of bottom and right corner.
1695 (Bug#9468)
1696
80ad64f4
EZ
16972011-09-10 Eli Zaretskii <eliz@gnu.org>
1698
1699 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1700 redisplay in small windows.
1701
208a048d
EZ
17022011-09-09 Eli Zaretskii <eliz@gnu.org>
1703
1704 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1705
9b1c252e
MR
17062011-09-08 Martin Rudalics <rudalics@gmx.at>
1707
1708 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1709 Operate on live windows only.
1710
2949f33b
JB
17112011-09-08 Juanma Barranquero <lekktu@gmail.com>
1712
1713 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1714
e08dcafd
EZ
17152011-09-07 Eli Zaretskii <eliz@gnu.org>
1716
1717 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1718 only under bidi iteration.
1719
115b96bd
JD
17202011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1721
1722 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1723
c8199d0f
PE
17242011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1725
1726 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1727 Without this fix, the command to link temacs failed due to an
1728 undefined symbol __builtin_isnan. This is because
1729 /usr/include/iso/math_c99.h #defines isnan(x) to
1730 __builtin_isnan(x), but the bundled gcc, which identifies itself
1731 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1732 a __builtin_isnan.
1733 * floatfns.c (isnan): #undef, and then #define to a clone of
1734 what's in data.c.
1735 (Fisnan): Always define, since it's always available now.
1736 (syms_of_floatfns): Always define isnan at the Lisp level.
1737
e39b275c 17382011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1739
1740 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1741
b2db44d9 17422011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1743
f4af5137 1744 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1745 The previous code assumed that file offsets (off_t values) fit in
1746 EMACS_INT variables, which is not true on typical 32-bit hosts.
1747 The code messed up by falsely reporting buffer overflow in cases
1748 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1749 when "big" contains more than 2**29 bytes, even though this
1750 inserts just one byte and does not overflow the buffer.
1751 (Finsert_file_contents): Store file offsets as off_t
1752 values, not as EMACS_INT values. Check for overflow when
1753 converting between EMACS_INT and off_t. When checking for
1754 buffer overflow or for overlap, take the offsets into account.
1755 Don't use EMACS_INT for small values where int suffices.
1756 When checking for overlap, fix a typo: ZV was used where
1757 ZV_BYTE was intended.
1758 (Fwrite_region): Don't assume off_t fits into 'long'.
1759 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1760
ecfc0a49
MA
17612011-09-05 Michael Albinus <michael.albinus@gmx.de>
1762
1763 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1764
6511acf2 17652011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1766
0999621a 1767 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1768
1769 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1770 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1771 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1772 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1773 (modify_event_symbol): Do not assume that the length of
1774 name_alist_or_stem is safe to alloca and fits in int.
1775 (Fexecute_extended_command): Likewise for function name and binding.
1776 (Frecursion_depth): Wrap around reliably on integer overflow.
1777 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1778 since some callers pass EMACS_INT values.
1779 (Fsingle_key_description): Don't crash if symbol name contains more
1780 than MAX_ALLOCA bytes.
1781 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1782 (get_minibuffer): Arg is now EMACS_INT, not int.
1783 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1784 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1785 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1786
2be7d702
PE
1787 * dbusbind.c (signature_cat): New function.
1788 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1789 Do not overrun buffer; instead, report string overflow.
1790
9d1df220
PE
1791 * dispnew.c (add_window_display_history): Don't overrun buffer.
1792 Truncate instead; this is OK since it's just a log.
1793
33ef5c64
PE
1794 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1795 even if the time zone offset is outlandishly large.
1796 Don't mishandle offset == INT_MIN.
1797
66c6fdd5
PE
1798 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1799 when creating daemon; the previous buffer-overflow check was incorrect.
1800
d749b01b
PE
1801 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1802 which has the guts of the old verror function.
1803
b5cd1905
PE
1804 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1805 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1806
6e1a67fb
PE
1807 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1808 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1809 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1810 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1811 length of string rather than counting it via multiple sprintfs;
1812 that's simpler and more reliable.
c21721cc
PE
1813 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1814 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1815 sprintf, in case result does not fit in int.
1816
c57b67fc
PE
1817 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1818 (fontset_from_font): Print it.
1819
8a401434
PE
1820 * frame.c (tty_frame_count): Now printmax_t, not int.
1821 (make_terminal_frame, set_term_frame_name): Print it.
1822 (x_report_frame_params): In X, window IDs are unsigned long,
1823 not signed long, so print them as unsigned.
1824 (validate_x_resource_name): Check for implausibly long names,
1825 and don't assume name length fits in 'int'.
1826 (x_get_resource_string): Don't blindly alloca invocation name;
1827 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1828 not fit in int.
1829
6e1a67fb
PE
1830 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1831 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1832 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1833
0df02bf3
PE
1834 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1835 Use esprintf, not sprintf, in case result does not fit in int.
1836
48e30793
PE
1837 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1838 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1839 it as a large positive number.
1840 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1841 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1842
a66ff6d8
PE
1843 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1844 in case result does not fit in int.
1845
aca216ff
PE
1846 * print.c (float_to_string): Detect width overflow more reliably.
1847 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1848 buffer overrun. Don't assume list length fits in 'int'. Treat
1849 print length of 0 as 0, not as infinity; to be consistent with other
1850 uses of print length in this function. Don't overflow print length
1851 index. Don't assume hash table size fits in 'long', or that
1852 vectorlike size fits in 'unsigned long'.
1853
31c286f7
PE
1854 * process.c (make_process): Use printmax_t, not int, to format
1855 process-name gensyms.
1856
55e5faa1
PE
1857 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1858
80f2e268
PE
1859 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1860 to avoid potential buffer overrun.
1861
670741ab
PE
1862 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1863 if X resource line is longer than 512 bytes.
1864
b7163a50
PE
1865 * xfns.c (x_window): Make sprintf buffer a bit bigger
1866 to avoid potential buffer overrun.
1867
ae58ff1f
PE
1868 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1869
c43c8a6a
PE
1870 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1871
3f8236f4
PE
18722011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1873
53e9fe90 1874 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1875 Without these, Emacs silently mishandles large integers sometimes.
1876 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1877 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1878
6511acf2
PE
1879 * xdisp.c (try_window_id): Check Emacs fixnum range before
1880 converting to 'int'.
806add1d 1881
6511acf2 1882 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1883 Check that an Emacs fixnum is in range before assigning it to 'int'.
1884 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1885 values converted from Emacs fixnums.
1886 (Frecenter): Don't wrap around a line count if it is out of 'int'
1887 range; instead, treat it as an extreme value.
1888 (Fset_window_configuration, compare_window_configurations):
1889 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1890
6511acf2
PE
1891 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1892 that can exceed INT_MAX. Check that EMACS_INT value is in range
1893 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1894 (match_limit): Don't assume that a fixnum can fit in 'int'.
1895
6511acf2 1896 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1897 exceed INT_MAX.
1898
6511acf2 1899 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1900 (Fvertical_motion): Don't wrap around LINES values that don't fit
1901 in 'int'. Instead, treat them as extreme values. This is good
1902 enough for windows, which can't have more than INT_MAX lines anyway.
1903
fcb901a7
LMI
19042011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1905
0f2f6b6d
LMI
1906 * Require libxml/parser.h to avoid compilation warning.
1907
fcb901a7
LMI
1908 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1909
1910 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1911 since this reportedly can destroy thread storage.
1912
6e20a0d4
CY
19132011-08-30 Chong Yidong <cyd@stupidchicken.com>
1914
1915 * syntax.c (find_defun_start): Update all cache variables if
1916 exiting early (Bug#9401).
1917
148ae00e
EZ
19182011-08-30 Eli Zaretskii <eliz@gnu.org>
1919
f6cfbd8f
EZ
1920 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1921
148ae00e
EZ
1922 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1923 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1924 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1925
1926 * term.c (tty_append_glyph): New function.
1927 (produce_stretch_glyph): Static function and its prototype deleted.
1928
a66cfb1c
SM
1929 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1930 Add prototypes.
148ae00e 1931
c4a07a4c
PE
19322011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1933
1934 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1935 when checking :margin (Bug#9390).
1936 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1937 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1938 so that the name doesn't mislead. All uses changed.
1939
6bc8cd65
JB
19402011-08-28 Johan Bockgård <bojohan@gnu.org>
1941
1942 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1943 set_tty_hooks.
1944
dca4927e
EZ
19452011-08-27 Eli Zaretskii <eliz@gnu.org>
1946
1947 * xdisp.c (move_it_to): Don't bail out early when reaching
1948 position beyond to_charpos, if we are scanning backwards.
1949 (move_it_vertically_backward): When DY == 0, make sure we get to
1950 the first character in the line after the newline.
1951
f2cad773
PE
19522011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1953
1954 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1955 (ccl_driver): Do not generate an out-of-range pointer.
1956 (Fccl_execute_on_string): Remove unnecessary check for
1957 integer overflow, noted by Stefan Monnier in
1958 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1959 Remove a FIXME that didn't need fixing.
1960 Simplify the newly-introduced buffer reallocation code.
1961
0cae2cdb
JB
19622011-08-27 Juanma Barranquero <lekktu@gmail.com>
1963
1964 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1965
5fc295a4 19662011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1967
70c60eb2 1968 Integer and memory overflow issues (Bug#9196).
726e0ab1 1969
d31850da
PE
1970 * doc.c (get_doc_string): Rework so that
1971 get_doc_string_buffer_size is the actual buffer size, rather than
1972 being 1 less than the actual buffer size; this makes xpalloc more
1973 convenient.
1974
a69fbedb
PE
1975 * image.c (x_allocate_bitmap_record, cache_image):
1976 * xselect.c (Fx_register_dnd_atom):
1977 Simplify previous changes by using xpalloc.
1978
fe5c5d37
PE
1979 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1980 since either will do and ptrdiff_t is convenient with xpalloc.
1981
0065d054
PE
1982 * charset.c (charset_table_size)
1983 (struct charset_sort_data.priority): Now ptrdiff_t.
1984 (charset_compare): Don't overflow if priorities differ greatly.
1985 (Fsort_charsets): Don't assume list length fits in int.
1986 Check for size-calculation overflow when allocating sort data.
1987 (syms_of_charset): Allocate an initial charset table that is
1988 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1989
1990 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1991
1992 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1993 The actual value is always <= INT_MAX, and leaving it unsigned made
1994 overflow checking harder.
1995
1996 * dispextern.h (struct glyph_matrix.rows_allocated)
1997 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1998 with xpalloc. The values are still always <= INT_MAX.
1999
2000 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2001
2002 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2003 (SAFE_NALLOCA): New macro.
2004
2005 * region-cache.c (struct boundary.pos, find_cache_boundary)
2006 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2007 (set_cache_region, invalidate_region_cache)
2008 (revalidate_region_cache, know_region_cache, region_cache_forward)
2009 (region_cache_backward, pp_cache):
2010 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2011 so that ptrdiff_t * can be passed to xpalloc.
2012 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2013 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2014 (pp_cache): Don't assume cache_len fits in int.
2015 * region-cache.h: Adjust extern decls to match.
2016
2017 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2018 EMACS_INT, since either will do, for xpalloc.
2019
2020 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2021 (xnmalloc, xnrealloc, xpalloc): New functions.
2022
726e0ab1
PE
2023 * bidi.c (bidi_shelve_header_size): New constant.
2024 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2025 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2026
51f30bc5 2027 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2028 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2029 (overlay_strings):
2030 Don't update size of array until after memory allocation succeeds,
2031 because xmalloc/xrealloc may not return.
0065d054
PE
2032 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2033 now that we have proper integer overflow checking.
2034 (record_overlay_string, overlay_strings): Catch overflows when
2035 calculating size of overlay_str_buf.
726e0ab1 2036
0065d054
PE
2037 * callproc.c (Fcall_process): Check for size overflow when
2038 calculating size of args2.
2039 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2040 Normally we prefer signed values, but sticking with ptrdiff_t would
2041 require adding more-complicated checks.
726e0ab1
PE
2042
2043 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2044 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2045 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2046 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2047
2048 * character.c (Fstring): Check for size-calculation overflow.
2049
2050 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2051 unnecessary integer overflow. Check for size overflow.
2052 (encode_coding_object): Don't update size until xmalloc succeeds.
2053
2054 * composite.c (get_composition_id): Check for overflow in glyph
2055 length calculations.
2056
2057 Integer and memory overflow fixes for display code.
2058 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2059 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2060 (scrolling_window): Check for overflow in size calculations.
2061 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2062 Don't assume glyph table len fits in int.
2063 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2064 (row_table_size): Now ptrdiff_t, not int.
2065 (scrolling_window): Avoid overflow in size calculations.
2066 Don't update size until allocation succeeds.
2067 * fns.c (concat): Check for overflow in size calculations.
2068 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2069 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2070 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2071
2072 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2073 (get_doc_string): Check for size calculation overflow.
2074 Don't update size until allocation succeeds.
2075 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2076 EMACS_INT, where ptrdiff_t will do.
2077 (Fsubstitute_command_keys): Check for string overflow.
2078
2079 * editfns.c (set_time_zone_rule): Don't assume environment length
2080 fits in int.
2081 (message_length): Now ptrdiff_t, not int.
2082 (Fmessage_box): Don't update size until allocation succeeds.
2083 Don't assume message length fits in int.
2084 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2085
0065d054
PE
2086 * emacs.c (main): Do not reallocate argv, since there is a null at
2087 the end that can be overwritten, and this way there's no need to
2088 worry about size-calculation overflow.
2089 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2090
2091 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2092 alloc succeeds.
2093 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2094
2095 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2096 (x_set_scroll_bar_width, x_figure_window_size):
2097 Check for integer overflow.
2098 (x_set_alpha): Do not assume XINT fits in int.
2099
2100 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2101 This is for the members text_lines, text_cols, total_lines, total_cols,
2102 where the system imposes an 'int' limit.
2103
2104 * fringe.c (Fdefine_fringe_bitmap):
2105 Don't update size until alloc works.
2106
2107 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2108 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2109
2110 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2111 Check for size-calculation overflow.
2112 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2113 do, as we prefer signed integers.
2114 (id_to_widget.max_size, id_to_widget.used)
2115 (xg_store_widget_in_map, xg_remove_widget_from_map)
2116 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2117 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2118 Use and return ptrdiff_t, not int.
2119 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2120 * gtkutil.h: Change prototypes to match the above.
2121
2122 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2123 are duplicate now that they've been promoted to lisp.h.
2124 (x_allocate_bitmap_record, x_alloc_image_color)
2125 (make_image_cache, cache_image, xpm_load):
2126 Don't update size until alloc is done.
2127 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2128 (x_detect_edges):
3256efce 2129 Check for size calculation overflow.
726e0ab1
PE
2130 (ct_colors_allocated_max): New constant.
2131 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2132 overflow.
3256efce 2133
726e0ab1
PE
2134 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2135 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2136 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2137 Use ptrdiff_t, not int, to count maps.
2138 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2139 calculations. Don't update size until allocation succeeds.
2140 Redo calculations to avoid overflow.
726e0ab1
PE
2141 * keyboard.h: Change prototypes to match the above.
2142
2143 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2144 to count maps.
2145 (current_minor_maps): Check for size calculation overflow.
2146 * keymap.h: Change prototypes to match the above.
2147
2148 * lread.c (read1, init_obarray): Don't update size until alloc done.
2149
2150 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2151 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2152
726e0ab1
PE
2153 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2154 Now ptrdiff_t, not int.
2155 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2156 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2157
2158 * process.c (Fnetwork_interface_list): Check for overflow
2159 in size calculation.
2160
2161 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2162
2163 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2164 overflow. Don't bother calling xmalloc when xrealloc will do.
2165
2166 * search.c (Freplace_match): Check for size calculation overflow.
2167 (Fset_match_data): Don't assume list lengths fit in 'int'.
2168
2169 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2170 for command line length. Do not attempt to address one before the
2171 beginning of an array, as that's not portable.
2172
2173 * term.c (max_frame_lines): Remove; unused.
2174 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2175 not int.
2176 (encode_terminal_code, calculate_costs): Check for size
2177 calculation overflow.
2178 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2179 table lengths and related sizes. Don't update size until alloc
2180 done. Redo calculations to avoid overflow.
2181 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2182
2183 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2184 subtracting pointers.
2185 (gobble_line): Check for overflow more carefully. Don't update size
2186 until alloc done.
2187
2188 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2189 Don't update size until alloc done.
2190 Redo size calculations to avoid overflow.
2191 Check for size calculation overflow.
0065d054 2192 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2193
2194 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2195 Use ptrdiff_t, not int, for sizes.
2196 (store_mode_line_noprop_char): Don't update size until alloc done.
2197
0065d054
PE
2198 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2199 Use ptrdiff_t, not int, for sizes.
2200 (Finternal_make_lisp_face, cache_face):
2201 Check for size calculation overflow.
2202 (cache_face): Treat size calculation overflows as if they were
2203 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2204
2205 * xfns.c (x_encode_text, x_set_name_internal)
2206 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2207 sizes, since they can exceed INT_MAX in size. Check for size
2208 calculation overflow.
2209
0065d054
PE
2210 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2211 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2212 Don't update size until alloc done.
2213
0065d054 2214 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2215 as sprintf is limited to int lengths.
1d526e2f 2216
252c5ee1
PE
2217 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2218 (X_LONG_MIN): New macros.
864d7ce7
PE
2219 Use them to make the following changes clearer.
2220 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2221 This change doesn't affect the value now, but it may help remind
2222 future maintainers not to raise the value too much later.
2223 (SELECTION_QUANTUM): Remove, replacing with ...
2224 (selection_quantum): ... new function, which avoids overflow.
2225 All uses changed.
2226 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2227 assumption that selection length fits in 'int'.
2228 (x_reply_selection_request, x_handle_selection_request)
2229 (x_get_window_property, receive_incremental_selection)
2230 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2231 (lisp_data_to_selection_data, clean_local_selection_data):
2232 Use ptrdiff_t, not int, to record length of selection.
2233 (x_reply_selection_request, x_get_window_property)
2234 (receive_incremental_selection, x_property_data_to_lisp):
2235 Redo calculations to avoid overflow.
2236 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2237 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2238 something.
2239 (x_get_window_property, receive_incremental_selection)
2240 (lisp_data_to_selection_data, x_property_data_to_lisp):
2241 Check for size-calculation overflow.
2242 (x_get_window_property, receive_incremental_selection)
2243 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2244 Don't store size until memory allocation succeeds.
2245 (x_get_window_property): Plug memory leak on memory exhaustion.
2246 Don't double-block input; malloc is safe here. Don't assume 2**34
2247 - 4 fits in unsigned long. Add an xassert to check
2248 XGetWindowProperty overflow. Be more careful about overflow
2249 calculations, and distinguish size from memory overflow better.
2250 (receive_incremental_selection): When tracing, don't assume
2251 unsigned int is less than INT_MAX.
2252 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2253 harmful) conversions of unsigned short to int.
2254 (lisp_data_to_selection_data): Don't assume that integers
2255 in the range -65535 through -1 fit in an X unsigned short.
2256 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2257 result parameters unless successful. Rely on cons_to_unsigned
2258 to report problems with elements; the old code wasn't right anyway.
2259 (x_check_property_data): Check for int overflow; we cannot use
2260 a wider type due to X limits.
2261 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2262
726e0ab1 2263 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2264
0065d054
PE
2265 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2266 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2267 (x_color_cells): Don't store size until memory allocation succeeds.
2268 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2269 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2270 (x_term_init): Don't assume length fits in int (sprintf is limited
2271 to int size).
bc18e09d 2272
ebfa62c0
PE
2273 Use ptrdiff_t for composition IDs.
2274 * character.c (lisp_string_width):
2275 * composite.c (composition_table_size, n_compositions)
2276 (get_composition_id, composition_gstring_from_id):
2277 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2278 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2279 * window.c (Frecenter):
2280 Use ptrdiff_t, not int, for composition IDs.
2281 * composite.c (get_composition_id): Check for integer overflow.
2282 * composite.h: Adjust prototypes to match the above changes.
2283
d3411f89
PE
2284 Use ptrdiff_t for hash table indexes.
2285 * category.c (hash_get_category_set):
2286 * ccl.c (ccl_driver):
2287 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2288 * coding.c (coding_system_charset_list, detect_coding_system):
2289 * coding.h (struct coding_system.id):
2290 * composite.c (get_composition_id, gstring_lookup_cache):
2291 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2292 * image.c (xpm_get_color_table_h):
2293 * lisp.h (hash_lookup, hash_put):
2294 * minibuf.c (Ftest_completion):
2295 Use ptrdiff_t for hash table indexes, not int (which is too
2296 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2297 32-bit --with-wide-int hosts).
2298
e097a6fa
PE
2299 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2300 Add a FIXME comment about memory leaks.
2301 (syms_of_charset): Don't assume xmalloc returns.
2302
5637687f
PE
2303 Don't assume that stated character widths fit in int.
2304 * character.c (Fchar_width, c_string_width, lisp_string_width):
2305 * character.h (CHAR_WIDTH):
2306 * indent.c (MULTIBYTE_BYTES_WIDTH):
2307 Use sanitize_char_width to avoid undefined and/or bad behavior
2308 with outlandish widths.
a66cfb1c 2309 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2310 now that we have two such functions. All uses changed.
2311 (sanitize_char_width): New inline function.
2312
a2271ba2
PE
2313 Don't assume that tab-width fits in int.
2314 * character.h (sanitize_width): New inline function.
2315 (SANE_TAB_WIDTH): New macro.
2316 (ASCII_CHAR_WIDTH): Use it.
2317 * indent.c (sane_tab_width): Remove. All uses replaced by
2318 SANE_TAB_WIDTH (current_buffer).
2319 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2320
18c52557
PE
2321 * fileio.c: Integer overflow issues with file modes.
2322 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2323
caeeedc1
PE
2324 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2325 Remove unreachable code.
2326 (read_hex, load_charset_map_from_file): Check for integer overflow.
2327
50849c52
PE
2328 * xterm.c: don't go over XClientMessageEvent limit
2329 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2330 (x_send_scroll_bar_event): Likewise. Check that the size does not
2331 exceed limits imposed by XClientMessageEvent, as well as the usual
2332 ptrdiff_t and size_t limits.
2333
b13995db
PE
2334 * keyboard.c: Overflow, signedness and related fixes.
2335 (make_lispy_movement): Use same integer type in forward decl
2336 that is used in the definition.
2337 (read_key_sequence, keyremap_step):
2338 Change bufsize argument back to int, undoing my 2011-03-30 change.
2339 We prefer signed types, and int is wide enough here.
2340 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2341 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2342 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2343 length, not size_t. Use ptrdiff_t for index, not int.
2344 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2345 possibility of integer overflow.
2346
13464394
PE
2347 Overflow, signedness and related fixes for images.
2348
2349 * dispextern.h (struct it.stack[0].u.image.image_id)
2350 (struct_it.image_id, struct image.id, struct image_cache.size)
2351 (struct image_cache.used, struct image_cache.ref_count):
2352 * gtkutil.c (update_frame_tool_bar):
2353 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2354 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2355 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2356 * nsmenu.m (update_frame_tool_bar):
2357 * xdisp.c (calc_pixel_width_or_height):
2358 * xfns.c (image_cache_refcount):
2359 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2360 on typical 64-bit hosts.
2361
2362 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2363 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2364 Omit unnecessary casts to int.
2365 (parse_image_spec): Check that integers fall into 'int' range
2366 when the callers expect that.
2367 (image_ascent): Redo ascent calculation to avoid int overflow.
2368 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2369 (lookup_image): Remove unnecessary tests.
2370 (xbm_image_p): Locals are now of int, not EMACS_INT,
2371 since parse_image_check makes sure they fit into int.
2372 (png_load, gif_load, svg_load_image):
2373 Prefer int to unsigned where either will do.
2374 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2375 old tiff_error_handler and tiff_warning_handler.
2376 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2377 stack buffer overflows. It uses only the features of vsnprintf
2378 that are common to both POSIX and native Microsoft.
2379 (tiff_error_handler, tiff_warning_handler): Use it.
2380 (tiff_load, gif_load, imagemagick_load_image):
2381 Don't assume :index value fits in 'int'.
2382 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2383 (imagemagick_load_image): Check that crop parameters fit into
2384 the integer types that MagickCropImage accepts. Don't assume
2385 Vimagemagick_render_type has a nonnegative value. Don't assume
2386 size_t fits in 'long'.
2387 (gs_load): Use printmax_t to print the widest integers possible.
2388 Check for integer overflow when computing image height and width.
2389
c11821d4
EZ
23902011-08-26 Eli Zaretskii <eliz@gnu.org>
2391
2392 * xdisp.c (redisplay_window): Don't force window start if point
2393 will be invisible in the resulting window. (Bug#9324)
2394
0c95fcf7
EZ
23952011-08-25 Eli Zaretskii <eliz@gnu.org>
2396
2397 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2398 the display spec is of the form `(space ...)'.
2399 (handle_display_spec): Return the value returned by
2400 handle_single_display_spec, not just 1 or zero.
2401 (handle_single_display_spec): If the display spec is of the form
2402 `(space ...)', and specifies display in the text area, return 2
2403 rather than 1.
fee65a97 2404 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2405 accurately, and prefer exact match for point under bidi.
2406 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2407
2408 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2409 into disp_prop; all users changed.
2410
2411 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2412 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2413 for the text covered by the display property.
2414
e4ed06f1
CY
24152011-08-25 Chong Yidong <cyd@stupidchicken.com>
2416
2417 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2418 Change return value to nil.
2419 (Frecord_buffer): Delete unused function.
2420
f67cdd7f
EZ
24212011-08-24 Eli Zaretskii <eliz@gnu.org>
2422
5980d4c6
EZ
2423 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2424 buffers, return left-to-right.
8610fe8b
EZ
2425 (set_cursor_from_row): Consider candidate row a win if its glyph
2426 represents a newline and point is on that newline. Fixes cursor
2427 positioning on the newline at EOL of R2L text within L2R
2428 paragraph, and vice versa.
2429 (try_cursor_movement): Check continued rows, in addition to
2430 continuation rows. Fixes unwarranted scroll when point enters a
2431 continued line of R2L text within an L2R paragraph, or vice versa.
2432 (cursor_row_p): Consider the case of point being equal to
2433 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2434 from the end of a short line to the beginning of a continued line
2435 of R2L text within L2R paragraph.
2436 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2437 composed characters.
5980d4c6 2438
f67cdd7f
EZ
2439 * bidi.c (bidi_check_type): Use xassert.
2440 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2441 members.
2442
bca633fb
EZ
24432011-08-23 Eli Zaretskii <eliz@gnu.org>
2444
2445 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2446 a character.
2447
4a5885a7
CY
24482011-08-23 Chong Yidong <cyd@stupidchicken.com>
2449
2450 * nsfont.m (ns_otf_to_script): Fix typo.
2451
0902a04e
KH
24522011-08-22 Kenichi Handa <handa@m17n.org>
2453
2454 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2455 extra slot even if the purpose is char-code-property-table.
2456
1a2e6670
EZ
24572011-08-23 Eli Zaretskii <eliz@gnu.org>
2458
8ddde651
EZ
2459 * xdisp.c (redisplay_window): When computing centering_position,
2460 account for the height of the header line. (Bug#8874)
2461
425cc014
EZ
2462 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2463 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2464 candidate is selected by the mouse, and that candidate has a
2465 composed character under the mouse.
2466
1a2e6670
EZ
2467 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2468 coordinates reported by pos-visible-in-window-p for a composed
2469 character in column zero.
2470
8b76d6f8
SM
24712011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2472
2473 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2474
dac347dd
EZ
24752011-08-22 Eli Zaretskii <eliz@gnu.org>
2476
2477 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2478 consider it a hit if to_charpos is anywhere in the range of the
2479 composed buffer positions.
2480
e013fb34
CY
24812011-08-22 Chong Yidong <cyd@stupidchicken.com>
2482
2483 * image.c (gif_load): Don't assume that each subimage has the same
2484 dimensions as the base image. Handle disposal method that is
2485 "undefined" by the gif spec (Bug#9335).
2486
bd1ba3e8
CY
24872011-08-20 Chong Yidong <cyd@stupidchicken.com>
2488
2489 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2490 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2491
54a1215b
EZ
24922011-08-19 Eli Zaretskii <eliz@gnu.org>
2493
823564e5
EZ
2494 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2495 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2496 from an Org mode buffer to a Speedbar frame.
2497
54a1215b
EZ
2498 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2499 a composition, take its buffer position from IT->cmp_it.charpos.
2500 Fixes cursor positioning at the beginning of a line that begins
2501 with a composed character.
2502
9778ebcc
EZ
25032011-08-18 Eli Zaretskii <eliz@gnu.org>
2504
0be6ee06
EZ
2505 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2506 character bidirectional type, use STRONG_L instead. Fixes crashes
2507 in a buffer produced by `describe-categories'.
2508
9778ebcc
EZ
2509 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2510 members before the level stack, so they would be saved and
2511 restored when copying iterator state. Fixes incorrect reordering
2512 around TABs covered by display properties.
2513
156bffbe
AS
25142011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2515
6b02f655 2516 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2517
72ad093b
CY
25182011-08-17 Chong Yidong <cyd@stupidchicken.com>
2519
2520 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2521 (internal_condition_case_2, internal_condition_case_n):
2522 Remove unnecessary aborts (Bug#9081).
72ad093b 2523
35774242
EZ
25242011-08-17 Eli Zaretskii <eliz@gnu.org>
2525
2526 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2527 has no `load' handler, try opening the file locally. (Bug#9311)
2528
db76dd85
KB
25292011-08-16 Ken Brown <kbrown@cornell.edu>
2530
2531 * gmalloc.c: Expand comment.
2532
b215eee5
EZ
25332011-08-16 Eli Zaretskii <eliz@gnu.org>
2534
2535 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2536 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2537
a4579d33
KB
25382011-08-16 Ken Brown <kbrown@cornell.edu>
2539
2540 Fix memory allocation problems in Cygwin build (Bug#9273).
2541
2542 * unexcw.c ( __malloc_initialized): Declare external variable.
2543 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2544
8b76d6f8
SM
2545 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2546 New variables.
a4579d33
KB
2547 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2548 dumped emacs.
2549 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2550 in the static heap.
2551 [CYGWIN] (special_realloc): New function.
2552 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2553 requests to realloc storage in the static heap.
2554
3ebec551
PE
25552011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2556
2557 * bidi.c (bidi_initialize): Remove unused local.
2558
9fd8be00
EZ
25592011-08-15 Eli Zaretskii <eliz@gnu.org>
2560
6b02f655
SM
2561 * bidimirror.h:
2562 * biditype.h: Remove file.
2563 * makefile.w32-in ($(BLD)/bidi.$(O)):
2564 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2565
2566 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2567
2568 * chartab.c: Improve commentary for the uniprop_table API.
2569
32413314
EZ
2570 * bidi.c (bidi_paragraph_init): Support zero value of
2571 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2572 (bidi_initialize): Use uniprop_table instead of including
2573 biditype.h and bidimirror.h.
32413314 2574
9fd8be00
EZ
2575 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2576 coordinates of the iterator when restoring from ppos_it.
2577 (Bug#9296)
2578
5cf2b69b
KH
25792011-08-14 Kenichi Handa <handa@m17n.org>
2580
2581 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2582 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2583
daf17d00
EZ
25842011-08-14 Eli Zaretskii <eliz@gnu.org>
2585
2586 * xdisp.c (move_it_in_display_line_to): Don't invoke
2587 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2588 ppos_it. Fixes vertical cursor motion when line beginning is
2589 covered by an image. (Bug#9296)
2590
08e3161a
JD
25912011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2592
2593 * nsterm.h (ns_run_ascript): Declare.
2594 (NSAPP_DATA2_RUNASSCRIPT): Define.
2595
2596 * nsfns.m (as_script, as_result, as_status): New static variables.
2597 (ns_run_ascript): New function.
5e617bc2 2598 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2599 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2600 the event loop. Get status from as_status (Bug#7276).
2601
2602 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2603 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2604 the event loop (Bug#7276).
2605
a3720aa2
AS
26062011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2607
2608 * gnutls.c (QCgnutls_bootprop_priority)
2609 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2610 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2611 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2612 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2613 (QCgnutls_bootprop_verify_hostname_error)
2614 (QCgnutls_bootprop_callbacks_verify): Rename from
2615 Qgnutls_bootprop_..., all uses changed.
2616
2617 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2618 uses changed.
2619
0a0d27fb
PE
26202011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2621
19d5c50c
PE
2622 * xfaces.c (Qframe_set_background_mode): Now static.
2623 * dispextern.h (Qframe_set_background_mode): Remove decl.
2624
0a0d27fb
PE
2625 * process.c (Fnetwork_interface_info): Declare local only if needed.
2626
377538cb
JD
26272011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2628
2629 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2630 (Fnetwork_interface_list): Allocate in increments of bytes instead
2631 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2632 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2633 sockaddr.
2634 (struct ifflag_def): notrailers is smart on OSX.
2635 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2636 Get hardware address with getifaddrs if available.
2637
08fff70c
EZ
26382011-08-12 Eli Zaretskii <eliz@gnu.org>
2639
2640 * xdisp.c (iterate_out_of_display_property): xassert that
2641 IT->position is set to within IT->object's boundaries. Break from
2642 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2643 when IT->position is set up wrongly due to some bug.
2644 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2645 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2646 entry. Force push_it to save on the stack the current
2647 buffer/string position, to be restored by pop_it. Fix flags in
2648 the iterator structure wrt the object coming from a display
2649 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2650 properties. (Bug#9284)
2651
7be1c708 26522011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2653
7be1c708
CY
2654 * fontset.c (fontset_get_font_group): Add proper type checks.
2655 (Bug#9172)
aac0c6e3 2656
7be1c708 26572011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2658
7be1c708
CY
2659 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2660 and LC_VERSION_MIN_MACOSX.
2661 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2662 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2663
97bb72a6
EZ
26642011-08-08 Eli Zaretskii <eliz@gnu.org>
2665
2666 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2667 no-display-properties-and-no-overlays under bidi display.
2668 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2669 properties and overlays.
97bb72a6 2670
d5617611
CY
26712011-08-08 Chong Yidong <cyd@stupidchicken.com>
2672
37e11a63
CY
2673 * editfns.c (Fset_time_zone_rule): Document relationship with the
2674 setenv function.
2675
d5617611
CY
2676 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2677 the font entity extracted from the cache (Bug#8109).
2678
58872834
CY
26792011-08-07 Chong Yidong <cyd@stupidchicken.com>
2680
2681 * composite.c (autocmp_chars): Don't reset point. That is done by
2682 restore_point_unwind (Bug#5984).
2683
75bfc667
JL
26842011-08-07 Juri Linkov <juri@jurta.org>
2685
2686 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2687 to show the arg `TIME' instead of `TIMEVAL'.
2688
d1410150
EZ
26892011-08-06 Eli Zaretskii <eliz@gnu.org>
2690
2691 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2692 display property strides EOL and includes a newline, as in
2693 longlines-mode. (Bug#9254)
75b771e4
EZ
2694 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2695 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2696
2697 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2698 is non-zero, even if the data buffer is NULL. Fixes a crash in
2699 vertical-motion with longlines-mode. (Bug#9254)
2700
35928349
EZ
27012011-08-05 Eli Zaretskii <eliz@gnu.org>
2702
ec7cc85b
EZ
2703 * bidi.c <bidi_cache_total_alloc>: Now static.
2704 (bidi_initialize): Initialize bidi_cache_total_alloc.
2705
8b76d6f8 2706 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2707 cache. (Bug#9221)
2708
2709 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2710 amount allocated this far in `bidi_cache_total_alloc'.
2711 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2712 non-zero, only free the data buffer without restoring the cache
2713 contents. All callers changed.
2714
2715 * dispextern.h (bidi_unshelve_cache): Update prototype.
2716
2717 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2718 (move_it_in_display_line, move_it_to)
2719 (move_it_vertically_backward, move_it_by_lines): Replace the call
2720 to xfree to an equivalent call to bidi_unshelve_cache.
2721 (move_it_in_display_line_to): Fix logic of returning
412b6358 2722 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2723
e2e2423b
EZ
27242011-08-05 Eli Zaretskii <eliz@gnu.org>
2725
2726 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2727 came from a string character with a `cursor' property. (Bug#9229)
2728
ae9e757a
JD
27292011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2730
2731 * Makefile.in (LIB_PTHREAD): New variable.
2732 (LIBES): Add LIB_PTHREAD (Bug#9216).
2733
2734 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2735 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2736
213bd7f2
AS
27372011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2738
6b02f655 2739 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2740
99aaf75f
JD
27412011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2742
2743 * xterm.c (x_find_topmost_parent): New function.
2744 (x_set_frame_alpha): Find topmost parent window with
2745 x_find_topmost_parent and set the property there also (bug#9181).
2746 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2747
c74e9d86
PE
27482011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2749
2750 * callproc.c (Fcall_process): Avoid vfork clobbering
2751 the local vars buffer, coding_systems, current_dir.
2752
640c8776
SM
27532011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2754
2755 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2756
f26d0e4c
PE
27572011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2758
8a10d76c
PE
2759 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2760 so that it is not optimized away.
2761
f26d0e4c
PE
2762 * xdisp.c (compute_display_string_pos): Remove unused local.
2763
55439c61
EZ
27642011-08-02 Eli Zaretskii <eliz@gnu.org>
2765
2766 Fix slow cursor motion and scrolling in large buffers with
2767 selective display, like Org Mode buffers. (Bug#9218)
2768
2769 * dispextern.h (struct bidi_it): New member disp_prop_p.
2770
2771 * xdisp.c: Remove one-slot cache of display string positions.
2772 (compute_display_string_pos): Accept an additional argument
5e617bc2 2773 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2774 for a display string or property. If found, set DISP_PROP_P
2775 non-zero.
2776
2777 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2778 DISP_PROP_P, and pass it to compute_display_string_pos.
2779 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2780 non-zero. All callers of bidi_fetch_char changed.
2781
fb33fa43
SM
27822011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2783
2784 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2785
b099e063
DM
27862010-12-03 Don March <don@ohspite.net>
2787
2788 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2789 last character M-[char] is translated to ESC [char] (bug#7541).
2790
5cc7f7af
KH
27912011-08-02 Kenichi Handa <handa@m17n.org>
2792
d0fffa3f 2793 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2794
2795 * chartab.c (uniprop_table): Make it non-static.
2796
525d5e6e
EZ
27972011-08-01 Eli Zaretskii <eliz@gnu.org>
2798
2799 * xdisp.c (forward_to_next_line_start): Accept additional argument
2800 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2801 on the newline.
2802 (reseat_at_next_visible_line_start): Use the bidi iterator state
2803 returned by forward_to_next_line_start to restore the state of
2804 it->bidi_it after backing up to previous newline. (Bug#9212)
2805
31011111
AS
28062011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2807
2808 * regex.c (re_comp): Protoize.
2809 (re_exec): Fix return type.
2810 (regexec): Fix type of `ret'. (Bug#9203)
2811
476371c4
PE
28122011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2813
e5d76069
PE
2814 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2815 This is needed if max-image-size is a floating-point number.
2816
9a79b20c
AS
28172011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2818
2819 * print.c (print_object): Print empty symbol as ##.
2820
2821 * lread.c (read1): Read ## as empty symbol.
2822
d8c2fa78
AA
28232011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2824
2825 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2826 setting frame foreground color (Bug#9175).
2827 (x_set_background_color): Likewise.
2828
ffe57a7a
AA
2829 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2830 contents (Bug#9176).
2831 (EmacsTooltip -init): Remove bezels and add shadows to
2832 tooltip windows.
2833
bf3492a5
AA
2834 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2835 or scroll bar (Bug#8470).
2836
d55e9c53
AA
2837 * nsfont.m (nsfont_open): Remove assignment to voffset and
2838 unnecessary vars hshink, expand, hd, full_height, min_height.
2839 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2840
2841 * nsterm.h (nsfont_info): Remove voffset field.
2842
d8c2fa78 28432011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2844
2845 Implement strike-through and overline on NextStep (Bug#8863).
2846
2847 * nsfont.m (nsfont_open): Use underline position provided by font,
2848 instead of hard-coded value of 2.
2849 (nsfont_draw): Call ns_draw_text_decoration instead.
2850
2851 * nsterm.h: Add declaration for ns_draw_text_decoration.
2852
2853 * nsterm.m (ns_draw_text_decoration): New function for drawing
2854 underline, overline, and strike-through.
2855 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2856 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2857 accommodate underlining, etc.
4843aac3 2858
4cc60b9b
EZ
28592011-07-28 Eli Zaretskii <eliz@gnu.org>
2860
bc7ece87
EZ
2861 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2862 default.
4cc60b9b 2863
476371c4
PE
28642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2865
66606eea
PE
2866 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2867 Without this fix, if a signal arrives just after memory fills up,
2868 'malloc' might be invoked reentrantly.
2869
476371c4
PE
2870 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2871 In other words, assume that every image size is allowed, on non-X
2872 hosts. This assumption is probably wrong, but it lets Emacs compile.
2873
f3fcc40d
AS
28742011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2875
2876 * regex.c (re_iswctype): Convert return values to boolean.
2877
350c992f
EZ
28782011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2879
2880 * xdisp.c (compute_display_string_pos): Don't use cached display
2881 string position if the buffer had its restriction changed.
2882 (Bug#9184)
2883
5266b4bb
PE
28842011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2885
2886 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2887
2573a837 28882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2889
41f55ccd 2890 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2891
39e378da
PE
2892 * bidi.c: Integer size and overflow fixes.
2893 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2894 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2895 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2896 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2897 (bidi_find_other_level_edge):
2898 Use ptrdiff_t instead of EMACS_INT where either will do.
2899 This works better on 32-bit hosts configured --with-wide-int.
2900 (bidi_cache_ensure_space): Check for size-calculation overflow.
2901 Use % rather than repeated addition, for better worst-case speed.
2902 Don't set bidi_cache_size until after xrealloc returns, because it
2903 might not return.
2904 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2905 (bidi_cache_ensure_space): Also check that the bidi cache size
2906 does not exceed that of the largest Lisp string or buffer. See Eli
2907 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2908
5e927815
PE
2909 * alloc.c (__malloc_size_t): Remove.
2910 All uses replaced by size_t. See Andreas Schwab's note
2911 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2912
ca4aa935
PE
2913 * image.c: Improve checking for integer overflow.
2914 (check_image_size): Assume that f is nonnull, since
2915 it is always nonnull in practice. This is one less thing to
2916 worry about when checking for integer overflow later.
2917 (x_check_image_size): New function, which checks for integer
2918 overflow issues inside X.
2919 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2920 This removes the need for a memory_full check.
2921 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2922 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2923 (xbm_read_bitmap_data): Change locals back to 'int', since
2924 their values must fit in 'int'.
2925 (xpm_load_image, png_load, tiff_load):
2926 Invoke x_create_x_image_and_pixmap earlier,
2927 to avoid much needless work if the image is too large.
2928 (tiff_load): Treat overly large images as if
2929 x_create_x_image_and_pixmap failed, not as malloc failures.
2930 (gs_load): Use x_check_image_size.
2931
5f8f9cc2
PE
2932 * gtkutil.c: Omit integer casts.
2933 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2934 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2935
5adf60bc
PE
2936 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2937
c8907a93
PE
2938 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2939 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2940 would wrongly return t on a 64-bit host.
2941
e3c25c68
PE
2942 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2943 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2944 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2945 and therefore cause GCC to emit a bogus diagnostic in some cases.
2946
3f791afe
PE
2947 * image.c: Integer signedness and overflow and related fixes.
2948 This is not an exhaustive set of fixes, but it's time to
2949 record what I've got.
2950 (lookup_pixel_color, check_image_size): Remove redundant decls.
2951 (check_image_size): Don't assume that arbitrary EMACS_INT values
2952 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2953 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2954 (tiff_load, imagemagick_load_image):
2955 Check for overflow in size calculations.
2956 (x_create_x_image_and_pixmap): Remove unnecessary test for
2957 xmalloc returning NULL; that can't happen.
2958 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2959 (xpm_color_bucket): Use better integer hashing function.
2960 (xpm_cache_color): Don't possibly over-allocate memory.
2961 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2962 (gif_memory_source):
2963 Use ptrdiff_t, not int or size_t, to record sizes.
2964 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2965 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2966 either works, as we prefer signed integers.
2967 (tiff_read_from_memory, tiff_write_from_memory):
2968 Return tsize_t, not size_t, since that's what the TIFF API wants.
2969 (tiff_read_from_memory): Don't fail simply because the read would
2970 go past EOF; instead, return a short read.
2971 (tiff_load): Omit no-longer-needed casts.
2972 (Fimagemagick_types): Don't assume size fits into 'int'.
2973
3cc5a532
PE
2974 Improve hashing quality when configured --with-wide-int.
2975 * fns.c (hash_string): New function, taken from sxhash_string.
2976 Do not discard information about ASCII character case; this
2977 discarding is no longer needed.
2978 (sxhash-string): Use it. Change sig to match it. Caller changed.
2979 * lisp.h: Declare it.
2980 * lread.c (hash_string): Remove, since we now use fns.c's version.
2981 The fns.c version returns a wider integer if --with-wide-int is
2982 specified, so this should help the quality of the hashing a bit.
2983
b312a492
PE
2984 * emacs.c: Integer overflow minor fix.
2985 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2986 Define only if GNU_LINUX.
2987 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2988
dfd153ae
PE
2989 * dispnew.c: Integer signedness and overflow fixes.
2990 Remove unnecessary forward decls, that were a maintenance hassle.
2991 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2992 All uses changed.
2993 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2994 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2995 (prepare_desired_row, line_draw_cost):
2996 Use int, not unsigned, where either works.
2997 (save_current_matrix, restore_current_matrix):
2998 Use ptrdiff_t, not size_t, where either works.
2999 (init_display): Check for overflow more accurately, and without
3000 relying on undefined behavior.
3001
a81d11a3
PE
3002 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3003 Remove, replacing with the new symbols in lisp.h. All uses changed.
3004 * fileio.c (make_temp_name):
3005 * filelock.c (lock_file_1, lock_file):
3006 * xdisp.c (message_dolog):
3007 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3008 Use pMd etc. instead.
3009 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3010 replacing the pWIDE etc. symbols removed from editfns.c.
3011
3300e6fd
PE
3012 * keyboard.h (num_input_events): Now uintmax_t.
3013 This is (very slightly) less likely to mess up due to wraparound.
3014 All uses changed.
3015
fd05c7e9
PE
3016 * buffer.c: Integer signedness fixes.
3017 (alloc_buffer_text, enlarge_buffer_text):
3018 Use ptrdiff_t rather than size_t when either will do, as we prefer
3019 signed integers.
3020
903fe15d
PE
3021 * alloc.c: Integer signedness and overflow fixes.
3022 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3023 (__malloc_size_t): Default to size_t, not to int.
3024 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3025 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3026 Prefer ptrdiff_t to size_t when either would do, as we prefer
3027 signed integers.
3028 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3029 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3030 Now const. Initialize with values that are in range even if char
3031 is signed.
3032 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3033 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3034 These functions do the right thing with sizes > 2**32.
3035 (check_depth): Now ptrdiff_t, not int.
3036 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3037 Adjust to new way of storing sizes. Check for size overflow bugs
3038 in rest of code.
3039 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3040 slightly wrong anyway, as it missed one instance of
3041 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3042 (refill_memory_reserve): Omit needless cast to size_t.
3043 (mark_object_loop_halt): Mark as externally visible.
3044
ac82cc6a
PE
3045 * xselect.c: Integer signedness and overflow fixes.
3046 (Fx_register_dnd_atom, x_handle_dnd_message):
3047 Use ptrdiff_t, not size_t, since we prefer signed.
3048 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3049 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3050 x_dnd_atoms_size and x_dnd_atoms_length.
3051
c2d1e36d
PE
3052 * doprnt.c: Prefer signed to unsigned when either works.
3053 * eval.c (verror):
3054 * doprnt.c (doprnt):
3055 * lisp.h (doprnt):
3056 * xdisp.c (vmessage):
3057 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3058 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3059 prefer signed arithmetic to avoid comparison confusion.
3060 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3061 but is a bit tricky.
3062
0e926e56
PE
3063 Assume freestanding C89 headers, string.h, stdlib.h.
3064 * data.c, doprnt.c, floatfns.c, print.c:
3065 Include float.h unconditionally.
3066 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3067 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3068 * regex.c: Likewise for stddef.h, string.h.
3069 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3070 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3071 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3072 (STDC_HEADERS): Remove obsolete defines.
3073 * sysdep.c: Include limits.h unconditionally.
3074
9cfdb3ec
PE
3075 Assume support for memcmp, memcpy, memmove, memset.
3076 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3077 * regex.c (memcmp, memcpy):
3078 Remove; we assume C89 now.
3079
3080 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3081 (__malloc_safe_bcopy): Remove; no longer needed.
3082
cf950e6b 3083 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3084 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3085 well either way, and we prefer signed to unsigned.
3086
dbf38e02
LMI
30872011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3088
3089 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3090 closes the connection while we're reading (bug#9182).
3091
d6f0886c 30922011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3093
d6f0886c
JD
3094 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3095 are specified (Bug#9168).
24e0f6b1 3096
2eb1f9e6
PE
30972011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3098
3099 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3100 Found by GCC static checking and --with-wide-int on a 32-bit host.
3101
22381272 31022011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3103
3104 * xdisp.c (compute_display_string_pos): Fix logic of caching
3105 previous display string position. Initialize cached_prev_pos to
3106 -1. Fixes slow-down at the beginning of a buffer.
3107
f25e39b4
EZ
31082011-07-24 Eli Zaretskii <eliz@gnu.org>
3109
3110 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3111 for attrs[LFACE_FONTSET_INDEX].
3112
04c4b52e
PE
31132011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3114
3115 * xml.c (parse_region): Remove unused local
3116 that was recently introduced.
3117
c1734fbd
EZ
31182011-07-23 Eli Zaretskii <eliz@gnu.org>
3119
be18c5a5
EZ
3120 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3121 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3122
c1734fbd
EZ
3123 * xdisp.c (move_it_in_display_line_to): Record the best matching
3124 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3125 exit if none of the characters scanned was an exact match.
3126 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3127 when exact match is impossible due to invisible text, and the
3128 lines are truncated.
3129
a258d627
JD
31302011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3131
3132 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3133 for OSX >= 10.7.
3134
b6d5a689
EZ
31352011-07-22 Eli Zaretskii <eliz@gnu.org>
3136
0f74f785
EZ
3137 Fix a significant slow-down of cursor motion with C-n, C-p,
3138 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3139 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3140 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3141 (next_element_from_buffer): Call compute_stop_pos_backwards to
3142 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3143 base_level_stop.
3144 (reseat): Don't look for prev_stop, as that could mean a very long
3145 run.
3146 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3147 <cached_disp_overlay_modiff>: Cache for last found display string
3148 position.
551918c1 3149 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3150 about the same buffer in the same area of character positions, and
3151 the buffer wasn't changed since the time the display string
3152 position was cached.
551918c1 3153
b2d0c91a
EZ
31542011-07-22 Eli Zaretskii <eliz@gnu.org>
3155
3156 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3157 is an integer, which is important for empty lines. (Bug#9149)
3158
043604ee
CY
31592011-07-22 Chong Yidong <cyd@stupidchicken.com>
3160
3161 * frame.c (Fmodify_frame_parameters): In tty case, update the
3162 default face if necessary (Bug#4238).
3163
da4adb04
CY
31642011-07-21 Chong Yidong <cyd@stupidchicken.com>
3165
3166 * editfns.c (Fstring_to_char): No need to explain what a character
3167 is in the docstring (Bug#6576).
3168
9abd0532
LMI
31692011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3170
3171 * xml.c (parse_region): Make sure we always return a tree.
3172
36881d16
HK
31732011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3174
3175 * xml.c (parse_region): If a document contains only comments,
3176 return that, too.
3177
1e98674d
LMI
31782011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3179
3180 * xml.c (make_dom): Return comments, too.
3181
590bd467
PE
31822011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3183
3184 Port to OpenBSD.
3185 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3186 and the surrounding thread.
3187 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3188 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3189 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3190 timer goes off.
3191 * s/openbsd.h (BROKEN_SIGIO): Define.
3192 * unexelf.c (unexec) [__OpenBSD__]:
3193 Don't update the .mdebug section of the Alpha COFF symbol table.
3194
f41628b2
LMI
31952011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3196
3197 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3198 (bug#8460).
3199
b59b67c5
PE
32002011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3201
15e3a074
PE
3202 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3203 This fixes some race conditions on the permissions of any newly
3204 created file.
3205
41bed37d
PE
3206 * alloc.c (valid_pointer_p): Use pipe, not open.
3207 This fixes some permissions issues when debugging.
3208
b59b67c5
PE
3209 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3210 If fchown fails to set both uid and gid, try to set just gid,
3211 as that is sometimes allowed. Adjust the file's mode to eliminate
3212 setuid or setgid bits that are inappropriate if fchown fails.
3213
925a6be7
SM
32142011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3215
3216 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3217 to compare Lisp_Objects.
3218 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3219 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3220 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3221
52968808
AS
32222011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3223
0a6a104b
AS
3224 * lread.c (read_integer): Unread even EOF character.
3225 (read1): Likewise. Properly record start position of symbol.
3226
52968808
AS
3227 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3228 symbol character follows.
3229
9e381cdd
PE
32302011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3231
3232 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3233 This works around a problem with the previous change to Fcopy_file.
3234 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3235 and without this change, GCC might complain about discarding
3236 fchown's return value.
3237
b5641435
JB
32382011-07-16 Juanma Barranquero <lekktu@gmail.com>
3239
3240 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3241
a8031457
PE
32422011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3243
3244 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3245
dd889327
LMI
32462011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3247
750c33f7
LMI
3248 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3249 it's used from the C level.
3250
dd889327
LMI
3251 * process.c: Use the same condition for POLL_FOR_INPUT in both
3252 keyboard.c and process.c (bug#1858).
3253
87e86684
LM
32542011-07-09 Lawrence Mitchell <wence@gmx.li>
3255
3256 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3257 (Fgnutls_boot): Use it.
3258
64348f40
AS
32592011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3260
3261 * doc.c (Fsubstitute_command_keys): Revert last change.
3262
1d698799
LMI
32632011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3264
f863868c
LMI
3265 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3266 quotes the next character, and doesn't affect other longer
3267 sequences (bug#8935).
3268
1d698799
LMI
3269 * lread.c (syms_of_lread): Clarify that is isn't only
3270 `eval-buffer' and `eval-defun' that's affected by
3271 `lexical-binding' (bug#8460).
3272
aa4b6df6
EZ
32732011-07-15 Eli Zaretskii <eliz@gnu.org>
3274
3275 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3276 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3277
5d856da6
PE
32782011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3279
ad6042bb
PE
3280 Fix minor problems found by static checking.
3281 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3282 (elsz): Now a signed constant, not a size_t var. We prefer signed
3283 types to unsigned, to avoid integer comparison confusion. Without
3284 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3285 "cannot optimize loop, the loop counter may overflow", a symptom
3286 of the confusion.
f00bbb22 3287 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3288 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3289
6468f31c
LMI
32902011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3291
49080b10
LMI
3292 * search.c (Fre_search_backward): Mention `case-fold-search' in
3293 all the re_search_* functions (bug#8138).
3294
6468f31c
LMI
3295 * keyboard.c (Fopen_dribble_file): Document when the file is
3296 closed (bug#8056).
3297
c965adc5
EZ
32982011-07-14 Eli Zaretskii <eliz@gnu.org>
3299
df9733bf
EZ
3300 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3301 bidi_cache_idx.
3302
0bb23927
EZ
3303 Support bidi reordering of display and overlay strings.
3304 * xdisp.c (compute_display_string_pos)
3305 (compute_display_string_end): Accept additional argument STRING.
3306 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3307 (reseat_to_string): Initialize bidi_it->string.s and
3308 bidi_it->string.schars.
3309 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3310 NULL (avoids a crash in bidi_paragraph_init).
3311 Initialize itb.string.lstring.
0bb23927
EZ
3312 (init_iterator): Call bidi_init_it only of a valid
3313 buffer position was specified. Initialize paragraph_embedding to
3314 L2R.
3315 (reseat_to_string): Initialize the bidi iterator.
3316 (display_string): If we need to ignore text properties of
3317 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3318 original value of -1 will not work with bidi.)
3319 (compute_display_string_pos): First arg is now struct
3320 `text_pos *'; all callers changed. Support display properties on
3321 Lisp strings.
3322 (compute_display_string_end): Support display properties on Lisp
3323 strings.
3324 (init_iterator, reseat_1, reseat_to_string): Initialize the
3325 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3326 when iterating on a string not from display properties).
640c8776
SM
3327 (compute_display_string_pos, compute_display_string_end):
3328 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3329 arrow keys.
3330 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3331 base_level_stop; instead, set base_level_stop to BEGV.
3332 Fixes crashes in vertical-motion.
0bb23927
EZ
3333 (next_element_from_buffer): Improve commentary for when
3334 the iterator is before prev_stop.
3335 (init_iterator): Initialize bidi_p from the default value of
3336 bidi-display-reordering, not from buffer-local value. Use the
3337 buffer-local value only if initializing for buffer iteration.
3338 (handle_invisible_prop): Support invisible properties on strings
3339 that are being bidi-reordered.
3340 (set_iterator_to_next): Support bidi reordering of C strings and
3341 Lisp strings.
3342 (next_element_from_string): Support bidi reordering of Lisp
3343 strings.
3344 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3345 (display_string): Support display of R2L glyph rows.
3346 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3347 (init_iterator): Don't initialize it->bidi_p for strings
3348 here.
3349 (reseat_to_string): Initialize it->bidi_p for strings here.
3350 (next_element_from_string, next_element_from_c_string)
3351 (next_element_from_buffer): Add xassert's for correspondence
3352 between IT's object being iterated and it->bidi_it.string
3353 structure.
3354 (face_before_or_after_it_pos): Support bidi iteration.
3355 (next_element_from_c_string): Handle the case of the first string
3356 character that is not the first one in the visual order.
3357 (get_visually_first_element): New function, refactored from common
3358 parts of next_element_from_buffer, next_element_from_string, and
3359 next_element_from_c_string.
3360 (tool_bar_lines_needed, redisplay_tool_bar)
3361 (display_menu_bar): Force left-to-right direction. Add a FIXME
3362 comment for making that be controlled by a user option.
3363 (push_it, pop_it): Save and restore the state of the
3364 bidi iterator. Save and restore the bidi_p flag.
3365 (pop_it): Iterate out of display property for string iteration as
3366 well.
3367 (iterate_out_of_display_property): Support iteration over strings.
3368 (handle_single_display_spec): Set up it->bidi_it for iteration
3369 over a display string, and call bidi_init_it.
3370 (handle_single_display_spec, next_overlay_string)
3371 (get_overlay_strings_1, push_display_prop): Set up the bidi
3372 iterator for displaying display or overlay strings.
3373 (forward_to_next_line_start): Don't use the shortcut if
3374 bidi-iterating.
3375 (back_to_previous_visible_line_start): If handle_display_prop
3376 pushed the iterator stack, restore the internal state of the bidi
3377 iterator by calling bidi_pop_it same number of times.
3378 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3379 and we are bidi-iterating, don't decrement the iterator position;
3380 instead, set the first_elt flag in the bidi iterator, to produce
3381 the same effect.
3382 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3383 (push_display_prop): xassert that we are iterating a buffer.
3384 (push_it, pop_it): Save and restore paragraph_embedding member.
3385 (handle_single_display_spec, next_overlay_string)
3386 (get_overlay_strings_1, reseat_1, reseat_to_string)
3387 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3388 correctly. Don't assume unibyte strings are not bidi-reordered.
3389 (compute_display_string_pos)
3390 (compute_display_string_end): Fix handling the case of C string.
3391 (push_it, pop_it): Save and restore from_disp_prop_p.
3392 (handle_single_display_spec, push_display_prop): Set the
3393 from_disp_prop_p flag.
3394 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3395 (pop_it): Call iterate_out_of_display_property only if we are
3396 popping after iteration over a string that came from a display
3397 property. Fix a typo in popping stretch info. Add an assertion
3398 for verifying that the iterator position is in sync with the bidi
3399 iterator.
3400 (handle_single_display_spec, get_overlay_strings_1)
3401 (push_display_prop): Fix initialization of paragraph direction for
3402 string when that of the parent object is not yet determined.
3403 (reseat_1): Call bidi_init_it to resync the bidi
3404 iterator with IT's position. (Bug#7616)
3405 (find_row_edges): If ROW->start.pos gives position
3406 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3407 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3408 Reset the from_disp_prop_p flag.
3409 (SAVE_IT, RESTORE_IT): New macros.
3410 (pos_visible_p, face_before_or_after_it_pos)
3411 (back_to_previous_visible_line_start)
3412 (move_it_in_display_line_to, move_it_in_display_line)
3413 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3414 (try_scrolling, redisplay_window, display_line): Use them when
3415 saving a temporary copy of the iterator and restoring it back.
3416 (back_to_previous_visible_line_start, reseat_1)
3417 (init_iterator): Empty the bidi cache "stack".
3418 (move_it_in_display_line_to): If iterator ended up at
3419 EOL, but we never saw any buffer positions smaller than
3420 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3421 motion in bidi-reordered lines.
3422 (move_it_in_display_line_to): Record prev_method and prev_pos
3423 immediately before the call to set_iterator_to_next. Fixes cursor
3424 motion in bidi-reordered lines with stretch glyphs and strings
3425 displayed in margins. (Bug#8133) (Bug#8867)
3426 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3427 TO_CHARPOS.
640c8776
SM
3428 (pos_visible_p): Support positions in bidi-reordered lines.
3429 Save and restore bidi cache.
0bb23927
EZ
3430
3431 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3432 (bidi_paragraph_info): Delete unused struct.
3433 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3434 (bidi_cache_start): New variable.
3435 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3436 to zero.
3437 (bidi_cache_fetch_state, bidi_cache_search)
3438 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3439 (bidi_cache_find, bidi_peek_at_next_level)
3440 (bidi_level_of_next_char, bidi_find_other_level_edge)
3441 (bidi_move_to_visually_next): Compare cache index with
3442 bidi_cache_start rather than with zero.
3443 (bidi_fetch_char): Accept new argument STRING; all callers
3444 changed. Support iteration over a string. Support strings with
3445 display properties. Support unibyte strings. Fix the type of
3446 `len' according to what STRING_CHAR_AND_LENGTH expects.
3447 (bidi_paragraph_init, bidi_resolve_explicit_1)
3448 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3449 (bidi_level_of_next_char, bidi_move_to_visually_next):
3450 Support iteration over a string.
0bb23927
EZ
3451 (bidi_set_sor_type, bidi_resolve_explicit_1)
3452 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3453 can now be zero (for strings); special values 0 and -1 were
3454 changed to -1 and -2, respectively.
3455 (bidi_char_at_pos): New function.
3456 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3457 Call it instead of FETCH_MULTIBYTE_CHAR.
3458 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3459 initialized to valid values.
3460 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3461 values.
3462 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3463 the test for valid cached positions. Fix the logic for looking up
3464 the sentinel state in the cache. GCPRO the Lisp string we are
3465 iterating.
3466 (bidi_push_it, bidi_pop_it): New functions.
3467 (bidi_initialize): Initialize the bidi cache start stack pointer.
3468 (bidi_cache_ensure_space): New function, refactored from part of
3469 bidi_cache_iterator_state. Don't assume the required size is just
3470 one BIDI_CACHE_CHUNK away.
3471 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3472 (bidi_count_bytes, bidi_char_at_pos): New functions.
3473 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3474 always valid if bidi_cache_idx is valid.
3475 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3476 is valid if it's going to be used.
3477 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3478 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3479 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3480 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3481 (bidi_find_other_level_edge, bidi_cache_start_stack):
3482 All variables related to cache indices are now EMACS_INT.
c965adc5 3483
0bb23927
EZ
3484 * dispextern.h (struct bidi_string_data): New structure.
3485 (struct bidi_it): New member `string'. Make flag members be 1-bit
3486 fields, and put them last in the struct.
640c8776
SM
3487 (compute_display_string_pos, compute_display_string_end):
3488 Update prototypes.
0bb23927
EZ
3489 (bidi_push_it, bidi_pop_it): Add prototypes.
3490 (struct iterator_stack_entry): New members bidi_p,
3491 paragraph_embedding, and from_disp_prop_p.
3492 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3493 (bidi_shelve_cache, bidi_unshelve_cache):
3494 Declare prototypes.
0bb23927
EZ
3495
3496 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3497 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3498 and vector-like objects.
3499
3500 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3501 cache around display iteration.
3502
3503 * window.c (Fwindow_end, window_scroll_pixel_based)
3504 (displayed_window_lines, Frecenter): Save and restore the bidi
3505 cache around display iteration.
3506
3bbd2265
LMI
35072011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3508
3509 * editfns.c (Fdelete_region): Clarify the use of the named
3510 parameters (bug#6788).
3511
adc47434
MR
35122011-07-14 Martin Rudalics <rudalics@gmx.at>
3513
3514 * indent.c (Fvertical_motion): Set and restore w->pointm when
3515 saving and restoring the window's buffer (Bug#9006).
3516
837c31f8
LMI
35172011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3518
3519 * editfns.c (Fstring_to_char): Clarify just what is returned
3520 (bug#6576). Text by Eli Zaretskii.
3521
ac389d0c
JB
35222011-07-13 Juanma Barranquero <lekktu@gmail.com>
3523
3524 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3525
0be0ce47
EZ
35262011-07-13 Eli Zaretskii <eliz@gnu.org>
3527
3528 * buffer.c (mmap_find): Fix a typo.
3529
cd18e7e3
JB
35302011-07-13 Johan Bockgård <bojohan@gnu.org>
3531
3532 Fix execution of x selection hooks.
3533 * xselect.c (Qx_lost_selection_functions)
3534 (Qx_sent_selection_functions): New vars.
3535 (syms_of_xselect): DEFSYM them.
3536 (x_handle_selection_request): Pass Qx_sent_selection_functions
3537 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3538 (x_handle_selection_clear,x_clear_frame_selections):
3539 Pass Qx_lost_selection_functions rather than
3540 Vx_lost_selection_functions to Frun_hook_with_args.
3541
47ea7f44
PE
35422011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3543
ac389d0c 3544 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3545 The old code sometimes used this field without initializing it.
3546
47ea7f44
PE
3547 * alloc.c (gc_sweep): Don't read past end of array.
3548 In theory, the old code could also have corrupted Emacs internals,
3549 though it'd be very unlikely.
3550
bc985c87
AS
35512011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3552
3553 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3554 argument. (Bug#4026)
bc985c87 3555
0cf34688
LMI
35562011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3557
b3dadd76
LMI
3558 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3559 key" (bug#4257).
3560
0cf34688
LMI
3561 * window.c (Fset_window_start): Doc fix (bug#4199).
3562 (Fset_window_hscroll): Ditto.
3563
270768cd
PE
35642011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3565
077e3dda 3566 Fix minor new problems caught by GCC 4.6.1.
270768cd 3567 * term.c (init_tty): Remove unused local.
490011a6 3568 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3569 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3570 not used otherwise.
270768cd 3571
b1f58454
CY
35722011-07-12 Chong Yidong <cyd@stupidchicken.com>
3573
3574 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3575
22b9578d
LMI
35762011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3577
6e70ab07
LMI
3578 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3579 are the mini-buffer and the echo area (bug#3320).
3580
22b9578d
LMI
3581 * term.c (init_tty): Remove support for supdup, c10 and perq
3582 terminals, which are no longer supported (bug#1482).
3583
8974cc9f
JB
35842011-07-10 Johan Bockgård <bojohan@gnu.org>
3585
3586 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3587
a560d974
JD
35882011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3589
3590 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3591 for non-popups (Bug#3642).
3592
1dae0f0a
AS
35932011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3594
268c2c36 3595 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3596 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3597 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3598 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3599 * data.c (fmod): Likewise.
3600 * dispnew.c (swap_glyphs_in_rows): Likewise.
3601 * emacs.c (memory_warning_signal): Likewise.
3602 * floatfns.c (float_error): Likewise.
3603 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3604 (otf_open, font_otf_capability, generate_otf_features)
3605 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3606 Likewise.
3607 * image.c (pbm_read_file): Likewise.
3608 * indent.c (string_display_width): Likewise.
3609 * intervals.c (check_for_interval, search_for_interval)
3610 (inc_interval_count, count_intervals, root_interval)
3611 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3612 * lread.c (defalias): Likewise.
268c2c36 3613 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3614 * regex.c (set_image_of_range_1, set_image_of_range)
3615 (regex_grow_registers): Likewise.
3616 * sysdep.c (strerror): Likewise.
3617 * termcap.c (valid_filename_p, tprint, main): Likewise.
3618 * tparam.c (main): Likewise.
3619 * unexhp9k800.c (run_time_remap, save_data_space)
3620 (update_file_ptrs, read_header, write_header, calculate_checksum)
3621 (copy_file, copy_rest, display_header): Likewise.
3622 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3623 Likewise.
3624 * xdisp.c (check_it): Likewise.
3625 * xfaces.c (register_color, unregister_color, unregister_colors):
3626 Likewise.
3627 * xfns.c (print_fontset_result): Likewise.
3628 * xrdb.c (member, fatal, main): Likewise.
3629
99033785
PE
36302011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3631
3632 Fix minor problems found by static checking (Bug#9031).
3633 * chartab.c (char_table_set_range, map_sub_char_table):
3634 Remove unused locals.
3635 (uniprop_table): Now static.
3636 * composite.c (_work_char): Remove unused static var.
3637
9cb2ac56
JB
36382011-07-09 Juanma Barranquero <lekktu@gmail.com>
3639
3640 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3641
f25661f0
JD
36422011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3643
3644 * gtkutil.c (qttip_cb): Remove code without function.
3645
8278c4fe
EZ
36462011-07-09 Eli Zaretskii <eliz@gnu.org>
3647
3648 * w32.c (pthread_sigmask): New stub.
3649
1692ae2d 36502011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3651
8a6ebd58 3652 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3653 sigprocmask is portable only for single-threaded applications, and
3654 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3655 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3656 (LIBES): Use it.
3657 * callproc.c (Fcall_process):
3658 * process.c (create_process):
3659 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3660 Use pthread_sigmask, not sigprocmask.
123403e4 3661
1b854618
JD
36622011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3663
3664 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3665 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3666 wrong (Bug#8591).
3667
3fe4b549
JD
36682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3669
0ce7e563
JD
3670 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3671 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3672 (xg_hide_tooltip): Fix comment.
3673
3fe4b549
JD
3674 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3675 in registerServicesMenuSendTypes.
3676 (validRequestorForSendType): Don't check ns_return_types.
3677
3678 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3679 ns_return_type.
3680
5df75e47
JR
36812011-07-08 Jason Rumney <jasonr@gnu.org>
3682
22610910
JR
3683 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3684 SH_SHOW for hidden windows (Bug#5482).
3685
5df75e47
JR
3686 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3687 frame struct members of non-existent frames (Bug#6284).
3688
699c10bd
JD
36892011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3690
4393663b
JD
3691 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3692 variable firstTime not needed on OSX >= 10.6.
3693 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3694 >= 10.5. Use setKnobProportion, setDoubleValue.
3695
3696 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3697 (MAC_OS_X_VERSION_10_5): Define if not defined.
3698 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3699 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3700 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3701
3702 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3703 cString and lossyCString on OSX >= 10.4
3704
58179cce 3705 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3706 sizeToFit on OSX >= 10.2.
3707
3708 * nsimage.m (allocInitFromFile): Don't use deprecated method
3709 bestRepresentationForDevice on OSX >= 10.6.
3710
3711 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3712 to avoid warning.
3713
3714 * emacs.c: Declare unexec_init_emacs_zone.
3715
a63e0781
JD
3716 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3717
699c10bd
JD
3718 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3719
3720 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3721 on svcsMenu (Bug#8842).
3722
3723 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3724 ns_return_types.
3725 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3726
3727 * nsterm.m (QUTF8_STRING): Declare.
3728 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3729 (validRequestorForSendType): Return type is (id).
3730 Change indexOfObjectIdenticalTo to indexOfObject.
3731 Check if we have local selection before returning self (Bug#8842).
3732 (writeSelectionToPasteboard): Put local selection into paste board
3733 if we have a local selection (Bug#8842).
3734 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3735
3736 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3737 (ns_get_local_selection): Declare.
3738
54e10184
LMI
37392011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3740
9888ff71
LMI
3741 * keymap.c (describe_map_tree): Don't insert a double newline at
3742 the end of the buffer (bug#1169) and return whether we inserted
3743 something.
3744
54e10184
LMI
3745 * callint.c (Fcall_interactively): Change "reading args" to
3746 "providing args" to try to clarify what it does (bug#1010).
3747
15fa4783
KH
37482011-07-07 Kenichi Handa <handa@m17n.org>
3749
3750 * composite.c (composition_compute_stop_pos): Ignore a static
3751 composition starting before CHARPOS (Bug#8915).
3752
3753 * xdisp.c (handle_composition_prop): Likewise.
3754
a8815b00
EZ
37552011-07-07 Eli Zaretskii <eliz@gnu.org>
3756
3757 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3758 (Bug#9015)
3759
ef7b981d 37602011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3761
3762 * character.h (unicode_category_t): New enum type.
3763
3764 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3765 (Qchar_code_property_table): New variable.
3766 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3767 (UNIPROP_COMPRESSED_FORM_P): New macros.
3768 (char_table_ascii): Uncompress the compressed values.
3769 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3770 Uncompress the compressed values.
ac389d0c 3771 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3772 (char_table_ref_and_range): Uncompress the compressed values.
3773 (sub_char_table_set): New arg is_uniprop. Callers changed.
3774 Uncompress the compressed values.
3775 (sub_char_table_set_range): Args changed. Callers changed.
3776 (char_table_set_range): Adjuted for the above change.
3777 (map_sub_char_table): Delete args default_val and parent. Add arg
3778 top. Give decoded values to a Lisp function.
640c8776 3779 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3780 values to a Lisp function. Gcpro more variables.
3781 (uniprop_table_uncompress)
3782 (uniprop_decode_value_run_length): New functions.
3783 (uniprop_decoder, uniprop_decoder_count): New variables.
3784 (uniprop_get_decoder, uniprop_encode_value_character)
3785 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3786 New functions.
3787 (uniprop_encoder, uniprop_encoder_count): New variables.
3788 (uniprop_get_encoder, uniprop_table)
3789 (Funicode_property_table_internal, Fget_unicode_property_internal)
3790 (Fput_unicode_property_internal): New functions.
3791 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3792 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3793 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3794 char-code-property-alist.
3795
640c8776 3796 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3797 Vunicode_category_table.
3798
640c8776 3799 * font.c (font_range): Adjust for the change of
c805dec0
KH
3800 Vunicode_category_table.
3801
76b397fb
DN
38022011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3803
3804 * m/iris4d.h: Remove file, move contents ...
3805 * s/irix6-5.h: ... here.
3806
22b4128e
PE
38072011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3808
3809 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3810 * alloc.c (mark_buffer):
3811 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3812 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3813 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3814 This isn't true in general, and it's particularly not true
3815 if Emacs is configured with --with-wide-int.
3816 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3817 New macros, used in the buffer.c change.
3818
869795d6
JD
38192011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3820
3821 * xsettings.c: Use both GConf and GSettings if both are available.
3822 (store_config_changed_event): Add comment.
3823 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3824 (store_tool_bar_style_changed): New functions.
5e617bc2 3825 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3826 (struct xsettings): Move font inside HAVE_XFT.
3827 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3828 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3829 Move inside HAVE_XFT.
640c8776 3830 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3831 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3832 also.
3833 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3834 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3835 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3836 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3837 (parse_settings): Move check for font inside HAVE_XFT.
3838 (read_settings, apply_xft_settings): Add comment.
3839 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3840 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3841 call store_font_name_changed.
3842 (xft_settings_event): Add comment.
3843 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3844 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3845 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3846 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3847 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3848 (xsettings_get_system_font, xsettings_get_system_normal_font):
3849 Add comment.
869795d6 3850
d8ed26bd
PE
38512011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3852
3853 Random fixes. E.g., (random) never returned negative values.
3854 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3855 subseconds part to the entropy, as that's a bit more random.
3856 Prefer signed to unsigned, since the signedness doesn't matter and
3857 in general we prefer signed. When given a limit, use a
3858 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3859 latter isn't right if USE_2_TAGS_FOR_INTS.
3860 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3861 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3862
cabf1cac
SM
38632011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3864
3865 * textprop.c (text_property_stickiness):
3866 Obey Vtext_property_default_nonsticky.
3867 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3868 * w32fns.c (syms_of_w32fns):
3869 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3870
6e9b2be9
PE
38712011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3872
3873 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3874 This is more efficient than Ffile_directory_p and avoids a minor race.
3875
90186c68
LMI
38762011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3877
7c301272
LMI
3878 * buffer.c (Foverlay_put): Say what the return value is
3879 (bug#7835).
3880
c4f2d8d4
LMI
3881 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3882 is a directory before asking whether to use the file name
3883 (bug#7564).
ad637907
LMI
3884 (barf_or_query_if_file_exists): Make the "File is a directory"
3885 error be more correct.
c4f2d8d4 3886
90186c68
LMI
3887 * fns.c (Frequire): Remove the mention of the .gz files, since
3888 that's installation-specific, but keep the mention of
3889 `get-load-suffixes'.
3890
da64016e
PE
38912011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3892
3893 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3894 Report string overflow if the output is too long.
3895
7d47b580
JB
38962011-07-04 Juanma Barranquero <lekktu@gmail.com>
3897
a555cb87
JB
3898 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3899 (syms_of_gnutls): Remove duplicate DEFSYM for
3900 Qgnutls_bootprop_verify_hostname_error, an error for
3901 Qgnutls_bootprop_verify_error (which is no longer used).
3902
7d47b580
JB
3903 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3904 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3905 Also (re)move comments that are misplaced or no longer relevant.
3906
1e49bfab
LMI
39072011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3908
3909 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3910
1485f4c0
CY
39112011-07-03 Chong Yidong <cyd@stupidchicken.com>
3912
3913 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3914 and background color parameters if they have been changed.
3915
a9ab721e
LMI
39162011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3917
3918 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3919
cf7cff57
PE
39202011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3921
2e13213d
PE
3922 * xsettings.c (SYSTEM_FONT): Define only when used.
3923 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3924
cf7cff57
PE
3925 * keymap.c (access_keymap_1): Now static.
3926
7a8e04f7
CY
39272011-07-02 Chong Yidong <cyd@stupidchicken.com>
3928
3929 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3930 leave any prefix arg for the up event (Bug#1586).
3931
61352f62
LMI
39322011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3933
69bb1ef7
LMI
3934 * lread.c (syms_of_lread): Mention single symbols defined by
3935 `defvar' or `defconst' (bug#7154).
3936
61352f62 3937 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3938 (Frequire): Mention get-load-suffixes.
61352f62 3939
28545e04
MR
39402011-07-02 Martin Rudalics <rudalics@gmx.at>
3941
3942 * window.h (window): Remove clone_number slot.
3943 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3944 Remove.
3945 (make_parent_window, make_window, saved_window)
3946 (Fset_window_configuration, save_window_save): Don't deal with
3947 clone numbers.
3948 * buffer.c (Qclone_number): Remove declaration.
3949 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3950
3349e122
SM
39512011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3952
3953 Add multiple inheritance to keymaps.
3954 * keymap.c (Fmake_composed_keymap): New function.
3955 (Fset_keymap_parent): Simplify.
3956 (fix_submap_inheritance): Remove.
3957 (access_keymap_1): New function extracted from access_keymap to handle
3958 embedded parents and handle lists of maps.
3959 (access_keymap): Use it.
3960 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3961 (Fcopy_keymap): Handle embedded parents.
3962 (Fcommand_remapping, define_as_prefix): Simplify.
3963 (Fkey_binding): Simplify.
3964 (syms_of_keymap): Move minibuffer-local-completion-map,
3965 minibuffer-local-filename-completion-map,
3966 minibuffer-local-must-match-map, and
3967 minibuffer-local-filename-must-match-map to Elisp.
3968 (syms_of_keymap): Defsubr make-composed-keymap.
3969 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3970 (parse_menu_item): Trivial simplification.
3971
3279eb87
GM
39722011-07-01 Glenn Morris <rgm@gnu.org>
3973
3974 * Makefile.in (SETTINGS_LIBS): Fix typo.
3975
4550efdf
KI
39762011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3977
3978 * coding.c (Fencode_coding_string): Record the last coding system
3979 used, as the function doc string says (bug#8738).
3980
0949d2b6
JD
39812011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3982
3983 * xsettings.c (store_monospaced_changed): Take new font as arg and
3984 check for change against current_mono_font.
3985 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3986 (emacs_settings_constructor, emacs_settings_get_property)
3987 (emacs_settings_set_property, emacs_settings_class_init)
3988 (emacs_settings_init, gsettings_obj): Remove.
3989 (something_changedCB): New function for HAVE_GSETTINGS.
3990 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3991 with value as argument.
3992 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3993 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3994 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3995 "changed".
3996
3997 * xgselect.c: Add defined (HAVE_GSETTINGS).
3998 (xgselect_initialize): Ditto.
3999
4000 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4001 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4002 xg_select.
4003
bbc6b304
PE
40042011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4005
4006 * eval.c (struct backtrace): Simplify and port the data structure.
4007 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4008 signed bit field, as this assumption is not portable and it makes
4009 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4010 "char debug_on_exit : 1" as this is not portable either; instead,
4011 use the portable "unsigned int debug_on_exit : 1". Remove unused
4012 member evalargs. Remove obsolete comments about cc bombing out.
4013
9851bfc5
JD
40142011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4015
51bb811f 4016 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4017 Let HAVE_GSETTINGS override HAVE_GCONF.
4018 (store_monospaced_changed): New function.
4019 (EMACS_SETTINGS): A new type derived from GObject to handle
4020 GSettings notifications.
4021 (emacs_settings_constructor, emacs_settings_get_property)
4022 (emacs_settings_set_property, emacs_settings_class_init):
4023 New functions.
4024 (gsettings_client, gsettings_obj): New variables.
4025 (GSETTINGS_SCHEMA): New define.
4026 (something_changedCB): Call store_monospaced_changed.
4027 (init_gsettings): New function.
4028 (xsettings_initialize): Call init_gsettings.
4029 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4030 to NULL.
4031
640c8776 4032 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4033 GCONF_CFLAGS/LIBS.
4034
5386012d
MR
40352011-06-29 Martin Rudalics <rudalics@gmx.at>
4036
4037 * window.c (resize_root_window, grow_mini_window)
4038 (shrink_mini_window): Rename Qresize_root_window to
4039 Qwindow_resize_root_window and Qresize_root_window_vertically to
4040 Qwindow_resize_root_window_vertically.
4041
f13e0b08
PE
40422011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4043
4044 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4045
94515237
JB
40462011-06-27 Juanma Barranquero <lekktu@gmail.com>
4047
4048 * makefile.w32-in: Redesign dependencies so they reflect more
4049 clearly which files are directly included by each source file,
4050 and not through other includes.
4051
e43b6e43
MR
40522011-06-27 Martin Rudalics <rudalics@gmx.at>
4053
4054 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4055 (sort_overlays, overlay_strings): When an overlay's clone number
4056 matches the window's clone number process the overlay even if
4057 the overlay's window property doesn't match the current window.
4058
d68443dc
MR
4059 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4060 (Fwindow_hchild): Rename to Fwindow_left_child.
4061 (Fwindow_next): Rename to Fwindow_next_sibling.
4062 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4063 (resize_window_check): Rename to window_resize_check.
4064 (resize_window_apply): Rename to window_resize_apply.
4065 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4066 (Fdelete_other_windows_internal, resize_frame_windows)
4067 (Fsplit_window_internal, Fdelete_window_internal)
4068 (grow_mini_window, shrink_mini_window)
4069 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4070
c7e73be5
JD
40712011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4072
4073 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4074 (emacs_fixed_set_min_size): Remove.
4075 (emacs_fixed_new): Take frame as argument.
4076
4077 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4078 (_EmacsFixedPrivate): Remove minwidth/height.
4079 Add struct frame *f.
4080 (emacs_fixed_init): Initialize priv->f.
4081 (get_parent_class, emacs_fixed_set_min_size): Remove.
4082 (emacs_fixed_new): Set priv->f to argument.
4083 (emacs_fixed_get_preferred_width)
4084 (emacs_fixed_get_preferred_height): Use min_width/height from
4085 frames size_hint to set minimum and natural (Bug#8919).
4086 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4087 and use min_width/height from frames size_hint to set
4088 min_width/height (Bug#8919).
4089
4090 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4091 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4092 Fix indentation.
c7e73be5 4093
cf99dcf8
EZ
40942011-06-26 Eli Zaretskii <eliz@gnu.org>
4095
4096 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4097 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4098 called at ZV.
4099
029529ac
CY
41002011-06-26 Chong Yidong <cyd@stupidchicken.com>
4101
4102 * process.c (wait_reading_process_output): Bypass select if
4103 waiting for a cell while ignoring keyboard input, and input is
4104 pending. Suggested by Jan Djärv (Bug#8869).
4105
7a7ef429
PE
41062011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4107
4108 Use gnulib's dup2 module instead of rolling our own.
4109 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4110
11fdef7d 41112011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4112
4113 * dispnew.c (scrolling_window): Before scrolling, turn off a
4114 mouse-highlight in the window being scrolled.
4115
cd3520a4
JB
41162011-06-24 Juanma Barranquero <lekktu@gmail.com>
4117
4118 Move DEFSYM to lisp.h and use everywhere.
4119
4120 * character.h (DEFSYM): Move declaration...
4121 * lisp.h (DEFSYM): ...here.
4122
4123 * gnutls.c:
4124 * minibuf.c:
4125 * w32menu.c:
4126 * w32proc.c:
4127 * w32select.c: Don't include character.h.
4128
4129 * alloc.c (syms_of_alloc):
4130 * buffer.c (syms_of_buffer):
4131 * bytecode.c (syms_of_bytecode):
4132 * callint.c (syms_of_callint):
4133 * casefiddle.c (syms_of_casefiddle):
4134 * casetab.c (init_casetab_once):
4135 * category.c (init_category_once, syms_of_category):
4136 * ccl.c (syms_of_ccl):
4137 * cmds.c (syms_of_cmds):
4138 * composite.c (syms_of_composite):
4139 * dbusbind.c (syms_of_dbusbind):
4140 * dired.c (syms_of_dired):
4141 * dispnew.c (syms_of_display):
4142 * doc.c (syms_of_doc):
4143 * editfns.c (syms_of_editfns):
4144 * emacs.c (syms_of_emacs):
4145 * eval.c (syms_of_eval):
4146 * fileio.c (syms_of_fileio):
4147 * fns.c (syms_of_fns):
4148 * frame.c (syms_of_frame):
4149 * fringe.c (syms_of_fringe):
4150 * insdel.c (syms_of_insdel):
4151 * keymap.c (syms_of_keymap):
4152 * lread.c (init_obarray, syms_of_lread):
4153 * macros.c (syms_of_macros):
4154 * msdos.c (syms_of_msdos):
4155 * print.c (syms_of_print):
4156 * process.c (syms_of_process):
4157 * search.c (syms_of_search):
4158 * sound.c (syms_of_sound):
4159 * syntax.c (init_syntax_once, syms_of_syntax):
4160 * terminal.c (syms_of_terminal):
4161 * textprop.c (syms_of_textprop):
4162 * undo.c (syms_of_undo):
4163 * w32.c (globals_of_w32):
4164 * window.c (syms_of_window):
4165 * xdisp.c (syms_of_xdisp):
4166 * xfaces.c (syms_of_xfaces):
4167 * xfns.c (syms_of_xfns):
4168 * xmenu.c (syms_of_xmenu):
4169 * xsettings.c (syms_of_xsettings):
4170 * xterm.c (syms_of_xterm): Use DEFSYM.
4171
4228cf16
TZ
41722011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4173
cd3520a4 4174 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4175
7fcccf1e
PE
41762011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4177
7efb4e0e
PE
4178 Integer and buffer overflow fixes (Bug#8873).
4179
ff5844ad
PE
4180 * print.c (printchar, strout): Check for string overflow.
4181 (PRINTPREPARE, printchar, strout):
4182 Don't set size unless allocation succeeds.
4183
90532f02
PE
4184 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4185 for sizes. Check for string overflow more accurately.
4186 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4187
6d84508d
PE
4188 * macros.c: Integer and buffer overflow fixes.
4189 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4190 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4191 Use ptrdiff_t, not int, for sizes.
4192 Don't increment bufsize until after realloc succeeds.
4193 Check for size-calculation overflow.
4194 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4195
437b2cb4
PE
4196 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4197
8b9ac8b4
PE
4198 * lread.c: Integer overflow fixes.
4199 (read_integer): Radix is now EMACS_INT, not int,
4200 to improve quality of diagnostics for out-of-range radices.
4201 Calculate buffer size correctly for out-of-range radices.
4202 (read1): Check for integer overflow in radices, and in
4203 read-circle numbers.
82cb60d3
PE
4204 (read_escape): Avoid int overflow.
4205 (Fload, openp, read_buffer_size, read1)
4206 (substitute_object_recurse, read_vector, read_list, map_obarray):
4207 Use ptrdiff_t, not int, for sizes.
4208 (read1): Use EMACS_INT, not int, for sizes.
20270765 4209 Check for size overflow.
8b9ac8b4 4210
7fcccf1e
PE
4211 * image.c (cache_image): Check for size arithmetic overflow.
4212
bfbbd7e7
PE
4213 * lread.c: Integer overflow issues.
4214 (saved_doc_string_size, saved_doc_string_length)
4215 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4216 Now ptrdiff_t, not int.
4217 (read1): Don't assume doc string length fits in int. Check for
4218 out-of-range doc string lengths.
4219 (read_list): Don't assume file position fits in int.
39019e54 4220 (read_escape): Check for hex character overflow.
bfbbd7e7 4221
4e323265
LL
42222011-06-22 Leo Liu <sdl.web@gmail.com>
4223
4224 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4225 Move to minibuffer.el.
4226
85fece3e
PE
42272011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4228
20b84ce9 4229 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4230 The following patches are for when GLYPH_DEBUG && !XASSERT.
4231 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4232 * dispnew.c (flush_stdout):
4233 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4234 Mark as externally visible.
4235 * dispnew.c (check_window_matrix_pointers): Now static.
4236 * dispnew.c (window_to_frame_vpos):
4237 * xfns.c (unwind_create_frame):
4238 * xterm.c (x_check_font): Remove unused local.
4239 * scroll.c (CHECK_BOUNDS):
4240 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4241 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4242 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4243 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4244 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4245 Now static.
4246 (debug_method_add): Use va_list and vsprintf rather than relying
4247 on undefined behavior with wrong number of arguments.
4248 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4249 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4250 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4251 since we're not interested in debugging glyphs with old libraries.
4252 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4253 GCC 4.6.0's static checking.
4254
0766b489
PE
42552011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4256
31fd4b32
PE
4257 Integer overflow and signedness fixes (Bug#8873).
4258 A few related buffer overrun fixes, too.
4259
b79e8648
PE
4260 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4261
0766b489
PE
4262 * dispextern.h (struct face.stipple):
4263 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4264 (x_bitmap_mask, x_allocate_bitmap_record)
4265 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4266 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4267 (x_create_bitmap_from_xpm_data):
4268 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4269 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4270 (.bitmaps_last):
4271 * xfaces.c (load_pixmap):
4272 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4273 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4274 (.bitmaps_last, struct x_output.icon_bitmap):
4275 Use ptrdiff_t, not int, for bitmap indexes.
4276 (x_allocate_bitmap_record): Check for size overflow.
4277 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4278
b081724f
PE
4279 Use ptrdiff_t, not int, for overlay counts.
4280 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4281 * editfns.c (overlays_around, get_pos_property):
4282 * textprop.c (get_char_property_and_overlay):
4283 * xdisp.c (next_overlay_change, note_mouse_highlight):
4284 * xfaces.c (face_at_buffer_position):
21514da7
PE
4285 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4286 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4287 (Fnext_overlay_change, Fprevious_overlay_change)
4288 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4289 Use ptrdiff_t, not int, for sizes.
21514da7 4290 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4291
3de73e5e
PE
4292 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4293
2606c57b
PE
4294 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4295 (x_session_initialize): Do not assume string length fits in int.
4296
aaafe47a
PE
4297 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4298 This is unlikely, but can occur if DPI is outlandish.
4299
2674ddc8 4300 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4301 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4302
28154962
PE
4303 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4304 * xrdb.c (magic_file_p, search_magic_path):
4305 Omit last arg SUFFIX; it was always 0. All callers changed.
4306 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4307
7de51af5
PE
4308 * xfont.c (xfont_match): Avoid need for strlen.
4309
25ed6cc3
PE
4310 * xfns.c: Don't assume strlen fits in int.
4311 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4312
4eab31dd
PE
4313 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4314 not unsigned long, as we prefer signed integers. All callers changed.
4315 Detect integer overflow in repeat count.
4316 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4317 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4318
171e2a58
PE
4319 * termcap.c: Don't assume sizes fit in int and never overflow.
4320 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4321 (gobble_line): Check for size-calculation overflow.
4322
ad39faca 4323 * minibuf.c (Fread_buffer):
6e5bb2dc 4324 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4325 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4326 Don't assume string length fits in int.
4327
52c61c22 4328 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4329 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4330
b5b8c9e5
PE
4331 * font.c: Don't assume string length fits in int.
4332 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4333 Use ptrdiff_t, not int.
ccd6111c
PE
4334 (font_intern_prop): Don't assume string length fits in int.
4335 Don't assume integer property fits in fixnum.
4336 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4337
882f0d81 4338 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4339 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4340 Reformulate so as not to need the command string.
4341 Invoke gzip -cd rather than gunzip, as it's more portable.
4342 (lock_info_type, lock_file_1, lock_file):
4343 Don't assume pid_t and time_t fit in unsigned long.
4344 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4345 (current_lock_owner): Prefer signed type for sizes.
4346 Use memcpy, not strncpy, where memcpy is what is really wanted.
4347 Don't assume (via atoi) that time_t and pid_t fit in int.
4348 Check for time_t and/or pid_t out of range, e.g., via a network share.
4349 Don't alloca where an auto var works fine.
4350
93f4cf88
PE
4351 * fileio.c: Fix some integer overflow issues.
4352 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4353 Don't assume string length fits in int.
4354 (directory_file_name): Don't assume string length fits in long.
4355 (make_temp_name): Don't assume pid fits in int, or that its print
4356 length is less than 20.
4357
f3e92b69
PE
4358 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4359
1bfdaf10
PE
4360 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4361
35016e9a
PE
4362 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4363
3d1e65a1
PE
4364 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4365 We prefer signed integers, even for size calculations.
4366
0b963a93
PE
4367 * emacs.c: Don't assume string length fits in 'int'.
4368 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4369 (main): Don't invoke strlen when not needed.
4370
573f4b54
PE
4371 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4372 (XD_DEBUG_MESSAGE): Don't waste a byte.
4373
989f33ba
PE
4374 * callproc.c (getenv_internal_1, getenv_internal)
4375 (Fgetenv_internal):
965d34eb
PE
4376 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4377
e4d29b33
PE
4378 * lread.c (invalid_syntax): Omit length argument.
4379 All uses changed. This doesn't fix a bug, but it simplifies the
4380 code away from its former Hollerith-constant appearance, and it's
4381 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4382 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4383
eb49b136
PE
4384 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4385 This didn't break anything, but it didn't help either.
4386 It's confusing to put a bogus integer in a place where the actual
4387 value does not matter.
9f62aeb1 4388 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4389 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4390
15375a22
PE
4391 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4392 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4393 implementation.
b61cc01c
PE
4394 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4395 We prefer signed types, and the value cannot exceed the EMACS_INT
4396 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4397 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4398 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4399 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4400
53b2623d
PE
4401 * indent.c (sane_tab_width): New function.
4402 (current_column, scan_for_column, Findent_to, position_indentation)
4403 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4404 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4405
51cab52b 4406 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4407
f2ed8a70
PE
4408 * lisp.h (lint_assume): New macro.
4409 * composite.c (composition_gstring_put_cache):
4410 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4411
abe80cc6
PE
4412 * editfns.c, insdel.c:
4413 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4414
b02c740e
PE
4415 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4416
ebc96716
PE
4417 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4418
b4e50fa0 4419 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4420 Use much-faster test for byte-length change.
311d5d7c 4421 Don't assume string byte-length fits in 'int'.
a4cf38e4 4422 Check that character arg fits in 'int'.
85461888 4423 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4424
c0c1ee9f
PE
4425 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4426
a498d7f4
PE
4427 * fns.c (concat): Catch string overflow earlier.
4428 Do not rely on integer wraparound.
4429
51cab52b
PE
4430 * dispextern.h (struct it.overlay_strings_charpos)
4431 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4432 * xdisp.c (forward_to_next_line_start)
4433 (back_to_previous_visible_line_start)
4434 (reseat_at_next_visible_line_start, next_element_from_buffer):
4435 Don't arbitrarily truncate the value of 'selective' to int.
4436
76031fad
PE
4437 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4438
5eb55db9
PE
4439 * composite.c: Don't truncate sizes to 'int'.
4440 (composition_gstring_p, composition_reseat_it)
4441 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4442 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4443 not EMACS_UINT, for indexes.
5eb55db9 4444
0703a717
PE
4445 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4446
d6202519
PE
4447 * buffer.c: Include <verify.h>.
4448 (struct sortvec.priority, struct sortstr.priority):
8961a454 4449 Now EMACS_INT, not int.
c20998a7 4450 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4451 (struct sortstr.size, record_overlay_string)
4452 (struct sortstrlist.size, struct sortlist.used):
4453 Don't truncate size to int.
4454 (record_overlay_string): Check for size-calculation overflow.
d6202519 4455 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4456
d5a19415
JM
44572011-06-22 Jim Meyering <meyering@redhat.com>
4458
029529ac 4459 Don't leak an XBM-image-sized buffer
d5a19415
JM
4460 * image.c (xbm_load): Free the image buffer after using it.
4461
a9041e6c
PE
44622011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4463
4464 Port to Sun C.
4465 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4466 that Sun C diagnosed.
4467 * fns.c (secure_hash): Fix pointer signedness issue.
4468 * intervals.c (static_offset_intervals): New function.
4469 (offset_intervals): Use it.
4470
7f3f739f
LL
44712011-06-21 Leo Liu <sdl.web@gmail.com>
4472
4473 * deps.mk (fns.o):
4474 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4475 sha512.h.
4476
4477 * fns.c (secure_hash): Rename from crypto_hash_function and change
4478 the first arg to accept symbols.
5b66d427 4479 (Fsecure_hash): New primitive.
7f3f739f
LL
4480 (syms_of_fns): New symbols.
4481
76147d94
DD
44822011-06-20 Deniz Dogan <deniz@dogan.se>
4483
4484 * process.c (Fset_process_buffer): Clarify return value in
4485 docstring.
4486
7d7d0045
CY
44872011-06-18 Chong Yidong <cyd@stupidchicken.com>
4488
4489 * dispnew.c (add_window_display_history): Use BVAR.
4490
4491 * xdisp.c (debug_method_add): Use BVAR.
4492 (check_window_end, dump_glyph_matrix, dump_glyph)
4493 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4494
4495 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4496 Likewise.
4497
4498 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4499 check till after the cache is created in init_frame_faces.
4500
ff2bc410
SM
45012011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4502
4503 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4504
28177add
PE
45052011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4506
dd3482fe
PE
4507 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4508 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4509 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4510
393d71f3 4511 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4512 * fileio.c (Finsert_file_contents):
4513 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4514 Remove the old (too-loose) buffer overflow checks.
4515 They weren't needed, since make_gap checks for buffer overflow.
4516 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4517 The old code merely checked for Emacs fixnum overflow, and relied
4518 on undefined (wraparound) behavior. The new code avoids undefined
4519 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4520
2e6813b0 4521 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4522 Tune. Don't use wider integers than needed. Don't use alloca.
4523 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4524
599a9e4f
PE
4525 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4526
99561444
PE
4527 * insdel.c, lisp.h (buffer_overflow): New function.
4528 (insert_from_buffer_1, replace_range, replace_range_2):
4529 * insdel.c (make_gap_larger):
4530 * editfns.c (Finsert_char):
4531 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4532
28177add
PE
4533 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4534
e69dafad
PE
45352011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4536
4baa020d 4537 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4538
b1c46f02
PE
4539 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4540 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4541
e69dafad
PE
4542 * fileio.c: Don't assume EMACS_INT fits in off_t.
4543 (emacs_lseek): New static function.
4544 (Finsert_file_contents, Fwrite_region): Use it.
4545 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4546
566684ea
PE
4547 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4548
e6966cd6
PE
4549 * fns.c: Don't overflow int when computing a list length.
4550 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4551 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4552 truncation on 64-bit hosts. Check for QUIT every
4553 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4554 faster and is responsive enough.
4555 (Flength): Report an error instead of overflowing an integer.
4556 (Fsafe_length): Return a float if the value is not representable
4557 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4558 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4559 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4560
dd0b0efb
PE
4561 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4562 (header_size, word_size): New constants.
4563 (allocate_vectorlike): Don't check size overflow here.
4564 (allocate_vector): Check it here instead, since this is the only
4565 caller of allocate_vectorlike that could cause overflow.
4566 Check that the new vector's length is representable as a fixnum.
4567
86fe5cfe
PE
4568 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4569 The previous code was bogus. For example, next_almost_prime (32)
4570 returned 39, which is undesirable as it is a multiple of 3; and
4571 next_almost_prime (24) returned 25, which is a multiple of 5 so
4572 why was the code bothering to check for multiples of 7?
4573
80e88859
PE
4574 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4575
4a2f0ad6
PE
4576 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4577
f66c7cf8
PE
4578 Variadic C functions now count arguments with ptrdiff_t.
4579 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4580 Back then I didn't know that the Emacs coding style prefers signed int.
4581 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4582 were being counted with int, which may truncate counts on 64-bit
4583 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4584 * lisp.h (struct Lisp_Subr.function.aMANY)
4585 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4586 Arg counts are now ptrdiff_t, not size_t.
4587 All variadic functions and their callers changed accordingly.
4588 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4589 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4590 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4591 * callint.c (Fcall_interactively): Check arg count for overflow,
4592 to avoid potential buffer overrun. Use signed char, not 'int',
4593 for 'varies' array, so that we needn't bother to check its size
4594 calculation for overflow.
4595 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4596 * eval.c (apply_lambda):
4597 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4598 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4599 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4600
a1759b76
PE
4601 * callint.c (Fcall_interactively): Don't use index var as event count.
4602
d96be9fc
PE
4603 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4604 * mem-limits.h (SIZE): Remove; no longer used.
4605
a690a978 4606 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4607
578c21e6
PE
4608 Remove unnecessary casts.
4609 * xterm.c (x_term_init):
4610 * xfns.c (x_set_border_pixel):
4611 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4612 These aren't needed now that we assume ANSI C.
4613
96f53c6c
PE
4614 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4615 It's more likely to cause problems (due to unsigned overflow)
4616 than to cure them.
4617
83c77d31
PE
4618 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4619
ee2079f1
PE
4620 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4621
6da65536
PE
4622 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4623
7147c4a4
PE
4624 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4625
193e32d9
PE
4626 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4627
e5533da6
PE
4628 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4629
9910e595
PE
4630 GLYPH_CODE_FACE returns EMACS_INT, not int.
4631 * dispextern.h (merge_faces):
4632 * xfaces.c (merge_faces):
01103c44
PE
4633 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4634 Don't assume EMACS_INT fits in int.
9910e595 4635
2638320e
PE
4636 * character.h (CHAR_VALID_P): Remove unused parameter.
4637 * fontset.c, lisp.h, xdisp.c: All uses changed.
4638
045eb8d9
PE
4639 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4640
c1f134b5
PE
4641 * fns.c (concat): Minor tuning based on overflow analysis.
4642 This doesn't fix any bugs. Use int to hold character, instead
4643 of constantly refetching from Emacs object. Use XFASTINT, not
4644 XINT, for value known to be a character. Don't bother comparing
4645 a single byte to 0400, as it's always less.
4646
395fcb93 4647 * floatfns.c (Fexpt):
327eeec8
PE
4648 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4649
abbd3d23
PE
4650 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4651 for characters.
4652
684a03ef
PE
4653 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4654
0fed43f3
PE
4655 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4656 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4657 incorrectly succeed when S was a string, because 4294967386 was
4658 truncated before it was used.
4659
8fd02eb7
PE
4660 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4661 Otherwise, an out-of-range integer could cause undefined behavior
4662 on a 64-bit host.
4663
f8c86b69
PE
4664 * composite.c: Use int, not EMACS_INT, for characters.
4665 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4666 EMACS_INT, for values that are known to be in character range.
4667 This doesn't fix any bugs but is the usual style inside Emacs and
4668 may generate better code on 32-bit machines.
4669
34206dd2
PE
4670 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4671 This is for reasons similar to the recent CHAR_STRING fix.
4672 * charset.c (Fencode_char): Check that character arg is actually
4673 a character. Pass an int to ENCODE_CHAR.
4674 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4675 wider than 'int', as a compile-time check to prevent future regressions
4676 in this area.
4677
c5958d4c 4678 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4679
4680 Make sure a 64-bit char is never passed to CHAR_STRING.
4681 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4682 by silently ignoring the top 32 bits, allowing some values
4683 that were far too large to be valid characters.
4684 * character.h: Include <verify.h>.
4685 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4686 arguments are no wider than unsigned, as a compile-time check
4687 to prevent future regressions in this area.
4688 * data.c (Faset):
01103c44 4689 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4690 (Fsubst_char_in_region):
4691 * fns.c (concat):
4692 * xdisp.c (decode_mode_spec_coding):
4693 Adjust to CHAR_STRING's new requirement.
4694 * editfns.c (Finsert_char, Fsubst_char_in_region):
4695 * fns.c (concat): Check that character args are actually
4696 characters. Without this test, these functions did the wrong
4697 thing with wildly out-of-range values on 64-bit hosts.
4698
d37ca623
PE
4699 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4700 These casts should not be needed on 32-bit hosts, either.
4701 * keyboard.c (read_char):
4702 * lread.c (Fload): Remove casts to unsigned.
4703
ea204efb
PE
4704 * lisp.h (UNSIGNED_CMP): New macro.
4705 This fixes comparison bugs on 64-bit hosts.
4706 (ASCII_CHAR_P): Use it.
4707 * casefiddle.c (casify_object):
01103c44 4708 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4709 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4710 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4711 * dispextern.h (FACE_FROM_ID):
4712 * keyboard.c (read_char): Use UNSIGNED_CMP.
4713
41cb286c
PE
4714 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4715 not to EMACS_INT, to avoid GCC warning.
4716
4a1b9832
PE
4717 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4718
55daad71
PE
4719 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4720 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4721 isn't needed on 32-bit machines.
8f95c75c 4722
01103c44
PE
4723 * buffer.c (Fgenerate_new_buffer_name):
4724 Use EMACS_INT for count, not int.
0ceccced 4725 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4726
4727 * data.c (Qcompiled_function): Now static.
4728
c6f072e7
PE
4729 * window.c (window_body_lines): Now static.
4730
20ce5912
PE
4731 * image.c (gif_load): Rename local to avoid shadowing.
4732
9c4c5f81
PE
4733 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4734 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4735 * alloc.c (make_save_value): Integer argument is now of type
4736 ptrdiff_t, not int.
4737 (mark_object): Use ptrdiff_t, not int.
4738 * lisp.h (pD): New macro.
4739 * print.c (print_object): Use it.
4740
c0c5c8ae
PE
4741 * alloc.c: Use EMACS_INT, not int, to count objects.
4742 (total_conses, total_markers, total_symbols, total_vector_size)
4743 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4744 (total_free_floats, total_floats, total_free_intervals)
4745 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4746 Now EMACS_INT, not int. All uses changed.
4747 (Fgarbage_collect): Compute overall total using a double, so that
4748 integer overflow is less likely to be a problem. Check for overflow
4749 when converting back to an integer.
5a25e253
PE
4750 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4751 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4752 These were 'int' variables that could overflow on 64-bit hosts;
4753 they were never used, so remove them instead of repairing them.
211a0b2a 4754 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4755 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4756 Previously, this ceilinged at INT_MAX, but that doesn't work on
4757 64-bit machines.
e46bb31a 4758 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4759
c78baabf 4760 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4761 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4762 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4763 when a (possibly-narrower) signed value would do just as well.
4764 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4765
c9d624c6
PE
4766 * alloc.c: Catch some string size overflows that we were missing.
4767 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4768 for convenience in STRING_BYTES_MAX.
4769 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4770 The definition here is exact; the one in lisp.h was approximate.
4771 (allocate_string_data): Check for string overflow. This catches
4772 some instances we weren't catching before. Also, it catches
4773 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4774 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4775 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4776
c9d624c6
PE
4777 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4778 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4779 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4780
353032ce
PE
4781 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4782
2bccce07
PE
4783 * alloc.c (Fmake_string): Check for out-of-range init.
4784
0ac30604
SM
47852011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4786
4787 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4788
c195f2de
JD
47892011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4790
4791 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4792 xg_get_default_scrollbar_width.
4793
4794 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4795 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4796 (style_changed_cb): Call update_theme_scrollbar_width and call
4797 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4798 all frames (Bug#8505).
4799 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4800 Call gtk_window_set_resizable if HAVE_GTK3.
4801 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4802 and height if HAVE_GTK3 (Bug#8505).
4803 (scroll_bar_width_for_theme): New variable.
4804 (update_theme_scrollbar_width): New function.
4805 (xg_get_default_scrollbar_width): Move code to
4806 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4807 (xg_initialize): Call update_theme_scrollbar_width.
4808
4809 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4810
4811 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4812
e10ac9f1
MR
48132011-06-12 Martin Rudalics <rudalics@gmx.at>
4814
4815 * frame.c (make_frame): Call other_buffer_safely instead of
4816 other_buffer.
4817
4818 * window.c (temp_output_buffer_show): Call display_buffer with
4819 second argument Vtemp_buffer_show_specifiers and reset latter
4820 immediately after the call.
4821 (Vtemp_buffer_show_specifiers): New variable.
4822 (auto_window_vscroll_p, next_screen_context_lines)
4823 (Vscroll_preserve_screen_position): Remove leading asterisks from
4824 doc-strings.
4825
2d3c217e 48262011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4827
7b7f97e8 4828 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4829 * buffer.c (Qclone_number): Remove for now, as it's unused.
4830 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4831 (record_buffer): Remove unused local.
4832 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4833 (set_frame_buffer_list): Remove; unused.
4834 * frame.h (other_visible_frames): Remove decl.
4835 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4836 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4837 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4838 if HAVE_GPM.
4839 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4840 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4841 Define only if HAVE_GPM.
4842 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4843 (update_hints_inhibit): Remove; never set. All uses removed.
4844 * widgetprv.h (emacsFrameClassRec): Remove decl.
4845 * window.c (delete_deletable_window): Now returns void, since it
4846 wasn't returning anything.
4847 (compare_window_configurations): Remove unused locals.
4848 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4849 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4850 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4851 the same widths as pointers. This follows up on the 2011-05-06 patch.
4852 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4853 * xterm.h: Likewise.
4854 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4855
1384b89e
JB
48562011-06-12 Juanma Barranquero <lekktu@gmail.com>
4857
4858 * makefile.w32-in: Update dependencies.
4859 (LISP_H): Add lib/intprops.h.
4860
1100a63c
CY
48612011-06-11 Chong Yidong <cyd@stupidchicken.com>
4862
4863 * image.c (gif_load): Add animation frame delay to the metadata.
4864 (syms_of_image): Use DEFSYM. New symbol `delay'.
4865
6198ccd0
MR
48662011-06-11 Martin Rudalics <rudalics@gmx.at>
4867
4868 * window.c (delete_deletable_window): Re-add.
4869 (Fset_window_configuration): Rewrite to handle dead buffers and
4870 consequently deletable windows.
4871 (window_tree, Fwindow_tree): Remove. Supply functionality in
4872 window.el.
4873 (compare_window_configurations): Simplify code.
4874
b6e3633c
AS
48752011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4876
1ab0dee5
AS
4877 * image.c (imagemagick_load_image): Fix type mismatch.
4878 (Fimagemagick_types): Likewise.
4879
b6e3633c
AS
4880 * window.h (replace_buffer_in_windows): Declare.
4881
9397e56f
MR
48822011-06-11 Martin Rudalics <rudalics@gmx.at>
4883
4884 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4885 Qclone_number. Remove external declaration of Qdelete_window.
4886 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4887 code.
640c8776
SM
4888 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4889 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4890 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4891 buffer list implementation.
4892 (other_buffer_safely): New function.
4893 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4894 calls to replace_buffer_in_windows and
4895 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4896 if allowed.
4897 (record_buffer): Inhibit quitting and rewrite using quittable
4898 functions. Run Qbuffer_list_update_hook if allowed.
4899 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4900 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4901 Move switch-to-buffer to window.el.
9397e56f
MR
4902 (bury-buffer): Move to window.el.
4903 (Vbuffer_list_update_hook): New variable.
4904
4905 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4906 section.
4907
4908 * window.h (resize_frame_windows): Move up in code.
4909 (Fwindow_frame): Remove EXFUN.
4910 (replace_buffer_in_all_windows): Remove prototype.
4911 (replace_buffer_in_windows_safely): Add prototype.
4912
4913 * window.c: Declare Qdelete_window static again. Move down
4914 declaration of select_count.
4915 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4916 (Fother_window): Move to window.el.
4917 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4918 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4919 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4920 window.el.
4921 (replace_buffer_in_windows): Implement by calling
4922 Qreplace_buffer_in_windows.
4923 (replace_buffer_in_all_windows): Remove with some functionality
4924 moved into replace_buffer_in_windows_safely.
4925 (replace_buffer_in_windows_safely): New function.
4926 (select_window_norecord, select_frame_norecord): Move in front
4927 of run_window_configuration_change_hook. Remove now obsolete
4928 declarations.
640c8776
SM
4929 (Fset_window_buffer): Rewrite doc-string.
4930 Call Qrecord_window_buffer.
9397e56f
MR
4931 (keys_of_window): Move binding for other-window to window.el.
4932
b50691aa
CY
49332011-06-11 Chong Yidong <cyd@stupidchicken.com>
4934
4935 * dispextern.h (struct image): Replace data member, whose int_val
4936 and ptr_val fields were not used by anything, with a single
4937 lisp_val object.
4938
4939 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4940 (gif_clear_image, gif_load, imagemagick_load_image)
4941 (gs_clear_image, gs_load): Callers changed.
4942
3f754b86
PE
49432011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4944
cca69397
PE
4945 * buffer.h: Include <time.h>, for time_t.
4946 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4947
109e28d0
PE
4948 Fix minor problems found by static checking.
4949
60737f02
PE
4950 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4951
4b66faf3
PE
4952 Make identifiers static if they are not used in other modules.
4953 * data.c (Qcompiled_function, Qframe, Qvector):
4954 * image.c (QimageMagick, Qsvg):
4955 * minibuf.c (Qmetadata):
4956 * window.c (resize_window_check, resize_root_window): Now static.
4957 * window.h (resize_window_check, resize_root_window): Remove decls.
4958
109e28d0
PE
4959 * window.c (window_deletion_count, delete_deletable_window):
4960 Remove; unused.
46a4ce9e
PE
4961 (window_body_lines): Now static.
4962 (Fdelete_other_windows_internal): Mark vars as initialized.
4963 Make sure 'resize_failed' is initialized.
4964 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4965 (resize_window_apply): Remove unused local.
4966 * window.h (delete_deletable_window): Remove decl.
4967
109e28d0 4968 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4969 (imagemagick_load_image): Fix pointer signedness problem by changing
4970 last arg from unsigned char * to char *. All uses changed.
4971 Also, fix a local for similar reasons.
4972 Remove unused locals. Remove locals to avoid shadowing.
4973 (fn_rsvg_handle_free): Remove; unused.
4974 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4975 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4976
3f754b86
PE
4977 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4978
2547adb1
CY
49792011-06-10 Chong Yidong <cyd@stupidchicken.com>
4980
4981 * image.c (gif_load): Fix omitted cast error introduced by
4982 2011-06-06 change.
4983
2c8e37d4
MR
49842011-06-10 Martin Rudalics <rudalics@gmx.at>
4985
4986 * window.h (resize_proportionally, orig_total_lines)
4987 (orig_top_line): Remove from window structure.
4988 (set_window_height, set_window_width, change_window_heights)
4989 (Fdelete_window): Remove prototypes.
4990 (resize_frame_windows): Remove duplicate declaration.
4991
440a42e3
EZ
49922011-06-10 Eli Zaretskii <eliz@gnu.org>
4993
4994 * window.h (resize_frame_windows, resize_window_check)
4995 (delete_deletable_window, resize_root_window)
4996 (resize_frame_windows): Declare prototypes.
4997
4998 * window.c (resize_window_apply): Make definition be "static" to
4999 match the prototype.
5000
562dd5e9
MR
50012011-06-10 Martin Rudalics <rudalics@gmx.at>
5002
5003 * window.c: Remove declarations of Qwindow_size_fixed,
5004 window_min_size_1, window_min_size_2, window_min_size,
5005 size_window, window_fixed_size_p, enlarge_window, delete_window.
5006 Remove static from declaration of Qdelete_window, it's
5007 temporarily needed by Fbury_buffer.
5008 (replace_window): Don't assign orig_top_line and
5009 orig_total_lines.
5010 (Fdelete_window, delete_window): Remove. Window deletion is
5011 handled by window.el.
640c8776
SM
5012 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5013 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5014 (Fdelete_other_windows): Remove. Deleting other windows is
5015 handled by window.el.
5016 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5017 handled in window.el.
5018 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5019 Window minimum sizes are handled in window.el.
5020 (shrink_windows, size_window, set_window_height)
5021 (set_window_width, change_window_heights, window_height)
5022 (window_width, CURBEG, CURSIZE, enlarge_window)
5023 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5024 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5025 handled in window.el.
5026 (make_dummy_parent): Rename to make_parent_window and give it a
5027 second argument horflag.
5028 (make_window): Don't set resize_proportionally any more.
5029 (Fsplit_window): Remove. Windows are split in window.el.
5030 (save_restore_action, save_restore_orig_size)
5031 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5032 Resize mini windows in window.el.
5033 (grow_mini_window, shrink_mini_window): Implement by calling
5034 Qresize_root_window_vertically, resize_window_check and
5035 resize_window_apply.
640c8776
SM
5036 (saved_window, Fset_window_configuration, save_window_save):
5037 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5038 resize_proportionally.
5039 (window_min_height, window_min_width): Move to window.el.
5040 (keys_of_window): Move bindings for delete-other-windows,
5041 split-window, delete-window and enlarge-window to window.el.
5042
5043 * buffer.c: Temporarily extern Qdelete_window.
5044 (Fbury_buffer): Temporarily call Qdelete_window instead of
5045 Fdelete_window (Fbury_buffer will move to window.el soon).
5046
5047 * frame.c (set_menu_bar_lines_1): Remove code handling
5048 orig_top_line and orig_total_lines.
5049
5050 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5051 set_window_height but set heights directly.
5052 (change_frame_size_1): Use resize_frame_windows.
5053
5054 * xdisp.c (init_xdisp): Don't use set_window_height but set
5055 heights directly.
5056
640c8776
SM
5057 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5058 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5059 run_window_configuration_change_hook.
5060
5061 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5062 instead of change_window_heights and run
5063 run_window_configuration_change_hook.
5064
1a13852e
MR
50652011-06-09 Martin Rudalics <rudalics@gmx.at>
5066
5067 * window.c (replace_window): Rename second argument REPLACEMENT to
5068 NEW. New third argument SETFLAG. Rewrite.
5069 (delete_window, make_dummy_parent): Call replace_window with
5070 third argument 1.
5071 (window_list_1): Move down in code.
5072 (run_window_configuration_change_hook): Move set_buffer part
5073 before select_frame_norecord part in order to unwind correctly.
5074 Rename count1 to count.
5075 (recombine_windows, delete_deletable_window, resize_root_window)
5076 (Fdelete_other_windows_internal)
5077 (Frun_window_configuration_change_hook, make_parent_window)
5078 (resize_window_check, resize_window_apply, Fresize_window_apply)
5079 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5080 (Fdelete_window_internal, Fresize_mini_window_internal):
5081 New functions.
1a13852e
MR
5082 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5083
f3d1777e
MR
50842011-06-08 Martin Rudalics <rudalics@gmx.at>
5085
496e208e
MR
5086 * window.h (window): Add some new members to window structure -
5087 normal_lines, normal_cols, new_total, new_normal, clone_number,
5088 splits, nest, prev_buffers, next_buffers.
5089 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5090 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5091
f3d1777e
MR
5092 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5093 Remove.
496e208e
MR
5094 (make_dummy_parent): Set new members of windows structure.
5095 (make_window): Move down in code. Handle new members of window
5096 structure.
5097 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5098 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5099 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5100 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5101 (Fset_window_next_buffers, Fset_window_clone_number):
5102 New functions.
496e208e
MR
5103 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5104 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5105 Doc-string fixes.
5106 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5107 Argument WINDOW can be now internal window too.
5108 (Fwindow_use_time): Move up in code.
5109 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5110 Rewrite doc-string.
5111 (Fset_window_configuration, saved_window)
5112 (Fcurrent_window_configuration, save_window_save): Handle new
5113 members of window structure.
b9e809c2
MR
5114 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5115 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5116 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5117 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5118 Qget_mru_window, Qresize_root_window,
5119 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5120 Qauto_buffer_name; staticpro them.
f3d1777e 5121
abde8f8c
MR
51222011-06-07 Martin Rudalics <rudalics@gmx.at>
5123
5124 * window.c (Fwindow_total_size, Fwindow_left_column)
5125 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5126 (Fwindow_list_1): New functions.
5127 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5128 (Fwindow_width, Fscroll_left, Fscroll_right):
5129 Use window_body_cols instead of window_box_text_cols.
5130 (delete_window, Fset_window_configuration):
5131 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5132 (delete_all_subwindows): Take a window as argument and not a
5133 structure. Rewrite.
190b47e6
MR
5134 (window_loop): Remove handling of GET_LRU_WINDOW and
5135 GET_LARGEST_WINDOW.
5136 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5137
5138 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5139 window_box_text_cols. delete_all_subwindows now takes a
5140 Lisp_Object as argument.
abde8f8c 5141
640c8776
SM
5142 * indent.c (compute_motion, Fcompute_motion):
5143 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5144
fa8a67e6
MR
5145 * frame.c (delete_frame): Call delete_all_subwindows with root
5146 window as argument.
5147
a54e3482
DC
51482011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5149
5150 * fns.c (Fputhash): Document return value.
5151
60002bf5
CY
51522011-06-06 Chong Yidong <cyd@stupidchicken.com>
5153
5154 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5155
0c671da6 51562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5157
b862a52a 5158 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5159
be44ca6c
PE
5160 Check for overflow when converting integer to cons and back.
5161 * charset.c (Fdefine_charset_internal, Fdecode_char):
5162 Use cons_to_unsigned to catch overflow.
5163 (Fencode_char): Use INTEGER_TO_CONS.
5164 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5165 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5166 * data.c (long_to_cons, cons_to_long): Remove.
5167 (cons_to_unsigned, cons_to_signed): New functions.
5168 These signal an error for invalid or out-of-range values.
5169 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5170 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5171 * font.c (Ffont_variation_glyphs):
5172 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5173 * lisp.h: Include <intprops.h>.
5174 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5175 (cons_to_signed, cons_to_unsigned): New decls.
5176 (long_to_cons, cons_to_long): Remove decls.
5177 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5178 (Fprimitive_undo): Use CONS_TO_INTEGER.
5179 * xfns.c (Fx_window_property): Likewise.
5180 * xselect.c: Include <limits.h>.
5181 (x_own_selection, selection_data_to_lisp_data):
5182 Use INTEGER_TO_CONS.
5183 (x_handle_selection_request, x_handle_selection_clear)
5184 (x_get_foreign_selection, Fx_disown_selection_internal)
5185 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5186 (lisp_data_to_selection_data): Use cons_to_unsigned.
5187 (x_fill_property_data): Use cons_to_signed.
5188 Report values out of range.
5189
d1f3d2af
PE
5190 Check for buffer and string overflow more precisely.
5191 * buffer.h (BUF_BYTES_MAX): New macro.
5192 * lisp.h (STRING_BYTES_MAX): New macro.
5193 * alloc.c (Fmake_string):
5194 * character.c (string_escape_byte8):
5195 * coding.c (coding_alloc_by_realloc):
5196 * doprnt.c (doprnt):
5197 * editfns.c (Fformat):
5198 * eval.c (verror):
5199 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5200 since they may not be the same number.
5201 * editfns.c (Finsert_char):
5202 * fileio.c (Finsert_file_contents):
5203 Likewise for BUF_BYTES_MAX.
5204
dd52fcea
PE
5205 * image.c: Use ptrdiff_t, not int, for sizes.
5206 (slurp_file): Switch from int to ptrdiff_t.
5207 All uses changed.
5208 (slurp_file): Check that file size fits in both size_t (for
5209 malloc) and ptrdiff_t (for sanity and safety).
5210
7f9bbdbb
PE
5211 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5212 if b->modtime has its maximal value.
5213
dfe18f82
PE
5214 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5215
84acfcf0
PE
5216 Don't assume time_t can fit into int.
5217 * buffer.h (struct buffer.modtime): Now time_t, not int.
5218 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5219 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5220
ccd9a01a
PE
5221 Minor fixes for signed vs unsigned integers.
5222 * character.h (MAYBE_UNIFY_CHAR):
5223 * charset.c (maybe_unify_char):
5224 * keyboard.c (read_char, reorder_modifiers):
5225 XINT -> XFASTINT, since the integer must be nonnegative.
5226 * ftfont.c (ftfont_spec_pattern):
5227 * keymap.c (access_keymap, silly_event_symbol_error):
5228 XUINT -> XFASTINT, since the integer must be nonnegative.
5229 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5230 since it makes no difference and we prefer signed.
5231 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5232 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5233 nonnegative.
5234
d6d100dd
SM
52352011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5236
5237 * window.h (Fwindow_frame): Declare.
5238
2b6148e4
PE
52392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5240
5241 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5242 (SPARE_MEMORY): Always define.
5243 (LARGE_REQUEST): Remove.
5244 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5245
f230ecc9
MR
52462011-06-06 Martin Rudalics <rudalics@gmx.at>
5247
727e958e
MR
5248 * lisp.h: Move EXFUNS for Fframe_root_window,
5249 Fframe_first_window and Fset_frame_selected_window to window.h.
5250
5251 * window.h: Move EXFUNS for Fframe_root_window,
5252 Fframe_first_window and Fset_frame_selected_window here from
5253 lisp.h.
5254
5255 * frame.c (Fwindow_frame, Fframe_first_window)
5256 (Fframe_root_window, Fframe_selected_window)
5257 (Fset_frame_selected_window): Move to window.c.
5258 (Factive_minibuffer_window): Move to minibuf.c.
5259 (Fother_visible_frames_p): New function.
5260
5261 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5262
f230ecc9
MR
5263 * window.c (decode_window, decode_any_window): Move up in code.
5264 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5265 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5266 (Fwindow_buffer): Move up and rewrite doc-string.
5267 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5268 (Fwindow_prev): New functions.
727e958e
MR
5269 (Fwindow_frame): Move here from frame.c. Accept any window as
5270 argument.
5271 (Fframe_root_window, Fframe_first_window)
5272 (Fframe_selected_window): Move here from frame.c. Accept frame
5273 or arbitrary window as argument. Update doc-strings.
5274 (Fminibuffer_window): Move up in code.
5275 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5276 (Fset_frame_selected_window): Move here from frame.c.
5277 Marginal rewrite.
727e958e
MR
5278 (Fselected_window, select_window, Fselect_window): Move up in
5279 code. Minor doc-string fixes.
f230ecc9 5280
4d09bcf6
PE
52812011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5282
5283 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5284 Do not assume that spare memory exists; that assumption is valid
5285 only if SYSTEM_MALLOC.
5286 (LARGE_REQUEST): New macro, so that the issue of large requests
5287 is separated from the issue of spare memory.
5288
810928a2
AS
52892011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5290
172418ad
AS
5291 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5292 format. (Bug#8806)
5293
43f862f7
AS
5294 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5295
810928a2
AS
5296 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5297 before statements.
5298
a059fe24
JD
52992011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5300
5301 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5302
5303 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5304
5305 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5306 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5307
989bf368
JB
53082011-06-05 Juanma Barranquero <lekktu@gmail.com>
5309
5310 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5311
4b80f674
CY
53122011-06-04 Chong Yidong <cyd@stupidchicken.com>
5313
5314 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5315 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5316 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5317 New error handlers.
4b80f674
CY
5318 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5319 Obey Vx_select_enable_clipboard_manager. Catch errors in
5320 x_clipboard_manager_save (Bug#8779).
5321 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5322 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5323
99a33b77 53242011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5325
5326 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5327
99a33b77 53282011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5329
5330 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5331 in the current matrix if keep_current_p is non-zero.
5332
8264569d
EZ
53332011-06-04 Eli Zaretskii <eliz@gnu.org>
5334
5335 * bidi.c (bidi_level_of_next_char): Fix last change.
5336
57f97249
EZ
53372011-06-03 Eli Zaretskii <eliz@gnu.org>
5338
fec2107c 5339 Support bidi reordering of text covered by display properties.
57f97249 5340
fec2107c
EZ
5341 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5342 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5343 (bidi_cache_search, bidi_cache_iterator_state)
5344 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5345 (bidi_level_of_next_char, bidi_move_to_visually_next):
5346 Support character positions inside a run of characters covered by a
fec2107c
EZ
5347 display string.
5348 (bidi_paragraph_init, bidi_resolve_explicit_1)
5349 (bidi_level_of_next_char): Call bidi_fetch_char and
5350 bidi_fetch_char_advance instead of FETCH_CHAR and
5351 FETCH_CHAR_ADVANCE.
5352 (bidi_init_it): Initialize new members.
5353 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5354 definitions.
5355 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5356 instead of using explicit *_CHAR codes.
d6d100dd
SM
5357 (bidi_resolve_explicit, bidi_resolve_weak):
5358 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5359 bidirectional text is supported only in multibyte buffers.
5360 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5361 it to initialize the frame_window_p member of struct bidi_it.
5362 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5363 (bidi_resolve_explicit, bidi_resolve_weak)
5364 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5365 bidi_it->nchars is non-positive.
5366 (bidi_level_of_next_char): Don't try to lookup the cache for the
5367 next/previous character if nothing is cached there yet, or if we
5368 were just reseat()'ed to a new position.
c40e2fb2 5369
0e14fe90
EZ
5370 * xdisp.c (set_cursor_from_row): Set start and stop points
5371 according to the row's direction when priming the loop that looks
5372 for the glyph on which to display cursor.
5373 (single_display_spec_intangible_p): Function deleted.
5374 (display_prop_intangible_p): Reimplement to call
5375 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5376 Accept 3 additional arguments needed by handle_display_spec.
5377 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5378 values: lists, `(when COND...)' forms, etc.
5379 (single_display_spec_string_p): Support property values that are
5380 lists with the argument STRING its top-level element.
5381 (display_prop_string_p): Fix the condition for processing a
5382 property that is a list to be consistent with handle_display_spec.
fec2107c 5383 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5384 last portion of handle_display_prop.
5385 (compute_display_string_pos): Accept additional argument
5386 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5387 value of a `display' property is a "replacing spec".
5388 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5389 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5390 the display property, but just return a value indicating whether
5391 the display property will replace the characters it covers.
5392 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5393 frame_window_p members of struct bidi_it.
d6d100dd
SM
5394 (compute_display_string_pos, compute_display_string_end):
5395 New functions.
fec2107c
EZ
5396 (push_it): Accept second argument POSITION, where pop_it should
5397 jump to continue iteration.
5398 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5399
fec2107c
EZ
5400 * keyboard.c (adjust_point_for_property): Adjust the call to
5401 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5402
5403 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5404 (bidi_init_it): Update prototypes.
5405 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5406 (compute_display_string_pos, compute_display_string_end):
5407 Declare prototypes.
fec2107c
EZ
5408 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5409 EMACS_INT.
fc6f18ce 5410
40087514 54112011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5412
57f53182
PE
5413 Malloc failure behavior now depends on size of allocation.
5414 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5415 * lisp.h: Change signatures accordingly.
5416 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5417 All callers changed. (Bug#8762)
5418
5419 * gnutls.c: Use Emacs's memory allocators.
5420 Without this change, the gnutls library would invoke malloc etc.
5421 directly, which causes problems on non-SYNC_INPUT hosts, and which
5422 runs afoul of improving memory_full behavior. (Bug#8761)
5423 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5424 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5425 xfree instead of the default malloc, realloc, free.
5426 (Fgnutls_boot): No need to check for memory allocation failure,
5427 since xmalloc does that for us.
5428
ac32cd99 5429 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5430 * category.c (hash_get_category_set):
5431 * ccl.c (ccl_driver):
5432 * charset.c (Fdefine_charset_internal):
5433 * charset.h (struct charset.hash_index):
5434 * composite.c (get_composition_id, gstring_lookup_cache)
5435 (composition_gstring_put_cache):
5436 * composite.h (struct composition.hash_index):
5437 * dispextern.h (struct image.hash):
5438 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5439 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5440 (hashfn_equal, hashfn_user_defined, make_hash_table)
5441 (maybe_resize_hash_table, hash_lookup, hash_put)
5442 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5443 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5444 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5445 * image.c (make_image, search_image_cache, lookup_image)
5446 (xpm_put_color_table_h):
5447 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5448 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5449 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5450 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5451 * alloc.c (allocate_vectorlike):
5452 Check for overflow in vector size calculations.
5453 * ccl.c (ccl_driver):
5454 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5455 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5456 need to be updated by these changes.
40087514
PE
5457 * fns.c (make_hash_table, maybe_resize_hash_table):
5458 Check for integer overflow with large hash tables.
0de4bb68
PE
5459 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5460 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5461 (SXHASH_REDUCE): New macro.
5462 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5463 Use it instead of discarding useful hash info with large hash values.
5464 (sxhash_float): New function.
5465 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5466 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5467 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5468 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5469 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5470 Adjust signatures to match updated version of code.
5471 (consing_since_gc): Now EMACS_INT, since a single hash table can
5472 use more than INT_MAX bytes.
5473
698d32e2
DN
54742011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5475
5476 Make it possible to build with GCC-4.6+ -O2 -flto.
5477
5478 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5479
fd6fa53f
SM
54802011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5481
5482 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5483 Call minibuffer-inactive-mode.
5484
864db017
JB
54852011-05-31 Juanma Barranquero <lekktu@gmail.com>
5486
5487 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5488 Update dependencies.
5489
2ad0baf4
DN
54902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5491
5492 * data.c (init_data): Remove code for UTS, this system is not
5493 supported anymore.
5494
4fcc2638
DN
54952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5496
5497 Don't force ./temacs to start in terminal mode.
5498
5499 * frame.c (make_initial_frame): Initialize faces in all cases, not
5500 only when CANNOT_DUMP is defined.
5501 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5502
c56e0fd5
DN
55032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5504
5505 * dispnew.c (add_window_display_history): Use const for the string
5506 pointer. Remove declaration, not needed.
5507
333d54da 55082011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5509
55d4c1b2 5510 Use 'inline', not 'INLINE'.
333d54da 5511 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5512 * alloc.c, fontset.c (INLINE): Remove.
5513 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5514 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5515 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5516 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5517 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5518
738db178
DN
55192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5520
5521 Make it possible to run ./temacs.
5522
5523 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5524 syms_of_callproc does the same thing. Remove test for
5525 "initialized", do it in the caller.
5526 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5527
620c53a6
SM
55282011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5529
5530 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5531 (read_minibuf): Use get_minibuffer.
5532 (syms_of_minibuf): Use DEFSYM.
5533 (Qmetadata): New var.
5534 * data.c (Qbuffer): Don't make it static.
5535 (syms_of_data): Use DEFSYM.
5536
e003a292
PE
55372011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5538
5539 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5540 (CCL_CODE_MIN): New macro.
5541
ed008a6d
PE
55422011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5543
3687c2ef
PE
5544 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5545
ed008a6d
PE
5546 * eval.c (Qdebug): Now static.
5547 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5548 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5549 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5550
d66c4c7c
CY
55512011-05-29 Chong Yidong <cyd@stupidchicken.com>
5552
5553 * image.c: Various fixes to ImageMagick code comments.
5554 (Fimagemagick_types): Doc fix.
5555
5fbc2025
PE
55562011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5557
0196f88a
PE
5558 Minor fixes prompted by GCC 4.6.0 warnings.
5559
5560 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5561
5fbc2025
PE
5562 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5563 (x_clipboard_manager_save_all): Move extern decl to ...
5564 * xterm.h: ... here, so that it can be checked for consistency.
5565
1dd3c2d9
CY
55662011-05-29 Chong Yidong <cyd@stupidchicken.com>
5567
5568 * xselect.c (x_clipboard_manager_save_frame)
5569 (x_clipboard_manager_save_all): New functions.
5570 (Fx_clipboard_manager_save): Lisp function deleted.
5571
5572 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5573 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5574
5575 * xterm.h: Update prototype.
5576
5ba6571d
WX
55772011-05-28 William Xu <william.xwl@gmail.com>
5578
5579 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5580 exiting (Bug#8239).
5581
3eaff834
JM
55822011-05-28 Jim Meyering <meyering@redhat.com>
5583
e1900994 5584 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5585 * fns.c (to_uchar): Define.
5586 (crypto_hash_function): Use it to convert some newly-signed
5587 variables to unsigned, to avoid sign-extension bugs. For example,
5588 without this change, (md5 "truc") would evaluate to
5589 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5590 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5591 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5592
0f6990a7
PE
55932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5594
5595 Integer overflow fixes.
c8a9ca5a 5596
08686060
PE
5597 * dbusbind.c: Serial number integer overflow fixes.
5598 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5599 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5600 to hold a serial number that is too large for a fixnum.
5601 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5602 Check for serial numbers out of range. Decode any serial number
59568bf0 5603 that was so large that it became a float. (Bug#8722)
08686060 5604
2d1fc3c7
PE
5605 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5606 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5607 Use XFASTINT rather than XUINT when numbers are nonnegative.
5608 (xd_append_arg, Fdbus_method_return_internal):
5609 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5610 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5611 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5612 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5613 (Bug#8722)
2d1fc3c7 5614
c8a9ca5a
PE
5615 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5616
519e1d69
PE
5617 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5618
30569699
PE
5619 ccl: add integer overflow checks
5620 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5621 (IN_INT_RANGE): New macros.
5622 (ccl_driver): Use them to check for integer overflow when
5623 decoding a CCL program. Many of the new checks are whether XINT (x)
5624 fits in int; it doesn't always, on 64-bit hosts. The new version
5625 doesn't catch all possible integer overflows, but it's an
847044ea 5626 improvement. (Bug#8719)
30569699 5627
c11285dc
PE
5628 * alloc.c (make_event_array): Use XINT, not XUINT.
5629 There's no need for unsigned here.
5630
fdccd48e
PE
5631 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5632 This follows up to the 2011-05-06 change that substituted uintptr_t
5633 for EMACS_INT. This case wasn't caught back then.
5634
37910ab2
PE
5635 Rework Fformat to avoid integer overflow issues.
5636 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5637 now (part of C89). Include <verify.h>.
5638 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5639 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5640 (Fformat): Avoid the prepass trying to compute sizes; it was only
5641 approximate and thus did not catch overflow reliably. Instead, walk
5642 through the format just once, formatting and computing sizes as we go,
5643 checking for integer overflow at every step, and allocating a larger
5644 buffer as needed. Keep track separately whether the format is
5645 multibyte. Keep only the most-recently calculated precision, rather
5646 than them all. Record whether each argument has been converted to
5647 string. Use EMACS_INT, not int, for byte and char and arg counts.
5648 Support field widths and precisions larger than INT_MAX. Avoid
5649 sprintf's undefined behavior with conversion specifications such as %#d
5650 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5651 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5652 formatting out-of-range floating point numbers with int
9173deec 5653 formats. (Bug#8668)
37910ab2 5654
2e6578fb
PE
5655 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5656
0ae6bdee
PE
5657 * data.c: Avoid integer truncation in expressions involving floats.
5658 * data.c: Include <intprops.h>.
5659 (arith_driver): When there's an integer overflow in an expression
5660 involving floating point, convert the integers to floating point
5661 so that the resulting value does not suffer from catastrophic
5662 integer truncation. For example, on a 64-bit host (* 4
5663 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5664 Do not rely on undefined behavior after integer overflow.
5665
de883a70
PE
5666 merge count_size_as_multibyte, parse_str_to_multibyte
5667 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5668 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5669 Check for integer overflow.
5670 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5671 since it's now a duplicate of the other. This is more of
5672 a character than a buffer op, so better that it's in character.c.
5673 * fns.c, print.c: Adjust to above changes.
5674
2ff916cb
PE
56752011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5676
5677 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5678
f1b54466
PE
56792011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5680
fb1ac845
PE
5681 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5682 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5683 (x_clipboard_manager_save): Now static.
5684 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5685
f1b54466
PE
5686 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5687 (crypto_hash_function): Now static.
5688 Fix pointer signedness problems. Avoid unnecessary initializations.
5689
a9f737ee
CY
56902011-05-27 Chong Yidong <cyd@stupidchicken.com>
5691
5692 * termhooks.h (Vselection_alist): Make it terminal-local.
5693
5694 * terminal.c (create_terminal): Initialize it.
5695
5696 * xselect.c: Support for clipboard managers.
5697 (Vselection_alist): Move to termhooks.h as terminal-local var.
5698 (LOCAL_SELECTION): New macro.
5699 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5700 (symbol_to_x_atom): Remove gratuitous arg.
5701 (x_handle_selection_request, lisp_data_to_selection_data)
5702 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5703 (x_own_selection, x_get_local_selection, x_convert_selection):
5704 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5705 (some_frame_on_display): Delete unused function.
5706 (Fx_own_selection_internal, Fx_get_selection_internal)
5707 (Fx_disown_selection_internal, Fx_selection_owner_p)
5708 (Fx_selection_exists_p): New optional frame arg.
5709 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5710 (x_handle_selection_clear): Don't treat other terminals with the
5711 same keyboard specially. Use the terminal-local Vselection_alist.
5712 (x_clear_frame_selections): Use Frun_hook_with_args.
5713
5714 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5715
5716 * xterm.h: Add support for those atoms.
5717
e067f0c1
CY
57182011-05-26 Chong Yidong <cyd@stupidchicken.com>
5719
5720 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5721 (converted_selections, conversion_fail_tag): New global variables.
5722 (x_selection_request_lisp_error): Free the above.
5723 (x_get_local_selection): Remove unnecessary code.
5724 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5725 of converted selections stored in converted_selections.
5726 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5727 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5728 (x_convert_selection): New function.
5729 (x_handle_selection_event): Simplify.
5730 (x_get_foreign_selection): Don't ignore incoming requests while
5731 waiting for an answer; this will fail when we implement
5732 SAVE_TARGETS, and seems unnecessary anyway.
5733 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5734 (Vx_sent_selection_functions): Doc fix.
5735
0f4aebc0
LL
57362011-05-26 Leo Liu <sdl.web@gmail.com>
5737
5738 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5739
e61124cd
YM
57402011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5741
5742 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5743
5744 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5745 for fringe update if it has periodic bitmap.
ac389d0c 5746 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5747 and fringe_bitmap_periodic_p.
5748
5749 * fringe.c (get_fringe_bitmap_data): New function.
5750 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5751 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5752 row. Mark glyph row for fringe update if periodicity changed.
5753
5754 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5755 for fringe update unless it has periodic bitmap.
5756
f16d9837
KH
57572011-05-25 Kenichi Handa <handa@m17n.org>
5758
5759 * xdisp.c (get_next_display_element): Set correct it->face_id for
5760 a static composition.
5761
e1b90ef6
LL
57622011-05-24 Leo Liu <sdl.web@gmail.com>
5763
5764 * deps.mk (fns.o):
5765 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5766
5767 * fns.c (crypto_hash_function, Fsha1): New function.
5768 (Fmd5): Use crypto_hash_function.
5769 (syms_of_fns): Add Ssha1.
5770
7400048f
PE
57712011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5772
5773 * gnutls.c: Remove unused macros.
5774 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5775 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5776 Remove macros that are defined and never used.
5777 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5778
abb71cf4
CY
57792011-05-22 Chong Yidong <cyd@stupidchicken.com>
5780
5781 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5782 (Fx_get_selection_internal): Minor cleanup.
5783 (Fx_own_selection_internal): Rename arguments for consistency with
5784 select.el.
5785
6307db39
PE
57862011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5787
5788 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5789
f3d4e0a4
CY
57902011-05-22 Chong Yidong <cyd@stupidchicken.com>
5791
5792 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5793
4d8ade89
YM
57942011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5795
5796 * dispnew.c (scrolling_window): Don't exclude the case that the
5797 last enabled row in the desired matrix touches the bottom boundary.
5798
32078c8d
GM
57992011-05-21 Glenn Morris <rgm@gnu.org>
5800
5801 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5802 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5803 and add some more files.
32078c8d 5804
7285dc67
EZ
58052011-05-20 Eli Zaretskii <eliz@gnu.org>
5806
5807 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5808 report_file_error introduced by the change from 2011-05-07.
5809
89d1bd22
PE
58102011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5811
5812 * systime.h (Time): Define only if emacs is defined.
5813 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5814 where the include path doesn't have X11/X.h by default. See
5815 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5816
cd394be1 58172011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5818
5819 * composite.c (find_automatic_composition): Fix previous change.
5820
b9704ad9
GM
58212011-05-20 Glenn Morris <rgm@gnu.org>
5822
5823 * lisp.mk: New file, split from Makefile.in.
5824 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5825 (shortlisp): Remove.
5826 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5827
4a720484
GM
58282011-05-19 Glenn Morris <rgm@gnu.org>
5829
5830 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5831 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5832 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5833 (lisp): Set the order to that of loadup.el.
5834 (shortlisp): Make it a copy of $lisp.
5835 (SOME_MACHINE_LISP): Remove.
5836 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5837 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5838
a28d4396
KH
58392011-05-18 Kenichi Handa <handa@m17n.org>
5840
5841 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5842 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5843 (find_automatic_composition): Mostly rewrite for efficiency.
5844
a2b1fa8e
JB
58452011-05-18 Juanma Barranquero <lekktu@gmail.com>
5846
5847 * makefile.w32-in: Update dependencies.
5848
8e1f5610
CS
58492011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5850
5851 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5852 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5853
7025ee00 58542011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5855
cdfa6eab
PE
5856 Fix some integer overflow issues, such as string length overflow.
5857
06d6db33
PE
5858 * insdel.c (count_size_as_multibyte): Check for string overflow.
5859
2b4560a8
PE
5860 * character.c (lisp_string_width): Check for string overflow.
5861 Use EMACS_INT, not int, for string indexes and lengths; in
5862 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5863 the resulting string length overflows an EMACS_INT; instead,
5864 report a string overflow if no precision given. When checking for
5865 precision exhaustion, use a check that cannot possibly have
5866 integer overflow. (Bug#8675)
5867 * character.h (lisp_string_width): Adjust to new signature.
5868
cb93f9be
PE
5869 * alloc.c (string_overflow): New function.
5870 (Fmake_string): Use it. This doesn't change behavior, but saves
5871 a few bytes and will simplify future changes.
5872 * character.c (string_escape_byte8): Likewise.
5873 * lisp.h (string_overflow): New decl.
5874
1a1f3366
PE
5875 Fixups, following up to the user-interface timestamp change.
5876 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5877 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5878 * msdos.c (mouse_get_pos): Likewise.
5879 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5880 * w32gui.h (Time): Define by including "systime.h" rather than by
5881 declaring it ourselves. (Bug#8664)
5882
d4e3e4d3
PE
5883 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5884 * image.c (clear_image_cache): Likewise.
5885
f6a24d19
PE
5886 * term.c (term_mouse_position): Don't assume time_t wraparound.
5887
08dc5ae6
PE
5888 Be more systematic about user-interface timestamps.
5889 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5890 and sometimes 'EMACS_UINT', to represent these timestamps.
5891 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5892 This makes the code easier to follow, and makes it easier to catch
5893 integer overflow bugs such as Bug#8664.
5894 * frame.c (Fmouse_position, Fmouse_pixel_position):
5895 Use Time, not unsigned long, for user-interface timestamps.
5896 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5897 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5898 * keyboard.h (last_event_timestamp): Likewise.
5899 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5900 * menu.h (xmenu_show): Likewise.
5901 * term.c (term_mouse_position): Likewise.
5902 * termhooks.h (struct input_event.timestamp): Likewise.
5903 (struct terminal.mouse_position_hook): Likewise.
5904 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5905 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5906 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5907 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5908 what it was before.
5909 * menu.h, termhooks.h: Include "systime.h", for Time.
5910
8e55734a
PE
5911 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5912 Don't assume that the difference between two unsigned long values
5913 can fit into an integer. At this point, we know button_down_time
5914 <= event->timestamp, so the difference must be nonnegative, so
5915 there's no need to cast the result if double-click-time is
5916 nonnegative, as it should be; check that it's nonnegative, just in
5917 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5918 apart (about 25 days). (Bug#8664)
8e55734a 5919
841f1b75 5920 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5921 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5922
3e26f69c
PE
5923 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5924 that always fit in int. Use a sentinel instead of a counter, to
5925 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5926 * frame.h (struct frame): Use int for menu_bar_items_used
5927 instead of EMACS_INT, since it always fits in int.
3e26f69c 5928
5cc152c0
PE
5929 * menu.c (grow_menu_items): Check for int overflow.
5930
d89eb65e
PE
5931 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5932
5235bd3e
PE
5933 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5934 Before, the code was not consistent. These values cannot exceed
5935 2**31 - 1 so there's no need to make them unsigned.
5936 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5937 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5938 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5939 as modifiers.
5940 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5941
bc827e23
PE
5942 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5943 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5944 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5945 presumably because the widths might not match.
5946
78eb494e
PE
5947 * window.c (size_window): Avoid needless test at loop start.
5948
04f2d78b
CB
59492011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5950
5951 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5952
d2fc7e3d 59532011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5954
5955 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5956
d2fc7e3d 59572011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5958
5959 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5960 `width' to `bar_area_x' and `bar_area_width', respectively.
5961 (x_scroll_run): Take account of fringe background extension.
5962
04f2d78b
CB
5963 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5964 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5965 `bar_area_width', respectively.
5966 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5967 background extension.
5968
79b70037
GM
59692011-05-10 Jim Meyering <meyering@redhat.com>
5970
5971 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5972
2f142cc5
JB
59732011-05-10 Juanma Barranquero <lekktu@gmail.com>
5974
5975 * image.c (Finit_image_library): Return t for built-in image types,
5976 like pbm and xbm. (Bug#8640)
5977
57679c86
AS
59782011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5979
5980 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5981
888c9e86
EZ
59822011-05-07 Eli Zaretskii <eliz@gnu.org>
5983
b0512a1d
EZ
5984 * w32console.c (Fset_screen_color): Doc fix.
5985 (Fget_screen_color): New function.
5986 (syms_of_ntterm): Defsubr it.
5987
7285dc67
EZ
5988 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5989 unlink the temporary file if Fcall_process didn't create it in the
5990 first place.
5991 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5992 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5993 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5994 cue to call_process_cleanup not to close that handle.
5995
4d3fcc8e
BK
59962011-05-07 Ben Key <bkey76@gmail.com>
5997
5998 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5999 one of two shell specific rules, either bootstrap-temacs-CMD or
6000 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6001 to the previous implementation of the bootstrap-temacs rule.
6002 The bootstrap-temacs-CMD rule is similar to the previous
6003 implementation of the bootstrap-temacs rule except that it
6004 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6005 variable.
6006
6007 These changes, along with some changes to nt/configure.bat,
6008 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6009 earlier fix to add support for --cflags and --ldflags options
6010 that include quotes so that it works whether make uses cmd or
6011 sh as the shell.
6012
b4289b64
MA
60132011-05-06 Michael Albinus <michael.albinus@gmx.de>
6014
6015 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6016 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6017 is a constant.
6018 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6019 a string. Handle both cases.
6020 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6021 (Fdbus_register_method): Use Qinvalid_function.
6022
af4c0e28
JB
60232011-05-06 Juanma Barranquero <lekktu@gmail.com>
6024
6025 * makefile.w32-in: Update dependencies.
6026 (LISP_H): Add inttypes.h and stdin.h.
6027 (PROCESS_H): Add unistd.h.
6028
c51453d9
EZ
60292011-05-06 Eli Zaretskii <eliz@gnu.org>
6030
6031 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6032 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6033
8ff0ac3c 60342011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6035
4c4b566b
PE
6036 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6037
aab2b9b5
PE
6038 * term.c (vfatal): Remove stray call to va_end.
6039 It's not needed and the C Standard doesn't allow it here anyway.
6040
c378da0b
PE
6041 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6042 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6043
288b08c7
PE
6044 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6045 bytes.
6046
e3601888
PE
6047 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6048
db6c0e74
PE
6049 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6050
dd5963ea
PE
6051 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6052
88c9450f
PE
6053 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6054
2f9442b8
PE
6055 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6056
c032b5f8
PE
6057 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6058 * charset.c (Fdefine_charset_internal): Don't initialize
6059 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6060 32-bit int (Bug#8600).
a108c10b
PE
6061
6062 * lread.c (read_integer): Be more consistent with string-to-number.
6063 Use string_to_number to do the actual conversion; this avoids
6064 rounding errors and fixes some other screwups. Without this fix,
6065 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6066 (digit_to_number): Move earlier, for benefit of read_integer.
6067 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6068 not a digit in any supported base. (Bug#8602)
a108c10b 6069
ad5f9eea
PE
6070 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6071
aec1708a
PE
6072 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6073 to match comment at start of function. This also removes a
6074 GCC warning about overflow in a 32+64-bit port.
6075
47be4ab5
PE
6076 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6077
371cac43
PE
6078 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6079 Reported by Stefan Monnier in
6080 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6081 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6082 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6083
d01a7826
PE
6084 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6085 (EMACS_UINTPTR): Likewise, with uintptr_t.
6086
7fd47d5c
PE
6087 * lisp.h: Prefer 64-bit EMACS_INT if available.
6088 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6089 on 32-bit hosts that have 64-bit int, so that they can access
6090 large files.
122b0c86
PE
6091 However, temporarily disable this change unless the temporary
6092 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6093
8727937b
PE
6094 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6095
8ac068ac
PE
6096 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6097 This removes an assumption that EMACS_INT and long are the same
6098 width as pointers. The assumption is true for Emacs porting targets
6099 now, but we want to make other targets possible.
6100 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6101 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6102 In the rest of the code, change types of integers that hold casted
6103 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6104 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6105 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6106 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6107 No need to cast type when ORing.
6108 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6109 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6110 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6111 assume EMACS_INT is the same width as char *.
6112 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6113 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6114 Remove no-longer-needed casts.
6115 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6116 (xg_tool_bar_help_callback, xg_make_tool_item):
6117 Use EMACS_INTPTR to hold an integer
6118 that will be cast to void *; this can avoid a GCC warning
6119 if EMACS_INT is not the same width as void *.
6120 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6121 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6122 (current_message_1, set_message_1):
6123 Use a local to convert to proper width without a cast.
6124 * xmenu.c (dialog_selection_callback): Likewise.
6125
ede49d71
PE
6126 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6127 Also, don't assume VALBITS / RAND_BITS is less than 5,
6128 and don't rely on undefined behavior when shifting a 1 left into
6129 the sign bit.
6130 * lisp.h (get_random): Change signature to match.
6131
2f30ecd0
PE
6132 * lread.c (hash_string): Use size_t, not int, for hash computation.
6133 Normally we prefer signed values; but hashing is special, because
6134 it's better to use unsigned division on hash table sizes so that
6135 the remainder is nonnegative. Also, size_t is the natural width
6136 for hashing into memory. The previous code used 'int', which doesn't
6137 retain enough info to hash well into very large tables.
6138 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6139
2a866e7b
PE
6140 * dbusbind.c: Don't possibly lose pointer info when converting.
6141 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6142 Use XPNTR rather than XHASH, so that the high-order bits of
6143 the pointer aren't lost when converting through void *.
6144
51639eac
PE
6145 * eval.c (Fautoload): Don't double-shift a pointer.
6146
92394119
PE
6147 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6148
dbdb9a7c
JB
61492011-05-06 Juanma Barranquero <lekktu@gmail.com>
6150
6151 * gnutls.c (DEF_GNUTLS_FN):
6152 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6153
db7a0b4f
AS
61542011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6155
6156 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6157 marker. (Bug#8610)
6158
cd394be1 61592011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6160
6161 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6162 New version that can reserve upto 2GB of heap space.
6163
f7ff1b0f 61642011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6165
6166 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6167
639c109b
TZ
61682011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6169
6170 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6171 `gnutls_certificate_set_x509_key_file'.
6172
d2127135
JB
61732011-05-05 Juanma Barranquero <lekktu@gmail.com>
6174
6175 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6176 Update dependencies.
6177
e968f4f3
JB
61782011-05-04 Juanma Barranquero <lekktu@gmail.com>
6179
6180 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6181 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6182 Remove unused parameter `fildes'.
6183 * process.c (read_process_output, send_process): Don't pass it.
6184
84d358f0
JB
61852011-05-04 Juanma Barranquero <lekktu@gmail.com>
6186
6187 Fix previous change: the library cache is defined in w32.c.
6188 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6189 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6190
0898ca10
JB
61912011-05-04 Juanma Barranquero <lekktu@gmail.com>
6192
6193 Implement dynamic loading of GnuTLS on Windows.
6194
6195 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6196 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6197 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6198 Declare.
6199
6200 * gnutls.c (Qgnutls_dll): Define.
6201 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6202 (gnutls_*): Declare function pointers.
6203 (init_gnutls_functions): New function to initialize function pointers.
6204 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6205 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6206 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6207 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6208 (emacs_gnutls_write, emacs_gnutls_read)
6209 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6210 (Fgnutls_available_p): New function.
6211 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6212 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6213 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6214
6215 * image.c: Include w32.h.
6216 (Vimage_type_cache): Delete.
6217 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6218 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6219 (w32_delayed_load): Move to w32.c.
6220
6221 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6222
6223 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6224 (w32_delayed_load): Move from image.c. When loading a library, record
6225 its filename in the :loaded-from property of the library id.
6226 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6227 Initialize and staticpro them.
6228 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6229
6230 * process.c: Include lisp.h before w32.h, not after.
6231 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6232 instead of gnutls_record_check_pending.
6233
6234 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6235
ff4de4aa
TZ
62362011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6237
6238 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6239 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6240 as passed in.
6241
abe95abb
JD
62422011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6243
6244 * xterm.c (x_set_frame_alpha): Do not set property on anything
6245 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6246
e16e55d4
JB
62472011-05-02 Juanma Barranquero <lekktu@gmail.com>
6248
6249 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6250
bafcf6a5
JB
62512011-05-02 Juanma Barranquero <lekktu@gmail.com>
6252
6253 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6254 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6255 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6256 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6257 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6258 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6259 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6260 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6261 (Qgnutls_bootprop_callbacks_verify): Make static.
6262
e7a6747f
AS
62632011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6264
19ed11ba
AS
6265 * callproc.c: Indentation fixup.
6266
e7a6747f 6267 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6268 (wait_for_termination, interruptible_wait_for_termination):
6269 Move after wait_for_termination_1.
e7a6747f 6270
1ef14cb4
LMI
62712011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6272
6273 * sysdep.c (interruptible_wait_for_termination): New function
6274 which is like wait_for_termination, but allows keyboard
6275 interruptions.
6276
6277 * callproc.c (Fcall_process): Add (:file "file") as an option for
6278 the STDOUT buffer.
6279 (Fcall_process_region): Ditto.
6280
330d880c
EZ
62812011-04-30 Eli Zaretskii <eliz@gnu.org>
6282
8db90b73
EZ
6283 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6284 rather than `XVECTOR (FOO)->size'.
6285
330d880c
EZ
6286 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6287 inttypes.h, as a gnulib replacement is used if it not available in
6288 system headers.
6289
15cbd324
EZ
62902011-04-21 Eli Zaretskii <eliz@gnu.org>
6291
6292 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6293 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6294 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6295
6296 * coding.c (coding_alloc_by_realloc): Error out if destination
6297 will grow beyond MOST_POSITIVE_FIXNUM.
6298 (decode_coding_emacs_mule): Abort if there isn't enough place in
6299 charbuf for the composition carryover bytes. Reserve an extra
6300 space for up to 2 characters produced in a loop.
6301 (decode_coding_iso_2022): Abort if there isn't enough place in
6302 charbuf for the composition carryover bytes.
6303
63042011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6305
ae940cca
EZ
6306 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6307 aborting when %lld or %lll format is passed.
6308 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6309 %llo or %llx format is passed. (Bug#8545)
6310
03ab8921
EZ
6311 * window.c (window_scroll_line_based): Use a marker instead of
6312 simple variables to record original value of point. (Bug#7952)
6313
afda1437
EZ
6314 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6315 produced by %s or %c overflows available buffer space. (Bug#8545)
6316
f76dee0c
PE
63172011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6318
6319 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6320 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6321
fdc5744d
JB
63222011-04-28 Juanma Barranquero <lekktu@gmail.com>
6323
6324 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6325
638f053a
JB
63262011-04-28 Juanma Barranquero <lekktu@gmail.com>
6327
6328 * keyboard.c (Qdelayed_warnings_hook): Define.
6329 (command_loop_1): Run `delayed-warnings-hook'
6330 if Vdelayed_warnings_list is non-nil.
6331 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6332 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6333
d178f871
EZ
63342011-04-28 Eli Zaretskii <eliz@gnu.org>
6335
6336 * doprnt.c (doprnt): Don't return value smaller than the buffer
6337 size if the message was truncated. (Bug#8545).
6338
b124fd93
JB
63392011-04-28 Juanma Barranquero <lekktu@gmail.com>
6340
6341 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6342 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6343
e810457d
PE
63442011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6345
6346 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6347
ea51cceb
JB
63482011-04-27 Juanma Barranquero <lekktu@gmail.com>
6349
6350 * makefile.w32-in: Update dependencies.
6351
94dcfacf
EZ
63522011-04-27 Eli Zaretskii <eliz@gnu.org>
6353
6354 Improve `doprnt' and its usage. (Bug#8545)
6355 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6356 `format_end'. Remove support for %l as a conversion specifier.
6357 Don't use xrealloc. Improve diagnostics when the %l size modifier
6358 is used. Update the commentary.
6359
6360 * eval.c (verror): Simplify calculation of size_t.
6361
6362 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6363 messages.
6364
f61f41d7
PE
63652011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6366
6367 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6368 change.
6369
96fb4434
PE
63702011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6371
6372 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6373 This makes this file independent of the recent pseudovector change.
6374
671875da 63752011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6376
69e9b5a3
PE
6377 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6378
b5f869a7 6379 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6380 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6381 Remove unused local.
c8926152 6382 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6383
841a1577 6384 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6385 GCC 4.6.0 optimizes based on type-based alias analysis.
6386 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6387 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6388 != &v->size, and therefore "v->size = 1; b->size = 2; return
6389 v->size;" must therefore return 1. This assumption is incorrect
6390 for Emacs, since it type-puns struct Lisp_Vector * with many other
6391 types. To fix this problem, this patch adds a new type struct
f904488f 6392 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6393 and pseudovectors, and helps optimizing compilers not get fooled
6394 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6395 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6396 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6397 the size member.
eab3844f
PE
6398 (XSETPVECTYPE): Rewrite in terms of new macro.
6399 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6400 This is a bit clearer, and further avoids the possibility of
6401 undesirable aliasing.
6402 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6403 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6404 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6405 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6406 (ASIZE): Now uses header.size rather than size.
6407 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6408 to avoid the hassle of writing XVECTOR (foo)->header.size.
6409 (struct vectorlike_header): New type.
eab3844f
PE
6410 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6411 object, to help avoid aliasing.
6412 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6413 (SUBRP): Likewise, since Lisp_Subr is a special case.
6414 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6415 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6416 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6417 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6418 changed to be "header.size" and "header.next".
6419 * buffer.h (struct buffer): Likewise.
6420 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6421 * frame.h (struct frame): Likewise.
6422 * process.h (struct Lisp_Process): Likewise.
6423 * termhooks.h (struct terminal): Likewise.
6424 * window.c (struct save_window_data, struct saved_window): Likewise.
6425 * window.h (struct window): Likewise.
6426 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6427 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6428 * buffer.c (init_buffer_once): Likewise.
6429 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6430 special case.
6431 * process.c (Fformat_network_address): Use local var for size,
6432 for brevity.
6433
0df1eac5
PE
6434 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6435
847ab9d1 6436 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6437 * data.c (atof): Remove decl; no longer used or needed.
6438 (digit_to_number): Move to lread.c.
6439 (Fstring_to_number): Use new string_to_number function, to be
6440 consistent with how the Lisp reader treats infinities and NaNs.
6441 Do not assume that floating-point numbers represent EMACS_INT
6442 without losing information; this is not true on most 64-bit hosts.
6443 Avoid double-rounding errors, by insisting on integers when
6444 parsing non-base-10 numbers, as the documentation specifies.
6445 * lisp.h (string_to_number): New decl, replacing ...
6446 (isfloat_string): Remove.
bc0a5c13 6447 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6448 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6449 appears to have been a coding error. Similarly, do not accept
6450 strings like +-1e0 as floating point numbers. Do not report
6451 overflow for integer overflows unless the base is not 10 which
6452 means we have no simple and reliable way to continue.
6453 Break out the floating-point parsing into a new
6454 function string_to_number, so that Fstring_to_number parses
6455 floating point numbers consistently with the Lisp reader.
04f2d78b 6456 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6457 (E_CHAR, EXP_INT): Remove, replacing with ...
6458 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6459 (string_to_number): New function, replacing isfloat_string.
6460 This function checks for valid syntax and produces the resulting
6461 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6462 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6463 so that overflow for non-base-10 numbers is reported only when
6464 there's no portable and simple way to convert to floating point.
452f4150 6465
67769ffc
PE
6466 * textprop.c (set_text_properties_1): Rewrite for clarity,
6467 and to avoid GCC warning about integer overflow.
6468
c20db43f
PE
6469 * intervals.h (struct interval): Use EMACS_INT for members
6470 where EMACS_UINT might cause problems. See
6471 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6472 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6473 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6474 All uses changed.
37aa2f85
PE
6475 (offset_intervals): Tell GCC not to worry about length overflow
6476 when negating a negative length.
c20db43f 6477
2538aa2f
PE
6478 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6479 (overrun_check_free): Likewise.
6480
f2d3008d
PE
6481 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6482 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6483 word size.
6484
ec8df744
PE
6485 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6486 (gnutls_make_error): Rename local to avoid shadowing.
6487 (gnutls_emacs_global_deinit): ifdef out; not used.
6488 (Fgnutls_boot): Use const for pointer to readonly storage.
6489 Comment out unused local. Fix pointer signedness problems.
6490
640ee02d
PE
6491 * lread.c (openp): Don't stuff size_t into an 'int'.
6492 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6493 about possible signed overflow.
6494
6048fb2a
PE
6495 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6496 (GDK_KEY_g): Don't define if already defined.
6497 (xg_prepare_tooltip): Avoid pointer signedness problem.
6498 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6499
fa3c87e1
PE
6500 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6501 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6502
2172544b
PE
6503 * xfns.c (Fx_window_property): Simplify a bit,
6504 to make a bit faster and to avoid GCC 4.6.0 warning.
6505 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6506
9b821a21
PE
6507 * fns.c (internal_equal): Don't assume size_t fits in int.
6508
3c616cfa
PE
6509 * alloc.c (compact_small_strings): Tighten assertion a little.
6510
c2982e87
PE
6511 Replace pEd with more-general pI, and fix some printf arg casts.
6512 * lisp.h (pI): New macro, generalizing old pEd macro to other
6513 conversion specifiers. For example, use "...%"pI"d..." rather
6514 than "...%"pEd"...".
6515 (pEd): Remove. All uses replaced with similar uses of pI.
6516 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6517 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6518 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6519 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6520 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6521 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6522 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6523 64-bit hosts.
6524 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6525 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6526 * print.c (safe_debug_print, print_object): Likewise.
6527 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6528 to int.
6f04d126
PE
6529 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6530 avoiding the 0 flag, which is not portable.
c2982e87
PE
6531 * process.c (Fmake_network_process): Use pI to avoid cast.
6532 * region-cache.c (pp_cache): Likewise.
6533 * xdisp.c (decode_mode_spec): Likewise.
6534 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6535 behavior on 64-bit hosts with printf arg.
6f04d126 6536 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6537 (x_stop_queuing_selection_requests): Likewise.
6538 (x_get_window_property): Don't truncate byte count to an 'int'
6539 when tracing.
0b432f21 6540
5e073ec7
PE
6541 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6542 here, since it parses constructs like leading '-' and spaces,
6543 which are not wanted; and it overflows with large numbers.
6544 Instead, simply match F[0-9]+, which is what is wanted anyway.
6545
36372bf9
PE
6546 * alloc.c: Remove unportable assumptions about struct layout.
6547 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6548 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6549 (allocate_vectorlike, make_pure_vector): Use the new macros,
6550 plus offsetof, to remove unportable assumptions about struct layout.
6551 These assumptions hold on all porting targets that I know of, but
6552 they are not guaranteed, they're easy to remove, and removing them
6553 makes further changes easier.
6554
0b432f21
PE
6555 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6556 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6557 (string_overrun_cookie): Now const. Use initializers that
6558 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6559 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6560 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6561 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6562 multiple of sizeof (EMACS_INT); it need not be, if
6563 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6564 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6565
895009e1
JB
65662011-04-26 Juanma Barranquero <lekktu@gmail.com>
6567
6568 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6569
6a7a1b0b
TZ
65702011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6571
6572 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6573 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6574 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6575
841a1577 65762011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6577
6578 * lisp.h (Qdebug): List symbol.
895009e1 6579 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6580 * keyboard.c (debug-on-event): New variable.
6581 (handle_user_signal): Break into debugger when debug-on-event
6582 matches the current signal symbol.
6583
f2d3ba6f
DN
65842011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6585
6586 * alloc.c (check_sblock, check_string_bytes)
6587 (check_string_free_list): Convert to standard C.
6588
42ce4c63
TZ
65892011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6590
6591 * w32.c (emacs_gnutls_push): Fix typo.
6592
825cd63c
EZ
65932011-04-25 Eli Zaretskii <eliz@gnu.org>
6594
fb11d64d
EZ
6595 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6596 "cast to pointer from integer of different size".
6597
825cd63c
EZ
6598 Improve doprnt and its use in verror. (Bug#8545)
6599 * doprnt.c (doprnt): Document the set of format control sequences
6600 supported by the function. Use SAFE_ALLOCA instead of always
6601 using `alloca'.
6602
6603 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6604 is one byte too soon. Don't use xrealloc; instead xfree and
6605 xmalloc anew.
6606
e061a11b
TZ
66072011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6608
6609 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6610 callbacks stage.
6611
6612 * gnutls.c: Renamed global_initialized to
6613 gnutls_global_initialized. Added internals for the
6614 :verify-hostname-error, :verify-error, and :verify-flags
6615 parameters of `gnutls-boot' and documented those parameters in the
6616 docstring. Start callback support.
9173deec
JB
6617 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6618 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6619 on error. Return error code.
e061a11b
TZ
6620 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6621 (emacs_gnutls_read): Likewise.
6622 (Fgnutls_boot): Return handshake error code.
6623 (emacs_gnutls_handle_error): New function.
6624 (wsaerror_to_errno): Likewise.
6625
6626 * w32.h (emacs_gnutls_pull): Add prototype.
6627 (emacs_gnutls_push): Likewise.
6628
6629 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6630 (emacs_gnutls_push): Likewise.
6631
66322011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6633
6634 * process.c (wait_reading_process_output): Check if GnuTLS
6635 buffered some data internally if no FDs are set for TLS
6636 connections.
6637
6638 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6639 (LIBS): Link to USER_LIBS.
6640 ($(BLD)/gnutls.$(0)): New target.
6641
fa6996bc
EZ
66422011-04-24 Eli Zaretskii <eliz@gnu.org>
6643
eb35682e
EZ
6644 * xdisp.c (handle_single_display_spec): Rename the
6645 display_replaced_before_p argument into display_replaced_p, to
6646 make it consistent with the commentary. Fix typos in the
6647 commentary.
6648
e2ad650c
EZ
6649 * textprop.c (syms_of_textprop): Remove dead code.
6650 (copy_text_properties): Delete obsolete commentary about an
6651 interface that was deleted long ago. Fix typos in the description
6652 of arguments.
6653
1b2de274
EZ
6654 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6655 to changes in oldXMenu/XMenu.h from 2011-04-16.
6656 <menu_help_message, prev_menu_help_message>: Constify.
6657 (IT_menu_make_room): menu->help_text is now `const char **';
6658 adjust.
6659
6660 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6661 to changes in oldXMenu/XMenu.h from 2011-04-16.
6662 (struct XMenu): Declare `help_text' `const char **'.
6663
6664 * xfaces.c <Qunspecified>: Make extern again.
6665
6666 * syntax.c: Include sys/types.h before including regex.h, as
6667 required by Posix.
6668
762b15be
EZ
6669 * doc.c (get_doc_string): Improve the format passed to `error'.
6670
6671 * doprnt.c (doprnt): Improve commentary.
6672
6673 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6674
6675 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6676 them with etags.
6677
f1052e5d
EZ
6678 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6679 changes in globals.h immediately force recompilation.
762b15be
EZ
6680 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6681 $(CURDIR)/s/ms-w32.h.
6682 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6683
fa6996bc
EZ
6684 * character.c (Fchar_direction): Function deleted.
6685 (syms_of_character): Don't defsubr it.
6686 <char-direction-table>: Deleted.
6687
e6c3da20
EZ
66882011-04-23 Eli Zaretskii <eliz@gnu.org>
6689
6690 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6691 * doprnt.c: Include limits.h.
6692 (SIZE_MAX): New macro.
04f2d78b
CB
6693 (doprnt): Return a size_t value. 2nd arg is now size_t.
6694 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6695 Improve overflow protection. Support `l' modifier for integer
6696 conversions. Support %l conversion. Don't assume an EMACS_INT
6697 argument for integer conversions and for %c.
6698
6699 * lisp.h (doprnt): Restore prototype.
6700
6701 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6702 $(SRC)/character.h.
6703
6704 * Makefile.in (base_obj): Add back doprnt.o.
6705
6706 * deps.mk (doprnt.o): Add back prerequisites.
6707 (callint.o): Depend on character.h.
6708
6709 * eval.c (internal_lisp_condition_case): Include the handler
6710 representation in the error message.
6711 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6712 when breaking from the loop.
6713
6714 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6715
6716 * callint.c (Fcall_interactively): When displaying error message
6717 about invalid control letter, pass the character's codepoint, not
6718 a pointer to its multibyte form. Improve display of the character
6719 in octal and display also its hex code.
6720
6721 * character.c (char_string): Use %x to display the (unsigned)
6722 codepoint of an invalid character, to avoid displaying a bogus
6723 negative value.
6724
6725 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6726 `error', not SYMBOL_NAME itself.
6727
6728 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6729 character arguments to `error'.
6730
6731 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6732 to `error' in error message about FINAL_CHAR argument. Make sure
6733 FINAL_CHAR is a character, and use %c when it is passed as
6734 argument to `error'.
6735
4ffd0d6b 67362011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6737
6738 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6739
6740 * w32.c: Include <time.h>.
6741 (sys_localtime): New function.
6742
4ffd0d6b 67432011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6744
6745 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6746
4ffd0d6b 6747 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6748
4ffd0d6b 67492011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6750
4ffd0d6b
GM
6751 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6752 zombies (Bug#8467).
aac0c6e3 6753
04c56954
EZ
67542011-04-19 Eli Zaretskii <eliz@gnu.org>
6755
6756 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6757 gl_state.e_property when gl_state.object is Qt.
6758
6759 * insdel.c (make_gap_larger): Remove limitation of buffer size
6760 to <= INT_MAX.
6761
16a43933
CY
67622011-04-18 Chong Yidong <cyd@stupidchicken.com>
6763
6764 * xdisp.c (lookup_glyphless_char_display)
6765 (produce_glyphless_glyph): Handle cons cell entry in
6766 glyphless-char-display.
6767 (Vglyphless_char_display): Document it.
6768
6769 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6770 glyphless-char-display.
6771
4581706e
CY
67722011-04-17 Chong Yidong <cyd@stupidchicken.com>
6773
6774 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6775
6776 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6777
6778 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6779 definition for no-X builds.
6780
4887c6e2 67812011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6782
fd35b6f9
PE
6783 Static checks with GCC 4.6.0 and non-default toolkits.
6784
5c1ccb01
PE
6785 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6786
006c5daa
PE
6787 * process.c (keyboard_bit_set): Define only if SIGIO.
6788 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6789 (send_process): Repair possible setjmp clobbering.
6790
efc736d3
PE
6791 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6792
4e2fe2e6
PE
6793 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6794
f97334a2
PE
6795 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6796
4e75f29d
PE
6797 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6798 Define only if needed.
6799
90efadd1
PE
6800 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6801 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6802 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6803
3c647824
PE
6804 * dispextern.h (struct redisplay_interface): Rename param
6805 to avoid shadowing.
e264f262 6806 * termhooks.h (struct terminal): Likewise.
761383f4 6807 * xterm.c (xembed_send_message): Likewise.
3c647824 6808
b58c5c4a
PE
6809 * insdel.c (make_gap_smaller): Define only if
6810 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6811
cad59032
PE
6812 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6813 it.
6814
c339dc2e
PE
6815 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6816 so that we aren't warned about unused symbols.
6817
91a3e27b
PE
6818 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6819
399c71d3 6820 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6821
8ffc96f5
PE
6822 * xfns.c (x_real_positions): Mark locals as initialized.
6823
eef9bc79
PE
6824 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6825
098db9dd
PE
6826 * xterm.c: Fix problems found by static analysis with other toolkits.
6827 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6828 (x_dispatch_event): Declare static if USE_GTK, and
6829 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6830 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6831 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6832 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6833 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6834
eb18f6cc
PE
6835 * xmenu.c (menu_help_callback): Pointer type fixes.
6836 Use const pointers when pointing at readonly data. Avoid pointer
6837 signedness clashes.
6838 (FALSE): Remove unused macro.
6839 (update_frame_menubar): Remove unused decl.
6840
1fe72bf8
PE
6841 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6842
60d9e1db
PE
6843 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6844 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6845 (single_menu_item): Rename local to avoid shadowing.
6846
39261c26
PE
6847 * keyboard.c (make_lispy_event): Remove unused local var.
6848
018c5e19
PE
6849 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6850 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6851
63d2b86e
PE
6852 * bitmaps: Change bitmaps from unsigned char back to the X11
6853 compatible char. Avoid the old compiler warnings about
6854 out-of-range initializers by using, for example, '\xab' rather
6855 than 0xab.
6856
aefd87e1
PE
6857 * xgselect.c (xgselect_initialize): Check vs interface
6858 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6859
bf501fb9
PE
6860 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6861
e9829fdf
PE
6862 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6863 to read-only memory.
6864
1086c095
PE
6865 * fns.c (vector): Remove; this old hack is no longer needed.
6866
2baccd04 6867 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6868 Remove unused var.
dde42981 6869 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6870
72391843 6871 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6872
436c16df 6873 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6874 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6875 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6876
92bb796d 6877 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6878 (x_term_init): Remove local to avoid shadowing.
92bb796d 6879
764430a3 6880 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6881
6882 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6883 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6884
d1dfb56c
EZ
68852011-04-16 Eli Zaretskii <eliz@gnu.org>
6886
c4354cb4
EZ
6887 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6888
d1dfb56c
EZ
6889 Fix regex.c, syntax.c and friends for buffers > 2GB.
6890 * syntax.h (struct gl_state_s): Declare character position members
6891 EMACS_INT.
6892
6893 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6894
04f2d78b
CB
6895 * textprop.c (verify_interval_modification, interval_of):
6896 Declare arguments EMACS_INT.
d1dfb56c
EZ
6897
6898 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6899 EMACS_INT.
6900
6901 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6902
6903 * indent.c (Fvertical_motion): Local variable it_start is now
6904 EMACS_INT.
6905
6906 * regex.c (re_match, re_match_2, re_match_2_internal)
6907 (bcmp_translate, regcomp, regexec, print_double_string)
6908 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6909 (re_compile_pattern, re_exec): Declare arguments and local
6910 variables `size_t' and `ssize_t' and return values `regoff_t', as
6911 appropriate.
6912 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6913 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6914 <compile_stack_type>: `size' and `avail' are now `size_t'.
6915
6916 * regex.h <regoff_t>: Use ssize_t, not int.
6917 (re_search, re_search_2, re_match, re_match_2): Arguments that
6918 specify buffer/string position and length are now ssize_t and
6919 size_t. Return type is regoff_t.
6920
613052cd
BK
69212011-04-16 Ben Key <bkey76@gmail.com>
6922
6923 * nsfont.m: Fixed bugs in ns_get_family and
6924 ns_descriptor_to_entity that were caused by using free to
6925 deallocate memory blocks that were allocated by xmalloc (via
6926 xstrdup). This caused Emacs to crash when compiled with
6927 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6928 --enable-checking=xmallocoverrun). xfree is now used to
6929 deallocate these memory blocks.
6930
4170f62f 69312011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6932
71b41406
PE
6933 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6934
9587a89d
PE
6935 emacs_write: Accept and return EMACS_INT for sizes.
6936 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6937 et seq.
6938 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6939 Accept and return EMACS_INT.
6940 (emacs_gnutls_write): Return the number of bytes written on
6941 partial writes.
6942 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6943 (emacs_read, emacs_write): Remove check for negative size, as the
6944 Emacs source code has been audited now.
9587a89d
PE
6945 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6946 (emacs_read, emacs_write): Use it.
273a5f82
PE
6947 * process.c (send_process): Adjust to the new signatures of
6948 emacs_write and emacs_gnutls_write. Do not attempt to store
6949 a byte offset into an 'int'; it might overflow.
9587a89d 6950 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6951
3e047f51
PE
6952 * sound.c: Don't assume sizes fit in 'int'.
6953 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6954 Return EMACS_INT, not int.
3e047f51 6955 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6956 Accept EMACS_INT, not int.
6957 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6958 record read return values.
6959
cc39a9db
BK
69602011-04-15 Ben Key <bkey76@gmail.com>
6961
c9d0ec6d
JB
6962 * keyboard.c (Qundefined): Don't declare static since it is used
6963 in nsfns.m.
6964 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6965 static since they are used in nsfont.m.
cc39a9db 6966
6c60eb9f
SM
69672011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6968
6969 * process.c (Qprocessp): Don't declare static.
6970 * lisp.h (Qprocessp): Declare again.
6971
7990b61a
JB
69722011-04-15 Juanma Barranquero <lekktu@gmail.com>
6973
6974 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6975
5d4cb038
PE
69762011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6977
8bd7b830 6978 Improve C-level modularity by making more things 'static'.
cd64ea1d 6979
e3b27b31
PE
6980 Don't publish debugger-only interfaces to other modules.
6981 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6982 (verify_bytepos, count_markers): Move decls to the only modules
6983 that need them.
6984 * region-cache.h (pp_cache): Likewise.
6985 * window.h (check_all_windows): Likewise.
6986 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6987
5d4cb038
PE
6988 * sysdep.c (croak): Now static, if
6989 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6990 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6991
6992 * alloc.c (refill_memory_reserve): Now static if
6993 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6994 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6995
e87b6180
PE
6996 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6997 Define only if USE_LUCID.
6998
ac64929e
PE
6999 * xrdb.c (x_customization_string, x_rm_string): Now static.
7000
6f37259d
PE
7001 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7002 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7003
1683e3ab
PE
7004 * xdisp.c (draw_row_with_mouse_face): Now static.
7005 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7006
de9c2632
PE
7007 * window.h (check_all_windows): Mark externally visible.
7008
2b96acb7
PE
7009 * window.c (window_deletion_count): Now static.
7010
7011 * undo.c: Make symbols static if they're not exported.
7012 (last_undo_buffer, last_boundary_position, pending_boundary):
7013 Now static.
7014
50436f33
PE
7015 * textprop.c (interval_insert_behind_hooks): Now static.
7016 (interval_insert_in_front_hooks): Likewise.
7017
64520e5c
PE
7018 * term.c: Make symbols static if they're not exported.
7019 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7020 (max_frame_lines, tty_set_terminal_modes):
7021 (tty_reset_terminal_modes, tty_turn_off_highlight):
7022 (get_tty_terminal): Now static.
7023 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7024 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7025 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7026 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7027 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7028
1fa53021
PE
7029 * sysdep.c: Make symbols static if they're not exported.
7030 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7031 Now static.
7032 (sigprocmask_set, full_mask): Remove; unused.
7033 (wait_debugging): Mark as visible.
7034 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7035 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7036
d4b43b22
PE
7037 * syntax.c (syntax_temp): Define only if !__GNUC__.
7038
b7c513d0
PE
7039 * sound.c (current_sound_device, current_sound): Now static.
7040
989b29ad
PE
7041 * search.c (searchbufs, searchbuf_head): Now static.
7042
13a55a78
PE
7043 * scroll.c (scroll_cost): Remove; unused.
7044 * dispextern.h (scroll_cost): Remove decl.
7045
de68a1fc
PE
7046 * region-cache.h (pp_cache): Mark as externally visible.
7047
40ccffa6
PE
7048 * process.c: Make symbols static if they're not exported.
7049 (process_tick, update_tick, create_process, chan_process):
7050 (Vprocess_alist, proc_buffered_char, datagram_access):
7051 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7052 (deactivate_process): Mark defn as static, as well as decl.
7053 * lisp.h (create_process): Remove decl.
7054 * process.h (chan_process, Vprocess_alist): Remove decls.
7055
ad64fc97
PE
7056 * print.c: Make symbols static if they're not exported.
7057 (print_depth, new_backquote_output, being_printed, print_buffer):
7058 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7059 (print_interval, print_number_index, initial_stderr_stream):
7060 Now static.
7061 * lisp.h (Fprinc): Remove decl.
7062 (debug_output_compilation_hack): Mark as externally visible.
7063
adddb265
PE
7064 * sysdep.c (croak): Move decl from here to syssignal.h.
7065 * syssignal.h (croak): Put it here, so the API can be checked when
7066 'croak' is called from dissociate_if_controlling_tty.
7067
1717ede2
PE
7068 * minibuf.c: Make symbols static if they're not exported.
7069 (minibuf_save_list, choose_minibuf_frame): Now static.
7070 * lisp.h (choose_minibuf_frame): Remove decl.
7071
fa5fb2bc
PE
7072 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7073
1e3890d1
PE
7074 * lread.c: Make symbols static if they're not exported.
7075 (read_objects, initial_obarray, oblookup_last_bucket_number):
7076 Now static.
7077 (make_symbol): Remove; unused.
7078 * lisp.h (initial_obarray, make_symbol): Remove decls.
7079
8a1414fa
PE
7080 * keyboard.c: Make symbols static if they're not exported.
7081 (single_kboard, recent_keys_index, total_keys, recent_keys):
7082 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7083 (this_single_command_key_start, echoing, last_auto_save):
7084 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7085 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7086 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7087 (Vlispy_mouse_stem, double_click_count):
7088 Now static.
7089 (force_auto_save_soon): Define only if SIGDANGER.
7090 (ignore_mouse_drag_p): Now static if
7091 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7092 (print_help): Remove; unused.
7093 (stop_character, last_timer_event): Mark as externally visible.
7094 * keyboard.h (ignore_mouse_drag_p): Declare only if
7095 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7096 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7097 * lisp.h (echoing): Remove decl.
7098 (force_auto_save_soon): Declare only if SIGDANGER.
7099 * xdisp.c (redisplay_window): Simplify code, to make it more
7100 obvious that ignore_mouse_drag_p is not accessed if !defined
7101 USE_GTK && !defined HAVE_NS.
7102
93ea6e8f
PE
7103 * intervals.c: Make symbols static if they're not exported.
7104 (merge_properties_sticky, merge_interval_right, delete_interval):
7105 Now static.
7106 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7107
77382fcc
PE
7108 * insdel.c: Make symbols static if they're not exported.
7109 However, leave prepare_to_modify_buffer alone. It's never
7110 called from outside this function, but that appears to be a bug.
7111 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7112 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7113 (adjust_after_replace_noundo): Remove; unused.
7114 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7115 (signal_before_change): Remove decls.
77382fcc 7116
9306c32e
PE
7117 * indent.c (val_compute_motion, val_vmotion): Now static.
7118
cd44d2eb
PE
7119 * image.c: Make symbols static if they're not exported.
7120 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7121 if USE_GTK.
7122 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7123 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7124
ad9a7a06
PE
7125 * fringe.c (standard_bitmaps): Now static.
7126 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7127
81626931
PE
7128 * frame.c: Make symbols static if they're not exported.
7129 (x_report_frame_params, make_terminal_frame): Now static.
7130 (get_frame_param): Now static, unless HAVE_NS.
7131 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7132 (x_get_resource_string): Remove; not used.
7133 * frame.h (make_terminal_frame, x_report_frame_params):
7134 (x_get_resource_string); Remove decls.
7135 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7136 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7137
239f9db9
PE
7138 * font.c, fontset.c: Make symbols static if they're not exported.
7139 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7140 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7141 * font.c (font_close_object): Now static.
7142 * font.h (font_close_object): Remove.
7143 * fontset.c (FONTSET_OBJLIST): Remove.
7144 (free_realized_fontset) #if-0 the body, which does nothing.
7145 (face_suitable_for_char_p): #if-0, as it's never called.
7146 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7147 * xfaces.c (face_at_string_position):
7148 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7149 since 0 is always ASCII.
7150
dfcf3579
PE
7151 * fns.c (weak_hash_tables): Now static.
7152
5045092b
PE
7153 * fileio.c: Make symbols static if they're not exported.
7154 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7155 (Vwrite_region_annotation_buffers): Now static.
7156
57a96f5c
PE
7157 * eval.c: Make symbols static if they're not exported.
7158 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7159 * lisp.h (backtrace_list): Remove decl.
7160
35f08c38
PE
7161 * emacs.c: Make symbols static if they're not exported.
7162 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7163 (fatal_error_code, fatal_error_signal_hook, standard_args):
7164 Now static.
7165 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7166 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7167 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7168 * lisp.h (fatal_error_signal_hook): Remove decl.
7169 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7170
f44bd759
PE
7171 * editfns.c: Move a (normally-unused) function to its only use.
7172 * editfns.c, lisp.h (get_operating_system_release): Remove.
7173 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7174 worth the hassle of breaking this out.
7175
b532497d
PE
7176 * xterm.c: Make symbols static if they're not exported.
7177 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7178 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7179 (x_destroy_window, x_delete_display):
7180 Now static.
7181 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7182 (x_mouse_leave): Remove; unused.
7183 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7184 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7185 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7186 Remove decls.
7187 (x_mouse_leave): Declare only if WINDOWSNT.
7188 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7189 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7190 USE_X_TOOLKIT.
7191
1675728f
PE
7192 * ftxfont.c: Make symbols static if they're not exported.
7193 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7194 HAVE_FREETYPE.
7195 * font.h (ftxfont_driver): Likewise.
7196
e4cebfca
PE
7197 * xfns.c: Make symbols static if they're not exported.
7198 (x_last_font_name, x_display_info_for_name):
7199 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7200 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7201 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7202 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7203 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7204 (last_show_tip_args): Now static.
7205 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7206 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7207 (x_screen_planes): Remove; unused.
7208 * dispextern.h (x_screen_planes): Remove decl.
7209
5bf46f05
PE
7210 * dispnew.c: Make symbols static if they're not exported.
7211 * dispextern.h (redraw_garbaged_frames, scrolling):
7212 (increment_row_positions): Remove.
7213 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7214 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7215 Now static.
7216 (redraw_garbaged_frames): Remove; unused.
7217
435f4c28
PE
7218 * xfaces.c: Make symbols static if they're not exported.
7219 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7220 Remove decls.
7221 * xterm.h (defined_color): Remove decls.
7222 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7223 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7224 (menu_face_changed_default, defined_color, free_realized_face):
7225 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7226 (ascii_face_of_lisp_face): Remove; unused.
7227
8524aef3
PE
7228 * xdisp.c: Make symbols static if they're not exported.
7229 * dispextern.h (scratch_glyph_row, window_box_edges):
7230 (glyph_to_pixel_coords, set_cursor_from_row):
7231 (get_next_display_element, set_iterator_to_next):
7232 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7233 (show_mouse_face): Remove decls
7234 * frame.h (message_buf_print): Likewise.
7235 * lisp.h (pop_message, set_message, check_point_in_composition):
7236 Likewise.
7237 * xterm.h (set_vertical_scroll_bar): Likewise.
7238 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7239 (message_buf_print, scratch_glyph_row, displayed_buffer):
7240 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7241 (get_next_display_element, show_mouse_face, window_box_edges):
7242 (frame_to_window_pixel_xy, check_point_in_composition):
7243 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7244 (glyph_to_pixel_coords): Remove; unused.
7245
16390cd2
PE
7246 * dired.c (file_name_completion): Now static.
7247
7248 * dbusbind.c (xd_in_read_queued_messages): Now static.
7249
a25f4dfa
PE
7250 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7251 * data.c (circular_list_error): Remove.
7252
14a9c8df
PE
7253 * commands.h (last_point_position, last_point_position_buffer):
7254 (last_point_position_window): Remove decls.
7255 * keyboard.c: Make these variables static.
7256
04f2d78b
CB
7257 * coding.h (coding, code_convert_region, encode_coding_gap):
7258 Remove decls.
74ab6df5
PE
7259 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7260 (iso_code_class, detect_coding, code_convert_region): Now static.
7261 (encode_coding_gap): Remove; unused.
7262
38dfbee1
PE
7263 * chartab.c (chartab_chars, chartab_bits): Now static.
7264
a2cb4e63
PE
7265 * charset.h (charset_iso_8859_1): Remove decl.
7266 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7267 Now static.
7268
127198fd
PE
7269 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7270 * ccl.c (Vccl_program_table): Now static.
7271 (check_ccl_update): Remove; unused.
7272
d85b608f
PE
7273 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7274 * category.h: ... from here.
7275 * category.c (check_category_table, set_category_set): Now static.
7276
31cd66f3
PE
7277 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7278 * lisp.h: Remove these decls.
7279
c358e587
PE
7280 * buffer.c (buffer_count): Remove unused var.
7281
e78aecca
PE
7282 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7283 so that it's not optimized away.
7284 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7285 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7286 exported only to the debugger.
7287
e192d7d3 7288 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7289 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7290
92470028
PE
7291 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7292 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7293 was inaccessible from Lisp.
7294 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7295 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7296
244ed907
PE
7297 alloc.c: Import and export fewer symbols, and remove unused items.
7298 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7299 is defined.
7300 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7301 it's not optimized away by whole-program optimization.
7302 (message_enable_multibyte, free_misc): Remove.
7303 (catchlist, handlerlist, mark_backtrace):
7304 Declare only if BYTE_MARK_STACK.
7305 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7306 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7307 (message_enable_multibyte): Remove decl.
7308 (free_misc, interval_free_list, float_block, float_block_index):
7309 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7310 (cons_free_list, last_marked_index):
7311 Now static.
7312 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7313 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7314 (mark_backtrace): Define only if BYTE_MARK_STACK.
7315 * xdisp.c (message_enable_multibyte): Now static.
7316
61c2b50e 7317 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7318 This makes it easier for human readers (and static analyzers)
7319 to see whether these variables are used from other modules.
7320 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7321 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7322 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7323 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7324 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7325 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7326 * xmenu.c, xselect.c:
7327 Declare Q* vars static if they are not used in other modules.
7328 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7329 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7330 Remove decls of unexported vars.
7331 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7332
95c82688
PE
7333 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7334
16a97296
PE
7335 Make Emacs functions such as Fatom 'static' by default.
7336 This makes it easier for human readers (and static analyzers)
7337 to see whether these functions can be called from other modules.
7338 DEFUN now defines a static function. To make the function external
7339 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7340 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7341 (Finit_image_library):
16a97296
PE
7342 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7343 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7344 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7345 Remove decls, since these functions are now static.
7346 (Funintern, Fget_internal_run_time): New decls, since these functions
7347 were already external.
95c82688 7348
16a97296
PE
7349 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7350 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7351 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7352 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7353 * keyboard.c, keymap.c, lread.c:
7354 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7355 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7356 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7357 Mark functions with DEFUE instead of DEFUN,
7358 if they are used in other modules.
7359 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7360 decls for now-static functions.
7361 * buffer.h (Fdelete_overlay): Remove decl.
7362 * callproc.c (Fgetenv_internal): Mark as internal.
7363 * composite.c (Fremove_list_of_text_properties): Remove decl.
7364 (Fcomposition_get_gstring): New forward static decl.
7365 * composite.h (Fcomposite_get_gstring): Remove decl.
7366 * dired.c (Ffile_attributes): New forward static decl.
7367 * doc.c (Fdocumntation_property): New forward static decl.
7368 * eval.c (Ffetch_bytecode): New forward static decl.
7369 (Funintern): Remove extern decl; now in .h file where it belongs.
7370 * fileio.c (Fmake_symbolic_link): New forward static decl.
7371 * image.c (Finit_image_library): New forward static decl.
7372 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7373 * intervals.h (Fprevious_property_change):
7374 (Fremove_list_of_text_properties): Remove decls.
7375 * keyboard.c (Fthis_command_keys): Remove decl.
7376 (Fcommand_execute): New forward static decl.
7377 * keymap.c (Flookup_key): New forward static decl.
7378 (Fcopy_keymap): Now static.
7379 * keymap.h (Flookup_key): Remove decl.
7380 * process.c (Fget_process): New forward static decl.
7381 (Fprocess_datagram_address): Mark as internal.
7382 * syntax.c (Fsyntax_table_p): New forward static decl.
7383 (skip_chars): Remove duplicate decl.
7384 * textprop.c (Fprevious_property_change): New forward static decl.
7385 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7386 Now internal.
7387 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7388 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7389
785bbd42
PE
7390 * editfns.c (Fformat): Remove unreachable code.
7391
8b913b57
AS
73922011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7393
7394 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7395 change. (Bug#8496)
7396
a6744a35
EZ
73972011-04-13 Eli Zaretskii <eliz@gnu.org>
7398
7399 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7400 when at ZV. (Bug#8487)
7401
e7974947
AS
74022011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7403
baad03f0
AS
7404 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7405 (Bug#8437)
7406 * keyboard.c (parse_tool_bar_item): Likewise.
7407 * sound.c (sound_cleanup, alsa_close): Likewise.
7408 * termcap.c (tgetent): Likewise.
7409 * xfns.c (x_default_font_parameter): Likewise.
7410 * xsettings.c (read_and_apply_settings): Likewise.
7411
e7974947
AS
7412 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7413 (overrun_check_free): Protoize.
7414
28272684
PE
74152011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7416
7417 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7418 since callers should never pass a negative size.
7419 Change the signature to match that of plain 'read' and 'write'; see
7420 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7421 * lisp.h: Update prototypes of emacs_write and emacs_read.
7422
11997c76
EZ
74232011-04-11 Eli Zaretskii <eliz@gnu.org>
7424
7425 * xdisp.c (redisplay_window): Don't try to determine the character
7426 position of the scroll margin if the window start point w->startp
e896f03c 7427 is outside the buffer's accessible region. (Bug#8468)
11997c76 7428
8a2cbd72
EZ
74292011-04-10 Eli Zaretskii <eliz@gnu.org>
7430
7431 Fix write-region and its subroutines for buffers > 2GB.
7432 * fileio.c (a_write, e_write): Modify declaration of arguments and
7433 local variables to support buffers larger than 2GB.
7434 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7435
7436 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7437 argument, local variables, and return value.
7438
7439 * lisp.h: Update prototypes of emacs_write and emacs_read.
7440
7441 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7442
4073e537 74432011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7444
1ebfdcb6
PE
7445 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7446
b2ded58d
PE
7447 Fix more problems found by GCC 4.6.0's static checks.
7448
7d66342c
PE
7449 * xdisp.c (vmessage): Use a better test for character truncation.
7450
bbf47d44
PE
7451 * charset.c (load_charset_map): <, not <=, for optimization,
7452 and to avoid potential problems with integer overflow.
9248994d 7453 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7454 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7455 * editfns.c (Fformat): Likewise.
1e69125e 7456 * syntax.c (skip_chars): Likewise.
3befa583 7457
e3019616
PE
7458 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7459 This also lets GCC 4.6.0 generate slightly better loop code.
7460
becfa255
PE
7461 * callint.c (Fcall_interactively): <, not <=, for optimization.
7462 (Fcall_interactively): Count the number of arguments produced,
7463 not the number of arguments given. This is simpler and lets GCC
7464 4.6.0 generate slightly better code.
7465
dae0cd48
PE
7466 * ftfont.c: Distingish more carefully between FcChar8 and char.
7467 The previous code passed unsigned char * to a functions like
7468 strlen and xstrcasecmp that expect char *, which does not
7469 conform to the C standard.
7470 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7471 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7472 char * when the C standard requires it.
7473
76032d70
PE
7474 * keyboard.c (read_char): Remove unused var.
7475
eb3f1cc8
PE
7476 * eval.c: Port to Windows vsnprintf (Bug#8435).
7477 Include <limits.h>.
7478 (SIZE_MAX): Define if the headers do not.
7479 (verror): Do not give up if vsnprintf returns a negative count.
7480 Instead, grow the buffer. This ports to Windows vsnprintf, which
7481 does not conform to C99. Problem reported by Eli Zaretskii.
7482 Also, simplify the allocation scheme, by avoiding the need for
7483 calling realloc, and removing the ALLOCATED variable.
7484
70476b54
PE
7485 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7486
12020a9e
PE
7487 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7488 But keep the doprint source code for now, as we might revamp it
7489 and use it again (Bug#8435).
ea6c7ae6
PE
7490 * lisp.h (doprnt): Remove.
7491 * Makefile.in (base_obj): Remove doprnt.o.
7492 * deps.mk (doprnt.o): Remove.
7493
5fdb398c
PE
7494 error: Print 32- and 64-bit integers portably (Bug#8435).
7495 Without this change, on typical 64-bit hosts error ("...%d...", N)
7496 was used to print both 32- and 64-bit integers N, which relied on
7497 undefined behavior.
7498 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7499 New macro.
7500 * lisp.h (error, verror): Mark as printf-like functions.
7501 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7502 Report overflow in size calculations when allocating printf buffer.
7503 Do not truncate output string at its first null byte.
7504 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7505 Truncate the output at a character boundary, since vsnprintf does not
7506 do that.
7507 * charset.c (check_iso_charset_parameter): Convert internal
7508 character to string before calling 'error', since %c now has the
7509 printf meaning.
7510 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7511 overflow when computing char to be passed to 'error'. Do not
7512 pass Lisp_Object to 'error'; pass the integer instead.
7513 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7514 formatted with plain %d.
7515
b189fa66
PE
7516 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7517
bff87ef0
PE
7518 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7519
7e2cac20
PE
7520 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7521
ce4d90b5
PE
7522 * xterm.c (x_catch_errors): Remove duplicate declaration.
7523
266c9547
PE
7524 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7525
79c49ad2
PE
7526 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7527
368f4090
JM
75282011-04-10 Jim Meyering <meyering@redhat.com>
7529
7530 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7531 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7532 return ssize_t not "int", and use size_t as the buffer length.
7533 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7534 * gnutls.h: Update declarations.
7535 * process.c (read_process_output): Use ssize_t, to match.
7536 (send_process): Likewise.
7537
a32d4040
CY
75382011-04-09 Chong Yidong <cyd@stupidchicken.com>
7539
7540 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7541
8546720e 75422011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7543
04f2d78b
CB
7544 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7545 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7546
8546720e
GM
7547 * xterm.c (handle_one_xevent):
7548 * xmenu.c (create_and_show_popup_menu):
7549 * xselect.c (x_decline_selection_request)
7550 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7551
0a2f5c1a 75522011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7553
7554 Fix some uses of `int' instead of EMACS_INT.
7555 * search.c (string_match_1, fast_string_match)
7556 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7557 (scan_buffer, find_next_newline_no_quit)
7558 (find_before_next_newline, search_command, Freplace_match)
7559 (Fmatch_data): Make some `int' variables be EMACS_INT.
7560
7561 * xdisp.c (display_count_lines): 3rd argument and return value now
7562 EMACS_INT. All callers changed.
7563 (pint2hrstr): Last argument is now EMACS_INT.
7564
7565 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7566 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7567 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7568 (decode_coding_utf_16, decode_coding_emacs_mule)
7569 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7570 (decode_coding_ccl, decode_coding_charset)
7571 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7572 (decode_coding_iso_2022, decode_coding_emacs_mule)
7573 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7574 <char_offset, last_offset>: Declare EMACS_INT.
7575 (encode_coding_utf_8, encode_coding_utf_16)
7576 (encode_coding_emacs_mule, encode_invocation_designation)
7577 (encode_designation_at_bol, encode_coding_iso_2022)
7578 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7579 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7580 Declare EMACS_INT.
7581 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7582 (encode_invocation_designation): Last argument P_NCHARS is now
7583 EMACS_INT.
7584 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7585 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7586
7587 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7588 All users changed.
7589
7590 * ccl.c (Fccl_execute_on_string): Declare some variables
7591 EMACS_INT.
7592
8546720e 75932011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7594
7595 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7596
4e19a977
CS
75972011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7598
7599 * process.c (Fformat_network_address): Doc fix.
7600
87302331
R
76012011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7602
ee7683eb 7603 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7604
cbb59342
CY
76052011-04-08 Chong Yidong <cyd@stupidchicken.com>
7606
7607 * keyboard.c (read_char): Call Lisp function help-form-show,
7608 instead of using internal_with_output_to_temp_buffer.
7609 (Qhelp_form_show): New var.
e0d38eeb 7610 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7611
7612 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7613
7614 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7615
e67a13ab
CY
76162011-04-06 Chong Yidong <cyd@stupidchicken.com>
7617
04f2d78b
CB
7618 * process.c (Flist_processes): Remove to Lisp.
7619 (list_processes_1): Delete.
e67a13ab 7620
973f782d
EZ
76212011-04-06 Eli Zaretskii <eliz@gnu.org>
7622
7c106b1e
EZ
7623 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7624
973f782d
EZ
7625 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7626
41cf7d1a 76272011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7628
ca23cc88
PE
7629 Fix more problems found by GCC 4.6.0's static checks.
7630
f390e2d5
PE
7631 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7632
42eea0d0
PE
7633 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7634
b69769da 7635 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7636
f9541e84
PE
7637 * xdisp.c (vmessage): Mark as a printf-like function.
7638
13841b55
PE
7639 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7640
c136c10f
PE
7641 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7642
5e2d4a30
PE
7643 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7644 printf-like functions.
7645 (tiff_load): Add casts to remove these marks before passing them
7646 to system-supplied API.
7647
583f48b9
PE
7648 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7649
b25d760e
PE
7650 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7651 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7652 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7653 directly, rather than having caller test rule sign. This avoids
7654 some unnecessary tests.
7655 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7656 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7657 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7658
bc7b6697 7659 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7660 (xfont_open): Avoid unnecessary tests.
bc7b6697 7661
27ccc379
PE
7662 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7663
dcd5c89a
PE
7664 * composite.h, composite.c (composition_gstring_put_cache):
7665 Use EMACS_INT, not int, for length.
7666
b13a45c6
PE
7667 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7668 breaking out part of COMPOSITION_DECODE_RULE.
7669 (COMPOSITION_DECODE_RULE): Use it.
7670 * composite.c (get_composition_id): Remove unused local vars,
7671 by using the new macro.
7672
1e792e4d
PE
7673 * textprop.c (set_text_properties_1): Change while to do-while,
7674 since the condition is always true at first.
7675
dc6c6455 7676 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7677 (interval_deletion_adjustment): Return unsigned value.
7678 All uses changed.
dc6c6455 7679
aba7731a
PE
7680 * process.c (list_processes_1, create_pty, read_process_output):
7681 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7682 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7683 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7684 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7685 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7686
fdfc4bf3
PE
7687 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7688
fca8fe46 7689 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7690 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7691
06a0259a 7692 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7693 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7694 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7695
e7b9e80f
PE
7696 * print.c (print_error_message): Avoid int overflow.
7697
56201685
PE
7698 * font.c (font_list_entities): Redo for clarity,
7699 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7700
78834453 7701 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7702 (font_score): Avoid potential overflow in diff calculation.
78834453 7703
0bc0b309 7704 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7705 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7706
e610eaca
PE
7707 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7708
b895abce
PE
7709 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7710 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7711 can always succeed if overflow has undefined behavior.
7712
1f1d9321 7713 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7714 (wordify): Omit three unnecessary tests.
1f1d9321 7715
c59478bc
PE
7716 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7717 All callers changed. This avoids the need for an unused var.
7718
79b73827
PE
7719 * casefiddle.c (casify_region): Remove var that is set but not used.
7720
a4db5dfe
PE
7721 * dired.c (file_name_completion): Remove var that is set but not used.
7722
43aae36e
PE
7723 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7724
2a47c44d 7725 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7726 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7727
a37c69bf
PE
7728 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7729 Check for integer overflow on size calculations.
7730
328ab8e7
PE
7731 * buffer.c (Fprevious_overlay_change): Remove var that is set
7732 but not used.
7733
e5a2a5cb
PE
7734 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7735 Remove vars that are set but not used.
8d84a6eb 7736 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7737 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7738
a60e5f68
PE
7739 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7740
f661cb61 7741 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7742 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7743
f0397f5a
PE
7744 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7745 that are set but not used.
7746
8664db06 7747 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7748 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7749
6abdaa4a
PE
7750 * xselect.c (x_get_local_selection, x_handle_property_notify):
7751 Remove vars that are set but not used.
7752
0ce7538d 7753 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7754 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7755
9ae848fc
PE
7756 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7757 Remove var that is set but not used.
0b918413
PE
7758 (scroll_bar_windows_size): Now size_t, not int.
7759 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7760 Check for overflow.
9ae848fc 7761
a5a62657
PE
7762 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7763 (map_tty_color) [!defined MSDOS]: Likewise.
7764
5c5cdd39
PE
7765 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7766
66ebf983
PE
7767 * coding.c: Remove vars that are set but not used.
7768 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7769 All callers changed.
7770 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7771 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7772 (decode_coding_charset): Remove vars that are set but not used.
7773
1be4d761
PE
7774 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7775 that is set but not used.
7776
47553fa8
PE
7777 * print.c (print_object): Remove var that is set but not used.
7778
1f7196bf 7779 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7780 The gnulib version avoids calling malloc in the usual case,
7781 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7782 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7783 * filelock.c (current_lock_owner): Likewise.
7784 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7785 * sysdep.c: Include allocator.h, careadlinkat.h.
7786 (emacs_no_realloc_allocator): New static constant.
7787 (emacs_readlink): New function.
fdb61804
PE
7788 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7789 ../lib/careadlinkat.h.
d1fdcab7 7790
f84c17c7
SM
77912011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7792
7793 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7794 first non-nil return value).
7795
ef3862ad
JD
77962011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7797
7798 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7799 if not defined (Bug#8403).
7800
376a7006
JB
78012011-04-02 Juanma Barranquero <lekktu@gmail.com>
7802
7803 * xdisp.c (display_count_lines): Remove parameter `start',
7804 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7805 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7806 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7807 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7808 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7809 and thereabouts. All callers changed.
7810 (get_per_char_metric): Remove parameter `f', unused since
7811 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7812
6ca3801d
JM
78132011-04-02 Jim Meyering <meyering@redhat.com>
7814
7815 do not dereference NULL upon failed strdup
7816 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7817 (ns_get_family): Likewise.
7818
d8e2b5ba
JB
78192011-04-02 Juanma Barranquero <lekktu@gmail.com>
7820
7821 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7822
8c74fcbd
JD
78232011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7824
7825 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7826 later (Bug#8403).
7827
7200d79c
SM
78282011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7829
03408648 7830 Add lexical binding.
7200d79c 7831
03408648
SM
7832 * window.c (Ftemp_output_buffer_show): New fun.
7833 (Fsave_window_excursion):
7834 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7835
7836 * lread.c (lisp_file_lexically_bound_p): New function.
7837 (Fload): Bind Qlexical_binding.
7838 (readevalloop): Remove `evalfun' arg.
7839 Bind Qinternal_interpreter_environment.
7840 (Feval_buffer): Bind Qlexical_binding.
7841 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7842 Mark as dynamic.
7843 (syms_of_lread): Declare `lexical-binding'.
7844
7845 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7846
7847 * keyboard.c (eval_dyn): New fun.
7848 (menu_item_eval_property): Use it.
ca105506
SM
7849
7850 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7851
03408648
SM
7852 * fns.c (concat, mapcar1): Accept byte-code-functions.
7853
7854 * eval.c (Fsetq): Handle lexical vars.
7855 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7856 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7857 (FletX, Flet): Obey lexical binding.
7858 (Fcommandp): Handle closures.
7859 (Feval): New `lexical' arg.
7860 (eval_sub): New function extracted from Feval. Use it almost
7861 everywhere where Feval was used. Look up vars in lexical env.
7862 Handle closures.
7863 (Ffunctionp): Move from subr.el.
7864 (Ffuncall): Handle closures.
7865 (apply_lambda): Remove `eval_flags'.
7866 (funcall_lambda): Handle closures and new byte-code-functions.
7867 (Fspecial_variable_p): New function.
7868 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7869 but without exporting it to Lisp.
23aba0ea 7870
23aba0ea 7871 * doc.c (Fdocumentation, store_function_docstring):
03408648 7872 * data.c (Finteractive_form): Handle closures.
23aba0ea 7873
03408648
SM
7874 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7875 interactive spec.
ba83908c 7876
04f2d78b
CB
7877 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7878 New byte-codes.
03408648
SM
7879 (exec_byte_code): New function extracted from Fbyte_code to handle new
7880 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7881
03408648 7882 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7883
03408648 7884 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7885
e2abce01
JB
78862011-03-31 Juanma Barranquero <lekktu@gmail.com>
7887
7888 * xdisp.c (redisplay_internal): Fix prototype.
7889
63696a73 78902011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7891
63696a73 7892 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7893 (try_scrolling): Use it when setting scroll_limit.
7894 Limit scrolling to 100 screen lines.
63696a73
EZ
7895 (redisplay_window): Even when falling back on "recentering",
7896 position point in the window according to scroll-conservatively,
7897 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7898
7899 (try_scrolling): When point is above the window, allow searching
7900 as far as scroll_max, or one screenful, to compute vertical
7901 distance from PT to the scroll margin position. This prevents
7902 try_scrolling from unnecessarily failing when
7903 scroll-conservatively is set to a value slightly larger than the
7904 window height. Clean up the case of PT below the margin at bottom
7905 of window: scroll_max can no longer be INT_MAX. When aggressive
7906 scrolling is in use, don't let point enter the opposite scroll
7907 margin as result of the scroll.
7908 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7909 threshold of 100 lines for never-recentering scrolling.
7910
e4cc2dfc
JB
79112011-03-31 Juanma Barranquero <lekktu@gmail.com>
7912
7913 * dispextern.h (move_it_by_lines):
7914 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7915 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7916 (message_log_check_duplicate): Remove parameters `prev_bol' and
7917 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7918 (redisplay_internal): Remove parameter `preserve_echo_area',
7919 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7920
7921 * indent.c (Fvertical_motion):
7922 * window.c (window_scroll_pixel_based, Frecenter):
7923 Don't pass `need_y_p' to `move_it_by_lines'.
7924
1c470562
SM
79252011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7926
44f230aa
SM
7927 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7928 steal a few bits to be more compact.
7929 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7930 Remove unneeded casts.
7931
1c470562
SM
7932 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7933
888adce9
ZK
79342011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7935
7936 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7937 binding" message (bug#7967).
7938
f838ed7b
PE
79392011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7940
77861b95
PE
7941 Fix more problems found by GCC 4.6.0's static checks.
7942
de6dbc14
PE
7943 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7944 Remove unused local var.
7945
f838ed7b
PE
7946 * editfns.c (Fmessage_box): Remove unused local var.
7947
792c7b2b
PE
7948 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7949 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7950 Omit unused local vars.
c499e557 7951 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7952 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7953 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7954 Omit unused local var.
7955
ba0165e1
PE
7956 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7957 Don't assume string length fits in int.
32ad8845 7958 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7959 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7960
3c59b4c9
PE
7961 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7962 instead of alloca (Bug#8344).
7963
a3eed478 7964 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7965 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7966
eb4d412d
PE
7967 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7968
1658b401
PE
7969 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7970 concerns.
7971
7972 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7973
7974 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7975
9a2c6e05
PE
7976 * keyboard.c (syms_of_keyboard): Use the same style as later
7977 in this function when indexing through an array. This also
7978 works around GCC bug 48267.
7979
03d0a109
PE
7980 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7981
44f730c8
PE
7982 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7983
fe75f926
PE
7984 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7985 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7986
ffa8c828
PE
7987 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7988 This avoids undefined behavior on integer overflow, and is a bit
7989 more convenient anyway since it is compared to a size_t variable.
7990
c5101a77
PE
7991 Variadic C functions now count arguments with size_t, not int.
7992 This avoids an unnecessary limitation on 64-bit machines, which
7993 caused (substring ...) to crash on large vectors (Bug#8344).
7994 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7995 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7996 All variadic functions and their callers changed accordingly.
c5101a77
PE
7997 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7998 * data.c (arith_driver, float_arith_driver): Likewise.
7999 * editfns.c (general_insert_function): Likewise.
8000 * eval.c (struct backtrace.nargs, interactive_p)
8001 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8002 (funcall_lambda, mark_backtrace): Likewise.
8003 * fns.c (concat): Likewise.
8004 * frame.c (x_set_frame_parameters): Likewise.
8005 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8006 0 if not found, not -1. All callers changed.
8007
dd3f25f7
PE
8008 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8009 (stack_copy_size): Now size_t, not int.
8010 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8011
461c2ab9
JB
80122011-03-28 Juanma Barranquero <lekktu@gmail.com>
8013
8014 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8015 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8016 All callers changed.
8017
8018 * lisp.h (multibyte_char_to_unibyte):
8019 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8020 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8021 * character.h (CHAR_TO_BYTE8):
8022 * cmds.c (internal_self_insert):
8023 * editfns.c (general_insert_function):
8024 * keymap.c (push_key_description):
8025 * search.c (Freplace_match):
8026 * xdisp.c (message_dolog, set_message_1): All callers changed.
8027
f6d62986
SM
80282011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8029
8030 * keyboard.c (safe_run_hook_funcall): New function.
8031 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8032 don't set the hook to nil, but remove the offending function instead.
8033 (Qcommand_hook_internal): Remove, unused.
8034 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8035 Vcommand_hook_internal.
8036
8037 * eval.c (enum run_hooks_condition): Remove.
8038 (funcall_nil, funcall_not): New functions.
8039 (run_hook_with_args): Call each function through a `funcall' argument.
8040 Remove `cond' argument, now redundant.
8041 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8042 (Frun_hook_with_args_until_failure): Adjust accordingly.
8043 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8044
1db5b1ad
JB
80452011-03-28 Juanma Barranquero <lekktu@gmail.com>
8046
8047 * dispextern.h (string_buffer_position): Remove declaration.
8048
8049 * print.c (strout): Remove parameter `multibyte', unused since
8050 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8051
8052 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8053 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8054 All callers changed.
8055
8056 * w32.c (_wsa_errlist): Use braces for struct initializers.
8057
8058 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8059 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8060 All callers changed.
8061 (string_buffer_position): Likewise. Also, make static (it's never
8062 used outside xdisp.c).
8063 (cursor_row_p): Remove parameter `w', unused since
8064 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8065 (decode_mode_spec): Remove parameter `precision', introduced during
8066 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8067 All callers changed.
8068
5ffb62aa
JD
80692011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8070
8071 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8072
461c2ab9 80732011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8074
8075 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8076 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8077 (ns_update_auto_hide_menu_bar): New functions.
8078 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8079 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8080 ns_constrain_all_frames.
8081 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8082 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8083
5c380ffb
JD
80842011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8085
8086 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8087
9af30bdf
GM
80882011-03-27 Glenn Morris <rgm@gnu.org>
8089
8090 * syssignal.h: Replace RETSIGTYPE with void.
8091 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8092 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8093 Replace SIGTYPE with void everywhere.
8094 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8095 * s/template.h (SIGTYPE): Remove commented out definition.
8096
e2abce01
JB
80972011-03-26 Eli Zaretskii <eliz@gnu.org>
8098
8099 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8100 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8101
f868cd8a
JB
81022011-03-26 Juanma Barranquero <lekktu@gmail.com>
8103
59eb0929
JB
8104 * w32.c (read_unc_volume): Use parameter `henum', instead of
8105 global variable `wget_enum_handle'.
8106
8107 * keymap.c (describe_vector): Remove parameters `indices' and
8108 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8109 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8110
f868cd8a
JB
8111 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8112
8113 * keyboard.c (timer_check): Remove parameter `do_it_now',
8114 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8115 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8116 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8117
8118 * keyboard.c (read_char):
8119 * w32menu.c (w32_menu_display_help):
8120 * xmenu.c (show_help_event, menu_help_callback):
8121 Adjust calls to `show_help_echo'.
8122
8123 * gtkutil.c (xg_maybe_add_timer):
8124 * keyboard.c (readable_events):
8125 * process.c (wait_reading_process_output):
8126 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8127
8128 * insdel.c (adjust_markers_gap_motion):
8129 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8130 (gap_left, gap_right): Don't call it.
8131
2ecf6fdb
CY
81322011-03-25 Chong Yidong <cyd@stupidchicken.com>
8133
8134 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8135 incurred during fontification.
8136
6b1f9ba4
JB
81372011-03-25 Juanma Barranquero <lekktu@gmail.com>
8138
8139 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8140 (DEFVAR_PER_BUFFER): Don't pass it.
8141
8142 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8143 (scrolling_window): Don't pass it.
8144
0f4a96b5
JB
81452011-03-25 Juanma Barranquero <lekktu@gmail.com>
8146
8147 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8148
8149 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8150 and `suffix'.
8151 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8152 of variables specific to SELinux and computation of `encoded_absname'.
8153
8154 * image.c (XPutPixel): Remove unused variable `height'.
8155
8156 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8157
8158 * unexw32.c (get_section_info): Remove unused variable `section'.
8159
8160 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8161 (system_process_attributes): Remove unused variable `sess'.
8162 (sys_read): Remove unused variable `err'.
8163
8164 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8165 (w32_wnd_proc): Remove unused variable `isdead'.
8166 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8167 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8168 (x_create_tip_frame): Remove unused variable `tem'.
8169
8170 * w32inevt.c (w32_console_read_socket):
8171 Remove unused variable `no_events'.
8172
8173 * w32term.c (x_draw_composite_glyph_string_foreground):
8174 Remove unused variable `width'.
8175
1149507c
JB
81762011-03-24 Juanma Barranquero <lekktu@gmail.com>
8177
8178 * w32term.c (x_set_glyph_string_clipping):
8179 Don't pass uninitialized region to CombineRgn.
8180
9c88f339
JB
81812011-03-23 Juanma Barranquero <lekktu@gmail.com>
8182
8183 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8184 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8185 (Fx_close_connection): Remove unused variable `i'.
8186
8187 * w32font.c (w32font_draw): Return number of glyphs.
8188 (w32font_open_internal): Remove unused variable `i'.
8189 (w32font_driver): Add missing initializer.
8190
8191 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8192 (fill_in_menu): Remove unused variable `items_added'.
8193
8194 * w32term.c (last_mouse_press_frame): Remove static global variable.
8195 (w32_clip_to_row): Remove unused variable `f'.
8196 (x_delete_terminal): Remove unused variable `i'.
8197
8198 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8199 (NOTHING): Remove unused static global variable.
8200 (uniscribe_check_otf): Remove unused variable `table'.
8201 (uniscribe_font_driver): Add missing initializers.
8202
dee091a3
JD
82032011-03-23 Julien Danjou <julien@danjou.info>
8204
8205 * term.c (Fsuspend_tty, Fresume_tty):
8206 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8207 * window.c (temp_output_buffer_show):
8208 * insdel.c (signal_before_change):
8209 * frame.c (Fhandle_switch_frame):
8210 * fileio.c (Fdo_auto_save):
8211 * emacs.c (Fkill_emacs):
8212 * editfns.c (save_excursion_restore):
8213 * cmds.c (internal_self_insert):
8214 * callint.c (Fcall_interactively):
8215 * buffer.c (Fkill_all_local_variables):
8216 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8217 Use Frun_hooks.
0f4a96b5 8218 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8219 unconditionally since it does the check itself.
dee091a3 8220
2c520ab5 82212011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8222
c9c49752
PE
8223 Fix more problems found by GCC 4.5.2's static checks.
8224
8abc3f12
PE
8225 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8226 the first time through the loop, since we know p0 < p1 then.
8227 This also avoids a gcc -Wstrict-overflow warning.
8228
a2d26660
PE
8229 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8230 leading to a memory leak, possible in functions like
8231 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8232 of objects (Bug#8318).
a2d26660 8233
916c72e9
PE
8234 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8235 that could (at least in theory) be that large.
8236
19ab8a18
PE
8237 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8238 This is less likely to overflow, and avoids undefined behavior if
8239 overflow does occur. All callers changed. Use strtoul to scan
8240 for the unsigned long integer.
b7cbbd6f
PE
8241 (pint2hrstr): Simplify and tune code slightly.
8242 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8243
f0641eff
PE
8244 * scroll.c (do_scrolling): Work around GCC bug 48228.
8245 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8246
7f650bb9
PE
8247 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8248 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8249 (validate_x_resource_name): Simplify count usage.
8250 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8251
37dd57d1
PE
8252 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8253 fail (Bug#8306).
81e56e61 8254
699979fc 8255 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8256
401bf9b4
PE
8257 * process.c (Fmake_network_process): Use socklen_t, not int,
8258 where POSIX says socklen_t is required in portable programs.
8259 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8260 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8261 (Fmake_network_process, server_accept_connection):
8262 (wait_reading_process_output, read_process_output):
8263 Likewise.
8264
b93aacde
PE
8265 * process.c: Rename or move locals to avoid shadowing.
8266 (list_processes_1, Fmake_network_process):
8267 (read_process_output_error_handler, exec_sentinel_error_handler):
8268 Rename or move locals.
4dc343ee 8269 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8270 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8271 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8272 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8273 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8274
af8a867c 8275 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8276 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8277 Include tparam.h instead, since it declares them.
af8a867c
PE
8278 * cm.h (PC): Remove extern decl; tparam.h now does this.
8279 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8280 * terminfo.c: Include tparam.h, to check interfaces.
8281 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8282 (tparam): Adjust signature to match interface in tparam.h;
8283 this removes some undefined behavior. Check that outstring and len
8284 are zero, which they always are with Emacs.
8285 * tparam.h (PC, BC, UP): New extern decls.
8286
0248044d 8287 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8288 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8289
8ff096c1 8290 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8291 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8292 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8293 (ftfont_list): Remove unused local.
49eaafba
PE
8294 (get_adstyle_property, ftfont_pattern_entity):
8295 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8296 Rename locals to avoid shadowing.
8ff096c1 8297
e2be39f6
PE
8298 * xfont.c (xfont_list_family): Mark var as initialized.
8299
c9735e30
PE
8300 * xml.c (make_dom): Now static.
8301
8f5201ae
PE
8302 * composite.c (composition_compute_stop_pos): Rename local to
8303 avoid shadowing.
b246f932
PE
8304 (composition_reseat_it): Remove unused locals.
8305 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8306 (composition_update_it): Mark var as initialized.
11b61122
PE
8307 (find_automatic_composition): Mark vars as initialized,
8308 with a FIXME (Bug#8290).
8f5201ae 8309
760fbc2c
PE
8310 character.h: Rename locals to avoid shadowing.
8311 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8312 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8313 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8314 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8315 to avoid shadowing.
8316
ff08eb85
PE
8317 * textprop.c (property_change_between_p): Remove; unused.
8318
fc7bf025
PE
8319 * intervals.c (interval_start_pos): Now static.
8320
235d7abc
PE
8321 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8322
44f230aa
SM
8323 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8324 Rename locals to avoid shadowing.
3e7d6594 8325
50060332
PE
8326 * sound.c (wav_play, au_play, Fplay_sound_internal):
8327 Fix pointer signedness.
d01f234b 8328 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8329 (wav_play): Initialize a variable to 0, to prevent undefined
8330 behavior (Bug#8278).
50060332 8331
c4fc4e30
PE
8332 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8333
918436ed
PE
8334 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8335
c939f91b
PE
8336 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8337 clobbering (Bug#8298).
b9c7f648
PE
8338 * sysdep.c (sys_subshell): Likewise.
8339 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8340
6bd8c144
PE
8341 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8342 This should get cleaned up, so that child_setup has the
8343 same signature on all platforms.
8344
7710357c 8345 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8346 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8347
c59da222
CY
83482011-03-22 Chong Yidong <cyd@stupidchicken.com>
8349
8350 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8351 not to be necessary, and produces flickering.
8352
66b87493
GM
83532011-03-20 Glenn Morris <rgm@gnu.org>
8354
8355 * config.in: Remove file.
8356
45b6f6d5
JB
83572011-03-20 Juanma Barranquero <lekktu@gmail.com>
8358
8359 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8360 are now in src/globals.h.
8361 (syms_of_minibuf): Remove spurious & from previous change.
8362
cd394be1 83632011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8364
8365 * minibuf.c (completing-read-function): New variable.
8366 (completing-read-default): Rename from completing-read.
8367 (completing-read): Call completing-read-function.
8368
b14e3e21
CY
83692011-03-19 Juanma Barranquero <lekktu@gmail.com>
8370
8371 * xfaces.c (Fx_load_color_file):
8372 Read color file from absolute filename (bug#8250).
8373
f2b726e6
JB
83742011-03-19 Juanma Barranquero <lekktu@gmail.com>
8375
8376 * makefile.w32-in: Update dependencies.
8377
09f6ff02
EZ
83782011-03-17 Eli Zaretskii <eliz@gnu.org>
8379
8380 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8381
29a6015a
PE
83822011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8383
a3a6c54e
PE
8384 Fix more problems found by GCC 4.5.2's static checks.
8385
b766f867
PE
8386 * process.c (make_serial_process_unwind, send_process_trap):
8387 (sigchld_handler): Now static.
8388
be02381c
PE
8389 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8390 That way, the code declares only the vars that it needs.
8391 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8392 * s/cygwin.h (PTY_ITERATION): Likewise.
8393 * s/darwin.h (PTY_ITERATION): Likewise.
8394 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8395
57048744
PE
8396 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8397 * process.c (allocate_pty): Don't declare stb unless it's needed.
8398
7914961c 8399 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8400 (CONSTANTLIM): Remove; unused.
8401 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8402 Define only if needed.
7914961c 8403
b3967b18
PE
8404 * unexelf.c (unexec): Name an expression,
8405 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8406 Use a different way to cause a compilation error if anyone uses
8407 n rather than nn, a way that does not involve shadowing.
73366a00 8408 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8409
29a6015a
PE
8410 * deps.mk (unexalpha.o): Remove; unused.
8411
43cfc33e 8412 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8413 * unexec.h: New file.
ce701a33
PE
8414 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8415 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8416 Depend on unexec.h.
8417 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8418 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8419 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8420 Change as necessary to match prototype in unexec.h.
ce701a33 8421
01f44d5a
PE
8422 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8423 shadowing.
4f63c6bb 8424 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8425
a6670b0b
PE
8426 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8427 Rename locals to avoid shadowing.
8428
cef2010d 8429 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8430 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8431
d4d7173a
PE
8432 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8433
f08b802a
PE
8434 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8435 warning when compiling print.c.
8436
3ddb0639
PE
8437 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8438 instead of using an uninitialized var.
5ad03b97 8439 (font_sort_entities): Mark var as initialized.
3ddb0639 8440
170a2692
PE
8441 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8442
e663c700
PE
8443 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8444 pointers to constants.
89bc529a 8445 (font_parse_fcname): Remove unused vars.
7b81e2d0 8446 (font_delete_unmatched): Now static.
ea838e10 8447 (font_get_spec): Remove; unused.
13a547c6
PE
8448 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8449 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8450 Rename or move locals to avoid shadowing.
e663c700 8451
2a80c887 8452 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8453 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8454
1384fa33 8455 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8456 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8457
8b2c52e9
PE
8458 * alloc.c (mark_backtrace): Move decl from here ...
8459 * lisp.h: ... to here, so that it can be checked.
8460
475545b5 8461 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8462 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8463 (lisp_indirect_variable): Name an expression,
8464 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8465 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8466
b1349114 8467 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8468 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8469 Use const pointer when appropriate.
b1349114 8470
a2928364
PE
8471 * lisp.h (get_system_name, get_operating_system_release):
8472 Move decls here, to check interfaces.
8473 * process.c (get_operating_system_release): Move decl to lisp.h.
8474 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8475 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8476 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8477 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8478 (Fformat_time_string, Fencode_time, Finsert_char):
8479 (Ftranslate_region_internal, Fformat):
8480 Rename or remove local vars to avoid shadowing.
9710023e 8481 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8482
a415e694
PE
8483 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8484 avoid shadowing.
8485
8ef4622d
PE
8486 * lisp.h (eassert): Check that the argument compiles, even if
8487 ENABLE_CHECKING is not defined.
8488
946f9a5b
PE
8489 * data.c (Findirect_variable): Name an expression, to avoid
8490 gcc -Wbad-function-cast warning.
112396d6 8491 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8492 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8493 (Fmake_variable_buffer_local, Fmake_local_variable):
8494 Mark variables as initialized.
52746918 8495 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8496
e5aab7e7 8497 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8498 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8499 Rename locals to avoid shadowing.
dff45157
PE
8500 (mark_stack): Move local variables into the #ifdef region where
8501 they're used.
7bc26fdb
PE
8502 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8503 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8504 needed otherwise.
8505 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8506 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8507 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8508
e5aab7e7
PE
8509 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8510 avoids undefined behavior in theory.
8511
4da60324
PE
8512 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8513
88043301
PE
8514 Use functions, not macros, for up- and down-casing (Bug#8254).
8515 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8516 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8517 to use the following functions instead of these macros.
8518 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8519 EMACS_INT, since callers assume the returned value fits in int.
8520 (upcase1): Likewise, for UPCASE_TABLE.
8521 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8522 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8523 the race-condition problem in the old DOWNCASE.
88043301 8524
19ed5445
PE
8525 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8526 Rename locals to avoid shadowing.
8527 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8528 (regex_compile, re_search_2, re_match_2_internal):
8529 Remove unused local vars.
952db0d7
PE
8530 (FREE_VAR): Rewrite so as not to use empty "else",
8531 which gcc can warn about.
da053e48 8532 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8533 (RETALLOC_IF): Define only if needed.
8534 (WORDCHAR_P): Likewise. This one is never needed, but is used
8535 only in a comment talking about a compiler bug, so put inside
8536 the #if 0 of that comment.
8537 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8538 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8539 Remove; unused.
19ed5445 8540
1f3561e4 8541 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8542 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8543 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8544
ded6f8f7
PE
8545 * search.c (simple_search): Remove unused var.
8546
dbd37a95
PE
8547 * dired.c (compile_pattern): Move decl from here ...
8548 * lisp.h: ... to here, so that it can be checked.
8549 (struct re_registers): New forward decl.
8550
7e47afad
PE
8551 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8552
85f24f61
PE
8553 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8554 All uses changed.
8555 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8556 Rename locals to avoid shadowing.
5671df8f 8557 (Fvertical_motion): Mark locals as initialized.
85f24f61 8558
181aa2be 8559 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8560 (casify_region): Mark local as initialized.
181aa2be 8561
930d429c
PE
8562 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8563
7082eac6
PE
8564 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8565 New macros, so that the caller can use some names other than
8566 gcpro1, gcpro2, etc.
8567 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8568 of the new macros.
8569 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8570 argument, for consistency with GCPRO2_VAR, etc: it is now the
8571 prefix of the variable, not the variable itself. All uses
8572 changed.
38b2c076
PE
8573 * dired.c (directory_files_internal, file_name_completion):
8574 Rename locals to avoid shadowing.
8575
15206ed9
PE
8576 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8577 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8578 dired.c's scmp function, had undefined behavior.
8579 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8580 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8581 * buffer.h: ... to here, because these macros use current_buffer,
8582 and the new implementation with inline functions needs to have
8583 current_buffer in scope now, rather than later when the macros
8584 are used.
8585 (downcase, upcase1): New static inline functions.
8586 (DOWNCASE, UPCASE1): Reimplement using these functions.
8587 This avoids undefined behavior in expressions like
8588 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8589 from race conditions in accessing the global variables
8590 case_temp1 and case_temp2.
8591 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8592 * lisp.h (case_temp1, case_temp2): Remove their decls.
8593 * character.h (ASCII_CHAR_P): Move from here ...
8594 * lisp.h: ... to here, so that the inline functions mentioned
8595 above can use them.
8596
4a6bea26
PE
8597 * dired.c (directory_files_internal_unwind): Now static.
8598
f14b7e14
PE
8599 * fileio.c (file_name_as_directory, directory_file_name):
8600 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8601 Now static.
2893f146
PE
8602 (file_name_as_directory): Use const pointers when appropriate.
8603 (Fexpand_file_name): Likewise. In particular, newdir might
8604 point at constant storage, so make it a const pointer.
fd4ead52 8605 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8606 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8607 signedness issues.
f839df0c
PE
8608 (Fset_file_times, Finsert_file_contents, auto_save_error):
8609 Rename locals to avoid shadowing.
f14b7e14 8610
5716756e 8611 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8612 (Ftry_completion, Fall_completions): Rename or remove locals
8613 to avoid shadowing.
5716756e 8614
b4c3046a
PE
8615 * marker.c (bytepos_to_charpos): Remove; unused.
8616
b45db522
PE
8617 * lisp.h (verify_bytepos, count_markers): New decls,
8618 so that gcc does not warn that these functions aren't declared.
8619
85876d07
PE
8620 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8621 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8622 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8623 (copy_text): Remove unused local var.
85876d07 8624
03d78a21 8625 * filelock.c (within_one_second): Now static.
b3dd38ab 8626 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8627
5df8f01b
PE
8628 * buffer.c (fix_overlays_before): Mark locals as initialized.
8629 (fix_start_end_in_overlays): Likewise. This function should be
8630 simplified by using pointers-to-pointers, but that's a different
8631 matter.
b1d876f1 8632 (switch_to_buffer_1): Now static.
8f54f30a
PE
8633 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8634 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8635
a70072c9 8636 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8637 Fix pointer signedness issue.
edced198
PE
8638 (sys_subshell): Mark local as volatile if checking for lint,
8639 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8640 (MAXPATHLEN): Define only if needed.
a70072c9 8641
a0977c44
PE
8642 * process.c (serial_open, serial_configure): Move decls from here ...
8643 * systty.h: ... to here, so that they can be checked.
8644
a884fdcc
PE
8645 * fns.c (get_random, seed_random): Move extern decls from here ...
8646 * lisp.h: ... to here, so that they can be checked.
8647
604efe86 8648 * sysdep.c (reset_io): Now static.
b8950c94 8649 (wait_for_termination_signal): Remove; unused.
604efe86 8650
38fc62d9
PE
8651 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8652 (copy_keymap_item, append_key, push_text_char_description):
8653 Now static.
1004a21a 8654 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8655 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8656 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8657 (describe_map_tree):
8658 Rename locals to avoid shadowing.
38fc62d9 8659
2f2650da
PE
8660 * keyboard.c: Declare functions static if they are not used elsewhere.
8661 (echo_char, echo_dash, cmd_error, top_level_2):
8662 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8663 (read_char, kbd_buffer_get_event, make_lispy_position):
8664 (make_lispy_event, make_lispy_movement, apply_modifiers):
8665 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8666 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8667 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8668 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8669 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8670
a053e86c 8671 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8672 (mark_kboards): Move decl here ...
8673 * alloc.c (mark_kboards): ... from here.
a053e86c 8674
4752793e
PE
8675 * lisp.h (force_auto_save_soon): New decl.
8676
74f10ca7 8677 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8678 (DEFINE_DUMMY_FUNCTION): New macro.
8679 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8680 Use it.
c03cd23f
PE
8681 (main): Add casts to avoid warnings
8682 if GCC considers string literals to be constants.
74f10ca7 8683
022e70d4
PE
8684 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8685
59d6fe83
PE
8686 * dbusbind.c: Pointer signedness fixes.
8687 (xd_signature, xd_append_arg, xd_initialize):
8688 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8689 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8690 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8691 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8692
78320123
PE
8693 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8694 if GCC considers string literals to be constants.
49cebcca 8695 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8696
35ac2a97
SM
86972011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8698
fb103ca9
SM
8699 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8700 (print_preprocess, print_object): New macro to fix last change.
8701
35ac2a97
SM
8702 * print.c (print_preprocess): Don't forget font objects.
8703
62973b41
JB
87042011-03-16 Juanma Barranquero <lekktu@gmail.com>
8705
8706 * emacs.c (USAGE3): Doc fixes.
8707
0e48bb22
AS
87082011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8709
8710 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8711 structure.
8712
7684e57b
JB
87132011-03-14 Juanma Barranquero <lekktu@gmail.com>
8714
8715 * lisp.h (VWindow_system, Qfile_name_history):
8716 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8717 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8718 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8719
8720 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8721 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8722
8723 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8724 * w32console.c (detect_input_pending, read_input_pending)
8725 (encode_terminal_code):
8726 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8727 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8728 (w32_system_caret_y, Qfile_name_history):
8729 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8730 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8731 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8732 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8733 * w32proc.c (Qlocal, report_file_error):
8734 * w32term.c (Vwindow_system, updating_frame):
8735 * w32uniscribe.c (initialized, uniscribe_font_driver):
8736 Remove unneeded extern declarations.
8737
2aa46d6c
CY
87382011-03-14 Chong Yidong <cyd@stupidchicken.com>
8739
c96bbc66 8740 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8741
cffc6f3b
CY
87422011-03-13 Chong Yidong <cyd@stupidchicken.com>
8743
8744 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8745 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8746 These macros can no longer be used for assignment.
8747
44f230aa
SM
8748 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8749 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8750 (record_buffer_markers, fetch_buffer_markers): New functions for
8751 recording and fetching special buffer markers.
8752 (set_buffer_internal_1, set_buffer_temp): Use them.
8753
8754 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8755
8756 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8757
8758 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8759 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8760
8761 * xdisp.c (hscroll_window_tree):
8762 (reconsider_clip_changes): Use PT instead of BUF_PT.
8763
d251f04b
EZ
87642011-03-13 Eli Zaretskii <eliz@gnu.org>
8765
8766 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8767 $(EMACS_ROOT)/lib/intprops.h.
8768
f0c77cd1
PE
87692011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8770
3eca4629
PE
8771 Fix more problems found by GCC 4.5.2's static checks.
8772
7c86ee98
PE
8773 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8774 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8775 (xg_free_frame_widgets): Make it clear that a local variable is
8776 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8777 (gdk_window_get_screen): Make it clear that this macro is needed
8778 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8779 (int_gtk_range_get_value): New function, which avoids a diagnostic
8780 from gcc -Wbad-function-cast.
8781 (xg_set_toolkit_scroll_bar_thumb): Use it.
8782 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8783 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8784 (get_utf8_string, xg_get_file_with_chooser):
8785 Rename locals to avoid shadowing.
8786 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8787
41729b81
PE
8788 * xgselect.c (xg_select): Remove unused var.
8789
f0c77cd1
PE
8790 * image.c (four_corners_best): Mark locals as initialized.
8791 (gif_load): Initialize transparent_p to zero (Bug#8238).
8792 Mark another local as initialized.
ec6cf4c6 8793 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8794
ce0ad53d 8795 * image.c (clear_image_cache): Now static.
d5d5a617 8796 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8797 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8798 (x_edge_detection): Remove unnecessary cast that
8799 gcc -Wbad-function-cast diagnoses.
2037898d 8800 (gif_load): Fix pointer signedness.
6ae141d6
PE
8801 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8802 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8803
33383987 88042011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8805
d32df629
PE
8806 Improve quality of tests for time stamp overflow.
8807 For example, without this patch (encode-time 0 0 0 1 1
8808 1152921504606846976) returns the obviously-bogus value (-948597
8809 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8810 reports time overflow. See
8811 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8812 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8813 * editfns.c: Include limits.h and intprops.h.
8814 (TIME_T_MIN, TIME_T_MAX): New macros.
8815 (time_overflow): Move earlier, to before first use.
8816 (hi_time, lo_time): New functions, for an accurate test for
8817 out-of-range times.
8818 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8819 (Fget_internal_run_time): Don't assume time_t fits in int.
8820 (make_time): Use list2 instead of Fcons twice.
8821 (Fdecode_time): More accurate test for out-of-range times.
8822 (check_tm_member): New function.
8823 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8824 (lisp_time_argument): Don't rely on undefined left-shift and
8825 right-shift behavior when checking for time stamp overflow.
8be6f318 8826
fe31d94c
PE
8827 * editfns.c (time_overflow): New function, refactoring common code.
8828 (Fformat_time_string, Fdecode_time, Fencode_time):
8829 (Fcurrent_time_string): Use it.
8830
8be6f318
PE
8831 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8832 * dired.c (make_time): Move to ...
8833 * editfns.c (make_time): ... here.
8834 * systime.h: Note the move.
8835
09d9db2c 88362011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8837
126bc0dc
YM
8838 * fringe.c (update_window_fringes): Remove unused variables.
8839
c47cbdfd
YM
8840 * unexmacosx.c (copy_data_segment): Also copy __got section.
8841 (Bug#8223)
8842
7ac80be9
EZ
88432011-03-12 Eli Zaretskii <eliz@gnu.org>
8844
c96bbc66 8845 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8846 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8847 Constify `char *' arguments and their references according to
8848 prototypes in tparam.h.
8849
ecb0f94d 8850 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8851
7ac80be9
EZ
8852 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8853 Adapt all references accordingly.
8854
8855 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8856
ef1fd07e
TT
88572011-03-11 Tom Tromey <tromey@redhat.com>
8858
8859 * buffer.c (syms_of_buffer): Remove obsolete comment.
8860
7ef4b50c
EZ
88612011-03-11 Eli Zaretskii <eliz@gnu.org>
8862
8863 * termhooks.h (encode_terminal_code): Declare prototype.
8864
8865 * msdos.c (encode_terminal_code): Don't declare prototype.
8866
8867 * term.c (encode_terminal_code): Now external again, used by
8868 w32console.c and msdos.c.
8869
44f230aa
SM
8870 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8871 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8872
4b1ec863 88732011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8874
1714f52b 8875 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8876
4b1ec863
PE
8877 * fringe.c (update_window_fringes): Mark locals as initialized
8878 (Bug#8227).
8879 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8880
524c7aa6
PE
8881 * alloc.c (mark_fringe_data): Move decl from here ...
8882 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8883 to check its interface.
8884 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8885
a5c0af81 8886 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8887 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8888 (fontset_font): Mark local as initialized.
a9a06e0b 8889 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8890
b4716021
PE
8891 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8892
811e9bac 8893 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8894 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8895 (x_own_selection, Fx_disown_selection_internal): Rename locals
8896 to avoid shadowing.
8897 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8898
7e3ab302
PE
8899 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8900 so that the caller can use some name other than gcpro1.
8901 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8902 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8903 (Fx_backspace_delete_keys_p):
8904 Use them to avoid shadowing, and rename vars to avoid shadowing.
8905 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8906 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8907 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8908 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8909 Remove unused locals.
7e3ab302
PE
8910 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8911 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8912 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8913 macros.
f78faa98 8914
e2b13473
PE
8915 * xterm.h (x_mouse_leave): New decl.
8916
77f23912
PE
8917 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8918 Remove unused functions.
cdf4ba58
PE
8919 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8920 (x_calc_absolute_position): Now static.
7411c686 8921 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8922 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8923 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8924 unless they are used.
38d0b34a
PE
8925 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8926 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8927 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8928 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8929 (x_error_catcher, x_connection_closed, x_error_handler):
8930 (x_error_quitter, xembed_send_message, x_iconify_frame):
8931 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8932 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8933 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8934
44f230aa
SM
8935 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8936 Rename or move locals to avoid shadowing.
6b463e58 8937 (tty_defined_color, merge_face_heights): Now static.
5967d051 8938 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8939 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8940 does not deduce is never used uninitialized.
73719eba
PE
8941 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8942 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8943
426994c3 8944 * terminal.c (store_terminal_param): Now static.
5489860b 8945
032f1620 8946 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8947 (set_frame_menubar): Remove unused local.
d4323972 8948 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8949 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8950 since they might point to immutable storage.
281585b0
PE
8951 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8952 since it's unused otherwise.
032f1620 8953
367c19e5 8954 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8955 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8956 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8957 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8958 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8959 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8960 does not deduce are never used uninitialized.
70739cbe 8961
07b48fa9
PE
8962 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8963
8868a238 8964 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8965 * window.c (window_loop, size_window):
8966 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8967
7e5cf297 8968 * window.c (display_buffer): Now static.
d6550a9f
PE
8969 (size_window): Mark variables that gcc -Wuninitialized
8970 does not deduce are never used uninitialized.
a586633d
PE
8971 * window.h (check_all_windows): New decl, to forestall
8972 gcc -Wmissing-prototypes diagnostic.
5b555da1 8973 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8974
f6095868
PE
8975 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8976 shadowing.
8977 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8978 Include <limits.h>.
8979 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8980 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8981 (load_charset_map): Mark variables that gcc -Wuninitialized
8982 does not deduce are never used uninitialized.
53df7c11 8983 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8984
f38b440c
PE
8985 * coding.c (coding_set_source, coding_set_destination):
8986 Use "else { /* comment */ }" rather than "else /* comment */;"
8987 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8988 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8989 a block, when the outer 'i' will do.
8990 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8991 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8992 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8993 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8994 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8995 Rename locals to avoid shadowing.
8996 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8997 * coding.c (emacs_mule_char, encode_invocation_designation):
8998 Now static, since they're not used elsewhere.
413bb2db 8999 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9000 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9001 (decode_coding_emacs_mule): Mark variables that gcc
9002 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9003 (detect_coding_iso_2022): Initialize a local variable that might
9004 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9005 this initialization is needed. (Bug#8211)
5f58e762
PE
9006 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9007 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9008 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9009 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9010 Remove unused macros.
f38b440c 9011
232b38b9 9012 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9013 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9014 * character.c (string_count_byte8): Likewise.
232b38b9 9015
fb90da1b
PE
9016 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9017 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9018
fb93dbc2
PE
9019 * chartab.c (copy_sub_char_table): Now static, since it's not used
9020 elsewhere.
5c156ace
PE
9021 (sub_char_table_ref_and_range, char_table_ref_and_range):
9022 Rename locals to avoid shadowing.
bbcd0949 9023 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9024
7d3b3862 9025 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9026 (BIDI_BOB): Remove unused macro.
7d3b3862 9027
6be7d3da
PE
9028 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9029 deduce are never used uninitialized.
c2ed9c8b 9030 * term.c (encode_terminal_code): Likewise.
6be7d3da 9031
75f8807f 9032 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9033
50938595
PE
9034 * tparam.h: New file.
9035 * term.c, tparam.h: Include it.
9036 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9037 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9038 Move these decls to tparam.h, and make them agree with what
9039 is actually in tparam.c. The previous trick of using incompatible
9040 decls in different modules does not conform to the C standard.
9041 All callers of tparam changed to use tparam's actual API.
9042 * tparam.c (tparam1, tparam, tgoto):
9043 Use const pointers where appropriate.
9044
fbceeba2
PE
9045 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9046 * cm.h (struct cm): Likewise.
9047 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9048 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9049 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9050 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9051 (turn_on_face, init_tty): Likewise.
9052 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9053
7f3f1250
PE
9054 * term.c (term_mouse_position): Rename local to avoid shadowing.
9055
e6ca6543
PE
9056 * alloc.c (mark_ttys): Move decl from here ...
9057 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9058
c40f8d15
AS
90592011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9060
9061 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9062
cfe0661d
JB
90632011-03-09 Juanma Barranquero <lekktu@gmail.com>
9064
9065 * search.c (compile_pattern_1): Remove argument regp, unused since
9066 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9067 (compile_pattern): Don't pass it.
9068
0afb4571
J
90692011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9070
9071 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9072 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9073 for ! HAVE_GTK3.
9074 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9075
9076 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9077
9078 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9079 gdk_window_get_screen, gdk_window_get_geometry,
9080 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9081 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9082 (xg_get_pixbuf_from_pixmap): New function.
9083 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9084 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9085 Call xg_get_pixbuf_from_pixmap instead of
9086 gdk_pixbuf_get_from_drawable.
9087 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9088 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9089 (xg_check_special_colors): Use GtkStyleContext and its functions
9090 for HAVE_GTK3.
9091 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9092 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9093 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9094 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9095 Call gtk_widget_get_preferred_size.
0afb4571
J
9096 (xg_frame_resized): gdk_window_get_geometry only takes 5
9097 parameters.
44f230aa
SM
9098 (xg_win_to_widget, xg_event_is_for_menubar):
9099 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9100 (xg_set_widget_bg): New function.
9101 (delete_cb): New function.
895009e1 9102 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9103 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9104 (xg_set_background_color): Call xg_set_widget_bg.
9105 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9106 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9107 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9108 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9109 if ! HAVE_GTK3.
9110 (update_frame_tool_bar): Call gtk_widget_hide.
9111 (xg_initialize): Use GDK_KEY_g.
9112
9113 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9114 if ! HAVE_GTK3
9115 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9116
9117 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9118 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9119 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9120
1c2cc4ef
JB
91212011-03-08 Juanma Barranquero <lekktu@gmail.com>
9122
9123 * w32xfns.c (select_palette): Check success of RealizePalette against
9124 GDI_ERROR, not zero.
9125
33383987 9126See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9127
9128;; Local Variables:
9129;; coding: utf-8
aac0c6e3
MR
9130;; End:
9131
acaf905b 9132 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9133
9134 This file is part of GNU Emacs.
9135
9136 GNU Emacs is free software: you can redistribute it and/or modify
9137 it under the terms of the GNU General Public License as published by
9138 the Free Software Foundation, either version 3 of the License, or
9139 (at your option) any later version.
9140
9141 GNU Emacs is distributed in the hope that it will be useful,
9142 but WITHOUT ANY WARRANTY; without even the implied warranty of
9143 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9144 GNU General Public License for more details.
9145
9146 You should have received a copy of the GNU General Public License
9147 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.