Guard against potential configure bug wrt HAVE_GETWD
[bpt/emacs.git] / src / ChangeLog
CommitLineData
1c6f11f4
GM
12012-08-06 Glenn Morris <rgm@gnu.org>
2
1db4583a
GM
3 * sysdep.c: Respect BROKEN_GETWD.
4
1c6f11f4
GM
5 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
6 Let configure handle it.
7 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
8
2b90362b
DA
92012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
10
11 Use GCALIGNMENT where appropriate.
12 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
13 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
14 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
15
5f50daf2
EZ
162012-08-06 Eli Zaretskii <eliz@gnu.org>
17
18 * w32menu.c (set_frame_menubar, initialize_frame_menubar): Don't
19 use FRAME_MENU_BAR_ITEMS as an lvalue.
20
cbcc7007
SM
212012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
22
23 * buffer.h (struct buffer): Revert `indirections' to a simple int;
24 that should be sufficient for everyone.
25
4d365fa4
JD
262012-08-06 Jan Djärv <jan.h.d@swipnet.se>
27
28 * keyboard.c (timer_check_2): Add break so timer_check returns next
29 timeout.
30
dd86bd82
DA
312012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
32
33 Fix Windows build errors introduced after converting to WGET and WSET.
34 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
35 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
36
054e1668
JD
372012-08-06 Jan Djärv <jan.h.d@swipnet.se>
38
39 * nsterm.m (ns_frame_rehighlight): Use FSET.
40
41 * nsmenu.m (ns_update_menubar): Use FSET.
42
21238f11
DA
432012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
44
45 Separate read and write access to Lisp_Object slots of Lisp_Process.
46 * process.h (PGET, PSET): New macros similar to AREF and ASET.
47 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
48
077288cf
DA
492012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
50
51 Separate read and write access to Lisp_Object slots of struct window.
52 * window.h (WGET, WSET): New macros similar to AREF and ASET.
53 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
54 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
55 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
56 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
57 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
58 Adjust users.
59
71688bd7
DA
602012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
61
62 Fix Windows build errors introduced after converting to FGET and FSET.
63 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
64 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
65 (w32_judge_scroll_bars): Change to use FSET.
66 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
67
f99bac93
DA
682012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
69
70 Fix replacement typo.
71 * window.c (replace_window): Set root_window instead of
72 selected_window. This fixes a total window subsystem
73 malfunction reported by Bastien Guerry <bzg@gnu.org>.
74
8c2a0f2d
GM
752012-08-06 Glenn Morris <rgm@gnu.org>
76
77 * lisp.mk (lisp): Add language/persian.elc.
78
edd74c35
DA
792012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
80
81 Separate read and write access to Lisp_Object slots of struct frame.
82 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
83 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
84 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
85 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
86 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
87
8671676c
AS
882012-08-05 Andreas Schwab <schwab@linux-m68k.org>
89
90 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
91
663e2b3f
DA
922012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
93
94 Generalize common compile-time constants.
95 * lisp.h (header_size, bool_header_size, word_size): Now here.
96 (struct Lisp_Vector): Add comment.
97 (struct Lisp_Bool_Vector): Move up to define handy constants.
98 (VECSIZE, PSEUDOVECSIZE): Simplify.
99 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
100 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
101 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
102 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
103 * xfont.c, xmenu.c: Use word_size where appropriate.
104
d32e47af
LM
1052012-08-05 Lawrence Mitchell <wence@gmx.li>
106
107 * search.c (Freplace_match): Treat \? in the replacement text
108 literally (Bug#8161).
109
e5d9c0d1
CY
1102012-08-05 Chong Yidong <cyd@gnu.org>
111
112 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
113 * frame.c (Vdelete_frame_functions):
114 * emacs.c (Vkill_emacs_hook): Doc fix.
115
8da0576b
EZ
1162012-08-04 Eli Zaretskii <eliz@gnu.org>
117
118 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
119 --with-x-toolkit=no builds.
120 Reported by Carsten Mattner <carstenmattner@gmail.com>.
121
02676e5d
CY
1222012-08-04 Chong Yidong <cyd@gnu.org>
123
124 * syntax.c (Fmodify_syntax_entry): Doc fix.
125
97147da9
EZ
1262012-08-04 Eli Zaretskii <eliz@gnu.org>
127
76151e2c
EZ
128 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
129 * w32.c (init_environment): Change the default values of many
130 environment variables in dflt_envvars[] to NULL, to avoid pushing
131 them into environment when they were not already defined. Remove
132 the code that deletes site-lisp subdirectories from the default
133 value of EMACSLOADPATH, as it is no longer needed.
134 (check_windows_init_file): Now external, not static. Use
135 Vload_path as is, without adding anything, as this function is now
136 called when Vload_path is already set up.
137
138 * w32.h (check_windows_init_file): Add prototype.
139
140 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
141 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
142 compatibility with Posix platforms.
143 (main): Move the call to check_windows_init_file to here from
144 w32.c.
145 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
146 any, in the DEFALT argument into the root of the Emacs build or
147 installation tree, as appropriate.
148
149 * callproc.c (init_callproc_1): Call decode_env_path instead of
150 doing its equivalent by hand.
151 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
152 the code that sets Vexec_path run on MS-Windows.
153
154 * lread.c (init_lread): Add comments to #ifdef's.
155
97147da9
EZ
156 * msdos.c (dos_set_window_size, IT_update_begin)
157 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
158 instead of direct references.
159
185ee146
PE
1602012-08-04 Paul Eggert <eggert@cs.ucla.edu>
161
162 Export DEFAULT_REHASH_* to GDB.
163 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
164 Now constants, not macros.
165
8834c57a
PE
1662012-08-03 Paul Eggert <eggert@cs.ucla.edu>
167
98c6f1e3
PE
168 Remove unnecessary casts involving pointers.
169 These casts are no longer needed now that we assume C89 or later,
170 since they involve casting to or from void *.
171 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
172 (make_pure_float, make_pure_vector):
173 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
174 * macros.c (Fstart_kbd_macro):
175 * menu.c (find_and_return_menu_selection):
176 * minibuf.c (read_minibuf_noninteractive):
177 * sysdep.c (closedir):
178 * xdisp.c (x_produce_glyphs):
179 * xfaces.c (compare_fonts_by_sort_order):
180 * xfns.c (x_real_positions, select_visual):
181 * xselect.c (x_stop_queuing_selection_requests)
182 (x_get_window_property, x_get_window_property_as_lisp_data):
183 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
184 Remove unnecessary pointer casts.
185 * alloc.c (record_xmalloc): New function.
186 * lisp.h (record_xmalloc): New decl.
187 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
188 more like a function. This is because the pointer cast is not
189 needed. All uses changed.
190 * print.c (print_string, print_error_message): Avoid length recalc.
191
8834c57a
PE
192 Improve fix for macroexp crash with debugging (Bug#12118).
193 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
194 ARRAY_MARK_FLAG when checking subscripts, because ASET is
195 not supposed to be invoked from the garbage collector.
196 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
197 (gc_aset): New function, which is like ASET but can be
198 used in the garbage collector.
199 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
200 (set_hash_index): Use it instead of ASET.
201
6dad7178
EZ
2022012-08-03 Eli Zaretskii <eliz@gnu.org>
203
204 Support symlinks on latest versions of MS-Windows.
205 * w32.c: Include winioctl.h and aclapi.h.
206 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
207 (revert_to_self): Forward declarations of static functions.
208 <static BOOL g_b_init_get_security_info>:
209 <g_b_init_create_symbolic_link>: New static flags.
210 (globals_of_w32): Initialize them to zero.
211 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
212 (map_w32_filename): Improve commentary. Simplify switch.
213 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
214 headers (most versions of MinGW w32api don't).
215 (get_security_info, create_symbolic_link)
216 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
217 New functions.
218 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
219 in the argument file name.
220 (sys_access): Call unc_volume_file_attributes only if
221 GetFileAttributes fails with network-related error codes.
222 (sys_rename): Diagnose renaming of a symlink when the user doesn't
223 have the required privileges.
224 (get_file_security_desc_by_name): Renamed from
225 get_file_security_desc.
226 (stat_worker): New function, with most of the guts of 'stat', and
227 with addition of handling of symlinks and support for 'lstat'. If
228 possible, get file's attributes and security information by
229 handle, not by name. Produce S_IFLNK bit for symlinks, when
230 called from 'lstat'.
231 (stat, lstat): New functions, call 'stat_worker'.
232 (symlink, readlink, careadlinkat): Rewritten to create and resolve
233 symlinks when the underlying filesystem supports them.
234
f162bcc3
PE
2352012-08-02 Paul Eggert <eggert@cs.ucla.edu>
236
79ea6c20
PE
237 Fix macroexp crash on Windows with debugging (Bug#12118).
238 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
239 checking subscripts; problem introduced with the recent
240 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
241 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
242 since it's used in non-static inline functions now.
243
c0ce93fd
PE
244 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
245 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 246
f162bcc3
PE
247 Use C99-style 'extern inline' if available.
248 * buffer.h (BUFFER_INLINE):
249 * category.h (CATEGORY_INLINE):
250 * character.h (CHARACTER_INLINE):
251 * charset.h (CHARSET_INLINE):
252 * composite.h (COMPOSITE_INLINE):
253 * dispextern.h (DISPEXTERN_INLINE):
254 * lisp.h (LISP_INLINE):
255 * systime.h (SYSTIME_INLINE):
256 New macro, replacing 'static inline' in this header.
257 * buffer.h, category.h, character.h, charset.h, composite.h:
258 * dispextern.h, lisp.h, systime.h:
259 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
260 * alloc.c (LISP_INLINE):
261 * buffer.c (BUFFER_INLINE):
262 * category.c (CATEGORY_INLINE):
263 * character.c (CHARACTER_INLINE):
264 * charset.c (CHARSET_INLINE):
265 * composite.c (COMPOSITE_INLINE):
266 * dispnew.c (DISPEXTERN_INLINE):
267 * sysdep.c (SYSTIME_INLINE):
268 Define to EXTERN_INLINE, so that the corresponding functions
269 are compiled into code.
270 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
271 (INLINE_HEADER_END): New macros.
272 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
273 since it's used in non-static inline functions now.
a8333d03 274 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 275
837b365b
GM
2762012-08-02 Glenn Morris <rgm@gnu.org>
277
d66b744d
GM
278 * s/: Remove empty directory.
279
837b365b
GM
280 * s/ms-w32.h: Move to ../nt/inc.
281 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
282 Update for new ms-w32.h location.
283
13294f95
PE
2842012-08-02 Paul Eggert <eggert@cs.ucla.edu>
285
286 Port to Solaris 8.
287 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
288
90df0db3
GM
2892012-08-02 Glenn Morris <rgm@gnu.org>
290
291 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
292 hard-coding the path separator.
293
4939150c
PE
2942012-08-01 Paul Eggert <eggert@cs.ucla.edu>
295
296 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
297 This how ASET and AREF are supposed to work, and makes
298 it easier to think about future improvements. See
299 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
300 * charset.h (set_charset_attr): New function.
301 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
302 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
303 (aref_addr): New function. All uses of &AREF(...) changed.
304 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
305 (set_hash_index): New functions. All lvalue-style uses of
306 HASH_KEY etc. changed.
307 * keyboard.c (set_prop): New function. All lvalue-style uses
308 of PROP changed.
309
947b2afd
AA
3102012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
311
312 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
313 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
314 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
315 * nsfns.m (ns_set_name_as_filename): Likewise.
316 * nsmenu.m (ns_update_menubar): Likewise.
317 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
318
4f5d0325
EZ
3192012-08-01 Eli Zaretskii <eliz@gnu.org>
320
2008beae
EZ
321 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
322 Adapt to latest changes in field names of the corresponding Lisp
288479f6 323 objects.
2008beae 324
4f5d0325
EZ
325 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
326
fe3cc771
GM
3272012-08-01 Glenn Morris <rgm@gnu.org>
328
329 * s/msdos.h: Remove file.
330 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
331 * Makefile.in (S_FILE): Remove.
332 (config_h): Remove S_FILE.
333
c90acc54
JB
3342012-08-01 Juanma Barranquero <lekktu@gmail.com>
335
336 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
337 Remove; moved to nt/config.nt.
338
d8a05828
DA
3392012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
340
341 Use INTERNAL_FIELD for conses and overlays.
342 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
343 Remove obsolete comment.
344 (MVAR): New macro.
345 (struct Lisp_Overlay): Use INTERNAL_FIELD.
346 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
347
8271d590
DA
3482012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
349
350 Use INTERNAL_FIELD for symbols.
351 * lisp.h (SVAR): New macro. Adjust users.
352 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
353 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
354
3193acd2
DA
3552012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
356
357 Use INTERNAL_FIELD for processes.
358 * process.h (PVAR): New macro. Adjust style.
359 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
360 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
361
3a45383a
DA
3622012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
363
364 Use INTERNAL_FIELD for windows.
365 * window.h (WVAR): New macro.
366 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
367 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
368 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
369 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
370 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
371 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
372
c1dbc63c
PE
3732012-08-01 Paul Eggert <eggert@cs.ucla.edu>
374
375 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
376
5c0c0e8a
GM
3772012-08-01 Glenn Morris <rgm@gnu.org>
378
379 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
380 Move to configure.ac.
381
552a99b4
JB
3822012-08-01 Juanma Barranquero <lekktu@gmail.com>
383
384 * makefile.w32-in (CONFIG_H): Update dependencies.
385 (CONF_POST_H): New macro.
386
387 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
388
8d8e2dfe
GM
3892012-07-31 Glenn Morris <rgm@gnu.org>
390
bc96620a
GM
391 * Makefile.in (S_FILE): No longer set by configure.
392
476b1b2d
GM
393 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
394 is available.
395 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
396
b2c7a106
GM
397 * process.h (NULL_DEVICE):
398 * emacs.c (SEPCHAR):
399 * editfns.c (USER_FULL_NAME): Let configure set them.
400
d53d062a
GM
401 * s/README, s/template.h: Remove files.
402
4515017f
GM
403 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
404
8d8e2dfe
GM
405 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
406 Move to configure.ac.
407
5b20b3cc
EZ
4082012-07-31 Eli Zaretskii <eliz@gnu.org>
409
1e0afd9a
EZ
410 * .gdbinit (xframe): Adapt to introduction of FVAR and the
411 resulting renaming of 'struct frame' members.
412
5b20b3cc
EZ
413 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
414
415 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
416 after introduction of FVAR.
417
f1310128
JD
4182012-07-31 Jan Djärv <jan.h.d@swipnet.se>
419
79e721e0
JD
420 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
421
422 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
423 instead of compositeToPoint.
424 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
425
8d7c7eed 426 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 427
e34f7f79
DA
4282012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
429
430 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
431 * lisp.h (INTERNAL_FIELD): New macro.
432 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
433 (BVAR): Change to use INTERNAL_FIELD.
434 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
435 (KVAR): Change to use INTERNAL_FIELD.
436 * frame.h (FVAR): New macro.
437 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
438 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
439 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
440 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
441 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
442
c09bfb2f
DA
4432012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
444
445 Miscellaneous fixes for non-default X toolkits.
446 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
447 * xterm.c (x_frame_of_widget): Remove redundant prototype.
448 Move under #ifdef USE_LUCID.
449 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
450 definition and usage to avoid warnings.
451
14c114ae
JD
4522012-07-31 Jan Djärv <jan.h.d@swipnet.se>
453
454 * nsterm.m (openFiles): Fix previous checkin.
455
3bd21e82
PE
4562012-07-31 Paul Eggert <eggert@cs.ucla.edu>
457
458 * indent.c (compute_motion): Remove unused local.
459
c1529ded
GM
4602012-07-31 Glenn Morris <rgm@gnu.org>
461
400d5621
GM
462 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
463
268e2432
GM
464 * conf_post.h [USG5_4]:
465 Move remaining contents of s/usg5-4-common.h here.
466 * s/usg5-4-common.h: Remove file.
467
7552f3ee
GM
468 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
469 * s/irix6-5.h: Remove file.
470
6a381852
GM
471 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
472 * s/darwin.h: Remove file.
473
c1529ded
GM
474 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
475 * s/hpux10-20.h: Remove file, which is now empty.
476
b429a4ee
GM
4772012-07-30 Glenn Morris <rgm@gnu.org>
478
479 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
480 * Makefile.in (config_h): Add conf_post.h.
481 * makefile.w32-in (CONFIG_H): Add conf_post.h.
482
adff3182
JD
4832012-07-30 Jan Djärv <jan.h.d@swipnet.se>
484
485 * nsterm.m (ns_do_open_file): New variable.
b9031d69 486 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
487 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
488 files only if ns_do_open_file.
489
c32af1e4
PE
4902012-07-30 Paul Eggert <eggert@cs.ucla.edu>
491
7393bcbb
PE
492 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
493 This no-op macro hasn't been needed for many years.
494 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
495
c32af1e4
PE
496 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
497 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
498 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
499 gdb_make_enums_visible.
500 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
501 (DIRECTORY_SEP): Now a constant, not a macro.
502
302fc036
EZ
5032012-07-30 Eli Zaretskii <eliz@gnu.org>
504
505 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
506 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
507
508 * w32term.c <w32_keyboard_codepage>: Renamed from
509 keyboard_codepage and now external. All users changed.
510
511 * w32term.h: Add declaration of w32_keyboard_codepage.
512
513 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
514 the codepage to translate keys to Unicode. If this argument is
515 -1, use the value returned by GetConsoleCP. All callers changed.
516
88fb40b4
PE
5172012-07-30 Paul Eggert <eggert@cs.ucla.edu>
518
0aee6912
PE
519 Update .PHONY listings in makefiles.
520 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
521 bootstrap-clean, distclean, maintainer-clean, versioclean,
522 extraclean, frc.
523
88fb40b4
PE
524 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
525 This is a bit clearer. Fix some commentary typos.
526
0a763bd1
GM
5272012-07-30 Glenn Morris <rgm@gnu.org>
528
32bac6d6
GM
529 * s/netbsd.h: Let configure include signal.h if needed.
530 Remove file, which is now empty.
531
b65e7c46
GM
532 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
533 Let configure set them.
534 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
535 No more need to undefine.
0a763bd1 536
169304bd
AS
5372012-07-30 Andreas Schwab <schwab@linux-m68k.org>
538
539 * keymap.c (Fkey_description): Don't remove 0x80 bit from
540 non-single-byte char when adding meta modifier. (Bug#12090)
541
6cd7a139
DA
5422012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
543
544 Convert safe_call to use variable number of arguments.
545 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
546 (safe_call2): Fix comment.
547 * lisp.h (safe_call): Adjust prototype.
548 * coding.c (encode_coding_object): Change to use safe_call2.
549 * xfaces.c (merge_face_heights): Change to use safe_call1.
550
d34d6ffc
GM
5512012-07-30 Glenn Morris <rgm@gnu.org>
552
7b8a48e4 553 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 554 does that unconditionally. Remove file, which is now empty.
7b8a48e4 555
d34d6ffc
GM
556 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
557 Remove empty files.
558
03a660a6
PE
5592012-07-30 Paul Eggert <eggert@cs.ucla.edu>
560
561 Export to GDB most of lisp.h's remaining object-like macros.
562 * lisp.h (min, max): Move earlier, because they're used earlier now.
563 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
564 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
565 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
566 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
567 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
568 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
569 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
570 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
571 Now constants, for GDB. They need not be macros.
572 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
573 Now constants, for GDB, as well as macros, for static initializers.
574 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
575 Move to after the definition of struct Lisp_Char_Table,
576 since the former now needs that type defined.
577 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
578 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
579 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
580 New enums, for gdb_make_enums_visible.
581 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 582 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
583 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
584 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
585 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
586 enum maxargs, enum MAX_ALLOCA.
587 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
588 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
589 no longer needed, now that they are done in lisp.h.
590
e499d0ee
DA
5912012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
592
593 Cleanup string bytes checking.
594 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
595 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
596 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
597 (check_sblock, compact_small_strings): Simplify.
598
d5040d2d
PE
5992012-07-29 Paul Eggert <eggert@cs.ucla.edu>
600
601 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
602 These macros are confusing and no longer need to be defined, as
603 the enum values now suffice. All uses replaced with definiens.
604 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
605
7f259ae6
JB
6062012-07-29 Juanma Barranquero <lekktu@gmail.com>
607
608 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
609 ($(BLD)/w32console.$(O)): Update dependencies.
610
7e63e0c3
DA
6112012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
612
613 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
614 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
615 time. Adjust users.
616 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
617
ffd817eb
JD
6182012-07-29 Jan Djärv <jan.h.d@swipnet.se>
619
620 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
621 setting sitelisp (Bug#12010).
622
417a7a0e
EZ
6232012-07-29 Eli Zaretskii <eliz@gnu.org>
624
625 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
626
627 * w32heap.c (cache_system_info):
628 * w32.c (sys_rename):
629 * w32proc.c (find_child_console, sys_kill): All users changed.
630
387d4d92
PE
6312012-07-29 Paul Eggert <eggert@cs.ucla.edu>
632
633 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
634
55a6cca6
EZ
6352012-07-29 Eli Zaretskii <eliz@gnu.org>
636
637 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
638
dbcf001c
DA
6392012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
640
641 Cleanup statistics calculation in Fgarbage_collect.
642 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
643 zombies percentage calculation. Simplify elapsed time calculation.
644
e2688e4a
DA
6452012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
646
647 Generalize marker debugging code under MARKER_DEBUG and use eassert.
648 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
649 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
650 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
651 (replace_range, replace_range_2, del_range_2): Change to eassert.
652 * marker.c (byte_char_debug_check): Adjust style.
653
b46a6a83
PE
6542012-07-29 Paul Eggert <eggert@cs.ucla.edu>
655
656 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
657 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
658 long-ago-commented-out code that talks about "WIN32".
659 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
660 All uses changed.
661
e32a5799
PE
6622012-07-28 Paul Eggert <eggert@cs.ucla.edu>
663
664 Use Gnulib stdalign module (Bug#9772, Bug#9960).
665 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
666 Simplify by using alignof.
667 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
668 * lisp.h: Include <stdalign.h>.
669 (GCALIGNMENT): New macro and constant.
670 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
671 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
672 (stdalign): New macro, if not already defined.
673
df81cd29
EZ
6742012-07-28 Eli Zaretskii <eliz@gnu.org>
675
01bd1b0d
EZ
676 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
677 * w32inevt.c: Include w32inevt.h.
678 (w32_read_console_input): New inline function, calls either
679 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
680 w32_console_unicode_input.
681 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
682 (w32_kbd_patch_key, key_event): Use the codepage returned by
683 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
684 (key_event): use uChar.UnicodeChar only if
685 w32_console_unicode_input is non-zero.
686
687 * w32console.c: Include w32heap.h.
688 <w32_console_unicode_input>: New global variable.
689 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
690 family of Windows, zero otherwise.
691
692 * w32inevt.h: Declare w32_console_unicode_input.
693
df81cd29
EZ
694 * xdisp.c (init_iterator): Don't reference tip_frame in a build
695 --without-x. (Bug#11742)
696
c20fdd9e
PE
6972012-07-27 Paul Eggert <eggert@cs.ucla.edu>
698
699 Adjust GDB to reflect pvec_type changes (Bug#12036).
700 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
701 2012-07-04 changes to pseudovector representation. Problem
702 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
703
32770973 7042012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
705
706 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
707 bus address.
708 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
709
3438fe21
EZ
7102012-07-27 Eli Zaretskii <eliz@gnu.org>
711
bcfbc9de
EZ
712 * alloc.c (listn): Fix the order the arguments are consed onto the
713 list.
714
3438fe21
EZ
715 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
716 enumeration constants, as PURE and HEAP are too general, and clash
717 with other headers and sources, such as gmalloc.c and the
718 MS-Windows system headers. All users changed.
719
eeaea515
DA
7202012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
721
722 Revert last save_excursion_save and save_excursion_restore changes.
723 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
724 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
725
073c88c2
DA
7262012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
727
728 Fix recently-introduced typos in Windows port.
729 Reported by Martin Rudalics <rudalics@gmx.at>.
730 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 731 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 732
4706125e
PE
7332012-07-27 Paul Eggert <eggert@cs.ucla.edu>
734
735 Improve GDB symbol export (Bug#12036).
736 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
737 arms of an 'if', not using conditional expressions; otherwise GDB
738 complains about the types in the unevaluated arm when the argument
739 is an integer literal.
740 (xgetint): Simplify expression.
741 * alloc.c (gdb_make_enums_visible): New constant. This ports to
742 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
743 Zaretskii in <http://bugs.gnu.org/12036#13>.
744 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
745 needed now that we have gdb_make_enums_visible.
746 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
747 (enum enum_USE_LSB_TAG):
748 New enum types, packaging up enums that need to be exported to GDB.
749
694b6c97
DA
7502012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
751
752 Utility function to make a list from specified amount of objects.
753 * lisp.h (enum constype): New datatype.
754 (listn): New prototype.
755 * alloc.c (listn): New function.
756 (Fmemory_use_count, syms_of_alloc): Use it.
757 * buffer.c (syms_of_buffer): Likewise.
758 * callint.c (syms_of_callint): Likewise.
759 * charset.c (define_charset_internal): Likewise.
760 * coding.c (syms_of_coding): Likewise.
761 * keymap.c (syms_of_keymap): Likewise.
762 * search.c (syms_of_search): Likewise.
763 * syntax.c (syms_of_syntax): Likewise.
764 * w32.c (init_environment): Likewise.
765 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
766 * xdisp.c (syms_of_xdisp): Likewise.
767 * xfns.c (syms_of_xfns): Likewise.
768
6195f384
DA
7692012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
770
771 Fast save_excursion_save and save_excursion_restore.
772 * lisp.h (struct Lisp_Excursion): New data type.
773 (PVEC_EXCURSION): New pseudovector type.
774 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
775 to deal with it. Adjust comments.
776 (init_marker, attach_marker): New prototype.
777 (unchain_marker): Adjust prototype.
778 * marker.c (attach_marker): Change to global.
779 (init_marker): New function.
780 * alloc.c (Fmake_marker, build_marker): Use it.
781 (build_marker): More easserts.
782 (mark_object): Handle struct Lisp_Excursion.
783 * editfns.c (save_excursion_save, save_excursion_restore):
784 Reimplement to use struct Lisp_Excursion. Add comments.
785
5eceb8fb
PE
7862012-07-26 Paul Eggert <eggert@cs.ucla.edu>
787
788 Fix export of symbols to GDB (Bug#12036).
789 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
790 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
791 emacs.c, as this is a more-suitable home. Had this been done earlier
792 the fix for 12036 would have avoided some of the problems noted in
793 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
794 would have been more obvious.
562157c8
PE
795 * emacs.c: Do not include <verify.h>; no longer needed.
796 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
797 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
798 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
799 Remove; now done in lisp.h.
800 * lisp.h (PUBLISH_TO_GDB): New macro.
801 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
802 (DATA_SEG_BITS): Use it.
803 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
804 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
805 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
806 not be usable in #if. This simplifies things.
807
d6749401
JB
8082012-07-26 Juanma Barranquero <lekktu@gmail.com>
809
810 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
811
1781b9e9
PE
8122012-07-26 Paul Eggert <eggert@cs.ucla.edu>
813
d89518db 814 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
815 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
816 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
817 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
818 Adjust to changes in lisp.h and emacs.c, by using
819 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
820 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
821 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
822 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
823 instead of gdb_valbits.
824 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
825 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
826 instead of gdb_array_mark_flag.
827 (xboolvector): Get size from $->size, not $->header.size.
828 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
829 (xreload, hook-run, hookpost-run): Remove.
830 * emacs.c: Include <verify.h>.
831 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
832 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
833 Remove.
834 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
835 (gdb_USE_LSB_TAG): New enum constants.
836 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
837 Also define these as enum constants, so they're visible to GDB.
838 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
839 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
840 as constants, so they're visible to GDB.
841 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
842 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
843 Now enum constants, not macros, so they're visible to GDB.
844 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
845 more convenient now. All uses changed.
846 (VALMASK) [USE_LSB_TAG]: Also define in this case.
847 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
848
3628596a
DA
8492012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
850
851 Explicitly free restriction data that are not needed anymore.
852 * editfns.c (save_restriction_restore): Free restriction data.
853
7abaf5cc
SM
8542012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
855
856 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
857 add argument, tune behavior, and adjust all callers.
858
71f88e00
PE
8592012-07-25 Paul Eggert <eggert@cs.ucla.edu>
860
861 Use typedef for EMACS_INT, EMACS_UINT.
862 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
863 than macros. This simplifies debugging in the usual case, since
864 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
865 and it allows expressions involving EMACS_INT casts.
866 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
867
57ec3034
JD
8682012-07-25 Jan Djärv <jan.h.d@swipnet.se>
869
870 * nsterm.m (ns_read_socket): Return early if there is a modal
871 window (Bug#12043).
872
8137e7b3
MR
8732012-07-25 Martin Rudalics <rudalics@gmx.at>
874
875 * frame.c (Fredirect_frame_focus): In doc-string don't mention
876 that FOCUS-FRAME can be omitted.
877
04e9897c
DA
8782012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
879
880 Adjust buffer text indirection counters at the end of Fkill_buffer.
881 * buffer.c (Fkill_buffer): Adjust indirection counters when the
882 buffer is definitely dead. This should really fix an issue reported
883 by Christoph Scholtes again. (Bug#12007).
884 (init_buffer_once): Initialize indirection counters of
885 buffer_defaults and buffer_local_symbols (for sanity and safety).
886
8a0484e1
EZ
8872012-07-24 Eli Zaretskii <eliz@gnu.org>
888
889 * xdisp.c (init_iterator): Don't compute dimensions of truncation
890 and continuation glyphs on tooltip frames, leave them at zero.
891 Avoids continued lines in tooltips. (Bug#11832)
892
fa691a83
DA
8932012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
894
895 Simplify copy_overlay.
04e9897c 896 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
897 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
898
436bc8e0
EZ
8992012-07-23 Eli Zaretskii <eliz@gnu.org>
900
901 * print.c (print_object): Don't crash when a frame's name is nil
902 or invalid. (Bug#12025)
903
904 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
905 it signals an error when a tooltip frame is being created.
906
d7a7fda3
DA
9072012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
908
909 Cleanup miscellaneous objects allocation and initialization.
910 * alloc.c (allocate_misc): Change to static. Add argument to
911 specify the subtype. Adjust comment and users.
912 (build_overlay): New function.
913 * buffer.c (copy_overlays, Fmake_overlay): Use it.
914 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
915 (allocate_misc): Remove prototype.
916 (build_overlay): Add prototype.
917
9182012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
919
920 Swap buffer text indirection counters in Fbuffer_swap_text.
921 * buffer.c (Fbuffer_swap_text): Swap indirections too.
922 This avoids crash reported by Christoph Scholtes at
923 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
924
9d7fa573
JD
9252012-07-22 Jan Djärv <jan.h.d@swipnet.se>
926
927 * nsmenu.m (Popdown_data): New struct.
928 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
929 free Popdown_data.
930 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
931 (initWithContentRect): Make imgView and contentView non-static
932 and autorelease them. Also autorelease img and matrix (Bug#12005).
933 (dealloc): Remove (Bug#12005).
934
0dd6d66d
DA
9352012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
936
937 Adjust consing_since_gc when objects are explicitly freed.
938 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
939 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
940 (free_cons, free_misc): Subtract object size from consing_since_gc.
941
d36d71df
DA
9422012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
943
944 Simplify and cleanup markers positioning code.
945 * marker.c (attach_marker): More useful eassert.
946 (live_buffer, set_marker_internal): New function.
947 (Fset_marker, set_marker_restricted): Use set_marker_internal.
948 (set_marker_both, set_marker_restricted_both): Use live_buffer.
949
fb9ea40f
PE
9502012-07-22 Paul Eggert <eggert@cs.ucla.edu>
951
952 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
953 as it's limited by the amount of memory, not by INT_MAX.
954
2d5c5f7d
EZ
9552012-07-21 Eli Zaretskii <eliz@gnu.org>
956
07fb592e
EZ
957 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
958 in special-event-map. See the discussion at
959 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
960 for the reasons.
961
37a9eac8 962 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
963 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
964 Fabrice Popineau <fabrice.popineau@supelec.fr>.
965
c4328746
JD
9662012-07-21 Jan Djärv <jan.h.d@swipnet.se>
967
968 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 969 (conversationIdentifier): Return value is NSInteger.
784051c4 970 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 971
6e5d1c12
CY
9722012-07-21 Chong Yidong <cyd@gnu.org>
973
974 * window.c (decode_any_window): Signal an error if the window is
975 on a dead frame (Bug#11984).
976
9928463d
DA
9772012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
978
979 Add indirection counting to speed up Fkill_buffer.
980 * buffer.h (struct buffer): New member.
981 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
982 (Fmake_indirect_buffer): Set indirection counter to -1, increment
983 base buffer indirection counter.
984 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
985 (Fkill_buffer): Adjust indirection counters as needed, don't walk
986 through buffer list if indirection counter is 0.
987
f8643a6b
DA
9882012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
989
990 Extend the value returned by Fgarbage_collect with heap statistics.
991 * alloc.c (Qheap): New symbol.
992 (syms_of_alloc): DEFSYM it.
993 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
994 (Fmemory_free): Remove.
995 (syms_of_alloc): Don't defsubr it.
996 * buffer.c (Fcompact_buffer): Remove.
997 (syms_of_buffer): Don't defsubr it.
998
dac616ff
DA
9992012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1000
1001 Make maybe_gc inline.
1002 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1003 * lisp.h (consing_since_gc, gc_relative_threshold)
1004 (memory_full_cons_threshold): Revert declaration.
1005 (maybe_gc): Remove prototype, define as inline.
1006 * alloc.c: Remove old commented-out code.
1007 (consing_since_gc, gc_relative_threshold)
1008 (memory_full_cons_threshold): Revert to global.
1009 (maybe_gc): Remove.
1010
d7ea76b4
DA
10112012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1012
1013 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1014 * lisp.h (build_unibyte_string): New function.
1015 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1016 * sysdep.c, w32fns.c, xfns.c: Use it.
1017 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1018 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1019 Adjust users accordingly.
1020 * font.h (font_open_by_name): Adjust prototype.
1021
765e61e3
DA
10222012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1023
1024 Cleanup calls to Fgarbage_collect.
1025 * lisp.h (maybe_gc): New prototype.
1026 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1027 Remove declarations.
1028 * alloc.c (maybe_gc): New function.
1029 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1030 Make them static.
1031 * bytecode.c (MAYBE_GC): Use maybe_gc.
1032 * eval.c (eval_sub, Ffuncall): Likewise.
1033 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1034 to avoid dependency from auto-save feature.
1035
52b852c7
PE
10362012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1037
1038 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1039 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1040 'for_each_per_buffer_object_at'.
1041 All uses changed. It's better to use upper-case for macros that
1042 cannot be implemented as functions, to give the reader a clue
1043 that they're special.
1044
5db81e33
SM
10452012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1046
1047 * alloc.c (Fgarbage_collect): Tweak docstring.
1048
5b835e1d
DA
10492012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1050
1051 Tweak the value returned from Fgarbage_collect again.
1052 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1053 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1054 Adjust documentation.
1055 (total_vector_bytes): Rename to total_vector_slots, adjust
1056 accounting.
1057 (total_free_vector_bytes): Rename to total_free_vector_slots,
1058 adjust accounting.
1059 (Qstring_bytes, Qvector_slots): New symbols.
1060 (syms_of_alloc): DEFSYM them.
1061
9cd47b72
DA
10622012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1063
1064 Buffer compaction primitive which may be used from Lisp.
1065 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1066 (syms_of_buffer): Register Fcompact_buffer.
1067 * alloc.c (Fgarbage_collect): Use compact_buffer.
1068 * buffer.h (compact_buffer): New prototype.
1069 (struct buffer_text): New member.
1070
d17337e5
DA
10712012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1072
1073 New macro to iterate over all buffers, miscellaneous cleanups.
1074 * lisp.h (all_buffers): Remove declaration.
1075 * buffer.h (all_buffers): Add declaration, with comment.
1076 (for_each_buffer): New macro.
1077 * alloc.c (Fgarbage_collect, mark_object): Use it.
1078 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1079 (init_buffer): Likewise.
1080 * data.c (Fset_default): Likewise.
1081 * coding.c (code_conversion_restore): Remove redundant check
1082 for dead buffer.
1083 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1084
60cfd278
AS
10852012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1086
1087 Fix bug that created negative-length intervals.
1088 * intervals.c (merge_interval_right, merge_interval_left):
1089 Do not zero out this interval if it is absorbed by its children,
1090 as this interval's total length doesn't change in that case. See
1091 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1092
d06714cb
PE
10932012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1094
83713154
PE
1095 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1096 when invoking (make-bool-vector N t) and N is a positive
1097 multiple of 8 -- the last 8 bits were mistakenly cleared.
1098
d06714cb
PE
1099 Remove some struct layout assumptions in bool vectors.
1100 * alloc.c (bool_header_size): New constant.
1101 (header_size, word_size): Move earlier, as they're now used earlier.
1102 Use 'word_size' in a few more places, where it's appropriate.
1103 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1104 padding before the data member of a bool vector.
1105 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1106 than doing the check by hand with an abort ().
1107
464d5a5e
SM
11082012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1109
5fbc0409
SM
1110 * eval.c (Fdefvar): Don't check constants since we only set the var if
1111 it's not yet defined anyway (bug#11904).
1112
464d5a5e
SM
1113 * lisp.h (last_undo_boundary): Declare new var.
1114 * keyboard.c (command_loop_1): Set it.
1115 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1116 were auto-added by the command loop (bug#11774).
1117
8dc2e44a
AS
11182012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1119
1120 * w32font.c (Qsymbol): Remove local definition.
1121 (syms_of_w32font): Don't DEFSYM it.
1122
169925ec
DA
11232012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1124
1125 Fix sweep_vectors to handle large bool vectors correctly.
1126 * alloc.c (sweep_vectors): Account total_vector_bytes for
1127 bool vectors larger than VBLOCK_BYTES_MAX.
1128
5fbfb018
CY
11292012-07-18 Chong Yidong <cyd@gnu.org>
1130
1131 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1132 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1133
3ab6e069
DA
11342012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1135
1136 Return more descriptive data from Fgarbage_collect.
1137 Suggested by Stefan Monnier in
1138 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1139 * alloc.c (bounded_number): New function.
1140 (total_buffers, total_vectors): New variable.
1141 (total_string_size): Rename to total_string_bytes, adjust users.
1142 (total_vector_size): Rename to total_vector_bytes, adjust users.
1143 (sweep_vectors): Account total_vectors and total_vector_bytes.
1144 (Fgarbage_collect): New return value. Adjust documentation.
1145 (gc_sweep): Account total_buffers.
1146 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1147 (VECTOR_SIZE): Remove.
1148 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1149 (Qinterval, Qmisc): New symbols.
1150 (syms_of_data): Initialize them.
1151 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1152 (Qcons, Qbuffer): New declarations.
1153
6d02fe5b
PE
11542012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1155
1156 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1157 Round up, not down. Improve doc.
1158
b7ffe040
DA
11592012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1160
1161 Restore old code in allocate_string_data to avoid Faset breakage.
1162 Reported by Julien Danjou <julien@danjou.info> in
1163 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1164 * alloc.c (allocate_string_data): Restore old code with minor
1165 adjustments, fix comment to explain this subtle issue.
1166
4dc7c8d5
SM
11672012-07-17 Eli Zaretskii <eliz@gnu.org>
1168
1169 Remove FILE_SYSTEM_CASE.
1170 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1171
1172 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1173 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1174 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1175 call-process-region passes it through expand-file-name.
1176
1177 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1178
11792012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1180
1181 Fix crash when creating indirect buffer (Bug#11917)
1182 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1183 Don't handle unbound variables specially if non-zero.
1184 (Fbuffer_local_variables): Pass zero.
1185 (clone_per_buffer_values): Pass non-zero.
1186
11872012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1188
1189 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1190 to make the loop interruptible.
1191
11922012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1193
1194 * gnutls.c (emacs_gnutls_handshake): Only retry if
1195 GNUTLS_E_INTERRUPTED.
1196
cce7fefc
DA
11972012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1198
1199 Cleanup and convert miscellaneous checks to eassert.
1200 * alloc.c (mark_interval): Fix comment, partially rephrase
1201 old comment from intervals.h (see below).
1202 * intervals.c (find_interval, adjust_intervals_for_insertion)
1203 (delete_interval, adjust_intervals_for_deletion)
1204 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1205 Convert to eassert.
1206 (adjust_intervals_for_insertion, make_new_interval):
1207 Remove obsolete and unused code.
1208 * intervals.h (struct interval): Remove obsolete comment.
1209 * textprotp.c (erase_properties): Remove unused code.
1210 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1211 (Fremove_list_of_text_properties): Convert to eassert.
1212
9ea10cc3
CY
12132012-07-17 Chong Yidong <cyd@gnu.org>
1214
1215 * editfns.c (Finsert_char): Doc fix.
1216
3900d5de
DA
12172012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1218
1219 Fix previous change to make Fmemory_free always accurate.
1220 * alloc.c (make_interval): Update total_free_intervals.
1221 (make_float): Likewise for total_free_floats.
1222 (free_cons, Fcons): Likewise for total_free_conses.
1223 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1224 Likewise for total_free_vector_bytes.
1225 (Fmake_symbol): Likewise for total_free_symbols.
1226 (bytes_free): Remove.
1227
7098646f
DA
12282012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1229
1230 Simple free memory accounting feature.
1231 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1232 (sweep_vectors): Accumulate size of free vectors.
1233 (Fgarbage_collect): Setup bytes_free.
1234 (Fmemory_free): New function.
1235 (syms_of_alloc): Register it.
1236
22657b40
DA
12372012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1238
1239 Cleanup overlays checking.
1240 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1241 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1242 eassert and OVERLAYP.
1243 (sort_overlays): Change to use OVERLAYP.
1244
ddfc8813
RK
12452012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1246
1247 * editfns.c (Finsert_char): Make it interactive, and make the
1248 second arg optional. Copy interactive spec and docstring from
1249 ucs-insert.
1250
7c26cf3c
PE
12512012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1252
1253 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1254 Unlike the other wrapped functions, fabs has an unspecified
1255 effect on errno.
1256
5d127af9
JD
12572012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1258
1259 * nsterm.m (keyDown): Interpret flags without left/right bits
1260 as the left key (Bug#11670).
1261
6a0dd1d7
DA
12622012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1263
1264 Remove empty and useless init functions.
1265 * lisp.h (init_character_once, init_fns, init_image)
1266 (init_filelock, init_sound): Remove prototype.
1267 * character.c (init_character_once): Remove.
1268 * filelock.c (init_filelock): Likewise.
1269 * fns.c (init_fns): Likewise.
1270 * image.c (init_image): Likewise.
1271 * sound.c (init_sound): Likewise.
1272 * emacs.c (main): Adjust accordingly.
1273
7a6136fd
DA
12742012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1275
1276 * gtkutil.h: Tiny cleanups.
1277 (use_old_gtk_file_dialog): Remove useless declaration.
1278 (xg_uses_old_file_dialog): Add suggested const attribute.
1279
ce811ad9
EZ
12802012-07-15 Eli Zaretskii <eliz@gnu.org>
1281
1282 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1283 (bidi_paragraph_init): Use it to limit search forward for a strong
1284 directional character in abnormally large paragraphs full of
1285 neutral or weak characters. (Bug#11943)
1286
c9adfeaa
SF
12872012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1288
1289 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1290 the toolbar (Bug#9451).
1291 (xg_make_tool_item): Give the widget event box a transparent
1292 background.
1293
fff62aa9
DA
12942012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1295
1296 Cleanup basic allocation variables and functions.
1297 * alloc.c (ignore_warnings, init_intervals, init_float)
1298 (init_cons, init_symbol, init_marker): Remove.
1299 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1300 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1301 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1302 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1303 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1304 (staticidx, init_alloc_once, init_strings, free_ablock):
1305 Remove redundant initialization.
1306 * fns.c (init_weak_hash_tables): Remove.
1307 * lisp.h (init_weak_hash_tables): Remove prototype.
1308
9730daca
DA
13092012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1310
1311 Use zero_vector where appropriate.
1312 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1313 accordingly.
1314 * lisp.h (zero_vector): New declaration.
1315 * font.c (null_vector): Remove.
1316 (syms_of_font): Remove initialization and staticpro.
1317 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1318 * keymap.c (Faccessible_keymaps): Likewise.
1319
2e2d2a13
LL
13202012-07-15 Leo Liu <sdl.web@gmail.com>
1321
1322 * fringe.c: Fix typo in comments.
1323
cd276f6e
LL
13242012-07-14 Leo Liu <sdl.web@gmail.com>
1325
1326 * fringe.c: Add a new bitmap exclamation-mark.
1327
5a1131d9
EZ
13282012-07-14 Eli Zaretskii <eliz@gnu.org>
1329
1330 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1331
1332 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1333 (HAVE_MENUS): Don't define, defined by editing config.in with
1334 msdos/sed2v2.inp.
1335 (GMALLOC_INHIBIT_VALLOC): Don't define.
1336 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1337
22e983b7
JB
13382012-07-14 Juanma Barranquero <lekktu@gmail.com>
1339
1340 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1341
5b3f250f
GM
13422012-07-14 Glenn Morris <rgm@gnu.org>
1343
1344 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1345 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1346 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1347
33d63ff4
GM
13482012-07-13 Glenn Morris <rgm@gnu.org>
1349
5b633342
GM
1350 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1351
33d63ff4
GM
1352 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1353 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1354
b55b9f85
JD
13552012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1356
0dc8cf50
JD
1357 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1358 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1359 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1360 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1361 where appropriate.
1362 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1363 as boolean expression.
1364 (x_set_window_size): Remove unused variable toolbar.
1365 (ns_get_color_default, ns_mod_to_lisp): Remove.
1366 (ns_mouse_position): Remove unused variables xchar and ychar.
1367 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1368 (ns_set_vertical_scroll_bar): Remove unused variable count.
1369 (ns_delete_terminal): Remove unused variable i.
1370 (ns_term_init): Remove unused variables r, g and b.
1371 (mouseDown): Remove unused variable window.
1372 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1373 (initFrameFromEmacs): Remove unused variable vbextra.
1374 (mouseEntered): Remove unused variables p and dpyinfo.
1375 (mouseExited): Remove unused variables p and r.
1376 (ns_define_frame_cursor, ns_clear_frame_area)
1377 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1378 (menuDown): Assign [sender tag] to variable and cast the variable.
1379
1380 * nsterm.h (menuDown): Add id as type to argument sender.
1381 (ns_display_info_for_name): Add Lisp_Object argument.
1382 (ns_term_init): Add Lisp_Object argument.
1383 (ns_map_event_to_object): Add void argument.
1384 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1385 prototype with arguments and only declare if __OBJC__.
1386 (nxatoms_of_nsselect): Add void argument.
1387 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1388 (ns_alloc_autorelease_pool): Add void argument.
1389 (ns_release_autorelease_pool): Add void* argument.
1390 (ns_get_defaults_value): Add const char* argument.
1391
1392 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1393 (initFromContents): Use SSDATA where appropriate.
1394 (ns_update_menubar): Add braces to ambigous if-else.
1395 (initWithTitle): Put () around assignment in if statement.
1396 (ns_menu_show): Remove unused variables window and keymap.
1397 (update_frame_tool_bar): Remove unused variable selected_p.
1398 (initWithContentRect): Remove unused variable this_cmd_name.
1399
1400 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1401 appropriate.
1402 (setXBMColor): Remove unused variable len.
1403 (setPixmapData): Put () around assignment in loop statement.
1404
1405 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1406 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1407 where appropriate.
1408 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1409 around assignment in loop statement.
1410 (nsfont_open): Remove unused variable i.
1411 (nsfont_open): Remove unused variable len.
1412 (nsfont_draw): Remove unused variable cs.
1413
1414 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1415 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1416 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1417 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1418 (Fns_font_name, Fns_perform_service)
1419 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1420 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1421 (ns_set_name): Remove unused variable view.
1422 (x_set_menu_bar_lines): Remove unused variable olines.
1423 (x_set_tool_bar_lines): Remove unused variable root_window.
1424 (Fns_list_colors): Put () around assignment in while statement.
1425 (Fns_perform_service): Remove unused variable len.
1426 (Fns_display_usable_bounds): Remove unused variable top.
1427 (syms_of_nsfns): Remove unused variable i.
1428
b55b9f85
JD
1429 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1430 memcpy (Bug#11907).
1431
ed9265fc 14322012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1433
1434 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1435 and free it with DestroyExceptionInfo (Bug#11558).
1436
ef099b57
JB
14372012-07-13 Juanma Barranquero <lekktu@gmail.com>
1438
1439 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1440 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1441 Set here, not in nt/config.nt.
1442
ea814a5d
EZ
14432012-07-13 Eli Zaretskii <eliz@gnu.org>
1444
1445 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1446 cursor overflow into the last glyph on display line when the right
1447 fringe is off. (Bug#11832)
1448
1a952767
PE
14492012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1450
1451 * xdisp.c (produce_special_glyphs): Now static.
1452 * dispextern.h (produce_special_glyphs): Remove decl.
1453
983188fd
GM
14542012-07-13 Glenn Morris <rgm@gnu.org>
1455
8d7c7eed 1456 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1457 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1458
983188fd
GM
1459 * s/usg5-4-common.h (USG, USG5):
1460 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1461 * s/sol2-6.h (SOLARIS2):
1462 * s/irix6-5.h (IRIX6_5):
1463 * s/hpux10-20.h (USG, USG5, HPUX):
1464 * s/gnu-linux.h (USG, GNU_LINUX):
1465 * s/freebsd.h (BSD_SYSTEM):
1466 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1467 * s/cygwin.h (CYGWIN):
1468 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1469 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1470
d1e68667 14712012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1472
1473 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1474
6de0e799
GM
14752012-07-13 Glenn Morris <rgm@gnu.org>
1476
739ae010
GM
1477 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1478
dbee5793
GM
1479 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1480
6de0e799
GM
1481 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1482 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1483
b82da769
GM
14842012-07-12 Glenn Morris <rgm@gnu.org>
1485
4fae5a7a 1486 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1487
1488 * process.c (init_process_emacs): Rename from init_process.
1489 The old name is also the name of a Mach system call.
1490 * lisp.h, emacs.c: Update for this name change.
1491 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1492 longer needed.
1493
5a979817
EZ
14942012-07-12 Eli Zaretskii <eliz@gnu.org>
1495
1496 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1497 memmove call that removes glyphs covered by the left truncation
1498 glyph. Improve commentary.
1499 (display_line): Fix display of continuation glyphs on GUI frames
1500 when the right fringe is turned off and variable-size fonts are
1501 used in the window. Move the code that appends a stretch glyph to
1502 produce_special_glyphs, so that it could be used for truncation
1503 and continuation glyphs alike.
1504 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1505 glyph of a suitably computed width, to align the special glyphs at
1506 the window margin. Code moved from display_line. (Bug#11832)
1507
3e91a053
GM
15082012-07-12 Glenn Morris <rgm@gnu.org>
1509
ba9e4b84
GM
1510 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1511
1512 * s/gnu-linux.h, s/hpux10-20.h:
1513 Do not unconditionally define HAVE_XRMSETDATABASE.
1514
3e91a053
GM
1515 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1516
b300b1f4
PE
15172012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1518
1519 Fix typos that broke OS X build.
1520 Reported by Randal L. Schwartz in
1521 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1522 * nsterm.m (ns_timeout): Add missing local decl.
1523 (ns_get_color): snprintf -> sprintf, to fix typo.
1524
6e777848
GM
15252012-07-12 Glenn Morris <rgm@gnu.org>
1526
3f922c37
GM
1527 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1528 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1529 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1530 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1531
0ab7b23a
GM
1532 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1533 Move PTY_OPEN to configure.
1534
6e777848
GM
1535 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1536 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1537 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1538
4a7edc24
DA
15392012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1540
1541 Use empty_unibyte_string where applicable.
1542 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1543 * lread.c (read1): Likewise.
1544 * xsettings.c (syms_of_xsettings): Likewise.
1545
308aab79
GM
15462012-07-12 Glenn Morris <rgm@gnu.org>
1547
42bd1719
GM
1548 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1549 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1550 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1551 * s/hpux10-20.h (RUN_TIME_REMAP):
1552 * s/bsd-common.h (TABDLY): Move to configure.
1553
1554 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1555
1556 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1557
ea0bbd17 1558 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1559 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1560
1561 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1562
308aab79
GM
1563 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1564 * s/template.h: Move NARROWPROTO to configure.
1565
ee1cf5cf
GM
15662012-07-11 Glenn Morris <rgm@gnu.org>
1567
30fe9bf4
GM
1568 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1569 unused since 2011-01-17 change to systty.h.
1570
ee1cf5cf
GM
1571 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1572 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1573 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1574
63e47e07
PE
15752012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1576
1577 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1578
c43fb4c3
GM
15792012-07-11 Glenn Morris <rgm@gnu.org>
1580
1581 * s/darwin.h, s/gnu-linux.h, s/template.h:
1582 Move INTERRUPT_INPUT to configure.
1583
e8df9267
DA
15842012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1585
1586 Minor adjustments to interning code.
1587 * lisp.h (intern, intern_c_string): Redefine as static inline
1588 wrappers for intern_1 and intern_c_string_1, respectively.
1589 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1590 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1591 Vobarray checking.
e8df9267
DA
1592 * font.c (font_intern_prop): Likewise. Adjust comment.
1593 * w32font.c (intern_font_name): Likewise.
1594
34348bd4
AS
15952012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1596
d96a1e0c
AS
1597 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1598
34348bd4
AS
1599 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1600 of Fcar/Fcdr if possible.
1601 * font.c (check_otf_features): Likewise.
1602 * fontset.c (Fnew_fontset): Likewise.
1603 * gnutls.c (Fgnutls_boot): Likewise.
1604 * minibuf.c (read_minibuf): Likewise.
1605 * msdos.c (IT_set_frame_parameters): Likewise.
1606 * xmenu.c (Fx_popup_dialog): Likewise.
1607 * w32menu.c (Fx_popup_dialog): Likewise.
1608
c8add24e
GM
16092012-07-11 Glenn Morris <rgm@gnu.org>
1610
4b575b3c
GM
1611 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1612 since nothing has defined it on these platforms.
1613
09f4e3b0
GM
1614 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1615 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1616
172bedef
GM
1617 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1618 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1619 Move CLASH_DETECTION to configure.
1620
249685df
GM
1621 * s/gnu.h: Remove file, which is now empty.
1622
c8add24e
GM
1623 * s/gnu.h, s/gnu-linux.h:
1624 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1625
b41253a3
JW
16262012-07-11 John Wiegley <johnw@newartisans.com>
1627
1628 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1629 function attribute, so we only use it if it exists in the
1630 compiler.
1631
d923b542
DA
16322012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1633
1634 Avoid call to strlen in fast_c_string_match_ignore_case.
1635 * search.c (fast_c_string_match_ignore_case): Change to use
1636 length argument. Adjust users accordingly.
1637 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1638
5ebbef1d
PE
16392012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1640
bb352260
PE
1641 Assume mkdir, rmdir.
1642 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1643 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1644
57054ddd
PE
1645 Assume rename.
1646 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1647
b747d3f7
PE
1648 Assume perror.
1649 * s/hpux10-20.h (HAVE_PERROR): Remove.
1650 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1651 Remove dummy definition, as this problem was obsolete long ago.
1652
5ebbef1d
PE
1653 Assume strerror.
1654 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1655
984e7f30
DA
16562012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1657
1658 Avoid calls to strlen in font processing functions.
1659 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1660 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1661 users accordingly.
d923b542
DA
1662 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1663 Adjust prototypes.
1664 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1665 Change to return ptrdiff_t.
984e7f30
DA
1666 (xfont_list_pattern, xfont_match): Use length returned by
1667 xfont_decode_coding_xlfd.
1668 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1669
20e94fdd
GM
16702012-07-11 Glenn Morris <rgm@gnu.org>
1671
9d596af3
GM
1672 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1673 Move DONT_REOPEN_PTY to configure.
1674
20e94fdd
GM
1675 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1676 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1677
e99a530f
PE
16782012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1679
22ffb973
PE
1680 Remove "#define unix" that is no longer needed (Bug#11905).
1681 * s/aix4-2.h (unix): Remove; no longer needed.
1682
e9a9ae03
PE
1683 EMACS_TIME simplification (Bug#11875).
1684 This replaces macros (which typically do not work in GDB)
1685 with functions, typedefs and enums, making the code easier to debug.
1686 The functional style also makes code easier to read and maintain.
1687 * systime.h: Include <sys/time.h> on all hosts, not just if
1688 WINDOWSNT, since 'struct timeval' is needed in general.
1689 (EMACS_TIME): Now a typedef, not a macro.
1690 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1691 not macros.
1692 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1693 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1694 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1695 (EMACS_TIME_LE): Now functions, not macros.
1696 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1697 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1698 which are not functions. All uses rewritten to use:
1699 (make_emacs_time): New function.
1700 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1701 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1702 not functions. All uses rewritten to use the following, respectively:
1703 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1704 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1705 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1706 * fileio.c (Fcopy_file):
1707 * xterm.c (XTflash): Get the current time closer to when it's used.
1708 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1709
ffacb126
PE
1710 * bytecode.c (targets): Suppress -Woverride-init warnings.
1711
e99a530f
PE
1712 Simplify by avoiding confusing use of strncpy etc.
1713 * doc.c (Fsnarf_documentation):
1714 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1715 * frame.c (Fmake_terminal_frame):
1716 * gtkutil.c (get_utf8_string):
1717 * lread.c (openp):
1718 * nsmenu.m (ns_update_menubar):
1719 * regex.c (regerror):
1720 Prefer memcpy to strncpy and strncat when either will do.
1721 * fileio.c (Fsubstitute_in_file_name):
1722 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1723 (menu_separator_name_p):
1724 * nsmenu.m (ns_update_menubar):
1725 Prefer memcmp to strncmp when either will do.
1726 * nsterm.m: Include <ftoastr.h>.
1727 (ns_get_color):
1728 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1729 Prefer snprintf to strncpy.
1730 * nsterm.m (ns_term_init):
1731 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1732 * nsterm.m (ns_term_init):
1733 Avoid the need for strncpy, by using build_string or
1734 make_unibyte_string directly. Use dtoastr, not snprintf.
1735 * process.c (Fmake_network_process): Diagnose service names that
1736 are too long, rather than silently truncating them or creating
1737 non-null-terminated names.
1738 (Fnetwork_interface_info): Likewise, for interface names.
1739 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1740 Prefer sprintf to strncat.
1741 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1742 Prefer vsnprintf to vsprintf + strncpy.
1743
c59592b3
GM
17442012-07-10 Glenn Morris <rgm@gnu.org>
1745
1746 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1747 Clarify fallback case.
1748
7d7bbefd
DA
17492012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1750
1751 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1752 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1753 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1754 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1755 where argument type is known to be a Lisp_Cons.
1756
3a4c8000
TT
17572012-07-10 Tom Tromey <tromey@redhat.com>
1758
1759 * bytecode.c (BYTE_CODE_THREADED): New macro.
1760 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1761 (enum byte_code_op): New type.
1762 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1763 (exec_byte_code): Use them. Use token threading when applicable.
1764
2a0213a6
DA
17652012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1766
1767 Optimize pure C strings initialization.
1768 * lisp.h (make_pure_string): Fix prototype.
1769 (build_pure_c_string): New function, defined as static inline. This
1770 provides a better opportunity to optimize away calls to strlen when
1771 the function is called with compile-time constant argument.
1772 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1773 argument, adjust users accordingly. Use build_pure_c_string where
1774 appropriate.
1775 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1776 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1777 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1778
cb1caeaf
DA
17792012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1780
1781 Avoid calls to strlen in miscellaneous functions.
1782 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1783 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1784 * lread.c (openp): Likewise.
1785
c293e30c
DA
17862012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1787
1788 Avoid calls to strlen in path processing functions.
1789 * fileio.c (file_name_as_directory): Add comment. Change to add
1790 srclen argument and return the length of result. Adjust users
1791 accordingly.
1792 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1793 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1794 users accordingly.
1795 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1796
9e059e3f
GM
17972012-07-10 Glenn Morris <rgm@gnu.org>
1798
d02eb359
GM
1799 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1800 Move PENDING_OUTPUT_COUNT definition to configure.
1801
882cf227
GM
1802 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1803 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1804 * s/gnu.h (DATA_START): Move definitions to configure.
1805
af6e839f
GM
1806 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1807 We include usg5-4-common.h, which defines them both.
1808
40289a12
GM
1809 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1810 O_RDONLY already includes it).
1811
9e059e3f
GM
1812 Stop ns builds setting the EMACSLOADPATH environment variable.
1813 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1814 Now it does not set EMACSLOADPATH, just returns the load-path string.
1815 * nsterm.h: Update accordingly.
1816 * lread.c [HAVE_NS]: Include nsterm.h.
1817 (init_lread) [HAVE_NS]: Use ns_load_path.
1818 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1819
7c4e8ec0
GM
18202012-07-09 Glenn Morris <rgm@gnu.org>
1821
d4f600ff
GM
1822 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1823 since the included bsd-common.h does so.
1824
cbb31951
GM
1825 Stop ns builds setting the EMACSPATH environment variable.
1826 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1827 (ns_init_paths): Do not set EMACSPATH.
1828 * nsterm.h (ns_exec_path): Add it.
1829 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1830 Use ns_exec_path.
1831
7c4e8ec0
GM
1832 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1833
26bccfae
PE
18342012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1835
a0bee46f
PE
1836 * process.c (wait_reading_process_output): 'waitchannels' was unset
1837 when read_kbd || !NILP (wait_for_cell); fix this.
1838
5994c183
PE
1839 Add GCC-style 'const' attribute to functions that can use it.
1840 * character.h (char_resolve_modifier_mask):
1841 * keyboard.h (make_ctrl_char):
1842 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1843 (init_character_once, next_almost_prime, init_fns, init_image)
1844 (flush_pending_output, init_sound):
1845 * mem-limits.h (start_of_data):
1846 * menu.h (finish_menu_items):
1847 Add ATTRIBUTE_CONST.
1848 * emacs.c (DEFINE_DUMMY_FUNCTION):
1849 Declare the dummy function with ATTRIBUTE_CONST.
1850 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1851 Add decls with ATTRIBUTE_CONST.
1852
26bccfae
PE
1853 Minor improvements to make_formatted_string.
1854 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1855 where int is good enough, as vsprintf returns an int.
1856 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1857
a8290ec3
DA
18582012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1859
1860 Use make_formatted_string to avoid double length calculation.
1861 * lisp.h (make_formatted_string): New prototype.
1862 * alloc.c (make_formatted_string): New function.
1863 * buffer.c (Fgenerate_new_buffer_name): Use it.
1864 * dbus.c (syms_of_dbusbind): Likewise.
1865 * editfns.c (Fcurrent_time_zone): Likewise.
1866 * filelock.c (get_boot_time): Likewise.
1867 * frame.c (make_terminal_frame, set_term_frame_name)
1868 (x_report_frame_params): Likewise.
1869 * image.c (gs_load): Likewise.
1870 * minibuf.c (get_minibuffer): Likewise.
1871 * msdos.c (dos_set_window_size): Likewise.
1872 * process.c (make_process): Likewise.
1873 * xdisp.c (ensure_echo_area_buffers): Likewise.
1874 * xsettings.c (apply_xft_settings): Likewise.
1875
d01ba2f1
GM
18762012-07-09 Glenn Morris <rgm@gnu.org>
1877
1878 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1879 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1880 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1881 * nsterm.h (ns_etc_directory): Add it.
1882 * callproc.c [HAVE_NS]: Include nsterm.h.
1883 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1884
f1f924b6
DA
18852012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1886
1887 Move marker debugging code under MARKER_DEBUG.
1888 * marker.c (MARKER_DEBUG): Move marker debugging code under
1889 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1890 for bootstrap with --enable-checking (~3x slowdown reported
1891 by Juanma Barranquero <lekktu@gmail.com>).
1892 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1893
ab531b66
PE
18942012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1895
1896 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1897 See <http://bugs.gnu.org/11825#29>.
1898
c4b3bc8a
EZ
18992012-07-08 Eli Zaretskii <eliz@gnu.org>
1900
1901 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1902 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1903 (display_line): Add commentary about displaying truncation glyphs
1904 on GUI frames.
1905 (produce_special_glyphs): Move here from term.c.
1906
1907 * term.c (produce_special_glyphs): Move to xdisp.c.
1908
1909 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1910 section.
c4b3bc8a 1911
b676b881
AS
19122012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1913
f17c5273
AS
1914 * xdisp.c (display_line): Avoid warning about implicit declaration
1915 of FRAME_FONT.
1916
298819b9
AS
1917 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1918
b676b881
AS
1919 * lisp.h: Remove empty conditional.
1920
6045c4fd
PE
19212012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1922
b3350bf9
PE
1923 * lread.c (load_path_check): Now static.
1924
6045c4fd
PE
1925 Fix some minor --with-ns problems found by static checking.
1926 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1927 (x_set_font) [!HAVE_X_WINDOWS]:
1928 * image.c (xpm_load_image) [HAVE_NS]:
1929 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1930 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1931 Remove unused local.
1932 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1933 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1934 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1935 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1936 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1937 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1938 Fix pointer signedness problem.
1939 * xfaces.c (FRAME_X_FONT_TABLE):
1940 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1941
929e7845
GM
19422012-07-07 Glenn Morris <rgm@gnu.org>
1943
1944 * lread.c (load_path_check): New function, split from init_lread.
1945 (init_lread): Reorganize. Motivation:
1946 If EMACSLOADPATH is set, check/warn about that rather than the
1947 defaults, which we are not going to use. Hence we can remove
1948 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1949 Don't warn if site-lisp directories are missing.
1950 If not installed, start from a blank load-path, since
1951 PATH_LOADSEARCH refers to the eventual installation directories.
1952
58dd0aa4
EZ
19532012-07-07 Eli Zaretskii <eliz@gnu.org>
1954
1955 Support truncation and continuation glyphs on GUI frames, when
1956 fringes are disabled. (Bug#11832)
1957 * xdisp.c (init_iterator): Get dimensions of truncation and
1958 continuation glyphs even if on GUI frames. Adjust
1959 it->last_visible_x on GUI frames when the left or right fringes,
1960 or both, are absent.
1961 (start_display, move_it_in_display_line_to): Handle the case of a
1962 GUI frame without a fringe to display continuation or truncation
1963 glyphs.
1964 (insert_left_trunc_glyphs): Support GUI frames: make sure
1965 truncation glyphs overwrite enough glyphs from the current line to
1966 have sufficient space in pixels.
1967 (display_line): Support truncation and continuation glyphs on GUI
1968 frames. If some spare pixels are left on the line after inserting
1969 the truncation glyphs, fill that space with a stretch glyph of a
1970 suitably computed width.
1971
1972 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1973 produce_glyphs, to support GUI sessions.
1974
31571fd7
PE
19752012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1976
5a16b9bc
PE
1977 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1978
f3047c75
PE
1979 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1980
31571fd7
PE
1981 Do not require float-time's arg to fit in time_t (Bug#11825).
1982 This works better on hosts where time_t is unsigned, and where
1983 float-time is applied to the (negative) difference between two times.
1984 * editfns.c (decode_time_components): Last arg is now double *,
1985 not int *, and means to store all the result as a double, without
1986 worrying about whether the seconds part fits in time_t.
1987 All callers changed.
1988 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1989 All callers changed.
1990 (Ffloat_time): Do not fail merely because the specified time falls
1991 outside of time_t range.
1992
4516fbef
GM
19932012-07-07 Glenn Morris <rgm@gnu.org>
1994
1995 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1996 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1997 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1998
07adc2c6
JB
19992012-07-07 Juanma Barranquero <lekktu@gmail.com>
2000
2001 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2002 Update dependencies.
2003
2004 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2005
fd573f31
PE
20062012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2007
fee5959d
PE
2008 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2009 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2010 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2011 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2012 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2013 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2014
fd573f31
PE
2015 * xfont.c (compare_font_names): Redo to omit the need for casts.
2016
ddadbc0e
AS
20172012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2018
fca8d6b6
AS
2019 * xfns.c (Fx_change_window_property): Doc fix.
2020 * w32fns.c (Fx_change_window_property): Doc fix.
2021
ddadbc0e
AS
2022 * w32fns.c (Fx_window_property): Accept the same arguments as the
2023 X Windows version. Doc fix.
2024 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2025
ed9265fc 20262012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2027 Eli Zaretskii <eliz@gnu.org>
2028
2029 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2030 Windows-specific code from nt/config.nt moved here.
2031 Obsolete settings removed.
2032
216ee680
PE
20332012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2034
2035 * process.c: Avoid unnecessary calls to gettime.
2036 (wait_reading_process_output): Don't get the time of day
2037 when gobbling data immediately and not waiting, as there's no need
2038 for it in that case. This removes a FIXME.
2039
bdd091e4
JD
20402012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2041
2042 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2043 is defined (Bug#11768).
2044
9d44f8ce
DA
20452012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2046
2047 Fix marker debugging code.
2048 * marker.c (byte_char_debug_check): Do not perform the check
2049 if buffer is not multibyte.
090bd7cb
JB
2050 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2051 Call byte_char_debug_check with correct arguments.
9d44f8ce 2052
90fc4786
DA
20532012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2054
2055 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2056 * marker.c (byte_char_debug_check, count_markers):
2057 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2058 (byte_debug_flag): Remove.
2059 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2060 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2061
7b7ae965
DA
20622012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2063
4e57b342
DA
2064 Avoid code repetition in marker-related functions.
2065 * marker.c (attach_marker): New function.
2066 (Fset_marker, set_marker_restricted, set_marker_both)
2067 (set_marker_restricted_both): Use it.
2068 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2069 Consistently rename charno to charpos.
2070 (marker_position): Add eassert.
2071 (marker_byte_position): Convert to eassert.
2072
20732012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2074
2075 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2076 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2077 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2078
657924ff
DA
20792012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2080
2081 Introduce fast path for the widely used marker operation.
2082 * alloc.c (build_marker): New function.
2083 * lisp.h (build_marker): New prototype.
2084 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2085 * composite.c (autocmp_chars): Likewise.
2086 * editfns.c (buildmark): Remove.
2087 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2088 (save_restriction_save): Use build_marker.
2089 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2090 * window.c (save_window_save): Likewise.
2091
041a49a6
DA
20922012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2093
2094 Do not use Fdelete_overlay in delete_all_overlays
2095 to avoid redundant calls to unchain_overlay.
2096 * buffer.c (drop_overlay): New function.
2097 (delete_all_overlays, Fdelete_overlay): Use it.
2098 * minibuf.c (get_minibuffer): Fix comment.
2099
7dca65a4
PE
21002012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2101
2102 Port to OpenBSD 5.1 amd64.
2103 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2104 This is needed for OpenBSD, and should be harmless on all BSD systems.
2105 Also, include <sys/sysctl.h>, as it should be available on all
2106 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2107 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2108 use p_pid member, not kp_proc.pid.
2109
8eb876e2
GM
21102012-07-06 Glenn Morris <rgm@gnu.org>
2111
2112 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2113
38182d90
PE
21142012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2115
2116 More xmalloc and related cleanup.
2117 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2118 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2119 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2120 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2121 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2122 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2123 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2124 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2125 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2126 * xterm.c:
2127 Omit needless casts involving void * pointers and allocation.
2128 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2129 as the former is more robust if P's type is changed.
2130 Prefer xzalloc to xmalloc + memset 0.
2131 Simplify malloc-or-realloc to realloc.
2132 Don't worry about xmalloc returning a null pointer.
2133 Prefer xstrdup to xmalloc + strcpy.
2134 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2135 growing it.
2136 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2137 alloca of a constant.
2138
6dd5a677
EZ
21392012-07-05 Eli Zaretskii <eliz@gnu.org>
2140
2141 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2142 hscroll is larger than the line width. Fixes long and futile
2143 looping inside extend_face_to_end_of_line (on a TTY) producing
2144 glyphs that are not needed and thrown away.
2145
6b312f0f
DA
21462012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2147
2148 * marker.c (set_marker_restricted_both): Simplify by using
2149 clip_to_bounds.
2150
f520ef9b
PE
21512012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2152
2153 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2154
383b7c95
JD
21552012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2156
2157 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2158 not defined (Bug#11768).
2159 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2160 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2161 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2162 followed by gtk_box_set_homogeneous (Bug#11768).
2163 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2164 (update_theme_scrollbar_width, xg_create_scroll_bar):
2165 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2166 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2167 (is_box_type): New function (Bug#11768).
2168 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2169 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2170 with default display (Bug#11768).
2171
d6e7bf45
EZ
21722012-07-05 Eli Zaretskii <eliz@gnu.org>
2173
2174 * xdisp.c (window_hscroll_limited): New function.
2175 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2176 coordinates when window's hscroll is set to insanely large
2177 values. (Bug#11857)
2178
431391ec
JB
21792012-07-05 Juanma Barranquero <lekktu@gmail.com>
2180
2181 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2182 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2183
23f86fce
DA
21842012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2185
2186 Cleanup xmalloc.
2187 * lisp.h (xzalloc): New prototype. Omit needless casts.
2188 * alloc.c (xzalloc): New function. Omit needless casts.
2189 * charset.c: Omit needless casts. Convert all calls to
2190 xmalloc with following memset to xzalloc.
2191 * dispnew.c: Likewise.
2192 * fringe.c: Likewise.
2193 * image.c: Likewise.
2194 * sound.c: Likewise.
2195 * term.c: Likewise.
2196 * w32fns.c: Likewise.
2197 * w32font.c: Likewise.
2198 * w32term.c: Likewise.
2199 * xfaces.c: Likewise.
2200 * xfns.c: Likewise.
2201 * xterm.c: Likewise.
2202 * atimer.c: Omit needless casts.
2203 * buffer.c: Likewise.
2204 * callproc.c: Likewise.
2205 * ccl.c: Likewise.
2206 * coding.c: Likewise.
2207 * composite.c: Likewise.
2208 * doc.c: Likewise.
2209 * doprnt.c: Likewise.
2210 * editfns.c: Likewise.
2211 * emacs.c: Likewise.
2212 * eval.c: Likewise.
2213 * filelock.c: Likewise.
2214 * fns.c: Likewise.
2215 * gtkutil.c: Likewise.
2216 * keyboard.c: Likewise.
2217 * lisp.h: Likewise.
2218 * lread.c: Likewise.
2219 * minibuf.c: Likewise.
2220 * msdos.c: Likewise.
2221 * print.c: Likewise.
2222 * process.c: Likewise.
2223 * region-cache.c: Likewise.
2224 * search.c: Likewise.
2225 * sysdep.c: Likewise.
2226 * termcap.c: Likewise.
2227 * terminal.c: Likewise.
2228 * tparam.c: Likewise.
2229 * w16select.c: Likewise.
2230 * w32.c: Likewise.
2231 * w32reg.c: Likewise.
2232 * w32select.c: Likewise.
2233 * w32uniscribe.c: Likewise.
2234 * widget.c: Likewise.
2235 * xdisp.c: Likewise.
2236 * xmenu.c: Likewise.
2237 * xrdb.c: Likewise.
2238 * xselect.c: Likewise.
2239
0497dc44
PE
22402012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2241
2242 * fileio.c (time_error_value): Check the right error number.
2243 Problem reported by Troels Nielsen in
2244 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2245
356e7178
PE
22462012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2247
4e71fd89
PE
2248 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2249 This should be fixed in a better way; see Eli Zaretskii in
2250 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2251 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2252
f0941253
PE
2253 * fileio.c (time_error_value): Rename from special_mtime.
2254 The old name's problems were noted by Eli Zaretskii in
2255 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2256
065c9eb4
PE
2257 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2258 This variable's comment says Emacs needs at least one GDB-visible
2259 symbol of type enum pvec_type, to work around GDB problems.
2260 The symbol's value doesn't matter.
2261
356e7178
PE
2262 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2263 that causes compilation to fail on pre-C99 compilers.
2264
ed9265fc 22652012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2266
2267 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2268 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2269
3884d954
DA
22702012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2271
d209e2fb 2272 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2273 headers for buffer_defaults and buffer_local_symbols.
2274 Reported by Juanma Barranquero <lekktu@gmail.com>.
2275
ee28be33
SM
22762012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2277
2278 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2279 * lisp.h (enum pvec_type): Use fewer bits.
2280 (PSEUDOVECTOR_SIZE_BITS): New constant.
2281 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2282 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2283 change in pvec_type.
2284 (PSEUDOVECTOR_TYPEP): New macro.
2285 (TYPED_PSEUDOVECTORP): Use it.
2286 * fns.c (internal_equal): Adapt code to extract pvectype.
2287 * emacs.c (gdb_pvec_type): Update type.
2288 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2289 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2290 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2291 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2292 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2293 abusing vector->header.next.nbytes.
2294 (live_vector_p): Use PVEC_TYPE.
2295 (mark_object): Adapt code to extract pvectype. Use switch.
2296
c7f2cd7f
PE
22972012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2298
2299 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2300 Tighten new eassert a bit.
2301
8ce70ed2
DA
23022012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2303
2304 Fix compilation with --enable-gcc-warnings and -O1
2305 optimization level.
2306 * doprnt.c (doprnt): Change type of tem to int, initialize
2307 to avoid compiler warning. Add eassert.
2308 * search.c (simple_search): Initialize match_byte to avoid
2309 compiler warning. Add eassert.
2310
dea7f1e5
PE
23112012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2312
24a212eb
PE
2313 Avoid weird behavior with large horizontal scrolls.
2314 Without this change, for example, large hscroll values would
2315 mess up Emacs's display on Fedora 15 x86, presumably due to
2316 overflows in int calculations in the display code.
2317 Also, if buffers had long lines, Emacs would freeze.
2318 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2319 (set_window_hscroll): New function, containing the old guts of
2320 Fset_window_hscroll. Return the clipped value.
2321 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2322 This avoids the need to check against PTRDIFF_MAX.
2323
dea7f1e5
PE
2324 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2325
76046526
DA
23262012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2327
2328 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2329
39adff0d
PE
23302012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2331
63807d47
PE
2332 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2333 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2334 since GCC 4.4.6 issues a bogus warning for them.
2335
39adff0d
PE
2336 Fix bugs in file timestamp newness comparisons.
2337 * fileio.c (Ffile_newer_than_file_p):
2338 * lread.c (Fload): Use full timestamp resolution of files,
2339 not just the 1-second resolution, so that files that are only
2340 slightly newer still count as newer.
2341 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2342 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2343
dbeed9a6
PE
23442012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2345
2346 * fileio.c: Improve handling of file time marker. (Bug#11852)
2347 (special_mtime): New function.
2348 (Finsert_file_contents, Fverify_visited_file_modtime):
2349 Use it to set special mtime values consistently.
2350
636334d6
AS
23512012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2352
2353 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2354 marker for non-existing file. (Bug#11852)
2355
e2017fe2
GM
23562012-07-03 Glenn Morris <rgm@gnu.org>
2357
2358 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2359 and did not make it into globals.h).
2360
404dbd37
TT
23612012-07-03 Tom Tromey <tromey@redhat.com>
2362
2363 * window.c (Fset_window_margins, Fset_window_fringes)
2364 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2365 * textprop.c (Fprevious_property_change): No longer static.
2366 * syntax.c (Fsyntax_table_p): No longer static.
2367 * process.c (Fget_process, Fprocess_datagram_address): No longer
2368 static.
2369 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2370 * keyboard.c (Fcommand_execute): No longer static.
2371 Remove EXFUN.
2372 * insdel.c (Fcombine_after_change_execute): No longer static.
2373 * image.c (Finit_image_library): No longer static.
2374 * fileio.c (Fmake_symbolic_link): No longer static.
2375 * eval.c (Ffetch_bytecode): No longer static.
2376 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2377 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2378 No longer static.
404dbd37
TT
2379 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2380 static.
2381 * dired.c (Ffile_attributes): No longer static.
2382 * composite.c (Fcomposition_get_gstring): No longer static.
2383 * callproc.c (Fgetenv_internal): No longer static.
2384
2385 * ccl.h: Remove EXFUNs.
2386 * buffer.h: Remove EXFUNs.
2387 * dispextern.h: Remove EXFUNs.
2388 * intervals.h: Remove EXFUNs.
2389 * fontset.h: Remove EXFUN.
2390 * font.h: Remove EXFUNs.
2391 * dosfns.c (system_process_attributes): Remove EXFUN.
2392 * keymap.h: Remove EXFUNs.
2393 * lisp.h: Remove EXFUNs.
2394 * w32term.h: Remove EXFUNs.
2395 * window.h: Remove EXFUNs.
2396 * xsettings.h: Remove EXFUN.
2397 * xterm.h: Remove EXFUN.
2398
8e4fd1e1
GM
23992012-07-03 Glenn Morris <rgm@gnu.org>
2400
2401 * lisp.h (Frandom): Make it visible to C.
2402 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2403 buffer for invisible buffers. (Bug#1229)
2404
ca95b3eb
DA
24052012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2406
2407 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2408 values which aren't power of 2.
2409 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2410 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2411 accordingly.
2412
7555c33f
SM
24132012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2414
2415 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2416
2417 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2418
d12e8f5a
DA
24192012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2420
2421 * alloc.c (allocate_vector_block): Remove redundant
2422 calls to mallopt if DOUG_LEA_MALLOC is defined.
2423 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2424 avoid calls to mallopt if zero_vector is returned.
2425
296094c3
DA
24262012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2427
2428 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2429 is enabled, avoid dereferencing NULL current_sblock if
2430 running undumped.
2431
36429c89
DA
24322012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2433
2434 Cleanup basic buffer management.
2435 * buffer.h (struct buffer): Change layout to use generic vector
2436 marking code. Fix some comments. Change type of 'clip_changed'
2437 to bitfield. Remove unused #ifndef old.
2438 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2439 (GET_OVERLAYS_AT): Fix indentation.
2440 (for_each_per_buffer_object_at): New macro.
2441 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2442 (Fbuffer_local_variables): Use it.
2443 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2444 * alloc.c (allocate_buffer): Adjust to match new layout of
2445 struct buffer. Fix comment.
2446 (mark_overlay): New function.
2447 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2448 Lisp area of struct buffer.
2449 (mark_object): Use it. Adjust marking of misc objects
2450 and related comments.
2451
3b3e4cac
PE
24522012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2453
2454 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2455 wrapper that is not needed because the wrapped code is a no-op (zero
2456 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2457 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2458
cf5c0175
DA
24592012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2460
2461 * alloc.c (mark_buffer): Simplify. Remove prototype.
2462 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2463 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2464 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2465 redundant calls to mark_vectorlike for bool vectors.
2466
ca26824c
GM
24672012-06-30 Glenn Morris <rgm@gnu.org>
2468
2e4c5312
GM
2469 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2470
ca26824c
GM
2471 * epaths.in (PATH_SITELOADSEARCH): New.
2472 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2473 This is rather than relying on --enable-locallisppath elements
2474 having "site-lisp" in their names. (Bug#10208#25, 11658)
2475
0d23c240
EZ
24762012-06-30 Eli Zaretskii <eliz@gnu.org>
2477
c9240d7a
EZ
2478 * w32proc.c (sys_select): Accept and ignore one more argument.
2479
2480 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2481
0d23c240 2482 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2483 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2484
2485 * sysdep.c: Don't include dos.h and dosfns.h.
2486
2487 * process.c (sys_select):
2488 * msdos.c (sys_select): Accept one more argument and ignore it.
2489
2490 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2491 adapt data types and code to that.
2492
2493 * dosfns.c:
2494 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2495 which clashes with the gnulib function of the same name.
2496
af5a5a98
AS
24972012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2498
c5e4379c
AS
2499 * font.c (font_style_to_value, font_style_symbolic)
2500 (font_prop_validate_style): Add type checks for values in
2501 font_style_table.
2502
af5a5a98
AS
2503 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2504 argument.
2505 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2506 uses.
2507
8d38f461
EZ
25082012-06-29 Eli Zaretskii <eliz@gnu.org>
2509
2e5a6631
EZ
2510 * xdisp.c (try_window_id): Undo last change.
2511
8d38f461
EZ
2512 * w32.c (getwd): Adjust commentary about startup_dir.
2513 (init_environment): Always call sys_access, even in non-MSVC
2514 builds. Don't chdir to the directory of the Emacs executable.
2515 This undoes code from 1997 which was justified by the need to
2516 "avoid conflicts when removing and renaming directories". But its
2517 downside was that every relative file name was being interpreted
2518 relative to the directory of the Emacs executable, which can never
2519 be TRT. In particular, it broke sys_access when called with
2520 relative file names.
2521 (sys_access): Map GetLastError to errno.
2522
2af3565e
DA
25232012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2524
2525 * window.h (struct window): Change type of 'fringes_outside_margins'
2526 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2527 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2528 Adjust comment.
2529 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2530 to ptrdiff_t.
2531
c8d3a25c 25322012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2533
c8d3a25c
GM
2534 * gnutls.c (emacs_gnutls_handshake):
2535 Add QUIT to make the loop interruptible.
57570cd3 2536
c8d3a25c 25372012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2538
c8d3a25c
GM
2539 * charset.c (init_charset): Make lack of etc/charsets fatal.
2540
3e984ee8
DA
25412012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2542
2543 * editfns.c (region_limit): Fix type mismatch.
2544
ef884f23
DA
25452012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2546
2547 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2548 undefined. Convert from xassert to eassert.
2549 * nsmenu.m: Convert from xassert to eassert.
2550 * nsterm.m: Likewise.
2551
7d7e0027
SM
25522012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2553
2554 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2555
aa754e6a
PE
25562012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2557
2558 Avoid integer overflow on scroll-left and scroll-right.
2559 * window.c (HSCROLL_MAX): New macro.
2560 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2561 overflow when requested scroll falls outside ptrdiff_t range.
2562
80b00b08
DA
25632012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2564
2565 * window.h (struct window): Change type of 'hscroll',
2566 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2567 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2568 Adjust users accordingly.
2569 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2570 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2571 from EMACS_INT to ptrdiff_t.
2572 (make_window): Omit redundant initialization.
2573
62b2bcf6
JB
25742012-06-28 Juanma Barranquero <lekktu@gmail.com>
2575
2576 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2577
45942c7d
DA
25782012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2579
2580 * window.h (struct window): Change type of 'use_time' and
2581 'sequence_number' from Lisp_Object to int.
2582 * frame.c (make_frame): Adjust users accordingly.
2583 * print.c (print_object): Likewise.
2584 * window.c (select_window, Fwindow_use_time, make_parent_window)
2585 (make_window): Likewise.
2586
e509cfa6
DA
25872012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2588
2589 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2590 enabled with --enable-checking=[all,glyphs] configure option.
2591 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2592 adjust comments accordingly.
2593 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2594 undefined, adjust comments accordingly.
2595 * image.c: Likewise.
2596 * scroll.c: Likewise.
2597 * w32fns.c: Likewise.
2598 * w32term.c: Likewise.
2599 * xdisp.c: Likewise.
2600 * xfaces.c: Likewise.
2601 * xfns.c: Likewise.
2602 * xterm.c: Likewise.
2603
a54e2c05
DA
26042012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2605
2606 Generalize run-time debugging checks.
2607 * dispextern.h (XASSERTS): Remove.
2608 * fontset.c (xassert): Remove.
2609 Convert from xassert to eassert.
2610 * alloc.c: Convert from xassert to eassert.
2611 * bidi.c: Likewise.
2612 * dispnew.c: Likewise.
2613 * fns.c: Likewise.
2614 * fringe.c: Likewise.
2615 * ftfont.c: Likewise.
2616 * gtkutil.c: Likewise.
2617 * image.c: Likewise.
2618 * keyboard.c: Likewise.
2619 * menu.c: Likewise.
2620 * process.c: Likewise.
2621 * scroll.c: Likewise.
2622 * sound.c: Likewise.
2623 * term.c: Likewise.
2624 * w32console.c: Likewise.
2625 * w32fns.c: Likewise.
2626 * w32term.c: Likewise.
2627 * window.c: Likewise.
2628 * xdisp.c: Likewise.
2629 * xfaces.c: Likewise.
2630 * xfns.c: Likewise.
2631 * xselect.c: Likewise.
2632 * xterm.c: Likewise.
2633
1ec4b7b2
SM
26342012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2635
2636 * fns.c (maybe_resize_hash_table): Output message when growing the
2637 purify-hashtable.
2638
2014308a
DA
26392012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2640
2641 * alloc.c (allocate_string_data): Remove dead code.
2642 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2643 avoid GCC warning about unused macro.
2644
246155eb
DA
26452012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2646
2647 * alloc.c (allocate_string): Omit intervals initialization.
2648 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2649 as in make_pure_string and make_pure_c_string.
2650
43184b7b
DA
26512012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2652
d209e2fb 2653 * alloc.c (allocate_string): Fix last change.
43184b7b 2654
3fe6dd74
DA
26552012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2656
d209e2fb 2657 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2658 to memset, add explicit initialization where appropriate.
2659
1ba6038a
GM
26602012-06-27 Glenn Morris <rgm@gnu.org>
2661
2662 * lisp.mk (lisp): Remove paths.elc.
2663
c89926a5
CY
26642012-06-27 Chong Yidong <cyd@gnu.org>
2665
2666 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2667
ed6b3510
JW
26682012-06-26 John Wiegley <johnw@newartisans.com>
2669
1ec4b7b2 2670 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2671 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2672
ed6b3510
JW
2673 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2674 when building with Clang.
2675
8edd4a2b
SM
26762012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2677
2678 * eval.c (Fapply): Allow calling it with a single argument.
2679
f6f62d1b
EZ
26802012-06-26 Eli Zaretskii <eliz@gnu.org>
2681
2682 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2683 _stricmp and _strnicmp.
2684 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2685
62efea5e
DA
26862012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2687
2688 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2689 allocated window.
2690 (allocate_process): Likewise for new process.
8edd4a2b 2691 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2692 (allocate_frame): Likewise.
2693 * frame.c (make_frame): Omit redundant initialization.
2694 * window.c (make_parent_window): Use memset.
2695 (make_window): Omit redundant initialization.
2696 * process.c (make_process): Omit redundant initialization.
2697 * terminal.c (create_terminal): Likewise.
2698
42997f4d
DA
26992012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2700
2701 * term.c (delete_tty): Remove redundant call to memset.
2702
1130ecfc
DA
27032012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2704
2705 * alloc.c: Remove build_string.
2706 * lisp.h: Define build_string as static inline. This provides
2707 a better opportunity to optimize away calls to strlen when the
2708 function is called with compile-time constant argument.
2709 * image.c (imagemagick_error): Convert to build_string.
2710 * w32proc.c (sys_spawnve): Likewise.
2711 * xterm.c (x_term_init): Likewise.
2712
cf38a720
PE
27132012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2714
99027bdd
PE
2715 Use sprintf return value instead of invoking strlen on result.
2716 In the old days this wasn't portable, since some sprintf
2717 implementations returned char *. But they died out years ago and
2718 Emacs already assumes sprintf returns int.
2719 Similarly for float_to_string.
2720 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2721 * ccl.c (ccl_driver):
2722 * character.c (string_escape_byte8):
2723 * data.c (Fnumber_to_string):
2724 * doprnt.c (doprnt):
2725 * print.c (print_object):
2726 * xdisp.c (message_dolog):
2727 * xfns.c (syms_of_xfns):
2728 Use sprintf or float_to_string result to avoid need to call strlen.
2729 * data.c (Fnumber_to_string):
2730 Use make_unibyte_string, since the string must be ASCII.
2731 * lisp.h, print.c (float_to_string): Now returns int length.
2732 * term.c (produce_glyphless_glyph):
2733 Use sprintf result rather than recomputing it.
2734
cf38a720
PE
2735 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2736 * Makefile.in (ALL_CFLAGS):
2737 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2738 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2739
3511c784
DA
27402012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2741
0a08eb21 2742 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2743 strcasecmp if available.
2744 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2745
fb7da12e
AS
27462012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2747
2748 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2749 Avoid comma operator.
2750 * menu.c (push_submenu_start, push_submenu_end)
2751 (push_left_right_boundary, push_menu_pane): Likewise.
2752 * msdos.c (dos_rawgetc): Likewise.
2753
afa2ffd8
DA
27542012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2755
2756 * xfns.c (xic_create_fontsetname): Remove redundant calls
2757 to memset.
2758
b3b4476b
PE
27592012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2760
4495ff38
PE
2761 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2762 sprintf already null-terminates its output.
2763
b3b4476b
PE
2764 * xfns.c (x_window): Remove redundant cast.
2765
b00876c9
DA
27662012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2767
2768 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2769 `const char *' to `char *' to avoid compiler warning.
2770
d188e26b
PE
27712012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2772
885d1d74
PE
2773 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2774 instead of truncating it to 63 (admittedly a generous limit).
2775
d188e26b
PE
2776 * process.c: Fix spelling and caps in comments.
2777
e2f560b1
DN
27782012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2779
e86db54b 2780 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2781 * sysdep.c (setpgrp): Remove definition, not used in this file.
2782
7583a3a1
JB
27832012-06-24 Juanma Barranquero <lekktu@gmail.com>
2784
2785 * makefile.w32-in: Update dependencies.
2786
696056c2
EZ
27872012-06-24 Eli Zaretskii <eliz@gnu.org>
2788
2789 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2790 (SYSTIME_H): Add nt/inc/sys/time.h.
2791
2792 * systime.h [WINDOWSNT]: Include sys/time.h.
2793
2794 * s/ms-w32.h (struct timespec): Definition moved from
2795 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2796
845ca893
PE
27972012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2798
2799 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2800 * buffer.h (buffer_slot_type_mismatch):
2801 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2802 * eval.c (unwind_to_catch):
2803 * image.c (my_png_error, my_error_exit):
2804 * keyboard.c (quit_throw_to_read_char, user_error)
2805 (Fexit_recursive_edit, Fabort_recursive_edit):
2806 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2807 (wrong_type_argument, buffer_overflow, __executable_start)
2808 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2809 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2810 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2811 (fatal):
2812 (child_setup) [!DOS_NT]:
2813 * lread.c (end_of_file_error, invalid_syntax):
2814 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2815 * puresize.h (pure_write_error):
2816 * search.c (matcher_overflow):
2817 * sound.c (sound_perror, alsa_sound_perror):
2818 * sysdep.c, syssignal.h (croak):
2819 * term.c (maybe_fatal, vfatal):
2820 * textprop.c (text_read_only):
2821 * undo.c (user_error):
2822 * unexmacosx.c (unexec_error):
2823 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2824 Use _Noreturn rather than NO_RETURN.
2825 No need for separate decl merely because of _Noreturn.
2826 * sound.c (sound_warning, parse_sound):
2827 Remove unnecessary forward decls.
2828
f1dd8073
PE
28292012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2830
2831 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2832 * lisp.h (WAIT_READING_MAX): New macro.
2833 * dispnew.c (Fsleep_for, sit_for):
2834 * keyboard.c (kbd_buffer_get_event):
2835 * process.c (Faccept_process_output):
2836 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2837 This improves on the previous patch, which introduced a bug
2838 when time_t is unsigned and as wide as intmax_t.
2839 See <http://bugs.gnu.org/9000#51>.
2840
b82c1755
EZ
28412012-06-23 Eli Zaretskii <eliz@gnu.org>
2842
2843 * dispnew.c (sit_for, Fsleep_for):
2844 * keyboard.c (kbd_buffer_get_event):
2845 * process.c (Faccept_process_output): Avoid compiler warnings when
2846 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2847
ca300656
JB
28482012-06-23 Juanma Barranquero <lekktu@gmail.com>
2849
049ec95b
JB
2850 * makefile.w32-in: Update dependencies.
2851
ca300656
JB
2852 * w32.c (ltime): Add return type and declare static.
2853 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2854
db7b8d06
PE
28552012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2856
2857 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2858 Privately reported by Herbert J. Skuhra.
2859 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2860 All uses changed.
2861 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2862 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2863
0bd8297f
EZ
28642012-06-23 Eli Zaretskii <eliz@gnu.org>
2865
96512555
EZ
2866 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2867 last argument of make_unibyte_string.
2868
0bd8297f
EZ
2869 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2870 language ID in the event parameters.
2871
2872 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2873 event.code, not the obscure "character set ID".
2874
63def6b6
CY
28752012-06-23 Chong Yidong <cyd@gnu.org>
2876
2877 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2878
e8a02204
EZ
28792012-06-23 Eli Zaretskii <eliz@gnu.org>
2880
388cdec0
EZ
2881 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2882 * w32.c (fdutimens): New function.
2883
2884 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2885
2886 * s/ms-w32.h (pselect): Redirect to sys_select.
2887
2888 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2889
e8a02204
EZ
2890 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2891 in the logic of incrementing and decrementing the value of
2892 use_relocatable_buffers.
2893
d054f3fb
PE
28942012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2895
2896 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2897 Privately reported by Herbert J. Skuhra.
2898 [__FreeBSD__]: Remove "*/" typo after "#include".
2899 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2900 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2901 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2902 Don't assume EMACS_TIME and struct timeval are the same type.
2903
d35af63c
PE
29042012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2905
2906 Support higher-resolution time stamps (Bug#9000).
2907 The time stamps are only nanosecond-resolution at the C level,
2908 since that's the best that any real-world system supports now.
2909 But they are picosecond-resolution at the Lisp level, as that's
2910 easy, and leaves room for future OS improvements.
2911
2912 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2913 (LIBES): Use it.
2914
2915 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2916 Don't get current time unless it's needed.
2917
2918 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2919 now provides it if it's absent.
2920 (start_atimer): Port to higher-res time stamps.
2921 Check for time stamp overflow. Don't get current time more
2922 often than is needed.
2923
2924 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2925 Include systime.h, not time.h.
2926 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2927
2928 * dired.c: Include stat-time.h.
2929 (Ffile-attributes): File times now have higher resolution.
2930
2931 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2932 (struct image): Timestamp now has higher resolution.
2933
2934 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2935 has at least microseconds now. All uses removed.
2936 (update_frame, update_single_window, update_window, update_frame_1)
2937 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2938
2939 * editfns.c (time_overflow): Now extern.
2940 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2941 (float-time, Fformat_time_string, Fcurrent_time_string)
2942 (Fcurrent_time_zone): Accept and generate higher-resolution
2943 time stamps.
2944 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2945 (decode_time_components, lisp_seconds_argument): New functions.
2946 (make_time): Now static.
2947 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2948 Report an error if the time is invalid, rather than having the caller
2949 do that.
2950
2951 * fileio.c: Include <stat-time.h>
2952 (Fcopy_file): Copy higher-resolution time stamps.
2953 Prefer to set the time stamp via a file descriptor if that works.
2954 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2955 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2956 (Fvisited_file_modtime, Fset_visited_file_modtime):
2957 Support higher-resolution time stamps.
2958
2959 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2960
2961 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2962
2963 * image.c (prepare_image_for_display, clear_image_cache)
2964 (lookup_image): Port to higer-resolution time stamps.
2965
2966 * keyboard.c (start_polling, bind_polling_period):
2967 Check for time stamp overflow.
2968 (read_char, kbd_buffer_get_event, timer_start_idle)
2969 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2970 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2971 Port to higher-resolution time stamps. Do not assume time_t is signed.
2972 (decode_timer): New function. Timers are now vectors of length 9,
2973 not 8, to accommodate the picosecond component.
2974 (timer_check_2): Use it.
2975
2976 * nsterm.m (select_timeout, timeval_subtract): Remove.
2977 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2978 as they're a bit more accurate and handle overflow better.
2979 (ns_select): Change prototype to be compatible with pselect.
2980 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2981 * nsterm.h (ns_select): Adjust prototype.
2982
2983 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2984 us-resolution time stamps.
2985 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2986
2987 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2988
2989 * lisp.h (time_overflow): New decl.
2990 (wait_reading_process_output): First arg is now intmax_t, not int,
2991 to accommodate larger waits.
2992
2993 * process.h (struct Lisp_Process.read_output_delay):
2994 Now counts nanoseconds, not microseconds.
2995 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2996 EMACS_HAS_USECS.
2997 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2998 (wait_reading_process_output):
2999 Port to ns-resolution time stamps.
3000 (Faccept_process_output, wait_reading_process_output):
3001 Check for time stamp overflow. Do not assume time_t is signed.
3002 (select_wrapper): Remove; we now use pselect.
3003 (Fprocess_attributes): Now generates ns-resolution time stamps.
3004
3005 * sysdep.c: Include utimens.h. Don't include utime.h
3006 or worry about struct utimbuf; gnulib does that for us now.
3007 (gettimeofday): Remove; gnulib provides a substitute.
3008 (make_timeval): New function.
3009 (set_file_times): Now sets ns-resolution time stamps.
3010 New arg FD; all uses changed.
3011 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3012 (system_process_attributes):
3013 Now returns ns-resolution time stamp. All uses changed.
3014 Check for time stamp overflow.
3015
3016 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3017 provides a substitute now.
3018
3019 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3020 since it guarantees struct timespec.
3021 (EMACS_TIME): Now struct timespec, so that we can support
3022 ns-resolution time stamps.
3023 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3024 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3025 (EMACS_USECS): Remove.
3026 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3027 so multiply the arg by 1000 before storing it.
3028 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3029 New macros.
3030 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3031 Port to ns-resolution time stamps.
3032 (EMACS_TIME_NEG_P): Remove; replaced by....
3033 (EMACS_TIME_SIGN): New macro.
3034 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3035 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3036 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3037 (make_timeval, make_lisp_time, decode_time_components): New decls.
3038 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3039 that it mishandled time_t overflow. You can't compare by subtracting!
3040 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3041 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3042
3043 * term.c: Include <sys/time.h>.
3044 (timeval_to_Time): New function, for proper overflow wraparound.
3045 (term_mouse_position, term_mouse_click): Use it.
3046
3047 * undo.c (record_first_change): Support higher-resolution time stamps
3048 in the undo buffer.
3049 (Fprimitive_undo): Use them when restoring time stamps.
3050
3051 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3052 (w32_get_internal_run_time):
3053 Port to higher-resolution Emacs time stamps.
3054 (ltime): Now accepts single 64-bit integer, as that's more convenient
3055 for callers.
3056
3057 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3058
3059 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3060 for compatibility with pselect. Support ns-resolution time stamps.
3061
3062 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3063
3064 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3065 Check for time stamp overflow, and support ns-resolution time stamps.
3066
3067 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3068 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3069 (timeval_subtract): Remove; no longer needed.
3070 (XTflash, XTring_bell, x_wait_for_event):
3071 Port to ns-resolution time stamps. Don't assume time_t is signed.
3072
b6a92dfe
CY
30732012-06-22 Chong Yidong <cyd@gnu.org>
3074
3075 * xdisp.c (x_consider_frame_title): Revert last change.
3076
d251c37c
EZ
30772012-06-22 Eli Zaretskii <eliz@gnu.org>
3078
3079 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3080 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3081 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3082 staticidx goes up to 1597 out of 1600 = 0x640.)
3083
f10deafb
PE
30842012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3085
3086 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3087 Otherwise, the umask might be mistakenly 0 while handling input signals.
3088
ec6de1e2
SM
30892012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3090
3091 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3092
28be1ada
DA
30932012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3094
3095 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3096 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3097 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3098 access to `contents' member of Lisp_Vector objects with AREF and ASET
3099 where appropriate.
3100
c6bf3022
CY
31012012-06-19 Chong Yidong <cyd@gnu.org>
3102
3103 * frame.c (delete_frame): When selecting a frame on a different
3104 text terminal, do not alter the terminal's top-frame.
3105
3106 * xdisp.c (format_mode_line_unwind_data): Record the target
3107 frame's selected window and its terminal's top-frame.
3108 (unwind_format_mode_line): Restore them.
3109 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3110 Callers changed.
3111 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3112 since tty frames can be explicitly named.
3113 (prepare_menu_bars): Likewise.
3114
3115 * term.c (Ftty_top_frame): New function.
3116
defd4196
PE
31172012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3118
3119 Port byte-code-meter to modern targets.
3120 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3121 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3122 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3123 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3124 (METER_1, METER_2): Simplify.
3125
1053a871
SM
31262012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3127
3128 * data.c (Fdefalias): Return `symbol' (bug#11686).
3129
b7e8d081
MR
31302012-06-18 Martin Rudalics <rudalics@gmx.at>
3131
3132 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3133 gets killed during executing of this function (Bug#11665).
3134 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3135 (Vkill_buffer_query_functions): In doc-string say that functions
3136 run by this hook should not change the current buffer.
3137
7ea2b339
PE
31382012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3139
3140 Fix recently-introduced process.c problems found by static checking.
3141 * process.c (write_queue_push, write_queue_pop, send_process):
3142 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3143 (write_queue_pop): Fix pointer signedness problem.
3144 (send_process): Remove unused local.
3145
96a313a1
CY
31462012-06-17 Chong Yidong <cyd@gnu.org>
3147
3148 * xdisp.c (redisplay_internal): No need to redisplay terminal
3149 frames that are not on top.
3150
20ca2e94
TN
31512012-06-17 Troels Nielsen <bn.troels@gmail.com>
3152
3153 * process.c (make_process): Initialize write_queue.
3154 (write_queue_push, write_queue_pop): New functions.
3155 (send_process): Use them to maintain correct ordering of process
3156 writes (Bug#10815).
3157
9a900ca9
PE
31582012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3159
310fbfa8
PE
3160 * lisp.h (eassert): Assume C89 or later.
3161 This removes the need for CHECK.
3162 (CHECK): Remove. Its comments about always evaluating its
3163 argument were confusing, as 'eassert' typically does not evaluate
3164 its argument.
3165
27bb1ca4
PE
3166 * coding.c (produce_chars): Use ptrdiff_t, not int.
3167
9a900ca9
PE
3168 * xterm.c (x_draw_underwave): Check for integer overflow.
3169 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3170
41b7f8bc 31712012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3172
3173 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3174 referenced (Bug#11583).
3175
9b0e3eba
AA
31762012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3177
3178 Implement wave-style variant of underlining.
3179 * dispextern.h (face_underline_type): New enum.
3180 (face): Add field for underline type.
3181 * nsterm.m (ns_draw_underwave): New function.
3182 (ns_draw_text_decoration): Use it.
3183 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3184 New functions.
3185 (x_draw_glyph_string): Use them.
3186 * xfaces.c (Qline, Qwave): New Lisp objects.
3187 (check_lface_attrs, merge_face_ref)
1053a871
SM
3188 (Finternal_set_lisp_face_attribute, realize_x_face):
3189 Handle wave-style underline face attributes.
9b0e3eba
AA
3190 * xterm.c (x_draw_underwave): New function.
3191 (x_draw_glyph_string): Use it.
3192
0fb52f11
JB
31932012-06-16 Juanma Barranquero <lekktu@gmail.com>
3194
3195 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3196 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3197 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3198 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3199 ($(BLD)/w32select.$(O)): Update dependencies.
3200
e5560ff7
AS
32012012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3202
3203 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3204 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3205 * character.c (_fetch_multibyte_char_p): Remove.
3206 * alloc.c: Include "character.h" before "buffer.h".
3207 * bidi.c: Likewise.
3208 * buffer.c: Likewise.
3209 * bytecode.c: Likewise.
3210 * callint.c: Likewise.
3211 * callproc.c: Likewise.
3212 * casefiddle.c: Likewise.
3213 * casetab.c: Likewise.
3214 * category.c: Likewise.
3215 * cmds.c: Likewise.
3216 * coding.c: Likewise.
3217 * composite.c: Likewise.
3218 * dired.c: Likewise.
3219 * dispnew.c: Likewise.
3220 * doc.c: Likewise.
3221 * dosfns.c: Likewise.
3222 * editfns.c: Likewise.
3223 * emacs.c: Likewise.
3224 * fileio.c: Likewise.
3225 * filelock.c: Likewise.
3226 * font.c: Likewise.
3227 * fontset.c: Likewise.
3228 * fringe.c: Likewise.
3229 * indent.c: Likewise.
3230 * insdel.c: Likewise.
3231 * intervals.c: Likewise.
3232 * keyboard.c: Likewise.
3233 * keymap.c: Likewise.
3234 * lread.c: Likewise.
3235 * macros.c: Likewise.
3236 * marker.c: Likewise.
3237 * minibuf.c: Likewise.
3238 * nsfns.m: Likewise.
3239 * nsmenu.m: Likewise.
3240 * print.c: Likewise.
3241 * process.c: Likewise.
3242 * regex.c: Likewise.
3243 * region-cache.c: Likewise.
3244 * search.c: Likewise.
3245 * syntax.c: Likewise.
3246 * term.c: Likewise.
3247 * textprop.c: Likewise.
3248 * undo.c: Likewise.
3249 * unexsol.c: Likewise.
3250 * w16select.c: Likewise.
3251 * w32fns.c: Likewise.
3252 * w32menu.c: Likewise.
3253 * window.c: Likewise.
3254 * xdisp.c: Likewise.
3255 * xfns.c: Likewise.
3256 * xmenu.c: Likewise.
3257 * xml.c: Likewise.
3258 * xselect.c: Likewise.
3259
2f07e6af
EZ
32602012-06-16 Eli Zaretskii <eliz@gnu.org>
3261
1053a871
SM
3262 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3263 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3264 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3265 row.
3266 (handle_face_prop): Use chunk-relative overlay string index when
3267 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3268 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3269 the rightmost. (Bug#11720)
2f07e6af 3270
29b83cec
AS
32712012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3272
3273 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3274 (CATEGORY_MEMBER): Enforce 1/0 value.
3275 * category.c (_temp_category_set): Remove.
3276
4c5501e9
EZ
32772012-06-16 Eli Zaretskii <eliz@gnu.org>
3278
3279 * window.c (Fdelete_other_windows_internal)
3280 (Fdelete_window_internal): Don't access frame's mouse highlight
3281 info of the initial frame. (Bug#11677)
3282
2b570124
PE
32832012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3284
e93864f9
PE
3285 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3286 Assume USE_2_TAGS_FOR_INTS.
3287 (xreload): Adjust $tagmask width to match recent lisp.h change.
3288
2b570124
PE
3289 Simplify lisp.h in minor ways that should not affect code.
3290 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3291 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3292 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3293 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3294 (INTTYPEBITS): New macro, for clarity.
3295 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3296 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3297 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3298 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3299 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3300
81755f69
JB
33012012-06-13 Juanma Barranquero <lekktu@gmail.com>
3302
3303 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3304
16192a57
GM
33052012-06-13 Glenn Morris <rgm@gnu.org>
3306
3307 * s/bsd-common.h (BSD4_3):
3308 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3309
646b5f55
AS
33102012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3311
3312 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3313 instead of union.
3314 (XLI, XIL): Define.
1053a871
SM
3315 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3316 Use them.
3317 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3318 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3319 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3320 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3321 * frame.c (delete_frame): Remove outdated comment.
3322 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3323 USE_LISP_UNION_TYPE.
3324 (Fw32_unregister_hot_key): Likewise.
3325 (Fw32_toggle_lock_key): Likewise.
3326 * w32menu.c (add_menu_item): Likewise.
3327 (w32_menu_display_help): Use XIL instead of checking
3328 USE_LISP_UNION_TYPE.
3329 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3330 (init_heap): Likewise.
3331 * w32term.c (w32_read_socket): Update comment.
3332
1d3823c9
GM
33332012-06-13 Glenn Morris <rgm@gnu.org>
3334
c62ff706
GM
3335 * s/usg5-4-common.h, src/s/unixware.h:
3336 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3337
1d3823c9
GM
3338 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3339
bfe3e0a2
PE
33402012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3341
3342 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3343 * alloc.c (make_number) [!defined make_number]:
3344 Remove, as lisp.h always defines this now.
3345 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3346 (roundup_size): Verify that it is a power of 2.
3347 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3348 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3349 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3350 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3351 USE_LSB_TAG now is always defined to be either 0 or 1.
3352 All uses changed.
3353 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3354 code works fine either way, and efficiency is not a concern here,
3355 as the union type is for debugging, not for production.
3356 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3357 Use an inline function on all platforms when using the union type,
3358 since this is simpler and 'static inline' can be used portably
3359 within Emacs now.
3360 (LISP_INITIALLY_ZERO): New macro.
3361 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3362 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3363
45fa9c0f
GM
33642012-06-12 Glenn Morris <rgm@gnu.org>
3365
b4492cba
GM
3366 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3367
3368 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3369
45fa9c0f
GM
3370 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3371 Move BROKEN_SIGIO to configure.
3372
3373 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3374 Move NO_TERMIO to configure.
3375
0e25d334
CY
33762012-06-12 Chong Yidong <cyd@gnu.org>
3377
3378 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3379 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3380 MagickExportImagePixels is undefined.
3381
43682bb6
PE
33822012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3383
3384 * image.c (imagemagick_load_image): Remove unused label.
3385
a9be7d2b
GM
33862012-06-11 Glenn Morris <rgm@gnu.org>
3387
3388 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3389 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3390 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3391 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3392
3017f87f
SM
33932012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3394
3395 * alloc.c (make_byte_code): New function.
3396 (Fmake_byte_code): Use it. Don't purify here.
3397 * lread.c (read1): Use it as well to avoid extra allocation.
3398
1b9b4cf4
CY
33992012-06-11 Chong Yidong <cyd@gnu.org>
3400
3401 * image.c (imagemagick_load_image): Implement transparency.
3402
95988fcf
AS
34032012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3404
3405 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3406 account for preceding backslashes. (Bug#11663)
3407
cd4eb164
CY
34082012-06-09 Chong Yidong <cyd@gnu.org>
3409
3410 * term.c: Support italics in capable terminals (Bug#9652).
3411 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3412 (turn_on_face): Output using TS_enter_italic_mode if available.
3413 Don't handle unused blinking and alt-charset cases.
3414 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3415 and tty_alt_charset_p cases.
3416 (tty_capable_p, init_tty): Support italics.
3417
3418 * termchar.h (struct tty_display_info): Add field for italics.
3419 Remove unused blink field.
3420
3421 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3422 Handle slant.
3423
3424 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3425 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3426 tty_alt_charset_p. Add tty_italic_p.
3427
ff88beb8
MA
34282012-06-09 Michael Albinus <michael.albinus@gmx.de>
3429
3430 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3431 dbus_type_is_basic if available.
3432 (xd_extract_signed, xd_extract_unsigned): Rename from
3433 extract_signed and extract_unsigned, respectively. Adapt callers.
3434
44286096
CY
34352012-06-09 Chong Yidong <cyd@gnu.org>
3436
1682701f
CY
3437 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3438
44286096
CY
3439 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3440 case (Bug#9752).
3441
d86feb17
PE
34422012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3443
3444 * xdisp.c (vmessage): Treat frame message as multibyte.
3445 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3446 would generate the diagnostic "Making \302\247 buffer-local while
3447 let-bound!".
3448
d5c20fe8
EZ
34492012-06-08 Eli Zaretskii <eliz@gnu.org>
3450
3451 * dispnew.c (showing_window_margins_p): Undo last change, which
3452 was done due to an inadvertent commit.
3453 (adjust_frame_glyphs_for_frame_redisplay): Do call
3454 showing_window_margins_p.
3455
513749ee
SM
34562012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3457
3458 * eval.c (Fmake_var_non_special): New primitive.
3459 (syms_of_eval): Defsubr it.
3460 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3461
d4a8f5c1
JB
34622012-06-08 Juanma Barranquero <lekktu@gmail.com>
3463
3464 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3465 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3466
8bbbc977
EZ
34672012-06-08 Eli Zaretskii <eliz@gnu.org>
3468
3469 * alloc.c (allocate_vectorlike): Fix last change.
3470
f3372c87
DA
34712012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3472
3473 Block-based vector allocation of small vectors.
3474 * lisp.h (struct vectorlike_header): New field `nbytes',
3475 adjust comment accordingly.
3476 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3477 to denote vector blocks. Adjust users (live_vector_p,
3478 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3479 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3480 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3481 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3482 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3483 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3484 (roundup_size): New constant.
3485 (struct vector_block): New data type.
3486 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3487 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3488 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3489 (sweep_vectors): New functions.
3490 (allocate_vectorlike): Return `zero_vector' as the only vector of
3491 0 items. Allocate new vector from block if vector size is less than
3492 or equal to VBLOCK_BYTES_MAX.
3493 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3494 (init_alloc_once): Add call to init_vectors.
3495
4f18a4ed
SM
34962012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3497
3498 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3499
86f158bc
PE
35002012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3501
3502 * doprnt.c (doprnt): Truncate multibyte char correctly.
3503 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3504 would mishandle a string argument "Xc" if X was a multibyte
3505 character of length 2: it would truncate after X's first byte
3506 rather than including all of X.
3507
c5cfcbe0
CY
35082012-06-06 Chong Yidong <cyd@gnu.org>
3509
3510 * buffer.c (word_wrap): Doc fix.
3511
c05cf390
PE
35122012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3513
3514 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3515
0c3461de
GM
35162012-06-03 Glenn Morris <rgm@gnu.org>
3517
3518 * xdisp.c (tool-bar-style): Doc fix.
3519
c71232db
UM
35202012-06-03 Ulrich Müller <ulm@gentoo.org>
3521
3522 * Makefile.in (PAXCTL): Define.
3523 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3524 binary via PaX flags if the paxctl utility is available.
3525 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3526 Restore PaX flags to their default. (Bug#11398)
3527
383f7350
CY
35282012-06-03 Chong Yidong <cyd@gnu.org>
3529
3530 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3531 buffer (Bug#11226).
3532
5f2c76c6
CY
35332012-06-03 Chong Yidong <cyd@gnu.org>
3534
3535 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3536 (note_mode_line_or_margin_highlight): If there is no help echo,
3537 use mode-line-default-help-echo. Handle the case where the mouse
3538 position is past the end of the mode line string.
3539
3540 * buffer.c (buffer_local_value_1): New function, split from
3541 Fbuffer_local_value; can return Qunbound.
3542 (Fbuffer_local_value): Use it.
3543 (Vmode_line_format): Docstring tweaks.
3544
773d47f6
PE
35452012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3546
3547 * sysdep.c (system_process_attributes): Improve comment.
3548
f2d6a3df
SM
35492012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3550
3551 * keyboard.c: Export real-this-command to Elisp.
3552 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3553 and DEFVAR it. Update all users.
3554
63810350
PE
35552012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3556
7bd5c1f4
PE
3557 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3558
63810350
PE
3559 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3560 Convert pctcpu and pctmem to Lisp float properly.
3561 Let the compiler fold better, as 100.0/0x8000 is exact.
3562
a2821611
AS
35632012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3564
3565 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3566 cons_block.
3567
5fceba1d
PE
35682012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3569
3570 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3571
c98ff5dd
DA
35722012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3573
3574 For a 'struct window', replace some Lisp_Object fields to
3575 bitfields where appropriate, remove unused fields.
3576 * window.h (struct window): Remove unused 'last_mark_x' and
3577 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3578 change it's type from Lisp_Object to bitfield.
3579 Change type of 'force_start', 'optional_new_start',
3580 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3581 fields from Lisp_Object to bitfield. Adjust users accordingly.
3582
ca34e0be
PE
35832012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3584
3585 Pacify gcc -Wdouble-precision when using Xaw.
3586 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3587 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3588 Use 'float' consistently, rather than 'float' in most places
3589 and 'double' in a couple of places.
3590
efc00ab1 35912012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3592
3593 * xdisp.c (handle_stop): Detect whether we have overlay strings
3594 loaded by testing it->current.overlay_string_index to be
3595 non-negative, instead of checking whether n_overlay_strings is
3596 positive. (Bug#11587)
3597
efc00ab1 35982012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3599
3600 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3601
3602 * doc.c (Fsubstitute_command_keys): Doc fix.
3603
efc00ab1 36042012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3605
3606 * search.c (search_buffer): Remove calls to
3607 r_alloc_inhibit_buffer_relocation, as it is now called by
3608 maybe_unify_char, which was the cause of relocation of buffer text
3609 in bug#11519.
3610
efc00ab1 36112012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3612
3613 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3614 for the duration of call to load_charset, to avoid problems with
3615 callers of maybe_unify_char that access buffer text through C
3616 pointers.
3617
3618 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3619 decrement the inhibition flag, instead of just setting or
3620 resetting it.
3621
ba93a187
PE
36222012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3623
3624 Remove obsolete '#define static' cruft.
3625 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3626 This #undef was "temporary" in 2000; it is no longer needed
3627 now that '#define static' has gone away.
3628 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3629 (gray_bitmap_bits): Remove; no longer needed.
3630 All uses replaced with definiens.
3631 * xterm.c: Include "bitmaps/gray.xbm".
3632
9e4bf381
PE
36332012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3634
3635 Clean up __executable_start, monstartup when --enable-profiling.
3636 The following changes affect the code only when profiling.
3637 * dispnew.c (__executable_start): Rename from safe_bcopy.
3638 Define only on platforms that need it.
3639 * emacs.c: Include <sys/gmon.h> when profiling.
3640 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3641 (__executable_start): Remove decl, since lisp.h does it now.
3642 (safe_bcopy): Remove decl; no longer has that name.
3643 (main): Coalesce #if into single bit of code, for simplicity.
3644 Cast pointers to uintptr_t, since standard libraries want integers
3645 and not pointers.
3646 * lisp.h (__executable_start): New decl.
3647
32d72c2f
GM
36482012-05-31 Glenn Morris <rgm@gnu.org>
3649
3650 * image.c (Fimagemagick_types): Doc fix.
3651
baac5bc7
JM
36522012-05-30 Jim Meyering <meyering@redhat.com>
3653
3654 * callproc.c (Fcall_process_region): Include directory component
3655 in mkstemp error message (Bug#11586).
3656
72cb32cf
PE
36572012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3658
3659 * alloc.c, lisp.h (make_pure_vector): Now static.
3660
61b108cc
SM
36612012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3662
3663 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3664 Move to byte-run.el.
3665 (Fautoload): Do the hash-doc more carefully.
3666 * data.c (Fdefalias): Purify definition, except for keymaps.
3667 (Qdefun): Move from eval.c.
3668 * lisp.h (Qdefun): Remove.
3669 * lread.c (read1): Tiny simplification.
3670
471fe23d
TN
36712012-05-29 Troels Nielsen <bn.troels@gmail.com>
3672
934f3f58 3673 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3674 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3675 Bug#9642, but explicitly check that the buffer the overlay would
3676 be moved to is live and rearrange lines to make sure that errors
3677 will not put the overlay in an inconsistent state.
3678 (Fdelete_overlay): Cosmetics.
3679
85d0efd1
EZ
36802012-05-28 Eli Zaretskii <eliz@gnu.org>
3681
3682 * w32term.c (my_bring_window_to_top): New function.
3683 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3684 could be different from the original one.
3685 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3686 (Bug#11513)
3687
3688 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3689 by calling BringWindowToTop.
3690
3691 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3692 (WM_EMACS_END): Increase by one.
3693
da92a98c
PE
36942012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3695
3696 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3697 This avoids undefined behavior that might cause the eassert
3698 to not catch an out-of-range value.
3699
74d1f848
JB
37002012-05-28 Juanma Barranquero <lekktu@gmail.com>
3701
3702 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3703 Update dependencies.
3704
9e1a06fc
EZ
37052012-05-27 Eli Zaretskii <eliz@gnu.org>
3706
3707 * bidi.c (bidi_mirror_char): Fix last change.
3708
f3dd7312
AS
37092012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3710
3711 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3712 when referring to sectname field in printf format.
3713
81899c91
PE
37142012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3715
57b81a9f
PE
3716 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3717 Only r_alloc_inhibit_buffer_relocation needed to be added;
3718 the others were already declared.
3719
81899c91
PE
3720 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3721 before checking whether it's out of range. Put the check inside
3722 eassert. See
3723 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3724
33017faf 37252012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3726
3727 * callproc.c (Fcall_process): Restore a line that was accidentally
3728 commented out in the 2011-02-13 change (bug#11547).
3729
33017faf 37302012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3731
3732 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3733 defined on ralloc.c.
3734
3735 * buffer.c [REL_ALLOC]: Remove prototypes of
3736 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3737 they are now on lisp.h.
3738
3739 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3740
3741 * search.c (search_buffer): Use it to inhibit relocation of buffer
3742 text while re_search_2 is doing its job, because re_search_2 is
3743 passed C pointers to buffer text. (Bug#11519)
3744
23415acf
EZ
3745 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3746 Update value to 24.
3747
44e27368
EZ
3748 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3749 state after an additional call to move_it_in_display_line_to, keep
3750 the values of it->max_ascent and it->max_descent found for the
3751 entire line.
3752 (pos_visible_p): Revert the comparison against bottom_y to what it
3753 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3754 (Bug#11464)
3755
c1892f11
PE
37562012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3757
3758 Fix coding-related core dumps with gcc -ftrapv.
3759 The code was computing A - B, where A and B are pointers, and B is
3760 random garbage. This can lead to core dumps on platforms that
3761 have special pointer registers, and it also leads to core dumps on
3762 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3763 A - B only when B is initialized properly.
3764 * coding.c (coding_set_source, coding_set_destination): Return void.
3765 (coding_change_source, coding_change_destinations): New functions,
3766 with the old behaviors of coding_set_source and coding_set_destination.
3767 All callers that need an offset changed to use these new functions.
3768
eb7afdad
GM
37692012-05-26 Glenn Morris <rgm@gnu.org>
3770
3771 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3772
f12fdf02
EZ
37732012-05-26 Eli Zaretskii <eliz@gnu.org>
3774
53a63be6 3775 Extend mouse support on W32 text-mode console.
61b108cc
SM
3776 * xdisp.c (draw_row_with_mouse_face):
3777 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3778
eb3f6f01 3779 * w32console.c: Include window.h.
61b108cc
SM
3780 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3781 New functions.
eb3f6f01
EZ
3782 (initialize_w32_display): Initialize mouse-highlight data.
3783
53a63be6
EZ
3784 * w32inevt.c: Include termchar.h and window.h.
3785 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3786 moves, call note_mouse_highlight. If help_echo changed, call
3787 gen_help_event to produce help-echo message in the echo area.
3788 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3789 highlight info.
3790
4cfd81f6
PE
37912012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3792
3793 * lread.c (read1): Simplify slightly to avoid an overflow warning
3794 with GCC 4.7.0 on x86-64.
3795
4446092a
EZ
37962012-05-26 Eli Zaretskii <eliz@gnu.org>
3797
3798 * bidi.c (bidi_mirror_char): Revert last change: an int is
3799 definitely wide enough here.
3800
42b2a986 38012012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3802
42b2a986 3803 Fix integer width and related bugs (Bug#9874).
eb106a49 3804 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3805 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3806 (string_bytes, check_sblock, allocate_string_data):
3807 (compact_small_strings, Fmake_bool_vector, make_string)
3808 (make_unibyte_string, make_multibyte_string)
3809 (make_string_from_bytes, make_specified_string)
3810 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3811 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3812 (mark_vectorlike):
3813 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3814 (allocate_pseudovector):
3815 Use int, not EMACS_INT, where int is wide enough.
3816 (inhibit_garbage_collection, Fgarbage_collect):
3817 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3818 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3819 int might not be wide enough.
3820 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3821 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3822 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3823 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3824 (bidi_level_of_next_char, bidi_move_to_visually_next):
3825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3826 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3827 (Fkill_buffer, Fset_buffer_major_mode)
3828 (advance_to_char_boundary, Fbuffer_swap_text)
3829 (Fset_buffer_multibyte, overlays_at, overlays_in)
3830 (overlay_touches_p, struct sortvec, record_overlay_string)
3831 (overlay_strings, recenter_overlay_lists)
3832 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3833 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3834 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3835 (Foverlay_recenter, last_overlay_modification_hooks_used)
3836 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3837 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3838 (validate_region): Omit unnecessary test for b <= e,
3839 since that's guaranteed by the previous test.
d311d28c
PE
3840 (adjust_overlays_for_delete): Avoid pos + length overflow.
3841 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3842 (report_overlay_modification):
3843 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3844 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3845 Omit pointer cast, which isn't needed anyway, and doesn't work
3846 after the EMACS_INT -> ptrdiff_t change.
02481186 3847 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3848 * buffer.h: Adjust decls to match defn changes elsewhere.
3849 (struct buffer_text, struct buffer):
3850 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3851 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3852 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3853 not int, to avoid needless 32-bit limit on 64-bit hosts.
3854 (exec_byte_code): Use tighter memory-full test, one that checks
3855 for alloca overflow. Don't compute the address of the object just
3856 before an array, as that's not portable. Use EMACS_INT, not
3857 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3858 * callint.c (Fcall_interactively):
3859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3860 * callproc.c (call_process_kill, Fcall_process):
3861 Don't assume pid_t fits into an Emacs fixnum.
3862 (call_process_cleanup, Fcall_process, child_setup):
3863 Don't assume pid_t fits into int.
3864 (call_process_cleanup, Fcall_process, delete_temp_file)
3865 (Fcall_process_region):
3866 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3867 (Fcall_process): Simplify handling of volatile integers.
3868 Use int, not EMACS_INT, where int will do.
3869 * casefiddle.c (casify_object, casify_region, operate_on_word)
3870 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3871 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3872 (casify_object): Avoid integer overflow when overallocating buffer.
3873 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3874 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3875 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3876 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3877 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3878 integers are now checked earlier. All uses replaced with XINT.
3879 (ccl_driver):
3880 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3881 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3882 (ccl_driver, Fregister_code_conversion_map):
3883 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3884 (resolve_symbol_ccl_program): Check that vector header is in range.
3885 Always copy the vector, so that we can check its contents reliably
3886 now rather than having to recheck each instruction as it's being
3887 executed. Check that vector words fit in 'int'.
3888 (ccl_get_compiled_code, Fregister_ccl_program)
3889 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3890 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3891 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3892 contents are in range.
3893 (Fccl_execute_on_string): Check that status is in range.
3894 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3895 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3896 Accept and return EMACS_INT, not int, because callers can pass values
3897 out of 'int' range.
3898 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3899 (multibyte_chars_in_text, parse_str_as_multibyte)
3900 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3901 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3902 (string_escape_byte8, Fget_byte):
3903 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3904 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3905 avoid mishandling large integers.
3906 * character.h: Adjust decls to match defn changes elsewhere.
3907 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3908 (Ffind_charset_region):
3909 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3910 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3911 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3912 Don't assume fixnum fits in int.
d311d28c
PE
3913 (load_charset_map_from_vector, Fmap_charset_chars):
3914 Remove now-unnecessary CHECK_NATNUMs.
3915 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3916 Don't rely on undefined behavior with signed left shift overflow.
3917 Don't assume unsigned int fits into fixnum, or that fixnum fits
3918 into unsigned int. Don't require max_code to be a valid fixnum;
3919 that's not true for gb10830 4-byte on a 32-bit host. Allow
3920 invalid_code to be a cons, for the same reason. Require code_offset
3921 to be a character. Avoid int overflow if max_char is close
3922 to INT_MAX.
3923 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3924 this is intended anyway and avoids some undefined behavior.
3925 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3926 INDEX_TO_CODE_POINT, as that's what it expects.
3927 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3928 * charset.h (DECODE_CHAR): Return int, not unsigned;
3929 this is what was intended anyway, and it avoids undefined behavior.
3930 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3931 integer-overflow issues.
3932 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3933 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3934 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3935 * chartab.c (Fmake_char_table, Fset_char_table_range)
3936 (uniprop_get_decoder, uniprop_get_encoder):
3937 Don't assume fixnum fits in int.
3938 * cmds.c (move_point): New function, that does the gist of
3939 Fforward_char and Fbackward_char, but does so while checking
3940 for integer overflow more accurately.
c96e5d6a 3941 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3942 (Fforward_line, Fend_of_line, internal_self_insert)
3943 (internal_self_insert):
3944 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3945 Fix a FIXME, by checking for integer overflow when calculating
3946 target_clm and actual_clm.
3947 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3948 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3949 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3950 (coding_alloc_by_making_gap, alloc_destination)
3951 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3952 (encode_coding_utf_16, detect_coding_emacs_mule)
3953 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3954 (detect_coding_iso_2022, decode_coding_iso_2022)
3955 (encode_invocation_designation, encode_designation_at_bol)
3956 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3957 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3958 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3959 (encode_coding_ccl, encode_coding_raw_text)
3960 (detect_coding_charset, decode_coding_charset)
3961 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3962 (produce_composition, produce_charset, produce_annotation)
3963 (decode_coding, handle_composition_annotation)
3964 (handle_charset_annotation, consume_chars, decode_coding_gap)
3965 (decode_coding_object, encode_coding_object, detect_coding_system)
3966 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3967 (code_convert_region, code_convert_string)
8f50130c
PE
3968 (Fdefine_coding_system_internal)
3969 (coding_set_source, coding_set_destination):
d311d28c
PE
3970 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3971 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3972 (Fdefine_coding_system_internal):
3973 Don't assume fixnums fit in int.
3974 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3975 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3976 (Funencodable_char_position, Fcheck_coding_systems_region)
3977 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3978 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3979 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3980 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3981 Don't access memory outside of the args array.
d311d28c 3982 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3983 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3984 result of ENCODE_CHAR.
d311d28c
PE
3985 * coding.h: Adjust decls to match defn changes elsewhere.
3986 (struct coding_system):
3987 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3988 * composite.c (get_composition_id, find_composition)
3989 (run_composition_function, update_compositions)
3990 (compose_text, composition_gstring_put_cache)
3991 (composition_gstring_p, composition_gstring_width)
3992 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3993 (composition_compute_stop_pos, composition_reseat_it)
3994 (composition_update_it, struct position_record)
3995 (find_automatic_composition, composition_adjust_point)
3996 (Fcomposition_get_gstring, Ffind_composition_internal):
3997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3998 (update_compositions):
3999 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4000 * composite.h: Adjust decls to match defn changes elsewhere.
4001 (struct composition):
4002 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4003 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4004 Do not attempt to compute the address of the object just before a
4005 buffer; this is not portable.
4006 (Faref, Faset):
4007 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4008 (Faset): Use int, not EMACS_INT, where int is wide enough.
4009 (Fstring_to_number): Don't assume fixnums fit in int.
4010 (Frem): Don't assume arg is nonnegative.
4011 * dbusbind.c (xd_append_arg): Check for integers out of range.
4012 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4013 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4014 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4015 (xd_get_connection_references): Return ptrdiff_t, not int.
4016 All uses changed.
4017 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4018 (xd_read_message_1):
4019 Use int, not unsigned, where the dbus API uses int.
4020 (Fdbus_message_internal): Don't overflow mtype.
4021 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4022 * dired.c (directory_files_internal, file_name_completion, scmp)
4023 (file_name_completion_stat):
4024 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4025 (file_name_completion): Don't overflow matchcount.
4026 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4027 * dispextern.h: Adjust decls to match defn changes elsewhere.
4028 (struct text_pos, struct glyph, struct bidi_saved_info)
4029 (struct bidi_string_data, struct bidi_it, struct composition_it)
4030 (struct it):
4031 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4032 (struct display_pos, struct composition_it, struct it):
4033 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4034 * dispnew.c (increment_matrix_positions)
4035 (increment_row_positions, mode_line_string)
4036 (marginal_area_string):
4037 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4038 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4039 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4040 (duration_to_sec_usec): New function, to check for overflow better.
4041 (Fsleep_for, sit_for): Use it.
4042 * doc.c (get_doc_string, store_function_docstring):
4043 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4044 (get_doc_string, Fsnarf_documentation):
4045 Use int, not EMACS_INT, where int is wide enough.
4046 (get_doc_string):
4047 Use SAFE_ALLOCA, not alloca.
4048 Check for overflow when converting EMACS_INT to off_t.
4049 * doprnt.c (doprnt):
4050 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4051 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4052 Don't assume uid_t fits into fixnum.
4053 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4054 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4055 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4056 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4057 (general_insert_function)
4058 (Finsert_char, make_buffer_string, make_buffer_string_both)
4059 (update_buffer_properties, Fbuffer_substring)
4060 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4061 (Fsubst_char_in_region, check_translation)
4062 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4063 (transpose_markers, Ftranspose_regions):
4064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4065 (clip_to_bounds): Move to lisp.h as an inline function).
4066 (Fconstrain_to_field): Don't assume integers are nonnegative.
4067 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4068 (Fsubst_char_in_region, Fsave_restriction):
4069 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4070 (Femacs_pid): Don't assume pid_t fits into fixnum.
4071 (lo_time): Use int, not EMACS_INT, when int suffices.
4072 (lisp_time_argument): Check for usec out of range.
4073 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4074 (Fuser_login_name, Fuser_full_name): Signal an error
4075 if a uid argument is out of range, rather than relying on
4076 undefined behavior.
c8d5c857
PE
4077 (Fformat_time_string): Remove now-unnecessary check.
4078 lisp_time_argument checks for out-of-range usec now.
243e0530 4079 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4080 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4081 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4082 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4083 (init_cmdargs, Fdump_emacs):
4084 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4085 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4086 the bottom (typically) 32 bits of the fixnum.
4087 * eval.c (specpdl_size, call_debugger):
4088 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4089 (when_entered_debugger, Fbacktrace_debug):
4090 Don't assume fixnum can fit in int.
4091 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4092 the object just before a buffer; this is not portable.
4093 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4094 (grow_specpdl, unbind_to):
4095 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4096 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4097 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4098 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4099 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4100 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4102 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4103 (a_write, e_write):
4104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4105 (Fcopy_file, non_regular_nbytes, read_non_regular)
4106 (Finsert_file_contents):
4107 Use int, not EMACS_INT, where int is wide enough.
4108 (READ_BUF_SIZE): Verify that it fits in int.
4109 (Finsert_file_contents): Check that counts are in proper range,
4110 rather than assuming fixnums fit into ptrdiff_t etc.
4111 Don't assume fixnums fit into int.
125b3835 4112 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4113 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4114 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4115 (string_char_to_byte, string_byte_to_char)
4116 (string_make_multibyte, string_to_multibyte)
4117 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4118 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4119 (substring_both, Fdelete, internal_equal, Ffillarray)
4120 (Fclear_string, mapcar1)
4121 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4122 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4123 (larger_vector, make_hash_table, maybe_resize_hash_table)
4124 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4125 (Fmaphash, secure_hash):
4126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4127 (concat): Check for string index and length overflow.
4128 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4129 (Frequire):
4130 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4131 (larger_vector): New API (vec, incr_min, size_max) replaces old
4132 one (vec, new_size, init). This catches size overflow.
4133 INIT was removed because it was always Qnil.
4134 All callers changed.
4135 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4136 the upper bound on a hash table index size.
4137 (make_hash_table, maybe_resize_hash_table): Use it.
4138 (secure_hash): Computer start_byte and end_byte only after
4139 they're known to be in ptrdiff_t range.
4140 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4141 (Ffont_get_glyphs, Ffont_at):
4142 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4143 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4144 (Flist_fonts, Fopen_font):
4145 Don't assume fixnum can fit in int.
4146 (check_gstring): Don't assume index can fit in int.
4147 (font_match_p): Check that fixnum is a character, not a nonnegative
4148 fixnum, since the later code needs to stuff it into an int.
4149 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4150 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4151 conversion overflow issues.
4152 (Fopen_font): Check for integer out of range.
4153 (Ffont_get_glyphs): Don't assume index can fit in int.
4154 * font.h: Adjust decls to match defn changes elsewhere.
4155 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4156 integer overflow.
4157 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4158 printmax_t, where ptrdiff_t is wide enough.
4159 (Finternal_char_font):
4160 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4161 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4162 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4163 (Fset_frame_position, x_set_frame_parameters)
4164 (x_set_line_spacing, x_set_border_width)
4165 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4166 Check that fixnums are in proper range for system types.
4167 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4168 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4169 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4170 Use SAFE_ALLOCA_LISP, not alloca.
4171 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4172 intptr_t is wide enough.
4173 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4174 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4175 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4176 Check for fixnum out of range.
4177 * ftfont.c (ftfont_list): Don't assume index fits in int.
4178 Check that fixnums are in proper range for system types.
4179 (ftfont_shape_by_flt):
4180 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4181 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4182 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4183 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4184 Check that fixnums are in proper range for system types.
4185 * gnutls.h: Adjust decls to match defn changes elsewhere.
4186 * gtkutil.c (xg_dialog_run):
4187 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4188 (update_frame_tool_bar):
4189 Check that fixnums are in proper range for system types.
4190 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4191 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4192 * indent.c (last_known_column, last_known_column_point):
4193 (current_column_bol_cache):
4194 (skip_invisible, current_column, check_display_width):
4195 (check_display_width, scan_for_column, current_column_1)
4196 (Findent_to, Fcurrent_indentation, position_indentation)
4197 (indented_beyond_p, Fmove_to_column, compute_motion):
4198 (Fcompute_motion, Fvertical_motion):
4199 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4200 (last_known_column_modified): Use EMACS_INT, not int.
4201 (check_display_width):
4202 (Fcompute_motion):
4203 Check that fixnums and floats are in proper range for system types.
4204 (compute_motion): Don't assume index or fixnum fits in int.
4205 (compute_motion, Fcompute_motion):
4206 Use int, not EMACS_INT, when it is wide enough.
4207 (vmotion): Omit local var start_hpos that is always 0; that way
4208 we don't need to worry about overflow in expressions involving it.
4209 * indent.h: Adjust decls to match defn changes elsewhere.
4210 (struct position):
4211 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4212 Use int, not EMACS_INT, where int is wide enough.
4213 Remove unused members ovstring_chars_done and tab_offset;
4214 all uses removed.
4215 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4216 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4217 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4218 (make_gap, copy_text, insert, insert_and_inherit)
4219 (insert_before_markers, insert_before_markers_and_inherit)
4220 (insert_1, count_combining_before, count_combining_after)
4221 (insert_1_both, insert_from_string)
4222 (insert_from_string_before_markers, insert_from_string_1)
4223 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4224 (adjust_after_replace, adjust_after_insert, replace_range)
4225 (replace_range_2, del_range, del_range_1, del_range_byte)
4226 (del_range_both, del_range_2, modify_region)
4227 (prepare_to_modify_buffer, signal_before_change)
4228 (signal_after_change, Fcombine_after_change_execute):
4229 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4230 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4231 (balance_an_interval, split_interval_right, split_interval_left)
4232 (find_interval, next_interval, update_interval)
4233 (adjust_intervals_for_insertion, delete_node, delete_interval)
4234 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4235 (static_offset_intervals, offset_intervals)
4236 (merge_interval_right, merge_interval_left, make_new_interval)
4237 (graft_intervals_into_buffer, temp_set_point_both)
4238 (temp_set_point, set_point, adjust_for_invis_intang)
4239 (set_point_both, move_if_not_intangible, get_property_and_range)
4240 (get_local_map, copy_intervals, copy_intervals_to_string)
4241 (compare_string_intervals, set_intervals_multibyte_1):
4242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4243 * intervals.h: Adjust decls to match defn changes elsewhere.
4244 (struct interval):
4245 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4246 * keyboard.c (this_command_key_count, this_single_command_key_start)
4247 (before_command_key_count, before_command_echo_length, echo_now)
4248 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4249 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4250 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4251 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4252 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4253 (last_non_minibuf_size, last_point_position, echo_truncate)
4254 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4255 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4256 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4257 (stuff_buffered_input):
4258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4259 (last_auto_save, command_loop_1, read_char):
4260 Use EMACS_INT, not int, to avoid integer overflow.
4261 (record_char): Avoid overflow in total_keys computation.
4262 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4263 * keyboard.h: Adjust decls to match defn changes elsewhere.
4264 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4265 (Fkey_description, Fdescribe_vector, Flookup_key):
4266 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4267 (click_position): New function, to check that positions are in range.
4268 (Fcurrent_active_maps):
4269 (describe_command):
4270 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4271 (Faccessible_keymaps, Fkey_description):
4272 (preferred_sequence_p):
4273 Don't assume fixnum can fit into int.
4274 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4275 Check for integer overflow in size calculations.
4276 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4277 avoid mishandling large integers.
4278 * lisp.h: Adjust decls to match defn changes elsewhere.
4279 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4280 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4281 (struct Lisp_Marker):
4282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4283 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4284 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4285 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4286 All callers changed.
4287 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4288 Assume the arg has valid form, since it always does.
4289 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4290 unsigned integer system type.
4291 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4292 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4293 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4294 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4295 (duration_to_sec_usec): New decl.
4296 * lread.c (read_from_string_index, read_from_string_index_byte)
4297 (read_from_string_limit, readchar, unreadchar, openp)
4298 (read_internal_start, read1, oblookup):
4299 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4300 (Fload, readevalloop, Feval_buffer, Feval_region):
4301 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4302 (openp): Check for out-of-range argument to 'access'.
4303 (read1): Use int, not EMACS_INT, where int is wide enough.
4304 Don't assume fixnum fits into int.
6efdadfd 4305 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4306 (read_filtered_event): Use duration_to_sec_usec
4307 to do proper overflow checking on durations.
d311d28c
PE
4308 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4309 in size calculation.
4310 (Fexecute_kbd_macro):
4311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4312 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4313 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4314 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4315 (set_marker_both, set_marker_restricted_both, marker_position)
4316 (marker_byte_position, Fbuffer_has_markers_at):
4317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4318 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4319 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4320 It now merely ensures that the menu is large enough, without
4321 necessarily growing it, as this avoids some integer overflow issues.
4322 All callers changed.
4323 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4325 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4326 Use SAFE_ALLOCA_LISP, not alloca.
4327 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4328 to EMACS_INT. Check that fixnums are in proper range for system types.
4329 * minibuf.c (minibuf_prompt_width, string_to_object)
4330 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4331 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4332 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4333 (get_minibuffer, read_minibuf_unwind):
4334 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4335 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4336 this simplifies overflow checking. All callers changed.
4337 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4338 (Ftest_completion):
4339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4340 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4341 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4342 Check that fixnums are in proper range for system types.
4343 (Fx_create_frame, Fx_show_tip):
4344 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4345 * nsfont.m (ns_findfonts, nsfont_list_family):
4346 Don't assume fixnum fits in long.
4347 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4348 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4349 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4350 wide enough.
17fdb222 4351 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4352 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4353 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4354 (PRINTDECLARE, PRINTPREPARE):
4355 (strout, print_string):
4356 (print, print_preprocess, print_check_string_charset_prop)
4357 (print_object):
4358 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4359 (PRINTDECLARE):
4360 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4361 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4362 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4363 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4364 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4365 (print_error_message): Use SAFE_ALLOCA, not alloca.
4366 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4367 (print_depth, new_backquote_output, print_number_index):
4368 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4369 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4370 (Fset_process_window_size, Fformat_network_address)
4371 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4372 (sigchld_handler):
d311d28c 4373 Check that fixnums are in proper range for system types.
d44287d4 4374 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4375 Check for process-ids out of pid_t range rather than relying on
4376 undefined behavior.
e4d81efc 4377 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4378 (Fformat_network_address, read_process_output, send_process)
4379 (Fprocess_send_region, status_notify):
4380 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4381 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4382 (wait_reading_process_output, read_process_output, exec_sentinel):
4383 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4384 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4385 (Faccept_process_output): Use duration_to_sec_usec to do proper
4386 overflow checking on durations.
dde14581
PE
4387 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4388 Don't assume pid_t fits in int.
02481186
PE
4389 * process.h (struct Lisp_Process): Members tick and update_tick
4390 are now of type EMACS_INT, not int.
b62b53e8
PE
4391 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4392 configured --with-wide-int.
d311d28c
PE
4393 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4394 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4395 * search.c (looking_at_1, string_match_1):
4396 (fast_string_match, fast_c_string_match_ignore_case)
4397 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4398 (scan_newline, find_before_next_newline, search_command)
4399 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4400 (set_search_regs, wordify):
4401 (Freplace_match):
4402 (Fmatch_data):
4403 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4404 (string_match_1, search_buffer, set_search_regs):
4405 (Fmatch_data):
4406 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4407 (wordify): Check for overflow in size calculation.
4408 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4409 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4410 Check that fixnums are in proper range for system types.
4411 * sound.c (struct sound_device)
4412 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4414 (Fplay_sound_internal):
4415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4416 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4417 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4418 (Fparse_partial_sexp):
4419 Don't assume fixnums can fit in int.
4420 (struct lisp_parse_state, find_start_pos, find_start_value)
4421 (find_start_value_byte, find_start_begv)
4422 (update_syntax_table, char_quoted, dec_bytepos)
4423 (find_defun_start, prev_char_comend_first, back_comment):
4424 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4425 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4426 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4427 (Finternal_describe_syntax_value): Check that match_lisp is a
4428 character, not an integer, since the code stuffs it into int.
4429 (scan_words, scan_sexps_forward):
4430 Check that fixnums are in proper range for system types.
4431 (Fforward_word):
4432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4433 (scan_sexps_forward):
4434 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4435 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4436 * syntax.h: Adjust decls to match defn changes elsewhere.
4437 (struct gl_state_s):
4438 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4439 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4440 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4441 * sysdep.c (wait_for_termination_1, wait_for_termination)
4442 (interruptible_wait_for_termination, mkdir):
4443 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4444 (emacs_read, emacs_write):
4445 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4446 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4447 and double all fit in int.
d311d28c
PE
4448 * term.c (set_tty_color_mode):
4449 Check that fixnums are in proper range for system types.
4450 * termhooks.h (struct input_event):
4451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4452 * textprop.c (validate_interval_range, interval_of)
4453 (Fadd_text_properties, set_text_properties_1)
4454 (Fremove_text_properties, Fremove_list_of_text_properties)
4455 (Ftext_property_any, Ftext_property_not_all)
4456 (copy_text_properties, text_property_list, extend_property_ranges)
4457 (verify_interval_modification):
4458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4459 (Fnext_single_char_property_change)
4460 (Fprevious_single_char_property_change):
4461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4462 (copy_text_properties):
4463 Check for integer overflow in index calculation.
d311d28c
PE
4464 * undo.c (last_boundary_position, record_point, record_insert)
4465 (record_delete, record_marker_adjustment, record_change)
4466 (record_property_change):
4467 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4468 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4469 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4470 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4471 (Fx_hide_tip, Fx_file_dialog):
4472 * w32menu.c (set_frame_menubar):
4473 Use ptrdiff_t, not int, for consistency with rest of code.
4474 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4475 (select_window, Fdelete_other_windows_internal)
4476 (window_scroll_pixel_based, window_scroll_line_based)
4477 (Frecenter, Fset_window_configuration):
4478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4479 (Fset_window_hscroll, run_window_configuration_change_hook)
4480 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4481 (Fscroll_other_window, Frecenter):
d311d28c
PE
4482 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4483 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4484 Don't assume fixnum fits in int.
4485 (Fset_window_scroll_bars):
4486 Check that fixnums are in proper range for system types.
4487 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4488 (string_pos, c_string_pos, number_of_chars, init_iterator)
4489 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4490 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4491 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4492 (face_before_or_after_it_pos, handle_invisible_prop)
4493 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4494 (display_prop_intangible_p, string_buffer_position_lim)
4495 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4496 (get_overlay_strings_1, get_overlay_strings)
4497 (iterate_out_of_display_property, forward_to_next_line_start)
4498 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4499 (get_next_display_element, set_iterator_to_next)
4500 (get_visually_first_element, compute_stop_pos_backwards)
4501 (handle_stop_backwards, next_element_from_buffer)
4502 (move_it_in_display_line_to, move_it_in_display_line)
4503 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4504 (add_to_log, message_dolog, message_log_check_duplicate)
4505 (message2, message2_nolog, message3, message3_nolog
4506 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4507 (current_message_1, truncate_echo_area, truncate_message_1)
4508 (set_message, set_message_1, store_mode_line_noprop)
4509 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4510 (text_outside_line_unchanged_p, check_point_in_composition)
4511 (reconsider_clip_changes)
4512 (redisplay_internal, set_cursor_from_row, try_scrolling)
4513 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4514 (redisplay_window, find_last_unchanged_at_beg_row)
4515 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4516 (trailing_whitespace_p, find_row_edges, display_line)
4517 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4518 (display_mode_element, store_mode_line_string)
4519 (pint2str, pint2hrstr, decode_mode_spec)
4520 (display_count_lines, display_string, draw_glyphs)
4521 (x_produce_glyphs, x_insert_glyphs)
4522 (rows_from_pos_range, mouse_face_from_buffer_pos)
4523 (fast_find_string_pos, mouse_face_from_string_pos)
4524 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4525 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4526 (safe_call, init_from_display_pos, handle_fontified_prop)
4527 (handle_single_display_spec, load_overlay_strings)
4528 (with_echo_area_buffer, setup_echo_area_for_printing)
4529 (display_echo_area, echo_area_display)
4530 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4531 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4532 (redisplay_window, dump_glyph_row, display_mode_line)
4533 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4534 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4535 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4536 (handle_single_display_spec, build_desired_tool_bar_string)
4537 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4538 (get_specified_cursor_type):
4539 Check that fixnums are in proper range for system types.
4540 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4541 (Flookup_image_map):
4542 Don't assume fixnums fit in int.
4543 (compare_overlay_entries):
4544 Avoid mishandling comparisons due to subtraction overflow.
4545 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4546 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4547 (handle_tool_bar_click):
4548 Use int, not unsigned, since we prefer signed and the signedness
4549 doesn't matter here.
4550 (get_next_display_element, next_element_from_display_vector):
4551 Use int, not EMACS_INT, when int is wide enough.
4552 (start_hourglass): Use duration_to_sec_usec to do proper
4553 overflow checking on durations.
4554 * xfaces.c (Fbitmap_spec_p):
4555 Check that fixnums are in proper range for system types.
4556 (compare_fonts_by_sort_order):
4557 Avoid mishandling comparisons due to subtraction overflow.
4558 (Fx_family_fonts, realize_basic_faces):
4559 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4560 (Fx_family_fonts):
4561 Don't assume fixnum fits in int.
4562 Use SAFE_ALLOCA_LISP, not alloca.
4563 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4564 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4565 (face_at_buffer_position, face_for_overlay_string)
4566 (face_at_string_position):
4567 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4568 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4569 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4570 (Fx_show_tip):
4571 Check that fixnums are in proper range for system types.
4572 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4573 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4574 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4575 (Fx_change_window_property): Don't assume fixnums fit in int.
4576 * xfont.c (xfont_chars_supported):
4577 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4578 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4579 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4580 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4581 * xml.c (parse_region):
4582 * xrdb.c (magic_file_p):
4583 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4584 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4585 (x_get_local_selection, x_reply_selection_request)
4586 (x_handle_selection_request, wait_for_property_change):
4587 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4588 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4589 short is wide enough.
4590 (x_send_client_event): Don't assume fixnum fits in int.
4591 * xterm.c (x_x_to_emacs_modifiers):
4592 Don't assume EMACS_INT overflows nicely into int.
4593 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4594 may come from Lisp.
4595 (handle_one_xevent): NATNUMP can eval its arg twice.
4596 (x_connection_closed):
4597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4598 * xterm.h: Adjust decls to match defn changes elsewhere.
4599 (struct scroll_bar): Use struct vectorlike_header
4600 rather than rolling our own approximation.
4601 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4602
c6574eb5
GM
46032012-05-25 Glenn Morris <rgm@gnu.org>
4604
4605 * lisp.mk (lisp): Update for more files being compiled now.
4606
e8d32c7e
SM
46072012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4608
48def666
SM
4609 * lread.c: Remove `read_pure' which makes no difference.
4610 (read_pure): Remove var.
4611 (unreadpure): Remove function.
4612 (readevalloop): Don't call read_list with -1 flag.
4613 (read1, read_vector): Don't test read_pure any more.
4614 (read_list): Simplify.
4615
e8d32c7e
SM
4616 * fileio.c, character.h: Minor style tweaks.
4617
4b2addb7
DA
46182012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4619
4620 * window.h (clip_changed): Remove useless declaration.
4621
584461b2
JB
46222012-05-22 Juanma Barranquero <lekktu@gmail.com>
4623
4624 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4625 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4626
34374650
PE
46272012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4628
4629 Remove src/m/*.
4630 This directory predates autoconf and is no longer needed nowadays.
4631 Move its few remaining bits of functionality to where they're needed.
4632 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4633 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4634 * m/template.h: Remove.
4635 * Makefile.in (M_FILE): Remove. All uses removed.
4636 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4637 * lisp.h (USE_LSB_TAG):
4638 * mem-limits.h (EXCEEDS_LISP_PTR):
4639 Use VAL_MAX, not VALBITS, in #if.
4640 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4641 (EMACS_UINT): Define unconditionally now.
4642 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4643 (BITS_PER_EMACS_INT): New constants, replacing
4644 what used to be in config.h, but not useful in #if.
4645 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4646 define them any more.
4647 (VAL_MAX): New macro.
4648 (VALMASK): Use it.
4649 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4650 BITS_PER_EMACS_INT, in #if.
4651 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4652 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4653 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4654 * s/ms-w32.h (DATA_START):
4655 Move here from removed file m/intel386.h.
4656 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4657 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4658
261cb4bb
PE
46592012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4660
4661 Assume C89 or later.
4662 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4663 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4664 (xrealloc):
4665 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4666 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4667 * textprop.c, tparam.c (NULL): Remove.
4668 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4669 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4670 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4671 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4672 * xterm.c (input_signal_count): Assume volatile works.
4673
ff23cd9f
KB
46742012-05-21 Ken Brown <kbrown@cornell.edu>
4675
4676 * xgselect.c (xg_select): Fix first argument in call to 'select'
4677 (bug#11508).
4678
1b170bc6
KB
46792012-05-20 Ken Brown <kbrown@cornell.edu>
4680
4681 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4682 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4683
b2f4d39f
KB
46842012-05-19 Ken Brown <kbrown@cornell.edu>
4685
4686 * xfns.c (x_in_use): Remove `static' qualifier.
4687 * xterm.h (x_in_use): Declare.
4688 * xgselect.c: Include xterm.h.
4689 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4690 and `display_arg' (bug#9754).
4691
003fdae2
PE
46922012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4693
9232a6d9
PE
4694 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4695
003fdae2
PE
4696 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4697 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4698
784b56e2
EZ
46992012-05-18 Eli Zaretskii <eliz@gnu.org>
4700
4701 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4702
4703 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4704 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4705
4706 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4707 reference to image_cache->refcount.
4708 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4709
a0a79cde
JL
47102012-05-17 Juri Linkov <juri@jurta.org>
4711
4712 * search.c (Fword_search_regexp, Fword_search_backward)
4713 (Fword_search_forward, Fword_search_backward_lax)
4714 (Fword_search_forward_lax): Move functions to isearch.el
4715 (bug#10145, bug#11381).
4716
b0572523
PE
47172012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4718
4719 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4720
9660f5fc
SM
47212012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4722
4723 * lread.c (init_obarray): Declare Qt and Qnil as special.
4724
4374de83
GM
47252012-05-14 Glenn Morris <rgm@gnu.org>
4726
4727 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4728 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4729
dc44c39a
PE
47302012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4731
078c97cb
PE
4732 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4733
dc44c39a
PE
4734 * unexaix.c: Port to more-recent AIX compilers.
4735 (report_error, report_error_1, make_hdr, copy_sym)
4736 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4737 Make arguments const char *, not char *, to avoid violations of C
4738 standard and to fix some AIX warnings reported by Gilles Pion.
4739
e18afed7 47402012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4741
4742 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4743 already have overlays loaded.
4744 (handle_single_display_spec): Before returning without displaying
4745 fringe bitmap, synchronize the bidi iterator with the main display
4746 iterator, by calling iterate_out_of_display_property.
4747 (iterate_out_of_display_property): Detect buffer iteration by
4748 testing that it->string is a Lisp string.
4749 (get_next_display_element): When the current object is exhausted,
4750 and there's something on it->stack, call set_iterator_to_next to
4751 proceed with what's on the stack, instead of returning zero.
4752 (set_iterator_to_next): If called at the end of a Lisp string,
4753 proceed to consider_string_end without incrementing string
4754 position. Don't increment display vector index past the end of
4755 the display vector. (Bug#11417)
c8fb9dc6
EZ
4756 (pos_visible_p): Don't report a position visible when move_it_to
4757 stopped at the last line of window, which happens to be scanned
4758 backwards by the bidi iteration. (Bug#11464)
ac268e67 4759
e18afed7 47602012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4761
4762 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4763 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4764 are on a TTY, and thus unable to display on the fringes.
4765 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4766 so we need to signal to the caller that this is a "replacing"
4767 display spec. This fixes display when the spec is invalid or we
4768 are on a TTY.
4769
e18afed7 47702012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4771
4772 * unexaix.c (make_hdr): Fix typo in prototype.
4773 This bug broke the build on AIX. Problem reported by Gilles Pion.
4774
9d0a235a
MA
47752012-05-14 Michael Albinus <michael.albinus@gmx.de>
4776
4777 * keyboard.c (kbd_buffer_get_event): Read special events also in
4778 batch mode. (Bug#11415)
4779
9e6b06ed
GM
47802012-05-12 Glenn Morris <rgm@gnu.org>
4781
4782 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4783
c1a1d7a3
EZ
47842012-05-12 Eli Zaretskii <eliz@gnu.org>
4785
4786 * lisp.mk (lisp): Add newcomment.elc.
4787
3fe7cdc8
GM
47882012-05-12 Glenn Morris <rgm@gnu.org>
4789
4790 * Makefile.in (MKDIR_P): New, set by configure.
4791 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4792
53f7d2c0
PE
47932012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4794
4795 Remove unused function hourglass_started.
4796 * dispextern.h (hourglass_started):
4797 * w32fns.c (hourglass_started):
4798 * xdisp.c (hourglass_started): Remove.
4799
75aafb17
JB
48002012-05-10 Juanma Barranquero <lekktu@gmail.com>
4801
4802 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4803 Update dependencies.
4804
12959e8e
PE
48052012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4806
97107e2e
PE
4807 * xgselect.c (xg_select): Put maxfds+1 into a var.
4808 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4809
12959e8e
PE
4810 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4811
836d29b3
DA
48122012-05-10 Dave Abrahams <dave@boostpro.com>
4813
4814 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4815 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4816
5cb67954
MA
48172012-05-09 Michael Albinus <michael.albinus@gmx.de>
4818
4819 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4820 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4821 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4822 Initialize xd_registered_buses.
4823
3478ec45
PE
48242012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4825
b263a6b0
PE
4826 Untag more efficiently if USE_LSB_TAG.
4827 This is based on a proposal by YAMAMOTO Mitsuharu in
4828 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4829 For an admittedly artificial (nth 8000 longlist) benchmark on
4830 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4831 Emacs's overall text size by 1%.
4832 * lisp.h (XUNTAG): New macro.
4833 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4834 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4835 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4836 * eval.c (Fautoload):
4837 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4838 * frame.h (XFRAME): Use XUNTAG.
4839
3478ec45
PE
4840 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4841 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4842 Remove unportable assumptions about print widths of types like
4843 dbus_uint32_t.
4844 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4845 intptr_t when converting between pointer and integer, to avoid GCC
4846 warnings about wrong width.
4847
666b903b 48482012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4849
4850 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4851 stack for each reader_thread, instead of defaulting to 8MB
4852 determined by the linker. This avoids failures in creating
4853 subprocesses on Windows 7, see the discussion in this thread:
4854 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4855
b120cc17
JC
48562012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4857
4858 Fix up display of the *Minibuf-0* buffer in the mini window.
4859 * keyboard.c (read_char): Don't clear the echo area if there's no
4860 message to clear.
4861 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4862 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4863
9a4b36f8
MA
48642012-05-07 Michael Albinus <michael.albinus@gmx.de>
4865
4866 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4867 batch mode.
4868
e5f9458f
CY
48692012-05-06 Chong Yidong <cyd@gnu.org>
4870
4871 * lisp.mk (lisp): Update.
4872
eceeb5fc 48732012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4874
4875 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4876
71873e2b
SM
48772012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4878
4879 * data.c (PUT_ERROR): New macro.
4880 (syms_of_data): Use it. Add new error type `user-error'.
4881 * undo.c (user_error): New function.
4882 (Fprimitive_undo): Use it.
4883 * print.c (print_error_message): Adjust print style for `user-error'.
4884 * keyboard.c (user_error): New function.
4885 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4886
ab0fa4e4
PE
48872012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4888
4889 Do not limit current-time-string to years 1000..9999.
4890 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4891 (Fcurrent_time_string): Support any year that is supported by the
4892 underlying localtime representation. Don't use asctime, as it
4893 has undefined behavior for years outside the range -999..9999.
4894
7ed806a7
PE
48952012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4896
4897 Fix race conditions involving setenv, gmtime, localtime, asctime.
4898 Without this fix, interrupts could mess up code that uses these
4899 nonreentrant functions, since setting TZ invalidates existing
4900 tm_zone or tzname values, and since most of these functions return
4901 pointers to static storage.
4902 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4903 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4904 Grow the critical sections to include not just invoking
4905 localtime/gmtime, but also accessing these functions' results
4906 including their tm_zone values if any, and any related TZ setting.
4907 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4908 so that the struct tm is saved in the critical section.
4909 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4910 motivated by the fact that memory allocation needs to be outside
4911 the critical section.
4912
0c16dfed
DA
49132012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4914
4915 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4916 with RESET_INTERVAL.
4917
4918 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4919 Remove duplicated buffer name initialization.
4920
3f83ace8
JM
49212012-05-02 Jim Meyering <jim@meyering.net>
4922
4923 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4924
c7b8541e
JM
4925 * xfns.c (x_window): Use xstrdup (Bug#11375).
4926
90207a15 49272012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4928
4929 * xdisp.c (pos_visible_p): If already at a newline from the
4930 display string before the 'while' loop, don't walk back the glyphs
4931 from it3.glyph_row. Solves assertion violation when the display
4932 string begins with a newline (egg.el). (Bug#11367)
4933
b593d6a9
AH
49342012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4935
4936 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4937 Move to simple.el.
4938
4737362e
GM
49392012-05-01 Glenn Morris <rgm@gnu.org>
4940
99cf43f9
GM
4941 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4942 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4943 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4944 All were removed before 23.1.
4945
9311dcff
GM
4946 * dispnew.c: Remove HAVE_LIBNCURSES test;
4947 it is always true on relevant platforms.
4948
4d5c6349
GM
4949 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4950 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4951
4737362e
GM
4952 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4953
74dd3a6b
AS
49542012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4955
4956 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4957 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4958 Remove.
4959
13c379ee
PE
49602012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4961
4962 Do not avoid creating empty evaporating overlays (Bug#9642).
4963 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4964 That is, do not delete an evaporating overlay if it becomes
4965 empty after its bounds are adjusted to fit within its buffer.
4966 This fix caused other problems, and I'm reverting it until we get
4967 to the bottom of them.
4968
a8e7d6d7 49692012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4970
4971 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4972
a8e7d6d7 49732012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4974
4975 * xdisp.c (pos_visible_p): If the window start position is beyond
4976 ZV, start the display from buffer beginning. Prevents assertion
4977 violation in init_iterator when the minibuffer window is scrolled
4978 via the scroll bar.
4979
4980 * window.c (window_scroll_pixel_based): Likewise.
4981
a8e7d6d7 49822012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4983
4984 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4985
a8e7d6d7 49862012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4987
4988 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4989 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4990
a8e7d6d7 49912012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4992
b593d6a9
AH
4993 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4994 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4995
1c6900d9
EZ
49962012-04-26 Eli Zaretskii <eliz@gnu.org>
4997
4c3fa1d9
EZ
4998 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4999 display element, check also the underlying string or buffer
5000 character. (Bug#11341)
5001
1c6900d9
EZ
5002 * w32menu.c: Include w32heap.h.
5003 (add_menu_item): If the call to AppendMenuW (via
5004 unicode_append_menu) fails, disable Unicode menus only if we are
5005 running on Windows 9X/Me.
5006
42bf8205
AS
50072012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5008
5009 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5010 (xgetint): Add missing shift for LSB tags.
5011
b1bac16e
MR
50122012-04-24 Martin Rudalics <rudalics@gmx.at>
5013
5014 * keyboard.c (read_char): Don't wipe echo area for select window
5015 events: These might get delayed via `mouse-autoselect-window'
5016 (Bug#11304).
5017
d69621cc
JB
50182012-04-24 Juanma Barranquero <lekktu@gmail.com>
5019
5020 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5021 manipulation of :loaded-from data.
5022
02fd101b
JB
50232012-04-23 Juanma Barranquero <lekktu@gmail.com>
5024
5025 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5026 now a cons (bug#11311).
5027
888bec30
PE
50282012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5029
89a438bd
PE
5030 Do not create empty overlays with the evaporate property (Bug#9642).
5031 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5032 if it becomes empty after its bounds are adjusted to fit within
5033 its buffer. Without this fix, in a nonempty buffer (let ((o
5034 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5035 yields an empty overlay that has the evaporate property, which is
5036 not supposed to happen.
5037
1068fe4d
PE
5038 Fix minor GTK3 problems found by static checking.
5039 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5040 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5041 (struct _EmacsFixedClass, emacs_fixed_get_type):
5042 Move decls here from emacsgtkfixed.h, since they needn't be public.
5043 (emacs_fixed_get_type): Now static.
5044 (emacs_fixed_class_init): Omit unused local.
5045 (emacs_fixed_child_type): Remove; unused.
5046 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5047 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5048 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5049 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5050 (EMACS_FIXED_GET_CLASS): Remove; unused.
5051 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5052
888bec30
PE
5053 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5054 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5055
de85e130
PE
50562012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5057
d0baac98 5058 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5059 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5060 (__malloc_size_t, __malloc_ptrdiff_t):
5061 Remove. All uses removed, replaced by the definiens if needed,
5062 since we can assume C89 or better now.
5063 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5064 (protect_malloc_state, align, get_contiguous_space)
5065 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5066 (malloc_atfork_handler_child, malloc_enable_thread)
5067 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5068 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5069 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5070 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5071 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5072 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5073 Define using prototypes, not old style.
5074 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5075 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5076 (align): Don't assume that signed integer overflow wraps around.
5077 Omit unused local var.
5078 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5079 (_free_internal_nolock, memalign, mallochook, reallochook):
5080 Omit no-longer-needed casts.
5081 (valloc): Use getpagesize, not __getpagesize.
5082 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5083 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5084
de85e130
PE
5085 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5086
dcbf5805
MA
50872012-04-22 Michael Albinus <michael.albinus@gmx.de>
5088
5089 Move functions from C to Lisp. Make non-blocking method calls
5090 the default. Implement further D-Bus standard interfaces.
5091
5092 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5093 (QCdbus_request_name_allow_replacement)
5094 (QCdbus_request_name_replace_existing)
5095 (QCdbus_request_name_do_not_queue)
5096 (QCdbus_request_name_reply_primary_owner)
5097 (QCdbus_request_name_reply_in_queue)
5098 (QCdbus_request_name_reply_exists)
5099 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5100 (QCdbus_registered_serial, QCdbus_registered_method)
5101 (QCdbus_registered_signal): New Lisp objects.
5102 (XD_DEBUG_MESSAGE): Use sizeof.
5103 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5104 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5105 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5106 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5107 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5108 (xd_signature, xd_append_arg): Allow float for integer types.
5109 (xd_get_connection_references): New function.
b593d6a9
AH
5110 (xd_get_connection_address): Rename from xd_initialize.
5111 Return cached address.
dcbf5805
MA
5112 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5113 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5114 level.
5115 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5116 Return number of refcounts.
dcbf5805
MA
5117 (Fdbus_get_unique_name): Make stronger parameter check.
5118 (Fdbus_message_internal): New defun.
5119 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5120 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5121 (Fdbus_send_signal, Fdbus_register_service)
5122 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5123 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5124 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5125 (Vdbus_compiled_version, Vdbus_runtime_version)
5126 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5127 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5128 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5129 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5130 Adapt docstring.
dcbf5805 5131
52828e02
PE
51322012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5133
da05bc4c
PE
5134 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5135 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5136 Do not assume ptrdiff_t is the same width as 'int'.
5137
52828e02
PE
5138 * alloc.c: Handle unusual debugging option combinations.
5139 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5140 since the two debugging options are incompatible.
5141 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5142 is defined.
5143 (mem_init, mem_insert, mem_insert_fixup):
5144 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5145 (NEED_MEM_INSERT): Remove; no longer needed.
5146
f01769f9
LL
51472012-04-22 Leo Liu <sdl.web@gmail.com>
5148
5149 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5150
5790543d
PE
51512012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5152
5153 * sysdep.c [__FreeBSD__]: Minor cleanups.
5154 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5155 Use Emacs indenting style more consistently. Avoid some casts.
5156 Use 'double' consistently rather than mixing 'float' and 'double'.
5157
b91b7e4d
EW
51582012-04-21 Eduard Wiebe <usenet@pusto.de>
5159
b593d6a9
AH
5160 * sysdep.c (list_system_processes, system_process_attributes):
5161 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5162
6114eb15
AS
51632012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5164
5165 * lisp.mk (lisp): Update.
5166
2f38dff7
PE
51672012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5168
5169 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5170 It is never used otherwise.
5171
4ae29f89
SM
51722012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5173
5174 * print.c (print_preprocess): Only check print_depth if print-circle
5175 is nil.
5176 (print_object): Check for cycles even when print-circle is nil and
5177 print-gensym is t, but only check print_depth if print-circle is nil.
5178
f30d612a
CY
51792012-04-20 Chong Yidong <cyd@gnu.org>
5180
5181 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5182 set the status to "failed" and ensure that sentinel is run.
5183
c07a4c0b 51842012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5185
5186 * process.c (Fset_process_inherit_coding_system_flag)
5187 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5188 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5189
c07a4c0b 51902012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5191
5192 * xdisp.c (string_buffer_position_lim): Limit starting position to
5193 BEGV.
5194 (set_cursor_from_row): If called for a mode-line or header-line
5195 row, return zero immediately.
5196 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5197 farther than the first row after the header line, if any.
5198 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5199 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5200
c07a4c0b 52012012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5202
4ae29f89
SM
5203 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5204 (bug#11238).
ad3a2b41 5205
c07a4c0b 52062012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 52072012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5208
5209 configure: new option --enable-gcc-warnings (Bug#11207)
5210 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5211 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5212 (ALL_CFLAGS): Use new macros rather than old.
5213 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5214 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5215 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5216 -Wunused-result, -Wunused-variable. This should go away once
5217 the Emacs and Gnulib regex code is merged.
5218 (xmalloc, xrealloc): Now static.
5219
aba027e8
PE
52202012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5221
5222 * dired.c (Fsystem_groups): Remove unused local.
5223
e5a36063
GM
52242012-04-17 Glenn Morris <rgm@gnu.org>
5225
5226 * dired.c (Fsystem_users): Doc fix.
5227
316411f0
DA
52282012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5229
5230 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5231 (syms_of_dired): Add them.
5232
9426aba4
PE
52332012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5234
b62a57be
PE
5235 Fix minor alloc.c problems found by static checking.
5236 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5237 New extern decls, to avoid calling undeclared functions.
5238 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5239 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5240 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5241 (NEED_MEM_INSERT): New macro.
5242 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5243 Remove one incorrect comment and fix another.
b62a57be 5244
3539f31f
PE
5245 Fix minor ralloc.c problems found by static checking.
5246 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5247 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5248 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5249 (r_alloc_sbrk): Now static.
5250
a041960a
PE
5251 Improve ralloc.c interface checking.
5252 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5253 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5254 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5255 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5256 [REL_ALLOC]: ... to here, to check interface.
5257 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5258 Remove decls. This fixes an "It stinks!".
5259
9426aba4
PE
5260 * alloc.c (which_symbols): Fix alignment issue / type clash.
5261
d55c12ed
AS
52622012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5263
5264 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5265 (struct Lisp_Misc_Any): Likewise.
5266 (struct Lisp_Free): Likewise.
5267 * alloc.c (union aligned_Lisp_Symbol): Define.
5268 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5269 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5270 (union aligned_Lisp_Misc): Define.
5271 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5272 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5273 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5274
b948ce8b
PE
52752012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5276
5277 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5278 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5279 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5280 * s/netbsd.h, s/sol2-6.h:
5281 Remove definition of GC_MARK_STACK, since the default now works.
5282 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5283 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5284 no longer the default.
5285 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5286
35dc09a1 52872012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5288
35dc09a1
GM
5289 * lread.c (lisp_file_lexically_bound_p):
5290 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5291
35dc09a1
GM
52922012-04-14 Eli Zaretskii <eliz@gnu.org>
5293
5294 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5295 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5296
52972012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5298
5299 * nsterm.m (constrainFrameRect): Always constrain when there is only
5300 one screen (Bug#10962).
5301
bcd86815
KB
53022012-04-13 Ken Brown <kbrown@cornell.edu>
5303
5304 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5305
c25df26e
RT
53062012-04-13 Reuben Thomas <rrt@sc3d.org>
5307
5308 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5309
0fc59f1e
DC
53102012-04-11 Daniel Colascione <dancol@dancol.org>
5311
5312 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5313 against is gone. It's better to use vfork now so that when Cygwin
5314 gains a new, working vfork, we use it automatically (bug#10398).
5315
de8c03dc
SM
53162012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5317
5318 * window.c (save_window_save): Obey window-point-insertion-type.
5319
2f097256
GM
53202012-04-11 Glenn Morris <rgm@gnu.org>
5321
5322 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5323
453b951e
SM
53242012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5325
5326 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5327
75f1671a 53282012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5329
5330 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5331 (force_quit_count): New var.
5332 (handle_interrupt): Use it.
5333
2a8ce227
JB
53342012-04-10 Juanma Barranquero <lekktu@gmail.com>
5335
5336 * w32.c (w32_delayed_load): Record the full path of the library
5337 being loaded (bug#10424).
5338
935396c0
GM
53392012-04-09 Glenn Morris <rgm@gnu.org>
5340
05920a43
GM
5341 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5342 not just in the obarray, before snarfing them. (Bug#11036)
5343
935396c0
GM
5344 * Makefile.in ($(leimdir)/leim-list.el):
5345 Pass EMACS rather than BUILT_EMACS.
5346
a18ecafa
TZ
53472012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5348
5349 * process.c (make_process):
5350 * process.h: Add integer `gnutls_handshakes_tried' member to
5351 process struct.
5352
6bbef4e5
JC
5353 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5354 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5355
5356 * gnutls.c (gnutls_log_function2i): Convenience log function.
5357 (emacs_gnutls_read): Use new log functions,
5358 `gnutls_handshakes_tried' process member, and
5359 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5360 attempts per process (connection).
5361
b4d3bc10
CY
53622012-04-09 Chong Yidong <cyd@gnu.org>
5363
5364 * eval.c (Fuser_variable_p, user_variable_p_eh)
5365 (lisp_indirect_variable): Functions deleted.
5366 (Fdefvar): Caller changed.
5367
5368 * callint.c (Finteractive, Fcall_interactively):
5369 * minibuf.c (Fread_variable): Callers changed.
5370
70f4d973
EZ
53712012-04-09 Eli Zaretskii <eliz@gnu.org>
5372
5373 * xdisp.c (set_cursor_from_row): If the display string appears in
5374 the buffer at position that is closer to point than the position
5375 after the display string, display the cursor on the first glyph of
5376 the display string. Fixes cursor display when a 'display' text
5377 property immediately follows invisible text. (Bug#11094)
5378
cb3c2e3e
PE
53792012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5380
5381 composite.c: use 'double' consistently
5382 * composite.c (get_composition_id): Use 'double' consistently
5383 instead of converting 'float' to 'double' and vice versa; this is
5384 easier to understand and avoids a GCC warning.
5385
fd06db5d
GM
53862012-04-09 Glenn Morris <rgm@gnu.org>
5387
50fe702a
GM
5388 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5389 preparation for dumping it with emacs. (Bug#4789)
5390 (leimdir): New variable.
5391 ($(leimdir)/leim-list.el): New rule.
5392 (emacs$(EXEEXT)): Depend on leim-list.el.
5393
fd06db5d
GM
5394 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5395 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5396 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5397
55c131ee
AS
53982012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5399
5400 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5401 proper alignment.
5402
9209588f
JB
54032012-04-07 Juanma Barranquero <lekktu@gmail.com>
5404
5405 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5406 Remove unused local variable.
5407
e3fb2efb
PE
54082012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5409
5410 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5411 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5412 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5413 objects, as mark_maybe_pointer will catch them otherwise.
5414 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5415 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5416
b5385551
PE
54172012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5418
5419 Fix typo that broke non-Windows builds.
5420 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5421
9078ead6
EZ
54222012-04-07 Eli Zaretskii <eliz@gnu.org>
5423
5424 Support building on MS-Windows with libxml2.
5425
5426 * makefile.w32-in (OBJ2): Add xml.$(O).
5427 (GLOBAL_SOURCES): Add xml.c.
5428 ($(BLD)/xml.$(O)): New dependency list.
5429
5430 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5431 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5432 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5433 [!WINDOWSNT]: New macros.
5434 (init_libxml2_functions, libxml2_loaded_p): New functions.
5435 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5436 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5437 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5438 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5439 linked in).
6bbef4e5
JC
5440 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5441 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5442 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5443
5444 * emacs.c: Don't include libxml/parser.h.
5445 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5446 xmlCleanupParser directly.
5447
5448 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5449
3811fdf3
EZ
54502012-04-07 Eli Zaretskii <eliz@gnu.org>
5451
5452 * indent.c (Fvertical_motion): If there is a display string at
5453 point, use it.vpos to compute how many lines to backtrack after
5454 move_it_to point. (Bug#11133)
5455
2f8e16b2
EZ
54562012-04-06 Eli Zaretskii <eliz@gnu.org>
5457
5458 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5459 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5460 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5461 macros related to unification of CJK characters. For the details,
5462 see the discussion following the message here:
5463 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5464
3d439cd1
CY
54652012-04-04 Chong Yidong <cyd@gnu.org>
5466
5467 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5468
8bc53d00
EZ
54692012-04-01 Eli Zaretskii <eliz@gnu.org>
5470
5471 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5472 instead of alloca. (Bug#11138)
5473
3b0512a3
AS
54742012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5475
5476 * w32menu.c (is_simple_dialog): Properly check lisp types.
5477 (Bug#11141)
5478
8427ddd2
EZ
54792012-03-31 Eli Zaretskii <eliz@gnu.org>
5480
979022ef
EZ
5481 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5482 position we get to after a call to move_it_to fails the
5483 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5484 only if we wind up in a string from display property. (Bug#11063)
5485
a6b1c7cc
EZ
5486 * window.c (Fdelete_other_windows_internal): Invalidate the row
5487 and column information about mouse highlight, so that redisplay
5488 restores it after reallocating the glyph matrices. (Bug#7464)
5489
8427ddd2
EZ
5490 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5491 string comes from a `display' text property, use the buffer
5492 position of that property as if we actually saw that position in
5493 the row's glyphs.
697ba24b
EZ
5494 (move_it_by_lines): Remove the assertion that
5495 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5496 violated when there's a before-string at the beginning of a line.
5497 (Bug#11063)
8427ddd2 5498
65a0a738
EZ
54992012-03-30 Eli Zaretskii <eliz@gnu.org>
5500
5501 * xdisp.c (append_space_for_newline): If the default face was
5502 remapped, use the remapped face for the appended newline.
5503 (extend_face_to_end_of_line): Use the remapped default face for
5504 extending the face to the end of the line.
5505 (display_line): Call extend_face_to_end_of_line when the default
5506 face was remapped. (Bug#11068)
5507
581355cc
EZ
55082012-03-29 Eli Zaretskii <eliz@gnu.org>
5509
5510 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5511
e8fc049f
SM
55122012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5513
5514 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5515
4fb9a543
GM
55162012-03-27 Glenn Morris <rgm@gnu.org>
5517
5518 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5519 Doc fixes.
5520
679910f1
KH
55212012-03-26 Kenichi Handa <handa@m17n.org>
5522
5523 * dispextern.h (struct glyph): Fix previous change. Change the
5524 bit length of glyphless.ch to 25 (Bug#11082).
5525
90d49b7f
CY
55262012-03-26 Chong Yidong <cyd@gnu.org>
5527
5528 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5529 (command_loop_1): Use it; inhibit selection update for
5530 handle-select-window too (Bug#8996).
5531
f514f6f0
FP
55322012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5533
e8fc049f 5534 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5535
bf43fa51
KH
55362012-03-25 Kenichi Handa <handa@m17n.org>
5537
5538 * dispextern.h (struct glyph): Change the bit length of
5539 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5540
8a0c01dd
EZ
55412012-03-24 Eli Zaretskii <eliz@gnu.org>
5542
5543 * s/ms-w32.h (tzname): Include time.h before redirecting to
5544 _tzname. Fixes the MSVC build. (Bug#9960)
5545
7d1c3a76
AS
55462012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5547
8ed79523
AS
5548 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5549 characters.
5550
7d1c3a76
AS
5551 * xterm.c (XTread_socket): Only modify handling_signal if
5552 !SYNC_INPUT. (Bug#11080)
5553
e99a9b8b
EZ
55542012-03-23 Eli Zaretskii <eliz@gnu.org>
5555
5556 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5557 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5558 when fetching a multibyte character consumes more bytes than
5559 CHAR_BYTES returns, due to unification of CJK characters in
5560 string_char. (Bug#11073)
5561
5063c0e1
TN
55622012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5563
5564 * process.c (wait_reading_process_output): Handle pty disconnect
5565 by refraining from sending oneself a SIGCHLD (bug#10933).
5566
9f851fbd
CY
55672012-03-22 Chong Yidong <cyd@gnu.org>
5568
5569 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5570
5063c0e1 5571 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5572 Mark string as coming from a prefix property.
5573 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5574 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5575
fb5b8aca
CY
55762012-03-21 Chong Yidong <cyd@gnu.org>
5577
5578 * xfaces.c (Vface_remapping_alist): Doc fix.
5579
62356a1b
EZ
55802012-03-20 Eli Zaretskii <eliz@gnu.org>
5581
5582 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5583 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5584 Doc fixes.
62356a1b 5585
025de85b
CY
55862012-03-20 Chong Yidong <cyd@gnu.org>
5587
5588 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5589 to reflect default non-nil value of redisplay-dont-pause.
5590
4827f94e
KH
55912012-03-19 Kenichi Handa <handa@m17n.org>
5592
5593 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5594 it fit in a valid range (Bug#11003).
5595
e50a24a2
EZ
55962012-03-18 Eli Zaretskii <eliz@gnu.org>
5597
5598 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5599 that is not from display property, accept the row as a "cursor
5600 row" if one of the string's character has a non-nil `cursor'
5601 property. Fixes cursor positioning when there are newlines in
5602 overlay strings, e.g. in icomplete.el. (Bug#11035)
5603
9af5ed87
PE
56042012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5605
5606 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5607
d1f55f16
CY
56082012-03-12 Chong Yidong <cyd@gnu.org>
5609
5610 * eval.c (inhibit_lisp_code): Rename from
5611 inhibit_window_configuration_change_hook; move from window.c.
5612
5613 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5614 * window.c (run_window_configuration_change_hook)
5615 (syms_of_window): Callers changed.
5616
66c5eebd
CY
56172012-03-11 Chong Yidong <cyd@gnu.org>
5618
413df973
CY
5619 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5620
66c5eebd
CY
5621 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5622
1de11f56
CY
56232012-03-10 Chong Yidong <cyd@gnu.org>
5624
5625 * frame.c (other_visible_frames): Don't assume the selected frame
5626 is visible (Bug#10955).
5627
cae07000
SM
56282012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5629
5630 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5631
89c94350
JD
56322012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5633
5634 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5635 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5636 zero (Bug#10954).
5637
999dd333
GM
56382012-03-03 Glenn Morris <rgm@gnu.org>
5639
01a6dcc8 5640 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5641
de0100f2
EZ
56422012-03-02 Eli Zaretskii <eliz@gnu.org>
5643
5644 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5645 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5646 (redisplay_window, next_element_from_string): Fix typos in
5647 comments.
3e441275
EZ
5648 (redisplay_window): Pass to move_it_vertically the margin in
5649 pixels, not in screen lines.
de0100f2 5650
96a72ee9
GM
56512012-03-02 Glenn Morris <rgm@gnu.org>
5652
5653 * buffer.c (buffer-list-update-hook): Doc fix.
5654
312508d7
EZ
56552012-02-29 Eli Zaretskii <eliz@gnu.org>
5656
5657 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5658 push_it before setting up the iterator for the first overlay
5659 string, even if we have an empty string loaded.
5660 (next_overlay_string): If there's an empty string on the iterator
5661 stack, pop the stack. (Bug#10903)
5662
27f3c637
PE
56632012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5664
5665 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5666 Suggested by Stefan Monnier in
5667 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5668 * alloc.c (widen_to_Lisp_Object): New static function.
5669 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5670 and widening them to Lisp_Objects. This would work even if
5671 USE_LSB_TAG is defined and wide integers are used, which might
5672 happen in a future version of Emacs.
5673
3c9dfce6
CY
56742012-02-25 Chong Yidong <cyd@gnu.org>
5675
fa74b241
CY
5676 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5677 Doc fix.
5678
3c9dfce6
CY
5679 * xselect.c (Fx_selection_exists_p): Doc fix.
5680 (x_clipboard_manager_save_all): Print an informative message
5681 before saving to clipboard manager.
5682
9486df08
CY
56832012-02-24 Chong Yidong <cyd@gnu.org>
5684
5685 * keyboard.c (process_special_events): Handle all X selection
5686 requests in kbd_buffer, not just the next one (Bug#8869).
5687
f01d3321
CY
56882012-02-23 Chong Yidong <cyd@gnu.org>
5689
5690 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5691 call when setting menu-bar-lines and tool-bar-lines parameters.
5692 (unwind_create_frame_1): New helper function.
5693
5694 * window.c (inhibit_window_configuration_change_hook): New var.
5695 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5696 (syms_of_window): Initialize it.
f01d3321 5697
86b847b6
CY
56982012-02-22 Chong Yidong <cyd@gnu.org>
5699
5700 * xterm.c (x_draw_image_relief): Add missing type check for
5701 Vtool_bar_button_margin (Bug#10743).
5702
a59225b1
CY
57032012-02-21 Chong Yidong <cyd@gnu.org>
5704
5705 * fileio.c (Vfile_name_handler_alist): Doc fix.
5706
5707 * buffer.c (Fget_file_buffer): Protect against invalid file
5708 handler return value.
5709
310f5bd4
PE
57102012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5711
cb3a28cc
PE
5712 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5713 when computing $valmask.
5714
310f5bd4
PE
5715 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5716 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5717 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5718 It's useless in that case, and it can cause problems on hosts
5719 that allocate halves of EMACS_INT values separately.
5720 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5721 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5722 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5723 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5724 it avoids undefined behavior on hosts where shifting right by more
5725 than the word width has undefined behavior.
5726
2375c96a
CY
57272012-02-19 Chong Yidong <cyd@gnu.org>
5728
5729 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5730 (Funhandled_file_name_directory, Ffile_name_as_directory)
5731 (Fdirectory_file_name, Fexpand_file_name)
5732 (Fsubstitute_in_file_name): Protect against invalid file handler
5733 return values (Bug#10845).
5734
3eb49e71
EZ
57352012-02-18 Eli Zaretskii <eliz@gnu.org>
5736
5737 * .gdbinit (pitx): Fix incorrect references to fields of the
5738 iterator stack.
5739
7b926f3f
CY
57402012-02-17 Chong Yidong <cyd@gnu.org>
5741
5742 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5743
11273115
PE
57442012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5745
5746 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5747 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5748
c3a70e2b
CY
57492012-02-15 Chong Yidong <cyd@gnu.org>
5750
5751 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5752 marked as special. Also, starting docstrings with * is obsolete.
5753
0ca43699
AS
57542012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5755
5756 * gnutls.c (emacs_gnutls_write): Fix last change.
5757
2e8f3c56
LI
57582012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5759
5760 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5761 send_process.
5762
af70074f
SM
57632012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5764
5765 * keymap.c (Fsingle_key_description): Handle char ranges.
5766
95986d52
CY
57672012-02-12 Chong Yidong <cyd@gnu.org>
5768
afd83bd1
CY
5769 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5770 as that creates a dangerous corner case.
5771
95986d52
CY
5772 * window.c (Fdelete_window_internal): Invalidate the mouse
5773 highlight (Bug#9904).
5774
bd7da63e
GM
57752012-02-12 Glenn Morris <rgm@gnu.org>
5776
5777 * xselect.c (Fx_own_selection_internal)
5778 (Fx_get_selection_internal, Fx_disown_selection_internal)
5779 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5780 * nsselect.m (Fx_own_selection_internal)
5781 (Fx_disown_selection_internal, Fx_selection_exists_p)
5782 (Fx_selection_owner_p, Fx_get_selection_internal):
5783 Sync docs and argument specs with the xselect.c versions.
5784
77abcbc2
LI
57852012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5786
5787 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5788
90b671e2
EZ
57892012-02-11 Eli Zaretskii <eliz@gnu.org>
5790
1c0ca0b7
EZ
5791 * w32select.c (Fx_selection_exists_p): Sync doc string and
5792 argument list with xselect.c. (Bug#10783)
5793
5794 * w16select.c (Fx_selection_exists_p): Sync doc string and
5795 argument list with xselect.c. (Bug#10783)
90b671e2 5796
49241268
GM
57972012-02-10 Glenn Morris <rgm@gnu.org>
5798
5799 * fns.c (Fsecure_hash): Doc fix.
5800
f998bbe7 58012012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5802
5803 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5804
0992bd9c
CY
58052012-02-07 Chong Yidong <cyd@gnu.org>
5806
5807 * buffer.c (Fbuffer_local_variables)
5808 (buffer_lisp_local_variables): Handle unbound vars correctly;
5809 don't let Qunbound leak into Lisp.
5810
af008560
GM
58112012-02-07 Glenn Morris <rgm@gnu.org>
5812
dd605cc4
GM
5813 * image.c (Fimagemagick_types): Doc fix.
5814
af008560
GM
5815 * image.c (imagemagick-render-type): Change it from a lisp object
5816 to an integer. Move the doc here from the lisp manual.
5817 Treat all values not equal to 0 the same.
5818
1449fa1d
CY
58192012-02-06 Chong Yidong <cyd@gnu.org>
5820
5821 * doc.c (store_function_docstring): Avoid applying docstring of
5822 alias to base function (Bug#2603).
5823
3723ec07
AS
58242012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5825
5826 * .gdbinit (pp1, pv1): Remove redundant defines.
5827 (pr): Use pp.
5828
79c1cc1e
CY
58292012-02-04 Chong Yidong <cyd@gnu.org>
5830
5831 * nsterm.m: Declare a global (Bug#10694).
5832
d7f29f8e
EZ
58332012-02-04 Eli Zaretskii <eliz@gnu.org>
5834
cae07000
SM
5835 * w32.c (get_emacs_configuration_options):
5836 Include --enable-checking, if specified, in the return value.
d7f29f8e 5837
3b95a6f9
MR
58382012-02-04 Martin Rudalics <rudalics@gmx.at>
5839
5840 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5841 after rounding frame sizes. (Bug#9723)
5842
d6fa96a6
EZ
58432012-02-04 Eli Zaretskii <eliz@gnu.org>
5844
5845 * keyboard.c (adjust_point_for_property): Don't position point
5846 before BEGV. (Bug#10696)
5847
df0b2940
PE
58482012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5849
5850 Handle overflow when computing char display width (Bug#9496).
5851 * character.c (char_width): Return EMACS_INT, not int.
5852 (char_width, c_string_width): Check for overflow when
5853 computing the width; this is possible now that individual
5854 characters can have unbounded width. Problem introduced
5855 by merge from Emacs 23 on 2012-01-19.
5856
6bee44d6
MA
58572012-02-02 Michael Albinus <michael.albinus@gmx.de>
5858
5859 * dbusbind.c (Fdbus_register_method): Mention the return value
5860 :ignore in the docstring.
5861
44f92739
GM
58622012-02-02 Glenn Morris <rgm@gnu.org>
5863
1b9f60cc
GM
5864 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5865
44f92739
GM
5866 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5867 Unconditionally set to t. (Bug#10673)
5868 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5869 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5870 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5871
c5d3843c
KH
58722012-02-02 Kenichi Handa <handa@m17n.org>
5873
5874 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5875 0, do not call append_composite_glyph.
5876
159462d4 58772012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5878
5879 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5880 NULL (Bug#6988).
5881 (x_produce_glyphs): If the component of a composition is a null
5882 string, set it->pixel_width to 1 to avoid zero-width glyph.
5883
78cef877
EZ
58842012-02-01 Eli Zaretskii <eliz@gnu.org>
5885
5886 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5887 first 2 arguments are identical. This makes inserting large
5888 output from a subprocess an order of magnitude faster on
5889 MS-Windows, where all sbrk'ed memory is always contiguous.
5890
97897668
GM
58912012-01-31 Glenn Morris <rgm@gnu.org>
5892
5893 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5894 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5895 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5896
31fd3586
GM
58972012-01-29 Glenn Morris <rgm@gnu.org>
5898
5899 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5900
0e24a8b2
CY
59012012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5902
5903 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5904
cc0adcb0
CY
59052012-01-28 Chong Yidong <cyd@gnu.org>
5906
5907 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5908
acc28cb9
CY
59092012-01-26 Chong Yidong <cyd@gnu.org>
5910
9c69cfb7
CY
5911 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5912
acc28cb9
CY
5913 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5914 repeat counts (Bug#10507).
5915
48da7392
GM
59162012-01-26 Glenn Morris <rgm@gnu.org>
5917
5918 * lread.c (syms_of_lread): Doc fix.
5919
14af5f7f
CY
59202012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5921
5922 * coding.c (encode_designation_at_bol): Change return value to
5923 EMACS_INT.
5924
0b21c100
CY
59252012-01-25 Chong Yidong <cyd@gnu.org>
5926
5927 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5928
3c2907f7
CY
59292012-01-21 Chong Yidong <cyd@gnu.org>
5930
5931 * floatfns.c (Fcopysign): Make the second argument non-optional,
5932 since nil is not allowed anyway.
5933
959ad23f
AS
59342012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5935
5936 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5937 (send_process): Likewise.
5938
34a02f46
MR
59392012-01-19 Martin Rudalics <rudalics@gmx.at>
5940
5941 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5942 (Vwindow_persistent_parameters): Do not use Qstate.
5943 Rewrite doc-strings.
34a02f46 5944
1259009a 59452012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5946
5947 * character.c (char_width): New function.
70d4fdf6
GM
5948 (Fchar_width, c_string_width, lisp_string_width):
5949 Use char_width (Bug#9496).
25ed9e61 5950
6a6ee00d
MR
59512012-01-16 Martin Rudalics <rudalics@gmx.at>
5952
5953 * window.c (Vwindow_persistent_parameters): New variable.
5954 (Fset_window_configuration, save_window_save): Handle persistent
5955 window parameters.
5956
c85efaf7
EZ
59572012-01-14 Eli Zaretskii <eliz@gnu.org>
5958
5959 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5960 thrashing the stack of the thread. (Bug#9087)
5961
5944709e
PE
59622012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5963
5964 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5965
e71f5d99
EZ
59662012-01-11 Eli Zaretskii <eliz@gnu.org>
5967
5968 * xdisp.c (rows_from_pos_range): Handle the case where the
5969 highlight ends on a newline. (Bug#10464)
5970 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5971 he end column for display of highlight that ends on a newline
5972 before a R2L line.
5973
ce316182
GM
59742012-01-11 Glenn Morris <rgm@gnu.org>
5975
5976 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5977 from load-path also when installation-directory is nil. (Bug#10208)
5978
5b43da69
GM
59792012-01-10 Glenn Morris <rgm@gnu.org>
5980
74cc8ff9
GM
5981 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5982
7d8d6e4e
GM
5983 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5984 Update template values to be closer to their typical values these days.
5b43da69 5985
a0db8d43
EZ
59862012-01-09 Eli Zaretskii <eliz@gnu.org>
5987
5988 * xdisp.c (rows_from_pos_range): Accept additional argument
5989 DISP_STRING, and accept any glyph in a row whose object is that
5990 string as eligible for mouse highlight. Fixes mouse highlight of
5991 display strings from overlays. (Bug#10464)
5992
9a0115ab 59932012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5994
b9110d6a 5995 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5996 * fileio.c (auto_saving_dir_umask): New static var.
5997 (Fmake_directory_internal): Use it.
5998 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5999 creating the directory. The old code temporarily assigns
6000 too-generous permissions to the directory.
6001 (do_auto_save_eh): Clear it.
b9110d6a 6002 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6003 that the var is always cleared.
6004
6c1bd3f3
EZ
60052012-01-07 Eli Zaretskii <eliz@gnu.org>
6006
6007 * search.c (scan_buffer): Pass character positions to
6008 know_region_cache, not byte positions. (Bug#6540)
6009
069d2b50
L
60102012-01-07 LynX <_LynX@bk.ru> (tiny change)
6011
6012 * w32.c (sys_rename): Report EXDEV when rename of a directory
6013 fails because the target is on another logical disk. (Bug#10284)
6014
75bf0d33
DB
60152012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6016
6017 * xterm.c (x_embed_request_focus): New function.
6018
6019 * xterm.h: Add prototype.
6020
6021 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6022
1c6e5a32
GM
60232012-01-05 Glenn Morris <rgm@gnu.org>
6024
6025 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6026
651e947e
EZ
60272012-01-01 Eli Zaretskii <eliz@gnu.org>
6028
6029 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6030 Load gnutls_transport_set_lowat only if GnuTLS version is below
6031 2.11.1.
6032 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6033 GnuTLS versions below 2.11.1.
6034
3778cdd8
AL
60352011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6036
6037 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6038 to the doc string advising against its use for altering the way
6039 windows are scrolled.
6040
0e5317f7
KH
60412011-12-28 Kenichi Handa <handa@m17n.org>
6042
6043 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6044 coding-system ASCII compatible only when it does not produce BOM
6045 on encoding (Bug#10383).
6046
93d5ca1f
JD
60472011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6048
6049 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6050 can scroll.
6051 (create_and_show_popup_menu): Always use menu_position_func for
6052 Gtk3 (Bug#10361).
6053
ca22b785
AS
60542011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6055
6056 * callint.c (Fcall_interactively): Don't truncate prompt string.
6057
d048e1e6
EZ
60582011-12-23 Eli Zaretskii <eliz@gnu.org>
6059
6060 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6061 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6062 resumed from there (after widening). (Bug#10360)
d048e1e6 6063
5ccaba1f
JD
60642011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6065
6066 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6067
204ee57f
JD
60682011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6069
b81d40f0
JB
6070 * nsterm.m (x_free_frame_resources):
6071 Release f->output_data.ns->miniimage.
204ee57f
JD
6072 (ns_index_color): Fix indentation. Do not retain
6073 color_table->colors[i].
6074
6075 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6076 before returning.
6077
6078 * nsfns.m (x_set_background_color): Assign return value from
6079 ns_index_color to face-background instead of NSColor*.
6080 (ns_implicitly_set_icon_type): Fix indentation.
6081 Change assignment in for loop to comparison.
6082
6083 * emacs.c (ns_pool): New variable.
6084 (main): Assign ns_pool.
6085 (Fkill_emacs): Call ns_release_autorelease_pool.
6086
6087 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6088 autorelease fdesc, release fdAttrs and tdict.
6089 (ns_get_covering_families): Release charset.
6090 (ns_findfonts): Release NSFontDescriptor created with new.
6091 (ns_uni_to_glyphs): Fix indentation.
6092 (setString): Release attrStr before assigning new value.
6093
c803b2b7
JD
60942011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6095
678f4426
JD
6096 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6097 and NS_IMPL_COCOA.
6098 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6099 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6100
cd394be1 61012011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6102
5fecd5fc
JD
6103 * nsterm.m (ns_term_init): Subscribe for notifications
6104 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6105 to method trackingNotification in EmacsMenu.
6106
6107 * nsmenu.m (trackingMenu): New variable.
3771cb17 6108 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6109 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6110 from Aquamacs (Bug#7030).
678f4426
JD
6111
61122011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6113
c803b2b7
JD
6114 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6115 (symbol_to_nsstring): Fix indentation.
6116 (ns_symbol_to_pb): New function.
cae07000
SM
6117 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6118 (Fns_rotate_cut_buffers_internal): Remove.
6119 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6120 Fns_store_cut_buffer_internal.
6121 (ns_get_foreign_selection, Fx_own_selection_internal)
6122 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6123 (Fns_get_selection_internal, Fns_store_selection_internal):
6124 Use ns_symbol_to_pb and check if return value is nil.
6125 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6126 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6127 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6128 renamed to Sns_store_selection_internal.
6129 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6130 and remove this function.
6131 (ns_handle_selection_clear): Remove, never used.
6132 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6133 here.
6134
e1b01a3a
KB
61352011-12-17 Ken Brown <kbrown@cornell.edu>
6136
6137 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6138 GID is unknown (Bug#10257).
6139
2adb6e85
PE
61402011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6141
6142 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6143 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6144 which caused a build failure on GNU/Linux IA-64. This problem was
6145 introduced by my 2011-10-07 patch.
6146
d1d7b339
JL
61472011-12-15 Juri Linkov <juri@jurta.org>
6148
6149 * image.c (imagemagick_error): New function. (Bug#10112)
6150 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6151 Use `imagemagick_error' where ImageMagick functions return
6152 `MagickFalse'.
6153 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6154 proper order.
6155
100d5755
KH
61562011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6157
6158 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6159 fill background (Bug#8992).
6160
454592a6
MR
61612011-12-13 Martin Rudalics <rudalics@gmx.at>
6162
6163 * window.c (Vwindow_combination_resize)
6164 (Vwindow_combination_limit): Use t instead of non-nil in
6165 doc-strings.
61d4b438
MR
6166 (Vrecenter_redisplay): Add first sentence of doc-string on
6167 separate line.
53524d93 6168 (Frecenter): Fix doc-string typo.
454592a6 6169
3633e3aa
KH
61702011-12-11 Kenichi Handa <handa@m17n.org>
6171
6172 * coding.c (Funencodable_char_position): Pay attention to the
6173 buffer text relocation (Bug#9389).
6174
7b9d523a 61752011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6176
7b9d523a
JD
6177 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6178 gtk_init (Bug#10100).
6179
b73189c6
EZ
61802011-12-10 Eli Zaretskii <eliz@gnu.org>
6181
6182 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6183 IT->string is nil. (Bug#10263)
6184
f7dfe5d6
JD
61852011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6186
83faebb4
JD
6187 * nsterm.h (x_free_frame_resources): Declare.
6188
f7dfe5d6
JD
6189 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6190 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6191
6192 * nsterm.h (ns_get_defaults_value): Declare.
6193
6194 * nsterm.m (ns_default): Call ns_get_defaults_value.
6195
7cd4e72c
EZ
61962011-12-09 Eli Zaretskii <eliz@gnu.org>
6197
6198 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6199 (Bug#10170)
6200
b34d7317
YM
62012011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6202
6203 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6204 that where the value of an _OBJC_* symbol points to is in the .bss
6205 section (Bug#10240).
6206
76470ad1
KH
62072011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6208
6209 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6210 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6211
745fff94
KH
62122011-12-08 Kenichi Handa <handa@m17n.org>
6213
6214 * ftfont.c (get_adstyle_property): Fix previous change
6215 (Bug#10233).
6216
6e44397c
JB
62172011-12-07 Juanma Barranquero <lekktu@gmail.com>
6218
6219 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6220 dirs from the default value of EMACSLOADPATH (bug#10208).
6221
7efa6272
GM
62222011-12-07 Glenn Morris <rgm@gnu.org>
6223
6224 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6225 installation and source directories as well. (Bug#10208)
6226
f6fc4d87
CY
62272011-12-06 Chong Yidong <cyd@gnu.org>
6228
6229 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6230
2bf26180
GM
62312011-12-06 Glenn Morris <rgm@gnu.org>
6232
6233 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6234 as an error, not just -1. (Bug#10217)
6235
3a6ad4f0
CY
62362011-12-05 Chong Yidong <cyd@gnu.org>
6237
6238 * keyboard.c (process_special_events): New function.
6239 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6240
75a3b399
PE
62412011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6242
6243 * coding.c (encode_designation_at_bol): Don't use uninitialized
6244 local variable (Bug#9318).
6245
c3c9e25e
KH
62462011-12-05 Kenichi Handa <handa@m17n.org>
6247
6248 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6249 return Qnil (Bug#8046, Bug#10193).
6250
5eb05ea3
KH
62512011-12-05 Kenichi Handa <handa@m17n.org>
6252
6253 * coding.c (encode_designation_at_bol): New args charbuf_end and
6254 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6255 (coding_set_source): Return how many bytes coding->source was
6256 relocated.
6257 (coding_set_destination): Return how many bytes
6258 coding->destination was relocated.
6259 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6260 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6261
62622011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6263
6264 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6265 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6266 macro (Bug#9318).
6267
62682011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6269
6270 The following changes are to fix Bug#9318.
6271
a79703f5 6272 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6273 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6274 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6275 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6276
7dbda6df
JB
62772011-12-05 Juanma Barranquero <lekktu@gmail.com>
6278
6279 * lisp.h (process_quit_flag): Fix external declaration.
6280
6d5eb5b0
SM
62812011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6282
6283 Don't macro-inline non-performance-critical code.
6284 * eval.c (process_quit_flag): New function.
6285 * lisp.h (QUIT): Use it.
6286
a0c3fad0
JD
62872011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6288
6289 * nsfns.m (get_geometry_from_preferences): New function.
6290 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6291
6c07aac2
AS
62922011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6293
6294 * emacs.c (Qkill_emacs): Define.
6295 (syms_of_emacs): Initialize it.
6296 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6297 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6298 (quit_throw_to_read_char): Add parameter `from_signal'.
6299 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6300 * lisp.h (QUIT): Call Fkill_emacs if requested.
6301
c052ead4
JD
63022011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6303
6304 * widget.c (update_wm_hints): Return if wmshell is null.
6305 (widget_update_wm_size_hints): New function.
6306
6307 * widget.h (widget_update_wm_size_hints): Declare.
6308
6309 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6310 widget_update_wm_size_hints (Bug#10104).
6311
9e49252b
EZ
63122011-12-03 Eli Zaretskii <eliz@gnu.org>
6313
6314 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6315 before a newline, prepare the bidi iterator for consuming the
6316 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6317 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6318
02b16839
JL
63192011-12-02 Juri Linkov <juri@jurta.org>
6320
6321 * search.c (Fword_search_regexp): New Lisp function created from
6322 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6323 (Fword_search_backward, Fword_search_forward)
6324 (Fword_search_backward_lax, Fword_search_forward_lax):
6325 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6326 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6327
0068070e
SM
63282011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6329
6330 * fileio.c (Finsert_file_contents): Move after-change-function call
6331 to before the "handled:" label, since all "goto handled" appear in
6332 cases where the *-change-functions have already been properly called
6333 (bug#10117).
6334
3360a3fc
AS
63352011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6336
6337 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6338 waiting for input. (Bug#10169)
6339
73d6c093
EZ
63402011-11-30 Eli Zaretskii <eliz@gnu.org>
6341
6342 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6343 verifies glyph row's hash code--we have just reallocated the
6344 glyphs, so their contents can be complete garbage. (Bug#10164)
6345
febe6bea
JB
63462011-11-30 Juanma Barranquero <lekktu@gmail.com>
6347
6348 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6349
801a4313
EZ
63502011-11-30 Eli Zaretskii <eliz@gnu.org>
6351
6352 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6353 attributes are tested _before_ calling verify_row_hash, to protect
6354 against GCC re-ordering of the tests. (Bug#10164)
6355
2b56b87e
JD
63562011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6357
6358 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6359
6360 * xterm.c (handle_one_xevent): Only set async_visible and friends
6361 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6362 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6363 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6364
dbf31225
PE
63652011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6366
6367 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6368 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6369 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6370 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6371 All uses changed to use GCPRO1 etc.
6372 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6373 Revert to old implementation (i.e., before 2011-03-11).
6374
1305621b
YM
63752011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6376
6377 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6378 of scroll runs so as to avoid assigning disabled bogus rows and
6379 unnecessary graphics copy operations.
6380
8c9afb46
EZ
63812011-11-27 Eli Zaretskii <eliz@gnu.org>
6382
6383 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6384 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6385 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6386 (malloc, free, realloc, calloc): Redirect to e_* only when
6387 compiling Emacs.
6388
6389 * lisp.h (GCTYPEBITS): Move before first use.
6390 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6391 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6392 this macro definition.
6393
6394 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6395 _MSC_VER.
6396
54e9e3bf
JD
63972011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6398
6d5eb5b0
SM
6399 * gtkutil.c (xg_create_frame_widgets):
6400 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6401 present with Gtk+ 2.0.
6402
83aca1cb
PE
64032011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6404
6405 * fileio.c (Finsert_file_contents): Undo previous change; see
6406 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6407
5b76caa4
PE
64082011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6409
6410 Rename locals to avoid shadowing.
6411 * fileio.c (Finsert_file_contents):
6412 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6413 * process.c (wait_reading_process_output):
6414 Rename inner 'proc' to 'p' to avoid shadowing.
6415 Indent for consistency with usual Emacs style.
6416
8c535114
EZ
64172011-11-25 Eli Zaretskii <eliz@gnu.org>
6418
6419 * xdisp.c (redisplay_window): If cursor row is not fully visible
6420 after recentering, and scroll-conservatively is set to a large
6421 number, scroll window by a few more lines to make the cursor fully
6422 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6423 (start_display): Don't move to the next line if the display should
6424 start at a newline that is part of a display vector or an overlay
6425 string. (Bug#10119)
8c535114 6426
fa4fdb5c
JL
64272011-11-24 Juri Linkov <juri@jurta.org>
6428
6429 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6430 after the `MagickPingImage' call. (Bug#10112)
6431
90ec88df
CY
64322011-11-23 Chong Yidong <cyd@gnu.org>
6433
6434 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6435
56e2e794
MR
64362011-11-23 Martin Rudalics <rudalics@gmx.at>
6437
6438 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6439 making another buffer current. (Bug#10114)
6440
b6e64c41
GM
64412011-11-23 Glenn Morris <rgm@gnu.org>
6442
6443 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6444
6b21de18
CY
64452011-11-23 Chong Yidong <cyd@gnu.org>
6446
6447 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6448 using it (Bug#5984).
6449
b12cd789
EZ
64502011-11-22 Eli Zaretskii <eliz@gnu.org>
6451
6452 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6453 and header-lines, as they don't have one computed for them.
6454 (Bug#10098)
6455
6456 * .gdbinit (prow): Make displayed values more self-explaining.
6457 Add row's hash code.
6458
261b6fd4
LMI
64592011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6460
6461 * process.c (wait_reading_process_output): Fix asynchrounous
6462 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6463 (wait_reading_process_output): Add comment and URL.
261b6fd4 6464
e7cfd277
JD
64652011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6466
6467 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6468
a9b9b7f5
CY
64692011-11-21 Chong Yidong <cyd@gnu.org>
6470
6471 * window.c (Fnext_window, Fprevious_window): Doc fix.
6472
b0d15b4f
SM
64732011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6474
6475 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6476
fe7a3057
JB
64772011-11-20 Juanma Barranquero <lekktu@gmail.com>
6478
6479 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6480
d2999b1a
MR
64812011-11-20 Martin Rudalics <rudalics@gmx.at>
6482
6483 * window.c (Fset_window_combination_limit): Rename argument
6484 STATUS to LIMIT.
6485 (Vwindow_combination_limit): Remove "status" from doc-string.
6486
d5ff9cd0
AS
64872011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6488
6489 * m/ibms390.h: Remove.
6490 * m/ibms390x.h: Don't include "ibms390.h".
6491
a5bb9bd3
SM
64922011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6493
6494 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6495 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6496
cd1181db
JB
64972011-11-20 Juanma Barranquero <lekktu@gmail.com>
6498
6499 * casetab.c (Fset_case_table):
6500 * charset.c (Fcharset_after): Fix typos.
6501
615a3b8d 65022011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6503
17e845af
PE
6504 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6505 Otherwise, valgrind does not work on some platforms.
6506 Problem reported by Andreas Schwab in
6a0bf43d
PE
6507 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6508 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6509 is set, removing the need for VIRT_ADDRESS_VARIES.
6510 (PURE_P): Use a more-efficient implementation that needs just one
6511 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6512 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6513 to 4 (xorl, subq, cmpq, setbe).
6514 * alloc.c (pure): Always extern now, since that's the
6515 VIRT_ADDR_VARIES behavior.
6516 (PURE_POINTER_P): Use a single comparison, not two, for
6517 consistency with the new puresize.h.
6518 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6519 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6520 Remove VIRT_ADDR_VARIES no longer needed.
6521
f8fe6f96
EZ
65222011-11-19 Eli Zaretskii <eliz@gnu.org>
6523
6524 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6525 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6526 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6527 behave as if the cursor position were at the window margin.
6528
6529 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6530 and the cursor position is out of bounds, behave as if the cursor
6531 position were at the window margin. (Bug#10075)
6532
df05a53c
CY
65332011-11-18 Chong Yidong <cyd@gnu.org>
6534
6535 * window.c (Fwindow_combination_limit): Make first argument
6536 non-optional, since it is meaningless for live windows like the
6537 selected window.
61ccba97 6538
2071918e
DA
65392011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6540
6541 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6542
b50a28de
SM
65432011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6544
6545 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6546 (graft_intervals_into_buffer): Simplify.
6547
015137db
EZ
65482011-11-18 Eli Zaretskii <eliz@gnu.org>
6549
6550 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6551 hash values of the two rows.
6552 (copy_row_except_pointers): Preserve the used[] arrays and the
6553 hash values of the two rows. (Bug#10035)
68c95424 6554 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6555
6556 * xdisp.c (row_hash): New function, body extracted from
6557 compute_line_metrics.
6558 (compute_line_metrics): Call row_hash, instead of computing the
6559 hash code inline.
6560
6561 * dispnew.c (verify_row_hash): Call row_hash for computing the
6562 hash code of a row, instead of duplicating code from xdisp.c.
6563
6564 * dispextern.h (row_hash): Add prototype.
6565
a2addb04
TH
65662011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6567
6568 * frame.c (delete_frame): Don't delete the terminal when the last
6569 X frame is closed if emacs is built with GTK toolkit.
6570
df85d315
JB
65712011-11-17 Juanma Barranquero <lekktu@gmail.com>
6572
6573 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6574
a0c2d0ae
MR
65752011-11-17 Martin Rudalics <rudalics@gmx.at>
6576
6577 * window.c (Vwindow_splits): Rename to
6578 Vwindow_combination_resize. Suggested by Juri Linkov.
6579 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6580 of Vwindow_splits.
6581
58179cce
JB
65822011-11-16 Juanma Barranquero <lekktu@gmail.com>
6583
7877f373
JB
6584 * nsfns.m (Fns_font_name):
6585 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6586
b6f67890
MR
65872011-11-16 Martin Rudalics <rudalics@gmx.at>
6588
6589 * window.h (window): Rename slot "nest" to "combination_limit".
6590 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6591 (Fset_window_nest): Rename to Fset_window_combination_limit.
6592 (Vwindow_nest): Rename to Vwindow_combination_limit.
6593 (recombine_windows, make_parent_window, make_window)
6594 (Fsplit_window_internal, saved_window)
6595 (Fset_window_configuration, save_window_save): Rename all
6596 occurrences of window_nest to window_combination_limit.
6597
c7015153
JB
65982011-11-15 Juanma Barranquero <lekktu@gmail.com>
6599
6600 * image.c (imagemagick_load_image): Fix typo.
6601
322ad6ec
EZ
66022011-11-14 Eli Zaretskii <eliz@gnu.org>
6603
6604 * xdisp.c (display_line): Move the call to
6605 highlight_trailing_whitespace before the call to
6606 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6607 faces of all the glyphs to compute ROW's hash value.
6608 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6609
f067b8ec
JB
66102011-11-14 Juanma Barranquero <lekktu@gmail.com>
6611
6612 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6613 just return (bug#10044).
6614
1e5b2111
EZ
66152011-11-12 Eli Zaretskii <eliz@gnu.org>
6616
7ef3cbd5
EZ
6617 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6618 with user-defined heap size. Bump the default size of the temacs
6619 heap to 27MB, to avoid memory warning when running temacs.
6620 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6621
1e5b2111
EZ
6622 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6623 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6624 (verify_row_hash) [XASSERTS]: New function.
6625 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6626 that the hash value of glyph rows is correct.
1e5b2111 6627
89d61221
MR
66282011-11-12 Martin Rudalics <rudalics@gmx.at>
6629
6630 * window.h (window): Remove splits slot.
6631 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6632 (Fdelete_other_windows_internal, make_parent_window)
6633 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6634 (Fset_window_configuration, save_window_save): Don't deal with
6635 split status of windows.
6636 (saved_window): Remove splits slot.
6637 (Vwindow_splits): Rewrite doc-string.
6638
97f18cc8
JD
66392011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6640
6641 * xfns.c (unwind_create_frame):
6642 * nsfns.m (unwind_create_frame):
6643 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6644 Vframe_list (Bug#9999).
6645
22a648b4
DA
66462011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6647
0b381c7e 6648 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6649
659afede
KH
66502011-11-11 Kenichi Handa <handa@m17n.org>
6651
6652 * callproc.c (Fcall_process): Set the member dst_multibyte of
6653 process_coding.
6654
9ac0394b
KH
66552011-11-11 Johan Bockgård <bojohan@gnu.org>
6656
6657 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6658 avoid a crash (bug#9496).
6659
2fbdc249
CY
66602011-11-09 Chong Yidong <cyd@gnu.org>
6661
6662 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6663 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6664
ac6b1f81
PE
66652011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6666
6667 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6668
09db192c
PE
66692011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6670
6671 Avoid some portability problems by eschewing 'extern inline' functions.
6672 The trivial performance wins aren't worth the portability hassles; see
6673 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6674 et seq.
6675 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6676 (window_box_width, window_box_left, window_box_left_offset)
6677 (window_box_right, window_box_right_offset): Undo previous change,
6678 by removing the "extern"s.
6679 * intervals.c (adjust_intervals_for_insertion)
6680 (adjust_intervals_for_deletion): Undo previous change,
6681 making these static again.
6682 (offset_intervals, temp_set_point_both, temp_set_point)
6683 (copy_intervals_to_string): No longer inline.
6684 * xdisp.c (window_text_bottom_y, window_box_width)
6685 (window_box_height, window_box_left_offset)
6686 (window_box_right_offset, window_box_left, window_box_right)
6687 (window_box): No longer inline.
6688
105216ed
CY
66892011-11-08 Chong Yidong <cyd@gnu.org>
6690
6691 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6692 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6693 Signal an error if not a live window.
105216ed
CY
6694 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6695 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6696
ae9e237f
JB
66972011-11-07 Juanma Barranquero <lekktu@gmail.com>
6698
6699 * lisp.h (syms_of_abbrev): Remove declaration.
6700 Reported by CHENG Gao <chenggao@royau.me>.
6701
c7aa8333
EZ
67022011-11-07 Eli Zaretskii <eliz@gnu.org>
6703
6704 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6705 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6706 of temacs in GUI mode.
6707
be7f5545
MR
67082011-11-07 Martin Rudalics <rudalics@gmx.at>
6709
6710 * window.h: Declare delete_all_child_windows instead of
6711 delete_all_subwindows.
6712 * window.c (Fwindow_nest, Fset_window_nest)
6713 (Fset_window_new_total, Fset_window_new_normal)
6714 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6715 (delete_all_subwindows): Rename to delete_all_child_windows.
6716 (Fdelete_other_windows_internal, Fset_window_configuration):
6717 Call delete_all_child_windows instead of delete_all_subwindows.
6718 * frame.c (delete_frame): Call delete_all_child_windows instead
6719 of delete_all_subwindows.
6720
ca78dc43
PE
67212011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6722
6723 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6724 This is also needed for porting to any host where GC_MARK_STACK is
6725 not GC_MAKE_GCPROS_NOOPS.
6726 (which_symbols): Use it.
6727
a0241d01
KH
67282011-11-07 Kenichi Handa <handa@m17n.org>
6729
6730 * coding.c (coding_set_destination): Check coding->src_pos only
6731 when coding->src_object is a buffer (bug#9910).
6732
6733 * process.c (send_process): Set the member src_multibyte of coding
6734 to 0 (bug#9911) when sending a unibyte text.
6735
6736 * callproc.c (Fcall_process): Set the member src_multibyte of
6737 process_coding to 0 (bug#9912).
6738
a64bfdfa 67392011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6740
6741 * xmenu.c (cleanup_widget_value_tree): New function.
6742 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6743 calling free_menubar_widget_value_tree directly (Bug#9830).
6744
cb41b32a
PE
67452011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6746
6747 Fix some portability problems with 'inline'.
6748 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6749 (window_box_width, window_box_left, window_box_left_offset)
6750 (window_box_right, window_box_right_offset): Declare extern.
6751 Otherwise, these inline functions do not conform to C99 and
6752 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6753 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6754 * intervals.c (adjust_intervals_for_insertion)
6755 (adjust_intervals_for_deletion): Now extern, because otherwise the
6756 extern inline functions 'offset_intervals' couldn't refer to it.
6757 (static_offset_intervals): Remove.
6758 (offset_intervals): Rewrite using the old contents of
6759 static_offset_intervals. The old version didn't conform to C99
6760 because an extern inline function contained a reference to an
6761 identifier with static linkage.
6762
b7041366
AS
67632011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6764
6765 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6766 GC.
6767
88a37c4d
EZ
67682011-11-06 Eli Zaretskii <eliz@gnu.org>
6769
6770 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6771 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6772 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6773 return Qleft_to_right.
6774
49745b39
CY
67752011-11-06 Chong Yidong <cyd@gnu.org>
6776
6777 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6778 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6779 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6780 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6781 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6782 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6783 (Fwindow_vscroll): Doc fix.
6784 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6785 argument, since it makes no sense to pass a live window and for
6786 consistency with window-child.
6787
1f05cd82
CS
67882011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6789
6790 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6791 support MSVC.
6792
22610910
JR
67932011-11-05 Jason Rumney <jasonr@gnu.org>
6794
6795 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6796 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6797 fonts (Bug#6029).
6798 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6799 bitwise arithmetic preventing use of unicode-sip and non-truetype
6800 opentype fonts.
6801
a06776b2
EZ
68022011-11-05 Eli Zaretskii <eliz@gnu.org>
6803
3ad924ba
EZ
6804 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6805 "emacs"-only part.
6806
a06776b2
EZ
6807 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6808 initialization code to keep similarity to xfns.c after changes
6809 from 2011-11-05.
6810
c9e7db78
JD
68112011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6812
a97f8f3f
JD
6813 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6814 (unwind_create_frame): New function (Bug#9943).
6815 (Fx_create_frame): Restructure code to be more similar to the one in
6816 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6817 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6818 Move terminal->reference_count++ just before making the frame official
6819 (Bug#9943).
6820
6821 * nsterm.m (x_free_frame_resources): New function.
6822 (x_destroy_window): Move code to x_free_frame_resources.
6823
c9e7db78 6824 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6825 (Fx_create_frame, x_create_tip_frame):
6826 Move terminal->reference_count++ just before making the frame
75f1671a 6827 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6828 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6829
a6fc3b5c
EZ
68302011-11-05 Eli Zaretskii <eliz@gnu.org>
6831
6832 Support MSVC build with newer versions of Visual Studio.
6833 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6834 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6835 nt/gmake.defs.
6836
6837 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6838 which are not supported by MSVC.
6839 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6840 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6841 bitfields.
6842 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6843 types in bitfields.
6844 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6845
6846 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6847
58179cce 68482011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6849
6850 Support MSVC build with newer versions of Visual Studio.
6851 * w32.c: Don't include w32api.h for MSVC.
6852 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6853
6854 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6855 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6856 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6857 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6858 e_* cousins.
6859 (alloca) [_MSC_VER]: Define to _alloca.
6860
6861 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6862
6863 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6864
a58c13ed
EZ
68652011-11-04 Eli Zaretskii <eliz@gnu.org>
6866
6867 * xdisp.c (note_mouse_highlight): If either of
6868 previous/next-single-property-change returns nil, treat that as
6869 the beginning or the end of the buffer. (Bug#9955)
6870
fe0b6370
JD
68712011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6872
a58c13ed 6873 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6874 label is not null (Bug#9951).
6875 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6876 may be NULL.
6877
89bd5ee1
EZ
68782011-11-04 Eli Zaretskii <eliz@gnu.org>
6879
6880 * window.c (Fwindow_body_size): Mention in the doc string that the
6881 return value is in frame's canonical units. (Bug#9949)
6882
84c3edb9
EZ
68832011-11-03 Eli Zaretskii <eliz@gnu.org>
6884
4e2fb5c7
EZ
6885 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6886
84c3edb9 6887 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6888 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6889 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6890
bc17a887
EZ
68912011-11-01 Eli Zaretskii <eliz@gnu.org>
6892
6893 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6894 Don't stop backward scan on the continuation glyph, even though
6895 its CHARPOS is positive.
6d5eb5b0
SM
6896 (mouse_face_from_buffer_pos, note_mouse_highlight):
6897 Rename cover_string to disp_string.
bc17a887 6898
4ee88440
MR
68992011-11-01 Martin Rudalics <rudalics@gmx.at>
6900
6901 * window.c (temp_output_buffer_show): Don't use
6902 Vtemp_buffer_show_specifiers.
6903 (Vtemp_buffer_show_specifiers): Remove unused variable.
6904
c2ff3c02
EZ
69052011-10-30 Eli Zaretskii <eliz@gnu.org>
6906
6907 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6908 past the beginning of the current glyph matrix.
6909
58179cce 69102011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6911
6912 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6913 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6914 HAVE_GTK3 (Bug#9869).
b77a6a7f 6915
3b574623
JD
6916 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6917 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6918
b77a6a7f
JD
6919 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6920
6921 * xterm.c: Declare x_handle_net_wm_state to return int.
6922 (handle_one_xevent): Check if we are iconified but don't have
6923 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6924 (get_current_wm_state): Return non-zero if not hidden,
6925 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6926 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6927 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6928 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6929
196e41e4
PE
69302011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6931
6932 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6933 so that this new function doesn't get optimized away by a
6934 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6935
021f2e1a
AS
69362011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6937
6938 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6939
8b058d44
EZ
69402011-10-29 Eli Zaretskii <eliz@gnu.org>
6941
6942 Fix the `xbytecode' command.
6943 * .gdbinit (xprintbytestr): New command.
b50a28de 6944 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6945 (xbytecode): Print the byte-code string as well.
6946
4452fb80
EZ
69472011-10-29 Kim Storm <storm@cua.dk>
6948
8b058d44
EZ
6949 * alloc.c (which_symbols): New function.
6950
21b72067
AS
69512011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6952
6953 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6954 line. (Bug#9903)
6955
83ed7b5c
GM
69562011-10-29 Glenn Morris <rgm@gnu.org>
6957
6958 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6959 Not clear what it was for, and it causes various bugs. (Bug#9839)
6960
5a7a728b
EZ
69612011-10-28 Eli Zaretskii <eliz@gnu.org>
6962
6963 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6964 possible random value that matches one of those tested as
6965 condition to clear the mouse face.
6966
d3d0842f
CY
69672011-10-28 Chong Yidong <cyd@gnu.org>
6968
6969 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6970
31b39d13
DN
69712011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6972
6973 * window.c (make_window): Initialize phys_cursor_on_p.
6974
9aba6043
SM
69752011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6976
6977 * lisp.h (struct Lisp_Symbol): Update comments.
6978
c20992f4
JB
69792011-10-28 Juanma Barranquero <lekktu@gmail.com>
6980
6981 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6982
db4f02f2
EZ
69832011-10-28 Eli Zaretskii <eliz@gnu.org>
6984
6985 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6986 <oslsachem@gmail.com> for helping to debug this.
6987
6988 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6989 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6990 (g_b_init_get_glyph_outline_w): New static variables.
6991 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6992 (GetGlyphOutlineW_Proc): New typedefs.
6993 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6994 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6995 New functions.
6996 (w32font_open_internal, compute_metrics):
6997 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6998 instead of calling the "wide" APIs directly.
6999
7000 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7001
7002 * w32.h (syms_of_w32font): Add prototype.
7003
87e68db4
JB
70042011-10-27 Juanma Barranquero <lekktu@gmail.com>
7005
7006 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7007 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7008 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7009 (Fmove_to_window_line): Doc fix.
7010
435c1d67
CY
70112011-10-27 Chong Yidong <cyd@gnu.org>
7012
7013 * process.c (make_process): Set gnutls_state to NULL.
7014
7015 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7016 non-NULL, regardless of GNUTLS_INITSTAGE.
7017 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7018 an error. Set process slots as soon as we allocate them.
7019
7020 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7021
9c6c6f49
CY
70222011-10-27 Chong Yidong <cyd@gnu.org>
7023
9aba6043
SM
7024 * gnutls.c (emacs_gnutls_deinit): New function.
7025 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7026 (Fgnutls_deinit, Fgnutls_boot): Use it.
7027
7028 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7029 (deactivate_process): Call emacs_gnutls_deinit.
7030
657d08d3
JB
70312011-10-27 Juanma Barranquero <lekktu@gmail.com>
7032
7033 * image.c (x_create_x_image_and_pixmap):
7034 * w32.c (sys_rename, w32_delayed_load):
7035 * w32font.c (fill_in_logfont):
7036 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7037
5430d399
JB
70382011-10-26 Juanma Barranquero <lekktu@gmail.com>
7039
7040 * w32fns.c (w32_default_color_map): New function,
7041 extracted from Fw32_default_color_map.
a7ef684b 7042 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7043
fe0055fa
PE
70442011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7045
7046 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7047
e6346438
SM
70482011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7049
7050 * keyboard.c (test_undefined): New function (bug#9751).
7051 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7052
e112cc37
ET
70532011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7054
7055 * sysdep.c (init_sys_modes): Fix the check for the controlling
7056 terminal (Bug#6649).
7057
7b5d6677
EZ
70582011-10-20 Eli Zaretskii <eliz@gnu.org>
7059
7060 * dispextern.h (struct bidi_it): New member next_en_type.
7061
7062 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7063 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7064 current character, check also for next_en_type being WEAK_EN.
7065 (bidi_resolve_weak): Don't enter the expensive loop if the current
7066 position is before next_en_pos. Record the bidi type of the first
7067 non-ET, non-BN character we find, in addition to its position.
7068 (bidi_level_of_next_char): Invalidate next_en_type when
7069 next_en_pos is over-stepped.
7070
7da0b018
PE
70712011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7072
7073 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7074 * editfns.c: Rewrite current-time-zone so that it invokes
7075 the equivalent of (format-time-string "%Z") to get the time zone name.
7076 This fixes a bug when the time zone name contains characters that
7077 need converting from the system time locale to Emacs internal format.
7078 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7079 that patch fixed format-time-string to do the conversion, but
7080 I forgot to fix current-time-zone.
7081 (format_time_string): New function, containing most of
7082 what Fformat_time_string used to contain.
7083 (Fformat_time_string): Rewrite in terms of format_time_string.
7084 This doesn't change this function's behavior.
7085 (current-time-zone): Rewrite to use format_time_string.
7086 This fixes the bug reported by Michael Schierl in
7087 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7088 Jason Rumney's 2007-06-07 change worked around this bug, but
7089 didn't fix it.
7090 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7091
8547b010
EZ
70922011-10-19 Eli Zaretskii <eliz@gnu.org>
7093
7094 * xdisp.c (start_display): If the character at POS is displayed
7095 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7096 (try_window_reusing_current_matrix): If a line ends in a display
7097 vector or the next line starts in a display vector, continue
7098 redrawing the window even though the character position of
7099 start_row was reached.
8547b010
EZ
7100 (Bug#9771, part 2)
7101
4e948d15
CY
71022011-10-18 Chong Yidong <cyd@gnu.org>
7103
7104 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7105 with nobreak-char-display too.
7106
4787455f
EZ
71072011-10-18 Eli Zaretskii <eliz@gnu.org>
7108
7109 Fix part 3 of bug#9771.
7110 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7111 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7112 non-neutral characters if the current character is a paragraph
7113 separator (a.k.a. Newline). This avoids running the same
7114 expensive loop twice, once when we consume the preceding newline
7115 and the other time when the line actually needs to be displayed.
7116 Avoid the loop when we see neutrals on the base embedding level
7117 following a character whose directionality is the same as the
7118 paragraph's. This avoids running the expensive loop when a line
7119 ends in a long sequence of neutrals, like control characters.
7120 Add assertion against STRONG_AL type. Slightly rearrange code
7121 that determines the type of a neutral given the first non-neutral
7122 that follows it.
7123 (bidi_level_of_next_char): Set next_en_pos to zero when
7124 invalidating its info.
7125
2c91f553
EZ
71262011-10-17 Eli Zaretskii <eliz@gnu.org>
7127
7128 * xdisp.c (push_display_prop): Determine whether to record string
7129 or buffer position by IT->string, not by IT->method. Allow
7130 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7131 (move_it_vertically_backward): Don't look for character position
7132 immediately after the newline when in a continuation line.
7133 (Bug#9771, part 1)
2c91f553 7134
c7b08b0d
MR
71352011-10-15 Martin Rudalics <rudalics@gmx.at>
7136
7137 * window.c (coordinates_in_window): Rewrite and delabelize
7138 vertical border check. (Bug#5357) (Bug#9618)
7139
6b02f655
SM
71402011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7141
7142 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7143 errors in XSetWindowBorder (bug#9310).
7144
81d40c92
DA
71452011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7146
7147 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7148 avoid crash when xmalloc overrun checking is enabled.
7149
d4172c3b
EZ
71502011-10-13 Eli Zaretskii <eliz@gnu.org>
7151
7152 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7153 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7154 cursor motion with <left> and <right> arrow keys.
7155
7156 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7157 some callers set that themselves.
7158
b00eea75
EZ
71592011-10-12 Eli Zaretskii <eliz@gnu.org>
7160
7161 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7162 display string and the previous row comes from the same string and
7163 is empty. (Bug#9739) (Bug#9738)
7164
8fe012c4
SM
71652011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7166
7167 * doc.c (get_doc_string): Encode file name (bug#9735).
7168
0074aef2
EZ
71692011-10-12 Eli Zaretskii <eliz@gnu.org>
7170
79beb178
EZ
7171 * bidi.c (bidi_level_of_next_char):
7172 * xdisp.c (get_visually_first_element): Remove old incorrect
7173 comments regarding the Unicode Line Separator character.
7174
0074aef2
EZ
7175 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7176
6e4b3fbe
DA
71772011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7178
7179 * alloc.c (Fgc_status): Do not access beyond zombies array
7180 boundary if nzombies > MAX_ZOMBIES.
7181 * alloc.c (dump_zombies): Add missing format specifier.
7182
0324f3af
PE
71832011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7184
b5525cac
PE
7185 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7186 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7187
0324f3af
PE
7188 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7189 Some packages use them to denote characters with modifiers.
7190
e9b5f888
AS
71912011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7192
7193 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7194 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7195 matching a pp-number. Rename parameter var to var1.
7196
127827c0
SM
71972011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7198
7199 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7200
c8fd3bd0
GM
72012011-10-08 Glenn Morris <rgm@gnu.org>
7202
7203 * callint.c (Fcall_interactively): Give a more explicit error for the
7204 'c' case with a non-character input. (Bug#8479)
7205
352ec8ff
EZ
72062011-10-08 Eli Zaretskii <eliz@gnu.org>
7207
03669ccb
EZ
7208 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7209 lines.
7061c986
EZ
7210 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7211 lines that are hscrolled on the left.
03669ccb 7212
352ec8ff
EZ
7213 * dispnew.c (buffer_posn_from_coords): Account for a possible
7214 presence of header-line. (Bug#4426)
7215
a66cfb1c
SM
72162011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7217
6b02f655
SM
7218 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7219 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7220
7c5ee88e
PE
72212011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7222
7223 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7224 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7225 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7226 this makes Emacs dump core during garbage collection on rare
7227 occasions. sizeof is obviously inferior to offsetof here, so
7228 stick with offsetof.
7229 (GC_POINTER_ALIGNMENT): New macro.
7230 (mark_memory): Omit 3rd (offset) arg; caller changed.
7231 Don't assume EMACS_INT alignment is the same as pointer alignment.
7232
df1bbe5b
SM
72332011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7234
7235 * keyboard.c (read_key_sequence_remapped): New var.
7236 (read_key_sequence): Compute remapping in the right buffer.
7237 (command_loop_1): Use read_key_sequence's remapping directly.
7238
51553db6
SM
72392011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7240
32c1fffd
SM
7241 * dired.c (file_name_completion): Don't expand file name.
7242 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7243 before checking file name handler.
7244
51553db6
SM
7245 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7246 they've been requested explicitly (bug#9591).
7247
b6bd1599 72482011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7249
7250 * keymap.c (Fsingle_key_description): Use make_specified_string
7251 instead of build_string to build string from push_key_description.
7252 (Bug#5193)
7253
f701dc2a
PE
72542011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7255
4222c55d
PE
7256 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7257 This fixes a Y2038 bug on 64-bit hosts.
7258 * buffer.c (reset_buffer):
7259 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7260 (Fclear_buffer_auto_save_failure):
7261 Use 0, not -1, to represent an unset failure time, since time_t
7262 might not be signed.
7263
f701dc2a
PE
7264 Remove dependency on glibc malloc internals.
7265 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7266 Move back here from lisp.h, but with their new implementations.
7267 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7268 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7269 * charset.c (charset_table_init): New static var.
7270 (syms_of_charset): Use it instead of xmalloc. This removes a
7271 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7272 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7273 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7274 Move back to alloc.c.
7275 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7276 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7277
9ceebf39
JD
72782011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7279
7280 * nsterm.m (windowDidResize): Call x_set_window_size only when
7281 ns_in_resize is true. Otherwise set pixelwidth/height and
7282 call change_frame_size (Bug#9628).
7283
cb993c58
PE
72842011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7285
3930c88b
PE
7286 Port --enable-checking=all to Fedora 14 x86-64.
7287 * charset.c (syms_of_charset): Also account for glibc malloc's
7288 internal overhead when calculating the initial malloc maximum.
7289
cb993c58
PE
7290 Port --enable-checking=all to Fedora 14 x86.
7291 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7292 Move to lisp.h.
7293 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7294 (overrun_check_realloc, overrun_check_free):
7295 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7296 That way, xmalloc returns a properly-aligned pointer even if
7297 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7298 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7299 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7300 into account when calculating the initial malloc maximum.
7301 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7302 Move here from alloc.c, so that charset.c can use it too.
7303 Properly align; the old code wasn't right for common 32-bit hosts
7304 when configured with --enable-checking=all.
7305 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7306 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7307
31bed486
EZ
73082011-09-29 Eli Zaretskii <eliz@gnu.org>
7309
04c70788 7310 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7311 use EDOM.
7312
fbcaa2f3
EZ
73132011-09-28 Eli Zaretskii <eliz@gnu.org>
7314
7315 * xdisp.c (compute_display_string_end): If there's no display
7316 string at CHARPOS, return -1.
7317
7318 * bidi.c (bidi_fetch_char): When compute_display_string_end
7319 returns a negative value, treat the character as a normal
7320 character not covered by a display string. (Bug#9624)
7321
a239d4e9
JB
73222011-09-28 Juanma Barranquero <lekktu@gmail.com>
7323
7324 * lread.c (Fread_from_string): Fix typo in docstring.
7325
88652fd5
EZ
73262011-09-27 Eli Zaretskii <eliz@gnu.org>
7327
7328 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7329 newline, reseat the iterator instead of bidi-iterating there one
7330 character at a time. (Bug#9610)
32c1fffd
SM
7331 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7332 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7333
ed497dd4
AS
73342011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7335
7336 * lread.c (readevalloop): Use correct code for NBSP.
7337 (read1): Likewise. (Bug#9608)
7338
b2bf61aa
MA
73392011-09-25 Michael Albinus <michael.albinus@gmx.de>
7340
7341 * dbusbind.c (Fdbus_register_signal): When service is not
7342 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7343
32bbb17c
GM
73442011-09-25 Glenn Morris <rgm@gnu.org>
7345
7346 * buffer.c (truncate-lines): Doc fix.
7347
94e0933e
CY
73482011-09-24 Chong Yidong <cyd@stupidchicken.com>
7349
7350 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7351 (Fset_window_next_buffers): Doc fix.
7352
cddde921
GM
73532011-09-24 Glenn Morris <rgm@gnu.org>
7354
7355 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7356
1260aef1
PE
73572011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7358
25b4bfa0
PE
7359 Fix minor problems found by static checking.
7360 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7361 * indent.c (Fvertical_motion): Fix == vs = typo.
7362
e3cbd34b
EZ
73632011-09-24 Eli Zaretskii <eliz@gnu.org>
7364
a66cfb1c
SM
7365 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7366 Default value is now t. Doc fix.
6bf7006f 7367
e3cbd34b 7368 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7369 logic when moving up, not only when moving down. Fix the
e3cbd34b 7370 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7371 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7372
7373 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7374 CHARPOS is covered by a display string which includes newlines.
7375 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7376 is covered by a display string with embedded newlines.
7377
a3de0cbd
MA
73782011-09-24 Michael Albinus <michael.albinus@gmx.de>
7379
7380 * dbusbind.c (Fdbus_register_signal): Add match rule to
7381 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7382 (Fdbus_register_method, Vdbus_registered_objects_table):
7383 Fix docstring.
a3de0cbd 7384
b260039d
JM
73852011-09-24 Jim Meyering <meyering@redhat.com>
7386
32c1fffd 7387 do not ignore write error for any output size
b260039d
JM
7388 The previous change was incomplete.
7389 While it makes emacs --batch detect the vast majority of stdout
7390 write failures, errors were still ignored whenever the output size is
7391 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7392 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7393 && echo FAIL: ignored write error
7394 FAIL: ignored write error
7395 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7396 && echo FAIL: ignored write error
7397 FAIL: ignored write error
7398 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7399
8eca8a7c
AS
74002011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7401
7402 * emacs.c (Fkill_emacs): In noninteractive mode exit
7403 non-successfully if a write error occurred on stdout. (Bug#9574)
7404
3341db62
EZ
74052011-09-21 Eli Zaretskii <eliz@gnu.org>
7406
7407 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7408 the xassert test.
7409
7410 * dispextern.h (struct it): Update the comment documenting what
7411 can it->OBJECT be.
7412
8c203dbf
EZ
74132011-09-20 Eli Zaretskii <eliz@gnu.org>
7414
7415 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7416 a display string, extend search for cursor position to end of row.
7417 (find_row_edges): If the row ends in a newline from a display
7418 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7419 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7420 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7421 non-empty line. Fixes confusing cursor motion with arrow keys at
7422 the beginning of a line that starts with whitespace.
8c203dbf 7423
a4824228
LMI
74242011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7425
7426 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7427 (bug#9493).
7428
33ed493b
CY
74292011-09-18 Chong Yidong <cyd@stupidchicken.com>
7430
7431 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7432 boolean (Bug#9154).
7433
56cd55c8
EZ
74342011-09-18 Eli Zaretskii <eliz@gnu.org>
7435
7436 * xdisp.c (display_line): Record maximum and minimum buffer
7437 positions even if no glyphs were produced (e.g., by a zero-width
7438 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7439 buffer positions that will be removed from the glyph row because
7440 they don't fit.
c02dcedf
EZ
7441 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7442 column is beyond frame width: don't subtract 1 "pixel" when
7443 computing width of the stretch.
3e62b7e0
EZ
7444 (reseat_at_next_visible_line_start): Undo the change made on
7445 2011-09-17 that saved paragraph information and restored it after
7446 the call to `reseat'. (Bug#9545)
56cd55c8 7447
5ed99d36 74482011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7449
7450 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7451 and turn window cursor on if cleared (Bug#9415).
7452
5ed99d36 74532011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7454
7455 * search.c (boyer_moore): Take unibyte characters from pattern
7456 literally. (Bug#9458)
7457
9bade7b2
EZ
74582011-09-18 Eli Zaretskii <eliz@gnu.org>
7459
7460 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7461
e5e9d610
PE
74622011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7463
87e4427a
PE
7464 Fix minor problem found by static checking.
7465 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7466 initialized, to pacify gcc -Wuninitialized.
7467
e5e9d610
PE
7468 * fileio.c: Report proper errno when syscall falls.
7469 (Finsert_file_contents): Save and restore errno,
7470 so that report_file_error outputs the correct diagnostic.
7471 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7472
a1674f0b
EZ
74732011-09-18 Eli Zaretskii <eliz@gnu.org>
7474
7475 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7476
fbfb6dd4
EZ
74772011-09-17 Eli Zaretskii <eliz@gnu.org>
7478
7479 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7480 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7481
bb187662
EZ
74822011-09-17 Eli Zaretskii <eliz@gnu.org>
7483
1137e8b8 7484 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7485 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7486
7487 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7488 (bidi_find_paragraph_start): Search back for paragraph beginning
7489 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7490 (bidi_move_to_visually_next): Only trigger paragraph-related
7491 computations when the last character is a newline or at EOB, not
7492 just any NEUTRAL_B. (Bug#9470)
7493
bb187662
EZ
7494 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7495 truncated lines if point is covered by a display string. (Bug#9524)
7496
2e621251
PE
74972011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7498
7499 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7500 (cons_to_x_long): New function.
7501 (lisp_data_to_selection_data): Use it. Correct the test for
7502 short-versus-long data; it was negated. Break out of vector
7503 loop, for efficiency, when a long datum is discovered.
7504
91a15bc6
SM
75052011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7506
7507 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7508
b41c3a35
EZ
75092011-09-16 Eli Zaretskii <eliz@gnu.org>
7510
7511 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7512 GCC PR/17406) by declaring this function with external scope.
7513
7812ba2d
PE
75142011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7515
7516 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7517 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7518
cf7edc2a
AS
75192011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7520
7521 * editfns.c (Fformat): Correctly handle text properties on "%%".
7522
bd01620e
EZ
75232011-09-15 Eli Zaretskii <eliz@gnu.org>
7524
7525 * xterm.c (x_draw_composite_glyph_string_foreground):
7526 * w32term.c (x_draw_composite_glyph_string_foreground):
7527 * term.c (encode_terminal_code):
7528 * composite.c (composition_update_it, get_composition_id):
7529 * xdisp.c (get_next_display_element)
7530 (fill_composite_glyph_string): Add comments about special meaning
7531 of TAB characters in a composition.
7532
a02719a3
PE
75332011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7534
7535 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7536 This occurs when processing a multibyte format.
7537 Problem reported by Wolfgang Jenker.
a02719a3 7538
72589a3c
JB
75392011-09-15 Johan Bockgård <bojohan@gnu.org>
7540
7541 * xdisp.c (try_cursor_movement): Only check for exact match if
7542 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7543
1c14176c
PE
75442011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7545
7546 Remove unused external symbols.
7547 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7548 * xdisp.c (calc_pixel_width_or_height): Now static.
7549 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7550 * indent.c (check_display_width):
7551 * w32term.c: Fix comment to match code.
7552 * xterm.c, xterm.h (x_catching_errors): Remove.
7553
d2eea5b5
PE
75542011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7555
7556 * xselect.c: Use signed conversions more consistently (Bug#9498).
7557 (selection_data_to_lisp_data): Assume incoming selection data are
7558 signed integers, not unsigned. This is to be consistent with
7559 outgoing selection data, which was modified to use signed integers
7560 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7561 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7562 expects long, not unsigned long.
7563
46888499
EZ
75642011-09-14 Eli Zaretskii <eliz@gnu.org>
7565
7566 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7567 computation of loop end. Reported by Johan Bockgård
7568 <bojohan@gnu.org>.
7569
ef8ef9fb
CY
75702011-09-13 Chong Yidong <cyd@stupidchicken.com>
7571
7572 * frame.c (Fother_visible_frames_p): Function deleted.
7573
fa819fed
EZ
75742011-09-12 Eli Zaretskii <eliz@gnu.org>
7575
7576 * indent.c (compute_motion): Process display vector front to back
7577 rather than the other way around. (Bug#2496)
7578
2ba8e008
SM
75792011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7580
7581 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7582
20f53c69
CY
75832011-09-11 Chong Yidong <cyd@stupidchicken.com>
7584
7585 * minibuf.c (Fread_from_minibuffer): Doc fix.
7586
d562d7a4
EZ
75872011-09-11 Eli Zaretskii <eliz@gnu.org>
7588
7589 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7590 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7591
1c4d7f3d
LMI
75922011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7593
7594 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7595 value for non-existent files.
7596
b885bf36
EZ
75972011-09-11 Eli Zaretskii <eliz@gnu.org>
7598
7599 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7600 set its "size" to -1. This will set the modtime_size field of
7601 the corresponding buffer to -1, which is what
7602 verify-visited-file-modtime expects for files that do not exist.
7603 (Bug#9139)
7604
6612f0bf
PE
76052011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7606
7607 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7608 here ...
7609 * lisp.h: ... from here. push_key_description is no longer
7610 defined in keyboard.c, so its declaration should not be in
7611 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7612 logically belongs with push_key_description.
7613
dfb3f755
PE
76142011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7615
7616 * buffer.h: Include <sys/types.h> instead of <time.h>.
7617 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7618 Problem reported by Herbert J. Skuhra.
7619
3134906c
LMI
76202011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7621
7622 * xml.c (parse_region): Make the parsing work for
7623 non-comment-starting XML files again (bug#9144).
7624
8d903f4e
AS
76252011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7626
7627 * image.c (gif_load): Fix calculation of bottom and right corner.
7628 (Bug#9468)
7629
80ad64f4
EZ
76302011-09-10 Eli Zaretskii <eliz@gnu.org>
7631
7632 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7633 redisplay in small windows.
7634
208a048d
EZ
76352011-09-09 Eli Zaretskii <eliz@gnu.org>
7636
7637 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7638
9b1c252e
MR
76392011-09-08 Martin Rudalics <rudalics@gmx.at>
7640
7641 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7642 Operate on live windows only.
7643
2949f33b
JB
76442011-09-08 Juanma Barranquero <lekktu@gmail.com>
7645
7646 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7647
e08dcafd
EZ
76482011-09-07 Eli Zaretskii <eliz@gnu.org>
7649
7650 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7651 only under bidi iteration.
7652
115b96bd
JD
76532011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7654
7655 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7656
c8199d0f
PE
76572011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7658
7659 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7660 Without this fix, the command to link temacs failed due to an
7661 undefined symbol __builtin_isnan. This is because
7662 /usr/include/iso/math_c99.h #defines isnan(x) to
7663 __builtin_isnan(x), but the bundled gcc, which identifies itself
7664 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7665 a __builtin_isnan.
7666 * floatfns.c (isnan): #undef, and then #define to a clone of
7667 what's in data.c.
7668 (Fisnan): Always define, since it's always available now.
7669 (syms_of_floatfns): Always define isnan at the Lisp level.
7670
e39b275c 76712011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7672
7673 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7674
b2db44d9 76752011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7676
f4af5137 7677 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7678 The previous code assumed that file offsets (off_t values) fit in
7679 EMACS_INT variables, which is not true on typical 32-bit hosts.
7680 The code messed up by falsely reporting buffer overflow in cases
7681 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7682 when "big" contains more than 2**29 bytes, even though this
7683 inserts just one byte and does not overflow the buffer.
7684 (Finsert_file_contents): Store file offsets as off_t
7685 values, not as EMACS_INT values. Check for overflow when
7686 converting between EMACS_INT and off_t. When checking for
7687 buffer overflow or for overlap, take the offsets into account.
7688 Don't use EMACS_INT for small values where int suffices.
7689 When checking for overlap, fix a typo: ZV was used where
7690 ZV_BYTE was intended.
7691 (Fwrite_region): Don't assume off_t fits into 'long'.
7692 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7693
ecfc0a49
MA
76942011-09-05 Michael Albinus <michael.albinus@gmx.de>
7695
7696 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7697
6511acf2 76982011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7699
0999621a 7700 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7701
7702 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7703 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7704 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7705 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7706 (modify_event_symbol): Do not assume that the length of
7707 name_alist_or_stem is safe to alloca and fits in int.
7708 (Fexecute_extended_command): Likewise for function name and binding.
7709 (Frecursion_depth): Wrap around reliably on integer overflow.
7710 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7711 since some callers pass EMACS_INT values.
7712 (Fsingle_key_description): Don't crash if symbol name contains more
7713 than MAX_ALLOCA bytes.
7714 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7715 (get_minibuffer): Arg is now EMACS_INT, not int.
7716 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7717 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7718 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7719
2be7d702
PE
7720 * dbusbind.c (signature_cat): New function.
7721 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7722 Do not overrun buffer; instead, report string overflow.
7723
9d1df220
PE
7724 * dispnew.c (add_window_display_history): Don't overrun buffer.
7725 Truncate instead; this is OK since it's just a log.
7726
33ef5c64
PE
7727 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7728 even if the time zone offset is outlandishly large.
7729 Don't mishandle offset == INT_MIN.
7730
66c6fdd5
PE
7731 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7732 when creating daemon; the previous buffer-overflow check was incorrect.
7733
d749b01b
PE
7734 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7735 which has the guts of the old verror function.
7736
b5cd1905
PE
7737 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7738 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7739
6e1a67fb
PE
7740 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7741 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7742 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7743 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7744 length of string rather than counting it via multiple sprintfs;
7745 that's simpler and more reliable.
c21721cc
PE
7746 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7747 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7748 sprintf, in case result does not fit in int.
7749
c57b67fc
PE
7750 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7751 (fontset_from_font): Print it.
7752
8a401434
PE
7753 * frame.c (tty_frame_count): Now printmax_t, not int.
7754 (make_terminal_frame, set_term_frame_name): Print it.
7755 (x_report_frame_params): In X, window IDs are unsigned long,
7756 not signed long, so print them as unsigned.
7757 (validate_x_resource_name): Check for implausibly long names,
7758 and don't assume name length fits in 'int'.
7759 (x_get_resource_string): Don't blindly alloca invocation name;
7760 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7761 not fit in int.
7762
6e1a67fb
PE
7763 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7764 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7765 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7766
0df02bf3
PE
7767 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7768 Use esprintf, not sprintf, in case result does not fit in int.
7769
48e30793
PE
7770 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7771 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7772 it as a large positive number.
7773 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7774 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7775
a66ff6d8
PE
7776 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7777 in case result does not fit in int.
7778
aca216ff
PE
7779 * print.c (float_to_string): Detect width overflow more reliably.
7780 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7781 buffer overrun. Don't assume list length fits in 'int'. Treat
7782 print length of 0 as 0, not as infinity; to be consistent with other
7783 uses of print length in this function. Don't overflow print length
7784 index. Don't assume hash table size fits in 'long', or that
7785 vectorlike size fits in 'unsigned long'.
7786
31c286f7
PE
7787 * process.c (make_process): Use printmax_t, not int, to format
7788 process-name gensyms.
7789
55e5faa1
PE
7790 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7791
80f2e268
PE
7792 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7793 to avoid potential buffer overrun.
7794
670741ab
PE
7795 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7796 if X resource line is longer than 512 bytes.
7797
b7163a50
PE
7798 * xfns.c (x_window): Make sprintf buffer a bit bigger
7799 to avoid potential buffer overrun.
7800
ae58ff1f
PE
7801 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7802
c43c8a6a
PE
7803 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7804
3f8236f4
PE
78052011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7806
53e9fe90 7807 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7808 Without these, Emacs silently mishandles large integers sometimes.
7809 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7810 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7811
6511acf2
PE
7812 * xdisp.c (try_window_id): Check Emacs fixnum range before
7813 converting to 'int'.
806add1d 7814
6511acf2 7815 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7816 Check that an Emacs fixnum is in range before assigning it to 'int'.
7817 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7818 values converted from Emacs fixnums.
7819 (Frecenter): Don't wrap around a line count if it is out of 'int'
7820 range; instead, treat it as an extreme value.
7821 (Fset_window_configuration, compare_window_configurations):
7822 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7823
6511acf2
PE
7824 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7825 that can exceed INT_MAX. Check that EMACS_INT value is in range
7826 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7827 (match_limit): Don't assume that a fixnum can fit in 'int'.
7828
6511acf2 7829 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7830 exceed INT_MAX.
7831
6511acf2 7832 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7833 (Fvertical_motion): Don't wrap around LINES values that don't fit
7834 in 'int'. Instead, treat them as extreme values. This is good
7835 enough for windows, which can't have more than INT_MAX lines anyway.
7836
fcb901a7
LMI
78372011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7838
0f2f6b6d
LMI
7839 * Require libxml/parser.h to avoid compilation warning.
7840
fcb901a7
LMI
7841 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7842
7843 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7844 since this reportedly can destroy thread storage.
7845
6e20a0d4
CY
78462011-08-30 Chong Yidong <cyd@stupidchicken.com>
7847
7848 * syntax.c (find_defun_start): Update all cache variables if
7849 exiting early (Bug#9401).
7850
148ae00e
EZ
78512011-08-30 Eli Zaretskii <eliz@gnu.org>
7852
f6cfbd8f
EZ
7853 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7854
148ae00e
EZ
7855 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7856 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7857 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7858
7859 * term.c (tty_append_glyph): New function.
7860 (produce_stretch_glyph): Static function and its prototype deleted.
7861
a66cfb1c
SM
7862 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7863 Add prototypes.
148ae00e 7864
c4a07a4c
PE
78652011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7866
7867 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7868 when checking :margin (Bug#9390).
7869 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7870 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7871 so that the name doesn't mislead. All uses changed.
7872
6bc8cd65
JB
78732011-08-28 Johan Bockgård <bojohan@gnu.org>
7874
7875 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7876 set_tty_hooks.
7877
dca4927e
EZ
78782011-08-27 Eli Zaretskii <eliz@gnu.org>
7879
7880 * xdisp.c (move_it_to): Don't bail out early when reaching
7881 position beyond to_charpos, if we are scanning backwards.
7882 (move_it_vertically_backward): When DY == 0, make sure we get to
7883 the first character in the line after the newline.
7884
f2cad773
PE
78852011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7886
7887 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7888 (ccl_driver): Do not generate an out-of-range pointer.
7889 (Fccl_execute_on_string): Remove unnecessary check for
7890 integer overflow, noted by Stefan Monnier in
7891 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7892 Remove a FIXME that didn't need fixing.
7893 Simplify the newly-introduced buffer reallocation code.
7894
0cae2cdb
JB
78952011-08-27 Juanma Barranquero <lekktu@gmail.com>
7896
7897 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7898
5fc295a4 78992011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7900
70c60eb2 7901 Integer and memory overflow issues (Bug#9196).
726e0ab1 7902
d31850da
PE
7903 * doc.c (get_doc_string): Rework so that
7904 get_doc_string_buffer_size is the actual buffer size, rather than
7905 being 1 less than the actual buffer size; this makes xpalloc more
7906 convenient.
7907
a69fbedb
PE
7908 * image.c (x_allocate_bitmap_record, cache_image):
7909 * xselect.c (Fx_register_dnd_atom):
7910 Simplify previous changes by using xpalloc.
7911
fe5c5d37
PE
7912 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7913 since either will do and ptrdiff_t is convenient with xpalloc.
7914
0065d054
PE
7915 * charset.c (charset_table_size)
7916 (struct charset_sort_data.priority): Now ptrdiff_t.
7917 (charset_compare): Don't overflow if priorities differ greatly.
7918 (Fsort_charsets): Don't assume list length fits in int.
7919 Check for size-calculation overflow when allocating sort data.
7920 (syms_of_charset): Allocate an initial charset table that is
7921 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7922
7923 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7924
7925 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7926 The actual value is always <= INT_MAX, and leaving it unsigned made
7927 overflow checking harder.
7928
7929 * dispextern.h (struct glyph_matrix.rows_allocated)
7930 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7931 with xpalloc. The values are still always <= INT_MAX.
7932
7933 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7934
7935 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7936 (SAFE_NALLOCA): New macro.
7937
7938 * region-cache.c (struct boundary.pos, find_cache_boundary)
7939 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7940 (set_cache_region, invalidate_region_cache)
7941 (revalidate_region_cache, know_region_cache, region_cache_forward)
7942 (region_cache_backward, pp_cache):
7943 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7944 so that ptrdiff_t * can be passed to xpalloc.
7945 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7946 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7947 (pp_cache): Don't assume cache_len fits in int.
7948 * region-cache.h: Adjust extern decls to match.
7949
7950 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7951 EMACS_INT, since either will do, for xpalloc.
7952
7953 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7954 (xnmalloc, xnrealloc, xpalloc): New functions.
7955
726e0ab1
PE
7956 * bidi.c (bidi_shelve_header_size): New constant.
7957 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7958 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7959
51f30bc5 7960 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7961 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7962 (overlay_strings):
7963 Don't update size of array until after memory allocation succeeds,
7964 because xmalloc/xrealloc may not return.
0065d054
PE
7965 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7966 now that we have proper integer overflow checking.
7967 (record_overlay_string, overlay_strings): Catch overflows when
7968 calculating size of overlay_str_buf.
726e0ab1 7969
0065d054
PE
7970 * callproc.c (Fcall_process): Check for size overflow when
7971 calculating size of args2.
7972 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7973 Normally we prefer signed values, but sticking with ptrdiff_t would
7974 require adding more-complicated checks.
726e0ab1
PE
7975
7976 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7977 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7978 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7979 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7980
7981 * character.c (Fstring): Check for size-calculation overflow.
7982
7983 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7984 unnecessary integer overflow. Check for size overflow.
7985 (encode_coding_object): Don't update size until xmalloc succeeds.
7986
7987 * composite.c (get_composition_id): Check for overflow in glyph
7988 length calculations.
7989
7990 Integer and memory overflow fixes for display code.
7991 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7992 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7993 (scrolling_window): Check for overflow in size calculations.
7994 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7995 Don't assume glyph table len fits in int.
7996 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7997 (row_table_size): Now ptrdiff_t, not int.
7998 (scrolling_window): Avoid overflow in size calculations.
7999 Don't update size until allocation succeeds.
8000 * fns.c (concat): Check for overflow in size calculations.
8001 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8002 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8003 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8004
8005 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8006 (get_doc_string): Check for size calculation overflow.
8007 Don't update size until allocation succeeds.
8008 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8009 EMACS_INT, where ptrdiff_t will do.
8010 (Fsubstitute_command_keys): Check for string overflow.
8011
8012 * editfns.c (set_time_zone_rule): Don't assume environment length
8013 fits in int.
8014 (message_length): Now ptrdiff_t, not int.
8015 (Fmessage_box): Don't update size until allocation succeeds.
8016 Don't assume message length fits in int.
8017 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8018
0065d054
PE
8019 * emacs.c (main): Do not reallocate argv, since there is a null at
8020 the end that can be overwritten, and this way there's no need to
8021 worry about size-calculation overflow.
8022 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8023
8024 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8025 alloc succeeds.
8026 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8027
8028 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8029 (x_set_scroll_bar_width, x_figure_window_size):
8030 Check for integer overflow.
8031 (x_set_alpha): Do not assume XINT fits in int.
8032
8033 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8034 This is for the members text_lines, text_cols, total_lines, total_cols,
8035 where the system imposes an 'int' limit.
8036
8037 * fringe.c (Fdefine_fringe_bitmap):
8038 Don't update size until alloc works.
8039
8040 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8041 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8042
8043 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8044 Check for size-calculation overflow.
8045 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8046 do, as we prefer signed integers.
8047 (id_to_widget.max_size, id_to_widget.used)
8048 (xg_store_widget_in_map, xg_remove_widget_from_map)
8049 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8050 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8051 Use and return ptrdiff_t, not int.
8052 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8053 * gtkutil.h: Change prototypes to match the above.
8054
8055 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8056 are duplicate now that they've been promoted to lisp.h.
8057 (x_allocate_bitmap_record, x_alloc_image_color)
8058 (make_image_cache, cache_image, xpm_load):
8059 Don't update size until alloc is done.
8060 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8061 (x_detect_edges):
3256efce 8062 Check for size calculation overflow.
726e0ab1
PE
8063 (ct_colors_allocated_max): New constant.
8064 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8065 overflow.
3256efce 8066
726e0ab1
PE
8067 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8068 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8069 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8070 Use ptrdiff_t, not int, to count maps.
8071 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8072 calculations. Don't update size until allocation succeeds.
8073 Redo calculations to avoid overflow.
726e0ab1
PE
8074 * keyboard.h: Change prototypes to match the above.
8075
8076 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8077 to count maps.
8078 (current_minor_maps): Check for size calculation overflow.
8079 * keymap.h: Change prototypes to match the above.
8080
8081 * lread.c (read1, init_obarray): Don't update size until alloc done.
8082
8083 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8084 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8085
726e0ab1
PE
8086 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8087 Now ptrdiff_t, not int.
8088 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8089 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8090
8091 * process.c (Fnetwork_interface_list): Check for overflow
8092 in size calculation.
8093
8094 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8095
8096 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8097 overflow. Don't bother calling xmalloc when xrealloc will do.
8098
8099 * search.c (Freplace_match): Check for size calculation overflow.
8100 (Fset_match_data): Don't assume list lengths fit in 'int'.
8101
8102 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8103 for command line length. Do not attempt to address one before the
8104 beginning of an array, as that's not portable.
8105
8106 * term.c (max_frame_lines): Remove; unused.
8107 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8108 not int.
8109 (encode_terminal_code, calculate_costs): Check for size
8110 calculation overflow.
8111 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8112 table lengths and related sizes. Don't update size until alloc
8113 done. Redo calculations to avoid overflow.
8114 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8115
8116 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8117 subtracting pointers.
8118 (gobble_line): Check for overflow more carefully. Don't update size
8119 until alloc done.
8120
8121 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8122 Don't update size until alloc done.
8123 Redo size calculations to avoid overflow.
8124 Check for size calculation overflow.
0065d054 8125 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8126
8127 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8128 Use ptrdiff_t, not int, for sizes.
8129 (store_mode_line_noprop_char): Don't update size until alloc done.
8130
0065d054
PE
8131 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8132 Use ptrdiff_t, not int, for sizes.
8133 (Finternal_make_lisp_face, cache_face):
8134 Check for size calculation overflow.
8135 (cache_face): Treat size calculation overflows as if they were
8136 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8137
8138 * xfns.c (x_encode_text, x_set_name_internal)
8139 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8140 sizes, since they can exceed INT_MAX in size. Check for size
8141 calculation overflow.
8142
0065d054
PE
8143 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8144 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8145 Don't update size until alloc done.
8146
0065d054 8147 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8148 as sprintf is limited to int lengths.
1d526e2f 8149
252c5ee1
PE
8150 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8151 (X_LONG_MIN): New macros.
864d7ce7
PE
8152 Use them to make the following changes clearer.
8153 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8154 This change doesn't affect the value now, but it may help remind
8155 future maintainers not to raise the value too much later.
8156 (SELECTION_QUANTUM): Remove, replacing with ...
8157 (selection_quantum): ... new function, which avoids overflow.
8158 All uses changed.
8159 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8160 assumption that selection length fits in 'int'.
8161 (x_reply_selection_request, x_handle_selection_request)
8162 (x_get_window_property, receive_incremental_selection)
8163 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8164 (lisp_data_to_selection_data, clean_local_selection_data):
8165 Use ptrdiff_t, not int, to record length of selection.
8166 (x_reply_selection_request, x_get_window_property)
8167 (receive_incremental_selection, x_property_data_to_lisp):
8168 Redo calculations to avoid overflow.
8169 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8170 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8171 something.
8172 (x_get_window_property, receive_incremental_selection)
8173 (lisp_data_to_selection_data, x_property_data_to_lisp):
8174 Check for size-calculation overflow.
8175 (x_get_window_property, receive_incremental_selection)
8176 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8177 Don't store size until memory allocation succeeds.
8178 (x_get_window_property): Plug memory leak on memory exhaustion.
8179 Don't double-block input; malloc is safe here. Don't assume 2**34
8180 - 4 fits in unsigned long. Add an xassert to check
8181 XGetWindowProperty overflow. Be more careful about overflow
8182 calculations, and distinguish size from memory overflow better.
8183 (receive_incremental_selection): When tracing, don't assume
8184 unsigned int is less than INT_MAX.
8185 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8186 harmful) conversions of unsigned short to int.
8187 (lisp_data_to_selection_data): Don't assume that integers
8188 in the range -65535 through -1 fit in an X unsigned short.
8189 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8190 result parameters unless successful. Rely on cons_to_unsigned
8191 to report problems with elements; the old code wasn't right anyway.
8192 (x_check_property_data): Check for int overflow; we cannot use
8193 a wider type due to X limits.
8194 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8195
726e0ab1 8196 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8197
0065d054
PE
8198 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8199 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8200 (x_color_cells): Don't store size until memory allocation succeeds.
8201 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8202 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8203 (x_term_init): Don't assume length fits in int (sprintf is limited
8204 to int size).
bc18e09d 8205
ebfa62c0
PE
8206 Use ptrdiff_t for composition IDs.
8207 * character.c (lisp_string_width):
8208 * composite.c (composition_table_size, n_compositions)
8209 (get_composition_id, composition_gstring_from_id):
8210 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8211 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8212 * window.c (Frecenter):
8213 Use ptrdiff_t, not int, for composition IDs.
8214 * composite.c (get_composition_id): Check for integer overflow.
8215 * composite.h: Adjust prototypes to match the above changes.
8216
d3411f89
PE
8217 Use ptrdiff_t for hash table indexes.
8218 * category.c (hash_get_category_set):
8219 * ccl.c (ccl_driver):
8220 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8221 * coding.c (coding_system_charset_list, detect_coding_system):
8222 * coding.h (struct coding_system.id):
8223 * composite.c (get_composition_id, gstring_lookup_cache):
8224 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8225 * image.c (xpm_get_color_table_h):
8226 * lisp.h (hash_lookup, hash_put):
8227 * minibuf.c (Ftest_completion):
8228 Use ptrdiff_t for hash table indexes, not int (which is too
8229 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8230 32-bit --with-wide-int hosts).
8231
e097a6fa
PE
8232 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8233 Add a FIXME comment about memory leaks.
8234 (syms_of_charset): Don't assume xmalloc returns.
8235
5637687f
PE
8236 Don't assume that stated character widths fit in int.
8237 * character.c (Fchar_width, c_string_width, lisp_string_width):
8238 * character.h (CHAR_WIDTH):
8239 * indent.c (MULTIBYTE_BYTES_WIDTH):
8240 Use sanitize_char_width to avoid undefined and/or bad behavior
8241 with outlandish widths.
a66cfb1c 8242 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8243 now that we have two such functions. All uses changed.
8244 (sanitize_char_width): New inline function.
8245
a2271ba2
PE
8246 Don't assume that tab-width fits in int.
8247 * character.h (sanitize_width): New inline function.
8248 (SANE_TAB_WIDTH): New macro.
8249 (ASCII_CHAR_WIDTH): Use it.
8250 * indent.c (sane_tab_width): Remove. All uses replaced by
8251 SANE_TAB_WIDTH (current_buffer).
8252 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8253
18c52557
PE
8254 * fileio.c: Integer overflow issues with file modes.
8255 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8256
caeeedc1
PE
8257 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8258 Remove unreachable code.
8259 (read_hex, load_charset_map_from_file): Check for integer overflow.
8260
6df6ae42 8261 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8262 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8263 (x_send_scroll_bar_event): Likewise. Check that the size does not
8264 exceed limits imposed by XClientMessageEvent, as well as the usual
8265 ptrdiff_t and size_t limits.
8266
b13995db
PE
8267 * keyboard.c: Overflow, signedness and related fixes.
8268 (make_lispy_movement): Use same integer type in forward decl
8269 that is used in the definition.
8270 (read_key_sequence, keyremap_step):
8271 Change bufsize argument back to int, undoing my 2011-03-30 change.
8272 We prefer signed types, and int is wide enough here.
8273 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8274 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8275 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8276 length, not size_t. Use ptrdiff_t for index, not int.
8277 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8278 possibility of integer overflow.
8279
13464394
PE
8280 Overflow, signedness and related fixes for images.
8281
8282 * dispextern.h (struct it.stack[0].u.image.image_id)
8283 (struct_it.image_id, struct image.id, struct image_cache.size)
8284 (struct image_cache.used, struct image_cache.ref_count):
8285 * gtkutil.c (update_frame_tool_bar):
8286 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8287 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8288 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8289 * nsmenu.m (update_frame_tool_bar):
8290 * xdisp.c (calc_pixel_width_or_height):
8291 * xfns.c (image_cache_refcount):
8292 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8293 on typical 64-bit hosts.
8294
8295 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8296 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8297 Omit unnecessary casts to int.
8298 (parse_image_spec): Check that integers fall into 'int' range
8299 when the callers expect that.
8300 (image_ascent): Redo ascent calculation to avoid int overflow.
8301 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8302 (lookup_image): Remove unnecessary tests.
8303 (xbm_image_p): Locals are now of int, not EMACS_INT,
8304 since parse_image_check makes sure they fit into int.
8305 (png_load, gif_load, svg_load_image):
8306 Prefer int to unsigned where either will do.
8307 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8308 old tiff_error_handler and tiff_warning_handler.
8309 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8310 stack buffer overflows. It uses only the features of vsnprintf
8311 that are common to both POSIX and native Microsoft.
8312 (tiff_error_handler, tiff_warning_handler): Use it.
8313 (tiff_load, gif_load, imagemagick_load_image):
8314 Don't assume :index value fits in 'int'.
8315 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8316 (imagemagick_load_image): Check that crop parameters fit into
8317 the integer types that MagickCropImage accepts. Don't assume
8318 Vimagemagick_render_type has a nonnegative value. Don't assume
8319 size_t fits in 'long'.
8320 (gs_load): Use printmax_t to print the widest integers possible.
8321 Check for integer overflow when computing image height and width.
8322
c11821d4
EZ
83232011-08-26 Eli Zaretskii <eliz@gnu.org>
8324
8325 * xdisp.c (redisplay_window): Don't force window start if point
8326 will be invisible in the resulting window. (Bug#9324)
8327
0c95fcf7
EZ
83282011-08-25 Eli Zaretskii <eliz@gnu.org>
8329
8330 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8331 the display spec is of the form `(space ...)'.
8332 (handle_display_spec): Return the value returned by
8333 handle_single_display_spec, not just 1 or zero.
8334 (handle_single_display_spec): If the display spec is of the form
8335 `(space ...)', and specifies display in the text area, return 2
8336 rather than 1.
fee65a97 8337 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8338 accurately, and prefer exact match for point under bidi.
8339 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8340
8341 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8342 into disp_prop; all users changed.
8343
8344 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8345 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8346 for the text covered by the display property.
8347
e4ed06f1
CY
83482011-08-25 Chong Yidong <cyd@stupidchicken.com>
8349
8350 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8351 Change return value to nil.
8352 (Frecord_buffer): Delete unused function.
8353
f67cdd7f
EZ
83542011-08-24 Eli Zaretskii <eliz@gnu.org>
8355
5980d4c6
EZ
8356 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8357 buffers, return left-to-right.
8610fe8b
EZ
8358 (set_cursor_from_row): Consider candidate row a win if its glyph
8359 represents a newline and point is on that newline. Fixes cursor
8360 positioning on the newline at EOL of R2L text within L2R
8361 paragraph, and vice versa.
8362 (try_cursor_movement): Check continued rows, in addition to
8363 continuation rows. Fixes unwarranted scroll when point enters a
8364 continued line of R2L text within an L2R paragraph, or vice versa.
8365 (cursor_row_p): Consider the case of point being equal to
8366 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8367 from the end of a short line to the beginning of a continued line
8368 of R2L text within L2R paragraph.
8369 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8370 composed characters.
5980d4c6 8371
f67cdd7f
EZ
8372 * bidi.c (bidi_check_type): Use xassert.
8373 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8374 members.
8375
bca633fb
EZ
83762011-08-23 Eli Zaretskii <eliz@gnu.org>
8377
8378 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8379 a character.
8380
4a5885a7
CY
83812011-08-23 Chong Yidong <cyd@stupidchicken.com>
8382
8383 * nsfont.m (ns_otf_to_script): Fix typo.
8384
0902a04e
KH
83852011-08-22 Kenichi Handa <handa@m17n.org>
8386
8387 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8388 extra slot even if the purpose is char-code-property-table.
8389
1a2e6670
EZ
83902011-08-23 Eli Zaretskii <eliz@gnu.org>
8391
8ddde651
EZ
8392 * xdisp.c (redisplay_window): When computing centering_position,
8393 account for the height of the header line. (Bug#8874)
8394
425cc014
EZ
8395 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8396 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8397 candidate is selected by the mouse, and that candidate has a
8398 composed character under the mouse.
8399
1a2e6670
EZ
8400 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8401 coordinates reported by pos-visible-in-window-p for a composed
8402 character in column zero.
8403
8b76d6f8
SM
84042011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8405
8406 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8407
dac347dd
EZ
84082011-08-22 Eli Zaretskii <eliz@gnu.org>
8409
8410 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8411 consider it a hit if to_charpos is anywhere in the range of the
8412 composed buffer positions.
8413
e013fb34
CY
84142011-08-22 Chong Yidong <cyd@stupidchicken.com>
8415
8416 * image.c (gif_load): Don't assume that each subimage has the same
8417 dimensions as the base image. Handle disposal method that is
8418 "undefined" by the gif spec (Bug#9335).
8419
bd1ba3e8
CY
84202011-08-20 Chong Yidong <cyd@stupidchicken.com>
8421
8422 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8423 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8424
54a1215b
EZ
84252011-08-19 Eli Zaretskii <eliz@gnu.org>
8426
823564e5
EZ
8427 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8428 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8429 from an Org mode buffer to a Speedbar frame.
8430
54a1215b
EZ
8431 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8432 a composition, take its buffer position from IT->cmp_it.charpos.
8433 Fixes cursor positioning at the beginning of a line that begins
8434 with a composed character.
8435
9778ebcc
EZ
84362011-08-18 Eli Zaretskii <eliz@gnu.org>
8437
0be6ee06
EZ
8438 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8439 character bidirectional type, use STRONG_L instead. Fixes crashes
8440 in a buffer produced by `describe-categories'.
8441
9778ebcc
EZ
8442 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8443 members before the level stack, so they would be saved and
8444 restored when copying iterator state. Fixes incorrect reordering
8445 around TABs covered by display properties.
8446
156bffbe
AS
84472011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8448
6b02f655 8449 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8450
72ad093b
CY
84512011-08-17 Chong Yidong <cyd@stupidchicken.com>
8452
8453 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8454 (internal_condition_case_2, internal_condition_case_n):
8455 Remove unnecessary aborts (Bug#9081).
72ad093b 8456
35774242
EZ
84572011-08-17 Eli Zaretskii <eliz@gnu.org>
8458
8459 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8460 has no `load' handler, try opening the file locally. (Bug#9311)
8461
db76dd85
KB
84622011-08-16 Ken Brown <kbrown@cornell.edu>
8463
8464 * gmalloc.c: Expand comment.
8465
b215eee5
EZ
84662011-08-16 Eli Zaretskii <eliz@gnu.org>
8467
8468 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8469 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8470
a4579d33
KB
84712011-08-16 Ken Brown <kbrown@cornell.edu>
8472
8473 Fix memory allocation problems in Cygwin build (Bug#9273).
8474
8475 * unexcw.c ( __malloc_initialized): Declare external variable.
8476 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8477
8b76d6f8
SM
8478 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8479 New variables.
a4579d33
KB
8480 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8481 dumped emacs.
8482 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8483 in the static heap.
8484 [CYGWIN] (special_realloc): New function.
8485 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8486 requests to realloc storage in the static heap.
8487
3ebec551
PE
84882011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8489
8490 * bidi.c (bidi_initialize): Remove unused local.
8491
9fd8be00
EZ
84922011-08-15 Eli Zaretskii <eliz@gnu.org>
8493
6b02f655
SM
8494 * bidimirror.h:
8495 * biditype.h: Remove file.
8496 * makefile.w32-in ($(BLD)/bidi.$(O)):
8497 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8498
8499 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8500
8501 * chartab.c: Improve commentary for the uniprop_table API.
8502
32413314
EZ
8503 * bidi.c (bidi_paragraph_init): Support zero value of
8504 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8505 (bidi_initialize): Use uniprop_table instead of including
8506 biditype.h and bidimirror.h.
32413314 8507
9fd8be00
EZ
8508 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8509 coordinates of the iterator when restoring from ppos_it.
8510 (Bug#9296)
8511
5cf2b69b
KH
85122011-08-14 Kenichi Handa <handa@m17n.org>
8513
8514 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8515 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8516
daf17d00
EZ
85172011-08-14 Eli Zaretskii <eliz@gnu.org>
8518
8519 * xdisp.c (move_it_in_display_line_to): Don't invoke
8520 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8521 ppos_it. Fixes vertical cursor motion when line beginning is
8522 covered by an image. (Bug#9296)
8523
08e3161a
JD
85242011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8525
8526 * nsterm.h (ns_run_ascript): Declare.
8527 (NSAPP_DATA2_RUNASSCRIPT): Define.
8528
8529 * nsfns.m (as_script, as_result, as_status): New static variables.
8530 (ns_run_ascript): New function.
5e617bc2 8531 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8532 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8533 the event loop. Get status from as_status (Bug#7276).
8534
8535 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8536 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8537 the event loop (Bug#7276).
8538
a3720aa2
AS
85392011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8540
8541 * gnutls.c (QCgnutls_bootprop_priority)
8542 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8543 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8544 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8545 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8546 (QCgnutls_bootprop_verify_hostname_error)
8547 (QCgnutls_bootprop_callbacks_verify): Rename from
8548 Qgnutls_bootprop_..., all uses changed.
8549
8550 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8551 uses changed.
8552
0a0d27fb
PE
85532011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8554
19d5c50c
PE
8555 * xfaces.c (Qframe_set_background_mode): Now static.
8556 * dispextern.h (Qframe_set_background_mode): Remove decl.
8557
0a0d27fb
PE
8558 * process.c (Fnetwork_interface_info): Declare local only if needed.
8559
377538cb
JD
85602011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8561
8562 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8563 (Fnetwork_interface_list): Allocate in increments of bytes instead
8564 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8565 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8566 sockaddr.
8567 (struct ifflag_def): notrailers is smart on OSX.
8568 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8569 Get hardware address with getifaddrs if available.
8570
08fff70c
EZ
85712011-08-12 Eli Zaretskii <eliz@gnu.org>
8572
8573 * xdisp.c (iterate_out_of_display_property): xassert that
8574 IT->position is set to within IT->object's boundaries. Break from
8575 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8576 when IT->position is set up wrongly due to some bug.
8577 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8578 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8579 entry. Force push_it to save on the stack the current
8580 buffer/string position, to be restored by pop_it. Fix flags in
8581 the iterator structure wrt the object coming from a display
8582 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8583 properties. (Bug#9284)
8584
7be1c708 85852011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8586
7be1c708
CY
8587 * fontset.c (fontset_get_font_group): Add proper type checks.
8588 (Bug#9172)
aac0c6e3 8589
7be1c708 85902011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8591
7be1c708
CY
8592 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8593 and LC_VERSION_MIN_MACOSX.
8594 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8595 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8596
97bb72a6
EZ
85972011-08-08 Eli Zaretskii <eliz@gnu.org>
8598
8599 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8600 no-display-properties-and-no-overlays under bidi display.
8601 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8602 properties and overlays.
97bb72a6 8603
d5617611
CY
86042011-08-08 Chong Yidong <cyd@stupidchicken.com>
8605
37e11a63
CY
8606 * editfns.c (Fset_time_zone_rule): Document relationship with the
8607 setenv function.
8608
d5617611
CY
8609 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8610 the font entity extracted from the cache (Bug#8109).
8611
58872834
CY
86122011-08-07 Chong Yidong <cyd@stupidchicken.com>
8613
8614 * composite.c (autocmp_chars): Don't reset point. That is done by
8615 restore_point_unwind (Bug#5984).
8616
75bfc667
JL
86172011-08-07 Juri Linkov <juri@jurta.org>
8618
8619 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8620 to show the arg `TIME' instead of `TIMEVAL'.
8621
d1410150
EZ
86222011-08-06 Eli Zaretskii <eliz@gnu.org>
8623
8624 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8625 display property strides EOL and includes a newline, as in
8626 longlines-mode. (Bug#9254)
75b771e4
EZ
8627 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8628 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8629
8630 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8631 is non-zero, even if the data buffer is NULL. Fixes a crash in
8632 vertical-motion with longlines-mode. (Bug#9254)
8633
35928349
EZ
86342011-08-05 Eli Zaretskii <eliz@gnu.org>
8635
ec7cc85b
EZ
8636 * bidi.c <bidi_cache_total_alloc>: Now static.
8637 (bidi_initialize): Initialize bidi_cache_total_alloc.
8638
8b76d6f8 8639 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8640 cache. (Bug#9221)
8641
8642 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8643 amount allocated this far in `bidi_cache_total_alloc'.
8644 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8645 non-zero, only free the data buffer without restoring the cache
8646 contents. All callers changed.
8647
8648 * dispextern.h (bidi_unshelve_cache): Update prototype.
8649
8650 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8651 (move_it_in_display_line, move_it_to)
8652 (move_it_vertically_backward, move_it_by_lines): Replace the call
8653 to xfree to an equivalent call to bidi_unshelve_cache.
8654 (move_it_in_display_line_to): Fix logic of returning
412b6358 8655 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8656
e2e2423b
EZ
86572011-08-05 Eli Zaretskii <eliz@gnu.org>
8658
8659 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8660 came from a string character with a `cursor' property. (Bug#9229)
8661
ae9e757a
JD
86622011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8663
8664 * Makefile.in (LIB_PTHREAD): New variable.
8665 (LIBES): Add LIB_PTHREAD (Bug#9216).
8666
8667 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8668 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8669
213bd7f2
AS
86702011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8671
6b02f655 8672 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8673
99aaf75f
JD
86742011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8675
8676 * xterm.c (x_find_topmost_parent): New function.
8677 (x_set_frame_alpha): Find topmost parent window with
8678 x_find_topmost_parent and set the property there also (bug#9181).
8679 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8680
c74e9d86
PE
86812011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8682
8683 * callproc.c (Fcall_process): Avoid vfork clobbering
8684 the local vars buffer, coding_systems, current_dir.
8685
640c8776
SM
86862011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8687
8688 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8689
f26d0e4c
PE
86902011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8691
8a10d76c
PE
8692 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8693 so that it is not optimized away.
8694
f26d0e4c
PE
8695 * xdisp.c (compute_display_string_pos): Remove unused local.
8696
55439c61
EZ
86972011-08-02 Eli Zaretskii <eliz@gnu.org>
8698
8699 Fix slow cursor motion and scrolling in large buffers with
8700 selective display, like Org Mode buffers. (Bug#9218)
8701
8702 * dispextern.h (struct bidi_it): New member disp_prop_p.
8703
8704 * xdisp.c: Remove one-slot cache of display string positions.
8705 (compute_display_string_pos): Accept an additional argument
5e617bc2 8706 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8707 for a display string or property. If found, set DISP_PROP_P
8708 non-zero.
8709
8710 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8711 DISP_PROP_P, and pass it to compute_display_string_pos.
8712 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8713 non-zero. All callers of bidi_fetch_char changed.
8714
fb33fa43
SM
87152011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8716
8717 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8718
b099e063
DM
87192010-12-03 Don March <don@ohspite.net>
8720
8721 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8722 last character M-[char] is translated to ESC [char] (bug#7541).
8723
5cc7f7af
KH
87242011-08-02 Kenichi Handa <handa@m17n.org>
8725
d0fffa3f 8726 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8727
8728 * chartab.c (uniprop_table): Make it non-static.
8729
525d5e6e
EZ
87302011-08-01 Eli Zaretskii <eliz@gnu.org>
8731
8732 * xdisp.c (forward_to_next_line_start): Accept additional argument
8733 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8734 on the newline.
8735 (reseat_at_next_visible_line_start): Use the bidi iterator state
8736 returned by forward_to_next_line_start to restore the state of
8737 it->bidi_it after backing up to previous newline. (Bug#9212)
8738
31011111
AS
87392011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8740
8741 * regex.c (re_comp): Protoize.
8742 (re_exec): Fix return type.
8743 (regexec): Fix type of `ret'. (Bug#9203)
8744
476371c4
PE
87452011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8746
e5d76069
PE
8747 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8748 This is needed if max-image-size is a floating-point number.
8749
9a79b20c
AS
87502011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8751
8752 * print.c (print_object): Print empty symbol as ##.
8753
8754 * lread.c (read1): Read ## as empty symbol.
8755
d8c2fa78
AA
87562011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8757
8758 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8759 setting frame foreground color (Bug#9175).
8760 (x_set_background_color): Likewise.
8761
ffe57a7a
AA
8762 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8763 contents (Bug#9176).
8764 (EmacsTooltip -init): Remove bezels and add shadows to
8765 tooltip windows.
8766
bf3492a5
AA
8767 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8768 or scroll bar (Bug#8470).
8769
d55e9c53
AA
8770 * nsfont.m (nsfont_open): Remove assignment to voffset and
8771 unnecessary vars hshink, expand, hd, full_height, min_height.
8772 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8773
8774 * nsterm.h (nsfont_info): Remove voffset field.
8775
d8c2fa78 87762011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8777
8778 Implement strike-through and overline on NextStep (Bug#8863).
8779
8780 * nsfont.m (nsfont_open): Use underline position provided by font,
8781 instead of hard-coded value of 2.
8782 (nsfont_draw): Call ns_draw_text_decoration instead.
8783
8784 * nsterm.h: Add declaration for ns_draw_text_decoration.
8785
8786 * nsterm.m (ns_draw_text_decoration): New function for drawing
8787 underline, overline, and strike-through.
8788 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8789 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8790 accommodate underlining, etc.
4843aac3 8791
4cc60b9b
EZ
87922011-07-28 Eli Zaretskii <eliz@gnu.org>
8793
bc7ece87
EZ
8794 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8795 default.
4cc60b9b 8796
476371c4
PE
87972011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8798
66606eea
PE
8799 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8800 Without this fix, if a signal arrives just after memory fills up,
8801 'malloc' might be invoked reentrantly.
8802
476371c4
PE
8803 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8804 In other words, assume that every image size is allowed, on non-X
8805 hosts. This assumption is probably wrong, but it lets Emacs compile.
8806
f3fcc40d
AS
88072011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8808
8809 * regex.c (re_iswctype): Convert return values to boolean.
8810
350c992f
EZ
88112011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8812
8813 * xdisp.c (compute_display_string_pos): Don't use cached display
8814 string position if the buffer had its restriction changed.
8815 (Bug#9184)
8816
5266b4bb
PE
88172011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8818
8819 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8820
2573a837 88212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8822
41f55ccd 8823 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8824
39e378da
PE
8825 * bidi.c: Integer size and overflow fixes.
8826 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8827 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8828 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8829 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8830 (bidi_find_other_level_edge):
8831 Use ptrdiff_t instead of EMACS_INT where either will do.
8832 This works better on 32-bit hosts configured --with-wide-int.
8833 (bidi_cache_ensure_space): Check for size-calculation overflow.
8834 Use % rather than repeated addition, for better worst-case speed.
8835 Don't set bidi_cache_size until after xrealloc returns, because it
8836 might not return.
8837 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8838 (bidi_cache_ensure_space): Also check that the bidi cache size
8839 does not exceed that of the largest Lisp string or buffer. See Eli
8840 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8841
5e927815
PE
8842 * alloc.c (__malloc_size_t): Remove.
8843 All uses replaced by size_t. See Andreas Schwab's note
8844 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8845
ca4aa935
PE
8846 * image.c: Improve checking for integer overflow.
8847 (check_image_size): Assume that f is nonnull, since
8848 it is always nonnull in practice. This is one less thing to
8849 worry about when checking for integer overflow later.
8850 (x_check_image_size): New function, which checks for integer
8851 overflow issues inside X.
8852 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8853 This removes the need for a memory_full check.
8854 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8855 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8856 (xbm_read_bitmap_data): Change locals back to 'int', since
8857 their values must fit in 'int'.
8858 (xpm_load_image, png_load, tiff_load):
8859 Invoke x_create_x_image_and_pixmap earlier,
8860 to avoid much needless work if the image is too large.
8861 (tiff_load): Treat overly large images as if
8862 x_create_x_image_and_pixmap failed, not as malloc failures.
8863 (gs_load): Use x_check_image_size.
8864
5f8f9cc2
PE
8865 * gtkutil.c: Omit integer casts.
8866 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8867 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8868
5adf60bc
PE
8869 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8870
c8907a93
PE
8871 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8872 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8873 would wrongly return t on a 64-bit host.
8874
e3c25c68
PE
8875 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8876 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8877 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8878 and therefore cause GCC to emit a bogus diagnostic in some cases.
8879
3f791afe
PE
8880 * image.c: Integer signedness and overflow and related fixes.
8881 This is not an exhaustive set of fixes, but it's time to
8882 record what I've got.
8883 (lookup_pixel_color, check_image_size): Remove redundant decls.
8884 (check_image_size): Don't assume that arbitrary EMACS_INT values
8885 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8886 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8887 (tiff_load, imagemagick_load_image):
8888 Check for overflow in size calculations.
8889 (x_create_x_image_and_pixmap): Remove unnecessary test for
8890 xmalloc returning NULL; that can't happen.
8891 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8892 (xpm_color_bucket): Use better integer hashing function.
8893 (xpm_cache_color): Don't possibly over-allocate memory.
8894 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8895 (gif_memory_source):
8896 Use ptrdiff_t, not int or size_t, to record sizes.
8897 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8898 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8899 either works, as we prefer signed integers.
8900 (tiff_read_from_memory, tiff_write_from_memory):
8901 Return tsize_t, not size_t, since that's what the TIFF API wants.
8902 (tiff_read_from_memory): Don't fail simply because the read would
8903 go past EOF; instead, return a short read.
8904 (tiff_load): Omit no-longer-needed casts.
8905 (Fimagemagick_types): Don't assume size fits into 'int'.
8906
3cc5a532
PE
8907 Improve hashing quality when configured --with-wide-int.
8908 * fns.c (hash_string): New function, taken from sxhash_string.
8909 Do not discard information about ASCII character case; this
8910 discarding is no longer needed.
8911 (sxhash-string): Use it. Change sig to match it. Caller changed.
8912 * lisp.h: Declare it.
8913 * lread.c (hash_string): Remove, since we now use fns.c's version.
8914 The fns.c version returns a wider integer if --with-wide-int is
8915 specified, so this should help the quality of the hashing a bit.
8916
b312a492
PE
8917 * emacs.c: Integer overflow minor fix.
8918 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8919 Define only if GNU_LINUX.
8920 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8921
dfd153ae
PE
8922 * dispnew.c: Integer signedness and overflow fixes.
8923 Remove unnecessary forward decls, that were a maintenance hassle.
8924 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8925 All uses changed.
8926 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8927 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8928 (prepare_desired_row, line_draw_cost):
8929 Use int, not unsigned, where either works.
8930 (save_current_matrix, restore_current_matrix):
8931 Use ptrdiff_t, not size_t, where either works.
8932 (init_display): Check for overflow more accurately, and without
8933 relying on undefined behavior.
8934
a81d11a3
PE
8935 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8936 Remove, replacing with the new symbols in lisp.h. All uses changed.
8937 * fileio.c (make_temp_name):
8938 * filelock.c (lock_file_1, lock_file):
8939 * xdisp.c (message_dolog):
8940 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8941 Use pMd etc. instead.
8942 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8943 replacing the pWIDE etc. symbols removed from editfns.c.
8944
3300e6fd
PE
8945 * keyboard.h (num_input_events): Now uintmax_t.
8946 This is (very slightly) less likely to mess up due to wraparound.
8947 All uses changed.
8948
fd05c7e9
PE
8949 * buffer.c: Integer signedness fixes.
8950 (alloc_buffer_text, enlarge_buffer_text):
8951 Use ptrdiff_t rather than size_t when either will do, as we prefer
8952 signed integers.
8953
903fe15d
PE
8954 * alloc.c: Integer signedness and overflow fixes.
8955 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8956 (__malloc_size_t): Default to size_t, not to int.
8957 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8958 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8959 Prefer ptrdiff_t to size_t when either would do, as we prefer
8960 signed integers.
8961 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8962 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8963 Now const. Initialize with values that are in range even if char
8964 is signed.
8965 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8966 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8967 These functions do the right thing with sizes > 2**32.
8968 (check_depth): Now ptrdiff_t, not int.
8969 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8970 Adjust to new way of storing sizes. Check for size overflow bugs
8971 in rest of code.
8972 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8973 slightly wrong anyway, as it missed one instance of
8974 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8975 (refill_memory_reserve): Omit needless cast to size_t.
8976 (mark_object_loop_halt): Mark as externally visible.
8977
ac82cc6a
PE
8978 * xselect.c: Integer signedness and overflow fixes.
8979 (Fx_register_dnd_atom, x_handle_dnd_message):
8980 Use ptrdiff_t, not size_t, since we prefer signed.
8981 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8982 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8983 x_dnd_atoms_size and x_dnd_atoms_length.
8984
c2d1e36d
PE
8985 * doprnt.c: Prefer signed to unsigned when either works.
8986 * eval.c (verror):
8987 * doprnt.c (doprnt):
8988 * lisp.h (doprnt):
8989 * xdisp.c (vmessage):
8990 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8991 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8992 prefer signed arithmetic to avoid comparison confusion.
8993 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8994 but is a bit tricky.
8995
0e926e56
PE
8996 Assume freestanding C89 headers, string.h, stdlib.h.
8997 * data.c, doprnt.c, floatfns.c, print.c:
8998 Include float.h unconditionally.
8999 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9000 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9001 * regex.c: Likewise for stddef.h, string.h.
9002 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9003 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9004 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9005 (STDC_HEADERS): Remove obsolete defines.
9006 * sysdep.c: Include limits.h unconditionally.
9007
9cfdb3ec
PE
9008 Assume support for memcmp, memcpy, memmove, memset.
9009 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9010 * regex.c (memcmp, memcpy):
9011 Remove; we assume C89 now.
9012
9013 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9014 (__malloc_safe_bcopy): Remove; no longer needed.
9015
cf950e6b 9016 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9017 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9018 well either way, and we prefer signed to unsigned.
9019
dbf38e02
LMI
90202011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9021
9022 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9023 closes the connection while we're reading (bug#9182).
9024
d6f0886c 90252011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9026
d6f0886c
JD
9027 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9028 are specified (Bug#9168).
24e0f6b1 9029
2eb1f9e6
PE
90302011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9031
9032 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9033 Found by GCC static checking and --with-wide-int on a 32-bit host.
9034
22381272 90352011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9036
9037 * xdisp.c (compute_display_string_pos): Fix logic of caching
9038 previous display string position. Initialize cached_prev_pos to
9039 -1. Fixes slow-down at the beginning of a buffer.
9040
f25e39b4
EZ
90412011-07-24 Eli Zaretskii <eliz@gnu.org>
9042
9043 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9044 for attrs[LFACE_FONTSET_INDEX].
9045
04c4b52e
PE
90462011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9047
9048 * xml.c (parse_region): Remove unused local
9049 that was recently introduced.
9050
c1734fbd
EZ
90512011-07-23 Eli Zaretskii <eliz@gnu.org>
9052
be18c5a5
EZ
9053 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9054 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9055
c1734fbd
EZ
9056 * xdisp.c (move_it_in_display_line_to): Record the best matching
9057 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9058 exit if none of the characters scanned was an exact match.
9059 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9060 when exact match is impossible due to invisible text, and the
9061 lines are truncated.
9062
a258d627
JD
90632011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9064
9065 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9066 for OSX >= 10.7.
9067
b6d5a689
EZ
90682011-07-22 Eli Zaretskii <eliz@gnu.org>
9069
0f74f785
EZ
9070 Fix a significant slow-down of cursor motion with C-n, C-p,
9071 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9072 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9073 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9074 (next_element_from_buffer): Call compute_stop_pos_backwards to
9075 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9076 base_level_stop.
9077 (reseat): Don't look for prev_stop, as that could mean a very long
9078 run.
9079 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9080 <cached_disp_overlay_modiff>: Cache for last found display string
9081 position.
551918c1 9082 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9083 about the same buffer in the same area of character positions, and
9084 the buffer wasn't changed since the time the display string
9085 position was cached.
551918c1 9086
b2d0c91a
EZ
90872011-07-22 Eli Zaretskii <eliz@gnu.org>
9088
9089 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9090 is an integer, which is important for empty lines. (Bug#9149)
9091
043604ee
CY
90922011-07-22 Chong Yidong <cyd@stupidchicken.com>
9093
9094 * frame.c (Fmodify_frame_parameters): In tty case, update the
9095 default face if necessary (Bug#4238).
9096
da4adb04
CY
90972011-07-21 Chong Yidong <cyd@stupidchicken.com>
9098
9099 * editfns.c (Fstring_to_char): No need to explain what a character
9100 is in the docstring (Bug#6576).
9101
9abd0532
LMI
91022011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9103
9104 * xml.c (parse_region): Make sure we always return a tree.
9105
36881d16
HK
91062011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9107
9108 * xml.c (parse_region): If a document contains only comments,
9109 return that, too.
9110
1e98674d
LMI
91112011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9112
9113 * xml.c (make_dom): Return comments, too.
9114
590bd467
PE
91152011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9116
9117 Port to OpenBSD.
9118 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9119 and the surrounding thread.
9120 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9121 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9122 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9123 timer goes off.
9124 * s/openbsd.h (BROKEN_SIGIO): Define.
9125 * unexelf.c (unexec) [__OpenBSD__]:
9126 Don't update the .mdebug section of the Alpha COFF symbol table.
9127
f41628b2
LMI
91282011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9129
9130 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9131 (bug#8460).
9132
b59b67c5
PE
91332011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9134
15e3a074
PE
9135 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9136 This fixes some race conditions on the permissions of any newly
9137 created file.
9138
41bed37d
PE
9139 * alloc.c (valid_pointer_p): Use pipe, not open.
9140 This fixes some permissions issues when debugging.
9141
b59b67c5
PE
9142 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9143 If fchown fails to set both uid and gid, try to set just gid,
9144 as that is sometimes allowed. Adjust the file's mode to eliminate
9145 setuid or setgid bits that are inappropriate if fchown fails.
9146
925a6be7
SM
91472011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9148
9149 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9150 to compare Lisp_Objects.
9151 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9152 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9153 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9154
52968808
AS
91552011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9156
0a6a104b
AS
9157 * lread.c (read_integer): Unread even EOF character.
9158 (read1): Likewise. Properly record start position of symbol.
9159
52968808
AS
9160 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9161 symbol character follows.
9162
9e381cdd
PE
91632011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9164
9165 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9166 This works around a problem with the previous change to Fcopy_file.
9167 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9168 and without this change, GCC might complain about discarding
9169 fchown's return value.
9170
b5641435
JB
91712011-07-16 Juanma Barranquero <lekktu@gmail.com>
9172
9173 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9174
a8031457
PE
91752011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9176
9177 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9178
dd889327
LMI
91792011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9180
750c33f7
LMI
9181 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9182 it's used from the C level.
9183
dd889327
LMI
9184 * process.c: Use the same condition for POLL_FOR_INPUT in both
9185 keyboard.c and process.c (bug#1858).
9186
87e86684
LM
91872011-07-09 Lawrence Mitchell <wence@gmx.li>
9188
9189 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9190 (Fgnutls_boot): Use it.
9191
64348f40
AS
91922011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9193
9194 * doc.c (Fsubstitute_command_keys): Revert last change.
9195
1d698799
LMI
91962011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9197
f863868c
LMI
9198 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9199 quotes the next character, and doesn't affect other longer
9200 sequences (bug#8935).
9201
1d698799
LMI
9202 * lread.c (syms_of_lread): Clarify that is isn't only
9203 `eval-buffer' and `eval-defun' that's affected by
9204 `lexical-binding' (bug#8460).
9205
aa4b6df6
EZ
92062011-07-15 Eli Zaretskii <eliz@gnu.org>
9207
9208 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9209 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9210
5d856da6
PE
92112011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9212
ad6042bb
PE
9213 Fix minor problems found by static checking.
9214 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9215 (elsz): Now a signed constant, not a size_t var. We prefer signed
9216 types to unsigned, to avoid integer comparison confusion. Without
9217 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9218 "cannot optimize loop, the loop counter may overflow", a symptom
9219 of the confusion.
f00bbb22 9220 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9221 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9222
6468f31c
LMI
92232011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9224
49080b10
LMI
9225 * search.c (Fre_search_backward): Mention `case-fold-search' in
9226 all the re_search_* functions (bug#8138).
9227
6468f31c
LMI
9228 * keyboard.c (Fopen_dribble_file): Document when the file is
9229 closed (bug#8056).
9230
c965adc5
EZ
92312011-07-14 Eli Zaretskii <eliz@gnu.org>
9232
df9733bf
EZ
9233 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9234 bidi_cache_idx.
9235
0bb23927
EZ
9236 Support bidi reordering of display and overlay strings.
9237 * xdisp.c (compute_display_string_pos)
9238 (compute_display_string_end): Accept additional argument STRING.
9239 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9240 (reseat_to_string): Initialize bidi_it->string.s and
9241 bidi_it->string.schars.
9242 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9243 NULL (avoids a crash in bidi_paragraph_init).
9244 Initialize itb.string.lstring.
0bb23927
EZ
9245 (init_iterator): Call bidi_init_it only of a valid
9246 buffer position was specified. Initialize paragraph_embedding to
9247 L2R.
9248 (reseat_to_string): Initialize the bidi iterator.
9249 (display_string): If we need to ignore text properties of
9250 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9251 original value of -1 will not work with bidi.)
9252 (compute_display_string_pos): First arg is now struct
9253 `text_pos *'; all callers changed. Support display properties on
9254 Lisp strings.
9255 (compute_display_string_end): Support display properties on Lisp
9256 strings.
9257 (init_iterator, reseat_1, reseat_to_string): Initialize the
9258 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9259 when iterating on a string not from display properties).
640c8776
SM
9260 (compute_display_string_pos, compute_display_string_end):
9261 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9262 arrow keys.
9263 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9264 base_level_stop; instead, set base_level_stop to BEGV.
9265 Fixes crashes in vertical-motion.
0bb23927
EZ
9266 (next_element_from_buffer): Improve commentary for when
9267 the iterator is before prev_stop.
9268 (init_iterator): Initialize bidi_p from the default value of
9269 bidi-display-reordering, not from buffer-local value. Use the
9270 buffer-local value only if initializing for buffer iteration.
9271 (handle_invisible_prop): Support invisible properties on strings
9272 that are being bidi-reordered.
9273 (set_iterator_to_next): Support bidi reordering of C strings and
9274 Lisp strings.
9275 (next_element_from_string): Support bidi reordering of Lisp
9276 strings.
9277 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9278 (display_string): Support display of R2L glyph rows.
9279 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9280 (init_iterator): Don't initialize it->bidi_p for strings
9281 here.
9282 (reseat_to_string): Initialize it->bidi_p for strings here.
9283 (next_element_from_string, next_element_from_c_string)
9284 (next_element_from_buffer): Add xassert's for correspondence
9285 between IT's object being iterated and it->bidi_it.string
9286 structure.
9287 (face_before_or_after_it_pos): Support bidi iteration.
9288 (next_element_from_c_string): Handle the case of the first string
9289 character that is not the first one in the visual order.
9290 (get_visually_first_element): New function, refactored from common
9291 parts of next_element_from_buffer, next_element_from_string, and
9292 next_element_from_c_string.
9293 (tool_bar_lines_needed, redisplay_tool_bar)
9294 (display_menu_bar): Force left-to-right direction. Add a FIXME
9295 comment for making that be controlled by a user option.
9296 (push_it, pop_it): Save and restore the state of the
9297 bidi iterator. Save and restore the bidi_p flag.
9298 (pop_it): Iterate out of display property for string iteration as
9299 well.
9300 (iterate_out_of_display_property): Support iteration over strings.
9301 (handle_single_display_spec): Set up it->bidi_it for iteration
9302 over a display string, and call bidi_init_it.
9303 (handle_single_display_spec, next_overlay_string)
9304 (get_overlay_strings_1, push_display_prop): Set up the bidi
9305 iterator for displaying display or overlay strings.
9306 (forward_to_next_line_start): Don't use the shortcut if
9307 bidi-iterating.
9308 (back_to_previous_visible_line_start): If handle_display_prop
9309 pushed the iterator stack, restore the internal state of the bidi
9310 iterator by calling bidi_pop_it same number of times.
9311 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9312 and we are bidi-iterating, don't decrement the iterator position;
9313 instead, set the first_elt flag in the bidi iterator, to produce
9314 the same effect.
9315 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9316 (push_display_prop): xassert that we are iterating a buffer.
9317 (push_it, pop_it): Save and restore paragraph_embedding member.
9318 (handle_single_display_spec, next_overlay_string)
9319 (get_overlay_strings_1, reseat_1, reseat_to_string)
9320 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9321 correctly. Don't assume unibyte strings are not bidi-reordered.
9322 (compute_display_string_pos)
9323 (compute_display_string_end): Fix handling the case of C string.
9324 (push_it, pop_it): Save and restore from_disp_prop_p.
9325 (handle_single_display_spec, push_display_prop): Set the
9326 from_disp_prop_p flag.
9327 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9328 (pop_it): Call iterate_out_of_display_property only if we are
9329 popping after iteration over a string that came from a display
9330 property. Fix a typo in popping stretch info. Add an assertion
9331 for verifying that the iterator position is in sync with the bidi
9332 iterator.
9333 (handle_single_display_spec, get_overlay_strings_1)
9334 (push_display_prop): Fix initialization of paragraph direction for
9335 string when that of the parent object is not yet determined.
9336 (reseat_1): Call bidi_init_it to resync the bidi
9337 iterator with IT's position. (Bug#7616)
9338 (find_row_edges): If ROW->start.pos gives position
9339 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9340 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9341 Reset the from_disp_prop_p flag.
9342 (SAVE_IT, RESTORE_IT): New macros.
9343 (pos_visible_p, face_before_or_after_it_pos)
9344 (back_to_previous_visible_line_start)
9345 (move_it_in_display_line_to, move_it_in_display_line)
9346 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9347 (try_scrolling, redisplay_window, display_line): Use them when
9348 saving a temporary copy of the iterator and restoring it back.
9349 (back_to_previous_visible_line_start, reseat_1)
9350 (init_iterator): Empty the bidi cache "stack".
9351 (move_it_in_display_line_to): If iterator ended up at
9352 EOL, but we never saw any buffer positions smaller than
9353 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9354 motion in bidi-reordered lines.
9355 (move_it_in_display_line_to): Record prev_method and prev_pos
9356 immediately before the call to set_iterator_to_next. Fixes cursor
9357 motion in bidi-reordered lines with stretch glyphs and strings
9358 displayed in margins. (Bug#8133) (Bug#8867)
9359 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9360 TO_CHARPOS.
640c8776
SM
9361 (pos_visible_p): Support positions in bidi-reordered lines.
9362 Save and restore bidi cache.
0bb23927
EZ
9363
9364 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9365 (bidi_paragraph_info): Delete unused struct.
9366 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9367 (bidi_cache_start): New variable.
9368 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9369 to zero.
9370 (bidi_cache_fetch_state, bidi_cache_search)
9371 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9372 (bidi_cache_find, bidi_peek_at_next_level)
9373 (bidi_level_of_next_char, bidi_find_other_level_edge)
9374 (bidi_move_to_visually_next): Compare cache index with
9375 bidi_cache_start rather than with zero.
9376 (bidi_fetch_char): Accept new argument STRING; all callers
9377 changed. Support iteration over a string. Support strings with
9378 display properties. Support unibyte strings. Fix the type of
9379 `len' according to what STRING_CHAR_AND_LENGTH expects.
9380 (bidi_paragraph_init, bidi_resolve_explicit_1)
9381 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9382 (bidi_level_of_next_char, bidi_move_to_visually_next):
9383 Support iteration over a string.
0bb23927
EZ
9384 (bidi_set_sor_type, bidi_resolve_explicit_1)
9385 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9386 can now be zero (for strings); special values 0 and -1 were
9387 changed to -1 and -2, respectively.
9388 (bidi_char_at_pos): New function.
9389 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9390 Call it instead of FETCH_MULTIBYTE_CHAR.
9391 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9392 initialized to valid values.
9393 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9394 values.
9395 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9396 the test for valid cached positions. Fix the logic for looking up
9397 the sentinel state in the cache. GCPRO the Lisp string we are
9398 iterating.
9399 (bidi_push_it, bidi_pop_it): New functions.
9400 (bidi_initialize): Initialize the bidi cache start stack pointer.
9401 (bidi_cache_ensure_space): New function, refactored from part of
9402 bidi_cache_iterator_state. Don't assume the required size is just
9403 one BIDI_CACHE_CHUNK away.
9404 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9405 (bidi_count_bytes, bidi_char_at_pos): New functions.
9406 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9407 always valid if bidi_cache_idx is valid.
9408 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9409 is valid if it's going to be used.
9410 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9411 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9412 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9413 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9414 (bidi_find_other_level_edge, bidi_cache_start_stack):
9415 All variables related to cache indices are now EMACS_INT.
c965adc5 9416
0bb23927
EZ
9417 * dispextern.h (struct bidi_string_data): New structure.
9418 (struct bidi_it): New member `string'. Make flag members be 1-bit
9419 fields, and put them last in the struct.
640c8776
SM
9420 (compute_display_string_pos, compute_display_string_end):
9421 Update prototypes.
0bb23927
EZ
9422 (bidi_push_it, bidi_pop_it): Add prototypes.
9423 (struct iterator_stack_entry): New members bidi_p,
9424 paragraph_embedding, and from_disp_prop_p.
9425 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9426 (bidi_shelve_cache, bidi_unshelve_cache):
9427 Declare prototypes.
0bb23927
EZ
9428
9429 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9430 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9431 and vector-like objects.
9432
9433 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9434 cache around display iteration.
9435
9436 * window.c (Fwindow_end, window_scroll_pixel_based)
9437 (displayed_window_lines, Frecenter): Save and restore the bidi
9438 cache around display iteration.
9439
3bbd2265
LMI
94402011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9441
9442 * editfns.c (Fdelete_region): Clarify the use of the named
9443 parameters (bug#6788).
9444
adc47434
MR
94452011-07-14 Martin Rudalics <rudalics@gmx.at>
9446
9447 * indent.c (Fvertical_motion): Set and restore w->pointm when
9448 saving and restoring the window's buffer (Bug#9006).
9449
837c31f8
LMI
94502011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9451
9452 * editfns.c (Fstring_to_char): Clarify just what is returned
9453 (bug#6576). Text by Eli Zaretskii.
9454
ac389d0c
JB
94552011-07-13 Juanma Barranquero <lekktu@gmail.com>
9456
9457 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9458
0be0ce47
EZ
94592011-07-13 Eli Zaretskii <eliz@gnu.org>
9460
9461 * buffer.c (mmap_find): Fix a typo.
9462
cd18e7e3
JB
94632011-07-13 Johan Bockgård <bojohan@gnu.org>
9464
9465 Fix execution of x selection hooks.
9466 * xselect.c (Qx_lost_selection_functions)
9467 (Qx_sent_selection_functions): New vars.
9468 (syms_of_xselect): DEFSYM them.
9469 (x_handle_selection_request): Pass Qx_sent_selection_functions
9470 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9471 (x_handle_selection_clear,x_clear_frame_selections):
9472 Pass Qx_lost_selection_functions rather than
9473 Vx_lost_selection_functions to Frun_hook_with_args.
9474
47ea7f44
PE
94752011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9476
ac389d0c 9477 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9478 The old code sometimes used this field without initializing it.
9479
47ea7f44
PE
9480 * alloc.c (gc_sweep): Don't read past end of array.
9481 In theory, the old code could also have corrupted Emacs internals,
9482 though it'd be very unlikely.
9483
bc985c87
AS
94842011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9485
9486 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9487 argument. (Bug#4026)
bc985c87 9488
0cf34688
LMI
94892011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9490
b3dadd76
LMI
9491 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9492 key" (bug#4257).
9493
0cf34688
LMI
9494 * window.c (Fset_window_start): Doc fix (bug#4199).
9495 (Fset_window_hscroll): Ditto.
9496
270768cd
PE
94972011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9498
077e3dda 9499 Fix minor new problems caught by GCC 4.6.1.
270768cd 9500 * term.c (init_tty): Remove unused local.
490011a6 9501 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9502 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9503 not used otherwise.
270768cd 9504
b1f58454
CY
95052011-07-12 Chong Yidong <cyd@stupidchicken.com>
9506
9507 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9508
22b9578d
LMI
95092011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9510
6e70ab07
LMI
9511 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9512 are the mini-buffer and the echo area (bug#3320).
9513
22b9578d
LMI
9514 * term.c (init_tty): Remove support for supdup, c10 and perq
9515 terminals, which are no longer supported (bug#1482).
9516
8974cc9f
JB
95172011-07-10 Johan Bockgård <bojohan@gnu.org>
9518
9519 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9520
a560d974
JD
95212011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9522
9523 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9524 for non-popups (Bug#3642).
9525
1dae0f0a
AS
95262011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9527
268c2c36 9528 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9529 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9530 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9531 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9532 * data.c (fmod): Likewise.
9533 * dispnew.c (swap_glyphs_in_rows): Likewise.
9534 * emacs.c (memory_warning_signal): Likewise.
9535 * floatfns.c (float_error): Likewise.
9536 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9537 (otf_open, font_otf_capability, generate_otf_features)
9538 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9539 Likewise.
9540 * image.c (pbm_read_file): Likewise.
9541 * indent.c (string_display_width): Likewise.
9542 * intervals.c (check_for_interval, search_for_interval)
9543 (inc_interval_count, count_intervals, root_interval)
9544 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9545 * lread.c (defalias): Likewise.
268c2c36 9546 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9547 * regex.c (set_image_of_range_1, set_image_of_range)
9548 (regex_grow_registers): Likewise.
9549 * sysdep.c (strerror): Likewise.
9550 * termcap.c (valid_filename_p, tprint, main): Likewise.
9551 * tparam.c (main): Likewise.
9552 * unexhp9k800.c (run_time_remap, save_data_space)
9553 (update_file_ptrs, read_header, write_header, calculate_checksum)
9554 (copy_file, copy_rest, display_header): Likewise.
9555 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9556 Likewise.
9557 * xdisp.c (check_it): Likewise.
9558 * xfaces.c (register_color, unregister_color, unregister_colors):
9559 Likewise.
9560 * xfns.c (print_fontset_result): Likewise.
9561 * xrdb.c (member, fatal, main): Likewise.
9562
99033785
PE
95632011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9564
9565 Fix minor problems found by static checking (Bug#9031).
9566 * chartab.c (char_table_set_range, map_sub_char_table):
9567 Remove unused locals.
9568 (uniprop_table): Now static.
9569 * composite.c (_work_char): Remove unused static var.
9570
9cb2ac56
JB
95712011-07-09 Juanma Barranquero <lekktu@gmail.com>
9572
9573 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9574
f25661f0
JD
95752011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9576
9577 * gtkutil.c (qttip_cb): Remove code without function.
9578
8278c4fe
EZ
95792011-07-09 Eli Zaretskii <eliz@gnu.org>
9580
9581 * w32.c (pthread_sigmask): New stub.
9582
1692ae2d 95832011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9584
8a6ebd58 9585 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9586 sigprocmask is portable only for single-threaded applications, and
9587 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9588 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9589 (LIBES): Use it.
9590 * callproc.c (Fcall_process):
9591 * process.c (create_process):
9592 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9593 Use pthread_sigmask, not sigprocmask.
123403e4 9594
1b854618
JD
95952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9596
9597 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9598 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9599 wrong (Bug#8591).
9600
3fe4b549
JD
96012011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9602
0ce7e563
JD
9603 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9604 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9605 (xg_hide_tooltip): Fix comment.
9606
3fe4b549
JD
9607 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9608 in registerServicesMenuSendTypes.
9609 (validRequestorForSendType): Don't check ns_return_types.
9610
9611 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9612 ns_return_type.
9613
5df75e47
JR
96142011-07-08 Jason Rumney <jasonr@gnu.org>
9615
22610910
JR
9616 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9617 SH_SHOW for hidden windows (Bug#5482).
9618
5df75e47
JR
9619 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9620 frame struct members of non-existent frames (Bug#6284).
9621
699c10bd
JD
96222011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9623
4393663b
JD
9624 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9625 variable firstTime not needed on OSX >= 10.6.
9626 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9627 >= 10.5. Use setKnobProportion, setDoubleValue.
9628
9629 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9630 (MAC_OS_X_VERSION_10_5): Define if not defined.
9631 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9632 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9633 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9634
9635 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9636 cString and lossyCString on OSX >= 10.4.
4393663b 9637
58179cce 9638 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9639 sizeToFit on OSX >= 10.2.
9640
9641 * nsimage.m (allocInitFromFile): Don't use deprecated method
9642 bestRepresentationForDevice on OSX >= 10.6.
9643
9644 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9645 to avoid warning.
9646
9647 * emacs.c: Declare unexec_init_emacs_zone.
9648
a63e0781
JD
9649 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9650
699c10bd
JD
9651 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9652
9653 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9654 on svcsMenu (Bug#8842).
9655
9656 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9657 ns_return_types.
9658 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9659
9660 * nsterm.m (QUTF8_STRING): Declare.
9661 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9662 (validRequestorForSendType): Return type is (id).
9663 Change indexOfObjectIdenticalTo to indexOfObject.
9664 Check if we have local selection before returning self (Bug#8842).
9665 (writeSelectionToPasteboard): Put local selection into paste board
9666 if we have a local selection (Bug#8842).
9667 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9668
9669 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9670 (ns_get_local_selection): Declare.
9671
54e10184
LMI
96722011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9673
9888ff71
LMI
9674 * keymap.c (describe_map_tree): Don't insert a double newline at
9675 the end of the buffer (bug#1169) and return whether we inserted
9676 something.
9677
54e10184
LMI
9678 * callint.c (Fcall_interactively): Change "reading args" to
9679 "providing args" to try to clarify what it does (bug#1010).
9680
15fa4783
KH
96812011-07-07 Kenichi Handa <handa@m17n.org>
9682
9683 * composite.c (composition_compute_stop_pos): Ignore a static
9684 composition starting before CHARPOS (Bug#8915).
9685
9686 * xdisp.c (handle_composition_prop): Likewise.
9687
a8815b00
EZ
96882011-07-07 Eli Zaretskii <eliz@gnu.org>
9689
9690 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9691 (Bug#9015)
9692
ef7b981d 96932011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9694
9695 * character.h (unicode_category_t): New enum type.
9696
9697 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9698 (Qchar_code_property_table): New variable.
9699 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9700 (UNIPROP_COMPRESSED_FORM_P): New macros.
9701 (char_table_ascii): Uncompress the compressed values.
9702 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9703 Uncompress the compressed values.
ac389d0c 9704 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9705 (char_table_ref_and_range): Uncompress the compressed values.
9706 (sub_char_table_set): New arg is_uniprop. Callers changed.
9707 Uncompress the compressed values.
9708 (sub_char_table_set_range): Args changed. Callers changed.
9709 (char_table_set_range): Adjuted for the above change.
9710 (map_sub_char_table): Delete args default_val and parent. Add arg
9711 top. Give decoded values to a Lisp function.
640c8776 9712 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9713 values to a Lisp function. Gcpro more variables.
9714 (uniprop_table_uncompress)
9715 (uniprop_decode_value_run_length): New functions.
9716 (uniprop_decoder, uniprop_decoder_count): New variables.
9717 (uniprop_get_decoder, uniprop_encode_value_character)
9718 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9719 New functions.
9720 (uniprop_encoder, uniprop_encoder_count): New variables.
9721 (uniprop_get_encoder, uniprop_table)
9722 (Funicode_property_table_internal, Fget_unicode_property_internal)
9723 (Fput_unicode_property_internal): New functions.
9724 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9725 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9726 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9727 char-code-property-alist.
9728
640c8776 9729 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9730 Vunicode_category_table.
9731
640c8776 9732 * font.c (font_range): Adjust for the change of
c805dec0
KH
9733 Vunicode_category_table.
9734
76b397fb
DN
97352011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9736
9737 * m/iris4d.h: Remove file, move contents ...
9738 * s/irix6-5.h: ... here.
9739
22b4128e
PE
97402011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9741
9742 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9743 * alloc.c (mark_buffer):
9744 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9745 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9746 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9747 This isn't true in general, and it's particularly not true
9748 if Emacs is configured with --with-wide-int.
9749 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9750 New macros, used in the buffer.c change.
9751
869795d6
JD
97522011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9753
9754 * xsettings.c: Use both GConf and GSettings if both are available.
9755 (store_config_changed_event): Add comment.
9756 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9757 (store_tool_bar_style_changed): New functions.
5e617bc2 9758 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9759 (struct xsettings): Move font inside HAVE_XFT.
9760 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9761 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9762 Move inside HAVE_XFT.
640c8776 9763 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9764 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9765 also.
9766 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9767 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9768 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9769 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9770 (parse_settings): Move check for font inside HAVE_XFT.
9771 (read_settings, apply_xft_settings): Add comment.
9772 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9773 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9774 call store_font_name_changed.
9775 (xft_settings_event): Add comment.
9776 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9777 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9778 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9779 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9780 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9781 (xsettings_get_system_font, xsettings_get_system_normal_font):
9782 Add comment.
869795d6 9783
d8ed26bd
PE
97842011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9785
9786 Random fixes. E.g., (random) never returned negative values.
9787 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9788 subseconds part to the entropy, as that's a bit more random.
9789 Prefer signed to unsigned, since the signedness doesn't matter and
9790 in general we prefer signed. When given a limit, use a
9791 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9792 latter isn't right if USE_2_TAGS_FOR_INTS.
9793 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9794 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9795
cabf1cac
SM
97962011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9797
9798 * textprop.c (text_property_stickiness):
9799 Obey Vtext_property_default_nonsticky.
9800 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9801 * w32fns.c (syms_of_w32fns):
9802 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9803
6e9b2be9
PE
98042011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9805
9806 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9807 This is more efficient than Ffile_directory_p and avoids a minor race.
9808
90186c68
LMI
98092011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9810
7c301272
LMI
9811 * buffer.c (Foverlay_put): Say what the return value is
9812 (bug#7835).
9813
c4f2d8d4
LMI
9814 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9815 is a directory before asking whether to use the file name
9816 (bug#7564).
ad637907
LMI
9817 (barf_or_query_if_file_exists): Make the "File is a directory"
9818 error be more correct.
c4f2d8d4 9819
90186c68
LMI
9820 * fns.c (Frequire): Remove the mention of the .gz files, since
9821 that's installation-specific, but keep the mention of
9822 `get-load-suffixes'.
9823
da64016e
PE
98242011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9825
9826 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9827 Report string overflow if the output is too long.
9828
7d47b580
JB
98292011-07-04 Juanma Barranquero <lekktu@gmail.com>
9830
a555cb87
JB
9831 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9832 (syms_of_gnutls): Remove duplicate DEFSYM for
9833 Qgnutls_bootprop_verify_hostname_error, an error for
9834 Qgnutls_bootprop_verify_error (which is no longer used).
9835
7d47b580
JB
9836 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9837 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9838 Also (re)move comments that are misplaced or no longer relevant.
9839
1e49bfab
LMI
98402011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9841
9842 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9843
1485f4c0
CY
98442011-07-03 Chong Yidong <cyd@stupidchicken.com>
9845
9846 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9847 and background color parameters if they have been changed.
9848
a9ab721e
LMI
98492011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9850
9851 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9852
cf7cff57
PE
98532011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9854
2e13213d
PE
9855 * xsettings.c (SYSTEM_FONT): Define only when used.
9856 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9857
cf7cff57
PE
9858 * keymap.c (access_keymap_1): Now static.
9859
7a8e04f7
CY
98602011-07-02 Chong Yidong <cyd@stupidchicken.com>
9861
9862 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9863 leave any prefix arg for the up event (Bug#1586).
9864
61352f62
LMI
98652011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9866
69bb1ef7
LMI
9867 * lread.c (syms_of_lread): Mention single symbols defined by
9868 `defvar' or `defconst' (bug#7154).
9869
61352f62 9870 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9871 (Frequire): Mention get-load-suffixes.
61352f62 9872
28545e04
MR
98732011-07-02 Martin Rudalics <rudalics@gmx.at>
9874
9875 * window.h (window): Remove clone_number slot.
9876 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9877 Remove.
9878 (make_parent_window, make_window, saved_window)
9879 (Fset_window_configuration, save_window_save): Don't deal with
9880 clone numbers.
9881 * buffer.c (Qclone_number): Remove declaration.
9882 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9883
3349e122
SM
98842011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9885
9886 Add multiple inheritance to keymaps.
9887 * keymap.c (Fmake_composed_keymap): New function.
9888 (Fset_keymap_parent): Simplify.
9889 (fix_submap_inheritance): Remove.
9890 (access_keymap_1): New function extracted from access_keymap to handle
9891 embedded parents and handle lists of maps.
9892 (access_keymap): Use it.
9893 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9894 (Fcopy_keymap): Handle embedded parents.
9895 (Fcommand_remapping, define_as_prefix): Simplify.
9896 (Fkey_binding): Simplify.
9897 (syms_of_keymap): Move minibuffer-local-completion-map,
9898 minibuffer-local-filename-completion-map,
9899 minibuffer-local-must-match-map, and
9900 minibuffer-local-filename-must-match-map to Elisp.
9901 (syms_of_keymap): Defsubr make-composed-keymap.
9902 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9903 (parse_menu_item): Trivial simplification.
9904
3279eb87
GM
99052011-07-01 Glenn Morris <rgm@gnu.org>
9906
9907 * Makefile.in (SETTINGS_LIBS): Fix typo.
9908
4550efdf
KI
99092011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9910
9911 * coding.c (Fencode_coding_string): Record the last coding system
9912 used, as the function doc string says (bug#8738).
9913
0949d2b6
JD
99142011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9915
9916 * xsettings.c (store_monospaced_changed): Take new font as arg and
9917 check for change against current_mono_font.
9918 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9919 (emacs_settings_constructor, emacs_settings_get_property)
9920 (emacs_settings_set_property, emacs_settings_class_init)
9921 (emacs_settings_init, gsettings_obj): Remove.
9922 (something_changedCB): New function for HAVE_GSETTINGS.
9923 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9924 with value as argument.
9925 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9926 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9927 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9928 "changed".
9929
9930 * xgselect.c: Add defined (HAVE_GSETTINGS).
9931 (xgselect_initialize): Ditto.
9932
9933 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9934 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9935 xg_select.
9936
bbc6b304
PE
99372011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9938
9939 * eval.c (struct backtrace): Simplify and port the data structure.
9940 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9941 signed bit field, as this assumption is not portable and it makes
9942 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9943 "char debug_on_exit : 1" as this is not portable either; instead,
9944 use the portable "unsigned int debug_on_exit : 1". Remove unused
9945 member evalargs. Remove obsolete comments about cc bombing out.
9946
9851bfc5
JD
99472011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9948
51bb811f 9949 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9950 Let HAVE_GSETTINGS override HAVE_GCONF.
9951 (store_monospaced_changed): New function.
9952 (EMACS_SETTINGS): A new type derived from GObject to handle
9953 GSettings notifications.
9954 (emacs_settings_constructor, emacs_settings_get_property)
9955 (emacs_settings_set_property, emacs_settings_class_init):
9956 New functions.
9957 (gsettings_client, gsettings_obj): New variables.
9958 (GSETTINGS_SCHEMA): New define.
9959 (something_changedCB): Call store_monospaced_changed.
9960 (init_gsettings): New function.
9961 (xsettings_initialize): Call init_gsettings.
9962 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9963 to NULL.
9964
640c8776 9965 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9966 GCONF_CFLAGS/LIBS.
9967
5386012d
MR
99682011-06-29 Martin Rudalics <rudalics@gmx.at>
9969
9970 * window.c (resize_root_window, grow_mini_window)
9971 (shrink_mini_window): Rename Qresize_root_window to
9972 Qwindow_resize_root_window and Qresize_root_window_vertically to
9973 Qwindow_resize_root_window_vertically.
9974
f13e0b08
PE
99752011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9976
9977 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9978
94515237
JB
99792011-06-27 Juanma Barranquero <lekktu@gmail.com>
9980
9981 * makefile.w32-in: Redesign dependencies so they reflect more
9982 clearly which files are directly included by each source file,
9983 and not through other includes.
9984
e43b6e43
MR
99852011-06-27 Martin Rudalics <rudalics@gmx.at>
9986
9987 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9988 (sort_overlays, overlay_strings): When an overlay's clone number
9989 matches the window's clone number process the overlay even if
9990 the overlay's window property doesn't match the current window.
9991
d68443dc
MR
9992 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9993 (Fwindow_hchild): Rename to Fwindow_left_child.
9994 (Fwindow_next): Rename to Fwindow_next_sibling.
9995 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9996 (resize_window_check): Rename to window_resize_check.
9997 (resize_window_apply): Rename to window_resize_apply.
9998 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9999 (Fdelete_other_windows_internal, resize_frame_windows)
10000 (Fsplit_window_internal, Fdelete_window_internal)
10001 (grow_mini_window, shrink_mini_window)
10002 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10003
c7e73be5
JD
100042011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10005
10006 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10007 (emacs_fixed_set_min_size): Remove.
10008 (emacs_fixed_new): Take frame as argument.
10009
10010 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10011 (_EmacsFixedPrivate): Remove minwidth/height.
10012 Add struct frame *f.
10013 (emacs_fixed_init): Initialize priv->f.
10014 (get_parent_class, emacs_fixed_set_min_size): Remove.
10015 (emacs_fixed_new): Set priv->f to argument.
10016 (emacs_fixed_get_preferred_width)
10017 (emacs_fixed_get_preferred_height): Use min_width/height from
10018 frames size_hint to set minimum and natural (Bug#8919).
10019 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10020 and use min_width/height from frames size_hint to set
10021 min_width/height (Bug#8919).
10022
10023 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10024 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10025 Fix indentation.
c7e73be5 10026
cf99dcf8
EZ
100272011-06-26 Eli Zaretskii <eliz@gnu.org>
10028
10029 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10030 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10031 called at ZV.
10032
029529ac
CY
100332011-06-26 Chong Yidong <cyd@stupidchicken.com>
10034
10035 * process.c (wait_reading_process_output): Bypass select if
10036 waiting for a cell while ignoring keyboard input, and input is
10037 pending. Suggested by Jan Djärv (Bug#8869).
10038
7a7ef429
PE
100392011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10040
10041 Use gnulib's dup2 module instead of rolling our own.
10042 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10043
11fdef7d 100442011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10045
10046 * dispnew.c (scrolling_window): Before scrolling, turn off a
10047 mouse-highlight in the window being scrolled.
10048
cd3520a4
JB
100492011-06-24 Juanma Barranquero <lekktu@gmail.com>
10050
10051 Move DEFSYM to lisp.h and use everywhere.
10052
10053 * character.h (DEFSYM): Move declaration...
10054 * lisp.h (DEFSYM): ...here.
10055
10056 * gnutls.c:
10057 * minibuf.c:
10058 * w32menu.c:
10059 * w32proc.c:
10060 * w32select.c: Don't include character.h.
10061
10062 * alloc.c (syms_of_alloc):
10063 * buffer.c (syms_of_buffer):
10064 * bytecode.c (syms_of_bytecode):
10065 * callint.c (syms_of_callint):
10066 * casefiddle.c (syms_of_casefiddle):
10067 * casetab.c (init_casetab_once):
10068 * category.c (init_category_once, syms_of_category):
10069 * ccl.c (syms_of_ccl):
10070 * cmds.c (syms_of_cmds):
10071 * composite.c (syms_of_composite):
10072 * dbusbind.c (syms_of_dbusbind):
10073 * dired.c (syms_of_dired):
10074 * dispnew.c (syms_of_display):
10075 * doc.c (syms_of_doc):
10076 * editfns.c (syms_of_editfns):
10077 * emacs.c (syms_of_emacs):
10078 * eval.c (syms_of_eval):
10079 * fileio.c (syms_of_fileio):
10080 * fns.c (syms_of_fns):
10081 * frame.c (syms_of_frame):
10082 * fringe.c (syms_of_fringe):
10083 * insdel.c (syms_of_insdel):
10084 * keymap.c (syms_of_keymap):
10085 * lread.c (init_obarray, syms_of_lread):
10086 * macros.c (syms_of_macros):
10087 * msdos.c (syms_of_msdos):
10088 * print.c (syms_of_print):
10089 * process.c (syms_of_process):
10090 * search.c (syms_of_search):
10091 * sound.c (syms_of_sound):
10092 * syntax.c (init_syntax_once, syms_of_syntax):
10093 * terminal.c (syms_of_terminal):
10094 * textprop.c (syms_of_textprop):
10095 * undo.c (syms_of_undo):
10096 * w32.c (globals_of_w32):
10097 * window.c (syms_of_window):
10098 * xdisp.c (syms_of_xdisp):
10099 * xfaces.c (syms_of_xfaces):
10100 * xfns.c (syms_of_xfns):
10101 * xmenu.c (syms_of_xmenu):
10102 * xsettings.c (syms_of_xsettings):
10103 * xterm.c (syms_of_xterm): Use DEFSYM.
10104
4228cf16
TZ
101052011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10106
cd3520a4 10107 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10108
7fcccf1e
PE
101092011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10110
7efb4e0e
PE
10111 Integer and buffer overflow fixes (Bug#8873).
10112
ff5844ad
PE
10113 * print.c (printchar, strout): Check for string overflow.
10114 (PRINTPREPARE, printchar, strout):
10115 Don't set size unless allocation succeeds.
10116
90532f02
PE
10117 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10118 for sizes. Check for string overflow more accurately.
10119 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10120
6d84508d
PE
10121 * macros.c: Integer and buffer overflow fixes.
10122 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10123 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10124 Use ptrdiff_t, not int, for sizes.
10125 Don't increment bufsize until after realloc succeeds.
10126 Check for size-calculation overflow.
10127 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10128
437b2cb4
PE
10129 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10130
8b9ac8b4
PE
10131 * lread.c: Integer overflow fixes.
10132 (read_integer): Radix is now EMACS_INT, not int,
10133 to improve quality of diagnostics for out-of-range radices.
10134 Calculate buffer size correctly for out-of-range radices.
10135 (read1): Check for integer overflow in radices, and in
10136 read-circle numbers.
82cb60d3
PE
10137 (read_escape): Avoid int overflow.
10138 (Fload, openp, read_buffer_size, read1)
10139 (substitute_object_recurse, read_vector, read_list, map_obarray):
10140 Use ptrdiff_t, not int, for sizes.
10141 (read1): Use EMACS_INT, not int, for sizes.
20270765 10142 Check for size overflow.
8b9ac8b4 10143
7fcccf1e
PE
10144 * image.c (cache_image): Check for size arithmetic overflow.
10145
bfbbd7e7
PE
10146 * lread.c: Integer overflow issues.
10147 (saved_doc_string_size, saved_doc_string_length)
10148 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10149 Now ptrdiff_t, not int.
10150 (read1): Don't assume doc string length fits in int. Check for
10151 out-of-range doc string lengths.
10152 (read_list): Don't assume file position fits in int.
39019e54 10153 (read_escape): Check for hex character overflow.
bfbbd7e7 10154
4e323265
LL
101552011-06-22 Leo Liu <sdl.web@gmail.com>
10156
10157 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10158 Move to minibuffer.el.
10159
85fece3e
PE
101602011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10161
20b84ce9 10162 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10163 The following patches are for when GLYPH_DEBUG && !XASSERT.
10164 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10165 * dispnew.c (flush_stdout):
10166 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10167 Mark as externally visible.
10168 * dispnew.c (check_window_matrix_pointers): Now static.
10169 * dispnew.c (window_to_frame_vpos):
10170 * xfns.c (unwind_create_frame):
10171 * xterm.c (x_check_font): Remove unused local.
10172 * scroll.c (CHECK_BOUNDS):
10173 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10174 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10175 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10176 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10177 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10178 Now static.
10179 (debug_method_add): Use va_list and vsprintf rather than relying
10180 on undefined behavior with wrong number of arguments.
10181 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10182 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10183 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10184 since we're not interested in debugging glyphs with old libraries.
10185 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10186 GCC 4.6.0's static checking.
10187
0766b489
PE
101882011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10189
31fd4b32
PE
10190 Integer overflow and signedness fixes (Bug#8873).
10191 A few related buffer overrun fixes, too.
10192
b79e8648
PE
10193 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10194
0766b489
PE
10195 * dispextern.h (struct face.stipple):
10196 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10197 (x_bitmap_mask, x_allocate_bitmap_record)
10198 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10199 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10200 (x_create_bitmap_from_xpm_data):
10201 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10202 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10203 (.bitmaps_last):
10204 * xfaces.c (load_pixmap):
10205 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10206 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10207 (.bitmaps_last, struct x_output.icon_bitmap):
10208 Use ptrdiff_t, not int, for bitmap indexes.
10209 (x_allocate_bitmap_record): Check for size overflow.
10210 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10211
b081724f
PE
10212 Use ptrdiff_t, not int, for overlay counts.
10213 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10214 * editfns.c (overlays_around, get_pos_property):
10215 * textprop.c (get_char_property_and_overlay):
10216 * xdisp.c (next_overlay_change, note_mouse_highlight):
10217 * xfaces.c (face_at_buffer_position):
21514da7
PE
10218 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10219 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10220 (Fnext_overlay_change, Fprevious_overlay_change)
10221 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10222 Use ptrdiff_t, not int, for sizes.
21514da7 10223 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10224
3de73e5e
PE
10225 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10226
2606c57b
PE
10227 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10228 (x_session_initialize): Do not assume string length fits in int.
10229
aaafe47a
PE
10230 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10231 This is unlikely, but can occur if DPI is outlandish.
10232
2674ddc8 10233 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10234 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10235
28154962
PE
10236 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10237 * xrdb.c (magic_file_p, search_magic_path):
10238 Omit last arg SUFFIX; it was always 0. All callers changed.
10239 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10240
7de51af5
PE
10241 * xfont.c (xfont_match): Avoid need for strlen.
10242
25ed6cc3
PE
10243 * xfns.c: Don't assume strlen fits in int.
10244 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10245
4eab31dd
PE
10246 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10247 not unsigned long, as we prefer signed integers. All callers changed.
10248 Detect integer overflow in repeat count.
10249 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10250 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10251
171e2a58
PE
10252 * termcap.c: Don't assume sizes fit in int and never overflow.
10253 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10254 (gobble_line): Check for size-calculation overflow.
10255
ad39faca 10256 * minibuf.c (Fread_buffer):
6e5bb2dc 10257 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10258 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10259 Don't assume string length fits in int.
10260
52c61c22 10261 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10262 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10263
b5b8c9e5
PE
10264 * font.c: Don't assume string length fits in int.
10265 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10266 Use ptrdiff_t, not int.
ccd6111c
PE
10267 (font_intern_prop): Don't assume string length fits in int.
10268 Don't assume integer property fits in fixnum.
10269 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10270
882f0d81 10271 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10272 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10273 Reformulate so as not to need the command string.
10274 Invoke gzip -cd rather than gunzip, as it's more portable.
10275 (lock_info_type, lock_file_1, lock_file):
10276 Don't assume pid_t and time_t fit in unsigned long.
10277 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10278 (current_lock_owner): Prefer signed type for sizes.
10279 Use memcpy, not strncpy, where memcpy is what is really wanted.
10280 Don't assume (via atoi) that time_t and pid_t fit in int.
10281 Check for time_t and/or pid_t out of range, e.g., via a network share.
10282 Don't alloca where an auto var works fine.
10283
93f4cf88
PE
10284 * fileio.c: Fix some integer overflow issues.
10285 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10286 Don't assume string length fits in int.
10287 (directory_file_name): Don't assume string length fits in long.
10288 (make_temp_name): Don't assume pid fits in int, or that its print
10289 length is less than 20.
10290
f3e92b69
PE
10291 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10292
1bfdaf10
PE
10293 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10294
35016e9a
PE
10295 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10296
3d1e65a1
PE
10297 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10298 We prefer signed integers, even for size calculations.
10299
0b963a93
PE
10300 * emacs.c: Don't assume string length fits in 'int'.
10301 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10302 (main): Don't invoke strlen when not needed.
10303
573f4b54
PE
10304 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10305 (XD_DEBUG_MESSAGE): Don't waste a byte.
10306
989f33ba
PE
10307 * callproc.c (getenv_internal_1, getenv_internal)
10308 (Fgetenv_internal):
965d34eb
PE
10309 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10310
e4d29b33
PE
10311 * lread.c (invalid_syntax): Omit length argument.
10312 All uses changed. This doesn't fix a bug, but it simplifies the
10313 code away from its former Hollerith-constant appearance, and it's
10314 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10315 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10316
eb49b136
PE
10317 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10318 This didn't break anything, but it didn't help either.
10319 It's confusing to put a bogus integer in a place where the actual
10320 value does not matter.
9f62aeb1 10321 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10322 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10323
15375a22
PE
10324 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10325 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10326 implementation.
b61cc01c
PE
10327 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10328 We prefer signed types, and the value cannot exceed the EMACS_INT
10329 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10330 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10331 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10332 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10333
53b2623d
PE
10334 * indent.c (sane_tab_width): New function.
10335 (current_column, scan_for_column, Findent_to, position_indentation)
10336 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10337 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10338
51cab52b 10339 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10340
f2ed8a70
PE
10341 * lisp.h (lint_assume): New macro.
10342 * composite.c (composition_gstring_put_cache):
10343 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10344
abe80cc6
PE
10345 * editfns.c, insdel.c:
10346 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10347
b02c740e
PE
10348 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10349
ebc96716
PE
10350 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10351
b4e50fa0 10352 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10353 Use much-faster test for byte-length change.
311d5d7c 10354 Don't assume string byte-length fits in 'int'.
a4cf38e4 10355 Check that character arg fits in 'int'.
85461888 10356 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10357
c0c1ee9f
PE
10358 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10359
a498d7f4
PE
10360 * fns.c (concat): Catch string overflow earlier.
10361 Do not rely on integer wraparound.
10362
51cab52b
PE
10363 * dispextern.h (struct it.overlay_strings_charpos)
10364 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10365 * xdisp.c (forward_to_next_line_start)
10366 (back_to_previous_visible_line_start)
10367 (reseat_at_next_visible_line_start, next_element_from_buffer):
10368 Don't arbitrarily truncate the value of 'selective' to int.
10369
76031fad
PE
10370 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10371
5eb55db9
PE
10372 * composite.c: Don't truncate sizes to 'int'.
10373 (composition_gstring_p, composition_reseat_it)
10374 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10375 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10376 not EMACS_UINT, for indexes.
5eb55db9 10377
0703a717
PE
10378 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10379
d6202519
PE
10380 * buffer.c: Include <verify.h>.
10381 (struct sortvec.priority, struct sortstr.priority):
8961a454 10382 Now EMACS_INT, not int.
c20998a7 10383 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10384 (struct sortstr.size, record_overlay_string)
10385 (struct sortstrlist.size, struct sortlist.used):
10386 Don't truncate size to int.
10387 (record_overlay_string): Check for size-calculation overflow.
d6202519 10388 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10389
d5a19415
JM
103902011-06-22 Jim Meyering <meyering@redhat.com>
10391
029529ac 10392 Don't leak an XBM-image-sized buffer
d5a19415
JM
10393 * image.c (xbm_load): Free the image buffer after using it.
10394
a9041e6c
PE
103952011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10396
10397 Port to Sun C.
10398 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10399 that Sun C diagnosed.
10400 * fns.c (secure_hash): Fix pointer signedness issue.
10401 * intervals.c (static_offset_intervals): New function.
10402 (offset_intervals): Use it.
10403
7f3f739f
LL
104042011-06-21 Leo Liu <sdl.web@gmail.com>
10405
10406 * deps.mk (fns.o):
10407 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10408 sha512.h.
10409
10410 * fns.c (secure_hash): Rename from crypto_hash_function and change
10411 the first arg to accept symbols.
5b66d427 10412 (Fsecure_hash): New primitive.
7f3f739f
LL
10413 (syms_of_fns): New symbols.
10414
76147d94
DD
104152011-06-20 Deniz Dogan <deniz@dogan.se>
10416
10417 * process.c (Fset_process_buffer): Clarify return value in
10418 docstring.
10419
7d7d0045
CY
104202011-06-18 Chong Yidong <cyd@stupidchicken.com>
10421
10422 * dispnew.c (add_window_display_history): Use BVAR.
10423
10424 * xdisp.c (debug_method_add): Use BVAR.
10425 (check_window_end, dump_glyph_matrix, dump_glyph)
10426 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10427
10428 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10429 Likewise.
10430
10431 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10432 check till after the cache is created in init_frame_faces.
10433
ff2bc410
SM
104342011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10435
10436 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10437
28177add
PE
104382011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10439
dd3482fe
PE
10440 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10441 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10442 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10443
393d71f3 10444 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10445 * fileio.c (Finsert_file_contents):
10446 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10447 Remove the old (too-loose) buffer overflow checks.
10448 They weren't needed, since make_gap checks for buffer overflow.
10449 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10450 The old code merely checked for Emacs fixnum overflow, and relied
10451 on undefined (wraparound) behavior. The new code avoids undefined
10452 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10453
2e6813b0 10454 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10455 Tune. Don't use wider integers than needed. Don't use alloca.
10456 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10457
599a9e4f
PE
10458 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10459
99561444
PE
10460 * insdel.c, lisp.h (buffer_overflow): New function.
10461 (insert_from_buffer_1, replace_range, replace_range_2):
10462 * insdel.c (make_gap_larger):
10463 * editfns.c (Finsert_char):
10464 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10465
28177add
PE
10466 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10467
e69dafad
PE
104682011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10469
4baa020d 10470 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10471
b1c46f02
PE
10472 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10473 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10474
e69dafad
PE
10475 * fileio.c: Don't assume EMACS_INT fits in off_t.
10476 (emacs_lseek): New static function.
10477 (Finsert_file_contents, Fwrite_region): Use it.
10478 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10479
566684ea
PE
10480 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10481
e6966cd6
PE
10482 * fns.c: Don't overflow int when computing a list length.
10483 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10484 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10485 truncation on 64-bit hosts. Check for QUIT every
10486 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10487 faster and is responsive enough.
10488 (Flength): Report an error instead of overflowing an integer.
10489 (Fsafe_length): Return a float if the value is not representable
10490 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10491 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10492 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10493
dd0b0efb
PE
10494 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10495 (header_size, word_size): New constants.
10496 (allocate_vectorlike): Don't check size overflow here.
10497 (allocate_vector): Check it here instead, since this is the only
10498 caller of allocate_vectorlike that could cause overflow.
10499 Check that the new vector's length is representable as a fixnum.
10500
86fe5cfe
PE
10501 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10502 The previous code was bogus. For example, next_almost_prime (32)
10503 returned 39, which is undesirable as it is a multiple of 3; and
10504 next_almost_prime (24) returned 25, which is a multiple of 5 so
10505 why was the code bothering to check for multiples of 7?
10506
80e88859
PE
10507 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10508
4a2f0ad6
PE
10509 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10510
f66c7cf8
PE
10511 Variadic C functions now count arguments with ptrdiff_t.
10512 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10513 Back then I didn't know that the Emacs coding style prefers signed int.
10514 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10515 were being counted with int, which may truncate counts on 64-bit
10516 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10517 * lisp.h (struct Lisp_Subr.function.aMANY)
10518 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10519 Arg counts are now ptrdiff_t, not size_t.
10520 All variadic functions and their callers changed accordingly.
10521 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10522 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10523 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10524 * callint.c (Fcall_interactively): Check arg count for overflow,
10525 to avoid potential buffer overrun. Use signed char, not 'int',
10526 for 'varies' array, so that we needn't bother to check its size
10527 calculation for overflow.
10528 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10529 * eval.c (apply_lambda):
10530 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10531 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10532 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10533
a1759b76
PE
10534 * callint.c (Fcall_interactively): Don't use index var as event count.
10535
d96be9fc
PE
10536 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10537 * mem-limits.h (SIZE): Remove; no longer used.
10538
a690a978 10539 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10540
578c21e6
PE
10541 Remove unnecessary casts.
10542 * xterm.c (x_term_init):
10543 * xfns.c (x_set_border_pixel):
10544 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10545 These aren't needed now that we assume ANSI C.
10546
96f53c6c
PE
10547 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10548 It's more likely to cause problems (due to unsigned overflow)
10549 than to cure them.
10550
83c77d31
PE
10551 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10552
ee2079f1
PE
10553 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10554
6da65536
PE
10555 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10556
7147c4a4
PE
10557 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10558
193e32d9
PE
10559 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10560
e5533da6
PE
10561 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10562
9910e595
PE
10563 GLYPH_CODE_FACE returns EMACS_INT, not int.
10564 * dispextern.h (merge_faces):
10565 * xfaces.c (merge_faces):
01103c44
PE
10566 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10567 Don't assume EMACS_INT fits in int.
9910e595 10568
2638320e
PE
10569 * character.h (CHAR_VALID_P): Remove unused parameter.
10570 * fontset.c, lisp.h, xdisp.c: All uses changed.
10571
045eb8d9
PE
10572 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10573
c1f134b5
PE
10574 * fns.c (concat): Minor tuning based on overflow analysis.
10575 This doesn't fix any bugs. Use int to hold character, instead
10576 of constantly refetching from Emacs object. Use XFASTINT, not
10577 XINT, for value known to be a character. Don't bother comparing
10578 a single byte to 0400, as it's always less.
10579
395fcb93 10580 * floatfns.c (Fexpt):
327eeec8
PE
10581 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10582
abbd3d23
PE
10583 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10584 for characters.
10585
684a03ef
PE
10586 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10587
0fed43f3
PE
10588 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10589 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10590 incorrectly succeed when S was a string, because 4294967386 was
10591 truncated before it was used.
10592
8fd02eb7
PE
10593 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10594 Otherwise, an out-of-range integer could cause undefined behavior
10595 on a 64-bit host.
10596
f8c86b69
PE
10597 * composite.c: Use int, not EMACS_INT, for characters.
10598 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10599 EMACS_INT, for values that are known to be in character range.
10600 This doesn't fix any bugs but is the usual style inside Emacs and
10601 may generate better code on 32-bit machines.
10602
34206dd2
PE
10603 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10604 This is for reasons similar to the recent CHAR_STRING fix.
10605 * charset.c (Fencode_char): Check that character arg is actually
10606 a character. Pass an int to ENCODE_CHAR.
10607 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10608 wider than 'int', as a compile-time check to prevent future regressions
10609 in this area.
10610
c5958d4c 10611 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10612
10613 Make sure a 64-bit char is never passed to CHAR_STRING.
10614 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10615 by silently ignoring the top 32 bits, allowing some values
10616 that were far too large to be valid characters.
10617 * character.h: Include <verify.h>.
10618 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10619 arguments are no wider than unsigned, as a compile-time check
10620 to prevent future regressions in this area.
10621 * data.c (Faset):
01103c44 10622 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10623 (Fsubst_char_in_region):
10624 * fns.c (concat):
10625 * xdisp.c (decode_mode_spec_coding):
10626 Adjust to CHAR_STRING's new requirement.
10627 * editfns.c (Finsert_char, Fsubst_char_in_region):
10628 * fns.c (concat): Check that character args are actually
10629 characters. Without this test, these functions did the wrong
10630 thing with wildly out-of-range values on 64-bit hosts.
10631
d37ca623
PE
10632 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10633 These casts should not be needed on 32-bit hosts, either.
10634 * keyboard.c (read_char):
10635 * lread.c (Fload): Remove casts to unsigned.
10636
ea204efb
PE
10637 * lisp.h (UNSIGNED_CMP): New macro.
10638 This fixes comparison bugs on 64-bit hosts.
10639 (ASCII_CHAR_P): Use it.
10640 * casefiddle.c (casify_object):
01103c44 10641 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10642 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10643 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10644 * dispextern.h (FACE_FROM_ID):
10645 * keyboard.c (read_char): Use UNSIGNED_CMP.
10646
41cb286c
PE
10647 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10648 not to EMACS_INT, to avoid GCC warning.
10649
4a1b9832
PE
10650 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10651
55daad71
PE
10652 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10653 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10654 isn't needed on 32-bit machines.
8f95c75c 10655
01103c44
PE
10656 * buffer.c (Fgenerate_new_buffer_name):
10657 Use EMACS_INT for count, not int.
0ceccced 10658 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10659
10660 * data.c (Qcompiled_function): Now static.
10661
c6f072e7
PE
10662 * window.c (window_body_lines): Now static.
10663
20ce5912
PE
10664 * image.c (gif_load): Rename local to avoid shadowing.
10665
9c4c5f81
PE
10666 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10667 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10668 * alloc.c (make_save_value): Integer argument is now of type
10669 ptrdiff_t, not int.
10670 (mark_object): Use ptrdiff_t, not int.
10671 * lisp.h (pD): New macro.
10672 * print.c (print_object): Use it.
10673
c0c5c8ae
PE
10674 * alloc.c: Use EMACS_INT, not int, to count objects.
10675 (total_conses, total_markers, total_symbols, total_vector_size)
10676 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10677 (total_free_floats, total_floats, total_free_intervals)
10678 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10679 Now EMACS_INT, not int. All uses changed.
10680 (Fgarbage_collect): Compute overall total using a double, so that
10681 integer overflow is less likely to be a problem. Check for overflow
10682 when converting back to an integer.
5a25e253
PE
10683 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10684 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10685 These were 'int' variables that could overflow on 64-bit hosts;
10686 they were never used, so remove them instead of repairing them.
211a0b2a 10687 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10688 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10689 Previously, this ceilinged at INT_MAX, but that doesn't work on
10690 64-bit machines.
e46bb31a 10691 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10692
c78baabf 10693 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10694 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10695 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10696 when a (possibly-narrower) signed value would do just as well.
10697 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10698
c9d624c6
PE
10699 * alloc.c: Catch some string size overflows that we were missing.
10700 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10701 for convenience in STRING_BYTES_MAX.
10702 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10703 The definition here is exact; the one in lisp.h was approximate.
10704 (allocate_string_data): Check for string overflow. This catches
10705 some instances we weren't catching before. Also, it catches
10706 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10707 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10708 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10709
c9d624c6
PE
10710 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10711 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10712 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10713
353032ce
PE
10714 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10715
2bccce07
PE
10716 * alloc.c (Fmake_string): Check for out-of-range init.
10717
0ac30604
SM
107182011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10719
10720 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10721
c195f2de
JD
107222011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10723
10724 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10725 xg_get_default_scrollbar_width.
10726
10727 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10728 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10729 (style_changed_cb): Call update_theme_scrollbar_width and call
10730 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10731 all frames (Bug#8505).
10732 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10733 Call gtk_window_set_resizable if HAVE_GTK3.
10734 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10735 and height if HAVE_GTK3 (Bug#8505).
10736 (scroll_bar_width_for_theme): New variable.
10737 (update_theme_scrollbar_width): New function.
10738 (xg_get_default_scrollbar_width): Move code to
10739 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10740 (xg_initialize): Call update_theme_scrollbar_width.
10741
10742 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10743
10744 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10745
e10ac9f1
MR
107462011-06-12 Martin Rudalics <rudalics@gmx.at>
10747
10748 * frame.c (make_frame): Call other_buffer_safely instead of
10749 other_buffer.
10750
10751 * window.c (temp_output_buffer_show): Call display_buffer with
10752 second argument Vtemp_buffer_show_specifiers and reset latter
10753 immediately after the call.
10754 (Vtemp_buffer_show_specifiers): New variable.
10755 (auto_window_vscroll_p, next_screen_context_lines)
10756 (Vscroll_preserve_screen_position): Remove leading asterisks from
10757 doc-strings.
10758
2d3c217e 107592011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10760
7b7f97e8 10761 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10762 * buffer.c (Qclone_number): Remove for now, as it's unused.
10763 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10764 (record_buffer): Remove unused local.
10765 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10766 (set_frame_buffer_list): Remove; unused.
10767 * frame.h (other_visible_frames): Remove decl.
10768 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10769 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10770 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10771 if HAVE_GPM.
10772 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10773 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10774 Define only if HAVE_GPM.
10775 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10776 (update_hints_inhibit): Remove; never set. All uses removed.
10777 * widgetprv.h (emacsFrameClassRec): Remove decl.
10778 * window.c (delete_deletable_window): Now returns void, since it
10779 wasn't returning anything.
10780 (compare_window_configurations): Remove unused locals.
10781 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10782 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10783 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10784 the same widths as pointers. This follows up on the 2011-05-06 patch.
10785 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10786 * xterm.h: Likewise.
10787 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10788
1384b89e
JB
107892011-06-12 Juanma Barranquero <lekktu@gmail.com>
10790
10791 * makefile.w32-in: Update dependencies.
10792 (LISP_H): Add lib/intprops.h.
10793
1100a63c
CY
107942011-06-11 Chong Yidong <cyd@stupidchicken.com>
10795
10796 * image.c (gif_load): Add animation frame delay to the metadata.
10797 (syms_of_image): Use DEFSYM. New symbol `delay'.
10798
6198ccd0
MR
107992011-06-11 Martin Rudalics <rudalics@gmx.at>
10800
10801 * window.c (delete_deletable_window): Re-add.
10802 (Fset_window_configuration): Rewrite to handle dead buffers and
10803 consequently deletable windows.
10804 (window_tree, Fwindow_tree): Remove. Supply functionality in
10805 window.el.
10806 (compare_window_configurations): Simplify code.
10807
b6e3633c
AS
108082011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10809
1ab0dee5
AS
10810 * image.c (imagemagick_load_image): Fix type mismatch.
10811 (Fimagemagick_types): Likewise.
10812
b6e3633c
AS
10813 * window.h (replace_buffer_in_windows): Declare.
10814
9397e56f
MR
108152011-06-11 Martin Rudalics <rudalics@gmx.at>
10816
10817 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10818 Qclone_number. Remove external declaration of Qdelete_window.
10819 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10820 code.
640c8776
SM
10821 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10822 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10823 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10824 buffer list implementation.
10825 (other_buffer_safely): New function.
10826 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10827 calls to replace_buffer_in_windows and
10828 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10829 if allowed.
10830 (record_buffer): Inhibit quitting and rewrite using quittable
10831 functions. Run Qbuffer_list_update_hook if allowed.
10832 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10833 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10834 Move switch-to-buffer to window.el.
9397e56f
MR
10835 (bury-buffer): Move to window.el.
10836 (Vbuffer_list_update_hook): New variable.
10837
10838 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10839 section.
10840
10841 * window.h (resize_frame_windows): Move up in code.
10842 (Fwindow_frame): Remove EXFUN.
10843 (replace_buffer_in_all_windows): Remove prototype.
10844 (replace_buffer_in_windows_safely): Add prototype.
10845
10846 * window.c: Declare Qdelete_window static again. Move down
10847 declaration of select_count.
10848 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10849 (Fother_window): Move to window.el.
10850 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10851 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10852 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10853 window.el.
10854 (replace_buffer_in_windows): Implement by calling
10855 Qreplace_buffer_in_windows.
10856 (replace_buffer_in_all_windows): Remove with some functionality
10857 moved into replace_buffer_in_windows_safely.
10858 (replace_buffer_in_windows_safely): New function.
10859 (select_window_norecord, select_frame_norecord): Move in front
10860 of run_window_configuration_change_hook. Remove now obsolete
10861 declarations.
640c8776
SM
10862 (Fset_window_buffer): Rewrite doc-string.
10863 Call Qrecord_window_buffer.
9397e56f
MR
10864 (keys_of_window): Move binding for other-window to window.el.
10865
b50691aa
CY
108662011-06-11 Chong Yidong <cyd@stupidchicken.com>
10867
10868 * dispextern.h (struct image): Replace data member, whose int_val
10869 and ptr_val fields were not used by anything, with a single
10870 lisp_val object.
10871
10872 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10873 (gif_clear_image, gif_load, imagemagick_load_image)
10874 (gs_clear_image, gs_load): Callers changed.
10875
3f754b86
PE
108762011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10877
cca69397
PE
10878 * buffer.h: Include <time.h>, for time_t.
10879 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10880
109e28d0
PE
10881 Fix minor problems found by static checking.
10882
60737f02
PE
10883 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10884
4b66faf3
PE
10885 Make identifiers static if they are not used in other modules.
10886 * data.c (Qcompiled_function, Qframe, Qvector):
10887 * image.c (QimageMagick, Qsvg):
10888 * minibuf.c (Qmetadata):
10889 * window.c (resize_window_check, resize_root_window): Now static.
10890 * window.h (resize_window_check, resize_root_window): Remove decls.
10891
109e28d0
PE
10892 * window.c (window_deletion_count, delete_deletable_window):
10893 Remove; unused.
46a4ce9e
PE
10894 (window_body_lines): Now static.
10895 (Fdelete_other_windows_internal): Mark vars as initialized.
10896 Make sure 'resize_failed' is initialized.
10897 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10898 (resize_window_apply): Remove unused local.
10899 * window.h (delete_deletable_window): Remove decl.
10900
109e28d0 10901 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10902 (imagemagick_load_image): Fix pointer signedness problem by changing
10903 last arg from unsigned char * to char *. All uses changed.
10904 Also, fix a local for similar reasons.
10905 Remove unused locals. Remove locals to avoid shadowing.
10906 (fn_rsvg_handle_free): Remove; unused.
10907 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10908 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10909
3f754b86
PE
10910 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10911
2547adb1
CY
109122011-06-10 Chong Yidong <cyd@stupidchicken.com>
10913
10914 * image.c (gif_load): Fix omitted cast error introduced by
10915 2011-06-06 change.
10916
2c8e37d4
MR
109172011-06-10 Martin Rudalics <rudalics@gmx.at>
10918
10919 * window.h (resize_proportionally, orig_total_lines)
10920 (orig_top_line): Remove from window structure.
10921 (set_window_height, set_window_width, change_window_heights)
10922 (Fdelete_window): Remove prototypes.
10923 (resize_frame_windows): Remove duplicate declaration.
10924
440a42e3
EZ
109252011-06-10 Eli Zaretskii <eliz@gnu.org>
10926
10927 * window.h (resize_frame_windows, resize_window_check)
10928 (delete_deletable_window, resize_root_window)
10929 (resize_frame_windows): Declare prototypes.
10930
10931 * window.c (resize_window_apply): Make definition be "static" to
10932 match the prototype.
10933
562dd5e9
MR
109342011-06-10 Martin Rudalics <rudalics@gmx.at>
10935
10936 * window.c: Remove declarations of Qwindow_size_fixed,
10937 window_min_size_1, window_min_size_2, window_min_size,
10938 size_window, window_fixed_size_p, enlarge_window, delete_window.
10939 Remove static from declaration of Qdelete_window, it's
10940 temporarily needed by Fbury_buffer.
10941 (replace_window): Don't assign orig_top_line and
10942 orig_total_lines.
10943 (Fdelete_window, delete_window): Remove. Window deletion is
10944 handled by window.el.
640c8776
SM
10945 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10946 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10947 (Fdelete_other_windows): Remove. Deleting other windows is
10948 handled by window.el.
10949 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10950 handled in window.el.
10951 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10952 Window minimum sizes are handled in window.el.
10953 (shrink_windows, size_window, set_window_height)
10954 (set_window_width, change_window_heights, window_height)
10955 (window_width, CURBEG, CURSIZE, enlarge_window)
10956 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10957 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10958 handled in window.el.
10959 (make_dummy_parent): Rename to make_parent_window and give it a
10960 second argument horflag.
10961 (make_window): Don't set resize_proportionally any more.
10962 (Fsplit_window): Remove. Windows are split in window.el.
10963 (save_restore_action, save_restore_orig_size)
10964 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10965 Resize mini windows in window.el.
10966 (grow_mini_window, shrink_mini_window): Implement by calling
10967 Qresize_root_window_vertically, resize_window_check and
10968 resize_window_apply.
640c8776
SM
10969 (saved_window, Fset_window_configuration, save_window_save):
10970 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10971 resize_proportionally.
10972 (window_min_height, window_min_width): Move to window.el.
10973 (keys_of_window): Move bindings for delete-other-windows,
10974 split-window, delete-window and enlarge-window to window.el.
10975
10976 * buffer.c: Temporarily extern Qdelete_window.
10977 (Fbury_buffer): Temporarily call Qdelete_window instead of
10978 Fdelete_window (Fbury_buffer will move to window.el soon).
10979
10980 * frame.c (set_menu_bar_lines_1): Remove code handling
10981 orig_top_line and orig_total_lines.
10982
10983 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10984 set_window_height but set heights directly.
10985 (change_frame_size_1): Use resize_frame_windows.
10986
10987 * xdisp.c (init_xdisp): Don't use set_window_height but set
10988 heights directly.
10989
640c8776
SM
10990 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10991 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10992 run_window_configuration_change_hook.
10993
10994 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10995 instead of change_window_heights and run
10996 run_window_configuration_change_hook.
10997
1a13852e
MR
109982011-06-09 Martin Rudalics <rudalics@gmx.at>
10999
11000 * window.c (replace_window): Rename second argument REPLACEMENT to
11001 NEW. New third argument SETFLAG. Rewrite.
11002 (delete_window, make_dummy_parent): Call replace_window with
11003 third argument 1.
11004 (window_list_1): Move down in code.
11005 (run_window_configuration_change_hook): Move set_buffer part
11006 before select_frame_norecord part in order to unwind correctly.
11007 Rename count1 to count.
11008 (recombine_windows, delete_deletable_window, resize_root_window)
11009 (Fdelete_other_windows_internal)
11010 (Frun_window_configuration_change_hook, make_parent_window)
11011 (resize_window_check, resize_window_apply, Fresize_window_apply)
11012 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11013 (Fdelete_window_internal, Fresize_mini_window_internal):
11014 New functions.
1a13852e
MR
11015 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11016
f3d1777e
MR
110172011-06-08 Martin Rudalics <rudalics@gmx.at>
11018
496e208e
MR
11019 * window.h (window): Add some new members to window structure -
11020 normal_lines, normal_cols, new_total, new_normal, clone_number,
11021 splits, nest, prev_buffers, next_buffers.
11022 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11023 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11024
f3d1777e
MR
11025 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11026 Remove.
496e208e
MR
11027 (make_dummy_parent): Set new members of windows structure.
11028 (make_window): Move down in code. Handle new members of window
11029 structure.
11030 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11031 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11032 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11033 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11034 (Fset_window_next_buffers, Fset_window_clone_number):
11035 New functions.
496e208e
MR
11036 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11037 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11038 Doc-string fixes.
11039 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11040 Argument WINDOW can be now internal window too.
11041 (Fwindow_use_time): Move up in code.
11042 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11043 Rewrite doc-string.
11044 (Fset_window_configuration, saved_window)
11045 (Fcurrent_window_configuration, save_window_save): Handle new
11046 members of window structure.
b9e809c2
MR
11047 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11048 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11049 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11050 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11051 Qget_mru_window, Qresize_root_window,
11052 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11053 Qauto_buffer_name; staticpro them.
f3d1777e 11054
abde8f8c
MR
110552011-06-07 Martin Rudalics <rudalics@gmx.at>
11056
11057 * window.c (Fwindow_total_size, Fwindow_left_column)
11058 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11059 (Fwindow_list_1): New functions.
11060 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11061 (Fwindow_width, Fscroll_left, Fscroll_right):
11062 Use window_body_cols instead of window_box_text_cols.
11063 (delete_window, Fset_window_configuration):
11064 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11065 (delete_all_subwindows): Take a window as argument and not a
11066 structure. Rewrite.
190b47e6
MR
11067 (window_loop): Remove handling of GET_LRU_WINDOW and
11068 GET_LARGEST_WINDOW.
11069 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11070
11071 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11072 window_box_text_cols. delete_all_subwindows now takes a
11073 Lisp_Object as argument.
abde8f8c 11074
640c8776
SM
11075 * indent.c (compute_motion, Fcompute_motion):
11076 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11077
fa8a67e6
MR
11078 * frame.c (delete_frame): Call delete_all_subwindows with root
11079 window as argument.
11080
a54e3482
DC
110812011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11082
11083 * fns.c (Fputhash): Document return value.
11084
60002bf5
CY
110852011-06-06 Chong Yidong <cyd@stupidchicken.com>
11086
11087 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11088
0c671da6 110892011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11090
b862a52a 11091 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11092
be44ca6c
PE
11093 Check for overflow when converting integer to cons and back.
11094 * charset.c (Fdefine_charset_internal, Fdecode_char):
11095 Use cons_to_unsigned to catch overflow.
11096 (Fencode_char): Use INTEGER_TO_CONS.
11097 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11098 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11099 * data.c (long_to_cons, cons_to_long): Remove.
11100 (cons_to_unsigned, cons_to_signed): New functions.
11101 These signal an error for invalid or out-of-range values.
11102 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11103 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11104 * font.c (Ffont_variation_glyphs):
11105 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11106 * lisp.h: Include <intprops.h>.
11107 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11108 (cons_to_signed, cons_to_unsigned): New decls.
11109 (long_to_cons, cons_to_long): Remove decls.
11110 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11111 (Fprimitive_undo): Use CONS_TO_INTEGER.
11112 * xfns.c (Fx_window_property): Likewise.
11113 * xselect.c: Include <limits.h>.
11114 (x_own_selection, selection_data_to_lisp_data):
11115 Use INTEGER_TO_CONS.
11116 (x_handle_selection_request, x_handle_selection_clear)
11117 (x_get_foreign_selection, Fx_disown_selection_internal)
11118 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11119 (lisp_data_to_selection_data): Use cons_to_unsigned.
11120 (x_fill_property_data): Use cons_to_signed.
11121 Report values out of range.
11122
d1f3d2af
PE
11123 Check for buffer and string overflow more precisely.
11124 * buffer.h (BUF_BYTES_MAX): New macro.
11125 * lisp.h (STRING_BYTES_MAX): New macro.
11126 * alloc.c (Fmake_string):
11127 * character.c (string_escape_byte8):
11128 * coding.c (coding_alloc_by_realloc):
11129 * doprnt.c (doprnt):
11130 * editfns.c (Fformat):
11131 * eval.c (verror):
11132 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11133 since they may not be the same number.
11134 * editfns.c (Finsert_char):
11135 * fileio.c (Finsert_file_contents):
11136 Likewise for BUF_BYTES_MAX.
11137
dd52fcea
PE
11138 * image.c: Use ptrdiff_t, not int, for sizes.
11139 (slurp_file): Switch from int to ptrdiff_t.
11140 All uses changed.
11141 (slurp_file): Check that file size fits in both size_t (for
11142 malloc) and ptrdiff_t (for sanity and safety).
11143
7f9bbdbb
PE
11144 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11145 if b->modtime has its maximal value.
11146
dfe18f82
PE
11147 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11148
84acfcf0
PE
11149 Don't assume time_t can fit into int.
11150 * buffer.h (struct buffer.modtime): Now time_t, not int.
11151 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11152 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11153
ccd9a01a
PE
11154 Minor fixes for signed vs unsigned integers.
11155 * character.h (MAYBE_UNIFY_CHAR):
11156 * charset.c (maybe_unify_char):
11157 * keyboard.c (read_char, reorder_modifiers):
11158 XINT -> XFASTINT, since the integer must be nonnegative.
11159 * ftfont.c (ftfont_spec_pattern):
11160 * keymap.c (access_keymap, silly_event_symbol_error):
11161 XUINT -> XFASTINT, since the integer must be nonnegative.
11162 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11163 since it makes no difference and we prefer signed.
11164 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11165 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11166 nonnegative.
11167
d6d100dd
SM
111682011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11169
11170 * window.h (Fwindow_frame): Declare.
11171
2b6148e4
PE
111722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11173
11174 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11175 (SPARE_MEMORY): Always define.
11176 (LARGE_REQUEST): Remove.
11177 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11178
f230ecc9
MR
111792011-06-06 Martin Rudalics <rudalics@gmx.at>
11180
727e958e
MR
11181 * lisp.h: Move EXFUNS for Fframe_root_window,
11182 Fframe_first_window and Fset_frame_selected_window to window.h.
11183
11184 * window.h: Move EXFUNS for Fframe_root_window,
11185 Fframe_first_window and Fset_frame_selected_window here from
11186 lisp.h.
11187
11188 * frame.c (Fwindow_frame, Fframe_first_window)
11189 (Fframe_root_window, Fframe_selected_window)
11190 (Fset_frame_selected_window): Move to window.c.
11191 (Factive_minibuffer_window): Move to minibuf.c.
11192 (Fother_visible_frames_p): New function.
11193
11194 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11195
f230ecc9
MR
11196 * window.c (decode_window, decode_any_window): Move up in code.
11197 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11198 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11199 (Fwindow_buffer): Move up and rewrite doc-string.
11200 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11201 (Fwindow_prev): New functions.
727e958e
MR
11202 (Fwindow_frame): Move here from frame.c. Accept any window as
11203 argument.
11204 (Fframe_root_window, Fframe_first_window)
11205 (Fframe_selected_window): Move here from frame.c. Accept frame
11206 or arbitrary window as argument. Update doc-strings.
11207 (Fminibuffer_window): Move up in code.
11208 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11209 (Fset_frame_selected_window): Move here from frame.c.
11210 Marginal rewrite.
727e958e
MR
11211 (Fselected_window, select_window, Fselect_window): Move up in
11212 code. Minor doc-string fixes.
f230ecc9 11213
4d09bcf6
PE
112142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11215
11216 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11217 Do not assume that spare memory exists; that assumption is valid
11218 only if SYSTEM_MALLOC.
11219 (LARGE_REQUEST): New macro, so that the issue of large requests
11220 is separated from the issue of spare memory.
11221
810928a2
AS
112222011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11223
172418ad
AS
11224 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11225 format. (Bug#8806)
11226
43f862f7
AS
11227 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11228
810928a2
AS
11229 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11230 before statements.
11231
a059fe24
JD
112322011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11233
11234 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11235
11236 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11237
11238 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11239 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11240
989bf368
JB
112412011-06-05 Juanma Barranquero <lekktu@gmail.com>
11242
11243 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11244
4b80f674
CY
112452011-06-04 Chong Yidong <cyd@stupidchicken.com>
11246
11247 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11248 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11249 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11250 New error handlers.
4b80f674
CY
11251 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11252 Obey Vx_select_enable_clipboard_manager. Catch errors in
11253 x_clipboard_manager_save (Bug#8779).
11254 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11255 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11256
99a33b77 112572011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11258
11259 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11260
99a33b77 112612011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11262
11263 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11264 in the current matrix if keep_current_p is non-zero.
11265
8264569d
EZ
112662011-06-04 Eli Zaretskii <eliz@gnu.org>
11267
11268 * bidi.c (bidi_level_of_next_char): Fix last change.
11269
57f97249
EZ
112702011-06-03 Eli Zaretskii <eliz@gnu.org>
11271
fec2107c 11272 Support bidi reordering of text covered by display properties.
57f97249 11273
fec2107c
EZ
11274 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11275 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11276 (bidi_cache_search, bidi_cache_iterator_state)
11277 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11278 (bidi_level_of_next_char, bidi_move_to_visually_next):
11279 Support character positions inside a run of characters covered by a
fec2107c
EZ
11280 display string.
11281 (bidi_paragraph_init, bidi_resolve_explicit_1)
11282 (bidi_level_of_next_char): Call bidi_fetch_char and
11283 bidi_fetch_char_advance instead of FETCH_CHAR and
11284 FETCH_CHAR_ADVANCE.
11285 (bidi_init_it): Initialize new members.
11286 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11287 definitions.
11288 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11289 instead of using explicit *_CHAR codes.
d6d100dd
SM
11290 (bidi_resolve_explicit, bidi_resolve_weak):
11291 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11292 bidirectional text is supported only in multibyte buffers.
11293 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11294 it to initialize the frame_window_p member of struct bidi_it.
11295 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11296 (bidi_resolve_explicit, bidi_resolve_weak)
11297 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11298 bidi_it->nchars is non-positive.
11299 (bidi_level_of_next_char): Don't try to lookup the cache for the
11300 next/previous character if nothing is cached there yet, or if we
11301 were just reseat()'ed to a new position.
c40e2fb2 11302
0e14fe90
EZ
11303 * xdisp.c (set_cursor_from_row): Set start and stop points
11304 according to the row's direction when priming the loop that looks
11305 for the glyph on which to display cursor.
11306 (single_display_spec_intangible_p): Function deleted.
11307 (display_prop_intangible_p): Reimplement to call
11308 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11309 Accept 3 additional arguments needed by handle_display_spec.
11310 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11311 values: lists, `(when COND...)' forms, etc.
11312 (single_display_spec_string_p): Support property values that are
11313 lists with the argument STRING its top-level element.
11314 (display_prop_string_p): Fix the condition for processing a
11315 property that is a list to be consistent with handle_display_spec.
fec2107c 11316 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11317 last portion of handle_display_prop.
11318 (compute_display_string_pos): Accept additional argument
11319 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11320 value of a `display' property is a "replacing spec".
11321 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11322 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11323 the display property, but just return a value indicating whether
11324 the display property will replace the characters it covers.
11325 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11326 frame_window_p members of struct bidi_it.
d6d100dd
SM
11327 (compute_display_string_pos, compute_display_string_end):
11328 New functions.
fec2107c
EZ
11329 (push_it): Accept second argument POSITION, where pop_it should
11330 jump to continue iteration.
11331 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11332
fec2107c
EZ
11333 * keyboard.c (adjust_point_for_property): Adjust the call to
11334 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11335
11336 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11337 (bidi_init_it): Update prototypes.
11338 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11339 (compute_display_string_pos, compute_display_string_end):
11340 Declare prototypes.
fec2107c
EZ
11341 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11342 EMACS_INT.
fc6f18ce 11343
40087514 113442011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11345
57f53182
PE
11346 Malloc failure behavior now depends on size of allocation.
11347 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11348 * lisp.h: Change signatures accordingly.
11349 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11350 All callers changed. (Bug#8762)
11351
11352 * gnutls.c: Use Emacs's memory allocators.
11353 Without this change, the gnutls library would invoke malloc etc.
11354 directly, which causes problems on non-SYNC_INPUT hosts, and which
11355 runs afoul of improving memory_full behavior. (Bug#8761)
11356 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11357 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11358 xfree instead of the default malloc, realloc, free.
11359 (Fgnutls_boot): No need to check for memory allocation failure,
11360 since xmalloc does that for us.
11361
ac32cd99 11362 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11363 * category.c (hash_get_category_set):
11364 * ccl.c (ccl_driver):
11365 * charset.c (Fdefine_charset_internal):
11366 * charset.h (struct charset.hash_index):
11367 * composite.c (get_composition_id, gstring_lookup_cache)
11368 (composition_gstring_put_cache):
11369 * composite.h (struct composition.hash_index):
11370 * dispextern.h (struct image.hash):
11371 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11372 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11373 (hashfn_equal, hashfn_user_defined, make_hash_table)
11374 (maybe_resize_hash_table, hash_lookup, hash_put)
11375 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11376 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11377 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11378 * image.c (make_image, search_image_cache, lookup_image)
11379 (xpm_put_color_table_h):
11380 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11381 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11382 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11383 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11384 * alloc.c (allocate_vectorlike):
11385 Check for overflow in vector size calculations.
11386 * ccl.c (ccl_driver):
11387 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11388 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11389 need to be updated by these changes.
40087514
PE
11390 * fns.c (make_hash_table, maybe_resize_hash_table):
11391 Check for integer overflow with large hash tables.
0de4bb68
PE
11392 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11393 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11394 (SXHASH_REDUCE): New macro.
11395 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11396 Use it instead of discarding useful hash info with large hash values.
11397 (sxhash_float): New function.
11398 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11399 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11400 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11401 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11402 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11403 Adjust signatures to match updated version of code.
11404 (consing_since_gc): Now EMACS_INT, since a single hash table can
11405 use more than INT_MAX bytes.
11406
698d32e2
DN
114072011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11408
11409 Make it possible to build with GCC-4.6+ -O2 -flto.
11410
11411 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11412
fd6fa53f
SM
114132011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11414
11415 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11416 Call minibuffer-inactive-mode.
11417
864db017
JB
114182011-05-31 Juanma Barranquero <lekktu@gmail.com>
11419
11420 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11421 Update dependencies.
11422
2ad0baf4
DN
114232011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11424
11425 * data.c (init_data): Remove code for UTS, this system is not
11426 supported anymore.
11427
4fcc2638
DN
114282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11429
11430 Don't force ./temacs to start in terminal mode.
11431
11432 * frame.c (make_initial_frame): Initialize faces in all cases, not
11433 only when CANNOT_DUMP is defined.
11434 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11435
c56e0fd5
DN
114362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11437
11438 * dispnew.c (add_window_display_history): Use const for the string
11439 pointer. Remove declaration, not needed.
11440
333d54da 114412011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11442
55d4c1b2 11443 Use 'inline', not 'INLINE'.
333d54da 11444 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11445 * alloc.c, fontset.c (INLINE): Remove.
11446 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11447 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11448 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11449 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11450 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11451
738db178
DN
114522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11453
11454 Make it possible to run ./temacs.
11455
11456 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11457 syms_of_callproc does the same thing. Remove test for
11458 "initialized", do it in the caller.
11459 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11460
620c53a6
SM
114612011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11462
11463 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11464 (read_minibuf): Use get_minibuffer.
11465 (syms_of_minibuf): Use DEFSYM.
11466 (Qmetadata): New var.
11467 * data.c (Qbuffer): Don't make it static.
11468 (syms_of_data): Use DEFSYM.
11469
e003a292
PE
114702011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11471
11472 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11473 (CCL_CODE_MIN): New macro.
11474
ed008a6d
PE
114752011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11476
3687c2ef
PE
11477 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11478
ed008a6d
PE
11479 * eval.c (Qdebug): Now static.
11480 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11481 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11482 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11483
d66c4c7c
CY
114842011-05-29 Chong Yidong <cyd@stupidchicken.com>
11485
11486 * image.c: Various fixes to ImageMagick code comments.
11487 (Fimagemagick_types): Doc fix.
11488
5fbc2025
PE
114892011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11490
0196f88a
PE
11491 Minor fixes prompted by GCC 4.6.0 warnings.
11492
11493 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11494
5fbc2025
PE
11495 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11496 (x_clipboard_manager_save_all): Move extern decl to ...
11497 * xterm.h: ... here, so that it can be checked for consistency.
11498
1dd3c2d9
CY
114992011-05-29 Chong Yidong <cyd@stupidchicken.com>
11500
11501 * xselect.c (x_clipboard_manager_save_frame)
11502 (x_clipboard_manager_save_all): New functions.
11503 (Fx_clipboard_manager_save): Lisp function deleted.
11504
11505 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11506 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11507
11508 * xterm.h: Update prototype.
11509
5ba6571d
WX
115102011-05-28 William Xu <william.xwl@gmail.com>
11511
11512 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11513 exiting (Bug#8239).
11514
3eaff834
JM
115152011-05-28 Jim Meyering <meyering@redhat.com>
11516
e1900994 11517 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11518 * fns.c (to_uchar): Define.
11519 (crypto_hash_function): Use it to convert some newly-signed
11520 variables to unsigned, to avoid sign-extension bugs. For example,
11521 without this change, (md5 "truc") would evaluate to
11522 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11523 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11524 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11525
0f6990a7
PE
115262011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11527
11528 Integer overflow fixes.
c8a9ca5a 11529
08686060
PE
11530 * dbusbind.c: Serial number integer overflow fixes.
11531 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11532 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11533 to hold a serial number that is too large for a fixnum.
11534 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11535 Check for serial numbers out of range. Decode any serial number
59568bf0 11536 that was so large that it became a float. (Bug#8722)
08686060 11537
2d1fc3c7
PE
11538 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11539 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11540 Use XFASTINT rather than XUINT when numbers are nonnegative.
11541 (xd_append_arg, Fdbus_method_return_internal):
11542 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11543 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11544 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11545 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11546 (Bug#8722)
2d1fc3c7 11547
c8a9ca5a
PE
11548 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11549
519e1d69
PE
11550 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11551
6df6ae42 11552 ccl: Add integer overflow checks.
30569699
PE
11553 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11554 (IN_INT_RANGE): New macros.
11555 (ccl_driver): Use them to check for integer overflow when
11556 decoding a CCL program. Many of the new checks are whether XINT (x)
11557 fits in int; it doesn't always, on 64-bit hosts. The new version
11558 doesn't catch all possible integer overflows, but it's an
847044ea 11559 improvement. (Bug#8719)
30569699 11560
c11285dc
PE
11561 * alloc.c (make_event_array): Use XINT, not XUINT.
11562 There's no need for unsigned here.
11563
fdccd48e
PE
11564 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11565 This follows up to the 2011-05-06 change that substituted uintptr_t
11566 for EMACS_INT. This case wasn't caught back then.
11567
37910ab2
PE
11568 Rework Fformat to avoid integer overflow issues.
11569 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11570 now (part of C89). Include <verify.h>.
11571 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11572 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11573 (Fformat): Avoid the prepass trying to compute sizes; it was only
11574 approximate and thus did not catch overflow reliably. Instead, walk
11575 through the format just once, formatting and computing sizes as we go,
11576 checking for integer overflow at every step, and allocating a larger
11577 buffer as needed. Keep track separately whether the format is
11578 multibyte. Keep only the most-recently calculated precision, rather
11579 than them all. Record whether each argument has been converted to
11580 string. Use EMACS_INT, not int, for byte and char and arg counts.
11581 Support field widths and precisions larger than INT_MAX. Avoid
11582 sprintf's undefined behavior with conversion specifications such as %#d
11583 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11584 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11585 formatting out-of-range floating point numbers with int
9173deec 11586 formats. (Bug#8668)
37910ab2 11587
2e6578fb
PE
11588 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11589
0ae6bdee
PE
11590 * data.c: Avoid integer truncation in expressions involving floats.
11591 * data.c: Include <intprops.h>.
11592 (arith_driver): When there's an integer overflow in an expression
11593 involving floating point, convert the integers to floating point
11594 so that the resulting value does not suffer from catastrophic
11595 integer truncation. For example, on a 64-bit host (* 4
11596 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11597 Do not rely on undefined behavior after integer overflow.
11598
de883a70
PE
11599 merge count_size_as_multibyte, parse_str_to_multibyte
11600 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11601 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11602 Check for integer overflow.
11603 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11604 since it's now a duplicate of the other. This is more of
11605 a character than a buffer op, so better that it's in character.c.
11606 * fns.c, print.c: Adjust to above changes.
11607
2ff916cb
PE
116082011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11609
11610 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11611
f1b54466
PE
116122011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11613
fb1ac845
PE
11614 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11615 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11616 (x_clipboard_manager_save): Now static.
11617 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11618
f1b54466
PE
11619 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11620 (crypto_hash_function): Now static.
11621 Fix pointer signedness problems. Avoid unnecessary initializations.
11622
a9f737ee
CY
116232011-05-27 Chong Yidong <cyd@stupidchicken.com>
11624
11625 * termhooks.h (Vselection_alist): Make it terminal-local.
11626
11627 * terminal.c (create_terminal): Initialize it.
11628
11629 * xselect.c: Support for clipboard managers.
11630 (Vselection_alist): Move to termhooks.h as terminal-local var.
11631 (LOCAL_SELECTION): New macro.
11632 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11633 (symbol_to_x_atom): Remove gratuitous arg.
11634 (x_handle_selection_request, lisp_data_to_selection_data)
11635 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11636 (x_own_selection, x_get_local_selection, x_convert_selection):
11637 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11638 (some_frame_on_display): Delete unused function.
11639 (Fx_own_selection_internal, Fx_get_selection_internal)
11640 (Fx_disown_selection_internal, Fx_selection_owner_p)
11641 (Fx_selection_exists_p): New optional frame arg.
11642 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11643 (x_handle_selection_clear): Don't treat other terminals with the
11644 same keyboard specially. Use the terminal-local Vselection_alist.
11645 (x_clear_frame_selections): Use Frun_hook_with_args.
11646
11647 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11648
11649 * xterm.h: Add support for those atoms.
11650
e067f0c1
CY
116512011-05-26 Chong Yidong <cyd@stupidchicken.com>
11652
11653 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11654 (converted_selections, conversion_fail_tag): New global variables.
11655 (x_selection_request_lisp_error): Free the above.
11656 (x_get_local_selection): Remove unnecessary code.
11657 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11658 of converted selections stored in converted_selections.
11659 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11660 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11661 (x_convert_selection): New function.
11662 (x_handle_selection_event): Simplify.
11663 (x_get_foreign_selection): Don't ignore incoming requests while
11664 waiting for an answer; this will fail when we implement
11665 SAVE_TARGETS, and seems unnecessary anyway.
11666 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11667 (Vx_sent_selection_functions): Doc fix.
11668
0f4aebc0
LL
116692011-05-26 Leo Liu <sdl.web@gmail.com>
11670
11671 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11672
e61124cd
YM
116732011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11674
11675 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11676
11677 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11678 for fringe update if it has periodic bitmap.
ac389d0c 11679 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11680 and fringe_bitmap_periodic_p.
11681
11682 * fringe.c (get_fringe_bitmap_data): New function.
11683 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11684 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11685 row. Mark glyph row for fringe update if periodicity changed.
11686
11687 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11688 for fringe update unless it has periodic bitmap.
11689
f16d9837
KH
116902011-05-25 Kenichi Handa <handa@m17n.org>
11691
11692 * xdisp.c (get_next_display_element): Set correct it->face_id for
11693 a static composition.
11694
e1b90ef6
LL
116952011-05-24 Leo Liu <sdl.web@gmail.com>
11696
11697 * deps.mk (fns.o):
11698 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11699
11700 * fns.c (crypto_hash_function, Fsha1): New function.
11701 (Fmd5): Use crypto_hash_function.
11702 (syms_of_fns): Add Ssha1.
11703
7400048f
PE
117042011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11705
11706 * gnutls.c: Remove unused macros.
11707 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11708 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11709 Remove macros that are defined and never used.
11710 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11711
abb71cf4
CY
117122011-05-22 Chong Yidong <cyd@stupidchicken.com>
11713
11714 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11715 (Fx_get_selection_internal): Minor cleanup.
11716 (Fx_own_selection_internal): Rename arguments for consistency with
11717 select.el.
11718
6307db39
PE
117192011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11720
11721 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11722
f3d4e0a4
CY
117232011-05-22 Chong Yidong <cyd@stupidchicken.com>
11724
11725 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11726
4d8ade89
YM
117272011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11728
11729 * dispnew.c (scrolling_window): Don't exclude the case that the
11730 last enabled row in the desired matrix touches the bottom boundary.
11731
32078c8d
GM
117322011-05-21 Glenn Morris <rgm@gnu.org>
11733
11734 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11735 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11736 and add some more files.
32078c8d 11737
7285dc67
EZ
117382011-05-20 Eli Zaretskii <eliz@gnu.org>
11739
11740 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11741 report_file_error introduced by the change from 2011-05-07.
11742
89d1bd22
PE
117432011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11744
11745 * systime.h (Time): Define only if emacs is defined.
11746 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11747 where the include path doesn't have X11/X.h by default. See
11748 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11749
cd394be1 117502011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11751
11752 * composite.c (find_automatic_composition): Fix previous change.
11753
b9704ad9
GM
117542011-05-20 Glenn Morris <rgm@gnu.org>
11755
11756 * lisp.mk: New file, split from Makefile.in.
11757 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11758 (shortlisp): Remove.
11759 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11760
4a720484
GM
117612011-05-19 Glenn Morris <rgm@gnu.org>
11762
11763 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11764 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11765 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11766 (lisp): Set the order to that of loadup.el.
11767 (shortlisp): Make it a copy of $lisp.
11768 (SOME_MACHINE_LISP): Remove.
11769 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11770 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11771
a28d4396
KH
117722011-05-18 Kenichi Handa <handa@m17n.org>
11773
11774 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11775 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11776 (find_automatic_composition): Mostly rewrite for efficiency.
11777
a2b1fa8e
JB
117782011-05-18 Juanma Barranquero <lekktu@gmail.com>
11779
11780 * makefile.w32-in: Update dependencies.
11781
8e1f5610
CS
117822011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11783
11784 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11785 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11786
7025ee00 117872011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11788
cdfa6eab
PE
11789 Fix some integer overflow issues, such as string length overflow.
11790
06d6db33
PE
11791 * insdel.c (count_size_as_multibyte): Check for string overflow.
11792
2b4560a8
PE
11793 * character.c (lisp_string_width): Check for string overflow.
11794 Use EMACS_INT, not int, for string indexes and lengths; in
11795 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11796 the resulting string length overflows an EMACS_INT; instead,
11797 report a string overflow if no precision given. When checking for
11798 precision exhaustion, use a check that cannot possibly have
11799 integer overflow. (Bug#8675)
11800 * character.h (lisp_string_width): Adjust to new signature.
11801
cb93f9be
PE
11802 * alloc.c (string_overflow): New function.
11803 (Fmake_string): Use it. This doesn't change behavior, but saves
11804 a few bytes and will simplify future changes.
11805 * character.c (string_escape_byte8): Likewise.
11806 * lisp.h (string_overflow): New decl.
11807
1a1f3366
PE
11808 Fixups, following up to the user-interface timestamp change.
11809 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11810 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11811 * msdos.c (mouse_get_pos): Likewise.
11812 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11813 * w32gui.h (Time): Define by including "systime.h" rather than by
11814 declaring it ourselves. (Bug#8664)
11815
d4e3e4d3
PE
11816 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11817 * image.c (clear_image_cache): Likewise.
11818
f6a24d19
PE
11819 * term.c (term_mouse_position): Don't assume time_t wraparound.
11820
08dc5ae6
PE
11821 Be more systematic about user-interface timestamps.
11822 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11823 and sometimes 'EMACS_UINT', to represent these timestamps.
11824 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11825 This makes the code easier to follow, and makes it easier to catch
11826 integer overflow bugs such as Bug#8664.
11827 * frame.c (Fmouse_position, Fmouse_pixel_position):
11828 Use Time, not unsigned long, for user-interface timestamps.
11829 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11830 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11831 * keyboard.h (last_event_timestamp): Likewise.
11832 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11833 * menu.h (xmenu_show): Likewise.
11834 * term.c (term_mouse_position): Likewise.
11835 * termhooks.h (struct input_event.timestamp): Likewise.
11836 (struct terminal.mouse_position_hook): Likewise.
11837 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11838 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11839 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11840 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11841 what it was before.
11842 * menu.h, termhooks.h: Include "systime.h", for Time.
11843
8e55734a
PE
11844 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11845 Don't assume that the difference between two unsigned long values
11846 can fit into an integer. At this point, we know button_down_time
11847 <= event->timestamp, so the difference must be nonnegative, so
11848 there's no need to cast the result if double-click-time is
11849 nonnegative, as it should be; check that it's nonnegative, just in
11850 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11851 apart (about 25 days). (Bug#8664)
8e55734a 11852
841f1b75 11853 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11854 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11855
3e26f69c
PE
11856 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11857 that always fit in int. Use a sentinel instead of a counter, to
11858 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11859 * frame.h (struct frame): Use int for menu_bar_items_used
11860 instead of EMACS_INT, since it always fits in int.
3e26f69c 11861
5cc152c0
PE
11862 * menu.c (grow_menu_items): Check for int overflow.
11863
d89eb65e
PE
11864 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11865
5235bd3e
PE
11866 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11867 Before, the code was not consistent. These values cannot exceed
11868 2**31 - 1 so there's no need to make them unsigned.
11869 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11870 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11871 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11872 as modifiers.
11873 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11874
bc827e23
PE
11875 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11876 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11877 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11878 presumably because the widths might not match.
11879
78eb494e
PE
11880 * window.c (size_window): Avoid needless test at loop start.
11881
04f2d78b
CB
118822011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11883
11884 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11885
d2fc7e3d 118862011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11887
11888 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11889
d2fc7e3d 118902011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11891
11892 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11893 `width' to `bar_area_x' and `bar_area_width', respectively.
11894 (x_scroll_run): Take account of fringe background extension.
11895
04f2d78b
CB
11896 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11897 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11898 `bar_area_width', respectively.
11899 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11900 background extension.
11901
79b70037
GM
119022011-05-10 Jim Meyering <meyering@redhat.com>
11903
11904 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11905
2f142cc5
JB
119062011-05-10 Juanma Barranquero <lekktu@gmail.com>
11907
11908 * image.c (Finit_image_library): Return t for built-in image types,
11909 like pbm and xbm. (Bug#8640)
11910
57679c86
AS
119112011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11912
11913 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11914
888c9e86
EZ
119152011-05-07 Eli Zaretskii <eliz@gnu.org>
11916
b0512a1d
EZ
11917 * w32console.c (Fset_screen_color): Doc fix.
11918 (Fget_screen_color): New function.
11919 (syms_of_ntterm): Defsubr it.
11920
7285dc67
EZ
11921 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11922 unlink the temporary file if Fcall_process didn't create it in the
11923 first place.
11924 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11925 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11926 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11927 cue to call_process_cleanup not to close that handle.
11928
4d3fcc8e
BK
119292011-05-07 Ben Key <bkey76@gmail.com>
11930
11931 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11932 one of two shell specific rules, either bootstrap-temacs-CMD or
11933 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11934 to the previous implementation of the bootstrap-temacs rule.
11935 The bootstrap-temacs-CMD rule is similar to the previous
11936 implementation of the bootstrap-temacs rule except that it
11937 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11938 variable.
11939
11940 These changes, along with some changes to nt/configure.bat,
11941 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11942 earlier fix to add support for --cflags and --ldflags options
11943 that include quotes so that it works whether make uses cmd or
11944 sh as the shell.
11945
b4289b64
MA
119462011-05-06 Michael Albinus <michael.albinus@gmx.de>
11947
11948 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11949 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11950 is a constant.
11951 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11952 a string. Handle both cases.
11953 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11954 (Fdbus_register_method): Use Qinvalid_function.
11955
af4c0e28
JB
119562011-05-06 Juanma Barranquero <lekktu@gmail.com>
11957
11958 * makefile.w32-in: Update dependencies.
11959 (LISP_H): Add inttypes.h and stdin.h.
11960 (PROCESS_H): Add unistd.h.
11961
c51453d9
EZ
119622011-05-06 Eli Zaretskii <eliz@gnu.org>
11963
11964 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11965 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11966
8ff0ac3c 119672011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11968
4c4b566b
PE
11969 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11970
aab2b9b5
PE
11971 * term.c (vfatal): Remove stray call to va_end.
11972 It's not needed and the C Standard doesn't allow it here anyway.
11973
c378da0b
PE
11974 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11975 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11976
288b08c7
PE
11977 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11978 bytes.
11979
e3601888
PE
11980 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11981
db6c0e74
PE
11982 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11983
dd5963ea
PE
11984 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11985
88c9450f
PE
11986 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11987
2f9442b8
PE
11988 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11989
c032b5f8
PE
11990 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11991 * charset.c (Fdefine_charset_internal): Don't initialize
11992 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11993 32-bit int (Bug#8600).
a108c10b
PE
11994
11995 * lread.c (read_integer): Be more consistent with string-to-number.
11996 Use string_to_number to do the actual conversion; this avoids
11997 rounding errors and fixes some other screwups. Without this fix,
11998 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11999 (digit_to_number): Move earlier, for benefit of read_integer.
12000 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12001 not a digit in any supported base. (Bug#8602)
a108c10b 12002
ad5f9eea
PE
12003 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12004
aec1708a
PE
12005 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12006 to match comment at start of function. This also removes a
12007 GCC warning about overflow in a 32+64-bit port.
12008
47be4ab5
PE
12009 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12010
371cac43
PE
12011 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12012 Reported by Stefan Monnier in
12013 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12014 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12015 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12016
d01a7826
PE
12017 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12018 (EMACS_UINTPTR): Likewise, with uintptr_t.
12019
7fd47d5c
PE
12020 * lisp.h: Prefer 64-bit EMACS_INT if available.
12021 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12022 on 32-bit hosts that have 64-bit int, so that they can access
12023 large files.
122b0c86
PE
12024 However, temporarily disable this change unless the temporary
12025 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12026
8727937b
PE
12027 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12028
8ac068ac
PE
12029 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12030 This removes an assumption that EMACS_INT and long are the same
12031 width as pointers. The assumption is true for Emacs porting targets
12032 now, but we want to make other targets possible.
12033 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12034 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12035 In the rest of the code, change types of integers that hold casted
12036 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12037 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12038 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12039 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12040 No need to cast type when ORing.
12041 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12042 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12043 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12044 assume EMACS_INT is the same width as char *.
12045 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12046 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12047 Remove no-longer-needed casts.
12048 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12049 (xg_tool_bar_help_callback, xg_make_tool_item):
12050 Use EMACS_INTPTR to hold an integer
12051 that will be cast to void *; this can avoid a GCC warning
12052 if EMACS_INT is not the same width as void *.
12053 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12054 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12055 (current_message_1, set_message_1):
12056 Use a local to convert to proper width without a cast.
12057 * xmenu.c (dialog_selection_callback): Likewise.
12058
ede49d71
PE
12059 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12060 Also, don't assume VALBITS / RAND_BITS is less than 5,
12061 and don't rely on undefined behavior when shifting a 1 left into
12062 the sign bit.
12063 * lisp.h (get_random): Change signature to match.
12064
2f30ecd0
PE
12065 * lread.c (hash_string): Use size_t, not int, for hash computation.
12066 Normally we prefer signed values; but hashing is special, because
12067 it's better to use unsigned division on hash table sizes so that
12068 the remainder is nonnegative. Also, size_t is the natural width
12069 for hashing into memory. The previous code used 'int', which doesn't
12070 retain enough info to hash well into very large tables.
12071 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12072
2a866e7b
PE
12073 * dbusbind.c: Don't possibly lose pointer info when converting.
12074 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12075 Use XPNTR rather than XHASH, so that the high-order bits of
12076 the pointer aren't lost when converting through void *.
12077
51639eac
PE
12078 * eval.c (Fautoload): Don't double-shift a pointer.
12079
92394119
PE
12080 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12081
dbdb9a7c
JB
120822011-05-06 Juanma Barranquero <lekktu@gmail.com>
12083
12084 * gnutls.c (DEF_GNUTLS_FN):
12085 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12086
db7a0b4f
AS
120872011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12088
12089 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12090 marker. (Bug#8610)
12091
cd394be1 120922011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12093
12094 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12095 New version that can reserve upto 2GB of heap space.
12096
f7ff1b0f 120972011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12098
12099 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12100
639c109b
TZ
121012011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12102
12103 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12104 `gnutls_certificate_set_x509_key_file'.
12105
d2127135
JB
121062011-05-05 Juanma Barranquero <lekktu@gmail.com>
12107
12108 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12109 Update dependencies.
12110
e968f4f3
JB
121112011-05-04 Juanma Barranquero <lekktu@gmail.com>
12112
12113 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12114 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12115 Remove unused parameter `fildes'.
12116 * process.c (read_process_output, send_process): Don't pass it.
12117
84d358f0
JB
121182011-05-04 Juanma Barranquero <lekktu@gmail.com>
12119
12120 Fix previous change: the library cache is defined in w32.c.
12121 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12122 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12123
0898ca10
JB
121242011-05-04 Juanma Barranquero <lekktu@gmail.com>
12125
12126 Implement dynamic loading of GnuTLS on Windows.
12127
12128 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12129 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12130 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12131 Declare.
12132
12133 * gnutls.c (Qgnutls_dll): Define.
12134 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12135 (gnutls_*): Declare function pointers.
12136 (init_gnutls_functions): New function to initialize function pointers.
12137 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12138 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12139 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12140 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12141 (emacs_gnutls_write, emacs_gnutls_read)
12142 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12143 (Fgnutls_available_p): New function.
12144 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12145 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12146 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12147
12148 * image.c: Include w32.h.
12149 (Vimage_type_cache): Delete.
12150 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12151 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12152 (w32_delayed_load): Move to w32.c.
12153
12154 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12155
12156 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12157 (w32_delayed_load): Move from image.c. When loading a library, record
12158 its filename in the :loaded-from property of the library id.
12159 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12160 Initialize and staticpro them.
12161 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12162
12163 * process.c: Include lisp.h before w32.h, not after.
12164 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12165 instead of gnutls_record_check_pending.
12166
12167 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12168
ff4de4aa
TZ
121692011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12170
12171 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12172 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12173 as passed in.
12174
abe95abb
JD
121752011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12176
12177 * xterm.c (x_set_frame_alpha): Do not set property on anything
12178 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12179
e16e55d4
JB
121802011-05-02 Juanma Barranquero <lekktu@gmail.com>
12181
12182 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12183
bafcf6a5
JB
121842011-05-02 Juanma Barranquero <lekktu@gmail.com>
12185
12186 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12187 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12188 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12189 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12190 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12191 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12192 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12193 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12194 (Qgnutls_bootprop_callbacks_verify): Make static.
12195
e7a6747f
AS
121962011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12197
19ed11ba
AS
12198 * callproc.c: Indentation fixup.
12199
e7a6747f 12200 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12201 (wait_for_termination, interruptible_wait_for_termination):
12202 Move after wait_for_termination_1.
e7a6747f 12203
1ef14cb4
LMI
122042011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12205
12206 * sysdep.c (interruptible_wait_for_termination): New function
12207 which is like wait_for_termination, but allows keyboard
12208 interruptions.
12209
12210 * callproc.c (Fcall_process): Add (:file "file") as an option for
12211 the STDOUT buffer.
12212 (Fcall_process_region): Ditto.
12213
330d880c
EZ
122142011-04-30 Eli Zaretskii <eliz@gnu.org>
12215
8db90b73
EZ
12216 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12217 rather than `XVECTOR (FOO)->size'.
12218
330d880c
EZ
12219 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12220 inttypes.h, as a gnulib replacement is used if it not available in
12221 system headers.
12222
15cbd324
EZ
122232011-04-21 Eli Zaretskii <eliz@gnu.org>
12224
12225 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12226 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12227 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12228
12229 * coding.c (coding_alloc_by_realloc): Error out if destination
12230 will grow beyond MOST_POSITIVE_FIXNUM.
12231 (decode_coding_emacs_mule): Abort if there isn't enough place in
12232 charbuf for the composition carryover bytes. Reserve an extra
12233 space for up to 2 characters produced in a loop.
12234 (decode_coding_iso_2022): Abort if there isn't enough place in
12235 charbuf for the composition carryover bytes.
12236
122372011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12238
ae940cca
EZ
12239 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12240 aborting when %lld or %lll format is passed.
12241 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12242 %llo or %llx format is passed. (Bug#8545)
12243
03ab8921
EZ
12244 * window.c (window_scroll_line_based): Use a marker instead of
12245 simple variables to record original value of point. (Bug#7952)
12246
afda1437
EZ
12247 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12248 produced by %s or %c overflows available buffer space. (Bug#8545)
12249
f76dee0c
PE
122502011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12251
12252 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12253 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12254
fdc5744d
JB
122552011-04-28 Juanma Barranquero <lekktu@gmail.com>
12256
12257 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12258
638f053a
JB
122592011-04-28 Juanma Barranquero <lekktu@gmail.com>
12260
12261 * keyboard.c (Qdelayed_warnings_hook): Define.
12262 (command_loop_1): Run `delayed-warnings-hook'
12263 if Vdelayed_warnings_list is non-nil.
12264 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12265 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12266
d178f871
EZ
122672011-04-28 Eli Zaretskii <eliz@gnu.org>
12268
12269 * doprnt.c (doprnt): Don't return value smaller than the buffer
12270 size if the message was truncated. (Bug#8545).
12271
b124fd93
JB
122722011-04-28 Juanma Barranquero <lekktu@gmail.com>
12273
12274 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12275 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12276
e810457d
PE
122772011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12278
12279 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12280
ea51cceb
JB
122812011-04-27 Juanma Barranquero <lekktu@gmail.com>
12282
12283 * makefile.w32-in: Update dependencies.
12284
94dcfacf
EZ
122852011-04-27 Eli Zaretskii <eliz@gnu.org>
12286
12287 Improve `doprnt' and its usage. (Bug#8545)
12288 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12289 `format_end'. Remove support for %l as a conversion specifier.
12290 Don't use xrealloc. Improve diagnostics when the %l size modifier
12291 is used. Update the commentary.
12292
12293 * eval.c (verror): Simplify calculation of size_t.
12294
12295 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12296 messages.
12297
f61f41d7
PE
122982011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12299
12300 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12301 change.
12302
96fb4434
PE
123032011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12304
12305 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12306 This makes this file independent of the recent pseudovector change.
12307
671875da 123082011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12309
69e9b5a3
PE
12310 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12311
b5f869a7 12312 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12313 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12314 Remove unused local.
c8926152 12315 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12316
841a1577 12317 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12318 GCC 4.6.0 optimizes based on type-based alias analysis.
12319 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12320 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12321 != &v->size, and therefore "v->size = 1; b->size = 2; return
12322 v->size;" must therefore return 1. This assumption is incorrect
12323 for Emacs, since it type-puns struct Lisp_Vector * with many other
12324 types. To fix this problem, this patch adds a new type struct
f904488f 12325 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12326 and pseudovectors, and helps optimizing compilers not get fooled
12327 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12328 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12329 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12330 the size member.
eab3844f
PE
12331 (XSETPVECTYPE): Rewrite in terms of new macro.
12332 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12333 This is a bit clearer, and further avoids the possibility of
12334 undesirable aliasing.
12335 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12336 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12337 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12338 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12339 (ASIZE): Now uses header.size rather than size.
12340 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12341 to avoid the hassle of writing XVECTOR (foo)->header.size.
12342 (struct vectorlike_header): New type.
eab3844f
PE
12343 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12344 object, to help avoid aliasing.
12345 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12346 (SUBRP): Likewise, since Lisp_Subr is a special case.
12347 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12348 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12349 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12350 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12351 changed to be "header.size" and "header.next".
12352 * buffer.h (struct buffer): Likewise.
12353 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12354 * frame.h (struct frame): Likewise.
12355 * process.h (struct Lisp_Process): Likewise.
12356 * termhooks.h (struct terminal): Likewise.
12357 * window.c (struct save_window_data, struct saved_window): Likewise.
12358 * window.h (struct window): Likewise.
12359 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12360 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12361 * buffer.c (init_buffer_once): Likewise.
12362 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12363 special case.
12364 * process.c (Fformat_network_address): Use local var for size,
12365 for brevity.
12366
0df1eac5
PE
12367 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12368
847ab9d1 12369 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12370 * data.c (atof): Remove decl; no longer used or needed.
12371 (digit_to_number): Move to lread.c.
12372 (Fstring_to_number): Use new string_to_number function, to be
12373 consistent with how the Lisp reader treats infinities and NaNs.
12374 Do not assume that floating-point numbers represent EMACS_INT
12375 without losing information; this is not true on most 64-bit hosts.
12376 Avoid double-rounding errors, by insisting on integers when
12377 parsing non-base-10 numbers, as the documentation specifies.
12378 * lisp.h (string_to_number): New decl, replacing ...
12379 (isfloat_string): Remove.
bc0a5c13 12380 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12381 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12382 appears to have been a coding error. Similarly, do not accept
12383 strings like +-1e0 as floating point numbers. Do not report
12384 overflow for integer overflows unless the base is not 10 which
12385 means we have no simple and reliable way to continue.
12386 Break out the floating-point parsing into a new
12387 function string_to_number, so that Fstring_to_number parses
12388 floating point numbers consistently with the Lisp reader.
04f2d78b 12389 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12390 (E_CHAR, EXP_INT): Remove, replacing with ...
12391 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12392 (string_to_number): New function, replacing isfloat_string.
12393 This function checks for valid syntax and produces the resulting
12394 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12395 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12396 so that overflow for non-base-10 numbers is reported only when
12397 there's no portable and simple way to convert to floating point.
452f4150 12398
67769ffc
PE
12399 * textprop.c (set_text_properties_1): Rewrite for clarity,
12400 and to avoid GCC warning about integer overflow.
12401
c20db43f
PE
12402 * intervals.h (struct interval): Use EMACS_INT for members
12403 where EMACS_UINT might cause problems. See
12404 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12405 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12406 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12407 All uses changed.
37aa2f85
PE
12408 (offset_intervals): Tell GCC not to worry about length overflow
12409 when negating a negative length.
c20db43f 12410
2538aa2f
PE
12411 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12412 (overrun_check_free): Likewise.
12413
f2d3008d
PE
12414 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12415 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12416 word size.
12417
ec8df744
PE
12418 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12419 (gnutls_make_error): Rename local to avoid shadowing.
12420 (gnutls_emacs_global_deinit): ifdef out; not used.
12421 (Fgnutls_boot): Use const for pointer to readonly storage.
12422 Comment out unused local. Fix pointer signedness problems.
12423
640ee02d
PE
12424 * lread.c (openp): Don't stuff size_t into an 'int'.
12425 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12426 about possible signed overflow.
12427
6048fb2a
PE
12428 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12429 (GDK_KEY_g): Don't define if already defined.
12430 (xg_prepare_tooltip): Avoid pointer signedness problem.
12431 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12432
fa3c87e1
PE
12433 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12434 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12435
2172544b
PE
12436 * xfns.c (Fx_window_property): Simplify a bit,
12437 to make a bit faster and to avoid GCC 4.6.0 warning.
12438 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12439
9b821a21
PE
12440 * fns.c (internal_equal): Don't assume size_t fits in int.
12441
3c616cfa
PE
12442 * alloc.c (compact_small_strings): Tighten assertion a little.
12443
c2982e87
PE
12444 Replace pEd with more-general pI, and fix some printf arg casts.
12445 * lisp.h (pI): New macro, generalizing old pEd macro to other
12446 conversion specifiers. For example, use "...%"pI"d..." rather
12447 than "...%"pEd"...".
12448 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12449 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12450 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12451 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12452 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12453 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12454 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12455 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12456 64-bit hosts.
12457 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12458 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12459 * print.c (safe_debug_print, print_object): Likewise.
12460 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12461 to int.
6f04d126
PE
12462 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12463 avoiding the 0 flag, which is not portable.
c2982e87
PE
12464 * process.c (Fmake_network_process): Use pI to avoid cast.
12465 * region-cache.c (pp_cache): Likewise.
12466 * xdisp.c (decode_mode_spec): Likewise.
12467 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12468 behavior on 64-bit hosts with printf arg.
6f04d126 12469 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12470 (x_stop_queuing_selection_requests): Likewise.
12471 (x_get_window_property): Don't truncate byte count to an 'int'
12472 when tracing.
0b432f21 12473
5e073ec7
PE
12474 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12475 here, since it parses constructs like leading '-' and spaces,
12476 which are not wanted; and it overflows with large numbers.
12477 Instead, simply match F[0-9]+, which is what is wanted anyway.
12478
36372bf9
PE
12479 * alloc.c: Remove unportable assumptions about struct layout.
12480 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12481 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12482 (allocate_vectorlike, make_pure_vector): Use the new macros,
12483 plus offsetof, to remove unportable assumptions about struct layout.
12484 These assumptions hold on all porting targets that I know of, but
12485 they are not guaranteed, they're easy to remove, and removing them
12486 makes further changes easier.
12487
0b432f21
PE
12488 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12489 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12490 (string_overrun_cookie): Now const. Use initializers that
12491 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12492 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12493 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12494 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12495 multiple of sizeof (EMACS_INT); it need not be, if
12496 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12497 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12498
895009e1
JB
124992011-04-26 Juanma Barranquero <lekktu@gmail.com>
12500
12501 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12502
6a7a1b0b
TZ
125032011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12504
12505 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12506 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12507 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12508
841a1577 125092011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12510
12511 * lisp.h (Qdebug): List symbol.
895009e1 12512 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12513 * keyboard.c (debug-on-event): New variable.
12514 (handle_user_signal): Break into debugger when debug-on-event
12515 matches the current signal symbol.
12516
f2d3ba6f
DN
125172011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12518
12519 * alloc.c (check_sblock, check_string_bytes)
12520 (check_string_free_list): Convert to standard C.
12521
42ce4c63
TZ
125222011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12523
12524 * w32.c (emacs_gnutls_push): Fix typo.
12525
825cd63c
EZ
125262011-04-25 Eli Zaretskii <eliz@gnu.org>
12527
fb11d64d
EZ
12528 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12529 "cast to pointer from integer of different size".
12530
825cd63c
EZ
12531 Improve doprnt and its use in verror. (Bug#8545)
12532 * doprnt.c (doprnt): Document the set of format control sequences
12533 supported by the function. Use SAFE_ALLOCA instead of always
12534 using `alloca'.
12535
12536 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12537 is one byte too soon. Don't use xrealloc; instead xfree and
12538 xmalloc anew.
12539
e061a11b
TZ
125402011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12541
12542 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12543 callbacks stage.
12544
12545 * gnutls.c: Renamed global_initialized to
12546 gnutls_global_initialized. Added internals for the
12547 :verify-hostname-error, :verify-error, and :verify-flags
12548 parameters of `gnutls-boot' and documented those parameters in the
12549 docstring. Start callback support.
9173deec
JB
12550 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12551 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12552 on error. Return error code.
e061a11b
TZ
12553 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12554 (emacs_gnutls_read): Likewise.
12555 (Fgnutls_boot): Return handshake error code.
12556 (emacs_gnutls_handle_error): New function.
12557 (wsaerror_to_errno): Likewise.
12558
12559 * w32.h (emacs_gnutls_pull): Add prototype.
12560 (emacs_gnutls_push): Likewise.
12561
12562 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12563 (emacs_gnutls_push): Likewise.
12564
125652011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12566
12567 * process.c (wait_reading_process_output): Check if GnuTLS
12568 buffered some data internally if no FDs are set for TLS
12569 connections.
12570
12571 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12572 (LIBS): Link to USER_LIBS.
12573 ($(BLD)/gnutls.$(0)): New target.
12574
fa6996bc
EZ
125752011-04-24 Eli Zaretskii <eliz@gnu.org>
12576
eb35682e
EZ
12577 * xdisp.c (handle_single_display_spec): Rename the
12578 display_replaced_before_p argument into display_replaced_p, to
12579 make it consistent with the commentary. Fix typos in the
12580 commentary.
12581
e2ad650c
EZ
12582 * textprop.c (syms_of_textprop): Remove dead code.
12583 (copy_text_properties): Delete obsolete commentary about an
12584 interface that was deleted long ago. Fix typos in the description
12585 of arguments.
12586
1b2de274
EZ
12587 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12588 to changes in oldXMenu/XMenu.h from 2011-04-16.
12589 <menu_help_message, prev_menu_help_message>: Constify.
12590 (IT_menu_make_room): menu->help_text is now `const char **';
12591 adjust.
12592
12593 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12594 to changes in oldXMenu/XMenu.h from 2011-04-16.
12595 (struct XMenu): Declare `help_text' `const char **'.
12596
12597 * xfaces.c <Qunspecified>: Make extern again.
12598
12599 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12600 required by POSIX.
1b2de274 12601
762b15be
EZ
12602 * doc.c (get_doc_string): Improve the format passed to `error'.
12603
12604 * doprnt.c (doprnt): Improve commentary.
12605
12606 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12607
12608 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12609 them with etags.
12610
f1052e5d
EZ
12611 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12612 changes in globals.h immediately force recompilation.
762b15be
EZ
12613 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12614 $(CURDIR)/s/ms-w32.h.
12615 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12616
fa6996bc
EZ
12617 * character.c (Fchar_direction): Function deleted.
12618 (syms_of_character): Don't defsubr it.
12619 <char-direction-table>: Deleted.
12620
e6c3da20
EZ
126212011-04-23 Eli Zaretskii <eliz@gnu.org>
12622
12623 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12624 * doprnt.c: Include limits.h.
12625 (SIZE_MAX): New macro.
04f2d78b
CB
12626 (doprnt): Return a size_t value. 2nd arg is now size_t.
12627 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12628 Improve overflow protection. Support `l' modifier for integer
12629 conversions. Support %l conversion. Don't assume an EMACS_INT
12630 argument for integer conversions and for %c.
12631
12632 * lisp.h (doprnt): Restore prototype.
12633
12634 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12635 $(SRC)/character.h.
12636
12637 * Makefile.in (base_obj): Add back doprnt.o.
12638
12639 * deps.mk (doprnt.o): Add back prerequisites.
12640 (callint.o): Depend on character.h.
12641
12642 * eval.c (internal_lisp_condition_case): Include the handler
12643 representation in the error message.
12644 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12645 when breaking from the loop.
12646
12647 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12648
12649 * callint.c (Fcall_interactively): When displaying error message
12650 about invalid control letter, pass the character's codepoint, not
12651 a pointer to its multibyte form. Improve display of the character
12652 in octal and display also its hex code.
12653
12654 * character.c (char_string): Use %x to display the (unsigned)
12655 codepoint of an invalid character, to avoid displaying a bogus
12656 negative value.
12657
12658 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12659 `error', not SYMBOL_NAME itself.
12660
12661 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12662 character arguments to `error'.
12663
12664 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12665 to `error' in error message about FINAL_CHAR argument. Make sure
12666 FINAL_CHAR is a character, and use %c when it is passed as
12667 argument to `error'.
12668
4ffd0d6b 126692011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12670
12671 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12672
12673 * w32.c: Include <time.h>.
12674 (sys_localtime): New function.
12675
4ffd0d6b 126762011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12677
12678 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12679
4ffd0d6b 12680 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12681
4ffd0d6b 126822011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12683
4ffd0d6b
GM
12684 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12685 zombies (Bug#8467).
aac0c6e3 12686
04c56954
EZ
126872011-04-19 Eli Zaretskii <eliz@gnu.org>
12688
12689 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12690 gl_state.e_property when gl_state.object is Qt.
12691
12692 * insdel.c (make_gap_larger): Remove limitation of buffer size
12693 to <= INT_MAX.
12694
16a43933
CY
126952011-04-18 Chong Yidong <cyd@stupidchicken.com>
12696
12697 * xdisp.c (lookup_glyphless_char_display)
12698 (produce_glyphless_glyph): Handle cons cell entry in
12699 glyphless-char-display.
12700 (Vglyphless_char_display): Document it.
12701
12702 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12703 glyphless-char-display.
12704
4581706e
CY
127052011-04-17 Chong Yidong <cyd@stupidchicken.com>
12706
12707 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12708
12709 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12710
12711 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12712 definition for no-X builds.
12713
4887c6e2 127142011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12715
fd35b6f9
PE
12716 Static checks with GCC 4.6.0 and non-default toolkits.
12717
5c1ccb01
PE
12718 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12719
006c5daa
PE
12720 * process.c (keyboard_bit_set): Define only if SIGIO.
12721 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12722 (send_process): Repair possible setjmp clobbering.
12723
efc736d3
PE
12724 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12725
4e2fe2e6
PE
12726 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12727
f97334a2
PE
12728 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12729
4e75f29d
PE
12730 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12731 Define only if needed.
12732
90efadd1
PE
12733 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12734 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12735 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12736
3c647824
PE
12737 * dispextern.h (struct redisplay_interface): Rename param
12738 to avoid shadowing.
e264f262 12739 * termhooks.h (struct terminal): Likewise.
761383f4 12740 * xterm.c (xembed_send_message): Likewise.
3c647824 12741
b58c5c4a
PE
12742 * insdel.c (make_gap_smaller): Define only if
12743 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12744
cad59032
PE
12745 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12746 it.
12747
c339dc2e
PE
12748 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12749 so that we aren't warned about unused symbols.
12750
91a3e27b
PE
12751 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12752
399c71d3 12753 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12754
8ffc96f5
PE
12755 * xfns.c (x_real_positions): Mark locals as initialized.
12756
eef9bc79
PE
12757 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12758
098db9dd
PE
12759 * xterm.c: Fix problems found by static analysis with other toolkits.
12760 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12761 (x_dispatch_event): Declare static if USE_GTK, and
12762 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12763 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12764 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12765 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12766 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12767
eb18f6cc
PE
12768 * xmenu.c (menu_help_callback): Pointer type fixes.
12769 Use const pointers when pointing at readonly data. Avoid pointer
12770 signedness clashes.
12771 (FALSE): Remove unused macro.
12772 (update_frame_menubar): Remove unused decl.
12773
1fe72bf8
PE
12774 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12775
60d9e1db
PE
12776 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12777 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12778 (single_menu_item): Rename local to avoid shadowing.
12779
39261c26
PE
12780 * keyboard.c (make_lispy_event): Remove unused local var.
12781
018c5e19
PE
12782 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12783 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12784
63d2b86e
PE
12785 * bitmaps: Change bitmaps from unsigned char back to the X11
12786 compatible char. Avoid the old compiler warnings about
12787 out-of-range initializers by using, for example, '\xab' rather
12788 than 0xab.
12789
aefd87e1
PE
12790 * xgselect.c (xgselect_initialize): Check vs interface
12791 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12792
bf501fb9
PE
12793 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12794
e9829fdf
PE
12795 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12796 to read-only memory.
12797
1086c095
PE
12798 * fns.c (vector): Remove; this old hack is no longer needed.
12799
2baccd04 12800 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12801 Remove unused var.
dde42981 12802 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12803
72391843 12804 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12805
436c16df 12806 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12807 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12808 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12809
92bb796d 12810 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12811 (x_term_init): Remove local to avoid shadowing.
92bb796d 12812
764430a3 12813 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12814
12815 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12816 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12817
d1dfb56c
EZ
128182011-04-16 Eli Zaretskii <eliz@gnu.org>
12819
c4354cb4
EZ
12820 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12821
d1dfb56c
EZ
12822 Fix regex.c, syntax.c and friends for buffers > 2GB.
12823 * syntax.h (struct gl_state_s): Declare character position members
12824 EMACS_INT.
12825
12826 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12827
04f2d78b
CB
12828 * textprop.c (verify_interval_modification, interval_of):
12829 Declare arguments EMACS_INT.
d1dfb56c
EZ
12830
12831 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12832 EMACS_INT.
12833
12834 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12835
12836 * indent.c (Fvertical_motion): Local variable it_start is now
12837 EMACS_INT.
12838
12839 * regex.c (re_match, re_match_2, re_match_2_internal)
12840 (bcmp_translate, regcomp, regexec, print_double_string)
12841 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12842 (re_compile_pattern, re_exec): Declare arguments and local
12843 variables `size_t' and `ssize_t' and return values `regoff_t', as
12844 appropriate.
12845 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12846 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12847 <compile_stack_type>: `size' and `avail' are now `size_t'.
12848
12849 * regex.h <regoff_t>: Use ssize_t, not int.
12850 (re_search, re_search_2, re_match, re_match_2): Arguments that
12851 specify buffer/string position and length are now ssize_t and
12852 size_t. Return type is regoff_t.
12853
613052cd
BK
128542011-04-16 Ben Key <bkey76@gmail.com>
12855
12856 * nsfont.m: Fixed bugs in ns_get_family and
12857 ns_descriptor_to_entity that were caused by using free to
12858 deallocate memory blocks that were allocated by xmalloc (via
12859 xstrdup). This caused Emacs to crash when compiled with
12860 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12861 --enable-checking=xmallocoverrun). xfree is now used to
12862 deallocate these memory blocks.
12863
4170f62f 128642011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12865
71b41406
PE
12866 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12867
9587a89d
PE
12868 emacs_write: Accept and return EMACS_INT for sizes.
12869 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12870 et seq.
12871 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12872 Accept and return EMACS_INT.
12873 (emacs_gnutls_write): Return the number of bytes written on
12874 partial writes.
12875 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12876 (emacs_read, emacs_write): Remove check for negative size, as the
12877 Emacs source code has been audited now.
9587a89d
PE
12878 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12879 (emacs_read, emacs_write): Use it.
273a5f82
PE
12880 * process.c (send_process): Adjust to the new signatures of
12881 emacs_write and emacs_gnutls_write. Do not attempt to store
12882 a byte offset into an 'int'; it might overflow.
9587a89d 12883 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12884
3e047f51
PE
12885 * sound.c: Don't assume sizes fit in 'int'.
12886 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12887 Return EMACS_INT, not int.
3e047f51 12888 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12889 Accept EMACS_INT, not int.
12890 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12891 record read return values.
12892
cc39a9db
BK
128932011-04-15 Ben Key <bkey76@gmail.com>
12894
c9d0ec6d
JB
12895 * keyboard.c (Qundefined): Don't declare static since it is used
12896 in nsfns.m.
12897 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12898 static since they are used in nsfont.m.
cc39a9db 12899
6c60eb9f
SM
129002011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12901
12902 * process.c (Qprocessp): Don't declare static.
12903 * lisp.h (Qprocessp): Declare again.
12904
7990b61a
JB
129052011-04-15 Juanma Barranquero <lekktu@gmail.com>
12906
12907 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12908
5d4cb038
PE
129092011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12910
8bd7b830 12911 Improve C-level modularity by making more things 'static'.
cd64ea1d 12912
e3b27b31
PE
12913 Don't publish debugger-only interfaces to other modules.
12914 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12915 (verify_bytepos, count_markers): Move decls to the only modules
12916 that need them.
12917 * region-cache.h (pp_cache): Likewise.
12918 * window.h (check_all_windows): Likewise.
12919 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12920
5d4cb038
PE
12921 * sysdep.c (croak): Now static, if
12922 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12923 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12924
12925 * alloc.c (refill_memory_reserve): Now static if
12926 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12927 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12928
e87b6180
PE
12929 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12930 Define only if USE_LUCID.
12931
ac64929e
PE
12932 * xrdb.c (x_customization_string, x_rm_string): Now static.
12933
6f37259d
PE
12934 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12935 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12936
1683e3ab
PE
12937 * xdisp.c (draw_row_with_mouse_face): Now static.
12938 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12939
de9c2632
PE
12940 * window.h (check_all_windows): Mark externally visible.
12941
2b96acb7
PE
12942 * window.c (window_deletion_count): Now static.
12943
12944 * undo.c: Make symbols static if they're not exported.
12945 (last_undo_buffer, last_boundary_position, pending_boundary):
12946 Now static.
12947
50436f33
PE
12948 * textprop.c (interval_insert_behind_hooks): Now static.
12949 (interval_insert_in_front_hooks): Likewise.
12950
64520e5c
PE
12951 * term.c: Make symbols static if they're not exported.
12952 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12953 (max_frame_lines, tty_set_terminal_modes):
12954 (tty_reset_terminal_modes, tty_turn_off_highlight):
12955 (get_tty_terminal): Now static.
12956 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12957 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12958 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12959 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12960 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12961
1fa53021
PE
12962 * sysdep.c: Make symbols static if they're not exported.
12963 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12964 Now static.
12965 (sigprocmask_set, full_mask): Remove; unused.
12966 (wait_debugging): Mark as visible.
12967 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12968 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12969
d4b43b22
PE
12970 * syntax.c (syntax_temp): Define only if !__GNUC__.
12971
b7c513d0
PE
12972 * sound.c (current_sound_device, current_sound): Now static.
12973
989b29ad
PE
12974 * search.c (searchbufs, searchbuf_head): Now static.
12975
13a55a78
PE
12976 * scroll.c (scroll_cost): Remove; unused.
12977 * dispextern.h (scroll_cost): Remove decl.
12978
de68a1fc
PE
12979 * region-cache.h (pp_cache): Mark as externally visible.
12980
40ccffa6
PE
12981 * process.c: Make symbols static if they're not exported.
12982 (process_tick, update_tick, create_process, chan_process):
12983 (Vprocess_alist, proc_buffered_char, datagram_access):
12984 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12985 (deactivate_process): Mark defn as static, as well as decl.
12986 * lisp.h (create_process): Remove decl.
12987 * process.h (chan_process, Vprocess_alist): Remove decls.
12988
ad64fc97
PE
12989 * print.c: Make symbols static if they're not exported.
12990 (print_depth, new_backquote_output, being_printed, print_buffer):
12991 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12992 (print_interval, print_number_index, initial_stderr_stream):
12993 Now static.
12994 * lisp.h (Fprinc): Remove decl.
12995 (debug_output_compilation_hack): Mark as externally visible.
12996
adddb265
PE
12997 * sysdep.c (croak): Move decl from here to syssignal.h.
12998 * syssignal.h (croak): Put it here, so the API can be checked when
12999 'croak' is called from dissociate_if_controlling_tty.
13000
1717ede2
PE
13001 * minibuf.c: Make symbols static if they're not exported.
13002 (minibuf_save_list, choose_minibuf_frame): Now static.
13003 * lisp.h (choose_minibuf_frame): Remove decl.
13004
fa5fb2bc
PE
13005 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13006
1e3890d1
PE
13007 * lread.c: Make symbols static if they're not exported.
13008 (read_objects, initial_obarray, oblookup_last_bucket_number):
13009 Now static.
13010 (make_symbol): Remove; unused.
13011 * lisp.h (initial_obarray, make_symbol): Remove decls.
13012
8a1414fa
PE
13013 * keyboard.c: Make symbols static if they're not exported.
13014 (single_kboard, recent_keys_index, total_keys, recent_keys):
13015 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13016 (this_single_command_key_start, echoing, last_auto_save):
13017 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13018 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13019 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13020 (Vlispy_mouse_stem, double_click_count):
13021 Now static.
13022 (force_auto_save_soon): Define only if SIGDANGER.
13023 (ignore_mouse_drag_p): Now static if
13024 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13025 (print_help): Remove; unused.
13026 (stop_character, last_timer_event): Mark as externally visible.
13027 * keyboard.h (ignore_mouse_drag_p): Declare only if
13028 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13029 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13030 * lisp.h (echoing): Remove decl.
13031 (force_auto_save_soon): Declare only if SIGDANGER.
13032 * xdisp.c (redisplay_window): Simplify code, to make it more
13033 obvious that ignore_mouse_drag_p is not accessed if !defined
13034 USE_GTK && !defined HAVE_NS.
13035
93ea6e8f
PE
13036 * intervals.c: Make symbols static if they're not exported.
13037 (merge_properties_sticky, merge_interval_right, delete_interval):
13038 Now static.
13039 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13040
77382fcc
PE
13041 * insdel.c: Make symbols static if they're not exported.
13042 However, leave prepare_to_modify_buffer alone. It's never
13043 called from outside this function, but that appears to be a bug.
13044 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13045 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13046 (adjust_after_replace_noundo): Remove; unused.
13047 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13048 (signal_before_change): Remove decls.
77382fcc 13049
9306c32e
PE
13050 * indent.c (val_compute_motion, val_vmotion): Now static.
13051
cd44d2eb
PE
13052 * image.c: Make symbols static if they're not exported.
13053 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13054 if USE_GTK.
13055 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13056 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13057
ad9a7a06
PE
13058 * fringe.c (standard_bitmaps): Now static.
13059 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13060
81626931
PE
13061 * frame.c: Make symbols static if they're not exported.
13062 (x_report_frame_params, make_terminal_frame): Now static.
13063 (get_frame_param): Now static, unless HAVE_NS.
13064 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13065 (x_get_resource_string): Remove; not used.
13066 * frame.h (make_terminal_frame, x_report_frame_params):
13067 (x_get_resource_string); Remove decls.
13068 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13069 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13070
239f9db9
PE
13071 * font.c, fontset.c: Make symbols static if they're not exported.
13072 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13073 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13074 * font.c (font_close_object): Now static.
13075 * font.h (font_close_object): Remove.
13076 * fontset.c (FONTSET_OBJLIST): Remove.
13077 (free_realized_fontset) #if-0 the body, which does nothing.
13078 (face_suitable_for_char_p): #if-0, as it's never called.
13079 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13080 * xfaces.c (face_at_string_position):
13081 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13082 since 0 is always ASCII.
13083
dfcf3579
PE
13084 * fns.c (weak_hash_tables): Now static.
13085
5045092b
PE
13086 * fileio.c: Make symbols static if they're not exported.
13087 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13088 (Vwrite_region_annotation_buffers): Now static.
13089
57a96f5c
PE
13090 * eval.c: Make symbols static if they're not exported.
13091 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13092 * lisp.h (backtrace_list): Remove decl.
13093
35f08c38
PE
13094 * emacs.c: Make symbols static if they're not exported.
13095 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13096 (fatal_error_code, fatal_error_signal_hook, standard_args):
13097 Now static.
13098 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13099 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13100 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13101 * lisp.h (fatal_error_signal_hook): Remove decl.
13102 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13103
f44bd759
PE
13104 * editfns.c: Move a (normally-unused) function to its only use.
13105 * editfns.c, lisp.h (get_operating_system_release): Remove.
13106 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13107 worth the hassle of breaking this out.
13108
b532497d
PE
13109 * xterm.c: Make symbols static if they're not exported.
13110 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13111 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13112 (x_destroy_window, x_delete_display):
13113 Now static.
13114 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13115 (x_mouse_leave): Remove; unused.
13116 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13117 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13118 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13119 Remove decls.
13120 (x_mouse_leave): Declare only if WINDOWSNT.
13121 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13122 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13123 USE_X_TOOLKIT.
13124
1675728f
PE
13125 * ftxfont.c: Make symbols static if they're not exported.
13126 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13127 HAVE_FREETYPE.
13128 * font.h (ftxfont_driver): Likewise.
13129
e4cebfca
PE
13130 * xfns.c: Make symbols static if they're not exported.
13131 (x_last_font_name, x_display_info_for_name):
13132 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13133 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13134 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13135 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13136 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13137 (last_show_tip_args): Now static.
13138 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13139 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13140 (x_screen_planes): Remove; unused.
13141 * dispextern.h (x_screen_planes): Remove decl.
13142
5bf46f05
PE
13143 * dispnew.c: Make symbols static if they're not exported.
13144 * dispextern.h (redraw_garbaged_frames, scrolling):
13145 (increment_row_positions): Remove.
13146 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13147 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13148 Now static.
13149 (redraw_garbaged_frames): Remove; unused.
13150
435f4c28
PE
13151 * xfaces.c: Make symbols static if they're not exported.
13152 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13153 Remove decls.
13154 * xterm.h (defined_color): Remove decls.
13155 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13156 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13157 (menu_face_changed_default, defined_color, free_realized_face):
13158 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13159 (ascii_face_of_lisp_face): Remove; unused.
13160
8524aef3
PE
13161 * xdisp.c: Make symbols static if they're not exported.
13162 * dispextern.h (scratch_glyph_row, window_box_edges):
13163 (glyph_to_pixel_coords, set_cursor_from_row):
13164 (get_next_display_element, set_iterator_to_next):
13165 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13166 (show_mouse_face): Remove decls
13167 * frame.h (message_buf_print): Likewise.
13168 * lisp.h (pop_message, set_message, check_point_in_composition):
13169 Likewise.
13170 * xterm.h (set_vertical_scroll_bar): Likewise.
13171 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13172 (message_buf_print, scratch_glyph_row, displayed_buffer):
13173 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13174 (get_next_display_element, show_mouse_face, window_box_edges):
13175 (frame_to_window_pixel_xy, check_point_in_composition):
13176 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13177 (glyph_to_pixel_coords): Remove; unused.
13178
16390cd2
PE
13179 * dired.c (file_name_completion): Now static.
13180
13181 * dbusbind.c (xd_in_read_queued_messages): Now static.
13182
a25f4dfa
PE
13183 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13184 * data.c (circular_list_error): Remove.
13185
14a9c8df
PE
13186 * commands.h (last_point_position, last_point_position_buffer):
13187 (last_point_position_window): Remove decls.
13188 * keyboard.c: Make these variables static.
13189
04f2d78b
CB
13190 * coding.h (coding, code_convert_region, encode_coding_gap):
13191 Remove decls.
74ab6df5
PE
13192 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13193 (iso_code_class, detect_coding, code_convert_region): Now static.
13194 (encode_coding_gap): Remove; unused.
13195
38dfbee1
PE
13196 * chartab.c (chartab_chars, chartab_bits): Now static.
13197
a2cb4e63
PE
13198 * charset.h (charset_iso_8859_1): Remove decl.
13199 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13200 Now static.
13201
127198fd
PE
13202 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13203 * ccl.c (Vccl_program_table): Now static.
13204 (check_ccl_update): Remove; unused.
13205
d85b608f
PE
13206 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13207 * category.h: ... from here.
13208 * category.c (check_category_table, set_category_set): Now static.
13209
31cd66f3
PE
13210 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13211 * lisp.h: Remove these decls.
13212
c358e587
PE
13213 * buffer.c (buffer_count): Remove unused var.
13214
e78aecca
PE
13215 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13216 so that it's not optimized away.
13217 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13218 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13219 exported only to the debugger.
13220
e192d7d3 13221 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13222 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13223
92470028
PE
13224 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13225 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13226 was inaccessible from Lisp.
13227 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13228 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13229
244ed907
PE
13230 alloc.c: Import and export fewer symbols, and remove unused items.
13231 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13232 is defined.
13233 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13234 it's not optimized away by whole-program optimization.
13235 (message_enable_multibyte, free_misc): Remove.
13236 (catchlist, handlerlist, mark_backtrace):
13237 Declare only if BYTE_MARK_STACK.
13238 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13239 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13240 (message_enable_multibyte): Remove decl.
13241 (free_misc, interval_free_list, float_block, float_block_index):
13242 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13243 (cons_free_list, last_marked_index):
13244 Now static.
13245 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13246 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13247 (mark_backtrace): Define only if BYTE_MARK_STACK.
13248 * xdisp.c (message_enable_multibyte): Now static.
13249
61c2b50e 13250 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13251 This makes it easier for human readers (and static analyzers)
13252 to see whether these variables are used from other modules.
13253 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13254 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13255 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13256 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13257 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13258 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13259 * xmenu.c, xselect.c:
13260 Declare Q* vars static if they are not used in other modules.
13261 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13262 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13263 Remove decls of unexported vars.
13264 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13265
95c82688
PE
13266 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13267
16a97296
PE
13268 Make Emacs functions such as Fatom 'static' by default.
13269 This makes it easier for human readers (and static analyzers)
13270 to see whether these functions can be called from other modules.
13271 DEFUN now defines a static function. To make the function external
13272 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13273 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13274 (Finit_image_library):
16a97296
PE
13275 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13276 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13277 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13278 Remove decls, since these functions are now static.
13279 (Funintern, Fget_internal_run_time): New decls, since these functions
13280 were already external.
95c82688 13281
16a97296
PE
13282 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13283 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13284 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13285 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13286 * keyboard.c, keymap.c, lread.c:
13287 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13288 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13289 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13290 Mark functions with DEFUE instead of DEFUN,
13291 if they are used in other modules.
13292 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13293 decls for now-static functions.
13294 * buffer.h (Fdelete_overlay): Remove decl.
13295 * callproc.c (Fgetenv_internal): Mark as internal.
13296 * composite.c (Fremove_list_of_text_properties): Remove decl.
13297 (Fcomposition_get_gstring): New forward static decl.
13298 * composite.h (Fcomposite_get_gstring): Remove decl.
13299 * dired.c (Ffile_attributes): New forward static decl.
13300 * doc.c (Fdocumntation_property): New forward static decl.
13301 * eval.c (Ffetch_bytecode): New forward static decl.
13302 (Funintern): Remove extern decl; now in .h file where it belongs.
13303 * fileio.c (Fmake_symbolic_link): New forward static decl.
13304 * image.c (Finit_image_library): New forward static decl.
13305 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13306 * intervals.h (Fprevious_property_change):
13307 (Fremove_list_of_text_properties): Remove decls.
13308 * keyboard.c (Fthis_command_keys): Remove decl.
13309 (Fcommand_execute): New forward static decl.
13310 * keymap.c (Flookup_key): New forward static decl.
13311 (Fcopy_keymap): Now static.
13312 * keymap.h (Flookup_key): Remove decl.
13313 * process.c (Fget_process): New forward static decl.
13314 (Fprocess_datagram_address): Mark as internal.
13315 * syntax.c (Fsyntax_table_p): New forward static decl.
13316 (skip_chars): Remove duplicate decl.
13317 * textprop.c (Fprevious_property_change): New forward static decl.
13318 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13319 Now internal.
13320 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13321 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13322
785bbd42
PE
13323 * editfns.c (Fformat): Remove unreachable code.
13324
8b913b57
AS
133252011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13326
13327 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13328 change. (Bug#8496)
13329
a6744a35
EZ
133302011-04-13 Eli Zaretskii <eliz@gnu.org>
13331
13332 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13333 when at ZV. (Bug#8487)
13334
e7974947
AS
133352011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13336
baad03f0
AS
13337 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13338 (Bug#8437)
13339 * keyboard.c (parse_tool_bar_item): Likewise.
13340 * sound.c (sound_cleanup, alsa_close): Likewise.
13341 * termcap.c (tgetent): Likewise.
13342 * xfns.c (x_default_font_parameter): Likewise.
13343 * xsettings.c (read_and_apply_settings): Likewise.
13344
e7974947
AS
13345 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13346 (overrun_check_free): Protoize.
13347
28272684
PE
133482011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13349
13350 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13351 since callers should never pass a negative size.
13352 Change the signature to match that of plain 'read' and 'write'; see
13353 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13354 * lisp.h: Update prototypes of emacs_write and emacs_read.
13355
11997c76
EZ
133562011-04-11 Eli Zaretskii <eliz@gnu.org>
13357
13358 * xdisp.c (redisplay_window): Don't try to determine the character
13359 position of the scroll margin if the window start point w->startp
e896f03c 13360 is outside the buffer's accessible region. (Bug#8468)
11997c76 13361
8a2cbd72
EZ
133622011-04-10 Eli Zaretskii <eliz@gnu.org>
13363
13364 Fix write-region and its subroutines for buffers > 2GB.
13365 * fileio.c (a_write, e_write): Modify declaration of arguments and
13366 local variables to support buffers larger than 2GB.
13367 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13368
13369 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13370 argument, local variables, and return value.
13371
13372 * lisp.h: Update prototypes of emacs_write and emacs_read.
13373
13374 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13375
4073e537 133762011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13377
1ebfdcb6
PE
13378 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13379
b2ded58d
PE
13380 Fix more problems found by GCC 4.6.0's static checks.
13381
7d66342c
PE
13382 * xdisp.c (vmessage): Use a better test for character truncation.
13383
bbf47d44
PE
13384 * charset.c (load_charset_map): <, not <=, for optimization,
13385 and to avoid potential problems with integer overflow.
9248994d 13386 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13387 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13388 * editfns.c (Fformat): Likewise.
1e69125e 13389 * syntax.c (skip_chars): Likewise.
3befa583 13390
e3019616
PE
13391 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13392 This also lets GCC 4.6.0 generate slightly better loop code.
13393
becfa255
PE
13394 * callint.c (Fcall_interactively): <, not <=, for optimization.
13395 (Fcall_interactively): Count the number of arguments produced,
13396 not the number of arguments given. This is simpler and lets GCC
13397 4.6.0 generate slightly better code.
13398
dae0cd48
PE
13399 * ftfont.c: Distingish more carefully between FcChar8 and char.
13400 The previous code passed unsigned char * to a functions like
13401 strlen and xstrcasecmp that expect char *, which does not
13402 conform to the C standard.
13403 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13404 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13405 char * when the C standard requires it.
13406
76032d70
PE
13407 * keyboard.c (read_char): Remove unused var.
13408
eb3f1cc8
PE
13409 * eval.c: Port to Windows vsnprintf (Bug#8435).
13410 Include <limits.h>.
13411 (SIZE_MAX): Define if the headers do not.
13412 (verror): Do not give up if vsnprintf returns a negative count.
13413 Instead, grow the buffer. This ports to Windows vsnprintf, which
13414 does not conform to C99. Problem reported by Eli Zaretskii.
13415 Also, simplify the allocation scheme, by avoiding the need for
13416 calling realloc, and removing the ALLOCATED variable.
13417
70476b54
PE
13418 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13419
12020a9e
PE
13420 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13421 But keep the doprint source code for now, as we might revamp it
13422 and use it again (Bug#8435).
ea6c7ae6
PE
13423 * lisp.h (doprnt): Remove.
13424 * Makefile.in (base_obj): Remove doprnt.o.
13425 * deps.mk (doprnt.o): Remove.
13426
5fdb398c
PE
13427 error: Print 32- and 64-bit integers portably (Bug#8435).
13428 Without this change, on typical 64-bit hosts error ("...%d...", N)
13429 was used to print both 32- and 64-bit integers N, which relied on
13430 undefined behavior.
61bdb816 13431 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13432 * lisp.h (error, verror): Mark as printf-like functions.
13433 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13434 Report overflow in size calculations when allocating printf buffer.
13435 Do not truncate output string at its first null byte.
13436 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13437 Truncate the output at a character boundary, since vsnprintf does not
13438 do that.
13439 * charset.c (check_iso_charset_parameter): Convert internal
13440 character to string before calling 'error', since %c now has the
13441 printf meaning.
13442 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13443 overflow when computing char to be passed to 'error'. Do not
13444 pass Lisp_Object to 'error'; pass the integer instead.
13445 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13446 formatted with plain %d.
13447
b189fa66
PE
13448 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13449
bff87ef0
PE
13450 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13451
7e2cac20
PE
13452 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13453
ce4d90b5
PE
13454 * xterm.c (x_catch_errors): Remove duplicate declaration.
13455
266c9547
PE
13456 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13457
79c49ad2
PE
13458 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13459
368f4090
JM
134602011-04-10 Jim Meyering <meyering@redhat.com>
13461
13462 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13463 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13464 return ssize_t not "int", and use size_t as the buffer length.
13465 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13466 * gnutls.h: Update declarations.
13467 * process.c (read_process_output): Use ssize_t, to match.
13468 (send_process): Likewise.
13469
a32d4040
CY
134702011-04-09 Chong Yidong <cyd@stupidchicken.com>
13471
13472 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13473
8546720e 134742011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13475
04f2d78b
CB
13476 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13477 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13478
8546720e
GM
13479 * xterm.c (handle_one_xevent):
13480 * xmenu.c (create_and_show_popup_menu):
13481 * xselect.c (x_decline_selection_request)
13482 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13483
0a2f5c1a 134842011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13485
13486 Fix some uses of `int' instead of EMACS_INT.
13487 * search.c (string_match_1, fast_string_match)
13488 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13489 (scan_buffer, find_next_newline_no_quit)
13490 (find_before_next_newline, search_command, Freplace_match)
13491 (Fmatch_data): Make some `int' variables be EMACS_INT.
13492
13493 * xdisp.c (display_count_lines): 3rd argument and return value now
13494 EMACS_INT. All callers changed.
13495 (pint2hrstr): Last argument is now EMACS_INT.
13496
13497 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13498 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13499 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13500 (decode_coding_utf_16, decode_coding_emacs_mule)
13501 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13502 (decode_coding_ccl, decode_coding_charset)
13503 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13504 (decode_coding_iso_2022, decode_coding_emacs_mule)
13505 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13506 <char_offset, last_offset>: Declare EMACS_INT.
13507 (encode_coding_utf_8, encode_coding_utf_16)
13508 (encode_coding_emacs_mule, encode_invocation_designation)
13509 (encode_designation_at_bol, encode_coding_iso_2022)
13510 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13511 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13512 Declare EMACS_INT.
13513 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13514 (encode_invocation_designation): Last argument P_NCHARS is now
13515 EMACS_INT.
13516 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13517 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13518
13519 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13520 All users changed.
13521
13522 * ccl.c (Fccl_execute_on_string): Declare some variables
13523 EMACS_INT.
13524
8546720e 135252011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13526
13527 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13528
4e19a977
CS
135292011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13530
13531 * process.c (Fformat_network_address): Doc fix.
13532
87302331
R
135332011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13534
ee7683eb 13535 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13536
cbb59342
CY
135372011-04-08 Chong Yidong <cyd@stupidchicken.com>
13538
13539 * keyboard.c (read_char): Call Lisp function help-form-show,
13540 instead of using internal_with_output_to_temp_buffer.
13541 (Qhelp_form_show): New var.
e0d38eeb 13542 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13543
13544 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13545
13546 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13547
e67a13ab
CY
135482011-04-06 Chong Yidong <cyd@stupidchicken.com>
13549
04f2d78b
CB
13550 * process.c (Flist_processes): Remove to Lisp.
13551 (list_processes_1): Delete.
e67a13ab 13552
973f782d
EZ
135532011-04-06 Eli Zaretskii <eliz@gnu.org>
13554
7c106b1e
EZ
13555 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13556
973f782d
EZ
13557 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13558
41cf7d1a 135592011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13560
ca23cc88
PE
13561 Fix more problems found by GCC 4.6.0's static checks.
13562
f390e2d5
PE
13563 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13564
42eea0d0
PE
13565 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13566
b69769da 13567 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13568
f9541e84
PE
13569 * xdisp.c (vmessage): Mark as a printf-like function.
13570
13841b55
PE
13571 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13572
c136c10f
PE
13573 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13574
5e2d4a30
PE
13575 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13576 printf-like functions.
13577 (tiff_load): Add casts to remove these marks before passing them
13578 to system-supplied API.
13579
583f48b9
PE
13580 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13581
b25d760e
PE
13582 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13583 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13584 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13585 directly, rather than having caller test rule sign. This avoids
13586 some unnecessary tests.
13587 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13588 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13589 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13590
bc7b6697 13591 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13592 (xfont_open): Avoid unnecessary tests.
bc7b6697 13593
27ccc379
PE
13594 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13595
dcd5c89a
PE
13596 * composite.h, composite.c (composition_gstring_put_cache):
13597 Use EMACS_INT, not int, for length.
13598
b13a45c6
PE
13599 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13600 breaking out part of COMPOSITION_DECODE_RULE.
13601 (COMPOSITION_DECODE_RULE): Use it.
13602 * composite.c (get_composition_id): Remove unused local vars,
13603 by using the new macro.
13604
1e792e4d
PE
13605 * textprop.c (set_text_properties_1): Change while to do-while,
13606 since the condition is always true at first.
13607
dc6c6455 13608 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13609 (interval_deletion_adjustment): Return unsigned value.
13610 All uses changed.
dc6c6455 13611
aba7731a
PE
13612 * process.c (list_processes_1, create_pty, read_process_output):
13613 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13614 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13615 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13616 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13617 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13618
fdfc4bf3
PE
13619 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13620
fca8fe46 13621 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13622 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13623
06a0259a 13624 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13625 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13626 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13627
e7b9e80f
PE
13628 * print.c (print_error_message): Avoid int overflow.
13629
56201685
PE
13630 * font.c (font_list_entities): Redo for clarity,
13631 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13632
78834453 13633 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13634 (font_score): Avoid potential overflow in diff calculation.
78834453 13635
0bc0b309 13636 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13637 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13638
e610eaca
PE
13639 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13640
b895abce
PE
13641 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13642 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13643 can always succeed if overflow has undefined behavior.
13644
1f1d9321 13645 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13646 (wordify): Omit three unnecessary tests.
1f1d9321 13647
c59478bc
PE
13648 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13649 All callers changed. This avoids the need for an unused var.
13650
79b73827
PE
13651 * casefiddle.c (casify_region): Remove var that is set but not used.
13652
a4db5dfe
PE
13653 * dired.c (file_name_completion): Remove var that is set but not used.
13654
43aae36e
PE
13655 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13656
2a47c44d 13657 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13658 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13659
a37c69bf
PE
13660 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13661 Check for integer overflow on size calculations.
13662
328ab8e7
PE
13663 * buffer.c (Fprevious_overlay_change): Remove var that is set
13664 but not used.
13665
e5a2a5cb
PE
13666 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13667 Remove vars that are set but not used.
8d84a6eb 13668 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13669 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13670
a60e5f68
PE
13671 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13672
f661cb61 13673 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13674 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13675
f0397f5a
PE
13676 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13677 that are set but not used.
13678
8664db06 13679 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13680 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13681
6abdaa4a
PE
13682 * xselect.c (x_get_local_selection, x_handle_property_notify):
13683 Remove vars that are set but not used.
13684
0ce7538d 13685 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13686 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13687
9ae848fc
PE
13688 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13689 Remove var that is set but not used.
0b918413
PE
13690 (scroll_bar_windows_size): Now size_t, not int.
13691 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13692 Check for overflow.
9ae848fc 13693
a5a62657
PE
13694 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13695 (map_tty_color) [!defined MSDOS]: Likewise.
13696
5c5cdd39
PE
13697 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13698
66ebf983
PE
13699 * coding.c: Remove vars that are set but not used.
13700 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13701 All callers changed.
13702 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13703 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13704 (decode_coding_charset): Remove vars that are set but not used.
13705
1be4d761
PE
13706 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13707 that is set but not used.
13708
47553fa8
PE
13709 * print.c (print_object): Remove var that is set but not used.
13710
1f7196bf 13711 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13712 The gnulib version avoids calling malloc in the usual case,
13713 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13714 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13715 * filelock.c (current_lock_owner): Likewise.
13716 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13717 * sysdep.c: Include allocator.h, careadlinkat.h.
13718 (emacs_no_realloc_allocator): New static constant.
13719 (emacs_readlink): New function.
fdb61804
PE
13720 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13721 ../lib/careadlinkat.h.
d1fdcab7 13722
f84c17c7
SM
137232011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13724
13725 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13726 first non-nil return value).
13727
ef3862ad
JD
137282011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13729
13730 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13731 if not defined (Bug#8403).
13732
376a7006
JB
137332011-04-02 Juanma Barranquero <lekktu@gmail.com>
13734
13735 * xdisp.c (display_count_lines): Remove parameter `start',
13736 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13737 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13738 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13739 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13740 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13741 and thereabouts. All callers changed.
13742 (get_per_char_metric): Remove parameter `f', unused since
13743 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13744
6ca3801d
JM
137452011-04-02 Jim Meyering <meyering@redhat.com>
13746
13747 do not dereference NULL upon failed strdup
13748 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13749 (ns_get_family): Likewise.
13750
d8e2b5ba
JB
137512011-04-02 Juanma Barranquero <lekktu@gmail.com>
13752
13753 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13754
8c74fcbd
JD
137552011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13756
13757 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13758 later (Bug#8403).
13759
7200d79c
SM
137602011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13761
03408648 13762 Add lexical binding.
7200d79c 13763
03408648
SM
13764 * window.c (Ftemp_output_buffer_show): New fun.
13765 (Fsave_window_excursion):
13766 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13767
13768 * lread.c (lisp_file_lexically_bound_p): New function.
13769 (Fload): Bind Qlexical_binding.
13770 (readevalloop): Remove `evalfun' arg.
13771 Bind Qinternal_interpreter_environment.
13772 (Feval_buffer): Bind Qlexical_binding.
13773 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13774 Mark as dynamic.
13775 (syms_of_lread): Declare `lexical-binding'.
13776
13777 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13778
13779 * keyboard.c (eval_dyn): New fun.
13780 (menu_item_eval_property): Use it.
ca105506
SM
13781
13782 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13783
03408648
SM
13784 * fns.c (concat, mapcar1): Accept byte-code-functions.
13785
13786 * eval.c (Fsetq): Handle lexical vars.
13787 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13788 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13789 (FletX, Flet): Obey lexical binding.
13790 (Fcommandp): Handle closures.
13791 (Feval): New `lexical' arg.
13792 (eval_sub): New function extracted from Feval. Use it almost
13793 everywhere where Feval was used. Look up vars in lexical env.
13794 Handle closures.
13795 (Ffunctionp): Move from subr.el.
13796 (Ffuncall): Handle closures.
13797 (apply_lambda): Remove `eval_flags'.
13798 (funcall_lambda): Handle closures and new byte-code-functions.
13799 (Fspecial_variable_p): New function.
13800 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13801 but without exporting it to Lisp.
23aba0ea 13802
23aba0ea 13803 * doc.c (Fdocumentation, store_function_docstring):
03408648 13804 * data.c (Finteractive_form): Handle closures.
23aba0ea 13805
03408648
SM
13806 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13807 interactive spec.
ba83908c 13808
04f2d78b
CB
13809 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13810 New byte-codes.
03408648
SM
13811 (exec_byte_code): New function extracted from Fbyte_code to handle new
13812 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13813
03408648 13814 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13815
03408648 13816 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13817
e2abce01
JB
138182011-03-31 Juanma Barranquero <lekktu@gmail.com>
13819
13820 * xdisp.c (redisplay_internal): Fix prototype.
13821
63696a73 138222011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13823
63696a73 13824 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13825 (try_scrolling): Use it when setting scroll_limit.
13826 Limit scrolling to 100 screen lines.
63696a73
EZ
13827 (redisplay_window): Even when falling back on "recentering",
13828 position point in the window according to scroll-conservatively,
13829 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13830
13831 (try_scrolling): When point is above the window, allow searching
13832 as far as scroll_max, or one screenful, to compute vertical
13833 distance from PT to the scroll margin position. This prevents
13834 try_scrolling from unnecessarily failing when
13835 scroll-conservatively is set to a value slightly larger than the
13836 window height. Clean up the case of PT below the margin at bottom
13837 of window: scroll_max can no longer be INT_MAX. When aggressive
13838 scrolling is in use, don't let point enter the opposite scroll
13839 margin as result of the scroll.
13840 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13841 threshold of 100 lines for never-recentering scrolling.
13842
e4cc2dfc
JB
138432011-03-31 Juanma Barranquero <lekktu@gmail.com>
13844
13845 * dispextern.h (move_it_by_lines):
13846 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13847 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13848 (message_log_check_duplicate): Remove parameters `prev_bol' and
13849 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13850 (redisplay_internal): Remove parameter `preserve_echo_area',
13851 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13852
13853 * indent.c (Fvertical_motion):
13854 * window.c (window_scroll_pixel_based, Frecenter):
13855 Don't pass `need_y_p' to `move_it_by_lines'.
13856
1c470562
SM
138572011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13858
44f230aa
SM
13859 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13860 steal a few bits to be more compact.
13861 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13862 Remove unneeded casts.
13863
1c470562
SM
13864 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13865
888adce9
ZK
138662011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13867
13868 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13869 binding" message (bug#7967).
13870
f838ed7b
PE
138712011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13872
77861b95
PE
13873 Fix more problems found by GCC 4.6.0's static checks.
13874
de6dbc14
PE
13875 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13876 Remove unused local var.
13877
f838ed7b
PE
13878 * editfns.c (Fmessage_box): Remove unused local var.
13879
792c7b2b
PE
13880 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13881 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13882 Omit unused local vars.
c499e557 13883 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13884 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13885 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13886 Omit unused local var.
13887
ba0165e1
PE
13888 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13889 Don't assume string length fits in int.
32ad8845 13890 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13891 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13892
3c59b4c9
PE
13893 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13894 instead of alloca (Bug#8344).
13895
a3eed478 13896 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13897 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13898
eb4d412d
PE
13899 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13900
1658b401
PE
13901 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13902 concerns.
13903
13904 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13905
13906 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13907
9a2c6e05
PE
13908 * keyboard.c (syms_of_keyboard): Use the same style as later
13909 in this function when indexing through an array. This also
13910 works around GCC bug 48267.
13911
03d0a109
PE
13912 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13913
44f730c8
PE
13914 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13915
fe75f926
PE
13916 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13917 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13918
ffa8c828
PE
13919 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13920 This avoids undefined behavior on integer overflow, and is a bit
13921 more convenient anyway since it is compared to a size_t variable.
13922
c5101a77
PE
13923 Variadic C functions now count arguments with size_t, not int.
13924 This avoids an unnecessary limitation on 64-bit machines, which
13925 caused (substring ...) to crash on large vectors (Bug#8344).
13926 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13927 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13928 All variadic functions and their callers changed accordingly.
c5101a77
PE
13929 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13930 * data.c (arith_driver, float_arith_driver): Likewise.
13931 * editfns.c (general_insert_function): Likewise.
13932 * eval.c (struct backtrace.nargs, interactive_p)
13933 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13934 (funcall_lambda, mark_backtrace): Likewise.
13935 * fns.c (concat): Likewise.
13936 * frame.c (x_set_frame_parameters): Likewise.
13937 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13938 0 if not found, not -1. All callers changed.
13939
dd3f25f7
PE
13940 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13941 (stack_copy_size): Now size_t, not int.
13942 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13943
461c2ab9
JB
139442011-03-28 Juanma Barranquero <lekktu@gmail.com>
13945
13946 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13947 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13948 All callers changed.
13949
13950 * lisp.h (multibyte_char_to_unibyte):
13951 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13952 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13953 * character.h (CHAR_TO_BYTE8):
13954 * cmds.c (internal_self_insert):
13955 * editfns.c (general_insert_function):
13956 * keymap.c (push_key_description):
13957 * search.c (Freplace_match):
13958 * xdisp.c (message_dolog, set_message_1): All callers changed.
13959
f6d62986
SM
139602011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13961
13962 * keyboard.c (safe_run_hook_funcall): New function.
13963 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13964 don't set the hook to nil, but remove the offending function instead.
13965 (Qcommand_hook_internal): Remove, unused.
13966 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13967 Vcommand_hook_internal.
13968
13969 * eval.c (enum run_hooks_condition): Remove.
13970 (funcall_nil, funcall_not): New functions.
13971 (run_hook_with_args): Call each function through a `funcall' argument.
13972 Remove `cond' argument, now redundant.
13973 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13974 (Frun_hook_with_args_until_failure): Adjust accordingly.
13975 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13976
1db5b1ad
JB
139772011-03-28 Juanma Barranquero <lekktu@gmail.com>
13978
13979 * dispextern.h (string_buffer_position): Remove declaration.
13980
13981 * print.c (strout): Remove parameter `multibyte', unused since
13982 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13983
13984 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13985 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13986 All callers changed.
13987
13988 * w32.c (_wsa_errlist): Use braces for struct initializers.
13989
13990 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13991 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13992 All callers changed.
13993 (string_buffer_position): Likewise. Also, make static (it's never
13994 used outside xdisp.c).
13995 (cursor_row_p): Remove parameter `w', unused since
13996 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13997 (decode_mode_spec): Remove parameter `precision', introduced during
13998 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13999 All callers changed.
14000
5ffb62aa
JD
140012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14002
14003 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14004
461c2ab9 140052011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14006
14007 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14008 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14009 (ns_update_auto_hide_menu_bar): New functions.
14010 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14011 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14012 ns_constrain_all_frames.
14013 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14014 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14015
5c380ffb
JD
140162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14017
14018 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14019
9af30bdf
GM
140202011-03-27 Glenn Morris <rgm@gnu.org>
14021
14022 * syssignal.h: Replace RETSIGTYPE with void.
14023 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14024 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14025 Replace SIGTYPE with void everywhere.
14026 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14027 * s/template.h (SIGTYPE): Remove commented out definition.
14028
e2abce01
JB
140292011-03-26 Eli Zaretskii <eliz@gnu.org>
14030
14031 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14032 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14033
f868cd8a
JB
140342011-03-26 Juanma Barranquero <lekktu@gmail.com>
14035
59eb0929
JB
14036 * w32.c (read_unc_volume): Use parameter `henum', instead of
14037 global variable `wget_enum_handle'.
14038
14039 * keymap.c (describe_vector): Remove parameters `indices' and
14040 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14041 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14042
f868cd8a
JB
14043 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14044
14045 * keyboard.c (timer_check): Remove parameter `do_it_now',
14046 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14047 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14048 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14049
14050 * keyboard.c (read_char):
14051 * w32menu.c (w32_menu_display_help):
14052 * xmenu.c (show_help_event, menu_help_callback):
14053 Adjust calls to `show_help_echo'.
14054
14055 * gtkutil.c (xg_maybe_add_timer):
14056 * keyboard.c (readable_events):
14057 * process.c (wait_reading_process_output):
14058 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14059
14060 * insdel.c (adjust_markers_gap_motion):
14061 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14062 (gap_left, gap_right): Don't call it.
14063
2ecf6fdb
CY
140642011-03-25 Chong Yidong <cyd@stupidchicken.com>
14065
14066 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14067 incurred during fontification.
14068
6b1f9ba4
JB
140692011-03-25 Juanma Barranquero <lekktu@gmail.com>
14070
14071 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14072 (DEFVAR_PER_BUFFER): Don't pass it.
14073
14074 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14075 (scrolling_window): Don't pass it.
14076
0f4a96b5
JB
140772011-03-25 Juanma Barranquero <lekktu@gmail.com>
14078
14079 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14080
14081 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14082 and `suffix'.
14083 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14084 of variables specific to SELinux and computation of `encoded_absname'.
14085
14086 * image.c (XPutPixel): Remove unused variable `height'.
14087
14088 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14089
14090 * unexw32.c (get_section_info): Remove unused variable `section'.
14091
14092 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14093 (system_process_attributes): Remove unused variable `sess'.
14094 (sys_read): Remove unused variable `err'.
14095
14096 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14097 (w32_wnd_proc): Remove unused variable `isdead'.
14098 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14099 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14100 (x_create_tip_frame): Remove unused variable `tem'.
14101
14102 * w32inevt.c (w32_console_read_socket):
14103 Remove unused variable `no_events'.
14104
14105 * w32term.c (x_draw_composite_glyph_string_foreground):
14106 Remove unused variable `width'.
14107
1149507c
JB
141082011-03-24 Juanma Barranquero <lekktu@gmail.com>
14109
14110 * w32term.c (x_set_glyph_string_clipping):
14111 Don't pass uninitialized region to CombineRgn.
14112
9c88f339
JB
141132011-03-23 Juanma Barranquero <lekktu@gmail.com>
14114
14115 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14116 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14117 (Fx_close_connection): Remove unused variable `i'.
14118
14119 * w32font.c (w32font_draw): Return number of glyphs.
14120 (w32font_open_internal): Remove unused variable `i'.
14121 (w32font_driver): Add missing initializer.
14122
14123 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14124 (fill_in_menu): Remove unused variable `items_added'.
14125
14126 * w32term.c (last_mouse_press_frame): Remove static global variable.
14127 (w32_clip_to_row): Remove unused variable `f'.
14128 (x_delete_terminal): Remove unused variable `i'.
14129
14130 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14131 (NOTHING): Remove unused static global variable.
14132 (uniscribe_check_otf): Remove unused variable `table'.
14133 (uniscribe_font_driver): Add missing initializers.
14134
dee091a3
JD
141352011-03-23 Julien Danjou <julien@danjou.info>
14136
14137 * term.c (Fsuspend_tty, Fresume_tty):
14138 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14139 * window.c (temp_output_buffer_show):
14140 * insdel.c (signal_before_change):
14141 * frame.c (Fhandle_switch_frame):
14142 * fileio.c (Fdo_auto_save):
14143 * emacs.c (Fkill_emacs):
14144 * editfns.c (save_excursion_restore):
14145 * cmds.c (internal_self_insert):
14146 * callint.c (Fcall_interactively):
14147 * buffer.c (Fkill_all_local_variables):
14148 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14149 Use Frun_hooks.
0f4a96b5 14150 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14151 unconditionally since it does the check itself.
dee091a3 14152
2c520ab5 141532011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14154
c9c49752
PE
14155 Fix more problems found by GCC 4.5.2's static checks.
14156
8abc3f12
PE
14157 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14158 the first time through the loop, since we know p0 < p1 then.
14159 This also avoids a gcc -Wstrict-overflow warning.
14160
a2d26660
PE
14161 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14162 leading to a memory leak, possible in functions like
14163 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14164 of objects (Bug#8318).
a2d26660 14165
916c72e9
PE
14166 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14167 that could (at least in theory) be that large.
14168
19ab8a18
PE
14169 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14170 This is less likely to overflow, and avoids undefined behavior if
14171 overflow does occur. All callers changed. Use strtoul to scan
14172 for the unsigned long integer.
b7cbbd6f
PE
14173 (pint2hrstr): Simplify and tune code slightly.
14174 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14175
f0641eff
PE
14176 * scroll.c (do_scrolling): Work around GCC bug 48228.
14177 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14178
7f650bb9
PE
14179 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14180 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14181 (validate_x_resource_name): Simplify count usage.
14182 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14183
37dd57d1
PE
14184 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14185 fail (Bug#8306).
81e56e61 14186
699979fc 14187 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14188
401bf9b4
PE
14189 * process.c (Fmake_network_process): Use socklen_t, not int,
14190 where POSIX says socklen_t is required in portable programs.
14191 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14192 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14193 (Fmake_network_process, server_accept_connection):
14194 (wait_reading_process_output, read_process_output):
14195 Likewise.
14196
b93aacde
PE
14197 * process.c: Rename or move locals to avoid shadowing.
14198 (list_processes_1, Fmake_network_process):
14199 (read_process_output_error_handler, exec_sentinel_error_handler):
14200 Rename or move locals.
4dc343ee 14201 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14202 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14203 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14204 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14205 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14206
af8a867c 14207 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14208 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14209 Include tparam.h instead, since it declares them.
af8a867c
PE
14210 * cm.h (PC): Remove extern decl; tparam.h now does this.
14211 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14212 * terminfo.c: Include tparam.h, to check interfaces.
14213 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14214 (tparam): Adjust signature to match interface in tparam.h;
14215 this removes some undefined behavior. Check that outstring and len
14216 are zero, which they always are with Emacs.
14217 * tparam.h (PC, BC, UP): New extern decls.
14218
0248044d 14219 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14220 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14221
8ff096c1 14222 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14223 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14224 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14225 (ftfont_list): Remove unused local.
49eaafba
PE
14226 (get_adstyle_property, ftfont_pattern_entity):
14227 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14228 Rename locals to avoid shadowing.
8ff096c1 14229
e2be39f6
PE
14230 * xfont.c (xfont_list_family): Mark var as initialized.
14231
c9735e30
PE
14232 * xml.c (make_dom): Now static.
14233
8f5201ae
PE
14234 * composite.c (composition_compute_stop_pos): Rename local to
14235 avoid shadowing.
b246f932
PE
14236 (composition_reseat_it): Remove unused locals.
14237 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14238 (composition_update_it): Mark var as initialized.
11b61122
PE
14239 (find_automatic_composition): Mark vars as initialized,
14240 with a FIXME (Bug#8290).
8f5201ae 14241
760fbc2c
PE
14242 character.h: Rename locals to avoid shadowing.
14243 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14244 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14245 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14246 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14247 to avoid shadowing.
14248
ff08eb85
PE
14249 * textprop.c (property_change_between_p): Remove; unused.
14250
fc7bf025
PE
14251 * intervals.c (interval_start_pos): Now static.
14252
235d7abc
PE
14253 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14254
44f230aa
SM
14255 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14256 Rename locals to avoid shadowing.
3e7d6594 14257
50060332
PE
14258 * sound.c (wav_play, au_play, Fplay_sound_internal):
14259 Fix pointer signedness.
d01f234b 14260 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14261 (wav_play): Initialize a variable to 0, to prevent undefined
14262 behavior (Bug#8278).
50060332 14263
c4fc4e30
PE
14264 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14265
918436ed
PE
14266 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14267
c939f91b
PE
14268 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14269 clobbering (Bug#8298).
b9c7f648
PE
14270 * sysdep.c (sys_subshell): Likewise.
14271 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14272
6bd8c144
PE
14273 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14274 This should get cleaned up, so that child_setup has the
14275 same signature on all platforms.
14276
7710357c 14277 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14278 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14279
c59da222
CY
142802011-03-22 Chong Yidong <cyd@stupidchicken.com>
14281
14282 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14283 not to be necessary, and produces flickering.
14284
66b87493
GM
142852011-03-20 Glenn Morris <rgm@gnu.org>
14286
14287 * config.in: Remove file.
14288
45b6f6d5
JB
142892011-03-20 Juanma Barranquero <lekktu@gmail.com>
14290
14291 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14292 are now in src/globals.h.
14293 (syms_of_minibuf): Remove spurious & from previous change.
14294
cd394be1 142952011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14296
14297 * minibuf.c (completing-read-function): New variable.
14298 (completing-read-default): Rename from completing-read.
14299 (completing-read): Call completing-read-function.
14300
b14e3e21
CY
143012011-03-19 Juanma Barranquero <lekktu@gmail.com>
14302
14303 * xfaces.c (Fx_load_color_file):
14304 Read color file from absolute filename (bug#8250).
14305
f2b726e6
JB
143062011-03-19 Juanma Barranquero <lekktu@gmail.com>
14307
14308 * makefile.w32-in: Update dependencies.
14309
09f6ff02
EZ
143102011-03-17 Eli Zaretskii <eliz@gnu.org>
14311
14312 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14313
29a6015a
PE
143142011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14315
a3a6c54e
PE
14316 Fix more problems found by GCC 4.5.2's static checks.
14317
b766f867
PE
14318 * process.c (make_serial_process_unwind, send_process_trap):
14319 (sigchld_handler): Now static.
14320
be02381c
PE
14321 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14322 That way, the code declares only the vars that it needs.
14323 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14324 * s/cygwin.h (PTY_ITERATION): Likewise.
14325 * s/darwin.h (PTY_ITERATION): Likewise.
14326 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14327
57048744
PE
14328 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14329 * process.c (allocate_pty): Don't declare stb unless it's needed.
14330
7914961c 14331 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14332 (CONSTANTLIM): Remove; unused.
14333 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14334 Define only if needed.
7914961c 14335
b3967b18
PE
14336 * unexelf.c (unexec): Name an expression,
14337 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14338 Use a different way to cause a compilation error if anyone uses
14339 n rather than nn, a way that does not involve shadowing.
73366a00 14340 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14341
29a6015a
PE
14342 * deps.mk (unexalpha.o): Remove; unused.
14343
43cfc33e 14344 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14345 * unexec.h: New file.
ce701a33
PE
14346 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14347 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14348 Depend on unexec.h.
14349 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14350 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14351 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14352 Change as necessary to match prototype in unexec.h.
ce701a33 14353
01f44d5a
PE
14354 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14355 shadowing.
4f63c6bb 14356 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14357
a6670b0b
PE
14358 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14359 Rename locals to avoid shadowing.
14360
cef2010d 14361 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14362 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14363
d4d7173a
PE
14364 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14365
f08b802a
PE
14366 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14367 warning when compiling print.c.
14368
3ddb0639
PE
14369 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14370 instead of using an uninitialized var.
5ad03b97 14371 (font_sort_entities): Mark var as initialized.
3ddb0639 14372
170a2692
PE
14373 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14374
e663c700
PE
14375 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14376 pointers to constants.
89bc529a 14377 (font_parse_fcname): Remove unused vars.
7b81e2d0 14378 (font_delete_unmatched): Now static.
ea838e10 14379 (font_get_spec): Remove; unused.
13a547c6
PE
14380 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14381 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14382 Rename or move locals to avoid shadowing.
e663c700 14383
2a80c887 14384 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14385 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14386
1384fa33 14387 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14388 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14389
8b2c52e9
PE
14390 * alloc.c (mark_backtrace): Move decl from here ...
14391 * lisp.h: ... to here, so that it can be checked.
14392
475545b5 14393 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14394 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14395 (lisp_indirect_variable): Name an expression,
14396 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14397 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14398
b1349114 14399 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14400 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14401 Use const pointer when appropriate.
b1349114 14402
a2928364
PE
14403 * lisp.h (get_system_name, get_operating_system_release):
14404 Move decls here, to check interfaces.
14405 * process.c (get_operating_system_release): Move decl to lisp.h.
14406 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14407 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14408 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14409 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14410 (Fformat_time_string, Fencode_time, Finsert_char):
14411 (Ftranslate_region_internal, Fformat):
14412 Rename or remove local vars to avoid shadowing.
9710023e 14413 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14414
a415e694
PE
14415 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14416 avoid shadowing.
14417
8ef4622d
PE
14418 * lisp.h (eassert): Check that the argument compiles, even if
14419 ENABLE_CHECKING is not defined.
14420
946f9a5b
PE
14421 * data.c (Findirect_variable): Name an expression, to avoid
14422 gcc -Wbad-function-cast warning.
112396d6 14423 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14424 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14425 (Fmake_variable_buffer_local, Fmake_local_variable):
14426 Mark variables as initialized.
52746918 14427 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14428
e5aab7e7 14429 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14430 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14431 Rename locals to avoid shadowing.
dff45157
PE
14432 (mark_stack): Move local variables into the #ifdef region where
14433 they're used.
7bc26fdb
PE
14434 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14435 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14436 needed otherwise.
14437 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14438 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14439 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14440
e5aab7e7
PE
14441 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14442 avoids undefined behavior in theory.
14443
4da60324
PE
14444 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14445
88043301
PE
14446 Use functions, not macros, for up- and down-casing (Bug#8254).
14447 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14448 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14449 to use the following functions instead of these macros.
14450 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14451 EMACS_INT, since callers assume the returned value fits in int.
14452 (upcase1): Likewise, for UPCASE_TABLE.
14453 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14454 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14455 the race-condition problem in the old DOWNCASE.
88043301 14456
19ed5445
PE
14457 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14458 Rename locals to avoid shadowing.
14459 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14460 (regex_compile, re_search_2, re_match_2_internal):
14461 Remove unused local vars.
952db0d7
PE
14462 (FREE_VAR): Rewrite so as not to use empty "else",
14463 which gcc can warn about.
da053e48 14464 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14465 (RETALLOC_IF): Define only if needed.
14466 (WORDCHAR_P): Likewise. This one is never needed, but is used
14467 only in a comment talking about a compiler bug, so put inside
14468 the #if 0 of that comment.
14469 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14470 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14471 Remove; unused.
19ed5445 14472
1f3561e4 14473 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14474 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14475 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14476
ded6f8f7
PE
14477 * search.c (simple_search): Remove unused var.
14478
dbd37a95
PE
14479 * dired.c (compile_pattern): Move decl from here ...
14480 * lisp.h: ... to here, so that it can be checked.
14481 (struct re_registers): New forward decl.
14482
7e47afad
PE
14483 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14484
85f24f61
PE
14485 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14486 All uses changed.
14487 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14488 Rename locals to avoid shadowing.
5671df8f 14489 (Fvertical_motion): Mark locals as initialized.
85f24f61 14490
181aa2be 14491 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14492 (casify_region): Mark local as initialized.
181aa2be 14493
930d429c
PE
14494 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14495
7082eac6
PE
14496 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14497 New macros, so that the caller can use some names other than
14498 gcpro1, gcpro2, etc.
14499 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14500 of the new macros.
14501 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14502 argument, for consistency with GCPRO2_VAR, etc: it is now the
14503 prefix of the variable, not the variable itself. All uses
14504 changed.
38b2c076
PE
14505 * dired.c (directory_files_internal, file_name_completion):
14506 Rename locals to avoid shadowing.
14507
15206ed9
PE
14508 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14509 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14510 dired.c's scmp function, had undefined behavior.
14511 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14512 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14513 * buffer.h: ... to here, because these macros use current_buffer,
14514 and the new implementation with inline functions needs to have
14515 current_buffer in scope now, rather than later when the macros
14516 are used.
14517 (downcase, upcase1): New static inline functions.
14518 (DOWNCASE, UPCASE1): Reimplement using these functions.
14519 This avoids undefined behavior in expressions like
14520 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14521 from race conditions in accessing the global variables
14522 case_temp1 and case_temp2.
14523 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14524 * lisp.h (case_temp1, case_temp2): Remove their decls.
14525 * character.h (ASCII_CHAR_P): Move from here ...
14526 * lisp.h: ... to here, so that the inline functions mentioned
14527 above can use them.
14528
4a6bea26
PE
14529 * dired.c (directory_files_internal_unwind): Now static.
14530
f14b7e14
PE
14531 * fileio.c (file_name_as_directory, directory_file_name):
14532 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14533 Now static.
2893f146
PE
14534 (file_name_as_directory): Use const pointers when appropriate.
14535 (Fexpand_file_name): Likewise. In particular, newdir might
14536 point at constant storage, so make it a const pointer.
fd4ead52 14537 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14538 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14539 signedness issues.
f839df0c
PE
14540 (Fset_file_times, Finsert_file_contents, auto_save_error):
14541 Rename locals to avoid shadowing.
f14b7e14 14542
5716756e 14543 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14544 (Ftry_completion, Fall_completions): Rename or remove locals
14545 to avoid shadowing.
5716756e 14546
b4c3046a
PE
14547 * marker.c (bytepos_to_charpos): Remove; unused.
14548
b45db522
PE
14549 * lisp.h (verify_bytepos, count_markers): New decls,
14550 so that gcc does not warn that these functions aren't declared.
14551
85876d07
PE
14552 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14553 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14554 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14555 (copy_text): Remove unused local var.
85876d07 14556
03d78a21 14557 * filelock.c (within_one_second): Now static.
b3dd38ab 14558 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14559
5df8f01b
PE
14560 * buffer.c (fix_overlays_before): Mark locals as initialized.
14561 (fix_start_end_in_overlays): Likewise. This function should be
14562 simplified by using pointers-to-pointers, but that's a different
14563 matter.
b1d876f1 14564 (switch_to_buffer_1): Now static.
8f54f30a
PE
14565 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14566 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14567
a70072c9 14568 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14569 Fix pointer signedness issue.
edced198
PE
14570 (sys_subshell): Mark local as volatile if checking for lint,
14571 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14572 (MAXPATHLEN): Define only if needed.
a70072c9 14573
a0977c44
PE
14574 * process.c (serial_open, serial_configure): Move decls from here ...
14575 * systty.h: ... to here, so that they can be checked.
14576
a884fdcc
PE
14577 * fns.c (get_random, seed_random): Move extern decls from here ...
14578 * lisp.h: ... to here, so that they can be checked.
14579
604efe86 14580 * sysdep.c (reset_io): Now static.
b8950c94 14581 (wait_for_termination_signal): Remove; unused.
604efe86 14582
38fc62d9
PE
14583 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14584 (copy_keymap_item, append_key, push_text_char_description):
14585 Now static.
1004a21a 14586 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14587 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14588 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14589 (describe_map_tree):
14590 Rename locals to avoid shadowing.
38fc62d9 14591
2f2650da
PE
14592 * keyboard.c: Declare functions static if they are not used elsewhere.
14593 (echo_char, echo_dash, cmd_error, top_level_2):
14594 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14595 (read_char, kbd_buffer_get_event, make_lispy_position):
14596 (make_lispy_event, make_lispy_movement, apply_modifiers):
14597 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14598 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14599 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14600 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14601 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14602
a053e86c 14603 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14604 (mark_kboards): Move decl here ...
14605 * alloc.c (mark_kboards): ... from here.
a053e86c 14606
4752793e
PE
14607 * lisp.h (force_auto_save_soon): New decl.
14608
74f10ca7 14609 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14610 (DEFINE_DUMMY_FUNCTION): New macro.
14611 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14612 Use it.
c03cd23f
PE
14613 (main): Add casts to avoid warnings
14614 if GCC considers string literals to be constants.
74f10ca7 14615
022e70d4
PE
14616 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14617
59d6fe83
PE
14618 * dbusbind.c: Pointer signedness fixes.
14619 (xd_signature, xd_append_arg, xd_initialize):
14620 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14621 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14622 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14623 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14624
78320123
PE
14625 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14626 if GCC considers string literals to be constants.
49cebcca 14627 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14628
35ac2a97
SM
146292011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14630
fb103ca9
SM
14631 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14632 (print_preprocess, print_object): New macro to fix last change.
14633
35ac2a97
SM
14634 * print.c (print_preprocess): Don't forget font objects.
14635
62973b41
JB
146362011-03-16 Juanma Barranquero <lekktu@gmail.com>
14637
14638 * emacs.c (USAGE3): Doc fixes.
14639
0e48bb22
AS
146402011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14641
14642 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14643 structure.
14644
7684e57b
JB
146452011-03-14 Juanma Barranquero <lekktu@gmail.com>
14646
14647 * lisp.h (VWindow_system, Qfile_name_history):
14648 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14649 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14650 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14651
14652 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14653 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14654
14655 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14656 * w32console.c (detect_input_pending, read_input_pending)
14657 (encode_terminal_code):
14658 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14659 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14660 (w32_system_caret_y, Qfile_name_history):
14661 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14662 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14663 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14664 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14665 * w32proc.c (Qlocal, report_file_error):
14666 * w32term.c (Vwindow_system, updating_frame):
14667 * w32uniscribe.c (initialized, uniscribe_font_driver):
14668 Remove unneeded extern declarations.
14669
2aa46d6c
CY
146702011-03-14 Chong Yidong <cyd@stupidchicken.com>
14671
c96bbc66 14672 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14673
cffc6f3b
CY
146742011-03-13 Chong Yidong <cyd@stupidchicken.com>
14675
14676 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14677 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14678 These macros can no longer be used for assignment.
14679
44f230aa
SM
14680 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14681 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14682 (record_buffer_markers, fetch_buffer_markers): New functions for
14683 recording and fetching special buffer markers.
14684 (set_buffer_internal_1, set_buffer_temp): Use them.
14685
14686 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14687
14688 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14689
14690 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14691 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14692
14693 * xdisp.c (hscroll_window_tree):
14694 (reconsider_clip_changes): Use PT instead of BUF_PT.
14695
d251f04b
EZ
146962011-03-13 Eli Zaretskii <eliz@gnu.org>
14697
14698 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14699 $(EMACS_ROOT)/lib/intprops.h.
14700
f0c77cd1
PE
147012011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14702
3eca4629
PE
14703 Fix more problems found by GCC 4.5.2's static checks.
14704
7c86ee98
PE
14705 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14706 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14707 (xg_free_frame_widgets): Make it clear that a local variable is
14708 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14709 (gdk_window_get_screen): Make it clear that this macro is needed
14710 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14711 (int_gtk_range_get_value): New function, which avoids a diagnostic
14712 from gcc -Wbad-function-cast.
14713 (xg_set_toolkit_scroll_bar_thumb): Use it.
14714 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14715 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14716 (get_utf8_string, xg_get_file_with_chooser):
14717 Rename locals to avoid shadowing.
14718 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14719
41729b81
PE
14720 * xgselect.c (xg_select): Remove unused var.
14721
f0c77cd1
PE
14722 * image.c (four_corners_best): Mark locals as initialized.
14723 (gif_load): Initialize transparent_p to zero (Bug#8238).
14724 Mark another local as initialized.
ec6cf4c6 14725 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14726
ce0ad53d 14727 * image.c (clear_image_cache): Now static.
d5d5a617 14728 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14729 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14730 (x_edge_detection): Remove unnecessary cast that
14731 gcc -Wbad-function-cast diagnoses.
2037898d 14732 (gif_load): Fix pointer signedness.
6ae141d6
PE
14733 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14734 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14735
33383987 147362011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14737
d32df629
PE
14738 Improve quality of tests for time stamp overflow.
14739 For example, without this patch (encode-time 0 0 0 1 1
14740 1152921504606846976) returns the obviously-bogus value (-948597
14741 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14742 reports time overflow. See
14743 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14744 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14745 * editfns.c: Include limits.h and intprops.h.
14746 (TIME_T_MIN, TIME_T_MAX): New macros.
14747 (time_overflow): Move earlier, to before first use.
14748 (hi_time, lo_time): New functions, for an accurate test for
14749 out-of-range times.
14750 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14751 (Fget_internal_run_time): Don't assume time_t fits in int.
14752 (make_time): Use list2 instead of Fcons twice.
14753 (Fdecode_time): More accurate test for out-of-range times.
14754 (check_tm_member): New function.
14755 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14756 (lisp_time_argument): Don't rely on undefined left-shift and
14757 right-shift behavior when checking for time stamp overflow.
8be6f318 14758
fe31d94c
PE
14759 * editfns.c (time_overflow): New function, refactoring common code.
14760 (Fformat_time_string, Fdecode_time, Fencode_time):
14761 (Fcurrent_time_string): Use it.
14762
8be6f318
PE
14763 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14764 * dired.c (make_time): Move to ...
14765 * editfns.c (make_time): ... here.
14766 * systime.h: Note the move.
14767
09d9db2c 147682011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14769
126bc0dc
YM
14770 * fringe.c (update_window_fringes): Remove unused variables.
14771
c47cbdfd
YM
14772 * unexmacosx.c (copy_data_segment): Also copy __got section.
14773 (Bug#8223)
14774
7ac80be9
EZ
147752011-03-12 Eli Zaretskii <eliz@gnu.org>
14776
c96bbc66 14777 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14778 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14779 Constify `char *' arguments and their references according to
14780 prototypes in tparam.h.
14781
ecb0f94d 14782 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14783
7ac80be9
EZ
14784 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14785 Adapt all references accordingly.
14786
14787 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14788
ef1fd07e
TT
147892011-03-11 Tom Tromey <tromey@redhat.com>
14790
14791 * buffer.c (syms_of_buffer): Remove obsolete comment.
14792
7ef4b50c
EZ
147932011-03-11 Eli Zaretskii <eliz@gnu.org>
14794
14795 * termhooks.h (encode_terminal_code): Declare prototype.
14796
14797 * msdos.c (encode_terminal_code): Don't declare prototype.
14798
14799 * term.c (encode_terminal_code): Now external again, used by
14800 w32console.c and msdos.c.
14801
44f230aa
SM
14802 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14803 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14804
4b1ec863 148052011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14806
1714f52b 14807 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14808
4b1ec863
PE
14809 * fringe.c (update_window_fringes): Mark locals as initialized
14810 (Bug#8227).
14811 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14812
524c7aa6
PE
14813 * alloc.c (mark_fringe_data): Move decl from here ...
14814 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14815 to check its interface.
14816 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14817
a5c0af81 14818 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14819 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14820 (fontset_font): Mark local as initialized.
a9a06e0b 14821 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14822
b4716021
PE
14823 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14824
811e9bac 14825 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14826 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14827 (x_own_selection, Fx_disown_selection_internal): Rename locals
14828 to avoid shadowing.
14829 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14830
7e3ab302
PE
14831 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14832 so that the caller can use some name other than gcpro1.
14833 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14834 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14835 (Fx_backspace_delete_keys_p):
14836 Use them to avoid shadowing, and rename vars to avoid shadowing.
14837 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14838 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14839 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14840 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14841 Remove unused locals.
7e3ab302
PE
14842 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14843 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14844 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14845 macros.
f78faa98 14846
e2b13473
PE
14847 * xterm.h (x_mouse_leave): New decl.
14848
77f23912
PE
14849 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14850 Remove unused functions.
cdf4ba58
PE
14851 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14852 (x_calc_absolute_position): Now static.
7411c686 14853 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14854 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14855 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14856 unless they are used.
38d0b34a
PE
14857 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14858 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14859 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14860 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14861 (x_error_catcher, x_connection_closed, x_error_handler):
14862 (x_error_quitter, xembed_send_message, x_iconify_frame):
14863 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14864 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14865 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14866
44f230aa
SM
14867 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14868 Rename or move locals to avoid shadowing.
6b463e58 14869 (tty_defined_color, merge_face_heights): Now static.
5967d051 14870 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14871 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14872 does not deduce is never used uninitialized.
73719eba
PE
14873 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14874 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14875
426994c3 14876 * terminal.c (store_terminal_param): Now static.
5489860b 14877
032f1620 14878 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14879 (set_frame_menubar): Remove unused local.
d4323972 14880 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14881 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14882 since they might point to immutable storage.
281585b0
PE
14883 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14884 since it's unused otherwise.
032f1620 14885
367c19e5 14886 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14887 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14888 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14889 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14890 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14891 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14892 does not deduce are never used uninitialized.
70739cbe 14893
07b48fa9
PE
14894 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14895
8868a238 14896 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14897 * window.c (window_loop, size_window):
14898 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14899
7e5cf297 14900 * window.c (display_buffer): Now static.
d6550a9f
PE
14901 (size_window): Mark variables that gcc -Wuninitialized
14902 does not deduce are never used uninitialized.
a586633d
PE
14903 * window.h (check_all_windows): New decl, to forestall
14904 gcc -Wmissing-prototypes diagnostic.
5b555da1 14905 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14906
f6095868
PE
14907 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14908 shadowing.
14909 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14910 Include <limits.h>.
14911 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14912 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14913 (load_charset_map): Mark variables that gcc -Wuninitialized
14914 does not deduce are never used uninitialized.
53df7c11 14915 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14916
f38b440c
PE
14917 * coding.c (coding_set_source, coding_set_destination):
14918 Use "else { /* comment */ }" rather than "else /* comment */;"
14919 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14920 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14921 a block, when the outer 'i' will do.
14922 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14923 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14924 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14925 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14926 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14927 Rename locals to avoid shadowing.
14928 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14929 * coding.c (emacs_mule_char, encode_invocation_designation):
14930 Now static, since they're not used elsewhere.
413bb2db 14931 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14932 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14933 (decode_coding_emacs_mule): Mark variables that gcc
14934 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14935 (detect_coding_iso_2022): Initialize a local variable that might
14936 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14937 this initialization is needed. (Bug#8211)
5f58e762
PE
14938 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14939 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14940 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14941 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14942 Remove unused macros.
f38b440c 14943
232b38b9 14944 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14945 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14946 * character.c (string_count_byte8): Likewise.
232b38b9 14947
fb90da1b
PE
14948 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14949 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14950
fb93dbc2
PE
14951 * chartab.c (copy_sub_char_table): Now static, since it's not used
14952 elsewhere.
5c156ace
PE
14953 (sub_char_table_ref_and_range, char_table_ref_and_range):
14954 Rename locals to avoid shadowing.
bbcd0949 14955 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14956
7d3b3862 14957 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14958 (BIDI_BOB): Remove unused macro.
7d3b3862 14959
6be7d3da
PE
14960 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14961 deduce are never used uninitialized.
c2ed9c8b 14962 * term.c (encode_terminal_code): Likewise.
6be7d3da 14963
75f8807f 14964 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14965
50938595
PE
14966 * tparam.h: New file.
14967 * term.c, tparam.h: Include it.
14968 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14969 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14970 Move these decls to tparam.h, and make them agree with what
14971 is actually in tparam.c. The previous trick of using incompatible
14972 decls in different modules does not conform to the C standard.
14973 All callers of tparam changed to use tparam's actual API.
14974 * tparam.c (tparam1, tparam, tgoto):
14975 Use const pointers where appropriate.
14976
fbceeba2
PE
14977 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14978 * cm.h (struct cm): Likewise.
14979 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14980 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14981 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14982 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14983 (turn_on_face, init_tty): Likewise.
14984 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14985
7f3f1250
PE
14986 * term.c (term_mouse_position): Rename local to avoid shadowing.
14987
e6ca6543
PE
14988 * alloc.c (mark_ttys): Move decl from here ...
14989 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14990
c40f8d15
AS
149912011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14992
14993 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14994
cfe0661d
JB
149952011-03-09 Juanma Barranquero <lekktu@gmail.com>
14996
14997 * search.c (compile_pattern_1): Remove argument regp, unused since
14998 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14999 (compile_pattern): Don't pass it.
15000
0afb4571
J
150012011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15002
15003 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15004 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15005 for ! HAVE_GTK3.
15006 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15007
15008 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15009
15010 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15011 gdk_window_get_screen, gdk_window_get_geometry,
15012 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15013 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15014 (xg_get_pixbuf_from_pixmap): New function.
15015 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15016 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15017 Call xg_get_pixbuf_from_pixmap instead of
15018 gdk_pixbuf_get_from_drawable.
15019 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15020 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15021 (xg_check_special_colors): Use GtkStyleContext and its functions
15022 for HAVE_GTK3.
15023 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15024 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15025 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15026 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15027 Call gtk_widget_get_preferred_size.
0afb4571
J
15028 (xg_frame_resized): gdk_window_get_geometry only takes 5
15029 parameters.
44f230aa
SM
15030 (xg_win_to_widget, xg_event_is_for_menubar):
15031 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15032 (xg_set_widget_bg): New function.
15033 (delete_cb): New function.
895009e1 15034 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15035 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15036 (xg_set_background_color): Call xg_set_widget_bg.
15037 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15038 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15039 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15040 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15041 if ! HAVE_GTK3.
15042 (update_frame_tool_bar): Call gtk_widget_hide.
15043 (xg_initialize): Use GDK_KEY_g.
15044
15045 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15046 if ! HAVE_GTK3
15047 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15048
15049 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15050 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15051 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15052
1c2cc4ef
JB
150532011-03-08 Juanma Barranquero <lekktu@gmail.com>
15054
15055 * w32xfns.c (select_palette): Check success of RealizePalette against
15056 GDI_ERROR, not zero.
15057
33383987 15058See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15059
15060;; Local Variables:
15061;; coding: utf-8
aac0c6e3
MR
15062;; End:
15063
2f097256 15064 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15065
15066 This file is part of GNU Emacs.
15067
15068 GNU Emacs is free software: you can redistribute it and/or modify
15069 it under the terms of the GNU General Public License as published by
15070 the Free Software Foundation, either version 3 of the License, or
15071 (at your option) any later version.
15072
15073 GNU Emacs is distributed in the hope that it will be useful,
15074 but WITHOUT ANY WARRANTY; without even the implied warranty of
15075 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15076 GNU General Public License for more details.
15077
15078 You should have received a copy of the GNU General Public License
15079 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.