Fix typos.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c7015153
JB
12011-11-15 Juanma Barranquero <lekktu@gmail.com>
2
3 * image.c (imagemagick_load_image): Fix typo.
4
322ad6ec
EZ
52011-11-14 Eli Zaretskii <eliz@gnu.org>
6
7 * xdisp.c (display_line): Move the call to
8 highlight_trailing_whitespace before the call to
9 compute_line_metrics, since the latter needs to see the final
10 faces of all the glyphs to compute ROW's hash value. Fixes
11 assertion violations in row_equal_p. (Bug#10035)
12
f067b8ec
JB
132011-11-14 Juanma Barranquero <lekktu@gmail.com>
14
15 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
16 just return (bug#10044).
17
1e5b2111
EZ
182011-11-12 Eli Zaretskii <eliz@gnu.org>
19
7ef3cbd5
EZ
20 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
21 with user-defined heap size. Bump the default size of the temacs
22 heap to 27MB, to avoid memory warning when running temacs.
23 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
24
1e5b2111
EZ
25 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
26 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
27 (verify_row_hash) [XASSERTS]: New function.
28 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
29 that the hash value of glyph rows is correct.
1e5b2111 30
89d61221
MR
312011-11-12 Martin Rudalics <rudalics@gmx.at>
32
33 * window.h (window): Remove splits slot.
34 * window.c (Fwindow_splits, Fset_window_splits): Remove.
35 (Fdelete_other_windows_internal, make_parent_window)
36 (make_window, Fsplit_window_internal, Fdelete_window_internal)
37 (Fset_window_configuration, save_window_save): Don't deal with
38 split status of windows.
39 (saved_window): Remove splits slot.
40 (Vwindow_splits): Rewrite doc-string.
41
97f18cc8
JD
422011-11-11 Jan Djärv <jan.h.d@swipnet.se>
43
44 * xfns.c (unwind_create_frame):
45 * nsfns.m (unwind_create_frame):
46 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
47 Vframe_list (Bug#9999).
48
22a648b4
DA
492011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
50
0b381c7e 51 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 52
659afede
KH
532011-11-11 Kenichi Handa <handa@m17n.org>
54
55 * callproc.c (Fcall_process): Set the member dst_multibyte of
56 process_coding.
57
9ac0394b
KH
582011-11-11 Johan Bockgård <bojohan@gnu.org>
59
60 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
61 avoid a crash (bug#9496).
62
2fbdc249
CY
632011-11-09 Chong Yidong <cyd@gnu.org>
64
65 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
66 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
67
ac6b1f81
PE
682011-11-08 Paul Eggert <eggert@cs.ucla.edu>
69
70 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
71
09db192c
PE
722011-11-08 Paul Eggert <eggert@cs.ucla.edu>
73
74 Avoid some portability problems by eschewing 'extern inline' functions.
75 The trivial performance wins aren't worth the portability hassles; see
76 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
77 et seq.
78 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
79 (window_box_width, window_box_left, window_box_left_offset)
80 (window_box_right, window_box_right_offset): Undo previous change,
81 by removing the "extern"s.
82 * intervals.c (adjust_intervals_for_insertion)
83 (adjust_intervals_for_deletion): Undo previous change,
84 making these static again.
85 (offset_intervals, temp_set_point_both, temp_set_point)
86 (copy_intervals_to_string): No longer inline.
87 * xdisp.c (window_text_bottom_y, window_box_width)
88 (window_box_height, window_box_left_offset)
89 (window_box_right_offset, window_box_left, window_box_right)
90 (window_box): No longer inline.
91
105216ed
CY
922011-11-08 Chong Yidong <cyd@gnu.org>
93
94 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
95 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
96 an error if not a live window.
97 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
98 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
99
ae9e237f
JB
1002011-11-07 Juanma Barranquero <lekktu@gmail.com>
101
102 * lisp.h (syms_of_abbrev): Remove declaration.
103 Reported by CHENG Gao <chenggao@royau.me>.
104
c7aa8333
EZ
1052011-11-07 Eli Zaretskii <eliz@gnu.org>
106
107 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
108 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
109 of temacs in GUI mode.
110
be7f5545
MR
1112011-11-07 Martin Rudalics <rudalics@gmx.at>
112
113 * window.h: Declare delete_all_child_windows instead of
114 delete_all_subwindows.
115 * window.c (Fwindow_nest, Fset_window_nest)
116 (Fset_window_new_total, Fset_window_new_normal)
117 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
118 (delete_all_subwindows): Rename to delete_all_child_windows.
119 (Fdelete_other_windows_internal, Fset_window_configuration):
120 Call delete_all_child_windows instead of delete_all_subwindows.
121 * frame.c (delete_frame): Call delete_all_child_windows instead
122 of delete_all_subwindows.
123
ca78dc43
PE
1242011-11-07 Paul Eggert <eggert@cs.ucla.edu>
125
126 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
127 This is also needed for porting to any host where GC_MARK_STACK is
128 not GC_MAKE_GCPROS_NOOPS.
129 (which_symbols): Use it.
130
a0241d01
KH
1312011-11-07 Kenichi Handa <handa@m17n.org>
132
133 * coding.c (coding_set_destination): Check coding->src_pos only
134 when coding->src_object is a buffer (bug#9910).
135
136 * process.c (send_process): Set the member src_multibyte of coding
137 to 0 (bug#9911) when sending a unibyte text.
138
139 * callproc.c (Fcall_process): Set the member src_multibyte of
140 process_coding to 0 (bug#9912).
141
a64bfdfa 1422011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
143
144 * xmenu.c (cleanup_widget_value_tree): New function.
145 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
146 calling free_menubar_widget_value_tree directly (Bug#9830).
147
cb41b32a
PE
1482011-11-06 Paul Eggert <eggert@cs.ucla.edu>
149
150 Fix some portability problems with 'inline'.
151 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
152 (window_box_width, window_box_left, window_box_left_offset)
153 (window_box_right, window_box_right_offset): Declare extern.
154 Otherwise, these inline functions do not conform to C99 and
155 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
156 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
157 * intervals.c (adjust_intervals_for_insertion)
158 (adjust_intervals_for_deletion): Now extern, because otherwise the
159 extern inline functions 'offset_intervals' couldn't refer to it.
160 (static_offset_intervals): Remove.
161 (offset_intervals): Rewrite using the old contents of
162 static_offset_intervals. The old version didn't conform to C99
163 because an extern inline function contained a reference to an
164 identifier with static linkage.
165
b7041366
AS
1662011-11-06 Andreas Schwab <schwab@linux-m68k.org>
167
168 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
169 GC.
170
88a37c4d
EZ
1712011-11-06 Eli Zaretskii <eliz@gnu.org>
172
173 * xdisp.c (init_iterator, reseat_to_string): Don't set the
174 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
175 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
176 return Qleft_to_right.
177
49745b39
CY
1782011-11-06 Chong Yidong <cyd@gnu.org>
179
180 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
181 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
182 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
183 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
184 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
185 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
186 (Fwindow_vscroll): Doc fix.
187 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
188 argument, since it makes no sense to pass a live window and for
189 consistency with window-child.
190
1f05cd82
CS
1912011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
192
193 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
194 support MSVC.
195
22610910
JR
1962011-11-05 Jason Rumney <jasonr@gnu.org>
197
198 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
199 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
200 fonts (Bug#6029).
201 (add_font_entity_to_list): Fix logic errors in mixed boolean and
202 bitwise arithmetic preventing use of unicode-sip and non-truetype
203 opentype fonts.
204
a06776b2
EZ
2052011-11-05 Eli Zaretskii <eliz@gnu.org>
206
3ad924ba
EZ
207 * s/ms-w32.h (fstat, stat, utime): Move redirections to
208 "emacs"-only part.
209
a06776b2
EZ
210 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
211 initialization code to keep similarity to xfns.c after changes
212 from 2011-11-05.
213
c9e7db78
JD
2142011-11-05 Jan Djärv <jan.h.d@swipnet.se>
215
a97f8f3f
JD
216 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
217 (unwind_create_frame): New function (Bug#9943).
218 (Fx_create_frame): Restructure code to be more similar to the one in
219 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
220 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
221 Move terminal->reference_count++ just before making the frame official
222 (Bug#9943).
223
224 * nsterm.m (x_free_frame_resources): New function.
225 (x_destroy_window): Move code to x_free_frame_resources.
226
c9e7db78
JD
227 * xfns.c (unwind_create_frame): Fix comment.
228 (Fx_create_frame, x_create_tip_frame): Move
229 terminal->reference_count++ just before making the frame
230 official. Move initialization of image_cache_refcount and
231 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
232
a6fc3b5c
EZ
2332011-11-05 Eli Zaretskii <eliz@gnu.org>
234
235 Support MSVC build with newer versions of Visual Studio.
236 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
237 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
238 nt/gmake.defs.
239
240 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
241 which are not supported by MSVC.
242 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
243 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
244 bitfields.
245 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
246 types in bitfields.
247 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
248
249 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
250
2512011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
252
253 Support MSVC build with newer versions of Visual Studio.
254 * w32.c: Don't include w32api.h for MSVC.
255 (init_environment) [_MSC_VER]: Call sys_access, not _access.
256
257 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
258 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
259 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
260 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
261 e_* cousins.
262 (alloca) [_MSC_VER]: Define to _alloca.
263
264 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
265
266 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
267
a58c13ed
EZ
2682011-11-04 Eli Zaretskii <eliz@gnu.org>
269
270 * xdisp.c (note_mouse_highlight): If either of
271 previous/next-single-property-change returns nil, treat that as
272 the beginning or the end of the buffer. (Bug#9955)
273
fe0b6370
JD
2742011-11-04 Jan Djärv <jan.h.d@swipnet.se>
275
a58c13ed 276 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
277 label is not null (Bug#9951).
278 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
279 may be NULL.
280
89bd5ee1
EZ
2812011-11-04 Eli Zaretskii <eliz@gnu.org>
282
283 * window.c (Fwindow_body_size): Mention in the doc string that the
284 return value is in frame's canonical units. (Bug#9949)
285
84c3edb9
EZ
2862011-11-03 Eli Zaretskii <eliz@gnu.org>
287
4e2fb5c7
EZ
288 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
289
84c3edb9 290 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 291 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 292 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 293
bc17a887
EZ
2942011-11-01 Eli Zaretskii <eliz@gnu.org>
295
296 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
297 Don't stop backward scan on the continuation glyph, even though
298 its CHARPOS is positive.
26b46e51
EZ
299 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
300 cover_string to disp_string.
bc17a887 301
4ee88440
MR
3022011-11-01 Martin Rudalics <rudalics@gmx.at>
303
304 * window.c (temp_output_buffer_show): Don't use
305 Vtemp_buffer_show_specifiers.
306 (Vtemp_buffer_show_specifiers): Remove unused variable.
307
c2ff3c02
EZ
3082011-10-30 Eli Zaretskii <eliz@gnu.org>
309
310 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
311 past the beginning of the current glyph matrix.
312
6e56383b
JD
3132011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
314
315 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
316 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
317 HAVE_GTK3 (Bug#9869).
b77a6a7f 318
3b574623
JD
319 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
320 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
321
b77a6a7f
JD
322 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
323
324 * xterm.c: Declare x_handle_net_wm_state to return int.
325 (handle_one_xevent): Check if we are iconified but don't have
326 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
327 (get_current_wm_state): Return non-zero if not hidden,
328 check for _NET_WM_STATE_HIDDEN (Bug#9893).
329 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
330 (x_handle_net_wm_state): Return what get_current_wm_state returns.
331 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
332
196e41e4
PE
3332011-10-29 Paul Eggert <eggert@cs.ucla.edu>
334
335 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
336 so that this new function doesn't get optimized away by a
337 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
338
021f2e1a
AS
3392011-10-29 Andreas Schwab <schwab@linux-m68k.org>
340
341 * frame.h (MOUSE_HL_INFO): Remove excess parens.
342
8b058d44
EZ
3432011-10-29 Eli Zaretskii <eliz@gnu.org>
344
345 Fix the `xbytecode' command.
346 * .gdbinit (xprintbytestr): New command.
347 (xwhichsymbols): Renamed from `which'; all callers changed.
348 (xbytecode): Print the byte-code string as well.
349
4452fb80
EZ
3502011-10-29 Kim Storm <storm@cua.dk>
351
8b058d44
EZ
352 * alloc.c (which_symbols): New function.
353
21b72067
AS
3542011-10-29 Andreas Schwab <schwab@linux-m68k.org>
355
356 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
357 line. (Bug#9903)
358
83ed7b5c
GM
3592011-10-29 Glenn Morris <rgm@gnu.org>
360
361 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
362 Not clear what it was for, and it causes various bugs. (Bug#9839)
363
5a7a728b
EZ
3642011-10-28 Eli Zaretskii <eliz@gnu.org>
365
366 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
367 possible random value that matches one of those tested as
368 condition to clear the mouse face.
369
d3d0842f
CY
3702011-10-28 Chong Yidong <cyd@gnu.org>
371
372 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
373
31b39d13
DN
3742011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
375
376 * window.c (make_window): Initialize phys_cursor_on_p.
377
9aba6043
SM
3782011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
379
380 * lisp.h (struct Lisp_Symbol): Update comments.
381
c20992f4
JB
3822011-10-28 Juanma Barranquero <lekktu@gmail.com>
383
384 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
385
db4f02f2
EZ
3862011-10-28 Eli Zaretskii <eliz@gnu.org>
387
388 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
389 <oslsachem@gmail.com> for helping to debug this.
390
391 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
392 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
393 (g_b_init_get_glyph_outline_w): New static variables.
394 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
395 (GetGlyphOutlineW_Proc): New typedefs.
396 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
397 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
398 New functions.
399 (w32font_open_internal, compute_metrics):
400 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
401 instead of calling the "wide" APIs directly.
402
403 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
404
405 * w32.h (syms_of_w32font): Add prototype.
406
87e68db4
JB
4072011-10-27 Juanma Barranquero <lekktu@gmail.com>
408
409 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
410 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
411 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
412 (Fmove_to_window_line): Doc fix.
413
435c1d67
CY
4142011-10-27 Chong Yidong <cyd@gnu.org>
415
416 * process.c (make_process): Set gnutls_state to NULL.
417
418 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
419 non-NULL, regardless of GNUTLS_INITSTAGE.
420 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
421 an error. Set process slots as soon as we allocate them.
422
423 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
424
9c6c6f49
CY
4252011-10-27 Chong Yidong <cyd@gnu.org>
426
9aba6043
SM
427 * gnutls.c (emacs_gnutls_deinit): New function.
428 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
429 (Fgnutls_deinit, Fgnutls_boot): Use it.
430
431 * process.c (make_process): Initialize GnuTLS credentials to NULL.
432 (deactivate_process): Call emacs_gnutls_deinit.
433
657d08d3
JB
4342011-10-27 Juanma Barranquero <lekktu@gmail.com>
435
436 * image.c (x_create_x_image_and_pixmap):
437 * w32.c (sys_rename, w32_delayed_load):
438 * w32font.c (fill_in_logfont):
439 * w32reg.c (x_get_string_resource): Silence compiler warnings.
440
5430d399
JB
4412011-10-26 Juanma Barranquero <lekktu@gmail.com>
442
443 * w32fns.c (w32_default_color_map): New function,
444 extracted from Fw32_default_color_map.
a7ef684b 445 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 446
fe0055fa
PE
4472011-10-25 Paul Eggert <eggert@cs.ucla.edu>
448
449 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
450
e6346438
SM
4512011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
452
453 * keyboard.c (test_undefined): New function (bug#9751).
454 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
455
e112cc37
ET
4562011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
457
458 * sysdep.c (init_sys_modes): Fix the check for the controlling
459 terminal (Bug#6649).
460
7b5d6677
EZ
4612011-10-20 Eli Zaretskii <eliz@gnu.org>
462
463 * dispextern.h (struct bidi_it): New member next_en_type.
464
465 * bidi.c (bidi_line_init): Initialize the next_en_type member.
466 (bidi_resolve_explicit_1): When next_en_pos is valid for the
467 current character, check also for next_en_type being WEAK_EN.
468 (bidi_resolve_weak): Don't enter the expensive loop if the current
469 position is before next_en_pos. Record the bidi type of the first
470 non-ET, non-BN character we find, in addition to its position.
471 (bidi_level_of_next_char): Invalidate next_en_type when
472 next_en_pos is over-stepped.
473
7da0b018
PE
4742011-10-20 Paul Eggert <eggert@cs.ucla.edu>
475
476 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
477 * editfns.c: Rewrite current-time-zone so that it invokes
478 the equivalent of (format-time-string "%Z") to get the time zone name.
479 This fixes a bug when the time zone name contains characters that
480 need converting from the system time locale to Emacs internal format.
481 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
482 that patch fixed format-time-string to do the conversion, but
483 I forgot to fix current-time-zone.
484 (format_time_string): New function, containing most of
485 what Fformat_time_string used to contain.
486 (Fformat_time_string): Rewrite in terms of format_time_string.
487 This doesn't change this function's behavior.
488 (current-time-zone): Rewrite to use format_time_string.
489 This fixes the bug reported by Michael Schierl in
490 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
491 Jason Rumney's 2007-06-07 change worked around this bug, but
492 didn't fix it.
493 * systime.h (tzname, timezone): Remove no-longer-used declarations.
494
8547b010
EZ
4952011-10-19 Eli Zaretskii <eliz@gnu.org>
496
497 * xdisp.c (start_display): If the character at POS is displayed
498 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
499 (try_window_reusing_current_matrix): If a line ends in a display
500 vector or the next line starts in a display vector, continue
501 redrawing the window even though the character position of
502 start_row was reached.
8547b010
EZ
503 (Bug#9771, part 2)
504
4e948d15
CY
5052011-10-18 Chong Yidong <cyd@gnu.org>
506
507 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
508 with nobreak-char-display too.
509
4787455f
EZ
5102011-10-18 Eli Zaretskii <eliz@gnu.org>
511
512 Fix part 3 of bug#9771.
513 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
514 (bidi_resolve_neutral): Don't enter the expensive loop looking for
515 non-neutral characters if the current character is a paragraph
516 separator (a.k.a. Newline). This avoids running the same
517 expensive loop twice, once when we consume the preceding newline
518 and the other time when the line actually needs to be displayed.
519 Avoid the loop when we see neutrals on the base embedding level
520 following a character whose directionality is the same as the
521 paragraph's. This avoids running the expensive loop when a line
522 ends in a long sequence of neutrals, like control characters.
523 Add assertion against STRONG_AL type. Slightly rearrange code
524 that determines the type of a neutral given the first non-neutral
525 that follows it.
526 (bidi_level_of_next_char): Set next_en_pos to zero when
527 invalidating its info.
528
2c91f553
EZ
5292011-10-17 Eli Zaretskii <eliz@gnu.org>
530
531 * xdisp.c (push_display_prop): Determine whether to record string
532 or buffer position by IT->string, not by IT->method. Allow
533 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
534 (move_it_vertically_backward): Don't look for character position
535 immediately after the newline when in a continuation line.
536 (Bug#9771, part 1)
2c91f553 537
c7b08b0d
MR
5382011-10-15 Martin Rudalics <rudalics@gmx.at>
539
540 * window.c (coordinates_in_window): Rewrite and delabelize
541 vertical border check. (Bug#5357) (Bug#9618)
542
6b02f655
SM
5432011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
544
545 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
546 errors in XSetWindowBorder (bug#9310).
547
81d40c92
DA
5482011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
549
550 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
551 avoid crash when xmalloc overrun checking is enabled.
552
d4172c3b
EZ
5532011-10-13 Eli Zaretskii <eliz@gnu.org>
554
555 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
556 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
557 cursor motion with <left> and <right> arrow keys.
558
559 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
560 some callers set that themselves.
561
b00eea75
EZ
5622011-10-12 Eli Zaretskii <eliz@gnu.org>
563
564 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
565 display string and the previous row comes from the same string and
566 is empty. (Bug#9739) (Bug#9738)
567
8fe012c4
SM
5682011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
569
570 * doc.c (get_doc_string): Encode file name (bug#9735).
571
0074aef2
EZ
5722011-10-12 Eli Zaretskii <eliz@gnu.org>
573
79beb178
EZ
574 * bidi.c (bidi_level_of_next_char):
575 * xdisp.c (get_visually_first_element): Remove old incorrect
576 comments regarding the Unicode Line Separator character.
577
0074aef2
EZ
578 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
579
6e4b3fbe
DA
5802011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
581
582 * alloc.c (Fgc_status): Do not access beyond zombies array
583 boundary if nzombies > MAX_ZOMBIES.
584 * alloc.c (dump_zombies): Add missing format specifier.
585
0324f3af
PE
5862011-10-12 Paul Eggert <eggert@cs.ucla.edu>
587
b5525cac
PE
588 * xdisp.c (set_cursor_from_row): Simplify conditionals,
589 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
590
0324f3af
PE
591 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
592 Some packages use them to denote characters with modifiers.
593
e9b5f888
AS
5942011-10-11 Andreas Schwab <schwab@linux-m68k.org>
595
596 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
597 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
598 matching a pp-number. Rename parameter var to var1.
599
127827c0
SM
6002011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
601
602 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
603
c8fd3bd0
GM
6042011-10-08 Glenn Morris <rgm@gnu.org>
605
606 * callint.c (Fcall_interactively): Give a more explicit error for the
607 'c' case with a non-character input. (Bug#8479)
608
352ec8ff
EZ
6092011-10-08 Eli Zaretskii <eliz@gnu.org>
610
03669ccb
EZ
611 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
612 lines.
7061c986
EZ
613 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
614 lines that are hscrolled on the left.
03669ccb 615
352ec8ff
EZ
616 * dispnew.c (buffer_posn_from_coords): Account for a possible
617 presence of header-line. (Bug#4426)
618
a66cfb1c
SM
6192011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
620
6b02f655
SM
621 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
622 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 623
7c5ee88e
PE
6242011-10-07 Paul Eggert <eggert@cs.ucla.edu>
625
626 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
627 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
628 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
629 this makes Emacs dump core during garbage collection on rare
630 occasions. sizeof is obviously inferior to offsetof here, so
631 stick with offsetof.
632 (GC_POINTER_ALIGNMENT): New macro.
633 (mark_memory): Omit 3rd (offset) arg; caller changed.
634 Don't assume EMACS_INT alignment is the same as pointer alignment.
635
df1bbe5b
SM
6362011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
637
638 * keyboard.c (read_key_sequence_remapped): New var.
639 (read_key_sequence): Compute remapping in the right buffer.
640 (command_loop_1): Use read_key_sequence's remapping directly.
641
51553db6
SM
6422011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
643
32c1fffd
SM
644 * dired.c (file_name_completion): Don't expand file name.
645 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
646 before checking file name handler.
647
51553db6
SM
648 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
649 they've been requested explicitly (bug#9591).
650
b6bd1599 6512011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
652
653 * keymap.c (Fsingle_key_description): Use make_specified_string
654 instead of build_string to build string from push_key_description.
655 (Bug#5193)
656
f701dc2a
PE
6572011-09-30 Paul Eggert <eggert@cs.ucla.edu>
658
4222c55d
PE
659 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
660 This fixes a Y2038 bug on 64-bit hosts.
661 * buffer.c (reset_buffer):
662 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
663 (Fclear_buffer_auto_save_failure):
664 Use 0, not -1, to represent an unset failure time, since time_t
665 might not be signed.
666
f701dc2a
PE
667 Remove dependency on glibc malloc internals.
668 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
669 Move back here from lisp.h, but with their new implementations.
670 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
671 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
672 * charset.c (charset_table_init): New static var.
673 (syms_of_charset): Use it instead of xmalloc. This removes a
674 dependency on glibc malloc internals. See Eli Zaretskii's comment in
675 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
676 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
677 Move back to alloc.c.
678 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
679 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
680
9ceebf39
JD
6812011-09-30 Jan Djärv <jan.h.d@swipnet.se>
682
683 * nsterm.m (windowDidResize): Call x_set_window_size only when
684 ns_in_resize is true. Otherwise set pixelwidth/height and
685 call change_frame_size (Bug#9628).
686
cb993c58
PE
6872011-09-30 Paul Eggert <eggert@cs.ucla.edu>
688
3930c88b
PE
689 Port --enable-checking=all to Fedora 14 x86-64.
690 * charset.c (syms_of_charset): Also account for glibc malloc's
691 internal overhead when calculating the initial malloc maximum.
692
cb993c58
PE
693 Port --enable-checking=all to Fedora 14 x86.
694 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
695 Move to lisp.h.
696 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
697 (overrun_check_realloc, overrun_check_free):
698 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
699 That way, xmalloc returns a properly-aligned pointer even if
700 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
701 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
702 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
703 into account when calculating the initial malloc maximum.
704 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
705 Move here from alloc.c, so that charset.c can use it too.
706 Properly align; the old code wasn't right for common 32-bit hosts
707 when configured with --enable-checking=all.
708 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
709 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
710
31bed486
EZ
7112011-09-29 Eli Zaretskii <eliz@gnu.org>
712
04c70788 713 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
714 use EDOM.
715
fbcaa2f3
EZ
7162011-09-28 Eli Zaretskii <eliz@gnu.org>
717
718 * xdisp.c (compute_display_string_end): If there's no display
719 string at CHARPOS, return -1.
720
721 * bidi.c (bidi_fetch_char): When compute_display_string_end
722 returns a negative value, treat the character as a normal
723 character not covered by a display string. (Bug#9624)
724
a239d4e9
JB
7252011-09-28 Juanma Barranquero <lekktu@gmail.com>
726
727 * lread.c (Fread_from_string): Fix typo in docstring.
728
88652fd5
EZ
7292011-09-27 Eli Zaretskii <eliz@gnu.org>
730
731 * xdisp.c (handle_invisible_prop): If invisible text ends on a
732 newline, reseat the iterator instead of bidi-iterating there one
733 character at a time. (Bug#9610)
32c1fffd
SM
734 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
735 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 736
ed497dd4
AS
7372011-09-27 Andreas Schwab <schwab@linux-m68k.org>
738
739 * lread.c (readevalloop): Use correct code for NBSP.
740 (read1): Likewise. (Bug#9608)
741
b2bf61aa
MA
7422011-09-25 Michael Albinus <michael.albinus@gmx.de>
743
744 * dbusbind.c (Fdbus_register_signal): When service is not
745 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
746
32bbb17c
GM
7472011-09-25 Glenn Morris <rgm@gnu.org>
748
749 * buffer.c (truncate-lines): Doc fix.
750
94e0933e
CY
7512011-09-24 Chong Yidong <cyd@stupidchicken.com>
752
753 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
754 (Fset_window_next_buffers): Doc fix.
755
cddde921
GM
7562011-09-24 Glenn Morris <rgm@gnu.org>
757
758 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
759
1260aef1
PE
7602011-09-24 Paul Eggert <eggert@cs.ucla.edu>
761
25b4bfa0
PE
762 Fix minor problems found by static checking.
763 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
764 * indent.c (Fvertical_motion): Fix == vs = typo.
765
e3cbd34b
EZ
7662011-09-24 Eli Zaretskii <eliz@gnu.org>
767
a66cfb1c
SM
768 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
769 Default value is now t. Doc fix.
6bf7006f 770
e3cbd34b 771 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 772 logic when moving up, not only when moving down. Fix the
e3cbd34b 773 confusing name and values of the it_overshoot_expected variable;
32c1fffd 774 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
775
776 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
777 CHARPOS is covered by a display string which includes newlines.
778 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
779 is covered by a display string with embedded newlines.
780
a3de0cbd
MA
7812011-09-24 Michael Albinus <michael.albinus@gmx.de>
782
783 * dbusbind.c (Fdbus_register_signal): Add match rule to
784 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
785 (Fdbus_register_method, Vdbus_registered_objects_table):
786 Fix docstring.
a3de0cbd 787
b260039d
JM
7882011-09-24 Jim Meyering <meyering@redhat.com>
789
32c1fffd 790 do not ignore write error for any output size
b260039d
JM
791 The previous change was incomplete.
792 While it makes emacs --batch detect the vast majority of stdout
793 write failures, errors were still ignored whenever the output size is
794 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
795 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
796 && echo FAIL: ignored write error
797 FAIL: ignored write error
798 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
799 && echo FAIL: ignored write error
800 FAIL: ignored write error
801 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
802
8eca8a7c
AS
8032011-09-23 Andreas Schwab <schwab@linux-m68k.org>
804
805 * emacs.c (Fkill_emacs): In noninteractive mode exit
806 non-successfully if a write error occurred on stdout. (Bug#9574)
807
3341db62
EZ
8082011-09-21 Eli Zaretskii <eliz@gnu.org>
809
810 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
811 the xassert test.
812
813 * dispextern.h (struct it): Update the comment documenting what
814 can it->OBJECT be.
815
8c203dbf
EZ
8162011-09-20 Eli Zaretskii <eliz@gnu.org>
817
818 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
819 a display string, extend search for cursor position to end of row.
820 (find_row_edges): If the row ends in a newline from a display
821 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
822 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
823 (Fcurrent_bidi_paragraph_direction): Fix search for previous
824 non-empty line. Fixes confusing cursor motion with arrow keys at
825 the beginning of a line that starts with whitespace.
8c203dbf 826
a4824228
LMI
8272011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
828
829 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
830 (bug#9493).
831
33ed493b
CY
8322011-09-18 Chong Yidong <cyd@stupidchicken.com>
833
834 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
835 boolean (Bug#9154).
836
56cd55c8
EZ
8372011-09-18 Eli Zaretskii <eliz@gnu.org>
838
839 * xdisp.c (display_line): Record maximum and minimum buffer
840 positions even if no glyphs were produced (e.g., by a zero-width
841 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
842 buffer positions that will be removed from the glyph row because
843 they don't fit.
c02dcedf
EZ
844 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
845 column is beyond frame width: don't subtract 1 "pixel" when
846 computing width of the stretch.
3e62b7e0
EZ
847 (reseat_at_next_visible_line_start): Undo the change made on
848 2011-09-17 that saved paragraph information and restored it after
849 the call to `reseat'. (Bug#9545)
56cd55c8 850
5ed99d36 8512011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
852
853 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
854 and turn window cursor on if cleared (Bug#9415).
855
5ed99d36 8562011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
857
858 * search.c (boyer_moore): Take unibyte characters from pattern
859 literally. (Bug#9458)
860
9bade7b2
EZ
8612011-09-18 Eli Zaretskii <eliz@gnu.org>
862
863 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
864
e5e9d610
PE
8652011-09-18 Paul Eggert <eggert@cs.ucla.edu>
866
87e4427a
PE
867 Fix minor problem found by static checking.
868 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
869 initialized, to pacify gcc -Wuninitialized.
870
e5e9d610
PE
871 * fileio.c: Report proper errno when syscall falls.
872 (Finsert_file_contents): Save and restore errno,
873 so that report_file_error outputs the correct diagnostic.
874 (Fwrite_region) [CLASH_DETECTION]: Likewise.
875
a1674f0b
EZ
8762011-09-18 Eli Zaretskii <eliz@gnu.org>
877
878 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
879
fbfb6dd4
EZ
8802011-09-17 Eli Zaretskii <eliz@gnu.org>
881
882 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
883 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
884
bb187662
EZ
8852011-09-17 Eli Zaretskii <eliz@gnu.org>
886
1137e8b8 887 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 888 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
889
890 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
891 (bidi_find_paragraph_start): Search back for paragraph beginning
892 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
893 (bidi_move_to_visually_next): Only trigger paragraph-related
894 computations when the last character is a newline or at EOB, not
895 just any NEUTRAL_B. (Bug#9470)
896
bb187662
EZ
897 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
898 truncated lines if point is covered by a display string. (Bug#9524)
899
2e621251
PE
9002011-09-16 Paul Eggert <eggert@cs.ucla.edu>
901
902 * xselect.c: Relax test for outgoing X longs (Bug#9498).
903 (cons_to_x_long): New function.
904 (lisp_data_to_selection_data): Use it. Correct the test for
905 short-versus-long data; it was negated. Break out of vector
906 loop, for efficiency, when a long datum is discovered.
907
91a15bc6
SM
9082011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
909
910 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
911
b41c3a35
EZ
9122011-09-16 Eli Zaretskii <eliz@gnu.org>
913
914 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
915 GCC PR/17406) by declaring this function with external scope.
916
7812ba2d
PE
9172011-09-15 Paul Eggert <eggert@cs.ucla.edu>
918
919 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
920 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
921
cf7edc2a
AS
9222011-09-15 Andreas Schwab <schwab@linux-m68k.org>
923
924 * editfns.c (Fformat): Correctly handle text properties on "%%".
925
bd01620e
EZ
9262011-09-15 Eli Zaretskii <eliz@gnu.org>
927
928 * xterm.c (x_draw_composite_glyph_string_foreground):
929 * w32term.c (x_draw_composite_glyph_string_foreground):
930 * term.c (encode_terminal_code):
931 * composite.c (composition_update_it, get_composition_id):
932 * xdisp.c (get_next_display_element)
933 (fill_composite_glyph_string): Add comments about special meaning
934 of TAB characters in a composition.
935
a02719a3
PE
9362011-09-15 Paul Eggert <eggert@cs.ucla.edu>
937
938 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
939 This occurs when processing a multibyte format.
940 Problem reported by Wolfgang Jenker.
a02719a3 941
72589a3c
JB
9422011-09-15 Johan Bockgård <bojohan@gnu.org>
943
944 * xdisp.c (try_cursor_movement): Only check for exact match if
945 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
946
1c14176c
PE
9472011-09-14 Paul Eggert <eggert@cs.ucla.edu>
948
949 Remove unused external symbols.
950 * dispextern.h (calc_pixel_width_or_height): Remove decl.
951 * xdisp.c (calc_pixel_width_or_height): Now static.
952 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
953 * indent.c (check_display_width):
954 * w32term.c: Fix comment to match code.
955 * xterm.c, xterm.h (x_catching_errors): Remove.
956
d2eea5b5
PE
9572011-09-14 Paul Eggert <eggert@cs.ucla.edu>
958
959 * xselect.c: Use signed conversions more consistently (Bug#9498).
960 (selection_data_to_lisp_data): Assume incoming selection data are
961 signed integers, not unsigned. This is to be consistent with
962 outgoing selection data, which was modified to use signed integers
963 in as part of the fix to Bug#9196 in response to Jan D.'s comment
964 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
965 expects long, not unsigned long.
966
46888499
EZ
9672011-09-14 Eli Zaretskii <eliz@gnu.org>
968
969 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
970 computation of loop end. Reported by Johan Bockgård
971 <bojohan@gnu.org>.
972
ef8ef9fb
CY
9732011-09-13 Chong Yidong <cyd@stupidchicken.com>
974
975 * frame.c (Fother_visible_frames_p): Function deleted.
976
fa819fed
EZ
9772011-09-12 Eli Zaretskii <eliz@gnu.org>
978
979 * indent.c (compute_motion): Process display vector front to back
980 rather than the other way around. (Bug#2496)
981
2ba8e008
SM
9822011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
983
984 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
985
20f53c69
CY
9862011-09-11 Chong Yidong <cyd@stupidchicken.com>
987
988 * minibuf.c (Fread_from_minibuffer): Doc fix.
989
d562d7a4
EZ
9902011-09-11 Eli Zaretskii <eliz@gnu.org>
991
992 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
993 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
994
1c4d7f3d
LMI
9952011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
996
997 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
998 value for non-existent files.
999
b885bf36
EZ
10002011-09-11 Eli Zaretskii <eliz@gnu.org>
1001
1002 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1003 set its "size" to -1. This will set the modtime_size field of
1004 the corresponding buffer to -1, which is what
1005 verify-visited-file-modtime expects for files that do not exist.
1006 (Bug#9139)
1007
6612f0bf
PE
10082011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1009
1010 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1011 here ...
1012 * lisp.h: ... from here. push_key_description is no longer
1013 defined in keyboard.c, so its declaration should not be in
1014 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1015 logically belongs with push_key_description.
1016
dfb3f755
PE
10172011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1018
1019 * buffer.h: Include <sys/types.h> instead of <time.h>.
1020 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1021 Problem reported by Herbert J. Skuhra.
1022
3134906c
LMI
10232011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1024
1025 * xml.c (parse_region): Make the parsing work for
1026 non-comment-starting XML files again (bug#9144).
1027
8d903f4e
AS
10282011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1029
1030 * image.c (gif_load): Fix calculation of bottom and right corner.
1031 (Bug#9468)
1032
80ad64f4
EZ
10332011-09-10 Eli Zaretskii <eliz@gnu.org>
1034
1035 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1036 redisplay in small windows.
1037
208a048d
EZ
10382011-09-09 Eli Zaretskii <eliz@gnu.org>
1039
1040 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1041
9b1c252e
MR
10422011-09-08 Martin Rudalics <rudalics@gmx.at>
1043
1044 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1045 Operate on live windows only.
1046
2949f33b
JB
10472011-09-08 Juanma Barranquero <lekktu@gmail.com>
1048
1049 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1050
e08dcafd
EZ
10512011-09-07 Eli Zaretskii <eliz@gnu.org>
1052
1053 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1054 only under bidi iteration.
1055
115b96bd
JD
10562011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1057
1058 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1059
c8199d0f
PE
10602011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1061
1062 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1063 Without this fix, the command to link temacs failed due to an
1064 undefined symbol __builtin_isnan. This is because
1065 /usr/include/iso/math_c99.h #defines isnan(x) to
1066 __builtin_isnan(x), but the bundled gcc, which identifies itself
1067 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1068 a __builtin_isnan.
1069 * floatfns.c (isnan): #undef, and then #define to a clone of
1070 what's in data.c.
1071 (Fisnan): Always define, since it's always available now.
1072 (syms_of_floatfns): Always define isnan at the Lisp level.
1073
e39b275c 10742011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1075
1076 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1077
b2db44d9 10782011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1079
f4af5137 1080 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1081 The previous code assumed that file offsets (off_t values) fit in
1082 EMACS_INT variables, which is not true on typical 32-bit hosts.
1083 The code messed up by falsely reporting buffer overflow in cases
1084 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1085 when "big" contains more than 2**29 bytes, even though this
1086 inserts just one byte and does not overflow the buffer.
1087 (Finsert_file_contents): Store file offsets as off_t
1088 values, not as EMACS_INT values. Check for overflow when
1089 converting between EMACS_INT and off_t. When checking for
1090 buffer overflow or for overlap, take the offsets into account.
1091 Don't use EMACS_INT for small values where int suffices.
1092 When checking for overlap, fix a typo: ZV was used where
1093 ZV_BYTE was intended.
1094 (Fwrite_region): Don't assume off_t fits into 'long'.
1095 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1096
ecfc0a49
MA
10972011-09-05 Michael Albinus <michael.albinus@gmx.de>
1098
1099 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1100
6511acf2 11012011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1102
0999621a 1103 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1104
1105 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1106 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1107 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1108 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1109 (modify_event_symbol): Do not assume that the length of
1110 name_alist_or_stem is safe to alloca and fits in int.
1111 (Fexecute_extended_command): Likewise for function name and binding.
1112 (Frecursion_depth): Wrap around reliably on integer overflow.
1113 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1114 since some callers pass EMACS_INT values.
1115 (Fsingle_key_description): Don't crash if symbol name contains more
1116 than MAX_ALLOCA bytes.
1117 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1118 (get_minibuffer): Arg is now EMACS_INT, not int.
1119 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1120 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1121 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1122
2be7d702
PE
1123 * dbusbind.c (signature_cat): New function.
1124 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1125 Do not overrun buffer; instead, report string overflow.
1126
9d1df220
PE
1127 * dispnew.c (add_window_display_history): Don't overrun buffer.
1128 Truncate instead; this is OK since it's just a log.
1129
33ef5c64
PE
1130 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1131 even if the time zone offset is outlandishly large.
1132 Don't mishandle offset == INT_MIN.
1133
66c6fdd5
PE
1134 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1135 when creating daemon; the previous buffer-overflow check was incorrect.
1136
d749b01b
PE
1137 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1138 which has the guts of the old verror function.
1139
b5cd1905
PE
1140 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1141 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1142
6e1a67fb
PE
1143 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1144 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1145 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1146 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1147 length of string rather than counting it via multiple sprintfs;
1148 that's simpler and more reliable.
c21721cc
PE
1149 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1150 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1151 sprintf, in case result does not fit in int.
1152
c57b67fc
PE
1153 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1154 (fontset_from_font): Print it.
1155
8a401434
PE
1156 * frame.c (tty_frame_count): Now printmax_t, not int.
1157 (make_terminal_frame, set_term_frame_name): Print it.
1158 (x_report_frame_params): In X, window IDs are unsigned long,
1159 not signed long, so print them as unsigned.
1160 (validate_x_resource_name): Check for implausibly long names,
1161 and don't assume name length fits in 'int'.
1162 (x_get_resource_string): Don't blindly alloca invocation name;
1163 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1164 not fit in int.
1165
6e1a67fb
PE
1166 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1167 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1168 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1169
0df02bf3
PE
1170 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1171 Use esprintf, not sprintf, in case result does not fit in int.
1172
48e30793
PE
1173 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1174 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1175 it as a large positive number.
1176 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1177 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1178
a66ff6d8
PE
1179 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1180 in case result does not fit in int.
1181
aca216ff
PE
1182 * print.c (float_to_string): Detect width overflow more reliably.
1183 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1184 buffer overrun. Don't assume list length fits in 'int'. Treat
1185 print length of 0 as 0, not as infinity; to be consistent with other
1186 uses of print length in this function. Don't overflow print length
1187 index. Don't assume hash table size fits in 'long', or that
1188 vectorlike size fits in 'unsigned long'.
1189
31c286f7
PE
1190 * process.c (make_process): Use printmax_t, not int, to format
1191 process-name gensyms.
1192
55e5faa1
PE
1193 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1194
80f2e268
PE
1195 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1196 to avoid potential buffer overrun.
1197
670741ab
PE
1198 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1199 if X resource line is longer than 512 bytes.
1200
b7163a50
PE
1201 * xfns.c (x_window): Make sprintf buffer a bit bigger
1202 to avoid potential buffer overrun.
1203
ae58ff1f
PE
1204 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1205
c43c8a6a
PE
1206 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1207
3f8236f4
PE
12082011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1209
53e9fe90 1210 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1211 Without these, Emacs silently mishandles large integers sometimes.
1212 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1213 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1214
6511acf2
PE
1215 * xdisp.c (try_window_id): Check Emacs fixnum range before
1216 converting to 'int'.
806add1d 1217
6511acf2 1218 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1219 Check that an Emacs fixnum is in range before assigning it to 'int'.
1220 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1221 values converted from Emacs fixnums.
1222 (Frecenter): Don't wrap around a line count if it is out of 'int'
1223 range; instead, treat it as an extreme value.
1224 (Fset_window_configuration, compare_window_configurations):
1225 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1226
6511acf2
PE
1227 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1228 that can exceed INT_MAX. Check that EMACS_INT value is in range
1229 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1230 (match_limit): Don't assume that a fixnum can fit in 'int'.
1231
6511acf2 1232 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1233 exceed INT_MAX.
1234
6511acf2 1235 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1236 (Fvertical_motion): Don't wrap around LINES values that don't fit
1237 in 'int'. Instead, treat them as extreme values. This is good
1238 enough for windows, which can't have more than INT_MAX lines anyway.
1239
fcb901a7
LMI
12402011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1241
0f2f6b6d
LMI
1242 * Require libxml/parser.h to avoid compilation warning.
1243
fcb901a7
LMI
1244 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1245
1246 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1247 since this reportedly can destroy thread storage.
1248
6e20a0d4
CY
12492011-08-30 Chong Yidong <cyd@stupidchicken.com>
1250
1251 * syntax.c (find_defun_start): Update all cache variables if
1252 exiting early (Bug#9401).
1253
148ae00e
EZ
12542011-08-30 Eli Zaretskii <eliz@gnu.org>
1255
f6cfbd8f
EZ
1256 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1257
148ae00e
EZ
1258 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1259 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1260 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1261
1262 * term.c (tty_append_glyph): New function.
1263 (produce_stretch_glyph): Static function and its prototype deleted.
1264
a66cfb1c
SM
1265 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1266 Add prototypes.
148ae00e 1267
c4a07a4c
PE
12682011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1269
1270 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1271 when checking :margin (Bug#9390).
1272 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1273 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1274 so that the name doesn't mislead. All uses changed.
1275
6bc8cd65
JB
12762011-08-28 Johan Bockgård <bojohan@gnu.org>
1277
1278 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1279 set_tty_hooks.
1280
dca4927e
EZ
12812011-08-27 Eli Zaretskii <eliz@gnu.org>
1282
1283 * xdisp.c (move_it_to): Don't bail out early when reaching
1284 position beyond to_charpos, if we are scanning backwards.
1285 (move_it_vertically_backward): When DY == 0, make sure we get to
1286 the first character in the line after the newline.
1287
f2cad773
PE
12882011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1289
1290 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1291 (ccl_driver): Do not generate an out-of-range pointer.
1292 (Fccl_execute_on_string): Remove unnecessary check for
1293 integer overflow, noted by Stefan Monnier in
1294 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1295 Remove a FIXME that didn't need fixing.
1296 Simplify the newly-introduced buffer reallocation code.
1297
0cae2cdb
JB
12982011-08-27 Juanma Barranquero <lekktu@gmail.com>
1299
1300 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1301
5fc295a4 13022011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1303
70c60eb2 1304 Integer and memory overflow issues (Bug#9196).
726e0ab1 1305
d31850da
PE
1306 * doc.c (get_doc_string): Rework so that
1307 get_doc_string_buffer_size is the actual buffer size, rather than
1308 being 1 less than the actual buffer size; this makes xpalloc more
1309 convenient.
1310
a69fbedb
PE
1311 * image.c (x_allocate_bitmap_record, cache_image):
1312 * xselect.c (Fx_register_dnd_atom):
1313 Simplify previous changes by using xpalloc.
1314
fe5c5d37
PE
1315 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1316 since either will do and ptrdiff_t is convenient with xpalloc.
1317
0065d054
PE
1318 * charset.c (charset_table_size)
1319 (struct charset_sort_data.priority): Now ptrdiff_t.
1320 (charset_compare): Don't overflow if priorities differ greatly.
1321 (Fsort_charsets): Don't assume list length fits in int.
1322 Check for size-calculation overflow when allocating sort data.
1323 (syms_of_charset): Allocate an initial charset table that is
1324 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1325
1326 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1327
1328 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1329 The actual value is always <= INT_MAX, and leaving it unsigned made
1330 overflow checking harder.
1331
1332 * dispextern.h (struct glyph_matrix.rows_allocated)
1333 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1334 with xpalloc. The values are still always <= INT_MAX.
1335
1336 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1337
1338 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1339 (SAFE_NALLOCA): New macro.
1340
1341 * region-cache.c (struct boundary.pos, find_cache_boundary)
1342 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1343 (set_cache_region, invalidate_region_cache)
1344 (revalidate_region_cache, know_region_cache, region_cache_forward)
1345 (region_cache_backward, pp_cache):
1346 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1347 so that ptrdiff_t * can be passed to xpalloc.
1348 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1349 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1350 (pp_cache): Don't assume cache_len fits in int.
1351 * region-cache.h: Adjust extern decls to match.
1352
1353 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1354 EMACS_INT, since either will do, for xpalloc.
1355
1356 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1357 (xnmalloc, xnrealloc, xpalloc): New functions.
1358
726e0ab1
PE
1359 * bidi.c (bidi_shelve_header_size): New constant.
1360 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1361 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1362
51f30bc5 1363 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1364 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1365 (overlay_strings):
1366 Don't update size of array until after memory allocation succeeds,
1367 because xmalloc/xrealloc may not return.
0065d054
PE
1368 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1369 now that we have proper integer overflow checking.
1370 (record_overlay_string, overlay_strings): Catch overflows when
1371 calculating size of overlay_str_buf.
726e0ab1 1372
0065d054
PE
1373 * callproc.c (Fcall_process): Check for size overflow when
1374 calculating size of args2.
1375 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1376 Normally we prefer signed values, but sticking with ptrdiff_t would
1377 require adding more-complicated checks.
726e0ab1
PE
1378
1379 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1380 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1381 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1382 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1383
1384 * character.c (Fstring): Check for size-calculation overflow.
1385
1386 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1387 unnecessary integer overflow. Check for size overflow.
1388 (encode_coding_object): Don't update size until xmalloc succeeds.
1389
1390 * composite.c (get_composition_id): Check for overflow in glyph
1391 length calculations.
1392
1393 Integer and memory overflow fixes for display code.
1394 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1395 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1396 (scrolling_window): Check for overflow in size calculations.
1397 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1398 Don't assume glyph table len fits in int.
1399 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1400 (row_table_size): Now ptrdiff_t, not int.
1401 (scrolling_window): Avoid overflow in size calculations.
1402 Don't update size until allocation succeeds.
1403 * fns.c (concat): Check for overflow in size calculations.
1404 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1405 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1406 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1407
1408 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1409 (get_doc_string): Check for size calculation overflow.
1410 Don't update size until allocation succeeds.
1411 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1412 EMACS_INT, where ptrdiff_t will do.
1413 (Fsubstitute_command_keys): Check for string overflow.
1414
1415 * editfns.c (set_time_zone_rule): Don't assume environment length
1416 fits in int.
1417 (message_length): Now ptrdiff_t, not int.
1418 (Fmessage_box): Don't update size until allocation succeeds.
1419 Don't assume message length fits in int.
1420 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1421
0065d054
PE
1422 * emacs.c (main): Do not reallocate argv, since there is a null at
1423 the end that can be overwritten, and this way there's no need to
1424 worry about size-calculation overflow.
1425 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1426
1427 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1428 alloc succeeds.
1429 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1430
1431 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1432 (x_set_scroll_bar_width, x_figure_window_size):
1433 Check for integer overflow.
1434 (x_set_alpha): Do not assume XINT fits in int.
1435
1436 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1437 This is for the members text_lines, text_cols, total_lines, total_cols,
1438 where the system imposes an 'int' limit.
1439
1440 * fringe.c (Fdefine_fringe_bitmap):
1441 Don't update size until alloc works.
1442
1443 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1444 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1445
1446 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1447 Check for size-calculation overflow.
1448 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1449 do, as we prefer signed integers.
1450 (id_to_widget.max_size, id_to_widget.used)
1451 (xg_store_widget_in_map, xg_remove_widget_from_map)
1452 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1453 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1454 Use and return ptrdiff_t, not int.
1455 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1456 * gtkutil.h: Change prototypes to match the above.
1457
1458 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1459 are duplicate now that they've been promoted to lisp.h.
1460 (x_allocate_bitmap_record, x_alloc_image_color)
1461 (make_image_cache, cache_image, xpm_load):
1462 Don't update size until alloc is done.
1463 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1464 (x_detect_edges):
3256efce 1465 Check for size calculation overflow.
726e0ab1
PE
1466 (ct_colors_allocated_max): New constant.
1467 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1468 overflow.
3256efce 1469
726e0ab1
PE
1470 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1471 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1472 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1473 Use ptrdiff_t, not int, to count maps.
1474 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1475 calculations. Don't update size until allocation succeeds.
1476 Redo calculations to avoid overflow.
726e0ab1
PE
1477 * keyboard.h: Change prototypes to match the above.
1478
1479 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1480 to count maps.
1481 (current_minor_maps): Check for size calculation overflow.
1482 * keymap.h: Change prototypes to match the above.
1483
1484 * lread.c (read1, init_obarray): Don't update size until alloc done.
1485
1486 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1487 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1488
726e0ab1
PE
1489 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1490 Now ptrdiff_t, not int.
1491 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1492 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1493
1494 * process.c (Fnetwork_interface_list): Check for overflow
1495 in size calculation.
1496
1497 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1498
1499 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1500 overflow. Don't bother calling xmalloc when xrealloc will do.
1501
1502 * search.c (Freplace_match): Check for size calculation overflow.
1503 (Fset_match_data): Don't assume list lengths fit in 'int'.
1504
1505 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1506 for command line length. Do not attempt to address one before the
1507 beginning of an array, as that's not portable.
1508
1509 * term.c (max_frame_lines): Remove; unused.
1510 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1511 not int.
1512 (encode_terminal_code, calculate_costs): Check for size
1513 calculation overflow.
1514 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1515 table lengths and related sizes. Don't update size until alloc
1516 done. Redo calculations to avoid overflow.
1517 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1518
1519 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1520 subtracting pointers.
1521 (gobble_line): Check for overflow more carefully. Don't update size
1522 until alloc done.
1523
1524 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1525 Don't update size until alloc done.
1526 Redo size calculations to avoid overflow.
1527 Check for size calculation overflow.
0065d054 1528 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1529
1530 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1531 Use ptrdiff_t, not int, for sizes.
1532 (store_mode_line_noprop_char): Don't update size until alloc done.
1533
0065d054
PE
1534 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1535 Use ptrdiff_t, not int, for sizes.
1536 (Finternal_make_lisp_face, cache_face):
1537 Check for size calculation overflow.
1538 (cache_face): Treat size calculation overflows as if they were
1539 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1540
1541 * xfns.c (x_encode_text, x_set_name_internal)
1542 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1543 sizes, since they can exceed INT_MAX in size. Check for size
1544 calculation overflow.
1545
0065d054
PE
1546 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1547 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1548 Don't update size until alloc done.
1549
0065d054 1550 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1551 as sprintf is limited to int lengths.
1d526e2f 1552
252c5ee1
PE
1553 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1554 (X_LONG_MIN): New macros.
864d7ce7
PE
1555 Use them to make the following changes clearer.
1556 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1557 This change doesn't affect the value now, but it may help remind
1558 future maintainers not to raise the value too much later.
1559 (SELECTION_QUANTUM): Remove, replacing with ...
1560 (selection_quantum): ... new function, which avoids overflow.
1561 All uses changed.
1562 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1563 assumption that selection length fits in 'int'.
1564 (x_reply_selection_request, x_handle_selection_request)
1565 (x_get_window_property, receive_incremental_selection)
1566 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1567 (lisp_data_to_selection_data, clean_local_selection_data):
1568 Use ptrdiff_t, not int, to record length of selection.
1569 (x_reply_selection_request, x_get_window_property)
1570 (receive_incremental_selection, x_property_data_to_lisp):
1571 Redo calculations to avoid overflow.
1572 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1573 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1574 something.
1575 (x_get_window_property, receive_incremental_selection)
1576 (lisp_data_to_selection_data, x_property_data_to_lisp):
1577 Check for size-calculation overflow.
1578 (x_get_window_property, receive_incremental_selection)
1579 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1580 Don't store size until memory allocation succeeds.
1581 (x_get_window_property): Plug memory leak on memory exhaustion.
1582 Don't double-block input; malloc is safe here. Don't assume 2**34
1583 - 4 fits in unsigned long. Add an xassert to check
1584 XGetWindowProperty overflow. Be more careful about overflow
1585 calculations, and distinguish size from memory overflow better.
1586 (receive_incremental_selection): When tracing, don't assume
1587 unsigned int is less than INT_MAX.
1588 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1589 harmful) conversions of unsigned short to int.
1590 (lisp_data_to_selection_data): Don't assume that integers
1591 in the range -65535 through -1 fit in an X unsigned short.
1592 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1593 result parameters unless successful. Rely on cons_to_unsigned
1594 to report problems with elements; the old code wasn't right anyway.
1595 (x_check_property_data): Check for int overflow; we cannot use
1596 a wider type due to X limits.
1597 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1598
726e0ab1 1599 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1600
0065d054
PE
1601 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1602 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1603 (x_color_cells): Don't store size until memory allocation succeeds.
1604 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1605 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1606 (x_term_init): Don't assume length fits in int (sprintf is limited
1607 to int size).
bc18e09d 1608
ebfa62c0
PE
1609 Use ptrdiff_t for composition IDs.
1610 * character.c (lisp_string_width):
1611 * composite.c (composition_table_size, n_compositions)
1612 (get_composition_id, composition_gstring_from_id):
1613 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1614 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1615 * window.c (Frecenter):
1616 Use ptrdiff_t, not int, for composition IDs.
1617 * composite.c (get_composition_id): Check for integer overflow.
1618 * composite.h: Adjust prototypes to match the above changes.
1619
d3411f89
PE
1620 Use ptrdiff_t for hash table indexes.
1621 * category.c (hash_get_category_set):
1622 * ccl.c (ccl_driver):
1623 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1624 * coding.c (coding_system_charset_list, detect_coding_system):
1625 * coding.h (struct coding_system.id):
1626 * composite.c (get_composition_id, gstring_lookup_cache):
1627 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1628 * image.c (xpm_get_color_table_h):
1629 * lisp.h (hash_lookup, hash_put):
1630 * minibuf.c (Ftest_completion):
1631 Use ptrdiff_t for hash table indexes, not int (which is too
1632 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1633 32-bit --with-wide-int hosts).
1634
e097a6fa
PE
1635 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1636 Add a FIXME comment about memory leaks.
1637 (syms_of_charset): Don't assume xmalloc returns.
1638
5637687f
PE
1639 Don't assume that stated character widths fit in int.
1640 * character.c (Fchar_width, c_string_width, lisp_string_width):
1641 * character.h (CHAR_WIDTH):
1642 * indent.c (MULTIBYTE_BYTES_WIDTH):
1643 Use sanitize_char_width to avoid undefined and/or bad behavior
1644 with outlandish widths.
a66cfb1c 1645 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1646 now that we have two such functions. All uses changed.
1647 (sanitize_char_width): New inline function.
1648
a2271ba2
PE
1649 Don't assume that tab-width fits in int.
1650 * character.h (sanitize_width): New inline function.
1651 (SANE_TAB_WIDTH): New macro.
1652 (ASCII_CHAR_WIDTH): Use it.
1653 * indent.c (sane_tab_width): Remove. All uses replaced by
1654 SANE_TAB_WIDTH (current_buffer).
1655 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1656
18c52557
PE
1657 * fileio.c: Integer overflow issues with file modes.
1658 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1659
caeeedc1
PE
1660 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1661 Remove unreachable code.
1662 (read_hex, load_charset_map_from_file): Check for integer overflow.
1663
50849c52
PE
1664 * xterm.c: don't go over XClientMessageEvent limit
1665 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1666 (x_send_scroll_bar_event): Likewise. Check that the size does not
1667 exceed limits imposed by XClientMessageEvent, as well as the usual
1668 ptrdiff_t and size_t limits.
1669
b13995db
PE
1670 * keyboard.c: Overflow, signedness and related fixes.
1671 (make_lispy_movement): Use same integer type in forward decl
1672 that is used in the definition.
1673 (read_key_sequence, keyremap_step):
1674 Change bufsize argument back to int, undoing my 2011-03-30 change.
1675 We prefer signed types, and int is wide enough here.
1676 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1677 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1678 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1679 length, not size_t. Use ptrdiff_t for index, not int.
1680 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1681 possibility of integer overflow.
1682
13464394
PE
1683 Overflow, signedness and related fixes for images.
1684
1685 * dispextern.h (struct it.stack[0].u.image.image_id)
1686 (struct_it.image_id, struct image.id, struct image_cache.size)
1687 (struct image_cache.used, struct image_cache.ref_count):
1688 * gtkutil.c (update_frame_tool_bar):
1689 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1690 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1691 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1692 * nsmenu.m (update_frame_tool_bar):
1693 * xdisp.c (calc_pixel_width_or_height):
1694 * xfns.c (image_cache_refcount):
1695 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1696 on typical 64-bit hosts.
1697
1698 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1699 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1700 Omit unnecessary casts to int.
1701 (parse_image_spec): Check that integers fall into 'int' range
1702 when the callers expect that.
1703 (image_ascent): Redo ascent calculation to avoid int overflow.
1704 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1705 (lookup_image): Remove unnecessary tests.
1706 (xbm_image_p): Locals are now of int, not EMACS_INT,
1707 since parse_image_check makes sure they fit into int.
1708 (png_load, gif_load, svg_load_image):
1709 Prefer int to unsigned where either will do.
1710 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1711 old tiff_error_handler and tiff_warning_handler.
1712 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1713 stack buffer overflows. It uses only the features of vsnprintf
1714 that are common to both POSIX and native Microsoft.
1715 (tiff_error_handler, tiff_warning_handler): Use it.
1716 (tiff_load, gif_load, imagemagick_load_image):
1717 Don't assume :index value fits in 'int'.
1718 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1719 (imagemagick_load_image): Check that crop parameters fit into
1720 the integer types that MagickCropImage accepts. Don't assume
1721 Vimagemagick_render_type has a nonnegative value. Don't assume
1722 size_t fits in 'long'.
1723 (gs_load): Use printmax_t to print the widest integers possible.
1724 Check for integer overflow when computing image height and width.
1725
c11821d4
EZ
17262011-08-26 Eli Zaretskii <eliz@gnu.org>
1727
1728 * xdisp.c (redisplay_window): Don't force window start if point
1729 will be invisible in the resulting window. (Bug#9324)
1730
0c95fcf7
EZ
17312011-08-25 Eli Zaretskii <eliz@gnu.org>
1732
1733 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1734 the display spec is of the form `(space ...)'.
1735 (handle_display_spec): Return the value returned by
1736 handle_single_display_spec, not just 1 or zero.
1737 (handle_single_display_spec): If the display spec is of the form
1738 `(space ...)', and specifies display in the text area, return 2
1739 rather than 1.
fee65a97 1740 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1741 accurately, and prefer exact match for point under bidi.
1742 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1743
1744 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1745 into disp_prop; all users changed.
1746
1747 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1748 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1749 for the text covered by the display property.
1750
e4ed06f1
CY
17512011-08-25 Chong Yidong <cyd@stupidchicken.com>
1752
1753 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1754 Change return value to nil.
1755 (Frecord_buffer): Delete unused function.
1756
f67cdd7f
EZ
17572011-08-24 Eli Zaretskii <eliz@gnu.org>
1758
5980d4c6
EZ
1759 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1760 buffers, return left-to-right.
8610fe8b
EZ
1761 (set_cursor_from_row): Consider candidate row a win if its glyph
1762 represents a newline and point is on that newline. Fixes cursor
1763 positioning on the newline at EOL of R2L text within L2R
1764 paragraph, and vice versa.
1765 (try_cursor_movement): Check continued rows, in addition to
1766 continuation rows. Fixes unwarranted scroll when point enters a
1767 continued line of R2L text within an L2R paragraph, or vice versa.
1768 (cursor_row_p): Consider the case of point being equal to
1769 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1770 from the end of a short line to the beginning of a continued line
1771 of R2L text within L2R paragraph.
1772 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1773 composed characters.
5980d4c6 1774
f67cdd7f
EZ
1775 * bidi.c (bidi_check_type): Use xassert.
1776 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1777 members.
1778
bca633fb
EZ
17792011-08-23 Eli Zaretskii <eliz@gnu.org>
1780
1781 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1782 a character.
1783
4a5885a7
CY
17842011-08-23 Chong Yidong <cyd@stupidchicken.com>
1785
1786 * nsfont.m (ns_otf_to_script): Fix typo.
1787
0902a04e
KH
17882011-08-22 Kenichi Handa <handa@m17n.org>
1789
1790 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1791 extra slot even if the purpose is char-code-property-table.
1792
1a2e6670
EZ
17932011-08-23 Eli Zaretskii <eliz@gnu.org>
1794
8ddde651
EZ
1795 * xdisp.c (redisplay_window): When computing centering_position,
1796 account for the height of the header line. (Bug#8874)
1797
425cc014
EZ
1798 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1799 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1800 candidate is selected by the mouse, and that candidate has a
1801 composed character under the mouse.
1802
1a2e6670
EZ
1803 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1804 coordinates reported by pos-visible-in-window-p for a composed
1805 character in column zero.
1806
8b76d6f8
SM
18072011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1808
1809 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1810
dac347dd
EZ
18112011-08-22 Eli Zaretskii <eliz@gnu.org>
1812
1813 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1814 consider it a hit if to_charpos is anywhere in the range of the
1815 composed buffer positions.
1816
e013fb34
CY
18172011-08-22 Chong Yidong <cyd@stupidchicken.com>
1818
1819 * image.c (gif_load): Don't assume that each subimage has the same
1820 dimensions as the base image. Handle disposal method that is
1821 "undefined" by the gif spec (Bug#9335).
1822
bd1ba3e8
CY
18232011-08-20 Chong Yidong <cyd@stupidchicken.com>
1824
1825 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1826 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1827
54a1215b
EZ
18282011-08-19 Eli Zaretskii <eliz@gnu.org>
1829
823564e5
EZ
1830 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1831 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1832 from an Org mode buffer to a Speedbar frame.
1833
54a1215b
EZ
1834 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1835 a composition, take its buffer position from IT->cmp_it.charpos.
1836 Fixes cursor positioning at the beginning of a line that begins
1837 with a composed character.
1838
9778ebcc
EZ
18392011-08-18 Eli Zaretskii <eliz@gnu.org>
1840
0be6ee06
EZ
1841 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1842 character bidirectional type, use STRONG_L instead. Fixes crashes
1843 in a buffer produced by `describe-categories'.
1844
9778ebcc
EZ
1845 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1846 members before the level stack, so they would be saved and
1847 restored when copying iterator state. Fixes incorrect reordering
1848 around TABs covered by display properties.
1849
156bffbe
AS
18502011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1851
6b02f655 1852 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1853
72ad093b
CY
18542011-08-17 Chong Yidong <cyd@stupidchicken.com>
1855
1856 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1857 (internal_condition_case_2, internal_condition_case_n):
1858 Remove unnecessary aborts (Bug#9081).
72ad093b 1859
35774242
EZ
18602011-08-17 Eli Zaretskii <eliz@gnu.org>
1861
1862 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1863 has no `load' handler, try opening the file locally. (Bug#9311)
1864
db76dd85
KB
18652011-08-16 Ken Brown <kbrown@cornell.edu>
1866
1867 * gmalloc.c: Expand comment.
1868
b215eee5
EZ
18692011-08-16 Eli Zaretskii <eliz@gnu.org>
1870
1871 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1872 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1873
a4579d33
KB
18742011-08-16 Ken Brown <kbrown@cornell.edu>
1875
1876 Fix memory allocation problems in Cygwin build (Bug#9273).
1877
1878 * unexcw.c ( __malloc_initialized): Declare external variable.
1879 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1880
8b76d6f8
SM
1881 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1882 New variables.
a4579d33
KB
1883 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1884 dumped emacs.
1885 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1886 in the static heap.
1887 [CYGWIN] (special_realloc): New function.
1888 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1889 requests to realloc storage in the static heap.
1890
3ebec551
PE
18912011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1892
1893 * bidi.c (bidi_initialize): Remove unused local.
1894
9fd8be00
EZ
18952011-08-15 Eli Zaretskii <eliz@gnu.org>
1896
6b02f655
SM
1897 * bidimirror.h:
1898 * biditype.h: Remove file.
1899 * makefile.w32-in ($(BLD)/bidi.$(O)):
1900 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1901
1902 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1903
1904 * chartab.c: Improve commentary for the uniprop_table API.
1905
32413314
EZ
1906 * bidi.c (bidi_paragraph_init): Support zero value of
1907 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1908 (bidi_initialize): Use uniprop_table instead of including
1909 biditype.h and bidimirror.h.
32413314 1910
9fd8be00
EZ
1911 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1912 coordinates of the iterator when restoring from ppos_it.
1913 (Bug#9296)
1914
5cf2b69b
KH
19152011-08-14 Kenichi Handa <handa@m17n.org>
1916
1917 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1918 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1919
daf17d00
EZ
19202011-08-14 Eli Zaretskii <eliz@gnu.org>
1921
1922 * xdisp.c (move_it_in_display_line_to): Don't invoke
1923 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1924 ppos_it. Fixes vertical cursor motion when line beginning is
1925 covered by an image. (Bug#9296)
1926
08e3161a
JD
19272011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1928
1929 * nsterm.h (ns_run_ascript): Declare.
1930 (NSAPP_DATA2_RUNASSCRIPT): Define.
1931
1932 * nsfns.m (as_script, as_result, as_status): New static variables.
1933 (ns_run_ascript): New function.
5e617bc2 1934 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1935 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1936 the event loop. Get status from as_status (Bug#7276).
1937
1938 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1939 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1940 the event loop (Bug#7276).
1941
a3720aa2
AS
19422011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1943
1944 * gnutls.c (QCgnutls_bootprop_priority)
1945 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1946 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1947 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1948 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1949 (QCgnutls_bootprop_verify_hostname_error)
1950 (QCgnutls_bootprop_callbacks_verify): Rename from
1951 Qgnutls_bootprop_..., all uses changed.
1952
1953 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1954 uses changed.
1955
0a0d27fb
PE
19562011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1957
19d5c50c
PE
1958 * xfaces.c (Qframe_set_background_mode): Now static.
1959 * dispextern.h (Qframe_set_background_mode): Remove decl.
1960
0a0d27fb
PE
1961 * process.c (Fnetwork_interface_info): Declare local only if needed.
1962
377538cb
JD
19632011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1964
1965 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1966 (Fnetwork_interface_list): Allocate in increments of bytes instead
1967 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1968 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1969 sockaddr.
1970 (struct ifflag_def): notrailers is smart on OSX.
1971 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1972 Get hardware address with getifaddrs if available.
1973
08fff70c
EZ
19742011-08-12 Eli Zaretskii <eliz@gnu.org>
1975
1976 * xdisp.c (iterate_out_of_display_property): xassert that
1977 IT->position is set to within IT->object's boundaries. Break from
1978 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1979 when IT->position is set up wrongly due to some bug.
1980 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1981 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1982 entry. Force push_it to save on the stack the current
1983 buffer/string position, to be restored by pop_it. Fix flags in
1984 the iterator structure wrt the object coming from a display
1985 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1986 properties. (Bug#9284)
1987
7be1c708 19882011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1989
7be1c708
CY
1990 * fontset.c (fontset_get_font_group): Add proper type checks.
1991 (Bug#9172)
aac0c6e3 1992
7be1c708 19932011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1994
7be1c708
CY
1995 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1996 and LC_VERSION_MIN_MACOSX.
1997 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1998 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1999
97bb72a6
EZ
20002011-08-08 Eli Zaretskii <eliz@gnu.org>
2001
2002 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2003 no-display-properties-and-no-overlays under bidi display.
2004 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2005 properties and overlays.
97bb72a6 2006
d5617611
CY
20072011-08-08 Chong Yidong <cyd@stupidchicken.com>
2008
37e11a63
CY
2009 * editfns.c (Fset_time_zone_rule): Document relationship with the
2010 setenv function.
2011
d5617611
CY
2012 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2013 the font entity extracted from the cache (Bug#8109).
2014
58872834
CY
20152011-08-07 Chong Yidong <cyd@stupidchicken.com>
2016
2017 * composite.c (autocmp_chars): Don't reset point. That is done by
2018 restore_point_unwind (Bug#5984).
2019
75bfc667
JL
20202011-08-07 Juri Linkov <juri@jurta.org>
2021
2022 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2023 to show the arg `TIME' instead of `TIMEVAL'.
2024
d1410150
EZ
20252011-08-06 Eli Zaretskii <eliz@gnu.org>
2026
2027 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2028 display property strides EOL and includes a newline, as in
2029 longlines-mode. (Bug#9254)
75b771e4
EZ
2030 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2031 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2032
2033 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2034 is non-zero, even if the data buffer is NULL. Fixes a crash in
2035 vertical-motion with longlines-mode. (Bug#9254)
2036
35928349
EZ
20372011-08-05 Eli Zaretskii <eliz@gnu.org>
2038
ec7cc85b
EZ
2039 * bidi.c <bidi_cache_total_alloc>: Now static.
2040 (bidi_initialize): Initialize bidi_cache_total_alloc.
2041
8b76d6f8 2042 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2043 cache. (Bug#9221)
2044
2045 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2046 amount allocated this far in `bidi_cache_total_alloc'.
2047 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2048 non-zero, only free the data buffer without restoring the cache
2049 contents. All callers changed.
2050
2051 * dispextern.h (bidi_unshelve_cache): Update prototype.
2052
2053 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2054 (move_it_in_display_line, move_it_to)
2055 (move_it_vertically_backward, move_it_by_lines): Replace the call
2056 to xfree to an equivalent call to bidi_unshelve_cache.
2057 (move_it_in_display_line_to): Fix logic of returning
412b6358 2058 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2059
e2e2423b
EZ
20602011-08-05 Eli Zaretskii <eliz@gnu.org>
2061
2062 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2063 came from a string character with a `cursor' property. (Bug#9229)
2064
ae9e757a
JD
20652011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2066
2067 * Makefile.in (LIB_PTHREAD): New variable.
2068 (LIBES): Add LIB_PTHREAD (Bug#9216).
2069
2070 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2071 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2072
213bd7f2
AS
20732011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2074
6b02f655 2075 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2076
99aaf75f
JD
20772011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2078
2079 * xterm.c (x_find_topmost_parent): New function.
2080 (x_set_frame_alpha): Find topmost parent window with
2081 x_find_topmost_parent and set the property there also (bug#9181).
2082 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2083
c74e9d86
PE
20842011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2085
2086 * callproc.c (Fcall_process): Avoid vfork clobbering
2087 the local vars buffer, coding_systems, current_dir.
2088
640c8776
SM
20892011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2090
2091 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2092
f26d0e4c
PE
20932011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2094
8a10d76c
PE
2095 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2096 so that it is not optimized away.
2097
f26d0e4c
PE
2098 * xdisp.c (compute_display_string_pos): Remove unused local.
2099
55439c61
EZ
21002011-08-02 Eli Zaretskii <eliz@gnu.org>
2101
2102 Fix slow cursor motion and scrolling in large buffers with
2103 selective display, like Org Mode buffers. (Bug#9218)
2104
2105 * dispextern.h (struct bidi_it): New member disp_prop_p.
2106
2107 * xdisp.c: Remove one-slot cache of display string positions.
2108 (compute_display_string_pos): Accept an additional argument
5e617bc2 2109 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2110 for a display string or property. If found, set DISP_PROP_P
2111 non-zero.
2112
2113 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2114 DISP_PROP_P, and pass it to compute_display_string_pos.
2115 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2116 non-zero. All callers of bidi_fetch_char changed.
2117
fb33fa43
SM
21182011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2119
2120 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2121
b099e063
DM
21222010-12-03 Don March <don@ohspite.net>
2123
2124 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2125 last character M-[char] is translated to ESC [char] (bug#7541).
2126
5cc7f7af
KH
21272011-08-02 Kenichi Handa <handa@m17n.org>
2128
d0fffa3f 2129 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2130
2131 * chartab.c (uniprop_table): Make it non-static.
2132
525d5e6e
EZ
21332011-08-01 Eli Zaretskii <eliz@gnu.org>
2134
2135 * xdisp.c (forward_to_next_line_start): Accept additional argument
2136 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2137 on the newline.
2138 (reseat_at_next_visible_line_start): Use the bidi iterator state
2139 returned by forward_to_next_line_start to restore the state of
2140 it->bidi_it after backing up to previous newline. (Bug#9212)
2141
31011111
AS
21422011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2143
2144 * regex.c (re_comp): Protoize.
2145 (re_exec): Fix return type.
2146 (regexec): Fix type of `ret'. (Bug#9203)
2147
476371c4
PE
21482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2149
e5d76069
PE
2150 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2151 This is needed if max-image-size is a floating-point number.
2152
9a79b20c
AS
21532011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2154
2155 * print.c (print_object): Print empty symbol as ##.
2156
2157 * lread.c (read1): Read ## as empty symbol.
2158
d8c2fa78
AA
21592011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2160
2161 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2162 setting frame foreground color (Bug#9175).
2163 (x_set_background_color): Likewise.
2164
ffe57a7a
AA
2165 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2166 contents (Bug#9176).
2167 (EmacsTooltip -init): Remove bezels and add shadows to
2168 tooltip windows.
2169
bf3492a5
AA
2170 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2171 or scroll bar (Bug#8470).
2172
d55e9c53
AA
2173 * nsfont.m (nsfont_open): Remove assignment to voffset and
2174 unnecessary vars hshink, expand, hd, full_height, min_height.
2175 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2176
2177 * nsterm.h (nsfont_info): Remove voffset field.
2178
d8c2fa78 21792011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2180
2181 Implement strike-through and overline on NextStep (Bug#8863).
2182
2183 * nsfont.m (nsfont_open): Use underline position provided by font,
2184 instead of hard-coded value of 2.
2185 (nsfont_draw): Call ns_draw_text_decoration instead.
2186
2187 * nsterm.h: Add declaration for ns_draw_text_decoration.
2188
2189 * nsterm.m (ns_draw_text_decoration): New function for drawing
2190 underline, overline, and strike-through.
2191 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2192 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2193 accommodate underlining, etc.
4843aac3 2194
4cc60b9b
EZ
21952011-07-28 Eli Zaretskii <eliz@gnu.org>
2196
bc7ece87
EZ
2197 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2198 default.
4cc60b9b 2199
476371c4
PE
22002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2201
66606eea
PE
2202 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2203 Without this fix, if a signal arrives just after memory fills up,
2204 'malloc' might be invoked reentrantly.
2205
476371c4
PE
2206 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2207 In other words, assume that every image size is allowed, on non-X
2208 hosts. This assumption is probably wrong, but it lets Emacs compile.
2209
f3fcc40d
AS
22102011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2211
2212 * regex.c (re_iswctype): Convert return values to boolean.
2213
350c992f
EZ
22142011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2215
2216 * xdisp.c (compute_display_string_pos): Don't use cached display
2217 string position if the buffer had its restriction changed.
2218 (Bug#9184)
2219
5266b4bb
PE
22202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2221
2222 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2223
2573a837 22242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2225
41f55ccd 2226 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2227
39e378da
PE
2228 * bidi.c: Integer size and overflow fixes.
2229 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2230 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2231 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2232 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2233 (bidi_find_other_level_edge):
2234 Use ptrdiff_t instead of EMACS_INT where either will do.
2235 This works better on 32-bit hosts configured --with-wide-int.
2236 (bidi_cache_ensure_space): Check for size-calculation overflow.
2237 Use % rather than repeated addition, for better worst-case speed.
2238 Don't set bidi_cache_size until after xrealloc returns, because it
2239 might not return.
2240 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2241 (bidi_cache_ensure_space): Also check that the bidi cache size
2242 does not exceed that of the largest Lisp string or buffer. See Eli
2243 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2244
5e927815
PE
2245 * alloc.c (__malloc_size_t): Remove.
2246 All uses replaced by size_t. See Andreas Schwab's note
2247 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2248
ca4aa935
PE
2249 * image.c: Improve checking for integer overflow.
2250 (check_image_size): Assume that f is nonnull, since
2251 it is always nonnull in practice. This is one less thing to
2252 worry about when checking for integer overflow later.
2253 (x_check_image_size): New function, which checks for integer
2254 overflow issues inside X.
2255 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2256 This removes the need for a memory_full check.
2257 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2258 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2259 (xbm_read_bitmap_data): Change locals back to 'int', since
2260 their values must fit in 'int'.
2261 (xpm_load_image, png_load, tiff_load):
2262 Invoke x_create_x_image_and_pixmap earlier,
2263 to avoid much needless work if the image is too large.
2264 (tiff_load): Treat overly large images as if
2265 x_create_x_image_and_pixmap failed, not as malloc failures.
2266 (gs_load): Use x_check_image_size.
2267
5f8f9cc2
PE
2268 * gtkutil.c: Omit integer casts.
2269 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2270 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2271
5adf60bc
PE
2272 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2273
c8907a93
PE
2274 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2275 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2276 would wrongly return t on a 64-bit host.
2277
e3c25c68
PE
2278 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2279 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2280 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2281 and therefore cause GCC to emit a bogus diagnostic in some cases.
2282
3f791afe
PE
2283 * image.c: Integer signedness and overflow and related fixes.
2284 This is not an exhaustive set of fixes, but it's time to
2285 record what I've got.
2286 (lookup_pixel_color, check_image_size): Remove redundant decls.
2287 (check_image_size): Don't assume that arbitrary EMACS_INT values
2288 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2289 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2290 (tiff_load, imagemagick_load_image):
2291 Check for overflow in size calculations.
2292 (x_create_x_image_and_pixmap): Remove unnecessary test for
2293 xmalloc returning NULL; that can't happen.
2294 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2295 (xpm_color_bucket): Use better integer hashing function.
2296 (xpm_cache_color): Don't possibly over-allocate memory.
2297 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2298 (gif_memory_source):
2299 Use ptrdiff_t, not int or size_t, to record sizes.
2300 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2301 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2302 either works, as we prefer signed integers.
2303 (tiff_read_from_memory, tiff_write_from_memory):
2304 Return tsize_t, not size_t, since that's what the TIFF API wants.
2305 (tiff_read_from_memory): Don't fail simply because the read would
2306 go past EOF; instead, return a short read.
2307 (tiff_load): Omit no-longer-needed casts.
2308 (Fimagemagick_types): Don't assume size fits into 'int'.
2309
3cc5a532
PE
2310 Improve hashing quality when configured --with-wide-int.
2311 * fns.c (hash_string): New function, taken from sxhash_string.
2312 Do not discard information about ASCII character case; this
2313 discarding is no longer needed.
2314 (sxhash-string): Use it. Change sig to match it. Caller changed.
2315 * lisp.h: Declare it.
2316 * lread.c (hash_string): Remove, since we now use fns.c's version.
2317 The fns.c version returns a wider integer if --with-wide-int is
2318 specified, so this should help the quality of the hashing a bit.
2319
b312a492
PE
2320 * emacs.c: Integer overflow minor fix.
2321 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2322 Define only if GNU_LINUX.
2323 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2324
dfd153ae
PE
2325 * dispnew.c: Integer signedness and overflow fixes.
2326 Remove unnecessary forward decls, that were a maintenance hassle.
2327 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2328 All uses changed.
2329 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2330 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2331 (prepare_desired_row, line_draw_cost):
2332 Use int, not unsigned, where either works.
2333 (save_current_matrix, restore_current_matrix):
2334 Use ptrdiff_t, not size_t, where either works.
2335 (init_display): Check for overflow more accurately, and without
2336 relying on undefined behavior.
2337
a81d11a3
PE
2338 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2339 Remove, replacing with the new symbols in lisp.h. All uses changed.
2340 * fileio.c (make_temp_name):
2341 * filelock.c (lock_file_1, lock_file):
2342 * xdisp.c (message_dolog):
2343 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2344 Use pMd etc. instead.
2345 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2346 replacing the pWIDE etc. symbols removed from editfns.c.
2347
3300e6fd
PE
2348 * keyboard.h (num_input_events): Now uintmax_t.
2349 This is (very slightly) less likely to mess up due to wraparound.
2350 All uses changed.
2351
fd05c7e9
PE
2352 * buffer.c: Integer signedness fixes.
2353 (alloc_buffer_text, enlarge_buffer_text):
2354 Use ptrdiff_t rather than size_t when either will do, as we prefer
2355 signed integers.
2356
903fe15d
PE
2357 * alloc.c: Integer signedness and overflow fixes.
2358 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2359 (__malloc_size_t): Default to size_t, not to int.
2360 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2361 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2362 Prefer ptrdiff_t to size_t when either would do, as we prefer
2363 signed integers.
2364 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2365 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2366 Now const. Initialize with values that are in range even if char
2367 is signed.
2368 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2369 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2370 These functions do the right thing with sizes > 2**32.
2371 (check_depth): Now ptrdiff_t, not int.
2372 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2373 Adjust to new way of storing sizes. Check for size overflow bugs
2374 in rest of code.
2375 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2376 slightly wrong anyway, as it missed one instance of
2377 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2378 (refill_memory_reserve): Omit needless cast to size_t.
2379 (mark_object_loop_halt): Mark as externally visible.
2380
ac82cc6a
PE
2381 * xselect.c: Integer signedness and overflow fixes.
2382 (Fx_register_dnd_atom, x_handle_dnd_message):
2383 Use ptrdiff_t, not size_t, since we prefer signed.
2384 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2385 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2386 x_dnd_atoms_size and x_dnd_atoms_length.
2387
c2d1e36d
PE
2388 * doprnt.c: Prefer signed to unsigned when either works.
2389 * eval.c (verror):
2390 * doprnt.c (doprnt):
2391 * lisp.h (doprnt):
2392 * xdisp.c (vmessage):
2393 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2394 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2395 prefer signed arithmetic to avoid comparison confusion.
2396 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2397 but is a bit tricky.
2398
0e926e56
PE
2399 Assume freestanding C89 headers, string.h, stdlib.h.
2400 * data.c, doprnt.c, floatfns.c, print.c:
2401 Include float.h unconditionally.
2402 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2403 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2404 * regex.c: Likewise for stddef.h, string.h.
2405 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2406 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2407 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2408 (STDC_HEADERS): Remove obsolete defines.
2409 * sysdep.c: Include limits.h unconditionally.
2410
9cfdb3ec
PE
2411 Assume support for memcmp, memcpy, memmove, memset.
2412 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2413 * regex.c (memcmp, memcpy):
2414 Remove; we assume C89 now.
2415
2416 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2417 (__malloc_safe_bcopy): Remove; no longer needed.
2418
cf950e6b 2419 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2420 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2421 well either way, and we prefer signed to unsigned.
2422
dbf38e02
LMI
24232011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2424
2425 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2426 closes the connection while we're reading (bug#9182).
2427
d6f0886c 24282011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2429
d6f0886c
JD
2430 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2431 are specified (Bug#9168).
24e0f6b1 2432
2eb1f9e6
PE
24332011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2434
2435 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2436 Found by GCC static checking and --with-wide-int on a 32-bit host.
2437
22381272 24382011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2439
2440 * xdisp.c (compute_display_string_pos): Fix logic of caching
2441 previous display string position. Initialize cached_prev_pos to
2442 -1. Fixes slow-down at the beginning of a buffer.
2443
f25e39b4
EZ
24442011-07-24 Eli Zaretskii <eliz@gnu.org>
2445
2446 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2447 for attrs[LFACE_FONTSET_INDEX].
2448
04c4b52e
PE
24492011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2450
2451 * xml.c (parse_region): Remove unused local
2452 that was recently introduced.
2453
c1734fbd
EZ
24542011-07-23 Eli Zaretskii <eliz@gnu.org>
2455
be18c5a5
EZ
2456 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2457 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2458
c1734fbd
EZ
2459 * xdisp.c (move_it_in_display_line_to): Record the best matching
2460 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2461 exit if none of the characters scanned was an exact match.
2462 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2463 when exact match is impossible due to invisible text, and the
2464 lines are truncated.
2465
a258d627
JD
24662011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2467
2468 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2469 for OSX >= 10.7.
2470
b6d5a689
EZ
24712011-07-22 Eli Zaretskii <eliz@gnu.org>
2472
0f74f785
EZ
2473 Fix a significant slow-down of cursor motion with C-n, C-p,
2474 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2475 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2476 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2477 (next_element_from_buffer): Call compute_stop_pos_backwards to
2478 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2479 base_level_stop.
2480 (reseat): Don't look for prev_stop, as that could mean a very long
2481 run.
2482 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2483 <cached_disp_overlay_modiff>: Cache for last found display string
2484 position.
551918c1 2485 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2486 about the same buffer in the same area of character positions, and
2487 the buffer wasn't changed since the time the display string
2488 position was cached.
551918c1 2489
b2d0c91a
EZ
24902011-07-22 Eli Zaretskii <eliz@gnu.org>
2491
2492 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2493 is an integer, which is important for empty lines. (Bug#9149)
2494
043604ee
CY
24952011-07-22 Chong Yidong <cyd@stupidchicken.com>
2496
2497 * frame.c (Fmodify_frame_parameters): In tty case, update the
2498 default face if necessary (Bug#4238).
2499
da4adb04
CY
25002011-07-21 Chong Yidong <cyd@stupidchicken.com>
2501
2502 * editfns.c (Fstring_to_char): No need to explain what a character
2503 is in the docstring (Bug#6576).
2504
9abd0532
LMI
25052011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2506
2507 * xml.c (parse_region): Make sure we always return a tree.
2508
36881d16
HK
25092011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2510
2511 * xml.c (parse_region): If a document contains only comments,
2512 return that, too.
2513
1e98674d
LMI
25142011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2515
2516 * xml.c (make_dom): Return comments, too.
2517
590bd467
PE
25182011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2519
2520 Port to OpenBSD.
2521 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2522 and the surrounding thread.
2523 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2524 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2525 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2526 timer goes off.
2527 * s/openbsd.h (BROKEN_SIGIO): Define.
2528 * unexelf.c (unexec) [__OpenBSD__]:
2529 Don't update the .mdebug section of the Alpha COFF symbol table.
2530
f41628b2
LMI
25312011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2532
2533 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2534 (bug#8460).
2535
b59b67c5
PE
25362011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2537
15e3a074
PE
2538 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2539 This fixes some race conditions on the permissions of any newly
2540 created file.
2541
41bed37d
PE
2542 * alloc.c (valid_pointer_p): Use pipe, not open.
2543 This fixes some permissions issues when debugging.
2544
b59b67c5
PE
2545 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2546 If fchown fails to set both uid and gid, try to set just gid,
2547 as that is sometimes allowed. Adjust the file's mode to eliminate
2548 setuid or setgid bits that are inappropriate if fchown fails.
2549
925a6be7
SM
25502011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2551
2552 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2553 to compare Lisp_Objects.
2554 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2555 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2556 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2557
52968808
AS
25582011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2559
0a6a104b
AS
2560 * lread.c (read_integer): Unread even EOF character.
2561 (read1): Likewise. Properly record start position of symbol.
2562
52968808
AS
2563 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2564 symbol character follows.
2565
9e381cdd
PE
25662011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2567
2568 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2569 This works around a problem with the previous change to Fcopy_file.
2570 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2571 and without this change, GCC might complain about discarding
2572 fchown's return value.
2573
b5641435
JB
25742011-07-16 Juanma Barranquero <lekktu@gmail.com>
2575
2576 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2577
a8031457
PE
25782011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2579
2580 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2581
dd889327
LMI
25822011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2583
750c33f7
LMI
2584 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2585 it's used from the C level.
2586
dd889327
LMI
2587 * process.c: Use the same condition for POLL_FOR_INPUT in both
2588 keyboard.c and process.c (bug#1858).
2589
87e86684
LM
25902011-07-09 Lawrence Mitchell <wence@gmx.li>
2591
2592 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2593 (Fgnutls_boot): Use it.
2594
64348f40
AS
25952011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2596
2597 * doc.c (Fsubstitute_command_keys): Revert last change.
2598
1d698799
LMI
25992011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2600
f863868c
LMI
2601 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2602 quotes the next character, and doesn't affect other longer
2603 sequences (bug#8935).
2604
1d698799
LMI
2605 * lread.c (syms_of_lread): Clarify that is isn't only
2606 `eval-buffer' and `eval-defun' that's affected by
2607 `lexical-binding' (bug#8460).
2608
aa4b6df6
EZ
26092011-07-15 Eli Zaretskii <eliz@gnu.org>
2610
2611 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2612 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2613
5d856da6
PE
26142011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2615
ad6042bb
PE
2616 Fix minor problems found by static checking.
2617 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2618 (elsz): Now a signed constant, not a size_t var. We prefer signed
2619 types to unsigned, to avoid integer comparison confusion. Without
2620 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2621 "cannot optimize loop, the loop counter may overflow", a symptom
2622 of the confusion.
f00bbb22 2623 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2624 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2625
6468f31c
LMI
26262011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2627
49080b10
LMI
2628 * search.c (Fre_search_backward): Mention `case-fold-search' in
2629 all the re_search_* functions (bug#8138).
2630
6468f31c
LMI
2631 * keyboard.c (Fopen_dribble_file): Document when the file is
2632 closed (bug#8056).
2633
c965adc5
EZ
26342011-07-14 Eli Zaretskii <eliz@gnu.org>
2635
df9733bf
EZ
2636 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2637 bidi_cache_idx.
2638
0bb23927
EZ
2639 Support bidi reordering of display and overlay strings.
2640 * xdisp.c (compute_display_string_pos)
2641 (compute_display_string_end): Accept additional argument STRING.
2642 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2643 (reseat_to_string): Initialize bidi_it->string.s and
2644 bidi_it->string.schars.
2645 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2646 NULL (avoids a crash in bidi_paragraph_init).
2647 Initialize itb.string.lstring.
0bb23927
EZ
2648 (init_iterator): Call bidi_init_it only of a valid
2649 buffer position was specified. Initialize paragraph_embedding to
2650 L2R.
2651 (reseat_to_string): Initialize the bidi iterator.
2652 (display_string): If we need to ignore text properties of
2653 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2654 original value of -1 will not work with bidi.)
2655 (compute_display_string_pos): First arg is now struct
2656 `text_pos *'; all callers changed. Support display properties on
2657 Lisp strings.
2658 (compute_display_string_end): Support display properties on Lisp
2659 strings.
2660 (init_iterator, reseat_1, reseat_to_string): Initialize the
2661 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2662 when iterating on a string not from display properties).
640c8776
SM
2663 (compute_display_string_pos, compute_display_string_end):
2664 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2665 arrow keys.
2666 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2667 base_level_stop; instead, set base_level_stop to BEGV.
2668 Fixes crashes in vertical-motion.
0bb23927
EZ
2669 (next_element_from_buffer): Improve commentary for when
2670 the iterator is before prev_stop.
2671 (init_iterator): Initialize bidi_p from the default value of
2672 bidi-display-reordering, not from buffer-local value. Use the
2673 buffer-local value only if initializing for buffer iteration.
2674 (handle_invisible_prop): Support invisible properties on strings
2675 that are being bidi-reordered.
2676 (set_iterator_to_next): Support bidi reordering of C strings and
2677 Lisp strings.
2678 (next_element_from_string): Support bidi reordering of Lisp
2679 strings.
2680 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2681 (display_string): Support display of R2L glyph rows.
2682 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2683 (init_iterator): Don't initialize it->bidi_p for strings
2684 here.
2685 (reseat_to_string): Initialize it->bidi_p for strings here.
2686 (next_element_from_string, next_element_from_c_string)
2687 (next_element_from_buffer): Add xassert's for correspondence
2688 between IT's object being iterated and it->bidi_it.string
2689 structure.
2690 (face_before_or_after_it_pos): Support bidi iteration.
2691 (next_element_from_c_string): Handle the case of the first string
2692 character that is not the first one in the visual order.
2693 (get_visually_first_element): New function, refactored from common
2694 parts of next_element_from_buffer, next_element_from_string, and
2695 next_element_from_c_string.
2696 (tool_bar_lines_needed, redisplay_tool_bar)
2697 (display_menu_bar): Force left-to-right direction. Add a FIXME
2698 comment for making that be controlled by a user option.
2699 (push_it, pop_it): Save and restore the state of the
2700 bidi iterator. Save and restore the bidi_p flag.
2701 (pop_it): Iterate out of display property for string iteration as
2702 well.
2703 (iterate_out_of_display_property): Support iteration over strings.
2704 (handle_single_display_spec): Set up it->bidi_it for iteration
2705 over a display string, and call bidi_init_it.
2706 (handle_single_display_spec, next_overlay_string)
2707 (get_overlay_strings_1, push_display_prop): Set up the bidi
2708 iterator for displaying display or overlay strings.
2709 (forward_to_next_line_start): Don't use the shortcut if
2710 bidi-iterating.
2711 (back_to_previous_visible_line_start): If handle_display_prop
2712 pushed the iterator stack, restore the internal state of the bidi
2713 iterator by calling bidi_pop_it same number of times.
2714 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2715 and we are bidi-iterating, don't decrement the iterator position;
2716 instead, set the first_elt flag in the bidi iterator, to produce
2717 the same effect.
2718 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2719 (push_display_prop): xassert that we are iterating a buffer.
2720 (push_it, pop_it): Save and restore paragraph_embedding member.
2721 (handle_single_display_spec, next_overlay_string)
2722 (get_overlay_strings_1, reseat_1, reseat_to_string)
2723 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2724 correctly. Don't assume unibyte strings are not bidi-reordered.
2725 (compute_display_string_pos)
2726 (compute_display_string_end): Fix handling the case of C string.
2727 (push_it, pop_it): Save and restore from_disp_prop_p.
2728 (handle_single_display_spec, push_display_prop): Set the
2729 from_disp_prop_p flag.
2730 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2731 (pop_it): Call iterate_out_of_display_property only if we are
2732 popping after iteration over a string that came from a display
2733 property. Fix a typo in popping stretch info. Add an assertion
2734 for verifying that the iterator position is in sync with the bidi
2735 iterator.
2736 (handle_single_display_spec, get_overlay_strings_1)
2737 (push_display_prop): Fix initialization of paragraph direction for
2738 string when that of the parent object is not yet determined.
2739 (reseat_1): Call bidi_init_it to resync the bidi
2740 iterator with IT's position. (Bug#7616)
2741 (find_row_edges): If ROW->start.pos gives position
2742 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2743 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2744 Reset the from_disp_prop_p flag.
2745 (SAVE_IT, RESTORE_IT): New macros.
2746 (pos_visible_p, face_before_or_after_it_pos)
2747 (back_to_previous_visible_line_start)
2748 (move_it_in_display_line_to, move_it_in_display_line)
2749 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2750 (try_scrolling, redisplay_window, display_line): Use them when
2751 saving a temporary copy of the iterator and restoring it back.
2752 (back_to_previous_visible_line_start, reseat_1)
2753 (init_iterator): Empty the bidi cache "stack".
2754 (move_it_in_display_line_to): If iterator ended up at
2755 EOL, but we never saw any buffer positions smaller than
2756 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2757 motion in bidi-reordered lines.
2758 (move_it_in_display_line_to): Record prev_method and prev_pos
2759 immediately before the call to set_iterator_to_next. Fixes cursor
2760 motion in bidi-reordered lines with stretch glyphs and strings
2761 displayed in margins. (Bug#8133) (Bug#8867)
2762 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2763 TO_CHARPOS.
640c8776
SM
2764 (pos_visible_p): Support positions in bidi-reordered lines.
2765 Save and restore bidi cache.
0bb23927
EZ
2766
2767 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2768 (bidi_paragraph_info): Delete unused struct.
2769 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2770 (bidi_cache_start): New variable.
2771 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2772 to zero.
2773 (bidi_cache_fetch_state, bidi_cache_search)
2774 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2775 (bidi_cache_find, bidi_peek_at_next_level)
2776 (bidi_level_of_next_char, bidi_find_other_level_edge)
2777 (bidi_move_to_visually_next): Compare cache index with
2778 bidi_cache_start rather than with zero.
2779 (bidi_fetch_char): Accept new argument STRING; all callers
2780 changed. Support iteration over a string. Support strings with
2781 display properties. Support unibyte strings. Fix the type of
2782 `len' according to what STRING_CHAR_AND_LENGTH expects.
2783 (bidi_paragraph_init, bidi_resolve_explicit_1)
2784 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2785 (bidi_level_of_next_char, bidi_move_to_visually_next):
2786 Support iteration over a string.
0bb23927
EZ
2787 (bidi_set_sor_type, bidi_resolve_explicit_1)
2788 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2789 can now be zero (for strings); special values 0 and -1 were
2790 changed to -1 and -2, respectively.
2791 (bidi_char_at_pos): New function.
2792 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2793 Call it instead of FETCH_MULTIBYTE_CHAR.
2794 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2795 initialized to valid values.
2796 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2797 values.
2798 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2799 the test for valid cached positions. Fix the logic for looking up
2800 the sentinel state in the cache. GCPRO the Lisp string we are
2801 iterating.
2802 (bidi_push_it, bidi_pop_it): New functions.
2803 (bidi_initialize): Initialize the bidi cache start stack pointer.
2804 (bidi_cache_ensure_space): New function, refactored from part of
2805 bidi_cache_iterator_state. Don't assume the required size is just
2806 one BIDI_CACHE_CHUNK away.
2807 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2808 (bidi_count_bytes, bidi_char_at_pos): New functions.
2809 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2810 always valid if bidi_cache_idx is valid.
2811 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2812 is valid if it's going to be used.
2813 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2814 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2815 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2816 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2817 (bidi_find_other_level_edge, bidi_cache_start_stack):
2818 All variables related to cache indices are now EMACS_INT.
c965adc5 2819
0bb23927
EZ
2820 * dispextern.h (struct bidi_string_data): New structure.
2821 (struct bidi_it): New member `string'. Make flag members be 1-bit
2822 fields, and put them last in the struct.
640c8776
SM
2823 (compute_display_string_pos, compute_display_string_end):
2824 Update prototypes.
0bb23927
EZ
2825 (bidi_push_it, bidi_pop_it): Add prototypes.
2826 (struct iterator_stack_entry): New members bidi_p,
2827 paragraph_embedding, and from_disp_prop_p.
2828 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2829 (bidi_shelve_cache, bidi_unshelve_cache):
2830 Declare prototypes.
0bb23927
EZ
2831
2832 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2833 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2834 and vector-like objects.
2835
2836 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2837 cache around display iteration.
2838
2839 * window.c (Fwindow_end, window_scroll_pixel_based)
2840 (displayed_window_lines, Frecenter): Save and restore the bidi
2841 cache around display iteration.
2842
3bbd2265
LMI
28432011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2844
2845 * editfns.c (Fdelete_region): Clarify the use of the named
2846 parameters (bug#6788).
2847
adc47434
MR
28482011-07-14 Martin Rudalics <rudalics@gmx.at>
2849
2850 * indent.c (Fvertical_motion): Set and restore w->pointm when
2851 saving and restoring the window's buffer (Bug#9006).
2852
837c31f8
LMI
28532011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2854
2855 * editfns.c (Fstring_to_char): Clarify just what is returned
2856 (bug#6576). Text by Eli Zaretskii.
2857
ac389d0c
JB
28582011-07-13 Juanma Barranquero <lekktu@gmail.com>
2859
2860 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2861
0be0ce47
EZ
28622011-07-13 Eli Zaretskii <eliz@gnu.org>
2863
2864 * buffer.c (mmap_find): Fix a typo.
2865
cd18e7e3
JB
28662011-07-13 Johan Bockgård <bojohan@gnu.org>
2867
2868 Fix execution of x selection hooks.
2869 * xselect.c (Qx_lost_selection_functions)
2870 (Qx_sent_selection_functions): New vars.
2871 (syms_of_xselect): DEFSYM them.
2872 (x_handle_selection_request): Pass Qx_sent_selection_functions
2873 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2874 (x_handle_selection_clear,x_clear_frame_selections):
2875 Pass Qx_lost_selection_functions rather than
2876 Vx_lost_selection_functions to Frun_hook_with_args.
2877
47ea7f44
PE
28782011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2879
ac389d0c 2880 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2881 The old code sometimes used this field without initializing it.
2882
47ea7f44
PE
2883 * alloc.c (gc_sweep): Don't read past end of array.
2884 In theory, the old code could also have corrupted Emacs internals,
2885 though it'd be very unlikely.
2886
bc985c87
AS
28872011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2888
2889 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2890 argument. (Bug#4026)
bc985c87 2891
0cf34688
LMI
28922011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2893
b3dadd76
LMI
2894 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2895 key" (bug#4257).
2896
0cf34688
LMI
2897 * window.c (Fset_window_start): Doc fix (bug#4199).
2898 (Fset_window_hscroll): Ditto.
2899
270768cd
PE
29002011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2901
077e3dda 2902 Fix minor new problems caught by GCC 4.6.1.
270768cd 2903 * term.c (init_tty): Remove unused local.
490011a6 2904 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2905 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2906 not used otherwise.
270768cd 2907
b1f58454
CY
29082011-07-12 Chong Yidong <cyd@stupidchicken.com>
2909
2910 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2911
22b9578d
LMI
29122011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2913
6e70ab07
LMI
2914 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2915 are the mini-buffer and the echo area (bug#3320).
2916
22b9578d
LMI
2917 * term.c (init_tty): Remove support for supdup, c10 and perq
2918 terminals, which are no longer supported (bug#1482).
2919
8974cc9f
JB
29202011-07-10 Johan Bockgård <bojohan@gnu.org>
2921
2922 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2923
a560d974
JD
29242011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2925
2926 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2927 for non-popups (Bug#3642).
2928
1dae0f0a
AS
29292011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2930
268c2c36 2931 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2932 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2933 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2934 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2935 * data.c (fmod): Likewise.
2936 * dispnew.c (swap_glyphs_in_rows): Likewise.
2937 * emacs.c (memory_warning_signal): Likewise.
2938 * floatfns.c (float_error): Likewise.
2939 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2940 (otf_open, font_otf_capability, generate_otf_features)
2941 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2942 Likewise.
2943 * image.c (pbm_read_file): Likewise.
2944 * indent.c (string_display_width): Likewise.
2945 * intervals.c (check_for_interval, search_for_interval)
2946 (inc_interval_count, count_intervals, root_interval)
2947 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2948 * lread.c (defalias): Likewise.
268c2c36 2949 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2950 * regex.c (set_image_of_range_1, set_image_of_range)
2951 (regex_grow_registers): Likewise.
2952 * sysdep.c (strerror): Likewise.
2953 * termcap.c (valid_filename_p, tprint, main): Likewise.
2954 * tparam.c (main): Likewise.
2955 * unexhp9k800.c (run_time_remap, save_data_space)
2956 (update_file_ptrs, read_header, write_header, calculate_checksum)
2957 (copy_file, copy_rest, display_header): Likewise.
2958 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2959 Likewise.
2960 * xdisp.c (check_it): Likewise.
2961 * xfaces.c (register_color, unregister_color, unregister_colors):
2962 Likewise.
2963 * xfns.c (print_fontset_result): Likewise.
2964 * xrdb.c (member, fatal, main): Likewise.
2965
99033785
PE
29662011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2967
2968 Fix minor problems found by static checking (Bug#9031).
2969 * chartab.c (char_table_set_range, map_sub_char_table):
2970 Remove unused locals.
2971 (uniprop_table): Now static.
2972 * composite.c (_work_char): Remove unused static var.
2973
9cb2ac56
JB
29742011-07-09 Juanma Barranquero <lekktu@gmail.com>
2975
2976 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2977
f25661f0
JD
29782011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2979
2980 * gtkutil.c (qttip_cb): Remove code without function.
2981
8278c4fe
EZ
29822011-07-09 Eli Zaretskii <eliz@gnu.org>
2983
2984 * w32.c (pthread_sigmask): New stub.
2985
1692ae2d 29862011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2987
8a6ebd58 2988 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2989 sigprocmask is portable only for single-threaded applications, and
2990 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2991 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2992 (LIBES): Use it.
2993 * callproc.c (Fcall_process):
2994 * process.c (create_process):
2995 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2996 Use pthread_sigmask, not sigprocmask.
123403e4 2997
1b854618
JD
29982011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2999
3000 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3001 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3002 wrong (Bug#8591).
3003
3fe4b549
JD
30042011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3005
0ce7e563
JD
3006 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3007 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3008 (xg_hide_tooltip): Fix comment.
3009
3fe4b549
JD
3010 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3011 in registerServicesMenuSendTypes.
3012 (validRequestorForSendType): Don't check ns_return_types.
3013
3014 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3015 ns_return_type.
3016
5df75e47
JR
30172011-07-08 Jason Rumney <jasonr@gnu.org>
3018
22610910
JR
3019 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3020 SH_SHOW for hidden windows (Bug#5482).
3021
5df75e47
JR
3022 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3023 frame struct members of non-existent frames (Bug#6284).
3024
699c10bd
JD
30252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3026
4393663b
JD
3027 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3028 variable firstTime not needed on OSX >= 10.6.
3029 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3030 >= 10.5. Use setKnobProportion, setDoubleValue.
3031
3032 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3033 (MAC_OS_X_VERSION_10_5): Define if not defined.
3034 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3035 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3036 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3037
3038 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3039 cString and lossyCString on OSX >= 10.4
3040
3041 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3042 sizeToFit on OSX >= 10.2.
3043
3044 * nsimage.m (allocInitFromFile): Don't use deprecated method
3045 bestRepresentationForDevice on OSX >= 10.6.
3046
3047 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3048 to avoid warning.
3049
3050 * emacs.c: Declare unexec_init_emacs_zone.
3051
a63e0781
JD
3052 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3053
699c10bd
JD
3054 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3055
3056 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3057 on svcsMenu (Bug#8842).
3058
3059 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3060 ns_return_types.
3061 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3062
3063 * nsterm.m (QUTF8_STRING): Declare.
3064 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3065 (validRequestorForSendType): Return type is (id).
3066 Change indexOfObjectIdenticalTo to indexOfObject.
3067 Check if we have local selection before returning self (Bug#8842).
3068 (writeSelectionToPasteboard): Put local selection into paste board
3069 if we have a local selection (Bug#8842).
3070 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3071
3072 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3073 (ns_get_local_selection): Declare.
3074
54e10184
LMI
30752011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3076
9888ff71
LMI
3077 * keymap.c (describe_map_tree): Don't insert a double newline at
3078 the end of the buffer (bug#1169) and return whether we inserted
3079 something.
3080
54e10184
LMI
3081 * callint.c (Fcall_interactively): Change "reading args" to
3082 "providing args" to try to clarify what it does (bug#1010).
3083
15fa4783
KH
30842011-07-07 Kenichi Handa <handa@m17n.org>
3085
3086 * composite.c (composition_compute_stop_pos): Ignore a static
3087 composition starting before CHARPOS (Bug#8915).
3088
3089 * xdisp.c (handle_composition_prop): Likewise.
3090
a8815b00
EZ
30912011-07-07 Eli Zaretskii <eliz@gnu.org>
3092
3093 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3094 (Bug#9015)
3095
ef7b981d 30962011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3097
3098 * character.h (unicode_category_t): New enum type.
3099
3100 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3101 (Qchar_code_property_table): New variable.
3102 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3103 (UNIPROP_COMPRESSED_FORM_P): New macros.
3104 (char_table_ascii): Uncompress the compressed values.
3105 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3106 Uncompress the compressed values.
ac389d0c 3107 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3108 (char_table_ref_and_range): Uncompress the compressed values.
3109 (sub_char_table_set): New arg is_uniprop. Callers changed.
3110 Uncompress the compressed values.
3111 (sub_char_table_set_range): Args changed. Callers changed.
3112 (char_table_set_range): Adjuted for the above change.
3113 (map_sub_char_table): Delete args default_val and parent. Add arg
3114 top. Give decoded values to a Lisp function.
640c8776 3115 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3116 values to a Lisp function. Gcpro more variables.
3117 (uniprop_table_uncompress)
3118 (uniprop_decode_value_run_length): New functions.
3119 (uniprop_decoder, uniprop_decoder_count): New variables.
3120 (uniprop_get_decoder, uniprop_encode_value_character)
3121 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3122 New functions.
3123 (uniprop_encoder, uniprop_encoder_count): New variables.
3124 (uniprop_get_encoder, uniprop_table)
3125 (Funicode_property_table_internal, Fget_unicode_property_internal)
3126 (Fput_unicode_property_internal): New functions.
3127 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3128 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3129 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3130 char-code-property-alist.
3131
640c8776 3132 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3133 Vunicode_category_table.
3134
640c8776 3135 * font.c (font_range): Adjust for the change of
c805dec0
KH
3136 Vunicode_category_table.
3137
76b397fb
DN
31382011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3139
3140 * m/iris4d.h: Remove file, move contents ...
3141 * s/irix6-5.h: ... here.
3142
22b4128e
PE
31432011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3144
3145 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3146 * alloc.c (mark_buffer):
3147 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3148 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3149 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3150 This isn't true in general, and it's particularly not true
3151 if Emacs is configured with --with-wide-int.
3152 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3153 New macros, used in the buffer.c change.
3154
869795d6
JD
31552011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3156
3157 * xsettings.c: Use both GConf and GSettings if both are available.
3158 (store_config_changed_event): Add comment.
3159 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3160 (store_tool_bar_style_changed): New functions.
5e617bc2 3161 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3162 (struct xsettings): Move font inside HAVE_XFT.
3163 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3164 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3165 Move inside HAVE_XFT.
640c8776 3166 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3167 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3168 also.
3169 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3170 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3171 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3172 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3173 (parse_settings): Move check for font inside HAVE_XFT.
3174 (read_settings, apply_xft_settings): Add comment.
3175 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3176 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3177 call store_font_name_changed.
3178 (xft_settings_event): Add comment.
3179 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3180 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3181 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3182 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3183 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3184 (xsettings_get_system_font, xsettings_get_system_normal_font):
3185 Add comment.
869795d6 3186
d8ed26bd
PE
31872011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3188
3189 Random fixes. E.g., (random) never returned negative values.
3190 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3191 subseconds part to the entropy, as that's a bit more random.
3192 Prefer signed to unsigned, since the signedness doesn't matter and
3193 in general we prefer signed. When given a limit, use a
3194 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3195 latter isn't right if USE_2_TAGS_FOR_INTS.
3196 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3197 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3198
cabf1cac
SM
31992011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3200
3201 * textprop.c (text_property_stickiness):
3202 Obey Vtext_property_default_nonsticky.
3203 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3204 * w32fns.c (syms_of_w32fns):
3205 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3206
6e9b2be9
PE
32072011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3208
3209 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3210 This is more efficient than Ffile_directory_p and avoids a minor race.
3211
90186c68
LMI
32122011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3213
7c301272
LMI
3214 * buffer.c (Foverlay_put): Say what the return value is
3215 (bug#7835).
3216
c4f2d8d4
LMI
3217 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3218 is a directory before asking whether to use the file name
3219 (bug#7564).
ad637907
LMI
3220 (barf_or_query_if_file_exists): Make the "File is a directory"
3221 error be more correct.
c4f2d8d4 3222
90186c68
LMI
3223 * fns.c (Frequire): Remove the mention of the .gz files, since
3224 that's installation-specific, but keep the mention of
3225 `get-load-suffixes'.
3226
da64016e
PE
32272011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3228
3229 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3230 Report string overflow if the output is too long.
3231
7d47b580
JB
32322011-07-04 Juanma Barranquero <lekktu@gmail.com>
3233
a555cb87
JB
3234 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3235 (syms_of_gnutls): Remove duplicate DEFSYM for
3236 Qgnutls_bootprop_verify_hostname_error, an error for
3237 Qgnutls_bootprop_verify_error (which is no longer used).
3238
7d47b580
JB
3239 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3240 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3241 Also (re)move comments that are misplaced or no longer relevant.
3242
1e49bfab
LMI
32432011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3244
3245 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3246
1485f4c0
CY
32472011-07-03 Chong Yidong <cyd@stupidchicken.com>
3248
3249 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3250 and background color parameters if they have been changed.
3251
a9ab721e
LMI
32522011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3253
3254 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3255
cf7cff57
PE
32562011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3257
2e13213d
PE
3258 * xsettings.c (SYSTEM_FONT): Define only when used.
3259 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3260
cf7cff57
PE
3261 * keymap.c (access_keymap_1): Now static.
3262
7a8e04f7
CY
32632011-07-02 Chong Yidong <cyd@stupidchicken.com>
3264
3265 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3266 leave any prefix arg for the up event (Bug#1586).
3267
61352f62
LMI
32682011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3269
69bb1ef7
LMI
3270 * lread.c (syms_of_lread): Mention single symbols defined by
3271 `defvar' or `defconst' (bug#7154).
3272
61352f62 3273 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3274 (Frequire): Mention get-load-suffixes.
61352f62 3275
28545e04
MR
32762011-07-02 Martin Rudalics <rudalics@gmx.at>
3277
3278 * window.h (window): Remove clone_number slot.
3279 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3280 Remove.
3281 (make_parent_window, make_window, saved_window)
3282 (Fset_window_configuration, save_window_save): Don't deal with
3283 clone numbers.
3284 * buffer.c (Qclone_number): Remove declaration.
3285 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3286
3349e122
SM
32872011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3288
3289 Add multiple inheritance to keymaps.
3290 * keymap.c (Fmake_composed_keymap): New function.
3291 (Fset_keymap_parent): Simplify.
3292 (fix_submap_inheritance): Remove.
3293 (access_keymap_1): New function extracted from access_keymap to handle
3294 embedded parents and handle lists of maps.
3295 (access_keymap): Use it.
3296 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3297 (Fcopy_keymap): Handle embedded parents.
3298 (Fcommand_remapping, define_as_prefix): Simplify.
3299 (Fkey_binding): Simplify.
3300 (syms_of_keymap): Move minibuffer-local-completion-map,
3301 minibuffer-local-filename-completion-map,
3302 minibuffer-local-must-match-map, and
3303 minibuffer-local-filename-must-match-map to Elisp.
3304 (syms_of_keymap): Defsubr make-composed-keymap.
3305 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3306 (parse_menu_item): Trivial simplification.
3307
3279eb87
GM
33082011-07-01 Glenn Morris <rgm@gnu.org>
3309
3310 * Makefile.in (SETTINGS_LIBS): Fix typo.
3311
4550efdf
KI
33122011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3313
3314 * coding.c (Fencode_coding_string): Record the last coding system
3315 used, as the function doc string says (bug#8738).
3316
0949d2b6
JD
33172011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3318
3319 * xsettings.c (store_monospaced_changed): Take new font as arg and
3320 check for change against current_mono_font.
3321 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3322 (emacs_settings_constructor, emacs_settings_get_property)
3323 (emacs_settings_set_property, emacs_settings_class_init)
3324 (emacs_settings_init, gsettings_obj): Remove.
3325 (something_changedCB): New function for HAVE_GSETTINGS.
3326 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3327 with value as argument.
3328 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3329 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3330 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3331 "changed".
3332
3333 * xgselect.c: Add defined (HAVE_GSETTINGS).
3334 (xgselect_initialize): Ditto.
3335
3336 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3337 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3338 xg_select.
3339
bbc6b304
PE
33402011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3341
3342 * eval.c (struct backtrace): Simplify and port the data structure.
3343 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3344 signed bit field, as this assumption is not portable and it makes
3345 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3346 "char debug_on_exit : 1" as this is not portable either; instead,
3347 use the portable "unsigned int debug_on_exit : 1". Remove unused
3348 member evalargs. Remove obsolete comments about cc bombing out.
3349
9851bfc5
JD
33502011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3351
51bb811f 3352 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3353 Let HAVE_GSETTINGS override HAVE_GCONF.
3354 (store_monospaced_changed): New function.
3355 (EMACS_SETTINGS): A new type derived from GObject to handle
3356 GSettings notifications.
3357 (emacs_settings_constructor, emacs_settings_get_property)
3358 (emacs_settings_set_property, emacs_settings_class_init):
3359 New functions.
3360 (gsettings_client, gsettings_obj): New variables.
3361 (GSETTINGS_SCHEMA): New define.
3362 (something_changedCB): Call store_monospaced_changed.
3363 (init_gsettings): New function.
3364 (xsettings_initialize): Call init_gsettings.
3365 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3366 to NULL.
3367
640c8776 3368 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3369 GCONF_CFLAGS/LIBS.
3370
5386012d
MR
33712011-06-29 Martin Rudalics <rudalics@gmx.at>
3372
3373 * window.c (resize_root_window, grow_mini_window)
3374 (shrink_mini_window): Rename Qresize_root_window to
3375 Qwindow_resize_root_window and Qresize_root_window_vertically to
3376 Qwindow_resize_root_window_vertically.
3377
f13e0b08
PE
33782011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3379
3380 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3381
94515237
JB
33822011-06-27 Juanma Barranquero <lekktu@gmail.com>
3383
3384 * makefile.w32-in: Redesign dependencies so they reflect more
3385 clearly which files are directly included by each source file,
3386 and not through other includes.
3387
e43b6e43
MR
33882011-06-27 Martin Rudalics <rudalics@gmx.at>
3389
3390 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3391 (sort_overlays, overlay_strings): When an overlay's clone number
3392 matches the window's clone number process the overlay even if
3393 the overlay's window property doesn't match the current window.
3394
d68443dc
MR
3395 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3396 (Fwindow_hchild): Rename to Fwindow_left_child.
3397 (Fwindow_next): Rename to Fwindow_next_sibling.
3398 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3399 (resize_window_check): Rename to window_resize_check.
3400 (resize_window_apply): Rename to window_resize_apply.
3401 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3402 (Fdelete_other_windows_internal, resize_frame_windows)
3403 (Fsplit_window_internal, Fdelete_window_internal)
3404 (grow_mini_window, shrink_mini_window)
3405 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3406
c7e73be5
JD
34072011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3408
3409 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3410 (emacs_fixed_set_min_size): Remove.
3411 (emacs_fixed_new): Take frame as argument.
3412
3413 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3414 (_EmacsFixedPrivate): Remove minwidth/height.
3415 Add struct frame *f.
3416 (emacs_fixed_init): Initialize priv->f.
3417 (get_parent_class, emacs_fixed_set_min_size): Remove.
3418 (emacs_fixed_new): Set priv->f to argument.
3419 (emacs_fixed_get_preferred_width)
3420 (emacs_fixed_get_preferred_height): Use min_width/height from
3421 frames size_hint to set minimum and natural (Bug#8919).
3422 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3423 and use min_width/height from frames size_hint to set
3424 min_width/height (Bug#8919).
3425
3426 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3427 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3428 Fix indentation.
c7e73be5 3429
cf99dcf8
EZ
34302011-06-26 Eli Zaretskii <eliz@gnu.org>
3431
3432 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3433 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3434 called at ZV.
3435
029529ac
CY
34362011-06-26 Chong Yidong <cyd@stupidchicken.com>
3437
3438 * process.c (wait_reading_process_output): Bypass select if
3439 waiting for a cell while ignoring keyboard input, and input is
3440 pending. Suggested by Jan Djärv (Bug#8869).
3441
7a7ef429
PE
34422011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3443
3444 Use gnulib's dup2 module instead of rolling our own.
3445 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3446
11fdef7d 34472011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3448
3449 * dispnew.c (scrolling_window): Before scrolling, turn off a
3450 mouse-highlight in the window being scrolled.
3451
cd3520a4
JB
34522011-06-24 Juanma Barranquero <lekktu@gmail.com>
3453
3454 Move DEFSYM to lisp.h and use everywhere.
3455
3456 * character.h (DEFSYM): Move declaration...
3457 * lisp.h (DEFSYM): ...here.
3458
3459 * gnutls.c:
3460 * minibuf.c:
3461 * w32menu.c:
3462 * w32proc.c:
3463 * w32select.c: Don't include character.h.
3464
3465 * alloc.c (syms_of_alloc):
3466 * buffer.c (syms_of_buffer):
3467 * bytecode.c (syms_of_bytecode):
3468 * callint.c (syms_of_callint):
3469 * casefiddle.c (syms_of_casefiddle):
3470 * casetab.c (init_casetab_once):
3471 * category.c (init_category_once, syms_of_category):
3472 * ccl.c (syms_of_ccl):
3473 * cmds.c (syms_of_cmds):
3474 * composite.c (syms_of_composite):
3475 * dbusbind.c (syms_of_dbusbind):
3476 * dired.c (syms_of_dired):
3477 * dispnew.c (syms_of_display):
3478 * doc.c (syms_of_doc):
3479 * editfns.c (syms_of_editfns):
3480 * emacs.c (syms_of_emacs):
3481 * eval.c (syms_of_eval):
3482 * fileio.c (syms_of_fileio):
3483 * fns.c (syms_of_fns):
3484 * frame.c (syms_of_frame):
3485 * fringe.c (syms_of_fringe):
3486 * insdel.c (syms_of_insdel):
3487 * keymap.c (syms_of_keymap):
3488 * lread.c (init_obarray, syms_of_lread):
3489 * macros.c (syms_of_macros):
3490 * msdos.c (syms_of_msdos):
3491 * print.c (syms_of_print):
3492 * process.c (syms_of_process):
3493 * search.c (syms_of_search):
3494 * sound.c (syms_of_sound):
3495 * syntax.c (init_syntax_once, syms_of_syntax):
3496 * terminal.c (syms_of_terminal):
3497 * textprop.c (syms_of_textprop):
3498 * undo.c (syms_of_undo):
3499 * w32.c (globals_of_w32):
3500 * window.c (syms_of_window):
3501 * xdisp.c (syms_of_xdisp):
3502 * xfaces.c (syms_of_xfaces):
3503 * xfns.c (syms_of_xfns):
3504 * xmenu.c (syms_of_xmenu):
3505 * xsettings.c (syms_of_xsettings):
3506 * xterm.c (syms_of_xterm): Use DEFSYM.
3507
4228cf16
TZ
35082011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3509
cd3520a4 3510 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3511
7fcccf1e
PE
35122011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3513
7efb4e0e
PE
3514 Integer and buffer overflow fixes (Bug#8873).
3515
ff5844ad
PE
3516 * print.c (printchar, strout): Check for string overflow.
3517 (PRINTPREPARE, printchar, strout):
3518 Don't set size unless allocation succeeds.
3519
90532f02
PE
3520 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3521 for sizes. Check for string overflow more accurately.
3522 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3523
6d84508d
PE
3524 * macros.c: Integer and buffer overflow fixes.
3525 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3526 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3527 Use ptrdiff_t, not int, for sizes.
3528 Don't increment bufsize until after realloc succeeds.
3529 Check for size-calculation overflow.
3530 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3531
437b2cb4
PE
3532 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3533
8b9ac8b4
PE
3534 * lread.c: Integer overflow fixes.
3535 (read_integer): Radix is now EMACS_INT, not int,
3536 to improve quality of diagnostics for out-of-range radices.
3537 Calculate buffer size correctly for out-of-range radices.
3538 (read1): Check for integer overflow in radices, and in
3539 read-circle numbers.
82cb60d3
PE
3540 (read_escape): Avoid int overflow.
3541 (Fload, openp, read_buffer_size, read1)
3542 (substitute_object_recurse, read_vector, read_list, map_obarray):
3543 Use ptrdiff_t, not int, for sizes.
3544 (read1): Use EMACS_INT, not int, for sizes.
20270765 3545 Check for size overflow.
8b9ac8b4 3546
7fcccf1e
PE
3547 * image.c (cache_image): Check for size arithmetic overflow.
3548
bfbbd7e7
PE
3549 * lread.c: Integer overflow issues.
3550 (saved_doc_string_size, saved_doc_string_length)
3551 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3552 Now ptrdiff_t, not int.
3553 (read1): Don't assume doc string length fits in int. Check for
3554 out-of-range doc string lengths.
3555 (read_list): Don't assume file position fits in int.
39019e54 3556 (read_escape): Check for hex character overflow.
bfbbd7e7 3557
4e323265
LL
35582011-06-22 Leo Liu <sdl.web@gmail.com>
3559
3560 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3561 Move to minibuffer.el.
3562
85fece3e
PE
35632011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3564
20b84ce9 3565 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3566 The following patches are for when GLYPH_DEBUG && !XASSERT.
3567 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3568 * dispnew.c (flush_stdout):
3569 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3570 Mark as externally visible.
3571 * dispnew.c (check_window_matrix_pointers): Now static.
3572 * dispnew.c (window_to_frame_vpos):
3573 * xfns.c (unwind_create_frame):
3574 * xterm.c (x_check_font): Remove unused local.
3575 * scroll.c (CHECK_BOUNDS):
3576 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3577 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3578 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3579 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3580 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3581 Now static.
3582 (debug_method_add): Use va_list and vsprintf rather than relying
3583 on undefined behavior with wrong number of arguments.
3584 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3585 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3586 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3587 since we're not interested in debugging glyphs with old libraries.
3588 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3589 GCC 4.6.0's static checking.
3590
0766b489
PE
35912011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3592
31fd4b32
PE
3593 Integer overflow and signedness fixes (Bug#8873).
3594 A few related buffer overrun fixes, too.
3595
b79e8648
PE
3596 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3597
0766b489
PE
3598 * dispextern.h (struct face.stipple):
3599 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3600 (x_bitmap_mask, x_allocate_bitmap_record)
3601 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3602 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3603 (x_create_bitmap_from_xpm_data):
3604 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3605 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3606 (.bitmaps_last):
3607 * xfaces.c (load_pixmap):
3608 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3609 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3610 (.bitmaps_last, struct x_output.icon_bitmap):
3611 Use ptrdiff_t, not int, for bitmap indexes.
3612 (x_allocate_bitmap_record): Check for size overflow.
3613 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3614
b081724f
PE
3615 Use ptrdiff_t, not int, for overlay counts.
3616 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3617 * editfns.c (overlays_around, get_pos_property):
3618 * textprop.c (get_char_property_and_overlay):
3619 * xdisp.c (next_overlay_change, note_mouse_highlight):
3620 * xfaces.c (face_at_buffer_position):
21514da7
PE
3621 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3622 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3623 (Fnext_overlay_change, Fprevious_overlay_change)
3624 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3625 Use ptrdiff_t, not int, for sizes.
21514da7 3626 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3627
3de73e5e
PE
3628 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3629
2606c57b
PE
3630 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3631 (x_session_initialize): Do not assume string length fits in int.
3632
aaafe47a
PE
3633 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3634 This is unlikely, but can occur if DPI is outlandish.
3635
2674ddc8 3636 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3637 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3638
28154962
PE
3639 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3640 * xrdb.c (magic_file_p, search_magic_path):
3641 Omit last arg SUFFIX; it was always 0. All callers changed.
3642 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3643
7de51af5
PE
3644 * xfont.c (xfont_match): Avoid need for strlen.
3645
25ed6cc3
PE
3646 * xfns.c: Don't assume strlen fits in int.
3647 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3648
4eab31dd
PE
3649 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3650 not unsigned long, as we prefer signed integers. All callers changed.
3651 Detect integer overflow in repeat count.
3652 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3653 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3654
171e2a58
PE
3655 * termcap.c: Don't assume sizes fit in int and never overflow.
3656 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3657 (gobble_line): Check for size-calculation overflow.
3658
ad39faca 3659 * minibuf.c (Fread_buffer):
6e5bb2dc 3660 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3661 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3662 Don't assume string length fits in int.
3663
52c61c22 3664 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3665 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3666
b5b8c9e5
PE
3667 * font.c: Don't assume string length fits in int.
3668 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3669 Use ptrdiff_t, not int.
ccd6111c
PE
3670 (font_intern_prop): Don't assume string length fits in int.
3671 Don't assume integer property fits in fixnum.
3672 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3673
882f0d81 3674 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3675 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3676 Reformulate so as not to need the command string.
3677 Invoke gzip -cd rather than gunzip, as it's more portable.
3678 (lock_info_type, lock_file_1, lock_file):
3679 Don't assume pid_t and time_t fit in unsigned long.
3680 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3681 (current_lock_owner): Prefer signed type for sizes.
3682 Use memcpy, not strncpy, where memcpy is what is really wanted.
3683 Don't assume (via atoi) that time_t and pid_t fit in int.
3684 Check for time_t and/or pid_t out of range, e.g., via a network share.
3685 Don't alloca where an auto var works fine.
3686
93f4cf88
PE
3687 * fileio.c: Fix some integer overflow issues.
3688 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3689 Don't assume string length fits in int.
3690 (directory_file_name): Don't assume string length fits in long.
3691 (make_temp_name): Don't assume pid fits in int, or that its print
3692 length is less than 20.
3693
f3e92b69
PE
3694 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3695
1bfdaf10
PE
3696 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3697
35016e9a
PE
3698 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3699
3d1e65a1
PE
3700 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3701 We prefer signed integers, even for size calculations.
3702
0b963a93
PE
3703 * emacs.c: Don't assume string length fits in 'int'.
3704 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3705 (main): Don't invoke strlen when not needed.
3706
573f4b54
PE
3707 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3708 (XD_DEBUG_MESSAGE): Don't waste a byte.
3709
989f33ba
PE
3710 * callproc.c (getenv_internal_1, getenv_internal)
3711 (Fgetenv_internal):
965d34eb
PE
3712 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3713
e4d29b33
PE
3714 * lread.c (invalid_syntax): Omit length argument.
3715 All uses changed. This doesn't fix a bug, but it simplifies the
3716 code away from its former Hollerith-constant appearance, and it's
3717 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3718 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3719
eb49b136
PE
3720 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3721 This didn't break anything, but it didn't help either.
3722 It's confusing to put a bogus integer in a place where the actual
3723 value does not matter.
9f62aeb1 3724 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3725 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3726
15375a22
PE
3727 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3728 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3729 implementation.
b61cc01c
PE
3730 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3731 We prefer signed types, and the value cannot exceed the EMACS_INT
3732 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3733 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3734 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3735 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3736
53b2623d
PE
3737 * indent.c (sane_tab_width): New function.
3738 (current_column, scan_for_column, Findent_to, position_indentation)
3739 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3740 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3741
51cab52b 3742 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3743
f2ed8a70
PE
3744 * lisp.h (lint_assume): New macro.
3745 * composite.c (composition_gstring_put_cache):
3746 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3747
abe80cc6
PE
3748 * editfns.c, insdel.c:
3749 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3750
b02c740e
PE
3751 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3752
ebc96716
PE
3753 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3754
b4e50fa0 3755 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3756 Use much-faster test for byte-length change.
311d5d7c 3757 Don't assume string byte-length fits in 'int'.
a4cf38e4 3758 Check that character arg fits in 'int'.
85461888 3759 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3760
c0c1ee9f
PE
3761 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3762
a498d7f4
PE
3763 * fns.c (concat): Catch string overflow earlier.
3764 Do not rely on integer wraparound.
3765
51cab52b
PE
3766 * dispextern.h (struct it.overlay_strings_charpos)
3767 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3768 * xdisp.c (forward_to_next_line_start)
3769 (back_to_previous_visible_line_start)
3770 (reseat_at_next_visible_line_start, next_element_from_buffer):
3771 Don't arbitrarily truncate the value of 'selective' to int.
3772
76031fad
PE
3773 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3774
5eb55db9
PE
3775 * composite.c: Don't truncate sizes to 'int'.
3776 (composition_gstring_p, composition_reseat_it)
3777 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3778 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3779 not EMACS_UINT, for indexes.
5eb55db9 3780
0703a717
PE
3781 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3782
d6202519
PE
3783 * buffer.c: Include <verify.h>.
3784 (struct sortvec.priority, struct sortstr.priority):
8961a454 3785 Now EMACS_INT, not int.
c20998a7 3786 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3787 (struct sortstr.size, record_overlay_string)
3788 (struct sortstrlist.size, struct sortlist.used):
3789 Don't truncate size to int.
3790 (record_overlay_string): Check for size-calculation overflow.
d6202519 3791 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3792
d5a19415
JM
37932011-06-22 Jim Meyering <meyering@redhat.com>
3794
029529ac 3795 Don't leak an XBM-image-sized buffer
d5a19415
JM
3796 * image.c (xbm_load): Free the image buffer after using it.
3797
a9041e6c
PE
37982011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3799
3800 Port to Sun C.
3801 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3802 that Sun C diagnosed.
3803 * fns.c (secure_hash): Fix pointer signedness issue.
3804 * intervals.c (static_offset_intervals): New function.
3805 (offset_intervals): Use it.
3806
7f3f739f
LL
38072011-06-21 Leo Liu <sdl.web@gmail.com>
3808
3809 * deps.mk (fns.o):
3810 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3811 sha512.h.
3812
3813 * fns.c (secure_hash): Rename from crypto_hash_function and change
3814 the first arg to accept symbols.
5b66d427 3815 (Fsecure_hash): New primitive.
7f3f739f
LL
3816 (syms_of_fns): New symbols.
3817
76147d94
DD
38182011-06-20 Deniz Dogan <deniz@dogan.se>
3819
3820 * process.c (Fset_process_buffer): Clarify return value in
3821 docstring.
3822
7d7d0045
CY
38232011-06-18 Chong Yidong <cyd@stupidchicken.com>
3824
3825 * dispnew.c (add_window_display_history): Use BVAR.
3826
3827 * xdisp.c (debug_method_add): Use BVAR.
3828 (check_window_end, dump_glyph_matrix, dump_glyph)
3829 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3830
3831 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3832 Likewise.
3833
3834 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3835 check till after the cache is created in init_frame_faces.
3836
ff2bc410
SM
38372011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3838
3839 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3840
28177add
PE
38412011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3842
dd3482fe
PE
3843 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3844 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3845 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3846
393d71f3 3847 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3848 * fileio.c (Finsert_file_contents):
3849 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3850 Remove the old (too-loose) buffer overflow checks.
3851 They weren't needed, since make_gap checks for buffer overflow.
3852 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3853 The old code merely checked for Emacs fixnum overflow, and relied
3854 on undefined (wraparound) behavior. The new code avoids undefined
3855 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3856
2e6813b0 3857 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3858 Tune. Don't use wider integers than needed. Don't use alloca.
3859 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3860
599a9e4f
PE
3861 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3862
99561444
PE
3863 * insdel.c, lisp.h (buffer_overflow): New function.
3864 (insert_from_buffer_1, replace_range, replace_range_2):
3865 * insdel.c (make_gap_larger):
3866 * editfns.c (Finsert_char):
3867 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3868
28177add
PE
3869 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3870
e69dafad
PE
38712011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3872
a7af7fde 3873 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3874
b1c46f02
PE
3875 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3876 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3877
e69dafad
PE
3878 * fileio.c: Don't assume EMACS_INT fits in off_t.
3879 (emacs_lseek): New static function.
3880 (Finsert_file_contents, Fwrite_region): Use it.
3881 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3882
566684ea
PE
3883 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3884
e6966cd6
PE
3885 * fns.c: Don't overflow int when computing a list length.
3886 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3887 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3888 truncation on 64-bit hosts. Check for QUIT every
3889 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3890 faster and is responsive enough.
3891 (Flength): Report an error instead of overflowing an integer.
3892 (Fsafe_length): Return a float if the value is not representable
3893 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3894 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3895 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3896
dd0b0efb
PE
3897 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3898 (header_size, word_size): New constants.
3899 (allocate_vectorlike): Don't check size overflow here.
3900 (allocate_vector): Check it here instead, since this is the only
3901 caller of allocate_vectorlike that could cause overflow.
3902 Check that the new vector's length is representable as a fixnum.
3903
86fe5cfe
PE
3904 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3905 The previous code was bogus. For example, next_almost_prime (32)
3906 returned 39, which is undesirable as it is a multiple of 3; and
3907 next_almost_prime (24) returned 25, which is a multiple of 5 so
3908 why was the code bothering to check for multiples of 7?
3909
80e88859
PE
3910 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3911
4a2f0ad6
PE
3912 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3913
f66c7cf8
PE
3914 Variadic C functions now count arguments with ptrdiff_t.
3915 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3916 Back then I didn't know that the Emacs coding style prefers signed int.
3917 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3918 were being counted with int, which may truncate counts on 64-bit
3919 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3920 * lisp.h (struct Lisp_Subr.function.aMANY)
3921 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3922 Arg counts are now ptrdiff_t, not size_t.
3923 All variadic functions and their callers changed accordingly.
3924 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3925 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3926 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3927 * callint.c (Fcall_interactively): Check arg count for overflow,
3928 to avoid potential buffer overrun. Use signed char, not 'int',
3929 for 'varies' array, so that we needn't bother to check its size
3930 calculation for overflow.
3931 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3932 * eval.c (apply_lambda):
3933 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3934 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3935 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3936
a1759b76
PE
3937 * callint.c (Fcall_interactively): Don't use index var as event count.
3938
d96be9fc
PE
3939 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3940 * mem-limits.h (SIZE): Remove; no longer used.
3941
a690a978 3942 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3943
578c21e6
PE
3944 Remove unnecessary casts.
3945 * xterm.c (x_term_init):
3946 * xfns.c (x_set_border_pixel):
3947 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3948 These aren't needed now that we assume ANSI C.
3949
96f53c6c
PE
3950 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3951 It's more likely to cause problems (due to unsigned overflow)
3952 than to cure them.
3953
83c77d31
PE
3954 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3955
ee2079f1
PE
3956 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3957
6da65536
PE
3958 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3959
7147c4a4
PE
3960 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3961
193e32d9
PE
3962 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3963
e5533da6
PE
3964 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3965
9910e595
PE
3966 GLYPH_CODE_FACE returns EMACS_INT, not int.
3967 * dispextern.h (merge_faces):
3968 * xfaces.c (merge_faces):
01103c44
PE
3969 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3970 Don't assume EMACS_INT fits in int.
9910e595 3971
2638320e
PE
3972 * character.h (CHAR_VALID_P): Remove unused parameter.
3973 * fontset.c, lisp.h, xdisp.c: All uses changed.
3974
045eb8d9
PE
3975 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3976
c1f134b5
PE
3977 * fns.c (concat): Minor tuning based on overflow analysis.
3978 This doesn't fix any bugs. Use int to hold character, instead
3979 of constantly refetching from Emacs object. Use XFASTINT, not
3980 XINT, for value known to be a character. Don't bother comparing
3981 a single byte to 0400, as it's always less.
3982
395fcb93 3983 * floatfns.c (Fexpt):
327eeec8
PE
3984 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3985
abbd3d23
PE
3986 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3987 for characters.
3988
684a03ef
PE
3989 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3990
0fed43f3
PE
3991 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3992 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3993 incorrectly succeed when S was a string, because 4294967386 was
3994 truncated before it was used.
3995
8fd02eb7
PE
3996 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3997 Otherwise, an out-of-range integer could cause undefined behavior
3998 on a 64-bit host.
3999
f8c86b69
PE
4000 * composite.c: Use int, not EMACS_INT, for characters.
4001 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4002 EMACS_INT, for values that are known to be in character range.
4003 This doesn't fix any bugs but is the usual style inside Emacs and
4004 may generate better code on 32-bit machines.
4005
34206dd2
PE
4006 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4007 This is for reasons similar to the recent CHAR_STRING fix.
4008 * charset.c (Fencode_char): Check that character arg is actually
4009 a character. Pass an int to ENCODE_CHAR.
4010 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4011 wider than 'int', as a compile-time check to prevent future regressions
4012 in this area.
4013
c5958d4c 4014 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4015
4016 Make sure a 64-bit char is never passed to CHAR_STRING.
4017 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4018 by silently ignoring the top 32 bits, allowing some values
4019 that were far too large to be valid characters.
4020 * character.h: Include <verify.h>.
4021 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4022 arguments are no wider than unsigned, as a compile-time check
4023 to prevent future regressions in this area.
4024 * data.c (Faset):
01103c44 4025 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4026 (Fsubst_char_in_region):
4027 * fns.c (concat):
4028 * xdisp.c (decode_mode_spec_coding):
4029 Adjust to CHAR_STRING's new requirement.
4030 * editfns.c (Finsert_char, Fsubst_char_in_region):
4031 * fns.c (concat): Check that character args are actually
4032 characters. Without this test, these functions did the wrong
4033 thing with wildly out-of-range values on 64-bit hosts.
4034
d37ca623
PE
4035 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4036 These casts should not be needed on 32-bit hosts, either.
4037 * keyboard.c (read_char):
4038 * lread.c (Fload): Remove casts to unsigned.
4039
ea204efb
PE
4040 * lisp.h (UNSIGNED_CMP): New macro.
4041 This fixes comparison bugs on 64-bit hosts.
4042 (ASCII_CHAR_P): Use it.
4043 * casefiddle.c (casify_object):
01103c44 4044 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4045 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4046 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4047 * dispextern.h (FACE_FROM_ID):
4048 * keyboard.c (read_char): Use UNSIGNED_CMP.
4049
41cb286c
PE
4050 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4051 not to EMACS_INT, to avoid GCC warning.
4052
4a1b9832
PE
4053 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4054
55daad71
PE
4055 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4056 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4057 isn't needed on 32-bit machines.
8f95c75c 4058
01103c44
PE
4059 * buffer.c (Fgenerate_new_buffer_name):
4060 Use EMACS_INT for count, not int.
0ceccced 4061 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4062
4063 * data.c (Qcompiled_function): Now static.
4064
c6f072e7
PE
4065 * window.c (window_body_lines): Now static.
4066
20ce5912
PE
4067 * image.c (gif_load): Rename local to avoid shadowing.
4068
9c4c5f81
PE
4069 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4070 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4071 * alloc.c (make_save_value): Integer argument is now of type
4072 ptrdiff_t, not int.
4073 (mark_object): Use ptrdiff_t, not int.
4074 * lisp.h (pD): New macro.
4075 * print.c (print_object): Use it.
4076
c0c5c8ae
PE
4077 * alloc.c: Use EMACS_INT, not int, to count objects.
4078 (total_conses, total_markers, total_symbols, total_vector_size)
4079 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4080 (total_free_floats, total_floats, total_free_intervals)
4081 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4082 Now EMACS_INT, not int. All uses changed.
4083 (Fgarbage_collect): Compute overall total using a double, so that
4084 integer overflow is less likely to be a problem. Check for overflow
4085 when converting back to an integer.
5a25e253
PE
4086 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4087 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4088 These were 'int' variables that could overflow on 64-bit hosts;
4089 they were never used, so remove them instead of repairing them.
211a0b2a 4090 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4091 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4092 Previously, this ceilinged at INT_MAX, but that doesn't work on
4093 64-bit machines.
e46bb31a 4094 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4095
c78baabf 4096 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4097 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4098 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4099 when a (possibly-narrower) signed value would do just as well.
4100 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4101
c9d624c6
PE
4102 * alloc.c: Catch some string size overflows that we were missing.
4103 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4104 for convenience in STRING_BYTES_MAX.
4105 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4106 The definition here is exact; the one in lisp.h was approximate.
4107 (allocate_string_data): Check for string overflow. This catches
4108 some instances we weren't catching before. Also, it catches
4109 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4110 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4111 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4112
c9d624c6
PE
4113 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4114 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4115 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4116
353032ce
PE
4117 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4118
2bccce07
PE
4119 * alloc.c (Fmake_string): Check for out-of-range init.
4120
0ac30604
SM
41212011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4122
4123 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4124
c195f2de
JD
41252011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4126
4127 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4128 xg_get_default_scrollbar_width.
4129
4130 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4131 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4132 (style_changed_cb): Call update_theme_scrollbar_width and call
4133 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4134 all frames (Bug#8505).
4135 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4136 Call gtk_window_set_resizable if HAVE_GTK3.
4137 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4138 and height if HAVE_GTK3 (Bug#8505).
4139 (scroll_bar_width_for_theme): New variable.
4140 (update_theme_scrollbar_width): New function.
4141 (xg_get_default_scrollbar_width): Move code to
4142 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4143 (xg_initialize): Call update_theme_scrollbar_width.
4144
4145 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4146
4147 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4148
e10ac9f1
MR
41492011-06-12 Martin Rudalics <rudalics@gmx.at>
4150
4151 * frame.c (make_frame): Call other_buffer_safely instead of
4152 other_buffer.
4153
4154 * window.c (temp_output_buffer_show): Call display_buffer with
4155 second argument Vtemp_buffer_show_specifiers and reset latter
4156 immediately after the call.
4157 (Vtemp_buffer_show_specifiers): New variable.
4158 (auto_window_vscroll_p, next_screen_context_lines)
4159 (Vscroll_preserve_screen_position): Remove leading asterisks from
4160 doc-strings.
4161
2d3c217e 41622011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4163
7b7f97e8 4164 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4165 * buffer.c (Qclone_number): Remove for now, as it's unused.
4166 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4167 (record_buffer): Remove unused local.
4168 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4169 (set_frame_buffer_list): Remove; unused.
4170 * frame.h (other_visible_frames): Remove decl.
4171 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4172 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4173 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4174 if HAVE_GPM.
4175 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4176 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4177 Define only if HAVE_GPM.
4178 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4179 (update_hints_inhibit): Remove; never set. All uses removed.
4180 * widgetprv.h (emacsFrameClassRec): Remove decl.
4181 * window.c (delete_deletable_window): Now returns void, since it
4182 wasn't returning anything.
4183 (compare_window_configurations): Remove unused locals.
4184 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4185 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4186 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4187 the same widths as pointers. This follows up on the 2011-05-06 patch.
4188 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4189 * xterm.h: Likewise.
4190 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4191
1384b89e
JB
41922011-06-12 Juanma Barranquero <lekktu@gmail.com>
4193
4194 * makefile.w32-in: Update dependencies.
4195 (LISP_H): Add lib/intprops.h.
4196
1100a63c
CY
41972011-06-11 Chong Yidong <cyd@stupidchicken.com>
4198
4199 * image.c (gif_load): Add animation frame delay to the metadata.
4200 (syms_of_image): Use DEFSYM. New symbol `delay'.
4201
6198ccd0
MR
42022011-06-11 Martin Rudalics <rudalics@gmx.at>
4203
4204 * window.c (delete_deletable_window): Re-add.
4205 (Fset_window_configuration): Rewrite to handle dead buffers and
4206 consequently deletable windows.
4207 (window_tree, Fwindow_tree): Remove. Supply functionality in
4208 window.el.
4209 (compare_window_configurations): Simplify code.
4210
b6e3633c
AS
42112011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4212
1ab0dee5
AS
4213 * image.c (imagemagick_load_image): Fix type mismatch.
4214 (Fimagemagick_types): Likewise.
4215
b6e3633c
AS
4216 * window.h (replace_buffer_in_windows): Declare.
4217
9397e56f
MR
42182011-06-11 Martin Rudalics <rudalics@gmx.at>
4219
4220 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4221 Qclone_number. Remove external declaration of Qdelete_window.
4222 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4223 code.
640c8776
SM
4224 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4225 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4226 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4227 buffer list implementation.
4228 (other_buffer_safely): New function.
4229 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4230 calls to replace_buffer_in_windows and
4231 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4232 if allowed.
4233 (record_buffer): Inhibit quitting and rewrite using quittable
4234 functions. Run Qbuffer_list_update_hook if allowed.
4235 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4236 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4237 Move switch-to-buffer to window.el.
9397e56f
MR
4238 (bury-buffer): Move to window.el.
4239 (Vbuffer_list_update_hook): New variable.
4240
4241 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4242 section.
4243
4244 * window.h (resize_frame_windows): Move up in code.
4245 (Fwindow_frame): Remove EXFUN.
4246 (replace_buffer_in_all_windows): Remove prototype.
4247 (replace_buffer_in_windows_safely): Add prototype.
4248
4249 * window.c: Declare Qdelete_window static again. Move down
4250 declaration of select_count.
4251 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4252 (Fother_window): Move to window.el.
4253 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4254 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4255 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4256 window.el.
4257 (replace_buffer_in_windows): Implement by calling
4258 Qreplace_buffer_in_windows.
4259 (replace_buffer_in_all_windows): Remove with some functionality
4260 moved into replace_buffer_in_windows_safely.
4261 (replace_buffer_in_windows_safely): New function.
4262 (select_window_norecord, select_frame_norecord): Move in front
4263 of run_window_configuration_change_hook. Remove now obsolete
4264 declarations.
640c8776
SM
4265 (Fset_window_buffer): Rewrite doc-string.
4266 Call Qrecord_window_buffer.
9397e56f
MR
4267 (keys_of_window): Move binding for other-window to window.el.
4268
b50691aa
CY
42692011-06-11 Chong Yidong <cyd@stupidchicken.com>
4270
4271 * dispextern.h (struct image): Replace data member, whose int_val
4272 and ptr_val fields were not used by anything, with a single
4273 lisp_val object.
4274
4275 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4276 (gif_clear_image, gif_load, imagemagick_load_image)
4277 (gs_clear_image, gs_load): Callers changed.
4278
3f754b86
PE
42792011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4280
cca69397
PE
4281 * buffer.h: Include <time.h>, for time_t.
4282 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4283
109e28d0
PE
4284 Fix minor problems found by static checking.
4285
60737f02
PE
4286 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4287
4b66faf3
PE
4288 Make identifiers static if they are not used in other modules.
4289 * data.c (Qcompiled_function, Qframe, Qvector):
4290 * image.c (QimageMagick, Qsvg):
4291 * minibuf.c (Qmetadata):
4292 * window.c (resize_window_check, resize_root_window): Now static.
4293 * window.h (resize_window_check, resize_root_window): Remove decls.
4294
109e28d0
PE
4295 * window.c (window_deletion_count, delete_deletable_window):
4296 Remove; unused.
46a4ce9e
PE
4297 (window_body_lines): Now static.
4298 (Fdelete_other_windows_internal): Mark vars as initialized.
4299 Make sure 'resize_failed' is initialized.
4300 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4301 (resize_window_apply): Remove unused local.
4302 * window.h (delete_deletable_window): Remove decl.
4303
109e28d0 4304 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4305 (imagemagick_load_image): Fix pointer signedness problem by changing
4306 last arg from unsigned char * to char *. All uses changed.
4307 Also, fix a local for similar reasons.
4308 Remove unused locals. Remove locals to avoid shadowing.
4309 (fn_rsvg_handle_free): Remove; unused.
4310 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4311 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4312
3f754b86
PE
4313 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4314
2547adb1
CY
43152011-06-10 Chong Yidong <cyd@stupidchicken.com>
4316
4317 * image.c (gif_load): Fix omitted cast error introduced by
4318 2011-06-06 change.
4319
2c8e37d4
MR
43202011-06-10 Martin Rudalics <rudalics@gmx.at>
4321
4322 * window.h (resize_proportionally, orig_total_lines)
4323 (orig_top_line): Remove from window structure.
4324 (set_window_height, set_window_width, change_window_heights)
4325 (Fdelete_window): Remove prototypes.
4326 (resize_frame_windows): Remove duplicate declaration.
4327
440a42e3
EZ
43282011-06-10 Eli Zaretskii <eliz@gnu.org>
4329
4330 * window.h (resize_frame_windows, resize_window_check)
4331 (delete_deletable_window, resize_root_window)
4332 (resize_frame_windows): Declare prototypes.
4333
4334 * window.c (resize_window_apply): Make definition be "static" to
4335 match the prototype.
4336
562dd5e9
MR
43372011-06-10 Martin Rudalics <rudalics@gmx.at>
4338
4339 * window.c: Remove declarations of Qwindow_size_fixed,
4340 window_min_size_1, window_min_size_2, window_min_size,
4341 size_window, window_fixed_size_p, enlarge_window, delete_window.
4342 Remove static from declaration of Qdelete_window, it's
4343 temporarily needed by Fbury_buffer.
4344 (replace_window): Don't assign orig_top_line and
4345 orig_total_lines.
4346 (Fdelete_window, delete_window): Remove. Window deletion is
4347 handled by window.el.
640c8776
SM
4348 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4349 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4350 (Fdelete_other_windows): Remove. Deleting other windows is
4351 handled by window.el.
4352 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4353 handled in window.el.
4354 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4355 Window minimum sizes are handled in window.el.
4356 (shrink_windows, size_window, set_window_height)
4357 (set_window_width, change_window_heights, window_height)
4358 (window_width, CURBEG, CURSIZE, enlarge_window)
4359 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4360 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4361 handled in window.el.
4362 (make_dummy_parent): Rename to make_parent_window and give it a
4363 second argument horflag.
4364 (make_window): Don't set resize_proportionally any more.
4365 (Fsplit_window): Remove. Windows are split in window.el.
4366 (save_restore_action, save_restore_orig_size)
4367 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4368 Resize mini windows in window.el.
4369 (grow_mini_window, shrink_mini_window): Implement by calling
4370 Qresize_root_window_vertically, resize_window_check and
4371 resize_window_apply.
640c8776
SM
4372 (saved_window, Fset_window_configuration, save_window_save):
4373 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4374 resize_proportionally.
4375 (window_min_height, window_min_width): Move to window.el.
4376 (keys_of_window): Move bindings for delete-other-windows,
4377 split-window, delete-window and enlarge-window to window.el.
4378
4379 * buffer.c: Temporarily extern Qdelete_window.
4380 (Fbury_buffer): Temporarily call Qdelete_window instead of
4381 Fdelete_window (Fbury_buffer will move to window.el soon).
4382
4383 * frame.c (set_menu_bar_lines_1): Remove code handling
4384 orig_top_line and orig_total_lines.
4385
4386 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4387 set_window_height but set heights directly.
4388 (change_frame_size_1): Use resize_frame_windows.
4389
4390 * xdisp.c (init_xdisp): Don't use set_window_height but set
4391 heights directly.
4392
640c8776
SM
4393 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4394 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4395 run_window_configuration_change_hook.
4396
4397 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4398 instead of change_window_heights and run
4399 run_window_configuration_change_hook.
4400
1a13852e
MR
44012011-06-09 Martin Rudalics <rudalics@gmx.at>
4402
4403 * window.c (replace_window): Rename second argument REPLACEMENT to
4404 NEW. New third argument SETFLAG. Rewrite.
4405 (delete_window, make_dummy_parent): Call replace_window with
4406 third argument 1.
4407 (window_list_1): Move down in code.
4408 (run_window_configuration_change_hook): Move set_buffer part
4409 before select_frame_norecord part in order to unwind correctly.
4410 Rename count1 to count.
4411 (recombine_windows, delete_deletable_window, resize_root_window)
4412 (Fdelete_other_windows_internal)
4413 (Frun_window_configuration_change_hook, make_parent_window)
4414 (resize_window_check, resize_window_apply, Fresize_window_apply)
4415 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4416 (Fdelete_window_internal, Fresize_mini_window_internal):
4417 New functions.
1a13852e
MR
4418 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4419
f3d1777e
MR
44202011-06-08 Martin Rudalics <rudalics@gmx.at>
4421
496e208e
MR
4422 * window.h (window): Add some new members to window structure -
4423 normal_lines, normal_cols, new_total, new_normal, clone_number,
4424 splits, nest, prev_buffers, next_buffers.
4425 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4426 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4427
f3d1777e
MR
4428 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4429 Remove.
496e208e
MR
4430 (make_dummy_parent): Set new members of windows structure.
4431 (make_window): Move down in code. Handle new members of window
4432 structure.
4433 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4434 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4435 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4436 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4437 (Fset_window_next_buffers, Fset_window_clone_number):
4438 New functions.
496e208e
MR
4439 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4440 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4441 Doc-string fixes.
4442 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4443 Argument WINDOW can be now internal window too.
4444 (Fwindow_use_time): Move up in code.
4445 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4446 Rewrite doc-string.
4447 (Fset_window_configuration, saved_window)
4448 (Fcurrent_window_configuration, save_window_save): Handle new
4449 members of window structure.
b9e809c2
MR
4450 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4451 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4452 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4453 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4454 Qget_mru_window, Qresize_root_window,
4455 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4456 Qauto_buffer_name; staticpro them.
f3d1777e 4457
abde8f8c
MR
44582011-06-07 Martin Rudalics <rudalics@gmx.at>
4459
4460 * window.c (Fwindow_total_size, Fwindow_left_column)
4461 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4462 (Fwindow_list_1): New functions.
4463 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4464 (Fwindow_width, Fscroll_left, Fscroll_right):
4465 Use window_body_cols instead of window_box_text_cols.
4466 (delete_window, Fset_window_configuration):
4467 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4468 (delete_all_subwindows): Take a window as argument and not a
4469 structure. Rewrite.
190b47e6
MR
4470 (window_loop): Remove handling of GET_LRU_WINDOW and
4471 GET_LARGEST_WINDOW.
4472 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4473
4474 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4475 window_box_text_cols. delete_all_subwindows now takes a
4476 Lisp_Object as argument.
abde8f8c 4477
640c8776
SM
4478 * indent.c (compute_motion, Fcompute_motion):
4479 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4480
fa8a67e6
MR
4481 * frame.c (delete_frame): Call delete_all_subwindows with root
4482 window as argument.
4483
a54e3482
DC
44842011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4485
4486 * fns.c (Fputhash): Document return value.
4487
60002bf5
CY
44882011-06-06 Chong Yidong <cyd@stupidchicken.com>
4489
4490 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4491
0c671da6 44922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4493
b862a52a 4494 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4495
be44ca6c
PE
4496 Check for overflow when converting integer to cons and back.
4497 * charset.c (Fdefine_charset_internal, Fdecode_char):
4498 Use cons_to_unsigned to catch overflow.
4499 (Fencode_char): Use INTEGER_TO_CONS.
4500 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4501 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4502 * data.c (long_to_cons, cons_to_long): Remove.
4503 (cons_to_unsigned, cons_to_signed): New functions.
4504 These signal an error for invalid or out-of-range values.
4505 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4506 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4507 * font.c (Ffont_variation_glyphs):
4508 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4509 * lisp.h: Include <intprops.h>.
4510 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4511 (cons_to_signed, cons_to_unsigned): New decls.
4512 (long_to_cons, cons_to_long): Remove decls.
4513 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4514 (Fprimitive_undo): Use CONS_TO_INTEGER.
4515 * xfns.c (Fx_window_property): Likewise.
4516 * xselect.c: Include <limits.h>.
4517 (x_own_selection, selection_data_to_lisp_data):
4518 Use INTEGER_TO_CONS.
4519 (x_handle_selection_request, x_handle_selection_clear)
4520 (x_get_foreign_selection, Fx_disown_selection_internal)
4521 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4522 (lisp_data_to_selection_data): Use cons_to_unsigned.
4523 (x_fill_property_data): Use cons_to_signed.
4524 Report values out of range.
4525
d1f3d2af
PE
4526 Check for buffer and string overflow more precisely.
4527 * buffer.h (BUF_BYTES_MAX): New macro.
4528 * lisp.h (STRING_BYTES_MAX): New macro.
4529 * alloc.c (Fmake_string):
4530 * character.c (string_escape_byte8):
4531 * coding.c (coding_alloc_by_realloc):
4532 * doprnt.c (doprnt):
4533 * editfns.c (Fformat):
4534 * eval.c (verror):
4535 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4536 since they may not be the same number.
4537 * editfns.c (Finsert_char):
4538 * fileio.c (Finsert_file_contents):
4539 Likewise for BUF_BYTES_MAX.
4540
dd52fcea
PE
4541 * image.c: Use ptrdiff_t, not int, for sizes.
4542 (slurp_file): Switch from int to ptrdiff_t.
4543 All uses changed.
4544 (slurp_file): Check that file size fits in both size_t (for
4545 malloc) and ptrdiff_t (for sanity and safety).
4546
7f9bbdbb
PE
4547 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4548 if b->modtime has its maximal value.
4549
dfe18f82
PE
4550 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4551
84acfcf0
PE
4552 Don't assume time_t can fit into int.
4553 * buffer.h (struct buffer.modtime): Now time_t, not int.
4554 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4555 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4556
ccd9a01a
PE
4557 Minor fixes for signed vs unsigned integers.
4558 * character.h (MAYBE_UNIFY_CHAR):
4559 * charset.c (maybe_unify_char):
4560 * keyboard.c (read_char, reorder_modifiers):
4561 XINT -> XFASTINT, since the integer must be nonnegative.
4562 * ftfont.c (ftfont_spec_pattern):
4563 * keymap.c (access_keymap, silly_event_symbol_error):
4564 XUINT -> XFASTINT, since the integer must be nonnegative.
4565 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4566 since it makes no difference and we prefer signed.
4567 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4568 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4569 nonnegative.
4570
d6d100dd
SM
45712011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4572
4573 * window.h (Fwindow_frame): Declare.
4574
2b6148e4
PE
45752011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4576
4577 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4578 (SPARE_MEMORY): Always define.
4579 (LARGE_REQUEST): Remove.
4580 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4581
f230ecc9
MR
45822011-06-06 Martin Rudalics <rudalics@gmx.at>
4583
727e958e
MR
4584 * lisp.h: Move EXFUNS for Fframe_root_window,
4585 Fframe_first_window and Fset_frame_selected_window to window.h.
4586
4587 * window.h: Move EXFUNS for Fframe_root_window,
4588 Fframe_first_window and Fset_frame_selected_window here from
4589 lisp.h.
4590
4591 * frame.c (Fwindow_frame, Fframe_first_window)
4592 (Fframe_root_window, Fframe_selected_window)
4593 (Fset_frame_selected_window): Move to window.c.
4594 (Factive_minibuffer_window): Move to minibuf.c.
4595 (Fother_visible_frames_p): New function.
4596
4597 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4598
f230ecc9
MR
4599 * window.c (decode_window, decode_any_window): Move up in code.
4600 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4601 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4602 (Fwindow_buffer): Move up and rewrite doc-string.
4603 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4604 (Fwindow_prev): New functions.
727e958e
MR
4605 (Fwindow_frame): Move here from frame.c. Accept any window as
4606 argument.
4607 (Fframe_root_window, Fframe_first_window)
4608 (Fframe_selected_window): Move here from frame.c. Accept frame
4609 or arbitrary window as argument. Update doc-strings.
4610 (Fminibuffer_window): Move up in code.
4611 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4612 (Fset_frame_selected_window): Move here from frame.c.
4613 Marginal rewrite.
727e958e
MR
4614 (Fselected_window, select_window, Fselect_window): Move up in
4615 code. Minor doc-string fixes.
f230ecc9 4616
4d09bcf6
PE
46172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4618
4619 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4620 Do not assume that spare memory exists; that assumption is valid
4621 only if SYSTEM_MALLOC.
4622 (LARGE_REQUEST): New macro, so that the issue of large requests
4623 is separated from the issue of spare memory.
4624
810928a2
AS
46252011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4626
172418ad
AS
4627 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4628 format. (Bug#8806)
4629
43f862f7
AS
4630 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4631
810928a2
AS
4632 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4633 before statements.
4634
a059fe24
JD
46352011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4636
4637 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4638
4639 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4640
4641 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4642 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4643
989bf368
JB
46442011-06-05 Juanma Barranquero <lekktu@gmail.com>
4645
4646 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4647
4b80f674
CY
46482011-06-04 Chong Yidong <cyd@stupidchicken.com>
4649
4650 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4651 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4652 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4653 New error handlers.
4b80f674
CY
4654 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4655 Obey Vx_select_enable_clipboard_manager. Catch errors in
4656 x_clipboard_manager_save (Bug#8779).
4657 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4658 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4659
99a33b77 46602011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4661
4662 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4663
99a33b77 46642011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4665
4666 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4667 in the current matrix if keep_current_p is non-zero.
4668
8264569d
EZ
46692011-06-04 Eli Zaretskii <eliz@gnu.org>
4670
4671 * bidi.c (bidi_level_of_next_char): Fix last change.
4672
57f97249
EZ
46732011-06-03 Eli Zaretskii <eliz@gnu.org>
4674
fec2107c 4675 Support bidi reordering of text covered by display properties.
57f97249 4676
fec2107c
EZ
4677 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4678 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4679 (bidi_cache_search, bidi_cache_iterator_state)
4680 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4681 (bidi_level_of_next_char, bidi_move_to_visually_next):
4682 Support character positions inside a run of characters covered by a
fec2107c
EZ
4683 display string.
4684 (bidi_paragraph_init, bidi_resolve_explicit_1)
4685 (bidi_level_of_next_char): Call bidi_fetch_char and
4686 bidi_fetch_char_advance instead of FETCH_CHAR and
4687 FETCH_CHAR_ADVANCE.
4688 (bidi_init_it): Initialize new members.
4689 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4690 definitions.
4691 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4692 instead of using explicit *_CHAR codes.
d6d100dd
SM
4693 (bidi_resolve_explicit, bidi_resolve_weak):
4694 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4695 bidirectional text is supported only in multibyte buffers.
4696 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4697 it to initialize the frame_window_p member of struct bidi_it.
4698 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4699 (bidi_resolve_explicit, bidi_resolve_weak)
4700 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4701 bidi_it->nchars is non-positive.
4702 (bidi_level_of_next_char): Don't try to lookup the cache for the
4703 next/previous character if nothing is cached there yet, or if we
4704 were just reseat()'ed to a new position.
c40e2fb2 4705
0e14fe90
EZ
4706 * xdisp.c (set_cursor_from_row): Set start and stop points
4707 according to the row's direction when priming the loop that looks
4708 for the glyph on which to display cursor.
4709 (single_display_spec_intangible_p): Function deleted.
4710 (display_prop_intangible_p): Reimplement to call
4711 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4712 Accept 3 additional arguments needed by handle_display_spec.
4713 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4714 values: lists, `(when COND...)' forms, etc.
4715 (single_display_spec_string_p): Support property values that are
4716 lists with the argument STRING its top-level element.
4717 (display_prop_string_p): Fix the condition for processing a
4718 property that is a list to be consistent with handle_display_spec.
fec2107c 4719 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4720 last portion of handle_display_prop.
4721 (compute_display_string_pos): Accept additional argument
4722 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4723 value of a `display' property is a "replacing spec".
4724 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4725 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4726 the display property, but just return a value indicating whether
4727 the display property will replace the characters it covers.
4728 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4729 frame_window_p members of struct bidi_it.
d6d100dd
SM
4730 (compute_display_string_pos, compute_display_string_end):
4731 New functions.
fec2107c
EZ
4732 (push_it): Accept second argument POSITION, where pop_it should
4733 jump to continue iteration.
4734 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4735
fec2107c
EZ
4736 * keyboard.c (adjust_point_for_property): Adjust the call to
4737 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4738
4739 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4740 (bidi_init_it): Update prototypes.
4741 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4742 (compute_display_string_pos, compute_display_string_end):
4743 Declare prototypes.
fec2107c
EZ
4744 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4745 EMACS_INT.
fc6f18ce 4746
40087514 47472011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4748
57f53182
PE
4749 Malloc failure behavior now depends on size of allocation.
4750 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4751 * lisp.h: Change signatures accordingly.
4752 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4753 All callers changed. (Bug#8762)
4754
4755 * gnutls.c: Use Emacs's memory allocators.
4756 Without this change, the gnutls library would invoke malloc etc.
4757 directly, which causes problems on non-SYNC_INPUT hosts, and which
4758 runs afoul of improving memory_full behavior. (Bug#8761)
4759 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4760 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4761 xfree instead of the default malloc, realloc, free.
4762 (Fgnutls_boot): No need to check for memory allocation failure,
4763 since xmalloc does that for us.
4764
ac32cd99 4765 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4766 * category.c (hash_get_category_set):
4767 * ccl.c (ccl_driver):
4768 * charset.c (Fdefine_charset_internal):
4769 * charset.h (struct charset.hash_index):
4770 * composite.c (get_composition_id, gstring_lookup_cache)
4771 (composition_gstring_put_cache):
4772 * composite.h (struct composition.hash_index):
4773 * dispextern.h (struct image.hash):
4774 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4775 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4776 (hashfn_equal, hashfn_user_defined, make_hash_table)
4777 (maybe_resize_hash_table, hash_lookup, hash_put)
4778 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4779 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4780 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4781 * image.c (make_image, search_image_cache, lookup_image)
4782 (xpm_put_color_table_h):
4783 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4784 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4785 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4786 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4787 * alloc.c (allocate_vectorlike):
4788 Check for overflow in vector size calculations.
4789 * ccl.c (ccl_driver):
4790 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4791 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4792 need to be updated by these changes.
40087514
PE
4793 * fns.c (make_hash_table, maybe_resize_hash_table):
4794 Check for integer overflow with large hash tables.
0de4bb68
PE
4795 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4796 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4797 (SXHASH_REDUCE): New macro.
4798 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4799 Use it instead of discarding useful hash info with large hash values.
4800 (sxhash_float): New function.
4801 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4802 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4803 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4804 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4805 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4806 Adjust signatures to match updated version of code.
4807 (consing_since_gc): Now EMACS_INT, since a single hash table can
4808 use more than INT_MAX bytes.
4809
698d32e2
DN
48102011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4811
4812 Make it possible to build with GCC-4.6+ -O2 -flto.
4813
4814 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4815
fd6fa53f
SM
48162011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4817
4818 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4819 Call minibuffer-inactive-mode.
4820
864db017
JB
48212011-05-31 Juanma Barranquero <lekktu@gmail.com>
4822
4823 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4824 Update dependencies.
4825
2ad0baf4
DN
48262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4827
4828 * data.c (init_data): Remove code for UTS, this system is not
4829 supported anymore.
4830
4fcc2638
DN
48312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4832
4833 Don't force ./temacs to start in terminal mode.
4834
4835 * frame.c (make_initial_frame): Initialize faces in all cases, not
4836 only when CANNOT_DUMP is defined.
4837 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4838
c56e0fd5
DN
48392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4840
4841 * dispnew.c (add_window_display_history): Use const for the string
4842 pointer. Remove declaration, not needed.
4843
333d54da 48442011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4845
55d4c1b2 4846 Use 'inline', not 'INLINE'.
333d54da 4847 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4848 * alloc.c, fontset.c (INLINE): Remove.
4849 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4850 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4851 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4852 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4853 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4854
738db178
DN
48552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4856
4857 Make it possible to run ./temacs.
4858
4859 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4860 syms_of_callproc does the same thing. Remove test for
4861 "initialized", do it in the caller.
4862 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4863
620c53a6
SM
48642011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4865
4866 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4867 (read_minibuf): Use get_minibuffer.
4868 (syms_of_minibuf): Use DEFSYM.
4869 (Qmetadata): New var.
4870 * data.c (Qbuffer): Don't make it static.
4871 (syms_of_data): Use DEFSYM.
4872
e003a292
PE
48732011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4874
4875 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4876 (CCL_CODE_MIN): New macro.
4877
ed008a6d
PE
48782011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4879
3687c2ef
PE
4880 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4881
ed008a6d
PE
4882 * eval.c (Qdebug): Now static.
4883 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4884 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4885 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4886
d66c4c7c
CY
48872011-05-29 Chong Yidong <cyd@stupidchicken.com>
4888
4889 * image.c: Various fixes to ImageMagick code comments.
4890 (Fimagemagick_types): Doc fix.
4891
5fbc2025
PE
48922011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4893
0196f88a
PE
4894 Minor fixes prompted by GCC 4.6.0 warnings.
4895
4896 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4897
5fbc2025
PE
4898 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4899 (x_clipboard_manager_save_all): Move extern decl to ...
4900 * xterm.h: ... here, so that it can be checked for consistency.
4901
1dd3c2d9
CY
49022011-05-29 Chong Yidong <cyd@stupidchicken.com>
4903
4904 * xselect.c (x_clipboard_manager_save_frame)
4905 (x_clipboard_manager_save_all): New functions.
4906 (Fx_clipboard_manager_save): Lisp function deleted.
4907
4908 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4909 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4910
4911 * xterm.h: Update prototype.
4912
5ba6571d
WX
49132011-05-28 William Xu <william.xwl@gmail.com>
4914
4915 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4916 exiting (Bug#8239).
4917
3eaff834
JM
49182011-05-28 Jim Meyering <meyering@redhat.com>
4919
e1900994 4920 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4921 * fns.c (to_uchar): Define.
4922 (crypto_hash_function): Use it to convert some newly-signed
4923 variables to unsigned, to avoid sign-extension bugs. For example,
4924 without this change, (md5 "truc") would evaluate to
4925 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4926 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4927 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4928
0f6990a7
PE
49292011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4930
4931 Integer overflow fixes.
c8a9ca5a 4932
08686060
PE
4933 * dbusbind.c: Serial number integer overflow fixes.
4934 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4935 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4936 to hold a serial number that is too large for a fixnum.
4937 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4938 Check for serial numbers out of range. Decode any serial number
59568bf0 4939 that was so large that it became a float. (Bug#8722)
08686060 4940
2d1fc3c7
PE
4941 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4942 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4943 Use XFASTINT rather than XUINT when numbers are nonnegative.
4944 (xd_append_arg, Fdbus_method_return_internal):
4945 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4946 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4947 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4948 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4949 (Bug#8722)
2d1fc3c7 4950
c8a9ca5a
PE
4951 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4952
519e1d69
PE
4953 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4954
30569699
PE
4955 ccl: add integer overflow checks
4956 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4957 (IN_INT_RANGE): New macros.
4958 (ccl_driver): Use them to check for integer overflow when
4959 decoding a CCL program. Many of the new checks are whether XINT (x)
4960 fits in int; it doesn't always, on 64-bit hosts. The new version
4961 doesn't catch all possible integer overflows, but it's an
847044ea 4962 improvement. (Bug#8719)
30569699 4963
c11285dc
PE
4964 * alloc.c (make_event_array): Use XINT, not XUINT.
4965 There's no need for unsigned here.
4966
fdccd48e
PE
4967 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4968 This follows up to the 2011-05-06 change that substituted uintptr_t
4969 for EMACS_INT. This case wasn't caught back then.
4970
37910ab2
PE
4971 Rework Fformat to avoid integer overflow issues.
4972 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4973 now (part of C89). Include <verify.h>.
4974 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4975 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4976 (Fformat): Avoid the prepass trying to compute sizes; it was only
4977 approximate and thus did not catch overflow reliably. Instead, walk
4978 through the format just once, formatting and computing sizes as we go,
4979 checking for integer overflow at every step, and allocating a larger
4980 buffer as needed. Keep track separately whether the format is
4981 multibyte. Keep only the most-recently calculated precision, rather
4982 than them all. Record whether each argument has been converted to
4983 string. Use EMACS_INT, not int, for byte and char and arg counts.
4984 Support field widths and precisions larger than INT_MAX. Avoid
4985 sprintf's undefined behavior with conversion specifications such as %#d
4986 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4987 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4988 formatting out-of-range floating point numbers with int
9173deec 4989 formats. (Bug#8668)
37910ab2 4990
2e6578fb
PE
4991 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4992
0ae6bdee
PE
4993 * data.c: Avoid integer truncation in expressions involving floats.
4994 * data.c: Include <intprops.h>.
4995 (arith_driver): When there's an integer overflow in an expression
4996 involving floating point, convert the integers to floating point
4997 so that the resulting value does not suffer from catastrophic
4998 integer truncation. For example, on a 64-bit host (* 4
4999 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5000 Do not rely on undefined behavior after integer overflow.
5001
de883a70
PE
5002 merge count_size_as_multibyte, parse_str_to_multibyte
5003 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5004 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5005 Check for integer overflow.
5006 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5007 since it's now a duplicate of the other. This is more of
5008 a character than a buffer op, so better that it's in character.c.
5009 * fns.c, print.c: Adjust to above changes.
5010
2ff916cb
PE
50112011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5012
5013 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5014
f1b54466
PE
50152011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5016
fb1ac845
PE
5017 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5018 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5019 (x_clipboard_manager_save): Now static.
5020 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5021
f1b54466
PE
5022 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5023 (crypto_hash_function): Now static.
5024 Fix pointer signedness problems. Avoid unnecessary initializations.
5025
a9f737ee
CY
50262011-05-27 Chong Yidong <cyd@stupidchicken.com>
5027
5028 * termhooks.h (Vselection_alist): Make it terminal-local.
5029
5030 * terminal.c (create_terminal): Initialize it.
5031
5032 * xselect.c: Support for clipboard managers.
5033 (Vselection_alist): Move to termhooks.h as terminal-local var.
5034 (LOCAL_SELECTION): New macro.
5035 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5036 (symbol_to_x_atom): Remove gratuitous arg.
5037 (x_handle_selection_request, lisp_data_to_selection_data)
5038 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5039 (x_own_selection, x_get_local_selection, x_convert_selection):
5040 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5041 (some_frame_on_display): Delete unused function.
5042 (Fx_own_selection_internal, Fx_get_selection_internal)
5043 (Fx_disown_selection_internal, Fx_selection_owner_p)
5044 (Fx_selection_exists_p): New optional frame arg.
5045 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5046 (x_handle_selection_clear): Don't treat other terminals with the
5047 same keyboard specially. Use the terminal-local Vselection_alist.
5048 (x_clear_frame_selections): Use Frun_hook_with_args.
5049
5050 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5051
5052 * xterm.h: Add support for those atoms.
5053
e067f0c1
CY
50542011-05-26 Chong Yidong <cyd@stupidchicken.com>
5055
5056 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5057 (converted_selections, conversion_fail_tag): New global variables.
5058 (x_selection_request_lisp_error): Free the above.
5059 (x_get_local_selection): Remove unnecessary code.
5060 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5061 of converted selections stored in converted_selections.
5062 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5063 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5064 (x_convert_selection): New function.
5065 (x_handle_selection_event): Simplify.
5066 (x_get_foreign_selection): Don't ignore incoming requests while
5067 waiting for an answer; this will fail when we implement
5068 SAVE_TARGETS, and seems unnecessary anyway.
5069 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5070 (Vx_sent_selection_functions): Doc fix.
5071
0f4aebc0
LL
50722011-05-26 Leo Liu <sdl.web@gmail.com>
5073
5074 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5075
e61124cd
YM
50762011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5077
5078 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5079
5080 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5081 for fringe update if it has periodic bitmap.
ac389d0c 5082 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5083 and fringe_bitmap_periodic_p.
5084
5085 * fringe.c (get_fringe_bitmap_data): New function.
5086 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5087 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5088 row. Mark glyph row for fringe update if periodicity changed.
5089
5090 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5091 for fringe update unless it has periodic bitmap.
5092
f16d9837
KH
50932011-05-25 Kenichi Handa <handa@m17n.org>
5094
5095 * xdisp.c (get_next_display_element): Set correct it->face_id for
5096 a static composition.
5097
e1b90ef6
LL
50982011-05-24 Leo Liu <sdl.web@gmail.com>
5099
5100 * deps.mk (fns.o):
5101 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5102
5103 * fns.c (crypto_hash_function, Fsha1): New function.
5104 (Fmd5): Use crypto_hash_function.
5105 (syms_of_fns): Add Ssha1.
5106
7400048f
PE
51072011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5108
5109 * gnutls.c: Remove unused macros.
5110 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5111 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5112 Remove macros that are defined and never used.
5113 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5114
abb71cf4
CY
51152011-05-22 Chong Yidong <cyd@stupidchicken.com>
5116
5117 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5118 (Fx_get_selection_internal): Minor cleanup.
5119 (Fx_own_selection_internal): Rename arguments for consistency with
5120 select.el.
5121
6307db39
PE
51222011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5123
5124 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5125
f3d4e0a4
CY
51262011-05-22 Chong Yidong <cyd@stupidchicken.com>
5127
5128 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5129
4d8ade89
YM
51302011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5131
5132 * dispnew.c (scrolling_window): Don't exclude the case that the
5133 last enabled row in the desired matrix touches the bottom boundary.
5134
32078c8d
GM
51352011-05-21 Glenn Morris <rgm@gnu.org>
5136
5137 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5138 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5139 and add some more files.
32078c8d 5140
7285dc67
EZ
51412011-05-20 Eli Zaretskii <eliz@gnu.org>
5142
5143 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5144 report_file_error introduced by the change from 2011-05-07.
5145
89d1bd22
PE
51462011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5147
5148 * systime.h (Time): Define only if emacs is defined.
5149 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5150 where the include path doesn't have X11/X.h by default. See
5151 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5152
e23640bb 51532011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5154
5155 * composite.c (find_automatic_composition): Fix previous change.
5156
b9704ad9
GM
51572011-05-20 Glenn Morris <rgm@gnu.org>
5158
5159 * lisp.mk: New file, split from Makefile.in.
5160 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5161 (shortlisp): Remove.
5162 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5163
4a720484
GM
51642011-05-19 Glenn Morris <rgm@gnu.org>
5165
5166 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5167 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5168 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5169 (lisp): Set the order to that of loadup.el.
5170 (shortlisp): Make it a copy of $lisp.
5171 (SOME_MACHINE_LISP): Remove.
5172 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5173 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5174
a28d4396
KH
51752011-05-18 Kenichi Handa <handa@m17n.org>
5176
5177 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5178 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5179 (find_automatic_composition): Mostly rewrite for efficiency.
5180
a2b1fa8e
JB
51812011-05-18 Juanma Barranquero <lekktu@gmail.com>
5182
5183 * makefile.w32-in: Update dependencies.
5184
8e1f5610
CS
51852011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5186
5187 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5188 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5189
7025ee00 51902011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5191
cdfa6eab
PE
5192 Fix some integer overflow issues, such as string length overflow.
5193
06d6db33
PE
5194 * insdel.c (count_size_as_multibyte): Check for string overflow.
5195
2b4560a8
PE
5196 * character.c (lisp_string_width): Check for string overflow.
5197 Use EMACS_INT, not int, for string indexes and lengths; in
5198 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5199 the resulting string length overflows an EMACS_INT; instead,
5200 report a string overflow if no precision given. When checking for
5201 precision exhaustion, use a check that cannot possibly have
5202 integer overflow. (Bug#8675)
5203 * character.h (lisp_string_width): Adjust to new signature.
5204
cb93f9be
PE
5205 * alloc.c (string_overflow): New function.
5206 (Fmake_string): Use it. This doesn't change behavior, but saves
5207 a few bytes and will simplify future changes.
5208 * character.c (string_escape_byte8): Likewise.
5209 * lisp.h (string_overflow): New decl.
5210
1a1f3366
PE
5211 Fixups, following up to the user-interface timestamp change.
5212 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5213 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5214 * msdos.c (mouse_get_pos): Likewise.
5215 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5216 * w32gui.h (Time): Define by including "systime.h" rather than by
5217 declaring it ourselves. (Bug#8664)
5218
d4e3e4d3
PE
5219 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5220 * image.c (clear_image_cache): Likewise.
5221
f6a24d19
PE
5222 * term.c (term_mouse_position): Don't assume time_t wraparound.
5223
08dc5ae6
PE
5224 Be more systematic about user-interface timestamps.
5225 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5226 and sometimes 'EMACS_UINT', to represent these timestamps.
5227 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5228 This makes the code easier to follow, and makes it easier to catch
5229 integer overflow bugs such as Bug#8664.
5230 * frame.c (Fmouse_position, Fmouse_pixel_position):
5231 Use Time, not unsigned long, for user-interface timestamps.
5232 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5233 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5234 * keyboard.h (last_event_timestamp): Likewise.
5235 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5236 * menu.h (xmenu_show): Likewise.
5237 * term.c (term_mouse_position): Likewise.
5238 * termhooks.h (struct input_event.timestamp): Likewise.
5239 (struct terminal.mouse_position_hook): Likewise.
5240 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5241 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5242 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5243 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5244 what it was before.
5245 * menu.h, termhooks.h: Include "systime.h", for Time.
5246
8e55734a
PE
5247 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5248 Don't assume that the difference between two unsigned long values
5249 can fit into an integer. At this point, we know button_down_time
5250 <= event->timestamp, so the difference must be nonnegative, so
5251 there's no need to cast the result if double-click-time is
5252 nonnegative, as it should be; check that it's nonnegative, just in
5253 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5254 apart (about 25 days). (Bug#8664)
8e55734a 5255
841f1b75 5256 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5257 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5258
3e26f69c
PE
5259 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5260 that always fit in int. Use a sentinel instead of a counter, to
5261 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5262 * frame.h (struct frame): Use int for menu_bar_items_used
5263 instead of EMACS_INT, since it always fits in int.
3e26f69c 5264
5cc152c0
PE
5265 * menu.c (grow_menu_items): Check for int overflow.
5266
d89eb65e
PE
5267 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5268
5235bd3e
PE
5269 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5270 Before, the code was not consistent. These values cannot exceed
5271 2**31 - 1 so there's no need to make them unsigned.
5272 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5273 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5274 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5275 as modifiers.
5276 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5277
bc827e23
PE
5278 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5279 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5280 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5281 presumably because the widths might not match.
5282
78eb494e
PE
5283 * window.c (size_window): Avoid needless test at loop start.
5284
04f2d78b
CB
52852011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5286
5287 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5288
d2fc7e3d 52892011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5290
5291 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5292
d2fc7e3d 52932011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5294
5295 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5296 `width' to `bar_area_x' and `bar_area_width', respectively.
5297 (x_scroll_run): Take account of fringe background extension.
5298
04f2d78b
CB
5299 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5300 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5301 `bar_area_width', respectively.
5302 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5303 background extension.
5304
79b70037
GM
53052011-05-10 Jim Meyering <meyering@redhat.com>
5306
5307 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5308
2f142cc5
JB
53092011-05-10 Juanma Barranquero <lekktu@gmail.com>
5310
5311 * image.c (Finit_image_library): Return t for built-in image types,
5312 like pbm and xbm. (Bug#8640)
5313
57679c86
AS
53142011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5315
5316 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5317
888c9e86
EZ
53182011-05-07 Eli Zaretskii <eliz@gnu.org>
5319
b0512a1d
EZ
5320 * w32console.c (Fset_screen_color): Doc fix.
5321 (Fget_screen_color): New function.
5322 (syms_of_ntterm): Defsubr it.
5323
7285dc67
EZ
5324 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5325 unlink the temporary file if Fcall_process didn't create it in the
5326 first place.
5327 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5328 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5329 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5330 cue to call_process_cleanup not to close that handle.
5331
4d3fcc8e
BK
53322011-05-07 Ben Key <bkey76@gmail.com>
5333
5334 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5335 one of two shell specific rules, either bootstrap-temacs-CMD or
5336 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5337 to the previous implementation of the bootstrap-temacs rule.
5338 The bootstrap-temacs-CMD rule is similar to the previous
5339 implementation of the bootstrap-temacs rule except that it
5340 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5341 variable.
5342
5343 These changes, along with some changes to nt/configure.bat,
5344 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5345 earlier fix to add support for --cflags and --ldflags options
5346 that include quotes so that it works whether make uses cmd or
5347 sh as the shell.
5348
b4289b64
MA
53492011-05-06 Michael Albinus <michael.albinus@gmx.de>
5350
5351 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5352 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5353 is a constant.
5354 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5355 a string. Handle both cases.
5356 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5357 (Fdbus_register_method): Use Qinvalid_function.
5358
af4c0e28
JB
53592011-05-06 Juanma Barranquero <lekktu@gmail.com>
5360
5361 * makefile.w32-in: Update dependencies.
5362 (LISP_H): Add inttypes.h and stdin.h.
5363 (PROCESS_H): Add unistd.h.
5364
c51453d9
EZ
53652011-05-06 Eli Zaretskii <eliz@gnu.org>
5366
5367 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5368 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5369
8ff0ac3c 53702011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5371
4c4b566b
PE
5372 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5373
aab2b9b5
PE
5374 * term.c (vfatal): Remove stray call to va_end.
5375 It's not needed and the C Standard doesn't allow it here anyway.
5376
c378da0b
PE
5377 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5378 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5379
288b08c7
PE
5380 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5381 bytes.
5382
e3601888
PE
5383 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5384
db6c0e74
PE
5385 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5386
dd5963ea
PE
5387 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5388
88c9450f
PE
5389 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5390
2f9442b8
PE
5391 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5392
c032b5f8
PE
5393 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5394 * charset.c (Fdefine_charset_internal): Don't initialize
5395 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5396 32-bit int (Bug#8600).
a108c10b
PE
5397
5398 * lread.c (read_integer): Be more consistent with string-to-number.
5399 Use string_to_number to do the actual conversion; this avoids
5400 rounding errors and fixes some other screwups. Without this fix,
5401 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5402 (digit_to_number): Move earlier, for benefit of read_integer.
5403 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5404 not a digit in any supported base. (Bug#8602)
a108c10b 5405
ad5f9eea
PE
5406 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5407
aec1708a
PE
5408 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5409 to match comment at start of function. This also removes a
5410 GCC warning about overflow in a 32+64-bit port.
5411
47be4ab5
PE
5412 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5413
371cac43
PE
5414 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5415 Reported by Stefan Monnier in
5416 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5417 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5418 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5419
d01a7826
PE
5420 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5421 (EMACS_UINTPTR): Likewise, with uintptr_t.
5422
7fd47d5c
PE
5423 * lisp.h: Prefer 64-bit EMACS_INT if available.
5424 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5425 on 32-bit hosts that have 64-bit int, so that they can access
5426 large files.
122b0c86
PE
5427 However, temporarily disable this change unless the temporary
5428 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5429
8727937b
PE
5430 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5431
8ac068ac
PE
5432 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5433 This removes an assumption that EMACS_INT and long are the same
5434 width as pointers. The assumption is true for Emacs porting targets
5435 now, but we want to make other targets possible.
5436 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5437 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5438 In the rest of the code, change types of integers that hold casted
5439 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5440 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5441 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5442 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5443 No need to cast type when ORing.
5444 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5445 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5446 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5447 assume EMACS_INT is the same width as char *.
5448 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5449 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5450 Remove no-longer-needed casts.
5451 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5452 (xg_tool_bar_help_callback, xg_make_tool_item):
5453 Use EMACS_INTPTR to hold an integer
5454 that will be cast to void *; this can avoid a GCC warning
5455 if EMACS_INT is not the same width as void *.
5456 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5457 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5458 (current_message_1, set_message_1):
5459 Use a local to convert to proper width without a cast.
5460 * xmenu.c (dialog_selection_callback): Likewise.
5461
ede49d71
PE
5462 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5463 Also, don't assume VALBITS / RAND_BITS is less than 5,
5464 and don't rely on undefined behavior when shifting a 1 left into
5465 the sign bit.
5466 * lisp.h (get_random): Change signature to match.
5467
2f30ecd0
PE
5468 * lread.c (hash_string): Use size_t, not int, for hash computation.
5469 Normally we prefer signed values; but hashing is special, because
5470 it's better to use unsigned division on hash table sizes so that
5471 the remainder is nonnegative. Also, size_t is the natural width
5472 for hashing into memory. The previous code used 'int', which doesn't
5473 retain enough info to hash well into very large tables.
5474 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5475
2a866e7b
PE
5476 * dbusbind.c: Don't possibly lose pointer info when converting.
5477 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5478 Use XPNTR rather than XHASH, so that the high-order bits of
5479 the pointer aren't lost when converting through void *.
5480
51639eac
PE
5481 * eval.c (Fautoload): Don't double-shift a pointer.
5482
92394119
PE
5483 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5484
dbdb9a7c
JB
54852011-05-06 Juanma Barranquero <lekktu@gmail.com>
5486
5487 * gnutls.c (DEF_GNUTLS_FN):
5488 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5489
db7a0b4f
AS
54902011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5491
5492 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5493 marker. (Bug#8610)
5494
f7ff1b0f 54952011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5496
5497 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5498 New version that can reserve upto 2GB of heap space.
5499
f7ff1b0f 55002011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5501
5502 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5503
639c109b
TZ
55042011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5505
5506 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5507 `gnutls_certificate_set_x509_key_file'.
5508
d2127135
JB
55092011-05-05 Juanma Barranquero <lekktu@gmail.com>
5510
5511 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5512 Update dependencies.
5513
e968f4f3
JB
55142011-05-04 Juanma Barranquero <lekktu@gmail.com>
5515
5516 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5517 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5518 Remove unused parameter `fildes'.
5519 * process.c (read_process_output, send_process): Don't pass it.
5520
84d358f0
JB
55212011-05-04 Juanma Barranquero <lekktu@gmail.com>
5522
5523 Fix previous change: the library cache is defined in w32.c.
5524 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5525 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5526
0898ca10
JB
55272011-05-04 Juanma Barranquero <lekktu@gmail.com>
5528
5529 Implement dynamic loading of GnuTLS on Windows.
5530
5531 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5532 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5533 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5534 Declare.
5535
5536 * gnutls.c (Qgnutls_dll): Define.
5537 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5538 (gnutls_*): Declare function pointers.
5539 (init_gnutls_functions): New function to initialize function pointers.
5540 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5541 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5542 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5543 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5544 (emacs_gnutls_write, emacs_gnutls_read)
5545 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5546 (Fgnutls_available_p): New function.
5547 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5548 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5549 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5550
5551 * image.c: Include w32.h.
5552 (Vimage_type_cache): Delete.
5553 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5554 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5555 (w32_delayed_load): Move to w32.c.
5556
5557 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5558
5559 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5560 (w32_delayed_load): Move from image.c. When loading a library, record
5561 its filename in the :loaded-from property of the library id.
5562 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5563 Initialize and staticpro them.
5564 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5565
5566 * process.c: Include lisp.h before w32.h, not after.
5567 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5568 instead of gnutls_record_check_pending.
5569
5570 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5571
ff4de4aa
TZ
55722011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5573
5574 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5575 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5576 as passed in.
5577
abe95abb
JD
55782011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5579
5580 * xterm.c (x_set_frame_alpha): Do not set property on anything
5581 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5582
e16e55d4
JB
55832011-05-02 Juanma Barranquero <lekktu@gmail.com>
5584
5585 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5586
bafcf6a5
JB
55872011-05-02 Juanma Barranquero <lekktu@gmail.com>
5588
5589 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5590 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5591 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5592 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5593 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5594 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5595 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5596 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5597 (Qgnutls_bootprop_callbacks_verify): Make static.
5598
e7a6747f
AS
55992011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5600
19ed11ba
AS
5601 * callproc.c: Indentation fixup.
5602
e7a6747f 5603 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5604 (wait_for_termination, interruptible_wait_for_termination):
5605 Move after wait_for_termination_1.
e7a6747f 5606
1ef14cb4
LMI
56072011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5608
5609 * sysdep.c (interruptible_wait_for_termination): New function
5610 which is like wait_for_termination, but allows keyboard
5611 interruptions.
5612
5613 * callproc.c (Fcall_process): Add (:file "file") as an option for
5614 the STDOUT buffer.
5615 (Fcall_process_region): Ditto.
5616
330d880c
EZ
56172011-04-30 Eli Zaretskii <eliz@gnu.org>
5618
8db90b73
EZ
5619 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5620 rather than `XVECTOR (FOO)->size'.
5621
330d880c
EZ
5622 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5623 inttypes.h, as a gnulib replacement is used if it not available in
5624 system headers.
5625
15cbd324
EZ
56262011-04-21 Eli Zaretskii <eliz@gnu.org>
5627
5628 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5629 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5630 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5631
5632 * coding.c (coding_alloc_by_realloc): Error out if destination
5633 will grow beyond MOST_POSITIVE_FIXNUM.
5634 (decode_coding_emacs_mule): Abort if there isn't enough place in
5635 charbuf for the composition carryover bytes. Reserve an extra
5636 space for up to 2 characters produced in a loop.
5637 (decode_coding_iso_2022): Abort if there isn't enough place in
5638 charbuf for the composition carryover bytes.
5639
56402011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5641
ae940cca
EZ
5642 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5643 aborting when %lld or %lll format is passed.
5644 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5645 %llo or %llx format is passed. (Bug#8545)
5646
03ab8921
EZ
5647 * window.c (window_scroll_line_based): Use a marker instead of
5648 simple variables to record original value of point. (Bug#7952)
5649
afda1437
EZ
5650 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5651 produced by %s or %c overflows available buffer space. (Bug#8545)
5652
f76dee0c
PE
56532011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5654
5655 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5656 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5657
fdc5744d
JB
56582011-04-28 Juanma Barranquero <lekktu@gmail.com>
5659
5660 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5661
638f053a
JB
56622011-04-28 Juanma Barranquero <lekktu@gmail.com>
5663
5664 * keyboard.c (Qdelayed_warnings_hook): Define.
5665 (command_loop_1): Run `delayed-warnings-hook'
5666 if Vdelayed_warnings_list is non-nil.
5667 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5668 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5669
d178f871
EZ
56702011-04-28 Eli Zaretskii <eliz@gnu.org>
5671
5672 * doprnt.c (doprnt): Don't return value smaller than the buffer
5673 size if the message was truncated. (Bug#8545).
5674
b124fd93
JB
56752011-04-28 Juanma Barranquero <lekktu@gmail.com>
5676
5677 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5678 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5679
e810457d
PE
56802011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5681
5682 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5683
ea51cceb
JB
56842011-04-27 Juanma Barranquero <lekktu@gmail.com>
5685
5686 * makefile.w32-in: Update dependencies.
5687
94dcfacf
EZ
56882011-04-27 Eli Zaretskii <eliz@gnu.org>
5689
5690 Improve `doprnt' and its usage. (Bug#8545)
5691 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5692 `format_end'. Remove support for %l as a conversion specifier.
5693 Don't use xrealloc. Improve diagnostics when the %l size modifier
5694 is used. Update the commentary.
5695
5696 * eval.c (verror): Simplify calculation of size_t.
5697
5698 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5699 messages.
5700
f61f41d7
PE
57012011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5702
5703 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5704 change.
5705
96fb4434
PE
57062011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5707
5708 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5709 This makes this file independent of the recent pseudovector change.
5710
671875da 57112011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5712
69e9b5a3
PE
5713 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5714
b5f869a7 5715 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5716 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5717 Remove unused local.
c8926152 5718 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5719
841a1577 5720 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5721 GCC 4.6.0 optimizes based on type-based alias analysis.
5722 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5723 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5724 != &v->size, and therefore "v->size = 1; b->size = 2; return
5725 v->size;" must therefore return 1. This assumption is incorrect
5726 for Emacs, since it type-puns struct Lisp_Vector * with many other
5727 types. To fix this problem, this patch adds a new type struct
f904488f 5728 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5729 and pseudovectors, and helps optimizing compilers not get fooled
5730 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5731 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5732 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5733 the size member.
eab3844f
PE
5734 (XSETPVECTYPE): Rewrite in terms of new macro.
5735 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5736 This is a bit clearer, and further avoids the possibility of
5737 undesirable aliasing.
5738 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5739 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5740 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5741 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5742 (ASIZE): Now uses header.size rather than size.
5743 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5744 to avoid the hassle of writing XVECTOR (foo)->header.size.
5745 (struct vectorlike_header): New type.
eab3844f
PE
5746 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5747 object, to help avoid aliasing.
5748 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5749 (SUBRP): Likewise, since Lisp_Subr is a special case.
5750 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5751 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5752 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5753 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5754 changed to be "header.size" and "header.next".
5755 * buffer.h (struct buffer): Likewise.
5756 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5757 * frame.h (struct frame): Likewise.
5758 * process.h (struct Lisp_Process): Likewise.
5759 * termhooks.h (struct terminal): Likewise.
5760 * window.c (struct save_window_data, struct saved_window): Likewise.
5761 * window.h (struct window): Likewise.
5762 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5763 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5764 * buffer.c (init_buffer_once): Likewise.
5765 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5766 special case.
5767 * process.c (Fformat_network_address): Use local var for size,
5768 for brevity.
5769
0df1eac5
PE
5770 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5771
847ab9d1 5772 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5773 * data.c (atof): Remove decl; no longer used or needed.
5774 (digit_to_number): Move to lread.c.
5775 (Fstring_to_number): Use new string_to_number function, to be
5776 consistent with how the Lisp reader treats infinities and NaNs.
5777 Do not assume that floating-point numbers represent EMACS_INT
5778 without losing information; this is not true on most 64-bit hosts.
5779 Avoid double-rounding errors, by insisting on integers when
5780 parsing non-base-10 numbers, as the documentation specifies.
5781 * lisp.h (string_to_number): New decl, replacing ...
5782 (isfloat_string): Remove.
bc0a5c13 5783 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5784 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5785 appears to have been a coding error. Similarly, do not accept
5786 strings like +-1e0 as floating point numbers. Do not report
5787 overflow for integer overflows unless the base is not 10 which
5788 means we have no simple and reliable way to continue.
5789 Break out the floating-point parsing into a new
5790 function string_to_number, so that Fstring_to_number parses
5791 floating point numbers consistently with the Lisp reader.
04f2d78b 5792 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5793 (E_CHAR, EXP_INT): Remove, replacing with ...
5794 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5795 (string_to_number): New function, replacing isfloat_string.
5796 This function checks for valid syntax and produces the resulting
5797 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5798 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5799 so that overflow for non-base-10 numbers is reported only when
5800 there's no portable and simple way to convert to floating point.
452f4150 5801
67769ffc
PE
5802 * textprop.c (set_text_properties_1): Rewrite for clarity,
5803 and to avoid GCC warning about integer overflow.
5804
c20db43f
PE
5805 * intervals.h (struct interval): Use EMACS_INT for members
5806 where EMACS_UINT might cause problems. See
5807 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5808 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5809 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5810 All uses changed.
37aa2f85
PE
5811 (offset_intervals): Tell GCC not to worry about length overflow
5812 when negating a negative length.
c20db43f 5813
2538aa2f
PE
5814 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5815 (overrun_check_free): Likewise.
5816
f2d3008d
PE
5817 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5818 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5819 word size.
5820
ec8df744
PE
5821 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5822 (gnutls_make_error): Rename local to avoid shadowing.
5823 (gnutls_emacs_global_deinit): ifdef out; not used.
5824 (Fgnutls_boot): Use const for pointer to readonly storage.
5825 Comment out unused local. Fix pointer signedness problems.
5826
640ee02d
PE
5827 * lread.c (openp): Don't stuff size_t into an 'int'.
5828 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5829 about possible signed overflow.
5830
6048fb2a
PE
5831 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5832 (GDK_KEY_g): Don't define if already defined.
5833 (xg_prepare_tooltip): Avoid pointer signedness problem.
5834 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5835
fa3c87e1
PE
5836 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5837 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5838
2172544b
PE
5839 * xfns.c (Fx_window_property): Simplify a bit,
5840 to make a bit faster and to avoid GCC 4.6.0 warning.
5841 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5842
9b821a21
PE
5843 * fns.c (internal_equal): Don't assume size_t fits in int.
5844
3c616cfa
PE
5845 * alloc.c (compact_small_strings): Tighten assertion a little.
5846
c2982e87
PE
5847 Replace pEd with more-general pI, and fix some printf arg casts.
5848 * lisp.h (pI): New macro, generalizing old pEd macro to other
5849 conversion specifiers. For example, use "...%"pI"d..." rather
5850 than "...%"pEd"...".
5851 (pEd): Remove. All uses replaced with similar uses of pI.
5852 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5853 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5854 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5855 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5856 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5857 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5858 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5859 64-bit hosts.
5860 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5861 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5862 * print.c (safe_debug_print, print_object): Likewise.
5863 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5864 to int.
6f04d126
PE
5865 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5866 avoiding the 0 flag, which is not portable.
c2982e87
PE
5867 * process.c (Fmake_network_process): Use pI to avoid cast.
5868 * region-cache.c (pp_cache): Likewise.
5869 * xdisp.c (decode_mode_spec): Likewise.
5870 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5871 behavior on 64-bit hosts with printf arg.
6f04d126 5872 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5873 (x_stop_queuing_selection_requests): Likewise.
5874 (x_get_window_property): Don't truncate byte count to an 'int'
5875 when tracing.
0b432f21 5876
5e073ec7
PE
5877 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5878 here, since it parses constructs like leading '-' and spaces,
5879 which are not wanted; and it overflows with large numbers.
5880 Instead, simply match F[0-9]+, which is what is wanted anyway.
5881
36372bf9
PE
5882 * alloc.c: Remove unportable assumptions about struct layout.
5883 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5884 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5885 (allocate_vectorlike, make_pure_vector): Use the new macros,
5886 plus offsetof, to remove unportable assumptions about struct layout.
5887 These assumptions hold on all porting targets that I know of, but
5888 they are not guaranteed, they're easy to remove, and removing them
5889 makes further changes easier.
5890
0b432f21
PE
5891 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5892 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5893 (string_overrun_cookie): Now const. Use initializers that
5894 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5895 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5896 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5897 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5898 multiple of sizeof (EMACS_INT); it need not be, if
5899 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5900 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5901
895009e1
JB
59022011-04-26 Juanma Barranquero <lekktu@gmail.com>
5903
5904 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5905
6a7a1b0b
TZ
59062011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5907
5908 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5909 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5910 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5911
841a1577 59122011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5913
5914 * lisp.h (Qdebug): List symbol.
895009e1 5915 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5916 * keyboard.c (debug-on-event): New variable.
5917 (handle_user_signal): Break into debugger when debug-on-event
5918 matches the current signal symbol.
5919
f2d3ba6f
DN
59202011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5921
5922 * alloc.c (check_sblock, check_string_bytes)
5923 (check_string_free_list): Convert to standard C.
5924
42ce4c63
TZ
59252011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5926
5927 * w32.c (emacs_gnutls_push): Fix typo.
5928
825cd63c
EZ
59292011-04-25 Eli Zaretskii <eliz@gnu.org>
5930
fb11d64d
EZ
5931 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5932 "cast to pointer from integer of different size".
5933
825cd63c
EZ
5934 Improve doprnt and its use in verror. (Bug#8545)
5935 * doprnt.c (doprnt): Document the set of format control sequences
5936 supported by the function. Use SAFE_ALLOCA instead of always
5937 using `alloca'.
5938
5939 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5940 is one byte too soon. Don't use xrealloc; instead xfree and
5941 xmalloc anew.
5942
e061a11b
TZ
59432011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5944
5945 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5946 callbacks stage.
5947
5948 * gnutls.c: Renamed global_initialized to
5949 gnutls_global_initialized. Added internals for the
5950 :verify-hostname-error, :verify-error, and :verify-flags
5951 parameters of `gnutls-boot' and documented those parameters in the
5952 docstring. Start callback support.
9173deec
JB
5953 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5954 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5955 on error. Return error code.
e061a11b
TZ
5956 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5957 (emacs_gnutls_read): Likewise.
5958 (Fgnutls_boot): Return handshake error code.
5959 (emacs_gnutls_handle_error): New function.
5960 (wsaerror_to_errno): Likewise.
5961
5962 * w32.h (emacs_gnutls_pull): Add prototype.
5963 (emacs_gnutls_push): Likewise.
5964
5965 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5966 (emacs_gnutls_push): Likewise.
5967
59682011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5969
5970 * process.c (wait_reading_process_output): Check if GnuTLS
5971 buffered some data internally if no FDs are set for TLS
5972 connections.
5973
5974 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5975 (LIBS): Link to USER_LIBS.
5976 ($(BLD)/gnutls.$(0)): New target.
5977
fa6996bc
EZ
59782011-04-24 Eli Zaretskii <eliz@gnu.org>
5979
eb35682e
EZ
5980 * xdisp.c (handle_single_display_spec): Rename the
5981 display_replaced_before_p argument into display_replaced_p, to
5982 make it consistent with the commentary. Fix typos in the
5983 commentary.
5984
e2ad650c
EZ
5985 * textprop.c (syms_of_textprop): Remove dead code.
5986 (copy_text_properties): Delete obsolete commentary about an
5987 interface that was deleted long ago. Fix typos in the description
5988 of arguments.
5989
1b2de274
EZ
5990 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5991 to changes in oldXMenu/XMenu.h from 2011-04-16.
5992 <menu_help_message, prev_menu_help_message>: Constify.
5993 (IT_menu_make_room): menu->help_text is now `const char **';
5994 adjust.
5995
5996 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5997 to changes in oldXMenu/XMenu.h from 2011-04-16.
5998 (struct XMenu): Declare `help_text' `const char **'.
5999
6000 * xfaces.c <Qunspecified>: Make extern again.
6001
6002 * syntax.c: Include sys/types.h before including regex.h, as
6003 required by Posix.
6004
762b15be
EZ
6005 * doc.c (get_doc_string): Improve the format passed to `error'.
6006
6007 * doprnt.c (doprnt): Improve commentary.
6008
6009 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6010
6011 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6012 them with etags.
6013
f1052e5d
EZ
6014 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6015 changes in globals.h immediately force recompilation.
762b15be
EZ
6016 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6017 $(CURDIR)/s/ms-w32.h.
6018 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6019
fa6996bc
EZ
6020 * character.c (Fchar_direction): Function deleted.
6021 (syms_of_character): Don't defsubr it.
6022 <char-direction-table>: Deleted.
6023
e6c3da20
EZ
60242011-04-23 Eli Zaretskii <eliz@gnu.org>
6025
6026 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6027 * doprnt.c: Include limits.h.
6028 (SIZE_MAX): New macro.
04f2d78b
CB
6029 (doprnt): Return a size_t value. 2nd arg is now size_t.
6030 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6031 Improve overflow protection. Support `l' modifier for integer
6032 conversions. Support %l conversion. Don't assume an EMACS_INT
6033 argument for integer conversions and for %c.
6034
6035 * lisp.h (doprnt): Restore prototype.
6036
6037 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6038 $(SRC)/character.h.
6039
6040 * Makefile.in (base_obj): Add back doprnt.o.
6041
6042 * deps.mk (doprnt.o): Add back prerequisites.
6043 (callint.o): Depend on character.h.
6044
6045 * eval.c (internal_lisp_condition_case): Include the handler
6046 representation in the error message.
6047 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6048 when breaking from the loop.
6049
6050 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6051
6052 * callint.c (Fcall_interactively): When displaying error message
6053 about invalid control letter, pass the character's codepoint, not
6054 a pointer to its multibyte form. Improve display of the character
6055 in octal and display also its hex code.
6056
6057 * character.c (char_string): Use %x to display the (unsigned)
6058 codepoint of an invalid character, to avoid displaying a bogus
6059 negative value.
6060
6061 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6062 `error', not SYMBOL_NAME itself.
6063
6064 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6065 character arguments to `error'.
6066
6067 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6068 to `error' in error message about FINAL_CHAR argument. Make sure
6069 FINAL_CHAR is a character, and use %c when it is passed as
6070 argument to `error'.
6071
4ffd0d6b 60722011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6073
6074 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6075
6076 * w32.c: Include <time.h>.
6077 (sys_localtime): New function.
6078
4ffd0d6b 60792011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6080
6081 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6082
4ffd0d6b 6083 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6084
4ffd0d6b 60852011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6086
4ffd0d6b
GM
6087 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6088 zombies (Bug#8467).
aac0c6e3 6089
04c56954
EZ
60902011-04-19 Eli Zaretskii <eliz@gnu.org>
6091
6092 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6093 gl_state.e_property when gl_state.object is Qt.
6094
6095 * insdel.c (make_gap_larger): Remove limitation of buffer size
6096 to <= INT_MAX.
6097
16a43933
CY
60982011-04-18 Chong Yidong <cyd@stupidchicken.com>
6099
6100 * xdisp.c (lookup_glyphless_char_display)
6101 (produce_glyphless_glyph): Handle cons cell entry in
6102 glyphless-char-display.
6103 (Vglyphless_char_display): Document it.
6104
6105 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6106 glyphless-char-display.
6107
4581706e
CY
61082011-04-17 Chong Yidong <cyd@stupidchicken.com>
6109
6110 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6111
6112 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6113
6114 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6115 definition for no-X builds.
6116
4887c6e2 61172011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6118
fd35b6f9
PE
6119 Static checks with GCC 4.6.0 and non-default toolkits.
6120
5c1ccb01
PE
6121 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6122
006c5daa
PE
6123 * process.c (keyboard_bit_set): Define only if SIGIO.
6124 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6125 (send_process): Repair possible setjmp clobbering.
6126
efc736d3
PE
6127 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6128
4e2fe2e6
PE
6129 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6130
f97334a2
PE
6131 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6132
4e75f29d
PE
6133 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6134 Define only if needed.
6135
90efadd1
PE
6136 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6137 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6138 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6139
3c647824
PE
6140 * dispextern.h (struct redisplay_interface): Rename param
6141 to avoid shadowing.
e264f262 6142 * termhooks.h (struct terminal): Likewise.
761383f4 6143 * xterm.c (xembed_send_message): Likewise.
3c647824 6144
b58c5c4a
PE
6145 * insdel.c (make_gap_smaller): Define only if
6146 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6147
cad59032
PE
6148 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6149 it.
6150
c339dc2e
PE
6151 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6152 so that we aren't warned about unused symbols.
6153
91a3e27b
PE
6154 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6155
399c71d3 6156 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6157
8ffc96f5
PE
6158 * xfns.c (x_real_positions): Mark locals as initialized.
6159
eef9bc79
PE
6160 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6161
098db9dd
PE
6162 * xterm.c: Fix problems found by static analysis with other toolkits.
6163 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6164 (x_dispatch_event): Declare static if USE_GTK, and
6165 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6166 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6167 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6168 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6169 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6170
eb18f6cc
PE
6171 * xmenu.c (menu_help_callback): Pointer type fixes.
6172 Use const pointers when pointing at readonly data. Avoid pointer
6173 signedness clashes.
6174 (FALSE): Remove unused macro.
6175 (update_frame_menubar): Remove unused decl.
6176
1fe72bf8
PE
6177 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6178
60d9e1db
PE
6179 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6180 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6181 (single_menu_item): Rename local to avoid shadowing.
6182
39261c26
PE
6183 * keyboard.c (make_lispy_event): Remove unused local var.
6184
018c5e19
PE
6185 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6186 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6187
63d2b86e
PE
6188 * bitmaps: Change bitmaps from unsigned char back to the X11
6189 compatible char. Avoid the old compiler warnings about
6190 out-of-range initializers by using, for example, '\xab' rather
6191 than 0xab.
6192
aefd87e1
PE
6193 * xgselect.c (xgselect_initialize): Check vs interface
6194 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6195
bf501fb9
PE
6196 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6197
e9829fdf
PE
6198 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6199 to read-only memory.
6200
1086c095
PE
6201 * fns.c (vector): Remove; this old hack is no longer needed.
6202
2baccd04 6203 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6204 Remove unused var.
dde42981 6205 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6206
72391843 6207 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6208
436c16df 6209 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6210 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6211 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6212
92bb796d 6213 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6214 (x_term_init): Remove local to avoid shadowing.
92bb796d 6215
764430a3 6216 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6217
6218 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6219 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6220
d1dfb56c
EZ
62212011-04-16 Eli Zaretskii <eliz@gnu.org>
6222
c4354cb4
EZ
6223 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6224
d1dfb56c
EZ
6225 Fix regex.c, syntax.c and friends for buffers > 2GB.
6226 * syntax.h (struct gl_state_s): Declare character position members
6227 EMACS_INT.
6228
6229 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6230
04f2d78b
CB
6231 * textprop.c (verify_interval_modification, interval_of):
6232 Declare arguments EMACS_INT.
d1dfb56c
EZ
6233
6234 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6235 EMACS_INT.
6236
6237 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6238
6239 * indent.c (Fvertical_motion): Local variable it_start is now
6240 EMACS_INT.
6241
6242 * regex.c (re_match, re_match_2, re_match_2_internal)
6243 (bcmp_translate, regcomp, regexec, print_double_string)
6244 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6245 (re_compile_pattern, re_exec): Declare arguments and local
6246 variables `size_t' and `ssize_t' and return values `regoff_t', as
6247 appropriate.
6248 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6249 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6250 <compile_stack_type>: `size' and `avail' are now `size_t'.
6251
6252 * regex.h <regoff_t>: Use ssize_t, not int.
6253 (re_search, re_search_2, re_match, re_match_2): Arguments that
6254 specify buffer/string position and length are now ssize_t and
6255 size_t. Return type is regoff_t.
6256
613052cd
BK
62572011-04-16 Ben Key <bkey76@gmail.com>
6258
6259 * nsfont.m: Fixed bugs in ns_get_family and
6260 ns_descriptor_to_entity that were caused by using free to
6261 deallocate memory blocks that were allocated by xmalloc (via
6262 xstrdup). This caused Emacs to crash when compiled with
6263 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6264 --enable-checking=xmallocoverrun). xfree is now used to
6265 deallocate these memory blocks.
6266
4170f62f 62672011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6268
71b41406
PE
6269 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6270
9587a89d
PE
6271 emacs_write: Accept and return EMACS_INT for sizes.
6272 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6273 et seq.
6274 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6275 Accept and return EMACS_INT.
6276 (emacs_gnutls_write): Return the number of bytes written on
6277 partial writes.
6278 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6279 (emacs_read, emacs_write): Remove check for negative size, as the
6280 Emacs source code has been audited now.
9587a89d
PE
6281 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6282 (emacs_read, emacs_write): Use it.
273a5f82
PE
6283 * process.c (send_process): Adjust to the new signatures of
6284 emacs_write and emacs_gnutls_write. Do not attempt to store
6285 a byte offset into an 'int'; it might overflow.
9587a89d 6286 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6287
3e047f51
PE
6288 * sound.c: Don't assume sizes fit in 'int'.
6289 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6290 Return EMACS_INT, not int.
3e047f51 6291 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6292 Accept EMACS_INT, not int.
6293 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6294 record read return values.
6295
cc39a9db
BK
62962011-04-15 Ben Key <bkey76@gmail.com>
6297
c9d0ec6d
JB
6298 * keyboard.c (Qundefined): Don't declare static since it is used
6299 in nsfns.m.
6300 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6301 static since they are used in nsfont.m.
cc39a9db 6302
6c60eb9f
SM
63032011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6304
6305 * process.c (Qprocessp): Don't declare static.
6306 * lisp.h (Qprocessp): Declare again.
6307
7990b61a
JB
63082011-04-15 Juanma Barranquero <lekktu@gmail.com>
6309
6310 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6311
5d4cb038
PE
63122011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6313
8bd7b830 6314 Improve C-level modularity by making more things 'static'.
cd64ea1d 6315
e3b27b31
PE
6316 Don't publish debugger-only interfaces to other modules.
6317 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6318 (verify_bytepos, count_markers): Move decls to the only modules
6319 that need them.
6320 * region-cache.h (pp_cache): Likewise.
6321 * window.h (check_all_windows): Likewise.
6322 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6323
5d4cb038
PE
6324 * sysdep.c (croak): Now static, if
6325 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6326 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6327
6328 * alloc.c (refill_memory_reserve): Now static if
6329 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6330 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6331
e87b6180
PE
6332 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6333 Define only if USE_LUCID.
6334
ac64929e
PE
6335 * xrdb.c (x_customization_string, x_rm_string): Now static.
6336
6f37259d
PE
6337 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6338 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6339
1683e3ab
PE
6340 * xdisp.c (draw_row_with_mouse_face): Now static.
6341 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6342
de9c2632
PE
6343 * window.h (check_all_windows): Mark externally visible.
6344
2b96acb7
PE
6345 * window.c (window_deletion_count): Now static.
6346
6347 * undo.c: Make symbols static if they're not exported.
6348 (last_undo_buffer, last_boundary_position, pending_boundary):
6349 Now static.
6350
50436f33
PE
6351 * textprop.c (interval_insert_behind_hooks): Now static.
6352 (interval_insert_in_front_hooks): Likewise.
6353
64520e5c
PE
6354 * term.c: Make symbols static if they're not exported.
6355 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6356 (max_frame_lines, tty_set_terminal_modes):
6357 (tty_reset_terminal_modes, tty_turn_off_highlight):
6358 (get_tty_terminal): Now static.
6359 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6360 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6361 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6362 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6363 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6364
1fa53021
PE
6365 * sysdep.c: Make symbols static if they're not exported.
6366 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6367 Now static.
6368 (sigprocmask_set, full_mask): Remove; unused.
6369 (wait_debugging): Mark as visible.
6370 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6371 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6372
d4b43b22
PE
6373 * syntax.c (syntax_temp): Define only if !__GNUC__.
6374
b7c513d0
PE
6375 * sound.c (current_sound_device, current_sound): Now static.
6376
989b29ad
PE
6377 * search.c (searchbufs, searchbuf_head): Now static.
6378
13a55a78
PE
6379 * scroll.c (scroll_cost): Remove; unused.
6380 * dispextern.h (scroll_cost): Remove decl.
6381
de68a1fc
PE
6382 * region-cache.h (pp_cache): Mark as externally visible.
6383
40ccffa6
PE
6384 * process.c: Make symbols static if they're not exported.
6385 (process_tick, update_tick, create_process, chan_process):
6386 (Vprocess_alist, proc_buffered_char, datagram_access):
6387 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6388 (deactivate_process): Mark defn as static, as well as decl.
6389 * lisp.h (create_process): Remove decl.
6390 * process.h (chan_process, Vprocess_alist): Remove decls.
6391
ad64fc97
PE
6392 * print.c: Make symbols static if they're not exported.
6393 (print_depth, new_backquote_output, being_printed, print_buffer):
6394 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6395 (print_interval, print_number_index, initial_stderr_stream):
6396 Now static.
6397 * lisp.h (Fprinc): Remove decl.
6398 (debug_output_compilation_hack): Mark as externally visible.
6399
adddb265
PE
6400 * sysdep.c (croak): Move decl from here to syssignal.h.
6401 * syssignal.h (croak): Put it here, so the API can be checked when
6402 'croak' is called from dissociate_if_controlling_tty.
6403
1717ede2
PE
6404 * minibuf.c: Make symbols static if they're not exported.
6405 (minibuf_save_list, choose_minibuf_frame): Now static.
6406 * lisp.h (choose_minibuf_frame): Remove decl.
6407
fa5fb2bc
PE
6408 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6409
1e3890d1
PE
6410 * lread.c: Make symbols static if they're not exported.
6411 (read_objects, initial_obarray, oblookup_last_bucket_number):
6412 Now static.
6413 (make_symbol): Remove; unused.
6414 * lisp.h (initial_obarray, make_symbol): Remove decls.
6415
8a1414fa
PE
6416 * keyboard.c: Make symbols static if they're not exported.
6417 (single_kboard, recent_keys_index, total_keys, recent_keys):
6418 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6419 (this_single_command_key_start, echoing, last_auto_save):
6420 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6421 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6422 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6423 (Vlispy_mouse_stem, double_click_count):
6424 Now static.
6425 (force_auto_save_soon): Define only if SIGDANGER.
6426 (ignore_mouse_drag_p): Now static if
6427 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6428 (print_help): Remove; unused.
6429 (stop_character, last_timer_event): Mark as externally visible.
6430 * keyboard.h (ignore_mouse_drag_p): Declare only if
6431 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6432 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6433 * lisp.h (echoing): Remove decl.
6434 (force_auto_save_soon): Declare only if SIGDANGER.
6435 * xdisp.c (redisplay_window): Simplify code, to make it more
6436 obvious that ignore_mouse_drag_p is not accessed if !defined
6437 USE_GTK && !defined HAVE_NS.
6438
93ea6e8f
PE
6439 * intervals.c: Make symbols static if they're not exported.
6440 (merge_properties_sticky, merge_interval_right, delete_interval):
6441 Now static.
6442 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6443
77382fcc
PE
6444 * insdel.c: Make symbols static if they're not exported.
6445 However, leave prepare_to_modify_buffer alone. It's never
6446 called from outside this function, but that appears to be a bug.
6447 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6448 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6449 (adjust_after_replace_noundo): Remove; unused.
6450 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6451 (signal_before_change): Remove decls.
77382fcc 6452
9306c32e
PE
6453 * indent.c (val_compute_motion, val_vmotion): Now static.
6454
cd44d2eb
PE
6455 * image.c: Make symbols static if they're not exported.
6456 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6457 if USE_GTK.
6458 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6459 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6460
ad9a7a06
PE
6461 * fringe.c (standard_bitmaps): Now static.
6462 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6463
81626931
PE
6464 * frame.c: Make symbols static if they're not exported.
6465 (x_report_frame_params, make_terminal_frame): Now static.
6466 (get_frame_param): Now static, unless HAVE_NS.
6467 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6468 (x_get_resource_string): Remove; not used.
6469 * frame.h (make_terminal_frame, x_report_frame_params):
6470 (x_get_resource_string); Remove decls.
6471 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6472 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6473
239f9db9
PE
6474 * font.c, fontset.c: Make symbols static if they're not exported.
6475 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6476 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6477 * font.c (font_close_object): Now static.
6478 * font.h (font_close_object): Remove.
6479 * fontset.c (FONTSET_OBJLIST): Remove.
6480 (free_realized_fontset) #if-0 the body, which does nothing.
6481 (face_suitable_for_char_p): #if-0, as it's never called.
6482 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6483 * xfaces.c (face_at_string_position):
6484 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6485 since 0 is always ASCII.
6486
dfcf3579
PE
6487 * fns.c (weak_hash_tables): Now static.
6488
5045092b
PE
6489 * fileio.c: Make symbols static if they're not exported.
6490 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6491 (Vwrite_region_annotation_buffers): Now static.
6492
57a96f5c
PE
6493 * eval.c: Make symbols static if they're not exported.
6494 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6495 * lisp.h (backtrace_list): Remove decl.
6496
35f08c38
PE
6497 * emacs.c: Make symbols static if they're not exported.
6498 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6499 (fatal_error_code, fatal_error_signal_hook, standard_args):
6500 Now static.
6501 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6502 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6503 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6504 * lisp.h (fatal_error_signal_hook): Remove decl.
6505 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6506
f44bd759
PE
6507 * editfns.c: Move a (normally-unused) function to its only use.
6508 * editfns.c, lisp.h (get_operating_system_release): Remove.
6509 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6510 worth the hassle of breaking this out.
6511
b532497d
PE
6512 * xterm.c: Make symbols static if they're not exported.
6513 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6514 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6515 (x_destroy_window, x_delete_display):
6516 Now static.
6517 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6518 (x_mouse_leave): Remove; unused.
6519 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6520 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6521 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6522 Remove decls.
6523 (x_mouse_leave): Declare only if WINDOWSNT.
6524 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6525 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6526 USE_X_TOOLKIT.
6527
1675728f
PE
6528 * ftxfont.c: Make symbols static if they're not exported.
6529 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6530 HAVE_FREETYPE.
6531 * font.h (ftxfont_driver): Likewise.
6532
e4cebfca
PE
6533 * xfns.c: Make symbols static if they're not exported.
6534 (x_last_font_name, x_display_info_for_name):
6535 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6536 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6537 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6538 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6539 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6540 (last_show_tip_args): Now static.
6541 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6542 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6543 (x_screen_planes): Remove; unused.
6544 * dispextern.h (x_screen_planes): Remove decl.
6545
5bf46f05
PE
6546 * dispnew.c: Make symbols static if they're not exported.
6547 * dispextern.h (redraw_garbaged_frames, scrolling):
6548 (increment_row_positions): Remove.
6549 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6550 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6551 Now static.
6552 (redraw_garbaged_frames): Remove; unused.
6553
435f4c28
PE
6554 * xfaces.c: Make symbols static if they're not exported.
6555 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6556 Remove decls.
6557 * xterm.h (defined_color): Remove decls.
6558 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6559 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6560 (menu_face_changed_default, defined_color, free_realized_face):
6561 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6562 (ascii_face_of_lisp_face): Remove; unused.
6563
8524aef3
PE
6564 * xdisp.c: Make symbols static if they're not exported.
6565 * dispextern.h (scratch_glyph_row, window_box_edges):
6566 (glyph_to_pixel_coords, set_cursor_from_row):
6567 (get_next_display_element, set_iterator_to_next):
6568 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6569 (show_mouse_face): Remove decls
6570 * frame.h (message_buf_print): Likewise.
6571 * lisp.h (pop_message, set_message, check_point_in_composition):
6572 Likewise.
6573 * xterm.h (set_vertical_scroll_bar): Likewise.
6574 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6575 (message_buf_print, scratch_glyph_row, displayed_buffer):
6576 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6577 (get_next_display_element, show_mouse_face, window_box_edges):
6578 (frame_to_window_pixel_xy, check_point_in_composition):
6579 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6580 (glyph_to_pixel_coords): Remove; unused.
6581
16390cd2
PE
6582 * dired.c (file_name_completion): Now static.
6583
6584 * dbusbind.c (xd_in_read_queued_messages): Now static.
6585
a25f4dfa
PE
6586 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6587 * data.c (circular_list_error): Remove.
6588
14a9c8df
PE
6589 * commands.h (last_point_position, last_point_position_buffer):
6590 (last_point_position_window): Remove decls.
6591 * keyboard.c: Make these variables static.
6592
04f2d78b
CB
6593 * coding.h (coding, code_convert_region, encode_coding_gap):
6594 Remove decls.
74ab6df5
PE
6595 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6596 (iso_code_class, detect_coding, code_convert_region): Now static.
6597 (encode_coding_gap): Remove; unused.
6598
38dfbee1
PE
6599 * chartab.c (chartab_chars, chartab_bits): Now static.
6600
a2cb4e63
PE
6601 * charset.h (charset_iso_8859_1): Remove decl.
6602 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6603 Now static.
6604
127198fd
PE
6605 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6606 * ccl.c (Vccl_program_table): Now static.
6607 (check_ccl_update): Remove; unused.
6608
d85b608f
PE
6609 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6610 * category.h: ... from here.
6611 * category.c (check_category_table, set_category_set): Now static.
6612
31cd66f3
PE
6613 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6614 * lisp.h: Remove these decls.
6615
c358e587
PE
6616 * buffer.c (buffer_count): Remove unused var.
6617
e78aecca
PE
6618 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6619 so that it's not optimized away.
6620 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6621 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6622 exported only to the debugger.
6623
e192d7d3 6624 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6625 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6626
92470028
PE
6627 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6628 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6629 was inaccessible from Lisp.
6630 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6631 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6632
244ed907
PE
6633 alloc.c: Import and export fewer symbols, and remove unused items.
6634 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6635 is defined.
6636 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6637 it's not optimized away by whole-program optimization.
6638 (message_enable_multibyte, free_misc): Remove.
6639 (catchlist, handlerlist, mark_backtrace):
6640 Declare only if BYTE_MARK_STACK.
6641 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6642 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6643 (message_enable_multibyte): Remove decl.
6644 (free_misc, interval_free_list, float_block, float_block_index):
6645 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6646 (cons_free_list, last_marked_index):
6647 Now static.
6648 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6649 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6650 (mark_backtrace): Define only if BYTE_MARK_STACK.
6651 * xdisp.c (message_enable_multibyte): Now static.
6652
61c2b50e 6653 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6654 This makes it easier for human readers (and static analyzers)
6655 to see whether these variables are used from other modules.
6656 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6657 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6658 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6659 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6660 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6661 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6662 * xmenu.c, xselect.c:
6663 Declare Q* vars static if they are not used in other modules.
6664 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6665 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6666 Remove decls of unexported vars.
6667 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6668
95c82688
PE
6669 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6670
16a97296
PE
6671 Make Emacs functions such as Fatom 'static' by default.
6672 This makes it easier for human readers (and static analyzers)
6673 to see whether these functions can be called from other modules.
6674 DEFUN now defines a static function. To make the function external
6675 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6676 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6677 (Finit_image_library):
16a97296
PE
6678 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6679 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6680 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6681 Remove decls, since these functions are now static.
6682 (Funintern, Fget_internal_run_time): New decls, since these functions
6683 were already external.
95c82688 6684
16a97296
PE
6685 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6686 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6687 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6688 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6689 * keyboard.c, keymap.c, lread.c:
6690 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6691 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6692 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6693 Mark functions with DEFUE instead of DEFUN,
6694 if they are used in other modules.
6695 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6696 decls for now-static functions.
6697 * buffer.h (Fdelete_overlay): Remove decl.
6698 * callproc.c (Fgetenv_internal): Mark as internal.
6699 * composite.c (Fremove_list_of_text_properties): Remove decl.
6700 (Fcomposition_get_gstring): New forward static decl.
6701 * composite.h (Fcomposite_get_gstring): Remove decl.
6702 * dired.c (Ffile_attributes): New forward static decl.
6703 * doc.c (Fdocumntation_property): New forward static decl.
6704 * eval.c (Ffetch_bytecode): New forward static decl.
6705 (Funintern): Remove extern decl; now in .h file where it belongs.
6706 * fileio.c (Fmake_symbolic_link): New forward static decl.
6707 * image.c (Finit_image_library): New forward static decl.
6708 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6709 * intervals.h (Fprevious_property_change):
6710 (Fremove_list_of_text_properties): Remove decls.
6711 * keyboard.c (Fthis_command_keys): Remove decl.
6712 (Fcommand_execute): New forward static decl.
6713 * keymap.c (Flookup_key): New forward static decl.
6714 (Fcopy_keymap): Now static.
6715 * keymap.h (Flookup_key): Remove decl.
6716 * process.c (Fget_process): New forward static decl.
6717 (Fprocess_datagram_address): Mark as internal.
6718 * syntax.c (Fsyntax_table_p): New forward static decl.
6719 (skip_chars): Remove duplicate decl.
6720 * textprop.c (Fprevious_property_change): New forward static decl.
6721 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6722 Now internal.
6723 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6724 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6725
785bbd42
PE
6726 * editfns.c (Fformat): Remove unreachable code.
6727
8b913b57
AS
67282011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6729
6730 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6731 change. (Bug#8496)
6732
a6744a35
EZ
67332011-04-13 Eli Zaretskii <eliz@gnu.org>
6734
6735 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6736 when at ZV. (Bug#8487)
6737
e7974947
AS
67382011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6739
baad03f0
AS
6740 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6741 (Bug#8437)
6742 * keyboard.c (parse_tool_bar_item): Likewise.
6743 * sound.c (sound_cleanup, alsa_close): Likewise.
6744 * termcap.c (tgetent): Likewise.
6745 * xfns.c (x_default_font_parameter): Likewise.
6746 * xsettings.c (read_and_apply_settings): Likewise.
6747
e7974947
AS
6748 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6749 (overrun_check_free): Protoize.
6750
28272684
PE
67512011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6752
6753 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6754 since callers should never pass a negative size.
6755 Change the signature to match that of plain 'read' and 'write'; see
6756 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6757 * lisp.h: Update prototypes of emacs_write and emacs_read.
6758
11997c76
EZ
67592011-04-11 Eli Zaretskii <eliz@gnu.org>
6760
6761 * xdisp.c (redisplay_window): Don't try to determine the character
6762 position of the scroll margin if the window start point w->startp
e896f03c 6763 is outside the buffer's accessible region. (Bug#8468)
11997c76 6764
8a2cbd72
EZ
67652011-04-10 Eli Zaretskii <eliz@gnu.org>
6766
6767 Fix write-region and its subroutines for buffers > 2GB.
6768 * fileio.c (a_write, e_write): Modify declaration of arguments and
6769 local variables to support buffers larger than 2GB.
6770 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6771
6772 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6773 argument, local variables, and return value.
6774
6775 * lisp.h: Update prototypes of emacs_write and emacs_read.
6776
6777 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6778
4073e537 67792011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6780
1ebfdcb6
PE
6781 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6782
b2ded58d
PE
6783 Fix more problems found by GCC 4.6.0's static checks.
6784
7d66342c
PE
6785 * xdisp.c (vmessage): Use a better test for character truncation.
6786
bbf47d44
PE
6787 * charset.c (load_charset_map): <, not <=, for optimization,
6788 and to avoid potential problems with integer overflow.
9248994d 6789 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6790 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6791 * editfns.c (Fformat): Likewise.
1e69125e 6792 * syntax.c (skip_chars): Likewise.
3befa583 6793
e3019616
PE
6794 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6795 This also lets GCC 4.6.0 generate slightly better loop code.
6796
becfa255
PE
6797 * callint.c (Fcall_interactively): <, not <=, for optimization.
6798 (Fcall_interactively): Count the number of arguments produced,
6799 not the number of arguments given. This is simpler and lets GCC
6800 4.6.0 generate slightly better code.
6801
dae0cd48
PE
6802 * ftfont.c: Distingish more carefully between FcChar8 and char.
6803 The previous code passed unsigned char * to a functions like
6804 strlen and xstrcasecmp that expect char *, which does not
6805 conform to the C standard.
6806 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6807 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6808 char * when the C standard requires it.
6809
76032d70
PE
6810 * keyboard.c (read_char): Remove unused var.
6811
eb3f1cc8
PE
6812 * eval.c: Port to Windows vsnprintf (Bug#8435).
6813 Include <limits.h>.
6814 (SIZE_MAX): Define if the headers do not.
6815 (verror): Do not give up if vsnprintf returns a negative count.
6816 Instead, grow the buffer. This ports to Windows vsnprintf, which
6817 does not conform to C99. Problem reported by Eli Zaretskii.
6818 Also, simplify the allocation scheme, by avoiding the need for
6819 calling realloc, and removing the ALLOCATED variable.
6820
70476b54
PE
6821 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6822
12020a9e
PE
6823 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6824 But keep the doprint source code for now, as we might revamp it
6825 and use it again (Bug#8435).
ea6c7ae6
PE
6826 * lisp.h (doprnt): Remove.
6827 * Makefile.in (base_obj): Remove doprnt.o.
6828 * deps.mk (doprnt.o): Remove.
6829
5fdb398c
PE
6830 error: Print 32- and 64-bit integers portably (Bug#8435).
6831 Without this change, on typical 64-bit hosts error ("...%d...", N)
6832 was used to print both 32- and 64-bit integers N, which relied on
6833 undefined behavior.
6834 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6835 New macro.
6836 * lisp.h (error, verror): Mark as printf-like functions.
6837 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6838 Report overflow in size calculations when allocating printf buffer.
6839 Do not truncate output string at its first null byte.
6840 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6841 Truncate the output at a character boundary, since vsnprintf does not
6842 do that.
6843 * charset.c (check_iso_charset_parameter): Convert internal
6844 character to string before calling 'error', since %c now has the
6845 printf meaning.
6846 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6847 overflow when computing char to be passed to 'error'. Do not
6848 pass Lisp_Object to 'error'; pass the integer instead.
6849 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6850 formatted with plain %d.
6851
b189fa66
PE
6852 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6853
bff87ef0
PE
6854 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6855
7e2cac20
PE
6856 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6857
ce4d90b5
PE
6858 * xterm.c (x_catch_errors): Remove duplicate declaration.
6859
266c9547
PE
6860 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6861
79c49ad2
PE
6862 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6863
368f4090
JM
68642011-04-10 Jim Meyering <meyering@redhat.com>
6865
6866 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6867 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6868 return ssize_t not "int", and use size_t as the buffer length.
6869 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6870 * gnutls.h: Update declarations.
6871 * process.c (read_process_output): Use ssize_t, to match.
6872 (send_process): Likewise.
6873
a32d4040
CY
68742011-04-09 Chong Yidong <cyd@stupidchicken.com>
6875
6876 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6877
8546720e 68782011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6879
04f2d78b
CB
6880 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6881 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6882
8546720e
GM
6883 * xterm.c (handle_one_xevent):
6884 * xmenu.c (create_and_show_popup_menu):
6885 * xselect.c (x_decline_selection_request)
6886 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6887
0a2f5c1a 68882011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6889
6890 Fix some uses of `int' instead of EMACS_INT.
6891 * search.c (string_match_1, fast_string_match)
6892 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6893 (scan_buffer, find_next_newline_no_quit)
6894 (find_before_next_newline, search_command, Freplace_match)
6895 (Fmatch_data): Make some `int' variables be EMACS_INT.
6896
6897 * xdisp.c (display_count_lines): 3rd argument and return value now
6898 EMACS_INT. All callers changed.
6899 (pint2hrstr): Last argument is now EMACS_INT.
6900
6901 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6902 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6903 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6904 (decode_coding_utf_16, decode_coding_emacs_mule)
6905 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6906 (decode_coding_ccl, decode_coding_charset)
6907 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6908 (decode_coding_iso_2022, decode_coding_emacs_mule)
6909 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6910 <char_offset, last_offset>: Declare EMACS_INT.
6911 (encode_coding_utf_8, encode_coding_utf_16)
6912 (encode_coding_emacs_mule, encode_invocation_designation)
6913 (encode_designation_at_bol, encode_coding_iso_2022)
6914 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6915 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6916 Declare EMACS_INT.
6917 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6918 (encode_invocation_designation): Last argument P_NCHARS is now
6919 EMACS_INT.
6920 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6921 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6922
6923 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6924 All users changed.
6925
6926 * ccl.c (Fccl_execute_on_string): Declare some variables
6927 EMACS_INT.
6928
8546720e 69292011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6930
6931 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6932
4e19a977
CS
69332011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6934
6935 * process.c (Fformat_network_address): Doc fix.
6936
87302331
R
69372011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6938
6939 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6940
cbb59342
CY
69412011-04-08 Chong Yidong <cyd@stupidchicken.com>
6942
6943 * keyboard.c (read_char): Call Lisp function help-form-show,
6944 instead of using internal_with_output_to_temp_buffer.
6945 (Qhelp_form_show): New var.
e0d38eeb 6946 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6947
6948 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6949
6950 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6951
e67a13ab
CY
69522011-04-06 Chong Yidong <cyd@stupidchicken.com>
6953
04f2d78b
CB
6954 * process.c (Flist_processes): Remove to Lisp.
6955 (list_processes_1): Delete.
e67a13ab 6956
973f782d
EZ
69572011-04-06 Eli Zaretskii <eliz@gnu.org>
6958
7c106b1e
EZ
6959 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6960
973f782d
EZ
6961 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6962
41cf7d1a 69632011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6964
ca23cc88
PE
6965 Fix more problems found by GCC 4.6.0's static checks.
6966
f390e2d5
PE
6967 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6968
42eea0d0
PE
6969 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6970
b69769da 6971 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6972
f9541e84
PE
6973 * xdisp.c (vmessage): Mark as a printf-like function.
6974
13841b55
PE
6975 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6976
c136c10f
PE
6977 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6978
5e2d4a30
PE
6979 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6980 printf-like functions.
6981 (tiff_load): Add casts to remove these marks before passing them
6982 to system-supplied API.
6983
583f48b9
PE
6984 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6985
b25d760e
PE
6986 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6987 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6988 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6989 directly, rather than having caller test rule sign. This avoids
6990 some unnecessary tests.
6991 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6992 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6993 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6994
bc7b6697 6995 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6996 (xfont_open): Avoid unnecessary tests.
bc7b6697 6997
27ccc379
PE
6998 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6999
dcd5c89a
PE
7000 * composite.h, composite.c (composition_gstring_put_cache):
7001 Use EMACS_INT, not int, for length.
7002
b13a45c6
PE
7003 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7004 breaking out part of COMPOSITION_DECODE_RULE.
7005 (COMPOSITION_DECODE_RULE): Use it.
7006 * composite.c (get_composition_id): Remove unused local vars,
7007 by using the new macro.
7008
1e792e4d
PE
7009 * textprop.c (set_text_properties_1): Change while to do-while,
7010 since the condition is always true at first.
7011
dc6c6455 7012 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7013 (interval_deletion_adjustment): Return unsigned value.
7014 All uses changed.
dc6c6455 7015
aba7731a
PE
7016 * process.c (list_processes_1, create_pty, read_process_output):
7017 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7018 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7019 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7020 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7021 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7022
fdfc4bf3
PE
7023 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7024
fca8fe46 7025 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7026 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7027
06a0259a 7028 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7029 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7030 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7031
e7b9e80f
PE
7032 * print.c (print_error_message): Avoid int overflow.
7033
56201685
PE
7034 * font.c (font_list_entities): Redo for clarity,
7035 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7036
78834453 7037 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7038 (font_score): Avoid potential overflow in diff calculation.
78834453 7039
0bc0b309 7040 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7041 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7042
e610eaca
PE
7043 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7044
b895abce
PE
7045 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7046 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7047 can always succeed if overflow has undefined behavior.
7048
1f1d9321 7049 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7050 (wordify): Omit three unnecessary tests.
1f1d9321 7051
c59478bc
PE
7052 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7053 All callers changed. This avoids the need for an unused var.
7054
79b73827
PE
7055 * casefiddle.c (casify_region): Remove var that is set but not used.
7056
a4db5dfe
PE
7057 * dired.c (file_name_completion): Remove var that is set but not used.
7058
43aae36e
PE
7059 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7060
2a47c44d 7061 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7062 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7063
a37c69bf
PE
7064 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7065 Check for integer overflow on size calculations.
7066
328ab8e7
PE
7067 * buffer.c (Fprevious_overlay_change): Remove var that is set
7068 but not used.
7069
e5a2a5cb
PE
7070 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7071 Remove vars that are set but not used.
8d84a6eb 7072 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7073 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7074
a60e5f68
PE
7075 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7076
f661cb61 7077 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7078 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7079
f0397f5a
PE
7080 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7081 that are set but not used.
7082
8664db06 7083 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7084 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7085
6abdaa4a
PE
7086 * xselect.c (x_get_local_selection, x_handle_property_notify):
7087 Remove vars that are set but not used.
7088
0ce7538d 7089 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7090 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7091
9ae848fc
PE
7092 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7093 Remove var that is set but not used.
0b918413
PE
7094 (scroll_bar_windows_size): Now size_t, not int.
7095 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7096 Check for overflow.
9ae848fc 7097
a5a62657
PE
7098 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7099 (map_tty_color) [!defined MSDOS]: Likewise.
7100
5c5cdd39
PE
7101 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7102
66ebf983
PE
7103 * coding.c: Remove vars that are set but not used.
7104 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7105 All callers changed.
7106 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7107 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7108 (decode_coding_charset): Remove vars that are set but not used.
7109
1be4d761
PE
7110 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7111 that is set but not used.
7112
47553fa8
PE
7113 * print.c (print_object): Remove var that is set but not used.
7114
1f7196bf 7115 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7116 The gnulib version avoids calling malloc in the usual case,
7117 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7118 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7119 * filelock.c (current_lock_owner): Likewise.
7120 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7121 * sysdep.c: Include allocator.h, careadlinkat.h.
7122 (emacs_no_realloc_allocator): New static constant.
7123 (emacs_readlink): New function.
fdb61804
PE
7124 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7125 ../lib/careadlinkat.h.
d1fdcab7 7126
f84c17c7
SM
71272011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7128
7129 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7130 first non-nil return value).
7131
ef3862ad
JD
71322011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7133
7134 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7135 if not defined (Bug#8403).
7136
376a7006
JB
71372011-04-02 Juanma Barranquero <lekktu@gmail.com>
7138
7139 * xdisp.c (display_count_lines): Remove parameter `start',
7140 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7141 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7142 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7143 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7144 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7145 and thereabouts. All callers changed.
7146 (get_per_char_metric): Remove parameter `f', unused since
7147 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7148
6ca3801d
JM
71492011-04-02 Jim Meyering <meyering@redhat.com>
7150
7151 do not dereference NULL upon failed strdup
7152 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7153 (ns_get_family): Likewise.
7154
d8e2b5ba
JB
71552011-04-02 Juanma Barranquero <lekktu@gmail.com>
7156
7157 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7158
8c74fcbd
JD
71592011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7160
7161 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7162 later (Bug#8403).
7163
7200d79c
SM
71642011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7165
03408648 7166 Add lexical binding.
7200d79c 7167
03408648
SM
7168 * window.c (Ftemp_output_buffer_show): New fun.
7169 (Fsave_window_excursion):
7170 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7171
7172 * lread.c (lisp_file_lexically_bound_p): New function.
7173 (Fload): Bind Qlexical_binding.
7174 (readevalloop): Remove `evalfun' arg.
7175 Bind Qinternal_interpreter_environment.
7176 (Feval_buffer): Bind Qlexical_binding.
7177 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7178 Mark as dynamic.
7179 (syms_of_lread): Declare `lexical-binding'.
7180
7181 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7182
7183 * keyboard.c (eval_dyn): New fun.
7184 (menu_item_eval_property): Use it.
ca105506
SM
7185
7186 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7187
03408648
SM
7188 * fns.c (concat, mapcar1): Accept byte-code-functions.
7189
7190 * eval.c (Fsetq): Handle lexical vars.
7191 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7192 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7193 (FletX, Flet): Obey lexical binding.
7194 (Fcommandp): Handle closures.
7195 (Feval): New `lexical' arg.
7196 (eval_sub): New function extracted from Feval. Use it almost
7197 everywhere where Feval was used. Look up vars in lexical env.
7198 Handle closures.
7199 (Ffunctionp): Move from subr.el.
7200 (Ffuncall): Handle closures.
7201 (apply_lambda): Remove `eval_flags'.
7202 (funcall_lambda): Handle closures and new byte-code-functions.
7203 (Fspecial_variable_p): New function.
7204 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7205 but without exporting it to Lisp.
23aba0ea 7206
23aba0ea 7207 * doc.c (Fdocumentation, store_function_docstring):
03408648 7208 * data.c (Finteractive_form): Handle closures.
23aba0ea 7209
03408648
SM
7210 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7211 interactive spec.
ba83908c 7212
04f2d78b
CB
7213 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7214 New byte-codes.
03408648
SM
7215 (exec_byte_code): New function extracted from Fbyte_code to handle new
7216 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7217
03408648 7218 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7219
03408648 7220 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7221
e2abce01
JB
72222011-03-31 Juanma Barranquero <lekktu@gmail.com>
7223
7224 * xdisp.c (redisplay_internal): Fix prototype.
7225
63696a73 72262011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7227
63696a73 7228 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7229 (try_scrolling): Use it when setting scroll_limit.
7230 Limit scrolling to 100 screen lines.
63696a73
EZ
7231 (redisplay_window): Even when falling back on "recentering",
7232 position point in the window according to scroll-conservatively,
7233 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7234
7235 (try_scrolling): When point is above the window, allow searching
7236 as far as scroll_max, or one screenful, to compute vertical
7237 distance from PT to the scroll margin position. This prevents
7238 try_scrolling from unnecessarily failing when
7239 scroll-conservatively is set to a value slightly larger than the
7240 window height. Clean up the case of PT below the margin at bottom
7241 of window: scroll_max can no longer be INT_MAX. When aggressive
7242 scrolling is in use, don't let point enter the opposite scroll
7243 margin as result of the scroll.
7244 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7245 threshold of 100 lines for never-recentering scrolling.
7246
e4cc2dfc
JB
72472011-03-31 Juanma Barranquero <lekktu@gmail.com>
7248
7249 * dispextern.h (move_it_by_lines):
7250 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7251 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7252 (message_log_check_duplicate): Remove parameters `prev_bol' and
7253 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7254 (redisplay_internal): Remove parameter `preserve_echo_area',
7255 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7256
7257 * indent.c (Fvertical_motion):
7258 * window.c (window_scroll_pixel_based, Frecenter):
7259 Don't pass `need_y_p' to `move_it_by_lines'.
7260
1c470562
SM
72612011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7262
44f230aa
SM
7263 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7264 steal a few bits to be more compact.
7265 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7266 Remove unneeded casts.
7267
1c470562
SM
7268 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7269
888adce9
ZK
72702011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7271
7272 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7273 binding" message (bug#7967).
7274
f838ed7b
PE
72752011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7276
77861b95
PE
7277 Fix more problems found by GCC 4.6.0's static checks.
7278
de6dbc14
PE
7279 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7280 Remove unused local var.
7281
f838ed7b
PE
7282 * editfns.c (Fmessage_box): Remove unused local var.
7283
792c7b2b
PE
7284 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7285 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7286 Omit unused local vars.
c499e557 7287 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7288 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7289 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7290 Omit unused local var.
7291
ba0165e1
PE
7292 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7293 Don't assume string length fits in int.
32ad8845 7294 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7295 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7296
3c59b4c9
PE
7297 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7298 instead of alloca (Bug#8344).
7299
a3eed478 7300 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7301 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7302
eb4d412d
PE
7303 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7304
1658b401
PE
7305 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7306 concerns.
7307
7308 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7309
7310 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7311
9a2c6e05
PE
7312 * keyboard.c (syms_of_keyboard): Use the same style as later
7313 in this function when indexing through an array. This also
7314 works around GCC bug 48267.
7315
03d0a109
PE
7316 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7317
44f730c8
PE
7318 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7319
fe75f926
PE
7320 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7321 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7322
ffa8c828
PE
7323 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7324 This avoids undefined behavior on integer overflow, and is a bit
7325 more convenient anyway since it is compared to a size_t variable.
7326
c5101a77
PE
7327 Variadic C functions now count arguments with size_t, not int.
7328 This avoids an unnecessary limitation on 64-bit machines, which
7329 caused (substring ...) to crash on large vectors (Bug#8344).
7330 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7331 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7332 All variadic functions and their callers changed accordingly.
c5101a77
PE
7333 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7334 * data.c (arith_driver, float_arith_driver): Likewise.
7335 * editfns.c (general_insert_function): Likewise.
7336 * eval.c (struct backtrace.nargs, interactive_p)
7337 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7338 (funcall_lambda, mark_backtrace): Likewise.
7339 * fns.c (concat): Likewise.
7340 * frame.c (x_set_frame_parameters): Likewise.
7341 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7342 0 if not found, not -1. All callers changed.
7343
dd3f25f7
PE
7344 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7345 (stack_copy_size): Now size_t, not int.
7346 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7347
461c2ab9
JB
73482011-03-28 Juanma Barranquero <lekktu@gmail.com>
7349
7350 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7351 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7352 All callers changed.
7353
7354 * lisp.h (multibyte_char_to_unibyte):
7355 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7356 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7357 * character.h (CHAR_TO_BYTE8):
7358 * cmds.c (internal_self_insert):
7359 * editfns.c (general_insert_function):
7360 * keymap.c (push_key_description):
7361 * search.c (Freplace_match):
7362 * xdisp.c (message_dolog, set_message_1): All callers changed.
7363
f6d62986
SM
73642011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7365
7366 * keyboard.c (safe_run_hook_funcall): New function.
7367 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7368 don't set the hook to nil, but remove the offending function instead.
7369 (Qcommand_hook_internal): Remove, unused.
7370 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7371 Vcommand_hook_internal.
7372
7373 * eval.c (enum run_hooks_condition): Remove.
7374 (funcall_nil, funcall_not): New functions.
7375 (run_hook_with_args): Call each function through a `funcall' argument.
7376 Remove `cond' argument, now redundant.
7377 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7378 (Frun_hook_with_args_until_failure): Adjust accordingly.
7379 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7380
1db5b1ad
JB
73812011-03-28 Juanma Barranquero <lekktu@gmail.com>
7382
7383 * dispextern.h (string_buffer_position): Remove declaration.
7384
7385 * print.c (strout): Remove parameter `multibyte', unused since
7386 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7387
7388 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7389 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7390 All callers changed.
7391
7392 * w32.c (_wsa_errlist): Use braces for struct initializers.
7393
7394 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7395 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7396 All callers changed.
7397 (string_buffer_position): Likewise. Also, make static (it's never
7398 used outside xdisp.c).
7399 (cursor_row_p): Remove parameter `w', unused since
7400 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7401 (decode_mode_spec): Remove parameter `precision', introduced during
7402 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7403 All callers changed.
7404
5ffb62aa
JD
74052011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7406
7407 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7408
461c2ab9 74092011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7410
7411 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7412 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7413 (ns_update_auto_hide_menu_bar): New functions.
7414 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7415 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7416 ns_constrain_all_frames.
7417 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7418 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7419
5c380ffb
JD
74202011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7421
7422 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7423
9af30bdf
GM
74242011-03-27 Glenn Morris <rgm@gnu.org>
7425
7426 * syssignal.h: Replace RETSIGTYPE with void.
7427 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7428 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7429 Replace SIGTYPE with void everywhere.
7430 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7431 * s/template.h (SIGTYPE): Remove commented out definition.
7432
e2abce01
JB
74332011-03-26 Eli Zaretskii <eliz@gnu.org>
7434
7435 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7436 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7437
f868cd8a
JB
74382011-03-26 Juanma Barranquero <lekktu@gmail.com>
7439
59eb0929
JB
7440 * w32.c (read_unc_volume): Use parameter `henum', instead of
7441 global variable `wget_enum_handle'.
7442
7443 * keymap.c (describe_vector): Remove parameters `indices' and
7444 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7445 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7446
f868cd8a
JB
7447 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7448
7449 * keyboard.c (timer_check): Remove parameter `do_it_now',
7450 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7451 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7452 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7453
7454 * keyboard.c (read_char):
7455 * w32menu.c (w32_menu_display_help):
7456 * xmenu.c (show_help_event, menu_help_callback):
7457 Adjust calls to `show_help_echo'.
7458
7459 * gtkutil.c (xg_maybe_add_timer):
7460 * keyboard.c (readable_events):
7461 * process.c (wait_reading_process_output):
7462 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7463
7464 * insdel.c (adjust_markers_gap_motion):
7465 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7466 (gap_left, gap_right): Don't call it.
7467
2ecf6fdb
CY
74682011-03-25 Chong Yidong <cyd@stupidchicken.com>
7469
7470 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7471 incurred during fontification.
7472
6b1f9ba4
JB
74732011-03-25 Juanma Barranquero <lekktu@gmail.com>
7474
7475 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7476 (DEFVAR_PER_BUFFER): Don't pass it.
7477
7478 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7479 (scrolling_window): Don't pass it.
7480
0f4a96b5
JB
74812011-03-25 Juanma Barranquero <lekktu@gmail.com>
7482
7483 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7484
7485 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7486 and `suffix'.
7487 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7488 of variables specific to SELinux and computation of `encoded_absname'.
7489
7490 * image.c (XPutPixel): Remove unused variable `height'.
7491
7492 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7493
7494 * unexw32.c (get_section_info): Remove unused variable `section'.
7495
7496 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7497 (system_process_attributes): Remove unused variable `sess'.
7498 (sys_read): Remove unused variable `err'.
7499
7500 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7501 (w32_wnd_proc): Remove unused variable `isdead'.
7502 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7503 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7504 (x_create_tip_frame): Remove unused variable `tem'.
7505
7506 * w32inevt.c (w32_console_read_socket):
7507 Remove unused variable `no_events'.
7508
7509 * w32term.c (x_draw_composite_glyph_string_foreground):
7510 Remove unused variable `width'.
7511
1149507c
JB
75122011-03-24 Juanma Barranquero <lekktu@gmail.com>
7513
7514 * w32term.c (x_set_glyph_string_clipping):
7515 Don't pass uninitialized region to CombineRgn.
7516
9c88f339
JB
75172011-03-23 Juanma Barranquero <lekktu@gmail.com>
7518
7519 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7520 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7521 (Fx_close_connection): Remove unused variable `i'.
7522
7523 * w32font.c (w32font_draw): Return number of glyphs.
7524 (w32font_open_internal): Remove unused variable `i'.
7525 (w32font_driver): Add missing initializer.
7526
7527 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7528 (fill_in_menu): Remove unused variable `items_added'.
7529
7530 * w32term.c (last_mouse_press_frame): Remove static global variable.
7531 (w32_clip_to_row): Remove unused variable `f'.
7532 (x_delete_terminal): Remove unused variable `i'.
7533
7534 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7535 (NOTHING): Remove unused static global variable.
7536 (uniscribe_check_otf): Remove unused variable `table'.
7537 (uniscribe_font_driver): Add missing initializers.
7538
dee091a3
JD
75392011-03-23 Julien Danjou <julien@danjou.info>
7540
7541 * term.c (Fsuspend_tty, Fresume_tty):
7542 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7543 * window.c (temp_output_buffer_show):
7544 * insdel.c (signal_before_change):
7545 * frame.c (Fhandle_switch_frame):
7546 * fileio.c (Fdo_auto_save):
7547 * emacs.c (Fkill_emacs):
7548 * editfns.c (save_excursion_restore):
7549 * cmds.c (internal_self_insert):
7550 * callint.c (Fcall_interactively):
7551 * buffer.c (Fkill_all_local_variables):
7552 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7553 Use Frun_hooks.
0f4a96b5 7554 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7555 unconditionnaly since it does the check itself.
7556
2c520ab5 75572011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7558
c9c49752
PE
7559 Fix more problems found by GCC 4.5.2's static checks.
7560
8abc3f12
PE
7561 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7562 the first time through the loop, since we know p0 < p1 then.
7563 This also avoids a gcc -Wstrict-overflow warning.
7564
a2d26660
PE
7565 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7566 leading to a memory leak, possible in functions like
7567 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7568 of objects (Bug#8318).
a2d26660 7569
916c72e9
PE
7570 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7571 that could (at least in theory) be that large.
7572
19ab8a18
PE
7573 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7574 This is less likely to overflow, and avoids undefined behavior if
7575 overflow does occur. All callers changed. Use strtoul to scan
7576 for the unsigned long integer.
b7cbbd6f
PE
7577 (pint2hrstr): Simplify and tune code slightly.
7578 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7579
f0641eff
PE
7580 * scroll.c (do_scrolling): Work around GCC bug 48228.
7581 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7582
7f650bb9
PE
7583 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7584 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7585 (validate_x_resource_name): Simplify count usage.
7586 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7587
37dd57d1
PE
7588 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7589 fail (Bug#8306).
81e56e61 7590
699979fc 7591 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7592
401bf9b4
PE
7593 * process.c (Fmake_network_process): Use socklen_t, not int,
7594 where POSIX says socklen_t is required in portable programs.
7595 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7596 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7597 (Fmake_network_process, server_accept_connection):
7598 (wait_reading_process_output, read_process_output):
7599 Likewise.
7600
b93aacde
PE
7601 * process.c: Rename or move locals to avoid shadowing.
7602 (list_processes_1, Fmake_network_process):
7603 (read_process_output_error_handler, exec_sentinel_error_handler):
7604 Rename or move locals.
4dc343ee 7605 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7606 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7607 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7608 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7609 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7610
af8a867c 7611 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7612 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7613 Include tparam.h instead, since it declares them.
af8a867c
PE
7614 * cm.h (PC): Remove extern decl; tparam.h now does this.
7615 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7616 * terminfo.c: Include tparam.h, to check interfaces.
7617 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7618 (tparam): Adjust signature to match interface in tparam.h;
7619 this removes some undefined behavior. Check that outstring and len
7620 are zero, which they always are with Emacs.
7621 * tparam.h (PC, BC, UP): New extern decls.
7622
0248044d 7623 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7624 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7625
8ff096c1 7626 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7627 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7628 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7629 (ftfont_list): Remove unused local.
49eaafba
PE
7630 (get_adstyle_property, ftfont_pattern_entity):
7631 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7632 Rename locals to avoid shadowing.
8ff096c1 7633
e2be39f6
PE
7634 * xfont.c (xfont_list_family): Mark var as initialized.
7635
c9735e30
PE
7636 * xml.c (make_dom): Now static.
7637
8f5201ae
PE
7638 * composite.c (composition_compute_stop_pos): Rename local to
7639 avoid shadowing.
b246f932
PE
7640 (composition_reseat_it): Remove unused locals.
7641 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7642 (composition_update_it): Mark var as initialized.
11b61122
PE
7643 (find_automatic_composition): Mark vars as initialized,
7644 with a FIXME (Bug#8290).
8f5201ae 7645
760fbc2c
PE
7646 character.h: Rename locals to avoid shadowing.
7647 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7648 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7649 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7650 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7651 to avoid shadowing.
7652
ff08eb85
PE
7653 * textprop.c (property_change_between_p): Remove; unused.
7654
fc7bf025
PE
7655 * intervals.c (interval_start_pos): Now static.
7656
235d7abc
PE
7657 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7658
44f230aa
SM
7659 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7660 Rename locals to avoid shadowing.
3e7d6594 7661
50060332
PE
7662 * sound.c (wav_play, au_play, Fplay_sound_internal):
7663 Fix pointer signedness.
d01f234b 7664 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7665 (wav_play): Initialize a variable to 0, to prevent undefined
7666 behavior (Bug#8278).
50060332 7667
c4fc4e30
PE
7668 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7669
918436ed
PE
7670 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7671
c939f91b
PE
7672 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7673 clobbering (Bug#8298).
b9c7f648
PE
7674 * sysdep.c (sys_subshell): Likewise.
7675 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7676
6bd8c144
PE
7677 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7678 This should get cleaned up, so that child_setup has the
7679 same signature on all platforms.
7680
7710357c 7681 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7682 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7683
c59da222
CY
76842011-03-22 Chong Yidong <cyd@stupidchicken.com>
7685
7686 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7687 not to be necessary, and produces flickering.
7688
66b87493
GM
76892011-03-20 Glenn Morris <rgm@gnu.org>
7690
7691 * config.in: Remove file.
7692
45b6f6d5
JB
76932011-03-20 Juanma Barranquero <lekktu@gmail.com>
7694
7695 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7696 are now in src/globals.h.
7697 (syms_of_minibuf): Remove spurious & from previous change.
7698
3ec03f7e
LL
76992011-03-20 Leo <sdl.web@gmail.com>
7700
7701 * minibuf.c (completing-read-function): New variable.
7702 (completing-read-default): Rename from completing-read.
7703 (completing-read): Call completing-read-function.
7704
b14e3e21
CY
77052011-03-19 Juanma Barranquero <lekktu@gmail.com>
7706
7707 * xfaces.c (Fx_load_color_file):
7708 Read color file from absolute filename (bug#8250).
7709
f2b726e6
JB
77102011-03-19 Juanma Barranquero <lekktu@gmail.com>
7711
7712 * makefile.w32-in: Update dependencies.
7713
09f6ff02
EZ
77142011-03-17 Eli Zaretskii <eliz@gnu.org>
7715
7716 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7717
29a6015a
PE
77182011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7719
a3a6c54e
PE
7720 Fix more problems found by GCC 4.5.2's static checks.
7721
b766f867
PE
7722 * process.c (make_serial_process_unwind, send_process_trap):
7723 (sigchld_handler): Now static.
7724
be02381c
PE
7725 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7726 That way, the code declares only the vars that it needs.
7727 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7728 * s/cygwin.h (PTY_ITERATION): Likewise.
7729 * s/darwin.h (PTY_ITERATION): Likewise.
7730 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7731
57048744
PE
7732 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7733 * process.c (allocate_pty): Don't declare stb unless it's needed.
7734
7914961c 7735 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7736 (CONSTANTLIM): Remove; unused.
7737 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7738 Define only if needed.
7914961c 7739
b3967b18
PE
7740 * unexelf.c (unexec): Name an expression,
7741 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7742 Use a different way to cause a compilation error if anyone uses
7743 n rather than nn, a way that does not involve shadowing.
73366a00 7744 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7745
29a6015a
PE
7746 * deps.mk (unexalpha.o): Remove; unused.
7747
43cfc33e 7748 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7749 * unexec.h: New file.
ce701a33
PE
7750 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7751 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7752 Depend on unexec.h.
7753 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7754 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7755 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7756 Change as necessary to match prototype in unexec.h.
ce701a33 7757
01f44d5a
PE
7758 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7759 shadowing.
4f63c6bb 7760 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7761
a6670b0b
PE
7762 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7763 Rename locals to avoid shadowing.
7764
cef2010d 7765 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7766 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7767
d4d7173a
PE
7768 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7769
f08b802a
PE
7770 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7771 warning when compiling print.c.
7772
3ddb0639
PE
7773 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7774 instead of using an uninitialized var.
5ad03b97 7775 (font_sort_entities): Mark var as initialized.
3ddb0639 7776
170a2692
PE
7777 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7778
e663c700
PE
7779 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7780 pointers to constants.
89bc529a 7781 (font_parse_fcname): Remove unused vars.
7b81e2d0 7782 (font_delete_unmatched): Now static.
ea838e10 7783 (font_get_spec): Remove; unused.
13a547c6
PE
7784 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7785 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7786 Rename or move locals to avoid shadowing.
e663c700 7787
2a80c887 7788 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7789 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7790
1384fa33 7791 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7792 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7793
8b2c52e9
PE
7794 * alloc.c (mark_backtrace): Move decl from here ...
7795 * lisp.h: ... to here, so that it can be checked.
7796
475545b5 7797 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7798 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7799 (lisp_indirect_variable): Name an expression,
7800 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7801 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7802
b1349114 7803 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7804 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7805 Use const pointer when appropriate.
b1349114 7806
a2928364
PE
7807 * lisp.h (get_system_name, get_operating_system_release):
7808 Move decls here, to check interfaces.
7809 * process.c (get_operating_system_release): Move decl to lisp.h.
7810 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7811 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7812 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7813 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7814 (Fformat_time_string, Fencode_time, Finsert_char):
7815 (Ftranslate_region_internal, Fformat):
7816 Rename or remove local vars to avoid shadowing.
9710023e 7817 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7818
a415e694
PE
7819 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7820 avoid shadowing.
7821
8ef4622d
PE
7822 * lisp.h (eassert): Check that the argument compiles, even if
7823 ENABLE_CHECKING is not defined.
7824
946f9a5b
PE
7825 * data.c (Findirect_variable): Name an expression, to avoid
7826 gcc -Wbad-function-cast warning.
112396d6 7827 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7828 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7829 (Fmake_variable_buffer_local, Fmake_local_variable):
7830 Mark variables as initialized.
52746918 7831 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7832
e5aab7e7 7833 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7834 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7835 Rename locals to avoid shadowing.
dff45157
PE
7836 (mark_stack): Move local variables into the #ifdef region where
7837 they're used.
7bc26fdb
PE
7838 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7839 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7840 needed otherwise.
7841 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7842 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7843 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7844
e5aab7e7
PE
7845 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7846 avoids undefined behavior in theory.
7847
4da60324
PE
7848 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7849
88043301
PE
7850 Use functions, not macros, for up- and down-casing (Bug#8254).
7851 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7852 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7853 to use the following functions instead of these macros.
7854 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7855 EMACS_INT, since callers assume the returned value fits in int.
7856 (upcase1): Likewise, for UPCASE_TABLE.
7857 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7858 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7859 the race-condition problem in the old DOWNCASE.
88043301 7860
19ed5445
PE
7861 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7862 Rename locals to avoid shadowing.
7863 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7864 (regex_compile, re_search_2, re_match_2_internal):
7865 Remove unused local vars.
952db0d7
PE
7866 (FREE_VAR): Rewrite so as not to use empty "else",
7867 which gcc can warn about.
da053e48 7868 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7869 (RETALLOC_IF): Define only if needed.
7870 (WORDCHAR_P): Likewise. This one is never needed, but is used
7871 only in a comment talking about a compiler bug, so put inside
7872 the #if 0 of that comment.
7873 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7874 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7875 Remove; unused.
19ed5445 7876
1f3561e4 7877 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7878 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7879 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7880
ded6f8f7
PE
7881 * search.c (simple_search): Remove unused var.
7882
dbd37a95
PE
7883 * dired.c (compile_pattern): Move decl from here ...
7884 * lisp.h: ... to here, so that it can be checked.
7885 (struct re_registers): New forward decl.
7886
7e47afad
PE
7887 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7888
85f24f61
PE
7889 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7890 All uses changed.
7891 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7892 Rename locals to avoid shadowing.
5671df8f 7893 (Fvertical_motion): Mark locals as initialized.
85f24f61 7894
181aa2be 7895 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7896 (casify_region): Mark local as initialized.
181aa2be 7897
930d429c
PE
7898 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7899
7082eac6
PE
7900 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7901 New macros, so that the caller can use some names other than
7902 gcpro1, gcpro2, etc.
7903 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7904 of the new macros.
7905 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7906 argument, for consistency with GCPRO2_VAR, etc: it is now the
7907 prefix of the variable, not the variable itself. All uses
7908 changed.
38b2c076
PE
7909 * dired.c (directory_files_internal, file_name_completion):
7910 Rename locals to avoid shadowing.
7911
15206ed9
PE
7912 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7913 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7914 dired.c's scmp function, had undefined behavior.
7915 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7916 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7917 * buffer.h: ... to here, because these macros use current_buffer,
7918 and the new implementation with inline functions needs to have
7919 current_buffer in scope now, rather than later when the macros
7920 are used.
7921 (downcase, upcase1): New static inline functions.
7922 (DOWNCASE, UPCASE1): Reimplement using these functions.
7923 This avoids undefined behavior in expressions like
7924 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7925 from race conditions in accessing the global variables
7926 case_temp1 and case_temp2.
7927 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7928 * lisp.h (case_temp1, case_temp2): Remove their decls.
7929 * character.h (ASCII_CHAR_P): Move from here ...
7930 * lisp.h: ... to here, so that the inline functions mentioned
7931 above can use them.
7932
4a6bea26
PE
7933 * dired.c (directory_files_internal_unwind): Now static.
7934
f14b7e14
PE
7935 * fileio.c (file_name_as_directory, directory_file_name):
7936 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7937 Now static.
2893f146
PE
7938 (file_name_as_directory): Use const pointers when appropriate.
7939 (Fexpand_file_name): Likewise. In particular, newdir might
7940 point at constant storage, so make it a const pointer.
fd4ead52 7941 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7942 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7943 signedness issues.
f839df0c
PE
7944 (Fset_file_times, Finsert_file_contents, auto_save_error):
7945 Rename locals to avoid shadowing.
f14b7e14 7946
5716756e 7947 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7948 (Ftry_completion, Fall_completions): Rename or remove locals
7949 to avoid shadowing.
5716756e 7950
b4c3046a
PE
7951 * marker.c (bytepos_to_charpos): Remove; unused.
7952
b45db522
PE
7953 * lisp.h (verify_bytepos, count_markers): New decls,
7954 so that gcc does not warn that these functions aren't declared.
7955
85876d07
PE
7956 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7957 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7958 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7959 (copy_text): Remove unused local var.
85876d07 7960
03d78a21 7961 * filelock.c (within_one_second): Now static.
b3dd38ab 7962 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7963
5df8f01b
PE
7964 * buffer.c (fix_overlays_before): Mark locals as initialized.
7965 (fix_start_end_in_overlays): Likewise. This function should be
7966 simplified by using pointers-to-pointers, but that's a different
7967 matter.
b1d876f1 7968 (switch_to_buffer_1): Now static.
8f54f30a
PE
7969 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7970 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7971
a70072c9 7972 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7973 Fix pointer signedness issue.
edced198
PE
7974 (sys_subshell): Mark local as volatile if checking for lint,
7975 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7976 (MAXPATHLEN): Define only if needed.
a70072c9 7977
a0977c44
PE
7978 * process.c (serial_open, serial_configure): Move decls from here ...
7979 * systty.h: ... to here, so that they can be checked.
7980
a884fdcc
PE
7981 * fns.c (get_random, seed_random): Move extern decls from here ...
7982 * lisp.h: ... to here, so that they can be checked.
7983
604efe86 7984 * sysdep.c (reset_io): Now static.
b8950c94 7985 (wait_for_termination_signal): Remove; unused.
604efe86 7986
38fc62d9
PE
7987 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7988 (copy_keymap_item, append_key, push_text_char_description):
7989 Now static.
1004a21a 7990 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7991 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7992 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7993 (describe_map_tree):
7994 Rename locals to avoid shadowing.
38fc62d9 7995
2f2650da
PE
7996 * keyboard.c: Declare functions static if they are not used elsewhere.
7997 (echo_char, echo_dash, cmd_error, top_level_2):
7998 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7999 (read_char, kbd_buffer_get_event, make_lispy_position):
8000 (make_lispy_event, make_lispy_movement, apply_modifiers):
8001 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8002 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8003 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8004 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8005 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8006
a053e86c 8007 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8008 (mark_kboards): Move decl here ...
8009 * alloc.c (mark_kboards): ... from here.
a053e86c 8010
4752793e
PE
8011 * lisp.h (force_auto_save_soon): New decl.
8012
74f10ca7 8013 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8014 (DEFINE_DUMMY_FUNCTION): New macro.
8015 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8016 Use it.
c03cd23f
PE
8017 (main): Add casts to avoid warnings
8018 if GCC considers string literals to be constants.
74f10ca7 8019
022e70d4
PE
8020 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8021
59d6fe83
PE
8022 * dbusbind.c: Pointer signedness fixes.
8023 (xd_signature, xd_append_arg, xd_initialize):
8024 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8025 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8026 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8027 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8028
78320123
PE
8029 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8030 if GCC considers string literals to be constants.
49cebcca 8031 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8032
35ac2a97
SM
80332011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8034
fb103ca9
SM
8035 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8036 (print_preprocess, print_object): New macro to fix last change.
8037
35ac2a97
SM
8038 * print.c (print_preprocess): Don't forget font objects.
8039
62973b41
JB
80402011-03-16 Juanma Barranquero <lekktu@gmail.com>
8041
8042 * emacs.c (USAGE3): Doc fixes.
8043
0e48bb22
AS
80442011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8045
8046 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8047 structure.
8048
7684e57b
JB
80492011-03-14 Juanma Barranquero <lekktu@gmail.com>
8050
8051 * lisp.h (VWindow_system, Qfile_name_history):
8052 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8053 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8054 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8055
8056 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8057 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8058
8059 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8060 * w32console.c (detect_input_pending, read_input_pending)
8061 (encode_terminal_code):
8062 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8063 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8064 (w32_system_caret_y, Qfile_name_history):
8065 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8066 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8067 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8068 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8069 * w32proc.c (Qlocal, report_file_error):
8070 * w32term.c (Vwindow_system, updating_frame):
8071 * w32uniscribe.c (initialized, uniscribe_font_driver):
8072 Remove unneeded extern declarations.
8073
2aa46d6c
CY
80742011-03-14 Chong Yidong <cyd@stupidchicken.com>
8075
c96bbc66 8076 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8077
cffc6f3b
CY
80782011-03-13 Chong Yidong <cyd@stupidchicken.com>
8079
8080 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8081 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8082 These macros can no longer be used for assignment.
8083
44f230aa
SM
8084 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8085 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8086 (record_buffer_markers, fetch_buffer_markers): New functions for
8087 recording and fetching special buffer markers.
8088 (set_buffer_internal_1, set_buffer_temp): Use them.
8089
8090 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8091
8092 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8093
8094 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8095 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8096
8097 * xdisp.c (hscroll_window_tree):
8098 (reconsider_clip_changes): Use PT instead of BUF_PT.
8099
d251f04b
EZ
81002011-03-13 Eli Zaretskii <eliz@gnu.org>
8101
8102 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8103 $(EMACS_ROOT)/lib/intprops.h.
8104
f0c77cd1
PE
81052011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8106
3eca4629
PE
8107 Fix more problems found by GCC 4.5.2's static checks.
8108
7c86ee98
PE
8109 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8110 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8111 (xg_free_frame_widgets): Make it clear that a local variable is
8112 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8113 (gdk_window_get_screen): Make it clear that this macro is needed
8114 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8115 (int_gtk_range_get_value): New function, which avoids a diagnostic
8116 from gcc -Wbad-function-cast.
8117 (xg_set_toolkit_scroll_bar_thumb): Use it.
8118 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8119 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8120 (get_utf8_string, xg_get_file_with_chooser):
8121 Rename locals to avoid shadowing.
8122 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8123
41729b81
PE
8124 * xgselect.c (xg_select): Remove unused var.
8125
f0c77cd1
PE
8126 * image.c (four_corners_best): Mark locals as initialized.
8127 (gif_load): Initialize transparent_p to zero (Bug#8238).
8128 Mark another local as initialized.
ec6cf4c6 8129 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8130
ce0ad53d 8131 * image.c (clear_image_cache): Now static.
d5d5a617 8132 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8133 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8134 (x_edge_detection): Remove unnecessary cast that
8135 gcc -Wbad-function-cast diagnoses.
2037898d 8136 (gif_load): Fix pointer signedness.
6ae141d6
PE
8137 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8138 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8139
33383987 81402011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8141
d32df629
PE
8142 Improve quality of tests for time stamp overflow.
8143 For example, without this patch (encode-time 0 0 0 1 1
8144 1152921504606846976) returns the obviously-bogus value (-948597
8145 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8146 reports time overflow. See
8147 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8148 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8149 * editfns.c: Include limits.h and intprops.h.
8150 (TIME_T_MIN, TIME_T_MAX): New macros.
8151 (time_overflow): Move earlier, to before first use.
8152 (hi_time, lo_time): New functions, for an accurate test for
8153 out-of-range times.
8154 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8155 (Fget_internal_run_time): Don't assume time_t fits in int.
8156 (make_time): Use list2 instead of Fcons twice.
8157 (Fdecode_time): More accurate test for out-of-range times.
8158 (check_tm_member): New function.
8159 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8160 (lisp_time_argument): Don't rely on undefined left-shift and
8161 right-shift behavior when checking for time stamp overflow.
8be6f318 8162
fe31d94c
PE
8163 * editfns.c (time_overflow): New function, refactoring common code.
8164 (Fformat_time_string, Fdecode_time, Fencode_time):
8165 (Fcurrent_time_string): Use it.
8166
8be6f318
PE
8167 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8168 * dired.c (make_time): Move to ...
8169 * editfns.c (make_time): ... here.
8170 * systime.h: Note the move.
8171
09d9db2c 81722011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8173
126bc0dc
YM
8174 * fringe.c (update_window_fringes): Remove unused variables.
8175
c47cbdfd
YM
8176 * unexmacosx.c (copy_data_segment): Also copy __got section.
8177 (Bug#8223)
8178
7ac80be9
EZ
81792011-03-12 Eli Zaretskii <eliz@gnu.org>
8180
c96bbc66 8181 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8182 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8183 Constify `char *' arguments and their references according to
8184 prototypes in tparam.h.
8185
ecb0f94d 8186 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8187
7ac80be9
EZ
8188 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8189 Adapt all references accordingly.
8190
8191 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8192
ef1fd07e
TT
81932011-03-11 Tom Tromey <tromey@redhat.com>
8194
8195 * buffer.c (syms_of_buffer): Remove obsolete comment.
8196
7ef4b50c
EZ
81972011-03-11 Eli Zaretskii <eliz@gnu.org>
8198
8199 * termhooks.h (encode_terminal_code): Declare prototype.
8200
8201 * msdos.c (encode_terminal_code): Don't declare prototype.
8202
8203 * term.c (encode_terminal_code): Now external again, used by
8204 w32console.c and msdos.c.
8205
44f230aa
SM
8206 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8207 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8208
4b1ec863 82092011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8210
1714f52b 8211 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8212
4b1ec863
PE
8213 * fringe.c (update_window_fringes): Mark locals as initialized
8214 (Bug#8227).
8215 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8216
524c7aa6
PE
8217 * alloc.c (mark_fringe_data): Move decl from here ...
8218 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8219 to check its interface.
8220 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8221
a5c0af81 8222 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8223 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8224 (fontset_font): Mark local as initialized.
a9a06e0b 8225 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8226
b4716021
PE
8227 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8228
811e9bac 8229 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8230 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8231 (x_own_selection, Fx_disown_selection_internal): Rename locals
8232 to avoid shadowing.
8233 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8234
7e3ab302
PE
8235 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8236 so that the caller can use some name other than gcpro1.
8237 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8238 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8239 (Fx_backspace_delete_keys_p):
8240 Use them to avoid shadowing, and rename vars to avoid shadowing.
8241 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8242 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8243 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8244 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8245 Remove unused locals.
7e3ab302
PE
8246 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8247 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8248 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8249 macros.
f78faa98 8250
e2b13473
PE
8251 * xterm.h (x_mouse_leave): New decl.
8252
77f23912
PE
8253 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8254 Remove unused functions.
cdf4ba58
PE
8255 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8256 (x_calc_absolute_position): Now static.
7411c686 8257 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8258 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8259 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8260 unless they are used.
38d0b34a
PE
8261 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8262 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8263 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8264 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8265 (x_error_catcher, x_connection_closed, x_error_handler):
8266 (x_error_quitter, xembed_send_message, x_iconify_frame):
8267 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8268 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8269 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8270
44f230aa
SM
8271 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8272 Rename or move locals to avoid shadowing.
6b463e58 8273 (tty_defined_color, merge_face_heights): Now static.
5967d051 8274 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8275 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8276 does not deduce is never used uninitialized.
73719eba
PE
8277 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8278 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8279
426994c3 8280 * terminal.c (store_terminal_param): Now static.
5489860b 8281
032f1620 8282 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8283 (set_frame_menubar): Remove unused local.
d4323972 8284 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8285 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8286 since they might point to immutable storage.
281585b0
PE
8287 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8288 since it's unused otherwise.
032f1620 8289
367c19e5 8290 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8291 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8292 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8293 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8294 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8295 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8296 does not deduce are never used uninitialized.
70739cbe 8297
07b48fa9
PE
8298 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8299
8868a238 8300 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8301 * window.c (window_loop, size_window):
8302 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8303
7e5cf297 8304 * window.c (display_buffer): Now static.
d6550a9f
PE
8305 (size_window): Mark variables that gcc -Wuninitialized
8306 does not deduce are never used uninitialized.
a586633d
PE
8307 * window.h (check_all_windows): New decl, to forestall
8308 gcc -Wmissing-prototypes diagnostic.
5b555da1 8309 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8310
f6095868
PE
8311 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8312 shadowing.
8313 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8314 Include <limits.h>.
8315 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8316 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8317 (load_charset_map): Mark variables that gcc -Wuninitialized
8318 does not deduce are never used uninitialized.
53df7c11 8319 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8320
f38b440c
PE
8321 * coding.c (coding_set_source, coding_set_destination):
8322 Use "else { /* comment */ }" rather than "else /* comment */;"
8323 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8324 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8325 a block, when the outer 'i' will do.
8326 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8327 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8328 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8329 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8330 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8331 Rename locals to avoid shadowing.
8332 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8333 * coding.c (emacs_mule_char, encode_invocation_designation):
8334 Now static, since they're not used elsewhere.
413bb2db 8335 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8336 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8337 (decode_coding_emacs_mule): Mark variables that gcc
8338 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8339 (detect_coding_iso_2022): Initialize a local variable that might
8340 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8341 this initialization is needed. (Bug#8211)
5f58e762
PE
8342 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8343 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8344 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8345 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8346 Remove unused macros.
f38b440c 8347
232b38b9 8348 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8349 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8350 * character.c (string_count_byte8): Likewise.
232b38b9 8351
fb90da1b
PE
8352 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8353 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8354
fb93dbc2
PE
8355 * chartab.c (copy_sub_char_table): Now static, since it's not used
8356 elsewhere.
5c156ace
PE
8357 (sub_char_table_ref_and_range, char_table_ref_and_range):
8358 Rename locals to avoid shadowing.
bbcd0949 8359 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8360
7d3b3862 8361 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8362 (BIDI_BOB): Remove unused macro.
7d3b3862 8363
6be7d3da
PE
8364 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8365 deduce are never used uninitialized.
c2ed9c8b 8366 * term.c (encode_terminal_code): Likewise.
6be7d3da 8367
75f8807f 8368 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8369
50938595
PE
8370 * tparam.h: New file.
8371 * term.c, tparam.h: Include it.
8372 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8373 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8374 Move these decls to tparam.h, and make them agree with what
8375 is actually in tparam.c. The previous trick of using incompatible
8376 decls in different modules does not conform to the C standard.
8377 All callers of tparam changed to use tparam's actual API.
8378 * tparam.c (tparam1, tparam, tgoto):
8379 Use const pointers where appropriate.
8380
fbceeba2
PE
8381 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8382 * cm.h (struct cm): Likewise.
8383 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8384 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8385 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8386 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8387 (turn_on_face, init_tty): Likewise.
8388 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8389
7f3f1250
PE
8390 * term.c (term_mouse_position): Rename local to avoid shadowing.
8391
e6ca6543
PE
8392 * alloc.c (mark_ttys): Move decl from here ...
8393 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8394
c40f8d15
AS
83952011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8396
8397 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8398
cfe0661d
JB
83992011-03-09 Juanma Barranquero <lekktu@gmail.com>
8400
8401 * search.c (compile_pattern_1): Remove argument regp, unused since
8402 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8403 (compile_pattern): Don't pass it.
8404
0afb4571
J
84052011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8406
8407 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8408 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8409 for ! HAVE_GTK3.
8410 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8411
8412 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8413
8414 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8415 gdk_window_get_screen, gdk_window_get_geometry,
8416 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8417 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8418 (xg_get_pixbuf_from_pixmap): New function.
8419 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8420 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8421 Call xg_get_pixbuf_from_pixmap instead of
8422 gdk_pixbuf_get_from_drawable.
8423 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8424 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8425 (xg_check_special_colors): Use GtkStyleContext and its functions
8426 for HAVE_GTK3.
8427 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8428 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8429 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8430 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8431 Call gtk_widget_get_preferred_size.
0afb4571
J
8432 (xg_frame_resized): gdk_window_get_geometry only takes 5
8433 parameters.
44f230aa
SM
8434 (xg_win_to_widget, xg_event_is_for_menubar):
8435 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8436 (xg_set_widget_bg): New function.
8437 (delete_cb): New function.
895009e1 8438 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8439 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8440 (xg_set_background_color): Call xg_set_widget_bg.
8441 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8442 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8443 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8444 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8445 if ! HAVE_GTK3.
8446 (update_frame_tool_bar): Call gtk_widget_hide.
8447 (xg_initialize): Use GDK_KEY_g.
8448
8449 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8450 if ! HAVE_GTK3
8451 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8452
8453 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8454 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8455 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8456
1c2cc4ef
JB
84572011-03-08 Juanma Barranquero <lekktu@gmail.com>
8458
8459 * w32xfns.c (select_palette): Check success of RealizePalette against
8460 GDI_ERROR, not zero.
8461
33383987 8462See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8463
8464;; Local Variables:
8465;; coding: utf-8
aac0c6e3
MR
8466;; End:
8467
33383987 8468 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8469
8470 This file is part of GNU Emacs.
8471
8472 GNU Emacs is free software: you can redistribute it and/or modify
8473 it under the terms of the GNU General Public License as published by
8474 the Free Software Foundation, either version 3 of the License, or
8475 (at your option) any later version.
8476
8477 GNU Emacs is distributed in the hope that it will be useful,
8478 but WITHOUT ANY WARRANTY; without even the implied warranty of
8479 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8480 GNU General Public License for more details.
8481
8482 You should have received a copy of the GNU General Public License
8483 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.