Revert problematic change to wait_reading_process_output.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
83ed7b5c
GM
12011-10-29 Glenn Morris <rgm@gnu.org>
2
3 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4 Not clear what it was for, and it causes various bugs. (Bug#9839)
5
5a7a728b
EZ
62011-10-28 Eli Zaretskii <eliz@gnu.org>
7
8 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
9 possible random value that matches one of those tested as
10 condition to clear the mouse face.
11
d3d0842f
CY
122011-10-28 Chong Yidong <cyd@gnu.org>
13
14 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
15
31b39d13
DN
162011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
17
18 * window.c (make_window): Initialize phys_cursor_on_p.
19
9aba6043
SM
202011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
21
22 * lisp.h (struct Lisp_Symbol): Update comments.
23
c20992f4
JB
242011-10-28 Juanma Barranquero <lekktu@gmail.com>
25
26 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
27
db4f02f2
EZ
282011-10-28 Eli Zaretskii <eliz@gnu.org>
29
30 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
31 <oslsachem@gmail.com> for helping to debug this.
32
33 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
34 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
35 (g_b_init_get_glyph_outline_w): New static variables.
36 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
37 (GetGlyphOutlineW_Proc): New typedefs.
38 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
39 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
40 New functions.
41 (w32font_open_internal, compute_metrics):
42 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
43 instead of calling the "wide" APIs directly.
44
45 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
46
47 * w32.h (syms_of_w32font): Add prototype.
48
87e68db4
JB
492011-10-27 Juanma Barranquero <lekktu@gmail.com>
50
51 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
52 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
53 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
54 (Fmove_to_window_line): Doc fix.
55
435c1d67
CY
562011-10-27 Chong Yidong <cyd@gnu.org>
57
58 * process.c (make_process): Set gnutls_state to NULL.
59
60 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
61 non-NULL, regardless of GNUTLS_INITSTAGE.
62 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
63 an error. Set process slots as soon as we allocate them.
64
65 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
66
9c6c6f49
CY
672011-10-27 Chong Yidong <cyd@gnu.org>
68
9aba6043
SM
69 * gnutls.c (emacs_gnutls_deinit): New function.
70 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
71 (Fgnutls_deinit, Fgnutls_boot): Use it.
72
73 * process.c (make_process): Initialize GnuTLS credentials to NULL.
74 (deactivate_process): Call emacs_gnutls_deinit.
75
657d08d3
JB
762011-10-27 Juanma Barranquero <lekktu@gmail.com>
77
78 * image.c (x_create_x_image_and_pixmap):
79 * w32.c (sys_rename, w32_delayed_load):
80 * w32font.c (fill_in_logfont):
81 * w32reg.c (x_get_string_resource): Silence compiler warnings.
82
5430d399
JB
832011-10-26 Juanma Barranquero <lekktu@gmail.com>
84
85 * w32fns.c (w32_default_color_map): New function,
86 extracted from Fw32_default_color_map.
a7ef684b 87 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 88
fe0055fa
PE
892011-10-25 Paul Eggert <eggert@cs.ucla.edu>
90
91 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
92
e6346438
SM
932011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
94
95 * keyboard.c (test_undefined): New function (bug#9751).
96 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
97
e112cc37
ET
982011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
99
100 * sysdep.c (init_sys_modes): Fix the check for the controlling
101 terminal (Bug#6649).
102
7b5d6677
EZ
1032011-10-20 Eli Zaretskii <eliz@gnu.org>
104
105 * dispextern.h (struct bidi_it): New member next_en_type.
106
107 * bidi.c (bidi_line_init): Initialize the next_en_type member.
108 (bidi_resolve_explicit_1): When next_en_pos is valid for the
109 current character, check also for next_en_type being WEAK_EN.
110 (bidi_resolve_weak): Don't enter the expensive loop if the current
111 position is before next_en_pos. Record the bidi type of the first
112 non-ET, non-BN character we find, in addition to its position.
113 (bidi_level_of_next_char): Invalidate next_en_type when
114 next_en_pos is over-stepped.
115
7da0b018
PE
1162011-10-20 Paul Eggert <eggert@cs.ucla.edu>
117
118 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
119 * editfns.c: Rewrite current-time-zone so that it invokes
120 the equivalent of (format-time-string "%Z") to get the time zone name.
121 This fixes a bug when the time zone name contains characters that
122 need converting from the system time locale to Emacs internal format.
123 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
124 that patch fixed format-time-string to do the conversion, but
125 I forgot to fix current-time-zone.
126 (format_time_string): New function, containing most of
127 what Fformat_time_string used to contain.
128 (Fformat_time_string): Rewrite in terms of format_time_string.
129 This doesn't change this function's behavior.
130 (current-time-zone): Rewrite to use format_time_string.
131 This fixes the bug reported by Michael Schierl in
132 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
133 Jason Rumney's 2007-06-07 change worked around this bug, but
134 didn't fix it.
135 * systime.h (tzname, timezone): Remove no-longer-used declarations.
136
8547b010
EZ
1372011-10-19 Eli Zaretskii <eliz@gnu.org>
138
139 * xdisp.c (start_display): If the character at POS is displayed
140 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
141 (try_window_reusing_current_matrix): If a line ends in a display
142 vector or the next line starts in a display vector, continue
143 redrawing the window even though the character position of
144 start_row was reached.
8547b010
EZ
145 (Bug#9771, part 2)
146
4e948d15
CY
1472011-10-18 Chong Yidong <cyd@gnu.org>
148
149 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
150 with nobreak-char-display too.
151
4787455f
EZ
1522011-10-18 Eli Zaretskii <eliz@gnu.org>
153
154 Fix part 3 of bug#9771.
155 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
156 (bidi_resolve_neutral): Don't enter the expensive loop looking for
157 non-neutral characters if the current character is a paragraph
158 separator (a.k.a. Newline). This avoids running the same
159 expensive loop twice, once when we consume the preceding newline
160 and the other time when the line actually needs to be displayed.
161 Avoid the loop when we see neutrals on the base embedding level
162 following a character whose directionality is the same as the
163 paragraph's. This avoids running the expensive loop when a line
164 ends in a long sequence of neutrals, like control characters.
165 Add assertion against STRONG_AL type. Slightly rearrange code
166 that determines the type of a neutral given the first non-neutral
167 that follows it.
168 (bidi_level_of_next_char): Set next_en_pos to zero when
169 invalidating its info.
170
2c91f553
EZ
1712011-10-17 Eli Zaretskii <eliz@gnu.org>
172
173 * xdisp.c (push_display_prop): Determine whether to record string
174 or buffer position by IT->string, not by IT->method. Allow
175 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
176 (move_it_vertically_backward): Don't look for character position
177 immediately after the newline when in a continuation line.
178 (Bug#9771, part 1)
2c91f553 179
c7b08b0d
MR
1802011-10-15 Martin Rudalics <rudalics@gmx.at>
181
182 * window.c (coordinates_in_window): Rewrite and delabelize
183 vertical border check. (Bug#5357) (Bug#9618)
184
6b02f655
SM
1852011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
186
187 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
188 errors in XSetWindowBorder (bug#9310).
189
81d40c92
DA
1902011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
191
192 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
193 avoid crash when xmalloc overrun checking is enabled.
194
d4172c3b
EZ
1952011-10-13 Eli Zaretskii <eliz@gnu.org>
196
197 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
198 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
199 cursor motion with <left> and <right> arrow keys.
200
201 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
202 some callers set that themselves.
203
b00eea75
EZ
2042011-10-12 Eli Zaretskii <eliz@gnu.org>
205
206 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
207 display string and the previous row comes from the same string and
208 is empty. (Bug#9739) (Bug#9738)
209
8fe012c4
SM
2102011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
211
212 * doc.c (get_doc_string): Encode file name (bug#9735).
213
0074aef2
EZ
2142011-10-12 Eli Zaretskii <eliz@gnu.org>
215
79beb178
EZ
216 * bidi.c (bidi_level_of_next_char):
217 * xdisp.c (get_visually_first_element): Remove old incorrect
218 comments regarding the Unicode Line Separator character.
219
0074aef2
EZ
220 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
221
6e4b3fbe
DA
2222011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
223
224 * alloc.c (Fgc_status): Do not access beyond zombies array
225 boundary if nzombies > MAX_ZOMBIES.
226 * alloc.c (dump_zombies): Add missing format specifier.
227
0324f3af
PE
2282011-10-12 Paul Eggert <eggert@cs.ucla.edu>
229
b5525cac
PE
230 * xdisp.c (set_cursor_from_row): Simplify conditionals,
231 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
232
0324f3af
PE
233 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
234 Some packages use them to denote characters with modifiers.
235
e9b5f888
AS
2362011-10-11 Andreas Schwab <schwab@linux-m68k.org>
237
238 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
239 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
240 matching a pp-number. Rename parameter var to var1.
241
127827c0
SM
2422011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
243
244 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
245
c8fd3bd0
GM
2462011-10-08 Glenn Morris <rgm@gnu.org>
247
248 * callint.c (Fcall_interactively): Give a more explicit error for the
249 'c' case with a non-character input. (Bug#8479)
250
352ec8ff
EZ
2512011-10-08 Eli Zaretskii <eliz@gnu.org>
252
03669ccb
EZ
253 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
254 lines.
7061c986
EZ
255 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
256 lines that are hscrolled on the left.
03669ccb 257
352ec8ff
EZ
258 * dispnew.c (buffer_posn_from_coords): Account for a possible
259 presence of header-line. (Bug#4426)
260
a66cfb1c
SM
2612011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
262
6b02f655
SM
263 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
264 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 265
7c5ee88e
PE
2662011-10-07 Paul Eggert <eggert@cs.ucla.edu>
267
268 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
269 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
270 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
271 this makes Emacs dump core during garbage collection on rare
272 occasions. sizeof is obviously inferior to offsetof here, so
273 stick with offsetof.
274 (GC_POINTER_ALIGNMENT): New macro.
275 (mark_memory): Omit 3rd (offset) arg; caller changed.
276 Don't assume EMACS_INT alignment is the same as pointer alignment.
277
df1bbe5b
SM
2782011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
279
280 * keyboard.c (read_key_sequence_remapped): New var.
281 (read_key_sequence): Compute remapping in the right buffer.
282 (command_loop_1): Use read_key_sequence's remapping directly.
283
51553db6
SM
2842011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
285
32c1fffd
SM
286 * dired.c (file_name_completion): Don't expand file name.
287 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
288 before checking file name handler.
289
51553db6
SM
290 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
291 they've been requested explicitly (bug#9591).
292
b6bd1599 2932011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
294
295 * keymap.c (Fsingle_key_description): Use make_specified_string
296 instead of build_string to build string from push_key_description.
297 (Bug#5193)
298
f701dc2a
PE
2992011-09-30 Paul Eggert <eggert@cs.ucla.edu>
300
4222c55d
PE
301 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
302 This fixes a Y2038 bug on 64-bit hosts.
303 * buffer.c (reset_buffer):
304 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
305 (Fclear_buffer_auto_save_failure):
306 Use 0, not -1, to represent an unset failure time, since time_t
307 might not be signed.
308
f701dc2a
PE
309 Remove dependency on glibc malloc internals.
310 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
311 Move back here from lisp.h, but with their new implementations.
312 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
313 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
314 * charset.c (charset_table_init): New static var.
315 (syms_of_charset): Use it instead of xmalloc. This removes a
316 dependency on glibc malloc internals. See Eli Zaretskii's comment in
317 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
318 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
319 Move back to alloc.c.
320 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
321 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
322
9ceebf39
JD
3232011-09-30 Jan Djärv <jan.h.d@swipnet.se>
324
325 * nsterm.m (windowDidResize): Call x_set_window_size only when
326 ns_in_resize is true. Otherwise set pixelwidth/height and
327 call change_frame_size (Bug#9628).
328
cb993c58
PE
3292011-09-30 Paul Eggert <eggert@cs.ucla.edu>
330
3930c88b
PE
331 Port --enable-checking=all to Fedora 14 x86-64.
332 * charset.c (syms_of_charset): Also account for glibc malloc's
333 internal overhead when calculating the initial malloc maximum.
334
cb993c58
PE
335 Port --enable-checking=all to Fedora 14 x86.
336 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
337 Move to lisp.h.
338 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
339 (overrun_check_realloc, overrun_check_free):
340 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
341 That way, xmalloc returns a properly-aligned pointer even if
342 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
343 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
344 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
345 into account when calculating the initial malloc maximum.
346 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
347 Move here from alloc.c, so that charset.c can use it too.
348 Properly align; the old code wasn't right for common 32-bit hosts
349 when configured with --enable-checking=all.
350 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
351 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
352
31bed486
EZ
3532011-09-29 Eli Zaretskii <eliz@gnu.org>
354
04c70788 355 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
356 use EDOM.
357
fbcaa2f3
EZ
3582011-09-28 Eli Zaretskii <eliz@gnu.org>
359
360 * xdisp.c (compute_display_string_end): If there's no display
361 string at CHARPOS, return -1.
362
363 * bidi.c (bidi_fetch_char): When compute_display_string_end
364 returns a negative value, treat the character as a normal
365 character not covered by a display string. (Bug#9624)
366
a239d4e9
JB
3672011-09-28 Juanma Barranquero <lekktu@gmail.com>
368
369 * lread.c (Fread_from_string): Fix typo in docstring.
370
88652fd5
EZ
3712011-09-27 Eli Zaretskii <eliz@gnu.org>
372
373 * xdisp.c (handle_invisible_prop): If invisible text ends on a
374 newline, reseat the iterator instead of bidi-iterating there one
375 character at a time. (Bug#9610)
32c1fffd
SM
376 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
377 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 378
ed497dd4
AS
3792011-09-27 Andreas Schwab <schwab@linux-m68k.org>
380
381 * lread.c (readevalloop): Use correct code for NBSP.
382 (read1): Likewise. (Bug#9608)
383
b2bf61aa
MA
3842011-09-25 Michael Albinus <michael.albinus@gmx.de>
385
386 * dbusbind.c (Fdbus_register_signal): When service is not
387 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
388
32bbb17c
GM
3892011-09-25 Glenn Morris <rgm@gnu.org>
390
391 * buffer.c (truncate-lines): Doc fix.
392
94e0933e
CY
3932011-09-24 Chong Yidong <cyd@stupidchicken.com>
394
395 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
396 (Fset_window_next_buffers): Doc fix.
397
cddde921
GM
3982011-09-24 Glenn Morris <rgm@gnu.org>
399
400 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
401
1260aef1
PE
4022011-09-24 Paul Eggert <eggert@cs.ucla.edu>
403
25b4bfa0
PE
404 Fix minor problems found by static checking.
405 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
406 * indent.c (Fvertical_motion): Fix == vs = typo.
407
e3cbd34b
EZ
4082011-09-24 Eli Zaretskii <eliz@gnu.org>
409
a66cfb1c
SM
410 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
411 Default value is now t. Doc fix.
6bf7006f 412
e3cbd34b 413 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 414 logic when moving up, not only when moving down. Fix the
e3cbd34b 415 confusing name and values of the it_overshoot_expected variable;
32c1fffd 416 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
417
418 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
419 CHARPOS is covered by a display string which includes newlines.
420 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
421 is covered by a display string with embedded newlines.
422
a3de0cbd
MA
4232011-09-24 Michael Albinus <michael.albinus@gmx.de>
424
425 * dbusbind.c (Fdbus_register_signal): Add match rule to
426 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
427 (Fdbus_register_method, Vdbus_registered_objects_table):
428 Fix docstring.
a3de0cbd 429
b260039d
JM
4302011-09-24 Jim Meyering <meyering@redhat.com>
431
32c1fffd 432 do not ignore write error for any output size
b260039d
JM
433 The previous change was incomplete.
434 While it makes emacs --batch detect the vast majority of stdout
435 write failures, errors were still ignored whenever the output size is
436 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
437 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
438 && echo FAIL: ignored write error
439 FAIL: ignored write error
440 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
441 && echo FAIL: ignored write error
442 FAIL: ignored write error
443 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
444
8eca8a7c
AS
4452011-09-23 Andreas Schwab <schwab@linux-m68k.org>
446
447 * emacs.c (Fkill_emacs): In noninteractive mode exit
448 non-successfully if a write error occurred on stdout. (Bug#9574)
449
3341db62
EZ
4502011-09-21 Eli Zaretskii <eliz@gnu.org>
451
452 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
453 the xassert test.
454
455 * dispextern.h (struct it): Update the comment documenting what
456 can it->OBJECT be.
457
8c203dbf
EZ
4582011-09-20 Eli Zaretskii <eliz@gnu.org>
459
460 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
461 a display string, extend search for cursor position to end of row.
462 (find_row_edges): If the row ends in a newline from a display
463 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
464 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
465 (Fcurrent_bidi_paragraph_direction): Fix search for previous
466 non-empty line. Fixes confusing cursor motion with arrow keys at
467 the beginning of a line that starts with whitespace.
8c203dbf 468
a4824228
LMI
4692011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
470
471 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
472 (bug#9493).
473
33ed493b
CY
4742011-09-18 Chong Yidong <cyd@stupidchicken.com>
475
476 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
477 boolean (Bug#9154).
478
56cd55c8
EZ
4792011-09-18 Eli Zaretskii <eliz@gnu.org>
480
481 * xdisp.c (display_line): Record maximum and minimum buffer
482 positions even if no glyphs were produced (e.g., by a zero-width
483 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
484 buffer positions that will be removed from the glyph row because
485 they don't fit.
c02dcedf
EZ
486 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
487 column is beyond frame width: don't subtract 1 "pixel" when
488 computing width of the stretch.
3e62b7e0
EZ
489 (reseat_at_next_visible_line_start): Undo the change made on
490 2011-09-17 that saved paragraph information and restored it after
491 the call to `reseat'. (Bug#9545)
56cd55c8 492
5ed99d36 4932011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
494
495 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
496 and turn window cursor on if cleared (Bug#9415).
497
5ed99d36 4982011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
499
500 * search.c (boyer_moore): Take unibyte characters from pattern
501 literally. (Bug#9458)
502
9bade7b2
EZ
5032011-09-18 Eli Zaretskii <eliz@gnu.org>
504
505 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
506
e5e9d610
PE
5072011-09-18 Paul Eggert <eggert@cs.ucla.edu>
508
87e4427a
PE
509 Fix minor problem found by static checking.
510 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
511 initialized, to pacify gcc -Wuninitialized.
512
e5e9d610
PE
513 * fileio.c: Report proper errno when syscall falls.
514 (Finsert_file_contents): Save and restore errno,
515 so that report_file_error outputs the correct diagnostic.
516 (Fwrite_region) [CLASH_DETECTION]: Likewise.
517
a1674f0b
EZ
5182011-09-18 Eli Zaretskii <eliz@gnu.org>
519
520 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
521
fbfb6dd4
EZ
5222011-09-17 Eli Zaretskii <eliz@gnu.org>
523
524 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
525 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
526
bb187662
EZ
5272011-09-17 Eli Zaretskii <eliz@gnu.org>
528
1137e8b8 529 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 530 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
531
532 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
533 (bidi_find_paragraph_start): Search back for paragraph beginning
534 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
535 (bidi_move_to_visually_next): Only trigger paragraph-related
536 computations when the last character is a newline or at EOB, not
537 just any NEUTRAL_B. (Bug#9470)
538
bb187662
EZ
539 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
540 truncated lines if point is covered by a display string. (Bug#9524)
541
2e621251
PE
5422011-09-16 Paul Eggert <eggert@cs.ucla.edu>
543
544 * xselect.c: Relax test for outgoing X longs (Bug#9498).
545 (cons_to_x_long): New function.
546 (lisp_data_to_selection_data): Use it. Correct the test for
547 short-versus-long data; it was negated. Break out of vector
548 loop, for efficiency, when a long datum is discovered.
549
91a15bc6
SM
5502011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
551
552 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
553
b41c3a35
EZ
5542011-09-16 Eli Zaretskii <eliz@gnu.org>
555
556 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
557 GCC PR/17406) by declaring this function with external scope.
558
7812ba2d
PE
5592011-09-15 Paul Eggert <eggert@cs.ucla.edu>
560
561 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
562 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
563
cf7edc2a
AS
5642011-09-15 Andreas Schwab <schwab@linux-m68k.org>
565
566 * editfns.c (Fformat): Correctly handle text properties on "%%".
567
bd01620e
EZ
5682011-09-15 Eli Zaretskii <eliz@gnu.org>
569
570 * xterm.c (x_draw_composite_glyph_string_foreground):
571 * w32term.c (x_draw_composite_glyph_string_foreground):
572 * term.c (encode_terminal_code):
573 * composite.c (composition_update_it, get_composition_id):
574 * xdisp.c (get_next_display_element)
575 (fill_composite_glyph_string): Add comments about special meaning
576 of TAB characters in a composition.
577
a02719a3
PE
5782011-09-15 Paul Eggert <eggert@cs.ucla.edu>
579
580 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
581 This occurs when processing a multibyte format.
582 Problem reported by Wolfgang Jenker.
a02719a3 583
72589a3c
JB
5842011-09-15 Johan Bockgård <bojohan@gnu.org>
585
586 * xdisp.c (try_cursor_movement): Only check for exact match if
587 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
588
1c14176c
PE
5892011-09-14 Paul Eggert <eggert@cs.ucla.edu>
590
591 Remove unused external symbols.
592 * dispextern.h (calc_pixel_width_or_height): Remove decl.
593 * xdisp.c (calc_pixel_width_or_height): Now static.
594 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
595 * indent.c (check_display_width):
596 * w32term.c: Fix comment to match code.
597 * xterm.c, xterm.h (x_catching_errors): Remove.
598
d2eea5b5
PE
5992011-09-14 Paul Eggert <eggert@cs.ucla.edu>
600
601 * xselect.c: Use signed conversions more consistently (Bug#9498).
602 (selection_data_to_lisp_data): Assume incoming selection data are
603 signed integers, not unsigned. This is to be consistent with
604 outgoing selection data, which was modified to use signed integers
605 in as part of the fix to Bug#9196 in response to Jan D.'s comment
606 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
607 expects long, not unsigned long.
608
46888499
EZ
6092011-09-14 Eli Zaretskii <eliz@gnu.org>
610
611 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
612 computation of loop end. Reported by Johan Bockgård
613 <bojohan@gnu.org>.
614
ef8ef9fb
CY
6152011-09-13 Chong Yidong <cyd@stupidchicken.com>
616
617 * frame.c (Fother_visible_frames_p): Function deleted.
618
fa819fed
EZ
6192011-09-12 Eli Zaretskii <eliz@gnu.org>
620
621 * indent.c (compute_motion): Process display vector front to back
622 rather than the other way around. (Bug#2496)
623
2ba8e008
SM
6242011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
625
626 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
627
20f53c69
CY
6282011-09-11 Chong Yidong <cyd@stupidchicken.com>
629
630 * minibuf.c (Fread_from_minibuffer): Doc fix.
631
d562d7a4
EZ
6322011-09-11 Eli Zaretskii <eliz@gnu.org>
633
634 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
635 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
636
1c4d7f3d
LMI
6372011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
638
639 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
640 value for non-existent files.
641
b885bf36
EZ
6422011-09-11 Eli Zaretskii <eliz@gnu.org>
643
644 * fileio.c (Finsert_file_contents): If the file cannot be opened,
645 set its "size" to -1. This will set the modtime_size field of
646 the corresponding buffer to -1, which is what
647 verify-visited-file-modtime expects for files that do not exist.
648 (Bug#9139)
649
6612f0bf
PE
6502011-09-11 Paul Eggert <eggert@cs.ucla.edu>
651
652 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
653 here ...
654 * lisp.h: ... from here. push_key_description is no longer
655 defined in keyboard.c, so its declaration should not be in
656 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
657 logically belongs with push_key_description.
658
dfb3f755
PE
6592011-09-10 Paul Eggert <eggert@cs.ucla.edu>
660
661 * buffer.h: Include <sys/types.h> instead of <time.h>.
662 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
663 Problem reported by Herbert J. Skuhra.
664
3134906c
LMI
6652011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
666
667 * xml.c (parse_region): Make the parsing work for
668 non-comment-starting XML files again (bug#9144).
669
8d903f4e
AS
6702011-09-10 Andreas Schwab <schwab@linux-m68k.org>
671
672 * image.c (gif_load): Fix calculation of bottom and right corner.
673 (Bug#9468)
674
80ad64f4
EZ
6752011-09-10 Eli Zaretskii <eliz@gnu.org>
676
677 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
678 redisplay in small windows.
679
208a048d
EZ
6802011-09-09 Eli Zaretskii <eliz@gnu.org>
681
682 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
683
9b1c252e
MR
6842011-09-08 Martin Rudalics <rudalics@gmx.at>
685
686 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
687 Operate on live windows only.
688
2949f33b
JB
6892011-09-08 Juanma Barranquero <lekktu@gmail.com>
690
691 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
692
e08dcafd
EZ
6932011-09-07 Eli Zaretskii <eliz@gnu.org>
694
695 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
696 only under bidi iteration.
697
115b96bd
JD
6982011-09-07 Jan Djärv <jan.h.d@swipnet.se>
699
700 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
701
c8199d0f
PE
7022011-09-06 Paul Eggert <eggert@cs.ucla.edu>
703
704 isnan: Fix porting problem to Solaris 10 with bundled gcc.
705 Without this fix, the command to link temacs failed due to an
706 undefined symbol __builtin_isnan. This is because
707 /usr/include/iso/math_c99.h #defines isnan(x) to
708 __builtin_isnan(x), but the bundled gcc, which identifies itself
709 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
710 a __builtin_isnan.
711 * floatfns.c (isnan): #undef, and then #define to a clone of
712 what's in data.c.
713 (Fisnan): Always define, since it's always available now.
714 (syms_of_floatfns): Always define isnan at the Lisp level.
715
e39b275c 7162011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
717
718 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
719
b2db44d9 7202011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 721
f4af5137 722 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
723 The previous code assumed that file offsets (off_t values) fit in
724 EMACS_INT variables, which is not true on typical 32-bit hosts.
725 The code messed up by falsely reporting buffer overflow in cases
726 such as (insert-file-contents "big" nil 1 2) into an empty buffer
727 when "big" contains more than 2**29 bytes, even though this
728 inserts just one byte and does not overflow the buffer.
729 (Finsert_file_contents): Store file offsets as off_t
730 values, not as EMACS_INT values. Check for overflow when
731 converting between EMACS_INT and off_t. When checking for
732 buffer overflow or for overlap, take the offsets into account.
733 Don't use EMACS_INT for small values where int suffices.
734 When checking for overlap, fix a typo: ZV was used where
735 ZV_BYTE was intended.
736 (Fwrite_region): Don't assume off_t fits into 'long'.
737 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
738
ecfc0a49
MA
7392011-09-05 Michael Albinus <michael.albinus@gmx.de>
740
741 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
742
6511acf2 7432011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 744
0999621a 745 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
746
747 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 748 (esprintf, exprintf, evxprintf): New functions.
62f19c19 749 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 750 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
751 (modify_event_symbol): Do not assume that the length of
752 name_alist_or_stem is safe to alloca and fits in int.
753 (Fexecute_extended_command): Likewise for function name and binding.
754 (Frecursion_depth): Wrap around reliably on integer overflow.
755 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
756 since some callers pass EMACS_INT values.
757 (Fsingle_key_description): Don't crash if symbol name contains more
758 than MAX_ALLOCA bytes.
759 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
760 (get_minibuffer): Arg is now EMACS_INT, not int.
761 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 762 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
763 * window.h (command_loop_level, minibuf_level): Reflect API changes.
764
2be7d702
PE
765 * dbusbind.c (signature_cat): New function.
766 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
767 Do not overrun buffer; instead, report string overflow.
768
9d1df220
PE
769 * dispnew.c (add_window_display_history): Don't overrun buffer.
770 Truncate instead; this is OK since it's just a log.
771
33ef5c64
PE
772 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
773 even if the time zone offset is outlandishly large.
774 Don't mishandle offset == INT_MIN.
775
66c6fdd5
PE
776 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
777 when creating daemon; the previous buffer-overflow check was incorrect.
778
d749b01b
PE
779 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
780 which has the guts of the old verror function.
781
b5cd1905
PE
782 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
783 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
784
6e1a67fb
PE
785 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
786 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 787 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 788 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
789 length of string rather than counting it via multiple sprintfs;
790 that's simpler and more reliable.
c21721cc
PE
791 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
792 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
793 sprintf, in case result does not fit in int.
794
c57b67fc
PE
795 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
796 (fontset_from_font): Print it.
797
8a401434
PE
798 * frame.c (tty_frame_count): Now printmax_t, not int.
799 (make_terminal_frame, set_term_frame_name): Print it.
800 (x_report_frame_params): In X, window IDs are unsigned long,
801 not signed long, so print them as unsigned.
802 (validate_x_resource_name): Check for implausibly long names,
803 and don't assume name length fits in 'int'.
804 (x_get_resource_string): Don't blindly alloca invocation name;
805 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
806 not fit in int.
807
6e1a67fb
PE
808 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
809 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
810 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
811
0df02bf3
PE
812 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
813 Use esprintf, not sprintf, in case result does not fit in int.
814
48e30793
PE
815 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
816 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
817 it as a large positive number.
818 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
819 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
820
a66ff6d8
PE
821 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
822 in case result does not fit in int.
823
aca216ff
PE
824 * print.c (float_to_string): Detect width overflow more reliably.
825 (print_object): Make sprintf buffer a bit bigger, to avoid potential
826 buffer overrun. Don't assume list length fits in 'int'. Treat
827 print length of 0 as 0, not as infinity; to be consistent with other
828 uses of print length in this function. Don't overflow print length
829 index. Don't assume hash table size fits in 'long', or that
830 vectorlike size fits in 'unsigned long'.
831
31c286f7
PE
832 * process.c (make_process): Use printmax_t, not int, to format
833 process-name gensyms.
834
55e5faa1
PE
835 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
836
80f2e268
PE
837 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
838 to avoid potential buffer overrun.
839
670741ab
PE
840 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
841 if X resource line is longer than 512 bytes.
842
b7163a50
PE
843 * xfns.c (x_window): Make sprintf buffer a bit bigger
844 to avoid potential buffer overrun.
845
ae58ff1f
PE
846 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
847
c43c8a6a
PE
848 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
849
3f8236f4
PE
8502011-09-04 Paul Eggert <eggert@cs.ucla.edu>
851
53e9fe90 852 Integer overflow fixes for scrolling, etc.
6511acf2
PE
853 Without these, Emacs silently mishandles large integers sometimes.
854 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
855 it were "C-u 1 M-x recenter" on a typical 64-bit host.
856
6511acf2
PE
857 * xdisp.c (try_window_id): Check Emacs fixnum range before
858 converting to 'int'.
806add1d 859
6511acf2 860 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
861 Check that an Emacs fixnum is in range before assigning it to 'int'.
862 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
863 values converted from Emacs fixnums.
864 (Frecenter): Don't wrap around a line count if it is out of 'int'
865 range; instead, treat it as an extreme value.
866 (Fset_window_configuration, compare_window_configurations):
867 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
868
6511acf2
PE
869 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
870 that can exceed INT_MAX. Check that EMACS_INT value is in range
871 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
872 (match_limit): Don't assume that a fixnum can fit in 'int'.
873
6511acf2 874 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
875 exceed INT_MAX.
876
6511acf2 877 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
878 (Fvertical_motion): Don't wrap around LINES values that don't fit
879 in 'int'. Instead, treat them as extreme values. This is good
880 enough for windows, which can't have more than INT_MAX lines anyway.
881
fcb901a7
LMI
8822011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
883
0f2f6b6d
LMI
884 * Require libxml/parser.h to avoid compilation warning.
885
fcb901a7
LMI
886 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
887
888 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
889 since this reportedly can destroy thread storage.
890
6e20a0d4
CY
8912011-08-30 Chong Yidong <cyd@stupidchicken.com>
892
893 * syntax.c (find_defun_start): Update all cache variables if
894 exiting early (Bug#9401).
895
148ae00e
EZ
8962011-08-30 Eli Zaretskii <eliz@gnu.org>
897
f6cfbd8f
EZ
898 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
899
148ae00e
EZ
900 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
901 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
902 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
903
904 * term.c (tty_append_glyph): New function.
905 (produce_stretch_glyph): Static function and its prototype deleted.
906
a66cfb1c
SM
907 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
908 Add prototypes.
148ae00e 909
c4a07a4c
PE
9102011-08-29 Paul Eggert <eggert@cs.ucla.edu>
911
912 * image.c (parse_image_spec): Check for nonnegative, not for positive,
913 when checking :margin (Bug#9390).
914 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 915 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
916 so that the name doesn't mislead. All uses changed.
917
6bc8cd65
JB
9182011-08-28 Johan Bockgård <bojohan@gnu.org>
919
920 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
921 set_tty_hooks.
922
dca4927e
EZ
9232011-08-27 Eli Zaretskii <eliz@gnu.org>
924
925 * xdisp.c (move_it_to): Don't bail out early when reaching
926 position beyond to_charpos, if we are scanning backwards.
927 (move_it_vertically_backward): When DY == 0, make sure we get to
928 the first character in the line after the newline.
929
f2cad773
PE
9302011-08-27 Paul Eggert <eggert@cs.ucla.edu>
931
932 * ccl.c: Improve and simplify overflow checking (Bug#9196).
933 (ccl_driver): Do not generate an out-of-range pointer.
934 (Fccl_execute_on_string): Remove unnecessary check for
935 integer overflow, noted by Stefan Monnier in
936 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
937 Remove a FIXME that didn't need fixing.
938 Simplify the newly-introduced buffer reallocation code.
939
0cae2cdb
JB
9402011-08-27 Juanma Barranquero <lekktu@gmail.com>
941
942 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
943
5fc295a4 9442011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 945
70c60eb2 946 Integer and memory overflow issues (Bug#9196).
726e0ab1 947
d31850da
PE
948 * doc.c (get_doc_string): Rework so that
949 get_doc_string_buffer_size is the actual buffer size, rather than
950 being 1 less than the actual buffer size; this makes xpalloc more
951 convenient.
952
a69fbedb
PE
953 * image.c (x_allocate_bitmap_record, cache_image):
954 * xselect.c (Fx_register_dnd_atom):
955 Simplify previous changes by using xpalloc.
956
fe5c5d37
PE
957 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
958 since either will do and ptrdiff_t is convenient with xpalloc.
959
0065d054
PE
960 * charset.c (charset_table_size)
961 (struct charset_sort_data.priority): Now ptrdiff_t.
962 (charset_compare): Don't overflow if priorities differ greatly.
963 (Fsort_charsets): Don't assume list length fits in int.
964 Check for size-calculation overflow when allocating sort data.
965 (syms_of_charset): Allocate an initial charset table that is
966 just under 64 KiB, to avoid problems with glibc malloc and mmap.
967
968 * cmds.c (internal_self_insert): Check for size-calculation overflow.
969
970 * composite.h (struct composition.glyph_len): Now int, not unsigned.
971 The actual value is always <= INT_MAX, and leaving it unsigned made
972 overflow checking harder.
973
974 * dispextern.h (struct glyph_matrix.rows_allocated)
975 (struct face_cache.size): Now ptrdiff_t, for convenience in use
976 with xpalloc. The values are still always <= INT_MAX.
977
978 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
979
980 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
981 (SAFE_NALLOCA): New macro.
982
983 * region-cache.c (struct boundary.pos, find_cache_boundary)
984 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
985 (set_cache_region, invalidate_region_cache)
986 (revalidate_region_cache, know_region_cache, region_cache_forward)
987 (region_cache_backward, pp_cache):
988 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
989 so that ptrdiff_t * can be passed to xpalloc.
990 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
991 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
992 (pp_cache): Don't assume cache_len fits in int.
993 * region-cache.h: Adjust extern decls to match.
994
995 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
996 EMACS_INT, since either will do, for xpalloc.
997
998 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
999 (xnmalloc, xnrealloc, xpalloc): New functions.
1000
726e0ab1
PE
1001 * bidi.c (bidi_shelve_header_size): New constant.
1002 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1003 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1004
51f30bc5 1005 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1006 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1007 (overlay_strings):
1008 Don't update size of array until after memory allocation succeeds,
1009 because xmalloc/xrealloc may not return.
0065d054
PE
1010 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1011 now that we have proper integer overflow checking.
1012 (record_overlay_string, overlay_strings): Catch overflows when
1013 calculating size of overlay_str_buf.
726e0ab1 1014
0065d054
PE
1015 * callproc.c (Fcall_process): Check for size overflow when
1016 calculating size of args2.
1017 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1018 Normally we prefer signed values, but sticking with ptrdiff_t would
1019 require adding more-complicated checks.
726e0ab1
PE
1020
1021 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1022 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1023 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1024 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1025
1026 * character.c (Fstring): Check for size-calculation overflow.
1027
1028 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1029 unnecessary integer overflow. Check for size overflow.
1030 (encode_coding_object): Don't update size until xmalloc succeeds.
1031
1032 * composite.c (get_composition_id): Check for overflow in glyph
1033 length calculations.
1034
1035 Integer and memory overflow fixes for display code.
1036 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1037 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1038 (scrolling_window): Check for overflow in size calculations.
1039 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1040 Don't assume glyph table len fits in int.
1041 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1042 (row_table_size): Now ptrdiff_t, not int.
1043 (scrolling_window): Avoid overflow in size calculations.
1044 Don't update size until allocation succeeds.
1045 * fns.c (concat): Check for overflow in size calculations.
1046 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1047 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1048 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1049
1050 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1051 (get_doc_string): Check for size calculation overflow.
1052 Don't update size until allocation succeeds.
1053 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1054 EMACS_INT, where ptrdiff_t will do.
1055 (Fsubstitute_command_keys): Check for string overflow.
1056
1057 * editfns.c (set_time_zone_rule): Don't assume environment length
1058 fits in int.
1059 (message_length): Now ptrdiff_t, not int.
1060 (Fmessage_box): Don't update size until allocation succeeds.
1061 Don't assume message length fits in int.
1062 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1063
0065d054
PE
1064 * emacs.c (main): Do not reallocate argv, since there is a null at
1065 the end that can be overwritten, and this way there's no need to
1066 worry about size-calculation overflow.
1067 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1068
1069 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1070 alloc succeeds.
1071 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1072
1073 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1074 (x_set_scroll_bar_width, x_figure_window_size):
1075 Check for integer overflow.
1076 (x_set_alpha): Do not assume XINT fits in int.
1077
1078 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1079 This is for the members text_lines, text_cols, total_lines, total_cols,
1080 where the system imposes an 'int' limit.
1081
1082 * fringe.c (Fdefine_fringe_bitmap):
1083 Don't update size until alloc works.
1084
1085 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1086 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1087
1088 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1089 Check for size-calculation overflow.
1090 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1091 do, as we prefer signed integers.
1092 (id_to_widget.max_size, id_to_widget.used)
1093 (xg_store_widget_in_map, xg_remove_widget_from_map)
1094 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1095 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1096 Use and return ptrdiff_t, not int.
1097 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1098 * gtkutil.h: Change prototypes to match the above.
1099
1100 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1101 are duplicate now that they've been promoted to lisp.h.
1102 (x_allocate_bitmap_record, x_alloc_image_color)
1103 (make_image_cache, cache_image, xpm_load):
1104 Don't update size until alloc is done.
1105 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1106 (x_detect_edges):
3256efce 1107 Check for size calculation overflow.
726e0ab1
PE
1108 (ct_colors_allocated_max): New constant.
1109 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1110 overflow.
3256efce 1111
726e0ab1
PE
1112 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1113 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1114 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1115 Use ptrdiff_t, not int, to count maps.
1116 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1117 calculations. Don't update size until allocation succeeds.
1118 Redo calculations to avoid overflow.
726e0ab1
PE
1119 * keyboard.h: Change prototypes to match the above.
1120
1121 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1122 to count maps.
1123 (current_minor_maps): Check for size calculation overflow.
1124 * keymap.h: Change prototypes to match the above.
1125
1126 * lread.c (read1, init_obarray): Don't update size until alloc done.
1127
1128 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1129 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1130
726e0ab1
PE
1131 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1132 Now ptrdiff_t, not int.
1133 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1134 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1135
1136 * process.c (Fnetwork_interface_list): Check for overflow
1137 in size calculation.
1138
1139 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1140
1141 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1142 overflow. Don't bother calling xmalloc when xrealloc will do.
1143
1144 * search.c (Freplace_match): Check for size calculation overflow.
1145 (Fset_match_data): Don't assume list lengths fit in 'int'.
1146
1147 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1148 for command line length. Do not attempt to address one before the
1149 beginning of an array, as that's not portable.
1150
1151 * term.c (max_frame_lines): Remove; unused.
1152 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1153 not int.
1154 (encode_terminal_code, calculate_costs): Check for size
1155 calculation overflow.
1156 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1157 table lengths and related sizes. Don't update size until alloc
1158 done. Redo calculations to avoid overflow.
1159 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1160
1161 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1162 subtracting pointers.
1163 (gobble_line): Check for overflow more carefully. Don't update size
1164 until alloc done.
1165
1166 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1167 Don't update size until alloc done.
1168 Redo size calculations to avoid overflow.
1169 Check for size calculation overflow.
0065d054 1170 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1171
1172 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1173 Use ptrdiff_t, not int, for sizes.
1174 (store_mode_line_noprop_char): Don't update size until alloc done.
1175
0065d054
PE
1176 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1177 Use ptrdiff_t, not int, for sizes.
1178 (Finternal_make_lisp_face, cache_face):
1179 Check for size calculation overflow.
1180 (cache_face): Treat size calculation overflows as if they were
1181 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1182
1183 * xfns.c (x_encode_text, x_set_name_internal)
1184 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1185 sizes, since they can exceed INT_MAX in size. Check for size
1186 calculation overflow.
1187
0065d054
PE
1188 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1189 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1190 Don't update size until alloc done.
1191
0065d054 1192 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1193 as sprintf is limited to int lengths.
1d526e2f 1194
252c5ee1
PE
1195 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1196 (X_LONG_MIN): New macros.
864d7ce7
PE
1197 Use them to make the following changes clearer.
1198 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1199 This change doesn't affect the value now, but it may help remind
1200 future maintainers not to raise the value too much later.
1201 (SELECTION_QUANTUM): Remove, replacing with ...
1202 (selection_quantum): ... new function, which avoids overflow.
1203 All uses changed.
1204 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1205 assumption that selection length fits in 'int'.
1206 (x_reply_selection_request, x_handle_selection_request)
1207 (x_get_window_property, receive_incremental_selection)
1208 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1209 (lisp_data_to_selection_data, clean_local_selection_data):
1210 Use ptrdiff_t, not int, to record length of selection.
1211 (x_reply_selection_request, x_get_window_property)
1212 (receive_incremental_selection, x_property_data_to_lisp):
1213 Redo calculations to avoid overflow.
1214 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1215 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1216 something.
1217 (x_get_window_property, receive_incremental_selection)
1218 (lisp_data_to_selection_data, x_property_data_to_lisp):
1219 Check for size-calculation overflow.
1220 (x_get_window_property, receive_incremental_selection)
1221 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1222 Don't store size until memory allocation succeeds.
1223 (x_get_window_property): Plug memory leak on memory exhaustion.
1224 Don't double-block input; malloc is safe here. Don't assume 2**34
1225 - 4 fits in unsigned long. Add an xassert to check
1226 XGetWindowProperty overflow. Be more careful about overflow
1227 calculations, and distinguish size from memory overflow better.
1228 (receive_incremental_selection): When tracing, don't assume
1229 unsigned int is less than INT_MAX.
1230 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1231 harmful) conversions of unsigned short to int.
1232 (lisp_data_to_selection_data): Don't assume that integers
1233 in the range -65535 through -1 fit in an X unsigned short.
1234 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1235 result parameters unless successful. Rely on cons_to_unsigned
1236 to report problems with elements; the old code wasn't right anyway.
1237 (x_check_property_data): Check for int overflow; we cannot use
1238 a wider type due to X limits.
1239 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1240
726e0ab1 1241 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1242
0065d054
PE
1243 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1244 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1245 (x_color_cells): Don't store size until memory allocation succeeds.
1246 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1247 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1248 (x_term_init): Don't assume length fits in int (sprintf is limited
1249 to int size).
bc18e09d 1250
ebfa62c0
PE
1251 Use ptrdiff_t for composition IDs.
1252 * character.c (lisp_string_width):
1253 * composite.c (composition_table_size, n_compositions)
1254 (get_composition_id, composition_gstring_from_id):
1255 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1256 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1257 * window.c (Frecenter):
1258 Use ptrdiff_t, not int, for composition IDs.
1259 * composite.c (get_composition_id): Check for integer overflow.
1260 * composite.h: Adjust prototypes to match the above changes.
1261
d3411f89
PE
1262 Use ptrdiff_t for hash table indexes.
1263 * category.c (hash_get_category_set):
1264 * ccl.c (ccl_driver):
1265 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1266 * coding.c (coding_system_charset_list, detect_coding_system):
1267 * coding.h (struct coding_system.id):
1268 * composite.c (get_composition_id, gstring_lookup_cache):
1269 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1270 * image.c (xpm_get_color_table_h):
1271 * lisp.h (hash_lookup, hash_put):
1272 * minibuf.c (Ftest_completion):
1273 Use ptrdiff_t for hash table indexes, not int (which is too
1274 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1275 32-bit --with-wide-int hosts).
1276
e097a6fa
PE
1277 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1278 Add a FIXME comment about memory leaks.
1279 (syms_of_charset): Don't assume xmalloc returns.
1280
5637687f
PE
1281 Don't assume that stated character widths fit in int.
1282 * character.c (Fchar_width, c_string_width, lisp_string_width):
1283 * character.h (CHAR_WIDTH):
1284 * indent.c (MULTIBYTE_BYTES_WIDTH):
1285 Use sanitize_char_width to avoid undefined and/or bad behavior
1286 with outlandish widths.
a66cfb1c 1287 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1288 now that we have two such functions. All uses changed.
1289 (sanitize_char_width): New inline function.
1290
a2271ba2
PE
1291 Don't assume that tab-width fits in int.
1292 * character.h (sanitize_width): New inline function.
1293 (SANE_TAB_WIDTH): New macro.
1294 (ASCII_CHAR_WIDTH): Use it.
1295 * indent.c (sane_tab_width): Remove. All uses replaced by
1296 SANE_TAB_WIDTH (current_buffer).
1297 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1298
18c52557
PE
1299 * fileio.c: Integer overflow issues with file modes.
1300 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1301
caeeedc1
PE
1302 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1303 Remove unreachable code.
1304 (read_hex, load_charset_map_from_file): Check for integer overflow.
1305
50849c52
PE
1306 * xterm.c: don't go over XClientMessageEvent limit
1307 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1308 (x_send_scroll_bar_event): Likewise. Check that the size does not
1309 exceed limits imposed by XClientMessageEvent, as well as the usual
1310 ptrdiff_t and size_t limits.
1311
b13995db
PE
1312 * keyboard.c: Overflow, signedness and related fixes.
1313 (make_lispy_movement): Use same integer type in forward decl
1314 that is used in the definition.
1315 (read_key_sequence, keyremap_step):
1316 Change bufsize argument back to int, undoing my 2011-03-30 change.
1317 We prefer signed types, and int is wide enough here.
1318 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1319 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1320 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1321 length, not size_t. Use ptrdiff_t for index, not int.
1322 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1323 possibility of integer overflow.
1324
13464394
PE
1325 Overflow, signedness and related fixes for images.
1326
1327 * dispextern.h (struct it.stack[0].u.image.image_id)
1328 (struct_it.image_id, struct image.id, struct image_cache.size)
1329 (struct image_cache.used, struct image_cache.ref_count):
1330 * gtkutil.c (update_frame_tool_bar):
1331 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1332 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1333 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1334 * nsmenu.m (update_frame_tool_bar):
1335 * xdisp.c (calc_pixel_width_or_height):
1336 * xfns.c (image_cache_refcount):
1337 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1338 on typical 64-bit hosts.
1339
1340 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1341 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1342 Omit unnecessary casts to int.
1343 (parse_image_spec): Check that integers fall into 'int' range
1344 when the callers expect that.
1345 (image_ascent): Redo ascent calculation to avoid int overflow.
1346 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1347 (lookup_image): Remove unnecessary tests.
1348 (xbm_image_p): Locals are now of int, not EMACS_INT,
1349 since parse_image_check makes sure they fit into int.
1350 (png_load, gif_load, svg_load_image):
1351 Prefer int to unsigned where either will do.
1352 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1353 old tiff_error_handler and tiff_warning_handler.
1354 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1355 stack buffer overflows. It uses only the features of vsnprintf
1356 that are common to both POSIX and native Microsoft.
1357 (tiff_error_handler, tiff_warning_handler): Use it.
1358 (tiff_load, gif_load, imagemagick_load_image):
1359 Don't assume :index value fits in 'int'.
1360 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1361 (imagemagick_load_image): Check that crop parameters fit into
1362 the integer types that MagickCropImage accepts. Don't assume
1363 Vimagemagick_render_type has a nonnegative value. Don't assume
1364 size_t fits in 'long'.
1365 (gs_load): Use printmax_t to print the widest integers possible.
1366 Check for integer overflow when computing image height and width.
1367
c11821d4
EZ
13682011-08-26 Eli Zaretskii <eliz@gnu.org>
1369
1370 * xdisp.c (redisplay_window): Don't force window start if point
1371 will be invisible in the resulting window. (Bug#9324)
1372
0c95fcf7
EZ
13732011-08-25 Eli Zaretskii <eliz@gnu.org>
1374
1375 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1376 the display spec is of the form `(space ...)'.
1377 (handle_display_spec): Return the value returned by
1378 handle_single_display_spec, not just 1 or zero.
1379 (handle_single_display_spec): If the display spec is of the form
1380 `(space ...)', and specifies display in the text area, return 2
1381 rather than 1.
fee65a97 1382 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1383 accurately, and prefer exact match for point under bidi.
1384 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1385
1386 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1387 into disp_prop; all users changed.
1388
1389 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1390 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1391 for the text covered by the display property.
1392
e4ed06f1
CY
13932011-08-25 Chong Yidong <cyd@stupidchicken.com>
1394
1395 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1396 Change return value to nil.
1397 (Frecord_buffer): Delete unused function.
1398
f67cdd7f
EZ
13992011-08-24 Eli Zaretskii <eliz@gnu.org>
1400
5980d4c6
EZ
1401 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1402 buffers, return left-to-right.
8610fe8b
EZ
1403 (set_cursor_from_row): Consider candidate row a win if its glyph
1404 represents a newline and point is on that newline. Fixes cursor
1405 positioning on the newline at EOL of R2L text within L2R
1406 paragraph, and vice versa.
1407 (try_cursor_movement): Check continued rows, in addition to
1408 continuation rows. Fixes unwarranted scroll when point enters a
1409 continued line of R2L text within an L2R paragraph, or vice versa.
1410 (cursor_row_p): Consider the case of point being equal to
1411 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1412 from the end of a short line to the beginning of a continued line
1413 of R2L text within L2R paragraph.
1414 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1415 composed characters.
5980d4c6 1416
f67cdd7f
EZ
1417 * bidi.c (bidi_check_type): Use xassert.
1418 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1419 members.
1420
bca633fb
EZ
14212011-08-23 Eli Zaretskii <eliz@gnu.org>
1422
1423 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1424 a character.
1425
4a5885a7
CY
14262011-08-23 Chong Yidong <cyd@stupidchicken.com>
1427
1428 * nsfont.m (ns_otf_to_script): Fix typo.
1429
0902a04e
KH
14302011-08-22 Kenichi Handa <handa@m17n.org>
1431
1432 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1433 extra slot even if the purpose is char-code-property-table.
1434
1a2e6670
EZ
14352011-08-23 Eli Zaretskii <eliz@gnu.org>
1436
8ddde651
EZ
1437 * xdisp.c (redisplay_window): When computing centering_position,
1438 account for the height of the header line. (Bug#8874)
1439
425cc014
EZ
1440 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1441 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1442 candidate is selected by the mouse, and that candidate has a
1443 composed character under the mouse.
1444
1a2e6670
EZ
1445 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1446 coordinates reported by pos-visible-in-window-p for a composed
1447 character in column zero.
1448
8b76d6f8
SM
14492011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1450
1451 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1452
dac347dd
EZ
14532011-08-22 Eli Zaretskii <eliz@gnu.org>
1454
1455 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1456 consider it a hit if to_charpos is anywhere in the range of the
1457 composed buffer positions.
1458
e013fb34
CY
14592011-08-22 Chong Yidong <cyd@stupidchicken.com>
1460
1461 * image.c (gif_load): Don't assume that each subimage has the same
1462 dimensions as the base image. Handle disposal method that is
1463 "undefined" by the gif spec (Bug#9335).
1464
bd1ba3e8
CY
14652011-08-20 Chong Yidong <cyd@stupidchicken.com>
1466
1467 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1468 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1469
54a1215b
EZ
14702011-08-19 Eli Zaretskii <eliz@gnu.org>
1471
823564e5
EZ
1472 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1473 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1474 from an Org mode buffer to a Speedbar frame.
1475
54a1215b
EZ
1476 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1477 a composition, take its buffer position from IT->cmp_it.charpos.
1478 Fixes cursor positioning at the beginning of a line that begins
1479 with a composed character.
1480
9778ebcc
EZ
14812011-08-18 Eli Zaretskii <eliz@gnu.org>
1482
0be6ee06
EZ
1483 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1484 character bidirectional type, use STRONG_L instead. Fixes crashes
1485 in a buffer produced by `describe-categories'.
1486
9778ebcc
EZ
1487 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1488 members before the level stack, so they would be saved and
1489 restored when copying iterator state. Fixes incorrect reordering
1490 around TABs covered by display properties.
1491
156bffbe
AS
14922011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1493
6b02f655 1494 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1495
72ad093b
CY
14962011-08-17 Chong Yidong <cyd@stupidchicken.com>
1497
1498 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1499 (internal_condition_case_2, internal_condition_case_n):
1500 Remove unnecessary aborts (Bug#9081).
72ad093b 1501
35774242
EZ
15022011-08-17 Eli Zaretskii <eliz@gnu.org>
1503
1504 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1505 has no `load' handler, try opening the file locally. (Bug#9311)
1506
db76dd85
KB
15072011-08-16 Ken Brown <kbrown@cornell.edu>
1508
1509 * gmalloc.c: Expand comment.
1510
b215eee5
EZ
15112011-08-16 Eli Zaretskii <eliz@gnu.org>
1512
1513 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1514 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1515
a4579d33
KB
15162011-08-16 Ken Brown <kbrown@cornell.edu>
1517
1518 Fix memory allocation problems in Cygwin build (Bug#9273).
1519
1520 * unexcw.c ( __malloc_initialized): Declare external variable.
1521 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1522
8b76d6f8
SM
1523 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1524 New variables.
a4579d33
KB
1525 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1526 dumped emacs.
1527 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1528 in the static heap.
1529 [CYGWIN] (special_realloc): New function.
1530 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1531 requests to realloc storage in the static heap.
1532
3ebec551
PE
15332011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1534
1535 * bidi.c (bidi_initialize): Remove unused local.
1536
9fd8be00
EZ
15372011-08-15 Eli Zaretskii <eliz@gnu.org>
1538
6b02f655
SM
1539 * bidimirror.h:
1540 * biditype.h: Remove file.
1541 * makefile.w32-in ($(BLD)/bidi.$(O)):
1542 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1543
1544 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1545
1546 * chartab.c: Improve commentary for the uniprop_table API.
1547
32413314
EZ
1548 * bidi.c (bidi_paragraph_init): Support zero value of
1549 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1550 (bidi_initialize): Use uniprop_table instead of including
1551 biditype.h and bidimirror.h.
32413314 1552
9fd8be00
EZ
1553 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1554 coordinates of the iterator when restoring from ppos_it.
1555 (Bug#9296)
1556
5cf2b69b
KH
15572011-08-14 Kenichi Handa <handa@m17n.org>
1558
1559 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1560 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1561
daf17d00
EZ
15622011-08-14 Eli Zaretskii <eliz@gnu.org>
1563
1564 * xdisp.c (move_it_in_display_line_to): Don't invoke
1565 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1566 ppos_it. Fixes vertical cursor motion when line beginning is
1567 covered by an image. (Bug#9296)
1568
08e3161a
JD
15692011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1570
1571 * nsterm.h (ns_run_ascript): Declare.
1572 (NSAPP_DATA2_RUNASSCRIPT): Define.
1573
1574 * nsfns.m (as_script, as_result, as_status): New static variables.
1575 (ns_run_ascript): New function.
5e617bc2 1576 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1577 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1578 the event loop. Get status from as_status (Bug#7276).
1579
1580 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1581 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1582 the event loop (Bug#7276).
1583
a3720aa2
AS
15842011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1585
1586 * gnutls.c (QCgnutls_bootprop_priority)
1587 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1588 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1589 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1590 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1591 (QCgnutls_bootprop_verify_hostname_error)
1592 (QCgnutls_bootprop_callbacks_verify): Rename from
1593 Qgnutls_bootprop_..., all uses changed.
1594
1595 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1596 uses changed.
1597
0a0d27fb
PE
15982011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1599
19d5c50c
PE
1600 * xfaces.c (Qframe_set_background_mode): Now static.
1601 * dispextern.h (Qframe_set_background_mode): Remove decl.
1602
0a0d27fb
PE
1603 * process.c (Fnetwork_interface_info): Declare local only if needed.
1604
377538cb
JD
16052011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1606
1607 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1608 (Fnetwork_interface_list): Allocate in increments of bytes instead
1609 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1610 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1611 sockaddr.
1612 (struct ifflag_def): notrailers is smart on OSX.
1613 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1614 Get hardware address with getifaddrs if available.
1615
08fff70c
EZ
16162011-08-12 Eli Zaretskii <eliz@gnu.org>
1617
1618 * xdisp.c (iterate_out_of_display_property): xassert that
1619 IT->position is set to within IT->object's boundaries. Break from
1620 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1621 when IT->position is set up wrongly due to some bug.
1622 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1623 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1624 entry. Force push_it to save on the stack the current
1625 buffer/string position, to be restored by pop_it. Fix flags in
1626 the iterator structure wrt the object coming from a display
1627 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1628 properties. (Bug#9284)
1629
7be1c708 16302011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1631
7be1c708
CY
1632 * fontset.c (fontset_get_font_group): Add proper type checks.
1633 (Bug#9172)
aac0c6e3 1634
7be1c708 16352011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1636
7be1c708
CY
1637 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1638 and LC_VERSION_MIN_MACOSX.
1639 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1640 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1641
97bb72a6
EZ
16422011-08-08 Eli Zaretskii <eliz@gnu.org>
1643
1644 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1645 no-display-properties-and-no-overlays under bidi display.
1646 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1647 properties and overlays.
97bb72a6 1648
d5617611
CY
16492011-08-08 Chong Yidong <cyd@stupidchicken.com>
1650
37e11a63
CY
1651 * editfns.c (Fset_time_zone_rule): Document relationship with the
1652 setenv function.
1653
d5617611
CY
1654 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1655 the font entity extracted from the cache (Bug#8109).
1656
58872834
CY
16572011-08-07 Chong Yidong <cyd@stupidchicken.com>
1658
1659 * composite.c (autocmp_chars): Don't reset point. That is done by
1660 restore_point_unwind (Bug#5984).
1661
75bfc667
JL
16622011-08-07 Juri Linkov <juri@jurta.org>
1663
1664 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1665 to show the arg `TIME' instead of `TIMEVAL'.
1666
d1410150
EZ
16672011-08-06 Eli Zaretskii <eliz@gnu.org>
1668
1669 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1670 display property strides EOL and includes a newline, as in
1671 longlines-mode. (Bug#9254)
75b771e4
EZ
1672 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1673 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1674
1675 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1676 is non-zero, even if the data buffer is NULL. Fixes a crash in
1677 vertical-motion with longlines-mode. (Bug#9254)
1678
35928349
EZ
16792011-08-05 Eli Zaretskii <eliz@gnu.org>
1680
ec7cc85b
EZ
1681 * bidi.c <bidi_cache_total_alloc>: Now static.
1682 (bidi_initialize): Initialize bidi_cache_total_alloc.
1683
8b76d6f8 1684 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1685 cache. (Bug#9221)
1686
1687 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1688 amount allocated this far in `bidi_cache_total_alloc'.
1689 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1690 non-zero, only free the data buffer without restoring the cache
1691 contents. All callers changed.
1692
1693 * dispextern.h (bidi_unshelve_cache): Update prototype.
1694
1695 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1696 (move_it_in_display_line, move_it_to)
1697 (move_it_vertically_backward, move_it_by_lines): Replace the call
1698 to xfree to an equivalent call to bidi_unshelve_cache.
1699 (move_it_in_display_line_to): Fix logic of returning
412b6358 1700 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1701
e2e2423b
EZ
17022011-08-05 Eli Zaretskii <eliz@gnu.org>
1703
1704 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1705 came from a string character with a `cursor' property. (Bug#9229)
1706
ae9e757a
JD
17072011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1708
1709 * Makefile.in (LIB_PTHREAD): New variable.
1710 (LIBES): Add LIB_PTHREAD (Bug#9216).
1711
1712 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1713 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1714
213bd7f2
AS
17152011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1716
6b02f655 1717 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1718
99aaf75f
JD
17192011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1720
1721 * xterm.c (x_find_topmost_parent): New function.
1722 (x_set_frame_alpha): Find topmost parent window with
1723 x_find_topmost_parent and set the property there also (bug#9181).
1724 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1725
c74e9d86
PE
17262011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1727
1728 * callproc.c (Fcall_process): Avoid vfork clobbering
1729 the local vars buffer, coding_systems, current_dir.
1730
640c8776
SM
17312011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1732
1733 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1734
f26d0e4c
PE
17352011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1736
8a10d76c
PE
1737 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1738 so that it is not optimized away.
1739
f26d0e4c
PE
1740 * xdisp.c (compute_display_string_pos): Remove unused local.
1741
55439c61
EZ
17422011-08-02 Eli Zaretskii <eliz@gnu.org>
1743
1744 Fix slow cursor motion and scrolling in large buffers with
1745 selective display, like Org Mode buffers. (Bug#9218)
1746
1747 * dispextern.h (struct bidi_it): New member disp_prop_p.
1748
1749 * xdisp.c: Remove one-slot cache of display string positions.
1750 (compute_display_string_pos): Accept an additional argument
5e617bc2 1751 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1752 for a display string or property. If found, set DISP_PROP_P
1753 non-zero.
1754
1755 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1756 DISP_PROP_P, and pass it to compute_display_string_pos.
1757 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1758 non-zero. All callers of bidi_fetch_char changed.
1759
fb33fa43
SM
17602011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1761
1762 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1763
b099e063
DM
17642010-12-03 Don March <don@ohspite.net>
1765
1766 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1767 last character M-[char] is translated to ESC [char] (bug#7541).
1768
5cc7f7af
KH
17692011-08-02 Kenichi Handa <handa@m17n.org>
1770
d0fffa3f 1771 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1772
1773 * chartab.c (uniprop_table): Make it non-static.
1774
525d5e6e
EZ
17752011-08-01 Eli Zaretskii <eliz@gnu.org>
1776
1777 * xdisp.c (forward_to_next_line_start): Accept additional argument
1778 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1779 on the newline.
1780 (reseat_at_next_visible_line_start): Use the bidi iterator state
1781 returned by forward_to_next_line_start to restore the state of
1782 it->bidi_it after backing up to previous newline. (Bug#9212)
1783
31011111
AS
17842011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1785
1786 * regex.c (re_comp): Protoize.
1787 (re_exec): Fix return type.
1788 (regexec): Fix type of `ret'. (Bug#9203)
1789
476371c4
PE
17902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1791
e5d76069
PE
1792 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1793 This is needed if max-image-size is a floating-point number.
1794
9a79b20c
AS
17952011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1796
1797 * print.c (print_object): Print empty symbol as ##.
1798
1799 * lread.c (read1): Read ## as empty symbol.
1800
d8c2fa78
AA
18012011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1802
1803 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1804 setting frame foreground color (Bug#9175).
1805 (x_set_background_color): Likewise.
1806
ffe57a7a
AA
1807 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1808 contents (Bug#9176).
1809 (EmacsTooltip -init): Remove bezels and add shadows to
1810 tooltip windows.
1811
bf3492a5
AA
1812 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1813 or scroll bar (Bug#8470).
1814
d55e9c53
AA
1815 * nsfont.m (nsfont_open): Remove assignment to voffset and
1816 unnecessary vars hshink, expand, hd, full_height, min_height.
1817 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1818
1819 * nsterm.h (nsfont_info): Remove voffset field.
1820
d8c2fa78 18212011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1822
1823 Implement strike-through and overline on NextStep (Bug#8863).
1824
1825 * nsfont.m (nsfont_open): Use underline position provided by font,
1826 instead of hard-coded value of 2.
1827 (nsfont_draw): Call ns_draw_text_decoration instead.
1828
1829 * nsterm.h: Add declaration for ns_draw_text_decoration.
1830
1831 * nsterm.m (ns_draw_text_decoration): New function for drawing
1832 underline, overline, and strike-through.
1833 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1834 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1835 accommodate underlining, etc.
4843aac3 1836
4cc60b9b
EZ
18372011-07-28 Eli Zaretskii <eliz@gnu.org>
1838
bc7ece87
EZ
1839 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1840 default.
4cc60b9b 1841
476371c4
PE
18422011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1843
66606eea
PE
1844 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1845 Without this fix, if a signal arrives just after memory fills up,
1846 'malloc' might be invoked reentrantly.
1847
476371c4
PE
1848 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1849 In other words, assume that every image size is allowed, on non-X
1850 hosts. This assumption is probably wrong, but it lets Emacs compile.
1851
f3fcc40d
AS
18522011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1853
1854 * regex.c (re_iswctype): Convert return values to boolean.
1855
350c992f
EZ
18562011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1857
1858 * xdisp.c (compute_display_string_pos): Don't use cached display
1859 string position if the buffer had its restriction changed.
1860 (Bug#9184)
1861
5266b4bb
PE
18622011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1863
1864 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1865
2573a837 18662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1867
41f55ccd 1868 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1869
39e378da
PE
1870 * bidi.c: Integer size and overflow fixes.
1871 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1872 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1873 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1874 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1875 (bidi_find_other_level_edge):
1876 Use ptrdiff_t instead of EMACS_INT where either will do.
1877 This works better on 32-bit hosts configured --with-wide-int.
1878 (bidi_cache_ensure_space): Check for size-calculation overflow.
1879 Use % rather than repeated addition, for better worst-case speed.
1880 Don't set bidi_cache_size until after xrealloc returns, because it
1881 might not return.
1882 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1883 (bidi_cache_ensure_space): Also check that the bidi cache size
1884 does not exceed that of the largest Lisp string or buffer. See Eli
1885 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1886
5e927815
PE
1887 * alloc.c (__malloc_size_t): Remove.
1888 All uses replaced by size_t. See Andreas Schwab's note
1889 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1890
ca4aa935
PE
1891 * image.c: Improve checking for integer overflow.
1892 (check_image_size): Assume that f is nonnull, since
1893 it is always nonnull in practice. This is one less thing to
1894 worry about when checking for integer overflow later.
1895 (x_check_image_size): New function, which checks for integer
1896 overflow issues inside X.
1897 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1898 This removes the need for a memory_full check.
1899 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1900 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1901 (xbm_read_bitmap_data): Change locals back to 'int', since
1902 their values must fit in 'int'.
1903 (xpm_load_image, png_load, tiff_load):
1904 Invoke x_create_x_image_and_pixmap earlier,
1905 to avoid much needless work if the image is too large.
1906 (tiff_load): Treat overly large images as if
1907 x_create_x_image_and_pixmap failed, not as malloc failures.
1908 (gs_load): Use x_check_image_size.
1909
5f8f9cc2
PE
1910 * gtkutil.c: Omit integer casts.
1911 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1912 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1913
5adf60bc
PE
1914 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1915
c8907a93
PE
1916 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1917 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1918 would wrongly return t on a 64-bit host.
1919
e3c25c68
PE
1920 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1921 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1922 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1923 and therefore cause GCC to emit a bogus diagnostic in some cases.
1924
3f791afe
PE
1925 * image.c: Integer signedness and overflow and related fixes.
1926 This is not an exhaustive set of fixes, but it's time to
1927 record what I've got.
1928 (lookup_pixel_color, check_image_size): Remove redundant decls.
1929 (check_image_size): Don't assume that arbitrary EMACS_INT values
1930 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1931 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1932 (tiff_load, imagemagick_load_image):
1933 Check for overflow in size calculations.
1934 (x_create_x_image_and_pixmap): Remove unnecessary test for
1935 xmalloc returning NULL; that can't happen.
1936 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1937 (xpm_color_bucket): Use better integer hashing function.
1938 (xpm_cache_color): Don't possibly over-allocate memory.
1939 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1940 (gif_memory_source):
1941 Use ptrdiff_t, not int or size_t, to record sizes.
1942 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1943 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1944 either works, as we prefer signed integers.
1945 (tiff_read_from_memory, tiff_write_from_memory):
1946 Return tsize_t, not size_t, since that's what the TIFF API wants.
1947 (tiff_read_from_memory): Don't fail simply because the read would
1948 go past EOF; instead, return a short read.
1949 (tiff_load): Omit no-longer-needed casts.
1950 (Fimagemagick_types): Don't assume size fits into 'int'.
1951
3cc5a532
PE
1952 Improve hashing quality when configured --with-wide-int.
1953 * fns.c (hash_string): New function, taken from sxhash_string.
1954 Do not discard information about ASCII character case; this
1955 discarding is no longer needed.
1956 (sxhash-string): Use it. Change sig to match it. Caller changed.
1957 * lisp.h: Declare it.
1958 * lread.c (hash_string): Remove, since we now use fns.c's version.
1959 The fns.c version returns a wider integer if --with-wide-int is
1960 specified, so this should help the quality of the hashing a bit.
1961
b312a492
PE
1962 * emacs.c: Integer overflow minor fix.
1963 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1964 Define only if GNU_LINUX.
1965 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1966
dfd153ae
PE
1967 * dispnew.c: Integer signedness and overflow fixes.
1968 Remove unnecessary forward decls, that were a maintenance hassle.
1969 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1970 All uses changed.
1971 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1972 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1973 (prepare_desired_row, line_draw_cost):
1974 Use int, not unsigned, where either works.
1975 (save_current_matrix, restore_current_matrix):
1976 Use ptrdiff_t, not size_t, where either works.
1977 (init_display): Check for overflow more accurately, and without
1978 relying on undefined behavior.
1979
a81d11a3
PE
1980 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1981 Remove, replacing with the new symbols in lisp.h. All uses changed.
1982 * fileio.c (make_temp_name):
1983 * filelock.c (lock_file_1, lock_file):
1984 * xdisp.c (message_dolog):
1985 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1986 Use pMd etc. instead.
1987 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1988 replacing the pWIDE etc. symbols removed from editfns.c.
1989
3300e6fd
PE
1990 * keyboard.h (num_input_events): Now uintmax_t.
1991 This is (very slightly) less likely to mess up due to wraparound.
1992 All uses changed.
1993
fd05c7e9
PE
1994 * buffer.c: Integer signedness fixes.
1995 (alloc_buffer_text, enlarge_buffer_text):
1996 Use ptrdiff_t rather than size_t when either will do, as we prefer
1997 signed integers.
1998
903fe15d
PE
1999 * alloc.c: Integer signedness and overflow fixes.
2000 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2001 (__malloc_size_t): Default to size_t, not to int.
2002 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2003 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2004 Prefer ptrdiff_t to size_t when either would do, as we prefer
2005 signed integers.
2006 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2007 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2008 Now const. Initialize with values that are in range even if char
2009 is signed.
2010 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2011 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2012 These functions do the right thing with sizes > 2**32.
2013 (check_depth): Now ptrdiff_t, not int.
2014 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2015 Adjust to new way of storing sizes. Check for size overflow bugs
2016 in rest of code.
2017 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2018 slightly wrong anyway, as it missed one instance of
2019 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2020 (refill_memory_reserve): Omit needless cast to size_t.
2021 (mark_object_loop_halt): Mark as externally visible.
2022
ac82cc6a
PE
2023 * xselect.c: Integer signedness and overflow fixes.
2024 (Fx_register_dnd_atom, x_handle_dnd_message):
2025 Use ptrdiff_t, not size_t, since we prefer signed.
2026 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2027 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2028 x_dnd_atoms_size and x_dnd_atoms_length.
2029
c2d1e36d
PE
2030 * doprnt.c: Prefer signed to unsigned when either works.
2031 * eval.c (verror):
2032 * doprnt.c (doprnt):
2033 * lisp.h (doprnt):
2034 * xdisp.c (vmessage):
2035 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2036 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2037 prefer signed arithmetic to avoid comparison confusion.
2038 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2039 but is a bit tricky.
2040
0e926e56
PE
2041 Assume freestanding C89 headers, string.h, stdlib.h.
2042 * data.c, doprnt.c, floatfns.c, print.c:
2043 Include float.h unconditionally.
2044 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2045 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2046 * regex.c: Likewise for stddef.h, string.h.
2047 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2048 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2049 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2050 (STDC_HEADERS): Remove obsolete defines.
2051 * sysdep.c: Include limits.h unconditionally.
2052
9cfdb3ec
PE
2053 Assume support for memcmp, memcpy, memmove, memset.
2054 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2055 * regex.c (memcmp, memcpy):
2056 Remove; we assume C89 now.
2057
2058 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2059 (__malloc_safe_bcopy): Remove; no longer needed.
2060
cf950e6b 2061 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2062 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2063 well either way, and we prefer signed to unsigned.
2064
dbf38e02
LMI
20652011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2066
2067 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2068 closes the connection while we're reading (bug#9182).
2069
d6f0886c 20702011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2071
d6f0886c
JD
2072 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2073 are specified (Bug#9168).
24e0f6b1 2074
2eb1f9e6
PE
20752011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2076
2077 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2078 Found by GCC static checking and --with-wide-int on a 32-bit host.
2079
22381272 20802011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2081
2082 * xdisp.c (compute_display_string_pos): Fix logic of caching
2083 previous display string position. Initialize cached_prev_pos to
2084 -1. Fixes slow-down at the beginning of a buffer.
2085
f25e39b4
EZ
20862011-07-24 Eli Zaretskii <eliz@gnu.org>
2087
2088 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2089 for attrs[LFACE_FONTSET_INDEX].
2090
04c4b52e
PE
20912011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2092
2093 * xml.c (parse_region): Remove unused local
2094 that was recently introduced.
2095
c1734fbd
EZ
20962011-07-23 Eli Zaretskii <eliz@gnu.org>
2097
be18c5a5
EZ
2098 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2099 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2100
c1734fbd
EZ
2101 * xdisp.c (move_it_in_display_line_to): Record the best matching
2102 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2103 exit if none of the characters scanned was an exact match.
2104 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2105 when exact match is impossible due to invisible text, and the
2106 lines are truncated.
2107
a258d627
JD
21082011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2109
2110 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2111 for OSX >= 10.7.
2112
b6d5a689
EZ
21132011-07-22 Eli Zaretskii <eliz@gnu.org>
2114
0f74f785
EZ
2115 Fix a significant slow-down of cursor motion with C-n, C-p,
2116 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2117 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2118 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2119 (next_element_from_buffer): Call compute_stop_pos_backwards to
2120 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2121 base_level_stop.
2122 (reseat): Don't look for prev_stop, as that could mean a very long
2123 run.
2124 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2125 <cached_disp_overlay_modiff>: Cache for last found display string
2126 position.
551918c1 2127 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2128 about the same buffer in the same area of character positions, and
2129 the buffer wasn't changed since the time the display string
2130 position was cached.
551918c1 2131
b2d0c91a
EZ
21322011-07-22 Eli Zaretskii <eliz@gnu.org>
2133
2134 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2135 is an integer, which is important for empty lines. (Bug#9149)
2136
043604ee
CY
21372011-07-22 Chong Yidong <cyd@stupidchicken.com>
2138
2139 * frame.c (Fmodify_frame_parameters): In tty case, update the
2140 default face if necessary (Bug#4238).
2141
da4adb04
CY
21422011-07-21 Chong Yidong <cyd@stupidchicken.com>
2143
2144 * editfns.c (Fstring_to_char): No need to explain what a character
2145 is in the docstring (Bug#6576).
2146
9abd0532
LMI
21472011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2148
2149 * xml.c (parse_region): Make sure we always return a tree.
2150
36881d16
HK
21512011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2152
2153 * xml.c (parse_region): If a document contains only comments,
2154 return that, too.
2155
1e98674d
LMI
21562011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2157
2158 * xml.c (make_dom): Return comments, too.
2159
590bd467
PE
21602011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2161
2162 Port to OpenBSD.
2163 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2164 and the surrounding thread.
2165 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2166 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2167 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2168 timer goes off.
2169 * s/openbsd.h (BROKEN_SIGIO): Define.
2170 * unexelf.c (unexec) [__OpenBSD__]:
2171 Don't update the .mdebug section of the Alpha COFF symbol table.
2172
f41628b2
LMI
21732011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2174
2175 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2176 (bug#8460).
2177
b59b67c5
PE
21782011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2179
15e3a074
PE
2180 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2181 This fixes some race conditions on the permissions of any newly
2182 created file.
2183
41bed37d
PE
2184 * alloc.c (valid_pointer_p): Use pipe, not open.
2185 This fixes some permissions issues when debugging.
2186
b59b67c5
PE
2187 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2188 If fchown fails to set both uid and gid, try to set just gid,
2189 as that is sometimes allowed. Adjust the file's mode to eliminate
2190 setuid or setgid bits that are inappropriate if fchown fails.
2191
925a6be7
SM
21922011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2193
2194 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2195 to compare Lisp_Objects.
2196 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2197 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2198 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2199
52968808
AS
22002011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2201
0a6a104b
AS
2202 * lread.c (read_integer): Unread even EOF character.
2203 (read1): Likewise. Properly record start position of symbol.
2204
52968808
AS
2205 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2206 symbol character follows.
2207
9e381cdd
PE
22082011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2209
2210 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2211 This works around a problem with the previous change to Fcopy_file.
2212 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2213 and without this change, GCC might complain about discarding
2214 fchown's return value.
2215
b5641435
JB
22162011-07-16 Juanma Barranquero <lekktu@gmail.com>
2217
2218 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2219
a8031457
PE
22202011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2221
2222 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2223
dd889327
LMI
22242011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2225
750c33f7
LMI
2226 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2227 it's used from the C level.
2228
dd889327
LMI
2229 * process.c: Use the same condition for POLL_FOR_INPUT in both
2230 keyboard.c and process.c (bug#1858).
2231
87e86684
LM
22322011-07-09 Lawrence Mitchell <wence@gmx.li>
2233
2234 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2235 (Fgnutls_boot): Use it.
2236
64348f40
AS
22372011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2238
2239 * doc.c (Fsubstitute_command_keys): Revert last change.
2240
1d698799
LMI
22412011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2242
f863868c
LMI
2243 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2244 quotes the next character, and doesn't affect other longer
2245 sequences (bug#8935).
2246
1d698799
LMI
2247 * lread.c (syms_of_lread): Clarify that is isn't only
2248 `eval-buffer' and `eval-defun' that's affected by
2249 `lexical-binding' (bug#8460).
2250
aa4b6df6
EZ
22512011-07-15 Eli Zaretskii <eliz@gnu.org>
2252
2253 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2254 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2255
5d856da6
PE
22562011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2257
ad6042bb
PE
2258 Fix minor problems found by static checking.
2259 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2260 (elsz): Now a signed constant, not a size_t var. We prefer signed
2261 types to unsigned, to avoid integer comparison confusion. Without
2262 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2263 "cannot optimize loop, the loop counter may overflow", a symptom
2264 of the confusion.
f00bbb22 2265 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2266 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2267
6468f31c
LMI
22682011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2269
49080b10
LMI
2270 * search.c (Fre_search_backward): Mention `case-fold-search' in
2271 all the re_search_* functions (bug#8138).
2272
6468f31c
LMI
2273 * keyboard.c (Fopen_dribble_file): Document when the file is
2274 closed (bug#8056).
2275
c965adc5
EZ
22762011-07-14 Eli Zaretskii <eliz@gnu.org>
2277
df9733bf
EZ
2278 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2279 bidi_cache_idx.
2280
0bb23927
EZ
2281 Support bidi reordering of display and overlay strings.
2282 * xdisp.c (compute_display_string_pos)
2283 (compute_display_string_end): Accept additional argument STRING.
2284 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2285 (reseat_to_string): Initialize bidi_it->string.s and
2286 bidi_it->string.schars.
2287 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2288 NULL (avoids a crash in bidi_paragraph_init).
2289 Initialize itb.string.lstring.
0bb23927
EZ
2290 (init_iterator): Call bidi_init_it only of a valid
2291 buffer position was specified. Initialize paragraph_embedding to
2292 L2R.
2293 (reseat_to_string): Initialize the bidi iterator.
2294 (display_string): If we need to ignore text properties of
2295 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2296 original value of -1 will not work with bidi.)
2297 (compute_display_string_pos): First arg is now struct
2298 `text_pos *'; all callers changed. Support display properties on
2299 Lisp strings.
2300 (compute_display_string_end): Support display properties on Lisp
2301 strings.
2302 (init_iterator, reseat_1, reseat_to_string): Initialize the
2303 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2304 when iterating on a string not from display properties).
640c8776
SM
2305 (compute_display_string_pos, compute_display_string_end):
2306 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2307 arrow keys.
2308 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2309 base_level_stop; instead, set base_level_stop to BEGV.
2310 Fixes crashes in vertical-motion.
0bb23927
EZ
2311 (next_element_from_buffer): Improve commentary for when
2312 the iterator is before prev_stop.
2313 (init_iterator): Initialize bidi_p from the default value of
2314 bidi-display-reordering, not from buffer-local value. Use the
2315 buffer-local value only if initializing for buffer iteration.
2316 (handle_invisible_prop): Support invisible properties on strings
2317 that are being bidi-reordered.
2318 (set_iterator_to_next): Support bidi reordering of C strings and
2319 Lisp strings.
2320 (next_element_from_string): Support bidi reordering of Lisp
2321 strings.
2322 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2323 (display_string): Support display of R2L glyph rows.
2324 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2325 (init_iterator): Don't initialize it->bidi_p for strings
2326 here.
2327 (reseat_to_string): Initialize it->bidi_p for strings here.
2328 (next_element_from_string, next_element_from_c_string)
2329 (next_element_from_buffer): Add xassert's for correspondence
2330 between IT's object being iterated and it->bidi_it.string
2331 structure.
2332 (face_before_or_after_it_pos): Support bidi iteration.
2333 (next_element_from_c_string): Handle the case of the first string
2334 character that is not the first one in the visual order.
2335 (get_visually_first_element): New function, refactored from common
2336 parts of next_element_from_buffer, next_element_from_string, and
2337 next_element_from_c_string.
2338 (tool_bar_lines_needed, redisplay_tool_bar)
2339 (display_menu_bar): Force left-to-right direction. Add a FIXME
2340 comment for making that be controlled by a user option.
2341 (push_it, pop_it): Save and restore the state of the
2342 bidi iterator. Save and restore the bidi_p flag.
2343 (pop_it): Iterate out of display property for string iteration as
2344 well.
2345 (iterate_out_of_display_property): Support iteration over strings.
2346 (handle_single_display_spec): Set up it->bidi_it for iteration
2347 over a display string, and call bidi_init_it.
2348 (handle_single_display_spec, next_overlay_string)
2349 (get_overlay_strings_1, push_display_prop): Set up the bidi
2350 iterator for displaying display or overlay strings.
2351 (forward_to_next_line_start): Don't use the shortcut if
2352 bidi-iterating.
2353 (back_to_previous_visible_line_start): If handle_display_prop
2354 pushed the iterator stack, restore the internal state of the bidi
2355 iterator by calling bidi_pop_it same number of times.
2356 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2357 and we are bidi-iterating, don't decrement the iterator position;
2358 instead, set the first_elt flag in the bidi iterator, to produce
2359 the same effect.
2360 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2361 (push_display_prop): xassert that we are iterating a buffer.
2362 (push_it, pop_it): Save and restore paragraph_embedding member.
2363 (handle_single_display_spec, next_overlay_string)
2364 (get_overlay_strings_1, reseat_1, reseat_to_string)
2365 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2366 correctly. Don't assume unibyte strings are not bidi-reordered.
2367 (compute_display_string_pos)
2368 (compute_display_string_end): Fix handling the case of C string.
2369 (push_it, pop_it): Save and restore from_disp_prop_p.
2370 (handle_single_display_spec, push_display_prop): Set the
2371 from_disp_prop_p flag.
2372 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2373 (pop_it): Call iterate_out_of_display_property only if we are
2374 popping after iteration over a string that came from a display
2375 property. Fix a typo in popping stretch info. Add an assertion
2376 for verifying that the iterator position is in sync with the bidi
2377 iterator.
2378 (handle_single_display_spec, get_overlay_strings_1)
2379 (push_display_prop): Fix initialization of paragraph direction for
2380 string when that of the parent object is not yet determined.
2381 (reseat_1): Call bidi_init_it to resync the bidi
2382 iterator with IT's position. (Bug#7616)
2383 (find_row_edges): If ROW->start.pos gives position
2384 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2385 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2386 Reset the from_disp_prop_p flag.
2387 (SAVE_IT, RESTORE_IT): New macros.
2388 (pos_visible_p, face_before_or_after_it_pos)
2389 (back_to_previous_visible_line_start)
2390 (move_it_in_display_line_to, move_it_in_display_line)
2391 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2392 (try_scrolling, redisplay_window, display_line): Use them when
2393 saving a temporary copy of the iterator and restoring it back.
2394 (back_to_previous_visible_line_start, reseat_1)
2395 (init_iterator): Empty the bidi cache "stack".
2396 (move_it_in_display_line_to): If iterator ended up at
2397 EOL, but we never saw any buffer positions smaller than
2398 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2399 motion in bidi-reordered lines.
2400 (move_it_in_display_line_to): Record prev_method and prev_pos
2401 immediately before the call to set_iterator_to_next. Fixes cursor
2402 motion in bidi-reordered lines with stretch glyphs and strings
2403 displayed in margins. (Bug#8133) (Bug#8867)
2404 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2405 TO_CHARPOS.
640c8776
SM
2406 (pos_visible_p): Support positions in bidi-reordered lines.
2407 Save and restore bidi cache.
0bb23927
EZ
2408
2409 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2410 (bidi_paragraph_info): Delete unused struct.
2411 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2412 (bidi_cache_start): New variable.
2413 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2414 to zero.
2415 (bidi_cache_fetch_state, bidi_cache_search)
2416 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2417 (bidi_cache_find, bidi_peek_at_next_level)
2418 (bidi_level_of_next_char, bidi_find_other_level_edge)
2419 (bidi_move_to_visually_next): Compare cache index with
2420 bidi_cache_start rather than with zero.
2421 (bidi_fetch_char): Accept new argument STRING; all callers
2422 changed. Support iteration over a string. Support strings with
2423 display properties. Support unibyte strings. Fix the type of
2424 `len' according to what STRING_CHAR_AND_LENGTH expects.
2425 (bidi_paragraph_init, bidi_resolve_explicit_1)
2426 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2427 (bidi_level_of_next_char, bidi_move_to_visually_next):
2428 Support iteration over a string.
0bb23927
EZ
2429 (bidi_set_sor_type, bidi_resolve_explicit_1)
2430 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2431 can now be zero (for strings); special values 0 and -1 were
2432 changed to -1 and -2, respectively.
2433 (bidi_char_at_pos): New function.
2434 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2435 Call it instead of FETCH_MULTIBYTE_CHAR.
2436 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2437 initialized to valid values.
2438 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2439 values.
2440 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2441 the test for valid cached positions. Fix the logic for looking up
2442 the sentinel state in the cache. GCPRO the Lisp string we are
2443 iterating.
2444 (bidi_push_it, bidi_pop_it): New functions.
2445 (bidi_initialize): Initialize the bidi cache start stack pointer.
2446 (bidi_cache_ensure_space): New function, refactored from part of
2447 bidi_cache_iterator_state. Don't assume the required size is just
2448 one BIDI_CACHE_CHUNK away.
2449 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2450 (bidi_count_bytes, bidi_char_at_pos): New functions.
2451 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2452 always valid if bidi_cache_idx is valid.
2453 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2454 is valid if it's going to be used.
2455 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2456 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2457 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2458 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2459 (bidi_find_other_level_edge, bidi_cache_start_stack):
2460 All variables related to cache indices are now EMACS_INT.
c965adc5 2461
0bb23927
EZ
2462 * dispextern.h (struct bidi_string_data): New structure.
2463 (struct bidi_it): New member `string'. Make flag members be 1-bit
2464 fields, and put them last in the struct.
640c8776
SM
2465 (compute_display_string_pos, compute_display_string_end):
2466 Update prototypes.
0bb23927
EZ
2467 (bidi_push_it, bidi_pop_it): Add prototypes.
2468 (struct iterator_stack_entry): New members bidi_p,
2469 paragraph_embedding, and from_disp_prop_p.
2470 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2471 (bidi_shelve_cache, bidi_unshelve_cache):
2472 Declare prototypes.
0bb23927
EZ
2473
2474 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2475 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2476 and vector-like objects.
2477
2478 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2479 cache around display iteration.
2480
2481 * window.c (Fwindow_end, window_scroll_pixel_based)
2482 (displayed_window_lines, Frecenter): Save and restore the bidi
2483 cache around display iteration.
2484
3bbd2265
LMI
24852011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2486
2487 * editfns.c (Fdelete_region): Clarify the use of the named
2488 parameters (bug#6788).
2489
adc47434
MR
24902011-07-14 Martin Rudalics <rudalics@gmx.at>
2491
2492 * indent.c (Fvertical_motion): Set and restore w->pointm when
2493 saving and restoring the window's buffer (Bug#9006).
2494
837c31f8
LMI
24952011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2496
2497 * editfns.c (Fstring_to_char): Clarify just what is returned
2498 (bug#6576). Text by Eli Zaretskii.
2499
ac389d0c
JB
25002011-07-13 Juanma Barranquero <lekktu@gmail.com>
2501
2502 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2503
0be0ce47
EZ
25042011-07-13 Eli Zaretskii <eliz@gnu.org>
2505
2506 * buffer.c (mmap_find): Fix a typo.
2507
cd18e7e3
JB
25082011-07-13 Johan Bockgård <bojohan@gnu.org>
2509
2510 Fix execution of x selection hooks.
2511 * xselect.c (Qx_lost_selection_functions)
2512 (Qx_sent_selection_functions): New vars.
2513 (syms_of_xselect): DEFSYM them.
2514 (x_handle_selection_request): Pass Qx_sent_selection_functions
2515 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2516 (x_handle_selection_clear,x_clear_frame_selections):
2517 Pass Qx_lost_selection_functions rather than
2518 Vx_lost_selection_functions to Frun_hook_with_args.
2519
47ea7f44
PE
25202011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2521
ac389d0c 2522 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2523 The old code sometimes used this field without initializing it.
2524
47ea7f44
PE
2525 * alloc.c (gc_sweep): Don't read past end of array.
2526 In theory, the old code could also have corrupted Emacs internals,
2527 though it'd be very unlikely.
2528
bc985c87
AS
25292011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2530
2531 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2532 argument. (Bug#4026)
bc985c87 2533
0cf34688
LMI
25342011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2535
b3dadd76
LMI
2536 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2537 key" (bug#4257).
2538
0cf34688
LMI
2539 * window.c (Fset_window_start): Doc fix (bug#4199).
2540 (Fset_window_hscroll): Ditto.
2541
270768cd
PE
25422011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2543
077e3dda 2544 Fix minor new problems caught by GCC 4.6.1.
270768cd 2545 * term.c (init_tty): Remove unused local.
490011a6 2546 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2547 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2548 not used otherwise.
270768cd 2549
b1f58454
CY
25502011-07-12 Chong Yidong <cyd@stupidchicken.com>
2551
2552 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2553
22b9578d
LMI
25542011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2555
6e70ab07
LMI
2556 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2557 are the mini-buffer and the echo area (bug#3320).
2558
22b9578d
LMI
2559 * term.c (init_tty): Remove support for supdup, c10 and perq
2560 terminals, which are no longer supported (bug#1482).
2561
8974cc9f
JB
25622011-07-10 Johan Bockgård <bojohan@gnu.org>
2563
2564 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2565
a560d974
JD
25662011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2567
2568 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2569 for non-popups (Bug#3642).
2570
1dae0f0a
AS
25712011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2572
268c2c36 2573 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2574 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2575 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2576 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2577 * data.c (fmod): Likewise.
2578 * dispnew.c (swap_glyphs_in_rows): Likewise.
2579 * emacs.c (memory_warning_signal): Likewise.
2580 * floatfns.c (float_error): Likewise.
2581 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2582 (otf_open, font_otf_capability, generate_otf_features)
2583 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2584 Likewise.
2585 * image.c (pbm_read_file): Likewise.
2586 * indent.c (string_display_width): Likewise.
2587 * intervals.c (check_for_interval, search_for_interval)
2588 (inc_interval_count, count_intervals, root_interval)
2589 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2590 * lread.c (defalias): Likewise.
268c2c36 2591 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2592 * regex.c (set_image_of_range_1, set_image_of_range)
2593 (regex_grow_registers): Likewise.
2594 * sysdep.c (strerror): Likewise.
2595 * termcap.c (valid_filename_p, tprint, main): Likewise.
2596 * tparam.c (main): Likewise.
2597 * unexhp9k800.c (run_time_remap, save_data_space)
2598 (update_file_ptrs, read_header, write_header, calculate_checksum)
2599 (copy_file, copy_rest, display_header): Likewise.
2600 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2601 Likewise.
2602 * xdisp.c (check_it): Likewise.
2603 * xfaces.c (register_color, unregister_color, unregister_colors):
2604 Likewise.
2605 * xfns.c (print_fontset_result): Likewise.
2606 * xrdb.c (member, fatal, main): Likewise.
2607
99033785
PE
26082011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2609
2610 Fix minor problems found by static checking (Bug#9031).
2611 * chartab.c (char_table_set_range, map_sub_char_table):
2612 Remove unused locals.
2613 (uniprop_table): Now static.
2614 * composite.c (_work_char): Remove unused static var.
2615
9cb2ac56
JB
26162011-07-09 Juanma Barranquero <lekktu@gmail.com>
2617
2618 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2619
f25661f0
JD
26202011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2621
2622 * gtkutil.c (qttip_cb): Remove code without function.
2623
8278c4fe
EZ
26242011-07-09 Eli Zaretskii <eliz@gnu.org>
2625
2626 * w32.c (pthread_sigmask): New stub.
2627
1692ae2d 26282011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2629
8a6ebd58 2630 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2631 sigprocmask is portable only for single-threaded applications, and
2632 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2633 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2634 (LIBES): Use it.
2635 * callproc.c (Fcall_process):
2636 * process.c (create_process):
2637 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2638 Use pthread_sigmask, not sigprocmask.
123403e4 2639
1b854618
JD
26402011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2641
2642 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2643 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2644 wrong (Bug#8591).
2645
3fe4b549
JD
26462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2647
0ce7e563
JD
2648 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2649 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2650 (xg_hide_tooltip): Fix comment.
2651
3fe4b549
JD
2652 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2653 in registerServicesMenuSendTypes.
2654 (validRequestorForSendType): Don't check ns_return_types.
2655
2656 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2657 ns_return_type.
2658
5df75e47
JR
26592011-07-08 Jason Rumney <jasonr@gnu.org>
2660
2661 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2662 frame struct members of non-existent frames (Bug#6284).
2663
699c10bd
JD
26642011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2665
4393663b
JD
2666 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2667 variable firstTime not needed on OSX >= 10.6.
2668 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2669 >= 10.5. Use setKnobProportion, setDoubleValue.
2670
2671 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2672 (MAC_OS_X_VERSION_10_5): Define if not defined.
2673 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2674 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2675 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2676
2677 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2678 cString and lossyCString on OSX >= 10.4
2679
2680 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2681 sizeToFit on OSX >= 10.2.
2682
2683 * nsimage.m (allocInitFromFile): Don't use deprecated method
2684 bestRepresentationForDevice on OSX >= 10.6.
2685
2686 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2687 to avoid warning.
2688
2689 * emacs.c: Declare unexec_init_emacs_zone.
2690
a63e0781
JD
2691 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2692
699c10bd
JD
2693 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2694
2695 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2696 on svcsMenu (Bug#8842).
2697
2698 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2699 ns_return_types.
2700 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2701
2702 * nsterm.m (QUTF8_STRING): Declare.
2703 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2704 (validRequestorForSendType): Return type is (id).
2705 Change indexOfObjectIdenticalTo to indexOfObject.
2706 Check if we have local selection before returning self (Bug#8842).
2707 (writeSelectionToPasteboard): Put local selection into paste board
2708 if we have a local selection (Bug#8842).
2709 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2710
2711 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2712 (ns_get_local_selection): Declare.
2713
54e10184
LMI
27142011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2715
9888ff71
LMI
2716 * keymap.c (describe_map_tree): Don't insert a double newline at
2717 the end of the buffer (bug#1169) and return whether we inserted
2718 something.
2719
54e10184
LMI
2720 * callint.c (Fcall_interactively): Change "reading args" to
2721 "providing args" to try to clarify what it does (bug#1010).
2722
15fa4783
KH
27232011-07-07 Kenichi Handa <handa@m17n.org>
2724
2725 * composite.c (composition_compute_stop_pos): Ignore a static
2726 composition starting before CHARPOS (Bug#8915).
2727
2728 * xdisp.c (handle_composition_prop): Likewise.
2729
a8815b00
EZ
27302011-07-07 Eli Zaretskii <eliz@gnu.org>
2731
2732 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2733 (Bug#9015)
2734
ef7b981d 27352011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2736
2737 * character.h (unicode_category_t): New enum type.
2738
2739 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2740 (Qchar_code_property_table): New variable.
2741 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2742 (UNIPROP_COMPRESSED_FORM_P): New macros.
2743 (char_table_ascii): Uncompress the compressed values.
2744 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2745 Uncompress the compressed values.
ac389d0c 2746 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2747 (char_table_ref_and_range): Uncompress the compressed values.
2748 (sub_char_table_set): New arg is_uniprop. Callers changed.
2749 Uncompress the compressed values.
2750 (sub_char_table_set_range): Args changed. Callers changed.
2751 (char_table_set_range): Adjuted for the above change.
2752 (map_sub_char_table): Delete args default_val and parent. Add arg
2753 top. Give decoded values to a Lisp function.
640c8776 2754 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2755 values to a Lisp function. Gcpro more variables.
2756 (uniprop_table_uncompress)
2757 (uniprop_decode_value_run_length): New functions.
2758 (uniprop_decoder, uniprop_decoder_count): New variables.
2759 (uniprop_get_decoder, uniprop_encode_value_character)
2760 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2761 New functions.
2762 (uniprop_encoder, uniprop_encoder_count): New variables.
2763 (uniprop_get_encoder, uniprop_table)
2764 (Funicode_property_table_internal, Fget_unicode_property_internal)
2765 (Fput_unicode_property_internal): New functions.
2766 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2767 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2768 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2769 char-code-property-alist.
2770
640c8776 2771 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2772 Vunicode_category_table.
2773
640c8776 2774 * font.c (font_range): Adjust for the change of
c805dec0
KH
2775 Vunicode_category_table.
2776
76b397fb
DN
27772011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2778
2779 * m/iris4d.h: Remove file, move contents ...
2780 * s/irix6-5.h: ... here.
2781
22b4128e
PE
27822011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2783
2784 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2785 * alloc.c (mark_buffer):
2786 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2787 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2788 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2789 This isn't true in general, and it's particularly not true
2790 if Emacs is configured with --with-wide-int.
2791 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2792 New macros, used in the buffer.c change.
2793
869795d6
JD
27942011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2795
2796 * xsettings.c: Use both GConf and GSettings if both are available.
2797 (store_config_changed_event): Add comment.
2798 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2799 (store_tool_bar_style_changed): New functions.
5e617bc2 2800 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2801 (struct xsettings): Move font inside HAVE_XFT.
2802 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2803 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2804 Move inside HAVE_XFT.
640c8776 2805 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2806 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2807 also.
2808 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2809 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2810 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2811 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2812 (parse_settings): Move check for font inside HAVE_XFT.
2813 (read_settings, apply_xft_settings): Add comment.
2814 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2815 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2816 call store_font_name_changed.
2817 (xft_settings_event): Add comment.
2818 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2819 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2820 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2821 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2822 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2823 (xsettings_get_system_font, xsettings_get_system_normal_font):
2824 Add comment.
869795d6 2825
d8ed26bd
PE
28262011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2827
2828 Random fixes. E.g., (random) never returned negative values.
2829 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2830 subseconds part to the entropy, as that's a bit more random.
2831 Prefer signed to unsigned, since the signedness doesn't matter and
2832 in general we prefer signed. When given a limit, use a
2833 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2834 latter isn't right if USE_2_TAGS_FOR_INTS.
2835 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2836 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2837
cabf1cac
SM
28382011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2839
2840 * textprop.c (text_property_stickiness):
2841 Obey Vtext_property_default_nonsticky.
2842 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2843 * w32fns.c (syms_of_w32fns):
2844 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2845
6e9b2be9
PE
28462011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2847
2848 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2849 This is more efficient than Ffile_directory_p and avoids a minor race.
2850
90186c68
LMI
28512011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2852
7c301272
LMI
2853 * buffer.c (Foverlay_put): Say what the return value is
2854 (bug#7835).
2855
c4f2d8d4
LMI
2856 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2857 is a directory before asking whether to use the file name
2858 (bug#7564).
ad637907
LMI
2859 (barf_or_query_if_file_exists): Make the "File is a directory"
2860 error be more correct.
c4f2d8d4 2861
90186c68
LMI
2862 * fns.c (Frequire): Remove the mention of the .gz files, since
2863 that's installation-specific, but keep the mention of
2864 `get-load-suffixes'.
2865
da64016e
PE
28662011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2867
2868 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2869 Report string overflow if the output is too long.
2870
7d47b580
JB
28712011-07-04 Juanma Barranquero <lekktu@gmail.com>
2872
a555cb87
JB
2873 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2874 (syms_of_gnutls): Remove duplicate DEFSYM for
2875 Qgnutls_bootprop_verify_hostname_error, an error for
2876 Qgnutls_bootprop_verify_error (which is no longer used).
2877
7d47b580
JB
2878 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2879 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2880 Also (re)move comments that are misplaced or no longer relevant.
2881
1e49bfab
LMI
28822011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2883
2884 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2885
1485f4c0
CY
28862011-07-03 Chong Yidong <cyd@stupidchicken.com>
2887
2888 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2889 and background color parameters if they have been changed.
2890
a9ab721e
LMI
28912011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2892
2893 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2894
cf7cff57
PE
28952011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2896
2e13213d
PE
2897 * xsettings.c (SYSTEM_FONT): Define only when used.
2898 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2899
cf7cff57
PE
2900 * keymap.c (access_keymap_1): Now static.
2901
7a8e04f7
CY
29022011-07-02 Chong Yidong <cyd@stupidchicken.com>
2903
2904 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2905 leave any prefix arg for the up event (Bug#1586).
2906
61352f62
LMI
29072011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2908
69bb1ef7
LMI
2909 * lread.c (syms_of_lread): Mention single symbols defined by
2910 `defvar' or `defconst' (bug#7154).
2911
61352f62 2912 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2913 (Frequire): Mention get-load-suffixes.
61352f62 2914
28545e04
MR
29152011-07-02 Martin Rudalics <rudalics@gmx.at>
2916
2917 * window.h (window): Remove clone_number slot.
2918 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2919 Remove.
2920 (make_parent_window, make_window, saved_window)
2921 (Fset_window_configuration, save_window_save): Don't deal with
2922 clone numbers.
2923 * buffer.c (Qclone_number): Remove declaration.
2924 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2925
3349e122
SM
29262011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2927
2928 Add multiple inheritance to keymaps.
2929 * keymap.c (Fmake_composed_keymap): New function.
2930 (Fset_keymap_parent): Simplify.
2931 (fix_submap_inheritance): Remove.
2932 (access_keymap_1): New function extracted from access_keymap to handle
2933 embedded parents and handle lists of maps.
2934 (access_keymap): Use it.
2935 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2936 (Fcopy_keymap): Handle embedded parents.
2937 (Fcommand_remapping, define_as_prefix): Simplify.
2938 (Fkey_binding): Simplify.
2939 (syms_of_keymap): Move minibuffer-local-completion-map,
2940 minibuffer-local-filename-completion-map,
2941 minibuffer-local-must-match-map, and
2942 minibuffer-local-filename-must-match-map to Elisp.
2943 (syms_of_keymap): Defsubr make-composed-keymap.
2944 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2945 (parse_menu_item): Trivial simplification.
2946
3279eb87
GM
29472011-07-01 Glenn Morris <rgm@gnu.org>
2948
2949 * Makefile.in (SETTINGS_LIBS): Fix typo.
2950
4550efdf
KI
29512011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2952
2953 * coding.c (Fencode_coding_string): Record the last coding system
2954 used, as the function doc string says (bug#8738).
2955
0949d2b6
JD
29562011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2957
2958 * xsettings.c (store_monospaced_changed): Take new font as arg and
2959 check for change against current_mono_font.
2960 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2961 (emacs_settings_constructor, emacs_settings_get_property)
2962 (emacs_settings_set_property, emacs_settings_class_init)
2963 (emacs_settings_init, gsettings_obj): Remove.
2964 (something_changedCB): New function for HAVE_GSETTINGS.
2965 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2966 with value as argument.
2967 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2968 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2969 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2970 "changed".
2971
2972 * xgselect.c: Add defined (HAVE_GSETTINGS).
2973 (xgselect_initialize): Ditto.
2974
2975 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2976 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2977 xg_select.
2978
bbc6b304
PE
29792011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2980
2981 * eval.c (struct backtrace): Simplify and port the data structure.
2982 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2983 signed bit field, as this assumption is not portable and it makes
2984 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2985 "char debug_on_exit : 1" as this is not portable either; instead,
2986 use the portable "unsigned int debug_on_exit : 1". Remove unused
2987 member evalargs. Remove obsolete comments about cc bombing out.
2988
9851bfc5
JD
29892011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2990
51bb811f 2991 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2992 Let HAVE_GSETTINGS override HAVE_GCONF.
2993 (store_monospaced_changed): New function.
2994 (EMACS_SETTINGS): A new type derived from GObject to handle
2995 GSettings notifications.
2996 (emacs_settings_constructor, emacs_settings_get_property)
2997 (emacs_settings_set_property, emacs_settings_class_init):
2998 New functions.
2999 (gsettings_client, gsettings_obj): New variables.
3000 (GSETTINGS_SCHEMA): New define.
3001 (something_changedCB): Call store_monospaced_changed.
3002 (init_gsettings): New function.
3003 (xsettings_initialize): Call init_gsettings.
3004 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3005 to NULL.
3006
640c8776 3007 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3008 GCONF_CFLAGS/LIBS.
3009
5386012d
MR
30102011-06-29 Martin Rudalics <rudalics@gmx.at>
3011
3012 * window.c (resize_root_window, grow_mini_window)
3013 (shrink_mini_window): Rename Qresize_root_window to
3014 Qwindow_resize_root_window and Qresize_root_window_vertically to
3015 Qwindow_resize_root_window_vertically.
3016
f13e0b08
PE
30172011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3018
3019 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3020
94515237
JB
30212011-06-27 Juanma Barranquero <lekktu@gmail.com>
3022
3023 * makefile.w32-in: Redesign dependencies so they reflect more
3024 clearly which files are directly included by each source file,
3025 and not through other includes.
3026
e43b6e43
MR
30272011-06-27 Martin Rudalics <rudalics@gmx.at>
3028
3029 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3030 (sort_overlays, overlay_strings): When an overlay's clone number
3031 matches the window's clone number process the overlay even if
3032 the overlay's window property doesn't match the current window.
3033
d68443dc
MR
3034 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3035 (Fwindow_hchild): Rename to Fwindow_left_child.
3036 (Fwindow_next): Rename to Fwindow_next_sibling.
3037 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3038 (resize_window_check): Rename to window_resize_check.
3039 (resize_window_apply): Rename to window_resize_apply.
3040 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3041 (Fdelete_other_windows_internal, resize_frame_windows)
3042 (Fsplit_window_internal, Fdelete_window_internal)
3043 (grow_mini_window, shrink_mini_window)
3044 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3045
c7e73be5
JD
30462011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3047
3048 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3049 (emacs_fixed_set_min_size): Remove.
3050 (emacs_fixed_new): Take frame as argument.
3051
3052 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3053 (_EmacsFixedPrivate): Remove minwidth/height.
3054 Add struct frame *f.
3055 (emacs_fixed_init): Initialize priv->f.
3056 (get_parent_class, emacs_fixed_set_min_size): Remove.
3057 (emacs_fixed_new): Set priv->f to argument.
3058 (emacs_fixed_get_preferred_width)
3059 (emacs_fixed_get_preferred_height): Use min_width/height from
3060 frames size_hint to set minimum and natural (Bug#8919).
3061 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3062 and use min_width/height from frames size_hint to set
3063 min_width/height (Bug#8919).
3064
3065 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3066 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3067 Fix indentation.
c7e73be5 3068
cf99dcf8
EZ
30692011-06-26 Eli Zaretskii <eliz@gnu.org>
3070
3071 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3072 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3073 called at ZV.
3074
029529ac
CY
30752011-06-26 Chong Yidong <cyd@stupidchicken.com>
3076
3077 * process.c (wait_reading_process_output): Bypass select if
3078 waiting for a cell while ignoring keyboard input, and input is
3079 pending. Suggested by Jan Djärv (Bug#8869).
3080
7a7ef429
PE
30812011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3082
3083 Use gnulib's dup2 module instead of rolling our own.
3084 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3085
11fdef7d 30862011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3087
3088 * dispnew.c (scrolling_window): Before scrolling, turn off a
3089 mouse-highlight in the window being scrolled.
3090
cd3520a4
JB
30912011-06-24 Juanma Barranquero <lekktu@gmail.com>
3092
3093 Move DEFSYM to lisp.h and use everywhere.
3094
3095 * character.h (DEFSYM): Move declaration...
3096 * lisp.h (DEFSYM): ...here.
3097
3098 * gnutls.c:
3099 * minibuf.c:
3100 * w32menu.c:
3101 * w32proc.c:
3102 * w32select.c: Don't include character.h.
3103
3104 * alloc.c (syms_of_alloc):
3105 * buffer.c (syms_of_buffer):
3106 * bytecode.c (syms_of_bytecode):
3107 * callint.c (syms_of_callint):
3108 * casefiddle.c (syms_of_casefiddle):
3109 * casetab.c (init_casetab_once):
3110 * category.c (init_category_once, syms_of_category):
3111 * ccl.c (syms_of_ccl):
3112 * cmds.c (syms_of_cmds):
3113 * composite.c (syms_of_composite):
3114 * dbusbind.c (syms_of_dbusbind):
3115 * dired.c (syms_of_dired):
3116 * dispnew.c (syms_of_display):
3117 * doc.c (syms_of_doc):
3118 * editfns.c (syms_of_editfns):
3119 * emacs.c (syms_of_emacs):
3120 * eval.c (syms_of_eval):
3121 * fileio.c (syms_of_fileio):
3122 * fns.c (syms_of_fns):
3123 * frame.c (syms_of_frame):
3124 * fringe.c (syms_of_fringe):
3125 * insdel.c (syms_of_insdel):
3126 * keymap.c (syms_of_keymap):
3127 * lread.c (init_obarray, syms_of_lread):
3128 * macros.c (syms_of_macros):
3129 * msdos.c (syms_of_msdos):
3130 * print.c (syms_of_print):
3131 * process.c (syms_of_process):
3132 * search.c (syms_of_search):
3133 * sound.c (syms_of_sound):
3134 * syntax.c (init_syntax_once, syms_of_syntax):
3135 * terminal.c (syms_of_terminal):
3136 * textprop.c (syms_of_textprop):
3137 * undo.c (syms_of_undo):
3138 * w32.c (globals_of_w32):
3139 * window.c (syms_of_window):
3140 * xdisp.c (syms_of_xdisp):
3141 * xfaces.c (syms_of_xfaces):
3142 * xfns.c (syms_of_xfns):
3143 * xmenu.c (syms_of_xmenu):
3144 * xsettings.c (syms_of_xsettings):
3145 * xterm.c (syms_of_xterm): Use DEFSYM.
3146
4228cf16
TZ
31472011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3148
cd3520a4 3149 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3150
7fcccf1e
PE
31512011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3152
7efb4e0e
PE
3153 Integer and buffer overflow fixes (Bug#8873).
3154
ff5844ad
PE
3155 * print.c (printchar, strout): Check for string overflow.
3156 (PRINTPREPARE, printchar, strout):
3157 Don't set size unless allocation succeeds.
3158
90532f02
PE
3159 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3160 for sizes. Check for string overflow more accurately.
3161 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3162
6d84508d
PE
3163 * macros.c: Integer and buffer overflow fixes.
3164 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3165 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3166 Use ptrdiff_t, not int, for sizes.
3167 Don't increment bufsize until after realloc succeeds.
3168 Check for size-calculation overflow.
3169 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3170
437b2cb4
PE
3171 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3172
8b9ac8b4
PE
3173 * lread.c: Integer overflow fixes.
3174 (read_integer): Radix is now EMACS_INT, not int,
3175 to improve quality of diagnostics for out-of-range radices.
3176 Calculate buffer size correctly for out-of-range radices.
3177 (read1): Check for integer overflow in radices, and in
3178 read-circle numbers.
82cb60d3
PE
3179 (read_escape): Avoid int overflow.
3180 (Fload, openp, read_buffer_size, read1)
3181 (substitute_object_recurse, read_vector, read_list, map_obarray):
3182 Use ptrdiff_t, not int, for sizes.
3183 (read1): Use EMACS_INT, not int, for sizes.
20270765 3184 Check for size overflow.
8b9ac8b4 3185
7fcccf1e
PE
3186 * image.c (cache_image): Check for size arithmetic overflow.
3187
bfbbd7e7
PE
3188 * lread.c: Integer overflow issues.
3189 (saved_doc_string_size, saved_doc_string_length)
3190 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3191 Now ptrdiff_t, not int.
3192 (read1): Don't assume doc string length fits in int. Check for
3193 out-of-range doc string lengths.
3194 (read_list): Don't assume file position fits in int.
39019e54 3195 (read_escape): Check for hex character overflow.
bfbbd7e7 3196
4e323265
LL
31972011-06-22 Leo Liu <sdl.web@gmail.com>
3198
3199 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3200 Move to minibuffer.el.
3201
85fece3e
PE
32022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3203
20b84ce9 3204 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3205 The following patches are for when GLYPH_DEBUG && !XASSERT.
3206 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3207 * dispnew.c (flush_stdout):
3208 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3209 Mark as externally visible.
3210 * dispnew.c (check_window_matrix_pointers): Now static.
3211 * dispnew.c (window_to_frame_vpos):
3212 * xfns.c (unwind_create_frame):
3213 * xterm.c (x_check_font): Remove unused local.
3214 * scroll.c (CHECK_BOUNDS):
3215 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3216 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3217 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3218 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3219 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3220 Now static.
3221 (debug_method_add): Use va_list and vsprintf rather than relying
3222 on undefined behavior with wrong number of arguments.
3223 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3224 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3225 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3226 since we're not interested in debugging glyphs with old libraries.
3227 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3228 GCC 4.6.0's static checking.
3229
0766b489
PE
32302011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3231
31fd4b32
PE
3232 Integer overflow and signedness fixes (Bug#8873).
3233 A few related buffer overrun fixes, too.
3234
b79e8648
PE
3235 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3236
0766b489
PE
3237 * dispextern.h (struct face.stipple):
3238 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3239 (x_bitmap_mask, x_allocate_bitmap_record)
3240 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3241 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3242 (x_create_bitmap_from_xpm_data):
3243 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3244 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3245 (.bitmaps_last):
3246 * xfaces.c (load_pixmap):
3247 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3248 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3249 (.bitmaps_last, struct x_output.icon_bitmap):
3250 Use ptrdiff_t, not int, for bitmap indexes.
3251 (x_allocate_bitmap_record): Check for size overflow.
3252 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3253
b081724f
PE
3254 Use ptrdiff_t, not int, for overlay counts.
3255 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3256 * editfns.c (overlays_around, get_pos_property):
3257 * textprop.c (get_char_property_and_overlay):
3258 * xdisp.c (next_overlay_change, note_mouse_highlight):
3259 * xfaces.c (face_at_buffer_position):
21514da7
PE
3260 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3261 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3262 (Fnext_overlay_change, Fprevious_overlay_change)
3263 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3264 Use ptrdiff_t, not int, for sizes.
21514da7 3265 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3266
3de73e5e
PE
3267 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3268
2606c57b
PE
3269 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3270 (x_session_initialize): Do not assume string length fits in int.
3271
aaafe47a
PE
3272 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3273 This is unlikely, but can occur if DPI is outlandish.
3274
2674ddc8 3275 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3276 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3277
28154962
PE
3278 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3279 * xrdb.c (magic_file_p, search_magic_path):
3280 Omit last arg SUFFIX; it was always 0. All callers changed.
3281 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3282
7de51af5
PE
3283 * xfont.c (xfont_match): Avoid need for strlen.
3284
25ed6cc3
PE
3285 * xfns.c: Don't assume strlen fits in int.
3286 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3287
4eab31dd
PE
3288 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3289 not unsigned long, as we prefer signed integers. All callers changed.
3290 Detect integer overflow in repeat count.
3291 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3292 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3293
171e2a58
PE
3294 * termcap.c: Don't assume sizes fit in int and never overflow.
3295 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3296 (gobble_line): Check for size-calculation overflow.
3297
ad39faca 3298 * minibuf.c (Fread_buffer):
6e5bb2dc 3299 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3300 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3301 Don't assume string length fits in int.
3302
52c61c22 3303 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3304 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3305
b5b8c9e5
PE
3306 * font.c: Don't assume string length fits in int.
3307 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3308 Use ptrdiff_t, not int.
ccd6111c
PE
3309 (font_intern_prop): Don't assume string length fits in int.
3310 Don't assume integer property fits in fixnum.
3311 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3312
882f0d81 3313 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3314 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3315 Reformulate so as not to need the command string.
3316 Invoke gzip -cd rather than gunzip, as it's more portable.
3317 (lock_info_type, lock_file_1, lock_file):
3318 Don't assume pid_t and time_t fit in unsigned long.
3319 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3320 (current_lock_owner): Prefer signed type for sizes.
3321 Use memcpy, not strncpy, where memcpy is what is really wanted.
3322 Don't assume (via atoi) that time_t and pid_t fit in int.
3323 Check for time_t and/or pid_t out of range, e.g., via a network share.
3324 Don't alloca where an auto var works fine.
3325
93f4cf88
PE
3326 * fileio.c: Fix some integer overflow issues.
3327 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3328 Don't assume string length fits in int.
3329 (directory_file_name): Don't assume string length fits in long.
3330 (make_temp_name): Don't assume pid fits in int, or that its print
3331 length is less than 20.
3332
f3e92b69
PE
3333 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3334
1bfdaf10
PE
3335 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3336
35016e9a
PE
3337 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3338
3d1e65a1
PE
3339 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3340 We prefer signed integers, even for size calculations.
3341
0b963a93
PE
3342 * emacs.c: Don't assume string length fits in 'int'.
3343 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3344 (main): Don't invoke strlen when not needed.
3345
573f4b54
PE
3346 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3347 (XD_DEBUG_MESSAGE): Don't waste a byte.
3348
989f33ba
PE
3349 * callproc.c (getenv_internal_1, getenv_internal)
3350 (Fgetenv_internal):
965d34eb
PE
3351 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3352
e4d29b33
PE
3353 * lread.c (invalid_syntax): Omit length argument.
3354 All uses changed. This doesn't fix a bug, but it simplifies the
3355 code away from its former Hollerith-constant appearance, and it's
3356 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3357 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3358
eb49b136
PE
3359 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3360 This didn't break anything, but it didn't help either.
3361 It's confusing to put a bogus integer in a place where the actual
3362 value does not matter.
9f62aeb1 3363 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3364 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3365
15375a22
PE
3366 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3367 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3368 implementation.
b61cc01c
PE
3369 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3370 We prefer signed types, and the value cannot exceed the EMACS_INT
3371 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3372 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3373 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3374 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3375
53b2623d
PE
3376 * indent.c (sane_tab_width): New function.
3377 (current_column, scan_for_column, Findent_to, position_indentation)
3378 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3379 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3380
51cab52b 3381 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3382
f2ed8a70
PE
3383 * lisp.h (lint_assume): New macro.
3384 * composite.c (composition_gstring_put_cache):
3385 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3386
abe80cc6
PE
3387 * editfns.c, insdel.c:
3388 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3389
b02c740e
PE
3390 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3391
ebc96716
PE
3392 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3393
b4e50fa0 3394 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3395 Use much-faster test for byte-length change.
311d5d7c 3396 Don't assume string byte-length fits in 'int'.
a4cf38e4 3397 Check that character arg fits in 'int'.
85461888 3398 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3399
c0c1ee9f
PE
3400 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3401
a498d7f4
PE
3402 * fns.c (concat): Catch string overflow earlier.
3403 Do not rely on integer wraparound.
3404
51cab52b
PE
3405 * dispextern.h (struct it.overlay_strings_charpos)
3406 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3407 * xdisp.c (forward_to_next_line_start)
3408 (back_to_previous_visible_line_start)
3409 (reseat_at_next_visible_line_start, next_element_from_buffer):
3410 Don't arbitrarily truncate the value of 'selective' to int.
3411
76031fad
PE
3412 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3413
5eb55db9
PE
3414 * composite.c: Don't truncate sizes to 'int'.
3415 (composition_gstring_p, composition_reseat_it)
3416 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3417 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3418 not EMACS_UINT, for indexes.
5eb55db9 3419
0703a717
PE
3420 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3421
d6202519
PE
3422 * buffer.c: Include <verify.h>.
3423 (struct sortvec.priority, struct sortstr.priority):
8961a454 3424 Now EMACS_INT, not int.
c20998a7 3425 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3426 (struct sortstr.size, record_overlay_string)
3427 (struct sortstrlist.size, struct sortlist.used):
3428 Don't truncate size to int.
3429 (record_overlay_string): Check for size-calculation overflow.
d6202519 3430 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3431
d5a19415
JM
34322011-06-22 Jim Meyering <meyering@redhat.com>
3433
029529ac 3434 Don't leak an XBM-image-sized buffer
d5a19415
JM
3435 * image.c (xbm_load): Free the image buffer after using it.
3436
a9041e6c
PE
34372011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3438
3439 Port to Sun C.
3440 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3441 that Sun C diagnosed.
3442 * fns.c (secure_hash): Fix pointer signedness issue.
3443 * intervals.c (static_offset_intervals): New function.
3444 (offset_intervals): Use it.
3445
7f3f739f
LL
34462011-06-21 Leo Liu <sdl.web@gmail.com>
3447
3448 * deps.mk (fns.o):
3449 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3450 sha512.h.
3451
3452 * fns.c (secure_hash): Rename from crypto_hash_function and change
3453 the first arg to accept symbols.
5b66d427 3454 (Fsecure_hash): New primitive.
7f3f739f
LL
3455 (syms_of_fns): New symbols.
3456
76147d94
DD
34572011-06-20 Deniz Dogan <deniz@dogan.se>
3458
3459 * process.c (Fset_process_buffer): Clarify return value in
3460 docstring.
3461
7d7d0045
CY
34622011-06-18 Chong Yidong <cyd@stupidchicken.com>
3463
3464 * dispnew.c (add_window_display_history): Use BVAR.
3465
3466 * xdisp.c (debug_method_add): Use BVAR.
3467 (check_window_end, dump_glyph_matrix, dump_glyph)
3468 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3469
3470 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3471 Likewise.
3472
3473 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3474 check till after the cache is created in init_frame_faces.
3475
ff2bc410
SM
34762011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3477
3478 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3479
28177add
PE
34802011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3481
dd3482fe
PE
3482 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3483 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3484 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3485
393d71f3 3486 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3487 * fileio.c (Finsert_file_contents):
3488 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3489 Remove the old (too-loose) buffer overflow checks.
3490 They weren't needed, since make_gap checks for buffer overflow.
3491 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3492 The old code merely checked for Emacs fixnum overflow, and relied
3493 on undefined (wraparound) behavior. The new code avoids undefined
3494 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3495
2e6813b0 3496 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3497 Tune. Don't use wider integers than needed. Don't use alloca.
3498 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3499
599a9e4f
PE
3500 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3501
99561444
PE
3502 * insdel.c, lisp.h (buffer_overflow): New function.
3503 (insert_from_buffer_1, replace_range, replace_range_2):
3504 * insdel.c (make_gap_larger):
3505 * editfns.c (Finsert_char):
3506 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3507
28177add
PE
3508 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3509
e69dafad
PE
35102011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3511
a7af7fde 3512 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3513
b1c46f02
PE
3514 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3515 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3516
e69dafad
PE
3517 * fileio.c: Don't assume EMACS_INT fits in off_t.
3518 (emacs_lseek): New static function.
3519 (Finsert_file_contents, Fwrite_region): Use it.
3520 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3521
566684ea
PE
3522 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3523
e6966cd6
PE
3524 * fns.c: Don't overflow int when computing a list length.
3525 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3526 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3527 truncation on 64-bit hosts. Check for QUIT every
3528 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3529 faster and is responsive enough.
3530 (Flength): Report an error instead of overflowing an integer.
3531 (Fsafe_length): Return a float if the value is not representable
3532 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3533 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3534 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3535
dd0b0efb
PE
3536 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3537 (header_size, word_size): New constants.
3538 (allocate_vectorlike): Don't check size overflow here.
3539 (allocate_vector): Check it here instead, since this is the only
3540 caller of allocate_vectorlike that could cause overflow.
3541 Check that the new vector's length is representable as a fixnum.
3542
86fe5cfe
PE
3543 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3544 The previous code was bogus. For example, next_almost_prime (32)
3545 returned 39, which is undesirable as it is a multiple of 3; and
3546 next_almost_prime (24) returned 25, which is a multiple of 5 so
3547 why was the code bothering to check for multiples of 7?
3548
80e88859
PE
3549 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3550
4a2f0ad6
PE
3551 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3552
f66c7cf8
PE
3553 Variadic C functions now count arguments with ptrdiff_t.
3554 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3555 Back then I didn't know that the Emacs coding style prefers signed int.
3556 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3557 were being counted with int, which may truncate counts on 64-bit
3558 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3559 * lisp.h (struct Lisp_Subr.function.aMANY)
3560 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3561 Arg counts are now ptrdiff_t, not size_t.
3562 All variadic functions and their callers changed accordingly.
3563 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3564 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3565 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3566 * callint.c (Fcall_interactively): Check arg count for overflow,
3567 to avoid potential buffer overrun. Use signed char, not 'int',
3568 for 'varies' array, so that we needn't bother to check its size
3569 calculation for overflow.
3570 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3571 * eval.c (apply_lambda):
3572 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3573 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3574 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3575
a1759b76
PE
3576 * callint.c (Fcall_interactively): Don't use index var as event count.
3577
d96be9fc
PE
3578 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3579 * mem-limits.h (SIZE): Remove; no longer used.
3580
a690a978 3581 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3582
578c21e6
PE
3583 Remove unnecessary casts.
3584 * xterm.c (x_term_init):
3585 * xfns.c (x_set_border_pixel):
3586 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3587 These aren't needed now that we assume ANSI C.
3588
96f53c6c
PE
3589 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3590 It's more likely to cause problems (due to unsigned overflow)
3591 than to cure them.
3592
83c77d31
PE
3593 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3594
ee2079f1
PE
3595 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3596
6da65536
PE
3597 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3598
7147c4a4
PE
3599 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3600
193e32d9
PE
3601 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3602
e5533da6
PE
3603 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3604
9910e595
PE
3605 GLYPH_CODE_FACE returns EMACS_INT, not int.
3606 * dispextern.h (merge_faces):
3607 * xfaces.c (merge_faces):
01103c44
PE
3608 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3609 Don't assume EMACS_INT fits in int.
9910e595 3610
2638320e
PE
3611 * character.h (CHAR_VALID_P): Remove unused parameter.
3612 * fontset.c, lisp.h, xdisp.c: All uses changed.
3613
045eb8d9
PE
3614 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3615
c1f134b5
PE
3616 * fns.c (concat): Minor tuning based on overflow analysis.
3617 This doesn't fix any bugs. Use int to hold character, instead
3618 of constantly refetching from Emacs object. Use XFASTINT, not
3619 XINT, for value known to be a character. Don't bother comparing
3620 a single byte to 0400, as it's always less.
3621
395fcb93 3622 * floatfns.c (Fexpt):
327eeec8
PE
3623 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3624
abbd3d23
PE
3625 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3626 for characters.
3627
684a03ef
PE
3628 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3629
0fed43f3
PE
3630 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3631 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3632 incorrectly succeed when S was a string, because 4294967386 was
3633 truncated before it was used.
3634
8fd02eb7
PE
3635 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3636 Otherwise, an out-of-range integer could cause undefined behavior
3637 on a 64-bit host.
3638
f8c86b69
PE
3639 * composite.c: Use int, not EMACS_INT, for characters.
3640 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3641 EMACS_INT, for values that are known to be in character range.
3642 This doesn't fix any bugs but is the usual style inside Emacs and
3643 may generate better code on 32-bit machines.
3644
34206dd2
PE
3645 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3646 This is for reasons similar to the recent CHAR_STRING fix.
3647 * charset.c (Fencode_char): Check that character arg is actually
3648 a character. Pass an int to ENCODE_CHAR.
3649 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3650 wider than 'int', as a compile-time check to prevent future regressions
3651 in this area.
3652
c5958d4c 3653 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3654
3655 Make sure a 64-bit char is never passed to CHAR_STRING.
3656 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3657 by silently ignoring the top 32 bits, allowing some values
3658 that were far too large to be valid characters.
3659 * character.h: Include <verify.h>.
3660 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3661 arguments are no wider than unsigned, as a compile-time check
3662 to prevent future regressions in this area.
3663 * data.c (Faset):
01103c44 3664 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3665 (Fsubst_char_in_region):
3666 * fns.c (concat):
3667 * xdisp.c (decode_mode_spec_coding):
3668 Adjust to CHAR_STRING's new requirement.
3669 * editfns.c (Finsert_char, Fsubst_char_in_region):
3670 * fns.c (concat): Check that character args are actually
3671 characters. Without this test, these functions did the wrong
3672 thing with wildly out-of-range values on 64-bit hosts.
3673
d37ca623
PE
3674 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3675 These casts should not be needed on 32-bit hosts, either.
3676 * keyboard.c (read_char):
3677 * lread.c (Fload): Remove casts to unsigned.
3678
ea204efb
PE
3679 * lisp.h (UNSIGNED_CMP): New macro.
3680 This fixes comparison bugs on 64-bit hosts.
3681 (ASCII_CHAR_P): Use it.
3682 * casefiddle.c (casify_object):
01103c44 3683 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3684 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3685 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3686 * dispextern.h (FACE_FROM_ID):
3687 * keyboard.c (read_char): Use UNSIGNED_CMP.
3688
41cb286c
PE
3689 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3690 not to EMACS_INT, to avoid GCC warning.
3691
4a1b9832
PE
3692 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3693
55daad71
PE
3694 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3695 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3696 isn't needed on 32-bit machines.
8f95c75c 3697
01103c44
PE
3698 * buffer.c (Fgenerate_new_buffer_name):
3699 Use EMACS_INT for count, not int.
0ceccced 3700 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3701
3702 * data.c (Qcompiled_function): Now static.
3703
c6f072e7
PE
3704 * window.c (window_body_lines): Now static.
3705
20ce5912
PE
3706 * image.c (gif_load): Rename local to avoid shadowing.
3707
9c4c5f81
PE
3708 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3709 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3710 * alloc.c (make_save_value): Integer argument is now of type
3711 ptrdiff_t, not int.
3712 (mark_object): Use ptrdiff_t, not int.
3713 * lisp.h (pD): New macro.
3714 * print.c (print_object): Use it.
3715
c0c5c8ae
PE
3716 * alloc.c: Use EMACS_INT, not int, to count objects.
3717 (total_conses, total_markers, total_symbols, total_vector_size)
3718 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3719 (total_free_floats, total_floats, total_free_intervals)
3720 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3721 Now EMACS_INT, not int. All uses changed.
3722 (Fgarbage_collect): Compute overall total using a double, so that
3723 integer overflow is less likely to be a problem. Check for overflow
3724 when converting back to an integer.
5a25e253
PE
3725 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3726 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3727 These were 'int' variables that could overflow on 64-bit hosts;
3728 they were never used, so remove them instead of repairing them.
211a0b2a 3729 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3730 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3731 Previously, this ceilinged at INT_MAX, but that doesn't work on
3732 64-bit machines.
e46bb31a 3733 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3734
c78baabf 3735 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3736 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3737 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3738 when a (possibly-narrower) signed value would do just as well.
3739 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3740
c9d624c6
PE
3741 * alloc.c: Catch some string size overflows that we were missing.
3742 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3743 for convenience in STRING_BYTES_MAX.
3744 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3745 The definition here is exact; the one in lisp.h was approximate.
3746 (allocate_string_data): Check for string overflow. This catches
3747 some instances we weren't catching before. Also, it catches
3748 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3749 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3750 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3751
c9d624c6
PE
3752 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3753 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3754 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3755
353032ce
PE
3756 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3757
2bccce07
PE
3758 * alloc.c (Fmake_string): Check for out-of-range init.
3759
0ac30604
SM
37602011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3761
3762 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3763
c195f2de
JD
37642011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3765
3766 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3767 xg_get_default_scrollbar_width.
3768
3769 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3770 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3771 (style_changed_cb): Call update_theme_scrollbar_width and call
3772 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3773 all frames (Bug#8505).
3774 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3775 Call gtk_window_set_resizable if HAVE_GTK3.
3776 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3777 and height if HAVE_GTK3 (Bug#8505).
3778 (scroll_bar_width_for_theme): New variable.
3779 (update_theme_scrollbar_width): New function.
3780 (xg_get_default_scrollbar_width): Move code to
3781 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3782 (xg_initialize): Call update_theme_scrollbar_width.
3783
3784 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3785
3786 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3787
e10ac9f1
MR
37882011-06-12 Martin Rudalics <rudalics@gmx.at>
3789
3790 * frame.c (make_frame): Call other_buffer_safely instead of
3791 other_buffer.
3792
3793 * window.c (temp_output_buffer_show): Call display_buffer with
3794 second argument Vtemp_buffer_show_specifiers and reset latter
3795 immediately after the call.
3796 (Vtemp_buffer_show_specifiers): New variable.
3797 (auto_window_vscroll_p, next_screen_context_lines)
3798 (Vscroll_preserve_screen_position): Remove leading asterisks from
3799 doc-strings.
3800
2d3c217e 38012011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3802
7b7f97e8 3803 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3804 * buffer.c (Qclone_number): Remove for now, as it's unused.
3805 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3806 (record_buffer): Remove unused local.
3807 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3808 (set_frame_buffer_list): Remove; unused.
3809 * frame.h (other_visible_frames): Remove decl.
3810 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3811 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3812 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3813 if HAVE_GPM.
3814 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3815 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3816 Define only if HAVE_GPM.
3817 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3818 (update_hints_inhibit): Remove; never set. All uses removed.
3819 * widgetprv.h (emacsFrameClassRec): Remove decl.
3820 * window.c (delete_deletable_window): Now returns void, since it
3821 wasn't returning anything.
3822 (compare_window_configurations): Remove unused locals.
3823 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3824 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3825 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3826 the same widths as pointers. This follows up on the 2011-05-06 patch.
3827 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3828 * xterm.h: Likewise.
3829 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3830
1384b89e
JB
38312011-06-12 Juanma Barranquero <lekktu@gmail.com>
3832
3833 * makefile.w32-in: Update dependencies.
3834 (LISP_H): Add lib/intprops.h.
3835
1100a63c
CY
38362011-06-11 Chong Yidong <cyd@stupidchicken.com>
3837
3838 * image.c (gif_load): Add animation frame delay to the metadata.
3839 (syms_of_image): Use DEFSYM. New symbol `delay'.
3840
6198ccd0
MR
38412011-06-11 Martin Rudalics <rudalics@gmx.at>
3842
3843 * window.c (delete_deletable_window): Re-add.
3844 (Fset_window_configuration): Rewrite to handle dead buffers and
3845 consequently deletable windows.
3846 (window_tree, Fwindow_tree): Remove. Supply functionality in
3847 window.el.
3848 (compare_window_configurations): Simplify code.
3849
b6e3633c
AS
38502011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3851
1ab0dee5
AS
3852 * image.c (imagemagick_load_image): Fix type mismatch.
3853 (Fimagemagick_types): Likewise.
3854
b6e3633c
AS
3855 * window.h (replace_buffer_in_windows): Declare.
3856
9397e56f
MR
38572011-06-11 Martin Rudalics <rudalics@gmx.at>
3858
3859 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3860 Qclone_number. Remove external declaration of Qdelete_window.
3861 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3862 code.
640c8776
SM
3863 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3864 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3865 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3866 buffer list implementation.
3867 (other_buffer_safely): New function.
3868 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3869 calls to replace_buffer_in_windows and
3870 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3871 if allowed.
3872 (record_buffer): Inhibit quitting and rewrite using quittable
3873 functions. Run Qbuffer_list_update_hook if allowed.
3874 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3875 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3876 Move switch-to-buffer to window.el.
9397e56f
MR
3877 (bury-buffer): Move to window.el.
3878 (Vbuffer_list_update_hook): New variable.
3879
3880 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3881 section.
3882
3883 * window.h (resize_frame_windows): Move up in code.
3884 (Fwindow_frame): Remove EXFUN.
3885 (replace_buffer_in_all_windows): Remove prototype.
3886 (replace_buffer_in_windows_safely): Add prototype.
3887
3888 * window.c: Declare Qdelete_window static again. Move down
3889 declaration of select_count.
3890 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3891 (Fother_window): Move to window.el.
3892 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3893 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3894 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3895 window.el.
3896 (replace_buffer_in_windows): Implement by calling
3897 Qreplace_buffer_in_windows.
3898 (replace_buffer_in_all_windows): Remove with some functionality
3899 moved into replace_buffer_in_windows_safely.
3900 (replace_buffer_in_windows_safely): New function.
3901 (select_window_norecord, select_frame_norecord): Move in front
3902 of run_window_configuration_change_hook. Remove now obsolete
3903 declarations.
640c8776
SM
3904 (Fset_window_buffer): Rewrite doc-string.
3905 Call Qrecord_window_buffer.
9397e56f
MR
3906 (keys_of_window): Move binding for other-window to window.el.
3907
b50691aa
CY
39082011-06-11 Chong Yidong <cyd@stupidchicken.com>
3909
3910 * dispextern.h (struct image): Replace data member, whose int_val
3911 and ptr_val fields were not used by anything, with a single
3912 lisp_val object.
3913
3914 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3915 (gif_clear_image, gif_load, imagemagick_load_image)
3916 (gs_clear_image, gs_load): Callers changed.
3917
3f754b86
PE
39182011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3919
cca69397
PE
3920 * buffer.h: Include <time.h>, for time_t.
3921 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3922
109e28d0
PE
3923 Fix minor problems found by static checking.
3924
60737f02
PE
3925 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3926
4b66faf3
PE
3927 Make identifiers static if they are not used in other modules.
3928 * data.c (Qcompiled_function, Qframe, Qvector):
3929 * image.c (QimageMagick, Qsvg):
3930 * minibuf.c (Qmetadata):
3931 * window.c (resize_window_check, resize_root_window): Now static.
3932 * window.h (resize_window_check, resize_root_window): Remove decls.
3933
109e28d0
PE
3934 * window.c (window_deletion_count, delete_deletable_window):
3935 Remove; unused.
46a4ce9e
PE
3936 (window_body_lines): Now static.
3937 (Fdelete_other_windows_internal): Mark vars as initialized.
3938 Make sure 'resize_failed' is initialized.
3939 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3940 (resize_window_apply): Remove unused local.
3941 * window.h (delete_deletable_window): Remove decl.
3942
109e28d0 3943 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3944 (imagemagick_load_image): Fix pointer signedness problem by changing
3945 last arg from unsigned char * to char *. All uses changed.
3946 Also, fix a local for similar reasons.
3947 Remove unused locals. Remove locals to avoid shadowing.
3948 (fn_rsvg_handle_free): Remove; unused.
3949 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3950 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3951
3f754b86
PE
3952 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3953
2547adb1
CY
39542011-06-10 Chong Yidong <cyd@stupidchicken.com>
3955
3956 * image.c (gif_load): Fix omitted cast error introduced by
3957 2011-06-06 change.
3958
2c8e37d4
MR
39592011-06-10 Martin Rudalics <rudalics@gmx.at>
3960
3961 * window.h (resize_proportionally, orig_total_lines)
3962 (orig_top_line): Remove from window structure.
3963 (set_window_height, set_window_width, change_window_heights)
3964 (Fdelete_window): Remove prototypes.
3965 (resize_frame_windows): Remove duplicate declaration.
3966
440a42e3
EZ
39672011-06-10 Eli Zaretskii <eliz@gnu.org>
3968
3969 * window.h (resize_frame_windows, resize_window_check)
3970 (delete_deletable_window, resize_root_window)
3971 (resize_frame_windows): Declare prototypes.
3972
3973 * window.c (resize_window_apply): Make definition be "static" to
3974 match the prototype.
3975
562dd5e9
MR
39762011-06-10 Martin Rudalics <rudalics@gmx.at>
3977
3978 * window.c: Remove declarations of Qwindow_size_fixed,
3979 window_min_size_1, window_min_size_2, window_min_size,
3980 size_window, window_fixed_size_p, enlarge_window, delete_window.
3981 Remove static from declaration of Qdelete_window, it's
3982 temporarily needed by Fbury_buffer.
3983 (replace_window): Don't assign orig_top_line and
3984 orig_total_lines.
3985 (Fdelete_window, delete_window): Remove. Window deletion is
3986 handled by window.el.
640c8776
SM
3987 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3988 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3989 (Fdelete_other_windows): Remove. Deleting other windows is
3990 handled by window.el.
3991 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3992 handled in window.el.
3993 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3994 Window minimum sizes are handled in window.el.
3995 (shrink_windows, size_window, set_window_height)
3996 (set_window_width, change_window_heights, window_height)
3997 (window_width, CURBEG, CURSIZE, enlarge_window)
3998 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3999 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4000 handled in window.el.
4001 (make_dummy_parent): Rename to make_parent_window and give it a
4002 second argument horflag.
4003 (make_window): Don't set resize_proportionally any more.
4004 (Fsplit_window): Remove. Windows are split in window.el.
4005 (save_restore_action, save_restore_orig_size)
4006 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4007 Resize mini windows in window.el.
4008 (grow_mini_window, shrink_mini_window): Implement by calling
4009 Qresize_root_window_vertically, resize_window_check and
4010 resize_window_apply.
640c8776
SM
4011 (saved_window, Fset_window_configuration, save_window_save):
4012 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4013 resize_proportionally.
4014 (window_min_height, window_min_width): Move to window.el.
4015 (keys_of_window): Move bindings for delete-other-windows,
4016 split-window, delete-window and enlarge-window to window.el.
4017
4018 * buffer.c: Temporarily extern Qdelete_window.
4019 (Fbury_buffer): Temporarily call Qdelete_window instead of
4020 Fdelete_window (Fbury_buffer will move to window.el soon).
4021
4022 * frame.c (set_menu_bar_lines_1): Remove code handling
4023 orig_top_line and orig_total_lines.
4024
4025 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4026 set_window_height but set heights directly.
4027 (change_frame_size_1): Use resize_frame_windows.
4028
4029 * xdisp.c (init_xdisp): Don't use set_window_height but set
4030 heights directly.
4031
640c8776
SM
4032 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4033 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4034 run_window_configuration_change_hook.
4035
4036 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4037 instead of change_window_heights and run
4038 run_window_configuration_change_hook.
4039
1a13852e
MR
40402011-06-09 Martin Rudalics <rudalics@gmx.at>
4041
4042 * window.c (replace_window): Rename second argument REPLACEMENT to
4043 NEW. New third argument SETFLAG. Rewrite.
4044 (delete_window, make_dummy_parent): Call replace_window with
4045 third argument 1.
4046 (window_list_1): Move down in code.
4047 (run_window_configuration_change_hook): Move set_buffer part
4048 before select_frame_norecord part in order to unwind correctly.
4049 Rename count1 to count.
4050 (recombine_windows, delete_deletable_window, resize_root_window)
4051 (Fdelete_other_windows_internal)
4052 (Frun_window_configuration_change_hook, make_parent_window)
4053 (resize_window_check, resize_window_apply, Fresize_window_apply)
4054 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4055 (Fdelete_window_internal, Fresize_mini_window_internal):
4056 New functions.
1a13852e
MR
4057 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4058
f3d1777e
MR
40592011-06-08 Martin Rudalics <rudalics@gmx.at>
4060
496e208e
MR
4061 * window.h (window): Add some new members to window structure -
4062 normal_lines, normal_cols, new_total, new_normal, clone_number,
4063 splits, nest, prev_buffers, next_buffers.
4064 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4065 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4066
f3d1777e
MR
4067 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4068 Remove.
496e208e
MR
4069 (make_dummy_parent): Set new members of windows structure.
4070 (make_window): Move down in code. Handle new members of window
4071 structure.
4072 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4073 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4074 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4075 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4076 (Fset_window_next_buffers, Fset_window_clone_number):
4077 New functions.
496e208e
MR
4078 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4079 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4080 Doc-string fixes.
4081 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4082 Argument WINDOW can be now internal window too.
4083 (Fwindow_use_time): Move up in code.
4084 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4085 Rewrite doc-string.
4086 (Fset_window_configuration, saved_window)
4087 (Fcurrent_window_configuration, save_window_save): Handle new
4088 members of window structure.
b9e809c2
MR
4089 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4090 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4091 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4092 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4093 Qget_mru_window, Qresize_root_window,
4094 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4095 Qauto_buffer_name; staticpro them.
f3d1777e 4096
abde8f8c
MR
40972011-06-07 Martin Rudalics <rudalics@gmx.at>
4098
4099 * window.c (Fwindow_total_size, Fwindow_left_column)
4100 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4101 (Fwindow_list_1): New functions.
4102 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4103 (Fwindow_width, Fscroll_left, Fscroll_right):
4104 Use window_body_cols instead of window_box_text_cols.
4105 (delete_window, Fset_window_configuration):
4106 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4107 (delete_all_subwindows): Take a window as argument and not a
4108 structure. Rewrite.
190b47e6
MR
4109 (window_loop): Remove handling of GET_LRU_WINDOW and
4110 GET_LARGEST_WINDOW.
4111 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4112
4113 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4114 window_box_text_cols. delete_all_subwindows now takes a
4115 Lisp_Object as argument.
abde8f8c 4116
640c8776
SM
4117 * indent.c (compute_motion, Fcompute_motion):
4118 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4119
fa8a67e6
MR
4120 * frame.c (delete_frame): Call delete_all_subwindows with root
4121 window as argument.
4122
a54e3482
DC
41232011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4124
4125 * fns.c (Fputhash): Document return value.
4126
60002bf5
CY
41272011-06-06 Chong Yidong <cyd@stupidchicken.com>
4128
4129 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4130
0c671da6 41312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4132
b862a52a 4133 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4134
be44ca6c
PE
4135 Check for overflow when converting integer to cons and back.
4136 * charset.c (Fdefine_charset_internal, Fdecode_char):
4137 Use cons_to_unsigned to catch overflow.
4138 (Fencode_char): Use INTEGER_TO_CONS.
4139 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4140 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4141 * data.c (long_to_cons, cons_to_long): Remove.
4142 (cons_to_unsigned, cons_to_signed): New functions.
4143 These signal an error for invalid or out-of-range values.
4144 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4145 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4146 * font.c (Ffont_variation_glyphs):
4147 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4148 * lisp.h: Include <intprops.h>.
4149 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4150 (cons_to_signed, cons_to_unsigned): New decls.
4151 (long_to_cons, cons_to_long): Remove decls.
4152 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4153 (Fprimitive_undo): Use CONS_TO_INTEGER.
4154 * xfns.c (Fx_window_property): Likewise.
4155 * xselect.c: Include <limits.h>.
4156 (x_own_selection, selection_data_to_lisp_data):
4157 Use INTEGER_TO_CONS.
4158 (x_handle_selection_request, x_handle_selection_clear)
4159 (x_get_foreign_selection, Fx_disown_selection_internal)
4160 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4161 (lisp_data_to_selection_data): Use cons_to_unsigned.
4162 (x_fill_property_data): Use cons_to_signed.
4163 Report values out of range.
4164
d1f3d2af
PE
4165 Check for buffer and string overflow more precisely.
4166 * buffer.h (BUF_BYTES_MAX): New macro.
4167 * lisp.h (STRING_BYTES_MAX): New macro.
4168 * alloc.c (Fmake_string):
4169 * character.c (string_escape_byte8):
4170 * coding.c (coding_alloc_by_realloc):
4171 * doprnt.c (doprnt):
4172 * editfns.c (Fformat):
4173 * eval.c (verror):
4174 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4175 since they may not be the same number.
4176 * editfns.c (Finsert_char):
4177 * fileio.c (Finsert_file_contents):
4178 Likewise for BUF_BYTES_MAX.
4179
dd52fcea
PE
4180 * image.c: Use ptrdiff_t, not int, for sizes.
4181 (slurp_file): Switch from int to ptrdiff_t.
4182 All uses changed.
4183 (slurp_file): Check that file size fits in both size_t (for
4184 malloc) and ptrdiff_t (for sanity and safety).
4185
7f9bbdbb
PE
4186 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4187 if b->modtime has its maximal value.
4188
dfe18f82
PE
4189 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4190
84acfcf0
PE
4191 Don't assume time_t can fit into int.
4192 * buffer.h (struct buffer.modtime): Now time_t, not int.
4193 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4194 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4195
ccd9a01a
PE
4196 Minor fixes for signed vs unsigned integers.
4197 * character.h (MAYBE_UNIFY_CHAR):
4198 * charset.c (maybe_unify_char):
4199 * keyboard.c (read_char, reorder_modifiers):
4200 XINT -> XFASTINT, since the integer must be nonnegative.
4201 * ftfont.c (ftfont_spec_pattern):
4202 * keymap.c (access_keymap, silly_event_symbol_error):
4203 XUINT -> XFASTINT, since the integer must be nonnegative.
4204 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4205 since it makes no difference and we prefer signed.
4206 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4207 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4208 nonnegative.
4209
d6d100dd
SM
42102011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4211
4212 * window.h (Fwindow_frame): Declare.
4213
2b6148e4
PE
42142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4215
4216 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4217 (SPARE_MEMORY): Always define.
4218 (LARGE_REQUEST): Remove.
4219 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4220
f230ecc9
MR
42212011-06-06 Martin Rudalics <rudalics@gmx.at>
4222
727e958e
MR
4223 * lisp.h: Move EXFUNS for Fframe_root_window,
4224 Fframe_first_window and Fset_frame_selected_window to window.h.
4225
4226 * window.h: Move EXFUNS for Fframe_root_window,
4227 Fframe_first_window and Fset_frame_selected_window here from
4228 lisp.h.
4229
4230 * frame.c (Fwindow_frame, Fframe_first_window)
4231 (Fframe_root_window, Fframe_selected_window)
4232 (Fset_frame_selected_window): Move to window.c.
4233 (Factive_minibuffer_window): Move to minibuf.c.
4234 (Fother_visible_frames_p): New function.
4235
4236 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4237
f230ecc9
MR
4238 * window.c (decode_window, decode_any_window): Move up in code.
4239 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4240 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4241 (Fwindow_buffer): Move up and rewrite doc-string.
4242 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4243 (Fwindow_prev): New functions.
727e958e
MR
4244 (Fwindow_frame): Move here from frame.c. Accept any window as
4245 argument.
4246 (Fframe_root_window, Fframe_first_window)
4247 (Fframe_selected_window): Move here from frame.c. Accept frame
4248 or arbitrary window as argument. Update doc-strings.
4249 (Fminibuffer_window): Move up in code.
4250 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4251 (Fset_frame_selected_window): Move here from frame.c.
4252 Marginal rewrite.
727e958e
MR
4253 (Fselected_window, select_window, Fselect_window): Move up in
4254 code. Minor doc-string fixes.
f230ecc9 4255
4d09bcf6
PE
42562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4257
4258 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4259 Do not assume that spare memory exists; that assumption is valid
4260 only if SYSTEM_MALLOC.
4261 (LARGE_REQUEST): New macro, so that the issue of large requests
4262 is separated from the issue of spare memory.
4263
810928a2
AS
42642011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4265
172418ad
AS
4266 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4267 format. (Bug#8806)
4268
43f862f7
AS
4269 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4270
810928a2
AS
4271 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4272 before statements.
4273
a059fe24
JD
42742011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4275
4276 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4277
4278 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4279
4280 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4281 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4282
989bf368
JB
42832011-06-05 Juanma Barranquero <lekktu@gmail.com>
4284
4285 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4286
4b80f674
CY
42872011-06-04 Chong Yidong <cyd@stupidchicken.com>
4288
4289 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4290 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4291 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4292 New error handlers.
4b80f674
CY
4293 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4294 Obey Vx_select_enable_clipboard_manager. Catch errors in
4295 x_clipboard_manager_save (Bug#8779).
4296 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4297 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4298
99a33b77 42992011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4300
4301 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4302
99a33b77 43032011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4304
4305 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4306 in the current matrix if keep_current_p is non-zero.
4307
8264569d
EZ
43082011-06-04 Eli Zaretskii <eliz@gnu.org>
4309
4310 * bidi.c (bidi_level_of_next_char): Fix last change.
4311
57f97249
EZ
43122011-06-03 Eli Zaretskii <eliz@gnu.org>
4313
fec2107c 4314 Support bidi reordering of text covered by display properties.
57f97249 4315
fec2107c
EZ
4316 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4317 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4318 (bidi_cache_search, bidi_cache_iterator_state)
4319 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4320 (bidi_level_of_next_char, bidi_move_to_visually_next):
4321 Support character positions inside a run of characters covered by a
fec2107c
EZ
4322 display string.
4323 (bidi_paragraph_init, bidi_resolve_explicit_1)
4324 (bidi_level_of_next_char): Call bidi_fetch_char and
4325 bidi_fetch_char_advance instead of FETCH_CHAR and
4326 FETCH_CHAR_ADVANCE.
4327 (bidi_init_it): Initialize new members.
4328 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4329 definitions.
4330 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4331 instead of using explicit *_CHAR codes.
d6d100dd
SM
4332 (bidi_resolve_explicit, bidi_resolve_weak):
4333 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4334 bidirectional text is supported only in multibyte buffers.
4335 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4336 it to initialize the frame_window_p member of struct bidi_it.
4337 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4338 (bidi_resolve_explicit, bidi_resolve_weak)
4339 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4340 bidi_it->nchars is non-positive.
4341 (bidi_level_of_next_char): Don't try to lookup the cache for the
4342 next/previous character if nothing is cached there yet, or if we
4343 were just reseat()'ed to a new position.
c40e2fb2 4344
0e14fe90
EZ
4345 * xdisp.c (set_cursor_from_row): Set start and stop points
4346 according to the row's direction when priming the loop that looks
4347 for the glyph on which to display cursor.
4348 (single_display_spec_intangible_p): Function deleted.
4349 (display_prop_intangible_p): Reimplement to call
4350 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4351 Accept 3 additional arguments needed by handle_display_spec.
4352 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4353 values: lists, `(when COND...)' forms, etc.
4354 (single_display_spec_string_p): Support property values that are
4355 lists with the argument STRING its top-level element.
4356 (display_prop_string_p): Fix the condition for processing a
4357 property that is a list to be consistent with handle_display_spec.
fec2107c 4358 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4359 last portion of handle_display_prop.
4360 (compute_display_string_pos): Accept additional argument
4361 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4362 value of a `display' property is a "replacing spec".
4363 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4364 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4365 the display property, but just return a value indicating whether
4366 the display property will replace the characters it covers.
4367 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4368 frame_window_p members of struct bidi_it.
d6d100dd
SM
4369 (compute_display_string_pos, compute_display_string_end):
4370 New functions.
fec2107c
EZ
4371 (push_it): Accept second argument POSITION, where pop_it should
4372 jump to continue iteration.
4373 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4374
fec2107c
EZ
4375 * keyboard.c (adjust_point_for_property): Adjust the call to
4376 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4377
4378 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4379 (bidi_init_it): Update prototypes.
4380 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4381 (compute_display_string_pos, compute_display_string_end):
4382 Declare prototypes.
fec2107c
EZ
4383 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4384 EMACS_INT.
fc6f18ce 4385
40087514 43862011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4387
57f53182
PE
4388 Malloc failure behavior now depends on size of allocation.
4389 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4390 * lisp.h: Change signatures accordingly.
4391 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4392 All callers changed. (Bug#8762)
4393
4394 * gnutls.c: Use Emacs's memory allocators.
4395 Without this change, the gnutls library would invoke malloc etc.
4396 directly, which causes problems on non-SYNC_INPUT hosts, and which
4397 runs afoul of improving memory_full behavior. (Bug#8761)
4398 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4399 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4400 xfree instead of the default malloc, realloc, free.
4401 (Fgnutls_boot): No need to check for memory allocation failure,
4402 since xmalloc does that for us.
4403
ac32cd99 4404 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4405 * category.c (hash_get_category_set):
4406 * ccl.c (ccl_driver):
4407 * charset.c (Fdefine_charset_internal):
4408 * charset.h (struct charset.hash_index):
4409 * composite.c (get_composition_id, gstring_lookup_cache)
4410 (composition_gstring_put_cache):
4411 * composite.h (struct composition.hash_index):
4412 * dispextern.h (struct image.hash):
4413 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4414 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4415 (hashfn_equal, hashfn_user_defined, make_hash_table)
4416 (maybe_resize_hash_table, hash_lookup, hash_put)
4417 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4418 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4419 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4420 * image.c (make_image, search_image_cache, lookup_image)
4421 (xpm_put_color_table_h):
4422 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4423 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4424 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4425 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4426 * alloc.c (allocate_vectorlike):
4427 Check for overflow in vector size calculations.
4428 * ccl.c (ccl_driver):
4429 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4430 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4431 need to be updated by these changes.
40087514
PE
4432 * fns.c (make_hash_table, maybe_resize_hash_table):
4433 Check for integer overflow with large hash tables.
0de4bb68
PE
4434 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4435 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4436 (SXHASH_REDUCE): New macro.
4437 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4438 Use it instead of discarding useful hash info with large hash values.
4439 (sxhash_float): New function.
4440 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4441 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4442 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4443 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4444 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4445 Adjust signatures to match updated version of code.
4446 (consing_since_gc): Now EMACS_INT, since a single hash table can
4447 use more than INT_MAX bytes.
4448
698d32e2
DN
44492011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4450
4451 Make it possible to build with GCC-4.6+ -O2 -flto.
4452
4453 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4454
fd6fa53f
SM
44552011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4456
4457 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4458 Call minibuffer-inactive-mode.
4459
864db017
JB
44602011-05-31 Juanma Barranquero <lekktu@gmail.com>
4461
4462 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4463 Update dependencies.
4464
2ad0baf4
DN
44652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4466
4467 * data.c (init_data): Remove code for UTS, this system is not
4468 supported anymore.
4469
4fcc2638
DN
44702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4471
4472 Don't force ./temacs to start in terminal mode.
4473
4474 * frame.c (make_initial_frame): Initialize faces in all cases, not
4475 only when CANNOT_DUMP is defined.
4476 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4477
c56e0fd5
DN
44782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4479
4480 * dispnew.c (add_window_display_history): Use const for the string
4481 pointer. Remove declaration, not needed.
4482
333d54da 44832011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4484
55d4c1b2 4485 Use 'inline', not 'INLINE'.
333d54da 4486 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4487 * alloc.c, fontset.c (INLINE): Remove.
4488 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4489 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4490 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4491 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4492 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4493
738db178
DN
44942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4495
4496 Make it possible to run ./temacs.
4497
4498 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4499 syms_of_callproc does the same thing. Remove test for
4500 "initialized", do it in the caller.
4501 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4502
620c53a6
SM
45032011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4504
4505 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4506 (read_minibuf): Use get_minibuffer.
4507 (syms_of_minibuf): Use DEFSYM.
4508 (Qmetadata): New var.
4509 * data.c (Qbuffer): Don't make it static.
4510 (syms_of_data): Use DEFSYM.
4511
e003a292
PE
45122011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4513
4514 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4515 (CCL_CODE_MIN): New macro.
4516
ed008a6d
PE
45172011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4518
3687c2ef
PE
4519 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4520
ed008a6d
PE
4521 * eval.c (Qdebug): Now static.
4522 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4523 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4524 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4525
d66c4c7c
CY
45262011-05-29 Chong Yidong <cyd@stupidchicken.com>
4527
4528 * image.c: Various fixes to ImageMagick code comments.
4529 (Fimagemagick_types): Doc fix.
4530
5fbc2025
PE
45312011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4532
0196f88a
PE
4533 Minor fixes prompted by GCC 4.6.0 warnings.
4534
4535 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4536
5fbc2025
PE
4537 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4538 (x_clipboard_manager_save_all): Move extern decl to ...
4539 * xterm.h: ... here, so that it can be checked for consistency.
4540
1dd3c2d9
CY
45412011-05-29 Chong Yidong <cyd@stupidchicken.com>
4542
4543 * xselect.c (x_clipboard_manager_save_frame)
4544 (x_clipboard_manager_save_all): New functions.
4545 (Fx_clipboard_manager_save): Lisp function deleted.
4546
4547 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4548 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4549
4550 * xterm.h: Update prototype.
4551
5ba6571d
WX
45522011-05-28 William Xu <william.xwl@gmail.com>
4553
4554 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4555 exiting (Bug#8239).
4556
3eaff834
JM
45572011-05-28 Jim Meyering <meyering@redhat.com>
4558
e1900994 4559 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4560 * fns.c (to_uchar): Define.
4561 (crypto_hash_function): Use it to convert some newly-signed
4562 variables to unsigned, to avoid sign-extension bugs. For example,
4563 without this change, (md5 "truc") would evaluate to
4564 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4565 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4566 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4567
0f6990a7
PE
45682011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4569
4570 Integer overflow fixes.
c8a9ca5a 4571
08686060
PE
4572 * dbusbind.c: Serial number integer overflow fixes.
4573 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4574 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4575 to hold a serial number that is too large for a fixnum.
4576 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4577 Check for serial numbers out of range. Decode any serial number
59568bf0 4578 that was so large that it became a float. (Bug#8722)
08686060 4579
2d1fc3c7
PE
4580 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4581 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4582 Use XFASTINT rather than XUINT when numbers are nonnegative.
4583 (xd_append_arg, Fdbus_method_return_internal):
4584 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4585 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4586 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4587 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4588 (Bug#8722)
2d1fc3c7 4589
c8a9ca5a
PE
4590 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4591
519e1d69
PE
4592 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4593
30569699
PE
4594 ccl: add integer overflow checks
4595 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4596 (IN_INT_RANGE): New macros.
4597 (ccl_driver): Use them to check for integer overflow when
4598 decoding a CCL program. Many of the new checks are whether XINT (x)
4599 fits in int; it doesn't always, on 64-bit hosts. The new version
4600 doesn't catch all possible integer overflows, but it's an
847044ea 4601 improvement. (Bug#8719)
30569699 4602
c11285dc
PE
4603 * alloc.c (make_event_array): Use XINT, not XUINT.
4604 There's no need for unsigned here.
4605
fdccd48e
PE
4606 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4607 This follows up to the 2011-05-06 change that substituted uintptr_t
4608 for EMACS_INT. This case wasn't caught back then.
4609
37910ab2
PE
4610 Rework Fformat to avoid integer overflow issues.
4611 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4612 now (part of C89). Include <verify.h>.
4613 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4614 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4615 (Fformat): Avoid the prepass trying to compute sizes; it was only
4616 approximate and thus did not catch overflow reliably. Instead, walk
4617 through the format just once, formatting and computing sizes as we go,
4618 checking for integer overflow at every step, and allocating a larger
4619 buffer as needed. Keep track separately whether the format is
4620 multibyte. Keep only the most-recently calculated precision, rather
4621 than them all. Record whether each argument has been converted to
4622 string. Use EMACS_INT, not int, for byte and char and arg counts.
4623 Support field widths and precisions larger than INT_MAX. Avoid
4624 sprintf's undefined behavior with conversion specifications such as %#d
4625 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4626 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4627 formatting out-of-range floating point numbers with int
9173deec 4628 formats. (Bug#8668)
37910ab2 4629
2e6578fb
PE
4630 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4631
0ae6bdee
PE
4632 * data.c: Avoid integer truncation in expressions involving floats.
4633 * data.c: Include <intprops.h>.
4634 (arith_driver): When there's an integer overflow in an expression
4635 involving floating point, convert the integers to floating point
4636 so that the resulting value does not suffer from catastrophic
4637 integer truncation. For example, on a 64-bit host (* 4
4638 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4639 Do not rely on undefined behavior after integer overflow.
4640
de883a70
PE
4641 merge count_size_as_multibyte, parse_str_to_multibyte
4642 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4643 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4644 Check for integer overflow.
4645 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4646 since it's now a duplicate of the other. This is more of
4647 a character than a buffer op, so better that it's in character.c.
4648 * fns.c, print.c: Adjust to above changes.
4649
2ff916cb
PE
46502011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4651
4652 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4653
f1b54466
PE
46542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4655
fb1ac845
PE
4656 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4657 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4658 (x_clipboard_manager_save): Now static.
4659 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4660
f1b54466
PE
4661 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4662 (crypto_hash_function): Now static.
4663 Fix pointer signedness problems. Avoid unnecessary initializations.
4664
a9f737ee
CY
46652011-05-27 Chong Yidong <cyd@stupidchicken.com>
4666
4667 * termhooks.h (Vselection_alist): Make it terminal-local.
4668
4669 * terminal.c (create_terminal): Initialize it.
4670
4671 * xselect.c: Support for clipboard managers.
4672 (Vselection_alist): Move to termhooks.h as terminal-local var.
4673 (LOCAL_SELECTION): New macro.
4674 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4675 (symbol_to_x_atom): Remove gratuitous arg.
4676 (x_handle_selection_request, lisp_data_to_selection_data)
4677 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4678 (x_own_selection, x_get_local_selection, x_convert_selection):
4679 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4680 (some_frame_on_display): Delete unused function.
4681 (Fx_own_selection_internal, Fx_get_selection_internal)
4682 (Fx_disown_selection_internal, Fx_selection_owner_p)
4683 (Fx_selection_exists_p): New optional frame arg.
4684 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4685 (x_handle_selection_clear): Don't treat other terminals with the
4686 same keyboard specially. Use the terminal-local Vselection_alist.
4687 (x_clear_frame_selections): Use Frun_hook_with_args.
4688
4689 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4690
4691 * xterm.h: Add support for those atoms.
4692
e067f0c1
CY
46932011-05-26 Chong Yidong <cyd@stupidchicken.com>
4694
4695 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4696 (converted_selections, conversion_fail_tag): New global variables.
4697 (x_selection_request_lisp_error): Free the above.
4698 (x_get_local_selection): Remove unnecessary code.
4699 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4700 of converted selections stored in converted_selections.
4701 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4702 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4703 (x_convert_selection): New function.
4704 (x_handle_selection_event): Simplify.
4705 (x_get_foreign_selection): Don't ignore incoming requests while
4706 waiting for an answer; this will fail when we implement
4707 SAVE_TARGETS, and seems unnecessary anyway.
4708 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4709 (Vx_sent_selection_functions): Doc fix.
4710
0f4aebc0
LL
47112011-05-26 Leo Liu <sdl.web@gmail.com>
4712
4713 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4714
e61124cd
YM
47152011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4716
4717 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4718
4719 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4720 for fringe update if it has periodic bitmap.
ac389d0c 4721 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4722 and fringe_bitmap_periodic_p.
4723
4724 * fringe.c (get_fringe_bitmap_data): New function.
4725 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4726 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4727 row. Mark glyph row for fringe update if periodicity changed.
4728
4729 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4730 for fringe update unless it has periodic bitmap.
4731
f16d9837
KH
47322011-05-25 Kenichi Handa <handa@m17n.org>
4733
4734 * xdisp.c (get_next_display_element): Set correct it->face_id for
4735 a static composition.
4736
e1b90ef6
LL
47372011-05-24 Leo Liu <sdl.web@gmail.com>
4738
4739 * deps.mk (fns.o):
4740 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4741
4742 * fns.c (crypto_hash_function, Fsha1): New function.
4743 (Fmd5): Use crypto_hash_function.
4744 (syms_of_fns): Add Ssha1.
4745
7400048f
PE
47462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4747
4748 * gnutls.c: Remove unused macros.
4749 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4750 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4751 Remove macros that are defined and never used.
4752 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4753
abb71cf4
CY
47542011-05-22 Chong Yidong <cyd@stupidchicken.com>
4755
4756 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4757 (Fx_get_selection_internal): Minor cleanup.
4758 (Fx_own_selection_internal): Rename arguments for consistency with
4759 select.el.
4760
6307db39
PE
47612011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4762
4763 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4764
f3d4e0a4
CY
47652011-05-22 Chong Yidong <cyd@stupidchicken.com>
4766
4767 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4768
4d8ade89
YM
47692011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4770
4771 * dispnew.c (scrolling_window): Don't exclude the case that the
4772 last enabled row in the desired matrix touches the bottom boundary.
4773
32078c8d
GM
47742011-05-21 Glenn Morris <rgm@gnu.org>
4775
4776 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4777 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4778 and add some more files.
32078c8d 4779
7285dc67
EZ
47802011-05-20 Eli Zaretskii <eliz@gnu.org>
4781
4782 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4783 report_file_error introduced by the change from 2011-05-07.
4784
89d1bd22
PE
47852011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4786
4787 * systime.h (Time): Define only if emacs is defined.
4788 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4789 where the include path doesn't have X11/X.h by default. See
4790 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4791
e23640bb 47922011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4793
4794 * composite.c (find_automatic_composition): Fix previous change.
4795
b9704ad9
GM
47962011-05-20 Glenn Morris <rgm@gnu.org>
4797
4798 * lisp.mk: New file, split from Makefile.in.
4799 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4800 (shortlisp): Remove.
4801 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4802
4a720484
GM
48032011-05-19 Glenn Morris <rgm@gnu.org>
4804
4805 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4806 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4807 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4808 (lisp): Set the order to that of loadup.el.
4809 (shortlisp): Make it a copy of $lisp.
4810 (SOME_MACHINE_LISP): Remove.
4811 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4812 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4813
a28d4396
KH
48142011-05-18 Kenichi Handa <handa@m17n.org>
4815
4816 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4817 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4818 (find_automatic_composition): Mostly rewrite for efficiency.
4819
a2b1fa8e
JB
48202011-05-18 Juanma Barranquero <lekktu@gmail.com>
4821
4822 * makefile.w32-in: Update dependencies.
4823
8e1f5610
CS
48242011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4825
4826 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4827 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4828
7025ee00 48292011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4830
cdfa6eab
PE
4831 Fix some integer overflow issues, such as string length overflow.
4832
06d6db33
PE
4833 * insdel.c (count_size_as_multibyte): Check for string overflow.
4834
2b4560a8
PE
4835 * character.c (lisp_string_width): Check for string overflow.
4836 Use EMACS_INT, not int, for string indexes and lengths; in
4837 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4838 the resulting string length overflows an EMACS_INT; instead,
4839 report a string overflow if no precision given. When checking for
4840 precision exhaustion, use a check that cannot possibly have
4841 integer overflow. (Bug#8675)
4842 * character.h (lisp_string_width): Adjust to new signature.
4843
cb93f9be
PE
4844 * alloc.c (string_overflow): New function.
4845 (Fmake_string): Use it. This doesn't change behavior, but saves
4846 a few bytes and will simplify future changes.
4847 * character.c (string_escape_byte8): Likewise.
4848 * lisp.h (string_overflow): New decl.
4849
1a1f3366
PE
4850 Fixups, following up to the user-interface timestamp change.
4851 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4852 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4853 * msdos.c (mouse_get_pos): Likewise.
4854 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4855 * w32gui.h (Time): Define by including "systime.h" rather than by
4856 declaring it ourselves. (Bug#8664)
4857
d4e3e4d3
PE
4858 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4859 * image.c (clear_image_cache): Likewise.
4860
f6a24d19
PE
4861 * term.c (term_mouse_position): Don't assume time_t wraparound.
4862
08dc5ae6
PE
4863 Be more systematic about user-interface timestamps.
4864 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4865 and sometimes 'EMACS_UINT', to represent these timestamps.
4866 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4867 This makes the code easier to follow, and makes it easier to catch
4868 integer overflow bugs such as Bug#8664.
4869 * frame.c (Fmouse_position, Fmouse_pixel_position):
4870 Use Time, not unsigned long, for user-interface timestamps.
4871 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4872 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4873 * keyboard.h (last_event_timestamp): Likewise.
4874 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4875 * menu.h (xmenu_show): Likewise.
4876 * term.c (term_mouse_position): Likewise.
4877 * termhooks.h (struct input_event.timestamp): Likewise.
4878 (struct terminal.mouse_position_hook): Likewise.
4879 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4880 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4881 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4882 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4883 what it was before.
4884 * menu.h, termhooks.h: Include "systime.h", for Time.
4885
8e55734a
PE
4886 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4887 Don't assume that the difference between two unsigned long values
4888 can fit into an integer. At this point, we know button_down_time
4889 <= event->timestamp, so the difference must be nonnegative, so
4890 there's no need to cast the result if double-click-time is
4891 nonnegative, as it should be; check that it's nonnegative, just in
4892 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4893 apart (about 25 days). (Bug#8664)
8e55734a 4894
841f1b75 4895 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4896 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4897
3e26f69c
PE
4898 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4899 that always fit in int. Use a sentinel instead of a counter, to
4900 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4901 * frame.h (struct frame): Use int for menu_bar_items_used
4902 instead of EMACS_INT, since it always fits in int.
3e26f69c 4903
5cc152c0
PE
4904 * menu.c (grow_menu_items): Check for int overflow.
4905
d89eb65e
PE
4906 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4907
5235bd3e
PE
4908 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4909 Before, the code was not consistent. These values cannot exceed
4910 2**31 - 1 so there's no need to make them unsigned.
4911 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4912 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4913 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4914 as modifiers.
4915 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4916
bc827e23
PE
4917 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4918 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4919 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4920 presumably because the widths might not match.
4921
78eb494e
PE
4922 * window.c (size_window): Avoid needless test at loop start.
4923
04f2d78b
CB
49242011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4925
4926 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4927
d2fc7e3d 49282011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4929
4930 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4931
d2fc7e3d 49322011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4933
4934 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4935 `width' to `bar_area_x' and `bar_area_width', respectively.
4936 (x_scroll_run): Take account of fringe background extension.
4937
04f2d78b
CB
4938 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4939 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4940 `bar_area_width', respectively.
4941 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4942 background extension.
4943
79b70037
GM
49442011-05-10 Jim Meyering <meyering@redhat.com>
4945
4946 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4947
2f142cc5
JB
49482011-05-10 Juanma Barranquero <lekktu@gmail.com>
4949
4950 * image.c (Finit_image_library): Return t for built-in image types,
4951 like pbm and xbm. (Bug#8640)
4952
57679c86
AS
49532011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4954
4955 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4956
888c9e86
EZ
49572011-05-07 Eli Zaretskii <eliz@gnu.org>
4958
b0512a1d
EZ
4959 * w32console.c (Fset_screen_color): Doc fix.
4960 (Fget_screen_color): New function.
4961 (syms_of_ntterm): Defsubr it.
4962
7285dc67
EZ
4963 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4964 unlink the temporary file if Fcall_process didn't create it in the
4965 first place.
4966 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4967 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4968 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4969 cue to call_process_cleanup not to close that handle.
4970
4d3fcc8e
BK
49712011-05-07 Ben Key <bkey76@gmail.com>
4972
4973 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4974 one of two shell specific rules, either bootstrap-temacs-CMD or
4975 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4976 to the previous implementation of the bootstrap-temacs rule.
4977 The bootstrap-temacs-CMD rule is similar to the previous
4978 implementation of the bootstrap-temacs rule except that it
4979 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4980 variable.
4981
4982 These changes, along with some changes to nt/configure.bat,
4983 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4984 earlier fix to add support for --cflags and --ldflags options
4985 that include quotes so that it works whether make uses cmd or
4986 sh as the shell.
4987
b4289b64
MA
49882011-05-06 Michael Albinus <michael.albinus@gmx.de>
4989
4990 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4991 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4992 is a constant.
4993 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4994 a string. Handle both cases.
4995 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4996 (Fdbus_register_method): Use Qinvalid_function.
4997
af4c0e28
JB
49982011-05-06 Juanma Barranquero <lekktu@gmail.com>
4999
5000 * makefile.w32-in: Update dependencies.
5001 (LISP_H): Add inttypes.h and stdin.h.
5002 (PROCESS_H): Add unistd.h.
5003
c51453d9
EZ
50042011-05-06 Eli Zaretskii <eliz@gnu.org>
5005
5006 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5007 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5008
8ff0ac3c 50092011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5010
4c4b566b
PE
5011 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5012
aab2b9b5
PE
5013 * term.c (vfatal): Remove stray call to va_end.
5014 It's not needed and the C Standard doesn't allow it here anyway.
5015
c378da0b
PE
5016 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5017 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5018
288b08c7
PE
5019 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5020 bytes.
5021
e3601888
PE
5022 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5023
db6c0e74
PE
5024 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5025
dd5963ea
PE
5026 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5027
88c9450f
PE
5028 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5029
2f9442b8
PE
5030 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5031
c032b5f8
PE
5032 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5033 * charset.c (Fdefine_charset_internal): Don't initialize
5034 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5035 32-bit int (Bug#8600).
a108c10b
PE
5036
5037 * lread.c (read_integer): Be more consistent with string-to-number.
5038 Use string_to_number to do the actual conversion; this avoids
5039 rounding errors and fixes some other screwups. Without this fix,
5040 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5041 (digit_to_number): Move earlier, for benefit of read_integer.
5042 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5043 not a digit in any supported base. (Bug#8602)
a108c10b 5044
ad5f9eea
PE
5045 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5046
aec1708a
PE
5047 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5048 to match comment at start of function. This also removes a
5049 GCC warning about overflow in a 32+64-bit port.
5050
47be4ab5
PE
5051 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5052
371cac43
PE
5053 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5054 Reported by Stefan Monnier in
5055 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5056 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5057 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5058
d01a7826
PE
5059 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5060 (EMACS_UINTPTR): Likewise, with uintptr_t.
5061
7fd47d5c
PE
5062 * lisp.h: Prefer 64-bit EMACS_INT if available.
5063 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5064 on 32-bit hosts that have 64-bit int, so that they can access
5065 large files.
122b0c86
PE
5066 However, temporarily disable this change unless the temporary
5067 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5068
8727937b
PE
5069 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5070
8ac068ac
PE
5071 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5072 This removes an assumption that EMACS_INT and long are the same
5073 width as pointers. The assumption is true for Emacs porting targets
5074 now, but we want to make other targets possible.
5075 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5076 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5077 In the rest of the code, change types of integers that hold casted
5078 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5079 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5080 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5081 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5082 No need to cast type when ORing.
5083 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5084 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5085 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5086 assume EMACS_INT is the same width as char *.
5087 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5088 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5089 Remove no-longer-needed casts.
5090 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5091 (xg_tool_bar_help_callback, xg_make_tool_item):
5092 Use EMACS_INTPTR to hold an integer
5093 that will be cast to void *; this can avoid a GCC warning
5094 if EMACS_INT is not the same width as void *.
5095 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5096 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5097 (current_message_1, set_message_1):
5098 Use a local to convert to proper width without a cast.
5099 * xmenu.c (dialog_selection_callback): Likewise.
5100
ede49d71
PE
5101 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5102 Also, don't assume VALBITS / RAND_BITS is less than 5,
5103 and don't rely on undefined behavior when shifting a 1 left into
5104 the sign bit.
5105 * lisp.h (get_random): Change signature to match.
5106
2f30ecd0
PE
5107 * lread.c (hash_string): Use size_t, not int, for hash computation.
5108 Normally we prefer signed values; but hashing is special, because
5109 it's better to use unsigned division on hash table sizes so that
5110 the remainder is nonnegative. Also, size_t is the natural width
5111 for hashing into memory. The previous code used 'int', which doesn't
5112 retain enough info to hash well into very large tables.
5113 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5114
2a866e7b
PE
5115 * dbusbind.c: Don't possibly lose pointer info when converting.
5116 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5117 Use XPNTR rather than XHASH, so that the high-order bits of
5118 the pointer aren't lost when converting through void *.
5119
51639eac
PE
5120 * eval.c (Fautoload): Don't double-shift a pointer.
5121
92394119
PE
5122 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5123
dbdb9a7c
JB
51242011-05-06 Juanma Barranquero <lekktu@gmail.com>
5125
5126 * gnutls.c (DEF_GNUTLS_FN):
5127 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5128
db7a0b4f
AS
51292011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5130
5131 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5132 marker. (Bug#8610)
5133
f7ff1b0f 51342011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5135
5136 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5137 New version that can reserve upto 2GB of heap space.
5138
f7ff1b0f 51392011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5140
5141 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5142
639c109b
TZ
51432011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5144
5145 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5146 `gnutls_certificate_set_x509_key_file'.
5147
d2127135
JB
51482011-05-05 Juanma Barranquero <lekktu@gmail.com>
5149
5150 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5151 Update dependencies.
5152
e968f4f3
JB
51532011-05-04 Juanma Barranquero <lekktu@gmail.com>
5154
5155 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5156 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5157 Remove unused parameter `fildes'.
5158 * process.c (read_process_output, send_process): Don't pass it.
5159
84d358f0
JB
51602011-05-04 Juanma Barranquero <lekktu@gmail.com>
5161
5162 Fix previous change: the library cache is defined in w32.c.
5163 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5164 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5165
0898ca10
JB
51662011-05-04 Juanma Barranquero <lekktu@gmail.com>
5167
5168 Implement dynamic loading of GnuTLS on Windows.
5169
5170 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5171 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5172 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5173 Declare.
5174
5175 * gnutls.c (Qgnutls_dll): Define.
5176 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5177 (gnutls_*): Declare function pointers.
5178 (init_gnutls_functions): New function to initialize function pointers.
5179 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5180 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5181 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5182 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5183 (emacs_gnutls_write, emacs_gnutls_read)
5184 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5185 (Fgnutls_available_p): New function.
5186 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5187 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5188 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5189
5190 * image.c: Include w32.h.
5191 (Vimage_type_cache): Delete.
5192 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5193 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5194 (w32_delayed_load): Move to w32.c.
5195
5196 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5197
5198 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5199 (w32_delayed_load): Move from image.c. When loading a library, record
5200 its filename in the :loaded-from property of the library id.
5201 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5202 Initialize and staticpro them.
5203 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5204
5205 * process.c: Include lisp.h before w32.h, not after.
5206 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5207 instead of gnutls_record_check_pending.
5208
5209 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5210
ff4de4aa
TZ
52112011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5212
5213 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5214 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5215 as passed in.
5216
abe95abb
JD
52172011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5218
5219 * xterm.c (x_set_frame_alpha): Do not set property on anything
5220 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5221
e16e55d4
JB
52222011-05-02 Juanma Barranquero <lekktu@gmail.com>
5223
5224 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5225
bafcf6a5
JB
52262011-05-02 Juanma Barranquero <lekktu@gmail.com>
5227
5228 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5229 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5230 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5231 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5232 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5233 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5234 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5235 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5236 (Qgnutls_bootprop_callbacks_verify): Make static.
5237
e7a6747f
AS
52382011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5239
19ed11ba
AS
5240 * callproc.c: Indentation fixup.
5241
e7a6747f 5242 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5243 (wait_for_termination, interruptible_wait_for_termination):
5244 Move after wait_for_termination_1.
e7a6747f 5245
1ef14cb4
LMI
52462011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5247
5248 * sysdep.c (interruptible_wait_for_termination): New function
5249 which is like wait_for_termination, but allows keyboard
5250 interruptions.
5251
5252 * callproc.c (Fcall_process): Add (:file "file") as an option for
5253 the STDOUT buffer.
5254 (Fcall_process_region): Ditto.
5255
330d880c
EZ
52562011-04-30 Eli Zaretskii <eliz@gnu.org>
5257
8db90b73
EZ
5258 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5259 rather than `XVECTOR (FOO)->size'.
5260
330d880c
EZ
5261 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5262 inttypes.h, as a gnulib replacement is used if it not available in
5263 system headers.
5264
15cbd324
EZ
52652011-04-21 Eli Zaretskii <eliz@gnu.org>
5266
5267 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5268 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5269 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5270
5271 * coding.c (coding_alloc_by_realloc): Error out if destination
5272 will grow beyond MOST_POSITIVE_FIXNUM.
5273 (decode_coding_emacs_mule): Abort if there isn't enough place in
5274 charbuf for the composition carryover bytes. Reserve an extra
5275 space for up to 2 characters produced in a loop.
5276 (decode_coding_iso_2022): Abort if there isn't enough place in
5277 charbuf for the composition carryover bytes.
5278
52792011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5280
ae940cca
EZ
5281 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5282 aborting when %lld or %lll format is passed.
5283 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5284 %llo or %llx format is passed. (Bug#8545)
5285
03ab8921
EZ
5286 * window.c (window_scroll_line_based): Use a marker instead of
5287 simple variables to record original value of point. (Bug#7952)
5288
afda1437
EZ
5289 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5290 produced by %s or %c overflows available buffer space. (Bug#8545)
5291
f76dee0c
PE
52922011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5293
5294 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5295 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5296
fdc5744d
JB
52972011-04-28 Juanma Barranquero <lekktu@gmail.com>
5298
5299 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5300
638f053a
JB
53012011-04-28 Juanma Barranquero <lekktu@gmail.com>
5302
5303 * keyboard.c (Qdelayed_warnings_hook): Define.
5304 (command_loop_1): Run `delayed-warnings-hook'
5305 if Vdelayed_warnings_list is non-nil.
5306 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5307 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5308
d178f871
EZ
53092011-04-28 Eli Zaretskii <eliz@gnu.org>
5310
5311 * doprnt.c (doprnt): Don't return value smaller than the buffer
5312 size if the message was truncated. (Bug#8545).
5313
b124fd93
JB
53142011-04-28 Juanma Barranquero <lekktu@gmail.com>
5315
5316 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5317 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5318
e810457d
PE
53192011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5320
5321 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5322
ea51cceb
JB
53232011-04-27 Juanma Barranquero <lekktu@gmail.com>
5324
5325 * makefile.w32-in: Update dependencies.
5326
94dcfacf
EZ
53272011-04-27 Eli Zaretskii <eliz@gnu.org>
5328
5329 Improve `doprnt' and its usage. (Bug#8545)
5330 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5331 `format_end'. Remove support for %l as a conversion specifier.
5332 Don't use xrealloc. Improve diagnostics when the %l size modifier
5333 is used. Update the commentary.
5334
5335 * eval.c (verror): Simplify calculation of size_t.
5336
5337 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5338 messages.
5339
f61f41d7
PE
53402011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5341
5342 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5343 change.
5344
96fb4434
PE
53452011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5346
5347 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5348 This makes this file independent of the recent pseudovector change.
5349
671875da 53502011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5351
69e9b5a3
PE
5352 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5353
b5f869a7 5354 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5355 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5356 Remove unused local.
c8926152 5357 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5358
841a1577 5359 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5360 GCC 4.6.0 optimizes based on type-based alias analysis.
5361 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5362 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5363 != &v->size, and therefore "v->size = 1; b->size = 2; return
5364 v->size;" must therefore return 1. This assumption is incorrect
5365 for Emacs, since it type-puns struct Lisp_Vector * with many other
5366 types. To fix this problem, this patch adds a new type struct
f904488f 5367 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5368 and pseudovectors, and helps optimizing compilers not get fooled
5369 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5370 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5371 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5372 the size member.
eab3844f
PE
5373 (XSETPVECTYPE): Rewrite in terms of new macro.
5374 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5375 This is a bit clearer, and further avoids the possibility of
5376 undesirable aliasing.
5377 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5378 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5379 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5380 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5381 (ASIZE): Now uses header.size rather than size.
5382 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5383 to avoid the hassle of writing XVECTOR (foo)->header.size.
5384 (struct vectorlike_header): New type.
eab3844f
PE
5385 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5386 object, to help avoid aliasing.
5387 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5388 (SUBRP): Likewise, since Lisp_Subr is a special case.
5389 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5390 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5391 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5392 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5393 changed to be "header.size" and "header.next".
5394 * buffer.h (struct buffer): Likewise.
5395 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5396 * frame.h (struct frame): Likewise.
5397 * process.h (struct Lisp_Process): Likewise.
5398 * termhooks.h (struct terminal): Likewise.
5399 * window.c (struct save_window_data, struct saved_window): Likewise.
5400 * window.h (struct window): Likewise.
5401 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5402 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5403 * buffer.c (init_buffer_once): Likewise.
5404 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5405 special case.
5406 * process.c (Fformat_network_address): Use local var for size,
5407 for brevity.
5408
0df1eac5
PE
5409 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5410
847ab9d1 5411 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5412 * data.c (atof): Remove decl; no longer used or needed.
5413 (digit_to_number): Move to lread.c.
5414 (Fstring_to_number): Use new string_to_number function, to be
5415 consistent with how the Lisp reader treats infinities and NaNs.
5416 Do not assume that floating-point numbers represent EMACS_INT
5417 without losing information; this is not true on most 64-bit hosts.
5418 Avoid double-rounding errors, by insisting on integers when
5419 parsing non-base-10 numbers, as the documentation specifies.
5420 * lisp.h (string_to_number): New decl, replacing ...
5421 (isfloat_string): Remove.
bc0a5c13 5422 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5423 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5424 appears to have been a coding error. Similarly, do not accept
5425 strings like +-1e0 as floating point numbers. Do not report
5426 overflow for integer overflows unless the base is not 10 which
5427 means we have no simple and reliable way to continue.
5428 Break out the floating-point parsing into a new
5429 function string_to_number, so that Fstring_to_number parses
5430 floating point numbers consistently with the Lisp reader.
04f2d78b 5431 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5432 (E_CHAR, EXP_INT): Remove, replacing with ...
5433 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5434 (string_to_number): New function, replacing isfloat_string.
5435 This function checks for valid syntax and produces the resulting
5436 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5437 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5438 so that overflow for non-base-10 numbers is reported only when
5439 there's no portable and simple way to convert to floating point.
452f4150 5440
67769ffc
PE
5441 * textprop.c (set_text_properties_1): Rewrite for clarity,
5442 and to avoid GCC warning about integer overflow.
5443
c20db43f
PE
5444 * intervals.h (struct interval): Use EMACS_INT for members
5445 where EMACS_UINT might cause problems. See
5446 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5447 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5448 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5449 All uses changed.
37aa2f85
PE
5450 (offset_intervals): Tell GCC not to worry about length overflow
5451 when negating a negative length.
c20db43f 5452
2538aa2f
PE
5453 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5454 (overrun_check_free): Likewise.
5455
f2d3008d
PE
5456 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5457 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5458 word size.
5459
ec8df744
PE
5460 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5461 (gnutls_make_error): Rename local to avoid shadowing.
5462 (gnutls_emacs_global_deinit): ifdef out; not used.
5463 (Fgnutls_boot): Use const for pointer to readonly storage.
5464 Comment out unused local. Fix pointer signedness problems.
5465
640ee02d
PE
5466 * lread.c (openp): Don't stuff size_t into an 'int'.
5467 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5468 about possible signed overflow.
5469
6048fb2a
PE
5470 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5471 (GDK_KEY_g): Don't define if already defined.
5472 (xg_prepare_tooltip): Avoid pointer signedness problem.
5473 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5474
fa3c87e1
PE
5475 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5476 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5477
2172544b
PE
5478 * xfns.c (Fx_window_property): Simplify a bit,
5479 to make a bit faster and to avoid GCC 4.6.0 warning.
5480 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5481
9b821a21
PE
5482 * fns.c (internal_equal): Don't assume size_t fits in int.
5483
3c616cfa
PE
5484 * alloc.c (compact_small_strings): Tighten assertion a little.
5485
c2982e87
PE
5486 Replace pEd with more-general pI, and fix some printf arg casts.
5487 * lisp.h (pI): New macro, generalizing old pEd macro to other
5488 conversion specifiers. For example, use "...%"pI"d..." rather
5489 than "...%"pEd"...".
5490 (pEd): Remove. All uses replaced with similar uses of pI.
5491 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5492 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5493 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5494 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5495 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5496 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5497 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5498 64-bit hosts.
5499 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5500 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5501 * print.c (safe_debug_print, print_object): Likewise.
5502 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5503 to int.
6f04d126
PE
5504 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5505 avoiding the 0 flag, which is not portable.
c2982e87
PE
5506 * process.c (Fmake_network_process): Use pI to avoid cast.
5507 * region-cache.c (pp_cache): Likewise.
5508 * xdisp.c (decode_mode_spec): Likewise.
5509 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5510 behavior on 64-bit hosts with printf arg.
6f04d126 5511 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5512 (x_stop_queuing_selection_requests): Likewise.
5513 (x_get_window_property): Don't truncate byte count to an 'int'
5514 when tracing.
0b432f21 5515
5e073ec7
PE
5516 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5517 here, since it parses constructs like leading '-' and spaces,
5518 which are not wanted; and it overflows with large numbers.
5519 Instead, simply match F[0-9]+, which is what is wanted anyway.
5520
36372bf9
PE
5521 * alloc.c: Remove unportable assumptions about struct layout.
5522 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5523 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5524 (allocate_vectorlike, make_pure_vector): Use the new macros,
5525 plus offsetof, to remove unportable assumptions about struct layout.
5526 These assumptions hold on all porting targets that I know of, but
5527 they are not guaranteed, they're easy to remove, and removing them
5528 makes further changes easier.
5529
0b432f21
PE
5530 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5531 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5532 (string_overrun_cookie): Now const. Use initializers that
5533 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5534 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5535 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5536 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5537 multiple of sizeof (EMACS_INT); it need not be, if
5538 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5539 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5540
895009e1
JB
55412011-04-26 Juanma Barranquero <lekktu@gmail.com>
5542
5543 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5544
6a7a1b0b
TZ
55452011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5546
5547 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5548 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5549 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5550
841a1577 55512011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5552
5553 * lisp.h (Qdebug): List symbol.
895009e1 5554 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5555 * keyboard.c (debug-on-event): New variable.
5556 (handle_user_signal): Break into debugger when debug-on-event
5557 matches the current signal symbol.
5558
f2d3ba6f
DN
55592011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5560
5561 * alloc.c (check_sblock, check_string_bytes)
5562 (check_string_free_list): Convert to standard C.
5563
42ce4c63
TZ
55642011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5565
5566 * w32.c (emacs_gnutls_push): Fix typo.
5567
825cd63c
EZ
55682011-04-25 Eli Zaretskii <eliz@gnu.org>
5569
fb11d64d
EZ
5570 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5571 "cast to pointer from integer of different size".
5572
825cd63c
EZ
5573 Improve doprnt and its use in verror. (Bug#8545)
5574 * doprnt.c (doprnt): Document the set of format control sequences
5575 supported by the function. Use SAFE_ALLOCA instead of always
5576 using `alloca'.
5577
5578 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5579 is one byte too soon. Don't use xrealloc; instead xfree and
5580 xmalloc anew.
5581
e061a11b
TZ
55822011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5583
5584 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5585 callbacks stage.
5586
5587 * gnutls.c: Renamed global_initialized to
5588 gnutls_global_initialized. Added internals for the
5589 :verify-hostname-error, :verify-error, and :verify-flags
5590 parameters of `gnutls-boot' and documented those parameters in the
5591 docstring. Start callback support.
9173deec
JB
5592 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5593 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5594 on error. Return error code.
e061a11b
TZ
5595 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5596 (emacs_gnutls_read): Likewise.
5597 (Fgnutls_boot): Return handshake error code.
5598 (emacs_gnutls_handle_error): New function.
5599 (wsaerror_to_errno): Likewise.
5600
5601 * w32.h (emacs_gnutls_pull): Add prototype.
5602 (emacs_gnutls_push): Likewise.
5603
5604 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5605 (emacs_gnutls_push): Likewise.
5606
56072011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5608
5609 * process.c (wait_reading_process_output): Check if GnuTLS
5610 buffered some data internally if no FDs are set for TLS
5611 connections.
5612
5613 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5614 (LIBS): Link to USER_LIBS.
5615 ($(BLD)/gnutls.$(0)): New target.
5616
fa6996bc
EZ
56172011-04-24 Eli Zaretskii <eliz@gnu.org>
5618
eb35682e
EZ
5619 * xdisp.c (handle_single_display_spec): Rename the
5620 display_replaced_before_p argument into display_replaced_p, to
5621 make it consistent with the commentary. Fix typos in the
5622 commentary.
5623
e2ad650c
EZ
5624 * textprop.c (syms_of_textprop): Remove dead code.
5625 (copy_text_properties): Delete obsolete commentary about an
5626 interface that was deleted long ago. Fix typos in the description
5627 of arguments.
5628
1b2de274
EZ
5629 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5630 to changes in oldXMenu/XMenu.h from 2011-04-16.
5631 <menu_help_message, prev_menu_help_message>: Constify.
5632 (IT_menu_make_room): menu->help_text is now `const char **';
5633 adjust.
5634
5635 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5636 to changes in oldXMenu/XMenu.h from 2011-04-16.
5637 (struct XMenu): Declare `help_text' `const char **'.
5638
5639 * xfaces.c <Qunspecified>: Make extern again.
5640
5641 * syntax.c: Include sys/types.h before including regex.h, as
5642 required by Posix.
5643
762b15be
EZ
5644 * doc.c (get_doc_string): Improve the format passed to `error'.
5645
5646 * doprnt.c (doprnt): Improve commentary.
5647
5648 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5649
5650 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5651 them with etags.
5652
f1052e5d
EZ
5653 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5654 changes in globals.h immediately force recompilation.
762b15be
EZ
5655 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5656 $(CURDIR)/s/ms-w32.h.
5657 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5658
fa6996bc
EZ
5659 * character.c (Fchar_direction): Function deleted.
5660 (syms_of_character): Don't defsubr it.
5661 <char-direction-table>: Deleted.
5662
e6c3da20
EZ
56632011-04-23 Eli Zaretskii <eliz@gnu.org>
5664
5665 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5666 * doprnt.c: Include limits.h.
5667 (SIZE_MAX): New macro.
04f2d78b
CB
5668 (doprnt): Return a size_t value. 2nd arg is now size_t.
5669 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5670 Improve overflow protection. Support `l' modifier for integer
5671 conversions. Support %l conversion. Don't assume an EMACS_INT
5672 argument for integer conversions and for %c.
5673
5674 * lisp.h (doprnt): Restore prototype.
5675
5676 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5677 $(SRC)/character.h.
5678
5679 * Makefile.in (base_obj): Add back doprnt.o.
5680
5681 * deps.mk (doprnt.o): Add back prerequisites.
5682 (callint.o): Depend on character.h.
5683
5684 * eval.c (internal_lisp_condition_case): Include the handler
5685 representation in the error message.
5686 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5687 when breaking from the loop.
5688
5689 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5690
5691 * callint.c (Fcall_interactively): When displaying error message
5692 about invalid control letter, pass the character's codepoint, not
5693 a pointer to its multibyte form. Improve display of the character
5694 in octal and display also its hex code.
5695
5696 * character.c (char_string): Use %x to display the (unsigned)
5697 codepoint of an invalid character, to avoid displaying a bogus
5698 negative value.
5699
5700 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5701 `error', not SYMBOL_NAME itself.
5702
5703 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5704 character arguments to `error'.
5705
5706 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5707 to `error' in error message about FINAL_CHAR argument. Make sure
5708 FINAL_CHAR is a character, and use %c when it is passed as
5709 argument to `error'.
5710
4ffd0d6b 57112011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5712
5713 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5714
5715 * w32.c: Include <time.h>.
5716 (sys_localtime): New function.
5717
4ffd0d6b 57182011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5719
5720 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5721
4ffd0d6b 5722 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5723
4ffd0d6b 57242011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5725
4ffd0d6b
GM
5726 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5727 zombies (Bug#8467).
aac0c6e3 5728
04c56954
EZ
57292011-04-19 Eli Zaretskii <eliz@gnu.org>
5730
5731 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5732 gl_state.e_property when gl_state.object is Qt.
5733
5734 * insdel.c (make_gap_larger): Remove limitation of buffer size
5735 to <= INT_MAX.
5736
16a43933
CY
57372011-04-18 Chong Yidong <cyd@stupidchicken.com>
5738
5739 * xdisp.c (lookup_glyphless_char_display)
5740 (produce_glyphless_glyph): Handle cons cell entry in
5741 glyphless-char-display.
5742 (Vglyphless_char_display): Document it.
5743
5744 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5745 glyphless-char-display.
5746
4581706e
CY
57472011-04-17 Chong Yidong <cyd@stupidchicken.com>
5748
5749 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5750
5751 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5752
5753 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5754 definition for no-X builds.
5755
4887c6e2 57562011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5757
fd35b6f9
PE
5758 Static checks with GCC 4.6.0 and non-default toolkits.
5759
5c1ccb01
PE
5760 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5761
006c5daa
PE
5762 * process.c (keyboard_bit_set): Define only if SIGIO.
5763 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5764 (send_process): Repair possible setjmp clobbering.
5765
efc736d3
PE
5766 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5767
4e2fe2e6
PE
5768 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5769
f97334a2
PE
5770 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5771
4e75f29d
PE
5772 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5773 Define only if needed.
5774
90efadd1
PE
5775 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5776 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5777 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5778
3c647824
PE
5779 * dispextern.h (struct redisplay_interface): Rename param
5780 to avoid shadowing.
e264f262 5781 * termhooks.h (struct terminal): Likewise.
761383f4 5782 * xterm.c (xembed_send_message): Likewise.
3c647824 5783
b58c5c4a
PE
5784 * insdel.c (make_gap_smaller): Define only if
5785 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5786
cad59032
PE
5787 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5788 it.
5789
c339dc2e
PE
5790 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5791 so that we aren't warned about unused symbols.
5792
91a3e27b
PE
5793 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5794
399c71d3 5795 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5796
8ffc96f5
PE
5797 * xfns.c (x_real_positions): Mark locals as initialized.
5798
eef9bc79
PE
5799 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5800
098db9dd
PE
5801 * xterm.c: Fix problems found by static analysis with other toolkits.
5802 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5803 (x_dispatch_event): Declare static if USE_GTK, and
5804 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5805 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5806 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5807 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5808 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5809
eb18f6cc
PE
5810 * xmenu.c (menu_help_callback): Pointer type fixes.
5811 Use const pointers when pointing at readonly data. Avoid pointer
5812 signedness clashes.
5813 (FALSE): Remove unused macro.
5814 (update_frame_menubar): Remove unused decl.
5815
1fe72bf8
PE
5816 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5817
60d9e1db
PE
5818 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5819 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5820 (single_menu_item): Rename local to avoid shadowing.
5821
39261c26
PE
5822 * keyboard.c (make_lispy_event): Remove unused local var.
5823
018c5e19
PE
5824 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5825 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5826
63d2b86e
PE
5827 * bitmaps: Change bitmaps from unsigned char back to the X11
5828 compatible char. Avoid the old compiler warnings about
5829 out-of-range initializers by using, for example, '\xab' rather
5830 than 0xab.
5831
aefd87e1
PE
5832 * xgselect.c (xgselect_initialize): Check vs interface
5833 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5834
bf501fb9
PE
5835 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5836
e9829fdf
PE
5837 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5838 to read-only memory.
5839
1086c095
PE
5840 * fns.c (vector): Remove; this old hack is no longer needed.
5841
2baccd04 5842 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5843 Remove unused var.
dde42981 5844 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5845
72391843 5846 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5847
436c16df 5848 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5849 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5850 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5851
92bb796d 5852 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5853 (x_term_init): Remove local to avoid shadowing.
92bb796d 5854
764430a3 5855 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5856
5857 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5858 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5859
d1dfb56c
EZ
58602011-04-16 Eli Zaretskii <eliz@gnu.org>
5861
c4354cb4
EZ
5862 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5863
d1dfb56c
EZ
5864 Fix regex.c, syntax.c and friends for buffers > 2GB.
5865 * syntax.h (struct gl_state_s): Declare character position members
5866 EMACS_INT.
5867
5868 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5869
04f2d78b
CB
5870 * textprop.c (verify_interval_modification, interval_of):
5871 Declare arguments EMACS_INT.
d1dfb56c
EZ
5872
5873 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5874 EMACS_INT.
5875
5876 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5877
5878 * indent.c (Fvertical_motion): Local variable it_start is now
5879 EMACS_INT.
5880
5881 * regex.c (re_match, re_match_2, re_match_2_internal)
5882 (bcmp_translate, regcomp, regexec, print_double_string)
5883 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5884 (re_compile_pattern, re_exec): Declare arguments and local
5885 variables `size_t' and `ssize_t' and return values `regoff_t', as
5886 appropriate.
5887 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5888 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5889 <compile_stack_type>: `size' and `avail' are now `size_t'.
5890
5891 * regex.h <regoff_t>: Use ssize_t, not int.
5892 (re_search, re_search_2, re_match, re_match_2): Arguments that
5893 specify buffer/string position and length are now ssize_t and
5894 size_t. Return type is regoff_t.
5895
613052cd
BK
58962011-04-16 Ben Key <bkey76@gmail.com>
5897
5898 * nsfont.m: Fixed bugs in ns_get_family and
5899 ns_descriptor_to_entity that were caused by using free to
5900 deallocate memory blocks that were allocated by xmalloc (via
5901 xstrdup). This caused Emacs to crash when compiled with
5902 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5903 --enable-checking=xmallocoverrun). xfree is now used to
5904 deallocate these memory blocks.
5905
4170f62f 59062011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5907
71b41406
PE
5908 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5909
9587a89d
PE
5910 emacs_write: Accept and return EMACS_INT for sizes.
5911 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5912 et seq.
5913 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5914 Accept and return EMACS_INT.
5915 (emacs_gnutls_write): Return the number of bytes written on
5916 partial writes.
5917 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5918 (emacs_read, emacs_write): Remove check for negative size, as the
5919 Emacs source code has been audited now.
9587a89d
PE
5920 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5921 (emacs_read, emacs_write): Use it.
273a5f82
PE
5922 * process.c (send_process): Adjust to the new signatures of
5923 emacs_write and emacs_gnutls_write. Do not attempt to store
5924 a byte offset into an 'int'; it might overflow.
9587a89d 5925 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5926
3e047f51
PE
5927 * sound.c: Don't assume sizes fit in 'int'.
5928 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5929 Return EMACS_INT, not int.
3e047f51 5930 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5931 Accept EMACS_INT, not int.
5932 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5933 record read return values.
5934
cc39a9db
BK
59352011-04-15 Ben Key <bkey76@gmail.com>
5936
c9d0ec6d
JB
5937 * keyboard.c (Qundefined): Don't declare static since it is used
5938 in nsfns.m.
5939 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5940 static since they are used in nsfont.m.
cc39a9db 5941
6c60eb9f
SM
59422011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5943
5944 * process.c (Qprocessp): Don't declare static.
5945 * lisp.h (Qprocessp): Declare again.
5946
7990b61a
JB
59472011-04-15 Juanma Barranquero <lekktu@gmail.com>
5948
5949 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5950
5d4cb038
PE
59512011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5952
8bd7b830 5953 Improve C-level modularity by making more things 'static'.
cd64ea1d 5954
e3b27b31
PE
5955 Don't publish debugger-only interfaces to other modules.
5956 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5957 (verify_bytepos, count_markers): Move decls to the only modules
5958 that need them.
5959 * region-cache.h (pp_cache): Likewise.
5960 * window.h (check_all_windows): Likewise.
5961 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5962
5d4cb038
PE
5963 * sysdep.c (croak): Now static, if
5964 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5965 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5966
5967 * alloc.c (refill_memory_reserve): Now static if
5968 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5969 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5970
e87b6180
PE
5971 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5972 Define only if USE_LUCID.
5973
ac64929e
PE
5974 * xrdb.c (x_customization_string, x_rm_string): Now static.
5975
6f37259d
PE
5976 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5977 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5978
1683e3ab
PE
5979 * xdisp.c (draw_row_with_mouse_face): Now static.
5980 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5981
de9c2632
PE
5982 * window.h (check_all_windows): Mark externally visible.
5983
2b96acb7
PE
5984 * window.c (window_deletion_count): Now static.
5985
5986 * undo.c: Make symbols static if they're not exported.
5987 (last_undo_buffer, last_boundary_position, pending_boundary):
5988 Now static.
5989
50436f33
PE
5990 * textprop.c (interval_insert_behind_hooks): Now static.
5991 (interval_insert_in_front_hooks): Likewise.
5992
64520e5c
PE
5993 * term.c: Make symbols static if they're not exported.
5994 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5995 (max_frame_lines, tty_set_terminal_modes):
5996 (tty_reset_terminal_modes, tty_turn_off_highlight):
5997 (get_tty_terminal): Now static.
5998 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5999 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6000 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6001 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6002 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6003
1fa53021
PE
6004 * sysdep.c: Make symbols static if they're not exported.
6005 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6006 Now static.
6007 (sigprocmask_set, full_mask): Remove; unused.
6008 (wait_debugging): Mark as visible.
6009 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6010 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6011
d4b43b22
PE
6012 * syntax.c (syntax_temp): Define only if !__GNUC__.
6013
b7c513d0
PE
6014 * sound.c (current_sound_device, current_sound): Now static.
6015
989b29ad
PE
6016 * search.c (searchbufs, searchbuf_head): Now static.
6017
13a55a78
PE
6018 * scroll.c (scroll_cost): Remove; unused.
6019 * dispextern.h (scroll_cost): Remove decl.
6020
de68a1fc
PE
6021 * region-cache.h (pp_cache): Mark as externally visible.
6022
40ccffa6
PE
6023 * process.c: Make symbols static if they're not exported.
6024 (process_tick, update_tick, create_process, chan_process):
6025 (Vprocess_alist, proc_buffered_char, datagram_access):
6026 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6027 (deactivate_process): Mark defn as static, as well as decl.
6028 * lisp.h (create_process): Remove decl.
6029 * process.h (chan_process, Vprocess_alist): Remove decls.
6030
ad64fc97
PE
6031 * print.c: Make symbols static if they're not exported.
6032 (print_depth, new_backquote_output, being_printed, print_buffer):
6033 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6034 (print_interval, print_number_index, initial_stderr_stream):
6035 Now static.
6036 * lisp.h (Fprinc): Remove decl.
6037 (debug_output_compilation_hack): Mark as externally visible.
6038
adddb265
PE
6039 * sysdep.c (croak): Move decl from here to syssignal.h.
6040 * syssignal.h (croak): Put it here, so the API can be checked when
6041 'croak' is called from dissociate_if_controlling_tty.
6042
1717ede2
PE
6043 * minibuf.c: Make symbols static if they're not exported.
6044 (minibuf_save_list, choose_minibuf_frame): Now static.
6045 * lisp.h (choose_minibuf_frame): Remove decl.
6046
fa5fb2bc
PE
6047 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6048
1e3890d1
PE
6049 * lread.c: Make symbols static if they're not exported.
6050 (read_objects, initial_obarray, oblookup_last_bucket_number):
6051 Now static.
6052 (make_symbol): Remove; unused.
6053 * lisp.h (initial_obarray, make_symbol): Remove decls.
6054
8a1414fa
PE
6055 * keyboard.c: Make symbols static if they're not exported.
6056 (single_kboard, recent_keys_index, total_keys, recent_keys):
6057 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6058 (this_single_command_key_start, echoing, last_auto_save):
6059 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6060 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6061 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6062 (Vlispy_mouse_stem, double_click_count):
6063 Now static.
6064 (force_auto_save_soon): Define only if SIGDANGER.
6065 (ignore_mouse_drag_p): Now static if
6066 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6067 (print_help): Remove; unused.
6068 (stop_character, last_timer_event): Mark as externally visible.
6069 * keyboard.h (ignore_mouse_drag_p): Declare only if
6070 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6071 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6072 * lisp.h (echoing): Remove decl.
6073 (force_auto_save_soon): Declare only if SIGDANGER.
6074 * xdisp.c (redisplay_window): Simplify code, to make it more
6075 obvious that ignore_mouse_drag_p is not accessed if !defined
6076 USE_GTK && !defined HAVE_NS.
6077
93ea6e8f
PE
6078 * intervals.c: Make symbols static if they're not exported.
6079 (merge_properties_sticky, merge_interval_right, delete_interval):
6080 Now static.
6081 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6082
77382fcc
PE
6083 * insdel.c: Make symbols static if they're not exported.
6084 However, leave prepare_to_modify_buffer alone. It's never
6085 called from outside this function, but that appears to be a bug.
6086 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6087 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6088 (adjust_after_replace_noundo): Remove; unused.
6089 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6090 (signal_before_change): Remove decls.
77382fcc 6091
9306c32e
PE
6092 * indent.c (val_compute_motion, val_vmotion): Now static.
6093
cd44d2eb
PE
6094 * image.c: Make symbols static if they're not exported.
6095 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6096 if USE_GTK.
6097 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6098 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6099
ad9a7a06
PE
6100 * fringe.c (standard_bitmaps): Now static.
6101 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6102
81626931
PE
6103 * frame.c: Make symbols static if they're not exported.
6104 (x_report_frame_params, make_terminal_frame): Now static.
6105 (get_frame_param): Now static, unless HAVE_NS.
6106 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6107 (x_get_resource_string): Remove; not used.
6108 * frame.h (make_terminal_frame, x_report_frame_params):
6109 (x_get_resource_string); Remove decls.
6110 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6111 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6112
239f9db9
PE
6113 * font.c, fontset.c: Make symbols static if they're not exported.
6114 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6115 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6116 * font.c (font_close_object): Now static.
6117 * font.h (font_close_object): Remove.
6118 * fontset.c (FONTSET_OBJLIST): Remove.
6119 (free_realized_fontset) #if-0 the body, which does nothing.
6120 (face_suitable_for_char_p): #if-0, as it's never called.
6121 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6122 * xfaces.c (face_at_string_position):
6123 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6124 since 0 is always ASCII.
6125
dfcf3579
PE
6126 * fns.c (weak_hash_tables): Now static.
6127
5045092b
PE
6128 * fileio.c: Make symbols static if they're not exported.
6129 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6130 (Vwrite_region_annotation_buffers): Now static.
6131
57a96f5c
PE
6132 * eval.c: Make symbols static if they're not exported.
6133 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6134 * lisp.h (backtrace_list): Remove decl.
6135
35f08c38
PE
6136 * emacs.c: Make symbols static if they're not exported.
6137 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6138 (fatal_error_code, fatal_error_signal_hook, standard_args):
6139 Now static.
6140 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6141 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6142 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6143 * lisp.h (fatal_error_signal_hook): Remove decl.
6144 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6145
f44bd759
PE
6146 * editfns.c: Move a (normally-unused) function to its only use.
6147 * editfns.c, lisp.h (get_operating_system_release): Remove.
6148 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6149 worth the hassle of breaking this out.
6150
b532497d
PE
6151 * xterm.c: Make symbols static if they're not exported.
6152 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6153 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6154 (x_destroy_window, x_delete_display):
6155 Now static.
6156 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6157 (x_mouse_leave): Remove; unused.
6158 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6159 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6160 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6161 Remove decls.
6162 (x_mouse_leave): Declare only if WINDOWSNT.
6163 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6164 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6165 USE_X_TOOLKIT.
6166
1675728f
PE
6167 * ftxfont.c: Make symbols static if they're not exported.
6168 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6169 HAVE_FREETYPE.
6170 * font.h (ftxfont_driver): Likewise.
6171
e4cebfca
PE
6172 * xfns.c: Make symbols static if they're not exported.
6173 (x_last_font_name, x_display_info_for_name):
6174 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6175 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6176 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6177 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6178 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6179 (last_show_tip_args): Now static.
6180 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6181 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6182 (x_screen_planes): Remove; unused.
6183 * dispextern.h (x_screen_planes): Remove decl.
6184
5bf46f05
PE
6185 * dispnew.c: Make symbols static if they're not exported.
6186 * dispextern.h (redraw_garbaged_frames, scrolling):
6187 (increment_row_positions): Remove.
6188 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6189 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6190 Now static.
6191 (redraw_garbaged_frames): Remove; unused.
6192
435f4c28
PE
6193 * xfaces.c: Make symbols static if they're not exported.
6194 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6195 Remove decls.
6196 * xterm.h (defined_color): Remove decls.
6197 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6198 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6199 (menu_face_changed_default, defined_color, free_realized_face):
6200 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6201 (ascii_face_of_lisp_face): Remove; unused.
6202
8524aef3
PE
6203 * xdisp.c: Make symbols static if they're not exported.
6204 * dispextern.h (scratch_glyph_row, window_box_edges):
6205 (glyph_to_pixel_coords, set_cursor_from_row):
6206 (get_next_display_element, set_iterator_to_next):
6207 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6208 (show_mouse_face): Remove decls
6209 * frame.h (message_buf_print): Likewise.
6210 * lisp.h (pop_message, set_message, check_point_in_composition):
6211 Likewise.
6212 * xterm.h (set_vertical_scroll_bar): Likewise.
6213 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6214 (message_buf_print, scratch_glyph_row, displayed_buffer):
6215 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6216 (get_next_display_element, show_mouse_face, window_box_edges):
6217 (frame_to_window_pixel_xy, check_point_in_composition):
6218 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6219 (glyph_to_pixel_coords): Remove; unused.
6220
16390cd2
PE
6221 * dired.c (file_name_completion): Now static.
6222
6223 * dbusbind.c (xd_in_read_queued_messages): Now static.
6224
a25f4dfa
PE
6225 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6226 * data.c (circular_list_error): Remove.
6227
14a9c8df
PE
6228 * commands.h (last_point_position, last_point_position_buffer):
6229 (last_point_position_window): Remove decls.
6230 * keyboard.c: Make these variables static.
6231
04f2d78b
CB
6232 * coding.h (coding, code_convert_region, encode_coding_gap):
6233 Remove decls.
74ab6df5
PE
6234 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6235 (iso_code_class, detect_coding, code_convert_region): Now static.
6236 (encode_coding_gap): Remove; unused.
6237
38dfbee1
PE
6238 * chartab.c (chartab_chars, chartab_bits): Now static.
6239
a2cb4e63
PE
6240 * charset.h (charset_iso_8859_1): Remove decl.
6241 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6242 Now static.
6243
127198fd
PE
6244 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6245 * ccl.c (Vccl_program_table): Now static.
6246 (check_ccl_update): Remove; unused.
6247
d85b608f
PE
6248 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6249 * category.h: ... from here.
6250 * category.c (check_category_table, set_category_set): Now static.
6251
31cd66f3
PE
6252 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6253 * lisp.h: Remove these decls.
6254
c358e587
PE
6255 * buffer.c (buffer_count): Remove unused var.
6256
e78aecca
PE
6257 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6258 so that it's not optimized away.
6259 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6260 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6261 exported only to the debugger.
6262
e192d7d3 6263 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6264 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6265
92470028
PE
6266 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6267 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6268 was inaccessible from Lisp.
6269 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6270 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6271
244ed907
PE
6272 alloc.c: Import and export fewer symbols, and remove unused items.
6273 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6274 is defined.
6275 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6276 it's not optimized away by whole-program optimization.
6277 (message_enable_multibyte, free_misc): Remove.
6278 (catchlist, handlerlist, mark_backtrace):
6279 Declare only if BYTE_MARK_STACK.
6280 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6281 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6282 (message_enable_multibyte): Remove decl.
6283 (free_misc, interval_free_list, float_block, float_block_index):
6284 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6285 (cons_free_list, last_marked_index):
6286 Now static.
6287 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6288 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6289 (mark_backtrace): Define only if BYTE_MARK_STACK.
6290 * xdisp.c (message_enable_multibyte): Now static.
6291
61c2b50e 6292 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6293 This makes it easier for human readers (and static analyzers)
6294 to see whether these variables are used from other modules.
6295 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6296 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6297 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6298 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6299 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6300 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6301 * xmenu.c, xselect.c:
6302 Declare Q* vars static if they are not used in other modules.
6303 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6304 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6305 Remove decls of unexported vars.
6306 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6307
95c82688
PE
6308 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6309
16a97296
PE
6310 Make Emacs functions such as Fatom 'static' by default.
6311 This makes it easier for human readers (and static analyzers)
6312 to see whether these functions can be called from other modules.
6313 DEFUN now defines a static function. To make the function external
6314 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6315 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6316 (Finit_image_library):
16a97296
PE
6317 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6318 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6319 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6320 Remove decls, since these functions are now static.
6321 (Funintern, Fget_internal_run_time): New decls, since these functions
6322 were already external.
95c82688 6323
16a97296
PE
6324 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6325 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6326 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6327 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6328 * keyboard.c, keymap.c, lread.c:
6329 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6330 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6331 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6332 Mark functions with DEFUE instead of DEFUN,
6333 if they are used in other modules.
6334 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6335 decls for now-static functions.
6336 * buffer.h (Fdelete_overlay): Remove decl.
6337 * callproc.c (Fgetenv_internal): Mark as internal.
6338 * composite.c (Fremove_list_of_text_properties): Remove decl.
6339 (Fcomposition_get_gstring): New forward static decl.
6340 * composite.h (Fcomposite_get_gstring): Remove decl.
6341 * dired.c (Ffile_attributes): New forward static decl.
6342 * doc.c (Fdocumntation_property): New forward static decl.
6343 * eval.c (Ffetch_bytecode): New forward static decl.
6344 (Funintern): Remove extern decl; now in .h file where it belongs.
6345 * fileio.c (Fmake_symbolic_link): New forward static decl.
6346 * image.c (Finit_image_library): New forward static decl.
6347 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6348 * intervals.h (Fprevious_property_change):
6349 (Fremove_list_of_text_properties): Remove decls.
6350 * keyboard.c (Fthis_command_keys): Remove decl.
6351 (Fcommand_execute): New forward static decl.
6352 * keymap.c (Flookup_key): New forward static decl.
6353 (Fcopy_keymap): Now static.
6354 * keymap.h (Flookup_key): Remove decl.
6355 * process.c (Fget_process): New forward static decl.
6356 (Fprocess_datagram_address): Mark as internal.
6357 * syntax.c (Fsyntax_table_p): New forward static decl.
6358 (skip_chars): Remove duplicate decl.
6359 * textprop.c (Fprevious_property_change): New forward static decl.
6360 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6361 Now internal.
6362 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6363 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6364
785bbd42
PE
6365 * editfns.c (Fformat): Remove unreachable code.
6366
8b913b57
AS
63672011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6368
6369 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6370 change. (Bug#8496)
6371
a6744a35
EZ
63722011-04-13 Eli Zaretskii <eliz@gnu.org>
6373
6374 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6375 when at ZV. (Bug#8487)
6376
e7974947
AS
63772011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6378
baad03f0
AS
6379 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6380 (Bug#8437)
6381 * keyboard.c (parse_tool_bar_item): Likewise.
6382 * sound.c (sound_cleanup, alsa_close): Likewise.
6383 * termcap.c (tgetent): Likewise.
6384 * xfns.c (x_default_font_parameter): Likewise.
6385 * xsettings.c (read_and_apply_settings): Likewise.
6386
e7974947
AS
6387 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6388 (overrun_check_free): Protoize.
6389
28272684
PE
63902011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6391
6392 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6393 since callers should never pass a negative size.
6394 Change the signature to match that of plain 'read' and 'write'; see
6395 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6396 * lisp.h: Update prototypes of emacs_write and emacs_read.
6397
11997c76
EZ
63982011-04-11 Eli Zaretskii <eliz@gnu.org>
6399
6400 * xdisp.c (redisplay_window): Don't try to determine the character
6401 position of the scroll margin if the window start point w->startp
e896f03c 6402 is outside the buffer's accessible region. (Bug#8468)
11997c76 6403
8a2cbd72
EZ
64042011-04-10 Eli Zaretskii <eliz@gnu.org>
6405
6406 Fix write-region and its subroutines for buffers > 2GB.
6407 * fileio.c (a_write, e_write): Modify declaration of arguments and
6408 local variables to support buffers larger than 2GB.
6409 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6410
6411 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6412 argument, local variables, and return value.
6413
6414 * lisp.h: Update prototypes of emacs_write and emacs_read.
6415
6416 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6417
4073e537 64182011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6419
1ebfdcb6
PE
6420 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6421
b2ded58d
PE
6422 Fix more problems found by GCC 4.6.0's static checks.
6423
7d66342c
PE
6424 * xdisp.c (vmessage): Use a better test for character truncation.
6425
bbf47d44
PE
6426 * charset.c (load_charset_map): <, not <=, for optimization,
6427 and to avoid potential problems with integer overflow.
9248994d 6428 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6429 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6430 * editfns.c (Fformat): Likewise.
1e69125e 6431 * syntax.c (skip_chars): Likewise.
3befa583 6432
e3019616
PE
6433 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6434 This also lets GCC 4.6.0 generate slightly better loop code.
6435
becfa255
PE
6436 * callint.c (Fcall_interactively): <, not <=, for optimization.
6437 (Fcall_interactively): Count the number of arguments produced,
6438 not the number of arguments given. This is simpler and lets GCC
6439 4.6.0 generate slightly better code.
6440
dae0cd48
PE
6441 * ftfont.c: Distingish more carefully between FcChar8 and char.
6442 The previous code passed unsigned char * to a functions like
6443 strlen and xstrcasecmp that expect char *, which does not
6444 conform to the C standard.
6445 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6446 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6447 char * when the C standard requires it.
6448
76032d70
PE
6449 * keyboard.c (read_char): Remove unused var.
6450
eb3f1cc8
PE
6451 * eval.c: Port to Windows vsnprintf (Bug#8435).
6452 Include <limits.h>.
6453 (SIZE_MAX): Define if the headers do not.
6454 (verror): Do not give up if vsnprintf returns a negative count.
6455 Instead, grow the buffer. This ports to Windows vsnprintf, which
6456 does not conform to C99. Problem reported by Eli Zaretskii.
6457 Also, simplify the allocation scheme, by avoiding the need for
6458 calling realloc, and removing the ALLOCATED variable.
6459
70476b54
PE
6460 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6461
12020a9e
PE
6462 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6463 But keep the doprint source code for now, as we might revamp it
6464 and use it again (Bug#8435).
ea6c7ae6
PE
6465 * lisp.h (doprnt): Remove.
6466 * Makefile.in (base_obj): Remove doprnt.o.
6467 * deps.mk (doprnt.o): Remove.
6468
5fdb398c
PE
6469 error: Print 32- and 64-bit integers portably (Bug#8435).
6470 Without this change, on typical 64-bit hosts error ("...%d...", N)
6471 was used to print both 32- and 64-bit integers N, which relied on
6472 undefined behavior.
6473 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6474 New macro.
6475 * lisp.h (error, verror): Mark as printf-like functions.
6476 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6477 Report overflow in size calculations when allocating printf buffer.
6478 Do not truncate output string at its first null byte.
6479 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6480 Truncate the output at a character boundary, since vsnprintf does not
6481 do that.
6482 * charset.c (check_iso_charset_parameter): Convert internal
6483 character to string before calling 'error', since %c now has the
6484 printf meaning.
6485 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6486 overflow when computing char to be passed to 'error'. Do not
6487 pass Lisp_Object to 'error'; pass the integer instead.
6488 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6489 formatted with plain %d.
6490
b189fa66
PE
6491 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6492
bff87ef0
PE
6493 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6494
7e2cac20
PE
6495 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6496
ce4d90b5
PE
6497 * xterm.c (x_catch_errors): Remove duplicate declaration.
6498
266c9547
PE
6499 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6500
79c49ad2
PE
6501 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6502
368f4090
JM
65032011-04-10 Jim Meyering <meyering@redhat.com>
6504
6505 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6506 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6507 return ssize_t not "int", and use size_t as the buffer length.
6508 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6509 * gnutls.h: Update declarations.
6510 * process.c (read_process_output): Use ssize_t, to match.
6511 (send_process): Likewise.
6512
a32d4040
CY
65132011-04-09 Chong Yidong <cyd@stupidchicken.com>
6514
6515 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6516
8546720e 65172011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6518
04f2d78b
CB
6519 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6520 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6521
8546720e
GM
6522 * xterm.c (handle_one_xevent):
6523 * xmenu.c (create_and_show_popup_menu):
6524 * xselect.c (x_decline_selection_request)
6525 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6526
0a2f5c1a 65272011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6528
6529 Fix some uses of `int' instead of EMACS_INT.
6530 * search.c (string_match_1, fast_string_match)
6531 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6532 (scan_buffer, find_next_newline_no_quit)
6533 (find_before_next_newline, search_command, Freplace_match)
6534 (Fmatch_data): Make some `int' variables be EMACS_INT.
6535
6536 * xdisp.c (display_count_lines): 3rd argument and return value now
6537 EMACS_INT. All callers changed.
6538 (pint2hrstr): Last argument is now EMACS_INT.
6539
6540 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6541 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6542 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6543 (decode_coding_utf_16, decode_coding_emacs_mule)
6544 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6545 (decode_coding_ccl, decode_coding_charset)
6546 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6547 (decode_coding_iso_2022, decode_coding_emacs_mule)
6548 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6549 <char_offset, last_offset>: Declare EMACS_INT.
6550 (encode_coding_utf_8, encode_coding_utf_16)
6551 (encode_coding_emacs_mule, encode_invocation_designation)
6552 (encode_designation_at_bol, encode_coding_iso_2022)
6553 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6554 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6555 Declare EMACS_INT.
6556 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6557 (encode_invocation_designation): Last argument P_NCHARS is now
6558 EMACS_INT.
6559 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6560 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6561
6562 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6563 All users changed.
6564
6565 * ccl.c (Fccl_execute_on_string): Declare some variables
6566 EMACS_INT.
6567
8546720e 65682011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6569
6570 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6571
4e19a977
CS
65722011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6573
6574 * process.c (Fformat_network_address): Doc fix.
6575
87302331
R
65762011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6577
6578 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6579
cbb59342
CY
65802011-04-08 Chong Yidong <cyd@stupidchicken.com>
6581
6582 * keyboard.c (read_char): Call Lisp function help-form-show,
6583 instead of using internal_with_output_to_temp_buffer.
6584 (Qhelp_form_show): New var.
e0d38eeb 6585 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6586
6587 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6588
6589 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6590
e67a13ab
CY
65912011-04-06 Chong Yidong <cyd@stupidchicken.com>
6592
04f2d78b
CB
6593 * process.c (Flist_processes): Remove to Lisp.
6594 (list_processes_1): Delete.
e67a13ab 6595
973f782d
EZ
65962011-04-06 Eli Zaretskii <eliz@gnu.org>
6597
7c106b1e
EZ
6598 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6599
973f782d
EZ
6600 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6601
41cf7d1a 66022011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6603
ca23cc88
PE
6604 Fix more problems found by GCC 4.6.0's static checks.
6605
f390e2d5
PE
6606 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6607
42eea0d0
PE
6608 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6609
b69769da 6610 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6611
f9541e84
PE
6612 * xdisp.c (vmessage): Mark as a printf-like function.
6613
13841b55
PE
6614 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6615
c136c10f
PE
6616 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6617
5e2d4a30
PE
6618 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6619 printf-like functions.
6620 (tiff_load): Add casts to remove these marks before passing them
6621 to system-supplied API.
6622
583f48b9
PE
6623 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6624
b25d760e
PE
6625 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6626 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6627 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6628 directly, rather than having caller test rule sign. This avoids
6629 some unnecessary tests.
6630 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6631 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6632 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6633
bc7b6697 6634 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6635 (xfont_open): Avoid unnecessary tests.
bc7b6697 6636
27ccc379
PE
6637 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6638
dcd5c89a
PE
6639 * composite.h, composite.c (composition_gstring_put_cache):
6640 Use EMACS_INT, not int, for length.
6641
b13a45c6
PE
6642 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6643 breaking out part of COMPOSITION_DECODE_RULE.
6644 (COMPOSITION_DECODE_RULE): Use it.
6645 * composite.c (get_composition_id): Remove unused local vars,
6646 by using the new macro.
6647
1e792e4d
PE
6648 * textprop.c (set_text_properties_1): Change while to do-while,
6649 since the condition is always true at first.
6650
dc6c6455 6651 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6652 (interval_deletion_adjustment): Return unsigned value.
6653 All uses changed.
dc6c6455 6654
aba7731a
PE
6655 * process.c (list_processes_1, create_pty, read_process_output):
6656 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6657 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6658 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6659 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6660 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6661
fdfc4bf3
PE
6662 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6663
fca8fe46 6664 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6665 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6666
06a0259a 6667 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6668 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6669 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6670
e7b9e80f
PE
6671 * print.c (print_error_message): Avoid int overflow.
6672
56201685
PE
6673 * font.c (font_list_entities): Redo for clarity,
6674 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6675
78834453 6676 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6677 (font_score): Avoid potential overflow in diff calculation.
78834453 6678
0bc0b309 6679 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6680 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6681
e610eaca
PE
6682 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6683
b895abce
PE
6684 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6685 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6686 can always succeed if overflow has undefined behavior.
6687
1f1d9321 6688 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6689 (wordify): Omit three unnecessary tests.
1f1d9321 6690
c59478bc
PE
6691 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6692 All callers changed. This avoids the need for an unused var.
6693
79b73827
PE
6694 * casefiddle.c (casify_region): Remove var that is set but not used.
6695
a4db5dfe
PE
6696 * dired.c (file_name_completion): Remove var that is set but not used.
6697
43aae36e
PE
6698 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6699
2a47c44d 6700 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6701 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6702
a37c69bf
PE
6703 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6704 Check for integer overflow on size calculations.
6705
328ab8e7
PE
6706 * buffer.c (Fprevious_overlay_change): Remove var that is set
6707 but not used.
6708
e5a2a5cb
PE
6709 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6710 Remove vars that are set but not used.
8d84a6eb 6711 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6712 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6713
a60e5f68
PE
6714 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6715
f661cb61 6716 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6717 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6718
f0397f5a
PE
6719 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6720 that are set but not used.
6721
8664db06 6722 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6723 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6724
6abdaa4a
PE
6725 * xselect.c (x_get_local_selection, x_handle_property_notify):
6726 Remove vars that are set but not used.
6727
0ce7538d 6728 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6729 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6730
9ae848fc
PE
6731 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6732 Remove var that is set but not used.
0b918413
PE
6733 (scroll_bar_windows_size): Now size_t, not int.
6734 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6735 Check for overflow.
9ae848fc 6736
a5a62657
PE
6737 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6738 (map_tty_color) [!defined MSDOS]: Likewise.
6739
5c5cdd39
PE
6740 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6741
66ebf983
PE
6742 * coding.c: Remove vars that are set but not used.
6743 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6744 All callers changed.
6745 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6746 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6747 (decode_coding_charset): Remove vars that are set but not used.
6748
1be4d761
PE
6749 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6750 that is set but not used.
6751
47553fa8
PE
6752 * print.c (print_object): Remove var that is set but not used.
6753
1f7196bf 6754 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6755 The gnulib version avoids calling malloc in the usual case,
6756 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6757 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6758 * filelock.c (current_lock_owner): Likewise.
6759 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6760 * sysdep.c: Include allocator.h, careadlinkat.h.
6761 (emacs_no_realloc_allocator): New static constant.
6762 (emacs_readlink): New function.
fdb61804
PE
6763 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6764 ../lib/careadlinkat.h.
d1fdcab7 6765
f84c17c7
SM
67662011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6767
6768 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6769 first non-nil return value).
6770
ef3862ad
JD
67712011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6772
6773 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6774 if not defined (Bug#8403).
6775
376a7006
JB
67762011-04-02 Juanma Barranquero <lekktu@gmail.com>
6777
6778 * xdisp.c (display_count_lines): Remove parameter `start',
6779 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6780 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6781 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6782 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6783 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6784 and thereabouts. All callers changed.
6785 (get_per_char_metric): Remove parameter `f', unused since
6786 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6787
6ca3801d
JM
67882011-04-02 Jim Meyering <meyering@redhat.com>
6789
6790 do not dereference NULL upon failed strdup
6791 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6792 (ns_get_family): Likewise.
6793
d8e2b5ba
JB
67942011-04-02 Juanma Barranquero <lekktu@gmail.com>
6795
6796 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6797
8c74fcbd
JD
67982011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6799
6800 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6801 later (Bug#8403).
6802
7200d79c
SM
68032011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6804
03408648 6805 Add lexical binding.
7200d79c 6806
03408648
SM
6807 * window.c (Ftemp_output_buffer_show): New fun.
6808 (Fsave_window_excursion):
6809 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6810
6811 * lread.c (lisp_file_lexically_bound_p): New function.
6812 (Fload): Bind Qlexical_binding.
6813 (readevalloop): Remove `evalfun' arg.
6814 Bind Qinternal_interpreter_environment.
6815 (Feval_buffer): Bind Qlexical_binding.
6816 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6817 Mark as dynamic.
6818 (syms_of_lread): Declare `lexical-binding'.
6819
6820 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6821
6822 * keyboard.c (eval_dyn): New fun.
6823 (menu_item_eval_property): Use it.
ca105506
SM
6824
6825 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6826
03408648
SM
6827 * fns.c (concat, mapcar1): Accept byte-code-functions.
6828
6829 * eval.c (Fsetq): Handle lexical vars.
6830 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6831 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6832 (FletX, Flet): Obey lexical binding.
6833 (Fcommandp): Handle closures.
6834 (Feval): New `lexical' arg.
6835 (eval_sub): New function extracted from Feval. Use it almost
6836 everywhere where Feval was used. Look up vars in lexical env.
6837 Handle closures.
6838 (Ffunctionp): Move from subr.el.
6839 (Ffuncall): Handle closures.
6840 (apply_lambda): Remove `eval_flags'.
6841 (funcall_lambda): Handle closures and new byte-code-functions.
6842 (Fspecial_variable_p): New function.
6843 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6844 but without exporting it to Lisp.
23aba0ea 6845
23aba0ea 6846 * doc.c (Fdocumentation, store_function_docstring):
03408648 6847 * data.c (Finteractive_form): Handle closures.
23aba0ea 6848
03408648
SM
6849 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6850 interactive spec.
ba83908c 6851
04f2d78b
CB
6852 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6853 New byte-codes.
03408648
SM
6854 (exec_byte_code): New function extracted from Fbyte_code to handle new
6855 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6856
03408648 6857 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6858
03408648 6859 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6860
e2abce01
JB
68612011-03-31 Juanma Barranquero <lekktu@gmail.com>
6862
6863 * xdisp.c (redisplay_internal): Fix prototype.
6864
63696a73 68652011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6866
63696a73 6867 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6868 (try_scrolling): Use it when setting scroll_limit.
6869 Limit scrolling to 100 screen lines.
63696a73
EZ
6870 (redisplay_window): Even when falling back on "recentering",
6871 position point in the window according to scroll-conservatively,
6872 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6873
6874 (try_scrolling): When point is above the window, allow searching
6875 as far as scroll_max, or one screenful, to compute vertical
6876 distance from PT to the scroll margin position. This prevents
6877 try_scrolling from unnecessarily failing when
6878 scroll-conservatively is set to a value slightly larger than the
6879 window height. Clean up the case of PT below the margin at bottom
6880 of window: scroll_max can no longer be INT_MAX. When aggressive
6881 scrolling is in use, don't let point enter the opposite scroll
6882 margin as result of the scroll.
6883 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6884 threshold of 100 lines for never-recentering scrolling.
6885
e4cc2dfc
JB
68862011-03-31 Juanma Barranquero <lekktu@gmail.com>
6887
6888 * dispextern.h (move_it_by_lines):
6889 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6890 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6891 (message_log_check_duplicate): Remove parameters `prev_bol' and
6892 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6893 (redisplay_internal): Remove parameter `preserve_echo_area',
6894 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6895
6896 * indent.c (Fvertical_motion):
6897 * window.c (window_scroll_pixel_based, Frecenter):
6898 Don't pass `need_y_p' to `move_it_by_lines'.
6899
1c470562
SM
69002011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6901
44f230aa
SM
6902 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6903 steal a few bits to be more compact.
6904 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6905 Remove unneeded casts.
6906
1c470562
SM
6907 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6908
888adce9
ZK
69092011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6910
6911 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6912 binding" message (bug#7967).
6913
f838ed7b
PE
69142011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6915
77861b95
PE
6916 Fix more problems found by GCC 4.6.0's static checks.
6917
de6dbc14
PE
6918 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6919 Remove unused local var.
6920
f838ed7b
PE
6921 * editfns.c (Fmessage_box): Remove unused local var.
6922
792c7b2b
PE
6923 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6924 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6925 Omit unused local vars.
c499e557 6926 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6927 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6928 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6929 Omit unused local var.
6930
ba0165e1
PE
6931 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6932 Don't assume string length fits in int.
32ad8845 6933 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6934 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6935
3c59b4c9
PE
6936 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6937 instead of alloca (Bug#8344).
6938
a3eed478 6939 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6940 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6941
eb4d412d
PE
6942 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6943
1658b401
PE
6944 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6945 concerns.
6946
6947 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6948
6949 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6950
9a2c6e05
PE
6951 * keyboard.c (syms_of_keyboard): Use the same style as later
6952 in this function when indexing through an array. This also
6953 works around GCC bug 48267.
6954
03d0a109
PE
6955 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6956
44f730c8
PE
6957 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6958
fe75f926
PE
6959 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6960 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6961
ffa8c828
PE
6962 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6963 This avoids undefined behavior on integer overflow, and is a bit
6964 more convenient anyway since it is compared to a size_t variable.
6965
c5101a77
PE
6966 Variadic C functions now count arguments with size_t, not int.
6967 This avoids an unnecessary limitation on 64-bit machines, which
6968 caused (substring ...) to crash on large vectors (Bug#8344).
6969 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6970 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6971 All variadic functions and their callers changed accordingly.
c5101a77
PE
6972 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6973 * data.c (arith_driver, float_arith_driver): Likewise.
6974 * editfns.c (general_insert_function): Likewise.
6975 * eval.c (struct backtrace.nargs, interactive_p)
6976 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6977 (funcall_lambda, mark_backtrace): Likewise.
6978 * fns.c (concat): Likewise.
6979 * frame.c (x_set_frame_parameters): Likewise.
6980 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6981 0 if not found, not -1. All callers changed.
6982
dd3f25f7
PE
6983 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6984 (stack_copy_size): Now size_t, not int.
6985 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6986
461c2ab9
JB
69872011-03-28 Juanma Barranquero <lekktu@gmail.com>
6988
6989 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6990 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6991 All callers changed.
6992
6993 * lisp.h (multibyte_char_to_unibyte):
6994 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6995 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6996 * character.h (CHAR_TO_BYTE8):
6997 * cmds.c (internal_self_insert):
6998 * editfns.c (general_insert_function):
6999 * keymap.c (push_key_description):
7000 * search.c (Freplace_match):
7001 * xdisp.c (message_dolog, set_message_1): All callers changed.
7002
f6d62986
SM
70032011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7004
7005 * keyboard.c (safe_run_hook_funcall): New function.
7006 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7007 don't set the hook to nil, but remove the offending function instead.
7008 (Qcommand_hook_internal): Remove, unused.
7009 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7010 Vcommand_hook_internal.
7011
7012 * eval.c (enum run_hooks_condition): Remove.
7013 (funcall_nil, funcall_not): New functions.
7014 (run_hook_with_args): Call each function through a `funcall' argument.
7015 Remove `cond' argument, now redundant.
7016 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7017 (Frun_hook_with_args_until_failure): Adjust accordingly.
7018 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7019
1db5b1ad
JB
70202011-03-28 Juanma Barranquero <lekktu@gmail.com>
7021
7022 * dispextern.h (string_buffer_position): Remove declaration.
7023
7024 * print.c (strout): Remove parameter `multibyte', unused since
7025 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7026
7027 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7028 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7029 All callers changed.
7030
7031 * w32.c (_wsa_errlist): Use braces for struct initializers.
7032
7033 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7034 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7035 All callers changed.
7036 (string_buffer_position): Likewise. Also, make static (it's never
7037 used outside xdisp.c).
7038 (cursor_row_p): Remove parameter `w', unused since
7039 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7040 (decode_mode_spec): Remove parameter `precision', introduced during
7041 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7042 All callers changed.
7043
5ffb62aa
JD
70442011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7045
7046 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7047
461c2ab9 70482011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7049
7050 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7051 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7052 (ns_update_auto_hide_menu_bar): New functions.
7053 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7054 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7055 ns_constrain_all_frames.
7056 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7057 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7058
5c380ffb
JD
70592011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7060
7061 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7062
9af30bdf
GM
70632011-03-27 Glenn Morris <rgm@gnu.org>
7064
7065 * syssignal.h: Replace RETSIGTYPE with void.
7066 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7067 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7068 Replace SIGTYPE with void everywhere.
7069 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7070 * s/template.h (SIGTYPE): Remove commented out definition.
7071
e2abce01
JB
70722011-03-26 Eli Zaretskii <eliz@gnu.org>
7073
7074 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7075 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7076
f868cd8a
JB
70772011-03-26 Juanma Barranquero <lekktu@gmail.com>
7078
59eb0929
JB
7079 * w32.c (read_unc_volume): Use parameter `henum', instead of
7080 global variable `wget_enum_handle'.
7081
7082 * keymap.c (describe_vector): Remove parameters `indices' and
7083 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7084 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7085
f868cd8a
JB
7086 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7087
7088 * keyboard.c (timer_check): Remove parameter `do_it_now',
7089 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7090 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7091 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7092
7093 * keyboard.c (read_char):
7094 * w32menu.c (w32_menu_display_help):
7095 * xmenu.c (show_help_event, menu_help_callback):
7096 Adjust calls to `show_help_echo'.
7097
7098 * gtkutil.c (xg_maybe_add_timer):
7099 * keyboard.c (readable_events):
7100 * process.c (wait_reading_process_output):
7101 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7102
7103 * insdel.c (adjust_markers_gap_motion):
7104 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7105 (gap_left, gap_right): Don't call it.
7106
2ecf6fdb
CY
71072011-03-25 Chong Yidong <cyd@stupidchicken.com>
7108
7109 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7110 incurred during fontification.
7111
6b1f9ba4
JB
71122011-03-25 Juanma Barranquero <lekktu@gmail.com>
7113
7114 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7115 (DEFVAR_PER_BUFFER): Don't pass it.
7116
7117 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7118 (scrolling_window): Don't pass it.
7119
0f4a96b5
JB
71202011-03-25 Juanma Barranquero <lekktu@gmail.com>
7121
7122 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7123
7124 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7125 and `suffix'.
7126 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7127 of variables specific to SELinux and computation of `encoded_absname'.
7128
7129 * image.c (XPutPixel): Remove unused variable `height'.
7130
7131 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7132
7133 * unexw32.c (get_section_info): Remove unused variable `section'.
7134
7135 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7136 (system_process_attributes): Remove unused variable `sess'.
7137 (sys_read): Remove unused variable `err'.
7138
7139 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7140 (w32_wnd_proc): Remove unused variable `isdead'.
7141 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7142 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7143 (x_create_tip_frame): Remove unused variable `tem'.
7144
7145 * w32inevt.c (w32_console_read_socket):
7146 Remove unused variable `no_events'.
7147
7148 * w32term.c (x_draw_composite_glyph_string_foreground):
7149 Remove unused variable `width'.
7150
1149507c
JB
71512011-03-24 Juanma Barranquero <lekktu@gmail.com>
7152
7153 * w32term.c (x_set_glyph_string_clipping):
7154 Don't pass uninitialized region to CombineRgn.
7155
9c88f339
JB
71562011-03-23 Juanma Barranquero <lekktu@gmail.com>
7157
7158 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7159 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7160 (Fx_close_connection): Remove unused variable `i'.
7161
7162 * w32font.c (w32font_draw): Return number of glyphs.
7163 (w32font_open_internal): Remove unused variable `i'.
7164 (w32font_driver): Add missing initializer.
7165
7166 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7167 (fill_in_menu): Remove unused variable `items_added'.
7168
7169 * w32term.c (last_mouse_press_frame): Remove static global variable.
7170 (w32_clip_to_row): Remove unused variable `f'.
7171 (x_delete_terminal): Remove unused variable `i'.
7172
7173 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7174 (NOTHING): Remove unused static global variable.
7175 (uniscribe_check_otf): Remove unused variable `table'.
7176 (uniscribe_font_driver): Add missing initializers.
7177
dee091a3
JD
71782011-03-23 Julien Danjou <julien@danjou.info>
7179
7180 * term.c (Fsuspend_tty, Fresume_tty):
7181 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7182 * window.c (temp_output_buffer_show):
7183 * insdel.c (signal_before_change):
7184 * frame.c (Fhandle_switch_frame):
7185 * fileio.c (Fdo_auto_save):
7186 * emacs.c (Fkill_emacs):
7187 * editfns.c (save_excursion_restore):
7188 * cmds.c (internal_self_insert):
7189 * callint.c (Fcall_interactively):
7190 * buffer.c (Fkill_all_local_variables):
7191 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7192 Use Frun_hooks.
0f4a96b5 7193 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7194 unconditionnaly since it does the check itself.
7195
2c520ab5 71962011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7197
c9c49752
PE
7198 Fix more problems found by GCC 4.5.2's static checks.
7199
8abc3f12
PE
7200 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7201 the first time through the loop, since we know p0 < p1 then.
7202 This also avoids a gcc -Wstrict-overflow warning.
7203
a2d26660
PE
7204 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7205 leading to a memory leak, possible in functions like
7206 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7207 of objects (Bug#8318).
a2d26660 7208
916c72e9
PE
7209 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7210 that could (at least in theory) be that large.
7211
19ab8a18
PE
7212 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7213 This is less likely to overflow, and avoids undefined behavior if
7214 overflow does occur. All callers changed. Use strtoul to scan
7215 for the unsigned long integer.
b7cbbd6f
PE
7216 (pint2hrstr): Simplify and tune code slightly.
7217 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7218
f0641eff
PE
7219 * scroll.c (do_scrolling): Work around GCC bug 48228.
7220 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7221
7f650bb9
PE
7222 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7223 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7224 (validate_x_resource_name): Simplify count usage.
7225 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7226
37dd57d1
PE
7227 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7228 fail (Bug#8306).
81e56e61 7229
699979fc 7230 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7231
401bf9b4
PE
7232 * process.c (Fmake_network_process): Use socklen_t, not int,
7233 where POSIX says socklen_t is required in portable programs.
7234 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7235 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7236 (Fmake_network_process, server_accept_connection):
7237 (wait_reading_process_output, read_process_output):
7238 Likewise.
7239
b93aacde
PE
7240 * process.c: Rename or move locals to avoid shadowing.
7241 (list_processes_1, Fmake_network_process):
7242 (read_process_output_error_handler, exec_sentinel_error_handler):
7243 Rename or move locals.
4dc343ee 7244 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7245 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7246 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7247 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7248 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7249
af8a867c 7250 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7251 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7252 Include tparam.h instead, since it declares them.
af8a867c
PE
7253 * cm.h (PC): Remove extern decl; tparam.h now does this.
7254 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7255 * terminfo.c: Include tparam.h, to check interfaces.
7256 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7257 (tparam): Adjust signature to match interface in tparam.h;
7258 this removes some undefined behavior. Check that outstring and len
7259 are zero, which they always are with Emacs.
7260 * tparam.h (PC, BC, UP): New extern decls.
7261
0248044d 7262 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7263 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7264
8ff096c1 7265 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7266 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7267 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7268 (ftfont_list): Remove unused local.
49eaafba
PE
7269 (get_adstyle_property, ftfont_pattern_entity):
7270 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7271 Rename locals to avoid shadowing.
8ff096c1 7272
e2be39f6
PE
7273 * xfont.c (xfont_list_family): Mark var as initialized.
7274
c9735e30
PE
7275 * xml.c (make_dom): Now static.
7276
8f5201ae
PE
7277 * composite.c (composition_compute_stop_pos): Rename local to
7278 avoid shadowing.
b246f932
PE
7279 (composition_reseat_it): Remove unused locals.
7280 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7281 (composition_update_it): Mark var as initialized.
11b61122
PE
7282 (find_automatic_composition): Mark vars as initialized,
7283 with a FIXME (Bug#8290).
8f5201ae 7284
760fbc2c
PE
7285 character.h: Rename locals to avoid shadowing.
7286 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7287 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7288 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7289 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7290 to avoid shadowing.
7291
ff08eb85
PE
7292 * textprop.c (property_change_between_p): Remove; unused.
7293
fc7bf025
PE
7294 * intervals.c (interval_start_pos): Now static.
7295
235d7abc
PE
7296 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7297
44f230aa
SM
7298 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7299 Rename locals to avoid shadowing.
3e7d6594 7300
50060332
PE
7301 * sound.c (wav_play, au_play, Fplay_sound_internal):
7302 Fix pointer signedness.
d01f234b 7303 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7304 (wav_play): Initialize a variable to 0, to prevent undefined
7305 behavior (Bug#8278).
50060332 7306
c4fc4e30
PE
7307 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7308
918436ed
PE
7309 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7310
c939f91b
PE
7311 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7312 clobbering (Bug#8298).
b9c7f648
PE
7313 * sysdep.c (sys_subshell): Likewise.
7314 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7315
6bd8c144
PE
7316 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7317 This should get cleaned up, so that child_setup has the
7318 same signature on all platforms.
7319
7710357c 7320 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7321 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7322
c59da222
CY
73232011-03-22 Chong Yidong <cyd@stupidchicken.com>
7324
7325 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7326 not to be necessary, and produces flickering.
7327
66b87493
GM
73282011-03-20 Glenn Morris <rgm@gnu.org>
7329
7330 * config.in: Remove file.
7331
45b6f6d5
JB
73322011-03-20 Juanma Barranquero <lekktu@gmail.com>
7333
7334 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7335 are now in src/globals.h.
7336 (syms_of_minibuf): Remove spurious & from previous change.
7337
3ec03f7e
LL
73382011-03-20 Leo <sdl.web@gmail.com>
7339
7340 * minibuf.c (completing-read-function): New variable.
7341 (completing-read-default): Rename from completing-read.
7342 (completing-read): Call completing-read-function.
7343
b14e3e21
CY
73442011-03-19 Juanma Barranquero <lekktu@gmail.com>
7345
7346 * xfaces.c (Fx_load_color_file):
7347 Read color file from absolute filename (bug#8250).
7348
f2b726e6
JB
73492011-03-19 Juanma Barranquero <lekktu@gmail.com>
7350
7351 * makefile.w32-in: Update dependencies.
7352
09f6ff02
EZ
73532011-03-17 Eli Zaretskii <eliz@gnu.org>
7354
7355 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7356
29a6015a
PE
73572011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7358
a3a6c54e
PE
7359 Fix more problems found by GCC 4.5.2's static checks.
7360
b766f867
PE
7361 * process.c (make_serial_process_unwind, send_process_trap):
7362 (sigchld_handler): Now static.
7363
be02381c
PE
7364 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7365 That way, the code declares only the vars that it needs.
7366 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7367 * s/cygwin.h (PTY_ITERATION): Likewise.
7368 * s/darwin.h (PTY_ITERATION): Likewise.
7369 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7370
57048744
PE
7371 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7372 * process.c (allocate_pty): Don't declare stb unless it's needed.
7373
7914961c 7374 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7375 (CONSTANTLIM): Remove; unused.
7376 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7377 Define only if needed.
7914961c 7378
b3967b18
PE
7379 * unexelf.c (unexec): Name an expression,
7380 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7381 Use a different way to cause a compilation error if anyone uses
7382 n rather than nn, a way that does not involve shadowing.
73366a00 7383 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7384
29a6015a
PE
7385 * deps.mk (unexalpha.o): Remove; unused.
7386
43cfc33e 7387 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7388 * unexec.h: New file.
ce701a33
PE
7389 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7390 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7391 Depend on unexec.h.
7392 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7393 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7394 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7395 Change as necessary to match prototype in unexec.h.
ce701a33 7396
01f44d5a
PE
7397 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7398 shadowing.
4f63c6bb 7399 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7400
a6670b0b
PE
7401 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7402 Rename locals to avoid shadowing.
7403
cef2010d 7404 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7405 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7406
d4d7173a
PE
7407 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7408
f08b802a
PE
7409 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7410 warning when compiling print.c.
7411
3ddb0639
PE
7412 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7413 instead of using an uninitialized var.
5ad03b97 7414 (font_sort_entities): Mark var as initialized.
3ddb0639 7415
170a2692
PE
7416 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7417
e663c700
PE
7418 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7419 pointers to constants.
89bc529a 7420 (font_parse_fcname): Remove unused vars.
7b81e2d0 7421 (font_delete_unmatched): Now static.
ea838e10 7422 (font_get_spec): Remove; unused.
13a547c6
PE
7423 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7424 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7425 Rename or move locals to avoid shadowing.
e663c700 7426
2a80c887 7427 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7428 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7429
1384fa33 7430 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7431 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7432
8b2c52e9
PE
7433 * alloc.c (mark_backtrace): Move decl from here ...
7434 * lisp.h: ... to here, so that it can be checked.
7435
475545b5 7436 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7437 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7438 (lisp_indirect_variable): Name an expression,
7439 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7440 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7441
b1349114 7442 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7443 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7444 Use const pointer when appropriate.
b1349114 7445
a2928364
PE
7446 * lisp.h (get_system_name, get_operating_system_release):
7447 Move decls here, to check interfaces.
7448 * process.c (get_operating_system_release): Move decl to lisp.h.
7449 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7450 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7451 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7452 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7453 (Fformat_time_string, Fencode_time, Finsert_char):
7454 (Ftranslate_region_internal, Fformat):
7455 Rename or remove local vars to avoid shadowing.
9710023e 7456 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7457
a415e694
PE
7458 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7459 avoid shadowing.
7460
8ef4622d
PE
7461 * lisp.h (eassert): Check that the argument compiles, even if
7462 ENABLE_CHECKING is not defined.
7463
946f9a5b
PE
7464 * data.c (Findirect_variable): Name an expression, to avoid
7465 gcc -Wbad-function-cast warning.
112396d6 7466 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7467 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7468 (Fmake_variable_buffer_local, Fmake_local_variable):
7469 Mark variables as initialized.
52746918 7470 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7471
e5aab7e7 7472 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7473 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7474 Rename locals to avoid shadowing.
dff45157
PE
7475 (mark_stack): Move local variables into the #ifdef region where
7476 they're used.
7bc26fdb
PE
7477 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7478 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7479 needed otherwise.
7480 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7481 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7482 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7483
e5aab7e7
PE
7484 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7485 avoids undefined behavior in theory.
7486
4da60324
PE
7487 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7488
88043301
PE
7489 Use functions, not macros, for up- and down-casing (Bug#8254).
7490 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7491 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7492 to use the following functions instead of these macros.
7493 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7494 EMACS_INT, since callers assume the returned value fits in int.
7495 (upcase1): Likewise, for UPCASE_TABLE.
7496 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7497 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7498 the race-condition problem in the old DOWNCASE.
88043301 7499
19ed5445
PE
7500 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7501 Rename locals to avoid shadowing.
7502 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7503 (regex_compile, re_search_2, re_match_2_internal):
7504 Remove unused local vars.
952db0d7
PE
7505 (FREE_VAR): Rewrite so as not to use empty "else",
7506 which gcc can warn about.
da053e48 7507 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7508 (RETALLOC_IF): Define only if needed.
7509 (WORDCHAR_P): Likewise. This one is never needed, but is used
7510 only in a comment talking about a compiler bug, so put inside
7511 the #if 0 of that comment.
7512 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7513 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7514 Remove; unused.
19ed5445 7515
1f3561e4 7516 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7517 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7518 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7519
ded6f8f7
PE
7520 * search.c (simple_search): Remove unused var.
7521
dbd37a95
PE
7522 * dired.c (compile_pattern): Move decl from here ...
7523 * lisp.h: ... to here, so that it can be checked.
7524 (struct re_registers): New forward decl.
7525
7e47afad
PE
7526 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7527
85f24f61
PE
7528 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7529 All uses changed.
7530 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7531 Rename locals to avoid shadowing.
5671df8f 7532 (Fvertical_motion): Mark locals as initialized.
85f24f61 7533
181aa2be 7534 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7535 (casify_region): Mark local as initialized.
181aa2be 7536
930d429c
PE
7537 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7538
7082eac6
PE
7539 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7540 New macros, so that the caller can use some names other than
7541 gcpro1, gcpro2, etc.
7542 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7543 of the new macros.
7544 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7545 argument, for consistency with GCPRO2_VAR, etc: it is now the
7546 prefix of the variable, not the variable itself. All uses
7547 changed.
38b2c076
PE
7548 * dired.c (directory_files_internal, file_name_completion):
7549 Rename locals to avoid shadowing.
7550
15206ed9
PE
7551 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7552 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7553 dired.c's scmp function, had undefined behavior.
7554 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7555 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7556 * buffer.h: ... to here, because these macros use current_buffer,
7557 and the new implementation with inline functions needs to have
7558 current_buffer in scope now, rather than later when the macros
7559 are used.
7560 (downcase, upcase1): New static inline functions.
7561 (DOWNCASE, UPCASE1): Reimplement using these functions.
7562 This avoids undefined behavior in expressions like
7563 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7564 from race conditions in accessing the global variables
7565 case_temp1 and case_temp2.
7566 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7567 * lisp.h (case_temp1, case_temp2): Remove their decls.
7568 * character.h (ASCII_CHAR_P): Move from here ...
7569 * lisp.h: ... to here, so that the inline functions mentioned
7570 above can use them.
7571
4a6bea26
PE
7572 * dired.c (directory_files_internal_unwind): Now static.
7573
f14b7e14
PE
7574 * fileio.c (file_name_as_directory, directory_file_name):
7575 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7576 Now static.
2893f146
PE
7577 (file_name_as_directory): Use const pointers when appropriate.
7578 (Fexpand_file_name): Likewise. In particular, newdir might
7579 point at constant storage, so make it a const pointer.
fd4ead52 7580 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7581 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7582 signedness issues.
f839df0c
PE
7583 (Fset_file_times, Finsert_file_contents, auto_save_error):
7584 Rename locals to avoid shadowing.
f14b7e14 7585
5716756e 7586 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7587 (Ftry_completion, Fall_completions): Rename or remove locals
7588 to avoid shadowing.
5716756e 7589
b4c3046a
PE
7590 * marker.c (bytepos_to_charpos): Remove; unused.
7591
b45db522
PE
7592 * lisp.h (verify_bytepos, count_markers): New decls,
7593 so that gcc does not warn that these functions aren't declared.
7594
85876d07
PE
7595 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7596 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7597 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7598 (copy_text): Remove unused local var.
85876d07 7599
03d78a21 7600 * filelock.c (within_one_second): Now static.
b3dd38ab 7601 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7602
5df8f01b
PE
7603 * buffer.c (fix_overlays_before): Mark locals as initialized.
7604 (fix_start_end_in_overlays): Likewise. This function should be
7605 simplified by using pointers-to-pointers, but that's a different
7606 matter.
b1d876f1 7607 (switch_to_buffer_1): Now static.
8f54f30a
PE
7608 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7609 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7610
a70072c9 7611 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7612 Fix pointer signedness issue.
edced198
PE
7613 (sys_subshell): Mark local as volatile if checking for lint,
7614 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7615 (MAXPATHLEN): Define only if needed.
a70072c9 7616
a0977c44
PE
7617 * process.c (serial_open, serial_configure): Move decls from here ...
7618 * systty.h: ... to here, so that they can be checked.
7619
a884fdcc
PE
7620 * fns.c (get_random, seed_random): Move extern decls from here ...
7621 * lisp.h: ... to here, so that they can be checked.
7622
604efe86 7623 * sysdep.c (reset_io): Now static.
b8950c94 7624 (wait_for_termination_signal): Remove; unused.
604efe86 7625
38fc62d9
PE
7626 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7627 (copy_keymap_item, append_key, push_text_char_description):
7628 Now static.
1004a21a 7629 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7630 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7631 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7632 (describe_map_tree):
7633 Rename locals to avoid shadowing.
38fc62d9 7634
2f2650da
PE
7635 * keyboard.c: Declare functions static if they are not used elsewhere.
7636 (echo_char, echo_dash, cmd_error, top_level_2):
7637 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7638 (read_char, kbd_buffer_get_event, make_lispy_position):
7639 (make_lispy_event, make_lispy_movement, apply_modifiers):
7640 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7641 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7642 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7643 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7644 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7645
a053e86c 7646 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7647 (mark_kboards): Move decl here ...
7648 * alloc.c (mark_kboards): ... from here.
a053e86c 7649
4752793e
PE
7650 * lisp.h (force_auto_save_soon): New decl.
7651
74f10ca7 7652 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7653 (DEFINE_DUMMY_FUNCTION): New macro.
7654 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7655 Use it.
c03cd23f
PE
7656 (main): Add casts to avoid warnings
7657 if GCC considers string literals to be constants.
74f10ca7 7658
022e70d4
PE
7659 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7660
59d6fe83
PE
7661 * dbusbind.c: Pointer signedness fixes.
7662 (xd_signature, xd_append_arg, xd_initialize):
7663 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7664 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7665 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7666 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7667
78320123
PE
7668 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7669 if GCC considers string literals to be constants.
49cebcca 7670 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7671
35ac2a97
SM
76722011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7673
fb103ca9
SM
7674 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7675 (print_preprocess, print_object): New macro to fix last change.
7676
35ac2a97
SM
7677 * print.c (print_preprocess): Don't forget font objects.
7678
62973b41
JB
76792011-03-16 Juanma Barranquero <lekktu@gmail.com>
7680
7681 * emacs.c (USAGE3): Doc fixes.
7682
0e48bb22
AS
76832011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7684
7685 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7686 structure.
7687
7684e57b
JB
76882011-03-14 Juanma Barranquero <lekktu@gmail.com>
7689
7690 * lisp.h (VWindow_system, Qfile_name_history):
7691 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7692 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7693 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7694
7695 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7696 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7697
7698 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7699 * w32console.c (detect_input_pending, read_input_pending)
7700 (encode_terminal_code):
7701 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7702 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7703 (w32_system_caret_y, Qfile_name_history):
7704 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7705 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7706 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7707 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7708 * w32proc.c (Qlocal, report_file_error):
7709 * w32term.c (Vwindow_system, updating_frame):
7710 * w32uniscribe.c (initialized, uniscribe_font_driver):
7711 Remove unneeded extern declarations.
7712
2aa46d6c
CY
77132011-03-14 Chong Yidong <cyd@stupidchicken.com>
7714
c96bbc66 7715 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7716
cffc6f3b
CY
77172011-03-13 Chong Yidong <cyd@stupidchicken.com>
7718
7719 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7720 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7721 These macros can no longer be used for assignment.
7722
44f230aa
SM
7723 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7724 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7725 (record_buffer_markers, fetch_buffer_markers): New functions for
7726 recording and fetching special buffer markers.
7727 (set_buffer_internal_1, set_buffer_temp): Use them.
7728
7729 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7730
7731 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7732
7733 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7734 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7735
7736 * xdisp.c (hscroll_window_tree):
7737 (reconsider_clip_changes): Use PT instead of BUF_PT.
7738
d251f04b
EZ
77392011-03-13 Eli Zaretskii <eliz@gnu.org>
7740
7741 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7742 $(EMACS_ROOT)/lib/intprops.h.
7743
f0c77cd1
PE
77442011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7745
3eca4629
PE
7746 Fix more problems found by GCC 4.5.2's static checks.
7747
7c86ee98
PE
7748 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7749 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7750 (xg_free_frame_widgets): Make it clear that a local variable is
7751 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7752 (gdk_window_get_screen): Make it clear that this macro is needed
7753 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7754 (int_gtk_range_get_value): New function, which avoids a diagnostic
7755 from gcc -Wbad-function-cast.
7756 (xg_set_toolkit_scroll_bar_thumb): Use it.
7757 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7758 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7759 (get_utf8_string, xg_get_file_with_chooser):
7760 Rename locals to avoid shadowing.
7761 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7762
41729b81
PE
7763 * xgselect.c (xg_select): Remove unused var.
7764
f0c77cd1
PE
7765 * image.c (four_corners_best): Mark locals as initialized.
7766 (gif_load): Initialize transparent_p to zero (Bug#8238).
7767 Mark another local as initialized.
ec6cf4c6 7768 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7769
ce0ad53d 7770 * image.c (clear_image_cache): Now static.
d5d5a617 7771 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7772 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7773 (x_edge_detection): Remove unnecessary cast that
7774 gcc -Wbad-function-cast diagnoses.
2037898d 7775 (gif_load): Fix pointer signedness.
6ae141d6
PE
7776 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7777 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7778
33383987 77792011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7780
d32df629
PE
7781 Improve quality of tests for time stamp overflow.
7782 For example, without this patch (encode-time 0 0 0 1 1
7783 1152921504606846976) returns the obviously-bogus value (-948597
7784 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7785 reports time overflow. See
7786 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7787 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7788 * editfns.c: Include limits.h and intprops.h.
7789 (TIME_T_MIN, TIME_T_MAX): New macros.
7790 (time_overflow): Move earlier, to before first use.
7791 (hi_time, lo_time): New functions, for an accurate test for
7792 out-of-range times.
7793 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7794 (Fget_internal_run_time): Don't assume time_t fits in int.
7795 (make_time): Use list2 instead of Fcons twice.
7796 (Fdecode_time): More accurate test for out-of-range times.
7797 (check_tm_member): New function.
7798 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7799 (lisp_time_argument): Don't rely on undefined left-shift and
7800 right-shift behavior when checking for time stamp overflow.
8be6f318 7801
fe31d94c
PE
7802 * editfns.c (time_overflow): New function, refactoring common code.
7803 (Fformat_time_string, Fdecode_time, Fencode_time):
7804 (Fcurrent_time_string): Use it.
7805
8be6f318
PE
7806 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7807 * dired.c (make_time): Move to ...
7808 * editfns.c (make_time): ... here.
7809 * systime.h: Note the move.
7810
09d9db2c 78112011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7812
126bc0dc
YM
7813 * fringe.c (update_window_fringes): Remove unused variables.
7814
c47cbdfd
YM
7815 * unexmacosx.c (copy_data_segment): Also copy __got section.
7816 (Bug#8223)
7817
7ac80be9
EZ
78182011-03-12 Eli Zaretskii <eliz@gnu.org>
7819
c96bbc66 7820 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7821 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7822 Constify `char *' arguments and their references according to
7823 prototypes in tparam.h.
7824
ecb0f94d 7825 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7826
7ac80be9
EZ
7827 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7828 Adapt all references accordingly.
7829
7830 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7831
ef1fd07e
TT
78322011-03-11 Tom Tromey <tromey@redhat.com>
7833
7834 * buffer.c (syms_of_buffer): Remove obsolete comment.
7835
7ef4b50c
EZ
78362011-03-11 Eli Zaretskii <eliz@gnu.org>
7837
7838 * termhooks.h (encode_terminal_code): Declare prototype.
7839
7840 * msdos.c (encode_terminal_code): Don't declare prototype.
7841
7842 * term.c (encode_terminal_code): Now external again, used by
7843 w32console.c and msdos.c.
7844
44f230aa
SM
7845 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7846 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7847
4b1ec863 78482011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7849
1714f52b 7850 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7851
4b1ec863
PE
7852 * fringe.c (update_window_fringes): Mark locals as initialized
7853 (Bug#8227).
7854 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7855
524c7aa6
PE
7856 * alloc.c (mark_fringe_data): Move decl from here ...
7857 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7858 to check its interface.
7859 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7860
a5c0af81 7861 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7862 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7863 (fontset_font): Mark local as initialized.
a9a06e0b 7864 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7865
b4716021
PE
7866 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7867
811e9bac 7868 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7869 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7870 (x_own_selection, Fx_disown_selection_internal): Rename locals
7871 to avoid shadowing.
7872 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7873
7e3ab302
PE
7874 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7875 so that the caller can use some name other than gcpro1.
7876 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7877 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7878 (Fx_backspace_delete_keys_p):
7879 Use them to avoid shadowing, and rename vars to avoid shadowing.
7880 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7881 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7882 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7883 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7884 Remove unused locals.
7e3ab302
PE
7885 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7886 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7887 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7888 macros.
f78faa98 7889
e2b13473
PE
7890 * xterm.h (x_mouse_leave): New decl.
7891
77f23912
PE
7892 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7893 Remove unused functions.
cdf4ba58
PE
7894 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7895 (x_calc_absolute_position): Now static.
7411c686 7896 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7897 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7898 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7899 unless they are used.
38d0b34a
PE
7900 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7901 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7902 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7903 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7904 (x_error_catcher, x_connection_closed, x_error_handler):
7905 (x_error_quitter, xembed_send_message, x_iconify_frame):
7906 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7907 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7908 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7909
44f230aa
SM
7910 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7911 Rename or move locals to avoid shadowing.
6b463e58 7912 (tty_defined_color, merge_face_heights): Now static.
5967d051 7913 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7914 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7915 does not deduce is never used uninitialized.
73719eba
PE
7916 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7917 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7918
426994c3 7919 * terminal.c (store_terminal_param): Now static.
5489860b 7920
032f1620 7921 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7922 (set_frame_menubar): Remove unused local.
d4323972 7923 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7924 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7925 since they might point to immutable storage.
281585b0
PE
7926 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7927 since it's unused otherwise.
032f1620 7928
367c19e5 7929 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7930 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7931 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7932 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7933 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7934 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7935 does not deduce are never used uninitialized.
70739cbe 7936
07b48fa9
PE
7937 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7938
8868a238 7939 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7940 * window.c (window_loop, size_window):
7941 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7942
7e5cf297 7943 * window.c (display_buffer): Now static.
d6550a9f
PE
7944 (size_window): Mark variables that gcc -Wuninitialized
7945 does not deduce are never used uninitialized.
a586633d
PE
7946 * window.h (check_all_windows): New decl, to forestall
7947 gcc -Wmissing-prototypes diagnostic.
5b555da1 7948 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7949
f6095868
PE
7950 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7951 shadowing.
7952 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7953 Include <limits.h>.
7954 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7955 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7956 (load_charset_map): Mark variables that gcc -Wuninitialized
7957 does not deduce are never used uninitialized.
53df7c11 7958 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7959
f38b440c
PE
7960 * coding.c (coding_set_source, coding_set_destination):
7961 Use "else { /* comment */ }" rather than "else /* comment */;"
7962 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7963 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7964 a block, when the outer 'i' will do.
7965 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7966 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7967 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7968 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7969 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7970 Rename locals to avoid shadowing.
7971 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7972 * coding.c (emacs_mule_char, encode_invocation_designation):
7973 Now static, since they're not used elsewhere.
413bb2db 7974 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7975 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7976 (decode_coding_emacs_mule): Mark variables that gcc
7977 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7978 (detect_coding_iso_2022): Initialize a local variable that might
7979 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7980 this initialization is needed. (Bug#8211)
5f58e762
PE
7981 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7982 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7983 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7984 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7985 Remove unused macros.
f38b440c 7986
232b38b9 7987 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7988 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7989 * character.c (string_count_byte8): Likewise.
232b38b9 7990
fb90da1b
PE
7991 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7992 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7993
fb93dbc2
PE
7994 * chartab.c (copy_sub_char_table): Now static, since it's not used
7995 elsewhere.
5c156ace
PE
7996 (sub_char_table_ref_and_range, char_table_ref_and_range):
7997 Rename locals to avoid shadowing.
bbcd0949 7998 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7999
7d3b3862 8000 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8001 (BIDI_BOB): Remove unused macro.
7d3b3862 8002
6be7d3da
PE
8003 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8004 deduce are never used uninitialized.
c2ed9c8b 8005 * term.c (encode_terminal_code): Likewise.
6be7d3da 8006
75f8807f 8007 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8008
50938595
PE
8009 * tparam.h: New file.
8010 * term.c, tparam.h: Include it.
8011 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8012 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8013 Move these decls to tparam.h, and make them agree with what
8014 is actually in tparam.c. The previous trick of using incompatible
8015 decls in different modules does not conform to the C standard.
8016 All callers of tparam changed to use tparam's actual API.
8017 * tparam.c (tparam1, tparam, tgoto):
8018 Use const pointers where appropriate.
8019
fbceeba2
PE
8020 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8021 * cm.h (struct cm): Likewise.
8022 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8023 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8024 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8025 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8026 (turn_on_face, init_tty): Likewise.
8027 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8028
7f3f1250
PE
8029 * term.c (term_mouse_position): Rename local to avoid shadowing.
8030
e6ca6543
PE
8031 * alloc.c (mark_ttys): Move decl from here ...
8032 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8033
c40f8d15
AS
80342011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8035
8036 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8037
cfe0661d
JB
80382011-03-09 Juanma Barranquero <lekktu@gmail.com>
8039
8040 * search.c (compile_pattern_1): Remove argument regp, unused since
8041 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8042 (compile_pattern): Don't pass it.
8043
0afb4571
J
80442011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8045
8046 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8047 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8048 for ! HAVE_GTK3.
8049 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8050
8051 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8052
8053 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8054 gdk_window_get_screen, gdk_window_get_geometry,
8055 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8056 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8057 (xg_get_pixbuf_from_pixmap): New function.
8058 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8059 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8060 Call xg_get_pixbuf_from_pixmap instead of
8061 gdk_pixbuf_get_from_drawable.
8062 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8063 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8064 (xg_check_special_colors): Use GtkStyleContext and its functions
8065 for HAVE_GTK3.
8066 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8067 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8068 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8069 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8070 Call gtk_widget_get_preferred_size.
0afb4571
J
8071 (xg_frame_resized): gdk_window_get_geometry only takes 5
8072 parameters.
44f230aa
SM
8073 (xg_win_to_widget, xg_event_is_for_menubar):
8074 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8075 (xg_set_widget_bg): New function.
8076 (delete_cb): New function.
895009e1 8077 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8078 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8079 (xg_set_background_color): Call xg_set_widget_bg.
8080 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8081 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8082 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8083 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8084 if ! HAVE_GTK3.
8085 (update_frame_tool_bar): Call gtk_widget_hide.
8086 (xg_initialize): Use GDK_KEY_g.
8087
8088 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8089 if ! HAVE_GTK3
8090 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8091
8092 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8093 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8094 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8095
1c2cc4ef
JB
80962011-03-08 Juanma Barranquero <lekktu@gmail.com>
8097
8098 * w32xfns.c (select_palette): Check success of RealizePalette against
8099 GDI_ERROR, not zero.
8100
33383987 8101See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8102
8103;; Local Variables:
8104;; coding: utf-8
aac0c6e3
MR
8105;; End:
8106
33383987 8107 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8108
8109 This file is part of GNU Emacs.
8110
8111 GNU Emacs is free software: you can redistribute it and/or modify
8112 it under the terms of the GNU General Public License as published by
8113 the Free Software Foundation, either version 3 of the License, or
8114 (at your option) any later version.
8115
8116 GNU Emacs is distributed in the hope that it will be useful,
8117 but WITHOUT ANY WARRANTY; without even the implied warranty of
8118 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8119 GNU General Public License for more details.
8120
8121 You should have received a copy of the GNU General Public License
8122 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.