* process.c (Fsignal_process): Simplify by avoiding a goto.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d44287d4 12011-10-11 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2
977b0e45 3 Fix integer width and related issues.
eb106a49 4 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
5 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
6 (string_bytes, check_sblock, allocate_string_data):
7 (compact_small_strings, Fmake_bool_vector, make_string)
8 (make_unibyte_string, make_multibyte_string)
9 (make_string_from_bytes, make_specified_string)
10 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
11 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
12 (mark_vectorlike):
13 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
14 (allocate_pseudovector):
15 Use int, not EMACS_INT, where int is wide enough.
16 (inhibit_garbage_collection, Fgarbage_collect):
17 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
18 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
19 int might not be wide enough.
20 (bidi_cache_search, bidi_cache_find, bidi_init_it)
21 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
22 (bidi_at_paragraph_end, bidi_find_paragraph_start)
23 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
24 (bidi_level_of_next_char, bidi_move_to_visually_next):
25 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
26 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
27 (Fkill_buffer, Fset_buffer_major_mode)
28 (advance_to_char_boundary, Fbuffer_swap_text)
29 (Fset_buffer_multibyte, overlays_at, overlays_in)
30 (overlay_touches_p, struct sortvec, record_overlay_string)
31 (overlay_strings, recenter_overlay_lists)
32 (adjust_overlays_for_insert, adjust_overlays_for_delete)
33 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
34 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
35 (Foverlay_recenter, last_overlay_modification_hooks_used)
36 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
37 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
38 (validate_region): Omit unnecessary test for b <= e,
39 since that's guaranteed by the previous test.
d311d28c
PE
40 (adjust_overlays_for_delete): Avoid pos + length overflow.
41 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
42 (report_overlay_modification):
43 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
44 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
45 Omit pointer cast, which isn't needed anyway, and doesn't work
46 after the EMACS_INT -> ptrdiff_t change.
79cce3f2
PE
47 (Fmove_overlay): Delete an evaporating overlay
48 if it becomes empty after its bounds are adjusted to fit within
49 its buffer. Without this fix, in a nonempty buffer (let ((o
50 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
51 yields an empty overlay that has the evaporate property, which is
52 not supposed to happen. (Bug#9642)
d311d28c
PE
53 * buffer.h: Adjust decls to match defn changes elsewhere.
54 (struct buffer_text, struct buffer):
55 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
56 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
57 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
58 not int, to avoid needless 32-bit limit on 64-bit hosts.
59 (exec_byte_code): Use tighter memory-full test, one that checks
60 for alloca overflow. Don't compute the address of the object just
61 before an array, as that's not portable. Use EMACS_INT, not
62 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
63 * callint.c (Fcall_interactively):
64 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
65 * callproc.c (call_process_kill, Fcall_process):
66 Don't assume pid_t fits into an Emacs fixnum.
67 (call_process_cleanup, Fcall_process, child_setup):
68 Don't assume pid_t fits into int.
69 (call_process_cleanup, Fcall_process, delete_temp_file)
70 (Fcall_process_region):
71 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
72 (Fcall_process): Simplify handling of volatile integers.
73 Use int, not EMACS_INT, where int will do.
74 * casefiddle.c (casify_object, casify_region, operate_on_word)
75 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
76 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
77 (casify_object): Avoid integer overflow when overallocating buffer.
78 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 79 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
80 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
81 * category.h (CATEGORYP): Don't assume arg is nonnegative.
82 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
83 integers are now checked earlier. All uses replaced with XINT.
84 (ccl_driver):
85 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
86 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
87 (ccl_driver, Fregister_code_conversion_map):
88 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
89 (resolve_symbol_ccl_program): Check that vector header is in range.
90 Always copy the vector, so that we can check its contents reliably
91 now rather than having to recheck each instruction as it's being
92 executed. Check that vector words fit in 'int'.
93 (ccl_get_compiled_code, Fregister_ccl_program)
94 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
95 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
96 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
97 contents are in range.
98 (Fccl_execute_on_string): Check that status is in range.
99 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
100 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
101 Accept and return EMACS_INT, not int, because callers can pass values
102 out of 'int' range.
103 (c_string_width, strwidth, lisp_string_width, chars_in_text)
104 (multibyte_chars_in_text, parse_str_as_multibyte)
105 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
106 (str_as_unibyte, str_to_unibyte, string_count_byte8)
107 (string_escape_byte8, Fget_byte):
108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
109 (Funibyte_string): Use CHECK_CHARACTER, not CHECK_NATNUM, to
110 avoid mishandling large integers.
111 * character.h: Adjust decls to match defn changes elsewhere.
112 * charset.c (load_charset_map_from_file, find_charsets_in_text)
113 (Ffind_charset_region):
114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
115 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
116 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 117 Don't assume fixnum fits in int.
d311d28c
PE
118 (load_charset_map_from_vector, Fmap_charset_chars):
119 Remove now-unnecessary CHECK_NATNUMs.
120 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
121 Don't rely on undefined behavior with signed left shift overflow.
122 Don't assume unsigned int fits into fixnum, or that fixnum fits
123 into unsigned int. Don't require max_code to be a valid fixnum;
124 that's not true for gb10830 4-byte on a 32-bit host. Allow
125 invalid_code to be a cons, for the same reason. Require code_offset
126 to be a character. Avoid int overflow if max_char is close
127 to INT_MAX.
128 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
129 this is intended anyway and avoids some undefined behavior.
130 (load_charset_map): Pass unsigned, not int, as 2nd arg of
131 INDEX_TO_CODE_POINT, as that's what it expects.
132 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
133 * charset.h (DECODE_CHAR): Return int, not unsigned;
134 this is what was intended anyway, and it avoids undefined behavior.
135 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
136 integer-overflow issues.
137 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
138 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
139 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
140 * chartab.c (Fmake_char_table, Fset_char_table_range)
141 (uniprop_get_decoder, uniprop_get_encoder):
142 Don't assume fixnum fits in int.
143 * cmds.c (move_point): New function, that does the gist of
144 Fforward_char and Fbackward_char, but does so while checking
145 for integer overflow more accurately.
c96e5d6a 146 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
147 (Fforward_line, Fend_of_line, internal_self_insert)
148 (internal_self_insert):
149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
150 Fix a FIXME, by checking for integer overflow when calculating
151 target_clm and actual_clm.
152 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
153 (ASSURE_DESTINATION, coding_alloc_by_realloc)
154 (coding_alloc_by_making_gap, alloc_destination)
155 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
156 (encode_coding_utf_16, detect_coding_emacs_mule)
157 (decode_coding_emacs_mule, encode_coding_emacs_mule)
158 (detect_coding_iso_2022, decode_coding_iso_2022)
159 (encode_invocation_designation, encode_designation_at_bol)
160 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
161 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
162 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
163 (encode_coding_ccl, encode_coding_raw_text)
164 (detect_coding_charset, decode_coding_charset)
165 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
166 (produce_composition, produce_charset, produce_annotation)
167 (decode_coding, handle_composition_annotation)
168 (handle_charset_annotation, consume_chars, decode_coding_gap)
169 (decode_coding_object, encode_coding_object, detect_coding_system)
170 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
171 (code_convert_region, code_convert_string)
172 (Fdefine_coding_system_internal):
173 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
174 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
175 (Fdefine_coding_system_internal):
176 Don't assume fixnums fit in int.
177 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 178 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
179 (Funencodable_char_position, Fcheck_coding_systems_region)
180 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 182 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 183 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 184 Don't access memory outside of the args array.
d311d28c 185 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
186 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
187 result of ENCODE_CHAR.
d311d28c
PE
188 * coding.h: Adjust decls to match defn changes elsewhere.
189 (struct coding_system):
190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
191 * composite.c (get_composition_id, find_composition)
192 (run_composition_function, update_compositions)
193 (compose_text, composition_gstring_put_cache)
194 (composition_gstring_p, composition_gstring_width)
195 (fill_gstring_header, fill_gstring_body, autocmp_chars)
196 (composition_compute_stop_pos, composition_reseat_it)
197 (composition_update_it, struct position_record)
198 (find_automatic_composition, composition_adjust_point)
199 (Fcomposition_get_gstring, Ffind_composition_internal):
200 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
201 (update_compositions):
202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
203 * composite.h: Adjust decls to match defn changes elsewhere.
204 (struct composition):
205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
206 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
207 Do not attempt to compute the address of the object just before a
208 buffer; this is not portable.
209 (Faref, Faset):
210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
211 (Faset): Use int, not EMACS_INT, where int is wide enough.
212 (Fstring_to_number): Don't assume fixnums fit in int.
213 (Frem): Don't assume arg is nonnegative.
214 * dbusbind.c (xd_append_arg): Check for integers out of range.
215 (Fdbus_call_method): Don't overflow the timeout int.
216 * dired.c (directory_files_internal, file_name_completion, scmp)
217 (file_name_completion_stat):
218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
219 (file_name_completion): Don't overflow matchcount.
220 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
221 * dispextern.h: Adjust decls to match defn changes elsewhere.
222 (struct text_pos, struct glyph, struct bidi_saved_info)
223 (struct bidi_string_data, struct bidi_it, struct composition_it)
224 (struct it):
225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
226 (struct display_pos, struct composition_it, struct it):
227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
228 * dispnew.c (increment_matrix_positions)
229 (increment_row_positions, mode_line_string)
230 (marginal_area_string):
231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 232 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
234 (duration_to_sec_usec): New function, to check for overflow better.
235 (Fsleep_for, sit_for): Use it.
236 * doc.c (get_doc_string, store_function_docstring):
237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
238 (get_doc_string, Fsnarf_documentation):
239 Use int, not EMACS_INT, where int is wide enough.
240 (get_doc_string):
241 Use SAFE_ALLOCA, not alloca.
242 Check for overflow when converting EMACS_INT to off_t.
243 * doprnt.c (doprnt):
244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
245 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
246 Don't assume uid_t fits into fixnum.
247 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
248 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
249 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
250 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
251 (general_insert_function)
252 (Finsert_char, make_buffer_string, make_buffer_string_both)
253 (update_buffer_properties, Fbuffer_substring)
254 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
255 (Fsubst_char_in_region, check_translation)
256 (Ftranslate_region_internal, save_restriction_restore, Fformat)
257 (transpose_markers, Ftranspose_regions):
258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
259 (clip_to_bounds): Move to lisp.h as an inline function).
260 (Fconstrain_to_field): Don't assume integers are nonnegative.
261 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
262 (Fsubst_char_in_region, Fsave_restriction):
263 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
264 (Femacs_pid): Don't assume pid_t fits into fixnum.
265 (lo_time): Use int, not EMACS_INT, when int suffices.
266 (lisp_time_argument): Check for usec out of range.
267 (Fencode_time): Don't assume fixnum fits in int.
268 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
269 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
270 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
271 (init_cmdargs, Fdump_emacs):
272 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
273 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
274 the bottom (typically) 32 bits of the fixnum.
275 * eval.c (specpdl_size, call_debugger):
276 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
277 (when_entered_debugger, Fbacktrace_debug):
278 Don't assume fixnum can fit in int.
279 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
280 the object just before a buffer; this is not portable.
281 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
282 (grow_specpdl, unbind_to):
283 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
284 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
285 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 286 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
287 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
288 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
289 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
290 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
291 (a_write, e_write):
292 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
293 (Fcopy_file, non_regular_nbytes, read_non_regular)
294 (Finsert_file_contents):
295 Use int, not EMACS_INT, where int is wide enough.
296 (READ_BUF_SIZE): Verify that it fits in int.
297 (Finsert_file_contents): Check that counts are in proper range,
298 rather than assuming fixnums fit into ptrdiff_t etc.
299 Don't assume fixnums fit into int.
125b3835 300 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
301 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
302 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
303 (string_char_to_byte, string_byte_to_char)
304 (string_make_multibyte, string_to_multibyte)
305 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
306 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
307 (substring_both, Fdelete, internal_equal, Ffillarray)
308 (Fclear_string, mapcar1)
309 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
310 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
311 (larger_vector, make_hash_table, maybe_resize_hash_table)
312 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
313 (Fmaphash, secure_hash):
314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
315 (concat): Check for string index and length overflow.
316 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
317 (Frequire):
318 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
319 (larger_vector): New API (vec, incr_min, size_max) replaces old
320 one (vec, new_size, init). This catches size overflow.
321 INIT was removed because it was always Qnil.
322 All callers changed.
323 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
324 the upper bound on a hash table index size.
325 (make_hash_table, maybe_resize_hash_table): Use it.
326 (secure_hash): Computer start_byte and end_byte only after
327 they're known to be in ptrdiff_t range.
328 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
329 (Ffont_get_glyphs, Ffont_at):
330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
331 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
332 (Flist_fonts, Fopen_font):
333 Don't assume fixnum can fit in int.
334 (check_gstring): Don't assume index can fit in int.
335 (font_match_p): Check that fixnum is a character, not a nonnegative
336 fixnum, since the later code needs to stuff it into an int.
337 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
338 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
339 conversion overflow issues.
340 (Fopen_font): Check for integer out of range.
341 (Ffont_get_glyphs): Don't assume index can fit in int.
342 * font.h: Adjust decls to match defn changes elsewhere.
343 * fontset.c (reorder_font_vector): Redo score calculation to avoid
344 integer overflow.
345 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
346 printmax_t, where ptrdiff_t is wide enough.
347 (Finternal_char_font):
348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
349 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
350 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
351 (Fset_frame_position, x_set_frame_parameters)
352 (x_set_line_spacing, x_set_border_width)
353 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
354 Check that fixnums are in proper range for system types.
355 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
356 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
357 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
358 Use SAFE_ALLOCA_LISP, not alloca.
359 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
360 intptr_t is wide enough.
361 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
362 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
363 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
364 Check for fixnum out of range.
365 * ftfont.c (ftfont_list): Don't assume index fits in int.
366 Check that fixnums are in proper range for system types.
367 (ftfont_shape_by_flt):
368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
369 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
371 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
372 Check that fixnums are in proper range for system types.
373 * gnutls.h: Adjust decls to match defn changes elsewhere.
374 * gtkutil.c (xg_dialog_run):
375 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
376 (update_frame_tool_bar):
377 Check that fixnums are in proper range for system types.
378 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 379 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
380 * indent.c (last_known_column, last_known_column_point):
381 (current_column_bol_cache):
382 (skip_invisible, current_column, check_display_width):
383 (check_display_width, scan_for_column, current_column_1)
384 (Findent_to, Fcurrent_indentation, position_indentation)
385 (indented_beyond_p, Fmove_to_column, compute_motion):
386 (Fcompute_motion, Fvertical_motion):
387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
388 (last_known_column_modified): Use EMACS_INT, not int.
389 (check_display_width):
390 (Fcompute_motion):
391 Check that fixnums and floats are in proper range for system types.
392 (compute_motion): Don't assume index or fixnum fits in int.
393 (compute_motion, Fcompute_motion):
394 Use int, not EMACS_INT, when it is wide enough.
395 (vmotion): Omit local var start_hpos that is always 0; that way
396 we don't need to worry about overflow in expressions involving it.
397 * indent.h: Adjust decls to match defn changes elsewhere.
398 (struct position):
399 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
400 Use int, not EMACS_INT, where int is wide enough.
401 Remove unused members ovstring_chars_done and tab_offset;
402 all uses removed.
403 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
404 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
405 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
406 (make_gap, copy_text, insert, insert_and_inherit)
407 (insert_before_markers, insert_before_markers_and_inherit)
408 (insert_1, count_combining_before, count_combining_after)
409 (insert_1_both, insert_from_string)
410 (insert_from_string_before_markers, insert_from_string_1)
411 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
412 (adjust_after_replace, adjust_after_insert, replace_range)
413 (replace_range_2, del_range, del_range_1, del_range_byte)
414 (del_range_both, del_range_2, modify_region)
415 (prepare_to_modify_buffer, signal_before_change)
416 (signal_after_change, Fcombine_after_change_execute):
417 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
418 * intervals.c (traverse_intervals, rotate_right, rotate_left)
419 (balance_an_interval, split_interval_right, split_interval_left)
420 (find_interval, next_interval, update_interval)
421 (adjust_intervals_for_insertion, delete_node, delete_interval)
422 (interval_deletion_adjustment, adjust_intervals_for_deletion)
423 (static_offset_intervals, offset_intervals)
424 (merge_interval_right, merge_interval_left, make_new_interval)
425 (graft_intervals_into_buffer, temp_set_point_both)
426 (temp_set_point, set_point, adjust_for_invis_intang)
427 (set_point_both, move_if_not_intangible, get_property_and_range)
428 (get_local_map, copy_intervals, copy_intervals_to_string)
429 (compare_string_intervals, set_intervals_multibyte_1):
430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
431 * intervals.h: Adjust decls to match defn changes elsewhere.
432 (struct interval):
433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
434 * keyboard.c (this_command_key_count, this_single_command_key_start)
435 (before_command_key_count, before_command_echo_length, echo_now)
436 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
437 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
438 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
439 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
440 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
441 (last_non_minibuf_size, last_point_position, echo_truncate)
442 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
443 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
444 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
445 (stuff_buffered_input):
446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
447 (last_auto_save, command_loop_1, read_char):
448 Use EMACS_INT, not int, to avoid integer overflow.
449 (record_char): Avoid overflow in total_keys computation.
450 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
451 * keyboard.h: Adjust decls to match defn changes elsewhere.
452 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
453 (Fkey_description, Fdescribe_vector, Flookup_key):
454 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
455 (click_position): New function, to check that positions are in range.
456 (Fcurrent_active_maps):
457 (describe_command):
458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
459 (Faccessible_keymaps, Fkey_description):
460 (preferred_sequence_p):
461 Don't assume fixnum can fit into int.
462 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
463 Check for integer overflow in size calculations.
464 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
465 avoid mishandling large integers.
466 * lisp.h: Adjust decls to match defn changes elsewhere.
467 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
468 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
469 (struct Lisp_Marker):
470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
471 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
472 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
473 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
474 All callers changed.
475 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
476 Assume the arg has valid form, since it always does.
477 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
478 unsigned integer system type.
479 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
480 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
481 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
482 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
483 (duration_to_sec_usec): New decl.
484 * lread.c (read_from_string_index, read_from_string_index_byte)
485 (read_from_string_limit, readchar, unreadchar, openp)
486 (read_internal_start, read1, oblookup):
487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
488 (Fload, readevalloop, Feval_buffer, Feval_region):
489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
490 (openp): Check for out-of-range argument to 'access'.
491 (read1): Use int, not EMACS_INT, where int is wide enough.
492 Don't assume fixnum fits into int.
1ab7b8ac
PE
493 (read_filtered_event): Use duration_to_sec_usec
494 to do proper overflow checking on durations.
d311d28c
PE
495 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
496 in size calculation.
497 (Fexecute_kbd_macro):
498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
499 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
500 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
501 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
502 (set_marker_both, set_marker_restricted_both, marker_position)
503 (marker_byte_position, Fbuffer_has_markers_at):
504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
505 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
506 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
507 It now merely ensures that the menu is large enough, without
508 necessarily growing it, as this avoids some integer overflow issues.
509 All callers changed.
510 (keymap_panes, parse_single_submenu, Fx_popup_menu):
511 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
512 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
513 Use SAFE_ALLOCA_LISP, not alloca.
514 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
515 to EMACS_INT. Check that fixnums are in proper range for system types.
516 * minibuf.c (minibuf_prompt_width, string_to_object)
517 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
518 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
520 (get_minibuffer, read_minibuf_unwind):
521 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
522 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
523 this simplifies overflow checking. All callers changed.
524 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
525 (Ftest_completion):
526 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
527 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
528 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
529 Check that fixnums are in proper range for system types.
530 (Fx_create_frame, Fx_show_tip):
531 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
532 * nsfont.m (ns_findfonts, nsfont_list_family):
533 Don't assume fixnum fits in long.
534 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
535 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
536 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
537 wide enough.
17fdb222 538 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
540 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
541 (PRINTDECLARE, PRINTPREPARE):
542 (strout, print_string):
543 (print, print_preprocess, print_check_string_charset_prop)
544 (print_object):
545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
546 (PRINTDECLARE):
547 (temp_output_buffer_setup, Fprin1_to_string, print_object):
548 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
549 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
550 (PRINTFINISH): Use SAFE_ALLOCA, not alloca.
551 (printchar, strout): Use xpalloc to catch size calculation overflow.
552 (Fexternal_debugging_output): Use CHECK_CHARACTER, not CHECK_NUMBER,
553 to avoid mishandling large integers.
554 (print_error_message): Use SAFE_ALLOCA, not alloca.
555 (print_object): Use int, not EMACS_INT, where int is wide enough.
556 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
557 (Fset_process_window_size, Fformat_network_address)
558 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 559 (sigchld_handler):
d311d28c 560 Check that fixnums are in proper range for system types.
d44287d4
PE
561 (Fsignal_process): Simplify by avoiding a goto.
562 Treat out-of-range process numbers just like invalid numbers
563 that fit into the pid_t range, and return -1.
d311d28c
PE
564 (Fformat_network_address, read_process_output, send_process)
565 (Fprocess_send_region, status_notify):
566 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
567 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
568 (wait_reading_process_output, read_process_output, exec_sentinel):
569 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
570 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
571 (Faccept_process_output): Use duration_to_sec_usec to do proper
572 overflow checking on durations.
b62b53e8
PE
573 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
574 configured --with-wide-int.
d311d28c
PE
575 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
576 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
577 * search.c (looking_at_1, string_match_1):
578 (fast_string_match, fast_c_string_match_ignore_case)
579 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
580 (scan_newline, find_before_next_newline, search_command)
581 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
582 (set_search_regs, wordify):
583 (Freplace_match):
584 (Fmatch_data):
585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
586 (string_match_1, search_buffer, set_search_regs):
587 (Fmatch_data):
588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
589 (wordify): Check for overflow in size calculation.
590 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
591 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
592 Check that fixnums are in proper range for system types.
593 * sound.c (struct sound_device)
594 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
596 (Fplay_sound_internal):
597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
598 * syntax.c (ST_COMMENT_STYLE, ST_STRING_STYLE):
599 In definitions, make it clearer that these values must be out of range
5895d7b9
PE
600 for the respective integer ranges. This fixes a bug with
601 ST_STRING_STYLE and non-ASCII characters.
d311d28c
PE
602 (struct lisp_parse_state, find_start_modiff)
603 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
604 (Fparse_partial_sexp):
605 Don't assume fixnums can fit in int.
606 (struct lisp_parse_state, find_start_pos, find_start_value)
607 (find_start_value_byte, find_start_begv)
608 (update_syntax_table, char_quoted, dec_bytepos)
609 (find_defun_start, prev_char_comend_first, back_comment):
610 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
611 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
613 (Finternal_describe_syntax_value): Check that match_lisp is a
614 character, not an integer, since the code stuffs it into int.
615 (scan_words, scan_sexps_forward):
616 Check that fixnums are in proper range for system types.
617 (Fforward_word):
618 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
619 (scan_sexps_forward):
620 Use CHARACTERP, not INTEGERP, since the value must fit into int.
621 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
622 * syntax.h: Adjust decls to match defn changes elsewhere.
623 (struct gl_state_s):
624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
625 * sysdep.c (wait_for_termination_1, wait_for_termination)
626 (interruptible_wait_for_termination, mkdir):
627 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
628 (emacs_read, emacs_write):
629 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
630 (system_process_attributes): Don't assume uid_t, gid_t, and
631 double all fit in int or even EMACS_INT.
632 * term.c (set_tty_color_mode):
633 Check that fixnums are in proper range for system types.
634 * termhooks.h (struct input_event):
635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
636 * textprop.c (validate_interval_range, interval_of)
637 (Fadd_text_properties, set_text_properties_1)
638 (Fremove_text_properties, Fremove_list_of_text_properties)
639 (Ftext_property_any, Ftext_property_not_all)
640 (copy_text_properties, text_property_list, extend_property_ranges)
641 (verify_interval_modification):
642 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
643 (Fnext_single_char_property_change)
644 (Fprevious_single_char_property_change):
645 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
646 (copy_text_properties):
647 Check for integer overflow in index calculation.
d311d28c
PE
648 * undo.c (last_boundary_position, record_point, record_insert)
649 (record_delete, record_marker_adjustment, record_change)
650 (record_property_change):
651 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
652 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
653 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
654 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
655 (Fx_hide_tip, Fx_file_dialog):
656 * w32menu.c (set_frame_menubar):
657 Use ptrdiff_t, not int, for consistency with rest of code.
658 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
659 (select_window, Fdelete_other_windows_internal)
660 (window_scroll_pixel_based, window_scroll_line_based)
661 (Frecenter, Fset_window_configuration):
662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
663 (Fset_window_hscroll, run_window_configuration_change_hook)
664 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 665 (Fscroll_other_window, Frecenter):
d311d28c
PE
666 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
667 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
668 Don't assume fixnum fits in int.
669 (Fset_window_scroll_bars):
670 Check that fixnums are in proper range for system types.
671 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
672 (string_pos, c_string_pos, number_of_chars, init_iterator)
673 (in_ellipses_for_invisible_text_p, init_from_display_pos)
674 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
675 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
676 (face_before_or_after_it_pos, handle_invisible_prop)
677 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
678 (display_prop_intangible_p, string_buffer_position_lim)
679 (string_buffer_position, handle_composition_prop, load_overlay_strings)
680 (get_overlay_strings_1, get_overlay_strings)
681 (iterate_out_of_display_property, forward_to_next_line_start)
682 (back_to_previous_visible_line_start, reseat, reseat_to_string)
683 (get_next_display_element, set_iterator_to_next)
684 (get_visually_first_element, compute_stop_pos_backwards)
685 (handle_stop_backwards, next_element_from_buffer)
686 (move_it_in_display_line_to, move_it_in_display_line)
687 (move_it_to, move_it_vertically_backward, move_it_by_lines)
688 (add_to_log, message_dolog, message_log_check_duplicate)
689 (message2, message2_nolog, message3, message3_nolog
690 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
691 (current_message_1, truncate_echo_area, truncate_message_1)
692 (set_message, set_message_1, store_mode_line_noprop)
693 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
694 (text_outside_line_unchanged_p, check_point_in_composition)
695 (reconsider_clip_changes)
696 (redisplay_internal, set_cursor_from_row, try_scrolling)
697 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
698 (redisplay_window, find_last_unchanged_at_beg_row)
699 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
700 (trailing_whitespace_p, find_row_edges, display_line)
701 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
702 (display_mode_element, store_mode_line_string)
703 (pint2str, pint2hrstr, decode_mode_spec)
704 (display_count_lines, display_string, draw_glyphs)
705 (x_produce_glyphs, x_insert_glyphs)
706 (rows_from_pos_range, mouse_face_from_buffer_pos)
707 (fast_find_string_pos, mouse_face_from_string_pos)
708 (note_mode_line_or_margin_highlight, note_mouse_highlight):
709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
710 (safe_call, init_from_display_pos, handle_fontified_prop)
711 (handle_single_display_spec, load_overlay_strings)
712 (with_echo_area_buffer, setup_echo_area_for_printing)
713 (display_echo_area, echo_area_display)
714 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
715 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
716 (redisplay_window, dump_glyph_row, display_mode_line)
717 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 718 (handle_display_spec, display_prop_string_p):
d311d28c
PE
719 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
720 (handle_single_display_spec, build_desired_tool_bar_string)
721 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
722 (get_specified_cursor_type):
723 Check that fixnums are in proper range for system types.
724 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
725 (Flookup_image_map):
726 Don't assume fixnums fit in int.
727 (compare_overlay_entries):
728 Avoid mishandling comparisons due to subtraction overflow.
729 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
730 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
731 (handle_tool_bar_click):
732 Use int, not unsigned, since we prefer signed and the signedness
733 doesn't matter here.
734 (get_next_display_element, next_element_from_display_vector):
735 Use int, not EMACS_INT, when int is wide enough.
736 (start_hourglass): Use duration_to_sec_usec to do proper
737 overflow checking on durations.
738 * xfaces.c (Fbitmap_spec_p):
739 Check that fixnums are in proper range for system types.
740 (compare_fonts_by_sort_order):
741 Avoid mishandling comparisons due to subtraction overflow.
742 (Fx_family_fonts, realize_basic_faces):
743 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
744 (Fx_family_fonts):
745 Don't assume fixnum fits in int.
746 Use SAFE_ALLOCA_LISP, not alloca.
747 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
748 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
749 (face_at_buffer_position, face_for_overlay_string)
750 (face_at_string_position):
751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
752 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
753 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
754 (Fx_show_tip):
755 Check that fixnums are in proper range for system types.
756 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
757 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
759 (Fx_change_window_property): Don't assume fixnums fit in int.
760 * xfont.c (xfont_chars_supported):
761 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
762 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
763 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
764 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
765 * xml.c (parse_region):
766 * xrdb.c (magic_file_p):
767 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
768 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
769 (x_get_local_selection, x_reply_selection_request)
770 (x_handle_selection_request, wait_for_property_change):
771 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
772 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
773 short is wide enough.
774 (x_send_client_event): Don't assume fixnum fits in int.
775 * xterm.c (x_x_to_emacs_modifiers):
776 Don't assume EMACS_INT overflows nicely into int.
777 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
778 may come from Lisp.
779 (handle_one_xevent): NATNUMP can eval its arg twice.
780 (x_connection_closed):
781 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
782 * xterm.h: Adjust decls to match defn changes elsewhere.
783 (struct scroll_bar): Use struct vectorlike_header
784 rather than rolling our own approximation.
785 (SCROLL_BAR_VEC_SIZE): Remove; not used.
786
a66cfb1c
SM
7872011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
788
789 * buffer.c (syms_of_buffer) <enable-multibyte-characters>: Don't
790 advertise functionality which we discourage or doesn't work.
791
7c5ee88e
PE
7922011-10-07 Paul Eggert <eggert@cs.ucla.edu>
793
794 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
795 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
796 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
797 this makes Emacs dump core during garbage collection on rare
798 occasions. sizeof is obviously inferior to offsetof here, so
799 stick with offsetof.
800 (GC_POINTER_ALIGNMENT): New macro.
801 (mark_memory): Omit 3rd (offset) arg; caller changed.
802 Don't assume EMACS_INT alignment is the same as pointer alignment.
803
df1bbe5b
SM
8042011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
805
806 * keyboard.c (read_key_sequence_remapped): New var.
807 (read_key_sequence): Compute remapping in the right buffer.
808 (command_loop_1): Use read_key_sequence's remapping directly.
809
51553db6
SM
8102011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
811
32c1fffd
SM
812 * dired.c (file_name_completion): Don't expand file name.
813 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
814 before checking file name handler.
815
51553db6
SM
816 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
817 they've been requested explicitly (bug#9591).
818
b6bd1599 8192011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
820
821 * keymap.c (Fsingle_key_description): Use make_specified_string
822 instead of build_string to build string from push_key_description.
823 (Bug#5193)
824
f701dc2a
PE
8252011-09-30 Paul Eggert <eggert@cs.ucla.edu>
826
4222c55d
PE
827 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
828 This fixes a Y2038 bug on 64-bit hosts.
829 * buffer.c (reset_buffer):
830 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
831 (Fclear_buffer_auto_save_failure):
832 Use 0, not -1, to represent an unset failure time, since time_t
833 might not be signed.
834
f701dc2a
PE
835 Remove dependency on glibc malloc internals.
836 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
837 Move back here from lisp.h, but with their new implementations.
838 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
839 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
840 * charset.c (charset_table_init): New static var.
841 (syms_of_charset): Use it instead of xmalloc. This removes a
842 dependency on glibc malloc internals. See Eli Zaretskii's comment in
843 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
844 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
845 Move back to alloc.c.
846 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
847 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
848
9ceebf39
JD
8492011-09-30 Jan Djärv <jan.h.d@swipnet.se>
850
851 * nsterm.m (windowDidResize): Call x_set_window_size only when
852 ns_in_resize is true. Otherwise set pixelwidth/height and
853 call change_frame_size (Bug#9628).
854
cb993c58
PE
8552011-09-30 Paul Eggert <eggert@cs.ucla.edu>
856
3930c88b
PE
857 Port --enable-checking=all to Fedora 14 x86-64.
858 * charset.c (syms_of_charset): Also account for glibc malloc's
859 internal overhead when calculating the initial malloc maximum.
860
cb993c58
PE
861 Port --enable-checking=all to Fedora 14 x86.
862 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
863 Move to lisp.h.
864 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
865 (overrun_check_realloc, overrun_check_free):
866 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
867 That way, xmalloc returns a properly-aligned pointer even if
868 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
869 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
870 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
871 into account when calculating the initial malloc maximum.
872 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
873 Move here from alloc.c, so that charset.c can use it too.
874 Properly align; the old code wasn't right for common 32-bit hosts
875 when configured with --enable-checking=all.
876 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
877 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
878
31bed486
EZ
8792011-09-29 Eli Zaretskii <eliz@gnu.org>
880
04c70788 881 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
882 use EDOM.
883
fbcaa2f3
EZ
8842011-09-28 Eli Zaretskii <eliz@gnu.org>
885
886 * xdisp.c (compute_display_string_end): If there's no display
887 string at CHARPOS, return -1.
888
889 * bidi.c (bidi_fetch_char): When compute_display_string_end
890 returns a negative value, treat the character as a normal
891 character not covered by a display string. (Bug#9624)
892
a239d4e9
JB
8932011-09-28 Juanma Barranquero <lekktu@gmail.com>
894
895 * lread.c (Fread_from_string): Fix typo in docstring.
896
88652fd5
EZ
8972011-09-27 Eli Zaretskii <eliz@gnu.org>
898
899 * xdisp.c (handle_invisible_prop): If invisible text ends on a
900 newline, reseat the iterator instead of bidi-iterating there one
901 character at a time. (Bug#9610)
32c1fffd
SM
902 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
903 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 904
ed497dd4
AS
9052011-09-27 Andreas Schwab <schwab@linux-m68k.org>
906
907 * lread.c (readevalloop): Use correct code for NBSP.
908 (read1): Likewise. (Bug#9608)
909
b2bf61aa
MA
9102011-09-25 Michael Albinus <michael.albinus@gmx.de>
911
912 * dbusbind.c (Fdbus_register_signal): When service is not
913 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
914
32bbb17c
GM
9152011-09-25 Glenn Morris <rgm@gnu.org>
916
917 * buffer.c (truncate-lines): Doc fix.
918
94e0933e
CY
9192011-09-24 Chong Yidong <cyd@stupidchicken.com>
920
921 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
922 (Fset_window_next_buffers): Doc fix.
923
cddde921
GM
9242011-09-24 Glenn Morris <rgm@gnu.org>
925
926 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
927
1260aef1
PE
9282011-09-24 Paul Eggert <eggert@cs.ucla.edu>
929
25b4bfa0
PE
930 Fix minor problems found by static checking.
931 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
932 * indent.c (Fvertical_motion): Fix == vs = typo.
933
e3cbd34b
EZ
9342011-09-24 Eli Zaretskii <eliz@gnu.org>
935
a66cfb1c
SM
936 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
937 Default value is now t. Doc fix.
6bf7006f 938
e3cbd34b 939 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 940 logic when moving up, not only when moving down. Fix the
e3cbd34b 941 confusing name and values of the it_overshoot_expected variable;
32c1fffd 942 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
943
944 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
945 CHARPOS is covered by a display string which includes newlines.
946 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
947 is covered by a display string with embedded newlines.
948
a3de0cbd
MA
9492011-09-24 Michael Albinus <michael.albinus@gmx.de>
950
951 * dbusbind.c (Fdbus_register_signal): Add match rule to
952 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
953 (Fdbus_register_method, Vdbus_registered_objects_table):
954 Fix docstring.
a3de0cbd 955
b260039d
JM
9562011-09-24 Jim Meyering <meyering@redhat.com>
957
32c1fffd 958 do not ignore write error for any output size
b260039d
JM
959 The previous change was incomplete.
960 While it makes emacs --batch detect the vast majority of stdout
961 write failures, errors were still ignored whenever the output size is
962 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
963 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
964 && echo FAIL: ignored write error
965 FAIL: ignored write error
966 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
967 && echo FAIL: ignored write error
968 FAIL: ignored write error
969 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
970
8eca8a7c
AS
9712011-09-23 Andreas Schwab <schwab@linux-m68k.org>
972
973 * emacs.c (Fkill_emacs): In noninteractive mode exit
974 non-successfully if a write error occurred on stdout. (Bug#9574)
975
3341db62
EZ
9762011-09-21 Eli Zaretskii <eliz@gnu.org>
977
978 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
979 the xassert test.
980
981 * dispextern.h (struct it): Update the comment documenting what
982 can it->OBJECT be.
983
8c203dbf
EZ
9842011-09-20 Eli Zaretskii <eliz@gnu.org>
985
986 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
987 a display string, extend search for cursor position to end of row.
988 (find_row_edges): If the row ends in a newline from a display
989 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
990 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
991 (Fcurrent_bidi_paragraph_direction): Fix search for previous
992 non-empty line. Fixes confusing cursor motion with arrow keys at
993 the beginning of a line that starts with whitespace.
8c203dbf 994
a4824228
LMI
9952011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
996
997 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
998 (bug#9493).
999
33ed493b
CY
10002011-09-18 Chong Yidong <cyd@stupidchicken.com>
1001
1002 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1003 boolean (Bug#9154).
1004
56cd55c8
EZ
10052011-09-18 Eli Zaretskii <eliz@gnu.org>
1006
1007 * xdisp.c (display_line): Record maximum and minimum buffer
1008 positions even if no glyphs were produced (e.g., by a zero-width
1009 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1010 buffer positions that will be removed from the glyph row because
1011 they don't fit.
c02dcedf
EZ
1012 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1013 column is beyond frame width: don't subtract 1 "pixel" when
1014 computing width of the stretch.
3e62b7e0
EZ
1015 (reseat_at_next_visible_line_start): Undo the change made on
1016 2011-09-17 that saved paragraph information and restored it after
1017 the call to `reseat'. (Bug#9545)
56cd55c8 1018
5ed99d36 10192011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1020
1021 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1022 and turn window cursor on if cleared (Bug#9415).
1023
5ed99d36 10242011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1025
1026 * search.c (boyer_moore): Take unibyte characters from pattern
1027 literally. (Bug#9458)
1028
9bade7b2
EZ
10292011-09-18 Eli Zaretskii <eliz@gnu.org>
1030
1031 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1032
e5e9d610
PE
10332011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1034
87e4427a
PE
1035 Fix minor problem found by static checking.
1036 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1037 initialized, to pacify gcc -Wuninitialized.
1038
e5e9d610
PE
1039 * fileio.c: Report proper errno when syscall falls.
1040 (Finsert_file_contents): Save and restore errno,
1041 so that report_file_error outputs the correct diagnostic.
1042 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1043
a1674f0b
EZ
10442011-09-18 Eli Zaretskii <eliz@gnu.org>
1045
1046 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1047
fbfb6dd4
EZ
10482011-09-17 Eli Zaretskii <eliz@gnu.org>
1049
1050 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1051 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1052
bb187662
EZ
10532011-09-17 Eli Zaretskii <eliz@gnu.org>
1054
1137e8b8
EZ
1055 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1056 about the current paragraph and restore it after the call to
1057 reseat.
1058
1059 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1060 (bidi_find_paragraph_start): Search back for paragraph beginning
1061 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1062 (bidi_move_to_visually_next): Only trigger paragraph-related
1063 computations when the last character is a newline or at EOB, not
1064 just any NEUTRAL_B. (Bug#9470)
1065
bb187662
EZ
1066 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1067 truncated lines if point is covered by a display string. (Bug#9524)
1068
2e621251
PE
10692011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1070
1071 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1072 (cons_to_x_long): New function.
1073 (lisp_data_to_selection_data): Use it. Correct the test for
1074 short-versus-long data; it was negated. Break out of vector
1075 loop, for efficiency, when a long datum is discovered.
1076
91a15bc6
SM
10772011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1078
1079 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1080
b41c3a35
EZ
10812011-09-16 Eli Zaretskii <eliz@gnu.org>
1082
1083 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1084 GCC PR/17406) by declaring this function with external scope.
1085
7812ba2d
PE
10862011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1087
1088 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1089 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1090
cf7edc2a
AS
10912011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1092
1093 * editfns.c (Fformat): Correctly handle text properties on "%%".
1094
bd01620e
EZ
10952011-09-15 Eli Zaretskii <eliz@gnu.org>
1096
1097 * xterm.c (x_draw_composite_glyph_string_foreground):
1098 * w32term.c (x_draw_composite_glyph_string_foreground):
1099 * term.c (encode_terminal_code):
1100 * composite.c (composition_update_it, get_composition_id):
1101 * xdisp.c (get_next_display_element)
1102 (fill_composite_glyph_string): Add comments about special meaning
1103 of TAB characters in a composition.
1104
a02719a3
PE
11052011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1106
1107 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1108 This occurs when processing a multibyte format.
1109 Problem reported by Wolfgang Jenker.
a02719a3 1110
72589a3c
JB
11112011-09-15 Johan Bockgård <bojohan@gnu.org>
1112
1113 * xdisp.c (try_cursor_movement): Only check for exact match if
1114 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1115
1c14176c
PE
11162011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1117
1118 Remove unused external symbols.
1119 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1120 * xdisp.c (calc_pixel_width_or_height): Now static.
1121 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1122 * indent.c (check_display_width):
1123 * w32term.c: Fix comment to match code.
1124 * xterm.c, xterm.h (x_catching_errors): Remove.
1125
d2eea5b5
PE
11262011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1127
1128 * xselect.c: Use signed conversions more consistently (Bug#9498).
1129 (selection_data_to_lisp_data): Assume incoming selection data are
1130 signed integers, not unsigned. This is to be consistent with
1131 outgoing selection data, which was modified to use signed integers
1132 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1133 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1134 expects long, not unsigned long.
1135
46888499
EZ
11362011-09-14 Eli Zaretskii <eliz@gnu.org>
1137
1138 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1139 computation of loop end. Reported by Johan Bockgård
1140 <bojohan@gnu.org>.
1141
ef8ef9fb
CY
11422011-09-13 Chong Yidong <cyd@stupidchicken.com>
1143
1144 * frame.c (Fother_visible_frames_p): Function deleted.
1145
fa819fed
EZ
11462011-09-12 Eli Zaretskii <eliz@gnu.org>
1147
1148 * indent.c (compute_motion): Process display vector front to back
1149 rather than the other way around. (Bug#2496)
1150
2ba8e008
SM
11512011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1152
1153 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1154
20f53c69
CY
11552011-09-11 Chong Yidong <cyd@stupidchicken.com>
1156
1157 * minibuf.c (Fread_from_minibuffer): Doc fix.
1158
d562d7a4
EZ
11592011-09-11 Eli Zaretskii <eliz@gnu.org>
1160
1161 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1162 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1163
1c4d7f3d
LMI
11642011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1165
1166 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1167 value for non-existent files.
1168
b885bf36
EZ
11692011-09-11 Eli Zaretskii <eliz@gnu.org>
1170
1171 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1172 set its "size" to -1. This will set the modtime_size field of
1173 the corresponding buffer to -1, which is what
1174 verify-visited-file-modtime expects for files that do not exist.
1175 (Bug#9139)
1176
6612f0bf
PE
11772011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1178
1179 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1180 here ...
1181 * lisp.h: ... from here. push_key_description is no longer
1182 defined in keyboard.c, so its declaration should not be in
1183 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1184 logically belongs with push_key_description.
1185
dfb3f755
PE
11862011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1187
1188 * buffer.h: Include <sys/types.h> instead of <time.h>.
1189 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1190 Problem reported by Herbert J. Skuhra.
1191
3134906c
LMI
11922011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1193
1194 * xml.c (parse_region): Make the parsing work for
1195 non-comment-starting XML files again (bug#9144).
1196
8d903f4e
AS
11972011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1198
1199 * image.c (gif_load): Fix calculation of bottom and right corner.
1200 (Bug#9468)
1201
80ad64f4
EZ
12022011-09-10 Eli Zaretskii <eliz@gnu.org>
1203
1204 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1205 redisplay in small windows.
1206
208a048d
EZ
12072011-09-09 Eli Zaretskii <eliz@gnu.org>
1208
1209 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1210
9b1c252e
MR
12112011-09-08 Martin Rudalics <rudalics@gmx.at>
1212
1213 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1214 Operate on live windows only.
1215
2949f33b
JB
12162011-09-08 Juanma Barranquero <lekktu@gmail.com>
1217
1218 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1219
e08dcafd
EZ
12202011-09-07 Eli Zaretskii <eliz@gnu.org>
1221
1222 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1223 only under bidi iteration.
1224
115b96bd
JD
12252011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1226
1227 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1228
c8199d0f
PE
12292011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1230
1231 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1232 Without this fix, the command to link temacs failed due to an
1233 undefined symbol __builtin_isnan. This is because
1234 /usr/include/iso/math_c99.h #defines isnan(x) to
1235 __builtin_isnan(x), but the bundled gcc, which identifies itself
1236 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1237 a __builtin_isnan.
1238 * floatfns.c (isnan): #undef, and then #define to a clone of
1239 what's in data.c.
1240 (Fisnan): Always define, since it's always available now.
1241 (syms_of_floatfns): Always define isnan at the Lisp level.
1242
e39b275c 12432011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1244
1245 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1246
b2db44d9 12472011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1248
f4af5137 1249 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1250 The previous code assumed that file offsets (off_t values) fit in
1251 EMACS_INT variables, which is not true on typical 32-bit hosts.
1252 The code messed up by falsely reporting buffer overflow in cases
1253 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1254 when "big" contains more than 2**29 bytes, even though this
1255 inserts just one byte and does not overflow the buffer.
1256 (Finsert_file_contents): Store file offsets as off_t
1257 values, not as EMACS_INT values. Check for overflow when
1258 converting between EMACS_INT and off_t. When checking for
1259 buffer overflow or for overlap, take the offsets into account.
1260 Don't use EMACS_INT for small values where int suffices.
1261 When checking for overlap, fix a typo: ZV was used where
1262 ZV_BYTE was intended.
1263 (Fwrite_region): Don't assume off_t fits into 'long'.
1264 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1265
ecfc0a49
MA
12662011-09-05 Michael Albinus <michael.albinus@gmx.de>
1267
1268 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1269
6511acf2 12702011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1271
0999621a 1272 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1273
1274 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1275 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
1276 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1277 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
1278 (modify_event_symbol): Do not assume that the length of
1279 name_alist_or_stem is safe to alloca and fits in int.
1280 (Fexecute_extended_command): Likewise for function name and binding.
1281 (Frecursion_depth): Wrap around reliably on integer overflow.
1282 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1283 since some callers pass EMACS_INT values.
1284 (Fsingle_key_description): Don't crash if symbol name contains more
1285 than MAX_ALLOCA bytes.
1286 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1287 (get_minibuffer): Arg is now EMACS_INT, not int.
1288 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1289 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1290 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1291
2be7d702
PE
1292 * dbusbind.c (signature_cat): New function.
1293 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1294 Do not overrun buffer; instead, report string overflow.
1295
9d1df220
PE
1296 * dispnew.c (add_window_display_history): Don't overrun buffer.
1297 Truncate instead; this is OK since it's just a log.
1298
33ef5c64
PE
1299 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1300 even if the time zone offset is outlandishly large.
1301 Don't mishandle offset == INT_MIN.
1302
66c6fdd5
PE
1303 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1304 when creating daemon; the previous buffer-overflow check was incorrect.
1305
d749b01b
PE
1306 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1307 which has the guts of the old verror function.
1308
b5cd1905
PE
1309 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1310 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1311
6e1a67fb
PE
1312 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1313 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1314 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1315 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1316 length of string rather than counting it via multiple sprintfs;
1317 that's simpler and more reliable.
c21721cc
PE
1318 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1319 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1320 sprintf, in case result does not fit in int.
1321
c57b67fc
PE
1322 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1323 (fontset_from_font): Print it.
1324
8a401434
PE
1325 * frame.c (tty_frame_count): Now printmax_t, not int.
1326 (make_terminal_frame, set_term_frame_name): Print it.
1327 (x_report_frame_params): In X, window IDs are unsigned long,
1328 not signed long, so print them as unsigned.
1329 (validate_x_resource_name): Check for implausibly long names,
1330 and don't assume name length fits in 'int'.
1331 (x_get_resource_string): Don't blindly alloca invocation name;
1332 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1333 not fit in int.
1334
6e1a67fb
PE
1335 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1336 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1337 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1338
0df02bf3
PE
1339 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1340 Use esprintf, not sprintf, in case result does not fit in int.
1341
48e30793
PE
1342 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1343 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1344 it as a large positive number.
1345 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1346 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1347
a66ff6d8
PE
1348 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1349 in case result does not fit in int.
1350
aca216ff
PE
1351 * print.c (float_to_string): Detect width overflow more reliably.
1352 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1353 buffer overrun. Don't assume list length fits in 'int'. Treat
1354 print length of 0 as 0, not as infinity; to be consistent with other
1355 uses of print length in this function. Don't overflow print length
1356 index. Don't assume hash table size fits in 'long', or that
1357 vectorlike size fits in 'unsigned long'.
1358
31c286f7
PE
1359 * process.c (make_process): Use printmax_t, not int, to format
1360 process-name gensyms.
1361
55e5faa1
PE
1362 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1363
80f2e268
PE
1364 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1365 to avoid potential buffer overrun.
1366
670741ab
PE
1367 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1368 if X resource line is longer than 512 bytes.
1369
b7163a50
PE
1370 * xfns.c (x_window): Make sprintf buffer a bit bigger
1371 to avoid potential buffer overrun.
1372
ae58ff1f
PE
1373 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1374
c43c8a6a
PE
1375 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1376
3f8236f4
PE
13772011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1378
53e9fe90 1379 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1380 Without these, Emacs silently mishandles large integers sometimes.
1381 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1382 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1383
6511acf2
PE
1384 * xdisp.c (try_window_id): Check Emacs fixnum range before
1385 converting to 'int'.
806add1d 1386
6511acf2 1387 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1388 Check that an Emacs fixnum is in range before assigning it to 'int'.
1389 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1390 values converted from Emacs fixnums.
1391 (Frecenter): Don't wrap around a line count if it is out of 'int'
1392 range; instead, treat it as an extreme value.
1393 (Fset_window_configuration, compare_window_configurations):
1394 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1395
6511acf2
PE
1396 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1397 that can exceed INT_MAX. Check that EMACS_INT value is in range
1398 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1399 (match_limit): Don't assume that a fixnum can fit in 'int'.
1400
6511acf2 1401 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1402 exceed INT_MAX.
1403
6511acf2 1404 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1405 (Fvertical_motion): Don't wrap around LINES values that don't fit
1406 in 'int'. Instead, treat them as extreme values. This is good
1407 enough for windows, which can't have more than INT_MAX lines anyway.
1408
fcb901a7
LMI
14092011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1410
0f2f6b6d
LMI
1411 * Require libxml/parser.h to avoid compilation warning.
1412
fcb901a7
LMI
1413 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1414
1415 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1416 since this reportedly can destroy thread storage.
1417
6e20a0d4
CY
14182011-08-30 Chong Yidong <cyd@stupidchicken.com>
1419
1420 * syntax.c (find_defun_start): Update all cache variables if
1421 exiting early (Bug#9401).
1422
148ae00e
EZ
14232011-08-30 Eli Zaretskii <eliz@gnu.org>
1424
f6cfbd8f
EZ
1425 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1426
148ae00e
EZ
1427 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1428 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1429 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1430
1431 * term.c (tty_append_glyph): New function.
1432 (produce_stretch_glyph): Static function and its prototype deleted.
1433
a66cfb1c
SM
1434 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1435 Add prototypes.
148ae00e 1436
c4a07a4c
PE
14372011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1438
1439 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1440 when checking :margin (Bug#9390).
1441 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1442 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1443 so that the name doesn't mislead. All uses changed.
1444
6bc8cd65
JB
14452011-08-28 Johan Bockgård <bojohan@gnu.org>
1446
1447 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1448 set_tty_hooks.
1449
dca4927e
EZ
14502011-08-27 Eli Zaretskii <eliz@gnu.org>
1451
1452 * xdisp.c (move_it_to): Don't bail out early when reaching
1453 position beyond to_charpos, if we are scanning backwards.
1454 (move_it_vertically_backward): When DY == 0, make sure we get to
1455 the first character in the line after the newline.
1456
f2cad773
PE
14572011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1458
1459 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1460 (ccl_driver): Do not generate an out-of-range pointer.
1461 (Fccl_execute_on_string): Remove unnecessary check for
1462 integer overflow, noted by Stefan Monnier in
1463 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1464 Remove a FIXME that didn't need fixing.
1465 Simplify the newly-introduced buffer reallocation code.
1466
0cae2cdb
JB
14672011-08-27 Juanma Barranquero <lekktu@gmail.com>
1468
1469 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1470
5fc295a4 14712011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1472
70c60eb2 1473 Integer and memory overflow issues (Bug#9196).
726e0ab1 1474
d31850da
PE
1475 * doc.c (get_doc_string): Rework so that
1476 get_doc_string_buffer_size is the actual buffer size, rather than
1477 being 1 less than the actual buffer size; this makes xpalloc more
1478 convenient.
1479
a69fbedb
PE
1480 * image.c (x_allocate_bitmap_record, cache_image):
1481 * xselect.c (Fx_register_dnd_atom):
1482 Simplify previous changes by using xpalloc.
1483
fe5c5d37
PE
1484 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1485 since either will do and ptrdiff_t is convenient with xpalloc.
1486
0065d054
PE
1487 * charset.c (charset_table_size)
1488 (struct charset_sort_data.priority): Now ptrdiff_t.
1489 (charset_compare): Don't overflow if priorities differ greatly.
1490 (Fsort_charsets): Don't assume list length fits in int.
1491 Check for size-calculation overflow when allocating sort data.
1492 (syms_of_charset): Allocate an initial charset table that is
1493 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1494
1495 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1496
1497 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1498 The actual value is always <= INT_MAX, and leaving it unsigned made
1499 overflow checking harder.
1500
1501 * dispextern.h (struct glyph_matrix.rows_allocated)
1502 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1503 with xpalloc. The values are still always <= INT_MAX.
1504
1505 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1506
1507 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1508 (SAFE_NALLOCA): New macro.
1509
1510 * region-cache.c (struct boundary.pos, find_cache_boundary)
1511 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1512 (set_cache_region, invalidate_region_cache)
1513 (revalidate_region_cache, know_region_cache, region_cache_forward)
1514 (region_cache_backward, pp_cache):
1515 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1516 so that ptrdiff_t * can be passed to xpalloc.
1517 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1518 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1519 (pp_cache): Don't assume cache_len fits in int.
1520 * region-cache.h: Adjust extern decls to match.
1521
1522 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1523 EMACS_INT, since either will do, for xpalloc.
1524
1525 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1526 (xnmalloc, xnrealloc, xpalloc): New functions.
1527
726e0ab1
PE
1528 * bidi.c (bidi_shelve_header_size): New constant.
1529 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1530 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1531
51f30bc5 1532 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1533 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1534 (overlay_strings):
1535 Don't update size of array until after memory allocation succeeds,
1536 because xmalloc/xrealloc may not return.
0065d054
PE
1537 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1538 now that we have proper integer overflow checking.
1539 (record_overlay_string, overlay_strings): Catch overflows when
1540 calculating size of overlay_str_buf.
726e0ab1 1541
0065d054
PE
1542 * callproc.c (Fcall_process): Check for size overflow when
1543 calculating size of args2.
1544 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1545 Normally we prefer signed values, but sticking with ptrdiff_t would
1546 require adding more-complicated checks.
726e0ab1
PE
1547
1548 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1549 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1550 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1551 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1552
1553 * character.c (Fstring): Check for size-calculation overflow.
1554
1555 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1556 unnecessary integer overflow. Check for size overflow.
1557 (encode_coding_object): Don't update size until xmalloc succeeds.
1558
1559 * composite.c (get_composition_id): Check for overflow in glyph
1560 length calculations.
1561
1562 Integer and memory overflow fixes for display code.
1563 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1564 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1565 (scrolling_window): Check for overflow in size calculations.
1566 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1567 Don't assume glyph table len fits in int.
1568 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1569 (row_table_size): Now ptrdiff_t, not int.
1570 (scrolling_window): Avoid overflow in size calculations.
1571 Don't update size until allocation succeeds.
1572 * fns.c (concat): Check for overflow in size calculations.
1573 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1574 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1575 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1576
1577 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1578 (get_doc_string): Check for size calculation overflow.
1579 Don't update size until allocation succeeds.
1580 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1581 EMACS_INT, where ptrdiff_t will do.
1582 (Fsubstitute_command_keys): Check for string overflow.
1583
1584 * editfns.c (set_time_zone_rule): Don't assume environment length
1585 fits in int.
1586 (message_length): Now ptrdiff_t, not int.
1587 (Fmessage_box): Don't update size until allocation succeeds.
1588 Don't assume message length fits in int.
1589 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1590
0065d054
PE
1591 * emacs.c (main): Do not reallocate argv, since there is a null at
1592 the end that can be overwritten, and this way there's no need to
1593 worry about size-calculation overflow.
1594 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1595
1596 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1597 alloc succeeds.
1598 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1599
1600 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1601 (x_set_scroll_bar_width, x_figure_window_size):
1602 Check for integer overflow.
1603 (x_set_alpha): Do not assume XINT fits in int.
1604
1605 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1606 This is for the members text_lines, text_cols, total_lines, total_cols,
1607 where the system imposes an 'int' limit.
1608
1609 * fringe.c (Fdefine_fringe_bitmap):
1610 Don't update size until alloc works.
1611
1612 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1613 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1614
1615 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1616 Check for size-calculation overflow.
1617 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1618 do, as we prefer signed integers.
1619 (id_to_widget.max_size, id_to_widget.used)
1620 (xg_store_widget_in_map, xg_remove_widget_from_map)
1621 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1622 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1623 Use and return ptrdiff_t, not int.
1624 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1625 * gtkutil.h: Change prototypes to match the above.
1626
1627 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1628 are duplicate now that they've been promoted to lisp.h.
1629 (x_allocate_bitmap_record, x_alloc_image_color)
1630 (make_image_cache, cache_image, xpm_load):
1631 Don't update size until alloc is done.
1632 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1633 (x_detect_edges):
3256efce 1634 Check for size calculation overflow.
726e0ab1
PE
1635 (ct_colors_allocated_max): New constant.
1636 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1637 overflow.
3256efce 1638
726e0ab1
PE
1639 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1640 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1641 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1642 Use ptrdiff_t, not int, to count maps.
1643 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1644 calculations. Don't update size until allocation succeeds.
1645 Redo calculations to avoid overflow.
726e0ab1
PE
1646 * keyboard.h: Change prototypes to match the above.
1647
1648 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1649 to count maps.
1650 (current_minor_maps): Check for size calculation overflow.
1651 * keymap.h: Change prototypes to match the above.
1652
1653 * lread.c (read1, init_obarray): Don't update size until alloc done.
1654
1655 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1656 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1657
726e0ab1
PE
1658 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1659 Now ptrdiff_t, not int.
1660 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1661 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1662
1663 * process.c (Fnetwork_interface_list): Check for overflow
1664 in size calculation.
1665
1666 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1667
1668 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1669 overflow. Don't bother calling xmalloc when xrealloc will do.
1670
1671 * search.c (Freplace_match): Check for size calculation overflow.
1672 (Fset_match_data): Don't assume list lengths fit in 'int'.
1673
1674 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1675 for command line length. Do not attempt to address one before the
1676 beginning of an array, as that's not portable.
1677
1678 * term.c (max_frame_lines): Remove; unused.
1679 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1680 not int.
1681 (encode_terminal_code, calculate_costs): Check for size
1682 calculation overflow.
1683 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1684 table lengths and related sizes. Don't update size until alloc
1685 done. Redo calculations to avoid overflow.
1686 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1687
1688 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1689 subtracting pointers.
1690 (gobble_line): Check for overflow more carefully. Don't update size
1691 until alloc done.
1692
1693 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1694 Don't update size until alloc done.
1695 Redo size calculations to avoid overflow.
1696 Check for size calculation overflow.
0065d054 1697 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1698
1699 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1700 Use ptrdiff_t, not int, for sizes.
1701 (store_mode_line_noprop_char): Don't update size until alloc done.
1702
0065d054
PE
1703 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1704 Use ptrdiff_t, not int, for sizes.
1705 (Finternal_make_lisp_face, cache_face):
1706 Check for size calculation overflow.
1707 (cache_face): Treat size calculation overflows as if they were
1708 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1709
1710 * xfns.c (x_encode_text, x_set_name_internal)
1711 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1712 sizes, since they can exceed INT_MAX in size. Check for size
1713 calculation overflow.
1714
0065d054
PE
1715 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1716 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1717 Don't update size until alloc done.
1718
0065d054 1719 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1720 as sprintf is limited to int lengths.
1d526e2f 1721
252c5ee1
PE
1722 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1723 (X_LONG_MIN): New macros.
864d7ce7
PE
1724 Use them to make the following changes clearer.
1725 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1726 This change doesn't affect the value now, but it may help remind
1727 future maintainers not to raise the value too much later.
1728 (SELECTION_QUANTUM): Remove, replacing with ...
1729 (selection_quantum): ... new function, which avoids overflow.
1730 All uses changed.
1731 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1732 assumption that selection length fits in 'int'.
1733 (x_reply_selection_request, x_handle_selection_request)
1734 (x_get_window_property, receive_incremental_selection)
1735 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1736 (lisp_data_to_selection_data, clean_local_selection_data):
1737 Use ptrdiff_t, not int, to record length of selection.
1738 (x_reply_selection_request, x_get_window_property)
1739 (receive_incremental_selection, x_property_data_to_lisp):
1740 Redo calculations to avoid overflow.
1741 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1742 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1743 something.
1744 (x_get_window_property, receive_incremental_selection)
1745 (lisp_data_to_selection_data, x_property_data_to_lisp):
1746 Check for size-calculation overflow.
1747 (x_get_window_property, receive_incremental_selection)
1748 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1749 Don't store size until memory allocation succeeds.
1750 (x_get_window_property): Plug memory leak on memory exhaustion.
1751 Don't double-block input; malloc is safe here. Don't assume 2**34
1752 - 4 fits in unsigned long. Add an xassert to check
1753 XGetWindowProperty overflow. Be more careful about overflow
1754 calculations, and distinguish size from memory overflow better.
1755 (receive_incremental_selection): When tracing, don't assume
1756 unsigned int is less than INT_MAX.
1757 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1758 harmful) conversions of unsigned short to int.
1759 (lisp_data_to_selection_data): Don't assume that integers
1760 in the range -65535 through -1 fit in an X unsigned short.
1761 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1762 result parameters unless successful. Rely on cons_to_unsigned
1763 to report problems with elements; the old code wasn't right anyway.
1764 (x_check_property_data): Check for int overflow; we cannot use
1765 a wider type due to X limits.
1766 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1767
726e0ab1 1768 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1769
0065d054
PE
1770 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1771 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1772 (x_color_cells): Don't store size until memory allocation succeeds.
1773 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1774 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1775 (x_term_init): Don't assume length fits in int (sprintf is limited
1776 to int size).
bc18e09d 1777
ebfa62c0
PE
1778 Use ptrdiff_t for composition IDs.
1779 * character.c (lisp_string_width):
1780 * composite.c (composition_table_size, n_compositions)
1781 (get_composition_id, composition_gstring_from_id):
1782 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1783 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1784 * window.c (Frecenter):
1785 Use ptrdiff_t, not int, for composition IDs.
1786 * composite.c (get_composition_id): Check for integer overflow.
1787 * composite.h: Adjust prototypes to match the above changes.
1788
d3411f89
PE
1789 Use ptrdiff_t for hash table indexes.
1790 * category.c (hash_get_category_set):
1791 * ccl.c (ccl_driver):
1792 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1793 * coding.c (coding_system_charset_list, detect_coding_system):
1794 * coding.h (struct coding_system.id):
1795 * composite.c (get_composition_id, gstring_lookup_cache):
1796 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1797 * image.c (xpm_get_color_table_h):
1798 * lisp.h (hash_lookup, hash_put):
1799 * minibuf.c (Ftest_completion):
1800 Use ptrdiff_t for hash table indexes, not int (which is too
1801 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1802 32-bit --with-wide-int hosts).
1803
e097a6fa
PE
1804 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1805 Add a FIXME comment about memory leaks.
1806 (syms_of_charset): Don't assume xmalloc returns.
1807
5637687f
PE
1808 Don't assume that stated character widths fit in int.
1809 * character.c (Fchar_width, c_string_width, lisp_string_width):
1810 * character.h (CHAR_WIDTH):
1811 * indent.c (MULTIBYTE_BYTES_WIDTH):
1812 Use sanitize_char_width to avoid undefined and/or bad behavior
1813 with outlandish widths.
a66cfb1c 1814 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1815 now that we have two such functions. All uses changed.
1816 (sanitize_char_width): New inline function.
1817
a2271ba2
PE
1818 Don't assume that tab-width fits in int.
1819 * character.h (sanitize_width): New inline function.
1820 (SANE_TAB_WIDTH): New macro.
1821 (ASCII_CHAR_WIDTH): Use it.
1822 * indent.c (sane_tab_width): Remove. All uses replaced by
1823 SANE_TAB_WIDTH (current_buffer).
1824 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1825
18c52557
PE
1826 * fileio.c: Integer overflow issues with file modes.
1827 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1828
caeeedc1
PE
1829 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1830 Remove unreachable code.
1831 (read_hex, load_charset_map_from_file): Check for integer overflow.
1832
50849c52
PE
1833 * xterm.c: don't go over XClientMessageEvent limit
1834 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1835 (x_send_scroll_bar_event): Likewise. Check that the size does not
1836 exceed limits imposed by XClientMessageEvent, as well as the usual
1837 ptrdiff_t and size_t limits.
1838
b13995db
PE
1839 * keyboard.c: Overflow, signedness and related fixes.
1840 (make_lispy_movement): Use same integer type in forward decl
1841 that is used in the definition.
1842 (read_key_sequence, keyremap_step):
1843 Change bufsize argument back to int, undoing my 2011-03-30 change.
1844 We prefer signed types, and int is wide enough here.
1845 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1846 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1847 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1848 length, not size_t. Use ptrdiff_t for index, not int.
1849 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1850 possibility of integer overflow.
1851
13464394
PE
1852 Overflow, signedness and related fixes for images.
1853
1854 * dispextern.h (struct it.stack[0].u.image.image_id)
1855 (struct_it.image_id, struct image.id, struct image_cache.size)
1856 (struct image_cache.used, struct image_cache.ref_count):
1857 * gtkutil.c (update_frame_tool_bar):
1858 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1859 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1860 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1861 * nsmenu.m (update_frame_tool_bar):
1862 * xdisp.c (calc_pixel_width_or_height):
1863 * xfns.c (image_cache_refcount):
1864 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1865 on typical 64-bit hosts.
1866
1867 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1868 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1869 Omit unnecessary casts to int.
1870 (parse_image_spec): Check that integers fall into 'int' range
1871 when the callers expect that.
1872 (image_ascent): Redo ascent calculation to avoid int overflow.
1873 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1874 (lookup_image): Remove unnecessary tests.
1875 (xbm_image_p): Locals are now of int, not EMACS_INT,
1876 since parse_image_check makes sure they fit into int.
1877 (png_load, gif_load, svg_load_image):
1878 Prefer int to unsigned where either will do.
1879 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1880 old tiff_error_handler and tiff_warning_handler.
1881 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1882 stack buffer overflows. It uses only the features of vsnprintf
1883 that are common to both POSIX and native Microsoft.
1884 (tiff_error_handler, tiff_warning_handler): Use it.
1885 (tiff_load, gif_load, imagemagick_load_image):
1886 Don't assume :index value fits in 'int'.
1887 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1888 (imagemagick_load_image): Check that crop parameters fit into
1889 the integer types that MagickCropImage accepts. Don't assume
1890 Vimagemagick_render_type has a nonnegative value. Don't assume
1891 size_t fits in 'long'.
1892 (gs_load): Use printmax_t to print the widest integers possible.
1893 Check for integer overflow when computing image height and width.
1894
c11821d4
EZ
18952011-08-26 Eli Zaretskii <eliz@gnu.org>
1896
1897 * xdisp.c (redisplay_window): Don't force window start if point
1898 will be invisible in the resulting window. (Bug#9324)
1899
0c95fcf7
EZ
19002011-08-25 Eli Zaretskii <eliz@gnu.org>
1901
1902 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1903 the display spec is of the form `(space ...)'.
1904 (handle_display_spec): Return the value returned by
1905 handle_single_display_spec, not just 1 or zero.
1906 (handle_single_display_spec): If the display spec is of the form
1907 `(space ...)', and specifies display in the text area, return 2
1908 rather than 1.
fee65a97 1909 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1910 accurately, and prefer exact match for point under bidi.
1911 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1912
1913 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1914 into disp_prop; all users changed.
1915
1916 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1917 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1918 for the text covered by the display property.
1919
e4ed06f1
CY
19202011-08-25 Chong Yidong <cyd@stupidchicken.com>
1921
1922 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1923 Change return value to nil.
1924 (Frecord_buffer): Delete unused function.
1925
f67cdd7f
EZ
19262011-08-24 Eli Zaretskii <eliz@gnu.org>
1927
5980d4c6
EZ
1928 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1929 buffers, return left-to-right.
8610fe8b
EZ
1930 (set_cursor_from_row): Consider candidate row a win if its glyph
1931 represents a newline and point is on that newline. Fixes cursor
1932 positioning on the newline at EOL of R2L text within L2R
1933 paragraph, and vice versa.
1934 (try_cursor_movement): Check continued rows, in addition to
1935 continuation rows. Fixes unwarranted scroll when point enters a
1936 continued line of R2L text within an L2R paragraph, or vice versa.
1937 (cursor_row_p): Consider the case of point being equal to
1938 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1939 from the end of a short line to the beginning of a continued line
1940 of R2L text within L2R paragraph.
1941 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1942 composed characters.
5980d4c6 1943
f67cdd7f
EZ
1944 * bidi.c (bidi_check_type): Use xassert.
1945 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1946 members.
1947
bca633fb
EZ
19482011-08-23 Eli Zaretskii <eliz@gnu.org>
1949
1950 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1951 a character.
1952
4a5885a7
CY
19532011-08-23 Chong Yidong <cyd@stupidchicken.com>
1954
1955 * nsfont.m (ns_otf_to_script): Fix typo.
1956
0902a04e
KH
19572011-08-22 Kenichi Handa <handa@m17n.org>
1958
1959 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1960 extra slot even if the purpose is char-code-property-table.
1961
1a2e6670
EZ
19622011-08-23 Eli Zaretskii <eliz@gnu.org>
1963
8ddde651
EZ
1964 * xdisp.c (redisplay_window): When computing centering_position,
1965 account for the height of the header line. (Bug#8874)
1966
425cc014
EZ
1967 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1968 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1969 candidate is selected by the mouse, and that candidate has a
1970 composed character under the mouse.
1971
1a2e6670
EZ
1972 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1973 coordinates reported by pos-visible-in-window-p for a composed
1974 character in column zero.
1975
8b76d6f8
SM
19762011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1977
1978 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1979
dac347dd
EZ
19802011-08-22 Eli Zaretskii <eliz@gnu.org>
1981
1982 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1983 consider it a hit if to_charpos is anywhere in the range of the
1984 composed buffer positions.
1985
e013fb34
CY
19862011-08-22 Chong Yidong <cyd@stupidchicken.com>
1987
1988 * image.c (gif_load): Don't assume that each subimage has the same
1989 dimensions as the base image. Handle disposal method that is
1990 "undefined" by the gif spec (Bug#9335).
1991
bd1ba3e8
CY
19922011-08-20 Chong Yidong <cyd@stupidchicken.com>
1993
1994 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1995 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1996
54a1215b
EZ
19972011-08-19 Eli Zaretskii <eliz@gnu.org>
1998
823564e5
EZ
1999 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2000 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2001 from an Org mode buffer to a Speedbar frame.
2002
54a1215b
EZ
2003 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2004 a composition, take its buffer position from IT->cmp_it.charpos.
2005 Fixes cursor positioning at the beginning of a line that begins
2006 with a composed character.
2007
9778ebcc
EZ
20082011-08-18 Eli Zaretskii <eliz@gnu.org>
2009
0be6ee06
EZ
2010 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2011 character bidirectional type, use STRONG_L instead. Fixes crashes
2012 in a buffer produced by `describe-categories'.
2013
9778ebcc
EZ
2014 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2015 members before the level stack, so they would be saved and
2016 restored when copying iterator state. Fixes incorrect reordering
2017 around TABs covered by display properties.
2018
156bffbe
AS
20192011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2020
2021 * process.c (Fnetwork_interface_list): Correctly determine buffer
2022 size.
2023
72ad093b
CY
20242011-08-17 Chong Yidong <cyd@stupidchicken.com>
2025
2026 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2027 (internal_condition_case_2, internal_condition_case_n):
2028 Remove unnecessary aborts (Bug#9081).
72ad093b 2029
35774242
EZ
20302011-08-17 Eli Zaretskii <eliz@gnu.org>
2031
2032 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2033 has no `load' handler, try opening the file locally. (Bug#9311)
2034
db76dd85
KB
20352011-08-16 Ken Brown <kbrown@cornell.edu>
2036
2037 * gmalloc.c: Expand comment.
2038
b215eee5
EZ
20392011-08-16 Eli Zaretskii <eliz@gnu.org>
2040
2041 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2042 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2043
a4579d33
KB
20442011-08-16 Ken Brown <kbrown@cornell.edu>
2045
2046 Fix memory allocation problems in Cygwin build (Bug#9273).
2047
2048 * unexcw.c ( __malloc_initialized): Declare external variable.
2049 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2050
8b76d6f8
SM
2051 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2052 New variables.
a4579d33
KB
2053 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2054 dumped emacs.
2055 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2056 in the static heap.
2057 [CYGWIN] (special_realloc): New function.
2058 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2059 requests to realloc storage in the static heap.
2060
3ebec551
PE
20612011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2062
2063 * bidi.c (bidi_initialize): Remove unused local.
2064
9fd8be00
EZ
20652011-08-15 Eli Zaretskii <eliz@gnu.org>
2066
474a8465
EZ
2067 * biditype.h: File removed.
2068
2069 * bidimirror.h: File removed.
2070
2071 * deps.mk (bidi.o): Remove biditype.h and
2072 bidimirror.h.
2073
2074 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
2075 bidimirror.h.
2076
2077 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2078
2079 * chartab.c: Improve commentary for the uniprop_table API.
2080
32413314
EZ
2081 * bidi.c (bidi_paragraph_init): Support zero value of
2082 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2083 (bidi_initialize): Use uniprop_table instead of including
2084 biditype.h and bidimirror.h.
32413314 2085
9fd8be00
EZ
2086 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2087 coordinates of the iterator when restoring from ppos_it.
2088 (Bug#9296)
2089
5cf2b69b
KH
20902011-08-14 Kenichi Handa <handa@m17n.org>
2091
2092 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2093 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2094
daf17d00
EZ
20952011-08-14 Eli Zaretskii <eliz@gnu.org>
2096
2097 * xdisp.c (move_it_in_display_line_to): Don't invoke
2098 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2099 ppos_it. Fixes vertical cursor motion when line beginning is
2100 covered by an image. (Bug#9296)
2101
08e3161a
JD
21022011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2103
2104 * nsterm.h (ns_run_ascript): Declare.
2105 (NSAPP_DATA2_RUNASSCRIPT): Define.
2106
2107 * nsfns.m (as_script, as_result, as_status): New static variables.
2108 (ns_run_ascript): New function.
5e617bc2 2109 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2110 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2111 the event loop. Get status from as_status (Bug#7276).
2112
2113 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2114 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2115 the event loop (Bug#7276).
2116
a3720aa2
AS
21172011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2118
2119 * gnutls.c (QCgnutls_bootprop_priority)
2120 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2121 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2122 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2123 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2124 (QCgnutls_bootprop_verify_hostname_error)
2125 (QCgnutls_bootprop_callbacks_verify): Rename from
2126 Qgnutls_bootprop_..., all uses changed.
2127
2128 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2129 uses changed.
2130
0a0d27fb
PE
21312011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2132
19d5c50c
PE
2133 * xfaces.c (Qframe_set_background_mode): Now static.
2134 * dispextern.h (Qframe_set_background_mode): Remove decl.
2135
0a0d27fb
PE
2136 * process.c (Fnetwork_interface_info): Declare local only if needed.
2137
377538cb
JD
21382011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2139
2140 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2141 (Fnetwork_interface_list): Allocate in increments of bytes instead
2142 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2143 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2144 sockaddr.
2145 (struct ifflag_def): notrailers is smart on OSX.
2146 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2147 Get hardware address with getifaddrs if available.
2148
08fff70c
EZ
21492011-08-12 Eli Zaretskii <eliz@gnu.org>
2150
2151 * xdisp.c (iterate_out_of_display_property): xassert that
2152 IT->position is set to within IT->object's boundaries. Break from
2153 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2154 when IT->position is set up wrongly due to some bug.
2155 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2156 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2157 entry. Force push_it to save on the stack the current
2158 buffer/string position, to be restored by pop_it. Fix flags in
2159 the iterator structure wrt the object coming from a display
2160 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2161 properties. (Bug#9284)
2162
7be1c708 21632011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2164
7be1c708
CY
2165 * fontset.c (fontset_get_font_group): Add proper type checks.
2166 (Bug#9172)
aac0c6e3 2167
7be1c708 21682011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2169
7be1c708
CY
2170 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2171 and LC_VERSION_MIN_MACOSX.
2172 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2173 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2174
97bb72a6
EZ
21752011-08-08 Eli Zaretskii <eliz@gnu.org>
2176
2177 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2178 no-display-properties-and-no-overlays under bidi display.
2179 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2180 properties and overlays.
97bb72a6 2181
d5617611
CY
21822011-08-08 Chong Yidong <cyd@stupidchicken.com>
2183
37e11a63
CY
2184 * editfns.c (Fset_time_zone_rule): Document relationship with the
2185 setenv function.
2186
d5617611
CY
2187 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2188 the font entity extracted from the cache (Bug#8109).
2189
58872834
CY
21902011-08-07 Chong Yidong <cyd@stupidchicken.com>
2191
2192 * composite.c (autocmp_chars): Don't reset point. That is done by
2193 restore_point_unwind (Bug#5984).
2194
75bfc667
JL
21952011-08-07 Juri Linkov <juri@jurta.org>
2196
2197 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2198 to show the arg `TIME' instead of `TIMEVAL'.
2199
d1410150
EZ
22002011-08-06 Eli Zaretskii <eliz@gnu.org>
2201
2202 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2203 display property strides EOL and includes a newline, as in
2204 longlines-mode. (Bug#9254)
75b771e4
EZ
2205 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2206 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2207
2208 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2209 is non-zero, even if the data buffer is NULL. Fixes a crash in
2210 vertical-motion with longlines-mode. (Bug#9254)
2211
35928349
EZ
22122011-08-05 Eli Zaretskii <eliz@gnu.org>
2213
ec7cc85b
EZ
2214 * bidi.c <bidi_cache_total_alloc>: Now static.
2215 (bidi_initialize): Initialize bidi_cache_total_alloc.
2216
8b76d6f8 2217 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2218 cache. (Bug#9221)
2219
2220 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2221 amount allocated this far in `bidi_cache_total_alloc'.
2222 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2223 non-zero, only free the data buffer without restoring the cache
2224 contents. All callers changed.
2225
2226 * dispextern.h (bidi_unshelve_cache): Update prototype.
2227
2228 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2229 (move_it_in_display_line, move_it_to)
2230 (move_it_vertically_backward, move_it_by_lines): Replace the call
2231 to xfree to an equivalent call to bidi_unshelve_cache.
2232 (move_it_in_display_line_to): Fix logic of returning
412b6358 2233 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2234
e2e2423b
EZ
22352011-08-05 Eli Zaretskii <eliz@gnu.org>
2236
2237 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2238 came from a string character with a `cursor' property. (Bug#9229)
2239
ae9e757a
JD
22402011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2241
2242 * Makefile.in (LIB_PTHREAD): New variable.
2243 (LIBES): Add LIB_PTHREAD (Bug#9216).
2244
2245 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2246 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2247
213bd7f2
AS
22482011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2249
2250 * regex.c (re_iswctype): Remove some redundant boolean
2251 conversions.
2252
99aaf75f
JD
22532011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2254
2255 * xterm.c (x_find_topmost_parent): New function.
2256 (x_set_frame_alpha): Find topmost parent window with
2257 x_find_topmost_parent and set the property there also (bug#9181).
2258 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2259
c74e9d86
PE
22602011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2261
2262 * callproc.c (Fcall_process): Avoid vfork clobbering
2263 the local vars buffer, coding_systems, current_dir.
2264
640c8776
SM
22652011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2266
2267 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2268
f26d0e4c
PE
22692011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2270
8a10d76c
PE
2271 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2272 so that it is not optimized away.
2273
f26d0e4c
PE
2274 * xdisp.c (compute_display_string_pos): Remove unused local.
2275
55439c61
EZ
22762011-08-02 Eli Zaretskii <eliz@gnu.org>
2277
2278 Fix slow cursor motion and scrolling in large buffers with
2279 selective display, like Org Mode buffers. (Bug#9218)
2280
2281 * dispextern.h (struct bidi_it): New member disp_prop_p.
2282
2283 * xdisp.c: Remove one-slot cache of display string positions.
2284 (compute_display_string_pos): Accept an additional argument
5e617bc2 2285 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2286 for a display string or property. If found, set DISP_PROP_P
2287 non-zero.
2288
2289 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2290 DISP_PROP_P, and pass it to compute_display_string_pos.
2291 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2292 non-zero. All callers of bidi_fetch_char changed.
2293
fb33fa43
SM
22942011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2295
2296 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2297
b099e063
DM
22982010-12-03 Don March <don@ohspite.net>
2299
2300 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2301 last character M-[char] is translated to ESC [char] (bug#7541).
2302
5cc7f7af
KH
23032011-08-02 Kenichi Handa <handa@m17n.org>
2304
d0fffa3f 2305 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2306
2307 * chartab.c (uniprop_table): Make it non-static.
2308
525d5e6e
EZ
23092011-08-01 Eli Zaretskii <eliz@gnu.org>
2310
2311 * xdisp.c (forward_to_next_line_start): Accept additional argument
2312 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2313 on the newline.
2314 (reseat_at_next_visible_line_start): Use the bidi iterator state
2315 returned by forward_to_next_line_start to restore the state of
2316 it->bidi_it after backing up to previous newline. (Bug#9212)
2317
31011111
AS
23182011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2319
2320 * regex.c (re_comp): Protoize.
2321 (re_exec): Fix return type.
2322 (regexec): Fix type of `ret'. (Bug#9203)
2323
476371c4
PE
23242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2325
e5d76069
PE
2326 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2327 This is needed if max-image-size is a floating-point number.
2328
9a79b20c
AS
23292011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2330
2331 * print.c (print_object): Print empty symbol as ##.
2332
2333 * lread.c (read1): Read ## as empty symbol.
2334
d8c2fa78
AA
23352011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2336
2337 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2338 setting frame foreground color (Bug#9175).
2339 (x_set_background_color): Likewise.
2340
ffe57a7a
AA
2341 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2342 contents (Bug#9176).
2343 (EmacsTooltip -init): Remove bezels and add shadows to
2344 tooltip windows.
2345
bf3492a5
AA
2346 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2347 or scroll bar (Bug#8470).
2348
d55e9c53
AA
2349 * nsfont.m (nsfont_open): Remove assignment to voffset and
2350 unnecessary vars hshink, expand, hd, full_height, min_height.
2351 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2352
2353 * nsterm.h (nsfont_info): Remove voffset field.
2354
d8c2fa78 23552011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2356
2357 Implement strike-through and overline on NextStep (Bug#8863).
2358
2359 * nsfont.m (nsfont_open): Use underline position provided by font,
2360 instead of hard-coded value of 2.
2361 (nsfont_draw): Call ns_draw_text_decoration instead.
2362
2363 * nsterm.h: Add declaration for ns_draw_text_decoration.
2364
2365 * nsterm.m (ns_draw_text_decoration): New function for drawing
2366 underline, overline, and strike-through.
2367 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2368 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2369 accommodate underlining, etc.
4843aac3 2370
4cc60b9b
EZ
23712011-07-28 Eli Zaretskii <eliz@gnu.org>
2372
bc7ece87
EZ
2373 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2374 default.
4cc60b9b 2375
476371c4
PE
23762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2377
66606eea
PE
2378 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2379 Without this fix, if a signal arrives just after memory fills up,
2380 'malloc' might be invoked reentrantly.
2381
476371c4
PE
2382 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2383 In other words, assume that every image size is allowed, on non-X
2384 hosts. This assumption is probably wrong, but it lets Emacs compile.
2385
f3fcc40d
AS
23862011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2387
2388 * regex.c (re_iswctype): Convert return values to boolean.
2389
350c992f
EZ
23902011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2391
2392 * xdisp.c (compute_display_string_pos): Don't use cached display
2393 string position if the buffer had its restriction changed.
2394 (Bug#9184)
2395
5266b4bb
PE
23962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2397
2398 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2399
2573a837 24002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2401
41f55ccd 2402 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2403
39e378da
PE
2404 * bidi.c: Integer size and overflow fixes.
2405 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2406 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2407 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2408 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2409 (bidi_find_other_level_edge):
2410 Use ptrdiff_t instead of EMACS_INT where either will do.
2411 This works better on 32-bit hosts configured --with-wide-int.
2412 (bidi_cache_ensure_space): Check for size-calculation overflow.
2413 Use % rather than repeated addition, for better worst-case speed.
2414 Don't set bidi_cache_size until after xrealloc returns, because it
2415 might not return.
2416 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2417 (bidi_cache_ensure_space): Also check that the bidi cache size
2418 does not exceed that of the largest Lisp string or buffer. See Eli
2419 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2420
5e927815
PE
2421 * alloc.c (__malloc_size_t): Remove.
2422 All uses replaced by size_t. See Andreas Schwab's note
2423 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2424
ca4aa935
PE
2425 * image.c: Improve checking for integer overflow.
2426 (check_image_size): Assume that f is nonnull, since
2427 it is always nonnull in practice. This is one less thing to
2428 worry about when checking for integer overflow later.
2429 (x_check_image_size): New function, which checks for integer
2430 overflow issues inside X.
2431 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2432 This removes the need for a memory_full check.
2433 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2434 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2435 (xbm_read_bitmap_data): Change locals back to 'int', since
2436 their values must fit in 'int'.
2437 (xpm_load_image, png_load, tiff_load):
2438 Invoke x_create_x_image_and_pixmap earlier,
2439 to avoid much needless work if the image is too large.
2440 (tiff_load): Treat overly large images as if
2441 x_create_x_image_and_pixmap failed, not as malloc failures.
2442 (gs_load): Use x_check_image_size.
2443
5f8f9cc2
PE
2444 * gtkutil.c: Omit integer casts.
2445 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2446 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2447
5adf60bc
PE
2448 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2449
c8907a93
PE
2450 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2451 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2452 would wrongly return t on a 64-bit host.
2453
e3c25c68
PE
2454 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2455 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2456 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2457 and therefore cause GCC to emit a bogus diagnostic in some cases.
2458
3f791afe
PE
2459 * image.c: Integer signedness and overflow and related fixes.
2460 This is not an exhaustive set of fixes, but it's time to
2461 record what I've got.
2462 (lookup_pixel_color, check_image_size): Remove redundant decls.
2463 (check_image_size): Don't assume that arbitrary EMACS_INT values
2464 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2465 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2466 (tiff_load, imagemagick_load_image):
2467 Check for overflow in size calculations.
2468 (x_create_x_image_and_pixmap): Remove unnecessary test for
2469 xmalloc returning NULL; that can't happen.
2470 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2471 (xpm_color_bucket): Use better integer hashing function.
2472 (xpm_cache_color): Don't possibly over-allocate memory.
2473 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2474 (gif_memory_source):
2475 Use ptrdiff_t, not int or size_t, to record sizes.
2476 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2477 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2478 either works, as we prefer signed integers.
2479 (tiff_read_from_memory, tiff_write_from_memory):
2480 Return tsize_t, not size_t, since that's what the TIFF API wants.
2481 (tiff_read_from_memory): Don't fail simply because the read would
2482 go past EOF; instead, return a short read.
2483 (tiff_load): Omit no-longer-needed casts.
2484 (Fimagemagick_types): Don't assume size fits into 'int'.
2485
3cc5a532
PE
2486 Improve hashing quality when configured --with-wide-int.
2487 * fns.c (hash_string): New function, taken from sxhash_string.
2488 Do not discard information about ASCII character case; this
2489 discarding is no longer needed.
2490 (sxhash-string): Use it. Change sig to match it. Caller changed.
2491 * lisp.h: Declare it.
2492 * lread.c (hash_string): Remove, since we now use fns.c's version.
2493 The fns.c version returns a wider integer if --with-wide-int is
2494 specified, so this should help the quality of the hashing a bit.
2495
b312a492
PE
2496 * emacs.c: Integer overflow minor fix.
2497 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2498 Define only if GNU_LINUX.
2499 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2500
dfd153ae
PE
2501 * dispnew.c: Integer signedness and overflow fixes.
2502 Remove unnecessary forward decls, that were a maintenance hassle.
2503 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2504 All uses changed.
2505 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2506 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2507 (prepare_desired_row, line_draw_cost):
2508 Use int, not unsigned, where either works.
2509 (save_current_matrix, restore_current_matrix):
2510 Use ptrdiff_t, not size_t, where either works.
2511 (init_display): Check for overflow more accurately, and without
2512 relying on undefined behavior.
2513
a81d11a3
PE
2514 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2515 Remove, replacing with the new symbols in lisp.h. All uses changed.
2516 * fileio.c (make_temp_name):
2517 * filelock.c (lock_file_1, lock_file):
2518 * xdisp.c (message_dolog):
2519 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2520 Use pMd etc. instead.
2521 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2522 replacing the pWIDE etc. symbols removed from editfns.c.
2523
3300e6fd
PE
2524 * keyboard.h (num_input_events): Now uintmax_t.
2525 This is (very slightly) less likely to mess up due to wraparound.
2526 All uses changed.
2527
fd05c7e9
PE
2528 * buffer.c: Integer signedness fixes.
2529 (alloc_buffer_text, enlarge_buffer_text):
2530 Use ptrdiff_t rather than size_t when either will do, as we prefer
2531 signed integers.
2532
903fe15d
PE
2533 * alloc.c: Integer signedness and overflow fixes.
2534 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2535 (__malloc_size_t): Default to size_t, not to int.
2536 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2537 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2538 Prefer ptrdiff_t to size_t when either would do, as we prefer
2539 signed integers.
2540 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2541 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2542 Now const. Initialize with values that are in range even if char
2543 is signed.
2544 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2545 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2546 These functions do the right thing with sizes > 2**32.
2547 (check_depth): Now ptrdiff_t, not int.
2548 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2549 Adjust to new way of storing sizes. Check for size overflow bugs
2550 in rest of code.
2551 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2552 slightly wrong anyway, as it missed one instance of
2553 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2554 (refill_memory_reserve): Omit needless cast to size_t.
2555 (mark_object_loop_halt): Mark as externally visible.
2556
ac82cc6a
PE
2557 * xselect.c: Integer signedness and overflow fixes.
2558 (Fx_register_dnd_atom, x_handle_dnd_message):
2559 Use ptrdiff_t, not size_t, since we prefer signed.
2560 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2561 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2562 x_dnd_atoms_size and x_dnd_atoms_length.
2563
c2d1e36d
PE
2564 * doprnt.c: Prefer signed to unsigned when either works.
2565 * eval.c (verror):
2566 * doprnt.c (doprnt):
2567 * lisp.h (doprnt):
2568 * xdisp.c (vmessage):
2569 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2570 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2571 prefer signed arithmetic to avoid comparison confusion.
2572 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2573 but is a bit tricky.
2574
0e926e56
PE
2575 Assume freestanding C89 headers, string.h, stdlib.h.
2576 * data.c, doprnt.c, floatfns.c, print.c:
2577 Include float.h unconditionally.
2578 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2579 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2580 * regex.c: Likewise for stddef.h, string.h.
2581 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2582 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2583 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2584 (STDC_HEADERS): Remove obsolete defines.
2585 * sysdep.c: Include limits.h unconditionally.
2586
9cfdb3ec
PE
2587 Assume support for memcmp, memcpy, memmove, memset.
2588 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2589 * regex.c (memcmp, memcpy):
2590 Remove; we assume C89 now.
2591
2592 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2593 (__malloc_safe_bcopy): Remove; no longer needed.
2594
cf950e6b 2595 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2596 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2597 well either way, and we prefer signed to unsigned.
2598
dbf38e02
LMI
25992011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2600
2601 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2602 closes the connection while we're reading (bug#9182).
2603
d6f0886c 26042011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2605
d6f0886c
JD
2606 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2607 are specified (Bug#9168).
24e0f6b1 2608
2eb1f9e6
PE
26092011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2610
2611 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2612 Found by GCC static checking and --with-wide-int on a 32-bit host.
2613
22381272 26142011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2615
2616 * xdisp.c (compute_display_string_pos): Fix logic of caching
2617 previous display string position. Initialize cached_prev_pos to
2618 -1. Fixes slow-down at the beginning of a buffer.
2619
f25e39b4
EZ
26202011-07-24 Eli Zaretskii <eliz@gnu.org>
2621
2622 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2623 for attrs[LFACE_FONTSET_INDEX].
2624
04c4b52e
PE
26252011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2626
2627 * xml.c (parse_region): Remove unused local
2628 that was recently introduced.
2629
c1734fbd
EZ
26302011-07-23 Eli Zaretskii <eliz@gnu.org>
2631
be18c5a5
EZ
2632 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2633 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2634
c1734fbd
EZ
2635 * xdisp.c (move_it_in_display_line_to): Record the best matching
2636 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2637 exit if none of the characters scanned was an exact match.
2638 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2639 when exact match is impossible due to invisible text, and the
2640 lines are truncated.
2641
a258d627
JD
26422011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2643
2644 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2645 for OSX >= 10.7.
2646
b6d5a689
EZ
26472011-07-22 Eli Zaretskii <eliz@gnu.org>
2648
0f74f785
EZ
2649 Fix a significant slow-down of cursor motion with C-n, C-p,
2650 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2651 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2652 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2653 (next_element_from_buffer): Call compute_stop_pos_backwards to
2654 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2655 base_level_stop.
2656 (reseat): Don't look for prev_stop, as that could mean a very long
2657 run.
2658 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2659 <cached_disp_overlay_modiff>: Cache for last found display string
2660 position.
551918c1 2661 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2662 about the same buffer in the same area of character positions, and
2663 the buffer wasn't changed since the time the display string
2664 position was cached.
551918c1 2665
b2d0c91a
EZ
26662011-07-22 Eli Zaretskii <eliz@gnu.org>
2667
2668 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2669 is an integer, which is important for empty lines. (Bug#9149)
2670
043604ee
CY
26712011-07-22 Chong Yidong <cyd@stupidchicken.com>
2672
2673 * frame.c (Fmodify_frame_parameters): In tty case, update the
2674 default face if necessary (Bug#4238).
2675
da4adb04
CY
26762011-07-21 Chong Yidong <cyd@stupidchicken.com>
2677
2678 * editfns.c (Fstring_to_char): No need to explain what a character
2679 is in the docstring (Bug#6576).
2680
9abd0532
LMI
26812011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2682
2683 * xml.c (parse_region): Make sure we always return a tree.
2684
36881d16
HK
26852011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2686
2687 * xml.c (parse_region): If a document contains only comments,
2688 return that, too.
2689
1e98674d
LMI
26902011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2691
2692 * xml.c (make_dom): Return comments, too.
2693
590bd467
PE
26942011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2695
2696 Port to OpenBSD.
2697 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2698 and the surrounding thread.
2699 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2700 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2701 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2702 timer goes off.
2703 * s/openbsd.h (BROKEN_SIGIO): Define.
2704 * unexelf.c (unexec) [__OpenBSD__]:
2705 Don't update the .mdebug section of the Alpha COFF symbol table.
2706
f41628b2
LMI
27072011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2708
2709 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2710 (bug#8460).
2711
b59b67c5
PE
27122011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2713
15e3a074
PE
2714 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2715 This fixes some race conditions on the permissions of any newly
2716 created file.
2717
41bed37d
PE
2718 * alloc.c (valid_pointer_p): Use pipe, not open.
2719 This fixes some permissions issues when debugging.
2720
b59b67c5
PE
2721 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2722 If fchown fails to set both uid and gid, try to set just gid,
2723 as that is sometimes allowed. Adjust the file's mode to eliminate
2724 setuid or setgid bits that are inappropriate if fchown fails.
2725
925a6be7
SM
27262011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2727
2728 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2729 to compare Lisp_Objects.
2730 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2731 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2732 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2733
52968808
AS
27342011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2735
0a6a104b
AS
2736 * lread.c (read_integer): Unread even EOF character.
2737 (read1): Likewise. Properly record start position of symbol.
2738
52968808
AS
2739 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2740 symbol character follows.
2741
9e381cdd
PE
27422011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2743
2744 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2745 This works around a problem with the previous change to Fcopy_file.
2746 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2747 and without this change, GCC might complain about discarding
2748 fchown's return value.
2749
b5641435
JB
27502011-07-16 Juanma Barranquero <lekktu@gmail.com>
2751
2752 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2753
a8031457
PE
27542011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2755
2756 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2757
dd889327
LMI
27582011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2759
750c33f7
LMI
2760 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2761 it's used from the C level.
2762
dd889327
LMI
2763 * process.c: Use the same condition for POLL_FOR_INPUT in both
2764 keyboard.c and process.c (bug#1858).
2765
87e86684
LM
27662011-07-09 Lawrence Mitchell <wence@gmx.li>
2767
2768 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2769 (Fgnutls_boot): Use it.
2770
64348f40
AS
27712011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2772
2773 * doc.c (Fsubstitute_command_keys): Revert last change.
2774
1d698799
LMI
27752011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2776
f863868c
LMI
2777 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2778 quotes the next character, and doesn't affect other longer
2779 sequences (bug#8935).
2780
1d698799
LMI
2781 * lread.c (syms_of_lread): Clarify that is isn't only
2782 `eval-buffer' and `eval-defun' that's affected by
2783 `lexical-binding' (bug#8460).
2784
aa4b6df6
EZ
27852011-07-15 Eli Zaretskii <eliz@gnu.org>
2786
2787 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2788 bidi redisplay when a line includes both an image and is
2789 truncated.
2790
5d856da6
PE
27912011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2792
ad6042bb
PE
2793 Fix minor problems found by static checking.
2794 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2795 (elsz): Now a signed constant, not a size_t var. We prefer signed
2796 types to unsigned, to avoid integer comparison confusion. Without
2797 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2798 "cannot optimize loop, the loop counter may overflow", a symptom
2799 of the confusion.
f00bbb22 2800 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2801 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2802
6468f31c
LMI
28032011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2804
49080b10
LMI
2805 * search.c (Fre_search_backward): Mention `case-fold-search' in
2806 all the re_search_* functions (bug#8138).
2807
6468f31c
LMI
2808 * keyboard.c (Fopen_dribble_file): Document when the file is
2809 closed (bug#8056).
2810
c965adc5
EZ
28112011-07-14 Eli Zaretskii <eliz@gnu.org>
2812
df9733bf
EZ
2813 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2814 bidi_cache_idx.
2815
0bb23927
EZ
2816 Support bidi reordering of display and overlay strings.
2817 * xdisp.c (compute_display_string_pos)
2818 (compute_display_string_end): Accept additional argument STRING.
2819 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2820 (reseat_to_string): Initialize bidi_it->string.s and
2821 bidi_it->string.schars.
2822 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2823 NULL (avoids a crash in bidi_paragraph_init).
2824 Initialize itb.string.lstring.
0bb23927
EZ
2825 (init_iterator): Call bidi_init_it only of a valid
2826 buffer position was specified. Initialize paragraph_embedding to
2827 L2R.
2828 (reseat_to_string): Initialize the bidi iterator.
2829 (display_string): If we need to ignore text properties of
2830 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2831 original value of -1 will not work with bidi.)
2832 (compute_display_string_pos): First arg is now struct
2833 `text_pos *'; all callers changed. Support display properties on
2834 Lisp strings.
2835 (compute_display_string_end): Support display properties on Lisp
2836 strings.
2837 (init_iterator, reseat_1, reseat_to_string): Initialize the
2838 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2839 when iterating on a string not from display properties).
640c8776
SM
2840 (compute_display_string_pos, compute_display_string_end):
2841 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2842 arrow keys.
2843 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2844 base_level_stop; instead, set base_level_stop to BEGV.
2845 Fixes crashes in vertical-motion.
0bb23927
EZ
2846 (next_element_from_buffer): Improve commentary for when
2847 the iterator is before prev_stop.
2848 (init_iterator): Initialize bidi_p from the default value of
2849 bidi-display-reordering, not from buffer-local value. Use the
2850 buffer-local value only if initializing for buffer iteration.
2851 (handle_invisible_prop): Support invisible properties on strings
2852 that are being bidi-reordered.
2853 (set_iterator_to_next): Support bidi reordering of C strings and
2854 Lisp strings.
2855 (next_element_from_string): Support bidi reordering of Lisp
2856 strings.
2857 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2858 (display_string): Support display of R2L glyph rows.
2859 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2860 (init_iterator): Don't initialize it->bidi_p for strings
2861 here.
2862 (reseat_to_string): Initialize it->bidi_p for strings here.
2863 (next_element_from_string, next_element_from_c_string)
2864 (next_element_from_buffer): Add xassert's for correspondence
2865 between IT's object being iterated and it->bidi_it.string
2866 structure.
2867 (face_before_or_after_it_pos): Support bidi iteration.
2868 (next_element_from_c_string): Handle the case of the first string
2869 character that is not the first one in the visual order.
2870 (get_visually_first_element): New function, refactored from common
2871 parts of next_element_from_buffer, next_element_from_string, and
2872 next_element_from_c_string.
2873 (tool_bar_lines_needed, redisplay_tool_bar)
2874 (display_menu_bar): Force left-to-right direction. Add a FIXME
2875 comment for making that be controlled by a user option.
2876 (push_it, pop_it): Save and restore the state of the
2877 bidi iterator. Save and restore the bidi_p flag.
2878 (pop_it): Iterate out of display property for string iteration as
2879 well.
2880 (iterate_out_of_display_property): Support iteration over strings.
2881 (handle_single_display_spec): Set up it->bidi_it for iteration
2882 over a display string, and call bidi_init_it.
2883 (handle_single_display_spec, next_overlay_string)
2884 (get_overlay_strings_1, push_display_prop): Set up the bidi
2885 iterator for displaying display or overlay strings.
2886 (forward_to_next_line_start): Don't use the shortcut if
2887 bidi-iterating.
2888 (back_to_previous_visible_line_start): If handle_display_prop
2889 pushed the iterator stack, restore the internal state of the bidi
2890 iterator by calling bidi_pop_it same number of times.
2891 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2892 and we are bidi-iterating, don't decrement the iterator position;
2893 instead, set the first_elt flag in the bidi iterator, to produce
2894 the same effect.
2895 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2896 (push_display_prop): xassert that we are iterating a buffer.
2897 (push_it, pop_it): Save and restore paragraph_embedding member.
2898 (handle_single_display_spec, next_overlay_string)
2899 (get_overlay_strings_1, reseat_1, reseat_to_string)
2900 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2901 correctly. Don't assume unibyte strings are not bidi-reordered.
2902 (compute_display_string_pos)
2903 (compute_display_string_end): Fix handling the case of C string.
2904 (push_it, pop_it): Save and restore from_disp_prop_p.
2905 (handle_single_display_spec, push_display_prop): Set the
2906 from_disp_prop_p flag.
2907 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2908 (pop_it): Call iterate_out_of_display_property only if we are
2909 popping after iteration over a string that came from a display
2910 property. Fix a typo in popping stretch info. Add an assertion
2911 for verifying that the iterator position is in sync with the bidi
2912 iterator.
2913 (handle_single_display_spec, get_overlay_strings_1)
2914 (push_display_prop): Fix initialization of paragraph direction for
2915 string when that of the parent object is not yet determined.
2916 (reseat_1): Call bidi_init_it to resync the bidi
2917 iterator with IT's position. (Bug#7616)
2918 (find_row_edges): If ROW->start.pos gives position
2919 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2920 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2921 Reset the from_disp_prop_p flag.
2922 (SAVE_IT, RESTORE_IT): New macros.
2923 (pos_visible_p, face_before_or_after_it_pos)
2924 (back_to_previous_visible_line_start)
2925 (move_it_in_display_line_to, move_it_in_display_line)
2926 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2927 (try_scrolling, redisplay_window, display_line): Use them when
2928 saving a temporary copy of the iterator and restoring it back.
2929 (back_to_previous_visible_line_start, reseat_1)
2930 (init_iterator): Empty the bidi cache "stack".
2931 (move_it_in_display_line_to): If iterator ended up at
2932 EOL, but we never saw any buffer positions smaller than
2933 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2934 motion in bidi-reordered lines.
2935 (move_it_in_display_line_to): Record prev_method and prev_pos
2936 immediately before the call to set_iterator_to_next. Fixes cursor
2937 motion in bidi-reordered lines with stretch glyphs and strings
2938 displayed in margins. (Bug#8133) (Bug#8867)
2939 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2940 TO_CHARPOS.
640c8776
SM
2941 (pos_visible_p): Support positions in bidi-reordered lines.
2942 Save and restore bidi cache.
0bb23927
EZ
2943
2944 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2945 (bidi_paragraph_info): Delete unused struct.
2946 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2947 (bidi_cache_start): New variable.
2948 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2949 to zero.
2950 (bidi_cache_fetch_state, bidi_cache_search)
2951 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2952 (bidi_cache_find, bidi_peek_at_next_level)
2953 (bidi_level_of_next_char, bidi_find_other_level_edge)
2954 (bidi_move_to_visually_next): Compare cache index with
2955 bidi_cache_start rather than with zero.
2956 (bidi_fetch_char): Accept new argument STRING; all callers
2957 changed. Support iteration over a string. Support strings with
2958 display properties. Support unibyte strings. Fix the type of
2959 `len' according to what STRING_CHAR_AND_LENGTH expects.
2960 (bidi_paragraph_init, bidi_resolve_explicit_1)
2961 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2962 (bidi_level_of_next_char, bidi_move_to_visually_next):
2963 Support iteration over a string.
0bb23927
EZ
2964 (bidi_set_sor_type, bidi_resolve_explicit_1)
2965 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2966 can now be zero (for strings); special values 0 and -1 were
2967 changed to -1 and -2, respectively.
2968 (bidi_char_at_pos): New function.
2969 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2970 Call it instead of FETCH_MULTIBYTE_CHAR.
2971 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2972 initialized to valid values.
2973 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2974 values.
2975 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2976 the test for valid cached positions. Fix the logic for looking up
2977 the sentinel state in the cache. GCPRO the Lisp string we are
2978 iterating.
2979 (bidi_push_it, bidi_pop_it): New functions.
2980 (bidi_initialize): Initialize the bidi cache start stack pointer.
2981 (bidi_cache_ensure_space): New function, refactored from part of
2982 bidi_cache_iterator_state. Don't assume the required size is just
2983 one BIDI_CACHE_CHUNK away.
2984 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2985 (bidi_count_bytes, bidi_char_at_pos): New functions.
2986 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2987 always valid if bidi_cache_idx is valid.
2988 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2989 is valid if it's going to be used.
2990 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2991 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2992 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2993 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2994 (bidi_find_other_level_edge, bidi_cache_start_stack):
2995 All variables related to cache indices are now EMACS_INT.
c965adc5 2996
0bb23927
EZ
2997 * dispextern.h (struct bidi_string_data): New structure.
2998 (struct bidi_it): New member `string'. Make flag members be 1-bit
2999 fields, and put them last in the struct.
640c8776
SM
3000 (compute_display_string_pos, compute_display_string_end):
3001 Update prototypes.
0bb23927
EZ
3002 (bidi_push_it, bidi_pop_it): Add prototypes.
3003 (struct iterator_stack_entry): New members bidi_p,
3004 paragraph_embedding, and from_disp_prop_p.
3005 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3006 (bidi_shelve_cache, bidi_unshelve_cache):
3007 Declare prototypes.
0bb23927
EZ
3008
3009 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3010 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3011 and vector-like objects.
3012
3013 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3014 cache around display iteration.
3015
3016 * window.c (Fwindow_end, window_scroll_pixel_based)
3017 (displayed_window_lines, Frecenter): Save and restore the bidi
3018 cache around display iteration.
3019
3bbd2265
LMI
30202011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3021
3022 * editfns.c (Fdelete_region): Clarify the use of the named
3023 parameters (bug#6788).
3024
adc47434
MR
30252011-07-14 Martin Rudalics <rudalics@gmx.at>
3026
3027 * indent.c (Fvertical_motion): Set and restore w->pointm when
3028 saving and restoring the window's buffer (Bug#9006).
3029
837c31f8
LMI
30302011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3031
3032 * editfns.c (Fstring_to_char): Clarify just what is returned
3033 (bug#6576). Text by Eli Zaretskii.
3034
ac389d0c
JB
30352011-07-13 Juanma Barranquero <lekktu@gmail.com>
3036
3037 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3038
0be0ce47
EZ
30392011-07-13 Eli Zaretskii <eliz@gnu.org>
3040
3041 * buffer.c (mmap_find): Fix a typo.
3042
cd18e7e3
JB
30432011-07-13 Johan Bockgård <bojohan@gnu.org>
3044
3045 Fix execution of x selection hooks.
3046 * xselect.c (Qx_lost_selection_functions)
3047 (Qx_sent_selection_functions): New vars.
3048 (syms_of_xselect): DEFSYM them.
3049 (x_handle_selection_request): Pass Qx_sent_selection_functions
3050 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3051 (x_handle_selection_clear,x_clear_frame_selections):
3052 Pass Qx_lost_selection_functions rather than
3053 Vx_lost_selection_functions to Frun_hook_with_args.
3054
47ea7f44
PE
30552011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3056
ac389d0c 3057 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3058 The old code sometimes used this field without initializing it.
3059
47ea7f44
PE
3060 * alloc.c (gc_sweep): Don't read past end of array.
3061 In theory, the old code could also have corrupted Emacs internals,
3062 though it'd be very unlikely.
3063
bc985c87
AS
30642011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3065
3066 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3067 argument. (Bug#4026)
bc985c87 3068
0cf34688
LMI
30692011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3070
b3dadd76
LMI
3071 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3072 key" (bug#4257).
3073
0cf34688
LMI
3074 * window.c (Fset_window_start): Doc fix (bug#4199).
3075 (Fset_window_hscroll): Ditto.
3076
270768cd
PE
30772011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3078
077e3dda 3079 Fix minor new problems caught by GCC 4.6.1.
270768cd 3080 * term.c (init_tty): Remove unused local.
490011a6 3081 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3082 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3083 not used otherwise.
270768cd 3084
b1f58454
CY
30852011-07-12 Chong Yidong <cyd@stupidchicken.com>
3086
3087 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3088
22b9578d
LMI
30892011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3090
6e70ab07
LMI
3091 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3092 are the mini-buffer and the echo area (bug#3320).
3093
22b9578d
LMI
3094 * term.c (init_tty): Remove support for supdup, c10 and perq
3095 terminals, which are no longer supported (bug#1482).
3096
8974cc9f
JB
30972011-07-10 Johan Bockgård <bojohan@gnu.org>
3098
3099 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3100
a560d974
JD
31012011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3102
3103 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3104 for non-popups (Bug#3642).
3105
1dae0f0a
AS
31062011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3107
268c2c36 3108 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3109 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3110 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3111 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3112 * data.c (fmod): Likewise.
3113 * dispnew.c (swap_glyphs_in_rows): Likewise.
3114 * emacs.c (memory_warning_signal): Likewise.
3115 * floatfns.c (float_error): Likewise.
3116 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3117 (otf_open, font_otf_capability, generate_otf_features)
3118 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3119 Likewise.
3120 * image.c (pbm_read_file): Likewise.
3121 * indent.c (string_display_width): Likewise.
3122 * intervals.c (check_for_interval, search_for_interval)
3123 (inc_interval_count, count_intervals, root_interval)
3124 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3125 * lread.c (defalias): Likewise.
268c2c36 3126 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3127 * regex.c (set_image_of_range_1, set_image_of_range)
3128 (regex_grow_registers): Likewise.
3129 * sysdep.c (strerror): Likewise.
3130 * termcap.c (valid_filename_p, tprint, main): Likewise.
3131 * tparam.c (main): Likewise.
3132 * unexhp9k800.c (run_time_remap, save_data_space)
3133 (update_file_ptrs, read_header, write_header, calculate_checksum)
3134 (copy_file, copy_rest, display_header): Likewise.
3135 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3136 Likewise.
3137 * xdisp.c (check_it): Likewise.
3138 * xfaces.c (register_color, unregister_color, unregister_colors):
3139 Likewise.
3140 * xfns.c (print_fontset_result): Likewise.
3141 * xrdb.c (member, fatal, main): Likewise.
3142
99033785
PE
31432011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3144
3145 Fix minor problems found by static checking (Bug#9031).
3146 * chartab.c (char_table_set_range, map_sub_char_table):
3147 Remove unused locals.
3148 (uniprop_table): Now static.
3149 * composite.c (_work_char): Remove unused static var.
3150
9cb2ac56
JB
31512011-07-09 Juanma Barranquero <lekktu@gmail.com>
3152
3153 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3154
f25661f0
JD
31552011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3156
3157 * gtkutil.c (qttip_cb): Remove code without function.
3158
8278c4fe
EZ
31592011-07-09 Eli Zaretskii <eliz@gnu.org>
3160
3161 * w32.c (pthread_sigmask): New stub.
3162
1692ae2d 31632011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3164
8a6ebd58 3165 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3166 sigprocmask is portable only for single-threaded applications, and
3167 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3168 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3169 (LIBES): Use it.
3170 * callproc.c (Fcall_process):
3171 * process.c (create_process):
3172 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3173 Use pthread_sigmask, not sigprocmask.
123403e4 3174
1b854618
JD
31752011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3176
3177 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3178 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3179 wrong (Bug#8591).
3180
3fe4b549
JD
31812011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3182
0ce7e563
JD
3183 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3184 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3185 (xg_hide_tooltip): Fix comment.
3186
3fe4b549
JD
3187 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3188 in registerServicesMenuSendTypes.
3189 (validRequestorForSendType): Don't check ns_return_types.
3190
3191 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3192 ns_return_type.
3193
5df75e47
JR
31942011-07-08 Jason Rumney <jasonr@gnu.org>
3195
3196 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3197 frame struct members of non-existent frames (Bug#6284).
3198
699c10bd
JD
31992011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3200
4393663b
JD
3201 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3202 variable firstTime not needed on OSX >= 10.6.
3203 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3204 >= 10.5. Use setKnobProportion, setDoubleValue.
3205
3206 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3207 (MAC_OS_X_VERSION_10_5): Define if not defined.
3208 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3209 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3210 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3211
3212 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3213 cString and lossyCString on OSX >= 10.4
3214
3215 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3216 sizeToFit on OSX >= 10.2.
3217
3218 * nsimage.m (allocInitFromFile): Don't use deprecated method
3219 bestRepresentationForDevice on OSX >= 10.6.
3220
3221 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3222 to avoid warning.
3223
3224 * emacs.c: Declare unexec_init_emacs_zone.
3225
a63e0781
JD
3226 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3227
699c10bd
JD
3228 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3229
3230 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3231 on svcsMenu (Bug#8842).
3232
3233 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3234 ns_return_types.
3235 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3236
3237 * nsterm.m (QUTF8_STRING): Declare.
3238 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3239 (validRequestorForSendType): Return type is (id).
3240 Change indexOfObjectIdenticalTo to indexOfObject.
3241 Check if we have local selection before returning self (Bug#8842).
3242 (writeSelectionToPasteboard): Put local selection into paste board
3243 if we have a local selection (Bug#8842).
3244 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3245
3246 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3247 (ns_get_local_selection): Declare.
3248
54e10184
LMI
32492011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3250
9888ff71
LMI
3251 * keymap.c (describe_map_tree): Don't insert a double newline at
3252 the end of the buffer (bug#1169) and return whether we inserted
3253 something.
3254
54e10184
LMI
3255 * callint.c (Fcall_interactively): Change "reading args" to
3256 "providing args" to try to clarify what it does (bug#1010).
3257
15fa4783
KH
32582011-07-07 Kenichi Handa <handa@m17n.org>
3259
3260 * composite.c (composition_compute_stop_pos): Ignore a static
3261 composition starting before CHARPOS (Bug#8915).
3262
3263 * xdisp.c (handle_composition_prop): Likewise.
3264
a8815b00
EZ
32652011-07-07 Eli Zaretskii <eliz@gnu.org>
3266
3267 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3268 (Bug#9015)
3269
ef7b981d 32702011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3271
3272 * character.h (unicode_category_t): New enum type.
3273
3274 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3275 (Qchar_code_property_table): New variable.
3276 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3277 (UNIPROP_COMPRESSED_FORM_P): New macros.
3278 (char_table_ascii): Uncompress the compressed values.
3279 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3280 Uncompress the compressed values.
ac389d0c 3281 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3282 (char_table_ref_and_range): Uncompress the compressed values.
3283 (sub_char_table_set): New arg is_uniprop. Callers changed.
3284 Uncompress the compressed values.
3285 (sub_char_table_set_range): Args changed. Callers changed.
3286 (char_table_set_range): Adjuted for the above change.
3287 (map_sub_char_table): Delete args default_val and parent. Add arg
3288 top. Give decoded values to a Lisp function.
640c8776 3289 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3290 values to a Lisp function. Gcpro more variables.
3291 (uniprop_table_uncompress)
3292 (uniprop_decode_value_run_length): New functions.
3293 (uniprop_decoder, uniprop_decoder_count): New variables.
3294 (uniprop_get_decoder, uniprop_encode_value_character)
3295 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3296 New functions.
3297 (uniprop_encoder, uniprop_encoder_count): New variables.
3298 (uniprop_get_encoder, uniprop_table)
3299 (Funicode_property_table_internal, Fget_unicode_property_internal)
3300 (Fput_unicode_property_internal): New functions.
3301 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3302 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3303 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3304 char-code-property-alist.
3305
640c8776 3306 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3307 Vunicode_category_table.
3308
640c8776 3309 * font.c (font_range): Adjust for the change of
c805dec0
KH
3310 Vunicode_category_table.
3311
76b397fb
DN
33122011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3313
3314 * m/iris4d.h: Remove file, move contents ...
3315 * s/irix6-5.h: ... here.
3316
22b4128e
PE
33172011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3318
3319 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3320 * alloc.c (mark_buffer):
3321 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3322 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3323 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3324 This isn't true in general, and it's particularly not true
3325 if Emacs is configured with --with-wide-int.
3326 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3327 New macros, used in the buffer.c change.
3328
869795d6
JD
33292011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3330
3331 * xsettings.c: Use both GConf and GSettings if both are available.
3332 (store_config_changed_event): Add comment.
3333 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3334 (store_tool_bar_style_changed): New functions.
5e617bc2 3335 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3336 (struct xsettings): Move font inside HAVE_XFT.
3337 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3338 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3339 Move inside HAVE_XFT.
640c8776 3340 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3341 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3342 also.
3343 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3344 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3345 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3346 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3347 (parse_settings): Move check for font inside HAVE_XFT.
3348 (read_settings, apply_xft_settings): Add comment.
3349 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3350 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3351 call store_font_name_changed.
3352 (xft_settings_event): Add comment.
3353 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3354 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3355 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3356 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3357 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3358 (xsettings_get_system_font, xsettings_get_system_normal_font):
3359 Add comment.
869795d6 3360
d8ed26bd
PE
33612011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3362
3363 Random fixes. E.g., (random) never returned negative values.
3364 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3365 subseconds part to the entropy, as that's a bit more random.
3366 Prefer signed to unsigned, since the signedness doesn't matter and
3367 in general we prefer signed. When given a limit, use a
3368 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3369 latter isn't right if USE_2_TAGS_FOR_INTS.
3370 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3371 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3372
cabf1cac
SM
33732011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3374
3375 * textprop.c (text_property_stickiness):
3376 Obey Vtext_property_default_nonsticky.
3377 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3378 * w32fns.c (syms_of_w32fns):
3379 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3380
6e9b2be9
PE
33812011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3382
3383 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3384 This is more efficient than Ffile_directory_p and avoids a minor race.
3385
90186c68
LMI
33862011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3387
7c301272
LMI
3388 * buffer.c (Foverlay_put): Say what the return value is
3389 (bug#7835).
3390
c4f2d8d4
LMI
3391 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3392 is a directory before asking whether to use the file name
3393 (bug#7564).
ad637907
LMI
3394 (barf_or_query_if_file_exists): Make the "File is a directory"
3395 error be more correct.
c4f2d8d4 3396
90186c68
LMI
3397 * fns.c (Frequire): Remove the mention of the .gz files, since
3398 that's installation-specific, but keep the mention of
3399 `get-load-suffixes'.
3400
da64016e
PE
34012011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3402
3403 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3404 Report string overflow if the output is too long.
3405
7d47b580
JB
34062011-07-04 Juanma Barranquero <lekktu@gmail.com>
3407
a555cb87
JB
3408 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3409 (syms_of_gnutls): Remove duplicate DEFSYM for
3410 Qgnutls_bootprop_verify_hostname_error, an error for
3411 Qgnutls_bootprop_verify_error (which is no longer used).
3412
7d47b580
JB
3413 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3414 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3415 Also (re)move comments that are misplaced or no longer relevant.
3416
1e49bfab
LMI
34172011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3418
3419 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3420
1485f4c0
CY
34212011-07-03 Chong Yidong <cyd@stupidchicken.com>
3422
3423 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3424 and background color parameters if they have been changed.
3425
a9ab721e
LMI
34262011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3427
3428 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3429
cf7cff57
PE
34302011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3431
2e13213d
PE
3432 * xsettings.c (SYSTEM_FONT): Define only when used.
3433 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3434
cf7cff57
PE
3435 * keymap.c (access_keymap_1): Now static.
3436
7a8e04f7
CY
34372011-07-02 Chong Yidong <cyd@stupidchicken.com>
3438
3439 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3440 leave any prefix arg for the up event (Bug#1586).
3441
61352f62
LMI
34422011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3443
69bb1ef7
LMI
3444 * lread.c (syms_of_lread): Mention single symbols defined by
3445 `defvar' or `defconst' (bug#7154).
3446
61352f62 3447 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3448 (Frequire): Mention get-load-suffixes.
61352f62 3449
28545e04
MR
34502011-07-02 Martin Rudalics <rudalics@gmx.at>
3451
3452 * window.h (window): Remove clone_number slot.
3453 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3454 Remove.
3455 (make_parent_window, make_window, saved_window)
3456 (Fset_window_configuration, save_window_save): Don't deal with
3457 clone numbers.
3458 * buffer.c (Qclone_number): Remove declaration.
3459 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3460
3349e122
SM
34612011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3462
3463 Add multiple inheritance to keymaps.
3464 * keymap.c (Fmake_composed_keymap): New function.
3465 (Fset_keymap_parent): Simplify.
3466 (fix_submap_inheritance): Remove.
3467 (access_keymap_1): New function extracted from access_keymap to handle
3468 embedded parents and handle lists of maps.
3469 (access_keymap): Use it.
3470 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3471 (Fcopy_keymap): Handle embedded parents.
3472 (Fcommand_remapping, define_as_prefix): Simplify.
3473 (Fkey_binding): Simplify.
3474 (syms_of_keymap): Move minibuffer-local-completion-map,
3475 minibuffer-local-filename-completion-map,
3476 minibuffer-local-must-match-map, and
3477 minibuffer-local-filename-must-match-map to Elisp.
3478 (syms_of_keymap): Defsubr make-composed-keymap.
3479 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3480 (parse_menu_item): Trivial simplification.
3481
3279eb87
GM
34822011-07-01 Glenn Morris <rgm@gnu.org>
3483
3484 * Makefile.in (SETTINGS_LIBS): Fix typo.
3485
4550efdf
KI
34862011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3487
3488 * coding.c (Fencode_coding_string): Record the last coding system
3489 used, as the function doc string says (bug#8738).
3490
0949d2b6
JD
34912011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3492
3493 * xsettings.c (store_monospaced_changed): Take new font as arg and
3494 check for change against current_mono_font.
3495 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3496 (emacs_settings_constructor, emacs_settings_get_property)
3497 (emacs_settings_set_property, emacs_settings_class_init)
3498 (emacs_settings_init, gsettings_obj): Remove.
3499 (something_changedCB): New function for HAVE_GSETTINGS.
3500 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3501 with value as argument.
3502 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3503 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3504 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3505 "changed".
3506
3507 * xgselect.c: Add defined (HAVE_GSETTINGS).
3508 (xgselect_initialize): Ditto.
3509
3510 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3511 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3512 xg_select.
3513
bbc6b304
PE
35142011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3515
3516 * eval.c (struct backtrace): Simplify and port the data structure.
3517 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3518 signed bit field, as this assumption is not portable and it makes
3519 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3520 "char debug_on_exit : 1" as this is not portable either; instead,
3521 use the portable "unsigned int debug_on_exit : 1". Remove unused
3522 member evalargs. Remove obsolete comments about cc bombing out.
3523
9851bfc5
JD
35242011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3525
51bb811f 3526 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3527 Let HAVE_GSETTINGS override HAVE_GCONF.
3528 (store_monospaced_changed): New function.
3529 (EMACS_SETTINGS): A new type derived from GObject to handle
3530 GSettings notifications.
3531 (emacs_settings_constructor, emacs_settings_get_property)
3532 (emacs_settings_set_property, emacs_settings_class_init):
3533 New functions.
3534 (gsettings_client, gsettings_obj): New variables.
3535 (GSETTINGS_SCHEMA): New define.
3536 (something_changedCB): Call store_monospaced_changed.
3537 (init_gsettings): New function.
3538 (xsettings_initialize): Call init_gsettings.
3539 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3540 to NULL.
3541
640c8776 3542 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3543 GCONF_CFLAGS/LIBS.
3544
5386012d
MR
35452011-06-29 Martin Rudalics <rudalics@gmx.at>
3546
3547 * window.c (resize_root_window, grow_mini_window)
3548 (shrink_mini_window): Rename Qresize_root_window to
3549 Qwindow_resize_root_window and Qresize_root_window_vertically to
3550 Qwindow_resize_root_window_vertically.
3551
f13e0b08
PE
35522011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3553
3554 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3555
94515237
JB
35562011-06-27 Juanma Barranquero <lekktu@gmail.com>
3557
3558 * makefile.w32-in: Redesign dependencies so they reflect more
3559 clearly which files are directly included by each source file,
3560 and not through other includes.
3561
e43b6e43
MR
35622011-06-27 Martin Rudalics <rudalics@gmx.at>
3563
3564 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3565 (sort_overlays, overlay_strings): When an overlay's clone number
3566 matches the window's clone number process the overlay even if
3567 the overlay's window property doesn't match the current window.
3568
d68443dc
MR
3569 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3570 (Fwindow_hchild): Rename to Fwindow_left_child.
3571 (Fwindow_next): Rename to Fwindow_next_sibling.
3572 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3573 (resize_window_check): Rename to window_resize_check.
3574 (resize_window_apply): Rename to window_resize_apply.
3575 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3576 (Fdelete_other_windows_internal, resize_frame_windows)
3577 (Fsplit_window_internal, Fdelete_window_internal)
3578 (grow_mini_window, shrink_mini_window)
3579 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3580
c7e73be5
JD
35812011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3582
3583 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3584 (emacs_fixed_set_min_size): Remove.
3585 (emacs_fixed_new): Take frame as argument.
3586
3587 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3588 (_EmacsFixedPrivate): Remove minwidth/height.
3589 Add struct frame *f.
3590 (emacs_fixed_init): Initialize priv->f.
3591 (get_parent_class, emacs_fixed_set_min_size): Remove.
3592 (emacs_fixed_new): Set priv->f to argument.
3593 (emacs_fixed_get_preferred_width)
3594 (emacs_fixed_get_preferred_height): Use min_width/height from
3595 frames size_hint to set minimum and natural (Bug#8919).
3596 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3597 and use min_width/height from frames size_hint to set
3598 min_width/height (Bug#8919).
3599
3600 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3601 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3602 Fix indentation.
c7e73be5 3603
cf99dcf8
EZ
36042011-06-26 Eli Zaretskii <eliz@gnu.org>
3605
3606 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3607 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3608 called at ZV.
3609
029529ac
CY
36102011-06-26 Chong Yidong <cyd@stupidchicken.com>
3611
3612 * process.c (wait_reading_process_output): Bypass select if
3613 waiting for a cell while ignoring keyboard input, and input is
3614 pending. Suggested by Jan Djärv (Bug#8869).
3615
7a7ef429
PE
36162011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3617
3618 Use gnulib's dup2 module instead of rolling our own.
3619 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3620
11fdef7d 36212011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3622
3623 * dispnew.c (scrolling_window): Before scrolling, turn off a
3624 mouse-highlight in the window being scrolled.
3625
cd3520a4
JB
36262011-06-24 Juanma Barranquero <lekktu@gmail.com>
3627
3628 Move DEFSYM to lisp.h and use everywhere.
3629
3630 * character.h (DEFSYM): Move declaration...
3631 * lisp.h (DEFSYM): ...here.
3632
3633 * gnutls.c:
3634 * minibuf.c:
3635 * w32menu.c:
3636 * w32proc.c:
3637 * w32select.c: Don't include character.h.
3638
3639 * alloc.c (syms_of_alloc):
3640 * buffer.c (syms_of_buffer):
3641 * bytecode.c (syms_of_bytecode):
3642 * callint.c (syms_of_callint):
3643 * casefiddle.c (syms_of_casefiddle):
3644 * casetab.c (init_casetab_once):
3645 * category.c (init_category_once, syms_of_category):
3646 * ccl.c (syms_of_ccl):
3647 * cmds.c (syms_of_cmds):
3648 * composite.c (syms_of_composite):
3649 * dbusbind.c (syms_of_dbusbind):
3650 * dired.c (syms_of_dired):
3651 * dispnew.c (syms_of_display):
3652 * doc.c (syms_of_doc):
3653 * editfns.c (syms_of_editfns):
3654 * emacs.c (syms_of_emacs):
3655 * eval.c (syms_of_eval):
3656 * fileio.c (syms_of_fileio):
3657 * fns.c (syms_of_fns):
3658 * frame.c (syms_of_frame):
3659 * fringe.c (syms_of_fringe):
3660 * insdel.c (syms_of_insdel):
3661 * keymap.c (syms_of_keymap):
3662 * lread.c (init_obarray, syms_of_lread):
3663 * macros.c (syms_of_macros):
3664 * msdos.c (syms_of_msdos):
3665 * print.c (syms_of_print):
3666 * process.c (syms_of_process):
3667 * search.c (syms_of_search):
3668 * sound.c (syms_of_sound):
3669 * syntax.c (init_syntax_once, syms_of_syntax):
3670 * terminal.c (syms_of_terminal):
3671 * textprop.c (syms_of_textprop):
3672 * undo.c (syms_of_undo):
3673 * w32.c (globals_of_w32):
3674 * window.c (syms_of_window):
3675 * xdisp.c (syms_of_xdisp):
3676 * xfaces.c (syms_of_xfaces):
3677 * xfns.c (syms_of_xfns):
3678 * xmenu.c (syms_of_xmenu):
3679 * xsettings.c (syms_of_xsettings):
3680 * xterm.c (syms_of_xterm): Use DEFSYM.
3681
4228cf16
TZ
36822011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3683
cd3520a4 3684 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3685
7fcccf1e
PE
36862011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3687
7efb4e0e
PE
3688 Integer and buffer overflow fixes (Bug#8873).
3689
ff5844ad
PE
3690 * print.c (printchar, strout): Check for string overflow.
3691 (PRINTPREPARE, printchar, strout):
3692 Don't set size unless allocation succeeds.
3693
90532f02
PE
3694 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3695 for sizes. Check for string overflow more accurately.
3696 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3697
6d84508d
PE
3698 * macros.c: Integer and buffer overflow fixes.
3699 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3700 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3701 Use ptrdiff_t, not int, for sizes.
3702 Don't increment bufsize until after realloc succeeds.
3703 Check for size-calculation overflow.
3704 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3705
437b2cb4
PE
3706 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3707
8b9ac8b4
PE
3708 * lread.c: Integer overflow fixes.
3709 (read_integer): Radix is now EMACS_INT, not int,
3710 to improve quality of diagnostics for out-of-range radices.
3711 Calculate buffer size correctly for out-of-range radices.
3712 (read1): Check for integer overflow in radices, and in
3713 read-circle numbers.
82cb60d3
PE
3714 (read_escape): Avoid int overflow.
3715 (Fload, openp, read_buffer_size, read1)
3716 (substitute_object_recurse, read_vector, read_list, map_obarray):
3717 Use ptrdiff_t, not int, for sizes.
3718 (read1): Use EMACS_INT, not int, for sizes.
20270765 3719 Check for size overflow.
8b9ac8b4 3720
7fcccf1e
PE
3721 * image.c (cache_image): Check for size arithmetic overflow.
3722
bfbbd7e7
PE
3723 * lread.c: Integer overflow issues.
3724 (saved_doc_string_size, saved_doc_string_length)
3725 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3726 Now ptrdiff_t, not int.
3727 (read1): Don't assume doc string length fits in int. Check for
3728 out-of-range doc string lengths.
3729 (read_list): Don't assume file position fits in int.
39019e54 3730 (read_escape): Check for hex character overflow.
bfbbd7e7 3731
4e323265
LL
37322011-06-22 Leo Liu <sdl.web@gmail.com>
3733
3734 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3735 Move to minibuffer.el.
3736
85fece3e
PE
37372011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3738
20b84ce9 3739 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3740 The following patches are for when GLYPH_DEBUG && !XASSERT.
3741 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3742 * dispnew.c (flush_stdout):
3743 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3744 Mark as externally visible.
3745 * dispnew.c (check_window_matrix_pointers): Now static.
3746 * dispnew.c (window_to_frame_vpos):
3747 * xfns.c (unwind_create_frame):
3748 * xterm.c (x_check_font): Remove unused local.
3749 * scroll.c (CHECK_BOUNDS):
3750 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3751 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3752 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3753 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3754 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3755 Now static.
3756 (debug_method_add): Use va_list and vsprintf rather than relying
3757 on undefined behavior with wrong number of arguments.
3758 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3759 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3760 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3761 since we're not interested in debugging glyphs with old libraries.
3762 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3763 GCC 4.6.0's static checking.
3764
0766b489
PE
37652011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3766
31fd4b32
PE
3767 Integer overflow and signedness fixes (Bug#8873).
3768 A few related buffer overrun fixes, too.
3769
b79e8648
PE
3770 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3771
0766b489
PE
3772 * dispextern.h (struct face.stipple):
3773 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3774 (x_bitmap_mask, x_allocate_bitmap_record)
3775 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3776 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3777 (x_create_bitmap_from_xpm_data):
3778 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3779 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3780 (.bitmaps_last):
3781 * xfaces.c (load_pixmap):
3782 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3783 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3784 (.bitmaps_last, struct x_output.icon_bitmap):
3785 Use ptrdiff_t, not int, for bitmap indexes.
3786 (x_allocate_bitmap_record): Check for size overflow.
3787 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3788
b081724f
PE
3789 Use ptrdiff_t, not int, for overlay counts.
3790 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3791 * editfns.c (overlays_around, get_pos_property):
3792 * textprop.c (get_char_property_and_overlay):
3793 * xdisp.c (next_overlay_change, note_mouse_highlight):
3794 * xfaces.c (face_at_buffer_position):
21514da7
PE
3795 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3796 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3797 (Fnext_overlay_change, Fprevious_overlay_change)
3798 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3799 Use ptrdiff_t, not int, for sizes.
21514da7 3800 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3801
3de73e5e
PE
3802 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3803
2606c57b
PE
3804 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3805 (x_session_initialize): Do not assume string length fits in int.
3806
aaafe47a
PE
3807 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3808 This is unlikely, but can occur if DPI is outlandish.
3809
2674ddc8 3810 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3811 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3812
28154962
PE
3813 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3814 * xrdb.c (magic_file_p, search_magic_path):
3815 Omit last arg SUFFIX; it was always 0. All callers changed.
3816 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3817
7de51af5
PE
3818 * xfont.c (xfont_match): Avoid need for strlen.
3819
25ed6cc3
PE
3820 * xfns.c: Don't assume strlen fits in int.
3821 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3822
4eab31dd
PE
3823 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3824 not unsigned long, as we prefer signed integers. All callers changed.
3825 Detect integer overflow in repeat count.
3826 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3827 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3828
171e2a58
PE
3829 * termcap.c: Don't assume sizes fit in int and never overflow.
3830 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3831 (gobble_line): Check for size-calculation overflow.
3832
ad39faca 3833 * minibuf.c (Fread_buffer):
6e5bb2dc 3834 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3835 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3836 Don't assume string length fits in int.
3837
52c61c22 3838 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3839 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3840
b5b8c9e5
PE
3841 * font.c: Don't assume string length fits in int.
3842 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3843 Use ptrdiff_t, not int.
ccd6111c
PE
3844 (font_intern_prop): Don't assume string length fits in int.
3845 Don't assume integer property fits in fixnum.
3846 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3847
882f0d81 3848 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3849 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3850 Reformulate so as not to need the command string.
3851 Invoke gzip -cd rather than gunzip, as it's more portable.
3852 (lock_info_type, lock_file_1, lock_file):
3853 Don't assume pid_t and time_t fit in unsigned long.
3854 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3855 (current_lock_owner): Prefer signed type for sizes.
3856 Use memcpy, not strncpy, where memcpy is what is really wanted.
3857 Don't assume (via atoi) that time_t and pid_t fit in int.
3858 Check for time_t and/or pid_t out of range, e.g., via a network share.
3859 Don't alloca where an auto var works fine.
3860
93f4cf88
PE
3861 * fileio.c: Fix some integer overflow issues.
3862 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3863 Don't assume string length fits in int.
3864 (directory_file_name): Don't assume string length fits in long.
3865 (make_temp_name): Don't assume pid fits in int, or that its print
3866 length is less than 20.
3867
f3e92b69
PE
3868 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3869
1bfdaf10
PE
3870 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3871
35016e9a
PE
3872 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3873
3d1e65a1
PE
3874 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3875 We prefer signed integers, even for size calculations.
3876
0b963a93
PE
3877 * emacs.c: Don't assume string length fits in 'int'.
3878 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3879 (main): Don't invoke strlen when not needed.
3880
573f4b54
PE
3881 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3882 (XD_DEBUG_MESSAGE): Don't waste a byte.
3883
989f33ba
PE
3884 * callproc.c (getenv_internal_1, getenv_internal)
3885 (Fgetenv_internal):
965d34eb
PE
3886 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3887
e4d29b33
PE
3888 * lread.c (invalid_syntax): Omit length argument.
3889 All uses changed. This doesn't fix a bug, but it simplifies the
3890 code away from its former Hollerith-constant appearance, and it's
3891 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3892 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3893
eb49b136
PE
3894 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3895 This didn't break anything, but it didn't help either.
3896 It's confusing to put a bogus integer in a place where the actual
3897 value does not matter.
9f62aeb1 3898 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3899 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3900
15375a22
PE
3901 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3902 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3903 implementation.
b61cc01c
PE
3904 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3905 We prefer signed types, and the value cannot exceed the EMACS_INT
3906 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3907 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3908 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3909 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3910
53b2623d
PE
3911 * indent.c (sane_tab_width): New function.
3912 (current_column, scan_for_column, Findent_to, position_indentation)
3913 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3914 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3915
51cab52b 3916 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3917
f2ed8a70
PE
3918 * lisp.h (lint_assume): New macro.
3919 * composite.c (composition_gstring_put_cache):
3920 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3921
abe80cc6
PE
3922 * editfns.c, insdel.c:
3923 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3924
b02c740e
PE
3925 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3926
ebc96716
PE
3927 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3928
b4e50fa0 3929 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3930 Use much-faster test for byte-length change.
311d5d7c 3931 Don't assume string byte-length fits in 'int'.
a4cf38e4 3932 Check that character arg fits in 'int'.
85461888 3933 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3934
c0c1ee9f
PE
3935 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3936
a498d7f4
PE
3937 * fns.c (concat): Catch string overflow earlier.
3938 Do not rely on integer wraparound.
3939
51cab52b
PE
3940 * dispextern.h (struct it.overlay_strings_charpos)
3941 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3942 * xdisp.c (forward_to_next_line_start)
3943 (back_to_previous_visible_line_start)
3944 (reseat_at_next_visible_line_start, next_element_from_buffer):
3945 Don't arbitrarily truncate the value of 'selective' to int.
3946
76031fad
PE
3947 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3948
5eb55db9
PE
3949 * composite.c: Don't truncate sizes to 'int'.
3950 (composition_gstring_p, composition_reseat_it)
3951 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3952 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3953 not EMACS_UINT, for indexes.
5eb55db9 3954
0703a717
PE
3955 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3956
d6202519
PE
3957 * buffer.c: Include <verify.h>.
3958 (struct sortvec.priority, struct sortstr.priority):
8961a454 3959 Now EMACS_INT, not int.
c20998a7 3960 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3961 (struct sortstr.size, record_overlay_string)
3962 (struct sortstrlist.size, struct sortlist.used):
3963 Don't truncate size to int.
3964 (record_overlay_string): Check for size-calculation overflow.
d6202519 3965 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3966
d5a19415
JM
39672011-06-22 Jim Meyering <meyering@redhat.com>
3968
029529ac 3969 Don't leak an XBM-image-sized buffer
d5a19415
JM
3970 * image.c (xbm_load): Free the image buffer after using it.
3971
a9041e6c
PE
39722011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3973
3974 Port to Sun C.
3975 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3976 that Sun C diagnosed.
3977 * fns.c (secure_hash): Fix pointer signedness issue.
3978 * intervals.c (static_offset_intervals): New function.
3979 (offset_intervals): Use it.
3980
7f3f739f
LL
39812011-06-21 Leo Liu <sdl.web@gmail.com>
3982
3983 * deps.mk (fns.o):
3984 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3985 sha512.h.
3986
3987 * fns.c (secure_hash): Rename from crypto_hash_function and change
3988 the first arg to accept symbols.
5b66d427 3989 (Fsecure_hash): New primitive.
7f3f739f
LL
3990 (syms_of_fns): New symbols.
3991
76147d94
DD
39922011-06-20 Deniz Dogan <deniz@dogan.se>
3993
3994 * process.c (Fset_process_buffer): Clarify return value in
3995 docstring.
3996
7d7d0045
CY
39972011-06-18 Chong Yidong <cyd@stupidchicken.com>
3998
3999 * dispnew.c (add_window_display_history): Use BVAR.
4000
4001 * xdisp.c (debug_method_add): Use BVAR.
4002 (check_window_end, dump_glyph_matrix, dump_glyph)
4003 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4004
4005 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4006 Likewise.
4007
4008 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4009 check till after the cache is created in init_frame_faces.
4010
ff2bc410
SM
40112011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4012
4013 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4014
28177add
PE
40152011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4016
dd3482fe
PE
4017 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4018 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4019 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4020
393d71f3 4021 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4022 * fileio.c (Finsert_file_contents):
4023 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4024 Remove the old (too-loose) buffer overflow checks.
4025 They weren't needed, since make_gap checks for buffer overflow.
4026 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4027 The old code merely checked for Emacs fixnum overflow, and relied
4028 on undefined (wraparound) behavior. The new code avoids undefined
4029 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4030
2e6813b0 4031 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4032 Tune. Don't use wider integers than needed. Don't use alloca.
4033 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4034
599a9e4f
PE
4035 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4036
99561444
PE
4037 * insdel.c, lisp.h (buffer_overflow): New function.
4038 (insert_from_buffer_1, replace_range, replace_range_2):
4039 * insdel.c (make_gap_larger):
4040 * editfns.c (Finsert_char):
4041 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4042
28177add
PE
4043 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4044
e69dafad
PE
40452011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4046
a7af7fde 4047 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4048
b1c46f02
PE
4049 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4050 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4051
e69dafad
PE
4052 * fileio.c: Don't assume EMACS_INT fits in off_t.
4053 (emacs_lseek): New static function.
4054 (Finsert_file_contents, Fwrite_region): Use it.
4055 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4056
566684ea
PE
4057 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4058
e6966cd6
PE
4059 * fns.c: Don't overflow int when computing a list length.
4060 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4061 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4062 truncation on 64-bit hosts. Check for QUIT every
4063 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4064 faster and is responsive enough.
4065 (Flength): Report an error instead of overflowing an integer.
4066 (Fsafe_length): Return a float if the value is not representable
4067 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4068 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4069 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4070
dd0b0efb
PE
4071 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4072 (header_size, word_size): New constants.
4073 (allocate_vectorlike): Don't check size overflow here.
4074 (allocate_vector): Check it here instead, since this is the only
4075 caller of allocate_vectorlike that could cause overflow.
4076 Check that the new vector's length is representable as a fixnum.
4077
86fe5cfe
PE
4078 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4079 The previous code was bogus. For example, next_almost_prime (32)
4080 returned 39, which is undesirable as it is a multiple of 3; and
4081 next_almost_prime (24) returned 25, which is a multiple of 5 so
4082 why was the code bothering to check for multiples of 7?
4083
80e88859
PE
4084 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4085
4a2f0ad6
PE
4086 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4087
f66c7cf8
PE
4088 Variadic C functions now count arguments with ptrdiff_t.
4089 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4090 Back then I didn't know that the Emacs coding style prefers signed int.
4091 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4092 were being counted with int, which may truncate counts on 64-bit
4093 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4094 * lisp.h (struct Lisp_Subr.function.aMANY)
4095 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4096 Arg counts are now ptrdiff_t, not size_t.
4097 All variadic functions and their callers changed accordingly.
4098 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4099 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4100 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4101 * callint.c (Fcall_interactively): Check arg count for overflow,
4102 to avoid potential buffer overrun. Use signed char, not 'int',
4103 for 'varies' array, so that we needn't bother to check its size
4104 calculation for overflow.
4105 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4106 * eval.c (apply_lambda):
4107 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4108 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4109 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4110
a1759b76
PE
4111 * callint.c (Fcall_interactively): Don't use index var as event count.
4112
d96be9fc
PE
4113 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4114 * mem-limits.h (SIZE): Remove; no longer used.
4115
a690a978 4116 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4117
578c21e6
PE
4118 Remove unnecessary casts.
4119 * xterm.c (x_term_init):
4120 * xfns.c (x_set_border_pixel):
4121 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4122 These aren't needed now that we assume ANSI C.
4123
96f53c6c
PE
4124 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4125 It's more likely to cause problems (due to unsigned overflow)
4126 than to cure them.
4127
83c77d31
PE
4128 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4129
ee2079f1
PE
4130 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4131
6da65536
PE
4132 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4133
7147c4a4
PE
4134 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4135
193e32d9
PE
4136 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4137
e5533da6
PE
4138 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4139
9910e595
PE
4140 GLYPH_CODE_FACE returns EMACS_INT, not int.
4141 * dispextern.h (merge_faces):
4142 * xfaces.c (merge_faces):
01103c44
PE
4143 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4144 Don't assume EMACS_INT fits in int.
9910e595 4145
2638320e
PE
4146 * character.h (CHAR_VALID_P): Remove unused parameter.
4147 * fontset.c, lisp.h, xdisp.c: All uses changed.
4148
045eb8d9
PE
4149 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4150
c1f134b5
PE
4151 * fns.c (concat): Minor tuning based on overflow analysis.
4152 This doesn't fix any bugs. Use int to hold character, instead
4153 of constantly refetching from Emacs object. Use XFASTINT, not
4154 XINT, for value known to be a character. Don't bother comparing
4155 a single byte to 0400, as it's always less.
4156
395fcb93 4157 * floatfns.c (Fexpt):
327eeec8
PE
4158 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4159
abbd3d23
PE
4160 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4161 for characters.
4162
684a03ef
PE
4163 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4164
0fed43f3
PE
4165 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4166 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4167 incorrectly succeed when S was a string, because 4294967386 was
4168 truncated before it was used.
4169
8fd02eb7
PE
4170 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4171 Otherwise, an out-of-range integer could cause undefined behavior
4172 on a 64-bit host.
4173
f8c86b69
PE
4174 * composite.c: Use int, not EMACS_INT, for characters.
4175 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4176 EMACS_INT, for values that are known to be in character range.
4177 This doesn't fix any bugs but is the usual style inside Emacs and
4178 may generate better code on 32-bit machines.
4179
34206dd2
PE
4180 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4181 This is for reasons similar to the recent CHAR_STRING fix.
4182 * charset.c (Fencode_char): Check that character arg is actually
4183 a character. Pass an int to ENCODE_CHAR.
4184 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4185 wider than 'int', as a compile-time check to prevent future regressions
4186 in this area.
4187
c5958d4c 4188 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4189
4190 Make sure a 64-bit char is never passed to CHAR_STRING.
4191 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4192 by silently ignoring the top 32 bits, allowing some values
4193 that were far too large to be valid characters.
4194 * character.h: Include <verify.h>.
4195 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4196 arguments are no wider than unsigned, as a compile-time check
4197 to prevent future regressions in this area.
4198 * data.c (Faset):
01103c44 4199 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4200 (Fsubst_char_in_region):
4201 * fns.c (concat):
4202 * xdisp.c (decode_mode_spec_coding):
4203 Adjust to CHAR_STRING's new requirement.
4204 * editfns.c (Finsert_char, Fsubst_char_in_region):
4205 * fns.c (concat): Check that character args are actually
4206 characters. Without this test, these functions did the wrong
4207 thing with wildly out-of-range values on 64-bit hosts.
4208
d37ca623
PE
4209 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4210 These casts should not be needed on 32-bit hosts, either.
4211 * keyboard.c (read_char):
4212 * lread.c (Fload): Remove casts to unsigned.
4213
ea204efb
PE
4214 * lisp.h (UNSIGNED_CMP): New macro.
4215 This fixes comparison bugs on 64-bit hosts.
4216 (ASCII_CHAR_P): Use it.
4217 * casefiddle.c (casify_object):
01103c44 4218 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4219 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4220 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4221 * dispextern.h (FACE_FROM_ID):
4222 * keyboard.c (read_char): Use UNSIGNED_CMP.
4223
41cb286c
PE
4224 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4225 not to EMACS_INT, to avoid GCC warning.
4226
4a1b9832
PE
4227 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4228
55daad71
PE
4229 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4230 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4231 isn't needed on 32-bit machines.
8f95c75c 4232
01103c44
PE
4233 * buffer.c (Fgenerate_new_buffer_name):
4234 Use EMACS_INT for count, not int.
0ceccced 4235 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4236
4237 * data.c (Qcompiled_function): Now static.
4238
c6f072e7
PE
4239 * window.c (window_body_lines): Now static.
4240
20ce5912
PE
4241 * image.c (gif_load): Rename local to avoid shadowing.
4242
9c4c5f81
PE
4243 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4244 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4245 * alloc.c (make_save_value): Integer argument is now of type
4246 ptrdiff_t, not int.
4247 (mark_object): Use ptrdiff_t, not int.
4248 * lisp.h (pD): New macro.
4249 * print.c (print_object): Use it.
4250
c0c5c8ae
PE
4251 * alloc.c: Use EMACS_INT, not int, to count objects.
4252 (total_conses, total_markers, total_symbols, total_vector_size)
4253 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4254 (total_free_floats, total_floats, total_free_intervals)
4255 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4256 Now EMACS_INT, not int. All uses changed.
4257 (Fgarbage_collect): Compute overall total using a double, so that
4258 integer overflow is less likely to be a problem. Check for overflow
4259 when converting back to an integer.
5a25e253
PE
4260 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4261 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4262 These were 'int' variables that could overflow on 64-bit hosts;
4263 they were never used, so remove them instead of repairing them.
211a0b2a 4264 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4265 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4266 Previously, this ceilinged at INT_MAX, but that doesn't work on
4267 64-bit machines.
e46bb31a 4268 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4269
c78baabf 4270 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4271 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4272 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4273 when a (possibly-narrower) signed value would do just as well.
4274 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4275
c9d624c6
PE
4276 * alloc.c: Catch some string size overflows that we were missing.
4277 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4278 for convenience in STRING_BYTES_MAX.
4279 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4280 The definition here is exact; the one in lisp.h was approximate.
4281 (allocate_string_data): Check for string overflow. This catches
4282 some instances we weren't catching before. Also, it catches
4283 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4284 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4285 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4286
c9d624c6
PE
4287 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4288 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4289 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4290
353032ce
PE
4291 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4292
2bccce07
PE
4293 * alloc.c (Fmake_string): Check for out-of-range init.
4294
0ac30604
SM
42952011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4296
4297 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4298
c195f2de
JD
42992011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4300
4301 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4302 xg_get_default_scrollbar_width.
4303
4304 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4305 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4306 (style_changed_cb): Call update_theme_scrollbar_width and call
4307 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4308 all frames (Bug#8505).
4309 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4310 Call gtk_window_set_resizable if HAVE_GTK3.
4311 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4312 and height if HAVE_GTK3 (Bug#8505).
4313 (scroll_bar_width_for_theme): New variable.
4314 (update_theme_scrollbar_width): New function.
4315 (xg_get_default_scrollbar_width): Move code to
4316 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4317 (xg_initialize): Call update_theme_scrollbar_width.
4318
4319 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4320
4321 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4322
e10ac9f1
MR
43232011-06-12 Martin Rudalics <rudalics@gmx.at>
4324
4325 * frame.c (make_frame): Call other_buffer_safely instead of
4326 other_buffer.
4327
4328 * window.c (temp_output_buffer_show): Call display_buffer with
4329 second argument Vtemp_buffer_show_specifiers and reset latter
4330 immediately after the call.
4331 (Vtemp_buffer_show_specifiers): New variable.
4332 (auto_window_vscroll_p, next_screen_context_lines)
4333 (Vscroll_preserve_screen_position): Remove leading asterisks from
4334 doc-strings.
4335
2d3c217e 43362011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4337
7b7f97e8 4338 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4339 * buffer.c (Qclone_number): Remove for now, as it's unused.
4340 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4341 (record_buffer): Remove unused local.
4342 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4343 (set_frame_buffer_list): Remove; unused.
4344 * frame.h (other_visible_frames): Remove decl.
4345 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4346 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4347 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4348 if HAVE_GPM.
4349 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4350 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4351 Define only if HAVE_GPM.
4352 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4353 (update_hints_inhibit): Remove; never set. All uses removed.
4354 * widgetprv.h (emacsFrameClassRec): Remove decl.
4355 * window.c (delete_deletable_window): Now returns void, since it
4356 wasn't returning anything.
4357 (compare_window_configurations): Remove unused locals.
4358 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4359 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4360 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4361 the same widths as pointers. This follows up on the 2011-05-06 patch.
4362 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4363 * xterm.h: Likewise.
4364 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4365
1384b89e
JB
43662011-06-12 Juanma Barranquero <lekktu@gmail.com>
4367
4368 * makefile.w32-in: Update dependencies.
4369 (LISP_H): Add lib/intprops.h.
4370
1100a63c
CY
43712011-06-11 Chong Yidong <cyd@stupidchicken.com>
4372
4373 * image.c (gif_load): Add animation frame delay to the metadata.
4374 (syms_of_image): Use DEFSYM. New symbol `delay'.
4375
6198ccd0
MR
43762011-06-11 Martin Rudalics <rudalics@gmx.at>
4377
4378 * window.c (delete_deletable_window): Re-add.
4379 (Fset_window_configuration): Rewrite to handle dead buffers and
4380 consequently deletable windows.
4381 (window_tree, Fwindow_tree): Remove. Supply functionality in
4382 window.el.
4383 (compare_window_configurations): Simplify code.
4384
b6e3633c
AS
43852011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4386
1ab0dee5
AS
4387 * image.c (imagemagick_load_image): Fix type mismatch.
4388 (Fimagemagick_types): Likewise.
4389
b6e3633c
AS
4390 * window.h (replace_buffer_in_windows): Declare.
4391
9397e56f
MR
43922011-06-11 Martin Rudalics <rudalics@gmx.at>
4393
4394 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4395 Qclone_number. Remove external declaration of Qdelete_window.
4396 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4397 code.
640c8776
SM
4398 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4399 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4400 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4401 buffer list implementation.
4402 (other_buffer_safely): New function.
4403 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4404 calls to replace_buffer_in_windows and
4405 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4406 if allowed.
4407 (record_buffer): Inhibit quitting and rewrite using quittable
4408 functions. Run Qbuffer_list_update_hook if allowed.
4409 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4410 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4411 Move switch-to-buffer to window.el.
9397e56f
MR
4412 (bury-buffer): Move to window.el.
4413 (Vbuffer_list_update_hook): New variable.
4414
4415 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4416 section.
4417
4418 * window.h (resize_frame_windows): Move up in code.
4419 (Fwindow_frame): Remove EXFUN.
4420 (replace_buffer_in_all_windows): Remove prototype.
4421 (replace_buffer_in_windows_safely): Add prototype.
4422
4423 * window.c: Declare Qdelete_window static again. Move down
4424 declaration of select_count.
4425 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4426 (Fother_window): Move to window.el.
4427 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4428 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4429 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4430 window.el.
4431 (replace_buffer_in_windows): Implement by calling
4432 Qreplace_buffer_in_windows.
4433 (replace_buffer_in_all_windows): Remove with some functionality
4434 moved into replace_buffer_in_windows_safely.
4435 (replace_buffer_in_windows_safely): New function.
4436 (select_window_norecord, select_frame_norecord): Move in front
4437 of run_window_configuration_change_hook. Remove now obsolete
4438 declarations.
640c8776
SM
4439 (Fset_window_buffer): Rewrite doc-string.
4440 Call Qrecord_window_buffer.
9397e56f
MR
4441 (keys_of_window): Move binding for other-window to window.el.
4442
b50691aa
CY
44432011-06-11 Chong Yidong <cyd@stupidchicken.com>
4444
4445 * dispextern.h (struct image): Replace data member, whose int_val
4446 and ptr_val fields were not used by anything, with a single
4447 lisp_val object.
4448
4449 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4450 (gif_clear_image, gif_load, imagemagick_load_image)
4451 (gs_clear_image, gs_load): Callers changed.
4452
3f754b86
PE
44532011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4454
cca69397
PE
4455 * buffer.h: Include <time.h>, for time_t.
4456 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4457
109e28d0
PE
4458 Fix minor problems found by static checking.
4459
60737f02
PE
4460 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4461
4b66faf3
PE
4462 Make identifiers static if they are not used in other modules.
4463 * data.c (Qcompiled_function, Qframe, Qvector):
4464 * image.c (QimageMagick, Qsvg):
4465 * minibuf.c (Qmetadata):
4466 * window.c (resize_window_check, resize_root_window): Now static.
4467 * window.h (resize_window_check, resize_root_window): Remove decls.
4468
109e28d0
PE
4469 * window.c (window_deletion_count, delete_deletable_window):
4470 Remove; unused.
46a4ce9e
PE
4471 (window_body_lines): Now static.
4472 (Fdelete_other_windows_internal): Mark vars as initialized.
4473 Make sure 'resize_failed' is initialized.
4474 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4475 (resize_window_apply): Remove unused local.
4476 * window.h (delete_deletable_window): Remove decl.
4477
109e28d0 4478 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4479 (imagemagick_load_image): Fix pointer signedness problem by changing
4480 last arg from unsigned char * to char *. All uses changed.
4481 Also, fix a local for similar reasons.
4482 Remove unused locals. Remove locals to avoid shadowing.
4483 (fn_rsvg_handle_free): Remove; unused.
4484 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4485 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4486
3f754b86
PE
4487 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4488
2547adb1
CY
44892011-06-10 Chong Yidong <cyd@stupidchicken.com>
4490
4491 * image.c (gif_load): Fix omitted cast error introduced by
4492 2011-06-06 change.
4493
2c8e37d4
MR
44942011-06-10 Martin Rudalics <rudalics@gmx.at>
4495
4496 * window.h (resize_proportionally, orig_total_lines)
4497 (orig_top_line): Remove from window structure.
4498 (set_window_height, set_window_width, change_window_heights)
4499 (Fdelete_window): Remove prototypes.
4500 (resize_frame_windows): Remove duplicate declaration.
4501
440a42e3
EZ
45022011-06-10 Eli Zaretskii <eliz@gnu.org>
4503
4504 * window.h (resize_frame_windows, resize_window_check)
4505 (delete_deletable_window, resize_root_window)
4506 (resize_frame_windows): Declare prototypes.
4507
4508 * window.c (resize_window_apply): Make definition be "static" to
4509 match the prototype.
4510
562dd5e9
MR
45112011-06-10 Martin Rudalics <rudalics@gmx.at>
4512
4513 * window.c: Remove declarations of Qwindow_size_fixed,
4514 window_min_size_1, window_min_size_2, window_min_size,
4515 size_window, window_fixed_size_p, enlarge_window, delete_window.
4516 Remove static from declaration of Qdelete_window, it's
4517 temporarily needed by Fbury_buffer.
4518 (replace_window): Don't assign orig_top_line and
4519 orig_total_lines.
4520 (Fdelete_window, delete_window): Remove. Window deletion is
4521 handled by window.el.
640c8776
SM
4522 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4523 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4524 (Fdelete_other_windows): Remove. Deleting other windows is
4525 handled by window.el.
4526 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4527 handled in window.el.
4528 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4529 Window minimum sizes are handled in window.el.
4530 (shrink_windows, size_window, set_window_height)
4531 (set_window_width, change_window_heights, window_height)
4532 (window_width, CURBEG, CURSIZE, enlarge_window)
4533 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4534 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4535 handled in window.el.
4536 (make_dummy_parent): Rename to make_parent_window and give it a
4537 second argument horflag.
4538 (make_window): Don't set resize_proportionally any more.
4539 (Fsplit_window): Remove. Windows are split in window.el.
4540 (save_restore_action, save_restore_orig_size)
4541 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4542 Resize mini windows in window.el.
4543 (grow_mini_window, shrink_mini_window): Implement by calling
4544 Qresize_root_window_vertically, resize_window_check and
4545 resize_window_apply.
640c8776
SM
4546 (saved_window, Fset_window_configuration, save_window_save):
4547 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4548 resize_proportionally.
4549 (window_min_height, window_min_width): Move to window.el.
4550 (keys_of_window): Move bindings for delete-other-windows,
4551 split-window, delete-window and enlarge-window to window.el.
4552
4553 * buffer.c: Temporarily extern Qdelete_window.
4554 (Fbury_buffer): Temporarily call Qdelete_window instead of
4555 Fdelete_window (Fbury_buffer will move to window.el soon).
4556
4557 * frame.c (set_menu_bar_lines_1): Remove code handling
4558 orig_top_line and orig_total_lines.
4559
4560 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4561 set_window_height but set heights directly.
4562 (change_frame_size_1): Use resize_frame_windows.
4563
4564 * xdisp.c (init_xdisp): Don't use set_window_height but set
4565 heights directly.
4566
640c8776
SM
4567 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4568 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4569 run_window_configuration_change_hook.
4570
4571 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4572 instead of change_window_heights and run
4573 run_window_configuration_change_hook.
4574
1a13852e
MR
45752011-06-09 Martin Rudalics <rudalics@gmx.at>
4576
4577 * window.c (replace_window): Rename second argument REPLACEMENT to
4578 NEW. New third argument SETFLAG. Rewrite.
4579 (delete_window, make_dummy_parent): Call replace_window with
4580 third argument 1.
4581 (window_list_1): Move down in code.
4582 (run_window_configuration_change_hook): Move set_buffer part
4583 before select_frame_norecord part in order to unwind correctly.
4584 Rename count1 to count.
4585 (recombine_windows, delete_deletable_window, resize_root_window)
4586 (Fdelete_other_windows_internal)
4587 (Frun_window_configuration_change_hook, make_parent_window)
4588 (resize_window_check, resize_window_apply, Fresize_window_apply)
4589 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4590 (Fdelete_window_internal, Fresize_mini_window_internal):
4591 New functions.
1a13852e
MR
4592 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4593
f3d1777e
MR
45942011-06-08 Martin Rudalics <rudalics@gmx.at>
4595
496e208e
MR
4596 * window.h (window): Add some new members to window structure -
4597 normal_lines, normal_cols, new_total, new_normal, clone_number,
4598 splits, nest, prev_buffers, next_buffers.
4599 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4600 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4601
f3d1777e
MR
4602 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4603 Remove.
496e208e
MR
4604 (make_dummy_parent): Set new members of windows structure.
4605 (make_window): Move down in code. Handle new members of window
4606 structure.
4607 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4608 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4609 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4610 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4611 (Fset_window_next_buffers, Fset_window_clone_number):
4612 New functions.
496e208e
MR
4613 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4614 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4615 Doc-string fixes.
4616 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4617 Argument WINDOW can be now internal window too.
4618 (Fwindow_use_time): Move up in code.
4619 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4620 Rewrite doc-string.
4621 (Fset_window_configuration, saved_window)
4622 (Fcurrent_window_configuration, save_window_save): Handle new
4623 members of window structure.
b9e809c2
MR
4624 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4625 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4626 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4627 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4628 Qget_mru_window, Qresize_root_window,
4629 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4630 Qauto_buffer_name; staticpro them.
f3d1777e 4631
abde8f8c
MR
46322011-06-07 Martin Rudalics <rudalics@gmx.at>
4633
4634 * window.c (Fwindow_total_size, Fwindow_left_column)
4635 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4636 (Fwindow_list_1): New functions.
4637 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4638 (Fwindow_width, Fscroll_left, Fscroll_right):
4639 Use window_body_cols instead of window_box_text_cols.
4640 (delete_window, Fset_window_configuration):
4641 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4642 (delete_all_subwindows): Take a window as argument and not a
4643 structure. Rewrite.
190b47e6
MR
4644 (window_loop): Remove handling of GET_LRU_WINDOW and
4645 GET_LARGEST_WINDOW.
4646 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4647
4648 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4649 window_box_text_cols. delete_all_subwindows now takes a
4650 Lisp_Object as argument.
abde8f8c 4651
640c8776
SM
4652 * indent.c (compute_motion, Fcompute_motion):
4653 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4654
fa8a67e6
MR
4655 * frame.c (delete_frame): Call delete_all_subwindows with root
4656 window as argument.
4657
a54e3482
DC
46582011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4659
4660 * fns.c (Fputhash): Document return value.
4661
60002bf5
CY
46622011-06-06 Chong Yidong <cyd@stupidchicken.com>
4663
4664 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4665
0c671da6 46662011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4667
b862a52a 4668 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4669
be44ca6c
PE
4670 Check for overflow when converting integer to cons and back.
4671 * charset.c (Fdefine_charset_internal, Fdecode_char):
4672 Use cons_to_unsigned to catch overflow.
4673 (Fencode_char): Use INTEGER_TO_CONS.
4674 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4675 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4676 * data.c (long_to_cons, cons_to_long): Remove.
4677 (cons_to_unsigned, cons_to_signed): New functions.
4678 These signal an error for invalid or out-of-range values.
4679 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4680 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4681 * font.c (Ffont_variation_glyphs):
4682 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4683 * lisp.h: Include <intprops.h>.
4684 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4685 (cons_to_signed, cons_to_unsigned): New decls.
4686 (long_to_cons, cons_to_long): Remove decls.
4687 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4688 (Fprimitive_undo): Use CONS_TO_INTEGER.
4689 * xfns.c (Fx_window_property): Likewise.
4690 * xselect.c: Include <limits.h>.
4691 (x_own_selection, selection_data_to_lisp_data):
4692 Use INTEGER_TO_CONS.
4693 (x_handle_selection_request, x_handle_selection_clear)
4694 (x_get_foreign_selection, Fx_disown_selection_internal)
4695 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4696 (lisp_data_to_selection_data): Use cons_to_unsigned.
4697 (x_fill_property_data): Use cons_to_signed.
4698 Report values out of range.
4699
d1f3d2af
PE
4700 Check for buffer and string overflow more precisely.
4701 * buffer.h (BUF_BYTES_MAX): New macro.
4702 * lisp.h (STRING_BYTES_MAX): New macro.
4703 * alloc.c (Fmake_string):
4704 * character.c (string_escape_byte8):
4705 * coding.c (coding_alloc_by_realloc):
4706 * doprnt.c (doprnt):
4707 * editfns.c (Fformat):
4708 * eval.c (verror):
4709 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4710 since they may not be the same number.
4711 * editfns.c (Finsert_char):
4712 * fileio.c (Finsert_file_contents):
4713 Likewise for BUF_BYTES_MAX.
4714
dd52fcea
PE
4715 * image.c: Use ptrdiff_t, not int, for sizes.
4716 (slurp_file): Switch from int to ptrdiff_t.
4717 All uses changed.
4718 (slurp_file): Check that file size fits in both size_t (for
4719 malloc) and ptrdiff_t (for sanity and safety).
4720
7f9bbdbb
PE
4721 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4722 if b->modtime has its maximal value.
4723
dfe18f82
PE
4724 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4725
84acfcf0
PE
4726 Don't assume time_t can fit into int.
4727 * buffer.h (struct buffer.modtime): Now time_t, not int.
4728 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4729 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4730
ccd9a01a
PE
4731 Minor fixes for signed vs unsigned integers.
4732 * character.h (MAYBE_UNIFY_CHAR):
4733 * charset.c (maybe_unify_char):
4734 * keyboard.c (read_char, reorder_modifiers):
4735 XINT -> XFASTINT, since the integer must be nonnegative.
4736 * ftfont.c (ftfont_spec_pattern):
4737 * keymap.c (access_keymap, silly_event_symbol_error):
4738 XUINT -> XFASTINT, since the integer must be nonnegative.
4739 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4740 since it makes no difference and we prefer signed.
4741 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4742 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4743 nonnegative.
4744
d6d100dd
SM
47452011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4746
4747 * window.h (Fwindow_frame): Declare.
4748
2b6148e4
PE
47492011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4750
4751 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4752 (SPARE_MEMORY): Always define.
4753 (LARGE_REQUEST): Remove.
4754 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4755
f230ecc9
MR
47562011-06-06 Martin Rudalics <rudalics@gmx.at>
4757
727e958e
MR
4758 * lisp.h: Move EXFUNS for Fframe_root_window,
4759 Fframe_first_window and Fset_frame_selected_window to window.h.
4760
4761 * window.h: Move EXFUNS for Fframe_root_window,
4762 Fframe_first_window and Fset_frame_selected_window here from
4763 lisp.h.
4764
4765 * frame.c (Fwindow_frame, Fframe_first_window)
4766 (Fframe_root_window, Fframe_selected_window)
4767 (Fset_frame_selected_window): Move to window.c.
4768 (Factive_minibuffer_window): Move to minibuf.c.
4769 (Fother_visible_frames_p): New function.
4770
4771 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4772
f230ecc9
MR
4773 * window.c (decode_window, decode_any_window): Move up in code.
4774 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4775 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4776 (Fwindow_buffer): Move up and rewrite doc-string.
4777 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4778 (Fwindow_prev): New functions.
727e958e
MR
4779 (Fwindow_frame): Move here from frame.c. Accept any window as
4780 argument.
4781 (Fframe_root_window, Fframe_first_window)
4782 (Fframe_selected_window): Move here from frame.c. Accept frame
4783 or arbitrary window as argument. Update doc-strings.
4784 (Fminibuffer_window): Move up in code.
4785 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4786 (Fset_frame_selected_window): Move here from frame.c.
4787 Marginal rewrite.
727e958e
MR
4788 (Fselected_window, select_window, Fselect_window): Move up in
4789 code. Minor doc-string fixes.
f230ecc9 4790
4d09bcf6
PE
47912011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4792
4793 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4794 Do not assume that spare memory exists; that assumption is valid
4795 only if SYSTEM_MALLOC.
4796 (LARGE_REQUEST): New macro, so that the issue of large requests
4797 is separated from the issue of spare memory.
4798
810928a2
AS
47992011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4800
172418ad
AS
4801 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4802 format. (Bug#8806)
4803
43f862f7
AS
4804 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4805
810928a2
AS
4806 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4807 before statements.
4808
a059fe24
JD
48092011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4810
4811 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4812
4813 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4814
4815 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4816 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4817
989bf368
JB
48182011-06-05 Juanma Barranquero <lekktu@gmail.com>
4819
4820 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4821
4b80f674
CY
48222011-06-04 Chong Yidong <cyd@stupidchicken.com>
4823
4824 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4825 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4826 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4827 New error handlers.
4b80f674
CY
4828 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4829 Obey Vx_select_enable_clipboard_manager. Catch errors in
4830 x_clipboard_manager_save (Bug#8779).
4831 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4832 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4833
99a33b77 48342011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4835
4836 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4837
99a33b77 48382011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4839
4840 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4841 in the current matrix if keep_current_p is non-zero.
4842
8264569d
EZ
48432011-06-04 Eli Zaretskii <eliz@gnu.org>
4844
4845 * bidi.c (bidi_level_of_next_char): Fix last change.
4846
57f97249
EZ
48472011-06-03 Eli Zaretskii <eliz@gnu.org>
4848
fec2107c 4849 Support bidi reordering of text covered by display properties.
57f97249 4850
fec2107c
EZ
4851 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4852 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4853 (bidi_cache_search, bidi_cache_iterator_state)
4854 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4855 (bidi_level_of_next_char, bidi_move_to_visually_next):
4856 Support character positions inside a run of characters covered by a
fec2107c
EZ
4857 display string.
4858 (bidi_paragraph_init, bidi_resolve_explicit_1)
4859 (bidi_level_of_next_char): Call bidi_fetch_char and
4860 bidi_fetch_char_advance instead of FETCH_CHAR and
4861 FETCH_CHAR_ADVANCE.
4862 (bidi_init_it): Initialize new members.
4863 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4864 definitions.
4865 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4866 instead of using explicit *_CHAR codes.
d6d100dd
SM
4867 (bidi_resolve_explicit, bidi_resolve_weak):
4868 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4869 bidirectional text is supported only in multibyte buffers.
4870 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4871 it to initialize the frame_window_p member of struct bidi_it.
4872 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4873 (bidi_resolve_explicit, bidi_resolve_weak)
4874 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4875 bidi_it->nchars is non-positive.
4876 (bidi_level_of_next_char): Don't try to lookup the cache for the
4877 next/previous character if nothing is cached there yet, or if we
4878 were just reseat()'ed to a new position.
c40e2fb2 4879
0e14fe90
EZ
4880 * xdisp.c (set_cursor_from_row): Set start and stop points
4881 according to the row's direction when priming the loop that looks
4882 for the glyph on which to display cursor.
4883 (single_display_spec_intangible_p): Function deleted.
4884 (display_prop_intangible_p): Reimplement to call
4885 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4886 Accept 3 additional arguments needed by handle_display_spec.
4887 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4888 values: lists, `(when COND...)' forms, etc.
4889 (single_display_spec_string_p): Support property values that are
4890 lists with the argument STRING its top-level element.
4891 (display_prop_string_p): Fix the condition for processing a
4892 property that is a list to be consistent with handle_display_spec.
fec2107c 4893 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4894 last portion of handle_display_prop.
4895 (compute_display_string_pos): Accept additional argument
4896 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4897 value of a `display' property is a "replacing spec".
4898 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4899 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4900 the display property, but just return a value indicating whether
4901 the display property will replace the characters it covers.
4902 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4903 frame_window_p members of struct bidi_it.
d6d100dd
SM
4904 (compute_display_string_pos, compute_display_string_end):
4905 New functions.
fec2107c
EZ
4906 (push_it): Accept second argument POSITION, where pop_it should
4907 jump to continue iteration.
4908 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4909
fec2107c
EZ
4910 * keyboard.c (adjust_point_for_property): Adjust the call to
4911 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4912
4913 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4914 (bidi_init_it): Update prototypes.
4915 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4916 (compute_display_string_pos, compute_display_string_end):
4917 Declare prototypes.
fec2107c
EZ
4918 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4919 EMACS_INT.
fc6f18ce 4920
40087514 49212011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4922
57f53182
PE
4923 Malloc failure behavior now depends on size of allocation.
4924 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4925 * lisp.h: Change signatures accordingly.
4926 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4927 All callers changed. (Bug#8762)
4928
4929 * gnutls.c: Use Emacs's memory allocators.
4930 Without this change, the gnutls library would invoke malloc etc.
4931 directly, which causes problems on non-SYNC_INPUT hosts, and which
4932 runs afoul of improving memory_full behavior. (Bug#8761)
4933 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4934 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4935 xfree instead of the default malloc, realloc, free.
4936 (Fgnutls_boot): No need to check for memory allocation failure,
4937 since xmalloc does that for us.
4938
ac32cd99 4939 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4940 * category.c (hash_get_category_set):
4941 * ccl.c (ccl_driver):
4942 * charset.c (Fdefine_charset_internal):
4943 * charset.h (struct charset.hash_index):
4944 * composite.c (get_composition_id, gstring_lookup_cache)
4945 (composition_gstring_put_cache):
4946 * composite.h (struct composition.hash_index):
4947 * dispextern.h (struct image.hash):
4948 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4949 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4950 (hashfn_equal, hashfn_user_defined, make_hash_table)
4951 (maybe_resize_hash_table, hash_lookup, hash_put)
4952 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4953 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4954 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4955 * image.c (make_image, search_image_cache, lookup_image)
4956 (xpm_put_color_table_h):
4957 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4958 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4959 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4960 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4961 * alloc.c (allocate_vectorlike):
4962 Check for overflow in vector size calculations.
4963 * ccl.c (ccl_driver):
4964 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4965 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4966 need to be updated by these changes.
40087514
PE
4967 * fns.c (make_hash_table, maybe_resize_hash_table):
4968 Check for integer overflow with large hash tables.
0de4bb68
PE
4969 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4970 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4971 (SXHASH_REDUCE): New macro.
4972 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4973 Use it instead of discarding useful hash info with large hash values.
4974 (sxhash_float): New function.
4975 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4976 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4977 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4978 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4979 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4980 Adjust signatures to match updated version of code.
4981 (consing_since_gc): Now EMACS_INT, since a single hash table can
4982 use more than INT_MAX bytes.
4983
698d32e2
DN
49842011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4985
4986 Make it possible to build with GCC-4.6+ -O2 -flto.
4987
4988 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4989
fd6fa53f
SM
49902011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4991
4992 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4993 Call minibuffer-inactive-mode.
4994
864db017
JB
49952011-05-31 Juanma Barranquero <lekktu@gmail.com>
4996
4997 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4998 Update dependencies.
4999
2ad0baf4
DN
50002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5001
5002 * data.c (init_data): Remove code for UTS, this system is not
5003 supported anymore.
5004
4fcc2638
DN
50052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5006
5007 Don't force ./temacs to start in terminal mode.
5008
5009 * frame.c (make_initial_frame): Initialize faces in all cases, not
5010 only when CANNOT_DUMP is defined.
5011 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5012
c56e0fd5
DN
50132011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5014
5015 * dispnew.c (add_window_display_history): Use const for the string
5016 pointer. Remove declaration, not needed.
5017
333d54da 50182011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5019
55d4c1b2 5020 Use 'inline', not 'INLINE'.
333d54da 5021 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5022 * alloc.c, fontset.c (INLINE): Remove.
5023 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5024 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5025 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5026 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5027 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5028
738db178
DN
50292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5030
5031 Make it possible to run ./temacs.
5032
5033 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5034 syms_of_callproc does the same thing. Remove test for
5035 "initialized", do it in the caller.
5036 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5037
620c53a6
SM
50382011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5039
5040 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5041 (read_minibuf): Use get_minibuffer.
5042 (syms_of_minibuf): Use DEFSYM.
5043 (Qmetadata): New var.
5044 * data.c (Qbuffer): Don't make it static.
5045 (syms_of_data): Use DEFSYM.
5046
e003a292
PE
50472011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5048
5049 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5050 (CCL_CODE_MIN): New macro.
5051
ed008a6d
PE
50522011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5053
3687c2ef
PE
5054 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5055
ed008a6d
PE
5056 * eval.c (Qdebug): Now static.
5057 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5058 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5059 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5060
d66c4c7c
CY
50612011-05-29 Chong Yidong <cyd@stupidchicken.com>
5062
5063 * image.c: Various fixes to ImageMagick code comments.
5064 (Fimagemagick_types): Doc fix.
5065
5fbc2025
PE
50662011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5067
0196f88a
PE
5068 Minor fixes prompted by GCC 4.6.0 warnings.
5069
5070 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5071
5fbc2025
PE
5072 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5073 (x_clipboard_manager_save_all): Move extern decl to ...
5074 * xterm.h: ... here, so that it can be checked for consistency.
5075
1dd3c2d9
CY
50762011-05-29 Chong Yidong <cyd@stupidchicken.com>
5077
5078 * xselect.c (x_clipboard_manager_save_frame)
5079 (x_clipboard_manager_save_all): New functions.
5080 (Fx_clipboard_manager_save): Lisp function deleted.
5081
5082 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5083 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5084
5085 * xterm.h: Update prototype.
5086
5ba6571d
WX
50872011-05-28 William Xu <william.xwl@gmail.com>
5088
5089 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5090 exiting (Bug#8239).
5091
3eaff834
JM
50922011-05-28 Jim Meyering <meyering@redhat.com>
5093
e1900994 5094 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5095 * fns.c (to_uchar): Define.
5096 (crypto_hash_function): Use it to convert some newly-signed
5097 variables to unsigned, to avoid sign-extension bugs. For example,
5098 without this change, (md5 "truc") would evaluate to
5099 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5100 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5101 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5102
0f6990a7
PE
51032011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5104
5105 Integer overflow fixes.
c8a9ca5a 5106
08686060
PE
5107 * dbusbind.c: Serial number integer overflow fixes.
5108 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5109 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5110 to hold a serial number that is too large for a fixnum.
5111 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5112 Check for serial numbers out of range. Decode any serial number
59568bf0 5113 that was so large that it became a float. (Bug#8722)
08686060 5114
2d1fc3c7
PE
5115 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5116 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5117 Use XFASTINT rather than XUINT when numbers are nonnegative.
5118 (xd_append_arg, Fdbus_method_return_internal):
5119 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5120 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5121 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5122 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5123 (Bug#8722)
2d1fc3c7 5124
c8a9ca5a
PE
5125 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5126
519e1d69
PE
5127 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5128
30569699
PE
5129 ccl: add integer overflow checks
5130 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5131 (IN_INT_RANGE): New macros.
5132 (ccl_driver): Use them to check for integer overflow when
5133 decoding a CCL program. Many of the new checks are whether XINT (x)
5134 fits in int; it doesn't always, on 64-bit hosts. The new version
5135 doesn't catch all possible integer overflows, but it's an
847044ea 5136 improvement. (Bug#8719)
30569699 5137
c11285dc
PE
5138 * alloc.c (make_event_array): Use XINT, not XUINT.
5139 There's no need for unsigned here.
5140
fdccd48e
PE
5141 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5142 This follows up to the 2011-05-06 change that substituted uintptr_t
5143 for EMACS_INT. This case wasn't caught back then.
5144
37910ab2
PE
5145 Rework Fformat to avoid integer overflow issues.
5146 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5147 now (part of C89). Include <verify.h>.
5148 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5149 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5150 (Fformat): Avoid the prepass trying to compute sizes; it was only
5151 approximate and thus did not catch overflow reliably. Instead, walk
5152 through the format just once, formatting and computing sizes as we go,
5153 checking for integer overflow at every step, and allocating a larger
5154 buffer as needed. Keep track separately whether the format is
5155 multibyte. Keep only the most-recently calculated precision, rather
5156 than them all. Record whether each argument has been converted to
5157 string. Use EMACS_INT, not int, for byte and char and arg counts.
5158 Support field widths and precisions larger than INT_MAX. Avoid
5159 sprintf's undefined behavior with conversion specifications such as %#d
5160 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5161 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5162 formatting out-of-range floating point numbers with int
9173deec 5163 formats. (Bug#8668)
37910ab2 5164
2e6578fb
PE
5165 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5166
0ae6bdee
PE
5167 * data.c: Avoid integer truncation in expressions involving floats.
5168 * data.c: Include <intprops.h>.
5169 (arith_driver): When there's an integer overflow in an expression
5170 involving floating point, convert the integers to floating point
5171 so that the resulting value does not suffer from catastrophic
5172 integer truncation. For example, on a 64-bit host (* 4
5173 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5174 Do not rely on undefined behavior after integer overflow.
5175
de883a70
PE
5176 merge count_size_as_multibyte, parse_str_to_multibyte
5177 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5178 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5179 Check for integer overflow.
5180 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5181 since it's now a duplicate of the other. This is more of
5182 a character than a buffer op, so better that it's in character.c.
5183 * fns.c, print.c: Adjust to above changes.
5184
2ff916cb
PE
51852011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5186
5187 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5188
f1b54466
PE
51892011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5190
fb1ac845
PE
5191 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5192 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5193 (x_clipboard_manager_save): Now static.
5194 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5195
f1b54466
PE
5196 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5197 (crypto_hash_function): Now static.
5198 Fix pointer signedness problems. Avoid unnecessary initializations.
5199
a9f737ee
CY
52002011-05-27 Chong Yidong <cyd@stupidchicken.com>
5201
5202 * termhooks.h (Vselection_alist): Make it terminal-local.
5203
5204 * terminal.c (create_terminal): Initialize it.
5205
5206 * xselect.c: Support for clipboard managers.
5207 (Vselection_alist): Move to termhooks.h as terminal-local var.
5208 (LOCAL_SELECTION): New macro.
5209 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5210 (symbol_to_x_atom): Remove gratuitous arg.
5211 (x_handle_selection_request, lisp_data_to_selection_data)
5212 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5213 (x_own_selection, x_get_local_selection, x_convert_selection):
5214 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5215 (some_frame_on_display): Delete unused function.
5216 (Fx_own_selection_internal, Fx_get_selection_internal)
5217 (Fx_disown_selection_internal, Fx_selection_owner_p)
5218 (Fx_selection_exists_p): New optional frame arg.
5219 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5220 (x_handle_selection_clear): Don't treat other terminals with the
5221 same keyboard specially. Use the terminal-local Vselection_alist.
5222 (x_clear_frame_selections): Use Frun_hook_with_args.
5223
5224 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5225
5226 * xterm.h: Add support for those atoms.
5227
e067f0c1
CY
52282011-05-26 Chong Yidong <cyd@stupidchicken.com>
5229
5230 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5231 (converted_selections, conversion_fail_tag): New global variables.
5232 (x_selection_request_lisp_error): Free the above.
5233 (x_get_local_selection): Remove unnecessary code.
5234 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5235 of converted selections stored in converted_selections.
5236 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5237 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5238 (x_convert_selection): New function.
5239 (x_handle_selection_event): Simplify.
5240 (x_get_foreign_selection): Don't ignore incoming requests while
5241 waiting for an answer; this will fail when we implement
5242 SAVE_TARGETS, and seems unnecessary anyway.
5243 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5244 (Vx_sent_selection_functions): Doc fix.
5245
0f4aebc0
LL
52462011-05-26 Leo Liu <sdl.web@gmail.com>
5247
5248 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5249
e61124cd
YM
52502011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5251
5252 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5253
5254 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5255 for fringe update if it has periodic bitmap.
ac389d0c 5256 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5257 and fringe_bitmap_periodic_p.
5258
5259 * fringe.c (get_fringe_bitmap_data): New function.
5260 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5261 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5262 row. Mark glyph row for fringe update if periodicity changed.
5263
5264 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5265 for fringe update unless it has periodic bitmap.
5266
f16d9837
KH
52672011-05-25 Kenichi Handa <handa@m17n.org>
5268
5269 * xdisp.c (get_next_display_element): Set correct it->face_id for
5270 a static composition.
5271
e1b90ef6
LL
52722011-05-24 Leo Liu <sdl.web@gmail.com>
5273
5274 * deps.mk (fns.o):
5275 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5276
5277 * fns.c (crypto_hash_function, Fsha1): New function.
5278 (Fmd5): Use crypto_hash_function.
5279 (syms_of_fns): Add Ssha1.
5280
7400048f
PE
52812011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5282
5283 * gnutls.c: Remove unused macros.
5284 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5285 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5286 Remove macros that are defined and never used.
5287 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5288
abb71cf4
CY
52892011-05-22 Chong Yidong <cyd@stupidchicken.com>
5290
5291 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5292 (Fx_get_selection_internal): Minor cleanup.
5293 (Fx_own_selection_internal): Rename arguments for consistency with
5294 select.el.
5295
6307db39
PE
52962011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5297
5298 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5299
f3d4e0a4
CY
53002011-05-22 Chong Yidong <cyd@stupidchicken.com>
5301
5302 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5303
4d8ade89
YM
53042011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5305
5306 * dispnew.c (scrolling_window): Don't exclude the case that the
5307 last enabled row in the desired matrix touches the bottom boundary.
5308
32078c8d
GM
53092011-05-21 Glenn Morris <rgm@gnu.org>
5310
5311 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5312 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5313 and add some more files.
32078c8d 5314
7285dc67
EZ
53152011-05-20 Eli Zaretskii <eliz@gnu.org>
5316
5317 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5318 report_file_error introduced by the change from 2011-05-07.
5319
89d1bd22
PE
53202011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5321
5322 * systime.h (Time): Define only if emacs is defined.
5323 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5324 where the include path doesn't have X11/X.h by default. See
5325 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5326
e23640bb 53272011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5328
5329 * composite.c (find_automatic_composition): Fix previous change.
5330
b9704ad9
GM
53312011-05-20 Glenn Morris <rgm@gnu.org>
5332
5333 * lisp.mk: New file, split from Makefile.in.
5334 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5335 (shortlisp): Remove.
5336 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5337
4a720484
GM
53382011-05-19 Glenn Morris <rgm@gnu.org>
5339
5340 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5341 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5342 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5343 (lisp): Set the order to that of loadup.el.
5344 (shortlisp): Make it a copy of $lisp.
5345 (SOME_MACHINE_LISP): Remove.
5346 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5347 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5348
a28d4396
KH
53492011-05-18 Kenichi Handa <handa@m17n.org>
5350
5351 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5352 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5353 (find_automatic_composition): Mostly rewrite for efficiency.
5354
a2b1fa8e
JB
53552011-05-18 Juanma Barranquero <lekktu@gmail.com>
5356
5357 * makefile.w32-in: Update dependencies.
5358
8e1f5610
CS
53592011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5360
5361 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5362 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5363
7025ee00 53642011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5365
cdfa6eab
PE
5366 Fix some integer overflow issues, such as string length overflow.
5367
06d6db33
PE
5368 * insdel.c (count_size_as_multibyte): Check for string overflow.
5369
2b4560a8
PE
5370 * character.c (lisp_string_width): Check for string overflow.
5371 Use EMACS_INT, not int, for string indexes and lengths; in
5372 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5373 the resulting string length overflows an EMACS_INT; instead,
5374 report a string overflow if no precision given. When checking for
5375 precision exhaustion, use a check that cannot possibly have
5376 integer overflow. (Bug#8675)
5377 * character.h (lisp_string_width): Adjust to new signature.
5378
cb93f9be
PE
5379 * alloc.c (string_overflow): New function.
5380 (Fmake_string): Use it. This doesn't change behavior, but saves
5381 a few bytes and will simplify future changes.
5382 * character.c (string_escape_byte8): Likewise.
5383 * lisp.h (string_overflow): New decl.
5384
1a1f3366
PE
5385 Fixups, following up to the user-interface timestamp change.
5386 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5387 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5388 * msdos.c (mouse_get_pos): Likewise.
5389 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5390 * w32gui.h (Time): Define by including "systime.h" rather than by
5391 declaring it ourselves. (Bug#8664)
5392
d4e3e4d3
PE
5393 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5394 * image.c (clear_image_cache): Likewise.
5395
f6a24d19
PE
5396 * term.c (term_mouse_position): Don't assume time_t wraparound.
5397
08dc5ae6
PE
5398 Be more systematic about user-interface timestamps.
5399 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5400 and sometimes 'EMACS_UINT', to represent these timestamps.
5401 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5402 This makes the code easier to follow, and makes it easier to catch
5403 integer overflow bugs such as Bug#8664.
5404 * frame.c (Fmouse_position, Fmouse_pixel_position):
5405 Use Time, not unsigned long, for user-interface timestamps.
5406 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5407 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5408 * keyboard.h (last_event_timestamp): Likewise.
5409 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5410 * menu.h (xmenu_show): Likewise.
5411 * term.c (term_mouse_position): Likewise.
5412 * termhooks.h (struct input_event.timestamp): Likewise.
5413 (struct terminal.mouse_position_hook): Likewise.
5414 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5415 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5416 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5417 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5418 what it was before.
5419 * menu.h, termhooks.h: Include "systime.h", for Time.
5420
8e55734a
PE
5421 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5422 Don't assume that the difference between two unsigned long values
5423 can fit into an integer. At this point, we know button_down_time
5424 <= event->timestamp, so the difference must be nonnegative, so
5425 there's no need to cast the result if double-click-time is
5426 nonnegative, as it should be; check that it's nonnegative, just in
5427 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5428 apart (about 25 days). (Bug#8664)
8e55734a 5429
841f1b75 5430 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5431 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5432
3e26f69c
PE
5433 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5434 that always fit in int. Use a sentinel instead of a counter, to
5435 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5436 * frame.h (struct frame): Use int for menu_bar_items_used
5437 instead of EMACS_INT, since it always fits in int.
3e26f69c 5438
5cc152c0
PE
5439 * menu.c (grow_menu_items): Check for int overflow.
5440
d89eb65e
PE
5441 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5442
5235bd3e
PE
5443 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5444 Before, the code was not consistent. These values cannot exceed
5445 2**31 - 1 so there's no need to make them unsigned.
5446 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5447 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5448 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5449 as modifiers.
5450 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5451
bc827e23
PE
5452 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5453 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5454 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5455 presumably because the widths might not match.
5456
78eb494e
PE
5457 * window.c (size_window): Avoid needless test at loop start.
5458
04f2d78b
CB
54592011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5460
5461 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5462
d2fc7e3d 54632011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5464
5465 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5466
d2fc7e3d 54672011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5468
5469 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5470 `width' to `bar_area_x' and `bar_area_width', respectively.
5471 (x_scroll_run): Take account of fringe background extension.
5472
04f2d78b
CB
5473 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5474 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5475 `bar_area_width', respectively.
5476 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5477 background extension.
5478
79b70037
GM
54792011-05-10 Jim Meyering <meyering@redhat.com>
5480
5481 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5482
2f142cc5
JB
54832011-05-10 Juanma Barranquero <lekktu@gmail.com>
5484
5485 * image.c (Finit_image_library): Return t for built-in image types,
5486 like pbm and xbm. (Bug#8640)
5487
57679c86
AS
54882011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5489
5490 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5491
888c9e86
EZ
54922011-05-07 Eli Zaretskii <eliz@gnu.org>
5493
b0512a1d
EZ
5494 * w32console.c (Fset_screen_color): Doc fix.
5495 (Fget_screen_color): New function.
5496 (syms_of_ntterm): Defsubr it.
5497
7285dc67
EZ
5498 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5499 unlink the temporary file if Fcall_process didn't create it in the
5500 first place.
5501 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5502 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5503 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5504 cue to call_process_cleanup not to close that handle.
5505
4d3fcc8e
BK
55062011-05-07 Ben Key <bkey76@gmail.com>
5507
5508 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5509 one of two shell specific rules, either bootstrap-temacs-CMD or
5510 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5511 to the previous implementation of the bootstrap-temacs rule.
5512 The bootstrap-temacs-CMD rule is similar to the previous
5513 implementation of the bootstrap-temacs rule except that it
5514 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5515 variable.
5516
5517 These changes, along with some changes to nt/configure.bat,
5518 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5519 earlier fix to add support for --cflags and --ldflags options
5520 that include quotes so that it works whether make uses cmd or
5521 sh as the shell.
5522
b4289b64
MA
55232011-05-06 Michael Albinus <michael.albinus@gmx.de>
5524
5525 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5526 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5527 is a constant.
5528 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5529 a string. Handle both cases.
5530 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5531 (Fdbus_register_method): Use Qinvalid_function.
5532
af4c0e28
JB
55332011-05-06 Juanma Barranquero <lekktu@gmail.com>
5534
5535 * makefile.w32-in: Update dependencies.
5536 (LISP_H): Add inttypes.h and stdin.h.
5537 (PROCESS_H): Add unistd.h.
5538
c51453d9
EZ
55392011-05-06 Eli Zaretskii <eliz@gnu.org>
5540
5541 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5542 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5543
8ff0ac3c 55442011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5545
4c4b566b
PE
5546 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5547
aab2b9b5
PE
5548 * term.c (vfatal): Remove stray call to va_end.
5549 It's not needed and the C Standard doesn't allow it here anyway.
5550
c378da0b
PE
5551 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5552 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5553
288b08c7
PE
5554 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5555 bytes.
5556
e3601888
PE
5557 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5558
db6c0e74
PE
5559 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5560
dd5963ea
PE
5561 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5562
88c9450f
PE
5563 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5564
2f9442b8
PE
5565 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5566
c032b5f8
PE
5567 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5568 * charset.c (Fdefine_charset_internal): Don't initialize
5569 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5570 32-bit int (Bug#8600).
a108c10b
PE
5571
5572 * lread.c (read_integer): Be more consistent with string-to-number.
5573 Use string_to_number to do the actual conversion; this avoids
5574 rounding errors and fixes some other screwups. Without this fix,
5575 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5576 (digit_to_number): Move earlier, for benefit of read_integer.
5577 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5578 not a digit in any supported base. (Bug#8602)
a108c10b 5579
ad5f9eea
PE
5580 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5581
aec1708a
PE
5582 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5583 to match comment at start of function. This also removes a
5584 GCC warning about overflow in a 32+64-bit port.
5585
47be4ab5
PE
5586 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5587
371cac43
PE
5588 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5589 Reported by Stefan Monnier in
5590 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5591 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5592 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5593
d01a7826
PE
5594 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5595 (EMACS_UINTPTR): Likewise, with uintptr_t.
5596
7fd47d5c
PE
5597 * lisp.h: Prefer 64-bit EMACS_INT if available.
5598 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5599 on 32-bit hosts that have 64-bit int, so that they can access
5600 large files.
122b0c86
PE
5601 However, temporarily disable this change unless the temporary
5602 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5603
8727937b
PE
5604 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5605
8ac068ac
PE
5606 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5607 This removes an assumption that EMACS_INT and long are the same
5608 width as pointers. The assumption is true for Emacs porting targets
5609 now, but we want to make other targets possible.
5610 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5611 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5612 In the rest of the code, change types of integers that hold casted
5613 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5614 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5615 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5616 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5617 No need to cast type when ORing.
5618 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5619 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5620 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5621 assume EMACS_INT is the same width as char *.
5622 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5623 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5624 Remove no-longer-needed casts.
5625 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5626 (xg_tool_bar_help_callback, xg_make_tool_item):
5627 Use EMACS_INTPTR to hold an integer
5628 that will be cast to void *; this can avoid a GCC warning
5629 if EMACS_INT is not the same width as void *.
5630 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5631 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5632 (current_message_1, set_message_1):
5633 Use a local to convert to proper width without a cast.
5634 * xmenu.c (dialog_selection_callback): Likewise.
5635
ede49d71
PE
5636 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5637 Also, don't assume VALBITS / RAND_BITS is less than 5,
5638 and don't rely on undefined behavior when shifting a 1 left into
5639 the sign bit.
5640 * lisp.h (get_random): Change signature to match.
5641
2f30ecd0
PE
5642 * lread.c (hash_string): Use size_t, not int, for hash computation.
5643 Normally we prefer signed values; but hashing is special, because
5644 it's better to use unsigned division on hash table sizes so that
5645 the remainder is nonnegative. Also, size_t is the natural width
5646 for hashing into memory. The previous code used 'int', which doesn't
5647 retain enough info to hash well into very large tables.
5648 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5649
2a866e7b
PE
5650 * dbusbind.c: Don't possibly lose pointer info when converting.
5651 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5652 Use XPNTR rather than XHASH, so that the high-order bits of
5653 the pointer aren't lost when converting through void *.
5654
51639eac
PE
5655 * eval.c (Fautoload): Don't double-shift a pointer.
5656
92394119
PE
5657 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5658
dbdb9a7c
JB
56592011-05-06 Juanma Barranquero <lekktu@gmail.com>
5660
5661 * gnutls.c (DEF_GNUTLS_FN):
5662 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5663
db7a0b4f
AS
56642011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5665
5666 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5667 marker. (Bug#8610)
5668
f7ff1b0f 56692011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5670
5671 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5672 New version that can reserve upto 2GB of heap space.
5673
f7ff1b0f 56742011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5675
5676 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5677
639c109b
TZ
56782011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5679
5680 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5681 `gnutls_certificate_set_x509_key_file'.
5682
d2127135
JB
56832011-05-05 Juanma Barranquero <lekktu@gmail.com>
5684
5685 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5686 Update dependencies.
5687
e968f4f3
JB
56882011-05-04 Juanma Barranquero <lekktu@gmail.com>
5689
5690 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5691 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5692 Remove unused parameter `fildes'.
5693 * process.c (read_process_output, send_process): Don't pass it.
5694
84d358f0
JB
56952011-05-04 Juanma Barranquero <lekktu@gmail.com>
5696
5697 Fix previous change: the library cache is defined in w32.c.
5698 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5699 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5700
0898ca10
JB
57012011-05-04 Juanma Barranquero <lekktu@gmail.com>
5702
5703 Implement dynamic loading of GnuTLS on Windows.
5704
5705 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5706 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5707 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5708 Declare.
5709
5710 * gnutls.c (Qgnutls_dll): Define.
5711 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5712 (gnutls_*): Declare function pointers.
5713 (init_gnutls_functions): New function to initialize function pointers.
5714 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5715 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5716 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5717 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5718 (emacs_gnutls_write, emacs_gnutls_read)
5719 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5720 (Fgnutls_available_p): New function.
5721 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5722 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5723 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5724
5725 * image.c: Include w32.h.
5726 (Vimage_type_cache): Delete.
5727 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5728 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5729 (w32_delayed_load): Move to w32.c.
5730
5731 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5732
5733 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5734 (w32_delayed_load): Move from image.c. When loading a library, record
5735 its filename in the :loaded-from property of the library id.
5736 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5737 Initialize and staticpro them.
5738 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5739
5740 * process.c: Include lisp.h before w32.h, not after.
5741 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5742 instead of gnutls_record_check_pending.
5743
5744 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5745
ff4de4aa
TZ
57462011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5747
5748 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5749 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5750 as passed in.
5751
abe95abb
JD
57522011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5753
5754 * xterm.c (x_set_frame_alpha): Do not set property on anything
5755 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5756
e16e55d4
JB
57572011-05-02 Juanma Barranquero <lekktu@gmail.com>
5758
5759 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5760
bafcf6a5
JB
57612011-05-02 Juanma Barranquero <lekktu@gmail.com>
5762
5763 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5764 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5765 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5766 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5767 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5768 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5769 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5770 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5771 (Qgnutls_bootprop_callbacks_verify): Make static.
5772
e7a6747f
AS
57732011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5774
19ed11ba
AS
5775 * callproc.c: Indentation fixup.
5776
e7a6747f 5777 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5778 (wait_for_termination, interruptible_wait_for_termination):
5779 Move after wait_for_termination_1.
e7a6747f 5780
1ef14cb4
LMI
57812011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5782
5783 * sysdep.c (interruptible_wait_for_termination): New function
5784 which is like wait_for_termination, but allows keyboard
5785 interruptions.
5786
5787 * callproc.c (Fcall_process): Add (:file "file") as an option for
5788 the STDOUT buffer.
5789 (Fcall_process_region): Ditto.
5790
330d880c
EZ
57912011-04-30 Eli Zaretskii <eliz@gnu.org>
5792
8db90b73
EZ
5793 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5794 rather than `XVECTOR (FOO)->size'.
5795
330d880c
EZ
5796 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5797 inttypes.h, as a gnulib replacement is used if it not available in
5798 system headers.
5799
15cbd324
EZ
58002011-04-21 Eli Zaretskii <eliz@gnu.org>
5801
5802 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5803 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5804 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5805
5806 * coding.c (coding_alloc_by_realloc): Error out if destination
5807 will grow beyond MOST_POSITIVE_FIXNUM.
5808 (decode_coding_emacs_mule): Abort if there isn't enough place in
5809 charbuf for the composition carryover bytes. Reserve an extra
5810 space for up to 2 characters produced in a loop.
5811 (decode_coding_iso_2022): Abort if there isn't enough place in
5812 charbuf for the composition carryover bytes.
5813
58142011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5815
ae940cca
EZ
5816 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5817 aborting when %lld or %lll format is passed.
5818 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5819 %llo or %llx format is passed. (Bug#8545)
5820
03ab8921
EZ
5821 * window.c (window_scroll_line_based): Use a marker instead of
5822 simple variables to record original value of point. (Bug#7952)
5823
afda1437
EZ
5824 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5825 produced by %s or %c overflows available buffer space. (Bug#8545)
5826
f76dee0c
PE
58272011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5828
5829 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5830 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5831
fdc5744d
JB
58322011-04-28 Juanma Barranquero <lekktu@gmail.com>
5833
5834 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5835
638f053a
JB
58362011-04-28 Juanma Barranquero <lekktu@gmail.com>
5837
5838 * keyboard.c (Qdelayed_warnings_hook): Define.
5839 (command_loop_1): Run `delayed-warnings-hook'
5840 if Vdelayed_warnings_list is non-nil.
5841 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5842 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5843
d178f871
EZ
58442011-04-28 Eli Zaretskii <eliz@gnu.org>
5845
5846 * doprnt.c (doprnt): Don't return value smaller than the buffer
5847 size if the message was truncated. (Bug#8545).
5848
b124fd93
JB
58492011-04-28 Juanma Barranquero <lekktu@gmail.com>
5850
5851 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5852 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5853
e810457d
PE
58542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5855
5856 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5857
ea51cceb
JB
58582011-04-27 Juanma Barranquero <lekktu@gmail.com>
5859
5860 * makefile.w32-in: Update dependencies.
5861
94dcfacf
EZ
58622011-04-27 Eli Zaretskii <eliz@gnu.org>
5863
5864 Improve `doprnt' and its usage. (Bug#8545)
5865 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5866 `format_end'. Remove support for %l as a conversion specifier.
5867 Don't use xrealloc. Improve diagnostics when the %l size modifier
5868 is used. Update the commentary.
5869
5870 * eval.c (verror): Simplify calculation of size_t.
5871
5872 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5873 messages.
5874
f61f41d7
PE
58752011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5876
5877 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5878 change.
5879
96fb4434
PE
58802011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5881
5882 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5883 This makes this file independent of the recent pseudovector change.
5884
671875da 58852011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5886
69e9b5a3
PE
5887 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5888
b5f869a7 5889 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5890 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5891 Remove unused local.
c8926152 5892 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5893
841a1577 5894 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5895 GCC 4.6.0 optimizes based on type-based alias analysis.
5896 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5897 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5898 != &v->size, and therefore "v->size = 1; b->size = 2; return
5899 v->size;" must therefore return 1. This assumption is incorrect
5900 for Emacs, since it type-puns struct Lisp_Vector * with many other
5901 types. To fix this problem, this patch adds a new type struct
f904488f 5902 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5903 and pseudovectors, and helps optimizing compilers not get fooled
5904 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5905 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5906 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5907 the size member.
eab3844f
PE
5908 (XSETPVECTYPE): Rewrite in terms of new macro.
5909 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5910 This is a bit clearer, and further avoids the possibility of
5911 undesirable aliasing.
5912 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5913 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5914 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5915 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5916 (ASIZE): Now uses header.size rather than size.
5917 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5918 to avoid the hassle of writing XVECTOR (foo)->header.size.
5919 (struct vectorlike_header): New type.
eab3844f
PE
5920 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5921 object, to help avoid aliasing.
5922 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5923 (SUBRP): Likewise, since Lisp_Subr is a special case.
5924 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5925 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5926 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5927 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5928 changed to be "header.size" and "header.next".
5929 * buffer.h (struct buffer): Likewise.
5930 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5931 * frame.h (struct frame): Likewise.
5932 * process.h (struct Lisp_Process): Likewise.
5933 * termhooks.h (struct terminal): Likewise.
5934 * window.c (struct save_window_data, struct saved_window): Likewise.
5935 * window.h (struct window): Likewise.
5936 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5937 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5938 * buffer.c (init_buffer_once): Likewise.
5939 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5940 special case.
5941 * process.c (Fformat_network_address): Use local var for size,
5942 for brevity.
5943
0df1eac5
PE
5944 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5945
847ab9d1 5946 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5947 * data.c (atof): Remove decl; no longer used or needed.
5948 (digit_to_number): Move to lread.c.
5949 (Fstring_to_number): Use new string_to_number function, to be
5950 consistent with how the Lisp reader treats infinities and NaNs.
5951 Do not assume that floating-point numbers represent EMACS_INT
5952 without losing information; this is not true on most 64-bit hosts.
5953 Avoid double-rounding errors, by insisting on integers when
5954 parsing non-base-10 numbers, as the documentation specifies.
5955 * lisp.h (string_to_number): New decl, replacing ...
5956 (isfloat_string): Remove.
bc0a5c13 5957 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5958 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5959 appears to have been a coding error. Similarly, do not accept
5960 strings like +-1e0 as floating point numbers. Do not report
5961 overflow for integer overflows unless the base is not 10 which
5962 means we have no simple and reliable way to continue.
5963 Break out the floating-point parsing into a new
5964 function string_to_number, so that Fstring_to_number parses
5965 floating point numbers consistently with the Lisp reader.
04f2d78b 5966 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5967 (E_CHAR, EXP_INT): Remove, replacing with ...
5968 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5969 (string_to_number): New function, replacing isfloat_string.
5970 This function checks for valid syntax and produces the resulting
5971 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5972 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5973 so that overflow for non-base-10 numbers is reported only when
5974 there's no portable and simple way to convert to floating point.
452f4150 5975
67769ffc
PE
5976 * textprop.c (set_text_properties_1): Rewrite for clarity,
5977 and to avoid GCC warning about integer overflow.
5978
c20db43f
PE
5979 * intervals.h (struct interval): Use EMACS_INT for members
5980 where EMACS_UINT might cause problems. See
5981 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5982 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5983 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5984 All uses changed.
37aa2f85
PE
5985 (offset_intervals): Tell GCC not to worry about length overflow
5986 when negating a negative length.
c20db43f 5987
2538aa2f
PE
5988 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5989 (overrun_check_free): Likewise.
5990
f2d3008d
PE
5991 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5992 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5993 word size.
5994
ec8df744
PE
5995 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5996 (gnutls_make_error): Rename local to avoid shadowing.
5997 (gnutls_emacs_global_deinit): ifdef out; not used.
5998 (Fgnutls_boot): Use const for pointer to readonly storage.
5999 Comment out unused local. Fix pointer signedness problems.
6000
640ee02d
PE
6001 * lread.c (openp): Don't stuff size_t into an 'int'.
6002 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6003 about possible signed overflow.
6004
6048fb2a
PE
6005 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6006 (GDK_KEY_g): Don't define if already defined.
6007 (xg_prepare_tooltip): Avoid pointer signedness problem.
6008 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6009
fa3c87e1
PE
6010 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6011 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6012
2172544b
PE
6013 * xfns.c (Fx_window_property): Simplify a bit,
6014 to make a bit faster and to avoid GCC 4.6.0 warning.
6015 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6016
9b821a21
PE
6017 * fns.c (internal_equal): Don't assume size_t fits in int.
6018
3c616cfa
PE
6019 * alloc.c (compact_small_strings): Tighten assertion a little.
6020
c2982e87
PE
6021 Replace pEd with more-general pI, and fix some printf arg casts.
6022 * lisp.h (pI): New macro, generalizing old pEd macro to other
6023 conversion specifiers. For example, use "...%"pI"d..." rather
6024 than "...%"pEd"...".
6025 (pEd): Remove. All uses replaced with similar uses of pI.
6026 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6027 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6028 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6029 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6030 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6031 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6032 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6033 64-bit hosts.
6034 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6035 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6036 * print.c (safe_debug_print, print_object): Likewise.
6037 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6038 to int.
6f04d126
PE
6039 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6040 avoiding the 0 flag, which is not portable.
c2982e87
PE
6041 * process.c (Fmake_network_process): Use pI to avoid cast.
6042 * region-cache.c (pp_cache): Likewise.
6043 * xdisp.c (decode_mode_spec): Likewise.
6044 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6045 behavior on 64-bit hosts with printf arg.
6f04d126 6046 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6047 (x_stop_queuing_selection_requests): Likewise.
6048 (x_get_window_property): Don't truncate byte count to an 'int'
6049 when tracing.
0b432f21 6050
5e073ec7
PE
6051 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6052 here, since it parses constructs like leading '-' and spaces,
6053 which are not wanted; and it overflows with large numbers.
6054 Instead, simply match F[0-9]+, which is what is wanted anyway.
6055
36372bf9
PE
6056 * alloc.c: Remove unportable assumptions about struct layout.
6057 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6058 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6059 (allocate_vectorlike, make_pure_vector): Use the new macros,
6060 plus offsetof, to remove unportable assumptions about struct layout.
6061 These assumptions hold on all porting targets that I know of, but
6062 they are not guaranteed, they're easy to remove, and removing them
6063 makes further changes easier.
6064
0b432f21
PE
6065 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6066 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6067 (string_overrun_cookie): Now const. Use initializers that
6068 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6069 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6070 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6071 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6072 multiple of sizeof (EMACS_INT); it need not be, if
6073 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6074 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6075
895009e1
JB
60762011-04-26 Juanma Barranquero <lekktu@gmail.com>
6077
6078 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6079
6a7a1b0b
TZ
60802011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6081
6082 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6083 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6084 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6085
841a1577 60862011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6087
6088 * lisp.h (Qdebug): List symbol.
895009e1 6089 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6090 * keyboard.c (debug-on-event): New variable.
6091 (handle_user_signal): Break into debugger when debug-on-event
6092 matches the current signal symbol.
6093
f2d3ba6f
DN
60942011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6095
6096 * alloc.c (check_sblock, check_string_bytes)
6097 (check_string_free_list): Convert to standard C.
6098
42ce4c63
TZ
60992011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6100
6101 * w32.c (emacs_gnutls_push): Fix typo.
6102
825cd63c
EZ
61032011-04-25 Eli Zaretskii <eliz@gnu.org>
6104
fb11d64d
EZ
6105 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6106 "cast to pointer from integer of different size".
6107
825cd63c
EZ
6108 Improve doprnt and its use in verror. (Bug#8545)
6109 * doprnt.c (doprnt): Document the set of format control sequences
6110 supported by the function. Use SAFE_ALLOCA instead of always
6111 using `alloca'.
6112
6113 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6114 is one byte too soon. Don't use xrealloc; instead xfree and
6115 xmalloc anew.
6116
e061a11b
TZ
61172011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6118
6119 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6120 callbacks stage.
6121
6122 * gnutls.c: Renamed global_initialized to
6123 gnutls_global_initialized. Added internals for the
6124 :verify-hostname-error, :verify-error, and :verify-flags
6125 parameters of `gnutls-boot' and documented those parameters in the
6126 docstring. Start callback support.
9173deec
JB
6127 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6128 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6129 on error. Return error code.
e061a11b
TZ
6130 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6131 (emacs_gnutls_read): Likewise.
6132 (Fgnutls_boot): Return handshake error code.
6133 (emacs_gnutls_handle_error): New function.
6134 (wsaerror_to_errno): Likewise.
6135
6136 * w32.h (emacs_gnutls_pull): Add prototype.
6137 (emacs_gnutls_push): Likewise.
6138
6139 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6140 (emacs_gnutls_push): Likewise.
6141
61422011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6143
6144 * process.c (wait_reading_process_output): Check if GnuTLS
6145 buffered some data internally if no FDs are set for TLS
6146 connections.
6147
6148 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6149 (LIBS): Link to USER_LIBS.
6150 ($(BLD)/gnutls.$(0)): New target.
6151
fa6996bc
EZ
61522011-04-24 Eli Zaretskii <eliz@gnu.org>
6153
eb35682e
EZ
6154 * xdisp.c (handle_single_display_spec): Rename the
6155 display_replaced_before_p argument into display_replaced_p, to
6156 make it consistent with the commentary. Fix typos in the
6157 commentary.
6158
e2ad650c
EZ
6159 * textprop.c (syms_of_textprop): Remove dead code.
6160 (copy_text_properties): Delete obsolete commentary about an
6161 interface that was deleted long ago. Fix typos in the description
6162 of arguments.
6163
1b2de274
EZ
6164 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6165 to changes in oldXMenu/XMenu.h from 2011-04-16.
6166 <menu_help_message, prev_menu_help_message>: Constify.
6167 (IT_menu_make_room): menu->help_text is now `const char **';
6168 adjust.
6169
6170 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6171 to changes in oldXMenu/XMenu.h from 2011-04-16.
6172 (struct XMenu): Declare `help_text' `const char **'.
6173
6174 * xfaces.c <Qunspecified>: Make extern again.
6175
6176 * syntax.c: Include sys/types.h before including regex.h, as
6177 required by Posix.
6178
762b15be
EZ
6179 * doc.c (get_doc_string): Improve the format passed to `error'.
6180
6181 * doprnt.c (doprnt): Improve commentary.
6182
6183 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6184
6185 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6186 them with etags.
6187
f1052e5d
EZ
6188 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6189 changes in globals.h immediately force recompilation.
762b15be
EZ
6190 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6191 $(CURDIR)/s/ms-w32.h.
6192 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6193
fa6996bc
EZ
6194 * character.c (Fchar_direction): Function deleted.
6195 (syms_of_character): Don't defsubr it.
6196 <char-direction-table>: Deleted.
6197
e6c3da20
EZ
61982011-04-23 Eli Zaretskii <eliz@gnu.org>
6199
6200 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6201 * doprnt.c: Include limits.h.
6202 (SIZE_MAX): New macro.
04f2d78b
CB
6203 (doprnt): Return a size_t value. 2nd arg is now size_t.
6204 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6205 Improve overflow protection. Support `l' modifier for integer
6206 conversions. Support %l conversion. Don't assume an EMACS_INT
6207 argument for integer conversions and for %c.
6208
6209 * lisp.h (doprnt): Restore prototype.
6210
6211 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6212 $(SRC)/character.h.
6213
6214 * Makefile.in (base_obj): Add back doprnt.o.
6215
6216 * deps.mk (doprnt.o): Add back prerequisites.
6217 (callint.o): Depend on character.h.
6218
6219 * eval.c (internal_lisp_condition_case): Include the handler
6220 representation in the error message.
6221 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6222 when breaking from the loop.
6223
6224 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6225
6226 * callint.c (Fcall_interactively): When displaying error message
6227 about invalid control letter, pass the character's codepoint, not
6228 a pointer to its multibyte form. Improve display of the character
6229 in octal and display also its hex code.
6230
6231 * character.c (char_string): Use %x to display the (unsigned)
6232 codepoint of an invalid character, to avoid displaying a bogus
6233 negative value.
6234
6235 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6236 `error', not SYMBOL_NAME itself.
6237
6238 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6239 character arguments to `error'.
6240
6241 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6242 to `error' in error message about FINAL_CHAR argument. Make sure
6243 FINAL_CHAR is a character, and use %c when it is passed as
6244 argument to `error'.
6245
4ffd0d6b 62462011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6247
6248 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6249
6250 * w32.c: Include <time.h>.
6251 (sys_localtime): New function.
6252
4ffd0d6b 62532011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6254
6255 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6256
4ffd0d6b 6257 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6258
4ffd0d6b 62592011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6260
4ffd0d6b
GM
6261 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6262 zombies (Bug#8467).
aac0c6e3 6263
04c56954
EZ
62642011-04-19 Eli Zaretskii <eliz@gnu.org>
6265
6266 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6267 gl_state.e_property when gl_state.object is Qt.
6268
6269 * insdel.c (make_gap_larger): Remove limitation of buffer size
6270 to <= INT_MAX.
6271
16a43933
CY
62722011-04-18 Chong Yidong <cyd@stupidchicken.com>
6273
6274 * xdisp.c (lookup_glyphless_char_display)
6275 (produce_glyphless_glyph): Handle cons cell entry in
6276 glyphless-char-display.
6277 (Vglyphless_char_display): Document it.
6278
6279 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6280 glyphless-char-display.
6281
4581706e
CY
62822011-04-17 Chong Yidong <cyd@stupidchicken.com>
6283
6284 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6285
6286 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6287
6288 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6289 definition for no-X builds.
6290
4887c6e2 62912011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6292
fd35b6f9
PE
6293 Static checks with GCC 4.6.0 and non-default toolkits.
6294
5c1ccb01
PE
6295 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6296
006c5daa
PE
6297 * process.c (keyboard_bit_set): Define only if SIGIO.
6298 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6299 (send_process): Repair possible setjmp clobbering.
6300
efc736d3
PE
6301 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6302
4e2fe2e6
PE
6303 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6304
f97334a2
PE
6305 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6306
4e75f29d
PE
6307 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6308 Define only if needed.
6309
90efadd1
PE
6310 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6311 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6312 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6313
3c647824
PE
6314 * dispextern.h (struct redisplay_interface): Rename param
6315 to avoid shadowing.
e264f262 6316 * termhooks.h (struct terminal): Likewise.
761383f4 6317 * xterm.c (xembed_send_message): Likewise.
3c647824 6318
b58c5c4a
PE
6319 * insdel.c (make_gap_smaller): Define only if
6320 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6321
cad59032
PE
6322 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6323 it.
6324
c339dc2e
PE
6325 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6326 so that we aren't warned about unused symbols.
6327
91a3e27b
PE
6328 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6329
399c71d3 6330 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6331
8ffc96f5
PE
6332 * xfns.c (x_real_positions): Mark locals as initialized.
6333
eef9bc79
PE
6334 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6335
098db9dd
PE
6336 * xterm.c: Fix problems found by static analysis with other toolkits.
6337 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6338 (x_dispatch_event): Declare static if USE_GTK, and
6339 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6340 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6341 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6342 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6343 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6344
eb18f6cc
PE
6345 * xmenu.c (menu_help_callback): Pointer type fixes.
6346 Use const pointers when pointing at readonly data. Avoid pointer
6347 signedness clashes.
6348 (FALSE): Remove unused macro.
6349 (update_frame_menubar): Remove unused decl.
6350
1fe72bf8
PE
6351 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6352
60d9e1db
PE
6353 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6354 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6355 (single_menu_item): Rename local to avoid shadowing.
6356
39261c26
PE
6357 * keyboard.c (make_lispy_event): Remove unused local var.
6358
018c5e19
PE
6359 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6360 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6361
63d2b86e
PE
6362 * bitmaps: Change bitmaps from unsigned char back to the X11
6363 compatible char. Avoid the old compiler warnings about
6364 out-of-range initializers by using, for example, '\xab' rather
6365 than 0xab.
6366
aefd87e1
PE
6367 * xgselect.c (xgselect_initialize): Check vs interface
6368 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6369
bf501fb9
PE
6370 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6371
e9829fdf
PE
6372 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6373 to read-only memory.
6374
1086c095
PE
6375 * fns.c (vector): Remove; this old hack is no longer needed.
6376
2baccd04 6377 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6378 Remove unused var.
dde42981 6379 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6380
72391843 6381 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6382
436c16df 6383 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6384 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6385 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6386
92bb796d 6387 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6388 (x_term_init): Remove local to avoid shadowing.
92bb796d 6389
764430a3 6390 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6391
6392 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6393 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6394
d1dfb56c
EZ
63952011-04-16 Eli Zaretskii <eliz@gnu.org>
6396
c4354cb4
EZ
6397 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6398
d1dfb56c
EZ
6399 Fix regex.c, syntax.c and friends for buffers > 2GB.
6400 * syntax.h (struct gl_state_s): Declare character position members
6401 EMACS_INT.
6402
6403 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6404
04f2d78b
CB
6405 * textprop.c (verify_interval_modification, interval_of):
6406 Declare arguments EMACS_INT.
d1dfb56c
EZ
6407
6408 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6409 EMACS_INT.
6410
6411 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6412
6413 * indent.c (Fvertical_motion): Local variable it_start is now
6414 EMACS_INT.
6415
6416 * regex.c (re_match, re_match_2, re_match_2_internal)
6417 (bcmp_translate, regcomp, regexec, print_double_string)
6418 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6419 (re_compile_pattern, re_exec): Declare arguments and local
6420 variables `size_t' and `ssize_t' and return values `regoff_t', as
6421 appropriate.
6422 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6423 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6424 <compile_stack_type>: `size' and `avail' are now `size_t'.
6425
6426 * regex.h <regoff_t>: Use ssize_t, not int.
6427 (re_search, re_search_2, re_match, re_match_2): Arguments that
6428 specify buffer/string position and length are now ssize_t and
6429 size_t. Return type is regoff_t.
6430
613052cd
BK
64312011-04-16 Ben Key <bkey76@gmail.com>
6432
6433 * nsfont.m: Fixed bugs in ns_get_family and
6434 ns_descriptor_to_entity that were caused by using free to
6435 deallocate memory blocks that were allocated by xmalloc (via
6436 xstrdup). This caused Emacs to crash when compiled with
6437 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6438 --enable-checking=xmallocoverrun). xfree is now used to
6439 deallocate these memory blocks.
6440
4170f62f 64412011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6442
71b41406
PE
6443 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6444
9587a89d
PE
6445 emacs_write: Accept and return EMACS_INT for sizes.
6446 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6447 et seq.
6448 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6449 Accept and return EMACS_INT.
6450 (emacs_gnutls_write): Return the number of bytes written on
6451 partial writes.
6452 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6453 (emacs_read, emacs_write): Remove check for negative size, as the
6454 Emacs source code has been audited now.
9587a89d
PE
6455 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6456 (emacs_read, emacs_write): Use it.
273a5f82
PE
6457 * process.c (send_process): Adjust to the new signatures of
6458 emacs_write and emacs_gnutls_write. Do not attempt to store
6459 a byte offset into an 'int'; it might overflow.
9587a89d 6460 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6461
3e047f51
PE
6462 * sound.c: Don't assume sizes fit in 'int'.
6463 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6464 Return EMACS_INT, not int.
3e047f51 6465 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6466 Accept EMACS_INT, not int.
6467 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6468 record read return values.
6469
cc39a9db
BK
64702011-04-15 Ben Key <bkey76@gmail.com>
6471
c9d0ec6d
JB
6472 * keyboard.c (Qundefined): Don't declare static since it is used
6473 in nsfns.m.
6474 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6475 static since they are used in nsfont.m.
cc39a9db 6476
6c60eb9f
SM
64772011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6478
6479 * process.c (Qprocessp): Don't declare static.
6480 * lisp.h (Qprocessp): Declare again.
6481
7990b61a
JB
64822011-04-15 Juanma Barranquero <lekktu@gmail.com>
6483
6484 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6485
5d4cb038
PE
64862011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6487
8bd7b830 6488 Improve C-level modularity by making more things 'static'.
cd64ea1d 6489
e3b27b31
PE
6490 Don't publish debugger-only interfaces to other modules.
6491 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6492 (verify_bytepos, count_markers): Move decls to the only modules
6493 that need them.
6494 * region-cache.h (pp_cache): Likewise.
6495 * window.h (check_all_windows): Likewise.
6496 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6497
5d4cb038
PE
6498 * sysdep.c (croak): Now static, if
6499 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6500 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6501
6502 * alloc.c (refill_memory_reserve): Now static if
6503 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6504 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6505
e87b6180
PE
6506 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6507 Define only if USE_LUCID.
6508
ac64929e
PE
6509 * xrdb.c (x_customization_string, x_rm_string): Now static.
6510
6f37259d
PE
6511 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6512 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6513
1683e3ab
PE
6514 * xdisp.c (draw_row_with_mouse_face): Now static.
6515 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6516
de9c2632
PE
6517 * window.h (check_all_windows): Mark externally visible.
6518
2b96acb7
PE
6519 * window.c (window_deletion_count): Now static.
6520
6521 * undo.c: Make symbols static if they're not exported.
6522 (last_undo_buffer, last_boundary_position, pending_boundary):
6523 Now static.
6524
50436f33
PE
6525 * textprop.c (interval_insert_behind_hooks): Now static.
6526 (interval_insert_in_front_hooks): Likewise.
6527
64520e5c
PE
6528 * term.c: Make symbols static if they're not exported.
6529 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6530 (max_frame_lines, tty_set_terminal_modes):
6531 (tty_reset_terminal_modes, tty_turn_off_highlight):
6532 (get_tty_terminal): Now static.
6533 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6534 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6535 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6536 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6537 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6538
1fa53021
PE
6539 * sysdep.c: Make symbols static if they're not exported.
6540 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6541 Now static.
6542 (sigprocmask_set, full_mask): Remove; unused.
6543 (wait_debugging): Mark as visible.
6544 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6545 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6546
d4b43b22
PE
6547 * syntax.c (syntax_temp): Define only if !__GNUC__.
6548
b7c513d0
PE
6549 * sound.c (current_sound_device, current_sound): Now static.
6550
989b29ad
PE
6551 * search.c (searchbufs, searchbuf_head): Now static.
6552
13a55a78
PE
6553 * scroll.c (scroll_cost): Remove; unused.
6554 * dispextern.h (scroll_cost): Remove decl.
6555
de68a1fc
PE
6556 * region-cache.h (pp_cache): Mark as externally visible.
6557
40ccffa6
PE
6558 * process.c: Make symbols static if they're not exported.
6559 (process_tick, update_tick, create_process, chan_process):
6560 (Vprocess_alist, proc_buffered_char, datagram_access):
6561 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6562 (deactivate_process): Mark defn as static, as well as decl.
6563 * lisp.h (create_process): Remove decl.
6564 * process.h (chan_process, Vprocess_alist): Remove decls.
6565
ad64fc97
PE
6566 * print.c: Make symbols static if they're not exported.
6567 (print_depth, new_backquote_output, being_printed, print_buffer):
6568 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6569 (print_interval, print_number_index, initial_stderr_stream):
6570 Now static.
6571 * lisp.h (Fprinc): Remove decl.
6572 (debug_output_compilation_hack): Mark as externally visible.
6573
adddb265
PE
6574 * sysdep.c (croak): Move decl from here to syssignal.h.
6575 * syssignal.h (croak): Put it here, so the API can be checked when
6576 'croak' is called from dissociate_if_controlling_tty.
6577
1717ede2
PE
6578 * minibuf.c: Make symbols static if they're not exported.
6579 (minibuf_save_list, choose_minibuf_frame): Now static.
6580 * lisp.h (choose_minibuf_frame): Remove decl.
6581
fa5fb2bc
PE
6582 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6583
1e3890d1
PE
6584 * lread.c: Make symbols static if they're not exported.
6585 (read_objects, initial_obarray, oblookup_last_bucket_number):
6586 Now static.
6587 (make_symbol): Remove; unused.
6588 * lisp.h (initial_obarray, make_symbol): Remove decls.
6589
8a1414fa
PE
6590 * keyboard.c: Make symbols static if they're not exported.
6591 (single_kboard, recent_keys_index, total_keys, recent_keys):
6592 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6593 (this_single_command_key_start, echoing, last_auto_save):
6594 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6595 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6596 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6597 (Vlispy_mouse_stem, double_click_count):
6598 Now static.
6599 (force_auto_save_soon): Define only if SIGDANGER.
6600 (ignore_mouse_drag_p): Now static if
6601 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6602 (print_help): Remove; unused.
6603 (stop_character, last_timer_event): Mark as externally visible.
6604 * keyboard.h (ignore_mouse_drag_p): Declare only if
6605 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6606 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6607 * lisp.h (echoing): Remove decl.
6608 (force_auto_save_soon): Declare only if SIGDANGER.
6609 * xdisp.c (redisplay_window): Simplify code, to make it more
6610 obvious that ignore_mouse_drag_p is not accessed if !defined
6611 USE_GTK && !defined HAVE_NS.
6612
93ea6e8f
PE
6613 * intervals.c: Make symbols static if they're not exported.
6614 (merge_properties_sticky, merge_interval_right, delete_interval):
6615 Now static.
6616 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6617
77382fcc
PE
6618 * insdel.c: Make symbols static if they're not exported.
6619 However, leave prepare_to_modify_buffer alone. It's never
6620 called from outside this function, but that appears to be a bug.
6621 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6622 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6623 (adjust_after_replace_noundo): Remove; unused.
6624 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6625 (signal_before_change): Remove decls.
77382fcc 6626
9306c32e
PE
6627 * indent.c (val_compute_motion, val_vmotion): Now static.
6628
cd44d2eb
PE
6629 * image.c: Make symbols static if they're not exported.
6630 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6631 if USE_GTK.
6632 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6633 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6634
ad9a7a06
PE
6635 * fringe.c (standard_bitmaps): Now static.
6636 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6637
81626931
PE
6638 * frame.c: Make symbols static if they're not exported.
6639 (x_report_frame_params, make_terminal_frame): Now static.
6640 (get_frame_param): Now static, unless HAVE_NS.
6641 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6642 (x_get_resource_string): Remove; not used.
6643 * frame.h (make_terminal_frame, x_report_frame_params):
6644 (x_get_resource_string); Remove decls.
6645 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6646 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6647
239f9db9
PE
6648 * font.c, fontset.c: Make symbols static if they're not exported.
6649 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6650 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6651 * font.c (font_close_object): Now static.
6652 * font.h (font_close_object): Remove.
6653 * fontset.c (FONTSET_OBJLIST): Remove.
6654 (free_realized_fontset) #if-0 the body, which does nothing.
6655 (face_suitable_for_char_p): #if-0, as it's never called.
6656 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6657 * xfaces.c (face_at_string_position):
6658 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6659 since 0 is always ASCII.
6660
dfcf3579
PE
6661 * fns.c (weak_hash_tables): Now static.
6662
5045092b
PE
6663 * fileio.c: Make symbols static if they're not exported.
6664 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6665 (Vwrite_region_annotation_buffers): Now static.
6666
57a96f5c
PE
6667 * eval.c: Make symbols static if they're not exported.
6668 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6669 * lisp.h (backtrace_list): Remove decl.
6670
35f08c38
PE
6671 * emacs.c: Make symbols static if they're not exported.
6672 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6673 (fatal_error_code, fatal_error_signal_hook, standard_args):
6674 Now static.
6675 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6676 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6677 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6678 * lisp.h (fatal_error_signal_hook): Remove decl.
6679 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6680
f44bd759
PE
6681 * editfns.c: Move a (normally-unused) function to its only use.
6682 * editfns.c, lisp.h (get_operating_system_release): Remove.
6683 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6684 worth the hassle of breaking this out.
6685
b532497d
PE
6686 * xterm.c: Make symbols static if they're not exported.
6687 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6688 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6689 (x_destroy_window, x_delete_display):
6690 Now static.
6691 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6692 (x_mouse_leave): Remove; unused.
6693 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6694 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6695 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6696 Remove decls.
6697 (x_mouse_leave): Declare only if WINDOWSNT.
6698 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6699 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6700 USE_X_TOOLKIT.
6701
1675728f
PE
6702 * ftxfont.c: Make symbols static if they're not exported.
6703 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6704 HAVE_FREETYPE.
6705 * font.h (ftxfont_driver): Likewise.
6706
e4cebfca
PE
6707 * xfns.c: Make symbols static if they're not exported.
6708 (x_last_font_name, x_display_info_for_name):
6709 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6710 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6711 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6712 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6713 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6714 (last_show_tip_args): Now static.
6715 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6716 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6717 (x_screen_planes): Remove; unused.
6718 * dispextern.h (x_screen_planes): Remove decl.
6719
5bf46f05
PE
6720 * dispnew.c: Make symbols static if they're not exported.
6721 * dispextern.h (redraw_garbaged_frames, scrolling):
6722 (increment_row_positions): Remove.
6723 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6724 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6725 Now static.
6726 (redraw_garbaged_frames): Remove; unused.
6727
435f4c28
PE
6728 * xfaces.c: Make symbols static if they're not exported.
6729 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6730 Remove decls.
6731 * xterm.h (defined_color): Remove decls.
6732 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6733 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6734 (menu_face_changed_default, defined_color, free_realized_face):
6735 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6736 (ascii_face_of_lisp_face): Remove; unused.
6737
8524aef3
PE
6738 * xdisp.c: Make symbols static if they're not exported.
6739 * dispextern.h (scratch_glyph_row, window_box_edges):
6740 (glyph_to_pixel_coords, set_cursor_from_row):
6741 (get_next_display_element, set_iterator_to_next):
6742 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6743 (show_mouse_face): Remove decls
6744 * frame.h (message_buf_print): Likewise.
6745 * lisp.h (pop_message, set_message, check_point_in_composition):
6746 Likewise.
6747 * xterm.h (set_vertical_scroll_bar): Likewise.
6748 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6749 (message_buf_print, scratch_glyph_row, displayed_buffer):
6750 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6751 (get_next_display_element, show_mouse_face, window_box_edges):
6752 (frame_to_window_pixel_xy, check_point_in_composition):
6753 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6754 (glyph_to_pixel_coords): Remove; unused.
6755
16390cd2
PE
6756 * dired.c (file_name_completion): Now static.
6757
6758 * dbusbind.c (xd_in_read_queued_messages): Now static.
6759
a25f4dfa
PE
6760 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6761 * data.c (circular_list_error): Remove.
6762
14a9c8df
PE
6763 * commands.h (last_point_position, last_point_position_buffer):
6764 (last_point_position_window): Remove decls.
6765 * keyboard.c: Make these variables static.
6766
04f2d78b
CB
6767 * coding.h (coding, code_convert_region, encode_coding_gap):
6768 Remove decls.
74ab6df5
PE
6769 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6770 (iso_code_class, detect_coding, code_convert_region): Now static.
6771 (encode_coding_gap): Remove; unused.
6772
38dfbee1
PE
6773 * chartab.c (chartab_chars, chartab_bits): Now static.
6774
a2cb4e63
PE
6775 * charset.h (charset_iso_8859_1): Remove decl.
6776 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6777 Now static.
6778
127198fd
PE
6779 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6780 * ccl.c (Vccl_program_table): Now static.
6781 (check_ccl_update): Remove; unused.
6782
d85b608f
PE
6783 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6784 * category.h: ... from here.
6785 * category.c (check_category_table, set_category_set): Now static.
6786
31cd66f3
PE
6787 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6788 * lisp.h: Remove these decls.
6789
c358e587
PE
6790 * buffer.c (buffer_count): Remove unused var.
6791
e78aecca
PE
6792 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6793 so that it's not optimized away.
6794 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6795 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6796 exported only to the debugger.
6797
e192d7d3 6798 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6799 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6800
92470028
PE
6801 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6802 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6803 was inaccessible from Lisp.
6804 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6805 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6806
244ed907
PE
6807 alloc.c: Import and export fewer symbols, and remove unused items.
6808 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6809 is defined.
6810 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6811 it's not optimized away by whole-program optimization.
6812 (message_enable_multibyte, free_misc): Remove.
6813 (catchlist, handlerlist, mark_backtrace):
6814 Declare only if BYTE_MARK_STACK.
6815 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6816 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6817 (message_enable_multibyte): Remove decl.
6818 (free_misc, interval_free_list, float_block, float_block_index):
6819 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6820 (cons_free_list, last_marked_index):
6821 Now static.
6822 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6823 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6824 (mark_backtrace): Define only if BYTE_MARK_STACK.
6825 * xdisp.c (message_enable_multibyte): Now static.
6826
61c2b50e 6827 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6828 This makes it easier for human readers (and static analyzers)
6829 to see whether these variables are used from other modules.
6830 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6831 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6832 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6833 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6834 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6835 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6836 * xmenu.c, xselect.c:
6837 Declare Q* vars static if they are not used in other modules.
6838 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6839 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6840 Remove decls of unexported vars.
6841 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6842
95c82688
PE
6843 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6844
16a97296
PE
6845 Make Emacs functions such as Fatom 'static' by default.
6846 This makes it easier for human readers (and static analyzers)
6847 to see whether these functions can be called from other modules.
6848 DEFUN now defines a static function. To make the function external
6849 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6850 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6851 (Finit_image_library):
16a97296
PE
6852 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6853 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6854 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6855 Remove decls, since these functions are now static.
6856 (Funintern, Fget_internal_run_time): New decls, since these functions
6857 were already external.
95c82688 6858
16a97296
PE
6859 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6860 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6861 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6862 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6863 * keyboard.c, keymap.c, lread.c:
6864 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6865 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6866 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6867 Mark functions with DEFUE instead of DEFUN,
6868 if they are used in other modules.
6869 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6870 decls for now-static functions.
6871 * buffer.h (Fdelete_overlay): Remove decl.
6872 * callproc.c (Fgetenv_internal): Mark as internal.
6873 * composite.c (Fremove_list_of_text_properties): Remove decl.
6874 (Fcomposition_get_gstring): New forward static decl.
6875 * composite.h (Fcomposite_get_gstring): Remove decl.
6876 * dired.c (Ffile_attributes): New forward static decl.
6877 * doc.c (Fdocumntation_property): New forward static decl.
6878 * eval.c (Ffetch_bytecode): New forward static decl.
6879 (Funintern): Remove extern decl; now in .h file where it belongs.
6880 * fileio.c (Fmake_symbolic_link): New forward static decl.
6881 * image.c (Finit_image_library): New forward static decl.
6882 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6883 * intervals.h (Fprevious_property_change):
6884 (Fremove_list_of_text_properties): Remove decls.
6885 * keyboard.c (Fthis_command_keys): Remove decl.
6886 (Fcommand_execute): New forward static decl.
6887 * keymap.c (Flookup_key): New forward static decl.
6888 (Fcopy_keymap): Now static.
6889 * keymap.h (Flookup_key): Remove decl.
6890 * process.c (Fget_process): New forward static decl.
6891 (Fprocess_datagram_address): Mark as internal.
6892 * syntax.c (Fsyntax_table_p): New forward static decl.
6893 (skip_chars): Remove duplicate decl.
6894 * textprop.c (Fprevious_property_change): New forward static decl.
6895 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6896 Now internal.
6897 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6898 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6899
785bbd42
PE
6900 * editfns.c (Fformat): Remove unreachable code.
6901
8b913b57
AS
69022011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6903
6904 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6905 change. (Bug#8496)
6906
a6744a35
EZ
69072011-04-13 Eli Zaretskii <eliz@gnu.org>
6908
6909 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6910 when at ZV. (Bug#8487)
6911
e7974947
AS
69122011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6913
baad03f0
AS
6914 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6915 (Bug#8437)
6916 * keyboard.c (parse_tool_bar_item): Likewise.
6917 * sound.c (sound_cleanup, alsa_close): Likewise.
6918 * termcap.c (tgetent): Likewise.
6919 * xfns.c (x_default_font_parameter): Likewise.
6920 * xsettings.c (read_and_apply_settings): Likewise.
6921
e7974947
AS
6922 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6923 (overrun_check_free): Protoize.
6924
28272684
PE
69252011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6926
6927 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6928 since callers should never pass a negative size.
6929 Change the signature to match that of plain 'read' and 'write'; see
6930 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6931 * lisp.h: Update prototypes of emacs_write and emacs_read.
6932
11997c76
EZ
69332011-04-11 Eli Zaretskii <eliz@gnu.org>
6934
6935 * xdisp.c (redisplay_window): Don't try to determine the character
6936 position of the scroll margin if the window start point w->startp
e896f03c 6937 is outside the buffer's accessible region. (Bug#8468)
11997c76 6938
8a2cbd72
EZ
69392011-04-10 Eli Zaretskii <eliz@gnu.org>
6940
6941 Fix write-region and its subroutines for buffers > 2GB.
6942 * fileio.c (a_write, e_write): Modify declaration of arguments and
6943 local variables to support buffers larger than 2GB.
6944 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6945
6946 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6947 argument, local variables, and return value.
6948
6949 * lisp.h: Update prototypes of emacs_write and emacs_read.
6950
6951 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6952
4073e537 69532011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6954
1ebfdcb6
PE
6955 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6956
b2ded58d
PE
6957 Fix more problems found by GCC 4.6.0's static checks.
6958
7d66342c
PE
6959 * xdisp.c (vmessage): Use a better test for character truncation.
6960
bbf47d44
PE
6961 * charset.c (load_charset_map): <, not <=, for optimization,
6962 and to avoid potential problems with integer overflow.
9248994d 6963 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6964 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6965 * editfns.c (Fformat): Likewise.
1e69125e 6966 * syntax.c (skip_chars): Likewise.
3befa583 6967
e3019616
PE
6968 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6969 This also lets GCC 4.6.0 generate slightly better loop code.
6970
becfa255
PE
6971 * callint.c (Fcall_interactively): <, not <=, for optimization.
6972 (Fcall_interactively): Count the number of arguments produced,
6973 not the number of arguments given. This is simpler and lets GCC
6974 4.6.0 generate slightly better code.
6975
dae0cd48
PE
6976 * ftfont.c: Distingish more carefully between FcChar8 and char.
6977 The previous code passed unsigned char * to a functions like
6978 strlen and xstrcasecmp that expect char *, which does not
6979 conform to the C standard.
6980 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6981 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6982 char * when the C standard requires it.
6983
76032d70
PE
6984 * keyboard.c (read_char): Remove unused var.
6985
eb3f1cc8
PE
6986 * eval.c: Port to Windows vsnprintf (Bug#8435).
6987 Include <limits.h>.
6988 (SIZE_MAX): Define if the headers do not.
6989 (verror): Do not give up if vsnprintf returns a negative count.
6990 Instead, grow the buffer. This ports to Windows vsnprintf, which
6991 does not conform to C99. Problem reported by Eli Zaretskii.
6992 Also, simplify the allocation scheme, by avoiding the need for
6993 calling realloc, and removing the ALLOCATED variable.
6994
70476b54
PE
6995 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6996
12020a9e
PE
6997 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6998 But keep the doprint source code for now, as we might revamp it
6999 and use it again (Bug#8435).
ea6c7ae6
PE
7000 * lisp.h (doprnt): Remove.
7001 * Makefile.in (base_obj): Remove doprnt.o.
7002 * deps.mk (doprnt.o): Remove.
7003
5fdb398c
PE
7004 error: Print 32- and 64-bit integers portably (Bug#8435).
7005 Without this change, on typical 64-bit hosts error ("...%d...", N)
7006 was used to print both 32- and 64-bit integers N, which relied on
7007 undefined behavior.
7008 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7009 New macro.
7010 * lisp.h (error, verror): Mark as printf-like functions.
7011 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7012 Report overflow in size calculations when allocating printf buffer.
7013 Do not truncate output string at its first null byte.
7014 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7015 Truncate the output at a character boundary, since vsnprintf does not
7016 do that.
7017 * charset.c (check_iso_charset_parameter): Convert internal
7018 character to string before calling 'error', since %c now has the
7019 printf meaning.
7020 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7021 overflow when computing char to be passed to 'error'. Do not
7022 pass Lisp_Object to 'error'; pass the integer instead.
7023 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7024 formatted with plain %d.
7025
b189fa66
PE
7026 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7027
bff87ef0
PE
7028 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7029
7e2cac20
PE
7030 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7031
ce4d90b5
PE
7032 * xterm.c (x_catch_errors): Remove duplicate declaration.
7033
266c9547
PE
7034 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7035
79c49ad2
PE
7036 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7037
368f4090
JM
70382011-04-10 Jim Meyering <meyering@redhat.com>
7039
7040 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7041 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7042 return ssize_t not "int", and use size_t as the buffer length.
7043 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7044 * gnutls.h: Update declarations.
7045 * process.c (read_process_output): Use ssize_t, to match.
7046 (send_process): Likewise.
7047
a32d4040
CY
70482011-04-09 Chong Yidong <cyd@stupidchicken.com>
7049
7050 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7051
8546720e 70522011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7053
04f2d78b
CB
7054 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7055 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7056
8546720e
GM
7057 * xterm.c (handle_one_xevent):
7058 * xmenu.c (create_and_show_popup_menu):
7059 * xselect.c (x_decline_selection_request)
7060 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7061
0a2f5c1a 70622011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7063
7064 Fix some uses of `int' instead of EMACS_INT.
7065 * search.c (string_match_1, fast_string_match)
7066 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7067 (scan_buffer, find_next_newline_no_quit)
7068 (find_before_next_newline, search_command, Freplace_match)
7069 (Fmatch_data): Make some `int' variables be EMACS_INT.
7070
7071 * xdisp.c (display_count_lines): 3rd argument and return value now
7072 EMACS_INT. All callers changed.
7073 (pint2hrstr): Last argument is now EMACS_INT.
7074
7075 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7076 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7077 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7078 (decode_coding_utf_16, decode_coding_emacs_mule)
7079 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7080 (decode_coding_ccl, decode_coding_charset)
7081 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7082 (decode_coding_iso_2022, decode_coding_emacs_mule)
7083 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7084 <char_offset, last_offset>: Declare EMACS_INT.
7085 (encode_coding_utf_8, encode_coding_utf_16)
7086 (encode_coding_emacs_mule, encode_invocation_designation)
7087 (encode_designation_at_bol, encode_coding_iso_2022)
7088 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7089 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7090 Declare EMACS_INT.
7091 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7092 (encode_invocation_designation): Last argument P_NCHARS is now
7093 EMACS_INT.
7094 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7095 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7096
7097 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7098 All users changed.
7099
7100 * ccl.c (Fccl_execute_on_string): Declare some variables
7101 EMACS_INT.
7102
8546720e 71032011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7104
7105 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7106
4e19a977
CS
71072011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7108
7109 * process.c (Fformat_network_address): Doc fix.
7110
87302331
R
71112011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7112
7113 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7114
cbb59342
CY
71152011-04-08 Chong Yidong <cyd@stupidchicken.com>
7116
7117 * keyboard.c (read_char): Call Lisp function help-form-show,
7118 instead of using internal_with_output_to_temp_buffer.
7119 (Qhelp_form_show): New var.
e0d38eeb 7120 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7121
7122 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7123
7124 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7125
e67a13ab
CY
71262011-04-06 Chong Yidong <cyd@stupidchicken.com>
7127
04f2d78b
CB
7128 * process.c (Flist_processes): Remove to Lisp.
7129 (list_processes_1): Delete.
e67a13ab 7130
973f782d
EZ
71312011-04-06 Eli Zaretskii <eliz@gnu.org>
7132
7c106b1e
EZ
7133 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7134
973f782d
EZ
7135 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7136
41cf7d1a 71372011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7138
ca23cc88
PE
7139 Fix more problems found by GCC 4.6.0's static checks.
7140
f390e2d5
PE
7141 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7142
42eea0d0
PE
7143 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7144
b69769da 7145 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7146
f9541e84
PE
7147 * xdisp.c (vmessage): Mark as a printf-like function.
7148
13841b55
PE
7149 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7150
c136c10f
PE
7151 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7152
5e2d4a30
PE
7153 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7154 printf-like functions.
7155 (tiff_load): Add casts to remove these marks before passing them
7156 to system-supplied API.
7157
583f48b9
PE
7158 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7159
b25d760e
PE
7160 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7161 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7162 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7163 directly, rather than having caller test rule sign. This avoids
7164 some unnecessary tests.
7165 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7166 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7167 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7168
bc7b6697 7169 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7170 (xfont_open): Avoid unnecessary tests.
bc7b6697 7171
27ccc379
PE
7172 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7173
dcd5c89a
PE
7174 * composite.h, composite.c (composition_gstring_put_cache):
7175 Use EMACS_INT, not int, for length.
7176
b13a45c6
PE
7177 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7178 breaking out part of COMPOSITION_DECODE_RULE.
7179 (COMPOSITION_DECODE_RULE): Use it.
7180 * composite.c (get_composition_id): Remove unused local vars,
7181 by using the new macro.
7182
1e792e4d
PE
7183 * textprop.c (set_text_properties_1): Change while to do-while,
7184 since the condition is always true at first.
7185
dc6c6455 7186 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7187 (interval_deletion_adjustment): Return unsigned value.
7188 All uses changed.
dc6c6455 7189
aba7731a
PE
7190 * process.c (list_processes_1, create_pty, read_process_output):
7191 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7192 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7193 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7194 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7195 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7196
fdfc4bf3
PE
7197 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7198
fca8fe46 7199 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7200 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7201
06a0259a 7202 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7203 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7204 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7205
e7b9e80f
PE
7206 * print.c (print_error_message): Avoid int overflow.
7207
56201685
PE
7208 * font.c (font_list_entities): Redo for clarity,
7209 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7210
78834453 7211 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7212 (font_score): Avoid potential overflow in diff calculation.
78834453 7213
0bc0b309 7214 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7215 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7216
e610eaca
PE
7217 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7218
b895abce
PE
7219 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7220 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7221 can always succeed if overflow has undefined behavior.
7222
1f1d9321 7223 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7224 (wordify): Omit three unnecessary tests.
1f1d9321 7225
c59478bc
PE
7226 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7227 All callers changed. This avoids the need for an unused var.
7228
79b73827
PE
7229 * casefiddle.c (casify_region): Remove var that is set but not used.
7230
a4db5dfe
PE
7231 * dired.c (file_name_completion): Remove var that is set but not used.
7232
43aae36e
PE
7233 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7234
2a47c44d 7235 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7236 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7237
a37c69bf
PE
7238 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7239 Check for integer overflow on size calculations.
7240
328ab8e7
PE
7241 * buffer.c (Fprevious_overlay_change): Remove var that is set
7242 but not used.
7243
e5a2a5cb
PE
7244 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7245 Remove vars that are set but not used.
8d84a6eb 7246 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7247 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7248
a60e5f68
PE
7249 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7250
f661cb61 7251 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7252 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7253
f0397f5a
PE
7254 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7255 that are set but not used.
7256
8664db06 7257 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7258 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7259
6abdaa4a
PE
7260 * xselect.c (x_get_local_selection, x_handle_property_notify):
7261 Remove vars that are set but not used.
7262
0ce7538d 7263 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7264 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7265
9ae848fc
PE
7266 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7267 Remove var that is set but not used.
0b918413
PE
7268 (scroll_bar_windows_size): Now size_t, not int.
7269 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7270 Check for overflow.
9ae848fc 7271
a5a62657
PE
7272 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7273 (map_tty_color) [!defined MSDOS]: Likewise.
7274
5c5cdd39
PE
7275 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7276
66ebf983
PE
7277 * coding.c: Remove vars that are set but not used.
7278 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7279 All callers changed.
7280 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7281 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7282 (decode_coding_charset): Remove vars that are set but not used.
7283
1be4d761
PE
7284 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7285 that is set but not used.
7286
47553fa8
PE
7287 * print.c (print_object): Remove var that is set but not used.
7288
1f7196bf 7289 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7290 The gnulib version avoids calling malloc in the usual case,
7291 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7292 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7293 * filelock.c (current_lock_owner): Likewise.
7294 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7295 * sysdep.c: Include allocator.h, careadlinkat.h.
7296 (emacs_no_realloc_allocator): New static constant.
7297 (emacs_readlink): New function.
fdb61804
PE
7298 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7299 ../lib/careadlinkat.h.
d1fdcab7 7300
f84c17c7
SM
73012011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7302
7303 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7304 first non-nil return value).
7305
ef3862ad
JD
73062011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7307
7308 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7309 if not defined (Bug#8403).
7310
376a7006
JB
73112011-04-02 Juanma Barranquero <lekktu@gmail.com>
7312
7313 * xdisp.c (display_count_lines): Remove parameter `start',
7314 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7315 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7316 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7317 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7318 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7319 and thereabouts. All callers changed.
7320 (get_per_char_metric): Remove parameter `f', unused since
7321 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7322
6ca3801d
JM
73232011-04-02 Jim Meyering <meyering@redhat.com>
7324
7325 do not dereference NULL upon failed strdup
7326 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7327 (ns_get_family): Likewise.
7328
d8e2b5ba
JB
73292011-04-02 Juanma Barranquero <lekktu@gmail.com>
7330
7331 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7332
8c74fcbd
JD
73332011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7334
7335 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7336 later (Bug#8403).
7337
7200d79c
SM
73382011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7339
03408648 7340 Add lexical binding.
7200d79c 7341
03408648
SM
7342 * window.c (Ftemp_output_buffer_show): New fun.
7343 (Fsave_window_excursion):
7344 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7345
7346 * lread.c (lisp_file_lexically_bound_p): New function.
7347 (Fload): Bind Qlexical_binding.
7348 (readevalloop): Remove `evalfun' arg.
7349 Bind Qinternal_interpreter_environment.
7350 (Feval_buffer): Bind Qlexical_binding.
7351 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7352 Mark as dynamic.
7353 (syms_of_lread): Declare `lexical-binding'.
7354
7355 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7356
7357 * keyboard.c (eval_dyn): New fun.
7358 (menu_item_eval_property): Use it.
ca105506
SM
7359
7360 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7361
03408648
SM
7362 * fns.c (concat, mapcar1): Accept byte-code-functions.
7363
7364 * eval.c (Fsetq): Handle lexical vars.
7365 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7366 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7367 (FletX, Flet): Obey lexical binding.
7368 (Fcommandp): Handle closures.
7369 (Feval): New `lexical' arg.
7370 (eval_sub): New function extracted from Feval. Use it almost
7371 everywhere where Feval was used. Look up vars in lexical env.
7372 Handle closures.
7373 (Ffunctionp): Move from subr.el.
7374 (Ffuncall): Handle closures.
7375 (apply_lambda): Remove `eval_flags'.
7376 (funcall_lambda): Handle closures and new byte-code-functions.
7377 (Fspecial_variable_p): New function.
7378 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7379 but without exporting it to Lisp.
23aba0ea 7380
23aba0ea 7381 * doc.c (Fdocumentation, store_function_docstring):
03408648 7382 * data.c (Finteractive_form): Handle closures.
23aba0ea 7383
03408648
SM
7384 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7385 interactive spec.
ba83908c 7386
04f2d78b
CB
7387 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7388 New byte-codes.
03408648
SM
7389 (exec_byte_code): New function extracted from Fbyte_code to handle new
7390 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7391
03408648 7392 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7393
03408648 7394 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7395
e2abce01
JB
73962011-03-31 Juanma Barranquero <lekktu@gmail.com>
7397
7398 * xdisp.c (redisplay_internal): Fix prototype.
7399
63696a73 74002011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7401
63696a73 7402 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7403 (try_scrolling): Use it when setting scroll_limit.
7404 Limit scrolling to 100 screen lines.
63696a73
EZ
7405 (redisplay_window): Even when falling back on "recentering",
7406 position point in the window according to scroll-conservatively,
7407 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7408
7409 (try_scrolling): When point is above the window, allow searching
7410 as far as scroll_max, or one screenful, to compute vertical
7411 distance from PT to the scroll margin position. This prevents
7412 try_scrolling from unnecessarily failing when
7413 scroll-conservatively is set to a value slightly larger than the
7414 window height. Clean up the case of PT below the margin at bottom
7415 of window: scroll_max can no longer be INT_MAX. When aggressive
7416 scrolling is in use, don't let point enter the opposite scroll
7417 margin as result of the scroll.
7418 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7419 threshold of 100 lines for never-recentering scrolling.
7420
e4cc2dfc
JB
74212011-03-31 Juanma Barranquero <lekktu@gmail.com>
7422
7423 * dispextern.h (move_it_by_lines):
7424 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7425 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7426 (message_log_check_duplicate): Remove parameters `prev_bol' and
7427 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7428 (redisplay_internal): Remove parameter `preserve_echo_area',
7429 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7430
7431 * indent.c (Fvertical_motion):
7432 * window.c (window_scroll_pixel_based, Frecenter):
7433 Don't pass `need_y_p' to `move_it_by_lines'.
7434
1c470562
SM
74352011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7436
44f230aa
SM
7437 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7438 steal a few bits to be more compact.
7439 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7440 Remove unneeded casts.
7441
1c470562
SM
7442 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7443
888adce9
ZK
74442011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7445
7446 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7447 binding" message (bug#7967).
7448
f838ed7b
PE
74492011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7450
77861b95
PE
7451 Fix more problems found by GCC 4.6.0's static checks.
7452
de6dbc14
PE
7453 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7454 Remove unused local var.
7455
f838ed7b
PE
7456 * editfns.c (Fmessage_box): Remove unused local var.
7457
792c7b2b
PE
7458 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7459 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7460 Omit unused local vars.
c499e557 7461 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7462 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7463 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7464 Omit unused local var.
7465
ba0165e1
PE
7466 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7467 Don't assume string length fits in int.
32ad8845 7468 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7469 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7470
3c59b4c9
PE
7471 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7472 instead of alloca (Bug#8344).
7473
a3eed478 7474 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7475 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7476
eb4d412d
PE
7477 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7478
1658b401
PE
7479 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7480 concerns.
7481
7482 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7483
7484 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7485
9a2c6e05
PE
7486 * keyboard.c (syms_of_keyboard): Use the same style as later
7487 in this function when indexing through an array. This also
7488 works around GCC bug 48267.
7489
03d0a109
PE
7490 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7491
44f730c8
PE
7492 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7493
fe75f926
PE
7494 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7495 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7496
ffa8c828
PE
7497 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7498 This avoids undefined behavior on integer overflow, and is a bit
7499 more convenient anyway since it is compared to a size_t variable.
7500
c5101a77
PE
7501 Variadic C functions now count arguments with size_t, not int.
7502 This avoids an unnecessary limitation on 64-bit machines, which
7503 caused (substring ...) to crash on large vectors (Bug#8344).
7504 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7505 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7506 All variadic functions and their callers changed accordingly.
c5101a77
PE
7507 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7508 * data.c (arith_driver, float_arith_driver): Likewise.
7509 * editfns.c (general_insert_function): Likewise.
7510 * eval.c (struct backtrace.nargs, interactive_p)
7511 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7512 (funcall_lambda, mark_backtrace): Likewise.
7513 * fns.c (concat): Likewise.
7514 * frame.c (x_set_frame_parameters): Likewise.
7515 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7516 0 if not found, not -1. All callers changed.
7517
dd3f25f7
PE
7518 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7519 (stack_copy_size): Now size_t, not int.
7520 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7521
461c2ab9
JB
75222011-03-28 Juanma Barranquero <lekktu@gmail.com>
7523
7524 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7525 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7526 All callers changed.
7527
7528 * lisp.h (multibyte_char_to_unibyte):
7529 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7530 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7531 * character.h (CHAR_TO_BYTE8):
7532 * cmds.c (internal_self_insert):
7533 * editfns.c (general_insert_function):
7534 * keymap.c (push_key_description):
7535 * search.c (Freplace_match):
7536 * xdisp.c (message_dolog, set_message_1): All callers changed.
7537
f6d62986
SM
75382011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7539
7540 * keyboard.c (safe_run_hook_funcall): New function.
7541 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7542 don't set the hook to nil, but remove the offending function instead.
7543 (Qcommand_hook_internal): Remove, unused.
7544 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7545 Vcommand_hook_internal.
7546
7547 * eval.c (enum run_hooks_condition): Remove.
7548 (funcall_nil, funcall_not): New functions.
7549 (run_hook_with_args): Call each function through a `funcall' argument.
7550 Remove `cond' argument, now redundant.
7551 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7552 (Frun_hook_with_args_until_failure): Adjust accordingly.
7553 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7554
1db5b1ad
JB
75552011-03-28 Juanma Barranquero <lekktu@gmail.com>
7556
7557 * dispextern.h (string_buffer_position): Remove declaration.
7558
7559 * print.c (strout): Remove parameter `multibyte', unused since
7560 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7561
7562 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7563 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7564 All callers changed.
7565
7566 * w32.c (_wsa_errlist): Use braces for struct initializers.
7567
7568 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7569 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7570 All callers changed.
7571 (string_buffer_position): Likewise. Also, make static (it's never
7572 used outside xdisp.c).
7573 (cursor_row_p): Remove parameter `w', unused since
7574 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7575 (decode_mode_spec): Remove parameter `precision', introduced during
7576 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7577 All callers changed.
7578
5ffb62aa
JD
75792011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7580
7581 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7582
461c2ab9 75832011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7584
7585 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7586 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7587 (ns_update_auto_hide_menu_bar): New functions.
7588 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7589 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7590 ns_constrain_all_frames.
7591 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7592 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7593
5c380ffb
JD
75942011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7595
7596 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7597
9af30bdf
GM
75982011-03-27 Glenn Morris <rgm@gnu.org>
7599
7600 * syssignal.h: Replace RETSIGTYPE with void.
7601 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7602 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7603 Replace SIGTYPE with void everywhere.
7604 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7605 * s/template.h (SIGTYPE): Remove commented out definition.
7606
e2abce01
JB
76072011-03-26 Eli Zaretskii <eliz@gnu.org>
7608
7609 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7610 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7611
f868cd8a
JB
76122011-03-26 Juanma Barranquero <lekktu@gmail.com>
7613
59eb0929
JB
7614 * w32.c (read_unc_volume): Use parameter `henum', instead of
7615 global variable `wget_enum_handle'.
7616
7617 * keymap.c (describe_vector): Remove parameters `indices' and
7618 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7619 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7620
f868cd8a
JB
7621 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7622
7623 * keyboard.c (timer_check): Remove parameter `do_it_now',
7624 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7625 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7626 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7627
7628 * keyboard.c (read_char):
7629 * w32menu.c (w32_menu_display_help):
7630 * xmenu.c (show_help_event, menu_help_callback):
7631 Adjust calls to `show_help_echo'.
7632
7633 * gtkutil.c (xg_maybe_add_timer):
7634 * keyboard.c (readable_events):
7635 * process.c (wait_reading_process_output):
7636 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7637
7638 * insdel.c (adjust_markers_gap_motion):
7639 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7640 (gap_left, gap_right): Don't call it.
7641
2ecf6fdb
CY
76422011-03-25 Chong Yidong <cyd@stupidchicken.com>
7643
7644 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7645 incurred during fontification.
7646
6b1f9ba4
JB
76472011-03-25 Juanma Barranquero <lekktu@gmail.com>
7648
7649 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7650 (DEFVAR_PER_BUFFER): Don't pass it.
7651
7652 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7653 (scrolling_window): Don't pass it.
7654
0f4a96b5
JB
76552011-03-25 Juanma Barranquero <lekktu@gmail.com>
7656
7657 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7658
7659 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7660 and `suffix'.
7661 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7662 of variables specific to SELinux and computation of `encoded_absname'.
7663
7664 * image.c (XPutPixel): Remove unused variable `height'.
7665
7666 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7667
7668 * unexw32.c (get_section_info): Remove unused variable `section'.
7669
7670 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7671 (system_process_attributes): Remove unused variable `sess'.
7672 (sys_read): Remove unused variable `err'.
7673
7674 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7675 (w32_wnd_proc): Remove unused variable `isdead'.
7676 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7677 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7678 (x_create_tip_frame): Remove unused variable `tem'.
7679
7680 * w32inevt.c (w32_console_read_socket):
7681 Remove unused variable `no_events'.
7682
7683 * w32term.c (x_draw_composite_glyph_string_foreground):
7684 Remove unused variable `width'.
7685
1149507c
JB
76862011-03-24 Juanma Barranquero <lekktu@gmail.com>
7687
7688 * w32term.c (x_set_glyph_string_clipping):
7689 Don't pass uninitialized region to CombineRgn.
7690
9c88f339
JB
76912011-03-23 Juanma Barranquero <lekktu@gmail.com>
7692
7693 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7694 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7695 (Fx_close_connection): Remove unused variable `i'.
7696
7697 * w32font.c (w32font_draw): Return number of glyphs.
7698 (w32font_open_internal): Remove unused variable `i'.
7699 (w32font_driver): Add missing initializer.
7700
7701 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7702 (fill_in_menu): Remove unused variable `items_added'.
7703
7704 * w32term.c (last_mouse_press_frame): Remove static global variable.
7705 (w32_clip_to_row): Remove unused variable `f'.
7706 (x_delete_terminal): Remove unused variable `i'.
7707
7708 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7709 (NOTHING): Remove unused static global variable.
7710 (uniscribe_check_otf): Remove unused variable `table'.
7711 (uniscribe_font_driver): Add missing initializers.
7712
dee091a3
JD
77132011-03-23 Julien Danjou <julien@danjou.info>
7714
7715 * term.c (Fsuspend_tty, Fresume_tty):
7716 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7717 * window.c (temp_output_buffer_show):
7718 * insdel.c (signal_before_change):
7719 * frame.c (Fhandle_switch_frame):
7720 * fileio.c (Fdo_auto_save):
7721 * emacs.c (Fkill_emacs):
7722 * editfns.c (save_excursion_restore):
7723 * cmds.c (internal_self_insert):
7724 * callint.c (Fcall_interactively):
7725 * buffer.c (Fkill_all_local_variables):
7726 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7727 Use Frun_hooks.
0f4a96b5 7728 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7729 unconditionnaly since it does the check itself.
7730
2c520ab5 77312011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7732
c9c49752
PE
7733 Fix more problems found by GCC 4.5.2's static checks.
7734
8abc3f12
PE
7735 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7736 the first time through the loop, since we know p0 < p1 then.
7737 This also avoids a gcc -Wstrict-overflow warning.
7738
a2d26660
PE
7739 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7740 leading to a memory leak, possible in functions like
7741 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7742 of objects (Bug#8318).
a2d26660 7743
916c72e9
PE
7744 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7745 that could (at least in theory) be that large.
7746
19ab8a18
PE
7747 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7748 This is less likely to overflow, and avoids undefined behavior if
7749 overflow does occur. All callers changed. Use strtoul to scan
7750 for the unsigned long integer.
b7cbbd6f
PE
7751 (pint2hrstr): Simplify and tune code slightly.
7752 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7753
f0641eff
PE
7754 * scroll.c (do_scrolling): Work around GCC bug 48228.
7755 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7756
7f650bb9
PE
7757 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7758 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7759 (validate_x_resource_name): Simplify count usage.
7760 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7761
37dd57d1
PE
7762 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7763 fail (Bug#8306).
81e56e61 7764
699979fc 7765 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7766
401bf9b4
PE
7767 * process.c (Fmake_network_process): Use socklen_t, not int,
7768 where POSIX says socklen_t is required in portable programs.
7769 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7770 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7771 (Fmake_network_process, server_accept_connection):
7772 (wait_reading_process_output, read_process_output):
7773 Likewise.
7774
b93aacde
PE
7775 * process.c: Rename or move locals to avoid shadowing.
7776 (list_processes_1, Fmake_network_process):
7777 (read_process_output_error_handler, exec_sentinel_error_handler):
7778 Rename or move locals.
4dc343ee 7779 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7780 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7781 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7782 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7783 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7784
af8a867c 7785 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7786 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7787 Include tparam.h instead, since it declares them.
af8a867c
PE
7788 * cm.h (PC): Remove extern decl; tparam.h now does this.
7789 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7790 * terminfo.c: Include tparam.h, to check interfaces.
7791 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7792 (tparam): Adjust signature to match interface in tparam.h;
7793 this removes some undefined behavior. Check that outstring and len
7794 are zero, which they always are with Emacs.
7795 * tparam.h (PC, BC, UP): New extern decls.
7796
0248044d 7797 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7798 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7799
8ff096c1 7800 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7801 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7802 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7803 (ftfont_list): Remove unused local.
49eaafba
PE
7804 (get_adstyle_property, ftfont_pattern_entity):
7805 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7806 Rename locals to avoid shadowing.
8ff096c1 7807
e2be39f6
PE
7808 * xfont.c (xfont_list_family): Mark var as initialized.
7809
c9735e30
PE
7810 * xml.c (make_dom): Now static.
7811
8f5201ae
PE
7812 * composite.c (composition_compute_stop_pos): Rename local to
7813 avoid shadowing.
b246f932
PE
7814 (composition_reseat_it): Remove unused locals.
7815 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7816 (composition_update_it): Mark var as initialized.
11b61122
PE
7817 (find_automatic_composition): Mark vars as initialized,
7818 with a FIXME (Bug#8290).
8f5201ae 7819
760fbc2c
PE
7820 character.h: Rename locals to avoid shadowing.
7821 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7822 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7823 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7824 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7825 to avoid shadowing.
7826
ff08eb85
PE
7827 * textprop.c (property_change_between_p): Remove; unused.
7828
fc7bf025
PE
7829 * intervals.c (interval_start_pos): Now static.
7830
235d7abc
PE
7831 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7832
44f230aa
SM
7833 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7834 Rename locals to avoid shadowing.
3e7d6594 7835
50060332
PE
7836 * sound.c (wav_play, au_play, Fplay_sound_internal):
7837 Fix pointer signedness.
d01f234b 7838 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7839 (wav_play): Initialize a variable to 0, to prevent undefined
7840 behavior (Bug#8278).
50060332 7841
c4fc4e30
PE
7842 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7843
918436ed
PE
7844 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7845
c939f91b
PE
7846 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7847 clobbering (Bug#8298).
b9c7f648
PE
7848 * sysdep.c (sys_subshell): Likewise.
7849 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7850
6bd8c144
PE
7851 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7852 This should get cleaned up, so that child_setup has the
7853 same signature on all platforms.
7854
7710357c 7855 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7856 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7857
c59da222
CY
78582011-03-22 Chong Yidong <cyd@stupidchicken.com>
7859
7860 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7861 not to be necessary, and produces flickering.
7862
66b87493
GM
78632011-03-20 Glenn Morris <rgm@gnu.org>
7864
7865 * config.in: Remove file.
7866
45b6f6d5
JB
78672011-03-20 Juanma Barranquero <lekktu@gmail.com>
7868
7869 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7870 are now in src/globals.h.
7871 (syms_of_minibuf): Remove spurious & from previous change.
7872
3ec03f7e
LL
78732011-03-20 Leo <sdl.web@gmail.com>
7874
7875 * minibuf.c (completing-read-function): New variable.
7876 (completing-read-default): Rename from completing-read.
7877 (completing-read): Call completing-read-function.
7878
b14e3e21
CY
78792011-03-19 Juanma Barranquero <lekktu@gmail.com>
7880
7881 * xfaces.c (Fx_load_color_file):
7882 Read color file from absolute filename (bug#8250).
7883
f2b726e6
JB
78842011-03-19 Juanma Barranquero <lekktu@gmail.com>
7885
7886 * makefile.w32-in: Update dependencies.
7887
09f6ff02
EZ
78882011-03-17 Eli Zaretskii <eliz@gnu.org>
7889
7890 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7891
29a6015a
PE
78922011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7893
a3a6c54e
PE
7894 Fix more problems found by GCC 4.5.2's static checks.
7895
b766f867
PE
7896 * process.c (make_serial_process_unwind, send_process_trap):
7897 (sigchld_handler): Now static.
7898
be02381c
PE
7899 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7900 That way, the code declares only the vars that it needs.
7901 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7902 * s/cygwin.h (PTY_ITERATION): Likewise.
7903 * s/darwin.h (PTY_ITERATION): Likewise.
7904 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7905
57048744
PE
7906 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7907 * process.c (allocate_pty): Don't declare stb unless it's needed.
7908
7914961c 7909 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7910 (CONSTANTLIM): Remove; unused.
7911 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7912 Define only if needed.
7914961c 7913
b3967b18
PE
7914 * unexelf.c (unexec): Name an expression,
7915 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7916 Use a different way to cause a compilation error if anyone uses
7917 n rather than nn, a way that does not involve shadowing.
73366a00 7918 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7919
29a6015a
PE
7920 * deps.mk (unexalpha.o): Remove; unused.
7921
43cfc33e 7922 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7923 * unexec.h: New file.
ce701a33
PE
7924 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7925 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7926 Depend on unexec.h.
7927 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7928 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7929 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7930 Change as necessary to match prototype in unexec.h.
ce701a33 7931
01f44d5a
PE
7932 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7933 shadowing.
4f63c6bb 7934 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7935
a6670b0b
PE
7936 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7937 Rename locals to avoid shadowing.
7938
cef2010d 7939 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7940 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7941
d4d7173a
PE
7942 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7943
f08b802a
PE
7944 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7945 warning when compiling print.c.
7946
3ddb0639
PE
7947 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7948 instead of using an uninitialized var.
5ad03b97 7949 (font_sort_entities): Mark var as initialized.
3ddb0639 7950
170a2692
PE
7951 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7952
e663c700
PE
7953 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7954 pointers to constants.
89bc529a 7955 (font_parse_fcname): Remove unused vars.
7b81e2d0 7956 (font_delete_unmatched): Now static.
ea838e10 7957 (font_get_spec): Remove; unused.
13a547c6
PE
7958 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7959 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7960 Rename or move locals to avoid shadowing.
e663c700 7961
2a80c887 7962 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7963 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7964
1384fa33 7965 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7966 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7967
8b2c52e9
PE
7968 * alloc.c (mark_backtrace): Move decl from here ...
7969 * lisp.h: ... to here, so that it can be checked.
7970
475545b5 7971 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7972 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7973 (lisp_indirect_variable): Name an expression,
7974 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7975 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7976
b1349114 7977 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7978 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7979 Use const pointer when appropriate.
b1349114 7980
a2928364
PE
7981 * lisp.h (get_system_name, get_operating_system_release):
7982 Move decls here, to check interfaces.
7983 * process.c (get_operating_system_release): Move decl to lisp.h.
7984 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7985 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7986 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7987 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7988 (Fformat_time_string, Fencode_time, Finsert_char):
7989 (Ftranslate_region_internal, Fformat):
7990 Rename or remove local vars to avoid shadowing.
9710023e 7991 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7992
a415e694
PE
7993 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7994 avoid shadowing.
7995
8ef4622d
PE
7996 * lisp.h (eassert): Check that the argument compiles, even if
7997 ENABLE_CHECKING is not defined.
7998
946f9a5b
PE
7999 * data.c (Findirect_variable): Name an expression, to avoid
8000 gcc -Wbad-function-cast warning.
112396d6 8001 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8002 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8003 (Fmake_variable_buffer_local, Fmake_local_variable):
8004 Mark variables as initialized.
52746918 8005 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8006
e5aab7e7 8007 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8008 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8009 Rename locals to avoid shadowing.
dff45157
PE
8010 (mark_stack): Move local variables into the #ifdef region where
8011 they're used.
7bc26fdb
PE
8012 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8013 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8014 needed otherwise.
8015 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8016 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8017 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8018
e5aab7e7
PE
8019 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8020 avoids undefined behavior in theory.
8021
4da60324
PE
8022 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8023
88043301
PE
8024 Use functions, not macros, for up- and down-casing (Bug#8254).
8025 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8026 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8027 to use the following functions instead of these macros.
8028 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8029 EMACS_INT, since callers assume the returned value fits in int.
8030 (upcase1): Likewise, for UPCASE_TABLE.
8031 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8032 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8033 the race-condition problem in the old DOWNCASE.
88043301 8034
19ed5445
PE
8035 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8036 Rename locals to avoid shadowing.
8037 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8038 (regex_compile, re_search_2, re_match_2_internal):
8039 Remove unused local vars.
952db0d7
PE
8040 (FREE_VAR): Rewrite so as not to use empty "else",
8041 which gcc can warn about.
da053e48 8042 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8043 (RETALLOC_IF): Define only if needed.
8044 (WORDCHAR_P): Likewise. This one is never needed, but is used
8045 only in a comment talking about a compiler bug, so put inside
8046 the #if 0 of that comment.
8047 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8048 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8049 Remove; unused.
19ed5445 8050
1f3561e4 8051 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8052 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8053 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8054
ded6f8f7
PE
8055 * search.c (simple_search): Remove unused var.
8056
dbd37a95
PE
8057 * dired.c (compile_pattern): Move decl from here ...
8058 * lisp.h: ... to here, so that it can be checked.
8059 (struct re_registers): New forward decl.
8060
7e47afad
PE
8061 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8062
85f24f61
PE
8063 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8064 All uses changed.
8065 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8066 Rename locals to avoid shadowing.
5671df8f 8067 (Fvertical_motion): Mark locals as initialized.
85f24f61 8068
181aa2be 8069 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8070 (casify_region): Mark local as initialized.
181aa2be 8071
930d429c
PE
8072 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8073
7082eac6
PE
8074 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8075 New macros, so that the caller can use some names other than
8076 gcpro1, gcpro2, etc.
8077 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8078 of the new macros.
8079 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8080 argument, for consistency with GCPRO2_VAR, etc: it is now the
8081 prefix of the variable, not the variable itself. All uses
8082 changed.
38b2c076
PE
8083 * dired.c (directory_files_internal, file_name_completion):
8084 Rename locals to avoid shadowing.
8085
15206ed9
PE
8086 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8087 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8088 dired.c's scmp function, had undefined behavior.
8089 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8090 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8091 * buffer.h: ... to here, because these macros use current_buffer,
8092 and the new implementation with inline functions needs to have
8093 current_buffer in scope now, rather than later when the macros
8094 are used.
8095 (downcase, upcase1): New static inline functions.
8096 (DOWNCASE, UPCASE1): Reimplement using these functions.
8097 This avoids undefined behavior in expressions like
8098 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8099 from race conditions in accessing the global variables
8100 case_temp1 and case_temp2.
8101 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8102 * lisp.h (case_temp1, case_temp2): Remove their decls.
8103 * character.h (ASCII_CHAR_P): Move from here ...
8104 * lisp.h: ... to here, so that the inline functions mentioned
8105 above can use them.
8106
4a6bea26
PE
8107 * dired.c (directory_files_internal_unwind): Now static.
8108
f14b7e14
PE
8109 * fileio.c (file_name_as_directory, directory_file_name):
8110 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8111 Now static.
2893f146
PE
8112 (file_name_as_directory): Use const pointers when appropriate.
8113 (Fexpand_file_name): Likewise. In particular, newdir might
8114 point at constant storage, so make it a const pointer.
fd4ead52 8115 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8116 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8117 signedness issues.
f839df0c
PE
8118 (Fset_file_times, Finsert_file_contents, auto_save_error):
8119 Rename locals to avoid shadowing.
f14b7e14 8120
5716756e 8121 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8122 (Ftry_completion, Fall_completions): Rename or remove locals
8123 to avoid shadowing.
5716756e 8124
b4c3046a
PE
8125 * marker.c (bytepos_to_charpos): Remove; unused.
8126
b45db522
PE
8127 * lisp.h (verify_bytepos, count_markers): New decls,
8128 so that gcc does not warn that these functions aren't declared.
8129
85876d07
PE
8130 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8131 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8132 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8133 (copy_text): Remove unused local var.
85876d07 8134
03d78a21 8135 * filelock.c (within_one_second): Now static.
b3dd38ab 8136 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8137
5df8f01b
PE
8138 * buffer.c (fix_overlays_before): Mark locals as initialized.
8139 (fix_start_end_in_overlays): Likewise. This function should be
8140 simplified by using pointers-to-pointers, but that's a different
8141 matter.
b1d876f1 8142 (switch_to_buffer_1): Now static.
8f54f30a
PE
8143 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8144 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8145
a70072c9 8146 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8147 Fix pointer signedness issue.
edced198
PE
8148 (sys_subshell): Mark local as volatile if checking for lint,
8149 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8150 (MAXPATHLEN): Define only if needed.
a70072c9 8151
a0977c44
PE
8152 * process.c (serial_open, serial_configure): Move decls from here ...
8153 * systty.h: ... to here, so that they can be checked.
8154
a884fdcc
PE
8155 * fns.c (get_random, seed_random): Move extern decls from here ...
8156 * lisp.h: ... to here, so that they can be checked.
8157
604efe86 8158 * sysdep.c (reset_io): Now static.
b8950c94 8159 (wait_for_termination_signal): Remove; unused.
604efe86 8160
38fc62d9
PE
8161 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8162 (copy_keymap_item, append_key, push_text_char_description):
8163 Now static.
1004a21a 8164 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8165 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8166 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8167 (describe_map_tree):
8168 Rename locals to avoid shadowing.
38fc62d9 8169
2f2650da
PE
8170 * keyboard.c: Declare functions static if they are not used elsewhere.
8171 (echo_char, echo_dash, cmd_error, top_level_2):
8172 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8173 (read_char, kbd_buffer_get_event, make_lispy_position):
8174 (make_lispy_event, make_lispy_movement, apply_modifiers):
8175 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8176 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8177 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8178 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8179 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8180
a053e86c 8181 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8182 (mark_kboards): Move decl here ...
8183 * alloc.c (mark_kboards): ... from here.
a053e86c 8184
4752793e
PE
8185 * lisp.h (force_auto_save_soon): New decl.
8186
74f10ca7 8187 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8188 (DEFINE_DUMMY_FUNCTION): New macro.
8189 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8190 Use it.
c03cd23f
PE
8191 (main): Add casts to avoid warnings
8192 if GCC considers string literals to be constants.
74f10ca7 8193
022e70d4
PE
8194 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8195
59d6fe83
PE
8196 * dbusbind.c: Pointer signedness fixes.
8197 (xd_signature, xd_append_arg, xd_initialize):
8198 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8199 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8200 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8201 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8202
78320123
PE
8203 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8204 if GCC considers string literals to be constants.
49cebcca 8205 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8206
35ac2a97
SM
82072011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8208
fb103ca9
SM
8209 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8210 (print_preprocess, print_object): New macro to fix last change.
8211
35ac2a97
SM
8212 * print.c (print_preprocess): Don't forget font objects.
8213
62973b41
JB
82142011-03-16 Juanma Barranquero <lekktu@gmail.com>
8215
8216 * emacs.c (USAGE3): Doc fixes.
8217
0e48bb22
AS
82182011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8219
8220 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8221 structure.
8222
7684e57b
JB
82232011-03-14 Juanma Barranquero <lekktu@gmail.com>
8224
8225 * lisp.h (VWindow_system, Qfile_name_history):
8226 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8227 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8228 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8229
8230 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8231 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8232
8233 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8234 * w32console.c (detect_input_pending, read_input_pending)
8235 (encode_terminal_code):
8236 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8237 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8238 (w32_system_caret_y, Qfile_name_history):
8239 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8240 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8241 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8242 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8243 * w32proc.c (Qlocal, report_file_error):
8244 * w32term.c (Vwindow_system, updating_frame):
8245 * w32uniscribe.c (initialized, uniscribe_font_driver):
8246 Remove unneeded extern declarations.
8247
2aa46d6c
CY
82482011-03-14 Chong Yidong <cyd@stupidchicken.com>
8249
c96bbc66 8250 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8251
cffc6f3b
CY
82522011-03-13 Chong Yidong <cyd@stupidchicken.com>
8253
8254 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8255 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8256 These macros can no longer be used for assignment.
8257
44f230aa
SM
8258 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8259 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8260 (record_buffer_markers, fetch_buffer_markers): New functions for
8261 recording and fetching special buffer markers.
8262 (set_buffer_internal_1, set_buffer_temp): Use them.
8263
8264 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8265
8266 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8267
8268 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8269 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8270
8271 * xdisp.c (hscroll_window_tree):
8272 (reconsider_clip_changes): Use PT instead of BUF_PT.
8273
d251f04b
EZ
82742011-03-13 Eli Zaretskii <eliz@gnu.org>
8275
8276 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8277 $(EMACS_ROOT)/lib/intprops.h.
8278
f0c77cd1
PE
82792011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8280
3eca4629
PE
8281 Fix more problems found by GCC 4.5.2's static checks.
8282
7c86ee98
PE
8283 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8284 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8285 (xg_free_frame_widgets): Make it clear that a local variable is
8286 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8287 (gdk_window_get_screen): Make it clear that this macro is needed
8288 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8289 (int_gtk_range_get_value): New function, which avoids a diagnostic
8290 from gcc -Wbad-function-cast.
8291 (xg_set_toolkit_scroll_bar_thumb): Use it.
8292 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8293 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8294 (get_utf8_string, xg_get_file_with_chooser):
8295 Rename locals to avoid shadowing.
8296 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8297
41729b81
PE
8298 * xgselect.c (xg_select): Remove unused var.
8299
f0c77cd1
PE
8300 * image.c (four_corners_best): Mark locals as initialized.
8301 (gif_load): Initialize transparent_p to zero (Bug#8238).
8302 Mark another local as initialized.
ec6cf4c6 8303 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8304
ce0ad53d 8305 * image.c (clear_image_cache): Now static.
d5d5a617 8306 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8307 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8308 (x_edge_detection): Remove unnecessary cast that
8309 gcc -Wbad-function-cast diagnoses.
2037898d 8310 (gif_load): Fix pointer signedness.
6ae141d6
PE
8311 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8312 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8313
33383987 83142011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8315
d32df629
PE
8316 Improve quality of tests for time stamp overflow.
8317 For example, without this patch (encode-time 0 0 0 1 1
8318 1152921504606846976) returns the obviously-bogus value (-948597
8319 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8320 reports time overflow. See
8321 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8322 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8323 * editfns.c: Include limits.h and intprops.h.
8324 (TIME_T_MIN, TIME_T_MAX): New macros.
8325 (time_overflow): Move earlier, to before first use.
8326 (hi_time, lo_time): New functions, for an accurate test for
8327 out-of-range times.
8328 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8329 (Fget_internal_run_time): Don't assume time_t fits in int.
8330 (make_time): Use list2 instead of Fcons twice.
8331 (Fdecode_time): More accurate test for out-of-range times.
8332 (check_tm_member): New function.
8333 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8334 (lisp_time_argument): Don't rely on undefined left-shift and
8335 right-shift behavior when checking for time stamp overflow.
8be6f318 8336
fe31d94c
PE
8337 * editfns.c (time_overflow): New function, refactoring common code.
8338 (Fformat_time_string, Fdecode_time, Fencode_time):
8339 (Fcurrent_time_string): Use it.
8340
8be6f318
PE
8341 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8342 * dired.c (make_time): Move to ...
8343 * editfns.c (make_time): ... here.
8344 * systime.h: Note the move.
8345
09d9db2c 83462011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8347
126bc0dc
YM
8348 * fringe.c (update_window_fringes): Remove unused variables.
8349
c47cbdfd
YM
8350 * unexmacosx.c (copy_data_segment): Also copy __got section.
8351 (Bug#8223)
8352
7ac80be9
EZ
83532011-03-12 Eli Zaretskii <eliz@gnu.org>
8354
c96bbc66 8355 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8356 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8357 Constify `char *' arguments and their references according to
8358 prototypes in tparam.h.
8359
ecb0f94d 8360 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8361
7ac80be9
EZ
8362 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8363 Adapt all references accordingly.
8364
8365 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8366
ef1fd07e
TT
83672011-03-11 Tom Tromey <tromey@redhat.com>
8368
8369 * buffer.c (syms_of_buffer): Remove obsolete comment.
8370
7ef4b50c
EZ
83712011-03-11 Eli Zaretskii <eliz@gnu.org>
8372
8373 * termhooks.h (encode_terminal_code): Declare prototype.
8374
8375 * msdos.c (encode_terminal_code): Don't declare prototype.
8376
8377 * term.c (encode_terminal_code): Now external again, used by
8378 w32console.c and msdos.c.
8379
44f230aa
SM
8380 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8381 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8382
4b1ec863 83832011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8384
1714f52b 8385 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8386
4b1ec863
PE
8387 * fringe.c (update_window_fringes): Mark locals as initialized
8388 (Bug#8227).
8389 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8390
524c7aa6
PE
8391 * alloc.c (mark_fringe_data): Move decl from here ...
8392 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8393 to check its interface.
8394 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8395
a5c0af81 8396 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8397 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8398 (fontset_font): Mark local as initialized.
a9a06e0b 8399 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8400
b4716021
PE
8401 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8402
811e9bac 8403 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8404 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8405 (x_own_selection, Fx_disown_selection_internal): Rename locals
8406 to avoid shadowing.
8407 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8408
7e3ab302
PE
8409 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8410 so that the caller can use some name other than gcpro1.
8411 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8412 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8413 (Fx_backspace_delete_keys_p):
8414 Use them to avoid shadowing, and rename vars to avoid shadowing.
8415 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8416 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8417 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8418 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8419 Remove unused locals.
7e3ab302
PE
8420 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8421 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8422 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8423 macros.
f78faa98 8424
e2b13473
PE
8425 * xterm.h (x_mouse_leave): New decl.
8426
77f23912
PE
8427 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8428 Remove unused functions.
cdf4ba58
PE
8429 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8430 (x_calc_absolute_position): Now static.
7411c686 8431 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8432 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8433 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8434 unless they are used.
38d0b34a
PE
8435 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8436 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8437 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8438 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8439 (x_error_catcher, x_connection_closed, x_error_handler):
8440 (x_error_quitter, xembed_send_message, x_iconify_frame):
8441 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8442 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8443 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8444
44f230aa
SM
8445 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8446 Rename or move locals to avoid shadowing.
6b463e58 8447 (tty_defined_color, merge_face_heights): Now static.
5967d051 8448 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8449 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8450 does not deduce is never used uninitialized.
73719eba
PE
8451 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8452 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8453
426994c3 8454 * terminal.c (store_terminal_param): Now static.
5489860b 8455
032f1620 8456 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8457 (set_frame_menubar): Remove unused local.
d4323972 8458 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8459 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8460 since they might point to immutable storage.
281585b0
PE
8461 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8462 since it's unused otherwise.
032f1620 8463
367c19e5 8464 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8465 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8466 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8467 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8468 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8469 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8470 does not deduce are never used uninitialized.
70739cbe 8471
07b48fa9
PE
8472 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8473
8868a238 8474 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8475 * window.c (window_loop, size_window):
8476 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8477
7e5cf297 8478 * window.c (display_buffer): Now static.
d6550a9f
PE
8479 (size_window): Mark variables that gcc -Wuninitialized
8480 does not deduce are never used uninitialized.
a586633d
PE
8481 * window.h (check_all_windows): New decl, to forestall
8482 gcc -Wmissing-prototypes diagnostic.
5b555da1 8483 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8484
f6095868
PE
8485 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8486 shadowing.
8487 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8488 Include <limits.h>.
8489 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8490 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8491 (load_charset_map): Mark variables that gcc -Wuninitialized
8492 does not deduce are never used uninitialized.
53df7c11 8493 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8494
f38b440c
PE
8495 * coding.c (coding_set_source, coding_set_destination):
8496 Use "else { /* comment */ }" rather than "else /* comment */;"
8497 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8498 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8499 a block, when the outer 'i' will do.
8500 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8501 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8502 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8503 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8504 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8505 Rename locals to avoid shadowing.
8506 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8507 * coding.c (emacs_mule_char, encode_invocation_designation):
8508 Now static, since they're not used elsewhere.
413bb2db 8509 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8510 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8511 (decode_coding_emacs_mule): Mark variables that gcc
8512 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8513 (detect_coding_iso_2022): Initialize a local variable that might
8514 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8515 this initialization is needed. (Bug#8211)
5f58e762
PE
8516 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8517 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8518 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8519 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8520 Remove unused macros.
f38b440c 8521
232b38b9 8522 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8523 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8524 * character.c (string_count_byte8): Likewise.
232b38b9 8525
fb90da1b
PE
8526 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8527 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8528
fb93dbc2
PE
8529 * chartab.c (copy_sub_char_table): Now static, since it's not used
8530 elsewhere.
5c156ace
PE
8531 (sub_char_table_ref_and_range, char_table_ref_and_range):
8532 Rename locals to avoid shadowing.
bbcd0949 8533 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8534
7d3b3862 8535 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8536 (BIDI_BOB): Remove unused macro.
7d3b3862 8537
6be7d3da
PE
8538 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8539 deduce are never used uninitialized.
c2ed9c8b 8540 * term.c (encode_terminal_code): Likewise.
6be7d3da 8541
75f8807f 8542 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8543
50938595
PE
8544 * tparam.h: New file.
8545 * term.c, tparam.h: Include it.
8546 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8547 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8548 Move these decls to tparam.h, and make them agree with what
8549 is actually in tparam.c. The previous trick of using incompatible
8550 decls in different modules does not conform to the C standard.
8551 All callers of tparam changed to use tparam's actual API.
8552 * tparam.c (tparam1, tparam, tgoto):
8553 Use const pointers where appropriate.
8554
fbceeba2
PE
8555 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8556 * cm.h (struct cm): Likewise.
8557 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8558 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8559 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8560 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8561 (turn_on_face, init_tty): Likewise.
8562 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8563
7f3f1250
PE
8564 * term.c (term_mouse_position): Rename local to avoid shadowing.
8565
e6ca6543
PE
8566 * alloc.c (mark_ttys): Move decl from here ...
8567 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8568
c40f8d15
AS
85692011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8570
8571 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8572
cfe0661d
JB
85732011-03-09 Juanma Barranquero <lekktu@gmail.com>
8574
8575 * search.c (compile_pattern_1): Remove argument regp, unused since
8576 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8577 (compile_pattern): Don't pass it.
8578
0afb4571
J
85792011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8580
8581 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8582 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8583 for ! HAVE_GTK3.
8584 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8585
8586 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8587
8588 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8589 gdk_window_get_screen, gdk_window_get_geometry,
8590 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8591 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8592 (xg_get_pixbuf_from_pixmap): New function.
8593 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8594 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8595 Call xg_get_pixbuf_from_pixmap instead of
8596 gdk_pixbuf_get_from_drawable.
8597 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8598 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8599 (xg_check_special_colors): Use GtkStyleContext and its functions
8600 for HAVE_GTK3.
8601 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8602 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8603 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8604 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8605 Call gtk_widget_get_preferred_size.
0afb4571
J
8606 (xg_frame_resized): gdk_window_get_geometry only takes 5
8607 parameters.
44f230aa
SM
8608 (xg_win_to_widget, xg_event_is_for_menubar):
8609 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8610 (xg_set_widget_bg): New function.
8611 (delete_cb): New function.
895009e1 8612 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8613 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8614 (xg_set_background_color): Call xg_set_widget_bg.
8615 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8616 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8617 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8618 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8619 if ! HAVE_GTK3.
8620 (update_frame_tool_bar): Call gtk_widget_hide.
8621 (xg_initialize): Use GDK_KEY_g.
8622
8623 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8624 if ! HAVE_GTK3
8625 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8626
8627 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8628 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8629 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8630
1c2cc4ef
JB
86312011-03-08 Juanma Barranquero <lekktu@gmail.com>
8632
8633 * w32xfns.c (select_palette): Check success of RealizePalette against
8634 GDI_ERROR, not zero.
8635
33383987 8636See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8637
8638;; Local Variables:
8639;; coding: utf-8
aac0c6e3
MR
8640;; End:
8641
33383987 8642 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8643
8644 This file is part of GNU Emacs.
8645
8646 GNU Emacs is free software: you can redistribute it and/or modify
8647 it under the terms of the GNU General Public License as published by
8648 the Free Software Foundation, either version 3 of the License, or
8649 (at your option) any later version.
8650
8651 GNU Emacs is distributed in the hope that it will be useful,
8652 but WITHOUT ANY WARRANTY; without even the implied warranty of
8653 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8654 GNU General Public License for more details.
8655
8656 You should have received a copy of the GNU General Public License
8657 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.