More gnutls memory fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
435c1d67
CY
12011-10-27 Chong Yidong <cyd@gnu.org>
2
3 * process.c (make_process): Set gnutls_state to NULL.
4
5 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6 non-NULL, regardless of GNUTLS_INITSTAGE.
7 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
8 an error. Set process slots as soon as we allocate them.
9
10 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
11
9c6c6f49
CY
122011-10-27 Chong Yidong <cyd@gnu.org>
13
14 * gnutls.c (emacs_gnutls_deinit): New function. Deallocate
15 credentials structures as well as calling gnutls_deinit.
16 (Fgnutls_deinit, Fgnutls_boot): Use it.
17
18 * process.c (make_process): Initialize GnuTLS credentials to NULL.
19 (deactivate_process): Call emacs_gnutls_deinit.
20
657d08d3
JB
212011-10-27 Juanma Barranquero <lekktu@gmail.com>
22
23 * image.c (x_create_x_image_and_pixmap):
24 * w32.c (sys_rename, w32_delayed_load):
25 * w32font.c (fill_in_logfont):
26 * w32reg.c (x_get_string_resource): Silence compiler warnings.
27
5430d399
JB
282011-10-26 Juanma Barranquero <lekktu@gmail.com>
29
30 * w32fns.c (w32_default_color_map): New function,
31 extracted from Fw32_default_color_map.
a7ef684b 32 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 33
fe0055fa
PE
342011-10-25 Paul Eggert <eggert@cs.ucla.edu>
35
36 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
37
e6346438
SM
382011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
39
40 * keyboard.c (test_undefined): New function (bug#9751).
41 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
42
e112cc37
ET
432011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
44
45 * sysdep.c (init_sys_modes): Fix the check for the controlling
46 terminal (Bug#6649).
47
7b5d6677
EZ
482011-10-20 Eli Zaretskii <eliz@gnu.org>
49
50 * dispextern.h (struct bidi_it): New member next_en_type.
51
52 * bidi.c (bidi_line_init): Initialize the next_en_type member.
53 (bidi_resolve_explicit_1): When next_en_pos is valid for the
54 current character, check also for next_en_type being WEAK_EN.
55 (bidi_resolve_weak): Don't enter the expensive loop if the current
56 position is before next_en_pos. Record the bidi type of the first
57 non-ET, non-BN character we find, in addition to its position.
58 (bidi_level_of_next_char): Invalidate next_en_type when
59 next_en_pos is over-stepped.
60
7da0b018
PE
612011-10-20 Paul Eggert <eggert@cs.ucla.edu>
62
63 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
64 * editfns.c: Rewrite current-time-zone so that it invokes
65 the equivalent of (format-time-string "%Z") to get the time zone name.
66 This fixes a bug when the time zone name contains characters that
67 need converting from the system time locale to Emacs internal format.
68 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
69 that patch fixed format-time-string to do the conversion, but
70 I forgot to fix current-time-zone.
71 (format_time_string): New function, containing most of
72 what Fformat_time_string used to contain.
73 (Fformat_time_string): Rewrite in terms of format_time_string.
74 This doesn't change this function's behavior.
75 (current-time-zone): Rewrite to use format_time_string.
76 This fixes the bug reported by Michael Schierl in
77 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
78 Jason Rumney's 2007-06-07 change worked around this bug, but
79 didn't fix it.
80 * systime.h (tzname, timezone): Remove no-longer-used declarations.
81
8547b010
EZ
822011-10-19 Eli Zaretskii <eliz@gnu.org>
83
84 * xdisp.c (start_display): If the character at POS is displayed
85 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
86 (try_window_reusing_current_matrix): If a line ends in a display
87 vector or the next line starts in a display vector, continue
88 redrawing the window even though the character position of
89 start_row was reached.
8547b010
EZ
90 (Bug#9771, part 2)
91
4e948d15
CY
922011-10-18 Chong Yidong <cyd@gnu.org>
93
94 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
95 with nobreak-char-display too.
96
4787455f
EZ
972011-10-18 Eli Zaretskii <eliz@gnu.org>
98
99 Fix part 3 of bug#9771.
100 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
101 (bidi_resolve_neutral): Don't enter the expensive loop looking for
102 non-neutral characters if the current character is a paragraph
103 separator (a.k.a. Newline). This avoids running the same
104 expensive loop twice, once when we consume the preceding newline
105 and the other time when the line actually needs to be displayed.
106 Avoid the loop when we see neutrals on the base embedding level
107 following a character whose directionality is the same as the
108 paragraph's. This avoids running the expensive loop when a line
109 ends in a long sequence of neutrals, like control characters.
110 Add assertion against STRONG_AL type. Slightly rearrange code
111 that determines the type of a neutral given the first non-neutral
112 that follows it.
113 (bidi_level_of_next_char): Set next_en_pos to zero when
114 invalidating its info.
115
2c91f553
EZ
1162011-10-17 Eli Zaretskii <eliz@gnu.org>
117
118 * xdisp.c (push_display_prop): Determine whether to record string
119 or buffer position by IT->string, not by IT->method. Allow
120 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
121 (move_it_vertically_backward): Don't look for character position
122 immediately after the newline when in a continuation line.
123 (Bug#9771, part 1)
2c91f553 124
c7b08b0d
MR
1252011-10-15 Martin Rudalics <rudalics@gmx.at>
126
127 * window.c (coordinates_in_window): Rewrite and delabelize
128 vertical border check. (Bug#5357) (Bug#9618)
129
6b02f655
SM
1302011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
131
132 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
133 errors in XSetWindowBorder (bug#9310).
134
81d40c92
DA
1352011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
136
137 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
138 avoid crash when xmalloc overrun checking is enabled.
139
d4172c3b
EZ
1402011-10-13 Eli Zaretskii <eliz@gnu.org>
141
142 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
143 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
144 cursor motion with <left> and <right> arrow keys.
145
146 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
147 some callers set that themselves.
148
b00eea75
EZ
1492011-10-12 Eli Zaretskii <eliz@gnu.org>
150
151 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
152 display string and the previous row comes from the same string and
153 is empty. (Bug#9739) (Bug#9738)
154
8fe012c4
SM
1552011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
156
157 * doc.c (get_doc_string): Encode file name (bug#9735).
158
0074aef2
EZ
1592011-10-12 Eli Zaretskii <eliz@gnu.org>
160
79beb178
EZ
161 * bidi.c (bidi_level_of_next_char):
162 * xdisp.c (get_visually_first_element): Remove old incorrect
163 comments regarding the Unicode Line Separator character.
164
0074aef2
EZ
165 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
166
6e4b3fbe
DA
1672011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
168
169 * alloc.c (Fgc_status): Do not access beyond zombies array
170 boundary if nzombies > MAX_ZOMBIES.
171 * alloc.c (dump_zombies): Add missing format specifier.
172
0324f3af
PE
1732011-10-12 Paul Eggert <eggert@cs.ucla.edu>
174
b5525cac
PE
175 * xdisp.c (set_cursor_from_row): Simplify conditionals,
176 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
177
0324f3af
PE
178 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
179 Some packages use them to denote characters with modifiers.
180
e9b5f888
AS
1812011-10-11 Andreas Schwab <schwab@linux-m68k.org>
182
183 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
184 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
185 matching a pp-number. Rename parameter var to var1.
186
127827c0
SM
1872011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
188
189 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
190
c8fd3bd0
GM
1912011-10-08 Glenn Morris <rgm@gnu.org>
192
193 * callint.c (Fcall_interactively): Give a more explicit error for the
194 'c' case with a non-character input. (Bug#8479)
195
352ec8ff
EZ
1962011-10-08 Eli Zaretskii <eliz@gnu.org>
197
03669ccb
EZ
198 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
199 lines.
7061c986
EZ
200 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
201 lines that are hscrolled on the left.
03669ccb 202
352ec8ff
EZ
203 * dispnew.c (buffer_posn_from_coords): Account for a possible
204 presence of header-line. (Bug#4426)
205
a66cfb1c
SM
2062011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
207
6b02f655
SM
208 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
209 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 210
7c5ee88e
PE
2112011-10-07 Paul Eggert <eggert@cs.ucla.edu>
212
213 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
214 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
215 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
216 this makes Emacs dump core during garbage collection on rare
217 occasions. sizeof is obviously inferior to offsetof here, so
218 stick with offsetof.
219 (GC_POINTER_ALIGNMENT): New macro.
220 (mark_memory): Omit 3rd (offset) arg; caller changed.
221 Don't assume EMACS_INT alignment is the same as pointer alignment.
222
df1bbe5b
SM
2232011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
224
225 * keyboard.c (read_key_sequence_remapped): New var.
226 (read_key_sequence): Compute remapping in the right buffer.
227 (command_loop_1): Use read_key_sequence's remapping directly.
228
51553db6
SM
2292011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
230
32c1fffd
SM
231 * dired.c (file_name_completion): Don't expand file name.
232 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
233 before checking file name handler.
234
51553db6
SM
235 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
236 they've been requested explicitly (bug#9591).
237
b6bd1599 2382011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
239
240 * keymap.c (Fsingle_key_description): Use make_specified_string
241 instead of build_string to build string from push_key_description.
242 (Bug#5193)
243
f701dc2a
PE
2442011-09-30 Paul Eggert <eggert@cs.ucla.edu>
245
4222c55d
PE
246 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
247 This fixes a Y2038 bug on 64-bit hosts.
248 * buffer.c (reset_buffer):
249 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
250 (Fclear_buffer_auto_save_failure):
251 Use 0, not -1, to represent an unset failure time, since time_t
252 might not be signed.
253
f701dc2a
PE
254 Remove dependency on glibc malloc internals.
255 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
256 Move back here from lisp.h, but with their new implementations.
257 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
258 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
259 * charset.c (charset_table_init): New static var.
260 (syms_of_charset): Use it instead of xmalloc. This removes a
261 dependency on glibc malloc internals. See Eli Zaretskii's comment in
262 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
263 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
264 Move back to alloc.c.
265 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
266 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
267
9ceebf39
JD
2682011-09-30 Jan Djärv <jan.h.d@swipnet.se>
269
270 * nsterm.m (windowDidResize): Call x_set_window_size only when
271 ns_in_resize is true. Otherwise set pixelwidth/height and
272 call change_frame_size (Bug#9628).
273
cb993c58
PE
2742011-09-30 Paul Eggert <eggert@cs.ucla.edu>
275
3930c88b
PE
276 Port --enable-checking=all to Fedora 14 x86-64.
277 * charset.c (syms_of_charset): Also account for glibc malloc's
278 internal overhead when calculating the initial malloc maximum.
279
cb993c58
PE
280 Port --enable-checking=all to Fedora 14 x86.
281 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
282 Move to lisp.h.
283 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
284 (overrun_check_realloc, overrun_check_free):
285 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
286 That way, xmalloc returns a properly-aligned pointer even if
287 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
288 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
289 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
290 into account when calculating the initial malloc maximum.
291 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
292 Move here from alloc.c, so that charset.c can use it too.
293 Properly align; the old code wasn't right for common 32-bit hosts
294 when configured with --enable-checking=all.
295 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
296 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
297
31bed486
EZ
2982011-09-29 Eli Zaretskii <eliz@gnu.org>
299
04c70788 300 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
301 use EDOM.
302
fbcaa2f3
EZ
3032011-09-28 Eli Zaretskii <eliz@gnu.org>
304
305 * xdisp.c (compute_display_string_end): If there's no display
306 string at CHARPOS, return -1.
307
308 * bidi.c (bidi_fetch_char): When compute_display_string_end
309 returns a negative value, treat the character as a normal
310 character not covered by a display string. (Bug#9624)
311
a239d4e9
JB
3122011-09-28 Juanma Barranquero <lekktu@gmail.com>
313
314 * lread.c (Fread_from_string): Fix typo in docstring.
315
88652fd5
EZ
3162011-09-27 Eli Zaretskii <eliz@gnu.org>
317
318 * xdisp.c (handle_invisible_prop): If invisible text ends on a
319 newline, reseat the iterator instead of bidi-iterating there one
320 character at a time. (Bug#9610)
32c1fffd
SM
321 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
322 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 323
ed497dd4
AS
3242011-09-27 Andreas Schwab <schwab@linux-m68k.org>
325
326 * lread.c (readevalloop): Use correct code for NBSP.
327 (read1): Likewise. (Bug#9608)
328
b2bf61aa
MA
3292011-09-25 Michael Albinus <michael.albinus@gmx.de>
330
331 * dbusbind.c (Fdbus_register_signal): When service is not
332 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
333
32bbb17c
GM
3342011-09-25 Glenn Morris <rgm@gnu.org>
335
336 * buffer.c (truncate-lines): Doc fix.
337
94e0933e
CY
3382011-09-24 Chong Yidong <cyd@stupidchicken.com>
339
340 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
341 (Fset_window_next_buffers): Doc fix.
342
cddde921
GM
3432011-09-24 Glenn Morris <rgm@gnu.org>
344
345 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
346
1260aef1
PE
3472011-09-24 Paul Eggert <eggert@cs.ucla.edu>
348
25b4bfa0
PE
349 Fix minor problems found by static checking.
350 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
351 * indent.c (Fvertical_motion): Fix == vs = typo.
352
e3cbd34b
EZ
3532011-09-24 Eli Zaretskii <eliz@gnu.org>
354
a66cfb1c
SM
355 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
356 Default value is now t. Doc fix.
6bf7006f 357
e3cbd34b 358 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 359 logic when moving up, not only when moving down. Fix the
e3cbd34b 360 confusing name and values of the it_overshoot_expected variable;
32c1fffd 361 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
362
363 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
364 CHARPOS is covered by a display string which includes newlines.
365 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
366 is covered by a display string with embedded newlines.
367
a3de0cbd
MA
3682011-09-24 Michael Albinus <michael.albinus@gmx.de>
369
370 * dbusbind.c (Fdbus_register_signal): Add match rule to
371 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
372 (Fdbus_register_method, Vdbus_registered_objects_table):
373 Fix docstring.
a3de0cbd 374
b260039d
JM
3752011-09-24 Jim Meyering <meyering@redhat.com>
376
32c1fffd 377 do not ignore write error for any output size
b260039d
JM
378 The previous change was incomplete.
379 While it makes emacs --batch detect the vast majority of stdout
380 write failures, errors were still ignored whenever the output size is
381 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
382 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
383 && echo FAIL: ignored write error
384 FAIL: ignored write error
385 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
386 && echo FAIL: ignored write error
387 FAIL: ignored write error
388 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
389
8eca8a7c
AS
3902011-09-23 Andreas Schwab <schwab@linux-m68k.org>
391
392 * emacs.c (Fkill_emacs): In noninteractive mode exit
393 non-successfully if a write error occurred on stdout. (Bug#9574)
394
3341db62
EZ
3952011-09-21 Eli Zaretskii <eliz@gnu.org>
396
397 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
398 the xassert test.
399
400 * dispextern.h (struct it): Update the comment documenting what
401 can it->OBJECT be.
402
8c203dbf
EZ
4032011-09-20 Eli Zaretskii <eliz@gnu.org>
404
405 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
406 a display string, extend search for cursor position to end of row.
407 (find_row_edges): If the row ends in a newline from a display
408 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
409 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
410 (Fcurrent_bidi_paragraph_direction): Fix search for previous
411 non-empty line. Fixes confusing cursor motion with arrow keys at
412 the beginning of a line that starts with whitespace.
8c203dbf 413
a4824228
LMI
4142011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
415
416 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
417 (bug#9493).
418
33ed493b
CY
4192011-09-18 Chong Yidong <cyd@stupidchicken.com>
420
421 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
422 boolean (Bug#9154).
423
56cd55c8
EZ
4242011-09-18 Eli Zaretskii <eliz@gnu.org>
425
426 * xdisp.c (display_line): Record maximum and minimum buffer
427 positions even if no glyphs were produced (e.g., by a zero-width
428 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
429 buffer positions that will be removed from the glyph row because
430 they don't fit.
c02dcedf
EZ
431 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
432 column is beyond frame width: don't subtract 1 "pixel" when
433 computing width of the stretch.
3e62b7e0
EZ
434 (reseat_at_next_visible_line_start): Undo the change made on
435 2011-09-17 that saved paragraph information and restored it after
436 the call to `reseat'. (Bug#9545)
56cd55c8 437
5ed99d36 4382011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
439
440 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
441 and turn window cursor on if cleared (Bug#9415).
442
5ed99d36 4432011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
444
445 * search.c (boyer_moore): Take unibyte characters from pattern
446 literally. (Bug#9458)
447
9bade7b2
EZ
4482011-09-18 Eli Zaretskii <eliz@gnu.org>
449
450 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
451
e5e9d610
PE
4522011-09-18 Paul Eggert <eggert@cs.ucla.edu>
453
87e4427a
PE
454 Fix minor problem found by static checking.
455 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
456 initialized, to pacify gcc -Wuninitialized.
457
e5e9d610
PE
458 * fileio.c: Report proper errno when syscall falls.
459 (Finsert_file_contents): Save and restore errno,
460 so that report_file_error outputs the correct diagnostic.
461 (Fwrite_region) [CLASH_DETECTION]: Likewise.
462
a1674f0b
EZ
4632011-09-18 Eli Zaretskii <eliz@gnu.org>
464
465 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
466
fbfb6dd4
EZ
4672011-09-17 Eli Zaretskii <eliz@gnu.org>
468
469 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
470 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
471
bb187662
EZ
4722011-09-17 Eli Zaretskii <eliz@gnu.org>
473
1137e8b8 474 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 475 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
476
477 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
478 (bidi_find_paragraph_start): Search back for paragraph beginning
479 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
480 (bidi_move_to_visually_next): Only trigger paragraph-related
481 computations when the last character is a newline or at EOB, not
482 just any NEUTRAL_B. (Bug#9470)
483
bb187662
EZ
484 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
485 truncated lines if point is covered by a display string. (Bug#9524)
486
2e621251
PE
4872011-09-16 Paul Eggert <eggert@cs.ucla.edu>
488
489 * xselect.c: Relax test for outgoing X longs (Bug#9498).
490 (cons_to_x_long): New function.
491 (lisp_data_to_selection_data): Use it. Correct the test for
492 short-versus-long data; it was negated. Break out of vector
493 loop, for efficiency, when a long datum is discovered.
494
91a15bc6
SM
4952011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
496
497 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
498
b41c3a35
EZ
4992011-09-16 Eli Zaretskii <eliz@gnu.org>
500
501 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
502 GCC PR/17406) by declaring this function with external scope.
503
7812ba2d
PE
5042011-09-15 Paul Eggert <eggert@cs.ucla.edu>
505
506 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
507 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
508
cf7edc2a
AS
5092011-09-15 Andreas Schwab <schwab@linux-m68k.org>
510
511 * editfns.c (Fformat): Correctly handle text properties on "%%".
512
bd01620e
EZ
5132011-09-15 Eli Zaretskii <eliz@gnu.org>
514
515 * xterm.c (x_draw_composite_glyph_string_foreground):
516 * w32term.c (x_draw_composite_glyph_string_foreground):
517 * term.c (encode_terminal_code):
518 * composite.c (composition_update_it, get_composition_id):
519 * xdisp.c (get_next_display_element)
520 (fill_composite_glyph_string): Add comments about special meaning
521 of TAB characters in a composition.
522
a02719a3
PE
5232011-09-15 Paul Eggert <eggert@cs.ucla.edu>
524
525 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
526 This occurs when processing a multibyte format.
527 Problem reported by Wolfgang Jenker.
a02719a3 528
72589a3c
JB
5292011-09-15 Johan Bockgård <bojohan@gnu.org>
530
531 * xdisp.c (try_cursor_movement): Only check for exact match if
532 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
533
1c14176c
PE
5342011-09-14 Paul Eggert <eggert@cs.ucla.edu>
535
536 Remove unused external symbols.
537 * dispextern.h (calc_pixel_width_or_height): Remove decl.
538 * xdisp.c (calc_pixel_width_or_height): Now static.
539 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
540 * indent.c (check_display_width):
541 * w32term.c: Fix comment to match code.
542 * xterm.c, xterm.h (x_catching_errors): Remove.
543
d2eea5b5
PE
5442011-09-14 Paul Eggert <eggert@cs.ucla.edu>
545
546 * xselect.c: Use signed conversions more consistently (Bug#9498).
547 (selection_data_to_lisp_data): Assume incoming selection data are
548 signed integers, not unsigned. This is to be consistent with
549 outgoing selection data, which was modified to use signed integers
550 in as part of the fix to Bug#9196 in response to Jan D.'s comment
551 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
552 expects long, not unsigned long.
553
46888499
EZ
5542011-09-14 Eli Zaretskii <eliz@gnu.org>
555
556 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
557 computation of loop end. Reported by Johan Bockgård
558 <bojohan@gnu.org>.
559
ef8ef9fb
CY
5602011-09-13 Chong Yidong <cyd@stupidchicken.com>
561
562 * frame.c (Fother_visible_frames_p): Function deleted.
563
fa819fed
EZ
5642011-09-12 Eli Zaretskii <eliz@gnu.org>
565
566 * indent.c (compute_motion): Process display vector front to back
567 rather than the other way around. (Bug#2496)
568
2ba8e008
SM
5692011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
570
571 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
572
20f53c69
CY
5732011-09-11 Chong Yidong <cyd@stupidchicken.com>
574
575 * minibuf.c (Fread_from_minibuffer): Doc fix.
576
d562d7a4
EZ
5772011-09-11 Eli Zaretskii <eliz@gnu.org>
578
579 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
580 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
581
1c4d7f3d
LMI
5822011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
583
584 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
585 value for non-existent files.
586
b885bf36
EZ
5872011-09-11 Eli Zaretskii <eliz@gnu.org>
588
589 * fileio.c (Finsert_file_contents): If the file cannot be opened,
590 set its "size" to -1. This will set the modtime_size field of
591 the corresponding buffer to -1, which is what
592 verify-visited-file-modtime expects for files that do not exist.
593 (Bug#9139)
594
6612f0bf
PE
5952011-09-11 Paul Eggert <eggert@cs.ucla.edu>
596
597 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
598 here ...
599 * lisp.h: ... from here. push_key_description is no longer
600 defined in keyboard.c, so its declaration should not be in
601 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
602 logically belongs with push_key_description.
603
dfb3f755
PE
6042011-09-10 Paul Eggert <eggert@cs.ucla.edu>
605
606 * buffer.h: Include <sys/types.h> instead of <time.h>.
607 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
608 Problem reported by Herbert J. Skuhra.
609
3134906c
LMI
6102011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
611
612 * xml.c (parse_region): Make the parsing work for
613 non-comment-starting XML files again (bug#9144).
614
8d903f4e
AS
6152011-09-10 Andreas Schwab <schwab@linux-m68k.org>
616
617 * image.c (gif_load): Fix calculation of bottom and right corner.
618 (Bug#9468)
619
80ad64f4
EZ
6202011-09-10 Eli Zaretskii <eliz@gnu.org>
621
622 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
623 redisplay in small windows.
624
208a048d
EZ
6252011-09-09 Eli Zaretskii <eliz@gnu.org>
626
627 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
628
9b1c252e
MR
6292011-09-08 Martin Rudalics <rudalics@gmx.at>
630
631 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
632 Operate on live windows only.
633
2949f33b
JB
6342011-09-08 Juanma Barranquero <lekktu@gmail.com>
635
636 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
637
e08dcafd
EZ
6382011-09-07 Eli Zaretskii <eliz@gnu.org>
639
640 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
641 only under bidi iteration.
642
115b96bd
JD
6432011-09-07 Jan Djärv <jan.h.d@swipnet.se>
644
645 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
646
c8199d0f
PE
6472011-09-06 Paul Eggert <eggert@cs.ucla.edu>
648
649 isnan: Fix porting problem to Solaris 10 with bundled gcc.
650 Without this fix, the command to link temacs failed due to an
651 undefined symbol __builtin_isnan. This is because
652 /usr/include/iso/math_c99.h #defines isnan(x) to
653 __builtin_isnan(x), but the bundled gcc, which identifies itself
654 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
655 a __builtin_isnan.
656 * floatfns.c (isnan): #undef, and then #define to a clone of
657 what's in data.c.
658 (Fisnan): Always define, since it's always available now.
659 (syms_of_floatfns): Always define isnan at the Lisp level.
660
e39b275c 6612011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
662
663 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
664
b2db44d9 6652011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 666
f4af5137 667 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
668 The previous code assumed that file offsets (off_t values) fit in
669 EMACS_INT variables, which is not true on typical 32-bit hosts.
670 The code messed up by falsely reporting buffer overflow in cases
671 such as (insert-file-contents "big" nil 1 2) into an empty buffer
672 when "big" contains more than 2**29 bytes, even though this
673 inserts just one byte and does not overflow the buffer.
674 (Finsert_file_contents): Store file offsets as off_t
675 values, not as EMACS_INT values. Check for overflow when
676 converting between EMACS_INT and off_t. When checking for
677 buffer overflow or for overlap, take the offsets into account.
678 Don't use EMACS_INT for small values where int suffices.
679 When checking for overlap, fix a typo: ZV was used where
680 ZV_BYTE was intended.
681 (Fwrite_region): Don't assume off_t fits into 'long'.
682 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
683
ecfc0a49
MA
6842011-09-05 Michael Albinus <michael.albinus@gmx.de>
685
686 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
687
6511acf2 6882011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 689
0999621a 690 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
691
692 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 693 (esprintf, exprintf, evxprintf): New functions.
62f19c19 694 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 695 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
696 (modify_event_symbol): Do not assume that the length of
697 name_alist_or_stem is safe to alloca and fits in int.
698 (Fexecute_extended_command): Likewise for function name and binding.
699 (Frecursion_depth): Wrap around reliably on integer overflow.
700 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
701 since some callers pass EMACS_INT values.
702 (Fsingle_key_description): Don't crash if symbol name contains more
703 than MAX_ALLOCA bytes.
704 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
705 (get_minibuffer): Arg is now EMACS_INT, not int.
706 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 707 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
708 * window.h (command_loop_level, minibuf_level): Reflect API changes.
709
2be7d702
PE
710 * dbusbind.c (signature_cat): New function.
711 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
712 Do not overrun buffer; instead, report string overflow.
713
9d1df220
PE
714 * dispnew.c (add_window_display_history): Don't overrun buffer.
715 Truncate instead; this is OK since it's just a log.
716
33ef5c64
PE
717 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
718 even if the time zone offset is outlandishly large.
719 Don't mishandle offset == INT_MIN.
720
66c6fdd5
PE
721 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
722 when creating daemon; the previous buffer-overflow check was incorrect.
723
d749b01b
PE
724 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
725 which has the guts of the old verror function.
726
b5cd1905
PE
727 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
728 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
729
6e1a67fb
PE
730 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
731 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 732 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 733 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
734 length of string rather than counting it via multiple sprintfs;
735 that's simpler and more reliable.
c21721cc
PE
736 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
737 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
738 sprintf, in case result does not fit in int.
739
c57b67fc
PE
740 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
741 (fontset_from_font): Print it.
742
8a401434
PE
743 * frame.c (tty_frame_count): Now printmax_t, not int.
744 (make_terminal_frame, set_term_frame_name): Print it.
745 (x_report_frame_params): In X, window IDs are unsigned long,
746 not signed long, so print them as unsigned.
747 (validate_x_resource_name): Check for implausibly long names,
748 and don't assume name length fits in 'int'.
749 (x_get_resource_string): Don't blindly alloca invocation name;
750 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
751 not fit in int.
752
6e1a67fb
PE
753 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
754 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
755 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
756
0df02bf3
PE
757 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
758 Use esprintf, not sprintf, in case result does not fit in int.
759
48e30793
PE
760 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
761 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
762 it as a large positive number.
763 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
764 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
765
a66ff6d8
PE
766 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
767 in case result does not fit in int.
768
aca216ff
PE
769 * print.c (float_to_string): Detect width overflow more reliably.
770 (print_object): Make sprintf buffer a bit bigger, to avoid potential
771 buffer overrun. Don't assume list length fits in 'int'. Treat
772 print length of 0 as 0, not as infinity; to be consistent with other
773 uses of print length in this function. Don't overflow print length
774 index. Don't assume hash table size fits in 'long', or that
775 vectorlike size fits in 'unsigned long'.
776
31c286f7
PE
777 * process.c (make_process): Use printmax_t, not int, to format
778 process-name gensyms.
779
55e5faa1
PE
780 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
781
80f2e268
PE
782 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
783 to avoid potential buffer overrun.
784
670741ab
PE
785 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
786 if X resource line is longer than 512 bytes.
787
b7163a50
PE
788 * xfns.c (x_window): Make sprintf buffer a bit bigger
789 to avoid potential buffer overrun.
790
ae58ff1f
PE
791 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
792
c43c8a6a
PE
793 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
794
3f8236f4
PE
7952011-09-04 Paul Eggert <eggert@cs.ucla.edu>
796
53e9fe90 797 Integer overflow fixes for scrolling, etc.
6511acf2
PE
798 Without these, Emacs silently mishandles large integers sometimes.
799 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
800 it were "C-u 1 M-x recenter" on a typical 64-bit host.
801
6511acf2
PE
802 * xdisp.c (try_window_id): Check Emacs fixnum range before
803 converting to 'int'.
806add1d 804
6511acf2 805 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
806 Check that an Emacs fixnum is in range before assigning it to 'int'.
807 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
808 values converted from Emacs fixnums.
809 (Frecenter): Don't wrap around a line count if it is out of 'int'
810 range; instead, treat it as an extreme value.
811 (Fset_window_configuration, compare_window_configurations):
812 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
813
6511acf2
PE
814 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
815 that can exceed INT_MAX. Check that EMACS_INT value is in range
816 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
817 (match_limit): Don't assume that a fixnum can fit in 'int'.
818
6511acf2 819 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
820 exceed INT_MAX.
821
6511acf2 822 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
823 (Fvertical_motion): Don't wrap around LINES values that don't fit
824 in 'int'. Instead, treat them as extreme values. This is good
825 enough for windows, which can't have more than INT_MAX lines anyway.
826
fcb901a7
LMI
8272011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
828
0f2f6b6d
LMI
829 * Require libxml/parser.h to avoid compilation warning.
830
fcb901a7
LMI
831 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
832
833 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
834 since this reportedly can destroy thread storage.
835
6e20a0d4
CY
8362011-08-30 Chong Yidong <cyd@stupidchicken.com>
837
838 * syntax.c (find_defun_start): Update all cache variables if
839 exiting early (Bug#9401).
840
148ae00e
EZ
8412011-08-30 Eli Zaretskii <eliz@gnu.org>
842
f6cfbd8f
EZ
843 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
844
148ae00e
EZ
845 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
846 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
847 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
848
849 * term.c (tty_append_glyph): New function.
850 (produce_stretch_glyph): Static function and its prototype deleted.
851
a66cfb1c
SM
852 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
853 Add prototypes.
148ae00e 854
c4a07a4c
PE
8552011-08-29 Paul Eggert <eggert@cs.ucla.edu>
856
857 * image.c (parse_image_spec): Check for nonnegative, not for positive,
858 when checking :margin (Bug#9390).
859 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 860 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
861 so that the name doesn't mislead. All uses changed.
862
6bc8cd65
JB
8632011-08-28 Johan Bockgård <bojohan@gnu.org>
864
865 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
866 set_tty_hooks.
867
dca4927e
EZ
8682011-08-27 Eli Zaretskii <eliz@gnu.org>
869
870 * xdisp.c (move_it_to): Don't bail out early when reaching
871 position beyond to_charpos, if we are scanning backwards.
872 (move_it_vertically_backward): When DY == 0, make sure we get to
873 the first character in the line after the newline.
874
f2cad773
PE
8752011-08-27 Paul Eggert <eggert@cs.ucla.edu>
876
877 * ccl.c: Improve and simplify overflow checking (Bug#9196).
878 (ccl_driver): Do not generate an out-of-range pointer.
879 (Fccl_execute_on_string): Remove unnecessary check for
880 integer overflow, noted by Stefan Monnier in
881 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
882 Remove a FIXME that didn't need fixing.
883 Simplify the newly-introduced buffer reallocation code.
884
0cae2cdb
JB
8852011-08-27 Juanma Barranquero <lekktu@gmail.com>
886
887 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
888
5fc295a4 8892011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 890
70c60eb2 891 Integer and memory overflow issues (Bug#9196).
726e0ab1 892
d31850da
PE
893 * doc.c (get_doc_string): Rework so that
894 get_doc_string_buffer_size is the actual buffer size, rather than
895 being 1 less than the actual buffer size; this makes xpalloc more
896 convenient.
897
a69fbedb
PE
898 * image.c (x_allocate_bitmap_record, cache_image):
899 * xselect.c (Fx_register_dnd_atom):
900 Simplify previous changes by using xpalloc.
901
fe5c5d37
PE
902 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
903 since either will do and ptrdiff_t is convenient with xpalloc.
904
0065d054
PE
905 * charset.c (charset_table_size)
906 (struct charset_sort_data.priority): Now ptrdiff_t.
907 (charset_compare): Don't overflow if priorities differ greatly.
908 (Fsort_charsets): Don't assume list length fits in int.
909 Check for size-calculation overflow when allocating sort data.
910 (syms_of_charset): Allocate an initial charset table that is
911 just under 64 KiB, to avoid problems with glibc malloc and mmap.
912
913 * cmds.c (internal_self_insert): Check for size-calculation overflow.
914
915 * composite.h (struct composition.glyph_len): Now int, not unsigned.
916 The actual value is always <= INT_MAX, and leaving it unsigned made
917 overflow checking harder.
918
919 * dispextern.h (struct glyph_matrix.rows_allocated)
920 (struct face_cache.size): Now ptrdiff_t, for convenience in use
921 with xpalloc. The values are still always <= INT_MAX.
922
923 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
924
925 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
926 (SAFE_NALLOCA): New macro.
927
928 * region-cache.c (struct boundary.pos, find_cache_boundary)
929 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
930 (set_cache_region, invalidate_region_cache)
931 (revalidate_region_cache, know_region_cache, region_cache_forward)
932 (region_cache_backward, pp_cache):
933 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
934 so that ptrdiff_t * can be passed to xpalloc.
935 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
936 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
937 (pp_cache): Don't assume cache_len fits in int.
938 * region-cache.h: Adjust extern decls to match.
939
940 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
941 EMACS_INT, since either will do, for xpalloc.
942
943 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
944 (xnmalloc, xnrealloc, xpalloc): New functions.
945
726e0ab1
PE
946 * bidi.c (bidi_shelve_header_size): New constant.
947 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
948 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
949
51f30bc5 950 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
951 * buffer.c (overlays_at, overlays_in, record_overlay_string)
952 (overlay_strings):
953 Don't update size of array until after memory allocation succeeds,
954 because xmalloc/xrealloc may not return.
0065d054
PE
955 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
956 now that we have proper integer overflow checking.
957 (record_overlay_string, overlay_strings): Catch overflows when
958 calculating size of overlay_str_buf.
726e0ab1 959
0065d054
PE
960 * callproc.c (Fcall_process): Check for size overflow when
961 calculating size of args2.
962 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
963 Normally we prefer signed values, but sticking with ptrdiff_t would
964 require adding more-complicated checks.
726e0ab1
PE
965
966 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
967 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
968 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 969 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
970
971 * character.c (Fstring): Check for size-calculation overflow.
972
973 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
974 unnecessary integer overflow. Check for size overflow.
975 (encode_coding_object): Don't update size until xmalloc succeeds.
976
977 * composite.c (get_composition_id): Check for overflow in glyph
978 length calculations.
979
980 Integer and memory overflow fixes for display code.
981 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
982 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
983 (scrolling_window): Check for overflow in size calculations.
984 (line_draw_cost, realloc_glyph_pool, add_row_entry):
985 Don't assume glyph table len fits in int.
986 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
987 (row_table_size): Now ptrdiff_t, not int.
988 (scrolling_window): Avoid overflow in size calculations.
989 Don't update size until allocation succeeds.
990 * fns.c (concat): Check for overflow in size calculations.
991 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
992 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
993 (NEXT_ALMOST_PRIME_LIMIT): New constant.
994
995 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
996 (get_doc_string): Check for size calculation overflow.
997 Don't update size until allocation succeeds.
998 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
999 EMACS_INT, where ptrdiff_t will do.
1000 (Fsubstitute_command_keys): Check for string overflow.
1001
1002 * editfns.c (set_time_zone_rule): Don't assume environment length
1003 fits in int.
1004 (message_length): Now ptrdiff_t, not int.
1005 (Fmessage_box): Don't update size until allocation succeeds.
1006 Don't assume message length fits in int.
1007 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1008
0065d054
PE
1009 * emacs.c (main): Do not reallocate argv, since there is a null at
1010 the end that can be overwritten, and this way there's no need to
1011 worry about size-calculation overflow.
1012 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1013
1014 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1015 alloc succeeds.
1016 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1017
1018 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1019 (x_set_scroll_bar_width, x_figure_window_size):
1020 Check for integer overflow.
1021 (x_set_alpha): Do not assume XINT fits in int.
1022
1023 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1024 This is for the members text_lines, text_cols, total_lines, total_cols,
1025 where the system imposes an 'int' limit.
1026
1027 * fringe.c (Fdefine_fringe_bitmap):
1028 Don't update size until alloc works.
1029
1030 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1031 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1032
1033 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1034 Check for size-calculation overflow.
1035 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1036 do, as we prefer signed integers.
1037 (id_to_widget.max_size, id_to_widget.used)
1038 (xg_store_widget_in_map, xg_remove_widget_from_map)
1039 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1040 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1041 Use and return ptrdiff_t, not int.
1042 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1043 * gtkutil.h: Change prototypes to match the above.
1044
1045 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1046 are duplicate now that they've been promoted to lisp.h.
1047 (x_allocate_bitmap_record, x_alloc_image_color)
1048 (make_image_cache, cache_image, xpm_load):
1049 Don't update size until alloc is done.
1050 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1051 (x_detect_edges):
3256efce 1052 Check for size calculation overflow.
726e0ab1
PE
1053 (ct_colors_allocated_max): New constant.
1054 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1055 overflow.
3256efce 1056
726e0ab1
PE
1057 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1058 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1059 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1060 Use ptrdiff_t, not int, to count maps.
1061 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1062 calculations. Don't update size until allocation succeeds.
1063 Redo calculations to avoid overflow.
726e0ab1
PE
1064 * keyboard.h: Change prototypes to match the above.
1065
1066 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1067 to count maps.
1068 (current_minor_maps): Check for size calculation overflow.
1069 * keymap.h: Change prototypes to match the above.
1070
1071 * lread.c (read1, init_obarray): Don't update size until alloc done.
1072
1073 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1074 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1075
726e0ab1
PE
1076 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1077 Now ptrdiff_t, not int.
1078 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1079 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1080
1081 * process.c (Fnetwork_interface_list): Check for overflow
1082 in size calculation.
1083
1084 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1085
1086 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1087 overflow. Don't bother calling xmalloc when xrealloc will do.
1088
1089 * search.c (Freplace_match): Check for size calculation overflow.
1090 (Fset_match_data): Don't assume list lengths fit in 'int'.
1091
1092 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1093 for command line length. Do not attempt to address one before the
1094 beginning of an array, as that's not portable.
1095
1096 * term.c (max_frame_lines): Remove; unused.
1097 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1098 not int.
1099 (encode_terminal_code, calculate_costs): Check for size
1100 calculation overflow.
1101 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1102 table lengths and related sizes. Don't update size until alloc
1103 done. Redo calculations to avoid overflow.
1104 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1105
1106 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1107 subtracting pointers.
1108 (gobble_line): Check for overflow more carefully. Don't update size
1109 until alloc done.
1110
1111 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1112 Don't update size until alloc done.
1113 Redo size calculations to avoid overflow.
1114 Check for size calculation overflow.
0065d054 1115 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1116
1117 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1118 Use ptrdiff_t, not int, for sizes.
1119 (store_mode_line_noprop_char): Don't update size until alloc done.
1120
0065d054
PE
1121 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1122 Use ptrdiff_t, not int, for sizes.
1123 (Finternal_make_lisp_face, cache_face):
1124 Check for size calculation overflow.
1125 (cache_face): Treat size calculation overflows as if they were
1126 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1127
1128 * xfns.c (x_encode_text, x_set_name_internal)
1129 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1130 sizes, since they can exceed INT_MAX in size. Check for size
1131 calculation overflow.
1132
0065d054
PE
1133 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1134 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1135 Don't update size until alloc done.
1136
0065d054 1137 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1138 as sprintf is limited to int lengths.
1d526e2f 1139
252c5ee1
PE
1140 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1141 (X_LONG_MIN): New macros.
864d7ce7
PE
1142 Use them to make the following changes clearer.
1143 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1144 This change doesn't affect the value now, but it may help remind
1145 future maintainers not to raise the value too much later.
1146 (SELECTION_QUANTUM): Remove, replacing with ...
1147 (selection_quantum): ... new function, which avoids overflow.
1148 All uses changed.
1149 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1150 assumption that selection length fits in 'int'.
1151 (x_reply_selection_request, x_handle_selection_request)
1152 (x_get_window_property, receive_incremental_selection)
1153 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1154 (lisp_data_to_selection_data, clean_local_selection_data):
1155 Use ptrdiff_t, not int, to record length of selection.
1156 (x_reply_selection_request, x_get_window_property)
1157 (receive_incremental_selection, x_property_data_to_lisp):
1158 Redo calculations to avoid overflow.
1159 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1160 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1161 something.
1162 (x_get_window_property, receive_incremental_selection)
1163 (lisp_data_to_selection_data, x_property_data_to_lisp):
1164 Check for size-calculation overflow.
1165 (x_get_window_property, receive_incremental_selection)
1166 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1167 Don't store size until memory allocation succeeds.
1168 (x_get_window_property): Plug memory leak on memory exhaustion.
1169 Don't double-block input; malloc is safe here. Don't assume 2**34
1170 - 4 fits in unsigned long. Add an xassert to check
1171 XGetWindowProperty overflow. Be more careful about overflow
1172 calculations, and distinguish size from memory overflow better.
1173 (receive_incremental_selection): When tracing, don't assume
1174 unsigned int is less than INT_MAX.
1175 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1176 harmful) conversions of unsigned short to int.
1177 (lisp_data_to_selection_data): Don't assume that integers
1178 in the range -65535 through -1 fit in an X unsigned short.
1179 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1180 result parameters unless successful. Rely on cons_to_unsigned
1181 to report problems with elements; the old code wasn't right anyway.
1182 (x_check_property_data): Check for int overflow; we cannot use
1183 a wider type due to X limits.
1184 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1185
726e0ab1 1186 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1187
0065d054
PE
1188 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1189 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1190 (x_color_cells): Don't store size until memory allocation succeeds.
1191 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1192 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1193 (x_term_init): Don't assume length fits in int (sprintf is limited
1194 to int size).
bc18e09d 1195
ebfa62c0
PE
1196 Use ptrdiff_t for composition IDs.
1197 * character.c (lisp_string_width):
1198 * composite.c (composition_table_size, n_compositions)
1199 (get_composition_id, composition_gstring_from_id):
1200 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1201 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1202 * window.c (Frecenter):
1203 Use ptrdiff_t, not int, for composition IDs.
1204 * composite.c (get_composition_id): Check for integer overflow.
1205 * composite.h: Adjust prototypes to match the above changes.
1206
d3411f89
PE
1207 Use ptrdiff_t for hash table indexes.
1208 * category.c (hash_get_category_set):
1209 * ccl.c (ccl_driver):
1210 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1211 * coding.c (coding_system_charset_list, detect_coding_system):
1212 * coding.h (struct coding_system.id):
1213 * composite.c (get_composition_id, gstring_lookup_cache):
1214 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1215 * image.c (xpm_get_color_table_h):
1216 * lisp.h (hash_lookup, hash_put):
1217 * minibuf.c (Ftest_completion):
1218 Use ptrdiff_t for hash table indexes, not int (which is too
1219 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1220 32-bit --with-wide-int hosts).
1221
e097a6fa
PE
1222 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1223 Add a FIXME comment about memory leaks.
1224 (syms_of_charset): Don't assume xmalloc returns.
1225
5637687f
PE
1226 Don't assume that stated character widths fit in int.
1227 * character.c (Fchar_width, c_string_width, lisp_string_width):
1228 * character.h (CHAR_WIDTH):
1229 * indent.c (MULTIBYTE_BYTES_WIDTH):
1230 Use sanitize_char_width to avoid undefined and/or bad behavior
1231 with outlandish widths.
a66cfb1c 1232 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1233 now that we have two such functions. All uses changed.
1234 (sanitize_char_width): New inline function.
1235
a2271ba2
PE
1236 Don't assume that tab-width fits in int.
1237 * character.h (sanitize_width): New inline function.
1238 (SANE_TAB_WIDTH): New macro.
1239 (ASCII_CHAR_WIDTH): Use it.
1240 * indent.c (sane_tab_width): Remove. All uses replaced by
1241 SANE_TAB_WIDTH (current_buffer).
1242 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1243
18c52557
PE
1244 * fileio.c: Integer overflow issues with file modes.
1245 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1246
caeeedc1
PE
1247 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1248 Remove unreachable code.
1249 (read_hex, load_charset_map_from_file): Check for integer overflow.
1250
50849c52
PE
1251 * xterm.c: don't go over XClientMessageEvent limit
1252 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1253 (x_send_scroll_bar_event): Likewise. Check that the size does not
1254 exceed limits imposed by XClientMessageEvent, as well as the usual
1255 ptrdiff_t and size_t limits.
1256
b13995db
PE
1257 * keyboard.c: Overflow, signedness and related fixes.
1258 (make_lispy_movement): Use same integer type in forward decl
1259 that is used in the definition.
1260 (read_key_sequence, keyremap_step):
1261 Change bufsize argument back to int, undoing my 2011-03-30 change.
1262 We prefer signed types, and int is wide enough here.
1263 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1264 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1265 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1266 length, not size_t. Use ptrdiff_t for index, not int.
1267 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1268 possibility of integer overflow.
1269
13464394
PE
1270 Overflow, signedness and related fixes for images.
1271
1272 * dispextern.h (struct it.stack[0].u.image.image_id)
1273 (struct_it.image_id, struct image.id, struct image_cache.size)
1274 (struct image_cache.used, struct image_cache.ref_count):
1275 * gtkutil.c (update_frame_tool_bar):
1276 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1277 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1278 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1279 * nsmenu.m (update_frame_tool_bar):
1280 * xdisp.c (calc_pixel_width_or_height):
1281 * xfns.c (image_cache_refcount):
1282 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1283 on typical 64-bit hosts.
1284
1285 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1286 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1287 Omit unnecessary casts to int.
1288 (parse_image_spec): Check that integers fall into 'int' range
1289 when the callers expect that.
1290 (image_ascent): Redo ascent calculation to avoid int overflow.
1291 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1292 (lookup_image): Remove unnecessary tests.
1293 (xbm_image_p): Locals are now of int, not EMACS_INT,
1294 since parse_image_check makes sure they fit into int.
1295 (png_load, gif_load, svg_load_image):
1296 Prefer int to unsigned where either will do.
1297 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1298 old tiff_error_handler and tiff_warning_handler.
1299 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1300 stack buffer overflows. It uses only the features of vsnprintf
1301 that are common to both POSIX and native Microsoft.
1302 (tiff_error_handler, tiff_warning_handler): Use it.
1303 (tiff_load, gif_load, imagemagick_load_image):
1304 Don't assume :index value fits in 'int'.
1305 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1306 (imagemagick_load_image): Check that crop parameters fit into
1307 the integer types that MagickCropImage accepts. Don't assume
1308 Vimagemagick_render_type has a nonnegative value. Don't assume
1309 size_t fits in 'long'.
1310 (gs_load): Use printmax_t to print the widest integers possible.
1311 Check for integer overflow when computing image height and width.
1312
c11821d4
EZ
13132011-08-26 Eli Zaretskii <eliz@gnu.org>
1314
1315 * xdisp.c (redisplay_window): Don't force window start if point
1316 will be invisible in the resulting window. (Bug#9324)
1317
0c95fcf7
EZ
13182011-08-25 Eli Zaretskii <eliz@gnu.org>
1319
1320 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1321 the display spec is of the form `(space ...)'.
1322 (handle_display_spec): Return the value returned by
1323 handle_single_display_spec, not just 1 or zero.
1324 (handle_single_display_spec): If the display spec is of the form
1325 `(space ...)', and specifies display in the text area, return 2
1326 rather than 1.
fee65a97 1327 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1328 accurately, and prefer exact match for point under bidi.
1329 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1330
1331 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1332 into disp_prop; all users changed.
1333
1334 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1335 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1336 for the text covered by the display property.
1337
e4ed06f1
CY
13382011-08-25 Chong Yidong <cyd@stupidchicken.com>
1339
1340 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1341 Change return value to nil.
1342 (Frecord_buffer): Delete unused function.
1343
f67cdd7f
EZ
13442011-08-24 Eli Zaretskii <eliz@gnu.org>
1345
5980d4c6
EZ
1346 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1347 buffers, return left-to-right.
8610fe8b
EZ
1348 (set_cursor_from_row): Consider candidate row a win if its glyph
1349 represents a newline and point is on that newline. Fixes cursor
1350 positioning on the newline at EOL of R2L text within L2R
1351 paragraph, and vice versa.
1352 (try_cursor_movement): Check continued rows, in addition to
1353 continuation rows. Fixes unwarranted scroll when point enters a
1354 continued line of R2L text within an L2R paragraph, or vice versa.
1355 (cursor_row_p): Consider the case of point being equal to
1356 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1357 from the end of a short line to the beginning of a continued line
1358 of R2L text within L2R paragraph.
1359 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1360 composed characters.
5980d4c6 1361
f67cdd7f
EZ
1362 * bidi.c (bidi_check_type): Use xassert.
1363 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1364 members.
1365
bca633fb
EZ
13662011-08-23 Eli Zaretskii <eliz@gnu.org>
1367
1368 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1369 a character.
1370
4a5885a7
CY
13712011-08-23 Chong Yidong <cyd@stupidchicken.com>
1372
1373 * nsfont.m (ns_otf_to_script): Fix typo.
1374
0902a04e
KH
13752011-08-22 Kenichi Handa <handa@m17n.org>
1376
1377 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1378 extra slot even if the purpose is char-code-property-table.
1379
1a2e6670
EZ
13802011-08-23 Eli Zaretskii <eliz@gnu.org>
1381
8ddde651
EZ
1382 * xdisp.c (redisplay_window): When computing centering_position,
1383 account for the height of the header line. (Bug#8874)
1384
425cc014
EZ
1385 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1386 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1387 candidate is selected by the mouse, and that candidate has a
1388 composed character under the mouse.
1389
1a2e6670
EZ
1390 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1391 coordinates reported by pos-visible-in-window-p for a composed
1392 character in column zero.
1393
8b76d6f8
SM
13942011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1395
1396 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1397
dac347dd
EZ
13982011-08-22 Eli Zaretskii <eliz@gnu.org>
1399
1400 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1401 consider it a hit if to_charpos is anywhere in the range of the
1402 composed buffer positions.
1403
e013fb34
CY
14042011-08-22 Chong Yidong <cyd@stupidchicken.com>
1405
1406 * image.c (gif_load): Don't assume that each subimage has the same
1407 dimensions as the base image. Handle disposal method that is
1408 "undefined" by the gif spec (Bug#9335).
1409
bd1ba3e8
CY
14102011-08-20 Chong Yidong <cyd@stupidchicken.com>
1411
1412 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1413 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1414
54a1215b
EZ
14152011-08-19 Eli Zaretskii <eliz@gnu.org>
1416
823564e5
EZ
1417 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1418 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1419 from an Org mode buffer to a Speedbar frame.
1420
54a1215b
EZ
1421 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1422 a composition, take its buffer position from IT->cmp_it.charpos.
1423 Fixes cursor positioning at the beginning of a line that begins
1424 with a composed character.
1425
9778ebcc
EZ
14262011-08-18 Eli Zaretskii <eliz@gnu.org>
1427
0be6ee06
EZ
1428 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1429 character bidirectional type, use STRONG_L instead. Fixes crashes
1430 in a buffer produced by `describe-categories'.
1431
9778ebcc
EZ
1432 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1433 members before the level stack, so they would be saved and
1434 restored when copying iterator state. Fixes incorrect reordering
1435 around TABs covered by display properties.
1436
156bffbe
AS
14372011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1438
6b02f655 1439 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1440
72ad093b
CY
14412011-08-17 Chong Yidong <cyd@stupidchicken.com>
1442
1443 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1444 (internal_condition_case_2, internal_condition_case_n):
1445 Remove unnecessary aborts (Bug#9081).
72ad093b 1446
35774242
EZ
14472011-08-17 Eli Zaretskii <eliz@gnu.org>
1448
1449 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1450 has no `load' handler, try opening the file locally. (Bug#9311)
1451
db76dd85
KB
14522011-08-16 Ken Brown <kbrown@cornell.edu>
1453
1454 * gmalloc.c: Expand comment.
1455
b215eee5
EZ
14562011-08-16 Eli Zaretskii <eliz@gnu.org>
1457
1458 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1459 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1460
a4579d33
KB
14612011-08-16 Ken Brown <kbrown@cornell.edu>
1462
1463 Fix memory allocation problems in Cygwin build (Bug#9273).
1464
1465 * unexcw.c ( __malloc_initialized): Declare external variable.
1466 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1467
8b76d6f8
SM
1468 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1469 New variables.
a4579d33
KB
1470 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1471 dumped emacs.
1472 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1473 in the static heap.
1474 [CYGWIN] (special_realloc): New function.
1475 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1476 requests to realloc storage in the static heap.
1477
3ebec551
PE
14782011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1479
1480 * bidi.c (bidi_initialize): Remove unused local.
1481
9fd8be00
EZ
14822011-08-15 Eli Zaretskii <eliz@gnu.org>
1483
6b02f655
SM
1484 * bidimirror.h:
1485 * biditype.h: Remove file.
1486 * makefile.w32-in ($(BLD)/bidi.$(O)):
1487 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1488
1489 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1490
1491 * chartab.c: Improve commentary for the uniprop_table API.
1492
32413314
EZ
1493 * bidi.c (bidi_paragraph_init): Support zero value of
1494 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1495 (bidi_initialize): Use uniprop_table instead of including
1496 biditype.h and bidimirror.h.
32413314 1497
9fd8be00
EZ
1498 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1499 coordinates of the iterator when restoring from ppos_it.
1500 (Bug#9296)
1501
5cf2b69b
KH
15022011-08-14 Kenichi Handa <handa@m17n.org>
1503
1504 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1505 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1506
daf17d00
EZ
15072011-08-14 Eli Zaretskii <eliz@gnu.org>
1508
1509 * xdisp.c (move_it_in_display_line_to): Don't invoke
1510 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1511 ppos_it. Fixes vertical cursor motion when line beginning is
1512 covered by an image. (Bug#9296)
1513
08e3161a
JD
15142011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1515
1516 * nsterm.h (ns_run_ascript): Declare.
1517 (NSAPP_DATA2_RUNASSCRIPT): Define.
1518
1519 * nsfns.m (as_script, as_result, as_status): New static variables.
1520 (ns_run_ascript): New function.
5e617bc2 1521 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1522 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1523 the event loop. Get status from as_status (Bug#7276).
1524
1525 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1526 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1527 the event loop (Bug#7276).
1528
a3720aa2
AS
15292011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1530
1531 * gnutls.c (QCgnutls_bootprop_priority)
1532 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1533 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1534 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1535 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1536 (QCgnutls_bootprop_verify_hostname_error)
1537 (QCgnutls_bootprop_callbacks_verify): Rename from
1538 Qgnutls_bootprop_..., all uses changed.
1539
1540 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1541 uses changed.
1542
0a0d27fb
PE
15432011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1544
19d5c50c
PE
1545 * xfaces.c (Qframe_set_background_mode): Now static.
1546 * dispextern.h (Qframe_set_background_mode): Remove decl.
1547
0a0d27fb
PE
1548 * process.c (Fnetwork_interface_info): Declare local only if needed.
1549
377538cb
JD
15502011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1551
1552 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1553 (Fnetwork_interface_list): Allocate in increments of bytes instead
1554 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1555 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1556 sockaddr.
1557 (struct ifflag_def): notrailers is smart on OSX.
1558 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1559 Get hardware address with getifaddrs if available.
1560
08fff70c
EZ
15612011-08-12 Eli Zaretskii <eliz@gnu.org>
1562
1563 * xdisp.c (iterate_out_of_display_property): xassert that
1564 IT->position is set to within IT->object's boundaries. Break from
1565 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1566 when IT->position is set up wrongly due to some bug.
1567 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1568 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1569 entry. Force push_it to save on the stack the current
1570 buffer/string position, to be restored by pop_it. Fix flags in
1571 the iterator structure wrt the object coming from a display
1572 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1573 properties. (Bug#9284)
1574
7be1c708 15752011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1576
7be1c708
CY
1577 * fontset.c (fontset_get_font_group): Add proper type checks.
1578 (Bug#9172)
aac0c6e3 1579
7be1c708 15802011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1581
7be1c708
CY
1582 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1583 and LC_VERSION_MIN_MACOSX.
1584 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1585 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1586
97bb72a6
EZ
15872011-08-08 Eli Zaretskii <eliz@gnu.org>
1588
1589 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1590 no-display-properties-and-no-overlays under bidi display.
1591 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1592 properties and overlays.
97bb72a6 1593
d5617611
CY
15942011-08-08 Chong Yidong <cyd@stupidchicken.com>
1595
37e11a63
CY
1596 * editfns.c (Fset_time_zone_rule): Document relationship with the
1597 setenv function.
1598
d5617611
CY
1599 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1600 the font entity extracted from the cache (Bug#8109).
1601
58872834
CY
16022011-08-07 Chong Yidong <cyd@stupidchicken.com>
1603
1604 * composite.c (autocmp_chars): Don't reset point. That is done by
1605 restore_point_unwind (Bug#5984).
1606
75bfc667
JL
16072011-08-07 Juri Linkov <juri@jurta.org>
1608
1609 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1610 to show the arg `TIME' instead of `TIMEVAL'.
1611
d1410150
EZ
16122011-08-06 Eli Zaretskii <eliz@gnu.org>
1613
1614 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1615 display property strides EOL and includes a newline, as in
1616 longlines-mode. (Bug#9254)
75b771e4
EZ
1617 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1618 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1619
1620 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1621 is non-zero, even if the data buffer is NULL. Fixes a crash in
1622 vertical-motion with longlines-mode. (Bug#9254)
1623
35928349
EZ
16242011-08-05 Eli Zaretskii <eliz@gnu.org>
1625
ec7cc85b
EZ
1626 * bidi.c <bidi_cache_total_alloc>: Now static.
1627 (bidi_initialize): Initialize bidi_cache_total_alloc.
1628
8b76d6f8 1629 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1630 cache. (Bug#9221)
1631
1632 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1633 amount allocated this far in `bidi_cache_total_alloc'.
1634 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1635 non-zero, only free the data buffer without restoring the cache
1636 contents. All callers changed.
1637
1638 * dispextern.h (bidi_unshelve_cache): Update prototype.
1639
1640 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1641 (move_it_in_display_line, move_it_to)
1642 (move_it_vertically_backward, move_it_by_lines): Replace the call
1643 to xfree to an equivalent call to bidi_unshelve_cache.
1644 (move_it_in_display_line_to): Fix logic of returning
412b6358 1645 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1646
e2e2423b
EZ
16472011-08-05 Eli Zaretskii <eliz@gnu.org>
1648
1649 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1650 came from a string character with a `cursor' property. (Bug#9229)
1651
ae9e757a
JD
16522011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1653
1654 * Makefile.in (LIB_PTHREAD): New variable.
1655 (LIBES): Add LIB_PTHREAD (Bug#9216).
1656
1657 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1658 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1659
213bd7f2
AS
16602011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1661
6b02f655 1662 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1663
99aaf75f
JD
16642011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1665
1666 * xterm.c (x_find_topmost_parent): New function.
1667 (x_set_frame_alpha): Find topmost parent window with
1668 x_find_topmost_parent and set the property there also (bug#9181).
1669 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1670
c74e9d86
PE
16712011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1672
1673 * callproc.c (Fcall_process): Avoid vfork clobbering
1674 the local vars buffer, coding_systems, current_dir.
1675
640c8776
SM
16762011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1677
1678 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1679
f26d0e4c
PE
16802011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1681
8a10d76c
PE
1682 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1683 so that it is not optimized away.
1684
f26d0e4c
PE
1685 * xdisp.c (compute_display_string_pos): Remove unused local.
1686
55439c61
EZ
16872011-08-02 Eli Zaretskii <eliz@gnu.org>
1688
1689 Fix slow cursor motion and scrolling in large buffers with
1690 selective display, like Org Mode buffers. (Bug#9218)
1691
1692 * dispextern.h (struct bidi_it): New member disp_prop_p.
1693
1694 * xdisp.c: Remove one-slot cache of display string positions.
1695 (compute_display_string_pos): Accept an additional argument
5e617bc2 1696 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1697 for a display string or property. If found, set DISP_PROP_P
1698 non-zero.
1699
1700 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1701 DISP_PROP_P, and pass it to compute_display_string_pos.
1702 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1703 non-zero. All callers of bidi_fetch_char changed.
1704
fb33fa43
SM
17052011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1706
1707 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1708
b099e063
DM
17092010-12-03 Don March <don@ohspite.net>
1710
1711 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1712 last character M-[char] is translated to ESC [char] (bug#7541).
1713
5cc7f7af
KH
17142011-08-02 Kenichi Handa <handa@m17n.org>
1715
d0fffa3f 1716 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1717
1718 * chartab.c (uniprop_table): Make it non-static.
1719
525d5e6e
EZ
17202011-08-01 Eli Zaretskii <eliz@gnu.org>
1721
1722 * xdisp.c (forward_to_next_line_start): Accept additional argument
1723 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1724 on the newline.
1725 (reseat_at_next_visible_line_start): Use the bidi iterator state
1726 returned by forward_to_next_line_start to restore the state of
1727 it->bidi_it after backing up to previous newline. (Bug#9212)
1728
31011111
AS
17292011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1730
1731 * regex.c (re_comp): Protoize.
1732 (re_exec): Fix return type.
1733 (regexec): Fix type of `ret'. (Bug#9203)
1734
476371c4
PE
17352011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1736
e5d76069
PE
1737 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1738 This is needed if max-image-size is a floating-point number.
1739
9a79b20c
AS
17402011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1741
1742 * print.c (print_object): Print empty symbol as ##.
1743
1744 * lread.c (read1): Read ## as empty symbol.
1745
d8c2fa78
AA
17462011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1747
1748 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1749 setting frame foreground color (Bug#9175).
1750 (x_set_background_color): Likewise.
1751
ffe57a7a
AA
1752 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1753 contents (Bug#9176).
1754 (EmacsTooltip -init): Remove bezels and add shadows to
1755 tooltip windows.
1756
bf3492a5
AA
1757 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1758 or scroll bar (Bug#8470).
1759
d55e9c53
AA
1760 * nsfont.m (nsfont_open): Remove assignment to voffset and
1761 unnecessary vars hshink, expand, hd, full_height, min_height.
1762 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1763
1764 * nsterm.h (nsfont_info): Remove voffset field.
1765
d8c2fa78 17662011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1767
1768 Implement strike-through and overline on NextStep (Bug#8863).
1769
1770 * nsfont.m (nsfont_open): Use underline position provided by font,
1771 instead of hard-coded value of 2.
1772 (nsfont_draw): Call ns_draw_text_decoration instead.
1773
1774 * nsterm.h: Add declaration for ns_draw_text_decoration.
1775
1776 * nsterm.m (ns_draw_text_decoration): New function for drawing
1777 underline, overline, and strike-through.
1778 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1779 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1780 accommodate underlining, etc.
4843aac3 1781
4cc60b9b
EZ
17822011-07-28 Eli Zaretskii <eliz@gnu.org>
1783
bc7ece87
EZ
1784 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1785 default.
4cc60b9b 1786
476371c4
PE
17872011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1788
66606eea
PE
1789 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1790 Without this fix, if a signal arrives just after memory fills up,
1791 'malloc' might be invoked reentrantly.
1792
476371c4
PE
1793 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1794 In other words, assume that every image size is allowed, on non-X
1795 hosts. This assumption is probably wrong, but it lets Emacs compile.
1796
f3fcc40d
AS
17972011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1798
1799 * regex.c (re_iswctype): Convert return values to boolean.
1800
350c992f
EZ
18012011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1802
1803 * xdisp.c (compute_display_string_pos): Don't use cached display
1804 string position if the buffer had its restriction changed.
1805 (Bug#9184)
1806
5266b4bb
PE
18072011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1808
1809 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1810
2573a837 18112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1812
41f55ccd 1813 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1814
39e378da
PE
1815 * bidi.c: Integer size and overflow fixes.
1816 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1817 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1818 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1819 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1820 (bidi_find_other_level_edge):
1821 Use ptrdiff_t instead of EMACS_INT where either will do.
1822 This works better on 32-bit hosts configured --with-wide-int.
1823 (bidi_cache_ensure_space): Check for size-calculation overflow.
1824 Use % rather than repeated addition, for better worst-case speed.
1825 Don't set bidi_cache_size until after xrealloc returns, because it
1826 might not return.
1827 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1828 (bidi_cache_ensure_space): Also check that the bidi cache size
1829 does not exceed that of the largest Lisp string or buffer. See Eli
1830 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1831
5e927815
PE
1832 * alloc.c (__malloc_size_t): Remove.
1833 All uses replaced by size_t. See Andreas Schwab's note
1834 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1835
ca4aa935
PE
1836 * image.c: Improve checking for integer overflow.
1837 (check_image_size): Assume that f is nonnull, since
1838 it is always nonnull in practice. This is one less thing to
1839 worry about when checking for integer overflow later.
1840 (x_check_image_size): New function, which checks for integer
1841 overflow issues inside X.
1842 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1843 This removes the need for a memory_full check.
1844 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1845 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1846 (xbm_read_bitmap_data): Change locals back to 'int', since
1847 their values must fit in 'int'.
1848 (xpm_load_image, png_load, tiff_load):
1849 Invoke x_create_x_image_and_pixmap earlier,
1850 to avoid much needless work if the image is too large.
1851 (tiff_load): Treat overly large images as if
1852 x_create_x_image_and_pixmap failed, not as malloc failures.
1853 (gs_load): Use x_check_image_size.
1854
5f8f9cc2
PE
1855 * gtkutil.c: Omit integer casts.
1856 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1857 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1858
5adf60bc
PE
1859 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1860
c8907a93
PE
1861 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1862 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1863 would wrongly return t on a 64-bit host.
1864
e3c25c68
PE
1865 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1866 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1867 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1868 and therefore cause GCC to emit a bogus diagnostic in some cases.
1869
3f791afe
PE
1870 * image.c: Integer signedness and overflow and related fixes.
1871 This is not an exhaustive set of fixes, but it's time to
1872 record what I've got.
1873 (lookup_pixel_color, check_image_size): Remove redundant decls.
1874 (check_image_size): Don't assume that arbitrary EMACS_INT values
1875 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1876 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1877 (tiff_load, imagemagick_load_image):
1878 Check for overflow in size calculations.
1879 (x_create_x_image_and_pixmap): Remove unnecessary test for
1880 xmalloc returning NULL; that can't happen.
1881 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1882 (xpm_color_bucket): Use better integer hashing function.
1883 (xpm_cache_color): Don't possibly over-allocate memory.
1884 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1885 (gif_memory_source):
1886 Use ptrdiff_t, not int or size_t, to record sizes.
1887 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1888 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1889 either works, as we prefer signed integers.
1890 (tiff_read_from_memory, tiff_write_from_memory):
1891 Return tsize_t, not size_t, since that's what the TIFF API wants.
1892 (tiff_read_from_memory): Don't fail simply because the read would
1893 go past EOF; instead, return a short read.
1894 (tiff_load): Omit no-longer-needed casts.
1895 (Fimagemagick_types): Don't assume size fits into 'int'.
1896
3cc5a532
PE
1897 Improve hashing quality when configured --with-wide-int.
1898 * fns.c (hash_string): New function, taken from sxhash_string.
1899 Do not discard information about ASCII character case; this
1900 discarding is no longer needed.
1901 (sxhash-string): Use it. Change sig to match it. Caller changed.
1902 * lisp.h: Declare it.
1903 * lread.c (hash_string): Remove, since we now use fns.c's version.
1904 The fns.c version returns a wider integer if --with-wide-int is
1905 specified, so this should help the quality of the hashing a bit.
1906
b312a492
PE
1907 * emacs.c: Integer overflow minor fix.
1908 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1909 Define only if GNU_LINUX.
1910 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1911
dfd153ae
PE
1912 * dispnew.c: Integer signedness and overflow fixes.
1913 Remove unnecessary forward decls, that were a maintenance hassle.
1914 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1915 All uses changed.
1916 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1917 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1918 (prepare_desired_row, line_draw_cost):
1919 Use int, not unsigned, where either works.
1920 (save_current_matrix, restore_current_matrix):
1921 Use ptrdiff_t, not size_t, where either works.
1922 (init_display): Check for overflow more accurately, and without
1923 relying on undefined behavior.
1924
a81d11a3
PE
1925 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1926 Remove, replacing with the new symbols in lisp.h. All uses changed.
1927 * fileio.c (make_temp_name):
1928 * filelock.c (lock_file_1, lock_file):
1929 * xdisp.c (message_dolog):
1930 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1931 Use pMd etc. instead.
1932 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1933 replacing the pWIDE etc. symbols removed from editfns.c.
1934
3300e6fd
PE
1935 * keyboard.h (num_input_events): Now uintmax_t.
1936 This is (very slightly) less likely to mess up due to wraparound.
1937 All uses changed.
1938
fd05c7e9
PE
1939 * buffer.c: Integer signedness fixes.
1940 (alloc_buffer_text, enlarge_buffer_text):
1941 Use ptrdiff_t rather than size_t when either will do, as we prefer
1942 signed integers.
1943
903fe15d
PE
1944 * alloc.c: Integer signedness and overflow fixes.
1945 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1946 (__malloc_size_t): Default to size_t, not to int.
1947 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1948 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1949 Prefer ptrdiff_t to size_t when either would do, as we prefer
1950 signed integers.
1951 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1952 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1953 Now const. Initialize with values that are in range even if char
1954 is signed.
1955 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1956 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1957 These functions do the right thing with sizes > 2**32.
1958 (check_depth): Now ptrdiff_t, not int.
1959 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1960 Adjust to new way of storing sizes. Check for size overflow bugs
1961 in rest of code.
1962 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1963 slightly wrong anyway, as it missed one instance of
1964 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1965 (refill_memory_reserve): Omit needless cast to size_t.
1966 (mark_object_loop_halt): Mark as externally visible.
1967
ac82cc6a
PE
1968 * xselect.c: Integer signedness and overflow fixes.
1969 (Fx_register_dnd_atom, x_handle_dnd_message):
1970 Use ptrdiff_t, not size_t, since we prefer signed.
1971 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1972 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1973 x_dnd_atoms_size and x_dnd_atoms_length.
1974
c2d1e36d
PE
1975 * doprnt.c: Prefer signed to unsigned when either works.
1976 * eval.c (verror):
1977 * doprnt.c (doprnt):
1978 * lisp.h (doprnt):
1979 * xdisp.c (vmessage):
1980 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1981 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1982 prefer signed arithmetic to avoid comparison confusion.
1983 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1984 but is a bit tricky.
1985
0e926e56
PE
1986 Assume freestanding C89 headers, string.h, stdlib.h.
1987 * data.c, doprnt.c, floatfns.c, print.c:
1988 Include float.h unconditionally.
1989 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1990 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1991 * regex.c: Likewise for stddef.h, string.h.
1992 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1993 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1994 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1995 (STDC_HEADERS): Remove obsolete defines.
1996 * sysdep.c: Include limits.h unconditionally.
1997
9cfdb3ec
PE
1998 Assume support for memcmp, memcpy, memmove, memset.
1999 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2000 * regex.c (memcmp, memcpy):
2001 Remove; we assume C89 now.
2002
2003 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2004 (__malloc_safe_bcopy): Remove; no longer needed.
2005
cf950e6b 2006 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2007 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2008 well either way, and we prefer signed to unsigned.
2009
dbf38e02
LMI
20102011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2011
2012 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2013 closes the connection while we're reading (bug#9182).
2014
d6f0886c 20152011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2016
d6f0886c
JD
2017 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2018 are specified (Bug#9168).
24e0f6b1 2019
2eb1f9e6
PE
20202011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2021
2022 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2023 Found by GCC static checking and --with-wide-int on a 32-bit host.
2024
22381272 20252011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2026
2027 * xdisp.c (compute_display_string_pos): Fix logic of caching
2028 previous display string position. Initialize cached_prev_pos to
2029 -1. Fixes slow-down at the beginning of a buffer.
2030
f25e39b4
EZ
20312011-07-24 Eli Zaretskii <eliz@gnu.org>
2032
2033 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2034 for attrs[LFACE_FONTSET_INDEX].
2035
04c4b52e
PE
20362011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2037
2038 * xml.c (parse_region): Remove unused local
2039 that was recently introduced.
2040
c1734fbd
EZ
20412011-07-23 Eli Zaretskii <eliz@gnu.org>
2042
be18c5a5
EZ
2043 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2044 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2045
c1734fbd
EZ
2046 * xdisp.c (move_it_in_display_line_to): Record the best matching
2047 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2048 exit if none of the characters scanned was an exact match.
2049 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2050 when exact match is impossible due to invisible text, and the
2051 lines are truncated.
2052
a258d627
JD
20532011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2054
2055 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2056 for OSX >= 10.7.
2057
b6d5a689
EZ
20582011-07-22 Eli Zaretskii <eliz@gnu.org>
2059
0f74f785
EZ
2060 Fix a significant slow-down of cursor motion with C-n, C-p,
2061 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2062 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2063 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2064 (next_element_from_buffer): Call compute_stop_pos_backwards to
2065 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2066 base_level_stop.
2067 (reseat): Don't look for prev_stop, as that could mean a very long
2068 run.
2069 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2070 <cached_disp_overlay_modiff>: Cache for last found display string
2071 position.
551918c1 2072 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2073 about the same buffer in the same area of character positions, and
2074 the buffer wasn't changed since the time the display string
2075 position was cached.
551918c1 2076
b2d0c91a
EZ
20772011-07-22 Eli Zaretskii <eliz@gnu.org>
2078
2079 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2080 is an integer, which is important for empty lines. (Bug#9149)
2081
043604ee
CY
20822011-07-22 Chong Yidong <cyd@stupidchicken.com>
2083
2084 * frame.c (Fmodify_frame_parameters): In tty case, update the
2085 default face if necessary (Bug#4238).
2086
da4adb04
CY
20872011-07-21 Chong Yidong <cyd@stupidchicken.com>
2088
2089 * editfns.c (Fstring_to_char): No need to explain what a character
2090 is in the docstring (Bug#6576).
2091
9abd0532
LMI
20922011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2093
2094 * xml.c (parse_region): Make sure we always return a tree.
2095
36881d16
HK
20962011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2097
2098 * xml.c (parse_region): If a document contains only comments,
2099 return that, too.
2100
1e98674d
LMI
21012011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2102
2103 * xml.c (make_dom): Return comments, too.
2104
590bd467
PE
21052011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2106
2107 Port to OpenBSD.
2108 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2109 and the surrounding thread.
2110 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2111 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2112 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2113 timer goes off.
2114 * s/openbsd.h (BROKEN_SIGIO): Define.
2115 * unexelf.c (unexec) [__OpenBSD__]:
2116 Don't update the .mdebug section of the Alpha COFF symbol table.
2117
f41628b2
LMI
21182011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2119
2120 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2121 (bug#8460).
2122
b59b67c5
PE
21232011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2124
15e3a074
PE
2125 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2126 This fixes some race conditions on the permissions of any newly
2127 created file.
2128
41bed37d
PE
2129 * alloc.c (valid_pointer_p): Use pipe, not open.
2130 This fixes some permissions issues when debugging.
2131
b59b67c5
PE
2132 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2133 If fchown fails to set both uid and gid, try to set just gid,
2134 as that is sometimes allowed. Adjust the file's mode to eliminate
2135 setuid or setgid bits that are inappropriate if fchown fails.
2136
925a6be7
SM
21372011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2138
2139 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2140 to compare Lisp_Objects.
2141 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2142 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2143 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2144
52968808
AS
21452011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2146
0a6a104b
AS
2147 * lread.c (read_integer): Unread even EOF character.
2148 (read1): Likewise. Properly record start position of symbol.
2149
52968808
AS
2150 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2151 symbol character follows.
2152
9e381cdd
PE
21532011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2154
2155 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2156 This works around a problem with the previous change to Fcopy_file.
2157 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2158 and without this change, GCC might complain about discarding
2159 fchown's return value.
2160
b5641435
JB
21612011-07-16 Juanma Barranquero <lekktu@gmail.com>
2162
2163 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2164
a8031457
PE
21652011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2166
2167 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2168
dd889327
LMI
21692011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2170
750c33f7
LMI
2171 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2172 it's used from the C level.
2173
dd889327
LMI
2174 * process.c: Use the same condition for POLL_FOR_INPUT in both
2175 keyboard.c and process.c (bug#1858).
2176
87e86684
LM
21772011-07-09 Lawrence Mitchell <wence@gmx.li>
2178
2179 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2180 (Fgnutls_boot): Use it.
2181
64348f40
AS
21822011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2183
2184 * doc.c (Fsubstitute_command_keys): Revert last change.
2185
1d698799
LMI
21862011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2187
f863868c
LMI
2188 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2189 quotes the next character, and doesn't affect other longer
2190 sequences (bug#8935).
2191
1d698799
LMI
2192 * lread.c (syms_of_lread): Clarify that is isn't only
2193 `eval-buffer' and `eval-defun' that's affected by
2194 `lexical-binding' (bug#8460).
2195
aa4b6df6
EZ
21962011-07-15 Eli Zaretskii <eliz@gnu.org>
2197
2198 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2199 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2200
5d856da6
PE
22012011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2202
ad6042bb
PE
2203 Fix minor problems found by static checking.
2204 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2205 (elsz): Now a signed constant, not a size_t var. We prefer signed
2206 types to unsigned, to avoid integer comparison confusion. Without
2207 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2208 "cannot optimize loop, the loop counter may overflow", a symptom
2209 of the confusion.
f00bbb22 2210 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2211 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2212
6468f31c
LMI
22132011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2214
49080b10
LMI
2215 * search.c (Fre_search_backward): Mention `case-fold-search' in
2216 all the re_search_* functions (bug#8138).
2217
6468f31c
LMI
2218 * keyboard.c (Fopen_dribble_file): Document when the file is
2219 closed (bug#8056).
2220
c965adc5
EZ
22212011-07-14 Eli Zaretskii <eliz@gnu.org>
2222
df9733bf
EZ
2223 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2224 bidi_cache_idx.
2225
0bb23927
EZ
2226 Support bidi reordering of display and overlay strings.
2227 * xdisp.c (compute_display_string_pos)
2228 (compute_display_string_end): Accept additional argument STRING.
2229 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2230 (reseat_to_string): Initialize bidi_it->string.s and
2231 bidi_it->string.schars.
2232 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2233 NULL (avoids a crash in bidi_paragraph_init).
2234 Initialize itb.string.lstring.
0bb23927
EZ
2235 (init_iterator): Call bidi_init_it only of a valid
2236 buffer position was specified. Initialize paragraph_embedding to
2237 L2R.
2238 (reseat_to_string): Initialize the bidi iterator.
2239 (display_string): If we need to ignore text properties of
2240 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2241 original value of -1 will not work with bidi.)
2242 (compute_display_string_pos): First arg is now struct
2243 `text_pos *'; all callers changed. Support display properties on
2244 Lisp strings.
2245 (compute_display_string_end): Support display properties on Lisp
2246 strings.
2247 (init_iterator, reseat_1, reseat_to_string): Initialize the
2248 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2249 when iterating on a string not from display properties).
640c8776
SM
2250 (compute_display_string_pos, compute_display_string_end):
2251 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2252 arrow keys.
2253 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2254 base_level_stop; instead, set base_level_stop to BEGV.
2255 Fixes crashes in vertical-motion.
0bb23927
EZ
2256 (next_element_from_buffer): Improve commentary for when
2257 the iterator is before prev_stop.
2258 (init_iterator): Initialize bidi_p from the default value of
2259 bidi-display-reordering, not from buffer-local value. Use the
2260 buffer-local value only if initializing for buffer iteration.
2261 (handle_invisible_prop): Support invisible properties on strings
2262 that are being bidi-reordered.
2263 (set_iterator_to_next): Support bidi reordering of C strings and
2264 Lisp strings.
2265 (next_element_from_string): Support bidi reordering of Lisp
2266 strings.
2267 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2268 (display_string): Support display of R2L glyph rows.
2269 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2270 (init_iterator): Don't initialize it->bidi_p for strings
2271 here.
2272 (reseat_to_string): Initialize it->bidi_p for strings here.
2273 (next_element_from_string, next_element_from_c_string)
2274 (next_element_from_buffer): Add xassert's for correspondence
2275 between IT's object being iterated and it->bidi_it.string
2276 structure.
2277 (face_before_or_after_it_pos): Support bidi iteration.
2278 (next_element_from_c_string): Handle the case of the first string
2279 character that is not the first one in the visual order.
2280 (get_visually_first_element): New function, refactored from common
2281 parts of next_element_from_buffer, next_element_from_string, and
2282 next_element_from_c_string.
2283 (tool_bar_lines_needed, redisplay_tool_bar)
2284 (display_menu_bar): Force left-to-right direction. Add a FIXME
2285 comment for making that be controlled by a user option.
2286 (push_it, pop_it): Save and restore the state of the
2287 bidi iterator. Save and restore the bidi_p flag.
2288 (pop_it): Iterate out of display property for string iteration as
2289 well.
2290 (iterate_out_of_display_property): Support iteration over strings.
2291 (handle_single_display_spec): Set up it->bidi_it for iteration
2292 over a display string, and call bidi_init_it.
2293 (handle_single_display_spec, next_overlay_string)
2294 (get_overlay_strings_1, push_display_prop): Set up the bidi
2295 iterator for displaying display or overlay strings.
2296 (forward_to_next_line_start): Don't use the shortcut if
2297 bidi-iterating.
2298 (back_to_previous_visible_line_start): If handle_display_prop
2299 pushed the iterator stack, restore the internal state of the bidi
2300 iterator by calling bidi_pop_it same number of times.
2301 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2302 and we are bidi-iterating, don't decrement the iterator position;
2303 instead, set the first_elt flag in the bidi iterator, to produce
2304 the same effect.
2305 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2306 (push_display_prop): xassert that we are iterating a buffer.
2307 (push_it, pop_it): Save and restore paragraph_embedding member.
2308 (handle_single_display_spec, next_overlay_string)
2309 (get_overlay_strings_1, reseat_1, reseat_to_string)
2310 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2311 correctly. Don't assume unibyte strings are not bidi-reordered.
2312 (compute_display_string_pos)
2313 (compute_display_string_end): Fix handling the case of C string.
2314 (push_it, pop_it): Save and restore from_disp_prop_p.
2315 (handle_single_display_spec, push_display_prop): Set the
2316 from_disp_prop_p flag.
2317 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2318 (pop_it): Call iterate_out_of_display_property only if we are
2319 popping after iteration over a string that came from a display
2320 property. Fix a typo in popping stretch info. Add an assertion
2321 for verifying that the iterator position is in sync with the bidi
2322 iterator.
2323 (handle_single_display_spec, get_overlay_strings_1)
2324 (push_display_prop): Fix initialization of paragraph direction for
2325 string when that of the parent object is not yet determined.
2326 (reseat_1): Call bidi_init_it to resync the bidi
2327 iterator with IT's position. (Bug#7616)
2328 (find_row_edges): If ROW->start.pos gives position
2329 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2330 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2331 Reset the from_disp_prop_p flag.
2332 (SAVE_IT, RESTORE_IT): New macros.
2333 (pos_visible_p, face_before_or_after_it_pos)
2334 (back_to_previous_visible_line_start)
2335 (move_it_in_display_line_to, move_it_in_display_line)
2336 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2337 (try_scrolling, redisplay_window, display_line): Use them when
2338 saving a temporary copy of the iterator and restoring it back.
2339 (back_to_previous_visible_line_start, reseat_1)
2340 (init_iterator): Empty the bidi cache "stack".
2341 (move_it_in_display_line_to): If iterator ended up at
2342 EOL, but we never saw any buffer positions smaller than
2343 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2344 motion in bidi-reordered lines.
2345 (move_it_in_display_line_to): Record prev_method and prev_pos
2346 immediately before the call to set_iterator_to_next. Fixes cursor
2347 motion in bidi-reordered lines with stretch glyphs and strings
2348 displayed in margins. (Bug#8133) (Bug#8867)
2349 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2350 TO_CHARPOS.
640c8776
SM
2351 (pos_visible_p): Support positions in bidi-reordered lines.
2352 Save and restore bidi cache.
0bb23927
EZ
2353
2354 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2355 (bidi_paragraph_info): Delete unused struct.
2356 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2357 (bidi_cache_start): New variable.
2358 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2359 to zero.
2360 (bidi_cache_fetch_state, bidi_cache_search)
2361 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2362 (bidi_cache_find, bidi_peek_at_next_level)
2363 (bidi_level_of_next_char, bidi_find_other_level_edge)
2364 (bidi_move_to_visually_next): Compare cache index with
2365 bidi_cache_start rather than with zero.
2366 (bidi_fetch_char): Accept new argument STRING; all callers
2367 changed. Support iteration over a string. Support strings with
2368 display properties. Support unibyte strings. Fix the type of
2369 `len' according to what STRING_CHAR_AND_LENGTH expects.
2370 (bidi_paragraph_init, bidi_resolve_explicit_1)
2371 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2372 (bidi_level_of_next_char, bidi_move_to_visually_next):
2373 Support iteration over a string.
0bb23927
EZ
2374 (bidi_set_sor_type, bidi_resolve_explicit_1)
2375 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2376 can now be zero (for strings); special values 0 and -1 were
2377 changed to -1 and -2, respectively.
2378 (bidi_char_at_pos): New function.
2379 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2380 Call it instead of FETCH_MULTIBYTE_CHAR.
2381 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2382 initialized to valid values.
2383 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2384 values.
2385 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2386 the test for valid cached positions. Fix the logic for looking up
2387 the sentinel state in the cache. GCPRO the Lisp string we are
2388 iterating.
2389 (bidi_push_it, bidi_pop_it): New functions.
2390 (bidi_initialize): Initialize the bidi cache start stack pointer.
2391 (bidi_cache_ensure_space): New function, refactored from part of
2392 bidi_cache_iterator_state. Don't assume the required size is just
2393 one BIDI_CACHE_CHUNK away.
2394 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2395 (bidi_count_bytes, bidi_char_at_pos): New functions.
2396 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2397 always valid if bidi_cache_idx is valid.
2398 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2399 is valid if it's going to be used.
2400 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2401 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2402 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2403 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2404 (bidi_find_other_level_edge, bidi_cache_start_stack):
2405 All variables related to cache indices are now EMACS_INT.
c965adc5 2406
0bb23927
EZ
2407 * dispextern.h (struct bidi_string_data): New structure.
2408 (struct bidi_it): New member `string'. Make flag members be 1-bit
2409 fields, and put them last in the struct.
640c8776
SM
2410 (compute_display_string_pos, compute_display_string_end):
2411 Update prototypes.
0bb23927
EZ
2412 (bidi_push_it, bidi_pop_it): Add prototypes.
2413 (struct iterator_stack_entry): New members bidi_p,
2414 paragraph_embedding, and from_disp_prop_p.
2415 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2416 (bidi_shelve_cache, bidi_unshelve_cache):
2417 Declare prototypes.
0bb23927
EZ
2418
2419 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2420 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2421 and vector-like objects.
2422
2423 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2424 cache around display iteration.
2425
2426 * window.c (Fwindow_end, window_scroll_pixel_based)
2427 (displayed_window_lines, Frecenter): Save and restore the bidi
2428 cache around display iteration.
2429
3bbd2265
LMI
24302011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2431
2432 * editfns.c (Fdelete_region): Clarify the use of the named
2433 parameters (bug#6788).
2434
adc47434
MR
24352011-07-14 Martin Rudalics <rudalics@gmx.at>
2436
2437 * indent.c (Fvertical_motion): Set and restore w->pointm when
2438 saving and restoring the window's buffer (Bug#9006).
2439
837c31f8
LMI
24402011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2441
2442 * editfns.c (Fstring_to_char): Clarify just what is returned
2443 (bug#6576). Text by Eli Zaretskii.
2444
ac389d0c
JB
24452011-07-13 Juanma Barranquero <lekktu@gmail.com>
2446
2447 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2448
0be0ce47
EZ
24492011-07-13 Eli Zaretskii <eliz@gnu.org>
2450
2451 * buffer.c (mmap_find): Fix a typo.
2452
cd18e7e3
JB
24532011-07-13 Johan Bockgård <bojohan@gnu.org>
2454
2455 Fix execution of x selection hooks.
2456 * xselect.c (Qx_lost_selection_functions)
2457 (Qx_sent_selection_functions): New vars.
2458 (syms_of_xselect): DEFSYM them.
2459 (x_handle_selection_request): Pass Qx_sent_selection_functions
2460 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2461 (x_handle_selection_clear,x_clear_frame_selections):
2462 Pass Qx_lost_selection_functions rather than
2463 Vx_lost_selection_functions to Frun_hook_with_args.
2464
47ea7f44
PE
24652011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2466
ac389d0c 2467 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2468 The old code sometimes used this field without initializing it.
2469
47ea7f44
PE
2470 * alloc.c (gc_sweep): Don't read past end of array.
2471 In theory, the old code could also have corrupted Emacs internals,
2472 though it'd be very unlikely.
2473
bc985c87
AS
24742011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2475
2476 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2477 argument. (Bug#4026)
bc985c87 2478
0cf34688
LMI
24792011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2480
b3dadd76
LMI
2481 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2482 key" (bug#4257).
2483
0cf34688
LMI
2484 * window.c (Fset_window_start): Doc fix (bug#4199).
2485 (Fset_window_hscroll): Ditto.
2486
270768cd
PE
24872011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2488
077e3dda 2489 Fix minor new problems caught by GCC 4.6.1.
270768cd 2490 * term.c (init_tty): Remove unused local.
490011a6 2491 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2492 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2493 not used otherwise.
270768cd 2494
b1f58454
CY
24952011-07-12 Chong Yidong <cyd@stupidchicken.com>
2496
2497 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2498
22b9578d
LMI
24992011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2500
6e70ab07
LMI
2501 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2502 are the mini-buffer and the echo area (bug#3320).
2503
22b9578d
LMI
2504 * term.c (init_tty): Remove support for supdup, c10 and perq
2505 terminals, which are no longer supported (bug#1482).
2506
8974cc9f
JB
25072011-07-10 Johan Bockgård <bojohan@gnu.org>
2508
2509 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2510
a560d974
JD
25112011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2512
2513 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2514 for non-popups (Bug#3642).
2515
1dae0f0a
AS
25162011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2517
268c2c36 2518 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2519 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2520 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2521 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2522 * data.c (fmod): Likewise.
2523 * dispnew.c (swap_glyphs_in_rows): Likewise.
2524 * emacs.c (memory_warning_signal): Likewise.
2525 * floatfns.c (float_error): Likewise.
2526 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2527 (otf_open, font_otf_capability, generate_otf_features)
2528 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2529 Likewise.
2530 * image.c (pbm_read_file): Likewise.
2531 * indent.c (string_display_width): Likewise.
2532 * intervals.c (check_for_interval, search_for_interval)
2533 (inc_interval_count, count_intervals, root_interval)
2534 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2535 * lread.c (defalias): Likewise.
268c2c36 2536 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2537 * regex.c (set_image_of_range_1, set_image_of_range)
2538 (regex_grow_registers): Likewise.
2539 * sysdep.c (strerror): Likewise.
2540 * termcap.c (valid_filename_p, tprint, main): Likewise.
2541 * tparam.c (main): Likewise.
2542 * unexhp9k800.c (run_time_remap, save_data_space)
2543 (update_file_ptrs, read_header, write_header, calculate_checksum)
2544 (copy_file, copy_rest, display_header): Likewise.
2545 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2546 Likewise.
2547 * xdisp.c (check_it): Likewise.
2548 * xfaces.c (register_color, unregister_color, unregister_colors):
2549 Likewise.
2550 * xfns.c (print_fontset_result): Likewise.
2551 * xrdb.c (member, fatal, main): Likewise.
2552
99033785
PE
25532011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2554
2555 Fix minor problems found by static checking (Bug#9031).
2556 * chartab.c (char_table_set_range, map_sub_char_table):
2557 Remove unused locals.
2558 (uniprop_table): Now static.
2559 * composite.c (_work_char): Remove unused static var.
2560
9cb2ac56
JB
25612011-07-09 Juanma Barranquero <lekktu@gmail.com>
2562
2563 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2564
f25661f0
JD
25652011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2566
2567 * gtkutil.c (qttip_cb): Remove code without function.
2568
8278c4fe
EZ
25692011-07-09 Eli Zaretskii <eliz@gnu.org>
2570
2571 * w32.c (pthread_sigmask): New stub.
2572
1692ae2d 25732011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2574
8a6ebd58 2575 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2576 sigprocmask is portable only for single-threaded applications, and
2577 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2578 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2579 (LIBES): Use it.
2580 * callproc.c (Fcall_process):
2581 * process.c (create_process):
2582 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2583 Use pthread_sigmask, not sigprocmask.
123403e4 2584
1b854618
JD
25852011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2586
2587 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2588 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2589 wrong (Bug#8591).
2590
3fe4b549
JD
25912011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2592
0ce7e563
JD
2593 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2594 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2595 (xg_hide_tooltip): Fix comment.
2596
3fe4b549
JD
2597 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2598 in registerServicesMenuSendTypes.
2599 (validRequestorForSendType): Don't check ns_return_types.
2600
2601 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2602 ns_return_type.
2603
5df75e47
JR
26042011-07-08 Jason Rumney <jasonr@gnu.org>
2605
2606 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2607 frame struct members of non-existent frames (Bug#6284).
2608
699c10bd
JD
26092011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2610
4393663b
JD
2611 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2612 variable firstTime not needed on OSX >= 10.6.
2613 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2614 >= 10.5. Use setKnobProportion, setDoubleValue.
2615
2616 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2617 (MAC_OS_X_VERSION_10_5): Define if not defined.
2618 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2619 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2620 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2621
2622 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2623 cString and lossyCString on OSX >= 10.4
2624
2625 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2626 sizeToFit on OSX >= 10.2.
2627
2628 * nsimage.m (allocInitFromFile): Don't use deprecated method
2629 bestRepresentationForDevice on OSX >= 10.6.
2630
2631 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2632 to avoid warning.
2633
2634 * emacs.c: Declare unexec_init_emacs_zone.
2635
a63e0781
JD
2636 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2637
699c10bd
JD
2638 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2639
2640 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2641 on svcsMenu (Bug#8842).
2642
2643 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2644 ns_return_types.
2645 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2646
2647 * nsterm.m (QUTF8_STRING): Declare.
2648 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2649 (validRequestorForSendType): Return type is (id).
2650 Change indexOfObjectIdenticalTo to indexOfObject.
2651 Check if we have local selection before returning self (Bug#8842).
2652 (writeSelectionToPasteboard): Put local selection into paste board
2653 if we have a local selection (Bug#8842).
2654 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2655
2656 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2657 (ns_get_local_selection): Declare.
2658
54e10184
LMI
26592011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2660
9888ff71
LMI
2661 * keymap.c (describe_map_tree): Don't insert a double newline at
2662 the end of the buffer (bug#1169) and return whether we inserted
2663 something.
2664
54e10184
LMI
2665 * callint.c (Fcall_interactively): Change "reading args" to
2666 "providing args" to try to clarify what it does (bug#1010).
2667
15fa4783
KH
26682011-07-07 Kenichi Handa <handa@m17n.org>
2669
2670 * composite.c (composition_compute_stop_pos): Ignore a static
2671 composition starting before CHARPOS (Bug#8915).
2672
2673 * xdisp.c (handle_composition_prop): Likewise.
2674
a8815b00
EZ
26752011-07-07 Eli Zaretskii <eliz@gnu.org>
2676
2677 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2678 (Bug#9015)
2679
ef7b981d 26802011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2681
2682 * character.h (unicode_category_t): New enum type.
2683
2684 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2685 (Qchar_code_property_table): New variable.
2686 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2687 (UNIPROP_COMPRESSED_FORM_P): New macros.
2688 (char_table_ascii): Uncompress the compressed values.
2689 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2690 Uncompress the compressed values.
ac389d0c 2691 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2692 (char_table_ref_and_range): Uncompress the compressed values.
2693 (sub_char_table_set): New arg is_uniprop. Callers changed.
2694 Uncompress the compressed values.
2695 (sub_char_table_set_range): Args changed. Callers changed.
2696 (char_table_set_range): Adjuted for the above change.
2697 (map_sub_char_table): Delete args default_val and parent. Add arg
2698 top. Give decoded values to a Lisp function.
640c8776 2699 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2700 values to a Lisp function. Gcpro more variables.
2701 (uniprop_table_uncompress)
2702 (uniprop_decode_value_run_length): New functions.
2703 (uniprop_decoder, uniprop_decoder_count): New variables.
2704 (uniprop_get_decoder, uniprop_encode_value_character)
2705 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2706 New functions.
2707 (uniprop_encoder, uniprop_encoder_count): New variables.
2708 (uniprop_get_encoder, uniprop_table)
2709 (Funicode_property_table_internal, Fget_unicode_property_internal)
2710 (Fput_unicode_property_internal): New functions.
2711 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2712 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2713 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2714 char-code-property-alist.
2715
640c8776 2716 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2717 Vunicode_category_table.
2718
640c8776 2719 * font.c (font_range): Adjust for the change of
c805dec0
KH
2720 Vunicode_category_table.
2721
76b397fb
DN
27222011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2723
2724 * m/iris4d.h: Remove file, move contents ...
2725 * s/irix6-5.h: ... here.
2726
22b4128e
PE
27272011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2728
2729 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2730 * alloc.c (mark_buffer):
2731 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2732 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2733 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2734 This isn't true in general, and it's particularly not true
2735 if Emacs is configured with --with-wide-int.
2736 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2737 New macros, used in the buffer.c change.
2738
869795d6
JD
27392011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2740
2741 * xsettings.c: Use both GConf and GSettings if both are available.
2742 (store_config_changed_event): Add comment.
2743 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2744 (store_tool_bar_style_changed): New functions.
5e617bc2 2745 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2746 (struct xsettings): Move font inside HAVE_XFT.
2747 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2748 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2749 Move inside HAVE_XFT.
640c8776 2750 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2751 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2752 also.
2753 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2754 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2755 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2756 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2757 (parse_settings): Move check for font inside HAVE_XFT.
2758 (read_settings, apply_xft_settings): Add comment.
2759 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2760 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2761 call store_font_name_changed.
2762 (xft_settings_event): Add comment.
2763 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2764 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2765 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2766 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2767 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2768 (xsettings_get_system_font, xsettings_get_system_normal_font):
2769 Add comment.
869795d6 2770
d8ed26bd
PE
27712011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2772
2773 Random fixes. E.g., (random) never returned negative values.
2774 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2775 subseconds part to the entropy, as that's a bit more random.
2776 Prefer signed to unsigned, since the signedness doesn't matter and
2777 in general we prefer signed. When given a limit, use a
2778 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2779 latter isn't right if USE_2_TAGS_FOR_INTS.
2780 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2781 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2782
cabf1cac
SM
27832011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2784
2785 * textprop.c (text_property_stickiness):
2786 Obey Vtext_property_default_nonsticky.
2787 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2788 * w32fns.c (syms_of_w32fns):
2789 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2790
6e9b2be9
PE
27912011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2792
2793 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2794 This is more efficient than Ffile_directory_p and avoids a minor race.
2795
90186c68
LMI
27962011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2797
7c301272
LMI
2798 * buffer.c (Foverlay_put): Say what the return value is
2799 (bug#7835).
2800
c4f2d8d4
LMI
2801 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2802 is a directory before asking whether to use the file name
2803 (bug#7564).
ad637907
LMI
2804 (barf_or_query_if_file_exists): Make the "File is a directory"
2805 error be more correct.
c4f2d8d4 2806
90186c68
LMI
2807 * fns.c (Frequire): Remove the mention of the .gz files, since
2808 that's installation-specific, but keep the mention of
2809 `get-load-suffixes'.
2810
da64016e
PE
28112011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2812
2813 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2814 Report string overflow if the output is too long.
2815
7d47b580
JB
28162011-07-04 Juanma Barranquero <lekktu@gmail.com>
2817
a555cb87
JB
2818 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2819 (syms_of_gnutls): Remove duplicate DEFSYM for
2820 Qgnutls_bootprop_verify_hostname_error, an error for
2821 Qgnutls_bootprop_verify_error (which is no longer used).
2822
7d47b580
JB
2823 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2824 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2825 Also (re)move comments that are misplaced or no longer relevant.
2826
1e49bfab
LMI
28272011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2828
2829 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2830
1485f4c0
CY
28312011-07-03 Chong Yidong <cyd@stupidchicken.com>
2832
2833 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2834 and background color parameters if they have been changed.
2835
a9ab721e
LMI
28362011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2837
2838 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2839
cf7cff57
PE
28402011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2841
2e13213d
PE
2842 * xsettings.c (SYSTEM_FONT): Define only when used.
2843 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2844
cf7cff57
PE
2845 * keymap.c (access_keymap_1): Now static.
2846
7a8e04f7
CY
28472011-07-02 Chong Yidong <cyd@stupidchicken.com>
2848
2849 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2850 leave any prefix arg for the up event (Bug#1586).
2851
61352f62
LMI
28522011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2853
69bb1ef7
LMI
2854 * lread.c (syms_of_lread): Mention single symbols defined by
2855 `defvar' or `defconst' (bug#7154).
2856
61352f62 2857 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2858 (Frequire): Mention get-load-suffixes.
61352f62 2859
28545e04
MR
28602011-07-02 Martin Rudalics <rudalics@gmx.at>
2861
2862 * window.h (window): Remove clone_number slot.
2863 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2864 Remove.
2865 (make_parent_window, make_window, saved_window)
2866 (Fset_window_configuration, save_window_save): Don't deal with
2867 clone numbers.
2868 * buffer.c (Qclone_number): Remove declaration.
2869 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2870
3349e122
SM
28712011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2872
2873 Add multiple inheritance to keymaps.
2874 * keymap.c (Fmake_composed_keymap): New function.
2875 (Fset_keymap_parent): Simplify.
2876 (fix_submap_inheritance): Remove.
2877 (access_keymap_1): New function extracted from access_keymap to handle
2878 embedded parents and handle lists of maps.
2879 (access_keymap): Use it.
2880 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2881 (Fcopy_keymap): Handle embedded parents.
2882 (Fcommand_remapping, define_as_prefix): Simplify.
2883 (Fkey_binding): Simplify.
2884 (syms_of_keymap): Move minibuffer-local-completion-map,
2885 minibuffer-local-filename-completion-map,
2886 minibuffer-local-must-match-map, and
2887 minibuffer-local-filename-must-match-map to Elisp.
2888 (syms_of_keymap): Defsubr make-composed-keymap.
2889 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2890 (parse_menu_item): Trivial simplification.
2891
3279eb87
GM
28922011-07-01 Glenn Morris <rgm@gnu.org>
2893
2894 * Makefile.in (SETTINGS_LIBS): Fix typo.
2895
4550efdf
KI
28962011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2897
2898 * coding.c (Fencode_coding_string): Record the last coding system
2899 used, as the function doc string says (bug#8738).
2900
0949d2b6
JD
29012011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2902
2903 * xsettings.c (store_monospaced_changed): Take new font as arg and
2904 check for change against current_mono_font.
2905 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2906 (emacs_settings_constructor, emacs_settings_get_property)
2907 (emacs_settings_set_property, emacs_settings_class_init)
2908 (emacs_settings_init, gsettings_obj): Remove.
2909 (something_changedCB): New function for HAVE_GSETTINGS.
2910 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2911 with value as argument.
2912 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2913 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2914 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2915 "changed".
2916
2917 * xgselect.c: Add defined (HAVE_GSETTINGS).
2918 (xgselect_initialize): Ditto.
2919
2920 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2921 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2922 xg_select.
2923
bbc6b304
PE
29242011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2925
2926 * eval.c (struct backtrace): Simplify and port the data structure.
2927 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2928 signed bit field, as this assumption is not portable and it makes
2929 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2930 "char debug_on_exit : 1" as this is not portable either; instead,
2931 use the portable "unsigned int debug_on_exit : 1". Remove unused
2932 member evalargs. Remove obsolete comments about cc bombing out.
2933
9851bfc5
JD
29342011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2935
51bb811f 2936 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2937 Let HAVE_GSETTINGS override HAVE_GCONF.
2938 (store_monospaced_changed): New function.
2939 (EMACS_SETTINGS): A new type derived from GObject to handle
2940 GSettings notifications.
2941 (emacs_settings_constructor, emacs_settings_get_property)
2942 (emacs_settings_set_property, emacs_settings_class_init):
2943 New functions.
2944 (gsettings_client, gsettings_obj): New variables.
2945 (GSETTINGS_SCHEMA): New define.
2946 (something_changedCB): Call store_monospaced_changed.
2947 (init_gsettings): New function.
2948 (xsettings_initialize): Call init_gsettings.
2949 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2950 to NULL.
2951
640c8776 2952 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2953 GCONF_CFLAGS/LIBS.
2954
5386012d
MR
29552011-06-29 Martin Rudalics <rudalics@gmx.at>
2956
2957 * window.c (resize_root_window, grow_mini_window)
2958 (shrink_mini_window): Rename Qresize_root_window to
2959 Qwindow_resize_root_window and Qresize_root_window_vertically to
2960 Qwindow_resize_root_window_vertically.
2961
f13e0b08
PE
29622011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2963
2964 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2965
94515237
JB
29662011-06-27 Juanma Barranquero <lekktu@gmail.com>
2967
2968 * makefile.w32-in: Redesign dependencies so they reflect more
2969 clearly which files are directly included by each source file,
2970 and not through other includes.
2971
e43b6e43
MR
29722011-06-27 Martin Rudalics <rudalics@gmx.at>
2973
2974 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2975 (sort_overlays, overlay_strings): When an overlay's clone number
2976 matches the window's clone number process the overlay even if
2977 the overlay's window property doesn't match the current window.
2978
d68443dc
MR
2979 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2980 (Fwindow_hchild): Rename to Fwindow_left_child.
2981 (Fwindow_next): Rename to Fwindow_next_sibling.
2982 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2983 (resize_window_check): Rename to window_resize_check.
2984 (resize_window_apply): Rename to window_resize_apply.
2985 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2986 (Fdelete_other_windows_internal, resize_frame_windows)
2987 (Fsplit_window_internal, Fdelete_window_internal)
2988 (grow_mini_window, shrink_mini_window)
2989 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2990
c7e73be5
JD
29912011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2992
2993 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2994 (emacs_fixed_set_min_size): Remove.
2995 (emacs_fixed_new): Take frame as argument.
2996
2997 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2998 (_EmacsFixedPrivate): Remove minwidth/height.
2999 Add struct frame *f.
3000 (emacs_fixed_init): Initialize priv->f.
3001 (get_parent_class, emacs_fixed_set_min_size): Remove.
3002 (emacs_fixed_new): Set priv->f to argument.
3003 (emacs_fixed_get_preferred_width)
3004 (emacs_fixed_get_preferred_height): Use min_width/height from
3005 frames size_hint to set minimum and natural (Bug#8919).
3006 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3007 and use min_width/height from frames size_hint to set
3008 min_width/height (Bug#8919).
3009
3010 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3011 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3012 Fix indentation.
c7e73be5 3013
cf99dcf8
EZ
30142011-06-26 Eli Zaretskii <eliz@gnu.org>
3015
3016 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3017 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3018 called at ZV.
3019
029529ac
CY
30202011-06-26 Chong Yidong <cyd@stupidchicken.com>
3021
3022 * process.c (wait_reading_process_output): Bypass select if
3023 waiting for a cell while ignoring keyboard input, and input is
3024 pending. Suggested by Jan Djärv (Bug#8869).
3025
7a7ef429
PE
30262011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3027
3028 Use gnulib's dup2 module instead of rolling our own.
3029 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3030
11fdef7d 30312011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3032
3033 * dispnew.c (scrolling_window): Before scrolling, turn off a
3034 mouse-highlight in the window being scrolled.
3035
cd3520a4
JB
30362011-06-24 Juanma Barranquero <lekktu@gmail.com>
3037
3038 Move DEFSYM to lisp.h and use everywhere.
3039
3040 * character.h (DEFSYM): Move declaration...
3041 * lisp.h (DEFSYM): ...here.
3042
3043 * gnutls.c:
3044 * minibuf.c:
3045 * w32menu.c:
3046 * w32proc.c:
3047 * w32select.c: Don't include character.h.
3048
3049 * alloc.c (syms_of_alloc):
3050 * buffer.c (syms_of_buffer):
3051 * bytecode.c (syms_of_bytecode):
3052 * callint.c (syms_of_callint):
3053 * casefiddle.c (syms_of_casefiddle):
3054 * casetab.c (init_casetab_once):
3055 * category.c (init_category_once, syms_of_category):
3056 * ccl.c (syms_of_ccl):
3057 * cmds.c (syms_of_cmds):
3058 * composite.c (syms_of_composite):
3059 * dbusbind.c (syms_of_dbusbind):
3060 * dired.c (syms_of_dired):
3061 * dispnew.c (syms_of_display):
3062 * doc.c (syms_of_doc):
3063 * editfns.c (syms_of_editfns):
3064 * emacs.c (syms_of_emacs):
3065 * eval.c (syms_of_eval):
3066 * fileio.c (syms_of_fileio):
3067 * fns.c (syms_of_fns):
3068 * frame.c (syms_of_frame):
3069 * fringe.c (syms_of_fringe):
3070 * insdel.c (syms_of_insdel):
3071 * keymap.c (syms_of_keymap):
3072 * lread.c (init_obarray, syms_of_lread):
3073 * macros.c (syms_of_macros):
3074 * msdos.c (syms_of_msdos):
3075 * print.c (syms_of_print):
3076 * process.c (syms_of_process):
3077 * search.c (syms_of_search):
3078 * sound.c (syms_of_sound):
3079 * syntax.c (init_syntax_once, syms_of_syntax):
3080 * terminal.c (syms_of_terminal):
3081 * textprop.c (syms_of_textprop):
3082 * undo.c (syms_of_undo):
3083 * w32.c (globals_of_w32):
3084 * window.c (syms_of_window):
3085 * xdisp.c (syms_of_xdisp):
3086 * xfaces.c (syms_of_xfaces):
3087 * xfns.c (syms_of_xfns):
3088 * xmenu.c (syms_of_xmenu):
3089 * xsettings.c (syms_of_xsettings):
3090 * xterm.c (syms_of_xterm): Use DEFSYM.
3091
4228cf16
TZ
30922011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3093
cd3520a4 3094 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3095
7fcccf1e
PE
30962011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3097
7efb4e0e
PE
3098 Integer and buffer overflow fixes (Bug#8873).
3099
ff5844ad
PE
3100 * print.c (printchar, strout): Check for string overflow.
3101 (PRINTPREPARE, printchar, strout):
3102 Don't set size unless allocation succeeds.
3103
90532f02
PE
3104 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3105 for sizes. Check for string overflow more accurately.
3106 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3107
6d84508d
PE
3108 * macros.c: Integer and buffer overflow fixes.
3109 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3110 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3111 Use ptrdiff_t, not int, for sizes.
3112 Don't increment bufsize until after realloc succeeds.
3113 Check for size-calculation overflow.
3114 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3115
437b2cb4
PE
3116 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3117
8b9ac8b4
PE
3118 * lread.c: Integer overflow fixes.
3119 (read_integer): Radix is now EMACS_INT, not int,
3120 to improve quality of diagnostics for out-of-range radices.
3121 Calculate buffer size correctly for out-of-range radices.
3122 (read1): Check for integer overflow in radices, and in
3123 read-circle numbers.
82cb60d3
PE
3124 (read_escape): Avoid int overflow.
3125 (Fload, openp, read_buffer_size, read1)
3126 (substitute_object_recurse, read_vector, read_list, map_obarray):
3127 Use ptrdiff_t, not int, for sizes.
3128 (read1): Use EMACS_INT, not int, for sizes.
20270765 3129 Check for size overflow.
8b9ac8b4 3130
7fcccf1e
PE
3131 * image.c (cache_image): Check for size arithmetic overflow.
3132
bfbbd7e7
PE
3133 * lread.c: Integer overflow issues.
3134 (saved_doc_string_size, saved_doc_string_length)
3135 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3136 Now ptrdiff_t, not int.
3137 (read1): Don't assume doc string length fits in int. Check for
3138 out-of-range doc string lengths.
3139 (read_list): Don't assume file position fits in int.
39019e54 3140 (read_escape): Check for hex character overflow.
bfbbd7e7 3141
4e323265
LL
31422011-06-22 Leo Liu <sdl.web@gmail.com>
3143
3144 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3145 Move to minibuffer.el.
3146
85fece3e
PE
31472011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3148
20b84ce9 3149 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3150 The following patches are for when GLYPH_DEBUG && !XASSERT.
3151 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3152 * dispnew.c (flush_stdout):
3153 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3154 Mark as externally visible.
3155 * dispnew.c (check_window_matrix_pointers): Now static.
3156 * dispnew.c (window_to_frame_vpos):
3157 * xfns.c (unwind_create_frame):
3158 * xterm.c (x_check_font): Remove unused local.
3159 * scroll.c (CHECK_BOUNDS):
3160 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3161 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3162 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3163 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3164 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3165 Now static.
3166 (debug_method_add): Use va_list and vsprintf rather than relying
3167 on undefined behavior with wrong number of arguments.
3168 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3169 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3170 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3171 since we're not interested in debugging glyphs with old libraries.
3172 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3173 GCC 4.6.0's static checking.
3174
0766b489
PE
31752011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3176
31fd4b32
PE
3177 Integer overflow and signedness fixes (Bug#8873).
3178 A few related buffer overrun fixes, too.
3179
b79e8648
PE
3180 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3181
0766b489
PE
3182 * dispextern.h (struct face.stipple):
3183 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3184 (x_bitmap_mask, x_allocate_bitmap_record)
3185 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3186 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3187 (x_create_bitmap_from_xpm_data):
3188 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3189 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3190 (.bitmaps_last):
3191 * xfaces.c (load_pixmap):
3192 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3193 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3194 (.bitmaps_last, struct x_output.icon_bitmap):
3195 Use ptrdiff_t, not int, for bitmap indexes.
3196 (x_allocate_bitmap_record): Check for size overflow.
3197 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3198
b081724f
PE
3199 Use ptrdiff_t, not int, for overlay counts.
3200 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3201 * editfns.c (overlays_around, get_pos_property):
3202 * textprop.c (get_char_property_and_overlay):
3203 * xdisp.c (next_overlay_change, note_mouse_highlight):
3204 * xfaces.c (face_at_buffer_position):
21514da7
PE
3205 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3206 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3207 (Fnext_overlay_change, Fprevious_overlay_change)
3208 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3209 Use ptrdiff_t, not int, for sizes.
21514da7 3210 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3211
3de73e5e
PE
3212 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3213
2606c57b
PE
3214 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3215 (x_session_initialize): Do not assume string length fits in int.
3216
aaafe47a
PE
3217 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3218 This is unlikely, but can occur if DPI is outlandish.
3219
2674ddc8 3220 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3221 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3222
28154962
PE
3223 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3224 * xrdb.c (magic_file_p, search_magic_path):
3225 Omit last arg SUFFIX; it was always 0. All callers changed.
3226 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3227
7de51af5
PE
3228 * xfont.c (xfont_match): Avoid need for strlen.
3229
25ed6cc3
PE
3230 * xfns.c: Don't assume strlen fits in int.
3231 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3232
4eab31dd
PE
3233 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3234 not unsigned long, as we prefer signed integers. All callers changed.
3235 Detect integer overflow in repeat count.
3236 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3237 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3238
171e2a58
PE
3239 * termcap.c: Don't assume sizes fit in int and never overflow.
3240 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3241 (gobble_line): Check for size-calculation overflow.
3242
ad39faca 3243 * minibuf.c (Fread_buffer):
6e5bb2dc 3244 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3245 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3246 Don't assume string length fits in int.
3247
52c61c22 3248 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3249 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3250
b5b8c9e5
PE
3251 * font.c: Don't assume string length fits in int.
3252 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3253 Use ptrdiff_t, not int.
ccd6111c
PE
3254 (font_intern_prop): Don't assume string length fits in int.
3255 Don't assume integer property fits in fixnum.
3256 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3257
882f0d81 3258 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3259 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3260 Reformulate so as not to need the command string.
3261 Invoke gzip -cd rather than gunzip, as it's more portable.
3262 (lock_info_type, lock_file_1, lock_file):
3263 Don't assume pid_t and time_t fit in unsigned long.
3264 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3265 (current_lock_owner): Prefer signed type for sizes.
3266 Use memcpy, not strncpy, where memcpy is what is really wanted.
3267 Don't assume (via atoi) that time_t and pid_t fit in int.
3268 Check for time_t and/or pid_t out of range, e.g., via a network share.
3269 Don't alloca where an auto var works fine.
3270
93f4cf88
PE
3271 * fileio.c: Fix some integer overflow issues.
3272 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3273 Don't assume string length fits in int.
3274 (directory_file_name): Don't assume string length fits in long.
3275 (make_temp_name): Don't assume pid fits in int, or that its print
3276 length is less than 20.
3277
f3e92b69
PE
3278 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3279
1bfdaf10
PE
3280 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3281
35016e9a
PE
3282 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3283
3d1e65a1
PE
3284 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3285 We prefer signed integers, even for size calculations.
3286
0b963a93
PE
3287 * emacs.c: Don't assume string length fits in 'int'.
3288 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3289 (main): Don't invoke strlen when not needed.
3290
573f4b54
PE
3291 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3292 (XD_DEBUG_MESSAGE): Don't waste a byte.
3293
989f33ba
PE
3294 * callproc.c (getenv_internal_1, getenv_internal)
3295 (Fgetenv_internal):
965d34eb
PE
3296 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3297
e4d29b33
PE
3298 * lread.c (invalid_syntax): Omit length argument.
3299 All uses changed. This doesn't fix a bug, but it simplifies the
3300 code away from its former Hollerith-constant appearance, and it's
3301 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3302 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3303
eb49b136
PE
3304 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3305 This didn't break anything, but it didn't help either.
3306 It's confusing to put a bogus integer in a place where the actual
3307 value does not matter.
9f62aeb1 3308 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3309 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3310
15375a22
PE
3311 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3312 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3313 implementation.
b61cc01c
PE
3314 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3315 We prefer signed types, and the value cannot exceed the EMACS_INT
3316 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3317 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3318 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3319 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3320
53b2623d
PE
3321 * indent.c (sane_tab_width): New function.
3322 (current_column, scan_for_column, Findent_to, position_indentation)
3323 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3324 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3325
51cab52b 3326 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3327
f2ed8a70
PE
3328 * lisp.h (lint_assume): New macro.
3329 * composite.c (composition_gstring_put_cache):
3330 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3331
abe80cc6
PE
3332 * editfns.c, insdel.c:
3333 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3334
b02c740e
PE
3335 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3336
ebc96716
PE
3337 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3338
b4e50fa0 3339 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3340 Use much-faster test for byte-length change.
311d5d7c 3341 Don't assume string byte-length fits in 'int'.
a4cf38e4 3342 Check that character arg fits in 'int'.
85461888 3343 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3344
c0c1ee9f
PE
3345 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3346
a498d7f4
PE
3347 * fns.c (concat): Catch string overflow earlier.
3348 Do not rely on integer wraparound.
3349
51cab52b
PE
3350 * dispextern.h (struct it.overlay_strings_charpos)
3351 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3352 * xdisp.c (forward_to_next_line_start)
3353 (back_to_previous_visible_line_start)
3354 (reseat_at_next_visible_line_start, next_element_from_buffer):
3355 Don't arbitrarily truncate the value of 'selective' to int.
3356
76031fad
PE
3357 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3358
5eb55db9
PE
3359 * composite.c: Don't truncate sizes to 'int'.
3360 (composition_gstring_p, composition_reseat_it)
3361 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3362 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3363 not EMACS_UINT, for indexes.
5eb55db9 3364
0703a717
PE
3365 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3366
d6202519
PE
3367 * buffer.c: Include <verify.h>.
3368 (struct sortvec.priority, struct sortstr.priority):
8961a454 3369 Now EMACS_INT, not int.
c20998a7 3370 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3371 (struct sortstr.size, record_overlay_string)
3372 (struct sortstrlist.size, struct sortlist.used):
3373 Don't truncate size to int.
3374 (record_overlay_string): Check for size-calculation overflow.
d6202519 3375 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3376
d5a19415
JM
33772011-06-22 Jim Meyering <meyering@redhat.com>
3378
029529ac 3379 Don't leak an XBM-image-sized buffer
d5a19415
JM
3380 * image.c (xbm_load): Free the image buffer after using it.
3381
a9041e6c
PE
33822011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3383
3384 Port to Sun C.
3385 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3386 that Sun C diagnosed.
3387 * fns.c (secure_hash): Fix pointer signedness issue.
3388 * intervals.c (static_offset_intervals): New function.
3389 (offset_intervals): Use it.
3390
7f3f739f
LL
33912011-06-21 Leo Liu <sdl.web@gmail.com>
3392
3393 * deps.mk (fns.o):
3394 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3395 sha512.h.
3396
3397 * fns.c (secure_hash): Rename from crypto_hash_function and change
3398 the first arg to accept symbols.
5b66d427 3399 (Fsecure_hash): New primitive.
7f3f739f
LL
3400 (syms_of_fns): New symbols.
3401
76147d94
DD
34022011-06-20 Deniz Dogan <deniz@dogan.se>
3403
3404 * process.c (Fset_process_buffer): Clarify return value in
3405 docstring.
3406
7d7d0045
CY
34072011-06-18 Chong Yidong <cyd@stupidchicken.com>
3408
3409 * dispnew.c (add_window_display_history): Use BVAR.
3410
3411 * xdisp.c (debug_method_add): Use BVAR.
3412 (check_window_end, dump_glyph_matrix, dump_glyph)
3413 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3414
3415 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3416 Likewise.
3417
3418 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3419 check till after the cache is created in init_frame_faces.
3420
ff2bc410
SM
34212011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3422
3423 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3424
28177add
PE
34252011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3426
dd3482fe
PE
3427 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3428 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3429 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3430
393d71f3 3431 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3432 * fileio.c (Finsert_file_contents):
3433 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3434 Remove the old (too-loose) buffer overflow checks.
3435 They weren't needed, since make_gap checks for buffer overflow.
3436 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3437 The old code merely checked for Emacs fixnum overflow, and relied
3438 on undefined (wraparound) behavior. The new code avoids undefined
3439 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3440
2e6813b0 3441 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3442 Tune. Don't use wider integers than needed. Don't use alloca.
3443 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3444
599a9e4f
PE
3445 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3446
99561444
PE
3447 * insdel.c, lisp.h (buffer_overflow): New function.
3448 (insert_from_buffer_1, replace_range, replace_range_2):
3449 * insdel.c (make_gap_larger):
3450 * editfns.c (Finsert_char):
3451 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3452
28177add
PE
3453 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3454
e69dafad
PE
34552011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3456
a7af7fde 3457 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3458
b1c46f02
PE
3459 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3460 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3461
e69dafad
PE
3462 * fileio.c: Don't assume EMACS_INT fits in off_t.
3463 (emacs_lseek): New static function.
3464 (Finsert_file_contents, Fwrite_region): Use it.
3465 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3466
566684ea
PE
3467 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3468
e6966cd6
PE
3469 * fns.c: Don't overflow int when computing a list length.
3470 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3471 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3472 truncation on 64-bit hosts. Check for QUIT every
3473 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3474 faster and is responsive enough.
3475 (Flength): Report an error instead of overflowing an integer.
3476 (Fsafe_length): Return a float if the value is not representable
3477 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3478 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3479 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3480
dd0b0efb
PE
3481 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3482 (header_size, word_size): New constants.
3483 (allocate_vectorlike): Don't check size overflow here.
3484 (allocate_vector): Check it here instead, since this is the only
3485 caller of allocate_vectorlike that could cause overflow.
3486 Check that the new vector's length is representable as a fixnum.
3487
86fe5cfe
PE
3488 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3489 The previous code was bogus. For example, next_almost_prime (32)
3490 returned 39, which is undesirable as it is a multiple of 3; and
3491 next_almost_prime (24) returned 25, which is a multiple of 5 so
3492 why was the code bothering to check for multiples of 7?
3493
80e88859
PE
3494 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3495
4a2f0ad6
PE
3496 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3497
f66c7cf8
PE
3498 Variadic C functions now count arguments with ptrdiff_t.
3499 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3500 Back then I didn't know that the Emacs coding style prefers signed int.
3501 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3502 were being counted with int, which may truncate counts on 64-bit
3503 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3504 * lisp.h (struct Lisp_Subr.function.aMANY)
3505 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3506 Arg counts are now ptrdiff_t, not size_t.
3507 All variadic functions and their callers changed accordingly.
3508 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3509 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3510 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3511 * callint.c (Fcall_interactively): Check arg count for overflow,
3512 to avoid potential buffer overrun. Use signed char, not 'int',
3513 for 'varies' array, so that we needn't bother to check its size
3514 calculation for overflow.
3515 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3516 * eval.c (apply_lambda):
3517 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3518 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3519 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3520
a1759b76
PE
3521 * callint.c (Fcall_interactively): Don't use index var as event count.
3522
d96be9fc
PE
3523 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3524 * mem-limits.h (SIZE): Remove; no longer used.
3525
a690a978 3526 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3527
578c21e6
PE
3528 Remove unnecessary casts.
3529 * xterm.c (x_term_init):
3530 * xfns.c (x_set_border_pixel):
3531 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3532 These aren't needed now that we assume ANSI C.
3533
96f53c6c
PE
3534 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3535 It's more likely to cause problems (due to unsigned overflow)
3536 than to cure them.
3537
83c77d31
PE
3538 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3539
ee2079f1
PE
3540 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3541
6da65536
PE
3542 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3543
7147c4a4
PE
3544 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3545
193e32d9
PE
3546 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3547
e5533da6
PE
3548 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3549
9910e595
PE
3550 GLYPH_CODE_FACE returns EMACS_INT, not int.
3551 * dispextern.h (merge_faces):
3552 * xfaces.c (merge_faces):
01103c44
PE
3553 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3554 Don't assume EMACS_INT fits in int.
9910e595 3555
2638320e
PE
3556 * character.h (CHAR_VALID_P): Remove unused parameter.
3557 * fontset.c, lisp.h, xdisp.c: All uses changed.
3558
045eb8d9
PE
3559 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3560
c1f134b5
PE
3561 * fns.c (concat): Minor tuning based on overflow analysis.
3562 This doesn't fix any bugs. Use int to hold character, instead
3563 of constantly refetching from Emacs object. Use XFASTINT, not
3564 XINT, for value known to be a character. Don't bother comparing
3565 a single byte to 0400, as it's always less.
3566
395fcb93 3567 * floatfns.c (Fexpt):
327eeec8
PE
3568 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3569
abbd3d23
PE
3570 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3571 for characters.
3572
684a03ef
PE
3573 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3574
0fed43f3
PE
3575 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3576 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3577 incorrectly succeed when S was a string, because 4294967386 was
3578 truncated before it was used.
3579
8fd02eb7
PE
3580 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3581 Otherwise, an out-of-range integer could cause undefined behavior
3582 on a 64-bit host.
3583
f8c86b69
PE
3584 * composite.c: Use int, not EMACS_INT, for characters.
3585 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3586 EMACS_INT, for values that are known to be in character range.
3587 This doesn't fix any bugs but is the usual style inside Emacs and
3588 may generate better code on 32-bit machines.
3589
34206dd2
PE
3590 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3591 This is for reasons similar to the recent CHAR_STRING fix.
3592 * charset.c (Fencode_char): Check that character arg is actually
3593 a character. Pass an int to ENCODE_CHAR.
3594 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3595 wider than 'int', as a compile-time check to prevent future regressions
3596 in this area.
3597
c5958d4c 3598 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3599
3600 Make sure a 64-bit char is never passed to CHAR_STRING.
3601 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3602 by silently ignoring the top 32 bits, allowing some values
3603 that were far too large to be valid characters.
3604 * character.h: Include <verify.h>.
3605 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3606 arguments are no wider than unsigned, as a compile-time check
3607 to prevent future regressions in this area.
3608 * data.c (Faset):
01103c44 3609 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3610 (Fsubst_char_in_region):
3611 * fns.c (concat):
3612 * xdisp.c (decode_mode_spec_coding):
3613 Adjust to CHAR_STRING's new requirement.
3614 * editfns.c (Finsert_char, Fsubst_char_in_region):
3615 * fns.c (concat): Check that character args are actually
3616 characters. Without this test, these functions did the wrong
3617 thing with wildly out-of-range values on 64-bit hosts.
3618
d37ca623
PE
3619 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3620 These casts should not be needed on 32-bit hosts, either.
3621 * keyboard.c (read_char):
3622 * lread.c (Fload): Remove casts to unsigned.
3623
ea204efb
PE
3624 * lisp.h (UNSIGNED_CMP): New macro.
3625 This fixes comparison bugs on 64-bit hosts.
3626 (ASCII_CHAR_P): Use it.
3627 * casefiddle.c (casify_object):
01103c44 3628 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3629 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3630 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3631 * dispextern.h (FACE_FROM_ID):
3632 * keyboard.c (read_char): Use UNSIGNED_CMP.
3633
41cb286c
PE
3634 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3635 not to EMACS_INT, to avoid GCC warning.
3636
4a1b9832
PE
3637 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3638
55daad71
PE
3639 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3640 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3641 isn't needed on 32-bit machines.
8f95c75c 3642
01103c44
PE
3643 * buffer.c (Fgenerate_new_buffer_name):
3644 Use EMACS_INT for count, not int.
0ceccced 3645 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3646
3647 * data.c (Qcompiled_function): Now static.
3648
c6f072e7
PE
3649 * window.c (window_body_lines): Now static.
3650
20ce5912
PE
3651 * image.c (gif_load): Rename local to avoid shadowing.
3652
9c4c5f81
PE
3653 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3654 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3655 * alloc.c (make_save_value): Integer argument is now of type
3656 ptrdiff_t, not int.
3657 (mark_object): Use ptrdiff_t, not int.
3658 * lisp.h (pD): New macro.
3659 * print.c (print_object): Use it.
3660
c0c5c8ae
PE
3661 * alloc.c: Use EMACS_INT, not int, to count objects.
3662 (total_conses, total_markers, total_symbols, total_vector_size)
3663 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3664 (total_free_floats, total_floats, total_free_intervals)
3665 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3666 Now EMACS_INT, not int. All uses changed.
3667 (Fgarbage_collect): Compute overall total using a double, so that
3668 integer overflow is less likely to be a problem. Check for overflow
3669 when converting back to an integer.
5a25e253
PE
3670 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3671 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3672 These were 'int' variables that could overflow on 64-bit hosts;
3673 they were never used, so remove them instead of repairing them.
211a0b2a 3674 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3675 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3676 Previously, this ceilinged at INT_MAX, but that doesn't work on
3677 64-bit machines.
e46bb31a 3678 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3679
c78baabf 3680 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3681 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3682 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3683 when a (possibly-narrower) signed value would do just as well.
3684 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3685
c9d624c6
PE
3686 * alloc.c: Catch some string size overflows that we were missing.
3687 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3688 for convenience in STRING_BYTES_MAX.
3689 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3690 The definition here is exact; the one in lisp.h was approximate.
3691 (allocate_string_data): Check for string overflow. This catches
3692 some instances we weren't catching before. Also, it catches
3693 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3694 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3695 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3696
c9d624c6
PE
3697 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3698 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3699 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3700
353032ce
PE
3701 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3702
2bccce07
PE
3703 * alloc.c (Fmake_string): Check for out-of-range init.
3704
0ac30604
SM
37052011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3706
3707 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3708
c195f2de
JD
37092011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3710
3711 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3712 xg_get_default_scrollbar_width.
3713
3714 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3715 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3716 (style_changed_cb): Call update_theme_scrollbar_width and call
3717 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3718 all frames (Bug#8505).
3719 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3720 Call gtk_window_set_resizable if HAVE_GTK3.
3721 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3722 and height if HAVE_GTK3 (Bug#8505).
3723 (scroll_bar_width_for_theme): New variable.
3724 (update_theme_scrollbar_width): New function.
3725 (xg_get_default_scrollbar_width): Move code to
3726 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3727 (xg_initialize): Call update_theme_scrollbar_width.
3728
3729 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3730
3731 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3732
e10ac9f1
MR
37332011-06-12 Martin Rudalics <rudalics@gmx.at>
3734
3735 * frame.c (make_frame): Call other_buffer_safely instead of
3736 other_buffer.
3737
3738 * window.c (temp_output_buffer_show): Call display_buffer with
3739 second argument Vtemp_buffer_show_specifiers and reset latter
3740 immediately after the call.
3741 (Vtemp_buffer_show_specifiers): New variable.
3742 (auto_window_vscroll_p, next_screen_context_lines)
3743 (Vscroll_preserve_screen_position): Remove leading asterisks from
3744 doc-strings.
3745
2d3c217e 37462011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3747
7b7f97e8 3748 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3749 * buffer.c (Qclone_number): Remove for now, as it's unused.
3750 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3751 (record_buffer): Remove unused local.
3752 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3753 (set_frame_buffer_list): Remove; unused.
3754 * frame.h (other_visible_frames): Remove decl.
3755 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3756 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3757 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3758 if HAVE_GPM.
3759 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3760 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3761 Define only if HAVE_GPM.
3762 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3763 (update_hints_inhibit): Remove; never set. All uses removed.
3764 * widgetprv.h (emacsFrameClassRec): Remove decl.
3765 * window.c (delete_deletable_window): Now returns void, since it
3766 wasn't returning anything.
3767 (compare_window_configurations): Remove unused locals.
3768 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3769 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3770 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3771 the same widths as pointers. This follows up on the 2011-05-06 patch.
3772 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3773 * xterm.h: Likewise.
3774 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3775
1384b89e
JB
37762011-06-12 Juanma Barranquero <lekktu@gmail.com>
3777
3778 * makefile.w32-in: Update dependencies.
3779 (LISP_H): Add lib/intprops.h.
3780
1100a63c
CY
37812011-06-11 Chong Yidong <cyd@stupidchicken.com>
3782
3783 * image.c (gif_load): Add animation frame delay to the metadata.
3784 (syms_of_image): Use DEFSYM. New symbol `delay'.
3785
6198ccd0
MR
37862011-06-11 Martin Rudalics <rudalics@gmx.at>
3787
3788 * window.c (delete_deletable_window): Re-add.
3789 (Fset_window_configuration): Rewrite to handle dead buffers and
3790 consequently deletable windows.
3791 (window_tree, Fwindow_tree): Remove. Supply functionality in
3792 window.el.
3793 (compare_window_configurations): Simplify code.
3794
b6e3633c
AS
37952011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3796
1ab0dee5
AS
3797 * image.c (imagemagick_load_image): Fix type mismatch.
3798 (Fimagemagick_types): Likewise.
3799
b6e3633c
AS
3800 * window.h (replace_buffer_in_windows): Declare.
3801
9397e56f
MR
38022011-06-11 Martin Rudalics <rudalics@gmx.at>
3803
3804 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3805 Qclone_number. Remove external declaration of Qdelete_window.
3806 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3807 code.
640c8776
SM
3808 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3809 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3810 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3811 buffer list implementation.
3812 (other_buffer_safely): New function.
3813 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3814 calls to replace_buffer_in_windows and
3815 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3816 if allowed.
3817 (record_buffer): Inhibit quitting and rewrite using quittable
3818 functions. Run Qbuffer_list_update_hook if allowed.
3819 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3820 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3821 Move switch-to-buffer to window.el.
9397e56f
MR
3822 (bury-buffer): Move to window.el.
3823 (Vbuffer_list_update_hook): New variable.
3824
3825 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3826 section.
3827
3828 * window.h (resize_frame_windows): Move up in code.
3829 (Fwindow_frame): Remove EXFUN.
3830 (replace_buffer_in_all_windows): Remove prototype.
3831 (replace_buffer_in_windows_safely): Add prototype.
3832
3833 * window.c: Declare Qdelete_window static again. Move down
3834 declaration of select_count.
3835 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3836 (Fother_window): Move to window.el.
3837 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3838 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3839 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3840 window.el.
3841 (replace_buffer_in_windows): Implement by calling
3842 Qreplace_buffer_in_windows.
3843 (replace_buffer_in_all_windows): Remove with some functionality
3844 moved into replace_buffer_in_windows_safely.
3845 (replace_buffer_in_windows_safely): New function.
3846 (select_window_norecord, select_frame_norecord): Move in front
3847 of run_window_configuration_change_hook. Remove now obsolete
3848 declarations.
640c8776
SM
3849 (Fset_window_buffer): Rewrite doc-string.
3850 Call Qrecord_window_buffer.
9397e56f
MR
3851 (keys_of_window): Move binding for other-window to window.el.
3852
b50691aa
CY
38532011-06-11 Chong Yidong <cyd@stupidchicken.com>
3854
3855 * dispextern.h (struct image): Replace data member, whose int_val
3856 and ptr_val fields were not used by anything, with a single
3857 lisp_val object.
3858
3859 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3860 (gif_clear_image, gif_load, imagemagick_load_image)
3861 (gs_clear_image, gs_load): Callers changed.
3862
3f754b86
PE
38632011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3864
cca69397
PE
3865 * buffer.h: Include <time.h>, for time_t.
3866 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3867
109e28d0
PE
3868 Fix minor problems found by static checking.
3869
60737f02
PE
3870 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3871
4b66faf3
PE
3872 Make identifiers static if they are not used in other modules.
3873 * data.c (Qcompiled_function, Qframe, Qvector):
3874 * image.c (QimageMagick, Qsvg):
3875 * minibuf.c (Qmetadata):
3876 * window.c (resize_window_check, resize_root_window): Now static.
3877 * window.h (resize_window_check, resize_root_window): Remove decls.
3878
109e28d0
PE
3879 * window.c (window_deletion_count, delete_deletable_window):
3880 Remove; unused.
46a4ce9e
PE
3881 (window_body_lines): Now static.
3882 (Fdelete_other_windows_internal): Mark vars as initialized.
3883 Make sure 'resize_failed' is initialized.
3884 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3885 (resize_window_apply): Remove unused local.
3886 * window.h (delete_deletable_window): Remove decl.
3887
109e28d0 3888 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3889 (imagemagick_load_image): Fix pointer signedness problem by changing
3890 last arg from unsigned char * to char *. All uses changed.
3891 Also, fix a local for similar reasons.
3892 Remove unused locals. Remove locals to avoid shadowing.
3893 (fn_rsvg_handle_free): Remove; unused.
3894 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3895 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3896
3f754b86
PE
3897 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3898
2547adb1
CY
38992011-06-10 Chong Yidong <cyd@stupidchicken.com>
3900
3901 * image.c (gif_load): Fix omitted cast error introduced by
3902 2011-06-06 change.
3903
2c8e37d4
MR
39042011-06-10 Martin Rudalics <rudalics@gmx.at>
3905
3906 * window.h (resize_proportionally, orig_total_lines)
3907 (orig_top_line): Remove from window structure.
3908 (set_window_height, set_window_width, change_window_heights)
3909 (Fdelete_window): Remove prototypes.
3910 (resize_frame_windows): Remove duplicate declaration.
3911
440a42e3
EZ
39122011-06-10 Eli Zaretskii <eliz@gnu.org>
3913
3914 * window.h (resize_frame_windows, resize_window_check)
3915 (delete_deletable_window, resize_root_window)
3916 (resize_frame_windows): Declare prototypes.
3917
3918 * window.c (resize_window_apply): Make definition be "static" to
3919 match the prototype.
3920
562dd5e9
MR
39212011-06-10 Martin Rudalics <rudalics@gmx.at>
3922
3923 * window.c: Remove declarations of Qwindow_size_fixed,
3924 window_min_size_1, window_min_size_2, window_min_size,
3925 size_window, window_fixed_size_p, enlarge_window, delete_window.
3926 Remove static from declaration of Qdelete_window, it's
3927 temporarily needed by Fbury_buffer.
3928 (replace_window): Don't assign orig_top_line and
3929 orig_total_lines.
3930 (Fdelete_window, delete_window): Remove. Window deletion is
3931 handled by window.el.
640c8776
SM
3932 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3933 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3934 (Fdelete_other_windows): Remove. Deleting other windows is
3935 handled by window.el.
3936 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3937 handled in window.el.
3938 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3939 Window minimum sizes are handled in window.el.
3940 (shrink_windows, size_window, set_window_height)
3941 (set_window_width, change_window_heights, window_height)
3942 (window_width, CURBEG, CURSIZE, enlarge_window)
3943 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3944 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3945 handled in window.el.
3946 (make_dummy_parent): Rename to make_parent_window and give it a
3947 second argument horflag.
3948 (make_window): Don't set resize_proportionally any more.
3949 (Fsplit_window): Remove. Windows are split in window.el.
3950 (save_restore_action, save_restore_orig_size)
3951 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3952 Resize mini windows in window.el.
3953 (grow_mini_window, shrink_mini_window): Implement by calling
3954 Qresize_root_window_vertically, resize_window_check and
3955 resize_window_apply.
640c8776
SM
3956 (saved_window, Fset_window_configuration, save_window_save):
3957 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3958 resize_proportionally.
3959 (window_min_height, window_min_width): Move to window.el.
3960 (keys_of_window): Move bindings for delete-other-windows,
3961 split-window, delete-window and enlarge-window to window.el.
3962
3963 * buffer.c: Temporarily extern Qdelete_window.
3964 (Fbury_buffer): Temporarily call Qdelete_window instead of
3965 Fdelete_window (Fbury_buffer will move to window.el soon).
3966
3967 * frame.c (set_menu_bar_lines_1): Remove code handling
3968 orig_top_line and orig_total_lines.
3969
3970 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3971 set_window_height but set heights directly.
3972 (change_frame_size_1): Use resize_frame_windows.
3973
3974 * xdisp.c (init_xdisp): Don't use set_window_height but set
3975 heights directly.
3976
640c8776
SM
3977 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3978 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3979 run_window_configuration_change_hook.
3980
3981 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3982 instead of change_window_heights and run
3983 run_window_configuration_change_hook.
3984
1a13852e
MR
39852011-06-09 Martin Rudalics <rudalics@gmx.at>
3986
3987 * window.c (replace_window): Rename second argument REPLACEMENT to
3988 NEW. New third argument SETFLAG. Rewrite.
3989 (delete_window, make_dummy_parent): Call replace_window with
3990 third argument 1.
3991 (window_list_1): Move down in code.
3992 (run_window_configuration_change_hook): Move set_buffer part
3993 before select_frame_norecord part in order to unwind correctly.
3994 Rename count1 to count.
3995 (recombine_windows, delete_deletable_window, resize_root_window)
3996 (Fdelete_other_windows_internal)
3997 (Frun_window_configuration_change_hook, make_parent_window)
3998 (resize_window_check, resize_window_apply, Fresize_window_apply)
3999 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4000 (Fdelete_window_internal, Fresize_mini_window_internal):
4001 New functions.
1a13852e
MR
4002 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4003
f3d1777e
MR
40042011-06-08 Martin Rudalics <rudalics@gmx.at>
4005
496e208e
MR
4006 * window.h (window): Add some new members to window structure -
4007 normal_lines, normal_cols, new_total, new_normal, clone_number,
4008 splits, nest, prev_buffers, next_buffers.
4009 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4010 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4011
f3d1777e
MR
4012 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4013 Remove.
496e208e
MR
4014 (make_dummy_parent): Set new members of windows structure.
4015 (make_window): Move down in code. Handle new members of window
4016 structure.
4017 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4018 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4019 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4020 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4021 (Fset_window_next_buffers, Fset_window_clone_number):
4022 New functions.
496e208e
MR
4023 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4024 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4025 Doc-string fixes.
4026 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4027 Argument WINDOW can be now internal window too.
4028 (Fwindow_use_time): Move up in code.
4029 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4030 Rewrite doc-string.
4031 (Fset_window_configuration, saved_window)
4032 (Fcurrent_window_configuration, save_window_save): Handle new
4033 members of window structure.
b9e809c2
MR
4034 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4035 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4036 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4037 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4038 Qget_mru_window, Qresize_root_window,
4039 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4040 Qauto_buffer_name; staticpro them.
f3d1777e 4041
abde8f8c
MR
40422011-06-07 Martin Rudalics <rudalics@gmx.at>
4043
4044 * window.c (Fwindow_total_size, Fwindow_left_column)
4045 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4046 (Fwindow_list_1): New functions.
4047 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4048 (Fwindow_width, Fscroll_left, Fscroll_right):
4049 Use window_body_cols instead of window_box_text_cols.
4050 (delete_window, Fset_window_configuration):
4051 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4052 (delete_all_subwindows): Take a window as argument and not a
4053 structure. Rewrite.
190b47e6
MR
4054 (window_loop): Remove handling of GET_LRU_WINDOW and
4055 GET_LARGEST_WINDOW.
4056 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4057
4058 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4059 window_box_text_cols. delete_all_subwindows now takes a
4060 Lisp_Object as argument.
abde8f8c 4061
640c8776
SM
4062 * indent.c (compute_motion, Fcompute_motion):
4063 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4064
fa8a67e6
MR
4065 * frame.c (delete_frame): Call delete_all_subwindows with root
4066 window as argument.
4067
a54e3482
DC
40682011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4069
4070 * fns.c (Fputhash): Document return value.
4071
60002bf5
CY
40722011-06-06 Chong Yidong <cyd@stupidchicken.com>
4073
4074 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4075
0c671da6 40762011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4077
b862a52a 4078 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4079
be44ca6c
PE
4080 Check for overflow when converting integer to cons and back.
4081 * charset.c (Fdefine_charset_internal, Fdecode_char):
4082 Use cons_to_unsigned to catch overflow.
4083 (Fencode_char): Use INTEGER_TO_CONS.
4084 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4085 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4086 * data.c (long_to_cons, cons_to_long): Remove.
4087 (cons_to_unsigned, cons_to_signed): New functions.
4088 These signal an error for invalid or out-of-range values.
4089 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4090 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4091 * font.c (Ffont_variation_glyphs):
4092 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4093 * lisp.h: Include <intprops.h>.
4094 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4095 (cons_to_signed, cons_to_unsigned): New decls.
4096 (long_to_cons, cons_to_long): Remove decls.
4097 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4098 (Fprimitive_undo): Use CONS_TO_INTEGER.
4099 * xfns.c (Fx_window_property): Likewise.
4100 * xselect.c: Include <limits.h>.
4101 (x_own_selection, selection_data_to_lisp_data):
4102 Use INTEGER_TO_CONS.
4103 (x_handle_selection_request, x_handle_selection_clear)
4104 (x_get_foreign_selection, Fx_disown_selection_internal)
4105 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4106 (lisp_data_to_selection_data): Use cons_to_unsigned.
4107 (x_fill_property_data): Use cons_to_signed.
4108 Report values out of range.
4109
d1f3d2af
PE
4110 Check for buffer and string overflow more precisely.
4111 * buffer.h (BUF_BYTES_MAX): New macro.
4112 * lisp.h (STRING_BYTES_MAX): New macro.
4113 * alloc.c (Fmake_string):
4114 * character.c (string_escape_byte8):
4115 * coding.c (coding_alloc_by_realloc):
4116 * doprnt.c (doprnt):
4117 * editfns.c (Fformat):
4118 * eval.c (verror):
4119 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4120 since they may not be the same number.
4121 * editfns.c (Finsert_char):
4122 * fileio.c (Finsert_file_contents):
4123 Likewise for BUF_BYTES_MAX.
4124
dd52fcea
PE
4125 * image.c: Use ptrdiff_t, not int, for sizes.
4126 (slurp_file): Switch from int to ptrdiff_t.
4127 All uses changed.
4128 (slurp_file): Check that file size fits in both size_t (for
4129 malloc) and ptrdiff_t (for sanity and safety).
4130
7f9bbdbb
PE
4131 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4132 if b->modtime has its maximal value.
4133
dfe18f82
PE
4134 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4135
84acfcf0
PE
4136 Don't assume time_t can fit into int.
4137 * buffer.h (struct buffer.modtime): Now time_t, not int.
4138 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4139 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4140
ccd9a01a
PE
4141 Minor fixes for signed vs unsigned integers.
4142 * character.h (MAYBE_UNIFY_CHAR):
4143 * charset.c (maybe_unify_char):
4144 * keyboard.c (read_char, reorder_modifiers):
4145 XINT -> XFASTINT, since the integer must be nonnegative.
4146 * ftfont.c (ftfont_spec_pattern):
4147 * keymap.c (access_keymap, silly_event_symbol_error):
4148 XUINT -> XFASTINT, since the integer must be nonnegative.
4149 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4150 since it makes no difference and we prefer signed.
4151 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4152 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4153 nonnegative.
4154
d6d100dd
SM
41552011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4156
4157 * window.h (Fwindow_frame): Declare.
4158
2b6148e4
PE
41592011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4160
4161 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4162 (SPARE_MEMORY): Always define.
4163 (LARGE_REQUEST): Remove.
4164 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4165
f230ecc9
MR
41662011-06-06 Martin Rudalics <rudalics@gmx.at>
4167
727e958e
MR
4168 * lisp.h: Move EXFUNS for Fframe_root_window,
4169 Fframe_first_window and Fset_frame_selected_window to window.h.
4170
4171 * window.h: Move EXFUNS for Fframe_root_window,
4172 Fframe_first_window and Fset_frame_selected_window here from
4173 lisp.h.
4174
4175 * frame.c (Fwindow_frame, Fframe_first_window)
4176 (Fframe_root_window, Fframe_selected_window)
4177 (Fset_frame_selected_window): Move to window.c.
4178 (Factive_minibuffer_window): Move to minibuf.c.
4179 (Fother_visible_frames_p): New function.
4180
4181 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4182
f230ecc9
MR
4183 * window.c (decode_window, decode_any_window): Move up in code.
4184 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4185 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4186 (Fwindow_buffer): Move up and rewrite doc-string.
4187 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4188 (Fwindow_prev): New functions.
727e958e
MR
4189 (Fwindow_frame): Move here from frame.c. Accept any window as
4190 argument.
4191 (Fframe_root_window, Fframe_first_window)
4192 (Fframe_selected_window): Move here from frame.c. Accept frame
4193 or arbitrary window as argument. Update doc-strings.
4194 (Fminibuffer_window): Move up in code.
4195 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4196 (Fset_frame_selected_window): Move here from frame.c.
4197 Marginal rewrite.
727e958e
MR
4198 (Fselected_window, select_window, Fselect_window): Move up in
4199 code. Minor doc-string fixes.
f230ecc9 4200
4d09bcf6
PE
42012011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4202
4203 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4204 Do not assume that spare memory exists; that assumption is valid
4205 only if SYSTEM_MALLOC.
4206 (LARGE_REQUEST): New macro, so that the issue of large requests
4207 is separated from the issue of spare memory.
4208
810928a2
AS
42092011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4210
172418ad
AS
4211 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4212 format. (Bug#8806)
4213
43f862f7
AS
4214 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4215
810928a2
AS
4216 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4217 before statements.
4218
a059fe24
JD
42192011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4220
4221 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4222
4223 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4224
4225 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4226 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4227
989bf368
JB
42282011-06-05 Juanma Barranquero <lekktu@gmail.com>
4229
4230 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4231
4b80f674
CY
42322011-06-04 Chong Yidong <cyd@stupidchicken.com>
4233
4234 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4235 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4236 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4237 New error handlers.
4b80f674
CY
4238 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4239 Obey Vx_select_enable_clipboard_manager. Catch errors in
4240 x_clipboard_manager_save (Bug#8779).
4241 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4242 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4243
99a33b77 42442011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4245
4246 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4247
99a33b77 42482011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4249
4250 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4251 in the current matrix if keep_current_p is non-zero.
4252
8264569d
EZ
42532011-06-04 Eli Zaretskii <eliz@gnu.org>
4254
4255 * bidi.c (bidi_level_of_next_char): Fix last change.
4256
57f97249
EZ
42572011-06-03 Eli Zaretskii <eliz@gnu.org>
4258
fec2107c 4259 Support bidi reordering of text covered by display properties.
57f97249 4260
fec2107c
EZ
4261 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4262 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4263 (bidi_cache_search, bidi_cache_iterator_state)
4264 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4265 (bidi_level_of_next_char, bidi_move_to_visually_next):
4266 Support character positions inside a run of characters covered by a
fec2107c
EZ
4267 display string.
4268 (bidi_paragraph_init, bidi_resolve_explicit_1)
4269 (bidi_level_of_next_char): Call bidi_fetch_char and
4270 bidi_fetch_char_advance instead of FETCH_CHAR and
4271 FETCH_CHAR_ADVANCE.
4272 (bidi_init_it): Initialize new members.
4273 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4274 definitions.
4275 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4276 instead of using explicit *_CHAR codes.
d6d100dd
SM
4277 (bidi_resolve_explicit, bidi_resolve_weak):
4278 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4279 bidirectional text is supported only in multibyte buffers.
4280 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4281 it to initialize the frame_window_p member of struct bidi_it.
4282 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4283 (bidi_resolve_explicit, bidi_resolve_weak)
4284 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4285 bidi_it->nchars is non-positive.
4286 (bidi_level_of_next_char): Don't try to lookup the cache for the
4287 next/previous character if nothing is cached there yet, or if we
4288 were just reseat()'ed to a new position.
c40e2fb2 4289
0e14fe90
EZ
4290 * xdisp.c (set_cursor_from_row): Set start and stop points
4291 according to the row's direction when priming the loop that looks
4292 for the glyph on which to display cursor.
4293 (single_display_spec_intangible_p): Function deleted.
4294 (display_prop_intangible_p): Reimplement to call
4295 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4296 Accept 3 additional arguments needed by handle_display_spec.
4297 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4298 values: lists, `(when COND...)' forms, etc.
4299 (single_display_spec_string_p): Support property values that are
4300 lists with the argument STRING its top-level element.
4301 (display_prop_string_p): Fix the condition for processing a
4302 property that is a list to be consistent with handle_display_spec.
fec2107c 4303 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4304 last portion of handle_display_prop.
4305 (compute_display_string_pos): Accept additional argument
4306 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4307 value of a `display' property is a "replacing spec".
4308 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4309 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4310 the display property, but just return a value indicating whether
4311 the display property will replace the characters it covers.
4312 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4313 frame_window_p members of struct bidi_it.
d6d100dd
SM
4314 (compute_display_string_pos, compute_display_string_end):
4315 New functions.
fec2107c
EZ
4316 (push_it): Accept second argument POSITION, where pop_it should
4317 jump to continue iteration.
4318 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4319
fec2107c
EZ
4320 * keyboard.c (adjust_point_for_property): Adjust the call to
4321 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4322
4323 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4324 (bidi_init_it): Update prototypes.
4325 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4326 (compute_display_string_pos, compute_display_string_end):
4327 Declare prototypes.
fec2107c
EZ
4328 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4329 EMACS_INT.
fc6f18ce 4330
40087514 43312011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4332
57f53182
PE
4333 Malloc failure behavior now depends on size of allocation.
4334 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4335 * lisp.h: Change signatures accordingly.
4336 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4337 All callers changed. (Bug#8762)
4338
4339 * gnutls.c: Use Emacs's memory allocators.
4340 Without this change, the gnutls library would invoke malloc etc.
4341 directly, which causes problems on non-SYNC_INPUT hosts, and which
4342 runs afoul of improving memory_full behavior. (Bug#8761)
4343 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4344 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4345 xfree instead of the default malloc, realloc, free.
4346 (Fgnutls_boot): No need to check for memory allocation failure,
4347 since xmalloc does that for us.
4348
ac32cd99 4349 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4350 * category.c (hash_get_category_set):
4351 * ccl.c (ccl_driver):
4352 * charset.c (Fdefine_charset_internal):
4353 * charset.h (struct charset.hash_index):
4354 * composite.c (get_composition_id, gstring_lookup_cache)
4355 (composition_gstring_put_cache):
4356 * composite.h (struct composition.hash_index):
4357 * dispextern.h (struct image.hash):
4358 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4359 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4360 (hashfn_equal, hashfn_user_defined, make_hash_table)
4361 (maybe_resize_hash_table, hash_lookup, hash_put)
4362 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4363 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4364 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4365 * image.c (make_image, search_image_cache, lookup_image)
4366 (xpm_put_color_table_h):
4367 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4368 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4369 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4370 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4371 * alloc.c (allocate_vectorlike):
4372 Check for overflow in vector size calculations.
4373 * ccl.c (ccl_driver):
4374 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4375 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4376 need to be updated by these changes.
40087514
PE
4377 * fns.c (make_hash_table, maybe_resize_hash_table):
4378 Check for integer overflow with large hash tables.
0de4bb68
PE
4379 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4380 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4381 (SXHASH_REDUCE): New macro.
4382 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4383 Use it instead of discarding useful hash info with large hash values.
4384 (sxhash_float): New function.
4385 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4386 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4387 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4388 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4389 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4390 Adjust signatures to match updated version of code.
4391 (consing_since_gc): Now EMACS_INT, since a single hash table can
4392 use more than INT_MAX bytes.
4393
698d32e2
DN
43942011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4395
4396 Make it possible to build with GCC-4.6+ -O2 -flto.
4397
4398 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4399
fd6fa53f
SM
44002011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4401
4402 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4403 Call minibuffer-inactive-mode.
4404
864db017
JB
44052011-05-31 Juanma Barranquero <lekktu@gmail.com>
4406
4407 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4408 Update dependencies.
4409
2ad0baf4
DN
44102011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4411
4412 * data.c (init_data): Remove code for UTS, this system is not
4413 supported anymore.
4414
4fcc2638
DN
44152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4416
4417 Don't force ./temacs to start in terminal mode.
4418
4419 * frame.c (make_initial_frame): Initialize faces in all cases, not
4420 only when CANNOT_DUMP is defined.
4421 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4422
c56e0fd5
DN
44232011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4424
4425 * dispnew.c (add_window_display_history): Use const for the string
4426 pointer. Remove declaration, not needed.
4427
333d54da 44282011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4429
55d4c1b2 4430 Use 'inline', not 'INLINE'.
333d54da 4431 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4432 * alloc.c, fontset.c (INLINE): Remove.
4433 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4434 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4435 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4436 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4437 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4438
738db178
DN
44392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4440
4441 Make it possible to run ./temacs.
4442
4443 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4444 syms_of_callproc does the same thing. Remove test for
4445 "initialized", do it in the caller.
4446 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4447
620c53a6
SM
44482011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4449
4450 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4451 (read_minibuf): Use get_minibuffer.
4452 (syms_of_minibuf): Use DEFSYM.
4453 (Qmetadata): New var.
4454 * data.c (Qbuffer): Don't make it static.
4455 (syms_of_data): Use DEFSYM.
4456
e003a292
PE
44572011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4458
4459 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4460 (CCL_CODE_MIN): New macro.
4461
ed008a6d
PE
44622011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4463
3687c2ef
PE
4464 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4465
ed008a6d
PE
4466 * eval.c (Qdebug): Now static.
4467 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4468 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4469 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4470
d66c4c7c
CY
44712011-05-29 Chong Yidong <cyd@stupidchicken.com>
4472
4473 * image.c: Various fixes to ImageMagick code comments.
4474 (Fimagemagick_types): Doc fix.
4475
5fbc2025
PE
44762011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4477
0196f88a
PE
4478 Minor fixes prompted by GCC 4.6.0 warnings.
4479
4480 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4481
5fbc2025
PE
4482 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4483 (x_clipboard_manager_save_all): Move extern decl to ...
4484 * xterm.h: ... here, so that it can be checked for consistency.
4485
1dd3c2d9
CY
44862011-05-29 Chong Yidong <cyd@stupidchicken.com>
4487
4488 * xselect.c (x_clipboard_manager_save_frame)
4489 (x_clipboard_manager_save_all): New functions.
4490 (Fx_clipboard_manager_save): Lisp function deleted.
4491
4492 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4493 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4494
4495 * xterm.h: Update prototype.
4496
5ba6571d
WX
44972011-05-28 William Xu <william.xwl@gmail.com>
4498
4499 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4500 exiting (Bug#8239).
4501
3eaff834
JM
45022011-05-28 Jim Meyering <meyering@redhat.com>
4503
e1900994 4504 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4505 * fns.c (to_uchar): Define.
4506 (crypto_hash_function): Use it to convert some newly-signed
4507 variables to unsigned, to avoid sign-extension bugs. For example,
4508 without this change, (md5 "truc") would evaluate to
4509 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4510 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4511 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4512
0f6990a7
PE
45132011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4514
4515 Integer overflow fixes.
c8a9ca5a 4516
08686060
PE
4517 * dbusbind.c: Serial number integer overflow fixes.
4518 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4519 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4520 to hold a serial number that is too large for a fixnum.
4521 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4522 Check for serial numbers out of range. Decode any serial number
59568bf0 4523 that was so large that it became a float. (Bug#8722)
08686060 4524
2d1fc3c7
PE
4525 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4526 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4527 Use XFASTINT rather than XUINT when numbers are nonnegative.
4528 (xd_append_arg, Fdbus_method_return_internal):
4529 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4530 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4531 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4532 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4533 (Bug#8722)
2d1fc3c7 4534
c8a9ca5a
PE
4535 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4536
519e1d69
PE
4537 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4538
30569699
PE
4539 ccl: add integer overflow checks
4540 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4541 (IN_INT_RANGE): New macros.
4542 (ccl_driver): Use them to check for integer overflow when
4543 decoding a CCL program. Many of the new checks are whether XINT (x)
4544 fits in int; it doesn't always, on 64-bit hosts. The new version
4545 doesn't catch all possible integer overflows, but it's an
847044ea 4546 improvement. (Bug#8719)
30569699 4547
c11285dc
PE
4548 * alloc.c (make_event_array): Use XINT, not XUINT.
4549 There's no need for unsigned here.
4550
fdccd48e
PE
4551 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4552 This follows up to the 2011-05-06 change that substituted uintptr_t
4553 for EMACS_INT. This case wasn't caught back then.
4554
37910ab2
PE
4555 Rework Fformat to avoid integer overflow issues.
4556 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4557 now (part of C89). Include <verify.h>.
4558 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4559 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4560 (Fformat): Avoid the prepass trying to compute sizes; it was only
4561 approximate and thus did not catch overflow reliably. Instead, walk
4562 through the format just once, formatting and computing sizes as we go,
4563 checking for integer overflow at every step, and allocating a larger
4564 buffer as needed. Keep track separately whether the format is
4565 multibyte. Keep only the most-recently calculated precision, rather
4566 than them all. Record whether each argument has been converted to
4567 string. Use EMACS_INT, not int, for byte and char and arg counts.
4568 Support field widths and precisions larger than INT_MAX. Avoid
4569 sprintf's undefined behavior with conversion specifications such as %#d
4570 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4571 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4572 formatting out-of-range floating point numbers with int
9173deec 4573 formats. (Bug#8668)
37910ab2 4574
2e6578fb
PE
4575 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4576
0ae6bdee
PE
4577 * data.c: Avoid integer truncation in expressions involving floats.
4578 * data.c: Include <intprops.h>.
4579 (arith_driver): When there's an integer overflow in an expression
4580 involving floating point, convert the integers to floating point
4581 so that the resulting value does not suffer from catastrophic
4582 integer truncation. For example, on a 64-bit host (* 4
4583 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4584 Do not rely on undefined behavior after integer overflow.
4585
de883a70
PE
4586 merge count_size_as_multibyte, parse_str_to_multibyte
4587 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4588 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4589 Check for integer overflow.
4590 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4591 since it's now a duplicate of the other. This is more of
4592 a character than a buffer op, so better that it's in character.c.
4593 * fns.c, print.c: Adjust to above changes.
4594
2ff916cb
PE
45952011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4596
4597 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4598
f1b54466
PE
45992011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4600
fb1ac845
PE
4601 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4602 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4603 (x_clipboard_manager_save): Now static.
4604 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4605
f1b54466
PE
4606 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4607 (crypto_hash_function): Now static.
4608 Fix pointer signedness problems. Avoid unnecessary initializations.
4609
a9f737ee
CY
46102011-05-27 Chong Yidong <cyd@stupidchicken.com>
4611
4612 * termhooks.h (Vselection_alist): Make it terminal-local.
4613
4614 * terminal.c (create_terminal): Initialize it.
4615
4616 * xselect.c: Support for clipboard managers.
4617 (Vselection_alist): Move to termhooks.h as terminal-local var.
4618 (LOCAL_SELECTION): New macro.
4619 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4620 (symbol_to_x_atom): Remove gratuitous arg.
4621 (x_handle_selection_request, lisp_data_to_selection_data)
4622 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4623 (x_own_selection, x_get_local_selection, x_convert_selection):
4624 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4625 (some_frame_on_display): Delete unused function.
4626 (Fx_own_selection_internal, Fx_get_selection_internal)
4627 (Fx_disown_selection_internal, Fx_selection_owner_p)
4628 (Fx_selection_exists_p): New optional frame arg.
4629 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4630 (x_handle_selection_clear): Don't treat other terminals with the
4631 same keyboard specially. Use the terminal-local Vselection_alist.
4632 (x_clear_frame_selections): Use Frun_hook_with_args.
4633
4634 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4635
4636 * xterm.h: Add support for those atoms.
4637
e067f0c1
CY
46382011-05-26 Chong Yidong <cyd@stupidchicken.com>
4639
4640 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4641 (converted_selections, conversion_fail_tag): New global variables.
4642 (x_selection_request_lisp_error): Free the above.
4643 (x_get_local_selection): Remove unnecessary code.
4644 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4645 of converted selections stored in converted_selections.
4646 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4647 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4648 (x_convert_selection): New function.
4649 (x_handle_selection_event): Simplify.
4650 (x_get_foreign_selection): Don't ignore incoming requests while
4651 waiting for an answer; this will fail when we implement
4652 SAVE_TARGETS, and seems unnecessary anyway.
4653 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4654 (Vx_sent_selection_functions): Doc fix.
4655
0f4aebc0
LL
46562011-05-26 Leo Liu <sdl.web@gmail.com>
4657
4658 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4659
e61124cd
YM
46602011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4661
4662 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4663
4664 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4665 for fringe update if it has periodic bitmap.
ac389d0c 4666 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4667 and fringe_bitmap_periodic_p.
4668
4669 * fringe.c (get_fringe_bitmap_data): New function.
4670 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4671 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4672 row. Mark glyph row for fringe update if periodicity changed.
4673
4674 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4675 for fringe update unless it has periodic bitmap.
4676
f16d9837
KH
46772011-05-25 Kenichi Handa <handa@m17n.org>
4678
4679 * xdisp.c (get_next_display_element): Set correct it->face_id for
4680 a static composition.
4681
e1b90ef6
LL
46822011-05-24 Leo Liu <sdl.web@gmail.com>
4683
4684 * deps.mk (fns.o):
4685 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4686
4687 * fns.c (crypto_hash_function, Fsha1): New function.
4688 (Fmd5): Use crypto_hash_function.
4689 (syms_of_fns): Add Ssha1.
4690
7400048f
PE
46912011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4692
4693 * gnutls.c: Remove unused macros.
4694 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4695 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4696 Remove macros that are defined and never used.
4697 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4698
abb71cf4
CY
46992011-05-22 Chong Yidong <cyd@stupidchicken.com>
4700
4701 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4702 (Fx_get_selection_internal): Minor cleanup.
4703 (Fx_own_selection_internal): Rename arguments for consistency with
4704 select.el.
4705
6307db39
PE
47062011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4707
4708 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4709
f3d4e0a4
CY
47102011-05-22 Chong Yidong <cyd@stupidchicken.com>
4711
4712 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4713
4d8ade89
YM
47142011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4715
4716 * dispnew.c (scrolling_window): Don't exclude the case that the
4717 last enabled row in the desired matrix touches the bottom boundary.
4718
32078c8d
GM
47192011-05-21 Glenn Morris <rgm@gnu.org>
4720
4721 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4722 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4723 and add some more files.
32078c8d 4724
7285dc67
EZ
47252011-05-20 Eli Zaretskii <eliz@gnu.org>
4726
4727 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4728 report_file_error introduced by the change from 2011-05-07.
4729
89d1bd22
PE
47302011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4731
4732 * systime.h (Time): Define only if emacs is defined.
4733 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4734 where the include path doesn't have X11/X.h by default. See
4735 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4736
e23640bb 47372011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4738
4739 * composite.c (find_automatic_composition): Fix previous change.
4740
b9704ad9
GM
47412011-05-20 Glenn Morris <rgm@gnu.org>
4742
4743 * lisp.mk: New file, split from Makefile.in.
4744 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4745 (shortlisp): Remove.
4746 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4747
4a720484
GM
47482011-05-19 Glenn Morris <rgm@gnu.org>
4749
4750 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4751 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4752 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4753 (lisp): Set the order to that of loadup.el.
4754 (shortlisp): Make it a copy of $lisp.
4755 (SOME_MACHINE_LISP): Remove.
4756 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4757 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4758
a28d4396
KH
47592011-05-18 Kenichi Handa <handa@m17n.org>
4760
4761 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4762 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4763 (find_automatic_composition): Mostly rewrite for efficiency.
4764
a2b1fa8e
JB
47652011-05-18 Juanma Barranquero <lekktu@gmail.com>
4766
4767 * makefile.w32-in: Update dependencies.
4768
8e1f5610
CS
47692011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4770
4771 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4772 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4773
7025ee00 47742011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4775
cdfa6eab
PE
4776 Fix some integer overflow issues, such as string length overflow.
4777
06d6db33
PE
4778 * insdel.c (count_size_as_multibyte): Check for string overflow.
4779
2b4560a8
PE
4780 * character.c (lisp_string_width): Check for string overflow.
4781 Use EMACS_INT, not int, for string indexes and lengths; in
4782 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4783 the resulting string length overflows an EMACS_INT; instead,
4784 report a string overflow if no precision given. When checking for
4785 precision exhaustion, use a check that cannot possibly have
4786 integer overflow. (Bug#8675)
4787 * character.h (lisp_string_width): Adjust to new signature.
4788
cb93f9be
PE
4789 * alloc.c (string_overflow): New function.
4790 (Fmake_string): Use it. This doesn't change behavior, but saves
4791 a few bytes and will simplify future changes.
4792 * character.c (string_escape_byte8): Likewise.
4793 * lisp.h (string_overflow): New decl.
4794
1a1f3366
PE
4795 Fixups, following up to the user-interface timestamp change.
4796 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4797 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4798 * msdos.c (mouse_get_pos): Likewise.
4799 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4800 * w32gui.h (Time): Define by including "systime.h" rather than by
4801 declaring it ourselves. (Bug#8664)
4802
d4e3e4d3
PE
4803 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4804 * image.c (clear_image_cache): Likewise.
4805
f6a24d19
PE
4806 * term.c (term_mouse_position): Don't assume time_t wraparound.
4807
08dc5ae6
PE
4808 Be more systematic about user-interface timestamps.
4809 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4810 and sometimes 'EMACS_UINT', to represent these timestamps.
4811 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4812 This makes the code easier to follow, and makes it easier to catch
4813 integer overflow bugs such as Bug#8664.
4814 * frame.c (Fmouse_position, Fmouse_pixel_position):
4815 Use Time, not unsigned long, for user-interface timestamps.
4816 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4817 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4818 * keyboard.h (last_event_timestamp): Likewise.
4819 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4820 * menu.h (xmenu_show): Likewise.
4821 * term.c (term_mouse_position): Likewise.
4822 * termhooks.h (struct input_event.timestamp): Likewise.
4823 (struct terminal.mouse_position_hook): Likewise.
4824 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4825 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4826 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4827 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4828 what it was before.
4829 * menu.h, termhooks.h: Include "systime.h", for Time.
4830
8e55734a
PE
4831 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4832 Don't assume that the difference between two unsigned long values
4833 can fit into an integer. At this point, we know button_down_time
4834 <= event->timestamp, so the difference must be nonnegative, so
4835 there's no need to cast the result if double-click-time is
4836 nonnegative, as it should be; check that it's nonnegative, just in
4837 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4838 apart (about 25 days). (Bug#8664)
8e55734a 4839
841f1b75 4840 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4841 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4842
3e26f69c
PE
4843 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4844 that always fit in int. Use a sentinel instead of a counter, to
4845 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4846 * frame.h (struct frame): Use int for menu_bar_items_used
4847 instead of EMACS_INT, since it always fits in int.
3e26f69c 4848
5cc152c0
PE
4849 * menu.c (grow_menu_items): Check for int overflow.
4850
d89eb65e
PE
4851 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4852
5235bd3e
PE
4853 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4854 Before, the code was not consistent. These values cannot exceed
4855 2**31 - 1 so there's no need to make them unsigned.
4856 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4857 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4858 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4859 as modifiers.
4860 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4861
bc827e23
PE
4862 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4863 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4864 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4865 presumably because the widths might not match.
4866
78eb494e
PE
4867 * window.c (size_window): Avoid needless test at loop start.
4868
04f2d78b
CB
48692011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4870
4871 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4872
d2fc7e3d 48732011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4874
4875 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4876
d2fc7e3d 48772011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4878
4879 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4880 `width' to `bar_area_x' and `bar_area_width', respectively.
4881 (x_scroll_run): Take account of fringe background extension.
4882
04f2d78b
CB
4883 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4884 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4885 `bar_area_width', respectively.
4886 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4887 background extension.
4888
79b70037
GM
48892011-05-10 Jim Meyering <meyering@redhat.com>
4890
4891 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4892
2f142cc5
JB
48932011-05-10 Juanma Barranquero <lekktu@gmail.com>
4894
4895 * image.c (Finit_image_library): Return t for built-in image types,
4896 like pbm and xbm. (Bug#8640)
4897
57679c86
AS
48982011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4899
4900 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4901
888c9e86
EZ
49022011-05-07 Eli Zaretskii <eliz@gnu.org>
4903
b0512a1d
EZ
4904 * w32console.c (Fset_screen_color): Doc fix.
4905 (Fget_screen_color): New function.
4906 (syms_of_ntterm): Defsubr it.
4907
7285dc67
EZ
4908 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4909 unlink the temporary file if Fcall_process didn't create it in the
4910 first place.
4911 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4912 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4913 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4914 cue to call_process_cleanup not to close that handle.
4915
4d3fcc8e
BK
49162011-05-07 Ben Key <bkey76@gmail.com>
4917
4918 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4919 one of two shell specific rules, either bootstrap-temacs-CMD or
4920 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4921 to the previous implementation of the bootstrap-temacs rule.
4922 The bootstrap-temacs-CMD rule is similar to the previous
4923 implementation of the bootstrap-temacs rule except that it
4924 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4925 variable.
4926
4927 These changes, along with some changes to nt/configure.bat,
4928 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4929 earlier fix to add support for --cflags and --ldflags options
4930 that include quotes so that it works whether make uses cmd or
4931 sh as the shell.
4932
b4289b64
MA
49332011-05-06 Michael Albinus <michael.albinus@gmx.de>
4934
4935 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4936 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4937 is a constant.
4938 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4939 a string. Handle both cases.
4940 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4941 (Fdbus_register_method): Use Qinvalid_function.
4942
af4c0e28
JB
49432011-05-06 Juanma Barranquero <lekktu@gmail.com>
4944
4945 * makefile.w32-in: Update dependencies.
4946 (LISP_H): Add inttypes.h and stdin.h.
4947 (PROCESS_H): Add unistd.h.
4948
c51453d9
EZ
49492011-05-06 Eli Zaretskii <eliz@gnu.org>
4950
4951 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4952 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4953
8ff0ac3c 49542011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4955
4c4b566b
PE
4956 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4957
aab2b9b5
PE
4958 * term.c (vfatal): Remove stray call to va_end.
4959 It's not needed and the C Standard doesn't allow it here anyway.
4960
c378da0b
PE
4961 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4962 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4963
288b08c7
PE
4964 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4965 bytes.
4966
e3601888
PE
4967 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4968
db6c0e74
PE
4969 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4970
dd5963ea
PE
4971 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4972
88c9450f
PE
4973 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4974
2f9442b8
PE
4975 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4976
c032b5f8
PE
4977 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4978 * charset.c (Fdefine_charset_internal): Don't initialize
4979 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4980 32-bit int (Bug#8600).
a108c10b
PE
4981
4982 * lread.c (read_integer): Be more consistent with string-to-number.
4983 Use string_to_number to do the actual conversion; this avoids
4984 rounding errors and fixes some other screwups. Without this fix,
4985 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4986 (digit_to_number): Move earlier, for benefit of read_integer.
4987 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4988 not a digit in any supported base. (Bug#8602)
a108c10b 4989
ad5f9eea
PE
4990 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4991
aec1708a
PE
4992 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4993 to match comment at start of function. This also removes a
4994 GCC warning about overflow in a 32+64-bit port.
4995
47be4ab5
PE
4996 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4997
371cac43
PE
4998 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4999 Reported by Stefan Monnier in
5000 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5001 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5002 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5003
d01a7826
PE
5004 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5005 (EMACS_UINTPTR): Likewise, with uintptr_t.
5006
7fd47d5c
PE
5007 * lisp.h: Prefer 64-bit EMACS_INT if available.
5008 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5009 on 32-bit hosts that have 64-bit int, so that they can access
5010 large files.
122b0c86
PE
5011 However, temporarily disable this change unless the temporary
5012 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5013
8727937b
PE
5014 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5015
8ac068ac
PE
5016 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5017 This removes an assumption that EMACS_INT and long are the same
5018 width as pointers. The assumption is true for Emacs porting targets
5019 now, but we want to make other targets possible.
5020 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5021 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5022 In the rest of the code, change types of integers that hold casted
5023 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5024 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5025 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5026 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5027 No need to cast type when ORing.
5028 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5029 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5030 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5031 assume EMACS_INT is the same width as char *.
5032 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5033 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5034 Remove no-longer-needed casts.
5035 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5036 (xg_tool_bar_help_callback, xg_make_tool_item):
5037 Use EMACS_INTPTR to hold an integer
5038 that will be cast to void *; this can avoid a GCC warning
5039 if EMACS_INT is not the same width as void *.
5040 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5041 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5042 (current_message_1, set_message_1):
5043 Use a local to convert to proper width without a cast.
5044 * xmenu.c (dialog_selection_callback): Likewise.
5045
ede49d71
PE
5046 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5047 Also, don't assume VALBITS / RAND_BITS is less than 5,
5048 and don't rely on undefined behavior when shifting a 1 left into
5049 the sign bit.
5050 * lisp.h (get_random): Change signature to match.
5051
2f30ecd0
PE
5052 * lread.c (hash_string): Use size_t, not int, for hash computation.
5053 Normally we prefer signed values; but hashing is special, because
5054 it's better to use unsigned division on hash table sizes so that
5055 the remainder is nonnegative. Also, size_t is the natural width
5056 for hashing into memory. The previous code used 'int', which doesn't
5057 retain enough info to hash well into very large tables.
5058 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5059
2a866e7b
PE
5060 * dbusbind.c: Don't possibly lose pointer info when converting.
5061 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5062 Use XPNTR rather than XHASH, so that the high-order bits of
5063 the pointer aren't lost when converting through void *.
5064
51639eac
PE
5065 * eval.c (Fautoload): Don't double-shift a pointer.
5066
92394119
PE
5067 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5068
dbdb9a7c
JB
50692011-05-06 Juanma Barranquero <lekktu@gmail.com>
5070
5071 * gnutls.c (DEF_GNUTLS_FN):
5072 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5073
db7a0b4f
AS
50742011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5075
5076 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5077 marker. (Bug#8610)
5078
f7ff1b0f 50792011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5080
5081 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5082 New version that can reserve upto 2GB of heap space.
5083
f7ff1b0f 50842011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5085
5086 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5087
639c109b
TZ
50882011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5089
5090 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5091 `gnutls_certificate_set_x509_key_file'.
5092
d2127135
JB
50932011-05-05 Juanma Barranquero <lekktu@gmail.com>
5094
5095 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5096 Update dependencies.
5097
e968f4f3
JB
50982011-05-04 Juanma Barranquero <lekktu@gmail.com>
5099
5100 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5101 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5102 Remove unused parameter `fildes'.
5103 * process.c (read_process_output, send_process): Don't pass it.
5104
84d358f0
JB
51052011-05-04 Juanma Barranquero <lekktu@gmail.com>
5106
5107 Fix previous change: the library cache is defined in w32.c.
5108 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5109 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5110
0898ca10
JB
51112011-05-04 Juanma Barranquero <lekktu@gmail.com>
5112
5113 Implement dynamic loading of GnuTLS on Windows.
5114
5115 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5116 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5117 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5118 Declare.
5119
5120 * gnutls.c (Qgnutls_dll): Define.
5121 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5122 (gnutls_*): Declare function pointers.
5123 (init_gnutls_functions): New function to initialize function pointers.
5124 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5125 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5126 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5127 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5128 (emacs_gnutls_write, emacs_gnutls_read)
5129 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5130 (Fgnutls_available_p): New function.
5131 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5132 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5133 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5134
5135 * image.c: Include w32.h.
5136 (Vimage_type_cache): Delete.
5137 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5138 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5139 (w32_delayed_load): Move to w32.c.
5140
5141 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5142
5143 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5144 (w32_delayed_load): Move from image.c. When loading a library, record
5145 its filename in the :loaded-from property of the library id.
5146 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5147 Initialize and staticpro them.
5148 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5149
5150 * process.c: Include lisp.h before w32.h, not after.
5151 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5152 instead of gnutls_record_check_pending.
5153
5154 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5155
ff4de4aa
TZ
51562011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5157
5158 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5159 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5160 as passed in.
5161
abe95abb
JD
51622011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5163
5164 * xterm.c (x_set_frame_alpha): Do not set property on anything
5165 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5166
e16e55d4
JB
51672011-05-02 Juanma Barranquero <lekktu@gmail.com>
5168
5169 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5170
bafcf6a5
JB
51712011-05-02 Juanma Barranquero <lekktu@gmail.com>
5172
5173 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5174 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5175 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5176 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5177 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5178 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5179 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5180 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5181 (Qgnutls_bootprop_callbacks_verify): Make static.
5182
e7a6747f
AS
51832011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5184
19ed11ba
AS
5185 * callproc.c: Indentation fixup.
5186
e7a6747f 5187 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5188 (wait_for_termination, interruptible_wait_for_termination):
5189 Move after wait_for_termination_1.
e7a6747f 5190
1ef14cb4
LMI
51912011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5192
5193 * sysdep.c (interruptible_wait_for_termination): New function
5194 which is like wait_for_termination, but allows keyboard
5195 interruptions.
5196
5197 * callproc.c (Fcall_process): Add (:file "file") as an option for
5198 the STDOUT buffer.
5199 (Fcall_process_region): Ditto.
5200
330d880c
EZ
52012011-04-30 Eli Zaretskii <eliz@gnu.org>
5202
8db90b73
EZ
5203 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5204 rather than `XVECTOR (FOO)->size'.
5205
330d880c
EZ
5206 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5207 inttypes.h, as a gnulib replacement is used if it not available in
5208 system headers.
5209
15cbd324
EZ
52102011-04-21 Eli Zaretskii <eliz@gnu.org>
5211
5212 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5213 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5214 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5215
5216 * coding.c (coding_alloc_by_realloc): Error out if destination
5217 will grow beyond MOST_POSITIVE_FIXNUM.
5218 (decode_coding_emacs_mule): Abort if there isn't enough place in
5219 charbuf for the composition carryover bytes. Reserve an extra
5220 space for up to 2 characters produced in a loop.
5221 (decode_coding_iso_2022): Abort if there isn't enough place in
5222 charbuf for the composition carryover bytes.
5223
52242011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5225
ae940cca
EZ
5226 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5227 aborting when %lld or %lll format is passed.
5228 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5229 %llo or %llx format is passed. (Bug#8545)
5230
03ab8921
EZ
5231 * window.c (window_scroll_line_based): Use a marker instead of
5232 simple variables to record original value of point. (Bug#7952)
5233
afda1437
EZ
5234 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5235 produced by %s or %c overflows available buffer space. (Bug#8545)
5236
f76dee0c
PE
52372011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5238
5239 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5240 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5241
fdc5744d
JB
52422011-04-28 Juanma Barranquero <lekktu@gmail.com>
5243
5244 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5245
638f053a
JB
52462011-04-28 Juanma Barranquero <lekktu@gmail.com>
5247
5248 * keyboard.c (Qdelayed_warnings_hook): Define.
5249 (command_loop_1): Run `delayed-warnings-hook'
5250 if Vdelayed_warnings_list is non-nil.
5251 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5252 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5253
d178f871
EZ
52542011-04-28 Eli Zaretskii <eliz@gnu.org>
5255
5256 * doprnt.c (doprnt): Don't return value smaller than the buffer
5257 size if the message was truncated. (Bug#8545).
5258
b124fd93
JB
52592011-04-28 Juanma Barranquero <lekktu@gmail.com>
5260
5261 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5262 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5263
e810457d
PE
52642011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5265
5266 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5267
ea51cceb
JB
52682011-04-27 Juanma Barranquero <lekktu@gmail.com>
5269
5270 * makefile.w32-in: Update dependencies.
5271
94dcfacf
EZ
52722011-04-27 Eli Zaretskii <eliz@gnu.org>
5273
5274 Improve `doprnt' and its usage. (Bug#8545)
5275 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5276 `format_end'. Remove support for %l as a conversion specifier.
5277 Don't use xrealloc. Improve diagnostics when the %l size modifier
5278 is used. Update the commentary.
5279
5280 * eval.c (verror): Simplify calculation of size_t.
5281
5282 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5283 messages.
5284
f61f41d7
PE
52852011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5286
5287 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5288 change.
5289
96fb4434
PE
52902011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5291
5292 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5293 This makes this file independent of the recent pseudovector change.
5294
671875da 52952011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5296
69e9b5a3
PE
5297 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5298
b5f869a7 5299 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5300 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5301 Remove unused local.
c8926152 5302 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5303
841a1577 5304 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5305 GCC 4.6.0 optimizes based on type-based alias analysis.
5306 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5307 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5308 != &v->size, and therefore "v->size = 1; b->size = 2; return
5309 v->size;" must therefore return 1. This assumption is incorrect
5310 for Emacs, since it type-puns struct Lisp_Vector * with many other
5311 types. To fix this problem, this patch adds a new type struct
f904488f 5312 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5313 and pseudovectors, and helps optimizing compilers not get fooled
5314 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5315 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5316 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5317 the size member.
eab3844f
PE
5318 (XSETPVECTYPE): Rewrite in terms of new macro.
5319 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5320 This is a bit clearer, and further avoids the possibility of
5321 undesirable aliasing.
5322 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5323 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5324 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5325 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5326 (ASIZE): Now uses header.size rather than size.
5327 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5328 to avoid the hassle of writing XVECTOR (foo)->header.size.
5329 (struct vectorlike_header): New type.
eab3844f
PE
5330 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5331 object, to help avoid aliasing.
5332 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5333 (SUBRP): Likewise, since Lisp_Subr is a special case.
5334 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5335 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5336 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5337 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5338 changed to be "header.size" and "header.next".
5339 * buffer.h (struct buffer): Likewise.
5340 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5341 * frame.h (struct frame): Likewise.
5342 * process.h (struct Lisp_Process): Likewise.
5343 * termhooks.h (struct terminal): Likewise.
5344 * window.c (struct save_window_data, struct saved_window): Likewise.
5345 * window.h (struct window): Likewise.
5346 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5347 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5348 * buffer.c (init_buffer_once): Likewise.
5349 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5350 special case.
5351 * process.c (Fformat_network_address): Use local var for size,
5352 for brevity.
5353
0df1eac5
PE
5354 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5355
847ab9d1 5356 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5357 * data.c (atof): Remove decl; no longer used or needed.
5358 (digit_to_number): Move to lread.c.
5359 (Fstring_to_number): Use new string_to_number function, to be
5360 consistent with how the Lisp reader treats infinities and NaNs.
5361 Do not assume that floating-point numbers represent EMACS_INT
5362 without losing information; this is not true on most 64-bit hosts.
5363 Avoid double-rounding errors, by insisting on integers when
5364 parsing non-base-10 numbers, as the documentation specifies.
5365 * lisp.h (string_to_number): New decl, replacing ...
5366 (isfloat_string): Remove.
bc0a5c13 5367 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5368 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5369 appears to have been a coding error. Similarly, do not accept
5370 strings like +-1e0 as floating point numbers. Do not report
5371 overflow for integer overflows unless the base is not 10 which
5372 means we have no simple and reliable way to continue.
5373 Break out the floating-point parsing into a new
5374 function string_to_number, so that Fstring_to_number parses
5375 floating point numbers consistently with the Lisp reader.
04f2d78b 5376 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5377 (E_CHAR, EXP_INT): Remove, replacing with ...
5378 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5379 (string_to_number): New function, replacing isfloat_string.
5380 This function checks for valid syntax and produces the resulting
5381 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5382 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5383 so that overflow for non-base-10 numbers is reported only when
5384 there's no portable and simple way to convert to floating point.
452f4150 5385
67769ffc
PE
5386 * textprop.c (set_text_properties_1): Rewrite for clarity,
5387 and to avoid GCC warning about integer overflow.
5388
c20db43f
PE
5389 * intervals.h (struct interval): Use EMACS_INT for members
5390 where EMACS_UINT might cause problems. See
5391 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5392 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5393 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5394 All uses changed.
37aa2f85
PE
5395 (offset_intervals): Tell GCC not to worry about length overflow
5396 when negating a negative length.
c20db43f 5397
2538aa2f
PE
5398 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5399 (overrun_check_free): Likewise.
5400
f2d3008d
PE
5401 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5402 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5403 word size.
5404
ec8df744
PE
5405 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5406 (gnutls_make_error): Rename local to avoid shadowing.
5407 (gnutls_emacs_global_deinit): ifdef out; not used.
5408 (Fgnutls_boot): Use const for pointer to readonly storage.
5409 Comment out unused local. Fix pointer signedness problems.
5410
640ee02d
PE
5411 * lread.c (openp): Don't stuff size_t into an 'int'.
5412 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5413 about possible signed overflow.
5414
6048fb2a
PE
5415 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5416 (GDK_KEY_g): Don't define if already defined.
5417 (xg_prepare_tooltip): Avoid pointer signedness problem.
5418 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5419
fa3c87e1
PE
5420 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5421 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5422
2172544b
PE
5423 * xfns.c (Fx_window_property): Simplify a bit,
5424 to make a bit faster and to avoid GCC 4.6.0 warning.
5425 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5426
9b821a21
PE
5427 * fns.c (internal_equal): Don't assume size_t fits in int.
5428
3c616cfa
PE
5429 * alloc.c (compact_small_strings): Tighten assertion a little.
5430
c2982e87
PE
5431 Replace pEd with more-general pI, and fix some printf arg casts.
5432 * lisp.h (pI): New macro, generalizing old pEd macro to other
5433 conversion specifiers. For example, use "...%"pI"d..." rather
5434 than "...%"pEd"...".
5435 (pEd): Remove. All uses replaced with similar uses of pI.
5436 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5437 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5438 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5439 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5440 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5441 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5442 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5443 64-bit hosts.
5444 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5445 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5446 * print.c (safe_debug_print, print_object): Likewise.
5447 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5448 to int.
6f04d126
PE
5449 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5450 avoiding the 0 flag, which is not portable.
c2982e87
PE
5451 * process.c (Fmake_network_process): Use pI to avoid cast.
5452 * region-cache.c (pp_cache): Likewise.
5453 * xdisp.c (decode_mode_spec): Likewise.
5454 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5455 behavior on 64-bit hosts with printf arg.
6f04d126 5456 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5457 (x_stop_queuing_selection_requests): Likewise.
5458 (x_get_window_property): Don't truncate byte count to an 'int'
5459 when tracing.
0b432f21 5460
5e073ec7
PE
5461 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5462 here, since it parses constructs like leading '-' and spaces,
5463 which are not wanted; and it overflows with large numbers.
5464 Instead, simply match F[0-9]+, which is what is wanted anyway.
5465
36372bf9
PE
5466 * alloc.c: Remove unportable assumptions about struct layout.
5467 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5468 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5469 (allocate_vectorlike, make_pure_vector): Use the new macros,
5470 plus offsetof, to remove unportable assumptions about struct layout.
5471 These assumptions hold on all porting targets that I know of, but
5472 they are not guaranteed, they're easy to remove, and removing them
5473 makes further changes easier.
5474
0b432f21
PE
5475 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5476 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5477 (string_overrun_cookie): Now const. Use initializers that
5478 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5479 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5480 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5481 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5482 multiple of sizeof (EMACS_INT); it need not be, if
5483 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5484 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5485
895009e1
JB
54862011-04-26 Juanma Barranquero <lekktu@gmail.com>
5487
5488 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5489
6a7a1b0b
TZ
54902011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5491
5492 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5493 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5494 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5495
841a1577 54962011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5497
5498 * lisp.h (Qdebug): List symbol.
895009e1 5499 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5500 * keyboard.c (debug-on-event): New variable.
5501 (handle_user_signal): Break into debugger when debug-on-event
5502 matches the current signal symbol.
5503
f2d3ba6f
DN
55042011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5505
5506 * alloc.c (check_sblock, check_string_bytes)
5507 (check_string_free_list): Convert to standard C.
5508
42ce4c63
TZ
55092011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5510
5511 * w32.c (emacs_gnutls_push): Fix typo.
5512
825cd63c
EZ
55132011-04-25 Eli Zaretskii <eliz@gnu.org>
5514
fb11d64d
EZ
5515 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5516 "cast to pointer from integer of different size".
5517
825cd63c
EZ
5518 Improve doprnt and its use in verror. (Bug#8545)
5519 * doprnt.c (doprnt): Document the set of format control sequences
5520 supported by the function. Use SAFE_ALLOCA instead of always
5521 using `alloca'.
5522
5523 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5524 is one byte too soon. Don't use xrealloc; instead xfree and
5525 xmalloc anew.
5526
e061a11b
TZ
55272011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5528
5529 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5530 callbacks stage.
5531
5532 * gnutls.c: Renamed global_initialized to
5533 gnutls_global_initialized. Added internals for the
5534 :verify-hostname-error, :verify-error, and :verify-flags
5535 parameters of `gnutls-boot' and documented those parameters in the
5536 docstring. Start callback support.
9173deec
JB
5537 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5538 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5539 on error. Return error code.
e061a11b
TZ
5540 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5541 (emacs_gnutls_read): Likewise.
5542 (Fgnutls_boot): Return handshake error code.
5543 (emacs_gnutls_handle_error): New function.
5544 (wsaerror_to_errno): Likewise.
5545
5546 * w32.h (emacs_gnutls_pull): Add prototype.
5547 (emacs_gnutls_push): Likewise.
5548
5549 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5550 (emacs_gnutls_push): Likewise.
5551
55522011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5553
5554 * process.c (wait_reading_process_output): Check if GnuTLS
5555 buffered some data internally if no FDs are set for TLS
5556 connections.
5557
5558 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5559 (LIBS): Link to USER_LIBS.
5560 ($(BLD)/gnutls.$(0)): New target.
5561
fa6996bc
EZ
55622011-04-24 Eli Zaretskii <eliz@gnu.org>
5563
eb35682e
EZ
5564 * xdisp.c (handle_single_display_spec): Rename the
5565 display_replaced_before_p argument into display_replaced_p, to
5566 make it consistent with the commentary. Fix typos in the
5567 commentary.
5568
e2ad650c
EZ
5569 * textprop.c (syms_of_textprop): Remove dead code.
5570 (copy_text_properties): Delete obsolete commentary about an
5571 interface that was deleted long ago. Fix typos in the description
5572 of arguments.
5573
1b2de274
EZ
5574 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5575 to changes in oldXMenu/XMenu.h from 2011-04-16.
5576 <menu_help_message, prev_menu_help_message>: Constify.
5577 (IT_menu_make_room): menu->help_text is now `const char **';
5578 adjust.
5579
5580 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5581 to changes in oldXMenu/XMenu.h from 2011-04-16.
5582 (struct XMenu): Declare `help_text' `const char **'.
5583
5584 * xfaces.c <Qunspecified>: Make extern again.
5585
5586 * syntax.c: Include sys/types.h before including regex.h, as
5587 required by Posix.
5588
762b15be
EZ
5589 * doc.c (get_doc_string): Improve the format passed to `error'.
5590
5591 * doprnt.c (doprnt): Improve commentary.
5592
5593 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5594
5595 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5596 them with etags.
5597
f1052e5d
EZ
5598 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5599 changes in globals.h immediately force recompilation.
762b15be
EZ
5600 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5601 $(CURDIR)/s/ms-w32.h.
5602 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5603
fa6996bc
EZ
5604 * character.c (Fchar_direction): Function deleted.
5605 (syms_of_character): Don't defsubr it.
5606 <char-direction-table>: Deleted.
5607
e6c3da20
EZ
56082011-04-23 Eli Zaretskii <eliz@gnu.org>
5609
5610 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5611 * doprnt.c: Include limits.h.
5612 (SIZE_MAX): New macro.
04f2d78b
CB
5613 (doprnt): Return a size_t value. 2nd arg is now size_t.
5614 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5615 Improve overflow protection. Support `l' modifier for integer
5616 conversions. Support %l conversion. Don't assume an EMACS_INT
5617 argument for integer conversions and for %c.
5618
5619 * lisp.h (doprnt): Restore prototype.
5620
5621 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5622 $(SRC)/character.h.
5623
5624 * Makefile.in (base_obj): Add back doprnt.o.
5625
5626 * deps.mk (doprnt.o): Add back prerequisites.
5627 (callint.o): Depend on character.h.
5628
5629 * eval.c (internal_lisp_condition_case): Include the handler
5630 representation in the error message.
5631 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5632 when breaking from the loop.
5633
5634 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5635
5636 * callint.c (Fcall_interactively): When displaying error message
5637 about invalid control letter, pass the character's codepoint, not
5638 a pointer to its multibyte form. Improve display of the character
5639 in octal and display also its hex code.
5640
5641 * character.c (char_string): Use %x to display the (unsigned)
5642 codepoint of an invalid character, to avoid displaying a bogus
5643 negative value.
5644
5645 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5646 `error', not SYMBOL_NAME itself.
5647
5648 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5649 character arguments to `error'.
5650
5651 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5652 to `error' in error message about FINAL_CHAR argument. Make sure
5653 FINAL_CHAR is a character, and use %c when it is passed as
5654 argument to `error'.
5655
4ffd0d6b 56562011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5657
5658 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5659
5660 * w32.c: Include <time.h>.
5661 (sys_localtime): New function.
5662
4ffd0d6b 56632011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5664
5665 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5666
4ffd0d6b 5667 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5668
4ffd0d6b 56692011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5670
4ffd0d6b
GM
5671 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5672 zombies (Bug#8467).
aac0c6e3 5673
04c56954
EZ
56742011-04-19 Eli Zaretskii <eliz@gnu.org>
5675
5676 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5677 gl_state.e_property when gl_state.object is Qt.
5678
5679 * insdel.c (make_gap_larger): Remove limitation of buffer size
5680 to <= INT_MAX.
5681
16a43933
CY
56822011-04-18 Chong Yidong <cyd@stupidchicken.com>
5683
5684 * xdisp.c (lookup_glyphless_char_display)
5685 (produce_glyphless_glyph): Handle cons cell entry in
5686 glyphless-char-display.
5687 (Vglyphless_char_display): Document it.
5688
5689 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5690 glyphless-char-display.
5691
4581706e
CY
56922011-04-17 Chong Yidong <cyd@stupidchicken.com>
5693
5694 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5695
5696 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5697
5698 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5699 definition for no-X builds.
5700
4887c6e2 57012011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5702
fd35b6f9
PE
5703 Static checks with GCC 4.6.0 and non-default toolkits.
5704
5c1ccb01
PE
5705 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5706
006c5daa
PE
5707 * process.c (keyboard_bit_set): Define only if SIGIO.
5708 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5709 (send_process): Repair possible setjmp clobbering.
5710
efc736d3
PE
5711 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5712
4e2fe2e6
PE
5713 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5714
f97334a2
PE
5715 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5716
4e75f29d
PE
5717 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5718 Define only if needed.
5719
90efadd1
PE
5720 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5721 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5722 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5723
3c647824
PE
5724 * dispextern.h (struct redisplay_interface): Rename param
5725 to avoid shadowing.
e264f262 5726 * termhooks.h (struct terminal): Likewise.
761383f4 5727 * xterm.c (xembed_send_message): Likewise.
3c647824 5728
b58c5c4a
PE
5729 * insdel.c (make_gap_smaller): Define only if
5730 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5731
cad59032
PE
5732 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5733 it.
5734
c339dc2e
PE
5735 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5736 so that we aren't warned about unused symbols.
5737
91a3e27b
PE
5738 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5739
399c71d3 5740 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5741
8ffc96f5
PE
5742 * xfns.c (x_real_positions): Mark locals as initialized.
5743
eef9bc79
PE
5744 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5745
098db9dd
PE
5746 * xterm.c: Fix problems found by static analysis with other toolkits.
5747 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5748 (x_dispatch_event): Declare static if USE_GTK, and
5749 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5750 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5751 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5752 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5753 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5754
eb18f6cc
PE
5755 * xmenu.c (menu_help_callback): Pointer type fixes.
5756 Use const pointers when pointing at readonly data. Avoid pointer
5757 signedness clashes.
5758 (FALSE): Remove unused macro.
5759 (update_frame_menubar): Remove unused decl.
5760
1fe72bf8
PE
5761 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5762
60d9e1db
PE
5763 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5764 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5765 (single_menu_item): Rename local to avoid shadowing.
5766
39261c26
PE
5767 * keyboard.c (make_lispy_event): Remove unused local var.
5768
018c5e19
PE
5769 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5770 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5771
63d2b86e
PE
5772 * bitmaps: Change bitmaps from unsigned char back to the X11
5773 compatible char. Avoid the old compiler warnings about
5774 out-of-range initializers by using, for example, '\xab' rather
5775 than 0xab.
5776
aefd87e1
PE
5777 * xgselect.c (xgselect_initialize): Check vs interface
5778 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5779
bf501fb9
PE
5780 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5781
e9829fdf
PE
5782 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5783 to read-only memory.
5784
1086c095
PE
5785 * fns.c (vector): Remove; this old hack is no longer needed.
5786
2baccd04 5787 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5788 Remove unused var.
dde42981 5789 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5790
72391843 5791 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5792
436c16df 5793 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5794 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5795 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5796
92bb796d 5797 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5798 (x_term_init): Remove local to avoid shadowing.
92bb796d 5799
764430a3 5800 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5801
5802 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5803 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5804
d1dfb56c
EZ
58052011-04-16 Eli Zaretskii <eliz@gnu.org>
5806
c4354cb4
EZ
5807 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5808
d1dfb56c
EZ
5809 Fix regex.c, syntax.c and friends for buffers > 2GB.
5810 * syntax.h (struct gl_state_s): Declare character position members
5811 EMACS_INT.
5812
5813 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5814
04f2d78b
CB
5815 * textprop.c (verify_interval_modification, interval_of):
5816 Declare arguments EMACS_INT.
d1dfb56c
EZ
5817
5818 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5819 EMACS_INT.
5820
5821 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5822
5823 * indent.c (Fvertical_motion): Local variable it_start is now
5824 EMACS_INT.
5825
5826 * regex.c (re_match, re_match_2, re_match_2_internal)
5827 (bcmp_translate, regcomp, regexec, print_double_string)
5828 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5829 (re_compile_pattern, re_exec): Declare arguments and local
5830 variables `size_t' and `ssize_t' and return values `regoff_t', as
5831 appropriate.
5832 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5833 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5834 <compile_stack_type>: `size' and `avail' are now `size_t'.
5835
5836 * regex.h <regoff_t>: Use ssize_t, not int.
5837 (re_search, re_search_2, re_match, re_match_2): Arguments that
5838 specify buffer/string position and length are now ssize_t and
5839 size_t. Return type is regoff_t.
5840
613052cd
BK
58412011-04-16 Ben Key <bkey76@gmail.com>
5842
5843 * nsfont.m: Fixed bugs in ns_get_family and
5844 ns_descriptor_to_entity that were caused by using free to
5845 deallocate memory blocks that were allocated by xmalloc (via
5846 xstrdup). This caused Emacs to crash when compiled with
5847 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5848 --enable-checking=xmallocoverrun). xfree is now used to
5849 deallocate these memory blocks.
5850
4170f62f 58512011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5852
71b41406
PE
5853 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5854
9587a89d
PE
5855 emacs_write: Accept and return EMACS_INT for sizes.
5856 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5857 et seq.
5858 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5859 Accept and return EMACS_INT.
5860 (emacs_gnutls_write): Return the number of bytes written on
5861 partial writes.
5862 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5863 (emacs_read, emacs_write): Remove check for negative size, as the
5864 Emacs source code has been audited now.
9587a89d
PE
5865 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5866 (emacs_read, emacs_write): Use it.
273a5f82
PE
5867 * process.c (send_process): Adjust to the new signatures of
5868 emacs_write and emacs_gnutls_write. Do not attempt to store
5869 a byte offset into an 'int'; it might overflow.
9587a89d 5870 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5871
3e047f51
PE
5872 * sound.c: Don't assume sizes fit in 'int'.
5873 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5874 Return EMACS_INT, not int.
3e047f51 5875 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5876 Accept EMACS_INT, not int.
5877 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5878 record read return values.
5879
cc39a9db
BK
58802011-04-15 Ben Key <bkey76@gmail.com>
5881
c9d0ec6d
JB
5882 * keyboard.c (Qundefined): Don't declare static since it is used
5883 in nsfns.m.
5884 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5885 static since they are used in nsfont.m.
cc39a9db 5886
6c60eb9f
SM
58872011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5888
5889 * process.c (Qprocessp): Don't declare static.
5890 * lisp.h (Qprocessp): Declare again.
5891
7990b61a
JB
58922011-04-15 Juanma Barranquero <lekktu@gmail.com>
5893
5894 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5895
5d4cb038
PE
58962011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5897
8bd7b830 5898 Improve C-level modularity by making more things 'static'.
cd64ea1d 5899
e3b27b31
PE
5900 Don't publish debugger-only interfaces to other modules.
5901 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5902 (verify_bytepos, count_markers): Move decls to the only modules
5903 that need them.
5904 * region-cache.h (pp_cache): Likewise.
5905 * window.h (check_all_windows): Likewise.
5906 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5907
5d4cb038
PE
5908 * sysdep.c (croak): Now static, if
5909 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5910 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5911
5912 * alloc.c (refill_memory_reserve): Now static if
5913 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5914 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5915
e87b6180
PE
5916 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5917 Define only if USE_LUCID.
5918
ac64929e
PE
5919 * xrdb.c (x_customization_string, x_rm_string): Now static.
5920
6f37259d
PE
5921 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5922 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5923
1683e3ab
PE
5924 * xdisp.c (draw_row_with_mouse_face): Now static.
5925 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5926
de9c2632
PE
5927 * window.h (check_all_windows): Mark externally visible.
5928
2b96acb7
PE
5929 * window.c (window_deletion_count): Now static.
5930
5931 * undo.c: Make symbols static if they're not exported.
5932 (last_undo_buffer, last_boundary_position, pending_boundary):
5933 Now static.
5934
50436f33
PE
5935 * textprop.c (interval_insert_behind_hooks): Now static.
5936 (interval_insert_in_front_hooks): Likewise.
5937
64520e5c
PE
5938 * term.c: Make symbols static if they're not exported.
5939 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5940 (max_frame_lines, tty_set_terminal_modes):
5941 (tty_reset_terminal_modes, tty_turn_off_highlight):
5942 (get_tty_terminal): Now static.
5943 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5944 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5945 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5946 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5947 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5948
1fa53021
PE
5949 * sysdep.c: Make symbols static if they're not exported.
5950 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5951 Now static.
5952 (sigprocmask_set, full_mask): Remove; unused.
5953 (wait_debugging): Mark as visible.
5954 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5955 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5956
d4b43b22
PE
5957 * syntax.c (syntax_temp): Define only if !__GNUC__.
5958
b7c513d0
PE
5959 * sound.c (current_sound_device, current_sound): Now static.
5960
989b29ad
PE
5961 * search.c (searchbufs, searchbuf_head): Now static.
5962
13a55a78
PE
5963 * scroll.c (scroll_cost): Remove; unused.
5964 * dispextern.h (scroll_cost): Remove decl.
5965
de68a1fc
PE
5966 * region-cache.h (pp_cache): Mark as externally visible.
5967
40ccffa6
PE
5968 * process.c: Make symbols static if they're not exported.
5969 (process_tick, update_tick, create_process, chan_process):
5970 (Vprocess_alist, proc_buffered_char, datagram_access):
5971 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5972 (deactivate_process): Mark defn as static, as well as decl.
5973 * lisp.h (create_process): Remove decl.
5974 * process.h (chan_process, Vprocess_alist): Remove decls.
5975
ad64fc97
PE
5976 * print.c: Make symbols static if they're not exported.
5977 (print_depth, new_backquote_output, being_printed, print_buffer):
5978 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5979 (print_interval, print_number_index, initial_stderr_stream):
5980 Now static.
5981 * lisp.h (Fprinc): Remove decl.
5982 (debug_output_compilation_hack): Mark as externally visible.
5983
adddb265
PE
5984 * sysdep.c (croak): Move decl from here to syssignal.h.
5985 * syssignal.h (croak): Put it here, so the API can be checked when
5986 'croak' is called from dissociate_if_controlling_tty.
5987
1717ede2
PE
5988 * minibuf.c: Make symbols static if they're not exported.
5989 (minibuf_save_list, choose_minibuf_frame): Now static.
5990 * lisp.h (choose_minibuf_frame): Remove decl.
5991
fa5fb2bc
PE
5992 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5993
1e3890d1
PE
5994 * lread.c: Make symbols static if they're not exported.
5995 (read_objects, initial_obarray, oblookup_last_bucket_number):
5996 Now static.
5997 (make_symbol): Remove; unused.
5998 * lisp.h (initial_obarray, make_symbol): Remove decls.
5999
8a1414fa
PE
6000 * keyboard.c: Make symbols static if they're not exported.
6001 (single_kboard, recent_keys_index, total_keys, recent_keys):
6002 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6003 (this_single_command_key_start, echoing, last_auto_save):
6004 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6005 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6006 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6007 (Vlispy_mouse_stem, double_click_count):
6008 Now static.
6009 (force_auto_save_soon): Define only if SIGDANGER.
6010 (ignore_mouse_drag_p): Now static if
6011 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6012 (print_help): Remove; unused.
6013 (stop_character, last_timer_event): Mark as externally visible.
6014 * keyboard.h (ignore_mouse_drag_p): Declare only if
6015 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6016 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6017 * lisp.h (echoing): Remove decl.
6018 (force_auto_save_soon): Declare only if SIGDANGER.
6019 * xdisp.c (redisplay_window): Simplify code, to make it more
6020 obvious that ignore_mouse_drag_p is not accessed if !defined
6021 USE_GTK && !defined HAVE_NS.
6022
93ea6e8f
PE
6023 * intervals.c: Make symbols static if they're not exported.
6024 (merge_properties_sticky, merge_interval_right, delete_interval):
6025 Now static.
6026 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6027
77382fcc
PE
6028 * insdel.c: Make symbols static if they're not exported.
6029 However, leave prepare_to_modify_buffer alone. It's never
6030 called from outside this function, but that appears to be a bug.
6031 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6032 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6033 (adjust_after_replace_noundo): Remove; unused.
6034 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6035 (signal_before_change): Remove decls.
77382fcc 6036
9306c32e
PE
6037 * indent.c (val_compute_motion, val_vmotion): Now static.
6038
cd44d2eb
PE
6039 * image.c: Make symbols static if they're not exported.
6040 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6041 if USE_GTK.
6042 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6043 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6044
ad9a7a06
PE
6045 * fringe.c (standard_bitmaps): Now static.
6046 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6047
81626931
PE
6048 * frame.c: Make symbols static if they're not exported.
6049 (x_report_frame_params, make_terminal_frame): Now static.
6050 (get_frame_param): Now static, unless HAVE_NS.
6051 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6052 (x_get_resource_string): Remove; not used.
6053 * frame.h (make_terminal_frame, x_report_frame_params):
6054 (x_get_resource_string); Remove decls.
6055 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6056 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6057
239f9db9
PE
6058 * font.c, fontset.c: Make symbols static if they're not exported.
6059 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6060 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6061 * font.c (font_close_object): Now static.
6062 * font.h (font_close_object): Remove.
6063 * fontset.c (FONTSET_OBJLIST): Remove.
6064 (free_realized_fontset) #if-0 the body, which does nothing.
6065 (face_suitable_for_char_p): #if-0, as it's never called.
6066 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6067 * xfaces.c (face_at_string_position):
6068 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6069 since 0 is always ASCII.
6070
dfcf3579
PE
6071 * fns.c (weak_hash_tables): Now static.
6072
5045092b
PE
6073 * fileio.c: Make symbols static if they're not exported.
6074 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6075 (Vwrite_region_annotation_buffers): Now static.
6076
57a96f5c
PE
6077 * eval.c: Make symbols static if they're not exported.
6078 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6079 * lisp.h (backtrace_list): Remove decl.
6080
35f08c38
PE
6081 * emacs.c: Make symbols static if they're not exported.
6082 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6083 (fatal_error_code, fatal_error_signal_hook, standard_args):
6084 Now static.
6085 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6086 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6087 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6088 * lisp.h (fatal_error_signal_hook): Remove decl.
6089 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6090
f44bd759
PE
6091 * editfns.c: Move a (normally-unused) function to its only use.
6092 * editfns.c, lisp.h (get_operating_system_release): Remove.
6093 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6094 worth the hassle of breaking this out.
6095
b532497d
PE
6096 * xterm.c: Make symbols static if they're not exported.
6097 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6098 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6099 (x_destroy_window, x_delete_display):
6100 Now static.
6101 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6102 (x_mouse_leave): Remove; unused.
6103 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6104 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6105 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6106 Remove decls.
6107 (x_mouse_leave): Declare only if WINDOWSNT.
6108 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6109 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6110 USE_X_TOOLKIT.
6111
1675728f
PE
6112 * ftxfont.c: Make symbols static if they're not exported.
6113 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6114 HAVE_FREETYPE.
6115 * font.h (ftxfont_driver): Likewise.
6116
e4cebfca
PE
6117 * xfns.c: Make symbols static if they're not exported.
6118 (x_last_font_name, x_display_info_for_name):
6119 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6120 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6121 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6122 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6123 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6124 (last_show_tip_args): Now static.
6125 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6126 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6127 (x_screen_planes): Remove; unused.
6128 * dispextern.h (x_screen_planes): Remove decl.
6129
5bf46f05
PE
6130 * dispnew.c: Make symbols static if they're not exported.
6131 * dispextern.h (redraw_garbaged_frames, scrolling):
6132 (increment_row_positions): Remove.
6133 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6134 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6135 Now static.
6136 (redraw_garbaged_frames): Remove; unused.
6137
435f4c28
PE
6138 * xfaces.c: Make symbols static if they're not exported.
6139 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6140 Remove decls.
6141 * xterm.h (defined_color): Remove decls.
6142 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6143 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6144 (menu_face_changed_default, defined_color, free_realized_face):
6145 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6146 (ascii_face_of_lisp_face): Remove; unused.
6147
8524aef3
PE
6148 * xdisp.c: Make symbols static if they're not exported.
6149 * dispextern.h (scratch_glyph_row, window_box_edges):
6150 (glyph_to_pixel_coords, set_cursor_from_row):
6151 (get_next_display_element, set_iterator_to_next):
6152 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6153 (show_mouse_face): Remove decls
6154 * frame.h (message_buf_print): Likewise.
6155 * lisp.h (pop_message, set_message, check_point_in_composition):
6156 Likewise.
6157 * xterm.h (set_vertical_scroll_bar): Likewise.
6158 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6159 (message_buf_print, scratch_glyph_row, displayed_buffer):
6160 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6161 (get_next_display_element, show_mouse_face, window_box_edges):
6162 (frame_to_window_pixel_xy, check_point_in_composition):
6163 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6164 (glyph_to_pixel_coords): Remove; unused.
6165
16390cd2
PE
6166 * dired.c (file_name_completion): Now static.
6167
6168 * dbusbind.c (xd_in_read_queued_messages): Now static.
6169
a25f4dfa
PE
6170 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6171 * data.c (circular_list_error): Remove.
6172
14a9c8df
PE
6173 * commands.h (last_point_position, last_point_position_buffer):
6174 (last_point_position_window): Remove decls.
6175 * keyboard.c: Make these variables static.
6176
04f2d78b
CB
6177 * coding.h (coding, code_convert_region, encode_coding_gap):
6178 Remove decls.
74ab6df5
PE
6179 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6180 (iso_code_class, detect_coding, code_convert_region): Now static.
6181 (encode_coding_gap): Remove; unused.
6182
38dfbee1
PE
6183 * chartab.c (chartab_chars, chartab_bits): Now static.
6184
a2cb4e63
PE
6185 * charset.h (charset_iso_8859_1): Remove decl.
6186 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6187 Now static.
6188
127198fd
PE
6189 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6190 * ccl.c (Vccl_program_table): Now static.
6191 (check_ccl_update): Remove; unused.
6192
d85b608f
PE
6193 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6194 * category.h: ... from here.
6195 * category.c (check_category_table, set_category_set): Now static.
6196
31cd66f3
PE
6197 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6198 * lisp.h: Remove these decls.
6199
c358e587
PE
6200 * buffer.c (buffer_count): Remove unused var.
6201
e78aecca
PE
6202 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6203 so that it's not optimized away.
6204 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6205 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6206 exported only to the debugger.
6207
e192d7d3 6208 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6209 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6210
92470028
PE
6211 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6212 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6213 was inaccessible from Lisp.
6214 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6215 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6216
244ed907
PE
6217 alloc.c: Import and export fewer symbols, and remove unused items.
6218 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6219 is defined.
6220 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6221 it's not optimized away by whole-program optimization.
6222 (message_enable_multibyte, free_misc): Remove.
6223 (catchlist, handlerlist, mark_backtrace):
6224 Declare only if BYTE_MARK_STACK.
6225 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6226 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6227 (message_enable_multibyte): Remove decl.
6228 (free_misc, interval_free_list, float_block, float_block_index):
6229 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6230 (cons_free_list, last_marked_index):
6231 Now static.
6232 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6233 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6234 (mark_backtrace): Define only if BYTE_MARK_STACK.
6235 * xdisp.c (message_enable_multibyte): Now static.
6236
61c2b50e 6237 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6238 This makes it easier for human readers (and static analyzers)
6239 to see whether these variables are used from other modules.
6240 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6241 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6242 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6243 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6244 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6245 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6246 * xmenu.c, xselect.c:
6247 Declare Q* vars static if they are not used in other modules.
6248 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6249 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6250 Remove decls of unexported vars.
6251 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6252
95c82688
PE
6253 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6254
16a97296
PE
6255 Make Emacs functions such as Fatom 'static' by default.
6256 This makes it easier for human readers (and static analyzers)
6257 to see whether these functions can be called from other modules.
6258 DEFUN now defines a static function. To make the function external
6259 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6260 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6261 (Finit_image_library):
16a97296
PE
6262 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6263 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6264 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6265 Remove decls, since these functions are now static.
6266 (Funintern, Fget_internal_run_time): New decls, since these functions
6267 were already external.
95c82688 6268
16a97296
PE
6269 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6270 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6271 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6272 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6273 * keyboard.c, keymap.c, lread.c:
6274 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6275 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6276 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6277 Mark functions with DEFUE instead of DEFUN,
6278 if they are used in other modules.
6279 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6280 decls for now-static functions.
6281 * buffer.h (Fdelete_overlay): Remove decl.
6282 * callproc.c (Fgetenv_internal): Mark as internal.
6283 * composite.c (Fremove_list_of_text_properties): Remove decl.
6284 (Fcomposition_get_gstring): New forward static decl.
6285 * composite.h (Fcomposite_get_gstring): Remove decl.
6286 * dired.c (Ffile_attributes): New forward static decl.
6287 * doc.c (Fdocumntation_property): New forward static decl.
6288 * eval.c (Ffetch_bytecode): New forward static decl.
6289 (Funintern): Remove extern decl; now in .h file where it belongs.
6290 * fileio.c (Fmake_symbolic_link): New forward static decl.
6291 * image.c (Finit_image_library): New forward static decl.
6292 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6293 * intervals.h (Fprevious_property_change):
6294 (Fremove_list_of_text_properties): Remove decls.
6295 * keyboard.c (Fthis_command_keys): Remove decl.
6296 (Fcommand_execute): New forward static decl.
6297 * keymap.c (Flookup_key): New forward static decl.
6298 (Fcopy_keymap): Now static.
6299 * keymap.h (Flookup_key): Remove decl.
6300 * process.c (Fget_process): New forward static decl.
6301 (Fprocess_datagram_address): Mark as internal.
6302 * syntax.c (Fsyntax_table_p): New forward static decl.
6303 (skip_chars): Remove duplicate decl.
6304 * textprop.c (Fprevious_property_change): New forward static decl.
6305 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6306 Now internal.
6307 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6308 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6309
785bbd42
PE
6310 * editfns.c (Fformat): Remove unreachable code.
6311
8b913b57
AS
63122011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6313
6314 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6315 change. (Bug#8496)
6316
a6744a35
EZ
63172011-04-13 Eli Zaretskii <eliz@gnu.org>
6318
6319 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6320 when at ZV. (Bug#8487)
6321
e7974947
AS
63222011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6323
baad03f0
AS
6324 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6325 (Bug#8437)
6326 * keyboard.c (parse_tool_bar_item): Likewise.
6327 * sound.c (sound_cleanup, alsa_close): Likewise.
6328 * termcap.c (tgetent): Likewise.
6329 * xfns.c (x_default_font_parameter): Likewise.
6330 * xsettings.c (read_and_apply_settings): Likewise.
6331
e7974947
AS
6332 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6333 (overrun_check_free): Protoize.
6334
28272684
PE
63352011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6336
6337 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6338 since callers should never pass a negative size.
6339 Change the signature to match that of plain 'read' and 'write'; see
6340 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6341 * lisp.h: Update prototypes of emacs_write and emacs_read.
6342
11997c76
EZ
63432011-04-11 Eli Zaretskii <eliz@gnu.org>
6344
6345 * xdisp.c (redisplay_window): Don't try to determine the character
6346 position of the scroll margin if the window start point w->startp
e896f03c 6347 is outside the buffer's accessible region. (Bug#8468)
11997c76 6348
8a2cbd72
EZ
63492011-04-10 Eli Zaretskii <eliz@gnu.org>
6350
6351 Fix write-region and its subroutines for buffers > 2GB.
6352 * fileio.c (a_write, e_write): Modify declaration of arguments and
6353 local variables to support buffers larger than 2GB.
6354 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6355
6356 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6357 argument, local variables, and return value.
6358
6359 * lisp.h: Update prototypes of emacs_write and emacs_read.
6360
6361 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6362
4073e537 63632011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6364
1ebfdcb6
PE
6365 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6366
b2ded58d
PE
6367 Fix more problems found by GCC 4.6.0's static checks.
6368
7d66342c
PE
6369 * xdisp.c (vmessage): Use a better test for character truncation.
6370
bbf47d44
PE
6371 * charset.c (load_charset_map): <, not <=, for optimization,
6372 and to avoid potential problems with integer overflow.
9248994d 6373 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6374 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6375 * editfns.c (Fformat): Likewise.
1e69125e 6376 * syntax.c (skip_chars): Likewise.
3befa583 6377
e3019616
PE
6378 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6379 This also lets GCC 4.6.0 generate slightly better loop code.
6380
becfa255
PE
6381 * callint.c (Fcall_interactively): <, not <=, for optimization.
6382 (Fcall_interactively): Count the number of arguments produced,
6383 not the number of arguments given. This is simpler and lets GCC
6384 4.6.0 generate slightly better code.
6385
dae0cd48
PE
6386 * ftfont.c: Distingish more carefully between FcChar8 and char.
6387 The previous code passed unsigned char * to a functions like
6388 strlen and xstrcasecmp that expect char *, which does not
6389 conform to the C standard.
6390 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6391 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6392 char * when the C standard requires it.
6393
76032d70
PE
6394 * keyboard.c (read_char): Remove unused var.
6395
eb3f1cc8
PE
6396 * eval.c: Port to Windows vsnprintf (Bug#8435).
6397 Include <limits.h>.
6398 (SIZE_MAX): Define if the headers do not.
6399 (verror): Do not give up if vsnprintf returns a negative count.
6400 Instead, grow the buffer. This ports to Windows vsnprintf, which
6401 does not conform to C99. Problem reported by Eli Zaretskii.
6402 Also, simplify the allocation scheme, by avoiding the need for
6403 calling realloc, and removing the ALLOCATED variable.
6404
70476b54
PE
6405 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6406
12020a9e
PE
6407 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6408 But keep the doprint source code for now, as we might revamp it
6409 and use it again (Bug#8435).
ea6c7ae6
PE
6410 * lisp.h (doprnt): Remove.
6411 * Makefile.in (base_obj): Remove doprnt.o.
6412 * deps.mk (doprnt.o): Remove.
6413
5fdb398c
PE
6414 error: Print 32- and 64-bit integers portably (Bug#8435).
6415 Without this change, on typical 64-bit hosts error ("...%d...", N)
6416 was used to print both 32- and 64-bit integers N, which relied on
6417 undefined behavior.
6418 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6419 New macro.
6420 * lisp.h (error, verror): Mark as printf-like functions.
6421 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6422 Report overflow in size calculations when allocating printf buffer.
6423 Do not truncate output string at its first null byte.
6424 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6425 Truncate the output at a character boundary, since vsnprintf does not
6426 do that.
6427 * charset.c (check_iso_charset_parameter): Convert internal
6428 character to string before calling 'error', since %c now has the
6429 printf meaning.
6430 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6431 overflow when computing char to be passed to 'error'. Do not
6432 pass Lisp_Object to 'error'; pass the integer instead.
6433 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6434 formatted with plain %d.
6435
b189fa66
PE
6436 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6437
bff87ef0
PE
6438 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6439
7e2cac20
PE
6440 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6441
ce4d90b5
PE
6442 * xterm.c (x_catch_errors): Remove duplicate declaration.
6443
266c9547
PE
6444 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6445
79c49ad2
PE
6446 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6447
368f4090
JM
64482011-04-10 Jim Meyering <meyering@redhat.com>
6449
6450 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6451 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6452 return ssize_t not "int", and use size_t as the buffer length.
6453 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6454 * gnutls.h: Update declarations.
6455 * process.c (read_process_output): Use ssize_t, to match.
6456 (send_process): Likewise.
6457
a32d4040
CY
64582011-04-09 Chong Yidong <cyd@stupidchicken.com>
6459
6460 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6461
8546720e 64622011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6463
04f2d78b
CB
6464 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6465 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6466
8546720e
GM
6467 * xterm.c (handle_one_xevent):
6468 * xmenu.c (create_and_show_popup_menu):
6469 * xselect.c (x_decline_selection_request)
6470 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6471
0a2f5c1a 64722011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6473
6474 Fix some uses of `int' instead of EMACS_INT.
6475 * search.c (string_match_1, fast_string_match)
6476 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6477 (scan_buffer, find_next_newline_no_quit)
6478 (find_before_next_newline, search_command, Freplace_match)
6479 (Fmatch_data): Make some `int' variables be EMACS_INT.
6480
6481 * xdisp.c (display_count_lines): 3rd argument and return value now
6482 EMACS_INT. All callers changed.
6483 (pint2hrstr): Last argument is now EMACS_INT.
6484
6485 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6486 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6487 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6488 (decode_coding_utf_16, decode_coding_emacs_mule)
6489 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6490 (decode_coding_ccl, decode_coding_charset)
6491 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6492 (decode_coding_iso_2022, decode_coding_emacs_mule)
6493 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6494 <char_offset, last_offset>: Declare EMACS_INT.
6495 (encode_coding_utf_8, encode_coding_utf_16)
6496 (encode_coding_emacs_mule, encode_invocation_designation)
6497 (encode_designation_at_bol, encode_coding_iso_2022)
6498 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6499 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6500 Declare EMACS_INT.
6501 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6502 (encode_invocation_designation): Last argument P_NCHARS is now
6503 EMACS_INT.
6504 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6505 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6506
6507 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6508 All users changed.
6509
6510 * ccl.c (Fccl_execute_on_string): Declare some variables
6511 EMACS_INT.
6512
8546720e 65132011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6514
6515 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6516
4e19a977
CS
65172011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6518
6519 * process.c (Fformat_network_address): Doc fix.
6520
87302331
R
65212011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6522
6523 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6524
cbb59342
CY
65252011-04-08 Chong Yidong <cyd@stupidchicken.com>
6526
6527 * keyboard.c (read_char): Call Lisp function help-form-show,
6528 instead of using internal_with_output_to_temp_buffer.
6529 (Qhelp_form_show): New var.
e0d38eeb 6530 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6531
6532 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6533
6534 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6535
e67a13ab
CY
65362011-04-06 Chong Yidong <cyd@stupidchicken.com>
6537
04f2d78b
CB
6538 * process.c (Flist_processes): Remove to Lisp.
6539 (list_processes_1): Delete.
e67a13ab 6540
973f782d
EZ
65412011-04-06 Eli Zaretskii <eliz@gnu.org>
6542
7c106b1e
EZ
6543 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6544
973f782d
EZ
6545 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6546
41cf7d1a 65472011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6548
ca23cc88
PE
6549 Fix more problems found by GCC 4.6.0's static checks.
6550
f390e2d5
PE
6551 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6552
42eea0d0
PE
6553 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6554
b69769da 6555 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6556
f9541e84
PE
6557 * xdisp.c (vmessage): Mark as a printf-like function.
6558
13841b55
PE
6559 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6560
c136c10f
PE
6561 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6562
5e2d4a30
PE
6563 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6564 printf-like functions.
6565 (tiff_load): Add casts to remove these marks before passing them
6566 to system-supplied API.
6567
583f48b9
PE
6568 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6569
b25d760e
PE
6570 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6571 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6572 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6573 directly, rather than having caller test rule sign. This avoids
6574 some unnecessary tests.
6575 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6576 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6577 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6578
bc7b6697 6579 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6580 (xfont_open): Avoid unnecessary tests.
bc7b6697 6581
27ccc379
PE
6582 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6583
dcd5c89a
PE
6584 * composite.h, composite.c (composition_gstring_put_cache):
6585 Use EMACS_INT, not int, for length.
6586
b13a45c6
PE
6587 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6588 breaking out part of COMPOSITION_DECODE_RULE.
6589 (COMPOSITION_DECODE_RULE): Use it.
6590 * composite.c (get_composition_id): Remove unused local vars,
6591 by using the new macro.
6592
1e792e4d
PE
6593 * textprop.c (set_text_properties_1): Change while to do-while,
6594 since the condition is always true at first.
6595
dc6c6455 6596 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6597 (interval_deletion_adjustment): Return unsigned value.
6598 All uses changed.
dc6c6455 6599
aba7731a
PE
6600 * process.c (list_processes_1, create_pty, read_process_output):
6601 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6602 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6603 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6604 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6605 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6606
fdfc4bf3
PE
6607 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6608
fca8fe46 6609 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6610 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6611
06a0259a 6612 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6613 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6614 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6615
e7b9e80f
PE
6616 * print.c (print_error_message): Avoid int overflow.
6617
56201685
PE
6618 * font.c (font_list_entities): Redo for clarity,
6619 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6620
78834453 6621 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6622 (font_score): Avoid potential overflow in diff calculation.
78834453 6623
0bc0b309 6624 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6625 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6626
e610eaca
PE
6627 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6628
b895abce
PE
6629 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6630 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6631 can always succeed if overflow has undefined behavior.
6632
1f1d9321 6633 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6634 (wordify): Omit three unnecessary tests.
1f1d9321 6635
c59478bc
PE
6636 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6637 All callers changed. This avoids the need for an unused var.
6638
79b73827
PE
6639 * casefiddle.c (casify_region): Remove var that is set but not used.
6640
a4db5dfe
PE
6641 * dired.c (file_name_completion): Remove var that is set but not used.
6642
43aae36e
PE
6643 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6644
2a47c44d 6645 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6646 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6647
a37c69bf
PE
6648 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6649 Check for integer overflow on size calculations.
6650
328ab8e7
PE
6651 * buffer.c (Fprevious_overlay_change): Remove var that is set
6652 but not used.
6653
e5a2a5cb
PE
6654 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6655 Remove vars that are set but not used.
8d84a6eb 6656 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6657 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6658
a60e5f68
PE
6659 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6660
f661cb61 6661 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6662 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6663
f0397f5a
PE
6664 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6665 that are set but not used.
6666
8664db06 6667 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6668 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6669
6abdaa4a
PE
6670 * xselect.c (x_get_local_selection, x_handle_property_notify):
6671 Remove vars that are set but not used.
6672
0ce7538d 6673 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6674 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6675
9ae848fc
PE
6676 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6677 Remove var that is set but not used.
0b918413
PE
6678 (scroll_bar_windows_size): Now size_t, not int.
6679 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6680 Check for overflow.
9ae848fc 6681
a5a62657
PE
6682 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6683 (map_tty_color) [!defined MSDOS]: Likewise.
6684
5c5cdd39
PE
6685 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6686
66ebf983
PE
6687 * coding.c: Remove vars that are set but not used.
6688 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6689 All callers changed.
6690 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6691 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6692 (decode_coding_charset): Remove vars that are set but not used.
6693
1be4d761
PE
6694 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6695 that is set but not used.
6696
47553fa8
PE
6697 * print.c (print_object): Remove var that is set but not used.
6698
1f7196bf 6699 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6700 The gnulib version avoids calling malloc in the usual case,
6701 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6702 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6703 * filelock.c (current_lock_owner): Likewise.
6704 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6705 * sysdep.c: Include allocator.h, careadlinkat.h.
6706 (emacs_no_realloc_allocator): New static constant.
6707 (emacs_readlink): New function.
fdb61804
PE
6708 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6709 ../lib/careadlinkat.h.
d1fdcab7 6710
f84c17c7
SM
67112011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6712
6713 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6714 first non-nil return value).
6715
ef3862ad
JD
67162011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6717
6718 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6719 if not defined (Bug#8403).
6720
376a7006
JB
67212011-04-02 Juanma Barranquero <lekktu@gmail.com>
6722
6723 * xdisp.c (display_count_lines): Remove parameter `start',
6724 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6725 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6726 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6727 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6728 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6729 and thereabouts. All callers changed.
6730 (get_per_char_metric): Remove parameter `f', unused since
6731 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6732
6ca3801d
JM
67332011-04-02 Jim Meyering <meyering@redhat.com>
6734
6735 do not dereference NULL upon failed strdup
6736 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6737 (ns_get_family): Likewise.
6738
d8e2b5ba
JB
67392011-04-02 Juanma Barranquero <lekktu@gmail.com>
6740
6741 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6742
8c74fcbd
JD
67432011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6744
6745 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6746 later (Bug#8403).
6747
7200d79c
SM
67482011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6749
03408648 6750 Add lexical binding.
7200d79c 6751
03408648
SM
6752 * window.c (Ftemp_output_buffer_show): New fun.
6753 (Fsave_window_excursion):
6754 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6755
6756 * lread.c (lisp_file_lexically_bound_p): New function.
6757 (Fload): Bind Qlexical_binding.
6758 (readevalloop): Remove `evalfun' arg.
6759 Bind Qinternal_interpreter_environment.
6760 (Feval_buffer): Bind Qlexical_binding.
6761 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6762 Mark as dynamic.
6763 (syms_of_lread): Declare `lexical-binding'.
6764
6765 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6766
6767 * keyboard.c (eval_dyn): New fun.
6768 (menu_item_eval_property): Use it.
ca105506
SM
6769
6770 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6771
03408648
SM
6772 * fns.c (concat, mapcar1): Accept byte-code-functions.
6773
6774 * eval.c (Fsetq): Handle lexical vars.
6775 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6776 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6777 (FletX, Flet): Obey lexical binding.
6778 (Fcommandp): Handle closures.
6779 (Feval): New `lexical' arg.
6780 (eval_sub): New function extracted from Feval. Use it almost
6781 everywhere where Feval was used. Look up vars in lexical env.
6782 Handle closures.
6783 (Ffunctionp): Move from subr.el.
6784 (Ffuncall): Handle closures.
6785 (apply_lambda): Remove `eval_flags'.
6786 (funcall_lambda): Handle closures and new byte-code-functions.
6787 (Fspecial_variable_p): New function.
6788 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6789 but without exporting it to Lisp.
23aba0ea 6790
23aba0ea 6791 * doc.c (Fdocumentation, store_function_docstring):
03408648 6792 * data.c (Finteractive_form): Handle closures.
23aba0ea 6793
03408648
SM
6794 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6795 interactive spec.
ba83908c 6796
04f2d78b
CB
6797 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6798 New byte-codes.
03408648
SM
6799 (exec_byte_code): New function extracted from Fbyte_code to handle new
6800 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6801
03408648 6802 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6803
03408648 6804 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6805
e2abce01
JB
68062011-03-31 Juanma Barranquero <lekktu@gmail.com>
6807
6808 * xdisp.c (redisplay_internal): Fix prototype.
6809
63696a73 68102011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6811
63696a73 6812 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6813 (try_scrolling): Use it when setting scroll_limit.
6814 Limit scrolling to 100 screen lines.
63696a73
EZ
6815 (redisplay_window): Even when falling back on "recentering",
6816 position point in the window according to scroll-conservatively,
6817 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6818
6819 (try_scrolling): When point is above the window, allow searching
6820 as far as scroll_max, or one screenful, to compute vertical
6821 distance from PT to the scroll margin position. This prevents
6822 try_scrolling from unnecessarily failing when
6823 scroll-conservatively is set to a value slightly larger than the
6824 window height. Clean up the case of PT below the margin at bottom
6825 of window: scroll_max can no longer be INT_MAX. When aggressive
6826 scrolling is in use, don't let point enter the opposite scroll
6827 margin as result of the scroll.
6828 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6829 threshold of 100 lines for never-recentering scrolling.
6830
e4cc2dfc
JB
68312011-03-31 Juanma Barranquero <lekktu@gmail.com>
6832
6833 * dispextern.h (move_it_by_lines):
6834 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6835 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6836 (message_log_check_duplicate): Remove parameters `prev_bol' and
6837 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6838 (redisplay_internal): Remove parameter `preserve_echo_area',
6839 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6840
6841 * indent.c (Fvertical_motion):
6842 * window.c (window_scroll_pixel_based, Frecenter):
6843 Don't pass `need_y_p' to `move_it_by_lines'.
6844
1c470562
SM
68452011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6846
44f230aa
SM
6847 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6848 steal a few bits to be more compact.
6849 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6850 Remove unneeded casts.
6851
1c470562
SM
6852 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6853
888adce9
ZK
68542011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6855
6856 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6857 binding" message (bug#7967).
6858
f838ed7b
PE
68592011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6860
77861b95
PE
6861 Fix more problems found by GCC 4.6.0's static checks.
6862
de6dbc14
PE
6863 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6864 Remove unused local var.
6865
f838ed7b
PE
6866 * editfns.c (Fmessage_box): Remove unused local var.
6867
792c7b2b
PE
6868 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6869 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6870 Omit unused local vars.
c499e557 6871 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6872 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6873 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6874 Omit unused local var.
6875
ba0165e1
PE
6876 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6877 Don't assume string length fits in int.
32ad8845 6878 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6879 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6880
3c59b4c9
PE
6881 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6882 instead of alloca (Bug#8344).
6883
a3eed478 6884 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6885 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6886
eb4d412d
PE
6887 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6888
1658b401
PE
6889 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6890 concerns.
6891
6892 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6893
6894 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6895
9a2c6e05
PE
6896 * keyboard.c (syms_of_keyboard): Use the same style as later
6897 in this function when indexing through an array. This also
6898 works around GCC bug 48267.
6899
03d0a109
PE
6900 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6901
44f730c8
PE
6902 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6903
fe75f926
PE
6904 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6905 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6906
ffa8c828
PE
6907 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6908 This avoids undefined behavior on integer overflow, and is a bit
6909 more convenient anyway since it is compared to a size_t variable.
6910
c5101a77
PE
6911 Variadic C functions now count arguments with size_t, not int.
6912 This avoids an unnecessary limitation on 64-bit machines, which
6913 caused (substring ...) to crash on large vectors (Bug#8344).
6914 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6915 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6916 All variadic functions and their callers changed accordingly.
c5101a77
PE
6917 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6918 * data.c (arith_driver, float_arith_driver): Likewise.
6919 * editfns.c (general_insert_function): Likewise.
6920 * eval.c (struct backtrace.nargs, interactive_p)
6921 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6922 (funcall_lambda, mark_backtrace): Likewise.
6923 * fns.c (concat): Likewise.
6924 * frame.c (x_set_frame_parameters): Likewise.
6925 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6926 0 if not found, not -1. All callers changed.
6927
dd3f25f7
PE
6928 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6929 (stack_copy_size): Now size_t, not int.
6930 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6931
461c2ab9
JB
69322011-03-28 Juanma Barranquero <lekktu@gmail.com>
6933
6934 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6935 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6936 All callers changed.
6937
6938 * lisp.h (multibyte_char_to_unibyte):
6939 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6940 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6941 * character.h (CHAR_TO_BYTE8):
6942 * cmds.c (internal_self_insert):
6943 * editfns.c (general_insert_function):
6944 * keymap.c (push_key_description):
6945 * search.c (Freplace_match):
6946 * xdisp.c (message_dolog, set_message_1): All callers changed.
6947
f6d62986
SM
69482011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6949
6950 * keyboard.c (safe_run_hook_funcall): New function.
6951 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6952 don't set the hook to nil, but remove the offending function instead.
6953 (Qcommand_hook_internal): Remove, unused.
6954 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6955 Vcommand_hook_internal.
6956
6957 * eval.c (enum run_hooks_condition): Remove.
6958 (funcall_nil, funcall_not): New functions.
6959 (run_hook_with_args): Call each function through a `funcall' argument.
6960 Remove `cond' argument, now redundant.
6961 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6962 (Frun_hook_with_args_until_failure): Adjust accordingly.
6963 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6964
1db5b1ad
JB
69652011-03-28 Juanma Barranquero <lekktu@gmail.com>
6966
6967 * dispextern.h (string_buffer_position): Remove declaration.
6968
6969 * print.c (strout): Remove parameter `multibyte', unused since
6970 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6971
6972 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6973 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6974 All callers changed.
6975
6976 * w32.c (_wsa_errlist): Use braces for struct initializers.
6977
6978 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6979 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6980 All callers changed.
6981 (string_buffer_position): Likewise. Also, make static (it's never
6982 used outside xdisp.c).
6983 (cursor_row_p): Remove parameter `w', unused since
6984 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6985 (decode_mode_spec): Remove parameter `precision', introduced during
6986 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6987 All callers changed.
6988
5ffb62aa
JD
69892011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6990
6991 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6992
461c2ab9 69932011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6994
6995 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6996 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6997 (ns_update_auto_hide_menu_bar): New functions.
6998 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6999 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7000 ns_constrain_all_frames.
7001 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7002 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7003
5c380ffb
JD
70042011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7005
7006 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7007
9af30bdf
GM
70082011-03-27 Glenn Morris <rgm@gnu.org>
7009
7010 * syssignal.h: Replace RETSIGTYPE with void.
7011 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7012 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7013 Replace SIGTYPE with void everywhere.
7014 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7015 * s/template.h (SIGTYPE): Remove commented out definition.
7016
e2abce01
JB
70172011-03-26 Eli Zaretskii <eliz@gnu.org>
7018
7019 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7020 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7021
f868cd8a
JB
70222011-03-26 Juanma Barranquero <lekktu@gmail.com>
7023
59eb0929
JB
7024 * w32.c (read_unc_volume): Use parameter `henum', instead of
7025 global variable `wget_enum_handle'.
7026
7027 * keymap.c (describe_vector): Remove parameters `indices' and
7028 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7029 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7030
f868cd8a
JB
7031 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7032
7033 * keyboard.c (timer_check): Remove parameter `do_it_now',
7034 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7035 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7036 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7037
7038 * keyboard.c (read_char):
7039 * w32menu.c (w32_menu_display_help):
7040 * xmenu.c (show_help_event, menu_help_callback):
7041 Adjust calls to `show_help_echo'.
7042
7043 * gtkutil.c (xg_maybe_add_timer):
7044 * keyboard.c (readable_events):
7045 * process.c (wait_reading_process_output):
7046 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7047
7048 * insdel.c (adjust_markers_gap_motion):
7049 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7050 (gap_left, gap_right): Don't call it.
7051
2ecf6fdb
CY
70522011-03-25 Chong Yidong <cyd@stupidchicken.com>
7053
7054 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7055 incurred during fontification.
7056
6b1f9ba4
JB
70572011-03-25 Juanma Barranquero <lekktu@gmail.com>
7058
7059 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7060 (DEFVAR_PER_BUFFER): Don't pass it.
7061
7062 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7063 (scrolling_window): Don't pass it.
7064
0f4a96b5
JB
70652011-03-25 Juanma Barranquero <lekktu@gmail.com>
7066
7067 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7068
7069 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7070 and `suffix'.
7071 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7072 of variables specific to SELinux and computation of `encoded_absname'.
7073
7074 * image.c (XPutPixel): Remove unused variable `height'.
7075
7076 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7077
7078 * unexw32.c (get_section_info): Remove unused variable `section'.
7079
7080 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7081 (system_process_attributes): Remove unused variable `sess'.
7082 (sys_read): Remove unused variable `err'.
7083
7084 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7085 (w32_wnd_proc): Remove unused variable `isdead'.
7086 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7087 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7088 (x_create_tip_frame): Remove unused variable `tem'.
7089
7090 * w32inevt.c (w32_console_read_socket):
7091 Remove unused variable `no_events'.
7092
7093 * w32term.c (x_draw_composite_glyph_string_foreground):
7094 Remove unused variable `width'.
7095
1149507c
JB
70962011-03-24 Juanma Barranquero <lekktu@gmail.com>
7097
7098 * w32term.c (x_set_glyph_string_clipping):
7099 Don't pass uninitialized region to CombineRgn.
7100
9c88f339
JB
71012011-03-23 Juanma Barranquero <lekktu@gmail.com>
7102
7103 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7104 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7105 (Fx_close_connection): Remove unused variable `i'.
7106
7107 * w32font.c (w32font_draw): Return number of glyphs.
7108 (w32font_open_internal): Remove unused variable `i'.
7109 (w32font_driver): Add missing initializer.
7110
7111 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7112 (fill_in_menu): Remove unused variable `items_added'.
7113
7114 * w32term.c (last_mouse_press_frame): Remove static global variable.
7115 (w32_clip_to_row): Remove unused variable `f'.
7116 (x_delete_terminal): Remove unused variable `i'.
7117
7118 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7119 (NOTHING): Remove unused static global variable.
7120 (uniscribe_check_otf): Remove unused variable `table'.
7121 (uniscribe_font_driver): Add missing initializers.
7122
dee091a3
JD
71232011-03-23 Julien Danjou <julien@danjou.info>
7124
7125 * term.c (Fsuspend_tty, Fresume_tty):
7126 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7127 * window.c (temp_output_buffer_show):
7128 * insdel.c (signal_before_change):
7129 * frame.c (Fhandle_switch_frame):
7130 * fileio.c (Fdo_auto_save):
7131 * emacs.c (Fkill_emacs):
7132 * editfns.c (save_excursion_restore):
7133 * cmds.c (internal_self_insert):
7134 * callint.c (Fcall_interactively):
7135 * buffer.c (Fkill_all_local_variables):
7136 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7137 Use Frun_hooks.
0f4a96b5 7138 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7139 unconditionnaly since it does the check itself.
7140
2c520ab5 71412011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7142
c9c49752
PE
7143 Fix more problems found by GCC 4.5.2's static checks.
7144
8abc3f12
PE
7145 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7146 the first time through the loop, since we know p0 < p1 then.
7147 This also avoids a gcc -Wstrict-overflow warning.
7148
a2d26660
PE
7149 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7150 leading to a memory leak, possible in functions like
7151 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7152 of objects (Bug#8318).
a2d26660 7153
916c72e9
PE
7154 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7155 that could (at least in theory) be that large.
7156
19ab8a18
PE
7157 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7158 This is less likely to overflow, and avoids undefined behavior if
7159 overflow does occur. All callers changed. Use strtoul to scan
7160 for the unsigned long integer.
b7cbbd6f
PE
7161 (pint2hrstr): Simplify and tune code slightly.
7162 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7163
f0641eff
PE
7164 * scroll.c (do_scrolling): Work around GCC bug 48228.
7165 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7166
7f650bb9
PE
7167 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7168 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7169 (validate_x_resource_name): Simplify count usage.
7170 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7171
37dd57d1
PE
7172 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7173 fail (Bug#8306).
81e56e61 7174
699979fc 7175 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7176
401bf9b4
PE
7177 * process.c (Fmake_network_process): Use socklen_t, not int,
7178 where POSIX says socklen_t is required in portable programs.
7179 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7180 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7181 (Fmake_network_process, server_accept_connection):
7182 (wait_reading_process_output, read_process_output):
7183 Likewise.
7184
b93aacde
PE
7185 * process.c: Rename or move locals to avoid shadowing.
7186 (list_processes_1, Fmake_network_process):
7187 (read_process_output_error_handler, exec_sentinel_error_handler):
7188 Rename or move locals.
4dc343ee 7189 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7190 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7191 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7192 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7193 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7194
af8a867c 7195 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7196 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7197 Include tparam.h instead, since it declares them.
af8a867c
PE
7198 * cm.h (PC): Remove extern decl; tparam.h now does this.
7199 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7200 * terminfo.c: Include tparam.h, to check interfaces.
7201 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7202 (tparam): Adjust signature to match interface in tparam.h;
7203 this removes some undefined behavior. Check that outstring and len
7204 are zero, which they always are with Emacs.
7205 * tparam.h (PC, BC, UP): New extern decls.
7206
0248044d 7207 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7208 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7209
8ff096c1 7210 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7211 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7212 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7213 (ftfont_list): Remove unused local.
49eaafba
PE
7214 (get_adstyle_property, ftfont_pattern_entity):
7215 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7216 Rename locals to avoid shadowing.
8ff096c1 7217
e2be39f6
PE
7218 * xfont.c (xfont_list_family): Mark var as initialized.
7219
c9735e30
PE
7220 * xml.c (make_dom): Now static.
7221
8f5201ae
PE
7222 * composite.c (composition_compute_stop_pos): Rename local to
7223 avoid shadowing.
b246f932
PE
7224 (composition_reseat_it): Remove unused locals.
7225 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7226 (composition_update_it): Mark var as initialized.
11b61122
PE
7227 (find_automatic_composition): Mark vars as initialized,
7228 with a FIXME (Bug#8290).
8f5201ae 7229
760fbc2c
PE
7230 character.h: Rename locals to avoid shadowing.
7231 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7232 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7233 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7234 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7235 to avoid shadowing.
7236
ff08eb85
PE
7237 * textprop.c (property_change_between_p): Remove; unused.
7238
fc7bf025
PE
7239 * intervals.c (interval_start_pos): Now static.
7240
235d7abc
PE
7241 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7242
44f230aa
SM
7243 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7244 Rename locals to avoid shadowing.
3e7d6594 7245
50060332
PE
7246 * sound.c (wav_play, au_play, Fplay_sound_internal):
7247 Fix pointer signedness.
d01f234b 7248 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7249 (wav_play): Initialize a variable to 0, to prevent undefined
7250 behavior (Bug#8278).
50060332 7251
c4fc4e30
PE
7252 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7253
918436ed
PE
7254 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7255
c939f91b
PE
7256 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7257 clobbering (Bug#8298).
b9c7f648
PE
7258 * sysdep.c (sys_subshell): Likewise.
7259 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7260
6bd8c144
PE
7261 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7262 This should get cleaned up, so that child_setup has the
7263 same signature on all platforms.
7264
7710357c 7265 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7266 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7267
c59da222
CY
72682011-03-22 Chong Yidong <cyd@stupidchicken.com>
7269
7270 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7271 not to be necessary, and produces flickering.
7272
66b87493
GM
72732011-03-20 Glenn Morris <rgm@gnu.org>
7274
7275 * config.in: Remove file.
7276
45b6f6d5
JB
72772011-03-20 Juanma Barranquero <lekktu@gmail.com>
7278
7279 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7280 are now in src/globals.h.
7281 (syms_of_minibuf): Remove spurious & from previous change.
7282
3ec03f7e
LL
72832011-03-20 Leo <sdl.web@gmail.com>
7284
7285 * minibuf.c (completing-read-function): New variable.
7286 (completing-read-default): Rename from completing-read.
7287 (completing-read): Call completing-read-function.
7288
b14e3e21
CY
72892011-03-19 Juanma Barranquero <lekktu@gmail.com>
7290
7291 * xfaces.c (Fx_load_color_file):
7292 Read color file from absolute filename (bug#8250).
7293
f2b726e6
JB
72942011-03-19 Juanma Barranquero <lekktu@gmail.com>
7295
7296 * makefile.w32-in: Update dependencies.
7297
09f6ff02
EZ
72982011-03-17 Eli Zaretskii <eliz@gnu.org>
7299
7300 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7301
29a6015a
PE
73022011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7303
a3a6c54e
PE
7304 Fix more problems found by GCC 4.5.2's static checks.
7305
b766f867
PE
7306 * process.c (make_serial_process_unwind, send_process_trap):
7307 (sigchld_handler): Now static.
7308
be02381c
PE
7309 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7310 That way, the code declares only the vars that it needs.
7311 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7312 * s/cygwin.h (PTY_ITERATION): Likewise.
7313 * s/darwin.h (PTY_ITERATION): Likewise.
7314 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7315
57048744
PE
7316 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7317 * process.c (allocate_pty): Don't declare stb unless it's needed.
7318
7914961c 7319 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7320 (CONSTANTLIM): Remove; unused.
7321 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7322 Define only if needed.
7914961c 7323
b3967b18
PE
7324 * unexelf.c (unexec): Name an expression,
7325 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7326 Use a different way to cause a compilation error if anyone uses
7327 n rather than nn, a way that does not involve shadowing.
73366a00 7328 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7329
29a6015a
PE
7330 * deps.mk (unexalpha.o): Remove; unused.
7331
43cfc33e 7332 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7333 * unexec.h: New file.
ce701a33
PE
7334 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7335 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7336 Depend on unexec.h.
7337 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7338 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7339 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7340 Change as necessary to match prototype in unexec.h.
ce701a33 7341
01f44d5a
PE
7342 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7343 shadowing.
4f63c6bb 7344 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7345
a6670b0b
PE
7346 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7347 Rename locals to avoid shadowing.
7348
cef2010d 7349 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7350 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7351
d4d7173a
PE
7352 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7353
f08b802a
PE
7354 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7355 warning when compiling print.c.
7356
3ddb0639
PE
7357 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7358 instead of using an uninitialized var.
5ad03b97 7359 (font_sort_entities): Mark var as initialized.
3ddb0639 7360
170a2692
PE
7361 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7362
e663c700
PE
7363 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7364 pointers to constants.
89bc529a 7365 (font_parse_fcname): Remove unused vars.
7b81e2d0 7366 (font_delete_unmatched): Now static.
ea838e10 7367 (font_get_spec): Remove; unused.
13a547c6
PE
7368 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7369 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7370 Rename or move locals to avoid shadowing.
e663c700 7371
2a80c887 7372 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7373 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7374
1384fa33 7375 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7376 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7377
8b2c52e9
PE
7378 * alloc.c (mark_backtrace): Move decl from here ...
7379 * lisp.h: ... to here, so that it can be checked.
7380
475545b5 7381 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7382 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7383 (lisp_indirect_variable): Name an expression,
7384 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7385 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7386
b1349114 7387 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7388 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7389 Use const pointer when appropriate.
b1349114 7390
a2928364
PE
7391 * lisp.h (get_system_name, get_operating_system_release):
7392 Move decls here, to check interfaces.
7393 * process.c (get_operating_system_release): Move decl to lisp.h.
7394 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7395 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7396 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7397 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7398 (Fformat_time_string, Fencode_time, Finsert_char):
7399 (Ftranslate_region_internal, Fformat):
7400 Rename or remove local vars to avoid shadowing.
9710023e 7401 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7402
a415e694
PE
7403 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7404 avoid shadowing.
7405
8ef4622d
PE
7406 * lisp.h (eassert): Check that the argument compiles, even if
7407 ENABLE_CHECKING is not defined.
7408
946f9a5b
PE
7409 * data.c (Findirect_variable): Name an expression, to avoid
7410 gcc -Wbad-function-cast warning.
112396d6 7411 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7412 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7413 (Fmake_variable_buffer_local, Fmake_local_variable):
7414 Mark variables as initialized.
52746918 7415 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7416
e5aab7e7 7417 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7418 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7419 Rename locals to avoid shadowing.
dff45157
PE
7420 (mark_stack): Move local variables into the #ifdef region where
7421 they're used.
7bc26fdb
PE
7422 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7423 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7424 needed otherwise.
7425 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7426 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7427 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7428
e5aab7e7
PE
7429 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7430 avoids undefined behavior in theory.
7431
4da60324
PE
7432 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7433
88043301
PE
7434 Use functions, not macros, for up- and down-casing (Bug#8254).
7435 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7436 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7437 to use the following functions instead of these macros.
7438 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7439 EMACS_INT, since callers assume the returned value fits in int.
7440 (upcase1): Likewise, for UPCASE_TABLE.
7441 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7442 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7443 the race-condition problem in the old DOWNCASE.
88043301 7444
19ed5445
PE
7445 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7446 Rename locals to avoid shadowing.
7447 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7448 (regex_compile, re_search_2, re_match_2_internal):
7449 Remove unused local vars.
952db0d7
PE
7450 (FREE_VAR): Rewrite so as not to use empty "else",
7451 which gcc can warn about.
da053e48 7452 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7453 (RETALLOC_IF): Define only if needed.
7454 (WORDCHAR_P): Likewise. This one is never needed, but is used
7455 only in a comment talking about a compiler bug, so put inside
7456 the #if 0 of that comment.
7457 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7458 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7459 Remove; unused.
19ed5445 7460
1f3561e4 7461 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7462 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7463 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7464
ded6f8f7
PE
7465 * search.c (simple_search): Remove unused var.
7466
dbd37a95
PE
7467 * dired.c (compile_pattern): Move decl from here ...
7468 * lisp.h: ... to here, so that it can be checked.
7469 (struct re_registers): New forward decl.
7470
7e47afad
PE
7471 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7472
85f24f61
PE
7473 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7474 All uses changed.
7475 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7476 Rename locals to avoid shadowing.
5671df8f 7477 (Fvertical_motion): Mark locals as initialized.
85f24f61 7478
181aa2be 7479 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7480 (casify_region): Mark local as initialized.
181aa2be 7481
930d429c
PE
7482 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7483
7082eac6
PE
7484 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7485 New macros, so that the caller can use some names other than
7486 gcpro1, gcpro2, etc.
7487 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7488 of the new macros.
7489 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7490 argument, for consistency with GCPRO2_VAR, etc: it is now the
7491 prefix of the variable, not the variable itself. All uses
7492 changed.
38b2c076
PE
7493 * dired.c (directory_files_internal, file_name_completion):
7494 Rename locals to avoid shadowing.
7495
15206ed9
PE
7496 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7497 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7498 dired.c's scmp function, had undefined behavior.
7499 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7500 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7501 * buffer.h: ... to here, because these macros use current_buffer,
7502 and the new implementation with inline functions needs to have
7503 current_buffer in scope now, rather than later when the macros
7504 are used.
7505 (downcase, upcase1): New static inline functions.
7506 (DOWNCASE, UPCASE1): Reimplement using these functions.
7507 This avoids undefined behavior in expressions like
7508 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7509 from race conditions in accessing the global variables
7510 case_temp1 and case_temp2.
7511 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7512 * lisp.h (case_temp1, case_temp2): Remove their decls.
7513 * character.h (ASCII_CHAR_P): Move from here ...
7514 * lisp.h: ... to here, so that the inline functions mentioned
7515 above can use them.
7516
4a6bea26
PE
7517 * dired.c (directory_files_internal_unwind): Now static.
7518
f14b7e14
PE
7519 * fileio.c (file_name_as_directory, directory_file_name):
7520 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7521 Now static.
2893f146
PE
7522 (file_name_as_directory): Use const pointers when appropriate.
7523 (Fexpand_file_name): Likewise. In particular, newdir might
7524 point at constant storage, so make it a const pointer.
fd4ead52 7525 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7526 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7527 signedness issues.
f839df0c
PE
7528 (Fset_file_times, Finsert_file_contents, auto_save_error):
7529 Rename locals to avoid shadowing.
f14b7e14 7530
5716756e 7531 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7532 (Ftry_completion, Fall_completions): Rename or remove locals
7533 to avoid shadowing.
5716756e 7534
b4c3046a
PE
7535 * marker.c (bytepos_to_charpos): Remove; unused.
7536
b45db522
PE
7537 * lisp.h (verify_bytepos, count_markers): New decls,
7538 so that gcc does not warn that these functions aren't declared.
7539
85876d07
PE
7540 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7541 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7542 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7543 (copy_text): Remove unused local var.
85876d07 7544
03d78a21 7545 * filelock.c (within_one_second): Now static.
b3dd38ab 7546 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7547
5df8f01b
PE
7548 * buffer.c (fix_overlays_before): Mark locals as initialized.
7549 (fix_start_end_in_overlays): Likewise. This function should be
7550 simplified by using pointers-to-pointers, but that's a different
7551 matter.
b1d876f1 7552 (switch_to_buffer_1): Now static.
8f54f30a
PE
7553 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7554 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7555
a70072c9 7556 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7557 Fix pointer signedness issue.
edced198
PE
7558 (sys_subshell): Mark local as volatile if checking for lint,
7559 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7560 (MAXPATHLEN): Define only if needed.
a70072c9 7561
a0977c44
PE
7562 * process.c (serial_open, serial_configure): Move decls from here ...
7563 * systty.h: ... to here, so that they can be checked.
7564
a884fdcc
PE
7565 * fns.c (get_random, seed_random): Move extern decls from here ...
7566 * lisp.h: ... to here, so that they can be checked.
7567
604efe86 7568 * sysdep.c (reset_io): Now static.
b8950c94 7569 (wait_for_termination_signal): Remove; unused.
604efe86 7570
38fc62d9
PE
7571 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7572 (copy_keymap_item, append_key, push_text_char_description):
7573 Now static.
1004a21a 7574 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7575 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7576 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7577 (describe_map_tree):
7578 Rename locals to avoid shadowing.
38fc62d9 7579
2f2650da
PE
7580 * keyboard.c: Declare functions static if they are not used elsewhere.
7581 (echo_char, echo_dash, cmd_error, top_level_2):
7582 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7583 (read_char, kbd_buffer_get_event, make_lispy_position):
7584 (make_lispy_event, make_lispy_movement, apply_modifiers):
7585 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7586 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7587 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7588 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7589 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7590
a053e86c 7591 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7592 (mark_kboards): Move decl here ...
7593 * alloc.c (mark_kboards): ... from here.
a053e86c 7594
4752793e
PE
7595 * lisp.h (force_auto_save_soon): New decl.
7596
74f10ca7 7597 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7598 (DEFINE_DUMMY_FUNCTION): New macro.
7599 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7600 Use it.
c03cd23f
PE
7601 (main): Add casts to avoid warnings
7602 if GCC considers string literals to be constants.
74f10ca7 7603
022e70d4
PE
7604 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7605
59d6fe83
PE
7606 * dbusbind.c: Pointer signedness fixes.
7607 (xd_signature, xd_append_arg, xd_initialize):
7608 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7609 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7610 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7611 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7612
78320123
PE
7613 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7614 if GCC considers string literals to be constants.
49cebcca 7615 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7616
35ac2a97
SM
76172011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7618
fb103ca9
SM
7619 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7620 (print_preprocess, print_object): New macro to fix last change.
7621
35ac2a97
SM
7622 * print.c (print_preprocess): Don't forget font objects.
7623
62973b41
JB
76242011-03-16 Juanma Barranquero <lekktu@gmail.com>
7625
7626 * emacs.c (USAGE3): Doc fixes.
7627
0e48bb22
AS
76282011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7629
7630 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7631 structure.
7632
7684e57b
JB
76332011-03-14 Juanma Barranquero <lekktu@gmail.com>
7634
7635 * lisp.h (VWindow_system, Qfile_name_history):
7636 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7637 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7638 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7639
7640 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7641 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7642
7643 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7644 * w32console.c (detect_input_pending, read_input_pending)
7645 (encode_terminal_code):
7646 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7647 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7648 (w32_system_caret_y, Qfile_name_history):
7649 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7650 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7651 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7652 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7653 * w32proc.c (Qlocal, report_file_error):
7654 * w32term.c (Vwindow_system, updating_frame):
7655 * w32uniscribe.c (initialized, uniscribe_font_driver):
7656 Remove unneeded extern declarations.
7657
2aa46d6c
CY
76582011-03-14 Chong Yidong <cyd@stupidchicken.com>
7659
c96bbc66 7660 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7661
cffc6f3b
CY
76622011-03-13 Chong Yidong <cyd@stupidchicken.com>
7663
7664 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7665 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7666 These macros can no longer be used for assignment.
7667
44f230aa
SM
7668 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7669 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7670 (record_buffer_markers, fetch_buffer_markers): New functions for
7671 recording and fetching special buffer markers.
7672 (set_buffer_internal_1, set_buffer_temp): Use them.
7673
7674 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7675
7676 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7677
7678 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7679 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7680
7681 * xdisp.c (hscroll_window_tree):
7682 (reconsider_clip_changes): Use PT instead of BUF_PT.
7683
d251f04b
EZ
76842011-03-13 Eli Zaretskii <eliz@gnu.org>
7685
7686 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7687 $(EMACS_ROOT)/lib/intprops.h.
7688
f0c77cd1
PE
76892011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7690
3eca4629
PE
7691 Fix more problems found by GCC 4.5.2's static checks.
7692
7c86ee98
PE
7693 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7694 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7695 (xg_free_frame_widgets): Make it clear that a local variable is
7696 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7697 (gdk_window_get_screen): Make it clear that this macro is needed
7698 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7699 (int_gtk_range_get_value): New function, which avoids a diagnostic
7700 from gcc -Wbad-function-cast.
7701 (xg_set_toolkit_scroll_bar_thumb): Use it.
7702 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7703 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7704 (get_utf8_string, xg_get_file_with_chooser):
7705 Rename locals to avoid shadowing.
7706 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7707
41729b81
PE
7708 * xgselect.c (xg_select): Remove unused var.
7709
f0c77cd1
PE
7710 * image.c (four_corners_best): Mark locals as initialized.
7711 (gif_load): Initialize transparent_p to zero (Bug#8238).
7712 Mark another local as initialized.
ec6cf4c6 7713 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7714
ce0ad53d 7715 * image.c (clear_image_cache): Now static.
d5d5a617 7716 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7717 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7718 (x_edge_detection): Remove unnecessary cast that
7719 gcc -Wbad-function-cast diagnoses.
2037898d 7720 (gif_load): Fix pointer signedness.
6ae141d6
PE
7721 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7722 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7723
33383987 77242011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7725
d32df629
PE
7726 Improve quality of tests for time stamp overflow.
7727 For example, without this patch (encode-time 0 0 0 1 1
7728 1152921504606846976) returns the obviously-bogus value (-948597
7729 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7730 reports time overflow. See
7731 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7732 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7733 * editfns.c: Include limits.h and intprops.h.
7734 (TIME_T_MIN, TIME_T_MAX): New macros.
7735 (time_overflow): Move earlier, to before first use.
7736 (hi_time, lo_time): New functions, for an accurate test for
7737 out-of-range times.
7738 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7739 (Fget_internal_run_time): Don't assume time_t fits in int.
7740 (make_time): Use list2 instead of Fcons twice.
7741 (Fdecode_time): More accurate test for out-of-range times.
7742 (check_tm_member): New function.
7743 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7744 (lisp_time_argument): Don't rely on undefined left-shift and
7745 right-shift behavior when checking for time stamp overflow.
8be6f318 7746
fe31d94c
PE
7747 * editfns.c (time_overflow): New function, refactoring common code.
7748 (Fformat_time_string, Fdecode_time, Fencode_time):
7749 (Fcurrent_time_string): Use it.
7750
8be6f318
PE
7751 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7752 * dired.c (make_time): Move to ...
7753 * editfns.c (make_time): ... here.
7754 * systime.h: Note the move.
7755
09d9db2c 77562011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7757
126bc0dc
YM
7758 * fringe.c (update_window_fringes): Remove unused variables.
7759
c47cbdfd
YM
7760 * unexmacosx.c (copy_data_segment): Also copy __got section.
7761 (Bug#8223)
7762
7ac80be9
EZ
77632011-03-12 Eli Zaretskii <eliz@gnu.org>
7764
c96bbc66 7765 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7766 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7767 Constify `char *' arguments and their references according to
7768 prototypes in tparam.h.
7769
ecb0f94d 7770 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7771
7ac80be9
EZ
7772 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7773 Adapt all references accordingly.
7774
7775 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7776
ef1fd07e
TT
77772011-03-11 Tom Tromey <tromey@redhat.com>
7778
7779 * buffer.c (syms_of_buffer): Remove obsolete comment.
7780
7ef4b50c
EZ
77812011-03-11 Eli Zaretskii <eliz@gnu.org>
7782
7783 * termhooks.h (encode_terminal_code): Declare prototype.
7784
7785 * msdos.c (encode_terminal_code): Don't declare prototype.
7786
7787 * term.c (encode_terminal_code): Now external again, used by
7788 w32console.c and msdos.c.
7789
44f230aa
SM
7790 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7791 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7792
4b1ec863 77932011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7794
1714f52b 7795 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7796
4b1ec863
PE
7797 * fringe.c (update_window_fringes): Mark locals as initialized
7798 (Bug#8227).
7799 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7800
524c7aa6
PE
7801 * alloc.c (mark_fringe_data): Move decl from here ...
7802 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7803 to check its interface.
7804 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7805
a5c0af81 7806 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7807 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7808 (fontset_font): Mark local as initialized.
a9a06e0b 7809 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7810
b4716021
PE
7811 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7812
811e9bac 7813 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7814 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7815 (x_own_selection, Fx_disown_selection_internal): Rename locals
7816 to avoid shadowing.
7817 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7818
7e3ab302
PE
7819 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7820 so that the caller can use some name other than gcpro1.
7821 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7822 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7823 (Fx_backspace_delete_keys_p):
7824 Use them to avoid shadowing, and rename vars to avoid shadowing.
7825 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7826 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7827 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7828 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7829 Remove unused locals.
7e3ab302
PE
7830 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7831 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7832 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7833 macros.
f78faa98 7834
e2b13473
PE
7835 * xterm.h (x_mouse_leave): New decl.
7836
77f23912
PE
7837 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7838 Remove unused functions.
cdf4ba58
PE
7839 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7840 (x_calc_absolute_position): Now static.
7411c686 7841 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7842 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7843 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7844 unless they are used.
38d0b34a
PE
7845 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7846 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7847 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7848 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7849 (x_error_catcher, x_connection_closed, x_error_handler):
7850 (x_error_quitter, xembed_send_message, x_iconify_frame):
7851 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7852 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7853 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7854
44f230aa
SM
7855 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7856 Rename or move locals to avoid shadowing.
6b463e58 7857 (tty_defined_color, merge_face_heights): Now static.
5967d051 7858 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7859 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7860 does not deduce is never used uninitialized.
73719eba
PE
7861 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7862 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7863
426994c3 7864 * terminal.c (store_terminal_param): Now static.
5489860b 7865
032f1620 7866 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7867 (set_frame_menubar): Remove unused local.
d4323972 7868 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7869 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7870 since they might point to immutable storage.
281585b0
PE
7871 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7872 since it's unused otherwise.
032f1620 7873
367c19e5 7874 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7875 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7876 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7877 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7878 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7879 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7880 does not deduce are never used uninitialized.
70739cbe 7881
07b48fa9
PE
7882 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7883
8868a238 7884 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7885 * window.c (window_loop, size_window):
7886 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7887
7e5cf297 7888 * window.c (display_buffer): Now static.
d6550a9f
PE
7889 (size_window): Mark variables that gcc -Wuninitialized
7890 does not deduce are never used uninitialized.
a586633d
PE
7891 * window.h (check_all_windows): New decl, to forestall
7892 gcc -Wmissing-prototypes diagnostic.
5b555da1 7893 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7894
f6095868
PE
7895 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7896 shadowing.
7897 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7898 Include <limits.h>.
7899 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7900 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7901 (load_charset_map): Mark variables that gcc -Wuninitialized
7902 does not deduce are never used uninitialized.
53df7c11 7903 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7904
f38b440c
PE
7905 * coding.c (coding_set_source, coding_set_destination):
7906 Use "else { /* comment */ }" rather than "else /* comment */;"
7907 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7908 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7909 a block, when the outer 'i' will do.
7910 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7911 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7912 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7913 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7914 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7915 Rename locals to avoid shadowing.
7916 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7917 * coding.c (emacs_mule_char, encode_invocation_designation):
7918 Now static, since they're not used elsewhere.
413bb2db 7919 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7920 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7921 (decode_coding_emacs_mule): Mark variables that gcc
7922 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7923 (detect_coding_iso_2022): Initialize a local variable that might
7924 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7925 this initialization is needed. (Bug#8211)
5f58e762
PE
7926 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7927 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7928 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7929 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7930 Remove unused macros.
f38b440c 7931
232b38b9 7932 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7933 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7934 * character.c (string_count_byte8): Likewise.
232b38b9 7935
fb90da1b
PE
7936 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7937 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7938
fb93dbc2
PE
7939 * chartab.c (copy_sub_char_table): Now static, since it's not used
7940 elsewhere.
5c156ace
PE
7941 (sub_char_table_ref_and_range, char_table_ref_and_range):
7942 Rename locals to avoid shadowing.
bbcd0949 7943 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7944
7d3b3862 7945 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7946 (BIDI_BOB): Remove unused macro.
7d3b3862 7947
6be7d3da
PE
7948 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7949 deduce are never used uninitialized.
c2ed9c8b 7950 * term.c (encode_terminal_code): Likewise.
6be7d3da 7951
75f8807f 7952 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7953
50938595
PE
7954 * tparam.h: New file.
7955 * term.c, tparam.h: Include it.
7956 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7957 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7958 Move these decls to tparam.h, and make them agree with what
7959 is actually in tparam.c. The previous trick of using incompatible
7960 decls in different modules does not conform to the C standard.
7961 All callers of tparam changed to use tparam's actual API.
7962 * tparam.c (tparam1, tparam, tgoto):
7963 Use const pointers where appropriate.
7964
fbceeba2
PE
7965 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7966 * cm.h (struct cm): Likewise.
7967 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7968 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7969 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7970 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7971 (turn_on_face, init_tty): Likewise.
7972 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7973
7f3f1250
PE
7974 * term.c (term_mouse_position): Rename local to avoid shadowing.
7975
e6ca6543
PE
7976 * alloc.c (mark_ttys): Move decl from here ...
7977 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7978
c40f8d15
AS
79792011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7980
7981 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7982
cfe0661d
JB
79832011-03-09 Juanma Barranquero <lekktu@gmail.com>
7984
7985 * search.c (compile_pattern_1): Remove argument regp, unused since
7986 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7987 (compile_pattern): Don't pass it.
7988
0afb4571
J
79892011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7990
7991 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7992 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7993 for ! HAVE_GTK3.
7994 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7995
7996 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7997
7998 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7999 gdk_window_get_screen, gdk_window_get_geometry,
8000 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8001 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8002 (xg_get_pixbuf_from_pixmap): New function.
8003 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8004 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8005 Call xg_get_pixbuf_from_pixmap instead of
8006 gdk_pixbuf_get_from_drawable.
8007 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8008 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8009 (xg_check_special_colors): Use GtkStyleContext and its functions
8010 for HAVE_GTK3.
8011 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8012 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8013 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8014 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8015 Call gtk_widget_get_preferred_size.
0afb4571
J
8016 (xg_frame_resized): gdk_window_get_geometry only takes 5
8017 parameters.
44f230aa
SM
8018 (xg_win_to_widget, xg_event_is_for_menubar):
8019 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8020 (xg_set_widget_bg): New function.
8021 (delete_cb): New function.
895009e1 8022 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8023 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8024 (xg_set_background_color): Call xg_set_widget_bg.
8025 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8026 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8027 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8028 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8029 if ! HAVE_GTK3.
8030 (update_frame_tool_bar): Call gtk_widget_hide.
8031 (xg_initialize): Use GDK_KEY_g.
8032
8033 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8034 if ! HAVE_GTK3
8035 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8036
8037 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8038 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8039 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8040
1c2cc4ef
JB
80412011-03-08 Juanma Barranquero <lekktu@gmail.com>
8042
8043 * w32xfns.c (select_palette): Check success of RealizePalette against
8044 GDI_ERROR, not zero.
8045
33383987 8046See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8047
8048;; Local Variables:
8049;; coding: utf-8
aac0c6e3
MR
8050;; End:
8051
33383987 8052 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8053
8054 This file is part of GNU Emacs.
8055
8056 GNU Emacs is free software: you can redistribute it and/or modify
8057 it under the terms of the GNU General Public License as published by
8058 the Free Software Foundation, either version 3 of the License, or
8059 (at your option) any later version.
8060
8061 GNU Emacs is distributed in the hope that it will be useful,
8062 but WITHOUT ANY WARRANTY; without even the implied warranty of
8063 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8064 GNU General Public License for more details.
8065
8066 You should have received a copy of the GNU General Public License
8067 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.