Tidy up ChangeLog a bit.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
977b0e45 12011-10-08 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2
977b0e45 3 Fix integer width and related issues.
eb106a49 4 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
5 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
6 (string_bytes, check_sblock, allocate_string_data):
7 (compact_small_strings, Fmake_bool_vector, make_string)
8 (make_unibyte_string, make_multibyte_string)
9 (make_string_from_bytes, make_specified_string)
10 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
11 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
12 (mark_vectorlike):
13 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
14 (allocate_pseudovector):
15 Use int, not EMACS_INT, where int is wide enough.
16 (inhibit_garbage_collection, Fgarbage_collect):
17 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
18 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
19 int might not be wide enough.
20 (bidi_cache_search, bidi_cache_find, bidi_init_it)
21 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
22 (bidi_at_paragraph_end, bidi_find_paragraph_start)
23 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
24 (bidi_level_of_next_char, bidi_move_to_visually_next):
25 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
26 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
27 (Fkill_buffer, Fset_buffer_major_mode)
28 (advance_to_char_boundary, Fbuffer_swap_text)
29 (Fset_buffer_multibyte, overlays_at, overlays_in)
30 (overlay_touches_p, struct sortvec, record_overlay_string)
31 (overlay_strings, recenter_overlay_lists)
32 (adjust_overlays_for_insert, adjust_overlays_for_delete)
33 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
34 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
35 (Foverlay_recenter, last_overlay_modification_hooks_used)
36 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
37 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
38 (validate_region): Omit unnecessary test for b <= e,
39 since that's guaranteed by the previous test.
d311d28c
PE
40 (adjust_overlays_for_delete): Avoid pos + length overflow.
41 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
42 (report_overlay_modification):
43 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
44 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
45 Omit pointer cast, which isn't needed anyway, and doesn't work
46 after the EMACS_INT -> ptrdiff_t change.
79cce3f2
PE
47 (Fmove_overlay): Delete an evaporating overlay
48 if it becomes empty after its bounds are adjusted to fit within
49 its buffer. Without this fix, in a nonempty buffer (let ((o
50 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
51 yields an empty overlay that has the evaporate property, which is
52 not supposed to happen. (Bug#9642)
d311d28c
PE
53 * buffer.h: Adjust decls to match defn changes elsewhere.
54 (struct buffer_text, struct buffer):
55 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
56 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
57 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
58 not int, to avoid needless 32-bit limit on 64-bit hosts.
59 (exec_byte_code): Use tighter memory-full test, one that checks
60 for alloca overflow. Don't compute the address of the object just
61 before an array, as that's not portable. Use EMACS_INT, not
62 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
63 * callint.c (Fcall_interactively):
64 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
65 * callproc.c (call_process_kill, Fcall_process):
66 Don't assume pid_t fits into an Emacs fixnum.
67 (call_process_cleanup, Fcall_process, child_setup):
68 Don't assume pid_t fits into int.
69 (call_process_cleanup, Fcall_process, delete_temp_file)
70 (Fcall_process_region):
71 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
72 (Fcall_process): Simplify handling of volatile integers.
73 Use int, not EMACS_INT, where int will do.
74 * casefiddle.c (casify_object, casify_region, operate_on_word)
75 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
76 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
77 (casify_object): Avoid integer overflow when overallocating buffer.
78 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 79 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
80 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
81 * category.h (CATEGORYP): Don't assume arg is nonnegative.
82 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
83 integers are now checked earlier. All uses replaced with XINT.
84 (ccl_driver):
85 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
86 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
87 (ccl_driver, Fregister_code_conversion_map):
88 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
89 (resolve_symbol_ccl_program): Check that vector header is in range.
90 Always copy the vector, so that we can check its contents reliably
91 now rather than having to recheck each instruction as it's being
92 executed. Check that vector words fit in 'int'.
93 (ccl_get_compiled_code, Fregister_ccl_program)
94 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
95 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
96 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
97 contents are in range.
98 (Fccl_execute_on_string): Check that status is in range.
99 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
100 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
101 Accept and return EMACS_INT, not int, because callers can pass values
102 out of 'int' range.
103 (c_string_width, strwidth, lisp_string_width, chars_in_text)
104 (multibyte_chars_in_text, parse_str_as_multibyte)
105 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
106 (str_as_unibyte, str_to_unibyte, string_count_byte8)
107 (string_escape_byte8, Fget_byte):
108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
109 (Funibyte_string): Use CHECK_CHARACTER, not CHECK_NATNUM, to
110 avoid mishandling large integers.
111 * character.h: Adjust decls to match defn changes elsewhere.
112 * charset.c (load_charset_map_from_file, find_charsets_in_text)
113 (Ffind_charset_region):
114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
115 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
116 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 117 Don't assume fixnum fits in int.
d311d28c
PE
118 (load_charset_map_from_vector, Fmap_charset_chars):
119 Remove now-unnecessary CHECK_NATNUMs.
120 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
121 Don't rely on undefined behavior with signed left shift overflow.
122 Don't assume unsigned int fits into fixnum, or that fixnum fits
123 into unsigned int. Don't require max_code to be a valid fixnum;
124 that's not true for gb10830 4-byte on a 32-bit host. Allow
125 invalid_code to be a cons, for the same reason. Require code_offset
126 to be a character. Avoid int overflow if max_char is close
127 to INT_MAX.
128 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
129 this is intended anyway and avoids some undefined behavior.
130 (load_charset_map): Pass unsigned, not int, as 2nd arg of
131 INDEX_TO_CODE_POINT, as that's what it expects.
132 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
133 * charset.h (DECODE_CHAR): Return int, not unsigned;
134 this is what was intended anyway, and it avoids undefined behavior.
135 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
136 integer-overflow issues.
137 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
138 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
139 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
140 * chartab.c (Fmake_char_table, Fset_char_table_range)
141 (uniprop_get_decoder, uniprop_get_encoder):
142 Don't assume fixnum fits in int.
143 * cmds.c (move_point): New function, that does the gist of
144 Fforward_char and Fbackward_char, but does so while checking
145 for integer overflow more accurately.
c96e5d6a 146 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
147 (Fforward_line, Fend_of_line, internal_self_insert)
148 (internal_self_insert):
149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
150 Fix a FIXME, by checking for integer overflow when calculating
151 target_clm and actual_clm.
152 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
153 (ASSURE_DESTINATION, coding_alloc_by_realloc)
154 (coding_alloc_by_making_gap, alloc_destination)
155 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
156 (encode_coding_utf_16, detect_coding_emacs_mule)
157 (decode_coding_emacs_mule, encode_coding_emacs_mule)
158 (detect_coding_iso_2022, decode_coding_iso_2022)
159 (encode_invocation_designation, encode_designation_at_bol)
160 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
161 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
162 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
163 (encode_coding_ccl, encode_coding_raw_text)
164 (detect_coding_charset, decode_coding_charset)
165 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
166 (produce_composition, produce_charset, produce_annotation)
167 (decode_coding, handle_composition_annotation)
168 (handle_charset_annotation, consume_chars, decode_coding_gap)
169 (decode_coding_object, encode_coding_object, detect_coding_system)
170 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
171 (code_convert_region, code_convert_string)
172 (Fdefine_coding_system_internal):
173 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
174 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
175 (Fdefine_coding_system_internal):
176 Don't assume fixnums fit in int.
177 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 178 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
179 (Funencodable_char_position, Fcheck_coding_systems_region)
180 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 182 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 183 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 184 Don't access memory outside of the args array.
d311d28c 185 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
186 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
187 result of ENCODE_CHAR.
d311d28c
PE
188 * coding.h: Adjust decls to match defn changes elsewhere.
189 (struct coding_system):
190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
191 * composite.c (get_composition_id, find_composition)
192 (run_composition_function, update_compositions)
193 (compose_text, composition_gstring_put_cache)
194 (composition_gstring_p, composition_gstring_width)
195 (fill_gstring_header, fill_gstring_body, autocmp_chars)
196 (composition_compute_stop_pos, composition_reseat_it)
197 (composition_update_it, struct position_record)
198 (find_automatic_composition, composition_adjust_point)
199 (Fcomposition_get_gstring, Ffind_composition_internal):
200 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
201 (update_compositions):
202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
203 * composite.h: Adjust decls to match defn changes elsewhere.
204 (struct composition):
205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
206 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
207 Do not attempt to compute the address of the object just before a
208 buffer; this is not portable.
209 (Faref, Faset):
210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
211 (Faset): Use int, not EMACS_INT, where int is wide enough.
212 (Fstring_to_number): Don't assume fixnums fit in int.
213 (Frem): Don't assume arg is nonnegative.
214 * dbusbind.c (xd_append_arg): Check for integers out of range.
215 (Fdbus_call_method): Don't overflow the timeout int.
216 * dired.c (directory_files_internal, file_name_completion, scmp)
217 (file_name_completion_stat):
218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
219 (file_name_completion): Don't overflow matchcount.
220 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
221 * dispextern.h: Adjust decls to match defn changes elsewhere.
222 (struct text_pos, struct glyph, struct bidi_saved_info)
223 (struct bidi_string_data, struct bidi_it, struct composition_it)
224 (struct it):
225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
226 (struct display_pos, struct composition_it, struct it):
227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
228 * dispnew.c (increment_matrix_positions)
229 (increment_row_positions, mode_line_string)
230 (marginal_area_string):
231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 232 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
234 (duration_to_sec_usec): New function, to check for overflow better.
235 (Fsleep_for, sit_for): Use it.
236 * doc.c (get_doc_string, store_function_docstring):
237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
238 (get_doc_string, Fsnarf_documentation):
239 Use int, not EMACS_INT, where int is wide enough.
240 (get_doc_string):
241 Use SAFE_ALLOCA, not alloca.
242 Check for overflow when converting EMACS_INT to off_t.
243 * doprnt.c (doprnt):
244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
245 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
246 Don't assume uid_t fits into fixnum.
247 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
248 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
249 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
250 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
251 (general_insert_function)
252 (Finsert_char, make_buffer_string, make_buffer_string_both)
253 (update_buffer_properties, Fbuffer_substring)
254 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
255 (Fsubst_char_in_region, check_translation)
256 (Ftranslate_region_internal, save_restriction_restore, Fformat)
257 (transpose_markers, Ftranspose_regions):
258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
259 (clip_to_bounds): Move to lisp.h as an inline function).
260 (Fconstrain_to_field): Don't assume integers are nonnegative.
261 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
262 (Fsubst_char_in_region, Fsave_restriction):
263 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
264 (Femacs_pid): Don't assume pid_t fits into fixnum.
265 (lo_time): Use int, not EMACS_INT, when int suffices.
266 (lisp_time_argument): Check for usec out of range.
267 (Fencode_time): Don't assume fixnum fits in int.
268 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
269 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
270 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
271 (init_cmdargs, Fdump_emacs):
272 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
273 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
274 the bottom (typically) 32 bits of the fixnum.
275 * eval.c (specpdl_size, call_debugger):
276 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
277 (when_entered_debugger, Fbacktrace_debug):
278 Don't assume fixnum can fit in int.
279 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
280 the object just before a buffer; this is not portable.
281 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
282 (grow_specpdl, unbind_to):
283 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
284 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
285 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 286 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
287 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
288 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
289 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
290 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
291 (a_write, e_write):
292 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
293 (Fcopy_file, non_regular_nbytes, read_non_regular)
294 (Finsert_file_contents):
295 Use int, not EMACS_INT, where int is wide enough.
296 (READ_BUF_SIZE): Verify that it fits in int.
297 (Finsert_file_contents): Check that counts are in proper range,
298 rather than assuming fixnums fit into ptrdiff_t etc.
299 Don't assume fixnums fit into int.
125b3835 300 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
301 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
302 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
303 (string_char_to_byte, string_byte_to_char)
304 (string_make_multibyte, string_to_multibyte)
305 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
306 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
307 (substring_both, Fdelete, internal_equal, Ffillarray)
308 (Fclear_string, mapcar1)
309 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
310 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
311 (larger_vector, make_hash_table, maybe_resize_hash_table)
312 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
313 (Fmaphash, secure_hash):
314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
315 (concat): Check for string index and length overflow.
316 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
317 (Frequire):
318 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
319 (larger_vector): New API (vec, incr_min, size_max) replaces old
320 one (vec, new_size, init). This catches size overflow.
321 INIT was removed because it was always Qnil.
322 All callers changed.
323 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
324 the upper bound on a hash table index size.
325 (make_hash_table, maybe_resize_hash_table): Use it.
326 (secure_hash): Computer start_byte and end_byte only after
327 they're known to be in ptrdiff_t range.
328 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
329 (Ffont_get_glyphs, Ffont_at):
330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
331 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
332 (Flist_fonts, Fopen_font):
333 Don't assume fixnum can fit in int.
334 (check_gstring): Don't assume index can fit in int.
335 (font_match_p): Check that fixnum is a character, not a nonnegative
336 fixnum, since the later code needs to stuff it into an int.
337 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
338 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
339 conversion overflow issues.
340 (Fopen_font): Check for integer out of range.
341 (Ffont_get_glyphs): Don't assume index can fit in int.
342 * font.h: Adjust decls to match defn changes elsewhere.
343 * fontset.c (reorder_font_vector): Redo score calculation to avoid
344 integer overflow.
345 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
346 printmax_t, where ptrdiff_t is wide enough.
347 (Finternal_char_font):
348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
349 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
350 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
351 (Fset_frame_position, x_set_frame_parameters)
352 (x_set_line_spacing, x_set_border_width)
353 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
354 Check that fixnums are in proper range for system types.
355 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
356 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
357 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
358 Use SAFE_ALLOCA_LISP, not alloca.
359 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
360 intptr_t is wide enough.
361 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
362 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
363 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
364 Check for fixnum out of range.
365 * ftfont.c (ftfont_list): Don't assume index fits in int.
366 Check that fixnums are in proper range for system types.
367 (ftfont_shape_by_flt):
368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
369 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
371 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
372 Check that fixnums are in proper range for system types.
373 * gnutls.h: Adjust decls to match defn changes elsewhere.
374 * gtkutil.c (xg_dialog_run):
375 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
376 (update_frame_tool_bar):
377 Check that fixnums are in proper range for system types.
378 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 379 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
380 * indent.c (last_known_column, last_known_column_point):
381 (current_column_bol_cache):
382 (skip_invisible, current_column, check_display_width):
383 (check_display_width, scan_for_column, current_column_1)
384 (Findent_to, Fcurrent_indentation, position_indentation)
385 (indented_beyond_p, Fmove_to_column, compute_motion):
386 (Fcompute_motion, Fvertical_motion):
387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
388 (last_known_column_modified): Use EMACS_INT, not int.
389 (check_display_width):
390 (Fcompute_motion):
391 Check that fixnums and floats are in proper range for system types.
392 (compute_motion): Don't assume index or fixnum fits in int.
393 (compute_motion, Fcompute_motion):
394 Use int, not EMACS_INT, when it is wide enough.
395 (vmotion): Omit local var start_hpos that is always 0; that way
396 we don't need to worry about overflow in expressions involving it.
397 * indent.h: Adjust decls to match defn changes elsewhere.
398 (struct position):
399 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
400 Use int, not EMACS_INT, where int is wide enough.
401 Remove unused members ovstring_chars_done and tab_offset;
402 all uses removed.
403 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
404 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
405 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
406 (make_gap, copy_text, insert, insert_and_inherit)
407 (insert_before_markers, insert_before_markers_and_inherit)
408 (insert_1, count_combining_before, count_combining_after)
409 (insert_1_both, insert_from_string)
410 (insert_from_string_before_markers, insert_from_string_1)
411 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
412 (adjust_after_replace, adjust_after_insert, replace_range)
413 (replace_range_2, del_range, del_range_1, del_range_byte)
414 (del_range_both, del_range_2, modify_region)
415 (prepare_to_modify_buffer, signal_before_change)
416 (signal_after_change, Fcombine_after_change_execute):
417 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
418 * intervals.c (traverse_intervals, rotate_right, rotate_left)
419 (balance_an_interval, split_interval_right, split_interval_left)
420 (find_interval, next_interval, update_interval)
421 (adjust_intervals_for_insertion, delete_node, delete_interval)
422 (interval_deletion_adjustment, adjust_intervals_for_deletion)
423 (static_offset_intervals, offset_intervals)
424 (merge_interval_right, merge_interval_left, make_new_interval)
425 (graft_intervals_into_buffer, temp_set_point_both)
426 (temp_set_point, set_point, adjust_for_invis_intang)
427 (set_point_both, move_if_not_intangible, get_property_and_range)
428 (get_local_map, copy_intervals, copy_intervals_to_string)
429 (compare_string_intervals, set_intervals_multibyte_1):
430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
431 * intervals.h: Adjust decls to match defn changes elsewhere.
432 (struct interval):
433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
434 * keyboard.c (this_command_key_count, this_single_command_key_start)
435 (before_command_key_count, before_command_echo_length, echo_now)
436 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
437 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
438 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
439 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
440 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
441 (last_non_minibuf_size, last_point_position, echo_truncate)
442 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
443 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
444 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
445 (stuff_buffered_input):
446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
447 (last_auto_save, command_loop_1, read_char):
448 Use EMACS_INT, not int, to avoid integer overflow.
449 (record_char): Avoid overflow in total_keys computation.
450 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
451 * keyboard.h: Adjust decls to match defn changes elsewhere.
452 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
453 (Fkey_description, Fdescribe_vector, Flookup_key):
454 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
455 (click_position): New function, to check that positions are in range.
456 (Fcurrent_active_maps):
457 (describe_command):
458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
459 (Faccessible_keymaps, Fkey_description):
460 (preferred_sequence_p):
461 Don't assume fixnum can fit into int.
462 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
463 Check for integer overflow in size calculations.
464 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
465 avoid mishandling large integers.
466 * lisp.h: Adjust decls to match defn changes elsewhere.
467 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
468 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
469 (struct Lisp_Marker):
470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
471 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
472 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
473 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
474 All callers changed.
475 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
476 Assume the arg has valid form, since it always does.
477 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
478 unsigned integer system type.
479 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
480 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
481 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
482 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
483 (duration_to_sec_usec): New decl.
484 * lread.c (read_from_string_index, read_from_string_index_byte)
485 (read_from_string_limit, readchar, unreadchar, openp)
486 (read_internal_start, read1, oblookup):
487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
488 (Fload, readevalloop, Feval_buffer, Feval_region):
489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
490 (openp): Check for out-of-range argument to 'access'.
491 (read1): Use int, not EMACS_INT, where int is wide enough.
492 Don't assume fixnum fits into int.
1ab7b8ac
PE
493 (read_filtered_event): Use duration_to_sec_usec
494 to do proper overflow checking on durations.
d311d28c
PE
495 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
496 in size calculation.
497 (Fexecute_kbd_macro):
498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
499 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
500 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
501 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
502 (set_marker_both, set_marker_restricted_both, marker_position)
503 (marker_byte_position, Fbuffer_has_markers_at):
504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
505 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
506 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
507 It now merely ensures that the menu is large enough, without
508 necessarily growing it, as this avoids some integer overflow issues.
509 All callers changed.
510 (keymap_panes, parse_single_submenu, Fx_popup_menu):
511 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
512 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
513 Use SAFE_ALLOCA_LISP, not alloca.
514 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
515 to EMACS_INT. Check that fixnums are in proper range for system types.
516 * minibuf.c (minibuf_prompt_width, string_to_object)
517 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
518 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
520 (get_minibuffer, read_minibuf_unwind):
521 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
522 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
523 this simplifies overflow checking. All callers changed.
524 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
525 (Ftest_completion):
526 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
527 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
528 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
529 Check that fixnums are in proper range for system types.
530 (Fx_create_frame, Fx_show_tip):
531 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
532 * nsfont.m (ns_findfonts, nsfont_list_family):
533 Don't assume fixnum fits in long.
534 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
535 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
536 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
537 wide enough.
17fdb222 538 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
540 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
541 (PRINTDECLARE, PRINTPREPARE):
542 (strout, print_string):
543 (print, print_preprocess, print_check_string_charset_prop)
544 (print_object):
545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
546 (PRINTDECLARE):
547 (temp_output_buffer_setup, Fprin1_to_string, print_object):
548 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
549 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
550 (PRINTFINISH): Use SAFE_ALLOCA, not alloca.
551 (printchar, strout): Use xpalloc to catch size calculation overflow.
552 (Fexternal_debugging_output): Use CHECK_CHARACTER, not CHECK_NUMBER,
553 to avoid mishandling large integers.
554 (print_error_message): Use SAFE_ALLOCA, not alloca.
555 (print_object): Use int, not EMACS_INT, where int is wide enough.
556 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
557 (Fset_process_window_size, Fformat_network_address)
558 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
559 (Fsignal_process, sigchld_handler):
560 Check that fixnums are in proper range for system types.
561 (Fformat_network_address, read_process_output, send_process)
562 (Fprocess_send_region, status_notify):
563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
564 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
565 (wait_reading_process_output, read_process_output, exec_sentinel):
566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
567 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
568 (Faccept_process_output): Use duration_to_sec_usec to do proper
569 overflow checking on durations.
b62b53e8
PE
570 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
571 configured --with-wide-int.
d311d28c
PE
572 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
573 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
574 * search.c (looking_at_1, string_match_1):
575 (fast_string_match, fast_c_string_match_ignore_case)
576 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
577 (scan_newline, find_before_next_newline, search_command)
578 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
579 (set_search_regs, wordify):
580 (Freplace_match):
581 (Fmatch_data):
582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
583 (string_match_1, search_buffer, set_search_regs):
584 (Fmatch_data):
585 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
586 (wordify): Check for overflow in size calculation.
587 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
588 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
589 Check that fixnums are in proper range for system types.
590 * sound.c (struct sound_device)
591 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
592 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
593 (Fplay_sound_internal):
594 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
595 * syntax.c (ST_COMMENT_STYLE, ST_STRING_STYLE):
596 In definitions, make it clearer that these values must be out of range
5895d7b9
PE
597 for the respective integer ranges. This fixes a bug with
598 ST_STRING_STYLE and non-ASCII characters.
d311d28c
PE
599 (struct lisp_parse_state, find_start_modiff)
600 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
601 (Fparse_partial_sexp):
602 Don't assume fixnums can fit in int.
603 (struct lisp_parse_state, find_start_pos, find_start_value)
604 (find_start_value_byte, find_start_begv)
605 (update_syntax_table, char_quoted, dec_bytepos)
606 (find_defun_start, prev_char_comend_first, back_comment):
607 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
608 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
610 (Finternal_describe_syntax_value): Check that match_lisp is a
611 character, not an integer, since the code stuffs it into int.
612 (scan_words, scan_sexps_forward):
613 Check that fixnums are in proper range for system types.
614 (Fforward_word):
615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
616 (scan_sexps_forward):
617 Use CHARACTERP, not INTEGERP, since the value must fit into int.
618 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
619 * syntax.h: Adjust decls to match defn changes elsewhere.
620 (struct gl_state_s):
621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
622 * sysdep.c (wait_for_termination_1, wait_for_termination)
623 (interruptible_wait_for_termination, mkdir):
624 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
625 (emacs_read, emacs_write):
626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
627 (system_process_attributes): Don't assume uid_t, gid_t, and
628 double all fit in int or even EMACS_INT.
629 * term.c (set_tty_color_mode):
630 Check that fixnums are in proper range for system types.
631 * termhooks.h (struct input_event):
632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
633 * textprop.c (validate_interval_range, interval_of)
634 (Fadd_text_properties, set_text_properties_1)
635 (Fremove_text_properties, Fremove_list_of_text_properties)
636 (Ftext_property_any, Ftext_property_not_all)
637 (copy_text_properties, text_property_list, extend_property_ranges)
638 (verify_interval_modification):
639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
640 (Fnext_single_char_property_change)
641 (Fprevious_single_char_property_change):
642 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
643 (copy_text_properties):
644 Check for integer overflow in index calculation.
d311d28c
PE
645 * undo.c (last_boundary_position, record_point, record_insert)
646 (record_delete, record_marker_adjustment, record_change)
647 (record_property_change):
648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
649 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
650 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
651 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
652 (Fx_hide_tip, Fx_file_dialog):
653 * w32menu.c (set_frame_menubar):
654 Use ptrdiff_t, not int, for consistency with rest of code.
655 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
656 (select_window, Fdelete_other_windows_internal)
657 (window_scroll_pixel_based, window_scroll_line_based)
658 (Frecenter, Fset_window_configuration):
659 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
660 (Fset_window_hscroll, run_window_configuration_change_hook)
661 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 662 (Fscroll_other_window, Frecenter):
d311d28c
PE
663 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
664 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
665 Don't assume fixnum fits in int.
666 (Fset_window_scroll_bars):
667 Check that fixnums are in proper range for system types.
668 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
669 (string_pos, c_string_pos, number_of_chars, init_iterator)
670 (in_ellipses_for_invisible_text_p, init_from_display_pos)
671 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
672 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
673 (face_before_or_after_it_pos, handle_invisible_prop)
674 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
675 (display_prop_intangible_p, string_buffer_position_lim)
676 (string_buffer_position, handle_composition_prop, load_overlay_strings)
677 (get_overlay_strings_1, get_overlay_strings)
678 (iterate_out_of_display_property, forward_to_next_line_start)
679 (back_to_previous_visible_line_start, reseat, reseat_to_string)
680 (get_next_display_element, set_iterator_to_next)
681 (get_visually_first_element, compute_stop_pos_backwards)
682 (handle_stop_backwards, next_element_from_buffer)
683 (move_it_in_display_line_to, move_it_in_display_line)
684 (move_it_to, move_it_vertically_backward, move_it_by_lines)
685 (add_to_log, message_dolog, message_log_check_duplicate)
686 (message2, message2_nolog, message3, message3_nolog
687 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
688 (current_message_1, truncate_echo_area, truncate_message_1)
689 (set_message, set_message_1, store_mode_line_noprop)
690 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
691 (text_outside_line_unchanged_p, check_point_in_composition)
692 (reconsider_clip_changes)
693 (redisplay_internal, set_cursor_from_row, try_scrolling)
694 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
695 (redisplay_window, find_last_unchanged_at_beg_row)
696 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
697 (trailing_whitespace_p, find_row_edges, display_line)
698 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
699 (display_mode_element, store_mode_line_string)
700 (pint2str, pint2hrstr, decode_mode_spec)
701 (display_count_lines, display_string, draw_glyphs)
702 (x_produce_glyphs, x_insert_glyphs)
703 (rows_from_pos_range, mouse_face_from_buffer_pos)
704 (fast_find_string_pos, mouse_face_from_string_pos)
705 (note_mode_line_or_margin_highlight, note_mouse_highlight):
706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
707 (safe_call, init_from_display_pos, handle_fontified_prop)
708 (handle_single_display_spec, load_overlay_strings)
709 (with_echo_area_buffer, setup_echo_area_for_printing)
710 (display_echo_area, echo_area_display)
711 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
712 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
713 (redisplay_window, dump_glyph_row, display_mode_line)
714 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 715 (handle_display_spec, display_prop_string_p):
d311d28c
PE
716 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
717 (handle_single_display_spec, build_desired_tool_bar_string)
718 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
719 (get_specified_cursor_type):
720 Check that fixnums are in proper range for system types.
721 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
722 (Flookup_image_map):
723 Don't assume fixnums fit in int.
724 (compare_overlay_entries):
725 Avoid mishandling comparisons due to subtraction overflow.
726 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
727 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
728 (handle_tool_bar_click):
729 Use int, not unsigned, since we prefer signed and the signedness
730 doesn't matter here.
731 (get_next_display_element, next_element_from_display_vector):
732 Use int, not EMACS_INT, when int is wide enough.
733 (start_hourglass): Use duration_to_sec_usec to do proper
734 overflow checking on durations.
735 * xfaces.c (Fbitmap_spec_p):
736 Check that fixnums are in proper range for system types.
737 (compare_fonts_by_sort_order):
738 Avoid mishandling comparisons due to subtraction overflow.
739 (Fx_family_fonts, realize_basic_faces):
740 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
741 (Fx_family_fonts):
742 Don't assume fixnum fits in int.
743 Use SAFE_ALLOCA_LISP, not alloca.
744 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
745 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
746 (face_at_buffer_position, face_for_overlay_string)
747 (face_at_string_position):
748 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
749 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
750 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
751 (Fx_show_tip):
752 Check that fixnums are in proper range for system types.
753 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
754 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
756 (Fx_change_window_property): Don't assume fixnums fit in int.
757 * xfont.c (xfont_chars_supported):
758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
759 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
760 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
761 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
762 * xml.c (parse_region):
763 * xrdb.c (magic_file_p):
764 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
765 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
766 (x_get_local_selection, x_reply_selection_request)
767 (x_handle_selection_request, wait_for_property_change):
768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
769 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
770 short is wide enough.
771 (x_send_client_event): Don't assume fixnum fits in int.
772 * xterm.c (x_x_to_emacs_modifiers):
773 Don't assume EMACS_INT overflows nicely into int.
774 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
775 may come from Lisp.
776 (handle_one_xevent): NATNUMP can eval its arg twice.
777 (x_connection_closed):
778 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
779 * xterm.h: Adjust decls to match defn changes elsewhere.
780 (struct scroll_bar): Use struct vectorlike_header
781 rather than rolling our own approximation.
782 (SCROLL_BAR_VEC_SIZE): Remove; not used.
783
a66cfb1c
SM
7842011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
785
786 * buffer.c (syms_of_buffer) <enable-multibyte-characters>: Don't
787 advertise functionality which we discourage or doesn't work.
788
7c5ee88e
PE
7892011-10-07 Paul Eggert <eggert@cs.ucla.edu>
790
791 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
792 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
793 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
794 this makes Emacs dump core during garbage collection on rare
795 occasions. sizeof is obviously inferior to offsetof here, so
796 stick with offsetof.
797 (GC_POINTER_ALIGNMENT): New macro.
798 (mark_memory): Omit 3rd (offset) arg; caller changed.
799 Don't assume EMACS_INT alignment is the same as pointer alignment.
800
df1bbe5b
SM
8012011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
802
803 * keyboard.c (read_key_sequence_remapped): New var.
804 (read_key_sequence): Compute remapping in the right buffer.
805 (command_loop_1): Use read_key_sequence's remapping directly.
806
51553db6
SM
8072011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
808
32c1fffd
SM
809 * dired.c (file_name_completion): Don't expand file name.
810 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
811 before checking file name handler.
812
51553db6
SM
813 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
814 they've been requested explicitly (bug#9591).
815
b6bd1599 8162011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
817
818 * keymap.c (Fsingle_key_description): Use make_specified_string
819 instead of build_string to build string from push_key_description.
820 (Bug#5193)
821
f701dc2a
PE
8222011-09-30 Paul Eggert <eggert@cs.ucla.edu>
823
4222c55d
PE
824 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
825 This fixes a Y2038 bug on 64-bit hosts.
826 * buffer.c (reset_buffer):
827 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
828 (Fclear_buffer_auto_save_failure):
829 Use 0, not -1, to represent an unset failure time, since time_t
830 might not be signed.
831
f701dc2a
PE
832 Remove dependency on glibc malloc internals.
833 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
834 Move back here from lisp.h, but with their new implementations.
835 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
836 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
837 * charset.c (charset_table_init): New static var.
838 (syms_of_charset): Use it instead of xmalloc. This removes a
839 dependency on glibc malloc internals. See Eli Zaretskii's comment in
840 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
841 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
842 Move back to alloc.c.
843 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
844 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
845
9ceebf39
JD
8462011-09-30 Jan Djärv <jan.h.d@swipnet.se>
847
848 * nsterm.m (windowDidResize): Call x_set_window_size only when
849 ns_in_resize is true. Otherwise set pixelwidth/height and
850 call change_frame_size (Bug#9628).
851
cb993c58
PE
8522011-09-30 Paul Eggert <eggert@cs.ucla.edu>
853
3930c88b
PE
854 Port --enable-checking=all to Fedora 14 x86-64.
855 * charset.c (syms_of_charset): Also account for glibc malloc's
856 internal overhead when calculating the initial malloc maximum.
857
cb993c58
PE
858 Port --enable-checking=all to Fedora 14 x86.
859 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
860 Move to lisp.h.
861 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
862 (overrun_check_realloc, overrun_check_free):
863 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
864 That way, xmalloc returns a properly-aligned pointer even if
865 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
866 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
867 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
868 into account when calculating the initial malloc maximum.
869 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
870 Move here from alloc.c, so that charset.c can use it too.
871 Properly align; the old code wasn't right for common 32-bit hosts
872 when configured with --enable-checking=all.
873 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
874 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
875
31bed486
EZ
8762011-09-29 Eli Zaretskii <eliz@gnu.org>
877
04c70788 878 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
879 use EDOM.
880
fbcaa2f3
EZ
8812011-09-28 Eli Zaretskii <eliz@gnu.org>
882
883 * xdisp.c (compute_display_string_end): If there's no display
884 string at CHARPOS, return -1.
885
886 * bidi.c (bidi_fetch_char): When compute_display_string_end
887 returns a negative value, treat the character as a normal
888 character not covered by a display string. (Bug#9624)
889
a239d4e9
JB
8902011-09-28 Juanma Barranquero <lekktu@gmail.com>
891
892 * lread.c (Fread_from_string): Fix typo in docstring.
893
88652fd5
EZ
8942011-09-27 Eli Zaretskii <eliz@gnu.org>
895
896 * xdisp.c (handle_invisible_prop): If invisible text ends on a
897 newline, reseat the iterator instead of bidi-iterating there one
898 character at a time. (Bug#9610)
32c1fffd
SM
899 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
900 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 901
ed497dd4
AS
9022011-09-27 Andreas Schwab <schwab@linux-m68k.org>
903
904 * lread.c (readevalloop): Use correct code for NBSP.
905 (read1): Likewise. (Bug#9608)
906
b2bf61aa
MA
9072011-09-25 Michael Albinus <michael.albinus@gmx.de>
908
909 * dbusbind.c (Fdbus_register_signal): When service is not
910 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
911
32bbb17c
GM
9122011-09-25 Glenn Morris <rgm@gnu.org>
913
914 * buffer.c (truncate-lines): Doc fix.
915
94e0933e
CY
9162011-09-24 Chong Yidong <cyd@stupidchicken.com>
917
918 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
919 (Fset_window_next_buffers): Doc fix.
920
cddde921
GM
9212011-09-24 Glenn Morris <rgm@gnu.org>
922
923 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
924
1260aef1
PE
9252011-09-24 Paul Eggert <eggert@cs.ucla.edu>
926
25b4bfa0
PE
927 Fix minor problems found by static checking.
928 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
929 * indent.c (Fvertical_motion): Fix == vs = typo.
930
e3cbd34b
EZ
9312011-09-24 Eli Zaretskii <eliz@gnu.org>
932
a66cfb1c
SM
933 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
934 Default value is now t. Doc fix.
6bf7006f 935
e3cbd34b 936 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 937 logic when moving up, not only when moving down. Fix the
e3cbd34b 938 confusing name and values of the it_overshoot_expected variable;
32c1fffd 939 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
940
941 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
942 CHARPOS is covered by a display string which includes newlines.
943 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
944 is covered by a display string with embedded newlines.
945
a3de0cbd
MA
9462011-09-24 Michael Albinus <michael.albinus@gmx.de>
947
948 * dbusbind.c (Fdbus_register_signal): Add match rule to
949 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
950 (Fdbus_register_method, Vdbus_registered_objects_table):
951 Fix docstring.
a3de0cbd 952
b260039d
JM
9532011-09-24 Jim Meyering <meyering@redhat.com>
954
32c1fffd 955 do not ignore write error for any output size
b260039d
JM
956 The previous change was incomplete.
957 While it makes emacs --batch detect the vast majority of stdout
958 write failures, errors were still ignored whenever the output size is
959 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
960 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
961 && echo FAIL: ignored write error
962 FAIL: ignored write error
963 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
964 && echo FAIL: ignored write error
965 FAIL: ignored write error
966 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
967
8eca8a7c
AS
9682011-09-23 Andreas Schwab <schwab@linux-m68k.org>
969
970 * emacs.c (Fkill_emacs): In noninteractive mode exit
971 non-successfully if a write error occurred on stdout. (Bug#9574)
972
3341db62
EZ
9732011-09-21 Eli Zaretskii <eliz@gnu.org>
974
975 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
976 the xassert test.
977
978 * dispextern.h (struct it): Update the comment documenting what
979 can it->OBJECT be.
980
8c203dbf
EZ
9812011-09-20 Eli Zaretskii <eliz@gnu.org>
982
983 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
984 a display string, extend search for cursor position to end of row.
985 (find_row_edges): If the row ends in a newline from a display
986 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
987 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
988 (Fcurrent_bidi_paragraph_direction): Fix search for previous
989 non-empty line. Fixes confusing cursor motion with arrow keys at
990 the beginning of a line that starts with whitespace.
8c203dbf 991
a4824228
LMI
9922011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
993
994 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
995 (bug#9493).
996
33ed493b
CY
9972011-09-18 Chong Yidong <cyd@stupidchicken.com>
998
999 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1000 boolean (Bug#9154).
1001
56cd55c8
EZ
10022011-09-18 Eli Zaretskii <eliz@gnu.org>
1003
1004 * xdisp.c (display_line): Record maximum and minimum buffer
1005 positions even if no glyphs were produced (e.g., by a zero-width
1006 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1007 buffer positions that will be removed from the glyph row because
1008 they don't fit.
c02dcedf
EZ
1009 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1010 column is beyond frame width: don't subtract 1 "pixel" when
1011 computing width of the stretch.
3e62b7e0
EZ
1012 (reseat_at_next_visible_line_start): Undo the change made on
1013 2011-09-17 that saved paragraph information and restored it after
1014 the call to `reseat'. (Bug#9545)
56cd55c8 1015
5ed99d36 10162011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1017
1018 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1019 and turn window cursor on if cleared (Bug#9415).
1020
5ed99d36 10212011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1022
1023 * search.c (boyer_moore): Take unibyte characters from pattern
1024 literally. (Bug#9458)
1025
9bade7b2
EZ
10262011-09-18 Eli Zaretskii <eliz@gnu.org>
1027
1028 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1029
e5e9d610
PE
10302011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1031
87e4427a
PE
1032 Fix minor problem found by static checking.
1033 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1034 initialized, to pacify gcc -Wuninitialized.
1035
e5e9d610
PE
1036 * fileio.c: Report proper errno when syscall falls.
1037 (Finsert_file_contents): Save and restore errno,
1038 so that report_file_error outputs the correct diagnostic.
1039 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1040
a1674f0b
EZ
10412011-09-18 Eli Zaretskii <eliz@gnu.org>
1042
1043 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1044
fbfb6dd4
EZ
10452011-09-17 Eli Zaretskii <eliz@gnu.org>
1046
1047 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1048 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1049
bb187662
EZ
10502011-09-17 Eli Zaretskii <eliz@gnu.org>
1051
1137e8b8
EZ
1052 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1053 about the current paragraph and restore it after the call to
1054 reseat.
1055
1056 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1057 (bidi_find_paragraph_start): Search back for paragraph beginning
1058 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1059 (bidi_move_to_visually_next): Only trigger paragraph-related
1060 computations when the last character is a newline or at EOB, not
1061 just any NEUTRAL_B. (Bug#9470)
1062
bb187662
EZ
1063 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1064 truncated lines if point is covered by a display string. (Bug#9524)
1065
2e621251
PE
10662011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1067
1068 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1069 (cons_to_x_long): New function.
1070 (lisp_data_to_selection_data): Use it. Correct the test for
1071 short-versus-long data; it was negated. Break out of vector
1072 loop, for efficiency, when a long datum is discovered.
1073
91a15bc6
SM
10742011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1075
1076 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1077
b41c3a35
EZ
10782011-09-16 Eli Zaretskii <eliz@gnu.org>
1079
1080 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1081 GCC PR/17406) by declaring this function with external scope.
1082
7812ba2d
PE
10832011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1084
1085 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1086 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1087
cf7edc2a
AS
10882011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1089
1090 * editfns.c (Fformat): Correctly handle text properties on "%%".
1091
bd01620e
EZ
10922011-09-15 Eli Zaretskii <eliz@gnu.org>
1093
1094 * xterm.c (x_draw_composite_glyph_string_foreground):
1095 * w32term.c (x_draw_composite_glyph_string_foreground):
1096 * term.c (encode_terminal_code):
1097 * composite.c (composition_update_it, get_composition_id):
1098 * xdisp.c (get_next_display_element)
1099 (fill_composite_glyph_string): Add comments about special meaning
1100 of TAB characters in a composition.
1101
a02719a3
PE
11022011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1103
1104 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1105 This occurs when processing a multibyte format.
1106 Problem reported by Wolfgang Jenker.
a02719a3 1107
72589a3c
JB
11082011-09-15 Johan Bockgård <bojohan@gnu.org>
1109
1110 * xdisp.c (try_cursor_movement): Only check for exact match if
1111 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1112
1c14176c
PE
11132011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1114
1115 Remove unused external symbols.
1116 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1117 * xdisp.c (calc_pixel_width_or_height): Now static.
1118 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1119 * indent.c (check_display_width):
1120 * w32term.c: Fix comment to match code.
1121 * xterm.c, xterm.h (x_catching_errors): Remove.
1122
d2eea5b5
PE
11232011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1124
1125 * xselect.c: Use signed conversions more consistently (Bug#9498).
1126 (selection_data_to_lisp_data): Assume incoming selection data are
1127 signed integers, not unsigned. This is to be consistent with
1128 outgoing selection data, which was modified to use signed integers
1129 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1130 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1131 expects long, not unsigned long.
1132
46888499
EZ
11332011-09-14 Eli Zaretskii <eliz@gnu.org>
1134
1135 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1136 computation of loop end. Reported by Johan Bockgård
1137 <bojohan@gnu.org>.
1138
ef8ef9fb
CY
11392011-09-13 Chong Yidong <cyd@stupidchicken.com>
1140
1141 * frame.c (Fother_visible_frames_p): Function deleted.
1142
fa819fed
EZ
11432011-09-12 Eli Zaretskii <eliz@gnu.org>
1144
1145 * indent.c (compute_motion): Process display vector front to back
1146 rather than the other way around. (Bug#2496)
1147
2ba8e008
SM
11482011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1149
1150 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1151
20f53c69
CY
11522011-09-11 Chong Yidong <cyd@stupidchicken.com>
1153
1154 * minibuf.c (Fread_from_minibuffer): Doc fix.
1155
d562d7a4
EZ
11562011-09-11 Eli Zaretskii <eliz@gnu.org>
1157
1158 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1159 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1160
1c4d7f3d
LMI
11612011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1162
1163 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1164 value for non-existent files.
1165
b885bf36
EZ
11662011-09-11 Eli Zaretskii <eliz@gnu.org>
1167
1168 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1169 set its "size" to -1. This will set the modtime_size field of
1170 the corresponding buffer to -1, which is what
1171 verify-visited-file-modtime expects for files that do not exist.
1172 (Bug#9139)
1173
6612f0bf
PE
11742011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1175
1176 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1177 here ...
1178 * lisp.h: ... from here. push_key_description is no longer
1179 defined in keyboard.c, so its declaration should not be in
1180 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1181 logically belongs with push_key_description.
1182
dfb3f755
PE
11832011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1184
1185 * buffer.h: Include <sys/types.h> instead of <time.h>.
1186 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1187 Problem reported by Herbert J. Skuhra.
1188
3134906c
LMI
11892011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1190
1191 * xml.c (parse_region): Make the parsing work for
1192 non-comment-starting XML files again (bug#9144).
1193
8d903f4e
AS
11942011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1195
1196 * image.c (gif_load): Fix calculation of bottom and right corner.
1197 (Bug#9468)
1198
80ad64f4
EZ
11992011-09-10 Eli Zaretskii <eliz@gnu.org>
1200
1201 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1202 redisplay in small windows.
1203
208a048d
EZ
12042011-09-09 Eli Zaretskii <eliz@gnu.org>
1205
1206 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1207
9b1c252e
MR
12082011-09-08 Martin Rudalics <rudalics@gmx.at>
1209
1210 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1211 Operate on live windows only.
1212
2949f33b
JB
12132011-09-08 Juanma Barranquero <lekktu@gmail.com>
1214
1215 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1216
e08dcafd
EZ
12172011-09-07 Eli Zaretskii <eliz@gnu.org>
1218
1219 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1220 only under bidi iteration.
1221
115b96bd
JD
12222011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1223
1224 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1225
c8199d0f
PE
12262011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1227
1228 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1229 Without this fix, the command to link temacs failed due to an
1230 undefined symbol __builtin_isnan. This is because
1231 /usr/include/iso/math_c99.h #defines isnan(x) to
1232 __builtin_isnan(x), but the bundled gcc, which identifies itself
1233 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1234 a __builtin_isnan.
1235 * floatfns.c (isnan): #undef, and then #define to a clone of
1236 what's in data.c.
1237 (Fisnan): Always define, since it's always available now.
1238 (syms_of_floatfns): Always define isnan at the Lisp level.
1239
e39b275c 12402011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1241
1242 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1243
b2db44d9 12442011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1245
f4af5137 1246 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1247 The previous code assumed that file offsets (off_t values) fit in
1248 EMACS_INT variables, which is not true on typical 32-bit hosts.
1249 The code messed up by falsely reporting buffer overflow in cases
1250 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1251 when "big" contains more than 2**29 bytes, even though this
1252 inserts just one byte and does not overflow the buffer.
1253 (Finsert_file_contents): Store file offsets as off_t
1254 values, not as EMACS_INT values. Check for overflow when
1255 converting between EMACS_INT and off_t. When checking for
1256 buffer overflow or for overlap, take the offsets into account.
1257 Don't use EMACS_INT for small values where int suffices.
1258 When checking for overlap, fix a typo: ZV was used where
1259 ZV_BYTE was intended.
1260 (Fwrite_region): Don't assume off_t fits into 'long'.
1261 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1262
ecfc0a49
MA
12632011-09-05 Michael Albinus <michael.albinus@gmx.de>
1264
1265 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1266
6511acf2 12672011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1268
0999621a 1269 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1270
1271 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1272 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
1273 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1274 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
1275 (modify_event_symbol): Do not assume that the length of
1276 name_alist_or_stem is safe to alloca and fits in int.
1277 (Fexecute_extended_command): Likewise for function name and binding.
1278 (Frecursion_depth): Wrap around reliably on integer overflow.
1279 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1280 since some callers pass EMACS_INT values.
1281 (Fsingle_key_description): Don't crash if symbol name contains more
1282 than MAX_ALLOCA bytes.
1283 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1284 (get_minibuffer): Arg is now EMACS_INT, not int.
1285 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1286 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1287 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1288
2be7d702
PE
1289 * dbusbind.c (signature_cat): New function.
1290 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1291 Do not overrun buffer; instead, report string overflow.
1292
9d1df220
PE
1293 * dispnew.c (add_window_display_history): Don't overrun buffer.
1294 Truncate instead; this is OK since it's just a log.
1295
33ef5c64
PE
1296 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1297 even if the time zone offset is outlandishly large.
1298 Don't mishandle offset == INT_MIN.
1299
66c6fdd5
PE
1300 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1301 when creating daemon; the previous buffer-overflow check was incorrect.
1302
d749b01b
PE
1303 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1304 which has the guts of the old verror function.
1305
b5cd1905
PE
1306 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1307 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1308
6e1a67fb
PE
1309 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1310 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1311 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1312 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1313 length of string rather than counting it via multiple sprintfs;
1314 that's simpler and more reliable.
c21721cc
PE
1315 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1316 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1317 sprintf, in case result does not fit in int.
1318
c57b67fc
PE
1319 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1320 (fontset_from_font): Print it.
1321
8a401434
PE
1322 * frame.c (tty_frame_count): Now printmax_t, not int.
1323 (make_terminal_frame, set_term_frame_name): Print it.
1324 (x_report_frame_params): In X, window IDs are unsigned long,
1325 not signed long, so print them as unsigned.
1326 (validate_x_resource_name): Check for implausibly long names,
1327 and don't assume name length fits in 'int'.
1328 (x_get_resource_string): Don't blindly alloca invocation name;
1329 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1330 not fit in int.
1331
6e1a67fb
PE
1332 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1333 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1334 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1335
0df02bf3
PE
1336 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1337 Use esprintf, not sprintf, in case result does not fit in int.
1338
48e30793
PE
1339 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1340 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1341 it as a large positive number.
1342 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1343 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1344
a66ff6d8
PE
1345 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1346 in case result does not fit in int.
1347
aca216ff
PE
1348 * print.c (float_to_string): Detect width overflow more reliably.
1349 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1350 buffer overrun. Don't assume list length fits in 'int'. Treat
1351 print length of 0 as 0, not as infinity; to be consistent with other
1352 uses of print length in this function. Don't overflow print length
1353 index. Don't assume hash table size fits in 'long', or that
1354 vectorlike size fits in 'unsigned long'.
1355
31c286f7
PE
1356 * process.c (make_process): Use printmax_t, not int, to format
1357 process-name gensyms.
1358
55e5faa1
PE
1359 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1360
80f2e268
PE
1361 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1362 to avoid potential buffer overrun.
1363
670741ab
PE
1364 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1365 if X resource line is longer than 512 bytes.
1366
b7163a50
PE
1367 * xfns.c (x_window): Make sprintf buffer a bit bigger
1368 to avoid potential buffer overrun.
1369
ae58ff1f
PE
1370 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1371
c43c8a6a
PE
1372 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1373
3f8236f4
PE
13742011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1375
53e9fe90 1376 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1377 Without these, Emacs silently mishandles large integers sometimes.
1378 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1379 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1380
6511acf2
PE
1381 * xdisp.c (try_window_id): Check Emacs fixnum range before
1382 converting to 'int'.
806add1d 1383
6511acf2 1384 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1385 Check that an Emacs fixnum is in range before assigning it to 'int'.
1386 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1387 values converted from Emacs fixnums.
1388 (Frecenter): Don't wrap around a line count if it is out of 'int'
1389 range; instead, treat it as an extreme value.
1390 (Fset_window_configuration, compare_window_configurations):
1391 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1392
6511acf2
PE
1393 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1394 that can exceed INT_MAX. Check that EMACS_INT value is in range
1395 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1396 (match_limit): Don't assume that a fixnum can fit in 'int'.
1397
6511acf2 1398 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1399 exceed INT_MAX.
1400
6511acf2 1401 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1402 (Fvertical_motion): Don't wrap around LINES values that don't fit
1403 in 'int'. Instead, treat them as extreme values. This is good
1404 enough for windows, which can't have more than INT_MAX lines anyway.
1405
fcb901a7
LMI
14062011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1407
0f2f6b6d
LMI
1408 * Require libxml/parser.h to avoid compilation warning.
1409
fcb901a7
LMI
1410 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1411
1412 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1413 since this reportedly can destroy thread storage.
1414
6e20a0d4
CY
14152011-08-30 Chong Yidong <cyd@stupidchicken.com>
1416
1417 * syntax.c (find_defun_start): Update all cache variables if
1418 exiting early (Bug#9401).
1419
148ae00e
EZ
14202011-08-30 Eli Zaretskii <eliz@gnu.org>
1421
f6cfbd8f
EZ
1422 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1423
148ae00e
EZ
1424 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1425 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1426 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1427
1428 * term.c (tty_append_glyph): New function.
1429 (produce_stretch_glyph): Static function and its prototype deleted.
1430
a66cfb1c
SM
1431 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1432 Add prototypes.
148ae00e 1433
c4a07a4c
PE
14342011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1435
1436 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1437 when checking :margin (Bug#9390).
1438 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1439 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1440 so that the name doesn't mislead. All uses changed.
1441
6bc8cd65
JB
14422011-08-28 Johan Bockgård <bojohan@gnu.org>
1443
1444 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1445 set_tty_hooks.
1446
dca4927e
EZ
14472011-08-27 Eli Zaretskii <eliz@gnu.org>
1448
1449 * xdisp.c (move_it_to): Don't bail out early when reaching
1450 position beyond to_charpos, if we are scanning backwards.
1451 (move_it_vertically_backward): When DY == 0, make sure we get to
1452 the first character in the line after the newline.
1453
f2cad773
PE
14542011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1455
1456 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1457 (ccl_driver): Do not generate an out-of-range pointer.
1458 (Fccl_execute_on_string): Remove unnecessary check for
1459 integer overflow, noted by Stefan Monnier in
1460 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1461 Remove a FIXME that didn't need fixing.
1462 Simplify the newly-introduced buffer reallocation code.
1463
0cae2cdb
JB
14642011-08-27 Juanma Barranquero <lekktu@gmail.com>
1465
1466 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1467
5fc295a4 14682011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1469
70c60eb2 1470 Integer and memory overflow issues (Bug#9196).
726e0ab1 1471
d31850da
PE
1472 * doc.c (get_doc_string): Rework so that
1473 get_doc_string_buffer_size is the actual buffer size, rather than
1474 being 1 less than the actual buffer size; this makes xpalloc more
1475 convenient.
1476
a69fbedb
PE
1477 * image.c (x_allocate_bitmap_record, cache_image):
1478 * xselect.c (Fx_register_dnd_atom):
1479 Simplify previous changes by using xpalloc.
1480
fe5c5d37
PE
1481 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1482 since either will do and ptrdiff_t is convenient with xpalloc.
1483
0065d054
PE
1484 * charset.c (charset_table_size)
1485 (struct charset_sort_data.priority): Now ptrdiff_t.
1486 (charset_compare): Don't overflow if priorities differ greatly.
1487 (Fsort_charsets): Don't assume list length fits in int.
1488 Check for size-calculation overflow when allocating sort data.
1489 (syms_of_charset): Allocate an initial charset table that is
1490 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1491
1492 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1493
1494 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1495 The actual value is always <= INT_MAX, and leaving it unsigned made
1496 overflow checking harder.
1497
1498 * dispextern.h (struct glyph_matrix.rows_allocated)
1499 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1500 with xpalloc. The values are still always <= INT_MAX.
1501
1502 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1503
1504 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1505 (SAFE_NALLOCA): New macro.
1506
1507 * region-cache.c (struct boundary.pos, find_cache_boundary)
1508 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1509 (set_cache_region, invalidate_region_cache)
1510 (revalidate_region_cache, know_region_cache, region_cache_forward)
1511 (region_cache_backward, pp_cache):
1512 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1513 so that ptrdiff_t * can be passed to xpalloc.
1514 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1515 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1516 (pp_cache): Don't assume cache_len fits in int.
1517 * region-cache.h: Adjust extern decls to match.
1518
1519 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1520 EMACS_INT, since either will do, for xpalloc.
1521
1522 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1523 (xnmalloc, xnrealloc, xpalloc): New functions.
1524
726e0ab1
PE
1525 * bidi.c (bidi_shelve_header_size): New constant.
1526 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1527 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1528
51f30bc5 1529 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1530 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1531 (overlay_strings):
1532 Don't update size of array until after memory allocation succeeds,
1533 because xmalloc/xrealloc may not return.
0065d054
PE
1534 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1535 now that we have proper integer overflow checking.
1536 (record_overlay_string, overlay_strings): Catch overflows when
1537 calculating size of overlay_str_buf.
726e0ab1 1538
0065d054
PE
1539 * callproc.c (Fcall_process): Check for size overflow when
1540 calculating size of args2.
1541 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1542 Normally we prefer signed values, but sticking with ptrdiff_t would
1543 require adding more-complicated checks.
726e0ab1
PE
1544
1545 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1546 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1547 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1548 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1549
1550 * character.c (Fstring): Check for size-calculation overflow.
1551
1552 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1553 unnecessary integer overflow. Check for size overflow.
1554 (encode_coding_object): Don't update size until xmalloc succeeds.
1555
1556 * composite.c (get_composition_id): Check for overflow in glyph
1557 length calculations.
1558
1559 Integer and memory overflow fixes for display code.
1560 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1561 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1562 (scrolling_window): Check for overflow in size calculations.
1563 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1564 Don't assume glyph table len fits in int.
1565 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1566 (row_table_size): Now ptrdiff_t, not int.
1567 (scrolling_window): Avoid overflow in size calculations.
1568 Don't update size until allocation succeeds.
1569 * fns.c (concat): Check for overflow in size calculations.
1570 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1571 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1572 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1573
1574 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1575 (get_doc_string): Check for size calculation overflow.
1576 Don't update size until allocation succeeds.
1577 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1578 EMACS_INT, where ptrdiff_t will do.
1579 (Fsubstitute_command_keys): Check for string overflow.
1580
1581 * editfns.c (set_time_zone_rule): Don't assume environment length
1582 fits in int.
1583 (message_length): Now ptrdiff_t, not int.
1584 (Fmessage_box): Don't update size until allocation succeeds.
1585 Don't assume message length fits in int.
1586 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1587
0065d054
PE
1588 * emacs.c (main): Do not reallocate argv, since there is a null at
1589 the end that can be overwritten, and this way there's no need to
1590 worry about size-calculation overflow.
1591 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1592
1593 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1594 alloc succeeds.
1595 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1596
1597 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1598 (x_set_scroll_bar_width, x_figure_window_size):
1599 Check for integer overflow.
1600 (x_set_alpha): Do not assume XINT fits in int.
1601
1602 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1603 This is for the members text_lines, text_cols, total_lines, total_cols,
1604 where the system imposes an 'int' limit.
1605
1606 * fringe.c (Fdefine_fringe_bitmap):
1607 Don't update size until alloc works.
1608
1609 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1610 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1611
1612 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1613 Check for size-calculation overflow.
1614 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1615 do, as we prefer signed integers.
1616 (id_to_widget.max_size, id_to_widget.used)
1617 (xg_store_widget_in_map, xg_remove_widget_from_map)
1618 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1619 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1620 Use and return ptrdiff_t, not int.
1621 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1622 * gtkutil.h: Change prototypes to match the above.
1623
1624 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1625 are duplicate now that they've been promoted to lisp.h.
1626 (x_allocate_bitmap_record, x_alloc_image_color)
1627 (make_image_cache, cache_image, xpm_load):
1628 Don't update size until alloc is done.
1629 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1630 (x_detect_edges):
3256efce 1631 Check for size calculation overflow.
726e0ab1
PE
1632 (ct_colors_allocated_max): New constant.
1633 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1634 overflow.
3256efce 1635
726e0ab1
PE
1636 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1637 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1638 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1639 Use ptrdiff_t, not int, to count maps.
1640 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1641 calculations. Don't update size until allocation succeeds.
1642 Redo calculations to avoid overflow.
726e0ab1
PE
1643 * keyboard.h: Change prototypes to match the above.
1644
1645 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1646 to count maps.
1647 (current_minor_maps): Check for size calculation overflow.
1648 * keymap.h: Change prototypes to match the above.
1649
1650 * lread.c (read1, init_obarray): Don't update size until alloc done.
1651
1652 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1653 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1654
726e0ab1
PE
1655 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1656 Now ptrdiff_t, not int.
1657 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1658 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1659
1660 * process.c (Fnetwork_interface_list): Check for overflow
1661 in size calculation.
1662
1663 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1664
1665 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1666 overflow. Don't bother calling xmalloc when xrealloc will do.
1667
1668 * search.c (Freplace_match): Check for size calculation overflow.
1669 (Fset_match_data): Don't assume list lengths fit in 'int'.
1670
1671 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1672 for command line length. Do not attempt to address one before the
1673 beginning of an array, as that's not portable.
1674
1675 * term.c (max_frame_lines): Remove; unused.
1676 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1677 not int.
1678 (encode_terminal_code, calculate_costs): Check for size
1679 calculation overflow.
1680 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1681 table lengths and related sizes. Don't update size until alloc
1682 done. Redo calculations to avoid overflow.
1683 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1684
1685 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1686 subtracting pointers.
1687 (gobble_line): Check for overflow more carefully. Don't update size
1688 until alloc done.
1689
1690 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1691 Don't update size until alloc done.
1692 Redo size calculations to avoid overflow.
1693 Check for size calculation overflow.
0065d054 1694 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1695
1696 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1697 Use ptrdiff_t, not int, for sizes.
1698 (store_mode_line_noprop_char): Don't update size until alloc done.
1699
0065d054
PE
1700 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1701 Use ptrdiff_t, not int, for sizes.
1702 (Finternal_make_lisp_face, cache_face):
1703 Check for size calculation overflow.
1704 (cache_face): Treat size calculation overflows as if they were
1705 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1706
1707 * xfns.c (x_encode_text, x_set_name_internal)
1708 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1709 sizes, since they can exceed INT_MAX in size. Check for size
1710 calculation overflow.
1711
0065d054
PE
1712 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1713 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1714 Don't update size until alloc done.
1715
0065d054 1716 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1717 as sprintf is limited to int lengths.
1d526e2f 1718
252c5ee1
PE
1719 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1720 (X_LONG_MIN): New macros.
864d7ce7
PE
1721 Use them to make the following changes clearer.
1722 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1723 This change doesn't affect the value now, but it may help remind
1724 future maintainers not to raise the value too much later.
1725 (SELECTION_QUANTUM): Remove, replacing with ...
1726 (selection_quantum): ... new function, which avoids overflow.
1727 All uses changed.
1728 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1729 assumption that selection length fits in 'int'.
1730 (x_reply_selection_request, x_handle_selection_request)
1731 (x_get_window_property, receive_incremental_selection)
1732 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1733 (lisp_data_to_selection_data, clean_local_selection_data):
1734 Use ptrdiff_t, not int, to record length of selection.
1735 (x_reply_selection_request, x_get_window_property)
1736 (receive_incremental_selection, x_property_data_to_lisp):
1737 Redo calculations to avoid overflow.
1738 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1739 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1740 something.
1741 (x_get_window_property, receive_incremental_selection)
1742 (lisp_data_to_selection_data, x_property_data_to_lisp):
1743 Check for size-calculation overflow.
1744 (x_get_window_property, receive_incremental_selection)
1745 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1746 Don't store size until memory allocation succeeds.
1747 (x_get_window_property): Plug memory leak on memory exhaustion.
1748 Don't double-block input; malloc is safe here. Don't assume 2**34
1749 - 4 fits in unsigned long. Add an xassert to check
1750 XGetWindowProperty overflow. Be more careful about overflow
1751 calculations, and distinguish size from memory overflow better.
1752 (receive_incremental_selection): When tracing, don't assume
1753 unsigned int is less than INT_MAX.
1754 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1755 harmful) conversions of unsigned short to int.
1756 (lisp_data_to_selection_data): Don't assume that integers
1757 in the range -65535 through -1 fit in an X unsigned short.
1758 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1759 result parameters unless successful. Rely on cons_to_unsigned
1760 to report problems with elements; the old code wasn't right anyway.
1761 (x_check_property_data): Check for int overflow; we cannot use
1762 a wider type due to X limits.
1763 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1764
726e0ab1 1765 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1766
0065d054
PE
1767 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1768 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1769 (x_color_cells): Don't store size until memory allocation succeeds.
1770 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1771 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1772 (x_term_init): Don't assume length fits in int (sprintf is limited
1773 to int size).
bc18e09d 1774
ebfa62c0
PE
1775 Use ptrdiff_t for composition IDs.
1776 * character.c (lisp_string_width):
1777 * composite.c (composition_table_size, n_compositions)
1778 (get_composition_id, composition_gstring_from_id):
1779 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1780 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1781 * window.c (Frecenter):
1782 Use ptrdiff_t, not int, for composition IDs.
1783 * composite.c (get_composition_id): Check for integer overflow.
1784 * composite.h: Adjust prototypes to match the above changes.
1785
d3411f89
PE
1786 Use ptrdiff_t for hash table indexes.
1787 * category.c (hash_get_category_set):
1788 * ccl.c (ccl_driver):
1789 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1790 * coding.c (coding_system_charset_list, detect_coding_system):
1791 * coding.h (struct coding_system.id):
1792 * composite.c (get_composition_id, gstring_lookup_cache):
1793 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1794 * image.c (xpm_get_color_table_h):
1795 * lisp.h (hash_lookup, hash_put):
1796 * minibuf.c (Ftest_completion):
1797 Use ptrdiff_t for hash table indexes, not int (which is too
1798 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1799 32-bit --with-wide-int hosts).
1800
e097a6fa
PE
1801 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1802 Add a FIXME comment about memory leaks.
1803 (syms_of_charset): Don't assume xmalloc returns.
1804
5637687f
PE
1805 Don't assume that stated character widths fit in int.
1806 * character.c (Fchar_width, c_string_width, lisp_string_width):
1807 * character.h (CHAR_WIDTH):
1808 * indent.c (MULTIBYTE_BYTES_WIDTH):
1809 Use sanitize_char_width to avoid undefined and/or bad behavior
1810 with outlandish widths.
a66cfb1c 1811 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1812 now that we have two such functions. All uses changed.
1813 (sanitize_char_width): New inline function.
1814
a2271ba2
PE
1815 Don't assume that tab-width fits in int.
1816 * character.h (sanitize_width): New inline function.
1817 (SANE_TAB_WIDTH): New macro.
1818 (ASCII_CHAR_WIDTH): Use it.
1819 * indent.c (sane_tab_width): Remove. All uses replaced by
1820 SANE_TAB_WIDTH (current_buffer).
1821 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1822
18c52557
PE
1823 * fileio.c: Integer overflow issues with file modes.
1824 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1825
caeeedc1
PE
1826 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1827 Remove unreachable code.
1828 (read_hex, load_charset_map_from_file): Check for integer overflow.
1829
50849c52
PE
1830 * xterm.c: don't go over XClientMessageEvent limit
1831 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1832 (x_send_scroll_bar_event): Likewise. Check that the size does not
1833 exceed limits imposed by XClientMessageEvent, as well as the usual
1834 ptrdiff_t and size_t limits.
1835
b13995db
PE
1836 * keyboard.c: Overflow, signedness and related fixes.
1837 (make_lispy_movement): Use same integer type in forward decl
1838 that is used in the definition.
1839 (read_key_sequence, keyremap_step):
1840 Change bufsize argument back to int, undoing my 2011-03-30 change.
1841 We prefer signed types, and int is wide enough here.
1842 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1843 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1844 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1845 length, not size_t. Use ptrdiff_t for index, not int.
1846 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1847 possibility of integer overflow.
1848
13464394
PE
1849 Overflow, signedness and related fixes for images.
1850
1851 * dispextern.h (struct it.stack[0].u.image.image_id)
1852 (struct_it.image_id, struct image.id, struct image_cache.size)
1853 (struct image_cache.used, struct image_cache.ref_count):
1854 * gtkutil.c (update_frame_tool_bar):
1855 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1856 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1857 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1858 * nsmenu.m (update_frame_tool_bar):
1859 * xdisp.c (calc_pixel_width_or_height):
1860 * xfns.c (image_cache_refcount):
1861 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1862 on typical 64-bit hosts.
1863
1864 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1865 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1866 Omit unnecessary casts to int.
1867 (parse_image_spec): Check that integers fall into 'int' range
1868 when the callers expect that.
1869 (image_ascent): Redo ascent calculation to avoid int overflow.
1870 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1871 (lookup_image): Remove unnecessary tests.
1872 (xbm_image_p): Locals are now of int, not EMACS_INT,
1873 since parse_image_check makes sure they fit into int.
1874 (png_load, gif_load, svg_load_image):
1875 Prefer int to unsigned where either will do.
1876 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1877 old tiff_error_handler and tiff_warning_handler.
1878 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1879 stack buffer overflows. It uses only the features of vsnprintf
1880 that are common to both POSIX and native Microsoft.
1881 (tiff_error_handler, tiff_warning_handler): Use it.
1882 (tiff_load, gif_load, imagemagick_load_image):
1883 Don't assume :index value fits in 'int'.
1884 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1885 (imagemagick_load_image): Check that crop parameters fit into
1886 the integer types that MagickCropImage accepts. Don't assume
1887 Vimagemagick_render_type has a nonnegative value. Don't assume
1888 size_t fits in 'long'.
1889 (gs_load): Use printmax_t to print the widest integers possible.
1890 Check for integer overflow when computing image height and width.
1891
c11821d4
EZ
18922011-08-26 Eli Zaretskii <eliz@gnu.org>
1893
1894 * xdisp.c (redisplay_window): Don't force window start if point
1895 will be invisible in the resulting window. (Bug#9324)
1896
0c95fcf7
EZ
18972011-08-25 Eli Zaretskii <eliz@gnu.org>
1898
1899 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1900 the display spec is of the form `(space ...)'.
1901 (handle_display_spec): Return the value returned by
1902 handle_single_display_spec, not just 1 or zero.
1903 (handle_single_display_spec): If the display spec is of the form
1904 `(space ...)', and specifies display in the text area, return 2
1905 rather than 1.
fee65a97 1906 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1907 accurately, and prefer exact match for point under bidi.
1908 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1909
1910 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1911 into disp_prop; all users changed.
1912
1913 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1914 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1915 for the text covered by the display property.
1916
e4ed06f1
CY
19172011-08-25 Chong Yidong <cyd@stupidchicken.com>
1918
1919 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1920 Change return value to nil.
1921 (Frecord_buffer): Delete unused function.
1922
f67cdd7f
EZ
19232011-08-24 Eli Zaretskii <eliz@gnu.org>
1924
5980d4c6
EZ
1925 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1926 buffers, return left-to-right.
8610fe8b
EZ
1927 (set_cursor_from_row): Consider candidate row a win if its glyph
1928 represents a newline and point is on that newline. Fixes cursor
1929 positioning on the newline at EOL of R2L text within L2R
1930 paragraph, and vice versa.
1931 (try_cursor_movement): Check continued rows, in addition to
1932 continuation rows. Fixes unwarranted scroll when point enters a
1933 continued line of R2L text within an L2R paragraph, or vice versa.
1934 (cursor_row_p): Consider the case of point being equal to
1935 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1936 from the end of a short line to the beginning of a continued line
1937 of R2L text within L2R paragraph.
1938 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1939 composed characters.
5980d4c6 1940
f67cdd7f
EZ
1941 * bidi.c (bidi_check_type): Use xassert.
1942 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1943 members.
1944
bca633fb
EZ
19452011-08-23 Eli Zaretskii <eliz@gnu.org>
1946
1947 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1948 a character.
1949
4a5885a7
CY
19502011-08-23 Chong Yidong <cyd@stupidchicken.com>
1951
1952 * nsfont.m (ns_otf_to_script): Fix typo.
1953
0902a04e
KH
19542011-08-22 Kenichi Handa <handa@m17n.org>
1955
1956 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1957 extra slot even if the purpose is char-code-property-table.
1958
1a2e6670
EZ
19592011-08-23 Eli Zaretskii <eliz@gnu.org>
1960
8ddde651
EZ
1961 * xdisp.c (redisplay_window): When computing centering_position,
1962 account for the height of the header line. (Bug#8874)
1963
425cc014
EZ
1964 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1965 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1966 candidate is selected by the mouse, and that candidate has a
1967 composed character under the mouse.
1968
1a2e6670
EZ
1969 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1970 coordinates reported by pos-visible-in-window-p for a composed
1971 character in column zero.
1972
8b76d6f8
SM
19732011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1974
1975 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1976
dac347dd
EZ
19772011-08-22 Eli Zaretskii <eliz@gnu.org>
1978
1979 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1980 consider it a hit if to_charpos is anywhere in the range of the
1981 composed buffer positions.
1982
e013fb34
CY
19832011-08-22 Chong Yidong <cyd@stupidchicken.com>
1984
1985 * image.c (gif_load): Don't assume that each subimage has the same
1986 dimensions as the base image. Handle disposal method that is
1987 "undefined" by the gif spec (Bug#9335).
1988
bd1ba3e8
CY
19892011-08-20 Chong Yidong <cyd@stupidchicken.com>
1990
1991 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1992 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1993
54a1215b
EZ
19942011-08-19 Eli Zaretskii <eliz@gnu.org>
1995
823564e5
EZ
1996 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1997 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1998 from an Org mode buffer to a Speedbar frame.
1999
54a1215b
EZ
2000 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2001 a composition, take its buffer position from IT->cmp_it.charpos.
2002 Fixes cursor positioning at the beginning of a line that begins
2003 with a composed character.
2004
9778ebcc
EZ
20052011-08-18 Eli Zaretskii <eliz@gnu.org>
2006
0be6ee06
EZ
2007 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2008 character bidirectional type, use STRONG_L instead. Fixes crashes
2009 in a buffer produced by `describe-categories'.
2010
9778ebcc
EZ
2011 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2012 members before the level stack, so they would be saved and
2013 restored when copying iterator state. Fixes incorrect reordering
2014 around TABs covered by display properties.
2015
156bffbe
AS
20162011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2017
2018 * process.c (Fnetwork_interface_list): Correctly determine buffer
2019 size.
2020
72ad093b
CY
20212011-08-17 Chong Yidong <cyd@stupidchicken.com>
2022
2023 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2024 (internal_condition_case_2, internal_condition_case_n):
2025 Remove unnecessary aborts (Bug#9081).
72ad093b 2026
35774242
EZ
20272011-08-17 Eli Zaretskii <eliz@gnu.org>
2028
2029 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2030 has no `load' handler, try opening the file locally. (Bug#9311)
2031
db76dd85
KB
20322011-08-16 Ken Brown <kbrown@cornell.edu>
2033
2034 * gmalloc.c: Expand comment.
2035
b215eee5
EZ
20362011-08-16 Eli Zaretskii <eliz@gnu.org>
2037
2038 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2039 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2040
a4579d33
KB
20412011-08-16 Ken Brown <kbrown@cornell.edu>
2042
2043 Fix memory allocation problems in Cygwin build (Bug#9273).
2044
2045 * unexcw.c ( __malloc_initialized): Declare external variable.
2046 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2047
8b76d6f8
SM
2048 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2049 New variables.
a4579d33
KB
2050 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2051 dumped emacs.
2052 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2053 in the static heap.
2054 [CYGWIN] (special_realloc): New function.
2055 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2056 requests to realloc storage in the static heap.
2057
3ebec551
PE
20582011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2059
2060 * bidi.c (bidi_initialize): Remove unused local.
2061
9fd8be00
EZ
20622011-08-15 Eli Zaretskii <eliz@gnu.org>
2063
474a8465
EZ
2064 * biditype.h: File removed.
2065
2066 * bidimirror.h: File removed.
2067
2068 * deps.mk (bidi.o): Remove biditype.h and
2069 bidimirror.h.
2070
2071 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
2072 bidimirror.h.
2073
2074 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2075
2076 * chartab.c: Improve commentary for the uniprop_table API.
2077
32413314
EZ
2078 * bidi.c (bidi_paragraph_init): Support zero value of
2079 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2080 (bidi_initialize): Use uniprop_table instead of including
2081 biditype.h and bidimirror.h.
32413314 2082
9fd8be00
EZ
2083 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2084 coordinates of the iterator when restoring from ppos_it.
2085 (Bug#9296)
2086
5cf2b69b
KH
20872011-08-14 Kenichi Handa <handa@m17n.org>
2088
2089 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2090 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2091
daf17d00
EZ
20922011-08-14 Eli Zaretskii <eliz@gnu.org>
2093
2094 * xdisp.c (move_it_in_display_line_to): Don't invoke
2095 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2096 ppos_it. Fixes vertical cursor motion when line beginning is
2097 covered by an image. (Bug#9296)
2098
08e3161a
JD
20992011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2100
2101 * nsterm.h (ns_run_ascript): Declare.
2102 (NSAPP_DATA2_RUNASSCRIPT): Define.
2103
2104 * nsfns.m (as_script, as_result, as_status): New static variables.
2105 (ns_run_ascript): New function.
5e617bc2 2106 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2107 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2108 the event loop. Get status from as_status (Bug#7276).
2109
2110 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2111 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2112 the event loop (Bug#7276).
2113
a3720aa2
AS
21142011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2115
2116 * gnutls.c (QCgnutls_bootprop_priority)
2117 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2118 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2119 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2120 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2121 (QCgnutls_bootprop_verify_hostname_error)
2122 (QCgnutls_bootprop_callbacks_verify): Rename from
2123 Qgnutls_bootprop_..., all uses changed.
2124
2125 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2126 uses changed.
2127
0a0d27fb
PE
21282011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2129
19d5c50c
PE
2130 * xfaces.c (Qframe_set_background_mode): Now static.
2131 * dispextern.h (Qframe_set_background_mode): Remove decl.
2132
0a0d27fb
PE
2133 * process.c (Fnetwork_interface_info): Declare local only if needed.
2134
377538cb
JD
21352011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2136
2137 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2138 (Fnetwork_interface_list): Allocate in increments of bytes instead
2139 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2140 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2141 sockaddr.
2142 (struct ifflag_def): notrailers is smart on OSX.
2143 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2144 Get hardware address with getifaddrs if available.
2145
08fff70c
EZ
21462011-08-12 Eli Zaretskii <eliz@gnu.org>
2147
2148 * xdisp.c (iterate_out_of_display_property): xassert that
2149 IT->position is set to within IT->object's boundaries. Break from
2150 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2151 when IT->position is set up wrongly due to some bug.
2152 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2153 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2154 entry. Force push_it to save on the stack the current
2155 buffer/string position, to be restored by pop_it. Fix flags in
2156 the iterator structure wrt the object coming from a display
2157 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2158 properties. (Bug#9284)
2159
7be1c708 21602011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2161
7be1c708
CY
2162 * fontset.c (fontset_get_font_group): Add proper type checks.
2163 (Bug#9172)
aac0c6e3 2164
7be1c708 21652011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2166
7be1c708
CY
2167 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2168 and LC_VERSION_MIN_MACOSX.
2169 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2170 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2171
97bb72a6
EZ
21722011-08-08 Eli Zaretskii <eliz@gnu.org>
2173
2174 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2175 no-display-properties-and-no-overlays under bidi display.
2176 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2177 properties and overlays.
97bb72a6 2178
d5617611
CY
21792011-08-08 Chong Yidong <cyd@stupidchicken.com>
2180
37e11a63
CY
2181 * editfns.c (Fset_time_zone_rule): Document relationship with the
2182 setenv function.
2183
d5617611
CY
2184 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2185 the font entity extracted from the cache (Bug#8109).
2186
58872834
CY
21872011-08-07 Chong Yidong <cyd@stupidchicken.com>
2188
2189 * composite.c (autocmp_chars): Don't reset point. That is done by
2190 restore_point_unwind (Bug#5984).
2191
75bfc667
JL
21922011-08-07 Juri Linkov <juri@jurta.org>
2193
2194 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2195 to show the arg `TIME' instead of `TIMEVAL'.
2196
d1410150
EZ
21972011-08-06 Eli Zaretskii <eliz@gnu.org>
2198
2199 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2200 display property strides EOL and includes a newline, as in
2201 longlines-mode. (Bug#9254)
75b771e4
EZ
2202 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2203 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2204
2205 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2206 is non-zero, even if the data buffer is NULL. Fixes a crash in
2207 vertical-motion with longlines-mode. (Bug#9254)
2208
35928349
EZ
22092011-08-05 Eli Zaretskii <eliz@gnu.org>
2210
ec7cc85b
EZ
2211 * bidi.c <bidi_cache_total_alloc>: Now static.
2212 (bidi_initialize): Initialize bidi_cache_total_alloc.
2213
8b76d6f8 2214 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2215 cache. (Bug#9221)
2216
2217 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2218 amount allocated this far in `bidi_cache_total_alloc'.
2219 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2220 non-zero, only free the data buffer without restoring the cache
2221 contents. All callers changed.
2222
2223 * dispextern.h (bidi_unshelve_cache): Update prototype.
2224
2225 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2226 (move_it_in_display_line, move_it_to)
2227 (move_it_vertically_backward, move_it_by_lines): Replace the call
2228 to xfree to an equivalent call to bidi_unshelve_cache.
2229 (move_it_in_display_line_to): Fix logic of returning
412b6358 2230 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2231
e2e2423b
EZ
22322011-08-05 Eli Zaretskii <eliz@gnu.org>
2233
2234 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2235 came from a string character with a `cursor' property. (Bug#9229)
2236
ae9e757a
JD
22372011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2238
2239 * Makefile.in (LIB_PTHREAD): New variable.
2240 (LIBES): Add LIB_PTHREAD (Bug#9216).
2241
2242 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2243 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2244
213bd7f2
AS
22452011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2246
2247 * regex.c (re_iswctype): Remove some redundant boolean
2248 conversions.
2249
99aaf75f
JD
22502011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2251
2252 * xterm.c (x_find_topmost_parent): New function.
2253 (x_set_frame_alpha): Find topmost parent window with
2254 x_find_topmost_parent and set the property there also (bug#9181).
2255 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2256
c74e9d86
PE
22572011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2258
2259 * callproc.c (Fcall_process): Avoid vfork clobbering
2260 the local vars buffer, coding_systems, current_dir.
2261
640c8776
SM
22622011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2263
2264 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2265
f26d0e4c
PE
22662011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2267
8a10d76c
PE
2268 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2269 so that it is not optimized away.
2270
f26d0e4c
PE
2271 * xdisp.c (compute_display_string_pos): Remove unused local.
2272
55439c61
EZ
22732011-08-02 Eli Zaretskii <eliz@gnu.org>
2274
2275 Fix slow cursor motion and scrolling in large buffers with
2276 selective display, like Org Mode buffers. (Bug#9218)
2277
2278 * dispextern.h (struct bidi_it): New member disp_prop_p.
2279
2280 * xdisp.c: Remove one-slot cache of display string positions.
2281 (compute_display_string_pos): Accept an additional argument
5e617bc2 2282 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2283 for a display string or property. If found, set DISP_PROP_P
2284 non-zero.
2285
2286 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2287 DISP_PROP_P, and pass it to compute_display_string_pos.
2288 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2289 non-zero. All callers of bidi_fetch_char changed.
2290
fb33fa43
SM
22912011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2292
2293 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2294
b099e063
DM
22952010-12-03 Don March <don@ohspite.net>
2296
2297 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2298 last character M-[char] is translated to ESC [char] (bug#7541).
2299
5cc7f7af
KH
23002011-08-02 Kenichi Handa <handa@m17n.org>
2301
d0fffa3f 2302 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2303
2304 * chartab.c (uniprop_table): Make it non-static.
2305
525d5e6e
EZ
23062011-08-01 Eli Zaretskii <eliz@gnu.org>
2307
2308 * xdisp.c (forward_to_next_line_start): Accept additional argument
2309 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2310 on the newline.
2311 (reseat_at_next_visible_line_start): Use the bidi iterator state
2312 returned by forward_to_next_line_start to restore the state of
2313 it->bidi_it after backing up to previous newline. (Bug#9212)
2314
31011111
AS
23152011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2316
2317 * regex.c (re_comp): Protoize.
2318 (re_exec): Fix return type.
2319 (regexec): Fix type of `ret'. (Bug#9203)
2320
476371c4
PE
23212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2322
e5d76069
PE
2323 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2324 This is needed if max-image-size is a floating-point number.
2325
9a79b20c
AS
23262011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2327
2328 * print.c (print_object): Print empty symbol as ##.
2329
2330 * lread.c (read1): Read ## as empty symbol.
2331
d8c2fa78
AA
23322011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2333
2334 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2335 setting frame foreground color (Bug#9175).
2336 (x_set_background_color): Likewise.
2337
ffe57a7a
AA
2338 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2339 contents (Bug#9176).
2340 (EmacsTooltip -init): Remove bezels and add shadows to
2341 tooltip windows.
2342
bf3492a5
AA
2343 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2344 or scroll bar (Bug#8470).
2345
d55e9c53
AA
2346 * nsfont.m (nsfont_open): Remove assignment to voffset and
2347 unnecessary vars hshink, expand, hd, full_height, min_height.
2348 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2349
2350 * nsterm.h (nsfont_info): Remove voffset field.
2351
d8c2fa78 23522011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2353
2354 Implement strike-through and overline on NextStep (Bug#8863).
2355
2356 * nsfont.m (nsfont_open): Use underline position provided by font,
2357 instead of hard-coded value of 2.
2358 (nsfont_draw): Call ns_draw_text_decoration instead.
2359
2360 * nsterm.h: Add declaration for ns_draw_text_decoration.
2361
2362 * nsterm.m (ns_draw_text_decoration): New function for drawing
2363 underline, overline, and strike-through.
2364 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2365 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2366 accommodate underlining, etc.
4843aac3 2367
4cc60b9b
EZ
23682011-07-28 Eli Zaretskii <eliz@gnu.org>
2369
bc7ece87
EZ
2370 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2371 default.
4cc60b9b 2372
476371c4
PE
23732011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2374
66606eea
PE
2375 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2376 Without this fix, if a signal arrives just after memory fills up,
2377 'malloc' might be invoked reentrantly.
2378
476371c4
PE
2379 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2380 In other words, assume that every image size is allowed, on non-X
2381 hosts. This assumption is probably wrong, but it lets Emacs compile.
2382
f3fcc40d
AS
23832011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2384
2385 * regex.c (re_iswctype): Convert return values to boolean.
2386
350c992f
EZ
23872011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2388
2389 * xdisp.c (compute_display_string_pos): Don't use cached display
2390 string position if the buffer had its restriction changed.
2391 (Bug#9184)
2392
5266b4bb
PE
23932011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2394
2395 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2396
2573a837 23972011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2398
41f55ccd 2399 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2400
39e378da
PE
2401 * bidi.c: Integer size and overflow fixes.
2402 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2403 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2404 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2405 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2406 (bidi_find_other_level_edge):
2407 Use ptrdiff_t instead of EMACS_INT where either will do.
2408 This works better on 32-bit hosts configured --with-wide-int.
2409 (bidi_cache_ensure_space): Check for size-calculation overflow.
2410 Use % rather than repeated addition, for better worst-case speed.
2411 Don't set bidi_cache_size until after xrealloc returns, because it
2412 might not return.
2413 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2414 (bidi_cache_ensure_space): Also check that the bidi cache size
2415 does not exceed that of the largest Lisp string or buffer. See Eli
2416 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2417
5e927815
PE
2418 * alloc.c (__malloc_size_t): Remove.
2419 All uses replaced by size_t. See Andreas Schwab's note
2420 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2421
ca4aa935
PE
2422 * image.c: Improve checking for integer overflow.
2423 (check_image_size): Assume that f is nonnull, since
2424 it is always nonnull in practice. This is one less thing to
2425 worry about when checking for integer overflow later.
2426 (x_check_image_size): New function, which checks for integer
2427 overflow issues inside X.
2428 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2429 This removes the need for a memory_full check.
2430 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2431 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2432 (xbm_read_bitmap_data): Change locals back to 'int', since
2433 their values must fit in 'int'.
2434 (xpm_load_image, png_load, tiff_load):
2435 Invoke x_create_x_image_and_pixmap earlier,
2436 to avoid much needless work if the image is too large.
2437 (tiff_load): Treat overly large images as if
2438 x_create_x_image_and_pixmap failed, not as malloc failures.
2439 (gs_load): Use x_check_image_size.
2440
5f8f9cc2
PE
2441 * gtkutil.c: Omit integer casts.
2442 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2443 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2444
5adf60bc
PE
2445 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2446
c8907a93
PE
2447 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2448 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2449 would wrongly return t on a 64-bit host.
2450
e3c25c68
PE
2451 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2452 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2453 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2454 and therefore cause GCC to emit a bogus diagnostic in some cases.
2455
3f791afe
PE
2456 * image.c: Integer signedness and overflow and related fixes.
2457 This is not an exhaustive set of fixes, but it's time to
2458 record what I've got.
2459 (lookup_pixel_color, check_image_size): Remove redundant decls.
2460 (check_image_size): Don't assume that arbitrary EMACS_INT values
2461 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2462 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2463 (tiff_load, imagemagick_load_image):
2464 Check for overflow in size calculations.
2465 (x_create_x_image_and_pixmap): Remove unnecessary test for
2466 xmalloc returning NULL; that can't happen.
2467 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2468 (xpm_color_bucket): Use better integer hashing function.
2469 (xpm_cache_color): Don't possibly over-allocate memory.
2470 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2471 (gif_memory_source):
2472 Use ptrdiff_t, not int or size_t, to record sizes.
2473 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2474 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2475 either works, as we prefer signed integers.
2476 (tiff_read_from_memory, tiff_write_from_memory):
2477 Return tsize_t, not size_t, since that's what the TIFF API wants.
2478 (tiff_read_from_memory): Don't fail simply because the read would
2479 go past EOF; instead, return a short read.
2480 (tiff_load): Omit no-longer-needed casts.
2481 (Fimagemagick_types): Don't assume size fits into 'int'.
2482
3cc5a532
PE
2483 Improve hashing quality when configured --with-wide-int.
2484 * fns.c (hash_string): New function, taken from sxhash_string.
2485 Do not discard information about ASCII character case; this
2486 discarding is no longer needed.
2487 (sxhash-string): Use it. Change sig to match it. Caller changed.
2488 * lisp.h: Declare it.
2489 * lread.c (hash_string): Remove, since we now use fns.c's version.
2490 The fns.c version returns a wider integer if --with-wide-int is
2491 specified, so this should help the quality of the hashing a bit.
2492
b312a492
PE
2493 * emacs.c: Integer overflow minor fix.
2494 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2495 Define only if GNU_LINUX.
2496 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2497
dfd153ae
PE
2498 * dispnew.c: Integer signedness and overflow fixes.
2499 Remove unnecessary forward decls, that were a maintenance hassle.
2500 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2501 All uses changed.
2502 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2503 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2504 (prepare_desired_row, line_draw_cost):
2505 Use int, not unsigned, where either works.
2506 (save_current_matrix, restore_current_matrix):
2507 Use ptrdiff_t, not size_t, where either works.
2508 (init_display): Check for overflow more accurately, and without
2509 relying on undefined behavior.
2510
a81d11a3
PE
2511 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2512 Remove, replacing with the new symbols in lisp.h. All uses changed.
2513 * fileio.c (make_temp_name):
2514 * filelock.c (lock_file_1, lock_file):
2515 * xdisp.c (message_dolog):
2516 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2517 Use pMd etc. instead.
2518 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2519 replacing the pWIDE etc. symbols removed from editfns.c.
2520
3300e6fd
PE
2521 * keyboard.h (num_input_events): Now uintmax_t.
2522 This is (very slightly) less likely to mess up due to wraparound.
2523 All uses changed.
2524
fd05c7e9
PE
2525 * buffer.c: Integer signedness fixes.
2526 (alloc_buffer_text, enlarge_buffer_text):
2527 Use ptrdiff_t rather than size_t when either will do, as we prefer
2528 signed integers.
2529
903fe15d
PE
2530 * alloc.c: Integer signedness and overflow fixes.
2531 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2532 (__malloc_size_t): Default to size_t, not to int.
2533 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2534 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2535 Prefer ptrdiff_t to size_t when either would do, as we prefer
2536 signed integers.
2537 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2538 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2539 Now const. Initialize with values that are in range even if char
2540 is signed.
2541 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2542 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2543 These functions do the right thing with sizes > 2**32.
2544 (check_depth): Now ptrdiff_t, not int.
2545 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2546 Adjust to new way of storing sizes. Check for size overflow bugs
2547 in rest of code.
2548 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2549 slightly wrong anyway, as it missed one instance of
2550 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2551 (refill_memory_reserve): Omit needless cast to size_t.
2552 (mark_object_loop_halt): Mark as externally visible.
2553
ac82cc6a
PE
2554 * xselect.c: Integer signedness and overflow fixes.
2555 (Fx_register_dnd_atom, x_handle_dnd_message):
2556 Use ptrdiff_t, not size_t, since we prefer signed.
2557 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2558 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2559 x_dnd_atoms_size and x_dnd_atoms_length.
2560
c2d1e36d
PE
2561 * doprnt.c: Prefer signed to unsigned when either works.
2562 * eval.c (verror):
2563 * doprnt.c (doprnt):
2564 * lisp.h (doprnt):
2565 * xdisp.c (vmessage):
2566 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2567 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2568 prefer signed arithmetic to avoid comparison confusion.
2569 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2570 but is a bit tricky.
2571
0e926e56
PE
2572 Assume freestanding C89 headers, string.h, stdlib.h.
2573 * data.c, doprnt.c, floatfns.c, print.c:
2574 Include float.h unconditionally.
2575 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2576 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2577 * regex.c: Likewise for stddef.h, string.h.
2578 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2579 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2580 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2581 (STDC_HEADERS): Remove obsolete defines.
2582 * sysdep.c: Include limits.h unconditionally.
2583
9cfdb3ec
PE
2584 Assume support for memcmp, memcpy, memmove, memset.
2585 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2586 * regex.c (memcmp, memcpy):
2587 Remove; we assume C89 now.
2588
2589 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2590 (__malloc_safe_bcopy): Remove; no longer needed.
2591
cf950e6b 2592 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2593 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2594 well either way, and we prefer signed to unsigned.
2595
dbf38e02
LMI
25962011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2597
2598 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2599 closes the connection while we're reading (bug#9182).
2600
d6f0886c 26012011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2602
d6f0886c
JD
2603 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2604 are specified (Bug#9168).
24e0f6b1 2605
2eb1f9e6
PE
26062011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2607
2608 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2609 Found by GCC static checking and --with-wide-int on a 32-bit host.
2610
22381272 26112011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2612
2613 * xdisp.c (compute_display_string_pos): Fix logic of caching
2614 previous display string position. Initialize cached_prev_pos to
2615 -1. Fixes slow-down at the beginning of a buffer.
2616
f25e39b4
EZ
26172011-07-24 Eli Zaretskii <eliz@gnu.org>
2618
2619 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2620 for attrs[LFACE_FONTSET_INDEX].
2621
04c4b52e
PE
26222011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2623
2624 * xml.c (parse_region): Remove unused local
2625 that was recently introduced.
2626
c1734fbd
EZ
26272011-07-23 Eli Zaretskii <eliz@gnu.org>
2628
be18c5a5
EZ
2629 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2630 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2631
c1734fbd
EZ
2632 * xdisp.c (move_it_in_display_line_to): Record the best matching
2633 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2634 exit if none of the characters scanned was an exact match.
2635 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2636 when exact match is impossible due to invisible text, and the
2637 lines are truncated.
2638
a258d627
JD
26392011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2640
2641 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2642 for OSX >= 10.7.
2643
b6d5a689
EZ
26442011-07-22 Eli Zaretskii <eliz@gnu.org>
2645
0f74f785
EZ
2646 Fix a significant slow-down of cursor motion with C-n, C-p,
2647 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2648 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2649 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2650 (next_element_from_buffer): Call compute_stop_pos_backwards to
2651 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2652 base_level_stop.
2653 (reseat): Don't look for prev_stop, as that could mean a very long
2654 run.
2655 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2656 <cached_disp_overlay_modiff>: Cache for last found display string
2657 position.
551918c1 2658 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2659 about the same buffer in the same area of character positions, and
2660 the buffer wasn't changed since the time the display string
2661 position was cached.
551918c1 2662
b2d0c91a
EZ
26632011-07-22 Eli Zaretskii <eliz@gnu.org>
2664
2665 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2666 is an integer, which is important for empty lines. (Bug#9149)
2667
043604ee
CY
26682011-07-22 Chong Yidong <cyd@stupidchicken.com>
2669
2670 * frame.c (Fmodify_frame_parameters): In tty case, update the
2671 default face if necessary (Bug#4238).
2672
da4adb04
CY
26732011-07-21 Chong Yidong <cyd@stupidchicken.com>
2674
2675 * editfns.c (Fstring_to_char): No need to explain what a character
2676 is in the docstring (Bug#6576).
2677
9abd0532
LMI
26782011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2679
2680 * xml.c (parse_region): Make sure we always return a tree.
2681
36881d16
HK
26822011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2683
2684 * xml.c (parse_region): If a document contains only comments,
2685 return that, too.
2686
1e98674d
LMI
26872011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2688
2689 * xml.c (make_dom): Return comments, too.
2690
590bd467
PE
26912011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2692
2693 Port to OpenBSD.
2694 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2695 and the surrounding thread.
2696 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2697 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2698 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2699 timer goes off.
2700 * s/openbsd.h (BROKEN_SIGIO): Define.
2701 * unexelf.c (unexec) [__OpenBSD__]:
2702 Don't update the .mdebug section of the Alpha COFF symbol table.
2703
f41628b2
LMI
27042011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2705
2706 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2707 (bug#8460).
2708
b59b67c5
PE
27092011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2710
15e3a074
PE
2711 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2712 This fixes some race conditions on the permissions of any newly
2713 created file.
2714
41bed37d
PE
2715 * alloc.c (valid_pointer_p): Use pipe, not open.
2716 This fixes some permissions issues when debugging.
2717
b59b67c5
PE
2718 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2719 If fchown fails to set both uid and gid, try to set just gid,
2720 as that is sometimes allowed. Adjust the file's mode to eliminate
2721 setuid or setgid bits that are inappropriate if fchown fails.
2722
925a6be7
SM
27232011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2724
2725 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2726 to compare Lisp_Objects.
2727 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2728 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2729 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2730
52968808
AS
27312011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2732
0a6a104b
AS
2733 * lread.c (read_integer): Unread even EOF character.
2734 (read1): Likewise. Properly record start position of symbol.
2735
52968808
AS
2736 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2737 symbol character follows.
2738
9e381cdd
PE
27392011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2740
2741 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2742 This works around a problem with the previous change to Fcopy_file.
2743 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2744 and without this change, GCC might complain about discarding
2745 fchown's return value.
2746
b5641435
JB
27472011-07-16 Juanma Barranquero <lekktu@gmail.com>
2748
2749 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2750
a8031457
PE
27512011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2752
2753 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2754
dd889327
LMI
27552011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2756
750c33f7
LMI
2757 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2758 it's used from the C level.
2759
dd889327
LMI
2760 * process.c: Use the same condition for POLL_FOR_INPUT in both
2761 keyboard.c and process.c (bug#1858).
2762
87e86684
LM
27632011-07-09 Lawrence Mitchell <wence@gmx.li>
2764
2765 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2766 (Fgnutls_boot): Use it.
2767
64348f40
AS
27682011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2769
2770 * doc.c (Fsubstitute_command_keys): Revert last change.
2771
1d698799
LMI
27722011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2773
f863868c
LMI
2774 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2775 quotes the next character, and doesn't affect other longer
2776 sequences (bug#8935).
2777
1d698799
LMI
2778 * lread.c (syms_of_lread): Clarify that is isn't only
2779 `eval-buffer' and `eval-defun' that's affected by
2780 `lexical-binding' (bug#8460).
2781
aa4b6df6
EZ
27822011-07-15 Eli Zaretskii <eliz@gnu.org>
2783
2784 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2785 bidi redisplay when a line includes both an image and is
2786 truncated.
2787
5d856da6
PE
27882011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2789
ad6042bb
PE
2790 Fix minor problems found by static checking.
2791 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2792 (elsz): Now a signed constant, not a size_t var. We prefer signed
2793 types to unsigned, to avoid integer comparison confusion. Without
2794 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2795 "cannot optimize loop, the loop counter may overflow", a symptom
2796 of the confusion.
f00bbb22 2797 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2798 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2799
6468f31c
LMI
28002011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2801
49080b10
LMI
2802 * search.c (Fre_search_backward): Mention `case-fold-search' in
2803 all the re_search_* functions (bug#8138).
2804
6468f31c
LMI
2805 * keyboard.c (Fopen_dribble_file): Document when the file is
2806 closed (bug#8056).
2807
c965adc5
EZ
28082011-07-14 Eli Zaretskii <eliz@gnu.org>
2809
df9733bf
EZ
2810 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2811 bidi_cache_idx.
2812
0bb23927
EZ
2813 Support bidi reordering of display and overlay strings.
2814 * xdisp.c (compute_display_string_pos)
2815 (compute_display_string_end): Accept additional argument STRING.
2816 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2817 (reseat_to_string): Initialize bidi_it->string.s and
2818 bidi_it->string.schars.
2819 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2820 NULL (avoids a crash in bidi_paragraph_init).
2821 Initialize itb.string.lstring.
0bb23927
EZ
2822 (init_iterator): Call bidi_init_it only of a valid
2823 buffer position was specified. Initialize paragraph_embedding to
2824 L2R.
2825 (reseat_to_string): Initialize the bidi iterator.
2826 (display_string): If we need to ignore text properties of
2827 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2828 original value of -1 will not work with bidi.)
2829 (compute_display_string_pos): First arg is now struct
2830 `text_pos *'; all callers changed. Support display properties on
2831 Lisp strings.
2832 (compute_display_string_end): Support display properties on Lisp
2833 strings.
2834 (init_iterator, reseat_1, reseat_to_string): Initialize the
2835 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2836 when iterating on a string not from display properties).
640c8776
SM
2837 (compute_display_string_pos, compute_display_string_end):
2838 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2839 arrow keys.
2840 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2841 base_level_stop; instead, set base_level_stop to BEGV.
2842 Fixes crashes in vertical-motion.
0bb23927
EZ
2843 (next_element_from_buffer): Improve commentary for when
2844 the iterator is before prev_stop.
2845 (init_iterator): Initialize bidi_p from the default value of
2846 bidi-display-reordering, not from buffer-local value. Use the
2847 buffer-local value only if initializing for buffer iteration.
2848 (handle_invisible_prop): Support invisible properties on strings
2849 that are being bidi-reordered.
2850 (set_iterator_to_next): Support bidi reordering of C strings and
2851 Lisp strings.
2852 (next_element_from_string): Support bidi reordering of Lisp
2853 strings.
2854 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2855 (display_string): Support display of R2L glyph rows.
2856 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2857 (init_iterator): Don't initialize it->bidi_p for strings
2858 here.
2859 (reseat_to_string): Initialize it->bidi_p for strings here.
2860 (next_element_from_string, next_element_from_c_string)
2861 (next_element_from_buffer): Add xassert's for correspondence
2862 between IT's object being iterated and it->bidi_it.string
2863 structure.
2864 (face_before_or_after_it_pos): Support bidi iteration.
2865 (next_element_from_c_string): Handle the case of the first string
2866 character that is not the first one in the visual order.
2867 (get_visually_first_element): New function, refactored from common
2868 parts of next_element_from_buffer, next_element_from_string, and
2869 next_element_from_c_string.
2870 (tool_bar_lines_needed, redisplay_tool_bar)
2871 (display_menu_bar): Force left-to-right direction. Add a FIXME
2872 comment for making that be controlled by a user option.
2873 (push_it, pop_it): Save and restore the state of the
2874 bidi iterator. Save and restore the bidi_p flag.
2875 (pop_it): Iterate out of display property for string iteration as
2876 well.
2877 (iterate_out_of_display_property): Support iteration over strings.
2878 (handle_single_display_spec): Set up it->bidi_it for iteration
2879 over a display string, and call bidi_init_it.
2880 (handle_single_display_spec, next_overlay_string)
2881 (get_overlay_strings_1, push_display_prop): Set up the bidi
2882 iterator for displaying display or overlay strings.
2883 (forward_to_next_line_start): Don't use the shortcut if
2884 bidi-iterating.
2885 (back_to_previous_visible_line_start): If handle_display_prop
2886 pushed the iterator stack, restore the internal state of the bidi
2887 iterator by calling bidi_pop_it same number of times.
2888 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2889 and we are bidi-iterating, don't decrement the iterator position;
2890 instead, set the first_elt flag in the bidi iterator, to produce
2891 the same effect.
2892 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2893 (push_display_prop): xassert that we are iterating a buffer.
2894 (push_it, pop_it): Save and restore paragraph_embedding member.
2895 (handle_single_display_spec, next_overlay_string)
2896 (get_overlay_strings_1, reseat_1, reseat_to_string)
2897 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2898 correctly. Don't assume unibyte strings are not bidi-reordered.
2899 (compute_display_string_pos)
2900 (compute_display_string_end): Fix handling the case of C string.
2901 (push_it, pop_it): Save and restore from_disp_prop_p.
2902 (handle_single_display_spec, push_display_prop): Set the
2903 from_disp_prop_p flag.
2904 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2905 (pop_it): Call iterate_out_of_display_property only if we are
2906 popping after iteration over a string that came from a display
2907 property. Fix a typo in popping stretch info. Add an assertion
2908 for verifying that the iterator position is in sync with the bidi
2909 iterator.
2910 (handle_single_display_spec, get_overlay_strings_1)
2911 (push_display_prop): Fix initialization of paragraph direction for
2912 string when that of the parent object is not yet determined.
2913 (reseat_1): Call bidi_init_it to resync the bidi
2914 iterator with IT's position. (Bug#7616)
2915 (find_row_edges): If ROW->start.pos gives position
2916 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2917 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2918 Reset the from_disp_prop_p flag.
2919 (SAVE_IT, RESTORE_IT): New macros.
2920 (pos_visible_p, face_before_or_after_it_pos)
2921 (back_to_previous_visible_line_start)
2922 (move_it_in_display_line_to, move_it_in_display_line)
2923 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2924 (try_scrolling, redisplay_window, display_line): Use them when
2925 saving a temporary copy of the iterator and restoring it back.
2926 (back_to_previous_visible_line_start, reseat_1)
2927 (init_iterator): Empty the bidi cache "stack".
2928 (move_it_in_display_line_to): If iterator ended up at
2929 EOL, but we never saw any buffer positions smaller than
2930 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2931 motion in bidi-reordered lines.
2932 (move_it_in_display_line_to): Record prev_method and prev_pos
2933 immediately before the call to set_iterator_to_next. Fixes cursor
2934 motion in bidi-reordered lines with stretch glyphs and strings
2935 displayed in margins. (Bug#8133) (Bug#8867)
2936 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2937 TO_CHARPOS.
640c8776
SM
2938 (pos_visible_p): Support positions in bidi-reordered lines.
2939 Save and restore bidi cache.
0bb23927
EZ
2940
2941 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2942 (bidi_paragraph_info): Delete unused struct.
2943 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2944 (bidi_cache_start): New variable.
2945 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2946 to zero.
2947 (bidi_cache_fetch_state, bidi_cache_search)
2948 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2949 (bidi_cache_find, bidi_peek_at_next_level)
2950 (bidi_level_of_next_char, bidi_find_other_level_edge)
2951 (bidi_move_to_visually_next): Compare cache index with
2952 bidi_cache_start rather than with zero.
2953 (bidi_fetch_char): Accept new argument STRING; all callers
2954 changed. Support iteration over a string. Support strings with
2955 display properties. Support unibyte strings. Fix the type of
2956 `len' according to what STRING_CHAR_AND_LENGTH expects.
2957 (bidi_paragraph_init, bidi_resolve_explicit_1)
2958 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2959 (bidi_level_of_next_char, bidi_move_to_visually_next):
2960 Support iteration over a string.
0bb23927
EZ
2961 (bidi_set_sor_type, bidi_resolve_explicit_1)
2962 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2963 can now be zero (for strings); special values 0 and -1 were
2964 changed to -1 and -2, respectively.
2965 (bidi_char_at_pos): New function.
2966 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2967 Call it instead of FETCH_MULTIBYTE_CHAR.
2968 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2969 initialized to valid values.
2970 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2971 values.
2972 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2973 the test for valid cached positions. Fix the logic for looking up
2974 the sentinel state in the cache. GCPRO the Lisp string we are
2975 iterating.
2976 (bidi_push_it, bidi_pop_it): New functions.
2977 (bidi_initialize): Initialize the bidi cache start stack pointer.
2978 (bidi_cache_ensure_space): New function, refactored from part of
2979 bidi_cache_iterator_state. Don't assume the required size is just
2980 one BIDI_CACHE_CHUNK away.
2981 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2982 (bidi_count_bytes, bidi_char_at_pos): New functions.
2983 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2984 always valid if bidi_cache_idx is valid.
2985 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2986 is valid if it's going to be used.
2987 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2988 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2989 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2990 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2991 (bidi_find_other_level_edge, bidi_cache_start_stack):
2992 All variables related to cache indices are now EMACS_INT.
c965adc5 2993
0bb23927
EZ
2994 * dispextern.h (struct bidi_string_data): New structure.
2995 (struct bidi_it): New member `string'. Make flag members be 1-bit
2996 fields, and put them last in the struct.
640c8776
SM
2997 (compute_display_string_pos, compute_display_string_end):
2998 Update prototypes.
0bb23927
EZ
2999 (bidi_push_it, bidi_pop_it): Add prototypes.
3000 (struct iterator_stack_entry): New members bidi_p,
3001 paragraph_embedding, and from_disp_prop_p.
3002 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3003 (bidi_shelve_cache, bidi_unshelve_cache):
3004 Declare prototypes.
0bb23927
EZ
3005
3006 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3007 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3008 and vector-like objects.
3009
3010 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3011 cache around display iteration.
3012
3013 * window.c (Fwindow_end, window_scroll_pixel_based)
3014 (displayed_window_lines, Frecenter): Save and restore the bidi
3015 cache around display iteration.
3016
3bbd2265
LMI
30172011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3018
3019 * editfns.c (Fdelete_region): Clarify the use of the named
3020 parameters (bug#6788).
3021
adc47434
MR
30222011-07-14 Martin Rudalics <rudalics@gmx.at>
3023
3024 * indent.c (Fvertical_motion): Set and restore w->pointm when
3025 saving and restoring the window's buffer (Bug#9006).
3026
837c31f8
LMI
30272011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3028
3029 * editfns.c (Fstring_to_char): Clarify just what is returned
3030 (bug#6576). Text by Eli Zaretskii.
3031
ac389d0c
JB
30322011-07-13 Juanma Barranquero <lekktu@gmail.com>
3033
3034 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3035
0be0ce47
EZ
30362011-07-13 Eli Zaretskii <eliz@gnu.org>
3037
3038 * buffer.c (mmap_find): Fix a typo.
3039
cd18e7e3
JB
30402011-07-13 Johan Bockgård <bojohan@gnu.org>
3041
3042 Fix execution of x selection hooks.
3043 * xselect.c (Qx_lost_selection_functions)
3044 (Qx_sent_selection_functions): New vars.
3045 (syms_of_xselect): DEFSYM them.
3046 (x_handle_selection_request): Pass Qx_sent_selection_functions
3047 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3048 (x_handle_selection_clear,x_clear_frame_selections):
3049 Pass Qx_lost_selection_functions rather than
3050 Vx_lost_selection_functions to Frun_hook_with_args.
3051
47ea7f44
PE
30522011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3053
ac389d0c 3054 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3055 The old code sometimes used this field without initializing it.
3056
47ea7f44
PE
3057 * alloc.c (gc_sweep): Don't read past end of array.
3058 In theory, the old code could also have corrupted Emacs internals,
3059 though it'd be very unlikely.
3060
bc985c87
AS
30612011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3062
3063 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3064 argument. (Bug#4026)
bc985c87 3065
0cf34688
LMI
30662011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3067
b3dadd76
LMI
3068 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3069 key" (bug#4257).
3070
0cf34688
LMI
3071 * window.c (Fset_window_start): Doc fix (bug#4199).
3072 (Fset_window_hscroll): Ditto.
3073
270768cd
PE
30742011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3075
077e3dda 3076 Fix minor new problems caught by GCC 4.6.1.
270768cd 3077 * term.c (init_tty): Remove unused local.
490011a6 3078 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3079 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3080 not used otherwise.
270768cd 3081
b1f58454
CY
30822011-07-12 Chong Yidong <cyd@stupidchicken.com>
3083
3084 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3085
22b9578d
LMI
30862011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3087
6e70ab07
LMI
3088 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3089 are the mini-buffer and the echo area (bug#3320).
3090
22b9578d
LMI
3091 * term.c (init_tty): Remove support for supdup, c10 and perq
3092 terminals, which are no longer supported (bug#1482).
3093
8974cc9f
JB
30942011-07-10 Johan Bockgård <bojohan@gnu.org>
3095
3096 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3097
a560d974
JD
30982011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3099
3100 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3101 for non-popups (Bug#3642).
3102
1dae0f0a
AS
31032011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3104
268c2c36 3105 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3106 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3107 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3108 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3109 * data.c (fmod): Likewise.
3110 * dispnew.c (swap_glyphs_in_rows): Likewise.
3111 * emacs.c (memory_warning_signal): Likewise.
3112 * floatfns.c (float_error): Likewise.
3113 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3114 (otf_open, font_otf_capability, generate_otf_features)
3115 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3116 Likewise.
3117 * image.c (pbm_read_file): Likewise.
3118 * indent.c (string_display_width): Likewise.
3119 * intervals.c (check_for_interval, search_for_interval)
3120 (inc_interval_count, count_intervals, root_interval)
3121 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3122 * lread.c (defalias): Likewise.
268c2c36 3123 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3124 * regex.c (set_image_of_range_1, set_image_of_range)
3125 (regex_grow_registers): Likewise.
3126 * sysdep.c (strerror): Likewise.
3127 * termcap.c (valid_filename_p, tprint, main): Likewise.
3128 * tparam.c (main): Likewise.
3129 * unexhp9k800.c (run_time_remap, save_data_space)
3130 (update_file_ptrs, read_header, write_header, calculate_checksum)
3131 (copy_file, copy_rest, display_header): Likewise.
3132 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3133 Likewise.
3134 * xdisp.c (check_it): Likewise.
3135 * xfaces.c (register_color, unregister_color, unregister_colors):
3136 Likewise.
3137 * xfns.c (print_fontset_result): Likewise.
3138 * xrdb.c (member, fatal, main): Likewise.
3139
99033785
PE
31402011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3141
3142 Fix minor problems found by static checking (Bug#9031).
3143 * chartab.c (char_table_set_range, map_sub_char_table):
3144 Remove unused locals.
3145 (uniprop_table): Now static.
3146 * composite.c (_work_char): Remove unused static var.
3147
9cb2ac56
JB
31482011-07-09 Juanma Barranquero <lekktu@gmail.com>
3149
3150 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3151
f25661f0
JD
31522011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3153
3154 * gtkutil.c (qttip_cb): Remove code without function.
3155
8278c4fe
EZ
31562011-07-09 Eli Zaretskii <eliz@gnu.org>
3157
3158 * w32.c (pthread_sigmask): New stub.
3159
1692ae2d 31602011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3161
8a6ebd58 3162 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3163 sigprocmask is portable only for single-threaded applications, and
3164 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3165 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3166 (LIBES): Use it.
3167 * callproc.c (Fcall_process):
3168 * process.c (create_process):
3169 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3170 Use pthread_sigmask, not sigprocmask.
123403e4 3171
1b854618
JD
31722011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3173
3174 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3175 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3176 wrong (Bug#8591).
3177
3fe4b549
JD
31782011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3179
0ce7e563
JD
3180 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3181 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3182 (xg_hide_tooltip): Fix comment.
3183
3fe4b549
JD
3184 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3185 in registerServicesMenuSendTypes.
3186 (validRequestorForSendType): Don't check ns_return_types.
3187
3188 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3189 ns_return_type.
3190
5df75e47
JR
31912011-07-08 Jason Rumney <jasonr@gnu.org>
3192
3193 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3194 frame struct members of non-existent frames (Bug#6284).
3195
699c10bd
JD
31962011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3197
4393663b
JD
3198 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3199 variable firstTime not needed on OSX >= 10.6.
3200 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3201 >= 10.5. Use setKnobProportion, setDoubleValue.
3202
3203 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3204 (MAC_OS_X_VERSION_10_5): Define if not defined.
3205 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3206 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3207 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3208
3209 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3210 cString and lossyCString on OSX >= 10.4
3211
3212 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3213 sizeToFit on OSX >= 10.2.
3214
3215 * nsimage.m (allocInitFromFile): Don't use deprecated method
3216 bestRepresentationForDevice on OSX >= 10.6.
3217
3218 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3219 to avoid warning.
3220
3221 * emacs.c: Declare unexec_init_emacs_zone.
3222
a63e0781
JD
3223 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3224
699c10bd
JD
3225 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3226
3227 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3228 on svcsMenu (Bug#8842).
3229
3230 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3231 ns_return_types.
3232 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3233
3234 * nsterm.m (QUTF8_STRING): Declare.
3235 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3236 (validRequestorForSendType): Return type is (id).
3237 Change indexOfObjectIdenticalTo to indexOfObject.
3238 Check if we have local selection before returning self (Bug#8842).
3239 (writeSelectionToPasteboard): Put local selection into paste board
3240 if we have a local selection (Bug#8842).
3241 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3242
3243 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3244 (ns_get_local_selection): Declare.
3245
54e10184
LMI
32462011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3247
9888ff71
LMI
3248 * keymap.c (describe_map_tree): Don't insert a double newline at
3249 the end of the buffer (bug#1169) and return whether we inserted
3250 something.
3251
54e10184
LMI
3252 * callint.c (Fcall_interactively): Change "reading args" to
3253 "providing args" to try to clarify what it does (bug#1010).
3254
15fa4783
KH
32552011-07-07 Kenichi Handa <handa@m17n.org>
3256
3257 * composite.c (composition_compute_stop_pos): Ignore a static
3258 composition starting before CHARPOS (Bug#8915).
3259
3260 * xdisp.c (handle_composition_prop): Likewise.
3261
a8815b00
EZ
32622011-07-07 Eli Zaretskii <eliz@gnu.org>
3263
3264 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3265 (Bug#9015)
3266
ef7b981d 32672011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3268
3269 * character.h (unicode_category_t): New enum type.
3270
3271 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3272 (Qchar_code_property_table): New variable.
3273 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3274 (UNIPROP_COMPRESSED_FORM_P): New macros.
3275 (char_table_ascii): Uncompress the compressed values.
3276 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3277 Uncompress the compressed values.
ac389d0c 3278 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3279 (char_table_ref_and_range): Uncompress the compressed values.
3280 (sub_char_table_set): New arg is_uniprop. Callers changed.
3281 Uncompress the compressed values.
3282 (sub_char_table_set_range): Args changed. Callers changed.
3283 (char_table_set_range): Adjuted for the above change.
3284 (map_sub_char_table): Delete args default_val and parent. Add arg
3285 top. Give decoded values to a Lisp function.
640c8776 3286 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3287 values to a Lisp function. Gcpro more variables.
3288 (uniprop_table_uncompress)
3289 (uniprop_decode_value_run_length): New functions.
3290 (uniprop_decoder, uniprop_decoder_count): New variables.
3291 (uniprop_get_decoder, uniprop_encode_value_character)
3292 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3293 New functions.
3294 (uniprop_encoder, uniprop_encoder_count): New variables.
3295 (uniprop_get_encoder, uniprop_table)
3296 (Funicode_property_table_internal, Fget_unicode_property_internal)
3297 (Fput_unicode_property_internal): New functions.
3298 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3299 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3300 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3301 char-code-property-alist.
3302
640c8776 3303 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3304 Vunicode_category_table.
3305
640c8776 3306 * font.c (font_range): Adjust for the change of
c805dec0
KH
3307 Vunicode_category_table.
3308
76b397fb
DN
33092011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3310
3311 * m/iris4d.h: Remove file, move contents ...
3312 * s/irix6-5.h: ... here.
3313
22b4128e
PE
33142011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3315
3316 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3317 * alloc.c (mark_buffer):
3318 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3319 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3320 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3321 This isn't true in general, and it's particularly not true
3322 if Emacs is configured with --with-wide-int.
3323 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3324 New macros, used in the buffer.c change.
3325
869795d6
JD
33262011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3327
3328 * xsettings.c: Use both GConf and GSettings if both are available.
3329 (store_config_changed_event): Add comment.
3330 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3331 (store_tool_bar_style_changed): New functions.
5e617bc2 3332 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3333 (struct xsettings): Move font inside HAVE_XFT.
3334 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3335 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3336 Move inside HAVE_XFT.
640c8776 3337 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3338 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3339 also.
3340 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3341 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3342 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3343 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3344 (parse_settings): Move check for font inside HAVE_XFT.
3345 (read_settings, apply_xft_settings): Add comment.
3346 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3347 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3348 call store_font_name_changed.
3349 (xft_settings_event): Add comment.
3350 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3351 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3352 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3353 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3354 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3355 (xsettings_get_system_font, xsettings_get_system_normal_font):
3356 Add comment.
869795d6 3357
d8ed26bd
PE
33582011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3359
3360 Random fixes. E.g., (random) never returned negative values.
3361 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3362 subseconds part to the entropy, as that's a bit more random.
3363 Prefer signed to unsigned, since the signedness doesn't matter and
3364 in general we prefer signed. When given a limit, use a
3365 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3366 latter isn't right if USE_2_TAGS_FOR_INTS.
3367 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3368 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3369
cabf1cac
SM
33702011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3371
3372 * textprop.c (text_property_stickiness):
3373 Obey Vtext_property_default_nonsticky.
3374 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3375 * w32fns.c (syms_of_w32fns):
3376 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3377
6e9b2be9
PE
33782011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3379
3380 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3381 This is more efficient than Ffile_directory_p and avoids a minor race.
3382
90186c68
LMI
33832011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3384
7c301272
LMI
3385 * buffer.c (Foverlay_put): Say what the return value is
3386 (bug#7835).
3387
c4f2d8d4
LMI
3388 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3389 is a directory before asking whether to use the file name
3390 (bug#7564).
ad637907
LMI
3391 (barf_or_query_if_file_exists): Make the "File is a directory"
3392 error be more correct.
c4f2d8d4 3393
90186c68
LMI
3394 * fns.c (Frequire): Remove the mention of the .gz files, since
3395 that's installation-specific, but keep the mention of
3396 `get-load-suffixes'.
3397
da64016e
PE
33982011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3399
3400 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3401 Report string overflow if the output is too long.
3402
7d47b580
JB
34032011-07-04 Juanma Barranquero <lekktu@gmail.com>
3404
a555cb87
JB
3405 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3406 (syms_of_gnutls): Remove duplicate DEFSYM for
3407 Qgnutls_bootprop_verify_hostname_error, an error for
3408 Qgnutls_bootprop_verify_error (which is no longer used).
3409
7d47b580
JB
3410 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3411 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3412 Also (re)move comments that are misplaced or no longer relevant.
3413
1e49bfab
LMI
34142011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3415
3416 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3417
1485f4c0
CY
34182011-07-03 Chong Yidong <cyd@stupidchicken.com>
3419
3420 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3421 and background color parameters if they have been changed.
3422
a9ab721e
LMI
34232011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3424
3425 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3426
cf7cff57
PE
34272011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3428
2e13213d
PE
3429 * xsettings.c (SYSTEM_FONT): Define only when used.
3430 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3431
cf7cff57
PE
3432 * keymap.c (access_keymap_1): Now static.
3433
7a8e04f7
CY
34342011-07-02 Chong Yidong <cyd@stupidchicken.com>
3435
3436 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3437 leave any prefix arg for the up event (Bug#1586).
3438
61352f62
LMI
34392011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3440
69bb1ef7
LMI
3441 * lread.c (syms_of_lread): Mention single symbols defined by
3442 `defvar' or `defconst' (bug#7154).
3443
61352f62 3444 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3445 (Frequire): Mention get-load-suffixes.
61352f62 3446
28545e04
MR
34472011-07-02 Martin Rudalics <rudalics@gmx.at>
3448
3449 * window.h (window): Remove clone_number slot.
3450 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3451 Remove.
3452 (make_parent_window, make_window, saved_window)
3453 (Fset_window_configuration, save_window_save): Don't deal with
3454 clone numbers.
3455 * buffer.c (Qclone_number): Remove declaration.
3456 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3457
3349e122
SM
34582011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3459
3460 Add multiple inheritance to keymaps.
3461 * keymap.c (Fmake_composed_keymap): New function.
3462 (Fset_keymap_parent): Simplify.
3463 (fix_submap_inheritance): Remove.
3464 (access_keymap_1): New function extracted from access_keymap to handle
3465 embedded parents and handle lists of maps.
3466 (access_keymap): Use it.
3467 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3468 (Fcopy_keymap): Handle embedded parents.
3469 (Fcommand_remapping, define_as_prefix): Simplify.
3470 (Fkey_binding): Simplify.
3471 (syms_of_keymap): Move minibuffer-local-completion-map,
3472 minibuffer-local-filename-completion-map,
3473 minibuffer-local-must-match-map, and
3474 minibuffer-local-filename-must-match-map to Elisp.
3475 (syms_of_keymap): Defsubr make-composed-keymap.
3476 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3477 (parse_menu_item): Trivial simplification.
3478
3279eb87
GM
34792011-07-01 Glenn Morris <rgm@gnu.org>
3480
3481 * Makefile.in (SETTINGS_LIBS): Fix typo.
3482
4550efdf
KI
34832011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3484
3485 * coding.c (Fencode_coding_string): Record the last coding system
3486 used, as the function doc string says (bug#8738).
3487
0949d2b6
JD
34882011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3489
3490 * xsettings.c (store_monospaced_changed): Take new font as arg and
3491 check for change against current_mono_font.
3492 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3493 (emacs_settings_constructor, emacs_settings_get_property)
3494 (emacs_settings_set_property, emacs_settings_class_init)
3495 (emacs_settings_init, gsettings_obj): Remove.
3496 (something_changedCB): New function for HAVE_GSETTINGS.
3497 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3498 with value as argument.
3499 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3500 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3501 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3502 "changed".
3503
3504 * xgselect.c: Add defined (HAVE_GSETTINGS).
3505 (xgselect_initialize): Ditto.
3506
3507 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3508 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3509 xg_select.
3510
bbc6b304
PE
35112011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3512
3513 * eval.c (struct backtrace): Simplify and port the data structure.
3514 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3515 signed bit field, as this assumption is not portable and it makes
3516 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3517 "char debug_on_exit : 1" as this is not portable either; instead,
3518 use the portable "unsigned int debug_on_exit : 1". Remove unused
3519 member evalargs. Remove obsolete comments about cc bombing out.
3520
9851bfc5
JD
35212011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3522
51bb811f 3523 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3524 Let HAVE_GSETTINGS override HAVE_GCONF.
3525 (store_monospaced_changed): New function.
3526 (EMACS_SETTINGS): A new type derived from GObject to handle
3527 GSettings notifications.
3528 (emacs_settings_constructor, emacs_settings_get_property)
3529 (emacs_settings_set_property, emacs_settings_class_init):
3530 New functions.
3531 (gsettings_client, gsettings_obj): New variables.
3532 (GSETTINGS_SCHEMA): New define.
3533 (something_changedCB): Call store_monospaced_changed.
3534 (init_gsettings): New function.
3535 (xsettings_initialize): Call init_gsettings.
3536 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3537 to NULL.
3538
640c8776 3539 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3540 GCONF_CFLAGS/LIBS.
3541
5386012d
MR
35422011-06-29 Martin Rudalics <rudalics@gmx.at>
3543
3544 * window.c (resize_root_window, grow_mini_window)
3545 (shrink_mini_window): Rename Qresize_root_window to
3546 Qwindow_resize_root_window and Qresize_root_window_vertically to
3547 Qwindow_resize_root_window_vertically.
3548
f13e0b08
PE
35492011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3550
3551 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3552
94515237
JB
35532011-06-27 Juanma Barranquero <lekktu@gmail.com>
3554
3555 * makefile.w32-in: Redesign dependencies so they reflect more
3556 clearly which files are directly included by each source file,
3557 and not through other includes.
3558
e43b6e43
MR
35592011-06-27 Martin Rudalics <rudalics@gmx.at>
3560
3561 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3562 (sort_overlays, overlay_strings): When an overlay's clone number
3563 matches the window's clone number process the overlay even if
3564 the overlay's window property doesn't match the current window.
3565
d68443dc
MR
3566 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3567 (Fwindow_hchild): Rename to Fwindow_left_child.
3568 (Fwindow_next): Rename to Fwindow_next_sibling.
3569 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3570 (resize_window_check): Rename to window_resize_check.
3571 (resize_window_apply): Rename to window_resize_apply.
3572 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3573 (Fdelete_other_windows_internal, resize_frame_windows)
3574 (Fsplit_window_internal, Fdelete_window_internal)
3575 (grow_mini_window, shrink_mini_window)
3576 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3577
c7e73be5
JD
35782011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3579
3580 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3581 (emacs_fixed_set_min_size): Remove.
3582 (emacs_fixed_new): Take frame as argument.
3583
3584 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3585 (_EmacsFixedPrivate): Remove minwidth/height.
3586 Add struct frame *f.
3587 (emacs_fixed_init): Initialize priv->f.
3588 (get_parent_class, emacs_fixed_set_min_size): Remove.
3589 (emacs_fixed_new): Set priv->f to argument.
3590 (emacs_fixed_get_preferred_width)
3591 (emacs_fixed_get_preferred_height): Use min_width/height from
3592 frames size_hint to set minimum and natural (Bug#8919).
3593 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3594 and use min_width/height from frames size_hint to set
3595 min_width/height (Bug#8919).
3596
3597 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3598 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3599 Fix indentation.
c7e73be5 3600
cf99dcf8
EZ
36012011-06-26 Eli Zaretskii <eliz@gnu.org>
3602
3603 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3604 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3605 called at ZV.
3606
029529ac
CY
36072011-06-26 Chong Yidong <cyd@stupidchicken.com>
3608
3609 * process.c (wait_reading_process_output): Bypass select if
3610 waiting for a cell while ignoring keyboard input, and input is
3611 pending. Suggested by Jan Djärv (Bug#8869).
3612
7a7ef429
PE
36132011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3614
3615 Use gnulib's dup2 module instead of rolling our own.
3616 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3617
11fdef7d 36182011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3619
3620 * dispnew.c (scrolling_window): Before scrolling, turn off a
3621 mouse-highlight in the window being scrolled.
3622
cd3520a4
JB
36232011-06-24 Juanma Barranquero <lekktu@gmail.com>
3624
3625 Move DEFSYM to lisp.h and use everywhere.
3626
3627 * character.h (DEFSYM): Move declaration...
3628 * lisp.h (DEFSYM): ...here.
3629
3630 * gnutls.c:
3631 * minibuf.c:
3632 * w32menu.c:
3633 * w32proc.c:
3634 * w32select.c: Don't include character.h.
3635
3636 * alloc.c (syms_of_alloc):
3637 * buffer.c (syms_of_buffer):
3638 * bytecode.c (syms_of_bytecode):
3639 * callint.c (syms_of_callint):
3640 * casefiddle.c (syms_of_casefiddle):
3641 * casetab.c (init_casetab_once):
3642 * category.c (init_category_once, syms_of_category):
3643 * ccl.c (syms_of_ccl):
3644 * cmds.c (syms_of_cmds):
3645 * composite.c (syms_of_composite):
3646 * dbusbind.c (syms_of_dbusbind):
3647 * dired.c (syms_of_dired):
3648 * dispnew.c (syms_of_display):
3649 * doc.c (syms_of_doc):
3650 * editfns.c (syms_of_editfns):
3651 * emacs.c (syms_of_emacs):
3652 * eval.c (syms_of_eval):
3653 * fileio.c (syms_of_fileio):
3654 * fns.c (syms_of_fns):
3655 * frame.c (syms_of_frame):
3656 * fringe.c (syms_of_fringe):
3657 * insdel.c (syms_of_insdel):
3658 * keymap.c (syms_of_keymap):
3659 * lread.c (init_obarray, syms_of_lread):
3660 * macros.c (syms_of_macros):
3661 * msdos.c (syms_of_msdos):
3662 * print.c (syms_of_print):
3663 * process.c (syms_of_process):
3664 * search.c (syms_of_search):
3665 * sound.c (syms_of_sound):
3666 * syntax.c (init_syntax_once, syms_of_syntax):
3667 * terminal.c (syms_of_terminal):
3668 * textprop.c (syms_of_textprop):
3669 * undo.c (syms_of_undo):
3670 * w32.c (globals_of_w32):
3671 * window.c (syms_of_window):
3672 * xdisp.c (syms_of_xdisp):
3673 * xfaces.c (syms_of_xfaces):
3674 * xfns.c (syms_of_xfns):
3675 * xmenu.c (syms_of_xmenu):
3676 * xsettings.c (syms_of_xsettings):
3677 * xterm.c (syms_of_xterm): Use DEFSYM.
3678
4228cf16
TZ
36792011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3680
cd3520a4 3681 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3682
7fcccf1e
PE
36832011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3684
7efb4e0e
PE
3685 Integer and buffer overflow fixes (Bug#8873).
3686
ff5844ad
PE
3687 * print.c (printchar, strout): Check for string overflow.
3688 (PRINTPREPARE, printchar, strout):
3689 Don't set size unless allocation succeeds.
3690
90532f02
PE
3691 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3692 for sizes. Check for string overflow more accurately.
3693 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3694
6d84508d
PE
3695 * macros.c: Integer and buffer overflow fixes.
3696 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3697 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3698 Use ptrdiff_t, not int, for sizes.
3699 Don't increment bufsize until after realloc succeeds.
3700 Check for size-calculation overflow.
3701 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3702
437b2cb4
PE
3703 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3704
8b9ac8b4
PE
3705 * lread.c: Integer overflow fixes.
3706 (read_integer): Radix is now EMACS_INT, not int,
3707 to improve quality of diagnostics for out-of-range radices.
3708 Calculate buffer size correctly for out-of-range radices.
3709 (read1): Check for integer overflow in radices, and in
3710 read-circle numbers.
82cb60d3
PE
3711 (read_escape): Avoid int overflow.
3712 (Fload, openp, read_buffer_size, read1)
3713 (substitute_object_recurse, read_vector, read_list, map_obarray):
3714 Use ptrdiff_t, not int, for sizes.
3715 (read1): Use EMACS_INT, not int, for sizes.
20270765 3716 Check for size overflow.
8b9ac8b4 3717
7fcccf1e
PE
3718 * image.c (cache_image): Check for size arithmetic overflow.
3719
bfbbd7e7
PE
3720 * lread.c: Integer overflow issues.
3721 (saved_doc_string_size, saved_doc_string_length)
3722 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3723 Now ptrdiff_t, not int.
3724 (read1): Don't assume doc string length fits in int. Check for
3725 out-of-range doc string lengths.
3726 (read_list): Don't assume file position fits in int.
39019e54 3727 (read_escape): Check for hex character overflow.
bfbbd7e7 3728
4e323265
LL
37292011-06-22 Leo Liu <sdl.web@gmail.com>
3730
3731 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3732 Move to minibuffer.el.
3733
85fece3e
PE
37342011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3735
20b84ce9 3736 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3737 The following patches are for when GLYPH_DEBUG && !XASSERT.
3738 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3739 * dispnew.c (flush_stdout):
3740 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3741 Mark as externally visible.
3742 * dispnew.c (check_window_matrix_pointers): Now static.
3743 * dispnew.c (window_to_frame_vpos):
3744 * xfns.c (unwind_create_frame):
3745 * xterm.c (x_check_font): Remove unused local.
3746 * scroll.c (CHECK_BOUNDS):
3747 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3748 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3749 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3750 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3751 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3752 Now static.
3753 (debug_method_add): Use va_list and vsprintf rather than relying
3754 on undefined behavior with wrong number of arguments.
3755 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3756 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3757 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3758 since we're not interested in debugging glyphs with old libraries.
3759 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3760 GCC 4.6.0's static checking.
3761
0766b489
PE
37622011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3763
31fd4b32
PE
3764 Integer overflow and signedness fixes (Bug#8873).
3765 A few related buffer overrun fixes, too.
3766
b79e8648
PE
3767 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3768
0766b489
PE
3769 * dispextern.h (struct face.stipple):
3770 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3771 (x_bitmap_mask, x_allocate_bitmap_record)
3772 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3773 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3774 (x_create_bitmap_from_xpm_data):
3775 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3776 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3777 (.bitmaps_last):
3778 * xfaces.c (load_pixmap):
3779 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3780 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3781 (.bitmaps_last, struct x_output.icon_bitmap):
3782 Use ptrdiff_t, not int, for bitmap indexes.
3783 (x_allocate_bitmap_record): Check for size overflow.
3784 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3785
b081724f
PE
3786 Use ptrdiff_t, not int, for overlay counts.
3787 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3788 * editfns.c (overlays_around, get_pos_property):
3789 * textprop.c (get_char_property_and_overlay):
3790 * xdisp.c (next_overlay_change, note_mouse_highlight):
3791 * xfaces.c (face_at_buffer_position):
21514da7
PE
3792 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3793 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3794 (Fnext_overlay_change, Fprevious_overlay_change)
3795 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3796 Use ptrdiff_t, not int, for sizes.
21514da7 3797 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3798
3de73e5e
PE
3799 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3800
2606c57b
PE
3801 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3802 (x_session_initialize): Do not assume string length fits in int.
3803
aaafe47a
PE
3804 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3805 This is unlikely, but can occur if DPI is outlandish.
3806
2674ddc8 3807 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3808 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3809
28154962
PE
3810 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3811 * xrdb.c (magic_file_p, search_magic_path):
3812 Omit last arg SUFFIX; it was always 0. All callers changed.
3813 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3814
7de51af5
PE
3815 * xfont.c (xfont_match): Avoid need for strlen.
3816
25ed6cc3
PE
3817 * xfns.c: Don't assume strlen fits in int.
3818 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3819
4eab31dd
PE
3820 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3821 not unsigned long, as we prefer signed integers. All callers changed.
3822 Detect integer overflow in repeat count.
3823 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3824 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3825
171e2a58
PE
3826 * termcap.c: Don't assume sizes fit in int and never overflow.
3827 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3828 (gobble_line): Check for size-calculation overflow.
3829
ad39faca 3830 * minibuf.c (Fread_buffer):
6e5bb2dc 3831 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3832 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3833 Don't assume string length fits in int.
3834
52c61c22 3835 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3836 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3837
b5b8c9e5
PE
3838 * font.c: Don't assume string length fits in int.
3839 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3840 Use ptrdiff_t, not int.
ccd6111c
PE
3841 (font_intern_prop): Don't assume string length fits in int.
3842 Don't assume integer property fits in fixnum.
3843 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3844
882f0d81 3845 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3846 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3847 Reformulate so as not to need the command string.
3848 Invoke gzip -cd rather than gunzip, as it's more portable.
3849 (lock_info_type, lock_file_1, lock_file):
3850 Don't assume pid_t and time_t fit in unsigned long.
3851 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3852 (current_lock_owner): Prefer signed type for sizes.
3853 Use memcpy, not strncpy, where memcpy is what is really wanted.
3854 Don't assume (via atoi) that time_t and pid_t fit in int.
3855 Check for time_t and/or pid_t out of range, e.g., via a network share.
3856 Don't alloca where an auto var works fine.
3857
93f4cf88
PE
3858 * fileio.c: Fix some integer overflow issues.
3859 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3860 Don't assume string length fits in int.
3861 (directory_file_name): Don't assume string length fits in long.
3862 (make_temp_name): Don't assume pid fits in int, or that its print
3863 length is less than 20.
3864
f3e92b69
PE
3865 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3866
1bfdaf10
PE
3867 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3868
35016e9a
PE
3869 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3870
3d1e65a1
PE
3871 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3872 We prefer signed integers, even for size calculations.
3873
0b963a93
PE
3874 * emacs.c: Don't assume string length fits in 'int'.
3875 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3876 (main): Don't invoke strlen when not needed.
3877
573f4b54
PE
3878 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3879 (XD_DEBUG_MESSAGE): Don't waste a byte.
3880
989f33ba
PE
3881 * callproc.c (getenv_internal_1, getenv_internal)
3882 (Fgetenv_internal):
965d34eb
PE
3883 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3884
e4d29b33
PE
3885 * lread.c (invalid_syntax): Omit length argument.
3886 All uses changed. This doesn't fix a bug, but it simplifies the
3887 code away from its former Hollerith-constant appearance, and it's
3888 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3889 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3890
eb49b136
PE
3891 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3892 This didn't break anything, but it didn't help either.
3893 It's confusing to put a bogus integer in a place where the actual
3894 value does not matter.
9f62aeb1 3895 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3896 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3897
15375a22
PE
3898 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3899 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3900 implementation.
b61cc01c
PE
3901 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3902 We prefer signed types, and the value cannot exceed the EMACS_INT
3903 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3904 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3905 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3906 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3907
53b2623d
PE
3908 * indent.c (sane_tab_width): New function.
3909 (current_column, scan_for_column, Findent_to, position_indentation)
3910 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3911 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3912
51cab52b 3913 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3914
f2ed8a70
PE
3915 * lisp.h (lint_assume): New macro.
3916 * composite.c (composition_gstring_put_cache):
3917 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3918
abe80cc6
PE
3919 * editfns.c, insdel.c:
3920 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3921
b02c740e
PE
3922 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3923
ebc96716
PE
3924 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3925
b4e50fa0 3926 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3927 Use much-faster test for byte-length change.
311d5d7c 3928 Don't assume string byte-length fits in 'int'.
a4cf38e4 3929 Check that character arg fits in 'int'.
85461888 3930 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3931
c0c1ee9f
PE
3932 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3933
a498d7f4
PE
3934 * fns.c (concat): Catch string overflow earlier.
3935 Do not rely on integer wraparound.
3936
51cab52b
PE
3937 * dispextern.h (struct it.overlay_strings_charpos)
3938 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3939 * xdisp.c (forward_to_next_line_start)
3940 (back_to_previous_visible_line_start)
3941 (reseat_at_next_visible_line_start, next_element_from_buffer):
3942 Don't arbitrarily truncate the value of 'selective' to int.
3943
76031fad
PE
3944 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3945
5eb55db9
PE
3946 * composite.c: Don't truncate sizes to 'int'.
3947 (composition_gstring_p, composition_reseat_it)
3948 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3949 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3950 not EMACS_UINT, for indexes.
5eb55db9 3951
0703a717
PE
3952 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3953
d6202519
PE
3954 * buffer.c: Include <verify.h>.
3955 (struct sortvec.priority, struct sortstr.priority):
8961a454 3956 Now EMACS_INT, not int.
c20998a7 3957 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3958 (struct sortstr.size, record_overlay_string)
3959 (struct sortstrlist.size, struct sortlist.used):
3960 Don't truncate size to int.
3961 (record_overlay_string): Check for size-calculation overflow.
d6202519 3962 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3963
d5a19415
JM
39642011-06-22 Jim Meyering <meyering@redhat.com>
3965
029529ac 3966 Don't leak an XBM-image-sized buffer
d5a19415
JM
3967 * image.c (xbm_load): Free the image buffer after using it.
3968
a9041e6c
PE
39692011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3970
3971 Port to Sun C.
3972 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3973 that Sun C diagnosed.
3974 * fns.c (secure_hash): Fix pointer signedness issue.
3975 * intervals.c (static_offset_intervals): New function.
3976 (offset_intervals): Use it.
3977
7f3f739f
LL
39782011-06-21 Leo Liu <sdl.web@gmail.com>
3979
3980 * deps.mk (fns.o):
3981 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3982 sha512.h.
3983
3984 * fns.c (secure_hash): Rename from crypto_hash_function and change
3985 the first arg to accept symbols.
5b66d427 3986 (Fsecure_hash): New primitive.
7f3f739f
LL
3987 (syms_of_fns): New symbols.
3988
76147d94
DD
39892011-06-20 Deniz Dogan <deniz@dogan.se>
3990
3991 * process.c (Fset_process_buffer): Clarify return value in
3992 docstring.
3993
7d7d0045
CY
39942011-06-18 Chong Yidong <cyd@stupidchicken.com>
3995
3996 * dispnew.c (add_window_display_history): Use BVAR.
3997
3998 * xdisp.c (debug_method_add): Use BVAR.
3999 (check_window_end, dump_glyph_matrix, dump_glyph)
4000 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4001
4002 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4003 Likewise.
4004
4005 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4006 check till after the cache is created in init_frame_faces.
4007
ff2bc410
SM
40082011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4009
4010 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4011
28177add
PE
40122011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4013
dd3482fe
PE
4014 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4015 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4016 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4017
393d71f3 4018 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4019 * fileio.c (Finsert_file_contents):
4020 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4021 Remove the old (too-loose) buffer overflow checks.
4022 They weren't needed, since make_gap checks for buffer overflow.
4023 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4024 The old code merely checked for Emacs fixnum overflow, and relied
4025 on undefined (wraparound) behavior. The new code avoids undefined
4026 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4027
2e6813b0 4028 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4029 Tune. Don't use wider integers than needed. Don't use alloca.
4030 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4031
599a9e4f
PE
4032 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4033
99561444
PE
4034 * insdel.c, lisp.h (buffer_overflow): New function.
4035 (insert_from_buffer_1, replace_range, replace_range_2):
4036 * insdel.c (make_gap_larger):
4037 * editfns.c (Finsert_char):
4038 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4039
28177add
PE
4040 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4041
e69dafad
PE
40422011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4043
a7af7fde 4044 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4045
b1c46f02
PE
4046 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4047 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4048
e69dafad
PE
4049 * fileio.c: Don't assume EMACS_INT fits in off_t.
4050 (emacs_lseek): New static function.
4051 (Finsert_file_contents, Fwrite_region): Use it.
4052 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4053
566684ea
PE
4054 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4055
e6966cd6
PE
4056 * fns.c: Don't overflow int when computing a list length.
4057 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4058 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4059 truncation on 64-bit hosts. Check for QUIT every
4060 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4061 faster and is responsive enough.
4062 (Flength): Report an error instead of overflowing an integer.
4063 (Fsafe_length): Return a float if the value is not representable
4064 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4065 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4066 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4067
dd0b0efb
PE
4068 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4069 (header_size, word_size): New constants.
4070 (allocate_vectorlike): Don't check size overflow here.
4071 (allocate_vector): Check it here instead, since this is the only
4072 caller of allocate_vectorlike that could cause overflow.
4073 Check that the new vector's length is representable as a fixnum.
4074
86fe5cfe
PE
4075 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4076 The previous code was bogus. For example, next_almost_prime (32)
4077 returned 39, which is undesirable as it is a multiple of 3; and
4078 next_almost_prime (24) returned 25, which is a multiple of 5 so
4079 why was the code bothering to check for multiples of 7?
4080
80e88859
PE
4081 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4082
4a2f0ad6
PE
4083 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4084
f66c7cf8
PE
4085 Variadic C functions now count arguments with ptrdiff_t.
4086 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4087 Back then I didn't know that the Emacs coding style prefers signed int.
4088 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4089 were being counted with int, which may truncate counts on 64-bit
4090 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4091 * lisp.h (struct Lisp_Subr.function.aMANY)
4092 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4093 Arg counts are now ptrdiff_t, not size_t.
4094 All variadic functions and their callers changed accordingly.
4095 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4096 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4097 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4098 * callint.c (Fcall_interactively): Check arg count for overflow,
4099 to avoid potential buffer overrun. Use signed char, not 'int',
4100 for 'varies' array, so that we needn't bother to check its size
4101 calculation for overflow.
4102 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4103 * eval.c (apply_lambda):
4104 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4105 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4106 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4107
a1759b76
PE
4108 * callint.c (Fcall_interactively): Don't use index var as event count.
4109
d96be9fc
PE
4110 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4111 * mem-limits.h (SIZE): Remove; no longer used.
4112
a690a978 4113 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4114
578c21e6
PE
4115 Remove unnecessary casts.
4116 * xterm.c (x_term_init):
4117 * xfns.c (x_set_border_pixel):
4118 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4119 These aren't needed now that we assume ANSI C.
4120
96f53c6c
PE
4121 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4122 It's more likely to cause problems (due to unsigned overflow)
4123 than to cure them.
4124
83c77d31
PE
4125 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4126
ee2079f1
PE
4127 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4128
6da65536
PE
4129 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4130
7147c4a4
PE
4131 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4132
193e32d9
PE
4133 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4134
e5533da6
PE
4135 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4136
9910e595
PE
4137 GLYPH_CODE_FACE returns EMACS_INT, not int.
4138 * dispextern.h (merge_faces):
4139 * xfaces.c (merge_faces):
01103c44
PE
4140 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4141 Don't assume EMACS_INT fits in int.
9910e595 4142
2638320e
PE
4143 * character.h (CHAR_VALID_P): Remove unused parameter.
4144 * fontset.c, lisp.h, xdisp.c: All uses changed.
4145
045eb8d9
PE
4146 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4147
c1f134b5
PE
4148 * fns.c (concat): Minor tuning based on overflow analysis.
4149 This doesn't fix any bugs. Use int to hold character, instead
4150 of constantly refetching from Emacs object. Use XFASTINT, not
4151 XINT, for value known to be a character. Don't bother comparing
4152 a single byte to 0400, as it's always less.
4153
395fcb93 4154 * floatfns.c (Fexpt):
327eeec8
PE
4155 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4156
abbd3d23
PE
4157 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4158 for characters.
4159
684a03ef
PE
4160 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4161
0fed43f3
PE
4162 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4163 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4164 incorrectly succeed when S was a string, because 4294967386 was
4165 truncated before it was used.
4166
8fd02eb7
PE
4167 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4168 Otherwise, an out-of-range integer could cause undefined behavior
4169 on a 64-bit host.
4170
f8c86b69
PE
4171 * composite.c: Use int, not EMACS_INT, for characters.
4172 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4173 EMACS_INT, for values that are known to be in character range.
4174 This doesn't fix any bugs but is the usual style inside Emacs and
4175 may generate better code on 32-bit machines.
4176
34206dd2
PE
4177 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4178 This is for reasons similar to the recent CHAR_STRING fix.
4179 * charset.c (Fencode_char): Check that character arg is actually
4180 a character. Pass an int to ENCODE_CHAR.
4181 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4182 wider than 'int', as a compile-time check to prevent future regressions
4183 in this area.
4184
c5958d4c 4185 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4186
4187 Make sure a 64-bit char is never passed to CHAR_STRING.
4188 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4189 by silently ignoring the top 32 bits, allowing some values
4190 that were far too large to be valid characters.
4191 * character.h: Include <verify.h>.
4192 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4193 arguments are no wider than unsigned, as a compile-time check
4194 to prevent future regressions in this area.
4195 * data.c (Faset):
01103c44 4196 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4197 (Fsubst_char_in_region):
4198 * fns.c (concat):
4199 * xdisp.c (decode_mode_spec_coding):
4200 Adjust to CHAR_STRING's new requirement.
4201 * editfns.c (Finsert_char, Fsubst_char_in_region):
4202 * fns.c (concat): Check that character args are actually
4203 characters. Without this test, these functions did the wrong
4204 thing with wildly out-of-range values on 64-bit hosts.
4205
d37ca623
PE
4206 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4207 These casts should not be needed on 32-bit hosts, either.
4208 * keyboard.c (read_char):
4209 * lread.c (Fload): Remove casts to unsigned.
4210
ea204efb
PE
4211 * lisp.h (UNSIGNED_CMP): New macro.
4212 This fixes comparison bugs on 64-bit hosts.
4213 (ASCII_CHAR_P): Use it.
4214 * casefiddle.c (casify_object):
01103c44 4215 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4216 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4217 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4218 * dispextern.h (FACE_FROM_ID):
4219 * keyboard.c (read_char): Use UNSIGNED_CMP.
4220
41cb286c
PE
4221 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4222 not to EMACS_INT, to avoid GCC warning.
4223
4a1b9832
PE
4224 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4225
55daad71
PE
4226 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4227 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4228 isn't needed on 32-bit machines.
8f95c75c 4229
01103c44
PE
4230 * buffer.c (Fgenerate_new_buffer_name):
4231 Use EMACS_INT for count, not int.
0ceccced 4232 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4233
4234 * data.c (Qcompiled_function): Now static.
4235
c6f072e7
PE
4236 * window.c (window_body_lines): Now static.
4237
20ce5912
PE
4238 * image.c (gif_load): Rename local to avoid shadowing.
4239
9c4c5f81
PE
4240 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4241 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4242 * alloc.c (make_save_value): Integer argument is now of type
4243 ptrdiff_t, not int.
4244 (mark_object): Use ptrdiff_t, not int.
4245 * lisp.h (pD): New macro.
4246 * print.c (print_object): Use it.
4247
c0c5c8ae
PE
4248 * alloc.c: Use EMACS_INT, not int, to count objects.
4249 (total_conses, total_markers, total_symbols, total_vector_size)
4250 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4251 (total_free_floats, total_floats, total_free_intervals)
4252 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4253 Now EMACS_INT, not int. All uses changed.
4254 (Fgarbage_collect): Compute overall total using a double, so that
4255 integer overflow is less likely to be a problem. Check for overflow
4256 when converting back to an integer.
5a25e253
PE
4257 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4258 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4259 These were 'int' variables that could overflow on 64-bit hosts;
4260 they were never used, so remove them instead of repairing them.
211a0b2a 4261 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4262 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4263 Previously, this ceilinged at INT_MAX, but that doesn't work on
4264 64-bit machines.
e46bb31a 4265 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4266
c78baabf 4267 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4268 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4269 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4270 when a (possibly-narrower) signed value would do just as well.
4271 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4272
c9d624c6
PE
4273 * alloc.c: Catch some string size overflows that we were missing.
4274 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4275 for convenience in STRING_BYTES_MAX.
4276 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4277 The definition here is exact; the one in lisp.h was approximate.
4278 (allocate_string_data): Check for string overflow. This catches
4279 some instances we weren't catching before. Also, it catches
4280 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4281 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4282 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4283
c9d624c6
PE
4284 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4285 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4286 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4287
353032ce
PE
4288 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4289
2bccce07
PE
4290 * alloc.c (Fmake_string): Check for out-of-range init.
4291
0ac30604
SM
42922011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4293
4294 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4295
c195f2de
JD
42962011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4297
4298 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4299 xg_get_default_scrollbar_width.
4300
4301 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4302 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4303 (style_changed_cb): Call update_theme_scrollbar_width and call
4304 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4305 all frames (Bug#8505).
4306 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4307 Call gtk_window_set_resizable if HAVE_GTK3.
4308 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4309 and height if HAVE_GTK3 (Bug#8505).
4310 (scroll_bar_width_for_theme): New variable.
4311 (update_theme_scrollbar_width): New function.
4312 (xg_get_default_scrollbar_width): Move code to
4313 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4314 (xg_initialize): Call update_theme_scrollbar_width.
4315
4316 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4317
4318 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4319
e10ac9f1
MR
43202011-06-12 Martin Rudalics <rudalics@gmx.at>
4321
4322 * frame.c (make_frame): Call other_buffer_safely instead of
4323 other_buffer.
4324
4325 * window.c (temp_output_buffer_show): Call display_buffer with
4326 second argument Vtemp_buffer_show_specifiers and reset latter
4327 immediately after the call.
4328 (Vtemp_buffer_show_specifiers): New variable.
4329 (auto_window_vscroll_p, next_screen_context_lines)
4330 (Vscroll_preserve_screen_position): Remove leading asterisks from
4331 doc-strings.
4332
2d3c217e 43332011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4334
7b7f97e8 4335 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4336 * buffer.c (Qclone_number): Remove for now, as it's unused.
4337 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4338 (record_buffer): Remove unused local.
4339 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4340 (set_frame_buffer_list): Remove; unused.
4341 * frame.h (other_visible_frames): Remove decl.
4342 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4343 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4344 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4345 if HAVE_GPM.
4346 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4347 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4348 Define only if HAVE_GPM.
4349 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4350 (update_hints_inhibit): Remove; never set. All uses removed.
4351 * widgetprv.h (emacsFrameClassRec): Remove decl.
4352 * window.c (delete_deletable_window): Now returns void, since it
4353 wasn't returning anything.
4354 (compare_window_configurations): Remove unused locals.
4355 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4356 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4357 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4358 the same widths as pointers. This follows up on the 2011-05-06 patch.
4359 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4360 * xterm.h: Likewise.
4361 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4362
1384b89e
JB
43632011-06-12 Juanma Barranquero <lekktu@gmail.com>
4364
4365 * makefile.w32-in: Update dependencies.
4366 (LISP_H): Add lib/intprops.h.
4367
1100a63c
CY
43682011-06-11 Chong Yidong <cyd@stupidchicken.com>
4369
4370 * image.c (gif_load): Add animation frame delay to the metadata.
4371 (syms_of_image): Use DEFSYM. New symbol `delay'.
4372
6198ccd0
MR
43732011-06-11 Martin Rudalics <rudalics@gmx.at>
4374
4375 * window.c (delete_deletable_window): Re-add.
4376 (Fset_window_configuration): Rewrite to handle dead buffers and
4377 consequently deletable windows.
4378 (window_tree, Fwindow_tree): Remove. Supply functionality in
4379 window.el.
4380 (compare_window_configurations): Simplify code.
4381
b6e3633c
AS
43822011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4383
1ab0dee5
AS
4384 * image.c (imagemagick_load_image): Fix type mismatch.
4385 (Fimagemagick_types): Likewise.
4386
b6e3633c
AS
4387 * window.h (replace_buffer_in_windows): Declare.
4388
9397e56f
MR
43892011-06-11 Martin Rudalics <rudalics@gmx.at>
4390
4391 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4392 Qclone_number. Remove external declaration of Qdelete_window.
4393 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4394 code.
640c8776
SM
4395 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4396 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4397 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4398 buffer list implementation.
4399 (other_buffer_safely): New function.
4400 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4401 calls to replace_buffer_in_windows and
4402 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4403 if allowed.
4404 (record_buffer): Inhibit quitting and rewrite using quittable
4405 functions. Run Qbuffer_list_update_hook if allowed.
4406 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4407 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4408 Move switch-to-buffer to window.el.
9397e56f
MR
4409 (bury-buffer): Move to window.el.
4410 (Vbuffer_list_update_hook): New variable.
4411
4412 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4413 section.
4414
4415 * window.h (resize_frame_windows): Move up in code.
4416 (Fwindow_frame): Remove EXFUN.
4417 (replace_buffer_in_all_windows): Remove prototype.
4418 (replace_buffer_in_windows_safely): Add prototype.
4419
4420 * window.c: Declare Qdelete_window static again. Move down
4421 declaration of select_count.
4422 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4423 (Fother_window): Move to window.el.
4424 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4425 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4426 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4427 window.el.
4428 (replace_buffer_in_windows): Implement by calling
4429 Qreplace_buffer_in_windows.
4430 (replace_buffer_in_all_windows): Remove with some functionality
4431 moved into replace_buffer_in_windows_safely.
4432 (replace_buffer_in_windows_safely): New function.
4433 (select_window_norecord, select_frame_norecord): Move in front
4434 of run_window_configuration_change_hook. Remove now obsolete
4435 declarations.
640c8776
SM
4436 (Fset_window_buffer): Rewrite doc-string.
4437 Call Qrecord_window_buffer.
9397e56f
MR
4438 (keys_of_window): Move binding for other-window to window.el.
4439
b50691aa
CY
44402011-06-11 Chong Yidong <cyd@stupidchicken.com>
4441
4442 * dispextern.h (struct image): Replace data member, whose int_val
4443 and ptr_val fields were not used by anything, with a single
4444 lisp_val object.
4445
4446 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4447 (gif_clear_image, gif_load, imagemagick_load_image)
4448 (gs_clear_image, gs_load): Callers changed.
4449
3f754b86
PE
44502011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4451
cca69397
PE
4452 * buffer.h: Include <time.h>, for time_t.
4453 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4454
109e28d0
PE
4455 Fix minor problems found by static checking.
4456
60737f02
PE
4457 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4458
4b66faf3
PE
4459 Make identifiers static if they are not used in other modules.
4460 * data.c (Qcompiled_function, Qframe, Qvector):
4461 * image.c (QimageMagick, Qsvg):
4462 * minibuf.c (Qmetadata):
4463 * window.c (resize_window_check, resize_root_window): Now static.
4464 * window.h (resize_window_check, resize_root_window): Remove decls.
4465
109e28d0
PE
4466 * window.c (window_deletion_count, delete_deletable_window):
4467 Remove; unused.
46a4ce9e
PE
4468 (window_body_lines): Now static.
4469 (Fdelete_other_windows_internal): Mark vars as initialized.
4470 Make sure 'resize_failed' is initialized.
4471 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4472 (resize_window_apply): Remove unused local.
4473 * window.h (delete_deletable_window): Remove decl.
4474
109e28d0 4475 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4476 (imagemagick_load_image): Fix pointer signedness problem by changing
4477 last arg from unsigned char * to char *. All uses changed.
4478 Also, fix a local for similar reasons.
4479 Remove unused locals. Remove locals to avoid shadowing.
4480 (fn_rsvg_handle_free): Remove; unused.
4481 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4482 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4483
3f754b86
PE
4484 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4485
2547adb1
CY
44862011-06-10 Chong Yidong <cyd@stupidchicken.com>
4487
4488 * image.c (gif_load): Fix omitted cast error introduced by
4489 2011-06-06 change.
4490
2c8e37d4
MR
44912011-06-10 Martin Rudalics <rudalics@gmx.at>
4492
4493 * window.h (resize_proportionally, orig_total_lines)
4494 (orig_top_line): Remove from window structure.
4495 (set_window_height, set_window_width, change_window_heights)
4496 (Fdelete_window): Remove prototypes.
4497 (resize_frame_windows): Remove duplicate declaration.
4498
440a42e3
EZ
44992011-06-10 Eli Zaretskii <eliz@gnu.org>
4500
4501 * window.h (resize_frame_windows, resize_window_check)
4502 (delete_deletable_window, resize_root_window)
4503 (resize_frame_windows): Declare prototypes.
4504
4505 * window.c (resize_window_apply): Make definition be "static" to
4506 match the prototype.
4507
562dd5e9
MR
45082011-06-10 Martin Rudalics <rudalics@gmx.at>
4509
4510 * window.c: Remove declarations of Qwindow_size_fixed,
4511 window_min_size_1, window_min_size_2, window_min_size,
4512 size_window, window_fixed_size_p, enlarge_window, delete_window.
4513 Remove static from declaration of Qdelete_window, it's
4514 temporarily needed by Fbury_buffer.
4515 (replace_window): Don't assign orig_top_line and
4516 orig_total_lines.
4517 (Fdelete_window, delete_window): Remove. Window deletion is
4518 handled by window.el.
640c8776
SM
4519 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4520 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4521 (Fdelete_other_windows): Remove. Deleting other windows is
4522 handled by window.el.
4523 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4524 handled in window.el.
4525 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4526 Window minimum sizes are handled in window.el.
4527 (shrink_windows, size_window, set_window_height)
4528 (set_window_width, change_window_heights, window_height)
4529 (window_width, CURBEG, CURSIZE, enlarge_window)
4530 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4531 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4532 handled in window.el.
4533 (make_dummy_parent): Rename to make_parent_window and give it a
4534 second argument horflag.
4535 (make_window): Don't set resize_proportionally any more.
4536 (Fsplit_window): Remove. Windows are split in window.el.
4537 (save_restore_action, save_restore_orig_size)
4538 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4539 Resize mini windows in window.el.
4540 (grow_mini_window, shrink_mini_window): Implement by calling
4541 Qresize_root_window_vertically, resize_window_check and
4542 resize_window_apply.
640c8776
SM
4543 (saved_window, Fset_window_configuration, save_window_save):
4544 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4545 resize_proportionally.
4546 (window_min_height, window_min_width): Move to window.el.
4547 (keys_of_window): Move bindings for delete-other-windows,
4548 split-window, delete-window and enlarge-window to window.el.
4549
4550 * buffer.c: Temporarily extern Qdelete_window.
4551 (Fbury_buffer): Temporarily call Qdelete_window instead of
4552 Fdelete_window (Fbury_buffer will move to window.el soon).
4553
4554 * frame.c (set_menu_bar_lines_1): Remove code handling
4555 orig_top_line and orig_total_lines.
4556
4557 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4558 set_window_height but set heights directly.
4559 (change_frame_size_1): Use resize_frame_windows.
4560
4561 * xdisp.c (init_xdisp): Don't use set_window_height but set
4562 heights directly.
4563
640c8776
SM
4564 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4565 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4566 run_window_configuration_change_hook.
4567
4568 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4569 instead of change_window_heights and run
4570 run_window_configuration_change_hook.
4571
1a13852e
MR
45722011-06-09 Martin Rudalics <rudalics@gmx.at>
4573
4574 * window.c (replace_window): Rename second argument REPLACEMENT to
4575 NEW. New third argument SETFLAG. Rewrite.
4576 (delete_window, make_dummy_parent): Call replace_window with
4577 third argument 1.
4578 (window_list_1): Move down in code.
4579 (run_window_configuration_change_hook): Move set_buffer part
4580 before select_frame_norecord part in order to unwind correctly.
4581 Rename count1 to count.
4582 (recombine_windows, delete_deletable_window, resize_root_window)
4583 (Fdelete_other_windows_internal)
4584 (Frun_window_configuration_change_hook, make_parent_window)
4585 (resize_window_check, resize_window_apply, Fresize_window_apply)
4586 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4587 (Fdelete_window_internal, Fresize_mini_window_internal):
4588 New functions.
1a13852e
MR
4589 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4590
f3d1777e
MR
45912011-06-08 Martin Rudalics <rudalics@gmx.at>
4592
496e208e
MR
4593 * window.h (window): Add some new members to window structure -
4594 normal_lines, normal_cols, new_total, new_normal, clone_number,
4595 splits, nest, prev_buffers, next_buffers.
4596 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4597 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4598
f3d1777e
MR
4599 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4600 Remove.
496e208e
MR
4601 (make_dummy_parent): Set new members of windows structure.
4602 (make_window): Move down in code. Handle new members of window
4603 structure.
4604 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4605 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4606 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4607 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4608 (Fset_window_next_buffers, Fset_window_clone_number):
4609 New functions.
496e208e
MR
4610 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4611 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4612 Doc-string fixes.
4613 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4614 Argument WINDOW can be now internal window too.
4615 (Fwindow_use_time): Move up in code.
4616 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4617 Rewrite doc-string.
4618 (Fset_window_configuration, saved_window)
4619 (Fcurrent_window_configuration, save_window_save): Handle new
4620 members of window structure.
b9e809c2
MR
4621 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4622 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4623 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4624 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4625 Qget_mru_window, Qresize_root_window,
4626 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4627 Qauto_buffer_name; staticpro them.
f3d1777e 4628
abde8f8c
MR
46292011-06-07 Martin Rudalics <rudalics@gmx.at>
4630
4631 * window.c (Fwindow_total_size, Fwindow_left_column)
4632 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4633 (Fwindow_list_1): New functions.
4634 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4635 (Fwindow_width, Fscroll_left, Fscroll_right):
4636 Use window_body_cols instead of window_box_text_cols.
4637 (delete_window, Fset_window_configuration):
4638 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4639 (delete_all_subwindows): Take a window as argument and not a
4640 structure. Rewrite.
190b47e6
MR
4641 (window_loop): Remove handling of GET_LRU_WINDOW and
4642 GET_LARGEST_WINDOW.
4643 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4644
4645 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4646 window_box_text_cols. delete_all_subwindows now takes a
4647 Lisp_Object as argument.
abde8f8c 4648
640c8776
SM
4649 * indent.c (compute_motion, Fcompute_motion):
4650 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4651
fa8a67e6
MR
4652 * frame.c (delete_frame): Call delete_all_subwindows with root
4653 window as argument.
4654
a54e3482
DC
46552011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4656
4657 * fns.c (Fputhash): Document return value.
4658
60002bf5
CY
46592011-06-06 Chong Yidong <cyd@stupidchicken.com>
4660
4661 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4662
0c671da6 46632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4664
b862a52a 4665 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4666
be44ca6c
PE
4667 Check for overflow when converting integer to cons and back.
4668 * charset.c (Fdefine_charset_internal, Fdecode_char):
4669 Use cons_to_unsigned to catch overflow.
4670 (Fencode_char): Use INTEGER_TO_CONS.
4671 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4672 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4673 * data.c (long_to_cons, cons_to_long): Remove.
4674 (cons_to_unsigned, cons_to_signed): New functions.
4675 These signal an error for invalid or out-of-range values.
4676 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4677 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4678 * font.c (Ffont_variation_glyphs):
4679 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4680 * lisp.h: Include <intprops.h>.
4681 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4682 (cons_to_signed, cons_to_unsigned): New decls.
4683 (long_to_cons, cons_to_long): Remove decls.
4684 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4685 (Fprimitive_undo): Use CONS_TO_INTEGER.
4686 * xfns.c (Fx_window_property): Likewise.
4687 * xselect.c: Include <limits.h>.
4688 (x_own_selection, selection_data_to_lisp_data):
4689 Use INTEGER_TO_CONS.
4690 (x_handle_selection_request, x_handle_selection_clear)
4691 (x_get_foreign_selection, Fx_disown_selection_internal)
4692 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4693 (lisp_data_to_selection_data): Use cons_to_unsigned.
4694 (x_fill_property_data): Use cons_to_signed.
4695 Report values out of range.
4696
d1f3d2af
PE
4697 Check for buffer and string overflow more precisely.
4698 * buffer.h (BUF_BYTES_MAX): New macro.
4699 * lisp.h (STRING_BYTES_MAX): New macro.
4700 * alloc.c (Fmake_string):
4701 * character.c (string_escape_byte8):
4702 * coding.c (coding_alloc_by_realloc):
4703 * doprnt.c (doprnt):
4704 * editfns.c (Fformat):
4705 * eval.c (verror):
4706 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4707 since they may not be the same number.
4708 * editfns.c (Finsert_char):
4709 * fileio.c (Finsert_file_contents):
4710 Likewise for BUF_BYTES_MAX.
4711
dd52fcea
PE
4712 * image.c: Use ptrdiff_t, not int, for sizes.
4713 (slurp_file): Switch from int to ptrdiff_t.
4714 All uses changed.
4715 (slurp_file): Check that file size fits in both size_t (for
4716 malloc) and ptrdiff_t (for sanity and safety).
4717
7f9bbdbb
PE
4718 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4719 if b->modtime has its maximal value.
4720
dfe18f82
PE
4721 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4722
84acfcf0
PE
4723 Don't assume time_t can fit into int.
4724 * buffer.h (struct buffer.modtime): Now time_t, not int.
4725 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4726 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4727
ccd9a01a
PE
4728 Minor fixes for signed vs unsigned integers.
4729 * character.h (MAYBE_UNIFY_CHAR):
4730 * charset.c (maybe_unify_char):
4731 * keyboard.c (read_char, reorder_modifiers):
4732 XINT -> XFASTINT, since the integer must be nonnegative.
4733 * ftfont.c (ftfont_spec_pattern):
4734 * keymap.c (access_keymap, silly_event_symbol_error):
4735 XUINT -> XFASTINT, since the integer must be nonnegative.
4736 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4737 since it makes no difference and we prefer signed.
4738 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4739 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4740 nonnegative.
4741
d6d100dd
SM
47422011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4743
4744 * window.h (Fwindow_frame): Declare.
4745
2b6148e4
PE
47462011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4747
4748 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4749 (SPARE_MEMORY): Always define.
4750 (LARGE_REQUEST): Remove.
4751 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4752
f230ecc9
MR
47532011-06-06 Martin Rudalics <rudalics@gmx.at>
4754
727e958e
MR
4755 * lisp.h: Move EXFUNS for Fframe_root_window,
4756 Fframe_first_window and Fset_frame_selected_window to window.h.
4757
4758 * window.h: Move EXFUNS for Fframe_root_window,
4759 Fframe_first_window and Fset_frame_selected_window here from
4760 lisp.h.
4761
4762 * frame.c (Fwindow_frame, Fframe_first_window)
4763 (Fframe_root_window, Fframe_selected_window)
4764 (Fset_frame_selected_window): Move to window.c.
4765 (Factive_minibuffer_window): Move to minibuf.c.
4766 (Fother_visible_frames_p): New function.
4767
4768 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4769
f230ecc9
MR
4770 * window.c (decode_window, decode_any_window): Move up in code.
4771 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4772 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4773 (Fwindow_buffer): Move up and rewrite doc-string.
4774 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4775 (Fwindow_prev): New functions.
727e958e
MR
4776 (Fwindow_frame): Move here from frame.c. Accept any window as
4777 argument.
4778 (Fframe_root_window, Fframe_first_window)
4779 (Fframe_selected_window): Move here from frame.c. Accept frame
4780 or arbitrary window as argument. Update doc-strings.
4781 (Fminibuffer_window): Move up in code.
4782 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4783 (Fset_frame_selected_window): Move here from frame.c.
4784 Marginal rewrite.
727e958e
MR
4785 (Fselected_window, select_window, Fselect_window): Move up in
4786 code. Minor doc-string fixes.
f230ecc9 4787
4d09bcf6
PE
47882011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4789
4790 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4791 Do not assume that spare memory exists; that assumption is valid
4792 only if SYSTEM_MALLOC.
4793 (LARGE_REQUEST): New macro, so that the issue of large requests
4794 is separated from the issue of spare memory.
4795
810928a2
AS
47962011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4797
172418ad
AS
4798 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4799 format. (Bug#8806)
4800
43f862f7
AS
4801 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4802
810928a2
AS
4803 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4804 before statements.
4805
a059fe24
JD
48062011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4807
4808 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4809
4810 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4811
4812 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4813 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4814
989bf368
JB
48152011-06-05 Juanma Barranquero <lekktu@gmail.com>
4816
4817 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4818
4b80f674
CY
48192011-06-04 Chong Yidong <cyd@stupidchicken.com>
4820
4821 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4822 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4823 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4824 New error handlers.
4b80f674
CY
4825 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4826 Obey Vx_select_enable_clipboard_manager. Catch errors in
4827 x_clipboard_manager_save (Bug#8779).
4828 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4829 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4830
99a33b77 48312011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4832
4833 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4834
99a33b77 48352011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4836
4837 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4838 in the current matrix if keep_current_p is non-zero.
4839
8264569d
EZ
48402011-06-04 Eli Zaretskii <eliz@gnu.org>
4841
4842 * bidi.c (bidi_level_of_next_char): Fix last change.
4843
57f97249
EZ
48442011-06-03 Eli Zaretskii <eliz@gnu.org>
4845
fec2107c 4846 Support bidi reordering of text covered by display properties.
57f97249 4847
fec2107c
EZ
4848 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4849 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4850 (bidi_cache_search, bidi_cache_iterator_state)
4851 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4852 (bidi_level_of_next_char, bidi_move_to_visually_next):
4853 Support character positions inside a run of characters covered by a
fec2107c
EZ
4854 display string.
4855 (bidi_paragraph_init, bidi_resolve_explicit_1)
4856 (bidi_level_of_next_char): Call bidi_fetch_char and
4857 bidi_fetch_char_advance instead of FETCH_CHAR and
4858 FETCH_CHAR_ADVANCE.
4859 (bidi_init_it): Initialize new members.
4860 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4861 definitions.
4862 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4863 instead of using explicit *_CHAR codes.
d6d100dd
SM
4864 (bidi_resolve_explicit, bidi_resolve_weak):
4865 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4866 bidirectional text is supported only in multibyte buffers.
4867 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4868 it to initialize the frame_window_p member of struct bidi_it.
4869 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4870 (bidi_resolve_explicit, bidi_resolve_weak)
4871 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4872 bidi_it->nchars is non-positive.
4873 (bidi_level_of_next_char): Don't try to lookup the cache for the
4874 next/previous character if nothing is cached there yet, or if we
4875 were just reseat()'ed to a new position.
c40e2fb2 4876
0e14fe90
EZ
4877 * xdisp.c (set_cursor_from_row): Set start and stop points
4878 according to the row's direction when priming the loop that looks
4879 for the glyph on which to display cursor.
4880 (single_display_spec_intangible_p): Function deleted.
4881 (display_prop_intangible_p): Reimplement to call
4882 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4883 Accept 3 additional arguments needed by handle_display_spec.
4884 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4885 values: lists, `(when COND...)' forms, etc.
4886 (single_display_spec_string_p): Support property values that are
4887 lists with the argument STRING its top-level element.
4888 (display_prop_string_p): Fix the condition for processing a
4889 property that is a list to be consistent with handle_display_spec.
fec2107c 4890 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4891 last portion of handle_display_prop.
4892 (compute_display_string_pos): Accept additional argument
4893 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4894 value of a `display' property is a "replacing spec".
4895 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4896 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4897 the display property, but just return a value indicating whether
4898 the display property will replace the characters it covers.
4899 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4900 frame_window_p members of struct bidi_it.
d6d100dd
SM
4901 (compute_display_string_pos, compute_display_string_end):
4902 New functions.
fec2107c
EZ
4903 (push_it): Accept second argument POSITION, where pop_it should
4904 jump to continue iteration.
4905 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4906
fec2107c
EZ
4907 * keyboard.c (adjust_point_for_property): Adjust the call to
4908 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4909
4910 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4911 (bidi_init_it): Update prototypes.
4912 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4913 (compute_display_string_pos, compute_display_string_end):
4914 Declare prototypes.
fec2107c
EZ
4915 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4916 EMACS_INT.
fc6f18ce 4917
40087514 49182011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4919
57f53182
PE
4920 Malloc failure behavior now depends on size of allocation.
4921 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4922 * lisp.h: Change signatures accordingly.
4923 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4924 All callers changed. (Bug#8762)
4925
4926 * gnutls.c: Use Emacs's memory allocators.
4927 Without this change, the gnutls library would invoke malloc etc.
4928 directly, which causes problems on non-SYNC_INPUT hosts, and which
4929 runs afoul of improving memory_full behavior. (Bug#8761)
4930 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4931 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4932 xfree instead of the default malloc, realloc, free.
4933 (Fgnutls_boot): No need to check for memory allocation failure,
4934 since xmalloc does that for us.
4935
ac32cd99 4936 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4937 * category.c (hash_get_category_set):
4938 * ccl.c (ccl_driver):
4939 * charset.c (Fdefine_charset_internal):
4940 * charset.h (struct charset.hash_index):
4941 * composite.c (get_composition_id, gstring_lookup_cache)
4942 (composition_gstring_put_cache):
4943 * composite.h (struct composition.hash_index):
4944 * dispextern.h (struct image.hash):
4945 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4946 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4947 (hashfn_equal, hashfn_user_defined, make_hash_table)
4948 (maybe_resize_hash_table, hash_lookup, hash_put)
4949 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4950 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4951 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4952 * image.c (make_image, search_image_cache, lookup_image)
4953 (xpm_put_color_table_h):
4954 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4955 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4956 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4957 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4958 * alloc.c (allocate_vectorlike):
4959 Check for overflow in vector size calculations.
4960 * ccl.c (ccl_driver):
4961 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4962 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4963 need to be updated by these changes.
40087514
PE
4964 * fns.c (make_hash_table, maybe_resize_hash_table):
4965 Check for integer overflow with large hash tables.
0de4bb68
PE
4966 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4967 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4968 (SXHASH_REDUCE): New macro.
4969 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4970 Use it instead of discarding useful hash info with large hash values.
4971 (sxhash_float): New function.
4972 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4973 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4974 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4975 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4976 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4977 Adjust signatures to match updated version of code.
4978 (consing_since_gc): Now EMACS_INT, since a single hash table can
4979 use more than INT_MAX bytes.
4980
698d32e2
DN
49812011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4982
4983 Make it possible to build with GCC-4.6+ -O2 -flto.
4984
4985 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4986
fd6fa53f
SM
49872011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4988
4989 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4990 Call minibuffer-inactive-mode.
4991
864db017
JB
49922011-05-31 Juanma Barranquero <lekktu@gmail.com>
4993
4994 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4995 Update dependencies.
4996
2ad0baf4
DN
49972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4998
4999 * data.c (init_data): Remove code for UTS, this system is not
5000 supported anymore.
5001
4fcc2638
DN
50022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5003
5004 Don't force ./temacs to start in terminal mode.
5005
5006 * frame.c (make_initial_frame): Initialize faces in all cases, not
5007 only when CANNOT_DUMP is defined.
5008 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5009
c56e0fd5
DN
50102011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5011
5012 * dispnew.c (add_window_display_history): Use const for the string
5013 pointer. Remove declaration, not needed.
5014
333d54da 50152011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5016
55d4c1b2 5017 Use 'inline', not 'INLINE'.
333d54da 5018 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5019 * alloc.c, fontset.c (INLINE): Remove.
5020 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5021 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5022 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5023 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5024 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5025
738db178
DN
50262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5027
5028 Make it possible to run ./temacs.
5029
5030 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5031 syms_of_callproc does the same thing. Remove test for
5032 "initialized", do it in the caller.
5033 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5034
620c53a6
SM
50352011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5036
5037 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5038 (read_minibuf): Use get_minibuffer.
5039 (syms_of_minibuf): Use DEFSYM.
5040 (Qmetadata): New var.
5041 * data.c (Qbuffer): Don't make it static.
5042 (syms_of_data): Use DEFSYM.
5043
e003a292
PE
50442011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5045
5046 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5047 (CCL_CODE_MIN): New macro.
5048
ed008a6d
PE
50492011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5050
3687c2ef
PE
5051 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5052
ed008a6d
PE
5053 * eval.c (Qdebug): Now static.
5054 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5055 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5056 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5057
d66c4c7c
CY
50582011-05-29 Chong Yidong <cyd@stupidchicken.com>
5059
5060 * image.c: Various fixes to ImageMagick code comments.
5061 (Fimagemagick_types): Doc fix.
5062
5fbc2025
PE
50632011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5064
0196f88a
PE
5065 Minor fixes prompted by GCC 4.6.0 warnings.
5066
5067 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5068
5fbc2025
PE
5069 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5070 (x_clipboard_manager_save_all): Move extern decl to ...
5071 * xterm.h: ... here, so that it can be checked for consistency.
5072
1dd3c2d9
CY
50732011-05-29 Chong Yidong <cyd@stupidchicken.com>
5074
5075 * xselect.c (x_clipboard_manager_save_frame)
5076 (x_clipboard_manager_save_all): New functions.
5077 (Fx_clipboard_manager_save): Lisp function deleted.
5078
5079 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5080 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5081
5082 * xterm.h: Update prototype.
5083
5ba6571d
WX
50842011-05-28 William Xu <william.xwl@gmail.com>
5085
5086 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5087 exiting (Bug#8239).
5088
3eaff834
JM
50892011-05-28 Jim Meyering <meyering@redhat.com>
5090
e1900994 5091 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5092 * fns.c (to_uchar): Define.
5093 (crypto_hash_function): Use it to convert some newly-signed
5094 variables to unsigned, to avoid sign-extension bugs. For example,
5095 without this change, (md5 "truc") would evaluate to
5096 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5097 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5098 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5099
0f6990a7
PE
51002011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5101
5102 Integer overflow fixes.
c8a9ca5a 5103
08686060
PE
5104 * dbusbind.c: Serial number integer overflow fixes.
5105 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5106 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5107 to hold a serial number that is too large for a fixnum.
5108 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5109 Check for serial numbers out of range. Decode any serial number
59568bf0 5110 that was so large that it became a float. (Bug#8722)
08686060 5111
2d1fc3c7
PE
5112 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5113 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5114 Use XFASTINT rather than XUINT when numbers are nonnegative.
5115 (xd_append_arg, Fdbus_method_return_internal):
5116 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5117 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5118 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5119 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5120 (Bug#8722)
2d1fc3c7 5121
c8a9ca5a
PE
5122 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5123
519e1d69
PE
5124 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5125
30569699
PE
5126 ccl: add integer overflow checks
5127 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5128 (IN_INT_RANGE): New macros.
5129 (ccl_driver): Use them to check for integer overflow when
5130 decoding a CCL program. Many of the new checks are whether XINT (x)
5131 fits in int; it doesn't always, on 64-bit hosts. The new version
5132 doesn't catch all possible integer overflows, but it's an
847044ea 5133 improvement. (Bug#8719)
30569699 5134
c11285dc
PE
5135 * alloc.c (make_event_array): Use XINT, not XUINT.
5136 There's no need for unsigned here.
5137
fdccd48e
PE
5138 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5139 This follows up to the 2011-05-06 change that substituted uintptr_t
5140 for EMACS_INT. This case wasn't caught back then.
5141
37910ab2
PE
5142 Rework Fformat to avoid integer overflow issues.
5143 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5144 now (part of C89). Include <verify.h>.
5145 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5146 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5147 (Fformat): Avoid the prepass trying to compute sizes; it was only
5148 approximate and thus did not catch overflow reliably. Instead, walk
5149 through the format just once, formatting and computing sizes as we go,
5150 checking for integer overflow at every step, and allocating a larger
5151 buffer as needed. Keep track separately whether the format is
5152 multibyte. Keep only the most-recently calculated precision, rather
5153 than them all. Record whether each argument has been converted to
5154 string. Use EMACS_INT, not int, for byte and char and arg counts.
5155 Support field widths and precisions larger than INT_MAX. Avoid
5156 sprintf's undefined behavior with conversion specifications such as %#d
5157 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5158 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5159 formatting out-of-range floating point numbers with int
9173deec 5160 formats. (Bug#8668)
37910ab2 5161
2e6578fb
PE
5162 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5163
0ae6bdee
PE
5164 * data.c: Avoid integer truncation in expressions involving floats.
5165 * data.c: Include <intprops.h>.
5166 (arith_driver): When there's an integer overflow in an expression
5167 involving floating point, convert the integers to floating point
5168 so that the resulting value does not suffer from catastrophic
5169 integer truncation. For example, on a 64-bit host (* 4
5170 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5171 Do not rely on undefined behavior after integer overflow.
5172
de883a70
PE
5173 merge count_size_as_multibyte, parse_str_to_multibyte
5174 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5175 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5176 Check for integer overflow.
5177 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5178 since it's now a duplicate of the other. This is more of
5179 a character than a buffer op, so better that it's in character.c.
5180 * fns.c, print.c: Adjust to above changes.
5181
2ff916cb
PE
51822011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5183
5184 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5185
f1b54466
PE
51862011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5187
fb1ac845
PE
5188 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5189 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5190 (x_clipboard_manager_save): Now static.
5191 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5192
f1b54466
PE
5193 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5194 (crypto_hash_function): Now static.
5195 Fix pointer signedness problems. Avoid unnecessary initializations.
5196
a9f737ee
CY
51972011-05-27 Chong Yidong <cyd@stupidchicken.com>
5198
5199 * termhooks.h (Vselection_alist): Make it terminal-local.
5200
5201 * terminal.c (create_terminal): Initialize it.
5202
5203 * xselect.c: Support for clipboard managers.
5204 (Vselection_alist): Move to termhooks.h as terminal-local var.
5205 (LOCAL_SELECTION): New macro.
5206 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5207 (symbol_to_x_atom): Remove gratuitous arg.
5208 (x_handle_selection_request, lisp_data_to_selection_data)
5209 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5210 (x_own_selection, x_get_local_selection, x_convert_selection):
5211 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5212 (some_frame_on_display): Delete unused function.
5213 (Fx_own_selection_internal, Fx_get_selection_internal)
5214 (Fx_disown_selection_internal, Fx_selection_owner_p)
5215 (Fx_selection_exists_p): New optional frame arg.
5216 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5217 (x_handle_selection_clear): Don't treat other terminals with the
5218 same keyboard specially. Use the terminal-local Vselection_alist.
5219 (x_clear_frame_selections): Use Frun_hook_with_args.
5220
5221 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5222
5223 * xterm.h: Add support for those atoms.
5224
e067f0c1
CY
52252011-05-26 Chong Yidong <cyd@stupidchicken.com>
5226
5227 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5228 (converted_selections, conversion_fail_tag): New global variables.
5229 (x_selection_request_lisp_error): Free the above.
5230 (x_get_local_selection): Remove unnecessary code.
5231 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5232 of converted selections stored in converted_selections.
5233 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5234 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5235 (x_convert_selection): New function.
5236 (x_handle_selection_event): Simplify.
5237 (x_get_foreign_selection): Don't ignore incoming requests while
5238 waiting for an answer; this will fail when we implement
5239 SAVE_TARGETS, and seems unnecessary anyway.
5240 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5241 (Vx_sent_selection_functions): Doc fix.
5242
0f4aebc0
LL
52432011-05-26 Leo Liu <sdl.web@gmail.com>
5244
5245 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5246
e61124cd
YM
52472011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5248
5249 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5250
5251 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5252 for fringe update if it has periodic bitmap.
ac389d0c 5253 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5254 and fringe_bitmap_periodic_p.
5255
5256 * fringe.c (get_fringe_bitmap_data): New function.
5257 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5258 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5259 row. Mark glyph row for fringe update if periodicity changed.
5260
5261 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5262 for fringe update unless it has periodic bitmap.
5263
f16d9837
KH
52642011-05-25 Kenichi Handa <handa@m17n.org>
5265
5266 * xdisp.c (get_next_display_element): Set correct it->face_id for
5267 a static composition.
5268
e1b90ef6
LL
52692011-05-24 Leo Liu <sdl.web@gmail.com>
5270
5271 * deps.mk (fns.o):
5272 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5273
5274 * fns.c (crypto_hash_function, Fsha1): New function.
5275 (Fmd5): Use crypto_hash_function.
5276 (syms_of_fns): Add Ssha1.
5277
7400048f
PE
52782011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5279
5280 * gnutls.c: Remove unused macros.
5281 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5282 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5283 Remove macros that are defined and never used.
5284 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5285
abb71cf4
CY
52862011-05-22 Chong Yidong <cyd@stupidchicken.com>
5287
5288 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5289 (Fx_get_selection_internal): Minor cleanup.
5290 (Fx_own_selection_internal): Rename arguments for consistency with
5291 select.el.
5292
6307db39
PE
52932011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5294
5295 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5296
f3d4e0a4
CY
52972011-05-22 Chong Yidong <cyd@stupidchicken.com>
5298
5299 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5300
4d8ade89
YM
53012011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5302
5303 * dispnew.c (scrolling_window): Don't exclude the case that the
5304 last enabled row in the desired matrix touches the bottom boundary.
5305
32078c8d
GM
53062011-05-21 Glenn Morris <rgm@gnu.org>
5307
5308 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5309 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5310 and add some more files.
32078c8d 5311
7285dc67
EZ
53122011-05-20 Eli Zaretskii <eliz@gnu.org>
5313
5314 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5315 report_file_error introduced by the change from 2011-05-07.
5316
89d1bd22
PE
53172011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5318
5319 * systime.h (Time): Define only if emacs is defined.
5320 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5321 where the include path doesn't have X11/X.h by default. See
5322 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5323
e23640bb 53242011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5325
5326 * composite.c (find_automatic_composition): Fix previous change.
5327
b9704ad9
GM
53282011-05-20 Glenn Morris <rgm@gnu.org>
5329
5330 * lisp.mk: New file, split from Makefile.in.
5331 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5332 (shortlisp): Remove.
5333 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5334
4a720484
GM
53352011-05-19 Glenn Morris <rgm@gnu.org>
5336
5337 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5338 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5339 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5340 (lisp): Set the order to that of loadup.el.
5341 (shortlisp): Make it a copy of $lisp.
5342 (SOME_MACHINE_LISP): Remove.
5343 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5344 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5345
a28d4396
KH
53462011-05-18 Kenichi Handa <handa@m17n.org>
5347
5348 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5349 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5350 (find_automatic_composition): Mostly rewrite for efficiency.
5351
a2b1fa8e
JB
53522011-05-18 Juanma Barranquero <lekktu@gmail.com>
5353
5354 * makefile.w32-in: Update dependencies.
5355
8e1f5610
CS
53562011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5357
5358 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5359 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5360
7025ee00 53612011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5362
cdfa6eab
PE
5363 Fix some integer overflow issues, such as string length overflow.
5364
06d6db33
PE
5365 * insdel.c (count_size_as_multibyte): Check for string overflow.
5366
2b4560a8
PE
5367 * character.c (lisp_string_width): Check for string overflow.
5368 Use EMACS_INT, not int, for string indexes and lengths; in
5369 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5370 the resulting string length overflows an EMACS_INT; instead,
5371 report a string overflow if no precision given. When checking for
5372 precision exhaustion, use a check that cannot possibly have
5373 integer overflow. (Bug#8675)
5374 * character.h (lisp_string_width): Adjust to new signature.
5375
cb93f9be
PE
5376 * alloc.c (string_overflow): New function.
5377 (Fmake_string): Use it. This doesn't change behavior, but saves
5378 a few bytes and will simplify future changes.
5379 * character.c (string_escape_byte8): Likewise.
5380 * lisp.h (string_overflow): New decl.
5381
1a1f3366
PE
5382 Fixups, following up to the user-interface timestamp change.
5383 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5384 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5385 * msdos.c (mouse_get_pos): Likewise.
5386 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5387 * w32gui.h (Time): Define by including "systime.h" rather than by
5388 declaring it ourselves. (Bug#8664)
5389
d4e3e4d3
PE
5390 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5391 * image.c (clear_image_cache): Likewise.
5392
f6a24d19
PE
5393 * term.c (term_mouse_position): Don't assume time_t wraparound.
5394
08dc5ae6
PE
5395 Be more systematic about user-interface timestamps.
5396 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5397 and sometimes 'EMACS_UINT', to represent these timestamps.
5398 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5399 This makes the code easier to follow, and makes it easier to catch
5400 integer overflow bugs such as Bug#8664.
5401 * frame.c (Fmouse_position, Fmouse_pixel_position):
5402 Use Time, not unsigned long, for user-interface timestamps.
5403 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5404 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5405 * keyboard.h (last_event_timestamp): Likewise.
5406 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5407 * menu.h (xmenu_show): Likewise.
5408 * term.c (term_mouse_position): Likewise.
5409 * termhooks.h (struct input_event.timestamp): Likewise.
5410 (struct terminal.mouse_position_hook): Likewise.
5411 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5412 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5413 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5414 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5415 what it was before.
5416 * menu.h, termhooks.h: Include "systime.h", for Time.
5417
8e55734a
PE
5418 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5419 Don't assume that the difference between two unsigned long values
5420 can fit into an integer. At this point, we know button_down_time
5421 <= event->timestamp, so the difference must be nonnegative, so
5422 there's no need to cast the result if double-click-time is
5423 nonnegative, as it should be; check that it's nonnegative, just in
5424 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5425 apart (about 25 days). (Bug#8664)
8e55734a 5426
841f1b75 5427 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5428 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5429
3e26f69c
PE
5430 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5431 that always fit in int. Use a sentinel instead of a counter, to
5432 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5433 * frame.h (struct frame): Use int for menu_bar_items_used
5434 instead of EMACS_INT, since it always fits in int.
3e26f69c 5435
5cc152c0
PE
5436 * menu.c (grow_menu_items): Check for int overflow.
5437
d89eb65e
PE
5438 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5439
5235bd3e
PE
5440 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5441 Before, the code was not consistent. These values cannot exceed
5442 2**31 - 1 so there's no need to make them unsigned.
5443 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5444 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5445 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5446 as modifiers.
5447 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5448
bc827e23
PE
5449 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5450 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5451 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5452 presumably because the widths might not match.
5453
78eb494e
PE
5454 * window.c (size_window): Avoid needless test at loop start.
5455
04f2d78b
CB
54562011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5457
5458 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5459
d2fc7e3d 54602011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5461
5462 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5463
d2fc7e3d 54642011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5465
5466 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5467 `width' to `bar_area_x' and `bar_area_width', respectively.
5468 (x_scroll_run): Take account of fringe background extension.
5469
04f2d78b
CB
5470 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5471 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5472 `bar_area_width', respectively.
5473 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5474 background extension.
5475
79b70037
GM
54762011-05-10 Jim Meyering <meyering@redhat.com>
5477
5478 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5479
2f142cc5
JB
54802011-05-10 Juanma Barranquero <lekktu@gmail.com>
5481
5482 * image.c (Finit_image_library): Return t for built-in image types,
5483 like pbm and xbm. (Bug#8640)
5484
57679c86
AS
54852011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5486
5487 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5488
888c9e86
EZ
54892011-05-07 Eli Zaretskii <eliz@gnu.org>
5490
b0512a1d
EZ
5491 * w32console.c (Fset_screen_color): Doc fix.
5492 (Fget_screen_color): New function.
5493 (syms_of_ntterm): Defsubr it.
5494
7285dc67
EZ
5495 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5496 unlink the temporary file if Fcall_process didn't create it in the
5497 first place.
5498 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5499 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5500 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5501 cue to call_process_cleanup not to close that handle.
5502
4d3fcc8e
BK
55032011-05-07 Ben Key <bkey76@gmail.com>
5504
5505 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5506 one of two shell specific rules, either bootstrap-temacs-CMD or
5507 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5508 to the previous implementation of the bootstrap-temacs rule.
5509 The bootstrap-temacs-CMD rule is similar to the previous
5510 implementation of the bootstrap-temacs rule except that it
5511 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5512 variable.
5513
5514 These changes, along with some changes to nt/configure.bat,
5515 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5516 earlier fix to add support for --cflags and --ldflags options
5517 that include quotes so that it works whether make uses cmd or
5518 sh as the shell.
5519
b4289b64
MA
55202011-05-06 Michael Albinus <michael.albinus@gmx.de>
5521
5522 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5523 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5524 is a constant.
5525 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5526 a string. Handle both cases.
5527 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5528 (Fdbus_register_method): Use Qinvalid_function.
5529
af4c0e28
JB
55302011-05-06 Juanma Barranquero <lekktu@gmail.com>
5531
5532 * makefile.w32-in: Update dependencies.
5533 (LISP_H): Add inttypes.h and stdin.h.
5534 (PROCESS_H): Add unistd.h.
5535
c51453d9
EZ
55362011-05-06 Eli Zaretskii <eliz@gnu.org>
5537
5538 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5539 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5540
8ff0ac3c 55412011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5542
4c4b566b
PE
5543 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5544
aab2b9b5
PE
5545 * term.c (vfatal): Remove stray call to va_end.
5546 It's not needed and the C Standard doesn't allow it here anyway.
5547
c378da0b
PE
5548 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5549 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5550
288b08c7
PE
5551 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5552 bytes.
5553
e3601888
PE
5554 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5555
db6c0e74
PE
5556 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5557
dd5963ea
PE
5558 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5559
88c9450f
PE
5560 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5561
2f9442b8
PE
5562 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5563
c032b5f8
PE
5564 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5565 * charset.c (Fdefine_charset_internal): Don't initialize
5566 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5567 32-bit int (Bug#8600).
a108c10b
PE
5568
5569 * lread.c (read_integer): Be more consistent with string-to-number.
5570 Use string_to_number to do the actual conversion; this avoids
5571 rounding errors and fixes some other screwups. Without this fix,
5572 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5573 (digit_to_number): Move earlier, for benefit of read_integer.
5574 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5575 not a digit in any supported base. (Bug#8602)
a108c10b 5576
ad5f9eea
PE
5577 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5578
aec1708a
PE
5579 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5580 to match comment at start of function. This also removes a
5581 GCC warning about overflow in a 32+64-bit port.
5582
47be4ab5
PE
5583 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5584
371cac43
PE
5585 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5586 Reported by Stefan Monnier in
5587 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5588 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5589 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5590
d01a7826
PE
5591 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5592 (EMACS_UINTPTR): Likewise, with uintptr_t.
5593
7fd47d5c
PE
5594 * lisp.h: Prefer 64-bit EMACS_INT if available.
5595 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5596 on 32-bit hosts that have 64-bit int, so that they can access
5597 large files.
122b0c86
PE
5598 However, temporarily disable this change unless the temporary
5599 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5600
8727937b
PE
5601 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5602
8ac068ac
PE
5603 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5604 This removes an assumption that EMACS_INT and long are the same
5605 width as pointers. The assumption is true for Emacs porting targets
5606 now, but we want to make other targets possible.
5607 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5608 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5609 In the rest of the code, change types of integers that hold casted
5610 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5611 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5612 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5613 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5614 No need to cast type when ORing.
5615 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5616 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5617 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5618 assume EMACS_INT is the same width as char *.
5619 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5620 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5621 Remove no-longer-needed casts.
5622 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5623 (xg_tool_bar_help_callback, xg_make_tool_item):
5624 Use EMACS_INTPTR to hold an integer
5625 that will be cast to void *; this can avoid a GCC warning
5626 if EMACS_INT is not the same width as void *.
5627 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5628 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5629 (current_message_1, set_message_1):
5630 Use a local to convert to proper width without a cast.
5631 * xmenu.c (dialog_selection_callback): Likewise.
5632
ede49d71
PE
5633 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5634 Also, don't assume VALBITS / RAND_BITS is less than 5,
5635 and don't rely on undefined behavior when shifting a 1 left into
5636 the sign bit.
5637 * lisp.h (get_random): Change signature to match.
5638
2f30ecd0
PE
5639 * lread.c (hash_string): Use size_t, not int, for hash computation.
5640 Normally we prefer signed values; but hashing is special, because
5641 it's better to use unsigned division on hash table sizes so that
5642 the remainder is nonnegative. Also, size_t is the natural width
5643 for hashing into memory. The previous code used 'int', which doesn't
5644 retain enough info to hash well into very large tables.
5645 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5646
2a866e7b
PE
5647 * dbusbind.c: Don't possibly lose pointer info when converting.
5648 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5649 Use XPNTR rather than XHASH, so that the high-order bits of
5650 the pointer aren't lost when converting through void *.
5651
51639eac
PE
5652 * eval.c (Fautoload): Don't double-shift a pointer.
5653
92394119
PE
5654 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5655
dbdb9a7c
JB
56562011-05-06 Juanma Barranquero <lekktu@gmail.com>
5657
5658 * gnutls.c (DEF_GNUTLS_FN):
5659 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5660
db7a0b4f
AS
56612011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5662
5663 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5664 marker. (Bug#8610)
5665
f7ff1b0f 56662011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5667
5668 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5669 New version that can reserve upto 2GB of heap space.
5670
f7ff1b0f 56712011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5672
5673 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5674
639c109b
TZ
56752011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5676
5677 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5678 `gnutls_certificate_set_x509_key_file'.
5679
d2127135
JB
56802011-05-05 Juanma Barranquero <lekktu@gmail.com>
5681
5682 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5683 Update dependencies.
5684
e968f4f3
JB
56852011-05-04 Juanma Barranquero <lekktu@gmail.com>
5686
5687 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5688 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5689 Remove unused parameter `fildes'.
5690 * process.c (read_process_output, send_process): Don't pass it.
5691
84d358f0
JB
56922011-05-04 Juanma Barranquero <lekktu@gmail.com>
5693
5694 Fix previous change: the library cache is defined in w32.c.
5695 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5696 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5697
0898ca10
JB
56982011-05-04 Juanma Barranquero <lekktu@gmail.com>
5699
5700 Implement dynamic loading of GnuTLS on Windows.
5701
5702 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5703 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5704 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5705 Declare.
5706
5707 * gnutls.c (Qgnutls_dll): Define.
5708 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5709 (gnutls_*): Declare function pointers.
5710 (init_gnutls_functions): New function to initialize function pointers.
5711 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5712 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5713 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5714 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5715 (emacs_gnutls_write, emacs_gnutls_read)
5716 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5717 (Fgnutls_available_p): New function.
5718 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5719 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5720 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5721
5722 * image.c: Include w32.h.
5723 (Vimage_type_cache): Delete.
5724 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5725 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5726 (w32_delayed_load): Move to w32.c.
5727
5728 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5729
5730 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5731 (w32_delayed_load): Move from image.c. When loading a library, record
5732 its filename in the :loaded-from property of the library id.
5733 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5734 Initialize and staticpro them.
5735 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5736
5737 * process.c: Include lisp.h before w32.h, not after.
5738 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5739 instead of gnutls_record_check_pending.
5740
5741 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5742
ff4de4aa
TZ
57432011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5744
5745 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5746 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5747 as passed in.
5748
abe95abb
JD
57492011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5750
5751 * xterm.c (x_set_frame_alpha): Do not set property on anything
5752 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5753
e16e55d4
JB
57542011-05-02 Juanma Barranquero <lekktu@gmail.com>
5755
5756 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5757
bafcf6a5
JB
57582011-05-02 Juanma Barranquero <lekktu@gmail.com>
5759
5760 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5761 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5762 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5763 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5764 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5765 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5766 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5767 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5768 (Qgnutls_bootprop_callbacks_verify): Make static.
5769
e7a6747f
AS
57702011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5771
19ed11ba
AS
5772 * callproc.c: Indentation fixup.
5773
e7a6747f 5774 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5775 (wait_for_termination, interruptible_wait_for_termination):
5776 Move after wait_for_termination_1.
e7a6747f 5777
1ef14cb4
LMI
57782011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5779
5780 * sysdep.c (interruptible_wait_for_termination): New function
5781 which is like wait_for_termination, but allows keyboard
5782 interruptions.
5783
5784 * callproc.c (Fcall_process): Add (:file "file") as an option for
5785 the STDOUT buffer.
5786 (Fcall_process_region): Ditto.
5787
330d880c
EZ
57882011-04-30 Eli Zaretskii <eliz@gnu.org>
5789
8db90b73
EZ
5790 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5791 rather than `XVECTOR (FOO)->size'.
5792
330d880c
EZ
5793 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5794 inttypes.h, as a gnulib replacement is used if it not available in
5795 system headers.
5796
15cbd324
EZ
57972011-04-21 Eli Zaretskii <eliz@gnu.org>
5798
5799 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5800 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5801 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5802
5803 * coding.c (coding_alloc_by_realloc): Error out if destination
5804 will grow beyond MOST_POSITIVE_FIXNUM.
5805 (decode_coding_emacs_mule): Abort if there isn't enough place in
5806 charbuf for the composition carryover bytes. Reserve an extra
5807 space for up to 2 characters produced in a loop.
5808 (decode_coding_iso_2022): Abort if there isn't enough place in
5809 charbuf for the composition carryover bytes.
5810
58112011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5812
ae940cca
EZ
5813 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5814 aborting when %lld or %lll format is passed.
5815 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5816 %llo or %llx format is passed. (Bug#8545)
5817
03ab8921
EZ
5818 * window.c (window_scroll_line_based): Use a marker instead of
5819 simple variables to record original value of point. (Bug#7952)
5820
afda1437
EZ
5821 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5822 produced by %s or %c overflows available buffer space. (Bug#8545)
5823
f76dee0c
PE
58242011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5825
5826 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5827 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5828
fdc5744d
JB
58292011-04-28 Juanma Barranquero <lekktu@gmail.com>
5830
5831 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5832
638f053a
JB
58332011-04-28 Juanma Barranquero <lekktu@gmail.com>
5834
5835 * keyboard.c (Qdelayed_warnings_hook): Define.
5836 (command_loop_1): Run `delayed-warnings-hook'
5837 if Vdelayed_warnings_list is non-nil.
5838 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5839 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5840
d178f871
EZ
58412011-04-28 Eli Zaretskii <eliz@gnu.org>
5842
5843 * doprnt.c (doprnt): Don't return value smaller than the buffer
5844 size if the message was truncated. (Bug#8545).
5845
b124fd93
JB
58462011-04-28 Juanma Barranquero <lekktu@gmail.com>
5847
5848 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5849 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5850
e810457d
PE
58512011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5852
5853 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5854
ea51cceb
JB
58552011-04-27 Juanma Barranquero <lekktu@gmail.com>
5856
5857 * makefile.w32-in: Update dependencies.
5858
94dcfacf
EZ
58592011-04-27 Eli Zaretskii <eliz@gnu.org>
5860
5861 Improve `doprnt' and its usage. (Bug#8545)
5862 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5863 `format_end'. Remove support for %l as a conversion specifier.
5864 Don't use xrealloc. Improve diagnostics when the %l size modifier
5865 is used. Update the commentary.
5866
5867 * eval.c (verror): Simplify calculation of size_t.
5868
5869 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5870 messages.
5871
f61f41d7
PE
58722011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5873
5874 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5875 change.
5876
96fb4434
PE
58772011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5878
5879 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5880 This makes this file independent of the recent pseudovector change.
5881
671875da 58822011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5883
69e9b5a3
PE
5884 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5885
b5f869a7 5886 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5887 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5888 Remove unused local.
c8926152 5889 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5890
841a1577 5891 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5892 GCC 4.6.0 optimizes based on type-based alias analysis.
5893 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5894 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5895 != &v->size, and therefore "v->size = 1; b->size = 2; return
5896 v->size;" must therefore return 1. This assumption is incorrect
5897 for Emacs, since it type-puns struct Lisp_Vector * with many other
5898 types. To fix this problem, this patch adds a new type struct
f904488f 5899 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5900 and pseudovectors, and helps optimizing compilers not get fooled
5901 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5902 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5903 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5904 the size member.
eab3844f
PE
5905 (XSETPVECTYPE): Rewrite in terms of new macro.
5906 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5907 This is a bit clearer, and further avoids the possibility of
5908 undesirable aliasing.
5909 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5910 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5911 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5912 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5913 (ASIZE): Now uses header.size rather than size.
5914 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5915 to avoid the hassle of writing XVECTOR (foo)->header.size.
5916 (struct vectorlike_header): New type.
eab3844f
PE
5917 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5918 object, to help avoid aliasing.
5919 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5920 (SUBRP): Likewise, since Lisp_Subr is a special case.
5921 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5922 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5923 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5924 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5925 changed to be "header.size" and "header.next".
5926 * buffer.h (struct buffer): Likewise.
5927 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5928 * frame.h (struct frame): Likewise.
5929 * process.h (struct Lisp_Process): Likewise.
5930 * termhooks.h (struct terminal): Likewise.
5931 * window.c (struct save_window_data, struct saved_window): Likewise.
5932 * window.h (struct window): Likewise.
5933 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5934 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5935 * buffer.c (init_buffer_once): Likewise.
5936 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5937 special case.
5938 * process.c (Fformat_network_address): Use local var for size,
5939 for brevity.
5940
0df1eac5
PE
5941 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5942
847ab9d1 5943 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5944 * data.c (atof): Remove decl; no longer used or needed.
5945 (digit_to_number): Move to lread.c.
5946 (Fstring_to_number): Use new string_to_number function, to be
5947 consistent with how the Lisp reader treats infinities and NaNs.
5948 Do not assume that floating-point numbers represent EMACS_INT
5949 without losing information; this is not true on most 64-bit hosts.
5950 Avoid double-rounding errors, by insisting on integers when
5951 parsing non-base-10 numbers, as the documentation specifies.
5952 * lisp.h (string_to_number): New decl, replacing ...
5953 (isfloat_string): Remove.
bc0a5c13 5954 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5955 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5956 appears to have been a coding error. Similarly, do not accept
5957 strings like +-1e0 as floating point numbers. Do not report
5958 overflow for integer overflows unless the base is not 10 which
5959 means we have no simple and reliable way to continue.
5960 Break out the floating-point parsing into a new
5961 function string_to_number, so that Fstring_to_number parses
5962 floating point numbers consistently with the Lisp reader.
04f2d78b 5963 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5964 (E_CHAR, EXP_INT): Remove, replacing with ...
5965 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5966 (string_to_number): New function, replacing isfloat_string.
5967 This function checks for valid syntax and produces the resulting
5968 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5969 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5970 so that overflow for non-base-10 numbers is reported only when
5971 there's no portable and simple way to convert to floating point.
452f4150 5972
67769ffc
PE
5973 * textprop.c (set_text_properties_1): Rewrite for clarity,
5974 and to avoid GCC warning about integer overflow.
5975
c20db43f
PE
5976 * intervals.h (struct interval): Use EMACS_INT for members
5977 where EMACS_UINT might cause problems. See
5978 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5979 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5980 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5981 All uses changed.
37aa2f85
PE
5982 (offset_intervals): Tell GCC not to worry about length overflow
5983 when negating a negative length.
c20db43f 5984
2538aa2f
PE
5985 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5986 (overrun_check_free): Likewise.
5987
f2d3008d
PE
5988 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5989 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5990 word size.
5991
ec8df744
PE
5992 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5993 (gnutls_make_error): Rename local to avoid shadowing.
5994 (gnutls_emacs_global_deinit): ifdef out; not used.
5995 (Fgnutls_boot): Use const for pointer to readonly storage.
5996 Comment out unused local. Fix pointer signedness problems.
5997
640ee02d
PE
5998 * lread.c (openp): Don't stuff size_t into an 'int'.
5999 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6000 about possible signed overflow.
6001
6048fb2a
PE
6002 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6003 (GDK_KEY_g): Don't define if already defined.
6004 (xg_prepare_tooltip): Avoid pointer signedness problem.
6005 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6006
fa3c87e1
PE
6007 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6008 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6009
2172544b
PE
6010 * xfns.c (Fx_window_property): Simplify a bit,
6011 to make a bit faster and to avoid GCC 4.6.0 warning.
6012 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6013
9b821a21
PE
6014 * fns.c (internal_equal): Don't assume size_t fits in int.
6015
3c616cfa
PE
6016 * alloc.c (compact_small_strings): Tighten assertion a little.
6017
c2982e87
PE
6018 Replace pEd with more-general pI, and fix some printf arg casts.
6019 * lisp.h (pI): New macro, generalizing old pEd macro to other
6020 conversion specifiers. For example, use "...%"pI"d..." rather
6021 than "...%"pEd"...".
6022 (pEd): Remove. All uses replaced with similar uses of pI.
6023 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6024 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6025 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6026 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6027 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6028 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6029 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6030 64-bit hosts.
6031 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6032 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6033 * print.c (safe_debug_print, print_object): Likewise.
6034 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6035 to int.
6f04d126
PE
6036 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6037 avoiding the 0 flag, which is not portable.
c2982e87
PE
6038 * process.c (Fmake_network_process): Use pI to avoid cast.
6039 * region-cache.c (pp_cache): Likewise.
6040 * xdisp.c (decode_mode_spec): Likewise.
6041 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6042 behavior on 64-bit hosts with printf arg.
6f04d126 6043 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6044 (x_stop_queuing_selection_requests): Likewise.
6045 (x_get_window_property): Don't truncate byte count to an 'int'
6046 when tracing.
0b432f21 6047
5e073ec7
PE
6048 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6049 here, since it parses constructs like leading '-' and spaces,
6050 which are not wanted; and it overflows with large numbers.
6051 Instead, simply match F[0-9]+, which is what is wanted anyway.
6052
36372bf9
PE
6053 * alloc.c: Remove unportable assumptions about struct layout.
6054 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6055 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6056 (allocate_vectorlike, make_pure_vector): Use the new macros,
6057 plus offsetof, to remove unportable assumptions about struct layout.
6058 These assumptions hold on all porting targets that I know of, but
6059 they are not guaranteed, they're easy to remove, and removing them
6060 makes further changes easier.
6061
0b432f21
PE
6062 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6063 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6064 (string_overrun_cookie): Now const. Use initializers that
6065 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6066 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6067 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6068 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6069 multiple of sizeof (EMACS_INT); it need not be, if
6070 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6071 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6072
895009e1
JB
60732011-04-26 Juanma Barranquero <lekktu@gmail.com>
6074
6075 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6076
6a7a1b0b
TZ
60772011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6078
6079 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6080 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6081 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6082
841a1577 60832011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6084
6085 * lisp.h (Qdebug): List symbol.
895009e1 6086 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6087 * keyboard.c (debug-on-event): New variable.
6088 (handle_user_signal): Break into debugger when debug-on-event
6089 matches the current signal symbol.
6090
f2d3ba6f
DN
60912011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6092
6093 * alloc.c (check_sblock, check_string_bytes)
6094 (check_string_free_list): Convert to standard C.
6095
42ce4c63
TZ
60962011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6097
6098 * w32.c (emacs_gnutls_push): Fix typo.
6099
825cd63c
EZ
61002011-04-25 Eli Zaretskii <eliz@gnu.org>
6101
fb11d64d
EZ
6102 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6103 "cast to pointer from integer of different size".
6104
825cd63c
EZ
6105 Improve doprnt and its use in verror. (Bug#8545)
6106 * doprnt.c (doprnt): Document the set of format control sequences
6107 supported by the function. Use SAFE_ALLOCA instead of always
6108 using `alloca'.
6109
6110 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6111 is one byte too soon. Don't use xrealloc; instead xfree and
6112 xmalloc anew.
6113
e061a11b
TZ
61142011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6115
6116 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6117 callbacks stage.
6118
6119 * gnutls.c: Renamed global_initialized to
6120 gnutls_global_initialized. Added internals for the
6121 :verify-hostname-error, :verify-error, and :verify-flags
6122 parameters of `gnutls-boot' and documented those parameters in the
6123 docstring. Start callback support.
9173deec
JB
6124 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6125 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6126 on error. Return error code.
e061a11b
TZ
6127 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6128 (emacs_gnutls_read): Likewise.
6129 (Fgnutls_boot): Return handshake error code.
6130 (emacs_gnutls_handle_error): New function.
6131 (wsaerror_to_errno): Likewise.
6132
6133 * w32.h (emacs_gnutls_pull): Add prototype.
6134 (emacs_gnutls_push): Likewise.
6135
6136 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6137 (emacs_gnutls_push): Likewise.
6138
61392011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6140
6141 * process.c (wait_reading_process_output): Check if GnuTLS
6142 buffered some data internally if no FDs are set for TLS
6143 connections.
6144
6145 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6146 (LIBS): Link to USER_LIBS.
6147 ($(BLD)/gnutls.$(0)): New target.
6148
fa6996bc
EZ
61492011-04-24 Eli Zaretskii <eliz@gnu.org>
6150
eb35682e
EZ
6151 * xdisp.c (handle_single_display_spec): Rename the
6152 display_replaced_before_p argument into display_replaced_p, to
6153 make it consistent with the commentary. Fix typos in the
6154 commentary.
6155
e2ad650c
EZ
6156 * textprop.c (syms_of_textprop): Remove dead code.
6157 (copy_text_properties): Delete obsolete commentary about an
6158 interface that was deleted long ago. Fix typos in the description
6159 of arguments.
6160
1b2de274
EZ
6161 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6162 to changes in oldXMenu/XMenu.h from 2011-04-16.
6163 <menu_help_message, prev_menu_help_message>: Constify.
6164 (IT_menu_make_room): menu->help_text is now `const char **';
6165 adjust.
6166
6167 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6168 to changes in oldXMenu/XMenu.h from 2011-04-16.
6169 (struct XMenu): Declare `help_text' `const char **'.
6170
6171 * xfaces.c <Qunspecified>: Make extern again.
6172
6173 * syntax.c: Include sys/types.h before including regex.h, as
6174 required by Posix.
6175
762b15be
EZ
6176 * doc.c (get_doc_string): Improve the format passed to `error'.
6177
6178 * doprnt.c (doprnt): Improve commentary.
6179
6180 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6181
6182 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6183 them with etags.
6184
f1052e5d
EZ
6185 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6186 changes in globals.h immediately force recompilation.
762b15be
EZ
6187 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6188 $(CURDIR)/s/ms-w32.h.
6189 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6190
fa6996bc
EZ
6191 * character.c (Fchar_direction): Function deleted.
6192 (syms_of_character): Don't defsubr it.
6193 <char-direction-table>: Deleted.
6194
e6c3da20
EZ
61952011-04-23 Eli Zaretskii <eliz@gnu.org>
6196
6197 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6198 * doprnt.c: Include limits.h.
6199 (SIZE_MAX): New macro.
04f2d78b
CB
6200 (doprnt): Return a size_t value. 2nd arg is now size_t.
6201 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6202 Improve overflow protection. Support `l' modifier for integer
6203 conversions. Support %l conversion. Don't assume an EMACS_INT
6204 argument for integer conversions and for %c.
6205
6206 * lisp.h (doprnt): Restore prototype.
6207
6208 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6209 $(SRC)/character.h.
6210
6211 * Makefile.in (base_obj): Add back doprnt.o.
6212
6213 * deps.mk (doprnt.o): Add back prerequisites.
6214 (callint.o): Depend on character.h.
6215
6216 * eval.c (internal_lisp_condition_case): Include the handler
6217 representation in the error message.
6218 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6219 when breaking from the loop.
6220
6221 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6222
6223 * callint.c (Fcall_interactively): When displaying error message
6224 about invalid control letter, pass the character's codepoint, not
6225 a pointer to its multibyte form. Improve display of the character
6226 in octal and display also its hex code.
6227
6228 * character.c (char_string): Use %x to display the (unsigned)
6229 codepoint of an invalid character, to avoid displaying a bogus
6230 negative value.
6231
6232 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6233 `error', not SYMBOL_NAME itself.
6234
6235 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6236 character arguments to `error'.
6237
6238 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6239 to `error' in error message about FINAL_CHAR argument. Make sure
6240 FINAL_CHAR is a character, and use %c when it is passed as
6241 argument to `error'.
6242
4ffd0d6b 62432011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6244
6245 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6246
6247 * w32.c: Include <time.h>.
6248 (sys_localtime): New function.
6249
4ffd0d6b 62502011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6251
6252 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6253
4ffd0d6b 6254 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6255
4ffd0d6b 62562011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6257
4ffd0d6b
GM
6258 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6259 zombies (Bug#8467).
aac0c6e3 6260
04c56954
EZ
62612011-04-19 Eli Zaretskii <eliz@gnu.org>
6262
6263 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6264 gl_state.e_property when gl_state.object is Qt.
6265
6266 * insdel.c (make_gap_larger): Remove limitation of buffer size
6267 to <= INT_MAX.
6268
16a43933
CY
62692011-04-18 Chong Yidong <cyd@stupidchicken.com>
6270
6271 * xdisp.c (lookup_glyphless_char_display)
6272 (produce_glyphless_glyph): Handle cons cell entry in
6273 glyphless-char-display.
6274 (Vglyphless_char_display): Document it.
6275
6276 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6277 glyphless-char-display.
6278
4581706e
CY
62792011-04-17 Chong Yidong <cyd@stupidchicken.com>
6280
6281 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6282
6283 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6284
6285 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6286 definition for no-X builds.
6287
4887c6e2 62882011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6289
fd35b6f9
PE
6290 Static checks with GCC 4.6.0 and non-default toolkits.
6291
5c1ccb01
PE
6292 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6293
006c5daa
PE
6294 * process.c (keyboard_bit_set): Define only if SIGIO.
6295 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6296 (send_process): Repair possible setjmp clobbering.
6297
efc736d3
PE
6298 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6299
4e2fe2e6
PE
6300 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6301
f97334a2
PE
6302 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6303
4e75f29d
PE
6304 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6305 Define only if needed.
6306
90efadd1
PE
6307 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6308 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6309 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6310
3c647824
PE
6311 * dispextern.h (struct redisplay_interface): Rename param
6312 to avoid shadowing.
e264f262 6313 * termhooks.h (struct terminal): Likewise.
761383f4 6314 * xterm.c (xembed_send_message): Likewise.
3c647824 6315
b58c5c4a
PE
6316 * insdel.c (make_gap_smaller): Define only if
6317 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6318
cad59032
PE
6319 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6320 it.
6321
c339dc2e
PE
6322 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6323 so that we aren't warned about unused symbols.
6324
91a3e27b
PE
6325 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6326
399c71d3 6327 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6328
8ffc96f5
PE
6329 * xfns.c (x_real_positions): Mark locals as initialized.
6330
eef9bc79
PE
6331 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6332
098db9dd
PE
6333 * xterm.c: Fix problems found by static analysis with other toolkits.
6334 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6335 (x_dispatch_event): Declare static if USE_GTK, and
6336 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6337 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6338 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6339 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6340 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6341
eb18f6cc
PE
6342 * xmenu.c (menu_help_callback): Pointer type fixes.
6343 Use const pointers when pointing at readonly data. Avoid pointer
6344 signedness clashes.
6345 (FALSE): Remove unused macro.
6346 (update_frame_menubar): Remove unused decl.
6347
1fe72bf8
PE
6348 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6349
60d9e1db
PE
6350 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6351 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6352 (single_menu_item): Rename local to avoid shadowing.
6353
39261c26
PE
6354 * keyboard.c (make_lispy_event): Remove unused local var.
6355
018c5e19
PE
6356 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6357 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6358
63d2b86e
PE
6359 * bitmaps: Change bitmaps from unsigned char back to the X11
6360 compatible char. Avoid the old compiler warnings about
6361 out-of-range initializers by using, for example, '\xab' rather
6362 than 0xab.
6363
aefd87e1
PE
6364 * xgselect.c (xgselect_initialize): Check vs interface
6365 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6366
bf501fb9
PE
6367 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6368
e9829fdf
PE
6369 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6370 to read-only memory.
6371
1086c095
PE
6372 * fns.c (vector): Remove; this old hack is no longer needed.
6373
2baccd04 6374 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6375 Remove unused var.
dde42981 6376 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6377
72391843 6378 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6379
436c16df 6380 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6381 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6382 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6383
92bb796d 6384 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6385 (x_term_init): Remove local to avoid shadowing.
92bb796d 6386
764430a3 6387 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6388
6389 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6390 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6391
d1dfb56c
EZ
63922011-04-16 Eli Zaretskii <eliz@gnu.org>
6393
c4354cb4
EZ
6394 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6395
d1dfb56c
EZ
6396 Fix regex.c, syntax.c and friends for buffers > 2GB.
6397 * syntax.h (struct gl_state_s): Declare character position members
6398 EMACS_INT.
6399
6400 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6401
04f2d78b
CB
6402 * textprop.c (verify_interval_modification, interval_of):
6403 Declare arguments EMACS_INT.
d1dfb56c
EZ
6404
6405 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6406 EMACS_INT.
6407
6408 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6409
6410 * indent.c (Fvertical_motion): Local variable it_start is now
6411 EMACS_INT.
6412
6413 * regex.c (re_match, re_match_2, re_match_2_internal)
6414 (bcmp_translate, regcomp, regexec, print_double_string)
6415 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6416 (re_compile_pattern, re_exec): Declare arguments and local
6417 variables `size_t' and `ssize_t' and return values `regoff_t', as
6418 appropriate.
6419 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6420 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6421 <compile_stack_type>: `size' and `avail' are now `size_t'.
6422
6423 * regex.h <regoff_t>: Use ssize_t, not int.
6424 (re_search, re_search_2, re_match, re_match_2): Arguments that
6425 specify buffer/string position and length are now ssize_t and
6426 size_t. Return type is regoff_t.
6427
613052cd
BK
64282011-04-16 Ben Key <bkey76@gmail.com>
6429
6430 * nsfont.m: Fixed bugs in ns_get_family and
6431 ns_descriptor_to_entity that were caused by using free to
6432 deallocate memory blocks that were allocated by xmalloc (via
6433 xstrdup). This caused Emacs to crash when compiled with
6434 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6435 --enable-checking=xmallocoverrun). xfree is now used to
6436 deallocate these memory blocks.
6437
4170f62f 64382011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6439
71b41406
PE
6440 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6441
9587a89d
PE
6442 emacs_write: Accept and return EMACS_INT for sizes.
6443 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6444 et seq.
6445 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6446 Accept and return EMACS_INT.
6447 (emacs_gnutls_write): Return the number of bytes written on
6448 partial writes.
6449 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6450 (emacs_read, emacs_write): Remove check for negative size, as the
6451 Emacs source code has been audited now.
9587a89d
PE
6452 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6453 (emacs_read, emacs_write): Use it.
273a5f82
PE
6454 * process.c (send_process): Adjust to the new signatures of
6455 emacs_write and emacs_gnutls_write. Do not attempt to store
6456 a byte offset into an 'int'; it might overflow.
9587a89d 6457 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6458
3e047f51
PE
6459 * sound.c: Don't assume sizes fit in 'int'.
6460 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6461 Return EMACS_INT, not int.
3e047f51 6462 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6463 Accept EMACS_INT, not int.
6464 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6465 record read return values.
6466
cc39a9db
BK
64672011-04-15 Ben Key <bkey76@gmail.com>
6468
c9d0ec6d
JB
6469 * keyboard.c (Qundefined): Don't declare static since it is used
6470 in nsfns.m.
6471 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6472 static since they are used in nsfont.m.
cc39a9db 6473
6c60eb9f
SM
64742011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6475
6476 * process.c (Qprocessp): Don't declare static.
6477 * lisp.h (Qprocessp): Declare again.
6478
7990b61a
JB
64792011-04-15 Juanma Barranquero <lekktu@gmail.com>
6480
6481 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6482
5d4cb038
PE
64832011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6484
8bd7b830 6485 Improve C-level modularity by making more things 'static'.
cd64ea1d 6486
e3b27b31
PE
6487 Don't publish debugger-only interfaces to other modules.
6488 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6489 (verify_bytepos, count_markers): Move decls to the only modules
6490 that need them.
6491 * region-cache.h (pp_cache): Likewise.
6492 * window.h (check_all_windows): Likewise.
6493 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6494
5d4cb038
PE
6495 * sysdep.c (croak): Now static, if
6496 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6497 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6498
6499 * alloc.c (refill_memory_reserve): Now static if
6500 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6501 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6502
e87b6180
PE
6503 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6504 Define only if USE_LUCID.
6505
ac64929e
PE
6506 * xrdb.c (x_customization_string, x_rm_string): Now static.
6507
6f37259d
PE
6508 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6509 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6510
1683e3ab
PE
6511 * xdisp.c (draw_row_with_mouse_face): Now static.
6512 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6513
de9c2632
PE
6514 * window.h (check_all_windows): Mark externally visible.
6515
2b96acb7
PE
6516 * window.c (window_deletion_count): Now static.
6517
6518 * undo.c: Make symbols static if they're not exported.
6519 (last_undo_buffer, last_boundary_position, pending_boundary):
6520 Now static.
6521
50436f33
PE
6522 * textprop.c (interval_insert_behind_hooks): Now static.
6523 (interval_insert_in_front_hooks): Likewise.
6524
64520e5c
PE
6525 * term.c: Make symbols static if they're not exported.
6526 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6527 (max_frame_lines, tty_set_terminal_modes):
6528 (tty_reset_terminal_modes, tty_turn_off_highlight):
6529 (get_tty_terminal): Now static.
6530 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6531 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6532 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6533 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6534 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6535
1fa53021
PE
6536 * sysdep.c: Make symbols static if they're not exported.
6537 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6538 Now static.
6539 (sigprocmask_set, full_mask): Remove; unused.
6540 (wait_debugging): Mark as visible.
6541 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6542 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6543
d4b43b22
PE
6544 * syntax.c (syntax_temp): Define only if !__GNUC__.
6545
b7c513d0
PE
6546 * sound.c (current_sound_device, current_sound): Now static.
6547
989b29ad
PE
6548 * search.c (searchbufs, searchbuf_head): Now static.
6549
13a55a78
PE
6550 * scroll.c (scroll_cost): Remove; unused.
6551 * dispextern.h (scroll_cost): Remove decl.
6552
de68a1fc
PE
6553 * region-cache.h (pp_cache): Mark as externally visible.
6554
40ccffa6
PE
6555 * process.c: Make symbols static if they're not exported.
6556 (process_tick, update_tick, create_process, chan_process):
6557 (Vprocess_alist, proc_buffered_char, datagram_access):
6558 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6559 (deactivate_process): Mark defn as static, as well as decl.
6560 * lisp.h (create_process): Remove decl.
6561 * process.h (chan_process, Vprocess_alist): Remove decls.
6562
ad64fc97
PE
6563 * print.c: Make symbols static if they're not exported.
6564 (print_depth, new_backquote_output, being_printed, print_buffer):
6565 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6566 (print_interval, print_number_index, initial_stderr_stream):
6567 Now static.
6568 * lisp.h (Fprinc): Remove decl.
6569 (debug_output_compilation_hack): Mark as externally visible.
6570
adddb265
PE
6571 * sysdep.c (croak): Move decl from here to syssignal.h.
6572 * syssignal.h (croak): Put it here, so the API can be checked when
6573 'croak' is called from dissociate_if_controlling_tty.
6574
1717ede2
PE
6575 * minibuf.c: Make symbols static if they're not exported.
6576 (minibuf_save_list, choose_minibuf_frame): Now static.
6577 * lisp.h (choose_minibuf_frame): Remove decl.
6578
fa5fb2bc
PE
6579 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6580
1e3890d1
PE
6581 * lread.c: Make symbols static if they're not exported.
6582 (read_objects, initial_obarray, oblookup_last_bucket_number):
6583 Now static.
6584 (make_symbol): Remove; unused.
6585 * lisp.h (initial_obarray, make_symbol): Remove decls.
6586
8a1414fa
PE
6587 * keyboard.c: Make symbols static if they're not exported.
6588 (single_kboard, recent_keys_index, total_keys, recent_keys):
6589 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6590 (this_single_command_key_start, echoing, last_auto_save):
6591 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6592 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6593 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6594 (Vlispy_mouse_stem, double_click_count):
6595 Now static.
6596 (force_auto_save_soon): Define only if SIGDANGER.
6597 (ignore_mouse_drag_p): Now static if
6598 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6599 (print_help): Remove; unused.
6600 (stop_character, last_timer_event): Mark as externally visible.
6601 * keyboard.h (ignore_mouse_drag_p): Declare only if
6602 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6603 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6604 * lisp.h (echoing): Remove decl.
6605 (force_auto_save_soon): Declare only if SIGDANGER.
6606 * xdisp.c (redisplay_window): Simplify code, to make it more
6607 obvious that ignore_mouse_drag_p is not accessed if !defined
6608 USE_GTK && !defined HAVE_NS.
6609
93ea6e8f
PE
6610 * intervals.c: Make symbols static if they're not exported.
6611 (merge_properties_sticky, merge_interval_right, delete_interval):
6612 Now static.
6613 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6614
77382fcc
PE
6615 * insdel.c: Make symbols static if they're not exported.
6616 However, leave prepare_to_modify_buffer alone. It's never
6617 called from outside this function, but that appears to be a bug.
6618 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6619 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6620 (adjust_after_replace_noundo): Remove; unused.
6621 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6622 (signal_before_change): Remove decls.
77382fcc 6623
9306c32e
PE
6624 * indent.c (val_compute_motion, val_vmotion): Now static.
6625
cd44d2eb
PE
6626 * image.c: Make symbols static if they're not exported.
6627 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6628 if USE_GTK.
6629 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6630 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6631
ad9a7a06
PE
6632 * fringe.c (standard_bitmaps): Now static.
6633 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6634
81626931
PE
6635 * frame.c: Make symbols static if they're not exported.
6636 (x_report_frame_params, make_terminal_frame): Now static.
6637 (get_frame_param): Now static, unless HAVE_NS.
6638 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6639 (x_get_resource_string): Remove; not used.
6640 * frame.h (make_terminal_frame, x_report_frame_params):
6641 (x_get_resource_string); Remove decls.
6642 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6643 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6644
239f9db9
PE
6645 * font.c, fontset.c: Make symbols static if they're not exported.
6646 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6647 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6648 * font.c (font_close_object): Now static.
6649 * font.h (font_close_object): Remove.
6650 * fontset.c (FONTSET_OBJLIST): Remove.
6651 (free_realized_fontset) #if-0 the body, which does nothing.
6652 (face_suitable_for_char_p): #if-0, as it's never called.
6653 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6654 * xfaces.c (face_at_string_position):
6655 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6656 since 0 is always ASCII.
6657
dfcf3579
PE
6658 * fns.c (weak_hash_tables): Now static.
6659
5045092b
PE
6660 * fileio.c: Make symbols static if they're not exported.
6661 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6662 (Vwrite_region_annotation_buffers): Now static.
6663
57a96f5c
PE
6664 * eval.c: Make symbols static if they're not exported.
6665 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6666 * lisp.h (backtrace_list): Remove decl.
6667
35f08c38
PE
6668 * emacs.c: Make symbols static if they're not exported.
6669 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6670 (fatal_error_code, fatal_error_signal_hook, standard_args):
6671 Now static.
6672 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6673 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6674 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6675 * lisp.h (fatal_error_signal_hook): Remove decl.
6676 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6677
f44bd759
PE
6678 * editfns.c: Move a (normally-unused) function to its only use.
6679 * editfns.c, lisp.h (get_operating_system_release): Remove.
6680 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6681 worth the hassle of breaking this out.
6682
b532497d
PE
6683 * xterm.c: Make symbols static if they're not exported.
6684 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6685 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6686 (x_destroy_window, x_delete_display):
6687 Now static.
6688 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6689 (x_mouse_leave): Remove; unused.
6690 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6691 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6692 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6693 Remove decls.
6694 (x_mouse_leave): Declare only if WINDOWSNT.
6695 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6696 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6697 USE_X_TOOLKIT.
6698
1675728f
PE
6699 * ftxfont.c: Make symbols static if they're not exported.
6700 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6701 HAVE_FREETYPE.
6702 * font.h (ftxfont_driver): Likewise.
6703
e4cebfca
PE
6704 * xfns.c: Make symbols static if they're not exported.
6705 (x_last_font_name, x_display_info_for_name):
6706 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6707 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6708 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6709 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6710 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6711 (last_show_tip_args): Now static.
6712 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6713 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6714 (x_screen_planes): Remove; unused.
6715 * dispextern.h (x_screen_planes): Remove decl.
6716
5bf46f05
PE
6717 * dispnew.c: Make symbols static if they're not exported.
6718 * dispextern.h (redraw_garbaged_frames, scrolling):
6719 (increment_row_positions): Remove.
6720 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6721 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6722 Now static.
6723 (redraw_garbaged_frames): Remove; unused.
6724
435f4c28
PE
6725 * xfaces.c: Make symbols static if they're not exported.
6726 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6727 Remove decls.
6728 * xterm.h (defined_color): Remove decls.
6729 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6730 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6731 (menu_face_changed_default, defined_color, free_realized_face):
6732 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6733 (ascii_face_of_lisp_face): Remove; unused.
6734
8524aef3
PE
6735 * xdisp.c: Make symbols static if they're not exported.
6736 * dispextern.h (scratch_glyph_row, window_box_edges):
6737 (glyph_to_pixel_coords, set_cursor_from_row):
6738 (get_next_display_element, set_iterator_to_next):
6739 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6740 (show_mouse_face): Remove decls
6741 * frame.h (message_buf_print): Likewise.
6742 * lisp.h (pop_message, set_message, check_point_in_composition):
6743 Likewise.
6744 * xterm.h (set_vertical_scroll_bar): Likewise.
6745 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6746 (message_buf_print, scratch_glyph_row, displayed_buffer):
6747 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6748 (get_next_display_element, show_mouse_face, window_box_edges):
6749 (frame_to_window_pixel_xy, check_point_in_composition):
6750 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6751 (glyph_to_pixel_coords): Remove; unused.
6752
16390cd2
PE
6753 * dired.c (file_name_completion): Now static.
6754
6755 * dbusbind.c (xd_in_read_queued_messages): Now static.
6756
a25f4dfa
PE
6757 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6758 * data.c (circular_list_error): Remove.
6759
14a9c8df
PE
6760 * commands.h (last_point_position, last_point_position_buffer):
6761 (last_point_position_window): Remove decls.
6762 * keyboard.c: Make these variables static.
6763
04f2d78b
CB
6764 * coding.h (coding, code_convert_region, encode_coding_gap):
6765 Remove decls.
74ab6df5
PE
6766 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6767 (iso_code_class, detect_coding, code_convert_region): Now static.
6768 (encode_coding_gap): Remove; unused.
6769
38dfbee1
PE
6770 * chartab.c (chartab_chars, chartab_bits): Now static.
6771
a2cb4e63
PE
6772 * charset.h (charset_iso_8859_1): Remove decl.
6773 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6774 Now static.
6775
127198fd
PE
6776 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6777 * ccl.c (Vccl_program_table): Now static.
6778 (check_ccl_update): Remove; unused.
6779
d85b608f
PE
6780 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6781 * category.h: ... from here.
6782 * category.c (check_category_table, set_category_set): Now static.
6783
31cd66f3
PE
6784 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6785 * lisp.h: Remove these decls.
6786
c358e587
PE
6787 * buffer.c (buffer_count): Remove unused var.
6788
e78aecca
PE
6789 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6790 so that it's not optimized away.
6791 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6792 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6793 exported only to the debugger.
6794
e192d7d3 6795 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6796 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6797
92470028
PE
6798 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6799 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6800 was inaccessible from Lisp.
6801 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6802 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6803
244ed907
PE
6804 alloc.c: Import and export fewer symbols, and remove unused items.
6805 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6806 is defined.
6807 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6808 it's not optimized away by whole-program optimization.
6809 (message_enable_multibyte, free_misc): Remove.
6810 (catchlist, handlerlist, mark_backtrace):
6811 Declare only if BYTE_MARK_STACK.
6812 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6813 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6814 (message_enable_multibyte): Remove decl.
6815 (free_misc, interval_free_list, float_block, float_block_index):
6816 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6817 (cons_free_list, last_marked_index):
6818 Now static.
6819 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6820 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6821 (mark_backtrace): Define only if BYTE_MARK_STACK.
6822 * xdisp.c (message_enable_multibyte): Now static.
6823
61c2b50e 6824 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6825 This makes it easier for human readers (and static analyzers)
6826 to see whether these variables are used from other modules.
6827 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6828 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6829 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6830 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6831 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6832 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6833 * xmenu.c, xselect.c:
6834 Declare Q* vars static if they are not used in other modules.
6835 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6836 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6837 Remove decls of unexported vars.
6838 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6839
95c82688
PE
6840 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6841
16a97296
PE
6842 Make Emacs functions such as Fatom 'static' by default.
6843 This makes it easier for human readers (and static analyzers)
6844 to see whether these functions can be called from other modules.
6845 DEFUN now defines a static function. To make the function external
6846 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6847 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6848 (Finit_image_library):
16a97296
PE
6849 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6850 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6851 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6852 Remove decls, since these functions are now static.
6853 (Funintern, Fget_internal_run_time): New decls, since these functions
6854 were already external.
95c82688 6855
16a97296
PE
6856 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6857 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6858 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6859 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6860 * keyboard.c, keymap.c, lread.c:
6861 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6862 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6863 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6864 Mark functions with DEFUE instead of DEFUN,
6865 if they are used in other modules.
6866 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6867 decls for now-static functions.
6868 * buffer.h (Fdelete_overlay): Remove decl.
6869 * callproc.c (Fgetenv_internal): Mark as internal.
6870 * composite.c (Fremove_list_of_text_properties): Remove decl.
6871 (Fcomposition_get_gstring): New forward static decl.
6872 * composite.h (Fcomposite_get_gstring): Remove decl.
6873 * dired.c (Ffile_attributes): New forward static decl.
6874 * doc.c (Fdocumntation_property): New forward static decl.
6875 * eval.c (Ffetch_bytecode): New forward static decl.
6876 (Funintern): Remove extern decl; now in .h file where it belongs.
6877 * fileio.c (Fmake_symbolic_link): New forward static decl.
6878 * image.c (Finit_image_library): New forward static decl.
6879 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6880 * intervals.h (Fprevious_property_change):
6881 (Fremove_list_of_text_properties): Remove decls.
6882 * keyboard.c (Fthis_command_keys): Remove decl.
6883 (Fcommand_execute): New forward static decl.
6884 * keymap.c (Flookup_key): New forward static decl.
6885 (Fcopy_keymap): Now static.
6886 * keymap.h (Flookup_key): Remove decl.
6887 * process.c (Fget_process): New forward static decl.
6888 (Fprocess_datagram_address): Mark as internal.
6889 * syntax.c (Fsyntax_table_p): New forward static decl.
6890 (skip_chars): Remove duplicate decl.
6891 * textprop.c (Fprevious_property_change): New forward static decl.
6892 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6893 Now internal.
6894 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6895 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6896
785bbd42
PE
6897 * editfns.c (Fformat): Remove unreachable code.
6898
8b913b57
AS
68992011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6900
6901 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6902 change. (Bug#8496)
6903
a6744a35
EZ
69042011-04-13 Eli Zaretskii <eliz@gnu.org>
6905
6906 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6907 when at ZV. (Bug#8487)
6908
e7974947
AS
69092011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6910
baad03f0
AS
6911 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6912 (Bug#8437)
6913 * keyboard.c (parse_tool_bar_item): Likewise.
6914 * sound.c (sound_cleanup, alsa_close): Likewise.
6915 * termcap.c (tgetent): Likewise.
6916 * xfns.c (x_default_font_parameter): Likewise.
6917 * xsettings.c (read_and_apply_settings): Likewise.
6918
e7974947
AS
6919 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6920 (overrun_check_free): Protoize.
6921
28272684
PE
69222011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6923
6924 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6925 since callers should never pass a negative size.
6926 Change the signature to match that of plain 'read' and 'write'; see
6927 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6928 * lisp.h: Update prototypes of emacs_write and emacs_read.
6929
11997c76
EZ
69302011-04-11 Eli Zaretskii <eliz@gnu.org>
6931
6932 * xdisp.c (redisplay_window): Don't try to determine the character
6933 position of the scroll margin if the window start point w->startp
e896f03c 6934 is outside the buffer's accessible region. (Bug#8468)
11997c76 6935
8a2cbd72
EZ
69362011-04-10 Eli Zaretskii <eliz@gnu.org>
6937
6938 Fix write-region and its subroutines for buffers > 2GB.
6939 * fileio.c (a_write, e_write): Modify declaration of arguments and
6940 local variables to support buffers larger than 2GB.
6941 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6942
6943 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6944 argument, local variables, and return value.
6945
6946 * lisp.h: Update prototypes of emacs_write and emacs_read.
6947
6948 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6949
4073e537 69502011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6951
1ebfdcb6
PE
6952 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6953
b2ded58d
PE
6954 Fix more problems found by GCC 4.6.0's static checks.
6955
7d66342c
PE
6956 * xdisp.c (vmessage): Use a better test for character truncation.
6957
bbf47d44
PE
6958 * charset.c (load_charset_map): <, not <=, for optimization,
6959 and to avoid potential problems with integer overflow.
9248994d 6960 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6961 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6962 * editfns.c (Fformat): Likewise.
1e69125e 6963 * syntax.c (skip_chars): Likewise.
3befa583 6964
e3019616
PE
6965 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6966 This also lets GCC 4.6.0 generate slightly better loop code.
6967
becfa255
PE
6968 * callint.c (Fcall_interactively): <, not <=, for optimization.
6969 (Fcall_interactively): Count the number of arguments produced,
6970 not the number of arguments given. This is simpler and lets GCC
6971 4.6.0 generate slightly better code.
6972
dae0cd48
PE
6973 * ftfont.c: Distingish more carefully between FcChar8 and char.
6974 The previous code passed unsigned char * to a functions like
6975 strlen and xstrcasecmp that expect char *, which does not
6976 conform to the C standard.
6977 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6978 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6979 char * when the C standard requires it.
6980
76032d70
PE
6981 * keyboard.c (read_char): Remove unused var.
6982
eb3f1cc8
PE
6983 * eval.c: Port to Windows vsnprintf (Bug#8435).
6984 Include <limits.h>.
6985 (SIZE_MAX): Define if the headers do not.
6986 (verror): Do not give up if vsnprintf returns a negative count.
6987 Instead, grow the buffer. This ports to Windows vsnprintf, which
6988 does not conform to C99. Problem reported by Eli Zaretskii.
6989 Also, simplify the allocation scheme, by avoiding the need for
6990 calling realloc, and removing the ALLOCATED variable.
6991
70476b54
PE
6992 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6993
12020a9e
PE
6994 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6995 But keep the doprint source code for now, as we might revamp it
6996 and use it again (Bug#8435).
ea6c7ae6
PE
6997 * lisp.h (doprnt): Remove.
6998 * Makefile.in (base_obj): Remove doprnt.o.
6999 * deps.mk (doprnt.o): Remove.
7000
5fdb398c
PE
7001 error: Print 32- and 64-bit integers portably (Bug#8435).
7002 Without this change, on typical 64-bit hosts error ("...%d...", N)
7003 was used to print both 32- and 64-bit integers N, which relied on
7004 undefined behavior.
7005 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7006 New macro.
7007 * lisp.h (error, verror): Mark as printf-like functions.
7008 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7009 Report overflow in size calculations when allocating printf buffer.
7010 Do not truncate output string at its first null byte.
7011 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7012 Truncate the output at a character boundary, since vsnprintf does not
7013 do that.
7014 * charset.c (check_iso_charset_parameter): Convert internal
7015 character to string before calling 'error', since %c now has the
7016 printf meaning.
7017 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7018 overflow when computing char to be passed to 'error'. Do not
7019 pass Lisp_Object to 'error'; pass the integer instead.
7020 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7021 formatted with plain %d.
7022
b189fa66
PE
7023 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7024
bff87ef0
PE
7025 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7026
7e2cac20
PE
7027 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7028
ce4d90b5
PE
7029 * xterm.c (x_catch_errors): Remove duplicate declaration.
7030
266c9547
PE
7031 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7032
79c49ad2
PE
7033 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7034
368f4090
JM
70352011-04-10 Jim Meyering <meyering@redhat.com>
7036
7037 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7038 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7039 return ssize_t not "int", and use size_t as the buffer length.
7040 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7041 * gnutls.h: Update declarations.
7042 * process.c (read_process_output): Use ssize_t, to match.
7043 (send_process): Likewise.
7044
a32d4040
CY
70452011-04-09 Chong Yidong <cyd@stupidchicken.com>
7046
7047 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7048
8546720e 70492011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7050
04f2d78b
CB
7051 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7052 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7053
8546720e
GM
7054 * xterm.c (handle_one_xevent):
7055 * xmenu.c (create_and_show_popup_menu):
7056 * xselect.c (x_decline_selection_request)
7057 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7058
0a2f5c1a 70592011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7060
7061 Fix some uses of `int' instead of EMACS_INT.
7062 * search.c (string_match_1, fast_string_match)
7063 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7064 (scan_buffer, find_next_newline_no_quit)
7065 (find_before_next_newline, search_command, Freplace_match)
7066 (Fmatch_data): Make some `int' variables be EMACS_INT.
7067
7068 * xdisp.c (display_count_lines): 3rd argument and return value now
7069 EMACS_INT. All callers changed.
7070 (pint2hrstr): Last argument is now EMACS_INT.
7071
7072 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7073 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7074 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7075 (decode_coding_utf_16, decode_coding_emacs_mule)
7076 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7077 (decode_coding_ccl, decode_coding_charset)
7078 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7079 (decode_coding_iso_2022, decode_coding_emacs_mule)
7080 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7081 <char_offset, last_offset>: Declare EMACS_INT.
7082 (encode_coding_utf_8, encode_coding_utf_16)
7083 (encode_coding_emacs_mule, encode_invocation_designation)
7084 (encode_designation_at_bol, encode_coding_iso_2022)
7085 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7086 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7087 Declare EMACS_INT.
7088 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7089 (encode_invocation_designation): Last argument P_NCHARS is now
7090 EMACS_INT.
7091 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7092 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7093
7094 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7095 All users changed.
7096
7097 * ccl.c (Fccl_execute_on_string): Declare some variables
7098 EMACS_INT.
7099
8546720e 71002011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7101
7102 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7103
4e19a977
CS
71042011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7105
7106 * process.c (Fformat_network_address): Doc fix.
7107
87302331
R
71082011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7109
7110 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7111
cbb59342
CY
71122011-04-08 Chong Yidong <cyd@stupidchicken.com>
7113
7114 * keyboard.c (read_char): Call Lisp function help-form-show,
7115 instead of using internal_with_output_to_temp_buffer.
7116 (Qhelp_form_show): New var.
e0d38eeb 7117 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7118
7119 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7120
7121 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7122
e67a13ab
CY
71232011-04-06 Chong Yidong <cyd@stupidchicken.com>
7124
04f2d78b
CB
7125 * process.c (Flist_processes): Remove to Lisp.
7126 (list_processes_1): Delete.
e67a13ab 7127
973f782d
EZ
71282011-04-06 Eli Zaretskii <eliz@gnu.org>
7129
7c106b1e
EZ
7130 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7131
973f782d
EZ
7132 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7133
41cf7d1a 71342011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7135
ca23cc88
PE
7136 Fix more problems found by GCC 4.6.0's static checks.
7137
f390e2d5
PE
7138 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7139
42eea0d0
PE
7140 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7141
b69769da 7142 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7143
f9541e84
PE
7144 * xdisp.c (vmessage): Mark as a printf-like function.
7145
13841b55
PE
7146 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7147
c136c10f
PE
7148 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7149
5e2d4a30
PE
7150 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7151 printf-like functions.
7152 (tiff_load): Add casts to remove these marks before passing them
7153 to system-supplied API.
7154
583f48b9
PE
7155 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7156
b25d760e
PE
7157 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7158 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7159 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7160 directly, rather than having caller test rule sign. This avoids
7161 some unnecessary tests.
7162 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7163 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7164 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7165
bc7b6697 7166 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7167 (xfont_open): Avoid unnecessary tests.
bc7b6697 7168
27ccc379
PE
7169 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7170
dcd5c89a
PE
7171 * composite.h, composite.c (composition_gstring_put_cache):
7172 Use EMACS_INT, not int, for length.
7173
b13a45c6
PE
7174 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7175 breaking out part of COMPOSITION_DECODE_RULE.
7176 (COMPOSITION_DECODE_RULE): Use it.
7177 * composite.c (get_composition_id): Remove unused local vars,
7178 by using the new macro.
7179
1e792e4d
PE
7180 * textprop.c (set_text_properties_1): Change while to do-while,
7181 since the condition is always true at first.
7182
dc6c6455 7183 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7184 (interval_deletion_adjustment): Return unsigned value.
7185 All uses changed.
dc6c6455 7186
aba7731a
PE
7187 * process.c (list_processes_1, create_pty, read_process_output):
7188 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7189 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7190 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7191 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7192 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7193
fdfc4bf3
PE
7194 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7195
fca8fe46 7196 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7197 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7198
06a0259a 7199 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7200 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7201 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7202
e7b9e80f
PE
7203 * print.c (print_error_message): Avoid int overflow.
7204
56201685
PE
7205 * font.c (font_list_entities): Redo for clarity,
7206 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7207
78834453 7208 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7209 (font_score): Avoid potential overflow in diff calculation.
78834453 7210
0bc0b309 7211 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7212 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7213
e610eaca
PE
7214 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7215
b895abce
PE
7216 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7217 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7218 can always succeed if overflow has undefined behavior.
7219
1f1d9321 7220 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7221 (wordify): Omit three unnecessary tests.
1f1d9321 7222
c59478bc
PE
7223 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7224 All callers changed. This avoids the need for an unused var.
7225
79b73827
PE
7226 * casefiddle.c (casify_region): Remove var that is set but not used.
7227
a4db5dfe
PE
7228 * dired.c (file_name_completion): Remove var that is set but not used.
7229
43aae36e
PE
7230 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7231
2a47c44d 7232 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7233 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7234
a37c69bf
PE
7235 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7236 Check for integer overflow on size calculations.
7237
328ab8e7
PE
7238 * buffer.c (Fprevious_overlay_change): Remove var that is set
7239 but not used.
7240
e5a2a5cb
PE
7241 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7242 Remove vars that are set but not used.
8d84a6eb 7243 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7244 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7245
a60e5f68
PE
7246 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7247
f661cb61 7248 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7249 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7250
f0397f5a
PE
7251 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7252 that are set but not used.
7253
8664db06 7254 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7255 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7256
6abdaa4a
PE
7257 * xselect.c (x_get_local_selection, x_handle_property_notify):
7258 Remove vars that are set but not used.
7259
0ce7538d 7260 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7261 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7262
9ae848fc
PE
7263 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7264 Remove var that is set but not used.
0b918413
PE
7265 (scroll_bar_windows_size): Now size_t, not int.
7266 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7267 Check for overflow.
9ae848fc 7268
a5a62657
PE
7269 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7270 (map_tty_color) [!defined MSDOS]: Likewise.
7271
5c5cdd39
PE
7272 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7273
66ebf983
PE
7274 * coding.c: Remove vars that are set but not used.
7275 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7276 All callers changed.
7277 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7278 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7279 (decode_coding_charset): Remove vars that are set but not used.
7280
1be4d761
PE
7281 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7282 that is set but not used.
7283
47553fa8
PE
7284 * print.c (print_object): Remove var that is set but not used.
7285
1f7196bf 7286 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7287 The gnulib version avoids calling malloc in the usual case,
7288 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7289 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7290 * filelock.c (current_lock_owner): Likewise.
7291 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7292 * sysdep.c: Include allocator.h, careadlinkat.h.
7293 (emacs_no_realloc_allocator): New static constant.
7294 (emacs_readlink): New function.
fdb61804
PE
7295 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7296 ../lib/careadlinkat.h.
d1fdcab7 7297
f84c17c7
SM
72982011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7299
7300 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7301 first non-nil return value).
7302
ef3862ad
JD
73032011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7304
7305 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7306 if not defined (Bug#8403).
7307
376a7006
JB
73082011-04-02 Juanma Barranquero <lekktu@gmail.com>
7309
7310 * xdisp.c (display_count_lines): Remove parameter `start',
7311 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7312 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7313 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7314 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7315 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7316 and thereabouts. All callers changed.
7317 (get_per_char_metric): Remove parameter `f', unused since
7318 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7319
6ca3801d
JM
73202011-04-02 Jim Meyering <meyering@redhat.com>
7321
7322 do not dereference NULL upon failed strdup
7323 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7324 (ns_get_family): Likewise.
7325
d8e2b5ba
JB
73262011-04-02 Juanma Barranquero <lekktu@gmail.com>
7327
7328 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7329
8c74fcbd
JD
73302011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7331
7332 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7333 later (Bug#8403).
7334
7200d79c
SM
73352011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7336
03408648 7337 Add lexical binding.
7200d79c 7338
03408648
SM
7339 * window.c (Ftemp_output_buffer_show): New fun.
7340 (Fsave_window_excursion):
7341 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7342
7343 * lread.c (lisp_file_lexically_bound_p): New function.
7344 (Fload): Bind Qlexical_binding.
7345 (readevalloop): Remove `evalfun' arg.
7346 Bind Qinternal_interpreter_environment.
7347 (Feval_buffer): Bind Qlexical_binding.
7348 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7349 Mark as dynamic.
7350 (syms_of_lread): Declare `lexical-binding'.
7351
7352 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7353
7354 * keyboard.c (eval_dyn): New fun.
7355 (menu_item_eval_property): Use it.
ca105506
SM
7356
7357 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7358
03408648
SM
7359 * fns.c (concat, mapcar1): Accept byte-code-functions.
7360
7361 * eval.c (Fsetq): Handle lexical vars.
7362 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7363 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7364 (FletX, Flet): Obey lexical binding.
7365 (Fcommandp): Handle closures.
7366 (Feval): New `lexical' arg.
7367 (eval_sub): New function extracted from Feval. Use it almost
7368 everywhere where Feval was used. Look up vars in lexical env.
7369 Handle closures.
7370 (Ffunctionp): Move from subr.el.
7371 (Ffuncall): Handle closures.
7372 (apply_lambda): Remove `eval_flags'.
7373 (funcall_lambda): Handle closures and new byte-code-functions.
7374 (Fspecial_variable_p): New function.
7375 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7376 but without exporting it to Lisp.
23aba0ea 7377
23aba0ea 7378 * doc.c (Fdocumentation, store_function_docstring):
03408648 7379 * data.c (Finteractive_form): Handle closures.
23aba0ea 7380
03408648
SM
7381 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7382 interactive spec.
ba83908c 7383
04f2d78b
CB
7384 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7385 New byte-codes.
03408648
SM
7386 (exec_byte_code): New function extracted from Fbyte_code to handle new
7387 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7388
03408648 7389 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7390
03408648 7391 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7392
e2abce01
JB
73932011-03-31 Juanma Barranquero <lekktu@gmail.com>
7394
7395 * xdisp.c (redisplay_internal): Fix prototype.
7396
63696a73 73972011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7398
63696a73 7399 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7400 (try_scrolling): Use it when setting scroll_limit.
7401 Limit scrolling to 100 screen lines.
63696a73
EZ
7402 (redisplay_window): Even when falling back on "recentering",
7403 position point in the window according to scroll-conservatively,
7404 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7405
7406 (try_scrolling): When point is above the window, allow searching
7407 as far as scroll_max, or one screenful, to compute vertical
7408 distance from PT to the scroll margin position. This prevents
7409 try_scrolling from unnecessarily failing when
7410 scroll-conservatively is set to a value slightly larger than the
7411 window height. Clean up the case of PT below the margin at bottom
7412 of window: scroll_max can no longer be INT_MAX. When aggressive
7413 scrolling is in use, don't let point enter the opposite scroll
7414 margin as result of the scroll.
7415 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7416 threshold of 100 lines for never-recentering scrolling.
7417
e4cc2dfc
JB
74182011-03-31 Juanma Barranquero <lekktu@gmail.com>
7419
7420 * dispextern.h (move_it_by_lines):
7421 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7422 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7423 (message_log_check_duplicate): Remove parameters `prev_bol' and
7424 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7425 (redisplay_internal): Remove parameter `preserve_echo_area',
7426 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7427
7428 * indent.c (Fvertical_motion):
7429 * window.c (window_scroll_pixel_based, Frecenter):
7430 Don't pass `need_y_p' to `move_it_by_lines'.
7431
1c470562
SM
74322011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7433
44f230aa
SM
7434 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7435 steal a few bits to be more compact.
7436 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7437 Remove unneeded casts.
7438
1c470562
SM
7439 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7440
888adce9
ZK
74412011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7442
7443 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7444 binding" message (bug#7967).
7445
f838ed7b
PE
74462011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7447
77861b95
PE
7448 Fix more problems found by GCC 4.6.0's static checks.
7449
de6dbc14
PE
7450 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7451 Remove unused local var.
7452
f838ed7b
PE
7453 * editfns.c (Fmessage_box): Remove unused local var.
7454
792c7b2b
PE
7455 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7456 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7457 Omit unused local vars.
c499e557 7458 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7459 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7460 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7461 Omit unused local var.
7462
ba0165e1
PE
7463 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7464 Don't assume string length fits in int.
32ad8845 7465 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7466 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7467
3c59b4c9
PE
7468 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7469 instead of alloca (Bug#8344).
7470
a3eed478 7471 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7472 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7473
eb4d412d
PE
7474 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7475
1658b401
PE
7476 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7477 concerns.
7478
7479 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7480
7481 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7482
9a2c6e05
PE
7483 * keyboard.c (syms_of_keyboard): Use the same style as later
7484 in this function when indexing through an array. This also
7485 works around GCC bug 48267.
7486
03d0a109
PE
7487 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7488
44f730c8
PE
7489 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7490
fe75f926
PE
7491 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7492 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7493
ffa8c828
PE
7494 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7495 This avoids undefined behavior on integer overflow, and is a bit
7496 more convenient anyway since it is compared to a size_t variable.
7497
c5101a77
PE
7498 Variadic C functions now count arguments with size_t, not int.
7499 This avoids an unnecessary limitation on 64-bit machines, which
7500 caused (substring ...) to crash on large vectors (Bug#8344).
7501 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7502 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7503 All variadic functions and their callers changed accordingly.
c5101a77
PE
7504 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7505 * data.c (arith_driver, float_arith_driver): Likewise.
7506 * editfns.c (general_insert_function): Likewise.
7507 * eval.c (struct backtrace.nargs, interactive_p)
7508 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7509 (funcall_lambda, mark_backtrace): Likewise.
7510 * fns.c (concat): Likewise.
7511 * frame.c (x_set_frame_parameters): Likewise.
7512 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7513 0 if not found, not -1. All callers changed.
7514
dd3f25f7
PE
7515 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7516 (stack_copy_size): Now size_t, not int.
7517 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7518
461c2ab9
JB
75192011-03-28 Juanma Barranquero <lekktu@gmail.com>
7520
7521 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7522 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7523 All callers changed.
7524
7525 * lisp.h (multibyte_char_to_unibyte):
7526 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7527 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7528 * character.h (CHAR_TO_BYTE8):
7529 * cmds.c (internal_self_insert):
7530 * editfns.c (general_insert_function):
7531 * keymap.c (push_key_description):
7532 * search.c (Freplace_match):
7533 * xdisp.c (message_dolog, set_message_1): All callers changed.
7534
f6d62986
SM
75352011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7536
7537 * keyboard.c (safe_run_hook_funcall): New function.
7538 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7539 don't set the hook to nil, but remove the offending function instead.
7540 (Qcommand_hook_internal): Remove, unused.
7541 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7542 Vcommand_hook_internal.
7543
7544 * eval.c (enum run_hooks_condition): Remove.
7545 (funcall_nil, funcall_not): New functions.
7546 (run_hook_with_args): Call each function through a `funcall' argument.
7547 Remove `cond' argument, now redundant.
7548 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7549 (Frun_hook_with_args_until_failure): Adjust accordingly.
7550 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7551
1db5b1ad
JB
75522011-03-28 Juanma Barranquero <lekktu@gmail.com>
7553
7554 * dispextern.h (string_buffer_position): Remove declaration.
7555
7556 * print.c (strout): Remove parameter `multibyte', unused since
7557 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7558
7559 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7560 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7561 All callers changed.
7562
7563 * w32.c (_wsa_errlist): Use braces for struct initializers.
7564
7565 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7566 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7567 All callers changed.
7568 (string_buffer_position): Likewise. Also, make static (it's never
7569 used outside xdisp.c).
7570 (cursor_row_p): Remove parameter `w', unused since
7571 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7572 (decode_mode_spec): Remove parameter `precision', introduced during
7573 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7574 All callers changed.
7575
5ffb62aa
JD
75762011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7577
7578 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7579
461c2ab9 75802011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7581
7582 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7583 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7584 (ns_update_auto_hide_menu_bar): New functions.
7585 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7586 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7587 ns_constrain_all_frames.
7588 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7589 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7590
5c380ffb
JD
75912011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7592
7593 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7594
9af30bdf
GM
75952011-03-27 Glenn Morris <rgm@gnu.org>
7596
7597 * syssignal.h: Replace RETSIGTYPE with void.
7598 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7599 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7600 Replace SIGTYPE with void everywhere.
7601 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7602 * s/template.h (SIGTYPE): Remove commented out definition.
7603
e2abce01
JB
76042011-03-26 Eli Zaretskii <eliz@gnu.org>
7605
7606 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7607 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7608
f868cd8a
JB
76092011-03-26 Juanma Barranquero <lekktu@gmail.com>
7610
59eb0929
JB
7611 * w32.c (read_unc_volume): Use parameter `henum', instead of
7612 global variable `wget_enum_handle'.
7613
7614 * keymap.c (describe_vector): Remove parameters `indices' and
7615 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7616 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7617
f868cd8a
JB
7618 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7619
7620 * keyboard.c (timer_check): Remove parameter `do_it_now',
7621 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7622 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7623 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7624
7625 * keyboard.c (read_char):
7626 * w32menu.c (w32_menu_display_help):
7627 * xmenu.c (show_help_event, menu_help_callback):
7628 Adjust calls to `show_help_echo'.
7629
7630 * gtkutil.c (xg_maybe_add_timer):
7631 * keyboard.c (readable_events):
7632 * process.c (wait_reading_process_output):
7633 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7634
7635 * insdel.c (adjust_markers_gap_motion):
7636 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7637 (gap_left, gap_right): Don't call it.
7638
2ecf6fdb
CY
76392011-03-25 Chong Yidong <cyd@stupidchicken.com>
7640
7641 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7642 incurred during fontification.
7643
6b1f9ba4
JB
76442011-03-25 Juanma Barranquero <lekktu@gmail.com>
7645
7646 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7647 (DEFVAR_PER_BUFFER): Don't pass it.
7648
7649 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7650 (scrolling_window): Don't pass it.
7651
0f4a96b5
JB
76522011-03-25 Juanma Barranquero <lekktu@gmail.com>
7653
7654 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7655
7656 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7657 and `suffix'.
7658 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7659 of variables specific to SELinux and computation of `encoded_absname'.
7660
7661 * image.c (XPutPixel): Remove unused variable `height'.
7662
7663 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7664
7665 * unexw32.c (get_section_info): Remove unused variable `section'.
7666
7667 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7668 (system_process_attributes): Remove unused variable `sess'.
7669 (sys_read): Remove unused variable `err'.
7670
7671 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7672 (w32_wnd_proc): Remove unused variable `isdead'.
7673 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7674 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7675 (x_create_tip_frame): Remove unused variable `tem'.
7676
7677 * w32inevt.c (w32_console_read_socket):
7678 Remove unused variable `no_events'.
7679
7680 * w32term.c (x_draw_composite_glyph_string_foreground):
7681 Remove unused variable `width'.
7682
1149507c
JB
76832011-03-24 Juanma Barranquero <lekktu@gmail.com>
7684
7685 * w32term.c (x_set_glyph_string_clipping):
7686 Don't pass uninitialized region to CombineRgn.
7687
9c88f339
JB
76882011-03-23 Juanma Barranquero <lekktu@gmail.com>
7689
7690 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7691 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7692 (Fx_close_connection): Remove unused variable `i'.
7693
7694 * w32font.c (w32font_draw): Return number of glyphs.
7695 (w32font_open_internal): Remove unused variable `i'.
7696 (w32font_driver): Add missing initializer.
7697
7698 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7699 (fill_in_menu): Remove unused variable `items_added'.
7700
7701 * w32term.c (last_mouse_press_frame): Remove static global variable.
7702 (w32_clip_to_row): Remove unused variable `f'.
7703 (x_delete_terminal): Remove unused variable `i'.
7704
7705 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7706 (NOTHING): Remove unused static global variable.
7707 (uniscribe_check_otf): Remove unused variable `table'.
7708 (uniscribe_font_driver): Add missing initializers.
7709
dee091a3
JD
77102011-03-23 Julien Danjou <julien@danjou.info>
7711
7712 * term.c (Fsuspend_tty, Fresume_tty):
7713 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7714 * window.c (temp_output_buffer_show):
7715 * insdel.c (signal_before_change):
7716 * frame.c (Fhandle_switch_frame):
7717 * fileio.c (Fdo_auto_save):
7718 * emacs.c (Fkill_emacs):
7719 * editfns.c (save_excursion_restore):
7720 * cmds.c (internal_self_insert):
7721 * callint.c (Fcall_interactively):
7722 * buffer.c (Fkill_all_local_variables):
7723 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7724 Use Frun_hooks.
0f4a96b5 7725 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7726 unconditionnaly since it does the check itself.
7727
2c520ab5 77282011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7729
c9c49752
PE
7730 Fix more problems found by GCC 4.5.2's static checks.
7731
8abc3f12
PE
7732 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7733 the first time through the loop, since we know p0 < p1 then.
7734 This also avoids a gcc -Wstrict-overflow warning.
7735
a2d26660
PE
7736 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7737 leading to a memory leak, possible in functions like
7738 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7739 of objects (Bug#8318).
a2d26660 7740
916c72e9
PE
7741 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7742 that could (at least in theory) be that large.
7743
19ab8a18
PE
7744 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7745 This is less likely to overflow, and avoids undefined behavior if
7746 overflow does occur. All callers changed. Use strtoul to scan
7747 for the unsigned long integer.
b7cbbd6f
PE
7748 (pint2hrstr): Simplify and tune code slightly.
7749 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7750
f0641eff
PE
7751 * scroll.c (do_scrolling): Work around GCC bug 48228.
7752 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7753
7f650bb9
PE
7754 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7755 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7756 (validate_x_resource_name): Simplify count usage.
7757 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7758
37dd57d1
PE
7759 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7760 fail (Bug#8306).
81e56e61 7761
699979fc 7762 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7763
401bf9b4
PE
7764 * process.c (Fmake_network_process): Use socklen_t, not int,
7765 where POSIX says socklen_t is required in portable programs.
7766 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7767 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7768 (Fmake_network_process, server_accept_connection):
7769 (wait_reading_process_output, read_process_output):
7770 Likewise.
7771
b93aacde
PE
7772 * process.c: Rename or move locals to avoid shadowing.
7773 (list_processes_1, Fmake_network_process):
7774 (read_process_output_error_handler, exec_sentinel_error_handler):
7775 Rename or move locals.
4dc343ee 7776 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7777 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7778 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7779 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7780 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7781
af8a867c 7782 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7783 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7784 Include tparam.h instead, since it declares them.
af8a867c
PE
7785 * cm.h (PC): Remove extern decl; tparam.h now does this.
7786 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7787 * terminfo.c: Include tparam.h, to check interfaces.
7788 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7789 (tparam): Adjust signature to match interface in tparam.h;
7790 this removes some undefined behavior. Check that outstring and len
7791 are zero, which they always are with Emacs.
7792 * tparam.h (PC, BC, UP): New extern decls.
7793
0248044d 7794 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7795 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7796
8ff096c1 7797 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7798 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7799 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7800 (ftfont_list): Remove unused local.
49eaafba
PE
7801 (get_adstyle_property, ftfont_pattern_entity):
7802 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7803 Rename locals to avoid shadowing.
8ff096c1 7804
e2be39f6
PE
7805 * xfont.c (xfont_list_family): Mark var as initialized.
7806
c9735e30
PE
7807 * xml.c (make_dom): Now static.
7808
8f5201ae
PE
7809 * composite.c (composition_compute_stop_pos): Rename local to
7810 avoid shadowing.
b246f932
PE
7811 (composition_reseat_it): Remove unused locals.
7812 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7813 (composition_update_it): Mark var as initialized.
11b61122
PE
7814 (find_automatic_composition): Mark vars as initialized,
7815 with a FIXME (Bug#8290).
8f5201ae 7816
760fbc2c
PE
7817 character.h: Rename locals to avoid shadowing.
7818 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7819 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7820 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7821 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7822 to avoid shadowing.
7823
ff08eb85
PE
7824 * textprop.c (property_change_between_p): Remove; unused.
7825
fc7bf025
PE
7826 * intervals.c (interval_start_pos): Now static.
7827
235d7abc
PE
7828 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7829
44f230aa
SM
7830 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7831 Rename locals to avoid shadowing.
3e7d6594 7832
50060332
PE
7833 * sound.c (wav_play, au_play, Fplay_sound_internal):
7834 Fix pointer signedness.
d01f234b 7835 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7836 (wav_play): Initialize a variable to 0, to prevent undefined
7837 behavior (Bug#8278).
50060332 7838
c4fc4e30
PE
7839 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7840
918436ed
PE
7841 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7842
c939f91b
PE
7843 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7844 clobbering (Bug#8298).
b9c7f648
PE
7845 * sysdep.c (sys_subshell): Likewise.
7846 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7847
6bd8c144
PE
7848 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7849 This should get cleaned up, so that child_setup has the
7850 same signature on all platforms.
7851
7710357c 7852 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7853 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7854
c59da222
CY
78552011-03-22 Chong Yidong <cyd@stupidchicken.com>
7856
7857 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7858 not to be necessary, and produces flickering.
7859
66b87493
GM
78602011-03-20 Glenn Morris <rgm@gnu.org>
7861
7862 * config.in: Remove file.
7863
45b6f6d5
JB
78642011-03-20 Juanma Barranquero <lekktu@gmail.com>
7865
7866 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7867 are now in src/globals.h.
7868 (syms_of_minibuf): Remove spurious & from previous change.
7869
3ec03f7e
LL
78702011-03-20 Leo <sdl.web@gmail.com>
7871
7872 * minibuf.c (completing-read-function): New variable.
7873 (completing-read-default): Rename from completing-read.
7874 (completing-read): Call completing-read-function.
7875
b14e3e21
CY
78762011-03-19 Juanma Barranquero <lekktu@gmail.com>
7877
7878 * xfaces.c (Fx_load_color_file):
7879 Read color file from absolute filename (bug#8250).
7880
f2b726e6
JB
78812011-03-19 Juanma Barranquero <lekktu@gmail.com>
7882
7883 * makefile.w32-in: Update dependencies.
7884
09f6ff02
EZ
78852011-03-17 Eli Zaretskii <eliz@gnu.org>
7886
7887 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7888
29a6015a
PE
78892011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7890
a3a6c54e
PE
7891 Fix more problems found by GCC 4.5.2's static checks.
7892
b766f867
PE
7893 * process.c (make_serial_process_unwind, send_process_trap):
7894 (sigchld_handler): Now static.
7895
be02381c
PE
7896 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7897 That way, the code declares only the vars that it needs.
7898 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7899 * s/cygwin.h (PTY_ITERATION): Likewise.
7900 * s/darwin.h (PTY_ITERATION): Likewise.
7901 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7902
57048744
PE
7903 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7904 * process.c (allocate_pty): Don't declare stb unless it's needed.
7905
7914961c 7906 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7907 (CONSTANTLIM): Remove; unused.
7908 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7909 Define only if needed.
7914961c 7910
b3967b18
PE
7911 * unexelf.c (unexec): Name an expression,
7912 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7913 Use a different way to cause a compilation error if anyone uses
7914 n rather than nn, a way that does not involve shadowing.
73366a00 7915 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7916
29a6015a
PE
7917 * deps.mk (unexalpha.o): Remove; unused.
7918
43cfc33e 7919 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7920 * unexec.h: New file.
ce701a33
PE
7921 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7922 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7923 Depend on unexec.h.
7924 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7925 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7926 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7927 Change as necessary to match prototype in unexec.h.
ce701a33 7928
01f44d5a
PE
7929 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7930 shadowing.
4f63c6bb 7931 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7932
a6670b0b
PE
7933 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7934 Rename locals to avoid shadowing.
7935
cef2010d 7936 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7937 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7938
d4d7173a
PE
7939 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7940
f08b802a
PE
7941 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7942 warning when compiling print.c.
7943
3ddb0639
PE
7944 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7945 instead of using an uninitialized var.
5ad03b97 7946 (font_sort_entities): Mark var as initialized.
3ddb0639 7947
170a2692
PE
7948 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7949
e663c700
PE
7950 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7951 pointers to constants.
89bc529a 7952 (font_parse_fcname): Remove unused vars.
7b81e2d0 7953 (font_delete_unmatched): Now static.
ea838e10 7954 (font_get_spec): Remove; unused.
13a547c6
PE
7955 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7956 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7957 Rename or move locals to avoid shadowing.
e663c700 7958
2a80c887 7959 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7960 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7961
1384fa33 7962 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7963 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7964
8b2c52e9
PE
7965 * alloc.c (mark_backtrace): Move decl from here ...
7966 * lisp.h: ... to here, so that it can be checked.
7967
475545b5 7968 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7969 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7970 (lisp_indirect_variable): Name an expression,
7971 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7972 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7973
b1349114 7974 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7975 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7976 Use const pointer when appropriate.
b1349114 7977
a2928364
PE
7978 * lisp.h (get_system_name, get_operating_system_release):
7979 Move decls here, to check interfaces.
7980 * process.c (get_operating_system_release): Move decl to lisp.h.
7981 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7982 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7983 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7984 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7985 (Fformat_time_string, Fencode_time, Finsert_char):
7986 (Ftranslate_region_internal, Fformat):
7987 Rename or remove local vars to avoid shadowing.
9710023e 7988 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7989
a415e694
PE
7990 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7991 avoid shadowing.
7992
8ef4622d
PE
7993 * lisp.h (eassert): Check that the argument compiles, even if
7994 ENABLE_CHECKING is not defined.
7995
946f9a5b
PE
7996 * data.c (Findirect_variable): Name an expression, to avoid
7997 gcc -Wbad-function-cast warning.
112396d6 7998 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7999 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8000 (Fmake_variable_buffer_local, Fmake_local_variable):
8001 Mark variables as initialized.
52746918 8002 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8003
e5aab7e7 8004 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8005 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8006 Rename locals to avoid shadowing.
dff45157
PE
8007 (mark_stack): Move local variables into the #ifdef region where
8008 they're used.
7bc26fdb
PE
8009 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8010 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8011 needed otherwise.
8012 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8013 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8014 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8015
e5aab7e7
PE
8016 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8017 avoids undefined behavior in theory.
8018
4da60324
PE
8019 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8020
88043301
PE
8021 Use functions, not macros, for up- and down-casing (Bug#8254).
8022 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8023 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8024 to use the following functions instead of these macros.
8025 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8026 EMACS_INT, since callers assume the returned value fits in int.
8027 (upcase1): Likewise, for UPCASE_TABLE.
8028 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8029 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8030 the race-condition problem in the old DOWNCASE.
88043301 8031
19ed5445
PE
8032 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8033 Rename locals to avoid shadowing.
8034 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8035 (regex_compile, re_search_2, re_match_2_internal):
8036 Remove unused local vars.
952db0d7
PE
8037 (FREE_VAR): Rewrite so as not to use empty "else",
8038 which gcc can warn about.
da053e48 8039 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8040 (RETALLOC_IF): Define only if needed.
8041 (WORDCHAR_P): Likewise. This one is never needed, but is used
8042 only in a comment talking about a compiler bug, so put inside
8043 the #if 0 of that comment.
8044 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8045 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8046 Remove; unused.
19ed5445 8047
1f3561e4 8048 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8049 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8050 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8051
ded6f8f7
PE
8052 * search.c (simple_search): Remove unused var.
8053
dbd37a95
PE
8054 * dired.c (compile_pattern): Move decl from here ...
8055 * lisp.h: ... to here, so that it can be checked.
8056 (struct re_registers): New forward decl.
8057
7e47afad
PE
8058 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8059
85f24f61
PE
8060 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8061 All uses changed.
8062 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8063 Rename locals to avoid shadowing.
5671df8f 8064 (Fvertical_motion): Mark locals as initialized.
85f24f61 8065
181aa2be 8066 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8067 (casify_region): Mark local as initialized.
181aa2be 8068
930d429c
PE
8069 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8070
7082eac6
PE
8071 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8072 New macros, so that the caller can use some names other than
8073 gcpro1, gcpro2, etc.
8074 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8075 of the new macros.
8076 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8077 argument, for consistency with GCPRO2_VAR, etc: it is now the
8078 prefix of the variable, not the variable itself. All uses
8079 changed.
38b2c076
PE
8080 * dired.c (directory_files_internal, file_name_completion):
8081 Rename locals to avoid shadowing.
8082
15206ed9
PE
8083 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8084 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8085 dired.c's scmp function, had undefined behavior.
8086 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8087 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8088 * buffer.h: ... to here, because these macros use current_buffer,
8089 and the new implementation with inline functions needs to have
8090 current_buffer in scope now, rather than later when the macros
8091 are used.
8092 (downcase, upcase1): New static inline functions.
8093 (DOWNCASE, UPCASE1): Reimplement using these functions.
8094 This avoids undefined behavior in expressions like
8095 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8096 from race conditions in accessing the global variables
8097 case_temp1 and case_temp2.
8098 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8099 * lisp.h (case_temp1, case_temp2): Remove their decls.
8100 * character.h (ASCII_CHAR_P): Move from here ...
8101 * lisp.h: ... to here, so that the inline functions mentioned
8102 above can use them.
8103
4a6bea26
PE
8104 * dired.c (directory_files_internal_unwind): Now static.
8105
f14b7e14
PE
8106 * fileio.c (file_name_as_directory, directory_file_name):
8107 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8108 Now static.
2893f146
PE
8109 (file_name_as_directory): Use const pointers when appropriate.
8110 (Fexpand_file_name): Likewise. In particular, newdir might
8111 point at constant storage, so make it a const pointer.
fd4ead52 8112 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8113 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8114 signedness issues.
f839df0c
PE
8115 (Fset_file_times, Finsert_file_contents, auto_save_error):
8116 Rename locals to avoid shadowing.
f14b7e14 8117
5716756e 8118 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8119 (Ftry_completion, Fall_completions): Rename or remove locals
8120 to avoid shadowing.
5716756e 8121
b4c3046a
PE
8122 * marker.c (bytepos_to_charpos): Remove; unused.
8123
b45db522
PE
8124 * lisp.h (verify_bytepos, count_markers): New decls,
8125 so that gcc does not warn that these functions aren't declared.
8126
85876d07
PE
8127 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8128 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8129 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8130 (copy_text): Remove unused local var.
85876d07 8131
03d78a21 8132 * filelock.c (within_one_second): Now static.
b3dd38ab 8133 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8134
5df8f01b
PE
8135 * buffer.c (fix_overlays_before): Mark locals as initialized.
8136 (fix_start_end_in_overlays): Likewise. This function should be
8137 simplified by using pointers-to-pointers, but that's a different
8138 matter.
b1d876f1 8139 (switch_to_buffer_1): Now static.
8f54f30a
PE
8140 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8141 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8142
a70072c9 8143 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8144 Fix pointer signedness issue.
edced198
PE
8145 (sys_subshell): Mark local as volatile if checking for lint,
8146 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8147 (MAXPATHLEN): Define only if needed.
a70072c9 8148
a0977c44
PE
8149 * process.c (serial_open, serial_configure): Move decls from here ...
8150 * systty.h: ... to here, so that they can be checked.
8151
a884fdcc
PE
8152 * fns.c (get_random, seed_random): Move extern decls from here ...
8153 * lisp.h: ... to here, so that they can be checked.
8154
604efe86 8155 * sysdep.c (reset_io): Now static.
b8950c94 8156 (wait_for_termination_signal): Remove; unused.
604efe86 8157
38fc62d9
PE
8158 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8159 (copy_keymap_item, append_key, push_text_char_description):
8160 Now static.
1004a21a 8161 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8162 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8163 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8164 (describe_map_tree):
8165 Rename locals to avoid shadowing.
38fc62d9 8166
2f2650da
PE
8167 * keyboard.c: Declare functions static if they are not used elsewhere.
8168 (echo_char, echo_dash, cmd_error, top_level_2):
8169 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8170 (read_char, kbd_buffer_get_event, make_lispy_position):
8171 (make_lispy_event, make_lispy_movement, apply_modifiers):
8172 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8173 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8174 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8175 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8176 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8177
a053e86c 8178 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8179 (mark_kboards): Move decl here ...
8180 * alloc.c (mark_kboards): ... from here.
a053e86c 8181
4752793e
PE
8182 * lisp.h (force_auto_save_soon): New decl.
8183
74f10ca7 8184 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8185 (DEFINE_DUMMY_FUNCTION): New macro.
8186 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8187 Use it.
c03cd23f
PE
8188 (main): Add casts to avoid warnings
8189 if GCC considers string literals to be constants.
74f10ca7 8190
022e70d4
PE
8191 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8192
59d6fe83
PE
8193 * dbusbind.c: Pointer signedness fixes.
8194 (xd_signature, xd_append_arg, xd_initialize):
8195 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8196 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8197 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8198 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8199
78320123
PE
8200 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8201 if GCC considers string literals to be constants.
49cebcca 8202 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8203
35ac2a97
SM
82042011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8205
fb103ca9
SM
8206 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8207 (print_preprocess, print_object): New macro to fix last change.
8208
35ac2a97
SM
8209 * print.c (print_preprocess): Don't forget font objects.
8210
62973b41
JB
82112011-03-16 Juanma Barranquero <lekktu@gmail.com>
8212
8213 * emacs.c (USAGE3): Doc fixes.
8214
0e48bb22
AS
82152011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8216
8217 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8218 structure.
8219
7684e57b
JB
82202011-03-14 Juanma Barranquero <lekktu@gmail.com>
8221
8222 * lisp.h (VWindow_system, Qfile_name_history):
8223 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8224 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8225 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8226
8227 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8228 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8229
8230 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8231 * w32console.c (detect_input_pending, read_input_pending)
8232 (encode_terminal_code):
8233 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8234 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8235 (w32_system_caret_y, Qfile_name_history):
8236 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8237 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8238 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8239 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8240 * w32proc.c (Qlocal, report_file_error):
8241 * w32term.c (Vwindow_system, updating_frame):
8242 * w32uniscribe.c (initialized, uniscribe_font_driver):
8243 Remove unneeded extern declarations.
8244
2aa46d6c
CY
82452011-03-14 Chong Yidong <cyd@stupidchicken.com>
8246
c96bbc66 8247 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8248
cffc6f3b
CY
82492011-03-13 Chong Yidong <cyd@stupidchicken.com>
8250
8251 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8252 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8253 These macros can no longer be used for assignment.
8254
44f230aa
SM
8255 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8256 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8257 (record_buffer_markers, fetch_buffer_markers): New functions for
8258 recording and fetching special buffer markers.
8259 (set_buffer_internal_1, set_buffer_temp): Use them.
8260
8261 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8262
8263 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8264
8265 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8266 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8267
8268 * xdisp.c (hscroll_window_tree):
8269 (reconsider_clip_changes): Use PT instead of BUF_PT.
8270
d251f04b
EZ
82712011-03-13 Eli Zaretskii <eliz@gnu.org>
8272
8273 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8274 $(EMACS_ROOT)/lib/intprops.h.
8275
f0c77cd1
PE
82762011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8277
3eca4629
PE
8278 Fix more problems found by GCC 4.5.2's static checks.
8279
7c86ee98
PE
8280 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8281 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8282 (xg_free_frame_widgets): Make it clear that a local variable is
8283 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8284 (gdk_window_get_screen): Make it clear that this macro is needed
8285 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8286 (int_gtk_range_get_value): New function, which avoids a diagnostic
8287 from gcc -Wbad-function-cast.
8288 (xg_set_toolkit_scroll_bar_thumb): Use it.
8289 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8290 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8291 (get_utf8_string, xg_get_file_with_chooser):
8292 Rename locals to avoid shadowing.
8293 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8294
41729b81
PE
8295 * xgselect.c (xg_select): Remove unused var.
8296
f0c77cd1
PE
8297 * image.c (four_corners_best): Mark locals as initialized.
8298 (gif_load): Initialize transparent_p to zero (Bug#8238).
8299 Mark another local as initialized.
ec6cf4c6 8300 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8301
ce0ad53d 8302 * image.c (clear_image_cache): Now static.
d5d5a617 8303 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8304 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8305 (x_edge_detection): Remove unnecessary cast that
8306 gcc -Wbad-function-cast diagnoses.
2037898d 8307 (gif_load): Fix pointer signedness.
6ae141d6
PE
8308 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8309 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8310
33383987 83112011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8312
d32df629
PE
8313 Improve quality of tests for time stamp overflow.
8314 For example, without this patch (encode-time 0 0 0 1 1
8315 1152921504606846976) returns the obviously-bogus value (-948597
8316 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8317 reports time overflow. See
8318 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8319 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8320 * editfns.c: Include limits.h and intprops.h.
8321 (TIME_T_MIN, TIME_T_MAX): New macros.
8322 (time_overflow): Move earlier, to before first use.
8323 (hi_time, lo_time): New functions, for an accurate test for
8324 out-of-range times.
8325 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8326 (Fget_internal_run_time): Don't assume time_t fits in int.
8327 (make_time): Use list2 instead of Fcons twice.
8328 (Fdecode_time): More accurate test for out-of-range times.
8329 (check_tm_member): New function.
8330 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8331 (lisp_time_argument): Don't rely on undefined left-shift and
8332 right-shift behavior when checking for time stamp overflow.
8be6f318 8333
fe31d94c
PE
8334 * editfns.c (time_overflow): New function, refactoring common code.
8335 (Fformat_time_string, Fdecode_time, Fencode_time):
8336 (Fcurrent_time_string): Use it.
8337
8be6f318
PE
8338 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8339 * dired.c (make_time): Move to ...
8340 * editfns.c (make_time): ... here.
8341 * systime.h: Note the move.
8342
09d9db2c 83432011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8344
126bc0dc
YM
8345 * fringe.c (update_window_fringes): Remove unused variables.
8346
c47cbdfd
YM
8347 * unexmacosx.c (copy_data_segment): Also copy __got section.
8348 (Bug#8223)
8349
7ac80be9
EZ
83502011-03-12 Eli Zaretskii <eliz@gnu.org>
8351
c96bbc66 8352 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8353 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8354 Constify `char *' arguments and their references according to
8355 prototypes in tparam.h.
8356
ecb0f94d 8357 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8358
7ac80be9
EZ
8359 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8360 Adapt all references accordingly.
8361
8362 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8363
ef1fd07e
TT
83642011-03-11 Tom Tromey <tromey@redhat.com>
8365
8366 * buffer.c (syms_of_buffer): Remove obsolete comment.
8367
7ef4b50c
EZ
83682011-03-11 Eli Zaretskii <eliz@gnu.org>
8369
8370 * termhooks.h (encode_terminal_code): Declare prototype.
8371
8372 * msdos.c (encode_terminal_code): Don't declare prototype.
8373
8374 * term.c (encode_terminal_code): Now external again, used by
8375 w32console.c and msdos.c.
8376
44f230aa
SM
8377 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8378 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8379
4b1ec863 83802011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8381
1714f52b 8382 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8383
4b1ec863
PE
8384 * fringe.c (update_window_fringes): Mark locals as initialized
8385 (Bug#8227).
8386 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8387
524c7aa6
PE
8388 * alloc.c (mark_fringe_data): Move decl from here ...
8389 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8390 to check its interface.
8391 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8392
a5c0af81 8393 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8394 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8395 (fontset_font): Mark local as initialized.
a9a06e0b 8396 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8397
b4716021
PE
8398 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8399
811e9bac 8400 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8401 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8402 (x_own_selection, Fx_disown_selection_internal): Rename locals
8403 to avoid shadowing.
8404 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8405
7e3ab302
PE
8406 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8407 so that the caller can use some name other than gcpro1.
8408 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8409 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8410 (Fx_backspace_delete_keys_p):
8411 Use them to avoid shadowing, and rename vars to avoid shadowing.
8412 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8413 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8414 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8415 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8416 Remove unused locals.
7e3ab302
PE
8417 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8418 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8419 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8420 macros.
f78faa98 8421
e2b13473
PE
8422 * xterm.h (x_mouse_leave): New decl.
8423
77f23912
PE
8424 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8425 Remove unused functions.
cdf4ba58
PE
8426 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8427 (x_calc_absolute_position): Now static.
7411c686 8428 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8429 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8430 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8431 unless they are used.
38d0b34a
PE
8432 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8433 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8434 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8435 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8436 (x_error_catcher, x_connection_closed, x_error_handler):
8437 (x_error_quitter, xembed_send_message, x_iconify_frame):
8438 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8439 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8440 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8441
44f230aa
SM
8442 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8443 Rename or move locals to avoid shadowing.
6b463e58 8444 (tty_defined_color, merge_face_heights): Now static.
5967d051 8445 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8446 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8447 does not deduce is never used uninitialized.
73719eba
PE
8448 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8449 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8450
426994c3 8451 * terminal.c (store_terminal_param): Now static.
5489860b 8452
032f1620 8453 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8454 (set_frame_menubar): Remove unused local.
d4323972 8455 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8456 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8457 since they might point to immutable storage.
281585b0
PE
8458 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8459 since it's unused otherwise.
032f1620 8460
367c19e5 8461 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8462 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8463 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8464 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8465 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8466 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8467 does not deduce are never used uninitialized.
70739cbe 8468
07b48fa9
PE
8469 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8470
8868a238 8471 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8472 * window.c (window_loop, size_window):
8473 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8474
7e5cf297 8475 * window.c (display_buffer): Now static.
d6550a9f
PE
8476 (size_window): Mark variables that gcc -Wuninitialized
8477 does not deduce are never used uninitialized.
a586633d
PE
8478 * window.h (check_all_windows): New decl, to forestall
8479 gcc -Wmissing-prototypes diagnostic.
5b555da1 8480 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8481
f6095868
PE
8482 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8483 shadowing.
8484 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8485 Include <limits.h>.
8486 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8487 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8488 (load_charset_map): Mark variables that gcc -Wuninitialized
8489 does not deduce are never used uninitialized.
53df7c11 8490 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8491
f38b440c
PE
8492 * coding.c (coding_set_source, coding_set_destination):
8493 Use "else { /* comment */ }" rather than "else /* comment */;"
8494 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8495 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8496 a block, when the outer 'i' will do.
8497 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8498 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8499 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8500 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8501 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8502 Rename locals to avoid shadowing.
8503 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8504 * coding.c (emacs_mule_char, encode_invocation_designation):
8505 Now static, since they're not used elsewhere.
413bb2db 8506 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8507 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8508 (decode_coding_emacs_mule): Mark variables that gcc
8509 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8510 (detect_coding_iso_2022): Initialize a local variable that might
8511 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8512 this initialization is needed. (Bug#8211)
5f58e762
PE
8513 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8514 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8515 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8516 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8517 Remove unused macros.
f38b440c 8518
232b38b9 8519 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8520 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8521 * character.c (string_count_byte8): Likewise.
232b38b9 8522
fb90da1b
PE
8523 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8524 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8525
fb93dbc2
PE
8526 * chartab.c (copy_sub_char_table): Now static, since it's not used
8527 elsewhere.
5c156ace
PE
8528 (sub_char_table_ref_and_range, char_table_ref_and_range):
8529 Rename locals to avoid shadowing.
bbcd0949 8530 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8531
7d3b3862 8532 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8533 (BIDI_BOB): Remove unused macro.
7d3b3862 8534
6be7d3da
PE
8535 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8536 deduce are never used uninitialized.
c2ed9c8b 8537 * term.c (encode_terminal_code): Likewise.
6be7d3da 8538
75f8807f 8539 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8540
50938595
PE
8541 * tparam.h: New file.
8542 * term.c, tparam.h: Include it.
8543 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8544 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8545 Move these decls to tparam.h, and make them agree with what
8546 is actually in tparam.c. The previous trick of using incompatible
8547 decls in different modules does not conform to the C standard.
8548 All callers of tparam changed to use tparam's actual API.
8549 * tparam.c (tparam1, tparam, tgoto):
8550 Use const pointers where appropriate.
8551
fbceeba2
PE
8552 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8553 * cm.h (struct cm): Likewise.
8554 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8555 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8556 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8557 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8558 (turn_on_face, init_tty): Likewise.
8559 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8560
7f3f1250
PE
8561 * term.c (term_mouse_position): Rename local to avoid shadowing.
8562
e6ca6543
PE
8563 * alloc.c (mark_ttys): Move decl from here ...
8564 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8565
c40f8d15
AS
85662011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8567
8568 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8569
cfe0661d
JB
85702011-03-09 Juanma Barranquero <lekktu@gmail.com>
8571
8572 * search.c (compile_pattern_1): Remove argument regp, unused since
8573 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8574 (compile_pattern): Don't pass it.
8575
0afb4571
J
85762011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8577
8578 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8579 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8580 for ! HAVE_GTK3.
8581 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8582
8583 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8584
8585 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8586 gdk_window_get_screen, gdk_window_get_geometry,
8587 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8588 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8589 (xg_get_pixbuf_from_pixmap): New function.
8590 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8591 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8592 Call xg_get_pixbuf_from_pixmap instead of
8593 gdk_pixbuf_get_from_drawable.
8594 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8595 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8596 (xg_check_special_colors): Use GtkStyleContext and its functions
8597 for HAVE_GTK3.
8598 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8599 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8600 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8601 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8602 Call gtk_widget_get_preferred_size.
0afb4571
J
8603 (xg_frame_resized): gdk_window_get_geometry only takes 5
8604 parameters.
44f230aa
SM
8605 (xg_win_to_widget, xg_event_is_for_menubar):
8606 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8607 (xg_set_widget_bg): New function.
8608 (delete_cb): New function.
895009e1 8609 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8610 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8611 (xg_set_background_color): Call xg_set_widget_bg.
8612 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8613 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8614 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8615 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8616 if ! HAVE_GTK3.
8617 (update_frame_tool_bar): Call gtk_widget_hide.
8618 (xg_initialize): Use GDK_KEY_g.
8619
8620 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8621 if ! HAVE_GTK3
8622 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8623
8624 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8625 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8626 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8627
1c2cc4ef
JB
86282011-03-08 Juanma Barranquero <lekktu@gmail.com>
8629
8630 * w32xfns.c (select_palette): Check success of RealizePalette against
8631 GDI_ERROR, not zero.
8632
33383987 8633See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8634
8635;; Local Variables:
8636;; coding: utf-8
aac0c6e3
MR
8637;; End:
8638
33383987 8639 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8640
8641 This file is part of GNU Emacs.
8642
8643 GNU Emacs is free software: you can redistribute it and/or modify
8644 it under the terms of the GNU General Public License as published by
8645 the Free Software Foundation, either version 3 of the License, or
8646 (at your option) any later version.
8647
8648 GNU Emacs is distributed in the hope that it will be useful,
8649 but WITHOUT ANY WARRANTY; without even the implied warranty of
8650 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8651 GNU General Public License for more details.
8652
8653 You should have received a copy of the GNU General Public License
8654 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.