* lread.c (read_filtered_event): Use duration_to_sec_usec.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d311d28c
PE
12011-09-21 Paul Eggert <eggert@cs.ucla.edu>
2
3 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
4 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
5 (string_bytes, check_sblock, allocate_string_data):
6 (compact_small_strings, Fmake_bool_vector, make_string)
7 (make_unibyte_string, make_multibyte_string)
8 (make_string_from_bytes, make_specified_string)
9 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
10 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
11 (mark_vectorlike):
12 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
13 (allocate_pseudovector):
14 Use int, not EMACS_INT, where int is wide enough.
15 (inhibit_garbage_collection, Fgarbage_collect):
16 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
17 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
18 int might not be wide enough.
19 (bidi_cache_search, bidi_cache_find, bidi_init_it)
20 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
21 (bidi_at_paragraph_end, bidi_find_paragraph_start)
22 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
23 (bidi_level_of_next_char, bidi_move_to_visually_next):
24 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
25 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
26 (Fkill_buffer, Fset_buffer_major_mode)
27 (advance_to_char_boundary, Fbuffer_swap_text)
28 (Fset_buffer_multibyte, overlays_at, overlays_in)
29 (overlay_touches_p, struct sortvec, record_overlay_string)
30 (overlay_strings, recenter_overlay_lists)
31 (adjust_overlays_for_insert, adjust_overlays_for_delete)
32 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
33 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
34 (Foverlay_recenter, last_overlay_modification_hooks_used)
35 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
36 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
37 (validate_region): Omit unnecessary test for b <= e, since
38 that's guaranteed by the previous test.
39 (adjust_overlays_for_delete): Avoid pos + length overflow.
40 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
41 (report_overlay_modification):
42 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
43 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
44 Omit pointer cast, which isn't needed anyway, and doesn't work
45 after the EMACS_INT -> ptrdiff_t change.
46 * buffer.h: Adjust decls to match defn changes elsewhere.
47 (struct buffer_text, struct buffer):
48 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
49 Use EMACS_INT, not int, where int might not be wide enough.
50 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, to avoid
51 needless 32-bit limit on 64-bit hosts. Remove unnecessary
52 memory-full test. Use EMACS_INT, not ptrdiff_t or int, where
53 ptrdiff_t or int might not be wide enough.
54 * callint.c (Fcall_interactively):
55 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
56 * callproc.c (call_process_kill, Fcall_process):
57 Don't assume pid_t fits into an Emacs fixnum.
58 (call_process_cleanup, Fcall_process, child_setup):
59 Don't assume pid_t fits into int.
60 (call_process_cleanup, Fcall_process, delete_temp_file)
61 (Fcall_process_region):
62 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
63 (Fcall_process): Simplify handling of volatile integers.
64 Use int, not EMACS_INT, where int will do.
65 * casefiddle.c (casify_object, casify_region, operate_on_word)
66 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
67 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
68 (casify_object): Avoid integer overflow when overallocating buffer.
69 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 70 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
71 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
72 * category.h (CATEGORYP): Don't assume arg is nonnegative.
73 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
74 integers are now checked earlier. All uses replaced with XINT.
75 (ccl_driver):
76 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
77 For CCL_MapSingle, check that content and value are in int range.
78 (resolve_symbol_ccl_program): Check that vector header is in range.
79 Always copy the vector, so that we can check its contents reliably
80 now rather than having to recheck each instruction as it's being
81 executed. Check that vector words fit in 'int'.
82 (ccl_get_compiled_code, Fregister_ccl_program)
83 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
84 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
85 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
86 contents are in range.
87 (Fccl_execute_on_string): Check that status is in range.
88 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
89 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
90 Accept and return EMACS_INT, not int, because callers can pass values
91 out of 'int' range.
92 (c_string_width, strwidth, lisp_string_width, chars_in_text)
93 (multibyte_chars_in_text, parse_str_as_multibyte)
94 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
95 (str_as_unibyte, str_to_unibyte, string_count_byte8)
96 (string_escape_byte8, Fget_byte):
97 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
98 (Funibyte_string): Use CHECK_CHARACTER, not CHECK_NATNUM, to
99 avoid mishandling large integers.
100 * character.h: Adjust decls to match defn changes elsewhere.
101 * charset.c (load_charset_map_from_file, find_charsets_in_text)
102 (Ffind_charset_region):
103 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
104 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
105 (load_charset_map_from_vector, Fdefine_charset_internal):
106 Don't assume fixnum fits in int or unsigned int.
107 (load_charset_map_from_vector, Fmap_charset_chars):
108 Remove now-unnecessary CHECK_NATNUMs.
109 (Fdefine_charset_internal): Check ranges here, more carefully.
110 * chartab.c (Fmake_char_table, Fset_char_table_range)
111 (uniprop_get_decoder, uniprop_get_encoder):
112 Don't assume fixnum fits in int.
113 * cmds.c (move_point): New function, that does the gist of
114 Fforward_char and Fbackward_char, but does so while checking
115 for integer overflow more accurately.
116 (Fforward_char, Fbackward_char, internal_self_insert): Use it.
117 (Fforward_line, Fend_of_line, internal_self_insert)
118 (internal_self_insert):
119 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
120 Fix a FIXME, by checking for integer overflow when calculating
121 target_clm and actual_clm.
122 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
123 (ASSURE_DESTINATION, coding_alloc_by_realloc)
124 (coding_alloc_by_making_gap, alloc_destination)
125 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
126 (encode_coding_utf_16, detect_coding_emacs_mule)
127 (decode_coding_emacs_mule, encode_coding_emacs_mule)
128 (detect_coding_iso_2022, decode_coding_iso_2022)
129 (encode_invocation_designation, encode_designation_at_bol)
130 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
131 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
132 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
133 (encode_coding_ccl, encode_coding_raw_text)
134 (detect_coding_charset, decode_coding_charset)
135 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
136 (produce_composition, produce_charset, produce_annotation)
137 (decode_coding, handle_composition_annotation)
138 (handle_charset_annotation, consume_chars, decode_coding_gap)
139 (decode_coding_object, encode_coding_object, detect_coding_system)
140 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
141 (code_convert_region, code_convert_string)
142 (Fdefine_coding_system_internal):
143 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
144 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
145 (Fdefine_coding_system_internal):
146 Don't assume fixnums fit in int.
147 (decode_coding_gap, decode_coding_object, encode_coding_object)
148 (Fread_coding_system, Fdetect_coding_region, Funencodable_char_position)
149 (Fcheck_coding_systems_region):
150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
151 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
152 (Fdefine_coding_system_internal): Check for charset-id overflow.
153 * coding.h: Adjust decls to match defn changes elsewhere.
154 (struct coding_system):
155 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
156 * composite.c (get_composition_id, find_composition)
157 (run_composition_function, update_compositions)
158 (compose_text, composition_gstring_put_cache)
159 (composition_gstring_p, composition_gstring_width)
160 (fill_gstring_header, fill_gstring_body, autocmp_chars)
161 (composition_compute_stop_pos, composition_reseat_it)
162 (composition_update_it, struct position_record)
163 (find_automatic_composition, composition_adjust_point)
164 (Fcomposition_get_gstring, Ffind_composition_internal):
165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
166 (update_compositions):
167 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
168 * composite.h: Adjust decls to match defn changes elsewhere.
169 (struct composition):
170 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
171 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
172 Do not attempt to compute the address of the object just before a
173 buffer; this is not portable.
174 (Faref, Faset):
175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
176 (Faset): Use int, not EMACS_INT, where int is wide enough.
177 (Fstring_to_number): Don't assume fixnums fit in int.
178 (Frem): Don't assume arg is nonnegative.
179 * dbusbind.c (xd_append_arg): Check for integers out of range.
180 (Fdbus_call_method): Don't overflow the timeout int.
537775e8 181
d311d28c
PE
182 * dired.c (directory_files_internal, file_name_completion, scmp)
183 (file_name_completion_stat):
184 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
185 (file_name_completion): Don't overflow matchcount.
186 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
187 * dispextern.h: Adjust decls to match defn changes elsewhere.
188 (struct text_pos, struct glyph, struct bidi_saved_info)
189 (struct bidi_string_data, struct bidi_it, struct composition_it)
190 (struct it):
191 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
192 (struct display_pos, struct composition_it, struct it):
193 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
194 * dispnew.c (increment_matrix_positions)
195 (increment_row_positions, mode_line_string)
196 (marginal_area_string):
197 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
198 (change_frame_size_1, Fredisplay):
199 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
200 (duration_to_sec_usec): New function, to check for overflow better.
201 (Fsleep_for, sit_for): Use it.
202 * doc.c (get_doc_string, store_function_docstring):
203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
204 (get_doc_string, Fsnarf_documentation):
205 Use int, not EMACS_INT, where int is wide enough.
206 (get_doc_string):
207 Use SAFE_ALLOCA, not alloca.
208 Check for overflow when converting EMACS_INT to off_t.
209 * doprnt.c (doprnt):
210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
211 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
212 Don't assume uid_t fits into fixnum.
213 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
214 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
215 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
216 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
217 (general_insert_function)
218 (Finsert_char, make_buffer_string, make_buffer_string_both)
219 (update_buffer_properties, Fbuffer_substring)
220 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
221 (Fsubst_char_in_region, check_translation)
222 (Ftranslate_region_internal, save_restriction_restore, Fformat)
223 (transpose_markers, Ftranspose_regions):
224 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225 (clip_to_bounds): Move to lisp.h as an inline function).
226 (Fconstrain_to_field): Don't assume integers are nonnegative.
227 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
228 (Fsubst_char_in_region, Fsave_restriction):
229 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
230 (Femacs_pid): Don't assume pid_t fits into fixnum.
231 (lo_time): Use int, not EMACS_INT, when int suffices.
232 (lisp_time_argument): Check for usec out of range.
233 (Fencode_time): Don't assume fixnum fits in int.
234 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
235 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
236 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
237 (init_cmdargs, Fdump_emacs):
238 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
239 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
240 the bottom (typically) 32 bits of the fixnum.
241 * eval.c (specpdl_size, call_debugger):
242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
243 (when_entered_debugger, Fbacktrace_debug):
244 Don't assume fixnum can fit in int.
245 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
246 the object just before a buffer; this is not portable.
247 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
248 (grow_specpdl, unbind_to):
249 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
250 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
251 (grow_specpdl): Simplify allocation by using xpalloc.
252 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
253 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
254 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
255 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
256 (a_write, e_write):
257 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
258 (Fcopy_file, non_regular_nbytes, read_non_regular)
259 (Finsert_file_contents):
260 Use int, not EMACS_INT, where int is wide enough.
261 (READ_BUF_SIZE): Verify that it fits in int.
262 (Finsert_file_contents): Check that counts are in proper range,
263 rather than assuming fixnums fit into ptrdiff_t etc.
264 Don't assume fixnums fit into int.
265 (Fdo_auto_save, Fset_buffer_auto_saved)
266 (Fclear_buffer_auto_save_failure):
267 Don't assume time_t is signed, or that it fits in int.
268 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec)
269 (concat, string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
270 (string_char_to_byte, string_byte_to_char)
271 (string_make_multibyte, string_to_multibyte)
272 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
273 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
274 (substring_both, Fdelete, internal_equal, Ffillarray)
275 (Fclear_string, mapcar1)
276 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
277 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
278 (larger_vector, make_hash_table, maybe_resize_hash_table)
279 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
280 (Fmaphash, secure_hash):
281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
282 (concat): Check for string index and length overflow.
283 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
284 (Frequire):
285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
286 (larger_vector): New API (vec, incr_min, size_max) replaces old
287 one (vec, new_size, init). This catches size overflow.
288 INIT was removed because it was always Qnil.
289 All callers changed.
290 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
291 the upper bound on a hash table index size.
292 (make_hash_table, maybe_resize_hash_table): Use it.
293 (secure_hash): Computer start_byte and end_byte only after
294 they're known to be in ptrdiff_t range.
295 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
296 (Ffont_get_glyphs, Ffont_at):
297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
298 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
299 (Flist_fonts, Fopen_font):
300 Don't assume fixnum can fit in int.
301 (check_gstring): Don't assume index can fit in int.
302 (font_match_p): Check that fixnum is a character, not a nonnegative
303 fixnum, since the later code needs to stuff it into an int.
304 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
305 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
306 conversion overflow issues.
307 (Fopen_font): Check for integer out of range.
308 (Ffont_get_glyphs): Don't assume index can fit in int.
309 * font.h: Adjust decls to match defn changes elsewhere.
310 * fontset.c (reorder_font_vector): Redo score calculation to avoid
311 integer overflow.
312 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
313 printmax_t, where ptrdiff_t is wide enough.
314 (Finternal_char_font):
315 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
316 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
317 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
318 (Fset_frame_position, x_set_frame_parameters)
319 (x_set_line_spacing, x_set_border_width)
320 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
321 Check that fixnums are in proper range for system types.
322 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
323 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
324 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
325 Use SAFE_ALLOCA_LISP, not alloca.
326 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
327 intptr_t is wide enough.
328 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
329 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
330 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
331 Check for fixnum out of range.
332 * ftfont.c (ftfont_list): Don't assume index fits in int.
333 Check that fixnums are in proper range for system types.
334 (ftfont_shape_by_flt):
335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
336 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
337 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
338 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
339 Check that fixnums are in proper range for system types.
340 * gnutls.h: Adjust decls to match defn changes elsewhere.
341 * gtkutil.c (xg_dialog_run):
342 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
343 (update_frame_tool_bar):
344 Check that fixnums are in proper range for system types.
345 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
346 (lookup_image): Check that fixnums are in proper range for system types.
347 * indent.c (last_known_column, last_known_column_point):
348 (current_column_bol_cache):
349 (skip_invisible, current_column, check_display_width):
350 (check_display_width, scan_for_column, current_column_1)
351 (Findent_to, Fcurrent_indentation, position_indentation)
352 (indented_beyond_p, Fmove_to_column, compute_motion):
353 (Fcompute_motion, Fvertical_motion):
354 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
355 (last_known_column_modified): Use EMACS_INT, not int.
356 (check_display_width):
357 (Fcompute_motion):
358 Check that fixnums and floats are in proper range for system types.
359 (compute_motion): Don't assume index or fixnum fits in int.
360 (compute_motion, Fcompute_motion):
361 Use int, not EMACS_INT, when it is wide enough.
362 (vmotion): Omit local var start_hpos that is always 0; that way
363 we don't need to worry about overflow in expressions involving it.
364 * indent.h: Adjust decls to match defn changes elsewhere.
365 (struct position):
366 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
367 Use int, not EMACS_INT, where int is wide enough.
368 Remove unused members ovstring_chars_done and tab_offset;
369 all uses removed.
370 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
371 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
372 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
373 (make_gap, copy_text, insert, insert_and_inherit)
374 (insert_before_markers, insert_before_markers_and_inherit)
375 (insert_1, count_combining_before, count_combining_after)
376 (insert_1_both, insert_from_string)
377 (insert_from_string_before_markers, insert_from_string_1)
378 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
379 (adjust_after_replace, adjust_after_insert, replace_range)
380 (replace_range_2, del_range, del_range_1, del_range_byte)
381 (del_range_both, del_range_2, modify_region)
382 (prepare_to_modify_buffer, signal_before_change)
383 (signal_after_change, Fcombine_after_change_execute):
384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
385 * intervals.c (traverse_intervals, rotate_right, rotate_left)
386 (balance_an_interval, split_interval_right, split_interval_left)
387 (find_interval, next_interval, update_interval)
388 (adjust_intervals_for_insertion, delete_node, delete_interval)
389 (interval_deletion_adjustment, adjust_intervals_for_deletion)
390 (static_offset_intervals, offset_intervals)
391 (merge_interval_right, merge_interval_left, make_new_interval)
392 (graft_intervals_into_buffer, temp_set_point_both)
393 (temp_set_point, set_point, adjust_for_invis_intang)
394 (set_point_both, move_if_not_intangible, get_property_and_range)
395 (get_local_map, copy_intervals, copy_intervals_to_string)
396 (compare_string_intervals, set_intervals_multibyte_1):
397 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
398 * intervals.h: Adjust decls to match defn changes elsewhere.
399 (struct interval):
400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
401 * keyboard.c (this_command_key_count, this_single_command_key_start)
402 (before_command_key_count, before_command_echo_length, echo_now)
403 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
404 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
405 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
406 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
407 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
408 (last_non_minibuf_size, last_point_position, echo_truncate)
409 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
410 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
411 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
412 (stuff_buffered_input):
413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
414 (last_auto_save, command_loop_1, read_char):
415 Use EMACS_INT, not int, to avoid integer overflow.
416 (record_char): Avoid overflow in total_keys computation.
417 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
418 * keyboard.h: Adjust decls to match defn changes elsewhere.
419 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
420 (Fkey_description, Fdescribe_vector, Flookup_key):
421 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
422 (click_position): New function, to check that positions are in range.
423 (Fcurrent_active_maps):
424 (describe_command):
425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
426 (Faccessible_keymaps, Fkey_description):
427 (preferred_sequence_p):
428 Don't assume fixnum can fit into int.
429 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
430 Check for integer overflow in size calculations.
431 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
432 avoid mishandling large integers.
433 * lisp.h: Adjust decls to match defn changes elsewhere.
434 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
435 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
436 (struct Lisp_Marker):
437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
438 (clip_to_bounds): Now an inline function, moved here from editfns.c.
439 (XSETSUBR): Use size of 0 since the actual size doesn't matter,
440 and using 0 avoids overflow.
441 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
442 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
443 All callers changed.
444 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
445 Assume the arg has valid form, since it always does.
446 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
447 unsigned integer system type.
448 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
449 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
450 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
451 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
452 (duration_to_sec_usec): New decl.
453 * lread.c (read_from_string_index, read_from_string_index_byte)
454 (read_from_string_limit, readchar, unreadchar, openp)
455 (read_internal_start, read1, oblookup):
456 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
457 (Fload, readevalloop, Feval_buffer, Feval_region):
458 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
459 (openp): Check for out-of-range argument to 'access'.
460 (read1): Use int, not EMACS_INT, where int is wide enough.
461 Don't assume fixnum fits into int.
1ab7b8ac
PE
462 (read_filtered_event): Use duration_to_sec_usec
463 to do proper overflow checking on durations.
d311d28c
PE
464 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
465 in size calculation.
466 (Fexecute_kbd_macro):
467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
468 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
469 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
470 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
471 (set_marker_both, set_marker_restricted_both, marker_position)
472 (marker_byte_position, Fbuffer_has_markers_at):
473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
474 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
475 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
476 It now merely ensures that the menu is large enough, without
477 necessarily growing it, as this avoids some integer overflow issues.
478 All callers changed.
479 (keymap_panes, parse_single_submenu, Fx_popup_menu):
480 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
481 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
482 Use SAFE_ALLOCA_LISP, not alloca.
483 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
484 to EMACS_INT. Check that fixnums are in proper range for system types.
485 * minibuf.c (minibuf_prompt_width, string_to_object)
486 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
487 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
488 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
489 (get_minibuffer, read_minibuf_unwind):
490 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
491 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
492 this simplifies overflow checking. All callers changed.
493 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
494 (Ftest_completion):
495 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
496 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
497 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
498 Check that fixnums are in proper range for system types.
499 (Fx_create_frame, Fx_show_tip):
500 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
501 * nsfont.m (ns_findfonts, nsfont_list_family):
502 Don't assume fixnum fits in long.
503 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
504 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
505 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
506 wide enough.
507 * nsselect.m (ns_get_local_selection):
508 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
509 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
510 (PRINTDECLARE, PRINTPREPARE):
511 (strout, print_string):
512 (print, print_preprocess, print_check_string_charset_prop)
513 (print_object):
514 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
515 (PRINTDECLARE):
516 (temp_output_buffer_setup, Fprin1_to_string, print_object):
517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
518 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
519 (PRINTFINISH): Use SAFE_ALLOCA, not alloca.
520 (printchar, strout): Use xpalloc to catch size calculation overflow.
521 (Fexternal_debugging_output): Use CHECK_CHARACTER, not CHECK_NUMBER,
522 to avoid mishandling large integers.
523 (print_error_message): Use SAFE_ALLOCA, not alloca.
524 (print_object): Use int, not EMACS_INT, where int is wide enough.
525 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
526 (Fset_process_window_size, Fformat_network_address)
527 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
528 (Fsignal_process, sigchld_handler):
529 Check that fixnums are in proper range for system types.
530 (Fformat_network_address, read_process_output, send_process)
531 (Fprocess_send_region, status_notify):
532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
533 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
534 (wait_reading_process_output, read_process_output, exec_sentinel):
535 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
536 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
537 (Faccept_process_output): Use duration_to_sec_usec to do proper
538 overflow checking on durations.
539 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
540 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
541 * search.c (looking_at_1, string_match_1):
542 (fast_string_match, fast_c_string_match_ignore_case)
543 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
544 (scan_newline, find_before_next_newline, search_command)
545 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
546 (set_search_regs, wordify):
547 (Freplace_match):
548 (Fmatch_data):
549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
550 (string_match_1, search_buffer, set_search_regs):
551 (Fmatch_data):
552 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
553 (wordify): Check for overflow in size calculation.
554 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
555 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
556 Check that fixnums are in proper range for system types.
557 * sound.c (struct sound_device)
558 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
559 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
560 (Fplay_sound_internal):
561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
562 * syntax.c (ST_COMMENT_STYLE, ST_STRING_STYLE):
563 In definitions, make it clearer that these values must be out of range
564 for the respective integer ranges. This fixes a bug with ST_STRING_STYLE
565 and non-ASCII characters.
566 (struct lisp_parse_state, find_start_modiff)
567 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
568 (Fparse_partial_sexp):
569 Don't assume fixnums can fit in int.
570 (struct lisp_parse_state, find_start_pos, find_start_value)
571 (find_start_value_byte, find_start_begv)
572 (update_syntax_table, char_quoted, dec_bytepos)
573 (find_defun_start, prev_char_comend_first, back_comment):
574 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
575 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
576 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
577 (Finternal_describe_syntax_value): Check that match_lisp is a
578 character, not an integer, since the code stuffs it into int.
579 (scan_words, scan_sexps_forward):
580 Check that fixnums are in proper range for system types.
581 (Fforward_word):
582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
583 (scan_sexps_forward):
584 Use CHARACTERP, not INTEGERP, since the value must fit into int.
585 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
586 * syntax.h: Adjust decls to match defn changes elsewhere.
587 (struct gl_state_s):
588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
589 * sysdep.c (wait_for_termination_1, wait_for_termination)
590 (interruptible_wait_for_termination, mkdir):
591 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
592 (emacs_read, emacs_write):
593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
594 (system_process_attributes): Don't assume uid_t, gid_t, and
595 double all fit in int or even EMACS_INT.
596 * term.c (set_tty_color_mode):
597 Check that fixnums are in proper range for system types.
598 * termhooks.h (struct input_event):
599 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
600 * textprop.c (validate_interval_range, interval_of)
601 (Fadd_text_properties, set_text_properties_1)
602 (Fremove_text_properties, Fremove_list_of_text_properties)
603 (Ftext_property_any, Ftext_property_not_all)
604 (copy_text_properties, text_property_list, extend_property_ranges)
605 (verify_interval_modification):
606 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
607 (Fnext_single_char_property_change)
608 (Fprevious_single_char_property_change):
609 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
610 (copy_text_properties): Check for integer overflow in index calculation.
611 * undo.c (last_boundary_position, record_point, record_insert)
612 (record_delete, record_marker_adjustment, record_change)
613 (record_property_change):
614 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
615 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
617 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
618 (Fx_hide_tip, Fx_file_dialog):
619 * w32menu.c (set_frame_menubar):
620 Use ptrdiff_t, not int, for consistency with rest of code.
621 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
622 (select_window, Fdelete_other_windows_internal)
623 (window_scroll_pixel_based, window_scroll_line_based)
624 (Frecenter, Fset_window_configuration):
625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
626 (Fset_window_hscroll, run_window_configuration_change_hook)
627 (set_window_buffer, temp_output_buffer_show, scroll_command)
628 (Fscroll_other_window):
629 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
630 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
631 Don't assume fixnum fits in int.
632 (Fset_window_scroll_bars):
633 Check that fixnums are in proper range for system types.
634 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
635 (string_pos, c_string_pos, number_of_chars, init_iterator)
636 (in_ellipses_for_invisible_text_p, init_from_display_pos)
637 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
638 (compute_display_string_end, handle_face_prop)
639 (face_before_or_after_it_pos, handle_invisible_prop, handle_display_prop)
640 (handle_display_spec, handle_single_display_spec)
641 (display_prop_intangible_p, string_buffer_position_lim)
642 (string_buffer_position, handle_composition_prop, load_overlay_strings)
643 (get_overlay_strings_1, get_overlay_strings)
644 (iterate_out_of_display_property, forward_to_next_line_start)
645 (back_to_previous_visible_line_start, reseat, reseat_to_string)
646 (get_next_display_element, set_iterator_to_next)
647 (get_visually_first_element, compute_stop_pos_backwards)
648 (handle_stop_backwards, next_element_from_buffer)
649 (move_it_in_display_line_to, move_it_in_display_line)
650 (move_it_to, move_it_vertically_backward, move_it_by_lines)
651 (add_to_log, message_dolog, message_log_check_duplicate)
652 (message2, message2_nolog, message3, message3_nolog
653 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
654 (current_message_1, truncate_echo_area, truncate_message_1)
655 (set_message, set_message_1, store_mode_line_noprop)
656 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
657 (text_outside_line_unchanged_p, check_point_in_composition)
658 (reconsider_clip_changes)
659 (redisplay_internal, set_cursor_from_row, try_scrolling)
660 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
661 (redisplay_window, find_last_unchanged_at_beg_row)
662 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
663 (trailing_whitespace_p, find_row_edges, display_line)
664 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
665 (display_mode_element, store_mode_line_string)
666 (pint2str, pint2hrstr, decode_mode_spec)
667 (display_count_lines, display_string, draw_glyphs)
668 (x_produce_glyphs, x_insert_glyphs)
669 (rows_from_pos_range, mouse_face_from_buffer_pos)
670 (fast_find_string_pos, mouse_face_from_string_pos)
671 (note_mode_line_or_margin_highlight, note_mouse_highlight):
672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
673 (safe_call, init_from_display_pos, handle_fontified_prop)
674 (handle_single_display_spec, load_overlay_strings)
675 (with_echo_area_buffer, setup_echo_area_for_printing)
676 (display_echo_area, echo_area_display)
677 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
678 (update_tool_bar, hscroll_window_tree, redisplay_internal)
679 (redisplay_window, dump_glyph_row, display_mode_line, Fformat_mode_line)
680 (decode_mode_spec, on_hot_spot_p):
681 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
682 (handle_single_display_spec, build_desired_tool_bar_string)
683 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
684 (get_specified_cursor_type):
685 Check that fixnums are in proper range for system types.
686 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
687 (Flookup_image_map):
688 Don't assume fixnums fit in int.
689 (compare_overlay_entries):
690 Avoid mishandling comparisons due to subtraction overflow.
691 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
692 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
693 (handle_tool_bar_click):
694 Use int, not unsigned, since we prefer signed and the signedness
695 doesn't matter here.
696 (get_next_display_element, next_element_from_display_vector):
697 Use int, not EMACS_INT, when int is wide enough.
698 (start_hourglass): Use duration_to_sec_usec to do proper
699 overflow checking on durations.
700 * xfaces.c (Fbitmap_spec_p):
701 Check that fixnums are in proper range for system types.
702 (compare_fonts_by_sort_order):
703 Avoid mishandling comparisons due to subtraction overflow.
704 (Fx_family_fonts, realize_basic_faces):
705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
706 (Fx_family_fonts):
707 Don't assume fixnum fits in int.
708 Use SAFE_ALLOCA_LISP, not alloca.
709 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
710 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
711 (face_at_buffer_position, face_for_overlay_string)
712 (face_at_string_position):
713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
714 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
715 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
716 (Fx_show_tip):
717 Check that fixnums are in proper range for system types.
718 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
719 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
720 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
721 (Fx_change_window_property): Don't assume fixnums fit in int.
722 * xfont.c (xfont_chars_supported):
723 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
724 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
725 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
727 * xml.c (parse_region):
728 * xrdb.c (magic_file_p):
729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
730 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
731 (x_get_local_selection, x_reply_selection_request)
732 (x_handle_selection_request, wait_for_property_change):
733 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
734 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
735 short is wide enough.
736 (x_send_client_event): Don't assume fixnum fits in int.
737 * xterm.c (x_x_to_emacs_modifiers):
738 Don't assume EMACS_INT overflows nicely into int.
739 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
740 may come from Lisp.
741 (handle_one_xevent): NATNUMP can eval its arg twice.
742 (x_connection_closed):
743 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
744 * xterm.h: Adjust decls to match defn changes elsewhere.
745 (struct scroll_bar): Use struct vectorlike_header
746 rather than rolling our own approximation.
747 (SCROLL_BAR_VEC_SIZE): Remove; not used.
748
3341db62
EZ
7492011-09-21 Eli Zaretskii <eliz@gnu.org>
750
751 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
752 the xassert test.
753
754 * dispextern.h (struct it): Update the comment documenting what
755 can it->OBJECT be.
756
8c203dbf
EZ
7572011-09-20 Eli Zaretskii <eliz@gnu.org>
758
759 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
760 a display string, extend search for cursor position to end of row.
761 (find_row_edges): If the row ends in a newline from a display
762 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
763 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
764 (Fcurrent_bidi_paragraph_direction): Fix search for previous
765 non-empty line. Fixes confusing cursor motion with arrow keys at
766 the beginning of a line that starts with whitespace.
8c203dbf 767
a4824228
LMI
7682011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
769
770 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
771 (bug#9493).
772
33ed493b
CY
7732011-09-18 Chong Yidong <cyd@stupidchicken.com>
774
775 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
776 boolean (Bug#9154).
777
56cd55c8
EZ
7782011-09-18 Eli Zaretskii <eliz@gnu.org>
779
780 * xdisp.c (display_line): Record maximum and minimum buffer
781 positions even if no glyphs were produced (e.g., by a zero-width
782 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
783 buffer positions that will be removed from the glyph row because
784 they don't fit.
c02dcedf
EZ
785 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
786 column is beyond frame width: don't subtract 1 "pixel" when
787 computing width of the stretch.
3e62b7e0
EZ
788 (reseat_at_next_visible_line_start): Undo the change made on
789 2011-09-17 that saved paragraph information and restored it after
790 the call to `reseat'. (Bug#9545)
56cd55c8 791
5ed99d36 7922011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
793
794 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
795 and turn window cursor on if cleared (Bug#9415).
796
5ed99d36 7972011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
798
799 * search.c (boyer_moore): Take unibyte characters from pattern
800 literally. (Bug#9458)
801
9bade7b2
EZ
8022011-09-18 Eli Zaretskii <eliz@gnu.org>
803
804 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
805
e5e9d610
PE
8062011-09-18 Paul Eggert <eggert@cs.ucla.edu>
807
87e4427a
PE
808 Fix minor problem found by static checking.
809 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
810 initialized, to pacify gcc -Wuninitialized.
811
e5e9d610
PE
812 * fileio.c: Report proper errno when syscall falls.
813 (Finsert_file_contents): Save and restore errno,
814 so that report_file_error outputs the correct diagnostic.
815 (Fwrite_region) [CLASH_DETECTION]: Likewise.
816
a1674f0b
EZ
8172011-09-18 Eli Zaretskii <eliz@gnu.org>
818
819 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
820
fbfb6dd4
EZ
8212011-09-17 Eli Zaretskii <eliz@gnu.org>
822
823 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
824 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
825
bb187662
EZ
8262011-09-17 Eli Zaretskii <eliz@gnu.org>
827
1137e8b8
EZ
828 * xdisp.c (reseat_at_next_visible_line_start): Keep information
829 about the current paragraph and restore it after the call to
830 reseat.
831
832 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
833 (bidi_find_paragraph_start): Search back for paragraph beginning
834 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
835 (bidi_move_to_visually_next): Only trigger paragraph-related
836 computations when the last character is a newline or at EOB, not
837 just any NEUTRAL_B. (Bug#9470)
838
bb187662
EZ
839 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
840 truncated lines if point is covered by a display string. (Bug#9524)
841
2e621251
PE
8422011-09-16 Paul Eggert <eggert@cs.ucla.edu>
843
844 * xselect.c: Relax test for outgoing X longs (Bug#9498).
845 (cons_to_x_long): New function.
846 (lisp_data_to_selection_data): Use it. Correct the test for
847 short-versus-long data; it was negated. Break out of vector
848 loop, for efficiency, when a long datum is discovered.
849
91a15bc6
SM
8502011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
851
852 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
853
b41c3a35
EZ
8542011-09-16 Eli Zaretskii <eliz@gnu.org>
855
856 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
857 GCC PR/17406) by declaring this function with external scope.
858
7812ba2d
PE
8592011-09-15 Paul Eggert <eggert@cs.ucla.edu>
860
861 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
862 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
863
cf7edc2a
AS
8642011-09-15 Andreas Schwab <schwab@linux-m68k.org>
865
866 * editfns.c (Fformat): Correctly handle text properties on "%%".
867
bd01620e
EZ
8682011-09-15 Eli Zaretskii <eliz@gnu.org>
869
870 * xterm.c (x_draw_composite_glyph_string_foreground):
871 * w32term.c (x_draw_composite_glyph_string_foreground):
872 * term.c (encode_terminal_code):
873 * composite.c (composition_update_it, get_composition_id):
874 * xdisp.c (get_next_display_element)
875 (fill_composite_glyph_string): Add comments about special meaning
876 of TAB characters in a composition.
877
a02719a3
PE
8782011-09-15 Paul Eggert <eggert@cs.ucla.edu>
879
880 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
881 This occurs when processing a multibyte format.
882 Problem reported by Wolfgang Jenker.
a02719a3 883
72589a3c
JB
8842011-09-15 Johan Bockgård <bojohan@gnu.org>
885
886 * xdisp.c (try_cursor_movement): Only check for exact match if
887 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
888
1c14176c
PE
8892011-09-14 Paul Eggert <eggert@cs.ucla.edu>
890
891 Remove unused external symbols.
892 * dispextern.h (calc_pixel_width_or_height): Remove decl.
893 * xdisp.c (calc_pixel_width_or_height): Now static.
894 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
895 * indent.c (check_display_width):
896 * w32term.c: Fix comment to match code.
897 * xterm.c, xterm.h (x_catching_errors): Remove.
898
d2eea5b5
PE
8992011-09-14 Paul Eggert <eggert@cs.ucla.edu>
900
901 * xselect.c: Use signed conversions more consistently (Bug#9498).
902 (selection_data_to_lisp_data): Assume incoming selection data are
903 signed integers, not unsigned. This is to be consistent with
904 outgoing selection data, which was modified to use signed integers
905 in as part of the fix to Bug#9196 in response to Jan D.'s comment
906 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
907 expects long, not unsigned long.
908
46888499
EZ
9092011-09-14 Eli Zaretskii <eliz@gnu.org>
910
911 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
912 computation of loop end. Reported by Johan Bockgård
913 <bojohan@gnu.org>.
914
ef8ef9fb
CY
9152011-09-13 Chong Yidong <cyd@stupidchicken.com>
916
917 * frame.c (Fother_visible_frames_p): Function deleted.
918
fa819fed
EZ
9192011-09-12 Eli Zaretskii <eliz@gnu.org>
920
921 * indent.c (compute_motion): Process display vector front to back
922 rather than the other way around. (Bug#2496)
923
2ba8e008
SM
9242011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
925
926 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
927
20f53c69
CY
9282011-09-11 Chong Yidong <cyd@stupidchicken.com>
929
930 * minibuf.c (Fread_from_minibuffer): Doc fix.
931
d562d7a4
EZ
9322011-09-11 Eli Zaretskii <eliz@gnu.org>
933
934 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
935 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
936
1c4d7f3d
LMI
9372011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
938
939 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
940 value for non-existent files.
941
b885bf36
EZ
9422011-09-11 Eli Zaretskii <eliz@gnu.org>
943
944 * fileio.c (Finsert_file_contents): If the file cannot be opened,
945 set its "size" to -1. This will set the modtime_size field of
946 the corresponding buffer to -1, which is what
947 verify-visited-file-modtime expects for files that do not exist.
948 (Bug#9139)
949
6612f0bf
PE
9502011-09-11 Paul Eggert <eggert@cs.ucla.edu>
951
952 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
953 here ...
954 * lisp.h: ... from here. push_key_description is no longer
955 defined in keyboard.c, so its declaration should not be in
956 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
957 logically belongs with push_key_description.
958
dfb3f755
PE
9592011-09-10 Paul Eggert <eggert@cs.ucla.edu>
960
961 * buffer.h: Include <sys/types.h> instead of <time.h>.
962 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
963 Problem reported by Herbert J. Skuhra.
964
3134906c
LMI
9652011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
966
967 * xml.c (parse_region): Make the parsing work for
968 non-comment-starting XML files again (bug#9144).
969
8d903f4e
AS
9702011-09-10 Andreas Schwab <schwab@linux-m68k.org>
971
972 * image.c (gif_load): Fix calculation of bottom and right corner.
973 (Bug#9468)
974
80ad64f4
EZ
9752011-09-10 Eli Zaretskii <eliz@gnu.org>
976
977 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
978 redisplay in small windows.
979
208a048d
EZ
9802011-09-09 Eli Zaretskii <eliz@gnu.org>
981
982 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
983
9b1c252e
MR
9842011-09-08 Martin Rudalics <rudalics@gmx.at>
985
986 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
987 Operate on live windows only.
988
2949f33b
JB
9892011-09-08 Juanma Barranquero <lekktu@gmail.com>
990
991 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
992
e08dcafd
EZ
9932011-09-07 Eli Zaretskii <eliz@gnu.org>
994
995 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
996 only under bidi iteration.
997
115b96bd
JD
9982011-09-07 Jan Djärv <jan.h.d@swipnet.se>
999
1000 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1001
c8199d0f
PE
10022011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1003
1004 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1005 Without this fix, the command to link temacs failed due to an
1006 undefined symbol __builtin_isnan. This is because
1007 /usr/include/iso/math_c99.h #defines isnan(x) to
1008 __builtin_isnan(x), but the bundled gcc, which identifies itself
1009 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1010 a __builtin_isnan.
1011 * floatfns.c (isnan): #undef, and then #define to a clone of
1012 what's in data.c.
1013 (Fisnan): Always define, since it's always available now.
1014 (syms_of_floatfns): Always define isnan at the Lisp level.
1015
e39b275c 10162011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1017
1018 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1019
b2db44d9 10202011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1021
f4af5137 1022 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1023 The previous code assumed that file offsets (off_t values) fit in
1024 EMACS_INT variables, which is not true on typical 32-bit hosts.
1025 The code messed up by falsely reporting buffer overflow in cases
1026 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1027 when "big" contains more than 2**29 bytes, even though this
1028 inserts just one byte and does not overflow the buffer.
1029 (Finsert_file_contents): Store file offsets as off_t
1030 values, not as EMACS_INT values. Check for overflow when
1031 converting between EMACS_INT and off_t. When checking for
1032 buffer overflow or for overlap, take the offsets into account.
1033 Don't use EMACS_INT for small values where int suffices.
1034 When checking for overlap, fix a typo: ZV was used where
1035 ZV_BYTE was intended.
1036 (Fwrite_region): Don't assume off_t fits into 'long'.
1037 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1038
ecfc0a49
MA
10392011-09-05 Michael Albinus <michael.albinus@gmx.de>
1040
1041 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1042
6511acf2 10432011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1044
0999621a 1045 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1046
1047 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1048 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
1049 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1050 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
1051 (modify_event_symbol): Do not assume that the length of
1052 name_alist_or_stem is safe to alloca and fits in int.
1053 (Fexecute_extended_command): Likewise for function name and binding.
1054 (Frecursion_depth): Wrap around reliably on integer overflow.
1055 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1056 since some callers pass EMACS_INT values.
1057 (Fsingle_key_description): Don't crash if symbol name contains more
1058 than MAX_ALLOCA bytes.
1059 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1060 (get_minibuffer): Arg is now EMACS_INT, not int.
1061 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1062 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1063 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1064
2be7d702
PE
1065 * dbusbind.c (signature_cat): New function.
1066 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1067 Do not overrun buffer; instead, report string overflow.
1068
9d1df220
PE
1069 * dispnew.c (add_window_display_history): Don't overrun buffer.
1070 Truncate instead; this is OK since it's just a log.
1071
33ef5c64
PE
1072 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1073 even if the time zone offset is outlandishly large.
1074 Don't mishandle offset == INT_MIN.
1075
66c6fdd5
PE
1076 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1077 when creating daemon; the previous buffer-overflow check was incorrect.
1078
d749b01b
PE
1079 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1080 which has the guts of the old verror function.
1081
b5cd1905
PE
1082 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1083 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1084
6e1a67fb
PE
1085 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1086 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1087 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1088 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1089 length of string rather than counting it via multiple sprintfs;
1090 that's simpler and more reliable.
c21721cc
PE
1091 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1092 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1093 sprintf, in case result does not fit in int.
1094
c57b67fc
PE
1095 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1096 (fontset_from_font): Print it.
1097
8a401434
PE
1098 * frame.c (tty_frame_count): Now printmax_t, not int.
1099 (make_terminal_frame, set_term_frame_name): Print it.
1100 (x_report_frame_params): In X, window IDs are unsigned long,
1101 not signed long, so print them as unsigned.
1102 (validate_x_resource_name): Check for implausibly long names,
1103 and don't assume name length fits in 'int'.
1104 (x_get_resource_string): Don't blindly alloca invocation name;
1105 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1106 not fit in int.
1107
6e1a67fb
PE
1108 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1109 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1110 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1111
0df02bf3
PE
1112 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1113 Use esprintf, not sprintf, in case result does not fit in int.
1114
48e30793
PE
1115 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1116 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1117 it as a large positive number.
1118 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1119 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1120
a66ff6d8
PE
1121 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1122 in case result does not fit in int.
1123
aca216ff
PE
1124 * print.c (float_to_string): Detect width overflow more reliably.
1125 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1126 buffer overrun. Don't assume list length fits in 'int'. Treat
1127 print length of 0 as 0, not as infinity; to be consistent with other
1128 uses of print length in this function. Don't overflow print length
1129 index. Don't assume hash table size fits in 'long', or that
1130 vectorlike size fits in 'unsigned long'.
1131
31c286f7
PE
1132 * process.c (make_process): Use printmax_t, not int, to format
1133 process-name gensyms.
1134
55e5faa1
PE
1135 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1136
80f2e268
PE
1137 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1138 to avoid potential buffer overrun.
1139
670741ab
PE
1140 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1141 if X resource line is longer than 512 bytes.
1142
b7163a50
PE
1143 * xfns.c (x_window): Make sprintf buffer a bit bigger
1144 to avoid potential buffer overrun.
1145
ae58ff1f
PE
1146 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1147
c43c8a6a
PE
1148 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1149
3f8236f4
PE
11502011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1151
53e9fe90 1152 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1153 Without these, Emacs silently mishandles large integers sometimes.
1154 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1155 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1156
6511acf2
PE
1157 * xdisp.c (try_window_id): Check Emacs fixnum range before
1158 converting to 'int'.
806add1d 1159
6511acf2 1160 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1161 Check that an Emacs fixnum is in range before assigning it to 'int'.
1162 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1163 values converted from Emacs fixnums.
1164 (Frecenter): Don't wrap around a line count if it is out of 'int'
1165 range; instead, treat it as an extreme value.
1166 (Fset_window_configuration, compare_window_configurations):
1167 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1168
6511acf2
PE
1169 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1170 that can exceed INT_MAX. Check that EMACS_INT value is in range
1171 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1172 (match_limit): Don't assume that a fixnum can fit in 'int'.
1173
6511acf2 1174 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1175 exceed INT_MAX.
1176
6511acf2 1177 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1178 (Fvertical_motion): Don't wrap around LINES values that don't fit
1179 in 'int'. Instead, treat them as extreme values. This is good
1180 enough for windows, which can't have more than INT_MAX lines anyway.
1181
fcb901a7
LMI
11822011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1183
0f2f6b6d
LMI
1184 * Require libxml/parser.h to avoid compilation warning.
1185
fcb901a7
LMI
1186 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1187
1188 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1189 since this reportedly can destroy thread storage.
1190
6e20a0d4
CY
11912011-08-30 Chong Yidong <cyd@stupidchicken.com>
1192
1193 * syntax.c (find_defun_start): Update all cache variables if
1194 exiting early (Bug#9401).
1195
148ae00e
EZ
11962011-08-30 Eli Zaretskii <eliz@gnu.org>
1197
f6cfbd8f
EZ
1198 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1199
148ae00e
EZ
1200 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1201 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1202 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1203
1204 * term.c (tty_append_glyph): New function.
1205 (produce_stretch_glyph): Static function and its prototype deleted.
1206
1207 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
1208 prototypes.
1209
c4a07a4c
PE
12102011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1211
1212 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1213 when checking :margin (Bug#9390).
1214 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1215 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1216 so that the name doesn't mislead. All uses changed.
1217
6bc8cd65
JB
12182011-08-28 Johan Bockgård <bojohan@gnu.org>
1219
1220 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1221 set_tty_hooks.
1222
dca4927e
EZ
12232011-08-27 Eli Zaretskii <eliz@gnu.org>
1224
1225 * xdisp.c (move_it_to): Don't bail out early when reaching
1226 position beyond to_charpos, if we are scanning backwards.
1227 (move_it_vertically_backward): When DY == 0, make sure we get to
1228 the first character in the line after the newline.
1229
f2cad773
PE
12302011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1231
1232 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1233 (ccl_driver): Do not generate an out-of-range pointer.
1234 (Fccl_execute_on_string): Remove unnecessary check for
1235 integer overflow, noted by Stefan Monnier in
1236 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1237 Remove a FIXME that didn't need fixing.
1238 Simplify the newly-introduced buffer reallocation code.
1239
0cae2cdb
JB
12402011-08-27 Juanma Barranquero <lekktu@gmail.com>
1241
1242 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1243
5fc295a4 12442011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1245
70c60eb2 1246 Integer and memory overflow issues (Bug#9196).
726e0ab1 1247
d31850da
PE
1248 * doc.c (get_doc_string): Rework so that
1249 get_doc_string_buffer_size is the actual buffer size, rather than
1250 being 1 less than the actual buffer size; this makes xpalloc more
1251 convenient.
1252
a69fbedb
PE
1253 * image.c (x_allocate_bitmap_record, cache_image):
1254 * xselect.c (Fx_register_dnd_atom):
1255 Simplify previous changes by using xpalloc.
1256
fe5c5d37
PE
1257 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1258 since either will do and ptrdiff_t is convenient with xpalloc.
1259
0065d054
PE
1260 * charset.c (charset_table_size)
1261 (struct charset_sort_data.priority): Now ptrdiff_t.
1262 (charset_compare): Don't overflow if priorities differ greatly.
1263 (Fsort_charsets): Don't assume list length fits in int.
1264 Check for size-calculation overflow when allocating sort data.
1265 (syms_of_charset): Allocate an initial charset table that is
1266 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1267
1268 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1269
1270 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1271 The actual value is always <= INT_MAX, and leaving it unsigned made
1272 overflow checking harder.
1273
1274 * dispextern.h (struct glyph_matrix.rows_allocated)
1275 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1276 with xpalloc. The values are still always <= INT_MAX.
1277
1278 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1279
1280 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1281 (SAFE_NALLOCA): New macro.
1282
1283 * region-cache.c (struct boundary.pos, find_cache_boundary)
1284 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1285 (set_cache_region, invalidate_region_cache)
1286 (revalidate_region_cache, know_region_cache, region_cache_forward)
1287 (region_cache_backward, pp_cache):
1288 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1289 so that ptrdiff_t * can be passed to xpalloc.
1290 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1291 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1292 (pp_cache): Don't assume cache_len fits in int.
1293 * region-cache.h: Adjust extern decls to match.
1294
1295 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1296 EMACS_INT, since either will do, for xpalloc.
1297
1298 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1299 (xnmalloc, xnrealloc, xpalloc): New functions.
1300
726e0ab1
PE
1301 * bidi.c (bidi_shelve_header_size): New constant.
1302 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1303 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1304
51f30bc5 1305 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1306 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1307 (overlay_strings):
1308 Don't update size of array until after memory allocation succeeds,
1309 because xmalloc/xrealloc may not return.
0065d054
PE
1310 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1311 now that we have proper integer overflow checking.
1312 (record_overlay_string, overlay_strings): Catch overflows when
1313 calculating size of overlay_str_buf.
726e0ab1 1314
0065d054
PE
1315 * callproc.c (Fcall_process): Check for size overflow when
1316 calculating size of args2.
1317 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1318 Normally we prefer signed values, but sticking with ptrdiff_t would
1319 require adding more-complicated checks.
726e0ab1
PE
1320
1321 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1322 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1323 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1324 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1325
1326 * character.c (Fstring): Check for size-calculation overflow.
1327
1328 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1329 unnecessary integer overflow. Check for size overflow.
1330 (encode_coding_object): Don't update size until xmalloc succeeds.
1331
1332 * composite.c (get_composition_id): Check for overflow in glyph
1333 length calculations.
1334
1335 Integer and memory overflow fixes for display code.
1336 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1337 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1338 (scrolling_window): Check for overflow in size calculations.
1339 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1340 Don't assume glyph table len fits in int.
1341 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1342 (row_table_size): Now ptrdiff_t, not int.
1343 (scrolling_window): Avoid overflow in size calculations.
1344 Don't update size until allocation succeeds.
1345 * fns.c (concat): Check for overflow in size calculations.
1346 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1347 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1348 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1349
1350 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1351 (get_doc_string): Check for size calculation overflow.
1352 Don't update size until allocation succeeds.
1353 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1354 EMACS_INT, where ptrdiff_t will do.
1355 (Fsubstitute_command_keys): Check for string overflow.
1356
1357 * editfns.c (set_time_zone_rule): Don't assume environment length
1358 fits in int.
1359 (message_length): Now ptrdiff_t, not int.
1360 (Fmessage_box): Don't update size until allocation succeeds.
1361 Don't assume message length fits in int.
1362 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1363
0065d054
PE
1364 * emacs.c (main): Do not reallocate argv, since there is a null at
1365 the end that can be overwritten, and this way there's no need to
1366 worry about size-calculation overflow.
1367 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1368
1369 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1370 alloc succeeds.
1371 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1372
1373 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1374 (x_set_scroll_bar_width, x_figure_window_size):
1375 Check for integer overflow.
1376 (x_set_alpha): Do not assume XINT fits in int.
1377
1378 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1379 This is for the members text_lines, text_cols, total_lines, total_cols,
1380 where the system imposes an 'int' limit.
1381
1382 * fringe.c (Fdefine_fringe_bitmap):
1383 Don't update size until alloc works.
1384
1385 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1386 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1387
1388 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1389 Check for size-calculation overflow.
1390 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1391 do, as we prefer signed integers.
1392 (id_to_widget.max_size, id_to_widget.used)
1393 (xg_store_widget_in_map, xg_remove_widget_from_map)
1394 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1395 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1396 Use and return ptrdiff_t, not int.
1397 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1398 * gtkutil.h: Change prototypes to match the above.
1399
1400 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1401 are duplicate now that they've been promoted to lisp.h.
1402 (x_allocate_bitmap_record, x_alloc_image_color)
1403 (make_image_cache, cache_image, xpm_load):
1404 Don't update size until alloc is done.
1405 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1406 (x_detect_edges):
3256efce 1407 Check for size calculation overflow.
726e0ab1
PE
1408 (ct_colors_allocated_max): New constant.
1409 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1410 overflow.
3256efce 1411
726e0ab1
PE
1412 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1413 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1414 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1415 Use ptrdiff_t, not int, to count maps.
1416 (read_char_minibuf_menu_prompt): Check for overflow in size
1417 calculations. Don't update size until allocation succeeds. Redo
1418 calculations to avoid overflow.
1419 * keyboard.h: Change prototypes to match the above.
1420
1421 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1422 to count maps.
1423 (current_minor_maps): Check for size calculation overflow.
1424 * keymap.h: Change prototypes to match the above.
1425
1426 * lread.c (read1, init_obarray): Don't update size until alloc done.
1427
1428 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1429 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1430
726e0ab1
PE
1431 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1432 Now ptrdiff_t, not int.
1433 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1434 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1435
1436 * process.c (Fnetwork_interface_list): Check for overflow
1437 in size calculation.
1438
1439 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1440
1441 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1442 overflow. Don't bother calling xmalloc when xrealloc will do.
1443
1444 * search.c (Freplace_match): Check for size calculation overflow.
1445 (Fset_match_data): Don't assume list lengths fit in 'int'.
1446
1447 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1448 for command line length. Do not attempt to address one before the
1449 beginning of an array, as that's not portable.
1450
1451 * term.c (max_frame_lines): Remove; unused.
1452 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1453 not int.
1454 (encode_terminal_code, calculate_costs): Check for size
1455 calculation overflow.
1456 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1457 table lengths and related sizes. Don't update size until alloc
1458 done. Redo calculations to avoid overflow.
1459 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1460
1461 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1462 subtracting pointers.
1463 (gobble_line): Check for overflow more carefully. Don't update size
1464 until alloc done.
1465
1466 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1467 Don't update size until alloc done.
1468 Redo size calculations to avoid overflow.
1469 Check for size calculation overflow.
0065d054 1470 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1471
1472 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1473 Use ptrdiff_t, not int, for sizes.
1474 (store_mode_line_noprop_char): Don't update size until alloc done.
1475
0065d054
PE
1476 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1477 Use ptrdiff_t, not int, for sizes.
1478 (Finternal_make_lisp_face, cache_face):
1479 Check for size calculation overflow.
1480 (cache_face): Treat size calculation overflows as if they were
1481 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1482
1483 * xfns.c (x_encode_text, x_set_name_internal)
1484 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1485 sizes, since they can exceed INT_MAX in size. Check for size
1486 calculation overflow.
1487
0065d054
PE
1488 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1489 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1490 Don't update size until alloc done.
1491
0065d054 1492 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1493 as sprintf is limited to int lengths.
1d526e2f 1494
252c5ee1
PE
1495 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1496 (X_LONG_MIN): New macros.
864d7ce7
PE
1497 Use them to make the following changes clearer.
1498 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1499 This change doesn't affect the value now, but it may help remind
1500 future maintainers not to raise the value too much later.
1501 (SELECTION_QUANTUM): Remove, replacing with ...
1502 (selection_quantum): ... new function, which avoids overflow.
1503 All uses changed.
1504 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1505 assumption that selection length fits in 'int'.
1506 (x_reply_selection_request, x_handle_selection_request)
1507 (x_get_window_property, receive_incremental_selection)
1508 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1509 (lisp_data_to_selection_data, clean_local_selection_data):
1510 Use ptrdiff_t, not int, to record length of selection.
1511 (x_reply_selection_request, x_get_window_property)
1512 (receive_incremental_selection, x_property_data_to_lisp):
1513 Redo calculations to avoid overflow.
1514 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1515 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1516 something.
1517 (x_get_window_property, receive_incremental_selection)
1518 (lisp_data_to_selection_data, x_property_data_to_lisp):
1519 Check for size-calculation overflow.
1520 (x_get_window_property, receive_incremental_selection)
1521 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1522 Don't store size until memory allocation succeeds.
1523 (x_get_window_property): Plug memory leak on memory exhaustion.
1524 Don't double-block input; malloc is safe here. Don't assume 2**34
1525 - 4 fits in unsigned long. Add an xassert to check
1526 XGetWindowProperty overflow. Be more careful about overflow
1527 calculations, and distinguish size from memory overflow better.
1528 (receive_incremental_selection): When tracing, don't assume
1529 unsigned int is less than INT_MAX.
1530 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1531 harmful) conversions of unsigned short to int.
1532 (lisp_data_to_selection_data): Don't assume that integers
1533 in the range -65535 through -1 fit in an X unsigned short.
1534 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1535 result parameters unless successful. Rely on cons_to_unsigned
1536 to report problems with elements; the old code wasn't right anyway.
1537 (x_check_property_data): Check for int overflow; we cannot use
1538 a wider type due to X limits.
1539 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1540
726e0ab1 1541 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1542
0065d054
PE
1543 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1544 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1545 (x_color_cells): Don't store size until memory allocation succeeds.
1546 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1547 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1548 (x_term_init): Don't assume length fits in int (sprintf is limited
1549 to int size).
bc18e09d 1550
ebfa62c0
PE
1551 Use ptrdiff_t for composition IDs.
1552 * character.c (lisp_string_width):
1553 * composite.c (composition_table_size, n_compositions)
1554 (get_composition_id, composition_gstring_from_id):
1555 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1556 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1557 * window.c (Frecenter):
1558 Use ptrdiff_t, not int, for composition IDs.
1559 * composite.c (get_composition_id): Check for integer overflow.
1560 * composite.h: Adjust prototypes to match the above changes.
1561
d3411f89
PE
1562 Use ptrdiff_t for hash table indexes.
1563 * category.c (hash_get_category_set):
1564 * ccl.c (ccl_driver):
1565 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1566 * coding.c (coding_system_charset_list, detect_coding_system):
1567 * coding.h (struct coding_system.id):
1568 * composite.c (get_composition_id, gstring_lookup_cache):
1569 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1570 * image.c (xpm_get_color_table_h):
1571 * lisp.h (hash_lookup, hash_put):
1572 * minibuf.c (Ftest_completion):
1573 Use ptrdiff_t for hash table indexes, not int (which is too
1574 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1575 32-bit --with-wide-int hosts).
1576
e097a6fa
PE
1577 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1578 Add a FIXME comment about memory leaks.
1579 (syms_of_charset): Don't assume xmalloc returns.
1580
5637687f
PE
1581 Don't assume that stated character widths fit in int.
1582 * character.c (Fchar_width, c_string_width, lisp_string_width):
1583 * character.h (CHAR_WIDTH):
1584 * indent.c (MULTIBYTE_BYTES_WIDTH):
1585 Use sanitize_char_width to avoid undefined and/or bad behavior
1586 with outlandish widths.
1587 * character.h (sanitize_tab_width): Renamed from sanitize_width,
1588 now that we have two such functions. All uses changed.
1589 (sanitize_char_width): New inline function.
1590
a2271ba2
PE
1591 Don't assume that tab-width fits in int.
1592 * character.h (sanitize_width): New inline function.
1593 (SANE_TAB_WIDTH): New macro.
1594 (ASCII_CHAR_WIDTH): Use it.
1595 * indent.c (sane_tab_width): Remove. All uses replaced by
1596 SANE_TAB_WIDTH (current_buffer).
1597 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1598
18c52557
PE
1599 * fileio.c: Integer overflow issues with file modes.
1600 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1601
caeeedc1
PE
1602 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1603 Remove unreachable code.
1604 (read_hex, load_charset_map_from_file): Check for integer overflow.
1605
50849c52
PE
1606 * xterm.c: don't go over XClientMessageEvent limit
1607 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1608 (x_send_scroll_bar_event): Likewise. Check that the size does not
1609 exceed limits imposed by XClientMessageEvent, as well as the usual
1610 ptrdiff_t and size_t limits.
1611
b13995db
PE
1612 * keyboard.c: Overflow, signedness and related fixes.
1613 (make_lispy_movement): Use same integer type in forward decl
1614 that is used in the definition.
1615 (read_key_sequence, keyremap_step):
1616 Change bufsize argument back to int, undoing my 2011-03-30 change.
1617 We prefer signed types, and int is wide enough here.
1618 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1619 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1620 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1621 length, not size_t. Use ptrdiff_t for index, not int.
1622 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1623 possibility of integer overflow.
1624
13464394
PE
1625 Overflow, signedness and related fixes for images.
1626
1627 * dispextern.h (struct it.stack[0].u.image.image_id)
1628 (struct_it.image_id, struct image.id, struct image_cache.size)
1629 (struct image_cache.used, struct image_cache.ref_count):
1630 * gtkutil.c (update_frame_tool_bar):
1631 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1632 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1633 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1634 * nsmenu.m (update_frame_tool_bar):
1635 * xdisp.c (calc_pixel_width_or_height):
1636 * xfns.c (image_cache_refcount):
1637 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1638 on typical 64-bit hosts.
1639
1640 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1641 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1642 Omit unnecessary casts to int.
1643 (parse_image_spec): Check that integers fall into 'int' range
1644 when the callers expect that.
1645 (image_ascent): Redo ascent calculation to avoid int overflow.
1646 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1647 (lookup_image): Remove unnecessary tests.
1648 (xbm_image_p): Locals are now of int, not EMACS_INT,
1649 since parse_image_check makes sure they fit into int.
1650 (png_load, gif_load, svg_load_image):
1651 Prefer int to unsigned where either will do.
1652 (tiff_handler): New function, combining the cores of the
1653 old tiff_error_handler and tiff_warning_handler. This
1654 function is rewritten to use vsnprintf and thereby avoid
1655 stack buffer overflows. It uses only the features of vsnprintf
1656 that are common to both POSIX and native Microsoft.
1657 (tiff_error_handler, tiff_warning_handler): Use it.
1658 (tiff_load, gif_load, imagemagick_load_image):
1659 Don't assume :index value fits in 'int'.
1660 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1661 (imagemagick_load_image): Check that crop parameters fit into
1662 the integer types that MagickCropImage accepts. Don't assume
1663 Vimagemagick_render_type has a nonnegative value. Don't assume
1664 size_t fits in 'long'.
1665 (gs_load): Use printmax_t to print the widest integers possible.
1666 Check for integer overflow when computing image height and width.
1667
c11821d4
EZ
16682011-08-26 Eli Zaretskii <eliz@gnu.org>
1669
1670 * xdisp.c (redisplay_window): Don't force window start if point
1671 will be invisible in the resulting window. (Bug#9324)
1672
0c95fcf7
EZ
16732011-08-25 Eli Zaretskii <eliz@gnu.org>
1674
1675 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1676 the display spec is of the form `(space ...)'.
1677 (handle_display_spec): Return the value returned by
1678 handle_single_display_spec, not just 1 or zero.
1679 (handle_single_display_spec): If the display spec is of the form
1680 `(space ...)', and specifies display in the text area, return 2
1681 rather than 1.
fee65a97 1682 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
1683 accurately, and prefer exact match for point under bidi. Don't
1684 advance `row' beyond the last row of the window.
0c95fcf7
EZ
1685
1686 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1687 into disp_prop; all users changed.
1688
1689 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1690 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1691 for the text covered by the display property.
1692
e4ed06f1
CY
16932011-08-25 Chong Yidong <cyd@stupidchicken.com>
1694
1695 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1696 Change return value to nil.
1697 (Frecord_buffer): Delete unused function.
1698
f67cdd7f
EZ
16992011-08-24 Eli Zaretskii <eliz@gnu.org>
1700
5980d4c6
EZ
1701 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1702 buffers, return left-to-right.
8610fe8b
EZ
1703 (set_cursor_from_row): Consider candidate row a win if its glyph
1704 represents a newline and point is on that newline. Fixes cursor
1705 positioning on the newline at EOL of R2L text within L2R
1706 paragraph, and vice versa.
1707 (try_cursor_movement): Check continued rows, in addition to
1708 continuation rows. Fixes unwarranted scroll when point enters a
1709 continued line of R2L text within an L2R paragraph, or vice versa.
1710 (cursor_row_p): Consider the case of point being equal to
1711 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1712 from the end of a short line to the beginning of a continued line
1713 of R2L text within L2R paragraph.
1714 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1715 composed characters.
5980d4c6 1716
f67cdd7f
EZ
1717 * bidi.c (bidi_check_type): Use xassert.
1718 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1719 members.
1720
bca633fb
EZ
17212011-08-23 Eli Zaretskii <eliz@gnu.org>
1722
1723 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1724 a character.
1725
4a5885a7
CY
17262011-08-23 Chong Yidong <cyd@stupidchicken.com>
1727
1728 * nsfont.m (ns_otf_to_script): Fix typo.
1729
0902a04e
KH
17302011-08-22 Kenichi Handa <handa@m17n.org>
1731
1732 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1733 extra slot even if the purpose is char-code-property-table.
1734
1a2e6670
EZ
17352011-08-23 Eli Zaretskii <eliz@gnu.org>
1736
8ddde651
EZ
1737 * xdisp.c (redisplay_window): When computing centering_position,
1738 account for the height of the header line. (Bug#8874)
1739
425cc014
EZ
1740 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1741 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1742 candidate is selected by the mouse, and that candidate has a
1743 composed character under the mouse.
1744
1a2e6670
EZ
1745 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1746 coordinates reported by pos-visible-in-window-p for a composed
1747 character in column zero.
1748
8b76d6f8
SM
17492011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1750
1751 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1752
dac347dd
EZ
17532011-08-22 Eli Zaretskii <eliz@gnu.org>
1754
1755 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1756 consider it a hit if to_charpos is anywhere in the range of the
1757 composed buffer positions.
1758
e013fb34
CY
17592011-08-22 Chong Yidong <cyd@stupidchicken.com>
1760
1761 * image.c (gif_load): Don't assume that each subimage has the same
1762 dimensions as the base image. Handle disposal method that is
1763 "undefined" by the gif spec (Bug#9335).
1764
bd1ba3e8
CY
17652011-08-20 Chong Yidong <cyd@stupidchicken.com>
1766
1767 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1768 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1769
54a1215b
EZ
17702011-08-19 Eli Zaretskii <eliz@gnu.org>
1771
823564e5
EZ
1772 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1773 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1774 from an Org mode buffer to a Speedbar frame.
1775
54a1215b
EZ
1776 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1777 a composition, take its buffer position from IT->cmp_it.charpos.
1778 Fixes cursor positioning at the beginning of a line that begins
1779 with a composed character.
1780
9778ebcc
EZ
17812011-08-18 Eli Zaretskii <eliz@gnu.org>
1782
0be6ee06
EZ
1783 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1784 character bidirectional type, use STRONG_L instead. Fixes crashes
1785 in a buffer produced by `describe-categories'.
1786
9778ebcc
EZ
1787 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1788 members before the level stack, so they would be saved and
1789 restored when copying iterator state. Fixes incorrect reordering
1790 around TABs covered by display properties.
1791
156bffbe
AS
17922011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1793
1794 * process.c (Fnetwork_interface_list): Correctly determine buffer
1795 size.
1796
72ad093b
CY
17972011-08-17 Chong Yidong <cyd@stupidchicken.com>
1798
1799 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1800 (internal_condition_case_2, internal_condition_case_n):
1801 Remove unnecessary aborts (Bug#9081).
72ad093b 1802
35774242
EZ
18032011-08-17 Eli Zaretskii <eliz@gnu.org>
1804
1805 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1806 has no `load' handler, try opening the file locally. (Bug#9311)
1807
db76dd85
KB
18082011-08-16 Ken Brown <kbrown@cornell.edu>
1809
1810 * gmalloc.c: Expand comment.
1811
b215eee5
EZ
18122011-08-16 Eli Zaretskii <eliz@gnu.org>
1813
1814 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1815 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1816
a4579d33
KB
18172011-08-16 Ken Brown <kbrown@cornell.edu>
1818
1819 Fix memory allocation problems in Cygwin build (Bug#9273).
1820
1821 * unexcw.c ( __malloc_initialized): Declare external variable.
1822 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1823
8b76d6f8
SM
1824 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1825 New variables.
a4579d33
KB
1826 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1827 dumped emacs.
1828 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1829 in the static heap.
1830 [CYGWIN] (special_realloc): New function.
1831 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1832 requests to realloc storage in the static heap.
1833
3ebec551
PE
18342011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1835
1836 * bidi.c (bidi_initialize): Remove unused local.
1837
9fd8be00
EZ
18382011-08-15 Eli Zaretskii <eliz@gnu.org>
1839
474a8465
EZ
1840 * biditype.h: File removed.
1841
1842 * bidimirror.h: File removed.
1843
1844 * deps.mk (bidi.o): Remove biditype.h and
1845 bidimirror.h.
1846
1847 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1848 bidimirror.h.
1849
1850 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1851
1852 * chartab.c: Improve commentary for the uniprop_table API.
1853
32413314
EZ
1854 * bidi.c (bidi_paragraph_init): Support zero value of
1855 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1856 (bidi_initialize): Use uniprop_table instead of including
1857 biditype.h and bidimirror.h.
32413314 1858
9fd8be00
EZ
1859 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1860 coordinates of the iterator when restoring from ppos_it.
1861 (Bug#9296)
1862
5cf2b69b
KH
18632011-08-14 Kenichi Handa <handa@m17n.org>
1864
1865 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1866 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1867
daf17d00
EZ
18682011-08-14 Eli Zaretskii <eliz@gnu.org>
1869
1870 * xdisp.c (move_it_in_display_line_to): Don't invoke
1871 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1872 ppos_it. Fixes vertical cursor motion when line beginning is
1873 covered by an image. (Bug#9296)
1874
08e3161a
JD
18752011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1876
1877 * nsterm.h (ns_run_ascript): Declare.
1878 (NSAPP_DATA2_RUNASSCRIPT): Define.
1879
1880 * nsfns.m (as_script, as_result, as_status): New static variables.
1881 (ns_run_ascript): New function.
5e617bc2 1882 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1883 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1884 the event loop. Get status from as_status (Bug#7276).
1885
1886 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1887 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1888 the event loop (Bug#7276).
1889
a3720aa2
AS
18902011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1891
1892 * gnutls.c (QCgnutls_bootprop_priority)
1893 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1894 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1895 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1896 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1897 (QCgnutls_bootprop_verify_hostname_error)
1898 (QCgnutls_bootprop_callbacks_verify): Rename from
1899 Qgnutls_bootprop_..., all uses changed.
1900
1901 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1902 uses changed.
1903
0a0d27fb
PE
19042011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1905
19d5c50c
PE
1906 * xfaces.c (Qframe_set_background_mode): Now static.
1907 * dispextern.h (Qframe_set_background_mode): Remove decl.
1908
0a0d27fb
PE
1909 * process.c (Fnetwork_interface_info): Declare local only if needed.
1910
377538cb
JD
19112011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1912
1913 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1914 (Fnetwork_interface_list): Allocate in increments of bytes instead
1915 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1916 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1917 sockaddr.
1918 (struct ifflag_def): notrailers is smart on OSX.
1919 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1920 Get hardware address with getifaddrs if available.
1921
08fff70c
EZ
19222011-08-12 Eli Zaretskii <eliz@gnu.org>
1923
1924 * xdisp.c (iterate_out_of_display_property): xassert that
1925 IT->position is set to within IT->object's boundaries. Break from
1926 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1927 when IT->position is set up wrongly due to some bug.
1928 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1929 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1930 entry. Force push_it to save on the stack the current
1931 buffer/string position, to be restored by pop_it. Fix flags in
1932 the iterator structure wrt the object coming from a display
1933 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1934 properties. (Bug#9284)
1935
7be1c708 19362011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1937
7be1c708
CY
1938 * fontset.c (fontset_get_font_group): Add proper type checks.
1939 (Bug#9172)
aac0c6e3 1940
7be1c708 19412011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1942
7be1c708
CY
1943 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1944 and LC_VERSION_MIN_MACOSX.
1945 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1946 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1947
97bb72a6
EZ
19482011-08-08 Eli Zaretskii <eliz@gnu.org>
1949
1950 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1951 no-display-properties-and-no-overlays under bidi display.
1952 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1953 properties and overlays.
97bb72a6 1954
d5617611
CY
19552011-08-08 Chong Yidong <cyd@stupidchicken.com>
1956
37e11a63
CY
1957 * editfns.c (Fset_time_zone_rule): Document relationship with the
1958 setenv function.
1959
d5617611
CY
1960 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1961 the font entity extracted from the cache (Bug#8109).
1962
58872834
CY
19632011-08-07 Chong Yidong <cyd@stupidchicken.com>
1964
1965 * composite.c (autocmp_chars): Don't reset point. That is done by
1966 restore_point_unwind (Bug#5984).
1967
75bfc667
JL
19682011-08-07 Juri Linkov <juri@jurta.org>
1969
1970 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1971 to show the arg `TIME' instead of `TIMEVAL'.
1972
d1410150
EZ
19732011-08-06 Eli Zaretskii <eliz@gnu.org>
1974
1975 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1976 display property strides EOL and includes a newline, as in
1977 longlines-mode. (Bug#9254)
75b771e4
EZ
1978 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1979 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1980
1981 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1982 is non-zero, even if the data buffer is NULL. Fixes a crash in
1983 vertical-motion with longlines-mode. (Bug#9254)
1984
35928349
EZ
19852011-08-05 Eli Zaretskii <eliz@gnu.org>
1986
ec7cc85b
EZ
1987 * bidi.c <bidi_cache_total_alloc>: Now static.
1988 (bidi_initialize): Initialize bidi_cache_total_alloc.
1989
8b76d6f8 1990 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1991 cache. (Bug#9221)
1992
1993 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1994 amount allocated this far in `bidi_cache_total_alloc'.
1995 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1996 non-zero, only free the data buffer without restoring the cache
1997 contents. All callers changed.
1998
1999 * dispextern.h (bidi_unshelve_cache): Update prototype.
2000
2001 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2002 (move_it_in_display_line, move_it_to)
2003 (move_it_vertically_backward, move_it_by_lines): Replace the call
2004 to xfree to an equivalent call to bidi_unshelve_cache.
2005 (move_it_in_display_line_to): Fix logic of returning
412b6358 2006 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2007
e2e2423b
EZ
20082011-08-05 Eli Zaretskii <eliz@gnu.org>
2009
2010 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2011 came from a string character with a `cursor' property. (Bug#9229)
2012
ae9e757a
JD
20132011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2014
2015 * Makefile.in (LIB_PTHREAD): New variable.
2016 (LIBES): Add LIB_PTHREAD (Bug#9216).
2017
2018 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2019 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2020
213bd7f2
AS
20212011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2022
2023 * regex.c (re_iswctype): Remove some redundant boolean
2024 conversions.
2025
99aaf75f
JD
20262011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2027
2028 * xterm.c (x_find_topmost_parent): New function.
2029 (x_set_frame_alpha): Find topmost parent window with
2030 x_find_topmost_parent and set the property there also (bug#9181).
2031 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2032
c74e9d86
PE
20332011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2034
2035 * callproc.c (Fcall_process): Avoid vfork clobbering
2036 the local vars buffer, coding_systems, current_dir.
2037
640c8776
SM
20382011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2039
2040 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2041
f26d0e4c
PE
20422011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2043
8a10d76c
PE
2044 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2045 so that it is not optimized away.
2046
f26d0e4c
PE
2047 * xdisp.c (compute_display_string_pos): Remove unused local.
2048
55439c61
EZ
20492011-08-02 Eli Zaretskii <eliz@gnu.org>
2050
2051 Fix slow cursor motion and scrolling in large buffers with
2052 selective display, like Org Mode buffers. (Bug#9218)
2053
2054 * dispextern.h (struct bidi_it): New member disp_prop_p.
2055
2056 * xdisp.c: Remove one-slot cache of display string positions.
2057 (compute_display_string_pos): Accept an additional argument
5e617bc2 2058 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2059 for a display string or property. If found, set DISP_PROP_P
2060 non-zero.
2061
2062 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2063 DISP_PROP_P, and pass it to compute_display_string_pos.
2064 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2065 non-zero. All callers of bidi_fetch_char changed.
2066
fb33fa43
SM
20672011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2068
2069 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2070
b099e063
DM
20712010-12-03 Don March <don@ohspite.net>
2072
2073 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2074 last character M-[char] is translated to ESC [char] (bug#7541).
2075
5cc7f7af
KH
20762011-08-02 Kenichi Handa <handa@m17n.org>
2077
d0fffa3f 2078 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2079
2080 * chartab.c (uniprop_table): Make it non-static.
2081
525d5e6e
EZ
20822011-08-01 Eli Zaretskii <eliz@gnu.org>
2083
2084 * xdisp.c (forward_to_next_line_start): Accept additional argument
2085 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2086 on the newline.
2087 (reseat_at_next_visible_line_start): Use the bidi iterator state
2088 returned by forward_to_next_line_start to restore the state of
2089 it->bidi_it after backing up to previous newline. (Bug#9212)
2090
31011111
AS
20912011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2092
2093 * regex.c (re_comp): Protoize.
2094 (re_exec): Fix return type.
2095 (regexec): Fix type of `ret'. (Bug#9203)
2096
476371c4
PE
20972011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2098
e5d76069
PE
2099 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2100 This is needed if max-image-size is a floating-point number.
2101
9a79b20c
AS
21022011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2103
2104 * print.c (print_object): Print empty symbol as ##.
2105
2106 * lread.c (read1): Read ## as empty symbol.
2107
d8c2fa78
AA
21082011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2109
2110 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2111 setting frame foreground color (Bug#9175).
2112 (x_set_background_color): Likewise.
2113
ffe57a7a
AA
2114 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2115 contents (Bug#9176).
2116 (EmacsTooltip -init): Remove bezels and add shadows to
2117 tooltip windows.
2118
bf3492a5
AA
2119 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2120 or scroll bar (Bug#8470).
2121
d55e9c53
AA
2122 * nsfont.m (nsfont_open): Remove assignment to voffset and
2123 unnecessary vars hshink, expand, hd, full_height, min_height.
2124 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2125
2126 * nsterm.h (nsfont_info): Remove voffset field.
2127
d8c2fa78 21282011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2129
2130 Implement strike-through and overline on NextStep (Bug#8863).
2131
2132 * nsfont.m (nsfont_open): Use underline position provided by font,
2133 instead of hard-coded value of 2.
2134 (nsfont_draw): Call ns_draw_text_decoration instead.
2135
2136 * nsterm.h: Add declaration for ns_draw_text_decoration.
2137
2138 * nsterm.m (ns_draw_text_decoration): New function for drawing
2139 underline, overline, and strike-through.
2140 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2141 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2142 accommodate underlining, etc.
4843aac3 2143
4cc60b9b
EZ
21442011-07-28 Eli Zaretskii <eliz@gnu.org>
2145
bc7ece87
EZ
2146 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2147 default.
4cc60b9b 2148
476371c4
PE
21492011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2150
66606eea
PE
2151 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2152 Without this fix, if a signal arrives just after memory fills up,
2153 'malloc' might be invoked reentrantly.
2154
476371c4
PE
2155 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2156 In other words, assume that every image size is allowed, on non-X
2157 hosts. This assumption is probably wrong, but it lets Emacs compile.
2158
f3fcc40d
AS
21592011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2160
2161 * regex.c (re_iswctype): Convert return values to boolean.
2162
350c992f
EZ
21632011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2164
2165 * xdisp.c (compute_display_string_pos): Don't use cached display
2166 string position if the buffer had its restriction changed.
2167 (Bug#9184)
2168
5266b4bb
PE
21692011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2170
2171 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2172
2573a837 21732011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2174
41f55ccd 2175 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2176
39e378da
PE
2177 * bidi.c: Integer size and overflow fixes.
2178 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2179 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2180 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2181 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2182 (bidi_find_other_level_edge):
2183 Use ptrdiff_t instead of EMACS_INT where either will do.
2184 This works better on 32-bit hosts configured --with-wide-int.
2185 (bidi_cache_ensure_space): Check for size-calculation overflow.
2186 Use % rather than repeated addition, for better worst-case speed.
2187 Don't set bidi_cache_size until after xrealloc returns, because it
2188 might not return.
2189 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2190 (bidi_cache_ensure_space): Also check that the bidi cache size
2191 does not exceed that of the largest Lisp string or buffer. See Eli
2192 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2193
5e927815
PE
2194 * alloc.c (__malloc_size_t): Remove.
2195 All uses replaced by size_t. See Andreas Schwab's note
2196 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2197
ca4aa935
PE
2198 * image.c: Improve checking for integer overflow.
2199 (check_image_size): Assume that f is nonnull, since
2200 it is always nonnull in practice. This is one less thing to
2201 worry about when checking for integer overflow later.
2202 (x_check_image_size): New function, which checks for integer
2203 overflow issues inside X.
2204 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2205 This removes the need for a memory_full check.
2206 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2207 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2208 (xbm_read_bitmap_data): Change locals back to 'int', since
2209 their values must fit in 'int'.
2210 (xpm_load_image, png_load, tiff_load):
2211 Invoke x_create_x_image_and_pixmap earlier,
2212 to avoid much needless work if the image is too large.
2213 (tiff_load): Treat overly large images as if
2214 x_create_x_image_and_pixmap failed, not as malloc failures.
2215 (gs_load): Use x_check_image_size.
2216
5f8f9cc2
PE
2217 * gtkutil.c: Omit integer casts.
2218 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2219 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2220
5adf60bc
PE
2221 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2222
c8907a93
PE
2223 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2224 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2225 would wrongly return t on a 64-bit host.
2226
e3c25c68
PE
2227 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2228 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2229 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2230 and therefore cause GCC to emit a bogus diagnostic in some cases.
2231
3f791afe
PE
2232 * image.c: Integer signedness and overflow and related fixes.
2233 This is not an exhaustive set of fixes, but it's time to
2234 record what I've got.
2235 (lookup_pixel_color, check_image_size): Remove redundant decls.
2236 (check_image_size): Don't assume that arbitrary EMACS_INT values
2237 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2238 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2239 (tiff_load, imagemagick_load_image):
2240 Check for overflow in size calculations.
2241 (x_create_x_image_and_pixmap): Remove unnecessary test for
2242 xmalloc returning NULL; that can't happen.
2243 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2244 (xpm_color_bucket): Use better integer hashing function.
2245 (xpm_cache_color): Don't possibly over-allocate memory.
2246 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2247 (gif_memory_source):
2248 Use ptrdiff_t, not int or size_t, to record sizes.
2249 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2250 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2251 either works, as we prefer signed integers.
2252 (tiff_read_from_memory, tiff_write_from_memory):
2253 Return tsize_t, not size_t, since that's what the TIFF API wants.
2254 (tiff_read_from_memory): Don't fail simply because the read would
2255 go past EOF; instead, return a short read.
2256 (tiff_load): Omit no-longer-needed casts.
2257 (Fimagemagick_types): Don't assume size fits into 'int'.
2258
3cc5a532
PE
2259 Improve hashing quality when configured --with-wide-int.
2260 * fns.c (hash_string): New function, taken from sxhash_string.
2261 Do not discard information about ASCII character case; this
2262 discarding is no longer needed.
2263 (sxhash-string): Use it. Change sig to match it. Caller changed.
2264 * lisp.h: Declare it.
2265 * lread.c (hash_string): Remove, since we now use fns.c's version.
2266 The fns.c version returns a wider integer if --with-wide-int is
2267 specified, so this should help the quality of the hashing a bit.
2268
b312a492
PE
2269 * emacs.c: Integer overflow minor fix.
2270 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2271 Define only if GNU_LINUX.
2272 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2273
dfd153ae
PE
2274 * dispnew.c: Integer signedness and overflow fixes.
2275 Remove unnecessary forward decls, that were a maintenance hassle.
2276 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2277 All uses changed.
2278 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2279 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2280 (prepare_desired_row, line_draw_cost):
2281 Use int, not unsigned, where either works.
2282 (save_current_matrix, restore_current_matrix):
2283 Use ptrdiff_t, not size_t, where either works.
2284 (init_display): Check for overflow more accurately, and without
2285 relying on undefined behavior.
2286
a81d11a3
PE
2287 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2288 Remove, replacing with the new symbols in lisp.h. All uses changed.
2289 * fileio.c (make_temp_name):
2290 * filelock.c (lock_file_1, lock_file):
2291 * xdisp.c (message_dolog):
2292 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2293 Use pMd etc. instead.
2294 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2295 replacing the pWIDE etc. symbols removed from editfns.c.
2296
3300e6fd
PE
2297 * keyboard.h (num_input_events): Now uintmax_t.
2298 This is (very slightly) less likely to mess up due to wraparound.
2299 All uses changed.
2300
fd05c7e9
PE
2301 * buffer.c: Integer signedness fixes.
2302 (alloc_buffer_text, enlarge_buffer_text):
2303 Use ptrdiff_t rather than size_t when either will do, as we prefer
2304 signed integers.
2305
903fe15d
PE
2306 * alloc.c: Integer signedness and overflow fixes.
2307 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2308 (__malloc_size_t): Default to size_t, not to int.
2309 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2310 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2311 Prefer ptrdiff_t to size_t when either would do, as we prefer
2312 signed integers.
2313 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2314 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2315 Now const. Initialize with values that are in range even if char
2316 is signed.
2317 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2318 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2319 These functions do the right thing with sizes > 2**32.
2320 (check_depth): Now ptrdiff_t, not int.
2321 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2322 Adjust to new way of storing sizes. Check for size overflow bugs
2323 in rest of code.
2324 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2325 slightly wrong anyway, as it missed one instance of
2326 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2327 (refill_memory_reserve): Omit needless cast to size_t.
2328 (mark_object_loop_halt): Mark as externally visible.
2329
ac82cc6a
PE
2330 * xselect.c: Integer signedness and overflow fixes.
2331 (Fx_register_dnd_atom, x_handle_dnd_message):
2332 Use ptrdiff_t, not size_t, since we prefer signed.
2333 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2334 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2335 x_dnd_atoms_size and x_dnd_atoms_length.
2336
c2d1e36d
PE
2337 * doprnt.c: Prefer signed to unsigned when either works.
2338 * eval.c (verror):
2339 * doprnt.c (doprnt):
2340 * lisp.h (doprnt):
2341 * xdisp.c (vmessage):
2342 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2343 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2344 prefer signed arithmetic to avoid comparison confusion.
2345 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2346 but is a bit tricky.
2347
0e926e56
PE
2348 Assume freestanding C89 headers, string.h, stdlib.h.
2349 * data.c, doprnt.c, floatfns.c, print.c:
2350 Include float.h unconditionally.
2351 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2352 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2353 * regex.c: Likewise for stddef.h, string.h.
2354 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2355 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2356 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2357 (STDC_HEADERS): Remove obsolete defines.
2358 * sysdep.c: Include limits.h unconditionally.
2359
9cfdb3ec
PE
2360 Assume support for memcmp, memcpy, memmove, memset.
2361 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2362 * regex.c (memcmp, memcpy):
2363 Remove; we assume C89 now.
2364
2365 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2366 (__malloc_safe_bcopy): Remove; no longer needed.
2367
cf950e6b 2368 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2369 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2370 well either way, and we prefer signed to unsigned.
2371
dbf38e02
LMI
23722011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2373
2374 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2375 closes the connection while we're reading (bug#9182).
2376
d6f0886c 23772011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2378
d6f0886c
JD
2379 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2380 are specified (Bug#9168).
24e0f6b1 2381
2eb1f9e6
PE
23822011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2383
2384 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2385 Found by GCC static checking and --with-wide-int on a 32-bit host.
2386
22381272 23872011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2388
2389 * xdisp.c (compute_display_string_pos): Fix logic of caching
2390 previous display string position. Initialize cached_prev_pos to
2391 -1. Fixes slow-down at the beginning of a buffer.
2392
f25e39b4
EZ
23932011-07-24 Eli Zaretskii <eliz@gnu.org>
2394
2395 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2396 for attrs[LFACE_FONTSET_INDEX].
2397
04c4b52e
PE
23982011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2399
2400 * xml.c (parse_region): Remove unused local
2401 that was recently introduced.
2402
c1734fbd
EZ
24032011-07-23 Eli Zaretskii <eliz@gnu.org>
2404
be18c5a5
EZ
2405 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2406 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2407
c1734fbd
EZ
2408 * xdisp.c (move_it_in_display_line_to): Record the best matching
2409 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2410 exit if none of the characters scanned was an exact match.
2411 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2412 when exact match is impossible due to invisible text, and the
2413 lines are truncated.
2414
a258d627
JD
24152011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2416
2417 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2418 for OSX >= 10.7.
2419
b6d5a689
EZ
24202011-07-22 Eli Zaretskii <eliz@gnu.org>
2421
0f74f785
EZ
2422 Fix a significant slow-down of cursor motion with C-n, C-p,
2423 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2424 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2425 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2426 (next_element_from_buffer): Call compute_stop_pos_backwards to
2427 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2428 base_level_stop.
2429 (reseat): Don't look for prev_stop, as that could mean a very long
2430 run.
2431 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2432 <cached_disp_overlay_modiff>: Cache for last found display string
2433 position.
551918c1 2434 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2435 about the same buffer in the same area of character positions, and
2436 the buffer wasn't changed since the time the display string
2437 position was cached.
551918c1 2438
b2d0c91a
EZ
24392011-07-22 Eli Zaretskii <eliz@gnu.org>
2440
2441 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2442 is an integer, which is important for empty lines. (Bug#9149)
2443
043604ee
CY
24442011-07-22 Chong Yidong <cyd@stupidchicken.com>
2445
2446 * frame.c (Fmodify_frame_parameters): In tty case, update the
2447 default face if necessary (Bug#4238).
2448
da4adb04
CY
24492011-07-21 Chong Yidong <cyd@stupidchicken.com>
2450
2451 * editfns.c (Fstring_to_char): No need to explain what a character
2452 is in the docstring (Bug#6576).
2453
9abd0532
LMI
24542011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2455
2456 * xml.c (parse_region): Make sure we always return a tree.
2457
36881d16
HK
24582011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2459
2460 * xml.c (parse_region): If a document contains only comments,
2461 return that, too.
2462
1e98674d
LMI
24632011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2464
2465 * xml.c (make_dom): Return comments, too.
2466
590bd467
PE
24672011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2468
2469 Port to OpenBSD.
2470 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2471 and the surrounding thread.
2472 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2473 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2474 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2475 timer goes off.
2476 * s/openbsd.h (BROKEN_SIGIO): Define.
2477 * unexelf.c (unexec) [__OpenBSD__]:
2478 Don't update the .mdebug section of the Alpha COFF symbol table.
2479
f41628b2
LMI
24802011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2481
2482 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2483 (bug#8460).
2484
b59b67c5
PE
24852011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2486
15e3a074
PE
2487 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2488 This fixes some race conditions on the permissions of any newly
2489 created file.
2490
41bed37d
PE
2491 * alloc.c (valid_pointer_p): Use pipe, not open.
2492 This fixes some permissions issues when debugging.
2493
b59b67c5
PE
2494 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2495 If fchown fails to set both uid and gid, try to set just gid,
2496 as that is sometimes allowed. Adjust the file's mode to eliminate
2497 setuid or setgid bits that are inappropriate if fchown fails.
2498
925a6be7
SM
24992011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2500
2501 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2502 to compare Lisp_Objects.
2503 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2504 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2505 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2506
52968808
AS
25072011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2508
0a6a104b
AS
2509 * lread.c (read_integer): Unread even EOF character.
2510 (read1): Likewise. Properly record start position of symbol.
2511
52968808
AS
2512 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2513 symbol character follows.
2514
9e381cdd
PE
25152011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2516
2517 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2518 This works around a problem with the previous change to Fcopy_file.
2519 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2520 and without this change, GCC might complain about discarding
2521 fchown's return value.
2522
b5641435
JB
25232011-07-16 Juanma Barranquero <lekktu@gmail.com>
2524
2525 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2526
a8031457
PE
25272011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2528
2529 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2530
dd889327
LMI
25312011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2532
750c33f7
LMI
2533 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2534 it's used from the C level.
2535
dd889327
LMI
2536 * process.c: Use the same condition for POLL_FOR_INPUT in both
2537 keyboard.c and process.c (bug#1858).
2538
87e86684
LM
25392011-07-09 Lawrence Mitchell <wence@gmx.li>
2540
2541 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2542 (Fgnutls_boot): Use it.
2543
64348f40
AS
25442011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2545
2546 * doc.c (Fsubstitute_command_keys): Revert last change.
2547
1d698799
LMI
25482011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2549
f863868c
LMI
2550 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2551 quotes the next character, and doesn't affect other longer
2552 sequences (bug#8935).
2553
1d698799
LMI
2554 * lread.c (syms_of_lread): Clarify that is isn't only
2555 `eval-buffer' and `eval-defun' that's affected by
2556 `lexical-binding' (bug#8460).
2557
aa4b6df6
EZ
25582011-07-15 Eli Zaretskii <eliz@gnu.org>
2559
2560 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2561 bidi redisplay when a line includes both an image and is
2562 truncated.
2563
5d856da6
PE
25642011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2565
ad6042bb
PE
2566 Fix minor problems found by static checking.
2567 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2568 (elsz): Now a signed constant, not a size_t var. We prefer signed
2569 types to unsigned, to avoid integer comparison confusion. Without
2570 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2571 "cannot optimize loop, the loop counter may overflow", a symptom
2572 of the confusion.
f00bbb22 2573 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2574 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2575
6468f31c
LMI
25762011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2577
49080b10
LMI
2578 * search.c (Fre_search_backward): Mention `case-fold-search' in
2579 all the re_search_* functions (bug#8138).
2580
6468f31c
LMI
2581 * keyboard.c (Fopen_dribble_file): Document when the file is
2582 closed (bug#8056).
2583
c965adc5
EZ
25842011-07-14 Eli Zaretskii <eliz@gnu.org>
2585
df9733bf
EZ
2586 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2587 bidi_cache_idx.
2588
0bb23927
EZ
2589 Support bidi reordering of display and overlay strings.
2590 * xdisp.c (compute_display_string_pos)
2591 (compute_display_string_end): Accept additional argument STRING.
2592 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2593 (reseat_to_string): Initialize bidi_it->string.s and
2594 bidi_it->string.schars.
2595 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2596 NULL (avoids a crash in bidi_paragraph_init).
2597 Initialize itb.string.lstring.
0bb23927
EZ
2598 (init_iterator): Call bidi_init_it only of a valid
2599 buffer position was specified. Initialize paragraph_embedding to
2600 L2R.
2601 (reseat_to_string): Initialize the bidi iterator.
2602 (display_string): If we need to ignore text properties of
2603 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2604 original value of -1 will not work with bidi.)
2605 (compute_display_string_pos): First arg is now struct
2606 `text_pos *'; all callers changed. Support display properties on
2607 Lisp strings.
2608 (compute_display_string_end): Support display properties on Lisp
2609 strings.
2610 (init_iterator, reseat_1, reseat_to_string): Initialize the
2611 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2612 when iterating on a string not from display properties).
640c8776
SM
2613 (compute_display_string_pos, compute_display_string_end):
2614 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2615 arrow keys.
2616 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2617 base_level_stop; instead, set base_level_stop to BEGV.
2618 Fixes crashes in vertical-motion.
0bb23927
EZ
2619 (next_element_from_buffer): Improve commentary for when
2620 the iterator is before prev_stop.
2621 (init_iterator): Initialize bidi_p from the default value of
2622 bidi-display-reordering, not from buffer-local value. Use the
2623 buffer-local value only if initializing for buffer iteration.
2624 (handle_invisible_prop): Support invisible properties on strings
2625 that are being bidi-reordered.
2626 (set_iterator_to_next): Support bidi reordering of C strings and
2627 Lisp strings.
2628 (next_element_from_string): Support bidi reordering of Lisp
2629 strings.
2630 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2631 (display_string): Support display of R2L glyph rows.
2632 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2633 (init_iterator): Don't initialize it->bidi_p for strings
2634 here.
2635 (reseat_to_string): Initialize it->bidi_p for strings here.
2636 (next_element_from_string, next_element_from_c_string)
2637 (next_element_from_buffer): Add xassert's for correspondence
2638 between IT's object being iterated and it->bidi_it.string
2639 structure.
2640 (face_before_or_after_it_pos): Support bidi iteration.
2641 (next_element_from_c_string): Handle the case of the first string
2642 character that is not the first one in the visual order.
2643 (get_visually_first_element): New function, refactored from common
2644 parts of next_element_from_buffer, next_element_from_string, and
2645 next_element_from_c_string.
2646 (tool_bar_lines_needed, redisplay_tool_bar)
2647 (display_menu_bar): Force left-to-right direction. Add a FIXME
2648 comment for making that be controlled by a user option.
2649 (push_it, pop_it): Save and restore the state of the
2650 bidi iterator. Save and restore the bidi_p flag.
2651 (pop_it): Iterate out of display property for string iteration as
2652 well.
2653 (iterate_out_of_display_property): Support iteration over strings.
2654 (handle_single_display_spec): Set up it->bidi_it for iteration
2655 over a display string, and call bidi_init_it.
2656 (handle_single_display_spec, next_overlay_string)
2657 (get_overlay_strings_1, push_display_prop): Set up the bidi
2658 iterator for displaying display or overlay strings.
2659 (forward_to_next_line_start): Don't use the shortcut if
2660 bidi-iterating.
2661 (back_to_previous_visible_line_start): If handle_display_prop
2662 pushed the iterator stack, restore the internal state of the bidi
2663 iterator by calling bidi_pop_it same number of times.
2664 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2665 and we are bidi-iterating, don't decrement the iterator position;
2666 instead, set the first_elt flag in the bidi iterator, to produce
2667 the same effect.
2668 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2669 (push_display_prop): xassert that we are iterating a buffer.
2670 (push_it, pop_it): Save and restore paragraph_embedding member.
2671 (handle_single_display_spec, next_overlay_string)
2672 (get_overlay_strings_1, reseat_1, reseat_to_string)
2673 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2674 correctly. Don't assume unibyte strings are not bidi-reordered.
2675 (compute_display_string_pos)
2676 (compute_display_string_end): Fix handling the case of C string.
2677 (push_it, pop_it): Save and restore from_disp_prop_p.
2678 (handle_single_display_spec, push_display_prop): Set the
2679 from_disp_prop_p flag.
2680 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2681 (pop_it): Call iterate_out_of_display_property only if we are
2682 popping after iteration over a string that came from a display
2683 property. Fix a typo in popping stretch info. Add an assertion
2684 for verifying that the iterator position is in sync with the bidi
2685 iterator.
2686 (handle_single_display_spec, get_overlay_strings_1)
2687 (push_display_prop): Fix initialization of paragraph direction for
2688 string when that of the parent object is not yet determined.
2689 (reseat_1): Call bidi_init_it to resync the bidi
2690 iterator with IT's position. (Bug#7616)
2691 (find_row_edges): If ROW->start.pos gives position
2692 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2693 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2694 Reset the from_disp_prop_p flag.
2695 (SAVE_IT, RESTORE_IT): New macros.
2696 (pos_visible_p, face_before_or_after_it_pos)
2697 (back_to_previous_visible_line_start)
2698 (move_it_in_display_line_to, move_it_in_display_line)
2699 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2700 (try_scrolling, redisplay_window, display_line): Use them when
2701 saving a temporary copy of the iterator and restoring it back.
2702 (back_to_previous_visible_line_start, reseat_1)
2703 (init_iterator): Empty the bidi cache "stack".
2704 (move_it_in_display_line_to): If iterator ended up at
2705 EOL, but we never saw any buffer positions smaller than
2706 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2707 motion in bidi-reordered lines.
2708 (move_it_in_display_line_to): Record prev_method and prev_pos
2709 immediately before the call to set_iterator_to_next. Fixes cursor
2710 motion in bidi-reordered lines with stretch glyphs and strings
2711 displayed in margins. (Bug#8133) (Bug#8867)
2712 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2713 TO_CHARPOS.
640c8776
SM
2714 (pos_visible_p): Support positions in bidi-reordered lines.
2715 Save and restore bidi cache.
0bb23927
EZ
2716
2717 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2718 (bidi_paragraph_info): Delete unused struct.
2719 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2720 (bidi_cache_start): New variable.
2721 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2722 to zero.
2723 (bidi_cache_fetch_state, bidi_cache_search)
2724 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2725 (bidi_cache_find, bidi_peek_at_next_level)
2726 (bidi_level_of_next_char, bidi_find_other_level_edge)
2727 (bidi_move_to_visually_next): Compare cache index with
2728 bidi_cache_start rather than with zero.
2729 (bidi_fetch_char): Accept new argument STRING; all callers
2730 changed. Support iteration over a string. Support strings with
2731 display properties. Support unibyte strings. Fix the type of
2732 `len' according to what STRING_CHAR_AND_LENGTH expects.
2733 (bidi_paragraph_init, bidi_resolve_explicit_1)
2734 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2735 (bidi_level_of_next_char, bidi_move_to_visually_next):
2736 Support iteration over a string.
0bb23927
EZ
2737 (bidi_set_sor_type, bidi_resolve_explicit_1)
2738 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2739 can now be zero (for strings); special values 0 and -1 were
2740 changed to -1 and -2, respectively.
2741 (bidi_char_at_pos): New function.
2742 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2743 Call it instead of FETCH_MULTIBYTE_CHAR.
2744 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2745 initialized to valid values.
2746 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2747 values.
2748 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2749 the test for valid cached positions. Fix the logic for looking up
2750 the sentinel state in the cache. GCPRO the Lisp string we are
2751 iterating.
2752 (bidi_push_it, bidi_pop_it): New functions.
2753 (bidi_initialize): Initialize the bidi cache start stack pointer.
2754 (bidi_cache_ensure_space): New function, refactored from part of
2755 bidi_cache_iterator_state. Don't assume the required size is just
2756 one BIDI_CACHE_CHUNK away.
2757 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2758 (bidi_count_bytes, bidi_char_at_pos): New functions.
2759 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2760 always valid if bidi_cache_idx is valid.
2761 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2762 is valid if it's going to be used.
2763 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2764 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2765 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2766 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2767 (bidi_find_other_level_edge, bidi_cache_start_stack):
2768 All variables related to cache indices are now EMACS_INT.
c965adc5 2769
0bb23927
EZ
2770 * dispextern.h (struct bidi_string_data): New structure.
2771 (struct bidi_it): New member `string'. Make flag members be 1-bit
2772 fields, and put them last in the struct.
640c8776
SM
2773 (compute_display_string_pos, compute_display_string_end):
2774 Update prototypes.
0bb23927
EZ
2775 (bidi_push_it, bidi_pop_it): Add prototypes.
2776 (struct iterator_stack_entry): New members bidi_p,
2777 paragraph_embedding, and from_disp_prop_p.
2778 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2779 (bidi_shelve_cache, bidi_unshelve_cache):
2780 Declare prototypes.
0bb23927
EZ
2781
2782 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2783 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2784 and vector-like objects.
2785
2786 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2787 cache around display iteration.
2788
2789 * window.c (Fwindow_end, window_scroll_pixel_based)
2790 (displayed_window_lines, Frecenter): Save and restore the bidi
2791 cache around display iteration.
2792
3bbd2265
LMI
27932011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2794
2795 * editfns.c (Fdelete_region): Clarify the use of the named
2796 parameters (bug#6788).
2797
adc47434
MR
27982011-07-14 Martin Rudalics <rudalics@gmx.at>
2799
2800 * indent.c (Fvertical_motion): Set and restore w->pointm when
2801 saving and restoring the window's buffer (Bug#9006).
2802
837c31f8
LMI
28032011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2804
2805 * editfns.c (Fstring_to_char): Clarify just what is returned
2806 (bug#6576). Text by Eli Zaretskii.
2807
ac389d0c
JB
28082011-07-13 Juanma Barranquero <lekktu@gmail.com>
2809
2810 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2811
0be0ce47
EZ
28122011-07-13 Eli Zaretskii <eliz@gnu.org>
2813
2814 * buffer.c (mmap_find): Fix a typo.
2815
cd18e7e3
JB
28162011-07-13 Johan Bockgård <bojohan@gnu.org>
2817
2818 Fix execution of x selection hooks.
2819 * xselect.c (Qx_lost_selection_functions)
2820 (Qx_sent_selection_functions): New vars.
2821 (syms_of_xselect): DEFSYM them.
2822 (x_handle_selection_request): Pass Qx_sent_selection_functions
2823 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2824 (x_handle_selection_clear,x_clear_frame_selections):
2825 Pass Qx_lost_selection_functions rather than
2826 Vx_lost_selection_functions to Frun_hook_with_args.
2827
47ea7f44
PE
28282011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2829
ac389d0c 2830 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2831 The old code sometimes used this field without initializing it.
2832
47ea7f44
PE
2833 * alloc.c (gc_sweep): Don't read past end of array.
2834 In theory, the old code could also have corrupted Emacs internals,
2835 though it'd be very unlikely.
2836
bc985c87
AS
28372011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2838
2839 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2840 argument. (Bug#4026)
bc985c87 2841
0cf34688
LMI
28422011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2843
b3dadd76
LMI
2844 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2845 key" (bug#4257).
2846
0cf34688
LMI
2847 * window.c (Fset_window_start): Doc fix (bug#4199).
2848 (Fset_window_hscroll): Ditto.
2849
270768cd
PE
28502011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2851
077e3dda 2852 Fix minor new problems caught by GCC 4.6.1.
270768cd 2853 * term.c (init_tty): Remove unused local.
490011a6 2854 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2855 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2856 not used otherwise.
270768cd 2857
b1f58454
CY
28582011-07-12 Chong Yidong <cyd@stupidchicken.com>
2859
2860 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2861
22b9578d
LMI
28622011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2863
6e70ab07
LMI
2864 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2865 are the mini-buffer and the echo area (bug#3320).
2866
22b9578d
LMI
2867 * term.c (init_tty): Remove support for supdup, c10 and perq
2868 terminals, which are no longer supported (bug#1482).
2869
8974cc9f
JB
28702011-07-10 Johan Bockgård <bojohan@gnu.org>
2871
2872 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2873
a560d974
JD
28742011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2875
2876 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2877 for non-popups (Bug#3642).
2878
1dae0f0a
AS
28792011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2880
268c2c36 2881 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2882 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2883 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2884 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2885 * data.c (fmod): Likewise.
2886 * dispnew.c (swap_glyphs_in_rows): Likewise.
2887 * emacs.c (memory_warning_signal): Likewise.
2888 * floatfns.c (float_error): Likewise.
2889 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2890 (otf_open, font_otf_capability, generate_otf_features)
2891 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2892 Likewise.
2893 * image.c (pbm_read_file): Likewise.
2894 * indent.c (string_display_width): Likewise.
2895 * intervals.c (check_for_interval, search_for_interval)
2896 (inc_interval_count, count_intervals, root_interval)
2897 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2898 * lread.c (defalias): Likewise.
268c2c36 2899 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2900 * regex.c (set_image_of_range_1, set_image_of_range)
2901 (regex_grow_registers): Likewise.
2902 * sysdep.c (strerror): Likewise.
2903 * termcap.c (valid_filename_p, tprint, main): Likewise.
2904 * tparam.c (main): Likewise.
2905 * unexhp9k800.c (run_time_remap, save_data_space)
2906 (update_file_ptrs, read_header, write_header, calculate_checksum)
2907 (copy_file, copy_rest, display_header): Likewise.
2908 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2909 Likewise.
2910 * xdisp.c (check_it): Likewise.
2911 * xfaces.c (register_color, unregister_color, unregister_colors):
2912 Likewise.
2913 * xfns.c (print_fontset_result): Likewise.
2914 * xrdb.c (member, fatal, main): Likewise.
2915
99033785
PE
29162011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2917
2918 Fix minor problems found by static checking (Bug#9031).
2919 * chartab.c (char_table_set_range, map_sub_char_table):
2920 Remove unused locals.
2921 (uniprop_table): Now static.
2922 * composite.c (_work_char): Remove unused static var.
2923
9cb2ac56
JB
29242011-07-09 Juanma Barranquero <lekktu@gmail.com>
2925
2926 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2927
f25661f0
JD
29282011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2929
2930 * gtkutil.c (qttip_cb): Remove code without function.
2931
8278c4fe
EZ
29322011-07-09 Eli Zaretskii <eliz@gnu.org>
2933
2934 * w32.c (pthread_sigmask): New stub.
2935
1692ae2d 29362011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2937
8a6ebd58 2938 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2939 sigprocmask is portable only for single-threaded applications, and
2940 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2941 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2942 (LIBES): Use it.
2943 * callproc.c (Fcall_process):
2944 * process.c (create_process):
2945 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2946 Use pthread_sigmask, not sigprocmask.
123403e4 2947
1b854618
JD
29482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2949
2950 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2951 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2952 wrong (Bug#8591).
2953
3fe4b549
JD
29542011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2955
0ce7e563
JD
2956 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2957 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2958 (xg_hide_tooltip): Fix comment.
2959
3fe4b549
JD
2960 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2961 in registerServicesMenuSendTypes.
2962 (validRequestorForSendType): Don't check ns_return_types.
2963
2964 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2965 ns_return_type.
2966
5df75e47
JR
29672011-07-08 Jason Rumney <jasonr@gnu.org>
2968
2969 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2970 frame struct members of non-existent frames (Bug#6284).
2971
699c10bd
JD
29722011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2973
4393663b
JD
2974 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2975 variable firstTime not needed on OSX >= 10.6.
2976 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2977 >= 10.5. Use setKnobProportion, setDoubleValue.
2978
2979 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2980 (MAC_OS_X_VERSION_10_5): Define if not defined.
2981 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2982 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2983 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2984
2985 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2986 cString and lossyCString on OSX >= 10.4
2987
2988 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2989 sizeToFit on OSX >= 10.2.
2990
2991 * nsimage.m (allocInitFromFile): Don't use deprecated method
2992 bestRepresentationForDevice on OSX >= 10.6.
2993
2994 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2995 to avoid warning.
2996
2997 * emacs.c: Declare unexec_init_emacs_zone.
2998
a63e0781
JD
2999 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3000
699c10bd
JD
3001 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3002
3003 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3004 on svcsMenu (Bug#8842).
3005
3006 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3007 ns_return_types.
3008 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3009
3010 * nsterm.m (QUTF8_STRING): Declare.
3011 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3012 (validRequestorForSendType): Return type is (id).
3013 Change indexOfObjectIdenticalTo to indexOfObject.
3014 Check if we have local selection before returning self (Bug#8842).
3015 (writeSelectionToPasteboard): Put local selection into paste board
3016 if we have a local selection (Bug#8842).
3017 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3018
3019 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3020 (ns_get_local_selection): Declare.
3021
54e10184
LMI
30222011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3023
9888ff71
LMI
3024 * keymap.c (describe_map_tree): Don't insert a double newline at
3025 the end of the buffer (bug#1169) and return whether we inserted
3026 something.
3027
54e10184
LMI
3028 * callint.c (Fcall_interactively): Change "reading args" to
3029 "providing args" to try to clarify what it does (bug#1010).
3030
15fa4783
KH
30312011-07-07 Kenichi Handa <handa@m17n.org>
3032
3033 * composite.c (composition_compute_stop_pos): Ignore a static
3034 composition starting before CHARPOS (Bug#8915).
3035
3036 * xdisp.c (handle_composition_prop): Likewise.
3037
a8815b00
EZ
30382011-07-07 Eli Zaretskii <eliz@gnu.org>
3039
3040 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3041 (Bug#9015)
3042
ef7b981d 30432011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3044
3045 * character.h (unicode_category_t): New enum type.
3046
3047 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3048 (Qchar_code_property_table): New variable.
3049 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3050 (UNIPROP_COMPRESSED_FORM_P): New macros.
3051 (char_table_ascii): Uncompress the compressed values.
3052 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3053 Uncompress the compressed values.
ac389d0c 3054 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3055 (char_table_ref_and_range): Uncompress the compressed values.
3056 (sub_char_table_set): New arg is_uniprop. Callers changed.
3057 Uncompress the compressed values.
3058 (sub_char_table_set_range): Args changed. Callers changed.
3059 (char_table_set_range): Adjuted for the above change.
3060 (map_sub_char_table): Delete args default_val and parent. Add arg
3061 top. Give decoded values to a Lisp function.
640c8776 3062 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3063 values to a Lisp function. Gcpro more variables.
3064 (uniprop_table_uncompress)
3065 (uniprop_decode_value_run_length): New functions.
3066 (uniprop_decoder, uniprop_decoder_count): New variables.
3067 (uniprop_get_decoder, uniprop_encode_value_character)
3068 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3069 New functions.
3070 (uniprop_encoder, uniprop_encoder_count): New variables.
3071 (uniprop_get_encoder, uniprop_table)
3072 (Funicode_property_table_internal, Fget_unicode_property_internal)
3073 (Fput_unicode_property_internal): New functions.
3074 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3075 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3076 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3077 char-code-property-alist.
3078
640c8776 3079 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3080 Vunicode_category_table.
3081
640c8776 3082 * font.c (font_range): Adjust for the change of
c805dec0
KH
3083 Vunicode_category_table.
3084
76b397fb
DN
30852011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3086
3087 * m/iris4d.h: Remove file, move contents ...
3088 * s/irix6-5.h: ... here.
3089
22b4128e
PE
30902011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3091
3092 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3093 * alloc.c (mark_buffer):
3094 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3095 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3096 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3097 This isn't true in general, and it's particularly not true
3098 if Emacs is configured with --with-wide-int.
3099 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3100 New macros, used in the buffer.c change.
3101
869795d6
JD
31022011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3103
3104 * xsettings.c: Use both GConf and GSettings if both are available.
3105 (store_config_changed_event): Add comment.
3106 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3107 (store_tool_bar_style_changed): New functions.
5e617bc2 3108 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3109 (struct xsettings): Move font inside HAVE_XFT.
3110 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3111 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3112 Move inside HAVE_XFT.
640c8776 3113 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3114 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3115 also.
3116 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3117 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3118 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3119 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3120 (parse_settings): Move check for font inside HAVE_XFT.
3121 (read_settings, apply_xft_settings): Add comment.
3122 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3123 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3124 call store_font_name_changed.
3125 (xft_settings_event): Add comment.
3126 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3127 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3128 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3129 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3130 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3131 (xsettings_get_system_font, xsettings_get_system_normal_font):
3132 Add comment.
869795d6 3133
d8ed26bd
PE
31342011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3135
3136 Random fixes. E.g., (random) never returned negative values.
3137 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3138 subseconds part to the entropy, as that's a bit more random.
3139 Prefer signed to unsigned, since the signedness doesn't matter and
3140 in general we prefer signed. When given a limit, use a
3141 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3142 latter isn't right if USE_2_TAGS_FOR_INTS.
3143 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3144 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3145
cabf1cac
SM
31462011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3147
3148 * textprop.c (text_property_stickiness):
3149 Obey Vtext_property_default_nonsticky.
3150 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3151 * w32fns.c (syms_of_w32fns):
3152 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3153
6e9b2be9
PE
31542011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3155
3156 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3157 This is more efficient than Ffile_directory_p and avoids a minor race.
3158
90186c68
LMI
31592011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3160
7c301272
LMI
3161 * buffer.c (Foverlay_put): Say what the return value is
3162 (bug#7835).
3163
c4f2d8d4
LMI
3164 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3165 is a directory before asking whether to use the file name
3166 (bug#7564).
ad637907
LMI
3167 (barf_or_query_if_file_exists): Make the "File is a directory"
3168 error be more correct.
c4f2d8d4 3169
90186c68
LMI
3170 * fns.c (Frequire): Remove the mention of the .gz files, since
3171 that's installation-specific, but keep the mention of
3172 `get-load-suffixes'.
3173
da64016e
PE
31742011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3175
3176 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3177 Report string overflow if the output is too long.
3178
7d47b580
JB
31792011-07-04 Juanma Barranquero <lekktu@gmail.com>
3180
a555cb87
JB
3181 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3182 (syms_of_gnutls): Remove duplicate DEFSYM for
3183 Qgnutls_bootprop_verify_hostname_error, an error for
3184 Qgnutls_bootprop_verify_error (which is no longer used).
3185
7d47b580
JB
3186 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3187 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3188 Also (re)move comments that are misplaced or no longer relevant.
3189
1e49bfab
LMI
31902011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3191
3192 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3193
1485f4c0
CY
31942011-07-03 Chong Yidong <cyd@stupidchicken.com>
3195
3196 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3197 and background color parameters if they have been changed.
3198
a9ab721e
LMI
31992011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3200
3201 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3202
cf7cff57
PE
32032011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3204
2e13213d
PE
3205 * xsettings.c (SYSTEM_FONT): Define only when used.
3206 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3207
cf7cff57
PE
3208 * keymap.c (access_keymap_1): Now static.
3209
7a8e04f7
CY
32102011-07-02 Chong Yidong <cyd@stupidchicken.com>
3211
3212 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3213 leave any prefix arg for the up event (Bug#1586).
3214
61352f62
LMI
32152011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3216
69bb1ef7
LMI
3217 * lread.c (syms_of_lread): Mention single symbols defined by
3218 `defvar' or `defconst' (bug#7154).
3219
61352f62 3220 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3221 (Frequire): Mention get-load-suffixes.
61352f62 3222
28545e04
MR
32232011-07-02 Martin Rudalics <rudalics@gmx.at>
3224
3225 * window.h (window): Remove clone_number slot.
3226 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3227 Remove.
3228 (make_parent_window, make_window, saved_window)
3229 (Fset_window_configuration, save_window_save): Don't deal with
3230 clone numbers.
3231 * buffer.c (Qclone_number): Remove declaration.
3232 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3233
3349e122
SM
32342011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3235
3236 Add multiple inheritance to keymaps.
3237 * keymap.c (Fmake_composed_keymap): New function.
3238 (Fset_keymap_parent): Simplify.
3239 (fix_submap_inheritance): Remove.
3240 (access_keymap_1): New function extracted from access_keymap to handle
3241 embedded parents and handle lists of maps.
3242 (access_keymap): Use it.
3243 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3244 (Fcopy_keymap): Handle embedded parents.
3245 (Fcommand_remapping, define_as_prefix): Simplify.
3246 (Fkey_binding): Simplify.
3247 (syms_of_keymap): Move minibuffer-local-completion-map,
3248 minibuffer-local-filename-completion-map,
3249 minibuffer-local-must-match-map, and
3250 minibuffer-local-filename-must-match-map to Elisp.
3251 (syms_of_keymap): Defsubr make-composed-keymap.
3252 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3253 (parse_menu_item): Trivial simplification.
3254
3279eb87
GM
32552011-07-01 Glenn Morris <rgm@gnu.org>
3256
3257 * Makefile.in (SETTINGS_LIBS): Fix typo.
3258
4550efdf
KI
32592011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3260
3261 * coding.c (Fencode_coding_string): Record the last coding system
3262 used, as the function doc string says (bug#8738).
3263
0949d2b6
JD
32642011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3265
3266 * xsettings.c (store_monospaced_changed): Take new font as arg and
3267 check for change against current_mono_font.
3268 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3269 (emacs_settings_constructor, emacs_settings_get_property)
3270 (emacs_settings_set_property, emacs_settings_class_init)
3271 (emacs_settings_init, gsettings_obj): Remove.
3272 (something_changedCB): New function for HAVE_GSETTINGS.
3273 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3274 with value as argument.
3275 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3276 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3277 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3278 "changed".
3279
3280 * xgselect.c: Add defined (HAVE_GSETTINGS).
3281 (xgselect_initialize): Ditto.
3282
3283 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3284 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3285 xg_select.
3286
bbc6b304
PE
32872011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3288
3289 * eval.c (struct backtrace): Simplify and port the data structure.
3290 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3291 signed bit field, as this assumption is not portable and it makes
3292 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3293 "char debug_on_exit : 1" as this is not portable either; instead,
3294 use the portable "unsigned int debug_on_exit : 1". Remove unused
3295 member evalargs. Remove obsolete comments about cc bombing out.
3296
9851bfc5
JD
32972011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3298
51bb811f 3299 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3300 Let HAVE_GSETTINGS override HAVE_GCONF.
3301 (store_monospaced_changed): New function.
3302 (EMACS_SETTINGS): A new type derived from GObject to handle
3303 GSettings notifications.
3304 (emacs_settings_constructor, emacs_settings_get_property)
3305 (emacs_settings_set_property, emacs_settings_class_init):
3306 New functions.
3307 (gsettings_client, gsettings_obj): New variables.
3308 (GSETTINGS_SCHEMA): New define.
3309 (something_changedCB): Call store_monospaced_changed.
3310 (init_gsettings): New function.
3311 (xsettings_initialize): Call init_gsettings.
3312 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3313 to NULL.
3314
640c8776 3315 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3316 GCONF_CFLAGS/LIBS.
3317
5386012d
MR
33182011-06-29 Martin Rudalics <rudalics@gmx.at>
3319
3320 * window.c (resize_root_window, grow_mini_window)
3321 (shrink_mini_window): Rename Qresize_root_window to
3322 Qwindow_resize_root_window and Qresize_root_window_vertically to
3323 Qwindow_resize_root_window_vertically.
3324
f13e0b08
PE
33252011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3326
3327 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3328
94515237
JB
33292011-06-27 Juanma Barranquero <lekktu@gmail.com>
3330
3331 * makefile.w32-in: Redesign dependencies so they reflect more
3332 clearly which files are directly included by each source file,
3333 and not through other includes.
3334
e43b6e43
MR
33352011-06-27 Martin Rudalics <rudalics@gmx.at>
3336
3337 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3338 (sort_overlays, overlay_strings): When an overlay's clone number
3339 matches the window's clone number process the overlay even if
3340 the overlay's window property doesn't match the current window.
3341
d68443dc
MR
3342 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3343 (Fwindow_hchild): Rename to Fwindow_left_child.
3344 (Fwindow_next): Rename to Fwindow_next_sibling.
3345 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3346 (resize_window_check): Rename to window_resize_check.
3347 (resize_window_apply): Rename to window_resize_apply.
3348 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3349 (Fdelete_other_windows_internal, resize_frame_windows)
3350 (Fsplit_window_internal, Fdelete_window_internal)
3351 (grow_mini_window, shrink_mini_window)
3352 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3353
c7e73be5
JD
33542011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3355
3356 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3357 (emacs_fixed_set_min_size): Remove.
3358 (emacs_fixed_new): Take frame as argument.
3359
3360 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3361 (_EmacsFixedPrivate): Remove minwidth/height.
3362 Add struct frame *f.
3363 (emacs_fixed_init): Initialize priv->f.
3364 (get_parent_class, emacs_fixed_set_min_size): Remove.
3365 (emacs_fixed_new): Set priv->f to argument.
3366 (emacs_fixed_get_preferred_width)
3367 (emacs_fixed_get_preferred_height): Use min_width/height from
3368 frames size_hint to set minimum and natural (Bug#8919).
3369 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3370 and use min_width/height from frames size_hint to set
3371 min_width/height (Bug#8919).
3372
3373 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3374 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3375 Fix indentation.
c7e73be5 3376
cf99dcf8
EZ
33772011-06-26 Eli Zaretskii <eliz@gnu.org>
3378
3379 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3380 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3381 called at ZV.
3382
029529ac
CY
33832011-06-26 Chong Yidong <cyd@stupidchicken.com>
3384
3385 * process.c (wait_reading_process_output): Bypass select if
3386 waiting for a cell while ignoring keyboard input, and input is
3387 pending. Suggested by Jan Djärv (Bug#8869).
3388
7a7ef429
PE
33892011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3390
3391 Use gnulib's dup2 module instead of rolling our own.
3392 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3393
11fdef7d 33942011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3395
3396 * dispnew.c (scrolling_window): Before scrolling, turn off a
3397 mouse-highlight in the window being scrolled.
3398
cd3520a4
JB
33992011-06-24 Juanma Barranquero <lekktu@gmail.com>
3400
3401 Move DEFSYM to lisp.h and use everywhere.
3402
3403 * character.h (DEFSYM): Move declaration...
3404 * lisp.h (DEFSYM): ...here.
3405
3406 * gnutls.c:
3407 * minibuf.c:
3408 * w32menu.c:
3409 * w32proc.c:
3410 * w32select.c: Don't include character.h.
3411
3412 * alloc.c (syms_of_alloc):
3413 * buffer.c (syms_of_buffer):
3414 * bytecode.c (syms_of_bytecode):
3415 * callint.c (syms_of_callint):
3416 * casefiddle.c (syms_of_casefiddle):
3417 * casetab.c (init_casetab_once):
3418 * category.c (init_category_once, syms_of_category):
3419 * ccl.c (syms_of_ccl):
3420 * cmds.c (syms_of_cmds):
3421 * composite.c (syms_of_composite):
3422 * dbusbind.c (syms_of_dbusbind):
3423 * dired.c (syms_of_dired):
3424 * dispnew.c (syms_of_display):
3425 * doc.c (syms_of_doc):
3426 * editfns.c (syms_of_editfns):
3427 * emacs.c (syms_of_emacs):
3428 * eval.c (syms_of_eval):
3429 * fileio.c (syms_of_fileio):
3430 * fns.c (syms_of_fns):
3431 * frame.c (syms_of_frame):
3432 * fringe.c (syms_of_fringe):
3433 * insdel.c (syms_of_insdel):
3434 * keymap.c (syms_of_keymap):
3435 * lread.c (init_obarray, syms_of_lread):
3436 * macros.c (syms_of_macros):
3437 * msdos.c (syms_of_msdos):
3438 * print.c (syms_of_print):
3439 * process.c (syms_of_process):
3440 * search.c (syms_of_search):
3441 * sound.c (syms_of_sound):
3442 * syntax.c (init_syntax_once, syms_of_syntax):
3443 * terminal.c (syms_of_terminal):
3444 * textprop.c (syms_of_textprop):
3445 * undo.c (syms_of_undo):
3446 * w32.c (globals_of_w32):
3447 * window.c (syms_of_window):
3448 * xdisp.c (syms_of_xdisp):
3449 * xfaces.c (syms_of_xfaces):
3450 * xfns.c (syms_of_xfns):
3451 * xmenu.c (syms_of_xmenu):
3452 * xsettings.c (syms_of_xsettings):
3453 * xterm.c (syms_of_xterm): Use DEFSYM.
3454
4228cf16
TZ
34552011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3456
cd3520a4 3457 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3458
7fcccf1e
PE
34592011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3460
7efb4e0e
PE
3461 Integer and buffer overflow fixes (Bug#8873).
3462
ff5844ad
PE
3463 * print.c (printchar, strout): Check for string overflow.
3464 (PRINTPREPARE, printchar, strout):
3465 Don't set size unless allocation succeeds.
3466
90532f02
PE
3467 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3468 for sizes. Check for string overflow more accurately.
3469 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3470
6d84508d
PE
3471 * macros.c: Integer and buffer overflow fixes.
3472 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3473 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3474 Use ptrdiff_t, not int, for sizes.
3475 Don't increment bufsize until after realloc succeeds.
3476 Check for size-calculation overflow.
3477 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3478
437b2cb4
PE
3479 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3480
8b9ac8b4
PE
3481 * lread.c: Integer overflow fixes.
3482 (read_integer): Radix is now EMACS_INT, not int,
3483 to improve quality of diagnostics for out-of-range radices.
3484 Calculate buffer size correctly for out-of-range radices.
3485 (read1): Check for integer overflow in radices, and in
3486 read-circle numbers.
82cb60d3
PE
3487 (read_escape): Avoid int overflow.
3488 (Fload, openp, read_buffer_size, read1)
3489 (substitute_object_recurse, read_vector, read_list, map_obarray):
3490 Use ptrdiff_t, not int, for sizes.
3491 (read1): Use EMACS_INT, not int, for sizes.
20270765 3492 Check for size overflow.
8b9ac8b4 3493
7fcccf1e
PE
3494 * image.c (cache_image): Check for size arithmetic overflow.
3495
bfbbd7e7
PE
3496 * lread.c: Integer overflow issues.
3497 (saved_doc_string_size, saved_doc_string_length)
3498 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3499 Now ptrdiff_t, not int.
3500 (read1): Don't assume doc string length fits in int. Check for
3501 out-of-range doc string lengths.
3502 (read_list): Don't assume file position fits in int.
39019e54 3503 (read_escape): Check for hex character overflow.
bfbbd7e7 3504
4e323265
LL
35052011-06-22 Leo Liu <sdl.web@gmail.com>
3506
3507 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3508 Move to minibuffer.el.
3509
85fece3e
PE
35102011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3511
20b84ce9 3512 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3513 The following patches are for when GLYPH_DEBUG && !XASSERT.
3514 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3515 * dispnew.c (flush_stdout):
3516 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3517 Mark as externally visible.
3518 * dispnew.c (check_window_matrix_pointers): Now static.
3519 * dispnew.c (window_to_frame_vpos):
3520 * xfns.c (unwind_create_frame):
3521 * xterm.c (x_check_font): Remove unused local.
3522 * scroll.c (CHECK_BOUNDS):
3523 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3524 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3525 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3526 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3527 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3528 Now static.
3529 (debug_method_add): Use va_list and vsprintf rather than relying
3530 on undefined behavior with wrong number of arguments.
3531 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3532 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3533 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3534 since we're not interested in debugging glyphs with old libraries.
3535 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3536 GCC 4.6.0's static checking.
3537
0766b489
PE
35382011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3539
31fd4b32
PE
3540 Integer overflow and signedness fixes (Bug#8873).
3541 A few related buffer overrun fixes, too.
3542
b79e8648
PE
3543 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3544
0766b489
PE
3545 * dispextern.h (struct face.stipple):
3546 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3547 (x_bitmap_mask, x_allocate_bitmap_record)
3548 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3549 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3550 (x_create_bitmap_from_xpm_data):
3551 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3552 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3553 (.bitmaps_last):
3554 * xfaces.c (load_pixmap):
3555 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3556 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3557 (.bitmaps_last, struct x_output.icon_bitmap):
3558 Use ptrdiff_t, not int, for bitmap indexes.
3559 (x_allocate_bitmap_record): Check for size overflow.
3560 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3561
b081724f
PE
3562 Use ptrdiff_t, not int, for overlay counts.
3563 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3564 * editfns.c (overlays_around, get_pos_property):
3565 * textprop.c (get_char_property_and_overlay):
3566 * xdisp.c (next_overlay_change, note_mouse_highlight):
3567 * xfaces.c (face_at_buffer_position):
21514da7
PE
3568 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3569 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3570 (Fnext_overlay_change, Fprevious_overlay_change)
3571 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3572 Use ptrdiff_t, not int, for sizes.
21514da7 3573 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3574
3de73e5e
PE
3575 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3576
2606c57b
PE
3577 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3578 (x_session_initialize): Do not assume string length fits in int.
3579
aaafe47a
PE
3580 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3581 This is unlikely, but can occur if DPI is outlandish.
3582
2674ddc8 3583 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3584 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3585
28154962
PE
3586 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3587 * xrdb.c (magic_file_p, search_magic_path):
3588 Omit last arg SUFFIX; it was always 0. All callers changed.
3589 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3590
7de51af5
PE
3591 * xfont.c (xfont_match): Avoid need for strlen.
3592
25ed6cc3
PE
3593 * xfns.c: Don't assume strlen fits in int.
3594 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3595
4eab31dd
PE
3596 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3597 not unsigned long, as we prefer signed integers. All callers changed.
3598 Detect integer overflow in repeat count.
3599 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3600 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3601
171e2a58
PE
3602 * termcap.c: Don't assume sizes fit in int and never overflow.
3603 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3604 (gobble_line): Check for size-calculation overflow.
3605
ad39faca 3606 * minibuf.c (Fread_buffer):
6e5bb2dc 3607 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3608 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3609 Don't assume string length fits in int.
3610
52c61c22 3611 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3612 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3613
b5b8c9e5
PE
3614 * font.c: Don't assume string length fits in int.
3615 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3616 Use ptrdiff_t, not int.
ccd6111c
PE
3617 (font_intern_prop): Don't assume string length fits in int.
3618 Don't assume integer property fits in fixnum.
3619 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3620
882f0d81 3621 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3622 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3623 Reformulate so as not to need the command string.
3624 Invoke gzip -cd rather than gunzip, as it's more portable.
3625 (lock_info_type, lock_file_1, lock_file):
3626 Don't assume pid_t and time_t fit in unsigned long.
3627 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3628 (current_lock_owner): Prefer signed type for sizes.
3629 Use memcpy, not strncpy, where memcpy is what is really wanted.
3630 Don't assume (via atoi) that time_t and pid_t fit in int.
3631 Check for time_t and/or pid_t out of range, e.g., via a network share.
3632 Don't alloca where an auto var works fine.
3633
93f4cf88
PE
3634 * fileio.c: Fix some integer overflow issues.
3635 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3636 Don't assume string length fits in int.
3637 (directory_file_name): Don't assume string length fits in long.
3638 (make_temp_name): Don't assume pid fits in int, or that its print
3639 length is less than 20.
3640
f3e92b69
PE
3641 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3642
1bfdaf10
PE
3643 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3644
35016e9a
PE
3645 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3646
3d1e65a1
PE
3647 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3648 We prefer signed integers, even for size calculations.
3649
0b963a93
PE
3650 * emacs.c: Don't assume string length fits in 'int'.
3651 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3652 (main): Don't invoke strlen when not needed.
3653
573f4b54
PE
3654 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3655 (XD_DEBUG_MESSAGE): Don't waste a byte.
3656
989f33ba
PE
3657 * callproc.c (getenv_internal_1, getenv_internal)
3658 (Fgetenv_internal):
965d34eb
PE
3659 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3660
e4d29b33
PE
3661 * lread.c (invalid_syntax): Omit length argument.
3662 All uses changed. This doesn't fix a bug, but it simplifies the
3663 code away from its former Hollerith-constant appearance, and it's
3664 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3665 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3666
eb49b136
PE
3667 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3668 This didn't break anything, but it didn't help either.
3669 It's confusing to put a bogus integer in a place where the actual
3670 value does not matter.
9f62aeb1 3671 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3672 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3673
15375a22
PE
3674 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3675 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3676 implementation.
b61cc01c
PE
3677 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3678 We prefer signed types, and the value cannot exceed the EMACS_INT
3679 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3680 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3681 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3682 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3683
53b2623d
PE
3684 * indent.c (sane_tab_width): New function.
3685 (current_column, scan_for_column, Findent_to, position_indentation)
3686 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3687 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3688
51cab52b 3689 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3690
f2ed8a70
PE
3691 * lisp.h (lint_assume): New macro.
3692 * composite.c (composition_gstring_put_cache):
3693 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3694
abe80cc6
PE
3695 * editfns.c, insdel.c:
3696 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3697
b02c740e
PE
3698 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3699
ebc96716
PE
3700 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3701
b4e50fa0 3702 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3703 Use much-faster test for byte-length change.
311d5d7c 3704 Don't assume string byte-length fits in 'int'.
a4cf38e4 3705 Check that character arg fits in 'int'.
85461888 3706 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3707
c0c1ee9f
PE
3708 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3709
a498d7f4
PE
3710 * fns.c (concat): Catch string overflow earlier.
3711 Do not rely on integer wraparound.
3712
51cab52b
PE
3713 * dispextern.h (struct it.overlay_strings_charpos)
3714 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3715 * xdisp.c (forward_to_next_line_start)
3716 (back_to_previous_visible_line_start)
3717 (reseat_at_next_visible_line_start, next_element_from_buffer):
3718 Don't arbitrarily truncate the value of 'selective' to int.
3719
76031fad
PE
3720 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3721
5eb55db9
PE
3722 * composite.c: Don't truncate sizes to 'int'.
3723 (composition_gstring_p, composition_reseat_it)
3724 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3725 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3726 not EMACS_UINT, for indexes.
5eb55db9 3727
0703a717
PE
3728 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3729
d6202519
PE
3730 * buffer.c: Include <verify.h>.
3731 (struct sortvec.priority, struct sortstr.priority):
8961a454 3732 Now EMACS_INT, not int.
c20998a7 3733 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3734 (struct sortstr.size, record_overlay_string)
3735 (struct sortstrlist.size, struct sortlist.used):
3736 Don't truncate size to int.
3737 (record_overlay_string): Check for size-calculation overflow.
d6202519 3738 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3739
d5a19415
JM
37402011-06-22 Jim Meyering <meyering@redhat.com>
3741
029529ac 3742 Don't leak an XBM-image-sized buffer
d5a19415
JM
3743 * image.c (xbm_load): Free the image buffer after using it.
3744
a9041e6c
PE
37452011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3746
3747 Port to Sun C.
3748 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3749 that Sun C diagnosed.
3750 * fns.c (secure_hash): Fix pointer signedness issue.
3751 * intervals.c (static_offset_intervals): New function.
3752 (offset_intervals): Use it.
3753
7f3f739f
LL
37542011-06-21 Leo Liu <sdl.web@gmail.com>
3755
3756 * deps.mk (fns.o):
3757 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3758 sha512.h.
3759
3760 * fns.c (secure_hash): Rename from crypto_hash_function and change
3761 the first arg to accept symbols.
5b66d427 3762 (Fsecure_hash): New primitive.
7f3f739f
LL
3763 (syms_of_fns): New symbols.
3764
76147d94
DD
37652011-06-20 Deniz Dogan <deniz@dogan.se>
3766
3767 * process.c (Fset_process_buffer): Clarify return value in
3768 docstring.
3769
7d7d0045
CY
37702011-06-18 Chong Yidong <cyd@stupidchicken.com>
3771
3772 * dispnew.c (add_window_display_history): Use BVAR.
3773
3774 * xdisp.c (debug_method_add): Use BVAR.
3775 (check_window_end, dump_glyph_matrix, dump_glyph)
3776 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3777
3778 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3779 Likewise.
3780
3781 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3782 check till after the cache is created in init_frame_faces.
3783
ff2bc410
SM
37842011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3785
3786 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3787
28177add
PE
37882011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3789
dd3482fe
PE
3790 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3791 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3792 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3793
393d71f3 3794 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3795 * fileio.c (Finsert_file_contents):
3796 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3797 Remove the old (too-loose) buffer overflow checks.
3798 They weren't needed, since make_gap checks for buffer overflow.
3799 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3800 The old code merely checked for Emacs fixnum overflow, and relied
3801 on undefined (wraparound) behavior. The new code avoids undefined
3802 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3803
2e6813b0 3804 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3805 Tune. Don't use wider integers than needed. Don't use alloca.
3806 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3807
599a9e4f
PE
3808 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3809
99561444
PE
3810 * insdel.c, lisp.h (buffer_overflow): New function.
3811 (insert_from_buffer_1, replace_range, replace_range_2):
3812 * insdel.c (make_gap_larger):
3813 * editfns.c (Finsert_char):
3814 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3815
28177add
PE
3816 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3817
e69dafad
PE
38182011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3819
a7af7fde 3820 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3821
b1c46f02
PE
3822 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3823 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3824
e69dafad
PE
3825 * fileio.c: Don't assume EMACS_INT fits in off_t.
3826 (emacs_lseek): New static function.
3827 (Finsert_file_contents, Fwrite_region): Use it.
3828 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3829
566684ea
PE
3830 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3831
e6966cd6
PE
3832 * fns.c: Don't overflow int when computing a list length.
3833 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3834 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3835 truncation on 64-bit hosts. Check for QUIT every
3836 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3837 faster and is responsive enough.
3838 (Flength): Report an error instead of overflowing an integer.
3839 (Fsafe_length): Return a float if the value is not representable
3840 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3841 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3842 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3843
dd0b0efb
PE
3844 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3845 (header_size, word_size): New constants.
3846 (allocate_vectorlike): Don't check size overflow here.
3847 (allocate_vector): Check it here instead, since this is the only
3848 caller of allocate_vectorlike that could cause overflow.
3849 Check that the new vector's length is representable as a fixnum.
3850
86fe5cfe
PE
3851 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3852 The previous code was bogus. For example, next_almost_prime (32)
3853 returned 39, which is undesirable as it is a multiple of 3; and
3854 next_almost_prime (24) returned 25, which is a multiple of 5 so
3855 why was the code bothering to check for multiples of 7?
3856
80e88859
PE
3857 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3858
4a2f0ad6
PE
3859 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3860
f66c7cf8
PE
3861 Variadic C functions now count arguments with ptrdiff_t.
3862 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3863 Back then I didn't know that the Emacs coding style prefers signed int.
3864 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3865 were being counted with int, which may truncate counts on 64-bit
3866 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3867 * lisp.h (struct Lisp_Subr.function.aMANY)
3868 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3869 Arg counts are now ptrdiff_t, not size_t.
3870 All variadic functions and their callers changed accordingly.
3871 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3872 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3873 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3874 * callint.c (Fcall_interactively): Check arg count for overflow,
3875 to avoid potential buffer overrun. Use signed char, not 'int',
3876 for 'varies' array, so that we needn't bother to check its size
3877 calculation for overflow.
3878 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3879 * eval.c (apply_lambda):
3880 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3881 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3882 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3883
a1759b76
PE
3884 * callint.c (Fcall_interactively): Don't use index var as event count.
3885
d96be9fc
PE
3886 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3887 * mem-limits.h (SIZE): Remove; no longer used.
3888
a690a978 3889 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3890
578c21e6
PE
3891 Remove unnecessary casts.
3892 * xterm.c (x_term_init):
3893 * xfns.c (x_set_border_pixel):
3894 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3895 These aren't needed now that we assume ANSI C.
3896
96f53c6c
PE
3897 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3898 It's more likely to cause problems (due to unsigned overflow)
3899 than to cure them.
3900
83c77d31
PE
3901 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3902
ee2079f1
PE
3903 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3904
6da65536
PE
3905 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3906
7147c4a4
PE
3907 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3908
193e32d9
PE
3909 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3910
e5533da6
PE
3911 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3912
9910e595
PE
3913 GLYPH_CODE_FACE returns EMACS_INT, not int.
3914 * dispextern.h (merge_faces):
3915 * xfaces.c (merge_faces):
01103c44
PE
3916 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3917 Don't assume EMACS_INT fits in int.
9910e595 3918
2638320e
PE
3919 * character.h (CHAR_VALID_P): Remove unused parameter.
3920 * fontset.c, lisp.h, xdisp.c: All uses changed.
3921
045eb8d9
PE
3922 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3923
c1f134b5
PE
3924 * fns.c (concat): Minor tuning based on overflow analysis.
3925 This doesn't fix any bugs. Use int to hold character, instead
3926 of constantly refetching from Emacs object. Use XFASTINT, not
3927 XINT, for value known to be a character. Don't bother comparing
3928 a single byte to 0400, as it's always less.
3929
395fcb93 3930 * floatfns.c (Fexpt):
327eeec8
PE
3931 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3932
abbd3d23
PE
3933 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3934 for characters.
3935
684a03ef
PE
3936 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3937
0fed43f3
PE
3938 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3939 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3940 incorrectly succeed when S was a string, because 4294967386 was
3941 truncated before it was used.
3942
8fd02eb7
PE
3943 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3944 Otherwise, an out-of-range integer could cause undefined behavior
3945 on a 64-bit host.
3946
f8c86b69
PE
3947 * composite.c: Use int, not EMACS_INT, for characters.
3948 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3949 EMACS_INT, for values that are known to be in character range.
3950 This doesn't fix any bugs but is the usual style inside Emacs and
3951 may generate better code on 32-bit machines.
3952
34206dd2
PE
3953 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3954 This is for reasons similar to the recent CHAR_STRING fix.
3955 * charset.c (Fencode_char): Check that character arg is actually
3956 a character. Pass an int to ENCODE_CHAR.
3957 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3958 wider than 'int', as a compile-time check to prevent future regressions
3959 in this area.
3960
c5958d4c 3961 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3962
3963 Make sure a 64-bit char is never passed to CHAR_STRING.
3964 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3965 by silently ignoring the top 32 bits, allowing some values
3966 that were far too large to be valid characters.
3967 * character.h: Include <verify.h>.
3968 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3969 arguments are no wider than unsigned, as a compile-time check
3970 to prevent future regressions in this area.
3971 * data.c (Faset):
01103c44 3972 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3973 (Fsubst_char_in_region):
3974 * fns.c (concat):
3975 * xdisp.c (decode_mode_spec_coding):
3976 Adjust to CHAR_STRING's new requirement.
3977 * editfns.c (Finsert_char, Fsubst_char_in_region):
3978 * fns.c (concat): Check that character args are actually
3979 characters. Without this test, these functions did the wrong
3980 thing with wildly out-of-range values on 64-bit hosts.
3981
d37ca623
PE
3982 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3983 These casts should not be needed on 32-bit hosts, either.
3984 * keyboard.c (read_char):
3985 * lread.c (Fload): Remove casts to unsigned.
3986
ea204efb
PE
3987 * lisp.h (UNSIGNED_CMP): New macro.
3988 This fixes comparison bugs on 64-bit hosts.
3989 (ASCII_CHAR_P): Use it.
3990 * casefiddle.c (casify_object):
01103c44 3991 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3992 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3993 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3994 * dispextern.h (FACE_FROM_ID):
3995 * keyboard.c (read_char): Use UNSIGNED_CMP.
3996
41cb286c
PE
3997 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3998 not to EMACS_INT, to avoid GCC warning.
3999
4a1b9832
PE
4000 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4001
55daad71
PE
4002 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4003 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4004 isn't needed on 32-bit machines.
8f95c75c 4005
01103c44
PE
4006 * buffer.c (Fgenerate_new_buffer_name):
4007 Use EMACS_INT for count, not int.
0ceccced 4008 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4009
4010 * data.c (Qcompiled_function): Now static.
4011
c6f072e7
PE
4012 * window.c (window_body_lines): Now static.
4013
20ce5912
PE
4014 * image.c (gif_load): Rename local to avoid shadowing.
4015
9c4c5f81
PE
4016 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4017 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4018 * alloc.c (make_save_value): Integer argument is now of type
4019 ptrdiff_t, not int.
4020 (mark_object): Use ptrdiff_t, not int.
4021 * lisp.h (pD): New macro.
4022 * print.c (print_object): Use it.
4023
c0c5c8ae
PE
4024 * alloc.c: Use EMACS_INT, not int, to count objects.
4025 (total_conses, total_markers, total_symbols, total_vector_size)
4026 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4027 (total_free_floats, total_floats, total_free_intervals)
4028 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4029 Now EMACS_INT, not int. All uses changed.
4030 (Fgarbage_collect): Compute overall total using a double, so that
4031 integer overflow is less likely to be a problem. Check for overflow
4032 when converting back to an integer.
5a25e253
PE
4033 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4034 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4035 These were 'int' variables that could overflow on 64-bit hosts;
4036 they were never used, so remove them instead of repairing them.
211a0b2a 4037 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4038 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4039 Previously, this ceilinged at INT_MAX, but that doesn't work on
4040 64-bit machines.
e46bb31a 4041 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4042
c78baabf 4043 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4044 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4045 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4046 when a (possibly-narrower) signed value would do just as well.
4047 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4048
c9d624c6
PE
4049 * alloc.c: Catch some string size overflows that we were missing.
4050 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4051 for convenience in STRING_BYTES_MAX.
4052 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4053 The definition here is exact; the one in lisp.h was approximate.
4054 (allocate_string_data): Check for string overflow. This catches
4055 some instances we weren't catching before. Also, it catches
4056 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4057 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4058 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4059
c9d624c6
PE
4060 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4061 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4062 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4063
353032ce
PE
4064 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4065
2bccce07
PE
4066 * alloc.c (Fmake_string): Check for out-of-range init.
4067
0ac30604
SM
40682011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4069
4070 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4071
c195f2de
JD
40722011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4073
4074 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4075 xg_get_default_scrollbar_width.
4076
4077 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4078 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4079 (style_changed_cb): Call update_theme_scrollbar_width and call
4080 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4081 all frames (Bug#8505).
4082 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4083 Call gtk_window_set_resizable if HAVE_GTK3.
4084 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4085 and height if HAVE_GTK3 (Bug#8505).
4086 (scroll_bar_width_for_theme): New variable.
4087 (update_theme_scrollbar_width): New function.
4088 (xg_get_default_scrollbar_width): Move code to
4089 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4090 (xg_initialize): Call update_theme_scrollbar_width.
4091
4092 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4093
4094 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4095
e10ac9f1
MR
40962011-06-12 Martin Rudalics <rudalics@gmx.at>
4097
4098 * frame.c (make_frame): Call other_buffer_safely instead of
4099 other_buffer.
4100
4101 * window.c (temp_output_buffer_show): Call display_buffer with
4102 second argument Vtemp_buffer_show_specifiers and reset latter
4103 immediately after the call.
4104 (Vtemp_buffer_show_specifiers): New variable.
4105 (auto_window_vscroll_p, next_screen_context_lines)
4106 (Vscroll_preserve_screen_position): Remove leading asterisks from
4107 doc-strings.
4108
2d3c217e 41092011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4110
7b7f97e8 4111 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4112 * buffer.c (Qclone_number): Remove for now, as it's unused.
4113 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4114 (record_buffer): Remove unused local.
4115 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4116 (set_frame_buffer_list): Remove; unused.
4117 * frame.h (other_visible_frames): Remove decl.
4118 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4119 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4120 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4121 if HAVE_GPM.
4122 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4123 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4124 Define only if HAVE_GPM.
4125 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4126 (update_hints_inhibit): Remove; never set. All uses removed.
4127 * widgetprv.h (emacsFrameClassRec): Remove decl.
4128 * window.c (delete_deletable_window): Now returns void, since it
4129 wasn't returning anything.
4130 (compare_window_configurations): Remove unused locals.
4131 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4132 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4133 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4134 the same widths as pointers. This follows up on the 2011-05-06 patch.
4135 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4136 * xterm.h: Likewise.
4137 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4138
1384b89e
JB
41392011-06-12 Juanma Barranquero <lekktu@gmail.com>
4140
4141 * makefile.w32-in: Update dependencies.
4142 (LISP_H): Add lib/intprops.h.
4143
1100a63c
CY
41442011-06-11 Chong Yidong <cyd@stupidchicken.com>
4145
4146 * image.c (gif_load): Add animation frame delay to the metadata.
4147 (syms_of_image): Use DEFSYM. New symbol `delay'.
4148
6198ccd0
MR
41492011-06-11 Martin Rudalics <rudalics@gmx.at>
4150
4151 * window.c (delete_deletable_window): Re-add.
4152 (Fset_window_configuration): Rewrite to handle dead buffers and
4153 consequently deletable windows.
4154 (window_tree, Fwindow_tree): Remove. Supply functionality in
4155 window.el.
4156 (compare_window_configurations): Simplify code.
4157
b6e3633c
AS
41582011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4159
1ab0dee5
AS
4160 * image.c (imagemagick_load_image): Fix type mismatch.
4161 (Fimagemagick_types): Likewise.
4162
b6e3633c
AS
4163 * window.h (replace_buffer_in_windows): Declare.
4164
9397e56f
MR
41652011-06-11 Martin Rudalics <rudalics@gmx.at>
4166
4167 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4168 Qclone_number. Remove external declaration of Qdelete_window.
4169 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4170 code.
640c8776
SM
4171 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4172 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4173 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4174 buffer list implementation.
4175 (other_buffer_safely): New function.
4176 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4177 calls to replace_buffer_in_windows and
4178 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4179 if allowed.
4180 (record_buffer): Inhibit quitting and rewrite using quittable
4181 functions. Run Qbuffer_list_update_hook if allowed.
4182 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4183 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4184 Move switch-to-buffer to window.el.
9397e56f
MR
4185 (bury-buffer): Move to window.el.
4186 (Vbuffer_list_update_hook): New variable.
4187
4188 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4189 section.
4190
4191 * window.h (resize_frame_windows): Move up in code.
4192 (Fwindow_frame): Remove EXFUN.
4193 (replace_buffer_in_all_windows): Remove prototype.
4194 (replace_buffer_in_windows_safely): Add prototype.
4195
4196 * window.c: Declare Qdelete_window static again. Move down
4197 declaration of select_count.
4198 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4199 (Fother_window): Move to window.el.
4200 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4201 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4202 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4203 window.el.
4204 (replace_buffer_in_windows): Implement by calling
4205 Qreplace_buffer_in_windows.
4206 (replace_buffer_in_all_windows): Remove with some functionality
4207 moved into replace_buffer_in_windows_safely.
4208 (replace_buffer_in_windows_safely): New function.
4209 (select_window_norecord, select_frame_norecord): Move in front
4210 of run_window_configuration_change_hook. Remove now obsolete
4211 declarations.
640c8776
SM
4212 (Fset_window_buffer): Rewrite doc-string.
4213 Call Qrecord_window_buffer.
9397e56f
MR
4214 (keys_of_window): Move binding for other-window to window.el.
4215
b50691aa
CY
42162011-06-11 Chong Yidong <cyd@stupidchicken.com>
4217
4218 * dispextern.h (struct image): Replace data member, whose int_val
4219 and ptr_val fields were not used by anything, with a single
4220 lisp_val object.
4221
4222 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4223 (gif_clear_image, gif_load, imagemagick_load_image)
4224 (gs_clear_image, gs_load): Callers changed.
4225
3f754b86
PE
42262011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4227
cca69397
PE
4228 * buffer.h: Include <time.h>, for time_t.
4229 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4230
109e28d0
PE
4231 Fix minor problems found by static checking.
4232
60737f02
PE
4233 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4234
4b66faf3
PE
4235 Make identifiers static if they are not used in other modules.
4236 * data.c (Qcompiled_function, Qframe, Qvector):
4237 * image.c (QimageMagick, Qsvg):
4238 * minibuf.c (Qmetadata):
4239 * window.c (resize_window_check, resize_root_window): Now static.
4240 * window.h (resize_window_check, resize_root_window): Remove decls.
4241
109e28d0
PE
4242 * window.c (window_deletion_count, delete_deletable_window):
4243 Remove; unused.
46a4ce9e
PE
4244 (window_body_lines): Now static.
4245 (Fdelete_other_windows_internal): Mark vars as initialized.
4246 Make sure 'resize_failed' is initialized.
4247 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4248 (resize_window_apply): Remove unused local.
4249 * window.h (delete_deletable_window): Remove decl.
4250
109e28d0 4251 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4252 (imagemagick_load_image): Fix pointer signedness problem by changing
4253 last arg from unsigned char * to char *. All uses changed.
4254 Also, fix a local for similar reasons.
4255 Remove unused locals. Remove locals to avoid shadowing.
4256 (fn_rsvg_handle_free): Remove; unused.
4257 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4258 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4259
3f754b86
PE
4260 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4261
2547adb1
CY
42622011-06-10 Chong Yidong <cyd@stupidchicken.com>
4263
4264 * image.c (gif_load): Fix omitted cast error introduced by
4265 2011-06-06 change.
4266
2c8e37d4
MR
42672011-06-10 Martin Rudalics <rudalics@gmx.at>
4268
4269 * window.h (resize_proportionally, orig_total_lines)
4270 (orig_top_line): Remove from window structure.
4271 (set_window_height, set_window_width, change_window_heights)
4272 (Fdelete_window): Remove prototypes.
4273 (resize_frame_windows): Remove duplicate declaration.
4274
440a42e3
EZ
42752011-06-10 Eli Zaretskii <eliz@gnu.org>
4276
4277 * window.h (resize_frame_windows, resize_window_check)
4278 (delete_deletable_window, resize_root_window)
4279 (resize_frame_windows): Declare prototypes.
4280
4281 * window.c (resize_window_apply): Make definition be "static" to
4282 match the prototype.
4283
562dd5e9
MR
42842011-06-10 Martin Rudalics <rudalics@gmx.at>
4285
4286 * window.c: Remove declarations of Qwindow_size_fixed,
4287 window_min_size_1, window_min_size_2, window_min_size,
4288 size_window, window_fixed_size_p, enlarge_window, delete_window.
4289 Remove static from declaration of Qdelete_window, it's
4290 temporarily needed by Fbury_buffer.
4291 (replace_window): Don't assign orig_top_line and
4292 orig_total_lines.
4293 (Fdelete_window, delete_window): Remove. Window deletion is
4294 handled by window.el.
640c8776
SM
4295 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4296 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4297 (Fdelete_other_windows): Remove. Deleting other windows is
4298 handled by window.el.
4299 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4300 handled in window.el.
4301 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4302 Window minimum sizes are handled in window.el.
4303 (shrink_windows, size_window, set_window_height)
4304 (set_window_width, change_window_heights, window_height)
4305 (window_width, CURBEG, CURSIZE, enlarge_window)
4306 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4307 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4308 handled in window.el.
4309 (make_dummy_parent): Rename to make_parent_window and give it a
4310 second argument horflag.
4311 (make_window): Don't set resize_proportionally any more.
4312 (Fsplit_window): Remove. Windows are split in window.el.
4313 (save_restore_action, save_restore_orig_size)
4314 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4315 Resize mini windows in window.el.
4316 (grow_mini_window, shrink_mini_window): Implement by calling
4317 Qresize_root_window_vertically, resize_window_check and
4318 resize_window_apply.
640c8776
SM
4319 (saved_window, Fset_window_configuration, save_window_save):
4320 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4321 resize_proportionally.
4322 (window_min_height, window_min_width): Move to window.el.
4323 (keys_of_window): Move bindings for delete-other-windows,
4324 split-window, delete-window and enlarge-window to window.el.
4325
4326 * buffer.c: Temporarily extern Qdelete_window.
4327 (Fbury_buffer): Temporarily call Qdelete_window instead of
4328 Fdelete_window (Fbury_buffer will move to window.el soon).
4329
4330 * frame.c (set_menu_bar_lines_1): Remove code handling
4331 orig_top_line and orig_total_lines.
4332
4333 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4334 set_window_height but set heights directly.
4335 (change_frame_size_1): Use resize_frame_windows.
4336
4337 * xdisp.c (init_xdisp): Don't use set_window_height but set
4338 heights directly.
4339
640c8776
SM
4340 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4341 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4342 run_window_configuration_change_hook.
4343
4344 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4345 instead of change_window_heights and run
4346 run_window_configuration_change_hook.
4347
1a13852e
MR
43482011-06-09 Martin Rudalics <rudalics@gmx.at>
4349
4350 * window.c (replace_window): Rename second argument REPLACEMENT to
4351 NEW. New third argument SETFLAG. Rewrite.
4352 (delete_window, make_dummy_parent): Call replace_window with
4353 third argument 1.
4354 (window_list_1): Move down in code.
4355 (run_window_configuration_change_hook): Move set_buffer part
4356 before select_frame_norecord part in order to unwind correctly.
4357 Rename count1 to count.
4358 (recombine_windows, delete_deletable_window, resize_root_window)
4359 (Fdelete_other_windows_internal)
4360 (Frun_window_configuration_change_hook, make_parent_window)
4361 (resize_window_check, resize_window_apply, Fresize_window_apply)
4362 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4363 (Fdelete_window_internal, Fresize_mini_window_internal):
4364 New functions.
1a13852e
MR
4365 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4366
f3d1777e
MR
43672011-06-08 Martin Rudalics <rudalics@gmx.at>
4368
496e208e
MR
4369 * window.h (window): Add some new members to window structure -
4370 normal_lines, normal_cols, new_total, new_normal, clone_number,
4371 splits, nest, prev_buffers, next_buffers.
4372 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4373 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4374
f3d1777e
MR
4375 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4376 Remove.
496e208e
MR
4377 (make_dummy_parent): Set new members of windows structure.
4378 (make_window): Move down in code. Handle new members of window
4379 structure.
4380 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4381 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4382 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4383 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4384 (Fset_window_next_buffers, Fset_window_clone_number):
4385 New functions.
496e208e
MR
4386 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4387 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4388 Doc-string fixes.
4389 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4390 Argument WINDOW can be now internal window too.
4391 (Fwindow_use_time): Move up in code.
4392 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4393 Rewrite doc-string.
4394 (Fset_window_configuration, saved_window)
4395 (Fcurrent_window_configuration, save_window_save): Handle new
4396 members of window structure.
b9e809c2
MR
4397 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4398 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4399 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4400 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4401 Qget_mru_window, Qresize_root_window,
4402 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4403 Qauto_buffer_name; staticpro them.
f3d1777e 4404
abde8f8c
MR
44052011-06-07 Martin Rudalics <rudalics@gmx.at>
4406
4407 * window.c (Fwindow_total_size, Fwindow_left_column)
4408 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4409 (Fwindow_list_1): New functions.
4410 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4411 (Fwindow_width, Fscroll_left, Fscroll_right):
4412 Use window_body_cols instead of window_box_text_cols.
4413 (delete_window, Fset_window_configuration):
4414 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4415 (delete_all_subwindows): Take a window as argument and not a
4416 structure. Rewrite.
190b47e6
MR
4417 (window_loop): Remove handling of GET_LRU_WINDOW and
4418 GET_LARGEST_WINDOW.
4419 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4420
4421 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4422 window_box_text_cols. delete_all_subwindows now takes a
4423 Lisp_Object as argument.
abde8f8c 4424
640c8776
SM
4425 * indent.c (compute_motion, Fcompute_motion):
4426 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4427
fa8a67e6
MR
4428 * frame.c (delete_frame): Call delete_all_subwindows with root
4429 window as argument.
4430
a54e3482
DC
44312011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4432
4433 * fns.c (Fputhash): Document return value.
4434
60002bf5
CY
44352011-06-06 Chong Yidong <cyd@stupidchicken.com>
4436
4437 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4438
0c671da6 44392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4440
b862a52a 4441 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4442
be44ca6c
PE
4443 Check for overflow when converting integer to cons and back.
4444 * charset.c (Fdefine_charset_internal, Fdecode_char):
4445 Use cons_to_unsigned to catch overflow.
4446 (Fencode_char): Use INTEGER_TO_CONS.
4447 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4448 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4449 * data.c (long_to_cons, cons_to_long): Remove.
4450 (cons_to_unsigned, cons_to_signed): New functions.
4451 These signal an error for invalid or out-of-range values.
4452 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4453 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4454 * font.c (Ffont_variation_glyphs):
4455 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4456 * lisp.h: Include <intprops.h>.
4457 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4458 (cons_to_signed, cons_to_unsigned): New decls.
4459 (long_to_cons, cons_to_long): Remove decls.
4460 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4461 (Fprimitive_undo): Use CONS_TO_INTEGER.
4462 * xfns.c (Fx_window_property): Likewise.
4463 * xselect.c: Include <limits.h>.
4464 (x_own_selection, selection_data_to_lisp_data):
4465 Use INTEGER_TO_CONS.
4466 (x_handle_selection_request, x_handle_selection_clear)
4467 (x_get_foreign_selection, Fx_disown_selection_internal)
4468 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4469 (lisp_data_to_selection_data): Use cons_to_unsigned.
4470 (x_fill_property_data): Use cons_to_signed.
4471 Report values out of range.
4472
d1f3d2af
PE
4473 Check for buffer and string overflow more precisely.
4474 * buffer.h (BUF_BYTES_MAX): New macro.
4475 * lisp.h (STRING_BYTES_MAX): New macro.
4476 * alloc.c (Fmake_string):
4477 * character.c (string_escape_byte8):
4478 * coding.c (coding_alloc_by_realloc):
4479 * doprnt.c (doprnt):
4480 * editfns.c (Fformat):
4481 * eval.c (verror):
4482 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4483 since they may not be the same number.
4484 * editfns.c (Finsert_char):
4485 * fileio.c (Finsert_file_contents):
4486 Likewise for BUF_BYTES_MAX.
4487
dd52fcea
PE
4488 * image.c: Use ptrdiff_t, not int, for sizes.
4489 (slurp_file): Switch from int to ptrdiff_t.
4490 All uses changed.
4491 (slurp_file): Check that file size fits in both size_t (for
4492 malloc) and ptrdiff_t (for sanity and safety).
4493
7f9bbdbb
PE
4494 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4495 if b->modtime has its maximal value.
4496
dfe18f82
PE
4497 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4498
84acfcf0
PE
4499 Don't assume time_t can fit into int.
4500 * buffer.h (struct buffer.modtime): Now time_t, not int.
4501 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4502 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4503
ccd9a01a
PE
4504 Minor fixes for signed vs unsigned integers.
4505 * character.h (MAYBE_UNIFY_CHAR):
4506 * charset.c (maybe_unify_char):
4507 * keyboard.c (read_char, reorder_modifiers):
4508 XINT -> XFASTINT, since the integer must be nonnegative.
4509 * ftfont.c (ftfont_spec_pattern):
4510 * keymap.c (access_keymap, silly_event_symbol_error):
4511 XUINT -> XFASTINT, since the integer must be nonnegative.
4512 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4513 since it makes no difference and we prefer signed.
4514 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4515 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4516 nonnegative.
4517
d6d100dd
SM
45182011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4519
4520 * window.h (Fwindow_frame): Declare.
4521
2b6148e4
PE
45222011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4523
4524 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4525 (SPARE_MEMORY): Always define.
4526 (LARGE_REQUEST): Remove.
4527 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4528
f230ecc9
MR
45292011-06-06 Martin Rudalics <rudalics@gmx.at>
4530
727e958e
MR
4531 * lisp.h: Move EXFUNS for Fframe_root_window,
4532 Fframe_first_window and Fset_frame_selected_window to window.h.
4533
4534 * window.h: Move EXFUNS for Fframe_root_window,
4535 Fframe_first_window and Fset_frame_selected_window here from
4536 lisp.h.
4537
4538 * frame.c (Fwindow_frame, Fframe_first_window)
4539 (Fframe_root_window, Fframe_selected_window)
4540 (Fset_frame_selected_window): Move to window.c.
4541 (Factive_minibuffer_window): Move to minibuf.c.
4542 (Fother_visible_frames_p): New function.
4543
4544 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4545
f230ecc9
MR
4546 * window.c (decode_window, decode_any_window): Move up in code.
4547 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4548 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4549 (Fwindow_buffer): Move up and rewrite doc-string.
4550 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4551 (Fwindow_prev): New functions.
727e958e
MR
4552 (Fwindow_frame): Move here from frame.c. Accept any window as
4553 argument.
4554 (Fframe_root_window, Fframe_first_window)
4555 (Fframe_selected_window): Move here from frame.c. Accept frame
4556 or arbitrary window as argument. Update doc-strings.
4557 (Fminibuffer_window): Move up in code.
4558 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4559 (Fset_frame_selected_window): Move here from frame.c.
4560 Marginal rewrite.
727e958e
MR
4561 (Fselected_window, select_window, Fselect_window): Move up in
4562 code. Minor doc-string fixes.
f230ecc9 4563
4d09bcf6
PE
45642011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4565
4566 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4567 Do not assume that spare memory exists; that assumption is valid
4568 only if SYSTEM_MALLOC.
4569 (LARGE_REQUEST): New macro, so that the issue of large requests
4570 is separated from the issue of spare memory.
4571
810928a2
AS
45722011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4573
172418ad
AS
4574 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4575 format. (Bug#8806)
4576
43f862f7
AS
4577 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4578
810928a2
AS
4579 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4580 before statements.
4581
a059fe24
JD
45822011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4583
4584 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4585
4586 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4587
4588 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4589 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4590
989bf368
JB
45912011-06-05 Juanma Barranquero <lekktu@gmail.com>
4592
4593 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4594
4b80f674
CY
45952011-06-04 Chong Yidong <cyd@stupidchicken.com>
4596
4597 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4598 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4599 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4600 New error handlers.
4b80f674
CY
4601 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4602 Obey Vx_select_enable_clipboard_manager. Catch errors in
4603 x_clipboard_manager_save (Bug#8779).
4604 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4605 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4606
99a33b77 46072011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4608
4609 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4610
99a33b77 46112011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4612
4613 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4614 in the current matrix if keep_current_p is non-zero.
4615
8264569d
EZ
46162011-06-04 Eli Zaretskii <eliz@gnu.org>
4617
4618 * bidi.c (bidi_level_of_next_char): Fix last change.
4619
57f97249
EZ
46202011-06-03 Eli Zaretskii <eliz@gnu.org>
4621
fec2107c 4622 Support bidi reordering of text covered by display properties.
57f97249 4623
fec2107c
EZ
4624 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4625 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4626 (bidi_cache_search, bidi_cache_iterator_state)
4627 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4628 (bidi_level_of_next_char, bidi_move_to_visually_next):
4629 Support character positions inside a run of characters covered by a
fec2107c
EZ
4630 display string.
4631 (bidi_paragraph_init, bidi_resolve_explicit_1)
4632 (bidi_level_of_next_char): Call bidi_fetch_char and
4633 bidi_fetch_char_advance instead of FETCH_CHAR and
4634 FETCH_CHAR_ADVANCE.
4635 (bidi_init_it): Initialize new members.
4636 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4637 definitions.
4638 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4639 instead of using explicit *_CHAR codes.
d6d100dd
SM
4640 (bidi_resolve_explicit, bidi_resolve_weak):
4641 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4642 bidirectional text is supported only in multibyte buffers.
4643 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4644 it to initialize the frame_window_p member of struct bidi_it.
4645 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4646 (bidi_resolve_explicit, bidi_resolve_weak)
4647 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4648 bidi_it->nchars is non-positive.
4649 (bidi_level_of_next_char): Don't try to lookup the cache for the
4650 next/previous character if nothing is cached there yet, or if we
4651 were just reseat()'ed to a new position.
c40e2fb2 4652
0e14fe90
EZ
4653 * xdisp.c (set_cursor_from_row): Set start and stop points
4654 according to the row's direction when priming the loop that looks
4655 for the glyph on which to display cursor.
4656 (single_display_spec_intangible_p): Function deleted.
4657 (display_prop_intangible_p): Reimplement to call
4658 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4659 Accept 3 additional arguments needed by handle_display_spec.
4660 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4661 values: lists, `(when COND...)' forms, etc.
4662 (single_display_spec_string_p): Support property values that are
4663 lists with the argument STRING its top-level element.
4664 (display_prop_string_p): Fix the condition for processing a
4665 property that is a list to be consistent with handle_display_spec.
fec2107c 4666 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4667 last portion of handle_display_prop.
4668 (compute_display_string_pos): Accept additional argument
4669 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4670 value of a `display' property is a "replacing spec".
4671 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4672 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4673 the display property, but just return a value indicating whether
4674 the display property will replace the characters it covers.
4675 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4676 frame_window_p members of struct bidi_it.
d6d100dd
SM
4677 (compute_display_string_pos, compute_display_string_end):
4678 New functions.
fec2107c
EZ
4679 (push_it): Accept second argument POSITION, where pop_it should
4680 jump to continue iteration.
4681 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4682
fec2107c
EZ
4683 * keyboard.c (adjust_point_for_property): Adjust the call to
4684 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4685
4686 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4687 (bidi_init_it): Update prototypes.
4688 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4689 (compute_display_string_pos, compute_display_string_end):
4690 Declare prototypes.
fec2107c
EZ
4691 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4692 EMACS_INT.
fc6f18ce 4693
40087514 46942011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4695
57f53182
PE
4696 Malloc failure behavior now depends on size of allocation.
4697 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4698 * lisp.h: Change signatures accordingly.
4699 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4700 All callers changed. (Bug#8762)
4701
4702 * gnutls.c: Use Emacs's memory allocators.
4703 Without this change, the gnutls library would invoke malloc etc.
4704 directly, which causes problems on non-SYNC_INPUT hosts, and which
4705 runs afoul of improving memory_full behavior. (Bug#8761)
4706 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4707 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4708 xfree instead of the default malloc, realloc, free.
4709 (Fgnutls_boot): No need to check for memory allocation failure,
4710 since xmalloc does that for us.
4711
ac32cd99 4712 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4713 * category.c (hash_get_category_set):
4714 * ccl.c (ccl_driver):
4715 * charset.c (Fdefine_charset_internal):
4716 * charset.h (struct charset.hash_index):
4717 * composite.c (get_composition_id, gstring_lookup_cache)
4718 (composition_gstring_put_cache):
4719 * composite.h (struct composition.hash_index):
4720 * dispextern.h (struct image.hash):
4721 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4722 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4723 (hashfn_equal, hashfn_user_defined, make_hash_table)
4724 (maybe_resize_hash_table, hash_lookup, hash_put)
4725 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4726 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4727 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4728 * image.c (make_image, search_image_cache, lookup_image)
4729 (xpm_put_color_table_h):
4730 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4731 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4732 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4733 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4734 * alloc.c (allocate_vectorlike):
4735 Check for overflow in vector size calculations.
4736 * ccl.c (ccl_driver):
4737 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4738 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4739 need to be updated by these changes.
40087514
PE
4740 * fns.c (make_hash_table, maybe_resize_hash_table):
4741 Check for integer overflow with large hash tables.
0de4bb68
PE
4742 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4743 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4744 (SXHASH_REDUCE): New macro.
4745 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4746 Use it instead of discarding useful hash info with large hash values.
4747 (sxhash_float): New function.
4748 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4749 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4750 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4751 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4752 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4753 Adjust signatures to match updated version of code.
4754 (consing_since_gc): Now EMACS_INT, since a single hash table can
4755 use more than INT_MAX bytes.
4756
698d32e2
DN
47572011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4758
4759 Make it possible to build with GCC-4.6+ -O2 -flto.
4760
4761 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4762
fd6fa53f
SM
47632011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4764
4765 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4766 Call minibuffer-inactive-mode.
4767
864db017
JB
47682011-05-31 Juanma Barranquero <lekktu@gmail.com>
4769
4770 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4771 Update dependencies.
4772
2ad0baf4
DN
47732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4774
4775 * data.c (init_data): Remove code for UTS, this system is not
4776 supported anymore.
4777
4fcc2638
DN
47782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4779
4780 Don't force ./temacs to start in terminal mode.
4781
4782 * frame.c (make_initial_frame): Initialize faces in all cases, not
4783 only when CANNOT_DUMP is defined.
4784 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4785
c56e0fd5
DN
47862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4787
4788 * dispnew.c (add_window_display_history): Use const for the string
4789 pointer. Remove declaration, not needed.
4790
333d54da 47912011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4792
55d4c1b2 4793 Use 'inline', not 'INLINE'.
333d54da 4794 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4795 * alloc.c, fontset.c (INLINE): Remove.
4796 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4797 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4798 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4799 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4800 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4801
738db178
DN
48022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4803
4804 Make it possible to run ./temacs.
4805
4806 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4807 syms_of_callproc does the same thing. Remove test for
4808 "initialized", do it in the caller.
4809 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4810
620c53a6
SM
48112011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4812
4813 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4814 (read_minibuf): Use get_minibuffer.
4815 (syms_of_minibuf): Use DEFSYM.
4816 (Qmetadata): New var.
4817 * data.c (Qbuffer): Don't make it static.
4818 (syms_of_data): Use DEFSYM.
4819
e003a292
PE
48202011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4821
4822 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4823 (CCL_CODE_MIN): New macro.
4824
ed008a6d
PE
48252011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4826
3687c2ef
PE
4827 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4828
ed008a6d
PE
4829 * eval.c (Qdebug): Now static.
4830 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4831 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4832 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4833
d66c4c7c
CY
48342011-05-29 Chong Yidong <cyd@stupidchicken.com>
4835
4836 * image.c: Various fixes to ImageMagick code comments.
4837 (Fimagemagick_types): Doc fix.
4838
5fbc2025
PE
48392011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4840
0196f88a
PE
4841 Minor fixes prompted by GCC 4.6.0 warnings.
4842
4843 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4844
5fbc2025
PE
4845 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4846 (x_clipboard_manager_save_all): Move extern decl to ...
4847 * xterm.h: ... here, so that it can be checked for consistency.
4848
1dd3c2d9
CY
48492011-05-29 Chong Yidong <cyd@stupidchicken.com>
4850
4851 * xselect.c (x_clipboard_manager_save_frame)
4852 (x_clipboard_manager_save_all): New functions.
4853 (Fx_clipboard_manager_save): Lisp function deleted.
4854
4855 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4856 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4857
4858 * xterm.h: Update prototype.
4859
5ba6571d
WX
48602011-05-28 William Xu <william.xwl@gmail.com>
4861
4862 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4863 exiting (Bug#8239).
4864
3eaff834
JM
48652011-05-28 Jim Meyering <meyering@redhat.com>
4866
e1900994 4867 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4868 * fns.c (to_uchar): Define.
4869 (crypto_hash_function): Use it to convert some newly-signed
4870 variables to unsigned, to avoid sign-extension bugs. For example,
4871 without this change, (md5 "truc") would evaluate to
4872 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4873 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4874 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4875
0f6990a7
PE
48762011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4877
4878 Integer overflow fixes.
c8a9ca5a 4879
08686060
PE
4880 * dbusbind.c: Serial number integer overflow fixes.
4881 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4882 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4883 to hold a serial number that is too large for a fixnum.
4884 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4885 Check for serial numbers out of range. Decode any serial number
59568bf0 4886 that was so large that it became a float. (Bug#8722)
08686060 4887
2d1fc3c7
PE
4888 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4889 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4890 Use XFASTINT rather than XUINT when numbers are nonnegative.
4891 (xd_append_arg, Fdbus_method_return_internal):
4892 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4893 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4894 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4895 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4896 (Bug#8722)
2d1fc3c7 4897
c8a9ca5a
PE
4898 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4899
519e1d69
PE
4900 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4901
30569699
PE
4902 ccl: add integer overflow checks
4903 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4904 (IN_INT_RANGE): New macros.
4905 (ccl_driver): Use them to check for integer overflow when
4906 decoding a CCL program. Many of the new checks are whether XINT (x)
4907 fits in int; it doesn't always, on 64-bit hosts. The new version
4908 doesn't catch all possible integer overflows, but it's an
847044ea 4909 improvement. (Bug#8719)
30569699 4910
c11285dc
PE
4911 * alloc.c (make_event_array): Use XINT, not XUINT.
4912 There's no need for unsigned here.
4913
fdccd48e
PE
4914 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4915 This follows up to the 2011-05-06 change that substituted uintptr_t
4916 for EMACS_INT. This case wasn't caught back then.
4917
37910ab2
PE
4918 Rework Fformat to avoid integer overflow issues.
4919 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4920 now (part of C89). Include <verify.h>.
4921 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4922 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4923 (Fformat): Avoid the prepass trying to compute sizes; it was only
4924 approximate and thus did not catch overflow reliably. Instead, walk
4925 through the format just once, formatting and computing sizes as we go,
4926 checking for integer overflow at every step, and allocating a larger
4927 buffer as needed. Keep track separately whether the format is
4928 multibyte. Keep only the most-recently calculated precision, rather
4929 than them all. Record whether each argument has been converted to
4930 string. Use EMACS_INT, not int, for byte and char and arg counts.
4931 Support field widths and precisions larger than INT_MAX. Avoid
4932 sprintf's undefined behavior with conversion specifications such as %#d
4933 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4934 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4935 formatting out-of-range floating point numbers with int
9173deec 4936 formats. (Bug#8668)
37910ab2 4937
2e6578fb
PE
4938 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4939
0ae6bdee
PE
4940 * data.c: Avoid integer truncation in expressions involving floats.
4941 * data.c: Include <intprops.h>.
4942 (arith_driver): When there's an integer overflow in an expression
4943 involving floating point, convert the integers to floating point
4944 so that the resulting value does not suffer from catastrophic
4945 integer truncation. For example, on a 64-bit host (* 4
4946 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4947 Do not rely on undefined behavior after integer overflow.
4948
de883a70
PE
4949 merge count_size_as_multibyte, parse_str_to_multibyte
4950 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4951 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4952 Check for integer overflow.
4953 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4954 since it's now a duplicate of the other. This is more of
4955 a character than a buffer op, so better that it's in character.c.
4956 * fns.c, print.c: Adjust to above changes.
4957
2ff916cb
PE
49582011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4959
4960 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4961
f1b54466
PE
49622011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4963
fb1ac845
PE
4964 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4965 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4966 (x_clipboard_manager_save): Now static.
4967 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4968
f1b54466
PE
4969 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4970 (crypto_hash_function): Now static.
4971 Fix pointer signedness problems. Avoid unnecessary initializations.
4972
a9f737ee
CY
49732011-05-27 Chong Yidong <cyd@stupidchicken.com>
4974
4975 * termhooks.h (Vselection_alist): Make it terminal-local.
4976
4977 * terminal.c (create_terminal): Initialize it.
4978
4979 * xselect.c: Support for clipboard managers.
4980 (Vselection_alist): Move to termhooks.h as terminal-local var.
4981 (LOCAL_SELECTION): New macro.
4982 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4983 (symbol_to_x_atom): Remove gratuitous arg.
4984 (x_handle_selection_request, lisp_data_to_selection_data)
4985 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4986 (x_own_selection, x_get_local_selection, x_convert_selection):
4987 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4988 (some_frame_on_display): Delete unused function.
4989 (Fx_own_selection_internal, Fx_get_selection_internal)
4990 (Fx_disown_selection_internal, Fx_selection_owner_p)
4991 (Fx_selection_exists_p): New optional frame arg.
4992 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4993 (x_handle_selection_clear): Don't treat other terminals with the
4994 same keyboard specially. Use the terminal-local Vselection_alist.
4995 (x_clear_frame_selections): Use Frun_hook_with_args.
4996
4997 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4998
4999 * xterm.h: Add support for those atoms.
5000
e067f0c1
CY
50012011-05-26 Chong Yidong <cyd@stupidchicken.com>
5002
5003 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5004 (converted_selections, conversion_fail_tag): New global variables.
5005 (x_selection_request_lisp_error): Free the above.
5006 (x_get_local_selection): Remove unnecessary code.
5007 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5008 of converted selections stored in converted_selections.
5009 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5010 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5011 (x_convert_selection): New function.
5012 (x_handle_selection_event): Simplify.
5013 (x_get_foreign_selection): Don't ignore incoming requests while
5014 waiting for an answer; this will fail when we implement
5015 SAVE_TARGETS, and seems unnecessary anyway.
5016 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5017 (Vx_sent_selection_functions): Doc fix.
5018
0f4aebc0
LL
50192011-05-26 Leo Liu <sdl.web@gmail.com>
5020
5021 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5022
e61124cd
YM
50232011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5024
5025 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5026
5027 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5028 for fringe update if it has periodic bitmap.
ac389d0c 5029 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5030 and fringe_bitmap_periodic_p.
5031
5032 * fringe.c (get_fringe_bitmap_data): New function.
5033 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5034 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5035 row. Mark glyph row for fringe update if periodicity changed.
5036
5037 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5038 for fringe update unless it has periodic bitmap.
5039
f16d9837
KH
50402011-05-25 Kenichi Handa <handa@m17n.org>
5041
5042 * xdisp.c (get_next_display_element): Set correct it->face_id for
5043 a static composition.
5044
e1b90ef6
LL
50452011-05-24 Leo Liu <sdl.web@gmail.com>
5046
5047 * deps.mk (fns.o):
5048 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5049
5050 * fns.c (crypto_hash_function, Fsha1): New function.
5051 (Fmd5): Use crypto_hash_function.
5052 (syms_of_fns): Add Ssha1.
5053
7400048f
PE
50542011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5055
5056 * gnutls.c: Remove unused macros.
5057 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5058 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5059 Remove macros that are defined and never used.
5060 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5061
abb71cf4
CY
50622011-05-22 Chong Yidong <cyd@stupidchicken.com>
5063
5064 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5065 (Fx_get_selection_internal): Minor cleanup.
5066 (Fx_own_selection_internal): Rename arguments for consistency with
5067 select.el.
5068
6307db39
PE
50692011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5070
5071 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5072
f3d4e0a4
CY
50732011-05-22 Chong Yidong <cyd@stupidchicken.com>
5074
5075 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5076
4d8ade89
YM
50772011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5078
5079 * dispnew.c (scrolling_window): Don't exclude the case that the
5080 last enabled row in the desired matrix touches the bottom boundary.
5081
32078c8d
GM
50822011-05-21 Glenn Morris <rgm@gnu.org>
5083
5084 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5085 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5086 and add some more files.
32078c8d 5087
7285dc67
EZ
50882011-05-20 Eli Zaretskii <eliz@gnu.org>
5089
5090 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5091 report_file_error introduced by the change from 2011-05-07.
5092
89d1bd22
PE
50932011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5094
5095 * systime.h (Time): Define only if emacs is defined.
5096 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5097 where the include path doesn't have X11/X.h by default. See
5098 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5099
e23640bb 51002011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5101
5102 * composite.c (find_automatic_composition): Fix previous change.
5103
b9704ad9
GM
51042011-05-20 Glenn Morris <rgm@gnu.org>
5105
5106 * lisp.mk: New file, split from Makefile.in.
5107 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5108 (shortlisp): Remove.
5109 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5110
4a720484
GM
51112011-05-19 Glenn Morris <rgm@gnu.org>
5112
5113 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5114 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5115 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5116 (lisp): Set the order to that of loadup.el.
5117 (shortlisp): Make it a copy of $lisp.
5118 (SOME_MACHINE_LISP): Remove.
5119 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5120 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5121
a28d4396
KH
51222011-05-18 Kenichi Handa <handa@m17n.org>
5123
5124 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5125 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5126 (find_automatic_composition): Mostly rewrite for efficiency.
5127
a2b1fa8e
JB
51282011-05-18 Juanma Barranquero <lekktu@gmail.com>
5129
5130 * makefile.w32-in: Update dependencies.
5131
8e1f5610
CS
51322011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5133
5134 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5135 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5136
7025ee00 51372011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5138
cdfa6eab
PE
5139 Fix some integer overflow issues, such as string length overflow.
5140
06d6db33
PE
5141 * insdel.c (count_size_as_multibyte): Check for string overflow.
5142
2b4560a8
PE
5143 * character.c (lisp_string_width): Check for string overflow.
5144 Use EMACS_INT, not int, for string indexes and lengths; in
5145 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5146 the resulting string length overflows an EMACS_INT; instead,
5147 report a string overflow if no precision given. When checking for
5148 precision exhaustion, use a check that cannot possibly have
5149 integer overflow. (Bug#8675)
5150 * character.h (lisp_string_width): Adjust to new signature.
5151
cb93f9be
PE
5152 * alloc.c (string_overflow): New function.
5153 (Fmake_string): Use it. This doesn't change behavior, but saves
5154 a few bytes and will simplify future changes.
5155 * character.c (string_escape_byte8): Likewise.
5156 * lisp.h (string_overflow): New decl.
5157
1a1f3366
PE
5158 Fixups, following up to the user-interface timestamp change.
5159 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5160 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5161 * msdos.c (mouse_get_pos): Likewise.
5162 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5163 * w32gui.h (Time): Define by including "systime.h" rather than by
5164 declaring it ourselves. (Bug#8664)
5165
d4e3e4d3
PE
5166 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5167 * image.c (clear_image_cache): Likewise.
5168
f6a24d19
PE
5169 * term.c (term_mouse_position): Don't assume time_t wraparound.
5170
08dc5ae6
PE
5171 Be more systematic about user-interface timestamps.
5172 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5173 and sometimes 'EMACS_UINT', to represent these timestamps.
5174 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5175 This makes the code easier to follow, and makes it easier to catch
5176 integer overflow bugs such as Bug#8664.
5177 * frame.c (Fmouse_position, Fmouse_pixel_position):
5178 Use Time, not unsigned long, for user-interface timestamps.
5179 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5180 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5181 * keyboard.h (last_event_timestamp): Likewise.
5182 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5183 * menu.h (xmenu_show): Likewise.
5184 * term.c (term_mouse_position): Likewise.
5185 * termhooks.h (struct input_event.timestamp): Likewise.
5186 (struct terminal.mouse_position_hook): Likewise.
5187 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5188 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5189 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5190 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5191 what it was before.
5192 * menu.h, termhooks.h: Include "systime.h", for Time.
5193
8e55734a
PE
5194 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5195 Don't assume that the difference between two unsigned long values
5196 can fit into an integer. At this point, we know button_down_time
5197 <= event->timestamp, so the difference must be nonnegative, so
5198 there's no need to cast the result if double-click-time is
5199 nonnegative, as it should be; check that it's nonnegative, just in
5200 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5201 apart (about 25 days). (Bug#8664)
8e55734a 5202
841f1b75 5203 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5204 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5205
3e26f69c
PE
5206 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5207 that always fit in int. Use a sentinel instead of a counter, to
5208 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5209 * frame.h (struct frame): Use int for menu_bar_items_used
5210 instead of EMACS_INT, since it always fits in int.
3e26f69c 5211
5cc152c0
PE
5212 * menu.c (grow_menu_items): Check for int overflow.
5213
d89eb65e
PE
5214 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5215
5235bd3e
PE
5216 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5217 Before, the code was not consistent. These values cannot exceed
5218 2**31 - 1 so there's no need to make them unsigned.
5219 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5220 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5221 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5222 as modifiers.
5223 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5224
bc827e23
PE
5225 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5226 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5227 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5228 presumably because the widths might not match.
5229
78eb494e
PE
5230 * window.c (size_window): Avoid needless test at loop start.
5231
04f2d78b
CB
52322011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5233
5234 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5235
d2fc7e3d 52362011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5237
5238 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5239
d2fc7e3d 52402011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5241
5242 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5243 `width' to `bar_area_x' and `bar_area_width', respectively.
5244 (x_scroll_run): Take account of fringe background extension.
5245
04f2d78b
CB
5246 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5247 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5248 `bar_area_width', respectively.
5249 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5250 background extension.
5251
79b70037
GM
52522011-05-10 Jim Meyering <meyering@redhat.com>
5253
5254 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5255
2f142cc5
JB
52562011-05-10 Juanma Barranquero <lekktu@gmail.com>
5257
5258 * image.c (Finit_image_library): Return t for built-in image types,
5259 like pbm and xbm. (Bug#8640)
5260
57679c86
AS
52612011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5262
5263 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5264
888c9e86
EZ
52652011-05-07 Eli Zaretskii <eliz@gnu.org>
5266
b0512a1d
EZ
5267 * w32console.c (Fset_screen_color): Doc fix.
5268 (Fget_screen_color): New function.
5269 (syms_of_ntterm): Defsubr it.
5270
7285dc67
EZ
5271 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5272 unlink the temporary file if Fcall_process didn't create it in the
5273 first place.
5274 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5275 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5276 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5277 cue to call_process_cleanup not to close that handle.
5278
4d3fcc8e
BK
52792011-05-07 Ben Key <bkey76@gmail.com>
5280
5281 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5282 one of two shell specific rules, either bootstrap-temacs-CMD or
5283 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5284 to the previous implementation of the bootstrap-temacs rule.
5285 The bootstrap-temacs-CMD rule is similar to the previous
5286 implementation of the bootstrap-temacs rule except that it
5287 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5288 variable.
5289
5290 These changes, along with some changes to nt/configure.bat,
5291 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5292 earlier fix to add support for --cflags and --ldflags options
5293 that include quotes so that it works whether make uses cmd or
5294 sh as the shell.
5295
b4289b64
MA
52962011-05-06 Michael Albinus <michael.albinus@gmx.de>
5297
5298 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5299 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5300 is a constant.
5301 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5302 a string. Handle both cases.
5303 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5304 (Fdbus_register_method): Use Qinvalid_function.
5305
af4c0e28
JB
53062011-05-06 Juanma Barranquero <lekktu@gmail.com>
5307
5308 * makefile.w32-in: Update dependencies.
5309 (LISP_H): Add inttypes.h and stdin.h.
5310 (PROCESS_H): Add unistd.h.
5311
c51453d9
EZ
53122011-05-06 Eli Zaretskii <eliz@gnu.org>
5313
5314 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5315 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5316
8ff0ac3c 53172011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5318
4c4b566b
PE
5319 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5320
aab2b9b5
PE
5321 * term.c (vfatal): Remove stray call to va_end.
5322 It's not needed and the C Standard doesn't allow it here anyway.
5323
c378da0b
PE
5324 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5325 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5326
288b08c7
PE
5327 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5328 bytes.
5329
e3601888
PE
5330 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5331
db6c0e74
PE
5332 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5333
dd5963ea
PE
5334 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5335
88c9450f
PE
5336 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5337
2f9442b8
PE
5338 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5339
c032b5f8
PE
5340 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5341 * charset.c (Fdefine_charset_internal): Don't initialize
5342 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5343 32-bit int (Bug#8600).
a108c10b
PE
5344
5345 * lread.c (read_integer): Be more consistent with string-to-number.
5346 Use string_to_number to do the actual conversion; this avoids
5347 rounding errors and fixes some other screwups. Without this fix,
5348 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5349 (digit_to_number): Move earlier, for benefit of read_integer.
5350 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5351 not a digit in any supported base. (Bug#8602)
a108c10b 5352
ad5f9eea
PE
5353 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5354
aec1708a
PE
5355 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5356 to match comment at start of function. This also removes a
5357 GCC warning about overflow in a 32+64-bit port.
5358
47be4ab5
PE
5359 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5360
371cac43
PE
5361 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5362 Reported by Stefan Monnier in
5363 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5364 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5365 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5366
d01a7826
PE
5367 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5368 (EMACS_UINTPTR): Likewise, with uintptr_t.
5369
7fd47d5c
PE
5370 * lisp.h: Prefer 64-bit EMACS_INT if available.
5371 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5372 on 32-bit hosts that have 64-bit int, so that they can access
5373 large files.
122b0c86
PE
5374 However, temporarily disable this change unless the temporary
5375 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5376
8727937b
PE
5377 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5378
8ac068ac
PE
5379 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5380 This removes an assumption that EMACS_INT and long are the same
5381 width as pointers. The assumption is true for Emacs porting targets
5382 now, but we want to make other targets possible.
5383 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5384 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5385 In the rest of the code, change types of integers that hold casted
5386 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5387 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5388 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5389 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5390 No need to cast type when ORing.
5391 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5392 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5393 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5394 assume EMACS_INT is the same width as char *.
5395 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5396 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5397 Remove no-longer-needed casts.
5398 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5399 (xg_tool_bar_help_callback, xg_make_tool_item):
5400 Use EMACS_INTPTR to hold an integer
5401 that will be cast to void *; this can avoid a GCC warning
5402 if EMACS_INT is not the same width as void *.
5403 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5404 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5405 (current_message_1, set_message_1):
5406 Use a local to convert to proper width without a cast.
5407 * xmenu.c (dialog_selection_callback): Likewise.
5408
ede49d71
PE
5409 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5410 Also, don't assume VALBITS / RAND_BITS is less than 5,
5411 and don't rely on undefined behavior when shifting a 1 left into
5412 the sign bit.
5413 * lisp.h (get_random): Change signature to match.
5414
2f30ecd0
PE
5415 * lread.c (hash_string): Use size_t, not int, for hash computation.
5416 Normally we prefer signed values; but hashing is special, because
5417 it's better to use unsigned division on hash table sizes so that
5418 the remainder is nonnegative. Also, size_t is the natural width
5419 for hashing into memory. The previous code used 'int', which doesn't
5420 retain enough info to hash well into very large tables.
5421 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5422
2a866e7b
PE
5423 * dbusbind.c: Don't possibly lose pointer info when converting.
5424 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5425 Use XPNTR rather than XHASH, so that the high-order bits of
5426 the pointer aren't lost when converting through void *.
5427
51639eac
PE
5428 * eval.c (Fautoload): Don't double-shift a pointer.
5429
92394119
PE
5430 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5431
dbdb9a7c
JB
54322011-05-06 Juanma Barranquero <lekktu@gmail.com>
5433
5434 * gnutls.c (DEF_GNUTLS_FN):
5435 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5436
db7a0b4f
AS
54372011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5438
5439 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5440 marker. (Bug#8610)
5441
f7ff1b0f 54422011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5443
5444 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5445 New version that can reserve upto 2GB of heap space.
5446
f7ff1b0f 54472011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5448
5449 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5450
639c109b
TZ
54512011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5452
5453 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5454 `gnutls_certificate_set_x509_key_file'.
5455
d2127135
JB
54562011-05-05 Juanma Barranquero <lekktu@gmail.com>
5457
5458 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5459 Update dependencies.
5460
e968f4f3
JB
54612011-05-04 Juanma Barranquero <lekktu@gmail.com>
5462
5463 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5464 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5465 Remove unused parameter `fildes'.
5466 * process.c (read_process_output, send_process): Don't pass it.
5467
84d358f0
JB
54682011-05-04 Juanma Barranquero <lekktu@gmail.com>
5469
5470 Fix previous change: the library cache is defined in w32.c.
5471 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5472 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5473
0898ca10
JB
54742011-05-04 Juanma Barranquero <lekktu@gmail.com>
5475
5476 Implement dynamic loading of GnuTLS on Windows.
5477
5478 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5479 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5480 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5481 Declare.
5482
5483 * gnutls.c (Qgnutls_dll): Define.
5484 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5485 (gnutls_*): Declare function pointers.
5486 (init_gnutls_functions): New function to initialize function pointers.
5487 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5488 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5489 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5490 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5491 (emacs_gnutls_write, emacs_gnutls_read)
5492 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5493 (Fgnutls_available_p): New function.
5494 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5495 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5496 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5497
5498 * image.c: Include w32.h.
5499 (Vimage_type_cache): Delete.
5500 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5501 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5502 (w32_delayed_load): Move to w32.c.
5503
5504 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5505
5506 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5507 (w32_delayed_load): Move from image.c. When loading a library, record
5508 its filename in the :loaded-from property of the library id.
5509 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5510 Initialize and staticpro them.
5511 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5512
5513 * process.c: Include lisp.h before w32.h, not after.
5514 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5515 instead of gnutls_record_check_pending.
5516
5517 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5518
ff4de4aa
TZ
55192011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5520
5521 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5522 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5523 as passed in.
5524
abe95abb
JD
55252011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5526
5527 * xterm.c (x_set_frame_alpha): Do not set property on anything
5528 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5529
e16e55d4
JB
55302011-05-02 Juanma Barranquero <lekktu@gmail.com>
5531
5532 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5533
bafcf6a5
JB
55342011-05-02 Juanma Barranquero <lekktu@gmail.com>
5535
5536 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5537 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5538 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5539 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5540 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5541 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5542 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5543 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5544 (Qgnutls_bootprop_callbacks_verify): Make static.
5545
e7a6747f
AS
55462011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5547
19ed11ba
AS
5548 * callproc.c: Indentation fixup.
5549
e7a6747f 5550 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5551 (wait_for_termination, interruptible_wait_for_termination):
5552 Move after wait_for_termination_1.
e7a6747f 5553
1ef14cb4
LMI
55542011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5555
5556 * sysdep.c (interruptible_wait_for_termination): New function
5557 which is like wait_for_termination, but allows keyboard
5558 interruptions.
5559
5560 * callproc.c (Fcall_process): Add (:file "file") as an option for
5561 the STDOUT buffer.
5562 (Fcall_process_region): Ditto.
5563
330d880c
EZ
55642011-04-30 Eli Zaretskii <eliz@gnu.org>
5565
8db90b73
EZ
5566 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5567 rather than `XVECTOR (FOO)->size'.
5568
330d880c
EZ
5569 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5570 inttypes.h, as a gnulib replacement is used if it not available in
5571 system headers.
5572
15cbd324
EZ
55732011-04-21 Eli Zaretskii <eliz@gnu.org>
5574
5575 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5576 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5577 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5578
5579 * coding.c (coding_alloc_by_realloc): Error out if destination
5580 will grow beyond MOST_POSITIVE_FIXNUM.
5581 (decode_coding_emacs_mule): Abort if there isn't enough place in
5582 charbuf for the composition carryover bytes. Reserve an extra
5583 space for up to 2 characters produced in a loop.
5584 (decode_coding_iso_2022): Abort if there isn't enough place in
5585 charbuf for the composition carryover bytes.
5586
55872011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5588
ae940cca
EZ
5589 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5590 aborting when %lld or %lll format is passed.
5591 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5592 %llo or %llx format is passed. (Bug#8545)
5593
03ab8921
EZ
5594 * window.c (window_scroll_line_based): Use a marker instead of
5595 simple variables to record original value of point. (Bug#7952)
5596
afda1437
EZ
5597 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5598 produced by %s or %c overflows available buffer space. (Bug#8545)
5599
f76dee0c
PE
56002011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5601
5602 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5603 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5604
fdc5744d
JB
56052011-04-28 Juanma Barranquero <lekktu@gmail.com>
5606
5607 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5608
638f053a
JB
56092011-04-28 Juanma Barranquero <lekktu@gmail.com>
5610
5611 * keyboard.c (Qdelayed_warnings_hook): Define.
5612 (command_loop_1): Run `delayed-warnings-hook'
5613 if Vdelayed_warnings_list is non-nil.
5614 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5615 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5616
d178f871
EZ
56172011-04-28 Eli Zaretskii <eliz@gnu.org>
5618
5619 * doprnt.c (doprnt): Don't return value smaller than the buffer
5620 size if the message was truncated. (Bug#8545).
5621
b124fd93
JB
56222011-04-28 Juanma Barranquero <lekktu@gmail.com>
5623
5624 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5625 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5626
e810457d
PE
56272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5628
5629 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5630
ea51cceb
JB
56312011-04-27 Juanma Barranquero <lekktu@gmail.com>
5632
5633 * makefile.w32-in: Update dependencies.
5634
94dcfacf
EZ
56352011-04-27 Eli Zaretskii <eliz@gnu.org>
5636
5637 Improve `doprnt' and its usage. (Bug#8545)
5638 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5639 `format_end'. Remove support for %l as a conversion specifier.
5640 Don't use xrealloc. Improve diagnostics when the %l size modifier
5641 is used. Update the commentary.
5642
5643 * eval.c (verror): Simplify calculation of size_t.
5644
5645 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5646 messages.
5647
f61f41d7
PE
56482011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5649
5650 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5651 change.
5652
96fb4434
PE
56532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5654
5655 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5656 This makes this file independent of the recent pseudovector change.
5657
671875da 56582011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5659
69e9b5a3
PE
5660 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5661
b5f869a7 5662 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5663 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5664 Remove unused local.
c8926152 5665 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5666
841a1577 5667 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5668 GCC 4.6.0 optimizes based on type-based alias analysis.
5669 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5670 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5671 != &v->size, and therefore "v->size = 1; b->size = 2; return
5672 v->size;" must therefore return 1. This assumption is incorrect
5673 for Emacs, since it type-puns struct Lisp_Vector * with many other
5674 types. To fix this problem, this patch adds a new type struct
f904488f 5675 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5676 and pseudovectors, and helps optimizing compilers not get fooled
5677 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5678 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5679 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5680 the size member.
eab3844f
PE
5681 (XSETPVECTYPE): Rewrite in terms of new macro.
5682 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5683 This is a bit clearer, and further avoids the possibility of
5684 undesirable aliasing.
5685 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5686 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5687 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5688 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5689 (ASIZE): Now uses header.size rather than size.
5690 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5691 to avoid the hassle of writing XVECTOR (foo)->header.size.
5692 (struct vectorlike_header): New type.
eab3844f
PE
5693 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5694 object, to help avoid aliasing.
5695 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5696 (SUBRP): Likewise, since Lisp_Subr is a special case.
5697 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5698 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5699 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5700 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5701 changed to be "header.size" and "header.next".
5702 * buffer.h (struct buffer): Likewise.
5703 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5704 * frame.h (struct frame): Likewise.
5705 * process.h (struct Lisp_Process): Likewise.
5706 * termhooks.h (struct terminal): Likewise.
5707 * window.c (struct save_window_data, struct saved_window): Likewise.
5708 * window.h (struct window): Likewise.
5709 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5710 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5711 * buffer.c (init_buffer_once): Likewise.
5712 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5713 special case.
5714 * process.c (Fformat_network_address): Use local var for size,
5715 for brevity.
5716
0df1eac5
PE
5717 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5718
847ab9d1 5719 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5720 * data.c (atof): Remove decl; no longer used or needed.
5721 (digit_to_number): Move to lread.c.
5722 (Fstring_to_number): Use new string_to_number function, to be
5723 consistent with how the Lisp reader treats infinities and NaNs.
5724 Do not assume that floating-point numbers represent EMACS_INT
5725 without losing information; this is not true on most 64-bit hosts.
5726 Avoid double-rounding errors, by insisting on integers when
5727 parsing non-base-10 numbers, as the documentation specifies.
5728 * lisp.h (string_to_number): New decl, replacing ...
5729 (isfloat_string): Remove.
bc0a5c13 5730 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5731 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5732 appears to have been a coding error. Similarly, do not accept
5733 strings like +-1e0 as floating point numbers. Do not report
5734 overflow for integer overflows unless the base is not 10 which
5735 means we have no simple and reliable way to continue.
5736 Break out the floating-point parsing into a new
5737 function string_to_number, so that Fstring_to_number parses
5738 floating point numbers consistently with the Lisp reader.
04f2d78b 5739 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5740 (E_CHAR, EXP_INT): Remove, replacing with ...
5741 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5742 (string_to_number): New function, replacing isfloat_string.
5743 This function checks for valid syntax and produces the resulting
5744 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5745 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5746 so that overflow for non-base-10 numbers is reported only when
5747 there's no portable and simple way to convert to floating point.
452f4150 5748
67769ffc
PE
5749 * textprop.c (set_text_properties_1): Rewrite for clarity,
5750 and to avoid GCC warning about integer overflow.
5751
c20db43f
PE
5752 * intervals.h (struct interval): Use EMACS_INT for members
5753 where EMACS_UINT might cause problems. See
5754 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5755 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5756 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5757 All uses changed.
37aa2f85
PE
5758 (offset_intervals): Tell GCC not to worry about length overflow
5759 when negating a negative length.
c20db43f 5760
2538aa2f
PE
5761 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5762 (overrun_check_free): Likewise.
5763
f2d3008d
PE
5764 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5765 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5766 word size.
5767
ec8df744
PE
5768 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5769 (gnutls_make_error): Rename local to avoid shadowing.
5770 (gnutls_emacs_global_deinit): ifdef out; not used.
5771 (Fgnutls_boot): Use const for pointer to readonly storage.
5772 Comment out unused local. Fix pointer signedness problems.
5773
640ee02d
PE
5774 * lread.c (openp): Don't stuff size_t into an 'int'.
5775 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5776 about possible signed overflow.
5777
6048fb2a
PE
5778 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5779 (GDK_KEY_g): Don't define if already defined.
5780 (xg_prepare_tooltip): Avoid pointer signedness problem.
5781 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5782
fa3c87e1
PE
5783 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5784 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5785
2172544b
PE
5786 * xfns.c (Fx_window_property): Simplify a bit,
5787 to make a bit faster and to avoid GCC 4.6.0 warning.
5788 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5789
9b821a21
PE
5790 * fns.c (internal_equal): Don't assume size_t fits in int.
5791
3c616cfa
PE
5792 * alloc.c (compact_small_strings): Tighten assertion a little.
5793
c2982e87
PE
5794 Replace pEd with more-general pI, and fix some printf arg casts.
5795 * lisp.h (pI): New macro, generalizing old pEd macro to other
5796 conversion specifiers. For example, use "...%"pI"d..." rather
5797 than "...%"pEd"...".
5798 (pEd): Remove. All uses replaced with similar uses of pI.
5799 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5800 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5801 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5802 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5803 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5804 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5805 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5806 64-bit hosts.
5807 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5808 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5809 * print.c (safe_debug_print, print_object): Likewise.
5810 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5811 to int.
6f04d126
PE
5812 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5813 avoiding the 0 flag, which is not portable.
c2982e87
PE
5814 * process.c (Fmake_network_process): Use pI to avoid cast.
5815 * region-cache.c (pp_cache): Likewise.
5816 * xdisp.c (decode_mode_spec): Likewise.
5817 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5818 behavior on 64-bit hosts with printf arg.
6f04d126 5819 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5820 (x_stop_queuing_selection_requests): Likewise.
5821 (x_get_window_property): Don't truncate byte count to an 'int'
5822 when tracing.
0b432f21 5823
5e073ec7
PE
5824 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5825 here, since it parses constructs like leading '-' and spaces,
5826 which are not wanted; and it overflows with large numbers.
5827 Instead, simply match F[0-9]+, which is what is wanted anyway.
5828
36372bf9
PE
5829 * alloc.c: Remove unportable assumptions about struct layout.
5830 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5831 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5832 (allocate_vectorlike, make_pure_vector): Use the new macros,
5833 plus offsetof, to remove unportable assumptions about struct layout.
5834 These assumptions hold on all porting targets that I know of, but
5835 they are not guaranteed, they're easy to remove, and removing them
5836 makes further changes easier.
5837
0b432f21
PE
5838 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5839 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5840 (string_overrun_cookie): Now const. Use initializers that
5841 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5842 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5843 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5844 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5845 multiple of sizeof (EMACS_INT); it need not be, if
5846 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5847 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5848
895009e1
JB
58492011-04-26 Juanma Barranquero <lekktu@gmail.com>
5850
5851 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5852
6a7a1b0b
TZ
58532011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5854
5855 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5856 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5857 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5858
841a1577 58592011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5860
5861 * lisp.h (Qdebug): List symbol.
895009e1 5862 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5863 * keyboard.c (debug-on-event): New variable.
5864 (handle_user_signal): Break into debugger when debug-on-event
5865 matches the current signal symbol.
5866
f2d3ba6f
DN
58672011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5868
5869 * alloc.c (check_sblock, check_string_bytes)
5870 (check_string_free_list): Convert to standard C.
5871
42ce4c63
TZ
58722011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5873
5874 * w32.c (emacs_gnutls_push): Fix typo.
5875
825cd63c
EZ
58762011-04-25 Eli Zaretskii <eliz@gnu.org>
5877
fb11d64d
EZ
5878 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5879 "cast to pointer from integer of different size".
5880
825cd63c
EZ
5881 Improve doprnt and its use in verror. (Bug#8545)
5882 * doprnt.c (doprnt): Document the set of format control sequences
5883 supported by the function. Use SAFE_ALLOCA instead of always
5884 using `alloca'.
5885
5886 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5887 is one byte too soon. Don't use xrealloc; instead xfree and
5888 xmalloc anew.
5889
e061a11b
TZ
58902011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5891
5892 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5893 callbacks stage.
5894
5895 * gnutls.c: Renamed global_initialized to
5896 gnutls_global_initialized. Added internals for the
5897 :verify-hostname-error, :verify-error, and :verify-flags
5898 parameters of `gnutls-boot' and documented those parameters in the
5899 docstring. Start callback support.
9173deec
JB
5900 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5901 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5902 on error. Return error code.
e061a11b
TZ
5903 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5904 (emacs_gnutls_read): Likewise.
5905 (Fgnutls_boot): Return handshake error code.
5906 (emacs_gnutls_handle_error): New function.
5907 (wsaerror_to_errno): Likewise.
5908
5909 * w32.h (emacs_gnutls_pull): Add prototype.
5910 (emacs_gnutls_push): Likewise.
5911
5912 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5913 (emacs_gnutls_push): Likewise.
5914
59152011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5916
5917 * process.c (wait_reading_process_output): Check if GnuTLS
5918 buffered some data internally if no FDs are set for TLS
5919 connections.
5920
5921 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5922 (LIBS): Link to USER_LIBS.
5923 ($(BLD)/gnutls.$(0)): New target.
5924
fa6996bc
EZ
59252011-04-24 Eli Zaretskii <eliz@gnu.org>
5926
eb35682e
EZ
5927 * xdisp.c (handle_single_display_spec): Rename the
5928 display_replaced_before_p argument into display_replaced_p, to
5929 make it consistent with the commentary. Fix typos in the
5930 commentary.
5931
e2ad650c
EZ
5932 * textprop.c (syms_of_textprop): Remove dead code.
5933 (copy_text_properties): Delete obsolete commentary about an
5934 interface that was deleted long ago. Fix typos in the description
5935 of arguments.
5936
1b2de274
EZ
5937 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5938 to changes in oldXMenu/XMenu.h from 2011-04-16.
5939 <menu_help_message, prev_menu_help_message>: Constify.
5940 (IT_menu_make_room): menu->help_text is now `const char **';
5941 adjust.
5942
5943 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5944 to changes in oldXMenu/XMenu.h from 2011-04-16.
5945 (struct XMenu): Declare `help_text' `const char **'.
5946
5947 * xfaces.c <Qunspecified>: Make extern again.
5948
5949 * syntax.c: Include sys/types.h before including regex.h, as
5950 required by Posix.
5951
762b15be
EZ
5952 * doc.c (get_doc_string): Improve the format passed to `error'.
5953
5954 * doprnt.c (doprnt): Improve commentary.
5955
5956 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5957
5958 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5959 them with etags.
5960
f1052e5d
EZ
5961 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5962 changes in globals.h immediately force recompilation.
762b15be
EZ
5963 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5964 $(CURDIR)/s/ms-w32.h.
5965 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5966
fa6996bc
EZ
5967 * character.c (Fchar_direction): Function deleted.
5968 (syms_of_character): Don't defsubr it.
5969 <char-direction-table>: Deleted.
5970
e6c3da20
EZ
59712011-04-23 Eli Zaretskii <eliz@gnu.org>
5972
5973 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5974 * doprnt.c: Include limits.h.
5975 (SIZE_MAX): New macro.
04f2d78b
CB
5976 (doprnt): Return a size_t value. 2nd arg is now size_t.
5977 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5978 Improve overflow protection. Support `l' modifier for integer
5979 conversions. Support %l conversion. Don't assume an EMACS_INT
5980 argument for integer conversions and for %c.
5981
5982 * lisp.h (doprnt): Restore prototype.
5983
5984 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5985 $(SRC)/character.h.
5986
5987 * Makefile.in (base_obj): Add back doprnt.o.
5988
5989 * deps.mk (doprnt.o): Add back prerequisites.
5990 (callint.o): Depend on character.h.
5991
5992 * eval.c (internal_lisp_condition_case): Include the handler
5993 representation in the error message.
5994 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5995 when breaking from the loop.
5996
5997 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5998
5999 * callint.c (Fcall_interactively): When displaying error message
6000 about invalid control letter, pass the character's codepoint, not
6001 a pointer to its multibyte form. Improve display of the character
6002 in octal and display also its hex code.
6003
6004 * character.c (char_string): Use %x to display the (unsigned)
6005 codepoint of an invalid character, to avoid displaying a bogus
6006 negative value.
6007
6008 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6009 `error', not SYMBOL_NAME itself.
6010
6011 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6012 character arguments to `error'.
6013
6014 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6015 to `error' in error message about FINAL_CHAR argument. Make sure
6016 FINAL_CHAR is a character, and use %c when it is passed as
6017 argument to `error'.
6018
4ffd0d6b 60192011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6020
6021 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6022
6023 * w32.c: Include <time.h>.
6024 (sys_localtime): New function.
6025
4ffd0d6b 60262011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6027
6028 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6029
4ffd0d6b 6030 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6031
4ffd0d6b 60322011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6033
4ffd0d6b
GM
6034 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6035 zombies (Bug#8467).
aac0c6e3 6036
04c56954
EZ
60372011-04-19 Eli Zaretskii <eliz@gnu.org>
6038
6039 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6040 gl_state.e_property when gl_state.object is Qt.
6041
6042 * insdel.c (make_gap_larger): Remove limitation of buffer size
6043 to <= INT_MAX.
6044
16a43933
CY
60452011-04-18 Chong Yidong <cyd@stupidchicken.com>
6046
6047 * xdisp.c (lookup_glyphless_char_display)
6048 (produce_glyphless_glyph): Handle cons cell entry in
6049 glyphless-char-display.
6050 (Vglyphless_char_display): Document it.
6051
6052 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6053 glyphless-char-display.
6054
4581706e
CY
60552011-04-17 Chong Yidong <cyd@stupidchicken.com>
6056
6057 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6058
6059 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6060
6061 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6062 definition for no-X builds.
6063
4887c6e2 60642011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6065
fd35b6f9
PE
6066 Static checks with GCC 4.6.0 and non-default toolkits.
6067
5c1ccb01
PE
6068 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6069
006c5daa
PE
6070 * process.c (keyboard_bit_set): Define only if SIGIO.
6071 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6072 (send_process): Repair possible setjmp clobbering.
6073
efc736d3
PE
6074 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6075
4e2fe2e6
PE
6076 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6077
f97334a2
PE
6078 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6079
4e75f29d
PE
6080 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6081 Define only if needed.
6082
90efadd1
PE
6083 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6084 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6085 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6086
3c647824
PE
6087 * dispextern.h (struct redisplay_interface): Rename param
6088 to avoid shadowing.
e264f262 6089 * termhooks.h (struct terminal): Likewise.
761383f4 6090 * xterm.c (xembed_send_message): Likewise.
3c647824 6091
b58c5c4a
PE
6092 * insdel.c (make_gap_smaller): Define only if
6093 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6094
cad59032
PE
6095 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6096 it.
6097
c339dc2e
PE
6098 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6099 so that we aren't warned about unused symbols.
6100
91a3e27b
PE
6101 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6102
399c71d3 6103 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6104
8ffc96f5
PE
6105 * xfns.c (x_real_positions): Mark locals as initialized.
6106
eef9bc79
PE
6107 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6108
098db9dd
PE
6109 * xterm.c: Fix problems found by static analysis with other toolkits.
6110 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6111 (x_dispatch_event): Declare static if USE_GTK, and
6112 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6113 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6114 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6115 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6116 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6117
eb18f6cc
PE
6118 * xmenu.c (menu_help_callback): Pointer type fixes.
6119 Use const pointers when pointing at readonly data. Avoid pointer
6120 signedness clashes.
6121 (FALSE): Remove unused macro.
6122 (update_frame_menubar): Remove unused decl.
6123
1fe72bf8
PE
6124 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6125
60d9e1db
PE
6126 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6127 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6128 (single_menu_item): Rename local to avoid shadowing.
6129
39261c26
PE
6130 * keyboard.c (make_lispy_event): Remove unused local var.
6131
018c5e19
PE
6132 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6133 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6134
63d2b86e
PE
6135 * bitmaps: Change bitmaps from unsigned char back to the X11
6136 compatible char. Avoid the old compiler warnings about
6137 out-of-range initializers by using, for example, '\xab' rather
6138 than 0xab.
6139
aefd87e1
PE
6140 * xgselect.c (xgselect_initialize): Check vs interface
6141 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6142
bf501fb9
PE
6143 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6144
e9829fdf
PE
6145 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6146 to read-only memory.
6147
1086c095
PE
6148 * fns.c (vector): Remove; this old hack is no longer needed.
6149
2baccd04 6150 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6151 Remove unused var.
dde42981 6152 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6153
72391843 6154 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6155
436c16df 6156 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6157 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6158 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6159
92bb796d 6160 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6161 (x_term_init): Remove local to avoid shadowing.
92bb796d 6162
764430a3 6163 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6164
6165 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6166 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6167
d1dfb56c
EZ
61682011-04-16 Eli Zaretskii <eliz@gnu.org>
6169
c4354cb4
EZ
6170 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6171
d1dfb56c
EZ
6172 Fix regex.c, syntax.c and friends for buffers > 2GB.
6173 * syntax.h (struct gl_state_s): Declare character position members
6174 EMACS_INT.
6175
6176 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6177
04f2d78b
CB
6178 * textprop.c (verify_interval_modification, interval_of):
6179 Declare arguments EMACS_INT.
d1dfb56c
EZ
6180
6181 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6182 EMACS_INT.
6183
6184 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6185
6186 * indent.c (Fvertical_motion): Local variable it_start is now
6187 EMACS_INT.
6188
6189 * regex.c (re_match, re_match_2, re_match_2_internal)
6190 (bcmp_translate, regcomp, regexec, print_double_string)
6191 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6192 (re_compile_pattern, re_exec): Declare arguments and local
6193 variables `size_t' and `ssize_t' and return values `regoff_t', as
6194 appropriate.
6195 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6196 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6197 <compile_stack_type>: `size' and `avail' are now `size_t'.
6198
6199 * regex.h <regoff_t>: Use ssize_t, not int.
6200 (re_search, re_search_2, re_match, re_match_2): Arguments that
6201 specify buffer/string position and length are now ssize_t and
6202 size_t. Return type is regoff_t.
6203
613052cd
BK
62042011-04-16 Ben Key <bkey76@gmail.com>
6205
6206 * nsfont.m: Fixed bugs in ns_get_family and
6207 ns_descriptor_to_entity that were caused by using free to
6208 deallocate memory blocks that were allocated by xmalloc (via
6209 xstrdup). This caused Emacs to crash when compiled with
6210 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6211 --enable-checking=xmallocoverrun). xfree is now used to
6212 deallocate these memory blocks.
6213
4170f62f 62142011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6215
71b41406
PE
6216 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6217
9587a89d
PE
6218 emacs_write: Accept and return EMACS_INT for sizes.
6219 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6220 et seq.
6221 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6222 Accept and return EMACS_INT.
6223 (emacs_gnutls_write): Return the number of bytes written on
6224 partial writes.
6225 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6226 (emacs_read, emacs_write): Remove check for negative size, as the
6227 Emacs source code has been audited now.
9587a89d
PE
6228 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6229 (emacs_read, emacs_write): Use it.
273a5f82
PE
6230 * process.c (send_process): Adjust to the new signatures of
6231 emacs_write and emacs_gnutls_write. Do not attempt to store
6232 a byte offset into an 'int'; it might overflow.
9587a89d 6233 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6234
3e047f51
PE
6235 * sound.c: Don't assume sizes fit in 'int'.
6236 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6237 Return EMACS_INT, not int.
3e047f51 6238 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6239 Accept EMACS_INT, not int.
6240 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6241 record read return values.
6242
cc39a9db
BK
62432011-04-15 Ben Key <bkey76@gmail.com>
6244
c9d0ec6d
JB
6245 * keyboard.c (Qundefined): Don't declare static since it is used
6246 in nsfns.m.
6247 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6248 static since they are used in nsfont.m.
cc39a9db 6249
6c60eb9f
SM
62502011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6251
6252 * process.c (Qprocessp): Don't declare static.
6253 * lisp.h (Qprocessp): Declare again.
6254
7990b61a
JB
62552011-04-15 Juanma Barranquero <lekktu@gmail.com>
6256
6257 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6258
5d4cb038
PE
62592011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6260
8bd7b830 6261 Improve C-level modularity by making more things 'static'.
cd64ea1d 6262
e3b27b31
PE
6263 Don't publish debugger-only interfaces to other modules.
6264 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6265 (verify_bytepos, count_markers): Move decls to the only modules
6266 that need them.
6267 * region-cache.h (pp_cache): Likewise.
6268 * window.h (check_all_windows): Likewise.
6269 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6270
5d4cb038
PE
6271 * sysdep.c (croak): Now static, if
6272 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6273 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6274
6275 * alloc.c (refill_memory_reserve): Now static if
6276 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6277 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6278
e87b6180
PE
6279 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6280 Define only if USE_LUCID.
6281
ac64929e
PE
6282 * xrdb.c (x_customization_string, x_rm_string): Now static.
6283
6f37259d
PE
6284 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6285 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6286
1683e3ab
PE
6287 * xdisp.c (draw_row_with_mouse_face): Now static.
6288 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6289
de9c2632
PE
6290 * window.h (check_all_windows): Mark externally visible.
6291
2b96acb7
PE
6292 * window.c (window_deletion_count): Now static.
6293
6294 * undo.c: Make symbols static if they're not exported.
6295 (last_undo_buffer, last_boundary_position, pending_boundary):
6296 Now static.
6297
50436f33
PE
6298 * textprop.c (interval_insert_behind_hooks): Now static.
6299 (interval_insert_in_front_hooks): Likewise.
6300
64520e5c
PE
6301 * term.c: Make symbols static if they're not exported.
6302 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6303 (max_frame_lines, tty_set_terminal_modes):
6304 (tty_reset_terminal_modes, tty_turn_off_highlight):
6305 (get_tty_terminal): Now static.
6306 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6307 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6308 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6309 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6310 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6311
1fa53021
PE
6312 * sysdep.c: Make symbols static if they're not exported.
6313 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6314 Now static.
6315 (sigprocmask_set, full_mask): Remove; unused.
6316 (wait_debugging): Mark as visible.
6317 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6318 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6319
d4b43b22
PE
6320 * syntax.c (syntax_temp): Define only if !__GNUC__.
6321
b7c513d0
PE
6322 * sound.c (current_sound_device, current_sound): Now static.
6323
989b29ad
PE
6324 * search.c (searchbufs, searchbuf_head): Now static.
6325
13a55a78
PE
6326 * scroll.c (scroll_cost): Remove; unused.
6327 * dispextern.h (scroll_cost): Remove decl.
6328
de68a1fc
PE
6329 * region-cache.h (pp_cache): Mark as externally visible.
6330
40ccffa6
PE
6331 * process.c: Make symbols static if they're not exported.
6332 (process_tick, update_tick, create_process, chan_process):
6333 (Vprocess_alist, proc_buffered_char, datagram_access):
6334 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6335 (deactivate_process): Mark defn as static, as well as decl.
6336 * lisp.h (create_process): Remove decl.
6337 * process.h (chan_process, Vprocess_alist): Remove decls.
6338
ad64fc97
PE
6339 * print.c: Make symbols static if they're not exported.
6340 (print_depth, new_backquote_output, being_printed, print_buffer):
6341 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6342 (print_interval, print_number_index, initial_stderr_stream):
6343 Now static.
6344 * lisp.h (Fprinc): Remove decl.
6345 (debug_output_compilation_hack): Mark as externally visible.
6346
adddb265
PE
6347 * sysdep.c (croak): Move decl from here to syssignal.h.
6348 * syssignal.h (croak): Put it here, so the API can be checked when
6349 'croak' is called from dissociate_if_controlling_tty.
6350
1717ede2
PE
6351 * minibuf.c: Make symbols static if they're not exported.
6352 (minibuf_save_list, choose_minibuf_frame): Now static.
6353 * lisp.h (choose_minibuf_frame): Remove decl.
6354
fa5fb2bc
PE
6355 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6356
1e3890d1
PE
6357 * lread.c: Make symbols static if they're not exported.
6358 (read_objects, initial_obarray, oblookup_last_bucket_number):
6359 Now static.
6360 (make_symbol): Remove; unused.
6361 * lisp.h (initial_obarray, make_symbol): Remove decls.
6362
8a1414fa
PE
6363 * keyboard.c: Make symbols static if they're not exported.
6364 (single_kboard, recent_keys_index, total_keys, recent_keys):
6365 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6366 (this_single_command_key_start, echoing, last_auto_save):
6367 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6368 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6369 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6370 (Vlispy_mouse_stem, double_click_count):
6371 Now static.
6372 (force_auto_save_soon): Define only if SIGDANGER.
6373 (ignore_mouse_drag_p): Now static if
6374 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6375 (print_help): Remove; unused.
6376 (stop_character, last_timer_event): Mark as externally visible.
6377 * keyboard.h (ignore_mouse_drag_p): Declare only if
6378 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6379 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6380 * lisp.h (echoing): Remove decl.
6381 (force_auto_save_soon): Declare only if SIGDANGER.
6382 * xdisp.c (redisplay_window): Simplify code, to make it more
6383 obvious that ignore_mouse_drag_p is not accessed if !defined
6384 USE_GTK && !defined HAVE_NS.
6385
93ea6e8f
PE
6386 * intervals.c: Make symbols static if they're not exported.
6387 (merge_properties_sticky, merge_interval_right, delete_interval):
6388 Now static.
6389 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6390
77382fcc
PE
6391 * insdel.c: Make symbols static if they're not exported.
6392 However, leave prepare_to_modify_buffer alone. It's never
6393 called from outside this function, but that appears to be a bug.
6394 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6395 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6396 (adjust_after_replace_noundo): Remove; unused.
6397 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6398 (signal_before_change): Remove decls.
77382fcc 6399
9306c32e
PE
6400 * indent.c (val_compute_motion, val_vmotion): Now static.
6401
cd44d2eb
PE
6402 * image.c: Make symbols static if they're not exported.
6403 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6404 if USE_GTK.
6405 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6406 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6407
ad9a7a06
PE
6408 * fringe.c (standard_bitmaps): Now static.
6409 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6410
81626931
PE
6411 * frame.c: Make symbols static if they're not exported.
6412 (x_report_frame_params, make_terminal_frame): Now static.
6413 (get_frame_param): Now static, unless HAVE_NS.
6414 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6415 (x_get_resource_string): Remove; not used.
6416 * frame.h (make_terminal_frame, x_report_frame_params):
6417 (x_get_resource_string); Remove decls.
6418 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6419 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6420
239f9db9
PE
6421 * font.c, fontset.c: Make symbols static if they're not exported.
6422 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6423 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6424 * font.c (font_close_object): Now static.
6425 * font.h (font_close_object): Remove.
6426 * fontset.c (FONTSET_OBJLIST): Remove.
6427 (free_realized_fontset) #if-0 the body, which does nothing.
6428 (face_suitable_for_char_p): #if-0, as it's never called.
6429 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6430 * xfaces.c (face_at_string_position):
6431 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6432 since 0 is always ASCII.
6433
dfcf3579
PE
6434 * fns.c (weak_hash_tables): Now static.
6435
5045092b
PE
6436 * fileio.c: Make symbols static if they're not exported.
6437 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6438 (Vwrite_region_annotation_buffers): Now static.
6439
57a96f5c
PE
6440 * eval.c: Make symbols static if they're not exported.
6441 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6442 * lisp.h (backtrace_list): Remove decl.
6443
35f08c38
PE
6444 * emacs.c: Make symbols static if they're not exported.
6445 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6446 (fatal_error_code, fatal_error_signal_hook, standard_args):
6447 Now static.
6448 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6449 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6450 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6451 * lisp.h (fatal_error_signal_hook): Remove decl.
6452 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6453
f44bd759
PE
6454 * editfns.c: Move a (normally-unused) function to its only use.
6455 * editfns.c, lisp.h (get_operating_system_release): Remove.
6456 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6457 worth the hassle of breaking this out.
6458
b532497d
PE
6459 * xterm.c: Make symbols static if they're not exported.
6460 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6461 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6462 (x_destroy_window, x_delete_display):
6463 Now static.
6464 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6465 (x_mouse_leave): Remove; unused.
6466 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6467 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6468 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6469 Remove decls.
6470 (x_mouse_leave): Declare only if WINDOWSNT.
6471 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6472 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6473 USE_X_TOOLKIT.
6474
1675728f
PE
6475 * ftxfont.c: Make symbols static if they're not exported.
6476 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6477 HAVE_FREETYPE.
6478 * font.h (ftxfont_driver): Likewise.
6479
e4cebfca
PE
6480 * xfns.c: Make symbols static if they're not exported.
6481 (x_last_font_name, x_display_info_for_name):
6482 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6483 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6484 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6485 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6486 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6487 (last_show_tip_args): Now static.
6488 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6489 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6490 (x_screen_planes): Remove; unused.
6491 * dispextern.h (x_screen_planes): Remove decl.
6492
5bf46f05
PE
6493 * dispnew.c: Make symbols static if they're not exported.
6494 * dispextern.h (redraw_garbaged_frames, scrolling):
6495 (increment_row_positions): Remove.
6496 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6497 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6498 Now static.
6499 (redraw_garbaged_frames): Remove; unused.
6500
435f4c28
PE
6501 * xfaces.c: Make symbols static if they're not exported.
6502 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6503 Remove decls.
6504 * xterm.h (defined_color): Remove decls.
6505 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6506 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6507 (menu_face_changed_default, defined_color, free_realized_face):
6508 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6509 (ascii_face_of_lisp_face): Remove; unused.
6510
8524aef3
PE
6511 * xdisp.c: Make symbols static if they're not exported.
6512 * dispextern.h (scratch_glyph_row, window_box_edges):
6513 (glyph_to_pixel_coords, set_cursor_from_row):
6514 (get_next_display_element, set_iterator_to_next):
6515 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6516 (show_mouse_face): Remove decls
6517 * frame.h (message_buf_print): Likewise.
6518 * lisp.h (pop_message, set_message, check_point_in_composition):
6519 Likewise.
6520 * xterm.h (set_vertical_scroll_bar): Likewise.
6521 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6522 (message_buf_print, scratch_glyph_row, displayed_buffer):
6523 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6524 (get_next_display_element, show_mouse_face, window_box_edges):
6525 (frame_to_window_pixel_xy, check_point_in_composition):
6526 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6527 (glyph_to_pixel_coords): Remove; unused.
6528
16390cd2
PE
6529 * dired.c (file_name_completion): Now static.
6530
6531 * dbusbind.c (xd_in_read_queued_messages): Now static.
6532
a25f4dfa
PE
6533 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6534 * data.c (circular_list_error): Remove.
6535
14a9c8df
PE
6536 * commands.h (last_point_position, last_point_position_buffer):
6537 (last_point_position_window): Remove decls.
6538 * keyboard.c: Make these variables static.
6539
04f2d78b
CB
6540 * coding.h (coding, code_convert_region, encode_coding_gap):
6541 Remove decls.
74ab6df5
PE
6542 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6543 (iso_code_class, detect_coding, code_convert_region): Now static.
6544 (encode_coding_gap): Remove; unused.
6545
38dfbee1
PE
6546 * chartab.c (chartab_chars, chartab_bits): Now static.
6547
a2cb4e63
PE
6548 * charset.h (charset_iso_8859_1): Remove decl.
6549 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6550 Now static.
6551
127198fd
PE
6552 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6553 * ccl.c (Vccl_program_table): Now static.
6554 (check_ccl_update): Remove; unused.
6555
d85b608f
PE
6556 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6557 * category.h: ... from here.
6558 * category.c (check_category_table, set_category_set): Now static.
6559
31cd66f3
PE
6560 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6561 * lisp.h: Remove these decls.
6562
c358e587
PE
6563 * buffer.c (buffer_count): Remove unused var.
6564
e78aecca
PE
6565 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6566 so that it's not optimized away.
6567 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6568 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6569 exported only to the debugger.
6570
e192d7d3 6571 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6572 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6573
92470028
PE
6574 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6575 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6576 was inaccessible from Lisp.
6577 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6578 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6579
244ed907
PE
6580 alloc.c: Import and export fewer symbols, and remove unused items.
6581 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6582 is defined.
6583 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6584 it's not optimized away by whole-program optimization.
6585 (message_enable_multibyte, free_misc): Remove.
6586 (catchlist, handlerlist, mark_backtrace):
6587 Declare only if BYTE_MARK_STACK.
6588 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6589 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6590 (message_enable_multibyte): Remove decl.
6591 (free_misc, interval_free_list, float_block, float_block_index):
6592 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6593 (cons_free_list, last_marked_index):
6594 Now static.
6595 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6596 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6597 (mark_backtrace): Define only if BYTE_MARK_STACK.
6598 * xdisp.c (message_enable_multibyte): Now static.
6599
61c2b50e 6600 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6601 This makes it easier for human readers (and static analyzers)
6602 to see whether these variables are used from other modules.
6603 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6604 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6605 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6606 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6607 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6608 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6609 * xmenu.c, xselect.c:
6610 Declare Q* vars static if they are not used in other modules.
6611 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6612 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6613 Remove decls of unexported vars.
6614 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6615
95c82688
PE
6616 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6617
16a97296
PE
6618 Make Emacs functions such as Fatom 'static' by default.
6619 This makes it easier for human readers (and static analyzers)
6620 to see whether these functions can be called from other modules.
6621 DEFUN now defines a static function. To make the function external
6622 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6623 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6624 (Finit_image_library):
16a97296
PE
6625 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6626 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6627 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6628 Remove decls, since these functions are now static.
6629 (Funintern, Fget_internal_run_time): New decls, since these functions
6630 were already external.
95c82688 6631
16a97296
PE
6632 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6633 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6634 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6635 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6636 * keyboard.c, keymap.c, lread.c:
6637 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6638 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6639 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6640 Mark functions with DEFUE instead of DEFUN,
6641 if they are used in other modules.
6642 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6643 decls for now-static functions.
6644 * buffer.h (Fdelete_overlay): Remove decl.
6645 * callproc.c (Fgetenv_internal): Mark as internal.
6646 * composite.c (Fremove_list_of_text_properties): Remove decl.
6647 (Fcomposition_get_gstring): New forward static decl.
6648 * composite.h (Fcomposite_get_gstring): Remove decl.
6649 * dired.c (Ffile_attributes): New forward static decl.
6650 * doc.c (Fdocumntation_property): New forward static decl.
6651 * eval.c (Ffetch_bytecode): New forward static decl.
6652 (Funintern): Remove extern decl; now in .h file where it belongs.
6653 * fileio.c (Fmake_symbolic_link): New forward static decl.
6654 * image.c (Finit_image_library): New forward static decl.
6655 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6656 * intervals.h (Fprevious_property_change):
6657 (Fremove_list_of_text_properties): Remove decls.
6658 * keyboard.c (Fthis_command_keys): Remove decl.
6659 (Fcommand_execute): New forward static decl.
6660 * keymap.c (Flookup_key): New forward static decl.
6661 (Fcopy_keymap): Now static.
6662 * keymap.h (Flookup_key): Remove decl.
6663 * process.c (Fget_process): New forward static decl.
6664 (Fprocess_datagram_address): Mark as internal.
6665 * syntax.c (Fsyntax_table_p): New forward static decl.
6666 (skip_chars): Remove duplicate decl.
6667 * textprop.c (Fprevious_property_change): New forward static decl.
6668 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6669 Now internal.
6670 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6671 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6672
785bbd42
PE
6673 * editfns.c (Fformat): Remove unreachable code.
6674
8b913b57
AS
66752011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6676
6677 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6678 change. (Bug#8496)
6679
a6744a35
EZ
66802011-04-13 Eli Zaretskii <eliz@gnu.org>
6681
6682 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6683 when at ZV. (Bug#8487)
6684
e7974947
AS
66852011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6686
baad03f0
AS
6687 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6688 (Bug#8437)
6689 * keyboard.c (parse_tool_bar_item): Likewise.
6690 * sound.c (sound_cleanup, alsa_close): Likewise.
6691 * termcap.c (tgetent): Likewise.
6692 * xfns.c (x_default_font_parameter): Likewise.
6693 * xsettings.c (read_and_apply_settings): Likewise.
6694
e7974947
AS
6695 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6696 (overrun_check_free): Protoize.
6697
28272684
PE
66982011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6699
6700 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6701 since callers should never pass a negative size.
6702 Change the signature to match that of plain 'read' and 'write'; see
6703 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6704 * lisp.h: Update prototypes of emacs_write and emacs_read.
6705
11997c76
EZ
67062011-04-11 Eli Zaretskii <eliz@gnu.org>
6707
6708 * xdisp.c (redisplay_window): Don't try to determine the character
6709 position of the scroll margin if the window start point w->startp
e896f03c 6710 is outside the buffer's accessible region. (Bug#8468)
11997c76 6711
8a2cbd72
EZ
67122011-04-10 Eli Zaretskii <eliz@gnu.org>
6713
6714 Fix write-region and its subroutines for buffers > 2GB.
6715 * fileio.c (a_write, e_write): Modify declaration of arguments and
6716 local variables to support buffers larger than 2GB.
6717 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6718
6719 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6720 argument, local variables, and return value.
6721
6722 * lisp.h: Update prototypes of emacs_write and emacs_read.
6723
6724 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6725
4073e537 67262011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6727
1ebfdcb6
PE
6728 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6729
b2ded58d
PE
6730 Fix more problems found by GCC 4.6.0's static checks.
6731
7d66342c
PE
6732 * xdisp.c (vmessage): Use a better test for character truncation.
6733
bbf47d44
PE
6734 * charset.c (load_charset_map): <, not <=, for optimization,
6735 and to avoid potential problems with integer overflow.
9248994d 6736 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6737 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6738 * editfns.c (Fformat): Likewise.
1e69125e 6739 * syntax.c (skip_chars): Likewise.
3befa583 6740
e3019616
PE
6741 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6742 This also lets GCC 4.6.0 generate slightly better loop code.
6743
becfa255
PE
6744 * callint.c (Fcall_interactively): <, not <=, for optimization.
6745 (Fcall_interactively): Count the number of arguments produced,
6746 not the number of arguments given. This is simpler and lets GCC
6747 4.6.0 generate slightly better code.
6748
dae0cd48
PE
6749 * ftfont.c: Distingish more carefully between FcChar8 and char.
6750 The previous code passed unsigned char * to a functions like
6751 strlen and xstrcasecmp that expect char *, which does not
6752 conform to the C standard.
6753 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6754 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6755 char * when the C standard requires it.
6756
76032d70
PE
6757 * keyboard.c (read_char): Remove unused var.
6758
eb3f1cc8
PE
6759 * eval.c: Port to Windows vsnprintf (Bug#8435).
6760 Include <limits.h>.
6761 (SIZE_MAX): Define if the headers do not.
6762 (verror): Do not give up if vsnprintf returns a negative count.
6763 Instead, grow the buffer. This ports to Windows vsnprintf, which
6764 does not conform to C99. Problem reported by Eli Zaretskii.
6765 Also, simplify the allocation scheme, by avoiding the need for
6766 calling realloc, and removing the ALLOCATED variable.
6767
70476b54
PE
6768 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6769
12020a9e
PE
6770 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6771 But keep the doprint source code for now, as we might revamp it
6772 and use it again (Bug#8435).
ea6c7ae6
PE
6773 * lisp.h (doprnt): Remove.
6774 * Makefile.in (base_obj): Remove doprnt.o.
6775 * deps.mk (doprnt.o): Remove.
6776
5fdb398c
PE
6777 error: Print 32- and 64-bit integers portably (Bug#8435).
6778 Without this change, on typical 64-bit hosts error ("...%d...", N)
6779 was used to print both 32- and 64-bit integers N, which relied on
6780 undefined behavior.
6781 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6782 New macro.
6783 * lisp.h (error, verror): Mark as printf-like functions.
6784 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6785 Report overflow in size calculations when allocating printf buffer.
6786 Do not truncate output string at its first null byte.
6787 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6788 Truncate the output at a character boundary, since vsnprintf does not
6789 do that.
6790 * charset.c (check_iso_charset_parameter): Convert internal
6791 character to string before calling 'error', since %c now has the
6792 printf meaning.
6793 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6794 overflow when computing char to be passed to 'error'. Do not
6795 pass Lisp_Object to 'error'; pass the integer instead.
6796 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6797 formatted with plain %d.
6798
b189fa66
PE
6799 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6800
bff87ef0
PE
6801 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6802
7e2cac20
PE
6803 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6804
ce4d90b5
PE
6805 * xterm.c (x_catch_errors): Remove duplicate declaration.
6806
266c9547
PE
6807 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6808
79c49ad2
PE
6809 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6810
368f4090
JM
68112011-04-10 Jim Meyering <meyering@redhat.com>
6812
6813 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6814 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6815 return ssize_t not "int", and use size_t as the buffer length.
6816 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6817 * gnutls.h: Update declarations.
6818 * process.c (read_process_output): Use ssize_t, to match.
6819 (send_process): Likewise.
6820
a32d4040
CY
68212011-04-09 Chong Yidong <cyd@stupidchicken.com>
6822
6823 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6824
8546720e 68252011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6826
04f2d78b
CB
6827 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6828 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6829
8546720e
GM
6830 * xterm.c (handle_one_xevent):
6831 * xmenu.c (create_and_show_popup_menu):
6832 * xselect.c (x_decline_selection_request)
6833 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6834
0a2f5c1a 68352011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6836
6837 Fix some uses of `int' instead of EMACS_INT.
6838 * search.c (string_match_1, fast_string_match)
6839 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6840 (scan_buffer, find_next_newline_no_quit)
6841 (find_before_next_newline, search_command, Freplace_match)
6842 (Fmatch_data): Make some `int' variables be EMACS_INT.
6843
6844 * xdisp.c (display_count_lines): 3rd argument and return value now
6845 EMACS_INT. All callers changed.
6846 (pint2hrstr): Last argument is now EMACS_INT.
6847
6848 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6849 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6850 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6851 (decode_coding_utf_16, decode_coding_emacs_mule)
6852 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6853 (decode_coding_ccl, decode_coding_charset)
6854 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6855 (decode_coding_iso_2022, decode_coding_emacs_mule)
6856 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6857 <char_offset, last_offset>: Declare EMACS_INT.
6858 (encode_coding_utf_8, encode_coding_utf_16)
6859 (encode_coding_emacs_mule, encode_invocation_designation)
6860 (encode_designation_at_bol, encode_coding_iso_2022)
6861 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6862 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6863 Declare EMACS_INT.
6864 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6865 (encode_invocation_designation): Last argument P_NCHARS is now
6866 EMACS_INT.
6867 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6868 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6869
6870 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6871 All users changed.
6872
6873 * ccl.c (Fccl_execute_on_string): Declare some variables
6874 EMACS_INT.
6875
8546720e 68762011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6877
6878 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6879
4e19a977
CS
68802011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6881
6882 * process.c (Fformat_network_address): Doc fix.
6883
87302331
R
68842011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6885
6886 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6887
cbb59342
CY
68882011-04-08 Chong Yidong <cyd@stupidchicken.com>
6889
6890 * keyboard.c (read_char): Call Lisp function help-form-show,
6891 instead of using internal_with_output_to_temp_buffer.
6892 (Qhelp_form_show): New var.
e0d38eeb 6893 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6894
6895 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6896
6897 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6898
e67a13ab
CY
68992011-04-06 Chong Yidong <cyd@stupidchicken.com>
6900
04f2d78b
CB
6901 * process.c (Flist_processes): Remove to Lisp.
6902 (list_processes_1): Delete.
e67a13ab 6903
973f782d
EZ
69042011-04-06 Eli Zaretskii <eliz@gnu.org>
6905
7c106b1e
EZ
6906 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6907
973f782d
EZ
6908 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6909
41cf7d1a 69102011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6911
ca23cc88
PE
6912 Fix more problems found by GCC 4.6.0's static checks.
6913
f390e2d5
PE
6914 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6915
42eea0d0
PE
6916 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6917
b69769da 6918 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6919
f9541e84
PE
6920 * xdisp.c (vmessage): Mark as a printf-like function.
6921
13841b55
PE
6922 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6923
c136c10f
PE
6924 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6925
5e2d4a30
PE
6926 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6927 printf-like functions.
6928 (tiff_load): Add casts to remove these marks before passing them
6929 to system-supplied API.
6930
583f48b9
PE
6931 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6932
b25d760e
PE
6933 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6934 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6935 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6936 directly, rather than having caller test rule sign. This avoids
6937 some unnecessary tests.
6938 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6939 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6940 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6941
bc7b6697 6942 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6943 (xfont_open): Avoid unnecessary tests.
bc7b6697 6944
27ccc379
PE
6945 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6946
dcd5c89a
PE
6947 * composite.h, composite.c (composition_gstring_put_cache):
6948 Use EMACS_INT, not int, for length.
6949
b13a45c6
PE
6950 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6951 breaking out part of COMPOSITION_DECODE_RULE.
6952 (COMPOSITION_DECODE_RULE): Use it.
6953 * composite.c (get_composition_id): Remove unused local vars,
6954 by using the new macro.
6955
1e792e4d
PE
6956 * textprop.c (set_text_properties_1): Change while to do-while,
6957 since the condition is always true at first.
6958
dc6c6455 6959 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6960 (interval_deletion_adjustment): Return unsigned value.
6961 All uses changed.
dc6c6455 6962
aba7731a
PE
6963 * process.c (list_processes_1, create_pty, read_process_output):
6964 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6965 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6966 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6967 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6968 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6969
fdfc4bf3
PE
6970 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6971
fca8fe46 6972 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6973 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6974
06a0259a 6975 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6976 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6977 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6978
e7b9e80f
PE
6979 * print.c (print_error_message): Avoid int overflow.
6980
56201685
PE
6981 * font.c (font_list_entities): Redo for clarity,
6982 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6983
78834453 6984 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6985 (font_score): Avoid potential overflow in diff calculation.
78834453 6986
0bc0b309 6987 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6988 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6989
e610eaca
PE
6990 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6991
b895abce
PE
6992 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6993 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6994 can always succeed if overflow has undefined behavior.
6995
1f1d9321 6996 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6997 (wordify): Omit three unnecessary tests.
1f1d9321 6998
c59478bc
PE
6999 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7000 All callers changed. This avoids the need for an unused var.
7001
79b73827
PE
7002 * casefiddle.c (casify_region): Remove var that is set but not used.
7003
a4db5dfe
PE
7004 * dired.c (file_name_completion): Remove var that is set but not used.
7005
43aae36e
PE
7006 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7007
2a47c44d 7008 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7009 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7010
a37c69bf
PE
7011 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7012 Check for integer overflow on size calculations.
7013
328ab8e7
PE
7014 * buffer.c (Fprevious_overlay_change): Remove var that is set
7015 but not used.
7016
e5a2a5cb
PE
7017 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7018 Remove vars that are set but not used.
8d84a6eb 7019 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7020 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7021
a60e5f68
PE
7022 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7023
f661cb61 7024 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7025 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7026
f0397f5a
PE
7027 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7028 that are set but not used.
7029
8664db06 7030 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7031 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7032
6abdaa4a
PE
7033 * xselect.c (x_get_local_selection, x_handle_property_notify):
7034 Remove vars that are set but not used.
7035
0ce7538d 7036 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7037 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7038
9ae848fc
PE
7039 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7040 Remove var that is set but not used.
0b918413
PE
7041 (scroll_bar_windows_size): Now size_t, not int.
7042 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7043 Check for overflow.
9ae848fc 7044
a5a62657
PE
7045 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7046 (map_tty_color) [!defined MSDOS]: Likewise.
7047
5c5cdd39
PE
7048 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7049
66ebf983
PE
7050 * coding.c: Remove vars that are set but not used.
7051 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7052 All callers changed.
7053 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7054 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7055 (decode_coding_charset): Remove vars that are set but not used.
7056
1be4d761
PE
7057 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7058 that is set but not used.
7059
47553fa8
PE
7060 * print.c (print_object): Remove var that is set but not used.
7061
1f7196bf 7062 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7063 The gnulib version avoids calling malloc in the usual case,
7064 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7065 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7066 * filelock.c (current_lock_owner): Likewise.
7067 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7068 * sysdep.c: Include allocator.h, careadlinkat.h.
7069 (emacs_no_realloc_allocator): New static constant.
7070 (emacs_readlink): New function.
fdb61804
PE
7071 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7072 ../lib/careadlinkat.h.
d1fdcab7 7073
f84c17c7
SM
70742011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7075
7076 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7077 first non-nil return value).
7078
ef3862ad
JD
70792011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7080
7081 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7082 if not defined (Bug#8403).
7083
376a7006
JB
70842011-04-02 Juanma Barranquero <lekktu@gmail.com>
7085
7086 * xdisp.c (display_count_lines): Remove parameter `start',
7087 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7088 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7089 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7090 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7091 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7092 and thereabouts. All callers changed.
7093 (get_per_char_metric): Remove parameter `f', unused since
7094 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7095
6ca3801d
JM
70962011-04-02 Jim Meyering <meyering@redhat.com>
7097
7098 do not dereference NULL upon failed strdup
7099 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7100 (ns_get_family): Likewise.
7101
d8e2b5ba
JB
71022011-04-02 Juanma Barranquero <lekktu@gmail.com>
7103
7104 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7105
8c74fcbd
JD
71062011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7107
7108 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7109 later (Bug#8403).
7110
7200d79c
SM
71112011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7112
03408648 7113 Add lexical binding.
7200d79c 7114
03408648
SM
7115 * window.c (Ftemp_output_buffer_show): New fun.
7116 (Fsave_window_excursion):
7117 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7118
7119 * lread.c (lisp_file_lexically_bound_p): New function.
7120 (Fload): Bind Qlexical_binding.
7121 (readevalloop): Remove `evalfun' arg.
7122 Bind Qinternal_interpreter_environment.
7123 (Feval_buffer): Bind Qlexical_binding.
7124 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7125 Mark as dynamic.
7126 (syms_of_lread): Declare `lexical-binding'.
7127
7128 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7129
7130 * keyboard.c (eval_dyn): New fun.
7131 (menu_item_eval_property): Use it.
ca105506
SM
7132
7133 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7134
03408648
SM
7135 * fns.c (concat, mapcar1): Accept byte-code-functions.
7136
7137 * eval.c (Fsetq): Handle lexical vars.
7138 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7139 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7140 (FletX, Flet): Obey lexical binding.
7141 (Fcommandp): Handle closures.
7142 (Feval): New `lexical' arg.
7143 (eval_sub): New function extracted from Feval. Use it almost
7144 everywhere where Feval was used. Look up vars in lexical env.
7145 Handle closures.
7146 (Ffunctionp): Move from subr.el.
7147 (Ffuncall): Handle closures.
7148 (apply_lambda): Remove `eval_flags'.
7149 (funcall_lambda): Handle closures and new byte-code-functions.
7150 (Fspecial_variable_p): New function.
7151 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7152 but without exporting it to Lisp.
23aba0ea 7153
23aba0ea 7154 * doc.c (Fdocumentation, store_function_docstring):
03408648 7155 * data.c (Finteractive_form): Handle closures.
23aba0ea 7156
03408648
SM
7157 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7158 interactive spec.
ba83908c 7159
04f2d78b
CB
7160 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7161 New byte-codes.
03408648
SM
7162 (exec_byte_code): New function extracted from Fbyte_code to handle new
7163 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7164
03408648 7165 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7166
03408648 7167 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7168
e2abce01
JB
71692011-03-31 Juanma Barranquero <lekktu@gmail.com>
7170
7171 * xdisp.c (redisplay_internal): Fix prototype.
7172
63696a73 71732011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7174
63696a73 7175 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7176 (try_scrolling): Use it when setting scroll_limit.
7177 Limit scrolling to 100 screen lines.
63696a73
EZ
7178 (redisplay_window): Even when falling back on "recentering",
7179 position point in the window according to scroll-conservatively,
7180 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7181
7182 (try_scrolling): When point is above the window, allow searching
7183 as far as scroll_max, or one screenful, to compute vertical
7184 distance from PT to the scroll margin position. This prevents
7185 try_scrolling from unnecessarily failing when
7186 scroll-conservatively is set to a value slightly larger than the
7187 window height. Clean up the case of PT below the margin at bottom
7188 of window: scroll_max can no longer be INT_MAX. When aggressive
7189 scrolling is in use, don't let point enter the opposite scroll
7190 margin as result of the scroll.
7191 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7192 threshold of 100 lines for never-recentering scrolling.
7193
e4cc2dfc
JB
71942011-03-31 Juanma Barranquero <lekktu@gmail.com>
7195
7196 * dispextern.h (move_it_by_lines):
7197 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7198 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7199 (message_log_check_duplicate): Remove parameters `prev_bol' and
7200 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7201 (redisplay_internal): Remove parameter `preserve_echo_area',
7202 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7203
7204 * indent.c (Fvertical_motion):
7205 * window.c (window_scroll_pixel_based, Frecenter):
7206 Don't pass `need_y_p' to `move_it_by_lines'.
7207
1c470562
SM
72082011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7209
44f230aa
SM
7210 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7211 steal a few bits to be more compact.
7212 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7213 Remove unneeded casts.
7214
1c470562
SM
7215 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7216
888adce9
ZK
72172011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7218
7219 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7220 binding" message (bug#7967).
7221
f838ed7b
PE
72222011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7223
77861b95
PE
7224 Fix more problems found by GCC 4.6.0's static checks.
7225
de6dbc14
PE
7226 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7227 Remove unused local var.
7228
f838ed7b
PE
7229 * editfns.c (Fmessage_box): Remove unused local var.
7230
792c7b2b
PE
7231 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7232 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7233 Omit unused local vars.
c499e557 7234 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7235 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7236 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7237 Omit unused local var.
7238
ba0165e1
PE
7239 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7240 Don't assume string length fits in int.
32ad8845 7241 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7242 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7243
3c59b4c9
PE
7244 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7245 instead of alloca (Bug#8344).
7246
a3eed478 7247 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7248 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7249
eb4d412d
PE
7250 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7251
1658b401
PE
7252 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7253 concerns.
7254
7255 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7256
7257 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7258
9a2c6e05
PE
7259 * keyboard.c (syms_of_keyboard): Use the same style as later
7260 in this function when indexing through an array. This also
7261 works around GCC bug 48267.
7262
03d0a109
PE
7263 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7264
44f730c8
PE
7265 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7266
fe75f926
PE
7267 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7268 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7269
ffa8c828
PE
7270 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7271 This avoids undefined behavior on integer overflow, and is a bit
7272 more convenient anyway since it is compared to a size_t variable.
7273
c5101a77
PE
7274 Variadic C functions now count arguments with size_t, not int.
7275 This avoids an unnecessary limitation on 64-bit machines, which
7276 caused (substring ...) to crash on large vectors (Bug#8344).
7277 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7278 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7279 All variadic functions and their callers changed accordingly.
c5101a77
PE
7280 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7281 * data.c (arith_driver, float_arith_driver): Likewise.
7282 * editfns.c (general_insert_function): Likewise.
7283 * eval.c (struct backtrace.nargs, interactive_p)
7284 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7285 (funcall_lambda, mark_backtrace): Likewise.
7286 * fns.c (concat): Likewise.
7287 * frame.c (x_set_frame_parameters): Likewise.
7288 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7289 0 if not found, not -1. All callers changed.
7290
dd3f25f7
PE
7291 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7292 (stack_copy_size): Now size_t, not int.
7293 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7294
461c2ab9
JB
72952011-03-28 Juanma Barranquero <lekktu@gmail.com>
7296
7297 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7298 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7299 All callers changed.
7300
7301 * lisp.h (multibyte_char_to_unibyte):
7302 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7303 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7304 * character.h (CHAR_TO_BYTE8):
7305 * cmds.c (internal_self_insert):
7306 * editfns.c (general_insert_function):
7307 * keymap.c (push_key_description):
7308 * search.c (Freplace_match):
7309 * xdisp.c (message_dolog, set_message_1): All callers changed.
7310
f6d62986
SM
73112011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7312
7313 * keyboard.c (safe_run_hook_funcall): New function.
7314 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7315 don't set the hook to nil, but remove the offending function instead.
7316 (Qcommand_hook_internal): Remove, unused.
7317 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7318 Vcommand_hook_internal.
7319
7320 * eval.c (enum run_hooks_condition): Remove.
7321 (funcall_nil, funcall_not): New functions.
7322 (run_hook_with_args): Call each function through a `funcall' argument.
7323 Remove `cond' argument, now redundant.
7324 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7325 (Frun_hook_with_args_until_failure): Adjust accordingly.
7326 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7327
1db5b1ad
JB
73282011-03-28 Juanma Barranquero <lekktu@gmail.com>
7329
7330 * dispextern.h (string_buffer_position): Remove declaration.
7331
7332 * print.c (strout): Remove parameter `multibyte', unused since
7333 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7334
7335 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7336 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7337 All callers changed.
7338
7339 * w32.c (_wsa_errlist): Use braces for struct initializers.
7340
7341 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7342 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7343 All callers changed.
7344 (string_buffer_position): Likewise. Also, make static (it's never
7345 used outside xdisp.c).
7346 (cursor_row_p): Remove parameter `w', unused since
7347 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7348 (decode_mode_spec): Remove parameter `precision', introduced during
7349 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7350 All callers changed.
7351
5ffb62aa
JD
73522011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7353
7354 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7355
461c2ab9 73562011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7357
7358 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7359 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7360 (ns_update_auto_hide_menu_bar): New functions.
7361 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7362 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7363 ns_constrain_all_frames.
7364 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7365 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7366
5c380ffb
JD
73672011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7368
7369 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7370
9af30bdf
GM
73712011-03-27 Glenn Morris <rgm@gnu.org>
7372
7373 * syssignal.h: Replace RETSIGTYPE with void.
7374 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7375 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7376 Replace SIGTYPE with void everywhere.
7377 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7378 * s/template.h (SIGTYPE): Remove commented out definition.
7379
e2abce01
JB
73802011-03-26 Eli Zaretskii <eliz@gnu.org>
7381
7382 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7383 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7384
f868cd8a
JB
73852011-03-26 Juanma Barranquero <lekktu@gmail.com>
7386
59eb0929
JB
7387 * w32.c (read_unc_volume): Use parameter `henum', instead of
7388 global variable `wget_enum_handle'.
7389
7390 * keymap.c (describe_vector): Remove parameters `indices' and
7391 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7392 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7393
f868cd8a
JB
7394 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7395
7396 * keyboard.c (timer_check): Remove parameter `do_it_now',
7397 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7398 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7399 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7400
7401 * keyboard.c (read_char):
7402 * w32menu.c (w32_menu_display_help):
7403 * xmenu.c (show_help_event, menu_help_callback):
7404 Adjust calls to `show_help_echo'.
7405
7406 * gtkutil.c (xg_maybe_add_timer):
7407 * keyboard.c (readable_events):
7408 * process.c (wait_reading_process_output):
7409 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7410
7411 * insdel.c (adjust_markers_gap_motion):
7412 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7413 (gap_left, gap_right): Don't call it.
7414
2ecf6fdb
CY
74152011-03-25 Chong Yidong <cyd@stupidchicken.com>
7416
7417 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7418 incurred during fontification.
7419
6b1f9ba4
JB
74202011-03-25 Juanma Barranquero <lekktu@gmail.com>
7421
7422 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7423 (DEFVAR_PER_BUFFER): Don't pass it.
7424
7425 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7426 (scrolling_window): Don't pass it.
7427
0f4a96b5
JB
74282011-03-25 Juanma Barranquero <lekktu@gmail.com>
7429
7430 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7431
7432 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7433 and `suffix'.
7434 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7435 of variables specific to SELinux and computation of `encoded_absname'.
7436
7437 * image.c (XPutPixel): Remove unused variable `height'.
7438
7439 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7440
7441 * unexw32.c (get_section_info): Remove unused variable `section'.
7442
7443 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7444 (system_process_attributes): Remove unused variable `sess'.
7445 (sys_read): Remove unused variable `err'.
7446
7447 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7448 (w32_wnd_proc): Remove unused variable `isdead'.
7449 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7450 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7451 (x_create_tip_frame): Remove unused variable `tem'.
7452
7453 * w32inevt.c (w32_console_read_socket):
7454 Remove unused variable `no_events'.
7455
7456 * w32term.c (x_draw_composite_glyph_string_foreground):
7457 Remove unused variable `width'.
7458
1149507c
JB
74592011-03-24 Juanma Barranquero <lekktu@gmail.com>
7460
7461 * w32term.c (x_set_glyph_string_clipping):
7462 Don't pass uninitialized region to CombineRgn.
7463
9c88f339
JB
74642011-03-23 Juanma Barranquero <lekktu@gmail.com>
7465
7466 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7467 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7468 (Fx_close_connection): Remove unused variable `i'.
7469
7470 * w32font.c (w32font_draw): Return number of glyphs.
7471 (w32font_open_internal): Remove unused variable `i'.
7472 (w32font_driver): Add missing initializer.
7473
7474 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7475 (fill_in_menu): Remove unused variable `items_added'.
7476
7477 * w32term.c (last_mouse_press_frame): Remove static global variable.
7478 (w32_clip_to_row): Remove unused variable `f'.
7479 (x_delete_terminal): Remove unused variable `i'.
7480
7481 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7482 (NOTHING): Remove unused static global variable.
7483 (uniscribe_check_otf): Remove unused variable `table'.
7484 (uniscribe_font_driver): Add missing initializers.
7485
dee091a3
JD
74862011-03-23 Julien Danjou <julien@danjou.info>
7487
7488 * term.c (Fsuspend_tty, Fresume_tty):
7489 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7490 * window.c (temp_output_buffer_show):
7491 * insdel.c (signal_before_change):
7492 * frame.c (Fhandle_switch_frame):
7493 * fileio.c (Fdo_auto_save):
7494 * emacs.c (Fkill_emacs):
7495 * editfns.c (save_excursion_restore):
7496 * cmds.c (internal_self_insert):
7497 * callint.c (Fcall_interactively):
7498 * buffer.c (Fkill_all_local_variables):
7499 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7500 Use Frun_hooks.
0f4a96b5 7501 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7502 unconditionnaly since it does the check itself.
7503
2c520ab5 75042011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7505
c9c49752
PE
7506 Fix more problems found by GCC 4.5.2's static checks.
7507
8abc3f12
PE
7508 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7509 the first time through the loop, since we know p0 < p1 then.
7510 This also avoids a gcc -Wstrict-overflow warning.
7511
a2d26660
PE
7512 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7513 leading to a memory leak, possible in functions like
7514 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7515 of objects (Bug#8318).
a2d26660 7516
916c72e9
PE
7517 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7518 that could (at least in theory) be that large.
7519
19ab8a18
PE
7520 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7521 This is less likely to overflow, and avoids undefined behavior if
7522 overflow does occur. All callers changed. Use strtoul to scan
7523 for the unsigned long integer.
b7cbbd6f
PE
7524 (pint2hrstr): Simplify and tune code slightly.
7525 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7526
f0641eff
PE
7527 * scroll.c (do_scrolling): Work around GCC bug 48228.
7528 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7529
7f650bb9
PE
7530 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7531 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7532 (validate_x_resource_name): Simplify count usage.
7533 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7534
37dd57d1
PE
7535 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7536 fail (Bug#8306).
81e56e61 7537
699979fc 7538 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7539
401bf9b4
PE
7540 * process.c (Fmake_network_process): Use socklen_t, not int,
7541 where POSIX says socklen_t is required in portable programs.
7542 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7543 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7544 (Fmake_network_process, server_accept_connection):
7545 (wait_reading_process_output, read_process_output):
7546 Likewise.
7547
b93aacde
PE
7548 * process.c: Rename or move locals to avoid shadowing.
7549 (list_processes_1, Fmake_network_process):
7550 (read_process_output_error_handler, exec_sentinel_error_handler):
7551 Rename or move locals.
4dc343ee 7552 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7553 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7554 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7555 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7556 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7557
af8a867c 7558 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7559 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7560 Include tparam.h instead, since it declares them.
af8a867c
PE
7561 * cm.h (PC): Remove extern decl; tparam.h now does this.
7562 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7563 * terminfo.c: Include tparam.h, to check interfaces.
7564 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7565 (tparam): Adjust signature to match interface in tparam.h;
7566 this removes some undefined behavior. Check that outstring and len
7567 are zero, which they always are with Emacs.
7568 * tparam.h (PC, BC, UP): New extern decls.
7569
0248044d 7570 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7571 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7572
8ff096c1 7573 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7574 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7575 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7576 (ftfont_list): Remove unused local.
49eaafba
PE
7577 (get_adstyle_property, ftfont_pattern_entity):
7578 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7579 Rename locals to avoid shadowing.
8ff096c1 7580
e2be39f6
PE
7581 * xfont.c (xfont_list_family): Mark var as initialized.
7582
c9735e30
PE
7583 * xml.c (make_dom): Now static.
7584
8f5201ae
PE
7585 * composite.c (composition_compute_stop_pos): Rename local to
7586 avoid shadowing.
b246f932
PE
7587 (composition_reseat_it): Remove unused locals.
7588 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7589 (composition_update_it): Mark var as initialized.
11b61122
PE
7590 (find_automatic_composition): Mark vars as initialized,
7591 with a FIXME (Bug#8290).
8f5201ae 7592
760fbc2c
PE
7593 character.h: Rename locals to avoid shadowing.
7594 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7595 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7596 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7597 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7598 to avoid shadowing.
7599
ff08eb85
PE
7600 * textprop.c (property_change_between_p): Remove; unused.
7601
fc7bf025
PE
7602 * intervals.c (interval_start_pos): Now static.
7603
235d7abc
PE
7604 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7605
44f230aa
SM
7606 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7607 Rename locals to avoid shadowing.
3e7d6594 7608
50060332
PE
7609 * sound.c (wav_play, au_play, Fplay_sound_internal):
7610 Fix pointer signedness.
d01f234b 7611 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7612 (wav_play): Initialize a variable to 0, to prevent undefined
7613 behavior (Bug#8278).
50060332 7614
c4fc4e30
PE
7615 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7616
918436ed
PE
7617 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7618
c939f91b
PE
7619 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7620 clobbering (Bug#8298).
b9c7f648
PE
7621 * sysdep.c (sys_subshell): Likewise.
7622 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7623
6bd8c144
PE
7624 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7625 This should get cleaned up, so that child_setup has the
7626 same signature on all platforms.
7627
7710357c 7628 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7629 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7630
c59da222
CY
76312011-03-22 Chong Yidong <cyd@stupidchicken.com>
7632
7633 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7634 not to be necessary, and produces flickering.
7635
66b87493
GM
76362011-03-20 Glenn Morris <rgm@gnu.org>
7637
7638 * config.in: Remove file.
7639
45b6f6d5
JB
76402011-03-20 Juanma Barranquero <lekktu@gmail.com>
7641
7642 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7643 are now in src/globals.h.
7644 (syms_of_minibuf): Remove spurious & from previous change.
7645
3ec03f7e
LL
76462011-03-20 Leo <sdl.web@gmail.com>
7647
7648 * minibuf.c (completing-read-function): New variable.
7649 (completing-read-default): Rename from completing-read.
7650 (completing-read): Call completing-read-function.
7651
b14e3e21
CY
76522011-03-19 Juanma Barranquero <lekktu@gmail.com>
7653
7654 * xfaces.c (Fx_load_color_file):
7655 Read color file from absolute filename (bug#8250).
7656
f2b726e6
JB
76572011-03-19 Juanma Barranquero <lekktu@gmail.com>
7658
7659 * makefile.w32-in: Update dependencies.
7660
09f6ff02
EZ
76612011-03-17 Eli Zaretskii <eliz@gnu.org>
7662
7663 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7664
29a6015a
PE
76652011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7666
a3a6c54e
PE
7667 Fix more problems found by GCC 4.5.2's static checks.
7668
b766f867
PE
7669 * process.c (make_serial_process_unwind, send_process_trap):
7670 (sigchld_handler): Now static.
7671
be02381c
PE
7672 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7673 That way, the code declares only the vars that it needs.
7674 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7675 * s/cygwin.h (PTY_ITERATION): Likewise.
7676 * s/darwin.h (PTY_ITERATION): Likewise.
7677 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7678
57048744
PE
7679 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7680 * process.c (allocate_pty): Don't declare stb unless it's needed.
7681
7914961c 7682 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7683 (CONSTANTLIM): Remove; unused.
7684 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7685 Define only if needed.
7914961c 7686
b3967b18
PE
7687 * unexelf.c (unexec): Name an expression,
7688 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7689 Use a different way to cause a compilation error if anyone uses
7690 n rather than nn, a way that does not involve shadowing.
73366a00 7691 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7692
29a6015a
PE
7693 * deps.mk (unexalpha.o): Remove; unused.
7694
43cfc33e 7695 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7696 * unexec.h: New file.
ce701a33
PE
7697 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7698 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7699 Depend on unexec.h.
7700 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7701 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7702 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7703 Change as necessary to match prototype in unexec.h.
ce701a33 7704
01f44d5a
PE
7705 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7706 shadowing.
4f63c6bb 7707 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7708
a6670b0b
PE
7709 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7710 Rename locals to avoid shadowing.
7711
cef2010d 7712 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7713 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7714
d4d7173a
PE
7715 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7716
f08b802a
PE
7717 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7718 warning when compiling print.c.
7719
3ddb0639
PE
7720 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7721 instead of using an uninitialized var.
5ad03b97 7722 (font_sort_entities): Mark var as initialized.
3ddb0639 7723
170a2692
PE
7724 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7725
e663c700
PE
7726 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7727 pointers to constants.
89bc529a 7728 (font_parse_fcname): Remove unused vars.
7b81e2d0 7729 (font_delete_unmatched): Now static.
ea838e10 7730 (font_get_spec): Remove; unused.
13a547c6
PE
7731 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7732 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7733 Rename or move locals to avoid shadowing.
e663c700 7734
2a80c887 7735 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7736 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7737
1384fa33 7738 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7739 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7740
8b2c52e9
PE
7741 * alloc.c (mark_backtrace): Move decl from here ...
7742 * lisp.h: ... to here, so that it can be checked.
7743
475545b5 7744 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7745 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7746 (lisp_indirect_variable): Name an expression,
7747 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7748 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7749
b1349114 7750 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7751 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7752 Use const pointer when appropriate.
b1349114 7753
a2928364
PE
7754 * lisp.h (get_system_name, get_operating_system_release):
7755 Move decls here, to check interfaces.
7756 * process.c (get_operating_system_release): Move decl to lisp.h.
7757 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7758 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7759 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7760 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7761 (Fformat_time_string, Fencode_time, Finsert_char):
7762 (Ftranslate_region_internal, Fformat):
7763 Rename or remove local vars to avoid shadowing.
9710023e 7764 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7765
a415e694
PE
7766 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7767 avoid shadowing.
7768
8ef4622d
PE
7769 * lisp.h (eassert): Check that the argument compiles, even if
7770 ENABLE_CHECKING is not defined.
7771
946f9a5b
PE
7772 * data.c (Findirect_variable): Name an expression, to avoid
7773 gcc -Wbad-function-cast warning.
112396d6 7774 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7775 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7776 (Fmake_variable_buffer_local, Fmake_local_variable):
7777 Mark variables as initialized.
52746918 7778 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7779
e5aab7e7 7780 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7781 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7782 Rename locals to avoid shadowing.
dff45157
PE
7783 (mark_stack): Move local variables into the #ifdef region where
7784 they're used.
7bc26fdb
PE
7785 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7786 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7787 needed otherwise.
7788 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7789 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7790 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7791
e5aab7e7
PE
7792 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7793 avoids undefined behavior in theory.
7794
4da60324
PE
7795 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7796
88043301
PE
7797 Use functions, not macros, for up- and down-casing (Bug#8254).
7798 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7799 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7800 to use the following functions instead of these macros.
7801 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7802 EMACS_INT, since callers assume the returned value fits in int.
7803 (upcase1): Likewise, for UPCASE_TABLE.
7804 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7805 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7806 the race-condition problem in the old DOWNCASE.
88043301 7807
19ed5445
PE
7808 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7809 Rename locals to avoid shadowing.
7810 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7811 (regex_compile, re_search_2, re_match_2_internal):
7812 Remove unused local vars.
952db0d7
PE
7813 (FREE_VAR): Rewrite so as not to use empty "else",
7814 which gcc can warn about.
da053e48 7815 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7816 (RETALLOC_IF): Define only if needed.
7817 (WORDCHAR_P): Likewise. This one is never needed, but is used
7818 only in a comment talking about a compiler bug, so put inside
7819 the #if 0 of that comment.
7820 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7821 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7822 Remove; unused.
19ed5445 7823
1f3561e4 7824 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7825 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7826 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7827
ded6f8f7
PE
7828 * search.c (simple_search): Remove unused var.
7829
dbd37a95
PE
7830 * dired.c (compile_pattern): Move decl from here ...
7831 * lisp.h: ... to here, so that it can be checked.
7832 (struct re_registers): New forward decl.
7833
7e47afad
PE
7834 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7835
85f24f61
PE
7836 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7837 All uses changed.
7838 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7839 Rename locals to avoid shadowing.
5671df8f 7840 (Fvertical_motion): Mark locals as initialized.
85f24f61 7841
181aa2be 7842 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7843 (casify_region): Mark local as initialized.
181aa2be 7844
930d429c
PE
7845 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7846
7082eac6
PE
7847 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7848 New macros, so that the caller can use some names other than
7849 gcpro1, gcpro2, etc.
7850 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7851 of the new macros.
7852 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7853 argument, for consistency with GCPRO2_VAR, etc: it is now the
7854 prefix of the variable, not the variable itself. All uses
7855 changed.
38b2c076
PE
7856 * dired.c (directory_files_internal, file_name_completion):
7857 Rename locals to avoid shadowing.
7858
15206ed9
PE
7859 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7860 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7861 dired.c's scmp function, had undefined behavior.
7862 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7863 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7864 * buffer.h: ... to here, because these macros use current_buffer,
7865 and the new implementation with inline functions needs to have
7866 current_buffer in scope now, rather than later when the macros
7867 are used.
7868 (downcase, upcase1): New static inline functions.
7869 (DOWNCASE, UPCASE1): Reimplement using these functions.
7870 This avoids undefined behavior in expressions like
7871 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7872 from race conditions in accessing the global variables
7873 case_temp1 and case_temp2.
7874 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7875 * lisp.h (case_temp1, case_temp2): Remove their decls.
7876 * character.h (ASCII_CHAR_P): Move from here ...
7877 * lisp.h: ... to here, so that the inline functions mentioned
7878 above can use them.
7879
4a6bea26
PE
7880 * dired.c (directory_files_internal_unwind): Now static.
7881
f14b7e14
PE
7882 * fileio.c (file_name_as_directory, directory_file_name):
7883 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7884 Now static.
2893f146
PE
7885 (file_name_as_directory): Use const pointers when appropriate.
7886 (Fexpand_file_name): Likewise. In particular, newdir might
7887 point at constant storage, so make it a const pointer.
fd4ead52 7888 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7889 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7890 signedness issues.
f839df0c
PE
7891 (Fset_file_times, Finsert_file_contents, auto_save_error):
7892 Rename locals to avoid shadowing.
f14b7e14 7893
5716756e 7894 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7895 (Ftry_completion, Fall_completions): Rename or remove locals
7896 to avoid shadowing.
5716756e 7897
b4c3046a
PE
7898 * marker.c (bytepos_to_charpos): Remove; unused.
7899
b45db522
PE
7900 * lisp.h (verify_bytepos, count_markers): New decls,
7901 so that gcc does not warn that these functions aren't declared.
7902
85876d07
PE
7903 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7904 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7905 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7906 (copy_text): Remove unused local var.
85876d07 7907
03d78a21 7908 * filelock.c (within_one_second): Now static.
b3dd38ab 7909 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7910
5df8f01b
PE
7911 * buffer.c (fix_overlays_before): Mark locals as initialized.
7912 (fix_start_end_in_overlays): Likewise. This function should be
7913 simplified by using pointers-to-pointers, but that's a different
7914 matter.
b1d876f1 7915 (switch_to_buffer_1): Now static.
8f54f30a
PE
7916 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7917 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7918
a70072c9 7919 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7920 Fix pointer signedness issue.
edced198
PE
7921 (sys_subshell): Mark local as volatile if checking for lint,
7922 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7923 (MAXPATHLEN): Define only if needed.
a70072c9 7924
a0977c44
PE
7925 * process.c (serial_open, serial_configure): Move decls from here ...
7926 * systty.h: ... to here, so that they can be checked.
7927
a884fdcc
PE
7928 * fns.c (get_random, seed_random): Move extern decls from here ...
7929 * lisp.h: ... to here, so that they can be checked.
7930
604efe86 7931 * sysdep.c (reset_io): Now static.
b8950c94 7932 (wait_for_termination_signal): Remove; unused.
604efe86 7933
38fc62d9
PE
7934 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7935 (copy_keymap_item, append_key, push_text_char_description):
7936 Now static.
1004a21a 7937 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7938 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7939 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7940 (describe_map_tree):
7941 Rename locals to avoid shadowing.
38fc62d9 7942
2f2650da
PE
7943 * keyboard.c: Declare functions static if they are not used elsewhere.
7944 (echo_char, echo_dash, cmd_error, top_level_2):
7945 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7946 (read_char, kbd_buffer_get_event, make_lispy_position):
7947 (make_lispy_event, make_lispy_movement, apply_modifiers):
7948 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7949 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7950 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7951 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7952 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7953
a053e86c 7954 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7955 (mark_kboards): Move decl here ...
7956 * alloc.c (mark_kboards): ... from here.
a053e86c 7957
4752793e
PE
7958 * lisp.h (force_auto_save_soon): New decl.
7959
74f10ca7 7960 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7961 (DEFINE_DUMMY_FUNCTION): New macro.
7962 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7963 Use it.
c03cd23f
PE
7964 (main): Add casts to avoid warnings
7965 if GCC considers string literals to be constants.
74f10ca7 7966
022e70d4
PE
7967 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7968
59d6fe83
PE
7969 * dbusbind.c: Pointer signedness fixes.
7970 (xd_signature, xd_append_arg, xd_initialize):
7971 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7972 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7973 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7974 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7975
78320123
PE
7976 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7977 if GCC considers string literals to be constants.
49cebcca 7978 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7979
35ac2a97
SM
79802011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7981
fb103ca9
SM
7982 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7983 (print_preprocess, print_object): New macro to fix last change.
7984
35ac2a97
SM
7985 * print.c (print_preprocess): Don't forget font objects.
7986
62973b41
JB
79872011-03-16 Juanma Barranquero <lekktu@gmail.com>
7988
7989 * emacs.c (USAGE3): Doc fixes.
7990
0e48bb22
AS
79912011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7992
7993 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7994 structure.
7995
7684e57b
JB
79962011-03-14 Juanma Barranquero <lekktu@gmail.com>
7997
7998 * lisp.h (VWindow_system, Qfile_name_history):
7999 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8000 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8001 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8002
8003 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8004 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8005
8006 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8007 * w32console.c (detect_input_pending, read_input_pending)
8008 (encode_terminal_code):
8009 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8010 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8011 (w32_system_caret_y, Qfile_name_history):
8012 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8013 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8014 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8015 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8016 * w32proc.c (Qlocal, report_file_error):
8017 * w32term.c (Vwindow_system, updating_frame):
8018 * w32uniscribe.c (initialized, uniscribe_font_driver):
8019 Remove unneeded extern declarations.
8020
2aa46d6c
CY
80212011-03-14 Chong Yidong <cyd@stupidchicken.com>
8022
c96bbc66 8023 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8024
cffc6f3b
CY
80252011-03-13 Chong Yidong <cyd@stupidchicken.com>
8026
8027 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8028 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8029 These macros can no longer be used for assignment.
8030
44f230aa
SM
8031 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8032 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8033 (record_buffer_markers, fetch_buffer_markers): New functions for
8034 recording and fetching special buffer markers.
8035 (set_buffer_internal_1, set_buffer_temp): Use them.
8036
8037 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8038
8039 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8040
8041 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8042 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8043
8044 * xdisp.c (hscroll_window_tree):
8045 (reconsider_clip_changes): Use PT instead of BUF_PT.
8046
d251f04b
EZ
80472011-03-13 Eli Zaretskii <eliz@gnu.org>
8048
8049 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8050 $(EMACS_ROOT)/lib/intprops.h.
8051
f0c77cd1
PE
80522011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8053
3eca4629
PE
8054 Fix more problems found by GCC 4.5.2's static checks.
8055
7c86ee98
PE
8056 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8057 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8058 (xg_free_frame_widgets): Make it clear that a local variable is
8059 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8060 (gdk_window_get_screen): Make it clear that this macro is needed
8061 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8062 (int_gtk_range_get_value): New function, which avoids a diagnostic
8063 from gcc -Wbad-function-cast.
8064 (xg_set_toolkit_scroll_bar_thumb): Use it.
8065 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8066 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8067 (get_utf8_string, xg_get_file_with_chooser):
8068 Rename locals to avoid shadowing.
8069 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8070
41729b81
PE
8071 * xgselect.c (xg_select): Remove unused var.
8072
f0c77cd1
PE
8073 * image.c (four_corners_best): Mark locals as initialized.
8074 (gif_load): Initialize transparent_p to zero (Bug#8238).
8075 Mark another local as initialized.
ec6cf4c6 8076 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8077
ce0ad53d 8078 * image.c (clear_image_cache): Now static.
d5d5a617 8079 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8080 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8081 (x_edge_detection): Remove unnecessary cast that
8082 gcc -Wbad-function-cast diagnoses.
2037898d 8083 (gif_load): Fix pointer signedness.
6ae141d6
PE
8084 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8085 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8086
33383987 80872011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8088
d32df629
PE
8089 Improve quality of tests for time stamp overflow.
8090 For example, without this patch (encode-time 0 0 0 1 1
8091 1152921504606846976) returns the obviously-bogus value (-948597
8092 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8093 reports time overflow. See
8094 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8095 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8096 * editfns.c: Include limits.h and intprops.h.
8097 (TIME_T_MIN, TIME_T_MAX): New macros.
8098 (time_overflow): Move earlier, to before first use.
8099 (hi_time, lo_time): New functions, for an accurate test for
8100 out-of-range times.
8101 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8102 (Fget_internal_run_time): Don't assume time_t fits in int.
8103 (make_time): Use list2 instead of Fcons twice.
8104 (Fdecode_time): More accurate test for out-of-range times.
8105 (check_tm_member): New function.
8106 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8107 (lisp_time_argument): Don't rely on undefined left-shift and
8108 right-shift behavior when checking for time stamp overflow.
8be6f318 8109
fe31d94c
PE
8110 * editfns.c (time_overflow): New function, refactoring common code.
8111 (Fformat_time_string, Fdecode_time, Fencode_time):
8112 (Fcurrent_time_string): Use it.
8113
8be6f318
PE
8114 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8115 * dired.c (make_time): Move to ...
8116 * editfns.c (make_time): ... here.
8117 * systime.h: Note the move.
8118
09d9db2c 81192011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8120
126bc0dc
YM
8121 * fringe.c (update_window_fringes): Remove unused variables.
8122
c47cbdfd
YM
8123 * unexmacosx.c (copy_data_segment): Also copy __got section.
8124 (Bug#8223)
8125
7ac80be9
EZ
81262011-03-12 Eli Zaretskii <eliz@gnu.org>
8127
c96bbc66 8128 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8129 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8130 Constify `char *' arguments and their references according to
8131 prototypes in tparam.h.
8132
ecb0f94d 8133 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8134
7ac80be9
EZ
8135 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8136 Adapt all references accordingly.
8137
8138 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8139
ef1fd07e
TT
81402011-03-11 Tom Tromey <tromey@redhat.com>
8141
8142 * buffer.c (syms_of_buffer): Remove obsolete comment.
8143
7ef4b50c
EZ
81442011-03-11 Eli Zaretskii <eliz@gnu.org>
8145
8146 * termhooks.h (encode_terminal_code): Declare prototype.
8147
8148 * msdos.c (encode_terminal_code): Don't declare prototype.
8149
8150 * term.c (encode_terminal_code): Now external again, used by
8151 w32console.c and msdos.c.
8152
44f230aa
SM
8153 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8154 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8155
4b1ec863 81562011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8157
1714f52b 8158 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8159
4b1ec863
PE
8160 * fringe.c (update_window_fringes): Mark locals as initialized
8161 (Bug#8227).
8162 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8163
524c7aa6
PE
8164 * alloc.c (mark_fringe_data): Move decl from here ...
8165 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8166 to check its interface.
8167 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8168
a5c0af81 8169 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8170 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8171 (fontset_font): Mark local as initialized.
a9a06e0b 8172 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8173
b4716021
PE
8174 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8175
811e9bac 8176 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8177 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8178 (x_own_selection, Fx_disown_selection_internal): Rename locals
8179 to avoid shadowing.
8180 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8181
7e3ab302
PE
8182 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8183 so that the caller can use some name other than gcpro1.
8184 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8185 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8186 (Fx_backspace_delete_keys_p):
8187 Use them to avoid shadowing, and rename vars to avoid shadowing.
8188 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8189 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8190 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8191 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8192 Remove unused locals.
7e3ab302
PE
8193 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8194 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8195 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8196 macros.
f78faa98 8197
e2b13473
PE
8198 * xterm.h (x_mouse_leave): New decl.
8199
77f23912
PE
8200 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8201 Remove unused functions.
cdf4ba58
PE
8202 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8203 (x_calc_absolute_position): Now static.
7411c686 8204 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8205 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8206 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8207 unless they are used.
38d0b34a
PE
8208 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8209 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8210 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8211 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8212 (x_error_catcher, x_connection_closed, x_error_handler):
8213 (x_error_quitter, xembed_send_message, x_iconify_frame):
8214 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8215 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8216 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8217
44f230aa
SM
8218 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8219 Rename or move locals to avoid shadowing.
6b463e58 8220 (tty_defined_color, merge_face_heights): Now static.
5967d051 8221 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8222 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8223 does not deduce is never used uninitialized.
73719eba
PE
8224 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8225 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8226
426994c3 8227 * terminal.c (store_terminal_param): Now static.
5489860b 8228
032f1620 8229 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8230 (set_frame_menubar): Remove unused local.
d4323972 8231 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8232 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8233 since they might point to immutable storage.
281585b0
PE
8234 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8235 since it's unused otherwise.
032f1620 8236
367c19e5 8237 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8238 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8239 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8240 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8241 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8242 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8243 does not deduce are never used uninitialized.
70739cbe 8244
07b48fa9
PE
8245 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8246
8868a238 8247 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8248 * window.c (window_loop, size_window):
8249 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8250
7e5cf297 8251 * window.c (display_buffer): Now static.
d6550a9f
PE
8252 (size_window): Mark variables that gcc -Wuninitialized
8253 does not deduce are never used uninitialized.
a586633d
PE
8254 * window.h (check_all_windows): New decl, to forestall
8255 gcc -Wmissing-prototypes diagnostic.
5b555da1 8256 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8257
f6095868
PE
8258 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8259 shadowing.
8260 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8261 Include <limits.h>.
8262 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8263 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8264 (load_charset_map): Mark variables that gcc -Wuninitialized
8265 does not deduce are never used uninitialized.
53df7c11 8266 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8267
f38b440c
PE
8268 * coding.c (coding_set_source, coding_set_destination):
8269 Use "else { /* comment */ }" rather than "else /* comment */;"
8270 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8271 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8272 a block, when the outer 'i' will do.
8273 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8274 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8275 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8276 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8277 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8278 Rename locals to avoid shadowing.
8279 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8280 * coding.c (emacs_mule_char, encode_invocation_designation):
8281 Now static, since they're not used elsewhere.
413bb2db 8282 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8283 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8284 (decode_coding_emacs_mule): Mark variables that gcc
8285 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8286 (detect_coding_iso_2022): Initialize a local variable that might
8287 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8288 this initialization is needed. (Bug#8211)
5f58e762
PE
8289 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8290 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8291 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8292 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8293 Remove unused macros.
f38b440c 8294
232b38b9 8295 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8296 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8297 * character.c (string_count_byte8): Likewise.
232b38b9 8298
fb90da1b
PE
8299 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8300 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8301
fb93dbc2
PE
8302 * chartab.c (copy_sub_char_table): Now static, since it's not used
8303 elsewhere.
5c156ace
PE
8304 (sub_char_table_ref_and_range, char_table_ref_and_range):
8305 Rename locals to avoid shadowing.
bbcd0949 8306 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8307
7d3b3862 8308 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8309 (BIDI_BOB): Remove unused macro.
7d3b3862 8310
6be7d3da
PE
8311 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8312 deduce are never used uninitialized.
c2ed9c8b 8313 * term.c (encode_terminal_code): Likewise.
6be7d3da 8314
75f8807f 8315 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8316
50938595
PE
8317 * tparam.h: New file.
8318 * term.c, tparam.h: Include it.
8319 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8320 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8321 Move these decls to tparam.h, and make them agree with what
8322 is actually in tparam.c. The previous trick of using incompatible
8323 decls in different modules does not conform to the C standard.
8324 All callers of tparam changed to use tparam's actual API.
8325 * tparam.c (tparam1, tparam, tgoto):
8326 Use const pointers where appropriate.
8327
fbceeba2
PE
8328 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8329 * cm.h (struct cm): Likewise.
8330 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8331 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8332 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8333 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8334 (turn_on_face, init_tty): Likewise.
8335 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8336
7f3f1250
PE
8337 * term.c (term_mouse_position): Rename local to avoid shadowing.
8338
e6ca6543
PE
8339 * alloc.c (mark_ttys): Move decl from here ...
8340 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8341
c40f8d15
AS
83422011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8343
8344 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8345
cfe0661d
JB
83462011-03-09 Juanma Barranquero <lekktu@gmail.com>
8347
8348 * search.c (compile_pattern_1): Remove argument regp, unused since
8349 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8350 (compile_pattern): Don't pass it.
8351
0afb4571
J
83522011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8353
8354 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8355 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8356 for ! HAVE_GTK3.
8357 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8358
8359 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8360
8361 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8362 gdk_window_get_screen, gdk_window_get_geometry,
8363 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8364 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8365 (xg_get_pixbuf_from_pixmap): New function.
8366 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8367 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8368 Call xg_get_pixbuf_from_pixmap instead of
8369 gdk_pixbuf_get_from_drawable.
8370 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8371 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8372 (xg_check_special_colors): Use GtkStyleContext and its functions
8373 for HAVE_GTK3.
8374 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8375 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8376 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8377 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8378 Call gtk_widget_get_preferred_size.
0afb4571
J
8379 (xg_frame_resized): gdk_window_get_geometry only takes 5
8380 parameters.
44f230aa
SM
8381 (xg_win_to_widget, xg_event_is_for_menubar):
8382 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8383 (xg_set_widget_bg): New function.
8384 (delete_cb): New function.
895009e1 8385 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8386 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8387 (xg_set_background_color): Call xg_set_widget_bg.
8388 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8389 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8390 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8391 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8392 if ! HAVE_GTK3.
8393 (update_frame_tool_bar): Call gtk_widget_hide.
8394 (xg_initialize): Use GDK_KEY_g.
8395
8396 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8397 if ! HAVE_GTK3
8398 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8399
8400 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8401 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8402 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8403
1c2cc4ef
JB
84042011-03-08 Juanma Barranquero <lekktu@gmail.com>
8405
8406 * w32xfns.c (select_palette): Check success of RealizePalette against
8407 GDI_ERROR, not zero.
8408
33383987 8409See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8410
8411;; Local Variables:
8412;; coding: utf-8
aac0c6e3
MR
8413;; End:
8414
33383987 8415 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8416
8417 This file is part of GNU Emacs.
8418
8419 GNU Emacs is free software: you can redistribute it and/or modify
8420 it under the terms of the GNU General Public License as published by
8421 the Free Software Foundation, either version 3 of the License, or
8422 (at your option) any later version.
8423
8424 GNU Emacs is distributed in the hope that it will be useful,
8425 but WITHOUT ANY WARRANTY; without even the implied warranty of
8426 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8427 GNU General Public License for more details.
8428
8429 You should have received a copy of the GNU General Public License
8430 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.