Minor doc fixes for some window functions.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
94e0933e
CY
12011-09-24 Chong Yidong <cyd@stupidchicken.com>
2
3 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4 (Fset_window_next_buffers): Doc fix.
5
cddde921
GM
62011-09-24 Glenn Morris <rgm@gnu.org>
7
8 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
9
1260aef1
PE
102011-09-24 Paul Eggert <eggert@cs.ucla.edu>
11
25b4bfa0
PE
12 Fix minor problems found by static checking.
13 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
14 * indent.c (Fvertical_motion): Fix == vs = typo.
15
e3cbd34b
EZ
162011-09-24 Eli Zaretskii <eliz@gnu.org>
17
6bf7006f
EZ
18 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
19 value is now t. Doc fix.
20
e3cbd34b
EZ
21 * indent.c (Fvertical_motion): Compute and apply the overshoot
22 logic when moving up, not only when moving down. Fix the
23 confusing name and values of the it_overshoot_expected variable;
24 logic changes accordingly. (Bug#9254) (Bug#9549)
25
26 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
27 CHARPOS is covered by a display string which includes newlines.
28 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
29 is covered by a display string with embedded newlines.
30
a3de0cbd
MA
312011-09-24 Michael Albinus <michael.albinus@gmx.de>
32
33 * dbusbind.c (Fdbus_register_signal): Add match rule to
34 Vdbus_registered_objects_table. (Bug#9581)
35 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
36 docstring.
37
b260039d
JM
382011-09-24 Jim Meyering <meyering@redhat.com>
39
40 do not ignore write error for any output size
41 The previous change was incomplete.
42 While it makes emacs --batch detect the vast majority of stdout
43 write failures, errors were still ignored whenever the output size is
44 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
45 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
46 && echo FAIL: ignored write error
47 FAIL: ignored write error
48 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
49 && echo FAIL: ignored write error
50 FAIL: ignored write error
51 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
52
8eca8a7c
AS
532011-09-23 Andreas Schwab <schwab@linux-m68k.org>
54
55 * emacs.c (Fkill_emacs): In noninteractive mode exit
56 non-successfully if a write error occurred on stdout. (Bug#9574)
57
3341db62
EZ
582011-09-21 Eli Zaretskii <eliz@gnu.org>
59
60 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
61 the xassert test.
62
63 * dispextern.h (struct it): Update the comment documenting what
64 can it->OBJECT be.
65
8c203dbf
EZ
662011-09-20 Eli Zaretskii <eliz@gnu.org>
67
68 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
69 a display string, extend search for cursor position to end of row.
70 (find_row_edges): If the row ends in a newline from a display
71 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
72 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
73 (Fcurrent_bidi_paragraph_direction): Fix search for previous
74 non-empty line. Fixes confusing cursor motion with arrow keys at
75 the beginning of a line that starts with whitespace.
8c203dbf 76
a4824228
LMI
772011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
78
79 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
80 (bug#9493).
81
33ed493b
CY
822011-09-18 Chong Yidong <cyd@stupidchicken.com>
83
84 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
85 boolean (Bug#9154).
86
56cd55c8
EZ
872011-09-18 Eli Zaretskii <eliz@gnu.org>
88
89 * xdisp.c (display_line): Record maximum and minimum buffer
90 positions even if no glyphs were produced (e.g., by a zero-width
91 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
92 buffer positions that will be removed from the glyph row because
93 they don't fit.
c02dcedf
EZ
94 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
95 column is beyond frame width: don't subtract 1 "pixel" when
96 computing width of the stretch.
3e62b7e0
EZ
97 (reseat_at_next_visible_line_start): Undo the change made on
98 2011-09-17 that saved paragraph information and restored it after
99 the call to `reseat'. (Bug#9545)
56cd55c8 100
5ed99d36 1012011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
102
103 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
104 and turn window cursor on if cleared (Bug#9415).
105
5ed99d36 1062011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
107
108 * search.c (boyer_moore): Take unibyte characters from pattern
109 literally. (Bug#9458)
110
9bade7b2
EZ
1112011-09-18 Eli Zaretskii <eliz@gnu.org>
112
113 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
114
e5e9d610
PE
1152011-09-18 Paul Eggert <eggert@cs.ucla.edu>
116
87e4427a
PE
117 Fix minor problem found by static checking.
118 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
119 initialized, to pacify gcc -Wuninitialized.
120
e5e9d610
PE
121 * fileio.c: Report proper errno when syscall falls.
122 (Finsert_file_contents): Save and restore errno,
123 so that report_file_error outputs the correct diagnostic.
124 (Fwrite_region) [CLASH_DETECTION]: Likewise.
125
a1674f0b
EZ
1262011-09-18 Eli Zaretskii <eliz@gnu.org>
127
128 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
129
fbfb6dd4
EZ
1302011-09-17 Eli Zaretskii <eliz@gnu.org>
131
132 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
133 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
134
bb187662
EZ
1352011-09-17 Eli Zaretskii <eliz@gnu.org>
136
1137e8b8
EZ
137 * xdisp.c (reseat_at_next_visible_line_start): Keep information
138 about the current paragraph and restore it after the call to
139 reseat.
140
141 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
142 (bidi_find_paragraph_start): Search back for paragraph beginning
143 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
144 (bidi_move_to_visually_next): Only trigger paragraph-related
145 computations when the last character is a newline or at EOB, not
146 just any NEUTRAL_B. (Bug#9470)
147
bb187662
EZ
148 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
149 truncated lines if point is covered by a display string. (Bug#9524)
150
2e621251
PE
1512011-09-16 Paul Eggert <eggert@cs.ucla.edu>
152
153 * xselect.c: Relax test for outgoing X longs (Bug#9498).
154 (cons_to_x_long): New function.
155 (lisp_data_to_selection_data): Use it. Correct the test for
156 short-versus-long data; it was negated. Break out of vector
157 loop, for efficiency, when a long datum is discovered.
158
91a15bc6
SM
1592011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
160
161 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
162
b41c3a35
EZ
1632011-09-16 Eli Zaretskii <eliz@gnu.org>
164
165 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
166 GCC PR/17406) by declaring this function with external scope.
167
7812ba2d
PE
1682011-09-15 Paul Eggert <eggert@cs.ucla.edu>
169
170 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
171 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
172
cf7edc2a
AS
1732011-09-15 Andreas Schwab <schwab@linux-m68k.org>
174
175 * editfns.c (Fformat): Correctly handle text properties on "%%".
176
bd01620e
EZ
1772011-09-15 Eli Zaretskii <eliz@gnu.org>
178
179 * xterm.c (x_draw_composite_glyph_string_foreground):
180 * w32term.c (x_draw_composite_glyph_string_foreground):
181 * term.c (encode_terminal_code):
182 * composite.c (composition_update_it, get_composition_id):
183 * xdisp.c (get_next_display_element)
184 (fill_composite_glyph_string): Add comments about special meaning
185 of TAB characters in a composition.
186
a02719a3
PE
1872011-09-15 Paul Eggert <eggert@cs.ucla.edu>
188
189 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
190 This occurs when processing a multibyte format.
191 Problem reported by Wolfgang Jenker.
a02719a3 192
72589a3c
JB
1932011-09-15 Johan Bockgård <bojohan@gnu.org>
194
195 * xdisp.c (try_cursor_movement): Only check for exact match if
196 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
197
1c14176c
PE
1982011-09-14 Paul Eggert <eggert@cs.ucla.edu>
199
200 Remove unused external symbols.
201 * dispextern.h (calc_pixel_width_or_height): Remove decl.
202 * xdisp.c (calc_pixel_width_or_height): Now static.
203 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
204 * indent.c (check_display_width):
205 * w32term.c: Fix comment to match code.
206 * xterm.c, xterm.h (x_catching_errors): Remove.
207
d2eea5b5
PE
2082011-09-14 Paul Eggert <eggert@cs.ucla.edu>
209
210 * xselect.c: Use signed conversions more consistently (Bug#9498).
211 (selection_data_to_lisp_data): Assume incoming selection data are
212 signed integers, not unsigned. This is to be consistent with
213 outgoing selection data, which was modified to use signed integers
214 in as part of the fix to Bug#9196 in response to Jan D.'s comment
215 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
216 expects long, not unsigned long.
217
46888499
EZ
2182011-09-14 Eli Zaretskii <eliz@gnu.org>
219
220 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
221 computation of loop end. Reported by Johan Bockgård
222 <bojohan@gnu.org>.
223
ef8ef9fb
CY
2242011-09-13 Chong Yidong <cyd@stupidchicken.com>
225
226 * frame.c (Fother_visible_frames_p): Function deleted.
227
fa819fed
EZ
2282011-09-12 Eli Zaretskii <eliz@gnu.org>
229
230 * indent.c (compute_motion): Process display vector front to back
231 rather than the other way around. (Bug#2496)
232
2ba8e008
SM
2332011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
234
235 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
236
20f53c69
CY
2372011-09-11 Chong Yidong <cyd@stupidchicken.com>
238
239 * minibuf.c (Fread_from_minibuffer): Doc fix.
240
d562d7a4
EZ
2412011-09-11 Eli Zaretskii <eliz@gnu.org>
242
243 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
244 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
245
1c4d7f3d
LMI
2462011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
247
248 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
249 value for non-existent files.
250
b885bf36
EZ
2512011-09-11 Eli Zaretskii <eliz@gnu.org>
252
253 * fileio.c (Finsert_file_contents): If the file cannot be opened,
254 set its "size" to -1. This will set the modtime_size field of
255 the corresponding buffer to -1, which is what
256 verify-visited-file-modtime expects for files that do not exist.
257 (Bug#9139)
258
6612f0bf
PE
2592011-09-11 Paul Eggert <eggert@cs.ucla.edu>
260
261 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
262 here ...
263 * lisp.h: ... from here. push_key_description is no longer
264 defined in keyboard.c, so its declaration should not be in
265 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
266 logically belongs with push_key_description.
267
dfb3f755
PE
2682011-09-10 Paul Eggert <eggert@cs.ucla.edu>
269
270 * buffer.h: Include <sys/types.h> instead of <time.h>.
271 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
272 Problem reported by Herbert J. Skuhra.
273
3134906c
LMI
2742011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
275
276 * xml.c (parse_region): Make the parsing work for
277 non-comment-starting XML files again (bug#9144).
278
8d903f4e
AS
2792011-09-10 Andreas Schwab <schwab@linux-m68k.org>
280
281 * image.c (gif_load): Fix calculation of bottom and right corner.
282 (Bug#9468)
283
80ad64f4
EZ
2842011-09-10 Eli Zaretskii <eliz@gnu.org>
285
286 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
287 redisplay in small windows.
288
208a048d
EZ
2892011-09-09 Eli Zaretskii <eliz@gnu.org>
290
291 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
292
9b1c252e
MR
2932011-09-08 Martin Rudalics <rudalics@gmx.at>
294
295 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
296 Operate on live windows only.
297
2949f33b
JB
2982011-09-08 Juanma Barranquero <lekktu@gmail.com>
299
300 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
301
e08dcafd
EZ
3022011-09-07 Eli Zaretskii <eliz@gnu.org>
303
304 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
305 only under bidi iteration.
306
115b96bd
JD
3072011-09-07 Jan Djärv <jan.h.d@swipnet.se>
308
309 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
310
c8199d0f
PE
3112011-09-06 Paul Eggert <eggert@cs.ucla.edu>
312
313 isnan: Fix porting problem to Solaris 10 with bundled gcc.
314 Without this fix, the command to link temacs failed due to an
315 undefined symbol __builtin_isnan. This is because
316 /usr/include/iso/math_c99.h #defines isnan(x) to
317 __builtin_isnan(x), but the bundled gcc, which identifies itself
318 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
319 a __builtin_isnan.
320 * floatfns.c (isnan): #undef, and then #define to a clone of
321 what's in data.c.
322 (Fisnan): Always define, since it's always available now.
323 (syms_of_floatfns): Always define isnan at the Lisp level.
324
e39b275c 3252011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
326
327 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
328
b2db44d9 3292011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 330
f4af5137 331 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
332 The previous code assumed that file offsets (off_t values) fit in
333 EMACS_INT variables, which is not true on typical 32-bit hosts.
334 The code messed up by falsely reporting buffer overflow in cases
335 such as (insert-file-contents "big" nil 1 2) into an empty buffer
336 when "big" contains more than 2**29 bytes, even though this
337 inserts just one byte and does not overflow the buffer.
338 (Finsert_file_contents): Store file offsets as off_t
339 values, not as EMACS_INT values. Check for overflow when
340 converting between EMACS_INT and off_t. When checking for
341 buffer overflow or for overlap, take the offsets into account.
342 Don't use EMACS_INT for small values where int suffices.
343 When checking for overlap, fix a typo: ZV was used where
344 ZV_BYTE was intended.
345 (Fwrite_region): Don't assume off_t fits into 'long'.
346 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
347
ecfc0a49
MA
3482011-09-05 Michael Albinus <michael.albinus@gmx.de>
349
350 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
351
6511acf2 3522011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 353
0999621a 354 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
355
356 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 357 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
358 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
359 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
360 (modify_event_symbol): Do not assume that the length of
361 name_alist_or_stem is safe to alloca and fits in int.
362 (Fexecute_extended_command): Likewise for function name and binding.
363 (Frecursion_depth): Wrap around reliably on integer overflow.
364 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
365 since some callers pass EMACS_INT values.
366 (Fsingle_key_description): Don't crash if symbol name contains more
367 than MAX_ALLOCA bytes.
368 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
369 (get_minibuffer): Arg is now EMACS_INT, not int.
370 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 371 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
372 * window.h (command_loop_level, minibuf_level): Reflect API changes.
373
2be7d702
PE
374 * dbusbind.c (signature_cat): New function.
375 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
376 Do not overrun buffer; instead, report string overflow.
377
9d1df220
PE
378 * dispnew.c (add_window_display_history): Don't overrun buffer.
379 Truncate instead; this is OK since it's just a log.
380
33ef5c64
PE
381 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
382 even if the time zone offset is outlandishly large.
383 Don't mishandle offset == INT_MIN.
384
66c6fdd5
PE
385 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
386 when creating daemon; the previous buffer-overflow check was incorrect.
387
d749b01b
PE
388 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
389 which has the guts of the old verror function.
390
b5cd1905
PE
391 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
392 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
393
6e1a67fb
PE
394 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
395 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 396 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 397 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
398 length of string rather than counting it via multiple sprintfs;
399 that's simpler and more reliable.
c21721cc
PE
400 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
401 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
402 sprintf, in case result does not fit in int.
403
c57b67fc
PE
404 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
405 (fontset_from_font): Print it.
406
8a401434
PE
407 * frame.c (tty_frame_count): Now printmax_t, not int.
408 (make_terminal_frame, set_term_frame_name): Print it.
409 (x_report_frame_params): In X, window IDs are unsigned long,
410 not signed long, so print them as unsigned.
411 (validate_x_resource_name): Check for implausibly long names,
412 and don't assume name length fits in 'int'.
413 (x_get_resource_string): Don't blindly alloca invocation name;
414 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
415 not fit in int.
416
6e1a67fb
PE
417 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
418 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
419 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
420
0df02bf3
PE
421 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
422 Use esprintf, not sprintf, in case result does not fit in int.
423
48e30793
PE
424 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
425 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
426 it as a large positive number.
427 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
428 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
429
a66ff6d8
PE
430 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
431 in case result does not fit in int.
432
aca216ff
PE
433 * print.c (float_to_string): Detect width overflow more reliably.
434 (print_object): Make sprintf buffer a bit bigger, to avoid potential
435 buffer overrun. Don't assume list length fits in 'int'. Treat
436 print length of 0 as 0, not as infinity; to be consistent with other
437 uses of print length in this function. Don't overflow print length
438 index. Don't assume hash table size fits in 'long', or that
439 vectorlike size fits in 'unsigned long'.
440
31c286f7
PE
441 * process.c (make_process): Use printmax_t, not int, to format
442 process-name gensyms.
443
55e5faa1
PE
444 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
445
80f2e268
PE
446 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
447 to avoid potential buffer overrun.
448
670741ab
PE
449 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
450 if X resource line is longer than 512 bytes.
451
b7163a50
PE
452 * xfns.c (x_window): Make sprintf buffer a bit bigger
453 to avoid potential buffer overrun.
454
ae58ff1f
PE
455 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
456
c43c8a6a
PE
457 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
458
3f8236f4
PE
4592011-09-04 Paul Eggert <eggert@cs.ucla.edu>
460
53e9fe90 461 Integer overflow fixes for scrolling, etc.
6511acf2
PE
462 Without these, Emacs silently mishandles large integers sometimes.
463 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
464 it were "C-u 1 M-x recenter" on a typical 64-bit host.
465
6511acf2
PE
466 * xdisp.c (try_window_id): Check Emacs fixnum range before
467 converting to 'int'.
806add1d 468
6511acf2 469 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
470 Check that an Emacs fixnum is in range before assigning it to 'int'.
471 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
472 values converted from Emacs fixnums.
473 (Frecenter): Don't wrap around a line count if it is out of 'int'
474 range; instead, treat it as an extreme value.
475 (Fset_window_configuration, compare_window_configurations):
476 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
477
6511acf2
PE
478 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
479 that can exceed INT_MAX. Check that EMACS_INT value is in range
480 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
481 (match_limit): Don't assume that a fixnum can fit in 'int'.
482
6511acf2 483 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
484 exceed INT_MAX.
485
6511acf2 486 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
487 (Fvertical_motion): Don't wrap around LINES values that don't fit
488 in 'int'. Instead, treat them as extreme values. This is good
489 enough for windows, which can't have more than INT_MAX lines anyway.
490
fcb901a7
LMI
4912011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
492
0f2f6b6d
LMI
493 * Require libxml/parser.h to avoid compilation warning.
494
fcb901a7
LMI
495 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
496
497 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
498 since this reportedly can destroy thread storage.
499
6e20a0d4
CY
5002011-08-30 Chong Yidong <cyd@stupidchicken.com>
501
502 * syntax.c (find_defun_start): Update all cache variables if
503 exiting early (Bug#9401).
504
148ae00e
EZ
5052011-08-30 Eli Zaretskii <eliz@gnu.org>
506
f6cfbd8f
EZ
507 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
508
148ae00e
EZ
509 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
510 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
511 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
512
513 * term.c (tty_append_glyph): New function.
514 (produce_stretch_glyph): Static function and its prototype deleted.
515
516 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
517 prototypes.
518
c4a07a4c
PE
5192011-08-29 Paul Eggert <eggert@cs.ucla.edu>
520
521 * image.c (parse_image_spec): Check for nonnegative, not for positive,
522 when checking :margin (Bug#9390).
523 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
524 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
525 so that the name doesn't mislead. All uses changed.
526
6bc8cd65
JB
5272011-08-28 Johan Bockgård <bojohan@gnu.org>
528
529 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
530 set_tty_hooks.
531
dca4927e
EZ
5322011-08-27 Eli Zaretskii <eliz@gnu.org>
533
534 * xdisp.c (move_it_to): Don't bail out early when reaching
535 position beyond to_charpos, if we are scanning backwards.
536 (move_it_vertically_backward): When DY == 0, make sure we get to
537 the first character in the line after the newline.
538
f2cad773
PE
5392011-08-27 Paul Eggert <eggert@cs.ucla.edu>
540
541 * ccl.c: Improve and simplify overflow checking (Bug#9196).
542 (ccl_driver): Do not generate an out-of-range pointer.
543 (Fccl_execute_on_string): Remove unnecessary check for
544 integer overflow, noted by Stefan Monnier in
545 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
546 Remove a FIXME that didn't need fixing.
547 Simplify the newly-introduced buffer reallocation code.
548
0cae2cdb
JB
5492011-08-27 Juanma Barranquero <lekktu@gmail.com>
550
551 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
552
5fc295a4 5532011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 554
70c60eb2 555 Integer and memory overflow issues (Bug#9196).
726e0ab1 556
d31850da
PE
557 * doc.c (get_doc_string): Rework so that
558 get_doc_string_buffer_size is the actual buffer size, rather than
559 being 1 less than the actual buffer size; this makes xpalloc more
560 convenient.
561
a69fbedb
PE
562 * image.c (x_allocate_bitmap_record, cache_image):
563 * xselect.c (Fx_register_dnd_atom):
564 Simplify previous changes by using xpalloc.
565
fe5c5d37
PE
566 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
567 since either will do and ptrdiff_t is convenient with xpalloc.
568
0065d054
PE
569 * charset.c (charset_table_size)
570 (struct charset_sort_data.priority): Now ptrdiff_t.
571 (charset_compare): Don't overflow if priorities differ greatly.
572 (Fsort_charsets): Don't assume list length fits in int.
573 Check for size-calculation overflow when allocating sort data.
574 (syms_of_charset): Allocate an initial charset table that is
575 just under 64 KiB, to avoid problems with glibc malloc and mmap.
576
577 * cmds.c (internal_self_insert): Check for size-calculation overflow.
578
579 * composite.h (struct composition.glyph_len): Now int, not unsigned.
580 The actual value is always <= INT_MAX, and leaving it unsigned made
581 overflow checking harder.
582
583 * dispextern.h (struct glyph_matrix.rows_allocated)
584 (struct face_cache.size): Now ptrdiff_t, for convenience in use
585 with xpalloc. The values are still always <= INT_MAX.
586
587 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
588
589 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
590 (SAFE_NALLOCA): New macro.
591
592 * region-cache.c (struct boundary.pos, find_cache_boundary)
593 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
594 (set_cache_region, invalidate_region_cache)
595 (revalidate_region_cache, know_region_cache, region_cache_forward)
596 (region_cache_backward, pp_cache):
597 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
598 so that ptrdiff_t * can be passed to xpalloc.
599 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
600 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
601 (pp_cache): Don't assume cache_len fits in int.
602 * region-cache.h: Adjust extern decls to match.
603
604 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
605 EMACS_INT, since either will do, for xpalloc.
606
607 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
608 (xnmalloc, xnrealloc, xpalloc): New functions.
609
726e0ab1
PE
610 * bidi.c (bidi_shelve_header_size): New constant.
611 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
612 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
613
51f30bc5 614 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
615 * buffer.c (overlays_at, overlays_in, record_overlay_string)
616 (overlay_strings):
617 Don't update size of array until after memory allocation succeeds,
618 because xmalloc/xrealloc may not return.
0065d054
PE
619 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
620 now that we have proper integer overflow checking.
621 (record_overlay_string, overlay_strings): Catch overflows when
622 calculating size of overlay_str_buf.
726e0ab1 623
0065d054
PE
624 * callproc.c (Fcall_process): Check for size overflow when
625 calculating size of args2.
626 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
627 Normally we prefer signed values, but sticking with ptrdiff_t would
628 require adding more-complicated checks.
726e0ab1
PE
629
630 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
631 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
632 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 633 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
634
635 * character.c (Fstring): Check for size-calculation overflow.
636
637 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
638 unnecessary integer overflow. Check for size overflow.
639 (encode_coding_object): Don't update size until xmalloc succeeds.
640
641 * composite.c (get_composition_id): Check for overflow in glyph
642 length calculations.
643
644 Integer and memory overflow fixes for display code.
645 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
646 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
647 (scrolling_window): Check for overflow in size calculations.
648 (line_draw_cost, realloc_glyph_pool, add_row_entry):
649 Don't assume glyph table len fits in int.
650 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
651 (row_table_size): Now ptrdiff_t, not int.
652 (scrolling_window): Avoid overflow in size calculations.
653 Don't update size until allocation succeeds.
654 * fns.c (concat): Check for overflow in size calculations.
655 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
656 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
657 (NEXT_ALMOST_PRIME_LIMIT): New constant.
658
659 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
660 (get_doc_string): Check for size calculation overflow.
661 Don't update size until allocation succeeds.
662 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
663 EMACS_INT, where ptrdiff_t will do.
664 (Fsubstitute_command_keys): Check for string overflow.
665
666 * editfns.c (set_time_zone_rule): Don't assume environment length
667 fits in int.
668 (message_length): Now ptrdiff_t, not int.
669 (Fmessage_box): Don't update size until allocation succeeds.
670 Don't assume message length fits in int.
671 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
672
0065d054
PE
673 * emacs.c (main): Do not reallocate argv, since there is a null at
674 the end that can be overwritten, and this way there's no need to
675 worry about size-calculation overflow.
676 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
677
678 * eval.c (init_eval_once, grow_specpdl): Don't update size until
679 alloc succeeds.
680 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
681
682 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
683 (x_set_scroll_bar_width, x_figure_window_size):
684 Check for integer overflow.
685 (x_set_alpha): Do not assume XINT fits in int.
686
687 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
688 This is for the members text_lines, text_cols, total_lines, total_cols,
689 where the system imposes an 'int' limit.
690
691 * fringe.c (Fdefine_fringe_bitmap):
692 Don't update size until alloc works.
693
694 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
695 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
696
697 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
698 Check for size-calculation overflow.
699 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
700 do, as we prefer signed integers.
701 (id_to_widget.max_size, id_to_widget.used)
702 (xg_store_widget_in_map, xg_remove_widget_from_map)
703 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
704 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
705 Use and return ptrdiff_t, not int.
706 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
707 * gtkutil.h: Change prototypes to match the above.
708
709 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
710 are duplicate now that they've been promoted to lisp.h.
711 (x_allocate_bitmap_record, x_alloc_image_color)
712 (make_image_cache, cache_image, xpm_load):
713 Don't update size until alloc is done.
714 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
715 (x_detect_edges):
3256efce 716 Check for size calculation overflow.
726e0ab1
PE
717 (ct_colors_allocated_max): New constant.
718 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
719 overflow.
3256efce 720
726e0ab1
PE
721 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
722 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
723 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
724 Use ptrdiff_t, not int, to count maps.
725 (read_char_minibuf_menu_prompt): Check for overflow in size
726 calculations. Don't update size until allocation succeeds. Redo
727 calculations to avoid overflow.
728 * keyboard.h: Change prototypes to match the above.
729
730 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
731 to count maps.
732 (current_minor_maps): Check for size calculation overflow.
733 * keymap.h: Change prototypes to match the above.
734
735 * lread.c (read1, init_obarray): Don't update size until alloc done.
736
737 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
738 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
739
726e0ab1
PE
740 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
741 Now ptrdiff_t, not int.
742 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
743 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
744
745 * process.c (Fnetwork_interface_list): Check for overflow
746 in size calculation.
747
748 * region-cache.c (move_cache_gap): Check for size calculation overflow.
749
750 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
751 overflow. Don't bother calling xmalloc when xrealloc will do.
752
753 * search.c (Freplace_match): Check for size calculation overflow.
754 (Fset_match_data): Don't assume list lengths fit in 'int'.
755
756 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
757 for command line length. Do not attempt to address one before the
758 beginning of an array, as that's not portable.
759
760 * term.c (max_frame_lines): Remove; unused.
761 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
762 not int.
763 (encode_terminal_code, calculate_costs): Check for size
764 calculation overflow.
765 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
766 table lengths and related sizes. Don't update size until alloc
767 done. Redo calculations to avoid overflow.
768 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
769
770 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
771 subtracting pointers.
772 (gobble_line): Check for overflow more carefully. Don't update size
773 until alloc done.
774
775 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
776 Don't update size until alloc done.
777 Redo size calculations to avoid overflow.
778 Check for size calculation overflow.
0065d054 779 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
780
781 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
782 Use ptrdiff_t, not int, for sizes.
783 (store_mode_line_noprop_char): Don't update size until alloc done.
784
0065d054
PE
785 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
786 Use ptrdiff_t, not int, for sizes.
787 (Finternal_make_lisp_face, cache_face):
788 Check for size calculation overflow.
789 (cache_face): Treat size calculation overflows as if they were
790 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
791
792 * xfns.c (x_encode_text, x_set_name_internal)
793 (Fx_change_window_property): Use ptrdiff_t, not int, to count
794 sizes, since they can exceed INT_MAX in size. Check for size
795 calculation overflow.
796
0065d054
PE
797 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
798 (xg_select): Check for size calculation overflow.
726e0ab1
PE
799 Don't update size until alloc done.
800
0065d054 801 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 802 as sprintf is limited to int lengths.
1d526e2f 803
252c5ee1
PE
804 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
805 (X_LONG_MIN): New macros.
864d7ce7
PE
806 Use them to make the following changes clearer.
807 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
808 This change doesn't affect the value now, but it may help remind
809 future maintainers not to raise the value too much later.
810 (SELECTION_QUANTUM): Remove, replacing with ...
811 (selection_quantum): ... new function, which avoids overflow.
812 All uses changed.
813 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
814 assumption that selection length fits in 'int'.
815 (x_reply_selection_request, x_handle_selection_request)
816 (x_get_window_property, receive_incremental_selection)
817 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
818 (lisp_data_to_selection_data, clean_local_selection_data):
819 Use ptrdiff_t, not int, to record length of selection.
820 (x_reply_selection_request, x_get_window_property)
821 (receive_incremental_selection, x_property_data_to_lisp):
822 Redo calculations to avoid overflow.
823 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 824 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
825 something.
826 (x_get_window_property, receive_incremental_selection)
827 (lisp_data_to_selection_data, x_property_data_to_lisp):
828 Check for size-calculation overflow.
829 (x_get_window_property, receive_incremental_selection)
830 (lisp_data_to_selection_data, Fx_register_dnd_atom):
831 Don't store size until memory allocation succeeds.
832 (x_get_window_property): Plug memory leak on memory exhaustion.
833 Don't double-block input; malloc is safe here. Don't assume 2**34
834 - 4 fits in unsigned long. Add an xassert to check
835 XGetWindowProperty overflow. Be more careful about overflow
836 calculations, and distinguish size from memory overflow better.
837 (receive_incremental_selection): When tracing, don't assume
838 unsigned int is less than INT_MAX.
839 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
840 harmful) conversions of unsigned short to int.
841 (lisp_data_to_selection_data): Don't assume that integers
842 in the range -65535 through -1 fit in an X unsigned short.
843 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
844 result parameters unless successful. Rely on cons_to_unsigned
845 to report problems with elements; the old code wasn't right anyway.
846 (x_check_property_data): Check for int overflow; we cannot use
847 a wider type due to X limits.
848 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
849
726e0ab1 850 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 851
0065d054
PE
852 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
853 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
854 (x_color_cells): Don't store size until memory allocation succeeds.
855 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 856 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
857 (x_term_init): Don't assume length fits in int (sprintf is limited
858 to int size).
bc18e09d 859
ebfa62c0
PE
860 Use ptrdiff_t for composition IDs.
861 * character.c (lisp_string_width):
862 * composite.c (composition_table_size, n_compositions)
863 (get_composition_id, composition_gstring_from_id):
864 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
865 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
866 * window.c (Frecenter):
867 Use ptrdiff_t, not int, for composition IDs.
868 * composite.c (get_composition_id): Check for integer overflow.
869 * composite.h: Adjust prototypes to match the above changes.
870
d3411f89
PE
871 Use ptrdiff_t for hash table indexes.
872 * category.c (hash_get_category_set):
873 * ccl.c (ccl_driver):
874 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
875 * coding.c (coding_system_charset_list, detect_coding_system):
876 * coding.h (struct coding_system.id):
877 * composite.c (get_composition_id, gstring_lookup_cache):
878 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
879 * image.c (xpm_get_color_table_h):
880 * lisp.h (hash_lookup, hash_put):
881 * minibuf.c (Ftest_completion):
882 Use ptrdiff_t for hash table indexes, not int (which is too
883 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
884 32-bit --with-wide-int hosts).
885
e097a6fa
PE
886 * charset.c (Fdefine_charset_internal): Check for integer overflow.
887 Add a FIXME comment about memory leaks.
888 (syms_of_charset): Don't assume xmalloc returns.
889
5637687f
PE
890 Don't assume that stated character widths fit in int.
891 * character.c (Fchar_width, c_string_width, lisp_string_width):
892 * character.h (CHAR_WIDTH):
893 * indent.c (MULTIBYTE_BYTES_WIDTH):
894 Use sanitize_char_width to avoid undefined and/or bad behavior
895 with outlandish widths.
896 * character.h (sanitize_tab_width): Renamed from sanitize_width,
897 now that we have two such functions. All uses changed.
898 (sanitize_char_width): New inline function.
899
a2271ba2
PE
900 Don't assume that tab-width fits in int.
901 * character.h (sanitize_width): New inline function.
902 (SANE_TAB_WIDTH): New macro.
903 (ASCII_CHAR_WIDTH): Use it.
904 * indent.c (sane_tab_width): Remove. All uses replaced by
905 SANE_TAB_WIDTH (current_buffer).
906 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
907
18c52557
PE
908 * fileio.c: Integer overflow issues with file modes.
909 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
910
caeeedc1
PE
911 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
912 Remove unreachable code.
913 (read_hex, load_charset_map_from_file): Check for integer overflow.
914
50849c52
PE
915 * xterm.c: don't go over XClientMessageEvent limit
916 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
917 (x_send_scroll_bar_event): Likewise. Check that the size does not
918 exceed limits imposed by XClientMessageEvent, as well as the usual
919 ptrdiff_t and size_t limits.
920
b13995db
PE
921 * keyboard.c: Overflow, signedness and related fixes.
922 (make_lispy_movement): Use same integer type in forward decl
923 that is used in the definition.
924 (read_key_sequence, keyremap_step):
925 Change bufsize argument back to int, undoing my 2011-03-30 change.
926 We prefer signed types, and int is wide enough here.
927 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
928 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
929 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
930 length, not size_t. Use ptrdiff_t for index, not int.
931 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
932 possibility of integer overflow.
933
13464394
PE
934 Overflow, signedness and related fixes for images.
935
936 * dispextern.h (struct it.stack[0].u.image.image_id)
937 (struct_it.image_id, struct image.id, struct image_cache.size)
938 (struct image_cache.used, struct image_cache.ref_count):
939 * gtkutil.c (update_frame_tool_bar):
940 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
941 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
942 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
943 * nsmenu.m (update_frame_tool_bar):
944 * xdisp.c (calc_pixel_width_or_height):
945 * xfns.c (image_cache_refcount):
946 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
947 on typical 64-bit hosts.
948
949 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
950 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
951 Omit unnecessary casts to int.
952 (parse_image_spec): Check that integers fall into 'int' range
953 when the callers expect that.
954 (image_ascent): Redo ascent calculation to avoid int overflow.
955 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
956 (lookup_image): Remove unnecessary tests.
957 (xbm_image_p): Locals are now of int, not EMACS_INT,
958 since parse_image_check makes sure they fit into int.
959 (png_load, gif_load, svg_load_image):
960 Prefer int to unsigned where either will do.
961 (tiff_handler): New function, combining the cores of the
962 old tiff_error_handler and tiff_warning_handler. This
963 function is rewritten to use vsnprintf and thereby avoid
964 stack buffer overflows. It uses only the features of vsnprintf
965 that are common to both POSIX and native Microsoft.
966 (tiff_error_handler, tiff_warning_handler): Use it.
967 (tiff_load, gif_load, imagemagick_load_image):
968 Don't assume :index value fits in 'int'.
969 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
970 (imagemagick_load_image): Check that crop parameters fit into
971 the integer types that MagickCropImage accepts. Don't assume
972 Vimagemagick_render_type has a nonnegative value. Don't assume
973 size_t fits in 'long'.
974 (gs_load): Use printmax_t to print the widest integers possible.
975 Check for integer overflow when computing image height and width.
976
c11821d4
EZ
9772011-08-26 Eli Zaretskii <eliz@gnu.org>
978
979 * xdisp.c (redisplay_window): Don't force window start if point
980 will be invisible in the resulting window. (Bug#9324)
981
0c95fcf7
EZ
9822011-08-25 Eli Zaretskii <eliz@gnu.org>
983
984 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
985 the display spec is of the form `(space ...)'.
986 (handle_display_spec): Return the value returned by
987 handle_single_display_spec, not just 1 or zero.
988 (handle_single_display_spec): If the display spec is of the form
989 `(space ...)', and specifies display in the text area, return 2
990 rather than 1.
fee65a97 991 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
992 accurately, and prefer exact match for point under bidi. Don't
993 advance `row' beyond the last row of the window.
0c95fcf7
EZ
994
995 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
996 into disp_prop; all users changed.
997
998 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
999 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1000 for the text covered by the display property.
1001
e4ed06f1
CY
10022011-08-25 Chong Yidong <cyd@stupidchicken.com>
1003
1004 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1005 Change return value to nil.
1006 (Frecord_buffer): Delete unused function.
1007
f67cdd7f
EZ
10082011-08-24 Eli Zaretskii <eliz@gnu.org>
1009
5980d4c6
EZ
1010 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1011 buffers, return left-to-right.
8610fe8b
EZ
1012 (set_cursor_from_row): Consider candidate row a win if its glyph
1013 represents a newline and point is on that newline. Fixes cursor
1014 positioning on the newline at EOL of R2L text within L2R
1015 paragraph, and vice versa.
1016 (try_cursor_movement): Check continued rows, in addition to
1017 continuation rows. Fixes unwarranted scroll when point enters a
1018 continued line of R2L text within an L2R paragraph, or vice versa.
1019 (cursor_row_p): Consider the case of point being equal to
1020 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1021 from the end of a short line to the beginning of a continued line
1022 of R2L text within L2R paragraph.
1023 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1024 composed characters.
5980d4c6 1025
f67cdd7f
EZ
1026 * bidi.c (bidi_check_type): Use xassert.
1027 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1028 members.
1029
bca633fb
EZ
10302011-08-23 Eli Zaretskii <eliz@gnu.org>
1031
1032 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1033 a character.
1034
4a5885a7
CY
10352011-08-23 Chong Yidong <cyd@stupidchicken.com>
1036
1037 * nsfont.m (ns_otf_to_script): Fix typo.
1038
0902a04e
KH
10392011-08-22 Kenichi Handa <handa@m17n.org>
1040
1041 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1042 extra slot even if the purpose is char-code-property-table.
1043
1a2e6670
EZ
10442011-08-23 Eli Zaretskii <eliz@gnu.org>
1045
8ddde651
EZ
1046 * xdisp.c (redisplay_window): When computing centering_position,
1047 account for the height of the header line. (Bug#8874)
1048
425cc014
EZ
1049 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1050 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1051 candidate is selected by the mouse, and that candidate has a
1052 composed character under the mouse.
1053
1a2e6670
EZ
1054 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1055 coordinates reported by pos-visible-in-window-p for a composed
1056 character in column zero.
1057
8b76d6f8
SM
10582011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1059
1060 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1061
dac347dd
EZ
10622011-08-22 Eli Zaretskii <eliz@gnu.org>
1063
1064 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1065 consider it a hit if to_charpos is anywhere in the range of the
1066 composed buffer positions.
1067
e013fb34
CY
10682011-08-22 Chong Yidong <cyd@stupidchicken.com>
1069
1070 * image.c (gif_load): Don't assume that each subimage has the same
1071 dimensions as the base image. Handle disposal method that is
1072 "undefined" by the gif spec (Bug#9335).
1073
bd1ba3e8
CY
10742011-08-20 Chong Yidong <cyd@stupidchicken.com>
1075
1076 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1077 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1078
54a1215b
EZ
10792011-08-19 Eli Zaretskii <eliz@gnu.org>
1080
823564e5
EZ
1081 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1082 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1083 from an Org mode buffer to a Speedbar frame.
1084
54a1215b
EZ
1085 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1086 a composition, take its buffer position from IT->cmp_it.charpos.
1087 Fixes cursor positioning at the beginning of a line that begins
1088 with a composed character.
1089
9778ebcc
EZ
10902011-08-18 Eli Zaretskii <eliz@gnu.org>
1091
0be6ee06
EZ
1092 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1093 character bidirectional type, use STRONG_L instead. Fixes crashes
1094 in a buffer produced by `describe-categories'.
1095
9778ebcc
EZ
1096 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1097 members before the level stack, so they would be saved and
1098 restored when copying iterator state. Fixes incorrect reordering
1099 around TABs covered by display properties.
1100
156bffbe
AS
11012011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1102
1103 * process.c (Fnetwork_interface_list): Correctly determine buffer
1104 size.
1105
72ad093b
CY
11062011-08-17 Chong Yidong <cyd@stupidchicken.com>
1107
1108 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1109 (internal_condition_case_2, internal_condition_case_n):
1110 Remove unnecessary aborts (Bug#9081).
72ad093b 1111
35774242
EZ
11122011-08-17 Eli Zaretskii <eliz@gnu.org>
1113
1114 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1115 has no `load' handler, try opening the file locally. (Bug#9311)
1116
db76dd85
KB
11172011-08-16 Ken Brown <kbrown@cornell.edu>
1118
1119 * gmalloc.c: Expand comment.
1120
b215eee5
EZ
11212011-08-16 Eli Zaretskii <eliz@gnu.org>
1122
1123 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1124 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1125
a4579d33
KB
11262011-08-16 Ken Brown <kbrown@cornell.edu>
1127
1128 Fix memory allocation problems in Cygwin build (Bug#9273).
1129
1130 * unexcw.c ( __malloc_initialized): Declare external variable.
1131 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1132
8b76d6f8
SM
1133 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1134 New variables.
a4579d33
KB
1135 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1136 dumped emacs.
1137 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1138 in the static heap.
1139 [CYGWIN] (special_realloc): New function.
1140 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1141 requests to realloc storage in the static heap.
1142
3ebec551
PE
11432011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1144
1145 * bidi.c (bidi_initialize): Remove unused local.
1146
9fd8be00
EZ
11472011-08-15 Eli Zaretskii <eliz@gnu.org>
1148
474a8465
EZ
1149 * biditype.h: File removed.
1150
1151 * bidimirror.h: File removed.
1152
1153 * deps.mk (bidi.o): Remove biditype.h and
1154 bidimirror.h.
1155
1156 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1157 bidimirror.h.
1158
1159 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1160
1161 * chartab.c: Improve commentary for the uniprop_table API.
1162
32413314
EZ
1163 * bidi.c (bidi_paragraph_init): Support zero value of
1164 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1165 (bidi_initialize): Use uniprop_table instead of including
1166 biditype.h and bidimirror.h.
32413314 1167
9fd8be00
EZ
1168 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1169 coordinates of the iterator when restoring from ppos_it.
1170 (Bug#9296)
1171
5cf2b69b
KH
11722011-08-14 Kenichi Handa <handa@m17n.org>
1173
1174 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1175 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1176
daf17d00
EZ
11772011-08-14 Eli Zaretskii <eliz@gnu.org>
1178
1179 * xdisp.c (move_it_in_display_line_to): Don't invoke
1180 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1181 ppos_it. Fixes vertical cursor motion when line beginning is
1182 covered by an image. (Bug#9296)
1183
08e3161a
JD
11842011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1185
1186 * nsterm.h (ns_run_ascript): Declare.
1187 (NSAPP_DATA2_RUNASSCRIPT): Define.
1188
1189 * nsfns.m (as_script, as_result, as_status): New static variables.
1190 (ns_run_ascript): New function.
5e617bc2 1191 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1192 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1193 the event loop. Get status from as_status (Bug#7276).
1194
1195 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1196 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1197 the event loop (Bug#7276).
1198
a3720aa2
AS
11992011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1200
1201 * gnutls.c (QCgnutls_bootprop_priority)
1202 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1203 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1204 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1205 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1206 (QCgnutls_bootprop_verify_hostname_error)
1207 (QCgnutls_bootprop_callbacks_verify): Rename from
1208 Qgnutls_bootprop_..., all uses changed.
1209
1210 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1211 uses changed.
1212
0a0d27fb
PE
12132011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1214
19d5c50c
PE
1215 * xfaces.c (Qframe_set_background_mode): Now static.
1216 * dispextern.h (Qframe_set_background_mode): Remove decl.
1217
0a0d27fb
PE
1218 * process.c (Fnetwork_interface_info): Declare local only if needed.
1219
377538cb
JD
12202011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1221
1222 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1223 (Fnetwork_interface_list): Allocate in increments of bytes instead
1224 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1225 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1226 sockaddr.
1227 (struct ifflag_def): notrailers is smart on OSX.
1228 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1229 Get hardware address with getifaddrs if available.
1230
08fff70c
EZ
12312011-08-12 Eli Zaretskii <eliz@gnu.org>
1232
1233 * xdisp.c (iterate_out_of_display_property): xassert that
1234 IT->position is set to within IT->object's boundaries. Break from
1235 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1236 when IT->position is set up wrongly due to some bug.
1237 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1238 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1239 entry. Force push_it to save on the stack the current
1240 buffer/string position, to be restored by pop_it. Fix flags in
1241 the iterator structure wrt the object coming from a display
1242 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1243 properties. (Bug#9284)
1244
7be1c708 12452011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1246
7be1c708
CY
1247 * fontset.c (fontset_get_font_group): Add proper type checks.
1248 (Bug#9172)
aac0c6e3 1249
7be1c708 12502011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1251
7be1c708
CY
1252 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1253 and LC_VERSION_MIN_MACOSX.
1254 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1255 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1256
97bb72a6
EZ
12572011-08-08 Eli Zaretskii <eliz@gnu.org>
1258
1259 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1260 no-display-properties-and-no-overlays under bidi display.
1261 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1262 properties and overlays.
97bb72a6 1263
d5617611
CY
12642011-08-08 Chong Yidong <cyd@stupidchicken.com>
1265
37e11a63
CY
1266 * editfns.c (Fset_time_zone_rule): Document relationship with the
1267 setenv function.
1268
d5617611
CY
1269 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1270 the font entity extracted from the cache (Bug#8109).
1271
58872834
CY
12722011-08-07 Chong Yidong <cyd@stupidchicken.com>
1273
1274 * composite.c (autocmp_chars): Don't reset point. That is done by
1275 restore_point_unwind (Bug#5984).
1276
75bfc667
JL
12772011-08-07 Juri Linkov <juri@jurta.org>
1278
1279 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1280 to show the arg `TIME' instead of `TIMEVAL'.
1281
d1410150
EZ
12822011-08-06 Eli Zaretskii <eliz@gnu.org>
1283
1284 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1285 display property strides EOL and includes a newline, as in
1286 longlines-mode. (Bug#9254)
75b771e4
EZ
1287 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1288 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1289
1290 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1291 is non-zero, even if the data buffer is NULL. Fixes a crash in
1292 vertical-motion with longlines-mode. (Bug#9254)
1293
35928349
EZ
12942011-08-05 Eli Zaretskii <eliz@gnu.org>
1295
ec7cc85b
EZ
1296 * bidi.c <bidi_cache_total_alloc>: Now static.
1297 (bidi_initialize): Initialize bidi_cache_total_alloc.
1298
8b76d6f8 1299 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1300 cache. (Bug#9221)
1301
1302 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1303 amount allocated this far in `bidi_cache_total_alloc'.
1304 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1305 non-zero, only free the data buffer without restoring the cache
1306 contents. All callers changed.
1307
1308 * dispextern.h (bidi_unshelve_cache): Update prototype.
1309
1310 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1311 (move_it_in_display_line, move_it_to)
1312 (move_it_vertically_backward, move_it_by_lines): Replace the call
1313 to xfree to an equivalent call to bidi_unshelve_cache.
1314 (move_it_in_display_line_to): Fix logic of returning
412b6358 1315 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1316
e2e2423b
EZ
13172011-08-05 Eli Zaretskii <eliz@gnu.org>
1318
1319 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1320 came from a string character with a `cursor' property. (Bug#9229)
1321
ae9e757a
JD
13222011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1323
1324 * Makefile.in (LIB_PTHREAD): New variable.
1325 (LIBES): Add LIB_PTHREAD (Bug#9216).
1326
1327 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1328 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1329
213bd7f2
AS
13302011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1331
1332 * regex.c (re_iswctype): Remove some redundant boolean
1333 conversions.
1334
99aaf75f
JD
13352011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1336
1337 * xterm.c (x_find_topmost_parent): New function.
1338 (x_set_frame_alpha): Find topmost parent window with
1339 x_find_topmost_parent and set the property there also (bug#9181).
1340 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1341
c74e9d86
PE
13422011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1343
1344 * callproc.c (Fcall_process): Avoid vfork clobbering
1345 the local vars buffer, coding_systems, current_dir.
1346
640c8776
SM
13472011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1348
1349 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1350
f26d0e4c
PE
13512011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1352
8a10d76c
PE
1353 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1354 so that it is not optimized away.
1355
f26d0e4c
PE
1356 * xdisp.c (compute_display_string_pos): Remove unused local.
1357
55439c61
EZ
13582011-08-02 Eli Zaretskii <eliz@gnu.org>
1359
1360 Fix slow cursor motion and scrolling in large buffers with
1361 selective display, like Org Mode buffers. (Bug#9218)
1362
1363 * dispextern.h (struct bidi_it): New member disp_prop_p.
1364
1365 * xdisp.c: Remove one-slot cache of display string positions.
1366 (compute_display_string_pos): Accept an additional argument
5e617bc2 1367 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1368 for a display string or property. If found, set DISP_PROP_P
1369 non-zero.
1370
1371 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1372 DISP_PROP_P, and pass it to compute_display_string_pos.
1373 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1374 non-zero. All callers of bidi_fetch_char changed.
1375
fb33fa43
SM
13762011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1377
1378 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1379
b099e063
DM
13802010-12-03 Don March <don@ohspite.net>
1381
1382 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1383 last character M-[char] is translated to ESC [char] (bug#7541).
1384
5cc7f7af
KH
13852011-08-02 Kenichi Handa <handa@m17n.org>
1386
d0fffa3f 1387 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1388
1389 * chartab.c (uniprop_table): Make it non-static.
1390
525d5e6e
EZ
13912011-08-01 Eli Zaretskii <eliz@gnu.org>
1392
1393 * xdisp.c (forward_to_next_line_start): Accept additional argument
1394 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1395 on the newline.
1396 (reseat_at_next_visible_line_start): Use the bidi iterator state
1397 returned by forward_to_next_line_start to restore the state of
1398 it->bidi_it after backing up to previous newline. (Bug#9212)
1399
31011111
AS
14002011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1401
1402 * regex.c (re_comp): Protoize.
1403 (re_exec): Fix return type.
1404 (regexec): Fix type of `ret'. (Bug#9203)
1405
476371c4
PE
14062011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1407
e5d76069
PE
1408 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1409 This is needed if max-image-size is a floating-point number.
1410
9a79b20c
AS
14112011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1412
1413 * print.c (print_object): Print empty symbol as ##.
1414
1415 * lread.c (read1): Read ## as empty symbol.
1416
d8c2fa78
AA
14172011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1418
1419 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1420 setting frame foreground color (Bug#9175).
1421 (x_set_background_color): Likewise.
1422
ffe57a7a
AA
1423 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1424 contents (Bug#9176).
1425 (EmacsTooltip -init): Remove bezels and add shadows to
1426 tooltip windows.
1427
bf3492a5
AA
1428 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1429 or scroll bar (Bug#8470).
1430
d55e9c53
AA
1431 * nsfont.m (nsfont_open): Remove assignment to voffset and
1432 unnecessary vars hshink, expand, hd, full_height, min_height.
1433 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1434
1435 * nsterm.h (nsfont_info): Remove voffset field.
1436
d8c2fa78 14372011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1438
1439 Implement strike-through and overline on NextStep (Bug#8863).
1440
1441 * nsfont.m (nsfont_open): Use underline position provided by font,
1442 instead of hard-coded value of 2.
1443 (nsfont_draw): Call ns_draw_text_decoration instead.
1444
1445 * nsterm.h: Add declaration for ns_draw_text_decoration.
1446
1447 * nsterm.m (ns_draw_text_decoration): New function for drawing
1448 underline, overline, and strike-through.
1449 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1450 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1451 accommodate underlining, etc.
4843aac3 1452
4cc60b9b
EZ
14532011-07-28 Eli Zaretskii <eliz@gnu.org>
1454
bc7ece87
EZ
1455 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1456 default.
4cc60b9b 1457
476371c4
PE
14582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1459
66606eea
PE
1460 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1461 Without this fix, if a signal arrives just after memory fills up,
1462 'malloc' might be invoked reentrantly.
1463
476371c4
PE
1464 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1465 In other words, assume that every image size is allowed, on non-X
1466 hosts. This assumption is probably wrong, but it lets Emacs compile.
1467
f3fcc40d
AS
14682011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1469
1470 * regex.c (re_iswctype): Convert return values to boolean.
1471
350c992f
EZ
14722011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1473
1474 * xdisp.c (compute_display_string_pos): Don't use cached display
1475 string position if the buffer had its restriction changed.
1476 (Bug#9184)
1477
5266b4bb
PE
14782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1479
1480 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1481
2573a837 14822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1483
41f55ccd 1484 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1485
39e378da
PE
1486 * bidi.c: Integer size and overflow fixes.
1487 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1488 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1489 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1490 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1491 (bidi_find_other_level_edge):
1492 Use ptrdiff_t instead of EMACS_INT where either will do.
1493 This works better on 32-bit hosts configured --with-wide-int.
1494 (bidi_cache_ensure_space): Check for size-calculation overflow.
1495 Use % rather than repeated addition, for better worst-case speed.
1496 Don't set bidi_cache_size until after xrealloc returns, because it
1497 might not return.
1498 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1499 (bidi_cache_ensure_space): Also check that the bidi cache size
1500 does not exceed that of the largest Lisp string or buffer. See Eli
1501 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1502
5e927815
PE
1503 * alloc.c (__malloc_size_t): Remove.
1504 All uses replaced by size_t. See Andreas Schwab's note
1505 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1506
ca4aa935
PE
1507 * image.c: Improve checking for integer overflow.
1508 (check_image_size): Assume that f is nonnull, since
1509 it is always nonnull in practice. This is one less thing to
1510 worry about when checking for integer overflow later.
1511 (x_check_image_size): New function, which checks for integer
1512 overflow issues inside X.
1513 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1514 This removes the need for a memory_full check.
1515 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1516 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1517 (xbm_read_bitmap_data): Change locals back to 'int', since
1518 their values must fit in 'int'.
1519 (xpm_load_image, png_load, tiff_load):
1520 Invoke x_create_x_image_and_pixmap earlier,
1521 to avoid much needless work if the image is too large.
1522 (tiff_load): Treat overly large images as if
1523 x_create_x_image_and_pixmap failed, not as malloc failures.
1524 (gs_load): Use x_check_image_size.
1525
5f8f9cc2
PE
1526 * gtkutil.c: Omit integer casts.
1527 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1528 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1529
5adf60bc
PE
1530 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1531
c8907a93
PE
1532 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1533 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1534 would wrongly return t on a 64-bit host.
1535
e3c25c68
PE
1536 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1537 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1538 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1539 and therefore cause GCC to emit a bogus diagnostic in some cases.
1540
3f791afe
PE
1541 * image.c: Integer signedness and overflow and related fixes.
1542 This is not an exhaustive set of fixes, but it's time to
1543 record what I've got.
1544 (lookup_pixel_color, check_image_size): Remove redundant decls.
1545 (check_image_size): Don't assume that arbitrary EMACS_INT values
1546 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1547 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1548 (tiff_load, imagemagick_load_image):
1549 Check for overflow in size calculations.
1550 (x_create_x_image_and_pixmap): Remove unnecessary test for
1551 xmalloc returning NULL; that can't happen.
1552 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1553 (xpm_color_bucket): Use better integer hashing function.
1554 (xpm_cache_color): Don't possibly over-allocate memory.
1555 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1556 (gif_memory_source):
1557 Use ptrdiff_t, not int or size_t, to record sizes.
1558 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1559 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1560 either works, as we prefer signed integers.
1561 (tiff_read_from_memory, tiff_write_from_memory):
1562 Return tsize_t, not size_t, since that's what the TIFF API wants.
1563 (tiff_read_from_memory): Don't fail simply because the read would
1564 go past EOF; instead, return a short read.
1565 (tiff_load): Omit no-longer-needed casts.
1566 (Fimagemagick_types): Don't assume size fits into 'int'.
1567
3cc5a532
PE
1568 Improve hashing quality when configured --with-wide-int.
1569 * fns.c (hash_string): New function, taken from sxhash_string.
1570 Do not discard information about ASCII character case; this
1571 discarding is no longer needed.
1572 (sxhash-string): Use it. Change sig to match it. Caller changed.
1573 * lisp.h: Declare it.
1574 * lread.c (hash_string): Remove, since we now use fns.c's version.
1575 The fns.c version returns a wider integer if --with-wide-int is
1576 specified, so this should help the quality of the hashing a bit.
1577
b312a492
PE
1578 * emacs.c: Integer overflow minor fix.
1579 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1580 Define only if GNU_LINUX.
1581 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1582
dfd153ae
PE
1583 * dispnew.c: Integer signedness and overflow fixes.
1584 Remove unnecessary forward decls, that were a maintenance hassle.
1585 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1586 All uses changed.
1587 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1588 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1589 (prepare_desired_row, line_draw_cost):
1590 Use int, not unsigned, where either works.
1591 (save_current_matrix, restore_current_matrix):
1592 Use ptrdiff_t, not size_t, where either works.
1593 (init_display): Check for overflow more accurately, and without
1594 relying on undefined behavior.
1595
a81d11a3
PE
1596 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1597 Remove, replacing with the new symbols in lisp.h. All uses changed.
1598 * fileio.c (make_temp_name):
1599 * filelock.c (lock_file_1, lock_file):
1600 * xdisp.c (message_dolog):
1601 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1602 Use pMd etc. instead.
1603 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1604 replacing the pWIDE etc. symbols removed from editfns.c.
1605
3300e6fd
PE
1606 * keyboard.h (num_input_events): Now uintmax_t.
1607 This is (very slightly) less likely to mess up due to wraparound.
1608 All uses changed.
1609
fd05c7e9
PE
1610 * buffer.c: Integer signedness fixes.
1611 (alloc_buffer_text, enlarge_buffer_text):
1612 Use ptrdiff_t rather than size_t when either will do, as we prefer
1613 signed integers.
1614
903fe15d
PE
1615 * alloc.c: Integer signedness and overflow fixes.
1616 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1617 (__malloc_size_t): Default to size_t, not to int.
1618 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1619 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1620 Prefer ptrdiff_t to size_t when either would do, as we prefer
1621 signed integers.
1622 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1623 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1624 Now const. Initialize with values that are in range even if char
1625 is signed.
1626 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1627 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1628 These functions do the right thing with sizes > 2**32.
1629 (check_depth): Now ptrdiff_t, not int.
1630 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1631 Adjust to new way of storing sizes. Check for size overflow bugs
1632 in rest of code.
1633 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1634 slightly wrong anyway, as it missed one instance of
1635 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1636 (refill_memory_reserve): Omit needless cast to size_t.
1637 (mark_object_loop_halt): Mark as externally visible.
1638
ac82cc6a
PE
1639 * xselect.c: Integer signedness and overflow fixes.
1640 (Fx_register_dnd_atom, x_handle_dnd_message):
1641 Use ptrdiff_t, not size_t, since we prefer signed.
1642 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1643 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1644 x_dnd_atoms_size and x_dnd_atoms_length.
1645
c2d1e36d
PE
1646 * doprnt.c: Prefer signed to unsigned when either works.
1647 * eval.c (verror):
1648 * doprnt.c (doprnt):
1649 * lisp.h (doprnt):
1650 * xdisp.c (vmessage):
1651 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1652 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1653 prefer signed arithmetic to avoid comparison confusion.
1654 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1655 but is a bit tricky.
1656
0e926e56
PE
1657 Assume freestanding C89 headers, string.h, stdlib.h.
1658 * data.c, doprnt.c, floatfns.c, print.c:
1659 Include float.h unconditionally.
1660 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1661 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1662 * regex.c: Likewise for stddef.h, string.h.
1663 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1664 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1665 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1666 (STDC_HEADERS): Remove obsolete defines.
1667 * sysdep.c: Include limits.h unconditionally.
1668
9cfdb3ec
PE
1669 Assume support for memcmp, memcpy, memmove, memset.
1670 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1671 * regex.c (memcmp, memcpy):
1672 Remove; we assume C89 now.
1673
1674 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1675 (__malloc_safe_bcopy): Remove; no longer needed.
1676
cf950e6b 1677 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1678 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1679 well either way, and we prefer signed to unsigned.
1680
dbf38e02
LMI
16812011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1682
1683 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1684 closes the connection while we're reading (bug#9182).
1685
d6f0886c 16862011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1687
d6f0886c
JD
1688 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1689 are specified (Bug#9168).
24e0f6b1 1690
2eb1f9e6
PE
16912011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1692
1693 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1694 Found by GCC static checking and --with-wide-int on a 32-bit host.
1695
22381272 16962011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1697
1698 * xdisp.c (compute_display_string_pos): Fix logic of caching
1699 previous display string position. Initialize cached_prev_pos to
1700 -1. Fixes slow-down at the beginning of a buffer.
1701
f25e39b4
EZ
17022011-07-24 Eli Zaretskii <eliz@gnu.org>
1703
1704 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1705 for attrs[LFACE_FONTSET_INDEX].
1706
04c4b52e
PE
17072011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1708
1709 * xml.c (parse_region): Remove unused local
1710 that was recently introduced.
1711
c1734fbd
EZ
17122011-07-23 Eli Zaretskii <eliz@gnu.org>
1713
be18c5a5
EZ
1714 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1715 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1716
c1734fbd
EZ
1717 * xdisp.c (move_it_in_display_line_to): Record the best matching
1718 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1719 exit if none of the characters scanned was an exact match.
1720 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1721 when exact match is impossible due to invisible text, and the
1722 lines are truncated.
1723
a258d627
JD
17242011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1725
1726 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1727 for OSX >= 10.7.
1728
b6d5a689
EZ
17292011-07-22 Eli Zaretskii <eliz@gnu.org>
1730
0f74f785
EZ
1731 Fix a significant slow-down of cursor motion with C-n, C-p,
1732 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1733 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1734 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1735 (next_element_from_buffer): Call compute_stop_pos_backwards to
1736 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1737 base_level_stop.
1738 (reseat): Don't look for prev_stop, as that could mean a very long
1739 run.
1740 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1741 <cached_disp_overlay_modiff>: Cache for last found display string
1742 position.
551918c1 1743 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1744 about the same buffer in the same area of character positions, and
1745 the buffer wasn't changed since the time the display string
1746 position was cached.
551918c1 1747
b2d0c91a
EZ
17482011-07-22 Eli Zaretskii <eliz@gnu.org>
1749
1750 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1751 is an integer, which is important for empty lines. (Bug#9149)
1752
043604ee
CY
17532011-07-22 Chong Yidong <cyd@stupidchicken.com>
1754
1755 * frame.c (Fmodify_frame_parameters): In tty case, update the
1756 default face if necessary (Bug#4238).
1757
da4adb04
CY
17582011-07-21 Chong Yidong <cyd@stupidchicken.com>
1759
1760 * editfns.c (Fstring_to_char): No need to explain what a character
1761 is in the docstring (Bug#6576).
1762
9abd0532
LMI
17632011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1764
1765 * xml.c (parse_region): Make sure we always return a tree.
1766
36881d16
HK
17672011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1768
1769 * xml.c (parse_region): If a document contains only comments,
1770 return that, too.
1771
1e98674d
LMI
17722011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1773
1774 * xml.c (make_dom): Return comments, too.
1775
590bd467
PE
17762011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1777
1778 Port to OpenBSD.
1779 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1780 and the surrounding thread.
1781 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1782 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1783 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1784 timer goes off.
1785 * s/openbsd.h (BROKEN_SIGIO): Define.
1786 * unexelf.c (unexec) [__OpenBSD__]:
1787 Don't update the .mdebug section of the Alpha COFF symbol table.
1788
f41628b2
LMI
17892011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1790
1791 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1792 (bug#8460).
1793
b59b67c5
PE
17942011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1795
15e3a074
PE
1796 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1797 This fixes some race conditions on the permissions of any newly
1798 created file.
1799
41bed37d
PE
1800 * alloc.c (valid_pointer_p): Use pipe, not open.
1801 This fixes some permissions issues when debugging.
1802
b59b67c5
PE
1803 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1804 If fchown fails to set both uid and gid, try to set just gid,
1805 as that is sometimes allowed. Adjust the file's mode to eliminate
1806 setuid or setgid bits that are inappropriate if fchown fails.
1807
925a6be7
SM
18082011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1809
1810 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1811 to compare Lisp_Objects.
1812 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1813 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1814 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1815
52968808
AS
18162011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1817
0a6a104b
AS
1818 * lread.c (read_integer): Unread even EOF character.
1819 (read1): Likewise. Properly record start position of symbol.
1820
52968808
AS
1821 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1822 symbol character follows.
1823
9e381cdd
PE
18242011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1825
1826 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1827 This works around a problem with the previous change to Fcopy_file.
1828 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1829 and without this change, GCC might complain about discarding
1830 fchown's return value.
1831
b5641435
JB
18322011-07-16 Juanma Barranquero <lekktu@gmail.com>
1833
1834 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1835
a8031457
PE
18362011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1837
1838 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1839
dd889327
LMI
18402011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1841
750c33f7
LMI
1842 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1843 it's used from the C level.
1844
dd889327
LMI
1845 * process.c: Use the same condition for POLL_FOR_INPUT in both
1846 keyboard.c and process.c (bug#1858).
1847
87e86684
LM
18482011-07-09 Lawrence Mitchell <wence@gmx.li>
1849
1850 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1851 (Fgnutls_boot): Use it.
1852
64348f40
AS
18532011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1854
1855 * doc.c (Fsubstitute_command_keys): Revert last change.
1856
1d698799
LMI
18572011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1858
f863868c
LMI
1859 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1860 quotes the next character, and doesn't affect other longer
1861 sequences (bug#8935).
1862
1d698799
LMI
1863 * lread.c (syms_of_lread): Clarify that is isn't only
1864 `eval-buffer' and `eval-defun' that's affected by
1865 `lexical-binding' (bug#8460).
1866
aa4b6df6
EZ
18672011-07-15 Eli Zaretskii <eliz@gnu.org>
1868
1869 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1870 bidi redisplay when a line includes both an image and is
1871 truncated.
1872
5d856da6
PE
18732011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1874
ad6042bb
PE
1875 Fix minor problems found by static checking.
1876 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1877 (elsz): Now a signed constant, not a size_t var. We prefer signed
1878 types to unsigned, to avoid integer comparison confusion. Without
1879 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1880 "cannot optimize loop, the loop counter may overflow", a symptom
1881 of the confusion.
f00bbb22 1882 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1883 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1884
6468f31c
LMI
18852011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1886
49080b10
LMI
1887 * search.c (Fre_search_backward): Mention `case-fold-search' in
1888 all the re_search_* functions (bug#8138).
1889
6468f31c
LMI
1890 * keyboard.c (Fopen_dribble_file): Document when the file is
1891 closed (bug#8056).
1892
c965adc5
EZ
18932011-07-14 Eli Zaretskii <eliz@gnu.org>
1894
df9733bf
EZ
1895 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1896 bidi_cache_idx.
1897
0bb23927
EZ
1898 Support bidi reordering of display and overlay strings.
1899 * xdisp.c (compute_display_string_pos)
1900 (compute_display_string_end): Accept additional argument STRING.
1901 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1902 (reseat_to_string): Initialize bidi_it->string.s and
1903 bidi_it->string.schars.
1904 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1905 NULL (avoids a crash in bidi_paragraph_init).
1906 Initialize itb.string.lstring.
0bb23927
EZ
1907 (init_iterator): Call bidi_init_it only of a valid
1908 buffer position was specified. Initialize paragraph_embedding to
1909 L2R.
1910 (reseat_to_string): Initialize the bidi iterator.
1911 (display_string): If we need to ignore text properties of
1912 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1913 original value of -1 will not work with bidi.)
1914 (compute_display_string_pos): First arg is now struct
1915 `text_pos *'; all callers changed. Support display properties on
1916 Lisp strings.
1917 (compute_display_string_end): Support display properties on Lisp
1918 strings.
1919 (init_iterator, reseat_1, reseat_to_string): Initialize the
1920 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1921 when iterating on a string not from display properties).
640c8776
SM
1922 (compute_display_string_pos, compute_display_string_end):
1923 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1924 arrow keys.
1925 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1926 base_level_stop; instead, set base_level_stop to BEGV.
1927 Fixes crashes in vertical-motion.
0bb23927
EZ
1928 (next_element_from_buffer): Improve commentary for when
1929 the iterator is before prev_stop.
1930 (init_iterator): Initialize bidi_p from the default value of
1931 bidi-display-reordering, not from buffer-local value. Use the
1932 buffer-local value only if initializing for buffer iteration.
1933 (handle_invisible_prop): Support invisible properties on strings
1934 that are being bidi-reordered.
1935 (set_iterator_to_next): Support bidi reordering of C strings and
1936 Lisp strings.
1937 (next_element_from_string): Support bidi reordering of Lisp
1938 strings.
1939 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1940 (display_string): Support display of R2L glyph rows.
1941 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1942 (init_iterator): Don't initialize it->bidi_p for strings
1943 here.
1944 (reseat_to_string): Initialize it->bidi_p for strings here.
1945 (next_element_from_string, next_element_from_c_string)
1946 (next_element_from_buffer): Add xassert's for correspondence
1947 between IT's object being iterated and it->bidi_it.string
1948 structure.
1949 (face_before_or_after_it_pos): Support bidi iteration.
1950 (next_element_from_c_string): Handle the case of the first string
1951 character that is not the first one in the visual order.
1952 (get_visually_first_element): New function, refactored from common
1953 parts of next_element_from_buffer, next_element_from_string, and
1954 next_element_from_c_string.
1955 (tool_bar_lines_needed, redisplay_tool_bar)
1956 (display_menu_bar): Force left-to-right direction. Add a FIXME
1957 comment for making that be controlled by a user option.
1958 (push_it, pop_it): Save and restore the state of the
1959 bidi iterator. Save and restore the bidi_p flag.
1960 (pop_it): Iterate out of display property for string iteration as
1961 well.
1962 (iterate_out_of_display_property): Support iteration over strings.
1963 (handle_single_display_spec): Set up it->bidi_it for iteration
1964 over a display string, and call bidi_init_it.
1965 (handle_single_display_spec, next_overlay_string)
1966 (get_overlay_strings_1, push_display_prop): Set up the bidi
1967 iterator for displaying display or overlay strings.
1968 (forward_to_next_line_start): Don't use the shortcut if
1969 bidi-iterating.
1970 (back_to_previous_visible_line_start): If handle_display_prop
1971 pushed the iterator stack, restore the internal state of the bidi
1972 iterator by calling bidi_pop_it same number of times.
1973 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1974 and we are bidi-iterating, don't decrement the iterator position;
1975 instead, set the first_elt flag in the bidi iterator, to produce
1976 the same effect.
1977 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1978 (push_display_prop): xassert that we are iterating a buffer.
1979 (push_it, pop_it): Save and restore paragraph_embedding member.
1980 (handle_single_display_spec, next_overlay_string)
1981 (get_overlay_strings_1, reseat_1, reseat_to_string)
1982 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1983 correctly. Don't assume unibyte strings are not bidi-reordered.
1984 (compute_display_string_pos)
1985 (compute_display_string_end): Fix handling the case of C string.
1986 (push_it, pop_it): Save and restore from_disp_prop_p.
1987 (handle_single_display_spec, push_display_prop): Set the
1988 from_disp_prop_p flag.
1989 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1990 (pop_it): Call iterate_out_of_display_property only if we are
1991 popping after iteration over a string that came from a display
1992 property. Fix a typo in popping stretch info. Add an assertion
1993 for verifying that the iterator position is in sync with the bidi
1994 iterator.
1995 (handle_single_display_spec, get_overlay_strings_1)
1996 (push_display_prop): Fix initialization of paragraph direction for
1997 string when that of the parent object is not yet determined.
1998 (reseat_1): Call bidi_init_it to resync the bidi
1999 iterator with IT's position. (Bug#7616)
2000 (find_row_edges): If ROW->start.pos gives position
2001 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2002 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2003 Reset the from_disp_prop_p flag.
2004 (SAVE_IT, RESTORE_IT): New macros.
2005 (pos_visible_p, face_before_or_after_it_pos)
2006 (back_to_previous_visible_line_start)
2007 (move_it_in_display_line_to, move_it_in_display_line)
2008 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2009 (try_scrolling, redisplay_window, display_line): Use them when
2010 saving a temporary copy of the iterator and restoring it back.
2011 (back_to_previous_visible_line_start, reseat_1)
2012 (init_iterator): Empty the bidi cache "stack".
2013 (move_it_in_display_line_to): If iterator ended up at
2014 EOL, but we never saw any buffer positions smaller than
2015 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2016 motion in bidi-reordered lines.
2017 (move_it_in_display_line_to): Record prev_method and prev_pos
2018 immediately before the call to set_iterator_to_next. Fixes cursor
2019 motion in bidi-reordered lines with stretch glyphs and strings
2020 displayed in margins. (Bug#8133) (Bug#8867)
2021 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2022 TO_CHARPOS.
640c8776
SM
2023 (pos_visible_p): Support positions in bidi-reordered lines.
2024 Save and restore bidi cache.
0bb23927
EZ
2025
2026 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2027 (bidi_paragraph_info): Delete unused struct.
2028 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2029 (bidi_cache_start): New variable.
2030 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2031 to zero.
2032 (bidi_cache_fetch_state, bidi_cache_search)
2033 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2034 (bidi_cache_find, bidi_peek_at_next_level)
2035 (bidi_level_of_next_char, bidi_find_other_level_edge)
2036 (bidi_move_to_visually_next): Compare cache index with
2037 bidi_cache_start rather than with zero.
2038 (bidi_fetch_char): Accept new argument STRING; all callers
2039 changed. Support iteration over a string. Support strings with
2040 display properties. Support unibyte strings. Fix the type of
2041 `len' according to what STRING_CHAR_AND_LENGTH expects.
2042 (bidi_paragraph_init, bidi_resolve_explicit_1)
2043 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2044 (bidi_level_of_next_char, bidi_move_to_visually_next):
2045 Support iteration over a string.
0bb23927
EZ
2046 (bidi_set_sor_type, bidi_resolve_explicit_1)
2047 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2048 can now be zero (for strings); special values 0 and -1 were
2049 changed to -1 and -2, respectively.
2050 (bidi_char_at_pos): New function.
2051 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2052 Call it instead of FETCH_MULTIBYTE_CHAR.
2053 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2054 initialized to valid values.
2055 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2056 values.
2057 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2058 the test for valid cached positions. Fix the logic for looking up
2059 the sentinel state in the cache. GCPRO the Lisp string we are
2060 iterating.
2061 (bidi_push_it, bidi_pop_it): New functions.
2062 (bidi_initialize): Initialize the bidi cache start stack pointer.
2063 (bidi_cache_ensure_space): New function, refactored from part of
2064 bidi_cache_iterator_state. Don't assume the required size is just
2065 one BIDI_CACHE_CHUNK away.
2066 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2067 (bidi_count_bytes, bidi_char_at_pos): New functions.
2068 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2069 always valid if bidi_cache_idx is valid.
2070 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2071 is valid if it's going to be used.
2072 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2073 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2074 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2075 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2076 (bidi_find_other_level_edge, bidi_cache_start_stack):
2077 All variables related to cache indices are now EMACS_INT.
c965adc5 2078
0bb23927
EZ
2079 * dispextern.h (struct bidi_string_data): New structure.
2080 (struct bidi_it): New member `string'. Make flag members be 1-bit
2081 fields, and put them last in the struct.
640c8776
SM
2082 (compute_display_string_pos, compute_display_string_end):
2083 Update prototypes.
0bb23927
EZ
2084 (bidi_push_it, bidi_pop_it): Add prototypes.
2085 (struct iterator_stack_entry): New members bidi_p,
2086 paragraph_embedding, and from_disp_prop_p.
2087 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2088 (bidi_shelve_cache, bidi_unshelve_cache):
2089 Declare prototypes.
0bb23927
EZ
2090
2091 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2092 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2093 and vector-like objects.
2094
2095 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2096 cache around display iteration.
2097
2098 * window.c (Fwindow_end, window_scroll_pixel_based)
2099 (displayed_window_lines, Frecenter): Save and restore the bidi
2100 cache around display iteration.
2101
3bbd2265
LMI
21022011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2103
2104 * editfns.c (Fdelete_region): Clarify the use of the named
2105 parameters (bug#6788).
2106
adc47434
MR
21072011-07-14 Martin Rudalics <rudalics@gmx.at>
2108
2109 * indent.c (Fvertical_motion): Set and restore w->pointm when
2110 saving and restoring the window's buffer (Bug#9006).
2111
837c31f8
LMI
21122011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2113
2114 * editfns.c (Fstring_to_char): Clarify just what is returned
2115 (bug#6576). Text by Eli Zaretskii.
2116
ac389d0c
JB
21172011-07-13 Juanma Barranquero <lekktu@gmail.com>
2118
2119 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2120
0be0ce47
EZ
21212011-07-13 Eli Zaretskii <eliz@gnu.org>
2122
2123 * buffer.c (mmap_find): Fix a typo.
2124
cd18e7e3
JB
21252011-07-13 Johan Bockgård <bojohan@gnu.org>
2126
2127 Fix execution of x selection hooks.
2128 * xselect.c (Qx_lost_selection_functions)
2129 (Qx_sent_selection_functions): New vars.
2130 (syms_of_xselect): DEFSYM them.
2131 (x_handle_selection_request): Pass Qx_sent_selection_functions
2132 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2133 (x_handle_selection_clear,x_clear_frame_selections):
2134 Pass Qx_lost_selection_functions rather than
2135 Vx_lost_selection_functions to Frun_hook_with_args.
2136
47ea7f44
PE
21372011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2138
ac389d0c 2139 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2140 The old code sometimes used this field without initializing it.
2141
47ea7f44
PE
2142 * alloc.c (gc_sweep): Don't read past end of array.
2143 In theory, the old code could also have corrupted Emacs internals,
2144 though it'd be very unlikely.
2145
bc985c87
AS
21462011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2147
2148 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2149 argument. (Bug#4026)
bc985c87 2150
0cf34688
LMI
21512011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2152
b3dadd76
LMI
2153 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2154 key" (bug#4257).
2155
0cf34688
LMI
2156 * window.c (Fset_window_start): Doc fix (bug#4199).
2157 (Fset_window_hscroll): Ditto.
2158
270768cd
PE
21592011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2160
077e3dda 2161 Fix minor new problems caught by GCC 4.6.1.
270768cd 2162 * term.c (init_tty): Remove unused local.
490011a6 2163 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2164 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2165 not used otherwise.
270768cd 2166
b1f58454
CY
21672011-07-12 Chong Yidong <cyd@stupidchicken.com>
2168
2169 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2170
22b9578d
LMI
21712011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2172
6e70ab07
LMI
2173 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2174 are the mini-buffer and the echo area (bug#3320).
2175
22b9578d
LMI
2176 * term.c (init_tty): Remove support for supdup, c10 and perq
2177 terminals, which are no longer supported (bug#1482).
2178
8974cc9f
JB
21792011-07-10 Johan Bockgård <bojohan@gnu.org>
2180
2181 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2182
a560d974
JD
21832011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2184
2185 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2186 for non-popups (Bug#3642).
2187
1dae0f0a
AS
21882011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2189
268c2c36 2190 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2191 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2192 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2193 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2194 * data.c (fmod): Likewise.
2195 * dispnew.c (swap_glyphs_in_rows): Likewise.
2196 * emacs.c (memory_warning_signal): Likewise.
2197 * floatfns.c (float_error): Likewise.
2198 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2199 (otf_open, font_otf_capability, generate_otf_features)
2200 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2201 Likewise.
2202 * image.c (pbm_read_file): Likewise.
2203 * indent.c (string_display_width): Likewise.
2204 * intervals.c (check_for_interval, search_for_interval)
2205 (inc_interval_count, count_intervals, root_interval)
2206 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2207 * lread.c (defalias): Likewise.
268c2c36 2208 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2209 * regex.c (set_image_of_range_1, set_image_of_range)
2210 (regex_grow_registers): Likewise.
2211 * sysdep.c (strerror): Likewise.
2212 * termcap.c (valid_filename_p, tprint, main): Likewise.
2213 * tparam.c (main): Likewise.
2214 * unexhp9k800.c (run_time_remap, save_data_space)
2215 (update_file_ptrs, read_header, write_header, calculate_checksum)
2216 (copy_file, copy_rest, display_header): Likewise.
2217 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2218 Likewise.
2219 * xdisp.c (check_it): Likewise.
2220 * xfaces.c (register_color, unregister_color, unregister_colors):
2221 Likewise.
2222 * xfns.c (print_fontset_result): Likewise.
2223 * xrdb.c (member, fatal, main): Likewise.
2224
99033785
PE
22252011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2226
2227 Fix minor problems found by static checking (Bug#9031).
2228 * chartab.c (char_table_set_range, map_sub_char_table):
2229 Remove unused locals.
2230 (uniprop_table): Now static.
2231 * composite.c (_work_char): Remove unused static var.
2232
9cb2ac56
JB
22332011-07-09 Juanma Barranquero <lekktu@gmail.com>
2234
2235 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2236
f25661f0
JD
22372011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2238
2239 * gtkutil.c (qttip_cb): Remove code without function.
2240
8278c4fe
EZ
22412011-07-09 Eli Zaretskii <eliz@gnu.org>
2242
2243 * w32.c (pthread_sigmask): New stub.
2244
1692ae2d 22452011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2246
8a6ebd58 2247 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2248 sigprocmask is portable only for single-threaded applications, and
2249 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2250 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2251 (LIBES): Use it.
2252 * callproc.c (Fcall_process):
2253 * process.c (create_process):
2254 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2255 Use pthread_sigmask, not sigprocmask.
123403e4 2256
1b854618
JD
22572011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2258
2259 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2260 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2261 wrong (Bug#8591).
2262
3fe4b549
JD
22632011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2264
0ce7e563
JD
2265 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2266 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2267 (xg_hide_tooltip): Fix comment.
2268
3fe4b549
JD
2269 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2270 in registerServicesMenuSendTypes.
2271 (validRequestorForSendType): Don't check ns_return_types.
2272
2273 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2274 ns_return_type.
2275
5df75e47
JR
22762011-07-08 Jason Rumney <jasonr@gnu.org>
2277
2278 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2279 frame struct members of non-existent frames (Bug#6284).
2280
699c10bd
JD
22812011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2282
4393663b
JD
2283 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2284 variable firstTime not needed on OSX >= 10.6.
2285 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2286 >= 10.5. Use setKnobProportion, setDoubleValue.
2287
2288 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2289 (MAC_OS_X_VERSION_10_5): Define if not defined.
2290 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2291 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2292 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2293
2294 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2295 cString and lossyCString on OSX >= 10.4
2296
2297 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2298 sizeToFit on OSX >= 10.2.
2299
2300 * nsimage.m (allocInitFromFile): Don't use deprecated method
2301 bestRepresentationForDevice on OSX >= 10.6.
2302
2303 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2304 to avoid warning.
2305
2306 * emacs.c: Declare unexec_init_emacs_zone.
2307
a63e0781
JD
2308 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2309
699c10bd
JD
2310 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2311
2312 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2313 on svcsMenu (Bug#8842).
2314
2315 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2316 ns_return_types.
2317 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2318
2319 * nsterm.m (QUTF8_STRING): Declare.
2320 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2321 (validRequestorForSendType): Return type is (id).
2322 Change indexOfObjectIdenticalTo to indexOfObject.
2323 Check if we have local selection before returning self (Bug#8842).
2324 (writeSelectionToPasteboard): Put local selection into paste board
2325 if we have a local selection (Bug#8842).
2326 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2327
2328 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2329 (ns_get_local_selection): Declare.
2330
54e10184
LMI
23312011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2332
9888ff71
LMI
2333 * keymap.c (describe_map_tree): Don't insert a double newline at
2334 the end of the buffer (bug#1169) and return whether we inserted
2335 something.
2336
54e10184
LMI
2337 * callint.c (Fcall_interactively): Change "reading args" to
2338 "providing args" to try to clarify what it does (bug#1010).
2339
15fa4783
KH
23402011-07-07 Kenichi Handa <handa@m17n.org>
2341
2342 * composite.c (composition_compute_stop_pos): Ignore a static
2343 composition starting before CHARPOS (Bug#8915).
2344
2345 * xdisp.c (handle_composition_prop): Likewise.
2346
a8815b00
EZ
23472011-07-07 Eli Zaretskii <eliz@gnu.org>
2348
2349 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2350 (Bug#9015)
2351
ef7b981d 23522011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2353
2354 * character.h (unicode_category_t): New enum type.
2355
2356 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2357 (Qchar_code_property_table): New variable.
2358 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2359 (UNIPROP_COMPRESSED_FORM_P): New macros.
2360 (char_table_ascii): Uncompress the compressed values.
2361 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2362 Uncompress the compressed values.
ac389d0c 2363 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2364 (char_table_ref_and_range): Uncompress the compressed values.
2365 (sub_char_table_set): New arg is_uniprop. Callers changed.
2366 Uncompress the compressed values.
2367 (sub_char_table_set_range): Args changed. Callers changed.
2368 (char_table_set_range): Adjuted for the above change.
2369 (map_sub_char_table): Delete args default_val and parent. Add arg
2370 top. Give decoded values to a Lisp function.
640c8776 2371 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2372 values to a Lisp function. Gcpro more variables.
2373 (uniprop_table_uncompress)
2374 (uniprop_decode_value_run_length): New functions.
2375 (uniprop_decoder, uniprop_decoder_count): New variables.
2376 (uniprop_get_decoder, uniprop_encode_value_character)
2377 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2378 New functions.
2379 (uniprop_encoder, uniprop_encoder_count): New variables.
2380 (uniprop_get_encoder, uniprop_table)
2381 (Funicode_property_table_internal, Fget_unicode_property_internal)
2382 (Fput_unicode_property_internal): New functions.
2383 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2384 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2385 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2386 char-code-property-alist.
2387
640c8776 2388 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2389 Vunicode_category_table.
2390
640c8776 2391 * font.c (font_range): Adjust for the change of
c805dec0
KH
2392 Vunicode_category_table.
2393
76b397fb
DN
23942011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2395
2396 * m/iris4d.h: Remove file, move contents ...
2397 * s/irix6-5.h: ... here.
2398
22b4128e
PE
23992011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2400
2401 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2402 * alloc.c (mark_buffer):
2403 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2404 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2405 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2406 This isn't true in general, and it's particularly not true
2407 if Emacs is configured with --with-wide-int.
2408 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2409 New macros, used in the buffer.c change.
2410
869795d6
JD
24112011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2412
2413 * xsettings.c: Use both GConf and GSettings if both are available.
2414 (store_config_changed_event): Add comment.
2415 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2416 (store_tool_bar_style_changed): New functions.
5e617bc2 2417 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2418 (struct xsettings): Move font inside HAVE_XFT.
2419 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2420 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2421 Move inside HAVE_XFT.
640c8776 2422 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2423 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2424 also.
2425 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2426 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2427 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2428 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2429 (parse_settings): Move check for font inside HAVE_XFT.
2430 (read_settings, apply_xft_settings): Add comment.
2431 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2432 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2433 call store_font_name_changed.
2434 (xft_settings_event): Add comment.
2435 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2436 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2437 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2438 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2439 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2440 (xsettings_get_system_font, xsettings_get_system_normal_font):
2441 Add comment.
869795d6 2442
d8ed26bd
PE
24432011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2444
2445 Random fixes. E.g., (random) never returned negative values.
2446 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2447 subseconds part to the entropy, as that's a bit more random.
2448 Prefer signed to unsigned, since the signedness doesn't matter and
2449 in general we prefer signed. When given a limit, use a
2450 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2451 latter isn't right if USE_2_TAGS_FOR_INTS.
2452 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2453 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2454
cabf1cac
SM
24552011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2456
2457 * textprop.c (text_property_stickiness):
2458 Obey Vtext_property_default_nonsticky.
2459 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2460 * w32fns.c (syms_of_w32fns):
2461 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2462
6e9b2be9
PE
24632011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2464
2465 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2466 This is more efficient than Ffile_directory_p and avoids a minor race.
2467
90186c68
LMI
24682011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2469
7c301272
LMI
2470 * buffer.c (Foverlay_put): Say what the return value is
2471 (bug#7835).
2472
c4f2d8d4
LMI
2473 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2474 is a directory before asking whether to use the file name
2475 (bug#7564).
ad637907
LMI
2476 (barf_or_query_if_file_exists): Make the "File is a directory"
2477 error be more correct.
c4f2d8d4 2478
90186c68
LMI
2479 * fns.c (Frequire): Remove the mention of the .gz files, since
2480 that's installation-specific, but keep the mention of
2481 `get-load-suffixes'.
2482
da64016e
PE
24832011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2484
2485 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2486 Report string overflow if the output is too long.
2487
7d47b580
JB
24882011-07-04 Juanma Barranquero <lekktu@gmail.com>
2489
a555cb87
JB
2490 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2491 (syms_of_gnutls): Remove duplicate DEFSYM for
2492 Qgnutls_bootprop_verify_hostname_error, an error for
2493 Qgnutls_bootprop_verify_error (which is no longer used).
2494
7d47b580
JB
2495 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2496 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2497 Also (re)move comments that are misplaced or no longer relevant.
2498
1e49bfab
LMI
24992011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2500
2501 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2502
1485f4c0
CY
25032011-07-03 Chong Yidong <cyd@stupidchicken.com>
2504
2505 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2506 and background color parameters if they have been changed.
2507
a9ab721e
LMI
25082011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2509
2510 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2511
cf7cff57
PE
25122011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2513
2e13213d
PE
2514 * xsettings.c (SYSTEM_FONT): Define only when used.
2515 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2516
cf7cff57
PE
2517 * keymap.c (access_keymap_1): Now static.
2518
7a8e04f7
CY
25192011-07-02 Chong Yidong <cyd@stupidchicken.com>
2520
2521 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2522 leave any prefix arg for the up event (Bug#1586).
2523
61352f62
LMI
25242011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2525
69bb1ef7
LMI
2526 * lread.c (syms_of_lread): Mention single symbols defined by
2527 `defvar' or `defconst' (bug#7154).
2528
61352f62 2529 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2530 (Frequire): Mention get-load-suffixes.
61352f62 2531
28545e04
MR
25322011-07-02 Martin Rudalics <rudalics@gmx.at>
2533
2534 * window.h (window): Remove clone_number slot.
2535 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2536 Remove.
2537 (make_parent_window, make_window, saved_window)
2538 (Fset_window_configuration, save_window_save): Don't deal with
2539 clone numbers.
2540 * buffer.c (Qclone_number): Remove declaration.
2541 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2542
3349e122
SM
25432011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2544
2545 Add multiple inheritance to keymaps.
2546 * keymap.c (Fmake_composed_keymap): New function.
2547 (Fset_keymap_parent): Simplify.
2548 (fix_submap_inheritance): Remove.
2549 (access_keymap_1): New function extracted from access_keymap to handle
2550 embedded parents and handle lists of maps.
2551 (access_keymap): Use it.
2552 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2553 (Fcopy_keymap): Handle embedded parents.
2554 (Fcommand_remapping, define_as_prefix): Simplify.
2555 (Fkey_binding): Simplify.
2556 (syms_of_keymap): Move minibuffer-local-completion-map,
2557 minibuffer-local-filename-completion-map,
2558 minibuffer-local-must-match-map, and
2559 minibuffer-local-filename-must-match-map to Elisp.
2560 (syms_of_keymap): Defsubr make-composed-keymap.
2561 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2562 (parse_menu_item): Trivial simplification.
2563
3279eb87
GM
25642011-07-01 Glenn Morris <rgm@gnu.org>
2565
2566 * Makefile.in (SETTINGS_LIBS): Fix typo.
2567
4550efdf
KI
25682011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2569
2570 * coding.c (Fencode_coding_string): Record the last coding system
2571 used, as the function doc string says (bug#8738).
2572
0949d2b6
JD
25732011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2574
2575 * xsettings.c (store_monospaced_changed): Take new font as arg and
2576 check for change against current_mono_font.
2577 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2578 (emacs_settings_constructor, emacs_settings_get_property)
2579 (emacs_settings_set_property, emacs_settings_class_init)
2580 (emacs_settings_init, gsettings_obj): Remove.
2581 (something_changedCB): New function for HAVE_GSETTINGS.
2582 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2583 with value as argument.
2584 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2585 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2586 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2587 "changed".
2588
2589 * xgselect.c: Add defined (HAVE_GSETTINGS).
2590 (xgselect_initialize): Ditto.
2591
2592 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2593 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2594 xg_select.
2595
bbc6b304
PE
25962011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2597
2598 * eval.c (struct backtrace): Simplify and port the data structure.
2599 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2600 signed bit field, as this assumption is not portable and it makes
2601 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2602 "char debug_on_exit : 1" as this is not portable either; instead,
2603 use the portable "unsigned int debug_on_exit : 1". Remove unused
2604 member evalargs. Remove obsolete comments about cc bombing out.
2605
9851bfc5
JD
26062011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2607
51bb811f 2608 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2609 Let HAVE_GSETTINGS override HAVE_GCONF.
2610 (store_monospaced_changed): New function.
2611 (EMACS_SETTINGS): A new type derived from GObject to handle
2612 GSettings notifications.
2613 (emacs_settings_constructor, emacs_settings_get_property)
2614 (emacs_settings_set_property, emacs_settings_class_init):
2615 New functions.
2616 (gsettings_client, gsettings_obj): New variables.
2617 (GSETTINGS_SCHEMA): New define.
2618 (something_changedCB): Call store_monospaced_changed.
2619 (init_gsettings): New function.
2620 (xsettings_initialize): Call init_gsettings.
2621 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2622 to NULL.
2623
640c8776 2624 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2625 GCONF_CFLAGS/LIBS.
2626
5386012d
MR
26272011-06-29 Martin Rudalics <rudalics@gmx.at>
2628
2629 * window.c (resize_root_window, grow_mini_window)
2630 (shrink_mini_window): Rename Qresize_root_window to
2631 Qwindow_resize_root_window and Qresize_root_window_vertically to
2632 Qwindow_resize_root_window_vertically.
2633
f13e0b08
PE
26342011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2635
2636 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2637
94515237
JB
26382011-06-27 Juanma Barranquero <lekktu@gmail.com>
2639
2640 * makefile.w32-in: Redesign dependencies so they reflect more
2641 clearly which files are directly included by each source file,
2642 and not through other includes.
2643
e43b6e43
MR
26442011-06-27 Martin Rudalics <rudalics@gmx.at>
2645
2646 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2647 (sort_overlays, overlay_strings): When an overlay's clone number
2648 matches the window's clone number process the overlay even if
2649 the overlay's window property doesn't match the current window.
2650
d68443dc
MR
2651 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2652 (Fwindow_hchild): Rename to Fwindow_left_child.
2653 (Fwindow_next): Rename to Fwindow_next_sibling.
2654 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2655 (resize_window_check): Rename to window_resize_check.
2656 (resize_window_apply): Rename to window_resize_apply.
2657 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2658 (Fdelete_other_windows_internal, resize_frame_windows)
2659 (Fsplit_window_internal, Fdelete_window_internal)
2660 (grow_mini_window, shrink_mini_window)
2661 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2662
c7e73be5
JD
26632011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2664
2665 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2666 (emacs_fixed_set_min_size): Remove.
2667 (emacs_fixed_new): Take frame as argument.
2668
2669 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2670 (_EmacsFixedPrivate): Remove minwidth/height.
2671 Add struct frame *f.
2672 (emacs_fixed_init): Initialize priv->f.
2673 (get_parent_class, emacs_fixed_set_min_size): Remove.
2674 (emacs_fixed_new): Set priv->f to argument.
2675 (emacs_fixed_get_preferred_width)
2676 (emacs_fixed_get_preferred_height): Use min_width/height from
2677 frames size_hint to set minimum and natural (Bug#8919).
2678 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2679 and use min_width/height from frames size_hint to set
2680 min_width/height (Bug#8919).
2681
2682 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2683 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2684 Fix indentation.
c7e73be5 2685
cf99dcf8
EZ
26862011-06-26 Eli Zaretskii <eliz@gnu.org>
2687
2688 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2689 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2690 called at ZV.
2691
029529ac
CY
26922011-06-26 Chong Yidong <cyd@stupidchicken.com>
2693
2694 * process.c (wait_reading_process_output): Bypass select if
2695 waiting for a cell while ignoring keyboard input, and input is
2696 pending. Suggested by Jan Djärv (Bug#8869).
2697
7a7ef429
PE
26982011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2699
2700 Use gnulib's dup2 module instead of rolling our own.
2701 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2702
11fdef7d 27032011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2704
2705 * dispnew.c (scrolling_window): Before scrolling, turn off a
2706 mouse-highlight in the window being scrolled.
2707
cd3520a4
JB
27082011-06-24 Juanma Barranquero <lekktu@gmail.com>
2709
2710 Move DEFSYM to lisp.h and use everywhere.
2711
2712 * character.h (DEFSYM): Move declaration...
2713 * lisp.h (DEFSYM): ...here.
2714
2715 * gnutls.c:
2716 * minibuf.c:
2717 * w32menu.c:
2718 * w32proc.c:
2719 * w32select.c: Don't include character.h.
2720
2721 * alloc.c (syms_of_alloc):
2722 * buffer.c (syms_of_buffer):
2723 * bytecode.c (syms_of_bytecode):
2724 * callint.c (syms_of_callint):
2725 * casefiddle.c (syms_of_casefiddle):
2726 * casetab.c (init_casetab_once):
2727 * category.c (init_category_once, syms_of_category):
2728 * ccl.c (syms_of_ccl):
2729 * cmds.c (syms_of_cmds):
2730 * composite.c (syms_of_composite):
2731 * dbusbind.c (syms_of_dbusbind):
2732 * dired.c (syms_of_dired):
2733 * dispnew.c (syms_of_display):
2734 * doc.c (syms_of_doc):
2735 * editfns.c (syms_of_editfns):
2736 * emacs.c (syms_of_emacs):
2737 * eval.c (syms_of_eval):
2738 * fileio.c (syms_of_fileio):
2739 * fns.c (syms_of_fns):
2740 * frame.c (syms_of_frame):
2741 * fringe.c (syms_of_fringe):
2742 * insdel.c (syms_of_insdel):
2743 * keymap.c (syms_of_keymap):
2744 * lread.c (init_obarray, syms_of_lread):
2745 * macros.c (syms_of_macros):
2746 * msdos.c (syms_of_msdos):
2747 * print.c (syms_of_print):
2748 * process.c (syms_of_process):
2749 * search.c (syms_of_search):
2750 * sound.c (syms_of_sound):
2751 * syntax.c (init_syntax_once, syms_of_syntax):
2752 * terminal.c (syms_of_terminal):
2753 * textprop.c (syms_of_textprop):
2754 * undo.c (syms_of_undo):
2755 * w32.c (globals_of_w32):
2756 * window.c (syms_of_window):
2757 * xdisp.c (syms_of_xdisp):
2758 * xfaces.c (syms_of_xfaces):
2759 * xfns.c (syms_of_xfns):
2760 * xmenu.c (syms_of_xmenu):
2761 * xsettings.c (syms_of_xsettings):
2762 * xterm.c (syms_of_xterm): Use DEFSYM.
2763
4228cf16
TZ
27642011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2765
cd3520a4 2766 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2767
7fcccf1e
PE
27682011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2769
7efb4e0e
PE
2770 Integer and buffer overflow fixes (Bug#8873).
2771
ff5844ad
PE
2772 * print.c (printchar, strout): Check for string overflow.
2773 (PRINTPREPARE, printchar, strout):
2774 Don't set size unless allocation succeeds.
2775
90532f02
PE
2776 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2777 for sizes. Check for string overflow more accurately.
2778 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2779
6d84508d
PE
2780 * macros.c: Integer and buffer overflow fixes.
2781 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2782 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2783 Use ptrdiff_t, not int, for sizes.
2784 Don't increment bufsize until after realloc succeeds.
2785 Check for size-calculation overflow.
2786 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2787
437b2cb4
PE
2788 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2789
8b9ac8b4
PE
2790 * lread.c: Integer overflow fixes.
2791 (read_integer): Radix is now EMACS_INT, not int,
2792 to improve quality of diagnostics for out-of-range radices.
2793 Calculate buffer size correctly for out-of-range radices.
2794 (read1): Check for integer overflow in radices, and in
2795 read-circle numbers.
82cb60d3
PE
2796 (read_escape): Avoid int overflow.
2797 (Fload, openp, read_buffer_size, read1)
2798 (substitute_object_recurse, read_vector, read_list, map_obarray):
2799 Use ptrdiff_t, not int, for sizes.
2800 (read1): Use EMACS_INT, not int, for sizes.
20270765 2801 Check for size overflow.
8b9ac8b4 2802
7fcccf1e
PE
2803 * image.c (cache_image): Check for size arithmetic overflow.
2804
bfbbd7e7
PE
2805 * lread.c: Integer overflow issues.
2806 (saved_doc_string_size, saved_doc_string_length)
2807 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2808 Now ptrdiff_t, not int.
2809 (read1): Don't assume doc string length fits in int. Check for
2810 out-of-range doc string lengths.
2811 (read_list): Don't assume file position fits in int.
39019e54 2812 (read_escape): Check for hex character overflow.
bfbbd7e7 2813
4e323265
LL
28142011-06-22 Leo Liu <sdl.web@gmail.com>
2815
2816 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2817 Move to minibuffer.el.
2818
85fece3e
PE
28192011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2820
20b84ce9 2821 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2822 The following patches are for when GLYPH_DEBUG && !XASSERT.
2823 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2824 * dispnew.c (flush_stdout):
2825 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2826 Mark as externally visible.
2827 * dispnew.c (check_window_matrix_pointers): Now static.
2828 * dispnew.c (window_to_frame_vpos):
2829 * xfns.c (unwind_create_frame):
2830 * xterm.c (x_check_font): Remove unused local.
2831 * scroll.c (CHECK_BOUNDS):
2832 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2833 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2834 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2835 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2836 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2837 Now static.
2838 (debug_method_add): Use va_list and vsprintf rather than relying
2839 on undefined behavior with wrong number of arguments.
2840 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2841 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2842 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2843 since we're not interested in debugging glyphs with old libraries.
2844 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2845 GCC 4.6.0's static checking.
2846
0766b489
PE
28472011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2848
31fd4b32
PE
2849 Integer overflow and signedness fixes (Bug#8873).
2850 A few related buffer overrun fixes, too.
2851
b79e8648
PE
2852 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2853
0766b489
PE
2854 * dispextern.h (struct face.stipple):
2855 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2856 (x_bitmap_mask, x_allocate_bitmap_record)
2857 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2858 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2859 (x_create_bitmap_from_xpm_data):
2860 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2861 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2862 (.bitmaps_last):
2863 * xfaces.c (load_pixmap):
2864 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2865 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2866 (.bitmaps_last, struct x_output.icon_bitmap):
2867 Use ptrdiff_t, not int, for bitmap indexes.
2868 (x_allocate_bitmap_record): Check for size overflow.
2869 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2870
b081724f
PE
2871 Use ptrdiff_t, not int, for overlay counts.
2872 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2873 * editfns.c (overlays_around, get_pos_property):
2874 * textprop.c (get_char_property_and_overlay):
2875 * xdisp.c (next_overlay_change, note_mouse_highlight):
2876 * xfaces.c (face_at_buffer_position):
21514da7
PE
2877 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2878 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2879 (Fnext_overlay_change, Fprevious_overlay_change)
2880 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2881 Use ptrdiff_t, not int, for sizes.
21514da7 2882 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2883
3de73e5e
PE
2884 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2885
2606c57b
PE
2886 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2887 (x_session_initialize): Do not assume string length fits in int.
2888
aaafe47a
PE
2889 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2890 This is unlikely, but can occur if DPI is outlandish.
2891
2674ddc8 2892 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2893 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2894
28154962
PE
2895 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2896 * xrdb.c (magic_file_p, search_magic_path):
2897 Omit last arg SUFFIX; it was always 0. All callers changed.
2898 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2899
7de51af5
PE
2900 * xfont.c (xfont_match): Avoid need for strlen.
2901
25ed6cc3
PE
2902 * xfns.c: Don't assume strlen fits in int.
2903 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2904
4eab31dd
PE
2905 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2906 not unsigned long, as we prefer signed integers. All callers changed.
2907 Detect integer overflow in repeat count.
2908 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2909 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2910
171e2a58
PE
2911 * termcap.c: Don't assume sizes fit in int and never overflow.
2912 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2913 (gobble_line): Check for size-calculation overflow.
2914
ad39faca 2915 * minibuf.c (Fread_buffer):
6e5bb2dc 2916 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2917 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2918 Don't assume string length fits in int.
2919
52c61c22 2920 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2921 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2922
b5b8c9e5
PE
2923 * font.c: Don't assume string length fits in int.
2924 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2925 Use ptrdiff_t, not int.
ccd6111c
PE
2926 (font_intern_prop): Don't assume string length fits in int.
2927 Don't assume integer property fits in fixnum.
2928 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2929
882f0d81 2930 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2931 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2932 Reformulate so as not to need the command string.
2933 Invoke gzip -cd rather than gunzip, as it's more portable.
2934 (lock_info_type, lock_file_1, lock_file):
2935 Don't assume pid_t and time_t fit in unsigned long.
2936 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2937 (current_lock_owner): Prefer signed type for sizes.
2938 Use memcpy, not strncpy, where memcpy is what is really wanted.
2939 Don't assume (via atoi) that time_t and pid_t fit in int.
2940 Check for time_t and/or pid_t out of range, e.g., via a network share.
2941 Don't alloca where an auto var works fine.
2942
93f4cf88
PE
2943 * fileio.c: Fix some integer overflow issues.
2944 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2945 Don't assume string length fits in int.
2946 (directory_file_name): Don't assume string length fits in long.
2947 (make_temp_name): Don't assume pid fits in int, or that its print
2948 length is less than 20.
2949
f3e92b69
PE
2950 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2951
1bfdaf10
PE
2952 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2953
35016e9a
PE
2954 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2955
3d1e65a1
PE
2956 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2957 We prefer signed integers, even for size calculations.
2958
0b963a93
PE
2959 * emacs.c: Don't assume string length fits in 'int'.
2960 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2961 (main): Don't invoke strlen when not needed.
2962
573f4b54
PE
2963 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2964 (XD_DEBUG_MESSAGE): Don't waste a byte.
2965
989f33ba
PE
2966 * callproc.c (getenv_internal_1, getenv_internal)
2967 (Fgetenv_internal):
965d34eb
PE
2968 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2969
e4d29b33
PE
2970 * lread.c (invalid_syntax): Omit length argument.
2971 All uses changed. This doesn't fix a bug, but it simplifies the
2972 code away from its former Hollerith-constant appearance, and it's
2973 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2974 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2975
eb49b136
PE
2976 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2977 This didn't break anything, but it didn't help either.
2978 It's confusing to put a bogus integer in a place where the actual
2979 value does not matter.
9f62aeb1 2980 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2981 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2982
15375a22
PE
2983 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2984 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2985 implementation.
b61cc01c
PE
2986 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2987 We prefer signed types, and the value cannot exceed the EMACS_INT
2988 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2989 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2990 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2991 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2992
53b2623d
PE
2993 * indent.c (sane_tab_width): New function.
2994 (current_column, scan_for_column, Findent_to, position_indentation)
2995 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2996 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2997
51cab52b 2998 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2999
f2ed8a70
PE
3000 * lisp.h (lint_assume): New macro.
3001 * composite.c (composition_gstring_put_cache):
3002 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3003
abe80cc6
PE
3004 * editfns.c, insdel.c:
3005 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3006
b02c740e
PE
3007 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3008
ebc96716
PE
3009 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3010
b4e50fa0 3011 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3012 Use much-faster test for byte-length change.
311d5d7c 3013 Don't assume string byte-length fits in 'int'.
a4cf38e4 3014 Check that character arg fits in 'int'.
85461888 3015 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3016
c0c1ee9f
PE
3017 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3018
a498d7f4
PE
3019 * fns.c (concat): Catch string overflow earlier.
3020 Do not rely on integer wraparound.
3021
51cab52b
PE
3022 * dispextern.h (struct it.overlay_strings_charpos)
3023 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3024 * xdisp.c (forward_to_next_line_start)
3025 (back_to_previous_visible_line_start)
3026 (reseat_at_next_visible_line_start, next_element_from_buffer):
3027 Don't arbitrarily truncate the value of 'selective' to int.
3028
76031fad
PE
3029 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3030
5eb55db9
PE
3031 * composite.c: Don't truncate sizes to 'int'.
3032 (composition_gstring_p, composition_reseat_it)
3033 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3034 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3035 not EMACS_UINT, for indexes.
5eb55db9 3036
0703a717
PE
3037 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3038
d6202519
PE
3039 * buffer.c: Include <verify.h>.
3040 (struct sortvec.priority, struct sortstr.priority):
8961a454 3041 Now EMACS_INT, not int.
c20998a7 3042 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3043 (struct sortstr.size, record_overlay_string)
3044 (struct sortstrlist.size, struct sortlist.used):
3045 Don't truncate size to int.
3046 (record_overlay_string): Check for size-calculation overflow.
d6202519 3047 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3048
d5a19415
JM
30492011-06-22 Jim Meyering <meyering@redhat.com>
3050
029529ac 3051 Don't leak an XBM-image-sized buffer
d5a19415
JM
3052 * image.c (xbm_load): Free the image buffer after using it.
3053
a9041e6c
PE
30542011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3055
3056 Port to Sun C.
3057 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3058 that Sun C diagnosed.
3059 * fns.c (secure_hash): Fix pointer signedness issue.
3060 * intervals.c (static_offset_intervals): New function.
3061 (offset_intervals): Use it.
3062
7f3f739f
LL
30632011-06-21 Leo Liu <sdl.web@gmail.com>
3064
3065 * deps.mk (fns.o):
3066 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3067 sha512.h.
3068
3069 * fns.c (secure_hash): Rename from crypto_hash_function and change
3070 the first arg to accept symbols.
5b66d427 3071 (Fsecure_hash): New primitive.
7f3f739f
LL
3072 (syms_of_fns): New symbols.
3073
76147d94
DD
30742011-06-20 Deniz Dogan <deniz@dogan.se>
3075
3076 * process.c (Fset_process_buffer): Clarify return value in
3077 docstring.
3078
7d7d0045
CY
30792011-06-18 Chong Yidong <cyd@stupidchicken.com>
3080
3081 * dispnew.c (add_window_display_history): Use BVAR.
3082
3083 * xdisp.c (debug_method_add): Use BVAR.
3084 (check_window_end, dump_glyph_matrix, dump_glyph)
3085 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3086
3087 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3088 Likewise.
3089
3090 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3091 check till after the cache is created in init_frame_faces.
3092
ff2bc410
SM
30932011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3094
3095 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3096
28177add
PE
30972011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3098
dd3482fe
PE
3099 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3100 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3101 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3102
393d71f3 3103 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3104 * fileio.c (Finsert_file_contents):
3105 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3106 Remove the old (too-loose) buffer overflow checks.
3107 They weren't needed, since make_gap checks for buffer overflow.
3108 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3109 The old code merely checked for Emacs fixnum overflow, and relied
3110 on undefined (wraparound) behavior. The new code avoids undefined
3111 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3112
2e6813b0 3113 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3114 Tune. Don't use wider integers than needed. Don't use alloca.
3115 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3116
599a9e4f
PE
3117 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3118
99561444
PE
3119 * insdel.c, lisp.h (buffer_overflow): New function.
3120 (insert_from_buffer_1, replace_range, replace_range_2):
3121 * insdel.c (make_gap_larger):
3122 * editfns.c (Finsert_char):
3123 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3124
28177add
PE
3125 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3126
e69dafad
PE
31272011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3128
a7af7fde 3129 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3130
b1c46f02
PE
3131 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3132 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3133
e69dafad
PE
3134 * fileio.c: Don't assume EMACS_INT fits in off_t.
3135 (emacs_lseek): New static function.
3136 (Finsert_file_contents, Fwrite_region): Use it.
3137 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3138
566684ea
PE
3139 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3140
e6966cd6
PE
3141 * fns.c: Don't overflow int when computing a list length.
3142 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3143 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3144 truncation on 64-bit hosts. Check for QUIT every
3145 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3146 faster and is responsive enough.
3147 (Flength): Report an error instead of overflowing an integer.
3148 (Fsafe_length): Return a float if the value is not representable
3149 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3150 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3151 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3152
dd0b0efb
PE
3153 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3154 (header_size, word_size): New constants.
3155 (allocate_vectorlike): Don't check size overflow here.
3156 (allocate_vector): Check it here instead, since this is the only
3157 caller of allocate_vectorlike that could cause overflow.
3158 Check that the new vector's length is representable as a fixnum.
3159
86fe5cfe
PE
3160 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3161 The previous code was bogus. For example, next_almost_prime (32)
3162 returned 39, which is undesirable as it is a multiple of 3; and
3163 next_almost_prime (24) returned 25, which is a multiple of 5 so
3164 why was the code bothering to check for multiples of 7?
3165
80e88859
PE
3166 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3167
4a2f0ad6
PE
3168 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3169
f66c7cf8
PE
3170 Variadic C functions now count arguments with ptrdiff_t.
3171 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3172 Back then I didn't know that the Emacs coding style prefers signed int.
3173 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3174 were being counted with int, which may truncate counts on 64-bit
3175 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3176 * lisp.h (struct Lisp_Subr.function.aMANY)
3177 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3178 Arg counts are now ptrdiff_t, not size_t.
3179 All variadic functions and their callers changed accordingly.
3180 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3181 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3182 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3183 * callint.c (Fcall_interactively): Check arg count for overflow,
3184 to avoid potential buffer overrun. Use signed char, not 'int',
3185 for 'varies' array, so that we needn't bother to check its size
3186 calculation for overflow.
3187 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3188 * eval.c (apply_lambda):
3189 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3190 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3191 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3192
a1759b76
PE
3193 * callint.c (Fcall_interactively): Don't use index var as event count.
3194
d96be9fc
PE
3195 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3196 * mem-limits.h (SIZE): Remove; no longer used.
3197
a690a978 3198 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3199
578c21e6
PE
3200 Remove unnecessary casts.
3201 * xterm.c (x_term_init):
3202 * xfns.c (x_set_border_pixel):
3203 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3204 These aren't needed now that we assume ANSI C.
3205
96f53c6c
PE
3206 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3207 It's more likely to cause problems (due to unsigned overflow)
3208 than to cure them.
3209
83c77d31
PE
3210 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3211
ee2079f1
PE
3212 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3213
6da65536
PE
3214 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3215
7147c4a4
PE
3216 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3217
193e32d9
PE
3218 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3219
e5533da6
PE
3220 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3221
9910e595
PE
3222 GLYPH_CODE_FACE returns EMACS_INT, not int.
3223 * dispextern.h (merge_faces):
3224 * xfaces.c (merge_faces):
01103c44
PE
3225 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3226 Don't assume EMACS_INT fits in int.
9910e595 3227
2638320e
PE
3228 * character.h (CHAR_VALID_P): Remove unused parameter.
3229 * fontset.c, lisp.h, xdisp.c: All uses changed.
3230
045eb8d9
PE
3231 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3232
c1f134b5
PE
3233 * fns.c (concat): Minor tuning based on overflow analysis.
3234 This doesn't fix any bugs. Use int to hold character, instead
3235 of constantly refetching from Emacs object. Use XFASTINT, not
3236 XINT, for value known to be a character. Don't bother comparing
3237 a single byte to 0400, as it's always less.
3238
395fcb93 3239 * floatfns.c (Fexpt):
327eeec8
PE
3240 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3241
abbd3d23
PE
3242 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3243 for characters.
3244
684a03ef
PE
3245 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3246
0fed43f3
PE
3247 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3248 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3249 incorrectly succeed when S was a string, because 4294967386 was
3250 truncated before it was used.
3251
8fd02eb7
PE
3252 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3253 Otherwise, an out-of-range integer could cause undefined behavior
3254 on a 64-bit host.
3255
f8c86b69
PE
3256 * composite.c: Use int, not EMACS_INT, for characters.
3257 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3258 EMACS_INT, for values that are known to be in character range.
3259 This doesn't fix any bugs but is the usual style inside Emacs and
3260 may generate better code on 32-bit machines.
3261
34206dd2
PE
3262 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3263 This is for reasons similar to the recent CHAR_STRING fix.
3264 * charset.c (Fencode_char): Check that character arg is actually
3265 a character. Pass an int to ENCODE_CHAR.
3266 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3267 wider than 'int', as a compile-time check to prevent future regressions
3268 in this area.
3269
c5958d4c 3270 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3271
3272 Make sure a 64-bit char is never passed to CHAR_STRING.
3273 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3274 by silently ignoring the top 32 bits, allowing some values
3275 that were far too large to be valid characters.
3276 * character.h: Include <verify.h>.
3277 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3278 arguments are no wider than unsigned, as a compile-time check
3279 to prevent future regressions in this area.
3280 * data.c (Faset):
01103c44 3281 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3282 (Fsubst_char_in_region):
3283 * fns.c (concat):
3284 * xdisp.c (decode_mode_spec_coding):
3285 Adjust to CHAR_STRING's new requirement.
3286 * editfns.c (Finsert_char, Fsubst_char_in_region):
3287 * fns.c (concat): Check that character args are actually
3288 characters. Without this test, these functions did the wrong
3289 thing with wildly out-of-range values on 64-bit hosts.
3290
d37ca623
PE
3291 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3292 These casts should not be needed on 32-bit hosts, either.
3293 * keyboard.c (read_char):
3294 * lread.c (Fload): Remove casts to unsigned.
3295
ea204efb
PE
3296 * lisp.h (UNSIGNED_CMP): New macro.
3297 This fixes comparison bugs on 64-bit hosts.
3298 (ASCII_CHAR_P): Use it.
3299 * casefiddle.c (casify_object):
01103c44 3300 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3301 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3302 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3303 * dispextern.h (FACE_FROM_ID):
3304 * keyboard.c (read_char): Use UNSIGNED_CMP.
3305
41cb286c
PE
3306 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3307 not to EMACS_INT, to avoid GCC warning.
3308
4a1b9832
PE
3309 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3310
55daad71
PE
3311 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3312 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3313 isn't needed on 32-bit machines.
8f95c75c 3314
01103c44
PE
3315 * buffer.c (Fgenerate_new_buffer_name):
3316 Use EMACS_INT for count, not int.
0ceccced 3317 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3318
3319 * data.c (Qcompiled_function): Now static.
3320
c6f072e7
PE
3321 * window.c (window_body_lines): Now static.
3322
20ce5912
PE
3323 * image.c (gif_load): Rename local to avoid shadowing.
3324
9c4c5f81
PE
3325 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3326 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3327 * alloc.c (make_save_value): Integer argument is now of type
3328 ptrdiff_t, not int.
3329 (mark_object): Use ptrdiff_t, not int.
3330 * lisp.h (pD): New macro.
3331 * print.c (print_object): Use it.
3332
c0c5c8ae
PE
3333 * alloc.c: Use EMACS_INT, not int, to count objects.
3334 (total_conses, total_markers, total_symbols, total_vector_size)
3335 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3336 (total_free_floats, total_floats, total_free_intervals)
3337 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3338 Now EMACS_INT, not int. All uses changed.
3339 (Fgarbage_collect): Compute overall total using a double, so that
3340 integer overflow is less likely to be a problem. Check for overflow
3341 when converting back to an integer.
5a25e253
PE
3342 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3343 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3344 These were 'int' variables that could overflow on 64-bit hosts;
3345 they were never used, so remove them instead of repairing them.
211a0b2a 3346 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3347 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3348 Previously, this ceilinged at INT_MAX, but that doesn't work on
3349 64-bit machines.
e46bb31a 3350 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3351
c78baabf 3352 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3353 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3354 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3355 when a (possibly-narrower) signed value would do just as well.
3356 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3357
c9d624c6
PE
3358 * alloc.c: Catch some string size overflows that we were missing.
3359 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3360 for convenience in STRING_BYTES_MAX.
3361 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3362 The definition here is exact; the one in lisp.h was approximate.
3363 (allocate_string_data): Check for string overflow. This catches
3364 some instances we weren't catching before. Also, it catches
3365 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3366 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3367 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3368
c9d624c6
PE
3369 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3370 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3371 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3372
353032ce
PE
3373 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3374
2bccce07
PE
3375 * alloc.c (Fmake_string): Check for out-of-range init.
3376
0ac30604
SM
33772011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3378
3379 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3380
c195f2de
JD
33812011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3382
3383 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3384 xg_get_default_scrollbar_width.
3385
3386 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3387 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3388 (style_changed_cb): Call update_theme_scrollbar_width and call
3389 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3390 all frames (Bug#8505).
3391 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3392 Call gtk_window_set_resizable if HAVE_GTK3.
3393 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3394 and height if HAVE_GTK3 (Bug#8505).
3395 (scroll_bar_width_for_theme): New variable.
3396 (update_theme_scrollbar_width): New function.
3397 (xg_get_default_scrollbar_width): Move code to
3398 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3399 (xg_initialize): Call update_theme_scrollbar_width.
3400
3401 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3402
3403 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3404
e10ac9f1
MR
34052011-06-12 Martin Rudalics <rudalics@gmx.at>
3406
3407 * frame.c (make_frame): Call other_buffer_safely instead of
3408 other_buffer.
3409
3410 * window.c (temp_output_buffer_show): Call display_buffer with
3411 second argument Vtemp_buffer_show_specifiers and reset latter
3412 immediately after the call.
3413 (Vtemp_buffer_show_specifiers): New variable.
3414 (auto_window_vscroll_p, next_screen_context_lines)
3415 (Vscroll_preserve_screen_position): Remove leading asterisks from
3416 doc-strings.
3417
2d3c217e 34182011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3419
7b7f97e8 3420 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3421 * buffer.c (Qclone_number): Remove for now, as it's unused.
3422 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3423 (record_buffer): Remove unused local.
3424 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3425 (set_frame_buffer_list): Remove; unused.
3426 * frame.h (other_visible_frames): Remove decl.
3427 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3428 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3429 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3430 if HAVE_GPM.
3431 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3432 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3433 Define only if HAVE_GPM.
3434 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3435 (update_hints_inhibit): Remove; never set. All uses removed.
3436 * widgetprv.h (emacsFrameClassRec): Remove decl.
3437 * window.c (delete_deletable_window): Now returns void, since it
3438 wasn't returning anything.
3439 (compare_window_configurations): Remove unused locals.
3440 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3441 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3442 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3443 the same widths as pointers. This follows up on the 2011-05-06 patch.
3444 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3445 * xterm.h: Likewise.
3446 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3447
1384b89e
JB
34482011-06-12 Juanma Barranquero <lekktu@gmail.com>
3449
3450 * makefile.w32-in: Update dependencies.
3451 (LISP_H): Add lib/intprops.h.
3452
1100a63c
CY
34532011-06-11 Chong Yidong <cyd@stupidchicken.com>
3454
3455 * image.c (gif_load): Add animation frame delay to the metadata.
3456 (syms_of_image): Use DEFSYM. New symbol `delay'.
3457
6198ccd0
MR
34582011-06-11 Martin Rudalics <rudalics@gmx.at>
3459
3460 * window.c (delete_deletable_window): Re-add.
3461 (Fset_window_configuration): Rewrite to handle dead buffers and
3462 consequently deletable windows.
3463 (window_tree, Fwindow_tree): Remove. Supply functionality in
3464 window.el.
3465 (compare_window_configurations): Simplify code.
3466
b6e3633c
AS
34672011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3468
1ab0dee5
AS
3469 * image.c (imagemagick_load_image): Fix type mismatch.
3470 (Fimagemagick_types): Likewise.
3471
b6e3633c
AS
3472 * window.h (replace_buffer_in_windows): Declare.
3473
9397e56f
MR
34742011-06-11 Martin Rudalics <rudalics@gmx.at>
3475
3476 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3477 Qclone_number. Remove external declaration of Qdelete_window.
3478 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3479 code.
640c8776
SM
3480 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3481 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3482 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3483 buffer list implementation.
3484 (other_buffer_safely): New function.
3485 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3486 calls to replace_buffer_in_windows and
3487 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3488 if allowed.
3489 (record_buffer): Inhibit quitting and rewrite using quittable
3490 functions. Run Qbuffer_list_update_hook if allowed.
3491 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3492 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3493 Move switch-to-buffer to window.el.
9397e56f
MR
3494 (bury-buffer): Move to window.el.
3495 (Vbuffer_list_update_hook): New variable.
3496
3497 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3498 section.
3499
3500 * window.h (resize_frame_windows): Move up in code.
3501 (Fwindow_frame): Remove EXFUN.
3502 (replace_buffer_in_all_windows): Remove prototype.
3503 (replace_buffer_in_windows_safely): Add prototype.
3504
3505 * window.c: Declare Qdelete_window static again. Move down
3506 declaration of select_count.
3507 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3508 (Fother_window): Move to window.el.
3509 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3510 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3511 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3512 window.el.
3513 (replace_buffer_in_windows): Implement by calling
3514 Qreplace_buffer_in_windows.
3515 (replace_buffer_in_all_windows): Remove with some functionality
3516 moved into replace_buffer_in_windows_safely.
3517 (replace_buffer_in_windows_safely): New function.
3518 (select_window_norecord, select_frame_norecord): Move in front
3519 of run_window_configuration_change_hook. Remove now obsolete
3520 declarations.
640c8776
SM
3521 (Fset_window_buffer): Rewrite doc-string.
3522 Call Qrecord_window_buffer.
9397e56f
MR
3523 (keys_of_window): Move binding for other-window to window.el.
3524
b50691aa
CY
35252011-06-11 Chong Yidong <cyd@stupidchicken.com>
3526
3527 * dispextern.h (struct image): Replace data member, whose int_val
3528 and ptr_val fields were not used by anything, with a single
3529 lisp_val object.
3530
3531 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3532 (gif_clear_image, gif_load, imagemagick_load_image)
3533 (gs_clear_image, gs_load): Callers changed.
3534
3f754b86
PE
35352011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3536
cca69397
PE
3537 * buffer.h: Include <time.h>, for time_t.
3538 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3539
109e28d0
PE
3540 Fix minor problems found by static checking.
3541
60737f02
PE
3542 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3543
4b66faf3
PE
3544 Make identifiers static if they are not used in other modules.
3545 * data.c (Qcompiled_function, Qframe, Qvector):
3546 * image.c (QimageMagick, Qsvg):
3547 * minibuf.c (Qmetadata):
3548 * window.c (resize_window_check, resize_root_window): Now static.
3549 * window.h (resize_window_check, resize_root_window): Remove decls.
3550
109e28d0
PE
3551 * window.c (window_deletion_count, delete_deletable_window):
3552 Remove; unused.
46a4ce9e
PE
3553 (window_body_lines): Now static.
3554 (Fdelete_other_windows_internal): Mark vars as initialized.
3555 Make sure 'resize_failed' is initialized.
3556 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3557 (resize_window_apply): Remove unused local.
3558 * window.h (delete_deletable_window): Remove decl.
3559
109e28d0 3560 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3561 (imagemagick_load_image): Fix pointer signedness problem by changing
3562 last arg from unsigned char * to char *. All uses changed.
3563 Also, fix a local for similar reasons.
3564 Remove unused locals. Remove locals to avoid shadowing.
3565 (fn_rsvg_handle_free): Remove; unused.
3566 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3567 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3568
3f754b86
PE
3569 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3570
2547adb1
CY
35712011-06-10 Chong Yidong <cyd@stupidchicken.com>
3572
3573 * image.c (gif_load): Fix omitted cast error introduced by
3574 2011-06-06 change.
3575
2c8e37d4
MR
35762011-06-10 Martin Rudalics <rudalics@gmx.at>
3577
3578 * window.h (resize_proportionally, orig_total_lines)
3579 (orig_top_line): Remove from window structure.
3580 (set_window_height, set_window_width, change_window_heights)
3581 (Fdelete_window): Remove prototypes.
3582 (resize_frame_windows): Remove duplicate declaration.
3583
440a42e3
EZ
35842011-06-10 Eli Zaretskii <eliz@gnu.org>
3585
3586 * window.h (resize_frame_windows, resize_window_check)
3587 (delete_deletable_window, resize_root_window)
3588 (resize_frame_windows): Declare prototypes.
3589
3590 * window.c (resize_window_apply): Make definition be "static" to
3591 match the prototype.
3592
562dd5e9
MR
35932011-06-10 Martin Rudalics <rudalics@gmx.at>
3594
3595 * window.c: Remove declarations of Qwindow_size_fixed,
3596 window_min_size_1, window_min_size_2, window_min_size,
3597 size_window, window_fixed_size_p, enlarge_window, delete_window.
3598 Remove static from declaration of Qdelete_window, it's
3599 temporarily needed by Fbury_buffer.
3600 (replace_window): Don't assign orig_top_line and
3601 orig_total_lines.
3602 (Fdelete_window, delete_window): Remove. Window deletion is
3603 handled by window.el.
640c8776
SM
3604 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3605 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3606 (Fdelete_other_windows): Remove. Deleting other windows is
3607 handled by window.el.
3608 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3609 handled in window.el.
3610 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3611 Window minimum sizes are handled in window.el.
3612 (shrink_windows, size_window, set_window_height)
3613 (set_window_width, change_window_heights, window_height)
3614 (window_width, CURBEG, CURSIZE, enlarge_window)
3615 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3616 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3617 handled in window.el.
3618 (make_dummy_parent): Rename to make_parent_window and give it a
3619 second argument horflag.
3620 (make_window): Don't set resize_proportionally any more.
3621 (Fsplit_window): Remove. Windows are split in window.el.
3622 (save_restore_action, save_restore_orig_size)
3623 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3624 Resize mini windows in window.el.
3625 (grow_mini_window, shrink_mini_window): Implement by calling
3626 Qresize_root_window_vertically, resize_window_check and
3627 resize_window_apply.
640c8776
SM
3628 (saved_window, Fset_window_configuration, save_window_save):
3629 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3630 resize_proportionally.
3631 (window_min_height, window_min_width): Move to window.el.
3632 (keys_of_window): Move bindings for delete-other-windows,
3633 split-window, delete-window and enlarge-window to window.el.
3634
3635 * buffer.c: Temporarily extern Qdelete_window.
3636 (Fbury_buffer): Temporarily call Qdelete_window instead of
3637 Fdelete_window (Fbury_buffer will move to window.el soon).
3638
3639 * frame.c (set_menu_bar_lines_1): Remove code handling
3640 orig_top_line and orig_total_lines.
3641
3642 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3643 set_window_height but set heights directly.
3644 (change_frame_size_1): Use resize_frame_windows.
3645
3646 * xdisp.c (init_xdisp): Don't use set_window_height but set
3647 heights directly.
3648
640c8776
SM
3649 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3650 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3651 run_window_configuration_change_hook.
3652
3653 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3654 instead of change_window_heights and run
3655 run_window_configuration_change_hook.
3656
1a13852e
MR
36572011-06-09 Martin Rudalics <rudalics@gmx.at>
3658
3659 * window.c (replace_window): Rename second argument REPLACEMENT to
3660 NEW. New third argument SETFLAG. Rewrite.
3661 (delete_window, make_dummy_parent): Call replace_window with
3662 third argument 1.
3663 (window_list_1): Move down in code.
3664 (run_window_configuration_change_hook): Move set_buffer part
3665 before select_frame_norecord part in order to unwind correctly.
3666 Rename count1 to count.
3667 (recombine_windows, delete_deletable_window, resize_root_window)
3668 (Fdelete_other_windows_internal)
3669 (Frun_window_configuration_change_hook, make_parent_window)
3670 (resize_window_check, resize_window_apply, Fresize_window_apply)
3671 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3672 (Fdelete_window_internal, Fresize_mini_window_internal):
3673 New functions.
1a13852e
MR
3674 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3675
f3d1777e
MR
36762011-06-08 Martin Rudalics <rudalics@gmx.at>
3677
496e208e
MR
3678 * window.h (window): Add some new members to window structure -
3679 normal_lines, normal_cols, new_total, new_normal, clone_number,
3680 splits, nest, prev_buffers, next_buffers.
3681 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3682 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3683
f3d1777e
MR
3684 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3685 Remove.
496e208e
MR
3686 (make_dummy_parent): Set new members of windows structure.
3687 (make_window): Move down in code. Handle new members of window
3688 structure.
3689 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3690 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3691 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3692 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3693 (Fset_window_next_buffers, Fset_window_clone_number):
3694 New functions.
496e208e
MR
3695 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3696 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3697 Doc-string fixes.
3698 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3699 Argument WINDOW can be now internal window too.
3700 (Fwindow_use_time): Move up in code.
3701 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3702 Rewrite doc-string.
3703 (Fset_window_configuration, saved_window)
3704 (Fcurrent_window_configuration, save_window_save): Handle new
3705 members of window structure.
b9e809c2
MR
3706 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3707 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3708 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3709 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3710 Qget_mru_window, Qresize_root_window,
3711 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3712 Qauto_buffer_name; staticpro them.
f3d1777e 3713
abde8f8c
MR
37142011-06-07 Martin Rudalics <rudalics@gmx.at>
3715
3716 * window.c (Fwindow_total_size, Fwindow_left_column)
3717 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3718 (Fwindow_list_1): New functions.
3719 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3720 (Fwindow_width, Fscroll_left, Fscroll_right):
3721 Use window_body_cols instead of window_box_text_cols.
3722 (delete_window, Fset_window_configuration):
3723 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3724 (delete_all_subwindows): Take a window as argument and not a
3725 structure. Rewrite.
190b47e6
MR
3726 (window_loop): Remove handling of GET_LRU_WINDOW and
3727 GET_LARGEST_WINDOW.
3728 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3729
3730 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3731 window_box_text_cols. delete_all_subwindows now takes a
3732 Lisp_Object as argument.
abde8f8c 3733
640c8776
SM
3734 * indent.c (compute_motion, Fcompute_motion):
3735 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3736
fa8a67e6
MR
3737 * frame.c (delete_frame): Call delete_all_subwindows with root
3738 window as argument.
3739
a54e3482
DC
37402011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3741
3742 * fns.c (Fputhash): Document return value.
3743
60002bf5
CY
37442011-06-06 Chong Yidong <cyd@stupidchicken.com>
3745
3746 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3747
0c671da6 37482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3749
b862a52a 3750 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3751
be44ca6c
PE
3752 Check for overflow when converting integer to cons and back.
3753 * charset.c (Fdefine_charset_internal, Fdecode_char):
3754 Use cons_to_unsigned to catch overflow.
3755 (Fencode_char): Use INTEGER_TO_CONS.
3756 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3757 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3758 * data.c (long_to_cons, cons_to_long): Remove.
3759 (cons_to_unsigned, cons_to_signed): New functions.
3760 These signal an error for invalid or out-of-range values.
3761 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3762 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3763 * font.c (Ffont_variation_glyphs):
3764 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3765 * lisp.h: Include <intprops.h>.
3766 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3767 (cons_to_signed, cons_to_unsigned): New decls.
3768 (long_to_cons, cons_to_long): Remove decls.
3769 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3770 (Fprimitive_undo): Use CONS_TO_INTEGER.
3771 * xfns.c (Fx_window_property): Likewise.
3772 * xselect.c: Include <limits.h>.
3773 (x_own_selection, selection_data_to_lisp_data):
3774 Use INTEGER_TO_CONS.
3775 (x_handle_selection_request, x_handle_selection_clear)
3776 (x_get_foreign_selection, Fx_disown_selection_internal)
3777 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3778 (lisp_data_to_selection_data): Use cons_to_unsigned.
3779 (x_fill_property_data): Use cons_to_signed.
3780 Report values out of range.
3781
d1f3d2af
PE
3782 Check for buffer and string overflow more precisely.
3783 * buffer.h (BUF_BYTES_MAX): New macro.
3784 * lisp.h (STRING_BYTES_MAX): New macro.
3785 * alloc.c (Fmake_string):
3786 * character.c (string_escape_byte8):
3787 * coding.c (coding_alloc_by_realloc):
3788 * doprnt.c (doprnt):
3789 * editfns.c (Fformat):
3790 * eval.c (verror):
3791 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3792 since they may not be the same number.
3793 * editfns.c (Finsert_char):
3794 * fileio.c (Finsert_file_contents):
3795 Likewise for BUF_BYTES_MAX.
3796
dd52fcea
PE
3797 * image.c: Use ptrdiff_t, not int, for sizes.
3798 (slurp_file): Switch from int to ptrdiff_t.
3799 All uses changed.
3800 (slurp_file): Check that file size fits in both size_t (for
3801 malloc) and ptrdiff_t (for sanity and safety).
3802
7f9bbdbb
PE
3803 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3804 if b->modtime has its maximal value.
3805
dfe18f82
PE
3806 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3807
84acfcf0
PE
3808 Don't assume time_t can fit into int.
3809 * buffer.h (struct buffer.modtime): Now time_t, not int.
3810 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3811 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3812
ccd9a01a
PE
3813 Minor fixes for signed vs unsigned integers.
3814 * character.h (MAYBE_UNIFY_CHAR):
3815 * charset.c (maybe_unify_char):
3816 * keyboard.c (read_char, reorder_modifiers):
3817 XINT -> XFASTINT, since the integer must be nonnegative.
3818 * ftfont.c (ftfont_spec_pattern):
3819 * keymap.c (access_keymap, silly_event_symbol_error):
3820 XUINT -> XFASTINT, since the integer must be nonnegative.
3821 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3822 since it makes no difference and we prefer signed.
3823 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3824 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3825 nonnegative.
3826
d6d100dd
SM
38272011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3828
3829 * window.h (Fwindow_frame): Declare.
3830
2b6148e4
PE
38312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3832
3833 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3834 (SPARE_MEMORY): Always define.
3835 (LARGE_REQUEST): Remove.
3836 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3837
f230ecc9
MR
38382011-06-06 Martin Rudalics <rudalics@gmx.at>
3839
727e958e
MR
3840 * lisp.h: Move EXFUNS for Fframe_root_window,
3841 Fframe_first_window and Fset_frame_selected_window to window.h.
3842
3843 * window.h: Move EXFUNS for Fframe_root_window,
3844 Fframe_first_window and Fset_frame_selected_window here from
3845 lisp.h.
3846
3847 * frame.c (Fwindow_frame, Fframe_first_window)
3848 (Fframe_root_window, Fframe_selected_window)
3849 (Fset_frame_selected_window): Move to window.c.
3850 (Factive_minibuffer_window): Move to minibuf.c.
3851 (Fother_visible_frames_p): New function.
3852
3853 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3854
f230ecc9
MR
3855 * window.c (decode_window, decode_any_window): Move up in code.
3856 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3857 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3858 (Fwindow_buffer): Move up and rewrite doc-string.
3859 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3860 (Fwindow_prev): New functions.
727e958e
MR
3861 (Fwindow_frame): Move here from frame.c. Accept any window as
3862 argument.
3863 (Fframe_root_window, Fframe_first_window)
3864 (Fframe_selected_window): Move here from frame.c. Accept frame
3865 or arbitrary window as argument. Update doc-strings.
3866 (Fminibuffer_window): Move up in code.
3867 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3868 (Fset_frame_selected_window): Move here from frame.c.
3869 Marginal rewrite.
727e958e
MR
3870 (Fselected_window, select_window, Fselect_window): Move up in
3871 code. Minor doc-string fixes.
f230ecc9 3872
4d09bcf6
PE
38732011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3874
3875 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3876 Do not assume that spare memory exists; that assumption is valid
3877 only if SYSTEM_MALLOC.
3878 (LARGE_REQUEST): New macro, so that the issue of large requests
3879 is separated from the issue of spare memory.
3880
810928a2
AS
38812011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3882
172418ad
AS
3883 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3884 format. (Bug#8806)
3885
43f862f7
AS
3886 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3887
810928a2
AS
3888 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3889 before statements.
3890
a059fe24
JD
38912011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3892
3893 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3894
3895 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3896
3897 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3898 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3899
989bf368
JB
39002011-06-05 Juanma Barranquero <lekktu@gmail.com>
3901
3902 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3903
4b80f674
CY
39042011-06-04 Chong Yidong <cyd@stupidchicken.com>
3905
3906 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3907 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3908 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3909 New error handlers.
4b80f674
CY
3910 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3911 Obey Vx_select_enable_clipboard_manager. Catch errors in
3912 x_clipboard_manager_save (Bug#8779).
3913 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3914 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3915
99a33b77 39162011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3917
3918 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3919
99a33b77 39202011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3921
3922 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3923 in the current matrix if keep_current_p is non-zero.
3924
8264569d
EZ
39252011-06-04 Eli Zaretskii <eliz@gnu.org>
3926
3927 * bidi.c (bidi_level_of_next_char): Fix last change.
3928
57f97249
EZ
39292011-06-03 Eli Zaretskii <eliz@gnu.org>
3930
fec2107c 3931 Support bidi reordering of text covered by display properties.
57f97249 3932
fec2107c
EZ
3933 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3934 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3935 (bidi_cache_search, bidi_cache_iterator_state)
3936 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3937 (bidi_level_of_next_char, bidi_move_to_visually_next):
3938 Support character positions inside a run of characters covered by a
fec2107c
EZ
3939 display string.
3940 (bidi_paragraph_init, bidi_resolve_explicit_1)
3941 (bidi_level_of_next_char): Call bidi_fetch_char and
3942 bidi_fetch_char_advance instead of FETCH_CHAR and
3943 FETCH_CHAR_ADVANCE.
3944 (bidi_init_it): Initialize new members.
3945 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3946 definitions.
3947 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3948 instead of using explicit *_CHAR codes.
d6d100dd
SM
3949 (bidi_resolve_explicit, bidi_resolve_weak):
3950 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3951 bidirectional text is supported only in multibyte buffers.
3952 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3953 it to initialize the frame_window_p member of struct bidi_it.
3954 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3955 (bidi_resolve_explicit, bidi_resolve_weak)
3956 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3957 bidi_it->nchars is non-positive.
3958 (bidi_level_of_next_char): Don't try to lookup the cache for the
3959 next/previous character if nothing is cached there yet, or if we
3960 were just reseat()'ed to a new position.
c40e2fb2 3961
0e14fe90
EZ
3962 * xdisp.c (set_cursor_from_row): Set start and stop points
3963 according to the row's direction when priming the loop that looks
3964 for the glyph on which to display cursor.
3965 (single_display_spec_intangible_p): Function deleted.
3966 (display_prop_intangible_p): Reimplement to call
3967 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3968 Accept 3 additional arguments needed by handle_display_spec.
3969 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3970 values: lists, `(when COND...)' forms, etc.
3971 (single_display_spec_string_p): Support property values that are
3972 lists with the argument STRING its top-level element.
3973 (display_prop_string_p): Fix the condition for processing a
3974 property that is a list to be consistent with handle_display_spec.
fec2107c 3975 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3976 last portion of handle_display_prop.
3977 (compute_display_string_pos): Accept additional argument
3978 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3979 value of a `display' property is a "replacing spec".
3980 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3981 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3982 the display property, but just return a value indicating whether
3983 the display property will replace the characters it covers.
3984 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3985 frame_window_p members of struct bidi_it.
d6d100dd
SM
3986 (compute_display_string_pos, compute_display_string_end):
3987 New functions.
fec2107c
EZ
3988 (push_it): Accept second argument POSITION, where pop_it should
3989 jump to continue iteration.
3990 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3991
fec2107c
EZ
3992 * keyboard.c (adjust_point_for_property): Adjust the call to
3993 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3994
3995 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3996 (bidi_init_it): Update prototypes.
3997 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3998 (compute_display_string_pos, compute_display_string_end):
3999 Declare prototypes.
fec2107c
EZ
4000 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4001 EMACS_INT.
fc6f18ce 4002
40087514 40032011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4004
57f53182
PE
4005 Malloc failure behavior now depends on size of allocation.
4006 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4007 * lisp.h: Change signatures accordingly.
4008 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4009 All callers changed. (Bug#8762)
4010
4011 * gnutls.c: Use Emacs's memory allocators.
4012 Without this change, the gnutls library would invoke malloc etc.
4013 directly, which causes problems on non-SYNC_INPUT hosts, and which
4014 runs afoul of improving memory_full behavior. (Bug#8761)
4015 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4016 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4017 xfree instead of the default malloc, realloc, free.
4018 (Fgnutls_boot): No need to check for memory allocation failure,
4019 since xmalloc does that for us.
4020
ac32cd99 4021 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4022 * category.c (hash_get_category_set):
4023 * ccl.c (ccl_driver):
4024 * charset.c (Fdefine_charset_internal):
4025 * charset.h (struct charset.hash_index):
4026 * composite.c (get_composition_id, gstring_lookup_cache)
4027 (composition_gstring_put_cache):
4028 * composite.h (struct composition.hash_index):
4029 * dispextern.h (struct image.hash):
4030 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4031 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4032 (hashfn_equal, hashfn_user_defined, make_hash_table)
4033 (maybe_resize_hash_table, hash_lookup, hash_put)
4034 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4035 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4036 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4037 * image.c (make_image, search_image_cache, lookup_image)
4038 (xpm_put_color_table_h):
4039 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4040 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4041 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4042 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4043 * alloc.c (allocate_vectorlike):
4044 Check for overflow in vector size calculations.
4045 * ccl.c (ccl_driver):
4046 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4047 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4048 need to be updated by these changes.
40087514
PE
4049 * fns.c (make_hash_table, maybe_resize_hash_table):
4050 Check for integer overflow with large hash tables.
0de4bb68
PE
4051 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4052 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4053 (SXHASH_REDUCE): New macro.
4054 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4055 Use it instead of discarding useful hash info with large hash values.
4056 (sxhash_float): New function.
4057 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4058 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4059 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4060 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4061 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4062 Adjust signatures to match updated version of code.
4063 (consing_since_gc): Now EMACS_INT, since a single hash table can
4064 use more than INT_MAX bytes.
4065
698d32e2
DN
40662011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4067
4068 Make it possible to build with GCC-4.6+ -O2 -flto.
4069
4070 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4071
fd6fa53f
SM
40722011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4073
4074 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4075 Call minibuffer-inactive-mode.
4076
864db017
JB
40772011-05-31 Juanma Barranquero <lekktu@gmail.com>
4078
4079 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4080 Update dependencies.
4081
2ad0baf4
DN
40822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4083
4084 * data.c (init_data): Remove code for UTS, this system is not
4085 supported anymore.
4086
4fcc2638
DN
40872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4088
4089 Don't force ./temacs to start in terminal mode.
4090
4091 * frame.c (make_initial_frame): Initialize faces in all cases, not
4092 only when CANNOT_DUMP is defined.
4093 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4094
c56e0fd5
DN
40952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4096
4097 * dispnew.c (add_window_display_history): Use const for the string
4098 pointer. Remove declaration, not needed.
4099
333d54da 41002011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4101
55d4c1b2 4102 Use 'inline', not 'INLINE'.
333d54da 4103 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4104 * alloc.c, fontset.c (INLINE): Remove.
4105 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4106 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4107 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4108 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4109 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4110
738db178
DN
41112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4112
4113 Make it possible to run ./temacs.
4114
4115 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4116 syms_of_callproc does the same thing. Remove test for
4117 "initialized", do it in the caller.
4118 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4119
620c53a6
SM
41202011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4121
4122 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4123 (read_minibuf): Use get_minibuffer.
4124 (syms_of_minibuf): Use DEFSYM.
4125 (Qmetadata): New var.
4126 * data.c (Qbuffer): Don't make it static.
4127 (syms_of_data): Use DEFSYM.
4128
e003a292
PE
41292011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4130
4131 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4132 (CCL_CODE_MIN): New macro.
4133
ed008a6d
PE
41342011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4135
3687c2ef
PE
4136 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4137
ed008a6d
PE
4138 * eval.c (Qdebug): Now static.
4139 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4140 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4141 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4142
d66c4c7c
CY
41432011-05-29 Chong Yidong <cyd@stupidchicken.com>
4144
4145 * image.c: Various fixes to ImageMagick code comments.
4146 (Fimagemagick_types): Doc fix.
4147
5fbc2025
PE
41482011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4149
0196f88a
PE
4150 Minor fixes prompted by GCC 4.6.0 warnings.
4151
4152 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4153
5fbc2025
PE
4154 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4155 (x_clipboard_manager_save_all): Move extern decl to ...
4156 * xterm.h: ... here, so that it can be checked for consistency.
4157
1dd3c2d9
CY
41582011-05-29 Chong Yidong <cyd@stupidchicken.com>
4159
4160 * xselect.c (x_clipboard_manager_save_frame)
4161 (x_clipboard_manager_save_all): New functions.
4162 (Fx_clipboard_manager_save): Lisp function deleted.
4163
4164 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4165 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4166
4167 * xterm.h: Update prototype.
4168
5ba6571d
WX
41692011-05-28 William Xu <william.xwl@gmail.com>
4170
4171 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4172 exiting (Bug#8239).
4173
3eaff834
JM
41742011-05-28 Jim Meyering <meyering@redhat.com>
4175
e1900994 4176 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4177 * fns.c (to_uchar): Define.
4178 (crypto_hash_function): Use it to convert some newly-signed
4179 variables to unsigned, to avoid sign-extension bugs. For example,
4180 without this change, (md5 "truc") would evaluate to
4181 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4182 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4183 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4184
0f6990a7
PE
41852011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4186
4187 Integer overflow fixes.
c8a9ca5a 4188
08686060
PE
4189 * dbusbind.c: Serial number integer overflow fixes.
4190 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4191 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4192 to hold a serial number that is too large for a fixnum.
4193 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4194 Check for serial numbers out of range. Decode any serial number
59568bf0 4195 that was so large that it became a float. (Bug#8722)
08686060 4196
2d1fc3c7
PE
4197 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4198 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4199 Use XFASTINT rather than XUINT when numbers are nonnegative.
4200 (xd_append_arg, Fdbus_method_return_internal):
4201 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4202 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4203 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4204 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4205 (Bug#8722)
2d1fc3c7 4206
c8a9ca5a
PE
4207 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4208
519e1d69
PE
4209 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4210
30569699
PE
4211 ccl: add integer overflow checks
4212 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4213 (IN_INT_RANGE): New macros.
4214 (ccl_driver): Use them to check for integer overflow when
4215 decoding a CCL program. Many of the new checks are whether XINT (x)
4216 fits in int; it doesn't always, on 64-bit hosts. The new version
4217 doesn't catch all possible integer overflows, but it's an
847044ea 4218 improvement. (Bug#8719)
30569699 4219
c11285dc
PE
4220 * alloc.c (make_event_array): Use XINT, not XUINT.
4221 There's no need for unsigned here.
4222
fdccd48e
PE
4223 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4224 This follows up to the 2011-05-06 change that substituted uintptr_t
4225 for EMACS_INT. This case wasn't caught back then.
4226
37910ab2
PE
4227 Rework Fformat to avoid integer overflow issues.
4228 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4229 now (part of C89). Include <verify.h>.
4230 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4231 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4232 (Fformat): Avoid the prepass trying to compute sizes; it was only
4233 approximate and thus did not catch overflow reliably. Instead, walk
4234 through the format just once, formatting and computing sizes as we go,
4235 checking for integer overflow at every step, and allocating a larger
4236 buffer as needed. Keep track separately whether the format is
4237 multibyte. Keep only the most-recently calculated precision, rather
4238 than them all. Record whether each argument has been converted to
4239 string. Use EMACS_INT, not int, for byte and char and arg counts.
4240 Support field widths and precisions larger than INT_MAX. Avoid
4241 sprintf's undefined behavior with conversion specifications such as %#d
4242 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4243 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4244 formatting out-of-range floating point numbers with int
9173deec 4245 formats. (Bug#8668)
37910ab2 4246
2e6578fb
PE
4247 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4248
0ae6bdee
PE
4249 * data.c: Avoid integer truncation in expressions involving floats.
4250 * data.c: Include <intprops.h>.
4251 (arith_driver): When there's an integer overflow in an expression
4252 involving floating point, convert the integers to floating point
4253 so that the resulting value does not suffer from catastrophic
4254 integer truncation. For example, on a 64-bit host (* 4
4255 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4256 Do not rely on undefined behavior after integer overflow.
4257
de883a70
PE
4258 merge count_size_as_multibyte, parse_str_to_multibyte
4259 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4260 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4261 Check for integer overflow.
4262 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4263 since it's now a duplicate of the other. This is more of
4264 a character than a buffer op, so better that it's in character.c.
4265 * fns.c, print.c: Adjust to above changes.
4266
2ff916cb
PE
42672011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4268
4269 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4270
f1b54466
PE
42712011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4272
fb1ac845
PE
4273 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4274 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4275 (x_clipboard_manager_save): Now static.
4276 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4277
f1b54466
PE
4278 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4279 (crypto_hash_function): Now static.
4280 Fix pointer signedness problems. Avoid unnecessary initializations.
4281
a9f737ee
CY
42822011-05-27 Chong Yidong <cyd@stupidchicken.com>
4283
4284 * termhooks.h (Vselection_alist): Make it terminal-local.
4285
4286 * terminal.c (create_terminal): Initialize it.
4287
4288 * xselect.c: Support for clipboard managers.
4289 (Vselection_alist): Move to termhooks.h as terminal-local var.
4290 (LOCAL_SELECTION): New macro.
4291 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4292 (symbol_to_x_atom): Remove gratuitous arg.
4293 (x_handle_selection_request, lisp_data_to_selection_data)
4294 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4295 (x_own_selection, x_get_local_selection, x_convert_selection):
4296 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4297 (some_frame_on_display): Delete unused function.
4298 (Fx_own_selection_internal, Fx_get_selection_internal)
4299 (Fx_disown_selection_internal, Fx_selection_owner_p)
4300 (Fx_selection_exists_p): New optional frame arg.
4301 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4302 (x_handle_selection_clear): Don't treat other terminals with the
4303 same keyboard specially. Use the terminal-local Vselection_alist.
4304 (x_clear_frame_selections): Use Frun_hook_with_args.
4305
4306 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4307
4308 * xterm.h: Add support for those atoms.
4309
e067f0c1
CY
43102011-05-26 Chong Yidong <cyd@stupidchicken.com>
4311
4312 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4313 (converted_selections, conversion_fail_tag): New global variables.
4314 (x_selection_request_lisp_error): Free the above.
4315 (x_get_local_selection): Remove unnecessary code.
4316 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4317 of converted selections stored in converted_selections.
4318 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4319 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4320 (x_convert_selection): New function.
4321 (x_handle_selection_event): Simplify.
4322 (x_get_foreign_selection): Don't ignore incoming requests while
4323 waiting for an answer; this will fail when we implement
4324 SAVE_TARGETS, and seems unnecessary anyway.
4325 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4326 (Vx_sent_selection_functions): Doc fix.
4327
0f4aebc0
LL
43282011-05-26 Leo Liu <sdl.web@gmail.com>
4329
4330 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4331
e61124cd
YM
43322011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4333
4334 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4335
4336 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4337 for fringe update if it has periodic bitmap.
ac389d0c 4338 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4339 and fringe_bitmap_periodic_p.
4340
4341 * fringe.c (get_fringe_bitmap_data): New function.
4342 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4343 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4344 row. Mark glyph row for fringe update if periodicity changed.
4345
4346 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4347 for fringe update unless it has periodic bitmap.
4348
f16d9837
KH
43492011-05-25 Kenichi Handa <handa@m17n.org>
4350
4351 * xdisp.c (get_next_display_element): Set correct it->face_id for
4352 a static composition.
4353
e1b90ef6
LL
43542011-05-24 Leo Liu <sdl.web@gmail.com>
4355
4356 * deps.mk (fns.o):
4357 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4358
4359 * fns.c (crypto_hash_function, Fsha1): New function.
4360 (Fmd5): Use crypto_hash_function.
4361 (syms_of_fns): Add Ssha1.
4362
7400048f
PE
43632011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4364
4365 * gnutls.c: Remove unused macros.
4366 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4367 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4368 Remove macros that are defined and never used.
4369 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4370
abb71cf4
CY
43712011-05-22 Chong Yidong <cyd@stupidchicken.com>
4372
4373 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4374 (Fx_get_selection_internal): Minor cleanup.
4375 (Fx_own_selection_internal): Rename arguments for consistency with
4376 select.el.
4377
6307db39
PE
43782011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4379
4380 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4381
f3d4e0a4
CY
43822011-05-22 Chong Yidong <cyd@stupidchicken.com>
4383
4384 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4385
4d8ade89
YM
43862011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4387
4388 * dispnew.c (scrolling_window): Don't exclude the case that the
4389 last enabled row in the desired matrix touches the bottom boundary.
4390
32078c8d
GM
43912011-05-21 Glenn Morris <rgm@gnu.org>
4392
4393 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4394 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4395 and add some more files.
32078c8d 4396
7285dc67
EZ
43972011-05-20 Eli Zaretskii <eliz@gnu.org>
4398
4399 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4400 report_file_error introduced by the change from 2011-05-07.
4401
89d1bd22
PE
44022011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4403
4404 * systime.h (Time): Define only if emacs is defined.
4405 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4406 where the include path doesn't have X11/X.h by default. See
4407 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4408
e23640bb 44092011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4410
4411 * composite.c (find_automatic_composition): Fix previous change.
4412
b9704ad9
GM
44132011-05-20 Glenn Morris <rgm@gnu.org>
4414
4415 * lisp.mk: New file, split from Makefile.in.
4416 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4417 (shortlisp): Remove.
4418 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4419
4a720484
GM
44202011-05-19 Glenn Morris <rgm@gnu.org>
4421
4422 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4423 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4424 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4425 (lisp): Set the order to that of loadup.el.
4426 (shortlisp): Make it a copy of $lisp.
4427 (SOME_MACHINE_LISP): Remove.
4428 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4429 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4430
a28d4396
KH
44312011-05-18 Kenichi Handa <handa@m17n.org>
4432
4433 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4434 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4435 (find_automatic_composition): Mostly rewrite for efficiency.
4436
a2b1fa8e
JB
44372011-05-18 Juanma Barranquero <lekktu@gmail.com>
4438
4439 * makefile.w32-in: Update dependencies.
4440
8e1f5610
CS
44412011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4442
4443 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4444 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4445
7025ee00 44462011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4447
cdfa6eab
PE
4448 Fix some integer overflow issues, such as string length overflow.
4449
06d6db33
PE
4450 * insdel.c (count_size_as_multibyte): Check for string overflow.
4451
2b4560a8
PE
4452 * character.c (lisp_string_width): Check for string overflow.
4453 Use EMACS_INT, not int, for string indexes and lengths; in
4454 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4455 the resulting string length overflows an EMACS_INT; instead,
4456 report a string overflow if no precision given. When checking for
4457 precision exhaustion, use a check that cannot possibly have
4458 integer overflow. (Bug#8675)
4459 * character.h (lisp_string_width): Adjust to new signature.
4460
cb93f9be
PE
4461 * alloc.c (string_overflow): New function.
4462 (Fmake_string): Use it. This doesn't change behavior, but saves
4463 a few bytes and will simplify future changes.
4464 * character.c (string_escape_byte8): Likewise.
4465 * lisp.h (string_overflow): New decl.
4466
1a1f3366
PE
4467 Fixups, following up to the user-interface timestamp change.
4468 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4469 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4470 * msdos.c (mouse_get_pos): Likewise.
4471 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4472 * w32gui.h (Time): Define by including "systime.h" rather than by
4473 declaring it ourselves. (Bug#8664)
4474
d4e3e4d3
PE
4475 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4476 * image.c (clear_image_cache): Likewise.
4477
f6a24d19
PE
4478 * term.c (term_mouse_position): Don't assume time_t wraparound.
4479
08dc5ae6
PE
4480 Be more systematic about user-interface timestamps.
4481 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4482 and sometimes 'EMACS_UINT', to represent these timestamps.
4483 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4484 This makes the code easier to follow, and makes it easier to catch
4485 integer overflow bugs such as Bug#8664.
4486 * frame.c (Fmouse_position, Fmouse_pixel_position):
4487 Use Time, not unsigned long, for user-interface timestamps.
4488 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4489 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4490 * keyboard.h (last_event_timestamp): Likewise.
4491 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4492 * menu.h (xmenu_show): Likewise.
4493 * term.c (term_mouse_position): Likewise.
4494 * termhooks.h (struct input_event.timestamp): Likewise.
4495 (struct terminal.mouse_position_hook): Likewise.
4496 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4497 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4498 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4499 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4500 what it was before.
4501 * menu.h, termhooks.h: Include "systime.h", for Time.
4502
8e55734a
PE
4503 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4504 Don't assume that the difference between two unsigned long values
4505 can fit into an integer. At this point, we know button_down_time
4506 <= event->timestamp, so the difference must be nonnegative, so
4507 there's no need to cast the result if double-click-time is
4508 nonnegative, as it should be; check that it's nonnegative, just in
4509 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4510 apart (about 25 days). (Bug#8664)
8e55734a 4511
841f1b75 4512 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4513 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4514
3e26f69c
PE
4515 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4516 that always fit in int. Use a sentinel instead of a counter, to
4517 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4518 * frame.h (struct frame): Use int for menu_bar_items_used
4519 instead of EMACS_INT, since it always fits in int.
3e26f69c 4520
5cc152c0
PE
4521 * menu.c (grow_menu_items): Check for int overflow.
4522
d89eb65e
PE
4523 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4524
5235bd3e
PE
4525 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4526 Before, the code was not consistent. These values cannot exceed
4527 2**31 - 1 so there's no need to make them unsigned.
4528 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4529 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4530 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4531 as modifiers.
4532 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4533
bc827e23
PE
4534 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4535 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4536 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4537 presumably because the widths might not match.
4538
78eb494e
PE
4539 * window.c (size_window): Avoid needless test at loop start.
4540
04f2d78b
CB
45412011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4542
4543 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4544
d2fc7e3d 45452011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4546
4547 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4548
d2fc7e3d 45492011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4550
4551 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4552 `width' to `bar_area_x' and `bar_area_width', respectively.
4553 (x_scroll_run): Take account of fringe background extension.
4554
04f2d78b
CB
4555 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4556 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4557 `bar_area_width', respectively.
4558 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4559 background extension.
4560
79b70037
GM
45612011-05-10 Jim Meyering <meyering@redhat.com>
4562
4563 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4564
2f142cc5
JB
45652011-05-10 Juanma Barranquero <lekktu@gmail.com>
4566
4567 * image.c (Finit_image_library): Return t for built-in image types,
4568 like pbm and xbm. (Bug#8640)
4569
57679c86
AS
45702011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4571
4572 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4573
888c9e86
EZ
45742011-05-07 Eli Zaretskii <eliz@gnu.org>
4575
b0512a1d
EZ
4576 * w32console.c (Fset_screen_color): Doc fix.
4577 (Fget_screen_color): New function.
4578 (syms_of_ntterm): Defsubr it.
4579
7285dc67
EZ
4580 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4581 unlink the temporary file if Fcall_process didn't create it in the
4582 first place.
4583 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4584 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4585 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4586 cue to call_process_cleanup not to close that handle.
4587
4d3fcc8e
BK
45882011-05-07 Ben Key <bkey76@gmail.com>
4589
4590 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4591 one of two shell specific rules, either bootstrap-temacs-CMD or
4592 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4593 to the previous implementation of the bootstrap-temacs rule.
4594 The bootstrap-temacs-CMD rule is similar to the previous
4595 implementation of the bootstrap-temacs rule except that it
4596 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4597 variable.
4598
4599 These changes, along with some changes to nt/configure.bat,
4600 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4601 earlier fix to add support for --cflags and --ldflags options
4602 that include quotes so that it works whether make uses cmd or
4603 sh as the shell.
4604
b4289b64
MA
46052011-05-06 Michael Albinus <michael.albinus@gmx.de>
4606
4607 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4608 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4609 is a constant.
4610 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4611 a string. Handle both cases.
4612 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4613 (Fdbus_register_method): Use Qinvalid_function.
4614
af4c0e28
JB
46152011-05-06 Juanma Barranquero <lekktu@gmail.com>
4616
4617 * makefile.w32-in: Update dependencies.
4618 (LISP_H): Add inttypes.h and stdin.h.
4619 (PROCESS_H): Add unistd.h.
4620
c51453d9
EZ
46212011-05-06 Eli Zaretskii <eliz@gnu.org>
4622
4623 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4624 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4625
8ff0ac3c 46262011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4627
4c4b566b
PE
4628 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4629
aab2b9b5
PE
4630 * term.c (vfatal): Remove stray call to va_end.
4631 It's not needed and the C Standard doesn't allow it here anyway.
4632
c378da0b
PE
4633 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4634 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4635
288b08c7
PE
4636 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4637 bytes.
4638
e3601888
PE
4639 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4640
db6c0e74
PE
4641 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4642
dd5963ea
PE
4643 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4644
88c9450f
PE
4645 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4646
2f9442b8
PE
4647 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4648
c032b5f8
PE
4649 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4650 * charset.c (Fdefine_charset_internal): Don't initialize
4651 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4652 32-bit int (Bug#8600).
a108c10b
PE
4653
4654 * lread.c (read_integer): Be more consistent with string-to-number.
4655 Use string_to_number to do the actual conversion; this avoids
4656 rounding errors and fixes some other screwups. Without this fix,
4657 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4658 (digit_to_number): Move earlier, for benefit of read_integer.
4659 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4660 not a digit in any supported base. (Bug#8602)
a108c10b 4661
ad5f9eea
PE
4662 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4663
aec1708a
PE
4664 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4665 to match comment at start of function. This also removes a
4666 GCC warning about overflow in a 32+64-bit port.
4667
47be4ab5
PE
4668 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4669
371cac43
PE
4670 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4671 Reported by Stefan Monnier in
4672 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4673 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4674 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4675
d01a7826
PE
4676 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4677 (EMACS_UINTPTR): Likewise, with uintptr_t.
4678
7fd47d5c
PE
4679 * lisp.h: Prefer 64-bit EMACS_INT if available.
4680 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4681 on 32-bit hosts that have 64-bit int, so that they can access
4682 large files.
122b0c86
PE
4683 However, temporarily disable this change unless the temporary
4684 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4685
8727937b
PE
4686 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4687
8ac068ac
PE
4688 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4689 This removes an assumption that EMACS_INT and long are the same
4690 width as pointers. The assumption is true for Emacs porting targets
4691 now, but we want to make other targets possible.
4692 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4693 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4694 In the rest of the code, change types of integers that hold casted
4695 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4696 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4697 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4698 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4699 No need to cast type when ORing.
4700 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4701 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4702 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4703 assume EMACS_INT is the same width as char *.
4704 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4705 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4706 Remove no-longer-needed casts.
4707 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4708 (xg_tool_bar_help_callback, xg_make_tool_item):
4709 Use EMACS_INTPTR to hold an integer
4710 that will be cast to void *; this can avoid a GCC warning
4711 if EMACS_INT is not the same width as void *.
4712 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4713 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4714 (current_message_1, set_message_1):
4715 Use a local to convert to proper width without a cast.
4716 * xmenu.c (dialog_selection_callback): Likewise.
4717
ede49d71
PE
4718 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4719 Also, don't assume VALBITS / RAND_BITS is less than 5,
4720 and don't rely on undefined behavior when shifting a 1 left into
4721 the sign bit.
4722 * lisp.h (get_random): Change signature to match.
4723
2f30ecd0
PE
4724 * lread.c (hash_string): Use size_t, not int, for hash computation.
4725 Normally we prefer signed values; but hashing is special, because
4726 it's better to use unsigned division on hash table sizes so that
4727 the remainder is nonnegative. Also, size_t is the natural width
4728 for hashing into memory. The previous code used 'int', which doesn't
4729 retain enough info to hash well into very large tables.
4730 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4731
2a866e7b
PE
4732 * dbusbind.c: Don't possibly lose pointer info when converting.
4733 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4734 Use XPNTR rather than XHASH, so that the high-order bits of
4735 the pointer aren't lost when converting through void *.
4736
51639eac
PE
4737 * eval.c (Fautoload): Don't double-shift a pointer.
4738
92394119
PE
4739 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4740
dbdb9a7c
JB
47412011-05-06 Juanma Barranquero <lekktu@gmail.com>
4742
4743 * gnutls.c (DEF_GNUTLS_FN):
4744 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4745
db7a0b4f
AS
47462011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4747
4748 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4749 marker. (Bug#8610)
4750
f7ff1b0f 47512011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4752
4753 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4754 New version that can reserve upto 2GB of heap space.
4755
f7ff1b0f 47562011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4757
4758 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4759
639c109b
TZ
47602011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4761
4762 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4763 `gnutls_certificate_set_x509_key_file'.
4764
d2127135
JB
47652011-05-05 Juanma Barranquero <lekktu@gmail.com>
4766
4767 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4768 Update dependencies.
4769
e968f4f3
JB
47702011-05-04 Juanma Barranquero <lekktu@gmail.com>
4771
4772 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4773 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4774 Remove unused parameter `fildes'.
4775 * process.c (read_process_output, send_process): Don't pass it.
4776
84d358f0
JB
47772011-05-04 Juanma Barranquero <lekktu@gmail.com>
4778
4779 Fix previous change: the library cache is defined in w32.c.
4780 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4781 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4782
0898ca10
JB
47832011-05-04 Juanma Barranquero <lekktu@gmail.com>
4784
4785 Implement dynamic loading of GnuTLS on Windows.
4786
4787 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4788 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4789 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4790 Declare.
4791
4792 * gnutls.c (Qgnutls_dll): Define.
4793 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4794 (gnutls_*): Declare function pointers.
4795 (init_gnutls_functions): New function to initialize function pointers.
4796 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4797 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4798 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4799 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4800 (emacs_gnutls_write, emacs_gnutls_read)
4801 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4802 (Fgnutls_available_p): New function.
4803 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4804 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4805 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4806
4807 * image.c: Include w32.h.
4808 (Vimage_type_cache): Delete.
4809 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4810 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4811 (w32_delayed_load): Move to w32.c.
4812
4813 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4814
4815 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4816 (w32_delayed_load): Move from image.c. When loading a library, record
4817 its filename in the :loaded-from property of the library id.
4818 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4819 Initialize and staticpro them.
4820 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4821
4822 * process.c: Include lisp.h before w32.h, not after.
4823 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4824 instead of gnutls_record_check_pending.
4825
4826 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4827
ff4de4aa
TZ
48282011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4829
4830 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4831 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4832 as passed in.
4833
abe95abb
JD
48342011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4835
4836 * xterm.c (x_set_frame_alpha): Do not set property on anything
4837 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4838
e16e55d4
JB
48392011-05-02 Juanma Barranquero <lekktu@gmail.com>
4840
4841 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4842
bafcf6a5
JB
48432011-05-02 Juanma Barranquero <lekktu@gmail.com>
4844
4845 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4846 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4847 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4848 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4849 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4850 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4851 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4852 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4853 (Qgnutls_bootprop_callbacks_verify): Make static.
4854
e7a6747f
AS
48552011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4856
19ed11ba
AS
4857 * callproc.c: Indentation fixup.
4858
e7a6747f 4859 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4860 (wait_for_termination, interruptible_wait_for_termination):
4861 Move after wait_for_termination_1.
e7a6747f 4862
1ef14cb4
LMI
48632011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4864
4865 * sysdep.c (interruptible_wait_for_termination): New function
4866 which is like wait_for_termination, but allows keyboard
4867 interruptions.
4868
4869 * callproc.c (Fcall_process): Add (:file "file") as an option for
4870 the STDOUT buffer.
4871 (Fcall_process_region): Ditto.
4872
330d880c
EZ
48732011-04-30 Eli Zaretskii <eliz@gnu.org>
4874
8db90b73
EZ
4875 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4876 rather than `XVECTOR (FOO)->size'.
4877
330d880c
EZ
4878 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4879 inttypes.h, as a gnulib replacement is used if it not available in
4880 system headers.
4881
15cbd324
EZ
48822011-04-21 Eli Zaretskii <eliz@gnu.org>
4883
4884 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4885 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4886 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4887
4888 * coding.c (coding_alloc_by_realloc): Error out if destination
4889 will grow beyond MOST_POSITIVE_FIXNUM.
4890 (decode_coding_emacs_mule): Abort if there isn't enough place in
4891 charbuf for the composition carryover bytes. Reserve an extra
4892 space for up to 2 characters produced in a loop.
4893 (decode_coding_iso_2022): Abort if there isn't enough place in
4894 charbuf for the composition carryover bytes.
4895
48962011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4897
ae940cca
EZ
4898 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4899 aborting when %lld or %lll format is passed.
4900 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4901 %llo or %llx format is passed. (Bug#8545)
4902
03ab8921
EZ
4903 * window.c (window_scroll_line_based): Use a marker instead of
4904 simple variables to record original value of point. (Bug#7952)
4905
afda1437
EZ
4906 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4907 produced by %s or %c overflows available buffer space. (Bug#8545)
4908
f76dee0c
PE
49092011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4910
4911 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4912 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4913
fdc5744d
JB
49142011-04-28 Juanma Barranquero <lekktu@gmail.com>
4915
4916 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4917
638f053a
JB
49182011-04-28 Juanma Barranquero <lekktu@gmail.com>
4919
4920 * keyboard.c (Qdelayed_warnings_hook): Define.
4921 (command_loop_1): Run `delayed-warnings-hook'
4922 if Vdelayed_warnings_list is non-nil.
4923 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4924 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4925
d178f871
EZ
49262011-04-28 Eli Zaretskii <eliz@gnu.org>
4927
4928 * doprnt.c (doprnt): Don't return value smaller than the buffer
4929 size if the message was truncated. (Bug#8545).
4930
b124fd93
JB
49312011-04-28 Juanma Barranquero <lekktu@gmail.com>
4932
4933 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4934 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4935
e810457d
PE
49362011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4937
4938 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4939
ea51cceb
JB
49402011-04-27 Juanma Barranquero <lekktu@gmail.com>
4941
4942 * makefile.w32-in: Update dependencies.
4943
94dcfacf
EZ
49442011-04-27 Eli Zaretskii <eliz@gnu.org>
4945
4946 Improve `doprnt' and its usage. (Bug#8545)
4947 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4948 `format_end'. Remove support for %l as a conversion specifier.
4949 Don't use xrealloc. Improve diagnostics when the %l size modifier
4950 is used. Update the commentary.
4951
4952 * eval.c (verror): Simplify calculation of size_t.
4953
4954 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4955 messages.
4956
f61f41d7
PE
49572011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4958
4959 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4960 change.
4961
96fb4434
PE
49622011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4963
4964 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4965 This makes this file independent of the recent pseudovector change.
4966
671875da 49672011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4968
69e9b5a3
PE
4969 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4970
b5f869a7 4971 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4972 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4973 Remove unused local.
c8926152 4974 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4975
841a1577 4976 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4977 GCC 4.6.0 optimizes based on type-based alias analysis.
4978 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4979 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4980 != &v->size, and therefore "v->size = 1; b->size = 2; return
4981 v->size;" must therefore return 1. This assumption is incorrect
4982 for Emacs, since it type-puns struct Lisp_Vector * with many other
4983 types. To fix this problem, this patch adds a new type struct
f904488f 4984 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4985 and pseudovectors, and helps optimizing compilers not get fooled
4986 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4987 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4988 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4989 the size member.
eab3844f
PE
4990 (XSETPVECTYPE): Rewrite in terms of new macro.
4991 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4992 This is a bit clearer, and further avoids the possibility of
4993 undesirable aliasing.
4994 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4995 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4996 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4997 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4998 (ASIZE): Now uses header.size rather than size.
4999 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5000 to avoid the hassle of writing XVECTOR (foo)->header.size.
5001 (struct vectorlike_header): New type.
eab3844f
PE
5002 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5003 object, to help avoid aliasing.
5004 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5005 (SUBRP): Likewise, since Lisp_Subr is a special case.
5006 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5007 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5008 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5009 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5010 changed to be "header.size" and "header.next".
5011 * buffer.h (struct buffer): Likewise.
5012 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5013 * frame.h (struct frame): Likewise.
5014 * process.h (struct Lisp_Process): Likewise.
5015 * termhooks.h (struct terminal): Likewise.
5016 * window.c (struct save_window_data, struct saved_window): Likewise.
5017 * window.h (struct window): Likewise.
5018 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5019 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5020 * buffer.c (init_buffer_once): Likewise.
5021 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5022 special case.
5023 * process.c (Fformat_network_address): Use local var for size,
5024 for brevity.
5025
0df1eac5
PE
5026 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5027
847ab9d1 5028 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5029 * data.c (atof): Remove decl; no longer used or needed.
5030 (digit_to_number): Move to lread.c.
5031 (Fstring_to_number): Use new string_to_number function, to be
5032 consistent with how the Lisp reader treats infinities and NaNs.
5033 Do not assume that floating-point numbers represent EMACS_INT
5034 without losing information; this is not true on most 64-bit hosts.
5035 Avoid double-rounding errors, by insisting on integers when
5036 parsing non-base-10 numbers, as the documentation specifies.
5037 * lisp.h (string_to_number): New decl, replacing ...
5038 (isfloat_string): Remove.
bc0a5c13 5039 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5040 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5041 appears to have been a coding error. Similarly, do not accept
5042 strings like +-1e0 as floating point numbers. Do not report
5043 overflow for integer overflows unless the base is not 10 which
5044 means we have no simple and reliable way to continue.
5045 Break out the floating-point parsing into a new
5046 function string_to_number, so that Fstring_to_number parses
5047 floating point numbers consistently with the Lisp reader.
04f2d78b 5048 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5049 (E_CHAR, EXP_INT): Remove, replacing with ...
5050 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5051 (string_to_number): New function, replacing isfloat_string.
5052 This function checks for valid syntax and produces the resulting
5053 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5054 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5055 so that overflow for non-base-10 numbers is reported only when
5056 there's no portable and simple way to convert to floating point.
452f4150 5057
67769ffc
PE
5058 * textprop.c (set_text_properties_1): Rewrite for clarity,
5059 and to avoid GCC warning about integer overflow.
5060
c20db43f
PE
5061 * intervals.h (struct interval): Use EMACS_INT for members
5062 where EMACS_UINT might cause problems. See
5063 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5064 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5065 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5066 All uses changed.
37aa2f85
PE
5067 (offset_intervals): Tell GCC not to worry about length overflow
5068 when negating a negative length.
c20db43f 5069
2538aa2f
PE
5070 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5071 (overrun_check_free): Likewise.
5072
f2d3008d
PE
5073 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5074 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5075 word size.
5076
ec8df744
PE
5077 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5078 (gnutls_make_error): Rename local to avoid shadowing.
5079 (gnutls_emacs_global_deinit): ifdef out; not used.
5080 (Fgnutls_boot): Use const for pointer to readonly storage.
5081 Comment out unused local. Fix pointer signedness problems.
5082
640ee02d
PE
5083 * lread.c (openp): Don't stuff size_t into an 'int'.
5084 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5085 about possible signed overflow.
5086
6048fb2a
PE
5087 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5088 (GDK_KEY_g): Don't define if already defined.
5089 (xg_prepare_tooltip): Avoid pointer signedness problem.
5090 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5091
fa3c87e1
PE
5092 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5093 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5094
2172544b
PE
5095 * xfns.c (Fx_window_property): Simplify a bit,
5096 to make a bit faster and to avoid GCC 4.6.0 warning.
5097 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5098
9b821a21
PE
5099 * fns.c (internal_equal): Don't assume size_t fits in int.
5100
3c616cfa
PE
5101 * alloc.c (compact_small_strings): Tighten assertion a little.
5102
c2982e87
PE
5103 Replace pEd with more-general pI, and fix some printf arg casts.
5104 * lisp.h (pI): New macro, generalizing old pEd macro to other
5105 conversion specifiers. For example, use "...%"pI"d..." rather
5106 than "...%"pEd"...".
5107 (pEd): Remove. All uses replaced with similar uses of pI.
5108 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5109 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5110 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5111 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5112 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5113 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5114 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5115 64-bit hosts.
5116 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5117 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5118 * print.c (safe_debug_print, print_object): Likewise.
5119 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5120 to int.
6f04d126
PE
5121 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5122 avoiding the 0 flag, which is not portable.
c2982e87
PE
5123 * process.c (Fmake_network_process): Use pI to avoid cast.
5124 * region-cache.c (pp_cache): Likewise.
5125 * xdisp.c (decode_mode_spec): Likewise.
5126 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5127 behavior on 64-bit hosts with printf arg.
6f04d126 5128 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5129 (x_stop_queuing_selection_requests): Likewise.
5130 (x_get_window_property): Don't truncate byte count to an 'int'
5131 when tracing.
0b432f21 5132
5e073ec7
PE
5133 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5134 here, since it parses constructs like leading '-' and spaces,
5135 which are not wanted; and it overflows with large numbers.
5136 Instead, simply match F[0-9]+, which is what is wanted anyway.
5137
36372bf9
PE
5138 * alloc.c: Remove unportable assumptions about struct layout.
5139 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5140 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5141 (allocate_vectorlike, make_pure_vector): Use the new macros,
5142 plus offsetof, to remove unportable assumptions about struct layout.
5143 These assumptions hold on all porting targets that I know of, but
5144 they are not guaranteed, they're easy to remove, and removing them
5145 makes further changes easier.
5146
0b432f21
PE
5147 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5148 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5149 (string_overrun_cookie): Now const. Use initializers that
5150 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5151 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5152 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5153 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5154 multiple of sizeof (EMACS_INT); it need not be, if
5155 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5156 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5157
895009e1
JB
51582011-04-26 Juanma Barranquero <lekktu@gmail.com>
5159
5160 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5161
6a7a1b0b
TZ
51622011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5163
5164 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5165 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5166 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5167
841a1577 51682011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5169
5170 * lisp.h (Qdebug): List symbol.
895009e1 5171 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5172 * keyboard.c (debug-on-event): New variable.
5173 (handle_user_signal): Break into debugger when debug-on-event
5174 matches the current signal symbol.
5175
f2d3ba6f
DN
51762011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5177
5178 * alloc.c (check_sblock, check_string_bytes)
5179 (check_string_free_list): Convert to standard C.
5180
42ce4c63
TZ
51812011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5182
5183 * w32.c (emacs_gnutls_push): Fix typo.
5184
825cd63c
EZ
51852011-04-25 Eli Zaretskii <eliz@gnu.org>
5186
fb11d64d
EZ
5187 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5188 "cast to pointer from integer of different size".
5189
825cd63c
EZ
5190 Improve doprnt and its use in verror. (Bug#8545)
5191 * doprnt.c (doprnt): Document the set of format control sequences
5192 supported by the function. Use SAFE_ALLOCA instead of always
5193 using `alloca'.
5194
5195 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5196 is one byte too soon. Don't use xrealloc; instead xfree and
5197 xmalloc anew.
5198
e061a11b
TZ
51992011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5200
5201 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5202 callbacks stage.
5203
5204 * gnutls.c: Renamed global_initialized to
5205 gnutls_global_initialized. Added internals for the
5206 :verify-hostname-error, :verify-error, and :verify-flags
5207 parameters of `gnutls-boot' and documented those parameters in the
5208 docstring. Start callback support.
9173deec
JB
5209 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5210 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5211 on error. Return error code.
e061a11b
TZ
5212 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5213 (emacs_gnutls_read): Likewise.
5214 (Fgnutls_boot): Return handshake error code.
5215 (emacs_gnutls_handle_error): New function.
5216 (wsaerror_to_errno): Likewise.
5217
5218 * w32.h (emacs_gnutls_pull): Add prototype.
5219 (emacs_gnutls_push): Likewise.
5220
5221 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5222 (emacs_gnutls_push): Likewise.
5223
52242011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5225
5226 * process.c (wait_reading_process_output): Check if GnuTLS
5227 buffered some data internally if no FDs are set for TLS
5228 connections.
5229
5230 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5231 (LIBS): Link to USER_LIBS.
5232 ($(BLD)/gnutls.$(0)): New target.
5233
fa6996bc
EZ
52342011-04-24 Eli Zaretskii <eliz@gnu.org>
5235
eb35682e
EZ
5236 * xdisp.c (handle_single_display_spec): Rename the
5237 display_replaced_before_p argument into display_replaced_p, to
5238 make it consistent with the commentary. Fix typos in the
5239 commentary.
5240
e2ad650c
EZ
5241 * textprop.c (syms_of_textprop): Remove dead code.
5242 (copy_text_properties): Delete obsolete commentary about an
5243 interface that was deleted long ago. Fix typos in the description
5244 of arguments.
5245
1b2de274
EZ
5246 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5247 to changes in oldXMenu/XMenu.h from 2011-04-16.
5248 <menu_help_message, prev_menu_help_message>: Constify.
5249 (IT_menu_make_room): menu->help_text is now `const char **';
5250 adjust.
5251
5252 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5253 to changes in oldXMenu/XMenu.h from 2011-04-16.
5254 (struct XMenu): Declare `help_text' `const char **'.
5255
5256 * xfaces.c <Qunspecified>: Make extern again.
5257
5258 * syntax.c: Include sys/types.h before including regex.h, as
5259 required by Posix.
5260
762b15be
EZ
5261 * doc.c (get_doc_string): Improve the format passed to `error'.
5262
5263 * doprnt.c (doprnt): Improve commentary.
5264
5265 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5266
5267 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5268 them with etags.
5269
f1052e5d
EZ
5270 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5271 changes in globals.h immediately force recompilation.
762b15be
EZ
5272 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5273 $(CURDIR)/s/ms-w32.h.
5274 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5275
fa6996bc
EZ
5276 * character.c (Fchar_direction): Function deleted.
5277 (syms_of_character): Don't defsubr it.
5278 <char-direction-table>: Deleted.
5279
e6c3da20
EZ
52802011-04-23 Eli Zaretskii <eliz@gnu.org>
5281
5282 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5283 * doprnt.c: Include limits.h.
5284 (SIZE_MAX): New macro.
04f2d78b
CB
5285 (doprnt): Return a size_t value. 2nd arg is now size_t.
5286 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5287 Improve overflow protection. Support `l' modifier for integer
5288 conversions. Support %l conversion. Don't assume an EMACS_INT
5289 argument for integer conversions and for %c.
5290
5291 * lisp.h (doprnt): Restore prototype.
5292
5293 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5294 $(SRC)/character.h.
5295
5296 * Makefile.in (base_obj): Add back doprnt.o.
5297
5298 * deps.mk (doprnt.o): Add back prerequisites.
5299 (callint.o): Depend on character.h.
5300
5301 * eval.c (internal_lisp_condition_case): Include the handler
5302 representation in the error message.
5303 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5304 when breaking from the loop.
5305
5306 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5307
5308 * callint.c (Fcall_interactively): When displaying error message
5309 about invalid control letter, pass the character's codepoint, not
5310 a pointer to its multibyte form. Improve display of the character
5311 in octal and display also its hex code.
5312
5313 * character.c (char_string): Use %x to display the (unsigned)
5314 codepoint of an invalid character, to avoid displaying a bogus
5315 negative value.
5316
5317 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5318 `error', not SYMBOL_NAME itself.
5319
5320 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5321 character arguments to `error'.
5322
5323 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5324 to `error' in error message about FINAL_CHAR argument. Make sure
5325 FINAL_CHAR is a character, and use %c when it is passed as
5326 argument to `error'.
5327
4ffd0d6b 53282011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5329
5330 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5331
5332 * w32.c: Include <time.h>.
5333 (sys_localtime): New function.
5334
4ffd0d6b 53352011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5336
5337 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5338
4ffd0d6b 5339 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5340
4ffd0d6b 53412011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5342
4ffd0d6b
GM
5343 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5344 zombies (Bug#8467).
aac0c6e3 5345
04c56954
EZ
53462011-04-19 Eli Zaretskii <eliz@gnu.org>
5347
5348 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5349 gl_state.e_property when gl_state.object is Qt.
5350
5351 * insdel.c (make_gap_larger): Remove limitation of buffer size
5352 to <= INT_MAX.
5353
16a43933
CY
53542011-04-18 Chong Yidong <cyd@stupidchicken.com>
5355
5356 * xdisp.c (lookup_glyphless_char_display)
5357 (produce_glyphless_glyph): Handle cons cell entry in
5358 glyphless-char-display.
5359 (Vglyphless_char_display): Document it.
5360
5361 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5362 glyphless-char-display.
5363
4581706e
CY
53642011-04-17 Chong Yidong <cyd@stupidchicken.com>
5365
5366 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5367
5368 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5369
5370 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5371 definition for no-X builds.
5372
4887c6e2 53732011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5374
fd35b6f9
PE
5375 Static checks with GCC 4.6.0 and non-default toolkits.
5376
5c1ccb01
PE
5377 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5378
006c5daa
PE
5379 * process.c (keyboard_bit_set): Define only if SIGIO.
5380 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5381 (send_process): Repair possible setjmp clobbering.
5382
efc736d3
PE
5383 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5384
4e2fe2e6
PE
5385 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5386
f97334a2
PE
5387 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5388
4e75f29d
PE
5389 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5390 Define only if needed.
5391
90efadd1
PE
5392 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5393 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5394 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5395
3c647824
PE
5396 * dispextern.h (struct redisplay_interface): Rename param
5397 to avoid shadowing.
e264f262 5398 * termhooks.h (struct terminal): Likewise.
761383f4 5399 * xterm.c (xembed_send_message): Likewise.
3c647824 5400
b58c5c4a
PE
5401 * insdel.c (make_gap_smaller): Define only if
5402 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5403
cad59032
PE
5404 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5405 it.
5406
c339dc2e
PE
5407 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5408 so that we aren't warned about unused symbols.
5409
91a3e27b
PE
5410 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5411
399c71d3 5412 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5413
8ffc96f5
PE
5414 * xfns.c (x_real_positions): Mark locals as initialized.
5415
eef9bc79
PE
5416 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5417
098db9dd
PE
5418 * xterm.c: Fix problems found by static analysis with other toolkits.
5419 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5420 (x_dispatch_event): Declare static if USE_GTK, and
5421 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5422 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5423 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5424 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5425 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5426
eb18f6cc
PE
5427 * xmenu.c (menu_help_callback): Pointer type fixes.
5428 Use const pointers when pointing at readonly data. Avoid pointer
5429 signedness clashes.
5430 (FALSE): Remove unused macro.
5431 (update_frame_menubar): Remove unused decl.
5432
1fe72bf8
PE
5433 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5434
60d9e1db
PE
5435 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5436 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5437 (single_menu_item): Rename local to avoid shadowing.
5438
39261c26
PE
5439 * keyboard.c (make_lispy_event): Remove unused local var.
5440
018c5e19
PE
5441 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5442 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5443
63d2b86e
PE
5444 * bitmaps: Change bitmaps from unsigned char back to the X11
5445 compatible char. Avoid the old compiler warnings about
5446 out-of-range initializers by using, for example, '\xab' rather
5447 than 0xab.
5448
aefd87e1
PE
5449 * xgselect.c (xgselect_initialize): Check vs interface
5450 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5451
bf501fb9
PE
5452 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5453
e9829fdf
PE
5454 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5455 to read-only memory.
5456
1086c095
PE
5457 * fns.c (vector): Remove; this old hack is no longer needed.
5458
2baccd04 5459 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5460 Remove unused var.
dde42981 5461 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5462
72391843 5463 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5464
436c16df 5465 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5466 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5467 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5468
92bb796d 5469 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5470 (x_term_init): Remove local to avoid shadowing.
92bb796d 5471
764430a3 5472 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5473
5474 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5475 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5476
d1dfb56c
EZ
54772011-04-16 Eli Zaretskii <eliz@gnu.org>
5478
c4354cb4
EZ
5479 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5480
d1dfb56c
EZ
5481 Fix regex.c, syntax.c and friends for buffers > 2GB.
5482 * syntax.h (struct gl_state_s): Declare character position members
5483 EMACS_INT.
5484
5485 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5486
04f2d78b
CB
5487 * textprop.c (verify_interval_modification, interval_of):
5488 Declare arguments EMACS_INT.
d1dfb56c
EZ
5489
5490 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5491 EMACS_INT.
5492
5493 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5494
5495 * indent.c (Fvertical_motion): Local variable it_start is now
5496 EMACS_INT.
5497
5498 * regex.c (re_match, re_match_2, re_match_2_internal)
5499 (bcmp_translate, regcomp, regexec, print_double_string)
5500 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5501 (re_compile_pattern, re_exec): Declare arguments and local
5502 variables `size_t' and `ssize_t' and return values `regoff_t', as
5503 appropriate.
5504 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5505 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5506 <compile_stack_type>: `size' and `avail' are now `size_t'.
5507
5508 * regex.h <regoff_t>: Use ssize_t, not int.
5509 (re_search, re_search_2, re_match, re_match_2): Arguments that
5510 specify buffer/string position and length are now ssize_t and
5511 size_t. Return type is regoff_t.
5512
613052cd
BK
55132011-04-16 Ben Key <bkey76@gmail.com>
5514
5515 * nsfont.m: Fixed bugs in ns_get_family and
5516 ns_descriptor_to_entity that were caused by using free to
5517 deallocate memory blocks that were allocated by xmalloc (via
5518 xstrdup). This caused Emacs to crash when compiled with
5519 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5520 --enable-checking=xmallocoverrun). xfree is now used to
5521 deallocate these memory blocks.
5522
4170f62f 55232011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5524
71b41406
PE
5525 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5526
9587a89d
PE
5527 emacs_write: Accept and return EMACS_INT for sizes.
5528 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5529 et seq.
5530 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5531 Accept and return EMACS_INT.
5532 (emacs_gnutls_write): Return the number of bytes written on
5533 partial writes.
5534 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5535 (emacs_read, emacs_write): Remove check for negative size, as the
5536 Emacs source code has been audited now.
9587a89d
PE
5537 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5538 (emacs_read, emacs_write): Use it.
273a5f82
PE
5539 * process.c (send_process): Adjust to the new signatures of
5540 emacs_write and emacs_gnutls_write. Do not attempt to store
5541 a byte offset into an 'int'; it might overflow.
9587a89d 5542 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5543
3e047f51
PE
5544 * sound.c: Don't assume sizes fit in 'int'.
5545 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5546 Return EMACS_INT, not int.
3e047f51 5547 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5548 Accept EMACS_INT, not int.
5549 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5550 record read return values.
5551
cc39a9db
BK
55522011-04-15 Ben Key <bkey76@gmail.com>
5553
c9d0ec6d
JB
5554 * keyboard.c (Qundefined): Don't declare static since it is used
5555 in nsfns.m.
5556 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5557 static since they are used in nsfont.m.
cc39a9db 5558
6c60eb9f
SM
55592011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5560
5561 * process.c (Qprocessp): Don't declare static.
5562 * lisp.h (Qprocessp): Declare again.
5563
7990b61a
JB
55642011-04-15 Juanma Barranquero <lekktu@gmail.com>
5565
5566 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5567
5d4cb038
PE
55682011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5569
8bd7b830 5570 Improve C-level modularity by making more things 'static'.
cd64ea1d 5571
e3b27b31
PE
5572 Don't publish debugger-only interfaces to other modules.
5573 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5574 (verify_bytepos, count_markers): Move decls to the only modules
5575 that need them.
5576 * region-cache.h (pp_cache): Likewise.
5577 * window.h (check_all_windows): Likewise.
5578 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5579
5d4cb038
PE
5580 * sysdep.c (croak): Now static, if
5581 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5582 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5583
5584 * alloc.c (refill_memory_reserve): Now static if
5585 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5586 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5587
e87b6180
PE
5588 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5589 Define only if USE_LUCID.
5590
ac64929e
PE
5591 * xrdb.c (x_customization_string, x_rm_string): Now static.
5592
6f37259d
PE
5593 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5594 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5595
1683e3ab
PE
5596 * xdisp.c (draw_row_with_mouse_face): Now static.
5597 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5598
de9c2632
PE
5599 * window.h (check_all_windows): Mark externally visible.
5600
2b96acb7
PE
5601 * window.c (window_deletion_count): Now static.
5602
5603 * undo.c: Make symbols static if they're not exported.
5604 (last_undo_buffer, last_boundary_position, pending_boundary):
5605 Now static.
5606
50436f33
PE
5607 * textprop.c (interval_insert_behind_hooks): Now static.
5608 (interval_insert_in_front_hooks): Likewise.
5609
64520e5c
PE
5610 * term.c: Make symbols static if they're not exported.
5611 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5612 (max_frame_lines, tty_set_terminal_modes):
5613 (tty_reset_terminal_modes, tty_turn_off_highlight):
5614 (get_tty_terminal): Now static.
5615 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5616 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5617 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5618 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5619 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5620
1fa53021
PE
5621 * sysdep.c: Make symbols static if they're not exported.
5622 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5623 Now static.
5624 (sigprocmask_set, full_mask): Remove; unused.
5625 (wait_debugging): Mark as visible.
5626 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5627 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5628
d4b43b22
PE
5629 * syntax.c (syntax_temp): Define only if !__GNUC__.
5630
b7c513d0
PE
5631 * sound.c (current_sound_device, current_sound): Now static.
5632
989b29ad
PE
5633 * search.c (searchbufs, searchbuf_head): Now static.
5634
13a55a78
PE
5635 * scroll.c (scroll_cost): Remove; unused.
5636 * dispextern.h (scroll_cost): Remove decl.
5637
de68a1fc
PE
5638 * region-cache.h (pp_cache): Mark as externally visible.
5639
40ccffa6
PE
5640 * process.c: Make symbols static if they're not exported.
5641 (process_tick, update_tick, create_process, chan_process):
5642 (Vprocess_alist, proc_buffered_char, datagram_access):
5643 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5644 (deactivate_process): Mark defn as static, as well as decl.
5645 * lisp.h (create_process): Remove decl.
5646 * process.h (chan_process, Vprocess_alist): Remove decls.
5647
ad64fc97
PE
5648 * print.c: Make symbols static if they're not exported.
5649 (print_depth, new_backquote_output, being_printed, print_buffer):
5650 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5651 (print_interval, print_number_index, initial_stderr_stream):
5652 Now static.
5653 * lisp.h (Fprinc): Remove decl.
5654 (debug_output_compilation_hack): Mark as externally visible.
5655
adddb265
PE
5656 * sysdep.c (croak): Move decl from here to syssignal.h.
5657 * syssignal.h (croak): Put it here, so the API can be checked when
5658 'croak' is called from dissociate_if_controlling_tty.
5659
1717ede2
PE
5660 * minibuf.c: Make symbols static if they're not exported.
5661 (minibuf_save_list, choose_minibuf_frame): Now static.
5662 * lisp.h (choose_minibuf_frame): Remove decl.
5663
fa5fb2bc
PE
5664 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5665
1e3890d1
PE
5666 * lread.c: Make symbols static if they're not exported.
5667 (read_objects, initial_obarray, oblookup_last_bucket_number):
5668 Now static.
5669 (make_symbol): Remove; unused.
5670 * lisp.h (initial_obarray, make_symbol): Remove decls.
5671
8a1414fa
PE
5672 * keyboard.c: Make symbols static if they're not exported.
5673 (single_kboard, recent_keys_index, total_keys, recent_keys):
5674 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5675 (this_single_command_key_start, echoing, last_auto_save):
5676 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5677 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5678 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5679 (Vlispy_mouse_stem, double_click_count):
5680 Now static.
5681 (force_auto_save_soon): Define only if SIGDANGER.
5682 (ignore_mouse_drag_p): Now static if
5683 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5684 (print_help): Remove; unused.
5685 (stop_character, last_timer_event): Mark as externally visible.
5686 * keyboard.h (ignore_mouse_drag_p): Declare only if
5687 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5688 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5689 * lisp.h (echoing): Remove decl.
5690 (force_auto_save_soon): Declare only if SIGDANGER.
5691 * xdisp.c (redisplay_window): Simplify code, to make it more
5692 obvious that ignore_mouse_drag_p is not accessed if !defined
5693 USE_GTK && !defined HAVE_NS.
5694
93ea6e8f
PE
5695 * intervals.c: Make symbols static if they're not exported.
5696 (merge_properties_sticky, merge_interval_right, delete_interval):
5697 Now static.
5698 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5699
77382fcc
PE
5700 * insdel.c: Make symbols static if they're not exported.
5701 However, leave prepare_to_modify_buffer alone. It's never
5702 called from outside this function, but that appears to be a bug.
5703 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5704 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5705 (adjust_after_replace_noundo): Remove; unused.
5706 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5707 (signal_before_change): Remove decls.
77382fcc 5708
9306c32e
PE
5709 * indent.c (val_compute_motion, val_vmotion): Now static.
5710
cd44d2eb
PE
5711 * image.c: Make symbols static if they're not exported.
5712 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5713 if USE_GTK.
5714 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5715 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5716
ad9a7a06
PE
5717 * fringe.c (standard_bitmaps): Now static.
5718 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5719
81626931
PE
5720 * frame.c: Make symbols static if they're not exported.
5721 (x_report_frame_params, make_terminal_frame): Now static.
5722 (get_frame_param): Now static, unless HAVE_NS.
5723 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5724 (x_get_resource_string): Remove; not used.
5725 * frame.h (make_terminal_frame, x_report_frame_params):
5726 (x_get_resource_string); Remove decls.
5727 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5728 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5729
239f9db9
PE
5730 * font.c, fontset.c: Make symbols static if they're not exported.
5731 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5732 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5733 * font.c (font_close_object): Now static.
5734 * font.h (font_close_object): Remove.
5735 * fontset.c (FONTSET_OBJLIST): Remove.
5736 (free_realized_fontset) #if-0 the body, which does nothing.
5737 (face_suitable_for_char_p): #if-0, as it's never called.
5738 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5739 * xfaces.c (face_at_string_position):
5740 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5741 since 0 is always ASCII.
5742
dfcf3579
PE
5743 * fns.c (weak_hash_tables): Now static.
5744
5045092b
PE
5745 * fileio.c: Make symbols static if they're not exported.
5746 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5747 (Vwrite_region_annotation_buffers): Now static.
5748
57a96f5c
PE
5749 * eval.c: Make symbols static if they're not exported.
5750 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5751 * lisp.h (backtrace_list): Remove decl.
5752
35f08c38
PE
5753 * emacs.c: Make symbols static if they're not exported.
5754 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5755 (fatal_error_code, fatal_error_signal_hook, standard_args):
5756 Now static.
5757 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5758 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5759 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5760 * lisp.h (fatal_error_signal_hook): Remove decl.
5761 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5762
f44bd759
PE
5763 * editfns.c: Move a (normally-unused) function to its only use.
5764 * editfns.c, lisp.h (get_operating_system_release): Remove.
5765 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5766 worth the hassle of breaking this out.
5767
b532497d
PE
5768 * xterm.c: Make symbols static if they're not exported.
5769 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5770 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5771 (x_destroy_window, x_delete_display):
5772 Now static.
5773 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5774 (x_mouse_leave): Remove; unused.
5775 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5776 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5777 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5778 Remove decls.
5779 (x_mouse_leave): Declare only if WINDOWSNT.
5780 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5781 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5782 USE_X_TOOLKIT.
5783
1675728f
PE
5784 * ftxfont.c: Make symbols static if they're not exported.
5785 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5786 HAVE_FREETYPE.
5787 * font.h (ftxfont_driver): Likewise.
5788
e4cebfca
PE
5789 * xfns.c: Make symbols static if they're not exported.
5790 (x_last_font_name, x_display_info_for_name):
5791 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5792 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5793 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5794 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5795 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5796 (last_show_tip_args): Now static.
5797 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5798 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5799 (x_screen_planes): Remove; unused.
5800 * dispextern.h (x_screen_planes): Remove decl.
5801
5bf46f05
PE
5802 * dispnew.c: Make symbols static if they're not exported.
5803 * dispextern.h (redraw_garbaged_frames, scrolling):
5804 (increment_row_positions): Remove.
5805 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5806 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5807 Now static.
5808 (redraw_garbaged_frames): Remove; unused.
5809
435f4c28
PE
5810 * xfaces.c: Make symbols static if they're not exported.
5811 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5812 Remove decls.
5813 * xterm.h (defined_color): Remove decls.
5814 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5815 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5816 (menu_face_changed_default, defined_color, free_realized_face):
5817 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5818 (ascii_face_of_lisp_face): Remove; unused.
5819
8524aef3
PE
5820 * xdisp.c: Make symbols static if they're not exported.
5821 * dispextern.h (scratch_glyph_row, window_box_edges):
5822 (glyph_to_pixel_coords, set_cursor_from_row):
5823 (get_next_display_element, set_iterator_to_next):
5824 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5825 (show_mouse_face): Remove decls
5826 * frame.h (message_buf_print): Likewise.
5827 * lisp.h (pop_message, set_message, check_point_in_composition):
5828 Likewise.
5829 * xterm.h (set_vertical_scroll_bar): Likewise.
5830 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5831 (message_buf_print, scratch_glyph_row, displayed_buffer):
5832 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5833 (get_next_display_element, show_mouse_face, window_box_edges):
5834 (frame_to_window_pixel_xy, check_point_in_composition):
5835 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5836 (glyph_to_pixel_coords): Remove; unused.
5837
16390cd2
PE
5838 * dired.c (file_name_completion): Now static.
5839
5840 * dbusbind.c (xd_in_read_queued_messages): Now static.
5841
a25f4dfa
PE
5842 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5843 * data.c (circular_list_error): Remove.
5844
14a9c8df
PE
5845 * commands.h (last_point_position, last_point_position_buffer):
5846 (last_point_position_window): Remove decls.
5847 * keyboard.c: Make these variables static.
5848
04f2d78b
CB
5849 * coding.h (coding, code_convert_region, encode_coding_gap):
5850 Remove decls.
74ab6df5
PE
5851 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5852 (iso_code_class, detect_coding, code_convert_region): Now static.
5853 (encode_coding_gap): Remove; unused.
5854
38dfbee1
PE
5855 * chartab.c (chartab_chars, chartab_bits): Now static.
5856
a2cb4e63
PE
5857 * charset.h (charset_iso_8859_1): Remove decl.
5858 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5859 Now static.
5860
127198fd
PE
5861 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5862 * ccl.c (Vccl_program_table): Now static.
5863 (check_ccl_update): Remove; unused.
5864
d85b608f
PE
5865 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5866 * category.h: ... from here.
5867 * category.c (check_category_table, set_category_set): Now static.
5868
31cd66f3
PE
5869 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5870 * lisp.h: Remove these decls.
5871
c358e587
PE
5872 * buffer.c (buffer_count): Remove unused var.
5873
e78aecca
PE
5874 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5875 so that it's not optimized away.
5876 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5877 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5878 exported only to the debugger.
5879
e192d7d3 5880 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5881 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5882
92470028
PE
5883 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5884 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5885 was inaccessible from Lisp.
5886 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5887 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5888
244ed907
PE
5889 alloc.c: Import and export fewer symbols, and remove unused items.
5890 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5891 is defined.
5892 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5893 it's not optimized away by whole-program optimization.
5894 (message_enable_multibyte, free_misc): Remove.
5895 (catchlist, handlerlist, mark_backtrace):
5896 Declare only if BYTE_MARK_STACK.
5897 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5898 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5899 (message_enable_multibyte): Remove decl.
5900 (free_misc, interval_free_list, float_block, float_block_index):
5901 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5902 (cons_free_list, last_marked_index):
5903 Now static.
5904 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5905 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5906 (mark_backtrace): Define only if BYTE_MARK_STACK.
5907 * xdisp.c (message_enable_multibyte): Now static.
5908
61c2b50e 5909 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5910 This makes it easier for human readers (and static analyzers)
5911 to see whether these variables are used from other modules.
5912 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5913 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5914 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5915 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5916 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5917 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5918 * xmenu.c, xselect.c:
5919 Declare Q* vars static if they are not used in other modules.
5920 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5921 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5922 Remove decls of unexported vars.
5923 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5924
95c82688
PE
5925 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5926
16a97296
PE
5927 Make Emacs functions such as Fatom 'static' by default.
5928 This makes it easier for human readers (and static analyzers)
5929 to see whether these functions can be called from other modules.
5930 DEFUN now defines a static function. To make the function external
5931 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5932 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5933 (Finit_image_library):
16a97296
PE
5934 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5935 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5936 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5937 Remove decls, since these functions are now static.
5938 (Funintern, Fget_internal_run_time): New decls, since these functions
5939 were already external.
95c82688 5940
16a97296
PE
5941 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5942 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5943 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5944 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5945 * keyboard.c, keymap.c, lread.c:
5946 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5947 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5948 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5949 Mark functions with DEFUE instead of DEFUN,
5950 if they are used in other modules.
5951 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5952 decls for now-static functions.
5953 * buffer.h (Fdelete_overlay): Remove decl.
5954 * callproc.c (Fgetenv_internal): Mark as internal.
5955 * composite.c (Fremove_list_of_text_properties): Remove decl.
5956 (Fcomposition_get_gstring): New forward static decl.
5957 * composite.h (Fcomposite_get_gstring): Remove decl.
5958 * dired.c (Ffile_attributes): New forward static decl.
5959 * doc.c (Fdocumntation_property): New forward static decl.
5960 * eval.c (Ffetch_bytecode): New forward static decl.
5961 (Funintern): Remove extern decl; now in .h file where it belongs.
5962 * fileio.c (Fmake_symbolic_link): New forward static decl.
5963 * image.c (Finit_image_library): New forward static decl.
5964 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5965 * intervals.h (Fprevious_property_change):
5966 (Fremove_list_of_text_properties): Remove decls.
5967 * keyboard.c (Fthis_command_keys): Remove decl.
5968 (Fcommand_execute): New forward static decl.
5969 * keymap.c (Flookup_key): New forward static decl.
5970 (Fcopy_keymap): Now static.
5971 * keymap.h (Flookup_key): Remove decl.
5972 * process.c (Fget_process): New forward static decl.
5973 (Fprocess_datagram_address): Mark as internal.
5974 * syntax.c (Fsyntax_table_p): New forward static decl.
5975 (skip_chars): Remove duplicate decl.
5976 * textprop.c (Fprevious_property_change): New forward static decl.
5977 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5978 Now internal.
5979 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5980 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5981
785bbd42
PE
5982 * editfns.c (Fformat): Remove unreachable code.
5983
8b913b57
AS
59842011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5985
5986 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5987 change. (Bug#8496)
5988
a6744a35
EZ
59892011-04-13 Eli Zaretskii <eliz@gnu.org>
5990
5991 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5992 when at ZV. (Bug#8487)
5993
e7974947
AS
59942011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5995
baad03f0
AS
5996 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5997 (Bug#8437)
5998 * keyboard.c (parse_tool_bar_item): Likewise.
5999 * sound.c (sound_cleanup, alsa_close): Likewise.
6000 * termcap.c (tgetent): Likewise.
6001 * xfns.c (x_default_font_parameter): Likewise.
6002 * xsettings.c (read_and_apply_settings): Likewise.
6003
e7974947
AS
6004 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6005 (overrun_check_free): Protoize.
6006
28272684
PE
60072011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6008
6009 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6010 since callers should never pass a negative size.
6011 Change the signature to match that of plain 'read' and 'write'; see
6012 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6013 * lisp.h: Update prototypes of emacs_write and emacs_read.
6014
11997c76
EZ
60152011-04-11 Eli Zaretskii <eliz@gnu.org>
6016
6017 * xdisp.c (redisplay_window): Don't try to determine the character
6018 position of the scroll margin if the window start point w->startp
e896f03c 6019 is outside the buffer's accessible region. (Bug#8468)
11997c76 6020
8a2cbd72
EZ
60212011-04-10 Eli Zaretskii <eliz@gnu.org>
6022
6023 Fix write-region and its subroutines for buffers > 2GB.
6024 * fileio.c (a_write, e_write): Modify declaration of arguments and
6025 local variables to support buffers larger than 2GB.
6026 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6027
6028 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6029 argument, local variables, and return value.
6030
6031 * lisp.h: Update prototypes of emacs_write and emacs_read.
6032
6033 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6034
4073e537 60352011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6036
1ebfdcb6
PE
6037 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6038
b2ded58d
PE
6039 Fix more problems found by GCC 4.6.0's static checks.
6040
7d66342c
PE
6041 * xdisp.c (vmessage): Use a better test for character truncation.
6042
bbf47d44
PE
6043 * charset.c (load_charset_map): <, not <=, for optimization,
6044 and to avoid potential problems with integer overflow.
9248994d 6045 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6046 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6047 * editfns.c (Fformat): Likewise.
1e69125e 6048 * syntax.c (skip_chars): Likewise.
3befa583 6049
e3019616
PE
6050 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6051 This also lets GCC 4.6.0 generate slightly better loop code.
6052
becfa255
PE
6053 * callint.c (Fcall_interactively): <, not <=, for optimization.
6054 (Fcall_interactively): Count the number of arguments produced,
6055 not the number of arguments given. This is simpler and lets GCC
6056 4.6.0 generate slightly better code.
6057
dae0cd48
PE
6058 * ftfont.c: Distingish more carefully between FcChar8 and char.
6059 The previous code passed unsigned char * to a functions like
6060 strlen and xstrcasecmp that expect char *, which does not
6061 conform to the C standard.
6062 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6063 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6064 char * when the C standard requires it.
6065
76032d70
PE
6066 * keyboard.c (read_char): Remove unused var.
6067
eb3f1cc8
PE
6068 * eval.c: Port to Windows vsnprintf (Bug#8435).
6069 Include <limits.h>.
6070 (SIZE_MAX): Define if the headers do not.
6071 (verror): Do not give up if vsnprintf returns a negative count.
6072 Instead, grow the buffer. This ports to Windows vsnprintf, which
6073 does not conform to C99. Problem reported by Eli Zaretskii.
6074 Also, simplify the allocation scheme, by avoiding the need for
6075 calling realloc, and removing the ALLOCATED variable.
6076
70476b54
PE
6077 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6078
12020a9e
PE
6079 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6080 But keep the doprint source code for now, as we might revamp it
6081 and use it again (Bug#8435).
ea6c7ae6
PE
6082 * lisp.h (doprnt): Remove.
6083 * Makefile.in (base_obj): Remove doprnt.o.
6084 * deps.mk (doprnt.o): Remove.
6085
5fdb398c
PE
6086 error: Print 32- and 64-bit integers portably (Bug#8435).
6087 Without this change, on typical 64-bit hosts error ("...%d...", N)
6088 was used to print both 32- and 64-bit integers N, which relied on
6089 undefined behavior.
6090 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6091 New macro.
6092 * lisp.h (error, verror): Mark as printf-like functions.
6093 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6094 Report overflow in size calculations when allocating printf buffer.
6095 Do not truncate output string at its first null byte.
6096 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6097 Truncate the output at a character boundary, since vsnprintf does not
6098 do that.
6099 * charset.c (check_iso_charset_parameter): Convert internal
6100 character to string before calling 'error', since %c now has the
6101 printf meaning.
6102 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6103 overflow when computing char to be passed to 'error'. Do not
6104 pass Lisp_Object to 'error'; pass the integer instead.
6105 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6106 formatted with plain %d.
6107
b189fa66
PE
6108 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6109
bff87ef0
PE
6110 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6111
7e2cac20
PE
6112 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6113
ce4d90b5
PE
6114 * xterm.c (x_catch_errors): Remove duplicate declaration.
6115
266c9547
PE
6116 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6117
79c49ad2
PE
6118 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6119
368f4090
JM
61202011-04-10 Jim Meyering <meyering@redhat.com>
6121
6122 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6123 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6124 return ssize_t not "int", and use size_t as the buffer length.
6125 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6126 * gnutls.h: Update declarations.
6127 * process.c (read_process_output): Use ssize_t, to match.
6128 (send_process): Likewise.
6129
a32d4040
CY
61302011-04-09 Chong Yidong <cyd@stupidchicken.com>
6131
6132 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6133
8546720e 61342011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6135
04f2d78b
CB
6136 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6137 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6138
8546720e
GM
6139 * xterm.c (handle_one_xevent):
6140 * xmenu.c (create_and_show_popup_menu):
6141 * xselect.c (x_decline_selection_request)
6142 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6143
0a2f5c1a 61442011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6145
6146 Fix some uses of `int' instead of EMACS_INT.
6147 * search.c (string_match_1, fast_string_match)
6148 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6149 (scan_buffer, find_next_newline_no_quit)
6150 (find_before_next_newline, search_command, Freplace_match)
6151 (Fmatch_data): Make some `int' variables be EMACS_INT.
6152
6153 * xdisp.c (display_count_lines): 3rd argument and return value now
6154 EMACS_INT. All callers changed.
6155 (pint2hrstr): Last argument is now EMACS_INT.
6156
6157 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6158 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6159 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6160 (decode_coding_utf_16, decode_coding_emacs_mule)
6161 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6162 (decode_coding_ccl, decode_coding_charset)
6163 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6164 (decode_coding_iso_2022, decode_coding_emacs_mule)
6165 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6166 <char_offset, last_offset>: Declare EMACS_INT.
6167 (encode_coding_utf_8, encode_coding_utf_16)
6168 (encode_coding_emacs_mule, encode_invocation_designation)
6169 (encode_designation_at_bol, encode_coding_iso_2022)
6170 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6171 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6172 Declare EMACS_INT.
6173 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6174 (encode_invocation_designation): Last argument P_NCHARS is now
6175 EMACS_INT.
6176 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6177 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6178
6179 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6180 All users changed.
6181
6182 * ccl.c (Fccl_execute_on_string): Declare some variables
6183 EMACS_INT.
6184
8546720e 61852011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6186
6187 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6188
4e19a977
CS
61892011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6190
6191 * process.c (Fformat_network_address): Doc fix.
6192
87302331
R
61932011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6194
6195 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6196
cbb59342
CY
61972011-04-08 Chong Yidong <cyd@stupidchicken.com>
6198
6199 * keyboard.c (read_char): Call Lisp function help-form-show,
6200 instead of using internal_with_output_to_temp_buffer.
6201 (Qhelp_form_show): New var.
e0d38eeb 6202 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6203
6204 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6205
6206 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6207
e67a13ab
CY
62082011-04-06 Chong Yidong <cyd@stupidchicken.com>
6209
04f2d78b
CB
6210 * process.c (Flist_processes): Remove to Lisp.
6211 (list_processes_1): Delete.
e67a13ab 6212
973f782d
EZ
62132011-04-06 Eli Zaretskii <eliz@gnu.org>
6214
7c106b1e
EZ
6215 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6216
973f782d
EZ
6217 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6218
41cf7d1a 62192011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6220
ca23cc88
PE
6221 Fix more problems found by GCC 4.6.0's static checks.
6222
f390e2d5
PE
6223 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6224
42eea0d0
PE
6225 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6226
b69769da 6227 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6228
f9541e84
PE
6229 * xdisp.c (vmessage): Mark as a printf-like function.
6230
13841b55
PE
6231 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6232
c136c10f
PE
6233 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6234
5e2d4a30
PE
6235 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6236 printf-like functions.
6237 (tiff_load): Add casts to remove these marks before passing them
6238 to system-supplied API.
6239
583f48b9
PE
6240 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6241
b25d760e
PE
6242 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6243 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6244 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6245 directly, rather than having caller test rule sign. This avoids
6246 some unnecessary tests.
6247 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6248 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6249 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6250
bc7b6697 6251 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6252 (xfont_open): Avoid unnecessary tests.
bc7b6697 6253
27ccc379
PE
6254 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6255
dcd5c89a
PE
6256 * composite.h, composite.c (composition_gstring_put_cache):
6257 Use EMACS_INT, not int, for length.
6258
b13a45c6
PE
6259 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6260 breaking out part of COMPOSITION_DECODE_RULE.
6261 (COMPOSITION_DECODE_RULE): Use it.
6262 * composite.c (get_composition_id): Remove unused local vars,
6263 by using the new macro.
6264
1e792e4d
PE
6265 * textprop.c (set_text_properties_1): Change while to do-while,
6266 since the condition is always true at first.
6267
dc6c6455 6268 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6269 (interval_deletion_adjustment): Return unsigned value.
6270 All uses changed.
dc6c6455 6271
aba7731a
PE
6272 * process.c (list_processes_1, create_pty, read_process_output):
6273 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6274 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6275 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6276 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6277 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6278
fdfc4bf3
PE
6279 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6280
fca8fe46 6281 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6282 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6283
06a0259a 6284 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6285 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6286 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6287
e7b9e80f
PE
6288 * print.c (print_error_message): Avoid int overflow.
6289
56201685
PE
6290 * font.c (font_list_entities): Redo for clarity,
6291 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6292
78834453 6293 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6294 (font_score): Avoid potential overflow in diff calculation.
78834453 6295
0bc0b309 6296 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6297 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6298
e610eaca
PE
6299 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6300
b895abce
PE
6301 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6302 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6303 can always succeed if overflow has undefined behavior.
6304
1f1d9321 6305 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6306 (wordify): Omit three unnecessary tests.
1f1d9321 6307
c59478bc
PE
6308 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6309 All callers changed. This avoids the need for an unused var.
6310
79b73827
PE
6311 * casefiddle.c (casify_region): Remove var that is set but not used.
6312
a4db5dfe
PE
6313 * dired.c (file_name_completion): Remove var that is set but not used.
6314
43aae36e
PE
6315 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6316
2a47c44d 6317 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6318 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6319
a37c69bf
PE
6320 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6321 Check for integer overflow on size calculations.
6322
328ab8e7
PE
6323 * buffer.c (Fprevious_overlay_change): Remove var that is set
6324 but not used.
6325
e5a2a5cb
PE
6326 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6327 Remove vars that are set but not used.
8d84a6eb 6328 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6329 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6330
a60e5f68
PE
6331 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6332
f661cb61 6333 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6334 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6335
f0397f5a
PE
6336 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6337 that are set but not used.
6338
8664db06 6339 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6340 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6341
6abdaa4a
PE
6342 * xselect.c (x_get_local_selection, x_handle_property_notify):
6343 Remove vars that are set but not used.
6344
0ce7538d 6345 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6346 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6347
9ae848fc
PE
6348 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6349 Remove var that is set but not used.
0b918413
PE
6350 (scroll_bar_windows_size): Now size_t, not int.
6351 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6352 Check for overflow.
9ae848fc 6353
a5a62657
PE
6354 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6355 (map_tty_color) [!defined MSDOS]: Likewise.
6356
5c5cdd39
PE
6357 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6358
66ebf983
PE
6359 * coding.c: Remove vars that are set but not used.
6360 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6361 All callers changed.
6362 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6363 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6364 (decode_coding_charset): Remove vars that are set but not used.
6365
1be4d761
PE
6366 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6367 that is set but not used.
6368
47553fa8
PE
6369 * print.c (print_object): Remove var that is set but not used.
6370
1f7196bf 6371 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6372 The gnulib version avoids calling malloc in the usual case,
6373 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6374 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6375 * filelock.c (current_lock_owner): Likewise.
6376 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6377 * sysdep.c: Include allocator.h, careadlinkat.h.
6378 (emacs_no_realloc_allocator): New static constant.
6379 (emacs_readlink): New function.
fdb61804
PE
6380 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6381 ../lib/careadlinkat.h.
d1fdcab7 6382
f84c17c7
SM
63832011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6384
6385 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6386 first non-nil return value).
6387
ef3862ad
JD
63882011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6389
6390 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6391 if not defined (Bug#8403).
6392
376a7006
JB
63932011-04-02 Juanma Barranquero <lekktu@gmail.com>
6394
6395 * xdisp.c (display_count_lines): Remove parameter `start',
6396 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6397 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6398 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6399 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6400 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6401 and thereabouts. All callers changed.
6402 (get_per_char_metric): Remove parameter `f', unused since
6403 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6404
6ca3801d
JM
64052011-04-02 Jim Meyering <meyering@redhat.com>
6406
6407 do not dereference NULL upon failed strdup
6408 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6409 (ns_get_family): Likewise.
6410
d8e2b5ba
JB
64112011-04-02 Juanma Barranquero <lekktu@gmail.com>
6412
6413 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6414
8c74fcbd
JD
64152011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6416
6417 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6418 later (Bug#8403).
6419
7200d79c
SM
64202011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6421
03408648 6422 Add lexical binding.
7200d79c 6423
03408648
SM
6424 * window.c (Ftemp_output_buffer_show): New fun.
6425 (Fsave_window_excursion):
6426 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6427
6428 * lread.c (lisp_file_lexically_bound_p): New function.
6429 (Fload): Bind Qlexical_binding.
6430 (readevalloop): Remove `evalfun' arg.
6431 Bind Qinternal_interpreter_environment.
6432 (Feval_buffer): Bind Qlexical_binding.
6433 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6434 Mark as dynamic.
6435 (syms_of_lread): Declare `lexical-binding'.
6436
6437 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6438
6439 * keyboard.c (eval_dyn): New fun.
6440 (menu_item_eval_property): Use it.
ca105506
SM
6441
6442 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6443
03408648
SM
6444 * fns.c (concat, mapcar1): Accept byte-code-functions.
6445
6446 * eval.c (Fsetq): Handle lexical vars.
6447 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6448 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6449 (FletX, Flet): Obey lexical binding.
6450 (Fcommandp): Handle closures.
6451 (Feval): New `lexical' arg.
6452 (eval_sub): New function extracted from Feval. Use it almost
6453 everywhere where Feval was used. Look up vars in lexical env.
6454 Handle closures.
6455 (Ffunctionp): Move from subr.el.
6456 (Ffuncall): Handle closures.
6457 (apply_lambda): Remove `eval_flags'.
6458 (funcall_lambda): Handle closures and new byte-code-functions.
6459 (Fspecial_variable_p): New function.
6460 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6461 but without exporting it to Lisp.
23aba0ea 6462
23aba0ea 6463 * doc.c (Fdocumentation, store_function_docstring):
03408648 6464 * data.c (Finteractive_form): Handle closures.
23aba0ea 6465
03408648
SM
6466 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6467 interactive spec.
ba83908c 6468
04f2d78b
CB
6469 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6470 New byte-codes.
03408648
SM
6471 (exec_byte_code): New function extracted from Fbyte_code to handle new
6472 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6473
03408648 6474 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6475
03408648 6476 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6477
e2abce01
JB
64782011-03-31 Juanma Barranquero <lekktu@gmail.com>
6479
6480 * xdisp.c (redisplay_internal): Fix prototype.
6481
63696a73 64822011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6483
63696a73 6484 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6485 (try_scrolling): Use it when setting scroll_limit.
6486 Limit scrolling to 100 screen lines.
63696a73
EZ
6487 (redisplay_window): Even when falling back on "recentering",
6488 position point in the window according to scroll-conservatively,
6489 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6490
6491 (try_scrolling): When point is above the window, allow searching
6492 as far as scroll_max, or one screenful, to compute vertical
6493 distance from PT to the scroll margin position. This prevents
6494 try_scrolling from unnecessarily failing when
6495 scroll-conservatively is set to a value slightly larger than the
6496 window height. Clean up the case of PT below the margin at bottom
6497 of window: scroll_max can no longer be INT_MAX. When aggressive
6498 scrolling is in use, don't let point enter the opposite scroll
6499 margin as result of the scroll.
6500 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6501 threshold of 100 lines for never-recentering scrolling.
6502
e4cc2dfc
JB
65032011-03-31 Juanma Barranquero <lekktu@gmail.com>
6504
6505 * dispextern.h (move_it_by_lines):
6506 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6507 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6508 (message_log_check_duplicate): Remove parameters `prev_bol' and
6509 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6510 (redisplay_internal): Remove parameter `preserve_echo_area',
6511 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6512
6513 * indent.c (Fvertical_motion):
6514 * window.c (window_scroll_pixel_based, Frecenter):
6515 Don't pass `need_y_p' to `move_it_by_lines'.
6516
1c470562
SM
65172011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6518
44f230aa
SM
6519 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6520 steal a few bits to be more compact.
6521 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6522 Remove unneeded casts.
6523
1c470562
SM
6524 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6525
888adce9
ZK
65262011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6527
6528 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6529 binding" message (bug#7967).
6530
f838ed7b
PE
65312011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6532
77861b95
PE
6533 Fix more problems found by GCC 4.6.0's static checks.
6534
de6dbc14
PE
6535 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6536 Remove unused local var.
6537
f838ed7b
PE
6538 * editfns.c (Fmessage_box): Remove unused local var.
6539
792c7b2b
PE
6540 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6541 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6542 Omit unused local vars.
c499e557 6543 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6544 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6545 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6546 Omit unused local var.
6547
ba0165e1
PE
6548 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6549 Don't assume string length fits in int.
32ad8845 6550 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6551 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6552
3c59b4c9
PE
6553 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6554 instead of alloca (Bug#8344).
6555
a3eed478 6556 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6557 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6558
eb4d412d
PE
6559 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6560
1658b401
PE
6561 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6562 concerns.
6563
6564 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6565
6566 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6567
9a2c6e05
PE
6568 * keyboard.c (syms_of_keyboard): Use the same style as later
6569 in this function when indexing through an array. This also
6570 works around GCC bug 48267.
6571
03d0a109
PE
6572 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6573
44f730c8
PE
6574 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6575
fe75f926
PE
6576 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6577 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6578
ffa8c828
PE
6579 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6580 This avoids undefined behavior on integer overflow, and is a bit
6581 more convenient anyway since it is compared to a size_t variable.
6582
c5101a77
PE
6583 Variadic C functions now count arguments with size_t, not int.
6584 This avoids an unnecessary limitation on 64-bit machines, which
6585 caused (substring ...) to crash on large vectors (Bug#8344).
6586 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6587 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6588 All variadic functions and their callers changed accordingly.
c5101a77
PE
6589 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6590 * data.c (arith_driver, float_arith_driver): Likewise.
6591 * editfns.c (general_insert_function): Likewise.
6592 * eval.c (struct backtrace.nargs, interactive_p)
6593 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6594 (funcall_lambda, mark_backtrace): Likewise.
6595 * fns.c (concat): Likewise.
6596 * frame.c (x_set_frame_parameters): Likewise.
6597 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6598 0 if not found, not -1. All callers changed.
6599
dd3f25f7
PE
6600 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6601 (stack_copy_size): Now size_t, not int.
6602 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6603
461c2ab9
JB
66042011-03-28 Juanma Barranquero <lekktu@gmail.com>
6605
6606 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6607 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6608 All callers changed.
6609
6610 * lisp.h (multibyte_char_to_unibyte):
6611 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6612 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6613 * character.h (CHAR_TO_BYTE8):
6614 * cmds.c (internal_self_insert):
6615 * editfns.c (general_insert_function):
6616 * keymap.c (push_key_description):
6617 * search.c (Freplace_match):
6618 * xdisp.c (message_dolog, set_message_1): All callers changed.
6619
f6d62986
SM
66202011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6621
6622 * keyboard.c (safe_run_hook_funcall): New function.
6623 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6624 don't set the hook to nil, but remove the offending function instead.
6625 (Qcommand_hook_internal): Remove, unused.
6626 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6627 Vcommand_hook_internal.
6628
6629 * eval.c (enum run_hooks_condition): Remove.
6630 (funcall_nil, funcall_not): New functions.
6631 (run_hook_with_args): Call each function through a `funcall' argument.
6632 Remove `cond' argument, now redundant.
6633 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6634 (Frun_hook_with_args_until_failure): Adjust accordingly.
6635 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6636
1db5b1ad
JB
66372011-03-28 Juanma Barranquero <lekktu@gmail.com>
6638
6639 * dispextern.h (string_buffer_position): Remove declaration.
6640
6641 * print.c (strout): Remove parameter `multibyte', unused since
6642 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6643
6644 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6645 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6646 All callers changed.
6647
6648 * w32.c (_wsa_errlist): Use braces for struct initializers.
6649
6650 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6651 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6652 All callers changed.
6653 (string_buffer_position): Likewise. Also, make static (it's never
6654 used outside xdisp.c).
6655 (cursor_row_p): Remove parameter `w', unused since
6656 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6657 (decode_mode_spec): Remove parameter `precision', introduced during
6658 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6659 All callers changed.
6660
5ffb62aa
JD
66612011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6662
6663 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6664
461c2ab9 66652011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6666
6667 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6668 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6669 (ns_update_auto_hide_menu_bar): New functions.
6670 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6671 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6672 ns_constrain_all_frames.
6673 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6674 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6675
5c380ffb
JD
66762011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6677
6678 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6679
9af30bdf
GM
66802011-03-27 Glenn Morris <rgm@gnu.org>
6681
6682 * syssignal.h: Replace RETSIGTYPE with void.
6683 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6684 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6685 Replace SIGTYPE with void everywhere.
6686 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6687 * s/template.h (SIGTYPE): Remove commented out definition.
6688
e2abce01
JB
66892011-03-26 Eli Zaretskii <eliz@gnu.org>
6690
6691 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6692 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6693
f868cd8a
JB
66942011-03-26 Juanma Barranquero <lekktu@gmail.com>
6695
59eb0929
JB
6696 * w32.c (read_unc_volume): Use parameter `henum', instead of
6697 global variable `wget_enum_handle'.
6698
6699 * keymap.c (describe_vector): Remove parameters `indices' and
6700 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6701 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6702
f868cd8a
JB
6703 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6704
6705 * keyboard.c (timer_check): Remove parameter `do_it_now',
6706 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6707 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6708 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6709
6710 * keyboard.c (read_char):
6711 * w32menu.c (w32_menu_display_help):
6712 * xmenu.c (show_help_event, menu_help_callback):
6713 Adjust calls to `show_help_echo'.
6714
6715 * gtkutil.c (xg_maybe_add_timer):
6716 * keyboard.c (readable_events):
6717 * process.c (wait_reading_process_output):
6718 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6719
6720 * insdel.c (adjust_markers_gap_motion):
6721 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6722 (gap_left, gap_right): Don't call it.
6723
2ecf6fdb
CY
67242011-03-25 Chong Yidong <cyd@stupidchicken.com>
6725
6726 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6727 incurred during fontification.
6728
6b1f9ba4
JB
67292011-03-25 Juanma Barranquero <lekktu@gmail.com>
6730
6731 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6732 (DEFVAR_PER_BUFFER): Don't pass it.
6733
6734 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6735 (scrolling_window): Don't pass it.
6736
0f4a96b5
JB
67372011-03-25 Juanma Barranquero <lekktu@gmail.com>
6738
6739 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6740
6741 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6742 and `suffix'.
6743 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6744 of variables specific to SELinux and computation of `encoded_absname'.
6745
6746 * image.c (XPutPixel): Remove unused variable `height'.
6747
6748 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6749
6750 * unexw32.c (get_section_info): Remove unused variable `section'.
6751
6752 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6753 (system_process_attributes): Remove unused variable `sess'.
6754 (sys_read): Remove unused variable `err'.
6755
6756 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6757 (w32_wnd_proc): Remove unused variable `isdead'.
6758 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6759 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6760 (x_create_tip_frame): Remove unused variable `tem'.
6761
6762 * w32inevt.c (w32_console_read_socket):
6763 Remove unused variable `no_events'.
6764
6765 * w32term.c (x_draw_composite_glyph_string_foreground):
6766 Remove unused variable `width'.
6767
1149507c
JB
67682011-03-24 Juanma Barranquero <lekktu@gmail.com>
6769
6770 * w32term.c (x_set_glyph_string_clipping):
6771 Don't pass uninitialized region to CombineRgn.
6772
9c88f339
JB
67732011-03-23 Juanma Barranquero <lekktu@gmail.com>
6774
6775 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6776 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6777 (Fx_close_connection): Remove unused variable `i'.
6778
6779 * w32font.c (w32font_draw): Return number of glyphs.
6780 (w32font_open_internal): Remove unused variable `i'.
6781 (w32font_driver): Add missing initializer.
6782
6783 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6784 (fill_in_menu): Remove unused variable `items_added'.
6785
6786 * w32term.c (last_mouse_press_frame): Remove static global variable.
6787 (w32_clip_to_row): Remove unused variable `f'.
6788 (x_delete_terminal): Remove unused variable `i'.
6789
6790 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6791 (NOTHING): Remove unused static global variable.
6792 (uniscribe_check_otf): Remove unused variable `table'.
6793 (uniscribe_font_driver): Add missing initializers.
6794
dee091a3
JD
67952011-03-23 Julien Danjou <julien@danjou.info>
6796
6797 * term.c (Fsuspend_tty, Fresume_tty):
6798 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6799 * window.c (temp_output_buffer_show):
6800 * insdel.c (signal_before_change):
6801 * frame.c (Fhandle_switch_frame):
6802 * fileio.c (Fdo_auto_save):
6803 * emacs.c (Fkill_emacs):
6804 * editfns.c (save_excursion_restore):
6805 * cmds.c (internal_self_insert):
6806 * callint.c (Fcall_interactively):
6807 * buffer.c (Fkill_all_local_variables):
6808 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6809 Use Frun_hooks.
0f4a96b5 6810 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6811 unconditionnaly since it does the check itself.
6812
2c520ab5 68132011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6814
c9c49752
PE
6815 Fix more problems found by GCC 4.5.2's static checks.
6816
8abc3f12
PE
6817 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6818 the first time through the loop, since we know p0 < p1 then.
6819 This also avoids a gcc -Wstrict-overflow warning.
6820
a2d26660
PE
6821 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6822 leading to a memory leak, possible in functions like
6823 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6824 of objects (Bug#8318).
a2d26660 6825
916c72e9
PE
6826 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6827 that could (at least in theory) be that large.
6828
19ab8a18
PE
6829 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6830 This is less likely to overflow, and avoids undefined behavior if
6831 overflow does occur. All callers changed. Use strtoul to scan
6832 for the unsigned long integer.
b7cbbd6f
PE
6833 (pint2hrstr): Simplify and tune code slightly.
6834 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6835
f0641eff
PE
6836 * scroll.c (do_scrolling): Work around GCC bug 48228.
6837 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6838
7f650bb9
PE
6839 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6840 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6841 (validate_x_resource_name): Simplify count usage.
6842 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6843
37dd57d1
PE
6844 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6845 fail (Bug#8306).
81e56e61 6846
699979fc 6847 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6848
401bf9b4
PE
6849 * process.c (Fmake_network_process): Use socklen_t, not int,
6850 where POSIX says socklen_t is required in portable programs.
6851 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6852 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6853 (Fmake_network_process, server_accept_connection):
6854 (wait_reading_process_output, read_process_output):
6855 Likewise.
6856
b93aacde
PE
6857 * process.c: Rename or move locals to avoid shadowing.
6858 (list_processes_1, Fmake_network_process):
6859 (read_process_output_error_handler, exec_sentinel_error_handler):
6860 Rename or move locals.
4dc343ee 6861 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6862 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6863 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6864 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6865 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6866
af8a867c 6867 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6868 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6869 Include tparam.h instead, since it declares them.
af8a867c
PE
6870 * cm.h (PC): Remove extern decl; tparam.h now does this.
6871 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6872 * terminfo.c: Include tparam.h, to check interfaces.
6873 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6874 (tparam): Adjust signature to match interface in tparam.h;
6875 this removes some undefined behavior. Check that outstring and len
6876 are zero, which they always are with Emacs.
6877 * tparam.h (PC, BC, UP): New extern decls.
6878
0248044d 6879 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6880 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6881
8ff096c1 6882 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6883 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6884 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6885 (ftfont_list): Remove unused local.
49eaafba
PE
6886 (get_adstyle_property, ftfont_pattern_entity):
6887 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6888 Rename locals to avoid shadowing.
8ff096c1 6889
e2be39f6
PE
6890 * xfont.c (xfont_list_family): Mark var as initialized.
6891
c9735e30
PE
6892 * xml.c (make_dom): Now static.
6893
8f5201ae
PE
6894 * composite.c (composition_compute_stop_pos): Rename local to
6895 avoid shadowing.
b246f932
PE
6896 (composition_reseat_it): Remove unused locals.
6897 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6898 (composition_update_it): Mark var as initialized.
11b61122
PE
6899 (find_automatic_composition): Mark vars as initialized,
6900 with a FIXME (Bug#8290).
8f5201ae 6901
760fbc2c
PE
6902 character.h: Rename locals to avoid shadowing.
6903 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6904 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6905 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6906 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6907 to avoid shadowing.
6908
ff08eb85
PE
6909 * textprop.c (property_change_between_p): Remove; unused.
6910
fc7bf025
PE
6911 * intervals.c (interval_start_pos): Now static.
6912
235d7abc
PE
6913 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6914
44f230aa
SM
6915 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6916 Rename locals to avoid shadowing.
3e7d6594 6917
50060332
PE
6918 * sound.c (wav_play, au_play, Fplay_sound_internal):
6919 Fix pointer signedness.
d01f234b 6920 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6921 (wav_play): Initialize a variable to 0, to prevent undefined
6922 behavior (Bug#8278).
50060332 6923
c4fc4e30
PE
6924 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6925
918436ed
PE
6926 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6927
c939f91b
PE
6928 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6929 clobbering (Bug#8298).
b9c7f648
PE
6930 * sysdep.c (sys_subshell): Likewise.
6931 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6932
6bd8c144
PE
6933 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6934 This should get cleaned up, so that child_setup has the
6935 same signature on all platforms.
6936
7710357c 6937 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6938 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6939
c59da222
CY
69402011-03-22 Chong Yidong <cyd@stupidchicken.com>
6941
6942 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6943 not to be necessary, and produces flickering.
6944
66b87493
GM
69452011-03-20 Glenn Morris <rgm@gnu.org>
6946
6947 * config.in: Remove file.
6948
45b6f6d5
JB
69492011-03-20 Juanma Barranquero <lekktu@gmail.com>
6950
6951 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6952 are now in src/globals.h.
6953 (syms_of_minibuf): Remove spurious & from previous change.
6954
3ec03f7e
LL
69552011-03-20 Leo <sdl.web@gmail.com>
6956
6957 * minibuf.c (completing-read-function): New variable.
6958 (completing-read-default): Rename from completing-read.
6959 (completing-read): Call completing-read-function.
6960
b14e3e21
CY
69612011-03-19 Juanma Barranquero <lekktu@gmail.com>
6962
6963 * xfaces.c (Fx_load_color_file):
6964 Read color file from absolute filename (bug#8250).
6965
f2b726e6
JB
69662011-03-19 Juanma Barranquero <lekktu@gmail.com>
6967
6968 * makefile.w32-in: Update dependencies.
6969
09f6ff02
EZ
69702011-03-17 Eli Zaretskii <eliz@gnu.org>
6971
6972 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6973
29a6015a
PE
69742011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6975
a3a6c54e
PE
6976 Fix more problems found by GCC 4.5.2's static checks.
6977
b766f867
PE
6978 * process.c (make_serial_process_unwind, send_process_trap):
6979 (sigchld_handler): Now static.
6980
be02381c
PE
6981 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6982 That way, the code declares only the vars that it needs.
6983 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6984 * s/cygwin.h (PTY_ITERATION): Likewise.
6985 * s/darwin.h (PTY_ITERATION): Likewise.
6986 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6987
57048744
PE
6988 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6989 * process.c (allocate_pty): Don't declare stb unless it's needed.
6990
7914961c 6991 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6992 (CONSTANTLIM): Remove; unused.
6993 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6994 Define only if needed.
7914961c 6995
b3967b18
PE
6996 * unexelf.c (unexec): Name an expression,
6997 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6998 Use a different way to cause a compilation error if anyone uses
6999 n rather than nn, a way that does not involve shadowing.
73366a00 7000 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7001
29a6015a
PE
7002 * deps.mk (unexalpha.o): Remove; unused.
7003
43cfc33e 7004 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7005 * unexec.h: New file.
ce701a33
PE
7006 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7007 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7008 Depend on unexec.h.
7009 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7010 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7011 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7012 Change as necessary to match prototype in unexec.h.
ce701a33 7013
01f44d5a
PE
7014 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7015 shadowing.
4f63c6bb 7016 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7017
a6670b0b
PE
7018 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7019 Rename locals to avoid shadowing.
7020
cef2010d 7021 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7022 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7023
d4d7173a
PE
7024 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7025
f08b802a
PE
7026 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7027 warning when compiling print.c.
7028
3ddb0639
PE
7029 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7030 instead of using an uninitialized var.
5ad03b97 7031 (font_sort_entities): Mark var as initialized.
3ddb0639 7032
170a2692
PE
7033 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7034
e663c700
PE
7035 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7036 pointers to constants.
89bc529a 7037 (font_parse_fcname): Remove unused vars.
7b81e2d0 7038 (font_delete_unmatched): Now static.
ea838e10 7039 (font_get_spec): Remove; unused.
13a547c6
PE
7040 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7041 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7042 Rename or move locals to avoid shadowing.
e663c700 7043
2a80c887 7044 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7045 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7046
1384fa33 7047 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7048 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7049
8b2c52e9
PE
7050 * alloc.c (mark_backtrace): Move decl from here ...
7051 * lisp.h: ... to here, so that it can be checked.
7052
475545b5 7053 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7054 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7055 (lisp_indirect_variable): Name an expression,
7056 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7057 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7058
b1349114 7059 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7060 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7061 Use const pointer when appropriate.
b1349114 7062
a2928364
PE
7063 * lisp.h (get_system_name, get_operating_system_release):
7064 Move decls here, to check interfaces.
7065 * process.c (get_operating_system_release): Move decl to lisp.h.
7066 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7067 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7068 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7069 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7070 (Fformat_time_string, Fencode_time, Finsert_char):
7071 (Ftranslate_region_internal, Fformat):
7072 Rename or remove local vars to avoid shadowing.
9710023e 7073 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7074
a415e694
PE
7075 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7076 avoid shadowing.
7077
8ef4622d
PE
7078 * lisp.h (eassert): Check that the argument compiles, even if
7079 ENABLE_CHECKING is not defined.
7080
946f9a5b
PE
7081 * data.c (Findirect_variable): Name an expression, to avoid
7082 gcc -Wbad-function-cast warning.
112396d6 7083 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7084 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7085 (Fmake_variable_buffer_local, Fmake_local_variable):
7086 Mark variables as initialized.
52746918 7087 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7088
e5aab7e7 7089 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7090 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7091 Rename locals to avoid shadowing.
dff45157
PE
7092 (mark_stack): Move local variables into the #ifdef region where
7093 they're used.
7bc26fdb
PE
7094 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7095 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7096 needed otherwise.
7097 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7098 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7099 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7100
e5aab7e7
PE
7101 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7102 avoids undefined behavior in theory.
7103
4da60324
PE
7104 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7105
88043301
PE
7106 Use functions, not macros, for up- and down-casing (Bug#8254).
7107 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7108 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7109 to use the following functions instead of these macros.
7110 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7111 EMACS_INT, since callers assume the returned value fits in int.
7112 (upcase1): Likewise, for UPCASE_TABLE.
7113 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7114 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7115 the race-condition problem in the old DOWNCASE.
88043301 7116
19ed5445
PE
7117 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7118 Rename locals to avoid shadowing.
7119 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7120 (regex_compile, re_search_2, re_match_2_internal):
7121 Remove unused local vars.
952db0d7
PE
7122 (FREE_VAR): Rewrite so as not to use empty "else",
7123 which gcc can warn about.
da053e48 7124 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7125 (RETALLOC_IF): Define only if needed.
7126 (WORDCHAR_P): Likewise. This one is never needed, but is used
7127 only in a comment talking about a compiler bug, so put inside
7128 the #if 0 of that comment.
7129 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7130 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7131 Remove; unused.
19ed5445 7132
1f3561e4 7133 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7134 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7135 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7136
ded6f8f7
PE
7137 * search.c (simple_search): Remove unused var.
7138
dbd37a95
PE
7139 * dired.c (compile_pattern): Move decl from here ...
7140 * lisp.h: ... to here, so that it can be checked.
7141 (struct re_registers): New forward decl.
7142
7e47afad
PE
7143 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7144
85f24f61
PE
7145 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7146 All uses changed.
7147 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7148 Rename locals to avoid shadowing.
5671df8f 7149 (Fvertical_motion): Mark locals as initialized.
85f24f61 7150
181aa2be 7151 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7152 (casify_region): Mark local as initialized.
181aa2be 7153
930d429c
PE
7154 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7155
7082eac6
PE
7156 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7157 New macros, so that the caller can use some names other than
7158 gcpro1, gcpro2, etc.
7159 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7160 of the new macros.
7161 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7162 argument, for consistency with GCPRO2_VAR, etc: it is now the
7163 prefix of the variable, not the variable itself. All uses
7164 changed.
38b2c076
PE
7165 * dired.c (directory_files_internal, file_name_completion):
7166 Rename locals to avoid shadowing.
7167
15206ed9
PE
7168 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7169 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7170 dired.c's scmp function, had undefined behavior.
7171 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7172 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7173 * buffer.h: ... to here, because these macros use current_buffer,
7174 and the new implementation with inline functions needs to have
7175 current_buffer in scope now, rather than later when the macros
7176 are used.
7177 (downcase, upcase1): New static inline functions.
7178 (DOWNCASE, UPCASE1): Reimplement using these functions.
7179 This avoids undefined behavior in expressions like
7180 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7181 from race conditions in accessing the global variables
7182 case_temp1 and case_temp2.
7183 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7184 * lisp.h (case_temp1, case_temp2): Remove their decls.
7185 * character.h (ASCII_CHAR_P): Move from here ...
7186 * lisp.h: ... to here, so that the inline functions mentioned
7187 above can use them.
7188
4a6bea26
PE
7189 * dired.c (directory_files_internal_unwind): Now static.
7190
f14b7e14
PE
7191 * fileio.c (file_name_as_directory, directory_file_name):
7192 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7193 Now static.
2893f146
PE
7194 (file_name_as_directory): Use const pointers when appropriate.
7195 (Fexpand_file_name): Likewise. In particular, newdir might
7196 point at constant storage, so make it a const pointer.
fd4ead52 7197 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7198 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7199 signedness issues.
f839df0c
PE
7200 (Fset_file_times, Finsert_file_contents, auto_save_error):
7201 Rename locals to avoid shadowing.
f14b7e14 7202
5716756e 7203 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7204 (Ftry_completion, Fall_completions): Rename or remove locals
7205 to avoid shadowing.
5716756e 7206
b4c3046a
PE
7207 * marker.c (bytepos_to_charpos): Remove; unused.
7208
b45db522
PE
7209 * lisp.h (verify_bytepos, count_markers): New decls,
7210 so that gcc does not warn that these functions aren't declared.
7211
85876d07
PE
7212 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7213 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7214 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7215 (copy_text): Remove unused local var.
85876d07 7216
03d78a21 7217 * filelock.c (within_one_second): Now static.
b3dd38ab 7218 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7219
5df8f01b
PE
7220 * buffer.c (fix_overlays_before): Mark locals as initialized.
7221 (fix_start_end_in_overlays): Likewise. This function should be
7222 simplified by using pointers-to-pointers, but that's a different
7223 matter.
b1d876f1 7224 (switch_to_buffer_1): Now static.
8f54f30a
PE
7225 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7226 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7227
a70072c9 7228 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7229 Fix pointer signedness issue.
edced198
PE
7230 (sys_subshell): Mark local as volatile if checking for lint,
7231 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7232 (MAXPATHLEN): Define only if needed.
a70072c9 7233
a0977c44
PE
7234 * process.c (serial_open, serial_configure): Move decls from here ...
7235 * systty.h: ... to here, so that they can be checked.
7236
a884fdcc
PE
7237 * fns.c (get_random, seed_random): Move extern decls from here ...
7238 * lisp.h: ... to here, so that they can be checked.
7239
604efe86 7240 * sysdep.c (reset_io): Now static.
b8950c94 7241 (wait_for_termination_signal): Remove; unused.
604efe86 7242
38fc62d9
PE
7243 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7244 (copy_keymap_item, append_key, push_text_char_description):
7245 Now static.
1004a21a 7246 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7247 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7248 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7249 (describe_map_tree):
7250 Rename locals to avoid shadowing.
38fc62d9 7251
2f2650da
PE
7252 * keyboard.c: Declare functions static if they are not used elsewhere.
7253 (echo_char, echo_dash, cmd_error, top_level_2):
7254 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7255 (read_char, kbd_buffer_get_event, make_lispy_position):
7256 (make_lispy_event, make_lispy_movement, apply_modifiers):
7257 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7258 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7259 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7260 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7261 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7262
a053e86c 7263 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7264 (mark_kboards): Move decl here ...
7265 * alloc.c (mark_kboards): ... from here.
a053e86c 7266
4752793e
PE
7267 * lisp.h (force_auto_save_soon): New decl.
7268
74f10ca7 7269 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7270 (DEFINE_DUMMY_FUNCTION): New macro.
7271 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7272 Use it.
c03cd23f
PE
7273 (main): Add casts to avoid warnings
7274 if GCC considers string literals to be constants.
74f10ca7 7275
022e70d4
PE
7276 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7277
59d6fe83
PE
7278 * dbusbind.c: Pointer signedness fixes.
7279 (xd_signature, xd_append_arg, xd_initialize):
7280 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7281 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7282 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7283 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7284
78320123
PE
7285 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7286 if GCC considers string literals to be constants.
49cebcca 7287 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7288
35ac2a97
SM
72892011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7290
fb103ca9
SM
7291 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7292 (print_preprocess, print_object): New macro to fix last change.
7293
35ac2a97
SM
7294 * print.c (print_preprocess): Don't forget font objects.
7295
62973b41
JB
72962011-03-16 Juanma Barranquero <lekktu@gmail.com>
7297
7298 * emacs.c (USAGE3): Doc fixes.
7299
0e48bb22
AS
73002011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7301
7302 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7303 structure.
7304
7684e57b
JB
73052011-03-14 Juanma Barranquero <lekktu@gmail.com>
7306
7307 * lisp.h (VWindow_system, Qfile_name_history):
7308 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7309 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7310 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7311
7312 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7313 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7314
7315 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7316 * w32console.c (detect_input_pending, read_input_pending)
7317 (encode_terminal_code):
7318 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7319 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7320 (w32_system_caret_y, Qfile_name_history):
7321 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7322 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7323 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7324 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7325 * w32proc.c (Qlocal, report_file_error):
7326 * w32term.c (Vwindow_system, updating_frame):
7327 * w32uniscribe.c (initialized, uniscribe_font_driver):
7328 Remove unneeded extern declarations.
7329
2aa46d6c
CY
73302011-03-14 Chong Yidong <cyd@stupidchicken.com>
7331
c96bbc66 7332 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7333
cffc6f3b
CY
73342011-03-13 Chong Yidong <cyd@stupidchicken.com>
7335
7336 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7337 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7338 These macros can no longer be used for assignment.
7339
44f230aa
SM
7340 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7341 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7342 (record_buffer_markers, fetch_buffer_markers): New functions for
7343 recording and fetching special buffer markers.
7344 (set_buffer_internal_1, set_buffer_temp): Use them.
7345
7346 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7347
7348 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7349
7350 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7351 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7352
7353 * xdisp.c (hscroll_window_tree):
7354 (reconsider_clip_changes): Use PT instead of BUF_PT.
7355
d251f04b
EZ
73562011-03-13 Eli Zaretskii <eliz@gnu.org>
7357
7358 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7359 $(EMACS_ROOT)/lib/intprops.h.
7360
f0c77cd1
PE
73612011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7362
3eca4629
PE
7363 Fix more problems found by GCC 4.5.2's static checks.
7364
7c86ee98
PE
7365 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7366 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7367 (xg_free_frame_widgets): Make it clear that a local variable is
7368 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7369 (gdk_window_get_screen): Make it clear that this macro is needed
7370 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7371 (int_gtk_range_get_value): New function, which avoids a diagnostic
7372 from gcc -Wbad-function-cast.
7373 (xg_set_toolkit_scroll_bar_thumb): Use it.
7374 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7375 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7376 (get_utf8_string, xg_get_file_with_chooser):
7377 Rename locals to avoid shadowing.
7378 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7379
41729b81
PE
7380 * xgselect.c (xg_select): Remove unused var.
7381
f0c77cd1
PE
7382 * image.c (four_corners_best): Mark locals as initialized.
7383 (gif_load): Initialize transparent_p to zero (Bug#8238).
7384 Mark another local as initialized.
ec6cf4c6 7385 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7386
ce0ad53d 7387 * image.c (clear_image_cache): Now static.
d5d5a617 7388 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7389 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7390 (x_edge_detection): Remove unnecessary cast that
7391 gcc -Wbad-function-cast diagnoses.
2037898d 7392 (gif_load): Fix pointer signedness.
6ae141d6
PE
7393 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7394 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7395
33383987 73962011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7397
d32df629
PE
7398 Improve quality of tests for time stamp overflow.
7399 For example, without this patch (encode-time 0 0 0 1 1
7400 1152921504606846976) returns the obviously-bogus value (-948597
7401 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7402 reports time overflow. See
7403 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7404 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7405 * editfns.c: Include limits.h and intprops.h.
7406 (TIME_T_MIN, TIME_T_MAX): New macros.
7407 (time_overflow): Move earlier, to before first use.
7408 (hi_time, lo_time): New functions, for an accurate test for
7409 out-of-range times.
7410 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7411 (Fget_internal_run_time): Don't assume time_t fits in int.
7412 (make_time): Use list2 instead of Fcons twice.
7413 (Fdecode_time): More accurate test for out-of-range times.
7414 (check_tm_member): New function.
7415 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7416 (lisp_time_argument): Don't rely on undefined left-shift and
7417 right-shift behavior when checking for time stamp overflow.
8be6f318 7418
fe31d94c
PE
7419 * editfns.c (time_overflow): New function, refactoring common code.
7420 (Fformat_time_string, Fdecode_time, Fencode_time):
7421 (Fcurrent_time_string): Use it.
7422
8be6f318
PE
7423 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7424 * dired.c (make_time): Move to ...
7425 * editfns.c (make_time): ... here.
7426 * systime.h: Note the move.
7427
09d9db2c 74282011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7429
126bc0dc
YM
7430 * fringe.c (update_window_fringes): Remove unused variables.
7431
c47cbdfd
YM
7432 * unexmacosx.c (copy_data_segment): Also copy __got section.
7433 (Bug#8223)
7434
7ac80be9
EZ
74352011-03-12 Eli Zaretskii <eliz@gnu.org>
7436
c96bbc66 7437 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7438 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7439 Constify `char *' arguments and their references according to
7440 prototypes in tparam.h.
7441
ecb0f94d 7442 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7443
7ac80be9
EZ
7444 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7445 Adapt all references accordingly.
7446
7447 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7448
ef1fd07e
TT
74492011-03-11 Tom Tromey <tromey@redhat.com>
7450
7451 * buffer.c (syms_of_buffer): Remove obsolete comment.
7452
7ef4b50c
EZ
74532011-03-11 Eli Zaretskii <eliz@gnu.org>
7454
7455 * termhooks.h (encode_terminal_code): Declare prototype.
7456
7457 * msdos.c (encode_terminal_code): Don't declare prototype.
7458
7459 * term.c (encode_terminal_code): Now external again, used by
7460 w32console.c and msdos.c.
7461
44f230aa
SM
7462 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7463 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7464
4b1ec863 74652011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7466
1714f52b 7467 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7468
4b1ec863
PE
7469 * fringe.c (update_window_fringes): Mark locals as initialized
7470 (Bug#8227).
7471 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7472
524c7aa6
PE
7473 * alloc.c (mark_fringe_data): Move decl from here ...
7474 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7475 to check its interface.
7476 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7477
a5c0af81 7478 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7479 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7480 (fontset_font): Mark local as initialized.
a9a06e0b 7481 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7482
b4716021
PE
7483 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7484
811e9bac 7485 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7486 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7487 (x_own_selection, Fx_disown_selection_internal): Rename locals
7488 to avoid shadowing.
7489 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7490
7e3ab302
PE
7491 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7492 so that the caller can use some name other than gcpro1.
7493 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7494 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7495 (Fx_backspace_delete_keys_p):
7496 Use them to avoid shadowing, and rename vars to avoid shadowing.
7497 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7498 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7499 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7500 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7501 Remove unused locals.
7e3ab302
PE
7502 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7503 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7504 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7505 macros.
f78faa98 7506
e2b13473
PE
7507 * xterm.h (x_mouse_leave): New decl.
7508
77f23912
PE
7509 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7510 Remove unused functions.
cdf4ba58
PE
7511 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7512 (x_calc_absolute_position): Now static.
7411c686 7513 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7514 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7515 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7516 unless they are used.
38d0b34a
PE
7517 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7518 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7519 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7520 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7521 (x_error_catcher, x_connection_closed, x_error_handler):
7522 (x_error_quitter, xembed_send_message, x_iconify_frame):
7523 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7524 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7525 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7526
44f230aa
SM
7527 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7528 Rename or move locals to avoid shadowing.
6b463e58 7529 (tty_defined_color, merge_face_heights): Now static.
5967d051 7530 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7531 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7532 does not deduce is never used uninitialized.
73719eba
PE
7533 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7534 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7535
426994c3 7536 * terminal.c (store_terminal_param): Now static.
5489860b 7537
032f1620 7538 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7539 (set_frame_menubar): Remove unused local.
d4323972 7540 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7541 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7542 since they might point to immutable storage.
281585b0
PE
7543 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7544 since it's unused otherwise.
032f1620 7545
367c19e5 7546 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7547 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7548 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7549 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7550 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7551 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7552 does not deduce are never used uninitialized.
70739cbe 7553
07b48fa9
PE
7554 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7555
8868a238 7556 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7557 * window.c (window_loop, size_window):
7558 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7559
7e5cf297 7560 * window.c (display_buffer): Now static.
d6550a9f
PE
7561 (size_window): Mark variables that gcc -Wuninitialized
7562 does not deduce are never used uninitialized.
a586633d
PE
7563 * window.h (check_all_windows): New decl, to forestall
7564 gcc -Wmissing-prototypes diagnostic.
5b555da1 7565 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7566
f6095868
PE
7567 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7568 shadowing.
7569 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7570 Include <limits.h>.
7571 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7572 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7573 (load_charset_map): Mark variables that gcc -Wuninitialized
7574 does not deduce are never used uninitialized.
53df7c11 7575 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7576
f38b440c
PE
7577 * coding.c (coding_set_source, coding_set_destination):
7578 Use "else { /* comment */ }" rather than "else /* comment */;"
7579 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7580 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7581 a block, when the outer 'i' will do.
7582 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7583 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7584 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7585 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7586 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7587 Rename locals to avoid shadowing.
7588 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7589 * coding.c (emacs_mule_char, encode_invocation_designation):
7590 Now static, since they're not used elsewhere.
413bb2db 7591 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7592 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7593 (decode_coding_emacs_mule): Mark variables that gcc
7594 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7595 (detect_coding_iso_2022): Initialize a local variable that might
7596 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7597 this initialization is needed. (Bug#8211)
5f58e762
PE
7598 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7599 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7600 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7601 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7602 Remove unused macros.
f38b440c 7603
232b38b9 7604 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7605 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7606 * character.c (string_count_byte8): Likewise.
232b38b9 7607
fb90da1b
PE
7608 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7609 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7610
fb93dbc2
PE
7611 * chartab.c (copy_sub_char_table): Now static, since it's not used
7612 elsewhere.
5c156ace
PE
7613 (sub_char_table_ref_and_range, char_table_ref_and_range):
7614 Rename locals to avoid shadowing.
bbcd0949 7615 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7616
7d3b3862 7617 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7618 (BIDI_BOB): Remove unused macro.
7d3b3862 7619
6be7d3da
PE
7620 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7621 deduce are never used uninitialized.
c2ed9c8b 7622 * term.c (encode_terminal_code): Likewise.
6be7d3da 7623
75f8807f 7624 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7625
50938595
PE
7626 * tparam.h: New file.
7627 * term.c, tparam.h: Include it.
7628 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7629 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7630 Move these decls to tparam.h, and make them agree with what
7631 is actually in tparam.c. The previous trick of using incompatible
7632 decls in different modules does not conform to the C standard.
7633 All callers of tparam changed to use tparam's actual API.
7634 * tparam.c (tparam1, tparam, tgoto):
7635 Use const pointers where appropriate.
7636
fbceeba2
PE
7637 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7638 * cm.h (struct cm): Likewise.
7639 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7640 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7641 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7642 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7643 (turn_on_face, init_tty): Likewise.
7644 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7645
7f3f1250
PE
7646 * term.c (term_mouse_position): Rename local to avoid shadowing.
7647
e6ca6543
PE
7648 * alloc.c (mark_ttys): Move decl from here ...
7649 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7650
c40f8d15
AS
76512011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7652
7653 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7654
cfe0661d
JB
76552011-03-09 Juanma Barranquero <lekktu@gmail.com>
7656
7657 * search.c (compile_pattern_1): Remove argument regp, unused since
7658 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7659 (compile_pattern): Don't pass it.
7660
0afb4571
J
76612011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7662
7663 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7664 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7665 for ! HAVE_GTK3.
7666 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7667
7668 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7669
7670 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7671 gdk_window_get_screen, gdk_window_get_geometry,
7672 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7673 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7674 (xg_get_pixbuf_from_pixmap): New function.
7675 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7676 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7677 Call xg_get_pixbuf_from_pixmap instead of
7678 gdk_pixbuf_get_from_drawable.
7679 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7680 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7681 (xg_check_special_colors): Use GtkStyleContext and its functions
7682 for HAVE_GTK3.
7683 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7684 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7685 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7686 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7687 Call gtk_widget_get_preferred_size.
0afb4571
J
7688 (xg_frame_resized): gdk_window_get_geometry only takes 5
7689 parameters.
44f230aa
SM
7690 (xg_win_to_widget, xg_event_is_for_menubar):
7691 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7692 (xg_set_widget_bg): New function.
7693 (delete_cb): New function.
895009e1 7694 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7695 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7696 (xg_set_background_color): Call xg_set_widget_bg.
7697 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7698 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7699 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7700 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7701 if ! HAVE_GTK3.
7702 (update_frame_tool_bar): Call gtk_widget_hide.
7703 (xg_initialize): Use GDK_KEY_g.
7704
7705 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7706 if ! HAVE_GTK3
7707 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7708
7709 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7710 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7711 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7712
1c2cc4ef
JB
77132011-03-08 Juanma Barranquero <lekktu@gmail.com>
7714
7715 * w32xfns.c (select_palette): Check success of RealizePalette against
7716 GDI_ERROR, not zero.
7717
33383987 7718See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7719
7720;; Local Variables:
7721;; coding: utf-8
aac0c6e3
MR
7722;; End:
7723
33383987 7724 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7725
7726 This file is part of GNU Emacs.
7727
7728 GNU Emacs is free software: you can redistribute it and/or modify
7729 it under the terms of the GNU General Public License as published by
7730 the Free Software Foundation, either version 3 of the License, or
7731 (at your option) any later version.
7732
7733 GNU Emacs is distributed in the hope that it will be useful,
7734 but WITHOUT ANY WARRANTY; without even the implied warranty of
7735 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7736 GNU General Public License for more details.
7737
7738 You should have received a copy of the GNU General Public License
7739 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.