Use make_formatted_string to avoid double length calculation.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a8290ec3
DA
12012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Use make_formatted_string to avoid double length calculation.
4 * lisp.h (make_formatted_string): New prototype.
5 * alloc.c (make_formatted_string): New function.
6 * buffer.c (Fgenerate_new_buffer_name): Use it.
7 * dbus.c (syms_of_dbusbind): Likewise.
8 * editfns.c (Fcurrent_time_zone): Likewise.
9 * filelock.c (get_boot_time): Likewise.
10 * frame.c (make_terminal_frame, set_term_frame_name)
11 (x_report_frame_params): Likewise.
12 * image.c (gs_load): Likewise.
13 * minibuf.c (get_minibuffer): Likewise.
14 * msdos.c (dos_set_window_size): Likewise.
15 * process.c (make_process): Likewise.
16 * xdisp.c (ensure_echo_area_buffers): Likewise.
17 * xsettings.c (apply_xft_settings): Likewise.
18
d01ba2f1
GM
192012-07-09 Glenn Morris <rgm@gnu.org>
20
21 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
22 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
23 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
24 * nsterm.h (ns_etc_directory): Add it.
25 * callproc.c [HAVE_NS]: Include nsterm.h.
26 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
27
f1f924b6
DA
282012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
29
30 Move marker debugging code under MARKER_DEBUG.
31 * marker.c (MARKER_DEBUG): Move marker debugging code under
32 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
33 for bootstrap with --enable-checking (~3x slowdown reported
34 by Juanma Barranquero <lekktu@gmail.com>).
35 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
36
ab531b66
PE
372012-07-08 Paul Eggert <eggert@cs.ucla.edu>
38
39 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
40 See <http://bugs.gnu.org/11825#29>.
41
c4b3bc8a
EZ
422012-07-08 Eli Zaretskii <eliz@gnu.org>
43
44 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
45 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
46 (display_line): Add commentary about displaying truncation glyphs
47 on GUI frames.
48 (produce_special_glyphs): Move here from term.c.
49
50 * term.c (produce_special_glyphs): Move to xdisp.c.
51
52 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
53 section.
c4b3bc8a 54
b676b881
AS
552012-07-07 Andreas Schwab <schwab@linux-m68k.org>
56
f17c5273
AS
57 * xdisp.c (display_line): Avoid warning about implicit declaration
58 of FRAME_FONT.
59
298819b9
AS
60 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
61
b676b881
AS
62 * lisp.h: Remove empty conditional.
63
6045c4fd
PE
642012-07-07 Paul Eggert <eggert@cs.ucla.edu>
65
b3350bf9
PE
66 * lread.c (load_path_check): Now static.
67
6045c4fd
PE
68 Fix some minor --with-ns problems found by static checking.
69 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
70 (x_set_font) [!HAVE_X_WINDOWS]:
71 * image.c (xpm_load_image) [HAVE_NS]:
72 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
73 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
74 Remove unused local.
75 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
76 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
77 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
78 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
79 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
80 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
81 Fix pointer signedness problem.
82 * xfaces.c (FRAME_X_FONT_TABLE):
83 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
84
929e7845
GM
852012-07-07 Glenn Morris <rgm@gnu.org>
86
87 * lread.c (load_path_check): New function, split from init_lread.
88 (init_lread): Reorganize. Motivation:
89 If EMACSLOADPATH is set, check/warn about that rather than the
90 defaults, which we are not going to use. Hence we can remove
91 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
92 Don't warn if site-lisp directories are missing.
93 If not installed, start from a blank load-path, since
94 PATH_LOADSEARCH refers to the eventual installation directories.
95
58dd0aa4
EZ
962012-07-07 Eli Zaretskii <eliz@gnu.org>
97
98 Support truncation and continuation glyphs on GUI frames, when
99 fringes are disabled. (Bug#11832)
100 * xdisp.c (init_iterator): Get dimensions of truncation and
101 continuation glyphs even if on GUI frames. Adjust
102 it->last_visible_x on GUI frames when the left or right fringes,
103 or both, are absent.
104 (start_display, move_it_in_display_line_to): Handle the case of a
105 GUI frame without a fringe to display continuation or truncation
106 glyphs.
107 (insert_left_trunc_glyphs): Support GUI frames: make sure
108 truncation glyphs overwrite enough glyphs from the current line to
109 have sufficient space in pixels.
110 (display_line): Support truncation and continuation glyphs on GUI
111 frames. If some spare pixels are left on the line after inserting
112 the truncation glyphs, fill that space with a stretch glyph of a
113 suitably computed width.
114
115 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
116 produce_glyphs, to support GUI sessions.
117
31571fd7
PE
1182012-07-07 Paul Eggert <eggert@cs.ucla.edu>
119
5a16b9bc
PE
120 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
121
f3047c75
PE
122 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
123
31571fd7
PE
124 Do not require float-time's arg to fit in time_t (Bug#11825).
125 This works better on hosts where time_t is unsigned, and where
126 float-time is applied to the (negative) difference between two times.
127 * editfns.c (decode_time_components): Last arg is now double *,
128 not int *, and means to store all the result as a double, without
129 worrying about whether the seconds part fits in time_t.
130 All callers changed.
131 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
132 All callers changed.
133 (Ffloat_time): Do not fail merely because the specified time falls
134 outside of time_t range.
135
4516fbef
GM
1362012-07-07 Glenn Morris <rgm@gnu.org>
137
138 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
139 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
140 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
141
07adc2c6
JB
1422012-07-07 Juanma Barranquero <lekktu@gmail.com>
143
144 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
145 Update dependencies.
146
147 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
148
fd573f31
PE
1492012-07-06 Paul Eggert <eggert@cs.ucla.edu>
150
fee5959d
PE
151 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
152 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
153 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
154 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
155 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
156 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
157
fd573f31
PE
158 * xfont.c (compare_font_names): Redo to omit the need for casts.
159
ddadbc0e
AS
1602012-07-06 Andreas Schwab <schwab@linux-m68k.org>
161
fca8d6b6
AS
162 * xfns.c (Fx_change_window_property): Doc fix.
163 * w32fns.c (Fx_change_window_property): Doc fix.
164
ddadbc0e
AS
165 * w32fns.c (Fx_window_property): Accept the same arguments as the
166 X Windows version. Doc fix.
167 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
168
f247498e
JB
1692012-07-06 Juanma Barranquero <lekktu@gmail.com>
170 Eli Zaretskii <eliz@gnu.org>
171
172 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
173 Windows-specific code from nt/config.nt moved here.
174 Obsolete settings removed.
175
216ee680
PE
1762012-07-06 Paul Eggert <eggert@cs.ucla.edu>
177
178 * process.c: Avoid unnecessary calls to gettime.
179 (wait_reading_process_output): Don't get the time of day
180 when gobbling data immediately and not waiting, as there's no need
181 for it in that case. This removes a FIXME.
182
bdd091e4
JD
1832012-07-06 Jan Djärv <jan.h.d@swipnet.se>
184
185 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
186 is defined (Bug#11768).
187
9d44f8ce
DA
1882012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
189
190 Fix marker debugging code.
191 * marker.c (byte_char_debug_check): Do not perform the check
192 if buffer is not multibyte.
090bd7cb
JB
193 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
194 Call byte_char_debug_check with correct arguments.
9d44f8ce 195
90fc4786
DA
1962012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
197
198 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
199 * marker.c (byte_char_debug_check, count_markers):
200 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
201 (byte_debug_flag): Remove.
202 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
203 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
204
7b7ae965
DA
2052012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
206
4e57b342
DA
207 Avoid code repetition in marker-related functions.
208 * marker.c (attach_marker): New function.
209 (Fset_marker, set_marker_restricted, set_marker_both)
210 (set_marker_restricted_both): Use it.
211 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
212 Consistently rename charno to charpos.
213 (marker_position): Add eassert.
214 (marker_byte_position): Convert to eassert.
215
2162012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
217
218 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 219 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 220 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 221
657924ff
DA
2222012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
223
224 Introduce fast path for the widely used marker operation.
225 * alloc.c (build_marker): New function.
226 * lisp.h (build_marker): New prototype.
227 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
228 * composite.c (autocmp_chars): Likewise.
229 * editfns.c (buildmark): Remove.
230 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
231 (save_restriction_save): Use build_marker.
232 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
233 * window.c (save_window_save): Likewise.
234
041a49a6
DA
2352012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
236
237 Do not use Fdelete_overlay in delete_all_overlays
238 to avoid redundant calls to unchain_overlay.
239 * buffer.c (drop_overlay): New function.
240 (delete_all_overlays, Fdelete_overlay): Use it.
241 * minibuf.c (get_minibuffer): Fix comment.
242
7dca65a4
PE
2432012-07-06 Paul Eggert <eggert@cs.ucla.edu>
244
245 Port to OpenBSD 5.1 amd64.
246 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
247 This is needed for OpenBSD, and should be harmless on all BSD systems.
248 Also, include <sys/sysctl.h>, as it should be available on all
249 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
250 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
251 use p_pid member, not kp_proc.pid.
252
8eb876e2
GM
2532012-07-06 Glenn Morris <rgm@gnu.org>
254
255 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
256
38182d90
PE
2572012-07-05 Paul Eggert <eggert@cs.ucla.edu>
258
259 More xmalloc and related cleanup.
260 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
261 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
262 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
263 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
264 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
265 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
266 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
267 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
268 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
269 * xterm.c:
270 Omit needless casts involving void * pointers and allocation.
271 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
272 as the former is more robust if P's type is changed.
273 Prefer xzalloc to xmalloc + memset 0.
274 Simplify malloc-or-realloc to realloc.
275 Don't worry about xmalloc returning a null pointer.
276 Prefer xstrdup to xmalloc + strcpy.
277 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
278 growing it.
279 * keyboard.c (apply_modifiers_uncached): Prefer local array to
280 alloca of a constant.
281
6dd5a677
EZ
2822012-07-05 Eli Zaretskii <eliz@gnu.org>
283
284 * xdisp.c (display_line): Fix horizontal pixel coordinates when
285 hscroll is larger than the line width. Fixes long and futile
286 looping inside extend_face_to_end_of_line (on a TTY) producing
287 glyphs that are not needed and thrown away.
288
6b312f0f
DA
2892012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
290
291 * marker.c (set_marker_restricted_both): Simplify by using
292 clip_to_bounds.
293
f520ef9b
PE
2942012-07-05 Paul Eggert <eggert@cs.ucla.edu>
295
296 * editfns.c (region_limit): Simplify by using clip_to_bounds.
297
383b7c95
JD
2982012-07-05 Jan Djärv <jan.h.d@swipnet.se>
299
300 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
301 not defined (Bug#11768).
302 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
303 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
304 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
305 followed by gtk_box_set_homogeneous (Bug#11768).
306 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
307 (update_theme_scrollbar_width, xg_create_scroll_bar):
308 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
309 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
310 (is_box_type): New function (Bug#11768).
311 (xg_tool_item_stale_p): Call is_box_type.
5293d758 312 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
313 with default display (Bug#11768).
314
d6e7bf45
EZ
3152012-07-05 Eli Zaretskii <eliz@gnu.org>
316
317 * xdisp.c (window_hscroll_limited): New function.
318 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
319 coordinates when window's hscroll is set to insanely large
320 values. (Bug#11857)
321
431391ec
JB
3222012-07-05 Juanma Barranquero <lekktu@gmail.com>
323
324 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
325 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
326
23f86fce
DA
3272012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
328
329 Cleanup xmalloc.
330 * lisp.h (xzalloc): New prototype. Omit needless casts.
331 * alloc.c (xzalloc): New function. Omit needless casts.
332 * charset.c: Omit needless casts. Convert all calls to
333 xmalloc with following memset to xzalloc.
334 * dispnew.c: Likewise.
335 * fringe.c: Likewise.
336 * image.c: Likewise.
337 * sound.c: Likewise.
338 * term.c: Likewise.
339 * w32fns.c: Likewise.
340 * w32font.c: Likewise.
341 * w32term.c: Likewise.
342 * xfaces.c: Likewise.
343 * xfns.c: Likewise.
344 * xterm.c: Likewise.
345 * atimer.c: Omit needless casts.
346 * buffer.c: Likewise.
347 * callproc.c: Likewise.
348 * ccl.c: Likewise.
349 * coding.c: Likewise.
350 * composite.c: Likewise.
351 * doc.c: Likewise.
352 * doprnt.c: Likewise.
353 * editfns.c: Likewise.
354 * emacs.c: Likewise.
355 * eval.c: Likewise.
356 * filelock.c: Likewise.
357 * fns.c: Likewise.
358 * gtkutil.c: Likewise.
359 * keyboard.c: Likewise.
360 * lisp.h: Likewise.
361 * lread.c: Likewise.
362 * minibuf.c: Likewise.
363 * msdos.c: Likewise.
364 * print.c: Likewise.
365 * process.c: Likewise.
366 * region-cache.c: Likewise.
367 * search.c: Likewise.
368 * sysdep.c: Likewise.
369 * termcap.c: Likewise.
370 * terminal.c: Likewise.
371 * tparam.c: Likewise.
372 * w16select.c: Likewise.
373 * w32.c: Likewise.
374 * w32reg.c: Likewise.
375 * w32select.c: Likewise.
376 * w32uniscribe.c: Likewise.
377 * widget.c: Likewise.
378 * xdisp.c: Likewise.
379 * xmenu.c: Likewise.
380 * xrdb.c: Likewise.
381 * xselect.c: Likewise.
382
0497dc44
PE
3832012-07-05 Paul Eggert <eggert@cs.ucla.edu>
384
385 * fileio.c (time_error_value): Check the right error number.
386 Problem reported by Troels Nielsen in
387 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
388
356e7178
PE
3892012-07-04 Paul Eggert <eggert@cs.ucla.edu>
390
4e71fd89
PE
391 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
392 This should be fixed in a better way; see Eli Zaretskii in
393 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
394 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
395
f0941253
PE
396 * fileio.c (time_error_value): Rename from special_mtime.
397 The old name's problems were noted by Eli Zaretskii in
398 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
399
065c9eb4
PE
400 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
401 This variable's comment says Emacs needs at least one GDB-visible
402 symbol of type enum pvec_type, to work around GDB problems.
403 The symbol's value doesn't matter.
404
356e7178
PE
405 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
406 that causes compilation to fail on pre-C99 compilers.
407
95f61aa2
JB
4082012-07-04 Juanma Barranquero <lekktu@gmail.com>
409
410 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
411 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
412
3884d954
DA
4132012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
414
d209e2fb 415 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
416 headers for buffer_defaults and buffer_local_symbols.
417 Reported by Juanma Barranquero <lekktu@gmail.com>.
418
ee28be33
SM
4192012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
420
421 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
422 * lisp.h (enum pvec_type): Use fewer bits.
423 (PSEUDOVECTOR_SIZE_BITS): New constant.
424 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
425 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
426 change in pvec_type.
427 (PSEUDOVECTOR_TYPEP): New macro.
428 (TYPED_PSEUDOVECTORP): Use it.
429 * fns.c (internal_equal): Adapt code to extract pvectype.
430 * emacs.c (gdb_pvec_type): Update type.
431 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
432 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
433 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
434 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
435 (sweep_vectors): Use it. Use local var `total_bytes' instead of
436 abusing vector->header.next.nbytes.
437 (live_vector_p): Use PVEC_TYPE.
438 (mark_object): Adapt code to extract pvectype. Use switch.
439
c7f2cd7f
PE
4402012-07-04 Paul Eggert <eggert@cs.ucla.edu>
441
442 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
443 Tighten new eassert a bit.
444
8ce70ed2
DA
4452012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
446
447 Fix compilation with --enable-gcc-warnings and -O1
448 optimization level.
449 * doprnt.c (doprnt): Change type of tem to int, initialize
450 to avoid compiler warning. Add eassert.
451 * search.c (simple_search): Initialize match_byte to avoid
452 compiler warning. Add eassert.
453
dea7f1e5
PE
4542012-07-04 Paul Eggert <eggert@cs.ucla.edu>
455
24a212eb
PE
456 Avoid weird behavior with large horizontal scrolls.
457 Without this change, for example, large hscroll values would
458 mess up Emacs's display on Fedora 15 x86, presumably due to
459 overflows in int calculations in the display code.
460 Also, if buffers had long lines, Emacs would freeze.
461 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
462 (set_window_hscroll): New function, containing the old guts of
463 Fset_window_hscroll. Return the clipped value.
464 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
465 This avoids the need to check against PTRDIFF_MAX.
466
dea7f1e5
PE
467 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
468
76046526
DA
4692012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
470
471 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
472
39adff0d
PE
4732012-07-04 Paul Eggert <eggert@cs.ucla.edu>
474
63807d47
PE
475 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
476 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
477 since GCC 4.4.6 issues a bogus warning for them.
478
39adff0d
PE
479 Fix bugs in file timestamp newness comparisons.
480 * fileio.c (Ffile_newer_than_file_p):
481 * lread.c (Fload): Use full timestamp resolution of files,
482 not just the 1-second resolution, so that files that are only
483 slightly newer still count as newer.
484 * fileio.c (Ffile_newer_than_file_p): Don't assume file
485 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
486
dbeed9a6
PE
4872012-07-03 Paul Eggert <eggert@cs.ucla.edu>
488
489 * fileio.c: Improve handling of file time marker. (Bug#11852)
490 (special_mtime): New function.
491 (Finsert_file_contents, Fverify_visited_file_modtime):
492 Use it to set special mtime values consistently.
493
636334d6
AS
4942012-07-03 Andreas Schwab <schwab@linux-m68k.org>
495
496 * fileio.c (Finsert_file_contents): Properly handle st_mtime
497 marker for non-existing file. (Bug#11852)
498
e2017fe2
GM
4992012-07-03 Glenn Morris <rgm@gnu.org>
500
501 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
502 and did not make it into globals.h).
503
404dbd37
TT
5042012-07-03 Tom Tromey <tromey@redhat.com>
505
506 * window.c (Fset_window_margins, Fset_window_fringes)
507 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
508 * textprop.c (Fprevious_property_change): No longer static.
509 * syntax.c (Fsyntax_table_p): No longer static.
510 * process.c (Fget_process, Fprocess_datagram_address): No longer
511 static.
512 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
513 * keyboard.c (Fcommand_execute): No longer static.
514 Remove EXFUN.
515 * insdel.c (Fcombine_after_change_execute): No longer static.
516 * image.c (Finit_image_library): No longer static.
517 * fileio.c (Fmake_symbolic_link): No longer static.
518 * eval.c (Ffetch_bytecode): No longer static.
519 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
520 * doc.c (Fdocumentation_property, Fsnarf_documentation):
521 No longer static.
404dbd37
TT
522 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
523 static.
524 * dired.c (Ffile_attributes): No longer static.
525 * composite.c (Fcomposition_get_gstring): No longer static.
526 * callproc.c (Fgetenv_internal): No longer static.
527
528 * ccl.h: Remove EXFUNs.
529 * buffer.h: Remove EXFUNs.
530 * dispextern.h: Remove EXFUNs.
531 * intervals.h: Remove EXFUNs.
532 * fontset.h: Remove EXFUN.
533 * font.h: Remove EXFUNs.
534 * dosfns.c (system_process_attributes): Remove EXFUN.
535 * keymap.h: Remove EXFUNs.
536 * lisp.h: Remove EXFUNs.
537 * w32term.h: Remove EXFUNs.
538 * window.h: Remove EXFUNs.
539 * xsettings.h: Remove EXFUN.
540 * xterm.h: Remove EXFUN.
541
8e4fd1e1
GM
5422012-07-03 Glenn Morris <rgm@gnu.org>
543
544 * lisp.h (Frandom): Make it visible to C.
545 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
546 buffer for invisible buffers. (Bug#1229)
547
ca95b3eb
DA
5482012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
549
550 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
551 values which aren't power of 2.
552 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
553 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
554 accordingly.
555
7555c33f
SM
5562012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
557
558 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
559
560 * alloc.c (mark_object): Revert part of last patch to use `switch'.
561
d12e8f5a
DA
5622012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
563
564 * alloc.c (allocate_vector_block): Remove redundant
565 calls to mallopt if DOUG_LEA_MALLOC is defined.
566 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
567 avoid calls to mallopt if zero_vector is returned.
568
296094c3
DA
5692012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
570
571 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
572 is enabled, avoid dereferencing NULL current_sblock if
573 running undumped.
574
36429c89
DA
5752012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
576
577 Cleanup basic buffer management.
578 * buffer.h (struct buffer): Change layout to use generic vector
579 marking code. Fix some comments. Change type of 'clip_changed'
580 to bitfield. Remove unused #ifndef old.
581 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
582 (GET_OVERLAYS_AT): Fix indentation.
583 (for_each_per_buffer_object_at): New macro.
584 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
585 (Fbuffer_local_variables): Use it.
586 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
587 * alloc.c (allocate_buffer): Adjust to match new layout of
588 struct buffer. Fix comment.
589 (mark_overlay): New function.
590 (mark_buffer): Use it. Use mark_vectorlike to mark normal
591 Lisp area of struct buffer.
592 (mark_object): Use it. Adjust marking of misc objects
593 and related comments.
594
3b3e4cac
PE
5952012-07-02 Paul Eggert <eggert@cs.ucla.edu>
596
597 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
598 wrapper that is not needed because the wrapped code is a no-op (zero
599 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
600 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
601
cf5c0175
DA
6022012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
603
604 * alloc.c (mark_buffer): Simplify. Remove prototype.
605 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 606 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
607 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
608 redundant calls to mark_vectorlike for bool vectors.
609
ca26824c
GM
6102012-06-30 Glenn Morris <rgm@gnu.org>
611
2e4c5312
GM
612 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
613
ca26824c
GM
614 * epaths.in (PATH_SITELOADSEARCH): New.
615 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
616 This is rather than relying on --enable-locallisppath elements
617 having "site-lisp" in their names. (Bug#10208#25, 11658)
618
0d23c240
EZ
6192012-06-30 Eli Zaretskii <eliz@gnu.org>
620
c9240d7a
EZ
621 * w32proc.c (sys_select): Accept and ignore one more argument.
622
623 * w32.c (emacs_gnutls_pull): Call select with one more argument.
624
0d23c240 625 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 626 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
627
628 * sysdep.c: Don't include dos.h and dosfns.h.
629
630 * process.c (sys_select):
631 * msdos.c (sys_select): Accept one more argument and ignore it.
632
633 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
634 adapt data types and code to that.
635
636 * dosfns.c:
637 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
638 which clashes with the gnulib function of the same name.
639
af5a5a98
AS
6402012-06-30 Andreas Schwab <schwab@linux-m68k.org>
641
c5e4379c
AS
642 * font.c (font_style_to_value, font_style_symbolic)
643 (font_prop_validate_style): Add type checks for values in
644 font_style_table.
645
af5a5a98
AS
646 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
647 argument.
648 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
649 uses.
650
8d38f461
EZ
6512012-06-29 Eli Zaretskii <eliz@gnu.org>
652
2e5a6631
EZ
653 * xdisp.c (try_window_id): Undo last change.
654
8d38f461
EZ
655 * w32.c (getwd): Adjust commentary about startup_dir.
656 (init_environment): Always call sys_access, even in non-MSVC
657 builds. Don't chdir to the directory of the Emacs executable.
658 This undoes code from 1997 which was justified by the need to
659 "avoid conflicts when removing and renaming directories". But its
660 downside was that every relative file name was being interpreted
661 relative to the directory of the Emacs executable, which can never
662 be TRT. In particular, it broke sys_access when called with
663 relative file names.
664 (sys_access): Map GetLastError to errno.
665
2af3565e
DA
6662012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
667
668 * window.h (struct window): Change type of 'fringes_outside_margins'
669 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 670 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
671 Adjust comment.
672 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
673 to ptrdiff_t.
674
c8d3a25c 6752012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 676
c8d3a25c
GM
677 * gnutls.c (emacs_gnutls_handshake):
678 Add QUIT to make the loop interruptible.
57570cd3 679
c8d3a25c 6802012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 681
c8d3a25c
GM
682 * charset.c (init_charset): Make lack of etc/charsets fatal.
683
3e984ee8
DA
6842012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
685
686 * editfns.c (region_limit): Fix type mismatch.
687
ef884f23
DA
6882012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
689
690 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
691 undefined. Convert from xassert to eassert.
692 * nsmenu.m: Convert from xassert to eassert.
693 * nsterm.m: Likewise.
694
7d7e0027
SM
6952012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
696
697 * editfns.c (region_limit): Clip to narrowing (bug#11770).
698
aa754e6a
PE
6992012-06-28 Paul Eggert <eggert@cs.ucla.edu>
700
701 Avoid integer overflow on scroll-left and scroll-right.
702 * window.c (HSCROLL_MAX): New macro.
703 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
704 overflow when requested scroll falls outside ptrdiff_t range.
705
80b00b08
DA
7062012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
707
708 * window.h (struct window): Change type of 'hscroll',
709 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
710 'last_modified' and 'last_overlay_modified' to EMACS_INT.
711 Adjust users accordingly.
712 * xdisp.c (try_cursor_movement): Replace type check with eassert.
713 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
714 from EMACS_INT to ptrdiff_t.
715 (make_window): Omit redundant initialization.
716
62b2bcf6
JB
7172012-06-28 Juanma Barranquero <lekktu@gmail.com>
718
719 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
720
45942c7d
DA
7212012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
722
723 * window.h (struct window): Change type of 'use_time' and
724 'sequence_number' from Lisp_Object to int.
725 * frame.c (make_frame): Adjust users accordingly.
726 * print.c (print_object): Likewise.
727 * window.c (select_window, Fwindow_use_time, make_parent_window)
728 (make_window): Likewise.
729
e509cfa6
DA
7302012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
731
732 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
733 enabled with --enable-checking=[all,glyphs] configure option.
734 Fix GLYPH_DEBUG usage assuming that it may be undefined,
735 adjust comments accordingly.
736 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
737 undefined, adjust comments accordingly.
738 * image.c: Likewise.
739 * scroll.c: Likewise.
740 * w32fns.c: Likewise.
741 * w32term.c: Likewise.
742 * xdisp.c: Likewise.
743 * xfaces.c: Likewise.
744 * xfns.c: Likewise.
745 * xterm.c: Likewise.
746
a54e2c05
DA
7472012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
748
749 Generalize run-time debugging checks.
750 * dispextern.h (XASSERTS): Remove.
751 * fontset.c (xassert): Remove.
752 Convert from xassert to eassert.
753 * alloc.c: Convert from xassert to eassert.
754 * bidi.c: Likewise.
755 * dispnew.c: Likewise.
756 * fns.c: Likewise.
757 * fringe.c: Likewise.
758 * ftfont.c: Likewise.
759 * gtkutil.c: Likewise.
760 * image.c: Likewise.
761 * keyboard.c: Likewise.
762 * menu.c: Likewise.
763 * process.c: Likewise.
764 * scroll.c: Likewise.
765 * sound.c: Likewise.
766 * term.c: Likewise.
767 * w32console.c: Likewise.
768 * w32fns.c: Likewise.
769 * w32term.c: Likewise.
770 * window.c: Likewise.
771 * xdisp.c: Likewise.
772 * xfaces.c: Likewise.
773 * xfns.c: Likewise.
774 * xselect.c: Likewise.
775 * xterm.c: Likewise.
776
1ec4b7b2
SM
7772012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
778
779 * fns.c (maybe_resize_hash_table): Output message when growing the
780 purify-hashtable.
781
2014308a
DA
7822012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
783
784 * alloc.c (allocate_string_data): Remove dead code.
785 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
786 avoid GCC warning about unused macro.
787
246155eb
DA
7882012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
789
790 * alloc.c (allocate_string): Omit intervals initialization.
791 * alloc.c (make_uninit_multibyte_string): Initialize intervals
792 as in make_pure_string and make_pure_c_string.
793
43184b7b
DA
7942012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
795
d209e2fb 796 * alloc.c (allocate_string): Fix last change.
43184b7b 797
3fe6dd74
DA
7982012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
799
d209e2fb 800 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
801 to memset, add explicit initialization where appropriate.
802
1ba6038a
GM
8032012-06-27 Glenn Morris <rgm@gnu.org>
804
805 * lisp.mk (lisp): Remove paths.elc.
806
c89926a5
CY
8072012-06-27 Chong Yidong <cyd@gnu.org>
808
809 * doc.c (Fsubstitute_command_keys): Fix punctuation.
810
ed6b3510
JW
8112012-06-26 John Wiegley <johnw@newartisans.com>
812
1ec4b7b2 813 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
814 on Mac OS X Lion: __mod_init_func and __mod_term_func.
815
ed6b3510
JW
816 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
817 when building with Clang.
818
8edd4a2b
SM
8192012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
820
821 * eval.c (Fapply): Allow calling it with a single argument.
822
f6f62d1b
EZ
8232012-06-26 Eli Zaretskii <eliz@gnu.org>
824
825 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
826 _stricmp and _strnicmp.
827 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
828
62efea5e
DA
8292012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
830
831 * alloc.c (allocate_window): Zero out non-Lisp part of newly
832 allocated window.
833 (allocate_process): Likewise for new process.
8edd4a2b 834 (allocate_terminal): Change to use offsetof.
62efea5e
DA
835 (allocate_frame): Likewise.
836 * frame.c (make_frame): Omit redundant initialization.
837 * window.c (make_parent_window): Use memset.
838 (make_window): Omit redundant initialization.
839 * process.c (make_process): Omit redundant initialization.
840 * terminal.c (create_terminal): Likewise.
841
42997f4d
DA
8422012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
843
844 * term.c (delete_tty): Remove redundant call to memset.
845
1130ecfc
DA
8462012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
847
848 * alloc.c: Remove build_string.
849 * lisp.h: Define build_string as static inline. This provides
850 a better opportunity to optimize away calls to strlen when the
851 function is called with compile-time constant argument.
852 * image.c (imagemagick_error): Convert to build_string.
853 * w32proc.c (sys_spawnve): Likewise.
854 * xterm.c (x_term_init): Likewise.
855
cf38a720
PE
8562012-06-26 Paul Eggert <eggert@cs.ucla.edu>
857
99027bdd
PE
858 Use sprintf return value instead of invoking strlen on result.
859 In the old days this wasn't portable, since some sprintf
860 implementations returned char *. But they died out years ago and
861 Emacs already assumes sprintf returns int.
862 Similarly for float_to_string.
863 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
864 * ccl.c (ccl_driver):
865 * character.c (string_escape_byte8):
866 * data.c (Fnumber_to_string):
867 * doprnt.c (doprnt):
868 * print.c (print_object):
869 * xdisp.c (message_dolog):
870 * xfns.c (syms_of_xfns):
871 Use sprintf or float_to_string result to avoid need to call strlen.
872 * data.c (Fnumber_to_string):
873 Use make_unibyte_string, since the string must be ASCII.
874 * lisp.h, print.c (float_to_string): Now returns int length.
875 * term.c (produce_glyphless_glyph):
876 Use sprintf result rather than recomputing it.
877
cf38a720
PE
878 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
879 * Makefile.in (ALL_CFLAGS):
880 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
881 * gmalloc.c, regex.c: Include <config.h> unconditionally.
882
3511c784
DA
8832012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
884
0a08eb21 885 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
886 strcasecmp if available.
887 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
888
fb7da12e
AS
8892012-06-25 Andreas Schwab <schwab@linux-m68k.org>
890
891 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
892 Avoid comma operator.
893 * menu.c (push_submenu_start, push_submenu_end)
894 (push_left_right_boundary, push_menu_pane): Likewise.
895 * msdos.c (dos_rawgetc): Likewise.
896
afa2ffd8
DA
8972012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
898
899 * xfns.c (xic_create_fontsetname): Remove redundant calls
900 to memset.
901
b3b4476b
PE
9022012-06-25 Paul Eggert <eggert@cs.ucla.edu>
903
4495ff38
PE
904 * gtkutil.c (get_utf8_string): Remove redundant assignment.
905 sprintf already null-terminates its output.
906
b3b4476b
PE
907 * xfns.c (x_window): Remove redundant cast.
908
b00876c9
DA
9092012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
910
911 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
912 `const char *' to `char *' to avoid compiler warning.
913
d188e26b
PE
9142012-06-24 Paul Eggert <eggert@cs.ucla.edu>
915
885d1d74
PE
916 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
917 instead of truncating it to 63 (admittedly a generous limit).
918
d188e26b
PE
919 * process.c: Fix spelling and caps in comments.
920
e2f560b1
DN
9212012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
922
e86db54b 923 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
924 * sysdep.c (setpgrp): Remove definition, not used in this file.
925
7583a3a1
JB
9262012-06-24 Juanma Barranquero <lekktu@gmail.com>
927
928 * makefile.w32-in: Update dependencies.
929
696056c2
EZ
9302012-06-24 Eli Zaretskii <eliz@gnu.org>
931
932 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
933 (SYSTIME_H): Add nt/inc/sys/time.h.
934
935 * systime.h [WINDOWSNT]: Include sys/time.h.
936
937 * s/ms-w32.h (struct timespec): Definition moved from
938 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
939
845ca893
PE
9402012-06-24 Paul Eggert <eggert@cs.ucla.edu>
941
942 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
943 * buffer.h (buffer_slot_type_mismatch):
944 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
945 * eval.c (unwind_to_catch):
946 * image.c (my_png_error, my_error_exit):
947 * keyboard.c (quit_throw_to_read_char, user_error)
948 (Fexit_recursive_edit, Fabort_recursive_edit):
949 * lisp.h (die, args_out_of_range, args_out_of_range_3)
950 (wrong_type_argument, buffer_overflow, __executable_start)
951 (memory_full, buffer_memory_full, string_overflow, Fthrow)
952 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
953 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
954 (fatal):
955 (child_setup) [!DOS_NT]:
956 * lread.c (end_of_file_error, invalid_syntax):
957 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
958 * puresize.h (pure_write_error):
959 * search.c (matcher_overflow):
960 * sound.c (sound_perror, alsa_sound_perror):
961 * sysdep.c, syssignal.h (croak):
962 * term.c (maybe_fatal, vfatal):
963 * textprop.c (text_read_only):
964 * undo.c (user_error):
965 * unexmacosx.c (unexec_error):
966 * xterm.c (x_ins_del_lines, x_delete_glyphs):
967 Use _Noreturn rather than NO_RETURN.
968 No need for separate decl merely because of _Noreturn.
969 * sound.c (sound_warning, parse_sound):
970 Remove unnecessary forward decls.
971
f1dd8073
PE
9722012-06-24 Paul Eggert <eggert@cs.ucla.edu>
973
974 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
975 * lisp.h (WAIT_READING_MAX): New macro.
976 * dispnew.c (Fsleep_for, sit_for):
977 * keyboard.c (kbd_buffer_get_event):
978 * process.c (Faccept_process_output):
979 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
980 This improves on the previous patch, which introduced a bug
981 when time_t is unsigned and as wide as intmax_t.
982 See <http://bugs.gnu.org/9000#51>.
983
b82c1755
EZ
9842012-06-23 Eli Zaretskii <eliz@gnu.org>
985
986 * dispnew.c (sit_for, Fsleep_for):
987 * keyboard.c (kbd_buffer_get_event):
988 * process.c (Faccept_process_output): Avoid compiler warnings when
989 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
990
ca300656
JB
9912012-06-23 Juanma Barranquero <lekktu@gmail.com>
992
049ec95b
JB
993 * makefile.w32-in: Update dependencies.
994
ca300656
JB
995 * w32.c (ltime): Add return type and declare static.
996 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
997
db7b8d06
PE
9982012-06-23 Paul Eggert <eggert@cs.ucla.edu>
999
1000 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1001 Privately reported by Herbert J. Skuhra.
1002 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1003 All uses changed.
1004 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1005 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1006
0bd8297f
EZ
10072012-06-23 Eli Zaretskii <eliz@gnu.org>
1008
96512555
EZ
1009 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1010 last argument of make_unibyte_string.
1011
0bd8297f
EZ
1012 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1013 language ID in the event parameters.
1014
1015 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1016 event.code, not the obscure "character set ID".
1017
63def6b6
CY
10182012-06-23 Chong Yidong <cyd@gnu.org>
1019
1020 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1021
e8a02204
EZ
10222012-06-23 Eli Zaretskii <eliz@gnu.org>
1023
388cdec0
EZ
1024 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1025 * w32.c (fdutimens): New function.
1026
1027 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1028
1029 * s/ms-w32.h (pselect): Redirect to sys_select.
1030
1031 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1032
e8a02204
EZ
1033 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1034 in the logic of incrementing and decrementing the value of
1035 use_relocatable_buffers.
1036
d054f3fb
PE
10372012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1038
1039 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1040 Privately reported by Herbert J. Skuhra.
1041 [__FreeBSD__]: Remove "*/" typo after "#include".
1042 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1043 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1044 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1045 Don't assume EMACS_TIME and struct timeval are the same type.
1046
d35af63c
PE
10472012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1048
1049 Support higher-resolution time stamps (Bug#9000).
1050 The time stamps are only nanosecond-resolution at the C level,
1051 since that's the best that any real-world system supports now.
1052 But they are picosecond-resolution at the Lisp level, as that's
1053 easy, and leaves room for future OS improvements.
1054
1055 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1056 (LIBES): Use it.
1057
1058 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1059 Don't get current time unless it's needed.
1060
1061 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1062 now provides it if it's absent.
1063 (start_atimer): Port to higher-res time stamps.
1064 Check for time stamp overflow. Don't get current time more
1065 often than is needed.
1066
1067 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1068 Include systime.h, not time.h.
1069 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1070
1071 * dired.c: Include stat-time.h.
1072 (Ffile-attributes): File times now have higher resolution.
1073
1074 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1075 (struct image): Timestamp now has higher resolution.
1076
1077 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1078 has at least microseconds now. All uses removed.
1079 (update_frame, update_single_window, update_window, update_frame_1)
1080 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1081
1082 * editfns.c (time_overflow): Now extern.
1083 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1084 (float-time, Fformat_time_string, Fcurrent_time_string)
1085 (Fcurrent_time_zone): Accept and generate higher-resolution
1086 time stamps.
1087 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1088 (decode_time_components, lisp_seconds_argument): New functions.
1089 (make_time): Now static.
1090 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1091 Report an error if the time is invalid, rather than having the caller
1092 do that.
1093
1094 * fileio.c: Include <stat-time.h>
1095 (Fcopy_file): Copy higher-resolution time stamps.
1096 Prefer to set the time stamp via a file descriptor if that works.
1097 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1098 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1099 (Fvisited_file_modtime, Fset_visited_file_modtime):
1100 Support higher-resolution time stamps.
1101
1102 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1103
1104 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1105
1106 * image.c (prepare_image_for_display, clear_image_cache)
1107 (lookup_image): Port to higer-resolution time stamps.
1108
1109 * keyboard.c (start_polling, bind_polling_period):
1110 Check for time stamp overflow.
1111 (read_char, kbd_buffer_get_event, timer_start_idle)
1112 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1113 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1114 Port to higher-resolution time stamps. Do not assume time_t is signed.
1115 (decode_timer): New function. Timers are now vectors of length 9,
1116 not 8, to accommodate the picosecond component.
1117 (timer_check_2): Use it.
1118
1119 * nsterm.m (select_timeout, timeval_subtract): Remove.
1120 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1121 as they're a bit more accurate and handle overflow better.
1122 (ns_select): Change prototype to be compatible with pselect.
1123 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1124 * nsterm.h (ns_select): Adjust prototype.
1125
1126 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1127 us-resolution time stamps.
1128 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1129
1130 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1131
1132 * lisp.h (time_overflow): New decl.
1133 (wait_reading_process_output): First arg is now intmax_t, not int,
1134 to accommodate larger waits.
1135
1136 * process.h (struct Lisp_Process.read_output_delay):
1137 Now counts nanoseconds, not microseconds.
1138 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1139 EMACS_HAS_USECS.
1140 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1141 (wait_reading_process_output):
1142 Port to ns-resolution time stamps.
1143 (Faccept_process_output, wait_reading_process_output):
1144 Check for time stamp overflow. Do not assume time_t is signed.
1145 (select_wrapper): Remove; we now use pselect.
1146 (Fprocess_attributes): Now generates ns-resolution time stamps.
1147
1148 * sysdep.c: Include utimens.h. Don't include utime.h
1149 or worry about struct utimbuf; gnulib does that for us now.
1150 (gettimeofday): Remove; gnulib provides a substitute.
1151 (make_timeval): New function.
1152 (set_file_times): Now sets ns-resolution time stamps.
1153 New arg FD; all uses changed.
1154 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1155 (system_process_attributes):
1156 Now returns ns-resolution time stamp. All uses changed.
1157 Check for time stamp overflow.
1158
1159 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1160 provides a substitute now.
1161
1162 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1163 since it guarantees struct timespec.
1164 (EMACS_TIME): Now struct timespec, so that we can support
1165 ns-resolution time stamps.
1166 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1167 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1168 (EMACS_USECS): Remove.
1169 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1170 so multiply the arg by 1000 before storing it.
1171 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1172 New macros.
1173 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1174 Port to ns-resolution time stamps.
1175 (EMACS_TIME_NEG_P): Remove; replaced by....
1176 (EMACS_TIME_SIGN): New macro.
1177 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1178 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1179 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1180 (make_timeval, make_lisp_time, decode_time_components): New decls.
1181 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1182 that it mishandled time_t overflow. You can't compare by subtracting!
1183 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1184 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1185
1186 * term.c: Include <sys/time.h>.
1187 (timeval_to_Time): New function, for proper overflow wraparound.
1188 (term_mouse_position, term_mouse_click): Use it.
1189
1190 * undo.c (record_first_change): Support higher-resolution time stamps
1191 in the undo buffer.
1192 (Fprimitive_undo): Use them when restoring time stamps.
1193
1194 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1195 (w32_get_internal_run_time):
1196 Port to higher-resolution Emacs time stamps.
1197 (ltime): Now accepts single 64-bit integer, as that's more convenient
1198 for callers.
1199
1200 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1201
1202 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1203 for compatibility with pselect. Support ns-resolution time stamps.
1204
1205 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1206
1207 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1208 Check for time stamp overflow, and support ns-resolution time stamps.
1209
1210 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1211 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1212 (timeval_subtract): Remove; no longer needed.
1213 (XTflash, XTring_bell, x_wait_for_event):
1214 Port to ns-resolution time stamps. Don't assume time_t is signed.
1215
b6a92dfe
CY
12162012-06-22 Chong Yidong <cyd@gnu.org>
1217
1218 * xdisp.c (x_consider_frame_title): Revert last change.
1219
d251c37c
EZ
12202012-06-22 Eli Zaretskii <eliz@gnu.org>
1221
1222 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1223 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1224 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1225 staticidx goes up to 1597 out of 1600 = 0x640.)
1226
f10deafb
PE
12272012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1228
1229 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1230 Otherwise, the umask might be mistakenly 0 while handling input signals.
1231
ec6de1e2
SM
12322012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1233
1234 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1235
28be1ada
DA
12362012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1237
1238 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1239 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1240 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1241 access to `contents' member of Lisp_Vector objects with AREF and ASET
1242 where appropriate.
1243
c6bf3022
CY
12442012-06-19 Chong Yidong <cyd@gnu.org>
1245
1246 * frame.c (delete_frame): When selecting a frame on a different
1247 text terminal, do not alter the terminal's top-frame.
1248
1249 * xdisp.c (format_mode_line_unwind_data): Record the target
1250 frame's selected window and its terminal's top-frame.
1251 (unwind_format_mode_line): Restore them.
1252 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1253 Callers changed.
1254 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1255 since tty frames can be explicitly named.
1256 (prepare_menu_bars): Likewise.
1257
1258 * term.c (Ftty_top_frame): New function.
1259
defd4196
PE
12602012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1261
1262 Port byte-code-meter to modern targets.
1263 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1264 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1265 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1266 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1267 (METER_1, METER_2): Simplify.
1268
1053a871
SM
12692012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1270
1271 * data.c (Fdefalias): Return `symbol' (bug#11686).
1272
b7e8d081
MR
12732012-06-18 Martin Rudalics <rudalics@gmx.at>
1274
1275 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1276 gets killed during executing of this function (Bug#11665).
1277 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1278 (Vkill_buffer_query_functions): In doc-string say that functions
1279 run by this hook should not change the current buffer.
1280
7ea2b339
PE
12812012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1282
1283 Fix recently-introduced process.c problems found by static checking.
1284 * process.c (write_queue_push, write_queue_pop, send_process):
1285 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1286 (write_queue_pop): Fix pointer signedness problem.
1287 (send_process): Remove unused local.
1288
96a313a1
CY
12892012-06-17 Chong Yidong <cyd@gnu.org>
1290
1291 * xdisp.c (redisplay_internal): No need to redisplay terminal
1292 frames that are not on top.
1293
20ca2e94
TN
12942012-06-17 Troels Nielsen <bn.troels@gmail.com>
1295
1296 * process.c (make_process): Initialize write_queue.
1297 (write_queue_push, write_queue_pop): New functions.
1298 (send_process): Use them to maintain correct ordering of process
1299 writes (Bug#10815).
1300
9a900ca9
PE
13012012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1302
310fbfa8
PE
1303 * lisp.h (eassert): Assume C89 or later.
1304 This removes the need for CHECK.
1305 (CHECK): Remove. Its comments about always evaluating its
1306 argument were confusing, as 'eassert' typically does not evaluate
1307 its argument.
1308
27bb1ca4
PE
1309 * coding.c (produce_chars): Use ptrdiff_t, not int.
1310
9a900ca9
PE
1311 * xterm.c (x_draw_underwave): Check for integer overflow.
1312 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1313
41b7f8bc 13142012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1315
1316 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1317 referenced (Bug#11583).
1318
9b0e3eba
AA
13192012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1320
1321 Implement wave-style variant of underlining.
1322 * dispextern.h (face_underline_type): New enum.
1323 (face): Add field for underline type.
1324 * nsterm.m (ns_draw_underwave): New function.
1325 (ns_draw_text_decoration): Use it.
1326 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1327 New functions.
1328 (x_draw_glyph_string): Use them.
1329 * xfaces.c (Qline, Qwave): New Lisp objects.
1330 (check_lface_attrs, merge_face_ref)
1053a871
SM
1331 (Finternal_set_lisp_face_attribute, realize_x_face):
1332 Handle wave-style underline face attributes.
9b0e3eba
AA
1333 * xterm.c (x_draw_underwave): New function.
1334 (x_draw_glyph_string): Use it.
1335
0fb52f11
JB
13362012-06-16 Juanma Barranquero <lekktu@gmail.com>
1337
1338 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1339 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1340 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1341 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1342 ($(BLD)/w32select.$(O)): Update dependencies.
1343
e5560ff7
AS
13442012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1345
1346 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1347 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1348 * character.c (_fetch_multibyte_char_p): Remove.
1349 * alloc.c: Include "character.h" before "buffer.h".
1350 * bidi.c: Likewise.
1351 * buffer.c: Likewise.
1352 * bytecode.c: Likewise.
1353 * callint.c: Likewise.
1354 * callproc.c: Likewise.
1355 * casefiddle.c: Likewise.
1356 * casetab.c: Likewise.
1357 * category.c: Likewise.
1358 * cmds.c: Likewise.
1359 * coding.c: Likewise.
1360 * composite.c: Likewise.
1361 * dired.c: Likewise.
1362 * dispnew.c: Likewise.
1363 * doc.c: Likewise.
1364 * dosfns.c: Likewise.
1365 * editfns.c: Likewise.
1366 * emacs.c: Likewise.
1367 * fileio.c: Likewise.
1368 * filelock.c: Likewise.
1369 * font.c: Likewise.
1370 * fontset.c: Likewise.
1371 * fringe.c: Likewise.
1372 * indent.c: Likewise.
1373 * insdel.c: Likewise.
1374 * intervals.c: Likewise.
1375 * keyboard.c: Likewise.
1376 * keymap.c: Likewise.
1377 * lread.c: Likewise.
1378 * macros.c: Likewise.
1379 * marker.c: Likewise.
1380 * minibuf.c: Likewise.
1381 * nsfns.m: Likewise.
1382 * nsmenu.m: Likewise.
1383 * print.c: Likewise.
1384 * process.c: Likewise.
1385 * regex.c: Likewise.
1386 * region-cache.c: Likewise.
1387 * search.c: Likewise.
1388 * syntax.c: Likewise.
1389 * term.c: Likewise.
1390 * textprop.c: Likewise.
1391 * undo.c: Likewise.
1392 * unexsol.c: Likewise.
1393 * w16select.c: Likewise.
1394 * w32fns.c: Likewise.
1395 * w32menu.c: Likewise.
1396 * window.c: Likewise.
1397 * xdisp.c: Likewise.
1398 * xfns.c: Likewise.
1399 * xmenu.c: Likewise.
1400 * xml.c: Likewise.
1401 * xselect.c: Likewise.
1402
2f07e6af
EZ
14032012-06-16 Eli Zaretskii <eliz@gnu.org>
1404
1053a871
SM
1405 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1406 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1407 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1408 row.
1409 (handle_face_prop): Use chunk-relative overlay string index when
1410 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1411 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1412 the rightmost. (Bug#11720)
2f07e6af 1413
29b83cec
AS
14142012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1415
1416 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1417 (CATEGORY_MEMBER): Enforce 1/0 value.
1418 * category.c (_temp_category_set): Remove.
1419
4c5501e9
EZ
14202012-06-16 Eli Zaretskii <eliz@gnu.org>
1421
1422 * window.c (Fdelete_other_windows_internal)
1423 (Fdelete_window_internal): Don't access frame's mouse highlight
1424 info of the initial frame. (Bug#11677)
1425
2b570124
PE
14262012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1427
e93864f9
PE
1428 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1429 Assume USE_2_TAGS_FOR_INTS.
1430 (xreload): Adjust $tagmask width to match recent lisp.h change.
1431
2b570124
PE
1432 Simplify lisp.h in minor ways that should not affect code.
1433 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1434 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1435 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1436 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1437 (INTTYPEBITS): New macro, for clarity.
1438 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1439 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1440 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1441 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1442 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1443
81755f69
JB
14442012-06-13 Juanma Barranquero <lekktu@gmail.com>
1445
1446 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1447
16192a57
GM
14482012-06-13 Glenn Morris <rgm@gnu.org>
1449
1450 * s/bsd-common.h (BSD4_3):
1451 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1452
646b5f55
AS
14532012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1454
1455 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1456 instead of union.
1457 (XLI, XIL): Define.
1053a871
SM
1458 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1459 Use them.
1460 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1461 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1462 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1463 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1464 * frame.c (delete_frame): Remove outdated comment.
1465 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1466 USE_LISP_UNION_TYPE.
1467 (Fw32_unregister_hot_key): Likewise.
1468 (Fw32_toggle_lock_key): Likewise.
1469 * w32menu.c (add_menu_item): Likewise.
1470 (w32_menu_display_help): Use XIL instead of checking
1471 USE_LISP_UNION_TYPE.
1472 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1473 (init_heap): Likewise.
1474 * w32term.c (w32_read_socket): Update comment.
1475
1d3823c9
GM
14762012-06-13 Glenn Morris <rgm@gnu.org>
1477
c62ff706
GM
1478 * s/usg5-4-common.h, src/s/unixware.h:
1479 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1480
1d3823c9
GM
1481 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1482
bfe3e0a2
PE
14832012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1484
1485 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1486 * alloc.c (make_number) [!defined make_number]:
1487 Remove, as lisp.h always defines this now.
1488 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1489 (roundup_size): Verify that it is a power of 2.
1490 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1491 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1492 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1493 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1494 USE_LSB_TAG now is always defined to be either 0 or 1.
1495 All uses changed.
1496 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1497 code works fine either way, and efficiency is not a concern here,
1498 as the union type is for debugging, not for production.
1499 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1500 Use an inline function on all platforms when using the union type,
1501 since this is simpler and 'static inline' can be used portably
1502 within Emacs now.
1503 (LISP_INITIALLY_ZERO): New macro.
1504 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1505 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1506
45fa9c0f
GM
15072012-06-12 Glenn Morris <rgm@gnu.org>
1508
b4492cba
GM
1509 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1510
1511 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1512
45fa9c0f
GM
1513 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1514 Move BROKEN_SIGIO to configure.
1515
1516 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1517 Move NO_TERMIO to configure.
1518
0e25d334
CY
15192012-06-12 Chong Yidong <cyd@gnu.org>
1520
1521 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1522 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1523 MagickExportImagePixels is undefined.
1524
43682bb6
PE
15252012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1526
1527 * image.c (imagemagick_load_image): Remove unused label.
1528
a9be7d2b
GM
15292012-06-11 Glenn Morris <rgm@gnu.org>
1530
1531 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1532 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1533 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1534 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1535
3017f87f
SM
15362012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1537
1538 * alloc.c (make_byte_code): New function.
1539 (Fmake_byte_code): Use it. Don't purify here.
1540 * lread.c (read1): Use it as well to avoid extra allocation.
1541
1b9b4cf4
CY
15422012-06-11 Chong Yidong <cyd@gnu.org>
1543
1544 * image.c (imagemagick_load_image): Implement transparency.
1545
95988fcf
AS
15462012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1547
1548 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1549 account for preceding backslashes. (Bug#11663)
1550
cd4eb164
CY
15512012-06-09 Chong Yidong <cyd@gnu.org>
1552
1553 * term.c: Support italics in capable terminals (Bug#9652).
1554 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1555 (turn_on_face): Output using TS_enter_italic_mode if available.
1556 Don't handle unused blinking and alt-charset cases.
1557 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1558 and tty_alt_charset_p cases.
1559 (tty_capable_p, init_tty): Support italics.
1560
1561 * termchar.h (struct tty_display_info): Add field for italics.
1562 Remove unused blink field.
1563
1564 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1565 Handle slant.
1566
1567 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1568 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1569 tty_alt_charset_p. Add tty_italic_p.
1570
ff88beb8
MA
15712012-06-09 Michael Albinus <michael.albinus@gmx.de>
1572
1573 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1574 dbus_type_is_basic if available.
1575 (xd_extract_signed, xd_extract_unsigned): Rename from
1576 extract_signed and extract_unsigned, respectively. Adapt callers.
1577
44286096
CY
15782012-06-09 Chong Yidong <cyd@gnu.org>
1579
1682701f
CY
1580 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1581
44286096
CY
1582 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1583 case (Bug#9752).
1584
d86feb17
PE
15852012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1586
1587 * xdisp.c (vmessage): Treat frame message as multibyte.
1588 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1589 would generate the diagnostic "Making \302\247 buffer-local while
1590 let-bound!".
1591
d5c20fe8
EZ
15922012-06-08 Eli Zaretskii <eliz@gnu.org>
1593
1594 * dispnew.c (showing_window_margins_p): Undo last change, which
1595 was done due to an inadvertent commit.
1596 (adjust_frame_glyphs_for_frame_redisplay): Do call
1597 showing_window_margins_p.
1598
513749ee
SM
15992012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1600
1601 * eval.c (Fmake_var_non_special): New primitive.
1602 (syms_of_eval): Defsubr it.
1603 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1604
d4a8f5c1
JB
16052012-06-08 Juanma Barranquero <lekktu@gmail.com>
1606
1607 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1608 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1609
8bbbc977
EZ
16102012-06-08 Eli Zaretskii <eliz@gnu.org>
1611
1612 * alloc.c (allocate_vectorlike): Fix last change.
1613
f3372c87
DA
16142012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1615
1616 Block-based vector allocation of small vectors.
1617 * lisp.h (struct vectorlike_header): New field `nbytes',
1618 adjust comment accordingly.
1619 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1620 to denote vector blocks. Adjust users (live_vector_p,
1621 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1622 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1623 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1624 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1625 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1626 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1627 (roundup_size): New constant.
1628 (struct vector_block): New data type.
1629 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1630 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1631 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1632 (sweep_vectors): New functions.
1633 (allocate_vectorlike): Return `zero_vector' as the only vector of
1634 0 items. Allocate new vector from block if vector size is less than
1635 or equal to VBLOCK_BYTES_MAX.
1636 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1637 (init_alloc_once): Add call to init_vectors.
1638
4f18a4ed
SM
16392012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1640
1641 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1642
86f158bc
PE
16432012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1644
1645 * doprnt.c (doprnt): Truncate multibyte char correctly.
1646 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1647 would mishandle a string argument "Xc" if X was a multibyte
1648 character of length 2: it would truncate after X's first byte
1649 rather than including all of X.
1650
c5cfcbe0
CY
16512012-06-06 Chong Yidong <cyd@gnu.org>
1652
1653 * buffer.c (word_wrap): Doc fix.
1654
c05cf390
PE
16552012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1656
1657 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1658
0c3461de
GM
16592012-06-03 Glenn Morris <rgm@gnu.org>
1660
1661 * xdisp.c (tool-bar-style): Doc fix.
1662
c71232db
UM
16632012-06-03 Ulrich Müller <ulm@gentoo.org>
1664
1665 * Makefile.in (PAXCTL): Define.
1666 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1667 binary via PaX flags if the paxctl utility is available.
1668 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1669 Restore PaX flags to their default. (Bug#11398)
1670
383f7350
CY
16712012-06-03 Chong Yidong <cyd@gnu.org>
1672
1673 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1674 buffer (Bug#11226).
1675
5f2c76c6
CY
16762012-06-03 Chong Yidong <cyd@gnu.org>
1677
1678 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1679 (note_mode_line_or_margin_highlight): If there is no help echo,
1680 use mode-line-default-help-echo. Handle the case where the mouse
1681 position is past the end of the mode line string.
1682
1683 * buffer.c (buffer_local_value_1): New function, split from
1684 Fbuffer_local_value; can return Qunbound.
1685 (Fbuffer_local_value): Use it.
1686 (Vmode_line_format): Docstring tweaks.
1687
773d47f6
PE
16882012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1689
1690 * sysdep.c (system_process_attributes): Improve comment.
1691
f2d6a3df
SM
16922012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1693
1694 * keyboard.c: Export real-this-command to Elisp.
1695 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1696 and DEFVAR it. Update all users.
1697
63810350
PE
16982012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1699
7bd5c1f4
PE
1700 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1701
63810350
PE
1702 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1703 Convert pctcpu and pctmem to Lisp float properly.
1704 Let the compiler fold better, as 100.0/0x8000 is exact.
1705
a2821611
AS
17062012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1707
1708 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1709 cons_block.
1710
5fceba1d
PE
17112012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1712
1713 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1714
c98ff5dd
DA
17152012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1716
1717 For a 'struct window', replace some Lisp_Object fields to
1718 bitfields where appropriate, remove unused fields.
1719 * window.h (struct window): Remove unused 'last_mark_x' and
1720 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1721 change it's type from Lisp_Object to bitfield.
1722 Change type of 'force_start', 'optional_new_start',
1723 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1724 fields from Lisp_Object to bitfield. Adjust users accordingly.
1725
ca34e0be
PE
17262012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1727
1728 Pacify gcc -Wdouble-precision when using Xaw.
1729 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1730 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1731 Use 'float' consistently, rather than 'float' in most places
1732 and 'double' in a couple of places.
1733
efc00ab1 17342012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1735
1736 * xdisp.c (handle_stop): Detect whether we have overlay strings
1737 loaded by testing it->current.overlay_string_index to be
1738 non-negative, instead of checking whether n_overlay_strings is
1739 positive. (Bug#11587)
1740
efc00ab1 17412012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1742
1743 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1744
1745 * doc.c (Fsubstitute_command_keys): Doc fix.
1746
efc00ab1 17472012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1748
1749 * search.c (search_buffer): Remove calls to
1750 r_alloc_inhibit_buffer_relocation, as it is now called by
1751 maybe_unify_char, which was the cause of relocation of buffer text
1752 in bug#11519.
1753
efc00ab1 17542012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1755
1756 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1757 for the duration of call to load_charset, to avoid problems with
1758 callers of maybe_unify_char that access buffer text through C
1759 pointers.
1760
1761 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1762 decrement the inhibition flag, instead of just setting or
1763 resetting it.
1764
ba93a187
PE
17652012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1766
1767 Remove obsolete '#define static' cruft.
1768 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1769 This #undef was "temporary" in 2000; it is no longer needed
1770 now that '#define static' has gone away.
1771 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1772 (gray_bitmap_bits): Remove; no longer needed.
1773 All uses replaced with definiens.
1774 * xterm.c: Include "bitmaps/gray.xbm".
1775
9e4bf381
PE
17762012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1777
1778 Clean up __executable_start, monstartup when --enable-profiling.
1779 The following changes affect the code only when profiling.
1780 * dispnew.c (__executable_start): Rename from safe_bcopy.
1781 Define only on platforms that need it.
1782 * emacs.c: Include <sys/gmon.h> when profiling.
1783 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1784 (__executable_start): Remove decl, since lisp.h does it now.
1785 (safe_bcopy): Remove decl; no longer has that name.
1786 (main): Coalesce #if into single bit of code, for simplicity.
1787 Cast pointers to uintptr_t, since standard libraries want integers
1788 and not pointers.
1789 * lisp.h (__executable_start): New decl.
1790
32d72c2f
GM
17912012-05-31 Glenn Morris <rgm@gnu.org>
1792
1793 * image.c (Fimagemagick_types): Doc fix.
1794
baac5bc7
JM
17952012-05-30 Jim Meyering <meyering@redhat.com>
1796
1797 * callproc.c (Fcall_process_region): Include directory component
1798 in mkstemp error message (Bug#11586).
1799
72cb32cf
PE
18002012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1801
1802 * alloc.c, lisp.h (make_pure_vector): Now static.
1803
61b108cc
SM
18042012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1805
1806 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1807 Move to byte-run.el.
1808 (Fautoload): Do the hash-doc more carefully.
1809 * data.c (Fdefalias): Purify definition, except for keymaps.
1810 (Qdefun): Move from eval.c.
1811 * lisp.h (Qdefun): Remove.
1812 * lread.c (read1): Tiny simplification.
1813
471fe23d
TN
18142012-05-29 Troels Nielsen <bn.troels@gmail.com>
1815
934f3f58 1816 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1817 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1818 Bug#9642, but explicitly check that the buffer the overlay would
1819 be moved to is live and rearrange lines to make sure that errors
1820 will not put the overlay in an inconsistent state.
1821 (Fdelete_overlay): Cosmetics.
1822
85d0efd1
EZ
18232012-05-28 Eli Zaretskii <eliz@gnu.org>
1824
1825 * w32term.c (my_bring_window_to_top): New function.
1826 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1827 could be different from the original one.
1828 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1829 (Bug#11513)
1830
1831 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1832 by calling BringWindowToTop.
1833
1834 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1835 (WM_EMACS_END): Increase by one.
1836
da92a98c
PE
18372012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1838
1839 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1840 This avoids undefined behavior that might cause the eassert
1841 to not catch an out-of-range value.
1842
74d1f848
JB
18432012-05-28 Juanma Barranquero <lekktu@gmail.com>
1844
1845 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1846 Update dependencies.
1847
9e1a06fc
EZ
18482012-05-27 Eli Zaretskii <eliz@gnu.org>
1849
1850 * bidi.c (bidi_mirror_char): Fix last change.
1851
f3dd7312
AS
18522012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1853
1854 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1855 when referring to sectname field in printf format.
1856
81899c91
PE
18572012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1858
57b81a9f
PE
1859 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1860 Only r_alloc_inhibit_buffer_relocation needed to be added;
1861 the others were already declared.
1862
81899c91
PE
1863 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1864 before checking whether it's out of range. Put the check inside
1865 eassert. See
1866 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1867
33017faf 18682012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1869
1870 * callproc.c (Fcall_process): Restore a line that was accidentally
1871 commented out in the 2011-02-13 change (bug#11547).
1872
33017faf 18732012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1874
1875 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1876 defined on ralloc.c.
1877
1878 * buffer.c [REL_ALLOC]: Remove prototypes of
1879 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1880 they are now on lisp.h.
1881
1882 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1883
1884 * search.c (search_buffer): Use it to inhibit relocation of buffer
1885 text while re_search_2 is doing its job, because re_search_2 is
1886 passed C pointers to buffer text. (Bug#11519)
1887
23415acf
EZ
1888 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1889 Update value to 24.
1890
44e27368
EZ
1891 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1892 state after an additional call to move_it_in_display_line_to, keep
1893 the values of it->max_ascent and it->max_descent found for the
1894 entire line.
1895 (pos_visible_p): Revert the comparison against bottom_y to what it
1896 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1897 (Bug#11464)
1898
c1892f11
PE
18992012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1900
1901 Fix coding-related core dumps with gcc -ftrapv.
1902 The code was computing A - B, where A and B are pointers, and B is
1903 random garbage. This can lead to core dumps on platforms that
1904 have special pointer registers, and it also leads to core dumps on
1905 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1906 A - B only when B is initialized properly.
1907 * coding.c (coding_set_source, coding_set_destination): Return void.
1908 (coding_change_source, coding_change_destinations): New functions,
1909 with the old behaviors of coding_set_source and coding_set_destination.
1910 All callers that need an offset changed to use these new functions.
1911
eb7afdad
GM
19122012-05-26 Glenn Morris <rgm@gnu.org>
1913
1914 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1915
f12fdf02
EZ
19162012-05-26 Eli Zaretskii <eliz@gnu.org>
1917
53a63be6 1918 Extend mouse support on W32 text-mode console.
61b108cc
SM
1919 * xdisp.c (draw_row_with_mouse_face):
1920 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1921
eb3f6f01 1922 * w32console.c: Include window.h.
61b108cc
SM
1923 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1924 New functions.
eb3f6f01
EZ
1925 (initialize_w32_display): Initialize mouse-highlight data.
1926
53a63be6
EZ
1927 * w32inevt.c: Include termchar.h and window.h.
1928 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1929 moves, call note_mouse_highlight. If help_echo changed, call
1930 gen_help_event to produce help-echo message in the echo area.
1931 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1932 highlight info.
1933
4cfd81f6
PE
19342012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1935
1936 * lread.c (read1): Simplify slightly to avoid an overflow warning
1937 with GCC 4.7.0 on x86-64.
1938
4446092a
EZ
19392012-05-26 Eli Zaretskii <eliz@gnu.org>
1940
1941 * bidi.c (bidi_mirror_char): Revert last change: an int is
1942 definitely wide enough here.
1943
42b2a986 19442012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1945
42b2a986 1946 Fix integer width and related bugs (Bug#9874).
eb106a49 1947 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1948 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1949 (string_bytes, check_sblock, allocate_string_data):
1950 (compact_small_strings, Fmake_bool_vector, make_string)
1951 (make_unibyte_string, make_multibyte_string)
1952 (make_string_from_bytes, make_specified_string)
1953 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1954 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1955 (mark_vectorlike):
1956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1957 (allocate_pseudovector):
1958 Use int, not EMACS_INT, where int is wide enough.
1959 (inhibit_garbage_collection, Fgarbage_collect):
1960 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1961 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1962 int might not be wide enough.
1963 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1964 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1965 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1966 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1967 (bidi_level_of_next_char, bidi_move_to_visually_next):
1968 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1969 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1970 (Fkill_buffer, Fset_buffer_major_mode)
1971 (advance_to_char_boundary, Fbuffer_swap_text)
1972 (Fset_buffer_multibyte, overlays_at, overlays_in)
1973 (overlay_touches_p, struct sortvec, record_overlay_string)
1974 (overlay_strings, recenter_overlay_lists)
1975 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1976 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1977 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1978 (Foverlay_recenter, last_overlay_modification_hooks_used)
1979 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1980 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1981 (validate_region): Omit unnecessary test for b <= e,
1982 since that's guaranteed by the previous test.
d311d28c
PE
1983 (adjust_overlays_for_delete): Avoid pos + length overflow.
1984 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1985 (report_overlay_modification):
1986 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1987 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1988 Omit pointer cast, which isn't needed anyway, and doesn't work
1989 after the EMACS_INT -> ptrdiff_t change.
02481186 1990 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1991 * buffer.h: Adjust decls to match defn changes elsewhere.
1992 (struct buffer_text, struct buffer):
1993 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1994 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1995 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1996 not int, to avoid needless 32-bit limit on 64-bit hosts.
1997 (exec_byte_code): Use tighter memory-full test, one that checks
1998 for alloca overflow. Don't compute the address of the object just
1999 before an array, as that's not portable. Use EMACS_INT, not
2000 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2001 * callint.c (Fcall_interactively):
2002 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2003 * callproc.c (call_process_kill, Fcall_process):
2004 Don't assume pid_t fits into an Emacs fixnum.
2005 (call_process_cleanup, Fcall_process, child_setup):
2006 Don't assume pid_t fits into int.
2007 (call_process_cleanup, Fcall_process, delete_temp_file)
2008 (Fcall_process_region):
2009 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2010 (Fcall_process): Simplify handling of volatile integers.
2011 Use int, not EMACS_INT, where int will do.
2012 * casefiddle.c (casify_object, casify_region, operate_on_word)
2013 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2014 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2015 (casify_object): Avoid integer overflow when overallocating buffer.
2016 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2017 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2018 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2019 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2020 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2021 integers are now checked earlier. All uses replaced with XINT.
2022 (ccl_driver):
2023 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2024 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2025 (ccl_driver, Fregister_code_conversion_map):
2026 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2027 (resolve_symbol_ccl_program): Check that vector header is in range.
2028 Always copy the vector, so that we can check its contents reliably
2029 now rather than having to recheck each instruction as it's being
2030 executed. Check that vector words fit in 'int'.
2031 (ccl_get_compiled_code, Fregister_ccl_program)
2032 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2033 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2034 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2035 contents are in range.
2036 (Fccl_execute_on_string): Check that status is in range.
2037 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2038 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2039 Accept and return EMACS_INT, not int, because callers can pass values
2040 out of 'int' range.
2041 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2042 (multibyte_chars_in_text, parse_str_as_multibyte)
2043 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2044 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2045 (string_escape_byte8, Fget_byte):
2046 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2047 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2048 avoid mishandling large integers.
2049 * character.h: Adjust decls to match defn changes elsewhere.
2050 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2051 (Ffind_charset_region):
2052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2053 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2054 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2055 Don't assume fixnum fits in int.
d311d28c
PE
2056 (load_charset_map_from_vector, Fmap_charset_chars):
2057 Remove now-unnecessary CHECK_NATNUMs.
2058 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2059 Don't rely on undefined behavior with signed left shift overflow.
2060 Don't assume unsigned int fits into fixnum, or that fixnum fits
2061 into unsigned int. Don't require max_code to be a valid fixnum;
2062 that's not true for gb10830 4-byte on a 32-bit host. Allow
2063 invalid_code to be a cons, for the same reason. Require code_offset
2064 to be a character. Avoid int overflow if max_char is close
2065 to INT_MAX.
2066 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2067 this is intended anyway and avoids some undefined behavior.
2068 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2069 INDEX_TO_CODE_POINT, as that's what it expects.
2070 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2071 * charset.h (DECODE_CHAR): Return int, not unsigned;
2072 this is what was intended anyway, and it avoids undefined behavior.
2073 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2074 integer-overflow issues.
2075 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2076 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2077 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2078 * chartab.c (Fmake_char_table, Fset_char_table_range)
2079 (uniprop_get_decoder, uniprop_get_encoder):
2080 Don't assume fixnum fits in int.
2081 * cmds.c (move_point): New function, that does the gist of
2082 Fforward_char and Fbackward_char, but does so while checking
2083 for integer overflow more accurately.
c96e5d6a 2084 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2085 (Fforward_line, Fend_of_line, internal_self_insert)
2086 (internal_self_insert):
2087 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2088 Fix a FIXME, by checking for integer overflow when calculating
2089 target_clm and actual_clm.
2090 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2091 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2092 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2093 (coding_alloc_by_making_gap, alloc_destination)
2094 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2095 (encode_coding_utf_16, detect_coding_emacs_mule)
2096 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2097 (detect_coding_iso_2022, decode_coding_iso_2022)
2098 (encode_invocation_designation, encode_designation_at_bol)
2099 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2100 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2101 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2102 (encode_coding_ccl, encode_coding_raw_text)
2103 (detect_coding_charset, decode_coding_charset)
2104 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2105 (produce_composition, produce_charset, produce_annotation)
2106 (decode_coding, handle_composition_annotation)
2107 (handle_charset_annotation, consume_chars, decode_coding_gap)
2108 (decode_coding_object, encode_coding_object, detect_coding_system)
2109 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2110 (code_convert_region, code_convert_string)
8f50130c
PE
2111 (Fdefine_coding_system_internal)
2112 (coding_set_source, coding_set_destination):
d311d28c
PE
2113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2114 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2115 (Fdefine_coding_system_internal):
2116 Don't assume fixnums fit in int.
2117 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2118 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2119 (Funencodable_char_position, Fcheck_coding_systems_region)
2120 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2121 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2122 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2123 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2124 Don't access memory outside of the args array.
d311d28c 2125 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2126 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2127 result of ENCODE_CHAR.
d311d28c
PE
2128 * coding.h: Adjust decls to match defn changes elsewhere.
2129 (struct coding_system):
2130 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2131 * composite.c (get_composition_id, find_composition)
2132 (run_composition_function, update_compositions)
2133 (compose_text, composition_gstring_put_cache)
2134 (composition_gstring_p, composition_gstring_width)
2135 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2136 (composition_compute_stop_pos, composition_reseat_it)
2137 (composition_update_it, struct position_record)
2138 (find_automatic_composition, composition_adjust_point)
2139 (Fcomposition_get_gstring, Ffind_composition_internal):
2140 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2141 (update_compositions):
2142 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2143 * composite.h: Adjust decls to match defn changes elsewhere.
2144 (struct composition):
2145 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2146 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2147 Do not attempt to compute the address of the object just before a
2148 buffer; this is not portable.
2149 (Faref, Faset):
2150 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2151 (Faset): Use int, not EMACS_INT, where int is wide enough.
2152 (Fstring_to_number): Don't assume fixnums fit in int.
2153 (Frem): Don't assume arg is nonnegative.
2154 * dbusbind.c (xd_append_arg): Check for integers out of range.
2155 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2156 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2157 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2158 (xd_get_connection_references): Return ptrdiff_t, not int.
2159 All uses changed.
2160 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2161 (xd_read_message_1):
2162 Use int, not unsigned, where the dbus API uses int.
2163 (Fdbus_message_internal): Don't overflow mtype.
2164 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2165 * dired.c (directory_files_internal, file_name_completion, scmp)
2166 (file_name_completion_stat):
2167 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2168 (file_name_completion): Don't overflow matchcount.
2169 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2170 * dispextern.h: Adjust decls to match defn changes elsewhere.
2171 (struct text_pos, struct glyph, struct bidi_saved_info)
2172 (struct bidi_string_data, struct bidi_it, struct composition_it)
2173 (struct it):
2174 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2175 (struct display_pos, struct composition_it, struct it):
2176 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2177 * dispnew.c (increment_matrix_positions)
2178 (increment_row_positions, mode_line_string)
2179 (marginal_area_string):
2180 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2181 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2182 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2183 (duration_to_sec_usec): New function, to check for overflow better.
2184 (Fsleep_for, sit_for): Use it.
2185 * doc.c (get_doc_string, store_function_docstring):
2186 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2187 (get_doc_string, Fsnarf_documentation):
2188 Use int, not EMACS_INT, where int is wide enough.
2189 (get_doc_string):
2190 Use SAFE_ALLOCA, not alloca.
2191 Check for overflow when converting EMACS_INT to off_t.
2192 * doprnt.c (doprnt):
2193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2194 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2195 Don't assume uid_t fits into fixnum.
2196 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2197 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2198 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2199 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2200 (general_insert_function)
2201 (Finsert_char, make_buffer_string, make_buffer_string_both)
2202 (update_buffer_properties, Fbuffer_substring)
2203 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2204 (Fsubst_char_in_region, check_translation)
2205 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2206 (transpose_markers, Ftranspose_regions):
2207 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2208 (clip_to_bounds): Move to lisp.h as an inline function).
2209 (Fconstrain_to_field): Don't assume integers are nonnegative.
2210 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2211 (Fsubst_char_in_region, Fsave_restriction):
2212 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2213 (Femacs_pid): Don't assume pid_t fits into fixnum.
2214 (lo_time): Use int, not EMACS_INT, when int suffices.
2215 (lisp_time_argument): Check for usec out of range.
2216 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2217 (Fuser_login_name, Fuser_full_name): Signal an error
2218 if a uid argument is out of range, rather than relying on
2219 undefined behavior.
c8d5c857
PE
2220 (Fformat_time_string): Remove now-unnecessary check.
2221 lisp_time_argument checks for out-of-range usec now.
243e0530 2222 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2223 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2224 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2225 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2226 (init_cmdargs, Fdump_emacs):
2227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2228 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2229 the bottom (typically) 32 bits of the fixnum.
2230 * eval.c (specpdl_size, call_debugger):
2231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2232 (when_entered_debugger, Fbacktrace_debug):
2233 Don't assume fixnum can fit in int.
2234 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2235 the object just before a buffer; this is not portable.
2236 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2237 (grow_specpdl, unbind_to):
2238 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2239 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2240 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2241 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2242 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2243 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2244 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2245 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2246 (a_write, e_write):
2247 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2248 (Fcopy_file, non_regular_nbytes, read_non_regular)
2249 (Finsert_file_contents):
2250 Use int, not EMACS_INT, where int is wide enough.
2251 (READ_BUF_SIZE): Verify that it fits in int.
2252 (Finsert_file_contents): Check that counts are in proper range,
2253 rather than assuming fixnums fit into ptrdiff_t etc.
2254 Don't assume fixnums fit into int.
125b3835 2255 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2256 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2257 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2258 (string_char_to_byte, string_byte_to_char)
2259 (string_make_multibyte, string_to_multibyte)
2260 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2261 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2262 (substring_both, Fdelete, internal_equal, Ffillarray)
2263 (Fclear_string, mapcar1)
2264 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2265 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2266 (larger_vector, make_hash_table, maybe_resize_hash_table)
2267 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2268 (Fmaphash, secure_hash):
2269 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2270 (concat): Check for string index and length overflow.
2271 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2272 (Frequire):
2273 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2274 (larger_vector): New API (vec, incr_min, size_max) replaces old
2275 one (vec, new_size, init). This catches size overflow.
2276 INIT was removed because it was always Qnil.
2277 All callers changed.
2278 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2279 the upper bound on a hash table index size.
2280 (make_hash_table, maybe_resize_hash_table): Use it.
2281 (secure_hash): Computer start_byte and end_byte only after
2282 they're known to be in ptrdiff_t range.
2283 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2284 (Ffont_get_glyphs, Ffont_at):
2285 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2286 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2287 (Flist_fonts, Fopen_font):
2288 Don't assume fixnum can fit in int.
2289 (check_gstring): Don't assume index can fit in int.
2290 (font_match_p): Check that fixnum is a character, not a nonnegative
2291 fixnum, since the later code needs to stuff it into an int.
2292 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2293 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2294 conversion overflow issues.
2295 (Fopen_font): Check for integer out of range.
2296 (Ffont_get_glyphs): Don't assume index can fit in int.
2297 * font.h: Adjust decls to match defn changes elsewhere.
2298 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2299 integer overflow.
2300 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2301 printmax_t, where ptrdiff_t is wide enough.
2302 (Finternal_char_font):
2303 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2304 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2305 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2306 (Fset_frame_position, x_set_frame_parameters)
2307 (x_set_line_spacing, x_set_border_width)
2308 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2309 Check that fixnums are in proper range for system types.
2310 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2311 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2312 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2313 Use SAFE_ALLOCA_LISP, not alloca.
2314 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2315 intptr_t is wide enough.
2316 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2317 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2318 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2319 Check for fixnum out of range.
2320 * ftfont.c (ftfont_list): Don't assume index fits in int.
2321 Check that fixnums are in proper range for system types.
2322 (ftfont_shape_by_flt):
2323 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2324 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2325 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2326 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2327 Check that fixnums are in proper range for system types.
2328 * gnutls.h: Adjust decls to match defn changes elsewhere.
2329 * gtkutil.c (xg_dialog_run):
2330 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2331 (update_frame_tool_bar):
2332 Check that fixnums are in proper range for system types.
2333 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2334 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2335 * indent.c (last_known_column, last_known_column_point):
2336 (current_column_bol_cache):
2337 (skip_invisible, current_column, check_display_width):
2338 (check_display_width, scan_for_column, current_column_1)
2339 (Findent_to, Fcurrent_indentation, position_indentation)
2340 (indented_beyond_p, Fmove_to_column, compute_motion):
2341 (Fcompute_motion, Fvertical_motion):
2342 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2343 (last_known_column_modified): Use EMACS_INT, not int.
2344 (check_display_width):
2345 (Fcompute_motion):
2346 Check that fixnums and floats are in proper range for system types.
2347 (compute_motion): Don't assume index or fixnum fits in int.
2348 (compute_motion, Fcompute_motion):
2349 Use int, not EMACS_INT, when it is wide enough.
2350 (vmotion): Omit local var start_hpos that is always 0; that way
2351 we don't need to worry about overflow in expressions involving it.
2352 * indent.h: Adjust decls to match defn changes elsewhere.
2353 (struct position):
2354 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2355 Use int, not EMACS_INT, where int is wide enough.
2356 Remove unused members ovstring_chars_done and tab_offset;
2357 all uses removed.
2358 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2359 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2360 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2361 (make_gap, copy_text, insert, insert_and_inherit)
2362 (insert_before_markers, insert_before_markers_and_inherit)
2363 (insert_1, count_combining_before, count_combining_after)
2364 (insert_1_both, insert_from_string)
2365 (insert_from_string_before_markers, insert_from_string_1)
2366 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2367 (adjust_after_replace, adjust_after_insert, replace_range)
2368 (replace_range_2, del_range, del_range_1, del_range_byte)
2369 (del_range_both, del_range_2, modify_region)
2370 (prepare_to_modify_buffer, signal_before_change)
2371 (signal_after_change, Fcombine_after_change_execute):
2372 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2373 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2374 (balance_an_interval, split_interval_right, split_interval_left)
2375 (find_interval, next_interval, update_interval)
2376 (adjust_intervals_for_insertion, delete_node, delete_interval)
2377 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2378 (static_offset_intervals, offset_intervals)
2379 (merge_interval_right, merge_interval_left, make_new_interval)
2380 (graft_intervals_into_buffer, temp_set_point_both)
2381 (temp_set_point, set_point, adjust_for_invis_intang)
2382 (set_point_both, move_if_not_intangible, get_property_and_range)
2383 (get_local_map, copy_intervals, copy_intervals_to_string)
2384 (compare_string_intervals, set_intervals_multibyte_1):
2385 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2386 * intervals.h: Adjust decls to match defn changes elsewhere.
2387 (struct interval):
2388 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2389 * keyboard.c (this_command_key_count, this_single_command_key_start)
2390 (before_command_key_count, before_command_echo_length, echo_now)
2391 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2392 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2393 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2394 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2395 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2396 (last_non_minibuf_size, last_point_position, echo_truncate)
2397 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2398 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2399 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2400 (stuff_buffered_input):
2401 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2402 (last_auto_save, command_loop_1, read_char):
2403 Use EMACS_INT, not int, to avoid integer overflow.
2404 (record_char): Avoid overflow in total_keys computation.
2405 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2406 * keyboard.h: Adjust decls to match defn changes elsewhere.
2407 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2408 (Fkey_description, Fdescribe_vector, Flookup_key):
2409 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2410 (click_position): New function, to check that positions are in range.
2411 (Fcurrent_active_maps):
2412 (describe_command):
2413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2414 (Faccessible_keymaps, Fkey_description):
2415 (preferred_sequence_p):
2416 Don't assume fixnum can fit into int.
2417 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2418 Check for integer overflow in size calculations.
2419 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2420 avoid mishandling large integers.
2421 * lisp.h: Adjust decls to match defn changes elsewhere.
2422 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2423 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2424 (struct Lisp_Marker):
2425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2426 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2427 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2428 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2429 All callers changed.
2430 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2431 Assume the arg has valid form, since it always does.
2432 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2433 unsigned integer system type.
2434 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2435 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2436 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2437 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2438 (duration_to_sec_usec): New decl.
2439 * lread.c (read_from_string_index, read_from_string_index_byte)
2440 (read_from_string_limit, readchar, unreadchar, openp)
2441 (read_internal_start, read1, oblookup):
2442 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2443 (Fload, readevalloop, Feval_buffer, Feval_region):
2444 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2445 (openp): Check for out-of-range argument to 'access'.
2446 (read1): Use int, not EMACS_INT, where int is wide enough.
2447 Don't assume fixnum fits into int.
6efdadfd 2448 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2449 (read_filtered_event): Use duration_to_sec_usec
2450 to do proper overflow checking on durations.
d311d28c
PE
2451 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2452 in size calculation.
2453 (Fexecute_kbd_macro):
2454 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2455 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2456 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2457 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2458 (set_marker_both, set_marker_restricted_both, marker_position)
2459 (marker_byte_position, Fbuffer_has_markers_at):
2460 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2461 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2462 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2463 It now merely ensures that the menu is large enough, without
2464 necessarily growing it, as this avoids some integer overflow issues.
2465 All callers changed.
2466 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2468 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2469 Use SAFE_ALLOCA_LISP, not alloca.
2470 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2471 to EMACS_INT. Check that fixnums are in proper range for system types.
2472 * minibuf.c (minibuf_prompt_width, string_to_object)
2473 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2474 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2476 (get_minibuffer, read_minibuf_unwind):
2477 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2478 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2479 this simplifies overflow checking. All callers changed.
2480 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2481 (Ftest_completion):
2482 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2483 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2484 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2485 Check that fixnums are in proper range for system types.
2486 (Fx_create_frame, Fx_show_tip):
2487 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2488 * nsfont.m (ns_findfonts, nsfont_list_family):
2489 Don't assume fixnum fits in long.
2490 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2491 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2492 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2493 wide enough.
17fdb222 2494 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2495 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2496 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2497 (PRINTDECLARE, PRINTPREPARE):
2498 (strout, print_string):
2499 (print, print_preprocess, print_check_string_charset_prop)
2500 (print_object):
2501 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2502 (PRINTDECLARE):
2503 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2504 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2505 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2506 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2507 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2508 (print_error_message): Use SAFE_ALLOCA, not alloca.
2509 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2510 (print_depth, new_backquote_output, print_number_index):
2511 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2512 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2513 (Fset_process_window_size, Fformat_network_address)
2514 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2515 (sigchld_handler):
d311d28c 2516 Check that fixnums are in proper range for system types.
d44287d4 2517 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2518 Check for process-ids out of pid_t range rather than relying on
2519 undefined behavior.
e4d81efc 2520 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2521 (Fformat_network_address, read_process_output, send_process)
2522 (Fprocess_send_region, status_notify):
2523 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2524 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2525 (wait_reading_process_output, read_process_output, exec_sentinel):
2526 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2527 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2528 (Faccept_process_output): Use duration_to_sec_usec to do proper
2529 overflow checking on durations.
dde14581
PE
2530 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2531 Don't assume pid_t fits in int.
02481186
PE
2532 * process.h (struct Lisp_Process): Members tick and update_tick
2533 are now of type EMACS_INT, not int.
b62b53e8
PE
2534 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2535 configured --with-wide-int.
d311d28c
PE
2536 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2537 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2538 * search.c (looking_at_1, string_match_1):
2539 (fast_string_match, fast_c_string_match_ignore_case)
2540 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2541 (scan_newline, find_before_next_newline, search_command)
2542 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2543 (set_search_regs, wordify):
2544 (Freplace_match):
2545 (Fmatch_data):
2546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2547 (string_match_1, search_buffer, set_search_regs):
2548 (Fmatch_data):
2549 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2550 (wordify): Check for overflow in size calculation.
2551 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2552 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2553 Check that fixnums are in proper range for system types.
2554 * sound.c (struct sound_device)
2555 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2556 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2557 (Fplay_sound_internal):
2558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2559 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2560 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2561 (Fparse_partial_sexp):
2562 Don't assume fixnums can fit in int.
2563 (struct lisp_parse_state, find_start_pos, find_start_value)
2564 (find_start_value_byte, find_start_begv)
2565 (update_syntax_table, char_quoted, dec_bytepos)
2566 (find_defun_start, prev_char_comend_first, back_comment):
2567 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2568 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2569 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2570 (Finternal_describe_syntax_value): Check that match_lisp is a
2571 character, not an integer, since the code stuffs it into int.
2572 (scan_words, scan_sexps_forward):
2573 Check that fixnums are in proper range for system types.
2574 (Fforward_word):
2575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2576 (scan_sexps_forward):
2577 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2578 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2579 * syntax.h: Adjust decls to match defn changes elsewhere.
2580 (struct gl_state_s):
2581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2582 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2583 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2584 * sysdep.c (wait_for_termination_1, wait_for_termination)
2585 (interruptible_wait_for_termination, mkdir):
2586 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2587 (emacs_read, emacs_write):
2588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2589 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2590 and double all fit in int.
d311d28c
PE
2591 * term.c (set_tty_color_mode):
2592 Check that fixnums are in proper range for system types.
2593 * termhooks.h (struct input_event):
2594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2595 * textprop.c (validate_interval_range, interval_of)
2596 (Fadd_text_properties, set_text_properties_1)
2597 (Fremove_text_properties, Fremove_list_of_text_properties)
2598 (Ftext_property_any, Ftext_property_not_all)
2599 (copy_text_properties, text_property_list, extend_property_ranges)
2600 (verify_interval_modification):
2601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2602 (Fnext_single_char_property_change)
2603 (Fprevious_single_char_property_change):
2604 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2605 (copy_text_properties):
2606 Check for integer overflow in index calculation.
d311d28c
PE
2607 * undo.c (last_boundary_position, record_point, record_insert)
2608 (record_delete, record_marker_adjustment, record_change)
2609 (record_property_change):
2610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2611 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2613 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2614 (Fx_hide_tip, Fx_file_dialog):
2615 * w32menu.c (set_frame_menubar):
2616 Use ptrdiff_t, not int, for consistency with rest of code.
2617 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2618 (select_window, Fdelete_other_windows_internal)
2619 (window_scroll_pixel_based, window_scroll_line_based)
2620 (Frecenter, Fset_window_configuration):
2621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2622 (Fset_window_hscroll, run_window_configuration_change_hook)
2623 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2624 (Fscroll_other_window, Frecenter):
d311d28c
PE
2625 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2626 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2627 Don't assume fixnum fits in int.
2628 (Fset_window_scroll_bars):
2629 Check that fixnums are in proper range for system types.
2630 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2631 (string_pos, c_string_pos, number_of_chars, init_iterator)
2632 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2633 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2634 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2635 (face_before_or_after_it_pos, handle_invisible_prop)
2636 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2637 (display_prop_intangible_p, string_buffer_position_lim)
2638 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2639 (get_overlay_strings_1, get_overlay_strings)
2640 (iterate_out_of_display_property, forward_to_next_line_start)
2641 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2642 (get_next_display_element, set_iterator_to_next)
2643 (get_visually_first_element, compute_stop_pos_backwards)
2644 (handle_stop_backwards, next_element_from_buffer)
2645 (move_it_in_display_line_to, move_it_in_display_line)
2646 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2647 (add_to_log, message_dolog, message_log_check_duplicate)
2648 (message2, message2_nolog, message3, message3_nolog
2649 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2650 (current_message_1, truncate_echo_area, truncate_message_1)
2651 (set_message, set_message_1, store_mode_line_noprop)
2652 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2653 (text_outside_line_unchanged_p, check_point_in_composition)
2654 (reconsider_clip_changes)
2655 (redisplay_internal, set_cursor_from_row, try_scrolling)
2656 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2657 (redisplay_window, find_last_unchanged_at_beg_row)
2658 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2659 (trailing_whitespace_p, find_row_edges, display_line)
2660 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2661 (display_mode_element, store_mode_line_string)
2662 (pint2str, pint2hrstr, decode_mode_spec)
2663 (display_count_lines, display_string, draw_glyphs)
2664 (x_produce_glyphs, x_insert_glyphs)
2665 (rows_from_pos_range, mouse_face_from_buffer_pos)
2666 (fast_find_string_pos, mouse_face_from_string_pos)
2667 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2669 (safe_call, init_from_display_pos, handle_fontified_prop)
2670 (handle_single_display_spec, load_overlay_strings)
2671 (with_echo_area_buffer, setup_echo_area_for_printing)
2672 (display_echo_area, echo_area_display)
2673 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2674 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2675 (redisplay_window, dump_glyph_row, display_mode_line)
2676 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2677 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2678 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2679 (handle_single_display_spec, build_desired_tool_bar_string)
2680 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2681 (get_specified_cursor_type):
2682 Check that fixnums are in proper range for system types.
2683 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2684 (Flookup_image_map):
2685 Don't assume fixnums fit in int.
2686 (compare_overlay_entries):
2687 Avoid mishandling comparisons due to subtraction overflow.
2688 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2689 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2690 (handle_tool_bar_click):
2691 Use int, not unsigned, since we prefer signed and the signedness
2692 doesn't matter here.
2693 (get_next_display_element, next_element_from_display_vector):
2694 Use int, not EMACS_INT, when int is wide enough.
2695 (start_hourglass): Use duration_to_sec_usec to do proper
2696 overflow checking on durations.
2697 * xfaces.c (Fbitmap_spec_p):
2698 Check that fixnums are in proper range for system types.
2699 (compare_fonts_by_sort_order):
2700 Avoid mishandling comparisons due to subtraction overflow.
2701 (Fx_family_fonts, realize_basic_faces):
2702 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2703 (Fx_family_fonts):
2704 Don't assume fixnum fits in int.
2705 Use SAFE_ALLOCA_LISP, not alloca.
2706 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2707 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2708 (face_at_buffer_position, face_for_overlay_string)
2709 (face_at_string_position):
2710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2711 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2712 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2713 (Fx_show_tip):
2714 Check that fixnums are in proper range for system types.
2715 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2716 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2718 (Fx_change_window_property): Don't assume fixnums fit in int.
2719 * xfont.c (xfont_chars_supported):
2720 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2721 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2722 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2723 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2724 * xml.c (parse_region):
2725 * xrdb.c (magic_file_p):
2726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2727 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2728 (x_get_local_selection, x_reply_selection_request)
2729 (x_handle_selection_request, wait_for_property_change):
2730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2731 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2732 short is wide enough.
2733 (x_send_client_event): Don't assume fixnum fits in int.
2734 * xterm.c (x_x_to_emacs_modifiers):
2735 Don't assume EMACS_INT overflows nicely into int.
2736 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2737 may come from Lisp.
2738 (handle_one_xevent): NATNUMP can eval its arg twice.
2739 (x_connection_closed):
2740 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2741 * xterm.h: Adjust decls to match defn changes elsewhere.
2742 (struct scroll_bar): Use struct vectorlike_header
2743 rather than rolling our own approximation.
2744 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2745
c6574eb5
GM
27462012-05-25 Glenn Morris <rgm@gnu.org>
2747
2748 * lisp.mk (lisp): Update for more files being compiled now.
2749
e8d32c7e
SM
27502012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2751
48def666
SM
2752 * lread.c: Remove `read_pure' which makes no difference.
2753 (read_pure): Remove var.
2754 (unreadpure): Remove function.
2755 (readevalloop): Don't call read_list with -1 flag.
2756 (read1, read_vector): Don't test read_pure any more.
2757 (read_list): Simplify.
2758
e8d32c7e
SM
2759 * fileio.c, character.h: Minor style tweaks.
2760
4b2addb7
DA
27612012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2762
2763 * window.h (clip_changed): Remove useless declaration.
2764
584461b2
JB
27652012-05-22 Juanma Barranquero <lekktu@gmail.com>
2766
2767 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2768 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2769
34374650
PE
27702012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2771
2772 Remove src/m/*.
2773 This directory predates autoconf and is no longer needed nowadays.
2774 Move its few remaining bits of functionality to where they're needed.
2775 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2776 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2777 * m/template.h: Remove.
2778 * Makefile.in (M_FILE): Remove. All uses removed.
2779 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2780 * lisp.h (USE_LSB_TAG):
2781 * mem-limits.h (EXCEEDS_LISP_PTR):
2782 Use VAL_MAX, not VALBITS, in #if.
2783 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2784 (EMACS_UINT): Define unconditionally now.
2785 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2786 (BITS_PER_EMACS_INT): New constants, replacing
2787 what used to be in config.h, but not useful in #if.
2788 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2789 define them any more.
2790 (VAL_MAX): New macro.
2791 (VALMASK): Use it.
2792 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2793 BITS_PER_EMACS_INT, in #if.
2794 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2795 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2796 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2797 * s/ms-w32.h (DATA_START):
2798 Move here from removed file m/intel386.h.
2799 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2800 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2801
261cb4bb
PE
28022012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2803
2804 Assume C89 or later.
2805 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2806 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2807 (xrealloc):
2808 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2809 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2810 * textprop.c, tparam.c (NULL): Remove.
2811 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2812 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2813 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2814 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2815 * xterm.c (input_signal_count): Assume volatile works.
2816
ff23cd9f
KB
28172012-05-21 Ken Brown <kbrown@cornell.edu>
2818
2819 * xgselect.c (xg_select): Fix first argument in call to 'select'
2820 (bug#11508).
2821
1b170bc6
KB
28222012-05-20 Ken Brown <kbrown@cornell.edu>
2823
2824 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2825 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2826
b2f4d39f
KB
28272012-05-19 Ken Brown <kbrown@cornell.edu>
2828
2829 * xfns.c (x_in_use): Remove `static' qualifier.
2830 * xterm.h (x_in_use): Declare.
2831 * xgselect.c: Include xterm.h.
2832 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2833 and `display_arg' (bug#9754).
2834
003fdae2
PE
28352012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2836
9232a6d9
PE
2837 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2838
003fdae2
PE
2839 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2840 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2841
784b56e2
EZ
28422012-05-18 Eli Zaretskii <eliz@gnu.org>
2843
2844 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2845
2846 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 2847 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
2848
2849 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2850 reference to image_cache->refcount.
2851 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2852
a0a79cde
JL
28532012-05-17 Juri Linkov <juri@jurta.org>
2854
2855 * search.c (Fword_search_regexp, Fword_search_backward)
2856 (Fword_search_forward, Fword_search_backward_lax)
2857 (Fword_search_forward_lax): Move functions to isearch.el
2858 (bug#10145, bug#11381).
2859
b0572523
PE
28602012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2861
2862 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2863
9660f5fc
SM
28642012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2865
2866 * lread.c (init_obarray): Declare Qt and Qnil as special.
2867
4374de83
GM
28682012-05-14 Glenn Morris <rgm@gnu.org>
2869
2870 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2871 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2872
dc44c39a
PE
28732012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2874
078c97cb
PE
2875 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2876
dc44c39a
PE
2877 * unexaix.c: Port to more-recent AIX compilers.
2878 (report_error, report_error_1, make_hdr, copy_sym)
2879 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2880 Make arguments const char *, not char *, to avoid violations of C
2881 standard and to fix some AIX warnings reported by Gilles Pion.
2882
e18afed7 28832012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2884
2885 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2886 already have overlays loaded.
2887 (handle_single_display_spec): Before returning without displaying
2888 fringe bitmap, synchronize the bidi iterator with the main display
2889 iterator, by calling iterate_out_of_display_property.
2890 (iterate_out_of_display_property): Detect buffer iteration by
2891 testing that it->string is a Lisp string.
2892 (get_next_display_element): When the current object is exhausted,
2893 and there's something on it->stack, call set_iterator_to_next to
2894 proceed with what's on the stack, instead of returning zero.
2895 (set_iterator_to_next): If called at the end of a Lisp string,
2896 proceed to consider_string_end without incrementing string
2897 position. Don't increment display vector index past the end of
2898 the display vector. (Bug#11417)
c8fb9dc6
EZ
2899 (pos_visible_p): Don't report a position visible when move_it_to
2900 stopped at the last line of window, which happens to be scanned
2901 backwards by the bidi iteration. (Bug#11464)
ac268e67 2902
e18afed7 29032012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2904
2905 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2906 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2907 are on a TTY, and thus unable to display on the fringes.
2908 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2909 so we need to signal to the caller that this is a "replacing"
2910 display spec. This fixes display when the spec is invalid or we
2911 are on a TTY.
2912
e18afed7 29132012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2914
2915 * unexaix.c (make_hdr): Fix typo in prototype.
2916 This bug broke the build on AIX. Problem reported by Gilles Pion.
2917
9d0a235a
MA
29182012-05-14 Michael Albinus <michael.albinus@gmx.de>
2919
2920 * keyboard.c (kbd_buffer_get_event): Read special events also in
2921 batch mode. (Bug#11415)
2922
9e6b06ed
GM
29232012-05-12 Glenn Morris <rgm@gnu.org>
2924
2925 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2926
c1a1d7a3
EZ
29272012-05-12 Eli Zaretskii <eliz@gnu.org>
2928
2929 * lisp.mk (lisp): Add newcomment.elc.
2930
3fe7cdc8
GM
29312012-05-12 Glenn Morris <rgm@gnu.org>
2932
2933 * Makefile.in (MKDIR_P): New, set by configure.
2934 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2935
53f7d2c0
PE
29362012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2937
2938 Remove unused function hourglass_started.
2939 * dispextern.h (hourglass_started):
2940 * w32fns.c (hourglass_started):
2941 * xdisp.c (hourglass_started): Remove.
2942
75aafb17
JB
29432012-05-10 Juanma Barranquero <lekktu@gmail.com>
2944
2945 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2946 Update dependencies.
2947
12959e8e
PE
29482012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2949
97107e2e
PE
2950 * xgselect.c (xg_select): Put maxfds+1 into a var.
2951 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2952
12959e8e
PE
2953 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2954
836d29b3
DA
29552012-05-10 Dave Abrahams <dave@boostpro.com>
2956
2957 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2958 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2959
5cb67954
MA
29602012-05-09 Michael Albinus <michael.albinus@gmx.de>
2961
2962 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2963 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2964 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2965 Initialize xd_registered_buses.
2966
3478ec45
PE
29672012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2968
b263a6b0
PE
2969 Untag more efficiently if USE_LSB_TAG.
2970 This is based on a proposal by YAMAMOTO Mitsuharu in
2971 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2972 For an admittedly artificial (nth 8000 longlist) benchmark on
2973 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2974 Emacs's overall text size by 1%.
2975 * lisp.h (XUNTAG): New macro.
2976 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2977 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2978 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2979 * eval.c (Fautoload):
2980 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2981 * frame.h (XFRAME): Use XUNTAG.
2982
3478ec45
PE
2983 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2984 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2985 Remove unportable assumptions about print widths of types like
2986 dbus_uint32_t.
2987 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2988 intptr_t when converting between pointer and integer, to avoid GCC
2989 warnings about wrong width.
2990
666b903b 29912012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2992
2993 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2994 stack for each reader_thread, instead of defaulting to 8MB
2995 determined by the linker. This avoids failures in creating
2996 subprocesses on Windows 7, see the discussion in this thread:
2997 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2998
b120cc17
JC
29992012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3000
3001 Fix up display of the *Minibuf-0* buffer in the mini window.
3002 * keyboard.c (read_char): Don't clear the echo area if there's no
3003 message to clear.
3004 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3005 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3006
9a4b36f8
MA
30072012-05-07 Michael Albinus <michael.albinus@gmx.de>
3008
3009 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3010 batch mode.
3011
e5f9458f
CY
30122012-05-06 Chong Yidong <cyd@gnu.org>
3013
3014 * lisp.mk (lisp): Update.
3015
eceeb5fc 30162012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3017
3018 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3019
71873e2b
SM
30202012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3021
3022 * data.c (PUT_ERROR): New macro.
3023 (syms_of_data): Use it. Add new error type `user-error'.
3024 * undo.c (user_error): New function.
3025 (Fprimitive_undo): Use it.
3026 * print.c (print_error_message): Adjust print style for `user-error'.
3027 * keyboard.c (user_error): New function.
3028 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3029
ab0fa4e4
PE
30302012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3031
3032 Do not limit current-time-string to years 1000..9999.
3033 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3034 (Fcurrent_time_string): Support any year that is supported by the
3035 underlying localtime representation. Don't use asctime, as it
3036 has undefined behavior for years outside the range -999..9999.
3037
7ed806a7
PE
30382012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3039
3040 Fix race conditions involving setenv, gmtime, localtime, asctime.
3041 Without this fix, interrupts could mess up code that uses these
3042 nonreentrant functions, since setting TZ invalidates existing
3043 tm_zone or tzname values, and since most of these functions return
3044 pointers to static storage.
3045 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3046 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3047 Grow the critical sections to include not just invoking
3048 localtime/gmtime, but also accessing these functions' results
3049 including their tm_zone values if any, and any related TZ setting.
3050 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3051 so that the struct tm is saved in the critical section.
3052 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3053 motivated by the fact that memory allocation needs to be outside
3054 the critical section.
3055
0c16dfed
DA
30562012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3057
3058 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3059 with RESET_INTERVAL.
3060
3061 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3062 Remove duplicated buffer name initialization.
3063
3f83ace8
JM
30642012-05-02 Jim Meyering <jim@meyering.net>
3065
3066 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3067
c7b8541e
JM
3068 * xfns.c (x_window): Use xstrdup (Bug#11375).
3069
90207a15 30702012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3071
3072 * xdisp.c (pos_visible_p): If already at a newline from the
3073 display string before the 'while' loop, don't walk back the glyphs
3074 from it3.glyph_row. Solves assertion violation when the display
3075 string begins with a newline (egg.el). (Bug#11367)
3076
b593d6a9
AH
30772012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3078
3079 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3080 Move to simple.el.
3081
4737362e
GM
30822012-05-01 Glenn Morris <rgm@gnu.org>
3083
99cf43f9
GM
3084 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3085 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3086 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3087 All were removed before 23.1.
3088
9311dcff
GM
3089 * dispnew.c: Remove HAVE_LIBNCURSES test;
3090 it is always true on relevant platforms.
3091
4d5c6349
GM
3092 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3093 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3094
4737362e
GM
3095 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3096
74dd3a6b
AS
30972012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3098
3099 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3100 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3101 Remove.
3102
13c379ee
PE
31032012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3104
3105 Do not avoid creating empty evaporating overlays (Bug#9642).
3106 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3107 That is, do not delete an evaporating overlay if it becomes
3108 empty after its bounds are adjusted to fit within its buffer.
3109 This fix caused other problems, and I'm reverting it until we get
3110 to the bottom of them.
3111
a8e7d6d7 31122012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3113
3114 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3115
a8e7d6d7 31162012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3117
3118 * xdisp.c (pos_visible_p): If the window start position is beyond
3119 ZV, start the display from buffer beginning. Prevents assertion
3120 violation in init_iterator when the minibuffer window is scrolled
3121 via the scroll bar.
3122
3123 * window.c (window_scroll_pixel_based): Likewise.
3124
a8e7d6d7 31252012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3126
3127 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3128
a8e7d6d7 31292012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3130
3131 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3132 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3133
a8e7d6d7 31342012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3135
b593d6a9
AH
3136 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3137 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3138
1c6900d9
EZ
31392012-04-26 Eli Zaretskii <eliz@gnu.org>
3140
4c3fa1d9
EZ
3141 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3142 display element, check also the underlying string or buffer
3143 character. (Bug#11341)
3144
1c6900d9
EZ
3145 * w32menu.c: Include w32heap.h.
3146 (add_menu_item): If the call to AppendMenuW (via
3147 unicode_append_menu) fails, disable Unicode menus only if we are
3148 running on Windows 9X/Me.
3149
42bf8205
AS
31502012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3151
3152 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3153 (xgetint): Add missing shift for LSB tags.
3154
b1bac16e
MR
31552012-04-24 Martin Rudalics <rudalics@gmx.at>
3156
3157 * keyboard.c (read_char): Don't wipe echo area for select window
3158 events: These might get delayed via `mouse-autoselect-window'
3159 (Bug#11304).
3160
d69621cc
JB
31612012-04-24 Juanma Barranquero <lekktu@gmail.com>
3162
3163 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3164 manipulation of :loaded-from data.
3165
02fd101b
JB
31662012-04-23 Juanma Barranquero <lekktu@gmail.com>
3167
3168 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3169 now a cons (bug#11311).
3170
888bec30
PE
31712012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3172
89a438bd
PE
3173 Do not create empty overlays with the evaporate property (Bug#9642).
3174 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3175 if it becomes empty after its bounds are adjusted to fit within
3176 its buffer. Without this fix, in a nonempty buffer (let ((o
3177 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3178 yields an empty overlay that has the evaporate property, which is
3179 not supposed to happen.
3180
1068fe4d
PE
3181 Fix minor GTK3 problems found by static checking.
3182 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3183 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3184 (struct _EmacsFixedClass, emacs_fixed_get_type):
3185 Move decls here from emacsgtkfixed.h, since they needn't be public.
3186 (emacs_fixed_get_type): Now static.
3187 (emacs_fixed_class_init): Omit unused local.
3188 (emacs_fixed_child_type): Remove; unused.
3189 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3190 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3191 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3192 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3193 (EMACS_FIXED_GET_CLASS): Remove; unused.
3194 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3195
888bec30
PE
3196 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3197 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3198
de85e130
PE
31992012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3200
d0baac98 3201 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3202 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3203 (__malloc_size_t, __malloc_ptrdiff_t):
3204 Remove. All uses removed, replaced by the definiens if needed,
3205 since we can assume C89 or better now.
3206 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3207 (protect_malloc_state, align, get_contiguous_space)
3208 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3209 (malloc_atfork_handler_child, malloc_enable_thread)
3210 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3211 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3212 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3213 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3214 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3215 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3216 Define using prototypes, not old style.
3217 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3218 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3219 (align): Don't assume that signed integer overflow wraps around.
3220 Omit unused local var.
3221 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3222 (_free_internal_nolock, memalign, mallochook, reallochook):
3223 Omit no-longer-needed casts.
3224 (valloc): Use getpagesize, not __getpagesize.
3225 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3226 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3227
de85e130
PE
3228 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3229
dcbf5805
MA
32302012-04-22 Michael Albinus <michael.albinus@gmx.de>
3231
3232 Move functions from C to Lisp. Make non-blocking method calls
3233 the default. Implement further D-Bus standard interfaces.
3234
3235 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3236 (QCdbus_request_name_allow_replacement)
3237 (QCdbus_request_name_replace_existing)
3238 (QCdbus_request_name_do_not_queue)
3239 (QCdbus_request_name_reply_primary_owner)
3240 (QCdbus_request_name_reply_in_queue)
3241 (QCdbus_request_name_reply_exists)
3242 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3243 (QCdbus_registered_serial, QCdbus_registered_method)
3244 (QCdbus_registered_signal): New Lisp objects.
3245 (XD_DEBUG_MESSAGE): Use sizeof.
3246 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3247 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3248 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3249 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3250 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3251 (xd_signature, xd_append_arg): Allow float for integer types.
3252 (xd_get_connection_references): New function.
b593d6a9
AH
3253 (xd_get_connection_address): Rename from xd_initialize.
3254 Return cached address.
dcbf5805
MA
3255 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3256 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3257 level.
3258 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3259 Return number of refcounts.
dcbf5805
MA
3260 (Fdbus_get_unique_name): Make stronger parameter check.
3261 (Fdbus_message_internal): New defun.
3262 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3263 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3264 (Fdbus_send_signal, Fdbus_register_service)
3265 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3266 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3267 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3268 (Vdbus_compiled_version, Vdbus_runtime_version)
3269 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3270 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3271 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3272 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3273 Adapt docstring.
dcbf5805 3274
52828e02
PE
32752012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3276
da05bc4c
PE
3277 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3278 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3279 Do not assume ptrdiff_t is the same width as 'int'.
3280
52828e02
PE
3281 * alloc.c: Handle unusual debugging option combinations.
3282 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3283 since the two debugging options are incompatible.
3284 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3285 is defined.
3286 (mem_init, mem_insert, mem_insert_fixup):
3287 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3288 (NEED_MEM_INSERT): Remove; no longer needed.
3289
f01769f9
LL
32902012-04-22 Leo Liu <sdl.web@gmail.com>
3291
3292 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3293
5790543d
PE
32942012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3295
3296 * sysdep.c [__FreeBSD__]: Minor cleanups.
3297 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3298 Use Emacs indenting style more consistently. Avoid some casts.
3299 Use 'double' consistently rather than mixing 'float' and 'double'.
3300
b91b7e4d
EW
33012012-04-21 Eduard Wiebe <usenet@pusto.de>
3302
b593d6a9
AH
3303 * sysdep.c (list_system_processes, system_process_attributes):
3304 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3305
6114eb15
AS
33062012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3307
3308 * lisp.mk (lisp): Update.
3309
2f38dff7
PE
33102012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3311
3312 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3313 It is never used otherwise.
3314
4ae29f89
SM
33152012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3316
3317 * print.c (print_preprocess): Only check print_depth if print-circle
3318 is nil.
3319 (print_object): Check for cycles even when print-circle is nil and
3320 print-gensym is t, but only check print_depth if print-circle is nil.
3321
f30d612a
CY
33222012-04-20 Chong Yidong <cyd@gnu.org>
3323
3324 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3325 set the status to "failed" and ensure that sentinel is run.
3326
c07a4c0b 33272012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3328
3329 * process.c (Fset_process_inherit_coding_system_flag)
3330 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3331 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3332
c07a4c0b 33332012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3334
3335 * xdisp.c (string_buffer_position_lim): Limit starting position to
3336 BEGV.
3337 (set_cursor_from_row): If called for a mode-line or header-line
3338 row, return zero immediately.
3339 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3340 farther than the first row after the header line, if any.
3341 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3342 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3343
c07a4c0b 33442012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3345
4ae29f89
SM
3346 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3347 (bug#11238).
ad3a2b41 3348
c07a4c0b 33492012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 33502012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3351
3352 configure: new option --enable-gcc-warnings (Bug#11207)
3353 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3354 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3355 (ALL_CFLAGS): Use new macros rather than old.
3356 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3357 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3358 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3359 -Wunused-result, -Wunused-variable. This should go away once
3360 the Emacs and Gnulib regex code is merged.
3361 (xmalloc, xrealloc): Now static.
3362
aba027e8
PE
33632012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3364
3365 * dired.c (Fsystem_groups): Remove unused local.
3366
e5a36063
GM
33672012-04-17 Glenn Morris <rgm@gnu.org>
3368
3369 * dired.c (Fsystem_users): Doc fix.
3370
316411f0
DA
33712012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3372
3373 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3374 (syms_of_dired): Add them.
3375
9426aba4
PE
33762012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3377
b62a57be
PE
3378 Fix minor alloc.c problems found by static checking.
3379 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3380 New extern decls, to avoid calling undeclared functions.
3381 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3382 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3383 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3384 (NEED_MEM_INSERT): New macro.
3385 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3386 Remove one incorrect comment and fix another.
b62a57be 3387
3539f31f
PE
3388 Fix minor ralloc.c problems found by static checking.
3389 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3390 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3391 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3392 (r_alloc_sbrk): Now static.
3393
a041960a
PE
3394 Improve ralloc.c interface checking.
3395 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3396 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3397 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3398 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3399 [REL_ALLOC]: ... to here, to check interface.
3400 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3401 Remove decls. This fixes an "It stinks!".
3402
9426aba4
PE
3403 * alloc.c (which_symbols): Fix alignment issue / type clash.
3404
d55c12ed
AS
34052012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3406
3407 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3408 (struct Lisp_Misc_Any): Likewise.
3409 (struct Lisp_Free): Likewise.
3410 * alloc.c (union aligned_Lisp_Symbol): Define.
3411 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3412 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3413 (union aligned_Lisp_Misc): Define.
3414 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3415 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3416 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3417
b948ce8b
PE
34182012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3419
3420 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3421 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3422 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3423 * s/netbsd.h, s/sol2-6.h:
3424 Remove definition of GC_MARK_STACK, since the default now works.
3425 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3426 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3427 no longer the default.
3428 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3429
35dc09a1 34302012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3431
35dc09a1
GM
3432 * lread.c (lisp_file_lexically_bound_p):
3433 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3434
35dc09a1
GM
34352012-04-14 Eli Zaretskii <eliz@gnu.org>
3436
3437 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3438 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3439
34402012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3441
3442 * nsterm.m (constrainFrameRect): Always constrain when there is only
3443 one screen (Bug#10962).
3444
bcd86815
KB
34452012-04-13 Ken Brown <kbrown@cornell.edu>
3446
3447 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3448
c25df26e
RT
34492012-04-13 Reuben Thomas <rrt@sc3d.org>
3450
3451 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3452
0fc59f1e
DC
34532012-04-11 Daniel Colascione <dancol@dancol.org>
3454
3455 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3456 against is gone. It's better to use vfork now so that when Cygwin
3457 gains a new, working vfork, we use it automatically (bug#10398).
3458
de8c03dc
SM
34592012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3460
3461 * window.c (save_window_save): Obey window-point-insertion-type.
3462
2f097256
GM
34632012-04-11 Glenn Morris <rgm@gnu.org>
3464
3465 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3466
453b951e
SM
34672012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3468
3469 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3470
75f1671a 34712012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3472
3473 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3474 (force_quit_count): New var.
3475 (handle_interrupt): Use it.
3476
2a8ce227
JB
34772012-04-10 Juanma Barranquero <lekktu@gmail.com>
3478
3479 * w32.c (w32_delayed_load): Record the full path of the library
3480 being loaded (bug#10424).
3481
935396c0
GM
34822012-04-09 Glenn Morris <rgm@gnu.org>
3483
05920a43
GM
3484 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3485 not just in the obarray, before snarfing them. (Bug#11036)
3486
935396c0
GM
3487 * Makefile.in ($(leimdir)/leim-list.el):
3488 Pass EMACS rather than BUILT_EMACS.
3489
a18ecafa
TZ
34902012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3491
3492 * process.c (make_process):
3493 * process.h: Add integer `gnutls_handshakes_tried' member to
3494 process struct.
3495
6bbef4e5
JC
3496 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3497 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3498
3499 * gnutls.c (gnutls_log_function2i): Convenience log function.
3500 (emacs_gnutls_read): Use new log functions,
3501 `gnutls_handshakes_tried' process member, and
3502 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3503 attempts per process (connection).
3504
b4d3bc10
CY
35052012-04-09 Chong Yidong <cyd@gnu.org>
3506
3507 * eval.c (Fuser_variable_p, user_variable_p_eh)
3508 (lisp_indirect_variable): Functions deleted.
3509 (Fdefvar): Caller changed.
3510
3511 * callint.c (Finteractive, Fcall_interactively):
3512 * minibuf.c (Fread_variable): Callers changed.
3513
70f4d973
EZ
35142012-04-09 Eli Zaretskii <eliz@gnu.org>
3515
3516 * xdisp.c (set_cursor_from_row): If the display string appears in
3517 the buffer at position that is closer to point than the position
3518 after the display string, display the cursor on the first glyph of
3519 the display string. Fixes cursor display when a 'display' text
3520 property immediately follows invisible text. (Bug#11094)
3521
cb3c2e3e
PE
35222012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3523
3524 composite.c: use 'double' consistently
3525 * composite.c (get_composition_id): Use 'double' consistently
3526 instead of converting 'float' to 'double' and vice versa; this is
3527 easier to understand and avoids a GCC warning.
3528
fd06db5d
GM
35292012-04-09 Glenn Morris <rgm@gnu.org>
3530
50fe702a
GM
3531 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3532 preparation for dumping it with emacs. (Bug#4789)
3533 (leimdir): New variable.
3534 ($(leimdir)/leim-list.el): New rule.
3535 (emacs$(EXEEXT)): Depend on leim-list.el.
3536
fd06db5d
GM
3537 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3538 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3539 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3540
55c131ee
AS
35412012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3542
3543 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3544 proper alignment.
3545
9209588f
JB
35462012-04-07 Juanma Barranquero <lekktu@gmail.com>
3547
3548 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3549 Remove unused local variable.
3550
e3fb2efb
PE
35512012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3552
3553 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3554 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3555 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3556 objects, as mark_maybe_pointer will catch them otherwise.
3557 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3558 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3559
b5385551
PE
35602012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3561
3562 Fix typo that broke non-Windows builds.
3563 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3564
9078ead6
EZ
35652012-04-07 Eli Zaretskii <eliz@gnu.org>
3566
3567 Support building on MS-Windows with libxml2.
3568
3569 * makefile.w32-in (OBJ2): Add xml.$(O).
3570 (GLOBAL_SOURCES): Add xml.c.
3571 ($(BLD)/xml.$(O)): New dependency list.
3572
3573 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3574 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3575 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3576 [!WINDOWSNT]: New macros.
3577 (init_libxml2_functions, libxml2_loaded_p): New functions.
3578 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3579 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3580 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3581 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3582 linked in).
6bbef4e5
JC
3583 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3584 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3585 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3586
3587 * emacs.c: Don't include libxml/parser.h.
3588 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3589 xmlCleanupParser directly.
3590
3591 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3592
3811fdf3
EZ
35932012-04-07 Eli Zaretskii <eliz@gnu.org>
3594
3595 * indent.c (Fvertical_motion): If there is a display string at
3596 point, use it.vpos to compute how many lines to backtrack after
3597 move_it_to point. (Bug#11133)
3598
2f8e16b2
EZ
35992012-04-06 Eli Zaretskii <eliz@gnu.org>
3600
3601 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3602 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3603 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3604 macros related to unification of CJK characters. For the details,
3605 see the discussion following the message here:
3606 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3607
3d439cd1
CY
36082012-04-04 Chong Yidong <cyd@gnu.org>
3609
3610 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3611
8bc53d00
EZ
36122012-04-01 Eli Zaretskii <eliz@gnu.org>
3613
3614 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3615 instead of alloca. (Bug#11138)
3616
3b0512a3
AS
36172012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3618
3619 * w32menu.c (is_simple_dialog): Properly check lisp types.
3620 (Bug#11141)
3621
8427ddd2
EZ
36222012-03-31 Eli Zaretskii <eliz@gnu.org>
3623
979022ef
EZ
3624 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3625 position we get to after a call to move_it_to fails the
3626 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3627 only if we wind up in a string from display property. (Bug#11063)
3628
a6b1c7cc
EZ
3629 * window.c (Fdelete_other_windows_internal): Invalidate the row
3630 and column information about mouse highlight, so that redisplay
3631 restores it after reallocating the glyph matrices. (Bug#7464)
3632
8427ddd2
EZ
3633 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3634 string comes from a `display' text property, use the buffer
3635 position of that property as if we actually saw that position in
3636 the row's glyphs.
697ba24b
EZ
3637 (move_it_by_lines): Remove the assertion that
3638 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3639 violated when there's a before-string at the beginning of a line.
3640 (Bug#11063)
8427ddd2 3641
65a0a738
EZ
36422012-03-30 Eli Zaretskii <eliz@gnu.org>
3643
3644 * xdisp.c (append_space_for_newline): If the default face was
3645 remapped, use the remapped face for the appended newline.
3646 (extend_face_to_end_of_line): Use the remapped default face for
3647 extending the face to the end of the line.
3648 (display_line): Call extend_face_to_end_of_line when the default
3649 face was remapped. (Bug#11068)
3650
581355cc
EZ
36512012-03-29 Eli Zaretskii <eliz@gnu.org>
3652
3653 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3654
e8fc049f
SM
36552012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3656
3657 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3658
4fb9a543
GM
36592012-03-27 Glenn Morris <rgm@gnu.org>
3660
3661 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3662 Doc fixes.
3663
679910f1
KH
36642012-03-26 Kenichi Handa <handa@m17n.org>
3665
3666 * dispextern.h (struct glyph): Fix previous change. Change the
3667 bit length of glyphless.ch to 25 (Bug#11082).
3668
90d49b7f
CY
36692012-03-26 Chong Yidong <cyd@gnu.org>
3670
3671 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3672 (command_loop_1): Use it; inhibit selection update for
3673 handle-select-window too (Bug#8996).
3674
f514f6f0
FP
36752012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3676
e8fc049f 3677 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3678
bf43fa51
KH
36792012-03-25 Kenichi Handa <handa@m17n.org>
3680
3681 * dispextern.h (struct glyph): Change the bit length of
3682 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3683
8a0c01dd
EZ
36842012-03-24 Eli Zaretskii <eliz@gnu.org>
3685
3686 * s/ms-w32.h (tzname): Include time.h before redirecting to
3687 _tzname. Fixes the MSVC build. (Bug#9960)
3688
7d1c3a76
AS
36892012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3690
8ed79523
AS
3691 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3692 characters.
3693
7d1c3a76
AS
3694 * xterm.c (XTread_socket): Only modify handling_signal if
3695 !SYNC_INPUT. (Bug#11080)
3696
e99a9b8b
EZ
36972012-03-23 Eli Zaretskii <eliz@gnu.org>
3698
3699 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3700 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3701 when fetching a multibyte character consumes more bytes than
3702 CHAR_BYTES returns, due to unification of CJK characters in
3703 string_char. (Bug#11073)
3704
5063c0e1
TN
37052012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3706
3707 * process.c (wait_reading_process_output): Handle pty disconnect
3708 by refraining from sending oneself a SIGCHLD (bug#10933).
3709
9f851fbd
CY
37102012-03-22 Chong Yidong <cyd@gnu.org>
3711
3712 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3713
5063c0e1 3714 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3715 Mark string as coming from a prefix property.
3716 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3717 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3718
fb5b8aca
CY
37192012-03-21 Chong Yidong <cyd@gnu.org>
3720
3721 * xfaces.c (Vface_remapping_alist): Doc fix.
3722
62356a1b
EZ
37232012-03-20 Eli Zaretskii <eliz@gnu.org>
3724
3725 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3726 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3727 Doc fixes.
62356a1b 3728
025de85b
CY
37292012-03-20 Chong Yidong <cyd@gnu.org>
3730
3731 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3732 to reflect default non-nil value of redisplay-dont-pause.
3733
4827f94e
KH
37342012-03-19 Kenichi Handa <handa@m17n.org>
3735
3736 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3737 it fit in a valid range (Bug#11003).
3738
e50a24a2
EZ
37392012-03-18 Eli Zaretskii <eliz@gnu.org>
3740
3741 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3742 that is not from display property, accept the row as a "cursor
3743 row" if one of the string's character has a non-nil `cursor'
3744 property. Fixes cursor positioning when there are newlines in
3745 overlay strings, e.g. in icomplete.el. (Bug#11035)
3746
9af5ed87
PE
37472012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3748
3749 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3750
d1f55f16
CY
37512012-03-12 Chong Yidong <cyd@gnu.org>
3752
3753 * eval.c (inhibit_lisp_code): Rename from
3754 inhibit_window_configuration_change_hook; move from window.c.
3755
3756 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3757 * window.c (run_window_configuration_change_hook)
3758 (syms_of_window): Callers changed.
3759
66c5eebd
CY
37602012-03-11 Chong Yidong <cyd@gnu.org>
3761
413df973
CY
3762 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3763
66c5eebd
CY
3764 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3765
1de11f56
CY
37662012-03-10 Chong Yidong <cyd@gnu.org>
3767
3768 * frame.c (other_visible_frames): Don't assume the selected frame
3769 is visible (Bug#10955).
3770
cae07000
SM
37712012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3772
3773 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3774
89c94350
JD
37752012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3776
3777 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3778 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3779 zero (Bug#10954).
3780
999dd333
GM
37812012-03-03 Glenn Morris <rgm@gnu.org>
3782
01a6dcc8 3783 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3784
de0100f2
EZ
37852012-03-02 Eli Zaretskii <eliz@gnu.org>
3786
3787 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3788 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3789 (redisplay_window, next_element_from_string): Fix typos in
3790 comments.
3e441275
EZ
3791 (redisplay_window): Pass to move_it_vertically the margin in
3792 pixels, not in screen lines.
de0100f2 3793
96a72ee9
GM
37942012-03-02 Glenn Morris <rgm@gnu.org>
3795
3796 * buffer.c (buffer-list-update-hook): Doc fix.
3797
312508d7
EZ
37982012-02-29 Eli Zaretskii <eliz@gnu.org>
3799
3800 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3801 push_it before setting up the iterator for the first overlay
3802 string, even if we have an empty string loaded.
3803 (next_overlay_string): If there's an empty string on the iterator
3804 stack, pop the stack. (Bug#10903)
3805
27f3c637
PE
38062012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3807
3808 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3809 Suggested by Stefan Monnier in
3810 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3811 * alloc.c (widen_to_Lisp_Object): New static function.
3812 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3813 and widening them to Lisp_Objects. This would work even if
3814 USE_LSB_TAG is defined and wide integers are used, which might
3815 happen in a future version of Emacs.
3816
3c9dfce6
CY
38172012-02-25 Chong Yidong <cyd@gnu.org>
3818
fa74b241
CY
3819 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3820 Doc fix.
3821
3c9dfce6
CY
3822 * xselect.c (Fx_selection_exists_p): Doc fix.
3823 (x_clipboard_manager_save_all): Print an informative message
3824 before saving to clipboard manager.
3825
9486df08
CY
38262012-02-24 Chong Yidong <cyd@gnu.org>
3827
3828 * keyboard.c (process_special_events): Handle all X selection
3829 requests in kbd_buffer, not just the next one (Bug#8869).
3830
f01d3321
CY
38312012-02-23 Chong Yidong <cyd@gnu.org>
3832
3833 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3834 call when setting menu-bar-lines and tool-bar-lines parameters.
3835 (unwind_create_frame_1): New helper function.
3836
3837 * window.c (inhibit_window_configuration_change_hook): New var.
3838 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3839 (syms_of_window): Initialize it.
f01d3321 3840
86b847b6
CY
38412012-02-22 Chong Yidong <cyd@gnu.org>
3842
3843 * xterm.c (x_draw_image_relief): Add missing type check for
3844 Vtool_bar_button_margin (Bug#10743).
3845
a59225b1
CY
38462012-02-21 Chong Yidong <cyd@gnu.org>
3847
3848 * fileio.c (Vfile_name_handler_alist): Doc fix.
3849
3850 * buffer.c (Fget_file_buffer): Protect against invalid file
3851 handler return value.
3852
310f5bd4
PE
38532012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3854
cb3a28cc
PE
3855 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3856 when computing $valmask.
3857
310f5bd4
PE
3858 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3859 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3860 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3861 It's useless in that case, and it can cause problems on hosts
3862 that allocate halves of EMACS_INT values separately.
3863 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3864 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3865 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3866 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3867 it avoids undefined behavior on hosts where shifting right by more
3868 than the word width has undefined behavior.
3869
2375c96a
CY
38702012-02-19 Chong Yidong <cyd@gnu.org>
3871
3872 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3873 (Funhandled_file_name_directory, Ffile_name_as_directory)
3874 (Fdirectory_file_name, Fexpand_file_name)
3875 (Fsubstitute_in_file_name): Protect against invalid file handler
3876 return values (Bug#10845).
3877
3eb49e71
EZ
38782012-02-18 Eli Zaretskii <eliz@gnu.org>
3879
3880 * .gdbinit (pitx): Fix incorrect references to fields of the
3881 iterator stack.
3882
7b926f3f
CY
38832012-02-17 Chong Yidong <cyd@gnu.org>
3884
3885 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3886
11273115
PE
38872012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3888
3889 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3890 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3891
c3a70e2b
CY
38922012-02-15 Chong Yidong <cyd@gnu.org>
3893
3894 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3895 marked as special. Also, starting docstrings with * is obsolete.
3896
0ca43699
AS
38972012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3898
3899 * gnutls.c (emacs_gnutls_write): Fix last change.
3900
2e8f3c56
LI
39012012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3902
3903 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3904 send_process.
3905
af70074f
SM
39062012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3907
3908 * keymap.c (Fsingle_key_description): Handle char ranges.
3909
95986d52
CY
39102012-02-12 Chong Yidong <cyd@gnu.org>
3911
afd83bd1
CY
3912 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3913 as that creates a dangerous corner case.
3914
95986d52
CY
3915 * window.c (Fdelete_window_internal): Invalidate the mouse
3916 highlight (Bug#9904).
3917
bd7da63e
GM
39182012-02-12 Glenn Morris <rgm@gnu.org>
3919
3920 * xselect.c (Fx_own_selection_internal)
3921 (Fx_get_selection_internal, Fx_disown_selection_internal)
3922 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3923 * nsselect.m (Fx_own_selection_internal)
3924 (Fx_disown_selection_internal, Fx_selection_exists_p)
3925 (Fx_selection_owner_p, Fx_get_selection_internal):
3926 Sync docs and argument specs with the xselect.c versions.
3927
77abcbc2
LI
39282012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3929
3930 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3931
90b671e2
EZ
39322012-02-11 Eli Zaretskii <eliz@gnu.org>
3933
1c0ca0b7
EZ
3934 * w32select.c (Fx_selection_exists_p): Sync doc string and
3935 argument list with xselect.c. (Bug#10783)
3936
3937 * w16select.c (Fx_selection_exists_p): Sync doc string and
3938 argument list with xselect.c. (Bug#10783)
90b671e2 3939
49241268
GM
39402012-02-10 Glenn Morris <rgm@gnu.org>
3941
3942 * fns.c (Fsecure_hash): Doc fix.
3943
f998bbe7 39442012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3945
3946 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3947
0992bd9c
CY
39482012-02-07 Chong Yidong <cyd@gnu.org>
3949
3950 * buffer.c (Fbuffer_local_variables)
3951 (buffer_lisp_local_variables): Handle unbound vars correctly;
3952 don't let Qunbound leak into Lisp.
3953
af008560
GM
39542012-02-07 Glenn Morris <rgm@gnu.org>
3955
dd605cc4
GM
3956 * image.c (Fimagemagick_types): Doc fix.
3957
af008560
GM
3958 * image.c (imagemagick-render-type): Change it from a lisp object
3959 to an integer. Move the doc here from the lisp manual.
3960 Treat all values not equal to 0 the same.
3961
1449fa1d
CY
39622012-02-06 Chong Yidong <cyd@gnu.org>
3963
3964 * doc.c (store_function_docstring): Avoid applying docstring of
3965 alias to base function (Bug#2603).
3966
3723ec07
AS
39672012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3968
3969 * .gdbinit (pp1, pv1): Remove redundant defines.
3970 (pr): Use pp.
3971
79c1cc1e
CY
39722012-02-04 Chong Yidong <cyd@gnu.org>
3973
3974 * nsterm.m: Declare a global (Bug#10694).
3975
d7f29f8e
EZ
39762012-02-04 Eli Zaretskii <eliz@gnu.org>
3977
cae07000
SM
3978 * w32.c (get_emacs_configuration_options):
3979 Include --enable-checking, if specified, in the return value.
d7f29f8e 3980
3b95a6f9
MR
39812012-02-04 Martin Rudalics <rudalics@gmx.at>
3982
3983 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3984 after rounding frame sizes. (Bug#9723)
3985
d6fa96a6
EZ
39862012-02-04 Eli Zaretskii <eliz@gnu.org>
3987
3988 * keyboard.c (adjust_point_for_property): Don't position point
3989 before BEGV. (Bug#10696)
3990
df0b2940
PE
39912012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3992
3993 Handle overflow when computing char display width (Bug#9496).
3994 * character.c (char_width): Return EMACS_INT, not int.
3995 (char_width, c_string_width): Check for overflow when
3996 computing the width; this is possible now that individual
3997 characters can have unbounded width. Problem introduced
3998 by merge from Emacs 23 on 2012-01-19.
3999
6bee44d6
MA
40002012-02-02 Michael Albinus <michael.albinus@gmx.de>
4001
4002 * dbusbind.c (Fdbus_register_method): Mention the return value
4003 :ignore in the docstring.
4004
44f92739
GM
40052012-02-02 Glenn Morris <rgm@gnu.org>
4006
1b9f60cc
GM
4007 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4008
44f92739
GM
4009 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4010 Unconditionally set to t. (Bug#10673)
4011 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4012 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4013 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4014
c5d3843c
KH
40152012-02-02 Kenichi Handa <handa@m17n.org>
4016
4017 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4018 0, do not call append_composite_glyph.
4019
159462d4 40202012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4021
4022 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4023 NULL (Bug#6988).
4024 (x_produce_glyphs): If the component of a composition is a null
4025 string, set it->pixel_width to 1 to avoid zero-width glyph.
4026
78cef877
EZ
40272012-02-01 Eli Zaretskii <eliz@gnu.org>
4028
4029 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4030 first 2 arguments are identical. This makes inserting large
4031 output from a subprocess an order of magnitude faster on
4032 MS-Windows, where all sbrk'ed memory is always contiguous.
4033
97897668
GM
40342012-01-31 Glenn Morris <rgm@gnu.org>
4035
4036 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4037 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4038 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4039
31fd3586
GM
40402012-01-29 Glenn Morris <rgm@gnu.org>
4041
4042 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4043
0e24a8b2
CY
40442012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4045
4046 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4047
cc0adcb0
CY
40482012-01-28 Chong Yidong <cyd@gnu.org>
4049
4050 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4051
acc28cb9
CY
40522012-01-26 Chong Yidong <cyd@gnu.org>
4053
9c69cfb7
CY
4054 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4055
acc28cb9
CY
4056 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4057 repeat counts (Bug#10507).
4058
48da7392
GM
40592012-01-26 Glenn Morris <rgm@gnu.org>
4060
4061 * lread.c (syms_of_lread): Doc fix.
4062
14af5f7f
CY
40632012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4064
4065 * coding.c (encode_designation_at_bol): Change return value to
4066 EMACS_INT.
4067
0b21c100
CY
40682012-01-25 Chong Yidong <cyd@gnu.org>
4069
4070 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4071
3c2907f7
CY
40722012-01-21 Chong Yidong <cyd@gnu.org>
4073
4074 * floatfns.c (Fcopysign): Make the second argument non-optional,
4075 since nil is not allowed anyway.
4076
959ad23f
AS
40772012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4078
4079 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4080 (send_process): Likewise.
4081
34a02f46
MR
40822012-01-19 Martin Rudalics <rudalics@gmx.at>
4083
4084 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4085 (Vwindow_persistent_parameters): Do not use Qstate.
4086 Rewrite doc-strings.
34a02f46 4087
1259009a 40882012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4089
4090 * character.c (char_width): New function.
70d4fdf6
GM
4091 (Fchar_width, c_string_width, lisp_string_width):
4092 Use char_width (Bug#9496).
25ed9e61 4093
6a6ee00d
MR
40942012-01-16 Martin Rudalics <rudalics@gmx.at>
4095
4096 * window.c (Vwindow_persistent_parameters): New variable.
4097 (Fset_window_configuration, save_window_save): Handle persistent
4098 window parameters.
4099
c85efaf7
EZ
41002012-01-14 Eli Zaretskii <eliz@gnu.org>
4101
4102 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4103 thrashing the stack of the thread. (Bug#9087)
4104
5944709e
PE
41052012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4106
4107 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4108
e71f5d99
EZ
41092012-01-11 Eli Zaretskii <eliz@gnu.org>
4110
4111 * xdisp.c (rows_from_pos_range): Handle the case where the
4112 highlight ends on a newline. (Bug#10464)
4113 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4114 he end column for display of highlight that ends on a newline
4115 before a R2L line.
4116
ce316182
GM
41172012-01-11 Glenn Morris <rgm@gnu.org>
4118
4119 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4120 from load-path also when installation-directory is nil. (Bug#10208)
4121
5b43da69
GM
41222012-01-10 Glenn Morris <rgm@gnu.org>
4123
74cc8ff9
GM
4124 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4125
7d8d6e4e
GM
4126 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4127 Update template values to be closer to their typical values these days.
5b43da69 4128
a0db8d43
EZ
41292012-01-09 Eli Zaretskii <eliz@gnu.org>
4130
4131 * xdisp.c (rows_from_pos_range): Accept additional argument
4132 DISP_STRING, and accept any glyph in a row whose object is that
4133 string as eligible for mouse highlight. Fixes mouse highlight of
4134 display strings from overlays. (Bug#10464)
4135
9a0115ab 41362012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4137
b9110d6a 4138 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4139 * fileio.c (auto_saving_dir_umask): New static var.
4140 (Fmake_directory_internal): Use it.
4141 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4142 creating the directory. The old code temporarily assigns
4143 too-generous permissions to the directory.
4144 (do_auto_save_eh): Clear it.
b9110d6a 4145 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4146 that the var is always cleared.
4147
6c1bd3f3
EZ
41482012-01-07 Eli Zaretskii <eliz@gnu.org>
4149
4150 * search.c (scan_buffer): Pass character positions to
4151 know_region_cache, not byte positions. (Bug#6540)
4152
069d2b50
L
41532012-01-07 LynX <_LynX@bk.ru> (tiny change)
4154
4155 * w32.c (sys_rename): Report EXDEV when rename of a directory
4156 fails because the target is on another logical disk. (Bug#10284)
4157
75bf0d33
DB
41582012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4159
4160 * xterm.c (x_embed_request_focus): New function.
4161
4162 * xterm.h: Add prototype.
4163
4164 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4165
1c6e5a32
GM
41662012-01-05 Glenn Morris <rgm@gnu.org>
4167
4168 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4169
651e947e
EZ
41702012-01-01 Eli Zaretskii <eliz@gnu.org>
4171
4172 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4173 Load gnutls_transport_set_lowat only if GnuTLS version is below
4174 2.11.1.
4175 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4176 GnuTLS versions below 2.11.1.
4177
3778cdd8
AL
41782011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4179
4180 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4181 to the doc string advising against its use for altering the way
4182 windows are scrolled.
4183
0e5317f7
KH
41842011-12-28 Kenichi Handa <handa@m17n.org>
4185
4186 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4187 coding-system ASCII compatible only when it does not produce BOM
4188 on encoding (Bug#10383).
4189
93d5ca1f
JD
41902011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4191
4192 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4193 can scroll.
4194 (create_and_show_popup_menu): Always use menu_position_func for
4195 Gtk3 (Bug#10361).
4196
ca22b785
AS
41972011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4198
4199 * callint.c (Fcall_interactively): Don't truncate prompt string.
4200
d048e1e6
EZ
42012011-12-23 Eli Zaretskii <eliz@gnu.org>
4202
4203 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4204 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4205 resumed from there (after widening). (Bug#10360)
d048e1e6 4206
5ccaba1f
JD
42072011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4208
4209 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4210
204ee57f
JD
42112011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4212
b81d40f0
JB
4213 * nsterm.m (x_free_frame_resources):
4214 Release f->output_data.ns->miniimage.
204ee57f
JD
4215 (ns_index_color): Fix indentation. Do not retain
4216 color_table->colors[i].
4217
4218 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4219 before returning.
4220
4221 * nsfns.m (x_set_background_color): Assign return value from
4222 ns_index_color to face-background instead of NSColor*.
4223 (ns_implicitly_set_icon_type): Fix indentation.
4224 Change assignment in for loop to comparison.
4225
4226 * emacs.c (ns_pool): New variable.
4227 (main): Assign ns_pool.
4228 (Fkill_emacs): Call ns_release_autorelease_pool.
4229
4230 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4231 autorelease fdesc, release fdAttrs and tdict.
4232 (ns_get_covering_families): Release charset.
4233 (ns_findfonts): Release NSFontDescriptor created with new.
4234 (ns_uni_to_glyphs): Fix indentation.
4235 (setString): Release attrStr before assigning new value.
4236
c803b2b7
JD
42372011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4238
678f4426
JD
4239 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4240 and NS_IMPL_COCOA.
4241 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4242 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4243
cd394be1 42442011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4245
5fecd5fc
JD
4246 * nsterm.m (ns_term_init): Subscribe for notifications
4247 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4248 to method trackingNotification in EmacsMenu.
4249
4250 * nsmenu.m (trackingMenu): New variable.
3771cb17 4251 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4252 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4253 from Aquamacs (Bug#7030).
678f4426
JD
4254
42552011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4256
c803b2b7
JD
4257 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4258 (symbol_to_nsstring): Fix indentation.
4259 (ns_symbol_to_pb): New function.
cae07000
SM
4260 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4261 (Fns_rotate_cut_buffers_internal): Remove.
4262 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4263 Fns_store_cut_buffer_internal.
4264 (ns_get_foreign_selection, Fx_own_selection_internal)
4265 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4266 (Fns_get_selection_internal, Fns_store_selection_internal):
4267 Use ns_symbol_to_pb and check if return value is nil.
4268 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4269 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4270 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4271 renamed to Sns_store_selection_internal.
4272 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4273 and remove this function.
4274 (ns_handle_selection_clear): Remove, never used.
4275 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4276 here.
4277
e1b01a3a
KB
42782011-12-17 Ken Brown <kbrown@cornell.edu>
4279
4280 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4281 GID is unknown (Bug#10257).
4282
2adb6e85
PE
42832011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4284
4285 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4286 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4287 which caused a build failure on GNU/Linux IA-64. This problem was
4288 introduced by my 2011-10-07 patch.
4289
d1d7b339
JL
42902011-12-15 Juri Linkov <juri@jurta.org>
4291
4292 * image.c (imagemagick_error): New function. (Bug#10112)
4293 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4294 Use `imagemagick_error' where ImageMagick functions return
4295 `MagickFalse'.
4296 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4297 proper order.
4298
100d5755
KH
42992011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4300
4301 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4302 fill background (Bug#8992).
4303
454592a6
MR
43042011-12-13 Martin Rudalics <rudalics@gmx.at>
4305
4306 * window.c (Vwindow_combination_resize)
4307 (Vwindow_combination_limit): Use t instead of non-nil in
4308 doc-strings.
61d4b438
MR
4309 (Vrecenter_redisplay): Add first sentence of doc-string on
4310 separate line.
53524d93 4311 (Frecenter): Fix doc-string typo.
454592a6 4312
3633e3aa
KH
43132011-12-11 Kenichi Handa <handa@m17n.org>
4314
4315 * coding.c (Funencodable_char_position): Pay attention to the
4316 buffer text relocation (Bug#9389).
4317
7b9d523a 43182011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4319
7b9d523a
JD
4320 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4321 gtk_init (Bug#10100).
4322
b73189c6
EZ
43232011-12-10 Eli Zaretskii <eliz@gnu.org>
4324
4325 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4326 IT->string is nil. (Bug#10263)
4327
f7dfe5d6
JD
43282011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4329
83faebb4
JD
4330 * nsterm.h (x_free_frame_resources): Declare.
4331
f7dfe5d6
JD
4332 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4333 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4334
4335 * nsterm.h (ns_get_defaults_value): Declare.
4336
4337 * nsterm.m (ns_default): Call ns_get_defaults_value.
4338
7cd4e72c
EZ
43392011-12-09 Eli Zaretskii <eliz@gnu.org>
4340
4341 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4342 (Bug#10170)
4343
b34d7317
YM
43442011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4345
4346 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4347 that where the value of an _OBJC_* symbol points to is in the .bss
4348 section (Bug#10240).
4349
76470ad1
KH
43502011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4351
4352 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4353 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4354
745fff94
KH
43552011-12-08 Kenichi Handa <handa@m17n.org>
4356
4357 * ftfont.c (get_adstyle_property): Fix previous change
4358 (Bug#10233).
4359
6e44397c
JB
43602011-12-07 Juanma Barranquero <lekktu@gmail.com>
4361
4362 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4363 dirs from the default value of EMACSLOADPATH (bug#10208).
4364
7efa6272
GM
43652011-12-07 Glenn Morris <rgm@gnu.org>
4366
4367 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4368 installation and source directories as well. (Bug#10208)
4369
f6fc4d87
CY
43702011-12-06 Chong Yidong <cyd@gnu.org>
4371
4372 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4373
2bf26180
GM
43742011-12-06 Glenn Morris <rgm@gnu.org>
4375
4376 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4377 as an error, not just -1. (Bug#10217)
4378
3a6ad4f0
CY
43792011-12-05 Chong Yidong <cyd@gnu.org>
4380
4381 * keyboard.c (process_special_events): New function.
4382 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4383
75a3b399
PE
43842011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4385
4386 * coding.c (encode_designation_at_bol): Don't use uninitialized
4387 local variable (Bug#9318).
4388
c3c9e25e
KH
43892011-12-05 Kenichi Handa <handa@m17n.org>
4390
4391 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4392 return Qnil (Bug#8046, Bug#10193).
4393
5eb05ea3
KH
43942011-12-05 Kenichi Handa <handa@m17n.org>
4395
4396 * coding.c (encode_designation_at_bol): New args charbuf_end and
4397 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4398 (coding_set_source): Return how many bytes coding->source was
4399 relocated.
4400 (coding_set_destination): Return how many bytes
4401 coding->destination was relocated.
4402 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4403 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4404
44052011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4406
4407 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4408 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4409 macro (Bug#9318).
4410
44112011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4412
4413 The following changes are to fix Bug#9318.
4414
a79703f5 4415 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4416 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4417 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4418 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4419
7dbda6df
JB
44202011-12-05 Juanma Barranquero <lekktu@gmail.com>
4421
4422 * lisp.h (process_quit_flag): Fix external declaration.
4423
6d5eb5b0
SM
44242011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4425
4426 Don't macro-inline non-performance-critical code.
4427 * eval.c (process_quit_flag): New function.
4428 * lisp.h (QUIT): Use it.
4429
a0c3fad0
JD
44302011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4431
4432 * nsfns.m (get_geometry_from_preferences): New function.
4433 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4434
6c07aac2
AS
44352011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4436
4437 * emacs.c (Qkill_emacs): Define.
4438 (syms_of_emacs): Initialize it.
4439 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4440 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4441 (quit_throw_to_read_char): Add parameter `from_signal'.
4442 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4443 * lisp.h (QUIT): Call Fkill_emacs if requested.
4444
c052ead4
JD
44452011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4446
4447 * widget.c (update_wm_hints): Return if wmshell is null.
4448 (widget_update_wm_size_hints): New function.
4449
4450 * widget.h (widget_update_wm_size_hints): Declare.
4451
4452 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4453 widget_update_wm_size_hints (Bug#10104).
4454
9e49252b
EZ
44552011-12-03 Eli Zaretskii <eliz@gnu.org>
4456
4457 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4458 before a newline, prepare the bidi iterator for consuming the
4459 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4460 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4461
02b16839
JL
44622011-12-02 Juri Linkov <juri@jurta.org>
4463
4464 * search.c (Fword_search_regexp): New Lisp function created from
4465 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4466 (Fword_search_backward, Fword_search_forward)
4467 (Fword_search_backward_lax, Fword_search_forward_lax):
4468 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4469 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4470
0068070e
SM
44712011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4472
4473 * fileio.c (Finsert_file_contents): Move after-change-function call
4474 to before the "handled:" label, since all "goto handled" appear in
4475 cases where the *-change-functions have already been properly called
4476 (bug#10117).
4477
3360a3fc
AS
44782011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4479
4480 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4481 waiting for input. (Bug#10169)
4482
73d6c093
EZ
44832011-11-30 Eli Zaretskii <eliz@gnu.org>
4484
4485 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4486 verifies glyph row's hash code--we have just reallocated the
4487 glyphs, so their contents can be complete garbage. (Bug#10164)
4488
febe6bea
JB
44892011-11-30 Juanma Barranquero <lekktu@gmail.com>
4490
4491 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4492
801a4313
EZ
44932011-11-30 Eli Zaretskii <eliz@gnu.org>
4494
4495 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4496 attributes are tested _before_ calling verify_row_hash, to protect
4497 against GCC re-ordering of the tests. (Bug#10164)
4498
2b56b87e
JD
44992011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4500
4501 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4502
4503 * xterm.c (handle_one_xevent): Only set async_visible and friends
4504 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4505 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4506 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4507
dbf31225
PE
45082011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4509
4510 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4511 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4512 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4513 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4514 All uses changed to use GCPRO1 etc.
4515 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4516 Revert to old implementation (i.e., before 2011-03-11).
4517
1305621b
YM
45182011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4519
4520 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4521 of scroll runs so as to avoid assigning disabled bogus rows and
4522 unnecessary graphics copy operations.
4523
8c9afb46
EZ
45242011-11-27 Eli Zaretskii <eliz@gnu.org>
4525
4526 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4527 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4528 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4529 (malloc, free, realloc, calloc): Redirect to e_* only when
4530 compiling Emacs.
4531
4532 * lisp.h (GCTYPEBITS): Move before first use.
4533 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4534 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4535 this macro definition.
4536
4537 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4538 _MSC_VER.
4539
54e9e3bf
JD
45402011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4541
6d5eb5b0
SM
4542 * gtkutil.c (xg_create_frame_widgets):
4543 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4544 present with Gtk+ 2.0.
4545
83aca1cb
PE
45462011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4547
4548 * fileio.c (Finsert_file_contents): Undo previous change; see
4549 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4550
5b76caa4
PE
45512011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4552
4553 Rename locals to avoid shadowing.
4554 * fileio.c (Finsert_file_contents):
4555 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4556 * process.c (wait_reading_process_output):
4557 Rename inner 'proc' to 'p' to avoid shadowing.
4558 Indent for consistency with usual Emacs style.
4559
8c535114
EZ
45602011-11-25 Eli Zaretskii <eliz@gnu.org>
4561
4562 * xdisp.c (redisplay_window): If cursor row is not fully visible
4563 after recentering, and scroll-conservatively is set to a large
4564 number, scroll window by a few more lines to make the cursor fully
4565 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4566 (start_display): Don't move to the next line if the display should
4567 start at a newline that is part of a display vector or an overlay
4568 string. (Bug#10119)
8c535114 4569
fa4fdb5c
JL
45702011-11-24 Juri Linkov <juri@jurta.org>
4571
4572 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4573 after the `MagickPingImage' call. (Bug#10112)
4574
90ec88df
CY
45752011-11-23 Chong Yidong <cyd@gnu.org>
4576
4577 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4578
56e2e794
MR
45792011-11-23 Martin Rudalics <rudalics@gmx.at>
4580
4581 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4582 making another buffer current. (Bug#10114)
4583
b6e64c41
GM
45842011-11-23 Glenn Morris <rgm@gnu.org>
4585
4586 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4587
6b21de18
CY
45882011-11-23 Chong Yidong <cyd@gnu.org>
4589
4590 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4591 using it (Bug#5984).
4592
b12cd789
EZ
45932011-11-22 Eli Zaretskii <eliz@gnu.org>
4594
4595 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4596 and header-lines, as they don't have one computed for them.
4597 (Bug#10098)
4598
4599 * .gdbinit (prow): Make displayed values more self-explaining.
4600 Add row's hash code.
4601
261b6fd4
LMI
46022011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4603
4604 * process.c (wait_reading_process_output): Fix asynchrounous
4605 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4606 (wait_reading_process_output): Add comment and URL.
261b6fd4 4607
e7cfd277
JD
46082011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4609
4610 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4611
a9b9b7f5
CY
46122011-11-21 Chong Yidong <cyd@gnu.org>
4613
4614 * window.c (Fnext_window, Fprevious_window): Doc fix.
4615
b0d15b4f
SM
46162011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4617
4618 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4619
fe7a3057
JB
46202011-11-20 Juanma Barranquero <lekktu@gmail.com>
4621
4622 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4623
d2999b1a
MR
46242011-11-20 Martin Rudalics <rudalics@gmx.at>
4625
4626 * window.c (Fset_window_combination_limit): Rename argument
4627 STATUS to LIMIT.
4628 (Vwindow_combination_limit): Remove "status" from doc-string.
4629
d5ff9cd0
AS
46302011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4631
4632 * m/ibms390.h: Remove.
4633 * m/ibms390x.h: Don't include "ibms390.h".
4634
a5bb9bd3
SM
46352011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4636
4637 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4638 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4639
cd1181db
JB
46402011-11-20 Juanma Barranquero <lekktu@gmail.com>
4641
4642 * casetab.c (Fset_case_table):
4643 * charset.c (Fcharset_after): Fix typos.
4644
615a3b8d 46452011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4646
17e845af
PE
4647 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4648 Otherwise, valgrind does not work on some platforms.
4649 Problem reported by Andreas Schwab in
6a0bf43d
PE
4650 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4651 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4652 is set, removing the need for VIRT_ADDRESS_VARIES.
4653 (PURE_P): Use a more-efficient implementation that needs just one
4654 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4655 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4656 to 4 (xorl, subq, cmpq, setbe).
4657 * alloc.c (pure): Always extern now, since that's the
4658 VIRT_ADDR_VARIES behavior.
4659 (PURE_POINTER_P): Use a single comparison, not two, for
4660 consistency with the new puresize.h.
4661 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4662 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4663 Remove VIRT_ADDR_VARIES no longer needed.
4664
f8fe6f96
EZ
46652011-11-19 Eli Zaretskii <eliz@gnu.org>
4666
4667 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4668 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4669 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4670 behave as if the cursor position were at the window margin.
4671
4672 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4673 and the cursor position is out of bounds, behave as if the cursor
4674 position were at the window margin. (Bug#10075)
4675
df05a53c
CY
46762011-11-18 Chong Yidong <cyd@gnu.org>
4677
4678 * window.c (Fwindow_combination_limit): Make first argument
4679 non-optional, since it is meaningless for live windows like the
4680 selected window.
61ccba97 4681
2071918e
DA
46822011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4683
4684 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4685
b50a28de
SM
46862011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4687
4688 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4689 (graft_intervals_into_buffer): Simplify.
4690
015137db
EZ
46912011-11-18 Eli Zaretskii <eliz@gnu.org>
4692
4693 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4694 hash values of the two rows.
4695 (copy_row_except_pointers): Preserve the used[] arrays and the
4696 hash values of the two rows. (Bug#10035)
68c95424 4697 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4698
4699 * xdisp.c (row_hash): New function, body extracted from
4700 compute_line_metrics.
4701 (compute_line_metrics): Call row_hash, instead of computing the
4702 hash code inline.
4703
4704 * dispnew.c (verify_row_hash): Call row_hash for computing the
4705 hash code of a row, instead of duplicating code from xdisp.c.
4706
4707 * dispextern.h (row_hash): Add prototype.
4708
a2addb04
TH
47092011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4710
4711 * frame.c (delete_frame): Don't delete the terminal when the last
4712 X frame is closed if emacs is built with GTK toolkit.
4713
df85d315
JB
47142011-11-17 Juanma Barranquero <lekktu@gmail.com>
4715
4716 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4717
a0c2d0ae
MR
47182011-11-17 Martin Rudalics <rudalics@gmx.at>
4719
4720 * window.c (Vwindow_splits): Rename to
4721 Vwindow_combination_resize. Suggested by Juri Linkov.
4722 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4723 of Vwindow_splits.
4724
58179cce
JB
47252011-11-16 Juanma Barranquero <lekktu@gmail.com>
4726
7877f373
JB
4727 * nsfns.m (Fns_font_name):
4728 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4729
b6f67890
MR
47302011-11-16 Martin Rudalics <rudalics@gmx.at>
4731
4732 * window.h (window): Rename slot "nest" to "combination_limit".
4733 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4734 (Fset_window_nest): Rename to Fset_window_combination_limit.
4735 (Vwindow_nest): Rename to Vwindow_combination_limit.
4736 (recombine_windows, make_parent_window, make_window)
4737 (Fsplit_window_internal, saved_window)
4738 (Fset_window_configuration, save_window_save): Rename all
4739 occurrences of window_nest to window_combination_limit.
4740
c7015153
JB
47412011-11-15 Juanma Barranquero <lekktu@gmail.com>
4742
4743 * image.c (imagemagick_load_image): Fix typo.
4744
322ad6ec
EZ
47452011-11-14 Eli Zaretskii <eliz@gnu.org>
4746
4747 * xdisp.c (display_line): Move the call to
4748 highlight_trailing_whitespace before the call to
4749 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4750 faces of all the glyphs to compute ROW's hash value.
4751 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4752
f067b8ec
JB
47532011-11-14 Juanma Barranquero <lekktu@gmail.com>
4754
4755 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4756 just return (bug#10044).
4757
1e5b2111
EZ
47582011-11-12 Eli Zaretskii <eliz@gnu.org>
4759
7ef3cbd5
EZ
4760 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4761 with user-defined heap size. Bump the default size of the temacs
4762 heap to 27MB, to avoid memory warning when running temacs.
4763 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4764
1e5b2111
EZ
4765 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4766 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4767 (verify_row_hash) [XASSERTS]: New function.
4768 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4769 that the hash value of glyph rows is correct.
1e5b2111 4770
89d61221
MR
47712011-11-12 Martin Rudalics <rudalics@gmx.at>
4772
4773 * window.h (window): Remove splits slot.
4774 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4775 (Fdelete_other_windows_internal, make_parent_window)
4776 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4777 (Fset_window_configuration, save_window_save): Don't deal with
4778 split status of windows.
4779 (saved_window): Remove splits slot.
4780 (Vwindow_splits): Rewrite doc-string.
4781
97f18cc8
JD
47822011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4783
4784 * xfns.c (unwind_create_frame):
4785 * nsfns.m (unwind_create_frame):
4786 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4787 Vframe_list (Bug#9999).
4788
22a648b4
DA
47892011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4790
0b381c7e 4791 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4792
659afede
KH
47932011-11-11 Kenichi Handa <handa@m17n.org>
4794
4795 * callproc.c (Fcall_process): Set the member dst_multibyte of
4796 process_coding.
4797
9ac0394b
KH
47982011-11-11 Johan Bockgård <bojohan@gnu.org>
4799
4800 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4801 avoid a crash (bug#9496).
4802
2fbdc249
CY
48032011-11-09 Chong Yidong <cyd@gnu.org>
4804
4805 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4806 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4807
ac6b1f81
PE
48082011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4809
4810 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4811
09db192c
PE
48122011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4813
4814 Avoid some portability problems by eschewing 'extern inline' functions.
4815 The trivial performance wins aren't worth the portability hassles; see
4816 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4817 et seq.
4818 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4819 (window_box_width, window_box_left, window_box_left_offset)
4820 (window_box_right, window_box_right_offset): Undo previous change,
4821 by removing the "extern"s.
4822 * intervals.c (adjust_intervals_for_insertion)
4823 (adjust_intervals_for_deletion): Undo previous change,
4824 making these static again.
4825 (offset_intervals, temp_set_point_both, temp_set_point)
4826 (copy_intervals_to_string): No longer inline.
4827 * xdisp.c (window_text_bottom_y, window_box_width)
4828 (window_box_height, window_box_left_offset)
4829 (window_box_right_offset, window_box_left, window_box_right)
4830 (window_box): No longer inline.
4831
105216ed
CY
48322011-11-08 Chong Yidong <cyd@gnu.org>
4833
4834 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4835 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4836 Signal an error if not a live window.
105216ed
CY
4837 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4838 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4839
ae9e237f
JB
48402011-11-07 Juanma Barranquero <lekktu@gmail.com>
4841
4842 * lisp.h (syms_of_abbrev): Remove declaration.
4843 Reported by CHENG Gao <chenggao@royau.me>.
4844
c7aa8333
EZ
48452011-11-07 Eli Zaretskii <eliz@gnu.org>
4846
4847 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4848 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4849 of temacs in GUI mode.
4850
be7f5545
MR
48512011-11-07 Martin Rudalics <rudalics@gmx.at>
4852
4853 * window.h: Declare delete_all_child_windows instead of
4854 delete_all_subwindows.
4855 * window.c (Fwindow_nest, Fset_window_nest)
4856 (Fset_window_new_total, Fset_window_new_normal)
4857 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4858 (delete_all_subwindows): Rename to delete_all_child_windows.
4859 (Fdelete_other_windows_internal, Fset_window_configuration):
4860 Call delete_all_child_windows instead of delete_all_subwindows.
4861 * frame.c (delete_frame): Call delete_all_child_windows instead
4862 of delete_all_subwindows.
4863
ca78dc43
PE
48642011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4865
4866 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4867 This is also needed for porting to any host where GC_MARK_STACK is
4868 not GC_MAKE_GCPROS_NOOPS.
4869 (which_symbols): Use it.
4870
a0241d01
KH
48712011-11-07 Kenichi Handa <handa@m17n.org>
4872
4873 * coding.c (coding_set_destination): Check coding->src_pos only
4874 when coding->src_object is a buffer (bug#9910).
4875
4876 * process.c (send_process): Set the member src_multibyte of coding
4877 to 0 (bug#9911) when sending a unibyte text.
4878
4879 * callproc.c (Fcall_process): Set the member src_multibyte of
4880 process_coding to 0 (bug#9912).
4881
a64bfdfa 48822011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4883
4884 * xmenu.c (cleanup_widget_value_tree): New function.
4885 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4886 calling free_menubar_widget_value_tree directly (Bug#9830).
4887
cb41b32a
PE
48882011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4889
4890 Fix some portability problems with 'inline'.
4891 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4892 (window_box_width, window_box_left, window_box_left_offset)
4893 (window_box_right, window_box_right_offset): Declare extern.
4894 Otherwise, these inline functions do not conform to C99 and
4895 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4896 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4897 * intervals.c (adjust_intervals_for_insertion)
4898 (adjust_intervals_for_deletion): Now extern, because otherwise the
4899 extern inline functions 'offset_intervals' couldn't refer to it.
4900 (static_offset_intervals): Remove.
4901 (offset_intervals): Rewrite using the old contents of
4902 static_offset_intervals. The old version didn't conform to C99
4903 because an extern inline function contained a reference to an
4904 identifier with static linkage.
4905
b7041366
AS
49062011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4907
4908 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4909 GC.
4910
88a37c4d
EZ
49112011-11-06 Eli Zaretskii <eliz@gnu.org>
4912
4913 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4914 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4915 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4916 return Qleft_to_right.
4917
49745b39
CY
49182011-11-06 Chong Yidong <cyd@gnu.org>
4919
4920 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4921 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4922 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4923 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4924 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4925 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4926 (Fwindow_vscroll): Doc fix.
4927 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4928 argument, since it makes no sense to pass a live window and for
4929 consistency with window-child.
4930
1f05cd82
CS
49312011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4932
4933 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4934 support MSVC.
4935
22610910
JR
49362011-11-05 Jason Rumney <jasonr@gnu.org>
4937
4938 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4939 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4940 fonts (Bug#6029).
4941 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4942 bitwise arithmetic preventing use of unicode-sip and non-truetype
4943 opentype fonts.
4944
a06776b2
EZ
49452011-11-05 Eli Zaretskii <eliz@gnu.org>
4946
3ad924ba
EZ
4947 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4948 "emacs"-only part.
4949
a06776b2
EZ
4950 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4951 initialization code to keep similarity to xfns.c after changes
4952 from 2011-11-05.
4953
c9e7db78
JD
49542011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4955
a97f8f3f
JD
4956 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4957 (unwind_create_frame): New function (Bug#9943).
4958 (Fx_create_frame): Restructure code to be more similar to the one in
4959 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4960 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4961 Move terminal->reference_count++ just before making the frame official
4962 (Bug#9943).
4963
4964 * nsterm.m (x_free_frame_resources): New function.
4965 (x_destroy_window): Move code to x_free_frame_resources.
4966
c9e7db78 4967 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4968 (Fx_create_frame, x_create_tip_frame):
4969 Move terminal->reference_count++ just before making the frame
75f1671a 4970 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4971 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4972
a6fc3b5c
EZ
49732011-11-05 Eli Zaretskii <eliz@gnu.org>
4974
4975 Support MSVC build with newer versions of Visual Studio.
4976 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4977 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4978 nt/gmake.defs.
4979
4980 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4981 which are not supported by MSVC.
4982 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4983 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4984 bitfields.
4985 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4986 types in bitfields.
4987 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4988
4989 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4990
58179cce 49912011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4992
4993 Support MSVC build with newer versions of Visual Studio.
4994 * w32.c: Don't include w32api.h for MSVC.
4995 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4996
4997 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4998 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4999 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5000 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5001 e_* cousins.
5002 (alloca) [_MSC_VER]: Define to _alloca.
5003
5004 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5005
5006 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5007
a58c13ed
EZ
50082011-11-04 Eli Zaretskii <eliz@gnu.org>
5009
5010 * xdisp.c (note_mouse_highlight): If either of
5011 previous/next-single-property-change returns nil, treat that as
5012 the beginning or the end of the buffer. (Bug#9955)
5013
fe0b6370
JD
50142011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5015
a58c13ed 5016 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5017 label is not null (Bug#9951).
5018 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5019 may be NULL.
5020
89bd5ee1
EZ
50212011-11-04 Eli Zaretskii <eliz@gnu.org>
5022
5023 * window.c (Fwindow_body_size): Mention in the doc string that the
5024 return value is in frame's canonical units. (Bug#9949)
5025
84c3edb9
EZ
50262011-11-03 Eli Zaretskii <eliz@gnu.org>
5027
4e2fb5c7
EZ
5028 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5029
84c3edb9 5030 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5031 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5032 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5033
bc17a887
EZ
50342011-11-01 Eli Zaretskii <eliz@gnu.org>
5035
5036 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5037 Don't stop backward scan on the continuation glyph, even though
5038 its CHARPOS is positive.
6d5eb5b0
SM
5039 (mouse_face_from_buffer_pos, note_mouse_highlight):
5040 Rename cover_string to disp_string.
bc17a887 5041
4ee88440
MR
50422011-11-01 Martin Rudalics <rudalics@gmx.at>
5043
5044 * window.c (temp_output_buffer_show): Don't use
5045 Vtemp_buffer_show_specifiers.
5046 (Vtemp_buffer_show_specifiers): Remove unused variable.
5047
c2ff3c02
EZ
50482011-10-30 Eli Zaretskii <eliz@gnu.org>
5049
5050 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5051 past the beginning of the current glyph matrix.
5052
58179cce 50532011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5054
5055 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5056 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5057 HAVE_GTK3 (Bug#9869).
b77a6a7f 5058
3b574623
JD
5059 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5060 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5061
b77a6a7f
JD
5062 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5063
5064 * xterm.c: Declare x_handle_net_wm_state to return int.
5065 (handle_one_xevent): Check if we are iconified but don't have
5066 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5067 (get_current_wm_state): Return non-zero if not hidden,
5068 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5069 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5070 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5071 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5072
196e41e4
PE
50732011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5074
5075 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5076 so that this new function doesn't get optimized away by a
5077 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5078
021f2e1a
AS
50792011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5080
5081 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5082
8b058d44
EZ
50832011-10-29 Eli Zaretskii <eliz@gnu.org>
5084
5085 Fix the `xbytecode' command.
5086 * .gdbinit (xprintbytestr): New command.
b50a28de 5087 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5088 (xbytecode): Print the byte-code string as well.
5089
4452fb80
EZ
50902011-10-29 Kim Storm <storm@cua.dk>
5091
8b058d44
EZ
5092 * alloc.c (which_symbols): New function.
5093
21b72067
AS
50942011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5095
5096 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5097 line. (Bug#9903)
5098
83ed7b5c
GM
50992011-10-29 Glenn Morris <rgm@gnu.org>
5100
5101 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5102 Not clear what it was for, and it causes various bugs. (Bug#9839)
5103
5a7a728b
EZ
51042011-10-28 Eli Zaretskii <eliz@gnu.org>
5105
5106 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5107 possible random value that matches one of those tested as
5108 condition to clear the mouse face.
5109
d3d0842f
CY
51102011-10-28 Chong Yidong <cyd@gnu.org>
5111
5112 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5113
31b39d13
DN
51142011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5115
5116 * window.c (make_window): Initialize phys_cursor_on_p.
5117
9aba6043
SM
51182011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5119
5120 * lisp.h (struct Lisp_Symbol): Update comments.
5121
c20992f4
JB
51222011-10-28 Juanma Barranquero <lekktu@gmail.com>
5123
5124 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5125
db4f02f2
EZ
51262011-10-28 Eli Zaretskii <eliz@gnu.org>
5127
5128 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5129 <oslsachem@gmail.com> for helping to debug this.
5130
5131 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5132 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5133 (g_b_init_get_glyph_outline_w): New static variables.
5134 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5135 (GetGlyphOutlineW_Proc): New typedefs.
5136 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5137 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5138 New functions.
5139 (w32font_open_internal, compute_metrics):
5140 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5141 instead of calling the "wide" APIs directly.
5142
5143 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5144
5145 * w32.h (syms_of_w32font): Add prototype.
5146
87e68db4
JB
51472011-10-27 Juanma Barranquero <lekktu@gmail.com>
5148
5149 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5150 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5151 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5152 (Fmove_to_window_line): Doc fix.
5153
435c1d67
CY
51542011-10-27 Chong Yidong <cyd@gnu.org>
5155
5156 * process.c (make_process): Set gnutls_state to NULL.
5157
5158 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5159 non-NULL, regardless of GNUTLS_INITSTAGE.
5160 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5161 an error. Set process slots as soon as we allocate them.
5162
5163 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5164
9c6c6f49
CY
51652011-10-27 Chong Yidong <cyd@gnu.org>
5166
9aba6043
SM
5167 * gnutls.c (emacs_gnutls_deinit): New function.
5168 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5169 (Fgnutls_deinit, Fgnutls_boot): Use it.
5170
5171 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5172 (deactivate_process): Call emacs_gnutls_deinit.
5173
657d08d3
JB
51742011-10-27 Juanma Barranquero <lekktu@gmail.com>
5175
5176 * image.c (x_create_x_image_and_pixmap):
5177 * w32.c (sys_rename, w32_delayed_load):
5178 * w32font.c (fill_in_logfont):
5179 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5180
5430d399
JB
51812011-10-26 Juanma Barranquero <lekktu@gmail.com>
5182
5183 * w32fns.c (w32_default_color_map): New function,
5184 extracted from Fw32_default_color_map.
a7ef684b 5185 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5186
fe0055fa
PE
51872011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5188
5189 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5190
e6346438
SM
51912011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5192
5193 * keyboard.c (test_undefined): New function (bug#9751).
5194 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5195
e112cc37
ET
51962011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5197
5198 * sysdep.c (init_sys_modes): Fix the check for the controlling
5199 terminal (Bug#6649).
5200
7b5d6677
EZ
52012011-10-20 Eli Zaretskii <eliz@gnu.org>
5202
5203 * dispextern.h (struct bidi_it): New member next_en_type.
5204
5205 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5206 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5207 current character, check also for next_en_type being WEAK_EN.
5208 (bidi_resolve_weak): Don't enter the expensive loop if the current
5209 position is before next_en_pos. Record the bidi type of the first
5210 non-ET, non-BN character we find, in addition to its position.
5211 (bidi_level_of_next_char): Invalidate next_en_type when
5212 next_en_pos is over-stepped.
5213
7da0b018
PE
52142011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5215
5216 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5217 * editfns.c: Rewrite current-time-zone so that it invokes
5218 the equivalent of (format-time-string "%Z") to get the time zone name.
5219 This fixes a bug when the time zone name contains characters that
5220 need converting from the system time locale to Emacs internal format.
5221 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5222 that patch fixed format-time-string to do the conversion, but
5223 I forgot to fix current-time-zone.
5224 (format_time_string): New function, containing most of
5225 what Fformat_time_string used to contain.
5226 (Fformat_time_string): Rewrite in terms of format_time_string.
5227 This doesn't change this function's behavior.
5228 (current-time-zone): Rewrite to use format_time_string.
5229 This fixes the bug reported by Michael Schierl in
5230 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5231 Jason Rumney's 2007-06-07 change worked around this bug, but
5232 didn't fix it.
5233 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5234
8547b010
EZ
52352011-10-19 Eli Zaretskii <eliz@gnu.org>
5236
5237 * xdisp.c (start_display): If the character at POS is displayed
5238 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5239 (try_window_reusing_current_matrix): If a line ends in a display
5240 vector or the next line starts in a display vector, continue
5241 redrawing the window even though the character position of
5242 start_row was reached.
8547b010
EZ
5243 (Bug#9771, part 2)
5244
4e948d15
CY
52452011-10-18 Chong Yidong <cyd@gnu.org>
5246
5247 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5248 with nobreak-char-display too.
5249
4787455f
EZ
52502011-10-18 Eli Zaretskii <eliz@gnu.org>
5251
5252 Fix part 3 of bug#9771.
5253 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5254 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5255 non-neutral characters if the current character is a paragraph
5256 separator (a.k.a. Newline). This avoids running the same
5257 expensive loop twice, once when we consume the preceding newline
5258 and the other time when the line actually needs to be displayed.
5259 Avoid the loop when we see neutrals on the base embedding level
5260 following a character whose directionality is the same as the
5261 paragraph's. This avoids running the expensive loop when a line
5262 ends in a long sequence of neutrals, like control characters.
5263 Add assertion against STRONG_AL type. Slightly rearrange code
5264 that determines the type of a neutral given the first non-neutral
5265 that follows it.
5266 (bidi_level_of_next_char): Set next_en_pos to zero when
5267 invalidating its info.
5268
2c91f553
EZ
52692011-10-17 Eli Zaretskii <eliz@gnu.org>
5270
5271 * xdisp.c (push_display_prop): Determine whether to record string
5272 or buffer position by IT->string, not by IT->method. Allow
5273 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5274 (move_it_vertically_backward): Don't look for character position
5275 immediately after the newline when in a continuation line.
5276 (Bug#9771, part 1)
2c91f553 5277
c7b08b0d
MR
52782011-10-15 Martin Rudalics <rudalics@gmx.at>
5279
5280 * window.c (coordinates_in_window): Rewrite and delabelize
5281 vertical border check. (Bug#5357) (Bug#9618)
5282
6b02f655
SM
52832011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5284
5285 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5286 errors in XSetWindowBorder (bug#9310).
5287
81d40c92
DA
52882011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5289
5290 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5291 avoid crash when xmalloc overrun checking is enabled.
5292
d4172c3b
EZ
52932011-10-13 Eli Zaretskii <eliz@gnu.org>
5294
5295 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5296 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5297 cursor motion with <left> and <right> arrow keys.
5298
5299 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5300 some callers set that themselves.
5301
b00eea75
EZ
53022011-10-12 Eli Zaretskii <eliz@gnu.org>
5303
5304 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5305 display string and the previous row comes from the same string and
5306 is empty. (Bug#9739) (Bug#9738)
5307
8fe012c4
SM
53082011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5309
5310 * doc.c (get_doc_string): Encode file name (bug#9735).
5311
0074aef2
EZ
53122011-10-12 Eli Zaretskii <eliz@gnu.org>
5313
79beb178
EZ
5314 * bidi.c (bidi_level_of_next_char):
5315 * xdisp.c (get_visually_first_element): Remove old incorrect
5316 comments regarding the Unicode Line Separator character.
5317
0074aef2
EZ
5318 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5319
6e4b3fbe
DA
53202011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5321
5322 * alloc.c (Fgc_status): Do not access beyond zombies array
5323 boundary if nzombies > MAX_ZOMBIES.
5324 * alloc.c (dump_zombies): Add missing format specifier.
5325
0324f3af
PE
53262011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5327
b5525cac
PE
5328 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5329 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5330
0324f3af
PE
5331 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5332 Some packages use them to denote characters with modifiers.
5333
e9b5f888
AS
53342011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5335
5336 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5337 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5338 matching a pp-number. Rename parameter var to var1.
5339
127827c0
SM
53402011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5341
5342 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5343
c8fd3bd0
GM
53442011-10-08 Glenn Morris <rgm@gnu.org>
5345
5346 * callint.c (Fcall_interactively): Give a more explicit error for the
5347 'c' case with a non-character input. (Bug#8479)
5348
352ec8ff
EZ
53492011-10-08 Eli Zaretskii <eliz@gnu.org>
5350
03669ccb
EZ
5351 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5352 lines.
7061c986
EZ
5353 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5354 lines that are hscrolled on the left.
03669ccb 5355
352ec8ff
EZ
5356 * dispnew.c (buffer_posn_from_coords): Account for a possible
5357 presence of header-line. (Bug#4426)
5358
a66cfb1c
SM
53592011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5360
6b02f655
SM
5361 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5362 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5363
7c5ee88e
PE
53642011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5365
5366 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5367 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5368 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5369 this makes Emacs dump core during garbage collection on rare
5370 occasions. sizeof is obviously inferior to offsetof here, so
5371 stick with offsetof.
5372 (GC_POINTER_ALIGNMENT): New macro.
5373 (mark_memory): Omit 3rd (offset) arg; caller changed.
5374 Don't assume EMACS_INT alignment is the same as pointer alignment.
5375
df1bbe5b
SM
53762011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5377
5378 * keyboard.c (read_key_sequence_remapped): New var.
5379 (read_key_sequence): Compute remapping in the right buffer.
5380 (command_loop_1): Use read_key_sequence's remapping directly.
5381
51553db6
SM
53822011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5383
32c1fffd
SM
5384 * dired.c (file_name_completion): Don't expand file name.
5385 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5386 before checking file name handler.
5387
51553db6
SM
5388 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5389 they've been requested explicitly (bug#9591).
5390
b6bd1599 53912011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5392
5393 * keymap.c (Fsingle_key_description): Use make_specified_string
5394 instead of build_string to build string from push_key_description.
5395 (Bug#5193)
5396
f701dc2a
PE
53972011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5398
4222c55d
PE
5399 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5400 This fixes a Y2038 bug on 64-bit hosts.
5401 * buffer.c (reset_buffer):
5402 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5403 (Fclear_buffer_auto_save_failure):
5404 Use 0, not -1, to represent an unset failure time, since time_t
5405 might not be signed.
5406
f701dc2a
PE
5407 Remove dependency on glibc malloc internals.
5408 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5409 Move back here from lisp.h, but with their new implementations.
5410 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5411 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5412 * charset.c (charset_table_init): New static var.
5413 (syms_of_charset): Use it instead of xmalloc. This removes a
5414 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5415 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5416 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5417 Move back to alloc.c.
5418 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5419 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5420
9ceebf39
JD
54212011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5422
5423 * nsterm.m (windowDidResize): Call x_set_window_size only when
5424 ns_in_resize is true. Otherwise set pixelwidth/height and
5425 call change_frame_size (Bug#9628).
5426
cb993c58
PE
54272011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5428
3930c88b
PE
5429 Port --enable-checking=all to Fedora 14 x86-64.
5430 * charset.c (syms_of_charset): Also account for glibc malloc's
5431 internal overhead when calculating the initial malloc maximum.
5432
cb993c58
PE
5433 Port --enable-checking=all to Fedora 14 x86.
5434 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5435 Move to lisp.h.
5436 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5437 (overrun_check_realloc, overrun_check_free):
5438 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5439 That way, xmalloc returns a properly-aligned pointer even if
5440 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5441 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5442 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5443 into account when calculating the initial malloc maximum.
5444 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5445 Move here from alloc.c, so that charset.c can use it too.
5446 Properly align; the old code wasn't right for common 32-bit hosts
5447 when configured with --enable-checking=all.
5448 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5449 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5450
31bed486
EZ
54512011-09-29 Eli Zaretskii <eliz@gnu.org>
5452
04c70788 5453 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5454 use EDOM.
5455
fbcaa2f3
EZ
54562011-09-28 Eli Zaretskii <eliz@gnu.org>
5457
5458 * xdisp.c (compute_display_string_end): If there's no display
5459 string at CHARPOS, return -1.
5460
5461 * bidi.c (bidi_fetch_char): When compute_display_string_end
5462 returns a negative value, treat the character as a normal
5463 character not covered by a display string. (Bug#9624)
5464
a239d4e9
JB
54652011-09-28 Juanma Barranquero <lekktu@gmail.com>
5466
5467 * lread.c (Fread_from_string): Fix typo in docstring.
5468
88652fd5
EZ
54692011-09-27 Eli Zaretskii <eliz@gnu.org>
5470
5471 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5472 newline, reseat the iterator instead of bidi-iterating there one
5473 character at a time. (Bug#9610)
32c1fffd
SM
5474 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5475 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5476
ed497dd4
AS
54772011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5478
5479 * lread.c (readevalloop): Use correct code for NBSP.
5480 (read1): Likewise. (Bug#9608)
5481
b2bf61aa
MA
54822011-09-25 Michael Albinus <michael.albinus@gmx.de>
5483
5484 * dbusbind.c (Fdbus_register_signal): When service is not
5485 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5486
32bbb17c
GM
54872011-09-25 Glenn Morris <rgm@gnu.org>
5488
5489 * buffer.c (truncate-lines): Doc fix.
5490
94e0933e
CY
54912011-09-24 Chong Yidong <cyd@stupidchicken.com>
5492
5493 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5494 (Fset_window_next_buffers): Doc fix.
5495
cddde921
GM
54962011-09-24 Glenn Morris <rgm@gnu.org>
5497
5498 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5499
1260aef1
PE
55002011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5501
25b4bfa0
PE
5502 Fix minor problems found by static checking.
5503 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5504 * indent.c (Fvertical_motion): Fix == vs = typo.
5505
e3cbd34b
EZ
55062011-09-24 Eli Zaretskii <eliz@gnu.org>
5507
a66cfb1c
SM
5508 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5509 Default value is now t. Doc fix.
6bf7006f 5510
e3cbd34b 5511 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5512 logic when moving up, not only when moving down. Fix the
e3cbd34b 5513 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5514 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5515
5516 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5517 CHARPOS is covered by a display string which includes newlines.
5518 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5519 is covered by a display string with embedded newlines.
5520
a3de0cbd
MA
55212011-09-24 Michael Albinus <michael.albinus@gmx.de>
5522
5523 * dbusbind.c (Fdbus_register_signal): Add match rule to
5524 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5525 (Fdbus_register_method, Vdbus_registered_objects_table):
5526 Fix docstring.
a3de0cbd 5527
b260039d
JM
55282011-09-24 Jim Meyering <meyering@redhat.com>
5529
32c1fffd 5530 do not ignore write error for any output size
b260039d
JM
5531 The previous change was incomplete.
5532 While it makes emacs --batch detect the vast majority of stdout
5533 write failures, errors were still ignored whenever the output size is
5534 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5535 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5536 && echo FAIL: ignored write error
5537 FAIL: ignored write error
5538 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5539 && echo FAIL: ignored write error
5540 FAIL: ignored write error
5541 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5542
8eca8a7c
AS
55432011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5544
5545 * emacs.c (Fkill_emacs): In noninteractive mode exit
5546 non-successfully if a write error occurred on stdout. (Bug#9574)
5547
3341db62
EZ
55482011-09-21 Eli Zaretskii <eliz@gnu.org>
5549
5550 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5551 the xassert test.
5552
5553 * dispextern.h (struct it): Update the comment documenting what
5554 can it->OBJECT be.
5555
8c203dbf
EZ
55562011-09-20 Eli Zaretskii <eliz@gnu.org>
5557
5558 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5559 a display string, extend search for cursor position to end of row.
5560 (find_row_edges): If the row ends in a newline from a display
5561 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5562 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5563 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5564 non-empty line. Fixes confusing cursor motion with arrow keys at
5565 the beginning of a line that starts with whitespace.
8c203dbf 5566
a4824228
LMI
55672011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5568
5569 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5570 (bug#9493).
5571
33ed493b
CY
55722011-09-18 Chong Yidong <cyd@stupidchicken.com>
5573
5574 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5575 boolean (Bug#9154).
5576
56cd55c8
EZ
55772011-09-18 Eli Zaretskii <eliz@gnu.org>
5578
5579 * xdisp.c (display_line): Record maximum and minimum buffer
5580 positions even if no glyphs were produced (e.g., by a zero-width
5581 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5582 buffer positions that will be removed from the glyph row because
5583 they don't fit.
c02dcedf
EZ
5584 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5585 column is beyond frame width: don't subtract 1 "pixel" when
5586 computing width of the stretch.
3e62b7e0
EZ
5587 (reseat_at_next_visible_line_start): Undo the change made on
5588 2011-09-17 that saved paragraph information and restored it after
5589 the call to `reseat'. (Bug#9545)
56cd55c8 5590
5ed99d36 55912011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5592
5593 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5594 and turn window cursor on if cleared (Bug#9415).
5595
5ed99d36 55962011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5597
5598 * search.c (boyer_moore): Take unibyte characters from pattern
5599 literally. (Bug#9458)
5600
9bade7b2
EZ
56012011-09-18 Eli Zaretskii <eliz@gnu.org>
5602
5603 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5604
e5e9d610
PE
56052011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5606
87e4427a
PE
5607 Fix minor problem found by static checking.
5608 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5609 initialized, to pacify gcc -Wuninitialized.
5610
e5e9d610
PE
5611 * fileio.c: Report proper errno when syscall falls.
5612 (Finsert_file_contents): Save and restore errno,
5613 so that report_file_error outputs the correct diagnostic.
5614 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5615
a1674f0b
EZ
56162011-09-18 Eli Zaretskii <eliz@gnu.org>
5617
5618 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5619
fbfb6dd4
EZ
56202011-09-17 Eli Zaretskii <eliz@gnu.org>
5621
5622 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5623 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5624
bb187662
EZ
56252011-09-17 Eli Zaretskii <eliz@gnu.org>
5626
1137e8b8 5627 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5628 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5629
5630 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5631 (bidi_find_paragraph_start): Search back for paragraph beginning
5632 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5633 (bidi_move_to_visually_next): Only trigger paragraph-related
5634 computations when the last character is a newline or at EOB, not
5635 just any NEUTRAL_B. (Bug#9470)
5636
bb187662
EZ
5637 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5638 truncated lines if point is covered by a display string. (Bug#9524)
5639
2e621251
PE
56402011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5641
5642 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5643 (cons_to_x_long): New function.
5644 (lisp_data_to_selection_data): Use it. Correct the test for
5645 short-versus-long data; it was negated. Break out of vector
5646 loop, for efficiency, when a long datum is discovered.
5647
91a15bc6
SM
56482011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5649
5650 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5651
b41c3a35
EZ
56522011-09-16 Eli Zaretskii <eliz@gnu.org>
5653
5654 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5655 GCC PR/17406) by declaring this function with external scope.
5656
7812ba2d
PE
56572011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5658
5659 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5660 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5661
cf7edc2a
AS
56622011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5663
5664 * editfns.c (Fformat): Correctly handle text properties on "%%".
5665
bd01620e
EZ
56662011-09-15 Eli Zaretskii <eliz@gnu.org>
5667
5668 * xterm.c (x_draw_composite_glyph_string_foreground):
5669 * w32term.c (x_draw_composite_glyph_string_foreground):
5670 * term.c (encode_terminal_code):
5671 * composite.c (composition_update_it, get_composition_id):
5672 * xdisp.c (get_next_display_element)
5673 (fill_composite_glyph_string): Add comments about special meaning
5674 of TAB characters in a composition.
5675
a02719a3
PE
56762011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5677
5678 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5679 This occurs when processing a multibyte format.
5680 Problem reported by Wolfgang Jenker.
a02719a3 5681
72589a3c
JB
56822011-09-15 Johan Bockgård <bojohan@gnu.org>
5683
5684 * xdisp.c (try_cursor_movement): Only check for exact match if
5685 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5686
1c14176c
PE
56872011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5688
5689 Remove unused external symbols.
5690 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5691 * xdisp.c (calc_pixel_width_or_height): Now static.
5692 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5693 * indent.c (check_display_width):
5694 * w32term.c: Fix comment to match code.
5695 * xterm.c, xterm.h (x_catching_errors): Remove.
5696
d2eea5b5
PE
56972011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5698
5699 * xselect.c: Use signed conversions more consistently (Bug#9498).
5700 (selection_data_to_lisp_data): Assume incoming selection data are
5701 signed integers, not unsigned. This is to be consistent with
5702 outgoing selection data, which was modified to use signed integers
5703 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5704 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5705 expects long, not unsigned long.
5706
46888499
EZ
57072011-09-14 Eli Zaretskii <eliz@gnu.org>
5708
5709 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5710 computation of loop end. Reported by Johan Bockgård
5711 <bojohan@gnu.org>.
5712
ef8ef9fb
CY
57132011-09-13 Chong Yidong <cyd@stupidchicken.com>
5714
5715 * frame.c (Fother_visible_frames_p): Function deleted.
5716
fa819fed
EZ
57172011-09-12 Eli Zaretskii <eliz@gnu.org>
5718
5719 * indent.c (compute_motion): Process display vector front to back
5720 rather than the other way around. (Bug#2496)
5721
2ba8e008
SM
57222011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5723
5724 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5725
20f53c69
CY
57262011-09-11 Chong Yidong <cyd@stupidchicken.com>
5727
5728 * minibuf.c (Fread_from_minibuffer): Doc fix.
5729
d562d7a4
EZ
57302011-09-11 Eli Zaretskii <eliz@gnu.org>
5731
5732 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5733 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5734
1c4d7f3d
LMI
57352011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5736
5737 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5738 value for non-existent files.
5739
b885bf36
EZ
57402011-09-11 Eli Zaretskii <eliz@gnu.org>
5741
5742 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5743 set its "size" to -1. This will set the modtime_size field of
5744 the corresponding buffer to -1, which is what
5745 verify-visited-file-modtime expects for files that do not exist.
5746 (Bug#9139)
5747
6612f0bf
PE
57482011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5749
5750 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5751 here ...
5752 * lisp.h: ... from here. push_key_description is no longer
5753 defined in keyboard.c, so its declaration should not be in
5754 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5755 logically belongs with push_key_description.
5756
dfb3f755
PE
57572011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5758
5759 * buffer.h: Include <sys/types.h> instead of <time.h>.
5760 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5761 Problem reported by Herbert J. Skuhra.
5762
3134906c
LMI
57632011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5764
5765 * xml.c (parse_region): Make the parsing work for
5766 non-comment-starting XML files again (bug#9144).
5767
8d903f4e
AS
57682011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5769
5770 * image.c (gif_load): Fix calculation of bottom and right corner.
5771 (Bug#9468)
5772
80ad64f4
EZ
57732011-09-10 Eli Zaretskii <eliz@gnu.org>
5774
5775 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5776 redisplay in small windows.
5777
208a048d
EZ
57782011-09-09 Eli Zaretskii <eliz@gnu.org>
5779
5780 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5781
9b1c252e
MR
57822011-09-08 Martin Rudalics <rudalics@gmx.at>
5783
5784 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5785 Operate on live windows only.
5786
2949f33b
JB
57872011-09-08 Juanma Barranquero <lekktu@gmail.com>
5788
5789 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5790
e08dcafd
EZ
57912011-09-07 Eli Zaretskii <eliz@gnu.org>
5792
5793 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5794 only under bidi iteration.
5795
115b96bd
JD
57962011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5797
5798 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5799
c8199d0f
PE
58002011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5801
5802 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5803 Without this fix, the command to link temacs failed due to an
5804 undefined symbol __builtin_isnan. This is because
5805 /usr/include/iso/math_c99.h #defines isnan(x) to
5806 __builtin_isnan(x), but the bundled gcc, which identifies itself
5807 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5808 a __builtin_isnan.
5809 * floatfns.c (isnan): #undef, and then #define to a clone of
5810 what's in data.c.
5811 (Fisnan): Always define, since it's always available now.
5812 (syms_of_floatfns): Always define isnan at the Lisp level.
5813
e39b275c 58142011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5815
5816 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5817
b2db44d9 58182011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5819
f4af5137 5820 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5821 The previous code assumed that file offsets (off_t values) fit in
5822 EMACS_INT variables, which is not true on typical 32-bit hosts.
5823 The code messed up by falsely reporting buffer overflow in cases
5824 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5825 when "big" contains more than 2**29 bytes, even though this
5826 inserts just one byte and does not overflow the buffer.
5827 (Finsert_file_contents): Store file offsets as off_t
5828 values, not as EMACS_INT values. Check for overflow when
5829 converting between EMACS_INT and off_t. When checking for
5830 buffer overflow or for overlap, take the offsets into account.
5831 Don't use EMACS_INT for small values where int suffices.
5832 When checking for overlap, fix a typo: ZV was used where
5833 ZV_BYTE was intended.
5834 (Fwrite_region): Don't assume off_t fits into 'long'.
5835 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5836
ecfc0a49
MA
58372011-09-05 Michael Albinus <michael.albinus@gmx.de>
5838
5839 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5840
6511acf2 58412011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5842
0999621a 5843 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5844
5845 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5846 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5847 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5848 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5849 (modify_event_symbol): Do not assume that the length of
5850 name_alist_or_stem is safe to alloca and fits in int.
5851 (Fexecute_extended_command): Likewise for function name and binding.
5852 (Frecursion_depth): Wrap around reliably on integer overflow.
5853 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5854 since some callers pass EMACS_INT values.
5855 (Fsingle_key_description): Don't crash if symbol name contains more
5856 than MAX_ALLOCA bytes.
5857 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5858 (get_minibuffer): Arg is now EMACS_INT, not int.
5859 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5860 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5861 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5862
2be7d702
PE
5863 * dbusbind.c (signature_cat): New function.
5864 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5865 Do not overrun buffer; instead, report string overflow.
5866
9d1df220
PE
5867 * dispnew.c (add_window_display_history): Don't overrun buffer.
5868 Truncate instead; this is OK since it's just a log.
5869
33ef5c64
PE
5870 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5871 even if the time zone offset is outlandishly large.
5872 Don't mishandle offset == INT_MIN.
5873
66c6fdd5
PE
5874 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5875 when creating daemon; the previous buffer-overflow check was incorrect.
5876
d749b01b
PE
5877 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5878 which has the guts of the old verror function.
5879
b5cd1905
PE
5880 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5881 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5882
6e1a67fb
PE
5883 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5884 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5885 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5886 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5887 length of string rather than counting it via multiple sprintfs;
5888 that's simpler and more reliable.
c21721cc
PE
5889 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5890 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5891 sprintf, in case result does not fit in int.
5892
c57b67fc
PE
5893 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5894 (fontset_from_font): Print it.
5895
8a401434
PE
5896 * frame.c (tty_frame_count): Now printmax_t, not int.
5897 (make_terminal_frame, set_term_frame_name): Print it.
5898 (x_report_frame_params): In X, window IDs are unsigned long,
5899 not signed long, so print them as unsigned.
5900 (validate_x_resource_name): Check for implausibly long names,
5901 and don't assume name length fits in 'int'.
5902 (x_get_resource_string): Don't blindly alloca invocation name;
5903 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5904 not fit in int.
5905
6e1a67fb
PE
5906 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5907 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5908 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5909
0df02bf3
PE
5910 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5911 Use esprintf, not sprintf, in case result does not fit in int.
5912
48e30793
PE
5913 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5914 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5915 it as a large positive number.
5916 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5917 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5918
a66ff6d8
PE
5919 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5920 in case result does not fit in int.
5921
aca216ff
PE
5922 * print.c (float_to_string): Detect width overflow more reliably.
5923 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5924 buffer overrun. Don't assume list length fits in 'int'. Treat
5925 print length of 0 as 0, not as infinity; to be consistent with other
5926 uses of print length in this function. Don't overflow print length
5927 index. Don't assume hash table size fits in 'long', or that
5928 vectorlike size fits in 'unsigned long'.
5929
31c286f7
PE
5930 * process.c (make_process): Use printmax_t, not int, to format
5931 process-name gensyms.
5932
55e5faa1
PE
5933 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5934
80f2e268
PE
5935 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5936 to avoid potential buffer overrun.
5937
670741ab
PE
5938 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5939 if X resource line is longer than 512 bytes.
5940
b7163a50
PE
5941 * xfns.c (x_window): Make sprintf buffer a bit bigger
5942 to avoid potential buffer overrun.
5943
ae58ff1f
PE
5944 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5945
c43c8a6a
PE
5946 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5947
3f8236f4
PE
59482011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5949
53e9fe90 5950 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5951 Without these, Emacs silently mishandles large integers sometimes.
5952 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5953 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5954
6511acf2
PE
5955 * xdisp.c (try_window_id): Check Emacs fixnum range before
5956 converting to 'int'.
806add1d 5957
6511acf2 5958 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5959 Check that an Emacs fixnum is in range before assigning it to 'int'.
5960 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5961 values converted from Emacs fixnums.
5962 (Frecenter): Don't wrap around a line count if it is out of 'int'
5963 range; instead, treat it as an extreme value.
5964 (Fset_window_configuration, compare_window_configurations):
5965 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5966
6511acf2
PE
5967 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5968 that can exceed INT_MAX. Check that EMACS_INT value is in range
5969 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5970 (match_limit): Don't assume that a fixnum can fit in 'int'.
5971
6511acf2 5972 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5973 exceed INT_MAX.
5974
6511acf2 5975 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5976 (Fvertical_motion): Don't wrap around LINES values that don't fit
5977 in 'int'. Instead, treat them as extreme values. This is good
5978 enough for windows, which can't have more than INT_MAX lines anyway.
5979
fcb901a7
LMI
59802011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5981
0f2f6b6d
LMI
5982 * Require libxml/parser.h to avoid compilation warning.
5983
fcb901a7
LMI
5984 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5985
5986 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5987 since this reportedly can destroy thread storage.
5988
6e20a0d4
CY
59892011-08-30 Chong Yidong <cyd@stupidchicken.com>
5990
5991 * syntax.c (find_defun_start): Update all cache variables if
5992 exiting early (Bug#9401).
5993
148ae00e
EZ
59942011-08-30 Eli Zaretskii <eliz@gnu.org>
5995
f6cfbd8f
EZ
5996 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5997
148ae00e
EZ
5998 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5999 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6000 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6001
6002 * term.c (tty_append_glyph): New function.
6003 (produce_stretch_glyph): Static function and its prototype deleted.
6004
a66cfb1c
SM
6005 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6006 Add prototypes.
148ae00e 6007
c4a07a4c
PE
60082011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6009
6010 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6011 when checking :margin (Bug#9390).
6012 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6013 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6014 so that the name doesn't mislead. All uses changed.
6015
6bc8cd65
JB
60162011-08-28 Johan Bockgård <bojohan@gnu.org>
6017
6018 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6019 set_tty_hooks.
6020
dca4927e
EZ
60212011-08-27 Eli Zaretskii <eliz@gnu.org>
6022
6023 * xdisp.c (move_it_to): Don't bail out early when reaching
6024 position beyond to_charpos, if we are scanning backwards.
6025 (move_it_vertically_backward): When DY == 0, make sure we get to
6026 the first character in the line after the newline.
6027
f2cad773
PE
60282011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6029
6030 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6031 (ccl_driver): Do not generate an out-of-range pointer.
6032 (Fccl_execute_on_string): Remove unnecessary check for
6033 integer overflow, noted by Stefan Monnier in
6034 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6035 Remove a FIXME that didn't need fixing.
6036 Simplify the newly-introduced buffer reallocation code.
6037
0cae2cdb
JB
60382011-08-27 Juanma Barranquero <lekktu@gmail.com>
6039
6040 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6041
5fc295a4 60422011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6043
70c60eb2 6044 Integer and memory overflow issues (Bug#9196).
726e0ab1 6045
d31850da
PE
6046 * doc.c (get_doc_string): Rework so that
6047 get_doc_string_buffer_size is the actual buffer size, rather than
6048 being 1 less than the actual buffer size; this makes xpalloc more
6049 convenient.
6050
a69fbedb
PE
6051 * image.c (x_allocate_bitmap_record, cache_image):
6052 * xselect.c (Fx_register_dnd_atom):
6053 Simplify previous changes by using xpalloc.
6054
fe5c5d37
PE
6055 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6056 since either will do and ptrdiff_t is convenient with xpalloc.
6057
0065d054
PE
6058 * charset.c (charset_table_size)
6059 (struct charset_sort_data.priority): Now ptrdiff_t.
6060 (charset_compare): Don't overflow if priorities differ greatly.
6061 (Fsort_charsets): Don't assume list length fits in int.
6062 Check for size-calculation overflow when allocating sort data.
6063 (syms_of_charset): Allocate an initial charset table that is
6064 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6065
6066 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6067
6068 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6069 The actual value is always <= INT_MAX, and leaving it unsigned made
6070 overflow checking harder.
6071
6072 * dispextern.h (struct glyph_matrix.rows_allocated)
6073 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6074 with xpalloc. The values are still always <= INT_MAX.
6075
6076 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6077
6078 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6079 (SAFE_NALLOCA): New macro.
6080
6081 * region-cache.c (struct boundary.pos, find_cache_boundary)
6082 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6083 (set_cache_region, invalidate_region_cache)
6084 (revalidate_region_cache, know_region_cache, region_cache_forward)
6085 (region_cache_backward, pp_cache):
6086 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6087 so that ptrdiff_t * can be passed to xpalloc.
6088 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6089 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6090 (pp_cache): Don't assume cache_len fits in int.
6091 * region-cache.h: Adjust extern decls to match.
6092
6093 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6094 EMACS_INT, since either will do, for xpalloc.
6095
6096 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6097 (xnmalloc, xnrealloc, xpalloc): New functions.
6098
726e0ab1
PE
6099 * bidi.c (bidi_shelve_header_size): New constant.
6100 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6101 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6102
51f30bc5 6103 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6104 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6105 (overlay_strings):
6106 Don't update size of array until after memory allocation succeeds,
6107 because xmalloc/xrealloc may not return.
0065d054
PE
6108 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6109 now that we have proper integer overflow checking.
6110 (record_overlay_string, overlay_strings): Catch overflows when
6111 calculating size of overlay_str_buf.
726e0ab1 6112
0065d054
PE
6113 * callproc.c (Fcall_process): Check for size overflow when
6114 calculating size of args2.
6115 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6116 Normally we prefer signed values, but sticking with ptrdiff_t would
6117 require adding more-complicated checks.
726e0ab1
PE
6118
6119 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6120 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6121 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6122 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6123
6124 * character.c (Fstring): Check for size-calculation overflow.
6125
6126 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6127 unnecessary integer overflow. Check for size overflow.
6128 (encode_coding_object): Don't update size until xmalloc succeeds.
6129
6130 * composite.c (get_composition_id): Check for overflow in glyph
6131 length calculations.
6132
6133 Integer and memory overflow fixes for display code.
6134 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6135 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6136 (scrolling_window): Check for overflow in size calculations.
6137 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6138 Don't assume glyph table len fits in int.
6139 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6140 (row_table_size): Now ptrdiff_t, not int.
6141 (scrolling_window): Avoid overflow in size calculations.
6142 Don't update size until allocation succeeds.
6143 * fns.c (concat): Check for overflow in size calculations.
6144 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6145 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6146 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6147
6148 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6149 (get_doc_string): Check for size calculation overflow.
6150 Don't update size until allocation succeeds.
6151 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6152 EMACS_INT, where ptrdiff_t will do.
6153 (Fsubstitute_command_keys): Check for string overflow.
6154
6155 * editfns.c (set_time_zone_rule): Don't assume environment length
6156 fits in int.
6157 (message_length): Now ptrdiff_t, not int.
6158 (Fmessage_box): Don't update size until allocation succeeds.
6159 Don't assume message length fits in int.
6160 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6161
0065d054
PE
6162 * emacs.c (main): Do not reallocate argv, since there is a null at
6163 the end that can be overwritten, and this way there's no need to
6164 worry about size-calculation overflow.
6165 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6166
6167 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6168 alloc succeeds.
6169 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6170
6171 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6172 (x_set_scroll_bar_width, x_figure_window_size):
6173 Check for integer overflow.
6174 (x_set_alpha): Do not assume XINT fits in int.
6175
6176 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6177 This is for the members text_lines, text_cols, total_lines, total_cols,
6178 where the system imposes an 'int' limit.
6179
6180 * fringe.c (Fdefine_fringe_bitmap):
6181 Don't update size until alloc works.
6182
6183 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6184 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6185
6186 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6187 Check for size-calculation overflow.
6188 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6189 do, as we prefer signed integers.
6190 (id_to_widget.max_size, id_to_widget.used)
6191 (xg_store_widget_in_map, xg_remove_widget_from_map)
6192 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6193 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6194 Use and return ptrdiff_t, not int.
6195 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6196 * gtkutil.h: Change prototypes to match the above.
6197
6198 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6199 are duplicate now that they've been promoted to lisp.h.
6200 (x_allocate_bitmap_record, x_alloc_image_color)
6201 (make_image_cache, cache_image, xpm_load):
6202 Don't update size until alloc is done.
6203 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6204 (x_detect_edges):
3256efce 6205 Check for size calculation overflow.
726e0ab1
PE
6206 (ct_colors_allocated_max): New constant.
6207 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6208 overflow.
3256efce 6209
726e0ab1
PE
6210 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6211 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6212 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6213 Use ptrdiff_t, not int, to count maps.
6214 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6215 calculations. Don't update size until allocation succeeds.
6216 Redo calculations to avoid overflow.
726e0ab1
PE
6217 * keyboard.h: Change prototypes to match the above.
6218
6219 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6220 to count maps.
6221 (current_minor_maps): Check for size calculation overflow.
6222 * keymap.h: Change prototypes to match the above.
6223
6224 * lread.c (read1, init_obarray): Don't update size until alloc done.
6225
6226 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6227 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6228
726e0ab1
PE
6229 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6230 Now ptrdiff_t, not int.
6231 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6232 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6233
6234 * process.c (Fnetwork_interface_list): Check for overflow
6235 in size calculation.
6236
6237 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6238
6239 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6240 overflow. Don't bother calling xmalloc when xrealloc will do.
6241
6242 * search.c (Freplace_match): Check for size calculation overflow.
6243 (Fset_match_data): Don't assume list lengths fit in 'int'.
6244
6245 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6246 for command line length. Do not attempt to address one before the
6247 beginning of an array, as that's not portable.
6248
6249 * term.c (max_frame_lines): Remove; unused.
6250 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6251 not int.
6252 (encode_terminal_code, calculate_costs): Check for size
6253 calculation overflow.
6254 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6255 table lengths and related sizes. Don't update size until alloc
6256 done. Redo calculations to avoid overflow.
6257 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6258
6259 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6260 subtracting pointers.
6261 (gobble_line): Check for overflow more carefully. Don't update size
6262 until alloc done.
6263
6264 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6265 Don't update size until alloc done.
6266 Redo size calculations to avoid overflow.
6267 Check for size calculation overflow.
0065d054 6268 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6269
6270 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6271 Use ptrdiff_t, not int, for sizes.
6272 (store_mode_line_noprop_char): Don't update size until alloc done.
6273
0065d054
PE
6274 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6275 Use ptrdiff_t, not int, for sizes.
6276 (Finternal_make_lisp_face, cache_face):
6277 Check for size calculation overflow.
6278 (cache_face): Treat size calculation overflows as if they were
6279 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6280
6281 * xfns.c (x_encode_text, x_set_name_internal)
6282 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6283 sizes, since they can exceed INT_MAX in size. Check for size
6284 calculation overflow.
6285
0065d054
PE
6286 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6287 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6288 Don't update size until alloc done.
6289
0065d054 6290 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6291 as sprintf is limited to int lengths.
1d526e2f 6292
252c5ee1
PE
6293 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6294 (X_LONG_MIN): New macros.
864d7ce7
PE
6295 Use them to make the following changes clearer.
6296 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6297 This change doesn't affect the value now, but it may help remind
6298 future maintainers not to raise the value too much later.
6299 (SELECTION_QUANTUM): Remove, replacing with ...
6300 (selection_quantum): ... new function, which avoids overflow.
6301 All uses changed.
6302 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6303 assumption that selection length fits in 'int'.
6304 (x_reply_selection_request, x_handle_selection_request)
6305 (x_get_window_property, receive_incremental_selection)
6306 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6307 (lisp_data_to_selection_data, clean_local_selection_data):
6308 Use ptrdiff_t, not int, to record length of selection.
6309 (x_reply_selection_request, x_get_window_property)
6310 (receive_incremental_selection, x_property_data_to_lisp):
6311 Redo calculations to avoid overflow.
6312 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6313 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6314 something.
6315 (x_get_window_property, receive_incremental_selection)
6316 (lisp_data_to_selection_data, x_property_data_to_lisp):
6317 Check for size-calculation overflow.
6318 (x_get_window_property, receive_incremental_selection)
6319 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6320 Don't store size until memory allocation succeeds.
6321 (x_get_window_property): Plug memory leak on memory exhaustion.
6322 Don't double-block input; malloc is safe here. Don't assume 2**34
6323 - 4 fits in unsigned long. Add an xassert to check
6324 XGetWindowProperty overflow. Be more careful about overflow
6325 calculations, and distinguish size from memory overflow better.
6326 (receive_incremental_selection): When tracing, don't assume
6327 unsigned int is less than INT_MAX.
6328 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6329 harmful) conversions of unsigned short to int.
6330 (lisp_data_to_selection_data): Don't assume that integers
6331 in the range -65535 through -1 fit in an X unsigned short.
6332 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6333 result parameters unless successful. Rely on cons_to_unsigned
6334 to report problems with elements; the old code wasn't right anyway.
6335 (x_check_property_data): Check for int overflow; we cannot use
6336 a wider type due to X limits.
6337 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6338
726e0ab1 6339 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6340
0065d054
PE
6341 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6342 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6343 (x_color_cells): Don't store size until memory allocation succeeds.
6344 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6345 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6346 (x_term_init): Don't assume length fits in int (sprintf is limited
6347 to int size).
bc18e09d 6348
ebfa62c0
PE
6349 Use ptrdiff_t for composition IDs.
6350 * character.c (lisp_string_width):
6351 * composite.c (composition_table_size, n_compositions)
6352 (get_composition_id, composition_gstring_from_id):
6353 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6354 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6355 * window.c (Frecenter):
6356 Use ptrdiff_t, not int, for composition IDs.
6357 * composite.c (get_composition_id): Check for integer overflow.
6358 * composite.h: Adjust prototypes to match the above changes.
6359
d3411f89
PE
6360 Use ptrdiff_t for hash table indexes.
6361 * category.c (hash_get_category_set):
6362 * ccl.c (ccl_driver):
6363 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6364 * coding.c (coding_system_charset_list, detect_coding_system):
6365 * coding.h (struct coding_system.id):
6366 * composite.c (get_composition_id, gstring_lookup_cache):
6367 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6368 * image.c (xpm_get_color_table_h):
6369 * lisp.h (hash_lookup, hash_put):
6370 * minibuf.c (Ftest_completion):
6371 Use ptrdiff_t for hash table indexes, not int (which is too
6372 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6373 32-bit --with-wide-int hosts).
6374
e097a6fa
PE
6375 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6376 Add a FIXME comment about memory leaks.
6377 (syms_of_charset): Don't assume xmalloc returns.
6378
5637687f
PE
6379 Don't assume that stated character widths fit in int.
6380 * character.c (Fchar_width, c_string_width, lisp_string_width):
6381 * character.h (CHAR_WIDTH):
6382 * indent.c (MULTIBYTE_BYTES_WIDTH):
6383 Use sanitize_char_width to avoid undefined and/or bad behavior
6384 with outlandish widths.
a66cfb1c 6385 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6386 now that we have two such functions. All uses changed.
6387 (sanitize_char_width): New inline function.
6388
a2271ba2
PE
6389 Don't assume that tab-width fits in int.
6390 * character.h (sanitize_width): New inline function.
6391 (SANE_TAB_WIDTH): New macro.
6392 (ASCII_CHAR_WIDTH): Use it.
6393 * indent.c (sane_tab_width): Remove. All uses replaced by
6394 SANE_TAB_WIDTH (current_buffer).
6395 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6396
18c52557
PE
6397 * fileio.c: Integer overflow issues with file modes.
6398 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6399
caeeedc1
PE
6400 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6401 Remove unreachable code.
6402 (read_hex, load_charset_map_from_file): Check for integer overflow.
6403
6df6ae42 6404 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6405 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6406 (x_send_scroll_bar_event): Likewise. Check that the size does not
6407 exceed limits imposed by XClientMessageEvent, as well as the usual
6408 ptrdiff_t and size_t limits.
6409
b13995db
PE
6410 * keyboard.c: Overflow, signedness and related fixes.
6411 (make_lispy_movement): Use same integer type in forward decl
6412 that is used in the definition.
6413 (read_key_sequence, keyremap_step):
6414 Change bufsize argument back to int, undoing my 2011-03-30 change.
6415 We prefer signed types, and int is wide enough here.
6416 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6417 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6418 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6419 length, not size_t. Use ptrdiff_t for index, not int.
6420 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6421 possibility of integer overflow.
6422
13464394
PE
6423 Overflow, signedness and related fixes for images.
6424
6425 * dispextern.h (struct it.stack[0].u.image.image_id)
6426 (struct_it.image_id, struct image.id, struct image_cache.size)
6427 (struct image_cache.used, struct image_cache.ref_count):
6428 * gtkutil.c (update_frame_tool_bar):
6429 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6430 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6431 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6432 * nsmenu.m (update_frame_tool_bar):
6433 * xdisp.c (calc_pixel_width_or_height):
6434 * xfns.c (image_cache_refcount):
6435 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6436 on typical 64-bit hosts.
6437
6438 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6439 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6440 Omit unnecessary casts to int.
6441 (parse_image_spec): Check that integers fall into 'int' range
6442 when the callers expect that.
6443 (image_ascent): Redo ascent calculation to avoid int overflow.
6444 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6445 (lookup_image): Remove unnecessary tests.
6446 (xbm_image_p): Locals are now of int, not EMACS_INT,
6447 since parse_image_check makes sure they fit into int.
6448 (png_load, gif_load, svg_load_image):
6449 Prefer int to unsigned where either will do.
6450 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6451 old tiff_error_handler and tiff_warning_handler.
6452 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6453 stack buffer overflows. It uses only the features of vsnprintf
6454 that are common to both POSIX and native Microsoft.
6455 (tiff_error_handler, tiff_warning_handler): Use it.
6456 (tiff_load, gif_load, imagemagick_load_image):
6457 Don't assume :index value fits in 'int'.
6458 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6459 (imagemagick_load_image): Check that crop parameters fit into
6460 the integer types that MagickCropImage accepts. Don't assume
6461 Vimagemagick_render_type has a nonnegative value. Don't assume
6462 size_t fits in 'long'.
6463 (gs_load): Use printmax_t to print the widest integers possible.
6464 Check for integer overflow when computing image height and width.
6465
c11821d4
EZ
64662011-08-26 Eli Zaretskii <eliz@gnu.org>
6467
6468 * xdisp.c (redisplay_window): Don't force window start if point
6469 will be invisible in the resulting window. (Bug#9324)
6470
0c95fcf7
EZ
64712011-08-25 Eli Zaretskii <eliz@gnu.org>
6472
6473 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6474 the display spec is of the form `(space ...)'.
6475 (handle_display_spec): Return the value returned by
6476 handle_single_display_spec, not just 1 or zero.
6477 (handle_single_display_spec): If the display spec is of the form
6478 `(space ...)', and specifies display in the text area, return 2
6479 rather than 1.
fee65a97 6480 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6481 accurately, and prefer exact match for point under bidi.
6482 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6483
6484 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6485 into disp_prop; all users changed.
6486
6487 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6488 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6489 for the text covered by the display property.
6490
e4ed06f1
CY
64912011-08-25 Chong Yidong <cyd@stupidchicken.com>
6492
6493 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6494 Change return value to nil.
6495 (Frecord_buffer): Delete unused function.
6496
f67cdd7f
EZ
64972011-08-24 Eli Zaretskii <eliz@gnu.org>
6498
5980d4c6
EZ
6499 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6500 buffers, return left-to-right.
8610fe8b
EZ
6501 (set_cursor_from_row): Consider candidate row a win if its glyph
6502 represents a newline and point is on that newline. Fixes cursor
6503 positioning on the newline at EOL of R2L text within L2R
6504 paragraph, and vice versa.
6505 (try_cursor_movement): Check continued rows, in addition to
6506 continuation rows. Fixes unwarranted scroll when point enters a
6507 continued line of R2L text within an L2R paragraph, or vice versa.
6508 (cursor_row_p): Consider the case of point being equal to
6509 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6510 from the end of a short line to the beginning of a continued line
6511 of R2L text within L2R paragraph.
6512 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6513 composed characters.
5980d4c6 6514
f67cdd7f
EZ
6515 * bidi.c (bidi_check_type): Use xassert.
6516 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6517 members.
6518
bca633fb
EZ
65192011-08-23 Eli Zaretskii <eliz@gnu.org>
6520
6521 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6522 a character.
6523
4a5885a7
CY
65242011-08-23 Chong Yidong <cyd@stupidchicken.com>
6525
6526 * nsfont.m (ns_otf_to_script): Fix typo.
6527
0902a04e
KH
65282011-08-22 Kenichi Handa <handa@m17n.org>
6529
6530 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6531 extra slot even if the purpose is char-code-property-table.
6532
1a2e6670
EZ
65332011-08-23 Eli Zaretskii <eliz@gnu.org>
6534
8ddde651
EZ
6535 * xdisp.c (redisplay_window): When computing centering_position,
6536 account for the height of the header line. (Bug#8874)
6537
425cc014
EZ
6538 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6539 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6540 candidate is selected by the mouse, and that candidate has a
6541 composed character under the mouse.
6542
1a2e6670
EZ
6543 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6544 coordinates reported by pos-visible-in-window-p for a composed
6545 character in column zero.
6546
8b76d6f8
SM
65472011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6548
6549 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6550
dac347dd
EZ
65512011-08-22 Eli Zaretskii <eliz@gnu.org>
6552
6553 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6554 consider it a hit if to_charpos is anywhere in the range of the
6555 composed buffer positions.
6556
e013fb34
CY
65572011-08-22 Chong Yidong <cyd@stupidchicken.com>
6558
6559 * image.c (gif_load): Don't assume that each subimage has the same
6560 dimensions as the base image. Handle disposal method that is
6561 "undefined" by the gif spec (Bug#9335).
6562
bd1ba3e8
CY
65632011-08-20 Chong Yidong <cyd@stupidchicken.com>
6564
6565 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6566 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6567
54a1215b
EZ
65682011-08-19 Eli Zaretskii <eliz@gnu.org>
6569
823564e5
EZ
6570 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6571 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6572 from an Org mode buffer to a Speedbar frame.
6573
54a1215b
EZ
6574 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6575 a composition, take its buffer position from IT->cmp_it.charpos.
6576 Fixes cursor positioning at the beginning of a line that begins
6577 with a composed character.
6578
9778ebcc
EZ
65792011-08-18 Eli Zaretskii <eliz@gnu.org>
6580
0be6ee06
EZ
6581 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6582 character bidirectional type, use STRONG_L instead. Fixes crashes
6583 in a buffer produced by `describe-categories'.
6584
9778ebcc
EZ
6585 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6586 members before the level stack, so they would be saved and
6587 restored when copying iterator state. Fixes incorrect reordering
6588 around TABs covered by display properties.
6589
156bffbe
AS
65902011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6591
6b02f655 6592 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6593
72ad093b
CY
65942011-08-17 Chong Yidong <cyd@stupidchicken.com>
6595
6596 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6597 (internal_condition_case_2, internal_condition_case_n):
6598 Remove unnecessary aborts (Bug#9081).
72ad093b 6599
35774242
EZ
66002011-08-17 Eli Zaretskii <eliz@gnu.org>
6601
6602 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6603 has no `load' handler, try opening the file locally. (Bug#9311)
6604
db76dd85
KB
66052011-08-16 Ken Brown <kbrown@cornell.edu>
6606
6607 * gmalloc.c: Expand comment.
6608
b215eee5
EZ
66092011-08-16 Eli Zaretskii <eliz@gnu.org>
6610
6611 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6612 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6613
a4579d33
KB
66142011-08-16 Ken Brown <kbrown@cornell.edu>
6615
6616 Fix memory allocation problems in Cygwin build (Bug#9273).
6617
6618 * unexcw.c ( __malloc_initialized): Declare external variable.
6619 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6620
8b76d6f8
SM
6621 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6622 New variables.
a4579d33
KB
6623 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6624 dumped emacs.
6625 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6626 in the static heap.
6627 [CYGWIN] (special_realloc): New function.
6628 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6629 requests to realloc storage in the static heap.
6630
3ebec551
PE
66312011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6632
6633 * bidi.c (bidi_initialize): Remove unused local.
6634
9fd8be00
EZ
66352011-08-15 Eli Zaretskii <eliz@gnu.org>
6636
6b02f655
SM
6637 * bidimirror.h:
6638 * biditype.h: Remove file.
6639 * makefile.w32-in ($(BLD)/bidi.$(O)):
6640 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6641
6642 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6643
6644 * chartab.c: Improve commentary for the uniprop_table API.
6645
32413314
EZ
6646 * bidi.c (bidi_paragraph_init): Support zero value of
6647 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6648 (bidi_initialize): Use uniprop_table instead of including
6649 biditype.h and bidimirror.h.
32413314 6650
9fd8be00
EZ
6651 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6652 coordinates of the iterator when restoring from ppos_it.
6653 (Bug#9296)
6654
5cf2b69b
KH
66552011-08-14 Kenichi Handa <handa@m17n.org>
6656
6657 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6658 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6659
daf17d00
EZ
66602011-08-14 Eli Zaretskii <eliz@gnu.org>
6661
6662 * xdisp.c (move_it_in_display_line_to): Don't invoke
6663 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6664 ppos_it. Fixes vertical cursor motion when line beginning is
6665 covered by an image. (Bug#9296)
6666
08e3161a
JD
66672011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6668
6669 * nsterm.h (ns_run_ascript): Declare.
6670 (NSAPP_DATA2_RUNASSCRIPT): Define.
6671
6672 * nsfns.m (as_script, as_result, as_status): New static variables.
6673 (ns_run_ascript): New function.
5e617bc2 6674 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6675 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6676 the event loop. Get status from as_status (Bug#7276).
6677
6678 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6679 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6680 the event loop (Bug#7276).
6681
a3720aa2
AS
66822011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6683
6684 * gnutls.c (QCgnutls_bootprop_priority)
6685 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6686 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6687 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6688 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6689 (QCgnutls_bootprop_verify_hostname_error)
6690 (QCgnutls_bootprop_callbacks_verify): Rename from
6691 Qgnutls_bootprop_..., all uses changed.
6692
6693 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6694 uses changed.
6695
0a0d27fb
PE
66962011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6697
19d5c50c
PE
6698 * xfaces.c (Qframe_set_background_mode): Now static.
6699 * dispextern.h (Qframe_set_background_mode): Remove decl.
6700
0a0d27fb
PE
6701 * process.c (Fnetwork_interface_info): Declare local only if needed.
6702
377538cb
JD
67032011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6704
6705 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6706 (Fnetwork_interface_list): Allocate in increments of bytes instead
6707 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6708 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6709 sockaddr.
6710 (struct ifflag_def): notrailers is smart on OSX.
6711 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6712 Get hardware address with getifaddrs if available.
6713
08fff70c
EZ
67142011-08-12 Eli Zaretskii <eliz@gnu.org>
6715
6716 * xdisp.c (iterate_out_of_display_property): xassert that
6717 IT->position is set to within IT->object's boundaries. Break from
6718 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6719 when IT->position is set up wrongly due to some bug.
6720 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6721 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6722 entry. Force push_it to save on the stack the current
6723 buffer/string position, to be restored by pop_it. Fix flags in
6724 the iterator structure wrt the object coming from a display
6725 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6726 properties. (Bug#9284)
6727
7be1c708 67282011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6729
7be1c708
CY
6730 * fontset.c (fontset_get_font_group): Add proper type checks.
6731 (Bug#9172)
aac0c6e3 6732
7be1c708 67332011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6734
7be1c708
CY
6735 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6736 and LC_VERSION_MIN_MACOSX.
6737 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6738 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6739
97bb72a6
EZ
67402011-08-08 Eli Zaretskii <eliz@gnu.org>
6741
6742 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6743 no-display-properties-and-no-overlays under bidi display.
6744 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6745 properties and overlays.
97bb72a6 6746
d5617611
CY
67472011-08-08 Chong Yidong <cyd@stupidchicken.com>
6748
37e11a63
CY
6749 * editfns.c (Fset_time_zone_rule): Document relationship with the
6750 setenv function.
6751
d5617611
CY
6752 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6753 the font entity extracted from the cache (Bug#8109).
6754
58872834
CY
67552011-08-07 Chong Yidong <cyd@stupidchicken.com>
6756
6757 * composite.c (autocmp_chars): Don't reset point. That is done by
6758 restore_point_unwind (Bug#5984).
6759
75bfc667
JL
67602011-08-07 Juri Linkov <juri@jurta.org>
6761
6762 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6763 to show the arg `TIME' instead of `TIMEVAL'.
6764
d1410150
EZ
67652011-08-06 Eli Zaretskii <eliz@gnu.org>
6766
6767 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6768 display property strides EOL and includes a newline, as in
6769 longlines-mode. (Bug#9254)
75b771e4
EZ
6770 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6771 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6772
6773 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6774 is non-zero, even if the data buffer is NULL. Fixes a crash in
6775 vertical-motion with longlines-mode. (Bug#9254)
6776
35928349
EZ
67772011-08-05 Eli Zaretskii <eliz@gnu.org>
6778
ec7cc85b
EZ
6779 * bidi.c <bidi_cache_total_alloc>: Now static.
6780 (bidi_initialize): Initialize bidi_cache_total_alloc.
6781
8b76d6f8 6782 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6783 cache. (Bug#9221)
6784
6785 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6786 amount allocated this far in `bidi_cache_total_alloc'.
6787 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6788 non-zero, only free the data buffer without restoring the cache
6789 contents. All callers changed.
6790
6791 * dispextern.h (bidi_unshelve_cache): Update prototype.
6792
6793 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6794 (move_it_in_display_line, move_it_to)
6795 (move_it_vertically_backward, move_it_by_lines): Replace the call
6796 to xfree to an equivalent call to bidi_unshelve_cache.
6797 (move_it_in_display_line_to): Fix logic of returning
412b6358 6798 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6799
e2e2423b
EZ
68002011-08-05 Eli Zaretskii <eliz@gnu.org>
6801
6802 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6803 came from a string character with a `cursor' property. (Bug#9229)
6804
ae9e757a
JD
68052011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6806
6807 * Makefile.in (LIB_PTHREAD): New variable.
6808 (LIBES): Add LIB_PTHREAD (Bug#9216).
6809
6810 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6811 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6812
213bd7f2
AS
68132011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6814
6b02f655 6815 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6816
99aaf75f
JD
68172011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6818
6819 * xterm.c (x_find_topmost_parent): New function.
6820 (x_set_frame_alpha): Find topmost parent window with
6821 x_find_topmost_parent and set the property there also (bug#9181).
6822 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6823
c74e9d86
PE
68242011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6825
6826 * callproc.c (Fcall_process): Avoid vfork clobbering
6827 the local vars buffer, coding_systems, current_dir.
6828
640c8776
SM
68292011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6830
6831 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6832
f26d0e4c
PE
68332011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6834
8a10d76c
PE
6835 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6836 so that it is not optimized away.
6837
f26d0e4c
PE
6838 * xdisp.c (compute_display_string_pos): Remove unused local.
6839
55439c61
EZ
68402011-08-02 Eli Zaretskii <eliz@gnu.org>
6841
6842 Fix slow cursor motion and scrolling in large buffers with
6843 selective display, like Org Mode buffers. (Bug#9218)
6844
6845 * dispextern.h (struct bidi_it): New member disp_prop_p.
6846
6847 * xdisp.c: Remove one-slot cache of display string positions.
6848 (compute_display_string_pos): Accept an additional argument
5e617bc2 6849 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6850 for a display string or property. If found, set DISP_PROP_P
6851 non-zero.
6852
6853 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6854 DISP_PROP_P, and pass it to compute_display_string_pos.
6855 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6856 non-zero. All callers of bidi_fetch_char changed.
6857
fb33fa43
SM
68582011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6859
6860 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6861
b099e063
DM
68622010-12-03 Don March <don@ohspite.net>
6863
6864 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6865 last character M-[char] is translated to ESC [char] (bug#7541).
6866
5cc7f7af
KH
68672011-08-02 Kenichi Handa <handa@m17n.org>
6868
d0fffa3f 6869 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6870
6871 * chartab.c (uniprop_table): Make it non-static.
6872
525d5e6e
EZ
68732011-08-01 Eli Zaretskii <eliz@gnu.org>
6874
6875 * xdisp.c (forward_to_next_line_start): Accept additional argument
6876 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6877 on the newline.
6878 (reseat_at_next_visible_line_start): Use the bidi iterator state
6879 returned by forward_to_next_line_start to restore the state of
6880 it->bidi_it after backing up to previous newline. (Bug#9212)
6881
31011111
AS
68822011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6883
6884 * regex.c (re_comp): Protoize.
6885 (re_exec): Fix return type.
6886 (regexec): Fix type of `ret'. (Bug#9203)
6887
476371c4
PE
68882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6889
e5d76069
PE
6890 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6891 This is needed if max-image-size is a floating-point number.
6892
9a79b20c
AS
68932011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6894
6895 * print.c (print_object): Print empty symbol as ##.
6896
6897 * lread.c (read1): Read ## as empty symbol.
6898
d8c2fa78
AA
68992011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6900
6901 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6902 setting frame foreground color (Bug#9175).
6903 (x_set_background_color): Likewise.
6904
ffe57a7a
AA
6905 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6906 contents (Bug#9176).
6907 (EmacsTooltip -init): Remove bezels and add shadows to
6908 tooltip windows.
6909
bf3492a5
AA
6910 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6911 or scroll bar (Bug#8470).
6912
d55e9c53
AA
6913 * nsfont.m (nsfont_open): Remove assignment to voffset and
6914 unnecessary vars hshink, expand, hd, full_height, min_height.
6915 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6916
6917 * nsterm.h (nsfont_info): Remove voffset field.
6918
d8c2fa78 69192011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6920
6921 Implement strike-through and overline on NextStep (Bug#8863).
6922
6923 * nsfont.m (nsfont_open): Use underline position provided by font,
6924 instead of hard-coded value of 2.
6925 (nsfont_draw): Call ns_draw_text_decoration instead.
6926
6927 * nsterm.h: Add declaration for ns_draw_text_decoration.
6928
6929 * nsterm.m (ns_draw_text_decoration): New function for drawing
6930 underline, overline, and strike-through.
6931 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6932 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6933 accommodate underlining, etc.
4843aac3 6934
4cc60b9b
EZ
69352011-07-28 Eli Zaretskii <eliz@gnu.org>
6936
bc7ece87
EZ
6937 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6938 default.
4cc60b9b 6939
476371c4
PE
69402011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6941
66606eea
PE
6942 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6943 Without this fix, if a signal arrives just after memory fills up,
6944 'malloc' might be invoked reentrantly.
6945
476371c4
PE
6946 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6947 In other words, assume that every image size is allowed, on non-X
6948 hosts. This assumption is probably wrong, but it lets Emacs compile.
6949
f3fcc40d
AS
69502011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6951
6952 * regex.c (re_iswctype): Convert return values to boolean.
6953
350c992f
EZ
69542011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6955
6956 * xdisp.c (compute_display_string_pos): Don't use cached display
6957 string position if the buffer had its restriction changed.
6958 (Bug#9184)
6959
5266b4bb
PE
69602011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6961
6962 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6963
2573a837 69642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6965
41f55ccd 6966 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6967
39e378da
PE
6968 * bidi.c: Integer size and overflow fixes.
6969 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6970 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6971 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6972 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6973 (bidi_find_other_level_edge):
6974 Use ptrdiff_t instead of EMACS_INT where either will do.
6975 This works better on 32-bit hosts configured --with-wide-int.
6976 (bidi_cache_ensure_space): Check for size-calculation overflow.
6977 Use % rather than repeated addition, for better worst-case speed.
6978 Don't set bidi_cache_size until after xrealloc returns, because it
6979 might not return.
6980 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6981 (bidi_cache_ensure_space): Also check that the bidi cache size
6982 does not exceed that of the largest Lisp string or buffer. See Eli
6983 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6984
5e927815
PE
6985 * alloc.c (__malloc_size_t): Remove.
6986 All uses replaced by size_t. See Andreas Schwab's note
6987 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6988
ca4aa935
PE
6989 * image.c: Improve checking for integer overflow.
6990 (check_image_size): Assume that f is nonnull, since
6991 it is always nonnull in practice. This is one less thing to
6992 worry about when checking for integer overflow later.
6993 (x_check_image_size): New function, which checks for integer
6994 overflow issues inside X.
6995 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6996 This removes the need for a memory_full check.
6997 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6998 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6999 (xbm_read_bitmap_data): Change locals back to 'int', since
7000 their values must fit in 'int'.
7001 (xpm_load_image, png_load, tiff_load):
7002 Invoke x_create_x_image_and_pixmap earlier,
7003 to avoid much needless work if the image is too large.
7004 (tiff_load): Treat overly large images as if
7005 x_create_x_image_and_pixmap failed, not as malloc failures.
7006 (gs_load): Use x_check_image_size.
7007
5f8f9cc2
PE
7008 * gtkutil.c: Omit integer casts.
7009 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7010 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7011
5adf60bc
PE
7012 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7013
c8907a93
PE
7014 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7015 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7016 would wrongly return t on a 64-bit host.
7017
e3c25c68
PE
7018 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7019 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7020 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7021 and therefore cause GCC to emit a bogus diagnostic in some cases.
7022
3f791afe
PE
7023 * image.c: Integer signedness and overflow and related fixes.
7024 This is not an exhaustive set of fixes, but it's time to
7025 record what I've got.
7026 (lookup_pixel_color, check_image_size): Remove redundant decls.
7027 (check_image_size): Don't assume that arbitrary EMACS_INT values
7028 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7029 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7030 (tiff_load, imagemagick_load_image):
7031 Check for overflow in size calculations.
7032 (x_create_x_image_and_pixmap): Remove unnecessary test for
7033 xmalloc returning NULL; that can't happen.
7034 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7035 (xpm_color_bucket): Use better integer hashing function.
7036 (xpm_cache_color): Don't possibly over-allocate memory.
7037 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7038 (gif_memory_source):
7039 Use ptrdiff_t, not int or size_t, to record sizes.
7040 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7041 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7042 either works, as we prefer signed integers.
7043 (tiff_read_from_memory, tiff_write_from_memory):
7044 Return tsize_t, not size_t, since that's what the TIFF API wants.
7045 (tiff_read_from_memory): Don't fail simply because the read would
7046 go past EOF; instead, return a short read.
7047 (tiff_load): Omit no-longer-needed casts.
7048 (Fimagemagick_types): Don't assume size fits into 'int'.
7049
3cc5a532
PE
7050 Improve hashing quality when configured --with-wide-int.
7051 * fns.c (hash_string): New function, taken from sxhash_string.
7052 Do not discard information about ASCII character case; this
7053 discarding is no longer needed.
7054 (sxhash-string): Use it. Change sig to match it. Caller changed.
7055 * lisp.h: Declare it.
7056 * lread.c (hash_string): Remove, since we now use fns.c's version.
7057 The fns.c version returns a wider integer if --with-wide-int is
7058 specified, so this should help the quality of the hashing a bit.
7059
b312a492
PE
7060 * emacs.c: Integer overflow minor fix.
7061 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7062 Define only if GNU_LINUX.
7063 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7064
dfd153ae
PE
7065 * dispnew.c: Integer signedness and overflow fixes.
7066 Remove unnecessary forward decls, that were a maintenance hassle.
7067 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7068 All uses changed.
7069 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7070 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7071 (prepare_desired_row, line_draw_cost):
7072 Use int, not unsigned, where either works.
7073 (save_current_matrix, restore_current_matrix):
7074 Use ptrdiff_t, not size_t, where either works.
7075 (init_display): Check for overflow more accurately, and without
7076 relying on undefined behavior.
7077
a81d11a3
PE
7078 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7079 Remove, replacing with the new symbols in lisp.h. All uses changed.
7080 * fileio.c (make_temp_name):
7081 * filelock.c (lock_file_1, lock_file):
7082 * xdisp.c (message_dolog):
7083 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7084 Use pMd etc. instead.
7085 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7086 replacing the pWIDE etc. symbols removed from editfns.c.
7087
3300e6fd
PE
7088 * keyboard.h (num_input_events): Now uintmax_t.
7089 This is (very slightly) less likely to mess up due to wraparound.
7090 All uses changed.
7091
fd05c7e9
PE
7092 * buffer.c: Integer signedness fixes.
7093 (alloc_buffer_text, enlarge_buffer_text):
7094 Use ptrdiff_t rather than size_t when either will do, as we prefer
7095 signed integers.
7096
903fe15d
PE
7097 * alloc.c: Integer signedness and overflow fixes.
7098 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7099 (__malloc_size_t): Default to size_t, not to int.
7100 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7101 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7102 Prefer ptrdiff_t to size_t when either would do, as we prefer
7103 signed integers.
7104 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7105 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7106 Now const. Initialize with values that are in range even if char
7107 is signed.
7108 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7109 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7110 These functions do the right thing with sizes > 2**32.
7111 (check_depth): Now ptrdiff_t, not int.
7112 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7113 Adjust to new way of storing sizes. Check for size overflow bugs
7114 in rest of code.
7115 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7116 slightly wrong anyway, as it missed one instance of
7117 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7118 (refill_memory_reserve): Omit needless cast to size_t.
7119 (mark_object_loop_halt): Mark as externally visible.
7120
ac82cc6a
PE
7121 * xselect.c: Integer signedness and overflow fixes.
7122 (Fx_register_dnd_atom, x_handle_dnd_message):
7123 Use ptrdiff_t, not size_t, since we prefer signed.
7124 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7125 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7126 x_dnd_atoms_size and x_dnd_atoms_length.
7127
c2d1e36d
PE
7128 * doprnt.c: Prefer signed to unsigned when either works.
7129 * eval.c (verror):
7130 * doprnt.c (doprnt):
7131 * lisp.h (doprnt):
7132 * xdisp.c (vmessage):
7133 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7134 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7135 prefer signed arithmetic to avoid comparison confusion.
7136 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7137 but is a bit tricky.
7138
0e926e56
PE
7139 Assume freestanding C89 headers, string.h, stdlib.h.
7140 * data.c, doprnt.c, floatfns.c, print.c:
7141 Include float.h unconditionally.
7142 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7143 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7144 * regex.c: Likewise for stddef.h, string.h.
7145 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7146 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7147 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7148 (STDC_HEADERS): Remove obsolete defines.
7149 * sysdep.c: Include limits.h unconditionally.
7150
9cfdb3ec
PE
7151 Assume support for memcmp, memcpy, memmove, memset.
7152 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7153 * regex.c (memcmp, memcpy):
7154 Remove; we assume C89 now.
7155
7156 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7157 (__malloc_safe_bcopy): Remove; no longer needed.
7158
cf950e6b 7159 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7160 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7161 well either way, and we prefer signed to unsigned.
7162
dbf38e02
LMI
71632011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7164
7165 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7166 closes the connection while we're reading (bug#9182).
7167
d6f0886c 71682011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7169
d6f0886c
JD
7170 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7171 are specified (Bug#9168).
24e0f6b1 7172
2eb1f9e6
PE
71732011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7174
7175 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7176 Found by GCC static checking and --with-wide-int on a 32-bit host.
7177
22381272 71782011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7179
7180 * xdisp.c (compute_display_string_pos): Fix logic of caching
7181 previous display string position. Initialize cached_prev_pos to
7182 -1. Fixes slow-down at the beginning of a buffer.
7183
f25e39b4
EZ
71842011-07-24 Eli Zaretskii <eliz@gnu.org>
7185
7186 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7187 for attrs[LFACE_FONTSET_INDEX].
7188
04c4b52e
PE
71892011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7190
7191 * xml.c (parse_region): Remove unused local
7192 that was recently introduced.
7193
c1734fbd
EZ
71942011-07-23 Eli Zaretskii <eliz@gnu.org>
7195
be18c5a5
EZ
7196 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7197 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7198
c1734fbd
EZ
7199 * xdisp.c (move_it_in_display_line_to): Record the best matching
7200 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7201 exit if none of the characters scanned was an exact match.
7202 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7203 when exact match is impossible due to invisible text, and the
7204 lines are truncated.
7205
a258d627
JD
72062011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7207
7208 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7209 for OSX >= 10.7.
7210
b6d5a689
EZ
72112011-07-22 Eli Zaretskii <eliz@gnu.org>
7212
0f74f785
EZ
7213 Fix a significant slow-down of cursor motion with C-n, C-p,
7214 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7215 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7216 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7217 (next_element_from_buffer): Call compute_stop_pos_backwards to
7218 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7219 base_level_stop.
7220 (reseat): Don't look for prev_stop, as that could mean a very long
7221 run.
7222 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7223 <cached_disp_overlay_modiff>: Cache for last found display string
7224 position.
551918c1 7225 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7226 about the same buffer in the same area of character positions, and
7227 the buffer wasn't changed since the time the display string
7228 position was cached.
551918c1 7229
b2d0c91a
EZ
72302011-07-22 Eli Zaretskii <eliz@gnu.org>
7231
7232 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7233 is an integer, which is important for empty lines. (Bug#9149)
7234
043604ee
CY
72352011-07-22 Chong Yidong <cyd@stupidchicken.com>
7236
7237 * frame.c (Fmodify_frame_parameters): In tty case, update the
7238 default face if necessary (Bug#4238).
7239
da4adb04
CY
72402011-07-21 Chong Yidong <cyd@stupidchicken.com>
7241
7242 * editfns.c (Fstring_to_char): No need to explain what a character
7243 is in the docstring (Bug#6576).
7244
9abd0532
LMI
72452011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7246
7247 * xml.c (parse_region): Make sure we always return a tree.
7248
36881d16
HK
72492011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7250
7251 * xml.c (parse_region): If a document contains only comments,
7252 return that, too.
7253
1e98674d
LMI
72542011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7255
7256 * xml.c (make_dom): Return comments, too.
7257
590bd467
PE
72582011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7259
7260 Port to OpenBSD.
7261 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7262 and the surrounding thread.
7263 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7264 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7265 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7266 timer goes off.
7267 * s/openbsd.h (BROKEN_SIGIO): Define.
7268 * unexelf.c (unexec) [__OpenBSD__]:
7269 Don't update the .mdebug section of the Alpha COFF symbol table.
7270
f41628b2
LMI
72712011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7272
7273 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7274 (bug#8460).
7275
b59b67c5
PE
72762011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7277
15e3a074
PE
7278 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7279 This fixes some race conditions on the permissions of any newly
7280 created file.
7281
41bed37d
PE
7282 * alloc.c (valid_pointer_p): Use pipe, not open.
7283 This fixes some permissions issues when debugging.
7284
b59b67c5
PE
7285 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7286 If fchown fails to set both uid and gid, try to set just gid,
7287 as that is sometimes allowed. Adjust the file's mode to eliminate
7288 setuid or setgid bits that are inappropriate if fchown fails.
7289
925a6be7
SM
72902011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7291
7292 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7293 to compare Lisp_Objects.
7294 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7295 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7296 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7297
52968808
AS
72982011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7299
0a6a104b
AS
7300 * lread.c (read_integer): Unread even EOF character.
7301 (read1): Likewise. Properly record start position of symbol.
7302
52968808
AS
7303 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7304 symbol character follows.
7305
9e381cdd
PE
73062011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7307
7308 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7309 This works around a problem with the previous change to Fcopy_file.
7310 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7311 and without this change, GCC might complain about discarding
7312 fchown's return value.
7313
b5641435
JB
73142011-07-16 Juanma Barranquero <lekktu@gmail.com>
7315
7316 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7317
a8031457
PE
73182011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7319
7320 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7321
dd889327
LMI
73222011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7323
750c33f7
LMI
7324 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7325 it's used from the C level.
7326
dd889327
LMI
7327 * process.c: Use the same condition for POLL_FOR_INPUT in both
7328 keyboard.c and process.c (bug#1858).
7329
87e86684
LM
73302011-07-09 Lawrence Mitchell <wence@gmx.li>
7331
7332 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7333 (Fgnutls_boot): Use it.
7334
64348f40
AS
73352011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7336
7337 * doc.c (Fsubstitute_command_keys): Revert last change.
7338
1d698799
LMI
73392011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7340
f863868c
LMI
7341 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7342 quotes the next character, and doesn't affect other longer
7343 sequences (bug#8935).
7344
1d698799
LMI
7345 * lread.c (syms_of_lread): Clarify that is isn't only
7346 `eval-buffer' and `eval-defun' that's affected by
7347 `lexical-binding' (bug#8460).
7348
aa4b6df6
EZ
73492011-07-15 Eli Zaretskii <eliz@gnu.org>
7350
7351 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7352 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7353
5d856da6
PE
73542011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7355
ad6042bb
PE
7356 Fix minor problems found by static checking.
7357 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7358 (elsz): Now a signed constant, not a size_t var. We prefer signed
7359 types to unsigned, to avoid integer comparison confusion. Without
7360 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7361 "cannot optimize loop, the loop counter may overflow", a symptom
7362 of the confusion.
f00bbb22 7363 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7364 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7365
6468f31c
LMI
73662011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7367
49080b10
LMI
7368 * search.c (Fre_search_backward): Mention `case-fold-search' in
7369 all the re_search_* functions (bug#8138).
7370
6468f31c
LMI
7371 * keyboard.c (Fopen_dribble_file): Document when the file is
7372 closed (bug#8056).
7373
c965adc5
EZ
73742011-07-14 Eli Zaretskii <eliz@gnu.org>
7375
df9733bf
EZ
7376 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7377 bidi_cache_idx.
7378
0bb23927
EZ
7379 Support bidi reordering of display and overlay strings.
7380 * xdisp.c (compute_display_string_pos)
7381 (compute_display_string_end): Accept additional argument STRING.
7382 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7383 (reseat_to_string): Initialize bidi_it->string.s and
7384 bidi_it->string.schars.
7385 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7386 NULL (avoids a crash in bidi_paragraph_init).
7387 Initialize itb.string.lstring.
0bb23927
EZ
7388 (init_iterator): Call bidi_init_it only of a valid
7389 buffer position was specified. Initialize paragraph_embedding to
7390 L2R.
7391 (reseat_to_string): Initialize the bidi iterator.
7392 (display_string): If we need to ignore text properties of
7393 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7394 original value of -1 will not work with bidi.)
7395 (compute_display_string_pos): First arg is now struct
7396 `text_pos *'; all callers changed. Support display properties on
7397 Lisp strings.
7398 (compute_display_string_end): Support display properties on Lisp
7399 strings.
7400 (init_iterator, reseat_1, reseat_to_string): Initialize the
7401 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7402 when iterating on a string not from display properties).
640c8776
SM
7403 (compute_display_string_pos, compute_display_string_end):
7404 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7405 arrow keys.
7406 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7407 base_level_stop; instead, set base_level_stop to BEGV.
7408 Fixes crashes in vertical-motion.
0bb23927
EZ
7409 (next_element_from_buffer): Improve commentary for when
7410 the iterator is before prev_stop.
7411 (init_iterator): Initialize bidi_p from the default value of
7412 bidi-display-reordering, not from buffer-local value. Use the
7413 buffer-local value only if initializing for buffer iteration.
7414 (handle_invisible_prop): Support invisible properties on strings
7415 that are being bidi-reordered.
7416 (set_iterator_to_next): Support bidi reordering of C strings and
7417 Lisp strings.
7418 (next_element_from_string): Support bidi reordering of Lisp
7419 strings.
7420 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7421 (display_string): Support display of R2L glyph rows.
7422 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7423 (init_iterator): Don't initialize it->bidi_p for strings
7424 here.
7425 (reseat_to_string): Initialize it->bidi_p for strings here.
7426 (next_element_from_string, next_element_from_c_string)
7427 (next_element_from_buffer): Add xassert's for correspondence
7428 between IT's object being iterated and it->bidi_it.string
7429 structure.
7430 (face_before_or_after_it_pos): Support bidi iteration.
7431 (next_element_from_c_string): Handle the case of the first string
7432 character that is not the first one in the visual order.
7433 (get_visually_first_element): New function, refactored from common
7434 parts of next_element_from_buffer, next_element_from_string, and
7435 next_element_from_c_string.
7436 (tool_bar_lines_needed, redisplay_tool_bar)
7437 (display_menu_bar): Force left-to-right direction. Add a FIXME
7438 comment for making that be controlled by a user option.
7439 (push_it, pop_it): Save and restore the state of the
7440 bidi iterator. Save and restore the bidi_p flag.
7441 (pop_it): Iterate out of display property for string iteration as
7442 well.
7443 (iterate_out_of_display_property): Support iteration over strings.
7444 (handle_single_display_spec): Set up it->bidi_it for iteration
7445 over a display string, and call bidi_init_it.
7446 (handle_single_display_spec, next_overlay_string)
7447 (get_overlay_strings_1, push_display_prop): Set up the bidi
7448 iterator for displaying display or overlay strings.
7449 (forward_to_next_line_start): Don't use the shortcut if
7450 bidi-iterating.
7451 (back_to_previous_visible_line_start): If handle_display_prop
7452 pushed the iterator stack, restore the internal state of the bidi
7453 iterator by calling bidi_pop_it same number of times.
7454 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7455 and we are bidi-iterating, don't decrement the iterator position;
7456 instead, set the first_elt flag in the bidi iterator, to produce
7457 the same effect.
7458 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7459 (push_display_prop): xassert that we are iterating a buffer.
7460 (push_it, pop_it): Save and restore paragraph_embedding member.
7461 (handle_single_display_spec, next_overlay_string)
7462 (get_overlay_strings_1, reseat_1, reseat_to_string)
7463 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7464 correctly. Don't assume unibyte strings are not bidi-reordered.
7465 (compute_display_string_pos)
7466 (compute_display_string_end): Fix handling the case of C string.
7467 (push_it, pop_it): Save and restore from_disp_prop_p.
7468 (handle_single_display_spec, push_display_prop): Set the
7469 from_disp_prop_p flag.
7470 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7471 (pop_it): Call iterate_out_of_display_property only if we are
7472 popping after iteration over a string that came from a display
7473 property. Fix a typo in popping stretch info. Add an assertion
7474 for verifying that the iterator position is in sync with the bidi
7475 iterator.
7476 (handle_single_display_spec, get_overlay_strings_1)
7477 (push_display_prop): Fix initialization of paragraph direction for
7478 string when that of the parent object is not yet determined.
7479 (reseat_1): Call bidi_init_it to resync the bidi
7480 iterator with IT's position. (Bug#7616)
7481 (find_row_edges): If ROW->start.pos gives position
7482 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7483 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7484 Reset the from_disp_prop_p flag.
7485 (SAVE_IT, RESTORE_IT): New macros.
7486 (pos_visible_p, face_before_or_after_it_pos)
7487 (back_to_previous_visible_line_start)
7488 (move_it_in_display_line_to, move_it_in_display_line)
7489 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7490 (try_scrolling, redisplay_window, display_line): Use them when
7491 saving a temporary copy of the iterator and restoring it back.
7492 (back_to_previous_visible_line_start, reseat_1)
7493 (init_iterator): Empty the bidi cache "stack".
7494 (move_it_in_display_line_to): If iterator ended up at
7495 EOL, but we never saw any buffer positions smaller than
7496 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7497 motion in bidi-reordered lines.
7498 (move_it_in_display_line_to): Record prev_method and prev_pos
7499 immediately before the call to set_iterator_to_next. Fixes cursor
7500 motion in bidi-reordered lines with stretch glyphs and strings
7501 displayed in margins. (Bug#8133) (Bug#8867)
7502 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7503 TO_CHARPOS.
640c8776
SM
7504 (pos_visible_p): Support positions in bidi-reordered lines.
7505 Save and restore bidi cache.
0bb23927
EZ
7506
7507 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7508 (bidi_paragraph_info): Delete unused struct.
7509 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7510 (bidi_cache_start): New variable.
7511 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7512 to zero.
7513 (bidi_cache_fetch_state, bidi_cache_search)
7514 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7515 (bidi_cache_find, bidi_peek_at_next_level)
7516 (bidi_level_of_next_char, bidi_find_other_level_edge)
7517 (bidi_move_to_visually_next): Compare cache index with
7518 bidi_cache_start rather than with zero.
7519 (bidi_fetch_char): Accept new argument STRING; all callers
7520 changed. Support iteration over a string. Support strings with
7521 display properties. Support unibyte strings. Fix the type of
7522 `len' according to what STRING_CHAR_AND_LENGTH expects.
7523 (bidi_paragraph_init, bidi_resolve_explicit_1)
7524 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7525 (bidi_level_of_next_char, bidi_move_to_visually_next):
7526 Support iteration over a string.
0bb23927
EZ
7527 (bidi_set_sor_type, bidi_resolve_explicit_1)
7528 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7529 can now be zero (for strings); special values 0 and -1 were
7530 changed to -1 and -2, respectively.
7531 (bidi_char_at_pos): New function.
7532 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7533 Call it instead of FETCH_MULTIBYTE_CHAR.
7534 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7535 initialized to valid values.
7536 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7537 values.
7538 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7539 the test for valid cached positions. Fix the logic for looking up
7540 the sentinel state in the cache. GCPRO the Lisp string we are
7541 iterating.
7542 (bidi_push_it, bidi_pop_it): New functions.
7543 (bidi_initialize): Initialize the bidi cache start stack pointer.
7544 (bidi_cache_ensure_space): New function, refactored from part of
7545 bidi_cache_iterator_state. Don't assume the required size is just
7546 one BIDI_CACHE_CHUNK away.
7547 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7548 (bidi_count_bytes, bidi_char_at_pos): New functions.
7549 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7550 always valid if bidi_cache_idx is valid.
7551 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7552 is valid if it's going to be used.
7553 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7554 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7555 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7556 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7557 (bidi_find_other_level_edge, bidi_cache_start_stack):
7558 All variables related to cache indices are now EMACS_INT.
c965adc5 7559
0bb23927
EZ
7560 * dispextern.h (struct bidi_string_data): New structure.
7561 (struct bidi_it): New member `string'. Make flag members be 1-bit
7562 fields, and put them last in the struct.
640c8776
SM
7563 (compute_display_string_pos, compute_display_string_end):
7564 Update prototypes.
0bb23927
EZ
7565 (bidi_push_it, bidi_pop_it): Add prototypes.
7566 (struct iterator_stack_entry): New members bidi_p,
7567 paragraph_embedding, and from_disp_prop_p.
7568 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7569 (bidi_shelve_cache, bidi_unshelve_cache):
7570 Declare prototypes.
0bb23927
EZ
7571
7572 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7573 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7574 and vector-like objects.
7575
7576 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7577 cache around display iteration.
7578
7579 * window.c (Fwindow_end, window_scroll_pixel_based)
7580 (displayed_window_lines, Frecenter): Save and restore the bidi
7581 cache around display iteration.
7582
3bbd2265
LMI
75832011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7584
7585 * editfns.c (Fdelete_region): Clarify the use of the named
7586 parameters (bug#6788).
7587
adc47434
MR
75882011-07-14 Martin Rudalics <rudalics@gmx.at>
7589
7590 * indent.c (Fvertical_motion): Set and restore w->pointm when
7591 saving and restoring the window's buffer (Bug#9006).
7592
837c31f8
LMI
75932011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7594
7595 * editfns.c (Fstring_to_char): Clarify just what is returned
7596 (bug#6576). Text by Eli Zaretskii.
7597
ac389d0c
JB
75982011-07-13 Juanma Barranquero <lekktu@gmail.com>
7599
7600 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7601
0be0ce47
EZ
76022011-07-13 Eli Zaretskii <eliz@gnu.org>
7603
7604 * buffer.c (mmap_find): Fix a typo.
7605
cd18e7e3
JB
76062011-07-13 Johan Bockgård <bojohan@gnu.org>
7607
7608 Fix execution of x selection hooks.
7609 * xselect.c (Qx_lost_selection_functions)
7610 (Qx_sent_selection_functions): New vars.
7611 (syms_of_xselect): DEFSYM them.
7612 (x_handle_selection_request): Pass Qx_sent_selection_functions
7613 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7614 (x_handle_selection_clear,x_clear_frame_selections):
7615 Pass Qx_lost_selection_functions rather than
7616 Vx_lost_selection_functions to Frun_hook_with_args.
7617
47ea7f44
PE
76182011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7619
ac389d0c 7620 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7621 The old code sometimes used this field without initializing it.
7622
47ea7f44
PE
7623 * alloc.c (gc_sweep): Don't read past end of array.
7624 In theory, the old code could also have corrupted Emacs internals,
7625 though it'd be very unlikely.
7626
bc985c87
AS
76272011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7628
7629 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7630 argument. (Bug#4026)
bc985c87 7631
0cf34688
LMI
76322011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7633
b3dadd76
LMI
7634 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7635 key" (bug#4257).
7636
0cf34688
LMI
7637 * window.c (Fset_window_start): Doc fix (bug#4199).
7638 (Fset_window_hscroll): Ditto.
7639
270768cd
PE
76402011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7641
077e3dda 7642 Fix minor new problems caught by GCC 4.6.1.
270768cd 7643 * term.c (init_tty): Remove unused local.
490011a6 7644 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7645 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7646 not used otherwise.
270768cd 7647
b1f58454
CY
76482011-07-12 Chong Yidong <cyd@stupidchicken.com>
7649
7650 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7651
22b9578d
LMI
76522011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7653
6e70ab07
LMI
7654 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7655 are the mini-buffer and the echo area (bug#3320).
7656
22b9578d
LMI
7657 * term.c (init_tty): Remove support for supdup, c10 and perq
7658 terminals, which are no longer supported (bug#1482).
7659
8974cc9f
JB
76602011-07-10 Johan Bockgård <bojohan@gnu.org>
7661
7662 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7663
a560d974
JD
76642011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7665
7666 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7667 for non-popups (Bug#3642).
7668
1dae0f0a
AS
76692011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7670
268c2c36 7671 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7672 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7673 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7674 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7675 * data.c (fmod): Likewise.
7676 * dispnew.c (swap_glyphs_in_rows): Likewise.
7677 * emacs.c (memory_warning_signal): Likewise.
7678 * floatfns.c (float_error): Likewise.
7679 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7680 (otf_open, font_otf_capability, generate_otf_features)
7681 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7682 Likewise.
7683 * image.c (pbm_read_file): Likewise.
7684 * indent.c (string_display_width): Likewise.
7685 * intervals.c (check_for_interval, search_for_interval)
7686 (inc_interval_count, count_intervals, root_interval)
7687 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7688 * lread.c (defalias): Likewise.
268c2c36 7689 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7690 * regex.c (set_image_of_range_1, set_image_of_range)
7691 (regex_grow_registers): Likewise.
7692 * sysdep.c (strerror): Likewise.
7693 * termcap.c (valid_filename_p, tprint, main): Likewise.
7694 * tparam.c (main): Likewise.
7695 * unexhp9k800.c (run_time_remap, save_data_space)
7696 (update_file_ptrs, read_header, write_header, calculate_checksum)
7697 (copy_file, copy_rest, display_header): Likewise.
7698 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7699 Likewise.
7700 * xdisp.c (check_it): Likewise.
7701 * xfaces.c (register_color, unregister_color, unregister_colors):
7702 Likewise.
7703 * xfns.c (print_fontset_result): Likewise.
7704 * xrdb.c (member, fatal, main): Likewise.
7705
99033785
PE
77062011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7707
7708 Fix minor problems found by static checking (Bug#9031).
7709 * chartab.c (char_table_set_range, map_sub_char_table):
7710 Remove unused locals.
7711 (uniprop_table): Now static.
7712 * composite.c (_work_char): Remove unused static var.
7713
9cb2ac56
JB
77142011-07-09 Juanma Barranquero <lekktu@gmail.com>
7715
7716 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7717
f25661f0
JD
77182011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7719
7720 * gtkutil.c (qttip_cb): Remove code without function.
7721
8278c4fe
EZ
77222011-07-09 Eli Zaretskii <eliz@gnu.org>
7723
7724 * w32.c (pthread_sigmask): New stub.
7725
1692ae2d 77262011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7727
8a6ebd58 7728 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7729 sigprocmask is portable only for single-threaded applications, and
7730 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7731 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7732 (LIBES): Use it.
7733 * callproc.c (Fcall_process):
7734 * process.c (create_process):
7735 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7736 Use pthread_sigmask, not sigprocmask.
123403e4 7737
1b854618
JD
77382011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7739
7740 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7741 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7742 wrong (Bug#8591).
7743
3fe4b549
JD
77442011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7745
0ce7e563
JD
7746 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7747 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7748 (xg_hide_tooltip): Fix comment.
7749
3fe4b549
JD
7750 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7751 in registerServicesMenuSendTypes.
7752 (validRequestorForSendType): Don't check ns_return_types.
7753
7754 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7755 ns_return_type.
7756
5df75e47
JR
77572011-07-08 Jason Rumney <jasonr@gnu.org>
7758
22610910
JR
7759 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7760 SH_SHOW for hidden windows (Bug#5482).
7761
5df75e47
JR
7762 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7763 frame struct members of non-existent frames (Bug#6284).
7764
699c10bd
JD
77652011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7766
4393663b
JD
7767 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7768 variable firstTime not needed on OSX >= 10.6.
7769 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7770 >= 10.5. Use setKnobProportion, setDoubleValue.
7771
7772 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7773 (MAC_OS_X_VERSION_10_5): Define if not defined.
7774 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7775 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7776 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7777
7778 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 7779 cString and lossyCString on OSX >= 10.4.
4393663b 7780
58179cce 7781 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7782 sizeToFit on OSX >= 10.2.
7783
7784 * nsimage.m (allocInitFromFile): Don't use deprecated method
7785 bestRepresentationForDevice on OSX >= 10.6.
7786
7787 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7788 to avoid warning.
7789
7790 * emacs.c: Declare unexec_init_emacs_zone.
7791
a63e0781
JD
7792 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7793
699c10bd
JD
7794 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7795
7796 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7797 on svcsMenu (Bug#8842).
7798
7799 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7800 ns_return_types.
7801 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7802
7803 * nsterm.m (QUTF8_STRING): Declare.
7804 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7805 (validRequestorForSendType): Return type is (id).
7806 Change indexOfObjectIdenticalTo to indexOfObject.
7807 Check if we have local selection before returning self (Bug#8842).
7808 (writeSelectionToPasteboard): Put local selection into paste board
7809 if we have a local selection (Bug#8842).
7810 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7811
7812 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7813 (ns_get_local_selection): Declare.
7814
54e10184
LMI
78152011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7816
9888ff71
LMI
7817 * keymap.c (describe_map_tree): Don't insert a double newline at
7818 the end of the buffer (bug#1169) and return whether we inserted
7819 something.
7820
54e10184
LMI
7821 * callint.c (Fcall_interactively): Change "reading args" to
7822 "providing args" to try to clarify what it does (bug#1010).
7823
15fa4783
KH
78242011-07-07 Kenichi Handa <handa@m17n.org>
7825
7826 * composite.c (composition_compute_stop_pos): Ignore a static
7827 composition starting before CHARPOS (Bug#8915).
7828
7829 * xdisp.c (handle_composition_prop): Likewise.
7830
a8815b00
EZ
78312011-07-07 Eli Zaretskii <eliz@gnu.org>
7832
7833 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7834 (Bug#9015)
7835
ef7b981d 78362011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7837
7838 * character.h (unicode_category_t): New enum type.
7839
7840 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7841 (Qchar_code_property_table): New variable.
7842 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7843 (UNIPROP_COMPRESSED_FORM_P): New macros.
7844 (char_table_ascii): Uncompress the compressed values.
7845 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7846 Uncompress the compressed values.
ac389d0c 7847 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7848 (char_table_ref_and_range): Uncompress the compressed values.
7849 (sub_char_table_set): New arg is_uniprop. Callers changed.
7850 Uncompress the compressed values.
7851 (sub_char_table_set_range): Args changed. Callers changed.
7852 (char_table_set_range): Adjuted for the above change.
7853 (map_sub_char_table): Delete args default_val and parent. Add arg
7854 top. Give decoded values to a Lisp function.
640c8776 7855 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7856 values to a Lisp function. Gcpro more variables.
7857 (uniprop_table_uncompress)
7858 (uniprop_decode_value_run_length): New functions.
7859 (uniprop_decoder, uniprop_decoder_count): New variables.
7860 (uniprop_get_decoder, uniprop_encode_value_character)
7861 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7862 New functions.
7863 (uniprop_encoder, uniprop_encoder_count): New variables.
7864 (uniprop_get_encoder, uniprop_table)
7865 (Funicode_property_table_internal, Fget_unicode_property_internal)
7866 (Fput_unicode_property_internal): New functions.
7867 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7868 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7869 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7870 char-code-property-alist.
7871
640c8776 7872 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7873 Vunicode_category_table.
7874
640c8776 7875 * font.c (font_range): Adjust for the change of
c805dec0
KH
7876 Vunicode_category_table.
7877
76b397fb
DN
78782011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7879
7880 * m/iris4d.h: Remove file, move contents ...
7881 * s/irix6-5.h: ... here.
7882
22b4128e
PE
78832011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7884
7885 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7886 * alloc.c (mark_buffer):
7887 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7888 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7889 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7890 This isn't true in general, and it's particularly not true
7891 if Emacs is configured with --with-wide-int.
7892 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7893 New macros, used in the buffer.c change.
7894
869795d6
JD
78952011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7896
7897 * xsettings.c: Use both GConf and GSettings if both are available.
7898 (store_config_changed_event): Add comment.
7899 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7900 (store_tool_bar_style_changed): New functions.
5e617bc2 7901 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7902 (struct xsettings): Move font inside HAVE_XFT.
7903 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7904 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7905 Move inside HAVE_XFT.
640c8776 7906 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7907 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7908 also.
7909 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7910 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7911 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7912 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7913 (parse_settings): Move check for font inside HAVE_XFT.
7914 (read_settings, apply_xft_settings): Add comment.
7915 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7916 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7917 call store_font_name_changed.
7918 (xft_settings_event): Add comment.
7919 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7920 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7921 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7922 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7923 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7924 (xsettings_get_system_font, xsettings_get_system_normal_font):
7925 Add comment.
869795d6 7926
d8ed26bd
PE
79272011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7928
7929 Random fixes. E.g., (random) never returned negative values.
7930 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7931 subseconds part to the entropy, as that's a bit more random.
7932 Prefer signed to unsigned, since the signedness doesn't matter and
7933 in general we prefer signed. When given a limit, use a
7934 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7935 latter isn't right if USE_2_TAGS_FOR_INTS.
7936 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7937 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7938
cabf1cac
SM
79392011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7940
7941 * textprop.c (text_property_stickiness):
7942 Obey Vtext_property_default_nonsticky.
7943 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7944 * w32fns.c (syms_of_w32fns):
7945 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7946
6e9b2be9
PE
79472011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7948
7949 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7950 This is more efficient than Ffile_directory_p and avoids a minor race.
7951
90186c68
LMI
79522011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7953
7c301272
LMI
7954 * buffer.c (Foverlay_put): Say what the return value is
7955 (bug#7835).
7956
c4f2d8d4
LMI
7957 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7958 is a directory before asking whether to use the file name
7959 (bug#7564).
ad637907
LMI
7960 (barf_or_query_if_file_exists): Make the "File is a directory"
7961 error be more correct.
c4f2d8d4 7962
90186c68
LMI
7963 * fns.c (Frequire): Remove the mention of the .gz files, since
7964 that's installation-specific, but keep the mention of
7965 `get-load-suffixes'.
7966
da64016e
PE
79672011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7968
7969 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7970 Report string overflow if the output is too long.
7971
7d47b580
JB
79722011-07-04 Juanma Barranquero <lekktu@gmail.com>
7973
a555cb87
JB
7974 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7975 (syms_of_gnutls): Remove duplicate DEFSYM for
7976 Qgnutls_bootprop_verify_hostname_error, an error for
7977 Qgnutls_bootprop_verify_error (which is no longer used).
7978
7d47b580
JB
7979 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7980 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7981 Also (re)move comments that are misplaced or no longer relevant.
7982
1e49bfab
LMI
79832011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7984
7985 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7986
1485f4c0
CY
79872011-07-03 Chong Yidong <cyd@stupidchicken.com>
7988
7989 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7990 and background color parameters if they have been changed.
7991
a9ab721e
LMI
79922011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7993
7994 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7995
cf7cff57
PE
79962011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7997
2e13213d
PE
7998 * xsettings.c (SYSTEM_FONT): Define only when used.
7999 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8000
cf7cff57
PE
8001 * keymap.c (access_keymap_1): Now static.
8002
7a8e04f7
CY
80032011-07-02 Chong Yidong <cyd@stupidchicken.com>
8004
8005 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8006 leave any prefix arg for the up event (Bug#1586).
8007
61352f62
LMI
80082011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8009
69bb1ef7
LMI
8010 * lread.c (syms_of_lread): Mention single symbols defined by
8011 `defvar' or `defconst' (bug#7154).
8012
61352f62 8013 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8014 (Frequire): Mention get-load-suffixes.
61352f62 8015
28545e04
MR
80162011-07-02 Martin Rudalics <rudalics@gmx.at>
8017
8018 * window.h (window): Remove clone_number slot.
8019 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8020 Remove.
8021 (make_parent_window, make_window, saved_window)
8022 (Fset_window_configuration, save_window_save): Don't deal with
8023 clone numbers.
8024 * buffer.c (Qclone_number): Remove declaration.
8025 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8026
3349e122
SM
80272011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8028
8029 Add multiple inheritance to keymaps.
8030 * keymap.c (Fmake_composed_keymap): New function.
8031 (Fset_keymap_parent): Simplify.
8032 (fix_submap_inheritance): Remove.
8033 (access_keymap_1): New function extracted from access_keymap to handle
8034 embedded parents and handle lists of maps.
8035 (access_keymap): Use it.
8036 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8037 (Fcopy_keymap): Handle embedded parents.
8038 (Fcommand_remapping, define_as_prefix): Simplify.
8039 (Fkey_binding): Simplify.
8040 (syms_of_keymap): Move minibuffer-local-completion-map,
8041 minibuffer-local-filename-completion-map,
8042 minibuffer-local-must-match-map, and
8043 minibuffer-local-filename-must-match-map to Elisp.
8044 (syms_of_keymap): Defsubr make-composed-keymap.
8045 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8046 (parse_menu_item): Trivial simplification.
8047
3279eb87
GM
80482011-07-01 Glenn Morris <rgm@gnu.org>
8049
8050 * Makefile.in (SETTINGS_LIBS): Fix typo.
8051
4550efdf
KI
80522011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8053
8054 * coding.c (Fencode_coding_string): Record the last coding system
8055 used, as the function doc string says (bug#8738).
8056
0949d2b6
JD
80572011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8058
8059 * xsettings.c (store_monospaced_changed): Take new font as arg and
8060 check for change against current_mono_font.
8061 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8062 (emacs_settings_constructor, emacs_settings_get_property)
8063 (emacs_settings_set_property, emacs_settings_class_init)
8064 (emacs_settings_init, gsettings_obj): Remove.
8065 (something_changedCB): New function for HAVE_GSETTINGS.
8066 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8067 with value as argument.
8068 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8069 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8070 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8071 "changed".
8072
8073 * xgselect.c: Add defined (HAVE_GSETTINGS).
8074 (xgselect_initialize): Ditto.
8075
8076 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8077 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8078 xg_select.
8079
bbc6b304
PE
80802011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8081
8082 * eval.c (struct backtrace): Simplify and port the data structure.
8083 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8084 signed bit field, as this assumption is not portable and it makes
8085 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8086 "char debug_on_exit : 1" as this is not portable either; instead,
8087 use the portable "unsigned int debug_on_exit : 1". Remove unused
8088 member evalargs. Remove obsolete comments about cc bombing out.
8089
9851bfc5
JD
80902011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8091
51bb811f 8092 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8093 Let HAVE_GSETTINGS override HAVE_GCONF.
8094 (store_monospaced_changed): New function.
8095 (EMACS_SETTINGS): A new type derived from GObject to handle
8096 GSettings notifications.
8097 (emacs_settings_constructor, emacs_settings_get_property)
8098 (emacs_settings_set_property, emacs_settings_class_init):
8099 New functions.
8100 (gsettings_client, gsettings_obj): New variables.
8101 (GSETTINGS_SCHEMA): New define.
8102 (something_changedCB): Call store_monospaced_changed.
8103 (init_gsettings): New function.
8104 (xsettings_initialize): Call init_gsettings.
8105 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8106 to NULL.
8107
640c8776 8108 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8109 GCONF_CFLAGS/LIBS.
8110
5386012d
MR
81112011-06-29 Martin Rudalics <rudalics@gmx.at>
8112
8113 * window.c (resize_root_window, grow_mini_window)
8114 (shrink_mini_window): Rename Qresize_root_window to
8115 Qwindow_resize_root_window and Qresize_root_window_vertically to
8116 Qwindow_resize_root_window_vertically.
8117
f13e0b08
PE
81182011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8119
8120 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8121
94515237
JB
81222011-06-27 Juanma Barranquero <lekktu@gmail.com>
8123
8124 * makefile.w32-in: Redesign dependencies so they reflect more
8125 clearly which files are directly included by each source file,
8126 and not through other includes.
8127
e43b6e43
MR
81282011-06-27 Martin Rudalics <rudalics@gmx.at>
8129
8130 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8131 (sort_overlays, overlay_strings): When an overlay's clone number
8132 matches the window's clone number process the overlay even if
8133 the overlay's window property doesn't match the current window.
8134
d68443dc
MR
8135 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8136 (Fwindow_hchild): Rename to Fwindow_left_child.
8137 (Fwindow_next): Rename to Fwindow_next_sibling.
8138 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8139 (resize_window_check): Rename to window_resize_check.
8140 (resize_window_apply): Rename to window_resize_apply.
8141 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8142 (Fdelete_other_windows_internal, resize_frame_windows)
8143 (Fsplit_window_internal, Fdelete_window_internal)
8144 (grow_mini_window, shrink_mini_window)
8145 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8146
c7e73be5
JD
81472011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8148
8149 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8150 (emacs_fixed_set_min_size): Remove.
8151 (emacs_fixed_new): Take frame as argument.
8152
8153 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8154 (_EmacsFixedPrivate): Remove minwidth/height.
8155 Add struct frame *f.
8156 (emacs_fixed_init): Initialize priv->f.
8157 (get_parent_class, emacs_fixed_set_min_size): Remove.
8158 (emacs_fixed_new): Set priv->f to argument.
8159 (emacs_fixed_get_preferred_width)
8160 (emacs_fixed_get_preferred_height): Use min_width/height from
8161 frames size_hint to set minimum and natural (Bug#8919).
8162 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8163 and use min_width/height from frames size_hint to set
8164 min_width/height (Bug#8919).
8165
8166 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8167 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8168 Fix indentation.
c7e73be5 8169
cf99dcf8
EZ
81702011-06-26 Eli Zaretskii <eliz@gnu.org>
8171
8172 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8173 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8174 called at ZV.
8175
029529ac
CY
81762011-06-26 Chong Yidong <cyd@stupidchicken.com>
8177
8178 * process.c (wait_reading_process_output): Bypass select if
8179 waiting for a cell while ignoring keyboard input, and input is
8180 pending. Suggested by Jan Djärv (Bug#8869).
8181
7a7ef429
PE
81822011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8183
8184 Use gnulib's dup2 module instead of rolling our own.
8185 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8186
11fdef7d 81872011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8188
8189 * dispnew.c (scrolling_window): Before scrolling, turn off a
8190 mouse-highlight in the window being scrolled.
8191
cd3520a4
JB
81922011-06-24 Juanma Barranquero <lekktu@gmail.com>
8193
8194 Move DEFSYM to lisp.h and use everywhere.
8195
8196 * character.h (DEFSYM): Move declaration...
8197 * lisp.h (DEFSYM): ...here.
8198
8199 * gnutls.c:
8200 * minibuf.c:
8201 * w32menu.c:
8202 * w32proc.c:
8203 * w32select.c: Don't include character.h.
8204
8205 * alloc.c (syms_of_alloc):
8206 * buffer.c (syms_of_buffer):
8207 * bytecode.c (syms_of_bytecode):
8208 * callint.c (syms_of_callint):
8209 * casefiddle.c (syms_of_casefiddle):
8210 * casetab.c (init_casetab_once):
8211 * category.c (init_category_once, syms_of_category):
8212 * ccl.c (syms_of_ccl):
8213 * cmds.c (syms_of_cmds):
8214 * composite.c (syms_of_composite):
8215 * dbusbind.c (syms_of_dbusbind):
8216 * dired.c (syms_of_dired):
8217 * dispnew.c (syms_of_display):
8218 * doc.c (syms_of_doc):
8219 * editfns.c (syms_of_editfns):
8220 * emacs.c (syms_of_emacs):
8221 * eval.c (syms_of_eval):
8222 * fileio.c (syms_of_fileio):
8223 * fns.c (syms_of_fns):
8224 * frame.c (syms_of_frame):
8225 * fringe.c (syms_of_fringe):
8226 * insdel.c (syms_of_insdel):
8227 * keymap.c (syms_of_keymap):
8228 * lread.c (init_obarray, syms_of_lread):
8229 * macros.c (syms_of_macros):
8230 * msdos.c (syms_of_msdos):
8231 * print.c (syms_of_print):
8232 * process.c (syms_of_process):
8233 * search.c (syms_of_search):
8234 * sound.c (syms_of_sound):
8235 * syntax.c (init_syntax_once, syms_of_syntax):
8236 * terminal.c (syms_of_terminal):
8237 * textprop.c (syms_of_textprop):
8238 * undo.c (syms_of_undo):
8239 * w32.c (globals_of_w32):
8240 * window.c (syms_of_window):
8241 * xdisp.c (syms_of_xdisp):
8242 * xfaces.c (syms_of_xfaces):
8243 * xfns.c (syms_of_xfns):
8244 * xmenu.c (syms_of_xmenu):
8245 * xsettings.c (syms_of_xsettings):
8246 * xterm.c (syms_of_xterm): Use DEFSYM.
8247
4228cf16
TZ
82482011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8249
cd3520a4 8250 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8251
7fcccf1e
PE
82522011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8253
7efb4e0e
PE
8254 Integer and buffer overflow fixes (Bug#8873).
8255
ff5844ad
PE
8256 * print.c (printchar, strout): Check for string overflow.
8257 (PRINTPREPARE, printchar, strout):
8258 Don't set size unless allocation succeeds.
8259
90532f02
PE
8260 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8261 for sizes. Check for string overflow more accurately.
8262 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8263
6d84508d
PE
8264 * macros.c: Integer and buffer overflow fixes.
8265 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8266 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8267 Use ptrdiff_t, not int, for sizes.
8268 Don't increment bufsize until after realloc succeeds.
8269 Check for size-calculation overflow.
8270 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8271
437b2cb4
PE
8272 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8273
8b9ac8b4
PE
8274 * lread.c: Integer overflow fixes.
8275 (read_integer): Radix is now EMACS_INT, not int,
8276 to improve quality of diagnostics for out-of-range radices.
8277 Calculate buffer size correctly for out-of-range radices.
8278 (read1): Check for integer overflow in radices, and in
8279 read-circle numbers.
82cb60d3
PE
8280 (read_escape): Avoid int overflow.
8281 (Fload, openp, read_buffer_size, read1)
8282 (substitute_object_recurse, read_vector, read_list, map_obarray):
8283 Use ptrdiff_t, not int, for sizes.
8284 (read1): Use EMACS_INT, not int, for sizes.
20270765 8285 Check for size overflow.
8b9ac8b4 8286
7fcccf1e
PE
8287 * image.c (cache_image): Check for size arithmetic overflow.
8288
bfbbd7e7
PE
8289 * lread.c: Integer overflow issues.
8290 (saved_doc_string_size, saved_doc_string_length)
8291 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8292 Now ptrdiff_t, not int.
8293 (read1): Don't assume doc string length fits in int. Check for
8294 out-of-range doc string lengths.
8295 (read_list): Don't assume file position fits in int.
39019e54 8296 (read_escape): Check for hex character overflow.
bfbbd7e7 8297
4e323265
LL
82982011-06-22 Leo Liu <sdl.web@gmail.com>
8299
8300 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8301 Move to minibuffer.el.
8302
85fece3e
PE
83032011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8304
20b84ce9 8305 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8306 The following patches are for when GLYPH_DEBUG && !XASSERT.
8307 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8308 * dispnew.c (flush_stdout):
8309 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8310 Mark as externally visible.
8311 * dispnew.c (check_window_matrix_pointers): Now static.
8312 * dispnew.c (window_to_frame_vpos):
8313 * xfns.c (unwind_create_frame):
8314 * xterm.c (x_check_font): Remove unused local.
8315 * scroll.c (CHECK_BOUNDS):
8316 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8317 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8318 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8319 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8320 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8321 Now static.
8322 (debug_method_add): Use va_list and vsprintf rather than relying
8323 on undefined behavior with wrong number of arguments.
8324 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8325 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8326 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8327 since we're not interested in debugging glyphs with old libraries.
8328 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8329 GCC 4.6.0's static checking.
8330
0766b489
PE
83312011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8332
31fd4b32
PE
8333 Integer overflow and signedness fixes (Bug#8873).
8334 A few related buffer overrun fixes, too.
8335
b79e8648
PE
8336 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8337
0766b489
PE
8338 * dispextern.h (struct face.stipple):
8339 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8340 (x_bitmap_mask, x_allocate_bitmap_record)
8341 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8342 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8343 (x_create_bitmap_from_xpm_data):
8344 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8345 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8346 (.bitmaps_last):
8347 * xfaces.c (load_pixmap):
8348 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8349 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8350 (.bitmaps_last, struct x_output.icon_bitmap):
8351 Use ptrdiff_t, not int, for bitmap indexes.
8352 (x_allocate_bitmap_record): Check for size overflow.
8353 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8354
b081724f
PE
8355 Use ptrdiff_t, not int, for overlay counts.
8356 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8357 * editfns.c (overlays_around, get_pos_property):
8358 * textprop.c (get_char_property_and_overlay):
8359 * xdisp.c (next_overlay_change, note_mouse_highlight):
8360 * xfaces.c (face_at_buffer_position):
21514da7
PE
8361 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8362 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8363 (Fnext_overlay_change, Fprevious_overlay_change)
8364 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8365 Use ptrdiff_t, not int, for sizes.
21514da7 8366 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8367
3de73e5e
PE
8368 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8369
2606c57b
PE
8370 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8371 (x_session_initialize): Do not assume string length fits in int.
8372
aaafe47a
PE
8373 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8374 This is unlikely, but can occur if DPI is outlandish.
8375
2674ddc8 8376 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8377 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8378
28154962
PE
8379 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8380 * xrdb.c (magic_file_p, search_magic_path):
8381 Omit last arg SUFFIX; it was always 0. All callers changed.
8382 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8383
7de51af5
PE
8384 * xfont.c (xfont_match): Avoid need for strlen.
8385
25ed6cc3
PE
8386 * xfns.c: Don't assume strlen fits in int.
8387 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8388
4eab31dd
PE
8389 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8390 not unsigned long, as we prefer signed integers. All callers changed.
8391 Detect integer overflow in repeat count.
8392 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8393 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8394
171e2a58
PE
8395 * termcap.c: Don't assume sizes fit in int and never overflow.
8396 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8397 (gobble_line): Check for size-calculation overflow.
8398
ad39faca 8399 * minibuf.c (Fread_buffer):
6e5bb2dc 8400 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8401 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8402 Don't assume string length fits in int.
8403
52c61c22 8404 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8405 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8406
b5b8c9e5
PE
8407 * font.c: Don't assume string length fits in int.
8408 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8409 Use ptrdiff_t, not int.
ccd6111c
PE
8410 (font_intern_prop): Don't assume string length fits in int.
8411 Don't assume integer property fits in fixnum.
8412 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8413
882f0d81 8414 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8415 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8416 Reformulate so as not to need the command string.
8417 Invoke gzip -cd rather than gunzip, as it's more portable.
8418 (lock_info_type, lock_file_1, lock_file):
8419 Don't assume pid_t and time_t fit in unsigned long.
8420 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8421 (current_lock_owner): Prefer signed type for sizes.
8422 Use memcpy, not strncpy, where memcpy is what is really wanted.
8423 Don't assume (via atoi) that time_t and pid_t fit in int.
8424 Check for time_t and/or pid_t out of range, e.g., via a network share.
8425 Don't alloca where an auto var works fine.
8426
93f4cf88
PE
8427 * fileio.c: Fix some integer overflow issues.
8428 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8429 Don't assume string length fits in int.
8430 (directory_file_name): Don't assume string length fits in long.
8431 (make_temp_name): Don't assume pid fits in int, or that its print
8432 length is less than 20.
8433
f3e92b69
PE
8434 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8435
1bfdaf10
PE
8436 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8437
35016e9a
PE
8438 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8439
3d1e65a1
PE
8440 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8441 We prefer signed integers, even for size calculations.
8442
0b963a93
PE
8443 * emacs.c: Don't assume string length fits in 'int'.
8444 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8445 (main): Don't invoke strlen when not needed.
8446
573f4b54
PE
8447 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8448 (XD_DEBUG_MESSAGE): Don't waste a byte.
8449
989f33ba
PE
8450 * callproc.c (getenv_internal_1, getenv_internal)
8451 (Fgetenv_internal):
965d34eb
PE
8452 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8453
e4d29b33
PE
8454 * lread.c (invalid_syntax): Omit length argument.
8455 All uses changed. This doesn't fix a bug, but it simplifies the
8456 code away from its former Hollerith-constant appearance, and it's
8457 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8458 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8459
eb49b136
PE
8460 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8461 This didn't break anything, but it didn't help either.
8462 It's confusing to put a bogus integer in a place where the actual
8463 value does not matter.
9f62aeb1 8464 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8465 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8466
15375a22
PE
8467 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8468 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8469 implementation.
b61cc01c
PE
8470 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8471 We prefer signed types, and the value cannot exceed the EMACS_INT
8472 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8473 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8474 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8475 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8476
53b2623d
PE
8477 * indent.c (sane_tab_width): New function.
8478 (current_column, scan_for_column, Findent_to, position_indentation)
8479 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8480 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8481
51cab52b 8482 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8483
f2ed8a70
PE
8484 * lisp.h (lint_assume): New macro.
8485 * composite.c (composition_gstring_put_cache):
8486 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8487
abe80cc6
PE
8488 * editfns.c, insdel.c:
8489 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8490
b02c740e
PE
8491 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8492
ebc96716
PE
8493 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8494
b4e50fa0 8495 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8496 Use much-faster test for byte-length change.
311d5d7c 8497 Don't assume string byte-length fits in 'int'.
a4cf38e4 8498 Check that character arg fits in 'int'.
85461888 8499 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8500
c0c1ee9f
PE
8501 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8502
a498d7f4
PE
8503 * fns.c (concat): Catch string overflow earlier.
8504 Do not rely on integer wraparound.
8505
51cab52b
PE
8506 * dispextern.h (struct it.overlay_strings_charpos)
8507 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8508 * xdisp.c (forward_to_next_line_start)
8509 (back_to_previous_visible_line_start)
8510 (reseat_at_next_visible_line_start, next_element_from_buffer):
8511 Don't arbitrarily truncate the value of 'selective' to int.
8512
76031fad
PE
8513 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8514
5eb55db9
PE
8515 * composite.c: Don't truncate sizes to 'int'.
8516 (composition_gstring_p, composition_reseat_it)
8517 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8518 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8519 not EMACS_UINT, for indexes.
5eb55db9 8520
0703a717
PE
8521 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8522
d6202519
PE
8523 * buffer.c: Include <verify.h>.
8524 (struct sortvec.priority, struct sortstr.priority):
8961a454 8525 Now EMACS_INT, not int.
c20998a7 8526 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8527 (struct sortstr.size, record_overlay_string)
8528 (struct sortstrlist.size, struct sortlist.used):
8529 Don't truncate size to int.
8530 (record_overlay_string): Check for size-calculation overflow.
d6202519 8531 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8532
d5a19415
JM
85332011-06-22 Jim Meyering <meyering@redhat.com>
8534
029529ac 8535 Don't leak an XBM-image-sized buffer
d5a19415
JM
8536 * image.c (xbm_load): Free the image buffer after using it.
8537
a9041e6c
PE
85382011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8539
8540 Port to Sun C.
8541 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8542 that Sun C diagnosed.
8543 * fns.c (secure_hash): Fix pointer signedness issue.
8544 * intervals.c (static_offset_intervals): New function.
8545 (offset_intervals): Use it.
8546
7f3f739f
LL
85472011-06-21 Leo Liu <sdl.web@gmail.com>
8548
8549 * deps.mk (fns.o):
8550 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8551 sha512.h.
8552
8553 * fns.c (secure_hash): Rename from crypto_hash_function and change
8554 the first arg to accept symbols.
5b66d427 8555 (Fsecure_hash): New primitive.
7f3f739f
LL
8556 (syms_of_fns): New symbols.
8557
76147d94
DD
85582011-06-20 Deniz Dogan <deniz@dogan.se>
8559
8560 * process.c (Fset_process_buffer): Clarify return value in
8561 docstring.
8562
7d7d0045
CY
85632011-06-18 Chong Yidong <cyd@stupidchicken.com>
8564
8565 * dispnew.c (add_window_display_history): Use BVAR.
8566
8567 * xdisp.c (debug_method_add): Use BVAR.
8568 (check_window_end, dump_glyph_matrix, dump_glyph)
8569 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8570
8571 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8572 Likewise.
8573
8574 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8575 check till after the cache is created in init_frame_faces.
8576
ff2bc410
SM
85772011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8578
8579 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8580
28177add
PE
85812011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8582
dd3482fe
PE
8583 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8584 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8585 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8586
393d71f3 8587 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8588 * fileio.c (Finsert_file_contents):
8589 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8590 Remove the old (too-loose) buffer overflow checks.
8591 They weren't needed, since make_gap checks for buffer overflow.
8592 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8593 The old code merely checked for Emacs fixnum overflow, and relied
8594 on undefined (wraparound) behavior. The new code avoids undefined
8595 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8596
2e6813b0 8597 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8598 Tune. Don't use wider integers than needed. Don't use alloca.
8599 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8600
599a9e4f
PE
8601 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8602
99561444
PE
8603 * insdel.c, lisp.h (buffer_overflow): New function.
8604 (insert_from_buffer_1, replace_range, replace_range_2):
8605 * insdel.c (make_gap_larger):
8606 * editfns.c (Finsert_char):
8607 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8608
28177add
PE
8609 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8610
e69dafad
PE
86112011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8612
4baa020d 8613 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8614
b1c46f02
PE
8615 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8616 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8617
e69dafad
PE
8618 * fileio.c: Don't assume EMACS_INT fits in off_t.
8619 (emacs_lseek): New static function.
8620 (Finsert_file_contents, Fwrite_region): Use it.
8621 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8622
566684ea
PE
8623 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8624
e6966cd6
PE
8625 * fns.c: Don't overflow int when computing a list length.
8626 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8627 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8628 truncation on 64-bit hosts. Check for QUIT every
8629 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8630 faster and is responsive enough.
8631 (Flength): Report an error instead of overflowing an integer.
8632 (Fsafe_length): Return a float if the value is not representable
8633 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8634 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8635 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8636
dd0b0efb
PE
8637 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8638 (header_size, word_size): New constants.
8639 (allocate_vectorlike): Don't check size overflow here.
8640 (allocate_vector): Check it here instead, since this is the only
8641 caller of allocate_vectorlike that could cause overflow.
8642 Check that the new vector's length is representable as a fixnum.
8643
86fe5cfe
PE
8644 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8645 The previous code was bogus. For example, next_almost_prime (32)
8646 returned 39, which is undesirable as it is a multiple of 3; and
8647 next_almost_prime (24) returned 25, which is a multiple of 5 so
8648 why was the code bothering to check for multiples of 7?
8649
80e88859
PE
8650 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8651
4a2f0ad6
PE
8652 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8653
f66c7cf8
PE
8654 Variadic C functions now count arguments with ptrdiff_t.
8655 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8656 Back then I didn't know that the Emacs coding style prefers signed int.
8657 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8658 were being counted with int, which may truncate counts on 64-bit
8659 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8660 * lisp.h (struct Lisp_Subr.function.aMANY)
8661 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8662 Arg counts are now ptrdiff_t, not size_t.
8663 All variadic functions and their callers changed accordingly.
8664 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8665 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8666 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8667 * callint.c (Fcall_interactively): Check arg count for overflow,
8668 to avoid potential buffer overrun. Use signed char, not 'int',
8669 for 'varies' array, so that we needn't bother to check its size
8670 calculation for overflow.
8671 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8672 * eval.c (apply_lambda):
8673 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8674 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8675 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8676
a1759b76
PE
8677 * callint.c (Fcall_interactively): Don't use index var as event count.
8678
d96be9fc
PE
8679 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8680 * mem-limits.h (SIZE): Remove; no longer used.
8681
a690a978 8682 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8683
578c21e6
PE
8684 Remove unnecessary casts.
8685 * xterm.c (x_term_init):
8686 * xfns.c (x_set_border_pixel):
8687 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8688 These aren't needed now that we assume ANSI C.
8689
96f53c6c
PE
8690 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8691 It's more likely to cause problems (due to unsigned overflow)
8692 than to cure them.
8693
83c77d31
PE
8694 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8695
ee2079f1
PE
8696 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8697
6da65536
PE
8698 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8699
7147c4a4
PE
8700 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8701
193e32d9
PE
8702 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8703
e5533da6
PE
8704 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8705
9910e595
PE
8706 GLYPH_CODE_FACE returns EMACS_INT, not int.
8707 * dispextern.h (merge_faces):
8708 * xfaces.c (merge_faces):
01103c44
PE
8709 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8710 Don't assume EMACS_INT fits in int.
9910e595 8711
2638320e
PE
8712 * character.h (CHAR_VALID_P): Remove unused parameter.
8713 * fontset.c, lisp.h, xdisp.c: All uses changed.
8714
045eb8d9
PE
8715 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8716
c1f134b5
PE
8717 * fns.c (concat): Minor tuning based on overflow analysis.
8718 This doesn't fix any bugs. Use int to hold character, instead
8719 of constantly refetching from Emacs object. Use XFASTINT, not
8720 XINT, for value known to be a character. Don't bother comparing
8721 a single byte to 0400, as it's always less.
8722
395fcb93 8723 * floatfns.c (Fexpt):
327eeec8
PE
8724 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8725
abbd3d23
PE
8726 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8727 for characters.
8728
684a03ef
PE
8729 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8730
0fed43f3
PE
8731 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8732 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8733 incorrectly succeed when S was a string, because 4294967386 was
8734 truncated before it was used.
8735
8fd02eb7
PE
8736 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8737 Otherwise, an out-of-range integer could cause undefined behavior
8738 on a 64-bit host.
8739
f8c86b69
PE
8740 * composite.c: Use int, not EMACS_INT, for characters.
8741 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8742 EMACS_INT, for values that are known to be in character range.
8743 This doesn't fix any bugs but is the usual style inside Emacs and
8744 may generate better code on 32-bit machines.
8745
34206dd2
PE
8746 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8747 This is for reasons similar to the recent CHAR_STRING fix.
8748 * charset.c (Fencode_char): Check that character arg is actually
8749 a character. Pass an int to ENCODE_CHAR.
8750 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8751 wider than 'int', as a compile-time check to prevent future regressions
8752 in this area.
8753
c5958d4c 8754 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8755
8756 Make sure a 64-bit char is never passed to CHAR_STRING.
8757 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8758 by silently ignoring the top 32 bits, allowing some values
8759 that were far too large to be valid characters.
8760 * character.h: Include <verify.h>.
8761 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8762 arguments are no wider than unsigned, as a compile-time check
8763 to prevent future regressions in this area.
8764 * data.c (Faset):
01103c44 8765 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8766 (Fsubst_char_in_region):
8767 * fns.c (concat):
8768 * xdisp.c (decode_mode_spec_coding):
8769 Adjust to CHAR_STRING's new requirement.
8770 * editfns.c (Finsert_char, Fsubst_char_in_region):
8771 * fns.c (concat): Check that character args are actually
8772 characters. Without this test, these functions did the wrong
8773 thing with wildly out-of-range values on 64-bit hosts.
8774
d37ca623
PE
8775 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8776 These casts should not be needed on 32-bit hosts, either.
8777 * keyboard.c (read_char):
8778 * lread.c (Fload): Remove casts to unsigned.
8779
ea204efb
PE
8780 * lisp.h (UNSIGNED_CMP): New macro.
8781 This fixes comparison bugs on 64-bit hosts.
8782 (ASCII_CHAR_P): Use it.
8783 * casefiddle.c (casify_object):
01103c44 8784 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8785 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8786 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8787 * dispextern.h (FACE_FROM_ID):
8788 * keyboard.c (read_char): Use UNSIGNED_CMP.
8789
41cb286c
PE
8790 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8791 not to EMACS_INT, to avoid GCC warning.
8792
4a1b9832
PE
8793 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8794
55daad71
PE
8795 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8796 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8797 isn't needed on 32-bit machines.
8f95c75c 8798
01103c44
PE
8799 * buffer.c (Fgenerate_new_buffer_name):
8800 Use EMACS_INT for count, not int.
0ceccced 8801 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8802
8803 * data.c (Qcompiled_function): Now static.
8804
c6f072e7
PE
8805 * window.c (window_body_lines): Now static.
8806
20ce5912
PE
8807 * image.c (gif_load): Rename local to avoid shadowing.
8808
9c4c5f81
PE
8809 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8810 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8811 * alloc.c (make_save_value): Integer argument is now of type
8812 ptrdiff_t, not int.
8813 (mark_object): Use ptrdiff_t, not int.
8814 * lisp.h (pD): New macro.
8815 * print.c (print_object): Use it.
8816
c0c5c8ae
PE
8817 * alloc.c: Use EMACS_INT, not int, to count objects.
8818 (total_conses, total_markers, total_symbols, total_vector_size)
8819 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8820 (total_free_floats, total_floats, total_free_intervals)
8821 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8822 Now EMACS_INT, not int. All uses changed.
8823 (Fgarbage_collect): Compute overall total using a double, so that
8824 integer overflow is less likely to be a problem. Check for overflow
8825 when converting back to an integer.
5a25e253
PE
8826 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8827 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8828 These were 'int' variables that could overflow on 64-bit hosts;
8829 they were never used, so remove them instead of repairing them.
211a0b2a 8830 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8831 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8832 Previously, this ceilinged at INT_MAX, but that doesn't work on
8833 64-bit machines.
e46bb31a 8834 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8835
c78baabf 8836 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8837 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8838 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8839 when a (possibly-narrower) signed value would do just as well.
8840 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8841
c9d624c6
PE
8842 * alloc.c: Catch some string size overflows that we were missing.
8843 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8844 for convenience in STRING_BYTES_MAX.
8845 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8846 The definition here is exact; the one in lisp.h was approximate.
8847 (allocate_string_data): Check for string overflow. This catches
8848 some instances we weren't catching before. Also, it catches
8849 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8850 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8851 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8852
c9d624c6
PE
8853 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8854 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8855 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8856
353032ce
PE
8857 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8858
2bccce07
PE
8859 * alloc.c (Fmake_string): Check for out-of-range init.
8860
0ac30604
SM
88612011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8862
8863 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8864
c195f2de
JD
88652011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8866
8867 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8868 xg_get_default_scrollbar_width.
8869
8870 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8871 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8872 (style_changed_cb): Call update_theme_scrollbar_width and call
8873 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8874 all frames (Bug#8505).
8875 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8876 Call gtk_window_set_resizable if HAVE_GTK3.
8877 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8878 and height if HAVE_GTK3 (Bug#8505).
8879 (scroll_bar_width_for_theme): New variable.
8880 (update_theme_scrollbar_width): New function.
8881 (xg_get_default_scrollbar_width): Move code to
8882 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8883 (xg_initialize): Call update_theme_scrollbar_width.
8884
8885 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8886
8887 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8888
e10ac9f1
MR
88892011-06-12 Martin Rudalics <rudalics@gmx.at>
8890
8891 * frame.c (make_frame): Call other_buffer_safely instead of
8892 other_buffer.
8893
8894 * window.c (temp_output_buffer_show): Call display_buffer with
8895 second argument Vtemp_buffer_show_specifiers and reset latter
8896 immediately after the call.
8897 (Vtemp_buffer_show_specifiers): New variable.
8898 (auto_window_vscroll_p, next_screen_context_lines)
8899 (Vscroll_preserve_screen_position): Remove leading asterisks from
8900 doc-strings.
8901
2d3c217e 89022011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8903
7b7f97e8 8904 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8905 * buffer.c (Qclone_number): Remove for now, as it's unused.
8906 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8907 (record_buffer): Remove unused local.
8908 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8909 (set_frame_buffer_list): Remove; unused.
8910 * frame.h (other_visible_frames): Remove decl.
8911 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8912 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8913 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8914 if HAVE_GPM.
8915 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8916 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8917 Define only if HAVE_GPM.
8918 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8919 (update_hints_inhibit): Remove; never set. All uses removed.
8920 * widgetprv.h (emacsFrameClassRec): Remove decl.
8921 * window.c (delete_deletable_window): Now returns void, since it
8922 wasn't returning anything.
8923 (compare_window_configurations): Remove unused locals.
8924 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8925 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8926 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8927 the same widths as pointers. This follows up on the 2011-05-06 patch.
8928 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8929 * xterm.h: Likewise.
8930 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8931
1384b89e
JB
89322011-06-12 Juanma Barranquero <lekktu@gmail.com>
8933
8934 * makefile.w32-in: Update dependencies.
8935 (LISP_H): Add lib/intprops.h.
8936
1100a63c
CY
89372011-06-11 Chong Yidong <cyd@stupidchicken.com>
8938
8939 * image.c (gif_load): Add animation frame delay to the metadata.
8940 (syms_of_image): Use DEFSYM. New symbol `delay'.
8941
6198ccd0
MR
89422011-06-11 Martin Rudalics <rudalics@gmx.at>
8943
8944 * window.c (delete_deletable_window): Re-add.
8945 (Fset_window_configuration): Rewrite to handle dead buffers and
8946 consequently deletable windows.
8947 (window_tree, Fwindow_tree): Remove. Supply functionality in
8948 window.el.
8949 (compare_window_configurations): Simplify code.
8950
b6e3633c
AS
89512011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8952
1ab0dee5
AS
8953 * image.c (imagemagick_load_image): Fix type mismatch.
8954 (Fimagemagick_types): Likewise.
8955
b6e3633c
AS
8956 * window.h (replace_buffer_in_windows): Declare.
8957
9397e56f
MR
89582011-06-11 Martin Rudalics <rudalics@gmx.at>
8959
8960 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8961 Qclone_number. Remove external declaration of Qdelete_window.
8962 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8963 code.
640c8776
SM
8964 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8965 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8966 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8967 buffer list implementation.
8968 (other_buffer_safely): New function.
8969 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8970 calls to replace_buffer_in_windows and
8971 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8972 if allowed.
8973 (record_buffer): Inhibit quitting and rewrite using quittable
8974 functions. Run Qbuffer_list_update_hook if allowed.
8975 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8976 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8977 Move switch-to-buffer to window.el.
9397e56f
MR
8978 (bury-buffer): Move to window.el.
8979 (Vbuffer_list_update_hook): New variable.
8980
8981 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8982 section.
8983
8984 * window.h (resize_frame_windows): Move up in code.
8985 (Fwindow_frame): Remove EXFUN.
8986 (replace_buffer_in_all_windows): Remove prototype.
8987 (replace_buffer_in_windows_safely): Add prototype.
8988
8989 * window.c: Declare Qdelete_window static again. Move down
8990 declaration of select_count.
8991 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8992 (Fother_window): Move to window.el.
8993 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8994 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8995 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8996 window.el.
8997 (replace_buffer_in_windows): Implement by calling
8998 Qreplace_buffer_in_windows.
8999 (replace_buffer_in_all_windows): Remove with some functionality
9000 moved into replace_buffer_in_windows_safely.
9001 (replace_buffer_in_windows_safely): New function.
9002 (select_window_norecord, select_frame_norecord): Move in front
9003 of run_window_configuration_change_hook. Remove now obsolete
9004 declarations.
640c8776
SM
9005 (Fset_window_buffer): Rewrite doc-string.
9006 Call Qrecord_window_buffer.
9397e56f
MR
9007 (keys_of_window): Move binding for other-window to window.el.
9008
b50691aa
CY
90092011-06-11 Chong Yidong <cyd@stupidchicken.com>
9010
9011 * dispextern.h (struct image): Replace data member, whose int_val
9012 and ptr_val fields were not used by anything, with a single
9013 lisp_val object.
9014
9015 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9016 (gif_clear_image, gif_load, imagemagick_load_image)
9017 (gs_clear_image, gs_load): Callers changed.
9018
3f754b86
PE
90192011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9020
cca69397
PE
9021 * buffer.h: Include <time.h>, for time_t.
9022 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9023
109e28d0
PE
9024 Fix minor problems found by static checking.
9025
60737f02
PE
9026 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9027
4b66faf3
PE
9028 Make identifiers static if they are not used in other modules.
9029 * data.c (Qcompiled_function, Qframe, Qvector):
9030 * image.c (QimageMagick, Qsvg):
9031 * minibuf.c (Qmetadata):
9032 * window.c (resize_window_check, resize_root_window): Now static.
9033 * window.h (resize_window_check, resize_root_window): Remove decls.
9034
109e28d0
PE
9035 * window.c (window_deletion_count, delete_deletable_window):
9036 Remove; unused.
46a4ce9e
PE
9037 (window_body_lines): Now static.
9038 (Fdelete_other_windows_internal): Mark vars as initialized.
9039 Make sure 'resize_failed' is initialized.
9040 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9041 (resize_window_apply): Remove unused local.
9042 * window.h (delete_deletable_window): Remove decl.
9043
109e28d0 9044 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9045 (imagemagick_load_image): Fix pointer signedness problem by changing
9046 last arg from unsigned char * to char *. All uses changed.
9047 Also, fix a local for similar reasons.
9048 Remove unused locals. Remove locals to avoid shadowing.
9049 (fn_rsvg_handle_free): Remove; unused.
9050 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9051 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9052
3f754b86
PE
9053 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9054
2547adb1
CY
90552011-06-10 Chong Yidong <cyd@stupidchicken.com>
9056
9057 * image.c (gif_load): Fix omitted cast error introduced by
9058 2011-06-06 change.
9059
2c8e37d4
MR
90602011-06-10 Martin Rudalics <rudalics@gmx.at>
9061
9062 * window.h (resize_proportionally, orig_total_lines)
9063 (orig_top_line): Remove from window structure.
9064 (set_window_height, set_window_width, change_window_heights)
9065 (Fdelete_window): Remove prototypes.
9066 (resize_frame_windows): Remove duplicate declaration.
9067
440a42e3
EZ
90682011-06-10 Eli Zaretskii <eliz@gnu.org>
9069
9070 * window.h (resize_frame_windows, resize_window_check)
9071 (delete_deletable_window, resize_root_window)
9072 (resize_frame_windows): Declare prototypes.
9073
9074 * window.c (resize_window_apply): Make definition be "static" to
9075 match the prototype.
9076
562dd5e9
MR
90772011-06-10 Martin Rudalics <rudalics@gmx.at>
9078
9079 * window.c: Remove declarations of Qwindow_size_fixed,
9080 window_min_size_1, window_min_size_2, window_min_size,
9081 size_window, window_fixed_size_p, enlarge_window, delete_window.
9082 Remove static from declaration of Qdelete_window, it's
9083 temporarily needed by Fbury_buffer.
9084 (replace_window): Don't assign orig_top_line and
9085 orig_total_lines.
9086 (Fdelete_window, delete_window): Remove. Window deletion is
9087 handled by window.el.
640c8776
SM
9088 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9089 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9090 (Fdelete_other_windows): Remove. Deleting other windows is
9091 handled by window.el.
9092 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9093 handled in window.el.
9094 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9095 Window minimum sizes are handled in window.el.
9096 (shrink_windows, size_window, set_window_height)
9097 (set_window_width, change_window_heights, window_height)
9098 (window_width, CURBEG, CURSIZE, enlarge_window)
9099 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9100 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9101 handled in window.el.
9102 (make_dummy_parent): Rename to make_parent_window and give it a
9103 second argument horflag.
9104 (make_window): Don't set resize_proportionally any more.
9105 (Fsplit_window): Remove. Windows are split in window.el.
9106 (save_restore_action, save_restore_orig_size)
9107 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9108 Resize mini windows in window.el.
9109 (grow_mini_window, shrink_mini_window): Implement by calling
9110 Qresize_root_window_vertically, resize_window_check and
9111 resize_window_apply.
640c8776
SM
9112 (saved_window, Fset_window_configuration, save_window_save):
9113 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9114 resize_proportionally.
9115 (window_min_height, window_min_width): Move to window.el.
9116 (keys_of_window): Move bindings for delete-other-windows,
9117 split-window, delete-window and enlarge-window to window.el.
9118
9119 * buffer.c: Temporarily extern Qdelete_window.
9120 (Fbury_buffer): Temporarily call Qdelete_window instead of
9121 Fdelete_window (Fbury_buffer will move to window.el soon).
9122
9123 * frame.c (set_menu_bar_lines_1): Remove code handling
9124 orig_top_line and orig_total_lines.
9125
9126 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9127 set_window_height but set heights directly.
9128 (change_frame_size_1): Use resize_frame_windows.
9129
9130 * xdisp.c (init_xdisp): Don't use set_window_height but set
9131 heights directly.
9132
640c8776
SM
9133 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9134 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9135 run_window_configuration_change_hook.
9136
9137 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9138 instead of change_window_heights and run
9139 run_window_configuration_change_hook.
9140
1a13852e
MR
91412011-06-09 Martin Rudalics <rudalics@gmx.at>
9142
9143 * window.c (replace_window): Rename second argument REPLACEMENT to
9144 NEW. New third argument SETFLAG. Rewrite.
9145 (delete_window, make_dummy_parent): Call replace_window with
9146 third argument 1.
9147 (window_list_1): Move down in code.
9148 (run_window_configuration_change_hook): Move set_buffer part
9149 before select_frame_norecord part in order to unwind correctly.
9150 Rename count1 to count.
9151 (recombine_windows, delete_deletable_window, resize_root_window)
9152 (Fdelete_other_windows_internal)
9153 (Frun_window_configuration_change_hook, make_parent_window)
9154 (resize_window_check, resize_window_apply, Fresize_window_apply)
9155 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9156 (Fdelete_window_internal, Fresize_mini_window_internal):
9157 New functions.
1a13852e
MR
9158 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9159
f3d1777e
MR
91602011-06-08 Martin Rudalics <rudalics@gmx.at>
9161
496e208e
MR
9162 * window.h (window): Add some new members to window structure -
9163 normal_lines, normal_cols, new_total, new_normal, clone_number,
9164 splits, nest, prev_buffers, next_buffers.
9165 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9166 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9167
f3d1777e
MR
9168 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9169 Remove.
496e208e
MR
9170 (make_dummy_parent): Set new members of windows structure.
9171 (make_window): Move down in code. Handle new members of window
9172 structure.
9173 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9174 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9175 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9176 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9177 (Fset_window_next_buffers, Fset_window_clone_number):
9178 New functions.
496e208e
MR
9179 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9180 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9181 Doc-string fixes.
9182 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9183 Argument WINDOW can be now internal window too.
9184 (Fwindow_use_time): Move up in code.
9185 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9186 Rewrite doc-string.
9187 (Fset_window_configuration, saved_window)
9188 (Fcurrent_window_configuration, save_window_save): Handle new
9189 members of window structure.
b9e809c2
MR
9190 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9191 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9192 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9193 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9194 Qget_mru_window, Qresize_root_window,
9195 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9196 Qauto_buffer_name; staticpro them.
f3d1777e 9197
abde8f8c
MR
91982011-06-07 Martin Rudalics <rudalics@gmx.at>
9199
9200 * window.c (Fwindow_total_size, Fwindow_left_column)
9201 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9202 (Fwindow_list_1): New functions.
9203 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9204 (Fwindow_width, Fscroll_left, Fscroll_right):
9205 Use window_body_cols instead of window_box_text_cols.
9206 (delete_window, Fset_window_configuration):
9207 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9208 (delete_all_subwindows): Take a window as argument and not a
9209 structure. Rewrite.
190b47e6
MR
9210 (window_loop): Remove handling of GET_LRU_WINDOW and
9211 GET_LARGEST_WINDOW.
9212 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9213
9214 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9215 window_box_text_cols. delete_all_subwindows now takes a
9216 Lisp_Object as argument.
abde8f8c 9217
640c8776
SM
9218 * indent.c (compute_motion, Fcompute_motion):
9219 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9220
fa8a67e6
MR
9221 * frame.c (delete_frame): Call delete_all_subwindows with root
9222 window as argument.
9223
a54e3482
DC
92242011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9225
9226 * fns.c (Fputhash): Document return value.
9227
60002bf5
CY
92282011-06-06 Chong Yidong <cyd@stupidchicken.com>
9229
9230 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9231
0c671da6 92322011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9233
b862a52a 9234 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9235
be44ca6c
PE
9236 Check for overflow when converting integer to cons and back.
9237 * charset.c (Fdefine_charset_internal, Fdecode_char):
9238 Use cons_to_unsigned to catch overflow.
9239 (Fencode_char): Use INTEGER_TO_CONS.
9240 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9241 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9242 * data.c (long_to_cons, cons_to_long): Remove.
9243 (cons_to_unsigned, cons_to_signed): New functions.
9244 These signal an error for invalid or out-of-range values.
9245 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9246 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9247 * font.c (Ffont_variation_glyphs):
9248 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9249 * lisp.h: Include <intprops.h>.
9250 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9251 (cons_to_signed, cons_to_unsigned): New decls.
9252 (long_to_cons, cons_to_long): Remove decls.
9253 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9254 (Fprimitive_undo): Use CONS_TO_INTEGER.
9255 * xfns.c (Fx_window_property): Likewise.
9256 * xselect.c: Include <limits.h>.
9257 (x_own_selection, selection_data_to_lisp_data):
9258 Use INTEGER_TO_CONS.
9259 (x_handle_selection_request, x_handle_selection_clear)
9260 (x_get_foreign_selection, Fx_disown_selection_internal)
9261 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9262 (lisp_data_to_selection_data): Use cons_to_unsigned.
9263 (x_fill_property_data): Use cons_to_signed.
9264 Report values out of range.
9265
d1f3d2af
PE
9266 Check for buffer and string overflow more precisely.
9267 * buffer.h (BUF_BYTES_MAX): New macro.
9268 * lisp.h (STRING_BYTES_MAX): New macro.
9269 * alloc.c (Fmake_string):
9270 * character.c (string_escape_byte8):
9271 * coding.c (coding_alloc_by_realloc):
9272 * doprnt.c (doprnt):
9273 * editfns.c (Fformat):
9274 * eval.c (verror):
9275 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9276 since they may not be the same number.
9277 * editfns.c (Finsert_char):
9278 * fileio.c (Finsert_file_contents):
9279 Likewise for BUF_BYTES_MAX.
9280
dd52fcea
PE
9281 * image.c: Use ptrdiff_t, not int, for sizes.
9282 (slurp_file): Switch from int to ptrdiff_t.
9283 All uses changed.
9284 (slurp_file): Check that file size fits in both size_t (for
9285 malloc) and ptrdiff_t (for sanity and safety).
9286
7f9bbdbb
PE
9287 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9288 if b->modtime has its maximal value.
9289
dfe18f82
PE
9290 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9291
84acfcf0
PE
9292 Don't assume time_t can fit into int.
9293 * buffer.h (struct buffer.modtime): Now time_t, not int.
9294 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9295 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9296
ccd9a01a
PE
9297 Minor fixes for signed vs unsigned integers.
9298 * character.h (MAYBE_UNIFY_CHAR):
9299 * charset.c (maybe_unify_char):
9300 * keyboard.c (read_char, reorder_modifiers):
9301 XINT -> XFASTINT, since the integer must be nonnegative.
9302 * ftfont.c (ftfont_spec_pattern):
9303 * keymap.c (access_keymap, silly_event_symbol_error):
9304 XUINT -> XFASTINT, since the integer must be nonnegative.
9305 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9306 since it makes no difference and we prefer signed.
9307 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9308 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9309 nonnegative.
9310
d6d100dd
SM
93112011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9312
9313 * window.h (Fwindow_frame): Declare.
9314
2b6148e4
PE
93152011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9316
9317 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9318 (SPARE_MEMORY): Always define.
9319 (LARGE_REQUEST): Remove.
9320 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9321
f230ecc9
MR
93222011-06-06 Martin Rudalics <rudalics@gmx.at>
9323
727e958e
MR
9324 * lisp.h: Move EXFUNS for Fframe_root_window,
9325 Fframe_first_window and Fset_frame_selected_window to window.h.
9326
9327 * window.h: Move EXFUNS for Fframe_root_window,
9328 Fframe_first_window and Fset_frame_selected_window here from
9329 lisp.h.
9330
9331 * frame.c (Fwindow_frame, Fframe_first_window)
9332 (Fframe_root_window, Fframe_selected_window)
9333 (Fset_frame_selected_window): Move to window.c.
9334 (Factive_minibuffer_window): Move to minibuf.c.
9335 (Fother_visible_frames_p): New function.
9336
9337 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9338
f230ecc9
MR
9339 * window.c (decode_window, decode_any_window): Move up in code.
9340 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9341 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9342 (Fwindow_buffer): Move up and rewrite doc-string.
9343 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9344 (Fwindow_prev): New functions.
727e958e
MR
9345 (Fwindow_frame): Move here from frame.c. Accept any window as
9346 argument.
9347 (Fframe_root_window, Fframe_first_window)
9348 (Fframe_selected_window): Move here from frame.c. Accept frame
9349 or arbitrary window as argument. Update doc-strings.
9350 (Fminibuffer_window): Move up in code.
9351 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9352 (Fset_frame_selected_window): Move here from frame.c.
9353 Marginal rewrite.
727e958e
MR
9354 (Fselected_window, select_window, Fselect_window): Move up in
9355 code. Minor doc-string fixes.
f230ecc9 9356
4d09bcf6
PE
93572011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9358
9359 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9360 Do not assume that spare memory exists; that assumption is valid
9361 only if SYSTEM_MALLOC.
9362 (LARGE_REQUEST): New macro, so that the issue of large requests
9363 is separated from the issue of spare memory.
9364
810928a2
AS
93652011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9366
172418ad
AS
9367 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9368 format. (Bug#8806)
9369
43f862f7
AS
9370 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9371
810928a2
AS
9372 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9373 before statements.
9374
a059fe24
JD
93752011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9376
9377 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9378
9379 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9380
9381 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9382 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9383
989bf368
JB
93842011-06-05 Juanma Barranquero <lekktu@gmail.com>
9385
9386 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9387
4b80f674
CY
93882011-06-04 Chong Yidong <cyd@stupidchicken.com>
9389
9390 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9391 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9392 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9393 New error handlers.
4b80f674
CY
9394 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9395 Obey Vx_select_enable_clipboard_manager. Catch errors in
9396 x_clipboard_manager_save (Bug#8779).
9397 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9398 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9399
99a33b77 94002011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9401
9402 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9403
99a33b77 94042011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9405
9406 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9407 in the current matrix if keep_current_p is non-zero.
9408
8264569d
EZ
94092011-06-04 Eli Zaretskii <eliz@gnu.org>
9410
9411 * bidi.c (bidi_level_of_next_char): Fix last change.
9412
57f97249
EZ
94132011-06-03 Eli Zaretskii <eliz@gnu.org>
9414
fec2107c 9415 Support bidi reordering of text covered by display properties.
57f97249 9416
fec2107c
EZ
9417 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9418 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9419 (bidi_cache_search, bidi_cache_iterator_state)
9420 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9421 (bidi_level_of_next_char, bidi_move_to_visually_next):
9422 Support character positions inside a run of characters covered by a
fec2107c
EZ
9423 display string.
9424 (bidi_paragraph_init, bidi_resolve_explicit_1)
9425 (bidi_level_of_next_char): Call bidi_fetch_char and
9426 bidi_fetch_char_advance instead of FETCH_CHAR and
9427 FETCH_CHAR_ADVANCE.
9428 (bidi_init_it): Initialize new members.
9429 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9430 definitions.
9431 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9432 instead of using explicit *_CHAR codes.
d6d100dd
SM
9433 (bidi_resolve_explicit, bidi_resolve_weak):
9434 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9435 bidirectional text is supported only in multibyte buffers.
9436 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9437 it to initialize the frame_window_p member of struct bidi_it.
9438 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9439 (bidi_resolve_explicit, bidi_resolve_weak)
9440 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9441 bidi_it->nchars is non-positive.
9442 (bidi_level_of_next_char): Don't try to lookup the cache for the
9443 next/previous character if nothing is cached there yet, or if we
9444 were just reseat()'ed to a new position.
c40e2fb2 9445
0e14fe90
EZ
9446 * xdisp.c (set_cursor_from_row): Set start and stop points
9447 according to the row's direction when priming the loop that looks
9448 for the glyph on which to display cursor.
9449 (single_display_spec_intangible_p): Function deleted.
9450 (display_prop_intangible_p): Reimplement to call
9451 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9452 Accept 3 additional arguments needed by handle_display_spec.
9453 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9454 values: lists, `(when COND...)' forms, etc.
9455 (single_display_spec_string_p): Support property values that are
9456 lists with the argument STRING its top-level element.
9457 (display_prop_string_p): Fix the condition for processing a
9458 property that is a list to be consistent with handle_display_spec.
fec2107c 9459 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9460 last portion of handle_display_prop.
9461 (compute_display_string_pos): Accept additional argument
9462 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9463 value of a `display' property is a "replacing spec".
9464 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9465 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9466 the display property, but just return a value indicating whether
9467 the display property will replace the characters it covers.
9468 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9469 frame_window_p members of struct bidi_it.
d6d100dd
SM
9470 (compute_display_string_pos, compute_display_string_end):
9471 New functions.
fec2107c
EZ
9472 (push_it): Accept second argument POSITION, where pop_it should
9473 jump to continue iteration.
9474 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9475
fec2107c
EZ
9476 * keyboard.c (adjust_point_for_property): Adjust the call to
9477 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9478
9479 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9480 (bidi_init_it): Update prototypes.
9481 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9482 (compute_display_string_pos, compute_display_string_end):
9483 Declare prototypes.
fec2107c
EZ
9484 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9485 EMACS_INT.
fc6f18ce 9486
40087514 94872011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9488
57f53182
PE
9489 Malloc failure behavior now depends on size of allocation.
9490 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9491 * lisp.h: Change signatures accordingly.
9492 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9493 All callers changed. (Bug#8762)
9494
9495 * gnutls.c: Use Emacs's memory allocators.
9496 Without this change, the gnutls library would invoke malloc etc.
9497 directly, which causes problems on non-SYNC_INPUT hosts, and which
9498 runs afoul of improving memory_full behavior. (Bug#8761)
9499 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9500 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9501 xfree instead of the default malloc, realloc, free.
9502 (Fgnutls_boot): No need to check for memory allocation failure,
9503 since xmalloc does that for us.
9504
ac32cd99 9505 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9506 * category.c (hash_get_category_set):
9507 * ccl.c (ccl_driver):
9508 * charset.c (Fdefine_charset_internal):
9509 * charset.h (struct charset.hash_index):
9510 * composite.c (get_composition_id, gstring_lookup_cache)
9511 (composition_gstring_put_cache):
9512 * composite.h (struct composition.hash_index):
9513 * dispextern.h (struct image.hash):
9514 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9515 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9516 (hashfn_equal, hashfn_user_defined, make_hash_table)
9517 (maybe_resize_hash_table, hash_lookup, hash_put)
9518 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9519 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9520 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9521 * image.c (make_image, search_image_cache, lookup_image)
9522 (xpm_put_color_table_h):
9523 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9524 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9525 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9526 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9527 * alloc.c (allocate_vectorlike):
9528 Check for overflow in vector size calculations.
9529 * ccl.c (ccl_driver):
9530 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9531 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9532 need to be updated by these changes.
40087514
PE
9533 * fns.c (make_hash_table, maybe_resize_hash_table):
9534 Check for integer overflow with large hash tables.
0de4bb68
PE
9535 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9536 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9537 (SXHASH_REDUCE): New macro.
9538 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9539 Use it instead of discarding useful hash info with large hash values.
9540 (sxhash_float): New function.
9541 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9542 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9543 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9544 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9545 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9546 Adjust signatures to match updated version of code.
9547 (consing_since_gc): Now EMACS_INT, since a single hash table can
9548 use more than INT_MAX bytes.
9549
698d32e2
DN
95502011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9551
9552 Make it possible to build with GCC-4.6+ -O2 -flto.
9553
9554 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9555
fd6fa53f
SM
95562011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9557
9558 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9559 Call minibuffer-inactive-mode.
9560
864db017
JB
95612011-05-31 Juanma Barranquero <lekktu@gmail.com>
9562
9563 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9564 Update dependencies.
9565
2ad0baf4
DN
95662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9567
9568 * data.c (init_data): Remove code for UTS, this system is not
9569 supported anymore.
9570
4fcc2638
DN
95712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9572
9573 Don't force ./temacs to start in terminal mode.
9574
9575 * frame.c (make_initial_frame): Initialize faces in all cases, not
9576 only when CANNOT_DUMP is defined.
9577 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9578
c56e0fd5
DN
95792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9580
9581 * dispnew.c (add_window_display_history): Use const for the string
9582 pointer. Remove declaration, not needed.
9583
333d54da 95842011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9585
55d4c1b2 9586 Use 'inline', not 'INLINE'.
333d54da 9587 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9588 * alloc.c, fontset.c (INLINE): Remove.
9589 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9590 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9591 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9592 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9593 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9594
738db178
DN
95952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9596
9597 Make it possible to run ./temacs.
9598
9599 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9600 syms_of_callproc does the same thing. Remove test for
9601 "initialized", do it in the caller.
9602 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9603
620c53a6
SM
96042011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9605
9606 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9607 (read_minibuf): Use get_minibuffer.
9608 (syms_of_minibuf): Use DEFSYM.
9609 (Qmetadata): New var.
9610 * data.c (Qbuffer): Don't make it static.
9611 (syms_of_data): Use DEFSYM.
9612
e003a292
PE
96132011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9614
9615 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9616 (CCL_CODE_MIN): New macro.
9617
ed008a6d
PE
96182011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9619
3687c2ef
PE
9620 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9621
ed008a6d
PE
9622 * eval.c (Qdebug): Now static.
9623 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9624 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9625 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9626
d66c4c7c
CY
96272011-05-29 Chong Yidong <cyd@stupidchicken.com>
9628
9629 * image.c: Various fixes to ImageMagick code comments.
9630 (Fimagemagick_types): Doc fix.
9631
5fbc2025
PE
96322011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9633
0196f88a
PE
9634 Minor fixes prompted by GCC 4.6.0 warnings.
9635
9636 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9637
5fbc2025
PE
9638 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9639 (x_clipboard_manager_save_all): Move extern decl to ...
9640 * xterm.h: ... here, so that it can be checked for consistency.
9641
1dd3c2d9
CY
96422011-05-29 Chong Yidong <cyd@stupidchicken.com>
9643
9644 * xselect.c (x_clipboard_manager_save_frame)
9645 (x_clipboard_manager_save_all): New functions.
9646 (Fx_clipboard_manager_save): Lisp function deleted.
9647
9648 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9649 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9650
9651 * xterm.h: Update prototype.
9652
5ba6571d
WX
96532011-05-28 William Xu <william.xwl@gmail.com>
9654
9655 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9656 exiting (Bug#8239).
9657
3eaff834
JM
96582011-05-28 Jim Meyering <meyering@redhat.com>
9659
e1900994 9660 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9661 * fns.c (to_uchar): Define.
9662 (crypto_hash_function): Use it to convert some newly-signed
9663 variables to unsigned, to avoid sign-extension bugs. For example,
9664 without this change, (md5 "truc") would evaluate to
9665 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9666 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9667 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9668
0f6990a7
PE
96692011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9670
9671 Integer overflow fixes.
c8a9ca5a 9672
08686060
PE
9673 * dbusbind.c: Serial number integer overflow fixes.
9674 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9675 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9676 to hold a serial number that is too large for a fixnum.
9677 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9678 Check for serial numbers out of range. Decode any serial number
59568bf0 9679 that was so large that it became a float. (Bug#8722)
08686060 9680
2d1fc3c7
PE
9681 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9682 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9683 Use XFASTINT rather than XUINT when numbers are nonnegative.
9684 (xd_append_arg, Fdbus_method_return_internal):
9685 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9686 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9687 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9688 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9689 (Bug#8722)
2d1fc3c7 9690
c8a9ca5a
PE
9691 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9692
519e1d69
PE
9693 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9694
6df6ae42 9695 ccl: Add integer overflow checks.
30569699
PE
9696 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9697 (IN_INT_RANGE): New macros.
9698 (ccl_driver): Use them to check for integer overflow when
9699 decoding a CCL program. Many of the new checks are whether XINT (x)
9700 fits in int; it doesn't always, on 64-bit hosts. The new version
9701 doesn't catch all possible integer overflows, but it's an
847044ea 9702 improvement. (Bug#8719)
30569699 9703
c11285dc
PE
9704 * alloc.c (make_event_array): Use XINT, not XUINT.
9705 There's no need for unsigned here.
9706
fdccd48e
PE
9707 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9708 This follows up to the 2011-05-06 change that substituted uintptr_t
9709 for EMACS_INT. This case wasn't caught back then.
9710
37910ab2
PE
9711 Rework Fformat to avoid integer overflow issues.
9712 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9713 now (part of C89). Include <verify.h>.
9714 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9715 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9716 (Fformat): Avoid the prepass trying to compute sizes; it was only
9717 approximate and thus did not catch overflow reliably. Instead, walk
9718 through the format just once, formatting and computing sizes as we go,
9719 checking for integer overflow at every step, and allocating a larger
9720 buffer as needed. Keep track separately whether the format is
9721 multibyte. Keep only the most-recently calculated precision, rather
9722 than them all. Record whether each argument has been converted to
9723 string. Use EMACS_INT, not int, for byte and char and arg counts.
9724 Support field widths and precisions larger than INT_MAX. Avoid
9725 sprintf's undefined behavior with conversion specifications such as %#d
9726 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9727 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9728 formatting out-of-range floating point numbers with int
9173deec 9729 formats. (Bug#8668)
37910ab2 9730
2e6578fb
PE
9731 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9732
0ae6bdee
PE
9733 * data.c: Avoid integer truncation in expressions involving floats.
9734 * data.c: Include <intprops.h>.
9735 (arith_driver): When there's an integer overflow in an expression
9736 involving floating point, convert the integers to floating point
9737 so that the resulting value does not suffer from catastrophic
9738 integer truncation. For example, on a 64-bit host (* 4
9739 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9740 Do not rely on undefined behavior after integer overflow.
9741
de883a70
PE
9742 merge count_size_as_multibyte, parse_str_to_multibyte
9743 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9744 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9745 Check for integer overflow.
9746 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9747 since it's now a duplicate of the other. This is more of
9748 a character than a buffer op, so better that it's in character.c.
9749 * fns.c, print.c: Adjust to above changes.
9750
2ff916cb
PE
97512011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9752
9753 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9754
f1b54466
PE
97552011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9756
fb1ac845
PE
9757 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9758 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9759 (x_clipboard_manager_save): Now static.
9760 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9761
f1b54466
PE
9762 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9763 (crypto_hash_function): Now static.
9764 Fix pointer signedness problems. Avoid unnecessary initializations.
9765
a9f737ee
CY
97662011-05-27 Chong Yidong <cyd@stupidchicken.com>
9767
9768 * termhooks.h (Vselection_alist): Make it terminal-local.
9769
9770 * terminal.c (create_terminal): Initialize it.
9771
9772 * xselect.c: Support for clipboard managers.
9773 (Vselection_alist): Move to termhooks.h as terminal-local var.
9774 (LOCAL_SELECTION): New macro.
9775 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9776 (symbol_to_x_atom): Remove gratuitous arg.
9777 (x_handle_selection_request, lisp_data_to_selection_data)
9778 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9779 (x_own_selection, x_get_local_selection, x_convert_selection):
9780 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9781 (some_frame_on_display): Delete unused function.
9782 (Fx_own_selection_internal, Fx_get_selection_internal)
9783 (Fx_disown_selection_internal, Fx_selection_owner_p)
9784 (Fx_selection_exists_p): New optional frame arg.
9785 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9786 (x_handle_selection_clear): Don't treat other terminals with the
9787 same keyboard specially. Use the terminal-local Vselection_alist.
9788 (x_clear_frame_selections): Use Frun_hook_with_args.
9789
9790 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9791
9792 * xterm.h: Add support for those atoms.
9793
e067f0c1
CY
97942011-05-26 Chong Yidong <cyd@stupidchicken.com>
9795
9796 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9797 (converted_selections, conversion_fail_tag): New global variables.
9798 (x_selection_request_lisp_error): Free the above.
9799 (x_get_local_selection): Remove unnecessary code.
9800 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9801 of converted selections stored in converted_selections.
9802 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9803 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9804 (x_convert_selection): New function.
9805 (x_handle_selection_event): Simplify.
9806 (x_get_foreign_selection): Don't ignore incoming requests while
9807 waiting for an answer; this will fail when we implement
9808 SAVE_TARGETS, and seems unnecessary anyway.
9809 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9810 (Vx_sent_selection_functions): Doc fix.
9811
0f4aebc0
LL
98122011-05-26 Leo Liu <sdl.web@gmail.com>
9813
9814 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9815
e61124cd
YM
98162011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9817
9818 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9819
9820 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9821 for fringe update if it has periodic bitmap.
ac389d0c 9822 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9823 and fringe_bitmap_periodic_p.
9824
9825 * fringe.c (get_fringe_bitmap_data): New function.
9826 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9827 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9828 row. Mark glyph row for fringe update if periodicity changed.
9829
9830 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9831 for fringe update unless it has periodic bitmap.
9832
f16d9837
KH
98332011-05-25 Kenichi Handa <handa@m17n.org>
9834
9835 * xdisp.c (get_next_display_element): Set correct it->face_id for
9836 a static composition.
9837
e1b90ef6
LL
98382011-05-24 Leo Liu <sdl.web@gmail.com>
9839
9840 * deps.mk (fns.o):
9841 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9842
9843 * fns.c (crypto_hash_function, Fsha1): New function.
9844 (Fmd5): Use crypto_hash_function.
9845 (syms_of_fns): Add Ssha1.
9846
7400048f
PE
98472011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9848
9849 * gnutls.c: Remove unused macros.
9850 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9851 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9852 Remove macros that are defined and never used.
9853 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9854
abb71cf4
CY
98552011-05-22 Chong Yidong <cyd@stupidchicken.com>
9856
9857 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9858 (Fx_get_selection_internal): Minor cleanup.
9859 (Fx_own_selection_internal): Rename arguments for consistency with
9860 select.el.
9861
6307db39
PE
98622011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9863
9864 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9865
f3d4e0a4
CY
98662011-05-22 Chong Yidong <cyd@stupidchicken.com>
9867
9868 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9869
4d8ade89
YM
98702011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9871
9872 * dispnew.c (scrolling_window): Don't exclude the case that the
9873 last enabled row in the desired matrix touches the bottom boundary.
9874
32078c8d
GM
98752011-05-21 Glenn Morris <rgm@gnu.org>
9876
9877 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9878 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9879 and add some more files.
32078c8d 9880
7285dc67
EZ
98812011-05-20 Eli Zaretskii <eliz@gnu.org>
9882
9883 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9884 report_file_error introduced by the change from 2011-05-07.
9885
89d1bd22
PE
98862011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9887
9888 * systime.h (Time): Define only if emacs is defined.
9889 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9890 where the include path doesn't have X11/X.h by default. See
9891 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9892
cd394be1 98932011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9894
9895 * composite.c (find_automatic_composition): Fix previous change.
9896
b9704ad9
GM
98972011-05-20 Glenn Morris <rgm@gnu.org>
9898
9899 * lisp.mk: New file, split from Makefile.in.
9900 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9901 (shortlisp): Remove.
9902 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9903
4a720484
GM
99042011-05-19 Glenn Morris <rgm@gnu.org>
9905
9906 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9907 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9908 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9909 (lisp): Set the order to that of loadup.el.
9910 (shortlisp): Make it a copy of $lisp.
9911 (SOME_MACHINE_LISP): Remove.
9912 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9913 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9914
a28d4396
KH
99152011-05-18 Kenichi Handa <handa@m17n.org>
9916
9917 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9918 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9919 (find_automatic_composition): Mostly rewrite for efficiency.
9920
a2b1fa8e
JB
99212011-05-18 Juanma Barranquero <lekktu@gmail.com>
9922
9923 * makefile.w32-in: Update dependencies.
9924
8e1f5610
CS
99252011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9926
9927 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9928 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9929
7025ee00 99302011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9931
cdfa6eab
PE
9932 Fix some integer overflow issues, such as string length overflow.
9933
06d6db33
PE
9934 * insdel.c (count_size_as_multibyte): Check for string overflow.
9935
2b4560a8
PE
9936 * character.c (lisp_string_width): Check for string overflow.
9937 Use EMACS_INT, not int, for string indexes and lengths; in
9938 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9939 the resulting string length overflows an EMACS_INT; instead,
9940 report a string overflow if no precision given. When checking for
9941 precision exhaustion, use a check that cannot possibly have
9942 integer overflow. (Bug#8675)
9943 * character.h (lisp_string_width): Adjust to new signature.
9944
cb93f9be
PE
9945 * alloc.c (string_overflow): New function.
9946 (Fmake_string): Use it. This doesn't change behavior, but saves
9947 a few bytes and will simplify future changes.
9948 * character.c (string_escape_byte8): Likewise.
9949 * lisp.h (string_overflow): New decl.
9950
1a1f3366
PE
9951 Fixups, following up to the user-interface timestamp change.
9952 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9953 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9954 * msdos.c (mouse_get_pos): Likewise.
9955 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9956 * w32gui.h (Time): Define by including "systime.h" rather than by
9957 declaring it ourselves. (Bug#8664)
9958
d4e3e4d3
PE
9959 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9960 * image.c (clear_image_cache): Likewise.
9961
f6a24d19
PE
9962 * term.c (term_mouse_position): Don't assume time_t wraparound.
9963
08dc5ae6
PE
9964 Be more systematic about user-interface timestamps.
9965 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9966 and sometimes 'EMACS_UINT', to represent these timestamps.
9967 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9968 This makes the code easier to follow, and makes it easier to catch
9969 integer overflow bugs such as Bug#8664.
9970 * frame.c (Fmouse_position, Fmouse_pixel_position):
9971 Use Time, not unsigned long, for user-interface timestamps.
9972 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9973 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9974 * keyboard.h (last_event_timestamp): Likewise.
9975 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9976 * menu.h (xmenu_show): Likewise.
9977 * term.c (term_mouse_position): Likewise.
9978 * termhooks.h (struct input_event.timestamp): Likewise.
9979 (struct terminal.mouse_position_hook): Likewise.
9980 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9981 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9982 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9983 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9984 what it was before.
9985 * menu.h, termhooks.h: Include "systime.h", for Time.
9986
8e55734a
PE
9987 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9988 Don't assume that the difference between two unsigned long values
9989 can fit into an integer. At this point, we know button_down_time
9990 <= event->timestamp, so the difference must be nonnegative, so
9991 there's no need to cast the result if double-click-time is
9992 nonnegative, as it should be; check that it's nonnegative, just in
9993 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9994 apart (about 25 days). (Bug#8664)
8e55734a 9995
841f1b75 9996 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9997 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9998
3e26f69c
PE
9999 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10000 that always fit in int. Use a sentinel instead of a counter, to
10001 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10002 * frame.h (struct frame): Use int for menu_bar_items_used
10003 instead of EMACS_INT, since it always fits in int.
3e26f69c 10004
5cc152c0
PE
10005 * menu.c (grow_menu_items): Check for int overflow.
10006
d89eb65e
PE
10007 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10008
5235bd3e
PE
10009 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10010 Before, the code was not consistent. These values cannot exceed
10011 2**31 - 1 so there's no need to make them unsigned.
10012 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10013 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10014 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10015 as modifiers.
10016 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10017
bc827e23
PE
10018 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10019 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10020 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10021 presumably because the widths might not match.
10022
78eb494e
PE
10023 * window.c (size_window): Avoid needless test at loop start.
10024
04f2d78b
CB
100252011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10026
10027 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10028
d2fc7e3d 100292011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10030
10031 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10032
d2fc7e3d 100332011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10034
10035 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10036 `width' to `bar_area_x' and `bar_area_width', respectively.
10037 (x_scroll_run): Take account of fringe background extension.
10038
04f2d78b
CB
10039 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10040 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10041 `bar_area_width', respectively.
10042 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10043 background extension.
10044
79b70037
GM
100452011-05-10 Jim Meyering <meyering@redhat.com>
10046
10047 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10048
2f142cc5
JB
100492011-05-10 Juanma Barranquero <lekktu@gmail.com>
10050
10051 * image.c (Finit_image_library): Return t for built-in image types,
10052 like pbm and xbm. (Bug#8640)
10053
57679c86
AS
100542011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10055
10056 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10057
888c9e86
EZ
100582011-05-07 Eli Zaretskii <eliz@gnu.org>
10059
b0512a1d
EZ
10060 * w32console.c (Fset_screen_color): Doc fix.
10061 (Fget_screen_color): New function.
10062 (syms_of_ntterm): Defsubr it.
10063
7285dc67
EZ
10064 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10065 unlink the temporary file if Fcall_process didn't create it in the
10066 first place.
10067 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10068 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10069 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10070 cue to call_process_cleanup not to close that handle.
10071
4d3fcc8e
BK
100722011-05-07 Ben Key <bkey76@gmail.com>
10073
10074 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10075 one of two shell specific rules, either bootstrap-temacs-CMD or
10076 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10077 to the previous implementation of the bootstrap-temacs rule.
10078 The bootstrap-temacs-CMD rule is similar to the previous
10079 implementation of the bootstrap-temacs rule except that it
10080 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10081 variable.
10082
10083 These changes, along with some changes to nt/configure.bat,
10084 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10085 earlier fix to add support for --cflags and --ldflags options
10086 that include quotes so that it works whether make uses cmd or
10087 sh as the shell.
10088
b4289b64
MA
100892011-05-06 Michael Albinus <michael.albinus@gmx.de>
10090
10091 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10092 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10093 is a constant.
10094 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10095 a string. Handle both cases.
10096 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10097 (Fdbus_register_method): Use Qinvalid_function.
10098
af4c0e28
JB
100992011-05-06 Juanma Barranquero <lekktu@gmail.com>
10100
10101 * makefile.w32-in: Update dependencies.
10102 (LISP_H): Add inttypes.h and stdin.h.
10103 (PROCESS_H): Add unistd.h.
10104
c51453d9
EZ
101052011-05-06 Eli Zaretskii <eliz@gnu.org>
10106
10107 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10108 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10109
8ff0ac3c 101102011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10111
4c4b566b
PE
10112 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10113
aab2b9b5
PE
10114 * term.c (vfatal): Remove stray call to va_end.
10115 It's not needed and the C Standard doesn't allow it here anyway.
10116
c378da0b
PE
10117 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10118 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10119
288b08c7
PE
10120 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10121 bytes.
10122
e3601888
PE
10123 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10124
db6c0e74
PE
10125 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10126
dd5963ea
PE
10127 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10128
88c9450f
PE
10129 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10130
2f9442b8
PE
10131 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10132
c032b5f8
PE
10133 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10134 * charset.c (Fdefine_charset_internal): Don't initialize
10135 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10136 32-bit int (Bug#8600).
a108c10b
PE
10137
10138 * lread.c (read_integer): Be more consistent with string-to-number.
10139 Use string_to_number to do the actual conversion; this avoids
10140 rounding errors and fixes some other screwups. Without this fix,
10141 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10142 (digit_to_number): Move earlier, for benefit of read_integer.
10143 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10144 not a digit in any supported base. (Bug#8602)
a108c10b 10145
ad5f9eea
PE
10146 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10147
aec1708a
PE
10148 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10149 to match comment at start of function. This also removes a
10150 GCC warning about overflow in a 32+64-bit port.
10151
47be4ab5
PE
10152 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10153
371cac43
PE
10154 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10155 Reported by Stefan Monnier in
10156 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10157 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10158 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10159
d01a7826
PE
10160 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10161 (EMACS_UINTPTR): Likewise, with uintptr_t.
10162
7fd47d5c
PE
10163 * lisp.h: Prefer 64-bit EMACS_INT if available.
10164 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10165 on 32-bit hosts that have 64-bit int, so that they can access
10166 large files.
122b0c86
PE
10167 However, temporarily disable this change unless the temporary
10168 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10169
8727937b
PE
10170 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10171
8ac068ac
PE
10172 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10173 This removes an assumption that EMACS_INT and long are the same
10174 width as pointers. The assumption is true for Emacs porting targets
10175 now, but we want to make other targets possible.
10176 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10177 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10178 In the rest of the code, change types of integers that hold casted
10179 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10180 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10181 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10182 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10183 No need to cast type when ORing.
10184 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10185 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10186 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10187 assume EMACS_INT is the same width as char *.
10188 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10189 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10190 Remove no-longer-needed casts.
10191 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10192 (xg_tool_bar_help_callback, xg_make_tool_item):
10193 Use EMACS_INTPTR to hold an integer
10194 that will be cast to void *; this can avoid a GCC warning
10195 if EMACS_INT is not the same width as void *.
10196 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10197 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10198 (current_message_1, set_message_1):
10199 Use a local to convert to proper width without a cast.
10200 * xmenu.c (dialog_selection_callback): Likewise.
10201
ede49d71
PE
10202 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10203 Also, don't assume VALBITS / RAND_BITS is less than 5,
10204 and don't rely on undefined behavior when shifting a 1 left into
10205 the sign bit.
10206 * lisp.h (get_random): Change signature to match.
10207
2f30ecd0
PE
10208 * lread.c (hash_string): Use size_t, not int, for hash computation.
10209 Normally we prefer signed values; but hashing is special, because
10210 it's better to use unsigned division on hash table sizes so that
10211 the remainder is nonnegative. Also, size_t is the natural width
10212 for hashing into memory. The previous code used 'int', which doesn't
10213 retain enough info to hash well into very large tables.
10214 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10215
2a866e7b
PE
10216 * dbusbind.c: Don't possibly lose pointer info when converting.
10217 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10218 Use XPNTR rather than XHASH, so that the high-order bits of
10219 the pointer aren't lost when converting through void *.
10220
51639eac
PE
10221 * eval.c (Fautoload): Don't double-shift a pointer.
10222
92394119
PE
10223 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10224
dbdb9a7c
JB
102252011-05-06 Juanma Barranquero <lekktu@gmail.com>
10226
10227 * gnutls.c (DEF_GNUTLS_FN):
10228 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10229
db7a0b4f
AS
102302011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10231
10232 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10233 marker. (Bug#8610)
10234
cd394be1 102352011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10236
10237 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10238 New version that can reserve upto 2GB of heap space.
10239
f7ff1b0f 102402011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10241
10242 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10243
639c109b
TZ
102442011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10245
10246 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10247 `gnutls_certificate_set_x509_key_file'.
10248
d2127135
JB
102492011-05-05 Juanma Barranquero <lekktu@gmail.com>
10250
10251 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10252 Update dependencies.
10253
e968f4f3
JB
102542011-05-04 Juanma Barranquero <lekktu@gmail.com>
10255
10256 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10257 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10258 Remove unused parameter `fildes'.
10259 * process.c (read_process_output, send_process): Don't pass it.
10260
84d358f0
JB
102612011-05-04 Juanma Barranquero <lekktu@gmail.com>
10262
10263 Fix previous change: the library cache is defined in w32.c.
10264 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10265 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10266
0898ca10
JB
102672011-05-04 Juanma Barranquero <lekktu@gmail.com>
10268
10269 Implement dynamic loading of GnuTLS on Windows.
10270
10271 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10272 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10273 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10274 Declare.
10275
10276 * gnutls.c (Qgnutls_dll): Define.
10277 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10278 (gnutls_*): Declare function pointers.
10279 (init_gnutls_functions): New function to initialize function pointers.
10280 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10281 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10282 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10283 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10284 (emacs_gnutls_write, emacs_gnutls_read)
10285 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10286 (Fgnutls_available_p): New function.
10287 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10288 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10289 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10290
10291 * image.c: Include w32.h.
10292 (Vimage_type_cache): Delete.
10293 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10294 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10295 (w32_delayed_load): Move to w32.c.
10296
10297 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10298
10299 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10300 (w32_delayed_load): Move from image.c. When loading a library, record
10301 its filename in the :loaded-from property of the library id.
10302 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10303 Initialize and staticpro them.
10304 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10305
10306 * process.c: Include lisp.h before w32.h, not after.
10307 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10308 instead of gnutls_record_check_pending.
10309
10310 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10311
ff4de4aa
TZ
103122011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10313
10314 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10315 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10316 as passed in.
10317
abe95abb
JD
103182011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10319
10320 * xterm.c (x_set_frame_alpha): Do not set property on anything
10321 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10322
e16e55d4
JB
103232011-05-02 Juanma Barranquero <lekktu@gmail.com>
10324
10325 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10326
bafcf6a5
JB
103272011-05-02 Juanma Barranquero <lekktu@gmail.com>
10328
10329 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10330 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10331 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10332 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10333 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10334 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10335 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10336 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10337 (Qgnutls_bootprop_callbacks_verify): Make static.
10338
e7a6747f
AS
103392011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10340
19ed11ba
AS
10341 * callproc.c: Indentation fixup.
10342
e7a6747f 10343 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10344 (wait_for_termination, interruptible_wait_for_termination):
10345 Move after wait_for_termination_1.
e7a6747f 10346
1ef14cb4
LMI
103472011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10348
10349 * sysdep.c (interruptible_wait_for_termination): New function
10350 which is like wait_for_termination, but allows keyboard
10351 interruptions.
10352
10353 * callproc.c (Fcall_process): Add (:file "file") as an option for
10354 the STDOUT buffer.
10355 (Fcall_process_region): Ditto.
10356
330d880c
EZ
103572011-04-30 Eli Zaretskii <eliz@gnu.org>
10358
8db90b73
EZ
10359 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10360 rather than `XVECTOR (FOO)->size'.
10361
330d880c
EZ
10362 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10363 inttypes.h, as a gnulib replacement is used if it not available in
10364 system headers.
10365
15cbd324
EZ
103662011-04-21 Eli Zaretskii <eliz@gnu.org>
10367
10368 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10369 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10370 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10371
10372 * coding.c (coding_alloc_by_realloc): Error out if destination
10373 will grow beyond MOST_POSITIVE_FIXNUM.
10374 (decode_coding_emacs_mule): Abort if there isn't enough place in
10375 charbuf for the composition carryover bytes. Reserve an extra
10376 space for up to 2 characters produced in a loop.
10377 (decode_coding_iso_2022): Abort if there isn't enough place in
10378 charbuf for the composition carryover bytes.
10379
103802011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10381
ae940cca
EZ
10382 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10383 aborting when %lld or %lll format is passed.
10384 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10385 %llo or %llx format is passed. (Bug#8545)
10386
03ab8921
EZ
10387 * window.c (window_scroll_line_based): Use a marker instead of
10388 simple variables to record original value of point. (Bug#7952)
10389
afda1437
EZ
10390 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10391 produced by %s or %c overflows available buffer space. (Bug#8545)
10392
f76dee0c
PE
103932011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10394
10395 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10396 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10397
fdc5744d
JB
103982011-04-28 Juanma Barranquero <lekktu@gmail.com>
10399
10400 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10401
638f053a
JB
104022011-04-28 Juanma Barranquero <lekktu@gmail.com>
10403
10404 * keyboard.c (Qdelayed_warnings_hook): Define.
10405 (command_loop_1): Run `delayed-warnings-hook'
10406 if Vdelayed_warnings_list is non-nil.
10407 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10408 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10409
d178f871
EZ
104102011-04-28 Eli Zaretskii <eliz@gnu.org>
10411
10412 * doprnt.c (doprnt): Don't return value smaller than the buffer
10413 size if the message was truncated. (Bug#8545).
10414
b124fd93
JB
104152011-04-28 Juanma Barranquero <lekktu@gmail.com>
10416
10417 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10418 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10419
e810457d
PE
104202011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10421
10422 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10423
ea51cceb
JB
104242011-04-27 Juanma Barranquero <lekktu@gmail.com>
10425
10426 * makefile.w32-in: Update dependencies.
10427
94dcfacf
EZ
104282011-04-27 Eli Zaretskii <eliz@gnu.org>
10429
10430 Improve `doprnt' and its usage. (Bug#8545)
10431 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10432 `format_end'. Remove support for %l as a conversion specifier.
10433 Don't use xrealloc. Improve diagnostics when the %l size modifier
10434 is used. Update the commentary.
10435
10436 * eval.c (verror): Simplify calculation of size_t.
10437
10438 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10439 messages.
10440
f61f41d7
PE
104412011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10442
10443 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10444 change.
10445
96fb4434
PE
104462011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10447
10448 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10449 This makes this file independent of the recent pseudovector change.
10450
671875da 104512011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10452
69e9b5a3
PE
10453 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10454
b5f869a7 10455 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10456 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10457 Remove unused local.
c8926152 10458 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10459
841a1577 10460 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10461 GCC 4.6.0 optimizes based on type-based alias analysis.
10462 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10463 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10464 != &v->size, and therefore "v->size = 1; b->size = 2; return
10465 v->size;" must therefore return 1. This assumption is incorrect
10466 for Emacs, since it type-puns struct Lisp_Vector * with many other
10467 types. To fix this problem, this patch adds a new type struct
f904488f 10468 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10469 and pseudovectors, and helps optimizing compilers not get fooled
10470 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10471 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10472 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10473 the size member.
eab3844f
PE
10474 (XSETPVECTYPE): Rewrite in terms of new macro.
10475 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10476 This is a bit clearer, and further avoids the possibility of
10477 undesirable aliasing.
10478 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10479 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10480 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10481 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10482 (ASIZE): Now uses header.size rather than size.
10483 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10484 to avoid the hassle of writing XVECTOR (foo)->header.size.
10485 (struct vectorlike_header): New type.
eab3844f
PE
10486 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10487 object, to help avoid aliasing.
10488 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10489 (SUBRP): Likewise, since Lisp_Subr is a special case.
10490 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10491 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10492 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10493 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10494 changed to be "header.size" and "header.next".
10495 * buffer.h (struct buffer): Likewise.
10496 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10497 * frame.h (struct frame): Likewise.
10498 * process.h (struct Lisp_Process): Likewise.
10499 * termhooks.h (struct terminal): Likewise.
10500 * window.c (struct save_window_data, struct saved_window): Likewise.
10501 * window.h (struct window): Likewise.
10502 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10503 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10504 * buffer.c (init_buffer_once): Likewise.
10505 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10506 special case.
10507 * process.c (Fformat_network_address): Use local var for size,
10508 for brevity.
10509
0df1eac5
PE
10510 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10511
847ab9d1 10512 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10513 * data.c (atof): Remove decl; no longer used or needed.
10514 (digit_to_number): Move to lread.c.
10515 (Fstring_to_number): Use new string_to_number function, to be
10516 consistent with how the Lisp reader treats infinities and NaNs.
10517 Do not assume that floating-point numbers represent EMACS_INT
10518 without losing information; this is not true on most 64-bit hosts.
10519 Avoid double-rounding errors, by insisting on integers when
10520 parsing non-base-10 numbers, as the documentation specifies.
10521 * lisp.h (string_to_number): New decl, replacing ...
10522 (isfloat_string): Remove.
bc0a5c13 10523 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10524 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10525 appears to have been a coding error. Similarly, do not accept
10526 strings like +-1e0 as floating point numbers. Do not report
10527 overflow for integer overflows unless the base is not 10 which
10528 means we have no simple and reliable way to continue.
10529 Break out the floating-point parsing into a new
10530 function string_to_number, so that Fstring_to_number parses
10531 floating point numbers consistently with the Lisp reader.
04f2d78b 10532 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10533 (E_CHAR, EXP_INT): Remove, replacing with ...
10534 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10535 (string_to_number): New function, replacing isfloat_string.
10536 This function checks for valid syntax and produces the resulting
10537 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10538 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10539 so that overflow for non-base-10 numbers is reported only when
10540 there's no portable and simple way to convert to floating point.
452f4150 10541
67769ffc
PE
10542 * textprop.c (set_text_properties_1): Rewrite for clarity,
10543 and to avoid GCC warning about integer overflow.
10544
c20db43f
PE
10545 * intervals.h (struct interval): Use EMACS_INT for members
10546 where EMACS_UINT might cause problems. See
10547 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10548 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10549 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10550 All uses changed.
37aa2f85
PE
10551 (offset_intervals): Tell GCC not to worry about length overflow
10552 when negating a negative length.
c20db43f 10553
2538aa2f
PE
10554 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10555 (overrun_check_free): Likewise.
10556
f2d3008d
PE
10557 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10558 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10559 word size.
10560
ec8df744
PE
10561 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10562 (gnutls_make_error): Rename local to avoid shadowing.
10563 (gnutls_emacs_global_deinit): ifdef out; not used.
10564 (Fgnutls_boot): Use const for pointer to readonly storage.
10565 Comment out unused local. Fix pointer signedness problems.
10566
640ee02d
PE
10567 * lread.c (openp): Don't stuff size_t into an 'int'.
10568 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10569 about possible signed overflow.
10570
6048fb2a
PE
10571 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10572 (GDK_KEY_g): Don't define if already defined.
10573 (xg_prepare_tooltip): Avoid pointer signedness problem.
10574 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10575
fa3c87e1
PE
10576 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10577 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10578
2172544b
PE
10579 * xfns.c (Fx_window_property): Simplify a bit,
10580 to make a bit faster and to avoid GCC 4.6.0 warning.
10581 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10582
9b821a21
PE
10583 * fns.c (internal_equal): Don't assume size_t fits in int.
10584
3c616cfa
PE
10585 * alloc.c (compact_small_strings): Tighten assertion a little.
10586
c2982e87
PE
10587 Replace pEd with more-general pI, and fix some printf arg casts.
10588 * lisp.h (pI): New macro, generalizing old pEd macro to other
10589 conversion specifiers. For example, use "...%"pI"d..." rather
10590 than "...%"pEd"...".
10591 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10592 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10593 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10594 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10595 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10596 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10597 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10598 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10599 64-bit hosts.
10600 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10601 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10602 * print.c (safe_debug_print, print_object): Likewise.
10603 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10604 to int.
6f04d126
PE
10605 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10606 avoiding the 0 flag, which is not portable.
c2982e87
PE
10607 * process.c (Fmake_network_process): Use pI to avoid cast.
10608 * region-cache.c (pp_cache): Likewise.
10609 * xdisp.c (decode_mode_spec): Likewise.
10610 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10611 behavior on 64-bit hosts with printf arg.
6f04d126 10612 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10613 (x_stop_queuing_selection_requests): Likewise.
10614 (x_get_window_property): Don't truncate byte count to an 'int'
10615 when tracing.
0b432f21 10616
5e073ec7
PE
10617 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10618 here, since it parses constructs like leading '-' and spaces,
10619 which are not wanted; and it overflows with large numbers.
10620 Instead, simply match F[0-9]+, which is what is wanted anyway.
10621
36372bf9
PE
10622 * alloc.c: Remove unportable assumptions about struct layout.
10623 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10624 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10625 (allocate_vectorlike, make_pure_vector): Use the new macros,
10626 plus offsetof, to remove unportable assumptions about struct layout.
10627 These assumptions hold on all porting targets that I know of, but
10628 they are not guaranteed, they're easy to remove, and removing them
10629 makes further changes easier.
10630
0b432f21
PE
10631 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10632 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10633 (string_overrun_cookie): Now const. Use initializers that
10634 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10635 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10636 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10637 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10638 multiple of sizeof (EMACS_INT); it need not be, if
10639 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10640 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10641
895009e1
JB
106422011-04-26 Juanma Barranquero <lekktu@gmail.com>
10643
10644 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10645
6a7a1b0b
TZ
106462011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10647
10648 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10649 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10650 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10651
841a1577 106522011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10653
10654 * lisp.h (Qdebug): List symbol.
895009e1 10655 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10656 * keyboard.c (debug-on-event): New variable.
10657 (handle_user_signal): Break into debugger when debug-on-event
10658 matches the current signal symbol.
10659
f2d3ba6f
DN
106602011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10661
10662 * alloc.c (check_sblock, check_string_bytes)
10663 (check_string_free_list): Convert to standard C.
10664
42ce4c63
TZ
106652011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10666
10667 * w32.c (emacs_gnutls_push): Fix typo.
10668
825cd63c
EZ
106692011-04-25 Eli Zaretskii <eliz@gnu.org>
10670
fb11d64d
EZ
10671 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10672 "cast to pointer from integer of different size".
10673
825cd63c
EZ
10674 Improve doprnt and its use in verror. (Bug#8545)
10675 * doprnt.c (doprnt): Document the set of format control sequences
10676 supported by the function. Use SAFE_ALLOCA instead of always
10677 using `alloca'.
10678
10679 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10680 is one byte too soon. Don't use xrealloc; instead xfree and
10681 xmalloc anew.
10682
e061a11b
TZ
106832011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10684
10685 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10686 callbacks stage.
10687
10688 * gnutls.c: Renamed global_initialized to
10689 gnutls_global_initialized. Added internals for the
10690 :verify-hostname-error, :verify-error, and :verify-flags
10691 parameters of `gnutls-boot' and documented those parameters in the
10692 docstring. Start callback support.
9173deec
JB
10693 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10694 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10695 on error. Return error code.
e061a11b
TZ
10696 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10697 (emacs_gnutls_read): Likewise.
10698 (Fgnutls_boot): Return handshake error code.
10699 (emacs_gnutls_handle_error): New function.
10700 (wsaerror_to_errno): Likewise.
10701
10702 * w32.h (emacs_gnutls_pull): Add prototype.
10703 (emacs_gnutls_push): Likewise.
10704
10705 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10706 (emacs_gnutls_push): Likewise.
10707
107082011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10709
10710 * process.c (wait_reading_process_output): Check if GnuTLS
10711 buffered some data internally if no FDs are set for TLS
10712 connections.
10713
10714 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10715 (LIBS): Link to USER_LIBS.
10716 ($(BLD)/gnutls.$(0)): New target.
10717
fa6996bc
EZ
107182011-04-24 Eli Zaretskii <eliz@gnu.org>
10719
eb35682e
EZ
10720 * xdisp.c (handle_single_display_spec): Rename the
10721 display_replaced_before_p argument into display_replaced_p, to
10722 make it consistent with the commentary. Fix typos in the
10723 commentary.
10724
e2ad650c
EZ
10725 * textprop.c (syms_of_textprop): Remove dead code.
10726 (copy_text_properties): Delete obsolete commentary about an
10727 interface that was deleted long ago. Fix typos in the description
10728 of arguments.
10729
1b2de274
EZ
10730 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10731 to changes in oldXMenu/XMenu.h from 2011-04-16.
10732 <menu_help_message, prev_menu_help_message>: Constify.
10733 (IT_menu_make_room): menu->help_text is now `const char **';
10734 adjust.
10735
10736 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10737 to changes in oldXMenu/XMenu.h from 2011-04-16.
10738 (struct XMenu): Declare `help_text' `const char **'.
10739
10740 * xfaces.c <Qunspecified>: Make extern again.
10741
10742 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10743 required by POSIX.
1b2de274 10744
762b15be
EZ
10745 * doc.c (get_doc_string): Improve the format passed to `error'.
10746
10747 * doprnt.c (doprnt): Improve commentary.
10748
10749 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10750
10751 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10752 them with etags.
10753
f1052e5d
EZ
10754 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10755 changes in globals.h immediately force recompilation.
762b15be
EZ
10756 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10757 $(CURDIR)/s/ms-w32.h.
10758 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10759
fa6996bc
EZ
10760 * character.c (Fchar_direction): Function deleted.
10761 (syms_of_character): Don't defsubr it.
10762 <char-direction-table>: Deleted.
10763
e6c3da20
EZ
107642011-04-23 Eli Zaretskii <eliz@gnu.org>
10765
10766 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10767 * doprnt.c: Include limits.h.
10768 (SIZE_MAX): New macro.
04f2d78b
CB
10769 (doprnt): Return a size_t value. 2nd arg is now size_t.
10770 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10771 Improve overflow protection. Support `l' modifier for integer
10772 conversions. Support %l conversion. Don't assume an EMACS_INT
10773 argument for integer conversions and for %c.
10774
10775 * lisp.h (doprnt): Restore prototype.
10776
10777 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10778 $(SRC)/character.h.
10779
10780 * Makefile.in (base_obj): Add back doprnt.o.
10781
10782 * deps.mk (doprnt.o): Add back prerequisites.
10783 (callint.o): Depend on character.h.
10784
10785 * eval.c (internal_lisp_condition_case): Include the handler
10786 representation in the error message.
10787 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10788 when breaking from the loop.
10789
10790 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10791
10792 * callint.c (Fcall_interactively): When displaying error message
10793 about invalid control letter, pass the character's codepoint, not
10794 a pointer to its multibyte form. Improve display of the character
10795 in octal and display also its hex code.
10796
10797 * character.c (char_string): Use %x to display the (unsigned)
10798 codepoint of an invalid character, to avoid displaying a bogus
10799 negative value.
10800
10801 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10802 `error', not SYMBOL_NAME itself.
10803
10804 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10805 character arguments to `error'.
10806
10807 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10808 to `error' in error message about FINAL_CHAR argument. Make sure
10809 FINAL_CHAR is a character, and use %c when it is passed as
10810 argument to `error'.
10811
4ffd0d6b 108122011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10813
10814 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10815
10816 * w32.c: Include <time.h>.
10817 (sys_localtime): New function.
10818
4ffd0d6b 108192011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10820
10821 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10822
4ffd0d6b 10823 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10824
4ffd0d6b 108252011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10826
4ffd0d6b
GM
10827 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10828 zombies (Bug#8467).
aac0c6e3 10829
04c56954
EZ
108302011-04-19 Eli Zaretskii <eliz@gnu.org>
10831
10832 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10833 gl_state.e_property when gl_state.object is Qt.
10834
10835 * insdel.c (make_gap_larger): Remove limitation of buffer size
10836 to <= INT_MAX.
10837
16a43933
CY
108382011-04-18 Chong Yidong <cyd@stupidchicken.com>
10839
10840 * xdisp.c (lookup_glyphless_char_display)
10841 (produce_glyphless_glyph): Handle cons cell entry in
10842 glyphless-char-display.
10843 (Vglyphless_char_display): Document it.
10844
10845 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10846 glyphless-char-display.
10847
4581706e
CY
108482011-04-17 Chong Yidong <cyd@stupidchicken.com>
10849
10850 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10851
10852 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10853
10854 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10855 definition for no-X builds.
10856
4887c6e2 108572011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10858
fd35b6f9
PE
10859 Static checks with GCC 4.6.0 and non-default toolkits.
10860
5c1ccb01
PE
10861 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10862
006c5daa
PE
10863 * process.c (keyboard_bit_set): Define only if SIGIO.
10864 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10865 (send_process): Repair possible setjmp clobbering.
10866
efc736d3
PE
10867 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10868
4e2fe2e6
PE
10869 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10870
f97334a2
PE
10871 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10872
4e75f29d
PE
10873 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10874 Define only if needed.
10875
90efadd1
PE
10876 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10877 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10878 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10879
3c647824
PE
10880 * dispextern.h (struct redisplay_interface): Rename param
10881 to avoid shadowing.
e264f262 10882 * termhooks.h (struct terminal): Likewise.
761383f4 10883 * xterm.c (xembed_send_message): Likewise.
3c647824 10884
b58c5c4a
PE
10885 * insdel.c (make_gap_smaller): Define only if
10886 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10887
cad59032
PE
10888 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10889 it.
10890
c339dc2e
PE
10891 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10892 so that we aren't warned about unused symbols.
10893
91a3e27b
PE
10894 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10895
399c71d3 10896 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10897
8ffc96f5
PE
10898 * xfns.c (x_real_positions): Mark locals as initialized.
10899
eef9bc79
PE
10900 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10901
098db9dd
PE
10902 * xterm.c: Fix problems found by static analysis with other toolkits.
10903 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10904 (x_dispatch_event): Declare static if USE_GTK, and
10905 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10906 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10907 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10908 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10909 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10910
eb18f6cc
PE
10911 * xmenu.c (menu_help_callback): Pointer type fixes.
10912 Use const pointers when pointing at readonly data. Avoid pointer
10913 signedness clashes.
10914 (FALSE): Remove unused macro.
10915 (update_frame_menubar): Remove unused decl.
10916
1fe72bf8
PE
10917 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10918
60d9e1db
PE
10919 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10920 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10921 (single_menu_item): Rename local to avoid shadowing.
10922
39261c26
PE
10923 * keyboard.c (make_lispy_event): Remove unused local var.
10924
018c5e19
PE
10925 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10926 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10927
63d2b86e
PE
10928 * bitmaps: Change bitmaps from unsigned char back to the X11
10929 compatible char. Avoid the old compiler warnings about
10930 out-of-range initializers by using, for example, '\xab' rather
10931 than 0xab.
10932
aefd87e1
PE
10933 * xgselect.c (xgselect_initialize): Check vs interface
10934 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10935
bf501fb9
PE
10936 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10937
e9829fdf
PE
10938 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10939 to read-only memory.
10940
1086c095
PE
10941 * fns.c (vector): Remove; this old hack is no longer needed.
10942
2baccd04 10943 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10944 Remove unused var.
dde42981 10945 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10946
72391843 10947 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10948
436c16df 10949 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10950 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10951 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10952
92bb796d 10953 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10954 (x_term_init): Remove local to avoid shadowing.
92bb796d 10955
764430a3 10956 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10957
10958 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10959 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10960
d1dfb56c
EZ
109612011-04-16 Eli Zaretskii <eliz@gnu.org>
10962
c4354cb4
EZ
10963 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10964
d1dfb56c
EZ
10965 Fix regex.c, syntax.c and friends for buffers > 2GB.
10966 * syntax.h (struct gl_state_s): Declare character position members
10967 EMACS_INT.
10968
10969 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10970
04f2d78b
CB
10971 * textprop.c (verify_interval_modification, interval_of):
10972 Declare arguments EMACS_INT.
d1dfb56c
EZ
10973
10974 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10975 EMACS_INT.
10976
10977 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10978
10979 * indent.c (Fvertical_motion): Local variable it_start is now
10980 EMACS_INT.
10981
10982 * regex.c (re_match, re_match_2, re_match_2_internal)
10983 (bcmp_translate, regcomp, regexec, print_double_string)
10984 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10985 (re_compile_pattern, re_exec): Declare arguments and local
10986 variables `size_t' and `ssize_t' and return values `regoff_t', as
10987 appropriate.
10988 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10989 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10990 <compile_stack_type>: `size' and `avail' are now `size_t'.
10991
10992 * regex.h <regoff_t>: Use ssize_t, not int.
10993 (re_search, re_search_2, re_match, re_match_2): Arguments that
10994 specify buffer/string position and length are now ssize_t and
10995 size_t. Return type is regoff_t.
10996
613052cd
BK
109972011-04-16 Ben Key <bkey76@gmail.com>
10998
10999 * nsfont.m: Fixed bugs in ns_get_family and
11000 ns_descriptor_to_entity that were caused by using free to
11001 deallocate memory blocks that were allocated by xmalloc (via
11002 xstrdup). This caused Emacs to crash when compiled with
11003 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11004 --enable-checking=xmallocoverrun). xfree is now used to
11005 deallocate these memory blocks.
11006
4170f62f 110072011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11008
71b41406
PE
11009 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11010
9587a89d
PE
11011 emacs_write: Accept and return EMACS_INT for sizes.
11012 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11013 et seq.
11014 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11015 Accept and return EMACS_INT.
11016 (emacs_gnutls_write): Return the number of bytes written on
11017 partial writes.
11018 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11019 (emacs_read, emacs_write): Remove check for negative size, as the
11020 Emacs source code has been audited now.
9587a89d
PE
11021 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11022 (emacs_read, emacs_write): Use it.
273a5f82
PE
11023 * process.c (send_process): Adjust to the new signatures of
11024 emacs_write and emacs_gnutls_write. Do not attempt to store
11025 a byte offset into an 'int'; it might overflow.
9587a89d 11026 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11027
3e047f51
PE
11028 * sound.c: Don't assume sizes fit in 'int'.
11029 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11030 Return EMACS_INT, not int.
3e047f51 11031 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11032 Accept EMACS_INT, not int.
11033 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11034 record read return values.
11035
cc39a9db
BK
110362011-04-15 Ben Key <bkey76@gmail.com>
11037
c9d0ec6d
JB
11038 * keyboard.c (Qundefined): Don't declare static since it is used
11039 in nsfns.m.
11040 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11041 static since they are used in nsfont.m.
cc39a9db 11042
6c60eb9f
SM
110432011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11044
11045 * process.c (Qprocessp): Don't declare static.
11046 * lisp.h (Qprocessp): Declare again.
11047
7990b61a
JB
110482011-04-15 Juanma Barranquero <lekktu@gmail.com>
11049
11050 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11051
5d4cb038
PE
110522011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11053
8bd7b830 11054 Improve C-level modularity by making more things 'static'.
cd64ea1d 11055
e3b27b31
PE
11056 Don't publish debugger-only interfaces to other modules.
11057 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11058 (verify_bytepos, count_markers): Move decls to the only modules
11059 that need them.
11060 * region-cache.h (pp_cache): Likewise.
11061 * window.h (check_all_windows): Likewise.
11062 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11063
5d4cb038
PE
11064 * sysdep.c (croak): Now static, if
11065 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11066 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11067
11068 * alloc.c (refill_memory_reserve): Now static if
11069 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11070 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11071
e87b6180
PE
11072 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11073 Define only if USE_LUCID.
11074
ac64929e
PE
11075 * xrdb.c (x_customization_string, x_rm_string): Now static.
11076
6f37259d
PE
11077 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11078 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11079
1683e3ab
PE
11080 * xdisp.c (draw_row_with_mouse_face): Now static.
11081 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11082
de9c2632
PE
11083 * window.h (check_all_windows): Mark externally visible.
11084
2b96acb7
PE
11085 * window.c (window_deletion_count): Now static.
11086
11087 * undo.c: Make symbols static if they're not exported.
11088 (last_undo_buffer, last_boundary_position, pending_boundary):
11089 Now static.
11090
50436f33
PE
11091 * textprop.c (interval_insert_behind_hooks): Now static.
11092 (interval_insert_in_front_hooks): Likewise.
11093
64520e5c
PE
11094 * term.c: Make symbols static if they're not exported.
11095 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11096 (max_frame_lines, tty_set_terminal_modes):
11097 (tty_reset_terminal_modes, tty_turn_off_highlight):
11098 (get_tty_terminal): Now static.
11099 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11100 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11101 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11102 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11103 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11104
1fa53021
PE
11105 * sysdep.c: Make symbols static if they're not exported.
11106 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11107 Now static.
11108 (sigprocmask_set, full_mask): Remove; unused.
11109 (wait_debugging): Mark as visible.
11110 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11111 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11112
d4b43b22
PE
11113 * syntax.c (syntax_temp): Define only if !__GNUC__.
11114
b7c513d0
PE
11115 * sound.c (current_sound_device, current_sound): Now static.
11116
989b29ad
PE
11117 * search.c (searchbufs, searchbuf_head): Now static.
11118
13a55a78
PE
11119 * scroll.c (scroll_cost): Remove; unused.
11120 * dispextern.h (scroll_cost): Remove decl.
11121
de68a1fc
PE
11122 * region-cache.h (pp_cache): Mark as externally visible.
11123
40ccffa6
PE
11124 * process.c: Make symbols static if they're not exported.
11125 (process_tick, update_tick, create_process, chan_process):
11126 (Vprocess_alist, proc_buffered_char, datagram_access):
11127 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11128 (deactivate_process): Mark defn as static, as well as decl.
11129 * lisp.h (create_process): Remove decl.
11130 * process.h (chan_process, Vprocess_alist): Remove decls.
11131
ad64fc97
PE
11132 * print.c: Make symbols static if they're not exported.
11133 (print_depth, new_backquote_output, being_printed, print_buffer):
11134 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11135 (print_interval, print_number_index, initial_stderr_stream):
11136 Now static.
11137 * lisp.h (Fprinc): Remove decl.
11138 (debug_output_compilation_hack): Mark as externally visible.
11139
adddb265
PE
11140 * sysdep.c (croak): Move decl from here to syssignal.h.
11141 * syssignal.h (croak): Put it here, so the API can be checked when
11142 'croak' is called from dissociate_if_controlling_tty.
11143
1717ede2
PE
11144 * minibuf.c: Make symbols static if they're not exported.
11145 (minibuf_save_list, choose_minibuf_frame): Now static.
11146 * lisp.h (choose_minibuf_frame): Remove decl.
11147
fa5fb2bc
PE
11148 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11149
1e3890d1
PE
11150 * lread.c: Make symbols static if they're not exported.
11151 (read_objects, initial_obarray, oblookup_last_bucket_number):
11152 Now static.
11153 (make_symbol): Remove; unused.
11154 * lisp.h (initial_obarray, make_symbol): Remove decls.
11155
8a1414fa
PE
11156 * keyboard.c: Make symbols static if they're not exported.
11157 (single_kboard, recent_keys_index, total_keys, recent_keys):
11158 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11159 (this_single_command_key_start, echoing, last_auto_save):
11160 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11161 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11162 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11163 (Vlispy_mouse_stem, double_click_count):
11164 Now static.
11165 (force_auto_save_soon): Define only if SIGDANGER.
11166 (ignore_mouse_drag_p): Now static if
11167 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11168 (print_help): Remove; unused.
11169 (stop_character, last_timer_event): Mark as externally visible.
11170 * keyboard.h (ignore_mouse_drag_p): Declare only if
11171 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11172 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11173 * lisp.h (echoing): Remove decl.
11174 (force_auto_save_soon): Declare only if SIGDANGER.
11175 * xdisp.c (redisplay_window): Simplify code, to make it more
11176 obvious that ignore_mouse_drag_p is not accessed if !defined
11177 USE_GTK && !defined HAVE_NS.
11178
93ea6e8f
PE
11179 * intervals.c: Make symbols static if they're not exported.
11180 (merge_properties_sticky, merge_interval_right, delete_interval):
11181 Now static.
11182 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11183
77382fcc
PE
11184 * insdel.c: Make symbols static if they're not exported.
11185 However, leave prepare_to_modify_buffer alone. It's never
11186 called from outside this function, but that appears to be a bug.
11187 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11188 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11189 (adjust_after_replace_noundo): Remove; unused.
11190 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11191 (signal_before_change): Remove decls.
77382fcc 11192
9306c32e
PE
11193 * indent.c (val_compute_motion, val_vmotion): Now static.
11194
cd44d2eb
PE
11195 * image.c: Make symbols static if they're not exported.
11196 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11197 if USE_GTK.
11198 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11199 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11200
ad9a7a06
PE
11201 * fringe.c (standard_bitmaps): Now static.
11202 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11203
81626931
PE
11204 * frame.c: Make symbols static if they're not exported.
11205 (x_report_frame_params, make_terminal_frame): Now static.
11206 (get_frame_param): Now static, unless HAVE_NS.
11207 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11208 (x_get_resource_string): Remove; not used.
11209 * frame.h (make_terminal_frame, x_report_frame_params):
11210 (x_get_resource_string); Remove decls.
11211 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11212 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11213
239f9db9
PE
11214 * font.c, fontset.c: Make symbols static if they're not exported.
11215 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11216 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11217 * font.c (font_close_object): Now static.
11218 * font.h (font_close_object): Remove.
11219 * fontset.c (FONTSET_OBJLIST): Remove.
11220 (free_realized_fontset) #if-0 the body, which does nothing.
11221 (face_suitable_for_char_p): #if-0, as it's never called.
11222 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11223 * xfaces.c (face_at_string_position):
11224 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11225 since 0 is always ASCII.
11226
dfcf3579
PE
11227 * fns.c (weak_hash_tables): Now static.
11228
5045092b
PE
11229 * fileio.c: Make symbols static if they're not exported.
11230 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11231 (Vwrite_region_annotation_buffers): Now static.
11232
57a96f5c
PE
11233 * eval.c: Make symbols static if they're not exported.
11234 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11235 * lisp.h (backtrace_list): Remove decl.
11236
35f08c38
PE
11237 * emacs.c: Make symbols static if they're not exported.
11238 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11239 (fatal_error_code, fatal_error_signal_hook, standard_args):
11240 Now static.
11241 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11242 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11243 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11244 * lisp.h (fatal_error_signal_hook): Remove decl.
11245 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11246
f44bd759
PE
11247 * editfns.c: Move a (normally-unused) function to its only use.
11248 * editfns.c, lisp.h (get_operating_system_release): Remove.
11249 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11250 worth the hassle of breaking this out.
11251
b532497d
PE
11252 * xterm.c: Make symbols static if they're not exported.
11253 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11254 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11255 (x_destroy_window, x_delete_display):
11256 Now static.
11257 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11258 (x_mouse_leave): Remove; unused.
11259 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11260 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11261 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11262 Remove decls.
11263 (x_mouse_leave): Declare only if WINDOWSNT.
11264 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11265 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11266 USE_X_TOOLKIT.
11267
1675728f
PE
11268 * ftxfont.c: Make symbols static if they're not exported.
11269 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11270 HAVE_FREETYPE.
11271 * font.h (ftxfont_driver): Likewise.
11272
e4cebfca
PE
11273 * xfns.c: Make symbols static if they're not exported.
11274 (x_last_font_name, x_display_info_for_name):
11275 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11276 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11277 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11278 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11279 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11280 (last_show_tip_args): Now static.
11281 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11282 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11283 (x_screen_planes): Remove; unused.
11284 * dispextern.h (x_screen_planes): Remove decl.
11285
5bf46f05
PE
11286 * dispnew.c: Make symbols static if they're not exported.
11287 * dispextern.h (redraw_garbaged_frames, scrolling):
11288 (increment_row_positions): Remove.
11289 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11290 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11291 Now static.
11292 (redraw_garbaged_frames): Remove; unused.
11293
435f4c28
PE
11294 * xfaces.c: Make symbols static if they're not exported.
11295 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11296 Remove decls.
11297 * xterm.h (defined_color): Remove decls.
11298 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11299 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11300 (menu_face_changed_default, defined_color, free_realized_face):
11301 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11302 (ascii_face_of_lisp_face): Remove; unused.
11303
8524aef3
PE
11304 * xdisp.c: Make symbols static if they're not exported.
11305 * dispextern.h (scratch_glyph_row, window_box_edges):
11306 (glyph_to_pixel_coords, set_cursor_from_row):
11307 (get_next_display_element, set_iterator_to_next):
11308 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11309 (show_mouse_face): Remove decls
11310 * frame.h (message_buf_print): Likewise.
11311 * lisp.h (pop_message, set_message, check_point_in_composition):
11312 Likewise.
11313 * xterm.h (set_vertical_scroll_bar): Likewise.
11314 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11315 (message_buf_print, scratch_glyph_row, displayed_buffer):
11316 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11317 (get_next_display_element, show_mouse_face, window_box_edges):
11318 (frame_to_window_pixel_xy, check_point_in_composition):
11319 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11320 (glyph_to_pixel_coords): Remove; unused.
11321
16390cd2
PE
11322 * dired.c (file_name_completion): Now static.
11323
11324 * dbusbind.c (xd_in_read_queued_messages): Now static.
11325
a25f4dfa
PE
11326 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11327 * data.c (circular_list_error): Remove.
11328
14a9c8df
PE
11329 * commands.h (last_point_position, last_point_position_buffer):
11330 (last_point_position_window): Remove decls.
11331 * keyboard.c: Make these variables static.
11332
04f2d78b
CB
11333 * coding.h (coding, code_convert_region, encode_coding_gap):
11334 Remove decls.
74ab6df5
PE
11335 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11336 (iso_code_class, detect_coding, code_convert_region): Now static.
11337 (encode_coding_gap): Remove; unused.
11338
38dfbee1
PE
11339 * chartab.c (chartab_chars, chartab_bits): Now static.
11340
a2cb4e63
PE
11341 * charset.h (charset_iso_8859_1): Remove decl.
11342 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11343 Now static.
11344
127198fd
PE
11345 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11346 * ccl.c (Vccl_program_table): Now static.
11347 (check_ccl_update): Remove; unused.
11348
d85b608f
PE
11349 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11350 * category.h: ... from here.
11351 * category.c (check_category_table, set_category_set): Now static.
11352
31cd66f3
PE
11353 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11354 * lisp.h: Remove these decls.
11355
c358e587
PE
11356 * buffer.c (buffer_count): Remove unused var.
11357
e78aecca
PE
11358 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11359 so that it's not optimized away.
11360 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11361 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11362 exported only to the debugger.
11363
e192d7d3 11364 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11365 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11366
92470028
PE
11367 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11368 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11369 was inaccessible from Lisp.
11370 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11371 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11372
244ed907
PE
11373 alloc.c: Import and export fewer symbols, and remove unused items.
11374 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11375 is defined.
11376 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11377 it's not optimized away by whole-program optimization.
11378 (message_enable_multibyte, free_misc): Remove.
11379 (catchlist, handlerlist, mark_backtrace):
11380 Declare only if BYTE_MARK_STACK.
11381 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11382 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11383 (message_enable_multibyte): Remove decl.
11384 (free_misc, interval_free_list, float_block, float_block_index):
11385 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11386 (cons_free_list, last_marked_index):
11387 Now static.
11388 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11389 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11390 (mark_backtrace): Define only if BYTE_MARK_STACK.
11391 * xdisp.c (message_enable_multibyte): Now static.
11392
61c2b50e 11393 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11394 This makes it easier for human readers (and static analyzers)
11395 to see whether these variables are used from other modules.
11396 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11397 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11398 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11399 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11400 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11401 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11402 * xmenu.c, xselect.c:
11403 Declare Q* vars static if they are not used in other modules.
11404 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11405 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11406 Remove decls of unexported vars.
11407 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11408
95c82688
PE
11409 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11410
16a97296
PE
11411 Make Emacs functions such as Fatom 'static' by default.
11412 This makes it easier for human readers (and static analyzers)
11413 to see whether these functions can be called from other modules.
11414 DEFUN now defines a static function. To make the function external
11415 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11416 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11417 (Finit_image_library):
16a97296
PE
11418 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11419 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11420 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11421 Remove decls, since these functions are now static.
11422 (Funintern, Fget_internal_run_time): New decls, since these functions
11423 were already external.
95c82688 11424
16a97296
PE
11425 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11426 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11427 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11428 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11429 * keyboard.c, keymap.c, lread.c:
11430 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11431 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11432 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11433 Mark functions with DEFUE instead of DEFUN,
11434 if they are used in other modules.
11435 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11436 decls for now-static functions.
11437 * buffer.h (Fdelete_overlay): Remove decl.
11438 * callproc.c (Fgetenv_internal): Mark as internal.
11439 * composite.c (Fremove_list_of_text_properties): Remove decl.
11440 (Fcomposition_get_gstring): New forward static decl.
11441 * composite.h (Fcomposite_get_gstring): Remove decl.
11442 * dired.c (Ffile_attributes): New forward static decl.
11443 * doc.c (Fdocumntation_property): New forward static decl.
11444 * eval.c (Ffetch_bytecode): New forward static decl.
11445 (Funintern): Remove extern decl; now in .h file where it belongs.
11446 * fileio.c (Fmake_symbolic_link): New forward static decl.
11447 * image.c (Finit_image_library): New forward static decl.
11448 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11449 * intervals.h (Fprevious_property_change):
11450 (Fremove_list_of_text_properties): Remove decls.
11451 * keyboard.c (Fthis_command_keys): Remove decl.
11452 (Fcommand_execute): New forward static decl.
11453 * keymap.c (Flookup_key): New forward static decl.
11454 (Fcopy_keymap): Now static.
11455 * keymap.h (Flookup_key): Remove decl.
11456 * process.c (Fget_process): New forward static decl.
11457 (Fprocess_datagram_address): Mark as internal.
11458 * syntax.c (Fsyntax_table_p): New forward static decl.
11459 (skip_chars): Remove duplicate decl.
11460 * textprop.c (Fprevious_property_change): New forward static decl.
11461 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11462 Now internal.
11463 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11464 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11465
785bbd42
PE
11466 * editfns.c (Fformat): Remove unreachable code.
11467
8b913b57
AS
114682011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11469
11470 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11471 change. (Bug#8496)
11472
a6744a35
EZ
114732011-04-13 Eli Zaretskii <eliz@gnu.org>
11474
11475 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11476 when at ZV. (Bug#8487)
11477
e7974947
AS
114782011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11479
baad03f0
AS
11480 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11481 (Bug#8437)
11482 * keyboard.c (parse_tool_bar_item): Likewise.
11483 * sound.c (sound_cleanup, alsa_close): Likewise.
11484 * termcap.c (tgetent): Likewise.
11485 * xfns.c (x_default_font_parameter): Likewise.
11486 * xsettings.c (read_and_apply_settings): Likewise.
11487
e7974947
AS
11488 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11489 (overrun_check_free): Protoize.
11490
28272684
PE
114912011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11492
11493 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11494 since callers should never pass a negative size.
11495 Change the signature to match that of plain 'read' and 'write'; see
11496 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11497 * lisp.h: Update prototypes of emacs_write and emacs_read.
11498
11997c76
EZ
114992011-04-11 Eli Zaretskii <eliz@gnu.org>
11500
11501 * xdisp.c (redisplay_window): Don't try to determine the character
11502 position of the scroll margin if the window start point w->startp
e896f03c 11503 is outside the buffer's accessible region. (Bug#8468)
11997c76 11504
8a2cbd72
EZ
115052011-04-10 Eli Zaretskii <eliz@gnu.org>
11506
11507 Fix write-region and its subroutines for buffers > 2GB.
11508 * fileio.c (a_write, e_write): Modify declaration of arguments and
11509 local variables to support buffers larger than 2GB.
11510 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11511
11512 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11513 argument, local variables, and return value.
11514
11515 * lisp.h: Update prototypes of emacs_write and emacs_read.
11516
11517 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11518
4073e537 115192011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11520
1ebfdcb6
PE
11521 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11522
b2ded58d
PE
11523 Fix more problems found by GCC 4.6.0's static checks.
11524
7d66342c
PE
11525 * xdisp.c (vmessage): Use a better test for character truncation.
11526
bbf47d44
PE
11527 * charset.c (load_charset_map): <, not <=, for optimization,
11528 and to avoid potential problems with integer overflow.
9248994d 11529 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11530 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11531 * editfns.c (Fformat): Likewise.
1e69125e 11532 * syntax.c (skip_chars): Likewise.
3befa583 11533
e3019616
PE
11534 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11535 This also lets GCC 4.6.0 generate slightly better loop code.
11536
becfa255
PE
11537 * callint.c (Fcall_interactively): <, not <=, for optimization.
11538 (Fcall_interactively): Count the number of arguments produced,
11539 not the number of arguments given. This is simpler and lets GCC
11540 4.6.0 generate slightly better code.
11541
dae0cd48
PE
11542 * ftfont.c: Distingish more carefully between FcChar8 and char.
11543 The previous code passed unsigned char * to a functions like
11544 strlen and xstrcasecmp that expect char *, which does not
11545 conform to the C standard.
11546 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11547 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11548 char * when the C standard requires it.
11549
76032d70
PE
11550 * keyboard.c (read_char): Remove unused var.
11551
eb3f1cc8
PE
11552 * eval.c: Port to Windows vsnprintf (Bug#8435).
11553 Include <limits.h>.
11554 (SIZE_MAX): Define if the headers do not.
11555 (verror): Do not give up if vsnprintf returns a negative count.
11556 Instead, grow the buffer. This ports to Windows vsnprintf, which
11557 does not conform to C99. Problem reported by Eli Zaretskii.
11558 Also, simplify the allocation scheme, by avoiding the need for
11559 calling realloc, and removing the ALLOCATED variable.
11560
70476b54
PE
11561 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11562
12020a9e
PE
11563 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11564 But keep the doprint source code for now, as we might revamp it
11565 and use it again (Bug#8435).
ea6c7ae6
PE
11566 * lisp.h (doprnt): Remove.
11567 * Makefile.in (base_obj): Remove doprnt.o.
11568 * deps.mk (doprnt.o): Remove.
11569
5fdb398c
PE
11570 error: Print 32- and 64-bit integers portably (Bug#8435).
11571 Without this change, on typical 64-bit hosts error ("...%d...", N)
11572 was used to print both 32- and 64-bit integers N, which relied on
11573 undefined behavior.
61bdb816 11574 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11575 * lisp.h (error, verror): Mark as printf-like functions.
11576 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11577 Report overflow in size calculations when allocating printf buffer.
11578 Do not truncate output string at its first null byte.
11579 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11580 Truncate the output at a character boundary, since vsnprintf does not
11581 do that.
11582 * charset.c (check_iso_charset_parameter): Convert internal
11583 character to string before calling 'error', since %c now has the
11584 printf meaning.
11585 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11586 overflow when computing char to be passed to 'error'. Do not
11587 pass Lisp_Object to 'error'; pass the integer instead.
11588 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11589 formatted with plain %d.
11590
b189fa66
PE
11591 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11592
bff87ef0
PE
11593 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11594
7e2cac20
PE
11595 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11596
ce4d90b5
PE
11597 * xterm.c (x_catch_errors): Remove duplicate declaration.
11598
266c9547
PE
11599 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11600
79c49ad2
PE
11601 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11602
368f4090
JM
116032011-04-10 Jim Meyering <meyering@redhat.com>
11604
11605 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11606 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11607 return ssize_t not "int", and use size_t as the buffer length.
11608 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11609 * gnutls.h: Update declarations.
11610 * process.c (read_process_output): Use ssize_t, to match.
11611 (send_process): Likewise.
11612
a32d4040
CY
116132011-04-09 Chong Yidong <cyd@stupidchicken.com>
11614
11615 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11616
8546720e 116172011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11618
04f2d78b
CB
11619 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11620 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11621
8546720e
GM
11622 * xterm.c (handle_one_xevent):
11623 * xmenu.c (create_and_show_popup_menu):
11624 * xselect.c (x_decline_selection_request)
11625 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11626
0a2f5c1a 116272011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11628
11629 Fix some uses of `int' instead of EMACS_INT.
11630 * search.c (string_match_1, fast_string_match)
11631 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11632 (scan_buffer, find_next_newline_no_quit)
11633 (find_before_next_newline, search_command, Freplace_match)
11634 (Fmatch_data): Make some `int' variables be EMACS_INT.
11635
11636 * xdisp.c (display_count_lines): 3rd argument and return value now
11637 EMACS_INT. All callers changed.
11638 (pint2hrstr): Last argument is now EMACS_INT.
11639
11640 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11641 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11642 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11643 (decode_coding_utf_16, decode_coding_emacs_mule)
11644 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11645 (decode_coding_ccl, decode_coding_charset)
11646 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11647 (decode_coding_iso_2022, decode_coding_emacs_mule)
11648 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11649 <char_offset, last_offset>: Declare EMACS_INT.
11650 (encode_coding_utf_8, encode_coding_utf_16)
11651 (encode_coding_emacs_mule, encode_invocation_designation)
11652 (encode_designation_at_bol, encode_coding_iso_2022)
11653 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11654 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11655 Declare EMACS_INT.
11656 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11657 (encode_invocation_designation): Last argument P_NCHARS is now
11658 EMACS_INT.
11659 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11660 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11661
11662 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11663 All users changed.
11664
11665 * ccl.c (Fccl_execute_on_string): Declare some variables
11666 EMACS_INT.
11667
8546720e 116682011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11669
11670 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11671
4e19a977
CS
116722011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11673
11674 * process.c (Fformat_network_address): Doc fix.
11675
87302331
R
116762011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11677
ee7683eb 11678 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11679
cbb59342
CY
116802011-04-08 Chong Yidong <cyd@stupidchicken.com>
11681
11682 * keyboard.c (read_char): Call Lisp function help-form-show,
11683 instead of using internal_with_output_to_temp_buffer.
11684 (Qhelp_form_show): New var.
e0d38eeb 11685 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11686
11687 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11688
11689 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11690
e67a13ab
CY
116912011-04-06 Chong Yidong <cyd@stupidchicken.com>
11692
04f2d78b
CB
11693 * process.c (Flist_processes): Remove to Lisp.
11694 (list_processes_1): Delete.
e67a13ab 11695
973f782d
EZ
116962011-04-06 Eli Zaretskii <eliz@gnu.org>
11697
7c106b1e
EZ
11698 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11699
973f782d
EZ
11700 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11701
41cf7d1a 117022011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11703
ca23cc88
PE
11704 Fix more problems found by GCC 4.6.0's static checks.
11705
f390e2d5
PE
11706 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11707
42eea0d0
PE
11708 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11709
b69769da 11710 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11711
f9541e84
PE
11712 * xdisp.c (vmessage): Mark as a printf-like function.
11713
13841b55
PE
11714 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11715
c136c10f
PE
11716 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11717
5e2d4a30
PE
11718 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11719 printf-like functions.
11720 (tiff_load): Add casts to remove these marks before passing them
11721 to system-supplied API.
11722
583f48b9
PE
11723 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11724
b25d760e
PE
11725 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11726 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11727 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11728 directly, rather than having caller test rule sign. This avoids
11729 some unnecessary tests.
11730 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11731 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11732 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11733
bc7b6697 11734 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11735 (xfont_open): Avoid unnecessary tests.
bc7b6697 11736
27ccc379
PE
11737 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11738
dcd5c89a
PE
11739 * composite.h, composite.c (composition_gstring_put_cache):
11740 Use EMACS_INT, not int, for length.
11741
b13a45c6
PE
11742 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11743 breaking out part of COMPOSITION_DECODE_RULE.
11744 (COMPOSITION_DECODE_RULE): Use it.
11745 * composite.c (get_composition_id): Remove unused local vars,
11746 by using the new macro.
11747
1e792e4d
PE
11748 * textprop.c (set_text_properties_1): Change while to do-while,
11749 since the condition is always true at first.
11750
dc6c6455 11751 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11752 (interval_deletion_adjustment): Return unsigned value.
11753 All uses changed.
dc6c6455 11754
aba7731a
PE
11755 * process.c (list_processes_1, create_pty, read_process_output):
11756 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11757 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11758 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11759 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11760 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11761
fdfc4bf3
PE
11762 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11763
fca8fe46 11764 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11765 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11766
06a0259a 11767 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11768 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11769 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11770
e7b9e80f
PE
11771 * print.c (print_error_message): Avoid int overflow.
11772
56201685
PE
11773 * font.c (font_list_entities): Redo for clarity,
11774 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11775
78834453 11776 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11777 (font_score): Avoid potential overflow in diff calculation.
78834453 11778
0bc0b309 11779 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11780 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11781
e610eaca
PE
11782 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11783
b895abce
PE
11784 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11785 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11786 can always succeed if overflow has undefined behavior.
11787
1f1d9321 11788 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11789 (wordify): Omit three unnecessary tests.
1f1d9321 11790
c59478bc
PE
11791 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11792 All callers changed. This avoids the need for an unused var.
11793
79b73827
PE
11794 * casefiddle.c (casify_region): Remove var that is set but not used.
11795
a4db5dfe
PE
11796 * dired.c (file_name_completion): Remove var that is set but not used.
11797
43aae36e
PE
11798 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11799
2a47c44d 11800 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11801 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11802
a37c69bf
PE
11803 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11804 Check for integer overflow on size calculations.
11805
328ab8e7
PE
11806 * buffer.c (Fprevious_overlay_change): Remove var that is set
11807 but not used.
11808
e5a2a5cb
PE
11809 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11810 Remove vars that are set but not used.
8d84a6eb 11811 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11812 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11813
a60e5f68
PE
11814 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11815
f661cb61 11816 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11817 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11818
f0397f5a
PE
11819 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11820 that are set but not used.
11821
8664db06 11822 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11823 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11824
6abdaa4a
PE
11825 * xselect.c (x_get_local_selection, x_handle_property_notify):
11826 Remove vars that are set but not used.
11827
0ce7538d 11828 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11829 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11830
9ae848fc
PE
11831 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11832 Remove var that is set but not used.
0b918413
PE
11833 (scroll_bar_windows_size): Now size_t, not int.
11834 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11835 Check for overflow.
9ae848fc 11836
a5a62657
PE
11837 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11838 (map_tty_color) [!defined MSDOS]: Likewise.
11839
5c5cdd39
PE
11840 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11841
66ebf983
PE
11842 * coding.c: Remove vars that are set but not used.
11843 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11844 All callers changed.
11845 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11846 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11847 (decode_coding_charset): Remove vars that are set but not used.
11848
1be4d761
PE
11849 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11850 that is set but not used.
11851
47553fa8
PE
11852 * print.c (print_object): Remove var that is set but not used.
11853
1f7196bf 11854 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11855 The gnulib version avoids calling malloc in the usual case,
11856 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11857 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11858 * filelock.c (current_lock_owner): Likewise.
11859 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11860 * sysdep.c: Include allocator.h, careadlinkat.h.
11861 (emacs_no_realloc_allocator): New static constant.
11862 (emacs_readlink): New function.
fdb61804
PE
11863 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11864 ../lib/careadlinkat.h.
d1fdcab7 11865
f84c17c7
SM
118662011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11867
11868 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11869 first non-nil return value).
11870
ef3862ad
JD
118712011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11872
11873 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11874 if not defined (Bug#8403).
11875
376a7006
JB
118762011-04-02 Juanma Barranquero <lekktu@gmail.com>
11877
11878 * xdisp.c (display_count_lines): Remove parameter `start',
11879 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11880 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11881 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11882 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11883 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11884 and thereabouts. All callers changed.
11885 (get_per_char_metric): Remove parameter `f', unused since
11886 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11887
6ca3801d
JM
118882011-04-02 Jim Meyering <meyering@redhat.com>
11889
11890 do not dereference NULL upon failed strdup
11891 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11892 (ns_get_family): Likewise.
11893
d8e2b5ba
JB
118942011-04-02 Juanma Barranquero <lekktu@gmail.com>
11895
11896 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11897
8c74fcbd
JD
118982011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11899
11900 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11901 later (Bug#8403).
11902
7200d79c
SM
119032011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11904
03408648 11905 Add lexical binding.
7200d79c 11906
03408648
SM
11907 * window.c (Ftemp_output_buffer_show): New fun.
11908 (Fsave_window_excursion):
11909 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11910
11911 * lread.c (lisp_file_lexically_bound_p): New function.
11912 (Fload): Bind Qlexical_binding.
11913 (readevalloop): Remove `evalfun' arg.
11914 Bind Qinternal_interpreter_environment.
11915 (Feval_buffer): Bind Qlexical_binding.
11916 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11917 Mark as dynamic.
11918 (syms_of_lread): Declare `lexical-binding'.
11919
11920 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11921
11922 * keyboard.c (eval_dyn): New fun.
11923 (menu_item_eval_property): Use it.
ca105506
SM
11924
11925 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11926
03408648
SM
11927 * fns.c (concat, mapcar1): Accept byte-code-functions.
11928
11929 * eval.c (Fsetq): Handle lexical vars.
11930 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11931 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11932 (FletX, Flet): Obey lexical binding.
11933 (Fcommandp): Handle closures.
11934 (Feval): New `lexical' arg.
11935 (eval_sub): New function extracted from Feval. Use it almost
11936 everywhere where Feval was used. Look up vars in lexical env.
11937 Handle closures.
11938 (Ffunctionp): Move from subr.el.
11939 (Ffuncall): Handle closures.
11940 (apply_lambda): Remove `eval_flags'.
11941 (funcall_lambda): Handle closures and new byte-code-functions.
11942 (Fspecial_variable_p): New function.
11943 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11944 but without exporting it to Lisp.
23aba0ea 11945
23aba0ea 11946 * doc.c (Fdocumentation, store_function_docstring):
03408648 11947 * data.c (Finteractive_form): Handle closures.
23aba0ea 11948
03408648
SM
11949 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11950 interactive spec.
ba83908c 11951
04f2d78b
CB
11952 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11953 New byte-codes.
03408648
SM
11954 (exec_byte_code): New function extracted from Fbyte_code to handle new
11955 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11956
03408648 11957 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11958
03408648 11959 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11960
e2abce01
JB
119612011-03-31 Juanma Barranquero <lekktu@gmail.com>
11962
11963 * xdisp.c (redisplay_internal): Fix prototype.
11964
63696a73 119652011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11966
63696a73 11967 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11968 (try_scrolling): Use it when setting scroll_limit.
11969 Limit scrolling to 100 screen lines.
63696a73
EZ
11970 (redisplay_window): Even when falling back on "recentering",
11971 position point in the window according to scroll-conservatively,
11972 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11973
11974 (try_scrolling): When point is above the window, allow searching
11975 as far as scroll_max, or one screenful, to compute vertical
11976 distance from PT to the scroll margin position. This prevents
11977 try_scrolling from unnecessarily failing when
11978 scroll-conservatively is set to a value slightly larger than the
11979 window height. Clean up the case of PT below the margin at bottom
11980 of window: scroll_max can no longer be INT_MAX. When aggressive
11981 scrolling is in use, don't let point enter the opposite scroll
11982 margin as result of the scroll.
11983 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11984 threshold of 100 lines for never-recentering scrolling.
11985
e4cc2dfc
JB
119862011-03-31 Juanma Barranquero <lekktu@gmail.com>
11987
11988 * dispextern.h (move_it_by_lines):
11989 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11990 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11991 (message_log_check_duplicate): Remove parameters `prev_bol' and
11992 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11993 (redisplay_internal): Remove parameter `preserve_echo_area',
11994 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11995
11996 * indent.c (Fvertical_motion):
11997 * window.c (window_scroll_pixel_based, Frecenter):
11998 Don't pass `need_y_p' to `move_it_by_lines'.
11999
1c470562
SM
120002011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12001
44f230aa
SM
12002 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12003 steal a few bits to be more compact.
12004 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12005 Remove unneeded casts.
12006
1c470562
SM
12007 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12008
888adce9
ZK
120092011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12010
12011 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12012 binding" message (bug#7967).
12013
f838ed7b
PE
120142011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12015
77861b95
PE
12016 Fix more problems found by GCC 4.6.0's static checks.
12017
de6dbc14
PE
12018 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12019 Remove unused local var.
12020
f838ed7b
PE
12021 * editfns.c (Fmessage_box): Remove unused local var.
12022
792c7b2b
PE
12023 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12024 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12025 Omit unused local vars.
c499e557 12026 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12027 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12028 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12029 Omit unused local var.
12030
ba0165e1
PE
12031 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12032 Don't assume string length fits in int.
32ad8845 12033 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12034 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12035
3c59b4c9
PE
12036 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12037 instead of alloca (Bug#8344).
12038
a3eed478 12039 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12040 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12041
eb4d412d
PE
12042 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12043
1658b401
PE
12044 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12045 concerns.
12046
12047 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12048
12049 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12050
9a2c6e05
PE
12051 * keyboard.c (syms_of_keyboard): Use the same style as later
12052 in this function when indexing through an array. This also
12053 works around GCC bug 48267.
12054
03d0a109
PE
12055 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12056
44f730c8
PE
12057 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12058
fe75f926
PE
12059 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12060 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12061
ffa8c828
PE
12062 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12063 This avoids undefined behavior on integer overflow, and is a bit
12064 more convenient anyway since it is compared to a size_t variable.
12065
c5101a77
PE
12066 Variadic C functions now count arguments with size_t, not int.
12067 This avoids an unnecessary limitation on 64-bit machines, which
12068 caused (substring ...) to crash on large vectors (Bug#8344).
12069 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12070 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12071 All variadic functions and their callers changed accordingly.
c5101a77
PE
12072 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12073 * data.c (arith_driver, float_arith_driver): Likewise.
12074 * editfns.c (general_insert_function): Likewise.
12075 * eval.c (struct backtrace.nargs, interactive_p)
12076 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12077 (funcall_lambda, mark_backtrace): Likewise.
12078 * fns.c (concat): Likewise.
12079 * frame.c (x_set_frame_parameters): Likewise.
12080 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12081 0 if not found, not -1. All callers changed.
12082
dd3f25f7
PE
12083 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12084 (stack_copy_size): Now size_t, not int.
12085 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12086
461c2ab9
JB
120872011-03-28 Juanma Barranquero <lekktu@gmail.com>
12088
12089 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12090 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12091 All callers changed.
12092
12093 * lisp.h (multibyte_char_to_unibyte):
12094 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12095 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12096 * character.h (CHAR_TO_BYTE8):
12097 * cmds.c (internal_self_insert):
12098 * editfns.c (general_insert_function):
12099 * keymap.c (push_key_description):
12100 * search.c (Freplace_match):
12101 * xdisp.c (message_dolog, set_message_1): All callers changed.
12102
f6d62986
SM
121032011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12104
12105 * keyboard.c (safe_run_hook_funcall): New function.
12106 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12107 don't set the hook to nil, but remove the offending function instead.
12108 (Qcommand_hook_internal): Remove, unused.
12109 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12110 Vcommand_hook_internal.
12111
12112 * eval.c (enum run_hooks_condition): Remove.
12113 (funcall_nil, funcall_not): New functions.
12114 (run_hook_with_args): Call each function through a `funcall' argument.
12115 Remove `cond' argument, now redundant.
12116 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12117 (Frun_hook_with_args_until_failure): Adjust accordingly.
12118 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12119
1db5b1ad
JB
121202011-03-28 Juanma Barranquero <lekktu@gmail.com>
12121
12122 * dispextern.h (string_buffer_position): Remove declaration.
12123
12124 * print.c (strout): Remove parameter `multibyte', unused since
12125 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12126
12127 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12128 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12129 All callers changed.
12130
12131 * w32.c (_wsa_errlist): Use braces for struct initializers.
12132
12133 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12134 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12135 All callers changed.
12136 (string_buffer_position): Likewise. Also, make static (it's never
12137 used outside xdisp.c).
12138 (cursor_row_p): Remove parameter `w', unused since
12139 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12140 (decode_mode_spec): Remove parameter `precision', introduced during
12141 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12142 All callers changed.
12143
5ffb62aa
JD
121442011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12145
12146 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12147
461c2ab9 121482011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12149
12150 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12151 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12152 (ns_update_auto_hide_menu_bar): New functions.
12153 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12154 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12155 ns_constrain_all_frames.
12156 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12157 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12158
5c380ffb
JD
121592011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12160
12161 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12162
9af30bdf
GM
121632011-03-27 Glenn Morris <rgm@gnu.org>
12164
12165 * syssignal.h: Replace RETSIGTYPE with void.
12166 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12167 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12168 Replace SIGTYPE with void everywhere.
12169 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12170 * s/template.h (SIGTYPE): Remove commented out definition.
12171
e2abce01
JB
121722011-03-26 Eli Zaretskii <eliz@gnu.org>
12173
12174 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12175 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12176
f868cd8a
JB
121772011-03-26 Juanma Barranquero <lekktu@gmail.com>
12178
59eb0929
JB
12179 * w32.c (read_unc_volume): Use parameter `henum', instead of
12180 global variable `wget_enum_handle'.
12181
12182 * keymap.c (describe_vector): Remove parameters `indices' and
12183 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12184 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12185
f868cd8a
JB
12186 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12187
12188 * keyboard.c (timer_check): Remove parameter `do_it_now',
12189 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12190 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12191 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12192
12193 * keyboard.c (read_char):
12194 * w32menu.c (w32_menu_display_help):
12195 * xmenu.c (show_help_event, menu_help_callback):
12196 Adjust calls to `show_help_echo'.
12197
12198 * gtkutil.c (xg_maybe_add_timer):
12199 * keyboard.c (readable_events):
12200 * process.c (wait_reading_process_output):
12201 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12202
12203 * insdel.c (adjust_markers_gap_motion):
12204 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12205 (gap_left, gap_right): Don't call it.
12206
2ecf6fdb
CY
122072011-03-25 Chong Yidong <cyd@stupidchicken.com>
12208
12209 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12210 incurred during fontification.
12211
6b1f9ba4
JB
122122011-03-25 Juanma Barranquero <lekktu@gmail.com>
12213
12214 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12215 (DEFVAR_PER_BUFFER): Don't pass it.
12216
12217 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12218 (scrolling_window): Don't pass it.
12219
0f4a96b5
JB
122202011-03-25 Juanma Barranquero <lekktu@gmail.com>
12221
12222 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12223
12224 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12225 and `suffix'.
12226 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12227 of variables specific to SELinux and computation of `encoded_absname'.
12228
12229 * image.c (XPutPixel): Remove unused variable `height'.
12230
12231 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12232
12233 * unexw32.c (get_section_info): Remove unused variable `section'.
12234
12235 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12236 (system_process_attributes): Remove unused variable `sess'.
12237 (sys_read): Remove unused variable `err'.
12238
12239 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12240 (w32_wnd_proc): Remove unused variable `isdead'.
12241 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12242 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12243 (x_create_tip_frame): Remove unused variable `tem'.
12244
12245 * w32inevt.c (w32_console_read_socket):
12246 Remove unused variable `no_events'.
12247
12248 * w32term.c (x_draw_composite_glyph_string_foreground):
12249 Remove unused variable `width'.
12250
1149507c
JB
122512011-03-24 Juanma Barranquero <lekktu@gmail.com>
12252
12253 * w32term.c (x_set_glyph_string_clipping):
12254 Don't pass uninitialized region to CombineRgn.
12255
9c88f339
JB
122562011-03-23 Juanma Barranquero <lekktu@gmail.com>
12257
12258 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12259 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12260 (Fx_close_connection): Remove unused variable `i'.
12261
12262 * w32font.c (w32font_draw): Return number of glyphs.
12263 (w32font_open_internal): Remove unused variable `i'.
12264 (w32font_driver): Add missing initializer.
12265
12266 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12267 (fill_in_menu): Remove unused variable `items_added'.
12268
12269 * w32term.c (last_mouse_press_frame): Remove static global variable.
12270 (w32_clip_to_row): Remove unused variable `f'.
12271 (x_delete_terminal): Remove unused variable `i'.
12272
12273 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12274 (NOTHING): Remove unused static global variable.
12275 (uniscribe_check_otf): Remove unused variable `table'.
12276 (uniscribe_font_driver): Add missing initializers.
12277
dee091a3
JD
122782011-03-23 Julien Danjou <julien@danjou.info>
12279
12280 * term.c (Fsuspend_tty, Fresume_tty):
12281 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12282 * window.c (temp_output_buffer_show):
12283 * insdel.c (signal_before_change):
12284 * frame.c (Fhandle_switch_frame):
12285 * fileio.c (Fdo_auto_save):
12286 * emacs.c (Fkill_emacs):
12287 * editfns.c (save_excursion_restore):
12288 * cmds.c (internal_self_insert):
12289 * callint.c (Fcall_interactively):
12290 * buffer.c (Fkill_all_local_variables):
12291 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12292 Use Frun_hooks.
0f4a96b5 12293 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12294 unconditionally since it does the check itself.
dee091a3 12295
2c520ab5 122962011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12297
c9c49752
PE
12298 Fix more problems found by GCC 4.5.2's static checks.
12299
8abc3f12
PE
12300 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12301 the first time through the loop, since we know p0 < p1 then.
12302 This also avoids a gcc -Wstrict-overflow warning.
12303
a2d26660
PE
12304 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12305 leading to a memory leak, possible in functions like
12306 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12307 of objects (Bug#8318).
a2d26660 12308
916c72e9
PE
12309 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12310 that could (at least in theory) be that large.
12311
19ab8a18
PE
12312 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12313 This is less likely to overflow, and avoids undefined behavior if
12314 overflow does occur. All callers changed. Use strtoul to scan
12315 for the unsigned long integer.
b7cbbd6f
PE
12316 (pint2hrstr): Simplify and tune code slightly.
12317 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12318
f0641eff
PE
12319 * scroll.c (do_scrolling): Work around GCC bug 48228.
12320 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12321
7f650bb9
PE
12322 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12323 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12324 (validate_x_resource_name): Simplify count usage.
12325 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12326
37dd57d1
PE
12327 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12328 fail (Bug#8306).
81e56e61 12329
699979fc 12330 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12331
401bf9b4
PE
12332 * process.c (Fmake_network_process): Use socklen_t, not int,
12333 where POSIX says socklen_t is required in portable programs.
12334 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12335 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12336 (Fmake_network_process, server_accept_connection):
12337 (wait_reading_process_output, read_process_output):
12338 Likewise.
12339
b93aacde
PE
12340 * process.c: Rename or move locals to avoid shadowing.
12341 (list_processes_1, Fmake_network_process):
12342 (read_process_output_error_handler, exec_sentinel_error_handler):
12343 Rename or move locals.
4dc343ee 12344 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12345 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12346 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12347 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12348 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12349
af8a867c 12350 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12351 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12352 Include tparam.h instead, since it declares them.
af8a867c
PE
12353 * cm.h (PC): Remove extern decl; tparam.h now does this.
12354 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12355 * terminfo.c: Include tparam.h, to check interfaces.
12356 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12357 (tparam): Adjust signature to match interface in tparam.h;
12358 this removes some undefined behavior. Check that outstring and len
12359 are zero, which they always are with Emacs.
12360 * tparam.h (PC, BC, UP): New extern decls.
12361
0248044d 12362 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12363 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12364
8ff096c1 12365 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12366 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12367 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12368 (ftfont_list): Remove unused local.
49eaafba
PE
12369 (get_adstyle_property, ftfont_pattern_entity):
12370 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12371 Rename locals to avoid shadowing.
8ff096c1 12372
e2be39f6
PE
12373 * xfont.c (xfont_list_family): Mark var as initialized.
12374
c9735e30
PE
12375 * xml.c (make_dom): Now static.
12376
8f5201ae
PE
12377 * composite.c (composition_compute_stop_pos): Rename local to
12378 avoid shadowing.
b246f932
PE
12379 (composition_reseat_it): Remove unused locals.
12380 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12381 (composition_update_it): Mark var as initialized.
11b61122
PE
12382 (find_automatic_composition): Mark vars as initialized,
12383 with a FIXME (Bug#8290).
8f5201ae 12384
760fbc2c
PE
12385 character.h: Rename locals to avoid shadowing.
12386 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12387 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12388 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12389 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12390 to avoid shadowing.
12391
ff08eb85
PE
12392 * textprop.c (property_change_between_p): Remove; unused.
12393
fc7bf025
PE
12394 * intervals.c (interval_start_pos): Now static.
12395
235d7abc
PE
12396 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12397
44f230aa
SM
12398 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12399 Rename locals to avoid shadowing.
3e7d6594 12400
50060332
PE
12401 * sound.c (wav_play, au_play, Fplay_sound_internal):
12402 Fix pointer signedness.
d01f234b 12403 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12404 (wav_play): Initialize a variable to 0, to prevent undefined
12405 behavior (Bug#8278).
50060332 12406
c4fc4e30
PE
12407 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12408
918436ed
PE
12409 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12410
c939f91b
PE
12411 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12412 clobbering (Bug#8298).
b9c7f648
PE
12413 * sysdep.c (sys_subshell): Likewise.
12414 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12415
6bd8c144
PE
12416 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12417 This should get cleaned up, so that child_setup has the
12418 same signature on all platforms.
12419
7710357c 12420 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12421 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12422
c59da222
CY
124232011-03-22 Chong Yidong <cyd@stupidchicken.com>
12424
12425 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12426 not to be necessary, and produces flickering.
12427
66b87493
GM
124282011-03-20 Glenn Morris <rgm@gnu.org>
12429
12430 * config.in: Remove file.
12431
45b6f6d5
JB
124322011-03-20 Juanma Barranquero <lekktu@gmail.com>
12433
12434 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12435 are now in src/globals.h.
12436 (syms_of_minibuf): Remove spurious & from previous change.
12437
cd394be1 124382011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12439
12440 * minibuf.c (completing-read-function): New variable.
12441 (completing-read-default): Rename from completing-read.
12442 (completing-read): Call completing-read-function.
12443
b14e3e21
CY
124442011-03-19 Juanma Barranquero <lekktu@gmail.com>
12445
12446 * xfaces.c (Fx_load_color_file):
12447 Read color file from absolute filename (bug#8250).
12448
f2b726e6
JB
124492011-03-19 Juanma Barranquero <lekktu@gmail.com>
12450
12451 * makefile.w32-in: Update dependencies.
12452
09f6ff02
EZ
124532011-03-17 Eli Zaretskii <eliz@gnu.org>
12454
12455 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12456
29a6015a
PE
124572011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12458
a3a6c54e
PE
12459 Fix more problems found by GCC 4.5.2's static checks.
12460
b766f867
PE
12461 * process.c (make_serial_process_unwind, send_process_trap):
12462 (sigchld_handler): Now static.
12463
be02381c
PE
12464 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12465 That way, the code declares only the vars that it needs.
12466 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12467 * s/cygwin.h (PTY_ITERATION): Likewise.
12468 * s/darwin.h (PTY_ITERATION): Likewise.
12469 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12470
57048744
PE
12471 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12472 * process.c (allocate_pty): Don't declare stb unless it's needed.
12473
7914961c 12474 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12475 (CONSTANTLIM): Remove; unused.
12476 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12477 Define only if needed.
7914961c 12478
b3967b18
PE
12479 * unexelf.c (unexec): Name an expression,
12480 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12481 Use a different way to cause a compilation error if anyone uses
12482 n rather than nn, a way that does not involve shadowing.
73366a00 12483 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12484
29a6015a
PE
12485 * deps.mk (unexalpha.o): Remove; unused.
12486
43cfc33e 12487 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12488 * unexec.h: New file.
ce701a33
PE
12489 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12490 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12491 Depend on unexec.h.
12492 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12493 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12494 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12495 Change as necessary to match prototype in unexec.h.
ce701a33 12496
01f44d5a
PE
12497 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12498 shadowing.
4f63c6bb 12499 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12500
a6670b0b
PE
12501 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12502 Rename locals to avoid shadowing.
12503
cef2010d 12504 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12505 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12506
d4d7173a
PE
12507 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12508
f08b802a
PE
12509 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12510 warning when compiling print.c.
12511
3ddb0639
PE
12512 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12513 instead of using an uninitialized var.
5ad03b97 12514 (font_sort_entities): Mark var as initialized.
3ddb0639 12515
170a2692
PE
12516 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12517
e663c700
PE
12518 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12519 pointers to constants.
89bc529a 12520 (font_parse_fcname): Remove unused vars.
7b81e2d0 12521 (font_delete_unmatched): Now static.
ea838e10 12522 (font_get_spec): Remove; unused.
13a547c6
PE
12523 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12524 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12525 Rename or move locals to avoid shadowing.
e663c700 12526
2a80c887 12527 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12528 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12529
1384fa33 12530 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12531 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12532
8b2c52e9
PE
12533 * alloc.c (mark_backtrace): Move decl from here ...
12534 * lisp.h: ... to here, so that it can be checked.
12535
475545b5 12536 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12537 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12538 (lisp_indirect_variable): Name an expression,
12539 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12540 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12541
b1349114 12542 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12543 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12544 Use const pointer when appropriate.
b1349114 12545
a2928364
PE
12546 * lisp.h (get_system_name, get_operating_system_release):
12547 Move decls here, to check interfaces.
12548 * process.c (get_operating_system_release): Move decl to lisp.h.
12549 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12550 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12551 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12552 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12553 (Fformat_time_string, Fencode_time, Finsert_char):
12554 (Ftranslate_region_internal, Fformat):
12555 Rename or remove local vars to avoid shadowing.
9710023e 12556 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12557
a415e694
PE
12558 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12559 avoid shadowing.
12560
8ef4622d
PE
12561 * lisp.h (eassert): Check that the argument compiles, even if
12562 ENABLE_CHECKING is not defined.
12563
946f9a5b
PE
12564 * data.c (Findirect_variable): Name an expression, to avoid
12565 gcc -Wbad-function-cast warning.
112396d6 12566 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12567 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12568 (Fmake_variable_buffer_local, Fmake_local_variable):
12569 Mark variables as initialized.
52746918 12570 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12571
e5aab7e7 12572 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12573 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12574 Rename locals to avoid shadowing.
dff45157
PE
12575 (mark_stack): Move local variables into the #ifdef region where
12576 they're used.
7bc26fdb
PE
12577 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12578 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12579 needed otherwise.
12580 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12581 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12582 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12583
e5aab7e7
PE
12584 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12585 avoids undefined behavior in theory.
12586
4da60324
PE
12587 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12588
88043301
PE
12589 Use functions, not macros, for up- and down-casing (Bug#8254).
12590 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12591 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12592 to use the following functions instead of these macros.
12593 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12594 EMACS_INT, since callers assume the returned value fits in int.
12595 (upcase1): Likewise, for UPCASE_TABLE.
12596 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12597 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12598 the race-condition problem in the old DOWNCASE.
88043301 12599
19ed5445
PE
12600 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12601 Rename locals to avoid shadowing.
12602 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12603 (regex_compile, re_search_2, re_match_2_internal):
12604 Remove unused local vars.
952db0d7
PE
12605 (FREE_VAR): Rewrite so as not to use empty "else",
12606 which gcc can warn about.
da053e48 12607 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12608 (RETALLOC_IF): Define only if needed.
12609 (WORDCHAR_P): Likewise. This one is never needed, but is used
12610 only in a comment talking about a compiler bug, so put inside
12611 the #if 0 of that comment.
12612 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12613 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12614 Remove; unused.
19ed5445 12615
1f3561e4 12616 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12617 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12618 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12619
ded6f8f7
PE
12620 * search.c (simple_search): Remove unused var.
12621
dbd37a95
PE
12622 * dired.c (compile_pattern): Move decl from here ...
12623 * lisp.h: ... to here, so that it can be checked.
12624 (struct re_registers): New forward decl.
12625
7e47afad
PE
12626 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12627
85f24f61
PE
12628 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12629 All uses changed.
12630 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12631 Rename locals to avoid shadowing.
5671df8f 12632 (Fvertical_motion): Mark locals as initialized.
85f24f61 12633
181aa2be 12634 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12635 (casify_region): Mark local as initialized.
181aa2be 12636
930d429c
PE
12637 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12638
7082eac6
PE
12639 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12640 New macros, so that the caller can use some names other than
12641 gcpro1, gcpro2, etc.
12642 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12643 of the new macros.
12644 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12645 argument, for consistency with GCPRO2_VAR, etc: it is now the
12646 prefix of the variable, not the variable itself. All uses
12647 changed.
38b2c076
PE
12648 * dired.c (directory_files_internal, file_name_completion):
12649 Rename locals to avoid shadowing.
12650
15206ed9
PE
12651 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12652 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12653 dired.c's scmp function, had undefined behavior.
12654 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12655 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12656 * buffer.h: ... to here, because these macros use current_buffer,
12657 and the new implementation with inline functions needs to have
12658 current_buffer in scope now, rather than later when the macros
12659 are used.
12660 (downcase, upcase1): New static inline functions.
12661 (DOWNCASE, UPCASE1): Reimplement using these functions.
12662 This avoids undefined behavior in expressions like
12663 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12664 from race conditions in accessing the global variables
12665 case_temp1 and case_temp2.
12666 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12667 * lisp.h (case_temp1, case_temp2): Remove their decls.
12668 * character.h (ASCII_CHAR_P): Move from here ...
12669 * lisp.h: ... to here, so that the inline functions mentioned
12670 above can use them.
12671
4a6bea26
PE
12672 * dired.c (directory_files_internal_unwind): Now static.
12673
f14b7e14
PE
12674 * fileio.c (file_name_as_directory, directory_file_name):
12675 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12676 Now static.
2893f146
PE
12677 (file_name_as_directory): Use const pointers when appropriate.
12678 (Fexpand_file_name): Likewise. In particular, newdir might
12679 point at constant storage, so make it a const pointer.
fd4ead52 12680 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12681 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12682 signedness issues.
f839df0c
PE
12683 (Fset_file_times, Finsert_file_contents, auto_save_error):
12684 Rename locals to avoid shadowing.
f14b7e14 12685
5716756e 12686 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12687 (Ftry_completion, Fall_completions): Rename or remove locals
12688 to avoid shadowing.
5716756e 12689
b4c3046a
PE
12690 * marker.c (bytepos_to_charpos): Remove; unused.
12691
b45db522
PE
12692 * lisp.h (verify_bytepos, count_markers): New decls,
12693 so that gcc does not warn that these functions aren't declared.
12694
85876d07
PE
12695 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12696 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12697 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12698 (copy_text): Remove unused local var.
85876d07 12699
03d78a21 12700 * filelock.c (within_one_second): Now static.
b3dd38ab 12701 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12702
5df8f01b
PE
12703 * buffer.c (fix_overlays_before): Mark locals as initialized.
12704 (fix_start_end_in_overlays): Likewise. This function should be
12705 simplified by using pointers-to-pointers, but that's a different
12706 matter.
b1d876f1 12707 (switch_to_buffer_1): Now static.
8f54f30a
PE
12708 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12709 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12710
a70072c9 12711 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12712 Fix pointer signedness issue.
edced198
PE
12713 (sys_subshell): Mark local as volatile if checking for lint,
12714 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12715 (MAXPATHLEN): Define only if needed.
a70072c9 12716
a0977c44
PE
12717 * process.c (serial_open, serial_configure): Move decls from here ...
12718 * systty.h: ... to here, so that they can be checked.
12719
a884fdcc
PE
12720 * fns.c (get_random, seed_random): Move extern decls from here ...
12721 * lisp.h: ... to here, so that they can be checked.
12722
604efe86 12723 * sysdep.c (reset_io): Now static.
b8950c94 12724 (wait_for_termination_signal): Remove; unused.
604efe86 12725
38fc62d9
PE
12726 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12727 (copy_keymap_item, append_key, push_text_char_description):
12728 Now static.
1004a21a 12729 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12730 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12731 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12732 (describe_map_tree):
12733 Rename locals to avoid shadowing.
38fc62d9 12734
2f2650da
PE
12735 * keyboard.c: Declare functions static if they are not used elsewhere.
12736 (echo_char, echo_dash, cmd_error, top_level_2):
12737 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12738 (read_char, kbd_buffer_get_event, make_lispy_position):
12739 (make_lispy_event, make_lispy_movement, apply_modifiers):
12740 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12741 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12742 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12743 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12744 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12745
a053e86c 12746 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12747 (mark_kboards): Move decl here ...
12748 * alloc.c (mark_kboards): ... from here.
a053e86c 12749
4752793e
PE
12750 * lisp.h (force_auto_save_soon): New decl.
12751
74f10ca7 12752 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12753 (DEFINE_DUMMY_FUNCTION): New macro.
12754 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12755 Use it.
c03cd23f
PE
12756 (main): Add casts to avoid warnings
12757 if GCC considers string literals to be constants.
74f10ca7 12758
022e70d4
PE
12759 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12760
59d6fe83
PE
12761 * dbusbind.c: Pointer signedness fixes.
12762 (xd_signature, xd_append_arg, xd_initialize):
12763 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12764 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12765 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12766 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12767
78320123
PE
12768 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12769 if GCC considers string literals to be constants.
49cebcca 12770 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12771
35ac2a97
SM
127722011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12773
fb103ca9
SM
12774 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12775 (print_preprocess, print_object): New macro to fix last change.
12776
35ac2a97
SM
12777 * print.c (print_preprocess): Don't forget font objects.
12778
62973b41
JB
127792011-03-16 Juanma Barranquero <lekktu@gmail.com>
12780
12781 * emacs.c (USAGE3): Doc fixes.
12782
0e48bb22
AS
127832011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12784
12785 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12786 structure.
12787
7684e57b
JB
127882011-03-14 Juanma Barranquero <lekktu@gmail.com>
12789
12790 * lisp.h (VWindow_system, Qfile_name_history):
12791 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12792 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12793 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12794
12795 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12796 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12797
12798 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12799 * w32console.c (detect_input_pending, read_input_pending)
12800 (encode_terminal_code):
12801 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12802 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12803 (w32_system_caret_y, Qfile_name_history):
12804 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12805 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12806 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12807 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12808 * w32proc.c (Qlocal, report_file_error):
12809 * w32term.c (Vwindow_system, updating_frame):
12810 * w32uniscribe.c (initialized, uniscribe_font_driver):
12811 Remove unneeded extern declarations.
12812
2aa46d6c
CY
128132011-03-14 Chong Yidong <cyd@stupidchicken.com>
12814
c96bbc66 12815 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12816
cffc6f3b
CY
128172011-03-13 Chong Yidong <cyd@stupidchicken.com>
12818
12819 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12820 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12821 These macros can no longer be used for assignment.
12822
44f230aa
SM
12823 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12824 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12825 (record_buffer_markers, fetch_buffer_markers): New functions for
12826 recording and fetching special buffer markers.
12827 (set_buffer_internal_1, set_buffer_temp): Use them.
12828
12829 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12830
12831 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12832
12833 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12834 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12835
12836 * xdisp.c (hscroll_window_tree):
12837 (reconsider_clip_changes): Use PT instead of BUF_PT.
12838
d251f04b
EZ
128392011-03-13 Eli Zaretskii <eliz@gnu.org>
12840
12841 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12842 $(EMACS_ROOT)/lib/intprops.h.
12843
f0c77cd1
PE
128442011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12845
3eca4629
PE
12846 Fix more problems found by GCC 4.5.2's static checks.
12847
7c86ee98
PE
12848 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12849 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12850 (xg_free_frame_widgets): Make it clear that a local variable is
12851 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12852 (gdk_window_get_screen): Make it clear that this macro is needed
12853 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12854 (int_gtk_range_get_value): New function, which avoids a diagnostic
12855 from gcc -Wbad-function-cast.
12856 (xg_set_toolkit_scroll_bar_thumb): Use it.
12857 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12858 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12859 (get_utf8_string, xg_get_file_with_chooser):
12860 Rename locals to avoid shadowing.
12861 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12862
41729b81
PE
12863 * xgselect.c (xg_select): Remove unused var.
12864
f0c77cd1
PE
12865 * image.c (four_corners_best): Mark locals as initialized.
12866 (gif_load): Initialize transparent_p to zero (Bug#8238).
12867 Mark another local as initialized.
ec6cf4c6 12868 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12869
ce0ad53d 12870 * image.c (clear_image_cache): Now static.
d5d5a617 12871 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12872 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12873 (x_edge_detection): Remove unnecessary cast that
12874 gcc -Wbad-function-cast diagnoses.
2037898d 12875 (gif_load): Fix pointer signedness.
6ae141d6
PE
12876 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12877 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12878
33383987 128792011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12880
d32df629
PE
12881 Improve quality of tests for time stamp overflow.
12882 For example, without this patch (encode-time 0 0 0 1 1
12883 1152921504606846976) returns the obviously-bogus value (-948597
12884 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12885 reports time overflow. See
12886 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12887 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12888 * editfns.c: Include limits.h and intprops.h.
12889 (TIME_T_MIN, TIME_T_MAX): New macros.
12890 (time_overflow): Move earlier, to before first use.
12891 (hi_time, lo_time): New functions, for an accurate test for
12892 out-of-range times.
12893 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12894 (Fget_internal_run_time): Don't assume time_t fits in int.
12895 (make_time): Use list2 instead of Fcons twice.
12896 (Fdecode_time): More accurate test for out-of-range times.
12897 (check_tm_member): New function.
12898 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12899 (lisp_time_argument): Don't rely on undefined left-shift and
12900 right-shift behavior when checking for time stamp overflow.
8be6f318 12901
fe31d94c
PE
12902 * editfns.c (time_overflow): New function, refactoring common code.
12903 (Fformat_time_string, Fdecode_time, Fencode_time):
12904 (Fcurrent_time_string): Use it.
12905
8be6f318
PE
12906 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12907 * dired.c (make_time): Move to ...
12908 * editfns.c (make_time): ... here.
12909 * systime.h: Note the move.
12910
09d9db2c 129112011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12912
126bc0dc
YM
12913 * fringe.c (update_window_fringes): Remove unused variables.
12914
c47cbdfd
YM
12915 * unexmacosx.c (copy_data_segment): Also copy __got section.
12916 (Bug#8223)
12917
7ac80be9
EZ
129182011-03-12 Eli Zaretskii <eliz@gnu.org>
12919
c96bbc66 12920 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12921 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12922 Constify `char *' arguments and their references according to
12923 prototypes in tparam.h.
12924
ecb0f94d 12925 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12926
7ac80be9
EZ
12927 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12928 Adapt all references accordingly.
12929
12930 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12931
ef1fd07e
TT
129322011-03-11 Tom Tromey <tromey@redhat.com>
12933
12934 * buffer.c (syms_of_buffer): Remove obsolete comment.
12935
7ef4b50c
EZ
129362011-03-11 Eli Zaretskii <eliz@gnu.org>
12937
12938 * termhooks.h (encode_terminal_code): Declare prototype.
12939
12940 * msdos.c (encode_terminal_code): Don't declare prototype.
12941
12942 * term.c (encode_terminal_code): Now external again, used by
12943 w32console.c and msdos.c.
12944
44f230aa
SM
12945 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12946 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12947
4b1ec863 129482011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12949
1714f52b 12950 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12951
4b1ec863
PE
12952 * fringe.c (update_window_fringes): Mark locals as initialized
12953 (Bug#8227).
12954 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12955
524c7aa6
PE
12956 * alloc.c (mark_fringe_data): Move decl from here ...
12957 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12958 to check its interface.
12959 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12960
a5c0af81 12961 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12962 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12963 (fontset_font): Mark local as initialized.
a9a06e0b 12964 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12965
b4716021
PE
12966 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12967
811e9bac 12968 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12969 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12970 (x_own_selection, Fx_disown_selection_internal): Rename locals
12971 to avoid shadowing.
12972 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12973
7e3ab302
PE
12974 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12975 so that the caller can use some name other than gcpro1.
12976 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12977 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12978 (Fx_backspace_delete_keys_p):
12979 Use them to avoid shadowing, and rename vars to avoid shadowing.
12980 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12981 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12982 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12983 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12984 Remove unused locals.
7e3ab302
PE
12985 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12986 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12987 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12988 macros.
f78faa98 12989
e2b13473
PE
12990 * xterm.h (x_mouse_leave): New decl.
12991
77f23912
PE
12992 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12993 Remove unused functions.
cdf4ba58
PE
12994 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12995 (x_calc_absolute_position): Now static.
7411c686 12996 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12997 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12998 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12999 unless they are used.
38d0b34a
PE
13000 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13001 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13002 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13003 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13004 (x_error_catcher, x_connection_closed, x_error_handler):
13005 (x_error_quitter, xembed_send_message, x_iconify_frame):
13006 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13007 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13008 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13009
44f230aa
SM
13010 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13011 Rename or move locals to avoid shadowing.
6b463e58 13012 (tty_defined_color, merge_face_heights): Now static.
5967d051 13013 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13014 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13015 does not deduce is never used uninitialized.
73719eba
PE
13016 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13017 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13018
426994c3 13019 * terminal.c (store_terminal_param): Now static.
5489860b 13020
032f1620 13021 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13022 (set_frame_menubar): Remove unused local.
d4323972 13023 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13024 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13025 since they might point to immutable storage.
281585b0
PE
13026 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13027 since it's unused otherwise.
032f1620 13028
367c19e5 13029 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13030 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13031 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13032 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13033 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13034 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13035 does not deduce are never used uninitialized.
70739cbe 13036
07b48fa9
PE
13037 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13038
8868a238 13039 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13040 * window.c (window_loop, size_window):
13041 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13042
7e5cf297 13043 * window.c (display_buffer): Now static.
d6550a9f
PE
13044 (size_window): Mark variables that gcc -Wuninitialized
13045 does not deduce are never used uninitialized.
a586633d
PE
13046 * window.h (check_all_windows): New decl, to forestall
13047 gcc -Wmissing-prototypes diagnostic.
5b555da1 13048 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13049
f6095868
PE
13050 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13051 shadowing.
13052 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13053 Include <limits.h>.
13054 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13055 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13056 (load_charset_map): Mark variables that gcc -Wuninitialized
13057 does not deduce are never used uninitialized.
53df7c11 13058 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13059
f38b440c
PE
13060 * coding.c (coding_set_source, coding_set_destination):
13061 Use "else { /* comment */ }" rather than "else /* comment */;"
13062 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13063 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13064 a block, when the outer 'i' will do.
13065 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13066 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13067 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13068 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13069 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13070 Rename locals to avoid shadowing.
13071 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13072 * coding.c (emacs_mule_char, encode_invocation_designation):
13073 Now static, since they're not used elsewhere.
413bb2db 13074 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13075 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13076 (decode_coding_emacs_mule): Mark variables that gcc
13077 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13078 (detect_coding_iso_2022): Initialize a local variable that might
13079 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13080 this initialization is needed. (Bug#8211)
5f58e762
PE
13081 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13082 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13083 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13084 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13085 Remove unused macros.
f38b440c 13086
232b38b9 13087 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13088 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13089 * character.c (string_count_byte8): Likewise.
232b38b9 13090
fb90da1b
PE
13091 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13092 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13093
fb93dbc2
PE
13094 * chartab.c (copy_sub_char_table): Now static, since it's not used
13095 elsewhere.
5c156ace
PE
13096 (sub_char_table_ref_and_range, char_table_ref_and_range):
13097 Rename locals to avoid shadowing.
bbcd0949 13098 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13099
7d3b3862 13100 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13101 (BIDI_BOB): Remove unused macro.
7d3b3862 13102
6be7d3da
PE
13103 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13104 deduce are never used uninitialized.
c2ed9c8b 13105 * term.c (encode_terminal_code): Likewise.
6be7d3da 13106
75f8807f 13107 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13108
50938595
PE
13109 * tparam.h: New file.
13110 * term.c, tparam.h: Include it.
13111 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13112 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13113 Move these decls to tparam.h, and make them agree with what
13114 is actually in tparam.c. The previous trick of using incompatible
13115 decls in different modules does not conform to the C standard.
13116 All callers of tparam changed to use tparam's actual API.
13117 * tparam.c (tparam1, tparam, tgoto):
13118 Use const pointers where appropriate.
13119
fbceeba2
PE
13120 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13121 * cm.h (struct cm): Likewise.
13122 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13123 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13124 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13125 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13126 (turn_on_face, init_tty): Likewise.
13127 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13128
7f3f1250
PE
13129 * term.c (term_mouse_position): Rename local to avoid shadowing.
13130
e6ca6543
PE
13131 * alloc.c (mark_ttys): Move decl from here ...
13132 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13133
c40f8d15
AS
131342011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13135
13136 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13137
cfe0661d
JB
131382011-03-09 Juanma Barranquero <lekktu@gmail.com>
13139
13140 * search.c (compile_pattern_1): Remove argument regp, unused since
13141 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13142 (compile_pattern): Don't pass it.
13143
0afb4571
J
131442011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13145
13146 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13147 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13148 for ! HAVE_GTK3.
13149 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13150
13151 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13152
13153 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13154 gdk_window_get_screen, gdk_window_get_geometry,
13155 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13156 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13157 (xg_get_pixbuf_from_pixmap): New function.
13158 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13159 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13160 Call xg_get_pixbuf_from_pixmap instead of
13161 gdk_pixbuf_get_from_drawable.
13162 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13163 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13164 (xg_check_special_colors): Use GtkStyleContext and its functions
13165 for HAVE_GTK3.
13166 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13167 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13168 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13169 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13170 Call gtk_widget_get_preferred_size.
0afb4571
J
13171 (xg_frame_resized): gdk_window_get_geometry only takes 5
13172 parameters.
44f230aa
SM
13173 (xg_win_to_widget, xg_event_is_for_menubar):
13174 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13175 (xg_set_widget_bg): New function.
13176 (delete_cb): New function.
895009e1 13177 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13178 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13179 (xg_set_background_color): Call xg_set_widget_bg.
13180 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13181 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13182 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13183 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13184 if ! HAVE_GTK3.
13185 (update_frame_tool_bar): Call gtk_widget_hide.
13186 (xg_initialize): Use GDK_KEY_g.
13187
13188 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13189 if ! HAVE_GTK3
13190 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13191
13192 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13193 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13194 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13195
1c2cc4ef
JB
131962011-03-08 Juanma Barranquero <lekktu@gmail.com>
13197
13198 * w32xfns.c (select_palette): Check success of RealizePalette against
13199 GDI_ERROR, not zero.
13200
33383987 13201See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13202
13203;; Local Variables:
13204;; coding: utf-8
aac0c6e3
MR
13205;; End:
13206
2f097256 13207 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13208
13209 This file is part of GNU Emacs.
13210
13211 GNU Emacs is free software: you can redistribute it and/or modify
13212 it under the terms of the GNU General Public License as published by
13213 the Free Software Foundation, either version 3 of the License, or
13214 (at your option) any later version.
13215
13216 GNU Emacs is distributed in the hope that it will be useful,
13217 but WITHOUT ANY WARRANTY; without even the implied warranty of
13218 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13219 GNU General Public License for more details.
13220
13221 You should have received a copy of the GNU General Public License
13222 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.