Remove a couple of src/s files
[bpt/emacs.git] / src / ChangeLog
CommitLineData
45fa9c0f
GM
12012-06-12 Glenn Morris <rgm@gnu.org>
2
0d369729
GM
3 * s/gnu-kfreebsd.h, s/openbsd.h: Remove files.
4
45fa9c0f
GM
5 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
6 Move BROKEN_SIGIO to configure.
7
8 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
9 Move NO_TERMIO to configure.
10
0e25d334
CY
112012-06-12 Chong Yidong <cyd@gnu.org>
12
13 * image.c (imagemagick_load_image): Use MagickFlattenImage if
14 MagickMergeImageLayers is undefined. Use pixel pusher loop if
15 MagickExportImagePixels is undefined.
16
43682bb6
PE
172012-06-12 Paul Eggert <eggert@cs.ucla.edu>
18
19 * image.c (imagemagick_load_image): Remove unused label.
20
a9be7d2b
GM
212012-06-11 Glenn Morris <rgm@gnu.org>
22
23 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
24 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
25 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
26 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
27
3017f87f
SM
282012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
29
30 * alloc.c (make_byte_code): New function.
31 (Fmake_byte_code): Use it. Don't purify here.
32 * lread.c (read1): Use it as well to avoid extra allocation.
33
1b9b4cf4
CY
342012-06-11 Chong Yidong <cyd@gnu.org>
35
36 * image.c (imagemagick_load_image): Implement transparency.
37
95988fcf
AS
382012-06-10 Andreas Schwab <schwab@linux-m68k.org>
39
40 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
41 account for preceding backslashes. (Bug#11663)
42
cd4eb164
CY
432012-06-09 Chong Yidong <cyd@gnu.org>
44
45 * term.c: Support italics in capable terminals (Bug#9652).
46 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
47 (turn_on_face): Output using TS_enter_italic_mode if available.
48 Don't handle unused blinking and alt-charset cases.
49 (turn_off_face): Handle italic case; discard unused tty_blinking_p
50 and tty_alt_charset_p cases.
51 (tty_capable_p, init_tty): Support italics.
52
53 * termchar.h (struct tty_display_info): Add field for italics.
54 Remove unused blink field.
55
56 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
57 Handle slant.
58
59 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
60 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
61 tty_alt_charset_p. Add tty_italic_p.
62
ff88beb8
MA
632012-06-09 Michael Albinus <michael.albinus@gmx.de>
64
65 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
66 dbus_type_is_basic if available.
67 (xd_extract_signed, xd_extract_unsigned): Rename from
68 extract_signed and extract_unsigned, respectively. Adapt callers.
69
44286096
CY
702012-06-09 Chong Yidong <cyd@gnu.org>
71
1682701f
CY
72 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
73
44286096
CY
74 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
75 case (Bug#9752).
76
d86feb17
PE
772012-06-08 Paul Eggert <eggert@cs.ucla.edu>
78
79 * xdisp.c (vmessage): Treat frame message as multibyte.
80 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
81 would generate the diagnostic "Making \302\247 buffer-local while
82 let-bound!".
83
d5c20fe8
EZ
842012-06-08 Eli Zaretskii <eliz@gnu.org>
85
86 * dispnew.c (showing_window_margins_p): Undo last change, which
87 was done due to an inadvertent commit.
88 (adjust_frame_glyphs_for_frame_redisplay): Do call
89 showing_window_margins_p.
90
513749ee
SM
912012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
92
93 * eval.c (Fmake_var_non_special): New primitive.
94 (syms_of_eval): Defsubr it.
95 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
96
d4a8f5c1
JB
972012-06-08 Juanma Barranquero <lekktu@gmail.com>
98
99 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
100 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
101
8bbbc977
EZ
1022012-06-08 Eli Zaretskii <eliz@gnu.org>
103
104 * alloc.c (allocate_vectorlike): Fix last change.
105
f3372c87
DA
1062012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
107
108 Block-based vector allocation of small vectors.
109 * lisp.h (struct vectorlike_header): New field `nbytes',
110 adjust comment accordingly.
111 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
112 to denote vector blocks. Adjust users (live_vector_p,
113 mark_maybe_pointer, valid_lisp_object_p) accordingly.
114 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
115 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
116 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
117 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
118 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
119 (roundup_size): New constant.
120 (struct vector_block): New data type.
121 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 122 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
123 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
124 (sweep_vectors): New functions.
125 (allocate_vectorlike): Return `zero_vector' as the only vector of
126 0 items. Allocate new vector from block if vector size is less than
127 or equal to VBLOCK_BYTES_MAX.
128 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
129 (init_alloc_once): Add call to init_vectors.
130
4f18a4ed
SM
1312012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
132
133 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
134
86f158bc
PE
1352012-06-07 Paul Eggert <eggert@cs.ucla.edu>
136
137 * doprnt.c (doprnt): Truncate multibyte char correctly.
138 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
139 would mishandle a string argument "Xc" if X was a multibyte
140 character of length 2: it would truncate after X's first byte
141 rather than including all of X.
142
c5cfcbe0
CY
1432012-06-06 Chong Yidong <cyd@gnu.org>
144
145 * buffer.c (word_wrap): Doc fix.
146
c05cf390
PE
1472012-06-04 Paul Eggert <eggert@cs.ucla.edu>
148
149 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
150
0c3461de
GM
1512012-06-03 Glenn Morris <rgm@gnu.org>
152
153 * xdisp.c (tool-bar-style): Doc fix.
154
c71232db
UM
1552012-06-03 Ulrich Müller <ulm@gentoo.org>
156
157 * Makefile.in (PAXCTL): Define.
158 (temacs$(EXEEXT)): Disable memory randomization for the temacs
159 binary via PaX flags if the paxctl utility is available.
160 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
161 Restore PaX flags to their default. (Bug#11398)
162
383f7350
CY
1632012-06-03 Chong Yidong <cyd@gnu.org>
164
165 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
166 buffer (Bug#11226).
167
5f2c76c6
CY
1682012-06-03 Chong Yidong <cyd@gnu.org>
169
170 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
171 (note_mode_line_or_margin_highlight): If there is no help echo,
172 use mode-line-default-help-echo. Handle the case where the mouse
173 position is past the end of the mode line string.
174
175 * buffer.c (buffer_local_value_1): New function, split from
176 Fbuffer_local_value; can return Qunbound.
177 (Fbuffer_local_value): Use it.
178 (Vmode_line_format): Docstring tweaks.
179
773d47f6
PE
1802012-06-02 Paul Eggert <eggert@cs.ucla.edu>
181
182 * sysdep.c (system_process_attributes): Improve comment.
183
f2d6a3df
SM
1842012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
185
186 * keyboard.c: Export real-this-command to Elisp.
187 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
188 and DEFVAR it. Update all users.
189
63810350
PE
1902012-06-02 Paul Eggert <eggert@cs.ucla.edu>
191
7bd5c1f4
PE
192 * minibuf.c (Fassoc_string): Remove duplicate declaration.
193
63810350
PE
194 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
195 Convert pctcpu and pctmem to Lisp float properly.
196 Let the compiler fold better, as 100.0/0x8000 is exact.
197
a2821611
AS
1982012-06-02 Andreas Schwab <schwab@linux-m68k.org>
199
200 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
201 cons_block.
202
5fceba1d
PE
2032012-06-01 Paul Eggert <eggert@cs.ucla.edu>
204
205 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
206
c98ff5dd
DA
2072012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
208
209 For a 'struct window', replace some Lisp_Object fields to
210 bitfields where appropriate, remove unused fields.
211 * window.h (struct window): Remove unused 'last_mark_x' and
212 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
213 change it's type from Lisp_Object to bitfield.
214 Change type of 'force_start', 'optional_new_start',
215 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
216 fields from Lisp_Object to bitfield. Adjust users accordingly.
217
ca34e0be
PE
2182012-05-31 Paul Eggert <eggert@cs.ucla.edu>
219
220 Pacify gcc -Wdouble-precision when using Xaw.
221 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
222 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
223 Use 'float' consistently, rather than 'float' in most places
224 and 'double' in a couple of places.
225
efc00ab1 2262012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
227
228 * xdisp.c (handle_stop): Detect whether we have overlay strings
229 loaded by testing it->current.overlay_string_index to be
230 non-negative, instead of checking whether n_overlay_strings is
231 positive. (Bug#11587)
232
efc00ab1 2332012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
234
235 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
236
237 * doc.c (Fsubstitute_command_keys): Doc fix.
238
efc00ab1 2392012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
240
241 * search.c (search_buffer): Remove calls to
242 r_alloc_inhibit_buffer_relocation, as it is now called by
243 maybe_unify_char, which was the cause of relocation of buffer text
244 in bug#11519.
245
efc00ab1 2462012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
247
248 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
249 for the duration of call to load_charset, to avoid problems with
250 callers of maybe_unify_char that access buffer text through C
251 pointers.
252
253 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
254 decrement the inhibition flag, instead of just setting or
255 resetting it.
256
ba93a187
PE
2572012-05-31 Paul Eggert <eggert@cs.ucla.edu>
258
259 Remove obsolete '#define static' cruft.
260 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
261 This #undef was "temporary" in 2000; it is no longer needed
262 now that '#define static' has gone away.
263 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
264 (gray_bitmap_bits): Remove; no longer needed.
265 All uses replaced with definiens.
266 * xterm.c: Include "bitmaps/gray.xbm".
267
9e4bf381
PE
2682012-05-30 Paul Eggert <eggert@cs.ucla.edu>
269
270 Clean up __executable_start, monstartup when --enable-profiling.
271 The following changes affect the code only when profiling.
272 * dispnew.c (__executable_start): Rename from safe_bcopy.
273 Define only on platforms that need it.
274 * emacs.c: Include <sys/gmon.h> when profiling.
275 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
276 (__executable_start): Remove decl, since lisp.h does it now.
277 (safe_bcopy): Remove decl; no longer has that name.
278 (main): Coalesce #if into single bit of code, for simplicity.
279 Cast pointers to uintptr_t, since standard libraries want integers
280 and not pointers.
281 * lisp.h (__executable_start): New decl.
282
32d72c2f
GM
2832012-05-31 Glenn Morris <rgm@gnu.org>
284
285 * image.c (Fimagemagick_types): Doc fix.
286
baac5bc7
JM
2872012-05-30 Jim Meyering <meyering@redhat.com>
288
289 * callproc.c (Fcall_process_region): Include directory component
290 in mkstemp error message (Bug#11586).
291
72cb32cf
PE
2922012-05-30 Paul Eggert <eggert@cs.ucla.edu>
293
294 * alloc.c, lisp.h (make_pure_vector): Now static.
295
61b108cc
SM
2962012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
297
298 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
299 Move to byte-run.el.
300 (Fautoload): Do the hash-doc more carefully.
301 * data.c (Fdefalias): Purify definition, except for keymaps.
302 (Qdefun): Move from eval.c.
303 * lisp.h (Qdefun): Remove.
304 * lread.c (read1): Tiny simplification.
305
471fe23d
TN
3062012-05-29 Troels Nielsen <bn.troels@gmail.com>
307
934f3f58 308 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
309 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
310 Bug#9642, but explicitly check that the buffer the overlay would
311 be moved to is live and rearrange lines to make sure that errors
312 will not put the overlay in an inconsistent state.
313 (Fdelete_overlay): Cosmetics.
314
85d0efd1
EZ
3152012-05-28 Eli Zaretskii <eliz@gnu.org>
316
317 * w32term.c (my_bring_window_to_top): New function.
318 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
319 could be different from the original one.
320 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
321 (Bug#11513)
322
323 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
324 by calling BringWindowToTop.
325
326 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
327 (WM_EMACS_END): Increase by one.
328
da92a98c
PE
3292012-05-28 Paul Eggert <eggert@cs.ucla.edu>
330
331 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
332 This avoids undefined behavior that might cause the eassert
333 to not catch an out-of-range value.
334
74d1f848
JB
3352012-05-28 Juanma Barranquero <lekktu@gmail.com>
336
337 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
338 Update dependencies.
339
9e1a06fc
EZ
3402012-05-27 Eli Zaretskii <eliz@gnu.org>
341
342 * bidi.c (bidi_mirror_char): Fix last change.
343
f3dd7312
AS
3442012-05-27 Andreas Schwab <schwab@linux-m68k.org>
345
346 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
347 when referring to sectname field in printf format.
348
81899c91
PE
3492012-05-27 Paul Eggert <eggert@cs.ucla.edu>
350
57b81a9f
PE
351 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
352 Only r_alloc_inhibit_buffer_relocation needed to be added;
353 the others were already declared.
354
81899c91
PE
355 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
356 before checking whether it's out of range. Put the check inside
357 eassert. See
358 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
359
33017faf 3602012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
361
362 * callproc.c (Fcall_process): Restore a line that was accidentally
363 commented out in the 2011-02-13 change (bug#11547).
364
33017faf 3652012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
366
367 * lisp.h [REL_ALLOC]: Add prototypes for external functions
368 defined on ralloc.c.
369
370 * buffer.c [REL_ALLOC]: Remove prototypes of
371 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
372 they are now on lisp.h.
373
374 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
375
376 * search.c (search_buffer): Use it to inhibit relocation of buffer
377 text while re_search_2 is doing its job, because re_search_2 is
378 passed C pointers to buffer text. (Bug#11519)
379
23415acf
EZ
380 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
381 Update value to 24.
382
44e27368
EZ
383 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
384 state after an additional call to move_it_in_display_line_to, keep
385 the values of it->max_ascent and it->max_descent found for the
386 entire line.
387 (pos_visible_p): Revert the comparison against bottom_y to what it
388 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
389 (Bug#11464)
390
c1892f11
PE
3912012-05-26 Paul Eggert <eggert@cs.ucla.edu>
392
393 Fix coding-related core dumps with gcc -ftrapv.
394 The code was computing A - B, where A and B are pointers, and B is
395 random garbage. This can lead to core dumps on platforms that
396 have special pointer registers, and it also leads to core dumps on
397 x86-64 when compiled with gcc -ftrapv. The fix is to compute
398 A - B only when B is initialized properly.
399 * coding.c (coding_set_source, coding_set_destination): Return void.
400 (coding_change_source, coding_change_destinations): New functions,
401 with the old behaviors of coding_set_source and coding_set_destination.
402 All callers that need an offset changed to use these new functions.
403
eb7afdad
GM
4042012-05-26 Glenn Morris <rgm@gnu.org>
405
406 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
407
f12fdf02
EZ
4082012-05-26 Eli Zaretskii <eliz@gnu.org>
409
53a63be6 410 Extend mouse support on W32 text-mode console.
61b108cc
SM
411 * xdisp.c (draw_row_with_mouse_face):
412 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 413
eb3f6f01 414 * w32console.c: Include window.h.
61b108cc
SM
415 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
416 New functions.
eb3f6f01
EZ
417 (initialize_w32_display): Initialize mouse-highlight data.
418
53a63be6
EZ
419 * w32inevt.c: Include termchar.h and window.h.
420 (do_mouse_event): Support mouse-autoselect-window. When the mouse
421 moves, call note_mouse_highlight. If help_echo changed, call
422 gen_help_event to produce help-echo message in the echo area.
423 Call clear_mouse_face if mouse_face_hidden is set in the mouse
424 highlight info.
425
4cfd81f6
PE
4262012-05-26 Paul Eggert <eggert@cs.ucla.edu>
427
428 * lread.c (read1): Simplify slightly to avoid an overflow warning
429 with GCC 4.7.0 on x86-64.
430
4446092a
EZ
4312012-05-26 Eli Zaretskii <eliz@gnu.org>
432
433 * bidi.c (bidi_mirror_char): Revert last change: an int is
434 definitely wide enough here.
435
42b2a986 4362012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 437
42b2a986 438 Fix integer width and related bugs (Bug#9874).
eb106a49 439 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
440 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
441 (string_bytes, check_sblock, allocate_string_data):
442 (compact_small_strings, Fmake_bool_vector, make_string)
443 (make_unibyte_string, make_multibyte_string)
444 (make_string_from_bytes, make_specified_string)
445 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
446 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
447 (mark_vectorlike):
448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
449 (allocate_pseudovector):
450 Use int, not EMACS_INT, where int is wide enough.
451 (inhibit_garbage_collection, Fgarbage_collect):
452 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
453 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
454 int might not be wide enough.
455 (bidi_cache_search, bidi_cache_find, bidi_init_it)
456 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
457 (bidi_at_paragraph_end, bidi_find_paragraph_start)
458 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
459 (bidi_level_of_next_char, bidi_move_to_visually_next):
460 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
461 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
462 (Fkill_buffer, Fset_buffer_major_mode)
463 (advance_to_char_boundary, Fbuffer_swap_text)
464 (Fset_buffer_multibyte, overlays_at, overlays_in)
465 (overlay_touches_p, struct sortvec, record_overlay_string)
466 (overlay_strings, recenter_overlay_lists)
467 (adjust_overlays_for_insert, adjust_overlays_for_delete)
468 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
469 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
470 (Foverlay_recenter, last_overlay_modification_hooks_used)
471 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
472 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
473 (validate_region): Omit unnecessary test for b <= e,
474 since that's guaranteed by the previous test.
d311d28c
PE
475 (adjust_overlays_for_delete): Avoid pos + length overflow.
476 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
477 (report_overlay_modification):
478 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
479 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
480 Omit pointer cast, which isn't needed anyway, and doesn't work
481 after the EMACS_INT -> ptrdiff_t change.
02481186 482 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
483 * buffer.h: Adjust decls to match defn changes elsewhere.
484 (struct buffer_text, struct buffer):
485 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
486 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
487 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
488 not int, to avoid needless 32-bit limit on 64-bit hosts.
489 (exec_byte_code): Use tighter memory-full test, one that checks
490 for alloca overflow. Don't compute the address of the object just
491 before an array, as that's not portable. Use EMACS_INT, not
492 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
493 * callint.c (Fcall_interactively):
494 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
495 * callproc.c (call_process_kill, Fcall_process):
496 Don't assume pid_t fits into an Emacs fixnum.
497 (call_process_cleanup, Fcall_process, child_setup):
498 Don't assume pid_t fits into int.
499 (call_process_cleanup, Fcall_process, delete_temp_file)
500 (Fcall_process_region):
501 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
502 (Fcall_process): Simplify handling of volatile integers.
503 Use int, not EMACS_INT, where int will do.
504 * casefiddle.c (casify_object, casify_region, operate_on_word)
505 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
507 (casify_object): Avoid integer overflow when overallocating buffer.
508 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 509 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
510 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
511 * category.h (CATEGORYP): Don't assume arg is nonnegative.
512 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
513 integers are now checked earlier. All uses replaced with XINT.
514 (ccl_driver):
515 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
516 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
517 (ccl_driver, Fregister_code_conversion_map):
518 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
519 (resolve_symbol_ccl_program): Check that vector header is in range.
520 Always copy the vector, so that we can check its contents reliably
521 now rather than having to recheck each instruction as it's being
522 executed. Check that vector words fit in 'int'.
523 (ccl_get_compiled_code, Fregister_ccl_program)
524 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
525 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
526 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
527 contents are in range.
528 (Fccl_execute_on_string): Check that status is in range.
529 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
530 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
531 Accept and return EMACS_INT, not int, because callers can pass values
532 out of 'int' range.
533 (c_string_width, strwidth, lisp_string_width, chars_in_text)
534 (multibyte_chars_in_text, parse_str_as_multibyte)
535 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
536 (str_as_unibyte, str_to_unibyte, string_count_byte8)
537 (string_escape_byte8, Fget_byte):
538 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 539 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
540 avoid mishandling large integers.
541 * character.h: Adjust decls to match defn changes elsewhere.
542 * charset.c (load_charset_map_from_file, find_charsets_in_text)
543 (Ffind_charset_region):
544 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
545 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
546 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 547 Don't assume fixnum fits in int.
d311d28c
PE
548 (load_charset_map_from_vector, Fmap_charset_chars):
549 Remove now-unnecessary CHECK_NATNUMs.
550 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
551 Don't rely on undefined behavior with signed left shift overflow.
552 Don't assume unsigned int fits into fixnum, or that fixnum fits
553 into unsigned int. Don't require max_code to be a valid fixnum;
554 that's not true for gb10830 4-byte on a 32-bit host. Allow
555 invalid_code to be a cons, for the same reason. Require code_offset
556 to be a character. Avoid int overflow if max_char is close
557 to INT_MAX.
558 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
559 this is intended anyway and avoids some undefined behavior.
560 (load_charset_map): Pass unsigned, not int, as 2nd arg of
561 INDEX_TO_CODE_POINT, as that's what it expects.
562 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
563 * charset.h (DECODE_CHAR): Return int, not unsigned;
564 this is what was intended anyway, and it avoids undefined behavior.
565 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
566 integer-overflow issues.
567 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
568 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
569 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
570 * chartab.c (Fmake_char_table, Fset_char_table_range)
571 (uniprop_get_decoder, uniprop_get_encoder):
572 Don't assume fixnum fits in int.
573 * cmds.c (move_point): New function, that does the gist of
574 Fforward_char and Fbackward_char, but does so while checking
575 for integer overflow more accurately.
c96e5d6a 576 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
577 (Fforward_line, Fend_of_line, internal_self_insert)
578 (internal_self_insert):
579 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
580 Fix a FIXME, by checking for integer overflow when calculating
581 target_clm and actual_clm.
582 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 583 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
584 (ASSURE_DESTINATION, coding_alloc_by_realloc)
585 (coding_alloc_by_making_gap, alloc_destination)
586 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
587 (encode_coding_utf_16, detect_coding_emacs_mule)
588 (decode_coding_emacs_mule, encode_coding_emacs_mule)
589 (detect_coding_iso_2022, decode_coding_iso_2022)
590 (encode_invocation_designation, encode_designation_at_bol)
591 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
592 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
593 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
594 (encode_coding_ccl, encode_coding_raw_text)
595 (detect_coding_charset, decode_coding_charset)
596 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
597 (produce_composition, produce_charset, produce_annotation)
598 (decode_coding, handle_composition_annotation)
599 (handle_charset_annotation, consume_chars, decode_coding_gap)
600 (decode_coding_object, encode_coding_object, detect_coding_system)
601 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
602 (code_convert_region, code_convert_string)
8f50130c
PE
603 (Fdefine_coding_system_internal)
604 (coding_set_source, coding_set_destination):
d311d28c
PE
605 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
606 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
607 (Fdefine_coding_system_internal):
608 Don't assume fixnums fit in int.
609 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 610 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
611 (Funencodable_char_position, Fcheck_coding_systems_region)
612 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 613 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 614 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 615 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 616 Don't access memory outside of the args array.
d311d28c 617 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
618 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
619 result of ENCODE_CHAR.
d311d28c
PE
620 * coding.h: Adjust decls to match defn changes elsewhere.
621 (struct coding_system):
622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
623 * composite.c (get_composition_id, find_composition)
624 (run_composition_function, update_compositions)
625 (compose_text, composition_gstring_put_cache)
626 (composition_gstring_p, composition_gstring_width)
627 (fill_gstring_header, fill_gstring_body, autocmp_chars)
628 (composition_compute_stop_pos, composition_reseat_it)
629 (composition_update_it, struct position_record)
630 (find_automatic_composition, composition_adjust_point)
631 (Fcomposition_get_gstring, Ffind_composition_internal):
632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
633 (update_compositions):
634 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
635 * composite.h: Adjust decls to match defn changes elsewhere.
636 (struct composition):
637 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
638 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
639 Do not attempt to compute the address of the object just before a
640 buffer; this is not portable.
641 (Faref, Faset):
642 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
643 (Faset): Use int, not EMACS_INT, where int is wide enough.
644 (Fstring_to_number): Don't assume fixnums fit in int.
645 (Frem): Don't assume arg is nonnegative.
646 * dbusbind.c (xd_append_arg): Check for integers out of range.
647 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 648 (extract_signed, extract_unsigned): New functions.
243e0530
PE
649 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
650 (xd_get_connection_references): Return ptrdiff_t, not int.
651 All uses changed.
652 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
653 (xd_read_message_1):
654 Use int, not unsigned, where the dbus API uses int.
655 (Fdbus_message_internal): Don't overflow mtype.
656 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
657 * dired.c (directory_files_internal, file_name_completion, scmp)
658 (file_name_completion_stat):
659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
660 (file_name_completion): Don't overflow matchcount.
661 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
662 * dispextern.h: Adjust decls to match defn changes elsewhere.
663 (struct text_pos, struct glyph, struct bidi_saved_info)
664 (struct bidi_string_data, struct bidi_it, struct composition_it)
665 (struct it):
666 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
667 (struct display_pos, struct composition_it, struct it):
668 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
669 * dispnew.c (increment_matrix_positions)
670 (increment_row_positions, mode_line_string)
671 (marginal_area_string):
672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 673 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
674 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
675 (duration_to_sec_usec): New function, to check for overflow better.
676 (Fsleep_for, sit_for): Use it.
677 * doc.c (get_doc_string, store_function_docstring):
678 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
679 (get_doc_string, Fsnarf_documentation):
680 Use int, not EMACS_INT, where int is wide enough.
681 (get_doc_string):
682 Use SAFE_ALLOCA, not alloca.
683 Check for overflow when converting EMACS_INT to off_t.
684 * doprnt.c (doprnt):
685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
686 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
687 Don't assume uid_t fits into fixnum.
688 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
689 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
690 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
691 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
692 (general_insert_function)
693 (Finsert_char, make_buffer_string, make_buffer_string_both)
694 (update_buffer_properties, Fbuffer_substring)
695 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
696 (Fsubst_char_in_region, check_translation)
697 (Ftranslate_region_internal, save_restriction_restore, Fformat)
698 (transpose_markers, Ftranspose_regions):
699 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
700 (clip_to_bounds): Move to lisp.h as an inline function).
701 (Fconstrain_to_field): Don't assume integers are nonnegative.
702 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
703 (Fsubst_char_in_region, Fsave_restriction):
704 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
705 (Femacs_pid): Don't assume pid_t fits into fixnum.
706 (lo_time): Use int, not EMACS_INT, when int suffices.
707 (lisp_time_argument): Check for usec out of range.
708 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
709 (Fuser_login_name, Fuser_full_name): Signal an error
710 if a uid argument is out of range, rather than relying on
711 undefined behavior.
c8d5c857
PE
712 (Fformat_time_string): Remove now-unnecessary check.
713 lisp_time_argument checks for out-of-range usec now.
243e0530 714 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
715 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
716 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
717 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
718 (init_cmdargs, Fdump_emacs):
719 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
720 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
721 the bottom (typically) 32 bits of the fixnum.
722 * eval.c (specpdl_size, call_debugger):
723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
724 (when_entered_debugger, Fbacktrace_debug):
725 Don't assume fixnum can fit in int.
726 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
727 the object just before a buffer; this is not portable.
728 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
729 (grow_specpdl, unbind_to):
730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
731 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
732 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 733 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
734 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
735 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
736 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
737 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
738 (a_write, e_write):
739 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
740 (Fcopy_file, non_regular_nbytes, read_non_regular)
741 (Finsert_file_contents):
742 Use int, not EMACS_INT, where int is wide enough.
743 (READ_BUF_SIZE): Verify that it fits in int.
744 (Finsert_file_contents): Check that counts are in proper range,
745 rather than assuming fixnums fit into ptrdiff_t etc.
746 Don't assume fixnums fit into int.
125b3835 747 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
748 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
749 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
750 (string_char_to_byte, string_byte_to_char)
751 (string_make_multibyte, string_to_multibyte)
752 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
753 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
754 (substring_both, Fdelete, internal_equal, Ffillarray)
755 (Fclear_string, mapcar1)
756 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
757 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
758 (larger_vector, make_hash_table, maybe_resize_hash_table)
759 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
760 (Fmaphash, secure_hash):
761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
762 (concat): Check for string index and length overflow.
763 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
764 (Frequire):
765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
766 (larger_vector): New API (vec, incr_min, size_max) replaces old
767 one (vec, new_size, init). This catches size overflow.
768 INIT was removed because it was always Qnil.
769 All callers changed.
770 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
771 the upper bound on a hash table index size.
772 (make_hash_table, maybe_resize_hash_table): Use it.
773 (secure_hash): Computer start_byte and end_byte only after
774 they're known to be in ptrdiff_t range.
775 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
776 (Ffont_get_glyphs, Ffont_at):
777 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
778 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
779 (Flist_fonts, Fopen_font):
780 Don't assume fixnum can fit in int.
781 (check_gstring): Don't assume index can fit in int.
782 (font_match_p): Check that fixnum is a character, not a nonnegative
783 fixnum, since the later code needs to stuff it into an int.
784 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
785 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
786 conversion overflow issues.
787 (Fopen_font): Check for integer out of range.
788 (Ffont_get_glyphs): Don't assume index can fit in int.
789 * font.h: Adjust decls to match defn changes elsewhere.
790 * fontset.c (reorder_font_vector): Redo score calculation to avoid
791 integer overflow.
792 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
793 printmax_t, where ptrdiff_t is wide enough.
794 (Finternal_char_font):
795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
796 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
797 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
798 (Fset_frame_position, x_set_frame_parameters)
799 (x_set_line_spacing, x_set_border_width)
800 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
801 Check that fixnums are in proper range for system types.
802 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
803 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
804 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
805 Use SAFE_ALLOCA_LISP, not alloca.
806 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
807 intptr_t is wide enough.
808 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
809 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
810 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
811 Check for fixnum out of range.
812 * ftfont.c (ftfont_list): Don't assume index fits in int.
813 Check that fixnums are in proper range for system types.
814 (ftfont_shape_by_flt):
815 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
816 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
817 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
818 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
819 Check that fixnums are in proper range for system types.
820 * gnutls.h: Adjust decls to match defn changes elsewhere.
821 * gtkutil.c (xg_dialog_run):
822 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
823 (update_frame_tool_bar):
824 Check that fixnums are in proper range for system types.
825 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 826 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
827 * indent.c (last_known_column, last_known_column_point):
828 (current_column_bol_cache):
829 (skip_invisible, current_column, check_display_width):
830 (check_display_width, scan_for_column, current_column_1)
831 (Findent_to, Fcurrent_indentation, position_indentation)
832 (indented_beyond_p, Fmove_to_column, compute_motion):
833 (Fcompute_motion, Fvertical_motion):
834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
835 (last_known_column_modified): Use EMACS_INT, not int.
836 (check_display_width):
837 (Fcompute_motion):
838 Check that fixnums and floats are in proper range for system types.
839 (compute_motion): Don't assume index or fixnum fits in int.
840 (compute_motion, Fcompute_motion):
841 Use int, not EMACS_INT, when it is wide enough.
842 (vmotion): Omit local var start_hpos that is always 0; that way
843 we don't need to worry about overflow in expressions involving it.
844 * indent.h: Adjust decls to match defn changes elsewhere.
845 (struct position):
846 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
847 Use int, not EMACS_INT, where int is wide enough.
848 Remove unused members ovstring_chars_done and tab_offset;
849 all uses removed.
850 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
851 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
852 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
853 (make_gap, copy_text, insert, insert_and_inherit)
854 (insert_before_markers, insert_before_markers_and_inherit)
855 (insert_1, count_combining_before, count_combining_after)
856 (insert_1_both, insert_from_string)
857 (insert_from_string_before_markers, insert_from_string_1)
858 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
859 (adjust_after_replace, adjust_after_insert, replace_range)
860 (replace_range_2, del_range, del_range_1, del_range_byte)
861 (del_range_both, del_range_2, modify_region)
862 (prepare_to_modify_buffer, signal_before_change)
863 (signal_after_change, Fcombine_after_change_execute):
864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
865 * intervals.c (traverse_intervals, rotate_right, rotate_left)
866 (balance_an_interval, split_interval_right, split_interval_left)
867 (find_interval, next_interval, update_interval)
868 (adjust_intervals_for_insertion, delete_node, delete_interval)
869 (interval_deletion_adjustment, adjust_intervals_for_deletion)
870 (static_offset_intervals, offset_intervals)
871 (merge_interval_right, merge_interval_left, make_new_interval)
872 (graft_intervals_into_buffer, temp_set_point_both)
873 (temp_set_point, set_point, adjust_for_invis_intang)
874 (set_point_both, move_if_not_intangible, get_property_and_range)
875 (get_local_map, copy_intervals, copy_intervals_to_string)
876 (compare_string_intervals, set_intervals_multibyte_1):
877 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
878 * intervals.h: Adjust decls to match defn changes elsewhere.
879 (struct interval):
880 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
881 * keyboard.c (this_command_key_count, this_single_command_key_start)
882 (before_command_key_count, before_command_echo_length, echo_now)
883 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
884 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
885 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
886 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
888 (last_non_minibuf_size, last_point_position, echo_truncate)
889 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
890 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
891 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
892 (stuff_buffered_input):
893 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
894 (last_auto_save, command_loop_1, read_char):
895 Use EMACS_INT, not int, to avoid integer overflow.
896 (record_char): Avoid overflow in total_keys computation.
897 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
898 * keyboard.h: Adjust decls to match defn changes elsewhere.
899 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
900 (Fkey_description, Fdescribe_vector, Flookup_key):
901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
902 (click_position): New function, to check that positions are in range.
903 (Fcurrent_active_maps):
904 (describe_command):
905 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
906 (Faccessible_keymaps, Fkey_description):
907 (preferred_sequence_p):
908 Don't assume fixnum can fit into int.
909 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
910 Check for integer overflow in size calculations.
911 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
912 avoid mishandling large integers.
913 * lisp.h: Adjust decls to match defn changes elsewhere.
914 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
915 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
916 (struct Lisp_Marker):
917 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
918 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
919 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
920 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
921 All callers changed.
922 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
923 Assume the arg has valid form, since it always does.
924 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
925 unsigned integer system type.
926 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
927 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
928 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
929 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
930 (duration_to_sec_usec): New decl.
931 * lread.c (read_from_string_index, read_from_string_index_byte)
932 (read_from_string_limit, readchar, unreadchar, openp)
933 (read_internal_start, read1, oblookup):
934 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
935 (Fload, readevalloop, Feval_buffer, Feval_region):
936 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
937 (openp): Check for out-of-range argument to 'access'.
938 (read1): Use int, not EMACS_INT, where int is wide enough.
939 Don't assume fixnum fits into int.
6efdadfd 940 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
941 (read_filtered_event): Use duration_to_sec_usec
942 to do proper overflow checking on durations.
d311d28c
PE
943 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
944 in size calculation.
945 (Fexecute_kbd_macro):
946 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
947 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
948 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
949 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
950 (set_marker_both, set_marker_restricted_both, marker_position)
951 (marker_byte_position, Fbuffer_has_markers_at):
952 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
953 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 954 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
955 It now merely ensures that the menu is large enough, without
956 necessarily growing it, as this avoids some integer overflow issues.
957 All callers changed.
958 (keymap_panes, parse_single_submenu, Fx_popup_menu):
959 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
960 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
961 Use SAFE_ALLOCA_LISP, not alloca.
962 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
963 to EMACS_INT. Check that fixnums are in proper range for system types.
964 * minibuf.c (minibuf_prompt_width, string_to_object)
965 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
966 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
967 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
968 (get_minibuffer, read_minibuf_unwind):
969 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
970 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
971 this simplifies overflow checking. All callers changed.
972 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
973 (Ftest_completion):
974 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
975 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
976 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
977 Check that fixnums are in proper range for system types.
978 (Fx_create_frame, Fx_show_tip):
979 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
980 * nsfont.m (ns_findfonts, nsfont_list_family):
981 Don't assume fixnum fits in long.
982 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
983 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
984 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
985 wide enough.
17fdb222 986 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
987 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
988 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
989 (PRINTDECLARE, PRINTPREPARE):
990 (strout, print_string):
991 (print, print_preprocess, print_check_string_charset_prop)
992 (print_object):
993 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
994 (PRINTDECLARE):
995 (temp_output_buffer_setup, Fprin1_to_string, print_object):
996 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
997 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 998 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 999 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1000 (print_error_message): Use SAFE_ALLOCA, not alloca.
1001 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1002 (print_depth, new_backquote_output, print_number_index):
1003 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1004 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1005 (Fset_process_window_size, Fformat_network_address)
1006 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1007 (sigchld_handler):
d311d28c 1008 Check that fixnums are in proper range for system types.
d44287d4 1009 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1010 Check for process-ids out of pid_t range rather than relying on
1011 undefined behavior.
e4d81efc 1012 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1013 (Fformat_network_address, read_process_output, send_process)
1014 (Fprocess_send_region, status_notify):
1015 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1016 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1017 (wait_reading_process_output, read_process_output, exec_sentinel):
1018 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1019 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1020 (Faccept_process_output): Use duration_to_sec_usec to do proper
1021 overflow checking on durations.
dde14581
PE
1022 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1023 Don't assume pid_t fits in int.
02481186
PE
1024 * process.h (struct Lisp_Process): Members tick and update_tick
1025 are now of type EMACS_INT, not int.
b62b53e8
PE
1026 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1027 configured --with-wide-int.
d311d28c
PE
1028 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1029 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1030 * search.c (looking_at_1, string_match_1):
1031 (fast_string_match, fast_c_string_match_ignore_case)
1032 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1033 (scan_newline, find_before_next_newline, search_command)
1034 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1035 (set_search_regs, wordify):
1036 (Freplace_match):
1037 (Fmatch_data):
1038 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1039 (string_match_1, search_buffer, set_search_regs):
1040 (Fmatch_data):
1041 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1042 (wordify): Check for overflow in size calculation.
1043 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1044 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1045 Check that fixnums are in proper range for system types.
1046 * sound.c (struct sound_device)
1047 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1048 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1049 (Fplay_sound_internal):
1050 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1051 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1052 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1053 (Fparse_partial_sexp):
1054 Don't assume fixnums can fit in int.
1055 (struct lisp_parse_state, find_start_pos, find_start_value)
1056 (find_start_value_byte, find_start_begv)
1057 (update_syntax_table, char_quoted, dec_bytepos)
1058 (find_defun_start, prev_char_comend_first, back_comment):
1059 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1060 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1061 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1062 (Finternal_describe_syntax_value): Check that match_lisp is a
1063 character, not an integer, since the code stuffs it into int.
1064 (scan_words, scan_sexps_forward):
1065 Check that fixnums are in proper range for system types.
1066 (Fforward_word):
1067 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1068 (scan_sexps_forward):
1069 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1070 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1071 * syntax.h: Adjust decls to match defn changes elsewhere.
1072 (struct gl_state_s):
1073 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1074 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1075 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1076 * sysdep.c (wait_for_termination_1, wait_for_termination)
1077 (interruptible_wait_for_termination, mkdir):
1078 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1079 (emacs_read, emacs_write):
1080 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1081 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1082 and double all fit in int.
d311d28c
PE
1083 * term.c (set_tty_color_mode):
1084 Check that fixnums are in proper range for system types.
1085 * termhooks.h (struct input_event):
1086 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1087 * textprop.c (validate_interval_range, interval_of)
1088 (Fadd_text_properties, set_text_properties_1)
1089 (Fremove_text_properties, Fremove_list_of_text_properties)
1090 (Ftext_property_any, Ftext_property_not_all)
1091 (copy_text_properties, text_property_list, extend_property_ranges)
1092 (verify_interval_modification):
1093 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1094 (Fnext_single_char_property_change)
1095 (Fprevious_single_char_property_change):
1096 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1097 (copy_text_properties):
1098 Check for integer overflow in index calculation.
d311d28c
PE
1099 * undo.c (last_boundary_position, record_point, record_insert)
1100 (record_delete, record_marker_adjustment, record_change)
1101 (record_property_change):
1102 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1103 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1104 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1105 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1106 (Fx_hide_tip, Fx_file_dialog):
1107 * w32menu.c (set_frame_menubar):
1108 Use ptrdiff_t, not int, for consistency with rest of code.
1109 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1110 (select_window, Fdelete_other_windows_internal)
1111 (window_scroll_pixel_based, window_scroll_line_based)
1112 (Frecenter, Fset_window_configuration):
1113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1114 (Fset_window_hscroll, run_window_configuration_change_hook)
1115 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1116 (Fscroll_other_window, Frecenter):
d311d28c
PE
1117 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1118 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1119 Don't assume fixnum fits in int.
1120 (Fset_window_scroll_bars):
1121 Check that fixnums are in proper range for system types.
1122 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1123 (string_pos, c_string_pos, number_of_chars, init_iterator)
1124 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1125 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1126 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1127 (face_before_or_after_it_pos, handle_invisible_prop)
1128 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1129 (display_prop_intangible_p, string_buffer_position_lim)
1130 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1131 (get_overlay_strings_1, get_overlay_strings)
1132 (iterate_out_of_display_property, forward_to_next_line_start)
1133 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1134 (get_next_display_element, set_iterator_to_next)
1135 (get_visually_first_element, compute_stop_pos_backwards)
1136 (handle_stop_backwards, next_element_from_buffer)
1137 (move_it_in_display_line_to, move_it_in_display_line)
1138 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1139 (add_to_log, message_dolog, message_log_check_duplicate)
1140 (message2, message2_nolog, message3, message3_nolog
1141 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1142 (current_message_1, truncate_echo_area, truncate_message_1)
1143 (set_message, set_message_1, store_mode_line_noprop)
1144 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1145 (text_outside_line_unchanged_p, check_point_in_composition)
1146 (reconsider_clip_changes)
1147 (redisplay_internal, set_cursor_from_row, try_scrolling)
1148 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1149 (redisplay_window, find_last_unchanged_at_beg_row)
1150 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1151 (trailing_whitespace_p, find_row_edges, display_line)
1152 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1153 (display_mode_element, store_mode_line_string)
1154 (pint2str, pint2hrstr, decode_mode_spec)
1155 (display_count_lines, display_string, draw_glyphs)
1156 (x_produce_glyphs, x_insert_glyphs)
1157 (rows_from_pos_range, mouse_face_from_buffer_pos)
1158 (fast_find_string_pos, mouse_face_from_string_pos)
1159 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1160 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1161 (safe_call, init_from_display_pos, handle_fontified_prop)
1162 (handle_single_display_spec, load_overlay_strings)
1163 (with_echo_area_buffer, setup_echo_area_for_printing)
1164 (display_echo_area, echo_area_display)
1165 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1166 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1167 (redisplay_window, dump_glyph_row, display_mode_line)
1168 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1169 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1170 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1171 (handle_single_display_spec, build_desired_tool_bar_string)
1172 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1173 (get_specified_cursor_type):
1174 Check that fixnums are in proper range for system types.
1175 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1176 (Flookup_image_map):
1177 Don't assume fixnums fit in int.
1178 (compare_overlay_entries):
1179 Avoid mishandling comparisons due to subtraction overflow.
1180 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1181 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1182 (handle_tool_bar_click):
1183 Use int, not unsigned, since we prefer signed and the signedness
1184 doesn't matter here.
1185 (get_next_display_element, next_element_from_display_vector):
1186 Use int, not EMACS_INT, when int is wide enough.
1187 (start_hourglass): Use duration_to_sec_usec to do proper
1188 overflow checking on durations.
1189 * xfaces.c (Fbitmap_spec_p):
1190 Check that fixnums are in proper range for system types.
1191 (compare_fonts_by_sort_order):
1192 Avoid mishandling comparisons due to subtraction overflow.
1193 (Fx_family_fonts, realize_basic_faces):
1194 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1195 (Fx_family_fonts):
1196 Don't assume fixnum fits in int.
1197 Use SAFE_ALLOCA_LISP, not alloca.
1198 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1199 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1200 (face_at_buffer_position, face_for_overlay_string)
1201 (face_at_string_position):
1202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1203 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1204 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1205 (Fx_show_tip):
1206 Check that fixnums are in proper range for system types.
1207 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1208 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1209 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1210 (Fx_change_window_property): Don't assume fixnums fit in int.
1211 * xfont.c (xfont_chars_supported):
1212 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1213 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1214 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1215 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1216 * xml.c (parse_region):
1217 * xrdb.c (magic_file_p):
1218 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1219 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1220 (x_get_local_selection, x_reply_selection_request)
1221 (x_handle_selection_request, wait_for_property_change):
1222 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1223 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1224 short is wide enough.
1225 (x_send_client_event): Don't assume fixnum fits in int.
1226 * xterm.c (x_x_to_emacs_modifiers):
1227 Don't assume EMACS_INT overflows nicely into int.
1228 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1229 may come from Lisp.
1230 (handle_one_xevent): NATNUMP can eval its arg twice.
1231 (x_connection_closed):
1232 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1233 * xterm.h: Adjust decls to match defn changes elsewhere.
1234 (struct scroll_bar): Use struct vectorlike_header
1235 rather than rolling our own approximation.
1236 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1237
c6574eb5
GM
12382012-05-25 Glenn Morris <rgm@gnu.org>
1239
1240 * lisp.mk (lisp): Update for more files being compiled now.
1241
e8d32c7e
SM
12422012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1243
48def666
SM
1244 * lread.c: Remove `read_pure' which makes no difference.
1245 (read_pure): Remove var.
1246 (unreadpure): Remove function.
1247 (readevalloop): Don't call read_list with -1 flag.
1248 (read1, read_vector): Don't test read_pure any more.
1249 (read_list): Simplify.
1250
e8d32c7e
SM
1251 * fileio.c, character.h: Minor style tweaks.
1252
4b2addb7
DA
12532012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1254
1255 * window.h (clip_changed): Remove useless declaration.
1256
584461b2
JB
12572012-05-22 Juanma Barranquero <lekktu@gmail.com>
1258
1259 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1260 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1261
34374650
PE
12622012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1263
1264 Remove src/m/*.
1265 This directory predates autoconf and is no longer needed nowadays.
1266 Move its few remaining bits of functionality to where they're needed.
1267 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1268 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1269 * m/template.h: Remove.
1270 * Makefile.in (M_FILE): Remove. All uses removed.
1271 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1272 * lisp.h (USE_LSB_TAG):
1273 * mem-limits.h (EXCEEDS_LISP_PTR):
1274 Use VAL_MAX, not VALBITS, in #if.
1275 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1276 (EMACS_UINT): Define unconditionally now.
1277 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1278 (BITS_PER_EMACS_INT): New constants, replacing
1279 what used to be in config.h, but not useful in #if.
1280 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1281 define them any more.
1282 (VAL_MAX): New macro.
1283 (VALMASK): Use it.
1284 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1285 BITS_PER_EMACS_INT, in #if.
1286 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1287 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1288 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1289 * s/ms-w32.h (DATA_START):
1290 Move here from removed file m/intel386.h.
1291 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1292 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1293
261cb4bb
PE
12942012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1295
1296 Assume C89 or later.
1297 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1298 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1299 (xrealloc):
1300 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1301 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1302 * textprop.c, tparam.c (NULL): Remove.
1303 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1304 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1305 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1306 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1307 * xterm.c (input_signal_count): Assume volatile works.
1308
ff23cd9f
KB
13092012-05-21 Ken Brown <kbrown@cornell.edu>
1310
1311 * xgselect.c (xg_select): Fix first argument in call to 'select'
1312 (bug#11508).
1313
1b170bc6
KB
13142012-05-20 Ken Brown <kbrown@cornell.edu>
1315
1316 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1317 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1318
b2f4d39f
KB
13192012-05-19 Ken Brown <kbrown@cornell.edu>
1320
1321 * xfns.c (x_in_use): Remove `static' qualifier.
1322 * xterm.h (x_in_use): Declare.
1323 * xgselect.c: Include xterm.h.
1324 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1325 and `display_arg' (bug#9754).
1326
003fdae2
PE
13272012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1328
9232a6d9
PE
1329 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1330
003fdae2
PE
1331 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1332 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1333
784b56e2
EZ
13342012-05-18 Eli Zaretskii <eliz@gnu.org>
1335
1336 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1337
1338 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1339 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1340
1341 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1342 reference to image_cache->refcount.
1343 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1344
a0a79cde
JL
13452012-05-17 Juri Linkov <juri@jurta.org>
1346
1347 * search.c (Fword_search_regexp, Fword_search_backward)
1348 (Fword_search_forward, Fword_search_backward_lax)
1349 (Fword_search_forward_lax): Move functions to isearch.el
1350 (bug#10145, bug#11381).
1351
b0572523
PE
13522012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1353
1354 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1355
9660f5fc
SM
13562012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1357
1358 * lread.c (init_obarray): Declare Qt and Qnil as special.
1359
4374de83
GM
13602012-05-14 Glenn Morris <rgm@gnu.org>
1361
1362 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1363 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1364
dc44c39a
PE
13652012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1366
078c97cb
PE
1367 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1368
dc44c39a
PE
1369 * unexaix.c: Port to more-recent AIX compilers.
1370 (report_error, report_error_1, make_hdr, copy_sym)
1371 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1372 Make arguments const char *, not char *, to avoid violations of C
1373 standard and to fix some AIX warnings reported by Gilles Pion.
1374
e18afed7 13752012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1376
1377 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1378 already have overlays loaded.
1379 (handle_single_display_spec): Before returning without displaying
1380 fringe bitmap, synchronize the bidi iterator with the main display
1381 iterator, by calling iterate_out_of_display_property.
1382 (iterate_out_of_display_property): Detect buffer iteration by
1383 testing that it->string is a Lisp string.
1384 (get_next_display_element): When the current object is exhausted,
1385 and there's something on it->stack, call set_iterator_to_next to
1386 proceed with what's on the stack, instead of returning zero.
1387 (set_iterator_to_next): If called at the end of a Lisp string,
1388 proceed to consider_string_end without incrementing string
1389 position. Don't increment display vector index past the end of
1390 the display vector. (Bug#11417)
c8fb9dc6
EZ
1391 (pos_visible_p): Don't report a position visible when move_it_to
1392 stopped at the last line of window, which happens to be scanned
1393 backwards by the bidi iteration. (Bug#11464)
ac268e67 1394
e18afed7 13952012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1396
1397 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1398 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1399 are on a TTY, and thus unable to display on the fringes.
1400 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1401 so we need to signal to the caller that this is a "replacing"
1402 display spec. This fixes display when the spec is invalid or we
1403 are on a TTY.
1404
e18afed7 14052012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1406
1407 * unexaix.c (make_hdr): Fix typo in prototype.
1408 This bug broke the build on AIX. Problem reported by Gilles Pion.
1409
9d0a235a
MA
14102012-05-14 Michael Albinus <michael.albinus@gmx.de>
1411
1412 * keyboard.c (kbd_buffer_get_event): Read special events also in
1413 batch mode. (Bug#11415)
1414
9e6b06ed
GM
14152012-05-12 Glenn Morris <rgm@gnu.org>
1416
1417 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1418
c1a1d7a3
EZ
14192012-05-12 Eli Zaretskii <eliz@gnu.org>
1420
1421 * lisp.mk (lisp): Add newcomment.elc.
1422
3fe7cdc8
GM
14232012-05-12 Glenn Morris <rgm@gnu.org>
1424
1425 * Makefile.in (MKDIR_P): New, set by configure.
1426 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1427
53f7d2c0
PE
14282012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1429
1430 Remove unused function hourglass_started.
1431 * dispextern.h (hourglass_started):
1432 * w32fns.c (hourglass_started):
1433 * xdisp.c (hourglass_started): Remove.
1434
75aafb17
JB
14352012-05-10 Juanma Barranquero <lekktu@gmail.com>
1436
1437 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1438 Update dependencies.
1439
12959e8e
PE
14402012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1441
97107e2e
PE
1442 * xgselect.c (xg_select): Put maxfds+1 into a var.
1443 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1444
12959e8e
PE
1445 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1446
836d29b3
DA
14472012-05-10 Dave Abrahams <dave@boostpro.com>
1448
1449 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1450 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1451
5cb67954
MA
14522012-05-09 Michael Albinus <michael.albinus@gmx.de>
1453
1454 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1455 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1456 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1457 Initialize xd_registered_buses.
1458
3478ec45
PE
14592012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1460
b263a6b0
PE
1461 Untag more efficiently if USE_LSB_TAG.
1462 This is based on a proposal by YAMAMOTO Mitsuharu in
1463 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1464 For an admittedly artificial (nth 8000 longlist) benchmark on
1465 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1466 Emacs's overall text size by 1%.
1467 * lisp.h (XUNTAG): New macro.
1468 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1469 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1470 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1471 * eval.c (Fautoload):
1472 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1473 * frame.h (XFRAME): Use XUNTAG.
1474
3478ec45
PE
1475 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1476 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1477 Remove unportable assumptions about print widths of types like
1478 dbus_uint32_t.
1479 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1480 intptr_t when converting between pointer and integer, to avoid GCC
1481 warnings about wrong width.
1482
666b903b 14832012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1484
1485 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1486 stack for each reader_thread, instead of defaulting to 8MB
1487 determined by the linker. This avoids failures in creating
1488 subprocesses on Windows 7, see the discussion in this thread:
1489 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1490
b120cc17
JC
14912012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1492
1493 Fix up display of the *Minibuf-0* buffer in the mini window.
1494 * keyboard.c (read_char): Don't clear the echo area if there's no
1495 message to clear.
1496 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1497 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1498
9a4b36f8
MA
14992012-05-07 Michael Albinus <michael.albinus@gmx.de>
1500
1501 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1502 batch mode.
1503
e5f9458f
CY
15042012-05-06 Chong Yidong <cyd@gnu.org>
1505
1506 * lisp.mk (lisp): Update.
1507
eceeb5fc 15082012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1509
1510 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1511
71873e2b
SM
15122012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1513
1514 * data.c (PUT_ERROR): New macro.
1515 (syms_of_data): Use it. Add new error type `user-error'.
1516 * undo.c (user_error): New function.
1517 (Fprimitive_undo): Use it.
1518 * print.c (print_error_message): Adjust print style for `user-error'.
1519 * keyboard.c (user_error): New function.
1520 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1521
ab0fa4e4
PE
15222012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1523
1524 Do not limit current-time-string to years 1000..9999.
1525 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1526 (Fcurrent_time_string): Support any year that is supported by the
1527 underlying localtime representation. Don't use asctime, as it
1528 has undefined behavior for years outside the range -999..9999.
1529
7ed806a7
PE
15302012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1531
1532 Fix race conditions involving setenv, gmtime, localtime, asctime.
1533 Without this fix, interrupts could mess up code that uses these
1534 nonreentrant functions, since setting TZ invalidates existing
1535 tm_zone or tzname values, and since most of these functions return
1536 pointers to static storage.
1537 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1538 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1539 Grow the critical sections to include not just invoking
1540 localtime/gmtime, but also accessing these functions' results
1541 including their tm_zone values if any, and any related TZ setting.
1542 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1543 so that the struct tm is saved in the critical section.
1544 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1545 motivated by the fact that memory allocation needs to be outside
1546 the critical section.
1547
0c16dfed
DA
15482012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1549
1550 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1551 with RESET_INTERVAL.
1552
1553 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1554 Remove duplicated buffer name initialization.
1555
3f83ace8
JM
15562012-05-02 Jim Meyering <jim@meyering.net>
1557
1558 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1559
c7b8541e
JM
1560 * xfns.c (x_window): Use xstrdup (Bug#11375).
1561
90207a15 15622012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1563
1564 * xdisp.c (pos_visible_p): If already at a newline from the
1565 display string before the 'while' loop, don't walk back the glyphs
1566 from it3.glyph_row. Solves assertion violation when the display
1567 string begins with a newline (egg.el). (Bug#11367)
1568
b593d6a9
AH
15692012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1570
1571 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1572 Move to simple.el.
1573
4737362e
GM
15742012-05-01 Glenn Morris <rgm@gnu.org>
1575
99cf43f9
GM
1576 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1577 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1578 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1579 All were removed before 23.1.
1580
9311dcff
GM
1581 * dispnew.c: Remove HAVE_LIBNCURSES test;
1582 it is always true on relevant platforms.
1583
4d5c6349
GM
1584 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1585 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1586
4737362e
GM
1587 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1588
74dd3a6b
AS
15892012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1590
1591 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1592 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1593 Remove.
1594
13c379ee
PE
15952012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1596
1597 Do not avoid creating empty evaporating overlays (Bug#9642).
1598 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1599 That is, do not delete an evaporating overlay if it becomes
1600 empty after its bounds are adjusted to fit within its buffer.
1601 This fix caused other problems, and I'm reverting it until we get
1602 to the bottom of them.
1603
a8e7d6d7 16042012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1605
1606 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1607
a8e7d6d7 16082012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1609
1610 * xdisp.c (pos_visible_p): If the window start position is beyond
1611 ZV, start the display from buffer beginning. Prevents assertion
1612 violation in init_iterator when the minibuffer window is scrolled
1613 via the scroll bar.
1614
1615 * window.c (window_scroll_pixel_based): Likewise.
1616
a8e7d6d7 16172012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1618
1619 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1620
a8e7d6d7 16212012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1622
1623 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1624 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1625
a8e7d6d7 16262012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1627
b593d6a9
AH
1628 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1629 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1630
1c6900d9
EZ
16312012-04-26 Eli Zaretskii <eliz@gnu.org>
1632
4c3fa1d9
EZ
1633 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1634 display element, check also the underlying string or buffer
1635 character. (Bug#11341)
1636
1c6900d9
EZ
1637 * w32menu.c: Include w32heap.h.
1638 (add_menu_item): If the call to AppendMenuW (via
1639 unicode_append_menu) fails, disable Unicode menus only if we are
1640 running on Windows 9X/Me.
1641
42bf8205
AS
16422012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1643
1644 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1645 (xgetint): Add missing shift for LSB tags.
1646
b1bac16e
MR
16472012-04-24 Martin Rudalics <rudalics@gmx.at>
1648
1649 * keyboard.c (read_char): Don't wipe echo area for select window
1650 events: These might get delayed via `mouse-autoselect-window'
1651 (Bug#11304).
1652
d69621cc
JB
16532012-04-24 Juanma Barranquero <lekktu@gmail.com>
1654
1655 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1656 manipulation of :loaded-from data.
1657
02fd101b
JB
16582012-04-23 Juanma Barranquero <lekktu@gmail.com>
1659
1660 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1661 now a cons (bug#11311).
1662
888bec30
PE
16632012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1664
89a438bd
PE
1665 Do not create empty overlays with the evaporate property (Bug#9642).
1666 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1667 if it becomes empty after its bounds are adjusted to fit within
1668 its buffer. Without this fix, in a nonempty buffer (let ((o
1669 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1670 yields an empty overlay that has the evaporate property, which is
1671 not supposed to happen.
1672
1068fe4d
PE
1673 Fix minor GTK3 problems found by static checking.
1674 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1675 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1676 (struct _EmacsFixedClass, emacs_fixed_get_type):
1677 Move decls here from emacsgtkfixed.h, since they needn't be public.
1678 (emacs_fixed_get_type): Now static.
1679 (emacs_fixed_class_init): Omit unused local.
1680 (emacs_fixed_child_type): Remove; unused.
1681 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1682 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1683 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1684 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1685 (EMACS_FIXED_GET_CLASS): Remove; unused.
1686 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1687
888bec30
PE
1688 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1689 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1690
de85e130
PE
16912012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1692
d0baac98 1693 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1694 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1695 (__malloc_size_t, __malloc_ptrdiff_t):
1696 Remove. All uses removed, replaced by the definiens if needed,
1697 since we can assume C89 or better now.
1698 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1699 (protect_malloc_state, align, get_contiguous_space)
1700 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1701 (malloc_atfork_handler_child, malloc_enable_thread)
1702 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1703 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1704 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1705 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1706 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1707 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1708 Define using prototypes, not old style.
1709 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1710 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1711 (align): Don't assume that signed integer overflow wraps around.
1712 Omit unused local var.
1713 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1714 (_free_internal_nolock, memalign, mallochook, reallochook):
1715 Omit no-longer-needed casts.
1716 (valloc): Use getpagesize, not __getpagesize.
1717 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1718 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1719
de85e130
PE
1720 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1721
dcbf5805
MA
17222012-04-22 Michael Albinus <michael.albinus@gmx.de>
1723
1724 Move functions from C to Lisp. Make non-blocking method calls
1725 the default. Implement further D-Bus standard interfaces.
1726
1727 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1728 (QCdbus_request_name_allow_replacement)
1729 (QCdbus_request_name_replace_existing)
1730 (QCdbus_request_name_do_not_queue)
1731 (QCdbus_request_name_reply_primary_owner)
1732 (QCdbus_request_name_reply_in_queue)
1733 (QCdbus_request_name_reply_exists)
1734 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1735 (QCdbus_registered_serial, QCdbus_registered_method)
1736 (QCdbus_registered_signal): New Lisp objects.
1737 (XD_DEBUG_MESSAGE): Use sizeof.
1738 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1739 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1740 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1741 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1742 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1743 (xd_signature, xd_append_arg): Allow float for integer types.
1744 (xd_get_connection_references): New function.
b593d6a9
AH
1745 (xd_get_connection_address): Rename from xd_initialize.
1746 Return cached address.
dcbf5805
MA
1747 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1748 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1749 level.
1750 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1751 Return number of refcounts.
dcbf5805
MA
1752 (Fdbus_get_unique_name): Make stronger parameter check.
1753 (Fdbus_message_internal): New defun.
1754 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1755 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1756 (Fdbus_send_signal, Fdbus_register_service)
1757 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1758 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1759 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1760 (Vdbus_compiled_version, Vdbus_runtime_version)
1761 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1762 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1763 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1764 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1765 Adapt docstring.
dcbf5805 1766
52828e02
PE
17672012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1768
da05bc4c
PE
1769 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1770 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1771 Do not assume ptrdiff_t is the same width as 'int'.
1772
52828e02
PE
1773 * alloc.c: Handle unusual debugging option combinations.
1774 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1775 since the two debugging options are incompatible.
1776 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1777 is defined.
1778 (mem_init, mem_insert, mem_insert_fixup):
1779 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1780 (NEED_MEM_INSERT): Remove; no longer needed.
1781
f01769f9
LL
17822012-04-22 Leo Liu <sdl.web@gmail.com>
1783
1784 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1785
5790543d
PE
17862012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1787
1788 * sysdep.c [__FreeBSD__]: Minor cleanups.
1789 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1790 Use Emacs indenting style more consistently. Avoid some casts.
1791 Use 'double' consistently rather than mixing 'float' and 'double'.
1792
b91b7e4d
EW
17932012-04-21 Eduard Wiebe <usenet@pusto.de>
1794
b593d6a9
AH
1795 * sysdep.c (list_system_processes, system_process_attributes):
1796 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1797
6114eb15
AS
17982012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1799
1800 * lisp.mk (lisp): Update.
1801
2f38dff7
PE
18022012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1803
1804 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1805 It is never used otherwise.
1806
4ae29f89
SM
18072012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1808
1809 * print.c (print_preprocess): Only check print_depth if print-circle
1810 is nil.
1811 (print_object): Check for cycles even when print-circle is nil and
1812 print-gensym is t, but only check print_depth if print-circle is nil.
1813
f30d612a
CY
18142012-04-20 Chong Yidong <cyd@gnu.org>
1815
1816 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1817 set the status to "failed" and ensure that sentinel is run.
1818
c07a4c0b 18192012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1820
1821 * process.c (Fset_process_inherit_coding_system_flag)
1822 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1823 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1824
c07a4c0b 18252012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1826
1827 * xdisp.c (string_buffer_position_lim): Limit starting position to
1828 BEGV.
1829 (set_cursor_from_row): If called for a mode-line or header-line
1830 row, return zero immediately.
1831 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1832 farther than the first row after the header line, if any.
1833 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1834 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1835
c07a4c0b 18362012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1837
4ae29f89
SM
1838 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1839 (bug#11238).
ad3a2b41 1840
c07a4c0b 18412012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 18422012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1843
1844 configure: new option --enable-gcc-warnings (Bug#11207)
1845 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1846 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1847 (ALL_CFLAGS): Use new macros rather than old.
1848 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1849 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1850 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1851 -Wunused-result, -Wunused-variable. This should go away once
1852 the Emacs and Gnulib regex code is merged.
1853 (xmalloc, xrealloc): Now static.
1854
aba027e8
PE
18552012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1856
1857 * dired.c (Fsystem_groups): Remove unused local.
1858
e5a36063
GM
18592012-04-17 Glenn Morris <rgm@gnu.org>
1860
1861 * dired.c (Fsystem_users): Doc fix.
1862
316411f0
DA
18632012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1864
1865 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1866 (syms_of_dired): Add them.
1867
9426aba4
PE
18682012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1869
b62a57be
PE
1870 Fix minor alloc.c problems found by static checking.
1871 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1872 New extern decls, to avoid calling undeclared functions.
1873 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1874 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1875 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1876 (NEED_MEM_INSERT): New macro.
1877 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1878 Remove one incorrect comment and fix another.
b62a57be 1879
3539f31f
PE
1880 Fix minor ralloc.c problems found by static checking.
1881 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1882 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1883 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1884 (r_alloc_sbrk): Now static.
1885
a041960a
PE
1886 Improve ralloc.c interface checking.
1887 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1888 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1889 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1890 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1891 [REL_ALLOC]: ... to here, to check interface.
1892 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1893 Remove decls. This fixes an "It stinks!".
1894
9426aba4
PE
1895 * alloc.c (which_symbols): Fix alignment issue / type clash.
1896
d55c12ed
AS
18972012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1898
1899 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1900 (struct Lisp_Misc_Any): Likewise.
1901 (struct Lisp_Free): Likewise.
1902 * alloc.c (union aligned_Lisp_Symbol): Define.
1903 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1904 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1905 (union aligned_Lisp_Misc): Define.
1906 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1907 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1908 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1909
b948ce8b
PE
19102012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1911
1912 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1913 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1914 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1915 * s/netbsd.h, s/sol2-6.h:
1916 Remove definition of GC_MARK_STACK, since the default now works.
1917 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1918 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1919 no longer the default.
1920 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1921
35dc09a1 19222012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1923
35dc09a1
GM
1924 * lread.c (lisp_file_lexically_bound_p):
1925 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1926
35dc09a1
GM
19272012-04-14 Eli Zaretskii <eliz@gnu.org>
1928
1929 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1930 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1931
19322012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1933
1934 * nsterm.m (constrainFrameRect): Always constrain when there is only
1935 one screen (Bug#10962).
1936
bcd86815
KB
19372012-04-13 Ken Brown <kbrown@cornell.edu>
1938
1939 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1940
c25df26e
RT
19412012-04-13 Reuben Thomas <rrt@sc3d.org>
1942
1943 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1944
0fc59f1e
DC
19452012-04-11 Daniel Colascione <dancol@dancol.org>
1946
1947 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1948 against is gone. It's better to use vfork now so that when Cygwin
1949 gains a new, working vfork, we use it automatically (bug#10398).
1950
de8c03dc
SM
19512012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1952
1953 * window.c (save_window_save): Obey window-point-insertion-type.
1954
2f097256
GM
19552012-04-11 Glenn Morris <rgm@gnu.org>
1956
1957 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1958
453b951e
SM
19592012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1960
1961 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1962
75f1671a 19632012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
1964
1965 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1966 (force_quit_count): New var.
1967 (handle_interrupt): Use it.
1968
2a8ce227
JB
19692012-04-10 Juanma Barranquero <lekktu@gmail.com>
1970
1971 * w32.c (w32_delayed_load): Record the full path of the library
1972 being loaded (bug#10424).
1973
935396c0
GM
19742012-04-09 Glenn Morris <rgm@gnu.org>
1975
05920a43
GM
1976 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1977 not just in the obarray, before snarfing them. (Bug#11036)
1978
935396c0
GM
1979 * Makefile.in ($(leimdir)/leim-list.el):
1980 Pass EMACS rather than BUILT_EMACS.
1981
a18ecafa
TZ
19822012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1983
1984 * process.c (make_process):
1985 * process.h: Add integer `gnutls_handshakes_tried' member to
1986 process struct.
1987
6bbef4e5
JC
1988 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1989 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
1990
1991 * gnutls.c (gnutls_log_function2i): Convenience log function.
1992 (emacs_gnutls_read): Use new log functions,
1993 `gnutls_handshakes_tried' process member, and
1994 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1995 attempts per process (connection).
1996
b4d3bc10
CY
19972012-04-09 Chong Yidong <cyd@gnu.org>
1998
1999 * eval.c (Fuser_variable_p, user_variable_p_eh)
2000 (lisp_indirect_variable): Functions deleted.
2001 (Fdefvar): Caller changed.
2002
2003 * callint.c (Finteractive, Fcall_interactively):
2004 * minibuf.c (Fread_variable): Callers changed.
2005
70f4d973
EZ
20062012-04-09 Eli Zaretskii <eliz@gnu.org>
2007
2008 * xdisp.c (set_cursor_from_row): If the display string appears in
2009 the buffer at position that is closer to point than the position
2010 after the display string, display the cursor on the first glyph of
2011 the display string. Fixes cursor display when a 'display' text
2012 property immediately follows invisible text. (Bug#11094)
2013
cb3c2e3e
PE
20142012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2015
2016 composite.c: use 'double' consistently
2017 * composite.c (get_composition_id): Use 'double' consistently
2018 instead of converting 'float' to 'double' and vice versa; this is
2019 easier to understand and avoids a GCC warning.
2020
fd06db5d
GM
20212012-04-09 Glenn Morris <rgm@gnu.org>
2022
50fe702a
GM
2023 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2024 preparation for dumping it with emacs. (Bug#4789)
2025 (leimdir): New variable.
2026 ($(leimdir)/leim-list.el): New rule.
2027 (emacs$(EXEEXT)): Depend on leim-list.el.
2028
fd06db5d
GM
2029 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2030 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2031 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2032
55c131ee
AS
20332012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2034
2035 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2036 proper alignment.
2037
9209588f
JB
20382012-04-07 Juanma Barranquero <lekktu@gmail.com>
2039
2040 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2041 Remove unused local variable.
2042
e3fb2efb
PE
20432012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2044
2045 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2046 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2047 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2048 objects, as mark_maybe_pointer will catch them otherwise.
2049 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2050 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2051
b5385551
PE
20522012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2053
2054 Fix typo that broke non-Windows builds.
2055 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2056
9078ead6
EZ
20572012-04-07 Eli Zaretskii <eliz@gnu.org>
2058
2059 Support building on MS-Windows with libxml2.
2060
2061 * makefile.w32-in (OBJ2): Add xml.$(O).
2062 (GLOBAL_SOURCES): Add xml.c.
2063 ($(BLD)/xml.$(O)): New dependency list.
2064
2065 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2066 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2067 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2068 [!WINDOWSNT]: New macros.
2069 (init_libxml2_functions, libxml2_loaded_p): New functions.
2070 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2071 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2072 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2073 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2074 linked in).
6bbef4e5
JC
2075 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2076 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2077 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2078
2079 * emacs.c: Don't include libxml/parser.h.
2080 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2081 xmlCleanupParser directly.
2082
2083 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2084
3811fdf3
EZ
20852012-04-07 Eli Zaretskii <eliz@gnu.org>
2086
2087 * indent.c (Fvertical_motion): If there is a display string at
2088 point, use it.vpos to compute how many lines to backtrack after
2089 move_it_to point. (Bug#11133)
2090
2f8e16b2
EZ
20912012-04-06 Eli Zaretskii <eliz@gnu.org>
2092
2093 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2094 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2095 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2096 macros related to unification of CJK characters. For the details,
2097 see the discussion following the message here:
2098 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2099
3d439cd1
CY
21002012-04-04 Chong Yidong <cyd@gnu.org>
2101
2102 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2103
8bc53d00
EZ
21042012-04-01 Eli Zaretskii <eliz@gnu.org>
2105
2106 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2107 instead of alloca. (Bug#11138)
2108
3b0512a3
AS
21092012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2110
2111 * w32menu.c (is_simple_dialog): Properly check lisp types.
2112 (Bug#11141)
2113
8427ddd2
EZ
21142012-03-31 Eli Zaretskii <eliz@gnu.org>
2115
979022ef
EZ
2116 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2117 position we get to after a call to move_it_to fails the
2118 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2119 only if we wind up in a string from display property. (Bug#11063)
2120
a6b1c7cc
EZ
2121 * window.c (Fdelete_other_windows_internal): Invalidate the row
2122 and column information about mouse highlight, so that redisplay
2123 restores it after reallocating the glyph matrices. (Bug#7464)
2124
8427ddd2
EZ
2125 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2126 string comes from a `display' text property, use the buffer
2127 position of that property as if we actually saw that position in
2128 the row's glyphs.
697ba24b
EZ
2129 (move_it_by_lines): Remove the assertion that
2130 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2131 violated when there's a before-string at the beginning of a line.
2132 (Bug#11063)
8427ddd2 2133
65a0a738
EZ
21342012-03-30 Eli Zaretskii <eliz@gnu.org>
2135
2136 * xdisp.c (append_space_for_newline): If the default face was
2137 remapped, use the remapped face for the appended newline.
2138 (extend_face_to_end_of_line): Use the remapped default face for
2139 extending the face to the end of the line.
2140 (display_line): Call extend_face_to_end_of_line when the default
2141 face was remapped. (Bug#11068)
2142
581355cc
EZ
21432012-03-29 Eli Zaretskii <eliz@gnu.org>
2144
2145 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2146
e8fc049f
SM
21472012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2148
2149 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2150
4fb9a543
GM
21512012-03-27 Glenn Morris <rgm@gnu.org>
2152
2153 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2154 Doc fixes.
2155
679910f1
KH
21562012-03-26 Kenichi Handa <handa@m17n.org>
2157
2158 * dispextern.h (struct glyph): Fix previous change. Change the
2159 bit length of glyphless.ch to 25 (Bug#11082).
2160
90d49b7f
CY
21612012-03-26 Chong Yidong <cyd@gnu.org>
2162
2163 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2164 (command_loop_1): Use it; inhibit selection update for
2165 handle-select-window too (Bug#8996).
2166
f514f6f0
FP
21672012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2168
e8fc049f 2169 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2170
bf43fa51
KH
21712012-03-25 Kenichi Handa <handa@m17n.org>
2172
2173 * dispextern.h (struct glyph): Change the bit length of
2174 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2175
8a0c01dd
EZ
21762012-03-24 Eli Zaretskii <eliz@gnu.org>
2177
2178 * s/ms-w32.h (tzname): Include time.h before redirecting to
2179 _tzname. Fixes the MSVC build. (Bug#9960)
2180
7d1c3a76
AS
21812012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2182
8ed79523
AS
2183 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2184 characters.
2185
7d1c3a76
AS
2186 * xterm.c (XTread_socket): Only modify handling_signal if
2187 !SYNC_INPUT. (Bug#11080)
2188
e99a9b8b
EZ
21892012-03-23 Eli Zaretskii <eliz@gnu.org>
2190
2191 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2192 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2193 when fetching a multibyte character consumes more bytes than
2194 CHAR_BYTES returns, due to unification of CJK characters in
2195 string_char. (Bug#11073)
2196
5063c0e1
TN
21972012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2198
2199 * process.c (wait_reading_process_output): Handle pty disconnect
2200 by refraining from sending oneself a SIGCHLD (bug#10933).
2201
9f851fbd
CY
22022012-03-22 Chong Yidong <cyd@gnu.org>
2203
2204 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2205
5063c0e1 2206 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2207 Mark string as coming from a prefix property.
2208 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2209 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2210
fb5b8aca
CY
22112012-03-21 Chong Yidong <cyd@gnu.org>
2212
2213 * xfaces.c (Vface_remapping_alist): Doc fix.
2214
62356a1b
EZ
22152012-03-20 Eli Zaretskii <eliz@gnu.org>
2216
2217 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2218 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2219 Doc fixes.
62356a1b 2220
025de85b
CY
22212012-03-20 Chong Yidong <cyd@gnu.org>
2222
2223 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2224 to reflect default non-nil value of redisplay-dont-pause.
2225
4827f94e
KH
22262012-03-19 Kenichi Handa <handa@m17n.org>
2227
2228 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2229 it fit in a valid range (Bug#11003).
2230
e50a24a2
EZ
22312012-03-18 Eli Zaretskii <eliz@gnu.org>
2232
2233 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2234 that is not from display property, accept the row as a "cursor
2235 row" if one of the string's character has a non-nil `cursor'
2236 property. Fixes cursor positioning when there are newlines in
2237 overlay strings, e.g. in icomplete.el. (Bug#11035)
2238
9af5ed87
PE
22392012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2240
2241 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2242
d1f55f16
CY
22432012-03-12 Chong Yidong <cyd@gnu.org>
2244
2245 * eval.c (inhibit_lisp_code): Rename from
2246 inhibit_window_configuration_change_hook; move from window.c.
2247
2248 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2249 * window.c (run_window_configuration_change_hook)
2250 (syms_of_window): Callers changed.
2251
66c5eebd
CY
22522012-03-11 Chong Yidong <cyd@gnu.org>
2253
413df973
CY
2254 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2255
66c5eebd
CY
2256 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2257
1de11f56
CY
22582012-03-10 Chong Yidong <cyd@gnu.org>
2259
2260 * frame.c (other_visible_frames): Don't assume the selected frame
2261 is visible (Bug#10955).
2262
cae07000
SM
22632012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2264
2265 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2266
89c94350
JD
22672012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2268
2269 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2270 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2271 zero (Bug#10954).
2272
999dd333
GM
22732012-03-03 Glenn Morris <rgm@gnu.org>
2274
01a6dcc8 2275 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2276
de0100f2
EZ
22772012-03-02 Eli Zaretskii <eliz@gnu.org>
2278
2279 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2280 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2281 (redisplay_window, next_element_from_string): Fix typos in
2282 comments.
3e441275
EZ
2283 (redisplay_window): Pass to move_it_vertically the margin in
2284 pixels, not in screen lines.
de0100f2 2285
96a72ee9
GM
22862012-03-02 Glenn Morris <rgm@gnu.org>
2287
2288 * buffer.c (buffer-list-update-hook): Doc fix.
2289
312508d7
EZ
22902012-02-29 Eli Zaretskii <eliz@gnu.org>
2291
2292 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2293 push_it before setting up the iterator for the first overlay
2294 string, even if we have an empty string loaded.
2295 (next_overlay_string): If there's an empty string on the iterator
2296 stack, pop the stack. (Bug#10903)
2297
27f3c637
PE
22982012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2299
2300 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2301 Suggested by Stefan Monnier in
2302 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2303 * alloc.c (widen_to_Lisp_Object): New static function.
2304 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2305 and widening them to Lisp_Objects. This would work even if
2306 USE_LSB_TAG is defined and wide integers are used, which might
2307 happen in a future version of Emacs.
2308
3c9dfce6
CY
23092012-02-25 Chong Yidong <cyd@gnu.org>
2310
fa74b241
CY
2311 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2312 Doc fix.
2313
3c9dfce6
CY
2314 * xselect.c (Fx_selection_exists_p): Doc fix.
2315 (x_clipboard_manager_save_all): Print an informative message
2316 before saving to clipboard manager.
2317
9486df08
CY
23182012-02-24 Chong Yidong <cyd@gnu.org>
2319
2320 * keyboard.c (process_special_events): Handle all X selection
2321 requests in kbd_buffer, not just the next one (Bug#8869).
2322
f01d3321
CY
23232012-02-23 Chong Yidong <cyd@gnu.org>
2324
2325 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2326 call when setting menu-bar-lines and tool-bar-lines parameters.
2327 (unwind_create_frame_1): New helper function.
2328
2329 * window.c (inhibit_window_configuration_change_hook): New var.
2330 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2331 (syms_of_window): Initialize it.
f01d3321 2332
86b847b6
CY
23332012-02-22 Chong Yidong <cyd@gnu.org>
2334
2335 * xterm.c (x_draw_image_relief): Add missing type check for
2336 Vtool_bar_button_margin (Bug#10743).
2337
a59225b1
CY
23382012-02-21 Chong Yidong <cyd@gnu.org>
2339
2340 * fileio.c (Vfile_name_handler_alist): Doc fix.
2341
2342 * buffer.c (Fget_file_buffer): Protect against invalid file
2343 handler return value.
2344
310f5bd4
PE
23452012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2346
cb3a28cc
PE
2347 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2348 when computing $valmask.
2349
310f5bd4
PE
2350 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2351 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2352 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2353 It's useless in that case, and it can cause problems on hosts
2354 that allocate halves of EMACS_INT values separately.
2355 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2356 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2357 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2358 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2359 it avoids undefined behavior on hosts where shifting right by more
2360 than the word width has undefined behavior.
2361
2375c96a
CY
23622012-02-19 Chong Yidong <cyd@gnu.org>
2363
2364 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2365 (Funhandled_file_name_directory, Ffile_name_as_directory)
2366 (Fdirectory_file_name, Fexpand_file_name)
2367 (Fsubstitute_in_file_name): Protect against invalid file handler
2368 return values (Bug#10845).
2369
3eb49e71
EZ
23702012-02-18 Eli Zaretskii <eliz@gnu.org>
2371
2372 * .gdbinit (pitx): Fix incorrect references to fields of the
2373 iterator stack.
2374
7b926f3f
CY
23752012-02-17 Chong Yidong <cyd@gnu.org>
2376
2377 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2378
11273115
PE
23792012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2380
2381 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2382 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2383
c3a70e2b
CY
23842012-02-15 Chong Yidong <cyd@gnu.org>
2385
2386 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2387 marked as special. Also, starting docstrings with * is obsolete.
2388
0ca43699
AS
23892012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2390
2391 * gnutls.c (emacs_gnutls_write): Fix last change.
2392
2e8f3c56
LI
23932012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2394
2395 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2396 send_process.
2397
af70074f
SM
23982012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2399
2400 * keymap.c (Fsingle_key_description): Handle char ranges.
2401
95986d52
CY
24022012-02-12 Chong Yidong <cyd@gnu.org>
2403
afd83bd1
CY
2404 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2405 as that creates a dangerous corner case.
2406
95986d52
CY
2407 * window.c (Fdelete_window_internal): Invalidate the mouse
2408 highlight (Bug#9904).
2409
bd7da63e
GM
24102012-02-12 Glenn Morris <rgm@gnu.org>
2411
2412 * xselect.c (Fx_own_selection_internal)
2413 (Fx_get_selection_internal, Fx_disown_selection_internal)
2414 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2415 * nsselect.m (Fx_own_selection_internal)
2416 (Fx_disown_selection_internal, Fx_selection_exists_p)
2417 (Fx_selection_owner_p, Fx_get_selection_internal):
2418 Sync docs and argument specs with the xselect.c versions.
2419
77abcbc2
LI
24202012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2421
2422 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2423
90b671e2
EZ
24242012-02-11 Eli Zaretskii <eliz@gnu.org>
2425
1c0ca0b7
EZ
2426 * w32select.c (Fx_selection_exists_p): Sync doc string and
2427 argument list with xselect.c. (Bug#10783)
2428
2429 * w16select.c (Fx_selection_exists_p): Sync doc string and
2430 argument list with xselect.c. (Bug#10783)
90b671e2 2431
49241268
GM
24322012-02-10 Glenn Morris <rgm@gnu.org>
2433
2434 * fns.c (Fsecure_hash): Doc fix.
2435
f998bbe7 24362012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2437
2438 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2439
0992bd9c
CY
24402012-02-07 Chong Yidong <cyd@gnu.org>
2441
2442 * buffer.c (Fbuffer_local_variables)
2443 (buffer_lisp_local_variables): Handle unbound vars correctly;
2444 don't let Qunbound leak into Lisp.
2445
af008560
GM
24462012-02-07 Glenn Morris <rgm@gnu.org>
2447
dd605cc4
GM
2448 * image.c (Fimagemagick_types): Doc fix.
2449
af008560
GM
2450 * image.c (imagemagick-render-type): Change it from a lisp object
2451 to an integer. Move the doc here from the lisp manual.
2452 Treat all values not equal to 0 the same.
2453
1449fa1d
CY
24542012-02-06 Chong Yidong <cyd@gnu.org>
2455
2456 * doc.c (store_function_docstring): Avoid applying docstring of
2457 alias to base function (Bug#2603).
2458
3723ec07
AS
24592012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2460
2461 * .gdbinit (pp1, pv1): Remove redundant defines.
2462 (pr): Use pp.
2463
79c1cc1e
CY
24642012-02-04 Chong Yidong <cyd@gnu.org>
2465
2466 * nsterm.m: Declare a global (Bug#10694).
2467
d7f29f8e
EZ
24682012-02-04 Eli Zaretskii <eliz@gnu.org>
2469
cae07000
SM
2470 * w32.c (get_emacs_configuration_options):
2471 Include --enable-checking, if specified, in the return value.
d7f29f8e 2472
3b95a6f9
MR
24732012-02-04 Martin Rudalics <rudalics@gmx.at>
2474
2475 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2476 after rounding frame sizes. (Bug#9723)
2477
d6fa96a6
EZ
24782012-02-04 Eli Zaretskii <eliz@gnu.org>
2479
2480 * keyboard.c (adjust_point_for_property): Don't position point
2481 before BEGV. (Bug#10696)
2482
df0b2940
PE
24832012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2484
2485 Handle overflow when computing char display width (Bug#9496).
2486 * character.c (char_width): Return EMACS_INT, not int.
2487 (char_width, c_string_width): Check for overflow when
2488 computing the width; this is possible now that individual
2489 characters can have unbounded width. Problem introduced
2490 by merge from Emacs 23 on 2012-01-19.
2491
6bee44d6
MA
24922012-02-02 Michael Albinus <michael.albinus@gmx.de>
2493
2494 * dbusbind.c (Fdbus_register_method): Mention the return value
2495 :ignore in the docstring.
2496
44f92739
GM
24972012-02-02 Glenn Morris <rgm@gnu.org>
2498
1b9f60cc
GM
2499 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2500
44f92739
GM
2501 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2502 Unconditionally set to t. (Bug#10673)
2503 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2504 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2505 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2506
c5d3843c
KH
25072012-02-02 Kenichi Handa <handa@m17n.org>
2508
2509 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2510 0, do not call append_composite_glyph.
2511
159462d4 25122012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2513
2514 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2515 NULL (Bug#6988).
2516 (x_produce_glyphs): If the component of a composition is a null
2517 string, set it->pixel_width to 1 to avoid zero-width glyph.
2518
78cef877
EZ
25192012-02-01 Eli Zaretskii <eliz@gnu.org>
2520
2521 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2522 first 2 arguments are identical. This makes inserting large
2523 output from a subprocess an order of magnitude faster on
2524 MS-Windows, where all sbrk'ed memory is always contiguous.
2525
97897668
GM
25262012-01-31 Glenn Morris <rgm@gnu.org>
2527
2528 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2529 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2530 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2531
31fd3586
GM
25322012-01-29 Glenn Morris <rgm@gnu.org>
2533
2534 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2535
0e24a8b2
CY
25362012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2537
2538 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2539
cc0adcb0
CY
25402012-01-28 Chong Yidong <cyd@gnu.org>
2541
2542 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2543
acc28cb9
CY
25442012-01-26 Chong Yidong <cyd@gnu.org>
2545
9c69cfb7
CY
2546 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2547
acc28cb9
CY
2548 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2549 repeat counts (Bug#10507).
2550
48da7392
GM
25512012-01-26 Glenn Morris <rgm@gnu.org>
2552
2553 * lread.c (syms_of_lread): Doc fix.
2554
14af5f7f
CY
25552012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2556
2557 * coding.c (encode_designation_at_bol): Change return value to
2558 EMACS_INT.
2559
0b21c100
CY
25602012-01-25 Chong Yidong <cyd@gnu.org>
2561
2562 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2563
3c2907f7
CY
25642012-01-21 Chong Yidong <cyd@gnu.org>
2565
2566 * floatfns.c (Fcopysign): Make the second argument non-optional,
2567 since nil is not allowed anyway.
2568
959ad23f
AS
25692012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2570
2571 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2572 (send_process): Likewise.
2573
34a02f46
MR
25742012-01-19 Martin Rudalics <rudalics@gmx.at>
2575
2576 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2577 (Vwindow_persistent_parameters): Do not use Qstate.
2578 Rewrite doc-strings.
34a02f46 2579
1259009a 25802012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2581
2582 * character.c (char_width): New function.
70d4fdf6
GM
2583 (Fchar_width, c_string_width, lisp_string_width):
2584 Use char_width (Bug#9496).
25ed9e61 2585
6a6ee00d
MR
25862012-01-16 Martin Rudalics <rudalics@gmx.at>
2587
2588 * window.c (Vwindow_persistent_parameters): New variable.
2589 (Fset_window_configuration, save_window_save): Handle persistent
2590 window parameters.
2591
c85efaf7
EZ
25922012-01-14 Eli Zaretskii <eliz@gnu.org>
2593
2594 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2595 thrashing the stack of the thread. (Bug#9087)
2596
5944709e
PE
25972012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2598
2599 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2600
e71f5d99
EZ
26012012-01-11 Eli Zaretskii <eliz@gnu.org>
2602
2603 * xdisp.c (rows_from_pos_range): Handle the case where the
2604 highlight ends on a newline. (Bug#10464)
2605 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2606 he end column for display of highlight that ends on a newline
2607 before a R2L line.
2608
ce316182
GM
26092012-01-11 Glenn Morris <rgm@gnu.org>
2610
2611 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2612 from load-path also when installation-directory is nil. (Bug#10208)
2613
5b43da69
GM
26142012-01-10 Glenn Morris <rgm@gnu.org>
2615
74cc8ff9
GM
2616 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2617
7d8d6e4e
GM
2618 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2619 Update template values to be closer to their typical values these days.
5b43da69 2620
a0db8d43
EZ
26212012-01-09 Eli Zaretskii <eliz@gnu.org>
2622
2623 * xdisp.c (rows_from_pos_range): Accept additional argument
2624 DISP_STRING, and accept any glyph in a row whose object is that
2625 string as eligible for mouse highlight. Fixes mouse highlight of
2626 display strings from overlays. (Bug#10464)
2627
9a0115ab 26282012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2629
b9110d6a 2630 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2631 * fileio.c (auto_saving_dir_umask): New static var.
2632 (Fmake_directory_internal): Use it.
2633 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2634 creating the directory. The old code temporarily assigns
2635 too-generous permissions to the directory.
2636 (do_auto_save_eh): Clear it.
b9110d6a 2637 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2638 that the var is always cleared.
2639
6c1bd3f3
EZ
26402012-01-07 Eli Zaretskii <eliz@gnu.org>
2641
2642 * search.c (scan_buffer): Pass character positions to
2643 know_region_cache, not byte positions. (Bug#6540)
2644
069d2b50
L
26452012-01-07 LynX <_LynX@bk.ru> (tiny change)
2646
2647 * w32.c (sys_rename): Report EXDEV when rename of a directory
2648 fails because the target is on another logical disk. (Bug#10284)
2649
75bf0d33
DB
26502012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2651
2652 * xterm.c (x_embed_request_focus): New function.
2653
2654 * xterm.h: Add prototype.
2655
2656 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2657
1c6e5a32
GM
26582012-01-05 Glenn Morris <rgm@gnu.org>
2659
2660 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2661
651e947e
EZ
26622012-01-01 Eli Zaretskii <eliz@gnu.org>
2663
2664 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2665 Load gnutls_transport_set_lowat only if GnuTLS version is below
2666 2.11.1.
2667 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2668 GnuTLS versions below 2.11.1.
2669
3778cdd8
AL
26702011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2671
2672 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2673 to the doc string advising against its use for altering the way
2674 windows are scrolled.
2675
0e5317f7
KH
26762011-12-28 Kenichi Handa <handa@m17n.org>
2677
2678 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2679 coding-system ASCII compatible only when it does not produce BOM
2680 on encoding (Bug#10383).
2681
93d5ca1f
JD
26822011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2683
2684 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2685 can scroll.
2686 (create_and_show_popup_menu): Always use menu_position_func for
2687 Gtk3 (Bug#10361).
2688
ca22b785
AS
26892011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2690
2691 * callint.c (Fcall_interactively): Don't truncate prompt string.
2692
d048e1e6
EZ
26932011-12-23 Eli Zaretskii <eliz@gnu.org>
2694
2695 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2696 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2697 resumed from there (after widening). (Bug#10360)
d048e1e6 2698
5ccaba1f
JD
26992011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2700
2701 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2702
204ee57f
JD
27032011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2704
b81d40f0
JB
2705 * nsterm.m (x_free_frame_resources):
2706 Release f->output_data.ns->miniimage.
204ee57f
JD
2707 (ns_index_color): Fix indentation. Do not retain
2708 color_table->colors[i].
2709
2710 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2711 before returning.
2712
2713 * nsfns.m (x_set_background_color): Assign return value from
2714 ns_index_color to face-background instead of NSColor*.
2715 (ns_implicitly_set_icon_type): Fix indentation.
2716 Change assignment in for loop to comparison.
2717
2718 * emacs.c (ns_pool): New variable.
2719 (main): Assign ns_pool.
2720 (Fkill_emacs): Call ns_release_autorelease_pool.
2721
2722 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2723 autorelease fdesc, release fdAttrs and tdict.
2724 (ns_get_covering_families): Release charset.
2725 (ns_findfonts): Release NSFontDescriptor created with new.
2726 (ns_uni_to_glyphs): Fix indentation.
2727 (setString): Release attrStr before assigning new value.
2728
c803b2b7
JD
27292011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2730
678f4426
JD
2731 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2732 and NS_IMPL_COCOA.
2733 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2734 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2735
cd394be1 27362011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2737
5fecd5fc
JD
2738 * nsterm.m (ns_term_init): Subscribe for notifications
2739 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2740 to method trackingNotification in EmacsMenu.
2741
2742 * nsmenu.m (trackingMenu): New variable.
3771cb17 2743 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2744 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2745 from Aquamacs (Bug#7030).
678f4426
JD
2746
27472011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2748
c803b2b7
JD
2749 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2750 (symbol_to_nsstring): Fix indentation.
2751 (ns_symbol_to_pb): New function.
cae07000
SM
2752 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2753 (Fns_rotate_cut_buffers_internal): Remove.
2754 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2755 Fns_store_cut_buffer_internal.
2756 (ns_get_foreign_selection, Fx_own_selection_internal)
2757 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2758 (Fns_get_selection_internal, Fns_store_selection_internal):
2759 Use ns_symbol_to_pb and check if return value is nil.
2760 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2761 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2762 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2763 renamed to Sns_store_selection_internal.
2764 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2765 and remove this function.
2766 (ns_handle_selection_clear): Remove, never used.
2767 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2768 here.
2769
e1b01a3a
KB
27702011-12-17 Ken Brown <kbrown@cornell.edu>
2771
2772 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2773 GID is unknown (Bug#10257).
2774
2adb6e85
PE
27752011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2776
2777 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2778 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2779 which caused a build failure on GNU/Linux IA-64. This problem was
2780 introduced by my 2011-10-07 patch.
2781
d1d7b339
JL
27822011-12-15 Juri Linkov <juri@jurta.org>
2783
2784 * image.c (imagemagick_error): New function. (Bug#10112)
2785 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2786 Use `imagemagick_error' where ImageMagick functions return
2787 `MagickFalse'.
2788 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2789 proper order.
2790
100d5755
KH
27912011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2792
2793 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2794 fill background (Bug#8992).
2795
454592a6
MR
27962011-12-13 Martin Rudalics <rudalics@gmx.at>
2797
2798 * window.c (Vwindow_combination_resize)
2799 (Vwindow_combination_limit): Use t instead of non-nil in
2800 doc-strings.
61d4b438
MR
2801 (Vrecenter_redisplay): Add first sentence of doc-string on
2802 separate line.
53524d93 2803 (Frecenter): Fix doc-string typo.
454592a6 2804
3633e3aa
KH
28052011-12-11 Kenichi Handa <handa@m17n.org>
2806
2807 * coding.c (Funencodable_char_position): Pay attention to the
2808 buffer text relocation (Bug#9389).
2809
7b9d523a 28102011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2811
7b9d523a
JD
2812 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2813 gtk_init (Bug#10100).
2814
b73189c6
EZ
28152011-12-10 Eli Zaretskii <eliz@gnu.org>
2816
2817 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2818 IT->string is nil. (Bug#10263)
2819
f7dfe5d6
JD
28202011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2821
83faebb4
JD
2822 * nsterm.h (x_free_frame_resources): Declare.
2823
f7dfe5d6
JD
2824 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2825 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2826
2827 * nsterm.h (ns_get_defaults_value): Declare.
2828
2829 * nsterm.m (ns_default): Call ns_get_defaults_value.
2830
7cd4e72c
EZ
28312011-12-09 Eli Zaretskii <eliz@gnu.org>
2832
2833 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2834 (Bug#10170)
2835
b34d7317
YM
28362011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2837
2838 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2839 that where the value of an _OBJC_* symbol points to is in the .bss
2840 section (Bug#10240).
2841
76470ad1
KH
28422011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2843
2844 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2845 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2846
745fff94
KH
28472011-12-08 Kenichi Handa <handa@m17n.org>
2848
2849 * ftfont.c (get_adstyle_property): Fix previous change
2850 (Bug#10233).
2851
6e44397c
JB
28522011-12-07 Juanma Barranquero <lekktu@gmail.com>
2853
2854 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2855 dirs from the default value of EMACSLOADPATH (bug#10208).
2856
7efa6272
GM
28572011-12-07 Glenn Morris <rgm@gnu.org>
2858
2859 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2860 installation and source directories as well. (Bug#10208)
2861
f6fc4d87
CY
28622011-12-06 Chong Yidong <cyd@gnu.org>
2863
2864 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2865
2bf26180
GM
28662011-12-06 Glenn Morris <rgm@gnu.org>
2867
2868 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2869 as an error, not just -1. (Bug#10217)
2870
3a6ad4f0
CY
28712011-12-05 Chong Yidong <cyd@gnu.org>
2872
2873 * keyboard.c (process_special_events): New function.
2874 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2875
75a3b399
PE
28762011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2877
2878 * coding.c (encode_designation_at_bol): Don't use uninitialized
2879 local variable (Bug#9318).
2880
c3c9e25e
KH
28812011-12-05 Kenichi Handa <handa@m17n.org>
2882
2883 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2884 return Qnil (Bug#8046, Bug#10193).
2885
5eb05ea3
KH
28862011-12-05 Kenichi Handa <handa@m17n.org>
2887
2888 * coding.c (encode_designation_at_bol): New args charbuf_end and
2889 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2890 (coding_set_source): Return how many bytes coding->source was
2891 relocated.
2892 (coding_set_destination): Return how many bytes
2893 coding->destination was relocated.
2894 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2895 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2896
28972011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2898
2899 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2900 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2901 macro (Bug#9318).
2902
29032011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2904
2905 The following changes are to fix Bug#9318.
2906
a79703f5 2907 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2908 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2909 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2910 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2911
7dbda6df
JB
29122011-12-05 Juanma Barranquero <lekktu@gmail.com>
2913
2914 * lisp.h (process_quit_flag): Fix external declaration.
2915
6d5eb5b0
SM
29162011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2917
2918 Don't macro-inline non-performance-critical code.
2919 * eval.c (process_quit_flag): New function.
2920 * lisp.h (QUIT): Use it.
2921
a0c3fad0
JD
29222011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2923
2924 * nsfns.m (get_geometry_from_preferences): New function.
2925 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2926
6c07aac2
AS
29272011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2928
2929 * emacs.c (Qkill_emacs): Define.
2930 (syms_of_emacs): Initialize it.
2931 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2932 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2933 (quit_throw_to_read_char): Add parameter `from_signal'.
2934 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
2935 * lisp.h (QUIT): Call Fkill_emacs if requested.
2936
c052ead4
JD
29372011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2938
2939 * widget.c (update_wm_hints): Return if wmshell is null.
2940 (widget_update_wm_size_hints): New function.
2941
2942 * widget.h (widget_update_wm_size_hints): Declare.
2943
2944 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2945 widget_update_wm_size_hints (Bug#10104).
2946
9e49252b
EZ
29472011-12-03 Eli Zaretskii <eliz@gnu.org>
2948
2949 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2950 before a newline, prepare the bidi iterator for consuming the
2951 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 2952 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 2953
02b16839
JL
29542011-12-02 Juri Linkov <juri@jurta.org>
2955
2956 * search.c (Fword_search_regexp): New Lisp function created from
2957 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2958 (Fword_search_backward, Fword_search_forward)
2959 (Fword_search_backward_lax, Fword_search_forward_lax):
2960 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2961 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2962
0068070e
SM
29632011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2964
2965 * fileio.c (Finsert_file_contents): Move after-change-function call
2966 to before the "handled:" label, since all "goto handled" appear in
2967 cases where the *-change-functions have already been properly called
2968 (bug#10117).
2969
3360a3fc
AS
29702011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2971
2972 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2973 waiting for input. (Bug#10169)
2974
73d6c093
EZ
29752011-11-30 Eli Zaretskii <eliz@gnu.org>
2976
2977 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2978 verifies glyph row's hash code--we have just reallocated the
2979 glyphs, so their contents can be complete garbage. (Bug#10164)
2980
febe6bea
JB
29812011-11-30 Juanma Barranquero <lekktu@gmail.com>
2982
2983 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2984
801a4313
EZ
29852011-11-30 Eli Zaretskii <eliz@gnu.org>
2986
2987 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2988 attributes are tested _before_ calling verify_row_hash, to protect
2989 against GCC re-ordering of the tests. (Bug#10164)
2990
2b56b87e
JD
29912011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2992
2993 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2994
2995 * xterm.c (handle_one_xevent): Only set async_visible and friends
2996 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 2997 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
2998 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2999
dbf31225
PE
30002011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3001
3002 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3003 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3004 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3005 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3006 All uses changed to use GCPRO1 etc.
3007 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3008 Revert to old implementation (i.e., before 2011-03-11).
3009
1305621b
YM
30102011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3011
3012 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3013 of scroll runs so as to avoid assigning disabled bogus rows and
3014 unnecessary graphics copy operations.
3015
8c9afb46
EZ
30162011-11-27 Eli Zaretskii <eliz@gnu.org>
3017
3018 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3019 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3020 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3021 (malloc, free, realloc, calloc): Redirect to e_* only when
3022 compiling Emacs.
3023
3024 * lisp.h (GCTYPEBITS): Move before first use.
3025 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3026 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3027 this macro definition.
3028
3029 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3030 _MSC_VER.
3031
54e9e3bf
JD
30322011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3033
6d5eb5b0
SM
3034 * gtkutil.c (xg_create_frame_widgets):
3035 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3036 present with Gtk+ 2.0.
3037
83aca1cb
PE
30382011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3039
3040 * fileio.c (Finsert_file_contents): Undo previous change; see
3041 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3042
5b76caa4
PE
30432011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3044
3045 Rename locals to avoid shadowing.
3046 * fileio.c (Finsert_file_contents):
3047 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3048 * process.c (wait_reading_process_output):
3049 Rename inner 'proc' to 'p' to avoid shadowing.
3050 Indent for consistency with usual Emacs style.
3051
8c535114
EZ
30522011-11-25 Eli Zaretskii <eliz@gnu.org>
3053
3054 * xdisp.c (redisplay_window): If cursor row is not fully visible
3055 after recentering, and scroll-conservatively is set to a large
3056 number, scroll window by a few more lines to make the cursor fully
3057 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3058 (start_display): Don't move to the next line if the display should
3059 start at a newline that is part of a display vector or an overlay
3060 string. (Bug#10119)
8c535114 3061
fa4fdb5c
JL
30622011-11-24 Juri Linkov <juri@jurta.org>
3063
3064 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3065 after the `MagickPingImage' call. (Bug#10112)
3066
90ec88df
CY
30672011-11-23 Chong Yidong <cyd@gnu.org>
3068
3069 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3070
56e2e794
MR
30712011-11-23 Martin Rudalics <rudalics@gmx.at>
3072
3073 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3074 making another buffer current. (Bug#10114)
3075
b6e64c41
GM
30762011-11-23 Glenn Morris <rgm@gnu.org>
3077
3078 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3079
6b21de18
CY
30802011-11-23 Chong Yidong <cyd@gnu.org>
3081
3082 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3083 using it (Bug#5984).
3084
b12cd789
EZ
30852011-11-22 Eli Zaretskii <eliz@gnu.org>
3086
3087 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3088 and header-lines, as they don't have one computed for them.
3089 (Bug#10098)
3090
3091 * .gdbinit (prow): Make displayed values more self-explaining.
3092 Add row's hash code.
3093
261b6fd4
LMI
30942011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3095
3096 * process.c (wait_reading_process_output): Fix asynchrounous
3097 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3098 (wait_reading_process_output): Add comment and URL.
261b6fd4 3099
e7cfd277
JD
31002011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3101
3102 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3103
a9b9b7f5
CY
31042011-11-21 Chong Yidong <cyd@gnu.org>
3105
3106 * window.c (Fnext_window, Fprevious_window): Doc fix.
3107
b0d15b4f
SM
31082011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3109
3110 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3111
fe7a3057
JB
31122011-11-20 Juanma Barranquero <lekktu@gmail.com>
3113
3114 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3115
d2999b1a
MR
31162011-11-20 Martin Rudalics <rudalics@gmx.at>
3117
3118 * window.c (Fset_window_combination_limit): Rename argument
3119 STATUS to LIMIT.
3120 (Vwindow_combination_limit): Remove "status" from doc-string.
3121
d5ff9cd0
AS
31222011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3123
3124 * m/ibms390.h: Remove.
3125 * m/ibms390x.h: Don't include "ibms390.h".
3126
a5bb9bd3
SM
31272011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3128
3129 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3130 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3131
cd1181db
JB
31322011-11-20 Juanma Barranquero <lekktu@gmail.com>
3133
3134 * casetab.c (Fset_case_table):
3135 * charset.c (Fcharset_after): Fix typos.
3136
615a3b8d 31372011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3138
17e845af
PE
3139 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3140 Otherwise, valgrind does not work on some platforms.
3141 Problem reported by Andreas Schwab in
6a0bf43d
PE
3142 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3143 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3144 is set, removing the need for VIRT_ADDRESS_VARIES.
3145 (PURE_P): Use a more-efficient implementation that needs just one
3146 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3147 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3148 to 4 (xorl, subq, cmpq, setbe).
3149 * alloc.c (pure): Always extern now, since that's the
3150 VIRT_ADDR_VARIES behavior.
3151 (PURE_POINTER_P): Use a single comparison, not two, for
3152 consistency with the new puresize.h.
3153 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3154 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3155 Remove VIRT_ADDR_VARIES no longer needed.
3156
f8fe6f96
EZ
31572011-11-19 Eli Zaretskii <eliz@gnu.org>
3158
3159 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3160 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3161 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3162 behave as if the cursor position were at the window margin.
3163
3164 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3165 and the cursor position is out of bounds, behave as if the cursor
3166 position were at the window margin. (Bug#10075)
3167
df05a53c
CY
31682011-11-18 Chong Yidong <cyd@gnu.org>
3169
3170 * window.c (Fwindow_combination_limit): Make first argument
3171 non-optional, since it is meaningless for live windows like the
3172 selected window.
61ccba97 3173
2071918e
DA
31742011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3175
3176 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3177
b50a28de
SM
31782011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3179
3180 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3181 (graft_intervals_into_buffer): Simplify.
3182
015137db
EZ
31832011-11-18 Eli Zaretskii <eliz@gnu.org>
3184
3185 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3186 hash values of the two rows.
3187 (copy_row_except_pointers): Preserve the used[] arrays and the
3188 hash values of the two rows. (Bug#10035)
68c95424 3189 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3190
3191 * xdisp.c (row_hash): New function, body extracted from
3192 compute_line_metrics.
3193 (compute_line_metrics): Call row_hash, instead of computing the
3194 hash code inline.
3195
3196 * dispnew.c (verify_row_hash): Call row_hash for computing the
3197 hash code of a row, instead of duplicating code from xdisp.c.
3198
3199 * dispextern.h (row_hash): Add prototype.
3200
a2addb04
TH
32012011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3202
3203 * frame.c (delete_frame): Don't delete the terminal when the last
3204 X frame is closed if emacs is built with GTK toolkit.
3205
df85d315
JB
32062011-11-17 Juanma Barranquero <lekktu@gmail.com>
3207
3208 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3209
a0c2d0ae
MR
32102011-11-17 Martin Rudalics <rudalics@gmx.at>
3211
3212 * window.c (Vwindow_splits): Rename to
3213 Vwindow_combination_resize. Suggested by Juri Linkov.
3214 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3215 of Vwindow_splits.
3216
58179cce
JB
32172011-11-16 Juanma Barranquero <lekktu@gmail.com>
3218
7877f373
JB
3219 * nsfns.m (Fns_font_name):
3220 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3221
b6f67890
MR
32222011-11-16 Martin Rudalics <rudalics@gmx.at>
3223
3224 * window.h (window): Rename slot "nest" to "combination_limit".
3225 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3226 (Fset_window_nest): Rename to Fset_window_combination_limit.
3227 (Vwindow_nest): Rename to Vwindow_combination_limit.
3228 (recombine_windows, make_parent_window, make_window)
3229 (Fsplit_window_internal, saved_window)
3230 (Fset_window_configuration, save_window_save): Rename all
3231 occurrences of window_nest to window_combination_limit.
3232
c7015153
JB
32332011-11-15 Juanma Barranquero <lekktu@gmail.com>
3234
3235 * image.c (imagemagick_load_image): Fix typo.
3236
322ad6ec
EZ
32372011-11-14 Eli Zaretskii <eliz@gnu.org>
3238
3239 * xdisp.c (display_line): Move the call to
3240 highlight_trailing_whitespace before the call to
3241 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3242 faces of all the glyphs to compute ROW's hash value.
3243 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3244
f067b8ec
JB
32452011-11-14 Juanma Barranquero <lekktu@gmail.com>
3246
3247 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3248 just return (bug#10044).
3249
1e5b2111
EZ
32502011-11-12 Eli Zaretskii <eliz@gnu.org>
3251
7ef3cbd5
EZ
3252 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3253 with user-defined heap size. Bump the default size of the temacs
3254 heap to 27MB, to avoid memory warning when running temacs.
3255 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3256
1e5b2111
EZ
3257 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3258 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3259 (verify_row_hash) [XASSERTS]: New function.
3260 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3261 that the hash value of glyph rows is correct.
1e5b2111 3262
89d61221
MR
32632011-11-12 Martin Rudalics <rudalics@gmx.at>
3264
3265 * window.h (window): Remove splits slot.
3266 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3267 (Fdelete_other_windows_internal, make_parent_window)
3268 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3269 (Fset_window_configuration, save_window_save): Don't deal with
3270 split status of windows.
3271 (saved_window): Remove splits slot.
3272 (Vwindow_splits): Rewrite doc-string.
3273
97f18cc8
JD
32742011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3275
3276 * xfns.c (unwind_create_frame):
3277 * nsfns.m (unwind_create_frame):
3278 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3279 Vframe_list (Bug#9999).
3280
22a648b4
DA
32812011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3282
0b381c7e 3283 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3284
659afede
KH
32852011-11-11 Kenichi Handa <handa@m17n.org>
3286
3287 * callproc.c (Fcall_process): Set the member dst_multibyte of
3288 process_coding.
3289
9ac0394b
KH
32902011-11-11 Johan Bockgård <bojohan@gnu.org>
3291
3292 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3293 avoid a crash (bug#9496).
3294
2fbdc249
CY
32952011-11-09 Chong Yidong <cyd@gnu.org>
3296
3297 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3298 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3299
ac6b1f81
PE
33002011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3301
3302 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3303
09db192c
PE
33042011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3305
3306 Avoid some portability problems by eschewing 'extern inline' functions.
3307 The trivial performance wins aren't worth the portability hassles; see
3308 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3309 et seq.
3310 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3311 (window_box_width, window_box_left, window_box_left_offset)
3312 (window_box_right, window_box_right_offset): Undo previous change,
3313 by removing the "extern"s.
3314 * intervals.c (adjust_intervals_for_insertion)
3315 (adjust_intervals_for_deletion): Undo previous change,
3316 making these static again.
3317 (offset_intervals, temp_set_point_both, temp_set_point)
3318 (copy_intervals_to_string): No longer inline.
3319 * xdisp.c (window_text_bottom_y, window_box_width)
3320 (window_box_height, window_box_left_offset)
3321 (window_box_right_offset, window_box_left, window_box_right)
3322 (window_box): No longer inline.
3323
105216ed
CY
33242011-11-08 Chong Yidong <cyd@gnu.org>
3325
3326 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3327 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3328 Signal an error if not a live window.
105216ed
CY
3329 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3330 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3331
ae9e237f
JB
33322011-11-07 Juanma Barranquero <lekktu@gmail.com>
3333
3334 * lisp.h (syms_of_abbrev): Remove declaration.
3335 Reported by CHENG Gao <chenggao@royau.me>.
3336
c7aa8333
EZ
33372011-11-07 Eli Zaretskii <eliz@gnu.org>
3338
3339 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3340 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3341 of temacs in GUI mode.
3342
be7f5545
MR
33432011-11-07 Martin Rudalics <rudalics@gmx.at>
3344
3345 * window.h: Declare delete_all_child_windows instead of
3346 delete_all_subwindows.
3347 * window.c (Fwindow_nest, Fset_window_nest)
3348 (Fset_window_new_total, Fset_window_new_normal)
3349 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3350 (delete_all_subwindows): Rename to delete_all_child_windows.
3351 (Fdelete_other_windows_internal, Fset_window_configuration):
3352 Call delete_all_child_windows instead of delete_all_subwindows.
3353 * frame.c (delete_frame): Call delete_all_child_windows instead
3354 of delete_all_subwindows.
3355
ca78dc43
PE
33562011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3357
3358 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3359 This is also needed for porting to any host where GC_MARK_STACK is
3360 not GC_MAKE_GCPROS_NOOPS.
3361 (which_symbols): Use it.
3362
a0241d01
KH
33632011-11-07 Kenichi Handa <handa@m17n.org>
3364
3365 * coding.c (coding_set_destination): Check coding->src_pos only
3366 when coding->src_object is a buffer (bug#9910).
3367
3368 * process.c (send_process): Set the member src_multibyte of coding
3369 to 0 (bug#9911) when sending a unibyte text.
3370
3371 * callproc.c (Fcall_process): Set the member src_multibyte of
3372 process_coding to 0 (bug#9912).
3373
a64bfdfa 33742011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3375
3376 * xmenu.c (cleanup_widget_value_tree): New function.
3377 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3378 calling free_menubar_widget_value_tree directly (Bug#9830).
3379
cb41b32a
PE
33802011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3381
3382 Fix some portability problems with 'inline'.
3383 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3384 (window_box_width, window_box_left, window_box_left_offset)
3385 (window_box_right, window_box_right_offset): Declare extern.
3386 Otherwise, these inline functions do not conform to C99 and
3387 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3388 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3389 * intervals.c (adjust_intervals_for_insertion)
3390 (adjust_intervals_for_deletion): Now extern, because otherwise the
3391 extern inline functions 'offset_intervals' couldn't refer to it.
3392 (static_offset_intervals): Remove.
3393 (offset_intervals): Rewrite using the old contents of
3394 static_offset_intervals. The old version didn't conform to C99
3395 because an extern inline function contained a reference to an
3396 identifier with static linkage.
3397
b7041366
AS
33982011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3399
3400 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3401 GC.
3402
88a37c4d
EZ
34032011-11-06 Eli Zaretskii <eliz@gnu.org>
3404
3405 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3406 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3407 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3408 return Qleft_to_right.
3409
49745b39
CY
34102011-11-06 Chong Yidong <cyd@gnu.org>
3411
3412 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3413 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3414 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3415 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3416 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3417 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3418 (Fwindow_vscroll): Doc fix.
3419 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3420 argument, since it makes no sense to pass a live window and for
3421 consistency with window-child.
3422
1f05cd82
CS
34232011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3424
3425 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3426 support MSVC.
3427
22610910
JR
34282011-11-05 Jason Rumney <jasonr@gnu.org>
3429
3430 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3431 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3432 fonts (Bug#6029).
3433 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3434 bitwise arithmetic preventing use of unicode-sip and non-truetype
3435 opentype fonts.
3436
a06776b2
EZ
34372011-11-05 Eli Zaretskii <eliz@gnu.org>
3438
3ad924ba
EZ
3439 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3440 "emacs"-only part.
3441
a06776b2
EZ
3442 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3443 initialization code to keep similarity to xfns.c after changes
3444 from 2011-11-05.
3445
c9e7db78
JD
34462011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3447
a97f8f3f
JD
3448 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3449 (unwind_create_frame): New function (Bug#9943).
3450 (Fx_create_frame): Restructure code to be more similar to the one in
3451 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3452 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3453 Move terminal->reference_count++ just before making the frame official
3454 (Bug#9943).
3455
3456 * nsterm.m (x_free_frame_resources): New function.
3457 (x_destroy_window): Move code to x_free_frame_resources.
3458
c9e7db78 3459 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3460 (Fx_create_frame, x_create_tip_frame):
3461 Move terminal->reference_count++ just before making the frame
75f1671a 3462 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3463 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3464
a6fc3b5c
EZ
34652011-11-05 Eli Zaretskii <eliz@gnu.org>
3466
3467 Support MSVC build with newer versions of Visual Studio.
3468 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3469 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3470 nt/gmake.defs.
3471
3472 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3473 which are not supported by MSVC.
3474 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3475 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3476 bitfields.
3477 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3478 types in bitfields.
3479 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3480
3481 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3482
58179cce 34832011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3484
3485 Support MSVC build with newer versions of Visual Studio.
3486 * w32.c: Don't include w32api.h for MSVC.
3487 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3488
3489 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3490 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3491 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3492 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3493 e_* cousins.
3494 (alloca) [_MSC_VER]: Define to _alloca.
3495
3496 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3497
3498 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3499
a58c13ed
EZ
35002011-11-04 Eli Zaretskii <eliz@gnu.org>
3501
3502 * xdisp.c (note_mouse_highlight): If either of
3503 previous/next-single-property-change returns nil, treat that as
3504 the beginning or the end of the buffer. (Bug#9955)
3505
fe0b6370
JD
35062011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3507
a58c13ed 3508 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3509 label is not null (Bug#9951).
3510 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3511 may be NULL.
3512
89bd5ee1
EZ
35132011-11-04 Eli Zaretskii <eliz@gnu.org>
3514
3515 * window.c (Fwindow_body_size): Mention in the doc string that the
3516 return value is in frame's canonical units. (Bug#9949)
3517
84c3edb9
EZ
35182011-11-03 Eli Zaretskii <eliz@gnu.org>
3519
4e2fb5c7
EZ
3520 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3521
84c3edb9 3522 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3523 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3524 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3525
bc17a887
EZ
35262011-11-01 Eli Zaretskii <eliz@gnu.org>
3527
3528 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3529 Don't stop backward scan on the continuation glyph, even though
3530 its CHARPOS is positive.
6d5eb5b0
SM
3531 (mouse_face_from_buffer_pos, note_mouse_highlight):
3532 Rename cover_string to disp_string.
bc17a887 3533
4ee88440
MR
35342011-11-01 Martin Rudalics <rudalics@gmx.at>
3535
3536 * window.c (temp_output_buffer_show): Don't use
3537 Vtemp_buffer_show_specifiers.
3538 (Vtemp_buffer_show_specifiers): Remove unused variable.
3539
c2ff3c02
EZ
35402011-10-30 Eli Zaretskii <eliz@gnu.org>
3541
3542 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3543 past the beginning of the current glyph matrix.
3544
58179cce 35452011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3546
3547 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3548 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3549 HAVE_GTK3 (Bug#9869).
b77a6a7f 3550
3b574623
JD
3551 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3552 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3553
b77a6a7f
JD
3554 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3555
3556 * xterm.c: Declare x_handle_net_wm_state to return int.
3557 (handle_one_xevent): Check if we are iconified but don't have
3558 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3559 (get_current_wm_state): Return non-zero if not hidden,
3560 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3561 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3562 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3563 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3564
196e41e4
PE
35652011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3566
3567 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3568 so that this new function doesn't get optimized away by a
3569 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3570
021f2e1a
AS
35712011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3572
3573 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3574
8b058d44
EZ
35752011-10-29 Eli Zaretskii <eliz@gnu.org>
3576
3577 Fix the `xbytecode' command.
3578 * .gdbinit (xprintbytestr): New command.
b50a28de 3579 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3580 (xbytecode): Print the byte-code string as well.
3581
4452fb80
EZ
35822011-10-29 Kim Storm <storm@cua.dk>
3583
8b058d44
EZ
3584 * alloc.c (which_symbols): New function.
3585
21b72067
AS
35862011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3587
3588 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3589 line. (Bug#9903)
3590
83ed7b5c
GM
35912011-10-29 Glenn Morris <rgm@gnu.org>
3592
3593 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3594 Not clear what it was for, and it causes various bugs. (Bug#9839)
3595
5a7a728b
EZ
35962011-10-28 Eli Zaretskii <eliz@gnu.org>
3597
3598 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3599 possible random value that matches one of those tested as
3600 condition to clear the mouse face.
3601
d3d0842f
CY
36022011-10-28 Chong Yidong <cyd@gnu.org>
3603
3604 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3605
31b39d13
DN
36062011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3607
3608 * window.c (make_window): Initialize phys_cursor_on_p.
3609
9aba6043
SM
36102011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3611
3612 * lisp.h (struct Lisp_Symbol): Update comments.
3613
c20992f4
JB
36142011-10-28 Juanma Barranquero <lekktu@gmail.com>
3615
3616 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3617
db4f02f2
EZ
36182011-10-28 Eli Zaretskii <eliz@gnu.org>
3619
3620 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3621 <oslsachem@gmail.com> for helping to debug this.
3622
3623 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3624 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3625 (g_b_init_get_glyph_outline_w): New static variables.
3626 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3627 (GetGlyphOutlineW_Proc): New typedefs.
3628 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3629 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3630 New functions.
3631 (w32font_open_internal, compute_metrics):
3632 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3633 instead of calling the "wide" APIs directly.
3634
3635 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3636
3637 * w32.h (syms_of_w32font): Add prototype.
3638
87e68db4
JB
36392011-10-27 Juanma Barranquero <lekktu@gmail.com>
3640
3641 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3642 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3643 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3644 (Fmove_to_window_line): Doc fix.
3645
435c1d67
CY
36462011-10-27 Chong Yidong <cyd@gnu.org>
3647
3648 * process.c (make_process): Set gnutls_state to NULL.
3649
3650 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3651 non-NULL, regardless of GNUTLS_INITSTAGE.
3652 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3653 an error. Set process slots as soon as we allocate them.
3654
3655 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3656
9c6c6f49
CY
36572011-10-27 Chong Yidong <cyd@gnu.org>
3658
9aba6043
SM
3659 * gnutls.c (emacs_gnutls_deinit): New function.
3660 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3661 (Fgnutls_deinit, Fgnutls_boot): Use it.
3662
3663 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3664 (deactivate_process): Call emacs_gnutls_deinit.
3665
657d08d3
JB
36662011-10-27 Juanma Barranquero <lekktu@gmail.com>
3667
3668 * image.c (x_create_x_image_and_pixmap):
3669 * w32.c (sys_rename, w32_delayed_load):
3670 * w32font.c (fill_in_logfont):
3671 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3672
5430d399
JB
36732011-10-26 Juanma Barranquero <lekktu@gmail.com>
3674
3675 * w32fns.c (w32_default_color_map): New function,
3676 extracted from Fw32_default_color_map.
a7ef684b 3677 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3678
fe0055fa
PE
36792011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3680
3681 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3682
e6346438
SM
36832011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3684
3685 * keyboard.c (test_undefined): New function (bug#9751).
3686 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3687
e112cc37
ET
36882011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3689
3690 * sysdep.c (init_sys_modes): Fix the check for the controlling
3691 terminal (Bug#6649).
3692
7b5d6677
EZ
36932011-10-20 Eli Zaretskii <eliz@gnu.org>
3694
3695 * dispextern.h (struct bidi_it): New member next_en_type.
3696
3697 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3698 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3699 current character, check also for next_en_type being WEAK_EN.
3700 (bidi_resolve_weak): Don't enter the expensive loop if the current
3701 position is before next_en_pos. Record the bidi type of the first
3702 non-ET, non-BN character we find, in addition to its position.
3703 (bidi_level_of_next_char): Invalidate next_en_type when
3704 next_en_pos is over-stepped.
3705
7da0b018
PE
37062011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3707
3708 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3709 * editfns.c: Rewrite current-time-zone so that it invokes
3710 the equivalent of (format-time-string "%Z") to get the time zone name.
3711 This fixes a bug when the time zone name contains characters that
3712 need converting from the system time locale to Emacs internal format.
3713 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3714 that patch fixed format-time-string to do the conversion, but
3715 I forgot to fix current-time-zone.
3716 (format_time_string): New function, containing most of
3717 what Fformat_time_string used to contain.
3718 (Fformat_time_string): Rewrite in terms of format_time_string.
3719 This doesn't change this function's behavior.
3720 (current-time-zone): Rewrite to use format_time_string.
3721 This fixes the bug reported by Michael Schierl in
3722 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3723 Jason Rumney's 2007-06-07 change worked around this bug, but
3724 didn't fix it.
3725 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3726
8547b010
EZ
37272011-10-19 Eli Zaretskii <eliz@gnu.org>
3728
3729 * xdisp.c (start_display): If the character at POS is displayed
3730 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3731 (try_window_reusing_current_matrix): If a line ends in a display
3732 vector or the next line starts in a display vector, continue
3733 redrawing the window even though the character position of
3734 start_row was reached.
8547b010
EZ
3735 (Bug#9771, part 2)
3736
4e948d15
CY
37372011-10-18 Chong Yidong <cyd@gnu.org>
3738
3739 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3740 with nobreak-char-display too.
3741
4787455f
EZ
37422011-10-18 Eli Zaretskii <eliz@gnu.org>
3743
3744 Fix part 3 of bug#9771.
3745 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3746 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3747 non-neutral characters if the current character is a paragraph
3748 separator (a.k.a. Newline). This avoids running the same
3749 expensive loop twice, once when we consume the preceding newline
3750 and the other time when the line actually needs to be displayed.
3751 Avoid the loop when we see neutrals on the base embedding level
3752 following a character whose directionality is the same as the
3753 paragraph's. This avoids running the expensive loop when a line
3754 ends in a long sequence of neutrals, like control characters.
3755 Add assertion against STRONG_AL type. Slightly rearrange code
3756 that determines the type of a neutral given the first non-neutral
3757 that follows it.
3758 (bidi_level_of_next_char): Set next_en_pos to zero when
3759 invalidating its info.
3760
2c91f553
EZ
37612011-10-17 Eli Zaretskii <eliz@gnu.org>
3762
3763 * xdisp.c (push_display_prop): Determine whether to record string
3764 or buffer position by IT->string, not by IT->method. Allow
3765 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3766 (move_it_vertically_backward): Don't look for character position
3767 immediately after the newline when in a continuation line.
3768 (Bug#9771, part 1)
2c91f553 3769
c7b08b0d
MR
37702011-10-15 Martin Rudalics <rudalics@gmx.at>
3771
3772 * window.c (coordinates_in_window): Rewrite and delabelize
3773 vertical border check. (Bug#5357) (Bug#9618)
3774
6b02f655
SM
37752011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3776
3777 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3778 errors in XSetWindowBorder (bug#9310).
3779
81d40c92
DA
37802011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3781
3782 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3783 avoid crash when xmalloc overrun checking is enabled.
3784
d4172c3b
EZ
37852011-10-13 Eli Zaretskii <eliz@gnu.org>
3786
3787 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3788 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3789 cursor motion with <left> and <right> arrow keys.
3790
3791 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3792 some callers set that themselves.
3793
b00eea75
EZ
37942011-10-12 Eli Zaretskii <eliz@gnu.org>
3795
3796 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3797 display string and the previous row comes from the same string and
3798 is empty. (Bug#9739) (Bug#9738)
3799
8fe012c4
SM
38002011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3801
3802 * doc.c (get_doc_string): Encode file name (bug#9735).
3803
0074aef2
EZ
38042011-10-12 Eli Zaretskii <eliz@gnu.org>
3805
79beb178
EZ
3806 * bidi.c (bidi_level_of_next_char):
3807 * xdisp.c (get_visually_first_element): Remove old incorrect
3808 comments regarding the Unicode Line Separator character.
3809
0074aef2
EZ
3810 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3811
6e4b3fbe
DA
38122011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3813
3814 * alloc.c (Fgc_status): Do not access beyond zombies array
3815 boundary if nzombies > MAX_ZOMBIES.
3816 * alloc.c (dump_zombies): Add missing format specifier.
3817
0324f3af
PE
38182011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3819
b5525cac
PE
3820 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3821 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3822
0324f3af
PE
3823 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3824 Some packages use them to denote characters with modifiers.
3825
e9b5f888
AS
38262011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3827
3828 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3829 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3830 matching a pp-number. Rename parameter var to var1.
3831
127827c0
SM
38322011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3833
3834 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3835
c8fd3bd0
GM
38362011-10-08 Glenn Morris <rgm@gnu.org>
3837
3838 * callint.c (Fcall_interactively): Give a more explicit error for the
3839 'c' case with a non-character input. (Bug#8479)
3840
352ec8ff
EZ
38412011-10-08 Eli Zaretskii <eliz@gnu.org>
3842
03669ccb
EZ
3843 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3844 lines.
7061c986
EZ
3845 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3846 lines that are hscrolled on the left.
03669ccb 3847
352ec8ff
EZ
3848 * dispnew.c (buffer_posn_from_coords): Account for a possible
3849 presence of header-line. (Bug#4426)
3850
a66cfb1c
SM
38512011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3852
6b02f655
SM
3853 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3854 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3855
7c5ee88e
PE
38562011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3857
3858 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3859 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3860 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3861 this makes Emacs dump core during garbage collection on rare
3862 occasions. sizeof is obviously inferior to offsetof here, so
3863 stick with offsetof.
3864 (GC_POINTER_ALIGNMENT): New macro.
3865 (mark_memory): Omit 3rd (offset) arg; caller changed.
3866 Don't assume EMACS_INT alignment is the same as pointer alignment.
3867
df1bbe5b
SM
38682011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3869
3870 * keyboard.c (read_key_sequence_remapped): New var.
3871 (read_key_sequence): Compute remapping in the right buffer.
3872 (command_loop_1): Use read_key_sequence's remapping directly.
3873
51553db6
SM
38742011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3875
32c1fffd
SM
3876 * dired.c (file_name_completion): Don't expand file name.
3877 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3878 before checking file name handler.
3879
51553db6
SM
3880 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3881 they've been requested explicitly (bug#9591).
3882
b6bd1599 38832011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3884
3885 * keymap.c (Fsingle_key_description): Use make_specified_string
3886 instead of build_string to build string from push_key_description.
3887 (Bug#5193)
3888
f701dc2a
PE
38892011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3890
4222c55d
PE
3891 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3892 This fixes a Y2038 bug on 64-bit hosts.
3893 * buffer.c (reset_buffer):
3894 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3895 (Fclear_buffer_auto_save_failure):
3896 Use 0, not -1, to represent an unset failure time, since time_t
3897 might not be signed.
3898
f701dc2a
PE
3899 Remove dependency on glibc malloc internals.
3900 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3901 Move back here from lisp.h, but with their new implementations.
3902 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3903 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3904 * charset.c (charset_table_init): New static var.
3905 (syms_of_charset): Use it instead of xmalloc. This removes a
3906 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3907 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3908 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3909 Move back to alloc.c.
3910 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3911 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3912
9ceebf39
JD
39132011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3914
3915 * nsterm.m (windowDidResize): Call x_set_window_size only when
3916 ns_in_resize is true. Otherwise set pixelwidth/height and
3917 call change_frame_size (Bug#9628).
3918
cb993c58
PE
39192011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3920
3930c88b
PE
3921 Port --enable-checking=all to Fedora 14 x86-64.
3922 * charset.c (syms_of_charset): Also account for glibc malloc's
3923 internal overhead when calculating the initial malloc maximum.
3924
cb993c58
PE
3925 Port --enable-checking=all to Fedora 14 x86.
3926 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3927 Move to lisp.h.
3928 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3929 (overrun_check_realloc, overrun_check_free):
3930 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3931 That way, xmalloc returns a properly-aligned pointer even if
3932 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3933 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3934 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3935 into account when calculating the initial malloc maximum.
3936 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3937 Move here from alloc.c, so that charset.c can use it too.
3938 Properly align; the old code wasn't right for common 32-bit hosts
3939 when configured with --enable-checking=all.
3940 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3941 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3942
31bed486
EZ
39432011-09-29 Eli Zaretskii <eliz@gnu.org>
3944
04c70788 3945 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
3946 use EDOM.
3947
fbcaa2f3
EZ
39482011-09-28 Eli Zaretskii <eliz@gnu.org>
3949
3950 * xdisp.c (compute_display_string_end): If there's no display
3951 string at CHARPOS, return -1.
3952
3953 * bidi.c (bidi_fetch_char): When compute_display_string_end
3954 returns a negative value, treat the character as a normal
3955 character not covered by a display string. (Bug#9624)
3956
a239d4e9
JB
39572011-09-28 Juanma Barranquero <lekktu@gmail.com>
3958
3959 * lread.c (Fread_from_string): Fix typo in docstring.
3960
88652fd5
EZ
39612011-09-27 Eli Zaretskii <eliz@gnu.org>
3962
3963 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3964 newline, reseat the iterator instead of bidi-iterating there one
3965 character at a time. (Bug#9610)
32c1fffd
SM
3966 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3967 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 3968
ed497dd4
AS
39692011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3970
3971 * lread.c (readevalloop): Use correct code for NBSP.
3972 (read1): Likewise. (Bug#9608)
3973
b2bf61aa
MA
39742011-09-25 Michael Albinus <michael.albinus@gmx.de>
3975
3976 * dbusbind.c (Fdbus_register_signal): When service is not
3977 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3978
32bbb17c
GM
39792011-09-25 Glenn Morris <rgm@gnu.org>
3980
3981 * buffer.c (truncate-lines): Doc fix.
3982
94e0933e
CY
39832011-09-24 Chong Yidong <cyd@stupidchicken.com>
3984
3985 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3986 (Fset_window_next_buffers): Doc fix.
3987
cddde921
GM
39882011-09-24 Glenn Morris <rgm@gnu.org>
3989
3990 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3991
1260aef1
PE
39922011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3993
25b4bfa0
PE
3994 Fix minor problems found by static checking.
3995 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
3996 * indent.c (Fvertical_motion): Fix == vs = typo.
3997
e3cbd34b
EZ
39982011-09-24 Eli Zaretskii <eliz@gnu.org>
3999
a66cfb1c
SM
4000 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4001 Default value is now t. Doc fix.
6bf7006f 4002
e3cbd34b 4003 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4004 logic when moving up, not only when moving down. Fix the
e3cbd34b 4005 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4006 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4007
4008 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4009 CHARPOS is covered by a display string which includes newlines.
4010 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4011 is covered by a display string with embedded newlines.
4012
a3de0cbd
MA
40132011-09-24 Michael Albinus <michael.albinus@gmx.de>
4014
4015 * dbusbind.c (Fdbus_register_signal): Add match rule to
4016 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4017 (Fdbus_register_method, Vdbus_registered_objects_table):
4018 Fix docstring.
a3de0cbd 4019
b260039d
JM
40202011-09-24 Jim Meyering <meyering@redhat.com>
4021
32c1fffd 4022 do not ignore write error for any output size
b260039d
JM
4023 The previous change was incomplete.
4024 While it makes emacs --batch detect the vast majority of stdout
4025 write failures, errors were still ignored whenever the output size is
4026 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4027 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4028 && echo FAIL: ignored write error
4029 FAIL: ignored write error
4030 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4031 && echo FAIL: ignored write error
4032 FAIL: ignored write error
4033 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4034
8eca8a7c
AS
40352011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4036
4037 * emacs.c (Fkill_emacs): In noninteractive mode exit
4038 non-successfully if a write error occurred on stdout. (Bug#9574)
4039
3341db62
EZ
40402011-09-21 Eli Zaretskii <eliz@gnu.org>
4041
4042 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4043 the xassert test.
4044
4045 * dispextern.h (struct it): Update the comment documenting what
4046 can it->OBJECT be.
4047
8c203dbf
EZ
40482011-09-20 Eli Zaretskii <eliz@gnu.org>
4049
4050 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4051 a display string, extend search for cursor position to end of row.
4052 (find_row_edges): If the row ends in a newline from a display
4053 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4054 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4055 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4056 non-empty line. Fixes confusing cursor motion with arrow keys at
4057 the beginning of a line that starts with whitespace.
8c203dbf 4058
a4824228
LMI
40592011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4060
4061 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4062 (bug#9493).
4063
33ed493b
CY
40642011-09-18 Chong Yidong <cyd@stupidchicken.com>
4065
4066 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4067 boolean (Bug#9154).
4068
56cd55c8
EZ
40692011-09-18 Eli Zaretskii <eliz@gnu.org>
4070
4071 * xdisp.c (display_line): Record maximum and minimum buffer
4072 positions even if no glyphs were produced (e.g., by a zero-width
4073 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4074 buffer positions that will be removed from the glyph row because
4075 they don't fit.
c02dcedf
EZ
4076 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4077 column is beyond frame width: don't subtract 1 "pixel" when
4078 computing width of the stretch.
3e62b7e0
EZ
4079 (reseat_at_next_visible_line_start): Undo the change made on
4080 2011-09-17 that saved paragraph information and restored it after
4081 the call to `reseat'. (Bug#9545)
56cd55c8 4082
5ed99d36 40832011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4084
4085 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4086 and turn window cursor on if cleared (Bug#9415).
4087
5ed99d36 40882011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4089
4090 * search.c (boyer_moore): Take unibyte characters from pattern
4091 literally. (Bug#9458)
4092
9bade7b2
EZ
40932011-09-18 Eli Zaretskii <eliz@gnu.org>
4094
4095 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4096
e5e9d610
PE
40972011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4098
87e4427a
PE
4099 Fix minor problem found by static checking.
4100 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4101 initialized, to pacify gcc -Wuninitialized.
4102
e5e9d610
PE
4103 * fileio.c: Report proper errno when syscall falls.
4104 (Finsert_file_contents): Save and restore errno,
4105 so that report_file_error outputs the correct diagnostic.
4106 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4107
a1674f0b
EZ
41082011-09-18 Eli Zaretskii <eliz@gnu.org>
4109
4110 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4111
fbfb6dd4
EZ
41122011-09-17 Eli Zaretskii <eliz@gnu.org>
4113
4114 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4115 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4116
bb187662
EZ
41172011-09-17 Eli Zaretskii <eliz@gnu.org>
4118
1137e8b8 4119 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4120 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4121
4122 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4123 (bidi_find_paragraph_start): Search back for paragraph beginning
4124 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4125 (bidi_move_to_visually_next): Only trigger paragraph-related
4126 computations when the last character is a newline or at EOB, not
4127 just any NEUTRAL_B. (Bug#9470)
4128
bb187662
EZ
4129 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4130 truncated lines if point is covered by a display string. (Bug#9524)
4131
2e621251
PE
41322011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4133
4134 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4135 (cons_to_x_long): New function.
4136 (lisp_data_to_selection_data): Use it. Correct the test for
4137 short-versus-long data; it was negated. Break out of vector
4138 loop, for efficiency, when a long datum is discovered.
4139
91a15bc6
SM
41402011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4141
4142 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4143
b41c3a35
EZ
41442011-09-16 Eli Zaretskii <eliz@gnu.org>
4145
4146 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4147 GCC PR/17406) by declaring this function with external scope.
4148
7812ba2d
PE
41492011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4150
4151 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4152 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4153
cf7edc2a
AS
41542011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4155
4156 * editfns.c (Fformat): Correctly handle text properties on "%%".
4157
bd01620e
EZ
41582011-09-15 Eli Zaretskii <eliz@gnu.org>
4159
4160 * xterm.c (x_draw_composite_glyph_string_foreground):
4161 * w32term.c (x_draw_composite_glyph_string_foreground):
4162 * term.c (encode_terminal_code):
4163 * composite.c (composition_update_it, get_composition_id):
4164 * xdisp.c (get_next_display_element)
4165 (fill_composite_glyph_string): Add comments about special meaning
4166 of TAB characters in a composition.
4167
a02719a3
PE
41682011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4169
4170 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4171 This occurs when processing a multibyte format.
4172 Problem reported by Wolfgang Jenker.
a02719a3 4173
72589a3c
JB
41742011-09-15 Johan Bockgård <bojohan@gnu.org>
4175
4176 * xdisp.c (try_cursor_movement): Only check for exact match if
4177 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4178
1c14176c
PE
41792011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4180
4181 Remove unused external symbols.
4182 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4183 * xdisp.c (calc_pixel_width_or_height): Now static.
4184 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4185 * indent.c (check_display_width):
4186 * w32term.c: Fix comment to match code.
4187 * xterm.c, xterm.h (x_catching_errors): Remove.
4188
d2eea5b5
PE
41892011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4190
4191 * xselect.c: Use signed conversions more consistently (Bug#9498).
4192 (selection_data_to_lisp_data): Assume incoming selection data are
4193 signed integers, not unsigned. This is to be consistent with
4194 outgoing selection data, which was modified to use signed integers
4195 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4196 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4197 expects long, not unsigned long.
4198
46888499
EZ
41992011-09-14 Eli Zaretskii <eliz@gnu.org>
4200
4201 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4202 computation of loop end. Reported by Johan Bockgård
4203 <bojohan@gnu.org>.
4204
ef8ef9fb
CY
42052011-09-13 Chong Yidong <cyd@stupidchicken.com>
4206
4207 * frame.c (Fother_visible_frames_p): Function deleted.
4208
fa819fed
EZ
42092011-09-12 Eli Zaretskii <eliz@gnu.org>
4210
4211 * indent.c (compute_motion): Process display vector front to back
4212 rather than the other way around. (Bug#2496)
4213
2ba8e008
SM
42142011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4215
4216 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4217
20f53c69
CY
42182011-09-11 Chong Yidong <cyd@stupidchicken.com>
4219
4220 * minibuf.c (Fread_from_minibuffer): Doc fix.
4221
d562d7a4
EZ
42222011-09-11 Eli Zaretskii <eliz@gnu.org>
4223
4224 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4225 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4226
1c4d7f3d
LMI
42272011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4228
4229 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4230 value for non-existent files.
4231
b885bf36
EZ
42322011-09-11 Eli Zaretskii <eliz@gnu.org>
4233
4234 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4235 set its "size" to -1. This will set the modtime_size field of
4236 the corresponding buffer to -1, which is what
4237 verify-visited-file-modtime expects for files that do not exist.
4238 (Bug#9139)
4239
6612f0bf
PE
42402011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4241
4242 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4243 here ...
4244 * lisp.h: ... from here. push_key_description is no longer
4245 defined in keyboard.c, so its declaration should not be in
4246 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4247 logically belongs with push_key_description.
4248
dfb3f755
PE
42492011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4250
4251 * buffer.h: Include <sys/types.h> instead of <time.h>.
4252 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4253 Problem reported by Herbert J. Skuhra.
4254
3134906c
LMI
42552011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4256
4257 * xml.c (parse_region): Make the parsing work for
4258 non-comment-starting XML files again (bug#9144).
4259
8d903f4e
AS
42602011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4261
4262 * image.c (gif_load): Fix calculation of bottom and right corner.
4263 (Bug#9468)
4264
80ad64f4
EZ
42652011-09-10 Eli Zaretskii <eliz@gnu.org>
4266
4267 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4268 redisplay in small windows.
4269
208a048d
EZ
42702011-09-09 Eli Zaretskii <eliz@gnu.org>
4271
4272 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4273
9b1c252e
MR
42742011-09-08 Martin Rudalics <rudalics@gmx.at>
4275
4276 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4277 Operate on live windows only.
4278
2949f33b
JB
42792011-09-08 Juanma Barranquero <lekktu@gmail.com>
4280
4281 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4282
e08dcafd
EZ
42832011-09-07 Eli Zaretskii <eliz@gnu.org>
4284
4285 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4286 only under bidi iteration.
4287
115b96bd
JD
42882011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4289
4290 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4291
c8199d0f
PE
42922011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4293
4294 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4295 Without this fix, the command to link temacs failed due to an
4296 undefined symbol __builtin_isnan. This is because
4297 /usr/include/iso/math_c99.h #defines isnan(x) to
4298 __builtin_isnan(x), but the bundled gcc, which identifies itself
4299 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4300 a __builtin_isnan.
4301 * floatfns.c (isnan): #undef, and then #define to a clone of
4302 what's in data.c.
4303 (Fisnan): Always define, since it's always available now.
4304 (syms_of_floatfns): Always define isnan at the Lisp level.
4305
e39b275c 43062011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4307
4308 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4309
b2db44d9 43102011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4311
f4af5137 4312 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4313 The previous code assumed that file offsets (off_t values) fit in
4314 EMACS_INT variables, which is not true on typical 32-bit hosts.
4315 The code messed up by falsely reporting buffer overflow in cases
4316 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4317 when "big" contains more than 2**29 bytes, even though this
4318 inserts just one byte and does not overflow the buffer.
4319 (Finsert_file_contents): Store file offsets as off_t
4320 values, not as EMACS_INT values. Check for overflow when
4321 converting between EMACS_INT and off_t. When checking for
4322 buffer overflow or for overlap, take the offsets into account.
4323 Don't use EMACS_INT for small values where int suffices.
4324 When checking for overlap, fix a typo: ZV was used where
4325 ZV_BYTE was intended.
4326 (Fwrite_region): Don't assume off_t fits into 'long'.
4327 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4328
ecfc0a49
MA
43292011-09-05 Michael Albinus <michael.albinus@gmx.de>
4330
4331 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4332
6511acf2 43332011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4334
0999621a 4335 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4336
4337 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4338 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4339 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4340 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4341 (modify_event_symbol): Do not assume that the length of
4342 name_alist_or_stem is safe to alloca and fits in int.
4343 (Fexecute_extended_command): Likewise for function name and binding.
4344 (Frecursion_depth): Wrap around reliably on integer overflow.
4345 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4346 since some callers pass EMACS_INT values.
4347 (Fsingle_key_description): Don't crash if symbol name contains more
4348 than MAX_ALLOCA bytes.
4349 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4350 (get_minibuffer): Arg is now EMACS_INT, not int.
4351 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4352 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4353 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4354
2be7d702
PE
4355 * dbusbind.c (signature_cat): New function.
4356 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4357 Do not overrun buffer; instead, report string overflow.
4358
9d1df220
PE
4359 * dispnew.c (add_window_display_history): Don't overrun buffer.
4360 Truncate instead; this is OK since it's just a log.
4361
33ef5c64
PE
4362 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4363 even if the time zone offset is outlandishly large.
4364 Don't mishandle offset == INT_MIN.
4365
66c6fdd5
PE
4366 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4367 when creating daemon; the previous buffer-overflow check was incorrect.
4368
d749b01b
PE
4369 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4370 which has the guts of the old verror function.
4371
b5cd1905
PE
4372 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4373 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4374
6e1a67fb
PE
4375 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4376 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4377 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4378 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4379 length of string rather than counting it via multiple sprintfs;
4380 that's simpler and more reliable.
c21721cc
PE
4381 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4382 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4383 sprintf, in case result does not fit in int.
4384
c57b67fc
PE
4385 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4386 (fontset_from_font): Print it.
4387
8a401434
PE
4388 * frame.c (tty_frame_count): Now printmax_t, not int.
4389 (make_terminal_frame, set_term_frame_name): Print it.
4390 (x_report_frame_params): In X, window IDs are unsigned long,
4391 not signed long, so print them as unsigned.
4392 (validate_x_resource_name): Check for implausibly long names,
4393 and don't assume name length fits in 'int'.
4394 (x_get_resource_string): Don't blindly alloca invocation name;
4395 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4396 not fit in int.
4397
6e1a67fb
PE
4398 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4399 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4400 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4401
0df02bf3
PE
4402 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4403 Use esprintf, not sprintf, in case result does not fit in int.
4404
48e30793
PE
4405 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4406 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4407 it as a large positive number.
4408 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4409 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4410
a66ff6d8
PE
4411 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4412 in case result does not fit in int.
4413
aca216ff
PE
4414 * print.c (float_to_string): Detect width overflow more reliably.
4415 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4416 buffer overrun. Don't assume list length fits in 'int'. Treat
4417 print length of 0 as 0, not as infinity; to be consistent with other
4418 uses of print length in this function. Don't overflow print length
4419 index. Don't assume hash table size fits in 'long', or that
4420 vectorlike size fits in 'unsigned long'.
4421
31c286f7
PE
4422 * process.c (make_process): Use printmax_t, not int, to format
4423 process-name gensyms.
4424
55e5faa1
PE
4425 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4426
80f2e268
PE
4427 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4428 to avoid potential buffer overrun.
4429
670741ab
PE
4430 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4431 if X resource line is longer than 512 bytes.
4432
b7163a50
PE
4433 * xfns.c (x_window): Make sprintf buffer a bit bigger
4434 to avoid potential buffer overrun.
4435
ae58ff1f
PE
4436 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4437
c43c8a6a
PE
4438 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4439
3f8236f4
PE
44402011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4441
53e9fe90 4442 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4443 Without these, Emacs silently mishandles large integers sometimes.
4444 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4445 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4446
6511acf2
PE
4447 * xdisp.c (try_window_id): Check Emacs fixnum range before
4448 converting to 'int'.
806add1d 4449
6511acf2 4450 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4451 Check that an Emacs fixnum is in range before assigning it to 'int'.
4452 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4453 values converted from Emacs fixnums.
4454 (Frecenter): Don't wrap around a line count if it is out of 'int'
4455 range; instead, treat it as an extreme value.
4456 (Fset_window_configuration, compare_window_configurations):
4457 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4458
6511acf2
PE
4459 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4460 that can exceed INT_MAX. Check that EMACS_INT value is in range
4461 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4462 (match_limit): Don't assume that a fixnum can fit in 'int'.
4463
6511acf2 4464 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4465 exceed INT_MAX.
4466
6511acf2 4467 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4468 (Fvertical_motion): Don't wrap around LINES values that don't fit
4469 in 'int'. Instead, treat them as extreme values. This is good
4470 enough for windows, which can't have more than INT_MAX lines anyway.
4471
fcb901a7
LMI
44722011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4473
0f2f6b6d
LMI
4474 * Require libxml/parser.h to avoid compilation warning.
4475
fcb901a7
LMI
4476 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4477
4478 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4479 since this reportedly can destroy thread storage.
4480
6e20a0d4
CY
44812011-08-30 Chong Yidong <cyd@stupidchicken.com>
4482
4483 * syntax.c (find_defun_start): Update all cache variables if
4484 exiting early (Bug#9401).
4485
148ae00e
EZ
44862011-08-30 Eli Zaretskii <eliz@gnu.org>
4487
f6cfbd8f
EZ
4488 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4489
148ae00e
EZ
4490 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4491 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4492 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4493
4494 * term.c (tty_append_glyph): New function.
4495 (produce_stretch_glyph): Static function and its prototype deleted.
4496
a66cfb1c
SM
4497 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4498 Add prototypes.
148ae00e 4499
c4a07a4c
PE
45002011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4501
4502 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4503 when checking :margin (Bug#9390).
4504 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4505 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4506 so that the name doesn't mislead. All uses changed.
4507
6bc8cd65
JB
45082011-08-28 Johan Bockgård <bojohan@gnu.org>
4509
4510 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4511 set_tty_hooks.
4512
dca4927e
EZ
45132011-08-27 Eli Zaretskii <eliz@gnu.org>
4514
4515 * xdisp.c (move_it_to): Don't bail out early when reaching
4516 position beyond to_charpos, if we are scanning backwards.
4517 (move_it_vertically_backward): When DY == 0, make sure we get to
4518 the first character in the line after the newline.
4519
f2cad773
PE
45202011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4521
4522 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4523 (ccl_driver): Do not generate an out-of-range pointer.
4524 (Fccl_execute_on_string): Remove unnecessary check for
4525 integer overflow, noted by Stefan Monnier in
4526 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4527 Remove a FIXME that didn't need fixing.
4528 Simplify the newly-introduced buffer reallocation code.
4529
0cae2cdb
JB
45302011-08-27 Juanma Barranquero <lekktu@gmail.com>
4531
4532 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4533
5fc295a4 45342011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4535
70c60eb2 4536 Integer and memory overflow issues (Bug#9196).
726e0ab1 4537
d31850da
PE
4538 * doc.c (get_doc_string): Rework so that
4539 get_doc_string_buffer_size is the actual buffer size, rather than
4540 being 1 less than the actual buffer size; this makes xpalloc more
4541 convenient.
4542
a69fbedb
PE
4543 * image.c (x_allocate_bitmap_record, cache_image):
4544 * xselect.c (Fx_register_dnd_atom):
4545 Simplify previous changes by using xpalloc.
4546
fe5c5d37
PE
4547 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4548 since either will do and ptrdiff_t is convenient with xpalloc.
4549
0065d054
PE
4550 * charset.c (charset_table_size)
4551 (struct charset_sort_data.priority): Now ptrdiff_t.
4552 (charset_compare): Don't overflow if priorities differ greatly.
4553 (Fsort_charsets): Don't assume list length fits in int.
4554 Check for size-calculation overflow when allocating sort data.
4555 (syms_of_charset): Allocate an initial charset table that is
4556 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4557
4558 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4559
4560 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4561 The actual value is always <= INT_MAX, and leaving it unsigned made
4562 overflow checking harder.
4563
4564 * dispextern.h (struct glyph_matrix.rows_allocated)
4565 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4566 with xpalloc. The values are still always <= INT_MAX.
4567
4568 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4569
4570 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4571 (SAFE_NALLOCA): New macro.
4572
4573 * region-cache.c (struct boundary.pos, find_cache_boundary)
4574 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4575 (set_cache_region, invalidate_region_cache)
4576 (revalidate_region_cache, know_region_cache, region_cache_forward)
4577 (region_cache_backward, pp_cache):
4578 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4579 so that ptrdiff_t * can be passed to xpalloc.
4580 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4581 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4582 (pp_cache): Don't assume cache_len fits in int.
4583 * region-cache.h: Adjust extern decls to match.
4584
4585 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4586 EMACS_INT, since either will do, for xpalloc.
4587
4588 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4589 (xnmalloc, xnrealloc, xpalloc): New functions.
4590
726e0ab1
PE
4591 * bidi.c (bidi_shelve_header_size): New constant.
4592 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4593 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4594
51f30bc5 4595 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4596 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4597 (overlay_strings):
4598 Don't update size of array until after memory allocation succeeds,
4599 because xmalloc/xrealloc may not return.
0065d054
PE
4600 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4601 now that we have proper integer overflow checking.
4602 (record_overlay_string, overlay_strings): Catch overflows when
4603 calculating size of overlay_str_buf.
726e0ab1 4604
0065d054
PE
4605 * callproc.c (Fcall_process): Check for size overflow when
4606 calculating size of args2.
4607 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4608 Normally we prefer signed values, but sticking with ptrdiff_t would
4609 require adding more-complicated checks.
726e0ab1
PE
4610
4611 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4612 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4613 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4614 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4615
4616 * character.c (Fstring): Check for size-calculation overflow.
4617
4618 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4619 unnecessary integer overflow. Check for size overflow.
4620 (encode_coding_object): Don't update size until xmalloc succeeds.
4621
4622 * composite.c (get_composition_id): Check for overflow in glyph
4623 length calculations.
4624
4625 Integer and memory overflow fixes for display code.
4626 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4627 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4628 (scrolling_window): Check for overflow in size calculations.
4629 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4630 Don't assume glyph table len fits in int.
4631 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4632 (row_table_size): Now ptrdiff_t, not int.
4633 (scrolling_window): Avoid overflow in size calculations.
4634 Don't update size until allocation succeeds.
4635 * fns.c (concat): Check for overflow in size calculations.
4636 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4637 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4638 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4639
4640 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4641 (get_doc_string): Check for size calculation overflow.
4642 Don't update size until allocation succeeds.
4643 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4644 EMACS_INT, where ptrdiff_t will do.
4645 (Fsubstitute_command_keys): Check for string overflow.
4646
4647 * editfns.c (set_time_zone_rule): Don't assume environment length
4648 fits in int.
4649 (message_length): Now ptrdiff_t, not int.
4650 (Fmessage_box): Don't update size until allocation succeeds.
4651 Don't assume message length fits in int.
4652 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4653
0065d054
PE
4654 * emacs.c (main): Do not reallocate argv, since there is a null at
4655 the end that can be overwritten, and this way there's no need to
4656 worry about size-calculation overflow.
4657 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4658
4659 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4660 alloc succeeds.
4661 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4662
4663 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4664 (x_set_scroll_bar_width, x_figure_window_size):
4665 Check for integer overflow.
4666 (x_set_alpha): Do not assume XINT fits in int.
4667
4668 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4669 This is for the members text_lines, text_cols, total_lines, total_cols,
4670 where the system imposes an 'int' limit.
4671
4672 * fringe.c (Fdefine_fringe_bitmap):
4673 Don't update size until alloc works.
4674
4675 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4676 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4677
4678 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4679 Check for size-calculation overflow.
4680 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4681 do, as we prefer signed integers.
4682 (id_to_widget.max_size, id_to_widget.used)
4683 (xg_store_widget_in_map, xg_remove_widget_from_map)
4684 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4685 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4686 Use and return ptrdiff_t, not int.
4687 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4688 * gtkutil.h: Change prototypes to match the above.
4689
4690 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4691 are duplicate now that they've been promoted to lisp.h.
4692 (x_allocate_bitmap_record, x_alloc_image_color)
4693 (make_image_cache, cache_image, xpm_load):
4694 Don't update size until alloc is done.
4695 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4696 (x_detect_edges):
3256efce 4697 Check for size calculation overflow.
726e0ab1
PE
4698 (ct_colors_allocated_max): New constant.
4699 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4700 overflow.
3256efce 4701
726e0ab1
PE
4702 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4703 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4704 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4705 Use ptrdiff_t, not int, to count maps.
4706 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4707 calculations. Don't update size until allocation succeeds.
4708 Redo calculations to avoid overflow.
726e0ab1
PE
4709 * keyboard.h: Change prototypes to match the above.
4710
4711 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4712 to count maps.
4713 (current_minor_maps): Check for size calculation overflow.
4714 * keymap.h: Change prototypes to match the above.
4715
4716 * lread.c (read1, init_obarray): Don't update size until alloc done.
4717
4718 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4719 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4720
726e0ab1
PE
4721 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4722 Now ptrdiff_t, not int.
4723 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4724 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4725
4726 * process.c (Fnetwork_interface_list): Check for overflow
4727 in size calculation.
4728
4729 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4730
4731 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4732 overflow. Don't bother calling xmalloc when xrealloc will do.
4733
4734 * search.c (Freplace_match): Check for size calculation overflow.
4735 (Fset_match_data): Don't assume list lengths fit in 'int'.
4736
4737 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4738 for command line length. Do not attempt to address one before the
4739 beginning of an array, as that's not portable.
4740
4741 * term.c (max_frame_lines): Remove; unused.
4742 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4743 not int.
4744 (encode_terminal_code, calculate_costs): Check for size
4745 calculation overflow.
4746 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4747 table lengths and related sizes. Don't update size until alloc
4748 done. Redo calculations to avoid overflow.
4749 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4750
4751 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4752 subtracting pointers.
4753 (gobble_line): Check for overflow more carefully. Don't update size
4754 until alloc done.
4755
4756 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4757 Don't update size until alloc done.
4758 Redo size calculations to avoid overflow.
4759 Check for size calculation overflow.
0065d054 4760 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4761
4762 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4763 Use ptrdiff_t, not int, for sizes.
4764 (store_mode_line_noprop_char): Don't update size until alloc done.
4765
0065d054
PE
4766 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4767 Use ptrdiff_t, not int, for sizes.
4768 (Finternal_make_lisp_face, cache_face):
4769 Check for size calculation overflow.
4770 (cache_face): Treat size calculation overflows as if they were
4771 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4772
4773 * xfns.c (x_encode_text, x_set_name_internal)
4774 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4775 sizes, since they can exceed INT_MAX in size. Check for size
4776 calculation overflow.
4777
0065d054
PE
4778 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4779 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4780 Don't update size until alloc done.
4781
0065d054 4782 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4783 as sprintf is limited to int lengths.
1d526e2f 4784
252c5ee1
PE
4785 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4786 (X_LONG_MIN): New macros.
864d7ce7
PE
4787 Use them to make the following changes clearer.
4788 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4789 This change doesn't affect the value now, but it may help remind
4790 future maintainers not to raise the value too much later.
4791 (SELECTION_QUANTUM): Remove, replacing with ...
4792 (selection_quantum): ... new function, which avoids overflow.
4793 All uses changed.
4794 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4795 assumption that selection length fits in 'int'.
4796 (x_reply_selection_request, x_handle_selection_request)
4797 (x_get_window_property, receive_incremental_selection)
4798 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4799 (lisp_data_to_selection_data, clean_local_selection_data):
4800 Use ptrdiff_t, not int, to record length of selection.
4801 (x_reply_selection_request, x_get_window_property)
4802 (receive_incremental_selection, x_property_data_to_lisp):
4803 Redo calculations to avoid overflow.
4804 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4805 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4806 something.
4807 (x_get_window_property, receive_incremental_selection)
4808 (lisp_data_to_selection_data, x_property_data_to_lisp):
4809 Check for size-calculation overflow.
4810 (x_get_window_property, receive_incremental_selection)
4811 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4812 Don't store size until memory allocation succeeds.
4813 (x_get_window_property): Plug memory leak on memory exhaustion.
4814 Don't double-block input; malloc is safe here. Don't assume 2**34
4815 - 4 fits in unsigned long. Add an xassert to check
4816 XGetWindowProperty overflow. Be more careful about overflow
4817 calculations, and distinguish size from memory overflow better.
4818 (receive_incremental_selection): When tracing, don't assume
4819 unsigned int is less than INT_MAX.
4820 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4821 harmful) conversions of unsigned short to int.
4822 (lisp_data_to_selection_data): Don't assume that integers
4823 in the range -65535 through -1 fit in an X unsigned short.
4824 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4825 result parameters unless successful. Rely on cons_to_unsigned
4826 to report problems with elements; the old code wasn't right anyway.
4827 (x_check_property_data): Check for int overflow; we cannot use
4828 a wider type due to X limits.
4829 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4830
726e0ab1 4831 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4832
0065d054
PE
4833 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4834 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4835 (x_color_cells): Don't store size until memory allocation succeeds.
4836 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4837 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4838 (x_term_init): Don't assume length fits in int (sprintf is limited
4839 to int size).
bc18e09d 4840
ebfa62c0
PE
4841 Use ptrdiff_t for composition IDs.
4842 * character.c (lisp_string_width):
4843 * composite.c (composition_table_size, n_compositions)
4844 (get_composition_id, composition_gstring_from_id):
4845 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4846 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4847 * window.c (Frecenter):
4848 Use ptrdiff_t, not int, for composition IDs.
4849 * composite.c (get_composition_id): Check for integer overflow.
4850 * composite.h: Adjust prototypes to match the above changes.
4851
d3411f89
PE
4852 Use ptrdiff_t for hash table indexes.
4853 * category.c (hash_get_category_set):
4854 * ccl.c (ccl_driver):
4855 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4856 * coding.c (coding_system_charset_list, detect_coding_system):
4857 * coding.h (struct coding_system.id):
4858 * composite.c (get_composition_id, gstring_lookup_cache):
4859 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4860 * image.c (xpm_get_color_table_h):
4861 * lisp.h (hash_lookup, hash_put):
4862 * minibuf.c (Ftest_completion):
4863 Use ptrdiff_t for hash table indexes, not int (which is too
4864 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4865 32-bit --with-wide-int hosts).
4866
e097a6fa
PE
4867 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4868 Add a FIXME comment about memory leaks.
4869 (syms_of_charset): Don't assume xmalloc returns.
4870
5637687f
PE
4871 Don't assume that stated character widths fit in int.
4872 * character.c (Fchar_width, c_string_width, lisp_string_width):
4873 * character.h (CHAR_WIDTH):
4874 * indent.c (MULTIBYTE_BYTES_WIDTH):
4875 Use sanitize_char_width to avoid undefined and/or bad behavior
4876 with outlandish widths.
a66cfb1c 4877 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4878 now that we have two such functions. All uses changed.
4879 (sanitize_char_width): New inline function.
4880
a2271ba2
PE
4881 Don't assume that tab-width fits in int.
4882 * character.h (sanitize_width): New inline function.
4883 (SANE_TAB_WIDTH): New macro.
4884 (ASCII_CHAR_WIDTH): Use it.
4885 * indent.c (sane_tab_width): Remove. All uses replaced by
4886 SANE_TAB_WIDTH (current_buffer).
4887 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4888
18c52557
PE
4889 * fileio.c: Integer overflow issues with file modes.
4890 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4891
caeeedc1
PE
4892 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4893 Remove unreachable code.
4894 (read_hex, load_charset_map_from_file): Check for integer overflow.
4895
6df6ae42 4896 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4897 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4898 (x_send_scroll_bar_event): Likewise. Check that the size does not
4899 exceed limits imposed by XClientMessageEvent, as well as the usual
4900 ptrdiff_t and size_t limits.
4901
b13995db
PE
4902 * keyboard.c: Overflow, signedness and related fixes.
4903 (make_lispy_movement): Use same integer type in forward decl
4904 that is used in the definition.
4905 (read_key_sequence, keyremap_step):
4906 Change bufsize argument back to int, undoing my 2011-03-30 change.
4907 We prefer signed types, and int is wide enough here.
4908 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4909 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4910 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4911 length, not size_t. Use ptrdiff_t for index, not int.
4912 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4913 possibility of integer overflow.
4914
13464394
PE
4915 Overflow, signedness and related fixes for images.
4916
4917 * dispextern.h (struct it.stack[0].u.image.image_id)
4918 (struct_it.image_id, struct image.id, struct image_cache.size)
4919 (struct image_cache.used, struct image_cache.ref_count):
4920 * gtkutil.c (update_frame_tool_bar):
4921 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4922 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4923 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4924 * nsmenu.m (update_frame_tool_bar):
4925 * xdisp.c (calc_pixel_width_or_height):
4926 * xfns.c (image_cache_refcount):
4927 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4928 on typical 64-bit hosts.
4929
4930 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4931 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4932 Omit unnecessary casts to int.
4933 (parse_image_spec): Check that integers fall into 'int' range
4934 when the callers expect that.
4935 (image_ascent): Redo ascent calculation to avoid int overflow.
4936 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4937 (lookup_image): Remove unnecessary tests.
4938 (xbm_image_p): Locals are now of int, not EMACS_INT,
4939 since parse_image_check makes sure they fit into int.
4940 (png_load, gif_load, svg_load_image):
4941 Prefer int to unsigned where either will do.
4942 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
4943 old tiff_error_handler and tiff_warning_handler.
4944 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
4945 stack buffer overflows. It uses only the features of vsnprintf
4946 that are common to both POSIX and native Microsoft.
4947 (tiff_error_handler, tiff_warning_handler): Use it.
4948 (tiff_load, gif_load, imagemagick_load_image):
4949 Don't assume :index value fits in 'int'.
4950 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4951 (imagemagick_load_image): Check that crop parameters fit into
4952 the integer types that MagickCropImage accepts. Don't assume
4953 Vimagemagick_render_type has a nonnegative value. Don't assume
4954 size_t fits in 'long'.
4955 (gs_load): Use printmax_t to print the widest integers possible.
4956 Check for integer overflow when computing image height and width.
4957
c11821d4
EZ
49582011-08-26 Eli Zaretskii <eliz@gnu.org>
4959
4960 * xdisp.c (redisplay_window): Don't force window start if point
4961 will be invisible in the resulting window. (Bug#9324)
4962
0c95fcf7
EZ
49632011-08-25 Eli Zaretskii <eliz@gnu.org>
4964
4965 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4966 the display spec is of the form `(space ...)'.
4967 (handle_display_spec): Return the value returned by
4968 handle_single_display_spec, not just 1 or zero.
4969 (handle_single_display_spec): If the display spec is of the form
4970 `(space ...)', and specifies display in the text area, return 2
4971 rather than 1.
fee65a97 4972 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
4973 accurately, and prefer exact match for point under bidi.
4974 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
4975
4976 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4977 into disp_prop; all users changed.
4978
4979 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4980 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4981 for the text covered by the display property.
4982
e4ed06f1
CY
49832011-08-25 Chong Yidong <cyd@stupidchicken.com>
4984
4985 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4986 Change return value to nil.
4987 (Frecord_buffer): Delete unused function.
4988
f67cdd7f
EZ
49892011-08-24 Eli Zaretskii <eliz@gnu.org>
4990
5980d4c6
EZ
4991 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4992 buffers, return left-to-right.
8610fe8b
EZ
4993 (set_cursor_from_row): Consider candidate row a win if its glyph
4994 represents a newline and point is on that newline. Fixes cursor
4995 positioning on the newline at EOL of R2L text within L2R
4996 paragraph, and vice versa.
4997 (try_cursor_movement): Check continued rows, in addition to
4998 continuation rows. Fixes unwarranted scroll when point enters a
4999 continued line of R2L text within an L2R paragraph, or vice versa.
5000 (cursor_row_p): Consider the case of point being equal to
5001 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5002 from the end of a short line to the beginning of a continued line
5003 of R2L text within L2R paragraph.
5004 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5005 composed characters.
5980d4c6 5006
f67cdd7f
EZ
5007 * bidi.c (bidi_check_type): Use xassert.
5008 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5009 members.
5010
bca633fb
EZ
50112011-08-23 Eli Zaretskii <eliz@gnu.org>
5012
5013 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5014 a character.
5015
4a5885a7
CY
50162011-08-23 Chong Yidong <cyd@stupidchicken.com>
5017
5018 * nsfont.m (ns_otf_to_script): Fix typo.
5019
0902a04e
KH
50202011-08-22 Kenichi Handa <handa@m17n.org>
5021
5022 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5023 extra slot even if the purpose is char-code-property-table.
5024
1a2e6670
EZ
50252011-08-23 Eli Zaretskii <eliz@gnu.org>
5026
8ddde651
EZ
5027 * xdisp.c (redisplay_window): When computing centering_position,
5028 account for the height of the header line. (Bug#8874)
5029
425cc014
EZ
5030 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5031 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5032 candidate is selected by the mouse, and that candidate has a
5033 composed character under the mouse.
5034
1a2e6670
EZ
5035 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5036 coordinates reported by pos-visible-in-window-p for a composed
5037 character in column zero.
5038
8b76d6f8
SM
50392011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5040
5041 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5042
dac347dd
EZ
50432011-08-22 Eli Zaretskii <eliz@gnu.org>
5044
5045 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5046 consider it a hit if to_charpos is anywhere in the range of the
5047 composed buffer positions.
5048
e013fb34
CY
50492011-08-22 Chong Yidong <cyd@stupidchicken.com>
5050
5051 * image.c (gif_load): Don't assume that each subimage has the same
5052 dimensions as the base image. Handle disposal method that is
5053 "undefined" by the gif spec (Bug#9335).
5054
bd1ba3e8
CY
50552011-08-20 Chong Yidong <cyd@stupidchicken.com>
5056
5057 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5058 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5059
54a1215b
EZ
50602011-08-19 Eli Zaretskii <eliz@gnu.org>
5061
823564e5
EZ
5062 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5063 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5064 from an Org mode buffer to a Speedbar frame.
5065
54a1215b
EZ
5066 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5067 a composition, take its buffer position from IT->cmp_it.charpos.
5068 Fixes cursor positioning at the beginning of a line that begins
5069 with a composed character.
5070
9778ebcc
EZ
50712011-08-18 Eli Zaretskii <eliz@gnu.org>
5072
0be6ee06
EZ
5073 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5074 character bidirectional type, use STRONG_L instead. Fixes crashes
5075 in a buffer produced by `describe-categories'.
5076
9778ebcc
EZ
5077 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5078 members before the level stack, so they would be saved and
5079 restored when copying iterator state. Fixes incorrect reordering
5080 around TABs covered by display properties.
5081
156bffbe
AS
50822011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5083
6b02f655 5084 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5085
72ad093b
CY
50862011-08-17 Chong Yidong <cyd@stupidchicken.com>
5087
5088 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5089 (internal_condition_case_2, internal_condition_case_n):
5090 Remove unnecessary aborts (Bug#9081).
72ad093b 5091
35774242
EZ
50922011-08-17 Eli Zaretskii <eliz@gnu.org>
5093
5094 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5095 has no `load' handler, try opening the file locally. (Bug#9311)
5096
db76dd85
KB
50972011-08-16 Ken Brown <kbrown@cornell.edu>
5098
5099 * gmalloc.c: Expand comment.
5100
b215eee5
EZ
51012011-08-16 Eli Zaretskii <eliz@gnu.org>
5102
5103 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5104 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5105
a4579d33
KB
51062011-08-16 Ken Brown <kbrown@cornell.edu>
5107
5108 Fix memory allocation problems in Cygwin build (Bug#9273).
5109
5110 * unexcw.c ( __malloc_initialized): Declare external variable.
5111 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5112
8b76d6f8
SM
5113 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5114 New variables.
a4579d33
KB
5115 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5116 dumped emacs.
5117 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5118 in the static heap.
5119 [CYGWIN] (special_realloc): New function.
5120 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5121 requests to realloc storage in the static heap.
5122
3ebec551
PE
51232011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5124
5125 * bidi.c (bidi_initialize): Remove unused local.
5126
9fd8be00
EZ
51272011-08-15 Eli Zaretskii <eliz@gnu.org>
5128
6b02f655
SM
5129 * bidimirror.h:
5130 * biditype.h: Remove file.
5131 * makefile.w32-in ($(BLD)/bidi.$(O)):
5132 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5133
5134 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5135
5136 * chartab.c: Improve commentary for the uniprop_table API.
5137
32413314
EZ
5138 * bidi.c (bidi_paragraph_init): Support zero value of
5139 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5140 (bidi_initialize): Use uniprop_table instead of including
5141 biditype.h and bidimirror.h.
32413314 5142
9fd8be00
EZ
5143 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5144 coordinates of the iterator when restoring from ppos_it.
5145 (Bug#9296)
5146
5cf2b69b
KH
51472011-08-14 Kenichi Handa <handa@m17n.org>
5148
5149 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5150 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5151
daf17d00
EZ
51522011-08-14 Eli Zaretskii <eliz@gnu.org>
5153
5154 * xdisp.c (move_it_in_display_line_to): Don't invoke
5155 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5156 ppos_it. Fixes vertical cursor motion when line beginning is
5157 covered by an image. (Bug#9296)
5158
08e3161a
JD
51592011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5160
5161 * nsterm.h (ns_run_ascript): Declare.
5162 (NSAPP_DATA2_RUNASSCRIPT): Define.
5163
5164 * nsfns.m (as_script, as_result, as_status): New static variables.
5165 (ns_run_ascript): New function.
5e617bc2 5166 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5167 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5168 the event loop. Get status from as_status (Bug#7276).
5169
5170 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5171 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5172 the event loop (Bug#7276).
5173
a3720aa2
AS
51742011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5175
5176 * gnutls.c (QCgnutls_bootprop_priority)
5177 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5178 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5179 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5180 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5181 (QCgnutls_bootprop_verify_hostname_error)
5182 (QCgnutls_bootprop_callbacks_verify): Rename from
5183 Qgnutls_bootprop_..., all uses changed.
5184
5185 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5186 uses changed.
5187
0a0d27fb
PE
51882011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5189
19d5c50c
PE
5190 * xfaces.c (Qframe_set_background_mode): Now static.
5191 * dispextern.h (Qframe_set_background_mode): Remove decl.
5192
0a0d27fb
PE
5193 * process.c (Fnetwork_interface_info): Declare local only if needed.
5194
377538cb
JD
51952011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5196
5197 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5198 (Fnetwork_interface_list): Allocate in increments of bytes instead
5199 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5200 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5201 sockaddr.
5202 (struct ifflag_def): notrailers is smart on OSX.
5203 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5204 Get hardware address with getifaddrs if available.
5205
08fff70c
EZ
52062011-08-12 Eli Zaretskii <eliz@gnu.org>
5207
5208 * xdisp.c (iterate_out_of_display_property): xassert that
5209 IT->position is set to within IT->object's boundaries. Break from
5210 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5211 when IT->position is set up wrongly due to some bug.
5212 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5213 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5214 entry. Force push_it to save on the stack the current
5215 buffer/string position, to be restored by pop_it. Fix flags in
5216 the iterator structure wrt the object coming from a display
5217 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5218 properties. (Bug#9284)
5219
7be1c708 52202011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5221
7be1c708
CY
5222 * fontset.c (fontset_get_font_group): Add proper type checks.
5223 (Bug#9172)
aac0c6e3 5224
7be1c708 52252011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5226
7be1c708
CY
5227 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5228 and LC_VERSION_MIN_MACOSX.
5229 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5230 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5231
97bb72a6
EZ
52322011-08-08 Eli Zaretskii <eliz@gnu.org>
5233
5234 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5235 no-display-properties-and-no-overlays under bidi display.
5236 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5237 properties and overlays.
97bb72a6 5238
d5617611
CY
52392011-08-08 Chong Yidong <cyd@stupidchicken.com>
5240
37e11a63
CY
5241 * editfns.c (Fset_time_zone_rule): Document relationship with the
5242 setenv function.
5243
d5617611
CY
5244 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5245 the font entity extracted from the cache (Bug#8109).
5246
58872834
CY
52472011-08-07 Chong Yidong <cyd@stupidchicken.com>
5248
5249 * composite.c (autocmp_chars): Don't reset point. That is done by
5250 restore_point_unwind (Bug#5984).
5251
75bfc667
JL
52522011-08-07 Juri Linkov <juri@jurta.org>
5253
5254 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5255 to show the arg `TIME' instead of `TIMEVAL'.
5256
d1410150
EZ
52572011-08-06 Eli Zaretskii <eliz@gnu.org>
5258
5259 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5260 display property strides EOL and includes a newline, as in
5261 longlines-mode. (Bug#9254)
75b771e4
EZ
5262 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5263 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5264
5265 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5266 is non-zero, even if the data buffer is NULL. Fixes a crash in
5267 vertical-motion with longlines-mode. (Bug#9254)
5268
35928349
EZ
52692011-08-05 Eli Zaretskii <eliz@gnu.org>
5270
ec7cc85b
EZ
5271 * bidi.c <bidi_cache_total_alloc>: Now static.
5272 (bidi_initialize): Initialize bidi_cache_total_alloc.
5273
8b76d6f8 5274 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5275 cache. (Bug#9221)
5276
5277 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5278 amount allocated this far in `bidi_cache_total_alloc'.
5279 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5280 non-zero, only free the data buffer without restoring the cache
5281 contents. All callers changed.
5282
5283 * dispextern.h (bidi_unshelve_cache): Update prototype.
5284
5285 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5286 (move_it_in_display_line, move_it_to)
5287 (move_it_vertically_backward, move_it_by_lines): Replace the call
5288 to xfree to an equivalent call to bidi_unshelve_cache.
5289 (move_it_in_display_line_to): Fix logic of returning
412b6358 5290 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5291
e2e2423b
EZ
52922011-08-05 Eli Zaretskii <eliz@gnu.org>
5293
5294 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5295 came from a string character with a `cursor' property. (Bug#9229)
5296
ae9e757a
JD
52972011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5298
5299 * Makefile.in (LIB_PTHREAD): New variable.
5300 (LIBES): Add LIB_PTHREAD (Bug#9216).
5301
5302 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5303 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5304
213bd7f2
AS
53052011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5306
6b02f655 5307 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5308
99aaf75f
JD
53092011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5310
5311 * xterm.c (x_find_topmost_parent): New function.
5312 (x_set_frame_alpha): Find topmost parent window with
5313 x_find_topmost_parent and set the property there also (bug#9181).
5314 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5315
c74e9d86
PE
53162011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5317
5318 * callproc.c (Fcall_process): Avoid vfork clobbering
5319 the local vars buffer, coding_systems, current_dir.
5320
640c8776
SM
53212011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5322
5323 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5324
f26d0e4c
PE
53252011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5326
8a10d76c
PE
5327 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5328 so that it is not optimized away.
5329
f26d0e4c
PE
5330 * xdisp.c (compute_display_string_pos): Remove unused local.
5331
55439c61
EZ
53322011-08-02 Eli Zaretskii <eliz@gnu.org>
5333
5334 Fix slow cursor motion and scrolling in large buffers with
5335 selective display, like Org Mode buffers. (Bug#9218)
5336
5337 * dispextern.h (struct bidi_it): New member disp_prop_p.
5338
5339 * xdisp.c: Remove one-slot cache of display string positions.
5340 (compute_display_string_pos): Accept an additional argument
5e617bc2 5341 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5342 for a display string or property. If found, set DISP_PROP_P
5343 non-zero.
5344
5345 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5346 DISP_PROP_P, and pass it to compute_display_string_pos.
5347 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5348 non-zero. All callers of bidi_fetch_char changed.
5349
fb33fa43
SM
53502011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5351
5352 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5353
b099e063
DM
53542010-12-03 Don March <don@ohspite.net>
5355
5356 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5357 last character M-[char] is translated to ESC [char] (bug#7541).
5358
5cc7f7af
KH
53592011-08-02 Kenichi Handa <handa@m17n.org>
5360
d0fffa3f 5361 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5362
5363 * chartab.c (uniprop_table): Make it non-static.
5364
525d5e6e
EZ
53652011-08-01 Eli Zaretskii <eliz@gnu.org>
5366
5367 * xdisp.c (forward_to_next_line_start): Accept additional argument
5368 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5369 on the newline.
5370 (reseat_at_next_visible_line_start): Use the bidi iterator state
5371 returned by forward_to_next_line_start to restore the state of
5372 it->bidi_it after backing up to previous newline. (Bug#9212)
5373
31011111
AS
53742011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5375
5376 * regex.c (re_comp): Protoize.
5377 (re_exec): Fix return type.
5378 (regexec): Fix type of `ret'. (Bug#9203)
5379
476371c4
PE
53802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5381
e5d76069
PE
5382 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5383 This is needed if max-image-size is a floating-point number.
5384
9a79b20c
AS
53852011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5386
5387 * print.c (print_object): Print empty symbol as ##.
5388
5389 * lread.c (read1): Read ## as empty symbol.
5390
d8c2fa78
AA
53912011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5392
5393 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5394 setting frame foreground color (Bug#9175).
5395 (x_set_background_color): Likewise.
5396
ffe57a7a
AA
5397 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5398 contents (Bug#9176).
5399 (EmacsTooltip -init): Remove bezels and add shadows to
5400 tooltip windows.
5401
bf3492a5
AA
5402 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5403 or scroll bar (Bug#8470).
5404
d55e9c53
AA
5405 * nsfont.m (nsfont_open): Remove assignment to voffset and
5406 unnecessary vars hshink, expand, hd, full_height, min_height.
5407 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5408
5409 * nsterm.h (nsfont_info): Remove voffset field.
5410
d8c2fa78 54112011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5412
5413 Implement strike-through and overline on NextStep (Bug#8863).
5414
5415 * nsfont.m (nsfont_open): Use underline position provided by font,
5416 instead of hard-coded value of 2.
5417 (nsfont_draw): Call ns_draw_text_decoration instead.
5418
5419 * nsterm.h: Add declaration for ns_draw_text_decoration.
5420
5421 * nsterm.m (ns_draw_text_decoration): New function for drawing
5422 underline, overline, and strike-through.
5423 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5424 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5425 accommodate underlining, etc.
4843aac3 5426
4cc60b9b
EZ
54272011-07-28 Eli Zaretskii <eliz@gnu.org>
5428
bc7ece87
EZ
5429 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5430 default.
4cc60b9b 5431
476371c4
PE
54322011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5433
66606eea
PE
5434 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5435 Without this fix, if a signal arrives just after memory fills up,
5436 'malloc' might be invoked reentrantly.
5437
476371c4
PE
5438 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5439 In other words, assume that every image size is allowed, on non-X
5440 hosts. This assumption is probably wrong, but it lets Emacs compile.
5441
f3fcc40d
AS
54422011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5443
5444 * regex.c (re_iswctype): Convert return values to boolean.
5445
350c992f
EZ
54462011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5447
5448 * xdisp.c (compute_display_string_pos): Don't use cached display
5449 string position if the buffer had its restriction changed.
5450 (Bug#9184)
5451
5266b4bb
PE
54522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5453
5454 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5455
2573a837 54562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5457
41f55ccd 5458 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5459
39e378da
PE
5460 * bidi.c: Integer size and overflow fixes.
5461 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5462 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5463 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5464 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5465 (bidi_find_other_level_edge):
5466 Use ptrdiff_t instead of EMACS_INT where either will do.
5467 This works better on 32-bit hosts configured --with-wide-int.
5468 (bidi_cache_ensure_space): Check for size-calculation overflow.
5469 Use % rather than repeated addition, for better worst-case speed.
5470 Don't set bidi_cache_size until after xrealloc returns, because it
5471 might not return.
5472 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5473 (bidi_cache_ensure_space): Also check that the bidi cache size
5474 does not exceed that of the largest Lisp string or buffer. See Eli
5475 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5476
5e927815
PE
5477 * alloc.c (__malloc_size_t): Remove.
5478 All uses replaced by size_t. See Andreas Schwab's note
5479 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5480
ca4aa935
PE
5481 * image.c: Improve checking for integer overflow.
5482 (check_image_size): Assume that f is nonnull, since
5483 it is always nonnull in practice. This is one less thing to
5484 worry about when checking for integer overflow later.
5485 (x_check_image_size): New function, which checks for integer
5486 overflow issues inside X.
5487 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5488 This removes the need for a memory_full check.
5489 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5490 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5491 (xbm_read_bitmap_data): Change locals back to 'int', since
5492 their values must fit in 'int'.
5493 (xpm_load_image, png_load, tiff_load):
5494 Invoke x_create_x_image_and_pixmap earlier,
5495 to avoid much needless work if the image is too large.
5496 (tiff_load): Treat overly large images as if
5497 x_create_x_image_and_pixmap failed, not as malloc failures.
5498 (gs_load): Use x_check_image_size.
5499
5f8f9cc2
PE
5500 * gtkutil.c: Omit integer casts.
5501 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5502 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5503
5adf60bc
PE
5504 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5505
c8907a93
PE
5506 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5507 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5508 would wrongly return t on a 64-bit host.
5509
e3c25c68
PE
5510 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5511 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5512 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5513 and therefore cause GCC to emit a bogus diagnostic in some cases.
5514
3f791afe
PE
5515 * image.c: Integer signedness and overflow and related fixes.
5516 This is not an exhaustive set of fixes, but it's time to
5517 record what I've got.
5518 (lookup_pixel_color, check_image_size): Remove redundant decls.
5519 (check_image_size): Don't assume that arbitrary EMACS_INT values
5520 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5521 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5522 (tiff_load, imagemagick_load_image):
5523 Check for overflow in size calculations.
5524 (x_create_x_image_and_pixmap): Remove unnecessary test for
5525 xmalloc returning NULL; that can't happen.
5526 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5527 (xpm_color_bucket): Use better integer hashing function.
5528 (xpm_cache_color): Don't possibly over-allocate memory.
5529 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5530 (gif_memory_source):
5531 Use ptrdiff_t, not int or size_t, to record sizes.
5532 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5533 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5534 either works, as we prefer signed integers.
5535 (tiff_read_from_memory, tiff_write_from_memory):
5536 Return tsize_t, not size_t, since that's what the TIFF API wants.
5537 (tiff_read_from_memory): Don't fail simply because the read would
5538 go past EOF; instead, return a short read.
5539 (tiff_load): Omit no-longer-needed casts.
5540 (Fimagemagick_types): Don't assume size fits into 'int'.
5541
3cc5a532
PE
5542 Improve hashing quality when configured --with-wide-int.
5543 * fns.c (hash_string): New function, taken from sxhash_string.
5544 Do not discard information about ASCII character case; this
5545 discarding is no longer needed.
5546 (sxhash-string): Use it. Change sig to match it. Caller changed.
5547 * lisp.h: Declare it.
5548 * lread.c (hash_string): Remove, since we now use fns.c's version.
5549 The fns.c version returns a wider integer if --with-wide-int is
5550 specified, so this should help the quality of the hashing a bit.
5551
b312a492
PE
5552 * emacs.c: Integer overflow minor fix.
5553 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5554 Define only if GNU_LINUX.
5555 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5556
dfd153ae
PE
5557 * dispnew.c: Integer signedness and overflow fixes.
5558 Remove unnecessary forward decls, that were a maintenance hassle.
5559 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5560 All uses changed.
5561 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5562 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5563 (prepare_desired_row, line_draw_cost):
5564 Use int, not unsigned, where either works.
5565 (save_current_matrix, restore_current_matrix):
5566 Use ptrdiff_t, not size_t, where either works.
5567 (init_display): Check for overflow more accurately, and without
5568 relying on undefined behavior.
5569
a81d11a3
PE
5570 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5571 Remove, replacing with the new symbols in lisp.h. All uses changed.
5572 * fileio.c (make_temp_name):
5573 * filelock.c (lock_file_1, lock_file):
5574 * xdisp.c (message_dolog):
5575 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5576 Use pMd etc. instead.
5577 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5578 replacing the pWIDE etc. symbols removed from editfns.c.
5579
3300e6fd
PE
5580 * keyboard.h (num_input_events): Now uintmax_t.
5581 This is (very slightly) less likely to mess up due to wraparound.
5582 All uses changed.
5583
fd05c7e9
PE
5584 * buffer.c: Integer signedness fixes.
5585 (alloc_buffer_text, enlarge_buffer_text):
5586 Use ptrdiff_t rather than size_t when either will do, as we prefer
5587 signed integers.
5588
903fe15d
PE
5589 * alloc.c: Integer signedness and overflow fixes.
5590 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5591 (__malloc_size_t): Default to size_t, not to int.
5592 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5593 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5594 Prefer ptrdiff_t to size_t when either would do, as we prefer
5595 signed integers.
5596 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5597 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5598 Now const. Initialize with values that are in range even if char
5599 is signed.
5600 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5601 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5602 These functions do the right thing with sizes > 2**32.
5603 (check_depth): Now ptrdiff_t, not int.
5604 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5605 Adjust to new way of storing sizes. Check for size overflow bugs
5606 in rest of code.
5607 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5608 slightly wrong anyway, as it missed one instance of
5609 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5610 (refill_memory_reserve): Omit needless cast to size_t.
5611 (mark_object_loop_halt): Mark as externally visible.
5612
ac82cc6a
PE
5613 * xselect.c: Integer signedness and overflow fixes.
5614 (Fx_register_dnd_atom, x_handle_dnd_message):
5615 Use ptrdiff_t, not size_t, since we prefer signed.
5616 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5617 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5618 x_dnd_atoms_size and x_dnd_atoms_length.
5619
c2d1e36d
PE
5620 * doprnt.c: Prefer signed to unsigned when either works.
5621 * eval.c (verror):
5622 * doprnt.c (doprnt):
5623 * lisp.h (doprnt):
5624 * xdisp.c (vmessage):
5625 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5626 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5627 prefer signed arithmetic to avoid comparison confusion.
5628 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5629 but is a bit tricky.
5630
0e926e56
PE
5631 Assume freestanding C89 headers, string.h, stdlib.h.
5632 * data.c, doprnt.c, floatfns.c, print.c:
5633 Include float.h unconditionally.
5634 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5635 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5636 * regex.c: Likewise for stddef.h, string.h.
5637 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5638 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5639 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5640 (STDC_HEADERS): Remove obsolete defines.
5641 * sysdep.c: Include limits.h unconditionally.
5642
9cfdb3ec
PE
5643 Assume support for memcmp, memcpy, memmove, memset.
5644 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5645 * regex.c (memcmp, memcpy):
5646 Remove; we assume C89 now.
5647
5648 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5649 (__malloc_safe_bcopy): Remove; no longer needed.
5650
cf950e6b 5651 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5652 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5653 well either way, and we prefer signed to unsigned.
5654
dbf38e02
LMI
56552011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5656
5657 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5658 closes the connection while we're reading (bug#9182).
5659
d6f0886c 56602011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5661
d6f0886c
JD
5662 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5663 are specified (Bug#9168).
24e0f6b1 5664
2eb1f9e6
PE
56652011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5666
5667 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5668 Found by GCC static checking and --with-wide-int on a 32-bit host.
5669
22381272 56702011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5671
5672 * xdisp.c (compute_display_string_pos): Fix logic of caching
5673 previous display string position. Initialize cached_prev_pos to
5674 -1. Fixes slow-down at the beginning of a buffer.
5675
f25e39b4
EZ
56762011-07-24 Eli Zaretskii <eliz@gnu.org>
5677
5678 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5679 for attrs[LFACE_FONTSET_INDEX].
5680
04c4b52e
PE
56812011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5682
5683 * xml.c (parse_region): Remove unused local
5684 that was recently introduced.
5685
c1734fbd
EZ
56862011-07-23 Eli Zaretskii <eliz@gnu.org>
5687
be18c5a5
EZ
5688 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5689 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5690
c1734fbd
EZ
5691 * xdisp.c (move_it_in_display_line_to): Record the best matching
5692 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5693 exit if none of the characters scanned was an exact match.
5694 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5695 when exact match is impossible due to invisible text, and the
5696 lines are truncated.
5697
a258d627
JD
56982011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5699
5700 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5701 for OSX >= 10.7.
5702
b6d5a689
EZ
57032011-07-22 Eli Zaretskii <eliz@gnu.org>
5704
0f74f785
EZ
5705 Fix a significant slow-down of cursor motion with C-n, C-p,
5706 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5707 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5708 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5709 (next_element_from_buffer): Call compute_stop_pos_backwards to
5710 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5711 base_level_stop.
5712 (reseat): Don't look for prev_stop, as that could mean a very long
5713 run.
5714 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5715 <cached_disp_overlay_modiff>: Cache for last found display string
5716 position.
551918c1 5717 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5718 about the same buffer in the same area of character positions, and
5719 the buffer wasn't changed since the time the display string
5720 position was cached.
551918c1 5721
b2d0c91a
EZ
57222011-07-22 Eli Zaretskii <eliz@gnu.org>
5723
5724 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5725 is an integer, which is important for empty lines. (Bug#9149)
5726
043604ee
CY
57272011-07-22 Chong Yidong <cyd@stupidchicken.com>
5728
5729 * frame.c (Fmodify_frame_parameters): In tty case, update the
5730 default face if necessary (Bug#4238).
5731
da4adb04
CY
57322011-07-21 Chong Yidong <cyd@stupidchicken.com>
5733
5734 * editfns.c (Fstring_to_char): No need to explain what a character
5735 is in the docstring (Bug#6576).
5736
9abd0532
LMI
57372011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5738
5739 * xml.c (parse_region): Make sure we always return a tree.
5740
36881d16
HK
57412011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5742
5743 * xml.c (parse_region): If a document contains only comments,
5744 return that, too.
5745
1e98674d
LMI
57462011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5747
5748 * xml.c (make_dom): Return comments, too.
5749
590bd467
PE
57502011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5751
5752 Port to OpenBSD.
5753 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5754 and the surrounding thread.
5755 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5756 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5757 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5758 timer goes off.
5759 * s/openbsd.h (BROKEN_SIGIO): Define.
5760 * unexelf.c (unexec) [__OpenBSD__]:
5761 Don't update the .mdebug section of the Alpha COFF symbol table.
5762
f41628b2
LMI
57632011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5764
5765 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5766 (bug#8460).
5767
b59b67c5
PE
57682011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5769
15e3a074
PE
5770 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5771 This fixes some race conditions on the permissions of any newly
5772 created file.
5773
41bed37d
PE
5774 * alloc.c (valid_pointer_p): Use pipe, not open.
5775 This fixes some permissions issues when debugging.
5776
b59b67c5
PE
5777 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5778 If fchown fails to set both uid and gid, try to set just gid,
5779 as that is sometimes allowed. Adjust the file's mode to eliminate
5780 setuid or setgid bits that are inappropriate if fchown fails.
5781
925a6be7
SM
57822011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5783
5784 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5785 to compare Lisp_Objects.
5786 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5787 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5788 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5789
52968808
AS
57902011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5791
0a6a104b
AS
5792 * lread.c (read_integer): Unread even EOF character.
5793 (read1): Likewise. Properly record start position of symbol.
5794
52968808
AS
5795 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5796 symbol character follows.
5797
9e381cdd
PE
57982011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5799
5800 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5801 This works around a problem with the previous change to Fcopy_file.
5802 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5803 and without this change, GCC might complain about discarding
5804 fchown's return value.
5805
b5641435
JB
58062011-07-16 Juanma Barranquero <lekktu@gmail.com>
5807
5808 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5809
a8031457
PE
58102011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5811
5812 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5813
dd889327
LMI
58142011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5815
750c33f7
LMI
5816 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5817 it's used from the C level.
5818
dd889327
LMI
5819 * process.c: Use the same condition for POLL_FOR_INPUT in both
5820 keyboard.c and process.c (bug#1858).
5821
87e86684
LM
58222011-07-09 Lawrence Mitchell <wence@gmx.li>
5823
5824 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5825 (Fgnutls_boot): Use it.
5826
64348f40
AS
58272011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5828
5829 * doc.c (Fsubstitute_command_keys): Revert last change.
5830
1d698799
LMI
58312011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5832
f863868c
LMI
5833 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5834 quotes the next character, and doesn't affect other longer
5835 sequences (bug#8935).
5836
1d698799
LMI
5837 * lread.c (syms_of_lread): Clarify that is isn't only
5838 `eval-buffer' and `eval-defun' that's affected by
5839 `lexical-binding' (bug#8460).
5840
aa4b6df6
EZ
58412011-07-15 Eli Zaretskii <eliz@gnu.org>
5842
5843 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5844 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5845
5d856da6
PE
58462011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5847
ad6042bb
PE
5848 Fix minor problems found by static checking.
5849 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5850 (elsz): Now a signed constant, not a size_t var. We prefer signed
5851 types to unsigned, to avoid integer comparison confusion. Without
5852 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5853 "cannot optimize loop, the loop counter may overflow", a symptom
5854 of the confusion.
f00bbb22 5855 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5856 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5857
6468f31c
LMI
58582011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5859
49080b10
LMI
5860 * search.c (Fre_search_backward): Mention `case-fold-search' in
5861 all the re_search_* functions (bug#8138).
5862
6468f31c
LMI
5863 * keyboard.c (Fopen_dribble_file): Document when the file is
5864 closed (bug#8056).
5865
c965adc5
EZ
58662011-07-14 Eli Zaretskii <eliz@gnu.org>
5867
df9733bf
EZ
5868 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5869 bidi_cache_idx.
5870
0bb23927
EZ
5871 Support bidi reordering of display and overlay strings.
5872 * xdisp.c (compute_display_string_pos)
5873 (compute_display_string_end): Accept additional argument STRING.
5874 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5875 (reseat_to_string): Initialize bidi_it->string.s and
5876 bidi_it->string.schars.
5877 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5878 NULL (avoids a crash in bidi_paragraph_init).
5879 Initialize itb.string.lstring.
0bb23927
EZ
5880 (init_iterator): Call bidi_init_it only of a valid
5881 buffer position was specified. Initialize paragraph_embedding to
5882 L2R.
5883 (reseat_to_string): Initialize the bidi iterator.
5884 (display_string): If we need to ignore text properties of
5885 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5886 original value of -1 will not work with bidi.)
5887 (compute_display_string_pos): First arg is now struct
5888 `text_pos *'; all callers changed. Support display properties on
5889 Lisp strings.
5890 (compute_display_string_end): Support display properties on Lisp
5891 strings.
5892 (init_iterator, reseat_1, reseat_to_string): Initialize the
5893 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5894 when iterating on a string not from display properties).
640c8776
SM
5895 (compute_display_string_pos, compute_display_string_end):
5896 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5897 arrow keys.
5898 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5899 base_level_stop; instead, set base_level_stop to BEGV.
5900 Fixes crashes in vertical-motion.
0bb23927
EZ
5901 (next_element_from_buffer): Improve commentary for when
5902 the iterator is before prev_stop.
5903 (init_iterator): Initialize bidi_p from the default value of
5904 bidi-display-reordering, not from buffer-local value. Use the
5905 buffer-local value only if initializing for buffer iteration.
5906 (handle_invisible_prop): Support invisible properties on strings
5907 that are being bidi-reordered.
5908 (set_iterator_to_next): Support bidi reordering of C strings and
5909 Lisp strings.
5910 (next_element_from_string): Support bidi reordering of Lisp
5911 strings.
5912 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5913 (display_string): Support display of R2L glyph rows.
5914 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5915 (init_iterator): Don't initialize it->bidi_p for strings
5916 here.
5917 (reseat_to_string): Initialize it->bidi_p for strings here.
5918 (next_element_from_string, next_element_from_c_string)
5919 (next_element_from_buffer): Add xassert's for correspondence
5920 between IT's object being iterated and it->bidi_it.string
5921 structure.
5922 (face_before_or_after_it_pos): Support bidi iteration.
5923 (next_element_from_c_string): Handle the case of the first string
5924 character that is not the first one in the visual order.
5925 (get_visually_first_element): New function, refactored from common
5926 parts of next_element_from_buffer, next_element_from_string, and
5927 next_element_from_c_string.
5928 (tool_bar_lines_needed, redisplay_tool_bar)
5929 (display_menu_bar): Force left-to-right direction. Add a FIXME
5930 comment for making that be controlled by a user option.
5931 (push_it, pop_it): Save and restore the state of the
5932 bidi iterator. Save and restore the bidi_p flag.
5933 (pop_it): Iterate out of display property for string iteration as
5934 well.
5935 (iterate_out_of_display_property): Support iteration over strings.
5936 (handle_single_display_spec): Set up it->bidi_it for iteration
5937 over a display string, and call bidi_init_it.
5938 (handle_single_display_spec, next_overlay_string)
5939 (get_overlay_strings_1, push_display_prop): Set up the bidi
5940 iterator for displaying display or overlay strings.
5941 (forward_to_next_line_start): Don't use the shortcut if
5942 bidi-iterating.
5943 (back_to_previous_visible_line_start): If handle_display_prop
5944 pushed the iterator stack, restore the internal state of the bidi
5945 iterator by calling bidi_pop_it same number of times.
5946 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5947 and we are bidi-iterating, don't decrement the iterator position;
5948 instead, set the first_elt flag in the bidi iterator, to produce
5949 the same effect.
5950 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5951 (push_display_prop): xassert that we are iterating a buffer.
5952 (push_it, pop_it): Save and restore paragraph_embedding member.
5953 (handle_single_display_spec, next_overlay_string)
5954 (get_overlay_strings_1, reseat_1, reseat_to_string)
5955 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5956 correctly. Don't assume unibyte strings are not bidi-reordered.
5957 (compute_display_string_pos)
5958 (compute_display_string_end): Fix handling the case of C string.
5959 (push_it, pop_it): Save and restore from_disp_prop_p.
5960 (handle_single_display_spec, push_display_prop): Set the
5961 from_disp_prop_p flag.
5962 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5963 (pop_it): Call iterate_out_of_display_property only if we are
5964 popping after iteration over a string that came from a display
5965 property. Fix a typo in popping stretch info. Add an assertion
5966 for verifying that the iterator position is in sync with the bidi
5967 iterator.
5968 (handle_single_display_spec, get_overlay_strings_1)
5969 (push_display_prop): Fix initialization of paragraph direction for
5970 string when that of the parent object is not yet determined.
5971 (reseat_1): Call bidi_init_it to resync the bidi
5972 iterator with IT's position. (Bug#7616)
5973 (find_row_edges): If ROW->start.pos gives position
5974 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5975 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5976 Reset the from_disp_prop_p flag.
5977 (SAVE_IT, RESTORE_IT): New macros.
5978 (pos_visible_p, face_before_or_after_it_pos)
5979 (back_to_previous_visible_line_start)
5980 (move_it_in_display_line_to, move_it_in_display_line)
5981 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5982 (try_scrolling, redisplay_window, display_line): Use them when
5983 saving a temporary copy of the iterator and restoring it back.
5984 (back_to_previous_visible_line_start, reseat_1)
5985 (init_iterator): Empty the bidi cache "stack".
5986 (move_it_in_display_line_to): If iterator ended up at
5987 EOL, but we never saw any buffer positions smaller than
5988 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5989 motion in bidi-reordered lines.
5990 (move_it_in_display_line_to): Record prev_method and prev_pos
5991 immediately before the call to set_iterator_to_next. Fixes cursor
5992 motion in bidi-reordered lines with stretch glyphs and strings
5993 displayed in margins. (Bug#8133) (Bug#8867)
5994 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5995 TO_CHARPOS.
640c8776
SM
5996 (pos_visible_p): Support positions in bidi-reordered lines.
5997 Save and restore bidi cache.
0bb23927
EZ
5998
5999 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6000 (bidi_paragraph_info): Delete unused struct.
6001 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6002 (bidi_cache_start): New variable.
6003 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6004 to zero.
6005 (bidi_cache_fetch_state, bidi_cache_search)
6006 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6007 (bidi_cache_find, bidi_peek_at_next_level)
6008 (bidi_level_of_next_char, bidi_find_other_level_edge)
6009 (bidi_move_to_visually_next): Compare cache index with
6010 bidi_cache_start rather than with zero.
6011 (bidi_fetch_char): Accept new argument STRING; all callers
6012 changed. Support iteration over a string. Support strings with
6013 display properties. Support unibyte strings. Fix the type of
6014 `len' according to what STRING_CHAR_AND_LENGTH expects.
6015 (bidi_paragraph_init, bidi_resolve_explicit_1)
6016 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6017 (bidi_level_of_next_char, bidi_move_to_visually_next):
6018 Support iteration over a string.
0bb23927
EZ
6019 (bidi_set_sor_type, bidi_resolve_explicit_1)
6020 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6021 can now be zero (for strings); special values 0 and -1 were
6022 changed to -1 and -2, respectively.
6023 (bidi_char_at_pos): New function.
6024 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6025 Call it instead of FETCH_MULTIBYTE_CHAR.
6026 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6027 initialized to valid values.
6028 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6029 values.
6030 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6031 the test for valid cached positions. Fix the logic for looking up
6032 the sentinel state in the cache. GCPRO the Lisp string we are
6033 iterating.
6034 (bidi_push_it, bidi_pop_it): New functions.
6035 (bidi_initialize): Initialize the bidi cache start stack pointer.
6036 (bidi_cache_ensure_space): New function, refactored from part of
6037 bidi_cache_iterator_state. Don't assume the required size is just
6038 one BIDI_CACHE_CHUNK away.
6039 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6040 (bidi_count_bytes, bidi_char_at_pos): New functions.
6041 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6042 always valid if bidi_cache_idx is valid.
6043 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6044 is valid if it's going to be used.
6045 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6046 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6047 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6048 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6049 (bidi_find_other_level_edge, bidi_cache_start_stack):
6050 All variables related to cache indices are now EMACS_INT.
c965adc5 6051
0bb23927
EZ
6052 * dispextern.h (struct bidi_string_data): New structure.
6053 (struct bidi_it): New member `string'. Make flag members be 1-bit
6054 fields, and put them last in the struct.
640c8776
SM
6055 (compute_display_string_pos, compute_display_string_end):
6056 Update prototypes.
0bb23927
EZ
6057 (bidi_push_it, bidi_pop_it): Add prototypes.
6058 (struct iterator_stack_entry): New members bidi_p,
6059 paragraph_embedding, and from_disp_prop_p.
6060 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6061 (bidi_shelve_cache, bidi_unshelve_cache):
6062 Declare prototypes.
0bb23927
EZ
6063
6064 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6065 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6066 and vector-like objects.
6067
6068 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6069 cache around display iteration.
6070
6071 * window.c (Fwindow_end, window_scroll_pixel_based)
6072 (displayed_window_lines, Frecenter): Save and restore the bidi
6073 cache around display iteration.
6074
3bbd2265
LMI
60752011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6076
6077 * editfns.c (Fdelete_region): Clarify the use of the named
6078 parameters (bug#6788).
6079
adc47434
MR
60802011-07-14 Martin Rudalics <rudalics@gmx.at>
6081
6082 * indent.c (Fvertical_motion): Set and restore w->pointm when
6083 saving and restoring the window's buffer (Bug#9006).
6084
837c31f8
LMI
60852011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6086
6087 * editfns.c (Fstring_to_char): Clarify just what is returned
6088 (bug#6576). Text by Eli Zaretskii.
6089
ac389d0c
JB
60902011-07-13 Juanma Barranquero <lekktu@gmail.com>
6091
6092 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6093
0be0ce47
EZ
60942011-07-13 Eli Zaretskii <eliz@gnu.org>
6095
6096 * buffer.c (mmap_find): Fix a typo.
6097
cd18e7e3
JB
60982011-07-13 Johan Bockgård <bojohan@gnu.org>
6099
6100 Fix execution of x selection hooks.
6101 * xselect.c (Qx_lost_selection_functions)
6102 (Qx_sent_selection_functions): New vars.
6103 (syms_of_xselect): DEFSYM them.
6104 (x_handle_selection_request): Pass Qx_sent_selection_functions
6105 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6106 (x_handle_selection_clear,x_clear_frame_selections):
6107 Pass Qx_lost_selection_functions rather than
6108 Vx_lost_selection_functions to Frun_hook_with_args.
6109
47ea7f44
PE
61102011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6111
ac389d0c 6112 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6113 The old code sometimes used this field without initializing it.
6114
47ea7f44
PE
6115 * alloc.c (gc_sweep): Don't read past end of array.
6116 In theory, the old code could also have corrupted Emacs internals,
6117 though it'd be very unlikely.
6118
bc985c87
AS
61192011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6120
6121 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6122 argument. (Bug#4026)
bc985c87 6123
0cf34688
LMI
61242011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6125
b3dadd76
LMI
6126 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6127 key" (bug#4257).
6128
0cf34688
LMI
6129 * window.c (Fset_window_start): Doc fix (bug#4199).
6130 (Fset_window_hscroll): Ditto.
6131
270768cd
PE
61322011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6133
077e3dda 6134 Fix minor new problems caught by GCC 4.6.1.
270768cd 6135 * term.c (init_tty): Remove unused local.
490011a6 6136 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6137 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6138 not used otherwise.
270768cd 6139
b1f58454
CY
61402011-07-12 Chong Yidong <cyd@stupidchicken.com>
6141
6142 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6143
22b9578d
LMI
61442011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6145
6e70ab07
LMI
6146 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6147 are the mini-buffer and the echo area (bug#3320).
6148
22b9578d
LMI
6149 * term.c (init_tty): Remove support for supdup, c10 and perq
6150 terminals, which are no longer supported (bug#1482).
6151
8974cc9f
JB
61522011-07-10 Johan Bockgård <bojohan@gnu.org>
6153
6154 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6155
a560d974
JD
61562011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6157
6158 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6159 for non-popups (Bug#3642).
6160
1dae0f0a
AS
61612011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6162
268c2c36 6163 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6164 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6165 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6166 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6167 * data.c (fmod): Likewise.
6168 * dispnew.c (swap_glyphs_in_rows): Likewise.
6169 * emacs.c (memory_warning_signal): Likewise.
6170 * floatfns.c (float_error): Likewise.
6171 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6172 (otf_open, font_otf_capability, generate_otf_features)
6173 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6174 Likewise.
6175 * image.c (pbm_read_file): Likewise.
6176 * indent.c (string_display_width): Likewise.
6177 * intervals.c (check_for_interval, search_for_interval)
6178 (inc_interval_count, count_intervals, root_interval)
6179 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6180 * lread.c (defalias): Likewise.
268c2c36 6181 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6182 * regex.c (set_image_of_range_1, set_image_of_range)
6183 (regex_grow_registers): Likewise.
6184 * sysdep.c (strerror): Likewise.
6185 * termcap.c (valid_filename_p, tprint, main): Likewise.
6186 * tparam.c (main): Likewise.
6187 * unexhp9k800.c (run_time_remap, save_data_space)
6188 (update_file_ptrs, read_header, write_header, calculate_checksum)
6189 (copy_file, copy_rest, display_header): Likewise.
6190 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6191 Likewise.
6192 * xdisp.c (check_it): Likewise.
6193 * xfaces.c (register_color, unregister_color, unregister_colors):
6194 Likewise.
6195 * xfns.c (print_fontset_result): Likewise.
6196 * xrdb.c (member, fatal, main): Likewise.
6197
99033785
PE
61982011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6199
6200 Fix minor problems found by static checking (Bug#9031).
6201 * chartab.c (char_table_set_range, map_sub_char_table):
6202 Remove unused locals.
6203 (uniprop_table): Now static.
6204 * composite.c (_work_char): Remove unused static var.
6205
9cb2ac56
JB
62062011-07-09 Juanma Barranquero <lekktu@gmail.com>
6207
6208 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6209
f25661f0
JD
62102011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6211
6212 * gtkutil.c (qttip_cb): Remove code without function.
6213
8278c4fe
EZ
62142011-07-09 Eli Zaretskii <eliz@gnu.org>
6215
6216 * w32.c (pthread_sigmask): New stub.
6217
1692ae2d 62182011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6219
8a6ebd58 6220 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6221 sigprocmask is portable only for single-threaded applications, and
6222 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6223 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6224 (LIBES): Use it.
6225 * callproc.c (Fcall_process):
6226 * process.c (create_process):
6227 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6228 Use pthread_sigmask, not sigprocmask.
123403e4 6229
1b854618
JD
62302011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6231
6232 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6233 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6234 wrong (Bug#8591).
6235
3fe4b549
JD
62362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6237
0ce7e563
JD
6238 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6239 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6240 (xg_hide_tooltip): Fix comment.
6241
3fe4b549
JD
6242 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6243 in registerServicesMenuSendTypes.
6244 (validRequestorForSendType): Don't check ns_return_types.
6245
6246 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6247 ns_return_type.
6248
5df75e47
JR
62492011-07-08 Jason Rumney <jasonr@gnu.org>
6250
22610910
JR
6251 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6252 SH_SHOW for hidden windows (Bug#5482).
6253
5df75e47
JR
6254 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6255 frame struct members of non-existent frames (Bug#6284).
6256
699c10bd
JD
62572011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6258
4393663b
JD
6259 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6260 variable firstTime not needed on OSX >= 10.6.
6261 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6262 >= 10.5. Use setKnobProportion, setDoubleValue.
6263
6264 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6265 (MAC_OS_X_VERSION_10_5): Define if not defined.
6266 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6267 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6268 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6269
6270 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6271 cString and lossyCString on OSX >= 10.4
6272
58179cce 6273 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6274 sizeToFit on OSX >= 10.2.
6275
6276 * nsimage.m (allocInitFromFile): Don't use deprecated method
6277 bestRepresentationForDevice on OSX >= 10.6.
6278
6279 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6280 to avoid warning.
6281
6282 * emacs.c: Declare unexec_init_emacs_zone.
6283
a63e0781
JD
6284 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6285
699c10bd
JD
6286 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6287
6288 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6289 on svcsMenu (Bug#8842).
6290
6291 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6292 ns_return_types.
6293 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6294
6295 * nsterm.m (QUTF8_STRING): Declare.
6296 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6297 (validRequestorForSendType): Return type is (id).
6298 Change indexOfObjectIdenticalTo to indexOfObject.
6299 Check if we have local selection before returning self (Bug#8842).
6300 (writeSelectionToPasteboard): Put local selection into paste board
6301 if we have a local selection (Bug#8842).
6302 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6303
6304 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6305 (ns_get_local_selection): Declare.
6306
54e10184
LMI
63072011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6308
9888ff71
LMI
6309 * keymap.c (describe_map_tree): Don't insert a double newline at
6310 the end of the buffer (bug#1169) and return whether we inserted
6311 something.
6312
54e10184
LMI
6313 * callint.c (Fcall_interactively): Change "reading args" to
6314 "providing args" to try to clarify what it does (bug#1010).
6315
15fa4783
KH
63162011-07-07 Kenichi Handa <handa@m17n.org>
6317
6318 * composite.c (composition_compute_stop_pos): Ignore a static
6319 composition starting before CHARPOS (Bug#8915).
6320
6321 * xdisp.c (handle_composition_prop): Likewise.
6322
a8815b00
EZ
63232011-07-07 Eli Zaretskii <eliz@gnu.org>
6324
6325 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6326 (Bug#9015)
6327
ef7b981d 63282011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6329
6330 * character.h (unicode_category_t): New enum type.
6331
6332 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6333 (Qchar_code_property_table): New variable.
6334 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6335 (UNIPROP_COMPRESSED_FORM_P): New macros.
6336 (char_table_ascii): Uncompress the compressed values.
6337 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6338 Uncompress the compressed values.
ac389d0c 6339 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6340 (char_table_ref_and_range): Uncompress the compressed values.
6341 (sub_char_table_set): New arg is_uniprop. Callers changed.
6342 Uncompress the compressed values.
6343 (sub_char_table_set_range): Args changed. Callers changed.
6344 (char_table_set_range): Adjuted for the above change.
6345 (map_sub_char_table): Delete args default_val and parent. Add arg
6346 top. Give decoded values to a Lisp function.
640c8776 6347 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6348 values to a Lisp function. Gcpro more variables.
6349 (uniprop_table_uncompress)
6350 (uniprop_decode_value_run_length): New functions.
6351 (uniprop_decoder, uniprop_decoder_count): New variables.
6352 (uniprop_get_decoder, uniprop_encode_value_character)
6353 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6354 New functions.
6355 (uniprop_encoder, uniprop_encoder_count): New variables.
6356 (uniprop_get_encoder, uniprop_table)
6357 (Funicode_property_table_internal, Fget_unicode_property_internal)
6358 (Fput_unicode_property_internal): New functions.
6359 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6360 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6361 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6362 char-code-property-alist.
6363
640c8776 6364 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6365 Vunicode_category_table.
6366
640c8776 6367 * font.c (font_range): Adjust for the change of
c805dec0
KH
6368 Vunicode_category_table.
6369
76b397fb
DN
63702011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6371
6372 * m/iris4d.h: Remove file, move contents ...
6373 * s/irix6-5.h: ... here.
6374
22b4128e
PE
63752011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6376
6377 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6378 * alloc.c (mark_buffer):
6379 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6380 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6381 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6382 This isn't true in general, and it's particularly not true
6383 if Emacs is configured with --with-wide-int.
6384 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6385 New macros, used in the buffer.c change.
6386
869795d6
JD
63872011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6388
6389 * xsettings.c: Use both GConf and GSettings if both are available.
6390 (store_config_changed_event): Add comment.
6391 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6392 (store_tool_bar_style_changed): New functions.
5e617bc2 6393 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6394 (struct xsettings): Move font inside HAVE_XFT.
6395 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6396 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6397 Move inside HAVE_XFT.
640c8776 6398 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6399 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6400 also.
6401 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6402 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6403 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6404 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6405 (parse_settings): Move check for font inside HAVE_XFT.
6406 (read_settings, apply_xft_settings): Add comment.
6407 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6408 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6409 call store_font_name_changed.
6410 (xft_settings_event): Add comment.
6411 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6412 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6413 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6414 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6415 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6416 (xsettings_get_system_font, xsettings_get_system_normal_font):
6417 Add comment.
869795d6 6418
d8ed26bd
PE
64192011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6420
6421 Random fixes. E.g., (random) never returned negative values.
6422 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6423 subseconds part to the entropy, as that's a bit more random.
6424 Prefer signed to unsigned, since the signedness doesn't matter and
6425 in general we prefer signed. When given a limit, use a
6426 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6427 latter isn't right if USE_2_TAGS_FOR_INTS.
6428 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6429 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6430
cabf1cac
SM
64312011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6432
6433 * textprop.c (text_property_stickiness):
6434 Obey Vtext_property_default_nonsticky.
6435 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6436 * w32fns.c (syms_of_w32fns):
6437 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6438
6e9b2be9
PE
64392011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6440
6441 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6442 This is more efficient than Ffile_directory_p and avoids a minor race.
6443
90186c68
LMI
64442011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6445
7c301272
LMI
6446 * buffer.c (Foverlay_put): Say what the return value is
6447 (bug#7835).
6448
c4f2d8d4
LMI
6449 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6450 is a directory before asking whether to use the file name
6451 (bug#7564).
ad637907
LMI
6452 (barf_or_query_if_file_exists): Make the "File is a directory"
6453 error be more correct.
c4f2d8d4 6454
90186c68
LMI
6455 * fns.c (Frequire): Remove the mention of the .gz files, since
6456 that's installation-specific, but keep the mention of
6457 `get-load-suffixes'.
6458
da64016e
PE
64592011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6460
6461 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6462 Report string overflow if the output is too long.
6463
7d47b580
JB
64642011-07-04 Juanma Barranquero <lekktu@gmail.com>
6465
a555cb87
JB
6466 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6467 (syms_of_gnutls): Remove duplicate DEFSYM for
6468 Qgnutls_bootprop_verify_hostname_error, an error for
6469 Qgnutls_bootprop_verify_error (which is no longer used).
6470
7d47b580
JB
6471 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6472 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6473 Also (re)move comments that are misplaced or no longer relevant.
6474
1e49bfab
LMI
64752011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6476
6477 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6478
1485f4c0
CY
64792011-07-03 Chong Yidong <cyd@stupidchicken.com>
6480
6481 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6482 and background color parameters if they have been changed.
6483
a9ab721e
LMI
64842011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6485
6486 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6487
cf7cff57
PE
64882011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6489
2e13213d
PE
6490 * xsettings.c (SYSTEM_FONT): Define only when used.
6491 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6492
cf7cff57
PE
6493 * keymap.c (access_keymap_1): Now static.
6494
7a8e04f7
CY
64952011-07-02 Chong Yidong <cyd@stupidchicken.com>
6496
6497 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6498 leave any prefix arg for the up event (Bug#1586).
6499
61352f62
LMI
65002011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6501
69bb1ef7
LMI
6502 * lread.c (syms_of_lread): Mention single symbols defined by
6503 `defvar' or `defconst' (bug#7154).
6504
61352f62 6505 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6506 (Frequire): Mention get-load-suffixes.
61352f62 6507
28545e04
MR
65082011-07-02 Martin Rudalics <rudalics@gmx.at>
6509
6510 * window.h (window): Remove clone_number slot.
6511 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6512 Remove.
6513 (make_parent_window, make_window, saved_window)
6514 (Fset_window_configuration, save_window_save): Don't deal with
6515 clone numbers.
6516 * buffer.c (Qclone_number): Remove declaration.
6517 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6518
3349e122
SM
65192011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6520
6521 Add multiple inheritance to keymaps.
6522 * keymap.c (Fmake_composed_keymap): New function.
6523 (Fset_keymap_parent): Simplify.
6524 (fix_submap_inheritance): Remove.
6525 (access_keymap_1): New function extracted from access_keymap to handle
6526 embedded parents and handle lists of maps.
6527 (access_keymap): Use it.
6528 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6529 (Fcopy_keymap): Handle embedded parents.
6530 (Fcommand_remapping, define_as_prefix): Simplify.
6531 (Fkey_binding): Simplify.
6532 (syms_of_keymap): Move minibuffer-local-completion-map,
6533 minibuffer-local-filename-completion-map,
6534 minibuffer-local-must-match-map, and
6535 minibuffer-local-filename-must-match-map to Elisp.
6536 (syms_of_keymap): Defsubr make-composed-keymap.
6537 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6538 (parse_menu_item): Trivial simplification.
6539
3279eb87
GM
65402011-07-01 Glenn Morris <rgm@gnu.org>
6541
6542 * Makefile.in (SETTINGS_LIBS): Fix typo.
6543
4550efdf
KI
65442011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6545
6546 * coding.c (Fencode_coding_string): Record the last coding system
6547 used, as the function doc string says (bug#8738).
6548
0949d2b6
JD
65492011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6550
6551 * xsettings.c (store_monospaced_changed): Take new font as arg and
6552 check for change against current_mono_font.
6553 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6554 (emacs_settings_constructor, emacs_settings_get_property)
6555 (emacs_settings_set_property, emacs_settings_class_init)
6556 (emacs_settings_init, gsettings_obj): Remove.
6557 (something_changedCB): New function for HAVE_GSETTINGS.
6558 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6559 with value as argument.
6560 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6561 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6562 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6563 "changed".
6564
6565 * xgselect.c: Add defined (HAVE_GSETTINGS).
6566 (xgselect_initialize): Ditto.
6567
6568 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6569 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6570 xg_select.
6571
bbc6b304
PE
65722011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6573
6574 * eval.c (struct backtrace): Simplify and port the data structure.
6575 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6576 signed bit field, as this assumption is not portable and it makes
6577 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6578 "char debug_on_exit : 1" as this is not portable either; instead,
6579 use the portable "unsigned int debug_on_exit : 1". Remove unused
6580 member evalargs. Remove obsolete comments about cc bombing out.
6581
9851bfc5
JD
65822011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6583
51bb811f 6584 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6585 Let HAVE_GSETTINGS override HAVE_GCONF.
6586 (store_monospaced_changed): New function.
6587 (EMACS_SETTINGS): A new type derived from GObject to handle
6588 GSettings notifications.
6589 (emacs_settings_constructor, emacs_settings_get_property)
6590 (emacs_settings_set_property, emacs_settings_class_init):
6591 New functions.
6592 (gsettings_client, gsettings_obj): New variables.
6593 (GSETTINGS_SCHEMA): New define.
6594 (something_changedCB): Call store_monospaced_changed.
6595 (init_gsettings): New function.
6596 (xsettings_initialize): Call init_gsettings.
6597 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6598 to NULL.
6599
640c8776 6600 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6601 GCONF_CFLAGS/LIBS.
6602
5386012d
MR
66032011-06-29 Martin Rudalics <rudalics@gmx.at>
6604
6605 * window.c (resize_root_window, grow_mini_window)
6606 (shrink_mini_window): Rename Qresize_root_window to
6607 Qwindow_resize_root_window and Qresize_root_window_vertically to
6608 Qwindow_resize_root_window_vertically.
6609
f13e0b08
PE
66102011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6611
6612 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6613
94515237
JB
66142011-06-27 Juanma Barranquero <lekktu@gmail.com>
6615
6616 * makefile.w32-in: Redesign dependencies so they reflect more
6617 clearly which files are directly included by each source file,
6618 and not through other includes.
6619
e43b6e43
MR
66202011-06-27 Martin Rudalics <rudalics@gmx.at>
6621
6622 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6623 (sort_overlays, overlay_strings): When an overlay's clone number
6624 matches the window's clone number process the overlay even if
6625 the overlay's window property doesn't match the current window.
6626
d68443dc
MR
6627 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6628 (Fwindow_hchild): Rename to Fwindow_left_child.
6629 (Fwindow_next): Rename to Fwindow_next_sibling.
6630 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6631 (resize_window_check): Rename to window_resize_check.
6632 (resize_window_apply): Rename to window_resize_apply.
6633 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6634 (Fdelete_other_windows_internal, resize_frame_windows)
6635 (Fsplit_window_internal, Fdelete_window_internal)
6636 (grow_mini_window, shrink_mini_window)
6637 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6638
c7e73be5
JD
66392011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6640
6641 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6642 (emacs_fixed_set_min_size): Remove.
6643 (emacs_fixed_new): Take frame as argument.
6644
6645 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6646 (_EmacsFixedPrivate): Remove minwidth/height.
6647 Add struct frame *f.
6648 (emacs_fixed_init): Initialize priv->f.
6649 (get_parent_class, emacs_fixed_set_min_size): Remove.
6650 (emacs_fixed_new): Set priv->f to argument.
6651 (emacs_fixed_get_preferred_width)
6652 (emacs_fixed_get_preferred_height): Use min_width/height from
6653 frames size_hint to set minimum and natural (Bug#8919).
6654 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6655 and use min_width/height from frames size_hint to set
6656 min_width/height (Bug#8919).
6657
6658 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6659 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6660 Fix indentation.
c7e73be5 6661
cf99dcf8
EZ
66622011-06-26 Eli Zaretskii <eliz@gnu.org>
6663
6664 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6665 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6666 called at ZV.
6667
029529ac
CY
66682011-06-26 Chong Yidong <cyd@stupidchicken.com>
6669
6670 * process.c (wait_reading_process_output): Bypass select if
6671 waiting for a cell while ignoring keyboard input, and input is
6672 pending. Suggested by Jan Djärv (Bug#8869).
6673
7a7ef429
PE
66742011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6675
6676 Use gnulib's dup2 module instead of rolling our own.
6677 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6678
11fdef7d 66792011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6680
6681 * dispnew.c (scrolling_window): Before scrolling, turn off a
6682 mouse-highlight in the window being scrolled.
6683
cd3520a4
JB
66842011-06-24 Juanma Barranquero <lekktu@gmail.com>
6685
6686 Move DEFSYM to lisp.h and use everywhere.
6687
6688 * character.h (DEFSYM): Move declaration...
6689 * lisp.h (DEFSYM): ...here.
6690
6691 * gnutls.c:
6692 * minibuf.c:
6693 * w32menu.c:
6694 * w32proc.c:
6695 * w32select.c: Don't include character.h.
6696
6697 * alloc.c (syms_of_alloc):
6698 * buffer.c (syms_of_buffer):
6699 * bytecode.c (syms_of_bytecode):
6700 * callint.c (syms_of_callint):
6701 * casefiddle.c (syms_of_casefiddle):
6702 * casetab.c (init_casetab_once):
6703 * category.c (init_category_once, syms_of_category):
6704 * ccl.c (syms_of_ccl):
6705 * cmds.c (syms_of_cmds):
6706 * composite.c (syms_of_composite):
6707 * dbusbind.c (syms_of_dbusbind):
6708 * dired.c (syms_of_dired):
6709 * dispnew.c (syms_of_display):
6710 * doc.c (syms_of_doc):
6711 * editfns.c (syms_of_editfns):
6712 * emacs.c (syms_of_emacs):
6713 * eval.c (syms_of_eval):
6714 * fileio.c (syms_of_fileio):
6715 * fns.c (syms_of_fns):
6716 * frame.c (syms_of_frame):
6717 * fringe.c (syms_of_fringe):
6718 * insdel.c (syms_of_insdel):
6719 * keymap.c (syms_of_keymap):
6720 * lread.c (init_obarray, syms_of_lread):
6721 * macros.c (syms_of_macros):
6722 * msdos.c (syms_of_msdos):
6723 * print.c (syms_of_print):
6724 * process.c (syms_of_process):
6725 * search.c (syms_of_search):
6726 * sound.c (syms_of_sound):
6727 * syntax.c (init_syntax_once, syms_of_syntax):
6728 * terminal.c (syms_of_terminal):
6729 * textprop.c (syms_of_textprop):
6730 * undo.c (syms_of_undo):
6731 * w32.c (globals_of_w32):
6732 * window.c (syms_of_window):
6733 * xdisp.c (syms_of_xdisp):
6734 * xfaces.c (syms_of_xfaces):
6735 * xfns.c (syms_of_xfns):
6736 * xmenu.c (syms_of_xmenu):
6737 * xsettings.c (syms_of_xsettings):
6738 * xterm.c (syms_of_xterm): Use DEFSYM.
6739
4228cf16
TZ
67402011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6741
cd3520a4 6742 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6743
7fcccf1e
PE
67442011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6745
7efb4e0e
PE
6746 Integer and buffer overflow fixes (Bug#8873).
6747
ff5844ad
PE
6748 * print.c (printchar, strout): Check for string overflow.
6749 (PRINTPREPARE, printchar, strout):
6750 Don't set size unless allocation succeeds.
6751
90532f02
PE
6752 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6753 for sizes. Check for string overflow more accurately.
6754 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6755
6d84508d
PE
6756 * macros.c: Integer and buffer overflow fixes.
6757 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6758 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6759 Use ptrdiff_t, not int, for sizes.
6760 Don't increment bufsize until after realloc succeeds.
6761 Check for size-calculation overflow.
6762 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6763
437b2cb4
PE
6764 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6765
8b9ac8b4
PE
6766 * lread.c: Integer overflow fixes.
6767 (read_integer): Radix is now EMACS_INT, not int,
6768 to improve quality of diagnostics for out-of-range radices.
6769 Calculate buffer size correctly for out-of-range radices.
6770 (read1): Check for integer overflow in radices, and in
6771 read-circle numbers.
82cb60d3
PE
6772 (read_escape): Avoid int overflow.
6773 (Fload, openp, read_buffer_size, read1)
6774 (substitute_object_recurse, read_vector, read_list, map_obarray):
6775 Use ptrdiff_t, not int, for sizes.
6776 (read1): Use EMACS_INT, not int, for sizes.
20270765 6777 Check for size overflow.
8b9ac8b4 6778
7fcccf1e
PE
6779 * image.c (cache_image): Check for size arithmetic overflow.
6780
bfbbd7e7
PE
6781 * lread.c: Integer overflow issues.
6782 (saved_doc_string_size, saved_doc_string_length)
6783 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6784 Now ptrdiff_t, not int.
6785 (read1): Don't assume doc string length fits in int. Check for
6786 out-of-range doc string lengths.
6787 (read_list): Don't assume file position fits in int.
39019e54 6788 (read_escape): Check for hex character overflow.
bfbbd7e7 6789
4e323265
LL
67902011-06-22 Leo Liu <sdl.web@gmail.com>
6791
6792 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6793 Move to minibuffer.el.
6794
85fece3e
PE
67952011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6796
20b84ce9 6797 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6798 The following patches are for when GLYPH_DEBUG && !XASSERT.
6799 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6800 * dispnew.c (flush_stdout):
6801 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6802 Mark as externally visible.
6803 * dispnew.c (check_window_matrix_pointers): Now static.
6804 * dispnew.c (window_to_frame_vpos):
6805 * xfns.c (unwind_create_frame):
6806 * xterm.c (x_check_font): Remove unused local.
6807 * scroll.c (CHECK_BOUNDS):
6808 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6809 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6810 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6811 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6812 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6813 Now static.
6814 (debug_method_add): Use va_list and vsprintf rather than relying
6815 on undefined behavior with wrong number of arguments.
6816 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6817 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6818 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6819 since we're not interested in debugging glyphs with old libraries.
6820 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6821 GCC 4.6.0's static checking.
6822
0766b489
PE
68232011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6824
31fd4b32
PE
6825 Integer overflow and signedness fixes (Bug#8873).
6826 A few related buffer overrun fixes, too.
6827
b79e8648
PE
6828 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6829
0766b489
PE
6830 * dispextern.h (struct face.stipple):
6831 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6832 (x_bitmap_mask, x_allocate_bitmap_record)
6833 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6834 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6835 (x_create_bitmap_from_xpm_data):
6836 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6837 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6838 (.bitmaps_last):
6839 * xfaces.c (load_pixmap):
6840 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6841 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6842 (.bitmaps_last, struct x_output.icon_bitmap):
6843 Use ptrdiff_t, not int, for bitmap indexes.
6844 (x_allocate_bitmap_record): Check for size overflow.
6845 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6846
b081724f
PE
6847 Use ptrdiff_t, not int, for overlay counts.
6848 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6849 * editfns.c (overlays_around, get_pos_property):
6850 * textprop.c (get_char_property_and_overlay):
6851 * xdisp.c (next_overlay_change, note_mouse_highlight):
6852 * xfaces.c (face_at_buffer_position):
21514da7
PE
6853 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6854 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6855 (Fnext_overlay_change, Fprevious_overlay_change)
6856 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6857 Use ptrdiff_t, not int, for sizes.
21514da7 6858 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6859
3de73e5e
PE
6860 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6861
2606c57b
PE
6862 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6863 (x_session_initialize): Do not assume string length fits in int.
6864
aaafe47a
PE
6865 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6866 This is unlikely, but can occur if DPI is outlandish.
6867
2674ddc8 6868 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6869 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6870
28154962
PE
6871 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6872 * xrdb.c (magic_file_p, search_magic_path):
6873 Omit last arg SUFFIX; it was always 0. All callers changed.
6874 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6875
7de51af5
PE
6876 * xfont.c (xfont_match): Avoid need for strlen.
6877
25ed6cc3
PE
6878 * xfns.c: Don't assume strlen fits in int.
6879 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6880
4eab31dd
PE
6881 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6882 not unsigned long, as we prefer signed integers. All callers changed.
6883 Detect integer overflow in repeat count.
6884 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6885 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6886
171e2a58
PE
6887 * termcap.c: Don't assume sizes fit in int and never overflow.
6888 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6889 (gobble_line): Check for size-calculation overflow.
6890
ad39faca 6891 * minibuf.c (Fread_buffer):
6e5bb2dc 6892 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6893 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6894 Don't assume string length fits in int.
6895
52c61c22 6896 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6897 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6898
b5b8c9e5
PE
6899 * font.c: Don't assume string length fits in int.
6900 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6901 Use ptrdiff_t, not int.
ccd6111c
PE
6902 (font_intern_prop): Don't assume string length fits in int.
6903 Don't assume integer property fits in fixnum.
6904 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6905
882f0d81 6906 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6907 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6908 Reformulate so as not to need the command string.
6909 Invoke gzip -cd rather than gunzip, as it's more portable.
6910 (lock_info_type, lock_file_1, lock_file):
6911 Don't assume pid_t and time_t fit in unsigned long.
6912 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6913 (current_lock_owner): Prefer signed type for sizes.
6914 Use memcpy, not strncpy, where memcpy is what is really wanted.
6915 Don't assume (via atoi) that time_t and pid_t fit in int.
6916 Check for time_t and/or pid_t out of range, e.g., via a network share.
6917 Don't alloca where an auto var works fine.
6918
93f4cf88
PE
6919 * fileio.c: Fix some integer overflow issues.
6920 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6921 Don't assume string length fits in int.
6922 (directory_file_name): Don't assume string length fits in long.
6923 (make_temp_name): Don't assume pid fits in int, or that its print
6924 length is less than 20.
6925
f3e92b69
PE
6926 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6927
1bfdaf10
PE
6928 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6929
35016e9a
PE
6930 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6931
3d1e65a1
PE
6932 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6933 We prefer signed integers, even for size calculations.
6934
0b963a93
PE
6935 * emacs.c: Don't assume string length fits in 'int'.
6936 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6937 (main): Don't invoke strlen when not needed.
6938
573f4b54
PE
6939 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6940 (XD_DEBUG_MESSAGE): Don't waste a byte.
6941
989f33ba
PE
6942 * callproc.c (getenv_internal_1, getenv_internal)
6943 (Fgetenv_internal):
965d34eb
PE
6944 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6945
e4d29b33
PE
6946 * lread.c (invalid_syntax): Omit length argument.
6947 All uses changed. This doesn't fix a bug, but it simplifies the
6948 code away from its former Hollerith-constant appearance, and it's
6949 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 6950 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 6951
eb49b136
PE
6952 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6953 This didn't break anything, but it didn't help either.
6954 It's confusing to put a bogus integer in a place where the actual
6955 value does not matter.
9f62aeb1 6956 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 6957 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 6958
15375a22
PE
6959 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6960 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6961 implementation.
b61cc01c
PE
6962 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6963 We prefer signed types, and the value cannot exceed the EMACS_INT
6964 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
6965 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6966 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6967 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 6968
53b2623d
PE
6969 * indent.c (sane_tab_width): New function.
6970 (current_column, scan_for_column, Findent_to, position_indentation)
6971 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 6972 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 6973
51cab52b 6974 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 6975
f2ed8a70
PE
6976 * lisp.h (lint_assume): New macro.
6977 * composite.c (composition_gstring_put_cache):
6978 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6979
abe80cc6
PE
6980 * editfns.c, insdel.c:
6981 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 6982
b02c740e
PE
6983 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6984
ebc96716
PE
6985 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6986
b4e50fa0 6987 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 6988 Use much-faster test for byte-length change.
311d5d7c 6989 Don't assume string byte-length fits in 'int'.
a4cf38e4 6990 Check that character arg fits in 'int'.
85461888 6991 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 6992
c0c1ee9f
PE
6993 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6994
a498d7f4
PE
6995 * fns.c (concat): Catch string overflow earlier.
6996 Do not rely on integer wraparound.
6997
51cab52b
PE
6998 * dispextern.h (struct it.overlay_strings_charpos)
6999 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7000 * xdisp.c (forward_to_next_line_start)
7001 (back_to_previous_visible_line_start)
7002 (reseat_at_next_visible_line_start, next_element_from_buffer):
7003 Don't arbitrarily truncate the value of 'selective' to int.
7004
76031fad
PE
7005 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7006
5eb55db9
PE
7007 * composite.c: Don't truncate sizes to 'int'.
7008 (composition_gstring_p, composition_reseat_it)
7009 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7010 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7011 not EMACS_UINT, for indexes.
5eb55db9 7012
0703a717
PE
7013 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7014
d6202519
PE
7015 * buffer.c: Include <verify.h>.
7016 (struct sortvec.priority, struct sortstr.priority):
8961a454 7017 Now EMACS_INT, not int.
c20998a7 7018 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7019 (struct sortstr.size, record_overlay_string)
7020 (struct sortstrlist.size, struct sortlist.used):
7021 Don't truncate size to int.
7022 (record_overlay_string): Check for size-calculation overflow.
d6202519 7023 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7024
d5a19415
JM
70252011-06-22 Jim Meyering <meyering@redhat.com>
7026
029529ac 7027 Don't leak an XBM-image-sized buffer
d5a19415
JM
7028 * image.c (xbm_load): Free the image buffer after using it.
7029
a9041e6c
PE
70302011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7031
7032 Port to Sun C.
7033 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7034 that Sun C diagnosed.
7035 * fns.c (secure_hash): Fix pointer signedness issue.
7036 * intervals.c (static_offset_intervals): New function.
7037 (offset_intervals): Use it.
7038
7f3f739f
LL
70392011-06-21 Leo Liu <sdl.web@gmail.com>
7040
7041 * deps.mk (fns.o):
7042 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7043 sha512.h.
7044
7045 * fns.c (secure_hash): Rename from crypto_hash_function and change
7046 the first arg to accept symbols.
5b66d427 7047 (Fsecure_hash): New primitive.
7f3f739f
LL
7048 (syms_of_fns): New symbols.
7049
76147d94
DD
70502011-06-20 Deniz Dogan <deniz@dogan.se>
7051
7052 * process.c (Fset_process_buffer): Clarify return value in
7053 docstring.
7054
7d7d0045
CY
70552011-06-18 Chong Yidong <cyd@stupidchicken.com>
7056
7057 * dispnew.c (add_window_display_history): Use BVAR.
7058
7059 * xdisp.c (debug_method_add): Use BVAR.
7060 (check_window_end, dump_glyph_matrix, dump_glyph)
7061 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7062
7063 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7064 Likewise.
7065
7066 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7067 check till after the cache is created in init_frame_faces.
7068
ff2bc410
SM
70692011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7070
7071 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7072
28177add
PE
70732011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7074
dd3482fe
PE
7075 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7076 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7077 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7078
393d71f3 7079 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7080 * fileio.c (Finsert_file_contents):
7081 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7082 Remove the old (too-loose) buffer overflow checks.
7083 They weren't needed, since make_gap checks for buffer overflow.
7084 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7085 The old code merely checked for Emacs fixnum overflow, and relied
7086 on undefined (wraparound) behavior. The new code avoids undefined
7087 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7088
2e6813b0 7089 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7090 Tune. Don't use wider integers than needed. Don't use alloca.
7091 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7092
599a9e4f
PE
7093 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7094
99561444
PE
7095 * insdel.c, lisp.h (buffer_overflow): New function.
7096 (insert_from_buffer_1, replace_range, replace_range_2):
7097 * insdel.c (make_gap_larger):
7098 * editfns.c (Finsert_char):
7099 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7100
28177add
PE
7101 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7102
e69dafad
PE
71032011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7104
4baa020d 7105 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7106
b1c46f02
PE
7107 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7108 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7109
e69dafad
PE
7110 * fileio.c: Don't assume EMACS_INT fits in off_t.
7111 (emacs_lseek): New static function.
7112 (Finsert_file_contents, Fwrite_region): Use it.
7113 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7114
566684ea
PE
7115 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7116
e6966cd6
PE
7117 * fns.c: Don't overflow int when computing a list length.
7118 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7119 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7120 truncation on 64-bit hosts. Check for QUIT every
7121 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7122 faster and is responsive enough.
7123 (Flength): Report an error instead of overflowing an integer.
7124 (Fsafe_length): Return a float if the value is not representable
7125 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7126 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7127 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7128
dd0b0efb
PE
7129 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7130 (header_size, word_size): New constants.
7131 (allocate_vectorlike): Don't check size overflow here.
7132 (allocate_vector): Check it here instead, since this is the only
7133 caller of allocate_vectorlike that could cause overflow.
7134 Check that the new vector's length is representable as a fixnum.
7135
86fe5cfe
PE
7136 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7137 The previous code was bogus. For example, next_almost_prime (32)
7138 returned 39, which is undesirable as it is a multiple of 3; and
7139 next_almost_prime (24) returned 25, which is a multiple of 5 so
7140 why was the code bothering to check for multiples of 7?
7141
80e88859
PE
7142 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7143
4a2f0ad6
PE
7144 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7145
f66c7cf8
PE
7146 Variadic C functions now count arguments with ptrdiff_t.
7147 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7148 Back then I didn't know that the Emacs coding style prefers signed int.
7149 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7150 were being counted with int, which may truncate counts on 64-bit
7151 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7152 * lisp.h (struct Lisp_Subr.function.aMANY)
7153 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7154 Arg counts are now ptrdiff_t, not size_t.
7155 All variadic functions and their callers changed accordingly.
7156 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7157 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7158 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7159 * callint.c (Fcall_interactively): Check arg count for overflow,
7160 to avoid potential buffer overrun. Use signed char, not 'int',
7161 for 'varies' array, so that we needn't bother to check its size
7162 calculation for overflow.
7163 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7164 * eval.c (apply_lambda):
7165 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7166 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7167 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7168
a1759b76
PE
7169 * callint.c (Fcall_interactively): Don't use index var as event count.
7170
d96be9fc
PE
7171 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7172 * mem-limits.h (SIZE): Remove; no longer used.
7173
a690a978 7174 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7175
578c21e6
PE
7176 Remove unnecessary casts.
7177 * xterm.c (x_term_init):
7178 * xfns.c (x_set_border_pixel):
7179 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7180 These aren't needed now that we assume ANSI C.
7181
96f53c6c
PE
7182 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7183 It's more likely to cause problems (due to unsigned overflow)
7184 than to cure them.
7185
83c77d31
PE
7186 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7187
ee2079f1
PE
7188 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7189
6da65536
PE
7190 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7191
7147c4a4
PE
7192 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7193
193e32d9
PE
7194 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7195
e5533da6
PE
7196 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7197
9910e595
PE
7198 GLYPH_CODE_FACE returns EMACS_INT, not int.
7199 * dispextern.h (merge_faces):
7200 * xfaces.c (merge_faces):
01103c44
PE
7201 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7202 Don't assume EMACS_INT fits in int.
9910e595 7203
2638320e
PE
7204 * character.h (CHAR_VALID_P): Remove unused parameter.
7205 * fontset.c, lisp.h, xdisp.c: All uses changed.
7206
045eb8d9
PE
7207 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7208
c1f134b5
PE
7209 * fns.c (concat): Minor tuning based on overflow analysis.
7210 This doesn't fix any bugs. Use int to hold character, instead
7211 of constantly refetching from Emacs object. Use XFASTINT, not
7212 XINT, for value known to be a character. Don't bother comparing
7213 a single byte to 0400, as it's always less.
7214
395fcb93 7215 * floatfns.c (Fexpt):
327eeec8
PE
7216 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7217
abbd3d23
PE
7218 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7219 for characters.
7220
684a03ef
PE
7221 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7222
0fed43f3
PE
7223 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7224 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7225 incorrectly succeed when S was a string, because 4294967386 was
7226 truncated before it was used.
7227
8fd02eb7
PE
7228 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7229 Otherwise, an out-of-range integer could cause undefined behavior
7230 on a 64-bit host.
7231
f8c86b69
PE
7232 * composite.c: Use int, not EMACS_INT, for characters.
7233 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7234 EMACS_INT, for values that are known to be in character range.
7235 This doesn't fix any bugs but is the usual style inside Emacs and
7236 may generate better code on 32-bit machines.
7237
34206dd2
PE
7238 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7239 This is for reasons similar to the recent CHAR_STRING fix.
7240 * charset.c (Fencode_char): Check that character arg is actually
7241 a character. Pass an int to ENCODE_CHAR.
7242 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7243 wider than 'int', as a compile-time check to prevent future regressions
7244 in this area.
7245
c5958d4c 7246 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7247
7248 Make sure a 64-bit char is never passed to CHAR_STRING.
7249 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7250 by silently ignoring the top 32 bits, allowing some values
7251 that were far too large to be valid characters.
7252 * character.h: Include <verify.h>.
7253 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7254 arguments are no wider than unsigned, as a compile-time check
7255 to prevent future regressions in this area.
7256 * data.c (Faset):
01103c44 7257 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7258 (Fsubst_char_in_region):
7259 * fns.c (concat):
7260 * xdisp.c (decode_mode_spec_coding):
7261 Adjust to CHAR_STRING's new requirement.
7262 * editfns.c (Finsert_char, Fsubst_char_in_region):
7263 * fns.c (concat): Check that character args are actually
7264 characters. Without this test, these functions did the wrong
7265 thing with wildly out-of-range values on 64-bit hosts.
7266
d37ca623
PE
7267 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7268 These casts should not be needed on 32-bit hosts, either.
7269 * keyboard.c (read_char):
7270 * lread.c (Fload): Remove casts to unsigned.
7271
ea204efb
PE
7272 * lisp.h (UNSIGNED_CMP): New macro.
7273 This fixes comparison bugs on 64-bit hosts.
7274 (ASCII_CHAR_P): Use it.
7275 * casefiddle.c (casify_object):
01103c44 7276 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7277 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7278 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7279 * dispextern.h (FACE_FROM_ID):
7280 * keyboard.c (read_char): Use UNSIGNED_CMP.
7281
41cb286c
PE
7282 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7283 not to EMACS_INT, to avoid GCC warning.
7284
4a1b9832
PE
7285 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7286
55daad71
PE
7287 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7288 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7289 isn't needed on 32-bit machines.
8f95c75c 7290
01103c44
PE
7291 * buffer.c (Fgenerate_new_buffer_name):
7292 Use EMACS_INT for count, not int.
0ceccced 7293 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7294
7295 * data.c (Qcompiled_function): Now static.
7296
c6f072e7
PE
7297 * window.c (window_body_lines): Now static.
7298
20ce5912
PE
7299 * image.c (gif_load): Rename local to avoid shadowing.
7300
9c4c5f81
PE
7301 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7302 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7303 * alloc.c (make_save_value): Integer argument is now of type
7304 ptrdiff_t, not int.
7305 (mark_object): Use ptrdiff_t, not int.
7306 * lisp.h (pD): New macro.
7307 * print.c (print_object): Use it.
7308
c0c5c8ae
PE
7309 * alloc.c: Use EMACS_INT, not int, to count objects.
7310 (total_conses, total_markers, total_symbols, total_vector_size)
7311 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7312 (total_free_floats, total_floats, total_free_intervals)
7313 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7314 Now EMACS_INT, not int. All uses changed.
7315 (Fgarbage_collect): Compute overall total using a double, so that
7316 integer overflow is less likely to be a problem. Check for overflow
7317 when converting back to an integer.
5a25e253
PE
7318 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7319 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7320 These were 'int' variables that could overflow on 64-bit hosts;
7321 they were never used, so remove them instead of repairing them.
211a0b2a 7322 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7323 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7324 Previously, this ceilinged at INT_MAX, but that doesn't work on
7325 64-bit machines.
e46bb31a 7326 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7327
c78baabf 7328 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7329 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7330 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7331 when a (possibly-narrower) signed value would do just as well.
7332 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7333
c9d624c6
PE
7334 * alloc.c: Catch some string size overflows that we were missing.
7335 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7336 for convenience in STRING_BYTES_MAX.
7337 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7338 The definition here is exact; the one in lisp.h was approximate.
7339 (allocate_string_data): Check for string overflow. This catches
7340 some instances we weren't catching before. Also, it catches
7341 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7342 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7343 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7344
c9d624c6
PE
7345 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7346 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7347 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7348
353032ce
PE
7349 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7350
2bccce07
PE
7351 * alloc.c (Fmake_string): Check for out-of-range init.
7352
0ac30604
SM
73532011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7354
7355 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7356
c195f2de
JD
73572011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7358
7359 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7360 xg_get_default_scrollbar_width.
7361
7362 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7363 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7364 (style_changed_cb): Call update_theme_scrollbar_width and call
7365 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7366 all frames (Bug#8505).
7367 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7368 Call gtk_window_set_resizable if HAVE_GTK3.
7369 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7370 and height if HAVE_GTK3 (Bug#8505).
7371 (scroll_bar_width_for_theme): New variable.
7372 (update_theme_scrollbar_width): New function.
7373 (xg_get_default_scrollbar_width): Move code to
7374 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7375 (xg_initialize): Call update_theme_scrollbar_width.
7376
7377 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7378
7379 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7380
e10ac9f1
MR
73812011-06-12 Martin Rudalics <rudalics@gmx.at>
7382
7383 * frame.c (make_frame): Call other_buffer_safely instead of
7384 other_buffer.
7385
7386 * window.c (temp_output_buffer_show): Call display_buffer with
7387 second argument Vtemp_buffer_show_specifiers and reset latter
7388 immediately after the call.
7389 (Vtemp_buffer_show_specifiers): New variable.
7390 (auto_window_vscroll_p, next_screen_context_lines)
7391 (Vscroll_preserve_screen_position): Remove leading asterisks from
7392 doc-strings.
7393
2d3c217e 73942011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7395
7b7f97e8 7396 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7397 * buffer.c (Qclone_number): Remove for now, as it's unused.
7398 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7399 (record_buffer): Remove unused local.
7400 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7401 (set_frame_buffer_list): Remove; unused.
7402 * frame.h (other_visible_frames): Remove decl.
7403 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7404 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7405 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7406 if HAVE_GPM.
7407 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7408 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7409 Define only if HAVE_GPM.
7410 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7411 (update_hints_inhibit): Remove; never set. All uses removed.
7412 * widgetprv.h (emacsFrameClassRec): Remove decl.
7413 * window.c (delete_deletable_window): Now returns void, since it
7414 wasn't returning anything.
7415 (compare_window_configurations): Remove unused locals.
7416 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7417 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7418 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7419 the same widths as pointers. This follows up on the 2011-05-06 patch.
7420 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7421 * xterm.h: Likewise.
7422 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7423
1384b89e
JB
74242011-06-12 Juanma Barranquero <lekktu@gmail.com>
7425
7426 * makefile.w32-in: Update dependencies.
7427 (LISP_H): Add lib/intprops.h.
7428
1100a63c
CY
74292011-06-11 Chong Yidong <cyd@stupidchicken.com>
7430
7431 * image.c (gif_load): Add animation frame delay to the metadata.
7432 (syms_of_image): Use DEFSYM. New symbol `delay'.
7433
6198ccd0
MR
74342011-06-11 Martin Rudalics <rudalics@gmx.at>
7435
7436 * window.c (delete_deletable_window): Re-add.
7437 (Fset_window_configuration): Rewrite to handle dead buffers and
7438 consequently deletable windows.
7439 (window_tree, Fwindow_tree): Remove. Supply functionality in
7440 window.el.
7441 (compare_window_configurations): Simplify code.
7442
b6e3633c
AS
74432011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7444
1ab0dee5
AS
7445 * image.c (imagemagick_load_image): Fix type mismatch.
7446 (Fimagemagick_types): Likewise.
7447
b6e3633c
AS
7448 * window.h (replace_buffer_in_windows): Declare.
7449
9397e56f
MR
74502011-06-11 Martin Rudalics <rudalics@gmx.at>
7451
7452 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7453 Qclone_number. Remove external declaration of Qdelete_window.
7454 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7455 code.
640c8776
SM
7456 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7457 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7458 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7459 buffer list implementation.
7460 (other_buffer_safely): New function.
7461 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7462 calls to replace_buffer_in_windows and
7463 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7464 if allowed.
7465 (record_buffer): Inhibit quitting and rewrite using quittable
7466 functions. Run Qbuffer_list_update_hook if allowed.
7467 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7468 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7469 Move switch-to-buffer to window.el.
9397e56f
MR
7470 (bury-buffer): Move to window.el.
7471 (Vbuffer_list_update_hook): New variable.
7472
7473 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7474 section.
7475
7476 * window.h (resize_frame_windows): Move up in code.
7477 (Fwindow_frame): Remove EXFUN.
7478 (replace_buffer_in_all_windows): Remove prototype.
7479 (replace_buffer_in_windows_safely): Add prototype.
7480
7481 * window.c: Declare Qdelete_window static again. Move down
7482 declaration of select_count.
7483 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7484 (Fother_window): Move to window.el.
7485 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7486 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7487 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7488 window.el.
7489 (replace_buffer_in_windows): Implement by calling
7490 Qreplace_buffer_in_windows.
7491 (replace_buffer_in_all_windows): Remove with some functionality
7492 moved into replace_buffer_in_windows_safely.
7493 (replace_buffer_in_windows_safely): New function.
7494 (select_window_norecord, select_frame_norecord): Move in front
7495 of run_window_configuration_change_hook. Remove now obsolete
7496 declarations.
640c8776
SM
7497 (Fset_window_buffer): Rewrite doc-string.
7498 Call Qrecord_window_buffer.
9397e56f
MR
7499 (keys_of_window): Move binding for other-window to window.el.
7500
b50691aa
CY
75012011-06-11 Chong Yidong <cyd@stupidchicken.com>
7502
7503 * dispextern.h (struct image): Replace data member, whose int_val
7504 and ptr_val fields were not used by anything, with a single
7505 lisp_val object.
7506
7507 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7508 (gif_clear_image, gif_load, imagemagick_load_image)
7509 (gs_clear_image, gs_load): Callers changed.
7510
3f754b86
PE
75112011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7512
cca69397
PE
7513 * buffer.h: Include <time.h>, for time_t.
7514 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7515
109e28d0
PE
7516 Fix minor problems found by static checking.
7517
60737f02
PE
7518 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7519
4b66faf3
PE
7520 Make identifiers static if they are not used in other modules.
7521 * data.c (Qcompiled_function, Qframe, Qvector):
7522 * image.c (QimageMagick, Qsvg):
7523 * minibuf.c (Qmetadata):
7524 * window.c (resize_window_check, resize_root_window): Now static.
7525 * window.h (resize_window_check, resize_root_window): Remove decls.
7526
109e28d0
PE
7527 * window.c (window_deletion_count, delete_deletable_window):
7528 Remove; unused.
46a4ce9e
PE
7529 (window_body_lines): Now static.
7530 (Fdelete_other_windows_internal): Mark vars as initialized.
7531 Make sure 'resize_failed' is initialized.
7532 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7533 (resize_window_apply): Remove unused local.
7534 * window.h (delete_deletable_window): Remove decl.
7535
109e28d0 7536 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7537 (imagemagick_load_image): Fix pointer signedness problem by changing
7538 last arg from unsigned char * to char *. All uses changed.
7539 Also, fix a local for similar reasons.
7540 Remove unused locals. Remove locals to avoid shadowing.
7541 (fn_rsvg_handle_free): Remove; unused.
7542 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7543 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7544
3f754b86
PE
7545 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7546
2547adb1
CY
75472011-06-10 Chong Yidong <cyd@stupidchicken.com>
7548
7549 * image.c (gif_load): Fix omitted cast error introduced by
7550 2011-06-06 change.
7551
2c8e37d4
MR
75522011-06-10 Martin Rudalics <rudalics@gmx.at>
7553
7554 * window.h (resize_proportionally, orig_total_lines)
7555 (orig_top_line): Remove from window structure.
7556 (set_window_height, set_window_width, change_window_heights)
7557 (Fdelete_window): Remove prototypes.
7558 (resize_frame_windows): Remove duplicate declaration.
7559
440a42e3
EZ
75602011-06-10 Eli Zaretskii <eliz@gnu.org>
7561
7562 * window.h (resize_frame_windows, resize_window_check)
7563 (delete_deletable_window, resize_root_window)
7564 (resize_frame_windows): Declare prototypes.
7565
7566 * window.c (resize_window_apply): Make definition be "static" to
7567 match the prototype.
7568
562dd5e9
MR
75692011-06-10 Martin Rudalics <rudalics@gmx.at>
7570
7571 * window.c: Remove declarations of Qwindow_size_fixed,
7572 window_min_size_1, window_min_size_2, window_min_size,
7573 size_window, window_fixed_size_p, enlarge_window, delete_window.
7574 Remove static from declaration of Qdelete_window, it's
7575 temporarily needed by Fbury_buffer.
7576 (replace_window): Don't assign orig_top_line and
7577 orig_total_lines.
7578 (Fdelete_window, delete_window): Remove. Window deletion is
7579 handled by window.el.
640c8776
SM
7580 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7581 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7582 (Fdelete_other_windows): Remove. Deleting other windows is
7583 handled by window.el.
7584 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7585 handled in window.el.
7586 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7587 Window minimum sizes are handled in window.el.
7588 (shrink_windows, size_window, set_window_height)
7589 (set_window_width, change_window_heights, window_height)
7590 (window_width, CURBEG, CURSIZE, enlarge_window)
7591 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7592 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7593 handled in window.el.
7594 (make_dummy_parent): Rename to make_parent_window and give it a
7595 second argument horflag.
7596 (make_window): Don't set resize_proportionally any more.
7597 (Fsplit_window): Remove. Windows are split in window.el.
7598 (save_restore_action, save_restore_orig_size)
7599 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7600 Resize mini windows in window.el.
7601 (grow_mini_window, shrink_mini_window): Implement by calling
7602 Qresize_root_window_vertically, resize_window_check and
7603 resize_window_apply.
640c8776
SM
7604 (saved_window, Fset_window_configuration, save_window_save):
7605 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7606 resize_proportionally.
7607 (window_min_height, window_min_width): Move to window.el.
7608 (keys_of_window): Move bindings for delete-other-windows,
7609 split-window, delete-window and enlarge-window to window.el.
7610
7611 * buffer.c: Temporarily extern Qdelete_window.
7612 (Fbury_buffer): Temporarily call Qdelete_window instead of
7613 Fdelete_window (Fbury_buffer will move to window.el soon).
7614
7615 * frame.c (set_menu_bar_lines_1): Remove code handling
7616 orig_top_line and orig_total_lines.
7617
7618 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7619 set_window_height but set heights directly.
7620 (change_frame_size_1): Use resize_frame_windows.
7621
7622 * xdisp.c (init_xdisp): Don't use set_window_height but set
7623 heights directly.
7624
640c8776
SM
7625 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7626 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7627 run_window_configuration_change_hook.
7628
7629 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7630 instead of change_window_heights and run
7631 run_window_configuration_change_hook.
7632
1a13852e
MR
76332011-06-09 Martin Rudalics <rudalics@gmx.at>
7634
7635 * window.c (replace_window): Rename second argument REPLACEMENT to
7636 NEW. New third argument SETFLAG. Rewrite.
7637 (delete_window, make_dummy_parent): Call replace_window with
7638 third argument 1.
7639 (window_list_1): Move down in code.
7640 (run_window_configuration_change_hook): Move set_buffer part
7641 before select_frame_norecord part in order to unwind correctly.
7642 Rename count1 to count.
7643 (recombine_windows, delete_deletable_window, resize_root_window)
7644 (Fdelete_other_windows_internal)
7645 (Frun_window_configuration_change_hook, make_parent_window)
7646 (resize_window_check, resize_window_apply, Fresize_window_apply)
7647 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7648 (Fdelete_window_internal, Fresize_mini_window_internal):
7649 New functions.
1a13852e
MR
7650 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7651
f3d1777e
MR
76522011-06-08 Martin Rudalics <rudalics@gmx.at>
7653
496e208e
MR
7654 * window.h (window): Add some new members to window structure -
7655 normal_lines, normal_cols, new_total, new_normal, clone_number,
7656 splits, nest, prev_buffers, next_buffers.
7657 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7658 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7659
f3d1777e
MR
7660 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7661 Remove.
496e208e
MR
7662 (make_dummy_parent): Set new members of windows structure.
7663 (make_window): Move down in code. Handle new members of window
7664 structure.
7665 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7666 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7667 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7668 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7669 (Fset_window_next_buffers, Fset_window_clone_number):
7670 New functions.
496e208e
MR
7671 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7672 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7673 Doc-string fixes.
7674 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7675 Argument WINDOW can be now internal window too.
7676 (Fwindow_use_time): Move up in code.
7677 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7678 Rewrite doc-string.
7679 (Fset_window_configuration, saved_window)
7680 (Fcurrent_window_configuration, save_window_save): Handle new
7681 members of window structure.
b9e809c2
MR
7682 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7683 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7684 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7685 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7686 Qget_mru_window, Qresize_root_window,
7687 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7688 Qauto_buffer_name; staticpro them.
f3d1777e 7689
abde8f8c
MR
76902011-06-07 Martin Rudalics <rudalics@gmx.at>
7691
7692 * window.c (Fwindow_total_size, Fwindow_left_column)
7693 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7694 (Fwindow_list_1): New functions.
7695 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7696 (Fwindow_width, Fscroll_left, Fscroll_right):
7697 Use window_body_cols instead of window_box_text_cols.
7698 (delete_window, Fset_window_configuration):
7699 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7700 (delete_all_subwindows): Take a window as argument and not a
7701 structure. Rewrite.
190b47e6
MR
7702 (window_loop): Remove handling of GET_LRU_WINDOW and
7703 GET_LARGEST_WINDOW.
7704 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7705
7706 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7707 window_box_text_cols. delete_all_subwindows now takes a
7708 Lisp_Object as argument.
abde8f8c 7709
640c8776
SM
7710 * indent.c (compute_motion, Fcompute_motion):
7711 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7712
fa8a67e6
MR
7713 * frame.c (delete_frame): Call delete_all_subwindows with root
7714 window as argument.
7715
a54e3482
DC
77162011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7717
7718 * fns.c (Fputhash): Document return value.
7719
60002bf5
CY
77202011-06-06 Chong Yidong <cyd@stupidchicken.com>
7721
7722 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7723
0c671da6 77242011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7725
b862a52a 7726 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7727
be44ca6c
PE
7728 Check for overflow when converting integer to cons and back.
7729 * charset.c (Fdefine_charset_internal, Fdecode_char):
7730 Use cons_to_unsigned to catch overflow.
7731 (Fencode_char): Use INTEGER_TO_CONS.
7732 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7733 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7734 * data.c (long_to_cons, cons_to_long): Remove.
7735 (cons_to_unsigned, cons_to_signed): New functions.
7736 These signal an error for invalid or out-of-range values.
7737 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7738 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7739 * font.c (Ffont_variation_glyphs):
7740 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7741 * lisp.h: Include <intprops.h>.
7742 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7743 (cons_to_signed, cons_to_unsigned): New decls.
7744 (long_to_cons, cons_to_long): Remove decls.
7745 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7746 (Fprimitive_undo): Use CONS_TO_INTEGER.
7747 * xfns.c (Fx_window_property): Likewise.
7748 * xselect.c: Include <limits.h>.
7749 (x_own_selection, selection_data_to_lisp_data):
7750 Use INTEGER_TO_CONS.
7751 (x_handle_selection_request, x_handle_selection_clear)
7752 (x_get_foreign_selection, Fx_disown_selection_internal)
7753 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7754 (lisp_data_to_selection_data): Use cons_to_unsigned.
7755 (x_fill_property_data): Use cons_to_signed.
7756 Report values out of range.
7757
d1f3d2af
PE
7758 Check for buffer and string overflow more precisely.
7759 * buffer.h (BUF_BYTES_MAX): New macro.
7760 * lisp.h (STRING_BYTES_MAX): New macro.
7761 * alloc.c (Fmake_string):
7762 * character.c (string_escape_byte8):
7763 * coding.c (coding_alloc_by_realloc):
7764 * doprnt.c (doprnt):
7765 * editfns.c (Fformat):
7766 * eval.c (verror):
7767 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7768 since they may not be the same number.
7769 * editfns.c (Finsert_char):
7770 * fileio.c (Finsert_file_contents):
7771 Likewise for BUF_BYTES_MAX.
7772
dd52fcea
PE
7773 * image.c: Use ptrdiff_t, not int, for sizes.
7774 (slurp_file): Switch from int to ptrdiff_t.
7775 All uses changed.
7776 (slurp_file): Check that file size fits in both size_t (for
7777 malloc) and ptrdiff_t (for sanity and safety).
7778
7f9bbdbb
PE
7779 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7780 if b->modtime has its maximal value.
7781
dfe18f82
PE
7782 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7783
84acfcf0
PE
7784 Don't assume time_t can fit into int.
7785 * buffer.h (struct buffer.modtime): Now time_t, not int.
7786 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7787 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7788
ccd9a01a
PE
7789 Minor fixes for signed vs unsigned integers.
7790 * character.h (MAYBE_UNIFY_CHAR):
7791 * charset.c (maybe_unify_char):
7792 * keyboard.c (read_char, reorder_modifiers):
7793 XINT -> XFASTINT, since the integer must be nonnegative.
7794 * ftfont.c (ftfont_spec_pattern):
7795 * keymap.c (access_keymap, silly_event_symbol_error):
7796 XUINT -> XFASTINT, since the integer must be nonnegative.
7797 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7798 since it makes no difference and we prefer signed.
7799 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7800 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7801 nonnegative.
7802
d6d100dd
SM
78032011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7804
7805 * window.h (Fwindow_frame): Declare.
7806
2b6148e4
PE
78072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7808
7809 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7810 (SPARE_MEMORY): Always define.
7811 (LARGE_REQUEST): Remove.
7812 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7813
f230ecc9
MR
78142011-06-06 Martin Rudalics <rudalics@gmx.at>
7815
727e958e
MR
7816 * lisp.h: Move EXFUNS for Fframe_root_window,
7817 Fframe_first_window and Fset_frame_selected_window to window.h.
7818
7819 * window.h: Move EXFUNS for Fframe_root_window,
7820 Fframe_first_window and Fset_frame_selected_window here from
7821 lisp.h.
7822
7823 * frame.c (Fwindow_frame, Fframe_first_window)
7824 (Fframe_root_window, Fframe_selected_window)
7825 (Fset_frame_selected_window): Move to window.c.
7826 (Factive_minibuffer_window): Move to minibuf.c.
7827 (Fother_visible_frames_p): New function.
7828
7829 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7830
f230ecc9
MR
7831 * window.c (decode_window, decode_any_window): Move up in code.
7832 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7833 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7834 (Fwindow_buffer): Move up and rewrite doc-string.
7835 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7836 (Fwindow_prev): New functions.
727e958e
MR
7837 (Fwindow_frame): Move here from frame.c. Accept any window as
7838 argument.
7839 (Fframe_root_window, Fframe_first_window)
7840 (Fframe_selected_window): Move here from frame.c. Accept frame
7841 or arbitrary window as argument. Update doc-strings.
7842 (Fminibuffer_window): Move up in code.
7843 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7844 (Fset_frame_selected_window): Move here from frame.c.
7845 Marginal rewrite.
727e958e
MR
7846 (Fselected_window, select_window, Fselect_window): Move up in
7847 code. Minor doc-string fixes.
f230ecc9 7848
4d09bcf6
PE
78492011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7850
7851 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7852 Do not assume that spare memory exists; that assumption is valid
7853 only if SYSTEM_MALLOC.
7854 (LARGE_REQUEST): New macro, so that the issue of large requests
7855 is separated from the issue of spare memory.
7856
810928a2
AS
78572011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7858
172418ad
AS
7859 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7860 format. (Bug#8806)
7861
43f862f7
AS
7862 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7863
810928a2
AS
7864 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7865 before statements.
7866
a059fe24
JD
78672011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7868
7869 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7870
7871 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7872
7873 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7874 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7875
989bf368
JB
78762011-06-05 Juanma Barranquero <lekktu@gmail.com>
7877
7878 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7879
4b80f674
CY
78802011-06-04 Chong Yidong <cyd@stupidchicken.com>
7881
7882 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7883 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7884 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7885 New error handlers.
4b80f674
CY
7886 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7887 Obey Vx_select_enable_clipboard_manager. Catch errors in
7888 x_clipboard_manager_save (Bug#8779).
7889 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7890 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7891
99a33b77 78922011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7893
7894 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7895
99a33b77 78962011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7897
7898 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7899 in the current matrix if keep_current_p is non-zero.
7900
8264569d
EZ
79012011-06-04 Eli Zaretskii <eliz@gnu.org>
7902
7903 * bidi.c (bidi_level_of_next_char): Fix last change.
7904
57f97249
EZ
79052011-06-03 Eli Zaretskii <eliz@gnu.org>
7906
fec2107c 7907 Support bidi reordering of text covered by display properties.
57f97249 7908
fec2107c
EZ
7909 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7910 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7911 (bidi_cache_search, bidi_cache_iterator_state)
7912 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7913 (bidi_level_of_next_char, bidi_move_to_visually_next):
7914 Support character positions inside a run of characters covered by a
fec2107c
EZ
7915 display string.
7916 (bidi_paragraph_init, bidi_resolve_explicit_1)
7917 (bidi_level_of_next_char): Call bidi_fetch_char and
7918 bidi_fetch_char_advance instead of FETCH_CHAR and
7919 FETCH_CHAR_ADVANCE.
7920 (bidi_init_it): Initialize new members.
7921 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7922 definitions.
7923 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7924 instead of using explicit *_CHAR codes.
d6d100dd
SM
7925 (bidi_resolve_explicit, bidi_resolve_weak):
7926 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7927 bidirectional text is supported only in multibyte buffers.
7928 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7929 it to initialize the frame_window_p member of struct bidi_it.
7930 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7931 (bidi_resolve_explicit, bidi_resolve_weak)
7932 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7933 bidi_it->nchars is non-positive.
7934 (bidi_level_of_next_char): Don't try to lookup the cache for the
7935 next/previous character if nothing is cached there yet, or if we
7936 were just reseat()'ed to a new position.
c40e2fb2 7937
0e14fe90
EZ
7938 * xdisp.c (set_cursor_from_row): Set start and stop points
7939 according to the row's direction when priming the loop that looks
7940 for the glyph on which to display cursor.
7941 (single_display_spec_intangible_p): Function deleted.
7942 (display_prop_intangible_p): Reimplement to call
7943 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
7944 Accept 3 additional arguments needed by handle_display_spec.
7945 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
7946 values: lists, `(when COND...)' forms, etc.
7947 (single_display_spec_string_p): Support property values that are
7948 lists with the argument STRING its top-level element.
7949 (display_prop_string_p): Fix the condition for processing a
7950 property that is a list to be consistent with handle_display_spec.
fec2107c 7951 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
7952 last portion of handle_display_prop.
7953 (compute_display_string_pos): Accept additional argument
7954 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7955 value of a `display' property is a "replacing spec".
7956 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7957 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7958 the display property, but just return a value indicating whether
7959 the display property will replace the characters it covers.
7960 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7961 frame_window_p members of struct bidi_it.
d6d100dd
SM
7962 (compute_display_string_pos, compute_display_string_end):
7963 New functions.
fec2107c
EZ
7964 (push_it): Accept second argument POSITION, where pop_it should
7965 jump to continue iteration.
7966 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 7967
fec2107c
EZ
7968 * keyboard.c (adjust_point_for_property): Adjust the call to
7969 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
7970
7971 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
7972 (bidi_init_it): Update prototypes.
7973 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
7974 (compute_display_string_pos, compute_display_string_end):
7975 Declare prototypes.
fec2107c
EZ
7976 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7977 EMACS_INT.
fc6f18ce 7978
40087514 79792011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 7980
57f53182
PE
7981 Malloc failure behavior now depends on size of allocation.
7982 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7983 * lisp.h: Change signatures accordingly.
7984 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7985 All callers changed. (Bug#8762)
7986
7987 * gnutls.c: Use Emacs's memory allocators.
7988 Without this change, the gnutls library would invoke malloc etc.
7989 directly, which causes problems on non-SYNC_INPUT hosts, and which
7990 runs afoul of improving memory_full behavior. (Bug#8761)
7991 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7992 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7993 xfree instead of the default malloc, realloc, free.
7994 (Fgnutls_boot): No need to check for memory allocation failure,
7995 since xmalloc does that for us.
7996
ac32cd99 7997 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
7998 * category.c (hash_get_category_set):
7999 * ccl.c (ccl_driver):
8000 * charset.c (Fdefine_charset_internal):
8001 * charset.h (struct charset.hash_index):
8002 * composite.c (get_composition_id, gstring_lookup_cache)
8003 (composition_gstring_put_cache):
8004 * composite.h (struct composition.hash_index):
8005 * dispextern.h (struct image.hash):
8006 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8007 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8008 (hashfn_equal, hashfn_user_defined, make_hash_table)
8009 (maybe_resize_hash_table, hash_lookup, hash_put)
8010 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8011 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8012 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8013 * image.c (make_image, search_image_cache, lookup_image)
8014 (xpm_put_color_table_h):
8015 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8016 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8017 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8018 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8019 * alloc.c (allocate_vectorlike):
8020 Check for overflow in vector size calculations.
8021 * ccl.c (ccl_driver):
8022 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8023 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8024 need to be updated by these changes.
40087514
PE
8025 * fns.c (make_hash_table, maybe_resize_hash_table):
8026 Check for integer overflow with large hash tables.
0de4bb68
PE
8027 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8028 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8029 (SXHASH_REDUCE): New macro.
8030 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8031 Use it instead of discarding useful hash info with large hash values.
8032 (sxhash_float): New function.
8033 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8034 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8035 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8036 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8037 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8038 Adjust signatures to match updated version of code.
8039 (consing_since_gc): Now EMACS_INT, since a single hash table can
8040 use more than INT_MAX bytes.
8041
698d32e2
DN
80422011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8043
8044 Make it possible to build with GCC-4.6+ -O2 -flto.
8045
8046 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8047
fd6fa53f
SM
80482011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8049
8050 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8051 Call minibuffer-inactive-mode.
8052
864db017
JB
80532011-05-31 Juanma Barranquero <lekktu@gmail.com>
8054
8055 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8056 Update dependencies.
8057
2ad0baf4
DN
80582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8059
8060 * data.c (init_data): Remove code for UTS, this system is not
8061 supported anymore.
8062
4fcc2638
DN
80632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8064
8065 Don't force ./temacs to start in terminal mode.
8066
8067 * frame.c (make_initial_frame): Initialize faces in all cases, not
8068 only when CANNOT_DUMP is defined.
8069 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8070
c56e0fd5
DN
80712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8072
8073 * dispnew.c (add_window_display_history): Use const for the string
8074 pointer. Remove declaration, not needed.
8075
333d54da 80762011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8077
55d4c1b2 8078 Use 'inline', not 'INLINE'.
333d54da 8079 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8080 * alloc.c, fontset.c (INLINE): Remove.
8081 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8082 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8083 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8084 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8085 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8086
738db178
DN
80872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8088
8089 Make it possible to run ./temacs.
8090
8091 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8092 syms_of_callproc does the same thing. Remove test for
8093 "initialized", do it in the caller.
8094 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8095
620c53a6
SM
80962011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8097
8098 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8099 (read_minibuf): Use get_minibuffer.
8100 (syms_of_minibuf): Use DEFSYM.
8101 (Qmetadata): New var.
8102 * data.c (Qbuffer): Don't make it static.
8103 (syms_of_data): Use DEFSYM.
8104
e003a292
PE
81052011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8106
8107 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8108 (CCL_CODE_MIN): New macro.
8109
ed008a6d
PE
81102011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8111
3687c2ef
PE
8112 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8113
ed008a6d
PE
8114 * eval.c (Qdebug): Now static.
8115 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8116 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8117 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8118
d66c4c7c
CY
81192011-05-29 Chong Yidong <cyd@stupidchicken.com>
8120
8121 * image.c: Various fixes to ImageMagick code comments.
8122 (Fimagemagick_types): Doc fix.
8123
5fbc2025
PE
81242011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8125
0196f88a
PE
8126 Minor fixes prompted by GCC 4.6.0 warnings.
8127
8128 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8129
5fbc2025
PE
8130 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8131 (x_clipboard_manager_save_all): Move extern decl to ...
8132 * xterm.h: ... here, so that it can be checked for consistency.
8133
1dd3c2d9
CY
81342011-05-29 Chong Yidong <cyd@stupidchicken.com>
8135
8136 * xselect.c (x_clipboard_manager_save_frame)
8137 (x_clipboard_manager_save_all): New functions.
8138 (Fx_clipboard_manager_save): Lisp function deleted.
8139
8140 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8141 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8142
8143 * xterm.h: Update prototype.
8144
5ba6571d
WX
81452011-05-28 William Xu <william.xwl@gmail.com>
8146
8147 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8148 exiting (Bug#8239).
8149
3eaff834
JM
81502011-05-28 Jim Meyering <meyering@redhat.com>
8151
e1900994 8152 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8153 * fns.c (to_uchar): Define.
8154 (crypto_hash_function): Use it to convert some newly-signed
8155 variables to unsigned, to avoid sign-extension bugs. For example,
8156 without this change, (md5 "truc") would evaluate to
8157 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8158 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8159 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8160
0f6990a7
PE
81612011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8162
8163 Integer overflow fixes.
c8a9ca5a 8164
08686060
PE
8165 * dbusbind.c: Serial number integer overflow fixes.
8166 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8167 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8168 to hold a serial number that is too large for a fixnum.
8169 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8170 Check for serial numbers out of range. Decode any serial number
59568bf0 8171 that was so large that it became a float. (Bug#8722)
08686060 8172
2d1fc3c7
PE
8173 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8174 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8175 Use XFASTINT rather than XUINT when numbers are nonnegative.
8176 (xd_append_arg, Fdbus_method_return_internal):
8177 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8178 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8179 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8180 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8181 (Bug#8722)
2d1fc3c7 8182
c8a9ca5a
PE
8183 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8184
519e1d69
PE
8185 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8186
6df6ae42 8187 ccl: Add integer overflow checks.
30569699
PE
8188 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8189 (IN_INT_RANGE): New macros.
8190 (ccl_driver): Use them to check for integer overflow when
8191 decoding a CCL program. Many of the new checks are whether XINT (x)
8192 fits in int; it doesn't always, on 64-bit hosts. The new version
8193 doesn't catch all possible integer overflows, but it's an
847044ea 8194 improvement. (Bug#8719)
30569699 8195
c11285dc
PE
8196 * alloc.c (make_event_array): Use XINT, not XUINT.
8197 There's no need for unsigned here.
8198
fdccd48e
PE
8199 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8200 This follows up to the 2011-05-06 change that substituted uintptr_t
8201 for EMACS_INT. This case wasn't caught back then.
8202
37910ab2
PE
8203 Rework Fformat to avoid integer overflow issues.
8204 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8205 now (part of C89). Include <verify.h>.
8206 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8207 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8208 (Fformat): Avoid the prepass trying to compute sizes; it was only
8209 approximate and thus did not catch overflow reliably. Instead, walk
8210 through the format just once, formatting and computing sizes as we go,
8211 checking for integer overflow at every step, and allocating a larger
8212 buffer as needed. Keep track separately whether the format is
8213 multibyte. Keep only the most-recently calculated precision, rather
8214 than them all. Record whether each argument has been converted to
8215 string. Use EMACS_INT, not int, for byte and char and arg counts.
8216 Support field widths and precisions larger than INT_MAX. Avoid
8217 sprintf's undefined behavior with conversion specifications such as %#d
8218 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8219 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8220 formatting out-of-range floating point numbers with int
9173deec 8221 formats. (Bug#8668)
37910ab2 8222
2e6578fb
PE
8223 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8224
0ae6bdee
PE
8225 * data.c: Avoid integer truncation in expressions involving floats.
8226 * data.c: Include <intprops.h>.
8227 (arith_driver): When there's an integer overflow in an expression
8228 involving floating point, convert the integers to floating point
8229 so that the resulting value does not suffer from catastrophic
8230 integer truncation. For example, on a 64-bit host (* 4
8231 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8232 Do not rely on undefined behavior after integer overflow.
8233
de883a70
PE
8234 merge count_size_as_multibyte, parse_str_to_multibyte
8235 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8236 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8237 Check for integer overflow.
8238 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8239 since it's now a duplicate of the other. This is more of
8240 a character than a buffer op, so better that it's in character.c.
8241 * fns.c, print.c: Adjust to above changes.
8242
2ff916cb
PE
82432011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8244
8245 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8246
f1b54466
PE
82472011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8248
fb1ac845
PE
8249 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8250 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8251 (x_clipboard_manager_save): Now static.
8252 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8253
f1b54466
PE
8254 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8255 (crypto_hash_function): Now static.
8256 Fix pointer signedness problems. Avoid unnecessary initializations.
8257
a9f737ee
CY
82582011-05-27 Chong Yidong <cyd@stupidchicken.com>
8259
8260 * termhooks.h (Vselection_alist): Make it terminal-local.
8261
8262 * terminal.c (create_terminal): Initialize it.
8263
8264 * xselect.c: Support for clipboard managers.
8265 (Vselection_alist): Move to termhooks.h as terminal-local var.
8266 (LOCAL_SELECTION): New macro.
8267 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8268 (symbol_to_x_atom): Remove gratuitous arg.
8269 (x_handle_selection_request, lisp_data_to_selection_data)
8270 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8271 (x_own_selection, x_get_local_selection, x_convert_selection):
8272 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8273 (some_frame_on_display): Delete unused function.
8274 (Fx_own_selection_internal, Fx_get_selection_internal)
8275 (Fx_disown_selection_internal, Fx_selection_owner_p)
8276 (Fx_selection_exists_p): New optional frame arg.
8277 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8278 (x_handle_selection_clear): Don't treat other terminals with the
8279 same keyboard specially. Use the terminal-local Vselection_alist.
8280 (x_clear_frame_selections): Use Frun_hook_with_args.
8281
8282 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8283
8284 * xterm.h: Add support for those atoms.
8285
e067f0c1
CY
82862011-05-26 Chong Yidong <cyd@stupidchicken.com>
8287
8288 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8289 (converted_selections, conversion_fail_tag): New global variables.
8290 (x_selection_request_lisp_error): Free the above.
8291 (x_get_local_selection): Remove unnecessary code.
8292 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8293 of converted selections stored in converted_selections.
8294 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8295 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8296 (x_convert_selection): New function.
8297 (x_handle_selection_event): Simplify.
8298 (x_get_foreign_selection): Don't ignore incoming requests while
8299 waiting for an answer; this will fail when we implement
8300 SAVE_TARGETS, and seems unnecessary anyway.
8301 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8302 (Vx_sent_selection_functions): Doc fix.
8303
0f4aebc0
LL
83042011-05-26 Leo Liu <sdl.web@gmail.com>
8305
8306 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8307
e61124cd
YM
83082011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8309
8310 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8311
8312 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8313 for fringe update if it has periodic bitmap.
ac389d0c 8314 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8315 and fringe_bitmap_periodic_p.
8316
8317 * fringe.c (get_fringe_bitmap_data): New function.
8318 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8319 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8320 row. Mark glyph row for fringe update if periodicity changed.
8321
8322 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8323 for fringe update unless it has periodic bitmap.
8324
f16d9837
KH
83252011-05-25 Kenichi Handa <handa@m17n.org>
8326
8327 * xdisp.c (get_next_display_element): Set correct it->face_id for
8328 a static composition.
8329
e1b90ef6
LL
83302011-05-24 Leo Liu <sdl.web@gmail.com>
8331
8332 * deps.mk (fns.o):
8333 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8334
8335 * fns.c (crypto_hash_function, Fsha1): New function.
8336 (Fmd5): Use crypto_hash_function.
8337 (syms_of_fns): Add Ssha1.
8338
7400048f
PE
83392011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8340
8341 * gnutls.c: Remove unused macros.
8342 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8343 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8344 Remove macros that are defined and never used.
8345 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8346
abb71cf4
CY
83472011-05-22 Chong Yidong <cyd@stupidchicken.com>
8348
8349 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8350 (Fx_get_selection_internal): Minor cleanup.
8351 (Fx_own_selection_internal): Rename arguments for consistency with
8352 select.el.
8353
6307db39
PE
83542011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8355
8356 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8357
f3d4e0a4
CY
83582011-05-22 Chong Yidong <cyd@stupidchicken.com>
8359
8360 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8361
4d8ade89
YM
83622011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8363
8364 * dispnew.c (scrolling_window): Don't exclude the case that the
8365 last enabled row in the desired matrix touches the bottom boundary.
8366
32078c8d
GM
83672011-05-21 Glenn Morris <rgm@gnu.org>
8368
8369 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8370 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8371 and add some more files.
32078c8d 8372
7285dc67
EZ
83732011-05-20 Eli Zaretskii <eliz@gnu.org>
8374
8375 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8376 report_file_error introduced by the change from 2011-05-07.
8377
89d1bd22
PE
83782011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8379
8380 * systime.h (Time): Define only if emacs is defined.
8381 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8382 where the include path doesn't have X11/X.h by default. See
8383 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8384
cd394be1 83852011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8386
8387 * composite.c (find_automatic_composition): Fix previous change.
8388
b9704ad9
GM
83892011-05-20 Glenn Morris <rgm@gnu.org>
8390
8391 * lisp.mk: New file, split from Makefile.in.
8392 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8393 (shortlisp): Remove.
8394 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8395
4a720484
GM
83962011-05-19 Glenn Morris <rgm@gnu.org>
8397
8398 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8399 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8400 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8401 (lisp): Set the order to that of loadup.el.
8402 (shortlisp): Make it a copy of $lisp.
8403 (SOME_MACHINE_LISP): Remove.
8404 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8405 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8406
a28d4396
KH
84072011-05-18 Kenichi Handa <handa@m17n.org>
8408
8409 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8410 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8411 (find_automatic_composition): Mostly rewrite for efficiency.
8412
a2b1fa8e
JB
84132011-05-18 Juanma Barranquero <lekktu@gmail.com>
8414
8415 * makefile.w32-in: Update dependencies.
8416
8e1f5610
CS
84172011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8418
8419 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8420 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8421
7025ee00 84222011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8423
cdfa6eab
PE
8424 Fix some integer overflow issues, such as string length overflow.
8425
06d6db33
PE
8426 * insdel.c (count_size_as_multibyte): Check for string overflow.
8427
2b4560a8
PE
8428 * character.c (lisp_string_width): Check for string overflow.
8429 Use EMACS_INT, not int, for string indexes and lengths; in
8430 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8431 the resulting string length overflows an EMACS_INT; instead,
8432 report a string overflow if no precision given. When checking for
8433 precision exhaustion, use a check that cannot possibly have
8434 integer overflow. (Bug#8675)
8435 * character.h (lisp_string_width): Adjust to new signature.
8436
cb93f9be
PE
8437 * alloc.c (string_overflow): New function.
8438 (Fmake_string): Use it. This doesn't change behavior, but saves
8439 a few bytes and will simplify future changes.
8440 * character.c (string_escape_byte8): Likewise.
8441 * lisp.h (string_overflow): New decl.
8442
1a1f3366
PE
8443 Fixups, following up to the user-interface timestamp change.
8444 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8445 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8446 * msdos.c (mouse_get_pos): Likewise.
8447 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8448 * w32gui.h (Time): Define by including "systime.h" rather than by
8449 declaring it ourselves. (Bug#8664)
8450
d4e3e4d3
PE
8451 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8452 * image.c (clear_image_cache): Likewise.
8453
f6a24d19
PE
8454 * term.c (term_mouse_position): Don't assume time_t wraparound.
8455
08dc5ae6
PE
8456 Be more systematic about user-interface timestamps.
8457 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8458 and sometimes 'EMACS_UINT', to represent these timestamps.
8459 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8460 This makes the code easier to follow, and makes it easier to catch
8461 integer overflow bugs such as Bug#8664.
8462 * frame.c (Fmouse_position, Fmouse_pixel_position):
8463 Use Time, not unsigned long, for user-interface timestamps.
8464 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8465 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8466 * keyboard.h (last_event_timestamp): Likewise.
8467 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8468 * menu.h (xmenu_show): Likewise.
8469 * term.c (term_mouse_position): Likewise.
8470 * termhooks.h (struct input_event.timestamp): Likewise.
8471 (struct terminal.mouse_position_hook): Likewise.
8472 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8473 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8474 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8475 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8476 what it was before.
8477 * menu.h, termhooks.h: Include "systime.h", for Time.
8478
8e55734a
PE
8479 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8480 Don't assume that the difference between two unsigned long values
8481 can fit into an integer. At this point, we know button_down_time
8482 <= event->timestamp, so the difference must be nonnegative, so
8483 there's no need to cast the result if double-click-time is
8484 nonnegative, as it should be; check that it's nonnegative, just in
8485 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8486 apart (about 25 days). (Bug#8664)
8e55734a 8487
841f1b75 8488 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8489 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8490
3e26f69c
PE
8491 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8492 that always fit in int. Use a sentinel instead of a counter, to
8493 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8494 * frame.h (struct frame): Use int for menu_bar_items_used
8495 instead of EMACS_INT, since it always fits in int.
3e26f69c 8496
5cc152c0
PE
8497 * menu.c (grow_menu_items): Check for int overflow.
8498
d89eb65e
PE
8499 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8500
5235bd3e
PE
8501 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8502 Before, the code was not consistent. These values cannot exceed
8503 2**31 - 1 so there's no need to make them unsigned.
8504 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8505 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8506 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8507 as modifiers.
8508 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8509
bc827e23
PE
8510 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8511 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8512 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8513 presumably because the widths might not match.
8514
78eb494e
PE
8515 * window.c (size_window): Avoid needless test at loop start.
8516
04f2d78b
CB
85172011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8518
8519 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8520
d2fc7e3d 85212011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8522
8523 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8524
d2fc7e3d 85252011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8526
8527 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8528 `width' to `bar_area_x' and `bar_area_width', respectively.
8529 (x_scroll_run): Take account of fringe background extension.
8530
04f2d78b
CB
8531 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8532 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8533 `bar_area_width', respectively.
8534 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8535 background extension.
8536
79b70037
GM
85372011-05-10 Jim Meyering <meyering@redhat.com>
8538
8539 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8540
2f142cc5
JB
85412011-05-10 Juanma Barranquero <lekktu@gmail.com>
8542
8543 * image.c (Finit_image_library): Return t for built-in image types,
8544 like pbm and xbm. (Bug#8640)
8545
57679c86
AS
85462011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8547
8548 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8549
888c9e86
EZ
85502011-05-07 Eli Zaretskii <eliz@gnu.org>
8551
b0512a1d
EZ
8552 * w32console.c (Fset_screen_color): Doc fix.
8553 (Fget_screen_color): New function.
8554 (syms_of_ntterm): Defsubr it.
8555
7285dc67
EZ
8556 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8557 unlink the temporary file if Fcall_process didn't create it in the
8558 first place.
8559 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8560 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8561 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8562 cue to call_process_cleanup not to close that handle.
8563
4d3fcc8e
BK
85642011-05-07 Ben Key <bkey76@gmail.com>
8565
8566 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8567 one of two shell specific rules, either bootstrap-temacs-CMD or
8568 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8569 to the previous implementation of the bootstrap-temacs rule.
8570 The bootstrap-temacs-CMD rule is similar to the previous
8571 implementation of the bootstrap-temacs rule except that it
8572 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8573 variable.
8574
8575 These changes, along with some changes to nt/configure.bat,
8576 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8577 earlier fix to add support for --cflags and --ldflags options
8578 that include quotes so that it works whether make uses cmd or
8579 sh as the shell.
8580
b4289b64
MA
85812011-05-06 Michael Albinus <michael.albinus@gmx.de>
8582
8583 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8584 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8585 is a constant.
8586 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8587 a string. Handle both cases.
8588 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8589 (Fdbus_register_method): Use Qinvalid_function.
8590
af4c0e28
JB
85912011-05-06 Juanma Barranquero <lekktu@gmail.com>
8592
8593 * makefile.w32-in: Update dependencies.
8594 (LISP_H): Add inttypes.h and stdin.h.
8595 (PROCESS_H): Add unistd.h.
8596
c51453d9
EZ
85972011-05-06 Eli Zaretskii <eliz@gnu.org>
8598
8599 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8600 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8601
8ff0ac3c 86022011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8603
4c4b566b
PE
8604 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8605
aab2b9b5
PE
8606 * term.c (vfatal): Remove stray call to va_end.
8607 It's not needed and the C Standard doesn't allow it here anyway.
8608
c378da0b
PE
8609 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8610 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8611
288b08c7
PE
8612 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8613 bytes.
8614
e3601888
PE
8615 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8616
db6c0e74
PE
8617 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8618
dd5963ea
PE
8619 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8620
88c9450f
PE
8621 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8622
2f9442b8
PE
8623 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8624
c032b5f8
PE
8625 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8626 * charset.c (Fdefine_charset_internal): Don't initialize
8627 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8628 32-bit int (Bug#8600).
a108c10b
PE
8629
8630 * lread.c (read_integer): Be more consistent with string-to-number.
8631 Use string_to_number to do the actual conversion; this avoids
8632 rounding errors and fixes some other screwups. Without this fix,
8633 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8634 (digit_to_number): Move earlier, for benefit of read_integer.
8635 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8636 not a digit in any supported base. (Bug#8602)
a108c10b 8637
ad5f9eea
PE
8638 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8639
aec1708a
PE
8640 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8641 to match comment at start of function. This also removes a
8642 GCC warning about overflow in a 32+64-bit port.
8643
47be4ab5
PE
8644 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8645
371cac43
PE
8646 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8647 Reported by Stefan Monnier in
8648 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8649 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8650 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8651
d01a7826
PE
8652 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8653 (EMACS_UINTPTR): Likewise, with uintptr_t.
8654
7fd47d5c
PE
8655 * lisp.h: Prefer 64-bit EMACS_INT if available.
8656 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8657 on 32-bit hosts that have 64-bit int, so that they can access
8658 large files.
122b0c86
PE
8659 However, temporarily disable this change unless the temporary
8660 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8661
8727937b
PE
8662 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8663
8ac068ac
PE
8664 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8665 This removes an assumption that EMACS_INT and long are the same
8666 width as pointers. The assumption is true for Emacs porting targets
8667 now, but we want to make other targets possible.
8668 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8669 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8670 In the rest of the code, change types of integers that hold casted
8671 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8672 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8673 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8674 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8675 No need to cast type when ORing.
8676 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8677 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8678 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8679 assume EMACS_INT is the same width as char *.
8680 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8681 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8682 Remove no-longer-needed casts.
8683 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8684 (xg_tool_bar_help_callback, xg_make_tool_item):
8685 Use EMACS_INTPTR to hold an integer
8686 that will be cast to void *; this can avoid a GCC warning
8687 if EMACS_INT is not the same width as void *.
8688 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8689 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8690 (current_message_1, set_message_1):
8691 Use a local to convert to proper width without a cast.
8692 * xmenu.c (dialog_selection_callback): Likewise.
8693
ede49d71
PE
8694 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8695 Also, don't assume VALBITS / RAND_BITS is less than 5,
8696 and don't rely on undefined behavior when shifting a 1 left into
8697 the sign bit.
8698 * lisp.h (get_random): Change signature to match.
8699
2f30ecd0
PE
8700 * lread.c (hash_string): Use size_t, not int, for hash computation.
8701 Normally we prefer signed values; but hashing is special, because
8702 it's better to use unsigned division on hash table sizes so that
8703 the remainder is nonnegative. Also, size_t is the natural width
8704 for hashing into memory. The previous code used 'int', which doesn't
8705 retain enough info to hash well into very large tables.
8706 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8707
2a866e7b
PE
8708 * dbusbind.c: Don't possibly lose pointer info when converting.
8709 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8710 Use XPNTR rather than XHASH, so that the high-order bits of
8711 the pointer aren't lost when converting through void *.
8712
51639eac
PE
8713 * eval.c (Fautoload): Don't double-shift a pointer.
8714
92394119
PE
8715 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8716
dbdb9a7c
JB
87172011-05-06 Juanma Barranquero <lekktu@gmail.com>
8718
8719 * gnutls.c (DEF_GNUTLS_FN):
8720 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8721
db7a0b4f
AS
87222011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8723
8724 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8725 marker. (Bug#8610)
8726
cd394be1 87272011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8728
8729 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8730 New version that can reserve upto 2GB of heap space.
8731
f7ff1b0f 87322011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8733
8734 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8735
639c109b
TZ
87362011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8737
8738 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8739 `gnutls_certificate_set_x509_key_file'.
8740
d2127135
JB
87412011-05-05 Juanma Barranquero <lekktu@gmail.com>
8742
8743 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8744 Update dependencies.
8745
e968f4f3
JB
87462011-05-04 Juanma Barranquero <lekktu@gmail.com>
8747
8748 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8749 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8750 Remove unused parameter `fildes'.
8751 * process.c (read_process_output, send_process): Don't pass it.
8752
84d358f0
JB
87532011-05-04 Juanma Barranquero <lekktu@gmail.com>
8754
8755 Fix previous change: the library cache is defined in w32.c.
8756 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8757 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8758
0898ca10
JB
87592011-05-04 Juanma Barranquero <lekktu@gmail.com>
8760
8761 Implement dynamic loading of GnuTLS on Windows.
8762
8763 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8764 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8765 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8766 Declare.
8767
8768 * gnutls.c (Qgnutls_dll): Define.
8769 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8770 (gnutls_*): Declare function pointers.
8771 (init_gnutls_functions): New function to initialize function pointers.
8772 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8773 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8774 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8775 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8776 (emacs_gnutls_write, emacs_gnutls_read)
8777 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8778 (Fgnutls_available_p): New function.
8779 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8780 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8781 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8782
8783 * image.c: Include w32.h.
8784 (Vimage_type_cache): Delete.
8785 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8786 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8787 (w32_delayed_load): Move to w32.c.
8788
8789 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8790
8791 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8792 (w32_delayed_load): Move from image.c. When loading a library, record
8793 its filename in the :loaded-from property of the library id.
8794 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8795 Initialize and staticpro them.
8796 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8797
8798 * process.c: Include lisp.h before w32.h, not after.
8799 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8800 instead of gnutls_record_check_pending.
8801
8802 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8803
ff4de4aa
TZ
88042011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8805
8806 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8807 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8808 as passed in.
8809
abe95abb
JD
88102011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8811
8812 * xterm.c (x_set_frame_alpha): Do not set property on anything
8813 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8814
e16e55d4
JB
88152011-05-02 Juanma Barranquero <lekktu@gmail.com>
8816
8817 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8818
bafcf6a5
JB
88192011-05-02 Juanma Barranquero <lekktu@gmail.com>
8820
8821 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8822 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8823 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8824 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8825 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8826 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8827 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8828 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8829 (Qgnutls_bootprop_callbacks_verify): Make static.
8830
e7a6747f
AS
88312011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8832
19ed11ba
AS
8833 * callproc.c: Indentation fixup.
8834
e7a6747f 8835 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8836 (wait_for_termination, interruptible_wait_for_termination):
8837 Move after wait_for_termination_1.
e7a6747f 8838
1ef14cb4
LMI
88392011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8840
8841 * sysdep.c (interruptible_wait_for_termination): New function
8842 which is like wait_for_termination, but allows keyboard
8843 interruptions.
8844
8845 * callproc.c (Fcall_process): Add (:file "file") as an option for
8846 the STDOUT buffer.
8847 (Fcall_process_region): Ditto.
8848
330d880c
EZ
88492011-04-30 Eli Zaretskii <eliz@gnu.org>
8850
8db90b73
EZ
8851 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8852 rather than `XVECTOR (FOO)->size'.
8853
330d880c
EZ
8854 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8855 inttypes.h, as a gnulib replacement is used if it not available in
8856 system headers.
8857
15cbd324
EZ
88582011-04-21 Eli Zaretskii <eliz@gnu.org>
8859
8860 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8861 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8862 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8863
8864 * coding.c (coding_alloc_by_realloc): Error out if destination
8865 will grow beyond MOST_POSITIVE_FIXNUM.
8866 (decode_coding_emacs_mule): Abort if there isn't enough place in
8867 charbuf for the composition carryover bytes. Reserve an extra
8868 space for up to 2 characters produced in a loop.
8869 (decode_coding_iso_2022): Abort if there isn't enough place in
8870 charbuf for the composition carryover bytes.
8871
88722011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8873
ae940cca
EZ
8874 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8875 aborting when %lld or %lll format is passed.
8876 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8877 %llo or %llx format is passed. (Bug#8545)
8878
03ab8921
EZ
8879 * window.c (window_scroll_line_based): Use a marker instead of
8880 simple variables to record original value of point. (Bug#7952)
8881
afda1437
EZ
8882 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8883 produced by %s or %c overflows available buffer space. (Bug#8545)
8884
f76dee0c
PE
88852011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8886
8887 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8888 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8889
fdc5744d
JB
88902011-04-28 Juanma Barranquero <lekktu@gmail.com>
8891
8892 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8893
638f053a
JB
88942011-04-28 Juanma Barranquero <lekktu@gmail.com>
8895
8896 * keyboard.c (Qdelayed_warnings_hook): Define.
8897 (command_loop_1): Run `delayed-warnings-hook'
8898 if Vdelayed_warnings_list is non-nil.
8899 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8900 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8901
d178f871
EZ
89022011-04-28 Eli Zaretskii <eliz@gnu.org>
8903
8904 * doprnt.c (doprnt): Don't return value smaller than the buffer
8905 size if the message was truncated. (Bug#8545).
8906
b124fd93
JB
89072011-04-28 Juanma Barranquero <lekktu@gmail.com>
8908
8909 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8910 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8911
e810457d
PE
89122011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8913
8914 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8915
ea51cceb
JB
89162011-04-27 Juanma Barranquero <lekktu@gmail.com>
8917
8918 * makefile.w32-in: Update dependencies.
8919
94dcfacf
EZ
89202011-04-27 Eli Zaretskii <eliz@gnu.org>
8921
8922 Improve `doprnt' and its usage. (Bug#8545)
8923 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8924 `format_end'. Remove support for %l as a conversion specifier.
8925 Don't use xrealloc. Improve diagnostics when the %l size modifier
8926 is used. Update the commentary.
8927
8928 * eval.c (verror): Simplify calculation of size_t.
8929
8930 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8931 messages.
8932
f61f41d7
PE
89332011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8934
8935 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8936 change.
8937
96fb4434
PE
89382011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8939
8940 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8941 This makes this file independent of the recent pseudovector change.
8942
671875da 89432011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 8944
69e9b5a3
PE
8945 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8946
b5f869a7 8947 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 8948 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 8949 Remove unused local.
c8926152 8950 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 8951
841a1577 8952 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
8953 GCC 4.6.0 optimizes based on type-based alias analysis.
8954 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
8955 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8956 != &v->size, and therefore "v->size = 1; b->size = 2; return
8957 v->size;" must therefore return 1. This assumption is incorrect
8958 for Emacs, since it type-puns struct Lisp_Vector * with many other
8959 types. To fix this problem, this patch adds a new type struct
f904488f 8960 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
8961 and pseudovectors, and helps optimizing compilers not get fooled
8962 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8963 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
8964 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8965 the size member.
eab3844f
PE
8966 (XSETPVECTYPE): Rewrite in terms of new macro.
8967 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8968 This is a bit clearer, and further avoids the possibility of
8969 undesirable aliasing.
8970 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 8971 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
8972 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8973 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
8974 (ASIZE): Now uses header.size rather than size.
8975 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
8976 to avoid the hassle of writing XVECTOR (foo)->header.size.
8977 (struct vectorlike_header): New type.
eab3844f
PE
8978 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8979 object, to help avoid aliasing.
8980 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8981 (SUBRP): Likewise, since Lisp_Subr is a special case.
8982 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8983 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8984 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 8985 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
8986 changed to be "header.size" and "header.next".
8987 * buffer.h (struct buffer): Likewise.
8988 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8989 * frame.h (struct frame): Likewise.
8990 * process.h (struct Lisp_Process): Likewise.
8991 * termhooks.h (struct terminal): Likewise.
8992 * window.c (struct save_window_data, struct saved_window): Likewise.
8993 * window.h (struct window): Likewise.
8994 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8995 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8996 * buffer.c (init_buffer_once): Likewise.
8997 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8998 special case.
8999 * process.c (Fformat_network_address): Use local var for size,
9000 for brevity.
9001
0df1eac5
PE
9002 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9003
847ab9d1 9004 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9005 * data.c (atof): Remove decl; no longer used or needed.
9006 (digit_to_number): Move to lread.c.
9007 (Fstring_to_number): Use new string_to_number function, to be
9008 consistent with how the Lisp reader treats infinities and NaNs.
9009 Do not assume that floating-point numbers represent EMACS_INT
9010 without losing information; this is not true on most 64-bit hosts.
9011 Avoid double-rounding errors, by insisting on integers when
9012 parsing non-base-10 numbers, as the documentation specifies.
9013 * lisp.h (string_to_number): New decl, replacing ...
9014 (isfloat_string): Remove.
bc0a5c13 9015 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9016 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9017 appears to have been a coding error. Similarly, do not accept
9018 strings like +-1e0 as floating point numbers. Do not report
9019 overflow for integer overflows unless the base is not 10 which
9020 means we have no simple and reliable way to continue.
9021 Break out the floating-point parsing into a new
9022 function string_to_number, so that Fstring_to_number parses
9023 floating point numbers consistently with the Lisp reader.
04f2d78b 9024 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9025 (E_CHAR, EXP_INT): Remove, replacing with ...
9026 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9027 (string_to_number): New function, replacing isfloat_string.
9028 This function checks for valid syntax and produces the resulting
9029 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9030 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9031 so that overflow for non-base-10 numbers is reported only when
9032 there's no portable and simple way to convert to floating point.
452f4150 9033
67769ffc
PE
9034 * textprop.c (set_text_properties_1): Rewrite for clarity,
9035 and to avoid GCC warning about integer overflow.
9036
c20db43f
PE
9037 * intervals.h (struct interval): Use EMACS_INT for members
9038 where EMACS_UINT might cause problems. See
9039 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9040 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9041 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9042 All uses changed.
37aa2f85
PE
9043 (offset_intervals): Tell GCC not to worry about length overflow
9044 when negating a negative length.
c20db43f 9045
2538aa2f
PE
9046 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9047 (overrun_check_free): Likewise.
9048
f2d3008d
PE
9049 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9050 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9051 word size.
9052
ec8df744
PE
9053 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9054 (gnutls_make_error): Rename local to avoid shadowing.
9055 (gnutls_emacs_global_deinit): ifdef out; not used.
9056 (Fgnutls_boot): Use const for pointer to readonly storage.
9057 Comment out unused local. Fix pointer signedness problems.
9058
640ee02d
PE
9059 * lread.c (openp): Don't stuff size_t into an 'int'.
9060 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9061 about possible signed overflow.
9062
6048fb2a
PE
9063 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9064 (GDK_KEY_g): Don't define if already defined.
9065 (xg_prepare_tooltip): Avoid pointer signedness problem.
9066 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9067
fa3c87e1
PE
9068 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9069 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9070
2172544b
PE
9071 * xfns.c (Fx_window_property): Simplify a bit,
9072 to make a bit faster and to avoid GCC 4.6.0 warning.
9073 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9074
9b821a21
PE
9075 * fns.c (internal_equal): Don't assume size_t fits in int.
9076
3c616cfa
PE
9077 * alloc.c (compact_small_strings): Tighten assertion a little.
9078
c2982e87
PE
9079 Replace pEd with more-general pI, and fix some printf arg casts.
9080 * lisp.h (pI): New macro, generalizing old pEd macro to other
9081 conversion specifiers. For example, use "...%"pI"d..." rather
9082 than "...%"pEd"...".
9083 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9084 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9085 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9086 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9087 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9088 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9089 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9090 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9091 64-bit hosts.
9092 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9093 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9094 * print.c (safe_debug_print, print_object): Likewise.
9095 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9096 to int.
6f04d126
PE
9097 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9098 avoiding the 0 flag, which is not portable.
c2982e87
PE
9099 * process.c (Fmake_network_process): Use pI to avoid cast.
9100 * region-cache.c (pp_cache): Likewise.
9101 * xdisp.c (decode_mode_spec): Likewise.
9102 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9103 behavior on 64-bit hosts with printf arg.
6f04d126 9104 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9105 (x_stop_queuing_selection_requests): Likewise.
9106 (x_get_window_property): Don't truncate byte count to an 'int'
9107 when tracing.
0b432f21 9108
5e073ec7
PE
9109 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9110 here, since it parses constructs like leading '-' and spaces,
9111 which are not wanted; and it overflows with large numbers.
9112 Instead, simply match F[0-9]+, which is what is wanted anyway.
9113
36372bf9
PE
9114 * alloc.c: Remove unportable assumptions about struct layout.
9115 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9116 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9117 (allocate_vectorlike, make_pure_vector): Use the new macros,
9118 plus offsetof, to remove unportable assumptions about struct layout.
9119 These assumptions hold on all porting targets that I know of, but
9120 they are not guaranteed, they're easy to remove, and removing them
9121 makes further changes easier.
9122
0b432f21
PE
9123 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9124 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9125 (string_overrun_cookie): Now const. Use initializers that
9126 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9127 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9128 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9129 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9130 multiple of sizeof (EMACS_INT); it need not be, if
9131 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9132 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9133
895009e1
JB
91342011-04-26 Juanma Barranquero <lekktu@gmail.com>
9135
9136 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9137
6a7a1b0b
TZ
91382011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9139
9140 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9141 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9142 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9143
841a1577 91442011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9145
9146 * lisp.h (Qdebug): List symbol.
895009e1 9147 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9148 * keyboard.c (debug-on-event): New variable.
9149 (handle_user_signal): Break into debugger when debug-on-event
9150 matches the current signal symbol.
9151
f2d3ba6f
DN
91522011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9153
9154 * alloc.c (check_sblock, check_string_bytes)
9155 (check_string_free_list): Convert to standard C.
9156
42ce4c63
TZ
91572011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9158
9159 * w32.c (emacs_gnutls_push): Fix typo.
9160
825cd63c
EZ
91612011-04-25 Eli Zaretskii <eliz@gnu.org>
9162
fb11d64d
EZ
9163 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9164 "cast to pointer from integer of different size".
9165
825cd63c
EZ
9166 Improve doprnt and its use in verror. (Bug#8545)
9167 * doprnt.c (doprnt): Document the set of format control sequences
9168 supported by the function. Use SAFE_ALLOCA instead of always
9169 using `alloca'.
9170
9171 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9172 is one byte too soon. Don't use xrealloc; instead xfree and
9173 xmalloc anew.
9174
e061a11b
TZ
91752011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9176
9177 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9178 callbacks stage.
9179
9180 * gnutls.c: Renamed global_initialized to
9181 gnutls_global_initialized. Added internals for the
9182 :verify-hostname-error, :verify-error, and :verify-flags
9183 parameters of `gnutls-boot' and documented those parameters in the
9184 docstring. Start callback support.
9173deec
JB
9185 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9186 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9187 on error. Return error code.
e061a11b
TZ
9188 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9189 (emacs_gnutls_read): Likewise.
9190 (Fgnutls_boot): Return handshake error code.
9191 (emacs_gnutls_handle_error): New function.
9192 (wsaerror_to_errno): Likewise.
9193
9194 * w32.h (emacs_gnutls_pull): Add prototype.
9195 (emacs_gnutls_push): Likewise.
9196
9197 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9198 (emacs_gnutls_push): Likewise.
9199
92002011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9201
9202 * process.c (wait_reading_process_output): Check if GnuTLS
9203 buffered some data internally if no FDs are set for TLS
9204 connections.
9205
9206 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9207 (LIBS): Link to USER_LIBS.
9208 ($(BLD)/gnutls.$(0)): New target.
9209
fa6996bc
EZ
92102011-04-24 Eli Zaretskii <eliz@gnu.org>
9211
eb35682e
EZ
9212 * xdisp.c (handle_single_display_spec): Rename the
9213 display_replaced_before_p argument into display_replaced_p, to
9214 make it consistent with the commentary. Fix typos in the
9215 commentary.
9216
e2ad650c
EZ
9217 * textprop.c (syms_of_textprop): Remove dead code.
9218 (copy_text_properties): Delete obsolete commentary about an
9219 interface that was deleted long ago. Fix typos in the description
9220 of arguments.
9221
1b2de274
EZ
9222 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9223 to changes in oldXMenu/XMenu.h from 2011-04-16.
9224 <menu_help_message, prev_menu_help_message>: Constify.
9225 (IT_menu_make_room): menu->help_text is now `const char **';
9226 adjust.
9227
9228 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9229 to changes in oldXMenu/XMenu.h from 2011-04-16.
9230 (struct XMenu): Declare `help_text' `const char **'.
9231
9232 * xfaces.c <Qunspecified>: Make extern again.
9233
9234 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9235 required by POSIX.
1b2de274 9236
762b15be
EZ
9237 * doc.c (get_doc_string): Improve the format passed to `error'.
9238
9239 * doprnt.c (doprnt): Improve commentary.
9240
9241 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9242
9243 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9244 them with etags.
9245
f1052e5d
EZ
9246 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9247 changes in globals.h immediately force recompilation.
762b15be
EZ
9248 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9249 $(CURDIR)/s/ms-w32.h.
9250 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9251
fa6996bc
EZ
9252 * character.c (Fchar_direction): Function deleted.
9253 (syms_of_character): Don't defsubr it.
9254 <char-direction-table>: Deleted.
9255
e6c3da20
EZ
92562011-04-23 Eli Zaretskii <eliz@gnu.org>
9257
9258 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9259 * doprnt.c: Include limits.h.
9260 (SIZE_MAX): New macro.
04f2d78b
CB
9261 (doprnt): Return a size_t value. 2nd arg is now size_t.
9262 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9263 Improve overflow protection. Support `l' modifier for integer
9264 conversions. Support %l conversion. Don't assume an EMACS_INT
9265 argument for integer conversions and for %c.
9266
9267 * lisp.h (doprnt): Restore prototype.
9268
9269 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9270 $(SRC)/character.h.
9271
9272 * Makefile.in (base_obj): Add back doprnt.o.
9273
9274 * deps.mk (doprnt.o): Add back prerequisites.
9275 (callint.o): Depend on character.h.
9276
9277 * eval.c (internal_lisp_condition_case): Include the handler
9278 representation in the error message.
9279 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9280 when breaking from the loop.
9281
9282 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9283
9284 * callint.c (Fcall_interactively): When displaying error message
9285 about invalid control letter, pass the character's codepoint, not
9286 a pointer to its multibyte form. Improve display of the character
9287 in octal and display also its hex code.
9288
9289 * character.c (char_string): Use %x to display the (unsigned)
9290 codepoint of an invalid character, to avoid displaying a bogus
9291 negative value.
9292
9293 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9294 `error', not SYMBOL_NAME itself.
9295
9296 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9297 character arguments to `error'.
9298
9299 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9300 to `error' in error message about FINAL_CHAR argument. Make sure
9301 FINAL_CHAR is a character, and use %c when it is passed as
9302 argument to `error'.
9303
4ffd0d6b 93042011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9305
9306 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9307
9308 * w32.c: Include <time.h>.
9309 (sys_localtime): New function.
9310
4ffd0d6b 93112011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9312
9313 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9314
4ffd0d6b 9315 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9316
4ffd0d6b 93172011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9318
4ffd0d6b
GM
9319 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9320 zombies (Bug#8467).
aac0c6e3 9321
04c56954
EZ
93222011-04-19 Eli Zaretskii <eliz@gnu.org>
9323
9324 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9325 gl_state.e_property when gl_state.object is Qt.
9326
9327 * insdel.c (make_gap_larger): Remove limitation of buffer size
9328 to <= INT_MAX.
9329
16a43933
CY
93302011-04-18 Chong Yidong <cyd@stupidchicken.com>
9331
9332 * xdisp.c (lookup_glyphless_char_display)
9333 (produce_glyphless_glyph): Handle cons cell entry in
9334 glyphless-char-display.
9335 (Vglyphless_char_display): Document it.
9336
9337 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9338 glyphless-char-display.
9339
4581706e
CY
93402011-04-17 Chong Yidong <cyd@stupidchicken.com>
9341
9342 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9343
9344 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9345
9346 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9347 definition for no-X builds.
9348
4887c6e2 93492011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9350
fd35b6f9
PE
9351 Static checks with GCC 4.6.0 and non-default toolkits.
9352
5c1ccb01
PE
9353 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9354
006c5daa
PE
9355 * process.c (keyboard_bit_set): Define only if SIGIO.
9356 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9357 (send_process): Repair possible setjmp clobbering.
9358
efc736d3
PE
9359 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9360
4e2fe2e6
PE
9361 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9362
f97334a2
PE
9363 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9364
4e75f29d
PE
9365 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9366 Define only if needed.
9367
90efadd1
PE
9368 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9369 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9370 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9371
3c647824
PE
9372 * dispextern.h (struct redisplay_interface): Rename param
9373 to avoid shadowing.
e264f262 9374 * termhooks.h (struct terminal): Likewise.
761383f4 9375 * xterm.c (xembed_send_message): Likewise.
3c647824 9376
b58c5c4a
PE
9377 * insdel.c (make_gap_smaller): Define only if
9378 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9379
cad59032
PE
9380 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9381 it.
9382
c339dc2e
PE
9383 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9384 so that we aren't warned about unused symbols.
9385
91a3e27b
PE
9386 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9387
399c71d3 9388 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9389
8ffc96f5
PE
9390 * xfns.c (x_real_positions): Mark locals as initialized.
9391
eef9bc79
PE
9392 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9393
098db9dd
PE
9394 * xterm.c: Fix problems found by static analysis with other toolkits.
9395 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9396 (x_dispatch_event): Declare static if USE_GTK, and
9397 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9398 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9399 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9400 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9401 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9402
eb18f6cc
PE
9403 * xmenu.c (menu_help_callback): Pointer type fixes.
9404 Use const pointers when pointing at readonly data. Avoid pointer
9405 signedness clashes.
9406 (FALSE): Remove unused macro.
9407 (update_frame_menubar): Remove unused decl.
9408
1fe72bf8
PE
9409 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9410
60d9e1db
PE
9411 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9412 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9413 (single_menu_item): Rename local to avoid shadowing.
9414
39261c26
PE
9415 * keyboard.c (make_lispy_event): Remove unused local var.
9416
018c5e19
PE
9417 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9418 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9419
63d2b86e
PE
9420 * bitmaps: Change bitmaps from unsigned char back to the X11
9421 compatible char. Avoid the old compiler warnings about
9422 out-of-range initializers by using, for example, '\xab' rather
9423 than 0xab.
9424
aefd87e1
PE
9425 * xgselect.c (xgselect_initialize): Check vs interface
9426 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9427
bf501fb9
PE
9428 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9429
e9829fdf
PE
9430 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9431 to read-only memory.
9432
1086c095
PE
9433 * fns.c (vector): Remove; this old hack is no longer needed.
9434
2baccd04 9435 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9436 Remove unused var.
dde42981 9437 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9438
72391843 9439 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9440
436c16df 9441 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9442 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9443 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9444
92bb796d 9445 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9446 (x_term_init): Remove local to avoid shadowing.
92bb796d 9447
764430a3 9448 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9449
9450 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9451 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9452
d1dfb56c
EZ
94532011-04-16 Eli Zaretskii <eliz@gnu.org>
9454
c4354cb4
EZ
9455 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9456
d1dfb56c
EZ
9457 Fix regex.c, syntax.c and friends for buffers > 2GB.
9458 * syntax.h (struct gl_state_s): Declare character position members
9459 EMACS_INT.
9460
9461 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9462
04f2d78b
CB
9463 * textprop.c (verify_interval_modification, interval_of):
9464 Declare arguments EMACS_INT.
d1dfb56c
EZ
9465
9466 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9467 EMACS_INT.
9468
9469 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9470
9471 * indent.c (Fvertical_motion): Local variable it_start is now
9472 EMACS_INT.
9473
9474 * regex.c (re_match, re_match_2, re_match_2_internal)
9475 (bcmp_translate, regcomp, regexec, print_double_string)
9476 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9477 (re_compile_pattern, re_exec): Declare arguments and local
9478 variables `size_t' and `ssize_t' and return values `regoff_t', as
9479 appropriate.
9480 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9481 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9482 <compile_stack_type>: `size' and `avail' are now `size_t'.
9483
9484 * regex.h <regoff_t>: Use ssize_t, not int.
9485 (re_search, re_search_2, re_match, re_match_2): Arguments that
9486 specify buffer/string position and length are now ssize_t and
9487 size_t. Return type is regoff_t.
9488
613052cd
BK
94892011-04-16 Ben Key <bkey76@gmail.com>
9490
9491 * nsfont.m: Fixed bugs in ns_get_family and
9492 ns_descriptor_to_entity that were caused by using free to
9493 deallocate memory blocks that were allocated by xmalloc (via
9494 xstrdup). This caused Emacs to crash when compiled with
9495 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9496 --enable-checking=xmallocoverrun). xfree is now used to
9497 deallocate these memory blocks.
9498
4170f62f 94992011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9500
71b41406
PE
9501 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9502
9587a89d
PE
9503 emacs_write: Accept and return EMACS_INT for sizes.
9504 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9505 et seq.
9506 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9507 Accept and return EMACS_INT.
9508 (emacs_gnutls_write): Return the number of bytes written on
9509 partial writes.
9510 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9511 (emacs_read, emacs_write): Remove check for negative size, as the
9512 Emacs source code has been audited now.
9587a89d
PE
9513 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9514 (emacs_read, emacs_write): Use it.
273a5f82
PE
9515 * process.c (send_process): Adjust to the new signatures of
9516 emacs_write and emacs_gnutls_write. Do not attempt to store
9517 a byte offset into an 'int'; it might overflow.
9587a89d 9518 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9519
3e047f51
PE
9520 * sound.c: Don't assume sizes fit in 'int'.
9521 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9522 Return EMACS_INT, not int.
3e047f51 9523 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9524 Accept EMACS_INT, not int.
9525 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9526 record read return values.
9527
cc39a9db
BK
95282011-04-15 Ben Key <bkey76@gmail.com>
9529
c9d0ec6d
JB
9530 * keyboard.c (Qundefined): Don't declare static since it is used
9531 in nsfns.m.
9532 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9533 static since they are used in nsfont.m.
cc39a9db 9534
6c60eb9f
SM
95352011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9536
9537 * process.c (Qprocessp): Don't declare static.
9538 * lisp.h (Qprocessp): Declare again.
9539
7990b61a
JB
95402011-04-15 Juanma Barranquero <lekktu@gmail.com>
9541
9542 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9543
5d4cb038
PE
95442011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9545
8bd7b830 9546 Improve C-level modularity by making more things 'static'.
cd64ea1d 9547
e3b27b31
PE
9548 Don't publish debugger-only interfaces to other modules.
9549 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9550 (verify_bytepos, count_markers): Move decls to the only modules
9551 that need them.
9552 * region-cache.h (pp_cache): Likewise.
9553 * window.h (check_all_windows): Likewise.
9554 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9555
5d4cb038
PE
9556 * sysdep.c (croak): Now static, if
9557 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9558 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9559
9560 * alloc.c (refill_memory_reserve): Now static if
9561 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9562 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9563
e87b6180
PE
9564 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9565 Define only if USE_LUCID.
9566
ac64929e
PE
9567 * xrdb.c (x_customization_string, x_rm_string): Now static.
9568
6f37259d
PE
9569 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9570 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9571
1683e3ab
PE
9572 * xdisp.c (draw_row_with_mouse_face): Now static.
9573 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9574
de9c2632
PE
9575 * window.h (check_all_windows): Mark externally visible.
9576
2b96acb7
PE
9577 * window.c (window_deletion_count): Now static.
9578
9579 * undo.c: Make symbols static if they're not exported.
9580 (last_undo_buffer, last_boundary_position, pending_boundary):
9581 Now static.
9582
50436f33
PE
9583 * textprop.c (interval_insert_behind_hooks): Now static.
9584 (interval_insert_in_front_hooks): Likewise.
9585
64520e5c
PE
9586 * term.c: Make symbols static if they're not exported.
9587 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9588 (max_frame_lines, tty_set_terminal_modes):
9589 (tty_reset_terminal_modes, tty_turn_off_highlight):
9590 (get_tty_terminal): Now static.
9591 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9592 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9593 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9594 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9595 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9596
1fa53021
PE
9597 * sysdep.c: Make symbols static if they're not exported.
9598 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9599 Now static.
9600 (sigprocmask_set, full_mask): Remove; unused.
9601 (wait_debugging): Mark as visible.
9602 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9603 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9604
d4b43b22
PE
9605 * syntax.c (syntax_temp): Define only if !__GNUC__.
9606
b7c513d0
PE
9607 * sound.c (current_sound_device, current_sound): Now static.
9608
989b29ad
PE
9609 * search.c (searchbufs, searchbuf_head): Now static.
9610
13a55a78
PE
9611 * scroll.c (scroll_cost): Remove; unused.
9612 * dispextern.h (scroll_cost): Remove decl.
9613
de68a1fc
PE
9614 * region-cache.h (pp_cache): Mark as externally visible.
9615
40ccffa6
PE
9616 * process.c: Make symbols static if they're not exported.
9617 (process_tick, update_tick, create_process, chan_process):
9618 (Vprocess_alist, proc_buffered_char, datagram_access):
9619 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9620 (deactivate_process): Mark defn as static, as well as decl.
9621 * lisp.h (create_process): Remove decl.
9622 * process.h (chan_process, Vprocess_alist): Remove decls.
9623
ad64fc97
PE
9624 * print.c: Make symbols static if they're not exported.
9625 (print_depth, new_backquote_output, being_printed, print_buffer):
9626 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9627 (print_interval, print_number_index, initial_stderr_stream):
9628 Now static.
9629 * lisp.h (Fprinc): Remove decl.
9630 (debug_output_compilation_hack): Mark as externally visible.
9631
adddb265
PE
9632 * sysdep.c (croak): Move decl from here to syssignal.h.
9633 * syssignal.h (croak): Put it here, so the API can be checked when
9634 'croak' is called from dissociate_if_controlling_tty.
9635
1717ede2
PE
9636 * minibuf.c: Make symbols static if they're not exported.
9637 (minibuf_save_list, choose_minibuf_frame): Now static.
9638 * lisp.h (choose_minibuf_frame): Remove decl.
9639
fa5fb2bc
PE
9640 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9641
1e3890d1
PE
9642 * lread.c: Make symbols static if they're not exported.
9643 (read_objects, initial_obarray, oblookup_last_bucket_number):
9644 Now static.
9645 (make_symbol): Remove; unused.
9646 * lisp.h (initial_obarray, make_symbol): Remove decls.
9647
8a1414fa
PE
9648 * keyboard.c: Make symbols static if they're not exported.
9649 (single_kboard, recent_keys_index, total_keys, recent_keys):
9650 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9651 (this_single_command_key_start, echoing, last_auto_save):
9652 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9653 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9654 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9655 (Vlispy_mouse_stem, double_click_count):
9656 Now static.
9657 (force_auto_save_soon): Define only if SIGDANGER.
9658 (ignore_mouse_drag_p): Now static if
9659 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9660 (print_help): Remove; unused.
9661 (stop_character, last_timer_event): Mark as externally visible.
9662 * keyboard.h (ignore_mouse_drag_p): Declare only if
9663 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9664 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9665 * lisp.h (echoing): Remove decl.
9666 (force_auto_save_soon): Declare only if SIGDANGER.
9667 * xdisp.c (redisplay_window): Simplify code, to make it more
9668 obvious that ignore_mouse_drag_p is not accessed if !defined
9669 USE_GTK && !defined HAVE_NS.
9670
93ea6e8f
PE
9671 * intervals.c: Make symbols static if they're not exported.
9672 (merge_properties_sticky, merge_interval_right, delete_interval):
9673 Now static.
9674 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9675
77382fcc
PE
9676 * insdel.c: Make symbols static if they're not exported.
9677 However, leave prepare_to_modify_buffer alone. It's never
9678 called from outside this function, but that appears to be a bug.
9679 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9680 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9681 (adjust_after_replace_noundo): Remove; unused.
9682 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9683 (signal_before_change): Remove decls.
77382fcc 9684
9306c32e
PE
9685 * indent.c (val_compute_motion, val_vmotion): Now static.
9686
cd44d2eb
PE
9687 * image.c: Make symbols static if they're not exported.
9688 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9689 if USE_GTK.
9690 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9691 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9692
ad9a7a06
PE
9693 * fringe.c (standard_bitmaps): Now static.
9694 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9695
81626931
PE
9696 * frame.c: Make symbols static if they're not exported.
9697 (x_report_frame_params, make_terminal_frame): Now static.
9698 (get_frame_param): Now static, unless HAVE_NS.
9699 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9700 (x_get_resource_string): Remove; not used.
9701 * frame.h (make_terminal_frame, x_report_frame_params):
9702 (x_get_resource_string); Remove decls.
9703 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9704 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9705
239f9db9
PE
9706 * font.c, fontset.c: Make symbols static if they're not exported.
9707 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9708 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9709 * font.c (font_close_object): Now static.
9710 * font.h (font_close_object): Remove.
9711 * fontset.c (FONTSET_OBJLIST): Remove.
9712 (free_realized_fontset) #if-0 the body, which does nothing.
9713 (face_suitable_for_char_p): #if-0, as it's never called.
9714 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9715 * xfaces.c (face_at_string_position):
9716 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9717 since 0 is always ASCII.
9718
dfcf3579
PE
9719 * fns.c (weak_hash_tables): Now static.
9720
5045092b
PE
9721 * fileio.c: Make symbols static if they're not exported.
9722 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9723 (Vwrite_region_annotation_buffers): Now static.
9724
57a96f5c
PE
9725 * eval.c: Make symbols static if they're not exported.
9726 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9727 * lisp.h (backtrace_list): Remove decl.
9728
35f08c38
PE
9729 * emacs.c: Make symbols static if they're not exported.
9730 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9731 (fatal_error_code, fatal_error_signal_hook, standard_args):
9732 Now static.
9733 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9734 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9735 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9736 * lisp.h (fatal_error_signal_hook): Remove decl.
9737 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9738
f44bd759
PE
9739 * editfns.c: Move a (normally-unused) function to its only use.
9740 * editfns.c, lisp.h (get_operating_system_release): Remove.
9741 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9742 worth the hassle of breaking this out.
9743
b532497d
PE
9744 * xterm.c: Make symbols static if they're not exported.
9745 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9746 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9747 (x_destroy_window, x_delete_display):
9748 Now static.
9749 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9750 (x_mouse_leave): Remove; unused.
9751 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9752 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9753 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9754 Remove decls.
9755 (x_mouse_leave): Declare only if WINDOWSNT.
9756 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9757 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9758 USE_X_TOOLKIT.
9759
1675728f
PE
9760 * ftxfont.c: Make symbols static if they're not exported.
9761 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9762 HAVE_FREETYPE.
9763 * font.h (ftxfont_driver): Likewise.
9764
e4cebfca
PE
9765 * xfns.c: Make symbols static if they're not exported.
9766 (x_last_font_name, x_display_info_for_name):
9767 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9768 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9769 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9770 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9771 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9772 (last_show_tip_args): Now static.
9773 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9774 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9775 (x_screen_planes): Remove; unused.
9776 * dispextern.h (x_screen_planes): Remove decl.
9777
5bf46f05
PE
9778 * dispnew.c: Make symbols static if they're not exported.
9779 * dispextern.h (redraw_garbaged_frames, scrolling):
9780 (increment_row_positions): Remove.
9781 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9782 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9783 Now static.
9784 (redraw_garbaged_frames): Remove; unused.
9785
435f4c28
PE
9786 * xfaces.c: Make symbols static if they're not exported.
9787 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9788 Remove decls.
9789 * xterm.h (defined_color): Remove decls.
9790 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9791 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9792 (menu_face_changed_default, defined_color, free_realized_face):
9793 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9794 (ascii_face_of_lisp_face): Remove; unused.
9795
8524aef3
PE
9796 * xdisp.c: Make symbols static if they're not exported.
9797 * dispextern.h (scratch_glyph_row, window_box_edges):
9798 (glyph_to_pixel_coords, set_cursor_from_row):
9799 (get_next_display_element, set_iterator_to_next):
9800 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9801 (show_mouse_face): Remove decls
9802 * frame.h (message_buf_print): Likewise.
9803 * lisp.h (pop_message, set_message, check_point_in_composition):
9804 Likewise.
9805 * xterm.h (set_vertical_scroll_bar): Likewise.
9806 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9807 (message_buf_print, scratch_glyph_row, displayed_buffer):
9808 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9809 (get_next_display_element, show_mouse_face, window_box_edges):
9810 (frame_to_window_pixel_xy, check_point_in_composition):
9811 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9812 (glyph_to_pixel_coords): Remove; unused.
9813
16390cd2
PE
9814 * dired.c (file_name_completion): Now static.
9815
9816 * dbusbind.c (xd_in_read_queued_messages): Now static.
9817
a25f4dfa
PE
9818 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9819 * data.c (circular_list_error): Remove.
9820
14a9c8df
PE
9821 * commands.h (last_point_position, last_point_position_buffer):
9822 (last_point_position_window): Remove decls.
9823 * keyboard.c: Make these variables static.
9824
04f2d78b
CB
9825 * coding.h (coding, code_convert_region, encode_coding_gap):
9826 Remove decls.
74ab6df5
PE
9827 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9828 (iso_code_class, detect_coding, code_convert_region): Now static.
9829 (encode_coding_gap): Remove; unused.
9830
38dfbee1
PE
9831 * chartab.c (chartab_chars, chartab_bits): Now static.
9832
a2cb4e63
PE
9833 * charset.h (charset_iso_8859_1): Remove decl.
9834 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9835 Now static.
9836
127198fd
PE
9837 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9838 * ccl.c (Vccl_program_table): Now static.
9839 (check_ccl_update): Remove; unused.
9840
d85b608f
PE
9841 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9842 * category.h: ... from here.
9843 * category.c (check_category_table, set_category_set): Now static.
9844
31cd66f3
PE
9845 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9846 * lisp.h: Remove these decls.
9847
c358e587
PE
9848 * buffer.c (buffer_count): Remove unused var.
9849
e78aecca
PE
9850 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9851 so that it's not optimized away.
9852 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9853 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9854 exported only to the debugger.
9855
e192d7d3 9856 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9857 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9858
92470028
PE
9859 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9860 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9861 was inaccessible from Lisp.
9862 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9863 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9864
244ed907
PE
9865 alloc.c: Import and export fewer symbols, and remove unused items.
9866 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9867 is defined.
9868 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9869 it's not optimized away by whole-program optimization.
9870 (message_enable_multibyte, free_misc): Remove.
9871 (catchlist, handlerlist, mark_backtrace):
9872 Declare only if BYTE_MARK_STACK.
9873 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9874 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9875 (message_enable_multibyte): Remove decl.
9876 (free_misc, interval_free_list, float_block, float_block_index):
9877 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9878 (cons_free_list, last_marked_index):
9879 Now static.
9880 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9881 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9882 (mark_backtrace): Define only if BYTE_MARK_STACK.
9883 * xdisp.c (message_enable_multibyte): Now static.
9884
61c2b50e 9885 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9886 This makes it easier for human readers (and static analyzers)
9887 to see whether these variables are used from other modules.
9888 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9889 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9890 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9891 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9892 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9893 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9894 * xmenu.c, xselect.c:
9895 Declare Q* vars static if they are not used in other modules.
9896 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9897 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9898 Remove decls of unexported vars.
9899 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9900
95c82688
PE
9901 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9902
16a97296
PE
9903 Make Emacs functions such as Fatom 'static' by default.
9904 This makes it easier for human readers (and static analyzers)
9905 to see whether these functions can be called from other modules.
9906 DEFUN now defines a static function. To make the function external
9907 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9908 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9909 (Finit_image_library):
16a97296
PE
9910 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9911 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9912 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9913 Remove decls, since these functions are now static.
9914 (Funintern, Fget_internal_run_time): New decls, since these functions
9915 were already external.
95c82688 9916
16a97296
PE
9917 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9918 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9919 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9920 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9921 * keyboard.c, keymap.c, lread.c:
9922 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9923 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9924 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9925 Mark functions with DEFUE instead of DEFUN,
9926 if they are used in other modules.
9927 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9928 decls for now-static functions.
9929 * buffer.h (Fdelete_overlay): Remove decl.
9930 * callproc.c (Fgetenv_internal): Mark as internal.
9931 * composite.c (Fremove_list_of_text_properties): Remove decl.
9932 (Fcomposition_get_gstring): New forward static decl.
9933 * composite.h (Fcomposite_get_gstring): Remove decl.
9934 * dired.c (Ffile_attributes): New forward static decl.
9935 * doc.c (Fdocumntation_property): New forward static decl.
9936 * eval.c (Ffetch_bytecode): New forward static decl.
9937 (Funintern): Remove extern decl; now in .h file where it belongs.
9938 * fileio.c (Fmake_symbolic_link): New forward static decl.
9939 * image.c (Finit_image_library): New forward static decl.
9940 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9941 * intervals.h (Fprevious_property_change):
9942 (Fremove_list_of_text_properties): Remove decls.
9943 * keyboard.c (Fthis_command_keys): Remove decl.
9944 (Fcommand_execute): New forward static decl.
9945 * keymap.c (Flookup_key): New forward static decl.
9946 (Fcopy_keymap): Now static.
9947 * keymap.h (Flookup_key): Remove decl.
9948 * process.c (Fget_process): New forward static decl.
9949 (Fprocess_datagram_address): Mark as internal.
9950 * syntax.c (Fsyntax_table_p): New forward static decl.
9951 (skip_chars): Remove duplicate decl.
9952 * textprop.c (Fprevious_property_change): New forward static decl.
9953 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9954 Now internal.
9955 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9956 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9957
785bbd42
PE
9958 * editfns.c (Fformat): Remove unreachable code.
9959
8b913b57
AS
99602011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9961
9962 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9963 change. (Bug#8496)
9964
a6744a35
EZ
99652011-04-13 Eli Zaretskii <eliz@gnu.org>
9966
9967 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9968 when at ZV. (Bug#8487)
9969
e7974947
AS
99702011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9971
baad03f0
AS
9972 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9973 (Bug#8437)
9974 * keyboard.c (parse_tool_bar_item): Likewise.
9975 * sound.c (sound_cleanup, alsa_close): Likewise.
9976 * termcap.c (tgetent): Likewise.
9977 * xfns.c (x_default_font_parameter): Likewise.
9978 * xsettings.c (read_and_apply_settings): Likewise.
9979
e7974947
AS
9980 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9981 (overrun_check_free): Protoize.
9982
28272684
PE
99832011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9984
9985 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9986 since callers should never pass a negative size.
9987 Change the signature to match that of plain 'read' and 'write'; see
9988 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9989 * lisp.h: Update prototypes of emacs_write and emacs_read.
9990
11997c76
EZ
99912011-04-11 Eli Zaretskii <eliz@gnu.org>
9992
9993 * xdisp.c (redisplay_window): Don't try to determine the character
9994 position of the scroll margin if the window start point w->startp
e896f03c 9995 is outside the buffer's accessible region. (Bug#8468)
11997c76 9996
8a2cbd72
EZ
99972011-04-10 Eli Zaretskii <eliz@gnu.org>
9998
9999 Fix write-region and its subroutines for buffers > 2GB.
10000 * fileio.c (a_write, e_write): Modify declaration of arguments and
10001 local variables to support buffers larger than 2GB.
10002 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10003
10004 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10005 argument, local variables, and return value.
10006
10007 * lisp.h: Update prototypes of emacs_write and emacs_read.
10008
10009 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10010
4073e537 100112011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10012
1ebfdcb6
PE
10013 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10014
b2ded58d
PE
10015 Fix more problems found by GCC 4.6.0's static checks.
10016
7d66342c
PE
10017 * xdisp.c (vmessage): Use a better test for character truncation.
10018
bbf47d44
PE
10019 * charset.c (load_charset_map): <, not <=, for optimization,
10020 and to avoid potential problems with integer overflow.
9248994d 10021 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10022 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10023 * editfns.c (Fformat): Likewise.
1e69125e 10024 * syntax.c (skip_chars): Likewise.
3befa583 10025
e3019616
PE
10026 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10027 This also lets GCC 4.6.0 generate slightly better loop code.
10028
becfa255
PE
10029 * callint.c (Fcall_interactively): <, not <=, for optimization.
10030 (Fcall_interactively): Count the number of arguments produced,
10031 not the number of arguments given. This is simpler and lets GCC
10032 4.6.0 generate slightly better code.
10033
dae0cd48
PE
10034 * ftfont.c: Distingish more carefully between FcChar8 and char.
10035 The previous code passed unsigned char * to a functions like
10036 strlen and xstrcasecmp that expect char *, which does not
10037 conform to the C standard.
10038 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10039 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10040 char * when the C standard requires it.
10041
76032d70
PE
10042 * keyboard.c (read_char): Remove unused var.
10043
eb3f1cc8
PE
10044 * eval.c: Port to Windows vsnprintf (Bug#8435).
10045 Include <limits.h>.
10046 (SIZE_MAX): Define if the headers do not.
10047 (verror): Do not give up if vsnprintf returns a negative count.
10048 Instead, grow the buffer. This ports to Windows vsnprintf, which
10049 does not conform to C99. Problem reported by Eli Zaretskii.
10050 Also, simplify the allocation scheme, by avoiding the need for
10051 calling realloc, and removing the ALLOCATED variable.
10052
70476b54
PE
10053 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10054
12020a9e
PE
10055 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10056 But keep the doprint source code for now, as we might revamp it
10057 and use it again (Bug#8435).
ea6c7ae6
PE
10058 * lisp.h (doprnt): Remove.
10059 * Makefile.in (base_obj): Remove doprnt.o.
10060 * deps.mk (doprnt.o): Remove.
10061
5fdb398c
PE
10062 error: Print 32- and 64-bit integers portably (Bug#8435).
10063 Without this change, on typical 64-bit hosts error ("...%d...", N)
10064 was used to print both 32- and 64-bit integers N, which relied on
10065 undefined behavior.
61bdb816 10066 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10067 * lisp.h (error, verror): Mark as printf-like functions.
10068 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10069 Report overflow in size calculations when allocating printf buffer.
10070 Do not truncate output string at its first null byte.
10071 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10072 Truncate the output at a character boundary, since vsnprintf does not
10073 do that.
10074 * charset.c (check_iso_charset_parameter): Convert internal
10075 character to string before calling 'error', since %c now has the
10076 printf meaning.
10077 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10078 overflow when computing char to be passed to 'error'. Do not
10079 pass Lisp_Object to 'error'; pass the integer instead.
10080 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10081 formatted with plain %d.
10082
b189fa66
PE
10083 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10084
bff87ef0
PE
10085 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10086
7e2cac20
PE
10087 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10088
ce4d90b5
PE
10089 * xterm.c (x_catch_errors): Remove duplicate declaration.
10090
266c9547
PE
10091 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10092
79c49ad2
PE
10093 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10094
368f4090
JM
100952011-04-10 Jim Meyering <meyering@redhat.com>
10096
10097 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10098 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10099 return ssize_t not "int", and use size_t as the buffer length.
10100 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10101 * gnutls.h: Update declarations.
10102 * process.c (read_process_output): Use ssize_t, to match.
10103 (send_process): Likewise.
10104
a32d4040
CY
101052011-04-09 Chong Yidong <cyd@stupidchicken.com>
10106
10107 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10108
8546720e 101092011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10110
04f2d78b
CB
10111 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10112 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10113
8546720e
GM
10114 * xterm.c (handle_one_xevent):
10115 * xmenu.c (create_and_show_popup_menu):
10116 * xselect.c (x_decline_selection_request)
10117 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10118
0a2f5c1a 101192011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10120
10121 Fix some uses of `int' instead of EMACS_INT.
10122 * search.c (string_match_1, fast_string_match)
10123 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10124 (scan_buffer, find_next_newline_no_quit)
10125 (find_before_next_newline, search_command, Freplace_match)
10126 (Fmatch_data): Make some `int' variables be EMACS_INT.
10127
10128 * xdisp.c (display_count_lines): 3rd argument and return value now
10129 EMACS_INT. All callers changed.
10130 (pint2hrstr): Last argument is now EMACS_INT.
10131
10132 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10133 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10134 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10135 (decode_coding_utf_16, decode_coding_emacs_mule)
10136 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10137 (decode_coding_ccl, decode_coding_charset)
10138 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10139 (decode_coding_iso_2022, decode_coding_emacs_mule)
10140 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10141 <char_offset, last_offset>: Declare EMACS_INT.
10142 (encode_coding_utf_8, encode_coding_utf_16)
10143 (encode_coding_emacs_mule, encode_invocation_designation)
10144 (encode_designation_at_bol, encode_coding_iso_2022)
10145 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10146 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10147 Declare EMACS_INT.
10148 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10149 (encode_invocation_designation): Last argument P_NCHARS is now
10150 EMACS_INT.
10151 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10152 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10153
10154 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10155 All users changed.
10156
10157 * ccl.c (Fccl_execute_on_string): Declare some variables
10158 EMACS_INT.
10159
8546720e 101602011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10161
10162 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10163
4e19a977
CS
101642011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10165
10166 * process.c (Fformat_network_address): Doc fix.
10167
87302331
R
101682011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10169
ee7683eb 10170 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10171
cbb59342
CY
101722011-04-08 Chong Yidong <cyd@stupidchicken.com>
10173
10174 * keyboard.c (read_char): Call Lisp function help-form-show,
10175 instead of using internal_with_output_to_temp_buffer.
10176 (Qhelp_form_show): New var.
e0d38eeb 10177 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10178
10179 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10180
10181 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10182
e67a13ab
CY
101832011-04-06 Chong Yidong <cyd@stupidchicken.com>
10184
04f2d78b
CB
10185 * process.c (Flist_processes): Remove to Lisp.
10186 (list_processes_1): Delete.
e67a13ab 10187
973f782d
EZ
101882011-04-06 Eli Zaretskii <eliz@gnu.org>
10189
7c106b1e
EZ
10190 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10191
973f782d
EZ
10192 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10193
41cf7d1a 101942011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10195
ca23cc88
PE
10196 Fix more problems found by GCC 4.6.0's static checks.
10197
f390e2d5
PE
10198 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10199
42eea0d0
PE
10200 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10201
b69769da 10202 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10203
f9541e84
PE
10204 * xdisp.c (vmessage): Mark as a printf-like function.
10205
13841b55
PE
10206 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10207
c136c10f
PE
10208 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10209
5e2d4a30
PE
10210 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10211 printf-like functions.
10212 (tiff_load): Add casts to remove these marks before passing them
10213 to system-supplied API.
10214
583f48b9
PE
10215 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10216
b25d760e
PE
10217 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10218 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10219 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10220 directly, rather than having caller test rule sign. This avoids
10221 some unnecessary tests.
10222 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10223 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10224 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10225
bc7b6697 10226 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10227 (xfont_open): Avoid unnecessary tests.
bc7b6697 10228
27ccc379
PE
10229 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10230
dcd5c89a
PE
10231 * composite.h, composite.c (composition_gstring_put_cache):
10232 Use EMACS_INT, not int, for length.
10233
b13a45c6
PE
10234 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10235 breaking out part of COMPOSITION_DECODE_RULE.
10236 (COMPOSITION_DECODE_RULE): Use it.
10237 * composite.c (get_composition_id): Remove unused local vars,
10238 by using the new macro.
10239
1e792e4d
PE
10240 * textprop.c (set_text_properties_1): Change while to do-while,
10241 since the condition is always true at first.
10242
dc6c6455 10243 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10244 (interval_deletion_adjustment): Return unsigned value.
10245 All uses changed.
dc6c6455 10246
aba7731a
PE
10247 * process.c (list_processes_1, create_pty, read_process_output):
10248 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10249 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10250 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10251 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10252 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10253
fdfc4bf3
PE
10254 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10255
fca8fe46 10256 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10257 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10258
06a0259a 10259 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10260 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10261 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10262
e7b9e80f
PE
10263 * print.c (print_error_message): Avoid int overflow.
10264
56201685
PE
10265 * font.c (font_list_entities): Redo for clarity,
10266 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10267
78834453 10268 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10269 (font_score): Avoid potential overflow in diff calculation.
78834453 10270
0bc0b309 10271 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10272 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10273
e610eaca
PE
10274 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10275
b895abce
PE
10276 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10277 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10278 can always succeed if overflow has undefined behavior.
10279
1f1d9321 10280 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10281 (wordify): Omit three unnecessary tests.
1f1d9321 10282
c59478bc
PE
10283 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10284 All callers changed. This avoids the need for an unused var.
10285
79b73827
PE
10286 * casefiddle.c (casify_region): Remove var that is set but not used.
10287
a4db5dfe
PE
10288 * dired.c (file_name_completion): Remove var that is set but not used.
10289
43aae36e
PE
10290 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10291
2a47c44d 10292 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10293 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10294
a37c69bf
PE
10295 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10296 Check for integer overflow on size calculations.
10297
328ab8e7
PE
10298 * buffer.c (Fprevious_overlay_change): Remove var that is set
10299 but not used.
10300
e5a2a5cb
PE
10301 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10302 Remove vars that are set but not used.
8d84a6eb 10303 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10304 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10305
a60e5f68
PE
10306 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10307
f661cb61 10308 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10309 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10310
f0397f5a
PE
10311 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10312 that are set but not used.
10313
8664db06 10314 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10315 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10316
6abdaa4a
PE
10317 * xselect.c (x_get_local_selection, x_handle_property_notify):
10318 Remove vars that are set but not used.
10319
0ce7538d 10320 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10321 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10322
9ae848fc
PE
10323 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10324 Remove var that is set but not used.
0b918413
PE
10325 (scroll_bar_windows_size): Now size_t, not int.
10326 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10327 Check for overflow.
9ae848fc 10328
a5a62657
PE
10329 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10330 (map_tty_color) [!defined MSDOS]: Likewise.
10331
5c5cdd39
PE
10332 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10333
66ebf983
PE
10334 * coding.c: Remove vars that are set but not used.
10335 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10336 All callers changed.
10337 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10338 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10339 (decode_coding_charset): Remove vars that are set but not used.
10340
1be4d761
PE
10341 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10342 that is set but not used.
10343
47553fa8
PE
10344 * print.c (print_object): Remove var that is set but not used.
10345
1f7196bf 10346 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10347 The gnulib version avoids calling malloc in the usual case,
10348 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10349 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10350 * filelock.c (current_lock_owner): Likewise.
10351 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10352 * sysdep.c: Include allocator.h, careadlinkat.h.
10353 (emacs_no_realloc_allocator): New static constant.
10354 (emacs_readlink): New function.
fdb61804
PE
10355 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10356 ../lib/careadlinkat.h.
d1fdcab7 10357
f84c17c7
SM
103582011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10359
10360 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10361 first non-nil return value).
10362
ef3862ad
JD
103632011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10364
10365 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10366 if not defined (Bug#8403).
10367
376a7006
JB
103682011-04-02 Juanma Barranquero <lekktu@gmail.com>
10369
10370 * xdisp.c (display_count_lines): Remove parameter `start',
10371 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10372 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10373 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10374 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10375 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10376 and thereabouts. All callers changed.
10377 (get_per_char_metric): Remove parameter `f', unused since
10378 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10379
6ca3801d
JM
103802011-04-02 Jim Meyering <meyering@redhat.com>
10381
10382 do not dereference NULL upon failed strdup
10383 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10384 (ns_get_family): Likewise.
10385
d8e2b5ba
JB
103862011-04-02 Juanma Barranquero <lekktu@gmail.com>
10387
10388 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10389
8c74fcbd
JD
103902011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10391
10392 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10393 later (Bug#8403).
10394
7200d79c
SM
103952011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10396
03408648 10397 Add lexical binding.
7200d79c 10398
03408648
SM
10399 * window.c (Ftemp_output_buffer_show): New fun.
10400 (Fsave_window_excursion):
10401 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10402
10403 * lread.c (lisp_file_lexically_bound_p): New function.
10404 (Fload): Bind Qlexical_binding.
10405 (readevalloop): Remove `evalfun' arg.
10406 Bind Qinternal_interpreter_environment.
10407 (Feval_buffer): Bind Qlexical_binding.
10408 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10409 Mark as dynamic.
10410 (syms_of_lread): Declare `lexical-binding'.
10411
10412 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10413
10414 * keyboard.c (eval_dyn): New fun.
10415 (menu_item_eval_property): Use it.
ca105506
SM
10416
10417 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10418
03408648
SM
10419 * fns.c (concat, mapcar1): Accept byte-code-functions.
10420
10421 * eval.c (Fsetq): Handle lexical vars.
10422 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10423 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10424 (FletX, Flet): Obey lexical binding.
10425 (Fcommandp): Handle closures.
10426 (Feval): New `lexical' arg.
10427 (eval_sub): New function extracted from Feval. Use it almost
10428 everywhere where Feval was used. Look up vars in lexical env.
10429 Handle closures.
10430 (Ffunctionp): Move from subr.el.
10431 (Ffuncall): Handle closures.
10432 (apply_lambda): Remove `eval_flags'.
10433 (funcall_lambda): Handle closures and new byte-code-functions.
10434 (Fspecial_variable_p): New function.
10435 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10436 but without exporting it to Lisp.
23aba0ea 10437
23aba0ea 10438 * doc.c (Fdocumentation, store_function_docstring):
03408648 10439 * data.c (Finteractive_form): Handle closures.
23aba0ea 10440
03408648
SM
10441 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10442 interactive spec.
ba83908c 10443
04f2d78b
CB
10444 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10445 New byte-codes.
03408648
SM
10446 (exec_byte_code): New function extracted from Fbyte_code to handle new
10447 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10448
03408648 10449 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10450
03408648 10451 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10452
e2abce01
JB
104532011-03-31 Juanma Barranquero <lekktu@gmail.com>
10454
10455 * xdisp.c (redisplay_internal): Fix prototype.
10456
63696a73 104572011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10458
63696a73 10459 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10460 (try_scrolling): Use it when setting scroll_limit.
10461 Limit scrolling to 100 screen lines.
63696a73
EZ
10462 (redisplay_window): Even when falling back on "recentering",
10463 position point in the window according to scroll-conservatively,
10464 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10465
10466 (try_scrolling): When point is above the window, allow searching
10467 as far as scroll_max, or one screenful, to compute vertical
10468 distance from PT to the scroll margin position. This prevents
10469 try_scrolling from unnecessarily failing when
10470 scroll-conservatively is set to a value slightly larger than the
10471 window height. Clean up the case of PT below the margin at bottom
10472 of window: scroll_max can no longer be INT_MAX. When aggressive
10473 scrolling is in use, don't let point enter the opposite scroll
10474 margin as result of the scroll.
10475 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10476 threshold of 100 lines for never-recentering scrolling.
10477
e4cc2dfc
JB
104782011-03-31 Juanma Barranquero <lekktu@gmail.com>
10479
10480 * dispextern.h (move_it_by_lines):
10481 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10482 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10483 (message_log_check_duplicate): Remove parameters `prev_bol' and
10484 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10485 (redisplay_internal): Remove parameter `preserve_echo_area',
10486 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10487
10488 * indent.c (Fvertical_motion):
10489 * window.c (window_scroll_pixel_based, Frecenter):
10490 Don't pass `need_y_p' to `move_it_by_lines'.
10491
1c470562
SM
104922011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10493
44f230aa
SM
10494 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10495 steal a few bits to be more compact.
10496 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10497 Remove unneeded casts.
10498
1c470562
SM
10499 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10500
888adce9
ZK
105012011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10502
10503 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10504 binding" message (bug#7967).
10505
f838ed7b
PE
105062011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10507
77861b95
PE
10508 Fix more problems found by GCC 4.6.0's static checks.
10509
de6dbc14
PE
10510 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10511 Remove unused local var.
10512
f838ed7b
PE
10513 * editfns.c (Fmessage_box): Remove unused local var.
10514
792c7b2b
PE
10515 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10516 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10517 Omit unused local vars.
c499e557 10518 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10519 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10520 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10521 Omit unused local var.
10522
ba0165e1
PE
10523 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10524 Don't assume string length fits in int.
32ad8845 10525 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10526 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10527
3c59b4c9
PE
10528 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10529 instead of alloca (Bug#8344).
10530
a3eed478 10531 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10532 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10533
eb4d412d
PE
10534 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10535
1658b401
PE
10536 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10537 concerns.
10538
10539 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10540
10541 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10542
9a2c6e05
PE
10543 * keyboard.c (syms_of_keyboard): Use the same style as later
10544 in this function when indexing through an array. This also
10545 works around GCC bug 48267.
10546
03d0a109
PE
10547 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10548
44f730c8
PE
10549 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10550
fe75f926
PE
10551 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10552 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10553
ffa8c828
PE
10554 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10555 This avoids undefined behavior on integer overflow, and is a bit
10556 more convenient anyway since it is compared to a size_t variable.
10557
c5101a77
PE
10558 Variadic C functions now count arguments with size_t, not int.
10559 This avoids an unnecessary limitation on 64-bit machines, which
10560 caused (substring ...) to crash on large vectors (Bug#8344).
10561 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10562 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10563 All variadic functions and their callers changed accordingly.
c5101a77
PE
10564 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10565 * data.c (arith_driver, float_arith_driver): Likewise.
10566 * editfns.c (general_insert_function): Likewise.
10567 * eval.c (struct backtrace.nargs, interactive_p)
10568 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10569 (funcall_lambda, mark_backtrace): Likewise.
10570 * fns.c (concat): Likewise.
10571 * frame.c (x_set_frame_parameters): Likewise.
10572 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10573 0 if not found, not -1. All callers changed.
10574
dd3f25f7
PE
10575 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10576 (stack_copy_size): Now size_t, not int.
10577 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10578
461c2ab9
JB
105792011-03-28 Juanma Barranquero <lekktu@gmail.com>
10580
10581 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10582 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10583 All callers changed.
10584
10585 * lisp.h (multibyte_char_to_unibyte):
10586 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10587 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10588 * character.h (CHAR_TO_BYTE8):
10589 * cmds.c (internal_self_insert):
10590 * editfns.c (general_insert_function):
10591 * keymap.c (push_key_description):
10592 * search.c (Freplace_match):
10593 * xdisp.c (message_dolog, set_message_1): All callers changed.
10594
f6d62986
SM
105952011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10596
10597 * keyboard.c (safe_run_hook_funcall): New function.
10598 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10599 don't set the hook to nil, but remove the offending function instead.
10600 (Qcommand_hook_internal): Remove, unused.
10601 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10602 Vcommand_hook_internal.
10603
10604 * eval.c (enum run_hooks_condition): Remove.
10605 (funcall_nil, funcall_not): New functions.
10606 (run_hook_with_args): Call each function through a `funcall' argument.
10607 Remove `cond' argument, now redundant.
10608 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10609 (Frun_hook_with_args_until_failure): Adjust accordingly.
10610 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10611
1db5b1ad
JB
106122011-03-28 Juanma Barranquero <lekktu@gmail.com>
10613
10614 * dispextern.h (string_buffer_position): Remove declaration.
10615
10616 * print.c (strout): Remove parameter `multibyte', unused since
10617 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10618
10619 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10620 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10621 All callers changed.
10622
10623 * w32.c (_wsa_errlist): Use braces for struct initializers.
10624
10625 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10626 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10627 All callers changed.
10628 (string_buffer_position): Likewise. Also, make static (it's never
10629 used outside xdisp.c).
10630 (cursor_row_p): Remove parameter `w', unused since
10631 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10632 (decode_mode_spec): Remove parameter `precision', introduced during
10633 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10634 All callers changed.
10635
5ffb62aa
JD
106362011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10637
10638 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10639
461c2ab9 106402011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10641
10642 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10643 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10644 (ns_update_auto_hide_menu_bar): New functions.
10645 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10646 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10647 ns_constrain_all_frames.
10648 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10649 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10650
5c380ffb
JD
106512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10652
10653 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10654
9af30bdf
GM
106552011-03-27 Glenn Morris <rgm@gnu.org>
10656
10657 * syssignal.h: Replace RETSIGTYPE with void.
10658 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10659 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10660 Replace SIGTYPE with void everywhere.
10661 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10662 * s/template.h (SIGTYPE): Remove commented out definition.
10663
e2abce01
JB
106642011-03-26 Eli Zaretskii <eliz@gnu.org>
10665
10666 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10667 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10668
f868cd8a
JB
106692011-03-26 Juanma Barranquero <lekktu@gmail.com>
10670
59eb0929
JB
10671 * w32.c (read_unc_volume): Use parameter `henum', instead of
10672 global variable `wget_enum_handle'.
10673
10674 * keymap.c (describe_vector): Remove parameters `indices' and
10675 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10676 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10677
f868cd8a
JB
10678 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10679
10680 * keyboard.c (timer_check): Remove parameter `do_it_now',
10681 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10682 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10683 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10684
10685 * keyboard.c (read_char):
10686 * w32menu.c (w32_menu_display_help):
10687 * xmenu.c (show_help_event, menu_help_callback):
10688 Adjust calls to `show_help_echo'.
10689
10690 * gtkutil.c (xg_maybe_add_timer):
10691 * keyboard.c (readable_events):
10692 * process.c (wait_reading_process_output):
10693 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10694
10695 * insdel.c (adjust_markers_gap_motion):
10696 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10697 (gap_left, gap_right): Don't call it.
10698
2ecf6fdb
CY
106992011-03-25 Chong Yidong <cyd@stupidchicken.com>
10700
10701 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10702 incurred during fontification.
10703
6b1f9ba4
JB
107042011-03-25 Juanma Barranquero <lekktu@gmail.com>
10705
10706 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10707 (DEFVAR_PER_BUFFER): Don't pass it.
10708
10709 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10710 (scrolling_window): Don't pass it.
10711
0f4a96b5
JB
107122011-03-25 Juanma Barranquero <lekktu@gmail.com>
10713
10714 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10715
10716 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10717 and `suffix'.
10718 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10719 of variables specific to SELinux and computation of `encoded_absname'.
10720
10721 * image.c (XPutPixel): Remove unused variable `height'.
10722
10723 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10724
10725 * unexw32.c (get_section_info): Remove unused variable `section'.
10726
10727 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10728 (system_process_attributes): Remove unused variable `sess'.
10729 (sys_read): Remove unused variable `err'.
10730
10731 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10732 (w32_wnd_proc): Remove unused variable `isdead'.
10733 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10734 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10735 (x_create_tip_frame): Remove unused variable `tem'.
10736
10737 * w32inevt.c (w32_console_read_socket):
10738 Remove unused variable `no_events'.
10739
10740 * w32term.c (x_draw_composite_glyph_string_foreground):
10741 Remove unused variable `width'.
10742
1149507c
JB
107432011-03-24 Juanma Barranquero <lekktu@gmail.com>
10744
10745 * w32term.c (x_set_glyph_string_clipping):
10746 Don't pass uninitialized region to CombineRgn.
10747
9c88f339
JB
107482011-03-23 Juanma Barranquero <lekktu@gmail.com>
10749
10750 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10751 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10752 (Fx_close_connection): Remove unused variable `i'.
10753
10754 * w32font.c (w32font_draw): Return number of glyphs.
10755 (w32font_open_internal): Remove unused variable `i'.
10756 (w32font_driver): Add missing initializer.
10757
10758 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10759 (fill_in_menu): Remove unused variable `items_added'.
10760
10761 * w32term.c (last_mouse_press_frame): Remove static global variable.
10762 (w32_clip_to_row): Remove unused variable `f'.
10763 (x_delete_terminal): Remove unused variable `i'.
10764
10765 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10766 (NOTHING): Remove unused static global variable.
10767 (uniscribe_check_otf): Remove unused variable `table'.
10768 (uniscribe_font_driver): Add missing initializers.
10769
dee091a3
JD
107702011-03-23 Julien Danjou <julien@danjou.info>
10771
10772 * term.c (Fsuspend_tty, Fresume_tty):
10773 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10774 * window.c (temp_output_buffer_show):
10775 * insdel.c (signal_before_change):
10776 * frame.c (Fhandle_switch_frame):
10777 * fileio.c (Fdo_auto_save):
10778 * emacs.c (Fkill_emacs):
10779 * editfns.c (save_excursion_restore):
10780 * cmds.c (internal_self_insert):
10781 * callint.c (Fcall_interactively):
10782 * buffer.c (Fkill_all_local_variables):
10783 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10784 Use Frun_hooks.
0f4a96b5 10785 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10786 unconditionally since it does the check itself.
dee091a3 10787
2c520ab5 107882011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10789
c9c49752
PE
10790 Fix more problems found by GCC 4.5.2's static checks.
10791
8abc3f12
PE
10792 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10793 the first time through the loop, since we know p0 < p1 then.
10794 This also avoids a gcc -Wstrict-overflow warning.
10795
a2d26660
PE
10796 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10797 leading to a memory leak, possible in functions like
10798 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10799 of objects (Bug#8318).
a2d26660 10800
916c72e9
PE
10801 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10802 that could (at least in theory) be that large.
10803
19ab8a18
PE
10804 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10805 This is less likely to overflow, and avoids undefined behavior if
10806 overflow does occur. All callers changed. Use strtoul to scan
10807 for the unsigned long integer.
b7cbbd6f
PE
10808 (pint2hrstr): Simplify and tune code slightly.
10809 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10810
f0641eff
PE
10811 * scroll.c (do_scrolling): Work around GCC bug 48228.
10812 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10813
7f650bb9
PE
10814 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10815 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10816 (validate_x_resource_name): Simplify count usage.
10817 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10818
37dd57d1
PE
10819 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10820 fail (Bug#8306).
81e56e61 10821
699979fc 10822 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10823
401bf9b4
PE
10824 * process.c (Fmake_network_process): Use socklen_t, not int,
10825 where POSIX says socklen_t is required in portable programs.
10826 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10827 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10828 (Fmake_network_process, server_accept_connection):
10829 (wait_reading_process_output, read_process_output):
10830 Likewise.
10831
b93aacde
PE
10832 * process.c: Rename or move locals to avoid shadowing.
10833 (list_processes_1, Fmake_network_process):
10834 (read_process_output_error_handler, exec_sentinel_error_handler):
10835 Rename or move locals.
4dc343ee 10836 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10837 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10838 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10839 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10840 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10841
af8a867c 10842 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10843 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10844 Include tparam.h instead, since it declares them.
af8a867c
PE
10845 * cm.h (PC): Remove extern decl; tparam.h now does this.
10846 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10847 * terminfo.c: Include tparam.h, to check interfaces.
10848 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10849 (tparam): Adjust signature to match interface in tparam.h;
10850 this removes some undefined behavior. Check that outstring and len
10851 are zero, which they always are with Emacs.
10852 * tparam.h (PC, BC, UP): New extern decls.
10853
0248044d 10854 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10855 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10856
8ff096c1 10857 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10858 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10859 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10860 (ftfont_list): Remove unused local.
49eaafba
PE
10861 (get_adstyle_property, ftfont_pattern_entity):
10862 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10863 Rename locals to avoid shadowing.
8ff096c1 10864
e2be39f6
PE
10865 * xfont.c (xfont_list_family): Mark var as initialized.
10866
c9735e30
PE
10867 * xml.c (make_dom): Now static.
10868
8f5201ae
PE
10869 * composite.c (composition_compute_stop_pos): Rename local to
10870 avoid shadowing.
b246f932
PE
10871 (composition_reseat_it): Remove unused locals.
10872 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10873 (composition_update_it): Mark var as initialized.
11b61122
PE
10874 (find_automatic_composition): Mark vars as initialized,
10875 with a FIXME (Bug#8290).
8f5201ae 10876
760fbc2c
PE
10877 character.h: Rename locals to avoid shadowing.
10878 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10879 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10880 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10881 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10882 to avoid shadowing.
10883
ff08eb85
PE
10884 * textprop.c (property_change_between_p): Remove; unused.
10885
fc7bf025
PE
10886 * intervals.c (interval_start_pos): Now static.
10887
235d7abc
PE
10888 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10889
44f230aa
SM
10890 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10891 Rename locals to avoid shadowing.
3e7d6594 10892
50060332
PE
10893 * sound.c (wav_play, au_play, Fplay_sound_internal):
10894 Fix pointer signedness.
d01f234b 10895 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10896 (wav_play): Initialize a variable to 0, to prevent undefined
10897 behavior (Bug#8278).
50060332 10898
c4fc4e30
PE
10899 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10900
918436ed
PE
10901 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10902
c939f91b
PE
10903 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10904 clobbering (Bug#8298).
b9c7f648
PE
10905 * sysdep.c (sys_subshell): Likewise.
10906 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10907
6bd8c144
PE
10908 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10909 This should get cleaned up, so that child_setup has the
10910 same signature on all platforms.
10911
7710357c 10912 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10913 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10914
c59da222
CY
109152011-03-22 Chong Yidong <cyd@stupidchicken.com>
10916
10917 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10918 not to be necessary, and produces flickering.
10919
66b87493
GM
109202011-03-20 Glenn Morris <rgm@gnu.org>
10921
10922 * config.in: Remove file.
10923
45b6f6d5
JB
109242011-03-20 Juanma Barranquero <lekktu@gmail.com>
10925
10926 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10927 are now in src/globals.h.
10928 (syms_of_minibuf): Remove spurious & from previous change.
10929
cd394be1 109302011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10931
10932 * minibuf.c (completing-read-function): New variable.
10933 (completing-read-default): Rename from completing-read.
10934 (completing-read): Call completing-read-function.
10935
b14e3e21
CY
109362011-03-19 Juanma Barranquero <lekktu@gmail.com>
10937
10938 * xfaces.c (Fx_load_color_file):
10939 Read color file from absolute filename (bug#8250).
10940
f2b726e6
JB
109412011-03-19 Juanma Barranquero <lekktu@gmail.com>
10942
10943 * makefile.w32-in: Update dependencies.
10944
09f6ff02
EZ
109452011-03-17 Eli Zaretskii <eliz@gnu.org>
10946
10947 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10948
29a6015a
PE
109492011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10950
a3a6c54e
PE
10951 Fix more problems found by GCC 4.5.2's static checks.
10952
b766f867
PE
10953 * process.c (make_serial_process_unwind, send_process_trap):
10954 (sigchld_handler): Now static.
10955
be02381c
PE
10956 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10957 That way, the code declares only the vars that it needs.
10958 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10959 * s/cygwin.h (PTY_ITERATION): Likewise.
10960 * s/darwin.h (PTY_ITERATION): Likewise.
10961 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10962
57048744
PE
10963 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10964 * process.c (allocate_pty): Don't declare stb unless it's needed.
10965
7914961c 10966 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
10967 (CONSTANTLIM): Remove; unused.
10968 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10969 Define only if needed.
7914961c 10970
b3967b18
PE
10971 * unexelf.c (unexec): Name an expression,
10972 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
10973 Use a different way to cause a compilation error if anyone uses
10974 n rather than nn, a way that does not involve shadowing.
73366a00 10975 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 10976
29a6015a
PE
10977 * deps.mk (unexalpha.o): Remove; unused.
10978
43cfc33e 10979 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 10980 * unexec.h: New file.
ce701a33
PE
10981 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10982 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10983 Depend on unexec.h.
10984 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10985 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10986 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 10987 Change as necessary to match prototype in unexec.h.
ce701a33 10988
01f44d5a
PE
10989 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10990 shadowing.
4f63c6bb 10991 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 10992
a6670b0b
PE
10993 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10994 Rename locals to avoid shadowing.
10995
cef2010d 10996 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 10997 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 10998
d4d7173a
PE
10999 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11000
f08b802a
PE
11001 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11002 warning when compiling print.c.
11003
3ddb0639
PE
11004 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11005 instead of using an uninitialized var.
5ad03b97 11006 (font_sort_entities): Mark var as initialized.
3ddb0639 11007
170a2692
PE
11008 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11009
e663c700
PE
11010 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11011 pointers to constants.
89bc529a 11012 (font_parse_fcname): Remove unused vars.
7b81e2d0 11013 (font_delete_unmatched): Now static.
ea838e10 11014 (font_get_spec): Remove; unused.
13a547c6
PE
11015 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11016 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11017 Rename or move locals to avoid shadowing.
e663c700 11018
2a80c887 11019 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11020 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11021
1384fa33 11022 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11023 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11024
8b2c52e9
PE
11025 * alloc.c (mark_backtrace): Move decl from here ...
11026 * lisp.h: ... to here, so that it can be checked.
11027
475545b5 11028 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11029 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11030 (lisp_indirect_variable): Name an expression,
11031 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11032 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11033
b1349114 11034 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11035 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11036 Use const pointer when appropriate.
b1349114 11037
a2928364
PE
11038 * lisp.h (get_system_name, get_operating_system_release):
11039 Move decls here, to check interfaces.
11040 * process.c (get_operating_system_release): Move decl to lisp.h.
11041 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11042 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11043 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11044 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11045 (Fformat_time_string, Fencode_time, Finsert_char):
11046 (Ftranslate_region_internal, Fformat):
11047 Rename or remove local vars to avoid shadowing.
9710023e 11048 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11049
a415e694
PE
11050 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11051 avoid shadowing.
11052
8ef4622d
PE
11053 * lisp.h (eassert): Check that the argument compiles, even if
11054 ENABLE_CHECKING is not defined.
11055
946f9a5b
PE
11056 * data.c (Findirect_variable): Name an expression, to avoid
11057 gcc -Wbad-function-cast warning.
112396d6 11058 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11059 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11060 (Fmake_variable_buffer_local, Fmake_local_variable):
11061 Mark variables as initialized.
52746918 11062 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11063
e5aab7e7 11064 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11065 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11066 Rename locals to avoid shadowing.
dff45157
PE
11067 (mark_stack): Move local variables into the #ifdef region where
11068 they're used.
7bc26fdb
PE
11069 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11070 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11071 needed otherwise.
11072 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11073 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11074 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11075
e5aab7e7
PE
11076 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11077 avoids undefined behavior in theory.
11078
4da60324
PE
11079 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11080
88043301
PE
11081 Use functions, not macros, for up- and down-casing (Bug#8254).
11082 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11083 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11084 to use the following functions instead of these macros.
11085 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11086 EMACS_INT, since callers assume the returned value fits in int.
11087 (upcase1): Likewise, for UPCASE_TABLE.
11088 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11089 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11090 the race-condition problem in the old DOWNCASE.
88043301 11091
19ed5445
PE
11092 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11093 Rename locals to avoid shadowing.
11094 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11095 (regex_compile, re_search_2, re_match_2_internal):
11096 Remove unused local vars.
952db0d7
PE
11097 (FREE_VAR): Rewrite so as not to use empty "else",
11098 which gcc can warn about.
da053e48 11099 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11100 (RETALLOC_IF): Define only if needed.
11101 (WORDCHAR_P): Likewise. This one is never needed, but is used
11102 only in a comment talking about a compiler bug, so put inside
11103 the #if 0 of that comment.
11104 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11105 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11106 Remove; unused.
19ed5445 11107
1f3561e4 11108 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11109 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11110 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11111
ded6f8f7
PE
11112 * search.c (simple_search): Remove unused var.
11113
dbd37a95
PE
11114 * dired.c (compile_pattern): Move decl from here ...
11115 * lisp.h: ... to here, so that it can be checked.
11116 (struct re_registers): New forward decl.
11117
7e47afad
PE
11118 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11119
85f24f61
PE
11120 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11121 All uses changed.
11122 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11123 Rename locals to avoid shadowing.
5671df8f 11124 (Fvertical_motion): Mark locals as initialized.
85f24f61 11125
181aa2be 11126 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11127 (casify_region): Mark local as initialized.
181aa2be 11128
930d429c
PE
11129 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11130
7082eac6
PE
11131 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11132 New macros, so that the caller can use some names other than
11133 gcpro1, gcpro2, etc.
11134 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11135 of the new macros.
11136 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11137 argument, for consistency with GCPRO2_VAR, etc: it is now the
11138 prefix of the variable, not the variable itself. All uses
11139 changed.
38b2c076
PE
11140 * dired.c (directory_files_internal, file_name_completion):
11141 Rename locals to avoid shadowing.
11142
15206ed9
PE
11143 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11144 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11145 dired.c's scmp function, had undefined behavior.
11146 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11147 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11148 * buffer.h: ... to here, because these macros use current_buffer,
11149 and the new implementation with inline functions needs to have
11150 current_buffer in scope now, rather than later when the macros
11151 are used.
11152 (downcase, upcase1): New static inline functions.
11153 (DOWNCASE, UPCASE1): Reimplement using these functions.
11154 This avoids undefined behavior in expressions like
11155 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11156 from race conditions in accessing the global variables
11157 case_temp1 and case_temp2.
11158 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11159 * lisp.h (case_temp1, case_temp2): Remove their decls.
11160 * character.h (ASCII_CHAR_P): Move from here ...
11161 * lisp.h: ... to here, so that the inline functions mentioned
11162 above can use them.
11163
4a6bea26
PE
11164 * dired.c (directory_files_internal_unwind): Now static.
11165
f14b7e14
PE
11166 * fileio.c (file_name_as_directory, directory_file_name):
11167 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11168 Now static.
2893f146
PE
11169 (file_name_as_directory): Use const pointers when appropriate.
11170 (Fexpand_file_name): Likewise. In particular, newdir might
11171 point at constant storage, so make it a const pointer.
fd4ead52 11172 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11173 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11174 signedness issues.
f839df0c
PE
11175 (Fset_file_times, Finsert_file_contents, auto_save_error):
11176 Rename locals to avoid shadowing.
f14b7e14 11177
5716756e 11178 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11179 (Ftry_completion, Fall_completions): Rename or remove locals
11180 to avoid shadowing.
5716756e 11181
b4c3046a
PE
11182 * marker.c (bytepos_to_charpos): Remove; unused.
11183
b45db522
PE
11184 * lisp.h (verify_bytepos, count_markers): New decls,
11185 so that gcc does not warn that these functions aren't declared.
11186
85876d07
PE
11187 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11188 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11189 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11190 (copy_text): Remove unused local var.
85876d07 11191
03d78a21 11192 * filelock.c (within_one_second): Now static.
b3dd38ab 11193 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11194
5df8f01b
PE
11195 * buffer.c (fix_overlays_before): Mark locals as initialized.
11196 (fix_start_end_in_overlays): Likewise. This function should be
11197 simplified by using pointers-to-pointers, but that's a different
11198 matter.
b1d876f1 11199 (switch_to_buffer_1): Now static.
8f54f30a
PE
11200 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11201 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11202
a70072c9 11203 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11204 Fix pointer signedness issue.
edced198
PE
11205 (sys_subshell): Mark local as volatile if checking for lint,
11206 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11207 (MAXPATHLEN): Define only if needed.
a70072c9 11208
a0977c44
PE
11209 * process.c (serial_open, serial_configure): Move decls from here ...
11210 * systty.h: ... to here, so that they can be checked.
11211
a884fdcc
PE
11212 * fns.c (get_random, seed_random): Move extern decls from here ...
11213 * lisp.h: ... to here, so that they can be checked.
11214
604efe86 11215 * sysdep.c (reset_io): Now static.
b8950c94 11216 (wait_for_termination_signal): Remove; unused.
604efe86 11217
38fc62d9
PE
11218 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11219 (copy_keymap_item, append_key, push_text_char_description):
11220 Now static.
1004a21a 11221 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11222 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11223 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11224 (describe_map_tree):
11225 Rename locals to avoid shadowing.
38fc62d9 11226
2f2650da
PE
11227 * keyboard.c: Declare functions static if they are not used elsewhere.
11228 (echo_char, echo_dash, cmd_error, top_level_2):
11229 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11230 (read_char, kbd_buffer_get_event, make_lispy_position):
11231 (make_lispy_event, make_lispy_movement, apply_modifiers):
11232 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11233 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11234 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11235 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11236 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11237
a053e86c 11238 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11239 (mark_kboards): Move decl here ...
11240 * alloc.c (mark_kboards): ... from here.
a053e86c 11241
4752793e
PE
11242 * lisp.h (force_auto_save_soon): New decl.
11243
74f10ca7 11244 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11245 (DEFINE_DUMMY_FUNCTION): New macro.
11246 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11247 Use it.
c03cd23f
PE
11248 (main): Add casts to avoid warnings
11249 if GCC considers string literals to be constants.
74f10ca7 11250
022e70d4
PE
11251 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11252
59d6fe83
PE
11253 * dbusbind.c: Pointer signedness fixes.
11254 (xd_signature, xd_append_arg, xd_initialize):
11255 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11256 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11257 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11258 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11259
78320123
PE
11260 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11261 if GCC considers string literals to be constants.
49cebcca 11262 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11263
35ac2a97
SM
112642011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11265
fb103ca9
SM
11266 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11267 (print_preprocess, print_object): New macro to fix last change.
11268
35ac2a97
SM
11269 * print.c (print_preprocess): Don't forget font objects.
11270
62973b41
JB
112712011-03-16 Juanma Barranquero <lekktu@gmail.com>
11272
11273 * emacs.c (USAGE3): Doc fixes.
11274
0e48bb22
AS
112752011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11276
11277 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11278 structure.
11279
7684e57b
JB
112802011-03-14 Juanma Barranquero <lekktu@gmail.com>
11281
11282 * lisp.h (VWindow_system, Qfile_name_history):
11283 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11284 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11285 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11286
11287 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11288 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11289
11290 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11291 * w32console.c (detect_input_pending, read_input_pending)
11292 (encode_terminal_code):
11293 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11294 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11295 (w32_system_caret_y, Qfile_name_history):
11296 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11297 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11298 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11299 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11300 * w32proc.c (Qlocal, report_file_error):
11301 * w32term.c (Vwindow_system, updating_frame):
11302 * w32uniscribe.c (initialized, uniscribe_font_driver):
11303 Remove unneeded extern declarations.
11304
2aa46d6c
CY
113052011-03-14 Chong Yidong <cyd@stupidchicken.com>
11306
c96bbc66 11307 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11308
cffc6f3b
CY
113092011-03-13 Chong Yidong <cyd@stupidchicken.com>
11310
11311 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11312 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11313 These macros can no longer be used for assignment.
11314
44f230aa
SM
11315 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11316 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11317 (record_buffer_markers, fetch_buffer_markers): New functions for
11318 recording and fetching special buffer markers.
11319 (set_buffer_internal_1, set_buffer_temp): Use them.
11320
11321 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11322
11323 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11324
11325 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11326 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11327
11328 * xdisp.c (hscroll_window_tree):
11329 (reconsider_clip_changes): Use PT instead of BUF_PT.
11330
d251f04b
EZ
113312011-03-13 Eli Zaretskii <eliz@gnu.org>
11332
11333 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11334 $(EMACS_ROOT)/lib/intprops.h.
11335
f0c77cd1
PE
113362011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11337
3eca4629
PE
11338 Fix more problems found by GCC 4.5.2's static checks.
11339
7c86ee98
PE
11340 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11341 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11342 (xg_free_frame_widgets): Make it clear that a local variable is
11343 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11344 (gdk_window_get_screen): Make it clear that this macro is needed
11345 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11346 (int_gtk_range_get_value): New function, which avoids a diagnostic
11347 from gcc -Wbad-function-cast.
11348 (xg_set_toolkit_scroll_bar_thumb): Use it.
11349 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11350 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11351 (get_utf8_string, xg_get_file_with_chooser):
11352 Rename locals to avoid shadowing.
11353 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11354
41729b81
PE
11355 * xgselect.c (xg_select): Remove unused var.
11356
f0c77cd1
PE
11357 * image.c (four_corners_best): Mark locals as initialized.
11358 (gif_load): Initialize transparent_p to zero (Bug#8238).
11359 Mark another local as initialized.
ec6cf4c6 11360 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11361
ce0ad53d 11362 * image.c (clear_image_cache): Now static.
d5d5a617 11363 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11364 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11365 (x_edge_detection): Remove unnecessary cast that
11366 gcc -Wbad-function-cast diagnoses.
2037898d 11367 (gif_load): Fix pointer signedness.
6ae141d6
PE
11368 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11369 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11370
33383987 113712011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11372
d32df629
PE
11373 Improve quality of tests for time stamp overflow.
11374 For example, without this patch (encode-time 0 0 0 1 1
11375 1152921504606846976) returns the obviously-bogus value (-948597
11376 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11377 reports time overflow. See
11378 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11379 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11380 * editfns.c: Include limits.h and intprops.h.
11381 (TIME_T_MIN, TIME_T_MAX): New macros.
11382 (time_overflow): Move earlier, to before first use.
11383 (hi_time, lo_time): New functions, for an accurate test for
11384 out-of-range times.
11385 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11386 (Fget_internal_run_time): Don't assume time_t fits in int.
11387 (make_time): Use list2 instead of Fcons twice.
11388 (Fdecode_time): More accurate test for out-of-range times.
11389 (check_tm_member): New function.
11390 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11391 (lisp_time_argument): Don't rely on undefined left-shift and
11392 right-shift behavior when checking for time stamp overflow.
8be6f318 11393
fe31d94c
PE
11394 * editfns.c (time_overflow): New function, refactoring common code.
11395 (Fformat_time_string, Fdecode_time, Fencode_time):
11396 (Fcurrent_time_string): Use it.
11397
8be6f318
PE
11398 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11399 * dired.c (make_time): Move to ...
11400 * editfns.c (make_time): ... here.
11401 * systime.h: Note the move.
11402
09d9db2c 114032011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11404
126bc0dc
YM
11405 * fringe.c (update_window_fringes): Remove unused variables.
11406
c47cbdfd
YM
11407 * unexmacosx.c (copy_data_segment): Also copy __got section.
11408 (Bug#8223)
11409
7ac80be9
EZ
114102011-03-12 Eli Zaretskii <eliz@gnu.org>
11411
c96bbc66 11412 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11413 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11414 Constify `char *' arguments and their references according to
11415 prototypes in tparam.h.
11416
ecb0f94d 11417 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11418
7ac80be9
EZ
11419 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11420 Adapt all references accordingly.
11421
11422 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11423
ef1fd07e
TT
114242011-03-11 Tom Tromey <tromey@redhat.com>
11425
11426 * buffer.c (syms_of_buffer): Remove obsolete comment.
11427
7ef4b50c
EZ
114282011-03-11 Eli Zaretskii <eliz@gnu.org>
11429
11430 * termhooks.h (encode_terminal_code): Declare prototype.
11431
11432 * msdos.c (encode_terminal_code): Don't declare prototype.
11433
11434 * term.c (encode_terminal_code): Now external again, used by
11435 w32console.c and msdos.c.
11436
44f230aa
SM
11437 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11438 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11439
4b1ec863 114402011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11441
1714f52b 11442 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11443
4b1ec863
PE
11444 * fringe.c (update_window_fringes): Mark locals as initialized
11445 (Bug#8227).
11446 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11447
524c7aa6
PE
11448 * alloc.c (mark_fringe_data): Move decl from here ...
11449 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11450 to check its interface.
11451 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11452
a5c0af81 11453 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11454 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11455 (fontset_font): Mark local as initialized.
a9a06e0b 11456 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11457
b4716021
PE
11458 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11459
811e9bac 11460 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11461 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11462 (x_own_selection, Fx_disown_selection_internal): Rename locals
11463 to avoid shadowing.
11464 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11465
7e3ab302
PE
11466 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11467 so that the caller can use some name other than gcpro1.
11468 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11469 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11470 (Fx_backspace_delete_keys_p):
11471 Use them to avoid shadowing, and rename vars to avoid shadowing.
11472 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11473 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11474 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11475 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11476 Remove unused locals.
7e3ab302
PE
11477 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11478 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11479 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11480 macros.
f78faa98 11481
e2b13473
PE
11482 * xterm.h (x_mouse_leave): New decl.
11483
77f23912
PE
11484 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11485 Remove unused functions.
cdf4ba58
PE
11486 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11487 (x_calc_absolute_position): Now static.
7411c686 11488 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11489 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11490 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11491 unless they are used.
38d0b34a
PE
11492 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11493 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11494 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11495 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11496 (x_error_catcher, x_connection_closed, x_error_handler):
11497 (x_error_quitter, xembed_send_message, x_iconify_frame):
11498 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11499 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11500 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11501
44f230aa
SM
11502 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11503 Rename or move locals to avoid shadowing.
6b463e58 11504 (tty_defined_color, merge_face_heights): Now static.
5967d051 11505 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11506 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11507 does not deduce is never used uninitialized.
73719eba
PE
11508 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11509 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11510
426994c3 11511 * terminal.c (store_terminal_param): Now static.
5489860b 11512
032f1620 11513 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11514 (set_frame_menubar): Remove unused local.
d4323972 11515 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11516 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11517 since they might point to immutable storage.
281585b0
PE
11518 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11519 since it's unused otherwise.
032f1620 11520
367c19e5 11521 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11522 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11523 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11524 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11525 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11526 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11527 does not deduce are never used uninitialized.
70739cbe 11528
07b48fa9
PE
11529 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11530
8868a238 11531 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11532 * window.c (window_loop, size_window):
11533 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11534
7e5cf297 11535 * window.c (display_buffer): Now static.
d6550a9f
PE
11536 (size_window): Mark variables that gcc -Wuninitialized
11537 does not deduce are never used uninitialized.
a586633d
PE
11538 * window.h (check_all_windows): New decl, to forestall
11539 gcc -Wmissing-prototypes diagnostic.
5b555da1 11540 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11541
f6095868
PE
11542 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11543 shadowing.
11544 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11545 Include <limits.h>.
11546 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11547 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11548 (load_charset_map): Mark variables that gcc -Wuninitialized
11549 does not deduce are never used uninitialized.
53df7c11 11550 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11551
f38b440c
PE
11552 * coding.c (coding_set_source, coding_set_destination):
11553 Use "else { /* comment */ }" rather than "else /* comment */;"
11554 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11555 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11556 a block, when the outer 'i' will do.
11557 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11558 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11559 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11560 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11561 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11562 Rename locals to avoid shadowing.
11563 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11564 * coding.c (emacs_mule_char, encode_invocation_designation):
11565 Now static, since they're not used elsewhere.
413bb2db 11566 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11567 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11568 (decode_coding_emacs_mule): Mark variables that gcc
11569 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11570 (detect_coding_iso_2022): Initialize a local variable that might
11571 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11572 this initialization is needed. (Bug#8211)
5f58e762
PE
11573 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11574 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11575 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11576 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11577 Remove unused macros.
f38b440c 11578
232b38b9 11579 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11580 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11581 * character.c (string_count_byte8): Likewise.
232b38b9 11582
fb90da1b
PE
11583 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11584 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11585
fb93dbc2
PE
11586 * chartab.c (copy_sub_char_table): Now static, since it's not used
11587 elsewhere.
5c156ace
PE
11588 (sub_char_table_ref_and_range, char_table_ref_and_range):
11589 Rename locals to avoid shadowing.
bbcd0949 11590 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11591
7d3b3862 11592 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11593 (BIDI_BOB): Remove unused macro.
7d3b3862 11594
6be7d3da
PE
11595 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11596 deduce are never used uninitialized.
c2ed9c8b 11597 * term.c (encode_terminal_code): Likewise.
6be7d3da 11598
75f8807f 11599 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11600
50938595
PE
11601 * tparam.h: New file.
11602 * term.c, tparam.h: Include it.
11603 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11604 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11605 Move these decls to tparam.h, and make them agree with what
11606 is actually in tparam.c. The previous trick of using incompatible
11607 decls in different modules does not conform to the C standard.
11608 All callers of tparam changed to use tparam's actual API.
11609 * tparam.c (tparam1, tparam, tgoto):
11610 Use const pointers where appropriate.
11611
fbceeba2
PE
11612 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11613 * cm.h (struct cm): Likewise.
11614 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11615 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11616 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11617 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11618 (turn_on_face, init_tty): Likewise.
11619 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11620
7f3f1250
PE
11621 * term.c (term_mouse_position): Rename local to avoid shadowing.
11622
e6ca6543
PE
11623 * alloc.c (mark_ttys): Move decl from here ...
11624 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11625
c40f8d15
AS
116262011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11627
11628 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11629
cfe0661d
JB
116302011-03-09 Juanma Barranquero <lekktu@gmail.com>
11631
11632 * search.c (compile_pattern_1): Remove argument regp, unused since
11633 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11634 (compile_pattern): Don't pass it.
11635
0afb4571
J
116362011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11637
11638 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11639 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11640 for ! HAVE_GTK3.
11641 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11642
11643 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11644
11645 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11646 gdk_window_get_screen, gdk_window_get_geometry,
11647 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11648 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11649 (xg_get_pixbuf_from_pixmap): New function.
11650 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11651 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11652 Call xg_get_pixbuf_from_pixmap instead of
11653 gdk_pixbuf_get_from_drawable.
11654 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11655 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11656 (xg_check_special_colors): Use GtkStyleContext and its functions
11657 for HAVE_GTK3.
11658 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11659 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11660 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11661 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11662 Call gtk_widget_get_preferred_size.
0afb4571
J
11663 (xg_frame_resized): gdk_window_get_geometry only takes 5
11664 parameters.
44f230aa
SM
11665 (xg_win_to_widget, xg_event_is_for_menubar):
11666 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11667 (xg_set_widget_bg): New function.
11668 (delete_cb): New function.
895009e1 11669 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11670 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11671 (xg_set_background_color): Call xg_set_widget_bg.
11672 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11673 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11674 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11675 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11676 if ! HAVE_GTK3.
11677 (update_frame_tool_bar): Call gtk_widget_hide.
11678 (xg_initialize): Use GDK_KEY_g.
11679
11680 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11681 if ! HAVE_GTK3
11682 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11683
11684 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11685 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11686 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11687
1c2cc4ef
JB
116882011-03-08 Juanma Barranquero <lekktu@gmail.com>
11689
11690 * w32xfns.c (select_palette): Check success of RealizePalette against
11691 GDI_ERROR, not zero.
11692
33383987 11693See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11694
11695;; Local Variables:
11696;; coding: utf-8
aac0c6e3
MR
11697;; End:
11698
2f097256 11699 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11700
11701 This file is part of GNU Emacs.
11702
11703 GNU Emacs is free software: you can redistribute it and/or modify
11704 it under the terms of the GNU General Public License as published by
11705 the Free Software Foundation, either version 3 of the License, or
11706 (at your option) any later version.
11707
11708 GNU Emacs is distributed in the hope that it will be useful,
11709 but WITHOUT ANY WARRANTY; without even the implied warranty of
11710 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11711 GNU General Public License for more details.
11712
11713 You should have received a copy of the GNU General Public License
11714 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.