Simplify previous changes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a69fbedb 12011-08-16 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2
70c60eb2 3 Integer and memory overflow issues (Bug#9196).
726e0ab1 4
a69fbedb
PE
5 * image.c (x_allocate_bitmap_record, cache_image):
6 * xselect.c (Fx_register_dnd_atom):
7 Simplify previous changes by using xpalloc.
8
fe5c5d37
PE
9 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
10 since either will do and ptrdiff_t is convenient with xpalloc.
11
0065d054
PE
12 * charset.c (charset_table_size)
13 (struct charset_sort_data.priority): Now ptrdiff_t.
14 (charset_compare): Don't overflow if priorities differ greatly.
15 (Fsort_charsets): Don't assume list length fits in int.
16 Check for size-calculation overflow when allocating sort data.
17 (syms_of_charset): Allocate an initial charset table that is
18 just under 64 KiB, to avoid problems with glibc malloc and mmap.
19
20 * cmds.c (internal_self_insert): Check for size-calculation overflow.
21
22 * composite.h (struct composition.glyph_len): Now int, not unsigned.
23 The actual value is always <= INT_MAX, and leaving it unsigned made
24 overflow checking harder.
25
26 * dispextern.h (struct glyph_matrix.rows_allocated)
27 (struct face_cache.size): Now ptrdiff_t, for convenience in use
28 with xpalloc. The values are still always <= INT_MAX.
29
30 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
31
32 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
33 (SAFE_NALLOCA): New macro.
34
35 * region-cache.c (struct boundary.pos, find_cache_boundary)
36 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
37 (set_cache_region, invalidate_region_cache)
38 (revalidate_region_cache, know_region_cache, region_cache_forward)
39 (region_cache_backward, pp_cache):
40 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
41 so that ptrdiff_t * can be passed to xpalloc.
42 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
43 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
44 (pp_cache): Don't assume cache_len fits in int.
45 * region-cache.h: Adjust extern decls to match.
46
47 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
48 EMACS_INT, since either will do, for xpalloc.
49
50 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
51 (xnmalloc, xnrealloc, xpalloc): New functions.
52
726e0ab1
PE
53 * bidi.c (bidi_shelve_header_size): New constant.
54 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
55 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
56
57 * buffer.c (overlays_at, overlays_in, record_overlay_string)
58 (overlay_strings):
59 Don't update size of array until after memory allocation succeeds,
60 because xmalloc/xrealloc may not return.
0065d054
PE
61 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
62 now that we have proper integer overflow checking.
63 (record_overlay_string, overlay_strings): Catch overflows when
64 calculating size of overlay_str_buf.
726e0ab1 65
0065d054
PE
66 * callproc.c (Fcall_process): Check for size overflow when
67 calculating size of args2.
68 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
69 Normally we prefer signed values, but sticking with ptrdiff_t would
70 require adding more-complicated checks.
726e0ab1
PE
71
72 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
73 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
74 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 75 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
76
77 * character.c (Fstring): Check for size-calculation overflow.
78
79 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
80 unnecessary integer overflow. Check for size overflow.
81 (encode_coding_object): Don't update size until xmalloc succeeds.
82
83 * composite.c (get_composition_id): Check for overflow in glyph
84 length calculations.
85
86 Integer and memory overflow fixes for display code.
87 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
88 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
89 (scrolling_window): Check for overflow in size calculations.
90 (line_draw_cost, realloc_glyph_pool, add_row_entry):
91 Don't assume glyph table len fits in int.
92 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
93 (row_table_size): Now ptrdiff_t, not int.
94 (scrolling_window): Avoid overflow in size calculations.
95 Don't update size until allocation succeeds.
96 * fns.c (concat): Check for overflow in size calculations.
97 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
98 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
99 (NEXT_ALMOST_PRIME_LIMIT): New constant.
100
101 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
102 (get_doc_string): Check for size calculation overflow.
103 Don't update size until allocation succeeds.
104 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
105 EMACS_INT, where ptrdiff_t will do.
106 (Fsubstitute_command_keys): Check for string overflow.
107
108 * editfns.c (set_time_zone_rule): Don't assume environment length
109 fits in int.
110 (message_length): Now ptrdiff_t, not int.
111 (Fmessage_box): Don't update size until allocation succeeds.
112 Don't assume message length fits in int.
113 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
114
0065d054
PE
115 * emacs.c (main): Do not reallocate argv, since there is a null at
116 the end that can be overwritten, and this way there's no need to
117 worry about size-calculation overflow.
118 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
119
120 * eval.c (init_eval_once, grow_specpdl): Don't update size until
121 alloc succeeds.
122 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
123
124 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
125 (x_set_scroll_bar_width, x_figure_window_size):
126 Check for integer overflow.
127 (x_set_alpha): Do not assume XINT fits in int.
128
129 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
130 This is for the members text_lines, text_cols, total_lines, total_cols,
131 where the system imposes an 'int' limit.
132
133 * fringe.c (Fdefine_fringe_bitmap):
134 Don't update size until alloc works.
135
136 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
137 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
138
139 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
140 Check for size-calculation overflow.
141 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
142 do, as we prefer signed integers.
143 (id_to_widget.max_size, id_to_widget.used)
144 (xg_store_widget_in_map, xg_remove_widget_from_map)
145 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
146 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
147 Use and return ptrdiff_t, not int.
148 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
149 * gtkutil.h: Change prototypes to match the above.
150
151 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
152 are duplicate now that they've been promoted to lisp.h.
153 (x_allocate_bitmap_record, x_alloc_image_color)
154 (make_image_cache, cache_image, xpm_load):
155 Don't update size until alloc is done.
156 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
157 (x_detect_edges):
3256efce 158 Check for size calculation overflow.
726e0ab1
PE
159 (ct_colors_allocated_max): New constant.
160 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
161 overflow.
3256efce 162
726e0ab1
PE
163 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
164 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
165 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
166 Use ptrdiff_t, not int, to count maps.
167 (read_char_minibuf_menu_prompt): Check for overflow in size
168 calculations. Don't update size until allocation succeeds. Redo
169 calculations to avoid overflow.
170 * keyboard.h: Change prototypes to match the above.
171
172 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
173 to count maps.
174 (current_minor_maps): Check for size calculation overflow.
175 * keymap.h: Change prototypes to match the above.
176
177 * lread.c (read1, init_obarray): Don't update size until alloc done.
178
179 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
180 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
181
726e0ab1
PE
182 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
183 Now ptrdiff_t, not int.
184 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
185 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
186
187 * process.c (Fnetwork_interface_list): Check for overflow
188 in size calculation.
189
190 * region-cache.c (move_cache_gap): Check for size calculation overflow.
191
192 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
193 overflow. Don't bother calling xmalloc when xrealloc will do.
194
195 * search.c (Freplace_match): Check for size calculation overflow.
196 (Fset_match_data): Don't assume list lengths fit in 'int'.
197
198 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
199 for command line length. Do not attempt to address one before the
200 beginning of an array, as that's not portable.
201
202 * term.c (max_frame_lines): Remove; unused.
203 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
204 not int.
205 (encode_terminal_code, calculate_costs): Check for size
206 calculation overflow.
207 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
208 table lengths and related sizes. Don't update size until alloc
209 done. Redo calculations to avoid overflow.
210 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
211
212 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
213 subtracting pointers.
214 (gobble_line): Check for overflow more carefully. Don't update size
215 until alloc done.
216
217 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
218 Don't update size until alloc done.
219 Redo size calculations to avoid overflow.
220 Check for size calculation overflow.
0065d054 221 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
222
223 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
224 Use ptrdiff_t, not int, for sizes.
225 (store_mode_line_noprop_char): Don't update size until alloc done.
226
0065d054
PE
227 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
228 Use ptrdiff_t, not int, for sizes.
229 (Finternal_make_lisp_face, cache_face):
230 Check for size calculation overflow.
231 (cache_face): Treat size calculation overflows as if they were
232 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
233
234 * xfns.c (x_encode_text, x_set_name_internal)
235 (Fx_change_window_property): Use ptrdiff_t, not int, to count
236 sizes, since they can exceed INT_MAX in size. Check for size
237 calculation overflow.
238
0065d054
PE
239 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
240 (xg_select): Check for size calculation overflow.
726e0ab1
PE
241 Don't update size until alloc done.
242
0065d054 243 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 244 as sprintf is limited to int lengths.
1d526e2f 245
252c5ee1
PE
246 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
247 (X_LONG_MIN): New macros.
864d7ce7
PE
248 Use them to make the following changes clearer.
249 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
250 This change doesn't affect the value now, but it may help remind
251 future maintainers not to raise the value too much later.
252 (SELECTION_QUANTUM): Remove, replacing with ...
253 (selection_quantum): ... new function, which avoids overflow.
254 All uses changed.
255 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
256 assumption that selection length fits in 'int'.
257 (x_reply_selection_request, x_handle_selection_request)
258 (x_get_window_property, receive_incremental_selection)
259 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
260 (lisp_data_to_selection_data, clean_local_selection_data):
261 Use ptrdiff_t, not int, to record length of selection.
262 (x_reply_selection_request, x_get_window_property)
263 (receive_incremental_selection, x_property_data_to_lisp):
264 Redo calculations to avoid overflow.
265 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 266 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
267 something.
268 (x_get_window_property, receive_incremental_selection)
269 (lisp_data_to_selection_data, x_property_data_to_lisp):
270 Check for size-calculation overflow.
271 (x_get_window_property, receive_incremental_selection)
272 (lisp_data_to_selection_data, Fx_register_dnd_atom):
273 Don't store size until memory allocation succeeds.
274 (x_get_window_property): Plug memory leak on memory exhaustion.
275 Don't double-block input; malloc is safe here. Don't assume 2**34
276 - 4 fits in unsigned long. Add an xassert to check
277 XGetWindowProperty overflow. Be more careful about overflow
278 calculations, and distinguish size from memory overflow better.
279 (receive_incremental_selection): When tracing, don't assume
280 unsigned int is less than INT_MAX.
281 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
282 harmful) conversions of unsigned short to int.
283 (lisp_data_to_selection_data): Don't assume that integers
284 in the range -65535 through -1 fit in an X unsigned short.
285 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
286 result parameters unless successful. Rely on cons_to_unsigned
287 to report problems with elements; the old code wasn't right anyway.
288 (x_check_property_data): Check for int overflow; we cannot use
289 a wider type due to X limits.
290 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
291
726e0ab1 292 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 293
0065d054
PE
294 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
295 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
296 (x_color_cells): Don't store size until memory allocation succeeds.
297 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 298 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
299 (x_term_init): Don't assume length fits in int (sprintf is limited
300 to int size).
bc18e09d 301
ebfa62c0
PE
302 Use ptrdiff_t for composition IDs.
303 * character.c (lisp_string_width):
304 * composite.c (composition_table_size, n_compositions)
305 (get_composition_id, composition_gstring_from_id):
306 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
307 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
308 * window.c (Frecenter):
309 Use ptrdiff_t, not int, for composition IDs.
310 * composite.c (get_composition_id): Check for integer overflow.
311 * composite.h: Adjust prototypes to match the above changes.
312
d3411f89
PE
313 Use ptrdiff_t for hash table indexes.
314 * category.c (hash_get_category_set):
315 * ccl.c (ccl_driver):
316 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
317 * coding.c (coding_system_charset_list, detect_coding_system):
318 * coding.h (struct coding_system.id):
319 * composite.c (get_composition_id, gstring_lookup_cache):
320 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
321 * image.c (xpm_get_color_table_h):
322 * lisp.h (hash_lookup, hash_put):
323 * minibuf.c (Ftest_completion):
324 Use ptrdiff_t for hash table indexes, not int (which is too
325 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
326 32-bit --with-wide-int hosts).
327
e097a6fa
PE
328 * charset.c (Fdefine_charset_internal): Check for integer overflow.
329 Add a FIXME comment about memory leaks.
330 (syms_of_charset): Don't assume xmalloc returns.
331
5637687f
PE
332 Don't assume that stated character widths fit in int.
333 * character.c (Fchar_width, c_string_width, lisp_string_width):
334 * character.h (CHAR_WIDTH):
335 * indent.c (MULTIBYTE_BYTES_WIDTH):
336 Use sanitize_char_width to avoid undefined and/or bad behavior
337 with outlandish widths.
338 * character.h (sanitize_tab_width): Renamed from sanitize_width,
339 now that we have two such functions. All uses changed.
340 (sanitize_char_width): New inline function.
341
a2271ba2
PE
342 Don't assume that tab-width fits in int.
343 * character.h (sanitize_width): New inline function.
344 (SANE_TAB_WIDTH): New macro.
345 (ASCII_CHAR_WIDTH): Use it.
346 * indent.c (sane_tab_width): Remove. All uses replaced by
347 SANE_TAB_WIDTH (current_buffer).
348 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
349
18c52557
PE
350 * fileio.c: Integer overflow issues with file modes.
351 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
352
caeeedc1
PE
353 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
354 Remove unreachable code.
355 (read_hex, load_charset_map_from_file): Check for integer overflow.
356
50849c52
PE
357 * xterm.c: don't go over XClientMessageEvent limit
358 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
359 (x_send_scroll_bar_event): Likewise. Check that the size does not
360 exceed limits imposed by XClientMessageEvent, as well as the usual
361 ptrdiff_t and size_t limits.
362
b13995db
PE
363 * keyboard.c: Overflow, signedness and related fixes.
364 (make_lispy_movement): Use same integer type in forward decl
365 that is used in the definition.
366 (read_key_sequence, keyremap_step):
367 Change bufsize argument back to int, undoing my 2011-03-30 change.
368 We prefer signed types, and int is wide enough here.
369 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
370 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
371 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
372 length, not size_t. Use ptrdiff_t for index, not int.
373 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
374 possibility of integer overflow.
375
13464394
PE
376 Overflow, signedness and related fixes for images.
377
378 * dispextern.h (struct it.stack[0].u.image.image_id)
379 (struct_it.image_id, struct image.id, struct image_cache.size)
380 (struct image_cache.used, struct image_cache.ref_count):
381 * gtkutil.c (update_frame_tool_bar):
382 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
383 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
384 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
385 * nsmenu.m (update_frame_tool_bar):
386 * xdisp.c (calc_pixel_width_or_height):
387 * xfns.c (image_cache_refcount):
388 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
389 on typical 64-bit hosts.
390
391 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
392 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
393 Omit unnecessary casts to int.
394 (parse_image_spec): Check that integers fall into 'int' range
395 when the callers expect that.
396 (image_ascent): Redo ascent calculation to avoid int overflow.
397 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
398 (lookup_image): Remove unnecessary tests.
399 (xbm_image_p): Locals are now of int, not EMACS_INT,
400 since parse_image_check makes sure they fit into int.
401 (png_load, gif_load, svg_load_image):
402 Prefer int to unsigned where either will do.
403 (tiff_handler): New function, combining the cores of the
404 old tiff_error_handler and tiff_warning_handler. This
405 function is rewritten to use vsnprintf and thereby avoid
406 stack buffer overflows. It uses only the features of vsnprintf
407 that are common to both POSIX and native Microsoft.
408 (tiff_error_handler, tiff_warning_handler): Use it.
409 (tiff_load, gif_load, imagemagick_load_image):
410 Don't assume :index value fits in 'int'.
411 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
412 (imagemagick_load_image): Check that crop parameters fit into
413 the integer types that MagickCropImage accepts. Don't assume
414 Vimagemagick_render_type has a nonnegative value. Don't assume
415 size_t fits in 'long'.
416 (gs_load): Use printmax_t to print the widest integers possible.
417 Check for integer overflow when computing image height and width.
418
3ebec551
PE
4192011-08-15 Paul Eggert <eggert@cs.ucla.edu>
420
421 * bidi.c (bidi_initialize): Remove unused local.
422
9fd8be00
EZ
4232011-08-15 Eli Zaretskii <eliz@gnu.org>
424
474a8465
EZ
425 * biditype.h: File removed.
426
427 * bidimirror.h: File removed.
428
429 * deps.mk (bidi.o): Remove biditype.h and
430 bidimirror.h.
431
432 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
433 bidimirror.h.
434
435 * dispextern.h: Fix a typo in the comment to bidi_type_t.
436
437 * chartab.c: Improve commentary for the uniprop_table API.
438
32413314
EZ
439 * bidi.c (bidi_paragraph_init): Support zero value of
440 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
441 (bidi_initialize): Use uniprop_table instead of including
442 biditype.h and bidimirror.h.
32413314 443
9fd8be00
EZ
444 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
445 coordinates of the iterator when restoring from ppos_it.
446 (Bug#9296)
447
5cf2b69b
KH
4482011-08-14 Kenichi Handa <handa@m17n.org>
449
450 * process.c (create_process): Call setup_process_coding_systems
451 after the pid of the process is set to -1.
452
daf17d00
EZ
4532011-08-14 Eli Zaretskii <eliz@gnu.org>
454
455 * xdisp.c (move_it_in_display_line_to): Don't invoke
456 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
457 ppos_it. Fixes vertical cursor motion when line beginning is
458 covered by an image. (Bug#9296)
459
08e3161a
JD
4602011-08-14 Jan Djärv <jan.h.d@swipnet.se>
461
462 * nsterm.h (ns_run_ascript): Declare.
463 (NSAPP_DATA2_RUNASSCRIPT): Define.
464
465 * nsfns.m (as_script, as_result, as_status): New static variables.
466 (ns_run_ascript): New function.
467 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
468 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
469 the event loop. Get status from as_status (Bug#7276).
470
471 * nsterm.m (sendEvent): If event is NSApplicationDefined and
472 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
473 the event loop (Bug#7276).
474
a3720aa2
AS
4752011-08-14 Andreas Schwab <schwab@linux-m68k.org>
476
477 * gnutls.c (QCgnutls_bootprop_priority)
478 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
479 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
480 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
481 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
482 (QCgnutls_bootprop_verify_hostname_error)
483 (QCgnutls_bootprop_callbacks_verify): Rename from
484 Qgnutls_bootprop_..., all uses changed.
485
486 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
487 uses changed.
488
0a0d27fb
PE
4892011-08-14 Paul Eggert <eggert@cs.ucla.edu>
490
19d5c50c
PE
491 * xfaces.c (Qframe_set_background_mode): Now static.
492 * dispextern.h (Qframe_set_background_mode): Remove decl.
493
0a0d27fb
PE
494 * process.c (Fnetwork_interface_info): Declare local only if needed.
495
377538cb
JD
4962011-08-13 Jan Djärv <jan.h.d@swipnet.se>
497
498 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
499 (Fnetwork_interface_list): Allocate in increments of bytes instead
500 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
501 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
502 sockaddr.
503 (struct ifflag_def): notrailers is smart on OSX.
504 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
505 Get hardware address with getifaddrs if available.
506
08fff70c
EZ
5072011-08-12 Eli Zaretskii <eliz@gnu.org>
508
509 * xdisp.c (iterate_out_of_display_property): xassert that
510 IT->position is set to within IT->object's boundaries. Break from
511 the loop as soon as EOB is reached; avoids infloops in redisplay
512 when IT->position is set up wrongly due to some bug. Set
513 IT->current to match the bidi iterator unconditionally.
514 (push_display_prop): Allow GET_FROM_STRING as IT->method on
515 entry. Force push_it to save on the stack the current
516 buffer/string position, to be restored by pop_it. Fix flags in
517 the iterator structure wrt the object coming from a display
518 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
519 properties. (Bug#9284)
520
7be1c708 5212011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 522
7be1c708
CY
523 * fontset.c (fontset_get_font_group): Add proper type checks.
524 (Bug#9172)
aac0c6e3 525
7be1c708 5262011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 527
7be1c708
CY
528 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
529 and LC_VERSION_MIN_MACOSX.
530 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
531 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 532
97bb72a6
EZ
5332011-08-08 Eli Zaretskii <eliz@gnu.org>
534
535 * xdisp.c (forward_to_next_line_start): Allow to use the
757664a4
EZ
536 no-display-properties-and-no-overlays under bidi display. Set
537 disp_pos in the bidi iterator to avoid searches for display
538 properties and overlays.
97bb72a6 539
d5617611
CY
5402011-08-08 Chong Yidong <cyd@stupidchicken.com>
541
37e11a63
CY
542 * editfns.c (Fset_time_zone_rule): Document relationship with the
543 setenv function.
544
d5617611
CY
545 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
546 the font entity extracted from the cache (Bug#8109).
547
58872834
CY
5482011-08-07 Chong Yidong <cyd@stupidchicken.com>
549
550 * composite.c (autocmp_chars): Don't reset point. That is done by
551 restore_point_unwind (Bug#5984).
552
75bfc667
JL
5532011-08-07 Juri Linkov <juri@jurta.org>
554
555 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
556 to show the arg `TIME' instead of `TIMEVAL'.
557
d1410150
EZ
5582011-08-06 Eli Zaretskii <eliz@gnu.org>
559
560 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
561 display property strides EOL and includes a newline, as in
562 longlines-mode. (Bug#9254)
75b771e4
EZ
563 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
564 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
565
566 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
567 is non-zero, even if the data buffer is NULL. Fixes a crash in
568 vertical-motion with longlines-mode. (Bug#9254)
569
35928349
EZ
5702011-08-05 Eli Zaretskii <eliz@gnu.org>
571
ec7cc85b
EZ
572 * bidi.c <bidi_cache_total_alloc>: Now static.
573 (bidi_initialize): Initialize bidi_cache_total_alloc.
574
35928349
EZ
575 *xdisp.c (display_line): Release buffer allocated for shelved bidi
576 cache. (Bug#9221)
577
578 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
579 amount allocated this far in `bidi_cache_total_alloc'.
580 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
581 non-zero, only free the data buffer without restoring the cache
582 contents. All callers changed.
583
584 * dispextern.h (bidi_unshelve_cache): Update prototype.
585
586 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
587 (move_it_in_display_line, move_it_to)
588 (move_it_vertically_backward, move_it_by_lines): Replace the call
589 to xfree to an equivalent call to bidi_unshelve_cache.
590 (move_it_in_display_line_to): Fix logic of returning
412b6358 591 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 592
e2e2423b
EZ
5932011-08-05 Eli Zaretskii <eliz@gnu.org>
594
595 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
596 came from a string character with a `cursor' property. (Bug#9229)
597
ae9e757a
JD
5982011-08-04 Jan Djärv <jan.h.d@swipnet.se>
599
600 * Makefile.in (LIB_PTHREAD): New variable.
601 (LIBES): Add LIB_PTHREAD (Bug#9216).
602
603 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
604 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
605
213bd7f2
AS
6062011-08-04 Andreas Schwab <schwab@linux-m68k.org>
607
608 * regex.c (re_iswctype): Remove some redundant boolean
609 conversions.
610
99aaf75f
JD
6112011-08-04 Jan Djärv <jan.h.d@swipnet.se>
612
613 * xterm.c (x_find_topmost_parent): New function.
614 (x_set_frame_alpha): Find topmost parent window with
615 x_find_topmost_parent and set the property there also (bug#9181).
616 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
617
c74e9d86
PE
6182011-08-04 Paul Eggert <eggert@cs.ucla.edu>
619
620 * callproc.c (Fcall_process): Avoid vfork clobbering
621 the local vars buffer, coding_systems, current_dir.
622
640c8776
SM
6232011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
624
625 * keymap.c (Fmake_composed_keymap): Move to subr.el.
626
f26d0e4c
PE
6272011-08-03 Paul Eggert <eggert@cs.ucla.edu>
628
8a10d76c
PE
629 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
630 so that it is not optimized away.
631
f26d0e4c
PE
632 * xdisp.c (compute_display_string_pos): Remove unused local.
633
55439c61
EZ
6342011-08-02 Eli Zaretskii <eliz@gnu.org>
635
636 Fix slow cursor motion and scrolling in large buffers with
637 selective display, like Org Mode buffers. (Bug#9218)
638
639 * dispextern.h (struct bidi_it): New member disp_prop_p.
640
641 * xdisp.c: Remove one-slot cache of display string positions.
642 (compute_display_string_pos): Accept an additional argument
643 DISP_PROP_P; callers changed. Scan at most 5K characters forward
644 for a display string or property. If found, set DISP_PROP_P
645 non-zero.
646
647 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
648 DISP_PROP_P, and pass it to compute_display_string_pos.
649 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
650 non-zero. All callers of bidi_fetch_char changed.
651
fb33fa43
SM
6522011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
653
654 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
655
b099e063
DM
6562010-12-03 Don March <don@ohspite.net>
657
658 * keymap.c (Fdefine_key): Fix non-prefix key error message when
659 last character M-[char] is translated to ESC [char] (bug#7541).
660
5cc7f7af
KH
6612011-08-02 Kenichi Handa <handa@m17n.org>
662
d0fffa3f 663 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
664
665 * chartab.c (uniprop_table): Make it non-static.
666
525d5e6e
EZ
6672011-08-01 Eli Zaretskii <eliz@gnu.org>
668
669 * xdisp.c (forward_to_next_line_start): Accept additional argument
670 BIDI_IT_PREV, and store into it the state of the bidi iterator had
671 on the newline.
672 (reseat_at_next_visible_line_start): Use the bidi iterator state
673 returned by forward_to_next_line_start to restore the state of
674 it->bidi_it after backing up to previous newline. (Bug#9212)
675
31011111
AS
6762011-07-30 Andreas Schwab <schwab@linux-m68k.org>
677
678 * regex.c (re_comp): Protoize.
679 (re_exec): Fix return type.
680 (regexec): Fix type of `ret'. (Bug#9203)
681
e5d76069
PE
6822011-07-29 Paul Eggert <eggert@cs.ucla.edu>
683
684 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
685 This is needed if max-image-size is a floating-point number.
686
9a79b20c
AS
6872011-07-28 Andreas Schwab <schwab@linux-m68k.org>
688
689 * print.c (print_object): Print empty symbol as ##.
690
691 * lread.c (read1): Read ## as empty symbol.
692
d8c2fa78
AA
6932011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
694
695 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
696 setting frame foreground color (Bug#9175).
697 (x_set_background_color): Likewise.
698
ffe57a7a
AA
699 * nsmenu.m (-setText): Size tooltip dimensions precisely to
700 contents (Bug#9176).
701 (EmacsTooltip -init): Remove bezels and add shadows to
702 tooltip windows.
703
bf3492a5
AA
704 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
705 or scroll bar (Bug#8470).
706
d55e9c53
AA
707 * nsfont.m (nsfont_open): Remove assignment to voffset and
708 unnecessary vars hshink, expand, hd, full_height, min_height.
709 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
710
711 * nsterm.h (nsfont_info): Remove voffset field.
712
d8c2fa78 7132011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
714
715 Implement strike-through and overline on NextStep (Bug#8863).
716
717 * nsfont.m (nsfont_open): Use underline position provided by font,
718 instead of hard-coded value of 2.
719 (nsfont_draw): Call ns_draw_text_decoration instead.
720
721 * nsterm.h: Add declaration for ns_draw_text_decoration.
722
723 * nsterm.m (ns_draw_text_decoration): New function for drawing
724 underline, overline, and strike-through.
725 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
726 ns_draw_text_decoration. Change treatment of cursor drawing to
727 accomodate underlining, etc.
728
4cc60b9b
EZ
7292011-07-28 Eli Zaretskii <eliz@gnu.org>
730
bc7ece87
EZ
731 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
732 default.
4cc60b9b 733
476371c4
PE
7342011-07-28 Paul Eggert <eggert@cs.ucla.edu>
735
66606eea
PE
736 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
737 Without this fix, if a signal arrives just after memory fills up,
738 'malloc' might be invoked reentrantly.
739
476371c4
PE
740 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
741 In other words, assume that every image size is allowed, on non-X
742 hosts. This assumption is probably wrong, but it lets Emacs compile.
743
f3fcc40d
AS
7442011-07-28 Andreas Schwab <schwab@linux-m68k.org>
745
746 * regex.c (re_iswctype): Convert return values to boolean.
747
350c992f
EZ
7482011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
749
750 * xdisp.c (compute_display_string_pos): Don't use cached display
751 string position if the buffer had its restriction changed.
752 (Bug#9184)
753
5266b4bb
PE
7542011-07-28 Paul Eggert <eggert@cs.ucla.edu>
755
756 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
757
2573a837 7582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 759
41f55ccd 760 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 761
39e378da
PE
762 * bidi.c: Integer size and overflow fixes.
763 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
764 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
765 (bidi_cache_find_level_change, bidi_cache_ensure_space)
766 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
767 (bidi_find_other_level_edge):
768 Use ptrdiff_t instead of EMACS_INT where either will do.
769 This works better on 32-bit hosts configured --with-wide-int.
770 (bidi_cache_ensure_space): Check for size-calculation overflow.
771 Use % rather than repeated addition, for better worst-case speed.
772 Don't set bidi_cache_size until after xrealloc returns, because it
773 might not return.
774 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
775 (bidi_cache_ensure_space): Also check that the bidi cache size
776 does not exceed that of the largest Lisp string or buffer. See Eli
777 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 778
5e927815
PE
779 * alloc.c (__malloc_size_t): Remove.
780 All uses replaced by size_t. See Andreas Schwab's note
781 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
782
ca4aa935
PE
783 * image.c: Improve checking for integer overflow.
784 (check_image_size): Assume that f is nonnull, since
785 it is always nonnull in practice. This is one less thing to
786 worry about when checking for integer overflow later.
787 (x_check_image_size): New function, which checks for integer
788 overflow issues inside X.
789 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
790 This removes the need for a memory_full check.
791 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
792 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
793 (xbm_read_bitmap_data): Change locals back to 'int', since
794 their values must fit in 'int'.
795 (xpm_load_image, png_load, tiff_load):
796 Invoke x_create_x_image_and_pixmap earlier,
797 to avoid much needless work if the image is too large.
798 (tiff_load): Treat overly large images as if
799 x_create_x_image_and_pixmap failed, not as malloc failures.
800 (gs_load): Use x_check_image_size.
801
5f8f9cc2
PE
802 * gtkutil.c: Omit integer casts.
803 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
804 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
805
5adf60bc
PE
806 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
807
c8907a93
PE
808 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
809 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
810 would wrongly return t on a 64-bit host.
811
e3c25c68
PE
812 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
813 The plain *_OVERFLOW macros run afoul of GCC bug 49705
814 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
815 and therefore cause GCC to emit a bogus diagnostic in some cases.
816
3f791afe
PE
817 * image.c: Integer signedness and overflow and related fixes.
818 This is not an exhaustive set of fixes, but it's time to
819 record what I've got.
820 (lookup_pixel_color, check_image_size): Remove redundant decls.
821 (check_image_size): Don't assume that arbitrary EMACS_INT values
822 fit in 'int', or that arbitrary 'double' values fit in 'int'.
823 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
824 (tiff_load, imagemagick_load_image):
825 Check for overflow in size calculations.
826 (x_create_x_image_and_pixmap): Remove unnecessary test for
827 xmalloc returning NULL; that can't happen.
828 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
829 (xpm_color_bucket): Use better integer hashing function.
830 (xpm_cache_color): Don't possibly over-allocate memory.
831 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
832 (gif_memory_source):
833 Use ptrdiff_t, not int or size_t, to record sizes.
834 (png_load): Don't assume values greater than 2**31 fit in 'int'.
835 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
836 either works, as we prefer signed integers.
837 (tiff_read_from_memory, tiff_write_from_memory):
838 Return tsize_t, not size_t, since that's what the TIFF API wants.
839 (tiff_read_from_memory): Don't fail simply because the read would
840 go past EOF; instead, return a short read.
841 (tiff_load): Omit no-longer-needed casts.
842 (Fimagemagick_types): Don't assume size fits into 'int'.
843
3cc5a532
PE
844 Improve hashing quality when configured --with-wide-int.
845 * fns.c (hash_string): New function, taken from sxhash_string.
846 Do not discard information about ASCII character case; this
847 discarding is no longer needed.
848 (sxhash-string): Use it. Change sig to match it. Caller changed.
849 * lisp.h: Declare it.
850 * lread.c (hash_string): Remove, since we now use fns.c's version.
851 The fns.c version returns a wider integer if --with-wide-int is
852 specified, so this should help the quality of the hashing a bit.
853
b312a492
PE
854 * emacs.c: Integer overflow minor fix.
855 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
856 Define only if GNU_LINUX.
857 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
858
dfd153ae
PE
859 * dispnew.c: Integer signedness and overflow fixes.
860 Remove unnecessary forward decls, that were a maintenance hassle.
861 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
862 All uses changed.
863 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
864 (scrolling_window): Use ptrdiff_t, not int, for byte count.
865 (prepare_desired_row, line_draw_cost):
866 Use int, not unsigned, where either works.
867 (save_current_matrix, restore_current_matrix):
868 Use ptrdiff_t, not size_t, where either works.
869 (init_display): Check for overflow more accurately, and without
870 relying on undefined behavior.
871
a81d11a3
PE
872 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
873 Remove, replacing with the new symbols in lisp.h. All uses changed.
874 * fileio.c (make_temp_name):
875 * filelock.c (lock_file_1, lock_file):
876 * xdisp.c (message_dolog):
877 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
878 Use pMd etc. instead.
879 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
880 replacing the pWIDE etc. symbols removed from editfns.c.
881
3300e6fd
PE
882 * keyboard.h (num_input_events): Now uintmax_t.
883 This is (very slightly) less likely to mess up due to wraparound.
884 All uses changed.
885
fd05c7e9
PE
886 * buffer.c: Integer signedness fixes.
887 (alloc_buffer_text, enlarge_buffer_text):
888 Use ptrdiff_t rather than size_t when either will do, as we prefer
889 signed integers.
890
903fe15d
PE
891 * alloc.c: Integer signedness and overflow fixes.
892 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
893 (__malloc_size_t): Default to size_t, not to int.
894 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
895 (Fgarbage_collect, mark_object_loop_halt, mark_object):
896 Prefer ptrdiff_t to size_t when either would do, as we prefer
897 signed integers.
898 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
899 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
900 Now const. Initialize with values that are in range even if char
901 is signed.
902 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
903 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
904 These functions do the right thing with sizes > 2**32.
905 (check_depth): Now ptrdiff_t, not int.
906 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
907 Adjust to new way of storing sizes. Check for size overflow bugs
908 in rest of code.
909 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
910 slightly wrong anyway, as it missed one instance of
911 XMALLOC_OVERRUN_CHECK_OVERHEAD.
912 (refill_memory_reserve): Omit needless cast to size_t.
913 (mark_object_loop_halt): Mark as externally visible.
914
ac82cc6a
PE
915 * xselect.c: Integer signedness and overflow fixes.
916 (Fx_register_dnd_atom, x_handle_dnd_message):
917 Use ptrdiff_t, not size_t, since we prefer signed.
918 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
919 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
920 x_dnd_atoms_size and x_dnd_atoms_length.
921
c2d1e36d
PE
922 * doprnt.c: Prefer signed to unsigned when either works.
923 * eval.c (verror):
924 * doprnt.c (doprnt):
925 * lisp.h (doprnt):
926 * xdisp.c (vmessage):
927 Use ptrdiff_t, not size_t, when using or implementing doprnt,
928 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
929 prefer signed arithmetic to avoid comparison confusion.
930 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
931 but is a bit tricky.
932
0e926e56
PE
933 Assume freestanding C89 headers, string.h, stdlib.h.
934 * data.c, doprnt.c, floatfns.c, print.c:
935 Include float.h unconditionally.
936 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
937 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
938 * regex.c: Likewise for stddef.h, string.h.
939 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
940 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
941 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
942 (STDC_HEADERS): Remove obsolete defines.
943 * sysdep.c: Include limits.h unconditionally.
944
9cfdb3ec
PE
945 Assume support for memcmp, memcpy, memmove, memset.
946 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
947 * regex.c (memcmp, memcpy):
948 Remove; we assume C89 now.
949
950 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
951 (__malloc_safe_bcopy): Remove; no longer needed.
952
cf950e6b 953 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
954 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
955 well either way, and we prefer signed to unsigned.
956
dbf38e02
LMI
9572011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
958
959 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
960 closes the connection while we're reading (bug#9182).
961
d6f0886c
JD
9622011-07-25 Jan Djärv <jan.h.d@swipnet.se>
963
964 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
965 are specified (Bug#9168).
966
2eb1f9e6
PE
9672011-07-25 Paul Eggert <eggert@cs.ucla.edu>
968
969 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
970 Found by GCC static checking and --with-wide-int on a 32-bit host.
971
22381272 9722011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
973
974 * xdisp.c (compute_display_string_pos): Fix logic of caching
975 previous display string position. Initialize cached_prev_pos to
976 -1. Fixes slow-down at the beginning of a buffer.
977
f25e39b4
EZ
9782011-07-24 Eli Zaretskii <eliz@gnu.org>
979
980 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
981 for attrs[LFACE_FONTSET_INDEX].
982
04c4b52e
PE
9832011-07-23 Paul Eggert <eggert@cs.ucla.edu>
984
985 * xml.c (parse_region): Remove unused local
986 that was recently introduced.
987
c1734fbd
EZ
9882011-07-23 Eli Zaretskii <eliz@gnu.org>
989
be18c5a5
EZ
990 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
991 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
992
c1734fbd
EZ
993 * xdisp.c (move_it_in_display_line_to): Record the best matching
994 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
995 exit if none of the characters scanned was an exact match.
996 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
997 when exact match is impossible due to invisible text, and the
998 lines are truncated.
999
a258d627
JD
10002011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1001
1002 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1003 for OSX >= 10.7.
1004
b6d5a689
EZ
10052011-07-22 Eli Zaretskii <eliz@gnu.org>
1006
0f74f785
EZ
1007 Fix a significant slow-down of cursor motion with C-n, C-p,
1008 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1009 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1010 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1011 (next_element_from_buffer): Call compute_stop_pos_backwards to
1012 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1013 base_level_stop.
1014 (reseat): Don't look for prev_stop, as that could mean a very long
1015 run.
1016 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1017 <cached_disp_overlay_modiff>: Cache for last found display string
1018 position.
551918c1 1019 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1020 about the same buffer in the same area of character positions, and
1021 the buffer wasn't changed since the time the display string
1022 position was cached.
551918c1 1023
b2d0c91a
EZ
10242011-07-22 Eli Zaretskii <eliz@gnu.org>
1025
1026 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1027 is an integer, which is important for empty lines. (Bug#9149)
1028
043604ee
CY
10292011-07-22 Chong Yidong <cyd@stupidchicken.com>
1030
1031 * frame.c (Fmodify_frame_parameters): In tty case, update the
1032 default face if necessary (Bug#4238).
1033
da4adb04
CY
10342011-07-21 Chong Yidong <cyd@stupidchicken.com>
1035
1036 * editfns.c (Fstring_to_char): No need to explain what a character
1037 is in the docstring (Bug#6576).
1038
9abd0532
LMI
10392011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1040
1041 * xml.c (parse_region): Make sure we always return a tree.
1042
36881d16
HK
10432011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1044
1045 * xml.c (parse_region): If a document contains only comments,
1046 return that, too.
1047
1e98674d
LMI
10482011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1049
1050 * xml.c (make_dom): Return comments, too.
1051
590bd467
PE
10522011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1053
1054 Port to OpenBSD.
1055 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1056 and the surrounding thread.
1057 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1058 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1059 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1060 timer goes off.
1061 * s/openbsd.h (BROKEN_SIGIO): Define.
1062 * unexelf.c (unexec) [__OpenBSD__]:
1063 Don't update the .mdebug section of the Alpha COFF symbol table.
1064
f41628b2
LMI
10652011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1066
1067 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1068 (bug#8460).
1069
b59b67c5
PE
10702011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1071
15e3a074
PE
1072 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1073 This fixes some race conditions on the permissions of any newly
1074 created file.
1075
41bed37d
PE
1076 * alloc.c (valid_pointer_p): Use pipe, not open.
1077 This fixes some permissions issues when debugging.
1078
b59b67c5
PE
1079 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1080 If fchown fails to set both uid and gid, try to set just gid,
1081 as that is sometimes allowed. Adjust the file's mode to eliminate
1082 setuid or setgid bits that are inappropriate if fchown fails.
1083
925a6be7
SM
10842011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1085
1086 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1087 to compare Lisp_Objects.
1088 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1089 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1090 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1091
52968808
AS
10922011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1093
0a6a104b
AS
1094 * lread.c (read_integer): Unread even EOF character.
1095 (read1): Likewise. Properly record start position of symbol.
1096
52968808
AS
1097 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1098 symbol character follows.
1099
9e381cdd
PE
11002011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1101
1102 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1103 This works around a problem with the previous change to Fcopy_file.
1104 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1105 and without this change, GCC might complain about discarding
1106 fchown's return value.
1107
b5641435
JB
11082011-07-16 Juanma Barranquero <lekktu@gmail.com>
1109
1110 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1111
a8031457
PE
11122011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1113
1114 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1115
dd889327
LMI
11162011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1117
750c33f7
LMI
1118 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1119 it's used from the C level.
1120
dd889327
LMI
1121 * process.c: Use the same condition for POLL_FOR_INPUT in both
1122 keyboard.c and process.c (bug#1858).
1123
87e86684
LM
11242011-07-09 Lawrence Mitchell <wence@gmx.li>
1125
1126 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1127 (Fgnutls_boot): Use it.
1128
64348f40
AS
11292011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1130
1131 * doc.c (Fsubstitute_command_keys): Revert last change.
1132
1d698799
LMI
11332011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1134
f863868c
LMI
1135 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1136 quotes the next character, and doesn't affect other longer
1137 sequences (bug#8935).
1138
1d698799
LMI
1139 * lread.c (syms_of_lread): Clarify that is isn't only
1140 `eval-buffer' and `eval-defun' that's affected by
1141 `lexical-binding' (bug#8460).
1142
aa4b6df6
EZ
11432011-07-15 Eli Zaretskii <eliz@gnu.org>
1144
1145 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1146 bidi redisplay when a line includes both an image and is
1147 truncated.
1148
5d856da6
PE
11492011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1150
ad6042bb
PE
1151 Fix minor problems found by static checking.
1152 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1153 (elsz): Now a signed constant, not a size_t var. We prefer signed
1154 types to unsigned, to avoid integer comparison confusion. Without
1155 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1156 "cannot optimize loop, the loop counter may overflow", a symptom
1157 of the confusion.
f00bbb22 1158 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1159 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1160
6468f31c
LMI
11612011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1162
49080b10
LMI
1163 * search.c (Fre_search_backward): Mention `case-fold-search' in
1164 all the re_search_* functions (bug#8138).
1165
6468f31c
LMI
1166 * keyboard.c (Fopen_dribble_file): Document when the file is
1167 closed (bug#8056).
1168
c965adc5
EZ
11692011-07-14 Eli Zaretskii <eliz@gnu.org>
1170
df9733bf
EZ
1171 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1172 bidi_cache_idx.
1173
0bb23927
EZ
1174 Support bidi reordering of display and overlay strings.
1175 * xdisp.c (compute_display_string_pos)
1176 (compute_display_string_end): Accept additional argument STRING.
1177 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1178 (reseat_to_string): Initialize bidi_it->string.s and
1179 bidi_it->string.schars.
1180 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1181 NULL (avoids a crash in bidi_paragraph_init).
1182 Initialize itb.string.lstring.
0bb23927
EZ
1183 (init_iterator): Call bidi_init_it only of a valid
1184 buffer position was specified. Initialize paragraph_embedding to
1185 L2R.
1186 (reseat_to_string): Initialize the bidi iterator.
1187 (display_string): If we need to ignore text properties of
1188 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1189 original value of -1 will not work with bidi.)
1190 (compute_display_string_pos): First arg is now struct
1191 `text_pos *'; all callers changed. Support display properties on
1192 Lisp strings.
1193 (compute_display_string_end): Support display properties on Lisp
1194 strings.
1195 (init_iterator, reseat_1, reseat_to_string): Initialize the
1196 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1197 when iterating on a string not from display properties).
640c8776
SM
1198 (compute_display_string_pos, compute_display_string_end):
1199 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1200 arrow keys.
1201 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1202 base_level_stop; instead, set base_level_stop to BEGV.
1203 Fixes crashes in vertical-motion.
0bb23927
EZ
1204 (next_element_from_buffer): Improve commentary for when
1205 the iterator is before prev_stop.
1206 (init_iterator): Initialize bidi_p from the default value of
1207 bidi-display-reordering, not from buffer-local value. Use the
1208 buffer-local value only if initializing for buffer iteration.
1209 (handle_invisible_prop): Support invisible properties on strings
1210 that are being bidi-reordered.
1211 (set_iterator_to_next): Support bidi reordering of C strings and
1212 Lisp strings.
1213 (next_element_from_string): Support bidi reordering of Lisp
1214 strings.
1215 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1216 (display_string): Support display of R2L glyph rows.
1217 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1218 (init_iterator): Don't initialize it->bidi_p for strings
1219 here.
1220 (reseat_to_string): Initialize it->bidi_p for strings here.
1221 (next_element_from_string, next_element_from_c_string)
1222 (next_element_from_buffer): Add xassert's for correspondence
1223 between IT's object being iterated and it->bidi_it.string
1224 structure.
1225 (face_before_or_after_it_pos): Support bidi iteration.
1226 (next_element_from_c_string): Handle the case of the first string
1227 character that is not the first one in the visual order.
1228 (get_visually_first_element): New function, refactored from common
1229 parts of next_element_from_buffer, next_element_from_string, and
1230 next_element_from_c_string.
1231 (tool_bar_lines_needed, redisplay_tool_bar)
1232 (display_menu_bar): Force left-to-right direction. Add a FIXME
1233 comment for making that be controlled by a user option.
1234 (push_it, pop_it): Save and restore the state of the
1235 bidi iterator. Save and restore the bidi_p flag.
1236 (pop_it): Iterate out of display property for string iteration as
1237 well.
1238 (iterate_out_of_display_property): Support iteration over strings.
1239 (handle_single_display_spec): Set up it->bidi_it for iteration
1240 over a display string, and call bidi_init_it.
1241 (handle_single_display_spec, next_overlay_string)
1242 (get_overlay_strings_1, push_display_prop): Set up the bidi
1243 iterator for displaying display or overlay strings.
1244 (forward_to_next_line_start): Don't use the shortcut if
1245 bidi-iterating.
1246 (back_to_previous_visible_line_start): If handle_display_prop
1247 pushed the iterator stack, restore the internal state of the bidi
1248 iterator by calling bidi_pop_it same number of times.
1249 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1250 and we are bidi-iterating, don't decrement the iterator position;
1251 instead, set the first_elt flag in the bidi iterator, to produce
1252 the same effect.
1253 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1254 (push_display_prop): xassert that we are iterating a buffer.
1255 (push_it, pop_it): Save and restore paragraph_embedding member.
1256 (handle_single_display_spec, next_overlay_string)
1257 (get_overlay_strings_1, reseat_1, reseat_to_string)
1258 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1259 correctly. Don't assume unibyte strings are not bidi-reordered.
1260 (compute_display_string_pos)
1261 (compute_display_string_end): Fix handling the case of C string.
1262 (push_it, pop_it): Save and restore from_disp_prop_p.
1263 (handle_single_display_spec, push_display_prop): Set the
1264 from_disp_prop_p flag.
1265 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1266 (pop_it): Call iterate_out_of_display_property only if we are
1267 popping after iteration over a string that came from a display
1268 property. Fix a typo in popping stretch info. Add an assertion
1269 for verifying that the iterator position is in sync with the bidi
1270 iterator.
1271 (handle_single_display_spec, get_overlay_strings_1)
1272 (push_display_prop): Fix initialization of paragraph direction for
1273 string when that of the parent object is not yet determined.
1274 (reseat_1): Call bidi_init_it to resync the bidi
1275 iterator with IT's position. (Bug#7616)
1276 (find_row_edges): If ROW->start.pos gives position
1277 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1278 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1279 Reset the from_disp_prop_p flag.
1280 (SAVE_IT, RESTORE_IT): New macros.
1281 (pos_visible_p, face_before_or_after_it_pos)
1282 (back_to_previous_visible_line_start)
1283 (move_it_in_display_line_to, move_it_in_display_line)
1284 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1285 (try_scrolling, redisplay_window, display_line): Use them when
1286 saving a temporary copy of the iterator and restoring it back.
1287 (back_to_previous_visible_line_start, reseat_1)
1288 (init_iterator): Empty the bidi cache "stack".
1289 (move_it_in_display_line_to): If iterator ended up at
1290 EOL, but we never saw any buffer positions smaller than
1291 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1292 motion in bidi-reordered lines.
1293 (move_it_in_display_line_to): Record prev_method and prev_pos
1294 immediately before the call to set_iterator_to_next. Fixes cursor
1295 motion in bidi-reordered lines with stretch glyphs and strings
1296 displayed in margins. (Bug#8133) (Bug#8867)
1297 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1298 TO_CHARPOS.
640c8776
SM
1299 (pos_visible_p): Support positions in bidi-reordered lines.
1300 Save and restore bidi cache.
0bb23927
EZ
1301
1302 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1303 (bidi_paragraph_info): Delete unused struct.
1304 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1305 (bidi_cache_start): New variable.
1306 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1307 to zero.
1308 (bidi_cache_fetch_state, bidi_cache_search)
1309 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1310 (bidi_cache_find, bidi_peek_at_next_level)
1311 (bidi_level_of_next_char, bidi_find_other_level_edge)
1312 (bidi_move_to_visually_next): Compare cache index with
1313 bidi_cache_start rather than with zero.
1314 (bidi_fetch_char): Accept new argument STRING; all callers
1315 changed. Support iteration over a string. Support strings with
1316 display properties. Support unibyte strings. Fix the type of
1317 `len' according to what STRING_CHAR_AND_LENGTH expects.
1318 (bidi_paragraph_init, bidi_resolve_explicit_1)
1319 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1320 (bidi_level_of_next_char, bidi_move_to_visually_next):
1321 Support iteration over a string.
0bb23927
EZ
1322 (bidi_set_sor_type, bidi_resolve_explicit_1)
1323 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1324 can now be zero (for strings); special values 0 and -1 were
1325 changed to -1 and -2, respectively.
1326 (bidi_char_at_pos): New function.
1327 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1328 Call it instead of FETCH_MULTIBYTE_CHAR.
1329 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1330 initialized to valid values.
1331 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1332 values.
1333 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1334 the test for valid cached positions. Fix the logic for looking up
1335 the sentinel state in the cache. GCPRO the Lisp string we are
1336 iterating.
1337 (bidi_push_it, bidi_pop_it): New functions.
1338 (bidi_initialize): Initialize the bidi cache start stack pointer.
1339 (bidi_cache_ensure_space): New function, refactored from part of
1340 bidi_cache_iterator_state. Don't assume the required size is just
1341 one BIDI_CACHE_CHUNK away.
1342 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1343 (bidi_count_bytes, bidi_char_at_pos): New functions.
1344 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1345 always valid if bidi_cache_idx is valid.
1346 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1347 is valid if it's going to be used.
1348 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1349 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1350 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1351 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1352 (bidi_find_other_level_edge, bidi_cache_start_stack):
1353 All variables related to cache indices are now EMACS_INT.
c965adc5 1354
0bb23927
EZ
1355 * dispextern.h (struct bidi_string_data): New structure.
1356 (struct bidi_it): New member `string'. Make flag members be 1-bit
1357 fields, and put them last in the struct.
640c8776
SM
1358 (compute_display_string_pos, compute_display_string_end):
1359 Update prototypes.
0bb23927
EZ
1360 (bidi_push_it, bidi_pop_it): Add prototypes.
1361 (struct iterator_stack_entry): New members bidi_p,
1362 paragraph_embedding, and from_disp_prop_p.
1363 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1364 (bidi_shelve_cache, bidi_unshelve_cache):
1365 Declare prototypes.
0bb23927
EZ
1366
1367 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1368 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1369 and vector-like objects.
1370
1371 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1372 cache around display iteration.
1373
1374 * window.c (Fwindow_end, window_scroll_pixel_based)
1375 (displayed_window_lines, Frecenter): Save and restore the bidi
1376 cache around display iteration.
1377
3bbd2265
LMI
13782011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1379
1380 * editfns.c (Fdelete_region): Clarify the use of the named
1381 parameters (bug#6788).
1382
adc47434
MR
13832011-07-14 Martin Rudalics <rudalics@gmx.at>
1384
1385 * indent.c (Fvertical_motion): Set and restore w->pointm when
1386 saving and restoring the window's buffer (Bug#9006).
1387
837c31f8
LMI
13882011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1389
1390 * editfns.c (Fstring_to_char): Clarify just what is returned
1391 (bug#6576). Text by Eli Zaretskii.
1392
ac389d0c
JB
13932011-07-13 Juanma Barranquero <lekktu@gmail.com>
1394
1395 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1396
0be0ce47
EZ
13972011-07-13 Eli Zaretskii <eliz@gnu.org>
1398
1399 * buffer.c (mmap_find): Fix a typo.
1400
cd18e7e3
JB
14012011-07-13 Johan Bockgård <bojohan@gnu.org>
1402
1403 Fix execution of x selection hooks.
1404 * xselect.c (Qx_lost_selection_functions)
1405 (Qx_sent_selection_functions): New vars.
1406 (syms_of_xselect): DEFSYM them.
1407 (x_handle_selection_request): Pass Qx_sent_selection_functions
1408 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1409 (x_handle_selection_clear,x_clear_frame_selections):
1410 Pass Qx_lost_selection_functions rather than
1411 Vx_lost_selection_functions to Frun_hook_with_args.
1412
47ea7f44
PE
14132011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1414
ac389d0c 1415 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1416 The old code sometimes used this field without initializing it.
1417
47ea7f44
PE
1418 * alloc.c (gc_sweep): Don't read past end of array.
1419 In theory, the old code could also have corrupted Emacs internals,
1420 though it'd be very unlikely.
1421
bc985c87
AS
14222011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1423
1424 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1425 argument. (Bug#4026)
bc985c87 1426
0cf34688
LMI
14272011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1428
b3dadd76
LMI
1429 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1430 key" (bug#4257).
1431
0cf34688
LMI
1432 * window.c (Fset_window_start): Doc fix (bug#4199).
1433 (Fset_window_hscroll): Ditto.
1434
270768cd
PE
14352011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1436
077e3dda 1437 Fix minor new problems caught by GCC 4.6.1.
270768cd 1438 * term.c (init_tty): Remove unused local.
490011a6 1439 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1440 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1441 not used otherwise.
270768cd 1442
b1f58454
CY
14432011-07-12 Chong Yidong <cyd@stupidchicken.com>
1444
1445 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1446
22b9578d
LMI
14472011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1448
6e70ab07
LMI
1449 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1450 are the mini-buffer and the echo area (bug#3320).
1451
22b9578d
LMI
1452 * term.c (init_tty): Remove support for supdup, c10 and perq
1453 terminals, which are no longer supported (bug#1482).
1454
8974cc9f
JB
14552011-07-10 Johan Bockgård <bojohan@gnu.org>
1456
1457 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1458
a560d974
JD
14592011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1460
1461 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1462 for non-popups (Bug#3642).
1463
1dae0f0a
AS
14642011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1465
268c2c36 1466 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1467 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1468 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1469 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1470 * data.c (fmod): Likewise.
1471 * dispnew.c (swap_glyphs_in_rows): Likewise.
1472 * emacs.c (memory_warning_signal): Likewise.
1473 * floatfns.c (float_error): Likewise.
1474 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1475 (otf_open, font_otf_capability, generate_otf_features)
1476 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1477 Likewise.
1478 * image.c (pbm_read_file): Likewise.
1479 * indent.c (string_display_width): Likewise.
1480 * intervals.c (check_for_interval, search_for_interval)
1481 (inc_interval_count, count_intervals, root_interval)
1482 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1483 * lread.c (defalias): Likewise.
268c2c36 1484 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1485 * regex.c (set_image_of_range_1, set_image_of_range)
1486 (regex_grow_registers): Likewise.
1487 * sysdep.c (strerror): Likewise.
1488 * termcap.c (valid_filename_p, tprint, main): Likewise.
1489 * tparam.c (main): Likewise.
1490 * unexhp9k800.c (run_time_remap, save_data_space)
1491 (update_file_ptrs, read_header, write_header, calculate_checksum)
1492 (copy_file, copy_rest, display_header): Likewise.
1493 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1494 Likewise.
1495 * xdisp.c (check_it): Likewise.
1496 * xfaces.c (register_color, unregister_color, unregister_colors):
1497 Likewise.
1498 * xfns.c (print_fontset_result): Likewise.
1499 * xrdb.c (member, fatal, main): Likewise.
1500
99033785
PE
15012011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1502
1503 Fix minor problems found by static checking (Bug#9031).
1504 * chartab.c (char_table_set_range, map_sub_char_table):
1505 Remove unused locals.
1506 (uniprop_table): Now static.
1507 * composite.c (_work_char): Remove unused static var.
1508
9cb2ac56
JB
15092011-07-09 Juanma Barranquero <lekktu@gmail.com>
1510
1511 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1512
f25661f0
JD
15132011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1514
1515 * gtkutil.c (qttip_cb): Remove code without function.
1516
8278c4fe
EZ
15172011-07-09 Eli Zaretskii <eliz@gnu.org>
1518
1519 * w32.c (pthread_sigmask): New stub.
1520
1692ae2d 15212011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1522
8a6ebd58 1523 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1524 sigprocmask is portable only for single-threaded applications, and
1525 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1526 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1527 (LIBES): Use it.
1528 * callproc.c (Fcall_process):
1529 * process.c (create_process):
1530 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1531 Use pthread_sigmask, not sigprocmask.
123403e4 1532
1b854618
JD
15332011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1534
1535 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1536 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1537 wrong (Bug#8591).
1538
3fe4b549
JD
15392011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1540
0ce7e563
JD
1541 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1542 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1543 (xg_hide_tooltip): Fix comment.
1544
3fe4b549
JD
1545 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1546 in registerServicesMenuSendTypes.
1547 (validRequestorForSendType): Don't check ns_return_types.
1548
1549 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1550 ns_return_type.
1551
5df75e47
JR
15522011-07-08 Jason Rumney <jasonr@gnu.org>
1553
1554 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1555 frame struct members of non-existent frames (Bug#6284).
1556
699c10bd
JD
15572011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1558
4393663b
JD
1559 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1560 variable firstTime not needed on OSX >= 10.6.
1561 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1562 >= 10.5. Use setKnobProportion, setDoubleValue.
1563
1564 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1565 (MAC_OS_X_VERSION_10_5): Define if not defined.
1566 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1567 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1568 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1569
1570 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1571 cString and lossyCString on OSX >= 10.4
1572
1573 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1574 sizeToFit on OSX >= 10.2.
1575
1576 * nsimage.m (allocInitFromFile): Don't use deprecated method
1577 bestRepresentationForDevice on OSX >= 10.6.
1578
1579 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1580 to avoid warning.
1581
1582 * emacs.c: Declare unexec_init_emacs_zone.
1583
a63e0781
JD
1584 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1585
699c10bd
JD
1586 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1587
1588 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1589 on svcsMenu (Bug#8842).
1590
1591 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1592 ns_return_types.
1593 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1594
1595 * nsterm.m (QUTF8_STRING): Declare.
1596 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1597 (validRequestorForSendType): Return type is (id).
1598 Change indexOfObjectIdenticalTo to indexOfObject.
1599 Check if we have local selection before returning self (Bug#8842).
1600 (writeSelectionToPasteboard): Put local selection into paste board
1601 if we have a local selection (Bug#8842).
1602 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1603
1604 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1605 (ns_get_local_selection): Declare.
1606
54e10184
LMI
16072011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1608
9888ff71
LMI
1609 * keymap.c (describe_map_tree): Don't insert a double newline at
1610 the end of the buffer (bug#1169) and return whether we inserted
1611 something.
1612
54e10184
LMI
1613 * callint.c (Fcall_interactively): Change "reading args" to
1614 "providing args" to try to clarify what it does (bug#1010).
1615
15fa4783
KH
16162011-07-07 Kenichi Handa <handa@m17n.org>
1617
1618 * composite.c (composition_compute_stop_pos): Ignore a static
1619 composition starting before CHARPOS (Bug#8915).
1620
1621 * xdisp.c (handle_composition_prop): Likewise.
1622
a8815b00
EZ
16232011-07-07 Eli Zaretskii <eliz@gnu.org>
1624
1625 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1626 (Bug#9015)
1627
ef7b981d 16282011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1629
1630 * character.h (unicode_category_t): New enum type.
1631
1632 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1633 (Qchar_code_property_table): New variable.
1634 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1635 (UNIPROP_COMPRESSED_FORM_P): New macros.
1636 (char_table_ascii): Uncompress the compressed values.
1637 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1638 Uncompress the compressed values.
ac389d0c 1639 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1640 (char_table_ref_and_range): Uncompress the compressed values.
1641 (sub_char_table_set): New arg is_uniprop. Callers changed.
1642 Uncompress the compressed values.
1643 (sub_char_table_set_range): Args changed. Callers changed.
1644 (char_table_set_range): Adjuted for the above change.
1645 (map_sub_char_table): Delete args default_val and parent. Add arg
1646 top. Give decoded values to a Lisp function.
640c8776 1647 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1648 values to a Lisp function. Gcpro more variables.
1649 (uniprop_table_uncompress)
1650 (uniprop_decode_value_run_length): New functions.
1651 (uniprop_decoder, uniprop_decoder_count): New variables.
1652 (uniprop_get_decoder, uniprop_encode_value_character)
1653 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1654 New functions.
1655 (uniprop_encoder, uniprop_encoder_count): New variables.
1656 (uniprop_get_encoder, uniprop_table)
1657 (Funicode_property_table_internal, Fget_unicode_property_internal)
1658 (Fput_unicode_property_internal): New functions.
1659 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1660 Sunicode_property_table_internal, Sget_unicode_property_internal,
1661 and Sput_unicode_property_internal. Defvar_lisp
1662 char-code-property-alist.
1663
640c8776 1664 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1665 Vunicode_category_table.
1666
640c8776 1667 * font.c (font_range): Adjust for the change of
c805dec0
KH
1668 Vunicode_category_table.
1669
76b397fb
DN
16702011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1671
1672 * m/iris4d.h: Remove file, move contents ...
1673 * s/irix6-5.h: ... here.
1674
22b4128e
PE
16752011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1676
1677 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1678 * alloc.c (mark_buffer):
1679 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1680 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1681 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1682 This isn't true in general, and it's particularly not true
1683 if Emacs is configured with --with-wide-int.
1684 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1685 New macros, used in the buffer.c change.
1686
869795d6
JD
16872011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1688
1689 * xsettings.c: Use both GConf and GSettings if both are available.
1690 (store_config_changed_event): Add comment.
1691 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1692 (store_tool_bar_style_changed): New functions.
1693 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1694 (struct xsettings): Move font inside HAVE_XFT.
1695 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1696 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1697 Move inside HAVE_XFT.
640c8776 1698 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1699 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1700 also.
1701 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1702 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1703 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1704 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1705 (parse_settings): Move check for font inside HAVE_XFT.
1706 (read_settings, apply_xft_settings): Add comment.
1707 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1708 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1709 call store_font_name_changed.
1710 (xft_settings_event): Add comment.
1711 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1712 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1713 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1714 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1715 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1716 (xsettings_get_system_font, xsettings_get_system_normal_font):
1717 Add comment.
869795d6 1718
d8ed26bd
PE
17192011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1720
1721 Random fixes. E.g., (random) never returned negative values.
1722 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1723 subseconds part to the entropy, as that's a bit more random.
1724 Prefer signed to unsigned, since the signedness doesn't matter and
1725 in general we prefer signed. When given a limit, use a
1726 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1727 latter isn't right if USE_2_TAGS_FOR_INTS.
1728 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1729 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1730
cabf1cac
SM
17312011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1732
1733 * textprop.c (text_property_stickiness):
1734 Obey Vtext_property_default_nonsticky.
1735 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1736 * w32fns.c (syms_of_w32fns):
1737 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1738
6e9b2be9
PE
17392011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1740
1741 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1742 This is more efficient than Ffile_directory_p and avoids a minor race.
1743
90186c68
LMI
17442011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1745
7c301272
LMI
1746 * buffer.c (Foverlay_put): Say what the return value is
1747 (bug#7835).
1748
c4f2d8d4
LMI
1749 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1750 is a directory before asking whether to use the file name
1751 (bug#7564).
ad637907
LMI
1752 (barf_or_query_if_file_exists): Make the "File is a directory"
1753 error be more correct.
c4f2d8d4 1754
90186c68
LMI
1755 * fns.c (Frequire): Remove the mention of the .gz files, since
1756 that's installation-specific, but keep the mention of
1757 `get-load-suffixes'.
1758
da64016e
PE
17592011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1760
1761 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1762 Report string overflow if the output is too long.
1763
7d47b580
JB
17642011-07-04 Juanma Barranquero <lekktu@gmail.com>
1765
a555cb87
JB
1766 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1767 (syms_of_gnutls): Remove duplicate DEFSYM for
1768 Qgnutls_bootprop_verify_hostname_error, an error for
1769 Qgnutls_bootprop_verify_error (which is no longer used).
1770
7d47b580
JB
1771 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1772 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1773 Also (re)move comments that are misplaced or no longer relevant.
1774
1e49bfab
LMI
17752011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1776
1777 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1778
1485f4c0
CY
17792011-07-03 Chong Yidong <cyd@stupidchicken.com>
1780
1781 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1782 and background color parameters if they have been changed.
1783
a9ab721e
LMI
17842011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1785
1786 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1787
cf7cff57
PE
17882011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1789
2e13213d
PE
1790 * xsettings.c (SYSTEM_FONT): Define only when used.
1791 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1792
cf7cff57
PE
1793 * keymap.c (access_keymap_1): Now static.
1794
7a8e04f7
CY
17952011-07-02 Chong Yidong <cyd@stupidchicken.com>
1796
1797 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1798 leave any prefix arg for the up event (Bug#1586).
1799
61352f62
LMI
18002011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1801
69bb1ef7
LMI
1802 * lread.c (syms_of_lread): Mention single symbols defined by
1803 `defvar' or `defconst' (bug#7154).
1804
61352f62 1805 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1806 (Frequire): Mention get-load-suffixes.
61352f62 1807
28545e04
MR
18082011-07-02 Martin Rudalics <rudalics@gmx.at>
1809
1810 * window.h (window): Remove clone_number slot.
1811 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1812 Remove.
1813 (make_parent_window, make_window, saved_window)
1814 (Fset_window_configuration, save_window_save): Don't deal with
1815 clone numbers.
1816 * buffer.c (Qclone_number): Remove declaration.
1817 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1818
3349e122
SM
18192011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1820
1821 Add multiple inheritance to keymaps.
1822 * keymap.c (Fmake_composed_keymap): New function.
1823 (Fset_keymap_parent): Simplify.
1824 (fix_submap_inheritance): Remove.
1825 (access_keymap_1): New function extracted from access_keymap to handle
1826 embedded parents and handle lists of maps.
1827 (access_keymap): Use it.
1828 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1829 (Fcopy_keymap): Handle embedded parents.
1830 (Fcommand_remapping, define_as_prefix): Simplify.
1831 (Fkey_binding): Simplify.
1832 (syms_of_keymap): Move minibuffer-local-completion-map,
1833 minibuffer-local-filename-completion-map,
1834 minibuffer-local-must-match-map, and
1835 minibuffer-local-filename-must-match-map to Elisp.
1836 (syms_of_keymap): Defsubr make-composed-keymap.
1837 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1838 (parse_menu_item): Trivial simplification.
1839
3279eb87
GM
18402011-07-01 Glenn Morris <rgm@gnu.org>
1841
1842 * Makefile.in (SETTINGS_LIBS): Fix typo.
1843
4550efdf
KI
18442011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1845
1846 * coding.c (Fencode_coding_string): Record the last coding system
1847 used, as the function doc string says (bug#8738).
1848
0949d2b6
JD
18492011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1850
1851 * xsettings.c (store_monospaced_changed): Take new font as arg and
1852 check for change against current_mono_font.
1853 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1854 (emacs_settings_constructor, emacs_settings_get_property)
1855 (emacs_settings_set_property, emacs_settings_class_init)
1856 (emacs_settings_init, gsettings_obj): Remove.
1857 (something_changedCB): New function for HAVE_GSETTINGS.
1858 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1859 with value as argument.
1860 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1861 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1862 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1863 "changed".
1864
1865 * xgselect.c: Add defined (HAVE_GSETTINGS).
1866 (xgselect_initialize): Ditto.
1867
1868 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1869 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1870 xg_select.
1871
bbc6b304
PE
18722011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1873
1874 * eval.c (struct backtrace): Simplify and port the data structure.
1875 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1876 signed bit field, as this assumption is not portable and it makes
1877 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1878 "char debug_on_exit : 1" as this is not portable either; instead,
1879 use the portable "unsigned int debug_on_exit : 1". Remove unused
1880 member evalargs. Remove obsolete comments about cc bombing out.
1881
9851bfc5
JD
18822011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1883
51bb811f 1884 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1885 Let HAVE_GSETTINGS override HAVE_GCONF.
1886 (store_monospaced_changed): New function.
1887 (EMACS_SETTINGS): A new type derived from GObject to handle
1888 GSettings notifications.
1889 (emacs_settings_constructor, emacs_settings_get_property)
1890 (emacs_settings_set_property, emacs_settings_class_init):
1891 New functions.
1892 (gsettings_client, gsettings_obj): New variables.
1893 (GSETTINGS_SCHEMA): New define.
1894 (something_changedCB): Call store_monospaced_changed.
1895 (init_gsettings): New function.
1896 (xsettings_initialize): Call init_gsettings.
1897 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1898 to NULL.
1899
640c8776 1900 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1901 GCONF_CFLAGS/LIBS.
1902
5386012d
MR
19032011-06-29 Martin Rudalics <rudalics@gmx.at>
1904
1905 * window.c (resize_root_window, grow_mini_window)
1906 (shrink_mini_window): Rename Qresize_root_window to
1907 Qwindow_resize_root_window and Qresize_root_window_vertically to
1908 Qwindow_resize_root_window_vertically.
1909
f13e0b08
PE
19102011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1911
1912 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1913
94515237
JB
19142011-06-27 Juanma Barranquero <lekktu@gmail.com>
1915
1916 * makefile.w32-in: Redesign dependencies so they reflect more
1917 clearly which files are directly included by each source file,
1918 and not through other includes.
1919
e43b6e43
MR
19202011-06-27 Martin Rudalics <rudalics@gmx.at>
1921
1922 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1923 (sort_overlays, overlay_strings): When an overlay's clone number
1924 matches the window's clone number process the overlay even if
1925 the overlay's window property doesn't match the current window.
1926
d68443dc
MR
1927 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1928 (Fwindow_hchild): Rename to Fwindow_left_child.
1929 (Fwindow_next): Rename to Fwindow_next_sibling.
1930 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1931 (resize_window_check): Rename to window_resize_check.
1932 (resize_window_apply): Rename to window_resize_apply.
1933 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1934 (Fdelete_other_windows_internal, resize_frame_windows)
1935 (Fsplit_window_internal, Fdelete_window_internal)
1936 (grow_mini_window, shrink_mini_window)
1937 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1938
c7e73be5
JD
19392011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1940
1941 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1942 (emacs_fixed_set_min_size): Remove.
1943 (emacs_fixed_new): Take frame as argument.
1944
1945 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1946 (_EmacsFixedPrivate): Remove minwidth/height.
1947 Add struct frame *f.
1948 (emacs_fixed_init): Initialize priv->f.
1949 (get_parent_class, emacs_fixed_set_min_size): Remove.
1950 (emacs_fixed_new): Set priv->f to argument.
1951 (emacs_fixed_get_preferred_width)
1952 (emacs_fixed_get_preferred_height): Use min_width/height from
1953 frames size_hint to set minimum and natural (Bug#8919).
1954 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1955 and use min_width/height from frames size_hint to set
1956 min_width/height (Bug#8919).
1957
1958 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1959 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1960 Fix indentation.
c7e73be5 1961
cf99dcf8
EZ
19622011-06-26 Eli Zaretskii <eliz@gnu.org>
1963
1964 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1965 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1966 called at ZV.
1967
029529ac
CY
19682011-06-26 Chong Yidong <cyd@stupidchicken.com>
1969
1970 * process.c (wait_reading_process_output): Bypass select if
1971 waiting for a cell while ignoring keyboard input, and input is
1972 pending. Suggested by Jan Djärv (Bug#8869).
1973
7a7ef429
PE
19742011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1975
1976 Use gnulib's dup2 module instead of rolling our own.
1977 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1978
11fdef7d 19792011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1980
1981 * dispnew.c (scrolling_window): Before scrolling, turn off a
1982 mouse-highlight in the window being scrolled.
1983
cd3520a4
JB
19842011-06-24 Juanma Barranquero <lekktu@gmail.com>
1985
1986 Move DEFSYM to lisp.h and use everywhere.
1987
1988 * character.h (DEFSYM): Move declaration...
1989 * lisp.h (DEFSYM): ...here.
1990
1991 * gnutls.c:
1992 * minibuf.c:
1993 * w32menu.c:
1994 * w32proc.c:
1995 * w32select.c: Don't include character.h.
1996
1997 * alloc.c (syms_of_alloc):
1998 * buffer.c (syms_of_buffer):
1999 * bytecode.c (syms_of_bytecode):
2000 * callint.c (syms_of_callint):
2001 * casefiddle.c (syms_of_casefiddle):
2002 * casetab.c (init_casetab_once):
2003 * category.c (init_category_once, syms_of_category):
2004 * ccl.c (syms_of_ccl):
2005 * cmds.c (syms_of_cmds):
2006 * composite.c (syms_of_composite):
2007 * dbusbind.c (syms_of_dbusbind):
2008 * dired.c (syms_of_dired):
2009 * dispnew.c (syms_of_display):
2010 * doc.c (syms_of_doc):
2011 * editfns.c (syms_of_editfns):
2012 * emacs.c (syms_of_emacs):
2013 * eval.c (syms_of_eval):
2014 * fileio.c (syms_of_fileio):
2015 * fns.c (syms_of_fns):
2016 * frame.c (syms_of_frame):
2017 * fringe.c (syms_of_fringe):
2018 * insdel.c (syms_of_insdel):
2019 * keymap.c (syms_of_keymap):
2020 * lread.c (init_obarray, syms_of_lread):
2021 * macros.c (syms_of_macros):
2022 * msdos.c (syms_of_msdos):
2023 * print.c (syms_of_print):
2024 * process.c (syms_of_process):
2025 * search.c (syms_of_search):
2026 * sound.c (syms_of_sound):
2027 * syntax.c (init_syntax_once, syms_of_syntax):
2028 * terminal.c (syms_of_terminal):
2029 * textprop.c (syms_of_textprop):
2030 * undo.c (syms_of_undo):
2031 * w32.c (globals_of_w32):
2032 * window.c (syms_of_window):
2033 * xdisp.c (syms_of_xdisp):
2034 * xfaces.c (syms_of_xfaces):
2035 * xfns.c (syms_of_xfns):
2036 * xmenu.c (syms_of_xmenu):
2037 * xsettings.c (syms_of_xsettings):
2038 * xterm.c (syms_of_xterm): Use DEFSYM.
2039
4228cf16
TZ
20402011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2041
cd3520a4 2042 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2043
7fcccf1e
PE
20442011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2045
7efb4e0e
PE
2046 Integer and buffer overflow fixes (Bug#8873).
2047
ff5844ad
PE
2048 * print.c (printchar, strout): Check for string overflow.
2049 (PRINTPREPARE, printchar, strout):
2050 Don't set size unless allocation succeeds.
2051
90532f02
PE
2052 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2053 for sizes. Check for string overflow more accurately.
2054 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2055
6d84508d
PE
2056 * macros.c: Integer and buffer overflow fixes.
2057 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2058 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2059 Use ptrdiff_t, not int, for sizes.
2060 Don't increment bufsize until after realloc succeeds.
2061 Check for size-calculation overflow.
2062 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2063
437b2cb4
PE
2064 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2065
8b9ac8b4
PE
2066 * lread.c: Integer overflow fixes.
2067 (read_integer): Radix is now EMACS_INT, not int,
2068 to improve quality of diagnostics for out-of-range radices.
2069 Calculate buffer size correctly for out-of-range radices.
2070 (read1): Check for integer overflow in radices, and in
2071 read-circle numbers.
82cb60d3
PE
2072 (read_escape): Avoid int overflow.
2073 (Fload, openp, read_buffer_size, read1)
2074 (substitute_object_recurse, read_vector, read_list, map_obarray):
2075 Use ptrdiff_t, not int, for sizes.
2076 (read1): Use EMACS_INT, not int, for sizes.
20270765 2077 Check for size overflow.
8b9ac8b4 2078
7fcccf1e
PE
2079 * image.c (cache_image): Check for size arithmetic overflow.
2080
bfbbd7e7
PE
2081 * lread.c: Integer overflow issues.
2082 (saved_doc_string_size, saved_doc_string_length)
2083 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2084 Now ptrdiff_t, not int.
2085 (read1): Don't assume doc string length fits in int. Check for
2086 out-of-range doc string lengths.
2087 (read_list): Don't assume file position fits in int.
39019e54 2088 (read_escape): Check for hex character overflow.
bfbbd7e7 2089
4e323265
LL
20902011-06-22 Leo Liu <sdl.web@gmail.com>
2091
2092 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2093 Move to minibuffer.el.
2094
85fece3e
PE
20952011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2096
20b84ce9 2097 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2098 The following patches are for when GLYPH_DEBUG && !XASSERT.
2099 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2100 * dispnew.c (flush_stdout):
2101 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2102 Mark as externally visible.
2103 * dispnew.c (check_window_matrix_pointers): Now static.
2104 * dispnew.c (window_to_frame_vpos):
2105 * xfns.c (unwind_create_frame):
2106 * xterm.c (x_check_font): Remove unused local.
2107 * scroll.c (CHECK_BOUNDS):
2108 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2109 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2110 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2111 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2112 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2113 Now static.
2114 (debug_method_add): Use va_list and vsprintf rather than relying
2115 on undefined behavior with wrong number of arguments.
2116 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2117 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2118 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2119 since we're not interested in debugging glyphs with old libraries.
2120 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2121 GCC 4.6.0's static checking.
2122
0766b489
PE
21232011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2124
31fd4b32
PE
2125 Integer overflow and signedness fixes (Bug#8873).
2126 A few related buffer overrun fixes, too.
2127
b79e8648
PE
2128 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2129
0766b489
PE
2130 * dispextern.h (struct face.stipple):
2131 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2132 (x_bitmap_mask, x_allocate_bitmap_record)
2133 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2134 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2135 (x_create_bitmap_from_xpm_data):
2136 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2137 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2138 (.bitmaps_last):
2139 * xfaces.c (load_pixmap):
2140 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2141 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2142 (.bitmaps_last, struct x_output.icon_bitmap):
2143 Use ptrdiff_t, not int, for bitmap indexes.
2144 (x_allocate_bitmap_record): Check for size overflow.
2145 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2146
b081724f
PE
2147 Use ptrdiff_t, not int, for overlay counts.
2148 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2149 * editfns.c (overlays_around, get_pos_property):
2150 * textprop.c (get_char_property_and_overlay):
2151 * xdisp.c (next_overlay_change, note_mouse_highlight):
2152 * xfaces.c (face_at_buffer_position):
21514da7
PE
2153 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2154 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2155 (Fnext_overlay_change, Fprevious_overlay_change)
2156 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2157 Use ptrdiff_t, not int, for sizes.
21514da7 2158 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2159
3de73e5e
PE
2160 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2161
2606c57b
PE
2162 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2163 (x_session_initialize): Do not assume string length fits in int.
2164
aaafe47a
PE
2165 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2166 This is unlikely, but can occur if DPI is outlandish.
2167
2674ddc8 2168 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2169 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2170
28154962
PE
2171 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2172 * xrdb.c (magic_file_p, search_magic_path):
2173 Omit last arg SUFFIX; it was always 0. All callers changed.
2174 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2175
7de51af5
PE
2176 * xfont.c (xfont_match): Avoid need for strlen.
2177
25ed6cc3
PE
2178 * xfns.c: Don't assume strlen fits in int.
2179 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2180
4eab31dd
PE
2181 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2182 not unsigned long, as we prefer signed integers. All callers changed.
2183 Detect integer overflow in repeat count.
2184 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2185 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2186
171e2a58
PE
2187 * termcap.c: Don't assume sizes fit in int and never overflow.
2188 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2189 (gobble_line): Check for size-calculation overflow.
2190
ad39faca 2191 * minibuf.c (Fread_buffer):
6e5bb2dc 2192 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2193 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2194 Don't assume string length fits in int.
2195
52c61c22 2196 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2197 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2198
b5b8c9e5
PE
2199 * font.c: Don't assume string length fits in int.
2200 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2201 Use ptrdiff_t, not int.
ccd6111c
PE
2202 (font_intern_prop): Don't assume string length fits in int.
2203 Don't assume integer property fits in fixnum.
2204 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2205
882f0d81 2206 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2207 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2208 Reformulate so as not to need the command string.
2209 Invoke gzip -cd rather than gunzip, as it's more portable.
2210 (lock_info_type, lock_file_1, lock_file):
2211 Don't assume pid_t and time_t fit in unsigned long.
2212 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2213 (current_lock_owner): Prefer signed type for sizes.
2214 Use memcpy, not strncpy, where memcpy is what is really wanted.
2215 Don't assume (via atoi) that time_t and pid_t fit in int.
2216 Check for time_t and/or pid_t out of range, e.g., via a network share.
2217 Don't alloca where an auto var works fine.
2218
93f4cf88
PE
2219 * fileio.c: Fix some integer overflow issues.
2220 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2221 Don't assume string length fits in int.
2222 (directory_file_name): Don't assume string length fits in long.
2223 (make_temp_name): Don't assume pid fits in int, or that its print
2224 length is less than 20.
2225
f3e92b69
PE
2226 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2227
1bfdaf10
PE
2228 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2229
35016e9a
PE
2230 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2231
3d1e65a1
PE
2232 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2233 We prefer signed integers, even for size calculations.
2234
0b963a93
PE
2235 * emacs.c: Don't assume string length fits in 'int'.
2236 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2237 (main): Don't invoke strlen when not needed.
2238
573f4b54
PE
2239 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2240 (XD_DEBUG_MESSAGE): Don't waste a byte.
2241
989f33ba
PE
2242 * callproc.c (getenv_internal_1, getenv_internal)
2243 (Fgetenv_internal):
965d34eb
PE
2244 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2245
e4d29b33
PE
2246 * lread.c (invalid_syntax): Omit length argument.
2247 All uses changed. This doesn't fix a bug, but it simplifies the
2248 code away from its former Hollerith-constant appearance, and it's
2249 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2250 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2251
eb49b136
PE
2252 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2253 This didn't break anything, but it didn't help either.
2254 It's confusing to put a bogus integer in a place where the actual
2255 value does not matter.
9f62aeb1 2256 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2257 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2258
15375a22
PE
2259 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2260 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2261 implementation.
b61cc01c
PE
2262 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2263 We prefer signed types, and the value cannot exceed the EMACS_INT
2264 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2265 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2266 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2267 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2268
53b2623d
PE
2269 * indent.c (sane_tab_width): New function.
2270 (current_column, scan_for_column, Findent_to, position_indentation)
2271 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2272 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2273
51cab52b 2274 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2275
f2ed8a70
PE
2276 * lisp.h (lint_assume): New macro.
2277 * composite.c (composition_gstring_put_cache):
2278 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2279
abe80cc6
PE
2280 * editfns.c, insdel.c:
2281 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2282
b02c740e
PE
2283 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2284
ebc96716
PE
2285 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2286
b4e50fa0 2287 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2288 Use much-faster test for byte-length change.
311d5d7c 2289 Don't assume string byte-length fits in 'int'.
a4cf38e4 2290 Check that character arg fits in 'int'.
85461888 2291 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2292
c0c1ee9f
PE
2293 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2294
a498d7f4
PE
2295 * fns.c (concat): Catch string overflow earlier.
2296 Do not rely on integer wraparound.
2297
51cab52b
PE
2298 * dispextern.h (struct it.overlay_strings_charpos)
2299 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2300 * xdisp.c (forward_to_next_line_start)
2301 (back_to_previous_visible_line_start)
2302 (reseat_at_next_visible_line_start, next_element_from_buffer):
2303 Don't arbitrarily truncate the value of 'selective' to int.
2304
76031fad
PE
2305 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2306
5eb55db9
PE
2307 * composite.c: Don't truncate sizes to 'int'.
2308 (composition_gstring_p, composition_reseat_it)
2309 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2310 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2311 not EMACS_UINT, for indexes.
5eb55db9 2312
0703a717
PE
2313 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2314
d6202519
PE
2315 * buffer.c: Include <verify.h>.
2316 (struct sortvec.priority, struct sortstr.priority):
8961a454 2317 Now EMACS_INT, not int.
c20998a7 2318 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2319 (struct sortstr.size, record_overlay_string)
2320 (struct sortstrlist.size, struct sortlist.used):
2321 Don't truncate size to int.
2322 (record_overlay_string): Check for size-calculation overflow.
d6202519 2323 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2324
d5a19415
JM
23252011-06-22 Jim Meyering <meyering@redhat.com>
2326
029529ac 2327 Don't leak an XBM-image-sized buffer
d5a19415
JM
2328 * image.c (xbm_load): Free the image buffer after using it.
2329
a9041e6c
PE
23302011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2331
2332 Port to Sun C.
2333 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2334 that Sun C diagnosed.
2335 * fns.c (secure_hash): Fix pointer signedness issue.
2336 * intervals.c (static_offset_intervals): New function.
2337 (offset_intervals): Use it.
2338
7f3f739f
LL
23392011-06-21 Leo Liu <sdl.web@gmail.com>
2340
2341 * deps.mk (fns.o):
2342 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2343 sha512.h.
2344
2345 * fns.c (secure_hash): Rename from crypto_hash_function and change
2346 the first arg to accept symbols.
5b66d427 2347 (Fsecure_hash): New primitive.
7f3f739f
LL
2348 (syms_of_fns): New symbols.
2349
76147d94
DD
23502011-06-20 Deniz Dogan <deniz@dogan.se>
2351
2352 * process.c (Fset_process_buffer): Clarify return value in
2353 docstring.
2354
7d7d0045
CY
23552011-06-18 Chong Yidong <cyd@stupidchicken.com>
2356
2357 * dispnew.c (add_window_display_history): Use BVAR.
2358
2359 * xdisp.c (debug_method_add): Use BVAR.
2360 (check_window_end, dump_glyph_matrix, dump_glyph)
2361 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2362
2363 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2364 Likewise.
2365
2366 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2367 check till after the cache is created in init_frame_faces.
2368
ff2bc410
SM
23692011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2370
2371 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2372
28177add
PE
23732011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2374
dd3482fe
PE
2375 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2376 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2377 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2378
393d71f3 2379 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2380 * fileio.c (Finsert_file_contents):
2381 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2382 Remove the old (too-loose) buffer overflow checks.
2383 They weren't needed, since make_gap checks for buffer overflow.
2384 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2385 The old code merely checked for Emacs fixnum overflow, and relied
2386 on undefined (wraparound) behavior. The new code avoids undefined
2387 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2388
2e6813b0 2389 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2390 Tune. Don't use wider integers than needed. Don't use alloca.
2391 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2392
599a9e4f
PE
2393 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2394
99561444
PE
2395 * insdel.c, lisp.h (buffer_overflow): New function.
2396 (insert_from_buffer_1, replace_range, replace_range_2):
2397 * insdel.c (make_gap_larger):
2398 * editfns.c (Finsert_char):
2399 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2400
28177add
PE
2401 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2402
e69dafad
PE
24032011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2404
a7af7fde 2405 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2406
b1c46f02
PE
2407 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2408 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2409
e69dafad
PE
2410 * fileio.c: Don't assume EMACS_INT fits in off_t.
2411 (emacs_lseek): New static function.
2412 (Finsert_file_contents, Fwrite_region): Use it.
2413 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2414
566684ea
PE
2415 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2416
e6966cd6
PE
2417 * fns.c: Don't overflow int when computing a list length.
2418 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2419 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2420 truncation on 64-bit hosts. Check for QUIT every
2421 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2422 faster and is responsive enough.
2423 (Flength): Report an error instead of overflowing an integer.
2424 (Fsafe_length): Return a float if the value is not representable
2425 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2426 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2427 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2428
dd0b0efb
PE
2429 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2430 (header_size, word_size): New constants.
2431 (allocate_vectorlike): Don't check size overflow here.
2432 (allocate_vector): Check it here instead, since this is the only
2433 caller of allocate_vectorlike that could cause overflow.
2434 Check that the new vector's length is representable as a fixnum.
2435
86fe5cfe
PE
2436 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2437 The previous code was bogus. For example, next_almost_prime (32)
2438 returned 39, which is undesirable as it is a multiple of 3; and
2439 next_almost_prime (24) returned 25, which is a multiple of 5 so
2440 why was the code bothering to check for multiples of 7?
2441
80e88859
PE
2442 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2443
4a2f0ad6
PE
2444 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2445
f66c7cf8
PE
2446 Variadic C functions now count arguments with ptrdiff_t.
2447 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2448 Back then I didn't know that the Emacs coding style prefers signed int.
2449 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2450 were being counted with int, which may truncate counts on 64-bit
2451 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2452 * lisp.h (struct Lisp_Subr.function.aMANY)
2453 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2454 Arg counts are now ptrdiff_t, not size_t.
2455 All variadic functions and their callers changed accordingly.
2456 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2457 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2458 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2459 * callint.c (Fcall_interactively): Check arg count for overflow,
2460 to avoid potential buffer overrun. Use signed char, not 'int',
2461 for 'varies' array, so that we needn't bother to check its size
2462 calculation for overflow.
2463 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2464 * eval.c (apply_lambda):
2465 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2466 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2467 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2468
a1759b76
PE
2469 * callint.c (Fcall_interactively): Don't use index var as event count.
2470
d96be9fc
PE
2471 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2472 * mem-limits.h (SIZE): Remove; no longer used.
2473
a690a978 2474 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2475
578c21e6
PE
2476 Remove unnecessary casts.
2477 * xterm.c (x_term_init):
2478 * xfns.c (x_set_border_pixel):
2479 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2480 These aren't needed now that we assume ANSI C.
2481
96f53c6c
PE
2482 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2483 It's more likely to cause problems (due to unsigned overflow)
2484 than to cure them.
2485
83c77d31
PE
2486 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2487
ee2079f1
PE
2488 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2489
6da65536
PE
2490 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2491
7147c4a4
PE
2492 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2493
193e32d9
PE
2494 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2495
e5533da6
PE
2496 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2497
9910e595
PE
2498 GLYPH_CODE_FACE returns EMACS_INT, not int.
2499 * dispextern.h (merge_faces):
2500 * xfaces.c (merge_faces):
01103c44
PE
2501 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2502 Don't assume EMACS_INT fits in int.
9910e595 2503
2638320e
PE
2504 * character.h (CHAR_VALID_P): Remove unused parameter.
2505 * fontset.c, lisp.h, xdisp.c: All uses changed.
2506
045eb8d9
PE
2507 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2508
c1f134b5
PE
2509 * fns.c (concat): Minor tuning based on overflow analysis.
2510 This doesn't fix any bugs. Use int to hold character, instead
2511 of constantly refetching from Emacs object. Use XFASTINT, not
2512 XINT, for value known to be a character. Don't bother comparing
2513 a single byte to 0400, as it's always less.
2514
395fcb93 2515 * floatfns.c (Fexpt):
327eeec8
PE
2516 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2517
abbd3d23
PE
2518 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2519 for characters.
2520
684a03ef
PE
2521 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2522
0fed43f3
PE
2523 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2524 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2525 incorrectly succeed when S was a string, because 4294967386 was
2526 truncated before it was used.
2527
8fd02eb7
PE
2528 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2529 Otherwise, an out-of-range integer could cause undefined behavior
2530 on a 64-bit host.
2531
f8c86b69
PE
2532 * composite.c: Use int, not EMACS_INT, for characters.
2533 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2534 EMACS_INT, for values that are known to be in character range.
2535 This doesn't fix any bugs but is the usual style inside Emacs and
2536 may generate better code on 32-bit machines.
2537
34206dd2
PE
2538 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2539 This is for reasons similar to the recent CHAR_STRING fix.
2540 * charset.c (Fencode_char): Check that character arg is actually
2541 a character. Pass an int to ENCODE_CHAR.
2542 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2543 wider than 'int', as a compile-time check to prevent future regressions
2544 in this area.
2545
c5958d4c 2546 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2547
2548 Make sure a 64-bit char is never passed to CHAR_STRING.
2549 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2550 by silently ignoring the top 32 bits, allowing some values
2551 that were far too large to be valid characters.
2552 * character.h: Include <verify.h>.
2553 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2554 arguments are no wider than unsigned, as a compile-time check
2555 to prevent future regressions in this area.
2556 * data.c (Faset):
01103c44 2557 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2558 (Fsubst_char_in_region):
2559 * fns.c (concat):
2560 * xdisp.c (decode_mode_spec_coding):
2561 Adjust to CHAR_STRING's new requirement.
2562 * editfns.c (Finsert_char, Fsubst_char_in_region):
2563 * fns.c (concat): Check that character args are actually
2564 characters. Without this test, these functions did the wrong
2565 thing with wildly out-of-range values on 64-bit hosts.
2566
d37ca623
PE
2567 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2568 These casts should not be needed on 32-bit hosts, either.
2569 * keyboard.c (read_char):
2570 * lread.c (Fload): Remove casts to unsigned.
2571
ea204efb
PE
2572 * lisp.h (UNSIGNED_CMP): New macro.
2573 This fixes comparison bugs on 64-bit hosts.
2574 (ASCII_CHAR_P): Use it.
2575 * casefiddle.c (casify_object):
01103c44 2576 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2577 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2578 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2579 * dispextern.h (FACE_FROM_ID):
2580 * keyboard.c (read_char): Use UNSIGNED_CMP.
2581
41cb286c
PE
2582 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2583 not to EMACS_INT, to avoid GCC warning.
2584
4a1b9832
PE
2585 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2586
55daad71
PE
2587 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2588 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2589 isn't needed on 32-bit machines.
8f95c75c 2590
01103c44
PE
2591 * buffer.c (Fgenerate_new_buffer_name):
2592 Use EMACS_INT for count, not int.
0ceccced 2593 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2594
2595 * data.c (Qcompiled_function): Now static.
2596
c6f072e7
PE
2597 * window.c (window_body_lines): Now static.
2598
20ce5912
PE
2599 * image.c (gif_load): Rename local to avoid shadowing.
2600
9c4c5f81
PE
2601 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2602 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2603 * alloc.c (make_save_value): Integer argument is now of type
2604 ptrdiff_t, not int.
2605 (mark_object): Use ptrdiff_t, not int.
2606 * lisp.h (pD): New macro.
2607 * print.c (print_object): Use it.
2608
c0c5c8ae
PE
2609 * alloc.c: Use EMACS_INT, not int, to count objects.
2610 (total_conses, total_markers, total_symbols, total_vector_size)
2611 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2612 (total_free_floats, total_floats, total_free_intervals)
2613 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2614 Now EMACS_INT, not int. All uses changed.
2615 (Fgarbage_collect): Compute overall total using a double, so that
2616 integer overflow is less likely to be a problem. Check for overflow
2617 when converting back to an integer.
5a25e253
PE
2618 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2619 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2620 These were 'int' variables that could overflow on 64-bit hosts;
2621 they were never used, so remove them instead of repairing them.
211a0b2a 2622 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2623 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2624 Previously, this ceilinged at INT_MAX, but that doesn't work on
2625 64-bit machines.
e46bb31a 2626 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2627
c78baabf 2628 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2629 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2630 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2631 when a (possibly-narrower) signed value would do just as well.
2632 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2633
c9d624c6
PE
2634 * alloc.c: Catch some string size overflows that we were missing.
2635 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2636 for convenience in STRING_BYTES_MAX.
2637 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2638 The definition here is exact; the one in lisp.h was approximate.
2639 (allocate_string_data): Check for string overflow. This catches
2640 some instances we weren't catching before. Also, it catches
2641 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2642 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2643 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2644
c9d624c6
PE
2645 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2646 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2647 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2648
353032ce
PE
2649 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2650
2bccce07
PE
2651 * alloc.c (Fmake_string): Check for out-of-range init.
2652
0ac30604
SM
26532011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2654
2655 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2656
c195f2de
JD
26572011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2658
2659 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2660 xg_get_default_scrollbar_width.
2661
2662 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2663 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2664 (style_changed_cb): Call update_theme_scrollbar_width and call
2665 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2666 all frames (Bug#8505).
2667 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2668 Call gtk_window_set_resizable if HAVE_GTK3.
2669 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2670 and height if HAVE_GTK3 (Bug#8505).
2671 (scroll_bar_width_for_theme): New variable.
2672 (update_theme_scrollbar_width): New function.
2673 (xg_get_default_scrollbar_width): Move code to
2674 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2675 (xg_initialize): Call update_theme_scrollbar_width.
2676
2677 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2678
2679 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2680
e10ac9f1
MR
26812011-06-12 Martin Rudalics <rudalics@gmx.at>
2682
2683 * frame.c (make_frame): Call other_buffer_safely instead of
2684 other_buffer.
2685
2686 * window.c (temp_output_buffer_show): Call display_buffer with
2687 second argument Vtemp_buffer_show_specifiers and reset latter
2688 immediately after the call.
2689 (Vtemp_buffer_show_specifiers): New variable.
2690 (auto_window_vscroll_p, next_screen_context_lines)
2691 (Vscroll_preserve_screen_position): Remove leading asterisks from
2692 doc-strings.
2693
2d3c217e 26942011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2695
7b7f97e8 2696 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2697 * buffer.c (Qclone_number): Remove for now, as it's unused.
2698 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2699 (record_buffer): Remove unused local.
2700 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2701 (set_frame_buffer_list): Remove; unused.
2702 * frame.h (other_visible_frames): Remove decl.
2703 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2704 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2705 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2706 if HAVE_GPM.
2707 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2708 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2709 Define only if HAVE_GPM.
2710 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2711 (update_hints_inhibit): Remove; never set. All uses removed.
2712 * widgetprv.h (emacsFrameClassRec): Remove decl.
2713 * window.c (delete_deletable_window): Now returns void, since it
2714 wasn't returning anything.
2715 (compare_window_configurations): Remove unused locals.
2716 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2717 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2718 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2719 the same widths as pointers. This follows up on the 2011-05-06 patch.
2720 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2721 * xterm.h: Likewise.
2722 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2723
1384b89e
JB
27242011-06-12 Juanma Barranquero <lekktu@gmail.com>
2725
2726 * makefile.w32-in: Update dependencies.
2727 (LISP_H): Add lib/intprops.h.
2728
1100a63c
CY
27292011-06-11 Chong Yidong <cyd@stupidchicken.com>
2730
2731 * image.c (gif_load): Add animation frame delay to the metadata.
2732 (syms_of_image): Use DEFSYM. New symbol `delay'.
2733
6198ccd0
MR
27342011-06-11 Martin Rudalics <rudalics@gmx.at>
2735
2736 * window.c (delete_deletable_window): Re-add.
2737 (Fset_window_configuration): Rewrite to handle dead buffers and
2738 consequently deletable windows.
2739 (window_tree, Fwindow_tree): Remove. Supply functionality in
2740 window.el.
2741 (compare_window_configurations): Simplify code.
2742
b6e3633c
AS
27432011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2744
1ab0dee5
AS
2745 * image.c (imagemagick_load_image): Fix type mismatch.
2746 (Fimagemagick_types): Likewise.
2747
b6e3633c
AS
2748 * window.h (replace_buffer_in_windows): Declare.
2749
9397e56f
MR
27502011-06-11 Martin Rudalics <rudalics@gmx.at>
2751
2752 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2753 Qclone_number. Remove external declaration of Qdelete_window.
2754 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2755 code.
640c8776
SM
2756 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2757 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2758 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2759 buffer list implementation.
2760 (other_buffer_safely): New function.
2761 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2762 calls to replace_buffer_in_windows and
2763 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2764 if allowed.
2765 (record_buffer): Inhibit quitting and rewrite using quittable
2766 functions. Run Qbuffer_list_update_hook if allowed.
2767 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2768 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2769 Move switch-to-buffer to window.el.
9397e56f
MR
2770 (bury-buffer): Move to window.el.
2771 (Vbuffer_list_update_hook): New variable.
2772
2773 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2774 section.
2775
2776 * window.h (resize_frame_windows): Move up in code.
2777 (Fwindow_frame): Remove EXFUN.
2778 (replace_buffer_in_all_windows): Remove prototype.
2779 (replace_buffer_in_windows_safely): Add prototype.
2780
2781 * window.c: Declare Qdelete_window static again. Move down
2782 declaration of select_count.
2783 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2784 (Fother_window): Move to window.el.
2785 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2786 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2787 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2788 window.el.
2789 (replace_buffer_in_windows): Implement by calling
2790 Qreplace_buffer_in_windows.
2791 (replace_buffer_in_all_windows): Remove with some functionality
2792 moved into replace_buffer_in_windows_safely.
2793 (replace_buffer_in_windows_safely): New function.
2794 (select_window_norecord, select_frame_norecord): Move in front
2795 of run_window_configuration_change_hook. Remove now obsolete
2796 declarations.
640c8776
SM
2797 (Fset_window_buffer): Rewrite doc-string.
2798 Call Qrecord_window_buffer.
9397e56f
MR
2799 (keys_of_window): Move binding for other-window to window.el.
2800
b50691aa
CY
28012011-06-11 Chong Yidong <cyd@stupidchicken.com>
2802
2803 * dispextern.h (struct image): Replace data member, whose int_val
2804 and ptr_val fields were not used by anything, with a single
2805 lisp_val object.
2806
2807 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2808 (gif_clear_image, gif_load, imagemagick_load_image)
2809 (gs_clear_image, gs_load): Callers changed.
2810
3f754b86
PE
28112011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2812
cca69397
PE
2813 * buffer.h: Include <time.h>, for time_t.
2814 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2815
109e28d0
PE
2816 Fix minor problems found by static checking.
2817
60737f02
PE
2818 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2819
4b66faf3
PE
2820 Make identifiers static if they are not used in other modules.
2821 * data.c (Qcompiled_function, Qframe, Qvector):
2822 * image.c (QimageMagick, Qsvg):
2823 * minibuf.c (Qmetadata):
2824 * window.c (resize_window_check, resize_root_window): Now static.
2825 * window.h (resize_window_check, resize_root_window): Remove decls.
2826
109e28d0
PE
2827 * window.c (window_deletion_count, delete_deletable_window):
2828 Remove; unused.
46a4ce9e
PE
2829 (window_body_lines): Now static.
2830 (Fdelete_other_windows_internal): Mark vars as initialized.
2831 Make sure 'resize_failed' is initialized.
2832 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2833 (resize_window_apply): Remove unused local.
2834 * window.h (delete_deletable_window): Remove decl.
2835
109e28d0 2836 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2837 (imagemagick_load_image): Fix pointer signedness problem by changing
2838 last arg from unsigned char * to char *. All uses changed.
2839 Also, fix a local for similar reasons.
2840 Remove unused locals. Remove locals to avoid shadowing.
2841 (fn_rsvg_handle_free): Remove; unused.
2842 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2843 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2844
3f754b86
PE
2845 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2846
2547adb1
CY
28472011-06-10 Chong Yidong <cyd@stupidchicken.com>
2848
2849 * image.c (gif_load): Fix omitted cast error introduced by
2850 2011-06-06 change.
2851
2c8e37d4
MR
28522011-06-10 Martin Rudalics <rudalics@gmx.at>
2853
2854 * window.h (resize_proportionally, orig_total_lines)
2855 (orig_top_line): Remove from window structure.
2856 (set_window_height, set_window_width, change_window_heights)
2857 (Fdelete_window): Remove prototypes.
2858 (resize_frame_windows): Remove duplicate declaration.
2859
440a42e3
EZ
28602011-06-10 Eli Zaretskii <eliz@gnu.org>
2861
2862 * window.h (resize_frame_windows, resize_window_check)
2863 (delete_deletable_window, resize_root_window)
2864 (resize_frame_windows): Declare prototypes.
2865
2866 * window.c (resize_window_apply): Make definition be "static" to
2867 match the prototype.
2868
562dd5e9
MR
28692011-06-10 Martin Rudalics <rudalics@gmx.at>
2870
2871 * window.c: Remove declarations of Qwindow_size_fixed,
2872 window_min_size_1, window_min_size_2, window_min_size,
2873 size_window, window_fixed_size_p, enlarge_window, delete_window.
2874 Remove static from declaration of Qdelete_window, it's
2875 temporarily needed by Fbury_buffer.
2876 (replace_window): Don't assign orig_top_line and
2877 orig_total_lines.
2878 (Fdelete_window, delete_window): Remove. Window deletion is
2879 handled by window.el.
640c8776
SM
2880 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2881 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2882 (Fdelete_other_windows): Remove. Deleting other windows is
2883 handled by window.el.
2884 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2885 handled in window.el.
2886 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2887 Window minimum sizes are handled in window.el.
2888 (shrink_windows, size_window, set_window_height)
2889 (set_window_width, change_window_heights, window_height)
2890 (window_width, CURBEG, CURSIZE, enlarge_window)
2891 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2892 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2893 handled in window.el.
2894 (make_dummy_parent): Rename to make_parent_window and give it a
2895 second argument horflag.
2896 (make_window): Don't set resize_proportionally any more.
2897 (Fsplit_window): Remove. Windows are split in window.el.
2898 (save_restore_action, save_restore_orig_size)
2899 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2900 Resize mini windows in window.el.
2901 (grow_mini_window, shrink_mini_window): Implement by calling
2902 Qresize_root_window_vertically, resize_window_check and
2903 resize_window_apply.
640c8776
SM
2904 (saved_window, Fset_window_configuration, save_window_save):
2905 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2906 resize_proportionally.
2907 (window_min_height, window_min_width): Move to window.el.
2908 (keys_of_window): Move bindings for delete-other-windows,
2909 split-window, delete-window and enlarge-window to window.el.
2910
2911 * buffer.c: Temporarily extern Qdelete_window.
2912 (Fbury_buffer): Temporarily call Qdelete_window instead of
2913 Fdelete_window (Fbury_buffer will move to window.el soon).
2914
2915 * frame.c (set_menu_bar_lines_1): Remove code handling
2916 orig_top_line and orig_total_lines.
2917
2918 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2919 set_window_height but set heights directly.
2920 (change_frame_size_1): Use resize_frame_windows.
2921
2922 * xdisp.c (init_xdisp): Don't use set_window_height but set
2923 heights directly.
2924
640c8776
SM
2925 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2926 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2927 run_window_configuration_change_hook.
2928
2929 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2930 instead of change_window_heights and run
2931 run_window_configuration_change_hook.
2932
1a13852e
MR
29332011-06-09 Martin Rudalics <rudalics@gmx.at>
2934
2935 * window.c (replace_window): Rename second argument REPLACEMENT to
2936 NEW. New third argument SETFLAG. Rewrite.
2937 (delete_window, make_dummy_parent): Call replace_window with
2938 third argument 1.
2939 (window_list_1): Move down in code.
2940 (run_window_configuration_change_hook): Move set_buffer part
2941 before select_frame_norecord part in order to unwind correctly.
2942 Rename count1 to count.
2943 (recombine_windows, delete_deletable_window, resize_root_window)
2944 (Fdelete_other_windows_internal)
2945 (Frun_window_configuration_change_hook, make_parent_window)
2946 (resize_window_check, resize_window_apply, Fresize_window_apply)
2947 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2948 (Fdelete_window_internal, Fresize_mini_window_internal):
2949 New functions.
1a13852e
MR
2950 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2951
f3d1777e
MR
29522011-06-08 Martin Rudalics <rudalics@gmx.at>
2953
496e208e
MR
2954 * window.h (window): Add some new members to window structure -
2955 normal_lines, normal_cols, new_total, new_normal, clone_number,
2956 splits, nest, prev_buffers, next_buffers.
2957 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2958 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2959
f3d1777e
MR
2960 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2961 Remove.
496e208e
MR
2962 (make_dummy_parent): Set new members of windows structure.
2963 (make_window): Move down in code. Handle new members of window
2964 structure.
2965 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2966 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2967 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2968 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2969 (Fset_window_next_buffers, Fset_window_clone_number):
2970 New functions.
496e208e
MR
2971 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2972 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2973 Doc-string fixes.
2974 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2975 Argument WINDOW can be now internal window too.
2976 (Fwindow_use_time): Move up in code.
2977 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2978 Rewrite doc-string.
2979 (Fset_window_configuration, saved_window)
2980 (Fcurrent_window_configuration, save_window_save): Handle new
2981 members of window structure.
b9e809c2
MR
2982 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2983 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2984 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2985 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2986 Qget_mru_window, Qresize_root_window,
2987 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2988 Qauto_buffer_name; staticpro them.
f3d1777e 2989
abde8f8c
MR
29902011-06-07 Martin Rudalics <rudalics@gmx.at>
2991
2992 * window.c (Fwindow_total_size, Fwindow_left_column)
2993 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2994 (Fwindow_list_1): New functions.
2995 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2996 (Fwindow_width, Fscroll_left, Fscroll_right):
2997 Use window_body_cols instead of window_box_text_cols.
2998 (delete_window, Fset_window_configuration):
2999 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3000 (delete_all_subwindows): Take a window as argument and not a
3001 structure. Rewrite.
190b47e6
MR
3002 (window_loop): Remove handling of GET_LRU_WINDOW and
3003 GET_LARGEST_WINDOW.
3004 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3005
3006 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3007 window_box_text_cols. delete_all_subwindows now takes a
3008 Lisp_Object as argument.
abde8f8c 3009
640c8776
SM
3010 * indent.c (compute_motion, Fcompute_motion):
3011 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3012
fa8a67e6
MR
3013 * frame.c (delete_frame): Call delete_all_subwindows with root
3014 window as argument.
3015
a54e3482
DC
30162011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3017
3018 * fns.c (Fputhash): Document return value.
3019
60002bf5
CY
30202011-06-06 Chong Yidong <cyd@stupidchicken.com>
3021
3022 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3023
0c671da6 30242011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3025
b862a52a 3026 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3027
be44ca6c
PE
3028 Check for overflow when converting integer to cons and back.
3029 * charset.c (Fdefine_charset_internal, Fdecode_char):
3030 Use cons_to_unsigned to catch overflow.
3031 (Fencode_char): Use INTEGER_TO_CONS.
3032 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3033 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3034 * data.c (long_to_cons, cons_to_long): Remove.
3035 (cons_to_unsigned, cons_to_signed): New functions.
3036 These signal an error for invalid or out-of-range values.
3037 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3038 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3039 * font.c (Ffont_variation_glyphs):
3040 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3041 * lisp.h: Include <intprops.h>.
3042 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3043 (cons_to_signed, cons_to_unsigned): New decls.
3044 (long_to_cons, cons_to_long): Remove decls.
3045 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3046 (Fprimitive_undo): Use CONS_TO_INTEGER.
3047 * xfns.c (Fx_window_property): Likewise.
3048 * xselect.c: Include <limits.h>.
3049 (x_own_selection, selection_data_to_lisp_data):
3050 Use INTEGER_TO_CONS.
3051 (x_handle_selection_request, x_handle_selection_clear)
3052 (x_get_foreign_selection, Fx_disown_selection_internal)
3053 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3054 (lisp_data_to_selection_data): Use cons_to_unsigned.
3055 (x_fill_property_data): Use cons_to_signed.
3056 Report values out of range.
3057
d1f3d2af
PE
3058 Check for buffer and string overflow more precisely.
3059 * buffer.h (BUF_BYTES_MAX): New macro.
3060 * lisp.h (STRING_BYTES_MAX): New macro.
3061 * alloc.c (Fmake_string):
3062 * character.c (string_escape_byte8):
3063 * coding.c (coding_alloc_by_realloc):
3064 * doprnt.c (doprnt):
3065 * editfns.c (Fformat):
3066 * eval.c (verror):
3067 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3068 since they may not be the same number.
3069 * editfns.c (Finsert_char):
3070 * fileio.c (Finsert_file_contents):
3071 Likewise for BUF_BYTES_MAX.
3072
dd52fcea
PE
3073 * image.c: Use ptrdiff_t, not int, for sizes.
3074 (slurp_file): Switch from int to ptrdiff_t.
3075 All uses changed.
3076 (slurp_file): Check that file size fits in both size_t (for
3077 malloc) and ptrdiff_t (for sanity and safety).
3078
7f9bbdbb
PE
3079 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3080 if b->modtime has its maximal value.
3081
dfe18f82
PE
3082 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3083
84acfcf0
PE
3084 Don't assume time_t can fit into int.
3085 * buffer.h (struct buffer.modtime): Now time_t, not int.
3086 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3087 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3088
ccd9a01a
PE
3089 Minor fixes for signed vs unsigned integers.
3090 * character.h (MAYBE_UNIFY_CHAR):
3091 * charset.c (maybe_unify_char):
3092 * keyboard.c (read_char, reorder_modifiers):
3093 XINT -> XFASTINT, since the integer must be nonnegative.
3094 * ftfont.c (ftfont_spec_pattern):
3095 * keymap.c (access_keymap, silly_event_symbol_error):
3096 XUINT -> XFASTINT, since the integer must be nonnegative.
3097 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3098 since it makes no difference and we prefer signed.
3099 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3100 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3101 nonnegative.
3102
d6d100dd
SM
31032011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3104
3105 * window.h (Fwindow_frame): Declare.
3106
2b6148e4
PE
31072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3108
3109 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3110 (SPARE_MEMORY): Always define.
3111 (LARGE_REQUEST): Remove.
3112 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3113
f230ecc9
MR
31142011-06-06 Martin Rudalics <rudalics@gmx.at>
3115
727e958e
MR
3116 * lisp.h: Move EXFUNS for Fframe_root_window,
3117 Fframe_first_window and Fset_frame_selected_window to window.h.
3118
3119 * window.h: Move EXFUNS for Fframe_root_window,
3120 Fframe_first_window and Fset_frame_selected_window here from
3121 lisp.h.
3122
3123 * frame.c (Fwindow_frame, Fframe_first_window)
3124 (Fframe_root_window, Fframe_selected_window)
3125 (Fset_frame_selected_window): Move to window.c.
3126 (Factive_minibuffer_window): Move to minibuf.c.
3127 (Fother_visible_frames_p): New function.
3128
3129 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3130
f230ecc9
MR
3131 * window.c (decode_window, decode_any_window): Move up in code.
3132 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3133 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3134 (Fwindow_buffer): Move up and rewrite doc-string.
3135 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3136 (Fwindow_prev): New functions.
727e958e
MR
3137 (Fwindow_frame): Move here from frame.c. Accept any window as
3138 argument.
3139 (Fframe_root_window, Fframe_first_window)
3140 (Fframe_selected_window): Move here from frame.c. Accept frame
3141 or arbitrary window as argument. Update doc-strings.
3142 (Fminibuffer_window): Move up in code.
3143 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3144 (Fset_frame_selected_window): Move here from frame.c.
3145 Marginal rewrite.
727e958e
MR
3146 (Fselected_window, select_window, Fselect_window): Move up in
3147 code. Minor doc-string fixes.
f230ecc9 3148
4d09bcf6
PE
31492011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3150
3151 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3152 Do not assume that spare memory exists; that assumption is valid
3153 only if SYSTEM_MALLOC.
3154 (LARGE_REQUEST): New macro, so that the issue of large requests
3155 is separated from the issue of spare memory.
3156
810928a2
AS
31572011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3158
172418ad
AS
3159 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3160 format. (Bug#8806)
3161
43f862f7
AS
3162 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3163
810928a2
AS
3164 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3165 before statements.
3166
a059fe24
JD
31672011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3168
3169 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3170
3171 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3172
3173 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3174 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3175
989bf368
JB
31762011-06-05 Juanma Barranquero <lekktu@gmail.com>
3177
3178 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3179
4b80f674
CY
31802011-06-04 Chong Yidong <cyd@stupidchicken.com>
3181
3182 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3183 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3184 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3185 New error handlers.
4b80f674
CY
3186 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3187 Obey Vx_select_enable_clipboard_manager. Catch errors in
3188 x_clipboard_manager_save (Bug#8779).
3189 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3190 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3191
99a33b77 31922011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3193
3194 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3195
99a33b77 31962011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3197
3198 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3199 in the current matrix if keep_current_p is non-zero.
3200
8264569d
EZ
32012011-06-04 Eli Zaretskii <eliz@gnu.org>
3202
3203 * bidi.c (bidi_level_of_next_char): Fix last change.
3204
57f97249
EZ
32052011-06-03 Eli Zaretskii <eliz@gnu.org>
3206
fec2107c 3207 Support bidi reordering of text covered by display properties.
57f97249 3208
fec2107c
EZ
3209 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3210 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3211 (bidi_cache_search, bidi_cache_iterator_state)
3212 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3213 (bidi_level_of_next_char, bidi_move_to_visually_next):
3214 Support character positions inside a run of characters covered by a
fec2107c
EZ
3215 display string.
3216 (bidi_paragraph_init, bidi_resolve_explicit_1)
3217 (bidi_level_of_next_char): Call bidi_fetch_char and
3218 bidi_fetch_char_advance instead of FETCH_CHAR and
3219 FETCH_CHAR_ADVANCE.
3220 (bidi_init_it): Initialize new members.
3221 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3222 definitions.
3223 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3224 instead of using explicit *_CHAR codes.
d6d100dd
SM
3225 (bidi_resolve_explicit, bidi_resolve_weak):
3226 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3227 bidirectional text is supported only in multibyte buffers.
3228 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3229 it to initialize the frame_window_p member of struct bidi_it.
3230 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3231 (bidi_resolve_explicit, bidi_resolve_weak)
3232 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3233 bidi_it->nchars is non-positive.
3234 (bidi_level_of_next_char): Don't try to lookup the cache for the
3235 next/previous character if nothing is cached there yet, or if we
3236 were just reseat()'ed to a new position.
c40e2fb2 3237
0e14fe90
EZ
3238 * xdisp.c (set_cursor_from_row): Set start and stop points
3239 according to the row's direction when priming the loop that looks
3240 for the glyph on which to display cursor.
3241 (single_display_spec_intangible_p): Function deleted.
3242 (display_prop_intangible_p): Reimplement to call
3243 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3244 Accept 3 additional arguments needed by handle_display_spec.
3245 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3246 values: lists, `(when COND...)' forms, etc.
3247 (single_display_spec_string_p): Support property values that are
3248 lists with the argument STRING its top-level element.
3249 (display_prop_string_p): Fix the condition for processing a
3250 property that is a list to be consistent with handle_display_spec.
fec2107c 3251 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3252 last portion of handle_display_prop.
3253 (compute_display_string_pos): Accept additional argument
3254 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3255 value of a `display' property is a "replacing spec".
3256 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3257 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3258 the display property, but just return a value indicating whether
3259 the display property will replace the characters it covers.
3260 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3261 frame_window_p members of struct bidi_it.
d6d100dd
SM
3262 (compute_display_string_pos, compute_display_string_end):
3263 New functions.
fec2107c
EZ
3264 (push_it): Accept second argument POSITION, where pop_it should
3265 jump to continue iteration.
3266 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3267
fec2107c
EZ
3268 * keyboard.c (adjust_point_for_property): Adjust the call to
3269 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3270
3271 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3272 (bidi_init_it): Update prototypes.
3273 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3274 (compute_display_string_pos, compute_display_string_end):
3275 Declare prototypes.
fec2107c
EZ
3276 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3277 EMACS_INT.
fc6f18ce 3278
40087514 32792011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3280
57f53182
PE
3281 Malloc failure behavior now depends on size of allocation.
3282 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3283 * lisp.h: Change signatures accordingly.
3284 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3285 All callers changed. (Bug#8762)
3286
3287 * gnutls.c: Use Emacs's memory allocators.
3288 Without this change, the gnutls library would invoke malloc etc.
3289 directly, which causes problems on non-SYNC_INPUT hosts, and which
3290 runs afoul of improving memory_full behavior. (Bug#8761)
3291 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3292 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3293 xfree instead of the default malloc, realloc, free.
3294 (Fgnutls_boot): No need to check for memory allocation failure,
3295 since xmalloc does that for us.
3296
ac32cd99 3297 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3298 * category.c (hash_get_category_set):
3299 * ccl.c (ccl_driver):
3300 * charset.c (Fdefine_charset_internal):
3301 * charset.h (struct charset.hash_index):
3302 * composite.c (get_composition_id, gstring_lookup_cache)
3303 (composition_gstring_put_cache):
3304 * composite.h (struct composition.hash_index):
3305 * dispextern.h (struct image.hash):
3306 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3307 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3308 (hashfn_equal, hashfn_user_defined, make_hash_table)
3309 (maybe_resize_hash_table, hash_lookup, hash_put)
3310 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3311 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3312 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3313 * image.c (make_image, search_image_cache, lookup_image)
3314 (xpm_put_color_table_h):
3315 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3316 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3317 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3318 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3319 * alloc.c (allocate_vectorlike):
3320 Check for overflow in vector size calculations.
3321 * ccl.c (ccl_driver):
3322 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3323 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3324 need to be updated by these changes.
40087514
PE
3325 * fns.c (make_hash_table, maybe_resize_hash_table):
3326 Check for integer overflow with large hash tables.
0de4bb68
PE
3327 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3328 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3329 (SXHASH_REDUCE): New macro.
3330 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3331 Use it instead of discarding useful hash info with large hash values.
3332 (sxhash_float): New function.
3333 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3334 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3335 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3336 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3337 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3338 Adjust signatures to match updated version of code.
3339 (consing_since_gc): Now EMACS_INT, since a single hash table can
3340 use more than INT_MAX bytes.
3341
698d32e2
DN
33422011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3343
3344 Make it possible to build with GCC-4.6+ -O2 -flto.
3345
3346 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3347
fd6fa53f
SM
33482011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3349
3350 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3351 Call minibuffer-inactive-mode.
3352
864db017
JB
33532011-05-31 Juanma Barranquero <lekktu@gmail.com>
3354
3355 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3356 Update dependencies.
3357
2ad0baf4
DN
33582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3359
3360 * data.c (init_data): Remove code for UTS, this system is not
3361 supported anymore.
3362
4fcc2638
DN
33632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3364
3365 Don't force ./temacs to start in terminal mode.
3366
3367 * frame.c (make_initial_frame): Initialize faces in all cases, not
3368 only when CANNOT_DUMP is defined.
3369 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3370
c56e0fd5
DN
33712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3372
3373 * dispnew.c (add_window_display_history): Use const for the string
3374 pointer. Remove declaration, not needed.
3375
333d54da 33762011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3377
55d4c1b2 3378 Use 'inline', not 'INLINE'.
333d54da 3379 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3380 * alloc.c, fontset.c (INLINE): Remove.
3381 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3382 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3383 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3384 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3385 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3386
738db178
DN
33872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3388
3389 Make it possible to run ./temacs.
3390
3391 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3392 syms_of_callproc does the same thing. Remove test for
3393 "initialized", do it in the caller.
3394 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3395
620c53a6
SM
33962011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3397
3398 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3399 (read_minibuf): Use get_minibuffer.
3400 (syms_of_minibuf): Use DEFSYM.
3401 (Qmetadata): New var.
3402 * data.c (Qbuffer): Don't make it static.
3403 (syms_of_data): Use DEFSYM.
3404
e003a292
PE
34052011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3406
3407 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3408 (CCL_CODE_MIN): New macro.
3409
ed008a6d
PE
34102011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3411
3687c2ef
PE
3412 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3413
ed008a6d
PE
3414 * eval.c (Qdebug): Now static.
3415 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3416 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3417 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3418
d66c4c7c
CY
34192011-05-29 Chong Yidong <cyd@stupidchicken.com>
3420
3421 * image.c: Various fixes to ImageMagick code comments.
3422 (Fimagemagick_types): Doc fix.
3423
5fbc2025
PE
34242011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3425
0196f88a
PE
3426 Minor fixes prompted by GCC 4.6.0 warnings.
3427
3428 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3429
5fbc2025
PE
3430 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3431 (x_clipboard_manager_save_all): Move extern decl to ...
3432 * xterm.h: ... here, so that it can be checked for consistency.
3433
1dd3c2d9
CY
34342011-05-29 Chong Yidong <cyd@stupidchicken.com>
3435
3436 * xselect.c (x_clipboard_manager_save_frame)
3437 (x_clipboard_manager_save_all): New functions.
3438 (Fx_clipboard_manager_save): Lisp function deleted.
3439
3440 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3441 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3442
3443 * xterm.h: Update prototype.
3444
5ba6571d
WX
34452011-05-28 William Xu <william.xwl@gmail.com>
3446
3447 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3448 exiting (Bug#8239).
3449
3eaff834
JM
34502011-05-28 Jim Meyering <meyering@redhat.com>
3451
e1900994 3452 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3453 * fns.c (to_uchar): Define.
3454 (crypto_hash_function): Use it to convert some newly-signed
3455 variables to unsigned, to avoid sign-extension bugs. For example,
3456 without this change, (md5 "truc") would evaluate to
3457 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3458 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3459 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3460
0f6990a7
PE
34612011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3462
3463 Integer overflow fixes.
c8a9ca5a 3464
08686060
PE
3465 * dbusbind.c: Serial number integer overflow fixes.
3466 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3467 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3468 to hold a serial number that is too large for a fixnum.
3469 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3470 Check for serial numbers out of range. Decode any serial number
59568bf0 3471 that was so large that it became a float. (Bug#8722)
08686060 3472
2d1fc3c7
PE
3473 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3474 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3475 Use XFASTINT rather than XUINT when numbers are nonnegative.
3476 (xd_append_arg, Fdbus_method_return_internal):
3477 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3478 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3479 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3480 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3481 (Bug#8722)
2d1fc3c7 3482
c8a9ca5a
PE
3483 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3484
519e1d69
PE
3485 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3486
30569699
PE
3487 ccl: add integer overflow checks
3488 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3489 (IN_INT_RANGE): New macros.
3490 (ccl_driver): Use them to check for integer overflow when
3491 decoding a CCL program. Many of the new checks are whether XINT (x)
3492 fits in int; it doesn't always, on 64-bit hosts. The new version
3493 doesn't catch all possible integer overflows, but it's an
847044ea 3494 improvement. (Bug#8719)
30569699 3495
c11285dc
PE
3496 * alloc.c (make_event_array): Use XINT, not XUINT.
3497 There's no need for unsigned here.
3498
fdccd48e
PE
3499 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3500 This follows up to the 2011-05-06 change that substituted uintptr_t
3501 for EMACS_INT. This case wasn't caught back then.
3502
37910ab2
PE
3503 Rework Fformat to avoid integer overflow issues.
3504 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3505 now (part of C89). Include <verify.h>.
3506 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3507 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3508 (Fformat): Avoid the prepass trying to compute sizes; it was only
3509 approximate and thus did not catch overflow reliably. Instead, walk
3510 through the format just once, formatting and computing sizes as we go,
3511 checking for integer overflow at every step, and allocating a larger
3512 buffer as needed. Keep track separately whether the format is
3513 multibyte. Keep only the most-recently calculated precision, rather
3514 than them all. Record whether each argument has been converted to
3515 string. Use EMACS_INT, not int, for byte and char and arg counts.
3516 Support field widths and precisions larger than INT_MAX. Avoid
3517 sprintf's undefined behavior with conversion specifications such as %#d
3518 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3519 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3520 formatting out-of-range floating point numbers with int
9173deec 3521 formats. (Bug#8668)
37910ab2 3522
2e6578fb
PE
3523 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3524
0ae6bdee
PE
3525 * data.c: Avoid integer truncation in expressions involving floats.
3526 * data.c: Include <intprops.h>.
3527 (arith_driver): When there's an integer overflow in an expression
3528 involving floating point, convert the integers to floating point
3529 so that the resulting value does not suffer from catastrophic
3530 integer truncation. For example, on a 64-bit host (* 4
3531 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3532 Do not rely on undefined behavior after integer overflow.
3533
de883a70
PE
3534 merge count_size_as_multibyte, parse_str_to_multibyte
3535 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3536 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3537 Check for integer overflow.
3538 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3539 since it's now a duplicate of the other. This is more of
3540 a character than a buffer op, so better that it's in character.c.
3541 * fns.c, print.c: Adjust to above changes.
3542
2ff916cb
PE
35432011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3544
3545 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3546
f1b54466
PE
35472011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3548
fb1ac845
PE
3549 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3550 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3551 (x_clipboard_manager_save): Now static.
3552 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3553
f1b54466
PE
3554 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3555 (crypto_hash_function): Now static.
3556 Fix pointer signedness problems. Avoid unnecessary initializations.
3557
a9f737ee
CY
35582011-05-27 Chong Yidong <cyd@stupidchicken.com>
3559
3560 * termhooks.h (Vselection_alist): Make it terminal-local.
3561
3562 * terminal.c (create_terminal): Initialize it.
3563
3564 * xselect.c: Support for clipboard managers.
3565 (Vselection_alist): Move to termhooks.h as terminal-local var.
3566 (LOCAL_SELECTION): New macro.
3567 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3568 (symbol_to_x_atom): Remove gratuitous arg.
3569 (x_handle_selection_request, lisp_data_to_selection_data)
3570 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3571 (x_own_selection, x_get_local_selection, x_convert_selection):
3572 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3573 (some_frame_on_display): Delete unused function.
3574 (Fx_own_selection_internal, Fx_get_selection_internal)
3575 (Fx_disown_selection_internal, Fx_selection_owner_p)
3576 (Fx_selection_exists_p): New optional frame arg.
3577 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3578 (x_handle_selection_clear): Don't treat other terminals with the
3579 same keyboard specially. Use the terminal-local Vselection_alist.
3580 (x_clear_frame_selections): Use Frun_hook_with_args.
3581
3582 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3583
3584 * xterm.h: Add support for those atoms.
3585
e067f0c1
CY
35862011-05-26 Chong Yidong <cyd@stupidchicken.com>
3587
3588 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3589 (converted_selections, conversion_fail_tag): New global variables.
3590 (x_selection_request_lisp_error): Free the above.
3591 (x_get_local_selection): Remove unnecessary code.
3592 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3593 of converted selections stored in converted_selections.
3594 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3595 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3596 (x_convert_selection): New function.
3597 (x_handle_selection_event): Simplify.
3598 (x_get_foreign_selection): Don't ignore incoming requests while
3599 waiting for an answer; this will fail when we implement
3600 SAVE_TARGETS, and seems unnecessary anyway.
3601 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3602 (Vx_sent_selection_functions): Doc fix.
3603
0f4aebc0
LL
36042011-05-26 Leo Liu <sdl.web@gmail.com>
3605
3606 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3607
e61124cd
YM
36082011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3609
3610 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3611
3612 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3613 for fringe update if it has periodic bitmap.
ac389d0c 3614 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3615 and fringe_bitmap_periodic_p.
3616
3617 * fringe.c (get_fringe_bitmap_data): New function.
3618 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3619 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3620 row. Mark glyph row for fringe update if periodicity changed.
3621
3622 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3623 for fringe update unless it has periodic bitmap.
3624
f16d9837
KH
36252011-05-25 Kenichi Handa <handa@m17n.org>
3626
3627 * xdisp.c (get_next_display_element): Set correct it->face_id for
3628 a static composition.
3629
e1b90ef6
LL
36302011-05-24 Leo Liu <sdl.web@gmail.com>
3631
3632 * deps.mk (fns.o):
3633 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3634
3635 * fns.c (crypto_hash_function, Fsha1): New function.
3636 (Fmd5): Use crypto_hash_function.
3637 (syms_of_fns): Add Ssha1.
3638
7400048f
PE
36392011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3640
3641 * gnutls.c: Remove unused macros.
3642 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3643 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3644 Remove macros that are defined and never used.
3645 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3646
abb71cf4
CY
36472011-05-22 Chong Yidong <cyd@stupidchicken.com>
3648
3649 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3650 (Fx_get_selection_internal): Minor cleanup.
3651 (Fx_own_selection_internal): Rename arguments for consistency with
3652 select.el.
3653
6307db39
PE
36542011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3655
3656 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3657
f3d4e0a4
CY
36582011-05-22 Chong Yidong <cyd@stupidchicken.com>
3659
3660 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3661
4d8ade89
YM
36622011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3663
3664 * dispnew.c (scrolling_window): Don't exclude the case that the
3665 last enabled row in the desired matrix touches the bottom boundary.
3666
32078c8d
GM
36672011-05-21 Glenn Morris <rgm@gnu.org>
3668
3669 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3670 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3671 and add some more files.
32078c8d 3672
7285dc67
EZ
36732011-05-20 Eli Zaretskii <eliz@gnu.org>
3674
3675 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3676 report_file_error introduced by the change from 2011-05-07.
3677
89d1bd22
PE
36782011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3679
3680 * systime.h (Time): Define only if emacs is defined.
3681 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3682 where the include path doesn't have X11/X.h by default. See
3683 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3684
e23640bb 36852011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3686
3687 * composite.c (find_automatic_composition): Fix previous change.
3688
b9704ad9
GM
36892011-05-20 Glenn Morris <rgm@gnu.org>
3690
3691 * lisp.mk: New file, split from Makefile.in.
3692 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3693 (shortlisp): Remove.
3694 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3695
4a720484
GM
36962011-05-19 Glenn Morris <rgm@gnu.org>
3697
3698 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3699 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3700 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3701 (lisp): Set the order to that of loadup.el.
3702 (shortlisp): Make it a copy of $lisp.
3703 (SOME_MACHINE_LISP): Remove.
3704 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3705 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3706
a28d4396
KH
37072011-05-18 Kenichi Handa <handa@m17n.org>
3708
3709 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3710 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3711 (find_automatic_composition): Mostly rewrite for efficiency.
3712
a2b1fa8e
JB
37132011-05-18 Juanma Barranquero <lekktu@gmail.com>
3714
3715 * makefile.w32-in: Update dependencies.
3716
8e1f5610
CS
37172011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3718
3719 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3720 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3721
7025ee00 37222011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3723
cdfa6eab
PE
3724 Fix some integer overflow issues, such as string length overflow.
3725
06d6db33
PE
3726 * insdel.c (count_size_as_multibyte): Check for string overflow.
3727
2b4560a8
PE
3728 * character.c (lisp_string_width): Check for string overflow.
3729 Use EMACS_INT, not int, for string indexes and lengths; in
3730 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3731 the resulting string length overflows an EMACS_INT; instead,
3732 report a string overflow if no precision given. When checking for
3733 precision exhaustion, use a check that cannot possibly have
3734 integer overflow. (Bug#8675)
3735 * character.h (lisp_string_width): Adjust to new signature.
3736
cb93f9be
PE
3737 * alloc.c (string_overflow): New function.
3738 (Fmake_string): Use it. This doesn't change behavior, but saves
3739 a few bytes and will simplify future changes.
3740 * character.c (string_escape_byte8): Likewise.
3741 * lisp.h (string_overflow): New decl.
3742
1a1f3366
PE
3743 Fixups, following up to the user-interface timestamp change.
3744 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3745 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3746 * msdos.c (mouse_get_pos): Likewise.
3747 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3748 * w32gui.h (Time): Define by including "systime.h" rather than by
3749 declaring it ourselves. (Bug#8664)
3750
d4e3e4d3
PE
3751 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3752 * image.c (clear_image_cache): Likewise.
3753
f6a24d19
PE
3754 * term.c (term_mouse_position): Don't assume time_t wraparound.
3755
08dc5ae6
PE
3756 Be more systematic about user-interface timestamps.
3757 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3758 and sometimes 'EMACS_UINT', to represent these timestamps.
3759 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3760 This makes the code easier to follow, and makes it easier to catch
3761 integer overflow bugs such as Bug#8664.
3762 * frame.c (Fmouse_position, Fmouse_pixel_position):
3763 Use Time, not unsigned long, for user-interface timestamps.
3764 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3765 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3766 * keyboard.h (last_event_timestamp): Likewise.
3767 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3768 * menu.h (xmenu_show): Likewise.
3769 * term.c (term_mouse_position): Likewise.
3770 * termhooks.h (struct input_event.timestamp): Likewise.
3771 (struct terminal.mouse_position_hook): Likewise.
3772 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3773 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3774 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3775 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3776 what it was before.
3777 * menu.h, termhooks.h: Include "systime.h", for Time.
3778
8e55734a
PE
3779 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3780 Don't assume that the difference between two unsigned long values
3781 can fit into an integer. At this point, we know button_down_time
3782 <= event->timestamp, so the difference must be nonnegative, so
3783 there's no need to cast the result if double-click-time is
3784 nonnegative, as it should be; check that it's nonnegative, just in
3785 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3786 apart (about 25 days). (Bug#8664)
8e55734a 3787
841f1b75 3788 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3789 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3790
3e26f69c
PE
3791 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3792 that always fit in int. Use a sentinel instead of a counter, to
3793 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3794 * frame.h (struct frame): Use int for menu_bar_items_used
3795 instead of EMACS_INT, since it always fits in int.
3e26f69c 3796
5cc152c0
PE
3797 * menu.c (grow_menu_items): Check for int overflow.
3798
d89eb65e
PE
3799 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3800
5235bd3e
PE
3801 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3802 Before, the code was not consistent. These values cannot exceed
3803 2**31 - 1 so there's no need to make them unsigned.
3804 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3805 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3806 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3807 as modifiers.
3808 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3809
bc827e23
PE
3810 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3811 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3812 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3813 presumably because the widths might not match.
3814
78eb494e
PE
3815 * window.c (size_window): Avoid needless test at loop start.
3816
04f2d78b
CB
38172011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3818
3819 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3820
d2fc7e3d 38212011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3822
3823 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3824
d2fc7e3d 38252011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3826
3827 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3828 `width' to `bar_area_x' and `bar_area_width', respectively.
3829 (x_scroll_run): Take account of fringe background extension.
3830
04f2d78b
CB
3831 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3832 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3833 `bar_area_width', respectively.
3834 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3835 background extension.
3836
79b70037
GM
38372011-05-10 Jim Meyering <meyering@redhat.com>
3838
3839 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3840
2f142cc5
JB
38412011-05-10 Juanma Barranquero <lekktu@gmail.com>
3842
3843 * image.c (Finit_image_library): Return t for built-in image types,
3844 like pbm and xbm. (Bug#8640)
3845
57679c86
AS
38462011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3847
3848 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3849
888c9e86
EZ
38502011-05-07 Eli Zaretskii <eliz@gnu.org>
3851
b0512a1d
EZ
3852 * w32console.c (Fset_screen_color): Doc fix.
3853 (Fget_screen_color): New function.
3854 (syms_of_ntterm): Defsubr it.
3855
7285dc67
EZ
3856 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3857 unlink the temporary file if Fcall_process didn't create it in the
3858 first place.
3859 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3860 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3861 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3862 cue to call_process_cleanup not to close that handle.
3863
4d3fcc8e
BK
38642011-05-07 Ben Key <bkey76@gmail.com>
3865
3866 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3867 one of two shell specific rules, either bootstrap-temacs-CMD or
3868 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3869 to the previous implementation of the bootstrap-temacs rule.
3870 The bootstrap-temacs-CMD rule is similar to the previous
3871 implementation of the bootstrap-temacs rule except that it
3872 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3873 variable.
3874
3875 These changes, along with some changes to nt/configure.bat,
3876 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3877 earlier fix to add support for --cflags and --ldflags options
3878 that include quotes so that it works whether make uses cmd or
3879 sh as the shell.
3880
b4289b64
MA
38812011-05-06 Michael Albinus <michael.albinus@gmx.de>
3882
3883 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3884 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3885 is a constant.
3886 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3887 a string. Handle both cases.
3888 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3889 (Fdbus_register_method): Use Qinvalid_function.
3890
af4c0e28
JB
38912011-05-06 Juanma Barranquero <lekktu@gmail.com>
3892
3893 * makefile.w32-in: Update dependencies.
3894 (LISP_H): Add inttypes.h and stdin.h.
3895 (PROCESS_H): Add unistd.h.
3896
c51453d9
EZ
38972011-05-06 Eli Zaretskii <eliz@gnu.org>
3898
3899 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3900 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3901
8ff0ac3c 39022011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3903
4c4b566b
PE
3904 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3905
aab2b9b5
PE
3906 * term.c (vfatal): Remove stray call to va_end.
3907 It's not needed and the C Standard doesn't allow it here anyway.
3908
c378da0b
PE
3909 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3910 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3911
288b08c7
PE
3912 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3913 bytes.
3914
e3601888
PE
3915 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3916
db6c0e74
PE
3917 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3918
dd5963ea
PE
3919 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3920
88c9450f
PE
3921 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3922
2f9442b8
PE
3923 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3924
c032b5f8
PE
3925 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3926 * charset.c (Fdefine_charset_internal): Don't initialize
3927 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3928 32-bit int (Bug#8600).
a108c10b
PE
3929
3930 * lread.c (read_integer): Be more consistent with string-to-number.
3931 Use string_to_number to do the actual conversion; this avoids
3932 rounding errors and fixes some other screwups. Without this fix,
3933 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3934 (digit_to_number): Move earlier, for benefit of read_integer.
3935 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3936 not a digit in any supported base. (Bug#8602)
a108c10b 3937
ad5f9eea
PE
3938 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3939
aec1708a
PE
3940 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3941 to match comment at start of function. This also removes a
3942 GCC warning about overflow in a 32+64-bit port.
3943
47be4ab5
PE
3944 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3945
371cac43
PE
3946 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3947 Reported by Stefan Monnier in
3948 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3949 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3950 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3951
d01a7826
PE
3952 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3953 (EMACS_UINTPTR): Likewise, with uintptr_t.
3954
7fd47d5c
PE
3955 * lisp.h: Prefer 64-bit EMACS_INT if available.
3956 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3957 on 32-bit hosts that have 64-bit int, so that they can access
3958 large files.
122b0c86
PE
3959 However, temporarily disable this change unless the temporary
3960 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3961
8727937b
PE
3962 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3963
8ac068ac
PE
3964 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3965 This removes an assumption that EMACS_INT and long are the same
3966 width as pointers. The assumption is true for Emacs porting targets
3967 now, but we want to make other targets possible.
3968 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3969 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3970 In the rest of the code, change types of integers that hold casted
3971 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3972 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3973 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3974 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3975 No need to cast type when ORing.
3976 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3977 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3978 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3979 assume EMACS_INT is the same width as char *.
3980 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3981 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3982 Remove no-longer-needed casts.
3983 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3984 (xg_tool_bar_help_callback, xg_make_tool_item):
3985 Use EMACS_INTPTR to hold an integer
3986 that will be cast to void *; this can avoid a GCC warning
3987 if EMACS_INT is not the same width as void *.
3988 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3989 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3990 (current_message_1, set_message_1):
3991 Use a local to convert to proper width without a cast.
3992 * xmenu.c (dialog_selection_callback): Likewise.
3993
ede49d71
PE
3994 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3995 Also, don't assume VALBITS / RAND_BITS is less than 5,
3996 and don't rely on undefined behavior when shifting a 1 left into
3997 the sign bit.
3998 * lisp.h (get_random): Change signature to match.
3999
2f30ecd0
PE
4000 * lread.c (hash_string): Use size_t, not int, for hash computation.
4001 Normally we prefer signed values; but hashing is special, because
4002 it's better to use unsigned division on hash table sizes so that
4003 the remainder is nonnegative. Also, size_t is the natural width
4004 for hashing into memory. The previous code used 'int', which doesn't
4005 retain enough info to hash well into very large tables.
4006 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4007
2a866e7b
PE
4008 * dbusbind.c: Don't possibly lose pointer info when converting.
4009 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4010 Use XPNTR rather than XHASH, so that the high-order bits of
4011 the pointer aren't lost when converting through void *.
4012
51639eac
PE
4013 * eval.c (Fautoload): Don't double-shift a pointer.
4014
92394119
PE
4015 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4016
dbdb9a7c
JB
40172011-05-06 Juanma Barranquero <lekktu@gmail.com>
4018
4019 * gnutls.c (DEF_GNUTLS_FN):
4020 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4021
db7a0b4f
AS
40222011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4023
4024 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4025 marker. (Bug#8610)
4026
f7ff1b0f 40272011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4028
4029 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4030 New version that can reserve upto 2GB of heap space.
4031
f7ff1b0f 40322011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4033
4034 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4035
639c109b
TZ
40362011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4037
4038 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4039 `gnutls_certificate_set_x509_key_file'.
4040
d2127135
JB
40412011-05-05 Juanma Barranquero <lekktu@gmail.com>
4042
4043 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4044 Update dependencies.
4045
e968f4f3
JB
40462011-05-04 Juanma Barranquero <lekktu@gmail.com>
4047
4048 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4049 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4050 Remove unused parameter `fildes'.
4051 * process.c (read_process_output, send_process): Don't pass it.
4052
84d358f0
JB
40532011-05-04 Juanma Barranquero <lekktu@gmail.com>
4054
4055 Fix previous change: the library cache is defined in w32.c.
4056 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4057 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4058
0898ca10
JB
40592011-05-04 Juanma Barranquero <lekktu@gmail.com>
4060
4061 Implement dynamic loading of GnuTLS on Windows.
4062
4063 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4064 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4065 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4066 Declare.
4067
4068 * gnutls.c (Qgnutls_dll): Define.
4069 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4070 (gnutls_*): Declare function pointers.
4071 (init_gnutls_functions): New function to initialize function pointers.
4072 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4073 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4074 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4075 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4076 (emacs_gnutls_write, emacs_gnutls_read)
4077 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4078 (Fgnutls_available_p): New function.
4079 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4080 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4081 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4082
4083 * image.c: Include w32.h.
4084 (Vimage_type_cache): Delete.
4085 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4086 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4087 (w32_delayed_load): Move to w32.c.
4088
4089 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4090
4091 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4092 (w32_delayed_load): Move from image.c. When loading a library, record
4093 its filename in the :loaded-from property of the library id.
4094 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4095 Initialize and staticpro them.
4096 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4097
4098 * process.c: Include lisp.h before w32.h, not after.
4099 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4100 instead of gnutls_record_check_pending.
4101
4102 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4103
ff4de4aa
TZ
41042011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4105
4106 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4107 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4108 as passed in.
4109
abe95abb
JD
41102011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4111
4112 * xterm.c (x_set_frame_alpha): Do not set property on anything
4113 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4114
e16e55d4
JB
41152011-05-02 Juanma Barranquero <lekktu@gmail.com>
4116
4117 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4118
bafcf6a5
JB
41192011-05-02 Juanma Barranquero <lekktu@gmail.com>
4120
4121 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4122 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4123 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4124 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4125 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4126 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4127 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4128 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4129 (Qgnutls_bootprop_callbacks_verify): Make static.
4130
e7a6747f
AS
41312011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4132
19ed11ba
AS
4133 * callproc.c: Indentation fixup.
4134
e7a6747f 4135 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4136 (wait_for_termination, interruptible_wait_for_termination):
4137 Move after wait_for_termination_1.
e7a6747f 4138
1ef14cb4
LMI
41392011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4140
4141 * sysdep.c (interruptible_wait_for_termination): New function
4142 which is like wait_for_termination, but allows keyboard
4143 interruptions.
4144
4145 * callproc.c (Fcall_process): Add (:file "file") as an option for
4146 the STDOUT buffer.
4147 (Fcall_process_region): Ditto.
4148
330d880c
EZ
41492011-04-30 Eli Zaretskii <eliz@gnu.org>
4150
8db90b73
EZ
4151 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4152 rather than `XVECTOR (FOO)->size'.
4153
330d880c
EZ
4154 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4155 inttypes.h, as a gnulib replacement is used if it not available in
4156 system headers.
4157
15cbd324
EZ
41582011-04-21 Eli Zaretskii <eliz@gnu.org>
4159
4160 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4161 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4162 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4163
4164 * coding.c (coding_alloc_by_realloc): Error out if destination
4165 will grow beyond MOST_POSITIVE_FIXNUM.
4166 (decode_coding_emacs_mule): Abort if there isn't enough place in
4167 charbuf for the composition carryover bytes. Reserve an extra
4168 space for up to 2 characters produced in a loop.
4169 (decode_coding_iso_2022): Abort if there isn't enough place in
4170 charbuf for the composition carryover bytes.
4171
41722011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4173
ae940cca
EZ
4174 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4175 aborting when %lld or %lll format is passed.
4176 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4177 %llo or %llx format is passed. (Bug#8545)
4178
03ab8921
EZ
4179 * window.c (window_scroll_line_based): Use a marker instead of
4180 simple variables to record original value of point. (Bug#7952)
4181
afda1437
EZ
4182 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4183 produced by %s or %c overflows available buffer space. (Bug#8545)
4184
f76dee0c
PE
41852011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4186
4187 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4188 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4189
fdc5744d
JB
41902011-04-28 Juanma Barranquero <lekktu@gmail.com>
4191
4192 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4193
638f053a
JB
41942011-04-28 Juanma Barranquero <lekktu@gmail.com>
4195
4196 * keyboard.c (Qdelayed_warnings_hook): Define.
4197 (command_loop_1): Run `delayed-warnings-hook'
4198 if Vdelayed_warnings_list is non-nil.
4199 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4200 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4201
d178f871
EZ
42022011-04-28 Eli Zaretskii <eliz@gnu.org>
4203
4204 * doprnt.c (doprnt): Don't return value smaller than the buffer
4205 size if the message was truncated. (Bug#8545).
4206
b124fd93
JB
42072011-04-28 Juanma Barranquero <lekktu@gmail.com>
4208
4209 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4210 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4211
e810457d
PE
42122011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4213
4214 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4215
ea51cceb
JB
42162011-04-27 Juanma Barranquero <lekktu@gmail.com>
4217
4218 * makefile.w32-in: Update dependencies.
4219
94dcfacf
EZ
42202011-04-27 Eli Zaretskii <eliz@gnu.org>
4221
4222 Improve `doprnt' and its usage. (Bug#8545)
4223 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4224 `format_end'. Remove support for %l as a conversion specifier.
4225 Don't use xrealloc. Improve diagnostics when the %l size modifier
4226 is used. Update the commentary.
4227
4228 * eval.c (verror): Simplify calculation of size_t.
4229
4230 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4231 messages.
4232
f61f41d7
PE
42332011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4234
4235 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4236 change.
4237
96fb4434
PE
42382011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4239
4240 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4241 This makes this file independent of the recent pseudovector change.
4242
671875da 42432011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4244
69e9b5a3
PE
4245 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4246
b5f869a7 4247 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4248 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4249 Remove unused local.
c8926152 4250 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4251
841a1577 4252 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4253 GCC 4.6.0 optimizes based on type-based alias analysis.
4254 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4255 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4256 != &v->size, and therefore "v->size = 1; b->size = 2; return
4257 v->size;" must therefore return 1. This assumption is incorrect
4258 for Emacs, since it type-puns struct Lisp_Vector * with many other
4259 types. To fix this problem, this patch adds a new type struct
f904488f 4260 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4261 and pseudovectors, and helps optimizing compilers not get fooled
4262 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4263 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4264 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4265 the size member.
eab3844f
PE
4266 (XSETPVECTYPE): Rewrite in terms of new macro.
4267 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4268 This is a bit clearer, and further avoids the possibility of
4269 undesirable aliasing.
4270 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4271 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4272 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4273 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4274 (ASIZE): Now uses header.size rather than size.
4275 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4276 to avoid the hassle of writing XVECTOR (foo)->header.size.
4277 (struct vectorlike_header): New type.
eab3844f
PE
4278 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4279 object, to help avoid aliasing.
4280 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4281 (SUBRP): Likewise, since Lisp_Subr is a special case.
4282 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4283 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4284 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4285 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4286 changed to be "header.size" and "header.next".
4287 * buffer.h (struct buffer): Likewise.
4288 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4289 * frame.h (struct frame): Likewise.
4290 * process.h (struct Lisp_Process): Likewise.
4291 * termhooks.h (struct terminal): Likewise.
4292 * window.c (struct save_window_data, struct saved_window): Likewise.
4293 * window.h (struct window): Likewise.
4294 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4295 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4296 * buffer.c (init_buffer_once): Likewise.
4297 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4298 special case.
4299 * process.c (Fformat_network_address): Use local var for size,
4300 for brevity.
4301
0df1eac5
PE
4302 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4303
847ab9d1 4304 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4305 * data.c (atof): Remove decl; no longer used or needed.
4306 (digit_to_number): Move to lread.c.
4307 (Fstring_to_number): Use new string_to_number function, to be
4308 consistent with how the Lisp reader treats infinities and NaNs.
4309 Do not assume that floating-point numbers represent EMACS_INT
4310 without losing information; this is not true on most 64-bit hosts.
4311 Avoid double-rounding errors, by insisting on integers when
4312 parsing non-base-10 numbers, as the documentation specifies.
4313 * lisp.h (string_to_number): New decl, replacing ...
4314 (isfloat_string): Remove.
bc0a5c13 4315 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4316 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4317 appears to have been a coding error. Similarly, do not accept
4318 strings like +-1e0 as floating point numbers. Do not report
4319 overflow for integer overflows unless the base is not 10 which
4320 means we have no simple and reliable way to continue.
4321 Break out the floating-point parsing into a new
4322 function string_to_number, so that Fstring_to_number parses
4323 floating point numbers consistently with the Lisp reader.
04f2d78b 4324 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4325 (E_CHAR, EXP_INT): Remove, replacing with ...
4326 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4327 (string_to_number): New function, replacing isfloat_string.
4328 This function checks for valid syntax and produces the resulting
4329 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4330 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4331 so that overflow for non-base-10 numbers is reported only when
4332 there's no portable and simple way to convert to floating point.
452f4150 4333
67769ffc
PE
4334 * textprop.c (set_text_properties_1): Rewrite for clarity,
4335 and to avoid GCC warning about integer overflow.
4336
c20db43f
PE
4337 * intervals.h (struct interval): Use EMACS_INT for members
4338 where EMACS_UINT might cause problems. See
4339 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4340 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4341 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4342 All uses changed.
37aa2f85
PE
4343 (offset_intervals): Tell GCC not to worry about length overflow
4344 when negating a negative length.
c20db43f 4345
2538aa2f
PE
4346 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4347 (overrun_check_free): Likewise.
4348
f2d3008d
PE
4349 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4350 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4351 word size.
4352
ec8df744
PE
4353 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4354 (gnutls_make_error): Rename local to avoid shadowing.
4355 (gnutls_emacs_global_deinit): ifdef out; not used.
4356 (Fgnutls_boot): Use const for pointer to readonly storage.
4357 Comment out unused local. Fix pointer signedness problems.
4358
640ee02d
PE
4359 * lread.c (openp): Don't stuff size_t into an 'int'.
4360 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4361 about possible signed overflow.
4362
6048fb2a
PE
4363 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4364 (GDK_KEY_g): Don't define if already defined.
4365 (xg_prepare_tooltip): Avoid pointer signedness problem.
4366 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4367
fa3c87e1
PE
4368 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4369 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4370
2172544b
PE
4371 * xfns.c (Fx_window_property): Simplify a bit,
4372 to make a bit faster and to avoid GCC 4.6.0 warning.
4373 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4374
9b821a21
PE
4375 * fns.c (internal_equal): Don't assume size_t fits in int.
4376
3c616cfa
PE
4377 * alloc.c (compact_small_strings): Tighten assertion a little.
4378
c2982e87
PE
4379 Replace pEd with more-general pI, and fix some printf arg casts.
4380 * lisp.h (pI): New macro, generalizing old pEd macro to other
4381 conversion specifiers. For example, use "...%"pI"d..." rather
4382 than "...%"pEd"...".
4383 (pEd): Remove. All uses replaced with similar uses of pI.
4384 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4385 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4386 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4387 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4388 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4389 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4390 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4391 64-bit hosts.
4392 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4393 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4394 * print.c (safe_debug_print, print_object): Likewise.
4395 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4396 to int.
6f04d126
PE
4397 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4398 avoiding the 0 flag, which is not portable.
c2982e87
PE
4399 * process.c (Fmake_network_process): Use pI to avoid cast.
4400 * region-cache.c (pp_cache): Likewise.
4401 * xdisp.c (decode_mode_spec): Likewise.
4402 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4403 behavior on 64-bit hosts with printf arg.
6f04d126 4404 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4405 (x_stop_queuing_selection_requests): Likewise.
4406 (x_get_window_property): Don't truncate byte count to an 'int'
4407 when tracing.
0b432f21 4408
5e073ec7
PE
4409 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4410 here, since it parses constructs like leading '-' and spaces,
4411 which are not wanted; and it overflows with large numbers.
4412 Instead, simply match F[0-9]+, which is what is wanted anyway.
4413
36372bf9
PE
4414 * alloc.c: Remove unportable assumptions about struct layout.
4415 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4416 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4417 (allocate_vectorlike, make_pure_vector): Use the new macros,
4418 plus offsetof, to remove unportable assumptions about struct layout.
4419 These assumptions hold on all porting targets that I know of, but
4420 they are not guaranteed, they're easy to remove, and removing them
4421 makes further changes easier.
4422
0b432f21
PE
4423 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4424 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4425 (string_overrun_cookie): Now const. Use initializers that
4426 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4427 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4428 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4429 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4430 multiple of sizeof (EMACS_INT); it need not be, if
4431 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4432 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4433
895009e1
JB
44342011-04-26 Juanma Barranquero <lekktu@gmail.com>
4435
4436 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4437
6a7a1b0b
TZ
44382011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4439
4440 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4441 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4442 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4443
841a1577 44442011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4445
4446 * lisp.h (Qdebug): List symbol.
895009e1 4447 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4448 * keyboard.c (debug-on-event): New variable.
4449 (handle_user_signal): Break into debugger when debug-on-event
4450 matches the current signal symbol.
4451
f2d3ba6f
DN
44522011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4453
4454 * alloc.c (check_sblock, check_string_bytes)
4455 (check_string_free_list): Convert to standard C.
4456
42ce4c63
TZ
44572011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4458
4459 * w32.c (emacs_gnutls_push): Fix typo.
4460
825cd63c
EZ
44612011-04-25 Eli Zaretskii <eliz@gnu.org>
4462
fb11d64d
EZ
4463 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4464 "cast to pointer from integer of different size".
4465
825cd63c
EZ
4466 Improve doprnt and its use in verror. (Bug#8545)
4467 * doprnt.c (doprnt): Document the set of format control sequences
4468 supported by the function. Use SAFE_ALLOCA instead of always
4469 using `alloca'.
4470
4471 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4472 is one byte too soon. Don't use xrealloc; instead xfree and
4473 xmalloc anew.
4474
e061a11b
TZ
44752011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4476
4477 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4478 callbacks stage.
4479
4480 * gnutls.c: Renamed global_initialized to
4481 gnutls_global_initialized. Added internals for the
4482 :verify-hostname-error, :verify-error, and :verify-flags
4483 parameters of `gnutls-boot' and documented those parameters in the
4484 docstring. Start callback support.
9173deec
JB
4485 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4486 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4487 on error. Return error code.
e061a11b
TZ
4488 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4489 (emacs_gnutls_read): Likewise.
4490 (Fgnutls_boot): Return handshake error code.
4491 (emacs_gnutls_handle_error): New function.
4492 (wsaerror_to_errno): Likewise.
4493
4494 * w32.h (emacs_gnutls_pull): Add prototype.
4495 (emacs_gnutls_push): Likewise.
4496
4497 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4498 (emacs_gnutls_push): Likewise.
4499
45002011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4501
4502 * process.c (wait_reading_process_output): Check if GnuTLS
4503 buffered some data internally if no FDs are set for TLS
4504 connections.
4505
4506 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4507 (LIBS): Link to USER_LIBS.
4508 ($(BLD)/gnutls.$(0)): New target.
4509
fa6996bc
EZ
45102011-04-24 Eli Zaretskii <eliz@gnu.org>
4511
eb35682e
EZ
4512 * xdisp.c (handle_single_display_spec): Rename the
4513 display_replaced_before_p argument into display_replaced_p, to
4514 make it consistent with the commentary. Fix typos in the
4515 commentary.
4516
e2ad650c
EZ
4517 * textprop.c (syms_of_textprop): Remove dead code.
4518 (copy_text_properties): Delete obsolete commentary about an
4519 interface that was deleted long ago. Fix typos in the description
4520 of arguments.
4521
1b2de274
EZ
4522 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4523 to changes in oldXMenu/XMenu.h from 2011-04-16.
4524 <menu_help_message, prev_menu_help_message>: Constify.
4525 (IT_menu_make_room): menu->help_text is now `const char **';
4526 adjust.
4527
4528 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4529 to changes in oldXMenu/XMenu.h from 2011-04-16.
4530 (struct XMenu): Declare `help_text' `const char **'.
4531
4532 * xfaces.c <Qunspecified>: Make extern again.
4533
4534 * syntax.c: Include sys/types.h before including regex.h, as
4535 required by Posix.
4536
762b15be
EZ
4537 * doc.c (get_doc_string): Improve the format passed to `error'.
4538
4539 * doprnt.c (doprnt): Improve commentary.
4540
4541 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4542
4543 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4544 them with etags.
4545
f1052e5d
EZ
4546 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4547 changes in globals.h immediately force recompilation.
762b15be
EZ
4548 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4549 $(CURDIR)/s/ms-w32.h.
4550 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4551
fa6996bc
EZ
4552 * character.c (Fchar_direction): Function deleted.
4553 (syms_of_character): Don't defsubr it.
4554 <char-direction-table>: Deleted.
4555
e6c3da20
EZ
45562011-04-23 Eli Zaretskii <eliz@gnu.org>
4557
4558 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4559 * doprnt.c: Include limits.h.
4560 (SIZE_MAX): New macro.
04f2d78b
CB
4561 (doprnt): Return a size_t value. 2nd arg is now size_t.
4562 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4563 Improve overflow protection. Support `l' modifier for integer
4564 conversions. Support %l conversion. Don't assume an EMACS_INT
4565 argument for integer conversions and for %c.
4566
4567 * lisp.h (doprnt): Restore prototype.
4568
4569 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4570 $(SRC)/character.h.
4571
4572 * Makefile.in (base_obj): Add back doprnt.o.
4573
4574 * deps.mk (doprnt.o): Add back prerequisites.
4575 (callint.o): Depend on character.h.
4576
4577 * eval.c (internal_lisp_condition_case): Include the handler
4578 representation in the error message.
4579 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4580 when breaking from the loop.
4581
4582 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4583
4584 * callint.c (Fcall_interactively): When displaying error message
4585 about invalid control letter, pass the character's codepoint, not
4586 a pointer to its multibyte form. Improve display of the character
4587 in octal and display also its hex code.
4588
4589 * character.c (char_string): Use %x to display the (unsigned)
4590 codepoint of an invalid character, to avoid displaying a bogus
4591 negative value.
4592
4593 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4594 `error', not SYMBOL_NAME itself.
4595
4596 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4597 character arguments to `error'.
4598
4599 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4600 to `error' in error message about FINAL_CHAR argument. Make sure
4601 FINAL_CHAR is a character, and use %c when it is passed as
4602 argument to `error'.
4603
4ffd0d6b 46042011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4605
4606 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4607
4608 * w32.c: Include <time.h>.
4609 (sys_localtime): New function.
4610
4ffd0d6b 46112011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4612
4613 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4614
4ffd0d6b 4615 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4616
4ffd0d6b 46172011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4618
4ffd0d6b
GM
4619 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4620 zombies (Bug#8467).
aac0c6e3 4621
04c56954
EZ
46222011-04-19 Eli Zaretskii <eliz@gnu.org>
4623
4624 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4625 gl_state.e_property when gl_state.object is Qt.
4626
4627 * insdel.c (make_gap_larger): Remove limitation of buffer size
4628 to <= INT_MAX.
4629
16a43933
CY
46302011-04-18 Chong Yidong <cyd@stupidchicken.com>
4631
4632 * xdisp.c (lookup_glyphless_char_display)
4633 (produce_glyphless_glyph): Handle cons cell entry in
4634 glyphless-char-display.
4635 (Vglyphless_char_display): Document it.
4636
4637 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4638 glyphless-char-display.
4639
4581706e
CY
46402011-04-17 Chong Yidong <cyd@stupidchicken.com>
4641
4642 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4643
4644 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4645
4646 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4647 definition for no-X builds.
4648
4887c6e2 46492011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4650
fd35b6f9
PE
4651 Static checks with GCC 4.6.0 and non-default toolkits.
4652
5c1ccb01
PE
4653 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4654
006c5daa
PE
4655 * process.c (keyboard_bit_set): Define only if SIGIO.
4656 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4657 (send_process): Repair possible setjmp clobbering.
4658
efc736d3
PE
4659 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4660
4e2fe2e6
PE
4661 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4662
f97334a2
PE
4663 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4664
4e75f29d
PE
4665 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4666 Define only if needed.
4667
90efadd1
PE
4668 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4669 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4670 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4671
3c647824
PE
4672 * dispextern.h (struct redisplay_interface): Rename param
4673 to avoid shadowing.
e264f262 4674 * termhooks.h (struct terminal): Likewise.
761383f4 4675 * xterm.c (xembed_send_message): Likewise.
3c647824 4676
b58c5c4a
PE
4677 * insdel.c (make_gap_smaller): Define only if
4678 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4679
cad59032
PE
4680 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4681 it.
4682
c339dc2e
PE
4683 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4684 so that we aren't warned about unused symbols.
4685
91a3e27b
PE
4686 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4687
399c71d3 4688 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4689
8ffc96f5
PE
4690 * xfns.c (x_real_positions): Mark locals as initialized.
4691
eef9bc79
PE
4692 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4693
098db9dd
PE
4694 * xterm.c: Fix problems found by static analysis with other toolkits.
4695 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4696 (x_dispatch_event): Declare static if USE_GTK, and
4697 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4698 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4699 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4700 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4701 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4702
eb18f6cc
PE
4703 * xmenu.c (menu_help_callback): Pointer type fixes.
4704 Use const pointers when pointing at readonly data. Avoid pointer
4705 signedness clashes.
4706 (FALSE): Remove unused macro.
4707 (update_frame_menubar): Remove unused decl.
4708
1fe72bf8
PE
4709 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4710
60d9e1db
PE
4711 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4712 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4713 (single_menu_item): Rename local to avoid shadowing.
4714
39261c26
PE
4715 * keyboard.c (make_lispy_event): Remove unused local var.
4716
018c5e19
PE
4717 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4718 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4719
63d2b86e
PE
4720 * bitmaps: Change bitmaps from unsigned char back to the X11
4721 compatible char. Avoid the old compiler warnings about
4722 out-of-range initializers by using, for example, '\xab' rather
4723 than 0xab.
4724
aefd87e1
PE
4725 * xgselect.c (xgselect_initialize): Check vs interface
4726 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4727
bf501fb9
PE
4728 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4729
e9829fdf
PE
4730 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4731 to read-only memory.
4732
1086c095
PE
4733 * fns.c (vector): Remove; this old hack is no longer needed.
4734
2baccd04 4735 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4736 Remove unused var.
dde42981 4737 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4738
72391843 4739 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4740
436c16df 4741 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4742 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4743 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4744
92bb796d 4745 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4746 (x_term_init): Remove local to avoid shadowing.
92bb796d 4747
764430a3 4748 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4749
4750 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4751 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4752
d1dfb56c
EZ
47532011-04-16 Eli Zaretskii <eliz@gnu.org>
4754
c4354cb4
EZ
4755 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4756
d1dfb56c
EZ
4757 Fix regex.c, syntax.c and friends for buffers > 2GB.
4758 * syntax.h (struct gl_state_s): Declare character position members
4759 EMACS_INT.
4760
4761 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4762
04f2d78b
CB
4763 * textprop.c (verify_interval_modification, interval_of):
4764 Declare arguments EMACS_INT.
d1dfb56c
EZ
4765
4766 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4767 EMACS_INT.
4768
4769 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4770
4771 * indent.c (Fvertical_motion): Local variable it_start is now
4772 EMACS_INT.
4773
4774 * regex.c (re_match, re_match_2, re_match_2_internal)
4775 (bcmp_translate, regcomp, regexec, print_double_string)
4776 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4777 (re_compile_pattern, re_exec): Declare arguments and local
4778 variables `size_t' and `ssize_t' and return values `regoff_t', as
4779 appropriate.
4780 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4781 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4782 <compile_stack_type>: `size' and `avail' are now `size_t'.
4783
4784 * regex.h <regoff_t>: Use ssize_t, not int.
4785 (re_search, re_search_2, re_match, re_match_2): Arguments that
4786 specify buffer/string position and length are now ssize_t and
4787 size_t. Return type is regoff_t.
4788
613052cd
BK
47892011-04-16 Ben Key <bkey76@gmail.com>
4790
4791 * nsfont.m: Fixed bugs in ns_get_family and
4792 ns_descriptor_to_entity that were caused by using free to
4793 deallocate memory blocks that were allocated by xmalloc (via
4794 xstrdup). This caused Emacs to crash when compiled with
4795 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4796 --enable-checking=xmallocoverrun). xfree is now used to
4797 deallocate these memory blocks.
4798
4170f62f 47992011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4800
71b41406
PE
4801 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4802
9587a89d
PE
4803 emacs_write: Accept and return EMACS_INT for sizes.
4804 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4805 et seq.
4806 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4807 Accept and return EMACS_INT.
4808 (emacs_gnutls_write): Return the number of bytes written on
4809 partial writes.
4810 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4811 (emacs_read, emacs_write): Remove check for negative size, as the
4812 Emacs source code has been audited now.
9587a89d
PE
4813 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4814 (emacs_read, emacs_write): Use it.
273a5f82
PE
4815 * process.c (send_process): Adjust to the new signatures of
4816 emacs_write and emacs_gnutls_write. Do not attempt to store
4817 a byte offset into an 'int'; it might overflow.
9587a89d 4818 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4819
3e047f51
PE
4820 * sound.c: Don't assume sizes fit in 'int'.
4821 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4822 Return EMACS_INT, not int.
3e047f51 4823 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4824 Accept EMACS_INT, not int.
4825 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4826 record read return values.
4827
cc39a9db
BK
48282011-04-15 Ben Key <bkey76@gmail.com>
4829
c9d0ec6d
JB
4830 * keyboard.c (Qundefined): Don't declare static since it is used
4831 in nsfns.m.
4832 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4833 static since they are used in nsfont.m.
cc39a9db 4834
6c60eb9f
SM
48352011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4836
4837 * process.c (Qprocessp): Don't declare static.
4838 * lisp.h (Qprocessp): Declare again.
4839
7990b61a
JB
48402011-04-15 Juanma Barranquero <lekktu@gmail.com>
4841
4842 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4843
5d4cb038
PE
48442011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4845
8bd7b830 4846 Improve C-level modularity by making more things 'static'.
cd64ea1d 4847
e3b27b31
PE
4848 Don't publish debugger-only interfaces to other modules.
4849 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4850 (verify_bytepos, count_markers): Move decls to the only modules
4851 that need them.
4852 * region-cache.h (pp_cache): Likewise.
4853 * window.h (check_all_windows): Likewise.
4854 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4855
5d4cb038
PE
4856 * sysdep.c (croak): Now static, if
4857 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4858 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4859
4860 * alloc.c (refill_memory_reserve): Now static if
4861 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4862 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4863
e87b6180
PE
4864 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4865 Define only if USE_LUCID.
4866
ac64929e
PE
4867 * xrdb.c (x_customization_string, x_rm_string): Now static.
4868
6f37259d
PE
4869 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4870 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4871
1683e3ab
PE
4872 * xdisp.c (draw_row_with_mouse_face): Now static.
4873 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4874
de9c2632
PE
4875 * window.h (check_all_windows): Mark externally visible.
4876
2b96acb7
PE
4877 * window.c (window_deletion_count): Now static.
4878
4879 * undo.c: Make symbols static if they're not exported.
4880 (last_undo_buffer, last_boundary_position, pending_boundary):
4881 Now static.
4882
50436f33
PE
4883 * textprop.c (interval_insert_behind_hooks): Now static.
4884 (interval_insert_in_front_hooks): Likewise.
4885
64520e5c
PE
4886 * term.c: Make symbols static if they're not exported.
4887 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4888 (max_frame_lines, tty_set_terminal_modes):
4889 (tty_reset_terminal_modes, tty_turn_off_highlight):
4890 (get_tty_terminal): Now static.
4891 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4892 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4893 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4894 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4895 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4896
1fa53021
PE
4897 * sysdep.c: Make symbols static if they're not exported.
4898 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4899 Now static.
4900 (sigprocmask_set, full_mask): Remove; unused.
4901 (wait_debugging): Mark as visible.
4902 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4903 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4904
d4b43b22
PE
4905 * syntax.c (syntax_temp): Define only if !__GNUC__.
4906
b7c513d0
PE
4907 * sound.c (current_sound_device, current_sound): Now static.
4908
989b29ad
PE
4909 * search.c (searchbufs, searchbuf_head): Now static.
4910
13a55a78
PE
4911 * scroll.c (scroll_cost): Remove; unused.
4912 * dispextern.h (scroll_cost): Remove decl.
4913
de68a1fc
PE
4914 * region-cache.h (pp_cache): Mark as externally visible.
4915
40ccffa6
PE
4916 * process.c: Make symbols static if they're not exported.
4917 (process_tick, update_tick, create_process, chan_process):
4918 (Vprocess_alist, proc_buffered_char, datagram_access):
4919 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4920 (deactivate_process): Mark defn as static, as well as decl.
4921 * lisp.h (create_process): Remove decl.
4922 * process.h (chan_process, Vprocess_alist): Remove decls.
4923
ad64fc97
PE
4924 * print.c: Make symbols static if they're not exported.
4925 (print_depth, new_backquote_output, being_printed, print_buffer):
4926 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4927 (print_interval, print_number_index, initial_stderr_stream):
4928 Now static.
4929 * lisp.h (Fprinc): Remove decl.
4930 (debug_output_compilation_hack): Mark as externally visible.
4931
adddb265
PE
4932 * sysdep.c (croak): Move decl from here to syssignal.h.
4933 * syssignal.h (croak): Put it here, so the API can be checked when
4934 'croak' is called from dissociate_if_controlling_tty.
4935
1717ede2
PE
4936 * minibuf.c: Make symbols static if they're not exported.
4937 (minibuf_save_list, choose_minibuf_frame): Now static.
4938 * lisp.h (choose_minibuf_frame): Remove decl.
4939
fa5fb2bc
PE
4940 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4941
1e3890d1
PE
4942 * lread.c: Make symbols static if they're not exported.
4943 (read_objects, initial_obarray, oblookup_last_bucket_number):
4944 Now static.
4945 (make_symbol): Remove; unused.
4946 * lisp.h (initial_obarray, make_symbol): Remove decls.
4947
8a1414fa
PE
4948 * keyboard.c: Make symbols static if they're not exported.
4949 (single_kboard, recent_keys_index, total_keys, recent_keys):
4950 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4951 (this_single_command_key_start, echoing, last_auto_save):
4952 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4953 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4954 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4955 (Vlispy_mouse_stem, double_click_count):
4956 Now static.
4957 (force_auto_save_soon): Define only if SIGDANGER.
4958 (ignore_mouse_drag_p): Now static if
4959 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4960 (print_help): Remove; unused.
4961 (stop_character, last_timer_event): Mark as externally visible.
4962 * keyboard.h (ignore_mouse_drag_p): Declare only if
4963 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4964 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4965 * lisp.h (echoing): Remove decl.
4966 (force_auto_save_soon): Declare only if SIGDANGER.
4967 * xdisp.c (redisplay_window): Simplify code, to make it more
4968 obvious that ignore_mouse_drag_p is not accessed if !defined
4969 USE_GTK && !defined HAVE_NS.
4970
93ea6e8f
PE
4971 * intervals.c: Make symbols static if they're not exported.
4972 (merge_properties_sticky, merge_interval_right, delete_interval):
4973 Now static.
4974 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4975
77382fcc
PE
4976 * insdel.c: Make symbols static if they're not exported.
4977 However, leave prepare_to_modify_buffer alone. It's never
4978 called from outside this function, but that appears to be a bug.
4979 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4980 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4981 (adjust_after_replace_noundo): Remove; unused.
4982 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4983 (signal_before_change): Remove decls.
77382fcc 4984
9306c32e
PE
4985 * indent.c (val_compute_motion, val_vmotion): Now static.
4986
cd44d2eb
PE
4987 * image.c: Make symbols static if they're not exported.
4988 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4989 if USE_GTK.
4990 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4991 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4992
ad9a7a06
PE
4993 * fringe.c (standard_bitmaps): Now static.
4994 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4995
81626931
PE
4996 * frame.c: Make symbols static if they're not exported.
4997 (x_report_frame_params, make_terminal_frame): Now static.
4998 (get_frame_param): Now static, unless HAVE_NS.
4999 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5000 (x_get_resource_string): Remove; not used.
5001 * frame.h (make_terminal_frame, x_report_frame_params):
5002 (x_get_resource_string); Remove decls.
5003 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5004 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5005
239f9db9
PE
5006 * font.c, fontset.c: Make symbols static if they're not exported.
5007 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5008 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5009 * font.c (font_close_object): Now static.
5010 * font.h (font_close_object): Remove.
5011 * fontset.c (FONTSET_OBJLIST): Remove.
5012 (free_realized_fontset) #if-0 the body, which does nothing.
5013 (face_suitable_for_char_p): #if-0, as it's never called.
5014 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5015 * xfaces.c (face_at_string_position):
5016 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5017 since 0 is always ASCII.
5018
dfcf3579
PE
5019 * fns.c (weak_hash_tables): Now static.
5020
5045092b
PE
5021 * fileio.c: Make symbols static if they're not exported.
5022 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5023 (Vwrite_region_annotation_buffers): Now static.
5024
57a96f5c
PE
5025 * eval.c: Make symbols static if they're not exported.
5026 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5027 * lisp.h (backtrace_list): Remove decl.
5028
35f08c38
PE
5029 * emacs.c: Make symbols static if they're not exported.
5030 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5031 (fatal_error_code, fatal_error_signal_hook, standard_args):
5032 Now static.
5033 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5034 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5035 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5036 * lisp.h (fatal_error_signal_hook): Remove decl.
5037 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5038
f44bd759
PE
5039 * editfns.c: Move a (normally-unused) function to its only use.
5040 * editfns.c, lisp.h (get_operating_system_release): Remove.
5041 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5042 worth the hassle of breaking this out.
5043
b532497d
PE
5044 * xterm.c: Make symbols static if they're not exported.
5045 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5046 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5047 (x_destroy_window, x_delete_display):
5048 Now static.
5049 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5050 (x_mouse_leave): Remove; unused.
5051 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5052 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5053 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5054 Remove decls.
5055 (x_mouse_leave): Declare only if WINDOWSNT.
5056 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5057 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5058 USE_X_TOOLKIT.
5059
1675728f
PE
5060 * ftxfont.c: Make symbols static if they're not exported.
5061 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5062 HAVE_FREETYPE.
5063 * font.h (ftxfont_driver): Likewise.
5064
e4cebfca
PE
5065 * xfns.c: Make symbols static if they're not exported.
5066 (x_last_font_name, x_display_info_for_name):
5067 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5068 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5069 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5070 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5071 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5072 (last_show_tip_args): Now static.
5073 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5074 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5075 (x_screen_planes): Remove; unused.
5076 * dispextern.h (x_screen_planes): Remove decl.
5077
5bf46f05
PE
5078 * dispnew.c: Make symbols static if they're not exported.
5079 * dispextern.h (redraw_garbaged_frames, scrolling):
5080 (increment_row_positions): Remove.
5081 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5082 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5083 Now static.
5084 (redraw_garbaged_frames): Remove; unused.
5085
435f4c28
PE
5086 * xfaces.c: Make symbols static if they're not exported.
5087 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5088 Remove decls.
5089 * xterm.h (defined_color): Remove decls.
5090 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5091 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5092 (menu_face_changed_default, defined_color, free_realized_face):
5093 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5094 (ascii_face_of_lisp_face): Remove; unused.
5095
8524aef3
PE
5096 * xdisp.c: Make symbols static if they're not exported.
5097 * dispextern.h (scratch_glyph_row, window_box_edges):
5098 (glyph_to_pixel_coords, set_cursor_from_row):
5099 (get_next_display_element, set_iterator_to_next):
5100 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5101 (show_mouse_face): Remove decls
5102 * frame.h (message_buf_print): Likewise.
5103 * lisp.h (pop_message, set_message, check_point_in_composition):
5104 Likewise.
5105 * xterm.h (set_vertical_scroll_bar): Likewise.
5106 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5107 (message_buf_print, scratch_glyph_row, displayed_buffer):
5108 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5109 (get_next_display_element, show_mouse_face, window_box_edges):
5110 (frame_to_window_pixel_xy, check_point_in_composition):
5111 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5112 (glyph_to_pixel_coords): Remove; unused.
5113
16390cd2
PE
5114 * dired.c (file_name_completion): Now static.
5115
5116 * dbusbind.c (xd_in_read_queued_messages): Now static.
5117
a25f4dfa
PE
5118 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5119 * data.c (circular_list_error): Remove.
5120
14a9c8df
PE
5121 * commands.h (last_point_position, last_point_position_buffer):
5122 (last_point_position_window): Remove decls.
5123 * keyboard.c: Make these variables static.
5124
04f2d78b
CB
5125 * coding.h (coding, code_convert_region, encode_coding_gap):
5126 Remove decls.
74ab6df5
PE
5127 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5128 (iso_code_class, detect_coding, code_convert_region): Now static.
5129 (encode_coding_gap): Remove; unused.
5130
38dfbee1
PE
5131 * chartab.c (chartab_chars, chartab_bits): Now static.
5132
a2cb4e63
PE
5133 * charset.h (charset_iso_8859_1): Remove decl.
5134 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5135 Now static.
5136
127198fd
PE
5137 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5138 * ccl.c (Vccl_program_table): Now static.
5139 (check_ccl_update): Remove; unused.
5140
d85b608f
PE
5141 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5142 * category.h: ... from here.
5143 * category.c (check_category_table, set_category_set): Now static.
5144
31cd66f3
PE
5145 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5146 * lisp.h: Remove these decls.
5147
c358e587
PE
5148 * buffer.c (buffer_count): Remove unused var.
5149
e78aecca
PE
5150 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5151 so that it's not optimized away.
5152 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5153 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5154 exported only to the debugger.
5155
e192d7d3 5156 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5157 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5158
92470028
PE
5159 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5160 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5161 was inaccessible from Lisp.
5162 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5163 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5164
244ed907
PE
5165 alloc.c: Import and export fewer symbols, and remove unused items.
5166 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5167 is defined.
5168 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5169 it's not optimized away by whole-program optimization.
5170 (message_enable_multibyte, free_misc): Remove.
5171 (catchlist, handlerlist, mark_backtrace):
5172 Declare only if BYTE_MARK_STACK.
5173 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5174 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5175 (message_enable_multibyte): Remove decl.
5176 (free_misc, interval_free_list, float_block, float_block_index):
5177 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5178 (cons_free_list, last_marked_index):
5179 Now static.
5180 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5181 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5182 (mark_backtrace): Define only if BYTE_MARK_STACK.
5183 * xdisp.c (message_enable_multibyte): Now static.
5184
61c2b50e 5185 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5186 This makes it easier for human readers (and static analyzers)
5187 to see whether these variables are used from other modules.
5188 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5189 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5190 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5191 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5192 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5193 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5194 * xmenu.c, xselect.c:
5195 Declare Q* vars static if they are not used in other modules.
5196 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5197 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5198 Remove decls of unexported vars.
5199 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5200
95c82688
PE
5201 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5202
16a97296
PE
5203 Make Emacs functions such as Fatom 'static' by default.
5204 This makes it easier for human readers (and static analyzers)
5205 to see whether these functions can be called from other modules.
5206 DEFUN now defines a static function. To make the function external
5207 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5208 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5209 (Finit_image_library):
16a97296
PE
5210 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5211 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5212 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5213 Remove decls, since these functions are now static.
5214 (Funintern, Fget_internal_run_time): New decls, since these functions
5215 were already external.
95c82688 5216
16a97296
PE
5217 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5218 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5219 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5220 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5221 * keyboard.c, keymap.c, lread.c:
5222 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5223 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5224 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5225 Mark functions with DEFUE instead of DEFUN,
5226 if they are used in other modules.
5227 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5228 decls for now-static functions.
5229 * buffer.h (Fdelete_overlay): Remove decl.
5230 * callproc.c (Fgetenv_internal): Mark as internal.
5231 * composite.c (Fremove_list_of_text_properties): Remove decl.
5232 (Fcomposition_get_gstring): New forward static decl.
5233 * composite.h (Fcomposite_get_gstring): Remove decl.
5234 * dired.c (Ffile_attributes): New forward static decl.
5235 * doc.c (Fdocumntation_property): New forward static decl.
5236 * eval.c (Ffetch_bytecode): New forward static decl.
5237 (Funintern): Remove extern decl; now in .h file where it belongs.
5238 * fileio.c (Fmake_symbolic_link): New forward static decl.
5239 * image.c (Finit_image_library): New forward static decl.
5240 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5241 * intervals.h (Fprevious_property_change):
5242 (Fremove_list_of_text_properties): Remove decls.
5243 * keyboard.c (Fthis_command_keys): Remove decl.
5244 (Fcommand_execute): New forward static decl.
5245 * keymap.c (Flookup_key): New forward static decl.
5246 (Fcopy_keymap): Now static.
5247 * keymap.h (Flookup_key): Remove decl.
5248 * process.c (Fget_process): New forward static decl.
5249 (Fprocess_datagram_address): Mark as internal.
5250 * syntax.c (Fsyntax_table_p): New forward static decl.
5251 (skip_chars): Remove duplicate decl.
5252 * textprop.c (Fprevious_property_change): New forward static decl.
5253 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5254 Now internal.
5255 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5256 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5257
785bbd42
PE
5258 * editfns.c (Fformat): Remove unreachable code.
5259
8b913b57
AS
52602011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5261
5262 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5263 change. (Bug#8496)
5264
a6744a35
EZ
52652011-04-13 Eli Zaretskii <eliz@gnu.org>
5266
5267 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5268 when at ZV. (Bug#8487)
5269
e7974947
AS
52702011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5271
baad03f0
AS
5272 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5273 (Bug#8437)
5274 * keyboard.c (parse_tool_bar_item): Likewise.
5275 * sound.c (sound_cleanup, alsa_close): Likewise.
5276 * termcap.c (tgetent): Likewise.
5277 * xfns.c (x_default_font_parameter): Likewise.
5278 * xsettings.c (read_and_apply_settings): Likewise.
5279
e7974947
AS
5280 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5281 (overrun_check_free): Protoize.
5282
28272684
PE
52832011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5284
5285 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5286 since callers should never pass a negative size.
5287 Change the signature to match that of plain 'read' and 'write'; see
5288 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5289 * lisp.h: Update prototypes of emacs_write and emacs_read.
5290
11997c76
EZ
52912011-04-11 Eli Zaretskii <eliz@gnu.org>
5292
5293 * xdisp.c (redisplay_window): Don't try to determine the character
5294 position of the scroll margin if the window start point w->startp
e896f03c 5295 is outside the buffer's accessible region. (Bug#8468)
11997c76 5296
8a2cbd72
EZ
52972011-04-10 Eli Zaretskii <eliz@gnu.org>
5298
5299 Fix write-region and its subroutines for buffers > 2GB.
5300 * fileio.c (a_write, e_write): Modify declaration of arguments and
5301 local variables to support buffers larger than 2GB.
5302 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5303
5304 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5305 argument, local variables, and return value.
5306
5307 * lisp.h: Update prototypes of emacs_write and emacs_read.
5308
5309 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5310
4073e537 53112011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5312
1ebfdcb6
PE
5313 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5314
b2ded58d
PE
5315 Fix more problems found by GCC 4.6.0's static checks.
5316
7d66342c
PE
5317 * xdisp.c (vmessage): Use a better test for character truncation.
5318
bbf47d44
PE
5319 * charset.c (load_charset_map): <, not <=, for optimization,
5320 and to avoid potential problems with integer overflow.
9248994d 5321 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5322 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5323 * editfns.c (Fformat): Likewise.
1e69125e 5324 * syntax.c (skip_chars): Likewise.
3befa583 5325
e3019616
PE
5326 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5327 This also lets GCC 4.6.0 generate slightly better loop code.
5328
becfa255
PE
5329 * callint.c (Fcall_interactively): <, not <=, for optimization.
5330 (Fcall_interactively): Count the number of arguments produced,
5331 not the number of arguments given. This is simpler and lets GCC
5332 4.6.0 generate slightly better code.
5333
dae0cd48
PE
5334 * ftfont.c: Distingish more carefully between FcChar8 and char.
5335 The previous code passed unsigned char * to a functions like
5336 strlen and xstrcasecmp that expect char *, which does not
5337 conform to the C standard.
5338 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5339 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5340 char * when the C standard requires it.
5341
76032d70
PE
5342 * keyboard.c (read_char): Remove unused var.
5343
eb3f1cc8
PE
5344 * eval.c: Port to Windows vsnprintf (Bug#8435).
5345 Include <limits.h>.
5346 (SIZE_MAX): Define if the headers do not.
5347 (verror): Do not give up if vsnprintf returns a negative count.
5348 Instead, grow the buffer. This ports to Windows vsnprintf, which
5349 does not conform to C99. Problem reported by Eli Zaretskii.
5350 Also, simplify the allocation scheme, by avoiding the need for
5351 calling realloc, and removing the ALLOCATED variable.
5352
70476b54
PE
5353 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5354
12020a9e
PE
5355 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5356 But keep the doprint source code for now, as we might revamp it
5357 and use it again (Bug#8435).
ea6c7ae6
PE
5358 * lisp.h (doprnt): Remove.
5359 * Makefile.in (base_obj): Remove doprnt.o.
5360 * deps.mk (doprnt.o): Remove.
5361
5fdb398c
PE
5362 error: Print 32- and 64-bit integers portably (Bug#8435).
5363 Without this change, on typical 64-bit hosts error ("...%d...", N)
5364 was used to print both 32- and 64-bit integers N, which relied on
5365 undefined behavior.
5366 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5367 New macro.
5368 * lisp.h (error, verror): Mark as printf-like functions.
5369 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5370 Report overflow in size calculations when allocating printf buffer.
5371 Do not truncate output string at its first null byte.
5372 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5373 Truncate the output at a character boundary, since vsnprintf does not
5374 do that.
5375 * charset.c (check_iso_charset_parameter): Convert internal
5376 character to string before calling 'error', since %c now has the
5377 printf meaning.
5378 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5379 overflow when computing char to be passed to 'error'. Do not
5380 pass Lisp_Object to 'error'; pass the integer instead.
5381 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5382 formatted with plain %d.
5383
b189fa66
PE
5384 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5385
bff87ef0
PE
5386 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5387
7e2cac20
PE
5388 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5389
ce4d90b5
PE
5390 * xterm.c (x_catch_errors): Remove duplicate declaration.
5391
266c9547
PE
5392 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5393
79c49ad2
PE
5394 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5395
368f4090
JM
53962011-04-10 Jim Meyering <meyering@redhat.com>
5397
5398 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5399 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5400 return ssize_t not "int", and use size_t as the buffer length.
5401 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5402 * gnutls.h: Update declarations.
5403 * process.c (read_process_output): Use ssize_t, to match.
5404 (send_process): Likewise.
5405
a32d4040
CY
54062011-04-09 Chong Yidong <cyd@stupidchicken.com>
5407
5408 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5409
8546720e 54102011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5411
04f2d78b
CB
5412 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5413 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5414
8546720e
GM
5415 * xterm.c (handle_one_xevent):
5416 * xmenu.c (create_and_show_popup_menu):
5417 * xselect.c (x_decline_selection_request)
5418 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5419
0a2f5c1a 54202011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5421
5422 Fix some uses of `int' instead of EMACS_INT.
5423 * search.c (string_match_1, fast_string_match)
5424 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5425 (scan_buffer, find_next_newline_no_quit)
5426 (find_before_next_newline, search_command, Freplace_match)
5427 (Fmatch_data): Make some `int' variables be EMACS_INT.
5428
5429 * xdisp.c (display_count_lines): 3rd argument and return value now
5430 EMACS_INT. All callers changed.
5431 (pint2hrstr): Last argument is now EMACS_INT.
5432
5433 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5434 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5435 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5436 (decode_coding_utf_16, decode_coding_emacs_mule)
5437 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5438 (decode_coding_ccl, decode_coding_charset)
5439 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5440 (decode_coding_iso_2022, decode_coding_emacs_mule)
5441 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5442 <char_offset, last_offset>: Declare EMACS_INT.
5443 (encode_coding_utf_8, encode_coding_utf_16)
5444 (encode_coding_emacs_mule, encode_invocation_designation)
5445 (encode_designation_at_bol, encode_coding_iso_2022)
5446 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5447 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5448 Declare EMACS_INT.
5449 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5450 (encode_invocation_designation): Last argument P_NCHARS is now
5451 EMACS_INT.
5452 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5453 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5454
5455 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5456 All users changed.
5457
5458 * ccl.c (Fccl_execute_on_string): Declare some variables
5459 EMACS_INT.
5460
8546720e 54612011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5462
5463 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5464
4e19a977
CS
54652011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5466
5467 * process.c (Fformat_network_address): Doc fix.
5468
87302331
R
54692011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5470
5471 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5472
cbb59342
CY
54732011-04-08 Chong Yidong <cyd@stupidchicken.com>
5474
5475 * keyboard.c (read_char): Call Lisp function help-form-show,
5476 instead of using internal_with_output_to_temp_buffer.
5477 (Qhelp_form_show): New var.
e0d38eeb 5478 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5479
5480 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5481
5482 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5483
e67a13ab
CY
54842011-04-06 Chong Yidong <cyd@stupidchicken.com>
5485
04f2d78b
CB
5486 * process.c (Flist_processes): Remove to Lisp.
5487 (list_processes_1): Delete.
e67a13ab 5488
973f782d
EZ
54892011-04-06 Eli Zaretskii <eliz@gnu.org>
5490
7c106b1e
EZ
5491 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5492
973f782d
EZ
5493 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5494
41cf7d1a 54952011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5496
ca23cc88
PE
5497 Fix more problems found by GCC 4.6.0's static checks.
5498
f390e2d5
PE
5499 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5500
42eea0d0
PE
5501 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5502
b69769da 5503 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5504
f9541e84
PE
5505 * xdisp.c (vmessage): Mark as a printf-like function.
5506
13841b55
PE
5507 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5508
c136c10f
PE
5509 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5510
5e2d4a30
PE
5511 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5512 printf-like functions.
5513 (tiff_load): Add casts to remove these marks before passing them
5514 to system-supplied API.
5515
583f48b9
PE
5516 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5517
b25d760e
PE
5518 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5519 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5520 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5521 directly, rather than having caller test rule sign. This avoids
5522 some unnecessary tests.
5523 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5524 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5525 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5526
bc7b6697 5527 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5528 (xfont_open): Avoid unnecessary tests.
bc7b6697 5529
27ccc379
PE
5530 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5531
dcd5c89a
PE
5532 * composite.h, composite.c (composition_gstring_put_cache):
5533 Use EMACS_INT, not int, for length.
5534
b13a45c6
PE
5535 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5536 breaking out part of COMPOSITION_DECODE_RULE.
5537 (COMPOSITION_DECODE_RULE): Use it.
5538 * composite.c (get_composition_id): Remove unused local vars,
5539 by using the new macro.
5540
1e792e4d
PE
5541 * textprop.c (set_text_properties_1): Change while to do-while,
5542 since the condition is always true at first.
5543
dc6c6455 5544 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5545 (interval_deletion_adjustment): Return unsigned value.
5546 All uses changed.
dc6c6455 5547
aba7731a
PE
5548 * process.c (list_processes_1, create_pty, read_process_output):
5549 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5550 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5551 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5552 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5553 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5554
fdfc4bf3
PE
5555 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5556
fca8fe46 5557 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5558 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5559
06a0259a 5560 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5561 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5562 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5563
e7b9e80f
PE
5564 * print.c (print_error_message): Avoid int overflow.
5565
56201685
PE
5566 * font.c (font_list_entities): Redo for clarity,
5567 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5568
78834453 5569 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5570 (font_score): Avoid potential overflow in diff calculation.
78834453 5571
0bc0b309 5572 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5573 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5574
e610eaca
PE
5575 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5576
b895abce
PE
5577 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5578 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5579 can always succeed if overflow has undefined behavior.
5580
1f1d9321 5581 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5582 (wordify): Omit three unnecessary tests.
1f1d9321 5583
c59478bc
PE
5584 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5585 All callers changed. This avoids the need for an unused var.
5586
79b73827
PE
5587 * casefiddle.c (casify_region): Remove var that is set but not used.
5588
a4db5dfe
PE
5589 * dired.c (file_name_completion): Remove var that is set but not used.
5590
43aae36e
PE
5591 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5592
2a47c44d 5593 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5594 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5595
a37c69bf
PE
5596 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5597 Check for integer overflow on size calculations.
5598
328ab8e7
PE
5599 * buffer.c (Fprevious_overlay_change): Remove var that is set
5600 but not used.
5601
e5a2a5cb
PE
5602 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5603 Remove vars that are set but not used.
8d84a6eb 5604 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5605 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5606
a60e5f68
PE
5607 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5608
f661cb61 5609 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5610 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5611
f0397f5a
PE
5612 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5613 that are set but not used.
5614
8664db06 5615 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5616 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5617
6abdaa4a
PE
5618 * xselect.c (x_get_local_selection, x_handle_property_notify):
5619 Remove vars that are set but not used.
5620
0ce7538d 5621 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5622 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5623
9ae848fc
PE
5624 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5625 Remove var that is set but not used.
0b918413
PE
5626 (scroll_bar_windows_size): Now size_t, not int.
5627 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5628 Check for overflow.
9ae848fc 5629
a5a62657
PE
5630 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5631 (map_tty_color) [!defined MSDOS]: Likewise.
5632
5c5cdd39
PE
5633 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5634
66ebf983
PE
5635 * coding.c: Remove vars that are set but not used.
5636 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5637 All callers changed.
5638 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5639 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5640 (decode_coding_charset): Remove vars that are set but not used.
5641
1be4d761
PE
5642 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5643 that is set but not used.
5644
47553fa8
PE
5645 * print.c (print_object): Remove var that is set but not used.
5646
1f7196bf 5647 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5648 The gnulib version avoids calling malloc in the usual case,
5649 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5650 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5651 * filelock.c (current_lock_owner): Likewise.
5652 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5653 * sysdep.c: Include allocator.h, careadlinkat.h.
5654 (emacs_no_realloc_allocator): New static constant.
5655 (emacs_readlink): New function.
fdb61804
PE
5656 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5657 ../lib/careadlinkat.h.
d1fdcab7 5658
f84c17c7
SM
56592011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5660
5661 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5662 first non-nil return value).
5663
ef3862ad
JD
56642011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5665
5666 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5667 if not defined (Bug#8403).
5668
376a7006
JB
56692011-04-02 Juanma Barranquero <lekktu@gmail.com>
5670
5671 * xdisp.c (display_count_lines): Remove parameter `start',
5672 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5673 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5674 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5675 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5676 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5677 and thereabouts. All callers changed.
5678 (get_per_char_metric): Remove parameter `f', unused since
5679 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5680
6ca3801d
JM
56812011-04-02 Jim Meyering <meyering@redhat.com>
5682
5683 do not dereference NULL upon failed strdup
5684 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5685 (ns_get_family): Likewise.
5686
d8e2b5ba
JB
56872011-04-02 Juanma Barranquero <lekktu@gmail.com>
5688
5689 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5690
8c74fcbd
JD
56912011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5692
5693 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5694 later (Bug#8403).
5695
7200d79c
SM
56962011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5697
03408648 5698 Add lexical binding.
7200d79c 5699
03408648
SM
5700 * window.c (Ftemp_output_buffer_show): New fun.
5701 (Fsave_window_excursion):
5702 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5703
5704 * lread.c (lisp_file_lexically_bound_p): New function.
5705 (Fload): Bind Qlexical_binding.
5706 (readevalloop): Remove `evalfun' arg.
5707 Bind Qinternal_interpreter_environment.
5708 (Feval_buffer): Bind Qlexical_binding.
5709 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5710 Mark as dynamic.
5711 (syms_of_lread): Declare `lexical-binding'.
5712
5713 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5714
5715 * keyboard.c (eval_dyn): New fun.
5716 (menu_item_eval_property): Use it.
ca105506
SM
5717
5718 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5719
03408648
SM
5720 * fns.c (concat, mapcar1): Accept byte-code-functions.
5721
5722 * eval.c (Fsetq): Handle lexical vars.
5723 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5724 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5725 (FletX, Flet): Obey lexical binding.
5726 (Fcommandp): Handle closures.
5727 (Feval): New `lexical' arg.
5728 (eval_sub): New function extracted from Feval. Use it almost
5729 everywhere where Feval was used. Look up vars in lexical env.
5730 Handle closures.
5731 (Ffunctionp): Move from subr.el.
5732 (Ffuncall): Handle closures.
5733 (apply_lambda): Remove `eval_flags'.
5734 (funcall_lambda): Handle closures and new byte-code-functions.
5735 (Fspecial_variable_p): New function.
5736 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5737 but without exporting it to Lisp.
23aba0ea 5738
23aba0ea 5739 * doc.c (Fdocumentation, store_function_docstring):
03408648 5740 * data.c (Finteractive_form): Handle closures.
23aba0ea 5741
03408648
SM
5742 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5743 interactive spec.
ba83908c 5744
04f2d78b
CB
5745 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5746 New byte-codes.
03408648
SM
5747 (exec_byte_code): New function extracted from Fbyte_code to handle new
5748 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5749
03408648 5750 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5751
03408648 5752 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5753
e2abce01
JB
57542011-03-31 Juanma Barranquero <lekktu@gmail.com>
5755
5756 * xdisp.c (redisplay_internal): Fix prototype.
5757
63696a73 57582011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5759
63696a73 5760 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5761 (try_scrolling): Use it when setting scroll_limit.
5762 Limit scrolling to 100 screen lines.
63696a73
EZ
5763 (redisplay_window): Even when falling back on "recentering",
5764 position point in the window according to scroll-conservatively,
5765 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5766
5767 (try_scrolling): When point is above the window, allow searching
5768 as far as scroll_max, or one screenful, to compute vertical
5769 distance from PT to the scroll margin position. This prevents
5770 try_scrolling from unnecessarily failing when
5771 scroll-conservatively is set to a value slightly larger than the
5772 window height. Clean up the case of PT below the margin at bottom
5773 of window: scroll_max can no longer be INT_MAX. When aggressive
5774 scrolling is in use, don't let point enter the opposite scroll
5775 margin as result of the scroll.
5776 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5777 threshold of 100 lines for never-recentering scrolling.
5778
e4cc2dfc
JB
57792011-03-31 Juanma Barranquero <lekktu@gmail.com>
5780
5781 * dispextern.h (move_it_by_lines):
5782 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5783 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5784 (message_log_check_duplicate): Remove parameters `prev_bol' and
5785 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5786 (redisplay_internal): Remove parameter `preserve_echo_area',
5787 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5788
5789 * indent.c (Fvertical_motion):
5790 * window.c (window_scroll_pixel_based, Frecenter):
5791 Don't pass `need_y_p' to `move_it_by_lines'.
5792
1c470562
SM
57932011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5794
44f230aa
SM
5795 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5796 steal a few bits to be more compact.
5797 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5798 Remove unneeded casts.
5799
1c470562
SM
5800 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5801
888adce9
ZK
58022011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5803
5804 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5805 binding" message (bug#7967).
5806
f838ed7b
PE
58072011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5808
77861b95
PE
5809 Fix more problems found by GCC 4.6.0's static checks.
5810
de6dbc14
PE
5811 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5812 Remove unused local var.
5813
f838ed7b
PE
5814 * editfns.c (Fmessage_box): Remove unused local var.
5815
792c7b2b
PE
5816 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5817 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5818 Omit unused local vars.
c499e557 5819 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5820 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5821 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5822 Omit unused local var.
5823
ba0165e1
PE
5824 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5825 Don't assume string length fits in int.
32ad8845 5826 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5827 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5828
3c59b4c9
PE
5829 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5830 instead of alloca (Bug#8344).
5831
a3eed478 5832 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5833 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5834
eb4d412d
PE
5835 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5836
1658b401
PE
5837 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5838 concerns.
5839
5840 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5841
5842 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5843
9a2c6e05
PE
5844 * keyboard.c (syms_of_keyboard): Use the same style as later
5845 in this function when indexing through an array. This also
5846 works around GCC bug 48267.
5847
03d0a109
PE
5848 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5849
44f730c8
PE
5850 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5851
fe75f926
PE
5852 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5853 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5854
ffa8c828
PE
5855 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5856 This avoids undefined behavior on integer overflow, and is a bit
5857 more convenient anyway since it is compared to a size_t variable.
5858
c5101a77
PE
5859 Variadic C functions now count arguments with size_t, not int.
5860 This avoids an unnecessary limitation on 64-bit machines, which
5861 caused (substring ...) to crash on large vectors (Bug#8344).
5862 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5863 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5864 All variadic functions and their callers changed accordingly.
c5101a77
PE
5865 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5866 * data.c (arith_driver, float_arith_driver): Likewise.
5867 * editfns.c (general_insert_function): Likewise.
5868 * eval.c (struct backtrace.nargs, interactive_p)
5869 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5870 (funcall_lambda, mark_backtrace): Likewise.
5871 * fns.c (concat): Likewise.
5872 * frame.c (x_set_frame_parameters): Likewise.
5873 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5874 0 if not found, not -1. All callers changed.
5875
dd3f25f7
PE
5876 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5877 (stack_copy_size): Now size_t, not int.
5878 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5879
461c2ab9
JB
58802011-03-28 Juanma Barranquero <lekktu@gmail.com>
5881
5882 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5883 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5884 All callers changed.
5885
5886 * lisp.h (multibyte_char_to_unibyte):
5887 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5888 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5889 * character.h (CHAR_TO_BYTE8):
5890 * cmds.c (internal_self_insert):
5891 * editfns.c (general_insert_function):
5892 * keymap.c (push_key_description):
5893 * search.c (Freplace_match):
5894 * xdisp.c (message_dolog, set_message_1): All callers changed.
5895
f6d62986
SM
58962011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5897
5898 * keyboard.c (safe_run_hook_funcall): New function.
5899 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5900 don't set the hook to nil, but remove the offending function instead.
5901 (Qcommand_hook_internal): Remove, unused.
5902 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5903 Vcommand_hook_internal.
5904
5905 * eval.c (enum run_hooks_condition): Remove.
5906 (funcall_nil, funcall_not): New functions.
5907 (run_hook_with_args): Call each function through a `funcall' argument.
5908 Remove `cond' argument, now redundant.
5909 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5910 (Frun_hook_with_args_until_failure): Adjust accordingly.
5911 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5912
1db5b1ad
JB
59132011-03-28 Juanma Barranquero <lekktu@gmail.com>
5914
5915 * dispextern.h (string_buffer_position): Remove declaration.
5916
5917 * print.c (strout): Remove parameter `multibyte', unused since
5918 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5919
5920 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5921 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5922 All callers changed.
5923
5924 * w32.c (_wsa_errlist): Use braces for struct initializers.
5925
5926 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5927 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5928 All callers changed.
5929 (string_buffer_position): Likewise. Also, make static (it's never
5930 used outside xdisp.c).
5931 (cursor_row_p): Remove parameter `w', unused since
5932 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5933 (decode_mode_spec): Remove parameter `precision', introduced during
5934 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5935 All callers changed.
5936
5ffb62aa
JD
59372011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5938
5939 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5940
461c2ab9 59412011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5942
5943 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5944 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5945 (ns_update_auto_hide_menu_bar): New functions.
5946 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5947 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5948 ns_constrain_all_frames.
5949 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5950 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5951
5c380ffb
JD
59522011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5953
5954 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5955
9af30bdf
GM
59562011-03-27 Glenn Morris <rgm@gnu.org>
5957
5958 * syssignal.h: Replace RETSIGTYPE with void.
5959 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5960 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5961 Replace SIGTYPE with void everywhere.
5962 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5963 * s/template.h (SIGTYPE): Remove commented out definition.
5964
e2abce01
JB
59652011-03-26 Eli Zaretskii <eliz@gnu.org>
5966
5967 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5968 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5969
f868cd8a
JB
59702011-03-26 Juanma Barranquero <lekktu@gmail.com>
5971
59eb0929
JB
5972 * w32.c (read_unc_volume): Use parameter `henum', instead of
5973 global variable `wget_enum_handle'.
5974
5975 * keymap.c (describe_vector): Remove parameters `indices' and
5976 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5977 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5978
f868cd8a
JB
5979 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5980
5981 * keyboard.c (timer_check): Remove parameter `do_it_now',
5982 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5983 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5984 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5985
5986 * keyboard.c (read_char):
5987 * w32menu.c (w32_menu_display_help):
5988 * xmenu.c (show_help_event, menu_help_callback):
5989 Adjust calls to `show_help_echo'.
5990
5991 * gtkutil.c (xg_maybe_add_timer):
5992 * keyboard.c (readable_events):
5993 * process.c (wait_reading_process_output):
5994 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5995
5996 * insdel.c (adjust_markers_gap_motion):
5997 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5998 (gap_left, gap_right): Don't call it.
5999
2ecf6fdb
CY
60002011-03-25 Chong Yidong <cyd@stupidchicken.com>
6001
6002 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6003 incurred during fontification.
6004
6b1f9ba4
JB
60052011-03-25 Juanma Barranquero <lekktu@gmail.com>
6006
6007 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6008 (DEFVAR_PER_BUFFER): Don't pass it.
6009
6010 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6011 (scrolling_window): Don't pass it.
6012
0f4a96b5
JB
60132011-03-25 Juanma Barranquero <lekktu@gmail.com>
6014
6015 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6016
6017 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6018 and `suffix'.
6019 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6020 of variables specific to SELinux and computation of `encoded_absname'.
6021
6022 * image.c (XPutPixel): Remove unused variable `height'.
6023
6024 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6025
6026 * unexw32.c (get_section_info): Remove unused variable `section'.
6027
6028 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6029 (system_process_attributes): Remove unused variable `sess'.
6030 (sys_read): Remove unused variable `err'.
6031
6032 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6033 (w32_wnd_proc): Remove unused variable `isdead'.
6034 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6035 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6036 (x_create_tip_frame): Remove unused variable `tem'.
6037
6038 * w32inevt.c (w32_console_read_socket):
6039 Remove unused variable `no_events'.
6040
6041 * w32term.c (x_draw_composite_glyph_string_foreground):
6042 Remove unused variable `width'.
6043
1149507c
JB
60442011-03-24 Juanma Barranquero <lekktu@gmail.com>
6045
6046 * w32term.c (x_set_glyph_string_clipping):
6047 Don't pass uninitialized region to CombineRgn.
6048
9c88f339
JB
60492011-03-23 Juanma Barranquero <lekktu@gmail.com>
6050
6051 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6052 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6053 (Fx_close_connection): Remove unused variable `i'.
6054
6055 * w32font.c (w32font_draw): Return number of glyphs.
6056 (w32font_open_internal): Remove unused variable `i'.
6057 (w32font_driver): Add missing initializer.
6058
6059 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6060 (fill_in_menu): Remove unused variable `items_added'.
6061
6062 * w32term.c (last_mouse_press_frame): Remove static global variable.
6063 (w32_clip_to_row): Remove unused variable `f'.
6064 (x_delete_terminal): Remove unused variable `i'.
6065
6066 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6067 (NOTHING): Remove unused static global variable.
6068 (uniscribe_check_otf): Remove unused variable `table'.
6069 (uniscribe_font_driver): Add missing initializers.
6070
dee091a3
JD
60712011-03-23 Julien Danjou <julien@danjou.info>
6072
6073 * term.c (Fsuspend_tty, Fresume_tty):
6074 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6075 * window.c (temp_output_buffer_show):
6076 * insdel.c (signal_before_change):
6077 * frame.c (Fhandle_switch_frame):
6078 * fileio.c (Fdo_auto_save):
6079 * emacs.c (Fkill_emacs):
6080 * editfns.c (save_excursion_restore):
6081 * cmds.c (internal_self_insert):
6082 * callint.c (Fcall_interactively):
6083 * buffer.c (Fkill_all_local_variables):
6084 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6085 Use Frun_hooks.
0f4a96b5 6086 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6087 unconditionnaly since it does the check itself.
6088
2c520ab5 60892011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6090
c9c49752
PE
6091 Fix more problems found by GCC 4.5.2's static checks.
6092
8abc3f12
PE
6093 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6094 the first time through the loop, since we know p0 < p1 then.
6095 This also avoids a gcc -Wstrict-overflow warning.
6096
a2d26660
PE
6097 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6098 leading to a memory leak, possible in functions like
6099 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6100 of objects (Bug#8318).
a2d26660 6101
916c72e9
PE
6102 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6103 that could (at least in theory) be that large.
6104
19ab8a18
PE
6105 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6106 This is less likely to overflow, and avoids undefined behavior if
6107 overflow does occur. All callers changed. Use strtoul to scan
6108 for the unsigned long integer.
b7cbbd6f
PE
6109 (pint2hrstr): Simplify and tune code slightly.
6110 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6111
f0641eff
PE
6112 * scroll.c (do_scrolling): Work around GCC bug 48228.
6113 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6114
7f650bb9
PE
6115 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6116 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6117 (validate_x_resource_name): Simplify count usage.
6118 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6119
37dd57d1
PE
6120 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6121 fail (Bug#8306).
81e56e61 6122
699979fc 6123 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6124
401bf9b4
PE
6125 * process.c (Fmake_network_process): Use socklen_t, not int,
6126 where POSIX says socklen_t is required in portable programs.
6127 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6128 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6129 (Fmake_network_process, server_accept_connection):
6130 (wait_reading_process_output, read_process_output):
6131 Likewise.
6132
b93aacde
PE
6133 * process.c: Rename or move locals to avoid shadowing.
6134 (list_processes_1, Fmake_network_process):
6135 (read_process_output_error_handler, exec_sentinel_error_handler):
6136 Rename or move locals.
4dc343ee 6137 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6138 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6139 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6140 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6141 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6142
af8a867c 6143 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6144 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6145 Include tparam.h instead, since it declares them.
af8a867c
PE
6146 * cm.h (PC): Remove extern decl; tparam.h now does this.
6147 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6148 * terminfo.c: Include tparam.h, to check interfaces.
6149 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6150 (tparam): Adjust signature to match interface in tparam.h;
6151 this removes some undefined behavior. Check that outstring and len
6152 are zero, which they always are with Emacs.
6153 * tparam.h (PC, BC, UP): New extern decls.
6154
0248044d 6155 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6156 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6157
8ff096c1 6158 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6159 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6160 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6161 (ftfont_list): Remove unused local.
49eaafba
PE
6162 (get_adstyle_property, ftfont_pattern_entity):
6163 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6164 Rename locals to avoid shadowing.
8ff096c1 6165
e2be39f6
PE
6166 * xfont.c (xfont_list_family): Mark var as initialized.
6167
c9735e30
PE
6168 * xml.c (make_dom): Now static.
6169
8f5201ae
PE
6170 * composite.c (composition_compute_stop_pos): Rename local to
6171 avoid shadowing.
b246f932
PE
6172 (composition_reseat_it): Remove unused locals.
6173 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6174 (composition_update_it): Mark var as initialized.
11b61122
PE
6175 (find_automatic_composition): Mark vars as initialized,
6176 with a FIXME (Bug#8290).
8f5201ae 6177
760fbc2c
PE
6178 character.h: Rename locals to avoid shadowing.
6179 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6180 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6181 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6182 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6183 to avoid shadowing.
6184
ff08eb85
PE
6185 * textprop.c (property_change_between_p): Remove; unused.
6186
fc7bf025
PE
6187 * intervals.c (interval_start_pos): Now static.
6188
235d7abc
PE
6189 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6190
44f230aa
SM
6191 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6192 Rename locals to avoid shadowing.
3e7d6594 6193
50060332
PE
6194 * sound.c (wav_play, au_play, Fplay_sound_internal):
6195 Fix pointer signedness.
d01f234b 6196 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6197 (wav_play): Initialize a variable to 0, to prevent undefined
6198 behavior (Bug#8278).
50060332 6199
c4fc4e30
PE
6200 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6201
918436ed
PE
6202 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6203
c939f91b
PE
6204 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6205 clobbering (Bug#8298).
b9c7f648
PE
6206 * sysdep.c (sys_subshell): Likewise.
6207 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6208
6bd8c144
PE
6209 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6210 This should get cleaned up, so that child_setup has the
6211 same signature on all platforms.
6212
7710357c 6213 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6214 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6215
c59da222
CY
62162011-03-22 Chong Yidong <cyd@stupidchicken.com>
6217
6218 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6219 not to be necessary, and produces flickering.
6220
66b87493
GM
62212011-03-20 Glenn Morris <rgm@gnu.org>
6222
6223 * config.in: Remove file.
6224
45b6f6d5
JB
62252011-03-20 Juanma Barranquero <lekktu@gmail.com>
6226
6227 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6228 are now in src/globals.h.
6229 (syms_of_minibuf): Remove spurious & from previous change.
6230
3ec03f7e
LL
62312011-03-20 Leo <sdl.web@gmail.com>
6232
6233 * minibuf.c (completing-read-function): New variable.
6234 (completing-read-default): Rename from completing-read.
6235 (completing-read): Call completing-read-function.
6236
b14e3e21
CY
62372011-03-19 Juanma Barranquero <lekktu@gmail.com>
6238
6239 * xfaces.c (Fx_load_color_file):
6240 Read color file from absolute filename (bug#8250).
6241
f2b726e6
JB
62422011-03-19 Juanma Barranquero <lekktu@gmail.com>
6243
6244 * makefile.w32-in: Update dependencies.
6245
09f6ff02
EZ
62462011-03-17 Eli Zaretskii <eliz@gnu.org>
6247
6248 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6249
29a6015a
PE
62502011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6251
a3a6c54e
PE
6252 Fix more problems found by GCC 4.5.2's static checks.
6253
b766f867
PE
6254 * process.c (make_serial_process_unwind, send_process_trap):
6255 (sigchld_handler): Now static.
6256
be02381c
PE
6257 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6258 That way, the code declares only the vars that it needs.
6259 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6260 * s/cygwin.h (PTY_ITERATION): Likewise.
6261 * s/darwin.h (PTY_ITERATION): Likewise.
6262 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6263
57048744
PE
6264 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6265 * process.c (allocate_pty): Don't declare stb unless it's needed.
6266
7914961c 6267 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6268 (CONSTANTLIM): Remove; unused.
6269 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6270 Define only if needed.
7914961c 6271
b3967b18
PE
6272 * unexelf.c (unexec): Name an expression,
6273 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6274 Use a different way to cause a compilation error if anyone uses
6275 n rather than nn, a way that does not involve shadowing.
73366a00 6276 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6277
29a6015a
PE
6278 * deps.mk (unexalpha.o): Remove; unused.
6279
43cfc33e 6280 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6281 * unexec.h: New file.
ce701a33
PE
6282 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6283 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6284 Depend on unexec.h.
6285 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6286 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6287 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6288 Change as necessary to match prototype in unexec.h.
ce701a33 6289
01f44d5a
PE
6290 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6291 shadowing.
4f63c6bb 6292 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6293
a6670b0b
PE
6294 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6295 Rename locals to avoid shadowing.
6296
cef2010d 6297 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6298 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6299
d4d7173a
PE
6300 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6301
f08b802a
PE
6302 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6303 warning when compiling print.c.
6304
3ddb0639
PE
6305 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6306 instead of using an uninitialized var.
5ad03b97 6307 (font_sort_entities): Mark var as initialized.
3ddb0639 6308
170a2692
PE
6309 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6310
e663c700
PE
6311 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6312 pointers to constants.
89bc529a 6313 (font_parse_fcname): Remove unused vars.
7b81e2d0 6314 (font_delete_unmatched): Now static.
ea838e10 6315 (font_get_spec): Remove; unused.
13a547c6
PE
6316 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6317 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6318 Rename or move locals to avoid shadowing.
e663c700 6319
2a80c887 6320 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6321 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6322
1384fa33 6323 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6324 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6325
8b2c52e9
PE
6326 * alloc.c (mark_backtrace): Move decl from here ...
6327 * lisp.h: ... to here, so that it can be checked.
6328
475545b5 6329 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6330 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6331 (lisp_indirect_variable): Name an expression,
6332 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6333 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6334
b1349114 6335 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6336 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6337 Use const pointer when appropriate.
b1349114 6338
a2928364
PE
6339 * lisp.h (get_system_name, get_operating_system_release):
6340 Move decls here, to check interfaces.
6341 * process.c (get_operating_system_release): Move decl to lisp.h.
6342 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6343 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6344 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6345 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6346 (Fformat_time_string, Fencode_time, Finsert_char):
6347 (Ftranslate_region_internal, Fformat):
6348 Rename or remove local vars to avoid shadowing.
9710023e 6349 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6350
a415e694
PE
6351 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6352 avoid shadowing.
6353
8ef4622d
PE
6354 * lisp.h (eassert): Check that the argument compiles, even if
6355 ENABLE_CHECKING is not defined.
6356
946f9a5b
PE
6357 * data.c (Findirect_variable): Name an expression, to avoid
6358 gcc -Wbad-function-cast warning.
112396d6 6359 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6360 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6361 (Fmake_variable_buffer_local, Fmake_local_variable):
6362 Mark variables as initialized.
52746918 6363 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6364
e5aab7e7 6365 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6366 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6367 Rename locals to avoid shadowing.
dff45157
PE
6368 (mark_stack): Move local variables into the #ifdef region where
6369 they're used.
7bc26fdb
PE
6370 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6371 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6372 needed otherwise.
6373 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6374 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6375 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6376
e5aab7e7
PE
6377 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6378 avoids undefined behavior in theory.
6379
4da60324
PE
6380 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6381
88043301
PE
6382 Use functions, not macros, for up- and down-casing (Bug#8254).
6383 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6384 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6385 to use the following functions instead of these macros.
6386 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6387 EMACS_INT, since callers assume the returned value fits in int.
6388 (upcase1): Likewise, for UPCASE_TABLE.
6389 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6390 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6391 the race-condition problem in the old DOWNCASE.
88043301 6392
19ed5445
PE
6393 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6394 Rename locals to avoid shadowing.
6395 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6396 (regex_compile, re_search_2, re_match_2_internal):
6397 Remove unused local vars.
952db0d7
PE
6398 (FREE_VAR): Rewrite so as not to use empty "else",
6399 which gcc can warn about.
da053e48 6400 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6401 (RETALLOC_IF): Define only if needed.
6402 (WORDCHAR_P): Likewise. This one is never needed, but is used
6403 only in a comment talking about a compiler bug, so put inside
6404 the #if 0 of that comment.
6405 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6406 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6407 Remove; unused.
19ed5445 6408
1f3561e4 6409 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6410 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6411 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6412
ded6f8f7
PE
6413 * search.c (simple_search): Remove unused var.
6414
dbd37a95
PE
6415 * dired.c (compile_pattern): Move decl from here ...
6416 * lisp.h: ... to here, so that it can be checked.
6417 (struct re_registers): New forward decl.
6418
7e47afad
PE
6419 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6420
85f24f61
PE
6421 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6422 All uses changed.
6423 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6424 Rename locals to avoid shadowing.
5671df8f 6425 (Fvertical_motion): Mark locals as initialized.
85f24f61 6426
181aa2be 6427 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6428 (casify_region): Mark local as initialized.
181aa2be 6429
930d429c
PE
6430 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6431
7082eac6
PE
6432 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6433 New macros, so that the caller can use some names other than
6434 gcpro1, gcpro2, etc.
6435 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6436 of the new macros.
6437 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6438 argument, for consistency with GCPRO2_VAR, etc: it is now the
6439 prefix of the variable, not the variable itself. All uses
6440 changed.
38b2c076
PE
6441 * dired.c (directory_files_internal, file_name_completion):
6442 Rename locals to avoid shadowing.
6443
15206ed9
PE
6444 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6445 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6446 dired.c's scmp function, had undefined behavior.
6447 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6448 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6449 * buffer.h: ... to here, because these macros use current_buffer,
6450 and the new implementation with inline functions needs to have
6451 current_buffer in scope now, rather than later when the macros
6452 are used.
6453 (downcase, upcase1): New static inline functions.
6454 (DOWNCASE, UPCASE1): Reimplement using these functions.
6455 This avoids undefined behavior in expressions like
6456 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6457 from race conditions in accessing the global variables
6458 case_temp1 and case_temp2.
6459 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6460 * lisp.h (case_temp1, case_temp2): Remove their decls.
6461 * character.h (ASCII_CHAR_P): Move from here ...
6462 * lisp.h: ... to here, so that the inline functions mentioned
6463 above can use them.
6464
4a6bea26
PE
6465 * dired.c (directory_files_internal_unwind): Now static.
6466
f14b7e14
PE
6467 * fileio.c (file_name_as_directory, directory_file_name):
6468 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6469 Now static.
2893f146
PE
6470 (file_name_as_directory): Use const pointers when appropriate.
6471 (Fexpand_file_name): Likewise. In particular, newdir might
6472 point at constant storage, so make it a const pointer.
fd4ead52 6473 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6474 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6475 signedness issues.
f839df0c
PE
6476 (Fset_file_times, Finsert_file_contents, auto_save_error):
6477 Rename locals to avoid shadowing.
f14b7e14 6478
5716756e 6479 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6480 (Ftry_completion, Fall_completions): Rename or remove locals
6481 to avoid shadowing.
5716756e 6482
b4c3046a
PE
6483 * marker.c (bytepos_to_charpos): Remove; unused.
6484
b45db522
PE
6485 * lisp.h (verify_bytepos, count_markers): New decls,
6486 so that gcc does not warn that these functions aren't declared.
6487
85876d07
PE
6488 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6489 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6490 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6491 (copy_text): Remove unused local var.
85876d07 6492
03d78a21 6493 * filelock.c (within_one_second): Now static.
b3dd38ab 6494 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6495
5df8f01b
PE
6496 * buffer.c (fix_overlays_before): Mark locals as initialized.
6497 (fix_start_end_in_overlays): Likewise. This function should be
6498 simplified by using pointers-to-pointers, but that's a different
6499 matter.
b1d876f1 6500 (switch_to_buffer_1): Now static.
8f54f30a
PE
6501 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6502 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6503
a70072c9 6504 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6505 Fix pointer signedness issue.
edced198
PE
6506 (sys_subshell): Mark local as volatile if checking for lint,
6507 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6508 (MAXPATHLEN): Define only if needed.
a70072c9 6509
a0977c44
PE
6510 * process.c (serial_open, serial_configure): Move decls from here ...
6511 * systty.h: ... to here, so that they can be checked.
6512
a884fdcc
PE
6513 * fns.c (get_random, seed_random): Move extern decls from here ...
6514 * lisp.h: ... to here, so that they can be checked.
6515
604efe86 6516 * sysdep.c (reset_io): Now static.
b8950c94 6517 (wait_for_termination_signal): Remove; unused.
604efe86 6518
38fc62d9
PE
6519 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6520 (copy_keymap_item, append_key, push_text_char_description):
6521 Now static.
1004a21a 6522 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6523 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6524 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6525 (describe_map_tree):
6526 Rename locals to avoid shadowing.
38fc62d9 6527
2f2650da
PE
6528 * keyboard.c: Declare functions static if they are not used elsewhere.
6529 (echo_char, echo_dash, cmd_error, top_level_2):
6530 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6531 (read_char, kbd_buffer_get_event, make_lispy_position):
6532 (make_lispy_event, make_lispy_movement, apply_modifiers):
6533 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6534 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6535 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6536 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6537 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6538
a053e86c 6539 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6540 (mark_kboards): Move decl here ...
6541 * alloc.c (mark_kboards): ... from here.
a053e86c 6542
4752793e
PE
6543 * lisp.h (force_auto_save_soon): New decl.
6544
74f10ca7 6545 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6546 (DEFINE_DUMMY_FUNCTION): New macro.
6547 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6548 Use it.
c03cd23f
PE
6549 (main): Add casts to avoid warnings
6550 if GCC considers string literals to be constants.
74f10ca7 6551
022e70d4
PE
6552 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6553
59d6fe83
PE
6554 * dbusbind.c: Pointer signedness fixes.
6555 (xd_signature, xd_append_arg, xd_initialize):
6556 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6557 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6558 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6559 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6560
78320123
PE
6561 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6562 if GCC considers string literals to be constants.
49cebcca 6563 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6564
35ac2a97
SM
65652011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6566
fb103ca9
SM
6567 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6568 (print_preprocess, print_object): New macro to fix last change.
6569
35ac2a97
SM
6570 * print.c (print_preprocess): Don't forget font objects.
6571
62973b41
JB
65722011-03-16 Juanma Barranquero <lekktu@gmail.com>
6573
6574 * emacs.c (USAGE3): Doc fixes.
6575
0e48bb22
AS
65762011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6577
6578 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6579 structure.
6580
7684e57b
JB
65812011-03-14 Juanma Barranquero <lekktu@gmail.com>
6582
6583 * lisp.h (VWindow_system, Qfile_name_history):
6584 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6585 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6586 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6587
6588 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6589 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6590
6591 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6592 * w32console.c (detect_input_pending, read_input_pending)
6593 (encode_terminal_code):
6594 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6595 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6596 (w32_system_caret_y, Qfile_name_history):
6597 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6598 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6599 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6600 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6601 * w32proc.c (Qlocal, report_file_error):
6602 * w32term.c (Vwindow_system, updating_frame):
6603 * w32uniscribe.c (initialized, uniscribe_font_driver):
6604 Remove unneeded extern declarations.
6605
2aa46d6c
CY
66062011-03-14 Chong Yidong <cyd@stupidchicken.com>
6607
c96bbc66 6608 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6609
cffc6f3b
CY
66102011-03-13 Chong Yidong <cyd@stupidchicken.com>
6611
6612 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6613 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6614 These macros can no longer be used for assignment.
6615
44f230aa
SM
6616 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6617 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6618 (record_buffer_markers, fetch_buffer_markers): New functions for
6619 recording and fetching special buffer markers.
6620 (set_buffer_internal_1, set_buffer_temp): Use them.
6621
6622 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6623
6624 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6625
6626 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6627 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6628
6629 * xdisp.c (hscroll_window_tree):
6630 (reconsider_clip_changes): Use PT instead of BUF_PT.
6631
d251f04b
EZ
66322011-03-13 Eli Zaretskii <eliz@gnu.org>
6633
6634 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6635 $(EMACS_ROOT)/lib/intprops.h.
6636
f0c77cd1
PE
66372011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6638
3eca4629
PE
6639 Fix more problems found by GCC 4.5.2's static checks.
6640
7c86ee98
PE
6641 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6642 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6643 (xg_free_frame_widgets): Make it clear that a local variable is
6644 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6645 (gdk_window_get_screen): Make it clear that this macro is needed
6646 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6647 (int_gtk_range_get_value): New function, which avoids a diagnostic
6648 from gcc -Wbad-function-cast.
6649 (xg_set_toolkit_scroll_bar_thumb): Use it.
6650 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6651 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6652 (get_utf8_string, xg_get_file_with_chooser):
6653 Rename locals to avoid shadowing.
6654 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6655
41729b81
PE
6656 * xgselect.c (xg_select): Remove unused var.
6657
f0c77cd1
PE
6658 * image.c (four_corners_best): Mark locals as initialized.
6659 (gif_load): Initialize transparent_p to zero (Bug#8238).
6660 Mark another local as initialized.
ec6cf4c6 6661 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6662
ce0ad53d 6663 * image.c (clear_image_cache): Now static.
d5d5a617 6664 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6665 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6666 (x_edge_detection): Remove unnecessary cast that
6667 gcc -Wbad-function-cast diagnoses.
2037898d 6668 (gif_load): Fix pointer signedness.
6ae141d6
PE
6669 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6670 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6671
33383987 66722011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6673
d32df629
PE
6674 Improve quality of tests for time stamp overflow.
6675 For example, without this patch (encode-time 0 0 0 1 1
6676 1152921504606846976) returns the obviously-bogus value (-948597
6677 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6678 reports time overflow. See
6679 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6680 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6681 * editfns.c: Include limits.h and intprops.h.
6682 (TIME_T_MIN, TIME_T_MAX): New macros.
6683 (time_overflow): Move earlier, to before first use.
6684 (hi_time, lo_time): New functions, for an accurate test for
6685 out-of-range times.
6686 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6687 (Fget_internal_run_time): Don't assume time_t fits in int.
6688 (make_time): Use list2 instead of Fcons twice.
6689 (Fdecode_time): More accurate test for out-of-range times.
6690 (check_tm_member): New function.
6691 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6692 (lisp_time_argument): Don't rely on undefined left-shift and
6693 right-shift behavior when checking for time stamp overflow.
8be6f318 6694
fe31d94c
PE
6695 * editfns.c (time_overflow): New function, refactoring common code.
6696 (Fformat_time_string, Fdecode_time, Fencode_time):
6697 (Fcurrent_time_string): Use it.
6698
8be6f318
PE
6699 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6700 * dired.c (make_time): Move to ...
6701 * editfns.c (make_time): ... here.
6702 * systime.h: Note the move.
6703
09d9db2c 67042011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6705
126bc0dc
YM
6706 * fringe.c (update_window_fringes): Remove unused variables.
6707
c47cbdfd
YM
6708 * unexmacosx.c (copy_data_segment): Also copy __got section.
6709 (Bug#8223)
6710
7ac80be9
EZ
67112011-03-12 Eli Zaretskii <eliz@gnu.org>
6712
c96bbc66 6713 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6714 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6715 Constify `char *' arguments and their references according to
6716 prototypes in tparam.h.
6717
ecb0f94d 6718 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6719
7ac80be9
EZ
6720 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6721 Adapt all references accordingly.
6722
6723 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6724
ef1fd07e
TT
67252011-03-11 Tom Tromey <tromey@redhat.com>
6726
6727 * buffer.c (syms_of_buffer): Remove obsolete comment.
6728
7ef4b50c
EZ
67292011-03-11 Eli Zaretskii <eliz@gnu.org>
6730
6731 * termhooks.h (encode_terminal_code): Declare prototype.
6732
6733 * msdos.c (encode_terminal_code): Don't declare prototype.
6734
6735 * term.c (encode_terminal_code): Now external again, used by
6736 w32console.c and msdos.c.
6737
44f230aa
SM
6738 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6739 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6740
4b1ec863 67412011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6742
1714f52b 6743 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6744
4b1ec863
PE
6745 * fringe.c (update_window_fringes): Mark locals as initialized
6746 (Bug#8227).
6747 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6748
524c7aa6
PE
6749 * alloc.c (mark_fringe_data): Move decl from here ...
6750 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6751 to check its interface.
6752 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6753
a5c0af81 6754 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6755 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6756 (fontset_font): Mark local as initialized.
a9a06e0b 6757 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6758
b4716021
PE
6759 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6760
811e9bac 6761 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6762 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6763 (x_own_selection, Fx_disown_selection_internal): Rename locals
6764 to avoid shadowing.
6765 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6766
7e3ab302
PE
6767 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6768 so that the caller can use some name other than gcpro1.
6769 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6770 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6771 (Fx_backspace_delete_keys_p):
6772 Use them to avoid shadowing, and rename vars to avoid shadowing.
6773 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6774 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6775 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6776 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6777 Remove unused locals.
7e3ab302
PE
6778 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6779 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6780 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6781 macros.
f78faa98 6782
e2b13473
PE
6783 * xterm.h (x_mouse_leave): New decl.
6784
77f23912
PE
6785 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6786 Remove unused functions.
cdf4ba58
PE
6787 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6788 (x_calc_absolute_position): Now static.
7411c686 6789 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6790 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6791 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6792 unless they are used.
38d0b34a
PE
6793 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6794 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6795 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6796 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6797 (x_error_catcher, x_connection_closed, x_error_handler):
6798 (x_error_quitter, xembed_send_message, x_iconify_frame):
6799 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6800 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6801 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6802
44f230aa
SM
6803 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6804 Rename or move locals to avoid shadowing.
6b463e58 6805 (tty_defined_color, merge_face_heights): Now static.
5967d051 6806 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6807 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6808 does not deduce is never used uninitialized.
73719eba
PE
6809 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6810 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6811
426994c3 6812 * terminal.c (store_terminal_param): Now static.
5489860b 6813
032f1620 6814 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6815 (set_frame_menubar): Remove unused local.
d4323972 6816 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6817 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6818 since they might point to immutable storage.
281585b0
PE
6819 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6820 since it's unused otherwise.
032f1620 6821
367c19e5 6822 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6823 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6824 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6825 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6826 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6827 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6828 does not deduce are never used uninitialized.
70739cbe 6829
07b48fa9
PE
6830 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6831
8868a238 6832 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6833 * window.c (window_loop, size_window):
6834 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6835
7e5cf297 6836 * window.c (display_buffer): Now static.
d6550a9f
PE
6837 (size_window): Mark variables that gcc -Wuninitialized
6838 does not deduce are never used uninitialized.
a586633d
PE
6839 * window.h (check_all_windows): New decl, to forestall
6840 gcc -Wmissing-prototypes diagnostic.
5b555da1 6841 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6842
f6095868
PE
6843 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6844 shadowing.
6845 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6846 Include <limits.h>.
6847 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6848 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6849 (load_charset_map): Mark variables that gcc -Wuninitialized
6850 does not deduce are never used uninitialized.
53df7c11 6851 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6852
f38b440c
PE
6853 * coding.c (coding_set_source, coding_set_destination):
6854 Use "else { /* comment */ }" rather than "else /* comment */;"
6855 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6856 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6857 a block, when the outer 'i' will do.
6858 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6859 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6860 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6861 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6862 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6863 Rename locals to avoid shadowing.
6864 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6865 * coding.c (emacs_mule_char, encode_invocation_designation):
6866 Now static, since they're not used elsewhere.
413bb2db 6867 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6868 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6869 (decode_coding_emacs_mule): Mark variables that gcc
6870 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6871 (detect_coding_iso_2022): Initialize a local variable that might
6872 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6873 this initialization is needed. (Bug#8211)
5f58e762
PE
6874 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6875 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6876 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6877 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6878 Remove unused macros.
f38b440c 6879
232b38b9 6880 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6881 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6882 * character.c (string_count_byte8): Likewise.
232b38b9 6883
fb90da1b
PE
6884 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6885 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6886
fb93dbc2
PE
6887 * chartab.c (copy_sub_char_table): Now static, since it's not used
6888 elsewhere.
5c156ace
PE
6889 (sub_char_table_ref_and_range, char_table_ref_and_range):
6890 Rename locals to avoid shadowing.
bbcd0949 6891 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6892
7d3b3862 6893 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6894 (BIDI_BOB): Remove unused macro.
7d3b3862 6895
6be7d3da
PE
6896 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6897 deduce are never used uninitialized.
c2ed9c8b 6898 * term.c (encode_terminal_code): Likewise.
6be7d3da 6899
75f8807f 6900 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6901
50938595
PE
6902 * tparam.h: New file.
6903 * term.c, tparam.h: Include it.
6904 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6905 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6906 Move these decls to tparam.h, and make them agree with what
6907 is actually in tparam.c. The previous trick of using incompatible
6908 decls in different modules does not conform to the C standard.
6909 All callers of tparam changed to use tparam's actual API.
6910 * tparam.c (tparam1, tparam, tgoto):
6911 Use const pointers where appropriate.
6912
fbceeba2
PE
6913 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6914 * cm.h (struct cm): Likewise.
6915 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6916 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6917 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6918 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6919 (turn_on_face, init_tty): Likewise.
6920 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6921
7f3f1250
PE
6922 * term.c (term_mouse_position): Rename local to avoid shadowing.
6923
e6ca6543
PE
6924 * alloc.c (mark_ttys): Move decl from here ...
6925 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6926
c40f8d15
AS
69272011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6928
6929 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6930
cfe0661d
JB
69312011-03-09 Juanma Barranquero <lekktu@gmail.com>
6932
6933 * search.c (compile_pattern_1): Remove argument regp, unused since
6934 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6935 (compile_pattern): Don't pass it.
6936
0afb4571
J
69372011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6938
6939 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6940 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6941 for ! HAVE_GTK3.
6942 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6943
6944 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6945
6946 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6947 gdk_window_get_screen, gdk_window_get_geometry,
6948 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6949 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6950 (xg_get_pixbuf_from_pixmap): New function.
6951 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6952 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6953 Call xg_get_pixbuf_from_pixmap instead of
6954 gdk_pixbuf_get_from_drawable.
6955 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6956 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6957 (xg_check_special_colors): Use GtkStyleContext and its functions
6958 for HAVE_GTK3.
6959 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6960 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6961 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6962 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6963 Call gtk_widget_get_preferred_size.
0afb4571
J
6964 (xg_frame_resized): gdk_window_get_geometry only takes 5
6965 parameters.
44f230aa
SM
6966 (xg_win_to_widget, xg_event_is_for_menubar):
6967 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6968 (xg_set_widget_bg): New function.
6969 (delete_cb): New function.
895009e1 6970 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6971 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6972 (xg_set_background_color): Call xg_set_widget_bg.
6973 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6974 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6975 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6976 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6977 if ! HAVE_GTK3.
6978 (update_frame_tool_bar): Call gtk_widget_hide.
6979 (xg_initialize): Use GDK_KEY_g.
6980
6981 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6982 if ! HAVE_GTK3
6983 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6984
6985 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6986 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6987 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6988
1c2cc4ef
JB
69892011-03-08 Juanma Barranquero <lekktu@gmail.com>
6990
6991 * w32xfns.c (select_palette): Check success of RealizePalette against
6992 GDI_ERROR, not zero.
6993
33383987 6994See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6995
6996;; Local Variables:
6997;; coding: utf-8
aac0c6e3
MR
6998;; End:
6999
33383987 7000 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7001
7002 This file is part of GNU Emacs.
7003
7004 GNU Emacs is free software: you can redistribute it and/or modify
7005 it under the terms of the GNU General Public License as published by
7006 the Free Software Foundation, either version 3 of the License, or
7007 (at your option) any later version.
7008
7009 GNU Emacs is distributed in the hope that it will be useful,
7010 but WITHOUT ANY WARRANTY; without even the implied warranty of
7011 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7012 GNU General Public License for more details.
7013
7014 You should have received a copy of the GNU General Public License
7015 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.