Handle `(space ...)' display spec as paragraph separator.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0c95fcf7
EZ
12011-08-25 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4 the display spec is of the form `(space ...)'.
5 (handle_display_spec): Return the value returned by
6 handle_single_display_spec, not just 1 or zero.
7 (handle_single_display_spec): If the display spec is of the form
8 `(space ...)', and specifies display in the text area, return 2
9 rather than 1.
10
11 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
12 into disp_prop; all users changed.
13
14 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
15 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
16 for the text covered by the display property.
17
e4ed06f1
CY
182011-08-25 Chong Yidong <cyd@stupidchicken.com>
19
20 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
21 Change return value to nil.
22 (Frecord_buffer): Delete unused function.
23
f67cdd7f
EZ
242011-08-24 Eli Zaretskii <eliz@gnu.org>
25
5980d4c6
EZ
26 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
27 buffers, return left-to-right.
8610fe8b
EZ
28 (set_cursor_from_row): Consider candidate row a win if its glyph
29 represents a newline and point is on that newline. Fixes cursor
30 positioning on the newline at EOL of R2L text within L2R
31 paragraph, and vice versa.
32 (try_cursor_movement): Check continued rows, in addition to
33 continuation rows. Fixes unwarranted scroll when point enters a
34 continued line of R2L text within an L2R paragraph, or vice versa.
35 (cursor_row_p): Consider the case of point being equal to
36 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
37 from the end of a short line to the beginning of a continued line
38 of R2L text within L2R paragraph.
39 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
40 composed characters.
5980d4c6 41
f67cdd7f
EZ
42 * bidi.c (bidi_check_type): Use xassert.
43 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
44 members.
45
bca633fb
EZ
462011-08-23 Eli Zaretskii <eliz@gnu.org>
47
48 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
49 a character.
50
4a5885a7
CY
512011-08-23 Chong Yidong <cyd@stupidchicken.com>
52
53 * nsfont.m (ns_otf_to_script): Fix typo.
54
0902a04e
KH
552011-08-22 Kenichi Handa <handa@m17n.org>
56
57 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
58 extra slot even if the purpose is char-code-property-table.
59
1a2e6670
EZ
602011-08-23 Eli Zaretskii <eliz@gnu.org>
61
8ddde651
EZ
62 * xdisp.c (redisplay_window): When computing centering_position,
63 account for the height of the header line. (Bug#8874)
64
425cc014
EZ
65 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
66 instead of CHAR_TO_BYTE. Fixes a crash when a completion
67 candidate is selected by the mouse, and that candidate has a
68 composed character under the mouse.
69
1a2e6670
EZ
70 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
71 coordinates reported by pos-visible-in-window-p for a composed
72 character in column zero.
73
8b76d6f8
SM
742011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
75
76 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
77
dac347dd
EZ
782011-08-22 Eli Zaretskii <eliz@gnu.org>
79
80 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
81 consider it a hit if to_charpos is anywhere in the range of the
82 composed buffer positions.
83
e013fb34
CY
842011-08-22 Chong Yidong <cyd@stupidchicken.com>
85
86 * image.c (gif_load): Don't assume that each subimage has the same
87 dimensions as the base image. Handle disposal method that is
88 "undefined" by the gif spec (Bug#9335).
89
bd1ba3e8
CY
902011-08-20 Chong Yidong <cyd@stupidchicken.com>
91
92 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 93 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 94
54a1215b
EZ
952011-08-19 Eli Zaretskii <eliz@gnu.org>
96
823564e5
EZ
97 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
98 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
99 from an Org mode buffer to a Speedbar frame.
100
54a1215b
EZ
101 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
102 a composition, take its buffer position from IT->cmp_it.charpos.
103 Fixes cursor positioning at the beginning of a line that begins
104 with a composed character.
105
9778ebcc
EZ
1062011-08-18 Eli Zaretskii <eliz@gnu.org>
107
0be6ee06
EZ
108 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
109 character bidirectional type, use STRONG_L instead. Fixes crashes
110 in a buffer produced by `describe-categories'.
111
9778ebcc
EZ
112 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
113 members before the level stack, so they would be saved and
114 restored when copying iterator state. Fixes incorrect reordering
115 around TABs covered by display properties.
116
156bffbe
AS
1172011-08-18 Andreas Schwab <schwab@linux-m68k.org>
118
119 * process.c (Fnetwork_interface_list): Correctly determine buffer
120 size.
121
72ad093b
CY
1222011-08-17 Chong Yidong <cyd@stupidchicken.com>
123
124 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
125 (internal_condition_case_2, internal_condition_case_n):
126 Remove unnecessary aborts (Bug#9081).
72ad093b 127
35774242
EZ
1282011-08-17 Eli Zaretskii <eliz@gnu.org>
129
130 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
131 has no `load' handler, try opening the file locally. (Bug#9311)
132
db76dd85
KB
1332011-08-16 Ken Brown <kbrown@cornell.edu>
134
135 * gmalloc.c: Expand comment.
136
b215eee5
EZ
1372011-08-16 Eli Zaretskii <eliz@gnu.org>
138
139 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
140 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
141
a4579d33
KB
1422011-08-16 Ken Brown <kbrown@cornell.edu>
143
144 Fix memory allocation problems in Cygwin build (Bug#9273).
145
146 * unexcw.c ( __malloc_initialized): Declare external variable.
147 (fixup_executable): Force the dumped emacs to reinitialize malloc.
148
8b76d6f8
SM
149 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
150 New variables.
a4579d33
KB
151 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
152 dumped emacs.
153 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
154 in the static heap.
155 [CYGWIN] (special_realloc): New function.
156 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
157 requests to realloc storage in the static heap.
158
3ebec551
PE
1592011-08-15 Paul Eggert <eggert@cs.ucla.edu>
160
161 * bidi.c (bidi_initialize): Remove unused local.
162
9fd8be00
EZ
1632011-08-15 Eli Zaretskii <eliz@gnu.org>
164
474a8465
EZ
165 * biditype.h: File removed.
166
167 * bidimirror.h: File removed.
168
169 * deps.mk (bidi.o): Remove biditype.h and
170 bidimirror.h.
171
172 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
173 bidimirror.h.
174
175 * dispextern.h: Fix a typo in the comment to bidi_type_t.
176
177 * chartab.c: Improve commentary for the uniprop_table API.
178
32413314
EZ
179 * bidi.c (bidi_paragraph_init): Support zero value of
180 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
181 (bidi_initialize): Use uniprop_table instead of including
182 biditype.h and bidimirror.h.
32413314 183
9fd8be00
EZ
184 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
185 coordinates of the iterator when restoring from ppos_it.
186 (Bug#9296)
187
5cf2b69b
KH
1882011-08-14 Kenichi Handa <handa@m17n.org>
189
190 * process.c (create_process): Call setup_process_coding_systems
72ad093b 191 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 192
daf17d00
EZ
1932011-08-14 Eli Zaretskii <eliz@gnu.org>
194
195 * xdisp.c (move_it_in_display_line_to): Don't invoke
196 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
197 ppos_it. Fixes vertical cursor motion when line beginning is
198 covered by an image. (Bug#9296)
199
08e3161a
JD
2002011-08-14 Jan Djärv <jan.h.d@swipnet.se>
201
202 * nsterm.h (ns_run_ascript): Declare.
203 (NSAPP_DATA2_RUNASSCRIPT): Define.
204
205 * nsfns.m (as_script, as_result, as_status): New static variables.
206 (ns_run_ascript): New function.
207 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
208 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
209 the event loop. Get status from as_status (Bug#7276).
210
211 * nsterm.m (sendEvent): If event is NSApplicationDefined and
212 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
213 the event loop (Bug#7276).
214
a3720aa2
AS
2152011-08-14 Andreas Schwab <schwab@linux-m68k.org>
216
217 * gnutls.c (QCgnutls_bootprop_priority)
218 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
219 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
220 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
221 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
222 (QCgnutls_bootprop_verify_hostname_error)
223 (QCgnutls_bootprop_callbacks_verify): Rename from
224 Qgnutls_bootprop_..., all uses changed.
225
226 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
227 uses changed.
228
0a0d27fb
PE
2292011-08-14 Paul Eggert <eggert@cs.ucla.edu>
230
19d5c50c
PE
231 * xfaces.c (Qframe_set_background_mode): Now static.
232 * dispextern.h (Qframe_set_background_mode): Remove decl.
233
0a0d27fb
PE
234 * process.c (Fnetwork_interface_info): Declare local only if needed.
235
377538cb
JD
2362011-08-13 Jan Djärv <jan.h.d@swipnet.se>
237
238 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
239 (Fnetwork_interface_list): Allocate in increments of bytes instead
240 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
241 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
242 sockaddr.
243 (struct ifflag_def): notrailers is smart on OSX.
244 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
245 Get hardware address with getifaddrs if available.
246
08fff70c
EZ
2472011-08-12 Eli Zaretskii <eliz@gnu.org>
248
249 * xdisp.c (iterate_out_of_display_property): xassert that
250 IT->position is set to within IT->object's boundaries. Break from
251 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
252 when IT->position is set up wrongly due to some bug.
253 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
254 (push_display_prop): Allow GET_FROM_STRING as IT->method on
255 entry. Force push_it to save on the stack the current
256 buffer/string position, to be restored by pop_it. Fix flags in
257 the iterator structure wrt the object coming from a display
258 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
259 properties. (Bug#9284)
260
7be1c708 2612011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 262
7be1c708
CY
263 * fontset.c (fontset_get_font_group): Add proper type checks.
264 (Bug#9172)
aac0c6e3 265
7be1c708 2662011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 267
7be1c708
CY
268 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
269 and LC_VERSION_MIN_MACOSX.
270 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
271 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 272
97bb72a6
EZ
2732011-08-08 Eli Zaretskii <eliz@gnu.org>
274
275 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
276 no-display-properties-and-no-overlays under bidi display.
277 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 278 properties and overlays.
97bb72a6 279
d5617611
CY
2802011-08-08 Chong Yidong <cyd@stupidchicken.com>
281
37e11a63
CY
282 * editfns.c (Fset_time_zone_rule): Document relationship with the
283 setenv function.
284
d5617611
CY
285 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
286 the font entity extracted from the cache (Bug#8109).
287
58872834
CY
2882011-08-07 Chong Yidong <cyd@stupidchicken.com>
289
290 * composite.c (autocmp_chars): Don't reset point. That is done by
291 restore_point_unwind (Bug#5984).
292
75bfc667
JL
2932011-08-07 Juri Linkov <juri@jurta.org>
294
295 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
296 to show the arg `TIME' instead of `TIMEVAL'.
297
d1410150
EZ
2982011-08-06 Eli Zaretskii <eliz@gnu.org>
299
300 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
301 display property strides EOL and includes a newline, as in
302 longlines-mode. (Bug#9254)
75b771e4
EZ
303 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
304 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
305
306 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
307 is non-zero, even if the data buffer is NULL. Fixes a crash in
308 vertical-motion with longlines-mode. (Bug#9254)
309
35928349
EZ
3102011-08-05 Eli Zaretskii <eliz@gnu.org>
311
ec7cc85b
EZ
312 * bidi.c <bidi_cache_total_alloc>: Now static.
313 (bidi_initialize): Initialize bidi_cache_total_alloc.
314
8b76d6f8 315 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
316 cache. (Bug#9221)
317
318 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
319 amount allocated this far in `bidi_cache_total_alloc'.
320 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
321 non-zero, only free the data buffer without restoring the cache
322 contents. All callers changed.
323
324 * dispextern.h (bidi_unshelve_cache): Update prototype.
325
326 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
327 (move_it_in_display_line, move_it_to)
328 (move_it_vertically_backward, move_it_by_lines): Replace the call
329 to xfree to an equivalent call to bidi_unshelve_cache.
330 (move_it_in_display_line_to): Fix logic of returning
412b6358 331 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 332
e2e2423b
EZ
3332011-08-05 Eli Zaretskii <eliz@gnu.org>
334
335 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
336 came from a string character with a `cursor' property. (Bug#9229)
337
ae9e757a
JD
3382011-08-04 Jan Djärv <jan.h.d@swipnet.se>
339
340 * Makefile.in (LIB_PTHREAD): New variable.
341 (LIBES): Add LIB_PTHREAD (Bug#9216).
342
343 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
344 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
345
213bd7f2
AS
3462011-08-04 Andreas Schwab <schwab@linux-m68k.org>
347
348 * regex.c (re_iswctype): Remove some redundant boolean
349 conversions.
350
99aaf75f
JD
3512011-08-04 Jan Djärv <jan.h.d@swipnet.se>
352
353 * xterm.c (x_find_topmost_parent): New function.
354 (x_set_frame_alpha): Find topmost parent window with
355 x_find_topmost_parent and set the property there also (bug#9181).
356 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
357
c74e9d86
PE
3582011-08-04 Paul Eggert <eggert@cs.ucla.edu>
359
360 * callproc.c (Fcall_process): Avoid vfork clobbering
361 the local vars buffer, coding_systems, current_dir.
362
640c8776
SM
3632011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
364
365 * keymap.c (Fmake_composed_keymap): Move to subr.el.
366
f26d0e4c
PE
3672011-08-03 Paul Eggert <eggert@cs.ucla.edu>
368
8a10d76c
PE
369 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
370 so that it is not optimized away.
371
f26d0e4c
PE
372 * xdisp.c (compute_display_string_pos): Remove unused local.
373
55439c61
EZ
3742011-08-02 Eli Zaretskii <eliz@gnu.org>
375
376 Fix slow cursor motion and scrolling in large buffers with
377 selective display, like Org Mode buffers. (Bug#9218)
378
379 * dispextern.h (struct bidi_it): New member disp_prop_p.
380
381 * xdisp.c: Remove one-slot cache of display string positions.
382 (compute_display_string_pos): Accept an additional argument
383 DISP_PROP_P; callers changed. Scan at most 5K characters forward
384 for a display string or property. If found, set DISP_PROP_P
385 non-zero.
386
387 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
388 DISP_PROP_P, and pass it to compute_display_string_pos.
389 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
390 non-zero. All callers of bidi_fetch_char changed.
391
fb33fa43
SM
3922011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
393
394 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
395
b099e063
DM
3962010-12-03 Don March <don@ohspite.net>
397
398 * keymap.c (Fdefine_key): Fix non-prefix key error message when
399 last character M-[char] is translated to ESC [char] (bug#7541).
400
5cc7f7af
KH
4012011-08-02 Kenichi Handa <handa@m17n.org>
402
d0fffa3f 403 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
404
405 * chartab.c (uniprop_table): Make it non-static.
406
525d5e6e
EZ
4072011-08-01 Eli Zaretskii <eliz@gnu.org>
408
409 * xdisp.c (forward_to_next_line_start): Accept additional argument
410 BIDI_IT_PREV, and store into it the state of the bidi iterator had
411 on the newline.
412 (reseat_at_next_visible_line_start): Use the bidi iterator state
413 returned by forward_to_next_line_start to restore the state of
414 it->bidi_it after backing up to previous newline. (Bug#9212)
415
31011111
AS
4162011-07-30 Andreas Schwab <schwab@linux-m68k.org>
417
418 * regex.c (re_comp): Protoize.
419 (re_exec): Fix return type.
420 (regexec): Fix type of `ret'. (Bug#9203)
421
e5d76069
PE
4222011-07-29 Paul Eggert <eggert@cs.ucla.edu>
423
424 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
425 This is needed if max-image-size is a floating-point number.
426
9a79b20c
AS
4272011-07-28 Andreas Schwab <schwab@linux-m68k.org>
428
429 * print.c (print_object): Print empty symbol as ##.
430
431 * lread.c (read1): Read ## as empty symbol.
432
d8c2fa78
AA
4332011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
434
435 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
436 setting frame foreground color (Bug#9175).
437 (x_set_background_color): Likewise.
438
ffe57a7a
AA
439 * nsmenu.m (-setText): Size tooltip dimensions precisely to
440 contents (Bug#9176).
441 (EmacsTooltip -init): Remove bezels and add shadows to
442 tooltip windows.
443
bf3492a5
AA
444 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
445 or scroll bar (Bug#8470).
446
d55e9c53
AA
447 * nsfont.m (nsfont_open): Remove assignment to voffset and
448 unnecessary vars hshink, expand, hd, full_height, min_height.
449 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
450
451 * nsterm.h (nsfont_info): Remove voffset field.
452
d8c2fa78 4532011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
454
455 Implement strike-through and overline on NextStep (Bug#8863).
456
457 * nsfont.m (nsfont_open): Use underline position provided by font,
458 instead of hard-coded value of 2.
459 (nsfont_draw): Call ns_draw_text_decoration instead.
460
461 * nsterm.h: Add declaration for ns_draw_text_decoration.
462
463 * nsterm.m (ns_draw_text_decoration): New function for drawing
464 underline, overline, and strike-through.
465 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
466 ns_draw_text_decoration. Change treatment of cursor drawing to
467 accomodate underlining, etc.
468
4cc60b9b
EZ
4692011-07-28 Eli Zaretskii <eliz@gnu.org>
470
bc7ece87
EZ
471 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
472 default.
4cc60b9b 473
476371c4
PE
4742011-07-28 Paul Eggert <eggert@cs.ucla.edu>
475
66606eea
PE
476 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
477 Without this fix, if a signal arrives just after memory fills up,
478 'malloc' might be invoked reentrantly.
479
476371c4
PE
480 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
481 In other words, assume that every image size is allowed, on non-X
482 hosts. This assumption is probably wrong, but it lets Emacs compile.
483
f3fcc40d
AS
4842011-07-28 Andreas Schwab <schwab@linux-m68k.org>
485
486 * regex.c (re_iswctype): Convert return values to boolean.
487
350c992f
EZ
4882011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
489
490 * xdisp.c (compute_display_string_pos): Don't use cached display
491 string position if the buffer had its restriction changed.
492 (Bug#9184)
493
5266b4bb
PE
4942011-07-28 Paul Eggert <eggert@cs.ucla.edu>
495
496 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
497
2573a837 4982011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 499
41f55ccd 500 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 501
39e378da
PE
502 * bidi.c: Integer size and overflow fixes.
503 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
504 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
505 (bidi_cache_find_level_change, bidi_cache_ensure_space)
506 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
507 (bidi_find_other_level_edge):
508 Use ptrdiff_t instead of EMACS_INT where either will do.
509 This works better on 32-bit hosts configured --with-wide-int.
510 (bidi_cache_ensure_space): Check for size-calculation overflow.
511 Use % rather than repeated addition, for better worst-case speed.
512 Don't set bidi_cache_size until after xrealloc returns, because it
513 might not return.
514 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
515 (bidi_cache_ensure_space): Also check that the bidi cache size
516 does not exceed that of the largest Lisp string or buffer. See Eli
517 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 518
5e927815
PE
519 * alloc.c (__malloc_size_t): Remove.
520 All uses replaced by size_t. See Andreas Schwab's note
521 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
522
ca4aa935
PE
523 * image.c: Improve checking for integer overflow.
524 (check_image_size): Assume that f is nonnull, since
525 it is always nonnull in practice. This is one less thing to
526 worry about when checking for integer overflow later.
527 (x_check_image_size): New function, which checks for integer
528 overflow issues inside X.
529 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
530 This removes the need for a memory_full check.
531 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
532 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
533 (xbm_read_bitmap_data): Change locals back to 'int', since
534 their values must fit in 'int'.
535 (xpm_load_image, png_load, tiff_load):
536 Invoke x_create_x_image_and_pixmap earlier,
537 to avoid much needless work if the image is too large.
538 (tiff_load): Treat overly large images as if
539 x_create_x_image_and_pixmap failed, not as malloc failures.
540 (gs_load): Use x_check_image_size.
541
5f8f9cc2
PE
542 * gtkutil.c: Omit integer casts.
543 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
544 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
545
5adf60bc
PE
546 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
547
c8907a93
PE
548 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
549 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
550 would wrongly return t on a 64-bit host.
551
e3c25c68
PE
552 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
553 The plain *_OVERFLOW macros run afoul of GCC bug 49705
554 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
555 and therefore cause GCC to emit a bogus diagnostic in some cases.
556
3f791afe
PE
557 * image.c: Integer signedness and overflow and related fixes.
558 This is not an exhaustive set of fixes, but it's time to
559 record what I've got.
560 (lookup_pixel_color, check_image_size): Remove redundant decls.
561 (check_image_size): Don't assume that arbitrary EMACS_INT values
562 fit in 'int', or that arbitrary 'double' values fit in 'int'.
563 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
564 (tiff_load, imagemagick_load_image):
565 Check for overflow in size calculations.
566 (x_create_x_image_and_pixmap): Remove unnecessary test for
567 xmalloc returning NULL; that can't happen.
568 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
569 (xpm_color_bucket): Use better integer hashing function.
570 (xpm_cache_color): Don't possibly over-allocate memory.
571 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
572 (gif_memory_source):
573 Use ptrdiff_t, not int or size_t, to record sizes.
574 (png_load): Don't assume values greater than 2**31 fit in 'int'.
575 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
576 either works, as we prefer signed integers.
577 (tiff_read_from_memory, tiff_write_from_memory):
578 Return tsize_t, not size_t, since that's what the TIFF API wants.
579 (tiff_read_from_memory): Don't fail simply because the read would
580 go past EOF; instead, return a short read.
581 (tiff_load): Omit no-longer-needed casts.
582 (Fimagemagick_types): Don't assume size fits into 'int'.
583
3cc5a532
PE
584 Improve hashing quality when configured --with-wide-int.
585 * fns.c (hash_string): New function, taken from sxhash_string.
586 Do not discard information about ASCII character case; this
587 discarding is no longer needed.
588 (sxhash-string): Use it. Change sig to match it. Caller changed.
589 * lisp.h: Declare it.
590 * lread.c (hash_string): Remove, since we now use fns.c's version.
591 The fns.c version returns a wider integer if --with-wide-int is
592 specified, so this should help the quality of the hashing a bit.
593
b312a492
PE
594 * emacs.c: Integer overflow minor fix.
595 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
596 Define only if GNU_LINUX.
597 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
598
dfd153ae
PE
599 * dispnew.c: Integer signedness and overflow fixes.
600 Remove unnecessary forward decls, that were a maintenance hassle.
601 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
602 All uses changed.
603 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
604 (scrolling_window): Use ptrdiff_t, not int, for byte count.
605 (prepare_desired_row, line_draw_cost):
606 Use int, not unsigned, where either works.
607 (save_current_matrix, restore_current_matrix):
608 Use ptrdiff_t, not size_t, where either works.
609 (init_display): Check for overflow more accurately, and without
610 relying on undefined behavior.
611
a81d11a3
PE
612 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
613 Remove, replacing with the new symbols in lisp.h. All uses changed.
614 * fileio.c (make_temp_name):
615 * filelock.c (lock_file_1, lock_file):
616 * xdisp.c (message_dolog):
617 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
618 Use pMd etc. instead.
619 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
620 replacing the pWIDE etc. symbols removed from editfns.c.
621
3300e6fd
PE
622 * keyboard.h (num_input_events): Now uintmax_t.
623 This is (very slightly) less likely to mess up due to wraparound.
624 All uses changed.
625
fd05c7e9
PE
626 * buffer.c: Integer signedness fixes.
627 (alloc_buffer_text, enlarge_buffer_text):
628 Use ptrdiff_t rather than size_t when either will do, as we prefer
629 signed integers.
630
903fe15d
PE
631 * alloc.c: Integer signedness and overflow fixes.
632 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
633 (__malloc_size_t): Default to size_t, not to int.
634 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
635 (Fgarbage_collect, mark_object_loop_halt, mark_object):
636 Prefer ptrdiff_t to size_t when either would do, as we prefer
637 signed integers.
638 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
639 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
640 Now const. Initialize with values that are in range even if char
641 is signed.
642 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
643 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
644 These functions do the right thing with sizes > 2**32.
645 (check_depth): Now ptrdiff_t, not int.
646 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
647 Adjust to new way of storing sizes. Check for size overflow bugs
648 in rest of code.
649 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
650 slightly wrong anyway, as it missed one instance of
651 XMALLOC_OVERRUN_CHECK_OVERHEAD.
652 (refill_memory_reserve): Omit needless cast to size_t.
653 (mark_object_loop_halt): Mark as externally visible.
654
ac82cc6a
PE
655 * xselect.c: Integer signedness and overflow fixes.
656 (Fx_register_dnd_atom, x_handle_dnd_message):
657 Use ptrdiff_t, not size_t, since we prefer signed.
658 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
659 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
660 x_dnd_atoms_size and x_dnd_atoms_length.
661
c2d1e36d
PE
662 * doprnt.c: Prefer signed to unsigned when either works.
663 * eval.c (verror):
664 * doprnt.c (doprnt):
665 * lisp.h (doprnt):
666 * xdisp.c (vmessage):
667 Use ptrdiff_t, not size_t, when using or implementing doprnt,
668 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
669 prefer signed arithmetic to avoid comparison confusion.
670 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
671 but is a bit tricky.
672
0e926e56
PE
673 Assume freestanding C89 headers, string.h, stdlib.h.
674 * data.c, doprnt.c, floatfns.c, print.c:
675 Include float.h unconditionally.
676 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
677 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
678 * regex.c: Likewise for stddef.h, string.h.
679 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
680 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
681 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
682 (STDC_HEADERS): Remove obsolete defines.
683 * sysdep.c: Include limits.h unconditionally.
684
9cfdb3ec
PE
685 Assume support for memcmp, memcpy, memmove, memset.
686 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
687 * regex.c (memcmp, memcpy):
688 Remove; we assume C89 now.
689
690 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
691 (__malloc_safe_bcopy): Remove; no longer needed.
692
cf950e6b 693 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
694 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
695 well either way, and we prefer signed to unsigned.
696
dbf38e02
LMI
6972011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
698
699 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
700 closes the connection while we're reading (bug#9182).
701
d6f0886c
JD
7022011-07-25 Jan Djärv <jan.h.d@swipnet.se>
703
704 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
705 are specified (Bug#9168).
706
2eb1f9e6
PE
7072011-07-25 Paul Eggert <eggert@cs.ucla.edu>
708
709 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
710 Found by GCC static checking and --with-wide-int on a 32-bit host.
711
22381272 7122011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
713
714 * xdisp.c (compute_display_string_pos): Fix logic of caching
715 previous display string position. Initialize cached_prev_pos to
716 -1. Fixes slow-down at the beginning of a buffer.
717
f25e39b4
EZ
7182011-07-24 Eli Zaretskii <eliz@gnu.org>
719
720 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
721 for attrs[LFACE_FONTSET_INDEX].
722
04c4b52e
PE
7232011-07-23 Paul Eggert <eggert@cs.ucla.edu>
724
725 * xml.c (parse_region): Remove unused local
726 that was recently introduced.
727
c1734fbd
EZ
7282011-07-23 Eli Zaretskii <eliz@gnu.org>
729
be18c5a5
EZ
730 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
731 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
732
c1734fbd
EZ
733 * xdisp.c (move_it_in_display_line_to): Record the best matching
734 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
735 exit if none of the characters scanned was an exact match.
736 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
737 when exact match is impossible due to invisible text, and the
738 lines are truncated.
739
a258d627
JD
7402011-07-23 Jan Djärv <jan.h.d@swipnet.se>
741
742 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
743 for OSX >= 10.7.
744
b6d5a689
EZ
7452011-07-22 Eli Zaretskii <eliz@gnu.org>
746
0f74f785
EZ
747 Fix a significant slow-down of cursor motion with C-n, C-p,
748 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
749 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 750 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
751 (next_element_from_buffer): Call compute_stop_pos_backwards to
752 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
753 base_level_stop.
754 (reseat): Don't look for prev_stop, as that could mean a very long
755 run.
756 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
757 <cached_disp_overlay_modiff>: Cache for last found display string
758 position.
551918c1 759 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
760 about the same buffer in the same area of character positions, and
761 the buffer wasn't changed since the time the display string
762 position was cached.
551918c1 763
b2d0c91a
EZ
7642011-07-22 Eli Zaretskii <eliz@gnu.org>
765
766 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
767 is an integer, which is important for empty lines. (Bug#9149)
768
043604ee
CY
7692011-07-22 Chong Yidong <cyd@stupidchicken.com>
770
771 * frame.c (Fmodify_frame_parameters): In tty case, update the
772 default face if necessary (Bug#4238).
773
da4adb04
CY
7742011-07-21 Chong Yidong <cyd@stupidchicken.com>
775
776 * editfns.c (Fstring_to_char): No need to explain what a character
777 is in the docstring (Bug#6576).
778
9abd0532
LMI
7792011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
780
781 * xml.c (parse_region): Make sure we always return a tree.
782
36881d16
HK
7832011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
784
785 * xml.c (parse_region): If a document contains only comments,
786 return that, too.
787
1e98674d
LMI
7882011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
789
790 * xml.c (make_dom): Return comments, too.
791
590bd467
PE
7922011-07-19 Paul Eggert <eggert@cs.ucla.edu>
793
794 Port to OpenBSD.
795 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
796 and the surrounding thread.
797 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
798 rather than fgets, and retry after EINTR. Otherwise, 'emacs
799 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
800 timer goes off.
801 * s/openbsd.h (BROKEN_SIGIO): Define.
802 * unexelf.c (unexec) [__OpenBSD__]:
803 Don't update the .mdebug section of the Alpha COFF symbol table.
804
f41628b2
LMI
8052011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
806
807 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
808 (bug#8460).
809
b59b67c5
PE
8102011-07-18 Paul Eggert <eggert@cs.ucla.edu>
811
15e3a074
PE
812 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
813 This fixes some race conditions on the permissions of any newly
814 created file.
815
41bed37d
PE
816 * alloc.c (valid_pointer_p): Use pipe, not open.
817 This fixes some permissions issues when debugging.
818
b59b67c5
PE
819 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
820 If fchown fails to set both uid and gid, try to set just gid,
821 as that is sometimes allowed. Adjust the file's mode to eliminate
822 setuid or setgid bits that are inappropriate if fchown fails.
823
925a6be7
SM
8242011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
825
826 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
827 to compare Lisp_Objects.
828 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
829 global_gnutls_log_level, don't mistake it for a Lisp_Object.
830 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
831
52968808
AS
8322011-07-17 Andreas Schwab <schwab@linux-m68k.org>
833
0a6a104b
AS
834 * lread.c (read_integer): Unread even EOF character.
835 (read1): Likewise. Properly record start position of symbol.
836
52968808
AS
837 * lread.c (read1): Read `#:' as empty uninterned symbol if no
838 symbol character follows.
839
9e381cdd
PE
8402011-07-17 Paul Eggert <eggert@cs.ucla.edu>
841
842 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
843 This works around a problem with the previous change to Fcopy_file.
844 Recent glibc declares fchown with __attribute__((warn_unused_result)),
845 and without this change, GCC might complain about discarding
846 fchown's return value.
847
b5641435
JB
8482011-07-16 Juanma Barranquero <lekktu@gmail.com>
849
850 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
851
a8031457
PE
8522011-07-16 Paul Eggert <eggert@cs.ucla.edu>
853
854 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
855
dd889327
LMI
8562011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
857
750c33f7
LMI
858 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
859 it's used from the C level.
860
dd889327
LMI
861 * process.c: Use the same condition for POLL_FOR_INPUT in both
862 keyboard.c and process.c (bug#1858).
863
87e86684
LM
8642011-07-09 Lawrence Mitchell <wence@gmx.li>
865
866 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
867 (Fgnutls_boot): Use it.
868
64348f40
AS
8692011-07-15 Andreas Schwab <schwab@linux-m68k.org>
870
871 * doc.c (Fsubstitute_command_keys): Revert last change.
872
1d698799
LMI
8732011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
874
f863868c
LMI
875 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
876 quotes the next character, and doesn't affect other longer
877 sequences (bug#8935).
878
1d698799
LMI
879 * lread.c (syms_of_lread): Clarify that is isn't only
880 `eval-buffer' and `eval-defun' that's affected by
881 `lexical-binding' (bug#8460).
882
aa4b6df6
EZ
8832011-07-15 Eli Zaretskii <eliz@gnu.org>
884
885 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
886 bidi redisplay when a line includes both an image and is
887 truncated.
888
5d856da6
PE
8892011-07-14 Paul Eggert <eggert@cs.ucla.edu>
890
ad6042bb
PE
891 Fix minor problems found by static checking.
892 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
893 (elsz): Now a signed constant, not a size_t var. We prefer signed
894 types to unsigned, to avoid integer comparison confusion. Without
895 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
896 "cannot optimize loop, the loop counter may overflow", a symptom
897 of the confusion.
f00bbb22 898 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
899 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
900
6468f31c
LMI
9012011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
902
49080b10
LMI
903 * search.c (Fre_search_backward): Mention `case-fold-search' in
904 all the re_search_* functions (bug#8138).
905
6468f31c
LMI
906 * keyboard.c (Fopen_dribble_file): Document when the file is
907 closed (bug#8056).
908
c965adc5
EZ
9092011-07-14 Eli Zaretskii <eliz@gnu.org>
910
df9733bf
EZ
911 * bidi.c (bidi_dump_cached_states): Fix format of displaying
912 bidi_cache_idx.
913
0bb23927
EZ
914 Support bidi reordering of display and overlay strings.
915 * xdisp.c (compute_display_string_pos)
916 (compute_display_string_end): Accept additional argument STRING.
917 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
918 (reseat_to_string): Initialize bidi_it->string.s and
919 bidi_it->string.schars.
920 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
921 NULL (avoids a crash in bidi_paragraph_init).
922 Initialize itb.string.lstring.
0bb23927
EZ
923 (init_iterator): Call bidi_init_it only of a valid
924 buffer position was specified. Initialize paragraph_embedding to
925 L2R.
926 (reseat_to_string): Initialize the bidi iterator.
927 (display_string): If we need to ignore text properties of
928 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
929 original value of -1 will not work with bidi.)
930 (compute_display_string_pos): First arg is now struct
931 `text_pos *'; all callers changed. Support display properties on
932 Lisp strings.
933 (compute_display_string_end): Support display properties on Lisp
934 strings.
935 (init_iterator, reseat_1, reseat_to_string): Initialize the
936 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
937 when iterating on a string not from display properties).
640c8776
SM
938 (compute_display_string_pos, compute_display_string_end):
939 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
940 arrow keys.
941 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
942 base_level_stop; instead, set base_level_stop to BEGV.
943 Fixes crashes in vertical-motion.
0bb23927
EZ
944 (next_element_from_buffer): Improve commentary for when
945 the iterator is before prev_stop.
946 (init_iterator): Initialize bidi_p from the default value of
947 bidi-display-reordering, not from buffer-local value. Use the
948 buffer-local value only if initializing for buffer iteration.
949 (handle_invisible_prop): Support invisible properties on strings
950 that are being bidi-reordered.
951 (set_iterator_to_next): Support bidi reordering of C strings and
952 Lisp strings.
953 (next_element_from_string): Support bidi reordering of Lisp
954 strings.
955 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
956 (display_string): Support display of R2L glyph rows.
957 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
958 (init_iterator): Don't initialize it->bidi_p for strings
959 here.
960 (reseat_to_string): Initialize it->bidi_p for strings here.
961 (next_element_from_string, next_element_from_c_string)
962 (next_element_from_buffer): Add xassert's for correspondence
963 between IT's object being iterated and it->bidi_it.string
964 structure.
965 (face_before_or_after_it_pos): Support bidi iteration.
966 (next_element_from_c_string): Handle the case of the first string
967 character that is not the first one in the visual order.
968 (get_visually_first_element): New function, refactored from common
969 parts of next_element_from_buffer, next_element_from_string, and
970 next_element_from_c_string.
971 (tool_bar_lines_needed, redisplay_tool_bar)
972 (display_menu_bar): Force left-to-right direction. Add a FIXME
973 comment for making that be controlled by a user option.
974 (push_it, pop_it): Save and restore the state of the
975 bidi iterator. Save and restore the bidi_p flag.
976 (pop_it): Iterate out of display property for string iteration as
977 well.
978 (iterate_out_of_display_property): Support iteration over strings.
979 (handle_single_display_spec): Set up it->bidi_it for iteration
980 over a display string, and call bidi_init_it.
981 (handle_single_display_spec, next_overlay_string)
982 (get_overlay_strings_1, push_display_prop): Set up the bidi
983 iterator for displaying display or overlay strings.
984 (forward_to_next_line_start): Don't use the shortcut if
985 bidi-iterating.
986 (back_to_previous_visible_line_start): If handle_display_prop
987 pushed the iterator stack, restore the internal state of the bidi
988 iterator by calling bidi_pop_it same number of times.
989 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
990 and we are bidi-iterating, don't decrement the iterator position;
991 instead, set the first_elt flag in the bidi iterator, to produce
992 the same effect.
993 (reseat_1): Remove redundant setting of string_from_display_prop_p.
994 (push_display_prop): xassert that we are iterating a buffer.
995 (push_it, pop_it): Save and restore paragraph_embedding member.
996 (handle_single_display_spec, next_overlay_string)
997 (get_overlay_strings_1, reseat_1, reseat_to_string)
998 (push_display_prop): Set up the `unibyte' member of bidi_it.string
999 correctly. Don't assume unibyte strings are not bidi-reordered.
1000 (compute_display_string_pos)
1001 (compute_display_string_end): Fix handling the case of C string.
1002 (push_it, pop_it): Save and restore from_disp_prop_p.
1003 (handle_single_display_spec, push_display_prop): Set the
1004 from_disp_prop_p flag.
1005 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1006 (pop_it): Call iterate_out_of_display_property only if we are
1007 popping after iteration over a string that came from a display
1008 property. Fix a typo in popping stretch info. Add an assertion
1009 for verifying that the iterator position is in sync with the bidi
1010 iterator.
1011 (handle_single_display_spec, get_overlay_strings_1)
1012 (push_display_prop): Fix initialization of paragraph direction for
1013 string when that of the parent object is not yet determined.
1014 (reseat_1): Call bidi_init_it to resync the bidi
1015 iterator with IT's position. (Bug#7616)
1016 (find_row_edges): If ROW->start.pos gives position
1017 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1018 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1019 Reset the from_disp_prop_p flag.
1020 (SAVE_IT, RESTORE_IT): New macros.
1021 (pos_visible_p, face_before_or_after_it_pos)
1022 (back_to_previous_visible_line_start)
1023 (move_it_in_display_line_to, move_it_in_display_line)
1024 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1025 (try_scrolling, redisplay_window, display_line): Use them when
1026 saving a temporary copy of the iterator and restoring it back.
1027 (back_to_previous_visible_line_start, reseat_1)
1028 (init_iterator): Empty the bidi cache "stack".
1029 (move_it_in_display_line_to): If iterator ended up at
1030 EOL, but we never saw any buffer positions smaller than
1031 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1032 motion in bidi-reordered lines.
1033 (move_it_in_display_line_to): Record prev_method and prev_pos
1034 immediately before the call to set_iterator_to_next. Fixes cursor
1035 motion in bidi-reordered lines with stretch glyphs and strings
1036 displayed in margins. (Bug#8133) (Bug#8867)
1037 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1038 TO_CHARPOS.
640c8776
SM
1039 (pos_visible_p): Support positions in bidi-reordered lines.
1040 Save and restore bidi cache.
0bb23927
EZ
1041
1042 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1043 (bidi_paragraph_info): Delete unused struct.
1044 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1045 (bidi_cache_start): New variable.
1046 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1047 to zero.
1048 (bidi_cache_fetch_state, bidi_cache_search)
1049 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1050 (bidi_cache_find, bidi_peek_at_next_level)
1051 (bidi_level_of_next_char, bidi_find_other_level_edge)
1052 (bidi_move_to_visually_next): Compare cache index with
1053 bidi_cache_start rather than with zero.
1054 (bidi_fetch_char): Accept new argument STRING; all callers
1055 changed. Support iteration over a string. Support strings with
1056 display properties. Support unibyte strings. Fix the type of
1057 `len' according to what STRING_CHAR_AND_LENGTH expects.
1058 (bidi_paragraph_init, bidi_resolve_explicit_1)
1059 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1060 (bidi_level_of_next_char, bidi_move_to_visually_next):
1061 Support iteration over a string.
0bb23927
EZ
1062 (bidi_set_sor_type, bidi_resolve_explicit_1)
1063 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1064 can now be zero (for strings); special values 0 and -1 were
1065 changed to -1 and -2, respectively.
1066 (bidi_char_at_pos): New function.
1067 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1068 Call it instead of FETCH_MULTIBYTE_CHAR.
1069 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1070 initialized to valid values.
1071 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1072 values.
1073 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1074 the test for valid cached positions. Fix the logic for looking up
1075 the sentinel state in the cache. GCPRO the Lisp string we are
1076 iterating.
1077 (bidi_push_it, bidi_pop_it): New functions.
1078 (bidi_initialize): Initialize the bidi cache start stack pointer.
1079 (bidi_cache_ensure_space): New function, refactored from part of
1080 bidi_cache_iterator_state. Don't assume the required size is just
1081 one BIDI_CACHE_CHUNK away.
1082 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1083 (bidi_count_bytes, bidi_char_at_pos): New functions.
1084 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1085 always valid if bidi_cache_idx is valid.
1086 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1087 is valid if it's going to be used.
1088 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1089 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1090 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1091 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1092 (bidi_find_other_level_edge, bidi_cache_start_stack):
1093 All variables related to cache indices are now EMACS_INT.
c965adc5 1094
0bb23927
EZ
1095 * dispextern.h (struct bidi_string_data): New structure.
1096 (struct bidi_it): New member `string'. Make flag members be 1-bit
1097 fields, and put them last in the struct.
640c8776
SM
1098 (compute_display_string_pos, compute_display_string_end):
1099 Update prototypes.
0bb23927
EZ
1100 (bidi_push_it, bidi_pop_it): Add prototypes.
1101 (struct iterator_stack_entry): New members bidi_p,
1102 paragraph_embedding, and from_disp_prop_p.
1103 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1104 (bidi_shelve_cache, bidi_unshelve_cache):
1105 Declare prototypes.
0bb23927
EZ
1106
1107 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1108 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1109 and vector-like objects.
1110
1111 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1112 cache around display iteration.
1113
1114 * window.c (Fwindow_end, window_scroll_pixel_based)
1115 (displayed_window_lines, Frecenter): Save and restore the bidi
1116 cache around display iteration.
1117
3bbd2265
LMI
11182011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1119
1120 * editfns.c (Fdelete_region): Clarify the use of the named
1121 parameters (bug#6788).
1122
adc47434
MR
11232011-07-14 Martin Rudalics <rudalics@gmx.at>
1124
1125 * indent.c (Fvertical_motion): Set and restore w->pointm when
1126 saving and restoring the window's buffer (Bug#9006).
1127
837c31f8
LMI
11282011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1129
1130 * editfns.c (Fstring_to_char): Clarify just what is returned
1131 (bug#6576). Text by Eli Zaretskii.
1132
ac389d0c
JB
11332011-07-13 Juanma Barranquero <lekktu@gmail.com>
1134
1135 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1136
0be0ce47
EZ
11372011-07-13 Eli Zaretskii <eliz@gnu.org>
1138
1139 * buffer.c (mmap_find): Fix a typo.
1140
cd18e7e3
JB
11412011-07-13 Johan Bockgård <bojohan@gnu.org>
1142
1143 Fix execution of x selection hooks.
1144 * xselect.c (Qx_lost_selection_functions)
1145 (Qx_sent_selection_functions): New vars.
1146 (syms_of_xselect): DEFSYM them.
1147 (x_handle_selection_request): Pass Qx_sent_selection_functions
1148 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1149 (x_handle_selection_clear,x_clear_frame_selections):
1150 Pass Qx_lost_selection_functions rather than
1151 Vx_lost_selection_functions to Frun_hook_with_args.
1152
47ea7f44
PE
11532011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1154
ac389d0c 1155 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1156 The old code sometimes used this field without initializing it.
1157
47ea7f44
PE
1158 * alloc.c (gc_sweep): Don't read past end of array.
1159 In theory, the old code could also have corrupted Emacs internals,
1160 though it'd be very unlikely.
1161
bc985c87
AS
11622011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1163
1164 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1165 argument. (Bug#4026)
bc985c87 1166
0cf34688
LMI
11672011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1168
b3dadd76
LMI
1169 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1170 key" (bug#4257).
1171
0cf34688
LMI
1172 * window.c (Fset_window_start): Doc fix (bug#4199).
1173 (Fset_window_hscroll): Ditto.
1174
270768cd
PE
11752011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1176
077e3dda 1177 Fix minor new problems caught by GCC 4.6.1.
270768cd 1178 * term.c (init_tty): Remove unused local.
490011a6 1179 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1180 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1181 not used otherwise.
270768cd 1182
b1f58454
CY
11832011-07-12 Chong Yidong <cyd@stupidchicken.com>
1184
1185 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1186
22b9578d
LMI
11872011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1188
6e70ab07
LMI
1189 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1190 are the mini-buffer and the echo area (bug#3320).
1191
22b9578d
LMI
1192 * term.c (init_tty): Remove support for supdup, c10 and perq
1193 terminals, which are no longer supported (bug#1482).
1194
8974cc9f
JB
11952011-07-10 Johan Bockgård <bojohan@gnu.org>
1196
1197 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1198
a560d974
JD
11992011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1200
1201 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1202 for non-popups (Bug#3642).
1203
1dae0f0a
AS
12042011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1205
268c2c36 1206 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1207 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1208 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1209 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1210 * data.c (fmod): Likewise.
1211 * dispnew.c (swap_glyphs_in_rows): Likewise.
1212 * emacs.c (memory_warning_signal): Likewise.
1213 * floatfns.c (float_error): Likewise.
1214 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1215 (otf_open, font_otf_capability, generate_otf_features)
1216 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1217 Likewise.
1218 * image.c (pbm_read_file): Likewise.
1219 * indent.c (string_display_width): Likewise.
1220 * intervals.c (check_for_interval, search_for_interval)
1221 (inc_interval_count, count_intervals, root_interval)
1222 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1223 * lread.c (defalias): Likewise.
268c2c36 1224 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1225 * regex.c (set_image_of_range_1, set_image_of_range)
1226 (regex_grow_registers): Likewise.
1227 * sysdep.c (strerror): Likewise.
1228 * termcap.c (valid_filename_p, tprint, main): Likewise.
1229 * tparam.c (main): Likewise.
1230 * unexhp9k800.c (run_time_remap, save_data_space)
1231 (update_file_ptrs, read_header, write_header, calculate_checksum)
1232 (copy_file, copy_rest, display_header): Likewise.
1233 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1234 Likewise.
1235 * xdisp.c (check_it): Likewise.
1236 * xfaces.c (register_color, unregister_color, unregister_colors):
1237 Likewise.
1238 * xfns.c (print_fontset_result): Likewise.
1239 * xrdb.c (member, fatal, main): Likewise.
1240
99033785
PE
12412011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1242
1243 Fix minor problems found by static checking (Bug#9031).
1244 * chartab.c (char_table_set_range, map_sub_char_table):
1245 Remove unused locals.
1246 (uniprop_table): Now static.
1247 * composite.c (_work_char): Remove unused static var.
1248
9cb2ac56
JB
12492011-07-09 Juanma Barranquero <lekktu@gmail.com>
1250
1251 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1252
f25661f0
JD
12532011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1254
1255 * gtkutil.c (qttip_cb): Remove code without function.
1256
8278c4fe
EZ
12572011-07-09 Eli Zaretskii <eliz@gnu.org>
1258
1259 * w32.c (pthread_sigmask): New stub.
1260
1692ae2d 12612011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1262
8a6ebd58 1263 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1264 sigprocmask is portable only for single-threaded applications, and
1265 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1266 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1267 (LIBES): Use it.
1268 * callproc.c (Fcall_process):
1269 * process.c (create_process):
1270 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1271 Use pthread_sigmask, not sigprocmask.
123403e4 1272
1b854618
JD
12732011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1274
1275 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1276 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1277 wrong (Bug#8591).
1278
3fe4b549
JD
12792011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1280
0ce7e563
JD
1281 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1282 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1283 (xg_hide_tooltip): Fix comment.
1284
3fe4b549
JD
1285 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1286 in registerServicesMenuSendTypes.
1287 (validRequestorForSendType): Don't check ns_return_types.
1288
1289 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1290 ns_return_type.
1291
5df75e47
JR
12922011-07-08 Jason Rumney <jasonr@gnu.org>
1293
1294 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1295 frame struct members of non-existent frames (Bug#6284).
1296
699c10bd
JD
12972011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1298
4393663b
JD
1299 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1300 variable firstTime not needed on OSX >= 10.6.
1301 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1302 >= 10.5. Use setKnobProportion, setDoubleValue.
1303
1304 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1305 (MAC_OS_X_VERSION_10_5): Define if not defined.
1306 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1307 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1308 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1309
1310 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1311 cString and lossyCString on OSX >= 10.4
1312
1313 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1314 sizeToFit on OSX >= 10.2.
1315
1316 * nsimage.m (allocInitFromFile): Don't use deprecated method
1317 bestRepresentationForDevice on OSX >= 10.6.
1318
1319 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1320 to avoid warning.
1321
1322 * emacs.c: Declare unexec_init_emacs_zone.
1323
a63e0781
JD
1324 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1325
699c10bd
JD
1326 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1327
1328 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1329 on svcsMenu (Bug#8842).
1330
1331 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1332 ns_return_types.
1333 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1334
1335 * nsterm.m (QUTF8_STRING): Declare.
1336 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1337 (validRequestorForSendType): Return type is (id).
1338 Change indexOfObjectIdenticalTo to indexOfObject.
1339 Check if we have local selection before returning self (Bug#8842).
1340 (writeSelectionToPasteboard): Put local selection into paste board
1341 if we have a local selection (Bug#8842).
1342 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1343
1344 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1345 (ns_get_local_selection): Declare.
1346
54e10184
LMI
13472011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1348
9888ff71
LMI
1349 * keymap.c (describe_map_tree): Don't insert a double newline at
1350 the end of the buffer (bug#1169) and return whether we inserted
1351 something.
1352
54e10184
LMI
1353 * callint.c (Fcall_interactively): Change "reading args" to
1354 "providing args" to try to clarify what it does (bug#1010).
1355
15fa4783
KH
13562011-07-07 Kenichi Handa <handa@m17n.org>
1357
1358 * composite.c (composition_compute_stop_pos): Ignore a static
1359 composition starting before CHARPOS (Bug#8915).
1360
1361 * xdisp.c (handle_composition_prop): Likewise.
1362
a8815b00
EZ
13632011-07-07 Eli Zaretskii <eliz@gnu.org>
1364
1365 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1366 (Bug#9015)
1367
ef7b981d 13682011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1369
1370 * character.h (unicode_category_t): New enum type.
1371
1372 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1373 (Qchar_code_property_table): New variable.
1374 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1375 (UNIPROP_COMPRESSED_FORM_P): New macros.
1376 (char_table_ascii): Uncompress the compressed values.
1377 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1378 Uncompress the compressed values.
ac389d0c 1379 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1380 (char_table_ref_and_range): Uncompress the compressed values.
1381 (sub_char_table_set): New arg is_uniprop. Callers changed.
1382 Uncompress the compressed values.
1383 (sub_char_table_set_range): Args changed. Callers changed.
1384 (char_table_set_range): Adjuted for the above change.
1385 (map_sub_char_table): Delete args default_val and parent. Add arg
1386 top. Give decoded values to a Lisp function.
640c8776 1387 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1388 values to a Lisp function. Gcpro more variables.
1389 (uniprop_table_uncompress)
1390 (uniprop_decode_value_run_length): New functions.
1391 (uniprop_decoder, uniprop_decoder_count): New variables.
1392 (uniprop_get_decoder, uniprop_encode_value_character)
1393 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1394 New functions.
1395 (uniprop_encoder, uniprop_encoder_count): New variables.
1396 (uniprop_get_encoder, uniprop_table)
1397 (Funicode_property_table_internal, Fget_unicode_property_internal)
1398 (Fput_unicode_property_internal): New functions.
1399 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1400 Sunicode_property_table_internal, Sget_unicode_property_internal,
1401 and Sput_unicode_property_internal. Defvar_lisp
1402 char-code-property-alist.
1403
640c8776 1404 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1405 Vunicode_category_table.
1406
640c8776 1407 * font.c (font_range): Adjust for the change of
c805dec0
KH
1408 Vunicode_category_table.
1409
76b397fb
DN
14102011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1411
1412 * m/iris4d.h: Remove file, move contents ...
1413 * s/irix6-5.h: ... here.
1414
22b4128e
PE
14152011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1416
1417 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1418 * alloc.c (mark_buffer):
1419 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1420 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1421 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1422 This isn't true in general, and it's particularly not true
1423 if Emacs is configured with --with-wide-int.
1424 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1425 New macros, used in the buffer.c change.
1426
869795d6
JD
14272011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1428
1429 * xsettings.c: Use both GConf and GSettings if both are available.
1430 (store_config_changed_event): Add comment.
1431 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1432 (store_tool_bar_style_changed): New functions.
1433 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1434 (struct xsettings): Move font inside HAVE_XFT.
1435 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1436 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1437 Move inside HAVE_XFT.
640c8776 1438 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1439 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1440 also.
1441 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1442 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1443 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1444 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1445 (parse_settings): Move check for font inside HAVE_XFT.
1446 (read_settings, apply_xft_settings): Add comment.
1447 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1448 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1449 call store_font_name_changed.
1450 (xft_settings_event): Add comment.
1451 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1452 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1453 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1454 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1455 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1456 (xsettings_get_system_font, xsettings_get_system_normal_font):
1457 Add comment.
869795d6 1458
d8ed26bd
PE
14592011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1460
1461 Random fixes. E.g., (random) never returned negative values.
1462 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1463 subseconds part to the entropy, as that's a bit more random.
1464 Prefer signed to unsigned, since the signedness doesn't matter and
1465 in general we prefer signed. When given a limit, use a
1466 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1467 latter isn't right if USE_2_TAGS_FOR_INTS.
1468 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1469 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1470
cabf1cac
SM
14712011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1472
1473 * textprop.c (text_property_stickiness):
1474 Obey Vtext_property_default_nonsticky.
1475 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1476 * w32fns.c (syms_of_w32fns):
1477 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1478
6e9b2be9
PE
14792011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1480
1481 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1482 This is more efficient than Ffile_directory_p and avoids a minor race.
1483
90186c68
LMI
14842011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1485
7c301272
LMI
1486 * buffer.c (Foverlay_put): Say what the return value is
1487 (bug#7835).
1488
c4f2d8d4
LMI
1489 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1490 is a directory before asking whether to use the file name
1491 (bug#7564).
ad637907
LMI
1492 (barf_or_query_if_file_exists): Make the "File is a directory"
1493 error be more correct.
c4f2d8d4 1494
90186c68
LMI
1495 * fns.c (Frequire): Remove the mention of the .gz files, since
1496 that's installation-specific, but keep the mention of
1497 `get-load-suffixes'.
1498
da64016e
PE
14992011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1500
1501 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1502 Report string overflow if the output is too long.
1503
7d47b580
JB
15042011-07-04 Juanma Barranquero <lekktu@gmail.com>
1505
a555cb87
JB
1506 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1507 (syms_of_gnutls): Remove duplicate DEFSYM for
1508 Qgnutls_bootprop_verify_hostname_error, an error for
1509 Qgnutls_bootprop_verify_error (which is no longer used).
1510
7d47b580
JB
1511 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1512 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1513 Also (re)move comments that are misplaced or no longer relevant.
1514
1e49bfab
LMI
15152011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1516
1517 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1518
1485f4c0
CY
15192011-07-03 Chong Yidong <cyd@stupidchicken.com>
1520
1521 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1522 and background color parameters if they have been changed.
1523
a9ab721e
LMI
15242011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1525
1526 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1527
cf7cff57
PE
15282011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1529
2e13213d
PE
1530 * xsettings.c (SYSTEM_FONT): Define only when used.
1531 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1532
cf7cff57
PE
1533 * keymap.c (access_keymap_1): Now static.
1534
7a8e04f7
CY
15352011-07-02 Chong Yidong <cyd@stupidchicken.com>
1536
1537 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1538 leave any prefix arg for the up event (Bug#1586).
1539
61352f62
LMI
15402011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1541
69bb1ef7
LMI
1542 * lread.c (syms_of_lread): Mention single symbols defined by
1543 `defvar' or `defconst' (bug#7154).
1544
61352f62 1545 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1546 (Frequire): Mention get-load-suffixes.
61352f62 1547
28545e04
MR
15482011-07-02 Martin Rudalics <rudalics@gmx.at>
1549
1550 * window.h (window): Remove clone_number slot.
1551 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1552 Remove.
1553 (make_parent_window, make_window, saved_window)
1554 (Fset_window_configuration, save_window_save): Don't deal with
1555 clone numbers.
1556 * buffer.c (Qclone_number): Remove declaration.
1557 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1558
3349e122
SM
15592011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1560
1561 Add multiple inheritance to keymaps.
1562 * keymap.c (Fmake_composed_keymap): New function.
1563 (Fset_keymap_parent): Simplify.
1564 (fix_submap_inheritance): Remove.
1565 (access_keymap_1): New function extracted from access_keymap to handle
1566 embedded parents and handle lists of maps.
1567 (access_keymap): Use it.
1568 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1569 (Fcopy_keymap): Handle embedded parents.
1570 (Fcommand_remapping, define_as_prefix): Simplify.
1571 (Fkey_binding): Simplify.
1572 (syms_of_keymap): Move minibuffer-local-completion-map,
1573 minibuffer-local-filename-completion-map,
1574 minibuffer-local-must-match-map, and
1575 minibuffer-local-filename-must-match-map to Elisp.
1576 (syms_of_keymap): Defsubr make-composed-keymap.
1577 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1578 (parse_menu_item): Trivial simplification.
1579
3279eb87
GM
15802011-07-01 Glenn Morris <rgm@gnu.org>
1581
1582 * Makefile.in (SETTINGS_LIBS): Fix typo.
1583
4550efdf
KI
15842011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1585
1586 * coding.c (Fencode_coding_string): Record the last coding system
1587 used, as the function doc string says (bug#8738).
1588
0949d2b6
JD
15892011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1590
1591 * xsettings.c (store_monospaced_changed): Take new font as arg and
1592 check for change against current_mono_font.
1593 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1594 (emacs_settings_constructor, emacs_settings_get_property)
1595 (emacs_settings_set_property, emacs_settings_class_init)
1596 (emacs_settings_init, gsettings_obj): Remove.
1597 (something_changedCB): New function for HAVE_GSETTINGS.
1598 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1599 with value as argument.
1600 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1601 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1602 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1603 "changed".
1604
1605 * xgselect.c: Add defined (HAVE_GSETTINGS).
1606 (xgselect_initialize): Ditto.
1607
1608 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1609 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1610 xg_select.
1611
bbc6b304
PE
16122011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1613
1614 * eval.c (struct backtrace): Simplify and port the data structure.
1615 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1616 signed bit field, as this assumption is not portable and it makes
1617 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1618 "char debug_on_exit : 1" as this is not portable either; instead,
1619 use the portable "unsigned int debug_on_exit : 1". Remove unused
1620 member evalargs. Remove obsolete comments about cc bombing out.
1621
9851bfc5
JD
16222011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1623
51bb811f 1624 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1625 Let HAVE_GSETTINGS override HAVE_GCONF.
1626 (store_monospaced_changed): New function.
1627 (EMACS_SETTINGS): A new type derived from GObject to handle
1628 GSettings notifications.
1629 (emacs_settings_constructor, emacs_settings_get_property)
1630 (emacs_settings_set_property, emacs_settings_class_init):
1631 New functions.
1632 (gsettings_client, gsettings_obj): New variables.
1633 (GSETTINGS_SCHEMA): New define.
1634 (something_changedCB): Call store_monospaced_changed.
1635 (init_gsettings): New function.
1636 (xsettings_initialize): Call init_gsettings.
1637 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1638 to NULL.
1639
640c8776 1640 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1641 GCONF_CFLAGS/LIBS.
1642
5386012d
MR
16432011-06-29 Martin Rudalics <rudalics@gmx.at>
1644
1645 * window.c (resize_root_window, grow_mini_window)
1646 (shrink_mini_window): Rename Qresize_root_window to
1647 Qwindow_resize_root_window and Qresize_root_window_vertically to
1648 Qwindow_resize_root_window_vertically.
1649
f13e0b08
PE
16502011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1651
1652 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1653
94515237
JB
16542011-06-27 Juanma Barranquero <lekktu@gmail.com>
1655
1656 * makefile.w32-in: Redesign dependencies so they reflect more
1657 clearly which files are directly included by each source file,
1658 and not through other includes.
1659
e43b6e43
MR
16602011-06-27 Martin Rudalics <rudalics@gmx.at>
1661
1662 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1663 (sort_overlays, overlay_strings): When an overlay's clone number
1664 matches the window's clone number process the overlay even if
1665 the overlay's window property doesn't match the current window.
1666
d68443dc
MR
1667 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1668 (Fwindow_hchild): Rename to Fwindow_left_child.
1669 (Fwindow_next): Rename to Fwindow_next_sibling.
1670 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1671 (resize_window_check): Rename to window_resize_check.
1672 (resize_window_apply): Rename to window_resize_apply.
1673 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1674 (Fdelete_other_windows_internal, resize_frame_windows)
1675 (Fsplit_window_internal, Fdelete_window_internal)
1676 (grow_mini_window, shrink_mini_window)
1677 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1678
c7e73be5
JD
16792011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1680
1681 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1682 (emacs_fixed_set_min_size): Remove.
1683 (emacs_fixed_new): Take frame as argument.
1684
1685 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1686 (_EmacsFixedPrivate): Remove minwidth/height.
1687 Add struct frame *f.
1688 (emacs_fixed_init): Initialize priv->f.
1689 (get_parent_class, emacs_fixed_set_min_size): Remove.
1690 (emacs_fixed_new): Set priv->f to argument.
1691 (emacs_fixed_get_preferred_width)
1692 (emacs_fixed_get_preferred_height): Use min_width/height from
1693 frames size_hint to set minimum and natural (Bug#8919).
1694 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1695 and use min_width/height from frames size_hint to set
1696 min_width/height (Bug#8919).
1697
1698 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1699 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1700 Fix indentation.
c7e73be5 1701
cf99dcf8
EZ
17022011-06-26 Eli Zaretskii <eliz@gnu.org>
1703
1704 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1705 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1706 called at ZV.
1707
029529ac
CY
17082011-06-26 Chong Yidong <cyd@stupidchicken.com>
1709
1710 * process.c (wait_reading_process_output): Bypass select if
1711 waiting for a cell while ignoring keyboard input, and input is
1712 pending. Suggested by Jan Djärv (Bug#8869).
1713
7a7ef429
PE
17142011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1715
1716 Use gnulib's dup2 module instead of rolling our own.
1717 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1718
11fdef7d 17192011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1720
1721 * dispnew.c (scrolling_window): Before scrolling, turn off a
1722 mouse-highlight in the window being scrolled.
1723
cd3520a4
JB
17242011-06-24 Juanma Barranquero <lekktu@gmail.com>
1725
1726 Move DEFSYM to lisp.h and use everywhere.
1727
1728 * character.h (DEFSYM): Move declaration...
1729 * lisp.h (DEFSYM): ...here.
1730
1731 * gnutls.c:
1732 * minibuf.c:
1733 * w32menu.c:
1734 * w32proc.c:
1735 * w32select.c: Don't include character.h.
1736
1737 * alloc.c (syms_of_alloc):
1738 * buffer.c (syms_of_buffer):
1739 * bytecode.c (syms_of_bytecode):
1740 * callint.c (syms_of_callint):
1741 * casefiddle.c (syms_of_casefiddle):
1742 * casetab.c (init_casetab_once):
1743 * category.c (init_category_once, syms_of_category):
1744 * ccl.c (syms_of_ccl):
1745 * cmds.c (syms_of_cmds):
1746 * composite.c (syms_of_composite):
1747 * dbusbind.c (syms_of_dbusbind):
1748 * dired.c (syms_of_dired):
1749 * dispnew.c (syms_of_display):
1750 * doc.c (syms_of_doc):
1751 * editfns.c (syms_of_editfns):
1752 * emacs.c (syms_of_emacs):
1753 * eval.c (syms_of_eval):
1754 * fileio.c (syms_of_fileio):
1755 * fns.c (syms_of_fns):
1756 * frame.c (syms_of_frame):
1757 * fringe.c (syms_of_fringe):
1758 * insdel.c (syms_of_insdel):
1759 * keymap.c (syms_of_keymap):
1760 * lread.c (init_obarray, syms_of_lread):
1761 * macros.c (syms_of_macros):
1762 * msdos.c (syms_of_msdos):
1763 * print.c (syms_of_print):
1764 * process.c (syms_of_process):
1765 * search.c (syms_of_search):
1766 * sound.c (syms_of_sound):
1767 * syntax.c (init_syntax_once, syms_of_syntax):
1768 * terminal.c (syms_of_terminal):
1769 * textprop.c (syms_of_textprop):
1770 * undo.c (syms_of_undo):
1771 * w32.c (globals_of_w32):
1772 * window.c (syms_of_window):
1773 * xdisp.c (syms_of_xdisp):
1774 * xfaces.c (syms_of_xfaces):
1775 * xfns.c (syms_of_xfns):
1776 * xmenu.c (syms_of_xmenu):
1777 * xsettings.c (syms_of_xsettings):
1778 * xterm.c (syms_of_xterm): Use DEFSYM.
1779
4228cf16
TZ
17802011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1781
cd3520a4 1782 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1783
7fcccf1e
PE
17842011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1785
7efb4e0e
PE
1786 Integer and buffer overflow fixes (Bug#8873).
1787
ff5844ad
PE
1788 * print.c (printchar, strout): Check for string overflow.
1789 (PRINTPREPARE, printchar, strout):
1790 Don't set size unless allocation succeeds.
1791
90532f02
PE
1792 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1793 for sizes. Check for string overflow more accurately.
1794 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1795
6d84508d
PE
1796 * macros.c: Integer and buffer overflow fixes.
1797 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1798 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1799 Use ptrdiff_t, not int, for sizes.
1800 Don't increment bufsize until after realloc succeeds.
1801 Check for size-calculation overflow.
1802 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1803
437b2cb4
PE
1804 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1805
8b9ac8b4
PE
1806 * lread.c: Integer overflow fixes.
1807 (read_integer): Radix is now EMACS_INT, not int,
1808 to improve quality of diagnostics for out-of-range radices.
1809 Calculate buffer size correctly for out-of-range radices.
1810 (read1): Check for integer overflow in radices, and in
1811 read-circle numbers.
82cb60d3
PE
1812 (read_escape): Avoid int overflow.
1813 (Fload, openp, read_buffer_size, read1)
1814 (substitute_object_recurse, read_vector, read_list, map_obarray):
1815 Use ptrdiff_t, not int, for sizes.
1816 (read1): Use EMACS_INT, not int, for sizes.
20270765 1817 Check for size overflow.
8b9ac8b4 1818
7fcccf1e
PE
1819 * image.c (cache_image): Check for size arithmetic overflow.
1820
bfbbd7e7
PE
1821 * lread.c: Integer overflow issues.
1822 (saved_doc_string_size, saved_doc_string_length)
1823 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1824 Now ptrdiff_t, not int.
1825 (read1): Don't assume doc string length fits in int. Check for
1826 out-of-range doc string lengths.
1827 (read_list): Don't assume file position fits in int.
39019e54 1828 (read_escape): Check for hex character overflow.
bfbbd7e7 1829
4e323265
LL
18302011-06-22 Leo Liu <sdl.web@gmail.com>
1831
1832 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1833 Move to minibuffer.el.
1834
85fece3e
PE
18352011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1836
20b84ce9 1837 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1838 The following patches are for when GLYPH_DEBUG && !XASSERT.
1839 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1840 * dispnew.c (flush_stdout):
1841 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1842 Mark as externally visible.
1843 * dispnew.c (check_window_matrix_pointers): Now static.
1844 * dispnew.c (window_to_frame_vpos):
1845 * xfns.c (unwind_create_frame):
1846 * xterm.c (x_check_font): Remove unused local.
1847 * scroll.c (CHECK_BOUNDS):
1848 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1849 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1850 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1851 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1852 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1853 Now static.
1854 (debug_method_add): Use va_list and vsprintf rather than relying
1855 on undefined behavior with wrong number of arguments.
1856 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1857 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1858 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1859 since we're not interested in debugging glyphs with old libraries.
1860 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1861 GCC 4.6.0's static checking.
1862
0766b489
PE
18632011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1864
31fd4b32
PE
1865 Integer overflow and signedness fixes (Bug#8873).
1866 A few related buffer overrun fixes, too.
1867
b79e8648
PE
1868 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1869
0766b489
PE
1870 * dispextern.h (struct face.stipple):
1871 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1872 (x_bitmap_mask, x_allocate_bitmap_record)
1873 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1874 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1875 (x_create_bitmap_from_xpm_data):
1876 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1877 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1878 (.bitmaps_last):
1879 * xfaces.c (load_pixmap):
1880 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1881 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1882 (.bitmaps_last, struct x_output.icon_bitmap):
1883 Use ptrdiff_t, not int, for bitmap indexes.
1884 (x_allocate_bitmap_record): Check for size overflow.
1885 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1886
b081724f
PE
1887 Use ptrdiff_t, not int, for overlay counts.
1888 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1889 * editfns.c (overlays_around, get_pos_property):
1890 * textprop.c (get_char_property_and_overlay):
1891 * xdisp.c (next_overlay_change, note_mouse_highlight):
1892 * xfaces.c (face_at_buffer_position):
21514da7
PE
1893 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1894 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1895 (Fnext_overlay_change, Fprevious_overlay_change)
1896 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1897 Use ptrdiff_t, not int, for sizes.
21514da7 1898 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1899
3de73e5e
PE
1900 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1901
2606c57b
PE
1902 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1903 (x_session_initialize): Do not assume string length fits in int.
1904
aaafe47a
PE
1905 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1906 This is unlikely, but can occur if DPI is outlandish.
1907
2674ddc8 1908 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1909 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1910
28154962
PE
1911 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1912 * xrdb.c (magic_file_p, search_magic_path):
1913 Omit last arg SUFFIX; it was always 0. All callers changed.
1914 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1915
7de51af5
PE
1916 * xfont.c (xfont_match): Avoid need for strlen.
1917
25ed6cc3
PE
1918 * xfns.c: Don't assume strlen fits in int.
1919 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1920
4eab31dd
PE
1921 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1922 not unsigned long, as we prefer signed integers. All callers changed.
1923 Detect integer overflow in repeat count.
1924 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1925 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1926
171e2a58
PE
1927 * termcap.c: Don't assume sizes fit in int and never overflow.
1928 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1929 (gobble_line): Check for size-calculation overflow.
1930
ad39faca 1931 * minibuf.c (Fread_buffer):
6e5bb2dc 1932 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1933 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1934 Don't assume string length fits in int.
1935
52c61c22 1936 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1937 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1938
b5b8c9e5
PE
1939 * font.c: Don't assume string length fits in int.
1940 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1941 Use ptrdiff_t, not int.
ccd6111c
PE
1942 (font_intern_prop): Don't assume string length fits in int.
1943 Don't assume integer property fits in fixnum.
1944 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1945
882f0d81 1946 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1947 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1948 Reformulate so as not to need the command string.
1949 Invoke gzip -cd rather than gunzip, as it's more portable.
1950 (lock_info_type, lock_file_1, lock_file):
1951 Don't assume pid_t and time_t fit in unsigned long.
1952 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1953 (current_lock_owner): Prefer signed type for sizes.
1954 Use memcpy, not strncpy, where memcpy is what is really wanted.
1955 Don't assume (via atoi) that time_t and pid_t fit in int.
1956 Check for time_t and/or pid_t out of range, e.g., via a network share.
1957 Don't alloca where an auto var works fine.
1958
93f4cf88
PE
1959 * fileio.c: Fix some integer overflow issues.
1960 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1961 Don't assume string length fits in int.
1962 (directory_file_name): Don't assume string length fits in long.
1963 (make_temp_name): Don't assume pid fits in int, or that its print
1964 length is less than 20.
1965
f3e92b69
PE
1966 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1967
1bfdaf10
PE
1968 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1969
35016e9a
PE
1970 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1971
3d1e65a1
PE
1972 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1973 We prefer signed integers, even for size calculations.
1974
0b963a93
PE
1975 * emacs.c: Don't assume string length fits in 'int'.
1976 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1977 (main): Don't invoke strlen when not needed.
1978
573f4b54
PE
1979 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1980 (XD_DEBUG_MESSAGE): Don't waste a byte.
1981
989f33ba
PE
1982 * callproc.c (getenv_internal_1, getenv_internal)
1983 (Fgetenv_internal):
965d34eb
PE
1984 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1985
e4d29b33
PE
1986 * lread.c (invalid_syntax): Omit length argument.
1987 All uses changed. This doesn't fix a bug, but it simplifies the
1988 code away from its former Hollerith-constant appearance, and it's
1989 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1990 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1991
eb49b136
PE
1992 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1993 This didn't break anything, but it didn't help either.
1994 It's confusing to put a bogus integer in a place where the actual
1995 value does not matter.
9f62aeb1 1996 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1997 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1998
15375a22
PE
1999 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2000 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2001 implementation.
b61cc01c
PE
2002 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2003 We prefer signed types, and the value cannot exceed the EMACS_INT
2004 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2005 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2006 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2007 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2008
53b2623d
PE
2009 * indent.c (sane_tab_width): New function.
2010 (current_column, scan_for_column, Findent_to, position_indentation)
2011 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2012 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2013
51cab52b 2014 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2015
f2ed8a70
PE
2016 * lisp.h (lint_assume): New macro.
2017 * composite.c (composition_gstring_put_cache):
2018 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2019
abe80cc6
PE
2020 * editfns.c, insdel.c:
2021 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2022
b02c740e
PE
2023 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2024
ebc96716
PE
2025 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2026
b4e50fa0 2027 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2028 Use much-faster test for byte-length change.
311d5d7c 2029 Don't assume string byte-length fits in 'int'.
a4cf38e4 2030 Check that character arg fits in 'int'.
85461888 2031 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2032
c0c1ee9f
PE
2033 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2034
a498d7f4
PE
2035 * fns.c (concat): Catch string overflow earlier.
2036 Do not rely on integer wraparound.
2037
51cab52b
PE
2038 * dispextern.h (struct it.overlay_strings_charpos)
2039 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2040 * xdisp.c (forward_to_next_line_start)
2041 (back_to_previous_visible_line_start)
2042 (reseat_at_next_visible_line_start, next_element_from_buffer):
2043 Don't arbitrarily truncate the value of 'selective' to int.
2044
76031fad
PE
2045 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2046
5eb55db9
PE
2047 * composite.c: Don't truncate sizes to 'int'.
2048 (composition_gstring_p, composition_reseat_it)
2049 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2050 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2051 not EMACS_UINT, for indexes.
5eb55db9 2052
0703a717
PE
2053 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2054
d6202519
PE
2055 * buffer.c: Include <verify.h>.
2056 (struct sortvec.priority, struct sortstr.priority):
8961a454 2057 Now EMACS_INT, not int.
c20998a7 2058 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2059 (struct sortstr.size, record_overlay_string)
2060 (struct sortstrlist.size, struct sortlist.used):
2061 Don't truncate size to int.
2062 (record_overlay_string): Check for size-calculation overflow.
d6202519 2063 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2064
d5a19415
JM
20652011-06-22 Jim Meyering <meyering@redhat.com>
2066
029529ac 2067 Don't leak an XBM-image-sized buffer
d5a19415
JM
2068 * image.c (xbm_load): Free the image buffer after using it.
2069
a9041e6c
PE
20702011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2071
2072 Port to Sun C.
2073 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2074 that Sun C diagnosed.
2075 * fns.c (secure_hash): Fix pointer signedness issue.
2076 * intervals.c (static_offset_intervals): New function.
2077 (offset_intervals): Use it.
2078
7f3f739f
LL
20792011-06-21 Leo Liu <sdl.web@gmail.com>
2080
2081 * deps.mk (fns.o):
2082 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2083 sha512.h.
2084
2085 * fns.c (secure_hash): Rename from crypto_hash_function and change
2086 the first arg to accept symbols.
5b66d427 2087 (Fsecure_hash): New primitive.
7f3f739f
LL
2088 (syms_of_fns): New symbols.
2089
76147d94
DD
20902011-06-20 Deniz Dogan <deniz@dogan.se>
2091
2092 * process.c (Fset_process_buffer): Clarify return value in
2093 docstring.
2094
7d7d0045
CY
20952011-06-18 Chong Yidong <cyd@stupidchicken.com>
2096
2097 * dispnew.c (add_window_display_history): Use BVAR.
2098
2099 * xdisp.c (debug_method_add): Use BVAR.
2100 (check_window_end, dump_glyph_matrix, dump_glyph)
2101 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2102
2103 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2104 Likewise.
2105
2106 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2107 check till after the cache is created in init_frame_faces.
2108
ff2bc410
SM
21092011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2110
2111 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2112
28177add
PE
21132011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2114
dd3482fe
PE
2115 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2116 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2117 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2118
393d71f3 2119 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2120 * fileio.c (Finsert_file_contents):
2121 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2122 Remove the old (too-loose) buffer overflow checks.
2123 They weren't needed, since make_gap checks for buffer overflow.
2124 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2125 The old code merely checked for Emacs fixnum overflow, and relied
2126 on undefined (wraparound) behavior. The new code avoids undefined
2127 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2128
2e6813b0 2129 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2130 Tune. Don't use wider integers than needed. Don't use alloca.
2131 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2132
599a9e4f
PE
2133 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2134
99561444
PE
2135 * insdel.c, lisp.h (buffer_overflow): New function.
2136 (insert_from_buffer_1, replace_range, replace_range_2):
2137 * insdel.c (make_gap_larger):
2138 * editfns.c (Finsert_char):
2139 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2140
28177add
PE
2141 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2142
e69dafad
PE
21432011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2144
a7af7fde 2145 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2146
b1c46f02
PE
2147 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2148 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2149
e69dafad
PE
2150 * fileio.c: Don't assume EMACS_INT fits in off_t.
2151 (emacs_lseek): New static function.
2152 (Finsert_file_contents, Fwrite_region): Use it.
2153 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2154
566684ea
PE
2155 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2156
e6966cd6
PE
2157 * fns.c: Don't overflow int when computing a list length.
2158 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2159 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2160 truncation on 64-bit hosts. Check for QUIT every
2161 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2162 faster and is responsive enough.
2163 (Flength): Report an error instead of overflowing an integer.
2164 (Fsafe_length): Return a float if the value is not representable
2165 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2166 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2167 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2168
dd0b0efb
PE
2169 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2170 (header_size, word_size): New constants.
2171 (allocate_vectorlike): Don't check size overflow here.
2172 (allocate_vector): Check it here instead, since this is the only
2173 caller of allocate_vectorlike that could cause overflow.
2174 Check that the new vector's length is representable as a fixnum.
2175
86fe5cfe
PE
2176 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2177 The previous code was bogus. For example, next_almost_prime (32)
2178 returned 39, which is undesirable as it is a multiple of 3; and
2179 next_almost_prime (24) returned 25, which is a multiple of 5 so
2180 why was the code bothering to check for multiples of 7?
2181
80e88859
PE
2182 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2183
4a2f0ad6
PE
2184 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2185
f66c7cf8
PE
2186 Variadic C functions now count arguments with ptrdiff_t.
2187 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2188 Back then I didn't know that the Emacs coding style prefers signed int.
2189 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2190 were being counted with int, which may truncate counts on 64-bit
2191 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2192 * lisp.h (struct Lisp_Subr.function.aMANY)
2193 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2194 Arg counts are now ptrdiff_t, not size_t.
2195 All variadic functions and their callers changed accordingly.
2196 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2197 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2198 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2199 * callint.c (Fcall_interactively): Check arg count for overflow,
2200 to avoid potential buffer overrun. Use signed char, not 'int',
2201 for 'varies' array, so that we needn't bother to check its size
2202 calculation for overflow.
2203 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2204 * eval.c (apply_lambda):
2205 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2206 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2207 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2208
a1759b76
PE
2209 * callint.c (Fcall_interactively): Don't use index var as event count.
2210
d96be9fc
PE
2211 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2212 * mem-limits.h (SIZE): Remove; no longer used.
2213
a690a978 2214 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2215
578c21e6
PE
2216 Remove unnecessary casts.
2217 * xterm.c (x_term_init):
2218 * xfns.c (x_set_border_pixel):
2219 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2220 These aren't needed now that we assume ANSI C.
2221
96f53c6c
PE
2222 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2223 It's more likely to cause problems (due to unsigned overflow)
2224 than to cure them.
2225
83c77d31
PE
2226 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2227
ee2079f1
PE
2228 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2229
6da65536
PE
2230 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2231
7147c4a4
PE
2232 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2233
193e32d9
PE
2234 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2235
e5533da6
PE
2236 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2237
9910e595
PE
2238 GLYPH_CODE_FACE returns EMACS_INT, not int.
2239 * dispextern.h (merge_faces):
2240 * xfaces.c (merge_faces):
01103c44
PE
2241 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2242 Don't assume EMACS_INT fits in int.
9910e595 2243
2638320e
PE
2244 * character.h (CHAR_VALID_P): Remove unused parameter.
2245 * fontset.c, lisp.h, xdisp.c: All uses changed.
2246
045eb8d9
PE
2247 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2248
c1f134b5
PE
2249 * fns.c (concat): Minor tuning based on overflow analysis.
2250 This doesn't fix any bugs. Use int to hold character, instead
2251 of constantly refetching from Emacs object. Use XFASTINT, not
2252 XINT, for value known to be a character. Don't bother comparing
2253 a single byte to 0400, as it's always less.
2254
395fcb93 2255 * floatfns.c (Fexpt):
327eeec8
PE
2256 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2257
abbd3d23
PE
2258 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2259 for characters.
2260
684a03ef
PE
2261 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2262
0fed43f3
PE
2263 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2264 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2265 incorrectly succeed when S was a string, because 4294967386 was
2266 truncated before it was used.
2267
8fd02eb7
PE
2268 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2269 Otherwise, an out-of-range integer could cause undefined behavior
2270 on a 64-bit host.
2271
f8c86b69
PE
2272 * composite.c: Use int, not EMACS_INT, for characters.
2273 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2274 EMACS_INT, for values that are known to be in character range.
2275 This doesn't fix any bugs but is the usual style inside Emacs and
2276 may generate better code on 32-bit machines.
2277
34206dd2
PE
2278 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2279 This is for reasons similar to the recent CHAR_STRING fix.
2280 * charset.c (Fencode_char): Check that character arg is actually
2281 a character. Pass an int to ENCODE_CHAR.
2282 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2283 wider than 'int', as a compile-time check to prevent future regressions
2284 in this area.
2285
c5958d4c 2286 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2287
2288 Make sure a 64-bit char is never passed to CHAR_STRING.
2289 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2290 by silently ignoring the top 32 bits, allowing some values
2291 that were far too large to be valid characters.
2292 * character.h: Include <verify.h>.
2293 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2294 arguments are no wider than unsigned, as a compile-time check
2295 to prevent future regressions in this area.
2296 * data.c (Faset):
01103c44 2297 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2298 (Fsubst_char_in_region):
2299 * fns.c (concat):
2300 * xdisp.c (decode_mode_spec_coding):
2301 Adjust to CHAR_STRING's new requirement.
2302 * editfns.c (Finsert_char, Fsubst_char_in_region):
2303 * fns.c (concat): Check that character args are actually
2304 characters. Without this test, these functions did the wrong
2305 thing with wildly out-of-range values on 64-bit hosts.
2306
d37ca623
PE
2307 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2308 These casts should not be needed on 32-bit hosts, either.
2309 * keyboard.c (read_char):
2310 * lread.c (Fload): Remove casts to unsigned.
2311
ea204efb
PE
2312 * lisp.h (UNSIGNED_CMP): New macro.
2313 This fixes comparison bugs on 64-bit hosts.
2314 (ASCII_CHAR_P): Use it.
2315 * casefiddle.c (casify_object):
01103c44 2316 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2317 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2318 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2319 * dispextern.h (FACE_FROM_ID):
2320 * keyboard.c (read_char): Use UNSIGNED_CMP.
2321
41cb286c
PE
2322 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2323 not to EMACS_INT, to avoid GCC warning.
2324
4a1b9832
PE
2325 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2326
55daad71
PE
2327 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2328 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2329 isn't needed on 32-bit machines.
8f95c75c 2330
01103c44
PE
2331 * buffer.c (Fgenerate_new_buffer_name):
2332 Use EMACS_INT for count, not int.
0ceccced 2333 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2334
2335 * data.c (Qcompiled_function): Now static.
2336
c6f072e7
PE
2337 * window.c (window_body_lines): Now static.
2338
20ce5912
PE
2339 * image.c (gif_load): Rename local to avoid shadowing.
2340
9c4c5f81
PE
2341 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2342 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2343 * alloc.c (make_save_value): Integer argument is now of type
2344 ptrdiff_t, not int.
2345 (mark_object): Use ptrdiff_t, not int.
2346 * lisp.h (pD): New macro.
2347 * print.c (print_object): Use it.
2348
c0c5c8ae
PE
2349 * alloc.c: Use EMACS_INT, not int, to count objects.
2350 (total_conses, total_markers, total_symbols, total_vector_size)
2351 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2352 (total_free_floats, total_floats, total_free_intervals)
2353 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2354 Now EMACS_INT, not int. All uses changed.
2355 (Fgarbage_collect): Compute overall total using a double, so that
2356 integer overflow is less likely to be a problem. Check for overflow
2357 when converting back to an integer.
5a25e253
PE
2358 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2359 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2360 These were 'int' variables that could overflow on 64-bit hosts;
2361 they were never used, so remove them instead of repairing them.
211a0b2a 2362 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2363 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2364 Previously, this ceilinged at INT_MAX, but that doesn't work on
2365 64-bit machines.
e46bb31a 2366 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2367
c78baabf 2368 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2369 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2370 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2371 when a (possibly-narrower) signed value would do just as well.
2372 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2373
c9d624c6
PE
2374 * alloc.c: Catch some string size overflows that we were missing.
2375 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2376 for convenience in STRING_BYTES_MAX.
2377 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2378 The definition here is exact; the one in lisp.h was approximate.
2379 (allocate_string_data): Check for string overflow. This catches
2380 some instances we weren't catching before. Also, it catches
2381 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2382 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2383 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2384
c9d624c6
PE
2385 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2386 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2387 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2388
353032ce
PE
2389 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2390
2bccce07
PE
2391 * alloc.c (Fmake_string): Check for out-of-range init.
2392
0ac30604
SM
23932011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2394
2395 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2396
c195f2de
JD
23972011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2398
2399 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2400 xg_get_default_scrollbar_width.
2401
2402 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2403 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2404 (style_changed_cb): Call update_theme_scrollbar_width and call
2405 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2406 all frames (Bug#8505).
2407 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2408 Call gtk_window_set_resizable if HAVE_GTK3.
2409 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2410 and height if HAVE_GTK3 (Bug#8505).
2411 (scroll_bar_width_for_theme): New variable.
2412 (update_theme_scrollbar_width): New function.
2413 (xg_get_default_scrollbar_width): Move code to
2414 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2415 (xg_initialize): Call update_theme_scrollbar_width.
2416
2417 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2418
2419 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2420
e10ac9f1
MR
24212011-06-12 Martin Rudalics <rudalics@gmx.at>
2422
2423 * frame.c (make_frame): Call other_buffer_safely instead of
2424 other_buffer.
2425
2426 * window.c (temp_output_buffer_show): Call display_buffer with
2427 second argument Vtemp_buffer_show_specifiers and reset latter
2428 immediately after the call.
2429 (Vtemp_buffer_show_specifiers): New variable.
2430 (auto_window_vscroll_p, next_screen_context_lines)
2431 (Vscroll_preserve_screen_position): Remove leading asterisks from
2432 doc-strings.
2433
2d3c217e 24342011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2435
7b7f97e8 2436 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2437 * buffer.c (Qclone_number): Remove for now, as it's unused.
2438 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2439 (record_buffer): Remove unused local.
2440 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2441 (set_frame_buffer_list): Remove; unused.
2442 * frame.h (other_visible_frames): Remove decl.
2443 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2444 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2445 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2446 if HAVE_GPM.
2447 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2448 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2449 Define only if HAVE_GPM.
2450 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2451 (update_hints_inhibit): Remove; never set. All uses removed.
2452 * widgetprv.h (emacsFrameClassRec): Remove decl.
2453 * window.c (delete_deletable_window): Now returns void, since it
2454 wasn't returning anything.
2455 (compare_window_configurations): Remove unused locals.
2456 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2457 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2458 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2459 the same widths as pointers. This follows up on the 2011-05-06 patch.
2460 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2461 * xterm.h: Likewise.
2462 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2463
1384b89e
JB
24642011-06-12 Juanma Barranquero <lekktu@gmail.com>
2465
2466 * makefile.w32-in: Update dependencies.
2467 (LISP_H): Add lib/intprops.h.
2468
1100a63c
CY
24692011-06-11 Chong Yidong <cyd@stupidchicken.com>
2470
2471 * image.c (gif_load): Add animation frame delay to the metadata.
2472 (syms_of_image): Use DEFSYM. New symbol `delay'.
2473
6198ccd0
MR
24742011-06-11 Martin Rudalics <rudalics@gmx.at>
2475
2476 * window.c (delete_deletable_window): Re-add.
2477 (Fset_window_configuration): Rewrite to handle dead buffers and
2478 consequently deletable windows.
2479 (window_tree, Fwindow_tree): Remove. Supply functionality in
2480 window.el.
2481 (compare_window_configurations): Simplify code.
2482
b6e3633c
AS
24832011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2484
1ab0dee5
AS
2485 * image.c (imagemagick_load_image): Fix type mismatch.
2486 (Fimagemagick_types): Likewise.
2487
b6e3633c
AS
2488 * window.h (replace_buffer_in_windows): Declare.
2489
9397e56f
MR
24902011-06-11 Martin Rudalics <rudalics@gmx.at>
2491
2492 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2493 Qclone_number. Remove external declaration of Qdelete_window.
2494 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2495 code.
640c8776
SM
2496 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2497 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2498 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2499 buffer list implementation.
2500 (other_buffer_safely): New function.
2501 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2502 calls to replace_buffer_in_windows and
2503 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2504 if allowed.
2505 (record_buffer): Inhibit quitting and rewrite using quittable
2506 functions. Run Qbuffer_list_update_hook if allowed.
2507 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2508 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2509 Move switch-to-buffer to window.el.
9397e56f
MR
2510 (bury-buffer): Move to window.el.
2511 (Vbuffer_list_update_hook): New variable.
2512
2513 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2514 section.
2515
2516 * window.h (resize_frame_windows): Move up in code.
2517 (Fwindow_frame): Remove EXFUN.
2518 (replace_buffer_in_all_windows): Remove prototype.
2519 (replace_buffer_in_windows_safely): Add prototype.
2520
2521 * window.c: Declare Qdelete_window static again. Move down
2522 declaration of select_count.
2523 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2524 (Fother_window): Move to window.el.
2525 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2526 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2527 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2528 window.el.
2529 (replace_buffer_in_windows): Implement by calling
2530 Qreplace_buffer_in_windows.
2531 (replace_buffer_in_all_windows): Remove with some functionality
2532 moved into replace_buffer_in_windows_safely.
2533 (replace_buffer_in_windows_safely): New function.
2534 (select_window_norecord, select_frame_norecord): Move in front
2535 of run_window_configuration_change_hook. Remove now obsolete
2536 declarations.
640c8776
SM
2537 (Fset_window_buffer): Rewrite doc-string.
2538 Call Qrecord_window_buffer.
9397e56f
MR
2539 (keys_of_window): Move binding for other-window to window.el.
2540
b50691aa
CY
25412011-06-11 Chong Yidong <cyd@stupidchicken.com>
2542
2543 * dispextern.h (struct image): Replace data member, whose int_val
2544 and ptr_val fields were not used by anything, with a single
2545 lisp_val object.
2546
2547 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2548 (gif_clear_image, gif_load, imagemagick_load_image)
2549 (gs_clear_image, gs_load): Callers changed.
2550
3f754b86
PE
25512011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2552
cca69397
PE
2553 * buffer.h: Include <time.h>, for time_t.
2554 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2555
109e28d0
PE
2556 Fix minor problems found by static checking.
2557
60737f02
PE
2558 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2559
4b66faf3
PE
2560 Make identifiers static if they are not used in other modules.
2561 * data.c (Qcompiled_function, Qframe, Qvector):
2562 * image.c (QimageMagick, Qsvg):
2563 * minibuf.c (Qmetadata):
2564 * window.c (resize_window_check, resize_root_window): Now static.
2565 * window.h (resize_window_check, resize_root_window): Remove decls.
2566
109e28d0
PE
2567 * window.c (window_deletion_count, delete_deletable_window):
2568 Remove; unused.
46a4ce9e
PE
2569 (window_body_lines): Now static.
2570 (Fdelete_other_windows_internal): Mark vars as initialized.
2571 Make sure 'resize_failed' is initialized.
2572 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2573 (resize_window_apply): Remove unused local.
2574 * window.h (delete_deletable_window): Remove decl.
2575
109e28d0 2576 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2577 (imagemagick_load_image): Fix pointer signedness problem by changing
2578 last arg from unsigned char * to char *. All uses changed.
2579 Also, fix a local for similar reasons.
2580 Remove unused locals. Remove locals to avoid shadowing.
2581 (fn_rsvg_handle_free): Remove; unused.
2582 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2583 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2584
3f754b86
PE
2585 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2586
2547adb1
CY
25872011-06-10 Chong Yidong <cyd@stupidchicken.com>
2588
2589 * image.c (gif_load): Fix omitted cast error introduced by
2590 2011-06-06 change.
2591
2c8e37d4
MR
25922011-06-10 Martin Rudalics <rudalics@gmx.at>
2593
2594 * window.h (resize_proportionally, orig_total_lines)
2595 (orig_top_line): Remove from window structure.
2596 (set_window_height, set_window_width, change_window_heights)
2597 (Fdelete_window): Remove prototypes.
2598 (resize_frame_windows): Remove duplicate declaration.
2599
440a42e3
EZ
26002011-06-10 Eli Zaretskii <eliz@gnu.org>
2601
2602 * window.h (resize_frame_windows, resize_window_check)
2603 (delete_deletable_window, resize_root_window)
2604 (resize_frame_windows): Declare prototypes.
2605
2606 * window.c (resize_window_apply): Make definition be "static" to
2607 match the prototype.
2608
562dd5e9
MR
26092011-06-10 Martin Rudalics <rudalics@gmx.at>
2610
2611 * window.c: Remove declarations of Qwindow_size_fixed,
2612 window_min_size_1, window_min_size_2, window_min_size,
2613 size_window, window_fixed_size_p, enlarge_window, delete_window.
2614 Remove static from declaration of Qdelete_window, it's
2615 temporarily needed by Fbury_buffer.
2616 (replace_window): Don't assign orig_top_line and
2617 orig_total_lines.
2618 (Fdelete_window, delete_window): Remove. Window deletion is
2619 handled by window.el.
640c8776
SM
2620 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2621 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2622 (Fdelete_other_windows): Remove. Deleting other windows is
2623 handled by window.el.
2624 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2625 handled in window.el.
2626 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2627 Window minimum sizes are handled in window.el.
2628 (shrink_windows, size_window, set_window_height)
2629 (set_window_width, change_window_heights, window_height)
2630 (window_width, CURBEG, CURSIZE, enlarge_window)
2631 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2632 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2633 handled in window.el.
2634 (make_dummy_parent): Rename to make_parent_window and give it a
2635 second argument horflag.
2636 (make_window): Don't set resize_proportionally any more.
2637 (Fsplit_window): Remove. Windows are split in window.el.
2638 (save_restore_action, save_restore_orig_size)
2639 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2640 Resize mini windows in window.el.
2641 (grow_mini_window, shrink_mini_window): Implement by calling
2642 Qresize_root_window_vertically, resize_window_check and
2643 resize_window_apply.
640c8776
SM
2644 (saved_window, Fset_window_configuration, save_window_save):
2645 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2646 resize_proportionally.
2647 (window_min_height, window_min_width): Move to window.el.
2648 (keys_of_window): Move bindings for delete-other-windows,
2649 split-window, delete-window and enlarge-window to window.el.
2650
2651 * buffer.c: Temporarily extern Qdelete_window.
2652 (Fbury_buffer): Temporarily call Qdelete_window instead of
2653 Fdelete_window (Fbury_buffer will move to window.el soon).
2654
2655 * frame.c (set_menu_bar_lines_1): Remove code handling
2656 orig_top_line and orig_total_lines.
2657
2658 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2659 set_window_height but set heights directly.
2660 (change_frame_size_1): Use resize_frame_windows.
2661
2662 * xdisp.c (init_xdisp): Don't use set_window_height but set
2663 heights directly.
2664
640c8776
SM
2665 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2666 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2667 run_window_configuration_change_hook.
2668
2669 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2670 instead of change_window_heights and run
2671 run_window_configuration_change_hook.
2672
1a13852e
MR
26732011-06-09 Martin Rudalics <rudalics@gmx.at>
2674
2675 * window.c (replace_window): Rename second argument REPLACEMENT to
2676 NEW. New third argument SETFLAG. Rewrite.
2677 (delete_window, make_dummy_parent): Call replace_window with
2678 third argument 1.
2679 (window_list_1): Move down in code.
2680 (run_window_configuration_change_hook): Move set_buffer part
2681 before select_frame_norecord part in order to unwind correctly.
2682 Rename count1 to count.
2683 (recombine_windows, delete_deletable_window, resize_root_window)
2684 (Fdelete_other_windows_internal)
2685 (Frun_window_configuration_change_hook, make_parent_window)
2686 (resize_window_check, resize_window_apply, Fresize_window_apply)
2687 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2688 (Fdelete_window_internal, Fresize_mini_window_internal):
2689 New functions.
1a13852e
MR
2690 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2691
f3d1777e
MR
26922011-06-08 Martin Rudalics <rudalics@gmx.at>
2693
496e208e
MR
2694 * window.h (window): Add some new members to window structure -
2695 normal_lines, normal_cols, new_total, new_normal, clone_number,
2696 splits, nest, prev_buffers, next_buffers.
2697 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2698 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2699
f3d1777e
MR
2700 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2701 Remove.
496e208e
MR
2702 (make_dummy_parent): Set new members of windows structure.
2703 (make_window): Move down in code. Handle new members of window
2704 structure.
2705 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2706 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2707 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2708 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2709 (Fset_window_next_buffers, Fset_window_clone_number):
2710 New functions.
496e208e
MR
2711 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2712 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2713 Doc-string fixes.
2714 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2715 Argument WINDOW can be now internal window too.
2716 (Fwindow_use_time): Move up in code.
2717 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2718 Rewrite doc-string.
2719 (Fset_window_configuration, saved_window)
2720 (Fcurrent_window_configuration, save_window_save): Handle new
2721 members of window structure.
b9e809c2
MR
2722 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2723 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2724 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2725 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2726 Qget_mru_window, Qresize_root_window,
2727 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2728 Qauto_buffer_name; staticpro them.
f3d1777e 2729
abde8f8c
MR
27302011-06-07 Martin Rudalics <rudalics@gmx.at>
2731
2732 * window.c (Fwindow_total_size, Fwindow_left_column)
2733 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2734 (Fwindow_list_1): New functions.
2735 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2736 (Fwindow_width, Fscroll_left, Fscroll_right):
2737 Use window_body_cols instead of window_box_text_cols.
2738 (delete_window, Fset_window_configuration):
2739 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
2740 (delete_all_subwindows): Take a window as argument and not a
2741 structure. Rewrite.
190b47e6
MR
2742 (window_loop): Remove handling of GET_LRU_WINDOW and
2743 GET_LARGEST_WINDOW.
2744 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2745
2746 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2747 window_box_text_cols. delete_all_subwindows now takes a
2748 Lisp_Object as argument.
abde8f8c 2749
640c8776
SM
2750 * indent.c (compute_motion, Fcompute_motion):
2751 Use window_body_cols instead of window_box_text_cols.
abde8f8c 2752
fa8a67e6
MR
2753 * frame.c (delete_frame): Call delete_all_subwindows with root
2754 window as argument.
2755
a54e3482
DC
27562011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2757
2758 * fns.c (Fputhash): Document return value.
2759
60002bf5
CY
27602011-06-06 Chong Yidong <cyd@stupidchicken.com>
2761
2762 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2763
0c671da6 27642011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2765
b862a52a 2766 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2767
be44ca6c
PE
2768 Check for overflow when converting integer to cons and back.
2769 * charset.c (Fdefine_charset_internal, Fdecode_char):
2770 Use cons_to_unsigned to catch overflow.
2771 (Fencode_char): Use INTEGER_TO_CONS.
2772 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2773 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2774 * data.c (long_to_cons, cons_to_long): Remove.
2775 (cons_to_unsigned, cons_to_signed): New functions.
2776 These signal an error for invalid or out-of-range values.
2777 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2778 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2779 * font.c (Ffont_variation_glyphs):
2780 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2781 * lisp.h: Include <intprops.h>.
2782 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2783 (cons_to_signed, cons_to_unsigned): New decls.
2784 (long_to_cons, cons_to_long): Remove decls.
2785 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2786 (Fprimitive_undo): Use CONS_TO_INTEGER.
2787 * xfns.c (Fx_window_property): Likewise.
2788 * xselect.c: Include <limits.h>.
2789 (x_own_selection, selection_data_to_lisp_data):
2790 Use INTEGER_TO_CONS.
2791 (x_handle_selection_request, x_handle_selection_clear)
2792 (x_get_foreign_selection, Fx_disown_selection_internal)
2793 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2794 (lisp_data_to_selection_data): Use cons_to_unsigned.
2795 (x_fill_property_data): Use cons_to_signed.
2796 Report values out of range.
2797
d1f3d2af
PE
2798 Check for buffer and string overflow more precisely.
2799 * buffer.h (BUF_BYTES_MAX): New macro.
2800 * lisp.h (STRING_BYTES_MAX): New macro.
2801 * alloc.c (Fmake_string):
2802 * character.c (string_escape_byte8):
2803 * coding.c (coding_alloc_by_realloc):
2804 * doprnt.c (doprnt):
2805 * editfns.c (Fformat):
2806 * eval.c (verror):
2807 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2808 since they may not be the same number.
2809 * editfns.c (Finsert_char):
2810 * fileio.c (Finsert_file_contents):
2811 Likewise for BUF_BYTES_MAX.
2812
dd52fcea
PE
2813 * image.c: Use ptrdiff_t, not int, for sizes.
2814 (slurp_file): Switch from int to ptrdiff_t.
2815 All uses changed.
2816 (slurp_file): Check that file size fits in both size_t (for
2817 malloc) and ptrdiff_t (for sanity and safety).
2818
7f9bbdbb
PE
2819 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2820 if b->modtime has its maximal value.
2821
dfe18f82
PE
2822 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2823
84acfcf0
PE
2824 Don't assume time_t can fit into int.
2825 * buffer.h (struct buffer.modtime): Now time_t, not int.
2826 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2827 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2828
ccd9a01a
PE
2829 Minor fixes for signed vs unsigned integers.
2830 * character.h (MAYBE_UNIFY_CHAR):
2831 * charset.c (maybe_unify_char):
2832 * keyboard.c (read_char, reorder_modifiers):
2833 XINT -> XFASTINT, since the integer must be nonnegative.
2834 * ftfont.c (ftfont_spec_pattern):
2835 * keymap.c (access_keymap, silly_event_symbol_error):
2836 XUINT -> XFASTINT, since the integer must be nonnegative.
2837 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2838 since it makes no difference and we prefer signed.
2839 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2840 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2841 nonnegative.
2842
d6d100dd
SM
28432011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2844
2845 * window.h (Fwindow_frame): Declare.
2846
2b6148e4
PE
28472011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2848
2849 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2850 (SPARE_MEMORY): Always define.
2851 (LARGE_REQUEST): Remove.
2852 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2853
f230ecc9
MR
28542011-06-06 Martin Rudalics <rudalics@gmx.at>
2855
727e958e
MR
2856 * lisp.h: Move EXFUNS for Fframe_root_window,
2857 Fframe_first_window and Fset_frame_selected_window to window.h.
2858
2859 * window.h: Move EXFUNS for Fframe_root_window,
2860 Fframe_first_window and Fset_frame_selected_window here from
2861 lisp.h.
2862
2863 * frame.c (Fwindow_frame, Fframe_first_window)
2864 (Fframe_root_window, Fframe_selected_window)
2865 (Fset_frame_selected_window): Move to window.c.
2866 (Factive_minibuffer_window): Move to minibuf.c.
2867 (Fother_visible_frames_p): New function.
2868
2869 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2870
f230ecc9
MR
2871 * window.c (decode_window, decode_any_window): Move up in code.
2872 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2873 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2874 (Fwindow_buffer): Move up and rewrite doc-string.
2875 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2876 (Fwindow_prev): New functions.
727e958e
MR
2877 (Fwindow_frame): Move here from frame.c. Accept any window as
2878 argument.
2879 (Fframe_root_window, Fframe_first_window)
2880 (Fframe_selected_window): Move here from frame.c. Accept frame
2881 or arbitrary window as argument. Update doc-strings.
2882 (Fminibuffer_window): Move up in code.
2883 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2884 (Fset_frame_selected_window): Move here from frame.c.
2885 Marginal rewrite.
727e958e
MR
2886 (Fselected_window, select_window, Fselect_window): Move up in
2887 code. Minor doc-string fixes.
f230ecc9 2888
4d09bcf6
PE
28892011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2890
2891 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2892 Do not assume that spare memory exists; that assumption is valid
2893 only if SYSTEM_MALLOC.
2894 (LARGE_REQUEST): New macro, so that the issue of large requests
2895 is separated from the issue of spare memory.
2896
810928a2
AS
28972011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2898
172418ad
AS
2899 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2900 format. (Bug#8806)
2901
43f862f7
AS
2902 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2903
810928a2
AS
2904 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2905 before statements.
2906
a059fe24
JD
29072011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2908
2909 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2910
2911 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2912
2913 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2914 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2915
989bf368
JB
29162011-06-05 Juanma Barranquero <lekktu@gmail.com>
2917
2918 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2919
4b80f674
CY
29202011-06-04 Chong Yidong <cyd@stupidchicken.com>
2921
2922 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2923 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2924 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2925 New error handlers.
4b80f674
CY
2926 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2927 Obey Vx_select_enable_clipboard_manager. Catch errors in
2928 x_clipboard_manager_save (Bug#8779).
2929 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2930 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2931
99a33b77 29322011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2933
2934 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2935
99a33b77 29362011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2937
2938 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2939 in the current matrix if keep_current_p is non-zero.
2940
8264569d
EZ
29412011-06-04 Eli Zaretskii <eliz@gnu.org>
2942
2943 * bidi.c (bidi_level_of_next_char): Fix last change.
2944
57f97249
EZ
29452011-06-03 Eli Zaretskii <eliz@gnu.org>
2946
fec2107c 2947 Support bidi reordering of text covered by display properties.
57f97249 2948
fec2107c
EZ
2949 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2950 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2951 (bidi_cache_search, bidi_cache_iterator_state)
2952 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2953 (bidi_level_of_next_char, bidi_move_to_visually_next):
2954 Support character positions inside a run of characters covered by a
fec2107c
EZ
2955 display string.
2956 (bidi_paragraph_init, bidi_resolve_explicit_1)
2957 (bidi_level_of_next_char): Call bidi_fetch_char and
2958 bidi_fetch_char_advance instead of FETCH_CHAR and
2959 FETCH_CHAR_ADVANCE.
2960 (bidi_init_it): Initialize new members.
2961 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2962 definitions.
2963 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2964 instead of using explicit *_CHAR codes.
d6d100dd
SM
2965 (bidi_resolve_explicit, bidi_resolve_weak):
2966 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2967 bidirectional text is supported only in multibyte buffers.
2968 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2969 it to initialize the frame_window_p member of struct bidi_it.
2970 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2971 (bidi_resolve_explicit, bidi_resolve_weak)
2972 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2973 bidi_it->nchars is non-positive.
2974 (bidi_level_of_next_char): Don't try to lookup the cache for the
2975 next/previous character if nothing is cached there yet, or if we
2976 were just reseat()'ed to a new position.
c40e2fb2 2977
0e14fe90
EZ
2978 * xdisp.c (set_cursor_from_row): Set start and stop points
2979 according to the row's direction when priming the loop that looks
2980 for the glyph on which to display cursor.
2981 (single_display_spec_intangible_p): Function deleted.
2982 (display_prop_intangible_p): Reimplement to call
2983 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2984 Accept 3 additional arguments needed by handle_display_spec.
2985 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2986 values: lists, `(when COND...)' forms, etc.
2987 (single_display_spec_string_p): Support property values that are
2988 lists with the argument STRING its top-level element.
2989 (display_prop_string_p): Fix the condition for processing a
2990 property that is a list to be consistent with handle_display_spec.
fec2107c 2991 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2992 last portion of handle_display_prop.
2993 (compute_display_string_pos): Accept additional argument
2994 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2995 value of a `display' property is a "replacing spec".
2996 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2997 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2998 the display property, but just return a value indicating whether
2999 the display property will replace the characters it covers.
3000 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3001 frame_window_p members of struct bidi_it.
d6d100dd
SM
3002 (compute_display_string_pos, compute_display_string_end):
3003 New functions.
fec2107c
EZ
3004 (push_it): Accept second argument POSITION, where pop_it should
3005 jump to continue iteration.
3006 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3007
fec2107c
EZ
3008 * keyboard.c (adjust_point_for_property): Adjust the call to
3009 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3010
3011 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3012 (bidi_init_it): Update prototypes.
3013 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3014 (compute_display_string_pos, compute_display_string_end):
3015 Declare prototypes.
fec2107c
EZ
3016 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3017 EMACS_INT.
fc6f18ce 3018
40087514 30192011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3020
57f53182
PE
3021 Malloc failure behavior now depends on size of allocation.
3022 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3023 * lisp.h: Change signatures accordingly.
3024 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3025 All callers changed. (Bug#8762)
3026
3027 * gnutls.c: Use Emacs's memory allocators.
3028 Without this change, the gnutls library would invoke malloc etc.
3029 directly, which causes problems on non-SYNC_INPUT hosts, and which
3030 runs afoul of improving memory_full behavior. (Bug#8761)
3031 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3032 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3033 xfree instead of the default malloc, realloc, free.
3034 (Fgnutls_boot): No need to check for memory allocation failure,
3035 since xmalloc does that for us.
3036
ac32cd99 3037 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3038 * category.c (hash_get_category_set):
3039 * ccl.c (ccl_driver):
3040 * charset.c (Fdefine_charset_internal):
3041 * charset.h (struct charset.hash_index):
3042 * composite.c (get_composition_id, gstring_lookup_cache)
3043 (composition_gstring_put_cache):
3044 * composite.h (struct composition.hash_index):
3045 * dispextern.h (struct image.hash):
3046 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3047 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3048 (hashfn_equal, hashfn_user_defined, make_hash_table)
3049 (maybe_resize_hash_table, hash_lookup, hash_put)
3050 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3051 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3052 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3053 * image.c (make_image, search_image_cache, lookup_image)
3054 (xpm_put_color_table_h):
3055 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3056 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3057 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3058 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3059 * alloc.c (allocate_vectorlike):
3060 Check for overflow in vector size calculations.
3061 * ccl.c (ccl_driver):
3062 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3063 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3064 need to be updated by these changes.
40087514
PE
3065 * fns.c (make_hash_table, maybe_resize_hash_table):
3066 Check for integer overflow with large hash tables.
0de4bb68
PE
3067 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3068 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3069 (SXHASH_REDUCE): New macro.
3070 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3071 Use it instead of discarding useful hash info with large hash values.
3072 (sxhash_float): New function.
3073 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3074 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3075 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3076 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3077 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3078 Adjust signatures to match updated version of code.
3079 (consing_since_gc): Now EMACS_INT, since a single hash table can
3080 use more than INT_MAX bytes.
3081
698d32e2
DN
30822011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3083
3084 Make it possible to build with GCC-4.6+ -O2 -flto.
3085
3086 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3087
fd6fa53f
SM
30882011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3089
3090 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3091 Call minibuffer-inactive-mode.
3092
864db017
JB
30932011-05-31 Juanma Barranquero <lekktu@gmail.com>
3094
3095 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3096 Update dependencies.
3097
2ad0baf4
DN
30982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3099
3100 * data.c (init_data): Remove code for UTS, this system is not
3101 supported anymore.
3102
4fcc2638
DN
31032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3104
3105 Don't force ./temacs to start in terminal mode.
3106
3107 * frame.c (make_initial_frame): Initialize faces in all cases, not
3108 only when CANNOT_DUMP is defined.
3109 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3110
c56e0fd5
DN
31112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3112
3113 * dispnew.c (add_window_display_history): Use const for the string
3114 pointer. Remove declaration, not needed.
3115
333d54da 31162011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3117
55d4c1b2 3118 Use 'inline', not 'INLINE'.
333d54da 3119 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3120 * alloc.c, fontset.c (INLINE): Remove.
3121 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3122 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3123 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3124 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3125 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3126
738db178
DN
31272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3128
3129 Make it possible to run ./temacs.
3130
3131 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3132 syms_of_callproc does the same thing. Remove test for
3133 "initialized", do it in the caller.
3134 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3135
620c53a6
SM
31362011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3137
3138 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3139 (read_minibuf): Use get_minibuffer.
3140 (syms_of_minibuf): Use DEFSYM.
3141 (Qmetadata): New var.
3142 * data.c (Qbuffer): Don't make it static.
3143 (syms_of_data): Use DEFSYM.
3144
e003a292
PE
31452011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3146
3147 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3148 (CCL_CODE_MIN): New macro.
3149
ed008a6d
PE
31502011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3151
3687c2ef
PE
3152 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3153
ed008a6d
PE
3154 * eval.c (Qdebug): Now static.
3155 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3156 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3157 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3158
d66c4c7c
CY
31592011-05-29 Chong Yidong <cyd@stupidchicken.com>
3160
3161 * image.c: Various fixes to ImageMagick code comments.
3162 (Fimagemagick_types): Doc fix.
3163
5fbc2025
PE
31642011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3165
0196f88a
PE
3166 Minor fixes prompted by GCC 4.6.0 warnings.
3167
3168 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3169
5fbc2025
PE
3170 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3171 (x_clipboard_manager_save_all): Move extern decl to ...
3172 * xterm.h: ... here, so that it can be checked for consistency.
3173
1dd3c2d9
CY
31742011-05-29 Chong Yidong <cyd@stupidchicken.com>
3175
3176 * xselect.c (x_clipboard_manager_save_frame)
3177 (x_clipboard_manager_save_all): New functions.
3178 (Fx_clipboard_manager_save): Lisp function deleted.
3179
3180 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3181 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3182
3183 * xterm.h: Update prototype.
3184
5ba6571d
WX
31852011-05-28 William Xu <william.xwl@gmail.com>
3186
3187 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3188 exiting (Bug#8239).
3189
3eaff834
JM
31902011-05-28 Jim Meyering <meyering@redhat.com>
3191
e1900994 3192 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3193 * fns.c (to_uchar): Define.
3194 (crypto_hash_function): Use it to convert some newly-signed
3195 variables to unsigned, to avoid sign-extension bugs. For example,
3196 without this change, (md5 "truc") would evaluate to
3197 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3198 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3199 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3200
0f6990a7
PE
32012011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3202
3203 Integer overflow fixes.
c8a9ca5a 3204
08686060
PE
3205 * dbusbind.c: Serial number integer overflow fixes.
3206 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3207 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3208 to hold a serial number that is too large for a fixnum.
3209 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3210 Check for serial numbers out of range. Decode any serial number
59568bf0 3211 that was so large that it became a float. (Bug#8722)
08686060 3212
2d1fc3c7
PE
3213 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3214 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3215 Use XFASTINT rather than XUINT when numbers are nonnegative.
3216 (xd_append_arg, Fdbus_method_return_internal):
3217 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3218 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3219 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3220 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3221 (Bug#8722)
2d1fc3c7 3222
c8a9ca5a
PE
3223 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3224
519e1d69
PE
3225 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3226
30569699
PE
3227 ccl: add integer overflow checks
3228 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3229 (IN_INT_RANGE): New macros.
3230 (ccl_driver): Use them to check for integer overflow when
3231 decoding a CCL program. Many of the new checks are whether XINT (x)
3232 fits in int; it doesn't always, on 64-bit hosts. The new version
3233 doesn't catch all possible integer overflows, but it's an
847044ea 3234 improvement. (Bug#8719)
30569699 3235
c11285dc
PE
3236 * alloc.c (make_event_array): Use XINT, not XUINT.
3237 There's no need for unsigned here.
3238
fdccd48e
PE
3239 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3240 This follows up to the 2011-05-06 change that substituted uintptr_t
3241 for EMACS_INT. This case wasn't caught back then.
3242
37910ab2
PE
3243 Rework Fformat to avoid integer overflow issues.
3244 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3245 now (part of C89). Include <verify.h>.
3246 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3247 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3248 (Fformat): Avoid the prepass trying to compute sizes; it was only
3249 approximate and thus did not catch overflow reliably. Instead, walk
3250 through the format just once, formatting and computing sizes as we go,
3251 checking for integer overflow at every step, and allocating a larger
3252 buffer as needed. Keep track separately whether the format is
3253 multibyte. Keep only the most-recently calculated precision, rather
3254 than them all. Record whether each argument has been converted to
3255 string. Use EMACS_INT, not int, for byte and char and arg counts.
3256 Support field widths and precisions larger than INT_MAX. Avoid
3257 sprintf's undefined behavior with conversion specifications such as %#d
3258 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3259 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3260 formatting out-of-range floating point numbers with int
9173deec 3261 formats. (Bug#8668)
37910ab2 3262
2e6578fb
PE
3263 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3264
0ae6bdee
PE
3265 * data.c: Avoid integer truncation in expressions involving floats.
3266 * data.c: Include <intprops.h>.
3267 (arith_driver): When there's an integer overflow in an expression
3268 involving floating point, convert the integers to floating point
3269 so that the resulting value does not suffer from catastrophic
3270 integer truncation. For example, on a 64-bit host (* 4
3271 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3272 Do not rely on undefined behavior after integer overflow.
3273
de883a70
PE
3274 merge count_size_as_multibyte, parse_str_to_multibyte
3275 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3276 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3277 Check for integer overflow.
3278 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3279 since it's now a duplicate of the other. This is more of
3280 a character than a buffer op, so better that it's in character.c.
3281 * fns.c, print.c: Adjust to above changes.
3282
2ff916cb
PE
32832011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3284
3285 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3286
f1b54466
PE
32872011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3288
fb1ac845
PE
3289 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3290 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3291 (x_clipboard_manager_save): Now static.
3292 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3293
f1b54466
PE
3294 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3295 (crypto_hash_function): Now static.
3296 Fix pointer signedness problems. Avoid unnecessary initializations.
3297
a9f737ee
CY
32982011-05-27 Chong Yidong <cyd@stupidchicken.com>
3299
3300 * termhooks.h (Vselection_alist): Make it terminal-local.
3301
3302 * terminal.c (create_terminal): Initialize it.
3303
3304 * xselect.c: Support for clipboard managers.
3305 (Vselection_alist): Move to termhooks.h as terminal-local var.
3306 (LOCAL_SELECTION): New macro.
3307 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3308 (symbol_to_x_atom): Remove gratuitous arg.
3309 (x_handle_selection_request, lisp_data_to_selection_data)
3310 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3311 (x_own_selection, x_get_local_selection, x_convert_selection):
3312 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3313 (some_frame_on_display): Delete unused function.
3314 (Fx_own_selection_internal, Fx_get_selection_internal)
3315 (Fx_disown_selection_internal, Fx_selection_owner_p)
3316 (Fx_selection_exists_p): New optional frame arg.
3317 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3318 (x_handle_selection_clear): Don't treat other terminals with the
3319 same keyboard specially. Use the terminal-local Vselection_alist.
3320 (x_clear_frame_selections): Use Frun_hook_with_args.
3321
3322 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3323
3324 * xterm.h: Add support for those atoms.
3325
e067f0c1
CY
33262011-05-26 Chong Yidong <cyd@stupidchicken.com>
3327
3328 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3329 (converted_selections, conversion_fail_tag): New global variables.
3330 (x_selection_request_lisp_error): Free the above.
3331 (x_get_local_selection): Remove unnecessary code.
3332 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3333 of converted selections stored in converted_selections.
3334 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3335 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3336 (x_convert_selection): New function.
3337 (x_handle_selection_event): Simplify.
3338 (x_get_foreign_selection): Don't ignore incoming requests while
3339 waiting for an answer; this will fail when we implement
3340 SAVE_TARGETS, and seems unnecessary anyway.
3341 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3342 (Vx_sent_selection_functions): Doc fix.
3343
0f4aebc0
LL
33442011-05-26 Leo Liu <sdl.web@gmail.com>
3345
3346 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3347
e61124cd
YM
33482011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3349
3350 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3351
3352 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3353 for fringe update if it has periodic bitmap.
ac389d0c 3354 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3355 and fringe_bitmap_periodic_p.
3356
3357 * fringe.c (get_fringe_bitmap_data): New function.
3358 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3359 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3360 row. Mark glyph row for fringe update if periodicity changed.
3361
3362 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3363 for fringe update unless it has periodic bitmap.
3364
f16d9837
KH
33652011-05-25 Kenichi Handa <handa@m17n.org>
3366
3367 * xdisp.c (get_next_display_element): Set correct it->face_id for
3368 a static composition.
3369
e1b90ef6
LL
33702011-05-24 Leo Liu <sdl.web@gmail.com>
3371
3372 * deps.mk (fns.o):
3373 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3374
3375 * fns.c (crypto_hash_function, Fsha1): New function.
3376 (Fmd5): Use crypto_hash_function.
3377 (syms_of_fns): Add Ssha1.
3378
7400048f
PE
33792011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3380
3381 * gnutls.c: Remove unused macros.
3382 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3383 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3384 Remove macros that are defined and never used.
3385 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3386
abb71cf4
CY
33872011-05-22 Chong Yidong <cyd@stupidchicken.com>
3388
3389 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3390 (Fx_get_selection_internal): Minor cleanup.
3391 (Fx_own_selection_internal): Rename arguments for consistency with
3392 select.el.
3393
6307db39
PE
33942011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3395
3396 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3397
f3d4e0a4
CY
33982011-05-22 Chong Yidong <cyd@stupidchicken.com>
3399
3400 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3401
4d8ade89
YM
34022011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3403
3404 * dispnew.c (scrolling_window): Don't exclude the case that the
3405 last enabled row in the desired matrix touches the bottom boundary.
3406
32078c8d
GM
34072011-05-21 Glenn Morris <rgm@gnu.org>
3408
3409 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3410 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3411 and add some more files.
32078c8d 3412
7285dc67
EZ
34132011-05-20 Eli Zaretskii <eliz@gnu.org>
3414
3415 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3416 report_file_error introduced by the change from 2011-05-07.
3417
89d1bd22
PE
34182011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3419
3420 * systime.h (Time): Define only if emacs is defined.
3421 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3422 where the include path doesn't have X11/X.h by default. See
3423 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3424
e23640bb 34252011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3426
3427 * composite.c (find_automatic_composition): Fix previous change.
3428
b9704ad9
GM
34292011-05-20 Glenn Morris <rgm@gnu.org>
3430
3431 * lisp.mk: New file, split from Makefile.in.
3432 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3433 (shortlisp): Remove.
3434 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3435
4a720484
GM
34362011-05-19 Glenn Morris <rgm@gnu.org>
3437
3438 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3439 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3440 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3441 (lisp): Set the order to that of loadup.el.
3442 (shortlisp): Make it a copy of $lisp.
3443 (SOME_MACHINE_LISP): Remove.
3444 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3445 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3446
a28d4396
KH
34472011-05-18 Kenichi Handa <handa@m17n.org>
3448
3449 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3450 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3451 (find_automatic_composition): Mostly rewrite for efficiency.
3452
a2b1fa8e
JB
34532011-05-18 Juanma Barranquero <lekktu@gmail.com>
3454
3455 * makefile.w32-in: Update dependencies.
3456
8e1f5610
CS
34572011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3458
3459 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3460 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3461
7025ee00 34622011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3463
cdfa6eab
PE
3464 Fix some integer overflow issues, such as string length overflow.
3465
06d6db33
PE
3466 * insdel.c (count_size_as_multibyte): Check for string overflow.
3467
2b4560a8
PE
3468 * character.c (lisp_string_width): Check for string overflow.
3469 Use EMACS_INT, not int, for string indexes and lengths; in
3470 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3471 the resulting string length overflows an EMACS_INT; instead,
3472 report a string overflow if no precision given. When checking for
3473 precision exhaustion, use a check that cannot possibly have
3474 integer overflow. (Bug#8675)
3475 * character.h (lisp_string_width): Adjust to new signature.
3476
cb93f9be
PE
3477 * alloc.c (string_overflow): New function.
3478 (Fmake_string): Use it. This doesn't change behavior, but saves
3479 a few bytes and will simplify future changes.
3480 * character.c (string_escape_byte8): Likewise.
3481 * lisp.h (string_overflow): New decl.
3482
1a1f3366
PE
3483 Fixups, following up to the user-interface timestamp change.
3484 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3485 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3486 * msdos.c (mouse_get_pos): Likewise.
3487 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3488 * w32gui.h (Time): Define by including "systime.h" rather than by
3489 declaring it ourselves. (Bug#8664)
3490
d4e3e4d3
PE
3491 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3492 * image.c (clear_image_cache): Likewise.
3493
f6a24d19
PE
3494 * term.c (term_mouse_position): Don't assume time_t wraparound.
3495
08dc5ae6
PE
3496 Be more systematic about user-interface timestamps.
3497 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3498 and sometimes 'EMACS_UINT', to represent these timestamps.
3499 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3500 This makes the code easier to follow, and makes it easier to catch
3501 integer overflow bugs such as Bug#8664.
3502 * frame.c (Fmouse_position, Fmouse_pixel_position):
3503 Use Time, not unsigned long, for user-interface timestamps.
3504 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3505 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3506 * keyboard.h (last_event_timestamp): Likewise.
3507 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3508 * menu.h (xmenu_show): Likewise.
3509 * term.c (term_mouse_position): Likewise.
3510 * termhooks.h (struct input_event.timestamp): Likewise.
3511 (struct terminal.mouse_position_hook): Likewise.
3512 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3513 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3514 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3515 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3516 what it was before.
3517 * menu.h, termhooks.h: Include "systime.h", for Time.
3518
8e55734a
PE
3519 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3520 Don't assume that the difference between two unsigned long values
3521 can fit into an integer. At this point, we know button_down_time
3522 <= event->timestamp, so the difference must be nonnegative, so
3523 there's no need to cast the result if double-click-time is
3524 nonnegative, as it should be; check that it's nonnegative, just in
3525 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3526 apart (about 25 days). (Bug#8664)
8e55734a 3527
841f1b75 3528 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3529 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3530
3e26f69c
PE
3531 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3532 that always fit in int. Use a sentinel instead of a counter, to
3533 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3534 * frame.h (struct frame): Use int for menu_bar_items_used
3535 instead of EMACS_INT, since it always fits in int.
3e26f69c 3536
5cc152c0
PE
3537 * menu.c (grow_menu_items): Check for int overflow.
3538
d89eb65e
PE
3539 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3540
5235bd3e
PE
3541 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3542 Before, the code was not consistent. These values cannot exceed
3543 2**31 - 1 so there's no need to make them unsigned.
3544 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3545 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3546 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3547 as modifiers.
3548 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3549
bc827e23
PE
3550 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3551 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3552 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3553 presumably because the widths might not match.
3554
78eb494e
PE
3555 * window.c (size_window): Avoid needless test at loop start.
3556
04f2d78b
CB
35572011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3558
3559 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3560
d2fc7e3d 35612011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3562
3563 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3564
d2fc7e3d 35652011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3566
3567 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3568 `width' to `bar_area_x' and `bar_area_width', respectively.
3569 (x_scroll_run): Take account of fringe background extension.
3570
04f2d78b
CB
3571 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3572 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3573 `bar_area_width', respectively.
3574 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3575 background extension.
3576
79b70037
GM
35772011-05-10 Jim Meyering <meyering@redhat.com>
3578
3579 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3580
2f142cc5
JB
35812011-05-10 Juanma Barranquero <lekktu@gmail.com>
3582
3583 * image.c (Finit_image_library): Return t for built-in image types,
3584 like pbm and xbm. (Bug#8640)
3585
57679c86
AS
35862011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3587
3588 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3589
888c9e86
EZ
35902011-05-07 Eli Zaretskii <eliz@gnu.org>
3591
b0512a1d
EZ
3592 * w32console.c (Fset_screen_color): Doc fix.
3593 (Fget_screen_color): New function.
3594 (syms_of_ntterm): Defsubr it.
3595
7285dc67
EZ
3596 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3597 unlink the temporary file if Fcall_process didn't create it in the
3598 first place.
3599 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3600 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3601 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3602 cue to call_process_cleanup not to close that handle.
3603
4d3fcc8e
BK
36042011-05-07 Ben Key <bkey76@gmail.com>
3605
3606 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3607 one of two shell specific rules, either bootstrap-temacs-CMD or
3608 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3609 to the previous implementation of the bootstrap-temacs rule.
3610 The bootstrap-temacs-CMD rule is similar to the previous
3611 implementation of the bootstrap-temacs rule except that it
3612 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3613 variable.
3614
3615 These changes, along with some changes to nt/configure.bat,
3616 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3617 earlier fix to add support for --cflags and --ldflags options
3618 that include quotes so that it works whether make uses cmd or
3619 sh as the shell.
3620
b4289b64
MA
36212011-05-06 Michael Albinus <michael.albinus@gmx.de>
3622
3623 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3624 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3625 is a constant.
3626 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3627 a string. Handle both cases.
3628 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3629 (Fdbus_register_method): Use Qinvalid_function.
3630
af4c0e28
JB
36312011-05-06 Juanma Barranquero <lekktu@gmail.com>
3632
3633 * makefile.w32-in: Update dependencies.
3634 (LISP_H): Add inttypes.h and stdin.h.
3635 (PROCESS_H): Add unistd.h.
3636
c51453d9
EZ
36372011-05-06 Eli Zaretskii <eliz@gnu.org>
3638
3639 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3640 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3641
8ff0ac3c 36422011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3643
4c4b566b
PE
3644 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3645
aab2b9b5
PE
3646 * term.c (vfatal): Remove stray call to va_end.
3647 It's not needed and the C Standard doesn't allow it here anyway.
3648
c378da0b
PE
3649 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3650 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3651
288b08c7
PE
3652 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3653 bytes.
3654
e3601888
PE
3655 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3656
db6c0e74
PE
3657 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3658
dd5963ea
PE
3659 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3660
88c9450f
PE
3661 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3662
2f9442b8
PE
3663 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3664
c032b5f8
PE
3665 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3666 * charset.c (Fdefine_charset_internal): Don't initialize
3667 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3668 32-bit int (Bug#8600).
a108c10b
PE
3669
3670 * lread.c (read_integer): Be more consistent with string-to-number.
3671 Use string_to_number to do the actual conversion; this avoids
3672 rounding errors and fixes some other screwups. Without this fix,
3673 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3674 (digit_to_number): Move earlier, for benefit of read_integer.
3675 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3676 not a digit in any supported base. (Bug#8602)
a108c10b 3677
ad5f9eea
PE
3678 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3679
aec1708a
PE
3680 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3681 to match comment at start of function. This also removes a
3682 GCC warning about overflow in a 32+64-bit port.
3683
47be4ab5
PE
3684 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3685
371cac43
PE
3686 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3687 Reported by Stefan Monnier in
3688 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3689 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3690 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3691
d01a7826
PE
3692 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3693 (EMACS_UINTPTR): Likewise, with uintptr_t.
3694
7fd47d5c
PE
3695 * lisp.h: Prefer 64-bit EMACS_INT if available.
3696 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3697 on 32-bit hosts that have 64-bit int, so that they can access
3698 large files.
122b0c86
PE
3699 However, temporarily disable this change unless the temporary
3700 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3701
8727937b
PE
3702 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3703
8ac068ac
PE
3704 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3705 This removes an assumption that EMACS_INT and long are the same
3706 width as pointers. The assumption is true for Emacs porting targets
3707 now, but we want to make other targets possible.
3708 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3709 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3710 In the rest of the code, change types of integers that hold casted
3711 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3712 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3713 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3714 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3715 No need to cast type when ORing.
3716 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3717 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3718 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3719 assume EMACS_INT is the same width as char *.
3720 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3721 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3722 Remove no-longer-needed casts.
3723 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3724 (xg_tool_bar_help_callback, xg_make_tool_item):
3725 Use EMACS_INTPTR to hold an integer
3726 that will be cast to void *; this can avoid a GCC warning
3727 if EMACS_INT is not the same width as void *.
3728 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3729 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3730 (current_message_1, set_message_1):
3731 Use a local to convert to proper width without a cast.
3732 * xmenu.c (dialog_selection_callback): Likewise.
3733
ede49d71
PE
3734 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3735 Also, don't assume VALBITS / RAND_BITS is less than 5,
3736 and don't rely on undefined behavior when shifting a 1 left into
3737 the sign bit.
3738 * lisp.h (get_random): Change signature to match.
3739
2f30ecd0
PE
3740 * lread.c (hash_string): Use size_t, not int, for hash computation.
3741 Normally we prefer signed values; but hashing is special, because
3742 it's better to use unsigned division on hash table sizes so that
3743 the remainder is nonnegative. Also, size_t is the natural width
3744 for hashing into memory. The previous code used 'int', which doesn't
3745 retain enough info to hash well into very large tables.
3746 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3747
2a866e7b
PE
3748 * dbusbind.c: Don't possibly lose pointer info when converting.
3749 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3750 Use XPNTR rather than XHASH, so that the high-order bits of
3751 the pointer aren't lost when converting through void *.
3752
51639eac
PE
3753 * eval.c (Fautoload): Don't double-shift a pointer.
3754
92394119
PE
3755 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3756
dbdb9a7c
JB
37572011-05-06 Juanma Barranquero <lekktu@gmail.com>
3758
3759 * gnutls.c (DEF_GNUTLS_FN):
3760 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3761
db7a0b4f
AS
37622011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3763
3764 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3765 marker. (Bug#8610)
3766
f7ff1b0f 37672011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3768
3769 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3770 New version that can reserve upto 2GB of heap space.
3771
f7ff1b0f 37722011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3773
3774 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3775
639c109b
TZ
37762011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3777
3778 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3779 `gnutls_certificate_set_x509_key_file'.
3780
d2127135
JB
37812011-05-05 Juanma Barranquero <lekktu@gmail.com>
3782
3783 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3784 Update dependencies.
3785
e968f4f3
JB
37862011-05-04 Juanma Barranquero <lekktu@gmail.com>
3787
3788 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3789 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3790 Remove unused parameter `fildes'.
3791 * process.c (read_process_output, send_process): Don't pass it.
3792
84d358f0
JB
37932011-05-04 Juanma Barranquero <lekktu@gmail.com>
3794
3795 Fix previous change: the library cache is defined in w32.c.
3796 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3797 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3798
0898ca10
JB
37992011-05-04 Juanma Barranquero <lekktu@gmail.com>
3800
3801 Implement dynamic loading of GnuTLS on Windows.
3802
3803 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3804 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3805 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3806 Declare.
3807
3808 * gnutls.c (Qgnutls_dll): Define.
3809 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3810 (gnutls_*): Declare function pointers.
3811 (init_gnutls_functions): New function to initialize function pointers.
3812 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3813 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3814 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3815 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3816 (emacs_gnutls_write, emacs_gnutls_read)
3817 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3818 (Fgnutls_available_p): New function.
3819 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3820 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3821 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3822
3823 * image.c: Include w32.h.
3824 (Vimage_type_cache): Delete.
3825 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3826 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3827 (w32_delayed_load): Move to w32.c.
3828
3829 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3830
3831 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3832 (w32_delayed_load): Move from image.c. When loading a library, record
3833 its filename in the :loaded-from property of the library id.
3834 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3835 Initialize and staticpro them.
3836 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3837
3838 * process.c: Include lisp.h before w32.h, not after.
3839 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3840 instead of gnutls_record_check_pending.
3841
3842 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3843
ff4de4aa
TZ
38442011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3845
3846 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3847 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3848 as passed in.
3849
abe95abb
JD
38502011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3851
3852 * xterm.c (x_set_frame_alpha): Do not set property on anything
3853 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3854
e16e55d4
JB
38552011-05-02 Juanma Barranquero <lekktu@gmail.com>
3856
3857 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3858
bafcf6a5
JB
38592011-05-02 Juanma Barranquero <lekktu@gmail.com>
3860
3861 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3862 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3863 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3864 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3865 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3866 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3867 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3868 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3869 (Qgnutls_bootprop_callbacks_verify): Make static.
3870
e7a6747f
AS
38712011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3872
19ed11ba
AS
3873 * callproc.c: Indentation fixup.
3874
e7a6747f 3875 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3876 (wait_for_termination, interruptible_wait_for_termination):
3877 Move after wait_for_termination_1.
e7a6747f 3878
1ef14cb4
LMI
38792011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3880
3881 * sysdep.c (interruptible_wait_for_termination): New function
3882 which is like wait_for_termination, but allows keyboard
3883 interruptions.
3884
3885 * callproc.c (Fcall_process): Add (:file "file") as an option for
3886 the STDOUT buffer.
3887 (Fcall_process_region): Ditto.
3888
330d880c
EZ
38892011-04-30 Eli Zaretskii <eliz@gnu.org>
3890
8db90b73
EZ
3891 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3892 rather than `XVECTOR (FOO)->size'.
3893
330d880c
EZ
3894 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3895 inttypes.h, as a gnulib replacement is used if it not available in
3896 system headers.
3897
15cbd324
EZ
38982011-04-21 Eli Zaretskii <eliz@gnu.org>
3899
3900 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3901 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3902 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3903
3904 * coding.c (coding_alloc_by_realloc): Error out if destination
3905 will grow beyond MOST_POSITIVE_FIXNUM.
3906 (decode_coding_emacs_mule): Abort if there isn't enough place in
3907 charbuf for the composition carryover bytes. Reserve an extra
3908 space for up to 2 characters produced in a loop.
3909 (decode_coding_iso_2022): Abort if there isn't enough place in
3910 charbuf for the composition carryover bytes.
3911
39122011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3913
ae940cca
EZ
3914 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3915 aborting when %lld or %lll format is passed.
3916 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3917 %llo or %llx format is passed. (Bug#8545)
3918
03ab8921
EZ
3919 * window.c (window_scroll_line_based): Use a marker instead of
3920 simple variables to record original value of point. (Bug#7952)
3921
afda1437
EZ
3922 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3923 produced by %s or %c overflows available buffer space. (Bug#8545)
3924
f76dee0c
PE
39252011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3926
3927 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3928 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3929
fdc5744d
JB
39302011-04-28 Juanma Barranquero <lekktu@gmail.com>
3931
3932 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3933
638f053a
JB
39342011-04-28 Juanma Barranquero <lekktu@gmail.com>
3935
3936 * keyboard.c (Qdelayed_warnings_hook): Define.
3937 (command_loop_1): Run `delayed-warnings-hook'
3938 if Vdelayed_warnings_list is non-nil.
3939 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3940 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3941
d178f871
EZ
39422011-04-28 Eli Zaretskii <eliz@gnu.org>
3943
3944 * doprnt.c (doprnt): Don't return value smaller than the buffer
3945 size if the message was truncated. (Bug#8545).
3946
b124fd93
JB
39472011-04-28 Juanma Barranquero <lekktu@gmail.com>
3948
3949 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3950 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3951
e810457d
PE
39522011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3953
3954 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3955
ea51cceb
JB
39562011-04-27 Juanma Barranquero <lekktu@gmail.com>
3957
3958 * makefile.w32-in: Update dependencies.
3959
94dcfacf
EZ
39602011-04-27 Eli Zaretskii <eliz@gnu.org>
3961
3962 Improve `doprnt' and its usage. (Bug#8545)
3963 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3964 `format_end'. Remove support for %l as a conversion specifier.
3965 Don't use xrealloc. Improve diagnostics when the %l size modifier
3966 is used. Update the commentary.
3967
3968 * eval.c (verror): Simplify calculation of size_t.
3969
3970 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3971 messages.
3972
f61f41d7
PE
39732011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3974
3975 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3976 change.
3977
96fb4434
PE
39782011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3979
3980 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3981 This makes this file independent of the recent pseudovector change.
3982
671875da 39832011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3984
69e9b5a3
PE
3985 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3986
b5f869a7 3987 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3988 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3989 Remove unused local.
c8926152 3990 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3991
841a1577 3992 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3993 GCC 4.6.0 optimizes based on type-based alias analysis.
3994 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3995 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3996 != &v->size, and therefore "v->size = 1; b->size = 2; return
3997 v->size;" must therefore return 1. This assumption is incorrect
3998 for Emacs, since it type-puns struct Lisp_Vector * with many other
3999 types. To fix this problem, this patch adds a new type struct
f904488f 4000 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4001 and pseudovectors, and helps optimizing compilers not get fooled
4002 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4003 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4004 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4005 the size member.
eab3844f
PE
4006 (XSETPVECTYPE): Rewrite in terms of new macro.
4007 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4008 This is a bit clearer, and further avoids the possibility of
4009 undesirable aliasing.
4010 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4011 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4012 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4013 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4014 (ASIZE): Now uses header.size rather than size.
4015 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4016 to avoid the hassle of writing XVECTOR (foo)->header.size.
4017 (struct vectorlike_header): New type.
eab3844f
PE
4018 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4019 object, to help avoid aliasing.
4020 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4021 (SUBRP): Likewise, since Lisp_Subr is a special case.
4022 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4023 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4024 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4025 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4026 changed to be "header.size" and "header.next".
4027 * buffer.h (struct buffer): Likewise.
4028 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4029 * frame.h (struct frame): Likewise.
4030 * process.h (struct Lisp_Process): Likewise.
4031 * termhooks.h (struct terminal): Likewise.
4032 * window.c (struct save_window_data, struct saved_window): Likewise.
4033 * window.h (struct window): Likewise.
4034 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4035 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4036 * buffer.c (init_buffer_once): Likewise.
4037 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4038 special case.
4039 * process.c (Fformat_network_address): Use local var for size,
4040 for brevity.
4041
0df1eac5
PE
4042 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4043
847ab9d1 4044 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4045 * data.c (atof): Remove decl; no longer used or needed.
4046 (digit_to_number): Move to lread.c.
4047 (Fstring_to_number): Use new string_to_number function, to be
4048 consistent with how the Lisp reader treats infinities and NaNs.
4049 Do not assume that floating-point numbers represent EMACS_INT
4050 without losing information; this is not true on most 64-bit hosts.
4051 Avoid double-rounding errors, by insisting on integers when
4052 parsing non-base-10 numbers, as the documentation specifies.
4053 * lisp.h (string_to_number): New decl, replacing ...
4054 (isfloat_string): Remove.
bc0a5c13 4055 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4056 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4057 appears to have been a coding error. Similarly, do not accept
4058 strings like +-1e0 as floating point numbers. Do not report
4059 overflow for integer overflows unless the base is not 10 which
4060 means we have no simple and reliable way to continue.
4061 Break out the floating-point parsing into a new
4062 function string_to_number, so that Fstring_to_number parses
4063 floating point numbers consistently with the Lisp reader.
04f2d78b 4064 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4065 (E_CHAR, EXP_INT): Remove, replacing with ...
4066 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4067 (string_to_number): New function, replacing isfloat_string.
4068 This function checks for valid syntax and produces the resulting
4069 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4070 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4071 so that overflow for non-base-10 numbers is reported only when
4072 there's no portable and simple way to convert to floating point.
452f4150 4073
67769ffc
PE
4074 * textprop.c (set_text_properties_1): Rewrite for clarity,
4075 and to avoid GCC warning about integer overflow.
4076
c20db43f
PE
4077 * intervals.h (struct interval): Use EMACS_INT for members
4078 where EMACS_UINT might cause problems. See
4079 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4080 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4081 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4082 All uses changed.
37aa2f85
PE
4083 (offset_intervals): Tell GCC not to worry about length overflow
4084 when negating a negative length.
c20db43f 4085
2538aa2f
PE
4086 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4087 (overrun_check_free): Likewise.
4088
f2d3008d
PE
4089 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4090 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4091 word size.
4092
ec8df744
PE
4093 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4094 (gnutls_make_error): Rename local to avoid shadowing.
4095 (gnutls_emacs_global_deinit): ifdef out; not used.
4096 (Fgnutls_boot): Use const for pointer to readonly storage.
4097 Comment out unused local. Fix pointer signedness problems.
4098
640ee02d
PE
4099 * lread.c (openp): Don't stuff size_t into an 'int'.
4100 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4101 about possible signed overflow.
4102
6048fb2a
PE
4103 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4104 (GDK_KEY_g): Don't define if already defined.
4105 (xg_prepare_tooltip): Avoid pointer signedness problem.
4106 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4107
fa3c87e1
PE
4108 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4109 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4110
2172544b
PE
4111 * xfns.c (Fx_window_property): Simplify a bit,
4112 to make a bit faster and to avoid GCC 4.6.0 warning.
4113 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4114
9b821a21
PE
4115 * fns.c (internal_equal): Don't assume size_t fits in int.
4116
3c616cfa
PE
4117 * alloc.c (compact_small_strings): Tighten assertion a little.
4118
c2982e87
PE
4119 Replace pEd with more-general pI, and fix some printf arg casts.
4120 * lisp.h (pI): New macro, generalizing old pEd macro to other
4121 conversion specifiers. For example, use "...%"pI"d..." rather
4122 than "...%"pEd"...".
4123 (pEd): Remove. All uses replaced with similar uses of pI.
4124 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4125 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4126 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4127 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4128 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4129 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4130 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4131 64-bit hosts.
4132 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4133 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4134 * print.c (safe_debug_print, print_object): Likewise.
4135 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4136 to int.
6f04d126
PE
4137 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4138 avoiding the 0 flag, which is not portable.
c2982e87
PE
4139 * process.c (Fmake_network_process): Use pI to avoid cast.
4140 * region-cache.c (pp_cache): Likewise.
4141 * xdisp.c (decode_mode_spec): Likewise.
4142 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4143 behavior on 64-bit hosts with printf arg.
6f04d126 4144 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4145 (x_stop_queuing_selection_requests): Likewise.
4146 (x_get_window_property): Don't truncate byte count to an 'int'
4147 when tracing.
0b432f21 4148
5e073ec7
PE
4149 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4150 here, since it parses constructs like leading '-' and spaces,
4151 which are not wanted; and it overflows with large numbers.
4152 Instead, simply match F[0-9]+, which is what is wanted anyway.
4153
36372bf9
PE
4154 * alloc.c: Remove unportable assumptions about struct layout.
4155 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4156 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4157 (allocate_vectorlike, make_pure_vector): Use the new macros,
4158 plus offsetof, to remove unportable assumptions about struct layout.
4159 These assumptions hold on all porting targets that I know of, but
4160 they are not guaranteed, they're easy to remove, and removing them
4161 makes further changes easier.
4162
0b432f21
PE
4163 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4164 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4165 (string_overrun_cookie): Now const. Use initializers that
4166 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4167 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4168 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4169 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4170 multiple of sizeof (EMACS_INT); it need not be, if
4171 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4172 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4173
895009e1
JB
41742011-04-26 Juanma Barranquero <lekktu@gmail.com>
4175
4176 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4177
6a7a1b0b
TZ
41782011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4179
4180 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4181 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4182 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4183
841a1577 41842011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4185
4186 * lisp.h (Qdebug): List symbol.
895009e1 4187 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4188 * keyboard.c (debug-on-event): New variable.
4189 (handle_user_signal): Break into debugger when debug-on-event
4190 matches the current signal symbol.
4191
f2d3ba6f
DN
41922011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4193
4194 * alloc.c (check_sblock, check_string_bytes)
4195 (check_string_free_list): Convert to standard C.
4196
42ce4c63
TZ
41972011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4198
4199 * w32.c (emacs_gnutls_push): Fix typo.
4200
825cd63c
EZ
42012011-04-25 Eli Zaretskii <eliz@gnu.org>
4202
fb11d64d
EZ
4203 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4204 "cast to pointer from integer of different size".
4205
825cd63c
EZ
4206 Improve doprnt and its use in verror. (Bug#8545)
4207 * doprnt.c (doprnt): Document the set of format control sequences
4208 supported by the function. Use SAFE_ALLOCA instead of always
4209 using `alloca'.
4210
4211 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4212 is one byte too soon. Don't use xrealloc; instead xfree and
4213 xmalloc anew.
4214
e061a11b
TZ
42152011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4216
4217 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4218 callbacks stage.
4219
4220 * gnutls.c: Renamed global_initialized to
4221 gnutls_global_initialized. Added internals for the
4222 :verify-hostname-error, :verify-error, and :verify-flags
4223 parameters of `gnutls-boot' and documented those parameters in the
4224 docstring. Start callback support.
9173deec
JB
4225 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4226 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4227 on error. Return error code.
e061a11b
TZ
4228 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4229 (emacs_gnutls_read): Likewise.
4230 (Fgnutls_boot): Return handshake error code.
4231 (emacs_gnutls_handle_error): New function.
4232 (wsaerror_to_errno): Likewise.
4233
4234 * w32.h (emacs_gnutls_pull): Add prototype.
4235 (emacs_gnutls_push): Likewise.
4236
4237 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4238 (emacs_gnutls_push): Likewise.
4239
42402011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4241
4242 * process.c (wait_reading_process_output): Check if GnuTLS
4243 buffered some data internally if no FDs are set for TLS
4244 connections.
4245
4246 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4247 (LIBS): Link to USER_LIBS.
4248 ($(BLD)/gnutls.$(0)): New target.
4249
fa6996bc
EZ
42502011-04-24 Eli Zaretskii <eliz@gnu.org>
4251
eb35682e
EZ
4252 * xdisp.c (handle_single_display_spec): Rename the
4253 display_replaced_before_p argument into display_replaced_p, to
4254 make it consistent with the commentary. Fix typos in the
4255 commentary.
4256
e2ad650c
EZ
4257 * textprop.c (syms_of_textprop): Remove dead code.
4258 (copy_text_properties): Delete obsolete commentary about an
4259 interface that was deleted long ago. Fix typos in the description
4260 of arguments.
4261
1b2de274
EZ
4262 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4263 to changes in oldXMenu/XMenu.h from 2011-04-16.
4264 <menu_help_message, prev_menu_help_message>: Constify.
4265 (IT_menu_make_room): menu->help_text is now `const char **';
4266 adjust.
4267
4268 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4269 to changes in oldXMenu/XMenu.h from 2011-04-16.
4270 (struct XMenu): Declare `help_text' `const char **'.
4271
4272 * xfaces.c <Qunspecified>: Make extern again.
4273
4274 * syntax.c: Include sys/types.h before including regex.h, as
4275 required by Posix.
4276
762b15be
EZ
4277 * doc.c (get_doc_string): Improve the format passed to `error'.
4278
4279 * doprnt.c (doprnt): Improve commentary.
4280
4281 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4282
4283 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4284 them with etags.
4285
f1052e5d
EZ
4286 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4287 changes in globals.h immediately force recompilation.
762b15be
EZ
4288 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4289 $(CURDIR)/s/ms-w32.h.
4290 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4291
fa6996bc
EZ
4292 * character.c (Fchar_direction): Function deleted.
4293 (syms_of_character): Don't defsubr it.
4294 <char-direction-table>: Deleted.
4295
e6c3da20
EZ
42962011-04-23 Eli Zaretskii <eliz@gnu.org>
4297
4298 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4299 * doprnt.c: Include limits.h.
4300 (SIZE_MAX): New macro.
04f2d78b
CB
4301 (doprnt): Return a size_t value. 2nd arg is now size_t.
4302 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4303 Improve overflow protection. Support `l' modifier for integer
4304 conversions. Support %l conversion. Don't assume an EMACS_INT
4305 argument for integer conversions and for %c.
4306
4307 * lisp.h (doprnt): Restore prototype.
4308
4309 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4310 $(SRC)/character.h.
4311
4312 * Makefile.in (base_obj): Add back doprnt.o.
4313
4314 * deps.mk (doprnt.o): Add back prerequisites.
4315 (callint.o): Depend on character.h.
4316
4317 * eval.c (internal_lisp_condition_case): Include the handler
4318 representation in the error message.
4319 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4320 when breaking from the loop.
4321
4322 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4323
4324 * callint.c (Fcall_interactively): When displaying error message
4325 about invalid control letter, pass the character's codepoint, not
4326 a pointer to its multibyte form. Improve display of the character
4327 in octal and display also its hex code.
4328
4329 * character.c (char_string): Use %x to display the (unsigned)
4330 codepoint of an invalid character, to avoid displaying a bogus
4331 negative value.
4332
4333 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4334 `error', not SYMBOL_NAME itself.
4335
4336 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4337 character arguments to `error'.
4338
4339 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4340 to `error' in error message about FINAL_CHAR argument. Make sure
4341 FINAL_CHAR is a character, and use %c when it is passed as
4342 argument to `error'.
4343
4ffd0d6b 43442011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4345
4346 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4347
4348 * w32.c: Include <time.h>.
4349 (sys_localtime): New function.
4350
4ffd0d6b 43512011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4352
4353 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4354
4ffd0d6b 4355 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4356
4ffd0d6b 43572011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4358
4ffd0d6b
GM
4359 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4360 zombies (Bug#8467).
aac0c6e3 4361
04c56954
EZ
43622011-04-19 Eli Zaretskii <eliz@gnu.org>
4363
4364 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4365 gl_state.e_property when gl_state.object is Qt.
4366
4367 * insdel.c (make_gap_larger): Remove limitation of buffer size
4368 to <= INT_MAX.
4369
16a43933
CY
43702011-04-18 Chong Yidong <cyd@stupidchicken.com>
4371
4372 * xdisp.c (lookup_glyphless_char_display)
4373 (produce_glyphless_glyph): Handle cons cell entry in
4374 glyphless-char-display.
4375 (Vglyphless_char_display): Document it.
4376
4377 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4378 glyphless-char-display.
4379
4581706e
CY
43802011-04-17 Chong Yidong <cyd@stupidchicken.com>
4381
4382 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4383
4384 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4385
4386 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4387 definition for no-X builds.
4388
4887c6e2 43892011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4390
fd35b6f9
PE
4391 Static checks with GCC 4.6.0 and non-default toolkits.
4392
5c1ccb01
PE
4393 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4394
006c5daa
PE
4395 * process.c (keyboard_bit_set): Define only if SIGIO.
4396 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4397 (send_process): Repair possible setjmp clobbering.
4398
efc736d3
PE
4399 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4400
4e2fe2e6
PE
4401 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4402
f97334a2
PE
4403 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4404
4e75f29d
PE
4405 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4406 Define only if needed.
4407
90efadd1
PE
4408 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4409 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4410 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4411
3c647824
PE
4412 * dispextern.h (struct redisplay_interface): Rename param
4413 to avoid shadowing.
e264f262 4414 * termhooks.h (struct terminal): Likewise.
761383f4 4415 * xterm.c (xembed_send_message): Likewise.
3c647824 4416
b58c5c4a
PE
4417 * insdel.c (make_gap_smaller): Define only if
4418 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4419
cad59032
PE
4420 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4421 it.
4422
c339dc2e
PE
4423 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4424 so that we aren't warned about unused symbols.
4425
91a3e27b
PE
4426 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4427
399c71d3 4428 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4429
8ffc96f5
PE
4430 * xfns.c (x_real_positions): Mark locals as initialized.
4431
eef9bc79
PE
4432 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4433
098db9dd
PE
4434 * xterm.c: Fix problems found by static analysis with other toolkits.
4435 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4436 (x_dispatch_event): Declare static if USE_GTK, and
4437 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4438 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4439 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4440 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4441 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4442
eb18f6cc
PE
4443 * xmenu.c (menu_help_callback): Pointer type fixes.
4444 Use const pointers when pointing at readonly data. Avoid pointer
4445 signedness clashes.
4446 (FALSE): Remove unused macro.
4447 (update_frame_menubar): Remove unused decl.
4448
1fe72bf8
PE
4449 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4450
60d9e1db
PE
4451 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4452 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4453 (single_menu_item): Rename local to avoid shadowing.
4454
39261c26
PE
4455 * keyboard.c (make_lispy_event): Remove unused local var.
4456
018c5e19
PE
4457 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4458 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4459
63d2b86e
PE
4460 * bitmaps: Change bitmaps from unsigned char back to the X11
4461 compatible char. Avoid the old compiler warnings about
4462 out-of-range initializers by using, for example, '\xab' rather
4463 than 0xab.
4464
aefd87e1
PE
4465 * xgselect.c (xgselect_initialize): Check vs interface
4466 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4467
bf501fb9
PE
4468 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4469
e9829fdf
PE
4470 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4471 to read-only memory.
4472
1086c095
PE
4473 * fns.c (vector): Remove; this old hack is no longer needed.
4474
2baccd04 4475 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4476 Remove unused var.
dde42981 4477 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4478
72391843 4479 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4480
436c16df 4481 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4482 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4483 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4484
92bb796d 4485 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4486 (x_term_init): Remove local to avoid shadowing.
92bb796d 4487
764430a3 4488 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4489
4490 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4491 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4492
d1dfb56c
EZ
44932011-04-16 Eli Zaretskii <eliz@gnu.org>
4494
c4354cb4
EZ
4495 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4496
d1dfb56c
EZ
4497 Fix regex.c, syntax.c and friends for buffers > 2GB.
4498 * syntax.h (struct gl_state_s): Declare character position members
4499 EMACS_INT.
4500
4501 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4502
04f2d78b
CB
4503 * textprop.c (verify_interval_modification, interval_of):
4504 Declare arguments EMACS_INT.
d1dfb56c
EZ
4505
4506 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4507 EMACS_INT.
4508
4509 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4510
4511 * indent.c (Fvertical_motion): Local variable it_start is now
4512 EMACS_INT.
4513
4514 * regex.c (re_match, re_match_2, re_match_2_internal)
4515 (bcmp_translate, regcomp, regexec, print_double_string)
4516 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4517 (re_compile_pattern, re_exec): Declare arguments and local
4518 variables `size_t' and `ssize_t' and return values `regoff_t', as
4519 appropriate.
4520 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4521 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4522 <compile_stack_type>: `size' and `avail' are now `size_t'.
4523
4524 * regex.h <regoff_t>: Use ssize_t, not int.
4525 (re_search, re_search_2, re_match, re_match_2): Arguments that
4526 specify buffer/string position and length are now ssize_t and
4527 size_t. Return type is regoff_t.
4528
613052cd
BK
45292011-04-16 Ben Key <bkey76@gmail.com>
4530
4531 * nsfont.m: Fixed bugs in ns_get_family and
4532 ns_descriptor_to_entity that were caused by using free to
4533 deallocate memory blocks that were allocated by xmalloc (via
4534 xstrdup). This caused Emacs to crash when compiled with
4535 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4536 --enable-checking=xmallocoverrun). xfree is now used to
4537 deallocate these memory blocks.
4538
4170f62f 45392011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4540
71b41406
PE
4541 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4542
9587a89d
PE
4543 emacs_write: Accept and return EMACS_INT for sizes.
4544 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4545 et seq.
4546 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4547 Accept and return EMACS_INT.
4548 (emacs_gnutls_write): Return the number of bytes written on
4549 partial writes.
4550 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4551 (emacs_read, emacs_write): Remove check for negative size, as the
4552 Emacs source code has been audited now.
9587a89d
PE
4553 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4554 (emacs_read, emacs_write): Use it.
273a5f82
PE
4555 * process.c (send_process): Adjust to the new signatures of
4556 emacs_write and emacs_gnutls_write. Do not attempt to store
4557 a byte offset into an 'int'; it might overflow.
9587a89d 4558 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4559
3e047f51
PE
4560 * sound.c: Don't assume sizes fit in 'int'.
4561 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4562 Return EMACS_INT, not int.
3e047f51 4563 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4564 Accept EMACS_INT, not int.
4565 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4566 record read return values.
4567
cc39a9db
BK
45682011-04-15 Ben Key <bkey76@gmail.com>
4569
c9d0ec6d
JB
4570 * keyboard.c (Qundefined): Don't declare static since it is used
4571 in nsfns.m.
4572 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4573 static since they are used in nsfont.m.
cc39a9db 4574
6c60eb9f
SM
45752011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4576
4577 * process.c (Qprocessp): Don't declare static.
4578 * lisp.h (Qprocessp): Declare again.
4579
7990b61a
JB
45802011-04-15 Juanma Barranquero <lekktu@gmail.com>
4581
4582 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4583
5d4cb038
PE
45842011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4585
8bd7b830 4586 Improve C-level modularity by making more things 'static'.
cd64ea1d 4587
e3b27b31
PE
4588 Don't publish debugger-only interfaces to other modules.
4589 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4590 (verify_bytepos, count_markers): Move decls to the only modules
4591 that need them.
4592 * region-cache.h (pp_cache): Likewise.
4593 * window.h (check_all_windows): Likewise.
4594 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4595
5d4cb038
PE
4596 * sysdep.c (croak): Now static, if
4597 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4598 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4599
4600 * alloc.c (refill_memory_reserve): Now static if
4601 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4602 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4603
e87b6180
PE
4604 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4605 Define only if USE_LUCID.
4606
ac64929e
PE
4607 * xrdb.c (x_customization_string, x_rm_string): Now static.
4608
6f37259d
PE
4609 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4610 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4611
1683e3ab
PE
4612 * xdisp.c (draw_row_with_mouse_face): Now static.
4613 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4614
de9c2632
PE
4615 * window.h (check_all_windows): Mark externally visible.
4616
2b96acb7
PE
4617 * window.c (window_deletion_count): Now static.
4618
4619 * undo.c: Make symbols static if they're not exported.
4620 (last_undo_buffer, last_boundary_position, pending_boundary):
4621 Now static.
4622
50436f33
PE
4623 * textprop.c (interval_insert_behind_hooks): Now static.
4624 (interval_insert_in_front_hooks): Likewise.
4625
64520e5c
PE
4626 * term.c: Make symbols static if they're not exported.
4627 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4628 (max_frame_lines, tty_set_terminal_modes):
4629 (tty_reset_terminal_modes, tty_turn_off_highlight):
4630 (get_tty_terminal): Now static.
4631 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4632 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4633 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4634 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4635 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4636
1fa53021
PE
4637 * sysdep.c: Make symbols static if they're not exported.
4638 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4639 Now static.
4640 (sigprocmask_set, full_mask): Remove; unused.
4641 (wait_debugging): Mark as visible.
4642 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4643 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4644
d4b43b22
PE
4645 * syntax.c (syntax_temp): Define only if !__GNUC__.
4646
b7c513d0
PE
4647 * sound.c (current_sound_device, current_sound): Now static.
4648
989b29ad
PE
4649 * search.c (searchbufs, searchbuf_head): Now static.
4650
13a55a78
PE
4651 * scroll.c (scroll_cost): Remove; unused.
4652 * dispextern.h (scroll_cost): Remove decl.
4653
de68a1fc
PE
4654 * region-cache.h (pp_cache): Mark as externally visible.
4655
40ccffa6
PE
4656 * process.c: Make symbols static if they're not exported.
4657 (process_tick, update_tick, create_process, chan_process):
4658 (Vprocess_alist, proc_buffered_char, datagram_access):
4659 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4660 (deactivate_process): Mark defn as static, as well as decl.
4661 * lisp.h (create_process): Remove decl.
4662 * process.h (chan_process, Vprocess_alist): Remove decls.
4663
ad64fc97
PE
4664 * print.c: Make symbols static if they're not exported.
4665 (print_depth, new_backquote_output, being_printed, print_buffer):
4666 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4667 (print_interval, print_number_index, initial_stderr_stream):
4668 Now static.
4669 * lisp.h (Fprinc): Remove decl.
4670 (debug_output_compilation_hack): Mark as externally visible.
4671
adddb265
PE
4672 * sysdep.c (croak): Move decl from here to syssignal.h.
4673 * syssignal.h (croak): Put it here, so the API can be checked when
4674 'croak' is called from dissociate_if_controlling_tty.
4675
1717ede2
PE
4676 * minibuf.c: Make symbols static if they're not exported.
4677 (minibuf_save_list, choose_minibuf_frame): Now static.
4678 * lisp.h (choose_minibuf_frame): Remove decl.
4679
fa5fb2bc
PE
4680 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4681
1e3890d1
PE
4682 * lread.c: Make symbols static if they're not exported.
4683 (read_objects, initial_obarray, oblookup_last_bucket_number):
4684 Now static.
4685 (make_symbol): Remove; unused.
4686 * lisp.h (initial_obarray, make_symbol): Remove decls.
4687
8a1414fa
PE
4688 * keyboard.c: Make symbols static if they're not exported.
4689 (single_kboard, recent_keys_index, total_keys, recent_keys):
4690 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4691 (this_single_command_key_start, echoing, last_auto_save):
4692 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4693 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4694 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4695 (Vlispy_mouse_stem, double_click_count):
4696 Now static.
4697 (force_auto_save_soon): Define only if SIGDANGER.
4698 (ignore_mouse_drag_p): Now static if
4699 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4700 (print_help): Remove; unused.
4701 (stop_character, last_timer_event): Mark as externally visible.
4702 * keyboard.h (ignore_mouse_drag_p): Declare only if
4703 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4704 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4705 * lisp.h (echoing): Remove decl.
4706 (force_auto_save_soon): Declare only if SIGDANGER.
4707 * xdisp.c (redisplay_window): Simplify code, to make it more
4708 obvious that ignore_mouse_drag_p is not accessed if !defined
4709 USE_GTK && !defined HAVE_NS.
4710
93ea6e8f
PE
4711 * intervals.c: Make symbols static if they're not exported.
4712 (merge_properties_sticky, merge_interval_right, delete_interval):
4713 Now static.
4714 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4715
77382fcc
PE
4716 * insdel.c: Make symbols static if they're not exported.
4717 However, leave prepare_to_modify_buffer alone. It's never
4718 called from outside this function, but that appears to be a bug.
4719 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4720 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4721 (adjust_after_replace_noundo): Remove; unused.
4722 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4723 (signal_before_change): Remove decls.
77382fcc 4724
9306c32e
PE
4725 * indent.c (val_compute_motion, val_vmotion): Now static.
4726
cd44d2eb
PE
4727 * image.c: Make symbols static if they're not exported.
4728 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4729 if USE_GTK.
4730 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4731 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4732
ad9a7a06
PE
4733 * fringe.c (standard_bitmaps): Now static.
4734 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4735
81626931
PE
4736 * frame.c: Make symbols static if they're not exported.
4737 (x_report_frame_params, make_terminal_frame): Now static.
4738 (get_frame_param): Now static, unless HAVE_NS.
4739 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4740 (x_get_resource_string): Remove; not used.
4741 * frame.h (make_terminal_frame, x_report_frame_params):
4742 (x_get_resource_string); Remove decls.
4743 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4744 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4745
239f9db9
PE
4746 * font.c, fontset.c: Make symbols static if they're not exported.
4747 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4748 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4749 * font.c (font_close_object): Now static.
4750 * font.h (font_close_object): Remove.
4751 * fontset.c (FONTSET_OBJLIST): Remove.
4752 (free_realized_fontset) #if-0 the body, which does nothing.
4753 (face_suitable_for_char_p): #if-0, as it's never called.
4754 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4755 * xfaces.c (face_at_string_position):
4756 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4757 since 0 is always ASCII.
4758
dfcf3579
PE
4759 * fns.c (weak_hash_tables): Now static.
4760
5045092b
PE
4761 * fileio.c: Make symbols static if they're not exported.
4762 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4763 (Vwrite_region_annotation_buffers): Now static.
4764
57a96f5c
PE
4765 * eval.c: Make symbols static if they're not exported.
4766 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4767 * lisp.h (backtrace_list): Remove decl.
4768
35f08c38
PE
4769 * emacs.c: Make symbols static if they're not exported.
4770 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4771 (fatal_error_code, fatal_error_signal_hook, standard_args):
4772 Now static.
4773 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4774 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4775 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4776 * lisp.h (fatal_error_signal_hook): Remove decl.
4777 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4778
f44bd759
PE
4779 * editfns.c: Move a (normally-unused) function to its only use.
4780 * editfns.c, lisp.h (get_operating_system_release): Remove.
4781 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4782 worth the hassle of breaking this out.
4783
b532497d
PE
4784 * xterm.c: Make symbols static if they're not exported.
4785 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4786 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4787 (x_destroy_window, x_delete_display):
4788 Now static.
4789 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4790 (x_mouse_leave): Remove; unused.
4791 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4792 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4793 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4794 Remove decls.
4795 (x_mouse_leave): Declare only if WINDOWSNT.
4796 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4797 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4798 USE_X_TOOLKIT.
4799
1675728f
PE
4800 * ftxfont.c: Make symbols static if they're not exported.
4801 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4802 HAVE_FREETYPE.
4803 * font.h (ftxfont_driver): Likewise.
4804
e4cebfca
PE
4805 * xfns.c: Make symbols static if they're not exported.
4806 (x_last_font_name, x_display_info_for_name):
4807 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4808 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4809 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4810 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4811 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4812 (last_show_tip_args): Now static.
4813 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4814 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4815 (x_screen_planes): Remove; unused.
4816 * dispextern.h (x_screen_planes): Remove decl.
4817
5bf46f05
PE
4818 * dispnew.c: Make symbols static if they're not exported.
4819 * dispextern.h (redraw_garbaged_frames, scrolling):
4820 (increment_row_positions): Remove.
4821 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4822 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4823 Now static.
4824 (redraw_garbaged_frames): Remove; unused.
4825
435f4c28
PE
4826 * xfaces.c: Make symbols static if they're not exported.
4827 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4828 Remove decls.
4829 * xterm.h (defined_color): Remove decls.
4830 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4831 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4832 (menu_face_changed_default, defined_color, free_realized_face):
4833 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4834 (ascii_face_of_lisp_face): Remove; unused.
4835
8524aef3
PE
4836 * xdisp.c: Make symbols static if they're not exported.
4837 * dispextern.h (scratch_glyph_row, window_box_edges):
4838 (glyph_to_pixel_coords, set_cursor_from_row):
4839 (get_next_display_element, set_iterator_to_next):
4840 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4841 (show_mouse_face): Remove decls
4842 * frame.h (message_buf_print): Likewise.
4843 * lisp.h (pop_message, set_message, check_point_in_composition):
4844 Likewise.
4845 * xterm.h (set_vertical_scroll_bar): Likewise.
4846 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4847 (message_buf_print, scratch_glyph_row, displayed_buffer):
4848 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4849 (get_next_display_element, show_mouse_face, window_box_edges):
4850 (frame_to_window_pixel_xy, check_point_in_composition):
4851 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4852 (glyph_to_pixel_coords): Remove; unused.
4853
16390cd2
PE
4854 * dired.c (file_name_completion): Now static.
4855
4856 * dbusbind.c (xd_in_read_queued_messages): Now static.
4857
a25f4dfa
PE
4858 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4859 * data.c (circular_list_error): Remove.
4860
14a9c8df
PE
4861 * commands.h (last_point_position, last_point_position_buffer):
4862 (last_point_position_window): Remove decls.
4863 * keyboard.c: Make these variables static.
4864
04f2d78b
CB
4865 * coding.h (coding, code_convert_region, encode_coding_gap):
4866 Remove decls.
74ab6df5
PE
4867 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4868 (iso_code_class, detect_coding, code_convert_region): Now static.
4869 (encode_coding_gap): Remove; unused.
4870
38dfbee1
PE
4871 * chartab.c (chartab_chars, chartab_bits): Now static.
4872
a2cb4e63
PE
4873 * charset.h (charset_iso_8859_1): Remove decl.
4874 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4875 Now static.
4876
127198fd
PE
4877 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4878 * ccl.c (Vccl_program_table): Now static.
4879 (check_ccl_update): Remove; unused.
4880
d85b608f
PE
4881 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4882 * category.h: ... from here.
4883 * category.c (check_category_table, set_category_set): Now static.
4884
31cd66f3
PE
4885 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4886 * lisp.h: Remove these decls.
4887
c358e587
PE
4888 * buffer.c (buffer_count): Remove unused var.
4889
e78aecca
PE
4890 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4891 so that it's not optimized away.
4892 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4893 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4894 exported only to the debugger.
4895
e192d7d3 4896 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4897 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4898
92470028
PE
4899 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4900 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4901 was inaccessible from Lisp.
4902 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4903 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4904
244ed907
PE
4905 alloc.c: Import and export fewer symbols, and remove unused items.
4906 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4907 is defined.
4908 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4909 it's not optimized away by whole-program optimization.
4910 (message_enable_multibyte, free_misc): Remove.
4911 (catchlist, handlerlist, mark_backtrace):
4912 Declare only if BYTE_MARK_STACK.
4913 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4914 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4915 (message_enable_multibyte): Remove decl.
4916 (free_misc, interval_free_list, float_block, float_block_index):
4917 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4918 (cons_free_list, last_marked_index):
4919 Now static.
4920 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4921 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4922 (mark_backtrace): Define only if BYTE_MARK_STACK.
4923 * xdisp.c (message_enable_multibyte): Now static.
4924
61c2b50e 4925 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4926 This makes it easier for human readers (and static analyzers)
4927 to see whether these variables are used from other modules.
4928 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4929 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4930 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4931 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4932 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4933 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4934 * xmenu.c, xselect.c:
4935 Declare Q* vars static if they are not used in other modules.
4936 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4937 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4938 Remove decls of unexported vars.
4939 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4940
95c82688
PE
4941 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4942
16a97296
PE
4943 Make Emacs functions such as Fatom 'static' by default.
4944 This makes it easier for human readers (and static analyzers)
4945 to see whether these functions can be called from other modules.
4946 DEFUN now defines a static function. To make the function external
4947 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4948 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4949 (Finit_image_library):
16a97296
PE
4950 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4951 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4952 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4953 Remove decls, since these functions are now static.
4954 (Funintern, Fget_internal_run_time): New decls, since these functions
4955 were already external.
95c82688 4956
16a97296
PE
4957 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4958 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4959 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4960 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4961 * keyboard.c, keymap.c, lread.c:
4962 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4963 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4964 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4965 Mark functions with DEFUE instead of DEFUN,
4966 if they are used in other modules.
4967 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4968 decls for now-static functions.
4969 * buffer.h (Fdelete_overlay): Remove decl.
4970 * callproc.c (Fgetenv_internal): Mark as internal.
4971 * composite.c (Fremove_list_of_text_properties): Remove decl.
4972 (Fcomposition_get_gstring): New forward static decl.
4973 * composite.h (Fcomposite_get_gstring): Remove decl.
4974 * dired.c (Ffile_attributes): New forward static decl.
4975 * doc.c (Fdocumntation_property): New forward static decl.
4976 * eval.c (Ffetch_bytecode): New forward static decl.
4977 (Funintern): Remove extern decl; now in .h file where it belongs.
4978 * fileio.c (Fmake_symbolic_link): New forward static decl.
4979 * image.c (Finit_image_library): New forward static decl.
4980 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4981 * intervals.h (Fprevious_property_change):
4982 (Fremove_list_of_text_properties): Remove decls.
4983 * keyboard.c (Fthis_command_keys): Remove decl.
4984 (Fcommand_execute): New forward static decl.
4985 * keymap.c (Flookup_key): New forward static decl.
4986 (Fcopy_keymap): Now static.
4987 * keymap.h (Flookup_key): Remove decl.
4988 * process.c (Fget_process): New forward static decl.
4989 (Fprocess_datagram_address): Mark as internal.
4990 * syntax.c (Fsyntax_table_p): New forward static decl.
4991 (skip_chars): Remove duplicate decl.
4992 * textprop.c (Fprevious_property_change): New forward static decl.
4993 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4994 Now internal.
4995 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4996 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4997
785bbd42
PE
4998 * editfns.c (Fformat): Remove unreachable code.
4999
8b913b57
AS
50002011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5001
5002 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5003 change. (Bug#8496)
5004
a6744a35
EZ
50052011-04-13 Eli Zaretskii <eliz@gnu.org>
5006
5007 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5008 when at ZV. (Bug#8487)
5009
e7974947
AS
50102011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5011
baad03f0
AS
5012 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5013 (Bug#8437)
5014 * keyboard.c (parse_tool_bar_item): Likewise.
5015 * sound.c (sound_cleanup, alsa_close): Likewise.
5016 * termcap.c (tgetent): Likewise.
5017 * xfns.c (x_default_font_parameter): Likewise.
5018 * xsettings.c (read_and_apply_settings): Likewise.
5019
e7974947
AS
5020 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5021 (overrun_check_free): Protoize.
5022
28272684
PE
50232011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5024
5025 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5026 since callers should never pass a negative size.
5027 Change the signature to match that of plain 'read' and 'write'; see
5028 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5029 * lisp.h: Update prototypes of emacs_write and emacs_read.
5030
11997c76
EZ
50312011-04-11 Eli Zaretskii <eliz@gnu.org>
5032
5033 * xdisp.c (redisplay_window): Don't try to determine the character
5034 position of the scroll margin if the window start point w->startp
e896f03c 5035 is outside the buffer's accessible region. (Bug#8468)
11997c76 5036
8a2cbd72
EZ
50372011-04-10 Eli Zaretskii <eliz@gnu.org>
5038
5039 Fix write-region and its subroutines for buffers > 2GB.
5040 * fileio.c (a_write, e_write): Modify declaration of arguments and
5041 local variables to support buffers larger than 2GB.
5042 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5043
5044 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5045 argument, local variables, and return value.
5046
5047 * lisp.h: Update prototypes of emacs_write and emacs_read.
5048
5049 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5050
4073e537 50512011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5052
1ebfdcb6
PE
5053 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5054
b2ded58d
PE
5055 Fix more problems found by GCC 4.6.0's static checks.
5056
7d66342c
PE
5057 * xdisp.c (vmessage): Use a better test for character truncation.
5058
bbf47d44
PE
5059 * charset.c (load_charset_map): <, not <=, for optimization,
5060 and to avoid potential problems with integer overflow.
9248994d 5061 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5062 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5063 * editfns.c (Fformat): Likewise.
1e69125e 5064 * syntax.c (skip_chars): Likewise.
3befa583 5065
e3019616
PE
5066 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5067 This also lets GCC 4.6.0 generate slightly better loop code.
5068
becfa255
PE
5069 * callint.c (Fcall_interactively): <, not <=, for optimization.
5070 (Fcall_interactively): Count the number of arguments produced,
5071 not the number of arguments given. This is simpler and lets GCC
5072 4.6.0 generate slightly better code.
5073
dae0cd48
PE
5074 * ftfont.c: Distingish more carefully between FcChar8 and char.
5075 The previous code passed unsigned char * to a functions like
5076 strlen and xstrcasecmp that expect char *, which does not
5077 conform to the C standard.
5078 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5079 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5080 char * when the C standard requires it.
5081
76032d70
PE
5082 * keyboard.c (read_char): Remove unused var.
5083
eb3f1cc8
PE
5084 * eval.c: Port to Windows vsnprintf (Bug#8435).
5085 Include <limits.h>.
5086 (SIZE_MAX): Define if the headers do not.
5087 (verror): Do not give up if vsnprintf returns a negative count.
5088 Instead, grow the buffer. This ports to Windows vsnprintf, which
5089 does not conform to C99. Problem reported by Eli Zaretskii.
5090 Also, simplify the allocation scheme, by avoiding the need for
5091 calling realloc, and removing the ALLOCATED variable.
5092
70476b54
PE
5093 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5094
12020a9e
PE
5095 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5096 But keep the doprint source code for now, as we might revamp it
5097 and use it again (Bug#8435).
ea6c7ae6
PE
5098 * lisp.h (doprnt): Remove.
5099 * Makefile.in (base_obj): Remove doprnt.o.
5100 * deps.mk (doprnt.o): Remove.
5101
5fdb398c
PE
5102 error: Print 32- and 64-bit integers portably (Bug#8435).
5103 Without this change, on typical 64-bit hosts error ("...%d...", N)
5104 was used to print both 32- and 64-bit integers N, which relied on
5105 undefined behavior.
5106 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5107 New macro.
5108 * lisp.h (error, verror): Mark as printf-like functions.
5109 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5110 Report overflow in size calculations when allocating printf buffer.
5111 Do not truncate output string at its first null byte.
5112 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5113 Truncate the output at a character boundary, since vsnprintf does not
5114 do that.
5115 * charset.c (check_iso_charset_parameter): Convert internal
5116 character to string before calling 'error', since %c now has the
5117 printf meaning.
5118 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5119 overflow when computing char to be passed to 'error'. Do not
5120 pass Lisp_Object to 'error'; pass the integer instead.
5121 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5122 formatted with plain %d.
5123
b189fa66
PE
5124 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5125
bff87ef0
PE
5126 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5127
7e2cac20
PE
5128 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5129
ce4d90b5
PE
5130 * xterm.c (x_catch_errors): Remove duplicate declaration.
5131
266c9547
PE
5132 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5133
79c49ad2
PE
5134 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5135
368f4090
JM
51362011-04-10 Jim Meyering <meyering@redhat.com>
5137
5138 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5139 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5140 return ssize_t not "int", and use size_t as the buffer length.
5141 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5142 * gnutls.h: Update declarations.
5143 * process.c (read_process_output): Use ssize_t, to match.
5144 (send_process): Likewise.
5145
a32d4040
CY
51462011-04-09 Chong Yidong <cyd@stupidchicken.com>
5147
5148 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5149
8546720e 51502011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5151
04f2d78b
CB
5152 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5153 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5154
8546720e
GM
5155 * xterm.c (handle_one_xevent):
5156 * xmenu.c (create_and_show_popup_menu):
5157 * xselect.c (x_decline_selection_request)
5158 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5159
0a2f5c1a 51602011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5161
5162 Fix some uses of `int' instead of EMACS_INT.
5163 * search.c (string_match_1, fast_string_match)
5164 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5165 (scan_buffer, find_next_newline_no_quit)
5166 (find_before_next_newline, search_command, Freplace_match)
5167 (Fmatch_data): Make some `int' variables be EMACS_INT.
5168
5169 * xdisp.c (display_count_lines): 3rd argument and return value now
5170 EMACS_INT. All callers changed.
5171 (pint2hrstr): Last argument is now EMACS_INT.
5172
5173 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5174 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5175 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5176 (decode_coding_utf_16, decode_coding_emacs_mule)
5177 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5178 (decode_coding_ccl, decode_coding_charset)
5179 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5180 (decode_coding_iso_2022, decode_coding_emacs_mule)
5181 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5182 <char_offset, last_offset>: Declare EMACS_INT.
5183 (encode_coding_utf_8, encode_coding_utf_16)
5184 (encode_coding_emacs_mule, encode_invocation_designation)
5185 (encode_designation_at_bol, encode_coding_iso_2022)
5186 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5187 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5188 Declare EMACS_INT.
5189 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5190 (encode_invocation_designation): Last argument P_NCHARS is now
5191 EMACS_INT.
5192 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5193 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5194
5195 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5196 All users changed.
5197
5198 * ccl.c (Fccl_execute_on_string): Declare some variables
5199 EMACS_INT.
5200
8546720e 52012011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5202
5203 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5204
4e19a977
CS
52052011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5206
5207 * process.c (Fformat_network_address): Doc fix.
5208
87302331
R
52092011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5210
5211 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5212
cbb59342
CY
52132011-04-08 Chong Yidong <cyd@stupidchicken.com>
5214
5215 * keyboard.c (read_char): Call Lisp function help-form-show,
5216 instead of using internal_with_output_to_temp_buffer.
5217 (Qhelp_form_show): New var.
e0d38eeb 5218 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5219
5220 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5221
5222 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5223
e67a13ab
CY
52242011-04-06 Chong Yidong <cyd@stupidchicken.com>
5225
04f2d78b
CB
5226 * process.c (Flist_processes): Remove to Lisp.
5227 (list_processes_1): Delete.
e67a13ab 5228
973f782d
EZ
52292011-04-06 Eli Zaretskii <eliz@gnu.org>
5230
7c106b1e
EZ
5231 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5232
973f782d
EZ
5233 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5234
41cf7d1a 52352011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5236
ca23cc88
PE
5237 Fix more problems found by GCC 4.6.0's static checks.
5238
f390e2d5
PE
5239 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5240
42eea0d0
PE
5241 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5242
b69769da 5243 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5244
f9541e84
PE
5245 * xdisp.c (vmessage): Mark as a printf-like function.
5246
13841b55
PE
5247 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5248
c136c10f
PE
5249 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5250
5e2d4a30
PE
5251 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5252 printf-like functions.
5253 (tiff_load): Add casts to remove these marks before passing them
5254 to system-supplied API.
5255
583f48b9
PE
5256 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5257
b25d760e
PE
5258 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5259 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5260 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5261 directly, rather than having caller test rule sign. This avoids
5262 some unnecessary tests.
5263 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5264 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5265 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5266
bc7b6697 5267 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5268 (xfont_open): Avoid unnecessary tests.
bc7b6697 5269
27ccc379
PE
5270 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5271
dcd5c89a
PE
5272 * composite.h, composite.c (composition_gstring_put_cache):
5273 Use EMACS_INT, not int, for length.
5274
b13a45c6
PE
5275 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5276 breaking out part of COMPOSITION_DECODE_RULE.
5277 (COMPOSITION_DECODE_RULE): Use it.
5278 * composite.c (get_composition_id): Remove unused local vars,
5279 by using the new macro.
5280
1e792e4d
PE
5281 * textprop.c (set_text_properties_1): Change while to do-while,
5282 since the condition is always true at first.
5283
dc6c6455 5284 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5285 (interval_deletion_adjustment): Return unsigned value.
5286 All uses changed.
dc6c6455 5287
aba7731a
PE
5288 * process.c (list_processes_1, create_pty, read_process_output):
5289 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5290 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5291 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5292 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5293 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5294
fdfc4bf3
PE
5295 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5296
fca8fe46 5297 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5298 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5299
06a0259a 5300 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5301 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5302 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5303
e7b9e80f
PE
5304 * print.c (print_error_message): Avoid int overflow.
5305
56201685
PE
5306 * font.c (font_list_entities): Redo for clarity,
5307 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5308
78834453 5309 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5310 (font_score): Avoid potential overflow in diff calculation.
78834453 5311
0bc0b309 5312 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5313 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5314
e610eaca
PE
5315 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5316
b895abce
PE
5317 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5318 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5319 can always succeed if overflow has undefined behavior.
5320
1f1d9321 5321 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5322 (wordify): Omit three unnecessary tests.
1f1d9321 5323
c59478bc
PE
5324 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5325 All callers changed. This avoids the need for an unused var.
5326
79b73827
PE
5327 * casefiddle.c (casify_region): Remove var that is set but not used.
5328
a4db5dfe
PE
5329 * dired.c (file_name_completion): Remove var that is set but not used.
5330
43aae36e
PE
5331 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5332
2a47c44d 5333 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5334 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5335
a37c69bf
PE
5336 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5337 Check for integer overflow on size calculations.
5338
328ab8e7
PE
5339 * buffer.c (Fprevious_overlay_change): Remove var that is set
5340 but not used.
5341
e5a2a5cb
PE
5342 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5343 Remove vars that are set but not used.
8d84a6eb 5344 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5345 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5346
a60e5f68
PE
5347 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5348
f661cb61 5349 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5350 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5351
f0397f5a
PE
5352 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5353 that are set but not used.
5354
8664db06 5355 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5356 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5357
6abdaa4a
PE
5358 * xselect.c (x_get_local_selection, x_handle_property_notify):
5359 Remove vars that are set but not used.
5360
0ce7538d 5361 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5362 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5363
9ae848fc
PE
5364 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5365 Remove var that is set but not used.
0b918413
PE
5366 (scroll_bar_windows_size): Now size_t, not int.
5367 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5368 Check for overflow.
9ae848fc 5369
a5a62657
PE
5370 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5371 (map_tty_color) [!defined MSDOS]: Likewise.
5372
5c5cdd39
PE
5373 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5374
66ebf983
PE
5375 * coding.c: Remove vars that are set but not used.
5376 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5377 All callers changed.
5378 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5379 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5380 (decode_coding_charset): Remove vars that are set but not used.
5381
1be4d761
PE
5382 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5383 that is set but not used.
5384
47553fa8
PE
5385 * print.c (print_object): Remove var that is set but not used.
5386
1f7196bf 5387 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5388 The gnulib version avoids calling malloc in the usual case,
5389 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5390 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5391 * filelock.c (current_lock_owner): Likewise.
5392 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5393 * sysdep.c: Include allocator.h, careadlinkat.h.
5394 (emacs_no_realloc_allocator): New static constant.
5395 (emacs_readlink): New function.
fdb61804
PE
5396 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5397 ../lib/careadlinkat.h.
d1fdcab7 5398
f84c17c7
SM
53992011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5400
5401 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5402 first non-nil return value).
5403
ef3862ad
JD
54042011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5405
5406 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5407 if not defined (Bug#8403).
5408
376a7006
JB
54092011-04-02 Juanma Barranquero <lekktu@gmail.com>
5410
5411 * xdisp.c (display_count_lines): Remove parameter `start',
5412 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5413 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5414 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5415 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5416 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5417 and thereabouts. All callers changed.
5418 (get_per_char_metric): Remove parameter `f', unused since
5419 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5420
6ca3801d
JM
54212011-04-02 Jim Meyering <meyering@redhat.com>
5422
5423 do not dereference NULL upon failed strdup
5424 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5425 (ns_get_family): Likewise.
5426
d8e2b5ba
JB
54272011-04-02 Juanma Barranquero <lekktu@gmail.com>
5428
5429 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5430
8c74fcbd
JD
54312011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5432
5433 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5434 later (Bug#8403).
5435
7200d79c
SM
54362011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5437
03408648 5438 Add lexical binding.
7200d79c 5439
03408648
SM
5440 * window.c (Ftemp_output_buffer_show): New fun.
5441 (Fsave_window_excursion):
5442 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5443
5444 * lread.c (lisp_file_lexically_bound_p): New function.
5445 (Fload): Bind Qlexical_binding.
5446 (readevalloop): Remove `evalfun' arg.
5447 Bind Qinternal_interpreter_environment.
5448 (Feval_buffer): Bind Qlexical_binding.
5449 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5450 Mark as dynamic.
5451 (syms_of_lread): Declare `lexical-binding'.
5452
5453 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5454
5455 * keyboard.c (eval_dyn): New fun.
5456 (menu_item_eval_property): Use it.
ca105506
SM
5457
5458 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5459
03408648
SM
5460 * fns.c (concat, mapcar1): Accept byte-code-functions.
5461
5462 * eval.c (Fsetq): Handle lexical vars.
5463 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5464 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5465 (FletX, Flet): Obey lexical binding.
5466 (Fcommandp): Handle closures.
5467 (Feval): New `lexical' arg.
5468 (eval_sub): New function extracted from Feval. Use it almost
5469 everywhere where Feval was used. Look up vars in lexical env.
5470 Handle closures.
5471 (Ffunctionp): Move from subr.el.
5472 (Ffuncall): Handle closures.
5473 (apply_lambda): Remove `eval_flags'.
5474 (funcall_lambda): Handle closures and new byte-code-functions.
5475 (Fspecial_variable_p): New function.
5476 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5477 but without exporting it to Lisp.
23aba0ea 5478
23aba0ea 5479 * doc.c (Fdocumentation, store_function_docstring):
03408648 5480 * data.c (Finteractive_form): Handle closures.
23aba0ea 5481
03408648
SM
5482 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5483 interactive spec.
ba83908c 5484
04f2d78b
CB
5485 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5486 New byte-codes.
03408648
SM
5487 (exec_byte_code): New function extracted from Fbyte_code to handle new
5488 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5489
03408648 5490 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5491
03408648 5492 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5493
e2abce01
JB
54942011-03-31 Juanma Barranquero <lekktu@gmail.com>
5495
5496 * xdisp.c (redisplay_internal): Fix prototype.
5497
63696a73 54982011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5499
63696a73 5500 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5501 (try_scrolling): Use it when setting scroll_limit.
5502 Limit scrolling to 100 screen lines.
63696a73
EZ
5503 (redisplay_window): Even when falling back on "recentering",
5504 position point in the window according to scroll-conservatively,
5505 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5506
5507 (try_scrolling): When point is above the window, allow searching
5508 as far as scroll_max, or one screenful, to compute vertical
5509 distance from PT to the scroll margin position. This prevents
5510 try_scrolling from unnecessarily failing when
5511 scroll-conservatively is set to a value slightly larger than the
5512 window height. Clean up the case of PT below the margin at bottom
5513 of window: scroll_max can no longer be INT_MAX. When aggressive
5514 scrolling is in use, don't let point enter the opposite scroll
5515 margin as result of the scroll.
5516 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5517 threshold of 100 lines for never-recentering scrolling.
5518
e4cc2dfc
JB
55192011-03-31 Juanma Barranquero <lekktu@gmail.com>
5520
5521 * dispextern.h (move_it_by_lines):
5522 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5523 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5524 (message_log_check_duplicate): Remove parameters `prev_bol' and
5525 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5526 (redisplay_internal): Remove parameter `preserve_echo_area',
5527 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5528
5529 * indent.c (Fvertical_motion):
5530 * window.c (window_scroll_pixel_based, Frecenter):
5531 Don't pass `need_y_p' to `move_it_by_lines'.
5532
1c470562
SM
55332011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5534
44f230aa
SM
5535 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5536 steal a few bits to be more compact.
5537 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5538 Remove unneeded casts.
5539
1c470562
SM
5540 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5541
888adce9
ZK
55422011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5543
5544 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5545 binding" message (bug#7967).
5546
f838ed7b
PE
55472011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5548
77861b95
PE
5549 Fix more problems found by GCC 4.6.0's static checks.
5550
de6dbc14
PE
5551 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5552 Remove unused local var.
5553
f838ed7b
PE
5554 * editfns.c (Fmessage_box): Remove unused local var.
5555
792c7b2b
PE
5556 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5557 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5558 Omit unused local vars.
c499e557 5559 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5560 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5561 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5562 Omit unused local var.
5563
ba0165e1
PE
5564 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5565 Don't assume string length fits in int.
32ad8845 5566 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5567 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5568
3c59b4c9
PE
5569 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5570 instead of alloca (Bug#8344).
5571
a3eed478 5572 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5573 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5574
eb4d412d
PE
5575 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5576
1658b401
PE
5577 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5578 concerns.
5579
5580 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5581
5582 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5583
9a2c6e05
PE
5584 * keyboard.c (syms_of_keyboard): Use the same style as later
5585 in this function when indexing through an array. This also
5586 works around GCC bug 48267.
5587
03d0a109
PE
5588 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5589
44f730c8
PE
5590 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5591
fe75f926
PE
5592 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5593 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5594
ffa8c828
PE
5595 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5596 This avoids undefined behavior on integer overflow, and is a bit
5597 more convenient anyway since it is compared to a size_t variable.
5598
c5101a77
PE
5599 Variadic C functions now count arguments with size_t, not int.
5600 This avoids an unnecessary limitation on 64-bit machines, which
5601 caused (substring ...) to crash on large vectors (Bug#8344).
5602 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5603 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5604 All variadic functions and their callers changed accordingly.
c5101a77
PE
5605 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5606 * data.c (arith_driver, float_arith_driver): Likewise.
5607 * editfns.c (general_insert_function): Likewise.
5608 * eval.c (struct backtrace.nargs, interactive_p)
5609 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5610 (funcall_lambda, mark_backtrace): Likewise.
5611 * fns.c (concat): Likewise.
5612 * frame.c (x_set_frame_parameters): Likewise.
5613 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5614 0 if not found, not -1. All callers changed.
5615
dd3f25f7
PE
5616 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5617 (stack_copy_size): Now size_t, not int.
5618 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5619
461c2ab9
JB
56202011-03-28 Juanma Barranquero <lekktu@gmail.com>
5621
5622 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5623 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5624 All callers changed.
5625
5626 * lisp.h (multibyte_char_to_unibyte):
5627 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5628 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5629 * character.h (CHAR_TO_BYTE8):
5630 * cmds.c (internal_self_insert):
5631 * editfns.c (general_insert_function):
5632 * keymap.c (push_key_description):
5633 * search.c (Freplace_match):
5634 * xdisp.c (message_dolog, set_message_1): All callers changed.
5635
f6d62986
SM
56362011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5637
5638 * keyboard.c (safe_run_hook_funcall): New function.
5639 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5640 don't set the hook to nil, but remove the offending function instead.
5641 (Qcommand_hook_internal): Remove, unused.
5642 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5643 Vcommand_hook_internal.
5644
5645 * eval.c (enum run_hooks_condition): Remove.
5646 (funcall_nil, funcall_not): New functions.
5647 (run_hook_with_args): Call each function through a `funcall' argument.
5648 Remove `cond' argument, now redundant.
5649 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5650 (Frun_hook_with_args_until_failure): Adjust accordingly.
5651 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5652
1db5b1ad
JB
56532011-03-28 Juanma Barranquero <lekktu@gmail.com>
5654
5655 * dispextern.h (string_buffer_position): Remove declaration.
5656
5657 * print.c (strout): Remove parameter `multibyte', unused since
5658 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5659
5660 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5661 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5662 All callers changed.
5663
5664 * w32.c (_wsa_errlist): Use braces for struct initializers.
5665
5666 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5667 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5668 All callers changed.
5669 (string_buffer_position): Likewise. Also, make static (it's never
5670 used outside xdisp.c).
5671 (cursor_row_p): Remove parameter `w', unused since
5672 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5673 (decode_mode_spec): Remove parameter `precision', introduced during
5674 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5675 All callers changed.
5676
5ffb62aa
JD
56772011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5678
5679 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5680
461c2ab9 56812011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5682
5683 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5684 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5685 (ns_update_auto_hide_menu_bar): New functions.
5686 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5687 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5688 ns_constrain_all_frames.
5689 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5690 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5691
5c380ffb
JD
56922011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5693
5694 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5695
9af30bdf
GM
56962011-03-27 Glenn Morris <rgm@gnu.org>
5697
5698 * syssignal.h: Replace RETSIGTYPE with void.
5699 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5700 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5701 Replace SIGTYPE with void everywhere.
5702 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5703 * s/template.h (SIGTYPE): Remove commented out definition.
5704
e2abce01
JB
57052011-03-26 Eli Zaretskii <eliz@gnu.org>
5706
5707 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5708 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5709
f868cd8a
JB
57102011-03-26 Juanma Barranquero <lekktu@gmail.com>
5711
59eb0929
JB
5712 * w32.c (read_unc_volume): Use parameter `henum', instead of
5713 global variable `wget_enum_handle'.
5714
5715 * keymap.c (describe_vector): Remove parameters `indices' and
5716 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5717 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5718
f868cd8a
JB
5719 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5720
5721 * keyboard.c (timer_check): Remove parameter `do_it_now',
5722 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5723 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5724 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5725
5726 * keyboard.c (read_char):
5727 * w32menu.c (w32_menu_display_help):
5728 * xmenu.c (show_help_event, menu_help_callback):
5729 Adjust calls to `show_help_echo'.
5730
5731 * gtkutil.c (xg_maybe_add_timer):
5732 * keyboard.c (readable_events):
5733 * process.c (wait_reading_process_output):
5734 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5735
5736 * insdel.c (adjust_markers_gap_motion):
5737 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5738 (gap_left, gap_right): Don't call it.
5739
2ecf6fdb
CY
57402011-03-25 Chong Yidong <cyd@stupidchicken.com>
5741
5742 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5743 incurred during fontification.
5744
6b1f9ba4
JB
57452011-03-25 Juanma Barranquero <lekktu@gmail.com>
5746
5747 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5748 (DEFVAR_PER_BUFFER): Don't pass it.
5749
5750 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5751 (scrolling_window): Don't pass it.
5752
0f4a96b5
JB
57532011-03-25 Juanma Barranquero <lekktu@gmail.com>
5754
5755 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5756
5757 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5758 and `suffix'.
5759 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5760 of variables specific to SELinux and computation of `encoded_absname'.
5761
5762 * image.c (XPutPixel): Remove unused variable `height'.
5763
5764 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5765
5766 * unexw32.c (get_section_info): Remove unused variable `section'.
5767
5768 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5769 (system_process_attributes): Remove unused variable `sess'.
5770 (sys_read): Remove unused variable `err'.
5771
5772 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5773 (w32_wnd_proc): Remove unused variable `isdead'.
5774 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5775 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5776 (x_create_tip_frame): Remove unused variable `tem'.
5777
5778 * w32inevt.c (w32_console_read_socket):
5779 Remove unused variable `no_events'.
5780
5781 * w32term.c (x_draw_composite_glyph_string_foreground):
5782 Remove unused variable `width'.
5783
1149507c
JB
57842011-03-24 Juanma Barranquero <lekktu@gmail.com>
5785
5786 * w32term.c (x_set_glyph_string_clipping):
5787 Don't pass uninitialized region to CombineRgn.
5788
9c88f339
JB
57892011-03-23 Juanma Barranquero <lekktu@gmail.com>
5790
5791 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5792 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5793 (Fx_close_connection): Remove unused variable `i'.
5794
5795 * w32font.c (w32font_draw): Return number of glyphs.
5796 (w32font_open_internal): Remove unused variable `i'.
5797 (w32font_driver): Add missing initializer.
5798
5799 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5800 (fill_in_menu): Remove unused variable `items_added'.
5801
5802 * w32term.c (last_mouse_press_frame): Remove static global variable.
5803 (w32_clip_to_row): Remove unused variable `f'.
5804 (x_delete_terminal): Remove unused variable `i'.
5805
5806 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5807 (NOTHING): Remove unused static global variable.
5808 (uniscribe_check_otf): Remove unused variable `table'.
5809 (uniscribe_font_driver): Add missing initializers.
5810
dee091a3
JD
58112011-03-23 Julien Danjou <julien@danjou.info>
5812
5813 * term.c (Fsuspend_tty, Fresume_tty):
5814 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5815 * window.c (temp_output_buffer_show):
5816 * insdel.c (signal_before_change):
5817 * frame.c (Fhandle_switch_frame):
5818 * fileio.c (Fdo_auto_save):
5819 * emacs.c (Fkill_emacs):
5820 * editfns.c (save_excursion_restore):
5821 * cmds.c (internal_self_insert):
5822 * callint.c (Fcall_interactively):
5823 * buffer.c (Fkill_all_local_variables):
5824 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5825 Use Frun_hooks.
0f4a96b5 5826 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5827 unconditionnaly since it does the check itself.
5828
2c520ab5 58292011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5830
c9c49752
PE
5831 Fix more problems found by GCC 4.5.2's static checks.
5832
8abc3f12
PE
5833 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5834 the first time through the loop, since we know p0 < p1 then.
5835 This also avoids a gcc -Wstrict-overflow warning.
5836
a2d26660
PE
5837 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5838 leading to a memory leak, possible in functions like
5839 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5840 of objects (Bug#8318).
a2d26660 5841
916c72e9
PE
5842 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5843 that could (at least in theory) be that large.
5844
19ab8a18
PE
5845 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5846 This is less likely to overflow, and avoids undefined behavior if
5847 overflow does occur. All callers changed. Use strtoul to scan
5848 for the unsigned long integer.
b7cbbd6f
PE
5849 (pint2hrstr): Simplify and tune code slightly.
5850 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5851
f0641eff
PE
5852 * scroll.c (do_scrolling): Work around GCC bug 48228.
5853 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5854
7f650bb9
PE
5855 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5856 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5857 (validate_x_resource_name): Simplify count usage.
5858 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5859
37dd57d1
PE
5860 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5861 fail (Bug#8306).
81e56e61 5862
699979fc 5863 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5864
401bf9b4
PE
5865 * process.c (Fmake_network_process): Use socklen_t, not int,
5866 where POSIX says socklen_t is required in portable programs.
5867 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5868 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5869 (Fmake_network_process, server_accept_connection):
5870 (wait_reading_process_output, read_process_output):
5871 Likewise.
5872
b93aacde
PE
5873 * process.c: Rename or move locals to avoid shadowing.
5874 (list_processes_1, Fmake_network_process):
5875 (read_process_output_error_handler, exec_sentinel_error_handler):
5876 Rename or move locals.
4dc343ee 5877 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5878 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5879 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5880 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5881 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5882
af8a867c 5883 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5884 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5885 Include tparam.h instead, since it declares them.
af8a867c
PE
5886 * cm.h (PC): Remove extern decl; tparam.h now does this.
5887 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5888 * terminfo.c: Include tparam.h, to check interfaces.
5889 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5890 (tparam): Adjust signature to match interface in tparam.h;
5891 this removes some undefined behavior. Check that outstring and len
5892 are zero, which they always are with Emacs.
5893 * tparam.h (PC, BC, UP): New extern decls.
5894
0248044d 5895 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5896 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5897
8ff096c1 5898 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5899 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5900 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5901 (ftfont_list): Remove unused local.
49eaafba
PE
5902 (get_adstyle_property, ftfont_pattern_entity):
5903 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5904 Rename locals to avoid shadowing.
8ff096c1 5905
e2be39f6
PE
5906 * xfont.c (xfont_list_family): Mark var as initialized.
5907
c9735e30
PE
5908 * xml.c (make_dom): Now static.
5909
8f5201ae
PE
5910 * composite.c (composition_compute_stop_pos): Rename local to
5911 avoid shadowing.
b246f932
PE
5912 (composition_reseat_it): Remove unused locals.
5913 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5914 (composition_update_it): Mark var as initialized.
11b61122
PE
5915 (find_automatic_composition): Mark vars as initialized,
5916 with a FIXME (Bug#8290).
8f5201ae 5917
760fbc2c
PE
5918 character.h: Rename locals to avoid shadowing.
5919 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5920 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5921 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5922 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5923 to avoid shadowing.
5924
ff08eb85
PE
5925 * textprop.c (property_change_between_p): Remove; unused.
5926
fc7bf025
PE
5927 * intervals.c (interval_start_pos): Now static.
5928
235d7abc
PE
5929 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5930
44f230aa
SM
5931 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5932 Rename locals to avoid shadowing.
3e7d6594 5933
50060332
PE
5934 * sound.c (wav_play, au_play, Fplay_sound_internal):
5935 Fix pointer signedness.
d01f234b 5936 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5937 (wav_play): Initialize a variable to 0, to prevent undefined
5938 behavior (Bug#8278).
50060332 5939
c4fc4e30
PE
5940 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5941
918436ed
PE
5942 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5943
c939f91b
PE
5944 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5945 clobbering (Bug#8298).
b9c7f648
PE
5946 * sysdep.c (sys_subshell): Likewise.
5947 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5948
6bd8c144
PE
5949 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5950 This should get cleaned up, so that child_setup has the
5951 same signature on all platforms.
5952
7710357c 5953 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5954 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5955
c59da222
CY
59562011-03-22 Chong Yidong <cyd@stupidchicken.com>
5957
5958 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5959 not to be necessary, and produces flickering.
5960
66b87493
GM
59612011-03-20 Glenn Morris <rgm@gnu.org>
5962
5963 * config.in: Remove file.
5964
45b6f6d5
JB
59652011-03-20 Juanma Barranquero <lekktu@gmail.com>
5966
5967 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5968 are now in src/globals.h.
5969 (syms_of_minibuf): Remove spurious & from previous change.
5970
3ec03f7e
LL
59712011-03-20 Leo <sdl.web@gmail.com>
5972
5973 * minibuf.c (completing-read-function): New variable.
5974 (completing-read-default): Rename from completing-read.
5975 (completing-read): Call completing-read-function.
5976
b14e3e21
CY
59772011-03-19 Juanma Barranquero <lekktu@gmail.com>
5978
5979 * xfaces.c (Fx_load_color_file):
5980 Read color file from absolute filename (bug#8250).
5981
f2b726e6
JB
59822011-03-19 Juanma Barranquero <lekktu@gmail.com>
5983
5984 * makefile.w32-in: Update dependencies.
5985
09f6ff02
EZ
59862011-03-17 Eli Zaretskii <eliz@gnu.org>
5987
5988 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5989
29a6015a
PE
59902011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5991
a3a6c54e
PE
5992 Fix more problems found by GCC 4.5.2's static checks.
5993
b766f867
PE
5994 * process.c (make_serial_process_unwind, send_process_trap):
5995 (sigchld_handler): Now static.
5996
be02381c
PE
5997 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5998 That way, the code declares only the vars that it needs.
5999 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6000 * s/cygwin.h (PTY_ITERATION): Likewise.
6001 * s/darwin.h (PTY_ITERATION): Likewise.
6002 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6003
57048744
PE
6004 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6005 * process.c (allocate_pty): Don't declare stb unless it's needed.
6006
7914961c 6007 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6008 (CONSTANTLIM): Remove; unused.
6009 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6010 Define only if needed.
7914961c 6011
b3967b18
PE
6012 * unexelf.c (unexec): Name an expression,
6013 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6014 Use a different way to cause a compilation error if anyone uses
6015 n rather than nn, a way that does not involve shadowing.
73366a00 6016 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6017
29a6015a
PE
6018 * deps.mk (unexalpha.o): Remove; unused.
6019
43cfc33e 6020 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6021 * unexec.h: New file.
ce701a33
PE
6022 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6023 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6024 Depend on unexec.h.
6025 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6026 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6027 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6028 Change as necessary to match prototype in unexec.h.
ce701a33 6029
01f44d5a
PE
6030 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6031 shadowing.
4f63c6bb 6032 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6033
a6670b0b
PE
6034 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6035 Rename locals to avoid shadowing.
6036
cef2010d 6037 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6038 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6039
d4d7173a
PE
6040 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6041
f08b802a
PE
6042 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6043 warning when compiling print.c.
6044
3ddb0639
PE
6045 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6046 instead of using an uninitialized var.
5ad03b97 6047 (font_sort_entities): Mark var as initialized.
3ddb0639 6048
170a2692
PE
6049 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6050
e663c700
PE
6051 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6052 pointers to constants.
89bc529a 6053 (font_parse_fcname): Remove unused vars.
7b81e2d0 6054 (font_delete_unmatched): Now static.
ea838e10 6055 (font_get_spec): Remove; unused.
13a547c6
PE
6056 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6057 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6058 Rename or move locals to avoid shadowing.
e663c700 6059
2a80c887 6060 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6061 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6062
1384fa33 6063 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6064 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6065
8b2c52e9
PE
6066 * alloc.c (mark_backtrace): Move decl from here ...
6067 * lisp.h: ... to here, so that it can be checked.
6068
475545b5 6069 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6070 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6071 (lisp_indirect_variable): Name an expression,
6072 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6073 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6074
b1349114 6075 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6076 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6077 Use const pointer when appropriate.
b1349114 6078
a2928364
PE
6079 * lisp.h (get_system_name, get_operating_system_release):
6080 Move decls here, to check interfaces.
6081 * process.c (get_operating_system_release): Move decl to lisp.h.
6082 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6083 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6084 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6085 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6086 (Fformat_time_string, Fencode_time, Finsert_char):
6087 (Ftranslate_region_internal, Fformat):
6088 Rename or remove local vars to avoid shadowing.
9710023e 6089 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6090
a415e694
PE
6091 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6092 avoid shadowing.
6093
8ef4622d
PE
6094 * lisp.h (eassert): Check that the argument compiles, even if
6095 ENABLE_CHECKING is not defined.
6096
946f9a5b
PE
6097 * data.c (Findirect_variable): Name an expression, to avoid
6098 gcc -Wbad-function-cast warning.
112396d6 6099 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6100 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6101 (Fmake_variable_buffer_local, Fmake_local_variable):
6102 Mark variables as initialized.
52746918 6103 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6104
e5aab7e7 6105 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6106 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6107 Rename locals to avoid shadowing.
dff45157
PE
6108 (mark_stack): Move local variables into the #ifdef region where
6109 they're used.
7bc26fdb
PE
6110 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6111 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6112 needed otherwise.
6113 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6114 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6115 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6116
e5aab7e7
PE
6117 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6118 avoids undefined behavior in theory.
6119
4da60324
PE
6120 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6121
88043301
PE
6122 Use functions, not macros, for up- and down-casing (Bug#8254).
6123 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6124 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6125 to use the following functions instead of these macros.
6126 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6127 EMACS_INT, since callers assume the returned value fits in int.
6128 (upcase1): Likewise, for UPCASE_TABLE.
6129 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6130 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6131 the race-condition problem in the old DOWNCASE.
88043301 6132
19ed5445
PE
6133 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6134 Rename locals to avoid shadowing.
6135 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6136 (regex_compile, re_search_2, re_match_2_internal):
6137 Remove unused local vars.
952db0d7
PE
6138 (FREE_VAR): Rewrite so as not to use empty "else",
6139 which gcc can warn about.
da053e48 6140 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6141 (RETALLOC_IF): Define only if needed.
6142 (WORDCHAR_P): Likewise. This one is never needed, but is used
6143 only in a comment talking about a compiler bug, so put inside
6144 the #if 0 of that comment.
6145 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6146 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6147 Remove; unused.
19ed5445 6148
1f3561e4 6149 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6150 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6151 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6152
ded6f8f7
PE
6153 * search.c (simple_search): Remove unused var.
6154
dbd37a95
PE
6155 * dired.c (compile_pattern): Move decl from here ...
6156 * lisp.h: ... to here, so that it can be checked.
6157 (struct re_registers): New forward decl.
6158
7e47afad
PE
6159 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6160
85f24f61
PE
6161 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6162 All uses changed.
6163 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6164 Rename locals to avoid shadowing.
5671df8f 6165 (Fvertical_motion): Mark locals as initialized.
85f24f61 6166
181aa2be 6167 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6168 (casify_region): Mark local as initialized.
181aa2be 6169
930d429c
PE
6170 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6171
7082eac6
PE
6172 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6173 New macros, so that the caller can use some names other than
6174 gcpro1, gcpro2, etc.
6175 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6176 of the new macros.
6177 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6178 argument, for consistency with GCPRO2_VAR, etc: it is now the
6179 prefix of the variable, not the variable itself. All uses
6180 changed.
38b2c076
PE
6181 * dired.c (directory_files_internal, file_name_completion):
6182 Rename locals to avoid shadowing.
6183
15206ed9
PE
6184 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6185 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6186 dired.c's scmp function, had undefined behavior.
6187 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6188 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6189 * buffer.h: ... to here, because these macros use current_buffer,
6190 and the new implementation with inline functions needs to have
6191 current_buffer in scope now, rather than later when the macros
6192 are used.
6193 (downcase, upcase1): New static inline functions.
6194 (DOWNCASE, UPCASE1): Reimplement using these functions.
6195 This avoids undefined behavior in expressions like
6196 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6197 from race conditions in accessing the global variables
6198 case_temp1 and case_temp2.
6199 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6200 * lisp.h (case_temp1, case_temp2): Remove their decls.
6201 * character.h (ASCII_CHAR_P): Move from here ...
6202 * lisp.h: ... to here, so that the inline functions mentioned
6203 above can use them.
6204
4a6bea26
PE
6205 * dired.c (directory_files_internal_unwind): Now static.
6206
f14b7e14
PE
6207 * fileio.c (file_name_as_directory, directory_file_name):
6208 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6209 Now static.
2893f146
PE
6210 (file_name_as_directory): Use const pointers when appropriate.
6211 (Fexpand_file_name): Likewise. In particular, newdir might
6212 point at constant storage, so make it a const pointer.
fd4ead52 6213 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6214 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6215 signedness issues.
f839df0c
PE
6216 (Fset_file_times, Finsert_file_contents, auto_save_error):
6217 Rename locals to avoid shadowing.
f14b7e14 6218
5716756e 6219 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6220 (Ftry_completion, Fall_completions): Rename or remove locals
6221 to avoid shadowing.
5716756e 6222
b4c3046a
PE
6223 * marker.c (bytepos_to_charpos): Remove; unused.
6224
b45db522
PE
6225 * lisp.h (verify_bytepos, count_markers): New decls,
6226 so that gcc does not warn that these functions aren't declared.
6227
85876d07
PE
6228 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6229 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6230 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6231 (copy_text): Remove unused local var.
85876d07 6232
03d78a21 6233 * filelock.c (within_one_second): Now static.
b3dd38ab 6234 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6235
5df8f01b
PE
6236 * buffer.c (fix_overlays_before): Mark locals as initialized.
6237 (fix_start_end_in_overlays): Likewise. This function should be
6238 simplified by using pointers-to-pointers, but that's a different
6239 matter.
b1d876f1 6240 (switch_to_buffer_1): Now static.
8f54f30a
PE
6241 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6242 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6243
a70072c9 6244 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6245 Fix pointer signedness issue.
edced198
PE
6246 (sys_subshell): Mark local as volatile if checking for lint,
6247 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6248 (MAXPATHLEN): Define only if needed.
a70072c9 6249
a0977c44
PE
6250 * process.c (serial_open, serial_configure): Move decls from here ...
6251 * systty.h: ... to here, so that they can be checked.
6252
a884fdcc
PE
6253 * fns.c (get_random, seed_random): Move extern decls from here ...
6254 * lisp.h: ... to here, so that they can be checked.
6255
604efe86 6256 * sysdep.c (reset_io): Now static.
b8950c94 6257 (wait_for_termination_signal): Remove; unused.
604efe86 6258
38fc62d9
PE
6259 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6260 (copy_keymap_item, append_key, push_text_char_description):
6261 Now static.
1004a21a 6262 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6263 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6264 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6265 (describe_map_tree):
6266 Rename locals to avoid shadowing.
38fc62d9 6267
2f2650da
PE
6268 * keyboard.c: Declare functions static if they are not used elsewhere.
6269 (echo_char, echo_dash, cmd_error, top_level_2):
6270 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6271 (read_char, kbd_buffer_get_event, make_lispy_position):
6272 (make_lispy_event, make_lispy_movement, apply_modifiers):
6273 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6274 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6275 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6276 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6277 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6278
a053e86c 6279 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6280 (mark_kboards): Move decl here ...
6281 * alloc.c (mark_kboards): ... from here.
a053e86c 6282
4752793e
PE
6283 * lisp.h (force_auto_save_soon): New decl.
6284
74f10ca7 6285 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6286 (DEFINE_DUMMY_FUNCTION): New macro.
6287 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6288 Use it.
c03cd23f
PE
6289 (main): Add casts to avoid warnings
6290 if GCC considers string literals to be constants.
74f10ca7 6291
022e70d4
PE
6292 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6293
59d6fe83
PE
6294 * dbusbind.c: Pointer signedness fixes.
6295 (xd_signature, xd_append_arg, xd_initialize):
6296 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6297 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6298 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6299 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6300
78320123
PE
6301 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6302 if GCC considers string literals to be constants.
49cebcca 6303 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6304
35ac2a97
SM
63052011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6306
fb103ca9
SM
6307 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6308 (print_preprocess, print_object): New macro to fix last change.
6309
35ac2a97
SM
6310 * print.c (print_preprocess): Don't forget font objects.
6311
62973b41
JB
63122011-03-16 Juanma Barranquero <lekktu@gmail.com>
6313
6314 * emacs.c (USAGE3): Doc fixes.
6315
0e48bb22
AS
63162011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6317
6318 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6319 structure.
6320
7684e57b
JB
63212011-03-14 Juanma Barranquero <lekktu@gmail.com>
6322
6323 * lisp.h (VWindow_system, Qfile_name_history):
6324 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6325 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6326 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6327
6328 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6329 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6330
6331 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6332 * w32console.c (detect_input_pending, read_input_pending)
6333 (encode_terminal_code):
6334 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6335 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6336 (w32_system_caret_y, Qfile_name_history):
6337 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6338 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6339 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6340 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6341 * w32proc.c (Qlocal, report_file_error):
6342 * w32term.c (Vwindow_system, updating_frame):
6343 * w32uniscribe.c (initialized, uniscribe_font_driver):
6344 Remove unneeded extern declarations.
6345
2aa46d6c
CY
63462011-03-14 Chong Yidong <cyd@stupidchicken.com>
6347
c96bbc66 6348 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6349
cffc6f3b
CY
63502011-03-13 Chong Yidong <cyd@stupidchicken.com>
6351
6352 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6353 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6354 These macros can no longer be used for assignment.
6355
44f230aa
SM
6356 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6357 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6358 (record_buffer_markers, fetch_buffer_markers): New functions for
6359 recording and fetching special buffer markers.
6360 (set_buffer_internal_1, set_buffer_temp): Use them.
6361
6362 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6363
6364 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6365
6366 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6367 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6368
6369 * xdisp.c (hscroll_window_tree):
6370 (reconsider_clip_changes): Use PT instead of BUF_PT.
6371
d251f04b
EZ
63722011-03-13 Eli Zaretskii <eliz@gnu.org>
6373
6374 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6375 $(EMACS_ROOT)/lib/intprops.h.
6376
f0c77cd1
PE
63772011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6378
3eca4629
PE
6379 Fix more problems found by GCC 4.5.2's static checks.
6380
7c86ee98
PE
6381 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6382 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6383 (xg_free_frame_widgets): Make it clear that a local variable is
6384 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6385 (gdk_window_get_screen): Make it clear that this macro is needed
6386 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6387 (int_gtk_range_get_value): New function, which avoids a diagnostic
6388 from gcc -Wbad-function-cast.
6389 (xg_set_toolkit_scroll_bar_thumb): Use it.
6390 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6391 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6392 (get_utf8_string, xg_get_file_with_chooser):
6393 Rename locals to avoid shadowing.
6394 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6395
41729b81
PE
6396 * xgselect.c (xg_select): Remove unused var.
6397
f0c77cd1
PE
6398 * image.c (four_corners_best): Mark locals as initialized.
6399 (gif_load): Initialize transparent_p to zero (Bug#8238).
6400 Mark another local as initialized.
ec6cf4c6 6401 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6402
ce0ad53d 6403 * image.c (clear_image_cache): Now static.
d5d5a617 6404 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6405 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6406 (x_edge_detection): Remove unnecessary cast that
6407 gcc -Wbad-function-cast diagnoses.
2037898d 6408 (gif_load): Fix pointer signedness.
6ae141d6
PE
6409 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6410 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6411
33383987 64122011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6413
d32df629
PE
6414 Improve quality of tests for time stamp overflow.
6415 For example, without this patch (encode-time 0 0 0 1 1
6416 1152921504606846976) returns the obviously-bogus value (-948597
6417 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6418 reports time overflow. See
6419 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6420 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6421 * editfns.c: Include limits.h and intprops.h.
6422 (TIME_T_MIN, TIME_T_MAX): New macros.
6423 (time_overflow): Move earlier, to before first use.
6424 (hi_time, lo_time): New functions, for an accurate test for
6425 out-of-range times.
6426 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6427 (Fget_internal_run_time): Don't assume time_t fits in int.
6428 (make_time): Use list2 instead of Fcons twice.
6429 (Fdecode_time): More accurate test for out-of-range times.
6430 (check_tm_member): New function.
6431 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6432 (lisp_time_argument): Don't rely on undefined left-shift and
6433 right-shift behavior when checking for time stamp overflow.
8be6f318 6434
fe31d94c
PE
6435 * editfns.c (time_overflow): New function, refactoring common code.
6436 (Fformat_time_string, Fdecode_time, Fencode_time):
6437 (Fcurrent_time_string): Use it.
6438
8be6f318
PE
6439 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6440 * dired.c (make_time): Move to ...
6441 * editfns.c (make_time): ... here.
6442 * systime.h: Note the move.
6443
09d9db2c 64442011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6445
126bc0dc
YM
6446 * fringe.c (update_window_fringes): Remove unused variables.
6447
c47cbdfd
YM
6448 * unexmacosx.c (copy_data_segment): Also copy __got section.
6449 (Bug#8223)
6450
7ac80be9
EZ
64512011-03-12 Eli Zaretskii <eliz@gnu.org>
6452
c96bbc66 6453 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6454 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6455 Constify `char *' arguments and their references according to
6456 prototypes in tparam.h.
6457
ecb0f94d 6458 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6459
7ac80be9
EZ
6460 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6461 Adapt all references accordingly.
6462
6463 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6464
ef1fd07e
TT
64652011-03-11 Tom Tromey <tromey@redhat.com>
6466
6467 * buffer.c (syms_of_buffer): Remove obsolete comment.
6468
7ef4b50c
EZ
64692011-03-11 Eli Zaretskii <eliz@gnu.org>
6470
6471 * termhooks.h (encode_terminal_code): Declare prototype.
6472
6473 * msdos.c (encode_terminal_code): Don't declare prototype.
6474
6475 * term.c (encode_terminal_code): Now external again, used by
6476 w32console.c and msdos.c.
6477
44f230aa
SM
6478 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6479 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6480
4b1ec863 64812011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6482
1714f52b 6483 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6484
4b1ec863
PE
6485 * fringe.c (update_window_fringes): Mark locals as initialized
6486 (Bug#8227).
6487 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6488
524c7aa6
PE
6489 * alloc.c (mark_fringe_data): Move decl from here ...
6490 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6491 to check its interface.
6492 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6493
a5c0af81 6494 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6495 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6496 (fontset_font): Mark local as initialized.
a9a06e0b 6497 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6498
b4716021
PE
6499 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6500
811e9bac 6501 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6502 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6503 (x_own_selection, Fx_disown_selection_internal): Rename locals
6504 to avoid shadowing.
6505 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6506
7e3ab302
PE
6507 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6508 so that the caller can use some name other than gcpro1.
6509 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6510 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6511 (Fx_backspace_delete_keys_p):
6512 Use them to avoid shadowing, and rename vars to avoid shadowing.
6513 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6514 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6515 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6516 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6517 Remove unused locals.
7e3ab302
PE
6518 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6519 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6520 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6521 macros.
f78faa98 6522
e2b13473
PE
6523 * xterm.h (x_mouse_leave): New decl.
6524
77f23912
PE
6525 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6526 Remove unused functions.
cdf4ba58
PE
6527 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6528 (x_calc_absolute_position): Now static.
7411c686 6529 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6530 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6531 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6532 unless they are used.
38d0b34a
PE
6533 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6534 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6535 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6536 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6537 (x_error_catcher, x_connection_closed, x_error_handler):
6538 (x_error_quitter, xembed_send_message, x_iconify_frame):
6539 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6540 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6541 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6542
44f230aa
SM
6543 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6544 Rename or move locals to avoid shadowing.
6b463e58 6545 (tty_defined_color, merge_face_heights): Now static.
5967d051 6546 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6547 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6548 does not deduce is never used uninitialized.
73719eba
PE
6549 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6550 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6551
426994c3 6552 * terminal.c (store_terminal_param): Now static.
5489860b 6553
032f1620 6554 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6555 (set_frame_menubar): Remove unused local.
d4323972 6556 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6557 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6558 since they might point to immutable storage.
281585b0
PE
6559 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6560 since it's unused otherwise.
032f1620 6561
367c19e5 6562 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6563 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6564 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6565 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6566 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6567 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6568 does not deduce are never used uninitialized.
70739cbe 6569
07b48fa9
PE
6570 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6571
8868a238 6572 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6573 * window.c (window_loop, size_window):
6574 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6575
7e5cf297 6576 * window.c (display_buffer): Now static.
d6550a9f
PE
6577 (size_window): Mark variables that gcc -Wuninitialized
6578 does not deduce are never used uninitialized.
a586633d
PE
6579 * window.h (check_all_windows): New decl, to forestall
6580 gcc -Wmissing-prototypes diagnostic.
5b555da1 6581 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6582
f6095868
PE
6583 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6584 shadowing.
6585 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6586 Include <limits.h>.
6587 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6588 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6589 (load_charset_map): Mark variables that gcc -Wuninitialized
6590 does not deduce are never used uninitialized.
53df7c11 6591 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6592
f38b440c
PE
6593 * coding.c (coding_set_source, coding_set_destination):
6594 Use "else { /* comment */ }" rather than "else /* comment */;"
6595 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6596 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6597 a block, when the outer 'i' will do.
6598 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6599 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6600 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6601 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6602 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6603 Rename locals to avoid shadowing.
6604 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6605 * coding.c (emacs_mule_char, encode_invocation_designation):
6606 Now static, since they're not used elsewhere.
413bb2db 6607 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6608 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6609 (decode_coding_emacs_mule): Mark variables that gcc
6610 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6611 (detect_coding_iso_2022): Initialize a local variable that might
6612 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6613 this initialization is needed. (Bug#8211)
5f58e762
PE
6614 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6615 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6616 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6617 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6618 Remove unused macros.
f38b440c 6619
232b38b9 6620 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6621 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6622 * character.c (string_count_byte8): Likewise.
232b38b9 6623
fb90da1b
PE
6624 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6625 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6626
fb93dbc2
PE
6627 * chartab.c (copy_sub_char_table): Now static, since it's not used
6628 elsewhere.
5c156ace
PE
6629 (sub_char_table_ref_and_range, char_table_ref_and_range):
6630 Rename locals to avoid shadowing.
bbcd0949 6631 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6632
7d3b3862 6633 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6634 (BIDI_BOB): Remove unused macro.
7d3b3862 6635
6be7d3da
PE
6636 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6637 deduce are never used uninitialized.
c2ed9c8b 6638 * term.c (encode_terminal_code): Likewise.
6be7d3da 6639
75f8807f 6640 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6641
50938595
PE
6642 * tparam.h: New file.
6643 * term.c, tparam.h: Include it.
6644 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6645 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6646 Move these decls to tparam.h, and make them agree with what
6647 is actually in tparam.c. The previous trick of using incompatible
6648 decls in different modules does not conform to the C standard.
6649 All callers of tparam changed to use tparam's actual API.
6650 * tparam.c (tparam1, tparam, tgoto):
6651 Use const pointers where appropriate.
6652
fbceeba2
PE
6653 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6654 * cm.h (struct cm): Likewise.
6655 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6656 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6657 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6658 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6659 (turn_on_face, init_tty): Likewise.
6660 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6661
7f3f1250
PE
6662 * term.c (term_mouse_position): Rename local to avoid shadowing.
6663
e6ca6543
PE
6664 * alloc.c (mark_ttys): Move decl from here ...
6665 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6666
c40f8d15
AS
66672011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6668
6669 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6670
cfe0661d
JB
66712011-03-09 Juanma Barranquero <lekktu@gmail.com>
6672
6673 * search.c (compile_pattern_1): Remove argument regp, unused since
6674 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6675 (compile_pattern): Don't pass it.
6676
0afb4571
J
66772011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6678
6679 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6680 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6681 for ! HAVE_GTK3.
6682 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6683
6684 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6685
6686 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6687 gdk_window_get_screen, gdk_window_get_geometry,
6688 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6689 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6690 (xg_get_pixbuf_from_pixmap): New function.
6691 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6692 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6693 Call xg_get_pixbuf_from_pixmap instead of
6694 gdk_pixbuf_get_from_drawable.
6695 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6696 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6697 (xg_check_special_colors): Use GtkStyleContext and its functions
6698 for HAVE_GTK3.
6699 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6700 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6701 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6702 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6703 Call gtk_widget_get_preferred_size.
0afb4571
J
6704 (xg_frame_resized): gdk_window_get_geometry only takes 5
6705 parameters.
44f230aa
SM
6706 (xg_win_to_widget, xg_event_is_for_menubar):
6707 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6708 (xg_set_widget_bg): New function.
6709 (delete_cb): New function.
895009e1 6710 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6711 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6712 (xg_set_background_color): Call xg_set_widget_bg.
6713 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6714 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6715 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6716 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6717 if ! HAVE_GTK3.
6718 (update_frame_tool_bar): Call gtk_widget_hide.
6719 (xg_initialize): Use GDK_KEY_g.
6720
6721 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6722 if ! HAVE_GTK3
6723 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6724
6725 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6726 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6727 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6728
1c2cc4ef
JB
67292011-03-08 Juanma Barranquero <lekktu@gmail.com>
6730
6731 * w32xfns.c (select_palette): Check success of RealizePalette against
6732 GDI_ERROR, not zero.
6733
33383987 6734See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6735
6736;; Local Variables:
6737;; coding: utf-8
aac0c6e3
MR
6738;; End:
6739
33383987 6740 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6741
6742 This file is part of GNU Emacs.
6743
6744 GNU Emacs is free software: you can redistribute it and/or modify
6745 it under the terms of the GNU General Public License as published by
6746 the Free Software Foundation, either version 3 of the License, or
6747 (at your option) any later version.
6748
6749 GNU Emacs is distributed in the hope that it will be useful,
6750 but WITHOUT ANY WARRANTY; without even the implied warranty of
6751 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6752 GNU General Public License for more details.
6753
6754 You should have received a copy of the GNU General Public License
6755 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.