1 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4 members before the level stack, so they would be saved and
5 restored when copying iterator state. Fixes incorrect reordering
6 around TABs covered by display properties.
8 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
10 * process.c (Fnetwork_interface_list): Correctly determine buffer
13 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
15 * eval.c (internal_condition_case, internal_condition_case_1)
16 (internal_condition_case_2, internal_condition_case_n): Remove
17 unnecessary aborts (Bug#9081).
19 2011-08-17 Eli Zaretskii <eliz@gnu.org>
21 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
22 has no `load' handler, try opening the file locally. (Bug#9311)
24 2011-08-16 Ken Brown <kbrown@cornell.edu>
26 * gmalloc.c: Expand comment.
28 2011-08-16 Eli Zaretskii <eliz@gnu.org>
30 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
31 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
33 2011-08-16 Ken Brown <kbrown@cornell.edu>
35 Fix memory allocation problems in Cygwin build (Bug#9273).
37 * unexcw.c ( __malloc_initialized): Declare external variable.
38 (fixup_executable): Force the dumped emacs to reinitialize malloc.
40 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo): New
42 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
44 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
46 [CYGWIN] (special_realloc): New function.
47 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
48 requests to realloc storage in the static heap.
50 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
52 * bidi.c (bidi_initialize): Remove unused local.
54 2011-08-15 Eli Zaretskii <eliz@gnu.org>
56 * biditype.h: File removed.
58 * bidimirror.h: File removed.
60 * deps.mk (bidi.o): Remove biditype.h and
63 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
66 * dispextern.h: Fix a typo in the comment to bidi_type_t.
68 * chartab.c: Improve commentary for the uniprop_table API.
70 * bidi.c (bidi_paragraph_init): Support zero value of
71 bidi_ignore_explicit_marks_for_paragraph_level.
72 (bidi_initialize): Use uniprop_table instead of including
73 biditype.h and bidimirror.h.
75 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
76 coordinates of the iterator when restoring from ppos_it.
79 2011-08-14 Kenichi Handa <handa@m17n.org>
81 * process.c (create_process): Call setup_process_coding_systems
82 after the pid of the process is set to -1 (Bug#8162).
84 2011-08-14 Eli Zaretskii <eliz@gnu.org>
86 * xdisp.c (move_it_in_display_line_to): Don't invoke
87 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
88 ppos_it. Fixes vertical cursor motion when line beginning is
89 covered by an image. (Bug#9296)
91 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
93 * nsterm.h (ns_run_ascript): Declare.
94 (NSAPP_DATA2_RUNASSCRIPT): Define.
96 * nsfns.m (as_script, as_result, as_status): New static variables.
97 (ns_run_ascript): New function.
98 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
99 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
100 the event loop. Get status from as_status (Bug#7276).
102 * nsterm.m (sendEvent): If event is NSApplicationDefined and
103 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
104 the event loop (Bug#7276).
106 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
108 * gnutls.c (QCgnutls_bootprop_priority)
109 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
110 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
111 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
112 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
113 (QCgnutls_bootprop_verify_hostname_error)
114 (QCgnutls_bootprop_callbacks_verify): Rename from
115 Qgnutls_bootprop_..., all uses changed.
117 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
120 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
122 * xfaces.c (Qframe_set_background_mode): Now static.
123 * dispextern.h (Qframe_set_background_mode): Remove decl.
125 * process.c (Fnetwork_interface_info): Declare local only if needed.
127 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
129 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
130 (Fnetwork_interface_list): Allocate in increments of bytes instead
131 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
132 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
134 (struct ifflag_def): notrailers is smart on OSX.
135 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
136 Get hardware address with getifaddrs if available.
138 2011-08-12 Eli Zaretskii <eliz@gnu.org>
140 * xdisp.c (iterate_out_of_display_property): xassert that
141 IT->position is set to within IT->object's boundaries. Break from
142 the loop as soon as EOB is reached; avoids infloops in redisplay
143 when IT->position is set up wrongly due to some bug. Set
144 IT->current to match the bidi iterator unconditionally.
145 (push_display_prop): Allow GET_FROM_STRING as IT->method on
146 entry. Force push_it to save on the stack the current
147 buffer/string position, to be restored by pop_it. Fix flags in
148 the iterator structure wrt the object coming from a display
149 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
150 properties. (Bug#9284)
152 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
154 * fontset.c (fontset_get_font_group): Add proper type checks.
157 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
159 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
160 and LC_VERSION_MIN_MACOSX.
161 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
162 (dump_it) [LC_FUNCTION_STARTS]: Use it.
164 2011-08-08 Eli Zaretskii <eliz@gnu.org>
166 * xdisp.c (forward_to_next_line_start): Allow to use the
167 no-display-properties-and-no-overlays under bidi display. Set
168 disp_pos in the bidi iterator to avoid searches for display
169 properties and overlays.
171 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
173 * editfns.c (Fset_time_zone_rule): Document relationship with the
176 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
177 the font entity extracted from the cache (Bug#8109).
179 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
181 * composite.c (autocmp_chars): Don't reset point. That is done by
182 restore_point_unwind (Bug#5984).
184 2011-08-07 Juri Linkov <juri@jurta.org>
186 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
187 to show the arg `TIME' instead of `TIMEVAL'.
189 2011-08-06 Eli Zaretskii <eliz@gnu.org>
191 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
192 display property strides EOL and includes a newline, as in
193 longlines-mode. (Bug#9254)
194 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
195 word-wrap under bidirectional display. (Bug#9224)
197 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
198 is non-zero, even if the data buffer is NULL. Fixes a crash in
199 vertical-motion with longlines-mode. (Bug#9254)
201 2011-08-05 Eli Zaretskii <eliz@gnu.org>
203 * bidi.c <bidi_cache_total_alloc>: Now static.
204 (bidi_initialize): Initialize bidi_cache_total_alloc.
206 *xdisp.c (display_line): Release buffer allocated for shelved bidi
209 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
210 amount allocated this far in `bidi_cache_total_alloc'.
211 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
212 non-zero, only free the data buffer without restoring the cache
213 contents. All callers changed.
215 * dispextern.h (bidi_unshelve_cache): Update prototype.
217 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
218 (move_it_in_display_line, move_it_to)
219 (move_it_vertically_backward, move_it_by_lines): Replace the call
220 to xfree to an equivalent call to bidi_unshelve_cache.
221 (move_it_in_display_line_to): Fix logic of returning
222 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
224 2011-08-05 Eli Zaretskii <eliz@gnu.org>
226 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
227 came from a string character with a `cursor' property. (Bug#9229)
229 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
231 * Makefile.in (LIB_PTHREAD): New variable.
232 (LIBES): Add LIB_PTHREAD (Bug#9216).
234 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
235 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
237 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
239 * regex.c (re_iswctype): Remove some redundant boolean
242 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
244 * xterm.c (x_find_topmost_parent): New function.
245 (x_set_frame_alpha): Find topmost parent window with
246 x_find_topmost_parent and set the property there also (bug#9181).
247 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
249 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
251 * callproc.c (Fcall_process): Avoid vfork clobbering
252 the local vars buffer, coding_systems, current_dir.
254 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
256 * keymap.c (Fmake_composed_keymap): Move to subr.el.
258 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
260 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
261 so that it is not optimized away.
263 * xdisp.c (compute_display_string_pos): Remove unused local.
265 2011-08-02 Eli Zaretskii <eliz@gnu.org>
267 Fix slow cursor motion and scrolling in large buffers with
268 selective display, like Org Mode buffers. (Bug#9218)
270 * dispextern.h (struct bidi_it): New member disp_prop_p.
272 * xdisp.c: Remove one-slot cache of display string positions.
273 (compute_display_string_pos): Accept an additional argument
274 DISP_PROP_P; callers changed. Scan at most 5K characters forward
275 for a display string or property. If found, set DISP_PROP_P
278 * bidi.c (bidi_fetch_char): Accept an additional argument
279 DISP_PROP_P, and pass it to compute_display_string_pos.
280 Only handle text covered by a display string if DISP_PROP_P is returned
281 non-zero. All callers of bidi_fetch_char changed.
283 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
285 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
287 2010-12-03 Don March <don@ohspite.net>
289 * keymap.c (Fdefine_key): Fix non-prefix key error message when
290 last character M-[char] is translated to ESC [char] (bug#7541).
292 2011-08-02 Kenichi Handa <handa@m17n.org>
294 * lisp.h (uniprop_table): Extern it.
296 * chartab.c (uniprop_table): Make it non-static.
298 2011-08-01 Eli Zaretskii <eliz@gnu.org>
300 * xdisp.c (forward_to_next_line_start): Accept additional argument
301 BIDI_IT_PREV, and store into it the state of the bidi iterator had
303 (reseat_at_next_visible_line_start): Use the bidi iterator state
304 returned by forward_to_next_line_start to restore the state of
305 it->bidi_it after backing up to previous newline. (Bug#9212)
307 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
309 * regex.c (re_comp): Protoize.
310 (re_exec): Fix return type.
311 (regexec): Fix type of `ret'. (Bug#9203)
313 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
315 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
316 This is needed if max-image-size is a floating-point number.
318 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
320 * print.c (print_object): Print empty symbol as ##.
322 * lread.c (read1): Read ## as empty symbol.
324 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
326 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
327 setting frame foreground color (Bug#9175).
328 (x_set_background_color): Likewise.
330 * nsmenu.m (-setText): Size tooltip dimensions precisely to
332 (EmacsTooltip -init): Remove bezels and add shadows to
335 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
336 or scroll bar (Bug#8470).
338 * nsfont.m (nsfont_open): Remove assignment to voffset and
339 unnecessary vars hshink, expand, hd, full_height, min_height.
340 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
342 * nsterm.h (nsfont_info): Remove voffset field.
344 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
346 Implement strike-through and overline on NextStep (Bug#8863).
348 * nsfont.m (nsfont_open): Use underline position provided by font,
349 instead of hard-coded value of 2.
350 (nsfont_draw): Call ns_draw_text_decoration instead.
352 * nsterm.h: Add declaration for ns_draw_text_decoration.
354 * nsterm.m (ns_draw_text_decoration): New function for drawing
355 underline, overline, and strike-through.
356 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
357 ns_draw_text_decoration. Change treatment of cursor drawing to
358 accomodate underlining, etc.
360 2011-07-28 Eli Zaretskii <eliz@gnu.org>
362 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
365 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
367 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
368 Without this fix, if a signal arrives just after memory fills up,
369 'malloc' might be invoked reentrantly.
371 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
372 In other words, assume that every image size is allowed, on non-X
373 hosts. This assumption is probably wrong, but it lets Emacs compile.
375 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
377 * regex.c (re_iswctype): Convert return values to boolean.
379 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
381 * xdisp.c (compute_display_string_pos): Don't use cached display
382 string position if the buffer had its restriction changed.
385 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
387 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
389 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
391 Integer signedness and overflow and related fixes. (Bug#9079)
393 * bidi.c: Integer size and overflow fixes.
394 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
395 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
396 (bidi_cache_find_level_change, bidi_cache_ensure_space)
397 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
398 (bidi_find_other_level_edge):
399 Use ptrdiff_t instead of EMACS_INT where either will do.
400 This works better on 32-bit hosts configured --with-wide-int.
401 (bidi_cache_ensure_space): Check for size-calculation overflow.
402 Use % rather than repeated addition, for better worst-case speed.
403 Don't set bidi_cache_size until after xrealloc returns, because it
405 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
406 (bidi_cache_ensure_space): Also check that the bidi cache size
407 does not exceed that of the largest Lisp string or buffer. See Eli
408 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
410 * alloc.c (__malloc_size_t): Remove.
411 All uses replaced by size_t. See Andreas Schwab's note
412 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
414 * image.c: Improve checking for integer overflow.
415 (check_image_size): Assume that f is nonnull, since
416 it is always nonnull in practice. This is one less thing to
417 worry about when checking for integer overflow later.
418 (x_check_image_size): New function, which checks for integer
419 overflow issues inside X.
420 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
421 This removes the need for a memory_full check.
422 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
423 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
424 (xbm_read_bitmap_data): Change locals back to 'int', since
425 their values must fit in 'int'.
426 (xpm_load_image, png_load, tiff_load):
427 Invoke x_create_x_image_and_pixmap earlier,
428 to avoid much needless work if the image is too large.
429 (tiff_load): Treat overly large images as if
430 x_create_x_image_and_pixmap failed, not as malloc failures.
431 (gs_load): Use x_check_image_size.
433 * gtkutil.c: Omit integer casts.
434 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
435 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
437 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
439 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
440 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
441 would wrongly return t on a 64-bit host.
443 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
444 The plain *_OVERFLOW macros run afoul of GCC bug 49705
445 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
446 and therefore cause GCC to emit a bogus diagnostic in some cases.
448 * image.c: Integer signedness and overflow and related fixes.
449 This is not an exhaustive set of fixes, but it's time to
450 record what I've got.
451 (lookup_pixel_color, check_image_size): Remove redundant decls.
452 (check_image_size): Don't assume that arbitrary EMACS_INT values
453 fit in 'int', or that arbitrary 'double' values fit in 'int'.
454 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
455 (tiff_load, imagemagick_load_image):
456 Check for overflow in size calculations.
457 (x_create_x_image_and_pixmap): Remove unnecessary test for
458 xmalloc returning NULL; that can't happen.
459 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
460 (xpm_color_bucket): Use better integer hashing function.
461 (xpm_cache_color): Don't possibly over-allocate memory.
462 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
464 Use ptrdiff_t, not int or size_t, to record sizes.
465 (png_load): Don't assume values greater than 2**31 fit in 'int'.
466 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
467 either works, as we prefer signed integers.
468 (tiff_read_from_memory, tiff_write_from_memory):
469 Return tsize_t, not size_t, since that's what the TIFF API wants.
470 (tiff_read_from_memory): Don't fail simply because the read would
471 go past EOF; instead, return a short read.
472 (tiff_load): Omit no-longer-needed casts.
473 (Fimagemagick_types): Don't assume size fits into 'int'.
475 Improve hashing quality when configured --with-wide-int.
476 * fns.c (hash_string): New function, taken from sxhash_string.
477 Do not discard information about ASCII character case; this
478 discarding is no longer needed.
479 (sxhash-string): Use it. Change sig to match it. Caller changed.
480 * lisp.h: Declare it.
481 * lread.c (hash_string): Remove, since we now use fns.c's version.
482 The fns.c version returns a wider integer if --with-wide-int is
483 specified, so this should help the quality of the hashing a bit.
485 * emacs.c: Integer overflow minor fix.
486 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
487 Define only if GNU_LINUX.
488 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
490 * dispnew.c: Integer signedness and overflow fixes.
491 Remove unnecessary forward decls, that were a maintenance hassle.
492 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
494 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
495 (scrolling_window): Use ptrdiff_t, not int, for byte count.
496 (prepare_desired_row, line_draw_cost):
497 Use int, not unsigned, where either works.
498 (save_current_matrix, restore_current_matrix):
499 Use ptrdiff_t, not size_t, where either works.
500 (init_display): Check for overflow more accurately, and without
501 relying on undefined behavior.
503 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
504 Remove, replacing with the new symbols in lisp.h. All uses changed.
505 * fileio.c (make_temp_name):
506 * filelock.c (lock_file_1, lock_file):
507 * xdisp.c (message_dolog):
508 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
509 Use pMd etc. instead.
510 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
511 replacing the pWIDE etc. symbols removed from editfns.c.
513 * keyboard.h (num_input_events): Now uintmax_t.
514 This is (very slightly) less likely to mess up due to wraparound.
517 * buffer.c: Integer signedness fixes.
518 (alloc_buffer_text, enlarge_buffer_text):
519 Use ptrdiff_t rather than size_t when either will do, as we prefer
522 * alloc.c: Integer signedness and overflow fixes.
523 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
524 (__malloc_size_t): Default to size_t, not to int.
525 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
526 (Fgarbage_collect, mark_object_loop_halt, mark_object):
527 Prefer ptrdiff_t to size_t when either would do, as we prefer
529 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
530 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
531 Now const. Initialize with values that are in range even if char
533 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
534 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
535 These functions do the right thing with sizes > 2**32.
536 (check_depth): Now ptrdiff_t, not int.
537 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
538 Adjust to new way of storing sizes. Check for size overflow bugs
540 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
541 slightly wrong anyway, as it missed one instance of
542 XMALLOC_OVERRUN_CHECK_OVERHEAD.
543 (refill_memory_reserve): Omit needless cast to size_t.
544 (mark_object_loop_halt): Mark as externally visible.
546 * xselect.c: Integer signedness and overflow fixes.
547 (Fx_register_dnd_atom, x_handle_dnd_message):
548 Use ptrdiff_t, not size_t, since we prefer signed.
549 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
550 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
551 x_dnd_atoms_size and x_dnd_atoms_length.
553 * doprnt.c: Prefer signed to unsigned when either works.
557 * xdisp.c (vmessage):
558 Use ptrdiff_t, not size_t, when using or implementing doprnt,
559 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
560 prefer signed arithmetic to avoid comparison confusion.
561 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
564 Assume freestanding C89 headers, string.h, stdlib.h.
565 * data.c, doprnt.c, floatfns.c, print.c:
566 Include float.h unconditionally.
567 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
568 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
569 * regex.c: Likewise for stddef.h, string.h.
570 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
571 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
572 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
573 (STDC_HEADERS): Remove obsolete defines.
574 * sysdep.c: Include limits.h unconditionally.
576 Assume support for memcmp, memcpy, memmove, memset.
577 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
578 * regex.c (memcmp, memcpy):
579 Remove; we assume C89 now.
581 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
582 (__malloc_safe_bcopy): Remove; no longer needed.
584 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
585 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
586 well either way, and we prefer signed to unsigned.
588 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
590 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
591 closes the connection while we're reading (bug#9182).
593 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
595 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
596 are specified (Bug#9168).
598 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
600 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
601 Found by GCC static checking and --with-wide-int on a 32-bit host.
603 2011-07-25 Eli Zaretskii <eliz@gnu.org>
605 * xdisp.c (compute_display_string_pos): Fix logic of caching
606 previous display string position. Initialize cached_prev_pos to
607 -1. Fixes slow-down at the beginning of a buffer.
609 2011-07-24 Eli Zaretskii <eliz@gnu.org>
611 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
612 for attrs[LFACE_FONTSET_INDEX].
614 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
616 * xml.c (parse_region): Remove unused local
617 that was recently introduced.
619 2011-07-23 Eli Zaretskii <eliz@gnu.org>
621 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
622 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
624 * xdisp.c (move_it_in_display_line_to): Record the best matching
625 position for TO_CHARPOS while scanning the line, and restore it on
626 exit if none of the characters scanned was an exact match.
627 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
628 when exact match is impossible due to invisible text, and the
631 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
633 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
636 2011-07-22 Eli Zaretskii <eliz@gnu.org>
638 Fix a significant slow-down of cursor motion with C-n, C-p,
639 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
640 auto-repeat under bidi redisplay in fontified buffers.
641 * xdisp.c (compute_stop_pos_backwards): New function.
642 (next_element_from_buffer): Call compute_stop_pos_backwards to
643 find a suitable prev_stop when we find ourselves before
645 (reseat): Don't look for prev_stop, as that could mean a very long
647 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
648 <cached_disp_overlay_modiff>: Cache for last found display string
650 (compute_display_string_pos): Return the cached position if asked
651 about the same buffer in the same area of character positions, and
652 the buffer wasn't changed since the time the display string
655 2011-07-22 Eli Zaretskii <eliz@gnu.org>
657 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
658 is an integer, which is important for empty lines. (Bug#9149)
660 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
662 * frame.c (Fmodify_frame_parameters): In tty case, update the
663 default face if necessary (Bug#4238).
665 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
667 * editfns.c (Fstring_to_char): No need to explain what a character
668 is in the docstring (Bug#6576).
670 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
672 * xml.c (parse_region): Make sure we always return a tree.
674 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
676 * xml.c (parse_region): If a document contains only comments,
679 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
681 * xml.c (make_dom): Return comments, too.
683 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
686 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
687 and the surrounding thread.
688 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
689 rather than fgets, and retry after EINTR. Otherwise, 'emacs
690 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
692 * s/openbsd.h (BROKEN_SIGIO): Define.
693 * unexelf.c (unexec) [__OpenBSD__]:
694 Don't update the .mdebug section of the Alpha COFF symbol table.
696 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
698 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
701 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
703 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
704 This fixes some race conditions on the permissions of any newly
707 * alloc.c (valid_pointer_p): Use pipe, not open.
708 This fixes some permissions issues when debugging.
710 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
711 If fchown fails to set both uid and gid, try to set just gid,
712 as that is sometimes allowed. Adjust the file's mode to eliminate
713 setuid or setgid bits that are inappropriate if fchown fails.
715 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
717 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
718 to compare Lisp_Objects.
719 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
720 global_gnutls_log_level, don't mistake it for a Lisp_Object.
721 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
723 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
725 * lread.c (read_integer): Unread even EOF character.
726 (read1): Likewise. Properly record start position of symbol.
728 * lread.c (read1): Read `#:' as empty uninterned symbol if no
729 symbol character follows.
731 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
733 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
734 This works around a problem with the previous change to Fcopy_file.
735 Recent glibc declares fchown with __attribute__((warn_unused_result)),
736 and without this change, GCC might complain about discarding
737 fchown's return value.
739 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
741 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
743 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
745 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
747 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
749 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
750 it's used from the C level.
752 * process.c: Use the same condition for POLL_FOR_INPUT in both
753 keyboard.c and process.c (bug#1858).
755 2011-07-09 Lawrence Mitchell <wence@gmx.li>
757 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
758 (Fgnutls_boot): Use it.
760 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
762 * doc.c (Fsubstitute_command_keys): Revert last change.
764 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
766 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
767 quotes the next character, and doesn't affect other longer
768 sequences (bug#8935).
770 * lread.c (syms_of_lread): Clarify that is isn't only
771 `eval-buffer' and `eval-defun' that's affected by
772 `lexical-binding' (bug#8460).
774 2011-07-15 Eli Zaretskii <eliz@gnu.org>
776 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
777 bidi redisplay when a line includes both an image and is
780 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
782 Fix minor problems found by static checking.
783 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
784 (elsz): Now a signed constant, not a size_t var. We prefer signed
785 types to unsigned, to avoid integer comparison confusion. Without
786 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
787 "cannot optimize loop, the loop counter may overflow", a symptom
789 * indent.c (Fvertical_motion): Mark locals as initialized.
790 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
792 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
794 * search.c (Fre_search_backward): Mention `case-fold-search' in
795 all the re_search_* functions (bug#8138).
797 * keyboard.c (Fopen_dribble_file): Document when the file is
800 2011-07-14 Eli Zaretskii <eliz@gnu.org>
802 * bidi.c (bidi_dump_cached_states): Fix format of displaying
805 Support bidi reordering of display and overlay strings.
806 * xdisp.c (compute_display_string_pos)
807 (compute_display_string_end): Accept additional argument STRING.
808 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
809 (reseat_to_string): Initialize bidi_it->string.s and
810 bidi_it->string.schars.
811 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
812 NULL (avoids a crash in bidi_paragraph_init).
813 Initialize itb.string.lstring.
814 (init_iterator): Call bidi_init_it only of a valid
815 buffer position was specified. Initialize paragraph_embedding to
817 (reseat_to_string): Initialize the bidi iterator.
818 (display_string): If we need to ignore text properties of
819 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
820 original value of -1 will not work with bidi.)
821 (compute_display_string_pos): First arg is now struct
822 `text_pos *'; all callers changed. Support display properties on
824 (compute_display_string_end): Support display properties on Lisp
826 (init_iterator, reseat_1, reseat_to_string): Initialize the
827 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
828 when iterating on a string not from display properties).
829 (compute_display_string_pos, compute_display_string_end):
830 Fix calculation of the object to scan. Fixes an error when using
832 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
833 base_level_stop; instead, set base_level_stop to BEGV.
834 Fixes crashes in vertical-motion.
835 (next_element_from_buffer): Improve commentary for when
836 the iterator is before prev_stop.
837 (init_iterator): Initialize bidi_p from the default value of
838 bidi-display-reordering, not from buffer-local value. Use the
839 buffer-local value only if initializing for buffer iteration.
840 (handle_invisible_prop): Support invisible properties on strings
841 that are being bidi-reordered.
842 (set_iterator_to_next): Support bidi reordering of C strings and
844 (next_element_from_string): Support bidi reordering of Lisp
846 (handle_stop_backwards): Support Lisp strings as well.
847 (display_string): Support display of R2L glyph rows.
848 Use IT_STRING_CHARPOS when displaying from a Lisp string.
849 (init_iterator): Don't initialize it->bidi_p for strings
851 (reseat_to_string): Initialize it->bidi_p for strings here.
852 (next_element_from_string, next_element_from_c_string)
853 (next_element_from_buffer): Add xassert's for correspondence
854 between IT's object being iterated and it->bidi_it.string
856 (face_before_or_after_it_pos): Support bidi iteration.
857 (next_element_from_c_string): Handle the case of the first string
858 character that is not the first one in the visual order.
859 (get_visually_first_element): New function, refactored from common
860 parts of next_element_from_buffer, next_element_from_string, and
861 next_element_from_c_string.
862 (tool_bar_lines_needed, redisplay_tool_bar)
863 (display_menu_bar): Force left-to-right direction. Add a FIXME
864 comment for making that be controlled by a user option.
865 (push_it, pop_it): Save and restore the state of the
866 bidi iterator. Save and restore the bidi_p flag.
867 (pop_it): Iterate out of display property for string iteration as
869 (iterate_out_of_display_property): Support iteration over strings.
870 (handle_single_display_spec): Set up it->bidi_it for iteration
871 over a display string, and call bidi_init_it.
872 (handle_single_display_spec, next_overlay_string)
873 (get_overlay_strings_1, push_display_prop): Set up the bidi
874 iterator for displaying display or overlay strings.
875 (forward_to_next_line_start): Don't use the shortcut if
877 (back_to_previous_visible_line_start): If handle_display_prop
878 pushed the iterator stack, restore the internal state of the bidi
879 iterator by calling bidi_pop_it same number of times.
880 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
881 and we are bidi-iterating, don't decrement the iterator position;
882 instead, set the first_elt flag in the bidi iterator, to produce
884 (reseat_1): Remove redundant setting of string_from_display_prop_p.
885 (push_display_prop): xassert that we are iterating a buffer.
886 (push_it, pop_it): Save and restore paragraph_embedding member.
887 (handle_single_display_spec, next_overlay_string)
888 (get_overlay_strings_1, reseat_1, reseat_to_string)
889 (push_display_prop): Set up the `unibyte' member of bidi_it.string
890 correctly. Don't assume unibyte strings are not bidi-reordered.
891 (compute_display_string_pos)
892 (compute_display_string_end): Fix handling the case of C string.
893 (push_it, pop_it): Save and restore from_disp_prop_p.
894 (handle_single_display_spec, push_display_prop): Set the
895 from_disp_prop_p flag.
896 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
897 (pop_it): Call iterate_out_of_display_property only if we are
898 popping after iteration over a string that came from a display
899 property. Fix a typo in popping stretch info. Add an assertion
900 for verifying that the iterator position is in sync with the bidi
902 (handle_single_display_spec, get_overlay_strings_1)
903 (push_display_prop): Fix initialization of paragraph direction for
904 string when that of the parent object is not yet determined.
905 (reseat_1): Call bidi_init_it to resync the bidi
906 iterator with IT's position. (Bug#7616)
907 (find_row_edges): If ROW->start.pos gives position
908 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
909 (handle_stop, back_to_previous_visible_line_start, reseat_1):
910 Reset the from_disp_prop_p flag.
911 (SAVE_IT, RESTORE_IT): New macros.
912 (pos_visible_p, face_before_or_after_it_pos)
913 (back_to_previous_visible_line_start)
914 (move_it_in_display_line_to, move_it_in_display_line)
915 (move_it_to, move_it_vertically_backward, move_it_by_lines)
916 (try_scrolling, redisplay_window, display_line): Use them when
917 saving a temporary copy of the iterator and restoring it back.
918 (back_to_previous_visible_line_start, reseat_1)
919 (init_iterator): Empty the bidi cache "stack".
920 (move_it_in_display_line_to): If iterator ended up at
921 EOL, but we never saw any buffer positions smaller than
922 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
923 motion in bidi-reordered lines.
924 (move_it_in_display_line_to): Record prev_method and prev_pos
925 immediately before the call to set_iterator_to_next. Fixes cursor
926 motion in bidi-reordered lines with stretch glyphs and strings
927 displayed in margins. (Bug#8133) (Bug#8867)
928 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
930 (pos_visible_p): Support positions in bidi-reordered lines.
931 Save and restore bidi cache.
933 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
934 (bidi_paragraph_info): Delete unused struct.
935 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
936 (bidi_cache_start): New variable.
937 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
939 (bidi_cache_fetch_state, bidi_cache_search)
940 (bidi_cache_find_level_change, bidi_cache_iterator_state)
941 (bidi_cache_find, bidi_peek_at_next_level)
942 (bidi_level_of_next_char, bidi_find_other_level_edge)
943 (bidi_move_to_visually_next): Compare cache index with
944 bidi_cache_start rather than with zero.
945 (bidi_fetch_char): Accept new argument STRING; all callers
946 changed. Support iteration over a string. Support strings with
947 display properties. Support unibyte strings. Fix the type of
948 `len' according to what STRING_CHAR_AND_LENGTH expects.
949 (bidi_paragraph_init, bidi_resolve_explicit_1)
950 (bidi_resolve_explicit, bidi_resolve_weak)
951 (bidi_level_of_next_char, bidi_move_to_visually_next):
952 Support iteration over a string.
953 (bidi_set_sor_type, bidi_resolve_explicit_1)
954 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
955 can now be zero (for strings); special values 0 and -1 were
956 changed to -1 and -2, respectively.
957 (bidi_char_at_pos): New function.
958 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
959 Call it instead of FETCH_MULTIBYTE_CHAR.
960 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
961 initialized to valid values.
962 (bidi_init_it): Don't initialize charpos and bytepos with invalid
964 (bidi_level_of_next_char): Allow the sentinel "position" to pass
965 the test for valid cached positions. Fix the logic for looking up
966 the sentinel state in the cache. GCPRO the Lisp string we are
968 (bidi_push_it, bidi_pop_it): New functions.
969 (bidi_initialize): Initialize the bidi cache start stack pointer.
970 (bidi_cache_ensure_space): New function, refactored from part of
971 bidi_cache_iterator_state. Don't assume the required size is just
972 one BIDI_CACHE_CHUNK away.
973 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
974 (bidi_count_bytes, bidi_char_at_pos): New functions.
975 (bidi_cache_search): Don't assume bidi_cache_last_idx is
976 always valid if bidi_cache_idx is valid.
977 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
978 is valid if it's going to be used.
979 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
980 (bidi_cache_fetch_state, bidi_cache_search)
981 (bidi_cache_find_level_change, bidi_cache_ensure_space)
982 (bidi_cache_iterator_state, bidi_cache_find)
983 (bidi_find_other_level_edge, bidi_cache_start_stack):
984 All variables related to cache indices are now EMACS_INT.
986 * dispextern.h (struct bidi_string_data): New structure.
987 (struct bidi_it): New member `string'. Make flag members be 1-bit
988 fields, and put them last in the struct.
989 (compute_display_string_pos, compute_display_string_end):
991 (bidi_push_it, bidi_pop_it): Add prototypes.
992 (struct iterator_stack_entry): New members bidi_p,
993 paragraph_embedding, and from_disp_prop_p.
994 (struct it): Member bidi_p is now a bit field 1 bit wide.
995 (bidi_shelve_cache, bidi_unshelve_cache):
998 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
999 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1000 and vector-like objects.
1002 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1003 cache around display iteration.
1005 * window.c (Fwindow_end, window_scroll_pixel_based)
1006 (displayed_window_lines, Frecenter): Save and restore the bidi
1007 cache around display iteration.
1009 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1011 * editfns.c (Fdelete_region): Clarify the use of the named
1012 parameters (bug#6788).
1014 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1016 * indent.c (Fvertical_motion): Set and restore w->pointm when
1017 saving and restoring the window's buffer (Bug#9006).
1019 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1021 * editfns.c (Fstring_to_char): Clarify just what is returned
1022 (bug#6576). Text by Eli Zaretskii.
1024 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1026 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1028 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1030 * buffer.c (mmap_find): Fix a typo.
1032 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1034 Fix execution of x selection hooks.
1035 * xselect.c (Qx_lost_selection_functions)
1036 (Qx_sent_selection_functions): New vars.
1037 (syms_of_xselect): DEFSYM them.
1038 (x_handle_selection_request): Pass Qx_sent_selection_functions
1039 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1040 (x_handle_selection_clear,x_clear_frame_selections):
1041 Pass Qx_lost_selection_functions rather than
1042 Vx_lost_selection_functions to Frun_hook_with_args.
1044 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1046 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1047 The old code sometimes used this field without initializing it.
1049 * alloc.c (gc_sweep): Don't read past end of array.
1050 In theory, the old code could also have corrupted Emacs internals,
1051 though it'd be very unlikely.
1053 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1055 * character.c (Fcharacterp): Don't advertise optional ignored
1056 argument. (Bug#4026)
1058 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1060 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1063 * window.c (Fset_window_start): Doc fix (bug#4199).
1064 (Fset_window_hscroll): Ditto.
1066 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1068 Fix minor new problems caught by GCC 4.6.1.
1069 * term.c (init_tty): Remove unused local.
1070 * xsettings.c (store_monospaced_changed): Define this function only
1071 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1074 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1076 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1078 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1080 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1081 are the mini-buffer and the echo area (bug#3320).
1083 * term.c (init_tty): Remove support for supdup, c10 and perq
1084 terminals, which are no longer supported (bug#1482).
1086 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1088 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1090 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1092 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1093 for non-popups (Bug#3642).
1095 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1097 * alloc.c (reset_malloc_hooks): Protoize.
1098 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1099 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1100 * cm.c (losecursor): Likewise.
1101 * data.c (fmod): Likewise.
1102 * dispnew.c (swap_glyphs_in_rows): Likewise.
1103 * emacs.c (memory_warning_signal): Likewise.
1104 * floatfns.c (float_error): Likewise.
1105 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1106 (otf_open, font_otf_capability, generate_otf_features)
1107 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1109 * image.c (pbm_read_file): Likewise.
1110 * indent.c (string_display_width): Likewise.
1111 * intervals.c (check_for_interval, search_for_interval)
1112 (inc_interval_count, count_intervals, root_interval)
1113 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1114 * lread.c (defalias): Likewise.
1115 * ralloc.c (r_alloc_check): Likewise.
1116 * regex.c (set_image_of_range_1, set_image_of_range)
1117 (regex_grow_registers): Likewise.
1118 * sysdep.c (strerror): Likewise.
1119 * termcap.c (valid_filename_p, tprint, main): Likewise.
1120 * tparam.c (main): Likewise.
1121 * unexhp9k800.c (run_time_remap, save_data_space)
1122 (update_file_ptrs, read_header, write_header, calculate_checksum)
1123 (copy_file, copy_rest, display_header): Likewise.
1124 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1126 * xdisp.c (check_it): Likewise.
1127 * xfaces.c (register_color, unregister_color, unregister_colors):
1129 * xfns.c (print_fontset_result): Likewise.
1130 * xrdb.c (member, fatal, main): Likewise.
1132 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1134 Fix minor problems found by static checking (Bug#9031).
1135 * chartab.c (char_table_set_range, map_sub_char_table):
1136 Remove unused locals.
1137 (uniprop_table): Now static.
1138 * composite.c (_work_char): Remove unused static var.
1140 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1142 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1144 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1146 * gtkutil.c (qttip_cb): Remove code without function.
1148 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1150 * w32.c (pthread_sigmask): New stub.
1152 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1154 Use pthread_sigmask, not sigprocmask (Bug#9010).
1155 sigprocmask is portable only for single-threaded applications, and
1156 Emacs can be multi-threaded when it uses GTK.
1157 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1159 * callproc.c (Fcall_process):
1160 * process.c (create_process):
1161 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1162 Use pthread_sigmask, not sigprocmask.
1164 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1166 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1167 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1170 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1172 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1173 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1174 (xg_hide_tooltip): Fix comment.
1176 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1177 in registerServicesMenuSendTypes.
1178 (validRequestorForSendType): Don't check ns_return_types.
1180 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1183 2011-07-08 Jason Rumney <jasonr@gnu.org>
1185 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1186 frame struct members of non-existent frames (Bug#6284).
1188 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1190 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1191 variable firstTime not needed on OSX >= 10.6.
1192 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1193 >= 10.5. Use setKnobProportion, setDoubleValue.
1195 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1196 (MAC_OS_X_VERSION_10_5): Define if not defined.
1197 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1198 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1199 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1201 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1202 cString and lossyCString on OSX >= 10.4
1204 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1205 sizeToFit on OSX >= 10.2.
1207 * nsimage.m (allocInitFromFile): Don't use deprecated method
1208 bestRepresentationForDevice on OSX >= 10.6.
1210 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1213 * emacs.c: Declare unexec_init_emacs_zone.
1215 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1217 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1219 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1220 on svcsMenu (Bug#8842).
1222 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1224 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1226 * nsterm.m (QUTF8_STRING): Declare.
1227 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1228 (validRequestorForSendType): Return type is (id).
1229 Change indexOfObjectIdenticalTo to indexOfObject.
1230 Check if we have local selection before returning self (Bug#8842).
1231 (writeSelectionToPasteboard): Put local selection into paste board
1232 if we have a local selection (Bug#8842).
1233 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1235 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1236 (ns_get_local_selection): Declare.
1238 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1240 * keymap.c (describe_map_tree): Don't insert a double newline at
1241 the end of the buffer (bug#1169) and return whether we inserted
1244 * callint.c (Fcall_interactively): Change "reading args" to
1245 "providing args" to try to clarify what it does (bug#1010).
1247 2011-07-07 Kenichi Handa <handa@m17n.org>
1249 * composite.c (composition_compute_stop_pos): Ignore a static
1250 composition starting before CHARPOS (Bug#8915).
1252 * xdisp.c (handle_composition_prop): Likewise.
1254 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1256 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1259 2011-07-07 Kenichi Handa <handa@m17n.org>
1261 * character.h (unicode_category_t): New enum type.
1263 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1264 (Qchar_code_property_table): New variable.
1265 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1266 (UNIPROP_COMPRESSED_FORM_P): New macros.
1267 (char_table_ascii): Uncompress the compressed values.
1268 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1269 Uncompress the compressed values.
1270 (sub_char_table_ref_and_range): Likewise.
1271 (char_table_ref_and_range): Uncompress the compressed values.
1272 (sub_char_table_set): New arg is_uniprop. Callers changed.
1273 Uncompress the compressed values.
1274 (sub_char_table_set_range): Args changed. Callers changed.
1275 (char_table_set_range): Adjuted for the above change.
1276 (map_sub_char_table): Delete args default_val and parent. Add arg
1277 top. Give decoded values to a Lisp function.
1278 (map_char_table): Adjust for the above change. Give decoded
1279 values to a Lisp function. Gcpro more variables.
1280 (uniprop_table_uncompress)
1281 (uniprop_decode_value_run_length): New functions.
1282 (uniprop_decoder, uniprop_decoder_count): New variables.
1283 (uniprop_get_decoder, uniprop_encode_value_character)
1284 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1286 (uniprop_encoder, uniprop_encoder_count): New variables.
1287 (uniprop_get_encoder, uniprop_table)
1288 (Funicode_property_table_internal, Fget_unicode_property_internal)
1289 (Fput_unicode_property_internal): New functions.
1290 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1291 Sunicode_property_table_internal, Sget_unicode_property_internal,
1292 and Sput_unicode_property_internal. Defvar_lisp
1293 char-code-property-alist.
1295 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1296 Vunicode_category_table.
1298 * font.c (font_range): Adjust for the change of
1299 Vunicode_category_table.
1301 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1303 * m/iris4d.h: Remove file, move contents ...
1304 * s/irix6-5.h: ... here.
1306 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1308 Remove unportable assumption about struct layout (Bug#8884).
1309 * alloc.c (mark_buffer):
1310 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1311 (clone_per_buffer_values): Don't assume that
1312 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1313 This isn't true in general, and it's particularly not true
1314 if Emacs is configured with --with-wide-int.
1315 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1316 New macros, used in the buffer.c change.
1318 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1320 * xsettings.c: Use both GConf and GSettings if both are available.
1321 (store_config_changed_event): Add comment.
1322 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1323 (store_tool_bar_style_changed): New functions.
1324 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1325 (struct xsettings): Move font inside HAVE_XFT.
1326 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1327 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1328 Move inside HAVE_XFT.
1329 (something_changed_gsettingsCB): Rename from something_changedCB.
1330 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1332 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1333 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1334 (something_changed_gconfCB): Rename from something_changedCB.
1335 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1336 (parse_settings): Move check for font inside HAVE_XFT.
1337 (read_settings, apply_xft_settings): Add comment.
1338 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1339 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1340 call store_font_name_changed.
1341 (xft_settings_event): Add comment.
1342 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1343 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1344 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1345 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1346 (xsettings_initialize): Call init_gsettings last.
1347 (xsettings_get_system_font, xsettings_get_system_normal_font):
1350 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1352 Random fixes. E.g., (random) never returned negative values.
1353 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1354 subseconds part to the entropy, as that's a bit more random.
1355 Prefer signed to unsigned, since the signedness doesn't matter and
1356 in general we prefer signed. When given a limit, use a
1357 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1358 latter isn't right if USE_2_TAGS_FOR_INTS.
1359 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1360 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1362 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1364 * textprop.c (text_property_stickiness):
1365 Obey Vtext_property_default_nonsticky.
1366 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1367 * w32fns.c (syms_of_w32fns):
1368 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1370 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1372 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1373 This is more efficient than Ffile_directory_p and avoids a minor race.
1375 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1377 * buffer.c (Foverlay_put): Say what the return value is
1380 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1381 is a directory before asking whether to use the file name
1383 (barf_or_query_if_file_exists): Make the "File is a directory"
1384 error be more correct.
1386 * fns.c (Frequire): Remove the mention of the .gz files, since
1387 that's installation-specific, but keep the mention of
1388 `get-load-suffixes'.
1390 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1392 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1393 Report string overflow if the output is too long.
1395 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1397 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1398 (syms_of_gnutls): Remove duplicate DEFSYM for
1399 Qgnutls_bootprop_verify_hostname_error, an error for
1400 Qgnutls_bootprop_verify_error (which is no longer used).
1402 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1403 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1404 Also (re)move comments that are misplaced or no longer relevant.
1406 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1408 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1410 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1412 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1413 and background color parameters if they have been changed.
1415 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1417 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1419 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1421 * xsettings.c (SYSTEM_FONT): Define only when used.
1422 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1424 * keymap.c (access_keymap_1): Now static.
1426 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1428 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1429 leave any prefix arg for the up event (Bug#1586).
1431 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1433 * lread.c (syms_of_lread): Mention single symbols defined by
1434 `defvar' or `defconst' (bug#7154).
1436 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1437 (Frequire): Mention get-load-suffixes.
1439 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1441 * window.h (window): Remove clone_number slot.
1442 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1444 (make_parent_window, make_window, saved_window)
1445 (Fset_window_configuration, save_window_save): Don't deal with
1447 * buffer.c (Qclone_number): Remove declaration.
1448 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1450 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1452 Add multiple inheritance to keymaps.
1453 * keymap.c (Fmake_composed_keymap): New function.
1454 (Fset_keymap_parent): Simplify.
1455 (fix_submap_inheritance): Remove.
1456 (access_keymap_1): New function extracted from access_keymap to handle
1457 embedded parents and handle lists of maps.
1458 (access_keymap): Use it.
1459 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1460 (Fcopy_keymap): Handle embedded parents.
1461 (Fcommand_remapping, define_as_prefix): Simplify.
1462 (Fkey_binding): Simplify.
1463 (syms_of_keymap): Move minibuffer-local-completion-map,
1464 minibuffer-local-filename-completion-map,
1465 minibuffer-local-must-match-map, and
1466 minibuffer-local-filename-must-match-map to Elisp.
1467 (syms_of_keymap): Defsubr make-composed-keymap.
1468 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1469 (parse_menu_item): Trivial simplification.
1471 2011-07-01 Glenn Morris <rgm@gnu.org>
1473 * Makefile.in (SETTINGS_LIBS): Fix typo.
1475 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1477 * coding.c (Fencode_coding_string): Record the last coding system
1478 used, as the function doc string says (bug#8738).
1480 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1482 * xsettings.c (store_monospaced_changed): Take new font as arg and
1483 check for change against current_mono_font.
1484 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1485 (emacs_settings_constructor, emacs_settings_get_property)
1486 (emacs_settings_set_property, emacs_settings_class_init)
1487 (emacs_settings_init, gsettings_obj): Remove.
1488 (something_changedCB): New function for HAVE_GSETTINGS.
1489 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1490 with value as argument.
1491 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1492 g_settings_new (Bug#8967). Do not create gsettings_obj.
1493 Remove calls to g_settings_bind. Connect something_changedCB to
1496 * xgselect.c: Add defined (HAVE_GSETTINGS).
1497 (xgselect_initialize): Ditto.
1499 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1500 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1503 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1505 * eval.c (struct backtrace): Simplify and port the data structure.
1506 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1507 signed bit field, as this assumption is not portable and it makes
1508 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1509 "char debug_on_exit : 1" as this is not portable either; instead,
1510 use the portable "unsigned int debug_on_exit : 1". Remove unused
1511 member evalargs. Remove obsolete comments about cc bombing out.
1513 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1515 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1516 Let HAVE_GSETTINGS override HAVE_GCONF.
1517 (store_monospaced_changed): New function.
1518 (EMACS_SETTINGS): A new type derived from GObject to handle
1519 GSettings notifications.
1520 (emacs_settings_constructor, emacs_settings_get_property)
1521 (emacs_settings_set_property, emacs_settings_class_init):
1523 (gsettings_client, gsettings_obj): New variables.
1524 (GSETTINGS_SCHEMA): New define.
1525 (something_changedCB): Call store_monospaced_changed.
1526 (init_gsettings): New function.
1527 (xsettings_initialize): Call init_gsettings.
1528 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1531 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1534 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1536 * window.c (resize_root_window, grow_mini_window)
1537 (shrink_mini_window): Rename Qresize_root_window to
1538 Qwindow_resize_root_window and Qresize_root_window_vertically to
1539 Qwindow_resize_root_window_vertically.
1541 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1543 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1545 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1547 * makefile.w32-in: Redesign dependencies so they reflect more
1548 clearly which files are directly included by each source file,
1549 and not through other includes.
1551 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1553 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1554 (sort_overlays, overlay_strings): When an overlay's clone number
1555 matches the window's clone number process the overlay even if
1556 the overlay's window property doesn't match the current window.
1558 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1559 (Fwindow_hchild): Rename to Fwindow_left_child.
1560 (Fwindow_next): Rename to Fwindow_next_sibling.
1561 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1562 (resize_window_check): Rename to window_resize_check.
1563 (resize_window_apply): Rename to window_resize_apply.
1564 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1565 (Fdelete_other_windows_internal, resize_frame_windows)
1566 (Fsplit_window_internal, Fdelete_window_internal)
1567 (grow_mini_window, shrink_mini_window)
1568 (Fresize_mini_window_internal): Fix callers accordingly.
1570 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1572 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1573 (emacs_fixed_set_min_size): Remove.
1574 (emacs_fixed_new): Take frame as argument.
1576 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1577 (_EmacsFixedPrivate): Remove minwidth/height.
1578 Add struct frame *f.
1579 (emacs_fixed_init): Initialize priv->f.
1580 (get_parent_class, emacs_fixed_set_min_size): Remove.
1581 (emacs_fixed_new): Set priv->f to argument.
1582 (emacs_fixed_get_preferred_width)
1583 (emacs_fixed_get_preferred_height): Use min_width/height from
1584 frames size_hint to set minimum and natural (Bug#8919).
1585 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1586 and use min_width/height from frames size_hint to set
1587 min_width/height (Bug#8919).
1589 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1590 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1593 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1595 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1596 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1599 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1601 * process.c (wait_reading_process_output): Bypass select if
1602 waiting for a cell while ignoring keyboard input, and input is
1603 pending. Suggested by Jan Djärv (Bug#8869).
1605 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1607 Use gnulib's dup2 module instead of rolling our own.
1608 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1610 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1612 * dispnew.c (scrolling_window): Before scrolling, turn off a
1613 mouse-highlight in the window being scrolled.
1615 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1617 Move DEFSYM to lisp.h and use everywhere.
1619 * character.h (DEFSYM): Move declaration...
1620 * lisp.h (DEFSYM): ...here.
1626 * w32select.c: Don't include character.h.
1628 * alloc.c (syms_of_alloc):
1629 * buffer.c (syms_of_buffer):
1630 * bytecode.c (syms_of_bytecode):
1631 * callint.c (syms_of_callint):
1632 * casefiddle.c (syms_of_casefiddle):
1633 * casetab.c (init_casetab_once):
1634 * category.c (init_category_once, syms_of_category):
1635 * ccl.c (syms_of_ccl):
1636 * cmds.c (syms_of_cmds):
1637 * composite.c (syms_of_composite):
1638 * dbusbind.c (syms_of_dbusbind):
1639 * dired.c (syms_of_dired):
1640 * dispnew.c (syms_of_display):
1641 * doc.c (syms_of_doc):
1642 * editfns.c (syms_of_editfns):
1643 * emacs.c (syms_of_emacs):
1644 * eval.c (syms_of_eval):
1645 * fileio.c (syms_of_fileio):
1646 * fns.c (syms_of_fns):
1647 * frame.c (syms_of_frame):
1648 * fringe.c (syms_of_fringe):
1649 * insdel.c (syms_of_insdel):
1650 * keymap.c (syms_of_keymap):
1651 * lread.c (init_obarray, syms_of_lread):
1652 * macros.c (syms_of_macros):
1653 * msdos.c (syms_of_msdos):
1654 * print.c (syms_of_print):
1655 * process.c (syms_of_process):
1656 * search.c (syms_of_search):
1657 * sound.c (syms_of_sound):
1658 * syntax.c (init_syntax_once, syms_of_syntax):
1659 * terminal.c (syms_of_terminal):
1660 * textprop.c (syms_of_textprop):
1661 * undo.c (syms_of_undo):
1662 * w32.c (globals_of_w32):
1663 * window.c (syms_of_window):
1664 * xdisp.c (syms_of_xdisp):
1665 * xfaces.c (syms_of_xfaces):
1666 * xfns.c (syms_of_xfns):
1667 * xmenu.c (syms_of_xmenu):
1668 * xsettings.c (syms_of_xsettings):
1669 * xterm.c (syms_of_xterm): Use DEFSYM.
1671 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1673 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1675 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1677 Integer and buffer overflow fixes (Bug#8873).
1679 * print.c (printchar, strout): Check for string overflow.
1680 (PRINTPREPARE, printchar, strout):
1681 Don't set size unless allocation succeeds.
1683 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1684 for sizes. Check for string overflow more accurately.
1685 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1687 * macros.c: Integer and buffer overflow fixes.
1688 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1689 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1690 Use ptrdiff_t, not int, for sizes.
1691 Don't increment bufsize until after realloc succeeds.
1692 Check for size-calculation overflow.
1693 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1695 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1697 * lread.c: Integer overflow fixes.
1698 (read_integer): Radix is now EMACS_INT, not int,
1699 to improve quality of diagnostics for out-of-range radices.
1700 Calculate buffer size correctly for out-of-range radices.
1701 (read1): Check for integer overflow in radices, and in
1702 read-circle numbers.
1703 (read_escape): Avoid int overflow.
1704 (Fload, openp, read_buffer_size, read1)
1705 (substitute_object_recurse, read_vector, read_list, map_obarray):
1706 Use ptrdiff_t, not int, for sizes.
1707 (read1): Use EMACS_INT, not int, for sizes.
1708 Check for size overflow.
1710 * image.c (cache_image): Check for size arithmetic overflow.
1712 * lread.c: Integer overflow issues.
1713 (saved_doc_string_size, saved_doc_string_length)
1714 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1715 Now ptrdiff_t, not int.
1716 (read1): Don't assume doc string length fits in int. Check for
1717 out-of-range doc string lengths.
1718 (read_list): Don't assume file position fits in int.
1719 (read_escape): Check for hex character overflow.
1721 2011-06-22 Leo Liu <sdl.web@gmail.com>
1723 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1724 Move to minibuffer.el.
1726 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1728 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1729 The following patches are for when GLYPH_DEBUG && !XASSERT.
1730 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1731 * dispnew.c (flush_stdout):
1732 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1733 Mark as externally visible.
1734 * dispnew.c (check_window_matrix_pointers): Now static.
1735 * dispnew.c (window_to_frame_vpos):
1736 * xfns.c (unwind_create_frame):
1737 * xterm.c (x_check_font): Remove unused local.
1738 * scroll.c (CHECK_BOUNDS):
1739 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1740 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1741 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1742 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1743 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1745 (debug_method_add): Use va_list and vsprintf rather than relying
1746 on undefined behavior with wrong number of arguments.
1747 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1748 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1749 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1750 since we're not interested in debugging glyphs with old libraries.
1751 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1752 GCC 4.6.0's static checking.
1754 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1756 Integer overflow and signedness fixes (Bug#8873).
1757 A few related buffer overrun fixes, too.
1759 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1761 * dispextern.h (struct face.stipple):
1762 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1763 (x_bitmap_mask, x_allocate_bitmap_record)
1764 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1765 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1766 (x_create_bitmap_from_xpm_data):
1767 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1768 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1770 * xfaces.c (load_pixmap):
1771 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1772 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1773 (.bitmaps_last, struct x_output.icon_bitmap):
1774 Use ptrdiff_t, not int, for bitmap indexes.
1775 (x_allocate_bitmap_record): Check for size overflow.
1776 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1778 Use ptrdiff_t, not int, for overlay counts.
1779 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1780 * editfns.c (overlays_around, get_pos_property):
1781 * textprop.c (get_char_property_and_overlay):
1782 * xdisp.c (next_overlay_change, note_mouse_highlight):
1783 * xfaces.c (face_at_buffer_position):
1784 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1785 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1786 (Fnext_overlay_change, Fprevious_overlay_change)
1787 (mouse_face_overlay_overlaps, Foverlays_in):
1788 Use ptrdiff_t, not int, for sizes.
1789 (overlays_at, overlays_in): Check for size-calculation overflow.
1791 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1793 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1794 (x_session_initialize): Do not assume string length fits in int.
1796 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1797 This is unlikely, but can occur if DPI is outlandish.
1799 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1800 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1802 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1803 * xrdb.c (magic_file_p, search_magic_path):
1804 Omit last arg SUFFIX; it was always 0. All callers changed.
1805 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1807 * xfont.c (xfont_match): Avoid need for strlen.
1809 * xfns.c: Don't assume strlen fits in int.
1810 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1812 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1813 not unsigned long, as we prefer signed integers. All callers changed.
1814 Detect integer overflow in repeat count.
1815 (message_dolog): Don't assume print length fits in 39 bytes.
1816 (display_mode_element): Don't assume strlen fits in int.
1818 * termcap.c: Don't assume sizes fit in int and never overflow.
1819 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1820 (gobble_line): Check for size-calculation overflow.
1822 * minibuf.c (Fread_buffer):
1823 * lread.c (intern, intern_c_string):
1824 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1825 Don't assume string length fits in int.
1827 * keyboard.c (parse_tool_bar_item):
1828 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1830 * font.c: Don't assume string length fits in int.
1831 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1832 Use ptrdiff_t, not int.
1833 (font_intern_prop): Don't assume string length fits in int.
1834 Don't assume integer property fits in fixnum.
1835 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1837 * filelock.c: Fix some buffer overrun and integer overflow issues.
1838 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1839 Reformulate so as not to need the command string.
1840 Invoke gzip -cd rather than gunzip, as it's more portable.
1841 (lock_info_type, lock_file_1, lock_file):
1842 Don't assume pid_t and time_t fit in unsigned long.
1843 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1844 (current_lock_owner): Prefer signed type for sizes.
1845 Use memcpy, not strncpy, where memcpy is what is really wanted.
1846 Don't assume (via atoi) that time_t and pid_t fit in int.
1847 Check for time_t and/or pid_t out of range, e.g., via a network share.
1848 Don't alloca where an auto var works fine.
1850 * fileio.c: Fix some integer overflow issues.
1851 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1852 Don't assume string length fits in int.
1853 (directory_file_name): Don't assume string length fits in long.
1854 (make_temp_name): Don't assume pid fits in int, or that its print
1855 length is less than 20.
1857 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1859 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1861 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1863 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1864 We prefer signed integers, even for size calculations.
1866 * emacs.c: Don't assume string length fits in 'int'.
1867 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1868 (main): Don't invoke strlen when not needed.
1870 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1871 (XD_DEBUG_MESSAGE): Don't waste a byte.
1873 * callproc.c (getenv_internal_1, getenv_internal)
1875 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1877 * lread.c (invalid_syntax): Omit length argument.
1878 All uses changed. This doesn't fix a bug, but it simplifies the
1879 code away from its former Hollerith-constant appearance, and it's
1880 one less 'int' to worry about when looking at integer-overflow issues.
1881 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1883 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1884 This didn't break anything, but it didn't help either.
1885 It's confusing to put a bogus integer in a place where the actual
1886 value does not matter.
1887 (LIST_END_P): Remove unused macro and its bogus comment.
1888 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1890 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1891 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1893 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1894 We prefer signed types, and the value cannot exceed the EMACS_INT
1895 range anyway (because otherwise the length would not be representable).
1896 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1897 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1898 This avoids a GCC warning when WIDE_EMACS_INT.
1900 * indent.c (sane_tab_width): New function.
1901 (current_column, scan_for_column, Findent_to, position_indentation)
1902 (compute_motion): Use it. This is just for clarity.
1903 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1905 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1907 * lisp.h (lint_assume): New macro.
1908 * composite.c (composition_gstring_put_cache):
1909 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1911 * editfns.c, insdel.c:
1912 Omit unnecessary forward decls, to simplify future changes.
1914 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1916 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1918 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1919 Use much-faster test for byte-length change.
1920 Don't assume string byte-length fits in 'int'.
1921 Check that character arg fits in 'int'.
1922 (mapcar1): Declare byte as byte, for clarity.
1924 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1926 * fns.c (concat): Catch string overflow earlier.
1927 Do not rely on integer wraparound.
1929 * dispextern.h (struct it.overlay_strings_charpos)
1930 (struct it.selective): Now EMACS_INT, not int.
1931 * xdisp.c (forward_to_next_line_start)
1932 (back_to_previous_visible_line_start)
1933 (reseat_at_next_visible_line_start, next_element_from_buffer):
1934 Don't arbitrarily truncate the value of 'selective' to int.
1936 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1938 * composite.c: Don't truncate sizes to 'int'.
1939 (composition_gstring_p, composition_reseat_it)
1940 (composition_adjust_point): Use EMACS_INT, not int.
1941 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1942 not EMACS_UINT, for indexes.
1944 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1946 * buffer.c: Include <verify.h>.
1947 (struct sortvec.priority, struct sortstr.priority):
1948 Now EMACS_INT, not int.
1949 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1950 (struct sortstr.size, record_overlay_string)
1951 (struct sortstrlist.size, struct sortlist.used):
1952 Don't truncate size to int.
1953 (record_overlay_string): Check for size-calculation overflow.
1954 (init_buffer_once): Check at compile-time, not run-time.
1956 2011-06-22 Jim Meyering <meyering@redhat.com>
1958 Don't leak an XBM-image-sized buffer
1959 * image.c (xbm_load): Free the image buffer after using it.
1961 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1964 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1965 that Sun C diagnosed.
1966 * fns.c (secure_hash): Fix pointer signedness issue.
1967 * intervals.c (static_offset_intervals): New function.
1968 (offset_intervals): Use it.
1970 2011-06-21 Leo Liu <sdl.web@gmail.com>
1973 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1976 * fns.c (secure_hash): Rename from crypto_hash_function and change
1977 the first arg to accept symbols.
1978 (Fsecure_hash): New primitive.
1979 (syms_of_fns): New symbols.
1981 2011-06-20 Deniz Dogan <deniz@dogan.se>
1983 * process.c (Fset_process_buffer): Clarify return value in
1986 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1988 * dispnew.c (add_window_display_history): Use BVAR.
1990 * xdisp.c (debug_method_add): Use BVAR.
1991 (check_window_end, dump_glyph_matrix, dump_glyph)
1992 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1994 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1997 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1998 check till after the cache is created in init_frame_faces.
2000 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2002 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2004 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2006 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2007 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2008 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2010 Improve buffer-overflow checking (Bug#8873).
2011 * fileio.c (Finsert_file_contents):
2012 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2013 Remove the old (too-loose) buffer overflow checks.
2014 They weren't needed, since make_gap checks for buffer overflow.
2015 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2016 The old code merely checked for Emacs fixnum overflow, and relied
2017 on undefined (wraparound) behavior. The new code avoids undefined
2018 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2020 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2021 Tune. Don't use wider integers than needed. Don't use alloca.
2022 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2024 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2026 * insdel.c, lisp.h (buffer_overflow): New function.
2027 (insert_from_buffer_1, replace_range, replace_range_2):
2028 * insdel.c (make_gap_larger):
2029 * editfns.c (Finsert_char):
2030 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2032 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2034 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2036 Integer overflow and signedness fixes (Bug#8873).
2038 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2039 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2041 * fileio.c: Don't assume EMACS_INT fits in off_t.
2042 (emacs_lseek): New static function.
2043 (Finsert_file_contents, Fwrite_region): Use it.
2044 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2046 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2048 * fns.c: Don't overflow int when computing a list length.
2049 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2050 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2051 truncation on 64-bit hosts. Check for QUIT every
2052 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2053 faster and is responsive enough.
2054 (Flength): Report an error instead of overflowing an integer.
2055 (Fsafe_length): Return a float if the value is not representable
2056 as a fixnum. This shouldn't happen except in contrived situations.
2057 (Fnthcdr, Fsort): Don't assume list length fits in int.
2058 (Fcopy_sequence): Don't assume vector length fits in int.
2060 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2061 (header_size, word_size): New constants.
2062 (allocate_vectorlike): Don't check size overflow here.
2063 (allocate_vector): Check it here instead, since this is the only
2064 caller of allocate_vectorlike that could cause overflow.
2065 Check that the new vector's length is representable as a fixnum.
2067 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2068 The previous code was bogus. For example, next_almost_prime (32)
2069 returned 39, which is undesirable as it is a multiple of 3; and
2070 next_almost_prime (24) returned 25, which is a multiple of 5 so
2071 why was the code bothering to check for multiples of 7?
2073 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2075 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2077 Variadic C functions now count arguments with ptrdiff_t.
2078 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2079 Back then I didn't know that the Emacs coding style prefers signed int.
2080 Also, in the meantime I found a few more instances where arguments
2081 were being counted with int, which may truncate counts on 64-bit
2082 machines, or EMACS_INT, which may be unnecessarily wide.
2083 * lisp.h (struct Lisp_Subr.function.aMANY)
2084 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2085 Arg counts are now ptrdiff_t, not size_t.
2086 All variadic functions and their callers changed accordingly.
2087 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2088 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2089 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2090 * callint.c (Fcall_interactively): Check arg count for overflow,
2091 to avoid potential buffer overrun. Use signed char, not 'int',
2092 for 'varies' array, so that we needn't bother to check its size
2093 calculation for overflow.
2094 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2095 * eval.c (apply_lambda):
2096 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2097 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2098 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2100 * callint.c (Fcall_interactively): Don't use index var as event count.
2102 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2103 * mem-limits.h (SIZE): Remove; no longer used.
2105 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2107 Remove unnecessary casts.
2108 * xterm.c (x_term_init):
2109 * xfns.c (x_set_border_pixel):
2110 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2111 These aren't needed now that we assume ANSI C.
2113 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2114 It's more likely to cause problems (due to unsigned overflow)
2117 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2119 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2121 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2123 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2125 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2127 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2129 GLYPH_CODE_FACE returns EMACS_INT, not int.
2130 * dispextern.h (merge_faces):
2131 * xfaces.c (merge_faces):
2132 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2133 Don't assume EMACS_INT fits in int.
2135 * character.h (CHAR_VALID_P): Remove unused parameter.
2136 * fontset.c, lisp.h, xdisp.c: All uses changed.
2138 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2140 * fns.c (concat): Minor tuning based on overflow analysis.
2141 This doesn't fix any bugs. Use int to hold character, instead
2142 of constantly refetching from Emacs object. Use XFASTINT, not
2143 XINT, for value known to be a character. Don't bother comparing
2144 a single byte to 0400, as it's always less.
2146 * floatfns.c (Fexpt):
2147 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2149 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2152 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2154 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2155 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2156 incorrectly succeed when S was a string, because 4294967386 was
2157 truncated before it was used.
2159 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2160 Otherwise, an out-of-range integer could cause undefined behavior
2163 * composite.c: Use int, not EMACS_INT, for characters.
2164 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2165 EMACS_INT, for values that are known to be in character range.
2166 This doesn't fix any bugs but is the usual style inside Emacs and
2167 may generate better code on 32-bit machines.
2169 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2170 This is for reasons similar to the recent CHAR_STRING fix.
2171 * charset.c (Fencode_char): Check that character arg is actually
2172 a character. Pass an int to ENCODE_CHAR.
2173 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2174 wider than 'int', as a compile-time check to prevent future regressions
2177 * character.c (char_string): Remove unnecessary casts.
2179 Make sure a 64-bit char is never passed to CHAR_STRING.
2180 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2181 by silently ignoring the top 32 bits, allowing some values
2182 that were far too large to be valid characters.
2183 * character.h: Include <verify.h>.
2184 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2185 arguments are no wider than unsigned, as a compile-time check
2186 to prevent future regressions in this area.
2188 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2189 (Fsubst_char_in_region):
2191 * xdisp.c (decode_mode_spec_coding):
2192 Adjust to CHAR_STRING's new requirement.
2193 * editfns.c (Finsert_char, Fsubst_char_in_region):
2194 * fns.c (concat): Check that character args are actually
2195 characters. Without this test, these functions did the wrong
2196 thing with wildly out-of-range values on 64-bit hosts.
2198 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2199 These casts should not be needed on 32-bit hosts, either.
2200 * keyboard.c (read_char):
2201 * lread.c (Fload): Remove casts to unsigned.
2203 * lisp.h (UNSIGNED_CMP): New macro.
2204 This fixes comparison bugs on 64-bit hosts.
2205 (ASCII_CHAR_P): Use it.
2206 * casefiddle.c (casify_object):
2207 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2208 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2209 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2210 * dispextern.h (FACE_FROM_ID):
2211 * keyboard.c (read_char): Use UNSIGNED_CMP.
2213 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2214 not to EMACS_INT, to avoid GCC warning.
2216 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2218 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2219 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2220 isn't needed on 32-bit machines.
2222 * buffer.c (Fgenerate_new_buffer_name):
2223 Use EMACS_INT for count, not int.
2224 (advance_to_char_boundary): Return EMACS_INT, not int.
2226 * data.c (Qcompiled_function): Now static.
2228 * window.c (window_body_lines): Now static.
2230 * image.c (gif_load): Rename local to avoid shadowing.
2232 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2233 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2234 * alloc.c (make_save_value): Integer argument is now of type
2236 (mark_object): Use ptrdiff_t, not int.
2237 * lisp.h (pD): New macro.
2238 * print.c (print_object): Use it.
2240 * alloc.c: Use EMACS_INT, not int, to count objects.
2241 (total_conses, total_markers, total_symbols, total_vector_size)
2242 (total_free_conses, total_free_markers, total_free_symbols)
2243 (total_free_floats, total_floats, total_free_intervals)
2244 (total_intervals, total_strings, total_free_strings):
2245 Now EMACS_INT, not int. All uses changed.
2246 (Fgarbage_collect): Compute overall total using a double, so that
2247 integer overflow is less likely to be a problem. Check for overflow
2248 when converting back to an integer.
2249 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2250 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2251 These were 'int' variables that could overflow on 64-bit hosts;
2252 they were never used, so remove them instead of repairing them.
2253 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2254 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2255 Previously, this ceilinged at INT_MAX, but that doesn't work on
2257 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2259 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2260 (allocate_vectorlike): Check for ptrdiff_t overflow.
2261 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2262 when a (possibly-narrower) signed value would do just as well.
2263 We prefer using signed arithmetic, to avoid comparison confusion.
2265 * alloc.c: Catch some string size overflows that we were missing.
2266 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2267 for convenience in STRING_BYTES_MAX.
2268 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2269 The definition here is exact; the one in lisp.h was approximate.
2270 (allocate_string_data): Check for string overflow. This catches
2271 some instances we weren't catching before. Also, it catches
2272 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2273 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2274 and ptrdiff_t and EMACS_INT are both 64 bits.
2276 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2277 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2278 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2280 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2282 * alloc.c (Fmake_string): Check for out-of-range init.
2284 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2286 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2288 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2290 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2291 xg_get_default_scrollbar_width.
2293 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2294 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2295 (style_changed_cb): Call update_theme_scrollbar_width and call
2296 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2297 all frames (Bug#8505).
2298 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2299 Call gtk_window_set_resizable if HAVE_GTK3.
2300 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2301 and height if HAVE_GTK3 (Bug#8505).
2302 (scroll_bar_width_for_theme): New variable.
2303 (update_theme_scrollbar_width): New function.
2304 (xg_get_default_scrollbar_width): Move code to
2305 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2306 (xg_initialize): Call update_theme_scrollbar_width.
2308 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2310 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2312 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2314 * frame.c (make_frame): Call other_buffer_safely instead of
2317 * window.c (temp_output_buffer_show): Call display_buffer with
2318 second argument Vtemp_buffer_show_specifiers and reset latter
2319 immediately after the call.
2320 (Vtemp_buffer_show_specifiers): New variable.
2321 (auto_window_vscroll_p, next_screen_context_lines)
2322 (Vscroll_preserve_screen_position): Remove leading asterisks from
2325 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2327 Fix minor problems found by GCC 4.6.0 static checking.
2328 * buffer.c (Qclone_number): Remove for now, as it's unused.
2329 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2330 (record_buffer): Remove unused local.
2331 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2332 (set_frame_buffer_list): Remove; unused.
2333 * frame.h (other_visible_frames): Remove decl.
2334 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2335 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2336 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2338 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2339 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2340 Define only if HAVE_GPM.
2341 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2342 (update_hints_inhibit): Remove; never set. All uses removed.
2343 * widgetprv.h (emacsFrameClassRec): Remove decl.
2344 * window.c (delete_deletable_window): Now returns void, since it
2345 wasn't returning anything.
2346 (compare_window_configurations): Remove unused locals.
2347 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2348 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2349 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2350 the same widths as pointers. This follows up on the 2011-05-06 patch.
2351 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2352 * xterm.h: Likewise.
2353 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2355 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2357 * makefile.w32-in: Update dependencies.
2358 (LISP_H): Add lib/intprops.h.
2360 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2362 * image.c (gif_load): Add animation frame delay to the metadata.
2363 (syms_of_image): Use DEFSYM. New symbol `delay'.
2365 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2367 * window.c (delete_deletable_window): Re-add.
2368 (Fset_window_configuration): Rewrite to handle dead buffers and
2369 consequently deletable windows.
2370 (window_tree, Fwindow_tree): Remove. Supply functionality in
2372 (compare_window_configurations): Simplify code.
2374 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2376 * image.c (imagemagick_load_image): Fix type mismatch.
2377 (Fimagemagick_types): Likewise.
2379 * window.h (replace_buffer_in_windows): Declare.
2381 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2383 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2384 Qclone_number. Remove external declaration of Qdelete_window.
2385 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2387 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2388 Run Qbuffer_list_update_hook if allowed.
2389 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2390 buffer list implementation.
2391 (other_buffer_safely): New function.
2392 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2393 calls to replace_buffer_in_windows and
2394 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2396 (record_buffer): Inhibit quitting and rewrite using quittable
2397 functions. Run Qbuffer_list_update_hook if allowed.
2398 (Frecord_buffer, Funrecord_buffer): New functions.
2399 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2400 Move switch-to-buffer to window.el.
2401 (bury-buffer): Move to window.el.
2402 (Vbuffer_list_update_hook): New variable.
2404 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2407 * window.h (resize_frame_windows): Move up in code.
2408 (Fwindow_frame): Remove EXFUN.
2409 (replace_buffer_in_all_windows): Remove prototype.
2410 (replace_buffer_in_windows_safely): Add prototype.
2412 * window.c: Declare Qdelete_window static again. Move down
2413 declaration of select_count.
2414 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2415 (Fother_window): Move to window.el.
2416 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2417 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2418 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2420 (replace_buffer_in_windows): Implement by calling
2421 Qreplace_buffer_in_windows.
2422 (replace_buffer_in_all_windows): Remove with some functionality
2423 moved into replace_buffer_in_windows_safely.
2424 (replace_buffer_in_windows_safely): New function.
2425 (select_window_norecord, select_frame_norecord): Move in front
2426 of run_window_configuration_change_hook. Remove now obsolete
2428 (Fset_window_buffer): Rewrite doc-string.
2429 Call Qrecord_window_buffer.
2430 (keys_of_window): Move binding for other-window to window.el.
2432 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2434 * dispextern.h (struct image): Replace data member, whose int_val
2435 and ptr_val fields were not used by anything, with a single
2438 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2439 (gif_clear_image, gif_load, imagemagick_load_image)
2440 (gs_clear_image, gs_load): Callers changed.
2442 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2444 * buffer.h: Include <time.h>, for time_t.
2445 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2447 Fix minor problems found by static checking.
2449 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2451 Make identifiers static if they are not used in other modules.
2452 * data.c (Qcompiled_function, Qframe, Qvector):
2453 * image.c (QimageMagick, Qsvg):
2454 * minibuf.c (Qmetadata):
2455 * window.c (resize_window_check, resize_root_window): Now static.
2456 * window.h (resize_window_check, resize_root_window): Remove decls.
2458 * window.c (window_deletion_count, delete_deletable_window):
2460 (window_body_lines): Now static.
2461 (Fdelete_other_windows_internal): Mark vars as initialized.
2462 Make sure 'resize_failed' is initialized.
2463 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2464 (resize_window_apply): Remove unused local.
2465 * window.h (delete_deletable_window): Remove decl.
2467 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2468 (imagemagick_load_image): Fix pointer signedness problem by changing
2469 last arg from unsigned char * to char *. All uses changed.
2470 Also, fix a local for similar reasons.
2471 Remove unused locals. Remove locals to avoid shadowing.
2472 (fn_rsvg_handle_free): Remove; unused.
2473 (svg_load, svg_load_image): Fix pointer signedness problem.
2474 (imagemagick_load_image): Don't use garbage pointer image_wand.
2476 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2478 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2480 * image.c (gif_load): Fix omitted cast error introduced by
2483 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2485 * window.h (resize_proportionally, orig_total_lines)
2486 (orig_top_line): Remove from window structure.
2487 (set_window_height, set_window_width, change_window_heights)
2488 (Fdelete_window): Remove prototypes.
2489 (resize_frame_windows): Remove duplicate declaration.
2491 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2493 * window.h (resize_frame_windows, resize_window_check)
2494 (delete_deletable_window, resize_root_window)
2495 (resize_frame_windows): Declare prototypes.
2497 * window.c (resize_window_apply): Make definition be "static" to
2498 match the prototype.
2500 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2502 * window.c: Remove declarations of Qwindow_size_fixed,
2503 window_min_size_1, window_min_size_2, window_min_size,
2504 size_window, window_fixed_size_p, enlarge_window, delete_window.
2505 Remove static from declaration of Qdelete_window, it's
2506 temporarily needed by Fbury_buffer.
2507 (replace_window): Don't assign orig_top_line and
2509 (Fdelete_window, delete_window): Remove. Window deletion is
2510 handled by window.el.
2511 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2512 Replace Fdelete_window calls with calls to Qdelete_window.
2513 (Fdelete_other_windows): Remove. Deleting other windows is
2514 handled by window.el.
2515 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2516 handled in window.el.
2517 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2518 Window minimum sizes are handled in window.el.
2519 (shrink_windows, size_window, set_window_height)
2520 (set_window_width, change_window_heights, window_height)
2521 (window_width, CURBEG, CURSIZE, enlarge_window)
2522 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2523 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2524 handled in window.el.
2525 (make_dummy_parent): Rename to make_parent_window and give it a
2526 second argument horflag.
2527 (make_window): Don't set resize_proportionally any more.
2528 (Fsplit_window): Remove. Windows are split in window.el.
2529 (save_restore_action, save_restore_orig_size)
2530 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2531 Resize mini windows in window.el.
2532 (grow_mini_window, shrink_mini_window): Implement by calling
2533 Qresize_root_window_vertically, resize_window_check and
2534 resize_window_apply.
2535 (saved_window, Fset_window_configuration, save_window_save):
2536 Do not handle orig_top_line, orig_total_lines, and
2537 resize_proportionally.
2538 (window_min_height, window_min_width): Move to window.el.
2539 (keys_of_window): Move bindings for delete-other-windows,
2540 split-window, delete-window and enlarge-window to window.el.
2542 * buffer.c: Temporarily extern Qdelete_window.
2543 (Fbury_buffer): Temporarily call Qdelete_window instead of
2544 Fdelete_window (Fbury_buffer will move to window.el soon).
2546 * frame.c (set_menu_bar_lines_1): Remove code handling
2547 orig_top_line and orig_total_lines.
2549 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2550 set_window_height but set heights directly.
2551 (change_frame_size_1): Use resize_frame_windows.
2553 * xdisp.c (init_xdisp): Don't use set_window_height but set
2556 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2557 Use resize_frame_windows instead of change_window_heights and run
2558 run_window_configuration_change_hook.
2560 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2561 instead of change_window_heights and run
2562 run_window_configuration_change_hook.
2564 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2566 * window.c (replace_window): Rename second argument REPLACEMENT to
2567 NEW. New third argument SETFLAG. Rewrite.
2568 (delete_window, make_dummy_parent): Call replace_window with
2570 (window_list_1): Move down in code.
2571 (run_window_configuration_change_hook): Move set_buffer part
2572 before select_frame_norecord part in order to unwind correctly.
2573 Rename count1 to count.
2574 (recombine_windows, delete_deletable_window, resize_root_window)
2575 (Fdelete_other_windows_internal)
2576 (Frun_window_configuration_change_hook, make_parent_window)
2577 (resize_window_check, resize_window_apply, Fresize_window_apply)
2578 (resize_frame_windows, Fsplit_window_internal)
2579 (Fdelete_window_internal, Fresize_mini_window_internal):
2581 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2583 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2585 * window.h (window): Add some new members to window structure -
2586 normal_lines, normal_cols, new_total, new_normal, clone_number,
2587 splits, nest, prev_buffers, next_buffers.
2588 (WINDOW_TOTAL_SIZE): Move here from window.c.
2589 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2591 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2593 (make_dummy_parent): Set new members of windows structure.
2594 (make_window): Move down in code. Handle new members of window
2596 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2597 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2598 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2599 (Fset_window_prev_buffers, Fwindow_next_buffers)
2600 (Fset_window_next_buffers, Fset_window_clone_number):
2602 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2603 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2605 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2606 Argument WINDOW can be now internal window too.
2607 (Fwindow_use_time): Move up in code.
2608 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2610 (Fset_window_configuration, saved_window)
2611 (Fcurrent_window_configuration, save_window_save): Handle new
2612 members of window structure.
2613 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2614 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2615 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2616 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2617 Qget_mru_window, Qresize_root_window,
2618 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2619 Qauto_buffer_name; staticpro them.
2621 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2623 * window.c (Fwindow_total_size, Fwindow_left_column)
2624 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2625 (Fwindow_list_1): New functions.
2626 (window_box_text_cols): Replace with window_body_cols.
2627 (Fwindow_width, Fscroll_left, Fscroll_right):
2628 Use window_body_cols instead of window_box_text_cols.
2629 (delete_window, Fset_window_configuration):
2630 Call delete_all_subwindows with window as argument.
2631 (delete_all_subwindows): Take a window as argument and not a
2633 (window_loop): Remove handling of GET_LRU_WINDOW and
2635 (Fget_lru_window, Fget_largest_window): Move to window.el.
2637 * window.h: Extern window_body_cols instead of
2638 window_box_text_cols. delete_all_subwindows now takes a
2639 Lisp_Object as argument.
2641 * indent.c (compute_motion, Fcompute_motion):
2642 Use window_body_cols instead of window_box_text_cols.
2644 * frame.c (delete_frame): Call delete_all_subwindows with root
2647 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2649 * fns.c (Fputhash): Document return value.
2651 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2653 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2655 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2657 Cons<->int and similar integer overflow fixes (Bug#8794).
2659 Check for overflow when converting integer to cons and back.
2660 * charset.c (Fdefine_charset_internal, Fdecode_char):
2661 Use cons_to_unsigned to catch overflow.
2662 (Fencode_char): Use INTEGER_TO_CONS.
2663 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2664 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2665 * data.c (long_to_cons, cons_to_long): Remove.
2666 (cons_to_unsigned, cons_to_signed): New functions.
2667 These signal an error for invalid or out-of-range values.
2668 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2669 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2670 * font.c (Ffont_variation_glyphs):
2671 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2672 * lisp.h: Include <intprops.h>.
2673 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2674 (cons_to_signed, cons_to_unsigned): New decls.
2675 (long_to_cons, cons_to_long): Remove decls.
2676 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2677 (Fprimitive_undo): Use CONS_TO_INTEGER.
2678 * xfns.c (Fx_window_property): Likewise.
2679 * xselect.c: Include <limits.h>.
2680 (x_own_selection, selection_data_to_lisp_data):
2681 Use INTEGER_TO_CONS.
2682 (x_handle_selection_request, x_handle_selection_clear)
2683 (x_get_foreign_selection, Fx_disown_selection_internal)
2684 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2685 (lisp_data_to_selection_data): Use cons_to_unsigned.
2686 (x_fill_property_data): Use cons_to_signed.
2687 Report values out of range.
2689 Check for buffer and string overflow more precisely.
2690 * buffer.h (BUF_BYTES_MAX): New macro.
2691 * lisp.h (STRING_BYTES_MAX): New macro.
2692 * alloc.c (Fmake_string):
2693 * character.c (string_escape_byte8):
2694 * coding.c (coding_alloc_by_realloc):
2695 * doprnt.c (doprnt):
2696 * editfns.c (Fformat):
2698 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2699 since they may not be the same number.
2700 * editfns.c (Finsert_char):
2701 * fileio.c (Finsert_file_contents):
2702 Likewise for BUF_BYTES_MAX.
2704 * image.c: Use ptrdiff_t, not int, for sizes.
2705 (slurp_file): Switch from int to ptrdiff_t.
2707 (slurp_file): Check that file size fits in both size_t (for
2708 malloc) and ptrdiff_t (for sanity and safety).
2710 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2711 if b->modtime has its maximal value.
2713 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2715 Don't assume time_t can fit into int.
2716 * buffer.h (struct buffer.modtime): Now time_t, not int.
2717 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2718 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2720 Minor fixes for signed vs unsigned integers.
2721 * character.h (MAYBE_UNIFY_CHAR):
2722 * charset.c (maybe_unify_char):
2723 * keyboard.c (read_char, reorder_modifiers):
2724 XINT -> XFASTINT, since the integer must be nonnegative.
2725 * ftfont.c (ftfont_spec_pattern):
2726 * keymap.c (access_keymap, silly_event_symbol_error):
2727 XUINT -> XFASTINT, since the integer must be nonnegative.
2728 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2729 since it makes no difference and we prefer signed.
2730 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2731 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2734 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2736 * window.h (Fwindow_frame): Declare.
2738 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2740 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2741 (SPARE_MEMORY): Always define.
2742 (LARGE_REQUEST): Remove.
2743 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2745 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2747 * lisp.h: Move EXFUNS for Fframe_root_window,
2748 Fframe_first_window and Fset_frame_selected_window to window.h.
2750 * window.h: Move EXFUNS for Fframe_root_window,
2751 Fframe_first_window and Fset_frame_selected_window here from
2754 * frame.c (Fwindow_frame, Fframe_first_window)
2755 (Fframe_root_window, Fframe_selected_window)
2756 (Fset_frame_selected_window): Move to window.c.
2757 (Factive_minibuffer_window): Move to minibuf.c.
2758 (Fother_visible_frames_p): New function.
2760 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2762 * window.c (decode_window, decode_any_window): Move up in code.
2763 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2764 (inhibit_frame_unsplittable): Remove unused variable.
2765 (Fwindow_buffer): Move up and rewrite doc-string.
2766 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2767 (Fwindow_prev): New functions.
2768 (Fwindow_frame): Move here from frame.c. Accept any window as
2770 (Fframe_root_window, Fframe_first_window)
2771 (Fframe_selected_window): Move here from frame.c. Accept frame
2772 or arbitrary window as argument. Update doc-strings.
2773 (Fminibuffer_window): Move up in code.
2774 (Fwindow_minibuffer_p): Move up in code and simplify.
2775 (Fset_frame_selected_window): Move here from frame.c.
2777 (Fselected_window, select_window, Fselect_window): Move up in
2778 code. Minor doc-string fixes.
2780 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2782 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2783 Do not assume that spare memory exists; that assumption is valid
2784 only if SYSTEM_MALLOC.
2785 (LARGE_REQUEST): New macro, so that the issue of large requests
2786 is separated from the issue of spare memory.
2788 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2790 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2793 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2795 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2798 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2800 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2802 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2804 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2805 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2807 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2809 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2811 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2813 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2814 (x_clipboard_manager_save): Add return value.
2815 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2817 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2818 Obey Vx_select_enable_clipboard_manager. Catch errors in
2819 x_clipboard_manager_save (Bug#8779).
2820 (Vx_select_enable_clipboard_manager): New variable.
2821 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2823 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2825 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2827 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2829 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2830 in the current matrix if keep_current_p is non-zero.
2832 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2834 * bidi.c (bidi_level_of_next_char): Fix last change.
2836 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2838 Support bidi reordering of text covered by display properties.
2840 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2841 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2842 (bidi_cache_search, bidi_cache_iterator_state)
2843 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2844 (bidi_level_of_next_char, bidi_move_to_visually_next):
2845 Support character positions inside a run of characters covered by a
2847 (bidi_paragraph_init, bidi_resolve_explicit_1)
2848 (bidi_level_of_next_char): Call bidi_fetch_char and
2849 bidi_fetch_char_advance instead of FETCH_CHAR and
2851 (bidi_init_it): Initialize new members.
2852 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2854 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2855 instead of using explicit *_CHAR codes.
2856 (bidi_resolve_explicit, bidi_resolve_weak):
2857 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2858 bidirectional text is supported only in multibyte buffers.
2859 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2860 it to initialize the frame_window_p member of struct bidi_it.
2861 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2862 (bidi_resolve_explicit, bidi_resolve_weak)
2863 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2864 bidi_it->nchars is non-positive.
2865 (bidi_level_of_next_char): Don't try to lookup the cache for the
2866 next/previous character if nothing is cached there yet, or if we
2867 were just reseat()'ed to a new position.
2869 * xdisp.c (set_cursor_from_row): Set start and stop points
2870 according to the row's direction when priming the loop that looks
2871 for the glyph on which to display cursor.
2872 (single_display_spec_intangible_p): Function deleted.
2873 (display_prop_intangible_p): Reimplement to call
2874 handle_display_spec instead of single_display_spec_intangible_p.
2875 Accept 3 additional arguments needed by handle_display_spec.
2876 This fixes incorrect cursor motion across display property with complex
2877 values: lists, `(when COND...)' forms, etc.
2878 (single_display_spec_string_p): Support property values that are
2879 lists with the argument STRING its top-level element.
2880 (display_prop_string_p): Fix the condition for processing a
2881 property that is a list to be consistent with handle_display_spec.
2882 (handle_display_spec): New function, refactored from the
2883 last portion of handle_display_prop.
2884 (compute_display_string_pos): Accept additional argument
2885 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2886 value of a `display' property is a "replacing spec".
2887 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2888 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2889 the display property, but just return a value indicating whether
2890 the display property will replace the characters it covers.
2891 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2892 frame_window_p members of struct bidi_it.
2893 (compute_display_string_pos, compute_display_string_end):
2895 (push_it): Accept second argument POSITION, where pop_it should
2896 jump to continue iteration.
2897 (reseat_1): Initialize bidi_it.disp_pos.
2899 * keyboard.c (adjust_point_for_property): Adjust the call to
2900 display_prop_intangible_p to its new signature.
2902 * dispextern.h (struct bidi_it): New member frame_window_p.
2903 (bidi_init_it): Update prototypes.
2904 (display_prop_intangible_p): Update prototype.
2905 (compute_display_string_pos, compute_display_string_end):
2907 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2910 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2912 Malloc failure behavior now depends on size of allocation.
2913 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2914 * lisp.h: Change signatures accordingly.
2915 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2916 All callers changed. (Bug#8762)
2918 * gnutls.c: Use Emacs's memory allocators.
2919 Without this change, the gnutls library would invoke malloc etc.
2920 directly, which causes problems on non-SYNC_INPUT hosts, and which
2921 runs afoul of improving memory_full behavior. (Bug#8761)
2922 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2923 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2924 xfree instead of the default malloc, realloc, free.
2925 (Fgnutls_boot): No need to check for memory allocation failure,
2926 since xmalloc does that for us.
2928 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2929 * category.c (hash_get_category_set):
2930 * ccl.c (ccl_driver):
2931 * charset.c (Fdefine_charset_internal):
2932 * charset.h (struct charset.hash_index):
2933 * composite.c (get_composition_id, gstring_lookup_cache)
2934 (composition_gstring_put_cache):
2935 * composite.h (struct composition.hash_index):
2936 * dispextern.h (struct image.hash):
2937 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2938 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2939 (hashfn_equal, hashfn_user_defined, make_hash_table)
2940 (maybe_resize_hash_table, hash_lookup, hash_put)
2941 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2942 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2943 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2944 * image.c (make_image, search_image_cache, lookup_image)
2945 (xpm_put_color_table_h):
2946 * lisp.h (struct Lisp_Hash_Table):
2947 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2948 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2949 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2950 * alloc.c (allocate_vectorlike):
2951 Check for overflow in vector size calculations.
2952 * ccl.c (ccl_driver):
2953 Check for overflow when converting EMACS_INT to int.
2954 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2955 need to be updated by these changes.
2956 * fns.c (make_hash_table, maybe_resize_hash_table):
2957 Check for integer overflow with large hash tables.
2958 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2959 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2960 (SXHASH_REDUCE): New macro.
2961 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2962 Use it instead of discarding useful hash info with large hash values.
2963 (sxhash_float): New function.
2964 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2965 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2966 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2967 Rewrite to use FIXNUM_BITS, as this simplifies things.
2968 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2969 Adjust signatures to match updated version of code.
2970 (consing_since_gc): Now EMACS_INT, since a single hash table can
2971 use more than INT_MAX bytes.
2973 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2975 Make it possible to build with GCC-4.6+ -O2 -flto.
2977 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2979 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2981 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2982 Call minibuffer-inactive-mode.
2984 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2986 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2987 Update dependencies.
2989 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2991 * data.c (init_data): Remove code for UTS, this system is not
2994 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2996 Don't force ./temacs to start in terminal mode.
2998 * frame.c (make_initial_frame): Initialize faces in all cases, not
2999 only when CANNOT_DUMP is defined.
3000 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3002 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3004 * dispnew.c (add_window_display_history): Use const for the string
3005 pointer. Remove declaration, not needed.
3007 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3009 Use 'inline', not 'INLINE'.
3010 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3011 * alloc.c, fontset.c (INLINE): Remove.
3012 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3013 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3014 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3015 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3016 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3018 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3020 Make it possible to run ./temacs.
3022 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3023 syms_of_callproc does the same thing. Remove test for
3024 "initialized", do it in the caller.
3025 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3027 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3029 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3030 (read_minibuf): Use get_minibuffer.
3031 (syms_of_minibuf): Use DEFSYM.
3032 (Qmetadata): New var.
3033 * data.c (Qbuffer): Don't make it static.
3034 (syms_of_data): Use DEFSYM.
3036 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3038 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3039 (CCL_CODE_MIN): New macro.
3041 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3043 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3045 * eval.c (Qdebug): Now static.
3046 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3047 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3048 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3050 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3052 * image.c: Various fixes to ImageMagick code comments.
3053 (Fimagemagick_types): Doc fix.
3055 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3057 Minor fixes prompted by GCC 4.6.0 warnings.
3059 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3061 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3062 (x_clipboard_manager_save_all): Move extern decl to ...
3063 * xterm.h: ... here, so that it can be checked for consistency.
3065 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3067 * xselect.c (x_clipboard_manager_save_frame)
3068 (x_clipboard_manager_save_all): New functions.
3069 (Fx_clipboard_manager_save): Lisp function deleted.
3071 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3072 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3074 * xterm.h: Update prototype.
3076 2011-05-28 William Xu <william.xwl@gmail.com>
3078 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3081 2011-05-28 Jim Meyering <meyering@redhat.com>
3083 Avoid a sign-extension bug in crypto_hash_function.
3084 * fns.c (to_uchar): Define.
3085 (crypto_hash_function): Use it to convert some newly-signed
3086 variables to unsigned, to avoid sign-extension bugs. For example,
3087 without this change, (md5 "truc") would evaluate to
3088 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3089 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3090 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3092 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3094 Integer overflow fixes.
3096 * dbusbind.c: Serial number integer overflow fixes.
3097 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3098 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3099 to hold a serial number that is too large for a fixnum.
3100 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3101 Check for serial numbers out of range. Decode any serial number
3102 that was so large that it became a float. (Bug#8722)
3104 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3105 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3106 Use XFASTINT rather than XUINT when numbers are nonnegative.
3107 (xd_append_arg, Fdbus_method_return_internal):
3108 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3109 arguments, check that Lisp number is nonnegative, rather than
3110 silently wrapping negative numbers around. (Bug#8722)
3111 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3114 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3116 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3118 ccl: add integer overflow checks
3119 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3120 (IN_INT_RANGE): New macros.
3121 (ccl_driver): Use them to check for integer overflow when
3122 decoding a CCL program. Many of the new checks are whether XINT (x)
3123 fits in int; it doesn't always, on 64-bit hosts. The new version
3124 doesn't catch all possible integer overflows, but it's an
3125 improvement. (Bug#8719)
3127 * alloc.c (make_event_array): Use XINT, not XUINT.
3128 There's no need for unsigned here.
3130 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3131 This follows up to the 2011-05-06 change that substituted uintptr_t
3132 for EMACS_INT. This case wasn't caught back then.
3134 Rework Fformat to avoid integer overflow issues.
3135 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3136 now (part of C89). Include <verify.h>.
3137 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3138 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3139 (Fformat): Avoid the prepass trying to compute sizes; it was only
3140 approximate and thus did not catch overflow reliably. Instead, walk
3141 through the format just once, formatting and computing sizes as we go,
3142 checking for integer overflow at every step, and allocating a larger
3143 buffer as needed. Keep track separately whether the format is
3144 multibyte. Keep only the most-recently calculated precision, rather
3145 than them all. Record whether each argument has been converted to
3146 string. Use EMACS_INT, not int, for byte and char and arg counts.
3147 Support field widths and precisions larger than INT_MAX. Avoid
3148 sprintf's undefined behavior with conversion specifications such as %#d
3149 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3150 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3151 formatting out-of-range floating point numbers with int
3154 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3156 * data.c: Avoid integer truncation in expressions involving floats.
3157 * data.c: Include <intprops.h>.
3158 (arith_driver): When there's an integer overflow in an expression
3159 involving floating point, convert the integers to floating point
3160 so that the resulting value does not suffer from catastrophic
3161 integer truncation. For example, on a 64-bit host (* 4
3162 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3163 Do not rely on undefined behavior after integer overflow.
3165 merge count_size_as_multibyte, parse_str_to_multibyte
3166 * character.c, character.h (count_size_as_multibyte):
3167 Rename from parse_str_to_multibyte; all uses changed.
3168 Check for integer overflow.
3169 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3170 since it's now a duplicate of the other. This is more of
3171 a character than a buffer op, so better that it's in character.c.
3172 * fns.c, print.c: Adjust to above changes.
3174 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3176 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3178 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3180 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3181 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3182 (x_clipboard_manager_save): Now static.
3183 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3185 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3186 (crypto_hash_function): Now static.
3187 Fix pointer signedness problems. Avoid unnecessary initializations.
3189 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3191 * termhooks.h (Vselection_alist): Make it terminal-local.
3193 * terminal.c (create_terminal): Initialize it.
3195 * xselect.c: Support for clipboard managers.
3196 (Vselection_alist): Move to termhooks.h as terminal-local var.
3197 (LOCAL_SELECTION): New macro.
3198 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3199 (symbol_to_x_atom): Remove gratuitous arg.
3200 (x_handle_selection_request, lisp_data_to_selection_data)
3201 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3202 (x_own_selection, x_get_local_selection, x_convert_selection):
3203 New arg, specifying work frame. Use terminal-local Vselection_alist.
3204 (some_frame_on_display): Delete unused function.
3205 (Fx_own_selection_internal, Fx_get_selection_internal)
3206 (Fx_disown_selection_internal, Fx_selection_owner_p)
3207 (Fx_selection_exists_p): New optional frame arg.
3208 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3209 (x_handle_selection_clear): Don't treat other terminals with the
3210 same keyboard specially. Use the terminal-local Vselection_alist.
3211 (x_clear_frame_selections): Use Frun_hook_with_args.
3213 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3215 * xterm.h: Add support for those atoms.
3217 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3219 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3220 (converted_selections, conversion_fail_tag): New global variables.
3221 (x_selection_request_lisp_error): Free the above.
3222 (x_get_local_selection): Remove unnecessary code.
3223 (x_reply_selection_request): Args changed; handle arbitrary array
3224 of converted selections stored in converted_selections.
3225 Separate the XChangeProperty and SelectionNotify steps.
3226 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3227 (x_convert_selection): New function.
3228 (x_handle_selection_event): Simplify.
3229 (x_get_foreign_selection): Don't ignore incoming requests while
3230 waiting for an answer; this will fail when we implement
3231 SAVE_TARGETS, and seems unnecessary anyway.
3232 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3233 (Vx_sent_selection_functions): Doc fix.
3235 2011-05-26 Leo Liu <sdl.web@gmail.com>
3237 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3239 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3241 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3243 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3244 for fringe update if it has periodic bitmap.
3245 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3246 and fringe_bitmap_periodic_p.
3248 * fringe.c (get_fringe_bitmap_data): New function.
3249 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3250 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3251 row. Mark glyph row for fringe update if periodicity changed.
3253 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3254 for fringe update unless it has periodic bitmap.
3256 2011-05-25 Kenichi Handa <handa@m17n.org>
3258 * xdisp.c (get_next_display_element): Set correct it->face_id for
3259 a static composition.
3261 2011-05-24 Leo Liu <sdl.web@gmail.com>
3264 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3266 * fns.c (crypto_hash_function, Fsha1): New function.
3267 (Fmd5): Use crypto_hash_function.
3268 (syms_of_fns): Add Ssha1.
3270 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3272 * gnutls.c: Remove unused macros.
3273 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3274 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3275 Remove macros that are defined and never used.
3276 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3278 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3280 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3281 (Fx_get_selection_internal): Minor cleanup.
3282 (Fx_own_selection_internal): Rename arguments for consistency with
3285 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3287 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3289 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3291 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3293 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3295 * dispnew.c (scrolling_window): Don't exclude the case that the
3296 last enabled row in the desired matrix touches the bottom boundary.
3298 2011-05-21 Glenn Morris <rgm@gnu.org>
3300 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3301 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3302 and add some more files.
3304 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3306 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3307 report_file_error introduced by the change from 2011-05-07.
3309 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3311 * systime.h (Time): Define only if emacs is defined.
3312 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3313 where the include path doesn't have X11/X.h by default. See
3314 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3316 2011-05-20 Kenichi Handa <handa@m17n.org>
3318 * composite.c (find_automatic_composition): Fix previous change.
3320 2011-05-20 Glenn Morris <rgm@gnu.org>
3322 * lisp.mk: New file, split from Makefile.in.
3323 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3324 (shortlisp): Remove.
3325 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3327 2011-05-19 Glenn Morris <rgm@gnu.org>
3329 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3330 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3331 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3332 (lisp): Set the order to that of loadup.el.
3333 (shortlisp): Make it a copy of $lisp.
3334 (SOME_MACHINE_LISP): Remove.
3335 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3336 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3338 2011-05-18 Kenichi Handa <handa@m17n.org>
3340 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3341 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3342 (find_automatic_composition): Mostly rewrite for efficiency.
3344 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3346 * makefile.w32-in: Update dependencies.
3348 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3350 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3351 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3353 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3355 Fix some integer overflow issues, such as string length overflow.
3357 * insdel.c (count_size_as_multibyte): Check for string overflow.
3359 * character.c (lisp_string_width): Check for string overflow.
3360 Use EMACS_INT, not int, for string indexes and lengths; in
3361 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3362 the resulting string length overflows an EMACS_INT; instead,
3363 report a string overflow if no precision given. When checking for
3364 precision exhaustion, use a check that cannot possibly have
3365 integer overflow. (Bug#8675)
3366 * character.h (lisp_string_width): Adjust to new signature.
3368 * alloc.c (string_overflow): New function.
3369 (Fmake_string): Use it. This doesn't change behavior, but saves
3370 a few bytes and will simplify future changes.
3371 * character.c (string_escape_byte8): Likewise.
3372 * lisp.h (string_overflow): New decl.
3374 Fixups, following up to the user-interface timestamp change.
3375 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3376 for UI timestamps, instead of unsigned long.
3377 * msdos.c (mouse_get_pos): Likewise.
3378 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3379 * w32gui.h (Time): Define by including "systime.h" rather than by
3380 declaring it ourselves. (Bug#8664)
3382 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3383 * image.c (clear_image_cache): Likewise.
3385 * term.c (term_mouse_position): Don't assume time_t wraparound.
3387 Be more systematic about user-interface timestamps.
3388 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3389 and sometimes 'EMACS_UINT', to represent these timestamps.
3390 This change causes it to use 'Time' uniformly, as that's what X uses.
3391 This makes the code easier to follow, and makes it easier to catch
3392 integer overflow bugs such as Bug#8664.
3393 * frame.c (Fmouse_position, Fmouse_pixel_position):
3394 Use Time, not unsigned long, for user-interface timestamps.
3395 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3396 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3397 * keyboard.h (last_event_timestamp): Likewise.
3398 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3399 * menu.h (xmenu_show): Likewise.
3400 * term.c (term_mouse_position): Likewise.
3401 * termhooks.h (struct input_event.timestamp): Likewise.
3402 (struct terminal.mouse_position_hook): Likewise.
3403 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3404 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3405 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3406 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3408 * menu.h, termhooks.h: Include "systime.h", for Time.
3410 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3411 Don't assume that the difference between two unsigned long values
3412 can fit into an integer. At this point, we know button_down_time
3413 <= event->timestamp, so the difference must be nonnegative, so
3414 there's no need to cast the result if double-click-time is
3415 nonnegative, as it should be; check that it's nonnegative, just in
3416 case. This bug is triggered when events are more than 2**31 ms
3417 apart (about 25 days). (Bug#8664)
3419 * xselect.c (last_event_timestamp): Remove duplicate decl.
3420 (x_own_selection): Remove needless cast to unsigned long.
3422 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3423 that always fit in int. Use a sentinel instead of a counter, to
3424 avoid a temp and to allay GCC's concerns about possible int overflow.
3425 * frame.h (struct frame): Use int for menu_bar_items_used
3426 instead of EMACS_INT, since it always fits in int.
3428 * menu.c (grow_menu_items): Check for int overflow.
3430 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3432 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3433 Before, the code was not consistent. These values cannot exceed
3434 2**31 - 1 so there's no need to make them unsigned.
3435 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3436 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3437 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3439 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3441 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3442 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3443 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3444 presumably because the widths might not match.
3446 * window.c (size_window): Avoid needless test at loop start.
3448 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3450 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3452 2011-05-12 Drew Adams <drew.adams@oracle.com>
3454 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3456 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3458 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3459 `width' to `bar_area_x' and `bar_area_width', respectively.
3460 (x_scroll_run): Take account of fringe background extension.
3462 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3463 Rename local vars `left' and `width' to `bar_area_x' and
3464 `bar_area_width', respectively.
3465 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3466 background extension.
3468 2011-05-10 Jim Meyering <meyering@redhat.com>
3470 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3472 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3474 * image.c (Finit_image_library): Return t for built-in image types,
3475 like pbm and xbm. (Bug#8640)
3477 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3479 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3481 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3483 * w32console.c (Fset_screen_color): Doc fix.
3484 (Fget_screen_color): New function.
3485 (syms_of_ntterm): Defsubr it.
3487 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3488 unlink the temporary file if Fcall_process didn't create it in the
3490 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3491 child process will be redirected to a file specified with `:file'.
3492 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3493 cue to call_process_cleanup not to close that handle.
3495 2011-05-07 Ben Key <bkey76@gmail.com>
3497 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3498 one of two shell specific rules, either bootstrap-temacs-CMD or
3499 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3500 to the previous implementation of the bootstrap-temacs rule.
3501 The bootstrap-temacs-CMD rule is similar to the previous
3502 implementation of the bootstrap-temacs rule except that it
3503 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3506 These changes, along with some changes to nt/configure.bat,
3507 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3508 earlier fix to add support for --cflags and --ldflags options
3509 that include quotes so that it works whether make uses cmd or
3512 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3514 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3515 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3517 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3518 a string. Handle both cases.
3519 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3520 (Fdbus_register_method): Use Qinvalid_function.
3522 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3524 * makefile.w32-in: Update dependencies.
3525 (LISP_H): Add inttypes.h and stdin.h.
3526 (PROCESS_H): Add unistd.h.
3528 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3530 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3531 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3533 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3535 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3537 * term.c (vfatal): Remove stray call to va_end.
3538 It's not needed and the C Standard doesn't allow it here anyway.
3540 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3541 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3543 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3546 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3548 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3550 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3552 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3554 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3556 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3557 * charset.c (Fdefine_charset_internal): Don't initialize
3558 charset.code_space[15]. The value was garbage, on hosts with
3559 32-bit int (Bug#8600).
3561 * lread.c (read_integer): Be more consistent with string-to-number.
3562 Use string_to_number to do the actual conversion; this avoids
3563 rounding errors and fixes some other screwups. Without this fix,
3564 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3565 (digit_to_number): Move earlier, for benefit of read_integer.
3566 Return -1 if the digit is out of range for the base, -2 if it is
3567 not a digit in any supported base. (Bug#8602)
3569 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3571 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3572 to match comment at start of function. This also removes a
3573 GCC warning about overflow in a 32+64-bit port.
3575 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3577 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3578 Reported by Stefan Monnier in
3579 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3580 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3581 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3583 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3584 (EMACS_UINTPTR): Likewise, with uintptr_t.
3586 * lisp.h: Prefer 64-bit EMACS_INT if available.
3587 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3588 on 32-bit hosts that have 64-bit int, so that they can access
3590 However, temporarily disable this change unless the temporary
3591 symbol WIDE_EMACS_INT is defined.
3593 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3595 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3596 This removes an assumption that EMACS_INT and long are the same
3597 width as pointers. The assumption is true for Emacs porting targets
3598 now, but we want to make other targets possible.
3599 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3600 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3601 In the rest of the code, change types of integers that hold casted
3602 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3603 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3604 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3605 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3606 No need to cast type when ORing.
3607 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3608 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3609 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3610 assume EMACS_INT is the same width as char *.
3611 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3612 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3613 Remove no-longer-needed casts.
3614 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3615 (xg_tool_bar_help_callback, xg_make_tool_item):
3616 Use EMACS_INTPTR to hold an integer
3617 that will be cast to void *; this can avoid a GCC warning
3618 if EMACS_INT is not the same width as void *.
3619 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3620 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3621 (current_message_1, set_message_1):
3622 Use a local to convert to proper width without a cast.
3623 * xmenu.c (dialog_selection_callback): Likewise.
3625 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3626 Also, don't assume VALBITS / RAND_BITS is less than 5,
3627 and don't rely on undefined behavior when shifting a 1 left into
3629 * lisp.h (get_random): Change signature to match.
3631 * lread.c (hash_string): Use size_t, not int, for hash computation.
3632 Normally we prefer signed values; but hashing is special, because
3633 it's better to use unsigned division on hash table sizes so that
3634 the remainder is nonnegative. Also, size_t is the natural width
3635 for hashing into memory. The previous code used 'int', which doesn't
3636 retain enough info to hash well into very large tables.
3637 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3639 * dbusbind.c: Don't possibly lose pointer info when converting.
3640 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3641 Use XPNTR rather than XHASH, so that the high-order bits of
3642 the pointer aren't lost when converting through void *.
3644 * eval.c (Fautoload): Don't double-shift a pointer.
3646 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3648 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3650 * gnutls.c (DEF_GNUTLS_FN):
3651 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3653 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3655 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3658 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3660 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3661 New version that can reserve upto 2GB of heap space.
3663 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3665 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3667 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3669 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3670 `gnutls_certificate_set_x509_key_file'.
3672 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3674 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3675 Update dependencies.
3677 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3679 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3680 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3681 Remove unused parameter `fildes'.
3682 * process.c (read_process_output, send_process): Don't pass it.
3684 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3686 Fix previous change: the library cache is defined in w32.c.
3687 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3688 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3690 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3692 Implement dynamic loading of GnuTLS on Windows.
3694 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3695 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3696 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3699 * gnutls.c (Qgnutls_dll): Define.
3700 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3701 (gnutls_*): Declare function pointers.
3702 (init_gnutls_functions): New function to initialize function pointers.
3703 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3704 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3705 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3706 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3707 (emacs_gnutls_write, emacs_gnutls_read)
3708 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3709 (Fgnutls_available_p): New function.
3710 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3711 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3712 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3714 * image.c: Include w32.h.
3715 (Vimage_type_cache): Delete.
3716 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3717 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3718 (w32_delayed_load): Move to w32.c.
3720 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3722 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3723 (w32_delayed_load): Move from image.c. When loading a library, record
3724 its filename in the :loaded-from property of the library id.
3725 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3726 Initialize and staticpro them.
3727 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3729 * process.c: Include lisp.h before w32.h, not after.
3730 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3731 instead of gnutls_record_check_pending.
3733 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3735 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3737 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3738 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3741 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3743 * xterm.c (x_set_frame_alpha): Do not set property on anything
3744 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3746 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3748 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3750 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3752 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3753 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3754 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3755 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3756 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3757 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3758 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3759 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3760 (Qgnutls_bootprop_callbacks_verify): Make static.
3762 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3764 * callproc.c: Indentation fixup.
3766 * sysdep.c (wait_for_termination_1): Make static.
3767 (wait_for_termination, interruptible_wait_for_termination):
3768 Move after wait_for_termination_1.
3770 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3772 * sysdep.c (interruptible_wait_for_termination): New function
3773 which is like wait_for_termination, but allows keyboard
3776 * callproc.c (Fcall_process): Add (:file "file") as an option for
3778 (Fcall_process_region): Ditto.
3780 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3782 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3783 rather than `XVECTOR (FOO)->size'.
3785 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3786 inttypes.h, as a gnulib replacement is used if it not available in
3789 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3791 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3792 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3793 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3795 * coding.c (coding_alloc_by_realloc): Error out if destination
3796 will grow beyond MOST_POSITIVE_FIXNUM.
3797 (decode_coding_emacs_mule): Abort if there isn't enough place in
3798 charbuf for the composition carryover bytes. Reserve an extra
3799 space for up to 2 characters produced in a loop.
3800 (decode_coding_iso_2022): Abort if there isn't enough place in
3801 charbuf for the composition carryover bytes.
3803 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3805 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3806 aborting when %lld or %lll format is passed.
3807 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3808 %llo or %llx format is passed. (Bug#8545)
3810 * window.c (window_scroll_line_based): Use a marker instead of
3811 simple variables to record original value of point. (Bug#7952)
3813 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3814 produced by %s or %c overflows available buffer space. (Bug#8545)
3816 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3818 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3819 (SIZE_MAX): Move defn after all includes, as they might #define it.
3821 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3823 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3825 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3827 * keyboard.c (Qdelayed_warnings_hook): Define.
3828 (command_loop_1): Run `delayed-warnings-hook'
3829 if Vdelayed_warnings_list is non-nil.
3830 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3831 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3833 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3835 * doprnt.c (doprnt): Don't return value smaller than the buffer
3836 size if the message was truncated. (Bug#8545).
3838 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3840 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3841 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3843 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3845 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3847 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3849 * makefile.w32-in: Update dependencies.
3851 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3853 Improve `doprnt' and its usage. (Bug#8545)
3854 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3855 `format_end'. Remove support for %l as a conversion specifier.
3856 Don't use xrealloc. Improve diagnostics when the %l size modifier
3857 is used. Update the commentary.
3859 * eval.c (verror): Simplify calculation of size_t.
3861 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3864 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3866 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3869 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3871 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3872 This makes this file independent of the recent pseudovector change.
3874 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3876 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3878 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3879 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3880 Remove unused local.
3881 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3883 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3884 GCC 4.6.0 optimizes based on type-based alias analysis.
3885 For example, if b is of type struct buffer * and v of type struct
3886 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3887 != &v->size, and therefore "v->size = 1; b->size = 2; return
3888 v->size;" must therefore return 1. This assumption is incorrect
3889 for Emacs, since it type-puns struct Lisp_Vector * with many other
3890 types. To fix this problem, this patch adds a new type struct
3891 vectorlike_header that documents the constraints on layout of vectors
3892 and pseudovectors, and helps optimizing compilers not get fooled
3893 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3894 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3895 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3897 (XSETPVECTYPE): Rewrite in terms of new macro.
3898 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3899 This is a bit clearer, and further avoids the possibility of
3900 undesirable aliasing.
3901 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3902 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3903 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3904 since Lisp_Subr is a special case (no "next" field).
3905 (ASIZE): Now uses header.size rather than size.
3906 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3907 to avoid the hassle of writing XVECTOR (foo)->header.size.
3908 (struct vectorlike_header): New type.
3909 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3910 object, to help avoid aliasing.
3911 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3912 (SUBRP): Likewise, since Lisp_Subr is a special case.
3913 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3914 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3915 (struct Lisp_Hash_Table): Combine first two members into a single
3916 struct vectorlike_header member. All uses of "size" and "next" members
3917 changed to be "header.size" and "header.next".
3918 * buffer.h (struct buffer): Likewise.
3919 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3920 * frame.h (struct frame): Likewise.
3921 * process.h (struct Lisp_Process): Likewise.
3922 * termhooks.h (struct terminal): Likewise.
3923 * window.c (struct save_window_data, struct saved_window): Likewise.
3924 * window.h (struct window): Likewise.
3925 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3926 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3927 * buffer.c (init_buffer_once): Likewise.
3928 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3930 * process.c (Fformat_network_address): Use local var for size,
3933 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3935 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3936 * data.c (atof): Remove decl; no longer used or needed.
3937 (digit_to_number): Move to lread.c.
3938 (Fstring_to_number): Use new string_to_number function, to be
3939 consistent with how the Lisp reader treats infinities and NaNs.
3940 Do not assume that floating-point numbers represent EMACS_INT
3941 without losing information; this is not true on most 64-bit hosts.
3942 Avoid double-rounding errors, by insisting on integers when
3943 parsing non-base-10 numbers, as the documentation specifies.
3944 * lisp.h (string_to_number): New decl, replacing ...
3945 (isfloat_string): Remove.
3946 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3947 (read1): Do not accept +. and -. as integers; this
3948 appears to have been a coding error. Similarly, do not accept
3949 strings like +-1e0 as floating point numbers. Do not report
3950 overflow for integer overflows unless the base is not 10 which
3951 means we have no simple and reliable way to continue.
3952 Break out the floating-point parsing into a new
3953 function string_to_number, so that Fstring_to_number parses
3954 floating point numbers consistently with the Lisp reader.
3955 (digit_to_number): Move here from data.c. Make it static inline.
3956 (E_CHAR, EXP_INT): Remove, replacing with ...
3957 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3958 (string_to_number): New function, replacing isfloat_string.
3959 This function checks for valid syntax and produces the resulting
3960 Lisp float number too. Rework it so that string-to-number
3961 no longer mishandles examples like "1.0e+". Use strtoumax,
3962 so that overflow for non-base-10 numbers is reported only when
3963 there's no portable and simple way to convert to floating point.
3965 * textprop.c (set_text_properties_1): Rewrite for clarity,
3966 and to avoid GCC warning about integer overflow.
3968 * intervals.h (struct interval): Use EMACS_INT for members
3969 where EMACS_UINT might cause problems. See
3970 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3971 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3972 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3974 (offset_intervals): Tell GCC not to worry about length overflow
3975 when negating a negative length.
3977 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3978 (overrun_check_free): Likewise.
3980 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3981 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3984 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3985 (gnutls_make_error): Rename local to avoid shadowing.
3986 (gnutls_emacs_global_deinit): ifdef out; not used.
3987 (Fgnutls_boot): Use const for pointer to readonly storage.
3988 Comment out unused local. Fix pointer signedness problems.
3990 * lread.c (openp): Don't stuff size_t into an 'int'.
3991 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3992 about possible signed overflow.
3994 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3995 (GDK_KEY_g): Don't define if already defined.
3996 (xg_prepare_tooltip): Avoid pointer signedness problem.
3997 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3999 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4000 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4002 * xfns.c (Fx_window_property): Simplify a bit,
4003 to make a bit faster and to avoid GCC 4.6.0 warning.
4004 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4006 * fns.c (internal_equal): Don't assume size_t fits in int.
4008 * alloc.c (compact_small_strings): Tighten assertion a little.
4010 Replace pEd with more-general pI, and fix some printf arg casts.
4011 * lisp.h (pI): New macro, generalizing old pEd macro to other
4012 conversion specifiers. For example, use "...%"pI"d..." rather
4013 than "...%"pEd"...".
4014 (pEd): Remove. All uses replaced with similar uses of pI.
4015 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4016 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4017 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4018 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4019 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4020 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4021 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4023 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4024 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4025 * print.c (safe_debug_print, print_object): Likewise.
4026 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4028 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4029 avoiding the 0 flag, which is not portable.
4030 * process.c (Fmake_network_process): Use pI to avoid cast.
4031 * region-cache.c (pp_cache): Likewise.
4032 * xdisp.c (decode_mode_spec): Likewise.
4033 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4034 behavior on 64-bit hosts with printf arg.
4035 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4036 (x_stop_queuing_selection_requests): Likewise.
4037 (x_get_window_property): Don't truncate byte count to an 'int'
4040 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4041 here, since it parses constructs like leading '-' and spaces,
4042 which are not wanted; and it overflows with large numbers.
4043 Instead, simply match F[0-9]+, which is what is wanted anyway.
4045 * alloc.c: Remove unportable assumptions about struct layout.
4046 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4047 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4048 (allocate_vectorlike, make_pure_vector): Use the new macros,
4049 plus offsetof, to remove unportable assumptions about struct layout.
4050 These assumptions hold on all porting targets that I know of, but
4051 they are not guaranteed, they're easy to remove, and removing them
4052 makes further changes easier.
4054 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4055 This doesn't fix a bug but makes the code clearer.
4056 (string_overrun_cookie): Now const. Use initializers that
4057 don't formally overflow signed char, to avoid warnings.
4058 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4059 can cause Emacs to crash when string overrun checking is enabled.
4060 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4061 multiple of sizeof (EMACS_INT); it need not be, if
4062 alignof(EMACS_INT) < sizeof (EMACS_INT).
4063 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4065 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4067 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4069 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4071 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4072 supposed to be handshaking. (Bug#8556)
4073 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4075 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4077 * lisp.h (Qdebug): List symbol.
4078 * eval.c (Qdebug): Restore global linkage.
4079 * keyboard.c (debug-on-event): New variable.
4080 (handle_user_signal): Break into debugger when debug-on-event
4081 matches the current signal symbol.
4083 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4085 * alloc.c (check_sblock, check_string_bytes)
4086 (check_string_free_list): Convert to standard C.
4088 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4090 * w32.c (emacs_gnutls_push): Fix typo.
4092 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4094 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4095 "cast to pointer from integer of different size".
4097 Improve doprnt and its use in verror. (Bug#8545)
4098 * doprnt.c (doprnt): Document the set of format control sequences
4099 supported by the function. Use SAFE_ALLOCA instead of always
4102 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4103 is one byte too soon. Don't use xrealloc; instead xfree and
4106 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4108 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4111 * gnutls.c: Renamed global_initialized to
4112 gnutls_global_initialized. Added internals for the
4113 :verify-hostname-error, :verify-error, and :verify-flags
4114 parameters of `gnutls-boot' and documented those parameters in the
4115 docstring. Start callback support.
4116 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4117 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4118 on error. Return error code.
4119 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4120 (emacs_gnutls_read): Likewise.
4121 (Fgnutls_boot): Return handshake error code.
4122 (emacs_gnutls_handle_error): New function.
4123 (wsaerror_to_errno): Likewise.
4125 * w32.h (emacs_gnutls_pull): Add prototype.
4126 (emacs_gnutls_push): Likewise.
4128 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4129 (emacs_gnutls_push): Likewise.
4131 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4133 * process.c (wait_reading_process_output): Check if GnuTLS
4134 buffered some data internally if no FDs are set for TLS
4137 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4138 (LIBS): Link to USER_LIBS.
4139 ($(BLD)/gnutls.$(0)): New target.
4141 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4143 * xdisp.c (handle_single_display_spec): Rename the
4144 display_replaced_before_p argument into display_replaced_p, to
4145 make it consistent with the commentary. Fix typos in the
4148 * textprop.c (syms_of_textprop): Remove dead code.
4149 (copy_text_properties): Delete obsolete commentary about an
4150 interface that was deleted long ago. Fix typos in the description
4153 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4154 to changes in oldXMenu/XMenu.h from 2011-04-16.
4155 <menu_help_message, prev_menu_help_message>: Constify.
4156 (IT_menu_make_room): menu->help_text is now `const char **';
4159 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4160 to changes in oldXMenu/XMenu.h from 2011-04-16.
4161 (struct XMenu): Declare `help_text' `const char **'.
4163 * xfaces.c <Qunspecified>: Make extern again.
4165 * syntax.c: Include sys/types.h before including regex.h, as
4168 * doc.c (get_doc_string): Improve the format passed to `error'.
4170 * doprnt.c (doprnt): Improve commentary.
4172 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4174 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4177 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4178 changes in globals.h immediately force recompilation.
4179 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4180 $(CURDIR)/s/ms-w32.h.
4181 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4183 * character.c (Fchar_direction): Function deleted.
4184 (syms_of_character): Don't defsubr it.
4185 <char-direction-table>: Deleted.
4187 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4189 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4190 * doprnt.c: Include limits.h.
4191 (SIZE_MAX): New macro.
4192 (doprnt): Return a size_t value. 2nd arg is now size_t.
4193 Many local variables are now size_t instead of int or unsigned.
4194 Improve overflow protection. Support `l' modifier for integer
4195 conversions. Support %l conversion. Don't assume an EMACS_INT
4196 argument for integer conversions and for %c.
4198 * lisp.h (doprnt): Restore prototype.
4200 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4203 * Makefile.in (base_obj): Add back doprnt.o.
4205 * deps.mk (doprnt.o): Add back prerequisites.
4206 (callint.o): Depend on character.h.
4208 * eval.c (internal_lisp_condition_case): Include the handler
4209 representation in the error message.
4210 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4211 when breaking from the loop.
4213 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4215 * callint.c (Fcall_interactively): When displaying error message
4216 about invalid control letter, pass the character's codepoint, not
4217 a pointer to its multibyte form. Improve display of the character
4218 in octal and display also its hex code.
4220 * character.c (char_string): Use %x to display the (unsigned)
4221 codepoint of an invalid character, to avoid displaying a bogus
4224 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4225 `error', not SYMBOL_NAME itself.
4227 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4228 character arguments to `error'.
4230 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4231 to `error' in error message about FINAL_CHAR argument. Make sure
4232 FINAL_CHAR is a character, and use %c when it is passed as
4233 argument to `error'.
4235 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4237 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4239 * w32.c: Include <time.h>.
4240 (sys_localtime): New function.
4242 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4244 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4246 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4248 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4250 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4253 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4255 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4256 gl_state.e_property when gl_state.object is Qt.
4258 * insdel.c (make_gap_larger): Remove limitation of buffer size
4261 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4263 * xdisp.c (lookup_glyphless_char_display)
4264 (produce_glyphless_glyph): Handle cons cell entry in
4265 glyphless-char-display.
4266 (Vglyphless_char_display): Document it.
4268 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4269 glyphless-char-display.
4271 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4273 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4275 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4277 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4278 definition for no-X builds.
4280 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4282 Static checks with GCC 4.6.0 and non-default toolkits.
4284 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4286 * process.c (keyboard_bit_set): Define only if SIGIO.
4287 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4288 (send_process): Repair possible setjmp clobbering.
4290 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4292 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4294 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4296 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4297 Define only if needed.
4299 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4300 by pacifying GCC about it. Maybe it's time to retire it?
4301 * xfaces.c (USG, __TIMEVAL__): Likewise.
4303 * dispextern.h (struct redisplay_interface): Rename param
4305 * termhooks.h (struct terminal): Likewise.
4306 * xterm.c (xembed_send_message): Likewise.
4308 * insdel.c (make_gap_smaller): Define only if
4309 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4311 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4314 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4315 so that we aren't warned about unused symbols.
4317 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4319 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4321 * xfns.c (x_real_positions): Mark locals as initialized.
4323 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4325 * xterm.c: Fix problems found by static analysis with other toolkits.
4326 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4327 (x_dispatch_event): Declare static if USE_GTK, and
4328 define if USE_GTK || USE_X_TOOLKIT.
4329 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4330 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4331 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4332 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4334 * xmenu.c (menu_help_callback): Pointer type fixes.
4335 Use const pointers when pointing at readonly data. Avoid pointer
4337 (FALSE): Remove unused macro.
4338 (update_frame_menubar): Remove unused decl.
4340 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4342 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4343 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4344 (single_menu_item): Rename local to avoid shadowing.
4346 * keyboard.c (make_lispy_event): Remove unused local var.
4348 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4349 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4351 * bitmaps: Change bitmaps from unsigned char back to the X11
4352 compatible char. Avoid the old compiler warnings about
4353 out-of-range initializers by using, for example, '\xab' rather
4356 * xgselect.c (xgselect_initialize): Check vs interface
4357 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4359 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4361 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4362 to read-only memory.
4364 * fns.c (vector): Remove; this old hack is no longer needed.
4366 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4368 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4370 * xrdb.c (x_load_resources): Omit unused local.
4372 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4373 (x_window): Rename locals to avoid shadowing.
4374 (USG): Use the kludged USG macro, to pacify gcc.
4376 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4377 (x_term_init): Remove local to avoid shadowing.
4379 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4381 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4382 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4384 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4386 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4388 Fix regex.c, syntax.c and friends for buffers > 2GB.
4389 * syntax.h (struct gl_state_s): Declare character position members
4392 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4394 * textprop.c (verify_interval_modification, interval_of):
4395 Declare arguments EMACS_INT.
4397 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4400 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4402 * indent.c (Fvertical_motion): Local variable it_start is now
4405 * regex.c (re_match, re_match_2, re_match_2_internal)
4406 (bcmp_translate, regcomp, regexec, print_double_string)
4407 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4408 (re_compile_pattern, re_exec): Declare arguments and local
4409 variables `size_t' and `ssize_t' and return values `regoff_t', as
4411 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4412 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4413 <compile_stack_type>: `size' and `avail' are now `size_t'.
4415 * regex.h <regoff_t>: Use ssize_t, not int.
4416 (re_search, re_search_2, re_match, re_match_2): Arguments that
4417 specify buffer/string position and length are now ssize_t and
4418 size_t. Return type is regoff_t.
4420 2011-04-16 Ben Key <bkey76@gmail.com>
4422 * nsfont.m: Fixed bugs in ns_get_family and
4423 ns_descriptor_to_entity that were caused by using free to
4424 deallocate memory blocks that were allocated by xmalloc (via
4425 xstrdup). This caused Emacs to crash when compiled with
4426 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4427 --enable-checking=xmallocoverrun). xfree is now used to
4428 deallocate these memory blocks.
4430 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4432 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4434 emacs_write: Accept and return EMACS_INT for sizes.
4435 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4437 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4438 Accept and return EMACS_INT.
4439 (emacs_gnutls_write): Return the number of bytes written on
4441 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4442 (emacs_read, emacs_write): Remove check for negative size, as the
4443 Emacs source code has been audited now.
4444 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4445 (emacs_read, emacs_write): Use it.
4446 * process.c (send_process): Adjust to the new signatures of
4447 emacs_write and emacs_gnutls_write. Do not attempt to store
4448 a byte offset into an 'int'; it might overflow.
4449 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4451 * sound.c: Don't assume sizes fit in 'int'.
4452 (struct sound_device.period_size, alsa_period_size):
4453 Return EMACS_INT, not int.
4454 (struct sound_device.write, vox_write, alsa_write):
4455 Accept EMACS_INT, not int.
4456 (wav_play, au_play): Use EMACS_INT to store sizes and to
4457 record read return values.
4459 2011-04-15 Ben Key <bkey76@gmail.com>
4461 * keyboard.c (Qundefined): Don't declare static since it is used
4463 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4464 static since they are used in nsfont.m.
4466 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4468 * process.c (Qprocessp): Don't declare static.
4469 * lisp.h (Qprocessp): Declare again.
4471 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4473 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4475 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4477 Improve C-level modularity by making more things 'static'.
4479 Don't publish debugger-only interfaces to other modules.
4480 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4481 (verify_bytepos, count_markers): Move decls to the only modules
4483 * region-cache.h (pp_cache): Likewise.
4484 * window.h (check_all_windows): Likewise.
4485 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4487 * sysdep.c (croak): Now static, if
4488 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4489 * syssignal.h (croak): Declare only if not static.
4491 * alloc.c (refill_memory_reserve): Now static if
4492 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4493 * lisp.h (refill_memory_reserve): Declare only if not static.
4495 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4496 Define only if USE_LUCID.
4498 * xrdb.c (x_customization_string, x_rm_string): Now static.
4500 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4501 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4503 * xdisp.c (draw_row_with_mouse_face): Now static.
4504 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4506 * window.h (check_all_windows): Mark externally visible.
4508 * window.c (window_deletion_count): Now static.
4510 * undo.c: Make symbols static if they're not exported.
4511 (last_undo_buffer, last_boundary_position, pending_boundary):
4514 * textprop.c (interval_insert_behind_hooks): Now static.
4515 (interval_insert_in_front_hooks): Likewise.
4517 * term.c: Make symbols static if they're not exported.
4518 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4519 (max_frame_lines, tty_set_terminal_modes):
4520 (tty_reset_terminal_modes, tty_turn_off_highlight):
4521 (get_tty_terminal): Now static.
4522 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4523 * termhooks.h (term_mouse_moveto): Do not declare if
4525 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4526 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4528 * sysdep.c: Make symbols static if they're not exported.
4529 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4531 (sigprocmask_set, full_mask): Remove; unused.
4532 (wait_debugging): Mark as visible.
4533 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4534 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4536 * syntax.c (syntax_temp): Define only if !__GNUC__.
4538 * sound.c (current_sound_device, current_sound): Now static.
4540 * search.c (searchbufs, searchbuf_head): Now static.
4542 * scroll.c (scroll_cost): Remove; unused.
4543 * dispextern.h (scroll_cost): Remove decl.
4545 * region-cache.h (pp_cache): Mark as externally visible.
4547 * process.c: Make symbols static if they're not exported.
4548 (process_tick, update_tick, create_process, chan_process):
4549 (Vprocess_alist, proc_buffered_char, datagram_access):
4550 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4551 (deactivate_process): Mark defn as static, as well as decl.
4552 * lisp.h (create_process): Remove decl.
4553 * process.h (chan_process, Vprocess_alist): Remove decls.
4555 * print.c: Make symbols static if they're not exported.
4556 (print_depth, new_backquote_output, being_printed, print_buffer):
4557 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4558 (print_interval, print_number_index, initial_stderr_stream):
4560 * lisp.h (Fprinc): Remove decl.
4561 (debug_output_compilation_hack): Mark as externally visible.
4563 * sysdep.c (croak): Move decl from here to syssignal.h.
4564 * syssignal.h (croak): Put it here, so the API can be checked when
4565 'croak' is called from dissociate_if_controlling_tty.
4567 * minibuf.c: Make symbols static if they're not exported.
4568 (minibuf_save_list, choose_minibuf_frame): Now static.
4569 * lisp.h (choose_minibuf_frame): Remove decl.
4571 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4573 * lread.c: Make symbols static if they're not exported.
4574 (read_objects, initial_obarray, oblookup_last_bucket_number):
4576 (make_symbol): Remove; unused.
4577 * lisp.h (initial_obarray, make_symbol): Remove decls.
4579 * keyboard.c: Make symbols static if they're not exported.
4580 (single_kboard, recent_keys_index, total_keys, recent_keys):
4581 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4582 (this_single_command_key_start, echoing, last_auto_save):
4583 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4584 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4585 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4586 (Vlispy_mouse_stem, double_click_count):
4588 (force_auto_save_soon): Define only if SIGDANGER.
4589 (ignore_mouse_drag_p): Now static if
4590 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4591 (print_help): Remove; unused.
4592 (stop_character, last_timer_event): Mark as externally visible.
4593 * keyboard.h (ignore_mouse_drag_p): Declare only if
4594 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4595 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4596 * lisp.h (echoing): Remove decl.
4597 (force_auto_save_soon): Declare only if SIGDANGER.
4598 * xdisp.c (redisplay_window): Simplify code, to make it more
4599 obvious that ignore_mouse_drag_p is not accessed if !defined
4600 USE_GTK && !defined HAVE_NS.
4602 * intervals.c: Make symbols static if they're not exported.
4603 (merge_properties_sticky, merge_interval_right, delete_interval):
4605 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4607 * insdel.c: Make symbols static if they're not exported.
4608 However, leave prepare_to_modify_buffer alone. It's never
4609 called from outside this function, but that appears to be a bug.
4610 (combine_after_change_list, combine_after_change_buffer):
4611 (adjust_after_replace, signal_before_change): Now static.
4612 (adjust_after_replace_noundo): Remove; unused.
4613 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4614 (signal_before_change): Remove decls.
4616 * indent.c (val_compute_motion, val_vmotion): Now static.
4618 * image.c: Make symbols static if they're not exported.
4619 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4621 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4622 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4624 * fringe.c (standard_bitmaps): Now static.
4625 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4627 * frame.c: Make symbols static if they're not exported.
4628 (x_report_frame_params, make_terminal_frame): Now static.
4629 (get_frame_param): Now static, unless HAVE_NS.
4630 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4631 (x_get_resource_string): Remove; not used.
4632 * frame.h (make_terminal_frame, x_report_frame_params):
4633 (x_get_resource_string); Remove decls.
4634 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4635 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4637 * font.c, fontset.c: Make symbols static if they're not exported.
4638 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4639 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4640 * font.c (font_close_object): Now static.
4641 * font.h (font_close_object): Remove.
4642 * fontset.c (FONTSET_OBJLIST): Remove.
4643 (free_realized_fontset) #if-0 the body, which does nothing.
4644 (face_suitable_for_char_p): #if-0, as it's never called.
4645 * fontset.h (face_suitable_for_char_p): Remove decl.
4646 * xfaces.c (face_at_string_position):
4647 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4648 since 0 is always ASCII.
4650 * fns.c (weak_hash_tables): Now static.
4652 * fileio.c: Make symbols static if they're not exported.
4653 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4654 (Vwrite_region_annotation_buffers): Now static.
4656 * eval.c: Make symbols static if they're not exported.
4657 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4658 * lisp.h (backtrace_list): Remove decl.
4660 * emacs.c: Make symbols static if they're not exported.
4661 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4662 (fatal_error_code, fatal_error_signal_hook, standard_args):
4664 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4665 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4666 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4667 * lisp.h (fatal_error_signal_hook): Remove decl.
4668 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4670 * editfns.c: Move a (normally-unused) function to its only use.
4671 * editfns.c, lisp.h (get_operating_system_release): Remove.
4672 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4673 worth the hassle of breaking this out.
4675 * xterm.c: Make symbols static if they're not exported.
4676 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4677 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4678 (x_destroy_window, x_delete_display):
4680 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4681 (x_mouse_leave): Remove; unused.
4682 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4683 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4684 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4686 (x_mouse_leave): Declare only if WINDOWSNT.
4687 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4688 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4691 * ftxfont.c: Make symbols static if they're not exported.
4692 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4694 * font.h (ftxfont_driver): Likewise.
4696 * xfns.c: Make symbols static if they're not exported.
4697 (x_last_font_name, x_display_info_for_name):
4698 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4699 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4700 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4701 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4702 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4703 (last_show_tip_args): Now static.
4704 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4705 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4706 (x_screen_planes): Remove; unused.
4707 * dispextern.h (x_screen_planes): Remove decl.
4709 * dispnew.c: Make symbols static if they're not exported.
4710 * dispextern.h (redraw_garbaged_frames, scrolling):
4711 (increment_row_positions): Remove.
4712 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4713 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4715 (redraw_garbaged_frames): Remove; unused.
4717 * xfaces.c: Make symbols static if they're not exported.
4718 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4720 * xterm.h (defined_color): Remove decls.
4721 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4722 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4723 (menu_face_changed_default, defined_color, free_realized_face):
4724 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4725 (ascii_face_of_lisp_face): Remove; unused.
4727 * xdisp.c: Make symbols static if they're not exported.
4728 * dispextern.h (scratch_glyph_row, window_box_edges):
4729 (glyph_to_pixel_coords, set_cursor_from_row):
4730 (get_next_display_element, set_iterator_to_next):
4731 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4732 (show_mouse_face): Remove decls
4733 * frame.h (message_buf_print): Likewise.
4734 * lisp.h (pop_message, set_message, check_point_in_composition):
4736 * xterm.h (set_vertical_scroll_bar): Likewise.
4737 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4738 (message_buf_print, scratch_glyph_row, displayed_buffer):
4739 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4740 (get_next_display_element, show_mouse_face, window_box_edges):
4741 (frame_to_window_pixel_xy, check_point_in_composition):
4742 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4743 (glyph_to_pixel_coords): Remove; unused.
4745 * dired.c (file_name_completion): Now static.
4747 * dbusbind.c (xd_in_read_queued_messages): Now static.
4749 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4750 * data.c (circular_list_error): Remove.
4752 * commands.h (last_point_position, last_point_position_buffer):
4753 (last_point_position_window): Remove decls.
4754 * keyboard.c: Make these variables static.
4756 * coding.h (coding, code_convert_region, encode_coding_gap):
4758 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4759 (iso_code_class, detect_coding, code_convert_region): Now static.
4760 (encode_coding_gap): Remove; unused.
4762 * chartab.c (chartab_chars, chartab_bits): Now static.
4764 * charset.h (charset_iso_8859_1): Remove decl.
4765 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4768 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4769 * ccl.c (Vccl_program_table): Now static.
4770 (check_ccl_update): Remove; unused.
4772 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4773 * category.h: ... from here.
4774 * category.c (check_category_table, set_category_set): Now static.
4776 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4777 * lisp.h: Remove these decls.
4779 * buffer.c (buffer_count): Remove unused var.
4781 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4782 so that it's not optimized away.
4783 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4784 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4785 exported only to the debugger.
4787 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4788 * atimer.h (run_all_atimers): Remove; not exported.
4790 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4791 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4792 was inaccessible from Lisp.
4793 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4794 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4796 alloc.c: Import and export fewer symbols, and remove unused items.
4797 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4799 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4800 it's not optimized away by whole-program optimization.
4801 (message_enable_multibyte, free_misc): Remove.
4802 (catchlist, handlerlist, mark_backtrace):
4803 Declare only if BYTE_MARK_STACK.
4804 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4805 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4806 (message_enable_multibyte): Remove decl.
4807 (free_misc, interval_free_list, float_block, float_block_index):
4808 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4809 (cons_free_list, last_marked_index):
4811 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4812 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4813 (mark_backtrace): Define only if BYTE_MARK_STACK.
4814 * xdisp.c (message_enable_multibyte): Now static.
4816 Declare Lisp_Object Q* variables to be 'static' if not exported.
4817 This makes it easier for human readers (and static analyzers)
4818 to see whether these variables are used from other modules.
4819 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4820 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4821 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4822 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4823 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4824 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4825 * xmenu.c, xselect.c:
4826 Declare Q* vars static if they are not used in other modules.
4827 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4828 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4829 Remove decls of unexported vars.
4830 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4832 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4834 Make Emacs functions such as Fatom 'static' by default.
4835 This makes it easier for human readers (and static analyzers)
4836 to see whether these functions can be called from other modules.
4837 DEFUN now defines a static function. To make the function external
4838 so that it can be used in other C modules, use the new macro DEFUE.
4839 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4840 (Finit_image_library):
4841 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4842 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4843 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4844 Remove decls, since these functions are now static.
4845 (Funintern, Fget_internal_run_time): New decls, since these functions
4846 were already external.
4848 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4849 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4850 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4851 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4852 * keyboard.c, keymap.c, lread.c:
4853 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4854 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4855 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4856 Mark functions with DEFUE instead of DEFUN,
4857 if they are used in other modules.
4858 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4859 decls for now-static functions.
4860 * buffer.h (Fdelete_overlay): Remove decl.
4861 * callproc.c (Fgetenv_internal): Mark as internal.
4862 * composite.c (Fremove_list_of_text_properties): Remove decl.
4863 (Fcomposition_get_gstring): New forward static decl.
4864 * composite.h (Fcomposite_get_gstring): Remove decl.
4865 * dired.c (Ffile_attributes): New forward static decl.
4866 * doc.c (Fdocumntation_property): New forward static decl.
4867 * eval.c (Ffetch_bytecode): New forward static decl.
4868 (Funintern): Remove extern decl; now in .h file where it belongs.
4869 * fileio.c (Fmake_symbolic_link): New forward static decl.
4870 * image.c (Finit_image_library): New forward static decl.
4871 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4872 * intervals.h (Fprevious_property_change):
4873 (Fremove_list_of_text_properties): Remove decls.
4874 * keyboard.c (Fthis_command_keys): Remove decl.
4875 (Fcommand_execute): New forward static decl.
4876 * keymap.c (Flookup_key): New forward static decl.
4877 (Fcopy_keymap): Now static.
4878 * keymap.h (Flookup_key): Remove decl.
4879 * process.c (Fget_process): New forward static decl.
4880 (Fprocess_datagram_address): Mark as internal.
4881 * syntax.c (Fsyntax_table_p): New forward static decl.
4882 (skip_chars): Remove duplicate decl.
4883 * textprop.c (Fprevious_property_change): New forward static decl.
4884 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4886 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4887 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4889 * editfns.c (Fformat): Remove unreachable code.
4891 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4893 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4896 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4898 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4899 when at ZV. (Bug#8487)
4901 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4903 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4905 * keyboard.c (parse_tool_bar_item): Likewise.
4906 * sound.c (sound_cleanup, alsa_close): Likewise.
4907 * termcap.c (tgetent): Likewise.
4908 * xfns.c (x_default_font_parameter): Likewise.
4909 * xsettings.c (read_and_apply_settings): Likewise.
4911 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4912 (overrun_check_free): Protoize.
4914 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4916 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4917 since callers should never pass a negative size.
4918 Change the signature to match that of plain 'read' and 'write'; see
4919 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4920 * lisp.h: Update prototypes of emacs_write and emacs_read.
4922 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4924 * xdisp.c (redisplay_window): Don't try to determine the character
4925 position of the scroll margin if the window start point w->startp
4926 is outside the buffer's accessible region. (Bug#8468)
4928 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4930 Fix write-region and its subroutines for buffers > 2GB.
4931 * fileio.c (a_write, e_write): Modify declaration of arguments and
4932 local variables to support buffers larger than 2GB.
4933 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4935 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4936 argument, local variables, and return value.
4938 * lisp.h: Update prototypes of emacs_write and emacs_read.
4940 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4942 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4944 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4946 Fix more problems found by GCC 4.6.0's static checks.
4948 * xdisp.c (vmessage): Use a better test for character truncation.
4950 * charset.c (load_charset_map): <, not <=, for optimization,
4951 and to avoid potential problems with integer overflow.
4952 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4953 * casetab.c (set_identity, shuffle): Likewise.
4954 * editfns.c (Fformat): Likewise.
4955 * syntax.c (skip_chars): Likewise.
4957 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4958 This also lets GCC 4.6.0 generate slightly better loop code.
4960 * callint.c (Fcall_interactively): <, not <=, for optimization.
4961 (Fcall_interactively): Count the number of arguments produced,
4962 not the number of arguments given. This is simpler and lets GCC
4963 4.6.0 generate slightly better code.
4965 * ftfont.c: Distingish more carefully between FcChar8 and char.
4966 The previous code passed unsigned char * to a functions like
4967 strlen and xstrcasecmp that expect char *, which does not
4968 conform to the C standard.
4969 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4970 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4971 char * when the C standard requires it.
4973 * keyboard.c (read_char): Remove unused var.
4975 * eval.c: Port to Windows vsnprintf (Bug#8435).
4977 (SIZE_MAX): Define if the headers do not.
4978 (verror): Do not give up if vsnprintf returns a negative count.
4979 Instead, grow the buffer. This ports to Windows vsnprintf, which
4980 does not conform to C99. Problem reported by Eli Zaretskii.
4981 Also, simplify the allocation scheme, by avoiding the need for
4982 calling realloc, and removing the ALLOCATED variable.
4984 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4986 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4987 But keep the doprint source code for now, as we might revamp it
4988 and use it again (Bug#8435).
4989 * lisp.h (doprnt): Remove.
4990 * Makefile.in (base_obj): Remove doprnt.o.
4991 * deps.mk (doprnt.o): Remove.
4993 error: Print 32- and 64-bit integers portably (Bug#8435).
4994 Without this change, on typical 64-bit hosts error ("...%d...", N)
4995 was used to print both 32- and 64-bit integers N, which relied on
4997 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4999 * lisp.h (error, verror): Mark as printf-like functions.
5000 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5001 Report overflow in size calculations when allocating printf buffer.
5002 Do not truncate output string at its first null byte.
5003 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5004 Truncate the output at a character boundary, since vsnprintf does not
5006 * charset.c (check_iso_charset_parameter): Convert internal
5007 character to string before calling 'error', since %c now has the
5009 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5010 overflow when computing char to be passed to 'error'. Do not
5011 pass Lisp_Object to 'error'; pass the integer instead.
5012 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5013 formatted with plain %d.
5015 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5017 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5019 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5021 * xterm.c (x_catch_errors): Remove duplicate declaration.
5023 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5025 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5027 2011-04-10 Jim Meyering <meyering@redhat.com>
5029 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5030 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5031 return ssize_t not "int", and use size_t as the buffer length.
5032 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5033 * gnutls.h: Update declarations.
5034 * process.c (read_process_output): Use ssize_t, to match.
5035 (send_process): Likewise.
5037 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5039 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5041 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5043 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5044 Use unsigned char, to match FcChar8 type definition.
5046 * xterm.c (handle_one_xevent):
5047 * xmenu.c (create_and_show_popup_menu):
5048 * xselect.c (x_decline_selection_request)
5049 (x_reply_selection_request): Avoid type-punned deref of X events.
5051 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5053 Fix some uses of `int' instead of EMACS_INT.
5054 * search.c (string_match_1, fast_string_match)
5055 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5056 (scan_buffer, find_next_newline_no_quit)
5057 (find_before_next_newline, search_command, Freplace_match)
5058 (Fmatch_data): Make some `int' variables be EMACS_INT.
5060 * xdisp.c (display_count_lines): 3rd argument and return value now
5061 EMACS_INT. All callers changed.
5062 (pint2hrstr): Last argument is now EMACS_INT.
5064 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5065 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5066 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5067 (decode_coding_utf_16, decode_coding_emacs_mule)
5068 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5069 (decode_coding_ccl, decode_coding_charset)
5070 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5071 (decode_coding_iso_2022, decode_coding_emacs_mule)
5072 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5073 <char_offset, last_offset>: Declare EMACS_INT.
5074 (encode_coding_utf_8, encode_coding_utf_16)
5075 (encode_coding_emacs_mule, encode_invocation_designation)
5076 (encode_designation_at_bol, encode_coding_iso_2022)
5077 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5078 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5080 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5081 (encode_invocation_designation): Last argument P_NCHARS is now
5083 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5084 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5086 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5089 * ccl.c (Fccl_execute_on_string): Declare some variables
5092 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5094 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5096 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5098 * process.c (Fformat_network_address): Doc fix.
5100 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5102 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5104 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5106 * keyboard.c (read_char): Call Lisp function help-form-show,
5107 instead of using internal_with_output_to_temp_buffer.
5108 (Qhelp_form_show): New var.
5109 (syms_of_keyboard): Use DEFSYM macro.
5111 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5113 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5115 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5117 * process.c (Flist_processes): Remove to Lisp.
5118 (list_processes_1): Delete.
5120 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5122 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5124 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5126 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5128 Fix more problems found by GCC 4.6.0's static checks.
5130 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5132 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5134 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5136 * xdisp.c (vmessage): Mark as a printf-like function.
5138 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5140 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5142 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5143 printf-like functions.
5144 (tiff_load): Add casts to remove these marks before passing them
5145 to system-supplied API.
5147 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5149 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5150 This avoids several warnings with gcc -Wstrict-overflow.
5151 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5152 directly, rather than having caller test rule sign. This avoids
5153 some unnecessary tests.
5154 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5155 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5156 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5158 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5159 (xfont_open): Avoid unnecessary tests.
5161 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5163 * composite.h, composite.c (composition_gstring_put_cache):
5164 Use EMACS_INT, not int, for length.
5166 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5167 breaking out part of COMPOSITION_DECODE_RULE.
5168 (COMPOSITION_DECODE_RULE): Use it.
5169 * composite.c (get_composition_id): Remove unused local vars,
5170 by using the new macro.
5172 * textprop.c (set_text_properties_1): Change while to do-while,
5173 since the condition is always true at first.
5175 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5176 (interval_deletion_adjustment): Return unsigned value.
5179 * process.c (list_processes_1, create_pty, read_process_output):
5180 (exec_sentinel): Remove vars that were set but not used.
5181 (create_pty): Remove unnecessary "volatile"s.
5182 (Fnetwork_interface_info): Avoid possibility of int overflow.
5183 (read_process_output): Do adaptive read buffering even if carryover.
5184 (read_process_output): Simplify nbytes computation if buffered.
5186 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5188 * syntax.c (scan_words): Remove var that was set but not used.
5189 (update_syntax_table): Use unsigned instead of int.
5191 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5192 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5193 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5195 * print.c (print_error_message): Avoid int overflow.
5197 * font.c (font_list_entities): Redo for clarity,
5198 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5200 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5201 (font_score): Avoid potential overflow in diff calculation.
5203 * fns.c (substring_both): Remove var that is set but not used.
5204 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5206 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5208 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5209 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5210 can always succeed if overflow has undefined behavior.
5212 * search.c (boyer_moore, wordify): Remove vars set but not used.
5213 (wordify): Omit three unnecessary tests.
5215 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5216 All callers changed. This avoids the need for an unused var.
5218 * casefiddle.c (casify_region): Remove var that is set but not used.
5220 * dired.c (file_name_completion): Remove var that is set but not used.
5222 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5224 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5225 (Finsert_file_contents): Remove unnecessary code checking fd.
5227 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5228 Check for integer overflow on size calculations.
5230 * buffer.c (Fprevious_overlay_change): Remove var that is set
5233 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5234 Remove vars that are set but not used.
5235 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5236 (timer_check_2): Mark vars as initialized.
5238 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5240 * image.c (lookup_image): Remove var that is set but not used.
5241 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5243 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5244 that are set but not used.
5246 * xfns.c (make_invisible_cursor): Don't return garbage
5247 if XCreateBitmapFromData fails (Bug#8410).
5249 * xselect.c (x_get_local_selection, x_handle_property_notify):
5250 Remove vars that are set but not used.
5252 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5253 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5255 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5256 Remove var that is set but not used.
5257 (scroll_bar_windows_size): Now size_t, not int.
5258 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5261 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5262 (map_tty_color) [!defined MSDOS]: Likewise.
5264 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5266 * coding.c: Remove vars that are set but not used.
5267 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5268 All callers changed.
5269 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5270 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5271 (decode_coding_charset): Remove vars that are set but not used.
5273 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5274 that is set but not used.
5276 * print.c (print_object): Remove var that is set but not used.
5278 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5279 The gnulib version avoids calling malloc in the usual case,
5280 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5281 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5282 * filelock.c (current_lock_owner): Likewise.
5283 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5284 * sysdep.c: Include allocator.h, careadlinkat.h.
5285 (emacs_no_realloc_allocator): New static constant.
5286 (emacs_readlink): New function.
5287 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5288 ../lib/careadlinkat.h.
5290 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5292 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5293 first non-nil return value).
5295 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5297 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5298 if not defined (Bug#8403).
5300 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5302 * xdisp.c (display_count_lines): Remove parameter `start',
5303 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5304 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5305 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5306 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5307 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5308 and thereabouts. All callers changed.
5309 (get_per_char_metric): Remove parameter `f', unused since
5310 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5312 2011-04-02 Jim Meyering <meyering@redhat.com>
5314 do not dereference NULL upon failed strdup
5315 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5316 (ns_get_family): Likewise.
5318 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5320 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5322 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5324 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5327 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5329 Add lexical binding.
5331 * window.c (Ftemp_output_buffer_show): New fun.
5332 (Fsave_window_excursion):
5333 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5335 * lread.c (lisp_file_lexically_bound_p): New function.
5336 (Fload): Bind Qlexical_binding.
5337 (readevalloop): Remove `evalfun' arg.
5338 Bind Qinternal_interpreter_environment.
5339 (Feval_buffer): Bind Qlexical_binding.
5340 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5342 (syms_of_lread): Declare `lexical-binding'.
5344 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5346 * keyboard.c (eval_dyn): New fun.
5347 (menu_item_eval_property): Use it.
5349 * image.c (parse_image_spec): Use Ffunctionp.
5351 * fns.c (concat, mapcar1): Accept byte-code-functions.
5353 * eval.c (Fsetq): Handle lexical vars.
5354 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5355 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5356 (FletX, Flet): Obey lexical binding.
5357 (Fcommandp): Handle closures.
5358 (Feval): New `lexical' arg.
5359 (eval_sub): New function extracted from Feval. Use it almost
5360 everywhere where Feval was used. Look up vars in lexical env.
5362 (Ffunctionp): Move from subr.el.
5363 (Ffuncall): Handle closures.
5364 (apply_lambda): Remove `eval_flags'.
5365 (funcall_lambda): Handle closures and new byte-code-functions.
5366 (Fspecial_variable_p): New function.
5367 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5368 but without exporting it to Lisp.
5370 * doc.c (Fdocumentation, store_function_docstring):
5371 * data.c (Finteractive_form): Handle closures.
5373 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5376 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5378 (exec_byte_code): New function extracted from Fbyte_code to handle new
5379 calling convention for byte-code-functions. Add new byte-codes.
5381 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5383 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5385 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5387 * xdisp.c (redisplay_internal): Fix prototype.
5389 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5391 * xdisp.c (SCROLL_LIMIT): New macro.
5392 (try_scrolling): Use it when setting scroll_limit.
5393 Limit scrolling to 100 screen lines.
5394 (redisplay_window): Even when falling back on "recentering",
5395 position point in the window according to scroll-conservatively,
5396 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5398 (try_scrolling): When point is above the window, allow searching
5399 as far as scroll_max, or one screenful, to compute vertical
5400 distance from PT to the scroll margin position. This prevents
5401 try_scrolling from unnecessarily failing when
5402 scroll-conservatively is set to a value slightly larger than the
5403 window height. Clean up the case of PT below the margin at bottom
5404 of window: scroll_max can no longer be INT_MAX. When aggressive
5405 scrolling is in use, don't let point enter the opposite scroll
5406 margin as result of the scroll.
5407 (syms_of_xdisp) <scroll-conservatively>: Document the
5408 threshold of 100 lines for never-recentering scrolling.
5410 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5412 * dispextern.h (move_it_by_lines):
5413 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5414 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5415 (message_log_check_duplicate): Remove parameters `prev_bol' and
5416 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5417 (redisplay_internal): Remove parameter `preserve_echo_area',
5418 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5420 * indent.c (Fvertical_motion):
5421 * window.c (window_scroll_pixel_based, Frecenter):
5422 Don't pass `need_y_p' to `move_it_by_lines'.
5424 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5426 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5427 steal a few bits to be more compact.
5428 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5429 Remove unneeded casts.
5431 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5433 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5435 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5436 binding" message (bug#7967).
5438 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5440 Fix more problems found by GCC 4.6.0's static checks.
5442 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5443 Remove unused local var.
5445 * editfns.c (Fmessage_box): Remove unused local var.
5447 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5448 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5449 Omit unused local vars.
5450 * window.c (shrink_windows): Omit unused local var.
5451 * menu.c (digest_single_submenu): Omit unused local var.
5452 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5453 Omit unused local var.
5455 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5456 Don't assume string length fits in int.
5457 (keyremap_step, read_key_sequence): Use size_t for sizes.
5458 (read_key_sequence): Don't check last_real_key_start redundantly.
5460 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5461 instead of alloca (Bug#8344).
5463 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5464 (Fbacktrace_frame): Don't assume nframes fits in int.
5466 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5468 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5471 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5473 * cm.c (calccost): Turn while-do into do-while, for clarity.
5475 * keyboard.c (syms_of_keyboard): Use the same style as later
5476 in this function when indexing through an array. This also
5477 works around GCC bug 48267.
5479 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5481 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5483 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5484 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5486 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5487 This avoids undefined behavior on integer overflow, and is a bit
5488 more convenient anyway since it is compared to a size_t variable.
5490 Variadic C functions now count arguments with size_t, not int.
5491 This avoids an unnecessary limitation on 64-bit machines, which
5492 caused (substring ...) to crash on large vectors (Bug#8344).
5493 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5494 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5495 All variadic functions and their callers changed accordingly.
5496 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5497 * data.c (arith_driver, float_arith_driver): Likewise.
5498 * editfns.c (general_insert_function): Likewise.
5499 * eval.c (struct backtrace.nargs, interactive_p)
5500 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5501 (funcall_lambda, mark_backtrace): Likewise.
5502 * fns.c (concat): Likewise.
5503 * frame.c (x_set_frame_parameters): Likewise.
5504 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5505 0 if not found, not -1. All callers changed.
5507 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5508 (stack_copy_size): Now size_t, not int.
5509 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5511 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5513 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5514 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5515 All callers changed.
5517 * lisp.h (multibyte_char_to_unibyte):
5518 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5519 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5520 * character.h (CHAR_TO_BYTE8):
5521 * cmds.c (internal_self_insert):
5522 * editfns.c (general_insert_function):
5523 * keymap.c (push_key_description):
5524 * search.c (Freplace_match):
5525 * xdisp.c (message_dolog, set_message_1): All callers changed.
5527 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5529 * keyboard.c (safe_run_hook_funcall): New function.
5530 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5531 don't set the hook to nil, but remove the offending function instead.
5532 (Qcommand_hook_internal): Remove, unused.
5533 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5534 Vcommand_hook_internal.
5536 * eval.c (enum run_hooks_condition): Remove.
5537 (funcall_nil, funcall_not): New functions.
5538 (run_hook_with_args): Call each function through a `funcall' argument.
5539 Remove `cond' argument, now redundant.
5540 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5541 (Frun_hook_with_args_until_failure): Adjust accordingly.
5542 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5544 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5546 * dispextern.h (string_buffer_position): Remove declaration.
5548 * print.c (strout): Remove parameter `multibyte', unused since
5549 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5551 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5552 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5553 All callers changed.
5555 * w32.c (_wsa_errlist): Use braces for struct initializers.
5557 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5558 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5559 All callers changed.
5560 (string_buffer_position): Likewise. Also, make static (it's never
5561 used outside xdisp.c).
5562 (cursor_row_p): Remove parameter `w', unused since
5563 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5564 (decode_mode_spec): Remove parameter `precision', introduced during
5565 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5566 All callers changed.
5568 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5570 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5572 2011-03-27 Anders Lindgren <andlind@gmail.com>
5574 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5575 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5576 (ns_update_auto_hide_menu_bar): New functions.
5577 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5578 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5579 ns_constrain_all_frames.
5580 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5581 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5583 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5585 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5587 2011-03-27 Glenn Morris <rgm@gnu.org>
5589 * syssignal.h: Replace RETSIGTYPE with void.
5590 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5591 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5592 Replace SIGTYPE with void everywhere.
5593 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5594 * s/template.h (SIGTYPE): Remove commented out definition.
5596 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5598 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5599 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5601 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5603 * w32.c (read_unc_volume): Use parameter `henum', instead of
5604 global variable `wget_enum_handle'.
5606 * keymap.c (describe_vector): Remove parameters `indices' and
5607 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5608 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5610 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5612 * keyboard.c (timer_check): Remove parameter `do_it_now',
5613 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5614 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5615 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5617 * keyboard.c (read_char):
5618 * w32menu.c (w32_menu_display_help):
5619 * xmenu.c (show_help_event, menu_help_callback):
5620 Adjust calls to `show_help_echo'.
5622 * gtkutil.c (xg_maybe_add_timer):
5623 * keyboard.c (readable_events):
5624 * process.c (wait_reading_process_output):
5625 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5627 * insdel.c (adjust_markers_gap_motion):
5628 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5629 (gap_left, gap_right): Don't call it.
5631 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5633 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5634 incurred during fontification.
5636 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5638 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5639 (DEFVAR_PER_BUFFER): Don't pass it.
5641 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5642 (scrolling_window): Don't pass it.
5644 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5646 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5648 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5650 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5651 of variables specific to SELinux and computation of `encoded_absname'.
5653 * image.c (XPutPixel): Remove unused variable `height'.
5655 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5657 * unexw32.c (get_section_info): Remove unused variable `section'.
5659 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5660 (system_process_attributes): Remove unused variable `sess'.
5661 (sys_read): Remove unused variable `err'.
5663 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5664 (w32_wnd_proc): Remove unused variable `isdead'.
5665 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5666 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5667 (x_create_tip_frame): Remove unused variable `tem'.
5669 * w32inevt.c (w32_console_read_socket):
5670 Remove unused variable `no_events'.
5672 * w32term.c (x_draw_composite_glyph_string_foreground):
5673 Remove unused variable `width'.
5675 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5677 * w32term.c (x_set_glyph_string_clipping):
5678 Don't pass uninitialized region to CombineRgn.
5680 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5682 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5683 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5684 (Fx_close_connection): Remove unused variable `i'.
5686 * w32font.c (w32font_draw): Return number of glyphs.
5687 (w32font_open_internal): Remove unused variable `i'.
5688 (w32font_driver): Add missing initializer.
5690 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5691 (fill_in_menu): Remove unused variable `items_added'.
5693 * w32term.c (last_mouse_press_frame): Remove static global variable.
5694 (w32_clip_to_row): Remove unused variable `f'.
5695 (x_delete_terminal): Remove unused variable `i'.
5697 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5698 (NOTHING): Remove unused static global variable.
5699 (uniscribe_check_otf): Remove unused variable `table'.
5700 (uniscribe_font_driver): Add missing initializers.
5702 2011-03-23 Julien Danjou <julien@danjou.info>
5704 * term.c (Fsuspend_tty, Fresume_tty):
5705 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5706 * window.c (temp_output_buffer_show):
5707 * insdel.c (signal_before_change):
5708 * frame.c (Fhandle_switch_frame):
5709 * fileio.c (Fdo_auto_save):
5710 * emacs.c (Fkill_emacs):
5711 * editfns.c (save_excursion_restore):
5712 * cmds.c (internal_self_insert):
5713 * callint.c (Fcall_interactively):
5714 * buffer.c (Fkill_all_local_variables):
5715 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5717 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5718 unconditionnaly since it does the check itself.
5720 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5722 Fix more problems found by GCC 4.5.2's static checks.
5724 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5725 the first time through the loop, since we know p0 < p1 then.
5726 This also avoids a gcc -Wstrict-overflow warning.
5728 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5729 leading to a memory leak, possible in functions like
5730 load_charset_map_from_file that can allocate an unbounded number
5731 of objects (Bug#8318).
5733 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5734 that could (at least in theory) be that large.
5736 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5737 This is less likely to overflow, and avoids undefined behavior if
5738 overflow does occur. All callers changed. Use strtoul to scan
5739 for the unsigned long integer.
5740 (pint2hrstr): Simplify and tune code slightly.
5741 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5743 * scroll.c (do_scrolling): Work around GCC bug 48228.
5744 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5746 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5747 This also avoids a warning with gcc -Wstrict-overflow.
5748 (validate_x_resource_name): Simplify count usage.
5749 This also avoids a warning with gcc -Wstrict-overflow.
5751 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5754 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5756 * process.c (Fmake_network_process): Use socklen_t, not int,
5757 where POSIX says socklen_t is required in portable programs.
5758 This fixes a porting bug on hosts like 64-bit HP-UX, where
5759 socklen_t is wider than int (Bug#8277).
5760 (Fmake_network_process, server_accept_connection):
5761 (wait_reading_process_output, read_process_output):
5764 * process.c: Rename or move locals to avoid shadowing.
5765 (list_processes_1, Fmake_network_process):
5766 (read_process_output_error_handler, exec_sentinel_error_handler):
5767 Rename or move locals.
5768 (Fmake_network_process): Define label "retry_connect" only if needed.
5769 (Fnetwork_interface_info): Fix pointer signedness.
5770 (process_send_signal): Add cast to avoid pointer signedness problem.
5771 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5772 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5774 Make tparam.h and terminfo.c consistent.
5775 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5776 Include tparam.h instead, since it declares them.
5777 * cm.h (PC): Remove extern decl; tparam.h now does this.
5778 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5779 * terminfo.c: Include tparam.h, to check interfaces.
5780 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5781 (tparam): Adjust signature to match interface in tparam.h;
5782 this removes some undefined behavior. Check that outstring and len
5783 are zero, which they always are with Emacs.
5784 * tparam.h (PC, BC, UP): New extern decls.
5786 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5787 (xftfont_open): Rename locals to avoid shadowing.
5789 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5790 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5791 (OTF_TAG_SYM): Omit macro if not needed.
5792 (ftfont_list): Remove unused local.
5793 (get_adstyle_property, ftfont_pattern_entity):
5794 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5795 Rename locals to avoid shadowing.
5797 * xfont.c (xfont_list_family): Mark var as initialized.
5799 * xml.c (make_dom): Now static.
5801 * composite.c (composition_compute_stop_pos): Rename local to
5803 (composition_reseat_it): Remove unused locals.
5804 (find_automatic_composition, composition_adjust_point): Likewise.
5805 (composition_update_it): Mark var as initialized.
5806 (find_automatic_composition): Mark vars as initialized,
5807 with a FIXME (Bug#8290).
5809 character.h: Rename locals to avoid shadowing.
5810 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5811 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5812 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5813 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5816 * textprop.c (property_change_between_p): Remove; unused.
5818 * intervals.c (interval_start_pos): Now static.
5820 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5822 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5823 Rename locals to avoid shadowing.
5825 * sound.c (wav_play, au_play, Fplay_sound_internal):
5826 Fix pointer signedness.
5827 (alsa_choose_format): Remove unused local var.
5828 (wav_play): Initialize a variable to 0, to prevent undefined
5829 behavior (Bug#8278).
5831 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5833 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5835 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5836 clobbering (Bug#8298).
5837 * sysdep.c (sys_subshell): Likewise.
5838 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5840 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5841 This should get cleaned up, so that child_setup has the
5842 same signature on all platforms.
5844 * callproc.c (call_process_cleanup): Now static.
5845 (relocate_fd): Rename locals to avoid shadowing.
5847 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5849 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5850 not to be necessary, and produces flickering.
5852 2011-03-20 Glenn Morris <rgm@gnu.org>
5854 * config.in: Remove file.
5856 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5858 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5859 are now in src/globals.h.
5860 (syms_of_minibuf): Remove spurious & from previous change.
5862 2011-03-20 Leo <sdl.web@gmail.com>
5864 * minibuf.c (completing-read-function): New variable.
5865 (completing-read-default): Rename from completing-read.
5866 (completing-read): Call completing-read-function.
5868 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5870 * xfaces.c (Fx_load_color_file):
5871 Read color file from absolute filename (bug#8250).
5873 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5875 * makefile.w32-in: Update dependencies.
5877 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5879 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5881 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5883 Fix more problems found by GCC 4.5.2's static checks.
5885 * process.c (make_serial_process_unwind, send_process_trap):
5886 (sigchld_handler): Now static.
5888 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5889 That way, the code declares only the vars that it needs.
5890 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5891 * s/cygwin.h (PTY_ITERATION): Likewise.
5892 * s/darwin.h (PTY_ITERATION): Likewise.
5893 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5895 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5896 * process.c (allocate_pty): Don't declare stb unless it's needed.
5898 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5899 (CONSTANTLIM): Remove; unused.
5900 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5901 Define only if needed.
5903 * unexelf.c (unexec): Name an expression,
5904 to avoid gcc -Wbad-function-cast warning.
5905 Use a different way to cause a compilation error if anyone uses
5906 n rather than nn, a way that does not involve shadowing.
5907 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5909 * deps.mk (unexalpha.o): Remove; unused.
5911 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5912 * unexec.h: New file.
5913 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5914 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5916 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5917 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5918 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5919 Change as necessary to match prototype in unexec.h.
5921 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5923 (back_comment, skip_chars): Mark vars as initialized.
5925 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5926 Rename locals to avoid shadowing.
5928 * lread.c (read1): Rewrite so as not to use empty "else".
5929 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5931 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5933 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5934 warning when compiling print.c.
5936 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5937 instead of using an uninitialized var.
5938 (font_sort_entities): Mark var as initialized.
5940 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5942 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5943 pointers to constants.
5944 (font_parse_fcname): Remove unused vars.
5945 (font_delete_unmatched): Now static.
5946 (font_get_spec): Remove; unused.
5947 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5948 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5949 Rename or move locals to avoid shadowing.
5951 * fns.c (require_nesting_list, require_unwind): Now static.
5952 (Ffillarray): Rename locals to avoid shadowing.
5954 * floatfns.c (domain_error2): Define only if needed.
5955 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5957 * alloc.c (mark_backtrace): Move decl from here ...
5958 * lisp.h: ... to here, so that it can be checked.
5960 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5961 (Fdefvar): Rewrite so as not to use empty "else".
5962 (lisp_indirect_variable): Name an expression,
5963 to avoid gcc -Wbad-function-cast warning.
5964 (Fdefvar): Rename locals to avoid shadowing.
5966 * callint.c (quotify_arg, quotify_args): Now static.
5967 (Fcall_interactively): Rename locals to avoid shadowing.
5968 Use const pointer when appropriate.
5970 * lisp.h (get_system_name, get_operating_system_release):
5971 Move decls here, to check interfaces.
5972 * process.c (get_operating_system_release): Move decl to lisp.h.
5973 * xrdb.c (get_system_name): Likewise.
5974 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5975 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5976 some of which prompt warnings from gcc -Wbad-function-cast.
5977 (Fformat_time_string, Fencode_time, Finsert_char):
5978 (Ftranslate_region_internal, Fformat):
5979 Rename or remove local vars to avoid shadowing.
5980 (Ftranslate_region_internal): Mark var as initialized.
5982 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5985 * lisp.h (eassert): Check that the argument compiles, even if
5986 ENABLE_CHECKING is not defined.
5988 * data.c (Findirect_variable): Name an expression, to avoid
5989 gcc -Wbad-function-cast warning.
5990 (default_value, arithcompare, arith_driver, arith_error): Now static.
5991 (store_symval_forwarding): Rename local to avoid shadowing.
5992 (Fmake_variable_buffer_local, Fmake_local_variable):
5993 Mark variables as initialized.
5994 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5996 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5997 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5998 Rename locals to avoid shadowing.
5999 (mark_stack): Move local variables into the #ifdef region where
6001 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6002 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6004 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6005 (GC_STRING_CHARS): Remove; not used.
6006 (Fmemory_limit): Cast sbrk's returned value to char *.
6008 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6009 avoids undefined behavior in theory.
6011 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6013 Use functions, not macros, for up- and down-casing (Bug#8254).
6014 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6015 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6016 to use the following functions instead of these macros.
6017 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6018 EMACS_INT, since callers assume the returned value fits in int.
6019 (upcase1): Likewise, for UPCASE_TABLE.
6020 (uppercasep, lowercasep, upcase): New static inline functions.
6021 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6022 the race-condition problem in the old DOWNCASE.
6024 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6025 Rename locals to avoid shadowing.
6026 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6027 (regex_compile, re_search_2, re_match_2_internal):
6028 Remove unused local vars.
6029 (FREE_VAR): Rewrite so as not to use empty "else",
6030 which gcc can warn about.
6031 (regex_compile, re_match_2_internal): Mark locals as initialized.
6032 (RETALLOC_IF): Define only if needed.
6033 (WORDCHAR_P): Likewise. This one is never needed, but is used
6034 only in a comment talking about a compiler bug, so put inside
6035 the #if 0 of that comment.
6036 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6037 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6040 * search.c (boyer_moore): Rename locals to avoid shadowing.
6041 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6042 (PREV_CHAR_BOUNDARY): Likewise.
6044 * search.c (simple_search): Remove unused var.
6046 * dired.c (compile_pattern): Move decl from here ...
6047 * lisp.h: ... to here, so that it can be checked.
6048 (struct re_registers): New forward decl.
6050 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6052 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6054 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6055 Rename locals to avoid shadowing.
6056 (Fvertical_motion): Mark locals as initialized.
6058 * casefiddle.c (casify_object, casify_region): Now static.
6059 (casify_region): Mark local as initialized.
6061 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6063 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6064 New macros, so that the caller can use some names other than
6065 gcpro1, gcpro2, etc.
6066 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6068 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6069 argument, for consistency with GCPRO2_VAR, etc: it is now the
6070 prefix of the variable, not the variable itself. All uses
6072 * dired.c (directory_files_internal, file_name_completion):
6073 Rename locals to avoid shadowing.
6075 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6076 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6077 dired.c's scmp function, had undefined behavior.
6078 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6079 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6080 * buffer.h: ... to here, because these macros use current_buffer,
6081 and the new implementation with inline functions needs to have
6082 current_buffer in scope now, rather than later when the macros
6084 (downcase, upcase1): New static inline functions.
6085 (DOWNCASE, UPCASE1): Reimplement using these functions.
6086 This avoids undefined behavior in expressions like
6087 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6088 from race conditions in accessing the global variables
6089 case_temp1 and case_temp2.
6090 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6091 * lisp.h (case_temp1, case_temp2): Remove their decls.
6092 * character.h (ASCII_CHAR_P): Move from here ...
6093 * lisp.h: ... to here, so that the inline functions mentioned
6096 * dired.c (directory_files_internal_unwind): Now static.
6098 * fileio.c (file_name_as_directory, directory_file_name):
6099 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6101 (file_name_as_directory): Use const pointers when appropriate.
6102 (Fexpand_file_name): Likewise. In particular, newdir might
6103 point at constant storage, so make it a const pointer.
6104 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6105 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6107 (Fset_file_times, Finsert_file_contents, auto_save_error):
6108 Rename locals to avoid shadowing.
6110 * minibuf.c (choose_minibuf_frame_1): Now static.
6111 (Ftry_completion, Fall_completions): Rename or remove locals
6114 * marker.c (bytepos_to_charpos): Remove; unused.
6116 * lisp.h (verify_bytepos, count_markers): New decls,
6117 so that gcc does not warn that these functions aren't declared.
6119 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6120 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6121 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6122 (copy_text): Remove unused local var.
6124 * filelock.c (within_one_second): Now static.
6125 (lock_file_1): Rename local to avoid shadowing.
6127 * buffer.c (fix_overlays_before): Mark locals as initialized.
6128 (fix_start_end_in_overlays): Likewise. This function should be
6129 simplified by using pointers-to-pointers, but that's a different
6131 (switch_to_buffer_1): Now static.
6132 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6133 (report_overlay_modification): Rename locals to avoid shadowing.
6135 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6136 Fix pointer signedness issue.
6137 (sys_subshell): Mark local as volatile if checking for lint,
6138 to suppress a gcc -Wclobbered warning that does not seem to be right.
6139 (MAXPATHLEN): Define only if needed.
6141 * process.c (serial_open, serial_configure): Move decls from here ...
6142 * systty.h: ... to here, so that they can be checked.
6144 * fns.c (get_random, seed_random): Move extern decls from here ...
6145 * lisp.h: ... to here, so that they can be checked.
6147 * sysdep.c (reset_io): Now static.
6148 (wait_for_termination_signal): Remove; unused.
6150 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6151 (copy_keymap_item, append_key, push_text_char_description):
6153 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6154 (DENSE_TABLE_SIZE): Remove; unused.
6155 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6156 (describe_map_tree):
6157 Rename locals to avoid shadowing.
6159 * keyboard.c: Declare functions static if they are not used elsewhere.
6160 (echo_char, echo_dash, cmd_error, top_level_2):
6161 (poll_for_input, handle_async_input): Now static.
6162 (read_char, kbd_buffer_get_event, make_lispy_position):
6163 (make_lispy_event, make_lispy_movement, apply_modifiers):
6164 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6165 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6166 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6167 (read_key_sequence, read_char): Mark locals as initialized.
6168 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6170 * keyboard.h (make_ctrl_char): New decl.
6171 (mark_kboards): Move decl here ...
6172 * alloc.c (mark_kboards): ... from here.
6174 * lisp.h (force_auto_save_soon): New decl.
6176 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6177 (DEFINE_DUMMY_FUNCTION): New macro.
6178 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6180 (main): Add casts to avoid warnings
6181 if GCC considers string literals to be constants.
6183 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6185 * dbusbind.c: Pointer signedness fixes.
6186 (xd_signature, xd_append_arg, xd_initialize):
6187 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6188 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6189 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6190 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6192 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6193 if GCC considers string literals to be constants.
6194 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6196 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6198 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6199 (print_preprocess, print_object): New macro to fix last change.
6201 * print.c (print_preprocess): Don't forget font objects.
6203 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6205 * emacs.c (USAGE3): Doc fixes.
6207 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6209 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6212 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6214 * lisp.h (VWindow_system, Qfile_name_history):
6215 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6216 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6217 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6219 * w32select.c: Don't #include "keyboard.h".
6220 (run_protected): Add extern declaration for waiting_for_input.
6222 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6223 * w32console.c (detect_input_pending, read_input_pending)
6224 (encode_terminal_code):
6225 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6226 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6227 (w32_system_caret_y, Qfile_name_history):
6228 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6229 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6230 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6231 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6232 * w32proc.c (Qlocal, report_file_error):
6233 * w32term.c (Vwindow_system, updating_frame):
6234 * w32uniscribe.c (initialized, uniscribe_font_driver):
6235 Remove unneeded extern declarations.
6237 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6239 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6241 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6243 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6244 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6245 These macros can no longer be used for assignment.
6247 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6248 Assign struct members directly, instead of using BUF_BEGV etc.
6249 (record_buffer_markers, fetch_buffer_markers): New functions for
6250 recording and fetching special buffer markers.
6251 (set_buffer_internal_1, set_buffer_temp): Use them.
6253 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6255 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6257 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6258 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6260 * xdisp.c (hscroll_window_tree):
6261 (reconsider_clip_changes): Use PT instead of BUF_PT.
6263 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6265 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6266 $(EMACS_ROOT)/lib/intprops.h.
6268 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6270 Fix more problems found by GCC 4.5.2's static checks.
6272 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6273 to unsigned char * to avoid compiler diagnostic.
6274 (xg_free_frame_widgets): Make it clear that a local variable is
6275 needed only if USE_GTK_TOOLTIP.
6276 (gdk_window_get_screen): Make it clear that this macro is needed
6277 only if USE_GTK_TOOLTIP.
6278 (int_gtk_range_get_value): New function, which avoids a diagnostic
6279 from gcc -Wbad-function-cast.
6280 (xg_set_toolkit_scroll_bar_thumb): Use it.
6281 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6282 diagnostic from gcc -Wbad-function-cast.
6283 (get_utf8_string, xg_get_file_with_chooser):
6284 Rename locals to avoid shadowing.
6285 (create_dialog): Move locals to avoid shadowing.
6287 * xgselect.c (xg_select): Remove unused var.
6289 * image.c (four_corners_best): Mark locals as initialized.
6290 (gif_load): Initialize transparent_p to zero (Bug#8238).
6291 Mark another local as initialized.
6292 (my_png_error, my_error_exit): Mark with NO_RETURN.
6294 * image.c (clear_image_cache): Now static.
6295 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6296 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6297 (x_edge_detection): Remove unnecessary cast that
6298 gcc -Wbad-function-cast diagnoses.
6299 (gif_load): Fix pointer signedness.
6300 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6301 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6303 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6305 Improve quality of tests for time stamp overflow.
6306 For example, without this patch (encode-time 0 0 0 1 1
6307 1152921504606846976) returns the obviously-bogus value (-948597
6308 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6309 reports time overflow. See
6310 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6311 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6312 * editfns.c: Include limits.h and intprops.h.
6313 (TIME_T_MIN, TIME_T_MAX): New macros.
6314 (time_overflow): Move earlier, to before first use.
6315 (hi_time, lo_time): New functions, for an accurate test for
6317 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6318 (Fget_internal_run_time): Don't assume time_t fits in int.
6319 (make_time): Use list2 instead of Fcons twice.
6320 (Fdecode_time): More accurate test for out-of-range times.
6321 (check_tm_member): New function.
6322 (Fencode_time): Use it, to test for out-of-range times.
6323 (lisp_time_argument): Don't rely on undefined left-shift and
6324 right-shift behavior when checking for time stamp overflow.
6326 * editfns.c (time_overflow): New function, refactoring common code.
6327 (Fformat_time_string, Fdecode_time, Fencode_time):
6328 (Fcurrent_time_string): Use it.
6330 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6331 * dired.c (make_time): Move to ...
6332 * editfns.c (make_time): ... here.
6333 * systime.h: Note the move.
6335 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6337 * fringe.c (update_window_fringes): Remove unused variables.
6339 * unexmacosx.c (copy_data_segment): Also copy __got section.
6342 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6344 * termcap.c [MSDOS]: Include "msdos.h".
6345 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6346 Constify `char *' arguments and their references according to
6347 prototypes in tparam.h.
6349 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6351 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6352 Adapt all references accordingly.
6354 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6356 2011-03-11 Tom Tromey <tromey@redhat.com>
6358 * buffer.c (syms_of_buffer): Remove obsolete comment.
6360 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6362 * termhooks.h (encode_terminal_code): Declare prototype.
6364 * msdos.c (encode_terminal_code): Don't declare prototype.
6366 * term.c (encode_terminal_code): Now external again, used by
6367 w32console.c and msdos.c.
6369 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6370 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6372 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6374 Fix some minor problems found by GCC 4.5.2's static checks.
6376 * fringe.c (update_window_fringes): Mark locals as initialized
6378 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6380 * alloc.c (mark_fringe_data): Move decl from here ...
6381 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6382 to check its interface.
6383 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6385 * fontset.c (free_realized_fontset): Now static.
6386 (Fset_fontset_font): Rename local to avoid shadowing.
6387 (fontset_font): Mark local as initialized.
6388 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6390 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6392 * xselect.c (x_disown_buffer_selections): Remove; not used.
6393 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6394 (x_own_selection, Fx_disown_selection_internal): Rename locals
6396 (x_handle_dnd_message): Remove local to avoid shadowing.
6398 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6399 so that the caller can use some name other than gcpro1.
6400 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6401 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6402 (Fx_backspace_delete_keys_p):
6403 Use them to avoid shadowing, and rename vars to avoid shadowing.
6404 (x_decode_color, x_set_name, x_window): Now static.
6405 (Fx_create_frame): Add braces to silence GCC warning.
6406 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6407 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6408 Remove unused locals.
6409 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6410 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6411 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6414 * xterm.h (x_mouse_leave): New decl.
6416 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6417 Remove unused functions.
6418 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6419 (x_calc_absolute_position): Now static.
6420 (XTread_socket): Don't define label "out" unless it's used.
6421 Don't declare local "event" unless it's used.
6422 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6423 unless they are used.
6424 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6425 (x_fatal_error_signal): Remove; not used.
6426 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6427 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6428 (x_error_catcher, x_connection_closed, x_error_handler):
6429 (x_error_quitter, xembed_send_message, x_iconify_frame):
6430 (my_log_handler): Rename locals to avoid shadowing.
6431 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6432 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6434 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6435 Rename or move locals to avoid shadowing.
6436 (tty_defined_color, merge_face_heights): Now static.
6437 (free_realized_faces_for_fontset): Remove; not used.
6438 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6439 does not deduce is never used uninitialized.
6440 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6441 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6443 * terminal.c (store_terminal_param): Now static.
6445 * xmenu.c (menu_highlight_callback): Now static.
6446 (set_frame_menubar): Remove unused local.
6447 (xmenu_show): Rename parameter to avoid shadowing.
6448 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6449 since they might point to immutable storage.
6450 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6451 since it's unused otherwise.
6453 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6454 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6455 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6456 avoids a gcc -Wuninitialized diagnostic.
6457 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6458 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6459 does not deduce are never used uninitialized.
6461 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6463 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6464 * window.c (window_loop, size_window):
6465 (run_window_configuration_change_hook, enlarge_window): Likewise.
6467 * window.c (display_buffer): Now static.
6468 (size_window): Mark variables that gcc -Wuninitialized
6469 does not deduce are never used uninitialized.
6470 * window.h (check_all_windows): New decl, to forestall
6471 gcc -Wmissing-prototypes diagnostic.
6472 * dispextern.h (bidi_dump_cached_states): Likewise.
6474 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6476 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6478 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6479 and to avoid gcc -Wuninitialized warning.
6480 (load_charset_map): Mark variables that gcc -Wuninitialized
6481 does not deduce are never used uninitialized.
6482 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6484 * coding.c (coding_set_source, coding_set_destination):
6485 Use "else { /* comment */ }" rather than "else /* comment */;"
6486 for clarity, and to avoid gcc -Wempty-body warning.
6487 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6488 a block, when the outer 'i' will do.
6489 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6490 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6491 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6492 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6493 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6494 Rename locals to avoid shadowing.
6495 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6496 * coding.c (emacs_mule_char, encode_invocation_designation):
6497 Now static, since they're not used elsewhere.
6498 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6499 (decode_coding_object, encode_coding_object, detect_coding_system):
6500 (decode_coding_emacs_mule): Mark variables that gcc
6501 -Wuninitialized does not deduce are never used uninitialized.
6502 (detect_coding_iso_2022): Initialize a local variable that might
6503 be used uninitialized. Leave a FIXME because it's not clear that
6504 this initialization is needed. (Bug#8211)
6505 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6506 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6507 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6508 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6509 Remove unused macros.
6511 * category.c (hash_get_category_set): Remove unused local var.
6512 (copy_category_table): Now static, since it's not used elsewhere.
6513 * character.c (string_count_byte8): Likewise.
6515 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6516 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6518 * chartab.c (copy_sub_char_table): Now static, since it's not used
6520 (sub_char_table_ref_and_range, char_table_ref_and_range):
6521 Rename locals to avoid shadowing.
6522 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6524 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6525 (BIDI_BOB): Remove unused macro.
6527 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6528 deduce are never used uninitialized.
6529 * term.c (encode_terminal_code): Likewise.
6531 * term.c (encode_terminal_code): Now static. Remove unused local.
6533 * tparam.h: New file.
6534 * term.c, tparam.h: Include it.
6535 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6536 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6537 Move these decls to tparam.h, and make them agree with what
6538 is actually in tparam.c. The previous trick of using incompatible
6539 decls in different modules does not conform to the C standard.
6540 All callers of tparam changed to use tparam's actual API.
6541 * tparam.c (tparam1, tparam, tgoto):
6542 Use const pointers where appropriate.
6544 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6545 * cm.h (struct cm): Likewise.
6546 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6547 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6548 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6549 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6550 (turn_on_face, init_tty): Likewise.
6551 * termchar.h (struct tty_display_info): Likewise.
6553 * term.c (term_mouse_position): Rename local to avoid shadowing.
6555 * alloc.c (mark_ttys): Move decl from here ...
6556 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6558 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6560 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6562 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6564 * search.c (compile_pattern_1): Remove argument regp, unused since
6565 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6566 (compile_pattern): Don't pass it.
6568 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6570 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6571 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6573 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6575 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6577 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6578 gdk_window_get_screen, gdk_window_get_geometry,
6579 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6580 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6581 (xg_get_pixbuf_from_pixmap): New function.
6582 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6583 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6584 Call xg_get_pixbuf_from_pixmap instead of
6585 gdk_pixbuf_get_from_drawable.
6586 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6587 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6588 (xg_check_special_colors): Use GtkStyleContext and its functions
6590 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6591 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6592 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6593 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6594 Call gtk_widget_get_preferred_size.
6595 (xg_frame_resized): gdk_window_get_geometry only takes 5
6597 (xg_win_to_widget, xg_event_is_for_menubar):
6598 Call gdk_x11_window_lookup_for_display.
6599 (xg_set_widget_bg): New function.
6600 (delete_cb): New function.
6601 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6602 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6603 (xg_set_background_color): Call xg_set_widget_bg.
6604 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6605 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6606 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6607 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6609 (update_frame_tool_bar): Call gtk_widget_hide.
6610 (xg_initialize): Use GDK_KEY_g.
6612 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6614 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6616 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6617 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6618 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6620 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6622 * w32xfns.c (select_palette): Check success of RealizePalette against
6623 GDI_ERROR, not zero.
6625 See ChangeLog.11 for earlier changes.
6631 Copyright (C) 2011 Free Software Foundation, Inc.
6633 This file is part of GNU Emacs.
6635 GNU Emacs is free software: you can redistribute it and/or modify
6636 it under the terms of the GNU General Public License as published by
6637 the Free Software Foundation, either version 3 of the License, or
6638 (at your option) any later version.
6640 GNU Emacs is distributed in the hope that it will be useful,
6641 but WITHOUT ANY WARRANTY; without even the implied warranty of
6642 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6643 GNU General Public License for more details.
6645 You should have received a copy of the GNU General Public License
6646 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.