Assume C89 or later.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
261cb4bb
PE
12012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2
3 Assume C89 or later.
4 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
5 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
6 (xrealloc):
7 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
8 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
9 * textprop.c, tparam.c (NULL): Remove.
10 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
11 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
12 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
13 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
14 * xterm.c (input_signal_count): Assume volatile works.
15
ff23cd9f
KB
162012-05-21 Ken Brown <kbrown@cornell.edu>
17
18 * xgselect.c (xg_select): Fix first argument in call to 'select'
19 (bug#11508).
20
1b170bc6
KB
212012-05-20 Ken Brown <kbrown@cornell.edu>
22
23 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
24 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
25
b2f4d39f
KB
262012-05-19 Ken Brown <kbrown@cornell.edu>
27
28 * xfns.c (x_in_use): Remove `static' qualifier.
29 * xterm.h (x_in_use): Declare.
30 * xgselect.c: Include xterm.h.
31 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
32 and `display_arg' (bug#9754).
33
003fdae2
PE
342012-05-19 Paul Eggert <eggert@cs.ucla.edu>
35
9232a6d9
PE
36 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
37
003fdae2
PE
38 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
39 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
40
784b56e2
EZ
412012-05-18 Eli Zaretskii <eliz@gnu.org>
42
43 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
44
45 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
46 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
47
48 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
49 reference to image_cache->refcount.
50 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
51
a0a79cde
JL
522012-05-17 Juri Linkov <juri@jurta.org>
53
54 * search.c (Fword_search_regexp, Fword_search_backward)
55 (Fword_search_forward, Fword_search_backward_lax)
56 (Fword_search_forward_lax): Move functions to isearch.el
57 (bug#10145, bug#11381).
58
b0572523
PE
592012-05-16 Paul Eggert <eggert@cs.ucla.edu>
60
61 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
62
9660f5fc
SM
632012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
64
65 * lread.c (init_obarray): Declare Qt and Qnil as special.
66
4374de83
GM
672012-05-14 Glenn Morris <rgm@gnu.org>
68
69 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 70 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 71
dc44c39a
PE
722012-05-14 Paul Eggert <eggert@cs.ucla.edu>
73
078c97cb
PE
74 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
75
dc44c39a
PE
76 * unexaix.c: Port to more-recent AIX compilers.
77 (report_error, report_error_1, make_hdr, copy_sym)
78 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
79 Make arguments const char *, not char *, to avoid violations of C
80 standard and to fix some AIX warnings reported by Gilles Pion.
81
e18afed7 822012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
83
84 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
85 already have overlays loaded.
86 (handle_single_display_spec): Before returning without displaying
87 fringe bitmap, synchronize the bidi iterator with the main display
88 iterator, by calling iterate_out_of_display_property.
89 (iterate_out_of_display_property): Detect buffer iteration by
90 testing that it->string is a Lisp string.
91 (get_next_display_element): When the current object is exhausted,
92 and there's something on it->stack, call set_iterator_to_next to
93 proceed with what's on the stack, instead of returning zero.
94 (set_iterator_to_next): If called at the end of a Lisp string,
95 proceed to consider_string_end without incrementing string
96 position. Don't increment display vector index past the end of
97 the display vector. (Bug#11417)
c8fb9dc6
EZ
98 (pos_visible_p): Don't report a position visible when move_it_to
99 stopped at the last line of window, which happens to be scanned
100 backwards by the bidi iteration. (Bug#11464)
ac268e67 101
e18afed7 1022012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
103
104 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
105 and right-margin display specs even if the spec is invalid or we
106 are on a TTY, and thus unable to display on the fringes. That's
107 because the text with the property will not be displayed anyway,
108 so we need to signal to the caller that this is a "replacing"
109 display spec. This fixes display when the spec is invalid or we
110 are on a TTY.
111
e18afed7 1122012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
113
114 * unexaix.c (make_hdr): Fix typo in prototype.
115 This bug broke the build on AIX. Problem reported by Gilles Pion.
116
9d0a235a
MA
1172012-05-14 Michael Albinus <michael.albinus@gmx.de>
118
119 * keyboard.c (kbd_buffer_get_event): Read special events also in
120 batch mode. (Bug#11415)
121
9e6b06ed
GM
1222012-05-12 Glenn Morris <rgm@gnu.org>
123
124 * ns.mk: Update for ns_appbindir no longer having trailing "/".
125
c1a1d7a3
EZ
1262012-05-12 Eli Zaretskii <eliz@gnu.org>
127
128 * lisp.mk (lisp): Add newcomment.elc.
129
3fe7cdc8
GM
1302012-05-12 Glenn Morris <rgm@gnu.org>
131
132 * Makefile.in (MKDIR_P): New, set by configure.
133 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
134
53f7d2c0
PE
1352012-05-11 Paul Eggert <eggert@cs.ucla.edu>
136
137 Remove unused function hourglass_started.
138 * dispextern.h (hourglass_started):
139 * w32fns.c (hourglass_started):
140 * xdisp.c (hourglass_started): Remove.
141
75aafb17
JB
1422012-05-10 Juanma Barranquero <lekktu@gmail.com>
143
144 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
145 Update dependencies.
146
12959e8e
PE
1472012-05-10 Paul Eggert <eggert@cs.ucla.edu>
148
97107e2e
PE
149 * xgselect.c (xg_select): Put maxfds+1 into a var.
150 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
151
12959e8e
PE
152 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
153
836d29b3
DA
1542012-05-10 Dave Abrahams <dave@boostpro.com>
155
156 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
157 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
158
5cb67954
MA
1592012-05-09 Michael Albinus <michael.albinus@gmx.de>
160
161 * dbusbind.c (xd_registered_buses): New internal Lisp object.
162 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
163 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
164 Initialize xd_registered_buses.
165
3478ec45
PE
1662012-05-09 Paul Eggert <eggert@cs.ucla.edu>
167
b263a6b0
PE
168 Untag more efficiently if USE_LSB_TAG.
169 This is based on a proposal by YAMAMOTO Mitsuharu in
170 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
171 For an admittedly artificial (nth 8000 longlist) benchmark on
172 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
173 Emacs's overall text size by 1%.
174 * lisp.h (XUNTAG): New macro.
175 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
176 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
177 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
178 * eval.c (Fautoload):
179 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
180 * frame.h (XFRAME): Use XUNTAG.
181
3478ec45
PE
182 Port recent dbusbind.c changes to 32-bit --with-wide-int.
183 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
184 Remove unportable assumptions about print widths of types like
185 dbus_uint32_t.
186 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
187 intptr_t when converting between pointer and integer, to avoid GCC
188 warnings about wrong width.
189
666b903b 1902012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
191
192 * w32proc.c (new_child): Force Windows to reserve only 64KB of
193 stack for each reader_thread, instead of defaulting to 8MB
194 determined by the linker. This avoids failures in creating
195 subprocesses on Windows 7, see the discussion in this thread:
196 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
197
b120cc17
JC
1982012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
199
200 Fix up display of the *Minibuf-0* buffer in the mini window.
201 * keyboard.c (read_char): Don't clear the echo area if there's no
202 message to clear.
203 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 204 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 205
9a4b36f8
MA
2062012-05-07 Michael Albinus <michael.albinus@gmx.de>
207
208 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
209 batch mode.
210
e5f9458f
CY
2112012-05-06 Chong Yidong <cyd@gnu.org>
212
213 * lisp.mk (lisp): Update.
214
eceeb5fc 2152012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
216
217 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
218
71873e2b
SM
2192012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
220
221 * data.c (PUT_ERROR): New macro.
222 (syms_of_data): Use it. Add new error type `user-error'.
223 * undo.c (user_error): New function.
224 (Fprimitive_undo): Use it.
225 * print.c (print_error_message): Adjust print style for `user-error'.
226 * keyboard.c (user_error): New function.
227 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
228
ab0fa4e4
PE
2292012-05-03 Paul Eggert <eggert@cs.ucla.edu>
230
231 Do not limit current-time-string to years 1000..9999.
232 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
233 (Fcurrent_time_string): Support any year that is supported by the
234 underlying localtime representation. Don't use asctime, as it
235 has undefined behavior for years outside the range -999..9999.
236
7ed806a7
PE
2372012-05-02 Paul Eggert <eggert@cs.ucla.edu>
238
239 Fix race conditions involving setenv, gmtime, localtime, asctime.
240 Without this fix, interrupts could mess up code that uses these
241 nonreentrant functions, since setting TZ invalidates existing
242 tm_zone or tzname values, and since most of these functions return
243 pointers to static storage.
244 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
245 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
246 Grow the critical sections to include not just invoking
247 localtime/gmtime, but also accessing these functions' results
248 including their tm_zone values if any, and any related TZ setting.
249 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
250 so that the struct tm is saved in the critical section.
251 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
252 motivated by the fact that memory allocation needs to be outside
253 the critical section.
254
0c16dfed
DA
2552012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
256
257 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
258 with RESET_INTERVAL.
259
260 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
261 Remove duplicated buffer name initialization.
262
3f83ace8
JM
2632012-05-02 Jim Meyering <jim@meyering.net>
264
265 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
266
c7b8541e
JM
267 * xfns.c (x_window): Use xstrdup (Bug#11375).
268
90207a15 2692012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
270
271 * xdisp.c (pos_visible_p): If already at a newline from the
272 display string before the 'while' loop, don't walk back the glyphs
273 from it3.glyph_row. Solves assertion violation when the display
274 string begins with a newline (egg.el). (Bug#11367)
275
b593d6a9
AH
2762012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
277
278 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
279 Move to simple.el.
280
4737362e
GM
2812012-05-01 Glenn Morris <rgm@gnu.org>
282
99cf43f9
GM
283 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
284 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
285 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
286 All were removed before 23.1.
287
9311dcff
GM
288 * dispnew.c: Remove HAVE_LIBNCURSES test;
289 it is always true on relevant platforms.
290
4d5c6349
GM
291 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
292 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
293
4737362e
GM
294 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
295
74dd3a6b
AS
2962012-04-30 Andreas Schwab <schwab@linux-m68k.org>
297
298 * .gdbinit (xpr): Remove checks for no longer existing misc types.
299 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
300 Remove.
301
13c379ee
PE
3022012-04-28 Paul Eggert <eggert@cs.ucla.edu>
303
304 Do not avoid creating empty evaporating overlays (Bug#9642).
305 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
306 That is, do not delete an evaporating overlay if it becomes
307 empty after its bounds are adjusted to fit within its buffer.
308 This fix caused other problems, and I'm reverting it until we get
309 to the bottom of them.
310
a8e7d6d7 3112012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
312
313 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
314
a8e7d6d7 3152012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
316
317 * xdisp.c (pos_visible_p): If the window start position is beyond
318 ZV, start the display from buffer beginning. Prevents assertion
319 violation in init_iterator when the minibuffer window is scrolled
320 via the scroll bar.
321
322 * window.c (window_scroll_pixel_based): Likewise.
323
a8e7d6d7 3242012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
325
326 * keymap.c (where_is_internal): Doc fix (Bug#10872).
327
a8e7d6d7 3282012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
329
330 * fileio.c (Fcopy_file, Fset_file_selinux_context):
331 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
332
a8e7d6d7 3332012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 334
b593d6a9
AH
335 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
336 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 337
1c6900d9
EZ
3382012-04-26 Eli Zaretskii <eliz@gnu.org>
339
4c3fa1d9
EZ
340 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
341 display element, check also the underlying string or buffer
342 character. (Bug#11341)
343
1c6900d9
EZ
344 * w32menu.c: Include w32heap.h.
345 (add_menu_item): If the call to AppendMenuW (via
346 unicode_append_menu) fails, disable Unicode menus only if we are
347 running on Windows 9X/Me.
348
42bf8205
AS
3492012-04-24 Andreas Schwab <schwab@linux-m68k.org>
350
351 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
352 (xgetint): Add missing shift for LSB tags.
353
b1bac16e
MR
3542012-04-24 Martin Rudalics <rudalics@gmx.at>
355
356 * keyboard.c (read_char): Don't wipe echo area for select window
357 events: These might get delayed via `mouse-autoselect-window'
358 (Bug#11304).
359
d69621cc
JB
3602012-04-24 Juanma Barranquero <lekktu@gmail.com>
361
362 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
363 manipulation of :loaded-from data.
364
02fd101b
JB
3652012-04-23 Juanma Barranquero <lekktu@gmail.com>
366
367 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
368 now a cons (bug#11311).
369
888bec30
PE
3702012-04-23 Paul Eggert <eggert@cs.ucla.edu>
371
89a438bd
PE
372 Do not create empty overlays with the evaporate property (Bug#9642).
373 * buffer.c (Fmove_overlay): Delete an evaporating overlay
374 if it becomes empty after its bounds are adjusted to fit within
375 its buffer. Without this fix, in a nonempty buffer (let ((o
376 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
377 yields an empty overlay that has the evaporate property, which is
378 not supposed to happen.
379
1068fe4d
PE
380 Fix minor GTK3 problems found by static checking.
381 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
382 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
383 (struct _EmacsFixedClass, emacs_fixed_get_type):
384 Move decls here from emacsgtkfixed.h, since they needn't be public.
385 (emacs_fixed_get_type): Now static.
386 (emacs_fixed_class_init): Omit unused local.
387 (emacs_fixed_child_type): Remove; unused.
388 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
389 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
390 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
391 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
392 (EMACS_FIXED_GET_CLASS): Remove; unused.
393 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
394
888bec30
PE
395 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
396 Problem reported by Juanma Barranquero for Windows -Wunused-function.
397
de85e130
PE
3982012-04-22 Paul Eggert <eggert@cs.ucla.edu>
399
d0baac98
PE
400 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
401 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
402 (__malloc_size_t, __malloc_ptrdiff_t):
403 Remove. All uses removed, replaced by the definiens if needed,
404 since we can assume C89 or better now.
405 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
406 (protect_malloc_state, align, get_contiguous_space)
407 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
408 (malloc_atfork_handler_child, malloc_enable_thread)
409 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
410 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
411 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
412 (special_realloc, _realloc_internal_nolock, _realloc_internal)
413 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
414 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
415 Define using prototypes, not old style.
416 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
417 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
418 (align): Don't assume that signed integer overflow wraps around.
419 Omit unused local var.
420 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
421 (_free_internal_nolock, memalign, mallochook, reallochook):
422 Omit no-longer-needed casts.
423 (valloc): Use getpagesize, not __getpagesize.
424 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
425 (struct hdr): The 'magic' member is now size_t, not unsigned long.
426
de85e130
PE
427 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
428
dcbf5805
MA
4292012-04-22 Michael Albinus <michael.albinus@gmx.de>
430
431 Move functions from C to Lisp. Make non-blocking method calls
432 the default. Implement further D-Bus standard interfaces.
433
434 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
435 (QCdbus_request_name_allow_replacement)
436 (QCdbus_request_name_replace_existing)
437 (QCdbus_request_name_do_not_queue)
438 (QCdbus_request_name_reply_primary_owner)
439 (QCdbus_request_name_reply_in_queue)
440 (QCdbus_request_name_reply_exists)
441 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
442 (QCdbus_registered_serial, QCdbus_registered_method)
443 (QCdbus_registered_signal): New Lisp objects.
444 (XD_DEBUG_MESSAGE): Use sizeof.
445 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
446 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
447 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
448 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
449 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
450 (xd_signature, xd_append_arg): Allow float for integer types.
451 (xd_get_connection_references): New function.
b593d6a9
AH
452 (xd_get_connection_address): Rename from xd_initialize.
453 Return cached address.
dcbf5805
MA
454 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
455 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
456 level.
457 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 458 Return number of refcounts.
dcbf5805
MA
459 (Fdbus_get_unique_name): Make stronger parameter check.
460 (Fdbus_message_internal): New defun.
461 (Fdbus_call_method, Fdbus_call_method_asynchronously)
462 (Fdbus_method_return_internal, Fdbus_method_error_internal)
463 (Fdbus_send_signal, Fdbus_register_service)
464 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
465 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
466 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
467 (Vdbus_compiled_version, Vdbus_runtime_version)
468 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
469 (Vdbus_message_type_method_return, Vdbus_message_type_error)
470 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
471 (Vdbus_registered_buses, Vdbus_registered_objects_table):
472 Adapt docstring.
dcbf5805 473
52828e02
PE
4742012-04-22 Paul Eggert <eggert@cs.ucla.edu>
475
da05bc4c
PE
476 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
477 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
478 Do not assume ptrdiff_t is the same width as 'int'.
479
52828e02
PE
480 * alloc.c: Handle unusual debugging option combinations.
481 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
482 since the two debugging options are incompatible.
483 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
484 is defined.
485 (mem_init, mem_insert, mem_insert_fixup):
486 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
487 (NEED_MEM_INSERT): Remove; no longer needed.
488
f01769f9
LL
4892012-04-22 Leo Liu <sdl.web@gmail.com>
490
491 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
492
5790543d
PE
4932012-04-22 Paul Eggert <eggert@cs.ucla.edu>
494
495 * sysdep.c [__FreeBSD__]: Minor cleanups.
496 (list_system_processes, system_process_attributes) [__FreeBSD__]:
497 Use Emacs indenting style more consistently. Avoid some casts.
498 Use 'double' consistently rather than mixing 'float' and 'double'.
499
b91b7e4d
EW
5002012-04-21 Eduard Wiebe <usenet@pusto.de>
501
b593d6a9
AH
502 * sysdep.c (list_system_processes, system_process_attributes):
503 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 504
6114eb15
AS
5052012-04-21 Andreas Schwab <schwab@linux-m68k.org>
506
507 * lisp.mk (lisp): Update.
508
2f38dff7
PE
5092012-04-20 Paul Eggert <eggert@cs.ucla.edu>
510
511 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
512 It is never used otherwise.
513
4ae29f89
SM
5142012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
515
516 * print.c (print_preprocess): Only check print_depth if print-circle
517 is nil.
518 (print_object): Check for cycles even when print-circle is nil and
519 print-gensym is t, but only check print_depth if print-circle is nil.
520
f30d612a
CY
5212012-04-20 Chong Yidong <cyd@gnu.org>
522
523 * process.c (wait_reading_process_output): If EIO occurs on a pty,
524 set the status to "failed" and ensure that sentinel is run.
525
c07a4c0b 5262012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
527
528 * process.c (Fset_process_inherit_coding_system_flag)
529 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 530 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 531
c07a4c0b 5322012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
533
534 * xdisp.c (string_buffer_position_lim): Limit starting position to
535 BEGV.
536 (set_cursor_from_row): If called for a mode-line or header-line
537 row, return zero immediately.
538 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
539 farther than the first row after the header line, if any.
540 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
541 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
542
c07a4c0b 5432012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 544
4ae29f89
SM
545 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
546 (bug#11238).
ad3a2b41 547
c07a4c0b 5482012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 5492012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
550
551 configure: new option --enable-gcc-warnings (Bug#11207)
552 * Makefile.in (C_WARNINGS_SWITCH): Remove.
553 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
554 (ALL_CFLAGS): Use new macros rather than old.
555 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
556 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
557 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
558 -Wunused-result, -Wunused-variable. This should go away once
559 the Emacs and Gnulib regex code is merged.
560 (xmalloc, xrealloc): Now static.
561
aba027e8
PE
5622012-04-17 Paul Eggert <eggert@cs.ucla.edu>
563
564 * dired.c (Fsystem_groups): Remove unused local.
565
e5a36063
GM
5662012-04-17 Glenn Morris <rgm@gnu.org>
567
568 * dired.c (Fsystem_users): Doc fix.
569
316411f0
DA
5702012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
571
572 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
573 (syms_of_dired): Add them.
574
9426aba4
PE
5752012-04-16 Paul Eggert <eggert@cs.ucla.edu>
576
b62a57be
PE
577 Fix minor alloc.c problems found by static checking.
578 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
579 New extern decls, to avoid calling undeclared functions.
580 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
581 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
582 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
583 (NEED_MEM_INSERT): New macro.
584 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 585 Remove one incorrect comment and fix another.
b62a57be 586
3539f31f
PE
587 Fix minor ralloc.c problems found by static checking.
588 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
589 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
590 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
591 (r_alloc_sbrk): Now static.
592
a041960a
PE
593 Improve ralloc.c interface checking.
594 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
595 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
596 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
597 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
598 [REL_ALLOC]: ... to here, to check interface.
599 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
600 Remove decls. This fixes an "It stinks!".
601
9426aba4
PE
602 * alloc.c (which_symbols): Fix alignment issue / type clash.
603
d55c12ed
AS
6042012-04-15 Andreas Schwab <schwab@linux-m68k.org>
605
606 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
607 (struct Lisp_Misc_Any): Likewise.
608 (struct Lisp_Free): Likewise.
609 * alloc.c (union aligned_Lisp_Symbol): Define.
610 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
611 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
612 (union aligned_Lisp_Misc): Define.
613 (MARKER_BLOCK_SIZE, struct marker_block): Use union
614 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 615 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 616
b948ce8b
PE
6172012-04-14 Paul Eggert <eggert@cs.ucla.edu>
618
619 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
620 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
621 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
622 * s/netbsd.h, s/sol2-6.h:
623 Remove definition of GC_MARK_STACK, since the default now works.
624 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
625 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
626 no longer the default.
627 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
628
35dc09a1 6292012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 630
35dc09a1
GM
631 * lread.c (lisp_file_lexically_bound_p):
632 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 633
35dc09a1
GM
6342012-04-14 Eli Zaretskii <eliz@gnu.org>
635
636 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
637 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
638
6392012-04-14 Jan Djärv <jan.h.d@swipnet.se>
640
641 * nsterm.m (constrainFrameRect): Always constrain when there is only
642 one screen (Bug#10962).
643
bcd86815
KB
6442012-04-13 Ken Brown <kbrown@cornell.edu>
645
646 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
647
c25df26e
RT
6482012-04-13 Reuben Thomas <rrt@sc3d.org>
649
650 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
651
0fc59f1e
DC
6522012-04-11 Daniel Colascione <dancol@dancol.org>
653
654 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
655 against is gone. It's better to use vfork now so that when Cygwin
656 gains a new, working vfork, we use it automatically (bug#10398).
657
de8c03dc
SM
6582012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
659
660 * window.c (save_window_save): Obey window-point-insertion-type.
661
2f097256
GM
6622012-04-11 Glenn Morris <rgm@gnu.org>
663
664 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
665
453b951e
SM
6662012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
667
668 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
669
75f1671a 6702012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
671
672 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
673 (force_quit_count): New var.
674 (handle_interrupt): Use it.
675
2a8ce227
JB
6762012-04-10 Juanma Barranquero <lekktu@gmail.com>
677
678 * w32.c (w32_delayed_load): Record the full path of the library
679 being loaded (bug#10424).
680
935396c0
GM
6812012-04-09 Glenn Morris <rgm@gnu.org>
682
05920a43
GM
683 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
684 not just in the obarray, before snarfing them. (Bug#11036)
685
935396c0
GM
686 * Makefile.in ($(leimdir)/leim-list.el):
687 Pass EMACS rather than BUILT_EMACS.
688
a18ecafa
TZ
6892012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
690
691 * process.c (make_process):
692 * process.h: Add integer `gnutls_handshakes_tried' member to
693 process struct.
694
6bbef4e5
JC
695 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
696 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
697
698 * gnutls.c (gnutls_log_function2i): Convenience log function.
699 (emacs_gnutls_read): Use new log functions,
700 `gnutls_handshakes_tried' process member, and
701 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
702 attempts per process (connection).
703
b4d3bc10
CY
7042012-04-09 Chong Yidong <cyd@gnu.org>
705
706 * eval.c (Fuser_variable_p, user_variable_p_eh)
707 (lisp_indirect_variable): Functions deleted.
708 (Fdefvar): Caller changed.
709
710 * callint.c (Finteractive, Fcall_interactively):
711 * minibuf.c (Fread_variable): Callers changed.
712
70f4d973
EZ
7132012-04-09 Eli Zaretskii <eliz@gnu.org>
714
715 * xdisp.c (set_cursor_from_row): If the display string appears in
716 the buffer at position that is closer to point than the position
717 after the display string, display the cursor on the first glyph of
718 the display string. Fixes cursor display when a 'display' text
719 property immediately follows invisible text. (Bug#11094)
720
cb3c2e3e
PE
7212012-04-09 Paul Eggert <eggert@cs.ucla.edu>
722
723 composite.c: use 'double' consistently
724 * composite.c (get_composition_id): Use 'double' consistently
725 instead of converting 'float' to 'double' and vice versa; this is
726 easier to understand and avoids a GCC warning.
727
fd06db5d
GM
7282012-04-09 Glenn Morris <rgm@gnu.org>
729
50fe702a
GM
730 * Makefile.in: Generate leim-list with bootstrap-emacs, in
731 preparation for dumping it with emacs. (Bug#4789)
732 (leimdir): New variable.
733 ($(leimdir)/leim-list.el): New rule.
734 (emacs$(EXEEXT)): Depend on leim-list.el.
735
fd06db5d
GM
736 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
737 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
738 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
739
55c131ee
AS
7402012-04-08 Andreas Schwab <schwab@linux-m68k.org>
741
742 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
743 proper alignment.
744
9209588f
JB
7452012-04-07 Juanma Barranquero <lekktu@gmail.com>
746
747 * xml.c (init_libxml2_functions) [WINDOWSNT]:
748 Remove unused local variable.
749
e3fb2efb
PE
7502012-04-07 Paul Eggert <eggert@cs.ucla.edu>
751
752 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
753 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
754 (mark_memory): Mark Lisp_Objects only if pointers might hide in
755 objects, as mark_maybe_pointer will catch them otherwise.
756 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
757 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
758
b5385551
PE
7592012-04-07 Paul Eggert <eggert@cs.ucla.edu>
760
761 Fix typo that broke non-Windows builds.
762 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
763
9078ead6
EZ
7642012-04-07 Eli Zaretskii <eliz@gnu.org>
765
766 Support building on MS-Windows with libxml2.
767
768 * makefile.w32-in (OBJ2): Add xml.$(O).
769 (GLOBAL_SOURCES): Add xml.c.
770 ($(BLD)/xml.$(O)): New dependency list.
771
772 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
773 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
774 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
775 [!WINDOWSNT]: New macros.
776 (init_libxml2_functions, libxml2_loaded_p): New functions.
777 (parse_region): Call fn_xmlCheckVersion instead of using the macro
778 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
779 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
780 Calls xmlCleanupParser only if libxml2 was loaded (or statically
781 linked in).
6bbef4e5
JC
782 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
783 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
784 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
785
786 * emacs.c: Don't include libxml/parser.h.
787 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
788 xmlCleanupParser directly.
789
790 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
791
3811fdf3
EZ
7922012-04-07 Eli Zaretskii <eliz@gnu.org>
793
794 * indent.c (Fvertical_motion): If there is a display string at
795 point, use it.vpos to compute how many lines to backtrack after
796 move_it_to point. (Bug#11133)
797
2f8e16b2
EZ
7982012-04-06 Eli Zaretskii <eliz@gnu.org>
799
800 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
801 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
802 about subtle differences between FETCH_CHAR* and STRING_CHAR*
803 macros related to unification of CJK characters. For the details,
804 see the discussion following the message here:
805 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
806
3d439cd1
CY
8072012-04-04 Chong Yidong <cyd@gnu.org>
808
809 * keyboard.c (Vdelayed_warnings_list): Doc fix.
810
8bc53d00
EZ
8112012-04-01 Eli Zaretskii <eliz@gnu.org>
812
813 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
814 instead of alloca. (Bug#11138)
815
3b0512a3
AS
8162012-04-01 Andreas Schwab <schwab@linux-m68k.org>
817
818 * w32menu.c (is_simple_dialog): Properly check lisp types.
819 (Bug#11141)
820
8427ddd2
EZ
8212012-03-31 Eli Zaretskii <eliz@gnu.org>
822
979022ef
EZ
823 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
824 position we get to after a call to move_it_to fails the
825 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
826 only if we wind up in a string from display property. (Bug#11063)
827
a6b1c7cc
EZ
828 * window.c (Fdelete_other_windows_internal): Invalidate the row
829 and column information about mouse highlight, so that redisplay
830 restores it after reallocating the glyph matrices. (Bug#7464)
831
8427ddd2
EZ
832 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
833 string comes from a `display' text property, use the buffer
834 position of that property as if we actually saw that position in
835 the row's glyphs.
697ba24b
EZ
836 (move_it_by_lines): Remove the assertion that
837 "it->current_x == 0 && it->hpos == 0" which can be legitimately
838 violated when there's a before-string at the beginning of a line.
839 (Bug#11063)
8427ddd2 840
65a0a738
EZ
8412012-03-30 Eli Zaretskii <eliz@gnu.org>
842
843 * xdisp.c (append_space_for_newline): If the default face was
844 remapped, use the remapped face for the appended newline.
845 (extend_face_to_end_of_line): Use the remapped default face for
846 extending the face to the end of the line.
847 (display_line): Call extend_face_to_end_of_line when the default
848 face was remapped. (Bug#11068)
849
581355cc
EZ
8502012-03-29 Eli Zaretskii <eliz@gnu.org>
851
852 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
853
e8fc049f
SM
8542012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
855
856 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
857
4fb9a543
GM
8582012-03-27 Glenn Morris <rgm@gnu.org>
859
860 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
861 Doc fixes.
862
679910f1
KH
8632012-03-26 Kenichi Handa <handa@m17n.org>
864
865 * dispextern.h (struct glyph): Fix previous change. Change the
866 bit length of glyphless.ch to 25 (Bug#11082).
867
90d49b7f
CY
8682012-03-26 Chong Yidong <cyd@gnu.org>
869
870 * keyboard.c (Vselection_inhibit_update_commands): New variable.
871 (command_loop_1): Use it; inhibit selection update for
872 handle-select-window too (Bug#8996).
873
f514f6f0
FP
8742012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
875
e8fc049f 876 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 877
bf43fa51
KH
8782012-03-25 Kenichi Handa <handa@m17n.org>
879
880 * dispextern.h (struct glyph): Change the bit length of
881 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
882
8a0c01dd
EZ
8832012-03-24 Eli Zaretskii <eliz@gnu.org>
884
885 * s/ms-w32.h (tzname): Include time.h before redirecting to
886 _tzname. Fixes the MSVC build. (Bug#9960)
887
7d1c3a76
AS
8882012-03-24 Andreas Schwab <schwab@linux-m68k.org>
889
8ed79523
AS
890 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
891 characters.
892
7d1c3a76
AS
893 * xterm.c (XTread_socket): Only modify handling_signal if
894 !SYNC_INPUT. (Bug#11080)
895
e99a9b8b
EZ
8962012-03-23 Eli Zaretskii <eliz@gnu.org>
897
898 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
899 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
900 when fetching a multibyte character consumes more bytes than
901 CHAR_BYTES returns, due to unification of CJK characters in
902 string_char. (Bug#11073)
903
5063c0e1
TN
9042012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
905
906 * process.c (wait_reading_process_output): Handle pty disconnect
907 by refraining from sending oneself a SIGCHLD (bug#10933).
908
9f851fbd
CY
9092012-03-22 Chong Yidong <cyd@gnu.org>
910
911 * dispextern.h (struct it): New member string_from_prefix_prop_p.
912
5063c0e1 913 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
914 Mark string as coming from a prefix property.
915 (handle_face_prop): Use default face for prefix strings (Bug#4281).
916 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
917
fb5b8aca
CY
9182012-03-21 Chong Yidong <cyd@gnu.org>
919
920 * xfaces.c (Vface_remapping_alist): Doc fix.
921
62356a1b
EZ
9222012-03-20 Eli Zaretskii <eliz@gnu.org>
923
924 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
925 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
926 Doc fixes.
62356a1b 927
025de85b
CY
9282012-03-20 Chong Yidong <cyd@gnu.org>
929
930 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
931 to reflect default non-nil value of redisplay-dont-pause.
932
4827f94e
KH
9332012-03-19 Kenichi Handa <handa@m17n.org>
934
935 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
936 it fit in a valid range (Bug#11003).
937
e50a24a2
EZ
9382012-03-18 Eli Zaretskii <eliz@gnu.org>
939
940 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
941 that is not from display property, accept the row as a "cursor
942 row" if one of the string's character has a non-nil `cursor'
943 property. Fixes cursor positioning when there are newlines in
944 overlay strings, e.g. in icomplete.el. (Bug#11035)
945
9af5ed87
PE
9462012-03-12 Paul Eggert <eggert@cs.ucla.edu>
947
948 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
949
d1f55f16
CY
9502012-03-12 Chong Yidong <cyd@gnu.org>
951
952 * eval.c (inhibit_lisp_code): Rename from
953 inhibit_window_configuration_change_hook; move from window.c.
954
955 * xfns.c (unwind_create_frame_1, Fx_create_frame):
956 * window.c (run_window_configuration_change_hook)
957 (syms_of_window): Callers changed.
958
66c5eebd
CY
9592012-03-11 Chong Yidong <cyd@gnu.org>
960
413df973
CY
961 * keymap.c (Fkey_description): Doc fix (Bug#9700).
962
66c5eebd
CY
963 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
964
1de11f56
CY
9652012-03-10 Chong Yidong <cyd@gnu.org>
966
967 * frame.c (other_visible_frames): Don't assume the selected frame
968 is visible (Bug#10955).
969
cae07000
SM
9702012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
971
972 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
973
89c94350
JD
9742012-03-08 Jan Djärv <jan.h.d@swipnet.se>
975
976 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
977 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
978 zero (Bug#10954).
979
999dd333
GM
9802012-03-03 Glenn Morris <rgm@gnu.org>
981
01a6dcc8 982 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 983
de0100f2
EZ
9842012-03-02 Eli Zaretskii <eliz@gnu.org>
985
986 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
987 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
988 (redisplay_window, next_element_from_string): Fix typos in
989 comments.
3e441275
EZ
990 (redisplay_window): Pass to move_it_vertically the margin in
991 pixels, not in screen lines.
de0100f2 992
96a72ee9
GM
9932012-03-02 Glenn Morris <rgm@gnu.org>
994
995 * buffer.c (buffer-list-update-hook): Doc fix.
996
312508d7
EZ
9972012-02-29 Eli Zaretskii <eliz@gnu.org>
998
999 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
1000 push_it before setting up the iterator for the first overlay
1001 string, even if we have an empty string loaded.
1002 (next_overlay_string): If there's an empty string on the iterator
1003 stack, pop the stack. (Bug#10903)
1004
27f3c637
PE
10052012-02-25 Paul Eggert <eggert@cs.ucla.edu>
1006
1007 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
1008 Suggested by Stefan Monnier in
1009 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
1010 * alloc.c (widen_to_Lisp_Object): New static function.
1011 (mark_memory): Also mark Lisp_Objects by fetching pointer words
1012 and widening them to Lisp_Objects. This would work even if
1013 USE_LSB_TAG is defined and wide integers are used, which might
1014 happen in a future version of Emacs.
1015
3c9dfce6
CY
10162012-02-25 Chong Yidong <cyd@gnu.org>
1017
fa74b241
CY
1018 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1019 Doc fix.
1020
3c9dfce6
CY
1021 * xselect.c (Fx_selection_exists_p): Doc fix.
1022 (x_clipboard_manager_save_all): Print an informative message
1023 before saving to clipboard manager.
1024
9486df08
CY
10252012-02-24 Chong Yidong <cyd@gnu.org>
1026
1027 * keyboard.c (process_special_events): Handle all X selection
1028 requests in kbd_buffer, not just the next one (Bug#8869).
1029
f01d3321
CY
10302012-02-23 Chong Yidong <cyd@gnu.org>
1031
1032 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1033 call when setting menu-bar-lines and tool-bar-lines parameters.
1034 (unwind_create_frame_1): New helper function.
1035
1036 * window.c (inhibit_window_configuration_change_hook): New var.
1037 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 1038 (syms_of_window): Initialize it.
f01d3321 1039
86b847b6
CY
10402012-02-22 Chong Yidong <cyd@gnu.org>
1041
1042 * xterm.c (x_draw_image_relief): Add missing type check for
1043 Vtool_bar_button_margin (Bug#10743).
1044
a59225b1
CY
10452012-02-21 Chong Yidong <cyd@gnu.org>
1046
1047 * fileio.c (Vfile_name_handler_alist): Doc fix.
1048
1049 * buffer.c (Fget_file_buffer): Protect against invalid file
1050 handler return value.
1051
310f5bd4
PE
10522012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1053
cb3a28cc
PE
1054 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
1055 when computing $valmask.
1056
310f5bd4
PE
1057 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
1058 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
1059 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
1060 It's useless in that case, and it can cause problems on hosts
1061 that allocate halves of EMACS_INT values separately.
1062 Reported by Dan Horák. Diagnosed by Andreas Schwab in
1063 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
1064 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
1065 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
1066 it avoids undefined behavior on hosts where shifting right by more
1067 than the word width has undefined behavior.
1068
2375c96a
CY
10692012-02-19 Chong Yidong <cyd@gnu.org>
1070
1071 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1072 (Funhandled_file_name_directory, Ffile_name_as_directory)
1073 (Fdirectory_file_name, Fexpand_file_name)
1074 (Fsubstitute_in_file_name): Protect against invalid file handler
1075 return values (Bug#10845).
1076
3eb49e71
EZ
10772012-02-18 Eli Zaretskii <eliz@gnu.org>
1078
1079 * .gdbinit (pitx): Fix incorrect references to fields of the
1080 iterator stack.
1081
7b926f3f
CY
10822012-02-17 Chong Yidong <cyd@gnu.org>
1083
1084 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1085
11273115
PE
10862012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1087
1088 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1089 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1090
c3a70e2b
CY
10912012-02-15 Chong Yidong <cyd@gnu.org>
1092
1093 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1094 marked as special. Also, starting docstrings with * is obsolete.
1095
0ca43699
AS
10962012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1097
1098 * gnutls.c (emacs_gnutls_write): Fix last change.
1099
2e8f3c56
LI
11002012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1101
1102 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1103 send_process.
1104
af70074f
SM
11052012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1106
1107 * keymap.c (Fsingle_key_description): Handle char ranges.
1108
95986d52
CY
11092012-02-12 Chong Yidong <cyd@gnu.org>
1110
afd83bd1
CY
1111 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1112 as that creates a dangerous corner case.
1113
95986d52
CY
1114 * window.c (Fdelete_window_internal): Invalidate the mouse
1115 highlight (Bug#9904).
1116
bd7da63e
GM
11172012-02-12 Glenn Morris <rgm@gnu.org>
1118
1119 * xselect.c (Fx_own_selection_internal)
1120 (Fx_get_selection_internal, Fx_disown_selection_internal)
1121 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1122 * nsselect.m (Fx_own_selection_internal)
1123 (Fx_disown_selection_internal, Fx_selection_exists_p)
1124 (Fx_selection_owner_p, Fx_get_selection_internal):
1125 Sync docs and argument specs with the xselect.c versions.
1126
77abcbc2
LI
11272012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1128
1129 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1130
90b671e2
EZ
11312012-02-11 Eli Zaretskii <eliz@gnu.org>
1132
1c0ca0b7
EZ
1133 * w32select.c (Fx_selection_exists_p): Sync doc string and
1134 argument list with xselect.c. (Bug#10783)
1135
1136 * w16select.c (Fx_selection_exists_p): Sync doc string and
1137 argument list with xselect.c. (Bug#10783)
90b671e2 1138
49241268
GM
11392012-02-10 Glenn Morris <rgm@gnu.org>
1140
1141 * fns.c (Fsecure_hash): Doc fix.
1142
f998bbe7 11432012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
1144
1145 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
1146
0992bd9c
CY
11472012-02-07 Chong Yidong <cyd@gnu.org>
1148
1149 * buffer.c (Fbuffer_local_variables)
1150 (buffer_lisp_local_variables): Handle unbound vars correctly;
1151 don't let Qunbound leak into Lisp.
1152
af008560
GM
11532012-02-07 Glenn Morris <rgm@gnu.org>
1154
dd605cc4
GM
1155 * image.c (Fimagemagick_types): Doc fix.
1156
af008560
GM
1157 * image.c (imagemagick-render-type): Change it from a lisp object
1158 to an integer. Move the doc here from the lisp manual.
1159 Treat all values not equal to 0 the same.
1160
1449fa1d
CY
11612012-02-06 Chong Yidong <cyd@gnu.org>
1162
1163 * doc.c (store_function_docstring): Avoid applying docstring of
1164 alias to base function (Bug#2603).
1165
3723ec07
AS
11662012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1167
1168 * .gdbinit (pp1, pv1): Remove redundant defines.
1169 (pr): Use pp.
1170
79c1cc1e
CY
11712012-02-04 Chong Yidong <cyd@gnu.org>
1172
1173 * nsterm.m: Declare a global (Bug#10694).
1174
d7f29f8e
EZ
11752012-02-04 Eli Zaretskii <eliz@gnu.org>
1176
cae07000
SM
1177 * w32.c (get_emacs_configuration_options):
1178 Include --enable-checking, if specified, in the return value.
d7f29f8e 1179
3b95a6f9
MR
11802012-02-04 Martin Rudalics <rudalics@gmx.at>
1181
1182 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1183 after rounding frame sizes. (Bug#9723)
1184
d6fa96a6
EZ
11852012-02-04 Eli Zaretskii <eliz@gnu.org>
1186
1187 * keyboard.c (adjust_point_for_property): Don't position point
1188 before BEGV. (Bug#10696)
1189
df0b2940
PE
11902012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1191
1192 Handle overflow when computing char display width (Bug#9496).
1193 * character.c (char_width): Return EMACS_INT, not int.
1194 (char_width, c_string_width): Check for overflow when
1195 computing the width; this is possible now that individual
1196 characters can have unbounded width. Problem introduced
1197 by merge from Emacs 23 on 2012-01-19.
1198
6bee44d6
MA
11992012-02-02 Michael Albinus <michael.albinus@gmx.de>
1200
1201 * dbusbind.c (Fdbus_register_method): Mention the return value
1202 :ignore in the docstring.
1203
44f92739
GM
12042012-02-02 Glenn Morris <rgm@gnu.org>
1205
1b9f60cc
GM
1206 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1207
44f92739
GM
1208 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1209 Unconditionally set to t. (Bug#10673)
1210 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1211 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1212 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1213
c5d3843c
KH
12142012-02-02 Kenichi Handa <handa@m17n.org>
1215
1216 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1217 0, do not call append_composite_glyph.
1218
159462d4 12192012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
1220
1221 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1222 NULL (Bug#6988).
1223 (x_produce_glyphs): If the component of a composition is a null
1224 string, set it->pixel_width to 1 to avoid zero-width glyph.
1225
78cef877
EZ
12262012-02-01 Eli Zaretskii <eliz@gnu.org>
1227
1228 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1229 first 2 arguments are identical. This makes inserting large
1230 output from a subprocess an order of magnitude faster on
1231 MS-Windows, where all sbrk'ed memory is always contiguous.
1232
97897668
GM
12332012-01-31 Glenn Morris <rgm@gnu.org>
1234
1235 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 1236 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
1237 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1238
31fd3586
GM
12392012-01-29 Glenn Morris <rgm@gnu.org>
1240
1241 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1242
0e24a8b2
CY
12432012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1244
1245 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1246
cc0adcb0
CY
12472012-01-28 Chong Yidong <cyd@gnu.org>
1248
1249 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1250
acc28cb9
CY
12512012-01-26 Chong Yidong <cyd@gnu.org>
1252
9c69cfb7
CY
1253 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1254
acc28cb9
CY
1255 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1256 repeat counts (Bug#10507).
1257
48da7392
GM
12582012-01-26 Glenn Morris <rgm@gnu.org>
1259
1260 * lread.c (syms_of_lread): Doc fix.
1261
14af5f7f
CY
12622012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1263
1264 * coding.c (encode_designation_at_bol): Change return value to
1265 EMACS_INT.
1266
0b21c100
CY
12672012-01-25 Chong Yidong <cyd@gnu.org>
1268
1269 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1270
3c2907f7
CY
12712012-01-21 Chong Yidong <cyd@gnu.org>
1272
1273 * floatfns.c (Fcopysign): Make the second argument non-optional,
1274 since nil is not allowed anyway.
1275
959ad23f
AS
12762012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1277
1278 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1279 (send_process): Likewise.
1280
34a02f46
MR
12812012-01-19 Martin Rudalics <rudalics@gmx.at>
1282
1283 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
1284 (Vwindow_persistent_parameters): Do not use Qstate.
1285 Rewrite doc-strings.
34a02f46 1286
1259009a 12872012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
1288
1289 * character.c (char_width): New function.
70d4fdf6
GM
1290 (Fchar_width, c_string_width, lisp_string_width):
1291 Use char_width (Bug#9496).
25ed9e61 1292
6a6ee00d
MR
12932012-01-16 Martin Rudalics <rudalics@gmx.at>
1294
1295 * window.c (Vwindow_persistent_parameters): New variable.
1296 (Fset_window_configuration, save_window_save): Handle persistent
1297 window parameters.
1298
c85efaf7
EZ
12992012-01-14 Eli Zaretskii <eliz@gnu.org>
1300
1301 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1302 thrashing the stack of the thread. (Bug#9087)
1303
5944709e
PE
13042012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1305
1306 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1307
e71f5d99
EZ
13082012-01-11 Eli Zaretskii <eliz@gnu.org>
1309
1310 * xdisp.c (rows_from_pos_range): Handle the case where the
1311 highlight ends on a newline. (Bug#10464)
1312 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1313 he end column for display of highlight that ends on a newline
1314 before a R2L line.
1315
ce316182
GM
13162012-01-11 Glenn Morris <rgm@gnu.org>
1317
1318 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1319 from load-path also when installation-directory is nil. (Bug#10208)
1320
5b43da69
GM
13212012-01-10 Glenn Morris <rgm@gnu.org>
1322
74cc8ff9
GM
1323 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1324
7d8d6e4e
GM
1325 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1326 Update template values to be closer to their typical values these days.
5b43da69 1327
a0db8d43
EZ
13282012-01-09 Eli Zaretskii <eliz@gnu.org>
1329
1330 * xdisp.c (rows_from_pos_range): Accept additional argument
1331 DISP_STRING, and accept any glyph in a row whose object is that
1332 string as eligible for mouse highlight. Fixes mouse highlight of
1333 display strings from overlays. (Bug#10464)
1334
9a0115ab 13352012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 1336
b9110d6a 1337 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
1338 * fileio.c (auto_saving_dir_umask): New static var.
1339 (Fmake_directory_internal): Use it.
1340 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1341 creating the directory. The old code temporarily assigns
1342 too-generous permissions to the directory.
1343 (do_auto_save_eh): Clear it.
b9110d6a 1344 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
1345 that the var is always cleared.
1346
6c1bd3f3
EZ
13472012-01-07 Eli Zaretskii <eliz@gnu.org>
1348
1349 * search.c (scan_buffer): Pass character positions to
1350 know_region_cache, not byte positions. (Bug#6540)
1351
069d2b50
L
13522012-01-07 LynX <_LynX@bk.ru> (tiny change)
1353
1354 * w32.c (sys_rename): Report EXDEV when rename of a directory
1355 fails because the target is on another logical disk. (Bug#10284)
1356
75bf0d33
DB
13572012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1358
1359 * xterm.c (x_embed_request_focus): New function.
1360
1361 * xterm.h: Add prototype.
1362
1363 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1364
1c6e5a32
GM
13652012-01-05 Glenn Morris <rgm@gnu.org>
1366
1367 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1368
651e947e
EZ
13692012-01-01 Eli Zaretskii <eliz@gnu.org>
1370
1371 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1372 Load gnutls_transport_set_lowat only if GnuTLS version is below
1373 2.11.1.
1374 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1375 GnuTLS versions below 2.11.1.
1376
3778cdd8
AL
13772011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1378
1379 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1380 to the doc string advising against its use for altering the way
1381 windows are scrolled.
1382
0e5317f7
KH
13832011-12-28 Kenichi Handa <handa@m17n.org>
1384
1385 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1386 coding-system ASCII compatible only when it does not produce BOM
1387 on encoding (Bug#10383).
1388
93d5ca1f
JD
13892011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1390
1391 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1392 can scroll.
1393 (create_and_show_popup_menu): Always use menu_position_func for
1394 Gtk3 (Bug#10361).
1395
ca22b785
AS
13962011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1397
1398 * callint.c (Fcall_interactively): Don't truncate prompt string.
1399
d048e1e6
EZ
14002011-12-23 Eli Zaretskii <eliz@gnu.org>
1401
1402 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1403 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 1404 resumed from there (after widening). (Bug#10360)
d048e1e6 1405
5ccaba1f
JD
14062011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1407
1408 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1409
204ee57f
JD
14102011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1411
b81d40f0
JB
1412 * nsterm.m (x_free_frame_resources):
1413 Release f->output_data.ns->miniimage.
204ee57f
JD
1414 (ns_index_color): Fix indentation. Do not retain
1415 color_table->colors[i].
1416
1417 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1418 before returning.
1419
1420 * nsfns.m (x_set_background_color): Assign return value from
1421 ns_index_color to face-background instead of NSColor*.
1422 (ns_implicitly_set_icon_type): Fix indentation.
1423 Change assignment in for loop to comparison.
1424
1425 * emacs.c (ns_pool): New variable.
1426 (main): Assign ns_pool.
1427 (Fkill_emacs): Call ns_release_autorelease_pool.
1428
1429 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1430 autorelease fdesc, release fdAttrs and tdict.
1431 (ns_get_covering_families): Release charset.
1432 (ns_findfonts): Release NSFontDescriptor created with new.
1433 (ns_uni_to_glyphs): Fix indentation.
1434 (setString): Release attrStr before assigning new value.
1435
c803b2b7
JD
14362011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1437
678f4426
JD
1438 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1439 and NS_IMPL_COCOA.
1440 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1441 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1442
cd394be1 14432011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1444
5fecd5fc
JD
1445 * nsterm.m (ns_term_init): Subscribe for notifications
1446 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1447 to method trackingNotification in EmacsMenu.
1448
1449 * nsmenu.m (trackingMenu): New variable.
3771cb17 1450 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1451 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1452 from Aquamacs (Bug#7030).
678f4426
JD
1453
14542011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1455
c803b2b7
JD
1456 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1457 (symbol_to_nsstring): Fix indentation.
1458 (ns_symbol_to_pb): New function.
cae07000
SM
1459 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1460 (Fns_rotate_cut_buffers_internal): Remove.
1461 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1462 Fns_store_cut_buffer_internal.
1463 (ns_get_foreign_selection, Fx_own_selection_internal)
1464 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1465 (Fns_get_selection_internal, Fns_store_selection_internal):
1466 Use ns_symbol_to_pb and check if return value is nil.
1467 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1468 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1469 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1470 renamed to Sns_store_selection_internal.
1471 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1472 and remove this function.
1473 (ns_handle_selection_clear): Remove, never used.
1474 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1475 here.
1476
e1b01a3a
KB
14772011-12-17 Ken Brown <kbrown@cornell.edu>
1478
1479 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1480 GID is unknown (Bug#10257).
1481
2adb6e85
PE
14822011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1483
1484 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1485 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1486 which caused a build failure on GNU/Linux IA-64. This problem was
1487 introduced by my 2011-10-07 patch.
1488
d1d7b339
JL
14892011-12-15 Juri Linkov <juri@jurta.org>
1490
1491 * image.c (imagemagick_error): New function. (Bug#10112)
1492 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1493 Use `imagemagick_error' where ImageMagick functions return
1494 `MagickFalse'.
1495 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1496 proper order.
1497
100d5755
KH
14982011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1499
1500 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1501 fill background (Bug#8992).
1502
454592a6
MR
15032011-12-13 Martin Rudalics <rudalics@gmx.at>
1504
1505 * window.c (Vwindow_combination_resize)
1506 (Vwindow_combination_limit): Use t instead of non-nil in
1507 doc-strings.
61d4b438
MR
1508 (Vrecenter_redisplay): Add first sentence of doc-string on
1509 separate line.
53524d93 1510 (Frecenter): Fix doc-string typo.
454592a6 1511
3633e3aa
KH
15122011-12-11 Kenichi Handa <handa@m17n.org>
1513
1514 * coding.c (Funencodable_char_position): Pay attention to the
1515 buffer text relocation (Bug#9389).
1516
7b9d523a
JD
15172011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1518
1519 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1520 gtk_init (Bug#10100).
1521
b73189c6
EZ
15222011-12-10 Eli Zaretskii <eliz@gnu.org>
1523
1524 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1525 IT->string is nil. (Bug#10263)
1526
f7dfe5d6
JD
15272011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1528
83faebb4
JD
1529 * nsterm.h (x_free_frame_resources): Declare.
1530
f7dfe5d6
JD
1531 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1532 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1533
1534 * nsterm.h (ns_get_defaults_value): Declare.
1535
1536 * nsterm.m (ns_default): Call ns_get_defaults_value.
1537
7cd4e72c
EZ
15382011-12-09 Eli Zaretskii <eliz@gnu.org>
1539
1540 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1541 (Bug#10170)
1542
b34d7317
YM
15432011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1544
1545 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1546 that where the value of an _OBJC_* symbol points to is in the .bss
1547 section (Bug#10240).
1548
76470ad1
KH
15492011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1550
1551 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1552 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1553
745fff94
KH
15542011-12-08 Kenichi Handa <handa@m17n.org>
1555
1556 * ftfont.c (get_adstyle_property): Fix previous change
1557 (Bug#10233).
1558
6e44397c
JB
15592011-12-07 Juanma Barranquero <lekktu@gmail.com>
1560
1561 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1562 dirs from the default value of EMACSLOADPATH (bug#10208).
1563
7efa6272
GM
15642011-12-07 Glenn Morris <rgm@gnu.org>
1565
1566 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1567 installation and source directories as well. (Bug#10208)
1568
f6fc4d87
CY
15692011-12-06 Chong Yidong <cyd@gnu.org>
1570
1571 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1572
2bf26180
GM
15732011-12-06 Glenn Morris <rgm@gnu.org>
1574
1575 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1576 as an error, not just -1. (Bug#10217)
1577
3a6ad4f0
CY
15782011-12-05 Chong Yidong <cyd@gnu.org>
1579
1580 * keyboard.c (process_special_events): New function.
1581 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1582
75a3b399
PE
15832011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1584
1585 * coding.c (encode_designation_at_bol): Don't use uninitialized
1586 local variable (Bug#9318).
1587
c3c9e25e
KH
15882011-12-05 Kenichi Handa <handa@m17n.org>
1589
1590 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1591 return Qnil (Bug#8046, Bug#10193).
1592
5eb05ea3
KH
15932011-12-05 Kenichi Handa <handa@m17n.org>
1594
1595 * coding.c (encode_designation_at_bol): New args charbuf_end and
1596 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1597 (coding_set_source): Return how many bytes coding->source was
1598 relocated.
1599 (coding_set_destination): Return how many bytes
1600 coding->destination was relocated.
1601 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1602 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1603
16042011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1605
1606 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1607 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1608 macro (Bug#9318).
1609
16102011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1611
1612 The following changes are to fix Bug#9318.
1613
a79703f5 1614 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1615 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1616 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1617 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1618
7dbda6df
JB
16192011-12-05 Juanma Barranquero <lekktu@gmail.com>
1620
1621 * lisp.h (process_quit_flag): Fix external declaration.
1622
6d5eb5b0
SM
16232011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1624
1625 Don't macro-inline non-performance-critical code.
1626 * eval.c (process_quit_flag): New function.
1627 * lisp.h (QUIT): Use it.
1628
a0c3fad0
JD
16292011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1630
1631 * nsfns.m (get_geometry_from_preferences): New function.
1632 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1633
6c07aac2
AS
16342011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1635
1636 * emacs.c (Qkill_emacs): Define.
1637 (syms_of_emacs): Initialize it.
1638 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1639 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1640 (quit_throw_to_read_char): Add parameter `from_signal'.
1641 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1642 * lisp.h (QUIT): Call Fkill_emacs if requested.
1643
c052ead4
JD
16442011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1645
1646 * widget.c (update_wm_hints): Return if wmshell is null.
1647 (widget_update_wm_size_hints): New function.
1648
1649 * widget.h (widget_update_wm_size_hints): Declare.
1650
1651 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1652 widget_update_wm_size_hints (Bug#10104).
1653
9e49252b
EZ
16542011-12-03 Eli Zaretskii <eliz@gnu.org>
1655
1656 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1657 before a newline, prepare the bidi iterator for consuming the
1658 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1659 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1660
02b16839
JL
16612011-12-02 Juri Linkov <juri@jurta.org>
1662
1663 * search.c (Fword_search_regexp): New Lisp function created from
1664 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1665 (Fword_search_backward, Fword_search_forward)
1666 (Fword_search_backward_lax, Fword_search_forward_lax):
1667 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1668 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1669
0068070e
SM
16702011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1671
1672 * fileio.c (Finsert_file_contents): Move after-change-function call
1673 to before the "handled:" label, since all "goto handled" appear in
1674 cases where the *-change-functions have already been properly called
1675 (bug#10117).
1676
3360a3fc
AS
16772011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1678
1679 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1680 waiting for input. (Bug#10169)
1681
73d6c093
EZ
16822011-11-30 Eli Zaretskii <eliz@gnu.org>
1683
1684 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1685 verifies glyph row's hash code--we have just reallocated the
1686 glyphs, so their contents can be complete garbage. (Bug#10164)
1687
febe6bea
JB
16882011-11-30 Juanma Barranquero <lekktu@gmail.com>
1689
1690 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1691
801a4313
EZ
16922011-11-30 Eli Zaretskii <eliz@gnu.org>
1693
1694 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1695 attributes are tested _before_ calling verify_row_hash, to protect
1696 against GCC re-ordering of the tests. (Bug#10164)
1697
2b56b87e
JD
16982011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1699
1700 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1701
1702 * xterm.c (handle_one_xevent): Only set async_visible and friends
1703 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1704 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1705 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1706
dbf31225
PE
17072011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1708
1709 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1710 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1711 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1712 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1713 All uses changed to use GCPRO1 etc.
1714 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1715 Revert to old implementation (i.e., before 2011-03-11).
1716
1305621b
YM
17172011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1718
1719 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1720 of scroll runs so as to avoid assigning disabled bogus rows and
1721 unnecessary graphics copy operations.
1722
8c9afb46
EZ
17232011-11-27 Eli Zaretskii <eliz@gnu.org>
1724
1725 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1726 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1727 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1728 (malloc, free, realloc, calloc): Redirect to e_* only when
1729 compiling Emacs.
1730
1731 * lisp.h (GCTYPEBITS): Move before first use.
1732 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1733 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1734 this macro definition.
1735
1736 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1737 _MSC_VER.
1738
54e9e3bf
JD
17392011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1740
6d5eb5b0
SM
1741 * gtkutil.c (xg_create_frame_widgets):
1742 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1743 present with Gtk+ 2.0.
1744
83aca1cb
PE
17452011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1746
1747 * fileio.c (Finsert_file_contents): Undo previous change; see
1748 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1749
5b76caa4
PE
17502011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1751
1752 Rename locals to avoid shadowing.
1753 * fileio.c (Finsert_file_contents):
1754 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1755 * process.c (wait_reading_process_output):
1756 Rename inner 'proc' to 'p' to avoid shadowing.
1757 Indent for consistency with usual Emacs style.
1758
8c535114
EZ
17592011-11-25 Eli Zaretskii <eliz@gnu.org>
1760
1761 * xdisp.c (redisplay_window): If cursor row is not fully visible
1762 after recentering, and scroll-conservatively is set to a large
1763 number, scroll window by a few more lines to make the cursor fully
1764 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1765 (start_display): Don't move to the next line if the display should
1766 start at a newline that is part of a display vector or an overlay
1767 string. (Bug#10119)
8c535114 1768
fa4fdb5c
JL
17692011-11-24 Juri Linkov <juri@jurta.org>
1770
1771 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1772 after the `MagickPingImage' call. (Bug#10112)
1773
90ec88df
CY
17742011-11-23 Chong Yidong <cyd@gnu.org>
1775
1776 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1777
56e2e794
MR
17782011-11-23 Martin Rudalics <rudalics@gmx.at>
1779
1780 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1781 making another buffer current. (Bug#10114)
1782
b6e64c41
GM
17832011-11-23 Glenn Morris <rgm@gnu.org>
1784
1785 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1786
6b21de18
CY
17872011-11-23 Chong Yidong <cyd@gnu.org>
1788
1789 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1790 using it (Bug#5984).
1791
b12cd789
EZ
17922011-11-22 Eli Zaretskii <eliz@gnu.org>
1793
1794 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1795 and header-lines, as they don't have one computed for them.
1796 (Bug#10098)
1797
1798 * .gdbinit (prow): Make displayed values more self-explaining.
1799 Add row's hash code.
1800
261b6fd4
LMI
18012011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1802
1803 * process.c (wait_reading_process_output): Fix asynchrounous
1804 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1805 (wait_reading_process_output): Add comment and URL.
261b6fd4 1806
e7cfd277
JD
18072011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1808
1809 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1810
a9b9b7f5
CY
18112011-11-21 Chong Yidong <cyd@gnu.org>
1812
1813 * window.c (Fnext_window, Fprevious_window): Doc fix.
1814
b0d15b4f
SM
18152011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1816
1817 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1818
fe7a3057
JB
18192011-11-20 Juanma Barranquero <lekktu@gmail.com>
1820
1821 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1822
d2999b1a
MR
18232011-11-20 Martin Rudalics <rudalics@gmx.at>
1824
1825 * window.c (Fset_window_combination_limit): Rename argument
1826 STATUS to LIMIT.
1827 (Vwindow_combination_limit): Remove "status" from doc-string.
1828
d5ff9cd0
AS
18292011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1830
1831 * m/ibms390.h: Remove.
1832 * m/ibms390x.h: Don't include "ibms390.h".
1833
a5bb9bd3
SM
18342011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1835
1836 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1837 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1838
cd1181db
JB
18392011-11-20 Juanma Barranquero <lekktu@gmail.com>
1840
1841 * casetab.c (Fset_case_table):
1842 * charset.c (Fcharset_after): Fix typos.
1843
615a3b8d 18442011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1845
17e845af
PE
1846 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1847 Otherwise, valgrind does not work on some platforms.
1848 Problem reported by Andreas Schwab in
6a0bf43d
PE
1849 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1850 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1851 is set, removing the need for VIRT_ADDRESS_VARIES.
1852 (PURE_P): Use a more-efficient implementation that needs just one
1853 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1854 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1855 to 4 (xorl, subq, cmpq, setbe).
1856 * alloc.c (pure): Always extern now, since that's the
1857 VIRT_ADDR_VARIES behavior.
1858 (PURE_POINTER_P): Use a single comparison, not two, for
1859 consistency with the new puresize.h.
1860 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1861 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1862 Remove VIRT_ADDR_VARIES no longer needed.
1863
f8fe6f96
EZ
18642011-11-19 Eli Zaretskii <eliz@gnu.org>
1865
1866 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1867 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1868 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1869 behave as if the cursor position were at the window margin.
1870
1871 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1872 and the cursor position is out of bounds, behave as if the cursor
1873 position were at the window margin. (Bug#10075)
1874
df05a53c
CY
18752011-11-18 Chong Yidong <cyd@gnu.org>
1876
1877 * window.c (Fwindow_combination_limit): Make first argument
1878 non-optional, since it is meaningless for live windows like the
1879 selected window.
1880
2071918e
DA
18812011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1882
1883 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1884
b50a28de
SM
18852011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1886
1887 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1888 (graft_intervals_into_buffer): Simplify.
1889
015137db
EZ
18902011-11-18 Eli Zaretskii <eliz@gnu.org>
1891
1892 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1893 hash values of the two rows.
1894 (copy_row_except_pointers): Preserve the used[] arrays and the
1895 hash values of the two rows. (Bug#10035)
68c95424 1896 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1897
1898 * xdisp.c (row_hash): New function, body extracted from
1899 compute_line_metrics.
1900 (compute_line_metrics): Call row_hash, instead of computing the
1901 hash code inline.
1902
1903 * dispnew.c (verify_row_hash): Call row_hash for computing the
1904 hash code of a row, instead of duplicating code from xdisp.c.
1905
1906 * dispextern.h (row_hash): Add prototype.
1907
a2addb04
TH
19082011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1909
1910 * frame.c (delete_frame): Don't delete the terminal when the last
1911 X frame is closed if emacs is built with GTK toolkit.
1912
df85d315
JB
19132011-11-17 Juanma Barranquero <lekktu@gmail.com>
1914
1915 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1916
a0c2d0ae
MR
19172011-11-17 Martin Rudalics <rudalics@gmx.at>
1918
1919 * window.c (Vwindow_splits): Rename to
1920 Vwindow_combination_resize. Suggested by Juri Linkov.
1921 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1922 of Vwindow_splits.
1923
58179cce
JB
19242011-11-16 Juanma Barranquero <lekktu@gmail.com>
1925
7877f373
JB
1926 * nsfns.m (Fns_font_name):
1927 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1928
b6f67890
MR
19292011-11-16 Martin Rudalics <rudalics@gmx.at>
1930
1931 * window.h (window): Rename slot "nest" to "combination_limit".
1932 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1933 (Fset_window_nest): Rename to Fset_window_combination_limit.
1934 (Vwindow_nest): Rename to Vwindow_combination_limit.
1935 (recombine_windows, make_parent_window, make_window)
1936 (Fsplit_window_internal, saved_window)
1937 (Fset_window_configuration, save_window_save): Rename all
1938 occurrences of window_nest to window_combination_limit.
1939
c7015153
JB
19402011-11-15 Juanma Barranquero <lekktu@gmail.com>
1941
1942 * image.c (imagemagick_load_image): Fix typo.
1943
322ad6ec
EZ
19442011-11-14 Eli Zaretskii <eliz@gnu.org>
1945
1946 * xdisp.c (display_line): Move the call to
1947 highlight_trailing_whitespace before the call to
1948 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1949 faces of all the glyphs to compute ROW's hash value.
1950 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1951
f067b8ec
JB
19522011-11-14 Juanma Barranquero <lekktu@gmail.com>
1953
1954 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1955 just return (bug#10044).
1956
1e5b2111
EZ
19572011-11-12 Eli Zaretskii <eliz@gnu.org>
1958
7ef3cbd5
EZ
1959 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1960 with user-defined heap size. Bump the default size of the temacs
1961 heap to 27MB, to avoid memory warning when running temacs.
1962 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1963
1e5b2111
EZ
1964 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1965 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1966 (verify_row_hash) [XASSERTS]: New function.
1967 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1968 that the hash value of glyph rows is correct.
1e5b2111 1969
89d61221
MR
19702011-11-12 Martin Rudalics <rudalics@gmx.at>
1971
1972 * window.h (window): Remove splits slot.
1973 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1974 (Fdelete_other_windows_internal, make_parent_window)
1975 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1976 (Fset_window_configuration, save_window_save): Don't deal with
1977 split status of windows.
1978 (saved_window): Remove splits slot.
1979 (Vwindow_splits): Rewrite doc-string.
1980
97f18cc8
JD
19812011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1982
1983 * xfns.c (unwind_create_frame):
1984 * nsfns.m (unwind_create_frame):
1985 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1986 Vframe_list (Bug#9999).
1987
22a648b4
DA
19882011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1989
0b381c7e 1990 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1991
659afede
KH
19922011-11-11 Kenichi Handa <handa@m17n.org>
1993
1994 * callproc.c (Fcall_process): Set the member dst_multibyte of
1995 process_coding.
1996
9ac0394b
KH
19972011-11-11 Johan Bockgård <bojohan@gnu.org>
1998
1999 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
2000 avoid a crash (bug#9496).
2001
2fbdc249
CY
20022011-11-09 Chong Yidong <cyd@gnu.org>
2003
2004 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2005 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
2006
ac6b1f81
PE
20072011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2008
2009 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
2010
09db192c
PE
20112011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2012
2013 Avoid some portability problems by eschewing 'extern inline' functions.
2014 The trivial performance wins aren't worth the portability hassles; see
2015 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2016 et seq.
2017 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2018 (window_box_width, window_box_left, window_box_left_offset)
2019 (window_box_right, window_box_right_offset): Undo previous change,
2020 by removing the "extern"s.
2021 * intervals.c (adjust_intervals_for_insertion)
2022 (adjust_intervals_for_deletion): Undo previous change,
2023 making these static again.
2024 (offset_intervals, temp_set_point_both, temp_set_point)
2025 (copy_intervals_to_string): No longer inline.
2026 * xdisp.c (window_text_bottom_y, window_box_width)
2027 (window_box_height, window_box_left_offset)
2028 (window_box_right_offset, window_box_left, window_box_right)
2029 (window_box): No longer inline.
2030
105216ed
CY
20312011-11-08 Chong Yidong <cyd@gnu.org>
2032
2033 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
2034 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2035 Signal an error if not a live window.
105216ed
CY
2036 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2037 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2038
ae9e237f
JB
20392011-11-07 Juanma Barranquero <lekktu@gmail.com>
2040
2041 * lisp.h (syms_of_abbrev): Remove declaration.
2042 Reported by CHENG Gao <chenggao@royau.me>.
2043
c7aa8333
EZ
20442011-11-07 Eli Zaretskii <eliz@gnu.org>
2045
2046 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2047 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2048 of temacs in GUI mode.
2049
be7f5545
MR
20502011-11-07 Martin Rudalics <rudalics@gmx.at>
2051
2052 * window.h: Declare delete_all_child_windows instead of
2053 delete_all_subwindows.
2054 * window.c (Fwindow_nest, Fset_window_nest)
2055 (Fset_window_new_total, Fset_window_new_normal)
2056 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
2057 (delete_all_subwindows): Rename to delete_all_child_windows.
2058 (Fdelete_other_windows_internal, Fset_window_configuration):
2059 Call delete_all_child_windows instead of delete_all_subwindows.
2060 * frame.c (delete_frame): Call delete_all_child_windows instead
2061 of delete_all_subwindows.
2062
ca78dc43
PE
20632011-11-07 Paul Eggert <eggert@cs.ucla.edu>
2064
2065 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
2066 This is also needed for porting to any host where GC_MARK_STACK is
2067 not GC_MAKE_GCPROS_NOOPS.
2068 (which_symbols): Use it.
2069
a0241d01
KH
20702011-11-07 Kenichi Handa <handa@m17n.org>
2071
2072 * coding.c (coding_set_destination): Check coding->src_pos only
2073 when coding->src_object is a buffer (bug#9910).
2074
2075 * process.c (send_process): Set the member src_multibyte of coding
2076 to 0 (bug#9911) when sending a unibyte text.
2077
2078 * callproc.c (Fcall_process): Set the member src_multibyte of
2079 process_coding to 0 (bug#9912).
2080
a64bfdfa 20812011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
2082
2083 * xmenu.c (cleanup_widget_value_tree): New function.
2084 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2085 calling free_menubar_widget_value_tree directly (Bug#9830).
2086
cb41b32a
PE
20872011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2088
2089 Fix some portability problems with 'inline'.
2090 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2091 (window_box_width, window_box_left, window_box_left_offset)
2092 (window_box_right, window_box_right_offset): Declare extern.
2093 Otherwise, these inline functions do not conform to C99 and
2094 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2095 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2096 * intervals.c (adjust_intervals_for_insertion)
2097 (adjust_intervals_for_deletion): Now extern, because otherwise the
2098 extern inline functions 'offset_intervals' couldn't refer to it.
2099 (static_offset_intervals): Remove.
2100 (offset_intervals): Rewrite using the old contents of
2101 static_offset_intervals. The old version didn't conform to C99
2102 because an extern inline function contained a reference to an
2103 identifier with static linkage.
2104
b7041366
AS
21052011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2106
2107 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2108 GC.
2109
88a37c4d
EZ
21102011-11-06 Eli Zaretskii <eliz@gnu.org>
2111
2112 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2113 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
2114 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
2115 return Qleft_to_right.
2116
49745b39
CY
21172011-11-06 Chong Yidong <cyd@gnu.org>
2118
2119 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2120 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2121 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2122 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
2123 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
2124 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2125 (Fwindow_vscroll): Doc fix.
2126 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2127 argument, since it makes no sense to pass a live window and for
2128 consistency with window-child.
2129
1f05cd82
CS
21302011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2131
2132 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2133 support MSVC.
2134
22610910
JR
21352011-11-05 Jason Rumney <jasonr@gnu.org>
2136
2137 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
2138 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
2139 fonts (Bug#6029).
2140 (add_font_entity_to_list): Fix logic errors in mixed boolean and
2141 bitwise arithmetic preventing use of unicode-sip and non-truetype
2142 opentype fonts.
2143
a06776b2
EZ
21442011-11-05 Eli Zaretskii <eliz@gnu.org>
2145
3ad924ba
EZ
2146 * s/ms-w32.h (fstat, stat, utime): Move redirections to
2147 "emacs"-only part.
2148
a06776b2
EZ
2149 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
2150 initialization code to keep similarity to xfns.c after changes
2151 from 2011-11-05.
2152
c9e7db78
JD
21532011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2154
a97f8f3f
JD
2155 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2156 (unwind_create_frame): New function (Bug#9943).
2157 (Fx_create_frame): Restructure code to be more similar to the one in
2158 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2159 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2160 Move terminal->reference_count++ just before making the frame official
2161 (Bug#9943).
2162
2163 * nsterm.m (x_free_frame_resources): New function.
2164 (x_destroy_window): Move code to x_free_frame_resources.
2165
c9e7db78 2166 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
2167 (Fx_create_frame, x_create_tip_frame):
2168 Move terminal->reference_count++ just before making the frame
75f1671a 2169 official. Move initialization of image_cache_refcount and
c9e7db78
JD
2170 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2171
a6fc3b5c
EZ
21722011-11-05 Eli Zaretskii <eliz@gnu.org>
2173
2174 Support MSVC build with newer versions of Visual Studio.
2175 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2176 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2177 nt/gmake.defs.
2178
2179 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2180 which are not supported by MSVC.
2181 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2182 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2183 bitfields.
2184 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2185 types in bitfields.
2186 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2187
2188 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2189
58179cce 21902011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
2191
2192 Support MSVC build with newer versions of Visual Studio.
2193 * w32.c: Don't include w32api.h for MSVC.
2194 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2195
2196 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2197 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2198 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2199 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2200 e_* cousins.
2201 (alloca) [_MSC_VER]: Define to _alloca.
2202
2203 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2204
2205 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2206
a58c13ed
EZ
22072011-11-04 Eli Zaretskii <eliz@gnu.org>
2208
2209 * xdisp.c (note_mouse_highlight): If either of
2210 previous/next-single-property-change returns nil, treat that as
2211 the beginning or the end of the buffer. (Bug#9955)
2212
fe0b6370
JD
22132011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2214
a58c13ed 2215 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
2216 label is not null (Bug#9951).
2217 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2218 may be NULL.
2219
89bd5ee1
EZ
22202011-11-04 Eli Zaretskii <eliz@gnu.org>
2221
2222 * window.c (Fwindow_body_size): Mention in the doc string that the
2223 return value is in frame's canonical units. (Bug#9949)
2224
84c3edb9
EZ
22252011-11-03 Eli Zaretskii <eliz@gnu.org>
2226
4e2fb5c7
EZ
2227 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2228
84c3edb9 2229 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 2230 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 2231 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 2232
bc17a887
EZ
22332011-11-01 Eli Zaretskii <eliz@gnu.org>
2234
2235 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2236 Don't stop backward scan on the continuation glyph, even though
2237 its CHARPOS is positive.
6d5eb5b0
SM
2238 (mouse_face_from_buffer_pos, note_mouse_highlight):
2239 Rename cover_string to disp_string.
bc17a887 2240
4ee88440
MR
22412011-11-01 Martin Rudalics <rudalics@gmx.at>
2242
2243 * window.c (temp_output_buffer_show): Don't use
2244 Vtemp_buffer_show_specifiers.
2245 (Vtemp_buffer_show_specifiers): Remove unused variable.
2246
c2ff3c02
EZ
22472011-10-30 Eli Zaretskii <eliz@gnu.org>
2248
2249 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2250 past the beginning of the current glyph matrix.
2251
58179cce 22522011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
2253
2254 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2255 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2256 HAVE_GTK3 (Bug#9869).
b77a6a7f 2257
3b574623
JD
2258 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2259 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2260
b77a6a7f
JD
2261 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2262
2263 * xterm.c: Declare x_handle_net_wm_state to return int.
2264 (handle_one_xevent): Check if we are iconified but don't have
2265 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2266 (get_current_wm_state): Return non-zero if not hidden,
2267 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2268 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2269 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2270 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2271
196e41e4
PE
22722011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2273
2274 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2275 so that this new function doesn't get optimized away by a
2276 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2277
021f2e1a
AS
22782011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2279
2280 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2281
8b058d44
EZ
22822011-10-29 Eli Zaretskii <eliz@gnu.org>
2283
2284 Fix the `xbytecode' command.
2285 * .gdbinit (xprintbytestr): New command.
b50a28de 2286 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
2287 (xbytecode): Print the byte-code string as well.
2288
4452fb80
EZ
22892011-10-29 Kim Storm <storm@cua.dk>
2290
8b058d44
EZ
2291 * alloc.c (which_symbols): New function.
2292
21b72067
AS
22932011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2294
2295 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2296 line. (Bug#9903)
2297
83ed7b5c
GM
22982011-10-29 Glenn Morris <rgm@gnu.org>
2299
2300 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2301 Not clear what it was for, and it causes various bugs. (Bug#9839)
2302
5a7a728b
EZ
23032011-10-28 Eli Zaretskii <eliz@gnu.org>
2304
2305 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2306 possible random value that matches one of those tested as
2307 condition to clear the mouse face.
2308
d3d0842f
CY
23092011-10-28 Chong Yidong <cyd@gnu.org>
2310
2311 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2312
31b39d13
DN
23132011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2314
2315 * window.c (make_window): Initialize phys_cursor_on_p.
2316
9aba6043
SM
23172011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2318
2319 * lisp.h (struct Lisp_Symbol): Update comments.
2320
c20992f4
JB
23212011-10-28 Juanma Barranquero <lekktu@gmail.com>
2322
2323 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2324
db4f02f2
EZ
23252011-10-28 Eli Zaretskii <eliz@gnu.org>
2326
2327 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2328 <oslsachem@gmail.com> for helping to debug this.
2329
2330 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2331 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2332 (g_b_init_get_glyph_outline_w): New static variables.
2333 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2334 (GetGlyphOutlineW_Proc): New typedefs.
2335 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
2336 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2337 New functions.
2338 (w32font_open_internal, compute_metrics):
2339 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
2340 instead of calling the "wide" APIs directly.
2341
2342 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2343
2344 * w32.h (syms_of_w32font): Add prototype.
2345
87e68db4
JB
23462011-10-27 Juanma Barranquero <lekktu@gmail.com>
2347
2348 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2349 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2350 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2351 (Fmove_to_window_line): Doc fix.
2352
435c1d67
CY
23532011-10-27 Chong Yidong <cyd@gnu.org>
2354
2355 * process.c (make_process): Set gnutls_state to NULL.
2356
2357 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2358 non-NULL, regardless of GNUTLS_INITSTAGE.
2359 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2360 an error. Set process slots as soon as we allocate them.
2361
2362 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2363
9c6c6f49
CY
23642011-10-27 Chong Yidong <cyd@gnu.org>
2365
9aba6043
SM
2366 * gnutls.c (emacs_gnutls_deinit): New function.
2367 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
2368 (Fgnutls_deinit, Fgnutls_boot): Use it.
2369
2370 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2371 (deactivate_process): Call emacs_gnutls_deinit.
2372
657d08d3
JB
23732011-10-27 Juanma Barranquero <lekktu@gmail.com>
2374
2375 * image.c (x_create_x_image_and_pixmap):
2376 * w32.c (sys_rename, w32_delayed_load):
2377 * w32font.c (fill_in_logfont):
2378 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2379
5430d399
JB
23802011-10-26 Juanma Barranquero <lekktu@gmail.com>
2381
2382 * w32fns.c (w32_default_color_map): New function,
2383 extracted from Fw32_default_color_map.
a7ef684b 2384 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 2385
fe0055fa
PE
23862011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2387
2388 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2389
e6346438
SM
23902011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2391
2392 * keyboard.c (test_undefined): New function (bug#9751).
2393 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2394
e112cc37
ET
23952011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2396
2397 * sysdep.c (init_sys_modes): Fix the check for the controlling
2398 terminal (Bug#6649).
2399
7b5d6677
EZ
24002011-10-20 Eli Zaretskii <eliz@gnu.org>
2401
2402 * dispextern.h (struct bidi_it): New member next_en_type.
2403
2404 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2405 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2406 current character, check also for next_en_type being WEAK_EN.
2407 (bidi_resolve_weak): Don't enter the expensive loop if the current
2408 position is before next_en_pos. Record the bidi type of the first
2409 non-ET, non-BN character we find, in addition to its position.
2410 (bidi_level_of_next_char): Invalidate next_en_type when
2411 next_en_pos is over-stepped.
2412
7da0b018
PE
24132011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2414
2415 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2416 * editfns.c: Rewrite current-time-zone so that it invokes
2417 the equivalent of (format-time-string "%Z") to get the time zone name.
2418 This fixes a bug when the time zone name contains characters that
2419 need converting from the system time locale to Emacs internal format.
2420 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2421 that patch fixed format-time-string to do the conversion, but
2422 I forgot to fix current-time-zone.
2423 (format_time_string): New function, containing most of
2424 what Fformat_time_string used to contain.
2425 (Fformat_time_string): Rewrite in terms of format_time_string.
2426 This doesn't change this function's behavior.
2427 (current-time-zone): Rewrite to use format_time_string.
2428 This fixes the bug reported by Michael Schierl in
2429 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2430 Jason Rumney's 2007-06-07 change worked around this bug, but
2431 didn't fix it.
2432 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2433
8547b010
EZ
24342011-10-19 Eli Zaretskii <eliz@gnu.org>
2435
2436 * xdisp.c (start_display): If the character at POS is displayed
2437 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2438 (try_window_reusing_current_matrix): If a line ends in a display
2439 vector or the next line starts in a display vector, continue
2440 redrawing the window even though the character position of
2441 start_row was reached.
8547b010
EZ
2442 (Bug#9771, part 2)
2443
4e948d15
CY
24442011-10-18 Chong Yidong <cyd@gnu.org>
2445
2446 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2447 with nobreak-char-display too.
2448
4787455f
EZ
24492011-10-18 Eli Zaretskii <eliz@gnu.org>
2450
2451 Fix part 3 of bug#9771.
2452 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2453 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2454 non-neutral characters if the current character is a paragraph
2455 separator (a.k.a. Newline). This avoids running the same
2456 expensive loop twice, once when we consume the preceding newline
2457 and the other time when the line actually needs to be displayed.
2458 Avoid the loop when we see neutrals on the base embedding level
2459 following a character whose directionality is the same as the
2460 paragraph's. This avoids running the expensive loop when a line
2461 ends in a long sequence of neutrals, like control characters.
2462 Add assertion against STRONG_AL type. Slightly rearrange code
2463 that determines the type of a neutral given the first non-neutral
2464 that follows it.
2465 (bidi_level_of_next_char): Set next_en_pos to zero when
2466 invalidating its info.
2467
2c91f553
EZ
24682011-10-17 Eli Zaretskii <eliz@gnu.org>
2469
2470 * xdisp.c (push_display_prop): Determine whether to record string
2471 or buffer position by IT->string, not by IT->method. Allow
2472 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2473 (move_it_vertically_backward): Don't look for character position
2474 immediately after the newline when in a continuation line.
2475 (Bug#9771, part 1)
2c91f553 2476
c7b08b0d
MR
24772011-10-15 Martin Rudalics <rudalics@gmx.at>
2478
2479 * window.c (coordinates_in_window): Rewrite and delabelize
2480 vertical border check. (Bug#5357) (Bug#9618)
2481
6b02f655
SM
24822011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2483
2484 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2485 errors in XSetWindowBorder (bug#9310).
2486
81d40c92
DA
24872011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2488
2489 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2490 avoid crash when xmalloc overrun checking is enabled.
2491
d4172c3b
EZ
24922011-10-13 Eli Zaretskii <eliz@gnu.org>
2493
2494 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2495 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2496 cursor motion with <left> and <right> arrow keys.
2497
2498 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2499 some callers set that themselves.
2500
b00eea75
EZ
25012011-10-12 Eli Zaretskii <eliz@gnu.org>
2502
2503 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2504 display string and the previous row comes from the same string and
2505 is empty. (Bug#9739) (Bug#9738)
2506
8fe012c4
SM
25072011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2508
2509 * doc.c (get_doc_string): Encode file name (bug#9735).
2510
0074aef2
EZ
25112011-10-12 Eli Zaretskii <eliz@gnu.org>
2512
79beb178
EZ
2513 * bidi.c (bidi_level_of_next_char):
2514 * xdisp.c (get_visually_first_element): Remove old incorrect
2515 comments regarding the Unicode Line Separator character.
2516
0074aef2
EZ
2517 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2518
6e4b3fbe
DA
25192011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2520
2521 * alloc.c (Fgc_status): Do not access beyond zombies array
2522 boundary if nzombies > MAX_ZOMBIES.
2523 * alloc.c (dump_zombies): Add missing format specifier.
2524
0324f3af
PE
25252011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2526
b5525cac
PE
2527 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2528 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2529
0324f3af
PE
2530 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2531 Some packages use them to denote characters with modifiers.
2532
e9b5f888
AS
25332011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2534
2535 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2536 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2537 matching a pp-number. Rename parameter var to var1.
2538
127827c0
SM
25392011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2540
2541 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2542
c8fd3bd0
GM
25432011-10-08 Glenn Morris <rgm@gnu.org>
2544
2545 * callint.c (Fcall_interactively): Give a more explicit error for the
2546 'c' case with a non-character input. (Bug#8479)
2547
352ec8ff
EZ
25482011-10-08 Eli Zaretskii <eliz@gnu.org>
2549
03669ccb
EZ
2550 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2551 lines.
7061c986
EZ
2552 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2553 lines that are hscrolled on the left.
03669ccb 2554
352ec8ff
EZ
2555 * dispnew.c (buffer_posn_from_coords): Account for a possible
2556 presence of header-line. (Bug#4426)
2557
a66cfb1c
SM
25582011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2559
6b02f655
SM
2560 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2561 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2562
7c5ee88e
PE
25632011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2564
2565 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2566 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2567 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2568 this makes Emacs dump core during garbage collection on rare
2569 occasions. sizeof is obviously inferior to offsetof here, so
2570 stick with offsetof.
2571 (GC_POINTER_ALIGNMENT): New macro.
2572 (mark_memory): Omit 3rd (offset) arg; caller changed.
2573 Don't assume EMACS_INT alignment is the same as pointer alignment.
2574
df1bbe5b
SM
25752011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2576
2577 * keyboard.c (read_key_sequence_remapped): New var.
2578 (read_key_sequence): Compute remapping in the right buffer.
2579 (command_loop_1): Use read_key_sequence's remapping directly.
2580
51553db6
SM
25812011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2582
32c1fffd
SM
2583 * dired.c (file_name_completion): Don't expand file name.
2584 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2585 before checking file name handler.
2586
51553db6
SM
2587 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2588 they've been requested explicitly (bug#9591).
2589
b6bd1599 25902011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2591
2592 * keymap.c (Fsingle_key_description): Use make_specified_string
2593 instead of build_string to build string from push_key_description.
2594 (Bug#5193)
2595
f701dc2a
PE
25962011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2597
4222c55d
PE
2598 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2599 This fixes a Y2038 bug on 64-bit hosts.
2600 * buffer.c (reset_buffer):
2601 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2602 (Fclear_buffer_auto_save_failure):
2603 Use 0, not -1, to represent an unset failure time, since time_t
2604 might not be signed.
2605
f701dc2a
PE
2606 Remove dependency on glibc malloc internals.
2607 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2608 Move back here from lisp.h, but with their new implementations.
2609 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2610 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2611 * charset.c (charset_table_init): New static var.
2612 (syms_of_charset): Use it instead of xmalloc. This removes a
2613 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2614 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2615 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2616 Move back to alloc.c.
2617 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2618 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2619
9ceebf39
JD
26202011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2621
2622 * nsterm.m (windowDidResize): Call x_set_window_size only when
2623 ns_in_resize is true. Otherwise set pixelwidth/height and
2624 call change_frame_size (Bug#9628).
2625
cb993c58
PE
26262011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2627
3930c88b
PE
2628 Port --enable-checking=all to Fedora 14 x86-64.
2629 * charset.c (syms_of_charset): Also account for glibc malloc's
2630 internal overhead when calculating the initial malloc maximum.
2631
cb993c58
PE
2632 Port --enable-checking=all to Fedora 14 x86.
2633 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2634 Move to lisp.h.
2635 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2636 (overrun_check_realloc, overrun_check_free):
2637 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2638 That way, xmalloc returns a properly-aligned pointer even if
2639 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2640 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2641 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2642 into account when calculating the initial malloc maximum.
2643 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2644 Move here from alloc.c, so that charset.c can use it too.
2645 Properly align; the old code wasn't right for common 32-bit hosts
2646 when configured with --enable-checking=all.
2647 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2648 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2649
31bed486
EZ
26502011-09-29 Eli Zaretskii <eliz@gnu.org>
2651
04c70788 2652 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2653 use EDOM.
2654
fbcaa2f3
EZ
26552011-09-28 Eli Zaretskii <eliz@gnu.org>
2656
2657 * xdisp.c (compute_display_string_end): If there's no display
2658 string at CHARPOS, return -1.
2659
2660 * bidi.c (bidi_fetch_char): When compute_display_string_end
2661 returns a negative value, treat the character as a normal
2662 character not covered by a display string. (Bug#9624)
2663
a239d4e9
JB
26642011-09-28 Juanma Barranquero <lekktu@gmail.com>
2665
2666 * lread.c (Fread_from_string): Fix typo in docstring.
2667
88652fd5
EZ
26682011-09-27 Eli Zaretskii <eliz@gnu.org>
2669
2670 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2671 newline, reseat the iterator instead of bidi-iterating there one
2672 character at a time. (Bug#9610)
32c1fffd
SM
2673 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2674 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2675
ed497dd4
AS
26762011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2677
2678 * lread.c (readevalloop): Use correct code for NBSP.
2679 (read1): Likewise. (Bug#9608)
2680
b2bf61aa
MA
26812011-09-25 Michael Albinus <michael.albinus@gmx.de>
2682
2683 * dbusbind.c (Fdbus_register_signal): When service is not
2684 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2685
32bbb17c
GM
26862011-09-25 Glenn Morris <rgm@gnu.org>
2687
2688 * buffer.c (truncate-lines): Doc fix.
2689
94e0933e
CY
26902011-09-24 Chong Yidong <cyd@stupidchicken.com>
2691
2692 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2693 (Fset_window_next_buffers): Doc fix.
2694
cddde921
GM
26952011-09-24 Glenn Morris <rgm@gnu.org>
2696
2697 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2698
1260aef1
PE
26992011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2700
25b4bfa0
PE
2701 Fix minor problems found by static checking.
2702 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2703 * indent.c (Fvertical_motion): Fix == vs = typo.
2704
e3cbd34b
EZ
27052011-09-24 Eli Zaretskii <eliz@gnu.org>
2706
a66cfb1c
SM
2707 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2708 Default value is now t. Doc fix.
6bf7006f 2709
e3cbd34b 2710 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2711 logic when moving up, not only when moving down. Fix the
e3cbd34b 2712 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2713 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2714
2715 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2716 CHARPOS is covered by a display string which includes newlines.
2717 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2718 is covered by a display string with embedded newlines.
2719
a3de0cbd
MA
27202011-09-24 Michael Albinus <michael.albinus@gmx.de>
2721
2722 * dbusbind.c (Fdbus_register_signal): Add match rule to
2723 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2724 (Fdbus_register_method, Vdbus_registered_objects_table):
2725 Fix docstring.
a3de0cbd 2726
b260039d
JM
27272011-09-24 Jim Meyering <meyering@redhat.com>
2728
32c1fffd 2729 do not ignore write error for any output size
b260039d
JM
2730 The previous change was incomplete.
2731 While it makes emacs --batch detect the vast majority of stdout
2732 write failures, errors were still ignored whenever the output size is
2733 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2734 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2735 && echo FAIL: ignored write error
2736 FAIL: ignored write error
2737 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2738 && echo FAIL: ignored write error
2739 FAIL: ignored write error
2740 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2741
8eca8a7c
AS
27422011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2743
2744 * emacs.c (Fkill_emacs): In noninteractive mode exit
2745 non-successfully if a write error occurred on stdout. (Bug#9574)
2746
3341db62
EZ
27472011-09-21 Eli Zaretskii <eliz@gnu.org>
2748
2749 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2750 the xassert test.
2751
2752 * dispextern.h (struct it): Update the comment documenting what
2753 can it->OBJECT be.
2754
8c203dbf
EZ
27552011-09-20 Eli Zaretskii <eliz@gnu.org>
2756
2757 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2758 a display string, extend search for cursor position to end of row.
2759 (find_row_edges): If the row ends in a newline from a display
2760 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2761 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2762 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2763 non-empty line. Fixes confusing cursor motion with arrow keys at
2764 the beginning of a line that starts with whitespace.
8c203dbf 2765
a4824228
LMI
27662011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2767
2768 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2769 (bug#9493).
2770
33ed493b
CY
27712011-09-18 Chong Yidong <cyd@stupidchicken.com>
2772
2773 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2774 boolean (Bug#9154).
2775
56cd55c8
EZ
27762011-09-18 Eli Zaretskii <eliz@gnu.org>
2777
2778 * xdisp.c (display_line): Record maximum and minimum buffer
2779 positions even if no glyphs were produced (e.g., by a zero-width
2780 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2781 buffer positions that will be removed from the glyph row because
2782 they don't fit.
c02dcedf
EZ
2783 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2784 column is beyond frame width: don't subtract 1 "pixel" when
2785 computing width of the stretch.
3e62b7e0
EZ
2786 (reseat_at_next_visible_line_start): Undo the change made on
2787 2011-09-17 that saved paragraph information and restored it after
2788 the call to `reseat'. (Bug#9545)
56cd55c8 2789
5ed99d36 27902011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2791
2792 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2793 and turn window cursor on if cleared (Bug#9415).
2794
5ed99d36 27952011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2796
2797 * search.c (boyer_moore): Take unibyte characters from pattern
2798 literally. (Bug#9458)
2799
9bade7b2
EZ
28002011-09-18 Eli Zaretskii <eliz@gnu.org>
2801
2802 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2803
e5e9d610
PE
28042011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2805
87e4427a
PE
2806 Fix minor problem found by static checking.
2807 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2808 initialized, to pacify gcc -Wuninitialized.
2809
e5e9d610
PE
2810 * fileio.c: Report proper errno when syscall falls.
2811 (Finsert_file_contents): Save and restore errno,
2812 so that report_file_error outputs the correct diagnostic.
2813 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2814
a1674f0b
EZ
28152011-09-18 Eli Zaretskii <eliz@gnu.org>
2816
2817 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2818
fbfb6dd4
EZ
28192011-09-17 Eli Zaretskii <eliz@gnu.org>
2820
2821 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2822 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2823
bb187662
EZ
28242011-09-17 Eli Zaretskii <eliz@gnu.org>
2825
1137e8b8 2826 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2827 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2828
2829 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2830 (bidi_find_paragraph_start): Search back for paragraph beginning
2831 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2832 (bidi_move_to_visually_next): Only trigger paragraph-related
2833 computations when the last character is a newline or at EOB, not
2834 just any NEUTRAL_B. (Bug#9470)
2835
bb187662
EZ
2836 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2837 truncated lines if point is covered by a display string. (Bug#9524)
2838
2e621251
PE
28392011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2840
2841 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2842 (cons_to_x_long): New function.
2843 (lisp_data_to_selection_data): Use it. Correct the test for
2844 short-versus-long data; it was negated. Break out of vector
2845 loop, for efficiency, when a long datum is discovered.
2846
91a15bc6
SM
28472011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2848
2849 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2850
b41c3a35
EZ
28512011-09-16 Eli Zaretskii <eliz@gnu.org>
2852
2853 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2854 GCC PR/17406) by declaring this function with external scope.
2855
7812ba2d
PE
28562011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2857
2858 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2859 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2860
cf7edc2a
AS
28612011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2862
2863 * editfns.c (Fformat): Correctly handle text properties on "%%".
2864
bd01620e
EZ
28652011-09-15 Eli Zaretskii <eliz@gnu.org>
2866
2867 * xterm.c (x_draw_composite_glyph_string_foreground):
2868 * w32term.c (x_draw_composite_glyph_string_foreground):
2869 * term.c (encode_terminal_code):
2870 * composite.c (composition_update_it, get_composition_id):
2871 * xdisp.c (get_next_display_element)
2872 (fill_composite_glyph_string): Add comments about special meaning
2873 of TAB characters in a composition.
2874
a02719a3
PE
28752011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2876
2877 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2878 This occurs when processing a multibyte format.
2879 Problem reported by Wolfgang Jenker.
a02719a3 2880
72589a3c
JB
28812011-09-15 Johan Bockgård <bojohan@gnu.org>
2882
2883 * xdisp.c (try_cursor_movement): Only check for exact match if
2884 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2885
1c14176c
PE
28862011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2887
2888 Remove unused external symbols.
2889 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2890 * xdisp.c (calc_pixel_width_or_height): Now static.
2891 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2892 * indent.c (check_display_width):
2893 * w32term.c: Fix comment to match code.
2894 * xterm.c, xterm.h (x_catching_errors): Remove.
2895
d2eea5b5
PE
28962011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2897
2898 * xselect.c: Use signed conversions more consistently (Bug#9498).
2899 (selection_data_to_lisp_data): Assume incoming selection data are
2900 signed integers, not unsigned. This is to be consistent with
2901 outgoing selection data, which was modified to use signed integers
2902 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2903 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2904 expects long, not unsigned long.
2905
46888499
EZ
29062011-09-14 Eli Zaretskii <eliz@gnu.org>
2907
2908 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2909 computation of loop end. Reported by Johan Bockgård
2910 <bojohan@gnu.org>.
2911
ef8ef9fb
CY
29122011-09-13 Chong Yidong <cyd@stupidchicken.com>
2913
2914 * frame.c (Fother_visible_frames_p): Function deleted.
2915
fa819fed
EZ
29162011-09-12 Eli Zaretskii <eliz@gnu.org>
2917
2918 * indent.c (compute_motion): Process display vector front to back
2919 rather than the other way around. (Bug#2496)
2920
2ba8e008
SM
29212011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2922
2923 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2924
20f53c69
CY
29252011-09-11 Chong Yidong <cyd@stupidchicken.com>
2926
2927 * minibuf.c (Fread_from_minibuffer): Doc fix.
2928
d562d7a4
EZ
29292011-09-11 Eli Zaretskii <eliz@gnu.org>
2930
2931 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2932 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2933
1c4d7f3d
LMI
29342011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2935
2936 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2937 value for non-existent files.
2938
b885bf36
EZ
29392011-09-11 Eli Zaretskii <eliz@gnu.org>
2940
2941 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2942 set its "size" to -1. This will set the modtime_size field of
2943 the corresponding buffer to -1, which is what
2944 verify-visited-file-modtime expects for files that do not exist.
2945 (Bug#9139)
2946
6612f0bf
PE
29472011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2948
2949 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2950 here ...
2951 * lisp.h: ... from here. push_key_description is no longer
2952 defined in keyboard.c, so its declaration should not be in
2953 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2954 logically belongs with push_key_description.
2955
dfb3f755
PE
29562011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2957
2958 * buffer.h: Include <sys/types.h> instead of <time.h>.
2959 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2960 Problem reported by Herbert J. Skuhra.
2961
3134906c
LMI
29622011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2963
2964 * xml.c (parse_region): Make the parsing work for
2965 non-comment-starting XML files again (bug#9144).
2966
8d903f4e
AS
29672011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2968
2969 * image.c (gif_load): Fix calculation of bottom and right corner.
2970 (Bug#9468)
2971
80ad64f4
EZ
29722011-09-10 Eli Zaretskii <eliz@gnu.org>
2973
2974 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2975 redisplay in small windows.
2976
208a048d
EZ
29772011-09-09 Eli Zaretskii <eliz@gnu.org>
2978
2979 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2980
9b1c252e
MR
29812011-09-08 Martin Rudalics <rudalics@gmx.at>
2982
2983 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2984 Operate on live windows only.
2985
2949f33b
JB
29862011-09-08 Juanma Barranquero <lekktu@gmail.com>
2987
2988 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2989
e08dcafd
EZ
29902011-09-07 Eli Zaretskii <eliz@gnu.org>
2991
2992 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2993 only under bidi iteration.
2994
115b96bd
JD
29952011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2996
2997 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2998
c8199d0f
PE
29992011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3000
3001 isnan: Fix porting problem to Solaris 10 with bundled gcc.
3002 Without this fix, the command to link temacs failed due to an
3003 undefined symbol __builtin_isnan. This is because
3004 /usr/include/iso/math_c99.h #defines isnan(x) to
3005 __builtin_isnan(x), but the bundled gcc, which identifies itself
3006 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
3007 a __builtin_isnan.
3008 * floatfns.c (isnan): #undef, and then #define to a clone of
3009 what's in data.c.
3010 (Fisnan): Always define, since it's always available now.
3011 (syms_of_floatfns): Always define isnan at the Lisp level.
3012
e39b275c 30132011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
3014
3015 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3016
b2db44d9 30172011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 3018
f4af5137 3019 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
3020 The previous code assumed that file offsets (off_t values) fit in
3021 EMACS_INT variables, which is not true on typical 32-bit hosts.
3022 The code messed up by falsely reporting buffer overflow in cases
3023 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3024 when "big" contains more than 2**29 bytes, even though this
3025 inserts just one byte and does not overflow the buffer.
3026 (Finsert_file_contents): Store file offsets as off_t
3027 values, not as EMACS_INT values. Check for overflow when
3028 converting between EMACS_INT and off_t. When checking for
3029 buffer overflow or for overlap, take the offsets into account.
3030 Don't use EMACS_INT for small values where int suffices.
3031 When checking for overlap, fix a typo: ZV was used where
3032 ZV_BYTE was intended.
3033 (Fwrite_region): Don't assume off_t fits into 'long'.
3034 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3035
ecfc0a49
MA
30362011-09-05 Michael Albinus <michael.albinus@gmx.de>
3037
3038 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3039
6511acf2 30402011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 3041
0999621a 3042 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
3043
3044 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 3045 (esprintf, exprintf, evxprintf): New functions.
62f19c19 3046 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 3047 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
3048 (modify_event_symbol): Do not assume that the length of
3049 name_alist_or_stem is safe to alloca and fits in int.
3050 (Fexecute_extended_command): Likewise for function name and binding.
3051 (Frecursion_depth): Wrap around reliably on integer overflow.
3052 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3053 since some callers pass EMACS_INT values.
3054 (Fsingle_key_description): Don't crash if symbol name contains more
3055 than MAX_ALLOCA bytes.
3056 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
3057 (get_minibuffer): Arg is now EMACS_INT, not int.
3058 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 3059 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
3060 * window.h (command_loop_level, minibuf_level): Reflect API changes.
3061
2be7d702
PE
3062 * dbusbind.c (signature_cat): New function.
3063 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
3064 Do not overrun buffer; instead, report string overflow.
3065
9d1df220
PE
3066 * dispnew.c (add_window_display_history): Don't overrun buffer.
3067 Truncate instead; this is OK since it's just a log.
3068
33ef5c64
PE
3069 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
3070 even if the time zone offset is outlandishly large.
3071 Don't mishandle offset == INT_MIN.
3072
66c6fdd5
PE
3073 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3074 when creating daemon; the previous buffer-overflow check was incorrect.
3075
d749b01b
PE
3076 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3077 which has the guts of the old verror function.
3078
b5cd1905
PE
3079 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3080 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3081
6e1a67fb
PE
3082 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3083 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 3084 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 3085 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
3086 length of string rather than counting it via multiple sprintfs;
3087 that's simpler and more reliable.
c21721cc
PE
3088 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3089 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3090 sprintf, in case result does not fit in int.
3091
c57b67fc
PE
3092 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3093 (fontset_from_font): Print it.
3094
8a401434
PE
3095 * frame.c (tty_frame_count): Now printmax_t, not int.
3096 (make_terminal_frame, set_term_frame_name): Print it.
3097 (x_report_frame_params): In X, window IDs are unsigned long,
3098 not signed long, so print them as unsigned.
3099 (validate_x_resource_name): Check for implausibly long names,
3100 and don't assume name length fits in 'int'.
3101 (x_get_resource_string): Don't blindly alloca invocation name;
3102 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3103 not fit in int.
3104
6e1a67fb
PE
3105 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3106 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
3107 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3108
0df02bf3
PE
3109 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3110 Use esprintf, not sprintf, in case result does not fit in int.
3111
48e30793
PE
3112 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3113 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
3114 it as a large positive number.
3115 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3116 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3117
a66ff6d8
PE
3118 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3119 in case result does not fit in int.
3120
aca216ff
PE
3121 * print.c (float_to_string): Detect width overflow more reliably.
3122 (print_object): Make sprintf buffer a bit bigger, to avoid potential
3123 buffer overrun. Don't assume list length fits in 'int'. Treat
3124 print length of 0 as 0, not as infinity; to be consistent with other
3125 uses of print length in this function. Don't overflow print length
3126 index. Don't assume hash table size fits in 'long', or that
3127 vectorlike size fits in 'unsigned long'.
3128
31c286f7
PE
3129 * process.c (make_process): Use printmax_t, not int, to format
3130 process-name gensyms.
3131
55e5faa1
PE
3132 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3133
80f2e268
PE
3134 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3135 to avoid potential buffer overrun.
3136
670741ab
PE
3137 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
3138 if X resource line is longer than 512 bytes.
3139
b7163a50
PE
3140 * xfns.c (x_window): Make sprintf buffer a bit bigger
3141 to avoid potential buffer overrun.
3142
ae58ff1f
PE
3143 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
3144
c43c8a6a
PE
3145 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
3146
3f8236f4
PE
31472011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3148
53e9fe90 3149 Integer overflow fixes for scrolling, etc.
6511acf2
PE
3150 Without these, Emacs silently mishandles large integers sometimes.
3151 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
3152 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3153
6511acf2
PE
3154 * xdisp.c (try_window_id): Check Emacs fixnum range before
3155 converting to 'int'.
806add1d 3156
6511acf2 3157 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
3158 Check that an Emacs fixnum is in range before assigning it to 'int'.
3159 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3160 values converted from Emacs fixnums.
3161 (Frecenter): Don't wrap around a line count if it is out of 'int'
3162 range; instead, treat it as an extreme value.
3163 (Fset_window_configuration, compare_window_configurations):
3164 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3165
6511acf2
PE
3166 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3167 that can exceed INT_MAX. Check that EMACS_INT value is in range
3168 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
3169 (match_limit): Don't assume that a fixnum can fit in 'int'.
3170
6511acf2 3171 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
3172 exceed INT_MAX.
3173
6511acf2 3174 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
3175 (Fvertical_motion): Don't wrap around LINES values that don't fit
3176 in 'int'. Instead, treat them as extreme values. This is good
3177 enough for windows, which can't have more than INT_MAX lines anyway.
3178
fcb901a7
LMI
31792011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3180
0f2f6b6d
LMI
3181 * Require libxml/parser.h to avoid compilation warning.
3182
fcb901a7
LMI
3183 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3184
3185 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3186 since this reportedly can destroy thread storage.
3187
6e20a0d4
CY
31882011-08-30 Chong Yidong <cyd@stupidchicken.com>
3189
3190 * syntax.c (find_defun_start): Update all cache variables if
3191 exiting early (Bug#9401).
3192
148ae00e
EZ
31932011-08-30 Eli Zaretskii <eliz@gnu.org>
3194
f6cfbd8f
EZ
3195 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3196
148ae00e
EZ
3197 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3198 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3199 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3200
3201 * term.c (tty_append_glyph): New function.
3202 (produce_stretch_glyph): Static function and its prototype deleted.
3203
a66cfb1c
SM
3204 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3205 Add prototypes.
148ae00e 3206
c4a07a4c
PE
32072011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3208
3209 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3210 when checking :margin (Bug#9390).
3211 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 3212 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
3213 so that the name doesn't mislead. All uses changed.
3214
6bc8cd65
JB
32152011-08-28 Johan Bockgård <bojohan@gnu.org>
3216
3217 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3218 set_tty_hooks.
3219
dca4927e
EZ
32202011-08-27 Eli Zaretskii <eliz@gnu.org>
3221
3222 * xdisp.c (move_it_to): Don't bail out early when reaching
3223 position beyond to_charpos, if we are scanning backwards.
3224 (move_it_vertically_backward): When DY == 0, make sure we get to
3225 the first character in the line after the newline.
3226
f2cad773
PE
32272011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3228
3229 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3230 (ccl_driver): Do not generate an out-of-range pointer.
3231 (Fccl_execute_on_string): Remove unnecessary check for
3232 integer overflow, noted by Stefan Monnier in
3233 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3234 Remove a FIXME that didn't need fixing.
3235 Simplify the newly-introduced buffer reallocation code.
3236
0cae2cdb
JB
32372011-08-27 Juanma Barranquero <lekktu@gmail.com>
3238
3239 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3240
5fc295a4 32412011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 3242
70c60eb2 3243 Integer and memory overflow issues (Bug#9196).
726e0ab1 3244
d31850da
PE
3245 * doc.c (get_doc_string): Rework so that
3246 get_doc_string_buffer_size is the actual buffer size, rather than
3247 being 1 less than the actual buffer size; this makes xpalloc more
3248 convenient.
3249
a69fbedb
PE
3250 * image.c (x_allocate_bitmap_record, cache_image):
3251 * xselect.c (Fx_register_dnd_atom):
3252 Simplify previous changes by using xpalloc.
3253
fe5c5d37
PE
3254 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3255 since either will do and ptrdiff_t is convenient with xpalloc.
3256
0065d054
PE
3257 * charset.c (charset_table_size)
3258 (struct charset_sort_data.priority): Now ptrdiff_t.
3259 (charset_compare): Don't overflow if priorities differ greatly.
3260 (Fsort_charsets): Don't assume list length fits in int.
3261 Check for size-calculation overflow when allocating sort data.
3262 (syms_of_charset): Allocate an initial charset table that is
3263 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3264
3265 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3266
3267 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3268 The actual value is always <= INT_MAX, and leaving it unsigned made
3269 overflow checking harder.
3270
3271 * dispextern.h (struct glyph_matrix.rows_allocated)
3272 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3273 with xpalloc. The values are still always <= INT_MAX.
3274
3275 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3276
3277 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3278 (SAFE_NALLOCA): New macro.
3279
3280 * region-cache.c (struct boundary.pos, find_cache_boundary)
3281 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3282 (set_cache_region, invalidate_region_cache)
3283 (revalidate_region_cache, know_region_cache, region_cache_forward)
3284 (region_cache_backward, pp_cache):
3285 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3286 so that ptrdiff_t * can be passed to xpalloc.
3287 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3288 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3289 (pp_cache): Don't assume cache_len fits in int.
3290 * region-cache.h: Adjust extern decls to match.
3291
3292 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3293 EMACS_INT, since either will do, for xpalloc.
3294
3295 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3296 (xnmalloc, xnrealloc, xpalloc): New functions.
3297
726e0ab1
PE
3298 * bidi.c (bidi_shelve_header_size): New constant.
3299 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3300 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3301
51f30bc5 3302 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
3303 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3304 (overlay_strings):
3305 Don't update size of array until after memory allocation succeeds,
3306 because xmalloc/xrealloc may not return.
0065d054
PE
3307 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3308 now that we have proper integer overflow checking.
3309 (record_overlay_string, overlay_strings): Catch overflows when
3310 calculating size of overlay_str_buf.
726e0ab1 3311
0065d054
PE
3312 * callproc.c (Fcall_process): Check for size overflow when
3313 calculating size of args2.
3314 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3315 Normally we prefer signed values, but sticking with ptrdiff_t would
3316 require adding more-complicated checks.
726e0ab1
PE
3317
3318 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3319 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3320 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 3321 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
3322
3323 * character.c (Fstring): Check for size-calculation overflow.
3324
3325 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3326 unnecessary integer overflow. Check for size overflow.
3327 (encode_coding_object): Don't update size until xmalloc succeeds.
3328
3329 * composite.c (get_composition_id): Check for overflow in glyph
3330 length calculations.
3331
3332 Integer and memory overflow fixes for display code.
3333 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3334 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3335 (scrolling_window): Check for overflow in size calculations.
3336 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3337 Don't assume glyph table len fits in int.
3338 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3339 (row_table_size): Now ptrdiff_t, not int.
3340 (scrolling_window): Avoid overflow in size calculations.
3341 Don't update size until allocation succeeds.
3342 * fns.c (concat): Check for overflow in size calculations.
3343 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3344 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3345 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3346
3347 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3348 (get_doc_string): Check for size calculation overflow.
3349 Don't update size until allocation succeeds.
3350 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3351 EMACS_INT, where ptrdiff_t will do.
3352 (Fsubstitute_command_keys): Check for string overflow.
3353
3354 * editfns.c (set_time_zone_rule): Don't assume environment length
3355 fits in int.
3356 (message_length): Now ptrdiff_t, not int.
3357 (Fmessage_box): Don't update size until allocation succeeds.
3358 Don't assume message length fits in int.
3359 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3360
0065d054
PE
3361 * emacs.c (main): Do not reallocate argv, since there is a null at
3362 the end that can be overwritten, and this way there's no need to
3363 worry about size-calculation overflow.
3364 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
3365
3366 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3367 alloc succeeds.
3368 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3369
3370 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3371 (x_set_scroll_bar_width, x_figure_window_size):
3372 Check for integer overflow.
3373 (x_set_alpha): Do not assume XINT fits in int.
3374
3375 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3376 This is for the members text_lines, text_cols, total_lines, total_cols,
3377 where the system imposes an 'int' limit.
3378
3379 * fringe.c (Fdefine_fringe_bitmap):
3380 Don't update size until alloc works.
3381
3382 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3383 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3384
3385 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3386 Check for size-calculation overflow.
3387 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3388 do, as we prefer signed integers.
3389 (id_to_widget.max_size, id_to_widget.used)
3390 (xg_store_widget_in_map, xg_remove_widget_from_map)
3391 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3392 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3393 Use and return ptrdiff_t, not int.
3394 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3395 * gtkutil.h: Change prototypes to match the above.
3396
3397 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3398 are duplicate now that they've been promoted to lisp.h.
3399 (x_allocate_bitmap_record, x_alloc_image_color)
3400 (make_image_cache, cache_image, xpm_load):
3401 Don't update size until alloc is done.
3402 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3403 (x_detect_edges):
3256efce 3404 Check for size calculation overflow.
726e0ab1
PE
3405 (ct_colors_allocated_max): New constant.
3406 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3407 overflow.
3256efce 3408
726e0ab1
PE
3409 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3410 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3411 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3412 Use ptrdiff_t, not int, to count maps.
3413 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
3414 calculations. Don't update size until allocation succeeds.
3415 Redo calculations to avoid overflow.
726e0ab1
PE
3416 * keyboard.h: Change prototypes to match the above.
3417
3418 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3419 to count maps.
3420 (current_minor_maps): Check for size calculation overflow.
3421 * keymap.h: Change prototypes to match the above.
3422
3423 * lread.c (read1, init_obarray): Don't update size until alloc done.
3424
3425 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3426 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3427
726e0ab1
PE
3428 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3429 Now ptrdiff_t, not int.
3430 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3431 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3432
3433 * process.c (Fnetwork_interface_list): Check for overflow
3434 in size calculation.
3435
3436 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3437
3438 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3439 overflow. Don't bother calling xmalloc when xrealloc will do.
3440
3441 * search.c (Freplace_match): Check for size calculation overflow.
3442 (Fset_match_data): Don't assume list lengths fit in 'int'.
3443
3444 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3445 for command line length. Do not attempt to address one before the
3446 beginning of an array, as that's not portable.
3447
3448 * term.c (max_frame_lines): Remove; unused.
3449 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3450 not int.
3451 (encode_terminal_code, calculate_costs): Check for size
3452 calculation overflow.
3453 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3454 table lengths and related sizes. Don't update size until alloc
3455 done. Redo calculations to avoid overflow.
3456 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3457
3458 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3459 subtracting pointers.
3460 (gobble_line): Check for overflow more carefully. Don't update size
3461 until alloc done.
3462
3463 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3464 Don't update size until alloc done.
3465 Redo size calculations to avoid overflow.
3466 Check for size calculation overflow.
0065d054 3467 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3468
3469 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3470 Use ptrdiff_t, not int, for sizes.
3471 (store_mode_line_noprop_char): Don't update size until alloc done.
3472
0065d054
PE
3473 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3474 Use ptrdiff_t, not int, for sizes.
3475 (Finternal_make_lisp_face, cache_face):
3476 Check for size calculation overflow.
3477 (cache_face): Treat size calculation overflows as if they were
3478 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3479
3480 * xfns.c (x_encode_text, x_set_name_internal)
3481 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3482 sizes, since they can exceed INT_MAX in size. Check for size
3483 calculation overflow.
3484
0065d054
PE
3485 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3486 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3487 Don't update size until alloc done.
3488
0065d054 3489 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3490 as sprintf is limited to int lengths.
1d526e2f 3491
252c5ee1
PE
3492 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3493 (X_LONG_MIN): New macros.
864d7ce7
PE
3494 Use them to make the following changes clearer.
3495 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3496 This change doesn't affect the value now, but it may help remind
3497 future maintainers not to raise the value too much later.
3498 (SELECTION_QUANTUM): Remove, replacing with ...
3499 (selection_quantum): ... new function, which avoids overflow.
3500 All uses changed.
3501 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3502 assumption that selection length fits in 'int'.
3503 (x_reply_selection_request, x_handle_selection_request)
3504 (x_get_window_property, receive_incremental_selection)
3505 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3506 (lisp_data_to_selection_data, clean_local_selection_data):
3507 Use ptrdiff_t, not int, to record length of selection.
3508 (x_reply_selection_request, x_get_window_property)
3509 (receive_incremental_selection, x_property_data_to_lisp):
3510 Redo calculations to avoid overflow.
3511 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3512 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3513 something.
3514 (x_get_window_property, receive_incremental_selection)
3515 (lisp_data_to_selection_data, x_property_data_to_lisp):
3516 Check for size-calculation overflow.
3517 (x_get_window_property, receive_incremental_selection)
3518 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3519 Don't store size until memory allocation succeeds.
3520 (x_get_window_property): Plug memory leak on memory exhaustion.
3521 Don't double-block input; malloc is safe here. Don't assume 2**34
3522 - 4 fits in unsigned long. Add an xassert to check
3523 XGetWindowProperty overflow. Be more careful about overflow
3524 calculations, and distinguish size from memory overflow better.
3525 (receive_incremental_selection): When tracing, don't assume
3526 unsigned int is less than INT_MAX.
3527 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3528 harmful) conversions of unsigned short to int.
3529 (lisp_data_to_selection_data): Don't assume that integers
3530 in the range -65535 through -1 fit in an X unsigned short.
3531 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3532 result parameters unless successful. Rely on cons_to_unsigned
3533 to report problems with elements; the old code wasn't right anyway.
3534 (x_check_property_data): Check for int overflow; we cannot use
3535 a wider type due to X limits.
3536 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3537
726e0ab1 3538 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3539
0065d054
PE
3540 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3541 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3542 (x_color_cells): Don't store size until memory allocation succeeds.
3543 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3544 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3545 (x_term_init): Don't assume length fits in int (sprintf is limited
3546 to int size).
bc18e09d 3547
ebfa62c0
PE
3548 Use ptrdiff_t for composition IDs.
3549 * character.c (lisp_string_width):
3550 * composite.c (composition_table_size, n_compositions)
3551 (get_composition_id, composition_gstring_from_id):
3552 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3553 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3554 * window.c (Frecenter):
3555 Use ptrdiff_t, not int, for composition IDs.
3556 * composite.c (get_composition_id): Check for integer overflow.
3557 * composite.h: Adjust prototypes to match the above changes.
3558
d3411f89
PE
3559 Use ptrdiff_t for hash table indexes.
3560 * category.c (hash_get_category_set):
3561 * ccl.c (ccl_driver):
3562 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3563 * coding.c (coding_system_charset_list, detect_coding_system):
3564 * coding.h (struct coding_system.id):
3565 * composite.c (get_composition_id, gstring_lookup_cache):
3566 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3567 * image.c (xpm_get_color_table_h):
3568 * lisp.h (hash_lookup, hash_put):
3569 * minibuf.c (Ftest_completion):
3570 Use ptrdiff_t for hash table indexes, not int (which is too
3571 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3572 32-bit --with-wide-int hosts).
3573
e097a6fa
PE
3574 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3575 Add a FIXME comment about memory leaks.
3576 (syms_of_charset): Don't assume xmalloc returns.
3577
5637687f
PE
3578 Don't assume that stated character widths fit in int.
3579 * character.c (Fchar_width, c_string_width, lisp_string_width):
3580 * character.h (CHAR_WIDTH):
3581 * indent.c (MULTIBYTE_BYTES_WIDTH):
3582 Use sanitize_char_width to avoid undefined and/or bad behavior
3583 with outlandish widths.
a66cfb1c 3584 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3585 now that we have two such functions. All uses changed.
3586 (sanitize_char_width): New inline function.
3587
a2271ba2
PE
3588 Don't assume that tab-width fits in int.
3589 * character.h (sanitize_width): New inline function.
3590 (SANE_TAB_WIDTH): New macro.
3591 (ASCII_CHAR_WIDTH): Use it.
3592 * indent.c (sane_tab_width): Remove. All uses replaced by
3593 SANE_TAB_WIDTH (current_buffer).
3594 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3595
18c52557
PE
3596 * fileio.c: Integer overflow issues with file modes.
3597 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3598
caeeedc1
PE
3599 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3600 Remove unreachable code.
3601 (read_hex, load_charset_map_from_file): Check for integer overflow.
3602
6df6ae42 3603 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3604 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3605 (x_send_scroll_bar_event): Likewise. Check that the size does not
3606 exceed limits imposed by XClientMessageEvent, as well as the usual
3607 ptrdiff_t and size_t limits.
3608
b13995db
PE
3609 * keyboard.c: Overflow, signedness and related fixes.
3610 (make_lispy_movement): Use same integer type in forward decl
3611 that is used in the definition.
3612 (read_key_sequence, keyremap_step):
3613 Change bufsize argument back to int, undoing my 2011-03-30 change.
3614 We prefer signed types, and int is wide enough here.
3615 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3616 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3617 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3618 length, not size_t. Use ptrdiff_t for index, not int.
3619 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3620 possibility of integer overflow.
3621
13464394
PE
3622 Overflow, signedness and related fixes for images.
3623
3624 * dispextern.h (struct it.stack[0].u.image.image_id)
3625 (struct_it.image_id, struct image.id, struct image_cache.size)
3626 (struct image_cache.used, struct image_cache.ref_count):
3627 * gtkutil.c (update_frame_tool_bar):
3628 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3629 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3630 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3631 * nsmenu.m (update_frame_tool_bar):
3632 * xdisp.c (calc_pixel_width_or_height):
3633 * xfns.c (image_cache_refcount):
3634 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3635 on typical 64-bit hosts.
3636
3637 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3638 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3639 Omit unnecessary casts to int.
3640 (parse_image_spec): Check that integers fall into 'int' range
3641 when the callers expect that.
3642 (image_ascent): Redo ascent calculation to avoid int overflow.
3643 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3644 (lookup_image): Remove unnecessary tests.
3645 (xbm_image_p): Locals are now of int, not EMACS_INT,
3646 since parse_image_check makes sure they fit into int.
3647 (png_load, gif_load, svg_load_image):
3648 Prefer int to unsigned where either will do.
3649 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3650 old tiff_error_handler and tiff_warning_handler.
3651 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3652 stack buffer overflows. It uses only the features of vsnprintf
3653 that are common to both POSIX and native Microsoft.
3654 (tiff_error_handler, tiff_warning_handler): Use it.
3655 (tiff_load, gif_load, imagemagick_load_image):
3656 Don't assume :index value fits in 'int'.
3657 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3658 (imagemagick_load_image): Check that crop parameters fit into
3659 the integer types that MagickCropImage accepts. Don't assume
3660 Vimagemagick_render_type has a nonnegative value. Don't assume
3661 size_t fits in 'long'.
3662 (gs_load): Use printmax_t to print the widest integers possible.
3663 Check for integer overflow when computing image height and width.
3664
c11821d4
EZ
36652011-08-26 Eli Zaretskii <eliz@gnu.org>
3666
3667 * xdisp.c (redisplay_window): Don't force window start if point
3668 will be invisible in the resulting window. (Bug#9324)
3669
0c95fcf7
EZ
36702011-08-25 Eli Zaretskii <eliz@gnu.org>
3671
3672 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3673 the display spec is of the form `(space ...)'.
3674 (handle_display_spec): Return the value returned by
3675 handle_single_display_spec, not just 1 or zero.
3676 (handle_single_display_spec): If the display spec is of the form
3677 `(space ...)', and specifies display in the text area, return 2
3678 rather than 1.
fee65a97 3679 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3680 accurately, and prefer exact match for point under bidi.
3681 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3682
3683 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3684 into disp_prop; all users changed.
3685
3686 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3687 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3688 for the text covered by the display property.
3689
e4ed06f1
CY
36902011-08-25 Chong Yidong <cyd@stupidchicken.com>
3691
3692 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3693 Change return value to nil.
3694 (Frecord_buffer): Delete unused function.
3695
f67cdd7f
EZ
36962011-08-24 Eli Zaretskii <eliz@gnu.org>
3697
5980d4c6
EZ
3698 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3699 buffers, return left-to-right.
8610fe8b
EZ
3700 (set_cursor_from_row): Consider candidate row a win if its glyph
3701 represents a newline and point is on that newline. Fixes cursor
3702 positioning on the newline at EOL of R2L text within L2R
3703 paragraph, and vice versa.
3704 (try_cursor_movement): Check continued rows, in addition to
3705 continuation rows. Fixes unwarranted scroll when point enters a
3706 continued line of R2L text within an L2R paragraph, or vice versa.
3707 (cursor_row_p): Consider the case of point being equal to
3708 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3709 from the end of a short line to the beginning of a continued line
3710 of R2L text within L2R paragraph.
3711 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3712 composed characters.
5980d4c6 3713
f67cdd7f
EZ
3714 * bidi.c (bidi_check_type): Use xassert.
3715 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3716 members.
3717
bca633fb
EZ
37182011-08-23 Eli Zaretskii <eliz@gnu.org>
3719
3720 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3721 a character.
3722
4a5885a7
CY
37232011-08-23 Chong Yidong <cyd@stupidchicken.com>
3724
3725 * nsfont.m (ns_otf_to_script): Fix typo.
3726
0902a04e
KH
37272011-08-22 Kenichi Handa <handa@m17n.org>
3728
3729 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3730 extra slot even if the purpose is char-code-property-table.
3731
1a2e6670
EZ
37322011-08-23 Eli Zaretskii <eliz@gnu.org>
3733
8ddde651
EZ
3734 * xdisp.c (redisplay_window): When computing centering_position,
3735 account for the height of the header line. (Bug#8874)
3736
425cc014
EZ
3737 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3738 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3739 candidate is selected by the mouse, and that candidate has a
3740 composed character under the mouse.
3741
1a2e6670
EZ
3742 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3743 coordinates reported by pos-visible-in-window-p for a composed
3744 character in column zero.
3745
8b76d6f8
SM
37462011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3747
3748 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3749
dac347dd
EZ
37502011-08-22 Eli Zaretskii <eliz@gnu.org>
3751
3752 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3753 consider it a hit if to_charpos is anywhere in the range of the
3754 composed buffer positions.
3755
e013fb34
CY
37562011-08-22 Chong Yidong <cyd@stupidchicken.com>
3757
3758 * image.c (gif_load): Don't assume that each subimage has the same
3759 dimensions as the base image. Handle disposal method that is
3760 "undefined" by the gif spec (Bug#9335).
3761
bd1ba3e8
CY
37622011-08-20 Chong Yidong <cyd@stupidchicken.com>
3763
3764 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3765 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3766
54a1215b
EZ
37672011-08-19 Eli Zaretskii <eliz@gnu.org>
3768
823564e5
EZ
3769 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3770 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3771 from an Org mode buffer to a Speedbar frame.
3772
54a1215b
EZ
3773 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3774 a composition, take its buffer position from IT->cmp_it.charpos.
3775 Fixes cursor positioning at the beginning of a line that begins
3776 with a composed character.
3777
9778ebcc
EZ
37782011-08-18 Eli Zaretskii <eliz@gnu.org>
3779
0be6ee06
EZ
3780 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3781 character bidirectional type, use STRONG_L instead. Fixes crashes
3782 in a buffer produced by `describe-categories'.
3783
9778ebcc
EZ
3784 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3785 members before the level stack, so they would be saved and
3786 restored when copying iterator state. Fixes incorrect reordering
3787 around TABs covered by display properties.
3788
156bffbe
AS
37892011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3790
6b02f655 3791 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3792
72ad093b
CY
37932011-08-17 Chong Yidong <cyd@stupidchicken.com>
3794
3795 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3796 (internal_condition_case_2, internal_condition_case_n):
3797 Remove unnecessary aborts (Bug#9081).
72ad093b 3798
35774242
EZ
37992011-08-17 Eli Zaretskii <eliz@gnu.org>
3800
3801 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3802 has no `load' handler, try opening the file locally. (Bug#9311)
3803
db76dd85
KB
38042011-08-16 Ken Brown <kbrown@cornell.edu>
3805
3806 * gmalloc.c: Expand comment.
3807
b215eee5
EZ
38082011-08-16 Eli Zaretskii <eliz@gnu.org>
3809
3810 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3811 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3812
a4579d33
KB
38132011-08-16 Ken Brown <kbrown@cornell.edu>
3814
3815 Fix memory allocation problems in Cygwin build (Bug#9273).
3816
3817 * unexcw.c ( __malloc_initialized): Declare external variable.
3818 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3819
8b76d6f8
SM
3820 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3821 New variables.
a4579d33
KB
3822 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3823 dumped emacs.
3824 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3825 in the static heap.
3826 [CYGWIN] (special_realloc): New function.
3827 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3828 requests to realloc storage in the static heap.
3829
3ebec551
PE
38302011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3831
3832 * bidi.c (bidi_initialize): Remove unused local.
3833
9fd8be00
EZ
38342011-08-15 Eli Zaretskii <eliz@gnu.org>
3835
6b02f655
SM
3836 * bidimirror.h:
3837 * biditype.h: Remove file.
3838 * makefile.w32-in ($(BLD)/bidi.$(O)):
3839 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3840
3841 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3842
3843 * chartab.c: Improve commentary for the uniprop_table API.
3844
32413314
EZ
3845 * bidi.c (bidi_paragraph_init): Support zero value of
3846 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3847 (bidi_initialize): Use uniprop_table instead of including
3848 biditype.h and bidimirror.h.
32413314 3849
9fd8be00
EZ
3850 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3851 coordinates of the iterator when restoring from ppos_it.
3852 (Bug#9296)
3853
5cf2b69b
KH
38542011-08-14 Kenichi Handa <handa@m17n.org>
3855
3856 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3857 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3858
daf17d00
EZ
38592011-08-14 Eli Zaretskii <eliz@gnu.org>
3860
3861 * xdisp.c (move_it_in_display_line_to): Don't invoke
3862 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3863 ppos_it. Fixes vertical cursor motion when line beginning is
3864 covered by an image. (Bug#9296)
3865
08e3161a
JD
38662011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3867
3868 * nsterm.h (ns_run_ascript): Declare.
3869 (NSAPP_DATA2_RUNASSCRIPT): Define.
3870
3871 * nsfns.m (as_script, as_result, as_status): New static variables.
3872 (ns_run_ascript): New function.
5e617bc2 3873 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3874 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3875 the event loop. Get status from as_status (Bug#7276).
3876
3877 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3878 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3879 the event loop (Bug#7276).
3880
a3720aa2
AS
38812011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3882
3883 * gnutls.c (QCgnutls_bootprop_priority)
3884 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3885 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3886 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3887 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3888 (QCgnutls_bootprop_verify_hostname_error)
3889 (QCgnutls_bootprop_callbacks_verify): Rename from
3890 Qgnutls_bootprop_..., all uses changed.
3891
3892 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3893 uses changed.
3894
0a0d27fb
PE
38952011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3896
19d5c50c
PE
3897 * xfaces.c (Qframe_set_background_mode): Now static.
3898 * dispextern.h (Qframe_set_background_mode): Remove decl.
3899
0a0d27fb
PE
3900 * process.c (Fnetwork_interface_info): Declare local only if needed.
3901
377538cb
JD
39022011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3903
3904 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3905 (Fnetwork_interface_list): Allocate in increments of bytes instead
3906 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3907 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3908 sockaddr.
3909 (struct ifflag_def): notrailers is smart on OSX.
3910 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3911 Get hardware address with getifaddrs if available.
3912
08fff70c
EZ
39132011-08-12 Eli Zaretskii <eliz@gnu.org>
3914
3915 * xdisp.c (iterate_out_of_display_property): xassert that
3916 IT->position is set to within IT->object's boundaries. Break from
3917 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3918 when IT->position is set up wrongly due to some bug.
3919 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3920 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3921 entry. Force push_it to save on the stack the current
3922 buffer/string position, to be restored by pop_it. Fix flags in
3923 the iterator structure wrt the object coming from a display
3924 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3925 properties. (Bug#9284)
3926
7be1c708 39272011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3928
7be1c708
CY
3929 * fontset.c (fontset_get_font_group): Add proper type checks.
3930 (Bug#9172)
aac0c6e3 3931
7be1c708 39322011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3933
7be1c708
CY
3934 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3935 and LC_VERSION_MIN_MACOSX.
3936 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3937 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3938
97bb72a6
EZ
39392011-08-08 Eli Zaretskii <eliz@gnu.org>
3940
3941 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3942 no-display-properties-and-no-overlays under bidi display.
3943 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3944 properties and overlays.
97bb72a6 3945
d5617611
CY
39462011-08-08 Chong Yidong <cyd@stupidchicken.com>
3947
37e11a63
CY
3948 * editfns.c (Fset_time_zone_rule): Document relationship with the
3949 setenv function.
3950
d5617611
CY
3951 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3952 the font entity extracted from the cache (Bug#8109).
3953
58872834
CY
39542011-08-07 Chong Yidong <cyd@stupidchicken.com>
3955
3956 * composite.c (autocmp_chars): Don't reset point. That is done by
3957 restore_point_unwind (Bug#5984).
3958
75bfc667
JL
39592011-08-07 Juri Linkov <juri@jurta.org>
3960
3961 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3962 to show the arg `TIME' instead of `TIMEVAL'.
3963
d1410150
EZ
39642011-08-06 Eli Zaretskii <eliz@gnu.org>
3965
3966 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3967 display property strides EOL and includes a newline, as in
3968 longlines-mode. (Bug#9254)
75b771e4
EZ
3969 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3970 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3971
3972 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3973 is non-zero, even if the data buffer is NULL. Fixes a crash in
3974 vertical-motion with longlines-mode. (Bug#9254)
3975
35928349
EZ
39762011-08-05 Eli Zaretskii <eliz@gnu.org>
3977
ec7cc85b
EZ
3978 * bidi.c <bidi_cache_total_alloc>: Now static.
3979 (bidi_initialize): Initialize bidi_cache_total_alloc.
3980
8b76d6f8 3981 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3982 cache. (Bug#9221)
3983
3984 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3985 amount allocated this far in `bidi_cache_total_alloc'.
3986 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3987 non-zero, only free the data buffer without restoring the cache
3988 contents. All callers changed.
3989
3990 * dispextern.h (bidi_unshelve_cache): Update prototype.
3991
3992 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3993 (move_it_in_display_line, move_it_to)
3994 (move_it_vertically_backward, move_it_by_lines): Replace the call
3995 to xfree to an equivalent call to bidi_unshelve_cache.
3996 (move_it_in_display_line_to): Fix logic of returning
412b6358 3997 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3998
e2e2423b
EZ
39992011-08-05 Eli Zaretskii <eliz@gnu.org>
4000
4001 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
4002 came from a string character with a `cursor' property. (Bug#9229)
4003
ae9e757a
JD
40042011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4005
4006 * Makefile.in (LIB_PTHREAD): New variable.
4007 (LIBES): Add LIB_PTHREAD (Bug#9216).
4008
4009 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
4010 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
4011
213bd7f2
AS
40122011-08-04 Andreas Schwab <schwab@linux-m68k.org>
4013
6b02f655 4014 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 4015
99aaf75f
JD
40162011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4017
4018 * xterm.c (x_find_topmost_parent): New function.
4019 (x_set_frame_alpha): Find topmost parent window with
4020 x_find_topmost_parent and set the property there also (bug#9181).
4021 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4022
c74e9d86
PE
40232011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4024
4025 * callproc.c (Fcall_process): Avoid vfork clobbering
4026 the local vars buffer, coding_systems, current_dir.
4027
640c8776
SM
40282011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4029
4030 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4031
f26d0e4c
PE
40322011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4033
8a10d76c
PE
4034 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4035 so that it is not optimized away.
4036
f26d0e4c
PE
4037 * xdisp.c (compute_display_string_pos): Remove unused local.
4038
55439c61
EZ
40392011-08-02 Eli Zaretskii <eliz@gnu.org>
4040
4041 Fix slow cursor motion and scrolling in large buffers with
4042 selective display, like Org Mode buffers. (Bug#9218)
4043
4044 * dispextern.h (struct bidi_it): New member disp_prop_p.
4045
4046 * xdisp.c: Remove one-slot cache of display string positions.
4047 (compute_display_string_pos): Accept an additional argument
5e617bc2 4048 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
4049 for a display string or property. If found, set DISP_PROP_P
4050 non-zero.
4051
4052 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
4053 DISP_PROP_P, and pass it to compute_display_string_pos.
4054 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
4055 non-zero. All callers of bidi_fetch_char changed.
4056
fb33fa43
SM
40572011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
4058
4059 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
4060
b099e063
DM
40612010-12-03 Don March <don@ohspite.net>
4062
4063 * keymap.c (Fdefine_key): Fix non-prefix key error message when
4064 last character M-[char] is translated to ESC [char] (bug#7541).
4065
5cc7f7af
KH
40662011-08-02 Kenichi Handa <handa@m17n.org>
4067
d0fffa3f 4068 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
4069
4070 * chartab.c (uniprop_table): Make it non-static.
4071
525d5e6e
EZ
40722011-08-01 Eli Zaretskii <eliz@gnu.org>
4073
4074 * xdisp.c (forward_to_next_line_start): Accept additional argument
4075 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4076 on the newline.
4077 (reseat_at_next_visible_line_start): Use the bidi iterator state
4078 returned by forward_to_next_line_start to restore the state of
4079 it->bidi_it after backing up to previous newline. (Bug#9212)
4080
31011111
AS
40812011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4082
4083 * regex.c (re_comp): Protoize.
4084 (re_exec): Fix return type.
4085 (regexec): Fix type of `ret'. (Bug#9203)
4086
476371c4
PE
40872011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4088
e5d76069
PE
4089 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4090 This is needed if max-image-size is a floating-point number.
4091
9a79b20c
AS
40922011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4093
4094 * print.c (print_object): Print empty symbol as ##.
4095
4096 * lread.c (read1): Read ## as empty symbol.
4097
d8c2fa78
AA
40982011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4099
4100 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4101 setting frame foreground color (Bug#9175).
4102 (x_set_background_color): Likewise.
4103
ffe57a7a
AA
4104 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4105 contents (Bug#9176).
4106 (EmacsTooltip -init): Remove bezels and add shadows to
4107 tooltip windows.
4108
bf3492a5
AA
4109 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4110 or scroll bar (Bug#8470).
4111
d55e9c53
AA
4112 * nsfont.m (nsfont_open): Remove assignment to voffset and
4113 unnecessary vars hshink, expand, hd, full_height, min_height.
4114 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4115
4116 * nsterm.h (nsfont_info): Remove voffset field.
4117
d8c2fa78 41182011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
4119
4120 Implement strike-through and overline on NextStep (Bug#8863).
4121
4122 * nsfont.m (nsfont_open): Use underline position provided by font,
4123 instead of hard-coded value of 2.
4124 (nsfont_draw): Call ns_draw_text_decoration instead.
4125
4126 * nsterm.h: Add declaration for ns_draw_text_decoration.
4127
4128 * nsterm.m (ns_draw_text_decoration): New function for drawing
4129 underline, overline, and strike-through.
4130 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4131 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 4132 accommodate underlining, etc.
4843aac3 4133
4cc60b9b
EZ
41342011-07-28 Eli Zaretskii <eliz@gnu.org>
4135
bc7ece87
EZ
4136 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
4137 default.
4cc60b9b 4138
476371c4
PE
41392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4140
66606eea
PE
4141 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
4142 Without this fix, if a signal arrives just after memory fills up,
4143 'malloc' might be invoked reentrantly.
4144
476371c4
PE
4145 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4146 In other words, assume that every image size is allowed, on non-X
4147 hosts. This assumption is probably wrong, but it lets Emacs compile.
4148
f3fcc40d
AS
41492011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4150
4151 * regex.c (re_iswctype): Convert return values to boolean.
4152
350c992f
EZ
41532011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4154
4155 * xdisp.c (compute_display_string_pos): Don't use cached display
4156 string position if the buffer had its restriction changed.
4157 (Bug#9184)
4158
5266b4bb
PE
41592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4160
4161 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4162
2573a837 41632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 4164
41f55ccd 4165 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 4166
39e378da
PE
4167 * bidi.c: Integer size and overflow fixes.
4168 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4169 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4170 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4171 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4172 (bidi_find_other_level_edge):
4173 Use ptrdiff_t instead of EMACS_INT where either will do.
4174 This works better on 32-bit hosts configured --with-wide-int.
4175 (bidi_cache_ensure_space): Check for size-calculation overflow.
4176 Use % rather than repeated addition, for better worst-case speed.
4177 Don't set bidi_cache_size until after xrealloc returns, because it
4178 might not return.
4179 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
4180 (bidi_cache_ensure_space): Also check that the bidi cache size
4181 does not exceed that of the largest Lisp string or buffer. See Eli
4182 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 4183
5e927815
PE
4184 * alloc.c (__malloc_size_t): Remove.
4185 All uses replaced by size_t. See Andreas Schwab's note
4186 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4187
ca4aa935
PE
4188 * image.c: Improve checking for integer overflow.
4189 (check_image_size): Assume that f is nonnull, since
4190 it is always nonnull in practice. This is one less thing to
4191 worry about when checking for integer overflow later.
4192 (x_check_image_size): New function, which checks for integer
4193 overflow issues inside X.
4194 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4195 This removes the need for a memory_full check.
4196 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4197 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4198 (xbm_read_bitmap_data): Change locals back to 'int', since
4199 their values must fit in 'int'.
4200 (xpm_load_image, png_load, tiff_load):
4201 Invoke x_create_x_image_and_pixmap earlier,
4202 to avoid much needless work if the image is too large.
4203 (tiff_load): Treat overly large images as if
4204 x_create_x_image_and_pixmap failed, not as malloc failures.
4205 (gs_load): Use x_check_image_size.
4206
5f8f9cc2
PE
4207 * gtkutil.c: Omit integer casts.
4208 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4209 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4210
5adf60bc
PE
4211 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4212
c8907a93
PE
4213 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4214 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4215 would wrongly return t on a 64-bit host.
4216
e3c25c68
PE
4217 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4218 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4219 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4220 and therefore cause GCC to emit a bogus diagnostic in some cases.
4221
3f791afe
PE
4222 * image.c: Integer signedness and overflow and related fixes.
4223 This is not an exhaustive set of fixes, but it's time to
4224 record what I've got.
4225 (lookup_pixel_color, check_image_size): Remove redundant decls.
4226 (check_image_size): Don't assume that arbitrary EMACS_INT values
4227 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4228 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4229 (tiff_load, imagemagick_load_image):
4230 Check for overflow in size calculations.
4231 (x_create_x_image_and_pixmap): Remove unnecessary test for
4232 xmalloc returning NULL; that can't happen.
4233 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4234 (xpm_color_bucket): Use better integer hashing function.
4235 (xpm_cache_color): Don't possibly over-allocate memory.
4236 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4237 (gif_memory_source):
4238 Use ptrdiff_t, not int or size_t, to record sizes.
4239 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4240 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4241 either works, as we prefer signed integers.
4242 (tiff_read_from_memory, tiff_write_from_memory):
4243 Return tsize_t, not size_t, since that's what the TIFF API wants.
4244 (tiff_read_from_memory): Don't fail simply because the read would
4245 go past EOF; instead, return a short read.
4246 (tiff_load): Omit no-longer-needed casts.
4247 (Fimagemagick_types): Don't assume size fits into 'int'.
4248
3cc5a532
PE
4249 Improve hashing quality when configured --with-wide-int.
4250 * fns.c (hash_string): New function, taken from sxhash_string.
4251 Do not discard information about ASCII character case; this
4252 discarding is no longer needed.
4253 (sxhash-string): Use it. Change sig to match it. Caller changed.
4254 * lisp.h: Declare it.
4255 * lread.c (hash_string): Remove, since we now use fns.c's version.
4256 The fns.c version returns a wider integer if --with-wide-int is
4257 specified, so this should help the quality of the hashing a bit.
4258
b312a492
PE
4259 * emacs.c: Integer overflow minor fix.
4260 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4261 Define only if GNU_LINUX.
4262 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4263
dfd153ae
PE
4264 * dispnew.c: Integer signedness and overflow fixes.
4265 Remove unnecessary forward decls, that were a maintenance hassle.
4266 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4267 All uses changed.
4268 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4269 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4270 (prepare_desired_row, line_draw_cost):
4271 Use int, not unsigned, where either works.
4272 (save_current_matrix, restore_current_matrix):
4273 Use ptrdiff_t, not size_t, where either works.
4274 (init_display): Check for overflow more accurately, and without
4275 relying on undefined behavior.
4276
a81d11a3
PE
4277 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4278 Remove, replacing with the new symbols in lisp.h. All uses changed.
4279 * fileio.c (make_temp_name):
4280 * filelock.c (lock_file_1, lock_file):
4281 * xdisp.c (message_dolog):
4282 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4283 Use pMd etc. instead.
4284 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4285 replacing the pWIDE etc. symbols removed from editfns.c.
4286
3300e6fd
PE
4287 * keyboard.h (num_input_events): Now uintmax_t.
4288 This is (very slightly) less likely to mess up due to wraparound.
4289 All uses changed.
4290
fd05c7e9
PE
4291 * buffer.c: Integer signedness fixes.
4292 (alloc_buffer_text, enlarge_buffer_text):
4293 Use ptrdiff_t rather than size_t when either will do, as we prefer
4294 signed integers.
4295
903fe15d
PE
4296 * alloc.c: Integer signedness and overflow fixes.
4297 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4298 (__malloc_size_t): Default to size_t, not to int.
4299 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4300 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4301 Prefer ptrdiff_t to size_t when either would do, as we prefer
4302 signed integers.
4303 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4304 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4305 Now const. Initialize with values that are in range even if char
4306 is signed.
4307 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4308 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4309 These functions do the right thing with sizes > 2**32.
4310 (check_depth): Now ptrdiff_t, not int.
4311 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4312 Adjust to new way of storing sizes. Check for size overflow bugs
4313 in rest of code.
4314 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4315 slightly wrong anyway, as it missed one instance of
4316 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4317 (refill_memory_reserve): Omit needless cast to size_t.
4318 (mark_object_loop_halt): Mark as externally visible.
4319
ac82cc6a
PE
4320 * xselect.c: Integer signedness and overflow fixes.
4321 (Fx_register_dnd_atom, x_handle_dnd_message):
4322 Use ptrdiff_t, not size_t, since we prefer signed.
4323 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4324 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4325 x_dnd_atoms_size and x_dnd_atoms_length.
4326
c2d1e36d
PE
4327 * doprnt.c: Prefer signed to unsigned when either works.
4328 * eval.c (verror):
4329 * doprnt.c (doprnt):
4330 * lisp.h (doprnt):
4331 * xdisp.c (vmessage):
4332 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4333 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4334 prefer signed arithmetic to avoid comparison confusion.
4335 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4336 but is a bit tricky.
4337
0e926e56
PE
4338 Assume freestanding C89 headers, string.h, stdlib.h.
4339 * data.c, doprnt.c, floatfns.c, print.c:
4340 Include float.h unconditionally.
4341 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4342 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4343 * regex.c: Likewise for stddef.h, string.h.
4344 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4345 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4346 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4347 (STDC_HEADERS): Remove obsolete defines.
4348 * sysdep.c: Include limits.h unconditionally.
4349
9cfdb3ec
PE
4350 Assume support for memcmp, memcpy, memmove, memset.
4351 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4352 * regex.c (memcmp, memcpy):
4353 Remove; we assume C89 now.
4354
4355 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4356 (__malloc_safe_bcopy): Remove; no longer needed.
4357
cf950e6b 4358 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
4359 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4360 well either way, and we prefer signed to unsigned.
4361
dbf38e02
LMI
43622011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4363
4364 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4365 closes the connection while we're reading (bug#9182).
4366
d6f0886c 43672011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 4368
d6f0886c
JD
4369 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4370 are specified (Bug#9168).
24e0f6b1 4371
2eb1f9e6
PE
43722011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4373
4374 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4375 Found by GCC static checking and --with-wide-int on a 32-bit host.
4376
22381272 43772011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
4378
4379 * xdisp.c (compute_display_string_pos): Fix logic of caching
4380 previous display string position. Initialize cached_prev_pos to
4381 -1. Fixes slow-down at the beginning of a buffer.
4382
f25e39b4
EZ
43832011-07-24 Eli Zaretskii <eliz@gnu.org>
4384
4385 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4386 for attrs[LFACE_FONTSET_INDEX].
4387
04c4b52e
PE
43882011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4389
4390 * xml.c (parse_region): Remove unused local
4391 that was recently introduced.
4392
c1734fbd
EZ
43932011-07-23 Eli Zaretskii <eliz@gnu.org>
4394
be18c5a5
EZ
4395 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4396 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4397
c1734fbd
EZ
4398 * xdisp.c (move_it_in_display_line_to): Record the best matching
4399 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
4400 exit if none of the characters scanned was an exact match.
4401 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
4402 when exact match is impossible due to invisible text, and the
4403 lines are truncated.
4404
a258d627
JD
44052011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4406
4407 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4408 for OSX >= 10.7.
4409
b6d5a689
EZ
44102011-07-22 Eli Zaretskii <eliz@gnu.org>
4411
0f74f785
EZ
4412 Fix a significant slow-down of cursor motion with C-n, C-p,
4413 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4414 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 4415 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
4416 (next_element_from_buffer): Call compute_stop_pos_backwards to
4417 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
4418 base_level_stop.
4419 (reseat): Don't look for prev_stop, as that could mean a very long
4420 run.
4421 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4422 <cached_disp_overlay_modiff>: Cache for last found display string
4423 position.
551918c1 4424 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
4425 about the same buffer in the same area of character positions, and
4426 the buffer wasn't changed since the time the display string
4427 position was cached.
551918c1 4428
b2d0c91a
EZ
44292011-07-22 Eli Zaretskii <eliz@gnu.org>
4430
4431 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4432 is an integer, which is important for empty lines. (Bug#9149)
4433
043604ee
CY
44342011-07-22 Chong Yidong <cyd@stupidchicken.com>
4435
4436 * frame.c (Fmodify_frame_parameters): In tty case, update the
4437 default face if necessary (Bug#4238).
4438
da4adb04
CY
44392011-07-21 Chong Yidong <cyd@stupidchicken.com>
4440
4441 * editfns.c (Fstring_to_char): No need to explain what a character
4442 is in the docstring (Bug#6576).
4443
9abd0532
LMI
44442011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4445
4446 * xml.c (parse_region): Make sure we always return a tree.
4447
36881d16
HK
44482011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4449
4450 * xml.c (parse_region): If a document contains only comments,
4451 return that, too.
4452
1e98674d
LMI
44532011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4454
4455 * xml.c (make_dom): Return comments, too.
4456
590bd467
PE
44572011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4458
4459 Port to OpenBSD.
4460 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4461 and the surrounding thread.
4462 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4463 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4464 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4465 timer goes off.
4466 * s/openbsd.h (BROKEN_SIGIO): Define.
4467 * unexelf.c (unexec) [__OpenBSD__]:
4468 Don't update the .mdebug section of the Alpha COFF symbol table.
4469
f41628b2
LMI
44702011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4471
4472 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4473 (bug#8460).
4474
b59b67c5
PE
44752011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4476
15e3a074
PE
4477 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4478 This fixes some race conditions on the permissions of any newly
4479 created file.
4480
41bed37d
PE
4481 * alloc.c (valid_pointer_p): Use pipe, not open.
4482 This fixes some permissions issues when debugging.
4483
b59b67c5
PE
4484 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4485 If fchown fails to set both uid and gid, try to set just gid,
4486 as that is sometimes allowed. Adjust the file's mode to eliminate
4487 setuid or setgid bits that are inappropriate if fchown fails.
4488
925a6be7
SM
44892011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4490
4491 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4492 to compare Lisp_Objects.
4493 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4494 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4495 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4496
52968808
AS
44972011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4498
0a6a104b
AS
4499 * lread.c (read_integer): Unread even EOF character.
4500 (read1): Likewise. Properly record start position of symbol.
4501
52968808
AS
4502 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4503 symbol character follows.
4504
9e381cdd
PE
45052011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4506
4507 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4508 This works around a problem with the previous change to Fcopy_file.
4509 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4510 and without this change, GCC might complain about discarding
4511 fchown's return value.
4512
b5641435
JB
45132011-07-16 Juanma Barranquero <lekktu@gmail.com>
4514
4515 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4516
a8031457
PE
45172011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4518
4519 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4520
dd889327
LMI
45212011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4522
750c33f7
LMI
4523 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4524 it's used from the C level.
4525
dd889327
LMI
4526 * process.c: Use the same condition for POLL_FOR_INPUT in both
4527 keyboard.c and process.c (bug#1858).
4528
87e86684
LM
45292011-07-09 Lawrence Mitchell <wence@gmx.li>
4530
4531 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4532 (Fgnutls_boot): Use it.
4533
64348f40
AS
45342011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4535
4536 * doc.c (Fsubstitute_command_keys): Revert last change.
4537
1d698799
LMI
45382011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4539
f863868c
LMI
4540 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4541 quotes the next character, and doesn't affect other longer
4542 sequences (bug#8935).
4543
1d698799
LMI
4544 * lread.c (syms_of_lread): Clarify that is isn't only
4545 `eval-buffer' and `eval-defun' that's affected by
4546 `lexical-binding' (bug#8460).
4547
aa4b6df6
EZ
45482011-07-15 Eli Zaretskii <eliz@gnu.org>
4549
4550 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4551 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4552
5d856da6
PE
45532011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4554
ad6042bb
PE
4555 Fix minor problems found by static checking.
4556 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4557 (elsz): Now a signed constant, not a size_t var. We prefer signed
4558 types to unsigned, to avoid integer comparison confusion. Without
4559 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4560 "cannot optimize loop, the loop counter may overflow", a symptom
4561 of the confusion.
f00bbb22 4562 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4563 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4564
6468f31c
LMI
45652011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4566
49080b10
LMI
4567 * search.c (Fre_search_backward): Mention `case-fold-search' in
4568 all the re_search_* functions (bug#8138).
4569
6468f31c
LMI
4570 * keyboard.c (Fopen_dribble_file): Document when the file is
4571 closed (bug#8056).
4572
c965adc5
EZ
45732011-07-14 Eli Zaretskii <eliz@gnu.org>
4574
df9733bf
EZ
4575 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4576 bidi_cache_idx.
4577
0bb23927
EZ
4578 Support bidi reordering of display and overlay strings.
4579 * xdisp.c (compute_display_string_pos)
4580 (compute_display_string_end): Accept additional argument STRING.
4581 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4582 (reseat_to_string): Initialize bidi_it->string.s and
4583 bidi_it->string.schars.
4584 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4585 NULL (avoids a crash in bidi_paragraph_init).
4586 Initialize itb.string.lstring.
0bb23927
EZ
4587 (init_iterator): Call bidi_init_it only of a valid
4588 buffer position was specified. Initialize paragraph_embedding to
4589 L2R.
4590 (reseat_to_string): Initialize the bidi iterator.
4591 (display_string): If we need to ignore text properties of
4592 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4593 original value of -1 will not work with bidi.)
4594 (compute_display_string_pos): First arg is now struct
4595 `text_pos *'; all callers changed. Support display properties on
4596 Lisp strings.
4597 (compute_display_string_end): Support display properties on Lisp
4598 strings.
4599 (init_iterator, reseat_1, reseat_to_string): Initialize the
4600 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4601 when iterating on a string not from display properties).
640c8776
SM
4602 (compute_display_string_pos, compute_display_string_end):
4603 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4604 arrow keys.
4605 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4606 base_level_stop; instead, set base_level_stop to BEGV.
4607 Fixes crashes in vertical-motion.
0bb23927
EZ
4608 (next_element_from_buffer): Improve commentary for when
4609 the iterator is before prev_stop.
4610 (init_iterator): Initialize bidi_p from the default value of
4611 bidi-display-reordering, not from buffer-local value. Use the
4612 buffer-local value only if initializing for buffer iteration.
4613 (handle_invisible_prop): Support invisible properties on strings
4614 that are being bidi-reordered.
4615 (set_iterator_to_next): Support bidi reordering of C strings and
4616 Lisp strings.
4617 (next_element_from_string): Support bidi reordering of Lisp
4618 strings.
4619 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4620 (display_string): Support display of R2L glyph rows.
4621 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4622 (init_iterator): Don't initialize it->bidi_p for strings
4623 here.
4624 (reseat_to_string): Initialize it->bidi_p for strings here.
4625 (next_element_from_string, next_element_from_c_string)
4626 (next_element_from_buffer): Add xassert's for correspondence
4627 between IT's object being iterated and it->bidi_it.string
4628 structure.
4629 (face_before_or_after_it_pos): Support bidi iteration.
4630 (next_element_from_c_string): Handle the case of the first string
4631 character that is not the first one in the visual order.
4632 (get_visually_first_element): New function, refactored from common
4633 parts of next_element_from_buffer, next_element_from_string, and
4634 next_element_from_c_string.
4635 (tool_bar_lines_needed, redisplay_tool_bar)
4636 (display_menu_bar): Force left-to-right direction. Add a FIXME
4637 comment for making that be controlled by a user option.
4638 (push_it, pop_it): Save and restore the state of the
4639 bidi iterator. Save and restore the bidi_p flag.
4640 (pop_it): Iterate out of display property for string iteration as
4641 well.
4642 (iterate_out_of_display_property): Support iteration over strings.
4643 (handle_single_display_spec): Set up it->bidi_it for iteration
4644 over a display string, and call bidi_init_it.
4645 (handle_single_display_spec, next_overlay_string)
4646 (get_overlay_strings_1, push_display_prop): Set up the bidi
4647 iterator for displaying display or overlay strings.
4648 (forward_to_next_line_start): Don't use the shortcut if
4649 bidi-iterating.
4650 (back_to_previous_visible_line_start): If handle_display_prop
4651 pushed the iterator stack, restore the internal state of the bidi
4652 iterator by calling bidi_pop_it same number of times.
4653 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4654 and we are bidi-iterating, don't decrement the iterator position;
4655 instead, set the first_elt flag in the bidi iterator, to produce
4656 the same effect.
4657 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4658 (push_display_prop): xassert that we are iterating a buffer.
4659 (push_it, pop_it): Save and restore paragraph_embedding member.
4660 (handle_single_display_spec, next_overlay_string)
4661 (get_overlay_strings_1, reseat_1, reseat_to_string)
4662 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4663 correctly. Don't assume unibyte strings are not bidi-reordered.
4664 (compute_display_string_pos)
4665 (compute_display_string_end): Fix handling the case of C string.
4666 (push_it, pop_it): Save and restore from_disp_prop_p.
4667 (handle_single_display_spec, push_display_prop): Set the
4668 from_disp_prop_p flag.
4669 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4670 (pop_it): Call iterate_out_of_display_property only if we are
4671 popping after iteration over a string that came from a display
4672 property. Fix a typo in popping stretch info. Add an assertion
4673 for verifying that the iterator position is in sync with the bidi
4674 iterator.
4675 (handle_single_display_spec, get_overlay_strings_1)
4676 (push_display_prop): Fix initialization of paragraph direction for
4677 string when that of the parent object is not yet determined.
4678 (reseat_1): Call bidi_init_it to resync the bidi
4679 iterator with IT's position. (Bug#7616)
4680 (find_row_edges): If ROW->start.pos gives position
4681 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4682 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4683 Reset the from_disp_prop_p flag.
4684 (SAVE_IT, RESTORE_IT): New macros.
4685 (pos_visible_p, face_before_or_after_it_pos)
4686 (back_to_previous_visible_line_start)
4687 (move_it_in_display_line_to, move_it_in_display_line)
4688 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4689 (try_scrolling, redisplay_window, display_line): Use them when
4690 saving a temporary copy of the iterator and restoring it back.
4691 (back_to_previous_visible_line_start, reseat_1)
4692 (init_iterator): Empty the bidi cache "stack".
4693 (move_it_in_display_line_to): If iterator ended up at
4694 EOL, but we never saw any buffer positions smaller than
4695 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4696 motion in bidi-reordered lines.
4697 (move_it_in_display_line_to): Record prev_method and prev_pos
4698 immediately before the call to set_iterator_to_next. Fixes cursor
4699 motion in bidi-reordered lines with stretch glyphs and strings
4700 displayed in margins. (Bug#8133) (Bug#8867)
4701 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4702 TO_CHARPOS.
640c8776
SM
4703 (pos_visible_p): Support positions in bidi-reordered lines.
4704 Save and restore bidi cache.
0bb23927
EZ
4705
4706 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4707 (bidi_paragraph_info): Delete unused struct.
4708 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4709 (bidi_cache_start): New variable.
4710 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4711 to zero.
4712 (bidi_cache_fetch_state, bidi_cache_search)
4713 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4714 (bidi_cache_find, bidi_peek_at_next_level)
4715 (bidi_level_of_next_char, bidi_find_other_level_edge)
4716 (bidi_move_to_visually_next): Compare cache index with
4717 bidi_cache_start rather than with zero.
4718 (bidi_fetch_char): Accept new argument STRING; all callers
4719 changed. Support iteration over a string. Support strings with
4720 display properties. Support unibyte strings. Fix the type of
4721 `len' according to what STRING_CHAR_AND_LENGTH expects.
4722 (bidi_paragraph_init, bidi_resolve_explicit_1)
4723 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4724 (bidi_level_of_next_char, bidi_move_to_visually_next):
4725 Support iteration over a string.
0bb23927
EZ
4726 (bidi_set_sor_type, bidi_resolve_explicit_1)
4727 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4728 can now be zero (for strings); special values 0 and -1 were
4729 changed to -1 and -2, respectively.
4730 (bidi_char_at_pos): New function.
4731 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4732 Call it instead of FETCH_MULTIBYTE_CHAR.
4733 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4734 initialized to valid values.
4735 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4736 values.
4737 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4738 the test for valid cached positions. Fix the logic for looking up
4739 the sentinel state in the cache. GCPRO the Lisp string we are
4740 iterating.
4741 (bidi_push_it, bidi_pop_it): New functions.
4742 (bidi_initialize): Initialize the bidi cache start stack pointer.
4743 (bidi_cache_ensure_space): New function, refactored from part of
4744 bidi_cache_iterator_state. Don't assume the required size is just
4745 one BIDI_CACHE_CHUNK away.
4746 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4747 (bidi_count_bytes, bidi_char_at_pos): New functions.
4748 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4749 always valid if bidi_cache_idx is valid.
4750 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4751 is valid if it's going to be used.
4752 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4753 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4754 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4755 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4756 (bidi_find_other_level_edge, bidi_cache_start_stack):
4757 All variables related to cache indices are now EMACS_INT.
c965adc5 4758
0bb23927
EZ
4759 * dispextern.h (struct bidi_string_data): New structure.
4760 (struct bidi_it): New member `string'. Make flag members be 1-bit
4761 fields, and put them last in the struct.
640c8776
SM
4762 (compute_display_string_pos, compute_display_string_end):
4763 Update prototypes.
0bb23927
EZ
4764 (bidi_push_it, bidi_pop_it): Add prototypes.
4765 (struct iterator_stack_entry): New members bidi_p,
4766 paragraph_embedding, and from_disp_prop_p.
4767 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4768 (bidi_shelve_cache, bidi_unshelve_cache):
4769 Declare prototypes.
0bb23927
EZ
4770
4771 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4772 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4773 and vector-like objects.
4774
4775 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4776 cache around display iteration.
4777
4778 * window.c (Fwindow_end, window_scroll_pixel_based)
4779 (displayed_window_lines, Frecenter): Save and restore the bidi
4780 cache around display iteration.
4781
3bbd2265
LMI
47822011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4783
4784 * editfns.c (Fdelete_region): Clarify the use of the named
4785 parameters (bug#6788).
4786
adc47434
MR
47872011-07-14 Martin Rudalics <rudalics@gmx.at>
4788
4789 * indent.c (Fvertical_motion): Set and restore w->pointm when
4790 saving and restoring the window's buffer (Bug#9006).
4791
837c31f8
LMI
47922011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4793
4794 * editfns.c (Fstring_to_char): Clarify just what is returned
4795 (bug#6576). Text by Eli Zaretskii.
4796
ac389d0c
JB
47972011-07-13 Juanma Barranquero <lekktu@gmail.com>
4798
4799 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4800
0be0ce47
EZ
48012011-07-13 Eli Zaretskii <eliz@gnu.org>
4802
4803 * buffer.c (mmap_find): Fix a typo.
4804
cd18e7e3
JB
48052011-07-13 Johan Bockgård <bojohan@gnu.org>
4806
4807 Fix execution of x selection hooks.
4808 * xselect.c (Qx_lost_selection_functions)
4809 (Qx_sent_selection_functions): New vars.
4810 (syms_of_xselect): DEFSYM them.
4811 (x_handle_selection_request): Pass Qx_sent_selection_functions
4812 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4813 (x_handle_selection_clear,x_clear_frame_selections):
4814 Pass Qx_lost_selection_functions rather than
4815 Vx_lost_selection_functions to Frun_hook_with_args.
4816
47ea7f44
PE
48172011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4818
ac389d0c 4819 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4820 The old code sometimes used this field without initializing it.
4821
47ea7f44
PE
4822 * alloc.c (gc_sweep): Don't read past end of array.
4823 In theory, the old code could also have corrupted Emacs internals,
4824 though it'd be very unlikely.
4825
bc985c87
AS
48262011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4827
4828 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4829 argument. (Bug#4026)
bc985c87 4830
0cf34688
LMI
48312011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4832
b3dadd76
LMI
4833 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4834 key" (bug#4257).
4835
0cf34688
LMI
4836 * window.c (Fset_window_start): Doc fix (bug#4199).
4837 (Fset_window_hscroll): Ditto.
4838
270768cd
PE
48392011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4840
077e3dda 4841 Fix minor new problems caught by GCC 4.6.1.
270768cd 4842 * term.c (init_tty): Remove unused local.
490011a6 4843 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4844 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4845 not used otherwise.
270768cd 4846
b1f58454
CY
48472011-07-12 Chong Yidong <cyd@stupidchicken.com>
4848
4849 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4850
22b9578d
LMI
48512011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4852
6e70ab07
LMI
4853 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4854 are the mini-buffer and the echo area (bug#3320).
4855
22b9578d
LMI
4856 * term.c (init_tty): Remove support for supdup, c10 and perq
4857 terminals, which are no longer supported (bug#1482).
4858
8974cc9f
JB
48592011-07-10 Johan Bockgård <bojohan@gnu.org>
4860
4861 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4862
a560d974
JD
48632011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4864
4865 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4866 for non-popups (Bug#3642).
4867
1dae0f0a
AS
48682011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4869
268c2c36 4870 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4871 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4872 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4873 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4874 * data.c (fmod): Likewise.
4875 * dispnew.c (swap_glyphs_in_rows): Likewise.
4876 * emacs.c (memory_warning_signal): Likewise.
4877 * floatfns.c (float_error): Likewise.
4878 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4879 (otf_open, font_otf_capability, generate_otf_features)
4880 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4881 Likewise.
4882 * image.c (pbm_read_file): Likewise.
4883 * indent.c (string_display_width): Likewise.
4884 * intervals.c (check_for_interval, search_for_interval)
4885 (inc_interval_count, count_intervals, root_interval)
4886 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4887 * lread.c (defalias): Likewise.
268c2c36 4888 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4889 * regex.c (set_image_of_range_1, set_image_of_range)
4890 (regex_grow_registers): Likewise.
4891 * sysdep.c (strerror): Likewise.
4892 * termcap.c (valid_filename_p, tprint, main): Likewise.
4893 * tparam.c (main): Likewise.
4894 * unexhp9k800.c (run_time_remap, save_data_space)
4895 (update_file_ptrs, read_header, write_header, calculate_checksum)
4896 (copy_file, copy_rest, display_header): Likewise.
4897 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4898 Likewise.
4899 * xdisp.c (check_it): Likewise.
4900 * xfaces.c (register_color, unregister_color, unregister_colors):
4901 Likewise.
4902 * xfns.c (print_fontset_result): Likewise.
4903 * xrdb.c (member, fatal, main): Likewise.
4904
99033785
PE
49052011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4906
4907 Fix minor problems found by static checking (Bug#9031).
4908 * chartab.c (char_table_set_range, map_sub_char_table):
4909 Remove unused locals.
4910 (uniprop_table): Now static.
4911 * composite.c (_work_char): Remove unused static var.
4912
9cb2ac56
JB
49132011-07-09 Juanma Barranquero <lekktu@gmail.com>
4914
4915 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4916
f25661f0
JD
49172011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4918
4919 * gtkutil.c (qttip_cb): Remove code without function.
4920
8278c4fe
EZ
49212011-07-09 Eli Zaretskii <eliz@gnu.org>
4922
4923 * w32.c (pthread_sigmask): New stub.
4924
1692ae2d 49252011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4926
8a6ebd58 4927 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4928 sigprocmask is portable only for single-threaded applications, and
4929 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4930 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4931 (LIBES): Use it.
4932 * callproc.c (Fcall_process):
4933 * process.c (create_process):
4934 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4935 Use pthread_sigmask, not sigprocmask.
123403e4 4936
1b854618
JD
49372011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4938
4939 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4940 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4941 wrong (Bug#8591).
4942
3fe4b549
JD
49432011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4944
0ce7e563
JD
4945 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4946 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4947 (xg_hide_tooltip): Fix comment.
4948
3fe4b549
JD
4949 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4950 in registerServicesMenuSendTypes.
4951 (validRequestorForSendType): Don't check ns_return_types.
4952
4953 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4954 ns_return_type.
4955
5df75e47
JR
49562011-07-08 Jason Rumney <jasonr@gnu.org>
4957
22610910
JR
4958 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4959 SH_SHOW for hidden windows (Bug#5482).
4960
5df75e47
JR
4961 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4962 frame struct members of non-existent frames (Bug#6284).
4963
699c10bd
JD
49642011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4965
4393663b
JD
4966 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4967 variable firstTime not needed on OSX >= 10.6.
4968 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4969 >= 10.5. Use setKnobProportion, setDoubleValue.
4970
4971 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4972 (MAC_OS_X_VERSION_10_5): Define if not defined.
4973 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4974 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4975 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4976
4977 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4978 cString and lossyCString on OSX >= 10.4
4979
58179cce 4980 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4981 sizeToFit on OSX >= 10.2.
4982
4983 * nsimage.m (allocInitFromFile): Don't use deprecated method
4984 bestRepresentationForDevice on OSX >= 10.6.
4985
4986 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4987 to avoid warning.
4988
4989 * emacs.c: Declare unexec_init_emacs_zone.
4990
a63e0781
JD
4991 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4992
699c10bd
JD
4993 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4994
4995 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4996 on svcsMenu (Bug#8842).
4997
4998 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4999 ns_return_types.
5000 (Fns_list_services): Just return Qnil on 10.6, code not working there.
5001
5002 * nsterm.m (QUTF8_STRING): Declare.
5003 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
5004 (validRequestorForSendType): Return type is (id).
5005 Change indexOfObjectIdenticalTo to indexOfObject.
5006 Check if we have local selection before returning self (Bug#8842).
5007 (writeSelectionToPasteboard): Put local selection into paste board
5008 if we have a local selection (Bug#8842).
5009 (syms_of_nsterm): DEFSYM QUTF8_STRING.
5010
5011 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
5012 (ns_get_local_selection): Declare.
5013
54e10184
LMI
50142011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5015
9888ff71
LMI
5016 * keymap.c (describe_map_tree): Don't insert a double newline at
5017 the end of the buffer (bug#1169) and return whether we inserted
5018 something.
5019
54e10184
LMI
5020 * callint.c (Fcall_interactively): Change "reading args" to
5021 "providing args" to try to clarify what it does (bug#1010).
5022
15fa4783
KH
50232011-07-07 Kenichi Handa <handa@m17n.org>
5024
5025 * composite.c (composition_compute_stop_pos): Ignore a static
5026 composition starting before CHARPOS (Bug#8915).
5027
5028 * xdisp.c (handle_composition_prop): Likewise.
5029
a8815b00
EZ
50302011-07-07 Eli Zaretskii <eliz@gnu.org>
5031
5032 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5033 (Bug#9015)
5034
ef7b981d 50352011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
5036
5037 * character.h (unicode_category_t): New enum type.
5038
5039 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5040 (Qchar_code_property_table): New variable.
5041 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5042 (UNIPROP_COMPRESSED_FORM_P): New macros.
5043 (char_table_ascii): Uncompress the compressed values.
5044 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5045 Uncompress the compressed values.
ac389d0c 5046 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
5047 (char_table_ref_and_range): Uncompress the compressed values.
5048 (sub_char_table_set): New arg is_uniprop. Callers changed.
5049 Uncompress the compressed values.
5050 (sub_char_table_set_range): Args changed. Callers changed.
5051 (char_table_set_range): Adjuted for the above change.
5052 (map_sub_char_table): Delete args default_val and parent. Add arg
5053 top. Give decoded values to a Lisp function.
640c8776 5054 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
5055 values to a Lisp function. Gcpro more variables.
5056 (uniprop_table_uncompress)
5057 (uniprop_decode_value_run_length): New functions.
5058 (uniprop_decoder, uniprop_decoder_count): New variables.
5059 (uniprop_get_decoder, uniprop_encode_value_character)
5060 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
5061 New functions.
5062 (uniprop_encoder, uniprop_encoder_count): New variables.
5063 (uniprop_get_encoder, uniprop_table)
5064 (Funicode_property_table_internal, Fget_unicode_property_internal)
5065 (Fput_unicode_property_internal): New functions.
5066 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
5067 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 5068 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
5069 char-code-property-alist.
5070
640c8776 5071 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
5072 Vunicode_category_table.
5073
640c8776 5074 * font.c (font_range): Adjust for the change of
c805dec0
KH
5075 Vunicode_category_table.
5076
76b397fb
DN
50772011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5078
5079 * m/iris4d.h: Remove file, move contents ...
5080 * s/irix6-5.h: ... here.
5081
22b4128e
PE
50822011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5083
5084 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
5085 * alloc.c (mark_buffer):
5086 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5087 (clone_per_buffer_values): Don't assume that
22b4128e
PE
5088 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5089 This isn't true in general, and it's particularly not true
5090 if Emacs is configured with --with-wide-int.
5091 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5092 New macros, used in the buffer.c change.
5093
869795d6
JD
50942011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5095
5096 * xsettings.c: Use both GConf and GSettings if both are available.
5097 (store_config_changed_event): Add comment.
5098 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5099 (store_tool_bar_style_changed): New functions.
5e617bc2 5100 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
5101 (struct xsettings): Move font inside HAVE_XFT.
5102 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 5103 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 5104 Move inside HAVE_XFT.
640c8776 5105 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
5106 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5107 also.
5108 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 5109 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 5110 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
5111 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5112 (parse_settings): Move check for font inside HAVE_XFT.
5113 (read_settings, apply_xft_settings): Add comment.
5114 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
5115 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5116 call store_font_name_changed.
5117 (xft_settings_event): Add comment.
5118 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5119 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5120 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5121 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5122 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
5123 (xsettings_get_system_font, xsettings_get_system_normal_font):
5124 Add comment.
869795d6 5125
d8ed26bd
PE
51262011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5127
5128 Random fixes. E.g., (random) never returned negative values.
5129 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5130 subseconds part to the entropy, as that's a bit more random.
5131 Prefer signed to unsigned, since the signedness doesn't matter and
5132 in general we prefer signed. When given a limit, use a
5133 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5134 latter isn't right if USE_2_TAGS_FOR_INTS.
5135 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5136 not 0..VALMASK. Don't discard "excess" bits that random () returns.
5137
cabf1cac
SM
51382011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5139
5140 * textprop.c (text_property_stickiness):
5141 Obey Vtext_property_default_nonsticky.
5142 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
5143 * w32fns.c (syms_of_w32fns):
5144 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
5145
6e9b2be9
PE
51462011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5147
5148 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
5149 This is more efficient than Ffile_directory_p and avoids a minor race.
5150
90186c68
LMI
51512011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
5152
7c301272
LMI
5153 * buffer.c (Foverlay_put): Say what the return value is
5154 (bug#7835).
5155
c4f2d8d4
LMI
5156 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5157 is a directory before asking whether to use the file name
5158 (bug#7564).
ad637907
LMI
5159 (barf_or_query_if_file_exists): Make the "File is a directory"
5160 error be more correct.
c4f2d8d4 5161
90186c68
LMI
5162 * fns.c (Frequire): Remove the mention of the .gz files, since
5163 that's installation-specific, but keep the mention of
5164 `get-load-suffixes'.
5165
da64016e
PE
51662011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5167
5168 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5169 Report string overflow if the output is too long.
5170
7d47b580
JB
51712011-07-04 Juanma Barranquero <lekktu@gmail.com>
5172
a555cb87
JB
5173 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5174 (syms_of_gnutls): Remove duplicate DEFSYM for
5175 Qgnutls_bootprop_verify_hostname_error, an error for
5176 Qgnutls_bootprop_verify_error (which is no longer used).
5177
7d47b580
JB
5178 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5179 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5180 Also (re)move comments that are misplaced or no longer relevant.
5181
1e49bfab
LMI
51822011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5183
5184 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5185
1485f4c0
CY
51862011-07-03 Chong Yidong <cyd@stupidchicken.com>
5187
5188 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5189 and background color parameters if they have been changed.
5190
a9ab721e
LMI
51912011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5192
5193 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5194
cf7cff57
PE
51952011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5196
2e13213d
PE
5197 * xsettings.c (SYSTEM_FONT): Define only when used.
5198 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5199
cf7cff57
PE
5200 * keymap.c (access_keymap_1): Now static.
5201
7a8e04f7
CY
52022011-07-02 Chong Yidong <cyd@stupidchicken.com>
5203
5204 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5205 leave any prefix arg for the up event (Bug#1586).
5206
61352f62
LMI
52072011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5208
69bb1ef7
LMI
5209 * lread.c (syms_of_lread): Mention single symbols defined by
5210 `defvar' or `defconst' (bug#7154).
5211
61352f62 5212 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 5213 (Frequire): Mention get-load-suffixes.
61352f62 5214
28545e04
MR
52152011-07-02 Martin Rudalics <rudalics@gmx.at>
5216
5217 * window.h (window): Remove clone_number slot.
5218 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5219 Remove.
5220 (make_parent_window, make_window, saved_window)
5221 (Fset_window_configuration, save_window_save): Don't deal with
5222 clone numbers.
5223 * buffer.c (Qclone_number): Remove declaration.
5224 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5225
3349e122
SM
52262011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5227
5228 Add multiple inheritance to keymaps.
5229 * keymap.c (Fmake_composed_keymap): New function.
5230 (Fset_keymap_parent): Simplify.
5231 (fix_submap_inheritance): Remove.
5232 (access_keymap_1): New function extracted from access_keymap to handle
5233 embedded parents and handle lists of maps.
5234 (access_keymap): Use it.
5235 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5236 (Fcopy_keymap): Handle embedded parents.
5237 (Fcommand_remapping, define_as_prefix): Simplify.
5238 (Fkey_binding): Simplify.
5239 (syms_of_keymap): Move minibuffer-local-completion-map,
5240 minibuffer-local-filename-completion-map,
5241 minibuffer-local-must-match-map, and
5242 minibuffer-local-filename-must-match-map to Elisp.
5243 (syms_of_keymap): Defsubr make-composed-keymap.
5244 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5245 (parse_menu_item): Trivial simplification.
5246
3279eb87
GM
52472011-07-01 Glenn Morris <rgm@gnu.org>
5248
5249 * Makefile.in (SETTINGS_LIBS): Fix typo.
5250
4550efdf
KI
52512011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5252
5253 * coding.c (Fencode_coding_string): Record the last coding system
5254 used, as the function doc string says (bug#8738).
5255
0949d2b6
JD
52562011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5257
5258 * xsettings.c (store_monospaced_changed): Take new font as arg and
5259 check for change against current_mono_font.
5260 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5261 (emacs_settings_constructor, emacs_settings_get_property)
5262 (emacs_settings_set_property, emacs_settings_class_init)
5263 (emacs_settings_init, gsettings_obj): Remove.
5264 (something_changedCB): New function for HAVE_GSETTINGS.
5265 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5266 with value as argument.
5267 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5268 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 5269 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
5270 "changed".
5271
5272 * xgselect.c: Add defined (HAVE_GSETTINGS).
5273 (xgselect_initialize): Ditto.
5274
5275 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5276 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5277 xg_select.
5278
bbc6b304
PE
52792011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5280
5281 * eval.c (struct backtrace): Simplify and port the data structure.
5282 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5283 signed bit field, as this assumption is not portable and it makes
5284 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5285 "char debug_on_exit : 1" as this is not portable either; instead,
5286 use the portable "unsigned int debug_on_exit : 1". Remove unused
5287 member evalargs. Remove obsolete comments about cc bombing out.
5288
9851bfc5
JD
52892011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5290
51bb811f 5291 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
5292 Let HAVE_GSETTINGS override HAVE_GCONF.
5293 (store_monospaced_changed): New function.
5294 (EMACS_SETTINGS): A new type derived from GObject to handle
5295 GSettings notifications.
5296 (emacs_settings_constructor, emacs_settings_get_property)
5297 (emacs_settings_set_property, emacs_settings_class_init):
5298 New functions.
5299 (gsettings_client, gsettings_obj): New variables.
5300 (GSETTINGS_SCHEMA): New define.
5301 (something_changedCB): Call store_monospaced_changed.
5302 (init_gsettings): New function.
5303 (xsettings_initialize): Call init_gsettings.
5304 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5305 to NULL.
5306
640c8776 5307 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
5308 GCONF_CFLAGS/LIBS.
5309
5386012d
MR
53102011-06-29 Martin Rudalics <rudalics@gmx.at>
5311
5312 * window.c (resize_root_window, grow_mini_window)
5313 (shrink_mini_window): Rename Qresize_root_window to
5314 Qwindow_resize_root_window and Qresize_root_window_vertically to
5315 Qwindow_resize_root_window_vertically.
5316
f13e0b08
PE
53172011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5318
5319 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5320
94515237
JB
53212011-06-27 Juanma Barranquero <lekktu@gmail.com>
5322
5323 * makefile.w32-in: Redesign dependencies so they reflect more
5324 clearly which files are directly included by each source file,
5325 and not through other includes.
5326
e43b6e43
MR
53272011-06-27 Martin Rudalics <rudalics@gmx.at>
5328
5329 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5330 (sort_overlays, overlay_strings): When an overlay's clone number
5331 matches the window's clone number process the overlay even if
5332 the overlay's window property doesn't match the current window.
5333
d68443dc
MR
5334 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5335 (Fwindow_hchild): Rename to Fwindow_left_child.
5336 (Fwindow_next): Rename to Fwindow_next_sibling.
5337 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
5338 (resize_window_check): Rename to window_resize_check.
5339 (resize_window_apply): Rename to window_resize_apply.
5340 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5341 (Fdelete_other_windows_internal, resize_frame_windows)
5342 (Fsplit_window_internal, Fdelete_window_internal)
5343 (grow_mini_window, shrink_mini_window)
5344 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 5345
c7e73be5
JD
53462011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5347
5348 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5349 (emacs_fixed_set_min_size): Remove.
5350 (emacs_fixed_new): Take frame as argument.
5351
5352 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5353 (_EmacsFixedPrivate): Remove minwidth/height.
5354 Add struct frame *f.
5355 (emacs_fixed_init): Initialize priv->f.
5356 (get_parent_class, emacs_fixed_set_min_size): Remove.
5357 (emacs_fixed_new): Set priv->f to argument.
5358 (emacs_fixed_get_preferred_width)
5359 (emacs_fixed_get_preferred_height): Use min_width/height from
5360 frames size_hint to set minimum and natural (Bug#8919).
5361 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5362 and use min_width/height from frames size_hint to set
5363 min_width/height (Bug#8919).
5364
5365 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
5366 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5367 Fix indentation.
c7e73be5 5368
cf99dcf8
EZ
53692011-06-26 Eli Zaretskii <eliz@gnu.org>
5370
5371 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5372 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5373 called at ZV.
5374
029529ac
CY
53752011-06-26 Chong Yidong <cyd@stupidchicken.com>
5376
5377 * process.c (wait_reading_process_output): Bypass select if
5378 waiting for a cell while ignoring keyboard input, and input is
5379 pending. Suggested by Jan Djärv (Bug#8869).
5380
7a7ef429
PE
53812011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5382
5383 Use gnulib's dup2 module instead of rolling our own.
5384 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5385
11fdef7d 53862011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
5387
5388 * dispnew.c (scrolling_window): Before scrolling, turn off a
5389 mouse-highlight in the window being scrolled.
5390
cd3520a4
JB
53912011-06-24 Juanma Barranquero <lekktu@gmail.com>
5392
5393 Move DEFSYM to lisp.h and use everywhere.
5394
5395 * character.h (DEFSYM): Move declaration...
5396 * lisp.h (DEFSYM): ...here.
5397
5398 * gnutls.c:
5399 * minibuf.c:
5400 * w32menu.c:
5401 * w32proc.c:
5402 * w32select.c: Don't include character.h.
5403
5404 * alloc.c (syms_of_alloc):
5405 * buffer.c (syms_of_buffer):
5406 * bytecode.c (syms_of_bytecode):
5407 * callint.c (syms_of_callint):
5408 * casefiddle.c (syms_of_casefiddle):
5409 * casetab.c (init_casetab_once):
5410 * category.c (init_category_once, syms_of_category):
5411 * ccl.c (syms_of_ccl):
5412 * cmds.c (syms_of_cmds):
5413 * composite.c (syms_of_composite):
5414 * dbusbind.c (syms_of_dbusbind):
5415 * dired.c (syms_of_dired):
5416 * dispnew.c (syms_of_display):
5417 * doc.c (syms_of_doc):
5418 * editfns.c (syms_of_editfns):
5419 * emacs.c (syms_of_emacs):
5420 * eval.c (syms_of_eval):
5421 * fileio.c (syms_of_fileio):
5422 * fns.c (syms_of_fns):
5423 * frame.c (syms_of_frame):
5424 * fringe.c (syms_of_fringe):
5425 * insdel.c (syms_of_insdel):
5426 * keymap.c (syms_of_keymap):
5427 * lread.c (init_obarray, syms_of_lread):
5428 * macros.c (syms_of_macros):
5429 * msdos.c (syms_of_msdos):
5430 * print.c (syms_of_print):
5431 * process.c (syms_of_process):
5432 * search.c (syms_of_search):
5433 * sound.c (syms_of_sound):
5434 * syntax.c (init_syntax_once, syms_of_syntax):
5435 * terminal.c (syms_of_terminal):
5436 * textprop.c (syms_of_textprop):
5437 * undo.c (syms_of_undo):
5438 * w32.c (globals_of_w32):
5439 * window.c (syms_of_window):
5440 * xdisp.c (syms_of_xdisp):
5441 * xfaces.c (syms_of_xfaces):
5442 * xfns.c (syms_of_xfns):
5443 * xmenu.c (syms_of_xmenu):
5444 * xsettings.c (syms_of_xsettings):
5445 * xterm.c (syms_of_xterm): Use DEFSYM.
5446
4228cf16
TZ
54472011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5448
cd3520a4 5449 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5450
7fcccf1e
PE
54512011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5452
7efb4e0e
PE
5453 Integer and buffer overflow fixes (Bug#8873).
5454
ff5844ad
PE
5455 * print.c (printchar, strout): Check for string overflow.
5456 (PRINTPREPARE, printchar, strout):
5457 Don't set size unless allocation succeeds.
5458
90532f02
PE
5459 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5460 for sizes. Check for string overflow more accurately.
5461 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5462
6d84508d
PE
5463 * macros.c: Integer and buffer overflow fixes.
5464 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5465 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5466 Use ptrdiff_t, not int, for sizes.
5467 Don't increment bufsize until after realloc succeeds.
5468 Check for size-calculation overflow.
5469 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5470
437b2cb4
PE
5471 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5472
8b9ac8b4
PE
5473 * lread.c: Integer overflow fixes.
5474 (read_integer): Radix is now EMACS_INT, not int,
5475 to improve quality of diagnostics for out-of-range radices.
5476 Calculate buffer size correctly for out-of-range radices.
5477 (read1): Check for integer overflow in radices, and in
5478 read-circle numbers.
82cb60d3
PE
5479 (read_escape): Avoid int overflow.
5480 (Fload, openp, read_buffer_size, read1)
5481 (substitute_object_recurse, read_vector, read_list, map_obarray):
5482 Use ptrdiff_t, not int, for sizes.
5483 (read1): Use EMACS_INT, not int, for sizes.
20270765 5484 Check for size overflow.
8b9ac8b4 5485
7fcccf1e
PE
5486 * image.c (cache_image): Check for size arithmetic overflow.
5487
bfbbd7e7
PE
5488 * lread.c: Integer overflow issues.
5489 (saved_doc_string_size, saved_doc_string_length)
5490 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5491 Now ptrdiff_t, not int.
5492 (read1): Don't assume doc string length fits in int. Check for
5493 out-of-range doc string lengths.
5494 (read_list): Don't assume file position fits in int.
39019e54 5495 (read_escape): Check for hex character overflow.
bfbbd7e7 5496
4e323265
LL
54972011-06-22 Leo Liu <sdl.web@gmail.com>
5498
5499 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5500 Move to minibuffer.el.
5501
85fece3e
PE
55022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5503
20b84ce9 5504 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5505 The following patches are for when GLYPH_DEBUG && !XASSERT.
5506 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5507 * dispnew.c (flush_stdout):
5508 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5509 Mark as externally visible.
5510 * dispnew.c (check_window_matrix_pointers): Now static.
5511 * dispnew.c (window_to_frame_vpos):
5512 * xfns.c (unwind_create_frame):
5513 * xterm.c (x_check_font): Remove unused local.
5514 * scroll.c (CHECK_BOUNDS):
5515 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5516 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5517 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5518 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5519 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5520 Now static.
5521 (debug_method_add): Use va_list and vsprintf rather than relying
5522 on undefined behavior with wrong number of arguments.
5523 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5524 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5525 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5526 since we're not interested in debugging glyphs with old libraries.
5527 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5528 GCC 4.6.0's static checking.
5529
0766b489
PE
55302011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5531
31fd4b32
PE
5532 Integer overflow and signedness fixes (Bug#8873).
5533 A few related buffer overrun fixes, too.
5534
b79e8648
PE
5535 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5536
0766b489
PE
5537 * dispextern.h (struct face.stipple):
5538 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5539 (x_bitmap_mask, x_allocate_bitmap_record)
5540 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5541 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5542 (x_create_bitmap_from_xpm_data):
5543 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5544 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5545 (.bitmaps_last):
5546 * xfaces.c (load_pixmap):
5547 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5548 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5549 (.bitmaps_last, struct x_output.icon_bitmap):
5550 Use ptrdiff_t, not int, for bitmap indexes.
5551 (x_allocate_bitmap_record): Check for size overflow.
5552 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5553
b081724f
PE
5554 Use ptrdiff_t, not int, for overlay counts.
5555 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5556 * editfns.c (overlays_around, get_pos_property):
5557 * textprop.c (get_char_property_and_overlay):
5558 * xdisp.c (next_overlay_change, note_mouse_highlight):
5559 * xfaces.c (face_at_buffer_position):
21514da7
PE
5560 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5561 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5562 (Fnext_overlay_change, Fprevious_overlay_change)
5563 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5564 Use ptrdiff_t, not int, for sizes.
21514da7 5565 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5566
3de73e5e
PE
5567 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5568
2606c57b
PE
5569 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5570 (x_session_initialize): Do not assume string length fits in int.
5571
aaafe47a
PE
5572 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5573 This is unlikely, but can occur if DPI is outlandish.
5574
2674ddc8 5575 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5576 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5577
28154962
PE
5578 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5579 * xrdb.c (magic_file_p, search_magic_path):
5580 Omit last arg SUFFIX; it was always 0. All callers changed.
5581 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5582
7de51af5
PE
5583 * xfont.c (xfont_match): Avoid need for strlen.
5584
25ed6cc3
PE
5585 * xfns.c: Don't assume strlen fits in int.
5586 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5587
4eab31dd
PE
5588 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5589 not unsigned long, as we prefer signed integers. All callers changed.
5590 Detect integer overflow in repeat count.
5591 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5592 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5593
171e2a58
PE
5594 * termcap.c: Don't assume sizes fit in int and never overflow.
5595 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5596 (gobble_line): Check for size-calculation overflow.
5597
ad39faca 5598 * minibuf.c (Fread_buffer):
6e5bb2dc 5599 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5600 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5601 Don't assume string length fits in int.
5602
52c61c22 5603 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5604 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5605
b5b8c9e5
PE
5606 * font.c: Don't assume string length fits in int.
5607 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5608 Use ptrdiff_t, not int.
ccd6111c
PE
5609 (font_intern_prop): Don't assume string length fits in int.
5610 Don't assume integer property fits in fixnum.
5611 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5612
882f0d81 5613 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5614 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5615 Reformulate so as not to need the command string.
5616 Invoke gzip -cd rather than gunzip, as it's more portable.
5617 (lock_info_type, lock_file_1, lock_file):
5618 Don't assume pid_t and time_t fit in unsigned long.
5619 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5620 (current_lock_owner): Prefer signed type for sizes.
5621 Use memcpy, not strncpy, where memcpy is what is really wanted.
5622 Don't assume (via atoi) that time_t and pid_t fit in int.
5623 Check for time_t and/or pid_t out of range, e.g., via a network share.
5624 Don't alloca where an auto var works fine.
5625
93f4cf88
PE
5626 * fileio.c: Fix some integer overflow issues.
5627 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5628 Don't assume string length fits in int.
5629 (directory_file_name): Don't assume string length fits in long.
5630 (make_temp_name): Don't assume pid fits in int, or that its print
5631 length is less than 20.
5632
f3e92b69
PE
5633 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5634
1bfdaf10
PE
5635 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5636
35016e9a
PE
5637 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5638
3d1e65a1
PE
5639 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5640 We prefer signed integers, even for size calculations.
5641
0b963a93
PE
5642 * emacs.c: Don't assume string length fits in 'int'.
5643 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5644 (main): Don't invoke strlen when not needed.
5645
573f4b54
PE
5646 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5647 (XD_DEBUG_MESSAGE): Don't waste a byte.
5648
989f33ba
PE
5649 * callproc.c (getenv_internal_1, getenv_internal)
5650 (Fgetenv_internal):
965d34eb
PE
5651 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5652
e4d29b33
PE
5653 * lread.c (invalid_syntax): Omit length argument.
5654 All uses changed. This doesn't fix a bug, but it simplifies the
5655 code away from its former Hollerith-constant appearance, and it's
5656 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5657 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5658
eb49b136
PE
5659 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5660 This didn't break anything, but it didn't help either.
5661 It's confusing to put a bogus integer in a place where the actual
5662 value does not matter.
9f62aeb1 5663 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5664 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5665
15375a22
PE
5666 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5667 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5668 implementation.
b61cc01c
PE
5669 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5670 We prefer signed types, and the value cannot exceed the EMACS_INT
5671 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5672 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5673 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5674 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5675
53b2623d
PE
5676 * indent.c (sane_tab_width): New function.
5677 (current_column, scan_for_column, Findent_to, position_indentation)
5678 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5679 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5680
51cab52b 5681 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5682
f2ed8a70
PE
5683 * lisp.h (lint_assume): New macro.
5684 * composite.c (composition_gstring_put_cache):
5685 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5686
abe80cc6
PE
5687 * editfns.c, insdel.c:
5688 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5689
b02c740e
PE
5690 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5691
ebc96716
PE
5692 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5693
b4e50fa0 5694 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5695 Use much-faster test for byte-length change.
311d5d7c 5696 Don't assume string byte-length fits in 'int'.
a4cf38e4 5697 Check that character arg fits in 'int'.
85461888 5698 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5699
c0c1ee9f
PE
5700 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5701
a498d7f4
PE
5702 * fns.c (concat): Catch string overflow earlier.
5703 Do not rely on integer wraparound.
5704
51cab52b
PE
5705 * dispextern.h (struct it.overlay_strings_charpos)
5706 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5707 * xdisp.c (forward_to_next_line_start)
5708 (back_to_previous_visible_line_start)
5709 (reseat_at_next_visible_line_start, next_element_from_buffer):
5710 Don't arbitrarily truncate the value of 'selective' to int.
5711
76031fad
PE
5712 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5713
5eb55db9
PE
5714 * composite.c: Don't truncate sizes to 'int'.
5715 (composition_gstring_p, composition_reseat_it)
5716 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5717 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5718 not EMACS_UINT, for indexes.
5eb55db9 5719
0703a717
PE
5720 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5721
d6202519
PE
5722 * buffer.c: Include <verify.h>.
5723 (struct sortvec.priority, struct sortstr.priority):
8961a454 5724 Now EMACS_INT, not int.
c20998a7 5725 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5726 (struct sortstr.size, record_overlay_string)
5727 (struct sortstrlist.size, struct sortlist.used):
5728 Don't truncate size to int.
5729 (record_overlay_string): Check for size-calculation overflow.
d6202519 5730 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5731
d5a19415
JM
57322011-06-22 Jim Meyering <meyering@redhat.com>
5733
029529ac 5734 Don't leak an XBM-image-sized buffer
d5a19415
JM
5735 * image.c (xbm_load): Free the image buffer after using it.
5736
a9041e6c
PE
57372011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5738
5739 Port to Sun C.
5740 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5741 that Sun C diagnosed.
5742 * fns.c (secure_hash): Fix pointer signedness issue.
5743 * intervals.c (static_offset_intervals): New function.
5744 (offset_intervals): Use it.
5745
7f3f739f
LL
57462011-06-21 Leo Liu <sdl.web@gmail.com>
5747
5748 * deps.mk (fns.o):
5749 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5750 sha512.h.
5751
5752 * fns.c (secure_hash): Rename from crypto_hash_function and change
5753 the first arg to accept symbols.
5b66d427 5754 (Fsecure_hash): New primitive.
7f3f739f
LL
5755 (syms_of_fns): New symbols.
5756
76147d94
DD
57572011-06-20 Deniz Dogan <deniz@dogan.se>
5758
5759 * process.c (Fset_process_buffer): Clarify return value in
5760 docstring.
5761
7d7d0045
CY
57622011-06-18 Chong Yidong <cyd@stupidchicken.com>
5763
5764 * dispnew.c (add_window_display_history): Use BVAR.
5765
5766 * xdisp.c (debug_method_add): Use BVAR.
5767 (check_window_end, dump_glyph_matrix, dump_glyph)
5768 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5769
5770 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5771 Likewise.
5772
5773 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5774 check till after the cache is created in init_frame_faces.
5775
ff2bc410
SM
57762011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5777
5778 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5779
28177add
PE
57802011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5781
dd3482fe
PE
5782 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5783 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5784 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5785
393d71f3 5786 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5787 * fileio.c (Finsert_file_contents):
5788 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5789 Remove the old (too-loose) buffer overflow checks.
5790 They weren't needed, since make_gap checks for buffer overflow.
5791 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5792 The old code merely checked for Emacs fixnum overflow, and relied
5793 on undefined (wraparound) behavior. The new code avoids undefined
5794 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5795
2e6813b0 5796 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5797 Tune. Don't use wider integers than needed. Don't use alloca.
5798 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5799
599a9e4f
PE
5800 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5801
99561444
PE
5802 * insdel.c, lisp.h (buffer_overflow): New function.
5803 (insert_from_buffer_1, replace_range, replace_range_2):
5804 * insdel.c (make_gap_larger):
5805 * editfns.c (Finsert_char):
5806 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5807
28177add
PE
5808 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5809
e69dafad
PE
58102011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5811
4baa020d 5812 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5813
b1c46f02
PE
5814 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5815 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5816
e69dafad
PE
5817 * fileio.c: Don't assume EMACS_INT fits in off_t.
5818 (emacs_lseek): New static function.
5819 (Finsert_file_contents, Fwrite_region): Use it.
5820 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5821
566684ea
PE
5822 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5823
e6966cd6
PE
5824 * fns.c: Don't overflow int when computing a list length.
5825 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5826 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5827 truncation on 64-bit hosts. Check for QUIT every
5828 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5829 faster and is responsive enough.
5830 (Flength): Report an error instead of overflowing an integer.
5831 (Fsafe_length): Return a float if the value is not representable
5832 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5833 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5834 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5835
dd0b0efb
PE
5836 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5837 (header_size, word_size): New constants.
5838 (allocate_vectorlike): Don't check size overflow here.
5839 (allocate_vector): Check it here instead, since this is the only
5840 caller of allocate_vectorlike that could cause overflow.
5841 Check that the new vector's length is representable as a fixnum.
5842
86fe5cfe
PE
5843 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5844 The previous code was bogus. For example, next_almost_prime (32)
5845 returned 39, which is undesirable as it is a multiple of 3; and
5846 next_almost_prime (24) returned 25, which is a multiple of 5 so
5847 why was the code bothering to check for multiples of 7?
5848
80e88859
PE
5849 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5850
4a2f0ad6
PE
5851 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5852
f66c7cf8
PE
5853 Variadic C functions now count arguments with ptrdiff_t.
5854 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5855 Back then I didn't know that the Emacs coding style prefers signed int.
5856 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5857 were being counted with int, which may truncate counts on 64-bit
5858 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5859 * lisp.h (struct Lisp_Subr.function.aMANY)
5860 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5861 Arg counts are now ptrdiff_t, not size_t.
5862 All variadic functions and their callers changed accordingly.
5863 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5864 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5865 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5866 * callint.c (Fcall_interactively): Check arg count for overflow,
5867 to avoid potential buffer overrun. Use signed char, not 'int',
5868 for 'varies' array, so that we needn't bother to check its size
5869 calculation for overflow.
5870 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5871 * eval.c (apply_lambda):
5872 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5873 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5874 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5875
a1759b76
PE
5876 * callint.c (Fcall_interactively): Don't use index var as event count.
5877
d96be9fc
PE
5878 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5879 * mem-limits.h (SIZE): Remove; no longer used.
5880
a690a978 5881 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5882
578c21e6
PE
5883 Remove unnecessary casts.
5884 * xterm.c (x_term_init):
5885 * xfns.c (x_set_border_pixel):
5886 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5887 These aren't needed now that we assume ANSI C.
5888
96f53c6c
PE
5889 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5890 It's more likely to cause problems (due to unsigned overflow)
5891 than to cure them.
5892
83c77d31
PE
5893 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5894
ee2079f1
PE
5895 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5896
6da65536
PE
5897 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5898
7147c4a4
PE
5899 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5900
193e32d9
PE
5901 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5902
e5533da6
PE
5903 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5904
9910e595
PE
5905 GLYPH_CODE_FACE returns EMACS_INT, not int.
5906 * dispextern.h (merge_faces):
5907 * xfaces.c (merge_faces):
01103c44
PE
5908 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5909 Don't assume EMACS_INT fits in int.
9910e595 5910
2638320e
PE
5911 * character.h (CHAR_VALID_P): Remove unused parameter.
5912 * fontset.c, lisp.h, xdisp.c: All uses changed.
5913
045eb8d9
PE
5914 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5915
c1f134b5
PE
5916 * fns.c (concat): Minor tuning based on overflow analysis.
5917 This doesn't fix any bugs. Use int to hold character, instead
5918 of constantly refetching from Emacs object. Use XFASTINT, not
5919 XINT, for value known to be a character. Don't bother comparing
5920 a single byte to 0400, as it's always less.
5921
395fcb93 5922 * floatfns.c (Fexpt):
327eeec8
PE
5923 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5924
abbd3d23
PE
5925 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5926 for characters.
5927
684a03ef
PE
5928 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5929
0fed43f3
PE
5930 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5931 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5932 incorrectly succeed when S was a string, because 4294967386 was
5933 truncated before it was used.
5934
8fd02eb7
PE
5935 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5936 Otherwise, an out-of-range integer could cause undefined behavior
5937 on a 64-bit host.
5938
f8c86b69
PE
5939 * composite.c: Use int, not EMACS_INT, for characters.
5940 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5941 EMACS_INT, for values that are known to be in character range.
5942 This doesn't fix any bugs but is the usual style inside Emacs and
5943 may generate better code on 32-bit machines.
5944
34206dd2
PE
5945 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5946 This is for reasons similar to the recent CHAR_STRING fix.
5947 * charset.c (Fencode_char): Check that character arg is actually
5948 a character. Pass an int to ENCODE_CHAR.
5949 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5950 wider than 'int', as a compile-time check to prevent future regressions
5951 in this area.
5952
c5958d4c 5953 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5954
5955 Make sure a 64-bit char is never passed to CHAR_STRING.
5956 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5957 by silently ignoring the top 32 bits, allowing some values
5958 that were far too large to be valid characters.
5959 * character.h: Include <verify.h>.
5960 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5961 arguments are no wider than unsigned, as a compile-time check
5962 to prevent future regressions in this area.
5963 * data.c (Faset):
01103c44 5964 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5965 (Fsubst_char_in_region):
5966 * fns.c (concat):
5967 * xdisp.c (decode_mode_spec_coding):
5968 Adjust to CHAR_STRING's new requirement.
5969 * editfns.c (Finsert_char, Fsubst_char_in_region):
5970 * fns.c (concat): Check that character args are actually
5971 characters. Without this test, these functions did the wrong
5972 thing with wildly out-of-range values on 64-bit hosts.
5973
d37ca623
PE
5974 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5975 These casts should not be needed on 32-bit hosts, either.
5976 * keyboard.c (read_char):
5977 * lread.c (Fload): Remove casts to unsigned.
5978
ea204efb
PE
5979 * lisp.h (UNSIGNED_CMP): New macro.
5980 This fixes comparison bugs on 64-bit hosts.
5981 (ASCII_CHAR_P): Use it.
5982 * casefiddle.c (casify_object):
01103c44 5983 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5984 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5985 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5986 * dispextern.h (FACE_FROM_ID):
5987 * keyboard.c (read_char): Use UNSIGNED_CMP.
5988
41cb286c
PE
5989 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5990 not to EMACS_INT, to avoid GCC warning.
5991
4a1b9832
PE
5992 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5993
55daad71
PE
5994 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5995 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5996 isn't needed on 32-bit machines.
8f95c75c 5997
01103c44
PE
5998 * buffer.c (Fgenerate_new_buffer_name):
5999 Use EMACS_INT for count, not int.
0ceccced 6000 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
6001
6002 * data.c (Qcompiled_function): Now static.
6003
c6f072e7
PE
6004 * window.c (window_body_lines): Now static.
6005
20ce5912
PE
6006 * image.c (gif_load): Rename local to avoid shadowing.
6007
9c4c5f81
PE
6008 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
6009 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
6010 * alloc.c (make_save_value): Integer argument is now of type
6011 ptrdiff_t, not int.
6012 (mark_object): Use ptrdiff_t, not int.
6013 * lisp.h (pD): New macro.
6014 * print.c (print_object): Use it.
6015
c0c5c8ae
PE
6016 * alloc.c: Use EMACS_INT, not int, to count objects.
6017 (total_conses, total_markers, total_symbols, total_vector_size)
6018 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
6019 (total_free_floats, total_floats, total_free_intervals)
6020 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
6021 Now EMACS_INT, not int. All uses changed.
6022 (Fgarbage_collect): Compute overall total using a double, so that
6023 integer overflow is less likely to be a problem. Check for overflow
6024 when converting back to an integer.
5a25e253
PE
6025 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6026 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6027 These were 'int' variables that could overflow on 64-bit hosts;
6028 they were never used, so remove them instead of repairing them.
211a0b2a 6029 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
6030 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6031 Previously, this ceilinged at INT_MAX, but that doesn't work on
6032 64-bit machines.
e46bb31a 6033 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 6034
c78baabf 6035 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 6036 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
6037 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6038 when a (possibly-narrower) signed value would do just as well.
6039 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 6040
c9d624c6
PE
6041 * alloc.c: Catch some string size overflows that we were missing.
6042 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6043 for convenience in STRING_BYTES_MAX.
6044 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6045 The definition here is exact; the one in lisp.h was approximate.
6046 (allocate_string_data): Check for string overflow. This catches
6047 some instances we weren't catching before. Also, it catches
6048 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6049 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6050 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 6051
c9d624c6
PE
6052 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6053 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 6054 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 6055
353032ce
PE
6056 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
6057
2bccce07
PE
6058 * alloc.c (Fmake_string): Check for out-of-range init.
6059
0ac30604
SM
60602011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
6061
6062 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
6063
c195f2de
JD
60642011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6065
6066 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
6067 xg_get_default_scrollbar_width.
6068
6069 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
6070 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6071 (style_changed_cb): Call update_theme_scrollbar_width and call
6072 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6073 all frames (Bug#8505).
6074 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6075 Call gtk_window_set_resizable if HAVE_GTK3.
6076 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6077 and height if HAVE_GTK3 (Bug#8505).
6078 (scroll_bar_width_for_theme): New variable.
6079 (update_theme_scrollbar_width): New function.
6080 (xg_get_default_scrollbar_width): Move code to
6081 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6082 (xg_initialize): Call update_theme_scrollbar_width.
6083
6084 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6085
6086 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6087
e10ac9f1
MR
60882011-06-12 Martin Rudalics <rudalics@gmx.at>
6089
6090 * frame.c (make_frame): Call other_buffer_safely instead of
6091 other_buffer.
6092
6093 * window.c (temp_output_buffer_show): Call display_buffer with
6094 second argument Vtemp_buffer_show_specifiers and reset latter
6095 immediately after the call.
6096 (Vtemp_buffer_show_specifiers): New variable.
6097 (auto_window_vscroll_p, next_screen_context_lines)
6098 (Vscroll_preserve_screen_position): Remove leading asterisks from
6099 doc-strings.
6100
2d3c217e 61012011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 6102
7b7f97e8 6103 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
6104 * buffer.c (Qclone_number): Remove for now, as it's unused.
6105 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6106 (record_buffer): Remove unused local.
6107 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6108 (set_frame_buffer_list): Remove; unused.
6109 * frame.h (other_visible_frames): Remove decl.
6110 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6111 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6112 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
6113 if HAVE_GPM.
6114 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
6115 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6116 Define only if HAVE_GPM.
6117 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6118 (update_hints_inhibit): Remove; never set. All uses removed.
6119 * widgetprv.h (emacsFrameClassRec): Remove decl.
6120 * window.c (delete_deletable_window): Now returns void, since it
6121 wasn't returning anything.
6122 (compare_window_configurations): Remove unused locals.
6123 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
6124 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
6125 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6126 the same widths as pointers. This follows up on the 2011-05-06 patch.
6127 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6128 * xterm.h: Likewise.
6129 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6130
1384b89e
JB
61312011-06-12 Juanma Barranquero <lekktu@gmail.com>
6132
6133 * makefile.w32-in: Update dependencies.
6134 (LISP_H): Add lib/intprops.h.
6135
1100a63c
CY
61362011-06-11 Chong Yidong <cyd@stupidchicken.com>
6137
6138 * image.c (gif_load): Add animation frame delay to the metadata.
6139 (syms_of_image): Use DEFSYM. New symbol `delay'.
6140
6198ccd0
MR
61412011-06-11 Martin Rudalics <rudalics@gmx.at>
6142
6143 * window.c (delete_deletable_window): Re-add.
6144 (Fset_window_configuration): Rewrite to handle dead buffers and
6145 consequently deletable windows.
6146 (window_tree, Fwindow_tree): Remove. Supply functionality in
6147 window.el.
6148 (compare_window_configurations): Simplify code.
6149
b6e3633c
AS
61502011-06-11 Andreas Schwab <schwab@linux-m68k.org>
6151
1ab0dee5
AS
6152 * image.c (imagemagick_load_image): Fix type mismatch.
6153 (Fimagemagick_types): Likewise.
6154
b6e3633c
AS
6155 * window.h (replace_buffer_in_windows): Declare.
6156
9397e56f
MR
61572011-06-11 Martin Rudalics <rudalics@gmx.at>
6158
6159 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6160 Qclone_number. Remove external declaration of Qdelete_window.
6161 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6162 code.
640c8776
SM
6163 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6164 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
6165 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6166 buffer list implementation.
6167 (other_buffer_safely): New function.
6168 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6169 calls to replace_buffer_in_windows and
6170 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6171 if allowed.
6172 (record_buffer): Inhibit quitting and rewrite using quittable
6173 functions. Run Qbuffer_list_update_hook if allowed.
6174 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
6175 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6176 Move switch-to-buffer to window.el.
9397e56f
MR
6177 (bury-buffer): Move to window.el.
6178 (Vbuffer_list_update_hook): New variable.
6179
6180 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6181 section.
6182
6183 * window.h (resize_frame_windows): Move up in code.
6184 (Fwindow_frame): Remove EXFUN.
6185 (replace_buffer_in_all_windows): Remove prototype.
6186 (replace_buffer_in_windows_safely): Add prototype.
6187
6188 * window.c: Declare Qdelete_window static again. Move down
6189 declaration of select_count.
6190 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6191 (Fother_window): Move to window.el.
6192 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6193 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6194 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6195 window.el.
6196 (replace_buffer_in_windows): Implement by calling
6197 Qreplace_buffer_in_windows.
6198 (replace_buffer_in_all_windows): Remove with some functionality
6199 moved into replace_buffer_in_windows_safely.
6200 (replace_buffer_in_windows_safely): New function.
6201 (select_window_norecord, select_frame_norecord): Move in front
6202 of run_window_configuration_change_hook. Remove now obsolete
6203 declarations.
640c8776
SM
6204 (Fset_window_buffer): Rewrite doc-string.
6205 Call Qrecord_window_buffer.
9397e56f
MR
6206 (keys_of_window): Move binding for other-window to window.el.
6207
b50691aa
CY
62082011-06-11 Chong Yidong <cyd@stupidchicken.com>
6209
6210 * dispextern.h (struct image): Replace data member, whose int_val
6211 and ptr_val fields were not used by anything, with a single
6212 lisp_val object.
6213
6214 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6215 (gif_clear_image, gif_load, imagemagick_load_image)
6216 (gs_clear_image, gs_load): Callers changed.
6217
3f754b86
PE
62182011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6219
cca69397
PE
6220 * buffer.h: Include <time.h>, for time_t.
6221 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6222
109e28d0
PE
6223 Fix minor problems found by static checking.
6224
60737f02
PE
6225 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6226
4b66faf3
PE
6227 Make identifiers static if they are not used in other modules.
6228 * data.c (Qcompiled_function, Qframe, Qvector):
6229 * image.c (QimageMagick, Qsvg):
6230 * minibuf.c (Qmetadata):
6231 * window.c (resize_window_check, resize_root_window): Now static.
6232 * window.h (resize_window_check, resize_root_window): Remove decls.
6233
109e28d0
PE
6234 * window.c (window_deletion_count, delete_deletable_window):
6235 Remove; unused.
46a4ce9e
PE
6236 (window_body_lines): Now static.
6237 (Fdelete_other_windows_internal): Mark vars as initialized.
6238 Make sure 'resize_failed' is initialized.
6239 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6240 (resize_window_apply): Remove unused local.
6241 * window.h (delete_deletable_window): Remove decl.
6242
109e28d0 6243 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
6244 (imagemagick_load_image): Fix pointer signedness problem by changing
6245 last arg from unsigned char * to char *. All uses changed.
6246 Also, fix a local for similar reasons.
6247 Remove unused locals. Remove locals to avoid shadowing.
6248 (fn_rsvg_handle_free): Remove; unused.
6249 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 6250 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 6251
3f754b86
PE
6252 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6253
2547adb1
CY
62542011-06-10 Chong Yidong <cyd@stupidchicken.com>
6255
6256 * image.c (gif_load): Fix omitted cast error introduced by
6257 2011-06-06 change.
6258
2c8e37d4
MR
62592011-06-10 Martin Rudalics <rudalics@gmx.at>
6260
6261 * window.h (resize_proportionally, orig_total_lines)
6262 (orig_top_line): Remove from window structure.
6263 (set_window_height, set_window_width, change_window_heights)
6264 (Fdelete_window): Remove prototypes.
6265 (resize_frame_windows): Remove duplicate declaration.
6266
440a42e3
EZ
62672011-06-10 Eli Zaretskii <eliz@gnu.org>
6268
6269 * window.h (resize_frame_windows, resize_window_check)
6270 (delete_deletable_window, resize_root_window)
6271 (resize_frame_windows): Declare prototypes.
6272
6273 * window.c (resize_window_apply): Make definition be "static" to
6274 match the prototype.
6275
562dd5e9
MR
62762011-06-10 Martin Rudalics <rudalics@gmx.at>
6277
6278 * window.c: Remove declarations of Qwindow_size_fixed,
6279 window_min_size_1, window_min_size_2, window_min_size,
6280 size_window, window_fixed_size_p, enlarge_window, delete_window.
6281 Remove static from declaration of Qdelete_window, it's
6282 temporarily needed by Fbury_buffer.
6283 (replace_window): Don't assign orig_top_line and
6284 orig_total_lines.
6285 (Fdelete_window, delete_window): Remove. Window deletion is
6286 handled by window.el.
640c8776
SM
6287 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6288 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
6289 (Fdelete_other_windows): Remove. Deleting other windows is
6290 handled by window.el.
6291 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6292 handled in window.el.
6293 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6294 Window minimum sizes are handled in window.el.
6295 (shrink_windows, size_window, set_window_height)
6296 (set_window_width, change_window_heights, window_height)
6297 (window_width, CURBEG, CURSIZE, enlarge_window)
6298 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6299 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6300 handled in window.el.
6301 (make_dummy_parent): Rename to make_parent_window and give it a
6302 second argument horflag.
6303 (make_window): Don't set resize_proportionally any more.
6304 (Fsplit_window): Remove. Windows are split in window.el.
6305 (save_restore_action, save_restore_orig_size)
6306 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6307 Resize mini windows in window.el.
6308 (grow_mini_window, shrink_mini_window): Implement by calling
6309 Qresize_root_window_vertically, resize_window_check and
6310 resize_window_apply.
640c8776
SM
6311 (saved_window, Fset_window_configuration, save_window_save):
6312 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
6313 resize_proportionally.
6314 (window_min_height, window_min_width): Move to window.el.
6315 (keys_of_window): Move bindings for delete-other-windows,
6316 split-window, delete-window and enlarge-window to window.el.
6317
6318 * buffer.c: Temporarily extern Qdelete_window.
6319 (Fbury_buffer): Temporarily call Qdelete_window instead of
6320 Fdelete_window (Fbury_buffer will move to window.el soon).
6321
6322 * frame.c (set_menu_bar_lines_1): Remove code handling
6323 orig_top_line and orig_total_lines.
6324
6325 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6326 set_window_height but set heights directly.
6327 (change_frame_size_1): Use resize_frame_windows.
6328
6329 * xdisp.c (init_xdisp): Don't use set_window_height but set
6330 heights directly.
6331
640c8776
SM
6332 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6333 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
6334 run_window_configuration_change_hook.
6335
6336 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6337 instead of change_window_heights and run
6338 run_window_configuration_change_hook.
6339
1a13852e
MR
63402011-06-09 Martin Rudalics <rudalics@gmx.at>
6341
6342 * window.c (replace_window): Rename second argument REPLACEMENT to
6343 NEW. New third argument SETFLAG. Rewrite.
6344 (delete_window, make_dummy_parent): Call replace_window with
6345 third argument 1.
6346 (window_list_1): Move down in code.
6347 (run_window_configuration_change_hook): Move set_buffer part
6348 before select_frame_norecord part in order to unwind correctly.
6349 Rename count1 to count.
6350 (recombine_windows, delete_deletable_window, resize_root_window)
6351 (Fdelete_other_windows_internal)
6352 (Frun_window_configuration_change_hook, make_parent_window)
6353 (resize_window_check, resize_window_apply, Fresize_window_apply)
6354 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
6355 (Fdelete_window_internal, Fresize_mini_window_internal):
6356 New functions.
1a13852e
MR
6357 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6358
f3d1777e
MR
63592011-06-08 Martin Rudalics <rudalics@gmx.at>
6360
496e208e
MR
6361 * window.h (window): Add some new members to window structure -
6362 normal_lines, normal_cols, new_total, new_normal, clone_number,
6363 splits, nest, prev_buffers, next_buffers.
6364 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 6365 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 6366
f3d1777e
MR
6367 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6368 Remove.
496e208e
MR
6369 (make_dummy_parent): Set new members of windows structure.
6370 (make_window): Move down in code. Handle new members of window
6371 structure.
6372 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6373 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6374 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6375 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
6376 (Fset_window_next_buffers, Fset_window_clone_number):
6377 New functions.
496e208e
MR
6378 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6379 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6380 Doc-string fixes.
6381 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6382 Argument WINDOW can be now internal window too.
6383 (Fwindow_use_time): Move up in code.
6384 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6385 Rewrite doc-string.
6386 (Fset_window_configuration, saved_window)
6387 (Fcurrent_window_configuration, save_window_save): Handle new
6388 members of window structure.
b9e809c2
MR
6389 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6390 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6391 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6392 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6393 Qget_mru_window, Qresize_root_window,
6394 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6395 Qauto_buffer_name; staticpro them.
f3d1777e 6396
abde8f8c
MR
63972011-06-07 Martin Rudalics <rudalics@gmx.at>
6398
6399 * window.c (Fwindow_total_size, Fwindow_left_column)
6400 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6401 (Fwindow_list_1): New functions.
6402 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
6403 (Fwindow_width, Fscroll_left, Fscroll_right):
6404 Use window_body_cols instead of window_box_text_cols.
6405 (delete_window, Fset_window_configuration):
6406 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
6407 (delete_all_subwindows): Take a window as argument and not a
6408 structure. Rewrite.
190b47e6
MR
6409 (window_loop): Remove handling of GET_LRU_WINDOW and
6410 GET_LARGEST_WINDOW.
6411 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
6412
6413 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
6414 window_box_text_cols. delete_all_subwindows now takes a
6415 Lisp_Object as argument.
abde8f8c 6416
640c8776
SM
6417 * indent.c (compute_motion, Fcompute_motion):
6418 Use window_body_cols instead of window_box_text_cols.
abde8f8c 6419
fa8a67e6
MR
6420 * frame.c (delete_frame): Call delete_all_subwindows with root
6421 window as argument.
6422
a54e3482
DC
64232011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6424
6425 * fns.c (Fputhash): Document return value.
6426
60002bf5
CY
64272011-06-06 Chong Yidong <cyd@stupidchicken.com>
6428
6429 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6430
0c671da6 64312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6432
b862a52a 6433 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6434
be44ca6c
PE
6435 Check for overflow when converting integer to cons and back.
6436 * charset.c (Fdefine_charset_internal, Fdecode_char):
6437 Use cons_to_unsigned to catch overflow.
6438 (Fencode_char): Use INTEGER_TO_CONS.
6439 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6440 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6441 * data.c (long_to_cons, cons_to_long): Remove.
6442 (cons_to_unsigned, cons_to_signed): New functions.
6443 These signal an error for invalid or out-of-range values.
6444 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6445 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6446 * font.c (Ffont_variation_glyphs):
6447 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6448 * lisp.h: Include <intprops.h>.
6449 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6450 (cons_to_signed, cons_to_unsigned): New decls.
6451 (long_to_cons, cons_to_long): Remove decls.
6452 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6453 (Fprimitive_undo): Use CONS_TO_INTEGER.
6454 * xfns.c (Fx_window_property): Likewise.
6455 * xselect.c: Include <limits.h>.
6456 (x_own_selection, selection_data_to_lisp_data):
6457 Use INTEGER_TO_CONS.
6458 (x_handle_selection_request, x_handle_selection_clear)
6459 (x_get_foreign_selection, Fx_disown_selection_internal)
6460 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6461 (lisp_data_to_selection_data): Use cons_to_unsigned.
6462 (x_fill_property_data): Use cons_to_signed.
6463 Report values out of range.
6464
d1f3d2af
PE
6465 Check for buffer and string overflow more precisely.
6466 * buffer.h (BUF_BYTES_MAX): New macro.
6467 * lisp.h (STRING_BYTES_MAX): New macro.
6468 * alloc.c (Fmake_string):
6469 * character.c (string_escape_byte8):
6470 * coding.c (coding_alloc_by_realloc):
6471 * doprnt.c (doprnt):
6472 * editfns.c (Fformat):
6473 * eval.c (verror):
6474 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6475 since they may not be the same number.
6476 * editfns.c (Finsert_char):
6477 * fileio.c (Finsert_file_contents):
6478 Likewise for BUF_BYTES_MAX.
6479
dd52fcea
PE
6480 * image.c: Use ptrdiff_t, not int, for sizes.
6481 (slurp_file): Switch from int to ptrdiff_t.
6482 All uses changed.
6483 (slurp_file): Check that file size fits in both size_t (for
6484 malloc) and ptrdiff_t (for sanity and safety).
6485
7f9bbdbb
PE
6486 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6487 if b->modtime has its maximal value.
6488
dfe18f82
PE
6489 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6490
84acfcf0
PE
6491 Don't assume time_t can fit into int.
6492 * buffer.h (struct buffer.modtime): Now time_t, not int.
6493 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6494 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6495
ccd9a01a
PE
6496 Minor fixes for signed vs unsigned integers.
6497 * character.h (MAYBE_UNIFY_CHAR):
6498 * charset.c (maybe_unify_char):
6499 * keyboard.c (read_char, reorder_modifiers):
6500 XINT -> XFASTINT, since the integer must be nonnegative.
6501 * ftfont.c (ftfont_spec_pattern):
6502 * keymap.c (access_keymap, silly_event_symbol_error):
6503 XUINT -> XFASTINT, since the integer must be nonnegative.
6504 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6505 since it makes no difference and we prefer signed.
6506 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6507 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6508 nonnegative.
6509
d6d100dd
SM
65102011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6511
6512 * window.h (Fwindow_frame): Declare.
6513
2b6148e4
PE
65142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6515
6516 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6517 (SPARE_MEMORY): Always define.
6518 (LARGE_REQUEST): Remove.
6519 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6520
f230ecc9
MR
65212011-06-06 Martin Rudalics <rudalics@gmx.at>
6522
727e958e
MR
6523 * lisp.h: Move EXFUNS for Fframe_root_window,
6524 Fframe_first_window and Fset_frame_selected_window to window.h.
6525
6526 * window.h: Move EXFUNS for Fframe_root_window,
6527 Fframe_first_window and Fset_frame_selected_window here from
6528 lisp.h.
6529
6530 * frame.c (Fwindow_frame, Fframe_first_window)
6531 (Fframe_root_window, Fframe_selected_window)
6532 (Fset_frame_selected_window): Move to window.c.
6533 (Factive_minibuffer_window): Move to minibuf.c.
6534 (Fother_visible_frames_p): New function.
6535
6536 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6537
f230ecc9
MR
6538 * window.c (decode_window, decode_any_window): Move up in code.
6539 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6540 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6541 (Fwindow_buffer): Move up and rewrite doc-string.
6542 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6543 (Fwindow_prev): New functions.
727e958e
MR
6544 (Fwindow_frame): Move here from frame.c. Accept any window as
6545 argument.
6546 (Fframe_root_window, Fframe_first_window)
6547 (Fframe_selected_window): Move here from frame.c. Accept frame
6548 or arbitrary window as argument. Update doc-strings.
6549 (Fminibuffer_window): Move up in code.
6550 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6551 (Fset_frame_selected_window): Move here from frame.c.
6552 Marginal rewrite.
727e958e
MR
6553 (Fselected_window, select_window, Fselect_window): Move up in
6554 code. Minor doc-string fixes.
f230ecc9 6555
4d09bcf6
PE
65562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6557
6558 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6559 Do not assume that spare memory exists; that assumption is valid
6560 only if SYSTEM_MALLOC.
6561 (LARGE_REQUEST): New macro, so that the issue of large requests
6562 is separated from the issue of spare memory.
6563
810928a2
AS
65642011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6565
172418ad
AS
6566 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6567 format. (Bug#8806)
6568
43f862f7
AS
6569 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6570
810928a2
AS
6571 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6572 before statements.
6573
a059fe24
JD
65742011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6575
6576 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6577
6578 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6579
6580 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6581 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6582
989bf368
JB
65832011-06-05 Juanma Barranquero <lekktu@gmail.com>
6584
6585 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6586
4b80f674
CY
65872011-06-04 Chong Yidong <cyd@stupidchicken.com>
6588
6589 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6590 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6591 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6592 New error handlers.
4b80f674
CY
6593 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6594 Obey Vx_select_enable_clipboard_manager. Catch errors in
6595 x_clipboard_manager_save (Bug#8779).
6596 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6597 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6598
99a33b77 65992011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6600
6601 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6602
99a33b77 66032011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6604
6605 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6606 in the current matrix if keep_current_p is non-zero.
6607
8264569d
EZ
66082011-06-04 Eli Zaretskii <eliz@gnu.org>
6609
6610 * bidi.c (bidi_level_of_next_char): Fix last change.
6611
57f97249
EZ
66122011-06-03 Eli Zaretskii <eliz@gnu.org>
6613
fec2107c 6614 Support bidi reordering of text covered by display properties.
57f97249 6615
fec2107c
EZ
6616 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6617 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6618 (bidi_cache_search, bidi_cache_iterator_state)
6619 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6620 (bidi_level_of_next_char, bidi_move_to_visually_next):
6621 Support character positions inside a run of characters covered by a
fec2107c
EZ
6622 display string.
6623 (bidi_paragraph_init, bidi_resolve_explicit_1)
6624 (bidi_level_of_next_char): Call bidi_fetch_char and
6625 bidi_fetch_char_advance instead of FETCH_CHAR and
6626 FETCH_CHAR_ADVANCE.
6627 (bidi_init_it): Initialize new members.
6628 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6629 definitions.
6630 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6631 instead of using explicit *_CHAR codes.
d6d100dd
SM
6632 (bidi_resolve_explicit, bidi_resolve_weak):
6633 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6634 bidirectional text is supported only in multibyte buffers.
6635 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6636 it to initialize the frame_window_p member of struct bidi_it.
6637 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6638 (bidi_resolve_explicit, bidi_resolve_weak)
6639 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6640 bidi_it->nchars is non-positive.
6641 (bidi_level_of_next_char): Don't try to lookup the cache for the
6642 next/previous character if nothing is cached there yet, or if we
6643 were just reseat()'ed to a new position.
c40e2fb2 6644
0e14fe90
EZ
6645 * xdisp.c (set_cursor_from_row): Set start and stop points
6646 according to the row's direction when priming the loop that looks
6647 for the glyph on which to display cursor.
6648 (single_display_spec_intangible_p): Function deleted.
6649 (display_prop_intangible_p): Reimplement to call
6650 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6651 Accept 3 additional arguments needed by handle_display_spec.
6652 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6653 values: lists, `(when COND...)' forms, etc.
6654 (single_display_spec_string_p): Support property values that are
6655 lists with the argument STRING its top-level element.
6656 (display_prop_string_p): Fix the condition for processing a
6657 property that is a list to be consistent with handle_display_spec.
fec2107c 6658 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6659 last portion of handle_display_prop.
6660 (compute_display_string_pos): Accept additional argument
6661 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6662 value of a `display' property is a "replacing spec".
6663 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6664 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6665 the display property, but just return a value indicating whether
6666 the display property will replace the characters it covers.
6667 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6668 frame_window_p members of struct bidi_it.
d6d100dd
SM
6669 (compute_display_string_pos, compute_display_string_end):
6670 New functions.
fec2107c
EZ
6671 (push_it): Accept second argument POSITION, where pop_it should
6672 jump to continue iteration.
6673 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6674
fec2107c
EZ
6675 * keyboard.c (adjust_point_for_property): Adjust the call to
6676 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6677
6678 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6679 (bidi_init_it): Update prototypes.
6680 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6681 (compute_display_string_pos, compute_display_string_end):
6682 Declare prototypes.
fec2107c
EZ
6683 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6684 EMACS_INT.
fc6f18ce 6685
40087514 66862011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6687
57f53182
PE
6688 Malloc failure behavior now depends on size of allocation.
6689 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6690 * lisp.h: Change signatures accordingly.
6691 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6692 All callers changed. (Bug#8762)
6693
6694 * gnutls.c: Use Emacs's memory allocators.
6695 Without this change, the gnutls library would invoke malloc etc.
6696 directly, which causes problems on non-SYNC_INPUT hosts, and which
6697 runs afoul of improving memory_full behavior. (Bug#8761)
6698 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6699 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6700 xfree instead of the default malloc, realloc, free.
6701 (Fgnutls_boot): No need to check for memory allocation failure,
6702 since xmalloc does that for us.
6703
ac32cd99 6704 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6705 * category.c (hash_get_category_set):
6706 * ccl.c (ccl_driver):
6707 * charset.c (Fdefine_charset_internal):
6708 * charset.h (struct charset.hash_index):
6709 * composite.c (get_composition_id, gstring_lookup_cache)
6710 (composition_gstring_put_cache):
6711 * composite.h (struct composition.hash_index):
6712 * dispextern.h (struct image.hash):
6713 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6714 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6715 (hashfn_equal, hashfn_user_defined, make_hash_table)
6716 (maybe_resize_hash_table, hash_lookup, hash_put)
6717 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6718 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6719 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6720 * image.c (make_image, search_image_cache, lookup_image)
6721 (xpm_put_color_table_h):
6722 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6723 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6724 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6725 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6726 * alloc.c (allocate_vectorlike):
6727 Check for overflow in vector size calculations.
6728 * ccl.c (ccl_driver):
6729 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6730 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6731 need to be updated by these changes.
40087514
PE
6732 * fns.c (make_hash_table, maybe_resize_hash_table):
6733 Check for integer overflow with large hash tables.
0de4bb68
PE
6734 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6735 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6736 (SXHASH_REDUCE): New macro.
6737 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6738 Use it instead of discarding useful hash info with large hash values.
6739 (sxhash_float): New function.
6740 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6741 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6742 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6743 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6744 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6745 Adjust signatures to match updated version of code.
6746 (consing_since_gc): Now EMACS_INT, since a single hash table can
6747 use more than INT_MAX bytes.
6748
698d32e2
DN
67492011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6750
6751 Make it possible to build with GCC-4.6+ -O2 -flto.
6752
6753 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6754
fd6fa53f
SM
67552011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6756
6757 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6758 Call minibuffer-inactive-mode.
6759
864db017
JB
67602011-05-31 Juanma Barranquero <lekktu@gmail.com>
6761
6762 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6763 Update dependencies.
6764
2ad0baf4
DN
67652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6766
6767 * data.c (init_data): Remove code for UTS, this system is not
6768 supported anymore.
6769
4fcc2638
DN
67702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6771
6772 Don't force ./temacs to start in terminal mode.
6773
6774 * frame.c (make_initial_frame): Initialize faces in all cases, not
6775 only when CANNOT_DUMP is defined.
6776 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6777
c56e0fd5
DN
67782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6779
6780 * dispnew.c (add_window_display_history): Use const for the string
6781 pointer. Remove declaration, not needed.
6782
333d54da 67832011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6784
55d4c1b2 6785 Use 'inline', not 'INLINE'.
333d54da 6786 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6787 * alloc.c, fontset.c (INLINE): Remove.
6788 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6789 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6790 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6791 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6792 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6793
738db178
DN
67942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6795
6796 Make it possible to run ./temacs.
6797
6798 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6799 syms_of_callproc does the same thing. Remove test for
6800 "initialized", do it in the caller.
6801 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6802
620c53a6
SM
68032011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6804
6805 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6806 (read_minibuf): Use get_minibuffer.
6807 (syms_of_minibuf): Use DEFSYM.
6808 (Qmetadata): New var.
6809 * data.c (Qbuffer): Don't make it static.
6810 (syms_of_data): Use DEFSYM.
6811
e003a292
PE
68122011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6813
6814 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6815 (CCL_CODE_MIN): New macro.
6816
ed008a6d
PE
68172011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6818
3687c2ef
PE
6819 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6820
ed008a6d
PE
6821 * eval.c (Qdebug): Now static.
6822 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6823 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6824 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6825
d66c4c7c
CY
68262011-05-29 Chong Yidong <cyd@stupidchicken.com>
6827
6828 * image.c: Various fixes to ImageMagick code comments.
6829 (Fimagemagick_types): Doc fix.
6830
5fbc2025
PE
68312011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6832
0196f88a
PE
6833 Minor fixes prompted by GCC 4.6.0 warnings.
6834
6835 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6836
5fbc2025
PE
6837 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6838 (x_clipboard_manager_save_all): Move extern decl to ...
6839 * xterm.h: ... here, so that it can be checked for consistency.
6840
1dd3c2d9
CY
68412011-05-29 Chong Yidong <cyd@stupidchicken.com>
6842
6843 * xselect.c (x_clipboard_manager_save_frame)
6844 (x_clipboard_manager_save_all): New functions.
6845 (Fx_clipboard_manager_save): Lisp function deleted.
6846
6847 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6848 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6849
6850 * xterm.h: Update prototype.
6851
5ba6571d
WX
68522011-05-28 William Xu <william.xwl@gmail.com>
6853
6854 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6855 exiting (Bug#8239).
6856
3eaff834
JM
68572011-05-28 Jim Meyering <meyering@redhat.com>
6858
e1900994 6859 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6860 * fns.c (to_uchar): Define.
6861 (crypto_hash_function): Use it to convert some newly-signed
6862 variables to unsigned, to avoid sign-extension bugs. For example,
6863 without this change, (md5 "truc") would evaluate to
6864 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6865 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6866 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6867
0f6990a7
PE
68682011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6869
6870 Integer overflow fixes.
c8a9ca5a 6871
08686060
PE
6872 * dbusbind.c: Serial number integer overflow fixes.
6873 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6874 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6875 to hold a serial number that is too large for a fixnum.
6876 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6877 Check for serial numbers out of range. Decode any serial number
59568bf0 6878 that was so large that it became a float. (Bug#8722)
08686060 6879
2d1fc3c7
PE
6880 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6881 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6882 Use XFASTINT rather than XUINT when numbers are nonnegative.
6883 (xd_append_arg, Fdbus_method_return_internal):
6884 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6885 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6886 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6887 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6888 (Bug#8722)
2d1fc3c7 6889
c8a9ca5a
PE
6890 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6891
519e1d69
PE
6892 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6893
6df6ae42 6894 ccl: Add integer overflow checks.
30569699
PE
6895 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6896 (IN_INT_RANGE): New macros.
6897 (ccl_driver): Use them to check for integer overflow when
6898 decoding a CCL program. Many of the new checks are whether XINT (x)
6899 fits in int; it doesn't always, on 64-bit hosts. The new version
6900 doesn't catch all possible integer overflows, but it's an
847044ea 6901 improvement. (Bug#8719)
30569699 6902
c11285dc
PE
6903 * alloc.c (make_event_array): Use XINT, not XUINT.
6904 There's no need for unsigned here.
6905
fdccd48e
PE
6906 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6907 This follows up to the 2011-05-06 change that substituted uintptr_t
6908 for EMACS_INT. This case wasn't caught back then.
6909
37910ab2
PE
6910 Rework Fformat to avoid integer overflow issues.
6911 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6912 now (part of C89). Include <verify.h>.
6913 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6914 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6915 (Fformat): Avoid the prepass trying to compute sizes; it was only
6916 approximate and thus did not catch overflow reliably. Instead, walk
6917 through the format just once, formatting and computing sizes as we go,
6918 checking for integer overflow at every step, and allocating a larger
6919 buffer as needed. Keep track separately whether the format is
6920 multibyte. Keep only the most-recently calculated precision, rather
6921 than them all. Record whether each argument has been converted to
6922 string. Use EMACS_INT, not int, for byte and char and arg counts.
6923 Support field widths and precisions larger than INT_MAX. Avoid
6924 sprintf's undefined behavior with conversion specifications such as %#d
6925 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6926 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6927 formatting out-of-range floating point numbers with int
9173deec 6928 formats. (Bug#8668)
37910ab2 6929
2e6578fb
PE
6930 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6931
0ae6bdee
PE
6932 * data.c: Avoid integer truncation in expressions involving floats.
6933 * data.c: Include <intprops.h>.
6934 (arith_driver): When there's an integer overflow in an expression
6935 involving floating point, convert the integers to floating point
6936 so that the resulting value does not suffer from catastrophic
6937 integer truncation. For example, on a 64-bit host (* 4
6938 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6939 Do not rely on undefined behavior after integer overflow.
6940
de883a70
PE
6941 merge count_size_as_multibyte, parse_str_to_multibyte
6942 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6943 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6944 Check for integer overflow.
6945 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6946 since it's now a duplicate of the other. This is more of
6947 a character than a buffer op, so better that it's in character.c.
6948 * fns.c, print.c: Adjust to above changes.
6949
2ff916cb
PE
69502011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6951
6952 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6953
f1b54466
PE
69542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6955
fb1ac845
PE
6956 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6957 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6958 (x_clipboard_manager_save): Now static.
6959 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6960
f1b54466
PE
6961 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6962 (crypto_hash_function): Now static.
6963 Fix pointer signedness problems. Avoid unnecessary initializations.
6964
a9f737ee
CY
69652011-05-27 Chong Yidong <cyd@stupidchicken.com>
6966
6967 * termhooks.h (Vselection_alist): Make it terminal-local.
6968
6969 * terminal.c (create_terminal): Initialize it.
6970
6971 * xselect.c: Support for clipboard managers.
6972 (Vselection_alist): Move to termhooks.h as terminal-local var.
6973 (LOCAL_SELECTION): New macro.
6974 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6975 (symbol_to_x_atom): Remove gratuitous arg.
6976 (x_handle_selection_request, lisp_data_to_selection_data)
6977 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6978 (x_own_selection, x_get_local_selection, x_convert_selection):
6979 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6980 (some_frame_on_display): Delete unused function.
6981 (Fx_own_selection_internal, Fx_get_selection_internal)
6982 (Fx_disown_selection_internal, Fx_selection_owner_p)
6983 (Fx_selection_exists_p): New optional frame arg.
6984 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6985 (x_handle_selection_clear): Don't treat other terminals with the
6986 same keyboard specially. Use the terminal-local Vselection_alist.
6987 (x_clear_frame_selections): Use Frun_hook_with_args.
6988
6989 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6990
6991 * xterm.h: Add support for those atoms.
6992
e067f0c1
CY
69932011-05-26 Chong Yidong <cyd@stupidchicken.com>
6994
6995 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6996 (converted_selections, conversion_fail_tag): New global variables.
6997 (x_selection_request_lisp_error): Free the above.
6998 (x_get_local_selection): Remove unnecessary code.
6999 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
7000 of converted selections stored in converted_selections.
7001 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
7002 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
7003 (x_convert_selection): New function.
7004 (x_handle_selection_event): Simplify.
7005 (x_get_foreign_selection): Don't ignore incoming requests while
7006 waiting for an answer; this will fail when we implement
7007 SAVE_TARGETS, and seems unnecessary anyway.
7008 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
7009 (Vx_sent_selection_functions): Doc fix.
7010
0f4aebc0
LL
70112011-05-26 Leo Liu <sdl.web@gmail.com>
7012
7013 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
7014
e61124cd
YM
70152011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7016
7017 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7018
7019 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7020 for fringe update if it has periodic bitmap.
ac389d0c 7021 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
7022 and fringe_bitmap_periodic_p.
7023
7024 * fringe.c (get_fringe_bitmap_data): New function.
7025 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7026 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7027 row. Mark glyph row for fringe update if periodicity changed.
7028
7029 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7030 for fringe update unless it has periodic bitmap.
7031
f16d9837
KH
70322011-05-25 Kenichi Handa <handa@m17n.org>
7033
7034 * xdisp.c (get_next_display_element): Set correct it->face_id for
7035 a static composition.
7036
e1b90ef6
LL
70372011-05-24 Leo Liu <sdl.web@gmail.com>
7038
7039 * deps.mk (fns.o):
7040 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7041
7042 * fns.c (crypto_hash_function, Fsha1): New function.
7043 (Fmd5): Use crypto_hash_function.
7044 (syms_of_fns): Add Ssha1.
7045
7400048f
PE
70462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7047
7048 * gnutls.c: Remove unused macros.
7049 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7050 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7051 Remove macros that are defined and never used.
7052 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7053
abb71cf4
CY
70542011-05-22 Chong Yidong <cyd@stupidchicken.com>
7055
7056 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
7057 (Fx_get_selection_internal): Minor cleanup.
7058 (Fx_own_selection_internal): Rename arguments for consistency with
7059 select.el.
7060
6307db39
PE
70612011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7062
7063 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
7064
f3d4e0a4
CY
70652011-05-22 Chong Yidong <cyd@stupidchicken.com>
7066
7067 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
7068
4d8ade89
YM
70692011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7070
7071 * dispnew.c (scrolling_window): Don't exclude the case that the
7072 last enabled row in the desired matrix touches the bottom boundary.
7073
32078c8d
GM
70742011-05-21 Glenn Morris <rgm@gnu.org>
7075
7076 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
7077 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7078 and add some more files.
32078c8d 7079
7285dc67
EZ
70802011-05-20 Eli Zaretskii <eliz@gnu.org>
7081
7082 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7083 report_file_error introduced by the change from 2011-05-07.
7084
89d1bd22
PE
70852011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7086
7087 * systime.h (Time): Define only if emacs is defined.
7088 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7089 where the include path doesn't have X11/X.h by default. See
7090 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7091
cd394be1 70922011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
7093
7094 * composite.c (find_automatic_composition): Fix previous change.
7095
b9704ad9
GM
70962011-05-20 Glenn Morris <rgm@gnu.org>
7097
7098 * lisp.mk: New file, split from Makefile.in.
7099 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7100 (shortlisp): Remove.
7101 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7102
4a720484
GM
71032011-05-19 Glenn Morris <rgm@gnu.org>
7104
7105 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7106 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7107 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7108 (lisp): Set the order to that of loadup.el.
7109 (shortlisp): Make it a copy of $lisp.
7110 (SOME_MACHINE_LISP): Remove.
7111 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7112 Use just $shortlisp, not $SOME_MACHINE_LISP too.
7113
a28d4396
KH
71142011-05-18 Kenichi Handa <handa@m17n.org>
7115
7116 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7117 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7118 (find_automatic_composition): Mostly rewrite for efficiency.
7119
a2b1fa8e
JB
71202011-05-18 Juanma Barranquero <lekktu@gmail.com>
7121
7122 * makefile.w32-in: Update dependencies.
7123
8e1f5610
CS
71242011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7125
7126 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 7127 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 7128
7025ee00 71292011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 7130
cdfa6eab
PE
7131 Fix some integer overflow issues, such as string length overflow.
7132
06d6db33
PE
7133 * insdel.c (count_size_as_multibyte): Check for string overflow.
7134
2b4560a8
PE
7135 * character.c (lisp_string_width): Check for string overflow.
7136 Use EMACS_INT, not int, for string indexes and lengths; in
7137 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
7138 the resulting string length overflows an EMACS_INT; instead,
7139 report a string overflow if no precision given. When checking for
7140 precision exhaustion, use a check that cannot possibly have
7141 integer overflow. (Bug#8675)
7142 * character.h (lisp_string_width): Adjust to new signature.
7143
cb93f9be
PE
7144 * alloc.c (string_overflow): New function.
7145 (Fmake_string): Use it. This doesn't change behavior, but saves
7146 a few bytes and will simplify future changes.
7147 * character.c (string_escape_byte8): Likewise.
7148 * lisp.h (string_overflow): New decl.
7149
1a1f3366
PE
7150 Fixups, following up to the user-interface timestamp change.
7151 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
7152 for UI timestamps, instead of unsigned long.
9fbd6841
PE
7153 * msdos.c (mouse_get_pos): Likewise.
7154 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
7155 * w32gui.h (Time): Define by including "systime.h" rather than by
7156 declaring it ourselves. (Bug#8664)
7157
d4e3e4d3
PE
7158 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7159 * image.c (clear_image_cache): Likewise.
7160
f6a24d19
PE
7161 * term.c (term_mouse_position): Don't assume time_t wraparound.
7162
08dc5ae6
PE
7163 Be more systematic about user-interface timestamps.
7164 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
7165 and sometimes 'EMACS_UINT', to represent these timestamps.
7166 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
7167 This makes the code easier to follow, and makes it easier to catch
7168 integer overflow bugs such as Bug#8664.
7169 * frame.c (Fmouse_position, Fmouse_pixel_position):
7170 Use Time, not unsigned long, for user-interface timestamps.
7171 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7172 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7173 * keyboard.h (last_event_timestamp): Likewise.
7174 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7175 * menu.h (xmenu_show): Likewise.
7176 * term.c (term_mouse_position): Likewise.
7177 * termhooks.h (struct input_event.timestamp): Likewise.
7178 (struct terminal.mouse_position_hook): Likewise.
7179 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7180 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7181 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7182 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7183 what it was before.
7184 * menu.h, termhooks.h: Include "systime.h", for Time.
7185
8e55734a
PE
7186 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7187 Don't assume that the difference between two unsigned long values
7188 can fit into an integer. At this point, we know button_down_time
7189 <= event->timestamp, so the difference must be nonnegative, so
7190 there's no need to cast the result if double-click-time is
7191 nonnegative, as it should be; check that it's nonnegative, just in
7192 case. This bug is triggered when events are more than 2**31 ms
86db42d2 7193 apart (about 25 days). (Bug#8664)
8e55734a 7194
841f1b75 7195 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 7196 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 7197
3e26f69c
PE
7198 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7199 that always fit in int. Use a sentinel instead of a counter, to
7200 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
7201 * frame.h (struct frame): Use int for menu_bar_items_used
7202 instead of EMACS_INT, since it always fits in int.
3e26f69c 7203
5cc152c0
PE
7204 * menu.c (grow_menu_items): Check for int overflow.
7205
d89eb65e
PE
7206 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7207
5235bd3e
PE
7208 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7209 Before, the code was not consistent. These values cannot exceed
7210 2**31 - 1 so there's no need to make them unsigned.
7211 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7212 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7213 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7214 as modifiers.
7215 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7216
bc827e23
PE
7217 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7218 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7219 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7220 presumably because the widths might not match.
7221
78eb494e
PE
7222 * window.c (size_window): Avoid needless test at loop start.
7223
04f2d78b
CB
72242011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7225
7226 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7227
d2fc7e3d 72282011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
7229
7230 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7231
d2fc7e3d 72322011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
7233
7234 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7235 `width' to `bar_area_x' and `bar_area_width', respectively.
7236 (x_scroll_run): Take account of fringe background extension.
7237
04f2d78b
CB
7238 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7239 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
7240 `bar_area_width', respectively.
7241 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7242 background extension.
7243
79b70037
GM
72442011-05-10 Jim Meyering <meyering@redhat.com>
7245
7246 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7247
2f142cc5
JB
72482011-05-10 Juanma Barranquero <lekktu@gmail.com>
7249
7250 * image.c (Finit_image_library): Return t for built-in image types,
7251 like pbm and xbm. (Bug#8640)
7252
57679c86
AS
72532011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7254
7255 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7256
888c9e86
EZ
72572011-05-07 Eli Zaretskii <eliz@gnu.org>
7258
b0512a1d
EZ
7259 * w32console.c (Fset_screen_color): Doc fix.
7260 (Fget_screen_color): New function.
7261 (syms_of_ntterm): Defsubr it.
7262
7285dc67
EZ
7263 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7264 unlink the temporary file if Fcall_process didn't create it in the
7265 first place.
7266 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7267 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
7268 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7269 cue to call_process_cleanup not to close that handle.
7270
4d3fcc8e
BK
72712011-05-07 Ben Key <bkey76@gmail.com>
7272
7273 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7274 one of two shell specific rules, either bootstrap-temacs-CMD or
7275 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7276 to the previous implementation of the bootstrap-temacs rule.
7277 The bootstrap-temacs-CMD rule is similar to the previous
7278 implementation of the bootstrap-temacs rule except that it
7279 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7280 variable.
7281
7282 These changes, along with some changes to nt/configure.bat,
7283 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7284 earlier fix to add support for --cflags and --ldflags options
7285 that include quotes so that it works whether make uses cmd or
7286 sh as the shell.
7287
b4289b64
MA
72882011-05-06 Michael Albinus <michael.albinus@gmx.de>
7289
7290 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7291 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7292 is a constant.
7293 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7294 a string. Handle both cases.
7295 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7296 (Fdbus_register_method): Use Qinvalid_function.
7297
af4c0e28
JB
72982011-05-06 Juanma Barranquero <lekktu@gmail.com>
7299
7300 * makefile.w32-in: Update dependencies.
7301 (LISP_H): Add inttypes.h and stdin.h.
7302 (PROCESS_H): Add unistd.h.
7303
c51453d9
EZ
73042011-05-06 Eli Zaretskii <eliz@gnu.org>
7305
7306 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7307 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7308
8ff0ac3c 73092011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 7310
4c4b566b
PE
7311 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7312
aab2b9b5
PE
7313 * term.c (vfatal): Remove stray call to va_end.
7314 It's not needed and the C Standard doesn't allow it here anyway.
7315
c378da0b
PE
7316 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7317 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7318
288b08c7
PE
7319 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7320 bytes.
7321
e3601888
PE
7322 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7323
db6c0e74
PE
7324 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7325
dd5963ea
PE
7326 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7327
88c9450f
PE
7328 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7329
2f9442b8
PE
7330 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7331
c032b5f8
PE
7332 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7333 * charset.c (Fdefine_charset_internal): Don't initialize
7334 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 7335 32-bit int (Bug#8600).
a108c10b
PE
7336
7337 * lread.c (read_integer): Be more consistent with string-to-number.
7338 Use string_to_number to do the actual conversion; this avoids
7339 rounding errors and fixes some other screwups. Without this fix,
7340 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7341 (digit_to_number): Move earlier, for benefit of read_integer.
7342 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 7343 not a digit in any supported base. (Bug#8602)
a108c10b 7344
ad5f9eea
PE
7345 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7346
aec1708a
PE
7347 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7348 to match comment at start of function. This also removes a
7349 GCC warning about overflow in a 32+64-bit port.
7350
47be4ab5
PE
7351 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7352
371cac43
PE
7353 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7354 Reported by Stefan Monnier in
7355 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
7356 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7357 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 7358
d01a7826
PE
7359 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7360 (EMACS_UINTPTR): Likewise, with uintptr_t.
7361
7fd47d5c
PE
7362 * lisp.h: Prefer 64-bit EMACS_INT if available.
7363 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7364 on 32-bit hosts that have 64-bit int, so that they can access
7365 large files.
122b0c86
PE
7366 However, temporarily disable this change unless the temporary
7367 symbol WIDE_EMACS_INT is defined.
7fd47d5c 7368
8727937b
PE
7369 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7370
8ac068ac
PE
7371 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7372 This removes an assumption that EMACS_INT and long are the same
7373 width as pointers. The assumption is true for Emacs porting targets
7374 now, but we want to make other targets possible.
7375 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7376 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7377 In the rest of the code, change types of integers that hold casted
7378 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7379 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7380 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7381 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7382 No need to cast type when ORing.
7383 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7384 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7385 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7386 assume EMACS_INT is the same width as char *.
7387 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7388 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7389 Remove no-longer-needed casts.
7390 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7391 (xg_tool_bar_help_callback, xg_make_tool_item):
7392 Use EMACS_INTPTR to hold an integer
7393 that will be cast to void *; this can avoid a GCC warning
7394 if EMACS_INT is not the same width as void *.
7395 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7396 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7397 (current_message_1, set_message_1):
7398 Use a local to convert to proper width without a cast.
7399 * xmenu.c (dialog_selection_callback): Likewise.
7400
ede49d71
PE
7401 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7402 Also, don't assume VALBITS / RAND_BITS is less than 5,
7403 and don't rely on undefined behavior when shifting a 1 left into
7404 the sign bit.
7405 * lisp.h (get_random): Change signature to match.
7406
2f30ecd0
PE
7407 * lread.c (hash_string): Use size_t, not int, for hash computation.
7408 Normally we prefer signed values; but hashing is special, because
7409 it's better to use unsigned division on hash table sizes so that
7410 the remainder is nonnegative. Also, size_t is the natural width
7411 for hashing into memory. The previous code used 'int', which doesn't
7412 retain enough info to hash well into very large tables.
7413 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7414
2a866e7b
PE
7415 * dbusbind.c: Don't possibly lose pointer info when converting.
7416 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7417 Use XPNTR rather than XHASH, so that the high-order bits of
7418 the pointer aren't lost when converting through void *.
7419
51639eac
PE
7420 * eval.c (Fautoload): Don't double-shift a pointer.
7421
92394119
PE
7422 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7423
dbdb9a7c
JB
74242011-05-06 Juanma Barranquero <lekktu@gmail.com>
7425
7426 * gnutls.c (DEF_GNUTLS_FN):
7427 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7428
db7a0b4f
AS
74292011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7430
7431 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7432 marker. (Bug#8610)
7433
cd394be1 74342011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7435
7436 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7437 New version that can reserve upto 2GB of heap space.
7438
f7ff1b0f 74392011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7440
7441 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7442
639c109b
TZ
74432011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7444
7445 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7446 `gnutls_certificate_set_x509_key_file'.
7447
d2127135
JB
74482011-05-05 Juanma Barranquero <lekktu@gmail.com>
7449
7450 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7451 Update dependencies.
7452
e968f4f3
JB
74532011-05-04 Juanma Barranquero <lekktu@gmail.com>
7454
7455 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7456 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7457 Remove unused parameter `fildes'.
7458 * process.c (read_process_output, send_process): Don't pass it.
7459
84d358f0
JB
74602011-05-04 Juanma Barranquero <lekktu@gmail.com>
7461
7462 Fix previous change: the library cache is defined in w32.c.
7463 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7464 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7465
0898ca10
JB
74662011-05-04 Juanma Barranquero <lekktu@gmail.com>
7467
7468 Implement dynamic loading of GnuTLS on Windows.
7469
7470 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7471 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7472 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7473 Declare.
7474
7475 * gnutls.c (Qgnutls_dll): Define.
7476 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7477 (gnutls_*): Declare function pointers.
7478 (init_gnutls_functions): New function to initialize function pointers.
7479 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7480 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7481 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7482 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7483 (emacs_gnutls_write, emacs_gnutls_read)
7484 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7485 (Fgnutls_available_p): New function.
7486 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7487 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7488 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7489
7490 * image.c: Include w32.h.
7491 (Vimage_type_cache): Delete.
7492 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7493 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7494 (w32_delayed_load): Move to w32.c.
7495
7496 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7497
7498 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7499 (w32_delayed_load): Move from image.c. When loading a library, record
7500 its filename in the :loaded-from property of the library id.
7501 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7502 Initialize and staticpro them.
7503 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7504
7505 * process.c: Include lisp.h before w32.h, not after.
7506 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7507 instead of gnutls_record_check_pending.
7508
7509 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7510
ff4de4aa
TZ
75112011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7512
7513 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7514 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7515 as passed in.
7516
abe95abb
JD
75172011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7518
7519 * xterm.c (x_set_frame_alpha): Do not set property on anything
7520 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7521
e16e55d4
JB
75222011-05-02 Juanma Barranquero <lekktu@gmail.com>
7523
7524 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7525
bafcf6a5
JB
75262011-05-02 Juanma Barranquero <lekktu@gmail.com>
7527
7528 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7529 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7530 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7531 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7532 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7533 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7534 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7535 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7536 (Qgnutls_bootprop_callbacks_verify): Make static.
7537
e7a6747f
AS
75382011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7539
19ed11ba
AS
7540 * callproc.c: Indentation fixup.
7541
e7a6747f 7542 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7543 (wait_for_termination, interruptible_wait_for_termination):
7544 Move after wait_for_termination_1.
e7a6747f 7545
1ef14cb4
LMI
75462011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7547
7548 * sysdep.c (interruptible_wait_for_termination): New function
7549 which is like wait_for_termination, but allows keyboard
7550 interruptions.
7551
7552 * callproc.c (Fcall_process): Add (:file "file") as an option for
7553 the STDOUT buffer.
7554 (Fcall_process_region): Ditto.
7555
330d880c
EZ
75562011-04-30 Eli Zaretskii <eliz@gnu.org>
7557
8db90b73
EZ
7558 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7559 rather than `XVECTOR (FOO)->size'.
7560
330d880c
EZ
7561 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7562 inttypes.h, as a gnulib replacement is used if it not available in
7563 system headers.
7564
15cbd324
EZ
75652011-04-21 Eli Zaretskii <eliz@gnu.org>
7566
7567 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7568 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7569 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7570
7571 * coding.c (coding_alloc_by_realloc): Error out if destination
7572 will grow beyond MOST_POSITIVE_FIXNUM.
7573 (decode_coding_emacs_mule): Abort if there isn't enough place in
7574 charbuf for the composition carryover bytes. Reserve an extra
7575 space for up to 2 characters produced in a loop.
7576 (decode_coding_iso_2022): Abort if there isn't enough place in
7577 charbuf for the composition carryover bytes.
7578
75792011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7580
ae940cca
EZ
7581 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7582 aborting when %lld or %lll format is passed.
7583 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7584 %llo or %llx format is passed. (Bug#8545)
7585
03ab8921
EZ
7586 * window.c (window_scroll_line_based): Use a marker instead of
7587 simple variables to record original value of point. (Bug#7952)
7588
afda1437
EZ
7589 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7590 produced by %s or %c overflows available buffer space. (Bug#8545)
7591
f76dee0c
PE
75922011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7593
7594 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7595 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7596
fdc5744d
JB
75972011-04-28 Juanma Barranquero <lekktu@gmail.com>
7598
7599 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7600
638f053a
JB
76012011-04-28 Juanma Barranquero <lekktu@gmail.com>
7602
7603 * keyboard.c (Qdelayed_warnings_hook): Define.
7604 (command_loop_1): Run `delayed-warnings-hook'
7605 if Vdelayed_warnings_list is non-nil.
7606 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7607 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7608
d178f871
EZ
76092011-04-28 Eli Zaretskii <eliz@gnu.org>
7610
7611 * doprnt.c (doprnt): Don't return value smaller than the buffer
7612 size if the message was truncated. (Bug#8545).
7613
b124fd93
JB
76142011-04-28 Juanma Barranquero <lekktu@gmail.com>
7615
7616 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7617 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7618
e810457d
PE
76192011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7620
7621 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7622
ea51cceb
JB
76232011-04-27 Juanma Barranquero <lekktu@gmail.com>
7624
7625 * makefile.w32-in: Update dependencies.
7626
94dcfacf
EZ
76272011-04-27 Eli Zaretskii <eliz@gnu.org>
7628
7629 Improve `doprnt' and its usage. (Bug#8545)
7630 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7631 `format_end'. Remove support for %l as a conversion specifier.
7632 Don't use xrealloc. Improve diagnostics when the %l size modifier
7633 is used. Update the commentary.
7634
7635 * eval.c (verror): Simplify calculation of size_t.
7636
7637 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7638 messages.
7639
f61f41d7
PE
76402011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7641
7642 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7643 change.
7644
96fb4434
PE
76452011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7646
7647 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7648 This makes this file independent of the recent pseudovector change.
7649
671875da 76502011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7651
69e9b5a3
PE
7652 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7653
b5f869a7 7654 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7655 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7656 Remove unused local.
c8926152 7657 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7658
841a1577 7659 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7660 GCC 4.6.0 optimizes based on type-based alias analysis.
7661 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7662 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7663 != &v->size, and therefore "v->size = 1; b->size = 2; return
7664 v->size;" must therefore return 1. This assumption is incorrect
7665 for Emacs, since it type-puns struct Lisp_Vector * with many other
7666 types. To fix this problem, this patch adds a new type struct
f904488f 7667 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7668 and pseudovectors, and helps optimizing compilers not get fooled
7669 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7670 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7671 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7672 the size member.
eab3844f
PE
7673 (XSETPVECTYPE): Rewrite in terms of new macro.
7674 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7675 This is a bit clearer, and further avoids the possibility of
7676 undesirable aliasing.
7677 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7678 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7679 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7680 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7681 (ASIZE): Now uses header.size rather than size.
7682 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7683 to avoid the hassle of writing XVECTOR (foo)->header.size.
7684 (struct vectorlike_header): New type.
eab3844f
PE
7685 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7686 object, to help avoid aliasing.
7687 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7688 (SUBRP): Likewise, since Lisp_Subr is a special case.
7689 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7690 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7691 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7692 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7693 changed to be "header.size" and "header.next".
7694 * buffer.h (struct buffer): Likewise.
7695 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7696 * frame.h (struct frame): Likewise.
7697 * process.h (struct Lisp_Process): Likewise.
7698 * termhooks.h (struct terminal): Likewise.
7699 * window.c (struct save_window_data, struct saved_window): Likewise.
7700 * window.h (struct window): Likewise.
7701 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7702 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7703 * buffer.c (init_buffer_once): Likewise.
7704 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7705 special case.
7706 * process.c (Fformat_network_address): Use local var for size,
7707 for brevity.
7708
0df1eac5
PE
7709 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7710
847ab9d1 7711 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7712 * data.c (atof): Remove decl; no longer used or needed.
7713 (digit_to_number): Move to lread.c.
7714 (Fstring_to_number): Use new string_to_number function, to be
7715 consistent with how the Lisp reader treats infinities and NaNs.
7716 Do not assume that floating-point numbers represent EMACS_INT
7717 without losing information; this is not true on most 64-bit hosts.
7718 Avoid double-rounding errors, by insisting on integers when
7719 parsing non-base-10 numbers, as the documentation specifies.
7720 * lisp.h (string_to_number): New decl, replacing ...
7721 (isfloat_string): Remove.
bc0a5c13 7722 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7723 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7724 appears to have been a coding error. Similarly, do not accept
7725 strings like +-1e0 as floating point numbers. Do not report
7726 overflow for integer overflows unless the base is not 10 which
7727 means we have no simple and reliable way to continue.
7728 Break out the floating-point parsing into a new
7729 function string_to_number, so that Fstring_to_number parses
7730 floating point numbers consistently with the Lisp reader.
04f2d78b 7731 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7732 (E_CHAR, EXP_INT): Remove, replacing with ...
7733 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7734 (string_to_number): New function, replacing isfloat_string.
7735 This function checks for valid syntax and produces the resulting
7736 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7737 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7738 so that overflow for non-base-10 numbers is reported only when
7739 there's no portable and simple way to convert to floating point.
452f4150 7740
67769ffc
PE
7741 * textprop.c (set_text_properties_1): Rewrite for clarity,
7742 and to avoid GCC warning about integer overflow.
7743
c20db43f
PE
7744 * intervals.h (struct interval): Use EMACS_INT for members
7745 where EMACS_UINT might cause problems. See
7746 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7747 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7748 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7749 All uses changed.
37aa2f85
PE
7750 (offset_intervals): Tell GCC not to worry about length overflow
7751 when negating a negative length.
c20db43f 7752
2538aa2f
PE
7753 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7754 (overrun_check_free): Likewise.
7755
f2d3008d
PE
7756 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7757 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7758 word size.
7759
ec8df744
PE
7760 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7761 (gnutls_make_error): Rename local to avoid shadowing.
7762 (gnutls_emacs_global_deinit): ifdef out; not used.
7763 (Fgnutls_boot): Use const for pointer to readonly storage.
7764 Comment out unused local. Fix pointer signedness problems.
7765
640ee02d
PE
7766 * lread.c (openp): Don't stuff size_t into an 'int'.
7767 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7768 about possible signed overflow.
7769
6048fb2a
PE
7770 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7771 (GDK_KEY_g): Don't define if already defined.
7772 (xg_prepare_tooltip): Avoid pointer signedness problem.
7773 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7774
fa3c87e1
PE
7775 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7776 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7777
2172544b
PE
7778 * xfns.c (Fx_window_property): Simplify a bit,
7779 to make a bit faster and to avoid GCC 4.6.0 warning.
7780 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7781
9b821a21
PE
7782 * fns.c (internal_equal): Don't assume size_t fits in int.
7783
3c616cfa
PE
7784 * alloc.c (compact_small_strings): Tighten assertion a little.
7785
c2982e87
PE
7786 Replace pEd with more-general pI, and fix some printf arg casts.
7787 * lisp.h (pI): New macro, generalizing old pEd macro to other
7788 conversion specifiers. For example, use "...%"pI"d..." rather
7789 than "...%"pEd"...".
7790 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7791 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7792 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7793 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7794 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7795 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7796 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7797 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7798 64-bit hosts.
7799 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7800 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7801 * print.c (safe_debug_print, print_object): Likewise.
7802 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7803 to int.
6f04d126
PE
7804 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7805 avoiding the 0 flag, which is not portable.
c2982e87
PE
7806 * process.c (Fmake_network_process): Use pI to avoid cast.
7807 * region-cache.c (pp_cache): Likewise.
7808 * xdisp.c (decode_mode_spec): Likewise.
7809 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7810 behavior on 64-bit hosts with printf arg.
6f04d126 7811 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7812 (x_stop_queuing_selection_requests): Likewise.
7813 (x_get_window_property): Don't truncate byte count to an 'int'
7814 when tracing.
0b432f21 7815
5e073ec7
PE
7816 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7817 here, since it parses constructs like leading '-' and spaces,
7818 which are not wanted; and it overflows with large numbers.
7819 Instead, simply match F[0-9]+, which is what is wanted anyway.
7820
36372bf9
PE
7821 * alloc.c: Remove unportable assumptions about struct layout.
7822 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7823 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7824 (allocate_vectorlike, make_pure_vector): Use the new macros,
7825 plus offsetof, to remove unportable assumptions about struct layout.
7826 These assumptions hold on all porting targets that I know of, but
7827 they are not guaranteed, they're easy to remove, and removing them
7828 makes further changes easier.
7829
0b432f21
PE
7830 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7831 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7832 (string_overrun_cookie): Now const. Use initializers that
7833 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7834 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7835 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7836 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7837 multiple of sizeof (EMACS_INT); it need not be, if
7838 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7839 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7840
895009e1
JB
78412011-04-26 Juanma Barranquero <lekktu@gmail.com>
7842
7843 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7844
6a7a1b0b
TZ
78452011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7846
7847 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7848 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7849 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7850
841a1577 78512011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7852
7853 * lisp.h (Qdebug): List symbol.
895009e1 7854 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7855 * keyboard.c (debug-on-event): New variable.
7856 (handle_user_signal): Break into debugger when debug-on-event
7857 matches the current signal symbol.
7858
f2d3ba6f
DN
78592011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7860
7861 * alloc.c (check_sblock, check_string_bytes)
7862 (check_string_free_list): Convert to standard C.
7863
42ce4c63
TZ
78642011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7865
7866 * w32.c (emacs_gnutls_push): Fix typo.
7867
825cd63c
EZ
78682011-04-25 Eli Zaretskii <eliz@gnu.org>
7869
fb11d64d
EZ
7870 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7871 "cast to pointer from integer of different size".
7872
825cd63c
EZ
7873 Improve doprnt and its use in verror. (Bug#8545)
7874 * doprnt.c (doprnt): Document the set of format control sequences
7875 supported by the function. Use SAFE_ALLOCA instead of always
7876 using `alloca'.
7877
7878 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7879 is one byte too soon. Don't use xrealloc; instead xfree and
7880 xmalloc anew.
7881
e061a11b
TZ
78822011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7883
7884 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7885 callbacks stage.
7886
7887 * gnutls.c: Renamed global_initialized to
7888 gnutls_global_initialized. Added internals for the
7889 :verify-hostname-error, :verify-error, and :verify-flags
7890 parameters of `gnutls-boot' and documented those parameters in the
7891 docstring. Start callback support.
9173deec
JB
7892 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7893 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7894 on error. Return error code.
e061a11b
TZ
7895 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7896 (emacs_gnutls_read): Likewise.
7897 (Fgnutls_boot): Return handshake error code.
7898 (emacs_gnutls_handle_error): New function.
7899 (wsaerror_to_errno): Likewise.
7900
7901 * w32.h (emacs_gnutls_pull): Add prototype.
7902 (emacs_gnutls_push): Likewise.
7903
7904 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7905 (emacs_gnutls_push): Likewise.
7906
79072011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7908
7909 * process.c (wait_reading_process_output): Check if GnuTLS
7910 buffered some data internally if no FDs are set for TLS
7911 connections.
7912
7913 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7914 (LIBS): Link to USER_LIBS.
7915 ($(BLD)/gnutls.$(0)): New target.
7916
fa6996bc
EZ
79172011-04-24 Eli Zaretskii <eliz@gnu.org>
7918
eb35682e
EZ
7919 * xdisp.c (handle_single_display_spec): Rename the
7920 display_replaced_before_p argument into display_replaced_p, to
7921 make it consistent with the commentary. Fix typos in the
7922 commentary.
7923
e2ad650c
EZ
7924 * textprop.c (syms_of_textprop): Remove dead code.
7925 (copy_text_properties): Delete obsolete commentary about an
7926 interface that was deleted long ago. Fix typos in the description
7927 of arguments.
7928
1b2de274
EZ
7929 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7930 to changes in oldXMenu/XMenu.h from 2011-04-16.
7931 <menu_help_message, prev_menu_help_message>: Constify.
7932 (IT_menu_make_room): menu->help_text is now `const char **';
7933 adjust.
7934
7935 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7936 to changes in oldXMenu/XMenu.h from 2011-04-16.
7937 (struct XMenu): Declare `help_text' `const char **'.
7938
7939 * xfaces.c <Qunspecified>: Make extern again.
7940
7941 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7942 required by POSIX.
1b2de274 7943
762b15be
EZ
7944 * doc.c (get_doc_string): Improve the format passed to `error'.
7945
7946 * doprnt.c (doprnt): Improve commentary.
7947
7948 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7949
7950 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7951 them with etags.
7952
f1052e5d
EZ
7953 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7954 changes in globals.h immediately force recompilation.
762b15be
EZ
7955 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7956 $(CURDIR)/s/ms-w32.h.
7957 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7958
fa6996bc
EZ
7959 * character.c (Fchar_direction): Function deleted.
7960 (syms_of_character): Don't defsubr it.
7961 <char-direction-table>: Deleted.
7962
e6c3da20
EZ
79632011-04-23 Eli Zaretskii <eliz@gnu.org>
7964
7965 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7966 * doprnt.c: Include limits.h.
7967 (SIZE_MAX): New macro.
04f2d78b
CB
7968 (doprnt): Return a size_t value. 2nd arg is now size_t.
7969 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7970 Improve overflow protection. Support `l' modifier for integer
7971 conversions. Support %l conversion. Don't assume an EMACS_INT
7972 argument for integer conversions and for %c.
7973
7974 * lisp.h (doprnt): Restore prototype.
7975
7976 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7977 $(SRC)/character.h.
7978
7979 * Makefile.in (base_obj): Add back doprnt.o.
7980
7981 * deps.mk (doprnt.o): Add back prerequisites.
7982 (callint.o): Depend on character.h.
7983
7984 * eval.c (internal_lisp_condition_case): Include the handler
7985 representation in the error message.
7986 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7987 when breaking from the loop.
7988
7989 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7990
7991 * callint.c (Fcall_interactively): When displaying error message
7992 about invalid control letter, pass the character's codepoint, not
7993 a pointer to its multibyte form. Improve display of the character
7994 in octal and display also its hex code.
7995
7996 * character.c (char_string): Use %x to display the (unsigned)
7997 codepoint of an invalid character, to avoid displaying a bogus
7998 negative value.
7999
8000 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
8001 `error', not SYMBOL_NAME itself.
8002
8003 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
8004 character arguments to `error'.
8005
8006 * charset.c (check_iso_charset_parameter): Fix incorrect argument
8007 to `error' in error message about FINAL_CHAR argument. Make sure
8008 FINAL_CHAR is a character, and use %c when it is passed as
8009 argument to `error'.
8010
4ffd0d6b 80112011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
8012
8013 * s/ms-w32.h (localtime): Redirect to sys_localtime.
8014
8015 * w32.c: Include <time.h>.
8016 (sys_localtime): New function.
8017
4ffd0d6b 80182011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
8019
8020 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8021
4ffd0d6b 8022 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 8023
4ffd0d6b 80242011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 8025
4ffd0d6b
GM
8026 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8027 zombies (Bug#8467).
aac0c6e3 8028
04c56954
EZ
80292011-04-19 Eli Zaretskii <eliz@gnu.org>
8030
8031 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8032 gl_state.e_property when gl_state.object is Qt.
8033
8034 * insdel.c (make_gap_larger): Remove limitation of buffer size
8035 to <= INT_MAX.
8036
16a43933
CY
80372011-04-18 Chong Yidong <cyd@stupidchicken.com>
8038
8039 * xdisp.c (lookup_glyphless_char_display)
8040 (produce_glyphless_glyph): Handle cons cell entry in
8041 glyphless-char-display.
8042 (Vglyphless_char_display): Document it.
8043
8044 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8045 glyphless-char-display.
8046
4581706e
CY
80472011-04-17 Chong Yidong <cyd@stupidchicken.com>
8048
8049 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8050
8051 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8052
8053 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8054 definition for no-X builds.
8055
4887c6e2 80562011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 8057
fd35b6f9
PE
8058 Static checks with GCC 4.6.0 and non-default toolkits.
8059
5c1ccb01
PE
8060 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
8061
006c5daa
PE
8062 * process.c (keyboard_bit_set): Define only if SIGIO.
8063 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
8064 (send_process): Repair possible setjmp clobbering.
8065
efc736d3
PE
8066 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
8067
4e2fe2e6
PE
8068 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
8069
f97334a2
PE
8070 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8071
4e75f29d
PE
8072 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8073 Define only if needed.
8074
90efadd1
PE
8075 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8076 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 8077 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 8078
3c647824
PE
8079 * dispextern.h (struct redisplay_interface): Rename param
8080 to avoid shadowing.
e264f262 8081 * termhooks.h (struct terminal): Likewise.
761383f4 8082 * xterm.c (xembed_send_message): Likewise.
3c647824 8083
b58c5c4a
PE
8084 * insdel.c (make_gap_smaller): Define only if
8085 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8086
cad59032
PE
8087 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8088 it.
8089
c339dc2e
PE
8090 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8091 so that we aren't warned about unused symbols.
8092
91a3e27b
PE
8093 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8094
399c71d3 8095 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 8096
8ffc96f5
PE
8097 * xfns.c (x_real_positions): Mark locals as initialized.
8098
eef9bc79
PE
8099 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8100
098db9dd
PE
8101 * xterm.c: Fix problems found by static analysis with other toolkits.
8102 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
8103 (x_dispatch_event): Declare static if USE_GTK, and
8104 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 8105 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 8106 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
8107 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8108 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 8109
eb18f6cc
PE
8110 * xmenu.c (menu_help_callback): Pointer type fixes.
8111 Use const pointers when pointing at readonly data. Avoid pointer
8112 signedness clashes.
8113 (FALSE): Remove unused macro.
8114 (update_frame_menubar): Remove unused decl.
8115
1fe72bf8
PE
8116 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8117
60d9e1db
PE
8118 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8119 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8120 (single_menu_item): Rename local to avoid shadowing.
8121
39261c26
PE
8122 * keyboard.c (make_lispy_event): Remove unused local var.
8123
018c5e19
PE
8124 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8125 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8126
63d2b86e
PE
8127 * bitmaps: Change bitmaps from unsigned char back to the X11
8128 compatible char. Avoid the old compiler warnings about
8129 out-of-range initializers by using, for example, '\xab' rather
8130 than 0xab.
8131
aefd87e1
PE
8132 * xgselect.c (xgselect_initialize): Check vs interface
8133 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8134
bf501fb9
PE
8135 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8136
e9829fdf
PE
8137 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
8138 to read-only memory.
8139
1086c095
PE
8140 * fns.c (vector): Remove; this old hack is no longer needed.
8141
2baccd04 8142 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 8143 Remove unused var.
dde42981 8144 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 8145
72391843 8146 * xrdb.c (x_load_resources): Omit unused local.
3565b346 8147
436c16df 8148 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 8149 (x_window): Rename locals to avoid shadowing.
dc5ddd85 8150 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 8151
92bb796d 8152 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 8153 (x_term_init): Remove local to avoid shadowing.
92bb796d 8154
764430a3 8155 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
8156
8157 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8158 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8159
d1dfb56c
EZ
81602011-04-16 Eli Zaretskii <eliz@gnu.org>
8161
c4354cb4
EZ
8162 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8163
d1dfb56c
EZ
8164 Fix regex.c, syntax.c and friends for buffers > 2GB.
8165 * syntax.h (struct gl_state_s): Declare character position members
8166 EMACS_INT.
8167
8168 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8169
04f2d78b
CB
8170 * textprop.c (verify_interval_modification, interval_of):
8171 Declare arguments EMACS_INT.
d1dfb56c
EZ
8172
8173 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8174 EMACS_INT.
8175
8176 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8177
8178 * indent.c (Fvertical_motion): Local variable it_start is now
8179 EMACS_INT.
8180
8181 * regex.c (re_match, re_match_2, re_match_2_internal)
8182 (bcmp_translate, regcomp, regexec, print_double_string)
8183 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8184 (re_compile_pattern, re_exec): Declare arguments and local
8185 variables `size_t' and `ssize_t' and return values `regoff_t', as
8186 appropriate.
8187 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8188 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8189 <compile_stack_type>: `size' and `avail' are now `size_t'.
8190
8191 * regex.h <regoff_t>: Use ssize_t, not int.
8192 (re_search, re_search_2, re_match, re_match_2): Arguments that
8193 specify buffer/string position and length are now ssize_t and
8194 size_t. Return type is regoff_t.
8195
613052cd
BK
81962011-04-16 Ben Key <bkey76@gmail.com>
8197
8198 * nsfont.m: Fixed bugs in ns_get_family and
8199 ns_descriptor_to_entity that were caused by using free to
8200 deallocate memory blocks that were allocated by xmalloc (via
8201 xstrdup). This caused Emacs to crash when compiled with
8202 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8203 --enable-checking=xmallocoverrun). xfree is now used to
8204 deallocate these memory blocks.
8205
4170f62f 82062011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 8207
71b41406
PE
8208 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8209
9587a89d
PE
8210 emacs_write: Accept and return EMACS_INT for sizes.
8211 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8212 et seq.
8213 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8214 Accept and return EMACS_INT.
8215 (emacs_gnutls_write): Return the number of bytes written on
8216 partial writes.
8217 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
8218 (emacs_read, emacs_write): Remove check for negative size, as the
8219 Emacs source code has been audited now.
9587a89d
PE
8220 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8221 (emacs_read, emacs_write): Use it.
273a5f82
PE
8222 * process.c (send_process): Adjust to the new signatures of
8223 emacs_write and emacs_gnutls_write. Do not attempt to store
8224 a byte offset into an 'int'; it might overflow.
9587a89d 8225 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 8226
3e047f51
PE
8227 * sound.c: Don't assume sizes fit in 'int'.
8228 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 8229 Return EMACS_INT, not int.
3e047f51 8230 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
8231 Accept EMACS_INT, not int.
8232 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
8233 record read return values.
8234
cc39a9db
BK
82352011-04-15 Ben Key <bkey76@gmail.com>
8236
c9d0ec6d
JB
8237 * keyboard.c (Qundefined): Don't declare static since it is used
8238 in nsfns.m.
8239 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8240 static since they are used in nsfont.m.
cc39a9db 8241
6c60eb9f
SM
82422011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8243
8244 * process.c (Qprocessp): Don't declare static.
8245 * lisp.h (Qprocessp): Declare again.
8246
7990b61a
JB
82472011-04-15 Juanma Barranquero <lekktu@gmail.com>
8248
8249 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8250
5d4cb038
PE
82512011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8252
8bd7b830 8253 Improve C-level modularity by making more things 'static'.
cd64ea1d 8254
e3b27b31
PE
8255 Don't publish debugger-only interfaces to other modules.
8256 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8257 (verify_bytepos, count_markers): Move decls to the only modules
8258 that need them.
8259 * region-cache.h (pp_cache): Likewise.
8260 * window.h (check_all_windows): Likewise.
8261 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8262
5d4cb038
PE
8263 * sysdep.c (croak): Now static, if
8264 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8265 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
8266
8267 * alloc.c (refill_memory_reserve): Now static if
8268 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8269 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 8270
e87b6180
PE
8271 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8272 Define only if USE_LUCID.
8273
ac64929e
PE
8274 * xrdb.c (x_customization_string, x_rm_string): Now static.
8275
6f37259d
PE
8276 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8277 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8278
1683e3ab
PE
8279 * xdisp.c (draw_row_with_mouse_face): Now static.
8280 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8281
de9c2632
PE
8282 * window.h (check_all_windows): Mark externally visible.
8283
2b96acb7
PE
8284 * window.c (window_deletion_count): Now static.
8285
8286 * undo.c: Make symbols static if they're not exported.
8287 (last_undo_buffer, last_boundary_position, pending_boundary):
8288 Now static.
8289
50436f33
PE
8290 * textprop.c (interval_insert_behind_hooks): Now static.
8291 (interval_insert_in_front_hooks): Likewise.
8292
64520e5c
PE
8293 * term.c: Make symbols static if they're not exported.
8294 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8295 (max_frame_lines, tty_set_terminal_modes):
8296 (tty_reset_terminal_modes, tty_turn_off_highlight):
8297 (get_tty_terminal): Now static.
8298 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8299 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 8300 HAVE_WINDOW_SYSTEM.
64520e5c
PE
8301 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8302 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8303
1fa53021
PE
8304 * sysdep.c: Make symbols static if they're not exported.
8305 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8306 Now static.
8307 (sigprocmask_set, full_mask): Remove; unused.
8308 (wait_debugging): Mark as visible.
8309 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8310 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8311
d4b43b22
PE
8312 * syntax.c (syntax_temp): Define only if !__GNUC__.
8313
b7c513d0
PE
8314 * sound.c (current_sound_device, current_sound): Now static.
8315
989b29ad
PE
8316 * search.c (searchbufs, searchbuf_head): Now static.
8317
13a55a78
PE
8318 * scroll.c (scroll_cost): Remove; unused.
8319 * dispextern.h (scroll_cost): Remove decl.
8320
de68a1fc
PE
8321 * region-cache.h (pp_cache): Mark as externally visible.
8322
40ccffa6
PE
8323 * process.c: Make symbols static if they're not exported.
8324 (process_tick, update_tick, create_process, chan_process):
8325 (Vprocess_alist, proc_buffered_char, datagram_access):
8326 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8327 (deactivate_process): Mark defn as static, as well as decl.
8328 * lisp.h (create_process): Remove decl.
8329 * process.h (chan_process, Vprocess_alist): Remove decls.
8330
ad64fc97
PE
8331 * print.c: Make symbols static if they're not exported.
8332 (print_depth, new_backquote_output, being_printed, print_buffer):
8333 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8334 (print_interval, print_number_index, initial_stderr_stream):
8335 Now static.
8336 * lisp.h (Fprinc): Remove decl.
8337 (debug_output_compilation_hack): Mark as externally visible.
8338
adddb265
PE
8339 * sysdep.c (croak): Move decl from here to syssignal.h.
8340 * syssignal.h (croak): Put it here, so the API can be checked when
8341 'croak' is called from dissociate_if_controlling_tty.
8342
1717ede2
PE
8343 * minibuf.c: Make symbols static if they're not exported.
8344 (minibuf_save_list, choose_minibuf_frame): Now static.
8345 * lisp.h (choose_minibuf_frame): Remove decl.
8346
fa5fb2bc
PE
8347 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8348
1e3890d1
PE
8349 * lread.c: Make symbols static if they're not exported.
8350 (read_objects, initial_obarray, oblookup_last_bucket_number):
8351 Now static.
8352 (make_symbol): Remove; unused.
8353 * lisp.h (initial_obarray, make_symbol): Remove decls.
8354
8a1414fa
PE
8355 * keyboard.c: Make symbols static if they're not exported.
8356 (single_kboard, recent_keys_index, total_keys, recent_keys):
8357 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8358 (this_single_command_key_start, echoing, last_auto_save):
8359 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8360 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8361 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8362 (Vlispy_mouse_stem, double_click_count):
8363 Now static.
8364 (force_auto_save_soon): Define only if SIGDANGER.
8365 (ignore_mouse_drag_p): Now static if
8366 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8367 (print_help): Remove; unused.
8368 (stop_character, last_timer_event): Mark as externally visible.
8369 * keyboard.h (ignore_mouse_drag_p): Declare only if
8370 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8371 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8372 * lisp.h (echoing): Remove decl.
8373 (force_auto_save_soon): Declare only if SIGDANGER.
8374 * xdisp.c (redisplay_window): Simplify code, to make it more
8375 obvious that ignore_mouse_drag_p is not accessed if !defined
8376 USE_GTK && !defined HAVE_NS.
8377
93ea6e8f
PE
8378 * intervals.c: Make symbols static if they're not exported.
8379 (merge_properties_sticky, merge_interval_right, delete_interval):
8380 Now static.
8381 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8382
77382fcc
PE
8383 * insdel.c: Make symbols static if they're not exported.
8384 However, leave prepare_to_modify_buffer alone. It's never
8385 called from outside this function, but that appears to be a bug.
8386 (combine_after_change_list, combine_after_change_buffer):
4889fc82 8387 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
8388 (adjust_after_replace_noundo): Remove; unused.
8389 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 8390 (signal_before_change): Remove decls.
77382fcc 8391
9306c32e
PE
8392 * indent.c (val_compute_motion, val_vmotion): Now static.
8393
cd44d2eb
PE
8394 * image.c: Make symbols static if they're not exported.
8395 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8396 if USE_GTK.
8397 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8398 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8399
ad9a7a06
PE
8400 * fringe.c (standard_bitmaps): Now static.
8401 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8402
81626931
PE
8403 * frame.c: Make symbols static if they're not exported.
8404 (x_report_frame_params, make_terminal_frame): Now static.
8405 (get_frame_param): Now static, unless HAVE_NS.
8406 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8407 (x_get_resource_string): Remove; not used.
8408 * frame.h (make_terminal_frame, x_report_frame_params):
8409 (x_get_resource_string); Remove decls.
8410 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8411 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8412
239f9db9
PE
8413 * font.c, fontset.c: Make symbols static if they're not exported.
8414 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8415 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8416 * font.c (font_close_object): Now static.
8417 * font.h (font_close_object): Remove.
8418 * fontset.c (FONTSET_OBJLIST): Remove.
8419 (free_realized_fontset) #if-0 the body, which does nothing.
8420 (face_suitable_for_char_p): #if-0, as it's never called.
8421 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
8422 * xfaces.c (face_at_string_position):
8423 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
8424 since 0 is always ASCII.
8425
dfcf3579
PE
8426 * fns.c (weak_hash_tables): Now static.
8427
5045092b
PE
8428 * fileio.c: Make symbols static if they're not exported.
8429 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8430 (Vwrite_region_annotation_buffers): Now static.
8431
57a96f5c
PE
8432 * eval.c: Make symbols static if they're not exported.
8433 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8434 * lisp.h (backtrace_list): Remove decl.
8435
35f08c38
PE
8436 * emacs.c: Make symbols static if they're not exported.
8437 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8438 (fatal_error_code, fatal_error_signal_hook, standard_args):
8439 Now static.
8440 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8441 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8442 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8443 * lisp.h (fatal_error_signal_hook): Remove decl.
8444 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8445
f44bd759
PE
8446 * editfns.c: Move a (normally-unused) function to its only use.
8447 * editfns.c, lisp.h (get_operating_system_release): Remove.
8448 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8449 worth the hassle of breaking this out.
8450
b532497d
PE
8451 * xterm.c: Make symbols static if they're not exported.
8452 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8453 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8454 (x_destroy_window, x_delete_display):
8455 Now static.
8456 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8457 (x_mouse_leave): Remove; unused.
8458 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8459 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8460 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8461 Remove decls.
8462 (x_mouse_leave): Declare only if WINDOWSNT.
8463 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8464 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8465 USE_X_TOOLKIT.
8466
1675728f
PE
8467 * ftxfont.c: Make symbols static if they're not exported.
8468 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8469 HAVE_FREETYPE.
8470 * font.h (ftxfont_driver): Likewise.
8471
e4cebfca
PE
8472 * xfns.c: Make symbols static if they're not exported.
8473 (x_last_font_name, x_display_info_for_name):
8474 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8475 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8476 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8477 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8478 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8479 (last_show_tip_args): Now static.
8480 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8481 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8482 (x_screen_planes): Remove; unused.
8483 * dispextern.h (x_screen_planes): Remove decl.
8484
5bf46f05
PE
8485 * dispnew.c: Make symbols static if they're not exported.
8486 * dispextern.h (redraw_garbaged_frames, scrolling):
8487 (increment_row_positions): Remove.
8488 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8489 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8490 Now static.
8491 (redraw_garbaged_frames): Remove; unused.
8492
435f4c28
PE
8493 * xfaces.c: Make symbols static if they're not exported.
8494 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8495 Remove decls.
8496 * xterm.h (defined_color): Remove decls.
8497 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8498 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8499 (menu_face_changed_default, defined_color, free_realized_face):
8500 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8501 (ascii_face_of_lisp_face): Remove; unused.
8502
8524aef3
PE
8503 * xdisp.c: Make symbols static if they're not exported.
8504 * dispextern.h (scratch_glyph_row, window_box_edges):
8505 (glyph_to_pixel_coords, set_cursor_from_row):
8506 (get_next_display_element, set_iterator_to_next):
8507 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8508 (show_mouse_face): Remove decls
8509 * frame.h (message_buf_print): Likewise.
8510 * lisp.h (pop_message, set_message, check_point_in_composition):
8511 Likewise.
8512 * xterm.h (set_vertical_scroll_bar): Likewise.
8513 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8514 (message_buf_print, scratch_glyph_row, displayed_buffer):
8515 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8516 (get_next_display_element, show_mouse_face, window_box_edges):
8517 (frame_to_window_pixel_xy, check_point_in_composition):
8518 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8519 (glyph_to_pixel_coords): Remove; unused.
8520
16390cd2
PE
8521 * dired.c (file_name_completion): Now static.
8522
8523 * dbusbind.c (xd_in_read_queued_messages): Now static.
8524
a25f4dfa
PE
8525 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8526 * data.c (circular_list_error): Remove.
8527
14a9c8df
PE
8528 * commands.h (last_point_position, last_point_position_buffer):
8529 (last_point_position_window): Remove decls.
8530 * keyboard.c: Make these variables static.
8531
04f2d78b
CB
8532 * coding.h (coding, code_convert_region, encode_coding_gap):
8533 Remove decls.
74ab6df5
PE
8534 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8535 (iso_code_class, detect_coding, code_convert_region): Now static.
8536 (encode_coding_gap): Remove; unused.
8537
38dfbee1
PE
8538 * chartab.c (chartab_chars, chartab_bits): Now static.
8539
a2cb4e63
PE
8540 * charset.h (charset_iso_8859_1): Remove decl.
8541 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8542 Now static.
8543
127198fd
PE
8544 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8545 * ccl.c (Vccl_program_table): Now static.
8546 (check_ccl_update): Remove; unused.
8547
d85b608f
PE
8548 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8549 * category.h: ... from here.
8550 * category.c (check_category_table, set_category_set): Now static.
8551
31cd66f3
PE
8552 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8553 * lisp.h: Remove these decls.
8554
c358e587
PE
8555 * buffer.c (buffer_count): Remove unused var.
8556
e78aecca
PE
8557 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8558 so that it's not optimized away.
8559 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8560 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8561 exported only to the debugger.
8562
e192d7d3 8563 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8564 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8565
92470028
PE
8566 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8567 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8568 was inaccessible from Lisp.
8569 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8570 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8571
244ed907
PE
8572 alloc.c: Import and export fewer symbols, and remove unused items.
8573 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8574 is defined.
8575 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8576 it's not optimized away by whole-program optimization.
8577 (message_enable_multibyte, free_misc): Remove.
8578 (catchlist, handlerlist, mark_backtrace):
8579 Declare only if BYTE_MARK_STACK.
8580 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8581 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8582 (message_enable_multibyte): Remove decl.
8583 (free_misc, interval_free_list, float_block, float_block_index):
8584 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8585 (cons_free_list, last_marked_index):
8586 Now static.
8587 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8588 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8589 (mark_backtrace): Define only if BYTE_MARK_STACK.
8590 * xdisp.c (message_enable_multibyte): Now static.
8591
61c2b50e 8592 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8593 This makes it easier for human readers (and static analyzers)
8594 to see whether these variables are used from other modules.
8595 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8596 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8597 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8598 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8599 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8600 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8601 * xmenu.c, xselect.c:
8602 Declare Q* vars static if they are not used in other modules.
8603 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8604 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8605 Remove decls of unexported vars.
8606 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8607
95c82688
PE
8608 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8609
16a97296
PE
8610 Make Emacs functions such as Fatom 'static' by default.
8611 This makes it easier for human readers (and static analyzers)
8612 to see whether these functions can be called from other modules.
8613 DEFUN now defines a static function. To make the function external
8614 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8615 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8616 (Finit_image_library):
16a97296
PE
8617 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8618 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8619 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8620 Remove decls, since these functions are now static.
8621 (Funintern, Fget_internal_run_time): New decls, since these functions
8622 were already external.
95c82688 8623
16a97296
PE
8624 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8625 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8626 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8627 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8628 * keyboard.c, keymap.c, lread.c:
8629 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8630 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8631 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8632 Mark functions with DEFUE instead of DEFUN,
8633 if they are used in other modules.
8634 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8635 decls for now-static functions.
8636 * buffer.h (Fdelete_overlay): Remove decl.
8637 * callproc.c (Fgetenv_internal): Mark as internal.
8638 * composite.c (Fremove_list_of_text_properties): Remove decl.
8639 (Fcomposition_get_gstring): New forward static decl.
8640 * composite.h (Fcomposite_get_gstring): Remove decl.
8641 * dired.c (Ffile_attributes): New forward static decl.
8642 * doc.c (Fdocumntation_property): New forward static decl.
8643 * eval.c (Ffetch_bytecode): New forward static decl.
8644 (Funintern): Remove extern decl; now in .h file where it belongs.
8645 * fileio.c (Fmake_symbolic_link): New forward static decl.
8646 * image.c (Finit_image_library): New forward static decl.
8647 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8648 * intervals.h (Fprevious_property_change):
8649 (Fremove_list_of_text_properties): Remove decls.
8650 * keyboard.c (Fthis_command_keys): Remove decl.
8651 (Fcommand_execute): New forward static decl.
8652 * keymap.c (Flookup_key): New forward static decl.
8653 (Fcopy_keymap): Now static.
8654 * keymap.h (Flookup_key): Remove decl.
8655 * process.c (Fget_process): New forward static decl.
8656 (Fprocess_datagram_address): Mark as internal.
8657 * syntax.c (Fsyntax_table_p): New forward static decl.
8658 (skip_chars): Remove duplicate decl.
8659 * textprop.c (Fprevious_property_change): New forward static decl.
8660 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8661 Now internal.
8662 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8663 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8664
785bbd42
PE
8665 * editfns.c (Fformat): Remove unreachable code.
8666
8b913b57
AS
86672011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8668
8669 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8670 change. (Bug#8496)
8671
a6744a35
EZ
86722011-04-13 Eli Zaretskii <eliz@gnu.org>
8673
8674 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8675 when at ZV. (Bug#8487)
8676
e7974947
AS
86772011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8678
baad03f0
AS
8679 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8680 (Bug#8437)
8681 * keyboard.c (parse_tool_bar_item): Likewise.
8682 * sound.c (sound_cleanup, alsa_close): Likewise.
8683 * termcap.c (tgetent): Likewise.
8684 * xfns.c (x_default_font_parameter): Likewise.
8685 * xsettings.c (read_and_apply_settings): Likewise.
8686
e7974947
AS
8687 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8688 (overrun_check_free): Protoize.
8689
28272684
PE
86902011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8691
8692 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8693 since callers should never pass a negative size.
8694 Change the signature to match that of plain 'read' and 'write'; see
8695 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8696 * lisp.h: Update prototypes of emacs_write and emacs_read.
8697
11997c76
EZ
86982011-04-11 Eli Zaretskii <eliz@gnu.org>
8699
8700 * xdisp.c (redisplay_window): Don't try to determine the character
8701 position of the scroll margin if the window start point w->startp
e896f03c 8702 is outside the buffer's accessible region. (Bug#8468)
11997c76 8703
8a2cbd72
EZ
87042011-04-10 Eli Zaretskii <eliz@gnu.org>
8705
8706 Fix write-region and its subroutines for buffers > 2GB.
8707 * fileio.c (a_write, e_write): Modify declaration of arguments and
8708 local variables to support buffers larger than 2GB.
8709 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8710
8711 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8712 argument, local variables, and return value.
8713
8714 * lisp.h: Update prototypes of emacs_write and emacs_read.
8715
8716 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8717
4073e537 87182011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8719
1ebfdcb6
PE
8720 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8721
b2ded58d
PE
8722 Fix more problems found by GCC 4.6.0's static checks.
8723
7d66342c
PE
8724 * xdisp.c (vmessage): Use a better test for character truncation.
8725
bbf47d44
PE
8726 * charset.c (load_charset_map): <, not <=, for optimization,
8727 and to avoid potential problems with integer overflow.
9248994d 8728 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8729 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8730 * editfns.c (Fformat): Likewise.
1e69125e 8731 * syntax.c (skip_chars): Likewise.
3befa583 8732
e3019616
PE
8733 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8734 This also lets GCC 4.6.0 generate slightly better loop code.
8735
becfa255
PE
8736 * callint.c (Fcall_interactively): <, not <=, for optimization.
8737 (Fcall_interactively): Count the number of arguments produced,
8738 not the number of arguments given. This is simpler and lets GCC
8739 4.6.0 generate slightly better code.
8740
dae0cd48
PE
8741 * ftfont.c: Distingish more carefully between FcChar8 and char.
8742 The previous code passed unsigned char * to a functions like
8743 strlen and xstrcasecmp that expect char *, which does not
8744 conform to the C standard.
8745 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8746 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8747 char * when the C standard requires it.
8748
76032d70
PE
8749 * keyboard.c (read_char): Remove unused var.
8750
eb3f1cc8
PE
8751 * eval.c: Port to Windows vsnprintf (Bug#8435).
8752 Include <limits.h>.
8753 (SIZE_MAX): Define if the headers do not.
8754 (verror): Do not give up if vsnprintf returns a negative count.
8755 Instead, grow the buffer. This ports to Windows vsnprintf, which
8756 does not conform to C99. Problem reported by Eli Zaretskii.
8757 Also, simplify the allocation scheme, by avoiding the need for
8758 calling realloc, and removing the ALLOCATED variable.
8759
70476b54
PE
8760 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8761
12020a9e
PE
8762 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8763 But keep the doprint source code for now, as we might revamp it
8764 and use it again (Bug#8435).
ea6c7ae6
PE
8765 * lisp.h (doprnt): Remove.
8766 * Makefile.in (base_obj): Remove doprnt.o.
8767 * deps.mk (doprnt.o): Remove.
8768
5fdb398c
PE
8769 error: Print 32- and 64-bit integers portably (Bug#8435).
8770 Without this change, on typical 64-bit hosts error ("...%d...", N)
8771 was used to print both 32- and 64-bit integers N, which relied on
8772 undefined behavior.
61bdb816 8773 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8774 * lisp.h (error, verror): Mark as printf-like functions.
8775 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8776 Report overflow in size calculations when allocating printf buffer.
8777 Do not truncate output string at its first null byte.
8778 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8779 Truncate the output at a character boundary, since vsnprintf does not
8780 do that.
8781 * charset.c (check_iso_charset_parameter): Convert internal
8782 character to string before calling 'error', since %c now has the
8783 printf meaning.
8784 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8785 overflow when computing char to be passed to 'error'. Do not
8786 pass Lisp_Object to 'error'; pass the integer instead.
8787 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8788 formatted with plain %d.
8789
b189fa66
PE
8790 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8791
bff87ef0
PE
8792 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8793
7e2cac20
PE
8794 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8795
ce4d90b5
PE
8796 * xterm.c (x_catch_errors): Remove duplicate declaration.
8797
266c9547
PE
8798 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8799
79c49ad2
PE
8800 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8801
368f4090
JM
88022011-04-10 Jim Meyering <meyering@redhat.com>
8803
8804 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8805 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8806 return ssize_t not "int", and use size_t as the buffer length.
8807 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8808 * gnutls.h: Update declarations.
8809 * process.c (read_process_output): Use ssize_t, to match.
8810 (send_process): Likewise.
8811
a32d4040
CY
88122011-04-09 Chong Yidong <cyd@stupidchicken.com>
8813
8814 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8815
8546720e 88162011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8817
04f2d78b
CB
8818 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8819 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8820
8546720e
GM
8821 * xterm.c (handle_one_xevent):
8822 * xmenu.c (create_and_show_popup_menu):
8823 * xselect.c (x_decline_selection_request)
8824 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8825
0a2f5c1a 88262011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8827
8828 Fix some uses of `int' instead of EMACS_INT.
8829 * search.c (string_match_1, fast_string_match)
8830 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8831 (scan_buffer, find_next_newline_no_quit)
8832 (find_before_next_newline, search_command, Freplace_match)
8833 (Fmatch_data): Make some `int' variables be EMACS_INT.
8834
8835 * xdisp.c (display_count_lines): 3rd argument and return value now
8836 EMACS_INT. All callers changed.
8837 (pint2hrstr): Last argument is now EMACS_INT.
8838
8839 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8840 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8841 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8842 (decode_coding_utf_16, decode_coding_emacs_mule)
8843 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8844 (decode_coding_ccl, decode_coding_charset)
8845 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8846 (decode_coding_iso_2022, decode_coding_emacs_mule)
8847 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8848 <char_offset, last_offset>: Declare EMACS_INT.
8849 (encode_coding_utf_8, encode_coding_utf_16)
8850 (encode_coding_emacs_mule, encode_invocation_designation)
8851 (encode_designation_at_bol, encode_coding_iso_2022)
8852 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8853 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8854 Declare EMACS_INT.
8855 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8856 (encode_invocation_designation): Last argument P_NCHARS is now
8857 EMACS_INT.
8858 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8859 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8860
8861 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8862 All users changed.
8863
8864 * ccl.c (Fccl_execute_on_string): Declare some variables
8865 EMACS_INT.
8866
8546720e 88672011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8868
8869 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8870
4e19a977
CS
88712011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8872
8873 * process.c (Fformat_network_address): Doc fix.
8874
87302331
R
88752011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8876
ee7683eb 8877 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8878
cbb59342
CY
88792011-04-08 Chong Yidong <cyd@stupidchicken.com>
8880
8881 * keyboard.c (read_char): Call Lisp function help-form-show,
8882 instead of using internal_with_output_to_temp_buffer.
8883 (Qhelp_form_show): New var.
e0d38eeb 8884 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8885
8886 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8887
8888 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8889
e67a13ab
CY
88902011-04-06 Chong Yidong <cyd@stupidchicken.com>
8891
04f2d78b
CB
8892 * process.c (Flist_processes): Remove to Lisp.
8893 (list_processes_1): Delete.
e67a13ab 8894
973f782d
EZ
88952011-04-06 Eli Zaretskii <eliz@gnu.org>
8896
7c106b1e
EZ
8897 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8898
973f782d
EZ
8899 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8900
41cf7d1a 89012011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8902
ca23cc88
PE
8903 Fix more problems found by GCC 4.6.0's static checks.
8904
f390e2d5
PE
8905 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8906
42eea0d0
PE
8907 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8908
b69769da 8909 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8910
f9541e84
PE
8911 * xdisp.c (vmessage): Mark as a printf-like function.
8912
13841b55
PE
8913 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8914
c136c10f
PE
8915 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8916
5e2d4a30
PE
8917 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8918 printf-like functions.
8919 (tiff_load): Add casts to remove these marks before passing them
8920 to system-supplied API.
8921
583f48b9
PE
8922 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8923
b25d760e
PE
8924 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8925 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8926 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8927 directly, rather than having caller test rule sign. This avoids
8928 some unnecessary tests.
8929 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8930 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8931 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8932
bc7b6697 8933 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8934 (xfont_open): Avoid unnecessary tests.
bc7b6697 8935
27ccc379
PE
8936 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8937
dcd5c89a
PE
8938 * composite.h, composite.c (composition_gstring_put_cache):
8939 Use EMACS_INT, not int, for length.
8940
b13a45c6
PE
8941 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8942 breaking out part of COMPOSITION_DECODE_RULE.
8943 (COMPOSITION_DECODE_RULE): Use it.
8944 * composite.c (get_composition_id): Remove unused local vars,
8945 by using the new macro.
8946
1e792e4d
PE
8947 * textprop.c (set_text_properties_1): Change while to do-while,
8948 since the condition is always true at first.
8949
dc6c6455 8950 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8951 (interval_deletion_adjustment): Return unsigned value.
8952 All uses changed.
dc6c6455 8953
aba7731a
PE
8954 * process.c (list_processes_1, create_pty, read_process_output):
8955 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8956 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8957 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8958 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8959 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8960
fdfc4bf3
PE
8961 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8962
fca8fe46 8963 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8964 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8965
06a0259a 8966 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8967 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8968 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8969
e7b9e80f
PE
8970 * print.c (print_error_message): Avoid int overflow.
8971
56201685
PE
8972 * font.c (font_list_entities): Redo for clarity,
8973 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8974
78834453 8975 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8976 (font_score): Avoid potential overflow in diff calculation.
78834453 8977
0bc0b309 8978 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8979 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8980
e610eaca
PE
8981 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8982
b895abce
PE
8983 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8984 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8985 can always succeed if overflow has undefined behavior.
8986
1f1d9321 8987 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8988 (wordify): Omit three unnecessary tests.
1f1d9321 8989
c59478bc
PE
8990 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8991 All callers changed. This avoids the need for an unused var.
8992
79b73827
PE
8993 * casefiddle.c (casify_region): Remove var that is set but not used.
8994
a4db5dfe
PE
8995 * dired.c (file_name_completion): Remove var that is set but not used.
8996
43aae36e
PE
8997 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8998
2a47c44d 8999 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 9000 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 9001
a37c69bf
PE
9002 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
9003 Check for integer overflow on size calculations.
9004
328ab8e7
PE
9005 * buffer.c (Fprevious_overlay_change): Remove var that is set
9006 but not used.
9007
e5a2a5cb
PE
9008 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
9009 Remove vars that are set but not used.
8d84a6eb 9010 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 9011 (timer_check_2): Mark vars as initialized.
e5a2a5cb 9012
a60e5f68
PE
9013 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
9014
f661cb61 9015 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 9016 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 9017
f0397f5a
PE
9018 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9019 that are set but not used.
9020
8664db06 9021 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 9022 if XCreateBitmapFromData fails (Bug#8410).
8664db06 9023
6abdaa4a
PE
9024 * xselect.c (x_get_local_selection, x_handle_property_notify):
9025 Remove vars that are set but not used.
9026
0ce7538d 9027 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 9028 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 9029
9ae848fc
PE
9030 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9031 Remove var that is set but not used.
0b918413
PE
9032 (scroll_bar_windows_size): Now size_t, not int.
9033 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9034 Check for overflow.
9ae848fc 9035
a5a62657
PE
9036 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9037 (map_tty_color) [!defined MSDOS]: Likewise.
9038
5c5cdd39
PE
9039 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9040
66ebf983
PE
9041 * coding.c: Remove vars that are set but not used.
9042 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9043 All callers changed.
9044 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9045 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9046 (decode_coding_charset): Remove vars that are set but not used.
9047
1be4d761
PE
9048 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9049 that is set but not used.
9050
47553fa8
PE
9051 * print.c (print_object): Remove var that is set but not used.
9052
1f7196bf 9053 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
9054 The gnulib version avoids calling malloc in the usual case,
9055 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
9056 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
9057 * filelock.c (current_lock_owner): Likewise.
9058 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
9059 * sysdep.c: Include allocator.h, careadlinkat.h.
9060 (emacs_no_realloc_allocator): New static constant.
9061 (emacs_readlink): New function.
fdb61804
PE
9062 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
9063 ../lib/careadlinkat.h.
d1fdcab7 9064
f84c17c7
SM
90652011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
9066
9067 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
9068 first non-nil return value).
9069
ef3862ad
JD
90702011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9071
9072 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9073 if not defined (Bug#8403).
9074
376a7006
JB
90752011-04-02 Juanma Barranquero <lekktu@gmail.com>
9076
9077 * xdisp.c (display_count_lines): Remove parameter `start',
9078 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9079 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9080 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9081 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9082 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9083 and thereabouts. All callers changed.
9084 (get_per_char_metric): Remove parameter `f', unused since
9085 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9086
6ca3801d
JM
90872011-04-02 Jim Meyering <meyering@redhat.com>
9088
9089 do not dereference NULL upon failed strdup
9090 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9091 (ns_get_family): Likewise.
9092
d8e2b5ba
JB
90932011-04-02 Juanma Barranquero <lekktu@gmail.com>
9094
9095 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9096
8c74fcbd
JD
90972011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9098
9099 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9100 later (Bug#8403).
9101
7200d79c
SM
91022011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9103
03408648 9104 Add lexical binding.
7200d79c 9105
03408648
SM
9106 * window.c (Ftemp_output_buffer_show): New fun.
9107 (Fsave_window_excursion):
9108 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9109
9110 * lread.c (lisp_file_lexically_bound_p): New function.
9111 (Fload): Bind Qlexical_binding.
9112 (readevalloop): Remove `evalfun' arg.
9113 Bind Qinternal_interpreter_environment.
9114 (Feval_buffer): Bind Qlexical_binding.
9115 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9116 Mark as dynamic.
9117 (syms_of_lread): Declare `lexical-binding'.
9118
9119 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9120
9121 * keyboard.c (eval_dyn): New fun.
9122 (menu_item_eval_property): Use it.
ca105506
SM
9123
9124 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 9125
03408648
SM
9126 * fns.c (concat, mapcar1): Accept byte-code-functions.
9127
9128 * eval.c (Fsetq): Handle lexical vars.
9129 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9130 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9131 (FletX, Flet): Obey lexical binding.
9132 (Fcommandp): Handle closures.
9133 (Feval): New `lexical' arg.
9134 (eval_sub): New function extracted from Feval. Use it almost
9135 everywhere where Feval was used. Look up vars in lexical env.
9136 Handle closures.
9137 (Ffunctionp): Move from subr.el.
9138 (Ffuncall): Handle closures.
9139 (apply_lambda): Remove `eval_flags'.
9140 (funcall_lambda): Handle closures and new byte-code-functions.
9141 (Fspecial_variable_p): New function.
9142 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
9143 but without exporting it to Lisp.
23aba0ea 9144
23aba0ea 9145 * doc.c (Fdocumentation, store_function_docstring):
03408648 9146 * data.c (Finteractive_form): Handle closures.
23aba0ea 9147
03408648
SM
9148 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
9149 interactive spec.
ba83908c 9150
04f2d78b
CB
9151 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
9152 New byte-codes.
03408648
SM
9153 (exec_byte_code): New function extracted from Fbyte_code to handle new
9154 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 9155
03408648 9156 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 9157
03408648 9158 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 9159
e2abce01
JB
91602011-03-31 Juanma Barranquero <lekktu@gmail.com>
9161
9162 * xdisp.c (redisplay_internal): Fix prototype.
9163
63696a73 91642011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 9165
63696a73 9166 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
9167 (try_scrolling): Use it when setting scroll_limit.
9168 Limit scrolling to 100 screen lines.
63696a73
EZ
9169 (redisplay_window): Even when falling back on "recentering",
9170 position point in the window according to scroll-conservatively,
9171 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9172
9173 (try_scrolling): When point is above the window, allow searching
9174 as far as scroll_max, or one screenful, to compute vertical
9175 distance from PT to the scroll margin position. This prevents
9176 try_scrolling from unnecessarily failing when
9177 scroll-conservatively is set to a value slightly larger than the
9178 window height. Clean up the case of PT below the margin at bottom
9179 of window: scroll_max can no longer be INT_MAX. When aggressive
9180 scrolling is in use, don't let point enter the opposite scroll
9181 margin as result of the scroll.
9182 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
9183 threshold of 100 lines for never-recentering scrolling.
9184
e4cc2dfc
JB
91852011-03-31 Juanma Barranquero <lekktu@gmail.com>
9186
9187 * dispextern.h (move_it_by_lines):
9188 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9189 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9190 (message_log_check_duplicate): Remove parameters `prev_bol' and
9191 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9192 (redisplay_internal): Remove parameter `preserve_echo_area',
9193 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9194
9195 * indent.c (Fvertical_motion):
9196 * window.c (window_scroll_pixel_based, Frecenter):
9197 Don't pass `need_y_p' to `move_it_by_lines'.
9198
1c470562
SM
91992011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9200
44f230aa
SM
9201 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9202 steal a few bits to be more compact.
9203 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9204 Remove unneeded casts.
9205
1c470562
SM
9206 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9207
888adce9
ZK
92082011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9209
9210 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9211 binding" message (bug#7967).
9212
f838ed7b
PE
92132011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9214
77861b95
PE
9215 Fix more problems found by GCC 4.6.0's static checks.
9216
de6dbc14
PE
9217 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9218 Remove unused local var.
9219
f838ed7b
PE
9220 * editfns.c (Fmessage_box): Remove unused local var.
9221
792c7b2b
PE
9222 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9223 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9224 Omit unused local vars.
c499e557 9225 * window.c (shrink_windows): Omit unused local var.
b01a1c29 9226 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
9227 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9228 Omit unused local var.
9229
ba0165e1
PE
9230 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9231 Don't assume string length fits in int.
32ad8845 9232 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 9233 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 9234
3c59b4c9
PE
9235 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9236 instead of alloca (Bug#8344).
9237
a3eed478 9238 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 9239 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 9240
eb4d412d
PE
9241 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9242
1658b401
PE
9243 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9244 concerns.
9245
9246 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9247
9248 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 9249
9a2c6e05
PE
9250 * keyboard.c (syms_of_keyboard): Use the same style as later
9251 in this function when indexing through an array. This also
9252 works around GCC bug 48267.
9253
03d0a109
PE
9254 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9255
44f730c8
PE
9256 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9257
fe75f926
PE
9258 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9259 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9260
ffa8c828
PE
9261 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9262 This avoids undefined behavior on integer overflow, and is a bit
9263 more convenient anyway since it is compared to a size_t variable.
9264
c5101a77
PE
9265 Variadic C functions now count arguments with size_t, not int.
9266 This avoids an unnecessary limitation on 64-bit machines, which
9267 caused (substring ...) to crash on large vectors (Bug#8344).
9268 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9269 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 9270 All variadic functions and their callers changed accordingly.
c5101a77
PE
9271 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9272 * data.c (arith_driver, float_arith_driver): Likewise.
9273 * editfns.c (general_insert_function): Likewise.
9274 * eval.c (struct backtrace.nargs, interactive_p)
9275 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9276 (funcall_lambda, mark_backtrace): Likewise.
9277 * fns.c (concat): Likewise.
9278 * frame.c (x_set_frame_parameters): Likewise.
9279 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9280 0 if not found, not -1. All callers changed.
9281
dd3f25f7
PE
9282 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9283 (stack_copy_size): Now size_t, not int.
9284 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9285
461c2ab9
JB
92862011-03-28 Juanma Barranquero <lekktu@gmail.com>
9287
9288 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9289 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9290 All callers changed.
9291
9292 * lisp.h (multibyte_char_to_unibyte):
9293 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9294 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9295 * character.h (CHAR_TO_BYTE8):
9296 * cmds.c (internal_self_insert):
9297 * editfns.c (general_insert_function):
9298 * keymap.c (push_key_description):
9299 * search.c (Freplace_match):
9300 * xdisp.c (message_dolog, set_message_1): All callers changed.
9301
f6d62986
SM
93022011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9303
9304 * keyboard.c (safe_run_hook_funcall): New function.
9305 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9306 don't set the hook to nil, but remove the offending function instead.
9307 (Qcommand_hook_internal): Remove, unused.
9308 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9309 Vcommand_hook_internal.
9310
9311 * eval.c (enum run_hooks_condition): Remove.
9312 (funcall_nil, funcall_not): New functions.
9313 (run_hook_with_args): Call each function through a `funcall' argument.
9314 Remove `cond' argument, now redundant.
9315 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9316 (Frun_hook_with_args_until_failure): Adjust accordingly.
9317 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9318
1db5b1ad
JB
93192011-03-28 Juanma Barranquero <lekktu@gmail.com>
9320
9321 * dispextern.h (string_buffer_position): Remove declaration.
9322
9323 * print.c (strout): Remove parameter `multibyte', unused since
9324 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9325
9326 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9327 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9328 All callers changed.
9329
9330 * w32.c (_wsa_errlist): Use braces for struct initializers.
9331
9332 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9333 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9334 All callers changed.
9335 (string_buffer_position): Likewise. Also, make static (it's never
9336 used outside xdisp.c).
9337 (cursor_row_p): Remove parameter `w', unused since
9338 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9339 (decode_mode_spec): Remove parameter `precision', introduced during
9340 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9341 All callers changed.
9342
5ffb62aa
JD
93432011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9344
9345 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9346
461c2ab9 93472011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
9348
9349 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9350 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9351 (ns_update_auto_hide_menu_bar): New functions.
9352 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9353 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9354 ns_constrain_all_frames.
9355 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9356 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9357
5c380ffb
JD
93582011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9359
9360 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9361
9af30bdf
GM
93622011-03-27 Glenn Morris <rgm@gnu.org>
9363
9364 * syssignal.h: Replace RETSIGTYPE with void.
9365 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9366 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9367 Replace SIGTYPE with void everywhere.
9368 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9369 * s/template.h (SIGTYPE): Remove commented out definition.
9370
e2abce01
JB
93712011-03-26 Eli Zaretskii <eliz@gnu.org>
9372
9373 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9374 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9375
f868cd8a
JB
93762011-03-26 Juanma Barranquero <lekktu@gmail.com>
9377
59eb0929
JB
9378 * w32.c (read_unc_volume): Use parameter `henum', instead of
9379 global variable `wget_enum_handle'.
9380
9381 * keymap.c (describe_vector): Remove parameters `indices' and
9382 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9383 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9384
f868cd8a
JB
9385 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9386
9387 * keyboard.c (timer_check): Remove parameter `do_it_now',
9388 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9389 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9390 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9391
9392 * keyboard.c (read_char):
9393 * w32menu.c (w32_menu_display_help):
9394 * xmenu.c (show_help_event, menu_help_callback):
9395 Adjust calls to `show_help_echo'.
9396
9397 * gtkutil.c (xg_maybe_add_timer):
9398 * keyboard.c (readable_events):
9399 * process.c (wait_reading_process_output):
9400 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9401
9402 * insdel.c (adjust_markers_gap_motion):
9403 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9404 (gap_left, gap_right): Don't call it.
9405
2ecf6fdb
CY
94062011-03-25 Chong Yidong <cyd@stupidchicken.com>
9407
9408 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9409 incurred during fontification.
9410
6b1f9ba4
JB
94112011-03-25 Juanma Barranquero <lekktu@gmail.com>
9412
9413 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9414 (DEFVAR_PER_BUFFER): Don't pass it.
9415
9416 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9417 (scrolling_window): Don't pass it.
9418
0f4a96b5
JB
94192011-03-25 Juanma Barranquero <lekktu@gmail.com>
9420
9421 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9422
9423 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9424 and `suffix'.
9425 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9426 of variables specific to SELinux and computation of `encoded_absname'.
9427
9428 * image.c (XPutPixel): Remove unused variable `height'.
9429
9430 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9431
9432 * unexw32.c (get_section_info): Remove unused variable `section'.
9433
9434 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9435 (system_process_attributes): Remove unused variable `sess'.
9436 (sys_read): Remove unused variable `err'.
9437
9438 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9439 (w32_wnd_proc): Remove unused variable `isdead'.
9440 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9441 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9442 (x_create_tip_frame): Remove unused variable `tem'.
9443
9444 * w32inevt.c (w32_console_read_socket):
9445 Remove unused variable `no_events'.
9446
9447 * w32term.c (x_draw_composite_glyph_string_foreground):
9448 Remove unused variable `width'.
9449
1149507c
JB
94502011-03-24 Juanma Barranquero <lekktu@gmail.com>
9451
9452 * w32term.c (x_set_glyph_string_clipping):
9453 Don't pass uninitialized region to CombineRgn.
9454
9c88f339
JB
94552011-03-23 Juanma Barranquero <lekktu@gmail.com>
9456
9457 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9458 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9459 (Fx_close_connection): Remove unused variable `i'.
9460
9461 * w32font.c (w32font_draw): Return number of glyphs.
9462 (w32font_open_internal): Remove unused variable `i'.
9463 (w32font_driver): Add missing initializer.
9464
9465 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9466 (fill_in_menu): Remove unused variable `items_added'.
9467
9468 * w32term.c (last_mouse_press_frame): Remove static global variable.
9469 (w32_clip_to_row): Remove unused variable `f'.
9470 (x_delete_terminal): Remove unused variable `i'.
9471
9472 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9473 (NOTHING): Remove unused static global variable.
9474 (uniscribe_check_otf): Remove unused variable `table'.
9475 (uniscribe_font_driver): Add missing initializers.
9476
dee091a3
JD
94772011-03-23 Julien Danjou <julien@danjou.info>
9478
9479 * term.c (Fsuspend_tty, Fresume_tty):
9480 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9481 * window.c (temp_output_buffer_show):
9482 * insdel.c (signal_before_change):
9483 * frame.c (Fhandle_switch_frame):
9484 * fileio.c (Fdo_auto_save):
9485 * emacs.c (Fkill_emacs):
9486 * editfns.c (save_excursion_restore):
9487 * cmds.c (internal_self_insert):
9488 * callint.c (Fcall_interactively):
9489 * buffer.c (Fkill_all_local_variables):
9490 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9491 Use Frun_hooks.
0f4a96b5 9492 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9493 unconditionally since it does the check itself.
dee091a3 9494
2c520ab5 94952011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9496
c9c49752
PE
9497 Fix more problems found by GCC 4.5.2's static checks.
9498
8abc3f12
PE
9499 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9500 the first time through the loop, since we know p0 < p1 then.
9501 This also avoids a gcc -Wstrict-overflow warning.
9502
a2d26660
PE
9503 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9504 leading to a memory leak, possible in functions like
9505 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9506 of objects (Bug#8318).
a2d26660 9507
916c72e9
PE
9508 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9509 that could (at least in theory) be that large.
9510
19ab8a18
PE
9511 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9512 This is less likely to overflow, and avoids undefined behavior if
9513 overflow does occur. All callers changed. Use strtoul to scan
9514 for the unsigned long integer.
b7cbbd6f
PE
9515 (pint2hrstr): Simplify and tune code slightly.
9516 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9517
f0641eff
PE
9518 * scroll.c (do_scrolling): Work around GCC bug 48228.
9519 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9520
7f650bb9
PE
9521 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9522 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9523 (validate_x_resource_name): Simplify count usage.
9524 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9525
37dd57d1
PE
9526 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9527 fail (Bug#8306).
81e56e61 9528
699979fc 9529 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9530
401bf9b4
PE
9531 * process.c (Fmake_network_process): Use socklen_t, not int,
9532 where POSIX says socklen_t is required in portable programs.
9533 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9534 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9535 (Fmake_network_process, server_accept_connection):
9536 (wait_reading_process_output, read_process_output):
9537 Likewise.
9538
b93aacde
PE
9539 * process.c: Rename or move locals to avoid shadowing.
9540 (list_processes_1, Fmake_network_process):
9541 (read_process_output_error_handler, exec_sentinel_error_handler):
9542 Rename or move locals.
4dc343ee 9543 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9544 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9545 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9546 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9547 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9548
af8a867c 9549 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9550 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9551 Include tparam.h instead, since it declares them.
af8a867c
PE
9552 * cm.h (PC): Remove extern decl; tparam.h now does this.
9553 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9554 * terminfo.c: Include tparam.h, to check interfaces.
9555 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9556 (tparam): Adjust signature to match interface in tparam.h;
9557 this removes some undefined behavior. Check that outstring and len
9558 are zero, which they always are with Emacs.
9559 * tparam.h (PC, BC, UP): New extern decls.
9560
0248044d 9561 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9562 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9563
8ff096c1 9564 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9565 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9566 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9567 (ftfont_list): Remove unused local.
49eaafba
PE
9568 (get_adstyle_property, ftfont_pattern_entity):
9569 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9570 Rename locals to avoid shadowing.
8ff096c1 9571
e2be39f6
PE
9572 * xfont.c (xfont_list_family): Mark var as initialized.
9573
c9735e30
PE
9574 * xml.c (make_dom): Now static.
9575
8f5201ae
PE
9576 * composite.c (composition_compute_stop_pos): Rename local to
9577 avoid shadowing.
b246f932
PE
9578 (composition_reseat_it): Remove unused locals.
9579 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9580 (composition_update_it): Mark var as initialized.
11b61122
PE
9581 (find_automatic_composition): Mark vars as initialized,
9582 with a FIXME (Bug#8290).
8f5201ae 9583
760fbc2c
PE
9584 character.h: Rename locals to avoid shadowing.
9585 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9586 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9587 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9588 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9589 to avoid shadowing.
9590
ff08eb85
PE
9591 * textprop.c (property_change_between_p): Remove; unused.
9592
fc7bf025
PE
9593 * intervals.c (interval_start_pos): Now static.
9594
235d7abc
PE
9595 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9596
44f230aa
SM
9597 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9598 Rename locals to avoid shadowing.
3e7d6594 9599
50060332
PE
9600 * sound.c (wav_play, au_play, Fplay_sound_internal):
9601 Fix pointer signedness.
d01f234b 9602 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9603 (wav_play): Initialize a variable to 0, to prevent undefined
9604 behavior (Bug#8278).
50060332 9605
c4fc4e30
PE
9606 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9607
918436ed
PE
9608 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9609
c939f91b
PE
9610 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9611 clobbering (Bug#8298).
b9c7f648
PE
9612 * sysdep.c (sys_subshell): Likewise.
9613 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9614
6bd8c144
PE
9615 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9616 This should get cleaned up, so that child_setup has the
9617 same signature on all platforms.
9618
7710357c 9619 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9620 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9621
c59da222
CY
96222011-03-22 Chong Yidong <cyd@stupidchicken.com>
9623
9624 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9625 not to be necessary, and produces flickering.
9626
66b87493
GM
96272011-03-20 Glenn Morris <rgm@gnu.org>
9628
9629 * config.in: Remove file.
9630
45b6f6d5
JB
96312011-03-20 Juanma Barranquero <lekktu@gmail.com>
9632
9633 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9634 are now in src/globals.h.
9635 (syms_of_minibuf): Remove spurious & from previous change.
9636
cd394be1 96372011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9638
9639 * minibuf.c (completing-read-function): New variable.
9640 (completing-read-default): Rename from completing-read.
9641 (completing-read): Call completing-read-function.
9642
b14e3e21
CY
96432011-03-19 Juanma Barranquero <lekktu@gmail.com>
9644
9645 * xfaces.c (Fx_load_color_file):
9646 Read color file from absolute filename (bug#8250).
9647
f2b726e6
JB
96482011-03-19 Juanma Barranquero <lekktu@gmail.com>
9649
9650 * makefile.w32-in: Update dependencies.
9651
09f6ff02
EZ
96522011-03-17 Eli Zaretskii <eliz@gnu.org>
9653
9654 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9655
29a6015a
PE
96562011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9657
a3a6c54e
PE
9658 Fix more problems found by GCC 4.5.2's static checks.
9659
b766f867
PE
9660 * process.c (make_serial_process_unwind, send_process_trap):
9661 (sigchld_handler): Now static.
9662
be02381c
PE
9663 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9664 That way, the code declares only the vars that it needs.
9665 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9666 * s/cygwin.h (PTY_ITERATION): Likewise.
9667 * s/darwin.h (PTY_ITERATION): Likewise.
9668 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9669
57048744
PE
9670 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9671 * process.c (allocate_pty): Don't declare stb unless it's needed.
9672
7914961c 9673 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9674 (CONSTANTLIM): Remove; unused.
9675 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9676 Define only if needed.
7914961c 9677
b3967b18
PE
9678 * unexelf.c (unexec): Name an expression,
9679 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9680 Use a different way to cause a compilation error if anyone uses
9681 n rather than nn, a way that does not involve shadowing.
73366a00 9682 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9683
29a6015a
PE
9684 * deps.mk (unexalpha.o): Remove; unused.
9685
43cfc33e 9686 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9687 * unexec.h: New file.
ce701a33
PE
9688 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9689 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9690 Depend on unexec.h.
9691 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9692 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9693 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9694 Change as necessary to match prototype in unexec.h.
ce701a33 9695
01f44d5a
PE
9696 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9697 shadowing.
4f63c6bb 9698 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9699
a6670b0b
PE
9700 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9701 Rename locals to avoid shadowing.
9702
cef2010d 9703 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9704 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9705
d4d7173a
PE
9706 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9707
f08b802a
PE
9708 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9709 warning when compiling print.c.
9710
3ddb0639
PE
9711 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9712 instead of using an uninitialized var.
5ad03b97 9713 (font_sort_entities): Mark var as initialized.
3ddb0639 9714
170a2692
PE
9715 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9716
e663c700
PE
9717 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9718 pointers to constants.
89bc529a 9719 (font_parse_fcname): Remove unused vars.
7b81e2d0 9720 (font_delete_unmatched): Now static.
ea838e10 9721 (font_get_spec): Remove; unused.
13a547c6
PE
9722 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9723 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9724 Rename or move locals to avoid shadowing.
e663c700 9725
2a80c887 9726 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9727 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9728
1384fa33 9729 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9730 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9731
8b2c52e9
PE
9732 * alloc.c (mark_backtrace): Move decl from here ...
9733 * lisp.h: ... to here, so that it can be checked.
9734
475545b5 9735 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9736 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9737 (lisp_indirect_variable): Name an expression,
9738 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9739 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9740
b1349114 9741 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9742 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9743 Use const pointer when appropriate.
b1349114 9744
a2928364
PE
9745 * lisp.h (get_system_name, get_operating_system_release):
9746 Move decls here, to check interfaces.
9747 * process.c (get_operating_system_release): Move decl to lisp.h.
9748 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9749 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9750 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9751 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9752 (Fformat_time_string, Fencode_time, Finsert_char):
9753 (Ftranslate_region_internal, Fformat):
9754 Rename or remove local vars to avoid shadowing.
9710023e 9755 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9756
a415e694
PE
9757 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9758 avoid shadowing.
9759
8ef4622d
PE
9760 * lisp.h (eassert): Check that the argument compiles, even if
9761 ENABLE_CHECKING is not defined.
9762
946f9a5b
PE
9763 * data.c (Findirect_variable): Name an expression, to avoid
9764 gcc -Wbad-function-cast warning.
112396d6 9765 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9766 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9767 (Fmake_variable_buffer_local, Fmake_local_variable):
9768 Mark variables as initialized.
52746918 9769 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9770
e5aab7e7 9771 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9772 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9773 Rename locals to avoid shadowing.
dff45157
PE
9774 (mark_stack): Move local variables into the #ifdef region where
9775 they're used.
7bc26fdb
PE
9776 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9777 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9778 needed otherwise.
9779 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9780 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9781 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9782
e5aab7e7
PE
9783 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9784 avoids undefined behavior in theory.
9785
4da60324
PE
9786 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9787
88043301
PE
9788 Use functions, not macros, for up- and down-casing (Bug#8254).
9789 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9790 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9791 to use the following functions instead of these macros.
9792 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9793 EMACS_INT, since callers assume the returned value fits in int.
9794 (upcase1): Likewise, for UPCASE_TABLE.
9795 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9796 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9797 the race-condition problem in the old DOWNCASE.
88043301 9798
19ed5445
PE
9799 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9800 Rename locals to avoid shadowing.
9801 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9802 (regex_compile, re_search_2, re_match_2_internal):
9803 Remove unused local vars.
952db0d7
PE
9804 (FREE_VAR): Rewrite so as not to use empty "else",
9805 which gcc can warn about.
da053e48 9806 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9807 (RETALLOC_IF): Define only if needed.
9808 (WORDCHAR_P): Likewise. This one is never needed, but is used
9809 only in a comment talking about a compiler bug, so put inside
9810 the #if 0 of that comment.
9811 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9812 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9813 Remove; unused.
19ed5445 9814
1f3561e4 9815 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9816 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9817 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9818
ded6f8f7
PE
9819 * search.c (simple_search): Remove unused var.
9820
dbd37a95
PE
9821 * dired.c (compile_pattern): Move decl from here ...
9822 * lisp.h: ... to here, so that it can be checked.
9823 (struct re_registers): New forward decl.
9824
7e47afad
PE
9825 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9826
85f24f61
PE
9827 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9828 All uses changed.
9829 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9830 Rename locals to avoid shadowing.
5671df8f 9831 (Fvertical_motion): Mark locals as initialized.
85f24f61 9832
181aa2be 9833 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9834 (casify_region): Mark local as initialized.
181aa2be 9835
930d429c
PE
9836 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9837
7082eac6
PE
9838 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9839 New macros, so that the caller can use some names other than
9840 gcpro1, gcpro2, etc.
9841 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9842 of the new macros.
9843 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9844 argument, for consistency with GCPRO2_VAR, etc: it is now the
9845 prefix of the variable, not the variable itself. All uses
9846 changed.
38b2c076
PE
9847 * dired.c (directory_files_internal, file_name_completion):
9848 Rename locals to avoid shadowing.
9849
15206ed9
PE
9850 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9851 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9852 dired.c's scmp function, had undefined behavior.
9853 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9854 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9855 * buffer.h: ... to here, because these macros use current_buffer,
9856 and the new implementation with inline functions needs to have
9857 current_buffer in scope now, rather than later when the macros
9858 are used.
9859 (downcase, upcase1): New static inline functions.
9860 (DOWNCASE, UPCASE1): Reimplement using these functions.
9861 This avoids undefined behavior in expressions like
9862 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9863 from race conditions in accessing the global variables
9864 case_temp1 and case_temp2.
9865 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9866 * lisp.h (case_temp1, case_temp2): Remove their decls.
9867 * character.h (ASCII_CHAR_P): Move from here ...
9868 * lisp.h: ... to here, so that the inline functions mentioned
9869 above can use them.
9870
4a6bea26
PE
9871 * dired.c (directory_files_internal_unwind): Now static.
9872
f14b7e14
PE
9873 * fileio.c (file_name_as_directory, directory_file_name):
9874 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9875 Now static.
2893f146
PE
9876 (file_name_as_directory): Use const pointers when appropriate.
9877 (Fexpand_file_name): Likewise. In particular, newdir might
9878 point at constant storage, so make it a const pointer.
fd4ead52 9879 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9880 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9881 signedness issues.
f839df0c
PE
9882 (Fset_file_times, Finsert_file_contents, auto_save_error):
9883 Rename locals to avoid shadowing.
f14b7e14 9884
5716756e 9885 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9886 (Ftry_completion, Fall_completions): Rename or remove locals
9887 to avoid shadowing.
5716756e 9888
b4c3046a
PE
9889 * marker.c (bytepos_to_charpos): Remove; unused.
9890
b45db522
PE
9891 * lisp.h (verify_bytepos, count_markers): New decls,
9892 so that gcc does not warn that these functions aren't declared.
9893
85876d07
PE
9894 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9895 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9896 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9897 (copy_text): Remove unused local var.
85876d07 9898
03d78a21 9899 * filelock.c (within_one_second): Now static.
b3dd38ab 9900 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9901
5df8f01b
PE
9902 * buffer.c (fix_overlays_before): Mark locals as initialized.
9903 (fix_start_end_in_overlays): Likewise. This function should be
9904 simplified by using pointers-to-pointers, but that's a different
9905 matter.
b1d876f1 9906 (switch_to_buffer_1): Now static.
8f54f30a
PE
9907 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9908 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9909
a70072c9 9910 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9911 Fix pointer signedness issue.
edced198
PE
9912 (sys_subshell): Mark local as volatile if checking for lint,
9913 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9914 (MAXPATHLEN): Define only if needed.
a70072c9 9915
a0977c44
PE
9916 * process.c (serial_open, serial_configure): Move decls from here ...
9917 * systty.h: ... to here, so that they can be checked.
9918
a884fdcc
PE
9919 * fns.c (get_random, seed_random): Move extern decls from here ...
9920 * lisp.h: ... to here, so that they can be checked.
9921
604efe86 9922 * sysdep.c (reset_io): Now static.
b8950c94 9923 (wait_for_termination_signal): Remove; unused.
604efe86 9924
38fc62d9
PE
9925 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9926 (copy_keymap_item, append_key, push_text_char_description):
9927 Now static.
1004a21a 9928 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9929 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9930 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9931 (describe_map_tree):
9932 Rename locals to avoid shadowing.
38fc62d9 9933
2f2650da
PE
9934 * keyboard.c: Declare functions static if they are not used elsewhere.
9935 (echo_char, echo_dash, cmd_error, top_level_2):
9936 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9937 (read_char, kbd_buffer_get_event, make_lispy_position):
9938 (make_lispy_event, make_lispy_movement, apply_modifiers):
9939 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9940 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9941 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9942 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9943 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9944
a053e86c 9945 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9946 (mark_kboards): Move decl here ...
9947 * alloc.c (mark_kboards): ... from here.
a053e86c 9948
4752793e
PE
9949 * lisp.h (force_auto_save_soon): New decl.
9950
74f10ca7 9951 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9952 (DEFINE_DUMMY_FUNCTION): New macro.
9953 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9954 Use it.
c03cd23f
PE
9955 (main): Add casts to avoid warnings
9956 if GCC considers string literals to be constants.
74f10ca7 9957
022e70d4
PE
9958 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9959
59d6fe83
PE
9960 * dbusbind.c: Pointer signedness fixes.
9961 (xd_signature, xd_append_arg, xd_initialize):
9962 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9963 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9964 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9965 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9966
78320123
PE
9967 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9968 if GCC considers string literals to be constants.
49cebcca 9969 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9970
35ac2a97
SM
99712011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9972
fb103ca9
SM
9973 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9974 (print_preprocess, print_object): New macro to fix last change.
9975
35ac2a97
SM
9976 * print.c (print_preprocess): Don't forget font objects.
9977
62973b41
JB
99782011-03-16 Juanma Barranquero <lekktu@gmail.com>
9979
9980 * emacs.c (USAGE3): Doc fixes.
9981
0e48bb22
AS
99822011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9983
9984 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9985 structure.
9986
7684e57b
JB
99872011-03-14 Juanma Barranquero <lekktu@gmail.com>
9988
9989 * lisp.h (VWindow_system, Qfile_name_history):
9990 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9991 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9992 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9993
9994 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9995 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9996
9997 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9998 * w32console.c (detect_input_pending, read_input_pending)
9999 (encode_terminal_code):
10000 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
10001 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
10002 (w32_system_caret_y, Qfile_name_history):
10003 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
10004 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
10005 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
10006 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
10007 * w32proc.c (Qlocal, report_file_error):
10008 * w32term.c (Vwindow_system, updating_frame):
10009 * w32uniscribe.c (initialized, uniscribe_font_driver):
10010 Remove unneeded extern declarations.
10011
2aa46d6c
CY
100122011-03-14 Chong Yidong <cyd@stupidchicken.com>
10013
c96bbc66 10014 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 10015
cffc6f3b
CY
100162011-03-13 Chong Yidong <cyd@stupidchicken.com>
10017
10018 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10019 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10020 These macros can no longer be used for assignment.
10021
44f230aa
SM
10022 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10023 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
10024 (record_buffer_markers, fetch_buffer_markers): New functions for
10025 recording and fetching special buffer markers.
10026 (set_buffer_internal_1, set_buffer_temp): Use them.
10027
10028 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10029
10030 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10031
10032 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10033 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10034
10035 * xdisp.c (hscroll_window_tree):
10036 (reconsider_clip_changes): Use PT instead of BUF_PT.
10037
d251f04b
EZ
100382011-03-13 Eli Zaretskii <eliz@gnu.org>
10039
10040 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10041 $(EMACS_ROOT)/lib/intprops.h.
10042
f0c77cd1
PE
100432011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10044
3eca4629
PE
10045 Fix more problems found by GCC 4.5.2's static checks.
10046
7c86ee98
PE
10047 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10048 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
10049 (xg_free_frame_widgets): Make it clear that a local variable is
10050 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
10051 (gdk_window_get_screen): Make it clear that this macro is needed
10052 only if USE_GTK_TOOLTIP.
1e5524e7
PE
10053 (int_gtk_range_get_value): New function, which avoids a diagnostic
10054 from gcc -Wbad-function-cast.
10055 (xg_set_toolkit_scroll_bar_thumb): Use it.
10056 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
10057 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
10058 (get_utf8_string, xg_get_file_with_chooser):
10059 Rename locals to avoid shadowing.
10060 (create_dialog): Move locals to avoid shadowing.
7c86ee98 10061
41729b81
PE
10062 * xgselect.c (xg_select): Remove unused var.
10063
f0c77cd1
PE
10064 * image.c (four_corners_best): Mark locals as initialized.
10065 (gif_load): Initialize transparent_p to zero (Bug#8238).
10066 Mark another local as initialized.
ec6cf4c6 10067 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 10068
ce0ad53d 10069 * image.c (clear_image_cache): Now static.
d5d5a617 10070 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 10071 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
10072 (x_edge_detection): Remove unnecessary cast that
10073 gcc -Wbad-function-cast diagnoses.
2037898d 10074 (gif_load): Fix pointer signedness.
6ae141d6
PE
10075 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10076 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 10077
33383987 100782011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 10079
d32df629
PE
10080 Improve quality of tests for time stamp overflow.
10081 For example, without this patch (encode-time 0 0 0 1 1
10082 1152921504606846976) returns the obviously-bogus value (-948597
10083 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10084 reports time overflow. See
10085 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
10086 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10087 * editfns.c: Include limits.h and intprops.h.
10088 (TIME_T_MIN, TIME_T_MAX): New macros.
10089 (time_overflow): Move earlier, to before first use.
10090 (hi_time, lo_time): New functions, for an accurate test for
10091 out-of-range times.
10092 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10093 (Fget_internal_run_time): Don't assume time_t fits in int.
10094 (make_time): Use list2 instead of Fcons twice.
10095 (Fdecode_time): More accurate test for out-of-range times.
10096 (check_tm_member): New function.
10097 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
10098 (lisp_time_argument): Don't rely on undefined left-shift and
10099 right-shift behavior when checking for time stamp overflow.
8be6f318 10100
fe31d94c
PE
10101 * editfns.c (time_overflow): New function, refactoring common code.
10102 (Fformat_time_string, Fdecode_time, Fencode_time):
10103 (Fcurrent_time_string): Use it.
10104
8be6f318
PE
10105 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10106 * dired.c (make_time): Move to ...
10107 * editfns.c (make_time): ... here.
10108 * systime.h: Note the move.
10109
09d9db2c 101102011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 10111
126bc0dc
YM
10112 * fringe.c (update_window_fringes): Remove unused variables.
10113
c47cbdfd
YM
10114 * unexmacosx.c (copy_data_segment): Also copy __got section.
10115 (Bug#8223)
10116
7ac80be9
EZ
101172011-03-12 Eli Zaretskii <eliz@gnu.org>
10118
c96bbc66 10119 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
10120 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10121 Constify `char *' arguments and their references according to
10122 prototypes in tparam.h.
10123
ecb0f94d 10124 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 10125
7ac80be9
EZ
10126 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10127 Adapt all references accordingly.
10128
10129 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10130
ef1fd07e
TT
101312011-03-11 Tom Tromey <tromey@redhat.com>
10132
10133 * buffer.c (syms_of_buffer): Remove obsolete comment.
10134
7ef4b50c
EZ
101352011-03-11 Eli Zaretskii <eliz@gnu.org>
10136
10137 * termhooks.h (encode_terminal_code): Declare prototype.
10138
10139 * msdos.c (encode_terminal_code): Don't declare prototype.
10140
10141 * term.c (encode_terminal_code): Now external again, used by
10142 w32console.c and msdos.c.
10143
44f230aa
SM
10144 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
10145 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 10146
4b1ec863 101472011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 10148
1714f52b 10149 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 10150
4b1ec863
PE
10151 * fringe.c (update_window_fringes): Mark locals as initialized
10152 (Bug#8227).
10153 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 10154
524c7aa6
PE
10155 * alloc.c (mark_fringe_data): Move decl from here ...
10156 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10157 to check its interface.
10158 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10159
a5c0af81 10160 * fontset.c (free_realized_fontset): Now static.
7519b8cd 10161 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 10162 (fontset_font): Mark local as initialized.
a9a06e0b 10163 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 10164
b4716021
PE
10165 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10166
811e9bac 10167 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 10168 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
10169 (x_own_selection, Fx_disown_selection_internal): Rename locals
10170 to avoid shadowing.
10171 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 10172
7e3ab302
PE
10173 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10174 so that the caller can use some name other than gcpro1.
10175 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
10176 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10177 (Fx_backspace_delete_keys_p):
10178 Use them to avoid shadowing, and rename vars to avoid shadowing.
10179 (x_decode_color, x_set_name, x_window): Now static.
6b437900 10180 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 10181 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
10182 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10183 Remove unused locals.
7e3ab302
PE
10184 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10185 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10186 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10187 macros.
f78faa98 10188
e2b13473
PE
10189 * xterm.h (x_mouse_leave): New decl.
10190
77f23912
PE
10191 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10192 Remove unused functions.
cdf4ba58
PE
10193 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10194 (x_calc_absolute_position): Now static.
7411c686 10195 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 10196 Don't declare local "event" unless it's used.
ed7bf3a5
PE
10197 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10198 unless they are used.
38d0b34a
PE
10199 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10200 (x_fatal_error_signal): Remove; not used.
a6067996
PE
10201 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10202 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10203 (x_error_catcher, x_connection_closed, x_error_handler):
10204 (x_error_quitter, xembed_send_message, x_iconify_frame):
10205 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 10206 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 10207 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 10208
44f230aa
SM
10209 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10210 Rename or move locals to avoid shadowing.
6b463e58 10211 (tty_defined_color, merge_face_heights): Now static.
5967d051 10212 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
10213 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10214 does not deduce is never used uninitialized.
73719eba
PE
10215 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10216 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 10217
426994c3 10218 * terminal.c (store_terminal_param): Now static.
5489860b 10219
032f1620 10220 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 10221 (set_frame_menubar): Remove unused local.
d4323972 10222 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
10223 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10224 since they might point to immutable storage.
281585b0
PE
10225 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10226 since it's unused otherwise.
032f1620 10227
367c19e5 10228 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 10229 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
10230 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10231 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 10232 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
10233 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10234 does not deduce are never used uninitialized.
70739cbe 10235
07b48fa9
PE
10236 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10237
8868a238 10238 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
10239 * window.c (window_loop, size_window):
10240 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 10241
7e5cf297 10242 * window.c (display_buffer): Now static.
d6550a9f
PE
10243 (size_window): Mark variables that gcc -Wuninitialized
10244 does not deduce are never used uninitialized.
a586633d
PE
10245 * window.h (check_all_windows): New decl, to forestall
10246 gcc -Wmissing-prototypes diagnostic.
5b555da1 10247 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 10248
f6095868
PE
10249 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10250 shadowing.
10251 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
10252 Include <limits.h>.
10253 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10254 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
10255 (load_charset_map): Mark variables that gcc -Wuninitialized
10256 does not deduce are never used uninitialized.
53df7c11 10257 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 10258
f38b440c
PE
10259 * coding.c (coding_set_source, coding_set_destination):
10260 Use "else { /* comment */ }" rather than "else /* comment */;"
10261 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
10262 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10263 a block, when the outer 'i' will do.
10264 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10265 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10266 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10267 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10268 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10269 Rename locals to avoid shadowing.
10270 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
10271 * coding.c (emacs_mule_char, encode_invocation_designation):
10272 Now static, since they're not used elsewhere.
413bb2db 10273 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 10274 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
10275 (decode_coding_emacs_mule): Mark variables that gcc
10276 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
10277 (detect_coding_iso_2022): Initialize a local variable that might
10278 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 10279 this initialization is needed. (Bug#8211)
5f58e762
PE
10280 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10281 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10282 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10283 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10284 Remove unused macros.
f38b440c 10285
232b38b9 10286 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 10287 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 10288 * character.c (string_count_byte8): Likewise.
232b38b9 10289
fb90da1b
PE
10290 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10291 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10292
fb93dbc2
PE
10293 * chartab.c (copy_sub_char_table): Now static, since it's not used
10294 elsewhere.
5c156ace
PE
10295 (sub_char_table_ref_and_range, char_table_ref_and_range):
10296 Rename locals to avoid shadowing.
bbcd0949 10297 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 10298
7d3b3862 10299 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 10300 (BIDI_BOB): Remove unused macro.
7d3b3862 10301
6be7d3da
PE
10302 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10303 deduce are never used uninitialized.
c2ed9c8b 10304 * term.c (encode_terminal_code): Likewise.
6be7d3da 10305
75f8807f 10306 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 10307
50938595
PE
10308 * tparam.h: New file.
10309 * term.c, tparam.h: Include it.
10310 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10311 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10312 Move these decls to tparam.h, and make them agree with what
10313 is actually in tparam.c. The previous trick of using incompatible
10314 decls in different modules does not conform to the C standard.
10315 All callers of tparam changed to use tparam's actual API.
10316 * tparam.c (tparam1, tparam, tgoto):
10317 Use const pointers where appropriate.
10318
fbceeba2
PE
10319 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10320 * cm.h (struct cm): Likewise.
10321 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10322 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10323 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10324 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10325 (turn_on_face, init_tty): Likewise.
10326 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 10327
7f3f1250
PE
10328 * term.c (term_mouse_position): Rename local to avoid shadowing.
10329
e6ca6543
PE
10330 * alloc.c (mark_ttys): Move decl from here ...
10331 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10332
c40f8d15
AS
103332011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10334
10335 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10336
cfe0661d
JB
103372011-03-09 Juanma Barranquero <lekktu@gmail.com>
10338
10339 * search.c (compile_pattern_1): Remove argument regp, unused since
10340 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10341 (compile_pattern): Don't pass it.
10342
0afb4571
J
103432011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10344
10345 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10346 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10347 for ! HAVE_GTK3.
10348 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10349
10350 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10351
10352 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10353 gdk_window_get_screen, gdk_window_get_geometry,
10354 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10355 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10356 (xg_get_pixbuf_from_pixmap): New function.
10357 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10358 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10359 Call xg_get_pixbuf_from_pixmap instead of
10360 gdk_pixbuf_get_from_drawable.
10361 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10362 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10363 (xg_check_special_colors): Use GtkStyleContext and its functions
10364 for HAVE_GTK3.
10365 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10366 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10367 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
10368 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10369 Call gtk_widget_get_preferred_size.
0afb4571
J
10370 (xg_frame_resized): gdk_window_get_geometry only takes 5
10371 parameters.
44f230aa
SM
10372 (xg_win_to_widget, xg_event_is_for_menubar):
10373 Call gdk_x11_window_lookup_for_display.
0afb4571
J
10374 (xg_set_widget_bg): New function.
10375 (delete_cb): New function.
895009e1 10376 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 10377 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
10378 (xg_set_background_color): Call xg_set_widget_bg.
10379 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10380 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10381 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10382 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10383 if ! HAVE_GTK3.
10384 (update_frame_tool_bar): Call gtk_widget_hide.
10385 (xg_initialize): Use GDK_KEY_g.
10386
10387 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10388 if ! HAVE_GTK3
10389 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10390
10391 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10392 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10393 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10394
1c2cc4ef
JB
103952011-03-08 Juanma Barranquero <lekktu@gmail.com>
10396
10397 * w32xfns.c (select_palette): Check success of RealizePalette against
10398 GDI_ERROR, not zero.
10399
33383987 10400See ChangeLog.11 for earlier changes.
aac0c6e3
MR
10401
10402;; Local Variables:
10403;; coding: utf-8
aac0c6e3
MR
10404;; End:
10405
2f097256 10406 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
10407
10408 This file is part of GNU Emacs.
10409
10410 GNU Emacs is free software: you can redistribute it and/or modify
10411 it under the terms of the GNU General Public License as published by
10412 the Free Software Foundation, either version 3 of the License, or
10413 (at your option) any later version.
10414
10415 GNU Emacs is distributed in the hope that it will be useful,
10416 but WITHOUT ANY WARRANTY; without even the implied warranty of
10417 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10418 GNU General Public License for more details.
10419
10420 You should have received a copy of the GNU General Public License
10421 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.