* keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
dc44c39a
PE
12012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2
078c97cb
PE
3 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4
dc44c39a
PE
5 * unexaix.c: Port to more-recent AIX compilers.
6 (report_error, report_error_1, make_hdr, copy_sym)
7 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
8 Make arguments const char *, not char *, to avoid violations of C
9 standard and to fix some AIX warnings reported by Gilles Pion.
10
e18afed7 112012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
12
13 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
14 already have overlays loaded.
15 (handle_single_display_spec): Before returning without displaying
16 fringe bitmap, synchronize the bidi iterator with the main display
17 iterator, by calling iterate_out_of_display_property.
18 (iterate_out_of_display_property): Detect buffer iteration by
19 testing that it->string is a Lisp string.
20 (get_next_display_element): When the current object is exhausted,
21 and there's something on it->stack, call set_iterator_to_next to
22 proceed with what's on the stack, instead of returning zero.
23 (set_iterator_to_next): If called at the end of a Lisp string,
24 proceed to consider_string_end without incrementing string
25 position. Don't increment display vector index past the end of
26 the display vector. (Bug#11417)
c8fb9dc6
EZ
27 (pos_visible_p): Don't report a position visible when move_it_to
28 stopped at the last line of window, which happens to be scanned
29 backwards by the bidi iteration. (Bug#11464)
ac268e67 30
e18afed7 312012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
32
33 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
34 and right-margin display specs even if the spec is invalid or we
35 are on a TTY, and thus unable to display on the fringes. That's
36 because the text with the property will not be displayed anyway,
37 so we need to signal to the caller that this is a "replacing"
38 display spec. This fixes display when the spec is invalid or we
39 are on a TTY.
40
e18afed7 412012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
42
43 * unexaix.c (make_hdr): Fix typo in prototype.
44 This bug broke the build on AIX. Problem reported by Gilles Pion.
45
9d0a235a
MA
462012-05-14 Michael Albinus <michael.albinus@gmx.de>
47
48 * keyboard.c (kbd_buffer_get_event): Read special events also in
49 batch mode. (Bug#11415)
50
9e6b06ed
GM
512012-05-12 Glenn Morris <rgm@gnu.org>
52
53 * ns.mk: Update for ns_appbindir no longer having trailing "/".
54
c1a1d7a3
EZ
552012-05-12 Eli Zaretskii <eliz@gnu.org>
56
57 * lisp.mk (lisp): Add newcomment.elc.
58
3fe7cdc8
GM
592012-05-12 Glenn Morris <rgm@gnu.org>
60
61 * Makefile.in (MKDIR_P): New, set by configure.
62 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
63
53f7d2c0
PE
642012-05-11 Paul Eggert <eggert@cs.ucla.edu>
65
66 Remove unused function hourglass_started.
67 * dispextern.h (hourglass_started):
68 * w32fns.c (hourglass_started):
69 * xdisp.c (hourglass_started): Remove.
70
75aafb17
JB
712012-05-10 Juanma Barranquero <lekktu@gmail.com>
72
73 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
74 Update dependencies.
75
12959e8e
PE
762012-05-10 Paul Eggert <eggert@cs.ucla.edu>
77
97107e2e
PE
78 * xgselect.c (xg_select): Put maxfds+1 into a var.
79 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
80
12959e8e
PE
81 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
82
836d29b3
DA
832012-05-10 Dave Abrahams <dave@boostpro.com>
84
85 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
86 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
87
5cb67954
MA
882012-05-09 Michael Albinus <michael.albinus@gmx.de>
89
90 * dbusbind.c (xd_registered_buses): New internal Lisp object.
91 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
92 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
93 Initialize xd_registered_buses.
94
3478ec45
PE
952012-05-09 Paul Eggert <eggert@cs.ucla.edu>
96
b263a6b0
PE
97 Untag more efficiently if USE_LSB_TAG.
98 This is based on a proposal by YAMAMOTO Mitsuharu in
99 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
100 For an admittedly artificial (nth 8000 longlist) benchmark on
101 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
102 Emacs's overall text size by 1%.
103 * lisp.h (XUNTAG): New macro.
104 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
105 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
106 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
107 * eval.c (Fautoload):
108 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
109 * frame.h (XFRAME): Use XUNTAG.
110
3478ec45
PE
111 Port recent dbusbind.c changes to 32-bit --with-wide-int.
112 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
113 Remove unportable assumptions about print widths of types like
114 dbus_uint32_t.
115 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
116 intptr_t when converting between pointer and integer, to avoid GCC
117 warnings about wrong width.
118
666b903b 1192012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
120
121 * w32proc.c (new_child): Force Windows to reserve only 64KB of
122 stack for each reader_thread, instead of defaulting to 8MB
123 determined by the linker. This avoids failures in creating
124 subprocesses on Windows 7, see the discussion in this thread:
125 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
126
b120cc17
JC
1272012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
128
129 Fix up display of the *Minibuf-0* buffer in the mini window.
130 * keyboard.c (read_char): Don't clear the echo area if there's no
131 message to clear.
132 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 133 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 134
9a4b36f8
MA
1352012-05-07 Michael Albinus <michael.albinus@gmx.de>
136
137 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
138 batch mode.
139
e5f9458f
CY
1402012-05-06 Chong Yidong <cyd@gnu.org>
141
142 * lisp.mk (lisp): Update.
143
eceeb5fc 1442012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
145
146 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
147
71873e2b
SM
1482012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
149
150 * data.c (PUT_ERROR): New macro.
151 (syms_of_data): Use it. Add new error type `user-error'.
152 * undo.c (user_error): New function.
153 (Fprimitive_undo): Use it.
154 * print.c (print_error_message): Adjust print style for `user-error'.
155 * keyboard.c (user_error): New function.
156 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
157
ab0fa4e4
PE
1582012-05-03 Paul Eggert <eggert@cs.ucla.edu>
159
160 Do not limit current-time-string to years 1000..9999.
161 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
162 (Fcurrent_time_string): Support any year that is supported by the
163 underlying localtime representation. Don't use asctime, as it
164 has undefined behavior for years outside the range -999..9999.
165
7ed806a7
PE
1662012-05-02 Paul Eggert <eggert@cs.ucla.edu>
167
168 Fix race conditions involving setenv, gmtime, localtime, asctime.
169 Without this fix, interrupts could mess up code that uses these
170 nonreentrant functions, since setting TZ invalidates existing
171 tm_zone or tzname values, and since most of these functions return
172 pointers to static storage.
173 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
174 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
175 Grow the critical sections to include not just invoking
176 localtime/gmtime, but also accessing these functions' results
177 including their tm_zone values if any, and any related TZ setting.
178 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
179 so that the struct tm is saved in the critical section.
180 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
181 motivated by the fact that memory allocation needs to be outside
182 the critical section.
183
0c16dfed
DA
1842012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
185
186 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
187 with RESET_INTERVAL.
188
189 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
190 Remove duplicated buffer name initialization.
191
3f83ace8
JM
1922012-05-02 Jim Meyering <jim@meyering.net>
193
194 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
195
c7b8541e
JM
196 * xfns.c (x_window): Use xstrdup (Bug#11375).
197
90207a15 1982012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
199
200 * xdisp.c (pos_visible_p): If already at a newline from the
201 display string before the 'while' loop, don't walk back the glyphs
202 from it3.glyph_row. Solves assertion violation when the display
203 string begins with a newline (egg.el). (Bug#11367)
204
b593d6a9
AH
2052012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
206
207 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
208 Move to simple.el.
209
4737362e
GM
2102012-05-01 Glenn Morris <rgm@gnu.org>
211
99cf43f9
GM
212 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
213 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
214 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
215 All were removed before 23.1.
216
9311dcff
GM
217 * dispnew.c: Remove HAVE_LIBNCURSES test;
218 it is always true on relevant platforms.
219
4d5c6349
GM
220 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
221 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
222
4737362e
GM
223 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
224
74dd3a6b
AS
2252012-04-30 Andreas Schwab <schwab@linux-m68k.org>
226
227 * .gdbinit (xpr): Remove checks for no longer existing misc types.
228 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
229 Remove.
230
13c379ee
PE
2312012-04-28 Paul Eggert <eggert@cs.ucla.edu>
232
233 Do not avoid creating empty evaporating overlays (Bug#9642).
234 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
235 That is, do not delete an evaporating overlay if it becomes
236 empty after its bounds are adjusted to fit within its buffer.
237 This fix caused other problems, and I'm reverting it until we get
238 to the bottom of them.
239
a8e7d6d7 2402012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
241
242 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
243
a8e7d6d7 2442012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
245
246 * xdisp.c (pos_visible_p): If the window start position is beyond
247 ZV, start the display from buffer beginning. Prevents assertion
248 violation in init_iterator when the minibuffer window is scrolled
249 via the scroll bar.
250
251 * window.c (window_scroll_pixel_based): Likewise.
252
a8e7d6d7 2532012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
254
255 * keymap.c (where_is_internal): Doc fix (Bug#10872).
256
a8e7d6d7 2572012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
258
259 * fileio.c (Fcopy_file, Fset_file_selinux_context):
260 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
261
a8e7d6d7 2622012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 263
b593d6a9
AH
264 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
265 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 266
1c6900d9
EZ
2672012-04-26 Eli Zaretskii <eliz@gnu.org>
268
4c3fa1d9
EZ
269 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
270 display element, check also the underlying string or buffer
271 character. (Bug#11341)
272
1c6900d9
EZ
273 * w32menu.c: Include w32heap.h.
274 (add_menu_item): If the call to AppendMenuW (via
275 unicode_append_menu) fails, disable Unicode menus only if we are
276 running on Windows 9X/Me.
277
42bf8205
AS
2782012-04-24 Andreas Schwab <schwab@linux-m68k.org>
279
280 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
281 (xgetint): Add missing shift for LSB tags.
282
b1bac16e
MR
2832012-04-24 Martin Rudalics <rudalics@gmx.at>
284
285 * keyboard.c (read_char): Don't wipe echo area for select window
286 events: These might get delayed via `mouse-autoselect-window'
287 (Bug#11304).
288
d69621cc
JB
2892012-04-24 Juanma Barranquero <lekktu@gmail.com>
290
291 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
292 manipulation of :loaded-from data.
293
02fd101b
JB
2942012-04-23 Juanma Barranquero <lekktu@gmail.com>
295
296 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
297 now a cons (bug#11311).
298
888bec30
PE
2992012-04-23 Paul Eggert <eggert@cs.ucla.edu>
300
89a438bd
PE
301 Do not create empty overlays with the evaporate property (Bug#9642).
302 * buffer.c (Fmove_overlay): Delete an evaporating overlay
303 if it becomes empty after its bounds are adjusted to fit within
304 its buffer. Without this fix, in a nonempty buffer (let ((o
305 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
306 yields an empty overlay that has the evaporate property, which is
307 not supposed to happen.
308
1068fe4d
PE
309 Fix minor GTK3 problems found by static checking.
310 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
311 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
312 (struct _EmacsFixedClass, emacs_fixed_get_type):
313 Move decls here from emacsgtkfixed.h, since they needn't be public.
314 (emacs_fixed_get_type): Now static.
315 (emacs_fixed_class_init): Omit unused local.
316 (emacs_fixed_child_type): Remove; unused.
317 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
318 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
319 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
320 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
321 (EMACS_FIXED_GET_CLASS): Remove; unused.
322 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
323
888bec30
PE
324 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
325 Problem reported by Juanma Barranquero for Windows -Wunused-function.
326
de85e130
PE
3272012-04-22 Paul Eggert <eggert@cs.ucla.edu>
328
d0baac98
PE
329 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
330 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
331 (__malloc_size_t, __malloc_ptrdiff_t):
332 Remove. All uses removed, replaced by the definiens if needed,
333 since we can assume C89 or better now.
334 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
335 (protect_malloc_state, align, get_contiguous_space)
336 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
337 (malloc_atfork_handler_child, malloc_enable_thread)
338 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
339 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
340 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
341 (special_realloc, _realloc_internal_nolock, _realloc_internal)
342 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
343 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
344 Define using prototypes, not old style.
345 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
346 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
347 (align): Don't assume that signed integer overflow wraps around.
348 Omit unused local var.
349 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
350 (_free_internal_nolock, memalign, mallochook, reallochook):
351 Omit no-longer-needed casts.
352 (valloc): Use getpagesize, not __getpagesize.
353 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
354 (struct hdr): The 'magic' member is now size_t, not unsigned long.
355
de85e130
PE
356 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
357
dcbf5805
MA
3582012-04-22 Michael Albinus <michael.albinus@gmx.de>
359
360 Move functions from C to Lisp. Make non-blocking method calls
361 the default. Implement further D-Bus standard interfaces.
362
363 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
364 (QCdbus_request_name_allow_replacement)
365 (QCdbus_request_name_replace_existing)
366 (QCdbus_request_name_do_not_queue)
367 (QCdbus_request_name_reply_primary_owner)
368 (QCdbus_request_name_reply_in_queue)
369 (QCdbus_request_name_reply_exists)
370 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
371 (QCdbus_registered_serial, QCdbus_registered_method)
372 (QCdbus_registered_signal): New Lisp objects.
373 (XD_DEBUG_MESSAGE): Use sizeof.
374 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
375 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
376 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
377 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
378 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
379 (xd_signature, xd_append_arg): Allow float for integer types.
380 (xd_get_connection_references): New function.
b593d6a9
AH
381 (xd_get_connection_address): Rename from xd_initialize.
382 Return cached address.
dcbf5805
MA
383 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
384 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
385 level.
386 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 387 Return number of refcounts.
dcbf5805
MA
388 (Fdbus_get_unique_name): Make stronger parameter check.
389 (Fdbus_message_internal): New defun.
390 (Fdbus_call_method, Fdbus_call_method_asynchronously)
391 (Fdbus_method_return_internal, Fdbus_method_error_internal)
392 (Fdbus_send_signal, Fdbus_register_service)
393 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
394 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
395 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
396 (Vdbus_compiled_version, Vdbus_runtime_version)
397 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
398 (Vdbus_message_type_method_return, Vdbus_message_type_error)
399 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
400 (Vdbus_registered_buses, Vdbus_registered_objects_table):
401 Adapt docstring.
dcbf5805 402
52828e02
PE
4032012-04-22 Paul Eggert <eggert@cs.ucla.edu>
404
da05bc4c
PE
405 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
406 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
407 Do not assume ptrdiff_t is the same width as 'int'.
408
52828e02
PE
409 * alloc.c: Handle unusual debugging option combinations.
410 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
411 since the two debugging options are incompatible.
412 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
413 is defined.
414 (mem_init, mem_insert, mem_insert_fixup):
415 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
416 (NEED_MEM_INSERT): Remove; no longer needed.
417
f01769f9
LL
4182012-04-22 Leo Liu <sdl.web@gmail.com>
419
420 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
421
5790543d
PE
4222012-04-22 Paul Eggert <eggert@cs.ucla.edu>
423
424 * sysdep.c [__FreeBSD__]: Minor cleanups.
425 (list_system_processes, system_process_attributes) [__FreeBSD__]:
426 Use Emacs indenting style more consistently. Avoid some casts.
427 Use 'double' consistently rather than mixing 'float' and 'double'.
428
b91b7e4d
EW
4292012-04-21 Eduard Wiebe <usenet@pusto.de>
430
b593d6a9
AH
431 * sysdep.c (list_system_processes, system_process_attributes):
432 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 433
6114eb15
AS
4342012-04-21 Andreas Schwab <schwab@linux-m68k.org>
435
436 * lisp.mk (lisp): Update.
437
2f38dff7
PE
4382012-04-20 Paul Eggert <eggert@cs.ucla.edu>
439
440 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
441 It is never used otherwise.
442
4ae29f89
SM
4432012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
444
445 * print.c (print_preprocess): Only check print_depth if print-circle
446 is nil.
447 (print_object): Check for cycles even when print-circle is nil and
448 print-gensym is t, but only check print_depth if print-circle is nil.
449
f30d612a
CY
4502012-04-20 Chong Yidong <cyd@gnu.org>
451
452 * process.c (wait_reading_process_output): If EIO occurs on a pty,
453 set the status to "failed" and ensure that sentinel is run.
454
c07a4c0b 4552012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
456
457 * process.c (Fset_process_inherit_coding_system_flag)
458 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 459 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 460
c07a4c0b 4612012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
462
463 * xdisp.c (string_buffer_position_lim): Limit starting position to
464 BEGV.
465 (set_cursor_from_row): If called for a mode-line or header-line
466 row, return zero immediately.
467 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
468 farther than the first row after the header line, if any.
469 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
470 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
471
c07a4c0b 4722012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 473
4ae29f89
SM
474 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
475 (bug#11238).
ad3a2b41 476
c07a4c0b 4772012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 4782012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
479
480 configure: new option --enable-gcc-warnings (Bug#11207)
481 * Makefile.in (C_WARNINGS_SWITCH): Remove.
482 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
483 (ALL_CFLAGS): Use new macros rather than old.
484 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
485 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
486 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
487 -Wunused-result, -Wunused-variable. This should go away once
488 the Emacs and Gnulib regex code is merged.
489 (xmalloc, xrealloc): Now static.
490
aba027e8
PE
4912012-04-17 Paul Eggert <eggert@cs.ucla.edu>
492
493 * dired.c (Fsystem_groups): Remove unused local.
494
e5a36063
GM
4952012-04-17 Glenn Morris <rgm@gnu.org>
496
497 * dired.c (Fsystem_users): Doc fix.
498
316411f0
DA
4992012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
500
501 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
502 (syms_of_dired): Add them.
503
9426aba4
PE
5042012-04-16 Paul Eggert <eggert@cs.ucla.edu>
505
b62a57be
PE
506 Fix minor alloc.c problems found by static checking.
507 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
508 New extern decls, to avoid calling undeclared functions.
509 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
510 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
511 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
512 (NEED_MEM_INSERT): New macro.
513 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 514 Remove one incorrect comment and fix another.
b62a57be 515
3539f31f
PE
516 Fix minor ralloc.c problems found by static checking.
517 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
518 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
519 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
520 (r_alloc_sbrk): Now static.
521
a041960a
PE
522 Improve ralloc.c interface checking.
523 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
524 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
525 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
526 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
527 [REL_ALLOC]: ... to here, to check interface.
528 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
529 Remove decls. This fixes an "It stinks!".
530
9426aba4
PE
531 * alloc.c (which_symbols): Fix alignment issue / type clash.
532
d55c12ed
AS
5332012-04-15 Andreas Schwab <schwab@linux-m68k.org>
534
535 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
536 (struct Lisp_Misc_Any): Likewise.
537 (struct Lisp_Free): Likewise.
538 * alloc.c (union aligned_Lisp_Symbol): Define.
539 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
540 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
541 (union aligned_Lisp_Misc): Define.
542 (MARKER_BLOCK_SIZE, struct marker_block): Use union
543 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 544 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 545
b948ce8b
PE
5462012-04-14 Paul Eggert <eggert@cs.ucla.edu>
547
548 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
549 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
550 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
551 * s/netbsd.h, s/sol2-6.h:
552 Remove definition of GC_MARK_STACK, since the default now works.
553 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
554 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
555 no longer the default.
556 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
557
35dc09a1 5582012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 559
35dc09a1
GM
560 * lread.c (lisp_file_lexically_bound_p):
561 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 562
35dc09a1
GM
5632012-04-14 Eli Zaretskii <eliz@gnu.org>
564
565 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
566 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
567
5682012-04-14 Jan Djärv <jan.h.d@swipnet.se>
569
570 * nsterm.m (constrainFrameRect): Always constrain when there is only
571 one screen (Bug#10962).
572
bcd86815
KB
5732012-04-13 Ken Brown <kbrown@cornell.edu>
574
575 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
576
c25df26e
RT
5772012-04-13 Reuben Thomas <rrt@sc3d.org>
578
579 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
580
0fc59f1e
DC
5812012-04-11 Daniel Colascione <dancol@dancol.org>
582
583 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
584 against is gone. It's better to use vfork now so that when Cygwin
585 gains a new, working vfork, we use it automatically (bug#10398).
586
de8c03dc
SM
5872012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
588
589 * window.c (save_window_save): Obey window-point-insertion-type.
590
2f097256
GM
5912012-04-11 Glenn Morris <rgm@gnu.org>
592
593 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
594
453b951e
SM
5952012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
596
597 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
598
75f1671a 5992012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
600
601 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
602 (force_quit_count): New var.
603 (handle_interrupt): Use it.
604
2a8ce227
JB
6052012-04-10 Juanma Barranquero <lekktu@gmail.com>
606
607 * w32.c (w32_delayed_load): Record the full path of the library
608 being loaded (bug#10424).
609
935396c0
GM
6102012-04-09 Glenn Morris <rgm@gnu.org>
611
05920a43
GM
612 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
613 not just in the obarray, before snarfing them. (Bug#11036)
614
935396c0
GM
615 * Makefile.in ($(leimdir)/leim-list.el):
616 Pass EMACS rather than BUILT_EMACS.
617
a18ecafa
TZ
6182012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
619
620 * process.c (make_process):
621 * process.h: Add integer `gnutls_handshakes_tried' member to
622 process struct.
623
6bbef4e5
JC
624 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
625 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
626
627 * gnutls.c (gnutls_log_function2i): Convenience log function.
628 (emacs_gnutls_read): Use new log functions,
629 `gnutls_handshakes_tried' process member, and
630 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
631 attempts per process (connection).
632
b4d3bc10
CY
6332012-04-09 Chong Yidong <cyd@gnu.org>
634
635 * eval.c (Fuser_variable_p, user_variable_p_eh)
636 (lisp_indirect_variable): Functions deleted.
637 (Fdefvar): Caller changed.
638
639 * callint.c (Finteractive, Fcall_interactively):
640 * minibuf.c (Fread_variable): Callers changed.
641
70f4d973
EZ
6422012-04-09 Eli Zaretskii <eliz@gnu.org>
643
644 * xdisp.c (set_cursor_from_row): If the display string appears in
645 the buffer at position that is closer to point than the position
646 after the display string, display the cursor on the first glyph of
647 the display string. Fixes cursor display when a 'display' text
648 property immediately follows invisible text. (Bug#11094)
649
cb3c2e3e
PE
6502012-04-09 Paul Eggert <eggert@cs.ucla.edu>
651
652 composite.c: use 'double' consistently
653 * composite.c (get_composition_id): Use 'double' consistently
654 instead of converting 'float' to 'double' and vice versa; this is
655 easier to understand and avoids a GCC warning.
656
fd06db5d
GM
6572012-04-09 Glenn Morris <rgm@gnu.org>
658
50fe702a
GM
659 * Makefile.in: Generate leim-list with bootstrap-emacs, in
660 preparation for dumping it with emacs. (Bug#4789)
661 (leimdir): New variable.
662 ($(leimdir)/leim-list.el): New rule.
663 (emacs$(EXEEXT)): Depend on leim-list.el.
664
fd06db5d
GM
665 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
666 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
667 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
668
55c131ee
AS
6692012-04-08 Andreas Schwab <schwab@linux-m68k.org>
670
671 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
672 proper alignment.
673
9209588f
JB
6742012-04-07 Juanma Barranquero <lekktu@gmail.com>
675
676 * xml.c (init_libxml2_functions) [WINDOWSNT]:
677 Remove unused local variable.
678
e3fb2efb
PE
6792012-04-07 Paul Eggert <eggert@cs.ucla.edu>
680
681 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
682 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
683 (mark_memory): Mark Lisp_Objects only if pointers might hide in
684 objects, as mark_maybe_pointer will catch them otherwise.
685 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
686 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
687
b5385551
PE
6882012-04-07 Paul Eggert <eggert@cs.ucla.edu>
689
690 Fix typo that broke non-Windows builds.
691 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
692
9078ead6
EZ
6932012-04-07 Eli Zaretskii <eliz@gnu.org>
694
695 Support building on MS-Windows with libxml2.
696
697 * makefile.w32-in (OBJ2): Add xml.$(O).
698 (GLOBAL_SOURCES): Add xml.c.
699 ($(BLD)/xml.$(O)): New dependency list.
700
701 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
702 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
703 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
704 [!WINDOWSNT]: New macros.
705 (init_libxml2_functions, libxml2_loaded_p): New functions.
706 (parse_region): Call fn_xmlCheckVersion instead of using the macro
707 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
708 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
709 Calls xmlCleanupParser only if libxml2 was loaded (or statically
710 linked in).
6bbef4e5
JC
711 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
712 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
713 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
714
715 * emacs.c: Don't include libxml/parser.h.
716 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
717 xmlCleanupParser directly.
718
719 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
720
3811fdf3
EZ
7212012-04-07 Eli Zaretskii <eliz@gnu.org>
722
723 * indent.c (Fvertical_motion): If there is a display string at
724 point, use it.vpos to compute how many lines to backtrack after
725 move_it_to point. (Bug#11133)
726
2f8e16b2
EZ
7272012-04-06 Eli Zaretskii <eliz@gnu.org>
728
729 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
730 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
731 about subtle differences between FETCH_CHAR* and STRING_CHAR*
732 macros related to unification of CJK characters. For the details,
733 see the discussion following the message here:
734 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
735
3d439cd1
CY
7362012-04-04 Chong Yidong <cyd@gnu.org>
737
738 * keyboard.c (Vdelayed_warnings_list): Doc fix.
739
8bc53d00
EZ
7402012-04-01 Eli Zaretskii <eliz@gnu.org>
741
742 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
743 instead of alloca. (Bug#11138)
744
3b0512a3
AS
7452012-04-01 Andreas Schwab <schwab@linux-m68k.org>
746
747 * w32menu.c (is_simple_dialog): Properly check lisp types.
748 (Bug#11141)
749
8427ddd2
EZ
7502012-03-31 Eli Zaretskii <eliz@gnu.org>
751
979022ef
EZ
752 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
753 position we get to after a call to move_it_to fails the
754 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
755 only if we wind up in a string from display property. (Bug#11063)
756
a6b1c7cc
EZ
757 * window.c (Fdelete_other_windows_internal): Invalidate the row
758 and column information about mouse highlight, so that redisplay
759 restores it after reallocating the glyph matrices. (Bug#7464)
760
8427ddd2
EZ
761 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
762 string comes from a `display' text property, use the buffer
763 position of that property as if we actually saw that position in
764 the row's glyphs.
697ba24b
EZ
765 (move_it_by_lines): Remove the assertion that
766 "it->current_x == 0 && it->hpos == 0" which can be legitimately
767 violated when there's a before-string at the beginning of a line.
768 (Bug#11063)
8427ddd2 769
65a0a738
EZ
7702012-03-30 Eli Zaretskii <eliz@gnu.org>
771
772 * xdisp.c (append_space_for_newline): If the default face was
773 remapped, use the remapped face for the appended newline.
774 (extend_face_to_end_of_line): Use the remapped default face for
775 extending the face to the end of the line.
776 (display_line): Call extend_face_to_end_of_line when the default
777 face was remapped. (Bug#11068)
778
581355cc
EZ
7792012-03-29 Eli Zaretskii <eliz@gnu.org>
780
781 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
782
e8fc049f
SM
7832012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
784
785 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
786
4fb9a543
GM
7872012-03-27 Glenn Morris <rgm@gnu.org>
788
789 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
790 Doc fixes.
791
679910f1
KH
7922012-03-26 Kenichi Handa <handa@m17n.org>
793
794 * dispextern.h (struct glyph): Fix previous change. Change the
795 bit length of glyphless.ch to 25 (Bug#11082).
796
90d49b7f
CY
7972012-03-26 Chong Yidong <cyd@gnu.org>
798
799 * keyboard.c (Vselection_inhibit_update_commands): New variable.
800 (command_loop_1): Use it; inhibit selection update for
801 handle-select-window too (Bug#8996).
802
f514f6f0
FP
8032012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
804
e8fc049f 805 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 806
bf43fa51
KH
8072012-03-25 Kenichi Handa <handa@m17n.org>
808
809 * dispextern.h (struct glyph): Change the bit length of
810 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
811
8a0c01dd
EZ
8122012-03-24 Eli Zaretskii <eliz@gnu.org>
813
814 * s/ms-w32.h (tzname): Include time.h before redirecting to
815 _tzname. Fixes the MSVC build. (Bug#9960)
816
7d1c3a76
AS
8172012-03-24 Andreas Schwab <schwab@linux-m68k.org>
818
8ed79523
AS
819 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
820 characters.
821
7d1c3a76
AS
822 * xterm.c (XTread_socket): Only modify handling_signal if
823 !SYNC_INPUT. (Bug#11080)
824
e99a9b8b
EZ
8252012-03-23 Eli Zaretskii <eliz@gnu.org>
826
827 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
828 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
829 when fetching a multibyte character consumes more bytes than
830 CHAR_BYTES returns, due to unification of CJK characters in
831 string_char. (Bug#11073)
832
5063c0e1
TN
8332012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
834
835 * process.c (wait_reading_process_output): Handle pty disconnect
836 by refraining from sending oneself a SIGCHLD (bug#10933).
837
9f851fbd
CY
8382012-03-22 Chong Yidong <cyd@gnu.org>
839
840 * dispextern.h (struct it): New member string_from_prefix_prop_p.
841
5063c0e1 842 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
843 Mark string as coming from a prefix property.
844 (handle_face_prop): Use default face for prefix strings (Bug#4281).
845 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
846
fb5b8aca
CY
8472012-03-21 Chong Yidong <cyd@gnu.org>
848
849 * xfaces.c (Vface_remapping_alist): Doc fix.
850
62356a1b
EZ
8512012-03-20 Eli Zaretskii <eliz@gnu.org>
852
853 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
854 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
855 Doc fixes.
62356a1b 856
025de85b
CY
8572012-03-20 Chong Yidong <cyd@gnu.org>
858
859 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
860 to reflect default non-nil value of redisplay-dont-pause.
861
4827f94e
KH
8622012-03-19 Kenichi Handa <handa@m17n.org>
863
864 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
865 it fit in a valid range (Bug#11003).
866
e50a24a2
EZ
8672012-03-18 Eli Zaretskii <eliz@gnu.org>
868
869 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
870 that is not from display property, accept the row as a "cursor
871 row" if one of the string's character has a non-nil `cursor'
872 property. Fixes cursor positioning when there are newlines in
873 overlay strings, e.g. in icomplete.el. (Bug#11035)
874
9af5ed87
PE
8752012-03-12 Paul Eggert <eggert@cs.ucla.edu>
876
877 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
878
d1f55f16
CY
8792012-03-12 Chong Yidong <cyd@gnu.org>
880
881 * eval.c (inhibit_lisp_code): Rename from
882 inhibit_window_configuration_change_hook; move from window.c.
883
884 * xfns.c (unwind_create_frame_1, Fx_create_frame):
885 * window.c (run_window_configuration_change_hook)
886 (syms_of_window): Callers changed.
887
66c5eebd
CY
8882012-03-11 Chong Yidong <cyd@gnu.org>
889
413df973
CY
890 * keymap.c (Fkey_description): Doc fix (Bug#9700).
891
66c5eebd
CY
892 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
893
1de11f56
CY
8942012-03-10 Chong Yidong <cyd@gnu.org>
895
896 * frame.c (other_visible_frames): Don't assume the selected frame
897 is visible (Bug#10955).
898
cae07000
SM
8992012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
900
901 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
902
89c94350
JD
9032012-03-08 Jan Djärv <jan.h.d@swipnet.se>
904
905 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
906 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
907 zero (Bug#10954).
908
999dd333
GM
9092012-03-03 Glenn Morris <rgm@gnu.org>
910
01a6dcc8 911 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 912
de0100f2
EZ
9132012-03-02 Eli Zaretskii <eliz@gnu.org>
914
915 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
916 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
917 (redisplay_window, next_element_from_string): Fix typos in
918 comments.
3e441275
EZ
919 (redisplay_window): Pass to move_it_vertically the margin in
920 pixels, not in screen lines.
de0100f2 921
96a72ee9
GM
9222012-03-02 Glenn Morris <rgm@gnu.org>
923
924 * buffer.c (buffer-list-update-hook): Doc fix.
925
312508d7
EZ
9262012-02-29 Eli Zaretskii <eliz@gnu.org>
927
928 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
929 push_it before setting up the iterator for the first overlay
930 string, even if we have an empty string loaded.
931 (next_overlay_string): If there's an empty string on the iterator
932 stack, pop the stack. (Bug#10903)
933
27f3c637
PE
9342012-02-25 Paul Eggert <eggert@cs.ucla.edu>
935
936 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
937 Suggested by Stefan Monnier in
938 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
939 * alloc.c (widen_to_Lisp_Object): New static function.
940 (mark_memory): Also mark Lisp_Objects by fetching pointer words
941 and widening them to Lisp_Objects. This would work even if
942 USE_LSB_TAG is defined and wide integers are used, which might
943 happen in a future version of Emacs.
944
3c9dfce6
CY
9452012-02-25 Chong Yidong <cyd@gnu.org>
946
fa74b241
CY
947 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
948 Doc fix.
949
3c9dfce6
CY
950 * xselect.c (Fx_selection_exists_p): Doc fix.
951 (x_clipboard_manager_save_all): Print an informative message
952 before saving to clipboard manager.
953
9486df08
CY
9542012-02-24 Chong Yidong <cyd@gnu.org>
955
956 * keyboard.c (process_special_events): Handle all X selection
957 requests in kbd_buffer, not just the next one (Bug#8869).
958
f01d3321
CY
9592012-02-23 Chong Yidong <cyd@gnu.org>
960
961 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
962 call when setting menu-bar-lines and tool-bar-lines parameters.
963 (unwind_create_frame_1): New helper function.
964
965 * window.c (inhibit_window_configuration_change_hook): New var.
966 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 967 (syms_of_window): Initialize it.
f01d3321 968
86b847b6
CY
9692012-02-22 Chong Yidong <cyd@gnu.org>
970
971 * xterm.c (x_draw_image_relief): Add missing type check for
972 Vtool_bar_button_margin (Bug#10743).
973
a59225b1
CY
9742012-02-21 Chong Yidong <cyd@gnu.org>
975
976 * fileio.c (Vfile_name_handler_alist): Doc fix.
977
978 * buffer.c (Fget_file_buffer): Protect against invalid file
979 handler return value.
980
310f5bd4
PE
9812012-02-20 Paul Eggert <eggert@cs.ucla.edu>
982
cb3a28cc
PE
983 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
984 when computing $valmask.
985
310f5bd4
PE
986 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
987 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
988 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
989 It's useless in that case, and it can cause problems on hosts
990 that allocate halves of EMACS_INT values separately.
991 Reported by Dan Horák. Diagnosed by Andreas Schwab in
992 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
993 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
994 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
995 it avoids undefined behavior on hosts where shifting right by more
996 than the word width has undefined behavior.
997
2375c96a
CY
9982012-02-19 Chong Yidong <cyd@gnu.org>
999
1000 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1001 (Funhandled_file_name_directory, Ffile_name_as_directory)
1002 (Fdirectory_file_name, Fexpand_file_name)
1003 (Fsubstitute_in_file_name): Protect against invalid file handler
1004 return values (Bug#10845).
1005
3eb49e71
EZ
10062012-02-18 Eli Zaretskii <eliz@gnu.org>
1007
1008 * .gdbinit (pitx): Fix incorrect references to fields of the
1009 iterator stack.
1010
7b926f3f
CY
10112012-02-17 Chong Yidong <cyd@gnu.org>
1012
1013 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1014
11273115
PE
10152012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1016
1017 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1018 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1019
c3a70e2b
CY
10202012-02-15 Chong Yidong <cyd@gnu.org>
1021
1022 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1023 marked as special. Also, starting docstrings with * is obsolete.
1024
0ca43699
AS
10252012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1026
1027 * gnutls.c (emacs_gnutls_write): Fix last change.
1028
2e8f3c56
LI
10292012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1030
1031 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1032 send_process.
1033
af70074f
SM
10342012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1035
1036 * keymap.c (Fsingle_key_description): Handle char ranges.
1037
95986d52
CY
10382012-02-12 Chong Yidong <cyd@gnu.org>
1039
afd83bd1
CY
1040 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1041 as that creates a dangerous corner case.
1042
95986d52
CY
1043 * window.c (Fdelete_window_internal): Invalidate the mouse
1044 highlight (Bug#9904).
1045
bd7da63e
GM
10462012-02-12 Glenn Morris <rgm@gnu.org>
1047
1048 * xselect.c (Fx_own_selection_internal)
1049 (Fx_get_selection_internal, Fx_disown_selection_internal)
1050 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1051 * nsselect.m (Fx_own_selection_internal)
1052 (Fx_disown_selection_internal, Fx_selection_exists_p)
1053 (Fx_selection_owner_p, Fx_get_selection_internal):
1054 Sync docs and argument specs with the xselect.c versions.
1055
77abcbc2
LI
10562012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1057
1058 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1059
90b671e2
EZ
10602012-02-11 Eli Zaretskii <eliz@gnu.org>
1061
1c0ca0b7
EZ
1062 * w32select.c (Fx_selection_exists_p): Sync doc string and
1063 argument list with xselect.c. (Bug#10783)
1064
1065 * w16select.c (Fx_selection_exists_p): Sync doc string and
1066 argument list with xselect.c. (Bug#10783)
90b671e2 1067
49241268
GM
10682012-02-10 Glenn Morris <rgm@gnu.org>
1069
1070 * fns.c (Fsecure_hash): Doc fix.
1071
f998bbe7 10722012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
1073
1074 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
1075
0992bd9c
CY
10762012-02-07 Chong Yidong <cyd@gnu.org>
1077
1078 * buffer.c (Fbuffer_local_variables)
1079 (buffer_lisp_local_variables): Handle unbound vars correctly;
1080 don't let Qunbound leak into Lisp.
1081
af008560
GM
10822012-02-07 Glenn Morris <rgm@gnu.org>
1083
dd605cc4
GM
1084 * image.c (Fimagemagick_types): Doc fix.
1085
af008560
GM
1086 * image.c (imagemagick-render-type): Change it from a lisp object
1087 to an integer. Move the doc here from the lisp manual.
1088 Treat all values not equal to 0 the same.
1089
1449fa1d
CY
10902012-02-06 Chong Yidong <cyd@gnu.org>
1091
1092 * doc.c (store_function_docstring): Avoid applying docstring of
1093 alias to base function (Bug#2603).
1094
3723ec07
AS
10952012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1096
1097 * .gdbinit (pp1, pv1): Remove redundant defines.
1098 (pr): Use pp.
1099
79c1cc1e
CY
11002012-02-04 Chong Yidong <cyd@gnu.org>
1101
1102 * nsterm.m: Declare a global (Bug#10694).
1103
d7f29f8e
EZ
11042012-02-04 Eli Zaretskii <eliz@gnu.org>
1105
cae07000
SM
1106 * w32.c (get_emacs_configuration_options):
1107 Include --enable-checking, if specified, in the return value.
d7f29f8e 1108
3b95a6f9
MR
11092012-02-04 Martin Rudalics <rudalics@gmx.at>
1110
1111 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1112 after rounding frame sizes. (Bug#9723)
1113
d6fa96a6
EZ
11142012-02-04 Eli Zaretskii <eliz@gnu.org>
1115
1116 * keyboard.c (adjust_point_for_property): Don't position point
1117 before BEGV. (Bug#10696)
1118
df0b2940
PE
11192012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1120
1121 Handle overflow when computing char display width (Bug#9496).
1122 * character.c (char_width): Return EMACS_INT, not int.
1123 (char_width, c_string_width): Check for overflow when
1124 computing the width; this is possible now that individual
1125 characters can have unbounded width. Problem introduced
1126 by merge from Emacs 23 on 2012-01-19.
1127
6bee44d6
MA
11282012-02-02 Michael Albinus <michael.albinus@gmx.de>
1129
1130 * dbusbind.c (Fdbus_register_method): Mention the return value
1131 :ignore in the docstring.
1132
44f92739
GM
11332012-02-02 Glenn Morris <rgm@gnu.org>
1134
1b9f60cc
GM
1135 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1136
44f92739
GM
1137 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1138 Unconditionally set to t. (Bug#10673)
1139 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1140 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1141 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1142
c5d3843c
KH
11432012-02-02 Kenichi Handa <handa@m17n.org>
1144
1145 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1146 0, do not call append_composite_glyph.
1147
159462d4 11482012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
1149
1150 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1151 NULL (Bug#6988).
1152 (x_produce_glyphs): If the component of a composition is a null
1153 string, set it->pixel_width to 1 to avoid zero-width glyph.
1154
78cef877
EZ
11552012-02-01 Eli Zaretskii <eliz@gnu.org>
1156
1157 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1158 first 2 arguments are identical. This makes inserting large
1159 output from a subprocess an order of magnitude faster on
1160 MS-Windows, where all sbrk'ed memory is always contiguous.
1161
97897668
GM
11622012-01-31 Glenn Morris <rgm@gnu.org>
1163
1164 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 1165 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
1166 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1167
31fd3586
GM
11682012-01-29 Glenn Morris <rgm@gnu.org>
1169
1170 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1171
0e24a8b2
CY
11722012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1173
1174 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1175
cc0adcb0
CY
11762012-01-28 Chong Yidong <cyd@gnu.org>
1177
1178 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1179
acc28cb9
CY
11802012-01-26 Chong Yidong <cyd@gnu.org>
1181
9c69cfb7
CY
1182 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1183
acc28cb9
CY
1184 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1185 repeat counts (Bug#10507).
1186
48da7392
GM
11872012-01-26 Glenn Morris <rgm@gnu.org>
1188
1189 * lread.c (syms_of_lread): Doc fix.
1190
14af5f7f
CY
11912012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1192
1193 * coding.c (encode_designation_at_bol): Change return value to
1194 EMACS_INT.
1195
0b21c100
CY
11962012-01-25 Chong Yidong <cyd@gnu.org>
1197
1198 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1199
3c2907f7
CY
12002012-01-21 Chong Yidong <cyd@gnu.org>
1201
1202 * floatfns.c (Fcopysign): Make the second argument non-optional,
1203 since nil is not allowed anyway.
1204
959ad23f
AS
12052012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1206
1207 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1208 (send_process): Likewise.
1209
34a02f46
MR
12102012-01-19 Martin Rudalics <rudalics@gmx.at>
1211
1212 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
1213 (Vwindow_persistent_parameters): Do not use Qstate.
1214 Rewrite doc-strings.
34a02f46 1215
1259009a 12162012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
1217
1218 * character.c (char_width): New function.
70d4fdf6
GM
1219 (Fchar_width, c_string_width, lisp_string_width):
1220 Use char_width (Bug#9496).
25ed9e61 1221
6a6ee00d
MR
12222012-01-16 Martin Rudalics <rudalics@gmx.at>
1223
1224 * window.c (Vwindow_persistent_parameters): New variable.
1225 (Fset_window_configuration, save_window_save): Handle persistent
1226 window parameters.
1227
c85efaf7
EZ
12282012-01-14 Eli Zaretskii <eliz@gnu.org>
1229
1230 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1231 thrashing the stack of the thread. (Bug#9087)
1232
5944709e
PE
12332012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1234
1235 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1236
e71f5d99
EZ
12372012-01-11 Eli Zaretskii <eliz@gnu.org>
1238
1239 * xdisp.c (rows_from_pos_range): Handle the case where the
1240 highlight ends on a newline. (Bug#10464)
1241 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1242 he end column for display of highlight that ends on a newline
1243 before a R2L line.
1244
ce316182
GM
12452012-01-11 Glenn Morris <rgm@gnu.org>
1246
1247 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1248 from load-path also when installation-directory is nil. (Bug#10208)
1249
5b43da69
GM
12502012-01-10 Glenn Morris <rgm@gnu.org>
1251
74cc8ff9
GM
1252 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1253
7d8d6e4e
GM
1254 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1255 Update template values to be closer to their typical values these days.
5b43da69 1256
a0db8d43
EZ
12572012-01-09 Eli Zaretskii <eliz@gnu.org>
1258
1259 * xdisp.c (rows_from_pos_range): Accept additional argument
1260 DISP_STRING, and accept any glyph in a row whose object is that
1261 string as eligible for mouse highlight. Fixes mouse highlight of
1262 display strings from overlays. (Bug#10464)
1263
9a0115ab 12642012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 1265
b9110d6a 1266 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
1267 * fileio.c (auto_saving_dir_umask): New static var.
1268 (Fmake_directory_internal): Use it.
1269 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1270 creating the directory. The old code temporarily assigns
1271 too-generous permissions to the directory.
1272 (do_auto_save_eh): Clear it.
b9110d6a 1273 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
1274 that the var is always cleared.
1275
6c1bd3f3
EZ
12762012-01-07 Eli Zaretskii <eliz@gnu.org>
1277
1278 * search.c (scan_buffer): Pass character positions to
1279 know_region_cache, not byte positions. (Bug#6540)
1280
069d2b50
L
12812012-01-07 LynX <_LynX@bk.ru> (tiny change)
1282
1283 * w32.c (sys_rename): Report EXDEV when rename of a directory
1284 fails because the target is on another logical disk. (Bug#10284)
1285
75bf0d33
DB
12862012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1287
1288 * xterm.c (x_embed_request_focus): New function.
1289
1290 * xterm.h: Add prototype.
1291
1292 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1293
1c6e5a32
GM
12942012-01-05 Glenn Morris <rgm@gnu.org>
1295
1296 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1297
651e947e
EZ
12982012-01-01 Eli Zaretskii <eliz@gnu.org>
1299
1300 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1301 Load gnutls_transport_set_lowat only if GnuTLS version is below
1302 2.11.1.
1303 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1304 GnuTLS versions below 2.11.1.
1305
3778cdd8
AL
13062011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1307
1308 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1309 to the doc string advising against its use for altering the way
1310 windows are scrolled.
1311
0e5317f7
KH
13122011-12-28 Kenichi Handa <handa@m17n.org>
1313
1314 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1315 coding-system ASCII compatible only when it does not produce BOM
1316 on encoding (Bug#10383).
1317
93d5ca1f
JD
13182011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1319
1320 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1321 can scroll.
1322 (create_and_show_popup_menu): Always use menu_position_func for
1323 Gtk3 (Bug#10361).
1324
ca22b785
AS
13252011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1326
1327 * callint.c (Fcall_interactively): Don't truncate prompt string.
1328
d048e1e6
EZ
13292011-12-23 Eli Zaretskii <eliz@gnu.org>
1330
1331 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1332 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 1333 resumed from there (after widening). (Bug#10360)
d048e1e6 1334
5ccaba1f
JD
13352011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1336
1337 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1338
204ee57f
JD
13392011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1340
b81d40f0
JB
1341 * nsterm.m (x_free_frame_resources):
1342 Release f->output_data.ns->miniimage.
204ee57f
JD
1343 (ns_index_color): Fix indentation. Do not retain
1344 color_table->colors[i].
1345
1346 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1347 before returning.
1348
1349 * nsfns.m (x_set_background_color): Assign return value from
1350 ns_index_color to face-background instead of NSColor*.
1351 (ns_implicitly_set_icon_type): Fix indentation.
1352 Change assignment in for loop to comparison.
1353
1354 * emacs.c (ns_pool): New variable.
1355 (main): Assign ns_pool.
1356 (Fkill_emacs): Call ns_release_autorelease_pool.
1357
1358 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1359 autorelease fdesc, release fdAttrs and tdict.
1360 (ns_get_covering_families): Release charset.
1361 (ns_findfonts): Release NSFontDescriptor created with new.
1362 (ns_uni_to_glyphs): Fix indentation.
1363 (setString): Release attrStr before assigning new value.
1364
c803b2b7
JD
13652011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1366
678f4426
JD
1367 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1368 and NS_IMPL_COCOA.
1369 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1370 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1371
cd394be1 13722011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1373
5fecd5fc
JD
1374 * nsterm.m (ns_term_init): Subscribe for notifications
1375 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1376 to method trackingNotification in EmacsMenu.
1377
1378 * nsmenu.m (trackingMenu): New variable.
3771cb17 1379 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1380 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1381 from Aquamacs (Bug#7030).
678f4426
JD
1382
13832011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1384
c803b2b7
JD
1385 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1386 (symbol_to_nsstring): Fix indentation.
1387 (ns_symbol_to_pb): New function.
cae07000
SM
1388 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1389 (Fns_rotate_cut_buffers_internal): Remove.
1390 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1391 Fns_store_cut_buffer_internal.
1392 (ns_get_foreign_selection, Fx_own_selection_internal)
1393 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1394 (Fns_get_selection_internal, Fns_store_selection_internal):
1395 Use ns_symbol_to_pb and check if return value is nil.
1396 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1397 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1398 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1399 renamed to Sns_store_selection_internal.
1400 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1401 and remove this function.
1402 (ns_handle_selection_clear): Remove, never used.
1403 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1404 here.
1405
e1b01a3a
KB
14062011-12-17 Ken Brown <kbrown@cornell.edu>
1407
1408 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1409 GID is unknown (Bug#10257).
1410
2adb6e85
PE
14112011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1412
1413 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1414 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1415 which caused a build failure on GNU/Linux IA-64. This problem was
1416 introduced by my 2011-10-07 patch.
1417
d1d7b339
JL
14182011-12-15 Juri Linkov <juri@jurta.org>
1419
1420 * image.c (imagemagick_error): New function. (Bug#10112)
1421 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1422 Use `imagemagick_error' where ImageMagick functions return
1423 `MagickFalse'.
1424 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1425 proper order.
1426
100d5755
KH
14272011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1428
1429 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1430 fill background (Bug#8992).
1431
454592a6
MR
14322011-12-13 Martin Rudalics <rudalics@gmx.at>
1433
1434 * window.c (Vwindow_combination_resize)
1435 (Vwindow_combination_limit): Use t instead of non-nil in
1436 doc-strings.
61d4b438
MR
1437 (Vrecenter_redisplay): Add first sentence of doc-string on
1438 separate line.
53524d93 1439 (Frecenter): Fix doc-string typo.
454592a6 1440
3633e3aa
KH
14412011-12-11 Kenichi Handa <handa@m17n.org>
1442
1443 * coding.c (Funencodable_char_position): Pay attention to the
1444 buffer text relocation (Bug#9389).
1445
7b9d523a
JD
14462011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1447
1448 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1449 gtk_init (Bug#10100).
1450
b73189c6
EZ
14512011-12-10 Eli Zaretskii <eliz@gnu.org>
1452
1453 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1454 IT->string is nil. (Bug#10263)
1455
f7dfe5d6
JD
14562011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1457
83faebb4
JD
1458 * nsterm.h (x_free_frame_resources): Declare.
1459
f7dfe5d6
JD
1460 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1461 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1462
1463 * nsterm.h (ns_get_defaults_value): Declare.
1464
1465 * nsterm.m (ns_default): Call ns_get_defaults_value.
1466
7cd4e72c
EZ
14672011-12-09 Eli Zaretskii <eliz@gnu.org>
1468
1469 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1470 (Bug#10170)
1471
b34d7317
YM
14722011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1473
1474 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1475 that where the value of an _OBJC_* symbol points to is in the .bss
1476 section (Bug#10240).
1477
76470ad1
KH
14782011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1479
1480 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1481 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1482
745fff94
KH
14832011-12-08 Kenichi Handa <handa@m17n.org>
1484
1485 * ftfont.c (get_adstyle_property): Fix previous change
1486 (Bug#10233).
1487
6e44397c
JB
14882011-12-07 Juanma Barranquero <lekktu@gmail.com>
1489
1490 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1491 dirs from the default value of EMACSLOADPATH (bug#10208).
1492
7efa6272
GM
14932011-12-07 Glenn Morris <rgm@gnu.org>
1494
1495 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1496 installation and source directories as well. (Bug#10208)
1497
f6fc4d87
CY
14982011-12-06 Chong Yidong <cyd@gnu.org>
1499
1500 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1501
2bf26180
GM
15022011-12-06 Glenn Morris <rgm@gnu.org>
1503
1504 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1505 as an error, not just -1. (Bug#10217)
1506
3a6ad4f0
CY
15072011-12-05 Chong Yidong <cyd@gnu.org>
1508
1509 * keyboard.c (process_special_events): New function.
1510 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1511
75a3b399
PE
15122011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1513
1514 * coding.c (encode_designation_at_bol): Don't use uninitialized
1515 local variable (Bug#9318).
1516
c3c9e25e
KH
15172011-12-05 Kenichi Handa <handa@m17n.org>
1518
1519 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1520 return Qnil (Bug#8046, Bug#10193).
1521
5eb05ea3
KH
15222011-12-05 Kenichi Handa <handa@m17n.org>
1523
1524 * coding.c (encode_designation_at_bol): New args charbuf_end and
1525 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1526 (coding_set_source): Return how many bytes coding->source was
1527 relocated.
1528 (coding_set_destination): Return how many bytes
1529 coding->destination was relocated.
1530 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1531 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1532
15332011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1534
1535 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1536 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1537 macro (Bug#9318).
1538
15392011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1540
1541 The following changes are to fix Bug#9318.
1542
a79703f5 1543 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1544 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1545 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1546 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1547
7dbda6df
JB
15482011-12-05 Juanma Barranquero <lekktu@gmail.com>
1549
1550 * lisp.h (process_quit_flag): Fix external declaration.
1551
6d5eb5b0
SM
15522011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1553
1554 Don't macro-inline non-performance-critical code.
1555 * eval.c (process_quit_flag): New function.
1556 * lisp.h (QUIT): Use it.
1557
a0c3fad0
JD
15582011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1559
1560 * nsfns.m (get_geometry_from_preferences): New function.
1561 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1562
6c07aac2
AS
15632011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1564
1565 * emacs.c (Qkill_emacs): Define.
1566 (syms_of_emacs): Initialize it.
1567 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1568 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1569 (quit_throw_to_read_char): Add parameter `from_signal'.
1570 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1571 * lisp.h (QUIT): Call Fkill_emacs if requested.
1572
c052ead4
JD
15732011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1574
1575 * widget.c (update_wm_hints): Return if wmshell is null.
1576 (widget_update_wm_size_hints): New function.
1577
1578 * widget.h (widget_update_wm_size_hints): Declare.
1579
1580 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1581 widget_update_wm_size_hints (Bug#10104).
1582
9e49252b
EZ
15832011-12-03 Eli Zaretskii <eliz@gnu.org>
1584
1585 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1586 before a newline, prepare the bidi iterator for consuming the
1587 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1588 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1589
02b16839
JL
15902011-12-02 Juri Linkov <juri@jurta.org>
1591
1592 * search.c (Fword_search_regexp): New Lisp function created from
1593 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1594 (Fword_search_backward, Fword_search_forward)
1595 (Fword_search_backward_lax, Fword_search_forward_lax):
1596 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1597 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1598
0068070e
SM
15992011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1600
1601 * fileio.c (Finsert_file_contents): Move after-change-function call
1602 to before the "handled:" label, since all "goto handled" appear in
1603 cases where the *-change-functions have already been properly called
1604 (bug#10117).
1605
3360a3fc
AS
16062011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1607
1608 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1609 waiting for input. (Bug#10169)
1610
73d6c093
EZ
16112011-11-30 Eli Zaretskii <eliz@gnu.org>
1612
1613 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1614 verifies glyph row's hash code--we have just reallocated the
1615 glyphs, so their contents can be complete garbage. (Bug#10164)
1616
febe6bea
JB
16172011-11-30 Juanma Barranquero <lekktu@gmail.com>
1618
1619 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1620
801a4313
EZ
16212011-11-30 Eli Zaretskii <eliz@gnu.org>
1622
1623 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1624 attributes are tested _before_ calling verify_row_hash, to protect
1625 against GCC re-ordering of the tests. (Bug#10164)
1626
2b56b87e
JD
16272011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1628
1629 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1630
1631 * xterm.c (handle_one_xevent): Only set async_visible and friends
1632 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1633 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1634 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1635
dbf31225
PE
16362011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1637
1638 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1639 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1640 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1641 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1642 All uses changed to use GCPRO1 etc.
1643 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1644 Revert to old implementation (i.e., before 2011-03-11).
1645
1305621b
YM
16462011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1647
1648 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1649 of scroll runs so as to avoid assigning disabled bogus rows and
1650 unnecessary graphics copy operations.
1651
8c9afb46
EZ
16522011-11-27 Eli Zaretskii <eliz@gnu.org>
1653
1654 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1655 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1656 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1657 (malloc, free, realloc, calloc): Redirect to e_* only when
1658 compiling Emacs.
1659
1660 * lisp.h (GCTYPEBITS): Move before first use.
1661 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1662 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1663 this macro definition.
1664
1665 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1666 _MSC_VER.
1667
54e9e3bf
JD
16682011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1669
6d5eb5b0
SM
1670 * gtkutil.c (xg_create_frame_widgets):
1671 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1672 present with Gtk+ 2.0.
1673
83aca1cb
PE
16742011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1675
1676 * fileio.c (Finsert_file_contents): Undo previous change; see
1677 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1678
5b76caa4
PE
16792011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1680
1681 Rename locals to avoid shadowing.
1682 * fileio.c (Finsert_file_contents):
1683 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1684 * process.c (wait_reading_process_output):
1685 Rename inner 'proc' to 'p' to avoid shadowing.
1686 Indent for consistency with usual Emacs style.
1687
8c535114
EZ
16882011-11-25 Eli Zaretskii <eliz@gnu.org>
1689
1690 * xdisp.c (redisplay_window): If cursor row is not fully visible
1691 after recentering, and scroll-conservatively is set to a large
1692 number, scroll window by a few more lines to make the cursor fully
1693 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1694 (start_display): Don't move to the next line if the display should
1695 start at a newline that is part of a display vector or an overlay
1696 string. (Bug#10119)
8c535114 1697
fa4fdb5c
JL
16982011-11-24 Juri Linkov <juri@jurta.org>
1699
1700 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1701 after the `MagickPingImage' call. (Bug#10112)
1702
90ec88df
CY
17032011-11-23 Chong Yidong <cyd@gnu.org>
1704
1705 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1706
56e2e794
MR
17072011-11-23 Martin Rudalics <rudalics@gmx.at>
1708
1709 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1710 making another buffer current. (Bug#10114)
1711
b6e64c41
GM
17122011-11-23 Glenn Morris <rgm@gnu.org>
1713
1714 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1715
6b21de18
CY
17162011-11-23 Chong Yidong <cyd@gnu.org>
1717
1718 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1719 using it (Bug#5984).
1720
b12cd789
EZ
17212011-11-22 Eli Zaretskii <eliz@gnu.org>
1722
1723 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1724 and header-lines, as they don't have one computed for them.
1725 (Bug#10098)
1726
1727 * .gdbinit (prow): Make displayed values more self-explaining.
1728 Add row's hash code.
1729
261b6fd4
LMI
17302011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1731
1732 * process.c (wait_reading_process_output): Fix asynchrounous
1733 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1734 (wait_reading_process_output): Add comment and URL.
261b6fd4 1735
e7cfd277
JD
17362011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1737
1738 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1739
a9b9b7f5
CY
17402011-11-21 Chong Yidong <cyd@gnu.org>
1741
1742 * window.c (Fnext_window, Fprevious_window): Doc fix.
1743
b0d15b4f
SM
17442011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1745
1746 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1747
fe7a3057
JB
17482011-11-20 Juanma Barranquero <lekktu@gmail.com>
1749
1750 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1751
d2999b1a
MR
17522011-11-20 Martin Rudalics <rudalics@gmx.at>
1753
1754 * window.c (Fset_window_combination_limit): Rename argument
1755 STATUS to LIMIT.
1756 (Vwindow_combination_limit): Remove "status" from doc-string.
1757
d5ff9cd0
AS
17582011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1759
1760 * m/ibms390.h: Remove.
1761 * m/ibms390x.h: Don't include "ibms390.h".
1762
a5bb9bd3
SM
17632011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1764
1765 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1766 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1767
cd1181db
JB
17682011-11-20 Juanma Barranquero <lekktu@gmail.com>
1769
1770 * casetab.c (Fset_case_table):
1771 * charset.c (Fcharset_after): Fix typos.
1772
615a3b8d 17732011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1774
17e845af
PE
1775 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1776 Otherwise, valgrind does not work on some platforms.
1777 Problem reported by Andreas Schwab in
6a0bf43d
PE
1778 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1779 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1780 is set, removing the need for VIRT_ADDRESS_VARIES.
1781 (PURE_P): Use a more-efficient implementation that needs just one
1782 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1783 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1784 to 4 (xorl, subq, cmpq, setbe).
1785 * alloc.c (pure): Always extern now, since that's the
1786 VIRT_ADDR_VARIES behavior.
1787 (PURE_POINTER_P): Use a single comparison, not two, for
1788 consistency with the new puresize.h.
1789 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1790 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1791 Remove VIRT_ADDR_VARIES no longer needed.
1792
f8fe6f96
EZ
17932011-11-19 Eli Zaretskii <eliz@gnu.org>
1794
1795 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1796 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1797 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1798 behave as if the cursor position were at the window margin.
1799
1800 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1801 and the cursor position is out of bounds, behave as if the cursor
1802 position were at the window margin. (Bug#10075)
1803
df05a53c
CY
18042011-11-18 Chong Yidong <cyd@gnu.org>
1805
1806 * window.c (Fwindow_combination_limit): Make first argument
1807 non-optional, since it is meaningless for live windows like the
1808 selected window.
1809
2071918e
DA
18102011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1811
1812 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1813
b50a28de
SM
18142011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1815
1816 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1817 (graft_intervals_into_buffer): Simplify.
1818
015137db
EZ
18192011-11-18 Eli Zaretskii <eliz@gnu.org>
1820
1821 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1822 hash values of the two rows.
1823 (copy_row_except_pointers): Preserve the used[] arrays and the
1824 hash values of the two rows. (Bug#10035)
68c95424 1825 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1826
1827 * xdisp.c (row_hash): New function, body extracted from
1828 compute_line_metrics.
1829 (compute_line_metrics): Call row_hash, instead of computing the
1830 hash code inline.
1831
1832 * dispnew.c (verify_row_hash): Call row_hash for computing the
1833 hash code of a row, instead of duplicating code from xdisp.c.
1834
1835 * dispextern.h (row_hash): Add prototype.
1836
a2addb04
TH
18372011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1838
1839 * frame.c (delete_frame): Don't delete the terminal when the last
1840 X frame is closed if emacs is built with GTK toolkit.
1841
df85d315
JB
18422011-11-17 Juanma Barranquero <lekktu@gmail.com>
1843
1844 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1845
a0c2d0ae
MR
18462011-11-17 Martin Rudalics <rudalics@gmx.at>
1847
1848 * window.c (Vwindow_splits): Rename to
1849 Vwindow_combination_resize. Suggested by Juri Linkov.
1850 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1851 of Vwindow_splits.
1852
58179cce
JB
18532011-11-16 Juanma Barranquero <lekktu@gmail.com>
1854
7877f373
JB
1855 * nsfns.m (Fns_font_name):
1856 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1857
b6f67890
MR
18582011-11-16 Martin Rudalics <rudalics@gmx.at>
1859
1860 * window.h (window): Rename slot "nest" to "combination_limit".
1861 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1862 (Fset_window_nest): Rename to Fset_window_combination_limit.
1863 (Vwindow_nest): Rename to Vwindow_combination_limit.
1864 (recombine_windows, make_parent_window, make_window)
1865 (Fsplit_window_internal, saved_window)
1866 (Fset_window_configuration, save_window_save): Rename all
1867 occurrences of window_nest to window_combination_limit.
1868
c7015153
JB
18692011-11-15 Juanma Barranquero <lekktu@gmail.com>
1870
1871 * image.c (imagemagick_load_image): Fix typo.
1872
322ad6ec
EZ
18732011-11-14 Eli Zaretskii <eliz@gnu.org>
1874
1875 * xdisp.c (display_line): Move the call to
1876 highlight_trailing_whitespace before the call to
1877 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1878 faces of all the glyphs to compute ROW's hash value.
1879 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1880
f067b8ec
JB
18812011-11-14 Juanma Barranquero <lekktu@gmail.com>
1882
1883 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1884 just return (bug#10044).
1885
1e5b2111
EZ
18862011-11-12 Eli Zaretskii <eliz@gnu.org>
1887
7ef3cbd5
EZ
1888 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1889 with user-defined heap size. Bump the default size of the temacs
1890 heap to 27MB, to avoid memory warning when running temacs.
1891 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1892
1e5b2111
EZ
1893 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1894 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1895 (verify_row_hash) [XASSERTS]: New function.
1896 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1897 that the hash value of glyph rows is correct.
1e5b2111 1898
89d61221
MR
18992011-11-12 Martin Rudalics <rudalics@gmx.at>
1900
1901 * window.h (window): Remove splits slot.
1902 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1903 (Fdelete_other_windows_internal, make_parent_window)
1904 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1905 (Fset_window_configuration, save_window_save): Don't deal with
1906 split status of windows.
1907 (saved_window): Remove splits slot.
1908 (Vwindow_splits): Rewrite doc-string.
1909
97f18cc8
JD
19102011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1911
1912 * xfns.c (unwind_create_frame):
1913 * nsfns.m (unwind_create_frame):
1914 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1915 Vframe_list (Bug#9999).
1916
22a648b4
DA
19172011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1918
0b381c7e 1919 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1920
659afede
KH
19212011-11-11 Kenichi Handa <handa@m17n.org>
1922
1923 * callproc.c (Fcall_process): Set the member dst_multibyte of
1924 process_coding.
1925
9ac0394b
KH
19262011-11-11 Johan Bockgård <bojohan@gnu.org>
1927
1928 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1929 avoid a crash (bug#9496).
1930
2fbdc249
CY
19312011-11-09 Chong Yidong <cyd@gnu.org>
1932
1933 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1934 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1935
ac6b1f81
PE
19362011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1937
1938 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1939
09db192c
PE
19402011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1941
1942 Avoid some portability problems by eschewing 'extern inline' functions.
1943 The trivial performance wins aren't worth the portability hassles; see
1944 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1945 et seq.
1946 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1947 (window_box_width, window_box_left, window_box_left_offset)
1948 (window_box_right, window_box_right_offset): Undo previous change,
1949 by removing the "extern"s.
1950 * intervals.c (adjust_intervals_for_insertion)
1951 (adjust_intervals_for_deletion): Undo previous change,
1952 making these static again.
1953 (offset_intervals, temp_set_point_both, temp_set_point)
1954 (copy_intervals_to_string): No longer inline.
1955 * xdisp.c (window_text_bottom_y, window_box_width)
1956 (window_box_height, window_box_left_offset)
1957 (window_box_right_offset, window_box_left, window_box_right)
1958 (window_box): No longer inline.
1959
105216ed
CY
19602011-11-08 Chong Yidong <cyd@gnu.org>
1961
1962 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1963 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1964 Signal an error if not a live window.
105216ed
CY
1965 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1966 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1967
ae9e237f
JB
19682011-11-07 Juanma Barranquero <lekktu@gmail.com>
1969
1970 * lisp.h (syms_of_abbrev): Remove declaration.
1971 Reported by CHENG Gao <chenggao@royau.me>.
1972
c7aa8333
EZ
19732011-11-07 Eli Zaretskii <eliz@gnu.org>
1974
1975 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1976 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1977 of temacs in GUI mode.
1978
be7f5545
MR
19792011-11-07 Martin Rudalics <rudalics@gmx.at>
1980
1981 * window.h: Declare delete_all_child_windows instead of
1982 delete_all_subwindows.
1983 * window.c (Fwindow_nest, Fset_window_nest)
1984 (Fset_window_new_total, Fset_window_new_normal)
1985 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1986 (delete_all_subwindows): Rename to delete_all_child_windows.
1987 (Fdelete_other_windows_internal, Fset_window_configuration):
1988 Call delete_all_child_windows instead of delete_all_subwindows.
1989 * frame.c (delete_frame): Call delete_all_child_windows instead
1990 of delete_all_subwindows.
1991
ca78dc43
PE
19922011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1993
1994 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1995 This is also needed for porting to any host where GC_MARK_STACK is
1996 not GC_MAKE_GCPROS_NOOPS.
1997 (which_symbols): Use it.
1998
a0241d01
KH
19992011-11-07 Kenichi Handa <handa@m17n.org>
2000
2001 * coding.c (coding_set_destination): Check coding->src_pos only
2002 when coding->src_object is a buffer (bug#9910).
2003
2004 * process.c (send_process): Set the member src_multibyte of coding
2005 to 0 (bug#9911) when sending a unibyte text.
2006
2007 * callproc.c (Fcall_process): Set the member src_multibyte of
2008 process_coding to 0 (bug#9912).
2009
a64bfdfa 20102011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
2011
2012 * xmenu.c (cleanup_widget_value_tree): New function.
2013 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2014 calling free_menubar_widget_value_tree directly (Bug#9830).
2015
cb41b32a
PE
20162011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2017
2018 Fix some portability problems with 'inline'.
2019 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2020 (window_box_width, window_box_left, window_box_left_offset)
2021 (window_box_right, window_box_right_offset): Declare extern.
2022 Otherwise, these inline functions do not conform to C99 and
2023 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2024 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2025 * intervals.c (adjust_intervals_for_insertion)
2026 (adjust_intervals_for_deletion): Now extern, because otherwise the
2027 extern inline functions 'offset_intervals' couldn't refer to it.
2028 (static_offset_intervals): Remove.
2029 (offset_intervals): Rewrite using the old contents of
2030 static_offset_intervals. The old version didn't conform to C99
2031 because an extern inline function contained a reference to an
2032 identifier with static linkage.
2033
b7041366
AS
20342011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2035
2036 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2037 GC.
2038
88a37c4d
EZ
20392011-11-06 Eli Zaretskii <eliz@gnu.org>
2040
2041 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2042 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
2043 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
2044 return Qleft_to_right.
2045
49745b39
CY
20462011-11-06 Chong Yidong <cyd@gnu.org>
2047
2048 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2049 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2050 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2051 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
2052 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
2053 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2054 (Fwindow_vscroll): Doc fix.
2055 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2056 argument, since it makes no sense to pass a live window and for
2057 consistency with window-child.
2058
1f05cd82
CS
20592011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2060
2061 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2062 support MSVC.
2063
22610910
JR
20642011-11-05 Jason Rumney <jasonr@gnu.org>
2065
2066 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
2067 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
2068 fonts (Bug#6029).
2069 (add_font_entity_to_list): Fix logic errors in mixed boolean and
2070 bitwise arithmetic preventing use of unicode-sip and non-truetype
2071 opentype fonts.
2072
a06776b2
EZ
20732011-11-05 Eli Zaretskii <eliz@gnu.org>
2074
3ad924ba
EZ
2075 * s/ms-w32.h (fstat, stat, utime): Move redirections to
2076 "emacs"-only part.
2077
a06776b2
EZ
2078 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
2079 initialization code to keep similarity to xfns.c after changes
2080 from 2011-11-05.
2081
c9e7db78
JD
20822011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2083
a97f8f3f
JD
2084 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2085 (unwind_create_frame): New function (Bug#9943).
2086 (Fx_create_frame): Restructure code to be more similar to the one in
2087 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2088 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2089 Move terminal->reference_count++ just before making the frame official
2090 (Bug#9943).
2091
2092 * nsterm.m (x_free_frame_resources): New function.
2093 (x_destroy_window): Move code to x_free_frame_resources.
2094
c9e7db78 2095 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
2096 (Fx_create_frame, x_create_tip_frame):
2097 Move terminal->reference_count++ just before making the frame
75f1671a 2098 official. Move initialization of image_cache_refcount and
c9e7db78
JD
2099 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2100
a6fc3b5c
EZ
21012011-11-05 Eli Zaretskii <eliz@gnu.org>
2102
2103 Support MSVC build with newer versions of Visual Studio.
2104 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2105 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2106 nt/gmake.defs.
2107
2108 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2109 which are not supported by MSVC.
2110 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2111 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2112 bitfields.
2113 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2114 types in bitfields.
2115 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2116
2117 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2118
58179cce 21192011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
2120
2121 Support MSVC build with newer versions of Visual Studio.
2122 * w32.c: Don't include w32api.h for MSVC.
2123 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2124
2125 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2126 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2127 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2128 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2129 e_* cousins.
2130 (alloca) [_MSC_VER]: Define to _alloca.
2131
2132 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2133
2134 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2135
a58c13ed
EZ
21362011-11-04 Eli Zaretskii <eliz@gnu.org>
2137
2138 * xdisp.c (note_mouse_highlight): If either of
2139 previous/next-single-property-change returns nil, treat that as
2140 the beginning or the end of the buffer. (Bug#9955)
2141
fe0b6370
JD
21422011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2143
a58c13ed 2144 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
2145 label is not null (Bug#9951).
2146 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2147 may be NULL.
2148
89bd5ee1
EZ
21492011-11-04 Eli Zaretskii <eliz@gnu.org>
2150
2151 * window.c (Fwindow_body_size): Mention in the doc string that the
2152 return value is in frame's canonical units. (Bug#9949)
2153
84c3edb9
EZ
21542011-11-03 Eli Zaretskii <eliz@gnu.org>
2155
4e2fb5c7
EZ
2156 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2157
84c3edb9 2158 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 2159 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 2160 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 2161
bc17a887
EZ
21622011-11-01 Eli Zaretskii <eliz@gnu.org>
2163
2164 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2165 Don't stop backward scan on the continuation glyph, even though
2166 its CHARPOS is positive.
6d5eb5b0
SM
2167 (mouse_face_from_buffer_pos, note_mouse_highlight):
2168 Rename cover_string to disp_string.
bc17a887 2169
4ee88440
MR
21702011-11-01 Martin Rudalics <rudalics@gmx.at>
2171
2172 * window.c (temp_output_buffer_show): Don't use
2173 Vtemp_buffer_show_specifiers.
2174 (Vtemp_buffer_show_specifiers): Remove unused variable.
2175
c2ff3c02
EZ
21762011-10-30 Eli Zaretskii <eliz@gnu.org>
2177
2178 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2179 past the beginning of the current glyph matrix.
2180
58179cce 21812011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
2182
2183 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2184 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2185 HAVE_GTK3 (Bug#9869).
b77a6a7f 2186
3b574623
JD
2187 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2188 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2189
b77a6a7f
JD
2190 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2191
2192 * xterm.c: Declare x_handle_net_wm_state to return int.
2193 (handle_one_xevent): Check if we are iconified but don't have
2194 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2195 (get_current_wm_state): Return non-zero if not hidden,
2196 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2197 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2198 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2199 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2200
196e41e4
PE
22012011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2202
2203 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2204 so that this new function doesn't get optimized away by a
2205 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2206
021f2e1a
AS
22072011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2208
2209 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2210
8b058d44
EZ
22112011-10-29 Eli Zaretskii <eliz@gnu.org>
2212
2213 Fix the `xbytecode' command.
2214 * .gdbinit (xprintbytestr): New command.
b50a28de 2215 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
2216 (xbytecode): Print the byte-code string as well.
2217
4452fb80
EZ
22182011-10-29 Kim Storm <storm@cua.dk>
2219
8b058d44
EZ
2220 * alloc.c (which_symbols): New function.
2221
21b72067
AS
22222011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2223
2224 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2225 line. (Bug#9903)
2226
83ed7b5c
GM
22272011-10-29 Glenn Morris <rgm@gnu.org>
2228
2229 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2230 Not clear what it was for, and it causes various bugs. (Bug#9839)
2231
5a7a728b
EZ
22322011-10-28 Eli Zaretskii <eliz@gnu.org>
2233
2234 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2235 possible random value that matches one of those tested as
2236 condition to clear the mouse face.
2237
d3d0842f
CY
22382011-10-28 Chong Yidong <cyd@gnu.org>
2239
2240 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2241
31b39d13
DN
22422011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2243
2244 * window.c (make_window): Initialize phys_cursor_on_p.
2245
9aba6043
SM
22462011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2247
2248 * lisp.h (struct Lisp_Symbol): Update comments.
2249
c20992f4
JB
22502011-10-28 Juanma Barranquero <lekktu@gmail.com>
2251
2252 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2253
db4f02f2
EZ
22542011-10-28 Eli Zaretskii <eliz@gnu.org>
2255
2256 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2257 <oslsachem@gmail.com> for helping to debug this.
2258
2259 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2260 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2261 (g_b_init_get_glyph_outline_w): New static variables.
2262 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2263 (GetGlyphOutlineW_Proc): New typedefs.
2264 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
2265 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2266 New functions.
2267 (w32font_open_internal, compute_metrics):
2268 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
2269 instead of calling the "wide" APIs directly.
2270
2271 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2272
2273 * w32.h (syms_of_w32font): Add prototype.
2274
87e68db4
JB
22752011-10-27 Juanma Barranquero <lekktu@gmail.com>
2276
2277 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2278 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2279 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2280 (Fmove_to_window_line): Doc fix.
2281
435c1d67
CY
22822011-10-27 Chong Yidong <cyd@gnu.org>
2283
2284 * process.c (make_process): Set gnutls_state to NULL.
2285
2286 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2287 non-NULL, regardless of GNUTLS_INITSTAGE.
2288 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2289 an error. Set process slots as soon as we allocate them.
2290
2291 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2292
9c6c6f49
CY
22932011-10-27 Chong Yidong <cyd@gnu.org>
2294
9aba6043
SM
2295 * gnutls.c (emacs_gnutls_deinit): New function.
2296 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
2297 (Fgnutls_deinit, Fgnutls_boot): Use it.
2298
2299 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2300 (deactivate_process): Call emacs_gnutls_deinit.
2301
657d08d3
JB
23022011-10-27 Juanma Barranquero <lekktu@gmail.com>
2303
2304 * image.c (x_create_x_image_and_pixmap):
2305 * w32.c (sys_rename, w32_delayed_load):
2306 * w32font.c (fill_in_logfont):
2307 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2308
5430d399
JB
23092011-10-26 Juanma Barranquero <lekktu@gmail.com>
2310
2311 * w32fns.c (w32_default_color_map): New function,
2312 extracted from Fw32_default_color_map.
a7ef684b 2313 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 2314
fe0055fa
PE
23152011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2316
2317 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2318
e6346438
SM
23192011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2320
2321 * keyboard.c (test_undefined): New function (bug#9751).
2322 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2323
e112cc37
ET
23242011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2325
2326 * sysdep.c (init_sys_modes): Fix the check for the controlling
2327 terminal (Bug#6649).
2328
7b5d6677
EZ
23292011-10-20 Eli Zaretskii <eliz@gnu.org>
2330
2331 * dispextern.h (struct bidi_it): New member next_en_type.
2332
2333 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2334 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2335 current character, check also for next_en_type being WEAK_EN.
2336 (bidi_resolve_weak): Don't enter the expensive loop if the current
2337 position is before next_en_pos. Record the bidi type of the first
2338 non-ET, non-BN character we find, in addition to its position.
2339 (bidi_level_of_next_char): Invalidate next_en_type when
2340 next_en_pos is over-stepped.
2341
7da0b018
PE
23422011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2343
2344 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2345 * editfns.c: Rewrite current-time-zone so that it invokes
2346 the equivalent of (format-time-string "%Z") to get the time zone name.
2347 This fixes a bug when the time zone name contains characters that
2348 need converting from the system time locale to Emacs internal format.
2349 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2350 that patch fixed format-time-string to do the conversion, but
2351 I forgot to fix current-time-zone.
2352 (format_time_string): New function, containing most of
2353 what Fformat_time_string used to contain.
2354 (Fformat_time_string): Rewrite in terms of format_time_string.
2355 This doesn't change this function's behavior.
2356 (current-time-zone): Rewrite to use format_time_string.
2357 This fixes the bug reported by Michael Schierl in
2358 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2359 Jason Rumney's 2007-06-07 change worked around this bug, but
2360 didn't fix it.
2361 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2362
8547b010
EZ
23632011-10-19 Eli Zaretskii <eliz@gnu.org>
2364
2365 * xdisp.c (start_display): If the character at POS is displayed
2366 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2367 (try_window_reusing_current_matrix): If a line ends in a display
2368 vector or the next line starts in a display vector, continue
2369 redrawing the window even though the character position of
2370 start_row was reached.
8547b010
EZ
2371 (Bug#9771, part 2)
2372
4e948d15
CY
23732011-10-18 Chong Yidong <cyd@gnu.org>
2374
2375 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2376 with nobreak-char-display too.
2377
4787455f
EZ
23782011-10-18 Eli Zaretskii <eliz@gnu.org>
2379
2380 Fix part 3 of bug#9771.
2381 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2382 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2383 non-neutral characters if the current character is a paragraph
2384 separator (a.k.a. Newline). This avoids running the same
2385 expensive loop twice, once when we consume the preceding newline
2386 and the other time when the line actually needs to be displayed.
2387 Avoid the loop when we see neutrals on the base embedding level
2388 following a character whose directionality is the same as the
2389 paragraph's. This avoids running the expensive loop when a line
2390 ends in a long sequence of neutrals, like control characters.
2391 Add assertion against STRONG_AL type. Slightly rearrange code
2392 that determines the type of a neutral given the first non-neutral
2393 that follows it.
2394 (bidi_level_of_next_char): Set next_en_pos to zero when
2395 invalidating its info.
2396
2c91f553
EZ
23972011-10-17 Eli Zaretskii <eliz@gnu.org>
2398
2399 * xdisp.c (push_display_prop): Determine whether to record string
2400 or buffer position by IT->string, not by IT->method. Allow
2401 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2402 (move_it_vertically_backward): Don't look for character position
2403 immediately after the newline when in a continuation line.
2404 (Bug#9771, part 1)
2c91f553 2405
c7b08b0d
MR
24062011-10-15 Martin Rudalics <rudalics@gmx.at>
2407
2408 * window.c (coordinates_in_window): Rewrite and delabelize
2409 vertical border check. (Bug#5357) (Bug#9618)
2410
6b02f655
SM
24112011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2412
2413 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2414 errors in XSetWindowBorder (bug#9310).
2415
81d40c92
DA
24162011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2417
2418 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2419 avoid crash when xmalloc overrun checking is enabled.
2420
d4172c3b
EZ
24212011-10-13 Eli Zaretskii <eliz@gnu.org>
2422
2423 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2424 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2425 cursor motion with <left> and <right> arrow keys.
2426
2427 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2428 some callers set that themselves.
2429
b00eea75
EZ
24302011-10-12 Eli Zaretskii <eliz@gnu.org>
2431
2432 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2433 display string and the previous row comes from the same string and
2434 is empty. (Bug#9739) (Bug#9738)
2435
8fe012c4
SM
24362011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2437
2438 * doc.c (get_doc_string): Encode file name (bug#9735).
2439
0074aef2
EZ
24402011-10-12 Eli Zaretskii <eliz@gnu.org>
2441
79beb178
EZ
2442 * bidi.c (bidi_level_of_next_char):
2443 * xdisp.c (get_visually_first_element): Remove old incorrect
2444 comments regarding the Unicode Line Separator character.
2445
0074aef2
EZ
2446 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2447
6e4b3fbe
DA
24482011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2449
2450 * alloc.c (Fgc_status): Do not access beyond zombies array
2451 boundary if nzombies > MAX_ZOMBIES.
2452 * alloc.c (dump_zombies): Add missing format specifier.
2453
0324f3af
PE
24542011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2455
b5525cac
PE
2456 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2457 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2458
0324f3af
PE
2459 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2460 Some packages use them to denote characters with modifiers.
2461
e9b5f888
AS
24622011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2463
2464 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2465 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2466 matching a pp-number. Rename parameter var to var1.
2467
127827c0
SM
24682011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2469
2470 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2471
c8fd3bd0
GM
24722011-10-08 Glenn Morris <rgm@gnu.org>
2473
2474 * callint.c (Fcall_interactively): Give a more explicit error for the
2475 'c' case with a non-character input. (Bug#8479)
2476
352ec8ff
EZ
24772011-10-08 Eli Zaretskii <eliz@gnu.org>
2478
03669ccb
EZ
2479 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2480 lines.
7061c986
EZ
2481 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2482 lines that are hscrolled on the left.
03669ccb 2483
352ec8ff
EZ
2484 * dispnew.c (buffer_posn_from_coords): Account for a possible
2485 presence of header-line. (Bug#4426)
2486
a66cfb1c
SM
24872011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2488
6b02f655
SM
2489 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2490 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2491
7c5ee88e
PE
24922011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2493
2494 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2495 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2496 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2497 this makes Emacs dump core during garbage collection on rare
2498 occasions. sizeof is obviously inferior to offsetof here, so
2499 stick with offsetof.
2500 (GC_POINTER_ALIGNMENT): New macro.
2501 (mark_memory): Omit 3rd (offset) arg; caller changed.
2502 Don't assume EMACS_INT alignment is the same as pointer alignment.
2503
df1bbe5b
SM
25042011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2505
2506 * keyboard.c (read_key_sequence_remapped): New var.
2507 (read_key_sequence): Compute remapping in the right buffer.
2508 (command_loop_1): Use read_key_sequence's remapping directly.
2509
51553db6
SM
25102011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2511
32c1fffd
SM
2512 * dired.c (file_name_completion): Don't expand file name.
2513 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2514 before checking file name handler.
2515
51553db6
SM
2516 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2517 they've been requested explicitly (bug#9591).
2518
b6bd1599 25192011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2520
2521 * keymap.c (Fsingle_key_description): Use make_specified_string
2522 instead of build_string to build string from push_key_description.
2523 (Bug#5193)
2524
f701dc2a
PE
25252011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2526
4222c55d
PE
2527 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2528 This fixes a Y2038 bug on 64-bit hosts.
2529 * buffer.c (reset_buffer):
2530 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2531 (Fclear_buffer_auto_save_failure):
2532 Use 0, not -1, to represent an unset failure time, since time_t
2533 might not be signed.
2534
f701dc2a
PE
2535 Remove dependency on glibc malloc internals.
2536 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2537 Move back here from lisp.h, but with their new implementations.
2538 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2539 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2540 * charset.c (charset_table_init): New static var.
2541 (syms_of_charset): Use it instead of xmalloc. This removes a
2542 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2543 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2544 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2545 Move back to alloc.c.
2546 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2547 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2548
9ceebf39
JD
25492011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2550
2551 * nsterm.m (windowDidResize): Call x_set_window_size only when
2552 ns_in_resize is true. Otherwise set pixelwidth/height and
2553 call change_frame_size (Bug#9628).
2554
cb993c58
PE
25552011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2556
3930c88b
PE
2557 Port --enable-checking=all to Fedora 14 x86-64.
2558 * charset.c (syms_of_charset): Also account for glibc malloc's
2559 internal overhead when calculating the initial malloc maximum.
2560
cb993c58
PE
2561 Port --enable-checking=all to Fedora 14 x86.
2562 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2563 Move to lisp.h.
2564 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2565 (overrun_check_realloc, overrun_check_free):
2566 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2567 That way, xmalloc returns a properly-aligned pointer even if
2568 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2569 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2570 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2571 into account when calculating the initial malloc maximum.
2572 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2573 Move here from alloc.c, so that charset.c can use it too.
2574 Properly align; the old code wasn't right for common 32-bit hosts
2575 when configured with --enable-checking=all.
2576 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2577 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2578
31bed486
EZ
25792011-09-29 Eli Zaretskii <eliz@gnu.org>
2580
04c70788 2581 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2582 use EDOM.
2583
fbcaa2f3
EZ
25842011-09-28 Eli Zaretskii <eliz@gnu.org>
2585
2586 * xdisp.c (compute_display_string_end): If there's no display
2587 string at CHARPOS, return -1.
2588
2589 * bidi.c (bidi_fetch_char): When compute_display_string_end
2590 returns a negative value, treat the character as a normal
2591 character not covered by a display string. (Bug#9624)
2592
a239d4e9
JB
25932011-09-28 Juanma Barranquero <lekktu@gmail.com>
2594
2595 * lread.c (Fread_from_string): Fix typo in docstring.
2596
88652fd5
EZ
25972011-09-27 Eli Zaretskii <eliz@gnu.org>
2598
2599 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2600 newline, reseat the iterator instead of bidi-iterating there one
2601 character at a time. (Bug#9610)
32c1fffd
SM
2602 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2603 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2604
ed497dd4
AS
26052011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2606
2607 * lread.c (readevalloop): Use correct code for NBSP.
2608 (read1): Likewise. (Bug#9608)
2609
b2bf61aa
MA
26102011-09-25 Michael Albinus <michael.albinus@gmx.de>
2611
2612 * dbusbind.c (Fdbus_register_signal): When service is not
2613 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2614
32bbb17c
GM
26152011-09-25 Glenn Morris <rgm@gnu.org>
2616
2617 * buffer.c (truncate-lines): Doc fix.
2618
94e0933e
CY
26192011-09-24 Chong Yidong <cyd@stupidchicken.com>
2620
2621 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2622 (Fset_window_next_buffers): Doc fix.
2623
cddde921
GM
26242011-09-24 Glenn Morris <rgm@gnu.org>
2625
2626 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2627
1260aef1
PE
26282011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2629
25b4bfa0
PE
2630 Fix minor problems found by static checking.
2631 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2632 * indent.c (Fvertical_motion): Fix == vs = typo.
2633
e3cbd34b
EZ
26342011-09-24 Eli Zaretskii <eliz@gnu.org>
2635
a66cfb1c
SM
2636 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2637 Default value is now t. Doc fix.
6bf7006f 2638
e3cbd34b 2639 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2640 logic when moving up, not only when moving down. Fix the
e3cbd34b 2641 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2642 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2643
2644 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2645 CHARPOS is covered by a display string which includes newlines.
2646 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2647 is covered by a display string with embedded newlines.
2648
a3de0cbd
MA
26492011-09-24 Michael Albinus <michael.albinus@gmx.de>
2650
2651 * dbusbind.c (Fdbus_register_signal): Add match rule to
2652 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2653 (Fdbus_register_method, Vdbus_registered_objects_table):
2654 Fix docstring.
a3de0cbd 2655
b260039d
JM
26562011-09-24 Jim Meyering <meyering@redhat.com>
2657
32c1fffd 2658 do not ignore write error for any output size
b260039d
JM
2659 The previous change was incomplete.
2660 While it makes emacs --batch detect the vast majority of stdout
2661 write failures, errors were still ignored whenever the output size is
2662 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2663 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2664 && echo FAIL: ignored write error
2665 FAIL: ignored write error
2666 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2667 && echo FAIL: ignored write error
2668 FAIL: ignored write error
2669 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2670
8eca8a7c
AS
26712011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2672
2673 * emacs.c (Fkill_emacs): In noninteractive mode exit
2674 non-successfully if a write error occurred on stdout. (Bug#9574)
2675
3341db62
EZ
26762011-09-21 Eli Zaretskii <eliz@gnu.org>
2677
2678 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2679 the xassert test.
2680
2681 * dispextern.h (struct it): Update the comment documenting what
2682 can it->OBJECT be.
2683
8c203dbf
EZ
26842011-09-20 Eli Zaretskii <eliz@gnu.org>
2685
2686 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2687 a display string, extend search for cursor position to end of row.
2688 (find_row_edges): If the row ends in a newline from a display
2689 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2690 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2691 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2692 non-empty line. Fixes confusing cursor motion with arrow keys at
2693 the beginning of a line that starts with whitespace.
8c203dbf 2694
a4824228
LMI
26952011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2696
2697 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2698 (bug#9493).
2699
33ed493b
CY
27002011-09-18 Chong Yidong <cyd@stupidchicken.com>
2701
2702 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2703 boolean (Bug#9154).
2704
56cd55c8
EZ
27052011-09-18 Eli Zaretskii <eliz@gnu.org>
2706
2707 * xdisp.c (display_line): Record maximum and minimum buffer
2708 positions even if no glyphs were produced (e.g., by a zero-width
2709 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2710 buffer positions that will be removed from the glyph row because
2711 they don't fit.
c02dcedf
EZ
2712 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2713 column is beyond frame width: don't subtract 1 "pixel" when
2714 computing width of the stretch.
3e62b7e0
EZ
2715 (reseat_at_next_visible_line_start): Undo the change made on
2716 2011-09-17 that saved paragraph information and restored it after
2717 the call to `reseat'. (Bug#9545)
56cd55c8 2718
5ed99d36 27192011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2720
2721 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2722 and turn window cursor on if cleared (Bug#9415).
2723
5ed99d36 27242011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2725
2726 * search.c (boyer_moore): Take unibyte characters from pattern
2727 literally. (Bug#9458)
2728
9bade7b2
EZ
27292011-09-18 Eli Zaretskii <eliz@gnu.org>
2730
2731 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2732
e5e9d610
PE
27332011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2734
87e4427a
PE
2735 Fix minor problem found by static checking.
2736 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2737 initialized, to pacify gcc -Wuninitialized.
2738
e5e9d610
PE
2739 * fileio.c: Report proper errno when syscall falls.
2740 (Finsert_file_contents): Save and restore errno,
2741 so that report_file_error outputs the correct diagnostic.
2742 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2743
a1674f0b
EZ
27442011-09-18 Eli Zaretskii <eliz@gnu.org>
2745
2746 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2747
fbfb6dd4
EZ
27482011-09-17 Eli Zaretskii <eliz@gnu.org>
2749
2750 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2751 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2752
bb187662
EZ
27532011-09-17 Eli Zaretskii <eliz@gnu.org>
2754
1137e8b8 2755 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2756 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2757
2758 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2759 (bidi_find_paragraph_start): Search back for paragraph beginning
2760 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2761 (bidi_move_to_visually_next): Only trigger paragraph-related
2762 computations when the last character is a newline or at EOB, not
2763 just any NEUTRAL_B. (Bug#9470)
2764
bb187662
EZ
2765 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2766 truncated lines if point is covered by a display string. (Bug#9524)
2767
2e621251
PE
27682011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2769
2770 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2771 (cons_to_x_long): New function.
2772 (lisp_data_to_selection_data): Use it. Correct the test for
2773 short-versus-long data; it was negated. Break out of vector
2774 loop, for efficiency, when a long datum is discovered.
2775
91a15bc6
SM
27762011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2777
2778 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2779
b41c3a35
EZ
27802011-09-16 Eli Zaretskii <eliz@gnu.org>
2781
2782 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2783 GCC PR/17406) by declaring this function with external scope.
2784
7812ba2d
PE
27852011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2786
2787 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2788 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2789
cf7edc2a
AS
27902011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2791
2792 * editfns.c (Fformat): Correctly handle text properties on "%%".
2793
bd01620e
EZ
27942011-09-15 Eli Zaretskii <eliz@gnu.org>
2795
2796 * xterm.c (x_draw_composite_glyph_string_foreground):
2797 * w32term.c (x_draw_composite_glyph_string_foreground):
2798 * term.c (encode_terminal_code):
2799 * composite.c (composition_update_it, get_composition_id):
2800 * xdisp.c (get_next_display_element)
2801 (fill_composite_glyph_string): Add comments about special meaning
2802 of TAB characters in a composition.
2803
a02719a3
PE
28042011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2805
2806 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2807 This occurs when processing a multibyte format.
2808 Problem reported by Wolfgang Jenker.
a02719a3 2809
72589a3c
JB
28102011-09-15 Johan Bockgård <bojohan@gnu.org>
2811
2812 * xdisp.c (try_cursor_movement): Only check for exact match if
2813 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2814
1c14176c
PE
28152011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2816
2817 Remove unused external symbols.
2818 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2819 * xdisp.c (calc_pixel_width_or_height): Now static.
2820 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2821 * indent.c (check_display_width):
2822 * w32term.c: Fix comment to match code.
2823 * xterm.c, xterm.h (x_catching_errors): Remove.
2824
d2eea5b5
PE
28252011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2826
2827 * xselect.c: Use signed conversions more consistently (Bug#9498).
2828 (selection_data_to_lisp_data): Assume incoming selection data are
2829 signed integers, not unsigned. This is to be consistent with
2830 outgoing selection data, which was modified to use signed integers
2831 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2832 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2833 expects long, not unsigned long.
2834
46888499
EZ
28352011-09-14 Eli Zaretskii <eliz@gnu.org>
2836
2837 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2838 computation of loop end. Reported by Johan Bockgård
2839 <bojohan@gnu.org>.
2840
ef8ef9fb
CY
28412011-09-13 Chong Yidong <cyd@stupidchicken.com>
2842
2843 * frame.c (Fother_visible_frames_p): Function deleted.
2844
fa819fed
EZ
28452011-09-12 Eli Zaretskii <eliz@gnu.org>
2846
2847 * indent.c (compute_motion): Process display vector front to back
2848 rather than the other way around. (Bug#2496)
2849
2ba8e008
SM
28502011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2851
2852 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2853
20f53c69
CY
28542011-09-11 Chong Yidong <cyd@stupidchicken.com>
2855
2856 * minibuf.c (Fread_from_minibuffer): Doc fix.
2857
d562d7a4
EZ
28582011-09-11 Eli Zaretskii <eliz@gnu.org>
2859
2860 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2861 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2862
1c4d7f3d
LMI
28632011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2864
2865 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2866 value for non-existent files.
2867
b885bf36
EZ
28682011-09-11 Eli Zaretskii <eliz@gnu.org>
2869
2870 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2871 set its "size" to -1. This will set the modtime_size field of
2872 the corresponding buffer to -1, which is what
2873 verify-visited-file-modtime expects for files that do not exist.
2874 (Bug#9139)
2875
6612f0bf
PE
28762011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2877
2878 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2879 here ...
2880 * lisp.h: ... from here. push_key_description is no longer
2881 defined in keyboard.c, so its declaration should not be in
2882 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2883 logically belongs with push_key_description.
2884
dfb3f755
PE
28852011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2886
2887 * buffer.h: Include <sys/types.h> instead of <time.h>.
2888 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2889 Problem reported by Herbert J. Skuhra.
2890
3134906c
LMI
28912011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2892
2893 * xml.c (parse_region): Make the parsing work for
2894 non-comment-starting XML files again (bug#9144).
2895
8d903f4e
AS
28962011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2897
2898 * image.c (gif_load): Fix calculation of bottom and right corner.
2899 (Bug#9468)
2900
80ad64f4
EZ
29012011-09-10 Eli Zaretskii <eliz@gnu.org>
2902
2903 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2904 redisplay in small windows.
2905
208a048d
EZ
29062011-09-09 Eli Zaretskii <eliz@gnu.org>
2907
2908 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2909
9b1c252e
MR
29102011-09-08 Martin Rudalics <rudalics@gmx.at>
2911
2912 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2913 Operate on live windows only.
2914
2949f33b
JB
29152011-09-08 Juanma Barranquero <lekktu@gmail.com>
2916
2917 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2918
e08dcafd
EZ
29192011-09-07 Eli Zaretskii <eliz@gnu.org>
2920
2921 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2922 only under bidi iteration.
2923
115b96bd
JD
29242011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2925
2926 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2927
c8199d0f
PE
29282011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2929
2930 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2931 Without this fix, the command to link temacs failed due to an
2932 undefined symbol __builtin_isnan. This is because
2933 /usr/include/iso/math_c99.h #defines isnan(x) to
2934 __builtin_isnan(x), but the bundled gcc, which identifies itself
2935 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2936 a __builtin_isnan.
2937 * floatfns.c (isnan): #undef, and then #define to a clone of
2938 what's in data.c.
2939 (Fisnan): Always define, since it's always available now.
2940 (syms_of_floatfns): Always define isnan at the Lisp level.
2941
e39b275c 29422011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2943
2944 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2945
b2db44d9 29462011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2947
f4af5137 2948 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2949 The previous code assumed that file offsets (off_t values) fit in
2950 EMACS_INT variables, which is not true on typical 32-bit hosts.
2951 The code messed up by falsely reporting buffer overflow in cases
2952 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2953 when "big" contains more than 2**29 bytes, even though this
2954 inserts just one byte and does not overflow the buffer.
2955 (Finsert_file_contents): Store file offsets as off_t
2956 values, not as EMACS_INT values. Check for overflow when
2957 converting between EMACS_INT and off_t. When checking for
2958 buffer overflow or for overlap, take the offsets into account.
2959 Don't use EMACS_INT for small values where int suffices.
2960 When checking for overlap, fix a typo: ZV was used where
2961 ZV_BYTE was intended.
2962 (Fwrite_region): Don't assume off_t fits into 'long'.
2963 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2964
ecfc0a49
MA
29652011-09-05 Michael Albinus <michael.albinus@gmx.de>
2966
2967 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2968
6511acf2 29692011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2970
0999621a 2971 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2972
2973 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2974 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2975 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2976 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2977 (modify_event_symbol): Do not assume that the length of
2978 name_alist_or_stem is safe to alloca and fits in int.
2979 (Fexecute_extended_command): Likewise for function name and binding.
2980 (Frecursion_depth): Wrap around reliably on integer overflow.
2981 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2982 since some callers pass EMACS_INT values.
2983 (Fsingle_key_description): Don't crash if symbol name contains more
2984 than MAX_ALLOCA bytes.
2985 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2986 (get_minibuffer): Arg is now EMACS_INT, not int.
2987 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2988 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2989 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2990
2be7d702
PE
2991 * dbusbind.c (signature_cat): New function.
2992 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2993 Do not overrun buffer; instead, report string overflow.
2994
9d1df220
PE
2995 * dispnew.c (add_window_display_history): Don't overrun buffer.
2996 Truncate instead; this is OK since it's just a log.
2997
33ef5c64
PE
2998 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2999 even if the time zone offset is outlandishly large.
3000 Don't mishandle offset == INT_MIN.
3001
66c6fdd5
PE
3002 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3003 when creating daemon; the previous buffer-overflow check was incorrect.
3004
d749b01b
PE
3005 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3006 which has the guts of the old verror function.
3007
b5cd1905
PE
3008 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3009 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3010
6e1a67fb
PE
3011 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3012 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 3013 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 3014 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
3015 length of string rather than counting it via multiple sprintfs;
3016 that's simpler and more reliable.
c21721cc
PE
3017 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3018 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3019 sprintf, in case result does not fit in int.
3020
c57b67fc
PE
3021 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3022 (fontset_from_font): Print it.
3023
8a401434
PE
3024 * frame.c (tty_frame_count): Now printmax_t, not int.
3025 (make_terminal_frame, set_term_frame_name): Print it.
3026 (x_report_frame_params): In X, window IDs are unsigned long,
3027 not signed long, so print them as unsigned.
3028 (validate_x_resource_name): Check for implausibly long names,
3029 and don't assume name length fits in 'int'.
3030 (x_get_resource_string): Don't blindly alloca invocation name;
3031 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3032 not fit in int.
3033
6e1a67fb
PE
3034 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3035 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
3036 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3037
0df02bf3
PE
3038 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3039 Use esprintf, not sprintf, in case result does not fit in int.
3040
48e30793
PE
3041 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3042 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
3043 it as a large positive number.
3044 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3045 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3046
a66ff6d8
PE
3047 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3048 in case result does not fit in int.
3049
aca216ff
PE
3050 * print.c (float_to_string): Detect width overflow more reliably.
3051 (print_object): Make sprintf buffer a bit bigger, to avoid potential
3052 buffer overrun. Don't assume list length fits in 'int'. Treat
3053 print length of 0 as 0, not as infinity; to be consistent with other
3054 uses of print length in this function. Don't overflow print length
3055 index. Don't assume hash table size fits in 'long', or that
3056 vectorlike size fits in 'unsigned long'.
3057
31c286f7
PE
3058 * process.c (make_process): Use printmax_t, not int, to format
3059 process-name gensyms.
3060
55e5faa1
PE
3061 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3062
80f2e268
PE
3063 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3064 to avoid potential buffer overrun.
3065
670741ab
PE
3066 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
3067 if X resource line is longer than 512 bytes.
3068
b7163a50
PE
3069 * xfns.c (x_window): Make sprintf buffer a bit bigger
3070 to avoid potential buffer overrun.
3071
ae58ff1f
PE
3072 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
3073
c43c8a6a
PE
3074 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
3075
3f8236f4
PE
30762011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3077
53e9fe90 3078 Integer overflow fixes for scrolling, etc.
6511acf2
PE
3079 Without these, Emacs silently mishandles large integers sometimes.
3080 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
3081 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3082
6511acf2
PE
3083 * xdisp.c (try_window_id): Check Emacs fixnum range before
3084 converting to 'int'.
806add1d 3085
6511acf2 3086 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
3087 Check that an Emacs fixnum is in range before assigning it to 'int'.
3088 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3089 values converted from Emacs fixnums.
3090 (Frecenter): Don't wrap around a line count if it is out of 'int'
3091 range; instead, treat it as an extreme value.
3092 (Fset_window_configuration, compare_window_configurations):
3093 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3094
6511acf2
PE
3095 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3096 that can exceed INT_MAX. Check that EMACS_INT value is in range
3097 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
3098 (match_limit): Don't assume that a fixnum can fit in 'int'.
3099
6511acf2 3100 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
3101 exceed INT_MAX.
3102
6511acf2 3103 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
3104 (Fvertical_motion): Don't wrap around LINES values that don't fit
3105 in 'int'. Instead, treat them as extreme values. This is good
3106 enough for windows, which can't have more than INT_MAX lines anyway.
3107
fcb901a7
LMI
31082011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3109
0f2f6b6d
LMI
3110 * Require libxml/parser.h to avoid compilation warning.
3111
fcb901a7
LMI
3112 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3113
3114 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3115 since this reportedly can destroy thread storage.
3116
6e20a0d4
CY
31172011-08-30 Chong Yidong <cyd@stupidchicken.com>
3118
3119 * syntax.c (find_defun_start): Update all cache variables if
3120 exiting early (Bug#9401).
3121
148ae00e
EZ
31222011-08-30 Eli Zaretskii <eliz@gnu.org>
3123
f6cfbd8f
EZ
3124 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3125
148ae00e
EZ
3126 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3127 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3128 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3129
3130 * term.c (tty_append_glyph): New function.
3131 (produce_stretch_glyph): Static function and its prototype deleted.
3132
a66cfb1c
SM
3133 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3134 Add prototypes.
148ae00e 3135
c4a07a4c
PE
31362011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3137
3138 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3139 when checking :margin (Bug#9390).
3140 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 3141 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
3142 so that the name doesn't mislead. All uses changed.
3143
6bc8cd65
JB
31442011-08-28 Johan Bockgård <bojohan@gnu.org>
3145
3146 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3147 set_tty_hooks.
3148
dca4927e
EZ
31492011-08-27 Eli Zaretskii <eliz@gnu.org>
3150
3151 * xdisp.c (move_it_to): Don't bail out early when reaching
3152 position beyond to_charpos, if we are scanning backwards.
3153 (move_it_vertically_backward): When DY == 0, make sure we get to
3154 the first character in the line after the newline.
3155
f2cad773
PE
31562011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3157
3158 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3159 (ccl_driver): Do not generate an out-of-range pointer.
3160 (Fccl_execute_on_string): Remove unnecessary check for
3161 integer overflow, noted by Stefan Monnier in
3162 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3163 Remove a FIXME that didn't need fixing.
3164 Simplify the newly-introduced buffer reallocation code.
3165
0cae2cdb
JB
31662011-08-27 Juanma Barranquero <lekktu@gmail.com>
3167
3168 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3169
5fc295a4 31702011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 3171
70c60eb2 3172 Integer and memory overflow issues (Bug#9196).
726e0ab1 3173
d31850da
PE
3174 * doc.c (get_doc_string): Rework so that
3175 get_doc_string_buffer_size is the actual buffer size, rather than
3176 being 1 less than the actual buffer size; this makes xpalloc more
3177 convenient.
3178
a69fbedb
PE
3179 * image.c (x_allocate_bitmap_record, cache_image):
3180 * xselect.c (Fx_register_dnd_atom):
3181 Simplify previous changes by using xpalloc.
3182
fe5c5d37
PE
3183 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3184 since either will do and ptrdiff_t is convenient with xpalloc.
3185
0065d054
PE
3186 * charset.c (charset_table_size)
3187 (struct charset_sort_data.priority): Now ptrdiff_t.
3188 (charset_compare): Don't overflow if priorities differ greatly.
3189 (Fsort_charsets): Don't assume list length fits in int.
3190 Check for size-calculation overflow when allocating sort data.
3191 (syms_of_charset): Allocate an initial charset table that is
3192 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3193
3194 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3195
3196 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3197 The actual value is always <= INT_MAX, and leaving it unsigned made
3198 overflow checking harder.
3199
3200 * dispextern.h (struct glyph_matrix.rows_allocated)
3201 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3202 with xpalloc. The values are still always <= INT_MAX.
3203
3204 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3205
3206 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3207 (SAFE_NALLOCA): New macro.
3208
3209 * region-cache.c (struct boundary.pos, find_cache_boundary)
3210 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3211 (set_cache_region, invalidate_region_cache)
3212 (revalidate_region_cache, know_region_cache, region_cache_forward)
3213 (region_cache_backward, pp_cache):
3214 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3215 so that ptrdiff_t * can be passed to xpalloc.
3216 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3217 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3218 (pp_cache): Don't assume cache_len fits in int.
3219 * region-cache.h: Adjust extern decls to match.
3220
3221 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3222 EMACS_INT, since either will do, for xpalloc.
3223
3224 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3225 (xnmalloc, xnrealloc, xpalloc): New functions.
3226
726e0ab1
PE
3227 * bidi.c (bidi_shelve_header_size): New constant.
3228 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3229 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3230
51f30bc5 3231 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
3232 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3233 (overlay_strings):
3234 Don't update size of array until after memory allocation succeeds,
3235 because xmalloc/xrealloc may not return.
0065d054
PE
3236 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3237 now that we have proper integer overflow checking.
3238 (record_overlay_string, overlay_strings): Catch overflows when
3239 calculating size of overlay_str_buf.
726e0ab1 3240
0065d054
PE
3241 * callproc.c (Fcall_process): Check for size overflow when
3242 calculating size of args2.
3243 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3244 Normally we prefer signed values, but sticking with ptrdiff_t would
3245 require adding more-complicated checks.
726e0ab1
PE
3246
3247 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3248 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3249 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 3250 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
3251
3252 * character.c (Fstring): Check for size-calculation overflow.
3253
3254 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3255 unnecessary integer overflow. Check for size overflow.
3256 (encode_coding_object): Don't update size until xmalloc succeeds.
3257
3258 * composite.c (get_composition_id): Check for overflow in glyph
3259 length calculations.
3260
3261 Integer and memory overflow fixes for display code.
3262 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3263 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3264 (scrolling_window): Check for overflow in size calculations.
3265 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3266 Don't assume glyph table len fits in int.
3267 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3268 (row_table_size): Now ptrdiff_t, not int.
3269 (scrolling_window): Avoid overflow in size calculations.
3270 Don't update size until allocation succeeds.
3271 * fns.c (concat): Check for overflow in size calculations.
3272 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3273 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3274 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3275
3276 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3277 (get_doc_string): Check for size calculation overflow.
3278 Don't update size until allocation succeeds.
3279 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3280 EMACS_INT, where ptrdiff_t will do.
3281 (Fsubstitute_command_keys): Check for string overflow.
3282
3283 * editfns.c (set_time_zone_rule): Don't assume environment length
3284 fits in int.
3285 (message_length): Now ptrdiff_t, not int.
3286 (Fmessage_box): Don't update size until allocation succeeds.
3287 Don't assume message length fits in int.
3288 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3289
0065d054
PE
3290 * emacs.c (main): Do not reallocate argv, since there is a null at
3291 the end that can be overwritten, and this way there's no need to
3292 worry about size-calculation overflow.
3293 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
3294
3295 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3296 alloc succeeds.
3297 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3298
3299 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3300 (x_set_scroll_bar_width, x_figure_window_size):
3301 Check for integer overflow.
3302 (x_set_alpha): Do not assume XINT fits in int.
3303
3304 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3305 This is for the members text_lines, text_cols, total_lines, total_cols,
3306 where the system imposes an 'int' limit.
3307
3308 * fringe.c (Fdefine_fringe_bitmap):
3309 Don't update size until alloc works.
3310
3311 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3312 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3313
3314 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3315 Check for size-calculation overflow.
3316 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3317 do, as we prefer signed integers.
3318 (id_to_widget.max_size, id_to_widget.used)
3319 (xg_store_widget_in_map, xg_remove_widget_from_map)
3320 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3321 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3322 Use and return ptrdiff_t, not int.
3323 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3324 * gtkutil.h: Change prototypes to match the above.
3325
3326 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3327 are duplicate now that they've been promoted to lisp.h.
3328 (x_allocate_bitmap_record, x_alloc_image_color)
3329 (make_image_cache, cache_image, xpm_load):
3330 Don't update size until alloc is done.
3331 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3332 (x_detect_edges):
3256efce 3333 Check for size calculation overflow.
726e0ab1
PE
3334 (ct_colors_allocated_max): New constant.
3335 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3336 overflow.
3256efce 3337
726e0ab1
PE
3338 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3339 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3340 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3341 Use ptrdiff_t, not int, to count maps.
3342 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
3343 calculations. Don't update size until allocation succeeds.
3344 Redo calculations to avoid overflow.
726e0ab1
PE
3345 * keyboard.h: Change prototypes to match the above.
3346
3347 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3348 to count maps.
3349 (current_minor_maps): Check for size calculation overflow.
3350 * keymap.h: Change prototypes to match the above.
3351
3352 * lread.c (read1, init_obarray): Don't update size until alloc done.
3353
3354 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3355 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3356
726e0ab1
PE
3357 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3358 Now ptrdiff_t, not int.
3359 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3360 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3361
3362 * process.c (Fnetwork_interface_list): Check for overflow
3363 in size calculation.
3364
3365 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3366
3367 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3368 overflow. Don't bother calling xmalloc when xrealloc will do.
3369
3370 * search.c (Freplace_match): Check for size calculation overflow.
3371 (Fset_match_data): Don't assume list lengths fit in 'int'.
3372
3373 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3374 for command line length. Do not attempt to address one before the
3375 beginning of an array, as that's not portable.
3376
3377 * term.c (max_frame_lines): Remove; unused.
3378 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3379 not int.
3380 (encode_terminal_code, calculate_costs): Check for size
3381 calculation overflow.
3382 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3383 table lengths and related sizes. Don't update size until alloc
3384 done. Redo calculations to avoid overflow.
3385 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3386
3387 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3388 subtracting pointers.
3389 (gobble_line): Check for overflow more carefully. Don't update size
3390 until alloc done.
3391
3392 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3393 Don't update size until alloc done.
3394 Redo size calculations to avoid overflow.
3395 Check for size calculation overflow.
0065d054 3396 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3397
3398 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3399 Use ptrdiff_t, not int, for sizes.
3400 (store_mode_line_noprop_char): Don't update size until alloc done.
3401
0065d054
PE
3402 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3403 Use ptrdiff_t, not int, for sizes.
3404 (Finternal_make_lisp_face, cache_face):
3405 Check for size calculation overflow.
3406 (cache_face): Treat size calculation overflows as if they were
3407 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3408
3409 * xfns.c (x_encode_text, x_set_name_internal)
3410 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3411 sizes, since they can exceed INT_MAX in size. Check for size
3412 calculation overflow.
3413
0065d054
PE
3414 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3415 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3416 Don't update size until alloc done.
3417
0065d054 3418 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3419 as sprintf is limited to int lengths.
1d526e2f 3420
252c5ee1
PE
3421 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3422 (X_LONG_MIN): New macros.
864d7ce7
PE
3423 Use them to make the following changes clearer.
3424 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3425 This change doesn't affect the value now, but it may help remind
3426 future maintainers not to raise the value too much later.
3427 (SELECTION_QUANTUM): Remove, replacing with ...
3428 (selection_quantum): ... new function, which avoids overflow.
3429 All uses changed.
3430 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3431 assumption that selection length fits in 'int'.
3432 (x_reply_selection_request, x_handle_selection_request)
3433 (x_get_window_property, receive_incremental_selection)
3434 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3435 (lisp_data_to_selection_data, clean_local_selection_data):
3436 Use ptrdiff_t, not int, to record length of selection.
3437 (x_reply_selection_request, x_get_window_property)
3438 (receive_incremental_selection, x_property_data_to_lisp):
3439 Redo calculations to avoid overflow.
3440 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3441 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3442 something.
3443 (x_get_window_property, receive_incremental_selection)
3444 (lisp_data_to_selection_data, x_property_data_to_lisp):
3445 Check for size-calculation overflow.
3446 (x_get_window_property, receive_incremental_selection)
3447 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3448 Don't store size until memory allocation succeeds.
3449 (x_get_window_property): Plug memory leak on memory exhaustion.
3450 Don't double-block input; malloc is safe here. Don't assume 2**34
3451 - 4 fits in unsigned long. Add an xassert to check
3452 XGetWindowProperty overflow. Be more careful about overflow
3453 calculations, and distinguish size from memory overflow better.
3454 (receive_incremental_selection): When tracing, don't assume
3455 unsigned int is less than INT_MAX.
3456 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3457 harmful) conversions of unsigned short to int.
3458 (lisp_data_to_selection_data): Don't assume that integers
3459 in the range -65535 through -1 fit in an X unsigned short.
3460 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3461 result parameters unless successful. Rely on cons_to_unsigned
3462 to report problems with elements; the old code wasn't right anyway.
3463 (x_check_property_data): Check for int overflow; we cannot use
3464 a wider type due to X limits.
3465 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3466
726e0ab1 3467 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3468
0065d054
PE
3469 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3470 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3471 (x_color_cells): Don't store size until memory allocation succeeds.
3472 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3473 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3474 (x_term_init): Don't assume length fits in int (sprintf is limited
3475 to int size).
bc18e09d 3476
ebfa62c0
PE
3477 Use ptrdiff_t for composition IDs.
3478 * character.c (lisp_string_width):
3479 * composite.c (composition_table_size, n_compositions)
3480 (get_composition_id, composition_gstring_from_id):
3481 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3482 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3483 * window.c (Frecenter):
3484 Use ptrdiff_t, not int, for composition IDs.
3485 * composite.c (get_composition_id): Check for integer overflow.
3486 * composite.h: Adjust prototypes to match the above changes.
3487
d3411f89
PE
3488 Use ptrdiff_t for hash table indexes.
3489 * category.c (hash_get_category_set):
3490 * ccl.c (ccl_driver):
3491 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3492 * coding.c (coding_system_charset_list, detect_coding_system):
3493 * coding.h (struct coding_system.id):
3494 * composite.c (get_composition_id, gstring_lookup_cache):
3495 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3496 * image.c (xpm_get_color_table_h):
3497 * lisp.h (hash_lookup, hash_put):
3498 * minibuf.c (Ftest_completion):
3499 Use ptrdiff_t for hash table indexes, not int (which is too
3500 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3501 32-bit --with-wide-int hosts).
3502
e097a6fa
PE
3503 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3504 Add a FIXME comment about memory leaks.
3505 (syms_of_charset): Don't assume xmalloc returns.
3506
5637687f
PE
3507 Don't assume that stated character widths fit in int.
3508 * character.c (Fchar_width, c_string_width, lisp_string_width):
3509 * character.h (CHAR_WIDTH):
3510 * indent.c (MULTIBYTE_BYTES_WIDTH):
3511 Use sanitize_char_width to avoid undefined and/or bad behavior
3512 with outlandish widths.
a66cfb1c 3513 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3514 now that we have two such functions. All uses changed.
3515 (sanitize_char_width): New inline function.
3516
a2271ba2
PE
3517 Don't assume that tab-width fits in int.
3518 * character.h (sanitize_width): New inline function.
3519 (SANE_TAB_WIDTH): New macro.
3520 (ASCII_CHAR_WIDTH): Use it.
3521 * indent.c (sane_tab_width): Remove. All uses replaced by
3522 SANE_TAB_WIDTH (current_buffer).
3523 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3524
18c52557
PE
3525 * fileio.c: Integer overflow issues with file modes.
3526 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3527
caeeedc1
PE
3528 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3529 Remove unreachable code.
3530 (read_hex, load_charset_map_from_file): Check for integer overflow.
3531
6df6ae42 3532 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3533 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3534 (x_send_scroll_bar_event): Likewise. Check that the size does not
3535 exceed limits imposed by XClientMessageEvent, as well as the usual
3536 ptrdiff_t and size_t limits.
3537
b13995db
PE
3538 * keyboard.c: Overflow, signedness and related fixes.
3539 (make_lispy_movement): Use same integer type in forward decl
3540 that is used in the definition.
3541 (read_key_sequence, keyremap_step):
3542 Change bufsize argument back to int, undoing my 2011-03-30 change.
3543 We prefer signed types, and int is wide enough here.
3544 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3545 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3546 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3547 length, not size_t. Use ptrdiff_t for index, not int.
3548 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3549 possibility of integer overflow.
3550
13464394
PE
3551 Overflow, signedness and related fixes for images.
3552
3553 * dispextern.h (struct it.stack[0].u.image.image_id)
3554 (struct_it.image_id, struct image.id, struct image_cache.size)
3555 (struct image_cache.used, struct image_cache.ref_count):
3556 * gtkutil.c (update_frame_tool_bar):
3557 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3558 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3559 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3560 * nsmenu.m (update_frame_tool_bar):
3561 * xdisp.c (calc_pixel_width_or_height):
3562 * xfns.c (image_cache_refcount):
3563 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3564 on typical 64-bit hosts.
3565
3566 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3567 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3568 Omit unnecessary casts to int.
3569 (parse_image_spec): Check that integers fall into 'int' range
3570 when the callers expect that.
3571 (image_ascent): Redo ascent calculation to avoid int overflow.
3572 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3573 (lookup_image): Remove unnecessary tests.
3574 (xbm_image_p): Locals are now of int, not EMACS_INT,
3575 since parse_image_check makes sure they fit into int.
3576 (png_load, gif_load, svg_load_image):
3577 Prefer int to unsigned where either will do.
3578 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3579 old tiff_error_handler and tiff_warning_handler.
3580 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3581 stack buffer overflows. It uses only the features of vsnprintf
3582 that are common to both POSIX and native Microsoft.
3583 (tiff_error_handler, tiff_warning_handler): Use it.
3584 (tiff_load, gif_load, imagemagick_load_image):
3585 Don't assume :index value fits in 'int'.
3586 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3587 (imagemagick_load_image): Check that crop parameters fit into
3588 the integer types that MagickCropImage accepts. Don't assume
3589 Vimagemagick_render_type has a nonnegative value. Don't assume
3590 size_t fits in 'long'.
3591 (gs_load): Use printmax_t to print the widest integers possible.
3592 Check for integer overflow when computing image height and width.
3593
c11821d4
EZ
35942011-08-26 Eli Zaretskii <eliz@gnu.org>
3595
3596 * xdisp.c (redisplay_window): Don't force window start if point
3597 will be invisible in the resulting window. (Bug#9324)
3598
0c95fcf7
EZ
35992011-08-25 Eli Zaretskii <eliz@gnu.org>
3600
3601 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3602 the display spec is of the form `(space ...)'.
3603 (handle_display_spec): Return the value returned by
3604 handle_single_display_spec, not just 1 or zero.
3605 (handle_single_display_spec): If the display spec is of the form
3606 `(space ...)', and specifies display in the text area, return 2
3607 rather than 1.
fee65a97 3608 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3609 accurately, and prefer exact match for point under bidi.
3610 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3611
3612 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3613 into disp_prop; all users changed.
3614
3615 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3616 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3617 for the text covered by the display property.
3618
e4ed06f1
CY
36192011-08-25 Chong Yidong <cyd@stupidchicken.com>
3620
3621 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3622 Change return value to nil.
3623 (Frecord_buffer): Delete unused function.
3624
f67cdd7f
EZ
36252011-08-24 Eli Zaretskii <eliz@gnu.org>
3626
5980d4c6
EZ
3627 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3628 buffers, return left-to-right.
8610fe8b
EZ
3629 (set_cursor_from_row): Consider candidate row a win if its glyph
3630 represents a newline and point is on that newline. Fixes cursor
3631 positioning on the newline at EOL of R2L text within L2R
3632 paragraph, and vice versa.
3633 (try_cursor_movement): Check continued rows, in addition to
3634 continuation rows. Fixes unwarranted scroll when point enters a
3635 continued line of R2L text within an L2R paragraph, or vice versa.
3636 (cursor_row_p): Consider the case of point being equal to
3637 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3638 from the end of a short line to the beginning of a continued line
3639 of R2L text within L2R paragraph.
3640 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3641 composed characters.
5980d4c6 3642
f67cdd7f
EZ
3643 * bidi.c (bidi_check_type): Use xassert.
3644 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3645 members.
3646
bca633fb
EZ
36472011-08-23 Eli Zaretskii <eliz@gnu.org>
3648
3649 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3650 a character.
3651
4a5885a7
CY
36522011-08-23 Chong Yidong <cyd@stupidchicken.com>
3653
3654 * nsfont.m (ns_otf_to_script): Fix typo.
3655
0902a04e
KH
36562011-08-22 Kenichi Handa <handa@m17n.org>
3657
3658 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3659 extra slot even if the purpose is char-code-property-table.
3660
1a2e6670
EZ
36612011-08-23 Eli Zaretskii <eliz@gnu.org>
3662
8ddde651
EZ
3663 * xdisp.c (redisplay_window): When computing centering_position,
3664 account for the height of the header line. (Bug#8874)
3665
425cc014
EZ
3666 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3667 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3668 candidate is selected by the mouse, and that candidate has a
3669 composed character under the mouse.
3670
1a2e6670
EZ
3671 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3672 coordinates reported by pos-visible-in-window-p for a composed
3673 character in column zero.
3674
8b76d6f8
SM
36752011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3676
3677 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3678
dac347dd
EZ
36792011-08-22 Eli Zaretskii <eliz@gnu.org>
3680
3681 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3682 consider it a hit if to_charpos is anywhere in the range of the
3683 composed buffer positions.
3684
e013fb34
CY
36852011-08-22 Chong Yidong <cyd@stupidchicken.com>
3686
3687 * image.c (gif_load): Don't assume that each subimage has the same
3688 dimensions as the base image. Handle disposal method that is
3689 "undefined" by the gif spec (Bug#9335).
3690
bd1ba3e8
CY
36912011-08-20 Chong Yidong <cyd@stupidchicken.com>
3692
3693 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3694 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3695
54a1215b
EZ
36962011-08-19 Eli Zaretskii <eliz@gnu.org>
3697
823564e5
EZ
3698 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3699 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3700 from an Org mode buffer to a Speedbar frame.
3701
54a1215b
EZ
3702 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3703 a composition, take its buffer position from IT->cmp_it.charpos.
3704 Fixes cursor positioning at the beginning of a line that begins
3705 with a composed character.
3706
9778ebcc
EZ
37072011-08-18 Eli Zaretskii <eliz@gnu.org>
3708
0be6ee06
EZ
3709 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3710 character bidirectional type, use STRONG_L instead. Fixes crashes
3711 in a buffer produced by `describe-categories'.
3712
9778ebcc
EZ
3713 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3714 members before the level stack, so they would be saved and
3715 restored when copying iterator state. Fixes incorrect reordering
3716 around TABs covered by display properties.
3717
156bffbe
AS
37182011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3719
6b02f655 3720 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3721
72ad093b
CY
37222011-08-17 Chong Yidong <cyd@stupidchicken.com>
3723
3724 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3725 (internal_condition_case_2, internal_condition_case_n):
3726 Remove unnecessary aborts (Bug#9081).
72ad093b 3727
35774242
EZ
37282011-08-17 Eli Zaretskii <eliz@gnu.org>
3729
3730 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3731 has no `load' handler, try opening the file locally. (Bug#9311)
3732
db76dd85
KB
37332011-08-16 Ken Brown <kbrown@cornell.edu>
3734
3735 * gmalloc.c: Expand comment.
3736
b215eee5
EZ
37372011-08-16 Eli Zaretskii <eliz@gnu.org>
3738
3739 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3740 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3741
a4579d33
KB
37422011-08-16 Ken Brown <kbrown@cornell.edu>
3743
3744 Fix memory allocation problems in Cygwin build (Bug#9273).
3745
3746 * unexcw.c ( __malloc_initialized): Declare external variable.
3747 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3748
8b76d6f8
SM
3749 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3750 New variables.
a4579d33
KB
3751 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3752 dumped emacs.
3753 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3754 in the static heap.
3755 [CYGWIN] (special_realloc): New function.
3756 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3757 requests to realloc storage in the static heap.
3758
3ebec551
PE
37592011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3760
3761 * bidi.c (bidi_initialize): Remove unused local.
3762
9fd8be00
EZ
37632011-08-15 Eli Zaretskii <eliz@gnu.org>
3764
6b02f655
SM
3765 * bidimirror.h:
3766 * biditype.h: Remove file.
3767 * makefile.w32-in ($(BLD)/bidi.$(O)):
3768 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3769
3770 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3771
3772 * chartab.c: Improve commentary for the uniprop_table API.
3773
32413314
EZ
3774 * bidi.c (bidi_paragraph_init): Support zero value of
3775 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3776 (bidi_initialize): Use uniprop_table instead of including
3777 biditype.h and bidimirror.h.
32413314 3778
9fd8be00
EZ
3779 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3780 coordinates of the iterator when restoring from ppos_it.
3781 (Bug#9296)
3782
5cf2b69b
KH
37832011-08-14 Kenichi Handa <handa@m17n.org>
3784
3785 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3786 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3787
daf17d00
EZ
37882011-08-14 Eli Zaretskii <eliz@gnu.org>
3789
3790 * xdisp.c (move_it_in_display_line_to): Don't invoke
3791 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3792 ppos_it. Fixes vertical cursor motion when line beginning is
3793 covered by an image. (Bug#9296)
3794
08e3161a
JD
37952011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3796
3797 * nsterm.h (ns_run_ascript): Declare.
3798 (NSAPP_DATA2_RUNASSCRIPT): Define.
3799
3800 * nsfns.m (as_script, as_result, as_status): New static variables.
3801 (ns_run_ascript): New function.
5e617bc2 3802 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3803 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3804 the event loop. Get status from as_status (Bug#7276).
3805
3806 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3807 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3808 the event loop (Bug#7276).
3809
a3720aa2
AS
38102011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3811
3812 * gnutls.c (QCgnutls_bootprop_priority)
3813 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3814 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3815 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3816 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3817 (QCgnutls_bootprop_verify_hostname_error)
3818 (QCgnutls_bootprop_callbacks_verify): Rename from
3819 Qgnutls_bootprop_..., all uses changed.
3820
3821 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3822 uses changed.
3823
0a0d27fb
PE
38242011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3825
19d5c50c
PE
3826 * xfaces.c (Qframe_set_background_mode): Now static.
3827 * dispextern.h (Qframe_set_background_mode): Remove decl.
3828
0a0d27fb
PE
3829 * process.c (Fnetwork_interface_info): Declare local only if needed.
3830
377538cb
JD
38312011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3832
3833 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3834 (Fnetwork_interface_list): Allocate in increments of bytes instead
3835 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3836 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3837 sockaddr.
3838 (struct ifflag_def): notrailers is smart on OSX.
3839 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3840 Get hardware address with getifaddrs if available.
3841
08fff70c
EZ
38422011-08-12 Eli Zaretskii <eliz@gnu.org>
3843
3844 * xdisp.c (iterate_out_of_display_property): xassert that
3845 IT->position is set to within IT->object's boundaries. Break from
3846 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3847 when IT->position is set up wrongly due to some bug.
3848 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3849 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3850 entry. Force push_it to save on the stack the current
3851 buffer/string position, to be restored by pop_it. Fix flags in
3852 the iterator structure wrt the object coming from a display
3853 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3854 properties. (Bug#9284)
3855
7be1c708 38562011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3857
7be1c708
CY
3858 * fontset.c (fontset_get_font_group): Add proper type checks.
3859 (Bug#9172)
aac0c6e3 3860
7be1c708 38612011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3862
7be1c708
CY
3863 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3864 and LC_VERSION_MIN_MACOSX.
3865 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3866 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3867
97bb72a6
EZ
38682011-08-08 Eli Zaretskii <eliz@gnu.org>
3869
3870 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3871 no-display-properties-and-no-overlays under bidi display.
3872 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3873 properties and overlays.
97bb72a6 3874
d5617611
CY
38752011-08-08 Chong Yidong <cyd@stupidchicken.com>
3876
37e11a63
CY
3877 * editfns.c (Fset_time_zone_rule): Document relationship with the
3878 setenv function.
3879
d5617611
CY
3880 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3881 the font entity extracted from the cache (Bug#8109).
3882
58872834
CY
38832011-08-07 Chong Yidong <cyd@stupidchicken.com>
3884
3885 * composite.c (autocmp_chars): Don't reset point. That is done by
3886 restore_point_unwind (Bug#5984).
3887
75bfc667
JL
38882011-08-07 Juri Linkov <juri@jurta.org>
3889
3890 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3891 to show the arg `TIME' instead of `TIMEVAL'.
3892
d1410150
EZ
38932011-08-06 Eli Zaretskii <eliz@gnu.org>
3894
3895 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3896 display property strides EOL and includes a newline, as in
3897 longlines-mode. (Bug#9254)
75b771e4
EZ
3898 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3899 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3900
3901 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3902 is non-zero, even if the data buffer is NULL. Fixes a crash in
3903 vertical-motion with longlines-mode. (Bug#9254)
3904
35928349
EZ
39052011-08-05 Eli Zaretskii <eliz@gnu.org>
3906
ec7cc85b
EZ
3907 * bidi.c <bidi_cache_total_alloc>: Now static.
3908 (bidi_initialize): Initialize bidi_cache_total_alloc.
3909
8b76d6f8 3910 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3911 cache. (Bug#9221)
3912
3913 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3914 amount allocated this far in `bidi_cache_total_alloc'.
3915 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3916 non-zero, only free the data buffer without restoring the cache
3917 contents. All callers changed.
3918
3919 * dispextern.h (bidi_unshelve_cache): Update prototype.
3920
3921 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3922 (move_it_in_display_line, move_it_to)
3923 (move_it_vertically_backward, move_it_by_lines): Replace the call
3924 to xfree to an equivalent call to bidi_unshelve_cache.
3925 (move_it_in_display_line_to): Fix logic of returning
412b6358 3926 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3927
e2e2423b
EZ
39282011-08-05 Eli Zaretskii <eliz@gnu.org>
3929
3930 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3931 came from a string character with a `cursor' property. (Bug#9229)
3932
ae9e757a
JD
39332011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3934
3935 * Makefile.in (LIB_PTHREAD): New variable.
3936 (LIBES): Add LIB_PTHREAD (Bug#9216).
3937
3938 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3939 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3940
213bd7f2
AS
39412011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3942
6b02f655 3943 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3944
99aaf75f
JD
39452011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3946
3947 * xterm.c (x_find_topmost_parent): New function.
3948 (x_set_frame_alpha): Find topmost parent window with
3949 x_find_topmost_parent and set the property there also (bug#9181).
3950 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3951
c74e9d86
PE
39522011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3953
3954 * callproc.c (Fcall_process): Avoid vfork clobbering
3955 the local vars buffer, coding_systems, current_dir.
3956
640c8776
SM
39572011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3958
3959 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3960
f26d0e4c
PE
39612011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3962
8a10d76c
PE
3963 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3964 so that it is not optimized away.
3965
f26d0e4c
PE
3966 * xdisp.c (compute_display_string_pos): Remove unused local.
3967
55439c61
EZ
39682011-08-02 Eli Zaretskii <eliz@gnu.org>
3969
3970 Fix slow cursor motion and scrolling in large buffers with
3971 selective display, like Org Mode buffers. (Bug#9218)
3972
3973 * dispextern.h (struct bidi_it): New member disp_prop_p.
3974
3975 * xdisp.c: Remove one-slot cache of display string positions.
3976 (compute_display_string_pos): Accept an additional argument
5e617bc2 3977 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3978 for a display string or property. If found, set DISP_PROP_P
3979 non-zero.
3980
3981 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3982 DISP_PROP_P, and pass it to compute_display_string_pos.
3983 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3984 non-zero. All callers of bidi_fetch_char changed.
3985
fb33fa43
SM
39862011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3987
3988 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3989
b099e063
DM
39902010-12-03 Don March <don@ohspite.net>
3991
3992 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3993 last character M-[char] is translated to ESC [char] (bug#7541).
3994
5cc7f7af
KH
39952011-08-02 Kenichi Handa <handa@m17n.org>
3996
d0fffa3f 3997 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3998
3999 * chartab.c (uniprop_table): Make it non-static.
4000
525d5e6e
EZ
40012011-08-01 Eli Zaretskii <eliz@gnu.org>
4002
4003 * xdisp.c (forward_to_next_line_start): Accept additional argument
4004 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4005 on the newline.
4006 (reseat_at_next_visible_line_start): Use the bidi iterator state
4007 returned by forward_to_next_line_start to restore the state of
4008 it->bidi_it after backing up to previous newline. (Bug#9212)
4009
31011111
AS
40102011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4011
4012 * regex.c (re_comp): Protoize.
4013 (re_exec): Fix return type.
4014 (regexec): Fix type of `ret'. (Bug#9203)
4015
476371c4
PE
40162011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4017
e5d76069
PE
4018 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4019 This is needed if max-image-size is a floating-point number.
4020
9a79b20c
AS
40212011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4022
4023 * print.c (print_object): Print empty symbol as ##.
4024
4025 * lread.c (read1): Read ## as empty symbol.
4026
d8c2fa78
AA
40272011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4028
4029 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4030 setting frame foreground color (Bug#9175).
4031 (x_set_background_color): Likewise.
4032
ffe57a7a
AA
4033 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4034 contents (Bug#9176).
4035 (EmacsTooltip -init): Remove bezels and add shadows to
4036 tooltip windows.
4037
bf3492a5
AA
4038 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4039 or scroll bar (Bug#8470).
4040
d55e9c53
AA
4041 * nsfont.m (nsfont_open): Remove assignment to voffset and
4042 unnecessary vars hshink, expand, hd, full_height, min_height.
4043 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4044
4045 * nsterm.h (nsfont_info): Remove voffset field.
4046
d8c2fa78 40472011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
4048
4049 Implement strike-through and overline on NextStep (Bug#8863).
4050
4051 * nsfont.m (nsfont_open): Use underline position provided by font,
4052 instead of hard-coded value of 2.
4053 (nsfont_draw): Call ns_draw_text_decoration instead.
4054
4055 * nsterm.h: Add declaration for ns_draw_text_decoration.
4056
4057 * nsterm.m (ns_draw_text_decoration): New function for drawing
4058 underline, overline, and strike-through.
4059 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4060 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 4061 accommodate underlining, etc.
4843aac3 4062
4cc60b9b
EZ
40632011-07-28 Eli Zaretskii <eliz@gnu.org>
4064
bc7ece87
EZ
4065 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
4066 default.
4cc60b9b 4067
476371c4
PE
40682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4069
66606eea
PE
4070 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
4071 Without this fix, if a signal arrives just after memory fills up,
4072 'malloc' might be invoked reentrantly.
4073
476371c4
PE
4074 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4075 In other words, assume that every image size is allowed, on non-X
4076 hosts. This assumption is probably wrong, but it lets Emacs compile.
4077
f3fcc40d
AS
40782011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4079
4080 * regex.c (re_iswctype): Convert return values to boolean.
4081
350c992f
EZ
40822011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4083
4084 * xdisp.c (compute_display_string_pos): Don't use cached display
4085 string position if the buffer had its restriction changed.
4086 (Bug#9184)
4087
5266b4bb
PE
40882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4089
4090 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4091
2573a837 40922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 4093
41f55ccd 4094 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 4095
39e378da
PE
4096 * bidi.c: Integer size and overflow fixes.
4097 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4098 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4099 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4100 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4101 (bidi_find_other_level_edge):
4102 Use ptrdiff_t instead of EMACS_INT where either will do.
4103 This works better on 32-bit hosts configured --with-wide-int.
4104 (bidi_cache_ensure_space): Check for size-calculation overflow.
4105 Use % rather than repeated addition, for better worst-case speed.
4106 Don't set bidi_cache_size until after xrealloc returns, because it
4107 might not return.
4108 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
4109 (bidi_cache_ensure_space): Also check that the bidi cache size
4110 does not exceed that of the largest Lisp string or buffer. See Eli
4111 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 4112
5e927815
PE
4113 * alloc.c (__malloc_size_t): Remove.
4114 All uses replaced by size_t. See Andreas Schwab's note
4115 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4116
ca4aa935
PE
4117 * image.c: Improve checking for integer overflow.
4118 (check_image_size): Assume that f is nonnull, since
4119 it is always nonnull in practice. This is one less thing to
4120 worry about when checking for integer overflow later.
4121 (x_check_image_size): New function, which checks for integer
4122 overflow issues inside X.
4123 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4124 This removes the need for a memory_full check.
4125 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4126 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4127 (xbm_read_bitmap_data): Change locals back to 'int', since
4128 their values must fit in 'int'.
4129 (xpm_load_image, png_load, tiff_load):
4130 Invoke x_create_x_image_and_pixmap earlier,
4131 to avoid much needless work if the image is too large.
4132 (tiff_load): Treat overly large images as if
4133 x_create_x_image_and_pixmap failed, not as malloc failures.
4134 (gs_load): Use x_check_image_size.
4135
5f8f9cc2
PE
4136 * gtkutil.c: Omit integer casts.
4137 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4138 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4139
5adf60bc
PE
4140 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4141
c8907a93
PE
4142 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4143 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4144 would wrongly return t on a 64-bit host.
4145
e3c25c68
PE
4146 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4147 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4148 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4149 and therefore cause GCC to emit a bogus diagnostic in some cases.
4150
3f791afe
PE
4151 * image.c: Integer signedness and overflow and related fixes.
4152 This is not an exhaustive set of fixes, but it's time to
4153 record what I've got.
4154 (lookup_pixel_color, check_image_size): Remove redundant decls.
4155 (check_image_size): Don't assume that arbitrary EMACS_INT values
4156 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4157 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4158 (tiff_load, imagemagick_load_image):
4159 Check for overflow in size calculations.
4160 (x_create_x_image_and_pixmap): Remove unnecessary test for
4161 xmalloc returning NULL; that can't happen.
4162 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4163 (xpm_color_bucket): Use better integer hashing function.
4164 (xpm_cache_color): Don't possibly over-allocate memory.
4165 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4166 (gif_memory_source):
4167 Use ptrdiff_t, not int or size_t, to record sizes.
4168 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4169 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4170 either works, as we prefer signed integers.
4171 (tiff_read_from_memory, tiff_write_from_memory):
4172 Return tsize_t, not size_t, since that's what the TIFF API wants.
4173 (tiff_read_from_memory): Don't fail simply because the read would
4174 go past EOF; instead, return a short read.
4175 (tiff_load): Omit no-longer-needed casts.
4176 (Fimagemagick_types): Don't assume size fits into 'int'.
4177
3cc5a532
PE
4178 Improve hashing quality when configured --with-wide-int.
4179 * fns.c (hash_string): New function, taken from sxhash_string.
4180 Do not discard information about ASCII character case; this
4181 discarding is no longer needed.
4182 (sxhash-string): Use it. Change sig to match it. Caller changed.
4183 * lisp.h: Declare it.
4184 * lread.c (hash_string): Remove, since we now use fns.c's version.
4185 The fns.c version returns a wider integer if --with-wide-int is
4186 specified, so this should help the quality of the hashing a bit.
4187
b312a492
PE
4188 * emacs.c: Integer overflow minor fix.
4189 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4190 Define only if GNU_LINUX.
4191 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4192
dfd153ae
PE
4193 * dispnew.c: Integer signedness and overflow fixes.
4194 Remove unnecessary forward decls, that were a maintenance hassle.
4195 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4196 All uses changed.
4197 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4198 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4199 (prepare_desired_row, line_draw_cost):
4200 Use int, not unsigned, where either works.
4201 (save_current_matrix, restore_current_matrix):
4202 Use ptrdiff_t, not size_t, where either works.
4203 (init_display): Check for overflow more accurately, and without
4204 relying on undefined behavior.
4205
a81d11a3
PE
4206 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4207 Remove, replacing with the new symbols in lisp.h. All uses changed.
4208 * fileio.c (make_temp_name):
4209 * filelock.c (lock_file_1, lock_file):
4210 * xdisp.c (message_dolog):
4211 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4212 Use pMd etc. instead.
4213 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4214 replacing the pWIDE etc. symbols removed from editfns.c.
4215
3300e6fd
PE
4216 * keyboard.h (num_input_events): Now uintmax_t.
4217 This is (very slightly) less likely to mess up due to wraparound.
4218 All uses changed.
4219
fd05c7e9
PE
4220 * buffer.c: Integer signedness fixes.
4221 (alloc_buffer_text, enlarge_buffer_text):
4222 Use ptrdiff_t rather than size_t when either will do, as we prefer
4223 signed integers.
4224
903fe15d
PE
4225 * alloc.c: Integer signedness and overflow fixes.
4226 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4227 (__malloc_size_t): Default to size_t, not to int.
4228 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4229 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4230 Prefer ptrdiff_t to size_t when either would do, as we prefer
4231 signed integers.
4232 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4233 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4234 Now const. Initialize with values that are in range even if char
4235 is signed.
4236 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4237 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4238 These functions do the right thing with sizes > 2**32.
4239 (check_depth): Now ptrdiff_t, not int.
4240 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4241 Adjust to new way of storing sizes. Check for size overflow bugs
4242 in rest of code.
4243 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4244 slightly wrong anyway, as it missed one instance of
4245 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4246 (refill_memory_reserve): Omit needless cast to size_t.
4247 (mark_object_loop_halt): Mark as externally visible.
4248
ac82cc6a
PE
4249 * xselect.c: Integer signedness and overflow fixes.
4250 (Fx_register_dnd_atom, x_handle_dnd_message):
4251 Use ptrdiff_t, not size_t, since we prefer signed.
4252 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4253 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4254 x_dnd_atoms_size and x_dnd_atoms_length.
4255
c2d1e36d
PE
4256 * doprnt.c: Prefer signed to unsigned when either works.
4257 * eval.c (verror):
4258 * doprnt.c (doprnt):
4259 * lisp.h (doprnt):
4260 * xdisp.c (vmessage):
4261 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4262 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4263 prefer signed arithmetic to avoid comparison confusion.
4264 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4265 but is a bit tricky.
4266
0e926e56
PE
4267 Assume freestanding C89 headers, string.h, stdlib.h.
4268 * data.c, doprnt.c, floatfns.c, print.c:
4269 Include float.h unconditionally.
4270 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4271 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4272 * regex.c: Likewise for stddef.h, string.h.
4273 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4274 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4275 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4276 (STDC_HEADERS): Remove obsolete defines.
4277 * sysdep.c: Include limits.h unconditionally.
4278
9cfdb3ec
PE
4279 Assume support for memcmp, memcpy, memmove, memset.
4280 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4281 * regex.c (memcmp, memcpy):
4282 Remove; we assume C89 now.
4283
4284 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4285 (__malloc_safe_bcopy): Remove; no longer needed.
4286
cf950e6b 4287 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
4288 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4289 well either way, and we prefer signed to unsigned.
4290
dbf38e02
LMI
42912011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4292
4293 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4294 closes the connection while we're reading (bug#9182).
4295
d6f0886c 42962011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 4297
d6f0886c
JD
4298 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4299 are specified (Bug#9168).
24e0f6b1 4300
2eb1f9e6
PE
43012011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4302
4303 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4304 Found by GCC static checking and --with-wide-int on a 32-bit host.
4305
22381272 43062011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
4307
4308 * xdisp.c (compute_display_string_pos): Fix logic of caching
4309 previous display string position. Initialize cached_prev_pos to
4310 -1. Fixes slow-down at the beginning of a buffer.
4311
f25e39b4
EZ
43122011-07-24 Eli Zaretskii <eliz@gnu.org>
4313
4314 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4315 for attrs[LFACE_FONTSET_INDEX].
4316
04c4b52e
PE
43172011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4318
4319 * xml.c (parse_region): Remove unused local
4320 that was recently introduced.
4321
c1734fbd
EZ
43222011-07-23 Eli Zaretskii <eliz@gnu.org>
4323
be18c5a5
EZ
4324 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4325 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4326
c1734fbd
EZ
4327 * xdisp.c (move_it_in_display_line_to): Record the best matching
4328 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
4329 exit if none of the characters scanned was an exact match.
4330 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
4331 when exact match is impossible due to invisible text, and the
4332 lines are truncated.
4333
a258d627
JD
43342011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4335
4336 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4337 for OSX >= 10.7.
4338
b6d5a689
EZ
43392011-07-22 Eli Zaretskii <eliz@gnu.org>
4340
0f74f785
EZ
4341 Fix a significant slow-down of cursor motion with C-n, C-p,
4342 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4343 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 4344 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
4345 (next_element_from_buffer): Call compute_stop_pos_backwards to
4346 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
4347 base_level_stop.
4348 (reseat): Don't look for prev_stop, as that could mean a very long
4349 run.
4350 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4351 <cached_disp_overlay_modiff>: Cache for last found display string
4352 position.
551918c1 4353 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
4354 about the same buffer in the same area of character positions, and
4355 the buffer wasn't changed since the time the display string
4356 position was cached.
551918c1 4357
b2d0c91a
EZ
43582011-07-22 Eli Zaretskii <eliz@gnu.org>
4359
4360 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4361 is an integer, which is important for empty lines. (Bug#9149)
4362
043604ee
CY
43632011-07-22 Chong Yidong <cyd@stupidchicken.com>
4364
4365 * frame.c (Fmodify_frame_parameters): In tty case, update the
4366 default face if necessary (Bug#4238).
4367
da4adb04
CY
43682011-07-21 Chong Yidong <cyd@stupidchicken.com>
4369
4370 * editfns.c (Fstring_to_char): No need to explain what a character
4371 is in the docstring (Bug#6576).
4372
9abd0532
LMI
43732011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4374
4375 * xml.c (parse_region): Make sure we always return a tree.
4376
36881d16
HK
43772011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4378
4379 * xml.c (parse_region): If a document contains only comments,
4380 return that, too.
4381
1e98674d
LMI
43822011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4383
4384 * xml.c (make_dom): Return comments, too.
4385
590bd467
PE
43862011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4387
4388 Port to OpenBSD.
4389 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4390 and the surrounding thread.
4391 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4392 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4393 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4394 timer goes off.
4395 * s/openbsd.h (BROKEN_SIGIO): Define.
4396 * unexelf.c (unexec) [__OpenBSD__]:
4397 Don't update the .mdebug section of the Alpha COFF symbol table.
4398
f41628b2
LMI
43992011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4400
4401 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4402 (bug#8460).
4403
b59b67c5
PE
44042011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4405
15e3a074
PE
4406 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4407 This fixes some race conditions on the permissions of any newly
4408 created file.
4409
41bed37d
PE
4410 * alloc.c (valid_pointer_p): Use pipe, not open.
4411 This fixes some permissions issues when debugging.
4412
b59b67c5
PE
4413 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4414 If fchown fails to set both uid and gid, try to set just gid,
4415 as that is sometimes allowed. Adjust the file's mode to eliminate
4416 setuid or setgid bits that are inappropriate if fchown fails.
4417
925a6be7
SM
44182011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4419
4420 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4421 to compare Lisp_Objects.
4422 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4423 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4424 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4425
52968808
AS
44262011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4427
0a6a104b
AS
4428 * lread.c (read_integer): Unread even EOF character.
4429 (read1): Likewise. Properly record start position of symbol.
4430
52968808
AS
4431 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4432 symbol character follows.
4433
9e381cdd
PE
44342011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4435
4436 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4437 This works around a problem with the previous change to Fcopy_file.
4438 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4439 and without this change, GCC might complain about discarding
4440 fchown's return value.
4441
b5641435
JB
44422011-07-16 Juanma Barranquero <lekktu@gmail.com>
4443
4444 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4445
a8031457
PE
44462011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4447
4448 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4449
dd889327
LMI
44502011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4451
750c33f7
LMI
4452 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4453 it's used from the C level.
4454
dd889327
LMI
4455 * process.c: Use the same condition for POLL_FOR_INPUT in both
4456 keyboard.c and process.c (bug#1858).
4457
87e86684
LM
44582011-07-09 Lawrence Mitchell <wence@gmx.li>
4459
4460 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4461 (Fgnutls_boot): Use it.
4462
64348f40
AS
44632011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4464
4465 * doc.c (Fsubstitute_command_keys): Revert last change.
4466
1d698799
LMI
44672011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4468
f863868c
LMI
4469 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4470 quotes the next character, and doesn't affect other longer
4471 sequences (bug#8935).
4472
1d698799
LMI
4473 * lread.c (syms_of_lread): Clarify that is isn't only
4474 `eval-buffer' and `eval-defun' that's affected by
4475 `lexical-binding' (bug#8460).
4476
aa4b6df6
EZ
44772011-07-15 Eli Zaretskii <eliz@gnu.org>
4478
4479 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4480 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4481
5d856da6
PE
44822011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4483
ad6042bb
PE
4484 Fix minor problems found by static checking.
4485 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4486 (elsz): Now a signed constant, not a size_t var. We prefer signed
4487 types to unsigned, to avoid integer comparison confusion. Without
4488 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4489 "cannot optimize loop, the loop counter may overflow", a symptom
4490 of the confusion.
f00bbb22 4491 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4492 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4493
6468f31c
LMI
44942011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4495
49080b10
LMI
4496 * search.c (Fre_search_backward): Mention `case-fold-search' in
4497 all the re_search_* functions (bug#8138).
4498
6468f31c
LMI
4499 * keyboard.c (Fopen_dribble_file): Document when the file is
4500 closed (bug#8056).
4501
c965adc5
EZ
45022011-07-14 Eli Zaretskii <eliz@gnu.org>
4503
df9733bf
EZ
4504 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4505 bidi_cache_idx.
4506
0bb23927
EZ
4507 Support bidi reordering of display and overlay strings.
4508 * xdisp.c (compute_display_string_pos)
4509 (compute_display_string_end): Accept additional argument STRING.
4510 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4511 (reseat_to_string): Initialize bidi_it->string.s and
4512 bidi_it->string.schars.
4513 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4514 NULL (avoids a crash in bidi_paragraph_init).
4515 Initialize itb.string.lstring.
0bb23927
EZ
4516 (init_iterator): Call bidi_init_it only of a valid
4517 buffer position was specified. Initialize paragraph_embedding to
4518 L2R.
4519 (reseat_to_string): Initialize the bidi iterator.
4520 (display_string): If we need to ignore text properties of
4521 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4522 original value of -1 will not work with bidi.)
4523 (compute_display_string_pos): First arg is now struct
4524 `text_pos *'; all callers changed. Support display properties on
4525 Lisp strings.
4526 (compute_display_string_end): Support display properties on Lisp
4527 strings.
4528 (init_iterator, reseat_1, reseat_to_string): Initialize the
4529 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4530 when iterating on a string not from display properties).
640c8776
SM
4531 (compute_display_string_pos, compute_display_string_end):
4532 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4533 arrow keys.
4534 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4535 base_level_stop; instead, set base_level_stop to BEGV.
4536 Fixes crashes in vertical-motion.
0bb23927
EZ
4537 (next_element_from_buffer): Improve commentary for when
4538 the iterator is before prev_stop.
4539 (init_iterator): Initialize bidi_p from the default value of
4540 bidi-display-reordering, not from buffer-local value. Use the
4541 buffer-local value only if initializing for buffer iteration.
4542 (handle_invisible_prop): Support invisible properties on strings
4543 that are being bidi-reordered.
4544 (set_iterator_to_next): Support bidi reordering of C strings and
4545 Lisp strings.
4546 (next_element_from_string): Support bidi reordering of Lisp
4547 strings.
4548 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4549 (display_string): Support display of R2L glyph rows.
4550 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4551 (init_iterator): Don't initialize it->bidi_p for strings
4552 here.
4553 (reseat_to_string): Initialize it->bidi_p for strings here.
4554 (next_element_from_string, next_element_from_c_string)
4555 (next_element_from_buffer): Add xassert's for correspondence
4556 between IT's object being iterated and it->bidi_it.string
4557 structure.
4558 (face_before_or_after_it_pos): Support bidi iteration.
4559 (next_element_from_c_string): Handle the case of the first string
4560 character that is not the first one in the visual order.
4561 (get_visually_first_element): New function, refactored from common
4562 parts of next_element_from_buffer, next_element_from_string, and
4563 next_element_from_c_string.
4564 (tool_bar_lines_needed, redisplay_tool_bar)
4565 (display_menu_bar): Force left-to-right direction. Add a FIXME
4566 comment for making that be controlled by a user option.
4567 (push_it, pop_it): Save and restore the state of the
4568 bidi iterator. Save and restore the bidi_p flag.
4569 (pop_it): Iterate out of display property for string iteration as
4570 well.
4571 (iterate_out_of_display_property): Support iteration over strings.
4572 (handle_single_display_spec): Set up it->bidi_it for iteration
4573 over a display string, and call bidi_init_it.
4574 (handle_single_display_spec, next_overlay_string)
4575 (get_overlay_strings_1, push_display_prop): Set up the bidi
4576 iterator for displaying display or overlay strings.
4577 (forward_to_next_line_start): Don't use the shortcut if
4578 bidi-iterating.
4579 (back_to_previous_visible_line_start): If handle_display_prop
4580 pushed the iterator stack, restore the internal state of the bidi
4581 iterator by calling bidi_pop_it same number of times.
4582 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4583 and we are bidi-iterating, don't decrement the iterator position;
4584 instead, set the first_elt flag in the bidi iterator, to produce
4585 the same effect.
4586 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4587 (push_display_prop): xassert that we are iterating a buffer.
4588 (push_it, pop_it): Save and restore paragraph_embedding member.
4589 (handle_single_display_spec, next_overlay_string)
4590 (get_overlay_strings_1, reseat_1, reseat_to_string)
4591 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4592 correctly. Don't assume unibyte strings are not bidi-reordered.
4593 (compute_display_string_pos)
4594 (compute_display_string_end): Fix handling the case of C string.
4595 (push_it, pop_it): Save and restore from_disp_prop_p.
4596 (handle_single_display_spec, push_display_prop): Set the
4597 from_disp_prop_p flag.
4598 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4599 (pop_it): Call iterate_out_of_display_property only if we are
4600 popping after iteration over a string that came from a display
4601 property. Fix a typo in popping stretch info. Add an assertion
4602 for verifying that the iterator position is in sync with the bidi
4603 iterator.
4604 (handle_single_display_spec, get_overlay_strings_1)
4605 (push_display_prop): Fix initialization of paragraph direction for
4606 string when that of the parent object is not yet determined.
4607 (reseat_1): Call bidi_init_it to resync the bidi
4608 iterator with IT's position. (Bug#7616)
4609 (find_row_edges): If ROW->start.pos gives position
4610 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4611 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4612 Reset the from_disp_prop_p flag.
4613 (SAVE_IT, RESTORE_IT): New macros.
4614 (pos_visible_p, face_before_or_after_it_pos)
4615 (back_to_previous_visible_line_start)
4616 (move_it_in_display_line_to, move_it_in_display_line)
4617 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4618 (try_scrolling, redisplay_window, display_line): Use them when
4619 saving a temporary copy of the iterator and restoring it back.
4620 (back_to_previous_visible_line_start, reseat_1)
4621 (init_iterator): Empty the bidi cache "stack".
4622 (move_it_in_display_line_to): If iterator ended up at
4623 EOL, but we never saw any buffer positions smaller than
4624 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4625 motion in bidi-reordered lines.
4626 (move_it_in_display_line_to): Record prev_method and prev_pos
4627 immediately before the call to set_iterator_to_next. Fixes cursor
4628 motion in bidi-reordered lines with stretch glyphs and strings
4629 displayed in margins. (Bug#8133) (Bug#8867)
4630 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4631 TO_CHARPOS.
640c8776
SM
4632 (pos_visible_p): Support positions in bidi-reordered lines.
4633 Save and restore bidi cache.
0bb23927
EZ
4634
4635 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4636 (bidi_paragraph_info): Delete unused struct.
4637 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4638 (bidi_cache_start): New variable.
4639 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4640 to zero.
4641 (bidi_cache_fetch_state, bidi_cache_search)
4642 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4643 (bidi_cache_find, bidi_peek_at_next_level)
4644 (bidi_level_of_next_char, bidi_find_other_level_edge)
4645 (bidi_move_to_visually_next): Compare cache index with
4646 bidi_cache_start rather than with zero.
4647 (bidi_fetch_char): Accept new argument STRING; all callers
4648 changed. Support iteration over a string. Support strings with
4649 display properties. Support unibyte strings. Fix the type of
4650 `len' according to what STRING_CHAR_AND_LENGTH expects.
4651 (bidi_paragraph_init, bidi_resolve_explicit_1)
4652 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4653 (bidi_level_of_next_char, bidi_move_to_visually_next):
4654 Support iteration over a string.
0bb23927
EZ
4655 (bidi_set_sor_type, bidi_resolve_explicit_1)
4656 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4657 can now be zero (for strings); special values 0 and -1 were
4658 changed to -1 and -2, respectively.
4659 (bidi_char_at_pos): New function.
4660 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4661 Call it instead of FETCH_MULTIBYTE_CHAR.
4662 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4663 initialized to valid values.
4664 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4665 values.
4666 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4667 the test for valid cached positions. Fix the logic for looking up
4668 the sentinel state in the cache. GCPRO the Lisp string we are
4669 iterating.
4670 (bidi_push_it, bidi_pop_it): New functions.
4671 (bidi_initialize): Initialize the bidi cache start stack pointer.
4672 (bidi_cache_ensure_space): New function, refactored from part of
4673 bidi_cache_iterator_state. Don't assume the required size is just
4674 one BIDI_CACHE_CHUNK away.
4675 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4676 (bidi_count_bytes, bidi_char_at_pos): New functions.
4677 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4678 always valid if bidi_cache_idx is valid.
4679 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4680 is valid if it's going to be used.
4681 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4682 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4683 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4684 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4685 (bidi_find_other_level_edge, bidi_cache_start_stack):
4686 All variables related to cache indices are now EMACS_INT.
c965adc5 4687
0bb23927
EZ
4688 * dispextern.h (struct bidi_string_data): New structure.
4689 (struct bidi_it): New member `string'. Make flag members be 1-bit
4690 fields, and put them last in the struct.
640c8776
SM
4691 (compute_display_string_pos, compute_display_string_end):
4692 Update prototypes.
0bb23927
EZ
4693 (bidi_push_it, bidi_pop_it): Add prototypes.
4694 (struct iterator_stack_entry): New members bidi_p,
4695 paragraph_embedding, and from_disp_prop_p.
4696 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4697 (bidi_shelve_cache, bidi_unshelve_cache):
4698 Declare prototypes.
0bb23927
EZ
4699
4700 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4701 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4702 and vector-like objects.
4703
4704 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4705 cache around display iteration.
4706
4707 * window.c (Fwindow_end, window_scroll_pixel_based)
4708 (displayed_window_lines, Frecenter): Save and restore the bidi
4709 cache around display iteration.
4710
3bbd2265
LMI
47112011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4712
4713 * editfns.c (Fdelete_region): Clarify the use of the named
4714 parameters (bug#6788).
4715
adc47434
MR
47162011-07-14 Martin Rudalics <rudalics@gmx.at>
4717
4718 * indent.c (Fvertical_motion): Set and restore w->pointm when
4719 saving and restoring the window's buffer (Bug#9006).
4720
837c31f8
LMI
47212011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4722
4723 * editfns.c (Fstring_to_char): Clarify just what is returned
4724 (bug#6576). Text by Eli Zaretskii.
4725
ac389d0c
JB
47262011-07-13 Juanma Barranquero <lekktu@gmail.com>
4727
4728 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4729
0be0ce47
EZ
47302011-07-13 Eli Zaretskii <eliz@gnu.org>
4731
4732 * buffer.c (mmap_find): Fix a typo.
4733
cd18e7e3
JB
47342011-07-13 Johan Bockgård <bojohan@gnu.org>
4735
4736 Fix execution of x selection hooks.
4737 * xselect.c (Qx_lost_selection_functions)
4738 (Qx_sent_selection_functions): New vars.
4739 (syms_of_xselect): DEFSYM them.
4740 (x_handle_selection_request): Pass Qx_sent_selection_functions
4741 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4742 (x_handle_selection_clear,x_clear_frame_selections):
4743 Pass Qx_lost_selection_functions rather than
4744 Vx_lost_selection_functions to Frun_hook_with_args.
4745
47ea7f44
PE
47462011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4747
ac389d0c 4748 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4749 The old code sometimes used this field without initializing it.
4750
47ea7f44
PE
4751 * alloc.c (gc_sweep): Don't read past end of array.
4752 In theory, the old code could also have corrupted Emacs internals,
4753 though it'd be very unlikely.
4754
bc985c87
AS
47552011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4756
4757 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4758 argument. (Bug#4026)
bc985c87 4759
0cf34688
LMI
47602011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4761
b3dadd76
LMI
4762 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4763 key" (bug#4257).
4764
0cf34688
LMI
4765 * window.c (Fset_window_start): Doc fix (bug#4199).
4766 (Fset_window_hscroll): Ditto.
4767
270768cd
PE
47682011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4769
077e3dda 4770 Fix minor new problems caught by GCC 4.6.1.
270768cd 4771 * term.c (init_tty): Remove unused local.
490011a6 4772 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4773 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4774 not used otherwise.
270768cd 4775
b1f58454
CY
47762011-07-12 Chong Yidong <cyd@stupidchicken.com>
4777
4778 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4779
22b9578d
LMI
47802011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4781
6e70ab07
LMI
4782 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4783 are the mini-buffer and the echo area (bug#3320).
4784
22b9578d
LMI
4785 * term.c (init_tty): Remove support for supdup, c10 and perq
4786 terminals, which are no longer supported (bug#1482).
4787
8974cc9f
JB
47882011-07-10 Johan Bockgård <bojohan@gnu.org>
4789
4790 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4791
a560d974
JD
47922011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4793
4794 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4795 for non-popups (Bug#3642).
4796
1dae0f0a
AS
47972011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4798
268c2c36 4799 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4800 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4801 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4802 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4803 * data.c (fmod): Likewise.
4804 * dispnew.c (swap_glyphs_in_rows): Likewise.
4805 * emacs.c (memory_warning_signal): Likewise.
4806 * floatfns.c (float_error): Likewise.
4807 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4808 (otf_open, font_otf_capability, generate_otf_features)
4809 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4810 Likewise.
4811 * image.c (pbm_read_file): Likewise.
4812 * indent.c (string_display_width): Likewise.
4813 * intervals.c (check_for_interval, search_for_interval)
4814 (inc_interval_count, count_intervals, root_interval)
4815 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4816 * lread.c (defalias): Likewise.
268c2c36 4817 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4818 * regex.c (set_image_of_range_1, set_image_of_range)
4819 (regex_grow_registers): Likewise.
4820 * sysdep.c (strerror): Likewise.
4821 * termcap.c (valid_filename_p, tprint, main): Likewise.
4822 * tparam.c (main): Likewise.
4823 * unexhp9k800.c (run_time_remap, save_data_space)
4824 (update_file_ptrs, read_header, write_header, calculate_checksum)
4825 (copy_file, copy_rest, display_header): Likewise.
4826 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4827 Likewise.
4828 * xdisp.c (check_it): Likewise.
4829 * xfaces.c (register_color, unregister_color, unregister_colors):
4830 Likewise.
4831 * xfns.c (print_fontset_result): Likewise.
4832 * xrdb.c (member, fatal, main): Likewise.
4833
99033785
PE
48342011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4835
4836 Fix minor problems found by static checking (Bug#9031).
4837 * chartab.c (char_table_set_range, map_sub_char_table):
4838 Remove unused locals.
4839 (uniprop_table): Now static.
4840 * composite.c (_work_char): Remove unused static var.
4841
9cb2ac56
JB
48422011-07-09 Juanma Barranquero <lekktu@gmail.com>
4843
4844 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4845
f25661f0
JD
48462011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4847
4848 * gtkutil.c (qttip_cb): Remove code without function.
4849
8278c4fe
EZ
48502011-07-09 Eli Zaretskii <eliz@gnu.org>
4851
4852 * w32.c (pthread_sigmask): New stub.
4853
1692ae2d 48542011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4855
8a6ebd58 4856 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4857 sigprocmask is portable only for single-threaded applications, and
4858 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4859 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4860 (LIBES): Use it.
4861 * callproc.c (Fcall_process):
4862 * process.c (create_process):
4863 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4864 Use pthread_sigmask, not sigprocmask.
123403e4 4865
1b854618
JD
48662011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4867
4868 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4869 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4870 wrong (Bug#8591).
4871
3fe4b549
JD
48722011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4873
0ce7e563
JD
4874 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4875 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4876 (xg_hide_tooltip): Fix comment.
4877
3fe4b549
JD
4878 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4879 in registerServicesMenuSendTypes.
4880 (validRequestorForSendType): Don't check ns_return_types.
4881
4882 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4883 ns_return_type.
4884
5df75e47
JR
48852011-07-08 Jason Rumney <jasonr@gnu.org>
4886
22610910
JR
4887 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4888 SH_SHOW for hidden windows (Bug#5482).
4889
5df75e47
JR
4890 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4891 frame struct members of non-existent frames (Bug#6284).
4892
699c10bd
JD
48932011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4894
4393663b
JD
4895 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4896 variable firstTime not needed on OSX >= 10.6.
4897 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4898 >= 10.5. Use setKnobProportion, setDoubleValue.
4899
4900 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4901 (MAC_OS_X_VERSION_10_5): Define if not defined.
4902 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4903 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4904 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4905
4906 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4907 cString and lossyCString on OSX >= 10.4
4908
58179cce 4909 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4910 sizeToFit on OSX >= 10.2.
4911
4912 * nsimage.m (allocInitFromFile): Don't use deprecated method
4913 bestRepresentationForDevice on OSX >= 10.6.
4914
4915 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4916 to avoid warning.
4917
4918 * emacs.c: Declare unexec_init_emacs_zone.
4919
a63e0781
JD
4920 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4921
699c10bd
JD
4922 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4923
4924 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4925 on svcsMenu (Bug#8842).
4926
4927 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4928 ns_return_types.
4929 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4930
4931 * nsterm.m (QUTF8_STRING): Declare.
4932 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4933 (validRequestorForSendType): Return type is (id).
4934 Change indexOfObjectIdenticalTo to indexOfObject.
4935 Check if we have local selection before returning self (Bug#8842).
4936 (writeSelectionToPasteboard): Put local selection into paste board
4937 if we have a local selection (Bug#8842).
4938 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4939
4940 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4941 (ns_get_local_selection): Declare.
4942
54e10184
LMI
49432011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4944
9888ff71
LMI
4945 * keymap.c (describe_map_tree): Don't insert a double newline at
4946 the end of the buffer (bug#1169) and return whether we inserted
4947 something.
4948
54e10184
LMI
4949 * callint.c (Fcall_interactively): Change "reading args" to
4950 "providing args" to try to clarify what it does (bug#1010).
4951
15fa4783
KH
49522011-07-07 Kenichi Handa <handa@m17n.org>
4953
4954 * composite.c (composition_compute_stop_pos): Ignore a static
4955 composition starting before CHARPOS (Bug#8915).
4956
4957 * xdisp.c (handle_composition_prop): Likewise.
4958
a8815b00
EZ
49592011-07-07 Eli Zaretskii <eliz@gnu.org>
4960
4961 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4962 (Bug#9015)
4963
ef7b981d 49642011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4965
4966 * character.h (unicode_category_t): New enum type.
4967
4968 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4969 (Qchar_code_property_table): New variable.
4970 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4971 (UNIPROP_COMPRESSED_FORM_P): New macros.
4972 (char_table_ascii): Uncompress the compressed values.
4973 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4974 Uncompress the compressed values.
ac389d0c 4975 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4976 (char_table_ref_and_range): Uncompress the compressed values.
4977 (sub_char_table_set): New arg is_uniprop. Callers changed.
4978 Uncompress the compressed values.
4979 (sub_char_table_set_range): Args changed. Callers changed.
4980 (char_table_set_range): Adjuted for the above change.
4981 (map_sub_char_table): Delete args default_val and parent. Add arg
4982 top. Give decoded values to a Lisp function.
640c8776 4983 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4984 values to a Lisp function. Gcpro more variables.
4985 (uniprop_table_uncompress)
4986 (uniprop_decode_value_run_length): New functions.
4987 (uniprop_decoder, uniprop_decoder_count): New variables.
4988 (uniprop_get_decoder, uniprop_encode_value_character)
4989 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4990 New functions.
4991 (uniprop_encoder, uniprop_encoder_count): New variables.
4992 (uniprop_get_encoder, uniprop_table)
4993 (Funicode_property_table_internal, Fget_unicode_property_internal)
4994 (Fput_unicode_property_internal): New functions.
4995 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4996 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4997 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4998 char-code-property-alist.
4999
640c8776 5000 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
5001 Vunicode_category_table.
5002
640c8776 5003 * font.c (font_range): Adjust for the change of
c805dec0
KH
5004 Vunicode_category_table.
5005
76b397fb
DN
50062011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5007
5008 * m/iris4d.h: Remove file, move contents ...
5009 * s/irix6-5.h: ... here.
5010
22b4128e
PE
50112011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5012
5013 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
5014 * alloc.c (mark_buffer):
5015 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5016 (clone_per_buffer_values): Don't assume that
22b4128e
PE
5017 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5018 This isn't true in general, and it's particularly not true
5019 if Emacs is configured with --with-wide-int.
5020 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5021 New macros, used in the buffer.c change.
5022
869795d6
JD
50232011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5024
5025 * xsettings.c: Use both GConf and GSettings if both are available.
5026 (store_config_changed_event): Add comment.
5027 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5028 (store_tool_bar_style_changed): New functions.
5e617bc2 5029 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
5030 (struct xsettings): Move font inside HAVE_XFT.
5031 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 5032 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 5033 Move inside HAVE_XFT.
640c8776 5034 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
5035 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5036 also.
5037 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 5038 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 5039 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
5040 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5041 (parse_settings): Move check for font inside HAVE_XFT.
5042 (read_settings, apply_xft_settings): Add comment.
5043 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
5044 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5045 call store_font_name_changed.
5046 (xft_settings_event): Add comment.
5047 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5048 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5049 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5050 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5051 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
5052 (xsettings_get_system_font, xsettings_get_system_normal_font):
5053 Add comment.
869795d6 5054
d8ed26bd
PE
50552011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5056
5057 Random fixes. E.g., (random) never returned negative values.
5058 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5059 subseconds part to the entropy, as that's a bit more random.
5060 Prefer signed to unsigned, since the signedness doesn't matter and
5061 in general we prefer signed. When given a limit, use a
5062 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5063 latter isn't right if USE_2_TAGS_FOR_INTS.
5064 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5065 not 0..VALMASK. Don't discard "excess" bits that random () returns.
5066
cabf1cac
SM
50672011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5068
5069 * textprop.c (text_property_stickiness):
5070 Obey Vtext_property_default_nonsticky.
5071 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
5072 * w32fns.c (syms_of_w32fns):
5073 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
5074
6e9b2be9
PE
50752011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5076
5077 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
5078 This is more efficient than Ffile_directory_p and avoids a minor race.
5079
90186c68
LMI
50802011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
5081
7c301272
LMI
5082 * buffer.c (Foverlay_put): Say what the return value is
5083 (bug#7835).
5084
c4f2d8d4
LMI
5085 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5086 is a directory before asking whether to use the file name
5087 (bug#7564).
ad637907
LMI
5088 (barf_or_query_if_file_exists): Make the "File is a directory"
5089 error be more correct.
c4f2d8d4 5090
90186c68
LMI
5091 * fns.c (Frequire): Remove the mention of the .gz files, since
5092 that's installation-specific, but keep the mention of
5093 `get-load-suffixes'.
5094
da64016e
PE
50952011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5096
5097 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5098 Report string overflow if the output is too long.
5099
7d47b580
JB
51002011-07-04 Juanma Barranquero <lekktu@gmail.com>
5101
a555cb87
JB
5102 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5103 (syms_of_gnutls): Remove duplicate DEFSYM for
5104 Qgnutls_bootprop_verify_hostname_error, an error for
5105 Qgnutls_bootprop_verify_error (which is no longer used).
5106
7d47b580
JB
5107 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5108 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5109 Also (re)move comments that are misplaced or no longer relevant.
5110
1e49bfab
LMI
51112011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5112
5113 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5114
1485f4c0
CY
51152011-07-03 Chong Yidong <cyd@stupidchicken.com>
5116
5117 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5118 and background color parameters if they have been changed.
5119
a9ab721e
LMI
51202011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5121
5122 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5123
cf7cff57
PE
51242011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5125
2e13213d
PE
5126 * xsettings.c (SYSTEM_FONT): Define only when used.
5127 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5128
cf7cff57
PE
5129 * keymap.c (access_keymap_1): Now static.
5130
7a8e04f7
CY
51312011-07-02 Chong Yidong <cyd@stupidchicken.com>
5132
5133 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5134 leave any prefix arg for the up event (Bug#1586).
5135
61352f62
LMI
51362011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5137
69bb1ef7
LMI
5138 * lread.c (syms_of_lread): Mention single symbols defined by
5139 `defvar' or `defconst' (bug#7154).
5140
61352f62 5141 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 5142 (Frequire): Mention get-load-suffixes.
61352f62 5143
28545e04
MR
51442011-07-02 Martin Rudalics <rudalics@gmx.at>
5145
5146 * window.h (window): Remove clone_number slot.
5147 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5148 Remove.
5149 (make_parent_window, make_window, saved_window)
5150 (Fset_window_configuration, save_window_save): Don't deal with
5151 clone numbers.
5152 * buffer.c (Qclone_number): Remove declaration.
5153 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5154
3349e122
SM
51552011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5156
5157 Add multiple inheritance to keymaps.
5158 * keymap.c (Fmake_composed_keymap): New function.
5159 (Fset_keymap_parent): Simplify.
5160 (fix_submap_inheritance): Remove.
5161 (access_keymap_1): New function extracted from access_keymap to handle
5162 embedded parents and handle lists of maps.
5163 (access_keymap): Use it.
5164 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5165 (Fcopy_keymap): Handle embedded parents.
5166 (Fcommand_remapping, define_as_prefix): Simplify.
5167 (Fkey_binding): Simplify.
5168 (syms_of_keymap): Move minibuffer-local-completion-map,
5169 minibuffer-local-filename-completion-map,
5170 minibuffer-local-must-match-map, and
5171 minibuffer-local-filename-must-match-map to Elisp.
5172 (syms_of_keymap): Defsubr make-composed-keymap.
5173 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5174 (parse_menu_item): Trivial simplification.
5175
3279eb87
GM
51762011-07-01 Glenn Morris <rgm@gnu.org>
5177
5178 * Makefile.in (SETTINGS_LIBS): Fix typo.
5179
4550efdf
KI
51802011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5181
5182 * coding.c (Fencode_coding_string): Record the last coding system
5183 used, as the function doc string says (bug#8738).
5184
0949d2b6
JD
51852011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5186
5187 * xsettings.c (store_monospaced_changed): Take new font as arg and
5188 check for change against current_mono_font.
5189 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5190 (emacs_settings_constructor, emacs_settings_get_property)
5191 (emacs_settings_set_property, emacs_settings_class_init)
5192 (emacs_settings_init, gsettings_obj): Remove.
5193 (something_changedCB): New function for HAVE_GSETTINGS.
5194 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5195 with value as argument.
5196 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5197 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 5198 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
5199 "changed".
5200
5201 * xgselect.c: Add defined (HAVE_GSETTINGS).
5202 (xgselect_initialize): Ditto.
5203
5204 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5205 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5206 xg_select.
5207
bbc6b304
PE
52082011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5209
5210 * eval.c (struct backtrace): Simplify and port the data structure.
5211 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5212 signed bit field, as this assumption is not portable and it makes
5213 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5214 "char debug_on_exit : 1" as this is not portable either; instead,
5215 use the portable "unsigned int debug_on_exit : 1". Remove unused
5216 member evalargs. Remove obsolete comments about cc bombing out.
5217
9851bfc5
JD
52182011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5219
51bb811f 5220 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
5221 Let HAVE_GSETTINGS override HAVE_GCONF.
5222 (store_monospaced_changed): New function.
5223 (EMACS_SETTINGS): A new type derived from GObject to handle
5224 GSettings notifications.
5225 (emacs_settings_constructor, emacs_settings_get_property)
5226 (emacs_settings_set_property, emacs_settings_class_init):
5227 New functions.
5228 (gsettings_client, gsettings_obj): New variables.
5229 (GSETTINGS_SCHEMA): New define.
5230 (something_changedCB): Call store_monospaced_changed.
5231 (init_gsettings): New function.
5232 (xsettings_initialize): Call init_gsettings.
5233 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5234 to NULL.
5235
640c8776 5236 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
5237 GCONF_CFLAGS/LIBS.
5238
5386012d
MR
52392011-06-29 Martin Rudalics <rudalics@gmx.at>
5240
5241 * window.c (resize_root_window, grow_mini_window)
5242 (shrink_mini_window): Rename Qresize_root_window to
5243 Qwindow_resize_root_window and Qresize_root_window_vertically to
5244 Qwindow_resize_root_window_vertically.
5245
f13e0b08
PE
52462011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5247
5248 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5249
94515237
JB
52502011-06-27 Juanma Barranquero <lekktu@gmail.com>
5251
5252 * makefile.w32-in: Redesign dependencies so they reflect more
5253 clearly which files are directly included by each source file,
5254 and not through other includes.
5255
e43b6e43
MR
52562011-06-27 Martin Rudalics <rudalics@gmx.at>
5257
5258 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5259 (sort_overlays, overlay_strings): When an overlay's clone number
5260 matches the window's clone number process the overlay even if
5261 the overlay's window property doesn't match the current window.
5262
d68443dc
MR
5263 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5264 (Fwindow_hchild): Rename to Fwindow_left_child.
5265 (Fwindow_next): Rename to Fwindow_next_sibling.
5266 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
5267 (resize_window_check): Rename to window_resize_check.
5268 (resize_window_apply): Rename to window_resize_apply.
5269 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5270 (Fdelete_other_windows_internal, resize_frame_windows)
5271 (Fsplit_window_internal, Fdelete_window_internal)
5272 (grow_mini_window, shrink_mini_window)
5273 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 5274
c7e73be5
JD
52752011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5276
5277 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5278 (emacs_fixed_set_min_size): Remove.
5279 (emacs_fixed_new): Take frame as argument.
5280
5281 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5282 (_EmacsFixedPrivate): Remove minwidth/height.
5283 Add struct frame *f.
5284 (emacs_fixed_init): Initialize priv->f.
5285 (get_parent_class, emacs_fixed_set_min_size): Remove.
5286 (emacs_fixed_new): Set priv->f to argument.
5287 (emacs_fixed_get_preferred_width)
5288 (emacs_fixed_get_preferred_height): Use min_width/height from
5289 frames size_hint to set minimum and natural (Bug#8919).
5290 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5291 and use min_width/height from frames size_hint to set
5292 min_width/height (Bug#8919).
5293
5294 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
5295 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5296 Fix indentation.
c7e73be5 5297
cf99dcf8
EZ
52982011-06-26 Eli Zaretskii <eliz@gnu.org>
5299
5300 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5301 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5302 called at ZV.
5303
029529ac
CY
53042011-06-26 Chong Yidong <cyd@stupidchicken.com>
5305
5306 * process.c (wait_reading_process_output): Bypass select if
5307 waiting for a cell while ignoring keyboard input, and input is
5308 pending. Suggested by Jan Djärv (Bug#8869).
5309
7a7ef429
PE
53102011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5311
5312 Use gnulib's dup2 module instead of rolling our own.
5313 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5314
11fdef7d 53152011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
5316
5317 * dispnew.c (scrolling_window): Before scrolling, turn off a
5318 mouse-highlight in the window being scrolled.
5319
cd3520a4
JB
53202011-06-24 Juanma Barranquero <lekktu@gmail.com>
5321
5322 Move DEFSYM to lisp.h and use everywhere.
5323
5324 * character.h (DEFSYM): Move declaration...
5325 * lisp.h (DEFSYM): ...here.
5326
5327 * gnutls.c:
5328 * minibuf.c:
5329 * w32menu.c:
5330 * w32proc.c:
5331 * w32select.c: Don't include character.h.
5332
5333 * alloc.c (syms_of_alloc):
5334 * buffer.c (syms_of_buffer):
5335 * bytecode.c (syms_of_bytecode):
5336 * callint.c (syms_of_callint):
5337 * casefiddle.c (syms_of_casefiddle):
5338 * casetab.c (init_casetab_once):
5339 * category.c (init_category_once, syms_of_category):
5340 * ccl.c (syms_of_ccl):
5341 * cmds.c (syms_of_cmds):
5342 * composite.c (syms_of_composite):
5343 * dbusbind.c (syms_of_dbusbind):
5344 * dired.c (syms_of_dired):
5345 * dispnew.c (syms_of_display):
5346 * doc.c (syms_of_doc):
5347 * editfns.c (syms_of_editfns):
5348 * emacs.c (syms_of_emacs):
5349 * eval.c (syms_of_eval):
5350 * fileio.c (syms_of_fileio):
5351 * fns.c (syms_of_fns):
5352 * frame.c (syms_of_frame):
5353 * fringe.c (syms_of_fringe):
5354 * insdel.c (syms_of_insdel):
5355 * keymap.c (syms_of_keymap):
5356 * lread.c (init_obarray, syms_of_lread):
5357 * macros.c (syms_of_macros):
5358 * msdos.c (syms_of_msdos):
5359 * print.c (syms_of_print):
5360 * process.c (syms_of_process):
5361 * search.c (syms_of_search):
5362 * sound.c (syms_of_sound):
5363 * syntax.c (init_syntax_once, syms_of_syntax):
5364 * terminal.c (syms_of_terminal):
5365 * textprop.c (syms_of_textprop):
5366 * undo.c (syms_of_undo):
5367 * w32.c (globals_of_w32):
5368 * window.c (syms_of_window):
5369 * xdisp.c (syms_of_xdisp):
5370 * xfaces.c (syms_of_xfaces):
5371 * xfns.c (syms_of_xfns):
5372 * xmenu.c (syms_of_xmenu):
5373 * xsettings.c (syms_of_xsettings):
5374 * xterm.c (syms_of_xterm): Use DEFSYM.
5375
4228cf16
TZ
53762011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5377
cd3520a4 5378 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5379
7fcccf1e
PE
53802011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5381
7efb4e0e
PE
5382 Integer and buffer overflow fixes (Bug#8873).
5383
ff5844ad
PE
5384 * print.c (printchar, strout): Check for string overflow.
5385 (PRINTPREPARE, printchar, strout):
5386 Don't set size unless allocation succeeds.
5387
90532f02
PE
5388 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5389 for sizes. Check for string overflow more accurately.
5390 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5391
6d84508d
PE
5392 * macros.c: Integer and buffer overflow fixes.
5393 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5394 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5395 Use ptrdiff_t, not int, for sizes.
5396 Don't increment bufsize until after realloc succeeds.
5397 Check for size-calculation overflow.
5398 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5399
437b2cb4
PE
5400 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5401
8b9ac8b4
PE
5402 * lread.c: Integer overflow fixes.
5403 (read_integer): Radix is now EMACS_INT, not int,
5404 to improve quality of diagnostics for out-of-range radices.
5405 Calculate buffer size correctly for out-of-range radices.
5406 (read1): Check for integer overflow in radices, and in
5407 read-circle numbers.
82cb60d3
PE
5408 (read_escape): Avoid int overflow.
5409 (Fload, openp, read_buffer_size, read1)
5410 (substitute_object_recurse, read_vector, read_list, map_obarray):
5411 Use ptrdiff_t, not int, for sizes.
5412 (read1): Use EMACS_INT, not int, for sizes.
20270765 5413 Check for size overflow.
8b9ac8b4 5414
7fcccf1e
PE
5415 * image.c (cache_image): Check for size arithmetic overflow.
5416
bfbbd7e7
PE
5417 * lread.c: Integer overflow issues.
5418 (saved_doc_string_size, saved_doc_string_length)
5419 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5420 Now ptrdiff_t, not int.
5421 (read1): Don't assume doc string length fits in int. Check for
5422 out-of-range doc string lengths.
5423 (read_list): Don't assume file position fits in int.
39019e54 5424 (read_escape): Check for hex character overflow.
bfbbd7e7 5425
4e323265
LL
54262011-06-22 Leo Liu <sdl.web@gmail.com>
5427
5428 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5429 Move to minibuffer.el.
5430
85fece3e
PE
54312011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5432
20b84ce9 5433 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5434 The following patches are for when GLYPH_DEBUG && !XASSERT.
5435 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5436 * dispnew.c (flush_stdout):
5437 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5438 Mark as externally visible.
5439 * dispnew.c (check_window_matrix_pointers): Now static.
5440 * dispnew.c (window_to_frame_vpos):
5441 * xfns.c (unwind_create_frame):
5442 * xterm.c (x_check_font): Remove unused local.
5443 * scroll.c (CHECK_BOUNDS):
5444 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5445 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5446 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5447 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5448 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5449 Now static.
5450 (debug_method_add): Use va_list and vsprintf rather than relying
5451 on undefined behavior with wrong number of arguments.
5452 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5453 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5454 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5455 since we're not interested in debugging glyphs with old libraries.
5456 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5457 GCC 4.6.0's static checking.
5458
0766b489
PE
54592011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5460
31fd4b32
PE
5461 Integer overflow and signedness fixes (Bug#8873).
5462 A few related buffer overrun fixes, too.
5463
b79e8648
PE
5464 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5465
0766b489
PE
5466 * dispextern.h (struct face.stipple):
5467 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5468 (x_bitmap_mask, x_allocate_bitmap_record)
5469 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5470 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5471 (x_create_bitmap_from_xpm_data):
5472 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5473 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5474 (.bitmaps_last):
5475 * xfaces.c (load_pixmap):
5476 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5477 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5478 (.bitmaps_last, struct x_output.icon_bitmap):
5479 Use ptrdiff_t, not int, for bitmap indexes.
5480 (x_allocate_bitmap_record): Check for size overflow.
5481 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5482
b081724f
PE
5483 Use ptrdiff_t, not int, for overlay counts.
5484 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5485 * editfns.c (overlays_around, get_pos_property):
5486 * textprop.c (get_char_property_and_overlay):
5487 * xdisp.c (next_overlay_change, note_mouse_highlight):
5488 * xfaces.c (face_at_buffer_position):
21514da7
PE
5489 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5490 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5491 (Fnext_overlay_change, Fprevious_overlay_change)
5492 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5493 Use ptrdiff_t, not int, for sizes.
21514da7 5494 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5495
3de73e5e
PE
5496 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5497
2606c57b
PE
5498 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5499 (x_session_initialize): Do not assume string length fits in int.
5500
aaafe47a
PE
5501 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5502 This is unlikely, but can occur if DPI is outlandish.
5503
2674ddc8 5504 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5505 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5506
28154962
PE
5507 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5508 * xrdb.c (magic_file_p, search_magic_path):
5509 Omit last arg SUFFIX; it was always 0. All callers changed.
5510 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5511
7de51af5
PE
5512 * xfont.c (xfont_match): Avoid need for strlen.
5513
25ed6cc3
PE
5514 * xfns.c: Don't assume strlen fits in int.
5515 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5516
4eab31dd
PE
5517 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5518 not unsigned long, as we prefer signed integers. All callers changed.
5519 Detect integer overflow in repeat count.
5520 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5521 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5522
171e2a58
PE
5523 * termcap.c: Don't assume sizes fit in int and never overflow.
5524 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5525 (gobble_line): Check for size-calculation overflow.
5526
ad39faca 5527 * minibuf.c (Fread_buffer):
6e5bb2dc 5528 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5529 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5530 Don't assume string length fits in int.
5531
52c61c22 5532 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5533 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5534
b5b8c9e5
PE
5535 * font.c: Don't assume string length fits in int.
5536 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5537 Use ptrdiff_t, not int.
ccd6111c
PE
5538 (font_intern_prop): Don't assume string length fits in int.
5539 Don't assume integer property fits in fixnum.
5540 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5541
882f0d81 5542 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5543 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5544 Reformulate so as not to need the command string.
5545 Invoke gzip -cd rather than gunzip, as it's more portable.
5546 (lock_info_type, lock_file_1, lock_file):
5547 Don't assume pid_t and time_t fit in unsigned long.
5548 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5549 (current_lock_owner): Prefer signed type for sizes.
5550 Use memcpy, not strncpy, where memcpy is what is really wanted.
5551 Don't assume (via atoi) that time_t and pid_t fit in int.
5552 Check for time_t and/or pid_t out of range, e.g., via a network share.
5553 Don't alloca where an auto var works fine.
5554
93f4cf88
PE
5555 * fileio.c: Fix some integer overflow issues.
5556 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5557 Don't assume string length fits in int.
5558 (directory_file_name): Don't assume string length fits in long.
5559 (make_temp_name): Don't assume pid fits in int, or that its print
5560 length is less than 20.
5561
f3e92b69
PE
5562 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5563
1bfdaf10
PE
5564 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5565
35016e9a
PE
5566 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5567
3d1e65a1
PE
5568 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5569 We prefer signed integers, even for size calculations.
5570
0b963a93
PE
5571 * emacs.c: Don't assume string length fits in 'int'.
5572 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5573 (main): Don't invoke strlen when not needed.
5574
573f4b54
PE
5575 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5576 (XD_DEBUG_MESSAGE): Don't waste a byte.
5577
989f33ba
PE
5578 * callproc.c (getenv_internal_1, getenv_internal)
5579 (Fgetenv_internal):
965d34eb
PE
5580 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5581
e4d29b33
PE
5582 * lread.c (invalid_syntax): Omit length argument.
5583 All uses changed. This doesn't fix a bug, but it simplifies the
5584 code away from its former Hollerith-constant appearance, and it's
5585 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5586 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5587
eb49b136
PE
5588 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5589 This didn't break anything, but it didn't help either.
5590 It's confusing to put a bogus integer in a place where the actual
5591 value does not matter.
9f62aeb1 5592 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5593 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5594
15375a22
PE
5595 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5596 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5597 implementation.
b61cc01c
PE
5598 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5599 We prefer signed types, and the value cannot exceed the EMACS_INT
5600 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5601 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5602 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5603 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5604
53b2623d
PE
5605 * indent.c (sane_tab_width): New function.
5606 (current_column, scan_for_column, Findent_to, position_indentation)
5607 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5608 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5609
51cab52b 5610 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5611
f2ed8a70
PE
5612 * lisp.h (lint_assume): New macro.
5613 * composite.c (composition_gstring_put_cache):
5614 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5615
abe80cc6
PE
5616 * editfns.c, insdel.c:
5617 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5618
b02c740e
PE
5619 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5620
ebc96716
PE
5621 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5622
b4e50fa0 5623 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5624 Use much-faster test for byte-length change.
311d5d7c 5625 Don't assume string byte-length fits in 'int'.
a4cf38e4 5626 Check that character arg fits in 'int'.
85461888 5627 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5628
c0c1ee9f
PE
5629 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5630
a498d7f4
PE
5631 * fns.c (concat): Catch string overflow earlier.
5632 Do not rely on integer wraparound.
5633
51cab52b
PE
5634 * dispextern.h (struct it.overlay_strings_charpos)
5635 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5636 * xdisp.c (forward_to_next_line_start)
5637 (back_to_previous_visible_line_start)
5638 (reseat_at_next_visible_line_start, next_element_from_buffer):
5639 Don't arbitrarily truncate the value of 'selective' to int.
5640
76031fad
PE
5641 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5642
5eb55db9
PE
5643 * composite.c: Don't truncate sizes to 'int'.
5644 (composition_gstring_p, composition_reseat_it)
5645 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5646 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5647 not EMACS_UINT, for indexes.
5eb55db9 5648
0703a717
PE
5649 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5650
d6202519
PE
5651 * buffer.c: Include <verify.h>.
5652 (struct sortvec.priority, struct sortstr.priority):
8961a454 5653 Now EMACS_INT, not int.
c20998a7 5654 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5655 (struct sortstr.size, record_overlay_string)
5656 (struct sortstrlist.size, struct sortlist.used):
5657 Don't truncate size to int.
5658 (record_overlay_string): Check for size-calculation overflow.
d6202519 5659 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5660
d5a19415
JM
56612011-06-22 Jim Meyering <meyering@redhat.com>
5662
029529ac 5663 Don't leak an XBM-image-sized buffer
d5a19415
JM
5664 * image.c (xbm_load): Free the image buffer after using it.
5665
a9041e6c
PE
56662011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5667
5668 Port to Sun C.
5669 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5670 that Sun C diagnosed.
5671 * fns.c (secure_hash): Fix pointer signedness issue.
5672 * intervals.c (static_offset_intervals): New function.
5673 (offset_intervals): Use it.
5674
7f3f739f
LL
56752011-06-21 Leo Liu <sdl.web@gmail.com>
5676
5677 * deps.mk (fns.o):
5678 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5679 sha512.h.
5680
5681 * fns.c (secure_hash): Rename from crypto_hash_function and change
5682 the first arg to accept symbols.
5b66d427 5683 (Fsecure_hash): New primitive.
7f3f739f
LL
5684 (syms_of_fns): New symbols.
5685
76147d94
DD
56862011-06-20 Deniz Dogan <deniz@dogan.se>
5687
5688 * process.c (Fset_process_buffer): Clarify return value in
5689 docstring.
5690
7d7d0045
CY
56912011-06-18 Chong Yidong <cyd@stupidchicken.com>
5692
5693 * dispnew.c (add_window_display_history): Use BVAR.
5694
5695 * xdisp.c (debug_method_add): Use BVAR.
5696 (check_window_end, dump_glyph_matrix, dump_glyph)
5697 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5698
5699 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5700 Likewise.
5701
5702 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5703 check till after the cache is created in init_frame_faces.
5704
ff2bc410
SM
57052011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5706
5707 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5708
28177add
PE
57092011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5710
dd3482fe
PE
5711 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5712 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5713 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5714
393d71f3 5715 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5716 * fileio.c (Finsert_file_contents):
5717 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5718 Remove the old (too-loose) buffer overflow checks.
5719 They weren't needed, since make_gap checks for buffer overflow.
5720 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5721 The old code merely checked for Emacs fixnum overflow, and relied
5722 on undefined (wraparound) behavior. The new code avoids undefined
5723 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5724
2e6813b0 5725 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5726 Tune. Don't use wider integers than needed. Don't use alloca.
5727 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5728
599a9e4f
PE
5729 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5730
99561444
PE
5731 * insdel.c, lisp.h (buffer_overflow): New function.
5732 (insert_from_buffer_1, replace_range, replace_range_2):
5733 * insdel.c (make_gap_larger):
5734 * editfns.c (Finsert_char):
5735 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5736
28177add
PE
5737 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5738
e69dafad
PE
57392011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5740
4baa020d 5741 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5742
b1c46f02
PE
5743 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5744 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5745
e69dafad
PE
5746 * fileio.c: Don't assume EMACS_INT fits in off_t.
5747 (emacs_lseek): New static function.
5748 (Finsert_file_contents, Fwrite_region): Use it.
5749 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5750
566684ea
PE
5751 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5752
e6966cd6
PE
5753 * fns.c: Don't overflow int when computing a list length.
5754 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5755 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5756 truncation on 64-bit hosts. Check for QUIT every
5757 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5758 faster and is responsive enough.
5759 (Flength): Report an error instead of overflowing an integer.
5760 (Fsafe_length): Return a float if the value is not representable
5761 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5762 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5763 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5764
dd0b0efb
PE
5765 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5766 (header_size, word_size): New constants.
5767 (allocate_vectorlike): Don't check size overflow here.
5768 (allocate_vector): Check it here instead, since this is the only
5769 caller of allocate_vectorlike that could cause overflow.
5770 Check that the new vector's length is representable as a fixnum.
5771
86fe5cfe
PE
5772 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5773 The previous code was bogus. For example, next_almost_prime (32)
5774 returned 39, which is undesirable as it is a multiple of 3; and
5775 next_almost_prime (24) returned 25, which is a multiple of 5 so
5776 why was the code bothering to check for multiples of 7?
5777
80e88859
PE
5778 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5779
4a2f0ad6
PE
5780 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5781
f66c7cf8
PE
5782 Variadic C functions now count arguments with ptrdiff_t.
5783 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5784 Back then I didn't know that the Emacs coding style prefers signed int.
5785 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5786 were being counted with int, which may truncate counts on 64-bit
5787 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5788 * lisp.h (struct Lisp_Subr.function.aMANY)
5789 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5790 Arg counts are now ptrdiff_t, not size_t.
5791 All variadic functions and their callers changed accordingly.
5792 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5793 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5794 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5795 * callint.c (Fcall_interactively): Check arg count for overflow,
5796 to avoid potential buffer overrun. Use signed char, not 'int',
5797 for 'varies' array, so that we needn't bother to check its size
5798 calculation for overflow.
5799 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5800 * eval.c (apply_lambda):
5801 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5802 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5803 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5804
a1759b76
PE
5805 * callint.c (Fcall_interactively): Don't use index var as event count.
5806
d96be9fc
PE
5807 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5808 * mem-limits.h (SIZE): Remove; no longer used.
5809
a690a978 5810 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5811
578c21e6
PE
5812 Remove unnecessary casts.
5813 * xterm.c (x_term_init):
5814 * xfns.c (x_set_border_pixel):
5815 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5816 These aren't needed now that we assume ANSI C.
5817
96f53c6c
PE
5818 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5819 It's more likely to cause problems (due to unsigned overflow)
5820 than to cure them.
5821
83c77d31
PE
5822 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5823
ee2079f1
PE
5824 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5825
6da65536
PE
5826 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5827
7147c4a4
PE
5828 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5829
193e32d9
PE
5830 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5831
e5533da6
PE
5832 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5833
9910e595
PE
5834 GLYPH_CODE_FACE returns EMACS_INT, not int.
5835 * dispextern.h (merge_faces):
5836 * xfaces.c (merge_faces):
01103c44
PE
5837 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5838 Don't assume EMACS_INT fits in int.
9910e595 5839
2638320e
PE
5840 * character.h (CHAR_VALID_P): Remove unused parameter.
5841 * fontset.c, lisp.h, xdisp.c: All uses changed.
5842
045eb8d9
PE
5843 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5844
c1f134b5
PE
5845 * fns.c (concat): Minor tuning based on overflow analysis.
5846 This doesn't fix any bugs. Use int to hold character, instead
5847 of constantly refetching from Emacs object. Use XFASTINT, not
5848 XINT, for value known to be a character. Don't bother comparing
5849 a single byte to 0400, as it's always less.
5850
395fcb93 5851 * floatfns.c (Fexpt):
327eeec8
PE
5852 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5853
abbd3d23
PE
5854 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5855 for characters.
5856
684a03ef
PE
5857 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5858
0fed43f3
PE
5859 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5860 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5861 incorrectly succeed when S was a string, because 4294967386 was
5862 truncated before it was used.
5863
8fd02eb7
PE
5864 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5865 Otherwise, an out-of-range integer could cause undefined behavior
5866 on a 64-bit host.
5867
f8c86b69
PE
5868 * composite.c: Use int, not EMACS_INT, for characters.
5869 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5870 EMACS_INT, for values that are known to be in character range.
5871 This doesn't fix any bugs but is the usual style inside Emacs and
5872 may generate better code on 32-bit machines.
5873
34206dd2
PE
5874 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5875 This is for reasons similar to the recent CHAR_STRING fix.
5876 * charset.c (Fencode_char): Check that character arg is actually
5877 a character. Pass an int to ENCODE_CHAR.
5878 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5879 wider than 'int', as a compile-time check to prevent future regressions
5880 in this area.
5881
c5958d4c 5882 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5883
5884 Make sure a 64-bit char is never passed to CHAR_STRING.
5885 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5886 by silently ignoring the top 32 bits, allowing some values
5887 that were far too large to be valid characters.
5888 * character.h: Include <verify.h>.
5889 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5890 arguments are no wider than unsigned, as a compile-time check
5891 to prevent future regressions in this area.
5892 * data.c (Faset):
01103c44 5893 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5894 (Fsubst_char_in_region):
5895 * fns.c (concat):
5896 * xdisp.c (decode_mode_spec_coding):
5897 Adjust to CHAR_STRING's new requirement.
5898 * editfns.c (Finsert_char, Fsubst_char_in_region):
5899 * fns.c (concat): Check that character args are actually
5900 characters. Without this test, these functions did the wrong
5901 thing with wildly out-of-range values on 64-bit hosts.
5902
d37ca623
PE
5903 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5904 These casts should not be needed on 32-bit hosts, either.
5905 * keyboard.c (read_char):
5906 * lread.c (Fload): Remove casts to unsigned.
5907
ea204efb
PE
5908 * lisp.h (UNSIGNED_CMP): New macro.
5909 This fixes comparison bugs on 64-bit hosts.
5910 (ASCII_CHAR_P): Use it.
5911 * casefiddle.c (casify_object):
01103c44 5912 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5913 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5914 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5915 * dispextern.h (FACE_FROM_ID):
5916 * keyboard.c (read_char): Use UNSIGNED_CMP.
5917
41cb286c
PE
5918 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5919 not to EMACS_INT, to avoid GCC warning.
5920
4a1b9832
PE
5921 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5922
55daad71
PE
5923 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5924 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5925 isn't needed on 32-bit machines.
8f95c75c 5926
01103c44
PE
5927 * buffer.c (Fgenerate_new_buffer_name):
5928 Use EMACS_INT for count, not int.
0ceccced 5929 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5930
5931 * data.c (Qcompiled_function): Now static.
5932
c6f072e7
PE
5933 * window.c (window_body_lines): Now static.
5934
20ce5912
PE
5935 * image.c (gif_load): Rename local to avoid shadowing.
5936
9c4c5f81
PE
5937 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5938 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5939 * alloc.c (make_save_value): Integer argument is now of type
5940 ptrdiff_t, not int.
5941 (mark_object): Use ptrdiff_t, not int.
5942 * lisp.h (pD): New macro.
5943 * print.c (print_object): Use it.
5944
c0c5c8ae
PE
5945 * alloc.c: Use EMACS_INT, not int, to count objects.
5946 (total_conses, total_markers, total_symbols, total_vector_size)
5947 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5948 (total_free_floats, total_floats, total_free_intervals)
5949 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5950 Now EMACS_INT, not int. All uses changed.
5951 (Fgarbage_collect): Compute overall total using a double, so that
5952 integer overflow is less likely to be a problem. Check for overflow
5953 when converting back to an integer.
5a25e253
PE
5954 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5955 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5956 These were 'int' variables that could overflow on 64-bit hosts;
5957 they were never used, so remove them instead of repairing them.
211a0b2a 5958 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5959 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5960 Previously, this ceilinged at INT_MAX, but that doesn't work on
5961 64-bit machines.
e46bb31a 5962 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5963
c78baabf 5964 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5965 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5966 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5967 when a (possibly-narrower) signed value would do just as well.
5968 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5969
c9d624c6
PE
5970 * alloc.c: Catch some string size overflows that we were missing.
5971 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5972 for convenience in STRING_BYTES_MAX.
5973 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5974 The definition here is exact; the one in lisp.h was approximate.
5975 (allocate_string_data): Check for string overflow. This catches
5976 some instances we weren't catching before. Also, it catches
5977 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5978 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5979 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5980
c9d624c6
PE
5981 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5982 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5983 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5984
353032ce
PE
5985 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5986
2bccce07
PE
5987 * alloc.c (Fmake_string): Check for out-of-range init.
5988
0ac30604
SM
59892011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5990
5991 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5992
c195f2de
JD
59932011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5994
5995 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5996 xg_get_default_scrollbar_width.
5997
5998 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5999 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6000 (style_changed_cb): Call update_theme_scrollbar_width and call
6001 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6002 all frames (Bug#8505).
6003 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6004 Call gtk_window_set_resizable if HAVE_GTK3.
6005 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6006 and height if HAVE_GTK3 (Bug#8505).
6007 (scroll_bar_width_for_theme): New variable.
6008 (update_theme_scrollbar_width): New function.
6009 (xg_get_default_scrollbar_width): Move code to
6010 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6011 (xg_initialize): Call update_theme_scrollbar_width.
6012
6013 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6014
6015 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6016
e10ac9f1
MR
60172011-06-12 Martin Rudalics <rudalics@gmx.at>
6018
6019 * frame.c (make_frame): Call other_buffer_safely instead of
6020 other_buffer.
6021
6022 * window.c (temp_output_buffer_show): Call display_buffer with
6023 second argument Vtemp_buffer_show_specifiers and reset latter
6024 immediately after the call.
6025 (Vtemp_buffer_show_specifiers): New variable.
6026 (auto_window_vscroll_p, next_screen_context_lines)
6027 (Vscroll_preserve_screen_position): Remove leading asterisks from
6028 doc-strings.
6029
2d3c217e 60302011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 6031
7b7f97e8 6032 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
6033 * buffer.c (Qclone_number): Remove for now, as it's unused.
6034 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6035 (record_buffer): Remove unused local.
6036 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6037 (set_frame_buffer_list): Remove; unused.
6038 * frame.h (other_visible_frames): Remove decl.
6039 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6040 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6041 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
6042 if HAVE_GPM.
6043 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
6044 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6045 Define only if HAVE_GPM.
6046 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6047 (update_hints_inhibit): Remove; never set. All uses removed.
6048 * widgetprv.h (emacsFrameClassRec): Remove decl.
6049 * window.c (delete_deletable_window): Now returns void, since it
6050 wasn't returning anything.
6051 (compare_window_configurations): Remove unused locals.
6052 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
6053 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
6054 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6055 the same widths as pointers. This follows up on the 2011-05-06 patch.
6056 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6057 * xterm.h: Likewise.
6058 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6059
1384b89e
JB
60602011-06-12 Juanma Barranquero <lekktu@gmail.com>
6061
6062 * makefile.w32-in: Update dependencies.
6063 (LISP_H): Add lib/intprops.h.
6064
1100a63c
CY
60652011-06-11 Chong Yidong <cyd@stupidchicken.com>
6066
6067 * image.c (gif_load): Add animation frame delay to the metadata.
6068 (syms_of_image): Use DEFSYM. New symbol `delay'.
6069
6198ccd0
MR
60702011-06-11 Martin Rudalics <rudalics@gmx.at>
6071
6072 * window.c (delete_deletable_window): Re-add.
6073 (Fset_window_configuration): Rewrite to handle dead buffers and
6074 consequently deletable windows.
6075 (window_tree, Fwindow_tree): Remove. Supply functionality in
6076 window.el.
6077 (compare_window_configurations): Simplify code.
6078
b6e3633c
AS
60792011-06-11 Andreas Schwab <schwab@linux-m68k.org>
6080
1ab0dee5
AS
6081 * image.c (imagemagick_load_image): Fix type mismatch.
6082 (Fimagemagick_types): Likewise.
6083
b6e3633c
AS
6084 * window.h (replace_buffer_in_windows): Declare.
6085
9397e56f
MR
60862011-06-11 Martin Rudalics <rudalics@gmx.at>
6087
6088 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6089 Qclone_number. Remove external declaration of Qdelete_window.
6090 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6091 code.
640c8776
SM
6092 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6093 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
6094 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6095 buffer list implementation.
6096 (other_buffer_safely): New function.
6097 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6098 calls to replace_buffer_in_windows and
6099 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6100 if allowed.
6101 (record_buffer): Inhibit quitting and rewrite using quittable
6102 functions. Run Qbuffer_list_update_hook if allowed.
6103 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
6104 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6105 Move switch-to-buffer to window.el.
9397e56f
MR
6106 (bury-buffer): Move to window.el.
6107 (Vbuffer_list_update_hook): New variable.
6108
6109 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6110 section.
6111
6112 * window.h (resize_frame_windows): Move up in code.
6113 (Fwindow_frame): Remove EXFUN.
6114 (replace_buffer_in_all_windows): Remove prototype.
6115 (replace_buffer_in_windows_safely): Add prototype.
6116
6117 * window.c: Declare Qdelete_window static again. Move down
6118 declaration of select_count.
6119 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6120 (Fother_window): Move to window.el.
6121 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6122 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6123 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6124 window.el.
6125 (replace_buffer_in_windows): Implement by calling
6126 Qreplace_buffer_in_windows.
6127 (replace_buffer_in_all_windows): Remove with some functionality
6128 moved into replace_buffer_in_windows_safely.
6129 (replace_buffer_in_windows_safely): New function.
6130 (select_window_norecord, select_frame_norecord): Move in front
6131 of run_window_configuration_change_hook. Remove now obsolete
6132 declarations.
640c8776
SM
6133 (Fset_window_buffer): Rewrite doc-string.
6134 Call Qrecord_window_buffer.
9397e56f
MR
6135 (keys_of_window): Move binding for other-window to window.el.
6136
b50691aa
CY
61372011-06-11 Chong Yidong <cyd@stupidchicken.com>
6138
6139 * dispextern.h (struct image): Replace data member, whose int_val
6140 and ptr_val fields were not used by anything, with a single
6141 lisp_val object.
6142
6143 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6144 (gif_clear_image, gif_load, imagemagick_load_image)
6145 (gs_clear_image, gs_load): Callers changed.
6146
3f754b86
PE
61472011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6148
cca69397
PE
6149 * buffer.h: Include <time.h>, for time_t.
6150 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6151
109e28d0
PE
6152 Fix minor problems found by static checking.
6153
60737f02
PE
6154 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6155
4b66faf3
PE
6156 Make identifiers static if they are not used in other modules.
6157 * data.c (Qcompiled_function, Qframe, Qvector):
6158 * image.c (QimageMagick, Qsvg):
6159 * minibuf.c (Qmetadata):
6160 * window.c (resize_window_check, resize_root_window): Now static.
6161 * window.h (resize_window_check, resize_root_window): Remove decls.
6162
109e28d0
PE
6163 * window.c (window_deletion_count, delete_deletable_window):
6164 Remove; unused.
46a4ce9e
PE
6165 (window_body_lines): Now static.
6166 (Fdelete_other_windows_internal): Mark vars as initialized.
6167 Make sure 'resize_failed' is initialized.
6168 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6169 (resize_window_apply): Remove unused local.
6170 * window.h (delete_deletable_window): Remove decl.
6171
109e28d0 6172 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
6173 (imagemagick_load_image): Fix pointer signedness problem by changing
6174 last arg from unsigned char * to char *. All uses changed.
6175 Also, fix a local for similar reasons.
6176 Remove unused locals. Remove locals to avoid shadowing.
6177 (fn_rsvg_handle_free): Remove; unused.
6178 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 6179 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 6180
3f754b86
PE
6181 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6182
2547adb1
CY
61832011-06-10 Chong Yidong <cyd@stupidchicken.com>
6184
6185 * image.c (gif_load): Fix omitted cast error introduced by
6186 2011-06-06 change.
6187
2c8e37d4
MR
61882011-06-10 Martin Rudalics <rudalics@gmx.at>
6189
6190 * window.h (resize_proportionally, orig_total_lines)
6191 (orig_top_line): Remove from window structure.
6192 (set_window_height, set_window_width, change_window_heights)
6193 (Fdelete_window): Remove prototypes.
6194 (resize_frame_windows): Remove duplicate declaration.
6195
440a42e3
EZ
61962011-06-10 Eli Zaretskii <eliz@gnu.org>
6197
6198 * window.h (resize_frame_windows, resize_window_check)
6199 (delete_deletable_window, resize_root_window)
6200 (resize_frame_windows): Declare prototypes.
6201
6202 * window.c (resize_window_apply): Make definition be "static" to
6203 match the prototype.
6204
562dd5e9
MR
62052011-06-10 Martin Rudalics <rudalics@gmx.at>
6206
6207 * window.c: Remove declarations of Qwindow_size_fixed,
6208 window_min_size_1, window_min_size_2, window_min_size,
6209 size_window, window_fixed_size_p, enlarge_window, delete_window.
6210 Remove static from declaration of Qdelete_window, it's
6211 temporarily needed by Fbury_buffer.
6212 (replace_window): Don't assign orig_top_line and
6213 orig_total_lines.
6214 (Fdelete_window, delete_window): Remove. Window deletion is
6215 handled by window.el.
640c8776
SM
6216 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6217 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
6218 (Fdelete_other_windows): Remove. Deleting other windows is
6219 handled by window.el.
6220 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6221 handled in window.el.
6222 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6223 Window minimum sizes are handled in window.el.
6224 (shrink_windows, size_window, set_window_height)
6225 (set_window_width, change_window_heights, window_height)
6226 (window_width, CURBEG, CURSIZE, enlarge_window)
6227 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6228 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6229 handled in window.el.
6230 (make_dummy_parent): Rename to make_parent_window and give it a
6231 second argument horflag.
6232 (make_window): Don't set resize_proportionally any more.
6233 (Fsplit_window): Remove. Windows are split in window.el.
6234 (save_restore_action, save_restore_orig_size)
6235 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6236 Resize mini windows in window.el.
6237 (grow_mini_window, shrink_mini_window): Implement by calling
6238 Qresize_root_window_vertically, resize_window_check and
6239 resize_window_apply.
640c8776
SM
6240 (saved_window, Fset_window_configuration, save_window_save):
6241 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
6242 resize_proportionally.
6243 (window_min_height, window_min_width): Move to window.el.
6244 (keys_of_window): Move bindings for delete-other-windows,
6245 split-window, delete-window and enlarge-window to window.el.
6246
6247 * buffer.c: Temporarily extern Qdelete_window.
6248 (Fbury_buffer): Temporarily call Qdelete_window instead of
6249 Fdelete_window (Fbury_buffer will move to window.el soon).
6250
6251 * frame.c (set_menu_bar_lines_1): Remove code handling
6252 orig_top_line and orig_total_lines.
6253
6254 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6255 set_window_height but set heights directly.
6256 (change_frame_size_1): Use resize_frame_windows.
6257
6258 * xdisp.c (init_xdisp): Don't use set_window_height but set
6259 heights directly.
6260
640c8776
SM
6261 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6262 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
6263 run_window_configuration_change_hook.
6264
6265 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6266 instead of change_window_heights and run
6267 run_window_configuration_change_hook.
6268
1a13852e
MR
62692011-06-09 Martin Rudalics <rudalics@gmx.at>
6270
6271 * window.c (replace_window): Rename second argument REPLACEMENT to
6272 NEW. New third argument SETFLAG. Rewrite.
6273 (delete_window, make_dummy_parent): Call replace_window with
6274 third argument 1.
6275 (window_list_1): Move down in code.
6276 (run_window_configuration_change_hook): Move set_buffer part
6277 before select_frame_norecord part in order to unwind correctly.
6278 Rename count1 to count.
6279 (recombine_windows, delete_deletable_window, resize_root_window)
6280 (Fdelete_other_windows_internal)
6281 (Frun_window_configuration_change_hook, make_parent_window)
6282 (resize_window_check, resize_window_apply, Fresize_window_apply)
6283 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
6284 (Fdelete_window_internal, Fresize_mini_window_internal):
6285 New functions.
1a13852e
MR
6286 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6287
f3d1777e
MR
62882011-06-08 Martin Rudalics <rudalics@gmx.at>
6289
496e208e
MR
6290 * window.h (window): Add some new members to window structure -
6291 normal_lines, normal_cols, new_total, new_normal, clone_number,
6292 splits, nest, prev_buffers, next_buffers.
6293 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 6294 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 6295
f3d1777e
MR
6296 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6297 Remove.
496e208e
MR
6298 (make_dummy_parent): Set new members of windows structure.
6299 (make_window): Move down in code. Handle new members of window
6300 structure.
6301 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6302 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6303 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6304 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
6305 (Fset_window_next_buffers, Fset_window_clone_number):
6306 New functions.
496e208e
MR
6307 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6308 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6309 Doc-string fixes.
6310 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6311 Argument WINDOW can be now internal window too.
6312 (Fwindow_use_time): Move up in code.
6313 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6314 Rewrite doc-string.
6315 (Fset_window_configuration, saved_window)
6316 (Fcurrent_window_configuration, save_window_save): Handle new
6317 members of window structure.
b9e809c2
MR
6318 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6319 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6320 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6321 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6322 Qget_mru_window, Qresize_root_window,
6323 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6324 Qauto_buffer_name; staticpro them.
f3d1777e 6325
abde8f8c
MR
63262011-06-07 Martin Rudalics <rudalics@gmx.at>
6327
6328 * window.c (Fwindow_total_size, Fwindow_left_column)
6329 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6330 (Fwindow_list_1): New functions.
6331 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
6332 (Fwindow_width, Fscroll_left, Fscroll_right):
6333 Use window_body_cols instead of window_box_text_cols.
6334 (delete_window, Fset_window_configuration):
6335 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
6336 (delete_all_subwindows): Take a window as argument and not a
6337 structure. Rewrite.
190b47e6
MR
6338 (window_loop): Remove handling of GET_LRU_WINDOW and
6339 GET_LARGEST_WINDOW.
6340 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
6341
6342 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
6343 window_box_text_cols. delete_all_subwindows now takes a
6344 Lisp_Object as argument.
abde8f8c 6345
640c8776
SM
6346 * indent.c (compute_motion, Fcompute_motion):
6347 Use window_body_cols instead of window_box_text_cols.
abde8f8c 6348
fa8a67e6
MR
6349 * frame.c (delete_frame): Call delete_all_subwindows with root
6350 window as argument.
6351
a54e3482
DC
63522011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6353
6354 * fns.c (Fputhash): Document return value.
6355
60002bf5
CY
63562011-06-06 Chong Yidong <cyd@stupidchicken.com>
6357
6358 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6359
0c671da6 63602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6361
b862a52a 6362 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6363
be44ca6c
PE
6364 Check for overflow when converting integer to cons and back.
6365 * charset.c (Fdefine_charset_internal, Fdecode_char):
6366 Use cons_to_unsigned to catch overflow.
6367 (Fencode_char): Use INTEGER_TO_CONS.
6368 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6369 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6370 * data.c (long_to_cons, cons_to_long): Remove.
6371 (cons_to_unsigned, cons_to_signed): New functions.
6372 These signal an error for invalid or out-of-range values.
6373 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6374 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6375 * font.c (Ffont_variation_glyphs):
6376 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6377 * lisp.h: Include <intprops.h>.
6378 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6379 (cons_to_signed, cons_to_unsigned): New decls.
6380 (long_to_cons, cons_to_long): Remove decls.
6381 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6382 (Fprimitive_undo): Use CONS_TO_INTEGER.
6383 * xfns.c (Fx_window_property): Likewise.
6384 * xselect.c: Include <limits.h>.
6385 (x_own_selection, selection_data_to_lisp_data):
6386 Use INTEGER_TO_CONS.
6387 (x_handle_selection_request, x_handle_selection_clear)
6388 (x_get_foreign_selection, Fx_disown_selection_internal)
6389 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6390 (lisp_data_to_selection_data): Use cons_to_unsigned.
6391 (x_fill_property_data): Use cons_to_signed.
6392 Report values out of range.
6393
d1f3d2af
PE
6394 Check for buffer and string overflow more precisely.
6395 * buffer.h (BUF_BYTES_MAX): New macro.
6396 * lisp.h (STRING_BYTES_MAX): New macro.
6397 * alloc.c (Fmake_string):
6398 * character.c (string_escape_byte8):
6399 * coding.c (coding_alloc_by_realloc):
6400 * doprnt.c (doprnt):
6401 * editfns.c (Fformat):
6402 * eval.c (verror):
6403 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6404 since they may not be the same number.
6405 * editfns.c (Finsert_char):
6406 * fileio.c (Finsert_file_contents):
6407 Likewise for BUF_BYTES_MAX.
6408
dd52fcea
PE
6409 * image.c: Use ptrdiff_t, not int, for sizes.
6410 (slurp_file): Switch from int to ptrdiff_t.
6411 All uses changed.
6412 (slurp_file): Check that file size fits in both size_t (for
6413 malloc) and ptrdiff_t (for sanity and safety).
6414
7f9bbdbb
PE
6415 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6416 if b->modtime has its maximal value.
6417
dfe18f82
PE
6418 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6419
84acfcf0
PE
6420 Don't assume time_t can fit into int.
6421 * buffer.h (struct buffer.modtime): Now time_t, not int.
6422 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6423 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6424
ccd9a01a
PE
6425 Minor fixes for signed vs unsigned integers.
6426 * character.h (MAYBE_UNIFY_CHAR):
6427 * charset.c (maybe_unify_char):
6428 * keyboard.c (read_char, reorder_modifiers):
6429 XINT -> XFASTINT, since the integer must be nonnegative.
6430 * ftfont.c (ftfont_spec_pattern):
6431 * keymap.c (access_keymap, silly_event_symbol_error):
6432 XUINT -> XFASTINT, since the integer must be nonnegative.
6433 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6434 since it makes no difference and we prefer signed.
6435 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6436 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6437 nonnegative.
6438
d6d100dd
SM
64392011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6440
6441 * window.h (Fwindow_frame): Declare.
6442
2b6148e4
PE
64432011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6444
6445 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6446 (SPARE_MEMORY): Always define.
6447 (LARGE_REQUEST): Remove.
6448 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6449
f230ecc9
MR
64502011-06-06 Martin Rudalics <rudalics@gmx.at>
6451
727e958e
MR
6452 * lisp.h: Move EXFUNS for Fframe_root_window,
6453 Fframe_first_window and Fset_frame_selected_window to window.h.
6454
6455 * window.h: Move EXFUNS for Fframe_root_window,
6456 Fframe_first_window and Fset_frame_selected_window here from
6457 lisp.h.
6458
6459 * frame.c (Fwindow_frame, Fframe_first_window)
6460 (Fframe_root_window, Fframe_selected_window)
6461 (Fset_frame_selected_window): Move to window.c.
6462 (Factive_minibuffer_window): Move to minibuf.c.
6463 (Fother_visible_frames_p): New function.
6464
6465 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6466
f230ecc9
MR
6467 * window.c (decode_window, decode_any_window): Move up in code.
6468 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6469 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6470 (Fwindow_buffer): Move up and rewrite doc-string.
6471 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6472 (Fwindow_prev): New functions.
727e958e
MR
6473 (Fwindow_frame): Move here from frame.c. Accept any window as
6474 argument.
6475 (Fframe_root_window, Fframe_first_window)
6476 (Fframe_selected_window): Move here from frame.c. Accept frame
6477 or arbitrary window as argument. Update doc-strings.
6478 (Fminibuffer_window): Move up in code.
6479 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6480 (Fset_frame_selected_window): Move here from frame.c.
6481 Marginal rewrite.
727e958e
MR
6482 (Fselected_window, select_window, Fselect_window): Move up in
6483 code. Minor doc-string fixes.
f230ecc9 6484
4d09bcf6
PE
64852011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6486
6487 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6488 Do not assume that spare memory exists; that assumption is valid
6489 only if SYSTEM_MALLOC.
6490 (LARGE_REQUEST): New macro, so that the issue of large requests
6491 is separated from the issue of spare memory.
6492
810928a2
AS
64932011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6494
172418ad
AS
6495 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6496 format. (Bug#8806)
6497
43f862f7
AS
6498 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6499
810928a2
AS
6500 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6501 before statements.
6502
a059fe24
JD
65032011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6504
6505 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6506
6507 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6508
6509 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6510 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6511
989bf368
JB
65122011-06-05 Juanma Barranquero <lekktu@gmail.com>
6513
6514 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6515
4b80f674
CY
65162011-06-04 Chong Yidong <cyd@stupidchicken.com>
6517
6518 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6519 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6520 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6521 New error handlers.
4b80f674
CY
6522 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6523 Obey Vx_select_enable_clipboard_manager. Catch errors in
6524 x_clipboard_manager_save (Bug#8779).
6525 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6526 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6527
99a33b77 65282011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6529
6530 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6531
99a33b77 65322011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6533
6534 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6535 in the current matrix if keep_current_p is non-zero.
6536
8264569d
EZ
65372011-06-04 Eli Zaretskii <eliz@gnu.org>
6538
6539 * bidi.c (bidi_level_of_next_char): Fix last change.
6540
57f97249
EZ
65412011-06-03 Eli Zaretskii <eliz@gnu.org>
6542
fec2107c 6543 Support bidi reordering of text covered by display properties.
57f97249 6544
fec2107c
EZ
6545 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6546 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6547 (bidi_cache_search, bidi_cache_iterator_state)
6548 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6549 (bidi_level_of_next_char, bidi_move_to_visually_next):
6550 Support character positions inside a run of characters covered by a
fec2107c
EZ
6551 display string.
6552 (bidi_paragraph_init, bidi_resolve_explicit_1)
6553 (bidi_level_of_next_char): Call bidi_fetch_char and
6554 bidi_fetch_char_advance instead of FETCH_CHAR and
6555 FETCH_CHAR_ADVANCE.
6556 (bidi_init_it): Initialize new members.
6557 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6558 definitions.
6559 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6560 instead of using explicit *_CHAR codes.
d6d100dd
SM
6561 (bidi_resolve_explicit, bidi_resolve_weak):
6562 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6563 bidirectional text is supported only in multibyte buffers.
6564 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6565 it to initialize the frame_window_p member of struct bidi_it.
6566 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6567 (bidi_resolve_explicit, bidi_resolve_weak)
6568 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6569 bidi_it->nchars is non-positive.
6570 (bidi_level_of_next_char): Don't try to lookup the cache for the
6571 next/previous character if nothing is cached there yet, or if we
6572 were just reseat()'ed to a new position.
c40e2fb2 6573
0e14fe90
EZ
6574 * xdisp.c (set_cursor_from_row): Set start and stop points
6575 according to the row's direction when priming the loop that looks
6576 for the glyph on which to display cursor.
6577 (single_display_spec_intangible_p): Function deleted.
6578 (display_prop_intangible_p): Reimplement to call
6579 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6580 Accept 3 additional arguments needed by handle_display_spec.
6581 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6582 values: lists, `(when COND...)' forms, etc.
6583 (single_display_spec_string_p): Support property values that are
6584 lists with the argument STRING its top-level element.
6585 (display_prop_string_p): Fix the condition for processing a
6586 property that is a list to be consistent with handle_display_spec.
fec2107c 6587 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6588 last portion of handle_display_prop.
6589 (compute_display_string_pos): Accept additional argument
6590 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6591 value of a `display' property is a "replacing spec".
6592 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6593 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6594 the display property, but just return a value indicating whether
6595 the display property will replace the characters it covers.
6596 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6597 frame_window_p members of struct bidi_it.
d6d100dd
SM
6598 (compute_display_string_pos, compute_display_string_end):
6599 New functions.
fec2107c
EZ
6600 (push_it): Accept second argument POSITION, where pop_it should
6601 jump to continue iteration.
6602 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6603
fec2107c
EZ
6604 * keyboard.c (adjust_point_for_property): Adjust the call to
6605 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6606
6607 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6608 (bidi_init_it): Update prototypes.
6609 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6610 (compute_display_string_pos, compute_display_string_end):
6611 Declare prototypes.
fec2107c
EZ
6612 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6613 EMACS_INT.
fc6f18ce 6614
40087514 66152011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6616
57f53182
PE
6617 Malloc failure behavior now depends on size of allocation.
6618 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6619 * lisp.h: Change signatures accordingly.
6620 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6621 All callers changed. (Bug#8762)
6622
6623 * gnutls.c: Use Emacs's memory allocators.
6624 Without this change, the gnutls library would invoke malloc etc.
6625 directly, which causes problems on non-SYNC_INPUT hosts, and which
6626 runs afoul of improving memory_full behavior. (Bug#8761)
6627 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6628 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6629 xfree instead of the default malloc, realloc, free.
6630 (Fgnutls_boot): No need to check for memory allocation failure,
6631 since xmalloc does that for us.
6632
ac32cd99 6633 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6634 * category.c (hash_get_category_set):
6635 * ccl.c (ccl_driver):
6636 * charset.c (Fdefine_charset_internal):
6637 * charset.h (struct charset.hash_index):
6638 * composite.c (get_composition_id, gstring_lookup_cache)
6639 (composition_gstring_put_cache):
6640 * composite.h (struct composition.hash_index):
6641 * dispextern.h (struct image.hash):
6642 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6643 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6644 (hashfn_equal, hashfn_user_defined, make_hash_table)
6645 (maybe_resize_hash_table, hash_lookup, hash_put)
6646 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6647 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6648 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6649 * image.c (make_image, search_image_cache, lookup_image)
6650 (xpm_put_color_table_h):
6651 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6652 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6653 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6654 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6655 * alloc.c (allocate_vectorlike):
6656 Check for overflow in vector size calculations.
6657 * ccl.c (ccl_driver):
6658 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6659 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6660 need to be updated by these changes.
40087514
PE
6661 * fns.c (make_hash_table, maybe_resize_hash_table):
6662 Check for integer overflow with large hash tables.
0de4bb68
PE
6663 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6664 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6665 (SXHASH_REDUCE): New macro.
6666 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6667 Use it instead of discarding useful hash info with large hash values.
6668 (sxhash_float): New function.
6669 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6670 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6671 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6672 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6673 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6674 Adjust signatures to match updated version of code.
6675 (consing_since_gc): Now EMACS_INT, since a single hash table can
6676 use more than INT_MAX bytes.
6677
698d32e2
DN
66782011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6679
6680 Make it possible to build with GCC-4.6+ -O2 -flto.
6681
6682 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6683
fd6fa53f
SM
66842011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6685
6686 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6687 Call minibuffer-inactive-mode.
6688
864db017
JB
66892011-05-31 Juanma Barranquero <lekktu@gmail.com>
6690
6691 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6692 Update dependencies.
6693
2ad0baf4
DN
66942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6695
6696 * data.c (init_data): Remove code for UTS, this system is not
6697 supported anymore.
6698
4fcc2638
DN
66992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6700
6701 Don't force ./temacs to start in terminal mode.
6702
6703 * frame.c (make_initial_frame): Initialize faces in all cases, not
6704 only when CANNOT_DUMP is defined.
6705 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6706
c56e0fd5
DN
67072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6708
6709 * dispnew.c (add_window_display_history): Use const for the string
6710 pointer. Remove declaration, not needed.
6711
333d54da 67122011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6713
55d4c1b2 6714 Use 'inline', not 'INLINE'.
333d54da 6715 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6716 * alloc.c, fontset.c (INLINE): Remove.
6717 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6718 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6719 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6720 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6721 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6722
738db178
DN
67232011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6724
6725 Make it possible to run ./temacs.
6726
6727 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6728 syms_of_callproc does the same thing. Remove test for
6729 "initialized", do it in the caller.
6730 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6731
620c53a6
SM
67322011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6733
6734 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6735 (read_minibuf): Use get_minibuffer.
6736 (syms_of_minibuf): Use DEFSYM.
6737 (Qmetadata): New var.
6738 * data.c (Qbuffer): Don't make it static.
6739 (syms_of_data): Use DEFSYM.
6740
e003a292
PE
67412011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6742
6743 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6744 (CCL_CODE_MIN): New macro.
6745
ed008a6d
PE
67462011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6747
3687c2ef
PE
6748 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6749
ed008a6d
PE
6750 * eval.c (Qdebug): Now static.
6751 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6752 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6753 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6754
d66c4c7c
CY
67552011-05-29 Chong Yidong <cyd@stupidchicken.com>
6756
6757 * image.c: Various fixes to ImageMagick code comments.
6758 (Fimagemagick_types): Doc fix.
6759
5fbc2025
PE
67602011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6761
0196f88a
PE
6762 Minor fixes prompted by GCC 4.6.0 warnings.
6763
6764 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6765
5fbc2025
PE
6766 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6767 (x_clipboard_manager_save_all): Move extern decl to ...
6768 * xterm.h: ... here, so that it can be checked for consistency.
6769
1dd3c2d9
CY
67702011-05-29 Chong Yidong <cyd@stupidchicken.com>
6771
6772 * xselect.c (x_clipboard_manager_save_frame)
6773 (x_clipboard_manager_save_all): New functions.
6774 (Fx_clipboard_manager_save): Lisp function deleted.
6775
6776 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6777 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6778
6779 * xterm.h: Update prototype.
6780
5ba6571d
WX
67812011-05-28 William Xu <william.xwl@gmail.com>
6782
6783 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6784 exiting (Bug#8239).
6785
3eaff834
JM
67862011-05-28 Jim Meyering <meyering@redhat.com>
6787
e1900994 6788 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6789 * fns.c (to_uchar): Define.
6790 (crypto_hash_function): Use it to convert some newly-signed
6791 variables to unsigned, to avoid sign-extension bugs. For example,
6792 without this change, (md5 "truc") would evaluate to
6793 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6794 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6795 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6796
0f6990a7
PE
67972011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6798
6799 Integer overflow fixes.
c8a9ca5a 6800
08686060
PE
6801 * dbusbind.c: Serial number integer overflow fixes.
6802 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6803 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6804 to hold a serial number that is too large for a fixnum.
6805 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6806 Check for serial numbers out of range. Decode any serial number
59568bf0 6807 that was so large that it became a float. (Bug#8722)
08686060 6808
2d1fc3c7
PE
6809 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6810 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6811 Use XFASTINT rather than XUINT when numbers are nonnegative.
6812 (xd_append_arg, Fdbus_method_return_internal):
6813 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6814 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6815 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6816 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6817 (Bug#8722)
2d1fc3c7 6818
c8a9ca5a
PE
6819 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6820
519e1d69
PE
6821 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6822
6df6ae42 6823 ccl: Add integer overflow checks.
30569699
PE
6824 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6825 (IN_INT_RANGE): New macros.
6826 (ccl_driver): Use them to check for integer overflow when
6827 decoding a CCL program. Many of the new checks are whether XINT (x)
6828 fits in int; it doesn't always, on 64-bit hosts. The new version
6829 doesn't catch all possible integer overflows, but it's an
847044ea 6830 improvement. (Bug#8719)
30569699 6831
c11285dc
PE
6832 * alloc.c (make_event_array): Use XINT, not XUINT.
6833 There's no need for unsigned here.
6834
fdccd48e
PE
6835 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6836 This follows up to the 2011-05-06 change that substituted uintptr_t
6837 for EMACS_INT. This case wasn't caught back then.
6838
37910ab2
PE
6839 Rework Fformat to avoid integer overflow issues.
6840 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6841 now (part of C89). Include <verify.h>.
6842 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6843 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6844 (Fformat): Avoid the prepass trying to compute sizes; it was only
6845 approximate and thus did not catch overflow reliably. Instead, walk
6846 through the format just once, formatting and computing sizes as we go,
6847 checking for integer overflow at every step, and allocating a larger
6848 buffer as needed. Keep track separately whether the format is
6849 multibyte. Keep only the most-recently calculated precision, rather
6850 than them all. Record whether each argument has been converted to
6851 string. Use EMACS_INT, not int, for byte and char and arg counts.
6852 Support field widths and precisions larger than INT_MAX. Avoid
6853 sprintf's undefined behavior with conversion specifications such as %#d
6854 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6855 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6856 formatting out-of-range floating point numbers with int
9173deec 6857 formats. (Bug#8668)
37910ab2 6858
2e6578fb
PE
6859 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6860
0ae6bdee
PE
6861 * data.c: Avoid integer truncation in expressions involving floats.
6862 * data.c: Include <intprops.h>.
6863 (arith_driver): When there's an integer overflow in an expression
6864 involving floating point, convert the integers to floating point
6865 so that the resulting value does not suffer from catastrophic
6866 integer truncation. For example, on a 64-bit host (* 4
6867 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6868 Do not rely on undefined behavior after integer overflow.
6869
de883a70
PE
6870 merge count_size_as_multibyte, parse_str_to_multibyte
6871 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6872 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6873 Check for integer overflow.
6874 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6875 since it's now a duplicate of the other. This is more of
6876 a character than a buffer op, so better that it's in character.c.
6877 * fns.c, print.c: Adjust to above changes.
6878
2ff916cb
PE
68792011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6880
6881 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6882
f1b54466
PE
68832011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6884
fb1ac845
PE
6885 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6886 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6887 (x_clipboard_manager_save): Now static.
6888 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6889
f1b54466
PE
6890 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6891 (crypto_hash_function): Now static.
6892 Fix pointer signedness problems. Avoid unnecessary initializations.
6893
a9f737ee
CY
68942011-05-27 Chong Yidong <cyd@stupidchicken.com>
6895
6896 * termhooks.h (Vselection_alist): Make it terminal-local.
6897
6898 * terminal.c (create_terminal): Initialize it.
6899
6900 * xselect.c: Support for clipboard managers.
6901 (Vselection_alist): Move to termhooks.h as terminal-local var.
6902 (LOCAL_SELECTION): New macro.
6903 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6904 (symbol_to_x_atom): Remove gratuitous arg.
6905 (x_handle_selection_request, lisp_data_to_selection_data)
6906 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6907 (x_own_selection, x_get_local_selection, x_convert_selection):
6908 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6909 (some_frame_on_display): Delete unused function.
6910 (Fx_own_selection_internal, Fx_get_selection_internal)
6911 (Fx_disown_selection_internal, Fx_selection_owner_p)
6912 (Fx_selection_exists_p): New optional frame arg.
6913 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6914 (x_handle_selection_clear): Don't treat other terminals with the
6915 same keyboard specially. Use the terminal-local Vselection_alist.
6916 (x_clear_frame_selections): Use Frun_hook_with_args.
6917
6918 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6919
6920 * xterm.h: Add support for those atoms.
6921
e067f0c1
CY
69222011-05-26 Chong Yidong <cyd@stupidchicken.com>
6923
6924 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6925 (converted_selections, conversion_fail_tag): New global variables.
6926 (x_selection_request_lisp_error): Free the above.
6927 (x_get_local_selection): Remove unnecessary code.
6928 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6929 of converted selections stored in converted_selections.
6930 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6931 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6932 (x_convert_selection): New function.
6933 (x_handle_selection_event): Simplify.
6934 (x_get_foreign_selection): Don't ignore incoming requests while
6935 waiting for an answer; this will fail when we implement
6936 SAVE_TARGETS, and seems unnecessary anyway.
6937 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6938 (Vx_sent_selection_functions): Doc fix.
6939
0f4aebc0
LL
69402011-05-26 Leo Liu <sdl.web@gmail.com>
6941
6942 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6943
e61124cd
YM
69442011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6945
6946 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6947
6948 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6949 for fringe update if it has periodic bitmap.
ac389d0c 6950 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6951 and fringe_bitmap_periodic_p.
6952
6953 * fringe.c (get_fringe_bitmap_data): New function.
6954 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6955 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6956 row. Mark glyph row for fringe update if periodicity changed.
6957
6958 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6959 for fringe update unless it has periodic bitmap.
6960
f16d9837
KH
69612011-05-25 Kenichi Handa <handa@m17n.org>
6962
6963 * xdisp.c (get_next_display_element): Set correct it->face_id for
6964 a static composition.
6965
e1b90ef6
LL
69662011-05-24 Leo Liu <sdl.web@gmail.com>
6967
6968 * deps.mk (fns.o):
6969 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6970
6971 * fns.c (crypto_hash_function, Fsha1): New function.
6972 (Fmd5): Use crypto_hash_function.
6973 (syms_of_fns): Add Ssha1.
6974
7400048f
PE
69752011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6976
6977 * gnutls.c: Remove unused macros.
6978 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6979 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6980 Remove macros that are defined and never used.
6981 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6982
abb71cf4
CY
69832011-05-22 Chong Yidong <cyd@stupidchicken.com>
6984
6985 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6986 (Fx_get_selection_internal): Minor cleanup.
6987 (Fx_own_selection_internal): Rename arguments for consistency with
6988 select.el.
6989
6307db39
PE
69902011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6991
6992 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6993
f3d4e0a4
CY
69942011-05-22 Chong Yidong <cyd@stupidchicken.com>
6995
6996 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6997
4d8ade89
YM
69982011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6999
7000 * dispnew.c (scrolling_window): Don't exclude the case that the
7001 last enabled row in the desired matrix touches the bottom boundary.
7002
32078c8d
GM
70032011-05-21 Glenn Morris <rgm@gnu.org>
7004
7005 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
7006 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7007 and add some more files.
32078c8d 7008
7285dc67
EZ
70092011-05-20 Eli Zaretskii <eliz@gnu.org>
7010
7011 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7012 report_file_error introduced by the change from 2011-05-07.
7013
89d1bd22
PE
70142011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7015
7016 * systime.h (Time): Define only if emacs is defined.
7017 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7018 where the include path doesn't have X11/X.h by default. See
7019 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7020
cd394be1 70212011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
7022
7023 * composite.c (find_automatic_composition): Fix previous change.
7024
b9704ad9
GM
70252011-05-20 Glenn Morris <rgm@gnu.org>
7026
7027 * lisp.mk: New file, split from Makefile.in.
7028 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7029 (shortlisp): Remove.
7030 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7031
4a720484
GM
70322011-05-19 Glenn Morris <rgm@gnu.org>
7033
7034 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7035 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7036 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7037 (lisp): Set the order to that of loadup.el.
7038 (shortlisp): Make it a copy of $lisp.
7039 (SOME_MACHINE_LISP): Remove.
7040 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7041 Use just $shortlisp, not $SOME_MACHINE_LISP too.
7042
a28d4396
KH
70432011-05-18 Kenichi Handa <handa@m17n.org>
7044
7045 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7046 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7047 (find_automatic_composition): Mostly rewrite for efficiency.
7048
a2b1fa8e
JB
70492011-05-18 Juanma Barranquero <lekktu@gmail.com>
7050
7051 * makefile.w32-in: Update dependencies.
7052
8e1f5610
CS
70532011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7054
7055 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 7056 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 7057
7025ee00 70582011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 7059
cdfa6eab
PE
7060 Fix some integer overflow issues, such as string length overflow.
7061
06d6db33
PE
7062 * insdel.c (count_size_as_multibyte): Check for string overflow.
7063
2b4560a8
PE
7064 * character.c (lisp_string_width): Check for string overflow.
7065 Use EMACS_INT, not int, for string indexes and lengths; in
7066 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
7067 the resulting string length overflows an EMACS_INT; instead,
7068 report a string overflow if no precision given. When checking for
7069 precision exhaustion, use a check that cannot possibly have
7070 integer overflow. (Bug#8675)
7071 * character.h (lisp_string_width): Adjust to new signature.
7072
cb93f9be
PE
7073 * alloc.c (string_overflow): New function.
7074 (Fmake_string): Use it. This doesn't change behavior, but saves
7075 a few bytes and will simplify future changes.
7076 * character.c (string_escape_byte8): Likewise.
7077 * lisp.h (string_overflow): New decl.
7078
1a1f3366
PE
7079 Fixups, following up to the user-interface timestamp change.
7080 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
7081 for UI timestamps, instead of unsigned long.
9fbd6841
PE
7082 * msdos.c (mouse_get_pos): Likewise.
7083 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
7084 * w32gui.h (Time): Define by including "systime.h" rather than by
7085 declaring it ourselves. (Bug#8664)
7086
d4e3e4d3
PE
7087 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7088 * image.c (clear_image_cache): Likewise.
7089
f6a24d19
PE
7090 * term.c (term_mouse_position): Don't assume time_t wraparound.
7091
08dc5ae6
PE
7092 Be more systematic about user-interface timestamps.
7093 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
7094 and sometimes 'EMACS_UINT', to represent these timestamps.
7095 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
7096 This makes the code easier to follow, and makes it easier to catch
7097 integer overflow bugs such as Bug#8664.
7098 * frame.c (Fmouse_position, Fmouse_pixel_position):
7099 Use Time, not unsigned long, for user-interface timestamps.
7100 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7101 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7102 * keyboard.h (last_event_timestamp): Likewise.
7103 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7104 * menu.h (xmenu_show): Likewise.
7105 * term.c (term_mouse_position): Likewise.
7106 * termhooks.h (struct input_event.timestamp): Likewise.
7107 (struct terminal.mouse_position_hook): Likewise.
7108 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7109 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7110 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7111 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7112 what it was before.
7113 * menu.h, termhooks.h: Include "systime.h", for Time.
7114
8e55734a
PE
7115 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7116 Don't assume that the difference between two unsigned long values
7117 can fit into an integer. At this point, we know button_down_time
7118 <= event->timestamp, so the difference must be nonnegative, so
7119 there's no need to cast the result if double-click-time is
7120 nonnegative, as it should be; check that it's nonnegative, just in
7121 case. This bug is triggered when events are more than 2**31 ms
86db42d2 7122 apart (about 25 days). (Bug#8664)
8e55734a 7123
841f1b75 7124 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 7125 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 7126
3e26f69c
PE
7127 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7128 that always fit in int. Use a sentinel instead of a counter, to
7129 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
7130 * frame.h (struct frame): Use int for menu_bar_items_used
7131 instead of EMACS_INT, since it always fits in int.
3e26f69c 7132
5cc152c0
PE
7133 * menu.c (grow_menu_items): Check for int overflow.
7134
d89eb65e
PE
7135 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7136
5235bd3e
PE
7137 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7138 Before, the code was not consistent. These values cannot exceed
7139 2**31 - 1 so there's no need to make them unsigned.
7140 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7141 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7142 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7143 as modifiers.
7144 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7145
bc827e23
PE
7146 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7147 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7148 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7149 presumably because the widths might not match.
7150
78eb494e
PE
7151 * window.c (size_window): Avoid needless test at loop start.
7152
04f2d78b
CB
71532011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7154
7155 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7156
d2fc7e3d 71572011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
7158
7159 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7160
d2fc7e3d 71612011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
7162
7163 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7164 `width' to `bar_area_x' and `bar_area_width', respectively.
7165 (x_scroll_run): Take account of fringe background extension.
7166
04f2d78b
CB
7167 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7168 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
7169 `bar_area_width', respectively.
7170 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7171 background extension.
7172
79b70037
GM
71732011-05-10 Jim Meyering <meyering@redhat.com>
7174
7175 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7176
2f142cc5
JB
71772011-05-10 Juanma Barranquero <lekktu@gmail.com>
7178
7179 * image.c (Finit_image_library): Return t for built-in image types,
7180 like pbm and xbm. (Bug#8640)
7181
57679c86
AS
71822011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7183
7184 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7185
888c9e86
EZ
71862011-05-07 Eli Zaretskii <eliz@gnu.org>
7187
b0512a1d
EZ
7188 * w32console.c (Fset_screen_color): Doc fix.
7189 (Fget_screen_color): New function.
7190 (syms_of_ntterm): Defsubr it.
7191
7285dc67
EZ
7192 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7193 unlink the temporary file if Fcall_process didn't create it in the
7194 first place.
7195 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7196 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
7197 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7198 cue to call_process_cleanup not to close that handle.
7199
4d3fcc8e
BK
72002011-05-07 Ben Key <bkey76@gmail.com>
7201
7202 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7203 one of two shell specific rules, either bootstrap-temacs-CMD or
7204 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7205 to the previous implementation of the bootstrap-temacs rule.
7206 The bootstrap-temacs-CMD rule is similar to the previous
7207 implementation of the bootstrap-temacs rule except that it
7208 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7209 variable.
7210
7211 These changes, along with some changes to nt/configure.bat,
7212 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7213 earlier fix to add support for --cflags and --ldflags options
7214 that include quotes so that it works whether make uses cmd or
7215 sh as the shell.
7216
b4289b64
MA
72172011-05-06 Michael Albinus <michael.albinus@gmx.de>
7218
7219 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7220 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7221 is a constant.
7222 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7223 a string. Handle both cases.
7224 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7225 (Fdbus_register_method): Use Qinvalid_function.
7226
af4c0e28
JB
72272011-05-06 Juanma Barranquero <lekktu@gmail.com>
7228
7229 * makefile.w32-in: Update dependencies.
7230 (LISP_H): Add inttypes.h and stdin.h.
7231 (PROCESS_H): Add unistd.h.
7232
c51453d9
EZ
72332011-05-06 Eli Zaretskii <eliz@gnu.org>
7234
7235 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7236 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7237
8ff0ac3c 72382011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 7239
4c4b566b
PE
7240 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7241
aab2b9b5
PE
7242 * term.c (vfatal): Remove stray call to va_end.
7243 It's not needed and the C Standard doesn't allow it here anyway.
7244
c378da0b
PE
7245 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7246 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7247
288b08c7
PE
7248 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7249 bytes.
7250
e3601888
PE
7251 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7252
db6c0e74
PE
7253 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7254
dd5963ea
PE
7255 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7256
88c9450f
PE
7257 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7258
2f9442b8
PE
7259 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7260
c032b5f8
PE
7261 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7262 * charset.c (Fdefine_charset_internal): Don't initialize
7263 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 7264 32-bit int (Bug#8600).
a108c10b
PE
7265
7266 * lread.c (read_integer): Be more consistent with string-to-number.
7267 Use string_to_number to do the actual conversion; this avoids
7268 rounding errors and fixes some other screwups. Without this fix,
7269 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7270 (digit_to_number): Move earlier, for benefit of read_integer.
7271 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 7272 not a digit in any supported base. (Bug#8602)
a108c10b 7273
ad5f9eea
PE
7274 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7275
aec1708a
PE
7276 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7277 to match comment at start of function. This also removes a
7278 GCC warning about overflow in a 32+64-bit port.
7279
47be4ab5
PE
7280 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7281
371cac43
PE
7282 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7283 Reported by Stefan Monnier in
7284 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
7285 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7286 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 7287
d01a7826
PE
7288 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7289 (EMACS_UINTPTR): Likewise, with uintptr_t.
7290
7fd47d5c
PE
7291 * lisp.h: Prefer 64-bit EMACS_INT if available.
7292 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7293 on 32-bit hosts that have 64-bit int, so that they can access
7294 large files.
122b0c86
PE
7295 However, temporarily disable this change unless the temporary
7296 symbol WIDE_EMACS_INT is defined.
7fd47d5c 7297
8727937b
PE
7298 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7299
8ac068ac
PE
7300 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7301 This removes an assumption that EMACS_INT and long are the same
7302 width as pointers. The assumption is true for Emacs porting targets
7303 now, but we want to make other targets possible.
7304 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7305 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7306 In the rest of the code, change types of integers that hold casted
7307 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7308 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7309 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7310 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7311 No need to cast type when ORing.
7312 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7313 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7314 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7315 assume EMACS_INT is the same width as char *.
7316 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7317 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7318 Remove no-longer-needed casts.
7319 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7320 (xg_tool_bar_help_callback, xg_make_tool_item):
7321 Use EMACS_INTPTR to hold an integer
7322 that will be cast to void *; this can avoid a GCC warning
7323 if EMACS_INT is not the same width as void *.
7324 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7325 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7326 (current_message_1, set_message_1):
7327 Use a local to convert to proper width without a cast.
7328 * xmenu.c (dialog_selection_callback): Likewise.
7329
ede49d71
PE
7330 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7331 Also, don't assume VALBITS / RAND_BITS is less than 5,
7332 and don't rely on undefined behavior when shifting a 1 left into
7333 the sign bit.
7334 * lisp.h (get_random): Change signature to match.
7335
2f30ecd0
PE
7336 * lread.c (hash_string): Use size_t, not int, for hash computation.
7337 Normally we prefer signed values; but hashing is special, because
7338 it's better to use unsigned division on hash table sizes so that
7339 the remainder is nonnegative. Also, size_t is the natural width
7340 for hashing into memory. The previous code used 'int', which doesn't
7341 retain enough info to hash well into very large tables.
7342 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7343
2a866e7b
PE
7344 * dbusbind.c: Don't possibly lose pointer info when converting.
7345 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7346 Use XPNTR rather than XHASH, so that the high-order bits of
7347 the pointer aren't lost when converting through void *.
7348
51639eac
PE
7349 * eval.c (Fautoload): Don't double-shift a pointer.
7350
92394119
PE
7351 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7352
dbdb9a7c
JB
73532011-05-06 Juanma Barranquero <lekktu@gmail.com>
7354
7355 * gnutls.c (DEF_GNUTLS_FN):
7356 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7357
db7a0b4f
AS
73582011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7359
7360 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7361 marker. (Bug#8610)
7362
cd394be1 73632011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7364
7365 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7366 New version that can reserve upto 2GB of heap space.
7367
f7ff1b0f 73682011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7369
7370 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7371
639c109b
TZ
73722011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7373
7374 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7375 `gnutls_certificate_set_x509_key_file'.
7376
d2127135
JB
73772011-05-05 Juanma Barranquero <lekktu@gmail.com>
7378
7379 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7380 Update dependencies.
7381
e968f4f3
JB
73822011-05-04 Juanma Barranquero <lekktu@gmail.com>
7383
7384 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7385 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7386 Remove unused parameter `fildes'.
7387 * process.c (read_process_output, send_process): Don't pass it.
7388
84d358f0
JB
73892011-05-04 Juanma Barranquero <lekktu@gmail.com>
7390
7391 Fix previous change: the library cache is defined in w32.c.
7392 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7393 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7394
0898ca10
JB
73952011-05-04 Juanma Barranquero <lekktu@gmail.com>
7396
7397 Implement dynamic loading of GnuTLS on Windows.
7398
7399 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7400 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7401 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7402 Declare.
7403
7404 * gnutls.c (Qgnutls_dll): Define.
7405 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7406 (gnutls_*): Declare function pointers.
7407 (init_gnutls_functions): New function to initialize function pointers.
7408 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7409 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7410 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7411 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7412 (emacs_gnutls_write, emacs_gnutls_read)
7413 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7414 (Fgnutls_available_p): New function.
7415 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7416 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7417 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7418
7419 * image.c: Include w32.h.
7420 (Vimage_type_cache): Delete.
7421 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7422 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7423 (w32_delayed_load): Move to w32.c.
7424
7425 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7426
7427 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7428 (w32_delayed_load): Move from image.c. When loading a library, record
7429 its filename in the :loaded-from property of the library id.
7430 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7431 Initialize and staticpro them.
7432 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7433
7434 * process.c: Include lisp.h before w32.h, not after.
7435 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7436 instead of gnutls_record_check_pending.
7437
7438 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7439
ff4de4aa
TZ
74402011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7441
7442 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7443 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7444 as passed in.
7445
abe95abb
JD
74462011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7447
7448 * xterm.c (x_set_frame_alpha): Do not set property on anything
7449 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7450
e16e55d4
JB
74512011-05-02 Juanma Barranquero <lekktu@gmail.com>
7452
7453 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7454
bafcf6a5
JB
74552011-05-02 Juanma Barranquero <lekktu@gmail.com>
7456
7457 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7458 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7459 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7460 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7461 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7462 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7463 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7464 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7465 (Qgnutls_bootprop_callbacks_verify): Make static.
7466
e7a6747f
AS
74672011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7468
19ed11ba
AS
7469 * callproc.c: Indentation fixup.
7470
e7a6747f 7471 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7472 (wait_for_termination, interruptible_wait_for_termination):
7473 Move after wait_for_termination_1.
e7a6747f 7474
1ef14cb4
LMI
74752011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7476
7477 * sysdep.c (interruptible_wait_for_termination): New function
7478 which is like wait_for_termination, but allows keyboard
7479 interruptions.
7480
7481 * callproc.c (Fcall_process): Add (:file "file") as an option for
7482 the STDOUT buffer.
7483 (Fcall_process_region): Ditto.
7484
330d880c
EZ
74852011-04-30 Eli Zaretskii <eliz@gnu.org>
7486
8db90b73
EZ
7487 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7488 rather than `XVECTOR (FOO)->size'.
7489
330d880c
EZ
7490 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7491 inttypes.h, as a gnulib replacement is used if it not available in
7492 system headers.
7493
15cbd324
EZ
74942011-04-21 Eli Zaretskii <eliz@gnu.org>
7495
7496 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7497 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7498 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7499
7500 * coding.c (coding_alloc_by_realloc): Error out if destination
7501 will grow beyond MOST_POSITIVE_FIXNUM.
7502 (decode_coding_emacs_mule): Abort if there isn't enough place in
7503 charbuf for the composition carryover bytes. Reserve an extra
7504 space for up to 2 characters produced in a loop.
7505 (decode_coding_iso_2022): Abort if there isn't enough place in
7506 charbuf for the composition carryover bytes.
7507
75082011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7509
ae940cca
EZ
7510 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7511 aborting when %lld or %lll format is passed.
7512 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7513 %llo or %llx format is passed. (Bug#8545)
7514
03ab8921
EZ
7515 * window.c (window_scroll_line_based): Use a marker instead of
7516 simple variables to record original value of point. (Bug#7952)
7517
afda1437
EZ
7518 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7519 produced by %s or %c overflows available buffer space. (Bug#8545)
7520
f76dee0c
PE
75212011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7522
7523 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7524 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7525
fdc5744d
JB
75262011-04-28 Juanma Barranquero <lekktu@gmail.com>
7527
7528 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7529
638f053a
JB
75302011-04-28 Juanma Barranquero <lekktu@gmail.com>
7531
7532 * keyboard.c (Qdelayed_warnings_hook): Define.
7533 (command_loop_1): Run `delayed-warnings-hook'
7534 if Vdelayed_warnings_list is non-nil.
7535 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7536 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7537
d178f871
EZ
75382011-04-28 Eli Zaretskii <eliz@gnu.org>
7539
7540 * doprnt.c (doprnt): Don't return value smaller than the buffer
7541 size if the message was truncated. (Bug#8545).
7542
b124fd93
JB
75432011-04-28 Juanma Barranquero <lekktu@gmail.com>
7544
7545 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7546 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7547
e810457d
PE
75482011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7549
7550 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7551
ea51cceb
JB
75522011-04-27 Juanma Barranquero <lekktu@gmail.com>
7553
7554 * makefile.w32-in: Update dependencies.
7555
94dcfacf
EZ
75562011-04-27 Eli Zaretskii <eliz@gnu.org>
7557
7558 Improve `doprnt' and its usage. (Bug#8545)
7559 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7560 `format_end'. Remove support for %l as a conversion specifier.
7561 Don't use xrealloc. Improve diagnostics when the %l size modifier
7562 is used. Update the commentary.
7563
7564 * eval.c (verror): Simplify calculation of size_t.
7565
7566 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7567 messages.
7568
f61f41d7
PE
75692011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7570
7571 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7572 change.
7573
96fb4434
PE
75742011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7575
7576 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7577 This makes this file independent of the recent pseudovector change.
7578
671875da 75792011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7580
69e9b5a3
PE
7581 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7582
b5f869a7 7583 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7584 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7585 Remove unused local.
c8926152 7586 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7587
841a1577 7588 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7589 GCC 4.6.0 optimizes based on type-based alias analysis.
7590 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7591 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7592 != &v->size, and therefore "v->size = 1; b->size = 2; return
7593 v->size;" must therefore return 1. This assumption is incorrect
7594 for Emacs, since it type-puns struct Lisp_Vector * with many other
7595 types. To fix this problem, this patch adds a new type struct
f904488f 7596 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7597 and pseudovectors, and helps optimizing compilers not get fooled
7598 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7599 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7600 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7601 the size member.
eab3844f
PE
7602 (XSETPVECTYPE): Rewrite in terms of new macro.
7603 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7604 This is a bit clearer, and further avoids the possibility of
7605 undesirable aliasing.
7606 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7607 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7608 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7609 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7610 (ASIZE): Now uses header.size rather than size.
7611 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7612 to avoid the hassle of writing XVECTOR (foo)->header.size.
7613 (struct vectorlike_header): New type.
eab3844f
PE
7614 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7615 object, to help avoid aliasing.
7616 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7617 (SUBRP): Likewise, since Lisp_Subr is a special case.
7618 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7619 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7620 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7621 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7622 changed to be "header.size" and "header.next".
7623 * buffer.h (struct buffer): Likewise.
7624 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7625 * frame.h (struct frame): Likewise.
7626 * process.h (struct Lisp_Process): Likewise.
7627 * termhooks.h (struct terminal): Likewise.
7628 * window.c (struct save_window_data, struct saved_window): Likewise.
7629 * window.h (struct window): Likewise.
7630 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7631 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7632 * buffer.c (init_buffer_once): Likewise.
7633 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7634 special case.
7635 * process.c (Fformat_network_address): Use local var for size,
7636 for brevity.
7637
0df1eac5
PE
7638 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7639
847ab9d1 7640 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7641 * data.c (atof): Remove decl; no longer used or needed.
7642 (digit_to_number): Move to lread.c.
7643 (Fstring_to_number): Use new string_to_number function, to be
7644 consistent with how the Lisp reader treats infinities and NaNs.
7645 Do not assume that floating-point numbers represent EMACS_INT
7646 without losing information; this is not true on most 64-bit hosts.
7647 Avoid double-rounding errors, by insisting on integers when
7648 parsing non-base-10 numbers, as the documentation specifies.
7649 * lisp.h (string_to_number): New decl, replacing ...
7650 (isfloat_string): Remove.
bc0a5c13 7651 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7652 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7653 appears to have been a coding error. Similarly, do not accept
7654 strings like +-1e0 as floating point numbers. Do not report
7655 overflow for integer overflows unless the base is not 10 which
7656 means we have no simple and reliable way to continue.
7657 Break out the floating-point parsing into a new
7658 function string_to_number, so that Fstring_to_number parses
7659 floating point numbers consistently with the Lisp reader.
04f2d78b 7660 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7661 (E_CHAR, EXP_INT): Remove, replacing with ...
7662 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7663 (string_to_number): New function, replacing isfloat_string.
7664 This function checks for valid syntax and produces the resulting
7665 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7666 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7667 so that overflow for non-base-10 numbers is reported only when
7668 there's no portable and simple way to convert to floating point.
452f4150 7669
67769ffc
PE
7670 * textprop.c (set_text_properties_1): Rewrite for clarity,
7671 and to avoid GCC warning about integer overflow.
7672
c20db43f
PE
7673 * intervals.h (struct interval): Use EMACS_INT for members
7674 where EMACS_UINT might cause problems. See
7675 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7676 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7677 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7678 All uses changed.
37aa2f85
PE
7679 (offset_intervals): Tell GCC not to worry about length overflow
7680 when negating a negative length.
c20db43f 7681
2538aa2f
PE
7682 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7683 (overrun_check_free): Likewise.
7684
f2d3008d
PE
7685 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7686 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7687 word size.
7688
ec8df744
PE
7689 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7690 (gnutls_make_error): Rename local to avoid shadowing.
7691 (gnutls_emacs_global_deinit): ifdef out; not used.
7692 (Fgnutls_boot): Use const for pointer to readonly storage.
7693 Comment out unused local. Fix pointer signedness problems.
7694
640ee02d
PE
7695 * lread.c (openp): Don't stuff size_t into an 'int'.
7696 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7697 about possible signed overflow.
7698
6048fb2a
PE
7699 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7700 (GDK_KEY_g): Don't define if already defined.
7701 (xg_prepare_tooltip): Avoid pointer signedness problem.
7702 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7703
fa3c87e1
PE
7704 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7705 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7706
2172544b
PE
7707 * xfns.c (Fx_window_property): Simplify a bit,
7708 to make a bit faster and to avoid GCC 4.6.0 warning.
7709 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7710
9b821a21
PE
7711 * fns.c (internal_equal): Don't assume size_t fits in int.
7712
3c616cfa
PE
7713 * alloc.c (compact_small_strings): Tighten assertion a little.
7714
c2982e87
PE
7715 Replace pEd with more-general pI, and fix some printf arg casts.
7716 * lisp.h (pI): New macro, generalizing old pEd macro to other
7717 conversion specifiers. For example, use "...%"pI"d..." rather
7718 than "...%"pEd"...".
7719 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7720 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7721 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7722 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7723 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7724 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7725 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7726 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7727 64-bit hosts.
7728 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7729 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7730 * print.c (safe_debug_print, print_object): Likewise.
7731 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7732 to int.
6f04d126
PE
7733 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7734 avoiding the 0 flag, which is not portable.
c2982e87
PE
7735 * process.c (Fmake_network_process): Use pI to avoid cast.
7736 * region-cache.c (pp_cache): Likewise.
7737 * xdisp.c (decode_mode_spec): Likewise.
7738 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7739 behavior on 64-bit hosts with printf arg.
6f04d126 7740 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7741 (x_stop_queuing_selection_requests): Likewise.
7742 (x_get_window_property): Don't truncate byte count to an 'int'
7743 when tracing.
0b432f21 7744
5e073ec7
PE
7745 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7746 here, since it parses constructs like leading '-' and spaces,
7747 which are not wanted; and it overflows with large numbers.
7748 Instead, simply match F[0-9]+, which is what is wanted anyway.
7749
36372bf9
PE
7750 * alloc.c: Remove unportable assumptions about struct layout.
7751 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7752 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7753 (allocate_vectorlike, make_pure_vector): Use the new macros,
7754 plus offsetof, to remove unportable assumptions about struct layout.
7755 These assumptions hold on all porting targets that I know of, but
7756 they are not guaranteed, they're easy to remove, and removing them
7757 makes further changes easier.
7758
0b432f21
PE
7759 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7760 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7761 (string_overrun_cookie): Now const. Use initializers that
7762 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7763 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7764 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7765 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7766 multiple of sizeof (EMACS_INT); it need not be, if
7767 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7768 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7769
895009e1
JB
77702011-04-26 Juanma Barranquero <lekktu@gmail.com>
7771
7772 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7773
6a7a1b0b
TZ
77742011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7775
7776 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7777 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7778 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7779
841a1577 77802011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7781
7782 * lisp.h (Qdebug): List symbol.
895009e1 7783 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7784 * keyboard.c (debug-on-event): New variable.
7785 (handle_user_signal): Break into debugger when debug-on-event
7786 matches the current signal symbol.
7787
f2d3ba6f
DN
77882011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7789
7790 * alloc.c (check_sblock, check_string_bytes)
7791 (check_string_free_list): Convert to standard C.
7792
42ce4c63
TZ
77932011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7794
7795 * w32.c (emacs_gnutls_push): Fix typo.
7796
825cd63c
EZ
77972011-04-25 Eli Zaretskii <eliz@gnu.org>
7798
fb11d64d
EZ
7799 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7800 "cast to pointer from integer of different size".
7801
825cd63c
EZ
7802 Improve doprnt and its use in verror. (Bug#8545)
7803 * doprnt.c (doprnt): Document the set of format control sequences
7804 supported by the function. Use SAFE_ALLOCA instead of always
7805 using `alloca'.
7806
7807 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7808 is one byte too soon. Don't use xrealloc; instead xfree and
7809 xmalloc anew.
7810
e061a11b
TZ
78112011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7812
7813 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7814 callbacks stage.
7815
7816 * gnutls.c: Renamed global_initialized to
7817 gnutls_global_initialized. Added internals for the
7818 :verify-hostname-error, :verify-error, and :verify-flags
7819 parameters of `gnutls-boot' and documented those parameters in the
7820 docstring. Start callback support.
9173deec
JB
7821 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7822 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7823 on error. Return error code.
e061a11b
TZ
7824 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7825 (emacs_gnutls_read): Likewise.
7826 (Fgnutls_boot): Return handshake error code.
7827 (emacs_gnutls_handle_error): New function.
7828 (wsaerror_to_errno): Likewise.
7829
7830 * w32.h (emacs_gnutls_pull): Add prototype.
7831 (emacs_gnutls_push): Likewise.
7832
7833 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7834 (emacs_gnutls_push): Likewise.
7835
78362011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7837
7838 * process.c (wait_reading_process_output): Check if GnuTLS
7839 buffered some data internally if no FDs are set for TLS
7840 connections.
7841
7842 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7843 (LIBS): Link to USER_LIBS.
7844 ($(BLD)/gnutls.$(0)): New target.
7845
fa6996bc
EZ
78462011-04-24 Eli Zaretskii <eliz@gnu.org>
7847
eb35682e
EZ
7848 * xdisp.c (handle_single_display_spec): Rename the
7849 display_replaced_before_p argument into display_replaced_p, to
7850 make it consistent with the commentary. Fix typos in the
7851 commentary.
7852
e2ad650c
EZ
7853 * textprop.c (syms_of_textprop): Remove dead code.
7854 (copy_text_properties): Delete obsolete commentary about an
7855 interface that was deleted long ago. Fix typos in the description
7856 of arguments.
7857
1b2de274
EZ
7858 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7859 to changes in oldXMenu/XMenu.h from 2011-04-16.
7860 <menu_help_message, prev_menu_help_message>: Constify.
7861 (IT_menu_make_room): menu->help_text is now `const char **';
7862 adjust.
7863
7864 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7865 to changes in oldXMenu/XMenu.h from 2011-04-16.
7866 (struct XMenu): Declare `help_text' `const char **'.
7867
7868 * xfaces.c <Qunspecified>: Make extern again.
7869
7870 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7871 required by POSIX.
1b2de274 7872
762b15be
EZ
7873 * doc.c (get_doc_string): Improve the format passed to `error'.
7874
7875 * doprnt.c (doprnt): Improve commentary.
7876
7877 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7878
7879 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7880 them with etags.
7881
f1052e5d
EZ
7882 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7883 changes in globals.h immediately force recompilation.
762b15be
EZ
7884 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7885 $(CURDIR)/s/ms-w32.h.
7886 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7887
fa6996bc
EZ
7888 * character.c (Fchar_direction): Function deleted.
7889 (syms_of_character): Don't defsubr it.
7890 <char-direction-table>: Deleted.
7891
e6c3da20
EZ
78922011-04-23 Eli Zaretskii <eliz@gnu.org>
7893
7894 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7895 * doprnt.c: Include limits.h.
7896 (SIZE_MAX): New macro.
04f2d78b
CB
7897 (doprnt): Return a size_t value. 2nd arg is now size_t.
7898 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7899 Improve overflow protection. Support `l' modifier for integer
7900 conversions. Support %l conversion. Don't assume an EMACS_INT
7901 argument for integer conversions and for %c.
7902
7903 * lisp.h (doprnt): Restore prototype.
7904
7905 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7906 $(SRC)/character.h.
7907
7908 * Makefile.in (base_obj): Add back doprnt.o.
7909
7910 * deps.mk (doprnt.o): Add back prerequisites.
7911 (callint.o): Depend on character.h.
7912
7913 * eval.c (internal_lisp_condition_case): Include the handler
7914 representation in the error message.
7915 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7916 when breaking from the loop.
7917
7918 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7919
7920 * callint.c (Fcall_interactively): When displaying error message
7921 about invalid control letter, pass the character's codepoint, not
7922 a pointer to its multibyte form. Improve display of the character
7923 in octal and display also its hex code.
7924
7925 * character.c (char_string): Use %x to display the (unsigned)
7926 codepoint of an invalid character, to avoid displaying a bogus
7927 negative value.
7928
7929 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7930 `error', not SYMBOL_NAME itself.
7931
7932 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7933 character arguments to `error'.
7934
7935 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7936 to `error' in error message about FINAL_CHAR argument. Make sure
7937 FINAL_CHAR is a character, and use %c when it is passed as
7938 argument to `error'.
7939
4ffd0d6b 79402011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7941
7942 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7943
7944 * w32.c: Include <time.h>.
7945 (sys_localtime): New function.
7946
4ffd0d6b 79472011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7948
7949 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7950
4ffd0d6b 7951 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7952
4ffd0d6b 79532011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7954
4ffd0d6b
GM
7955 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7956 zombies (Bug#8467).
aac0c6e3 7957
04c56954
EZ
79582011-04-19 Eli Zaretskii <eliz@gnu.org>
7959
7960 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7961 gl_state.e_property when gl_state.object is Qt.
7962
7963 * insdel.c (make_gap_larger): Remove limitation of buffer size
7964 to <= INT_MAX.
7965
16a43933
CY
79662011-04-18 Chong Yidong <cyd@stupidchicken.com>
7967
7968 * xdisp.c (lookup_glyphless_char_display)
7969 (produce_glyphless_glyph): Handle cons cell entry in
7970 glyphless-char-display.
7971 (Vglyphless_char_display): Document it.
7972
7973 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7974 glyphless-char-display.
7975
4581706e
CY
79762011-04-17 Chong Yidong <cyd@stupidchicken.com>
7977
7978 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7979
7980 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7981
7982 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7983 definition for no-X builds.
7984
4887c6e2 79852011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7986
fd35b6f9
PE
7987 Static checks with GCC 4.6.0 and non-default toolkits.
7988
5c1ccb01
PE
7989 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7990
006c5daa
PE
7991 * process.c (keyboard_bit_set): Define only if SIGIO.
7992 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7993 (send_process): Repair possible setjmp clobbering.
7994
efc736d3
PE
7995 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7996
4e2fe2e6
PE
7997 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7998
f97334a2
PE
7999 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8000
4e75f29d
PE
8001 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8002 Define only if needed.
8003
90efadd1
PE
8004 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8005 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 8006 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 8007
3c647824
PE
8008 * dispextern.h (struct redisplay_interface): Rename param
8009 to avoid shadowing.
e264f262 8010 * termhooks.h (struct terminal): Likewise.
761383f4 8011 * xterm.c (xembed_send_message): Likewise.
3c647824 8012
b58c5c4a
PE
8013 * insdel.c (make_gap_smaller): Define only if
8014 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8015
cad59032
PE
8016 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8017 it.
8018
c339dc2e
PE
8019 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8020 so that we aren't warned about unused symbols.
8021
91a3e27b
PE
8022 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8023
399c71d3 8024 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 8025
8ffc96f5
PE
8026 * xfns.c (x_real_positions): Mark locals as initialized.
8027
eef9bc79
PE
8028 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8029
098db9dd
PE
8030 * xterm.c: Fix problems found by static analysis with other toolkits.
8031 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
8032 (x_dispatch_event): Declare static if USE_GTK, and
8033 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 8034 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 8035 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
8036 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8037 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 8038
eb18f6cc
PE
8039 * xmenu.c (menu_help_callback): Pointer type fixes.
8040 Use const pointers when pointing at readonly data. Avoid pointer
8041 signedness clashes.
8042 (FALSE): Remove unused macro.
8043 (update_frame_menubar): Remove unused decl.
8044
1fe72bf8
PE
8045 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8046
60d9e1db
PE
8047 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8048 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8049 (single_menu_item): Rename local to avoid shadowing.
8050
39261c26
PE
8051 * keyboard.c (make_lispy_event): Remove unused local var.
8052
018c5e19
PE
8053 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8054 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8055
63d2b86e
PE
8056 * bitmaps: Change bitmaps from unsigned char back to the X11
8057 compatible char. Avoid the old compiler warnings about
8058 out-of-range initializers by using, for example, '\xab' rather
8059 than 0xab.
8060
aefd87e1
PE
8061 * xgselect.c (xgselect_initialize): Check vs interface
8062 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8063
bf501fb9
PE
8064 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8065
e9829fdf
PE
8066 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
8067 to read-only memory.
8068
1086c095
PE
8069 * fns.c (vector): Remove; this old hack is no longer needed.
8070
2baccd04 8071 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 8072 Remove unused var.
dde42981 8073 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 8074
72391843 8075 * xrdb.c (x_load_resources): Omit unused local.
3565b346 8076
436c16df 8077 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 8078 (x_window): Rename locals to avoid shadowing.
dc5ddd85 8079 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 8080
92bb796d 8081 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 8082 (x_term_init): Remove local to avoid shadowing.
92bb796d 8083
764430a3 8084 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
8085
8086 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8087 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8088
d1dfb56c
EZ
80892011-04-16 Eli Zaretskii <eliz@gnu.org>
8090
c4354cb4
EZ
8091 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8092
d1dfb56c
EZ
8093 Fix regex.c, syntax.c and friends for buffers > 2GB.
8094 * syntax.h (struct gl_state_s): Declare character position members
8095 EMACS_INT.
8096
8097 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8098
04f2d78b
CB
8099 * textprop.c (verify_interval_modification, interval_of):
8100 Declare arguments EMACS_INT.
d1dfb56c
EZ
8101
8102 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8103 EMACS_INT.
8104
8105 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8106
8107 * indent.c (Fvertical_motion): Local variable it_start is now
8108 EMACS_INT.
8109
8110 * regex.c (re_match, re_match_2, re_match_2_internal)
8111 (bcmp_translate, regcomp, regexec, print_double_string)
8112 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8113 (re_compile_pattern, re_exec): Declare arguments and local
8114 variables `size_t' and `ssize_t' and return values `regoff_t', as
8115 appropriate.
8116 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8117 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8118 <compile_stack_type>: `size' and `avail' are now `size_t'.
8119
8120 * regex.h <regoff_t>: Use ssize_t, not int.
8121 (re_search, re_search_2, re_match, re_match_2): Arguments that
8122 specify buffer/string position and length are now ssize_t and
8123 size_t. Return type is regoff_t.
8124
613052cd
BK
81252011-04-16 Ben Key <bkey76@gmail.com>
8126
8127 * nsfont.m: Fixed bugs in ns_get_family and
8128 ns_descriptor_to_entity that were caused by using free to
8129 deallocate memory blocks that were allocated by xmalloc (via
8130 xstrdup). This caused Emacs to crash when compiled with
8131 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8132 --enable-checking=xmallocoverrun). xfree is now used to
8133 deallocate these memory blocks.
8134
4170f62f 81352011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 8136
71b41406
PE
8137 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8138
9587a89d
PE
8139 emacs_write: Accept and return EMACS_INT for sizes.
8140 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8141 et seq.
8142 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8143 Accept and return EMACS_INT.
8144 (emacs_gnutls_write): Return the number of bytes written on
8145 partial writes.
8146 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
8147 (emacs_read, emacs_write): Remove check for negative size, as the
8148 Emacs source code has been audited now.
9587a89d
PE
8149 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8150 (emacs_read, emacs_write): Use it.
273a5f82
PE
8151 * process.c (send_process): Adjust to the new signatures of
8152 emacs_write and emacs_gnutls_write. Do not attempt to store
8153 a byte offset into an 'int'; it might overflow.
9587a89d 8154 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 8155
3e047f51
PE
8156 * sound.c: Don't assume sizes fit in 'int'.
8157 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 8158 Return EMACS_INT, not int.
3e047f51 8159 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
8160 Accept EMACS_INT, not int.
8161 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
8162 record read return values.
8163
cc39a9db
BK
81642011-04-15 Ben Key <bkey76@gmail.com>
8165
c9d0ec6d
JB
8166 * keyboard.c (Qundefined): Don't declare static since it is used
8167 in nsfns.m.
8168 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8169 static since they are used in nsfont.m.
cc39a9db 8170
6c60eb9f
SM
81712011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8172
8173 * process.c (Qprocessp): Don't declare static.
8174 * lisp.h (Qprocessp): Declare again.
8175
7990b61a
JB
81762011-04-15 Juanma Barranquero <lekktu@gmail.com>
8177
8178 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8179
5d4cb038
PE
81802011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8181
8bd7b830 8182 Improve C-level modularity by making more things 'static'.
cd64ea1d 8183
e3b27b31
PE
8184 Don't publish debugger-only interfaces to other modules.
8185 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8186 (verify_bytepos, count_markers): Move decls to the only modules
8187 that need them.
8188 * region-cache.h (pp_cache): Likewise.
8189 * window.h (check_all_windows): Likewise.
8190 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8191
5d4cb038
PE
8192 * sysdep.c (croak): Now static, if
8193 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8194 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
8195
8196 * alloc.c (refill_memory_reserve): Now static if
8197 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8198 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 8199
e87b6180
PE
8200 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8201 Define only if USE_LUCID.
8202
ac64929e
PE
8203 * xrdb.c (x_customization_string, x_rm_string): Now static.
8204
6f37259d
PE
8205 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8206 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8207
1683e3ab
PE
8208 * xdisp.c (draw_row_with_mouse_face): Now static.
8209 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8210
de9c2632
PE
8211 * window.h (check_all_windows): Mark externally visible.
8212
2b96acb7
PE
8213 * window.c (window_deletion_count): Now static.
8214
8215 * undo.c: Make symbols static if they're not exported.
8216 (last_undo_buffer, last_boundary_position, pending_boundary):
8217 Now static.
8218
50436f33
PE
8219 * textprop.c (interval_insert_behind_hooks): Now static.
8220 (interval_insert_in_front_hooks): Likewise.
8221
64520e5c
PE
8222 * term.c: Make symbols static if they're not exported.
8223 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8224 (max_frame_lines, tty_set_terminal_modes):
8225 (tty_reset_terminal_modes, tty_turn_off_highlight):
8226 (get_tty_terminal): Now static.
8227 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8228 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 8229 HAVE_WINDOW_SYSTEM.
64520e5c
PE
8230 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8231 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8232
1fa53021
PE
8233 * sysdep.c: Make symbols static if they're not exported.
8234 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8235 Now static.
8236 (sigprocmask_set, full_mask): Remove; unused.
8237 (wait_debugging): Mark as visible.
8238 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8239 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8240
d4b43b22
PE
8241 * syntax.c (syntax_temp): Define only if !__GNUC__.
8242
b7c513d0
PE
8243 * sound.c (current_sound_device, current_sound): Now static.
8244
989b29ad
PE
8245 * search.c (searchbufs, searchbuf_head): Now static.
8246
13a55a78
PE
8247 * scroll.c (scroll_cost): Remove; unused.
8248 * dispextern.h (scroll_cost): Remove decl.
8249
de68a1fc
PE
8250 * region-cache.h (pp_cache): Mark as externally visible.
8251
40ccffa6
PE
8252 * process.c: Make symbols static if they're not exported.
8253 (process_tick, update_tick, create_process, chan_process):
8254 (Vprocess_alist, proc_buffered_char, datagram_access):
8255 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8256 (deactivate_process): Mark defn as static, as well as decl.
8257 * lisp.h (create_process): Remove decl.
8258 * process.h (chan_process, Vprocess_alist): Remove decls.
8259
ad64fc97
PE
8260 * print.c: Make symbols static if they're not exported.
8261 (print_depth, new_backquote_output, being_printed, print_buffer):
8262 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8263 (print_interval, print_number_index, initial_stderr_stream):
8264 Now static.
8265 * lisp.h (Fprinc): Remove decl.
8266 (debug_output_compilation_hack): Mark as externally visible.
8267
adddb265
PE
8268 * sysdep.c (croak): Move decl from here to syssignal.h.
8269 * syssignal.h (croak): Put it here, so the API can be checked when
8270 'croak' is called from dissociate_if_controlling_tty.
8271
1717ede2
PE
8272 * minibuf.c: Make symbols static if they're not exported.
8273 (minibuf_save_list, choose_minibuf_frame): Now static.
8274 * lisp.h (choose_minibuf_frame): Remove decl.
8275
fa5fb2bc
PE
8276 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8277
1e3890d1
PE
8278 * lread.c: Make symbols static if they're not exported.
8279 (read_objects, initial_obarray, oblookup_last_bucket_number):
8280 Now static.
8281 (make_symbol): Remove; unused.
8282 * lisp.h (initial_obarray, make_symbol): Remove decls.
8283
8a1414fa
PE
8284 * keyboard.c: Make symbols static if they're not exported.
8285 (single_kboard, recent_keys_index, total_keys, recent_keys):
8286 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8287 (this_single_command_key_start, echoing, last_auto_save):
8288 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8289 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8290 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8291 (Vlispy_mouse_stem, double_click_count):
8292 Now static.
8293 (force_auto_save_soon): Define only if SIGDANGER.
8294 (ignore_mouse_drag_p): Now static if
8295 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8296 (print_help): Remove; unused.
8297 (stop_character, last_timer_event): Mark as externally visible.
8298 * keyboard.h (ignore_mouse_drag_p): Declare only if
8299 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8300 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8301 * lisp.h (echoing): Remove decl.
8302 (force_auto_save_soon): Declare only if SIGDANGER.
8303 * xdisp.c (redisplay_window): Simplify code, to make it more
8304 obvious that ignore_mouse_drag_p is not accessed if !defined
8305 USE_GTK && !defined HAVE_NS.
8306
93ea6e8f
PE
8307 * intervals.c: Make symbols static if they're not exported.
8308 (merge_properties_sticky, merge_interval_right, delete_interval):
8309 Now static.
8310 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8311
77382fcc
PE
8312 * insdel.c: Make symbols static if they're not exported.
8313 However, leave prepare_to_modify_buffer alone. It's never
8314 called from outside this function, but that appears to be a bug.
8315 (combine_after_change_list, combine_after_change_buffer):
4889fc82 8316 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
8317 (adjust_after_replace_noundo): Remove; unused.
8318 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 8319 (signal_before_change): Remove decls.
77382fcc 8320
9306c32e
PE
8321 * indent.c (val_compute_motion, val_vmotion): Now static.
8322
cd44d2eb
PE
8323 * image.c: Make symbols static if they're not exported.
8324 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8325 if USE_GTK.
8326 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8327 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8328
ad9a7a06
PE
8329 * fringe.c (standard_bitmaps): Now static.
8330 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8331
81626931
PE
8332 * frame.c: Make symbols static if they're not exported.
8333 (x_report_frame_params, make_terminal_frame): Now static.
8334 (get_frame_param): Now static, unless HAVE_NS.
8335 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8336 (x_get_resource_string): Remove; not used.
8337 * frame.h (make_terminal_frame, x_report_frame_params):
8338 (x_get_resource_string); Remove decls.
8339 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8340 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8341
239f9db9
PE
8342 * font.c, fontset.c: Make symbols static if they're not exported.
8343 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8344 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8345 * font.c (font_close_object): Now static.
8346 * font.h (font_close_object): Remove.
8347 * fontset.c (FONTSET_OBJLIST): Remove.
8348 (free_realized_fontset) #if-0 the body, which does nothing.
8349 (face_suitable_for_char_p): #if-0, as it's never called.
8350 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
8351 * xfaces.c (face_at_string_position):
8352 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
8353 since 0 is always ASCII.
8354
dfcf3579
PE
8355 * fns.c (weak_hash_tables): Now static.
8356
5045092b
PE
8357 * fileio.c: Make symbols static if they're not exported.
8358 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8359 (Vwrite_region_annotation_buffers): Now static.
8360
57a96f5c
PE
8361 * eval.c: Make symbols static if they're not exported.
8362 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8363 * lisp.h (backtrace_list): Remove decl.
8364
35f08c38
PE
8365 * emacs.c: Make symbols static if they're not exported.
8366 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8367 (fatal_error_code, fatal_error_signal_hook, standard_args):
8368 Now static.
8369 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8370 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8371 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8372 * lisp.h (fatal_error_signal_hook): Remove decl.
8373 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8374
f44bd759
PE
8375 * editfns.c: Move a (normally-unused) function to its only use.
8376 * editfns.c, lisp.h (get_operating_system_release): Remove.
8377 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8378 worth the hassle of breaking this out.
8379
b532497d
PE
8380 * xterm.c: Make symbols static if they're not exported.
8381 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8382 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8383 (x_destroy_window, x_delete_display):
8384 Now static.
8385 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8386 (x_mouse_leave): Remove; unused.
8387 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8388 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8389 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8390 Remove decls.
8391 (x_mouse_leave): Declare only if WINDOWSNT.
8392 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8393 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8394 USE_X_TOOLKIT.
8395
1675728f
PE
8396 * ftxfont.c: Make symbols static if they're not exported.
8397 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8398 HAVE_FREETYPE.
8399 * font.h (ftxfont_driver): Likewise.
8400
e4cebfca
PE
8401 * xfns.c: Make symbols static if they're not exported.
8402 (x_last_font_name, x_display_info_for_name):
8403 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8404 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8405 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8406 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8407 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8408 (last_show_tip_args): Now static.
8409 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8410 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8411 (x_screen_planes): Remove; unused.
8412 * dispextern.h (x_screen_planes): Remove decl.
8413
5bf46f05
PE
8414 * dispnew.c: Make symbols static if they're not exported.
8415 * dispextern.h (redraw_garbaged_frames, scrolling):
8416 (increment_row_positions): Remove.
8417 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8418 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8419 Now static.
8420 (redraw_garbaged_frames): Remove; unused.
8421
435f4c28
PE
8422 * xfaces.c: Make symbols static if they're not exported.
8423 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8424 Remove decls.
8425 * xterm.h (defined_color): Remove decls.
8426 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8427 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8428 (menu_face_changed_default, defined_color, free_realized_face):
8429 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8430 (ascii_face_of_lisp_face): Remove; unused.
8431
8524aef3
PE
8432 * xdisp.c: Make symbols static if they're not exported.
8433 * dispextern.h (scratch_glyph_row, window_box_edges):
8434 (glyph_to_pixel_coords, set_cursor_from_row):
8435 (get_next_display_element, set_iterator_to_next):
8436 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8437 (show_mouse_face): Remove decls
8438 * frame.h (message_buf_print): Likewise.
8439 * lisp.h (pop_message, set_message, check_point_in_composition):
8440 Likewise.
8441 * xterm.h (set_vertical_scroll_bar): Likewise.
8442 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8443 (message_buf_print, scratch_glyph_row, displayed_buffer):
8444 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8445 (get_next_display_element, show_mouse_face, window_box_edges):
8446 (frame_to_window_pixel_xy, check_point_in_composition):
8447 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8448 (glyph_to_pixel_coords): Remove; unused.
8449
16390cd2
PE
8450 * dired.c (file_name_completion): Now static.
8451
8452 * dbusbind.c (xd_in_read_queued_messages): Now static.
8453
a25f4dfa
PE
8454 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8455 * data.c (circular_list_error): Remove.
8456
14a9c8df
PE
8457 * commands.h (last_point_position, last_point_position_buffer):
8458 (last_point_position_window): Remove decls.
8459 * keyboard.c: Make these variables static.
8460
04f2d78b
CB
8461 * coding.h (coding, code_convert_region, encode_coding_gap):
8462 Remove decls.
74ab6df5
PE
8463 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8464 (iso_code_class, detect_coding, code_convert_region): Now static.
8465 (encode_coding_gap): Remove; unused.
8466
38dfbee1
PE
8467 * chartab.c (chartab_chars, chartab_bits): Now static.
8468
a2cb4e63
PE
8469 * charset.h (charset_iso_8859_1): Remove decl.
8470 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8471 Now static.
8472
127198fd
PE
8473 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8474 * ccl.c (Vccl_program_table): Now static.
8475 (check_ccl_update): Remove; unused.
8476
d85b608f
PE
8477 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8478 * category.h: ... from here.
8479 * category.c (check_category_table, set_category_set): Now static.
8480
31cd66f3
PE
8481 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8482 * lisp.h: Remove these decls.
8483
c358e587
PE
8484 * buffer.c (buffer_count): Remove unused var.
8485
e78aecca
PE
8486 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8487 so that it's not optimized away.
8488 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8489 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8490 exported only to the debugger.
8491
e192d7d3 8492 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8493 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8494
92470028
PE
8495 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8496 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8497 was inaccessible from Lisp.
8498 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8499 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8500
244ed907
PE
8501 alloc.c: Import and export fewer symbols, and remove unused items.
8502 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8503 is defined.
8504 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8505 it's not optimized away by whole-program optimization.
8506 (message_enable_multibyte, free_misc): Remove.
8507 (catchlist, handlerlist, mark_backtrace):
8508 Declare only if BYTE_MARK_STACK.
8509 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8510 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8511 (message_enable_multibyte): Remove decl.
8512 (free_misc, interval_free_list, float_block, float_block_index):
8513 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8514 (cons_free_list, last_marked_index):
8515 Now static.
8516 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8517 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8518 (mark_backtrace): Define only if BYTE_MARK_STACK.
8519 * xdisp.c (message_enable_multibyte): Now static.
8520
61c2b50e 8521 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8522 This makes it easier for human readers (and static analyzers)
8523 to see whether these variables are used from other modules.
8524 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8525 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8526 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8527 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8528 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8529 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8530 * xmenu.c, xselect.c:
8531 Declare Q* vars static if they are not used in other modules.
8532 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8533 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8534 Remove decls of unexported vars.
8535 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8536
95c82688
PE
8537 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8538
16a97296
PE
8539 Make Emacs functions such as Fatom 'static' by default.
8540 This makes it easier for human readers (and static analyzers)
8541 to see whether these functions can be called from other modules.
8542 DEFUN now defines a static function. To make the function external
8543 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8544 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8545 (Finit_image_library):
16a97296
PE
8546 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8547 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8548 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8549 Remove decls, since these functions are now static.
8550 (Funintern, Fget_internal_run_time): New decls, since these functions
8551 were already external.
95c82688 8552
16a97296
PE
8553 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8554 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8555 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8556 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8557 * keyboard.c, keymap.c, lread.c:
8558 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8559 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8560 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8561 Mark functions with DEFUE instead of DEFUN,
8562 if they are used in other modules.
8563 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8564 decls for now-static functions.
8565 * buffer.h (Fdelete_overlay): Remove decl.
8566 * callproc.c (Fgetenv_internal): Mark as internal.
8567 * composite.c (Fremove_list_of_text_properties): Remove decl.
8568 (Fcomposition_get_gstring): New forward static decl.
8569 * composite.h (Fcomposite_get_gstring): Remove decl.
8570 * dired.c (Ffile_attributes): New forward static decl.
8571 * doc.c (Fdocumntation_property): New forward static decl.
8572 * eval.c (Ffetch_bytecode): New forward static decl.
8573 (Funintern): Remove extern decl; now in .h file where it belongs.
8574 * fileio.c (Fmake_symbolic_link): New forward static decl.
8575 * image.c (Finit_image_library): New forward static decl.
8576 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8577 * intervals.h (Fprevious_property_change):
8578 (Fremove_list_of_text_properties): Remove decls.
8579 * keyboard.c (Fthis_command_keys): Remove decl.
8580 (Fcommand_execute): New forward static decl.
8581 * keymap.c (Flookup_key): New forward static decl.
8582 (Fcopy_keymap): Now static.
8583 * keymap.h (Flookup_key): Remove decl.
8584 * process.c (Fget_process): New forward static decl.
8585 (Fprocess_datagram_address): Mark as internal.
8586 * syntax.c (Fsyntax_table_p): New forward static decl.
8587 (skip_chars): Remove duplicate decl.
8588 * textprop.c (Fprevious_property_change): New forward static decl.
8589 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8590 Now internal.
8591 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8592 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8593
785bbd42
PE
8594 * editfns.c (Fformat): Remove unreachable code.
8595
8b913b57
AS
85962011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8597
8598 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8599 change. (Bug#8496)
8600
a6744a35
EZ
86012011-04-13 Eli Zaretskii <eliz@gnu.org>
8602
8603 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8604 when at ZV. (Bug#8487)
8605
e7974947
AS
86062011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8607
baad03f0
AS
8608 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8609 (Bug#8437)
8610 * keyboard.c (parse_tool_bar_item): Likewise.
8611 * sound.c (sound_cleanup, alsa_close): Likewise.
8612 * termcap.c (tgetent): Likewise.
8613 * xfns.c (x_default_font_parameter): Likewise.
8614 * xsettings.c (read_and_apply_settings): Likewise.
8615
e7974947
AS
8616 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8617 (overrun_check_free): Protoize.
8618
28272684
PE
86192011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8620
8621 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8622 since callers should never pass a negative size.
8623 Change the signature to match that of plain 'read' and 'write'; see
8624 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8625 * lisp.h: Update prototypes of emacs_write and emacs_read.
8626
11997c76
EZ
86272011-04-11 Eli Zaretskii <eliz@gnu.org>
8628
8629 * xdisp.c (redisplay_window): Don't try to determine the character
8630 position of the scroll margin if the window start point w->startp
e896f03c 8631 is outside the buffer's accessible region. (Bug#8468)
11997c76 8632
8a2cbd72
EZ
86332011-04-10 Eli Zaretskii <eliz@gnu.org>
8634
8635 Fix write-region and its subroutines for buffers > 2GB.
8636 * fileio.c (a_write, e_write): Modify declaration of arguments and
8637 local variables to support buffers larger than 2GB.
8638 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8639
8640 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8641 argument, local variables, and return value.
8642
8643 * lisp.h: Update prototypes of emacs_write and emacs_read.
8644
8645 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8646
4073e537 86472011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8648
1ebfdcb6
PE
8649 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8650
b2ded58d
PE
8651 Fix more problems found by GCC 4.6.0's static checks.
8652
7d66342c
PE
8653 * xdisp.c (vmessage): Use a better test for character truncation.
8654
bbf47d44
PE
8655 * charset.c (load_charset_map): <, not <=, for optimization,
8656 and to avoid potential problems with integer overflow.
9248994d 8657 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8658 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8659 * editfns.c (Fformat): Likewise.
1e69125e 8660 * syntax.c (skip_chars): Likewise.
3befa583 8661
e3019616
PE
8662 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8663 This also lets GCC 4.6.0 generate slightly better loop code.
8664
becfa255
PE
8665 * callint.c (Fcall_interactively): <, not <=, for optimization.
8666 (Fcall_interactively): Count the number of arguments produced,
8667 not the number of arguments given. This is simpler and lets GCC
8668 4.6.0 generate slightly better code.
8669
dae0cd48
PE
8670 * ftfont.c: Distingish more carefully between FcChar8 and char.
8671 The previous code passed unsigned char * to a functions like
8672 strlen and xstrcasecmp that expect char *, which does not
8673 conform to the C standard.
8674 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8675 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8676 char * when the C standard requires it.
8677
76032d70
PE
8678 * keyboard.c (read_char): Remove unused var.
8679
eb3f1cc8
PE
8680 * eval.c: Port to Windows vsnprintf (Bug#8435).
8681 Include <limits.h>.
8682 (SIZE_MAX): Define if the headers do not.
8683 (verror): Do not give up if vsnprintf returns a negative count.
8684 Instead, grow the buffer. This ports to Windows vsnprintf, which
8685 does not conform to C99. Problem reported by Eli Zaretskii.
8686 Also, simplify the allocation scheme, by avoiding the need for
8687 calling realloc, and removing the ALLOCATED variable.
8688
70476b54
PE
8689 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8690
12020a9e
PE
8691 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8692 But keep the doprint source code for now, as we might revamp it
8693 and use it again (Bug#8435).
ea6c7ae6
PE
8694 * lisp.h (doprnt): Remove.
8695 * Makefile.in (base_obj): Remove doprnt.o.
8696 * deps.mk (doprnt.o): Remove.
8697
5fdb398c
PE
8698 error: Print 32- and 64-bit integers portably (Bug#8435).
8699 Without this change, on typical 64-bit hosts error ("...%d...", N)
8700 was used to print both 32- and 64-bit integers N, which relied on
8701 undefined behavior.
61bdb816 8702 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8703 * lisp.h (error, verror): Mark as printf-like functions.
8704 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8705 Report overflow in size calculations when allocating printf buffer.
8706 Do not truncate output string at its first null byte.
8707 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8708 Truncate the output at a character boundary, since vsnprintf does not
8709 do that.
8710 * charset.c (check_iso_charset_parameter): Convert internal
8711 character to string before calling 'error', since %c now has the
8712 printf meaning.
8713 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8714 overflow when computing char to be passed to 'error'. Do not
8715 pass Lisp_Object to 'error'; pass the integer instead.
8716 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8717 formatted with plain %d.
8718
b189fa66
PE
8719 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8720
bff87ef0
PE
8721 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8722
7e2cac20
PE
8723 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8724
ce4d90b5
PE
8725 * xterm.c (x_catch_errors): Remove duplicate declaration.
8726
266c9547
PE
8727 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8728
79c49ad2
PE
8729 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8730
368f4090
JM
87312011-04-10 Jim Meyering <meyering@redhat.com>
8732
8733 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8734 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8735 return ssize_t not "int", and use size_t as the buffer length.
8736 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8737 * gnutls.h: Update declarations.
8738 * process.c (read_process_output): Use ssize_t, to match.
8739 (send_process): Likewise.
8740
a32d4040
CY
87412011-04-09 Chong Yidong <cyd@stupidchicken.com>
8742
8743 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8744
8546720e 87452011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8746
04f2d78b
CB
8747 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8748 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8749
8546720e
GM
8750 * xterm.c (handle_one_xevent):
8751 * xmenu.c (create_and_show_popup_menu):
8752 * xselect.c (x_decline_selection_request)
8753 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8754
0a2f5c1a 87552011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8756
8757 Fix some uses of `int' instead of EMACS_INT.
8758 * search.c (string_match_1, fast_string_match)
8759 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8760 (scan_buffer, find_next_newline_no_quit)
8761 (find_before_next_newline, search_command, Freplace_match)
8762 (Fmatch_data): Make some `int' variables be EMACS_INT.
8763
8764 * xdisp.c (display_count_lines): 3rd argument and return value now
8765 EMACS_INT. All callers changed.
8766 (pint2hrstr): Last argument is now EMACS_INT.
8767
8768 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8769 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8770 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8771 (decode_coding_utf_16, decode_coding_emacs_mule)
8772 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8773 (decode_coding_ccl, decode_coding_charset)
8774 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8775 (decode_coding_iso_2022, decode_coding_emacs_mule)
8776 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8777 <char_offset, last_offset>: Declare EMACS_INT.
8778 (encode_coding_utf_8, encode_coding_utf_16)
8779 (encode_coding_emacs_mule, encode_invocation_designation)
8780 (encode_designation_at_bol, encode_coding_iso_2022)
8781 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8782 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8783 Declare EMACS_INT.
8784 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8785 (encode_invocation_designation): Last argument P_NCHARS is now
8786 EMACS_INT.
8787 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8788 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8789
8790 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8791 All users changed.
8792
8793 * ccl.c (Fccl_execute_on_string): Declare some variables
8794 EMACS_INT.
8795
8546720e 87962011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8797
8798 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8799
4e19a977
CS
88002011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8801
8802 * process.c (Fformat_network_address): Doc fix.
8803
87302331
R
88042011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8805
ee7683eb 8806 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8807
cbb59342
CY
88082011-04-08 Chong Yidong <cyd@stupidchicken.com>
8809
8810 * keyboard.c (read_char): Call Lisp function help-form-show,
8811 instead of using internal_with_output_to_temp_buffer.
8812 (Qhelp_form_show): New var.
e0d38eeb 8813 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8814
8815 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8816
8817 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8818
e67a13ab
CY
88192011-04-06 Chong Yidong <cyd@stupidchicken.com>
8820
04f2d78b
CB
8821 * process.c (Flist_processes): Remove to Lisp.
8822 (list_processes_1): Delete.
e67a13ab 8823
973f782d
EZ
88242011-04-06 Eli Zaretskii <eliz@gnu.org>
8825
7c106b1e
EZ
8826 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8827
973f782d
EZ
8828 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8829
41cf7d1a 88302011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8831
ca23cc88
PE
8832 Fix more problems found by GCC 4.6.0's static checks.
8833
f390e2d5
PE
8834 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8835
42eea0d0
PE
8836 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8837
b69769da 8838 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8839
f9541e84
PE
8840 * xdisp.c (vmessage): Mark as a printf-like function.
8841
13841b55
PE
8842 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8843
c136c10f
PE
8844 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8845
5e2d4a30
PE
8846 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8847 printf-like functions.
8848 (tiff_load): Add casts to remove these marks before passing them
8849 to system-supplied API.
8850
583f48b9
PE
8851 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8852
b25d760e
PE
8853 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8854 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8855 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8856 directly, rather than having caller test rule sign. This avoids
8857 some unnecessary tests.
8858 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8859 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8860 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8861
bc7b6697 8862 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8863 (xfont_open): Avoid unnecessary tests.
bc7b6697 8864
27ccc379
PE
8865 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8866
dcd5c89a
PE
8867 * composite.h, composite.c (composition_gstring_put_cache):
8868 Use EMACS_INT, not int, for length.
8869
b13a45c6
PE
8870 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8871 breaking out part of COMPOSITION_DECODE_RULE.
8872 (COMPOSITION_DECODE_RULE): Use it.
8873 * composite.c (get_composition_id): Remove unused local vars,
8874 by using the new macro.
8875
1e792e4d
PE
8876 * textprop.c (set_text_properties_1): Change while to do-while,
8877 since the condition is always true at first.
8878
dc6c6455 8879 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8880 (interval_deletion_adjustment): Return unsigned value.
8881 All uses changed.
dc6c6455 8882
aba7731a
PE
8883 * process.c (list_processes_1, create_pty, read_process_output):
8884 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8885 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8886 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8887 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8888 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8889
fdfc4bf3
PE
8890 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8891
fca8fe46 8892 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8893 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8894
06a0259a 8895 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8896 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8897 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8898
e7b9e80f
PE
8899 * print.c (print_error_message): Avoid int overflow.
8900
56201685
PE
8901 * font.c (font_list_entities): Redo for clarity,
8902 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8903
78834453 8904 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8905 (font_score): Avoid potential overflow in diff calculation.
78834453 8906
0bc0b309 8907 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8908 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8909
e610eaca
PE
8910 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8911
b895abce
PE
8912 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8913 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8914 can always succeed if overflow has undefined behavior.
8915
1f1d9321 8916 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8917 (wordify): Omit three unnecessary tests.
1f1d9321 8918
c59478bc
PE
8919 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8920 All callers changed. This avoids the need for an unused var.
8921
79b73827
PE
8922 * casefiddle.c (casify_region): Remove var that is set but not used.
8923
a4db5dfe
PE
8924 * dired.c (file_name_completion): Remove var that is set but not used.
8925
43aae36e
PE
8926 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8927
2a47c44d 8928 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8929 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8930
a37c69bf
PE
8931 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8932 Check for integer overflow on size calculations.
8933
328ab8e7
PE
8934 * buffer.c (Fprevious_overlay_change): Remove var that is set
8935 but not used.
8936
e5a2a5cb
PE
8937 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8938 Remove vars that are set but not used.
8d84a6eb 8939 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8940 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8941
a60e5f68
PE
8942 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8943
f661cb61 8944 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8945 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8946
f0397f5a
PE
8947 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8948 that are set but not used.
8949
8664db06 8950 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8951 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8952
6abdaa4a
PE
8953 * xselect.c (x_get_local_selection, x_handle_property_notify):
8954 Remove vars that are set but not used.
8955
0ce7538d 8956 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8957 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8958
9ae848fc
PE
8959 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8960 Remove var that is set but not used.
0b918413
PE
8961 (scroll_bar_windows_size): Now size_t, not int.
8962 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8963 Check for overflow.
9ae848fc 8964
a5a62657
PE
8965 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8966 (map_tty_color) [!defined MSDOS]: Likewise.
8967
5c5cdd39
PE
8968 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8969
66ebf983
PE
8970 * coding.c: Remove vars that are set but not used.
8971 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8972 All callers changed.
8973 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8974 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8975 (decode_coding_charset): Remove vars that are set but not used.
8976
1be4d761
PE
8977 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8978 that is set but not used.
8979
47553fa8
PE
8980 * print.c (print_object): Remove var that is set but not used.
8981
1f7196bf 8982 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8983 The gnulib version avoids calling malloc in the usual case,
8984 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8985 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8986 * filelock.c (current_lock_owner): Likewise.
8987 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8988 * sysdep.c: Include allocator.h, careadlinkat.h.
8989 (emacs_no_realloc_allocator): New static constant.
8990 (emacs_readlink): New function.
fdb61804
PE
8991 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8992 ../lib/careadlinkat.h.
d1fdcab7 8993
f84c17c7
SM
89942011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8995
8996 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8997 first non-nil return value).
8998
ef3862ad
JD
89992011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9000
9001 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9002 if not defined (Bug#8403).
9003
376a7006
JB
90042011-04-02 Juanma Barranquero <lekktu@gmail.com>
9005
9006 * xdisp.c (display_count_lines): Remove parameter `start',
9007 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9008 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9009 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9010 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9011 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9012 and thereabouts. All callers changed.
9013 (get_per_char_metric): Remove parameter `f', unused since
9014 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9015
6ca3801d
JM
90162011-04-02 Jim Meyering <meyering@redhat.com>
9017
9018 do not dereference NULL upon failed strdup
9019 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9020 (ns_get_family): Likewise.
9021
d8e2b5ba
JB
90222011-04-02 Juanma Barranquero <lekktu@gmail.com>
9023
9024 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9025
8c74fcbd
JD
90262011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9027
9028 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9029 later (Bug#8403).
9030
7200d79c
SM
90312011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9032
03408648 9033 Add lexical binding.
7200d79c 9034
03408648
SM
9035 * window.c (Ftemp_output_buffer_show): New fun.
9036 (Fsave_window_excursion):
9037 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9038
9039 * lread.c (lisp_file_lexically_bound_p): New function.
9040 (Fload): Bind Qlexical_binding.
9041 (readevalloop): Remove `evalfun' arg.
9042 Bind Qinternal_interpreter_environment.
9043 (Feval_buffer): Bind Qlexical_binding.
9044 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9045 Mark as dynamic.
9046 (syms_of_lread): Declare `lexical-binding'.
9047
9048 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9049
9050 * keyboard.c (eval_dyn): New fun.
9051 (menu_item_eval_property): Use it.
ca105506
SM
9052
9053 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 9054
03408648
SM
9055 * fns.c (concat, mapcar1): Accept byte-code-functions.
9056
9057 * eval.c (Fsetq): Handle lexical vars.
9058 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9059 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9060 (FletX, Flet): Obey lexical binding.
9061 (Fcommandp): Handle closures.
9062 (Feval): New `lexical' arg.
9063 (eval_sub): New function extracted from Feval. Use it almost
9064 everywhere where Feval was used. Look up vars in lexical env.
9065 Handle closures.
9066 (Ffunctionp): Move from subr.el.
9067 (Ffuncall): Handle closures.
9068 (apply_lambda): Remove `eval_flags'.
9069 (funcall_lambda): Handle closures and new byte-code-functions.
9070 (Fspecial_variable_p): New function.
9071 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
9072 but without exporting it to Lisp.
23aba0ea 9073
23aba0ea 9074 * doc.c (Fdocumentation, store_function_docstring):
03408648 9075 * data.c (Finteractive_form): Handle closures.
23aba0ea 9076
03408648
SM
9077 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
9078 interactive spec.
ba83908c 9079
04f2d78b
CB
9080 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
9081 New byte-codes.
03408648
SM
9082 (exec_byte_code): New function extracted from Fbyte_code to handle new
9083 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 9084
03408648 9085 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 9086
03408648 9087 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 9088
e2abce01
JB
90892011-03-31 Juanma Barranquero <lekktu@gmail.com>
9090
9091 * xdisp.c (redisplay_internal): Fix prototype.
9092
63696a73 90932011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 9094
63696a73 9095 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
9096 (try_scrolling): Use it when setting scroll_limit.
9097 Limit scrolling to 100 screen lines.
63696a73
EZ
9098 (redisplay_window): Even when falling back on "recentering",
9099 position point in the window according to scroll-conservatively,
9100 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9101
9102 (try_scrolling): When point is above the window, allow searching
9103 as far as scroll_max, or one screenful, to compute vertical
9104 distance from PT to the scroll margin position. This prevents
9105 try_scrolling from unnecessarily failing when
9106 scroll-conservatively is set to a value slightly larger than the
9107 window height. Clean up the case of PT below the margin at bottom
9108 of window: scroll_max can no longer be INT_MAX. When aggressive
9109 scrolling is in use, don't let point enter the opposite scroll
9110 margin as result of the scroll.
9111 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
9112 threshold of 100 lines for never-recentering scrolling.
9113
e4cc2dfc
JB
91142011-03-31 Juanma Barranquero <lekktu@gmail.com>
9115
9116 * dispextern.h (move_it_by_lines):
9117 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9118 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9119 (message_log_check_duplicate): Remove parameters `prev_bol' and
9120 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9121 (redisplay_internal): Remove parameter `preserve_echo_area',
9122 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9123
9124 * indent.c (Fvertical_motion):
9125 * window.c (window_scroll_pixel_based, Frecenter):
9126 Don't pass `need_y_p' to `move_it_by_lines'.
9127
1c470562
SM
91282011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9129
44f230aa
SM
9130 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9131 steal a few bits to be more compact.
9132 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9133 Remove unneeded casts.
9134
1c470562
SM
9135 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9136
888adce9
ZK
91372011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9138
9139 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9140 binding" message (bug#7967).
9141
f838ed7b
PE
91422011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9143
77861b95
PE
9144 Fix more problems found by GCC 4.6.0's static checks.
9145
de6dbc14
PE
9146 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9147 Remove unused local var.
9148
f838ed7b
PE
9149 * editfns.c (Fmessage_box): Remove unused local var.
9150
792c7b2b
PE
9151 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9152 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9153 Omit unused local vars.
c499e557 9154 * window.c (shrink_windows): Omit unused local var.
b01a1c29 9155 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
9156 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9157 Omit unused local var.
9158
ba0165e1
PE
9159 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9160 Don't assume string length fits in int.
32ad8845 9161 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 9162 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 9163
3c59b4c9
PE
9164 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9165 instead of alloca (Bug#8344).
9166
a3eed478 9167 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 9168 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 9169
eb4d412d
PE
9170 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9171
1658b401
PE
9172 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9173 concerns.
9174
9175 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9176
9177 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 9178
9a2c6e05
PE
9179 * keyboard.c (syms_of_keyboard): Use the same style as later
9180 in this function when indexing through an array. This also
9181 works around GCC bug 48267.
9182
03d0a109
PE
9183 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9184
44f730c8
PE
9185 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9186
fe75f926
PE
9187 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9188 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9189
ffa8c828
PE
9190 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9191 This avoids undefined behavior on integer overflow, and is a bit
9192 more convenient anyway since it is compared to a size_t variable.
9193
c5101a77
PE
9194 Variadic C functions now count arguments with size_t, not int.
9195 This avoids an unnecessary limitation on 64-bit machines, which
9196 caused (substring ...) to crash on large vectors (Bug#8344).
9197 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9198 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 9199 All variadic functions and their callers changed accordingly.
c5101a77
PE
9200 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9201 * data.c (arith_driver, float_arith_driver): Likewise.
9202 * editfns.c (general_insert_function): Likewise.
9203 * eval.c (struct backtrace.nargs, interactive_p)
9204 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9205 (funcall_lambda, mark_backtrace): Likewise.
9206 * fns.c (concat): Likewise.
9207 * frame.c (x_set_frame_parameters): Likewise.
9208 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9209 0 if not found, not -1. All callers changed.
9210
dd3f25f7
PE
9211 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9212 (stack_copy_size): Now size_t, not int.
9213 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9214
461c2ab9
JB
92152011-03-28 Juanma Barranquero <lekktu@gmail.com>
9216
9217 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9218 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9219 All callers changed.
9220
9221 * lisp.h (multibyte_char_to_unibyte):
9222 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9223 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9224 * character.h (CHAR_TO_BYTE8):
9225 * cmds.c (internal_self_insert):
9226 * editfns.c (general_insert_function):
9227 * keymap.c (push_key_description):
9228 * search.c (Freplace_match):
9229 * xdisp.c (message_dolog, set_message_1): All callers changed.
9230
f6d62986
SM
92312011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9232
9233 * keyboard.c (safe_run_hook_funcall): New function.
9234 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9235 don't set the hook to nil, but remove the offending function instead.
9236 (Qcommand_hook_internal): Remove, unused.
9237 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9238 Vcommand_hook_internal.
9239
9240 * eval.c (enum run_hooks_condition): Remove.
9241 (funcall_nil, funcall_not): New functions.
9242 (run_hook_with_args): Call each function through a `funcall' argument.
9243 Remove `cond' argument, now redundant.
9244 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9245 (Frun_hook_with_args_until_failure): Adjust accordingly.
9246 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9247
1db5b1ad
JB
92482011-03-28 Juanma Barranquero <lekktu@gmail.com>
9249
9250 * dispextern.h (string_buffer_position): Remove declaration.
9251
9252 * print.c (strout): Remove parameter `multibyte', unused since
9253 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9254
9255 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9256 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9257 All callers changed.
9258
9259 * w32.c (_wsa_errlist): Use braces for struct initializers.
9260
9261 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9262 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9263 All callers changed.
9264 (string_buffer_position): Likewise. Also, make static (it's never
9265 used outside xdisp.c).
9266 (cursor_row_p): Remove parameter `w', unused since
9267 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9268 (decode_mode_spec): Remove parameter `precision', introduced during
9269 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9270 All callers changed.
9271
5ffb62aa
JD
92722011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9273
9274 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9275
461c2ab9 92762011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
9277
9278 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9279 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9280 (ns_update_auto_hide_menu_bar): New functions.
9281 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9282 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9283 ns_constrain_all_frames.
9284 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9285 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9286
5c380ffb
JD
92872011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9288
9289 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9290
9af30bdf
GM
92912011-03-27 Glenn Morris <rgm@gnu.org>
9292
9293 * syssignal.h: Replace RETSIGTYPE with void.
9294 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9295 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9296 Replace SIGTYPE with void everywhere.
9297 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9298 * s/template.h (SIGTYPE): Remove commented out definition.
9299
e2abce01
JB
93002011-03-26 Eli Zaretskii <eliz@gnu.org>
9301
9302 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9303 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9304
f868cd8a
JB
93052011-03-26 Juanma Barranquero <lekktu@gmail.com>
9306
59eb0929
JB
9307 * w32.c (read_unc_volume): Use parameter `henum', instead of
9308 global variable `wget_enum_handle'.
9309
9310 * keymap.c (describe_vector): Remove parameters `indices' and
9311 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9312 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9313
f868cd8a
JB
9314 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9315
9316 * keyboard.c (timer_check): Remove parameter `do_it_now',
9317 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9318 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9319 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9320
9321 * keyboard.c (read_char):
9322 * w32menu.c (w32_menu_display_help):
9323 * xmenu.c (show_help_event, menu_help_callback):
9324 Adjust calls to `show_help_echo'.
9325
9326 * gtkutil.c (xg_maybe_add_timer):
9327 * keyboard.c (readable_events):
9328 * process.c (wait_reading_process_output):
9329 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9330
9331 * insdel.c (adjust_markers_gap_motion):
9332 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9333 (gap_left, gap_right): Don't call it.
9334
2ecf6fdb
CY
93352011-03-25 Chong Yidong <cyd@stupidchicken.com>
9336
9337 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9338 incurred during fontification.
9339
6b1f9ba4
JB
93402011-03-25 Juanma Barranquero <lekktu@gmail.com>
9341
9342 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9343 (DEFVAR_PER_BUFFER): Don't pass it.
9344
9345 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9346 (scrolling_window): Don't pass it.
9347
0f4a96b5
JB
93482011-03-25 Juanma Barranquero <lekktu@gmail.com>
9349
9350 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9351
9352 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9353 and `suffix'.
9354 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9355 of variables specific to SELinux and computation of `encoded_absname'.
9356
9357 * image.c (XPutPixel): Remove unused variable `height'.
9358
9359 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9360
9361 * unexw32.c (get_section_info): Remove unused variable `section'.
9362
9363 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9364 (system_process_attributes): Remove unused variable `sess'.
9365 (sys_read): Remove unused variable `err'.
9366
9367 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9368 (w32_wnd_proc): Remove unused variable `isdead'.
9369 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9370 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9371 (x_create_tip_frame): Remove unused variable `tem'.
9372
9373 * w32inevt.c (w32_console_read_socket):
9374 Remove unused variable `no_events'.
9375
9376 * w32term.c (x_draw_composite_glyph_string_foreground):
9377 Remove unused variable `width'.
9378
1149507c
JB
93792011-03-24 Juanma Barranquero <lekktu@gmail.com>
9380
9381 * w32term.c (x_set_glyph_string_clipping):
9382 Don't pass uninitialized region to CombineRgn.
9383
9c88f339
JB
93842011-03-23 Juanma Barranquero <lekktu@gmail.com>
9385
9386 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9387 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9388 (Fx_close_connection): Remove unused variable `i'.
9389
9390 * w32font.c (w32font_draw): Return number of glyphs.
9391 (w32font_open_internal): Remove unused variable `i'.
9392 (w32font_driver): Add missing initializer.
9393
9394 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9395 (fill_in_menu): Remove unused variable `items_added'.
9396
9397 * w32term.c (last_mouse_press_frame): Remove static global variable.
9398 (w32_clip_to_row): Remove unused variable `f'.
9399 (x_delete_terminal): Remove unused variable `i'.
9400
9401 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9402 (NOTHING): Remove unused static global variable.
9403 (uniscribe_check_otf): Remove unused variable `table'.
9404 (uniscribe_font_driver): Add missing initializers.
9405
dee091a3
JD
94062011-03-23 Julien Danjou <julien@danjou.info>
9407
9408 * term.c (Fsuspend_tty, Fresume_tty):
9409 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9410 * window.c (temp_output_buffer_show):
9411 * insdel.c (signal_before_change):
9412 * frame.c (Fhandle_switch_frame):
9413 * fileio.c (Fdo_auto_save):
9414 * emacs.c (Fkill_emacs):
9415 * editfns.c (save_excursion_restore):
9416 * cmds.c (internal_self_insert):
9417 * callint.c (Fcall_interactively):
9418 * buffer.c (Fkill_all_local_variables):
9419 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9420 Use Frun_hooks.
0f4a96b5 9421 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9422 unconditionally since it does the check itself.
dee091a3 9423
2c520ab5 94242011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9425
c9c49752
PE
9426 Fix more problems found by GCC 4.5.2's static checks.
9427
8abc3f12
PE
9428 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9429 the first time through the loop, since we know p0 < p1 then.
9430 This also avoids a gcc -Wstrict-overflow warning.
9431
a2d26660
PE
9432 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9433 leading to a memory leak, possible in functions like
9434 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9435 of objects (Bug#8318).
a2d26660 9436
916c72e9
PE
9437 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9438 that could (at least in theory) be that large.
9439
19ab8a18
PE
9440 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9441 This is less likely to overflow, and avoids undefined behavior if
9442 overflow does occur. All callers changed. Use strtoul to scan
9443 for the unsigned long integer.
b7cbbd6f
PE
9444 (pint2hrstr): Simplify and tune code slightly.
9445 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9446
f0641eff
PE
9447 * scroll.c (do_scrolling): Work around GCC bug 48228.
9448 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9449
7f650bb9
PE
9450 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9451 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9452 (validate_x_resource_name): Simplify count usage.
9453 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9454
37dd57d1
PE
9455 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9456 fail (Bug#8306).
81e56e61 9457
699979fc 9458 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9459
401bf9b4
PE
9460 * process.c (Fmake_network_process): Use socklen_t, not int,
9461 where POSIX says socklen_t is required in portable programs.
9462 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9463 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9464 (Fmake_network_process, server_accept_connection):
9465 (wait_reading_process_output, read_process_output):
9466 Likewise.
9467
b93aacde
PE
9468 * process.c: Rename or move locals to avoid shadowing.
9469 (list_processes_1, Fmake_network_process):
9470 (read_process_output_error_handler, exec_sentinel_error_handler):
9471 Rename or move locals.
4dc343ee 9472 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9473 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9474 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9475 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9476 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9477
af8a867c 9478 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9479 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9480 Include tparam.h instead, since it declares them.
af8a867c
PE
9481 * cm.h (PC): Remove extern decl; tparam.h now does this.
9482 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9483 * terminfo.c: Include tparam.h, to check interfaces.
9484 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9485 (tparam): Adjust signature to match interface in tparam.h;
9486 this removes some undefined behavior. Check that outstring and len
9487 are zero, which they always are with Emacs.
9488 * tparam.h (PC, BC, UP): New extern decls.
9489
0248044d 9490 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9491 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9492
8ff096c1 9493 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9494 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9495 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9496 (ftfont_list): Remove unused local.
49eaafba
PE
9497 (get_adstyle_property, ftfont_pattern_entity):
9498 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9499 Rename locals to avoid shadowing.
8ff096c1 9500
e2be39f6
PE
9501 * xfont.c (xfont_list_family): Mark var as initialized.
9502
c9735e30
PE
9503 * xml.c (make_dom): Now static.
9504
8f5201ae
PE
9505 * composite.c (composition_compute_stop_pos): Rename local to
9506 avoid shadowing.
b246f932
PE
9507 (composition_reseat_it): Remove unused locals.
9508 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9509 (composition_update_it): Mark var as initialized.
11b61122
PE
9510 (find_automatic_composition): Mark vars as initialized,
9511 with a FIXME (Bug#8290).
8f5201ae 9512
760fbc2c
PE
9513 character.h: Rename locals to avoid shadowing.
9514 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9515 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9516 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9517 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9518 to avoid shadowing.
9519
ff08eb85
PE
9520 * textprop.c (property_change_between_p): Remove; unused.
9521
fc7bf025
PE
9522 * intervals.c (interval_start_pos): Now static.
9523
235d7abc
PE
9524 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9525
44f230aa
SM
9526 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9527 Rename locals to avoid shadowing.
3e7d6594 9528
50060332
PE
9529 * sound.c (wav_play, au_play, Fplay_sound_internal):
9530 Fix pointer signedness.
d01f234b 9531 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9532 (wav_play): Initialize a variable to 0, to prevent undefined
9533 behavior (Bug#8278).
50060332 9534
c4fc4e30
PE
9535 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9536
918436ed
PE
9537 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9538
c939f91b
PE
9539 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9540 clobbering (Bug#8298).
b9c7f648
PE
9541 * sysdep.c (sys_subshell): Likewise.
9542 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9543
6bd8c144
PE
9544 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9545 This should get cleaned up, so that child_setup has the
9546 same signature on all platforms.
9547
7710357c 9548 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9549 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9550
c59da222
CY
95512011-03-22 Chong Yidong <cyd@stupidchicken.com>
9552
9553 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9554 not to be necessary, and produces flickering.
9555
66b87493
GM
95562011-03-20 Glenn Morris <rgm@gnu.org>
9557
9558 * config.in: Remove file.
9559
45b6f6d5
JB
95602011-03-20 Juanma Barranquero <lekktu@gmail.com>
9561
9562 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9563 are now in src/globals.h.
9564 (syms_of_minibuf): Remove spurious & from previous change.
9565
cd394be1 95662011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9567
9568 * minibuf.c (completing-read-function): New variable.
9569 (completing-read-default): Rename from completing-read.
9570 (completing-read): Call completing-read-function.
9571
b14e3e21
CY
95722011-03-19 Juanma Barranquero <lekktu@gmail.com>
9573
9574 * xfaces.c (Fx_load_color_file):
9575 Read color file from absolute filename (bug#8250).
9576
f2b726e6
JB
95772011-03-19 Juanma Barranquero <lekktu@gmail.com>
9578
9579 * makefile.w32-in: Update dependencies.
9580
09f6ff02
EZ
95812011-03-17 Eli Zaretskii <eliz@gnu.org>
9582
9583 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9584
29a6015a
PE
95852011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9586
a3a6c54e
PE
9587 Fix more problems found by GCC 4.5.2's static checks.
9588
b766f867
PE
9589 * process.c (make_serial_process_unwind, send_process_trap):
9590 (sigchld_handler): Now static.
9591
be02381c
PE
9592 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9593 That way, the code declares only the vars that it needs.
9594 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9595 * s/cygwin.h (PTY_ITERATION): Likewise.
9596 * s/darwin.h (PTY_ITERATION): Likewise.
9597 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9598
57048744
PE
9599 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9600 * process.c (allocate_pty): Don't declare stb unless it's needed.
9601
7914961c 9602 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9603 (CONSTANTLIM): Remove; unused.
9604 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9605 Define only if needed.
7914961c 9606
b3967b18
PE
9607 * unexelf.c (unexec): Name an expression,
9608 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9609 Use a different way to cause a compilation error if anyone uses
9610 n rather than nn, a way that does not involve shadowing.
73366a00 9611 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9612
29a6015a
PE
9613 * deps.mk (unexalpha.o): Remove; unused.
9614
43cfc33e 9615 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9616 * unexec.h: New file.
ce701a33
PE
9617 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9618 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9619 Depend on unexec.h.
9620 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9621 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9622 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9623 Change as necessary to match prototype in unexec.h.
ce701a33 9624
01f44d5a
PE
9625 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9626 shadowing.
4f63c6bb 9627 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9628
a6670b0b
PE
9629 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9630 Rename locals to avoid shadowing.
9631
cef2010d 9632 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9633 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9634
d4d7173a
PE
9635 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9636
f08b802a
PE
9637 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9638 warning when compiling print.c.
9639
3ddb0639
PE
9640 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9641 instead of using an uninitialized var.
5ad03b97 9642 (font_sort_entities): Mark var as initialized.
3ddb0639 9643
170a2692
PE
9644 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9645
e663c700
PE
9646 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9647 pointers to constants.
89bc529a 9648 (font_parse_fcname): Remove unused vars.
7b81e2d0 9649 (font_delete_unmatched): Now static.
ea838e10 9650 (font_get_spec): Remove; unused.
13a547c6
PE
9651 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9652 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9653 Rename or move locals to avoid shadowing.
e663c700 9654
2a80c887 9655 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9656 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9657
1384fa33 9658 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9659 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9660
8b2c52e9
PE
9661 * alloc.c (mark_backtrace): Move decl from here ...
9662 * lisp.h: ... to here, so that it can be checked.
9663
475545b5 9664 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9665 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9666 (lisp_indirect_variable): Name an expression,
9667 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9668 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9669
b1349114 9670 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9671 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9672 Use const pointer when appropriate.
b1349114 9673
a2928364
PE
9674 * lisp.h (get_system_name, get_operating_system_release):
9675 Move decls here, to check interfaces.
9676 * process.c (get_operating_system_release): Move decl to lisp.h.
9677 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9678 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9679 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9680 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9681 (Fformat_time_string, Fencode_time, Finsert_char):
9682 (Ftranslate_region_internal, Fformat):
9683 Rename or remove local vars to avoid shadowing.
9710023e 9684 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9685
a415e694
PE
9686 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9687 avoid shadowing.
9688
8ef4622d
PE
9689 * lisp.h (eassert): Check that the argument compiles, even if
9690 ENABLE_CHECKING is not defined.
9691
946f9a5b
PE
9692 * data.c (Findirect_variable): Name an expression, to avoid
9693 gcc -Wbad-function-cast warning.
112396d6 9694 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9695 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9696 (Fmake_variable_buffer_local, Fmake_local_variable):
9697 Mark variables as initialized.
52746918 9698 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9699
e5aab7e7 9700 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9701 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9702 Rename locals to avoid shadowing.
dff45157
PE
9703 (mark_stack): Move local variables into the #ifdef region where
9704 they're used.
7bc26fdb
PE
9705 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9706 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9707 needed otherwise.
9708 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9709 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9710 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9711
e5aab7e7
PE
9712 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9713 avoids undefined behavior in theory.
9714
4da60324
PE
9715 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9716
88043301
PE
9717 Use functions, not macros, for up- and down-casing (Bug#8254).
9718 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9719 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9720 to use the following functions instead of these macros.
9721 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9722 EMACS_INT, since callers assume the returned value fits in int.
9723 (upcase1): Likewise, for UPCASE_TABLE.
9724 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9725 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9726 the race-condition problem in the old DOWNCASE.
88043301 9727
19ed5445
PE
9728 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9729 Rename locals to avoid shadowing.
9730 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9731 (regex_compile, re_search_2, re_match_2_internal):
9732 Remove unused local vars.
952db0d7
PE
9733 (FREE_VAR): Rewrite so as not to use empty "else",
9734 which gcc can warn about.
da053e48 9735 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9736 (RETALLOC_IF): Define only if needed.
9737 (WORDCHAR_P): Likewise. This one is never needed, but is used
9738 only in a comment talking about a compiler bug, so put inside
9739 the #if 0 of that comment.
9740 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9741 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9742 Remove; unused.
19ed5445 9743
1f3561e4 9744 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9745 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9746 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9747
ded6f8f7
PE
9748 * search.c (simple_search): Remove unused var.
9749
dbd37a95
PE
9750 * dired.c (compile_pattern): Move decl from here ...
9751 * lisp.h: ... to here, so that it can be checked.
9752 (struct re_registers): New forward decl.
9753
7e47afad
PE
9754 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9755
85f24f61
PE
9756 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9757 All uses changed.
9758 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9759 Rename locals to avoid shadowing.
5671df8f 9760 (Fvertical_motion): Mark locals as initialized.
85f24f61 9761
181aa2be 9762 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9763 (casify_region): Mark local as initialized.
181aa2be 9764
930d429c
PE
9765 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9766
7082eac6
PE
9767 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9768 New macros, so that the caller can use some names other than
9769 gcpro1, gcpro2, etc.
9770 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9771 of the new macros.
9772 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9773 argument, for consistency with GCPRO2_VAR, etc: it is now the
9774 prefix of the variable, not the variable itself. All uses
9775 changed.
38b2c076
PE
9776 * dired.c (directory_files_internal, file_name_completion):
9777 Rename locals to avoid shadowing.
9778
15206ed9
PE
9779 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9780 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9781 dired.c's scmp function, had undefined behavior.
9782 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9783 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9784 * buffer.h: ... to here, because these macros use current_buffer,
9785 and the new implementation with inline functions needs to have
9786 current_buffer in scope now, rather than later when the macros
9787 are used.
9788 (downcase, upcase1): New static inline functions.
9789 (DOWNCASE, UPCASE1): Reimplement using these functions.
9790 This avoids undefined behavior in expressions like
9791 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9792 from race conditions in accessing the global variables
9793 case_temp1 and case_temp2.
9794 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9795 * lisp.h (case_temp1, case_temp2): Remove their decls.
9796 * character.h (ASCII_CHAR_P): Move from here ...
9797 * lisp.h: ... to here, so that the inline functions mentioned
9798 above can use them.
9799
4a6bea26
PE
9800 * dired.c (directory_files_internal_unwind): Now static.
9801
f14b7e14
PE
9802 * fileio.c (file_name_as_directory, directory_file_name):
9803 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9804 Now static.
2893f146
PE
9805 (file_name_as_directory): Use const pointers when appropriate.
9806 (Fexpand_file_name): Likewise. In particular, newdir might
9807 point at constant storage, so make it a const pointer.
fd4ead52 9808 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9809 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9810 signedness issues.
f839df0c
PE
9811 (Fset_file_times, Finsert_file_contents, auto_save_error):
9812 Rename locals to avoid shadowing.
f14b7e14 9813
5716756e 9814 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9815 (Ftry_completion, Fall_completions): Rename or remove locals
9816 to avoid shadowing.
5716756e 9817
b4c3046a
PE
9818 * marker.c (bytepos_to_charpos): Remove; unused.
9819
b45db522
PE
9820 * lisp.h (verify_bytepos, count_markers): New decls,
9821 so that gcc does not warn that these functions aren't declared.
9822
85876d07
PE
9823 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9824 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9825 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9826 (copy_text): Remove unused local var.
85876d07 9827
03d78a21 9828 * filelock.c (within_one_second): Now static.
b3dd38ab 9829 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9830
5df8f01b
PE
9831 * buffer.c (fix_overlays_before): Mark locals as initialized.
9832 (fix_start_end_in_overlays): Likewise. This function should be
9833 simplified by using pointers-to-pointers, but that's a different
9834 matter.
b1d876f1 9835 (switch_to_buffer_1): Now static.
8f54f30a
PE
9836 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9837 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9838
a70072c9 9839 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9840 Fix pointer signedness issue.
edced198
PE
9841 (sys_subshell): Mark local as volatile if checking for lint,
9842 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9843 (MAXPATHLEN): Define only if needed.
a70072c9 9844
a0977c44
PE
9845 * process.c (serial_open, serial_configure): Move decls from here ...
9846 * systty.h: ... to here, so that they can be checked.
9847
a884fdcc
PE
9848 * fns.c (get_random, seed_random): Move extern decls from here ...
9849 * lisp.h: ... to here, so that they can be checked.
9850
604efe86 9851 * sysdep.c (reset_io): Now static.
b8950c94 9852 (wait_for_termination_signal): Remove; unused.
604efe86 9853
38fc62d9
PE
9854 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9855 (copy_keymap_item, append_key, push_text_char_description):
9856 Now static.
1004a21a 9857 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9858 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9859 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9860 (describe_map_tree):
9861 Rename locals to avoid shadowing.
38fc62d9 9862
2f2650da
PE
9863 * keyboard.c: Declare functions static if they are not used elsewhere.
9864 (echo_char, echo_dash, cmd_error, top_level_2):
9865 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9866 (read_char, kbd_buffer_get_event, make_lispy_position):
9867 (make_lispy_event, make_lispy_movement, apply_modifiers):
9868 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9869 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9870 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9871 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9872 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9873
a053e86c 9874 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9875 (mark_kboards): Move decl here ...
9876 * alloc.c (mark_kboards): ... from here.
a053e86c 9877
4752793e
PE
9878 * lisp.h (force_auto_save_soon): New decl.
9879
74f10ca7 9880 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9881 (DEFINE_DUMMY_FUNCTION): New macro.
9882 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9883 Use it.
c03cd23f
PE
9884 (main): Add casts to avoid warnings
9885 if GCC considers string literals to be constants.
74f10ca7 9886
022e70d4
PE
9887 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9888
59d6fe83
PE
9889 * dbusbind.c: Pointer signedness fixes.
9890 (xd_signature, xd_append_arg, xd_initialize):
9891 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9892 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9893 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9894 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9895
78320123
PE
9896 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9897 if GCC considers string literals to be constants.
49cebcca 9898 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9899
35ac2a97
SM
99002011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9901
fb103ca9
SM
9902 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9903 (print_preprocess, print_object): New macro to fix last change.
9904
35ac2a97
SM
9905 * print.c (print_preprocess): Don't forget font objects.
9906
62973b41
JB
99072011-03-16 Juanma Barranquero <lekktu@gmail.com>
9908
9909 * emacs.c (USAGE3): Doc fixes.
9910
0e48bb22
AS
99112011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9912
9913 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9914 structure.
9915
7684e57b
JB
99162011-03-14 Juanma Barranquero <lekktu@gmail.com>
9917
9918 * lisp.h (VWindow_system, Qfile_name_history):
9919 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9920 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9921 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9922
9923 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9924 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9925
9926 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9927 * w32console.c (detect_input_pending, read_input_pending)
9928 (encode_terminal_code):
9929 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9930 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9931 (w32_system_caret_y, Qfile_name_history):
9932 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9933 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9934 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9935 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9936 * w32proc.c (Qlocal, report_file_error):
9937 * w32term.c (Vwindow_system, updating_frame):
9938 * w32uniscribe.c (initialized, uniscribe_font_driver):
9939 Remove unneeded extern declarations.
9940
2aa46d6c
CY
99412011-03-14 Chong Yidong <cyd@stupidchicken.com>
9942
c96bbc66 9943 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9944
cffc6f3b
CY
99452011-03-13 Chong Yidong <cyd@stupidchicken.com>
9946
9947 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9948 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9949 These macros can no longer be used for assignment.
9950
44f230aa
SM
9951 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9952 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9953 (record_buffer_markers, fetch_buffer_markers): New functions for
9954 recording and fetching special buffer markers.
9955 (set_buffer_internal_1, set_buffer_temp): Use them.
9956
9957 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9958
9959 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9960
9961 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9962 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9963
9964 * xdisp.c (hscroll_window_tree):
9965 (reconsider_clip_changes): Use PT instead of BUF_PT.
9966
d251f04b
EZ
99672011-03-13 Eli Zaretskii <eliz@gnu.org>
9968
9969 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9970 $(EMACS_ROOT)/lib/intprops.h.
9971
f0c77cd1
PE
99722011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9973
3eca4629
PE
9974 Fix more problems found by GCC 4.5.2's static checks.
9975
7c86ee98
PE
9976 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9977 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9978 (xg_free_frame_widgets): Make it clear that a local variable is
9979 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9980 (gdk_window_get_screen): Make it clear that this macro is needed
9981 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9982 (int_gtk_range_get_value): New function, which avoids a diagnostic
9983 from gcc -Wbad-function-cast.
9984 (xg_set_toolkit_scroll_bar_thumb): Use it.
9985 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9986 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9987 (get_utf8_string, xg_get_file_with_chooser):
9988 Rename locals to avoid shadowing.
9989 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9990
41729b81
PE
9991 * xgselect.c (xg_select): Remove unused var.
9992
f0c77cd1
PE
9993 * image.c (four_corners_best): Mark locals as initialized.
9994 (gif_load): Initialize transparent_p to zero (Bug#8238).
9995 Mark another local as initialized.
ec6cf4c6 9996 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9997
ce0ad53d 9998 * image.c (clear_image_cache): Now static.
d5d5a617 9999 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 10000 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
10001 (x_edge_detection): Remove unnecessary cast that
10002 gcc -Wbad-function-cast diagnoses.
2037898d 10003 (gif_load): Fix pointer signedness.
6ae141d6
PE
10004 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10005 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 10006
33383987 100072011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 10008
d32df629
PE
10009 Improve quality of tests for time stamp overflow.
10010 For example, without this patch (encode-time 0 0 0 1 1
10011 1152921504606846976) returns the obviously-bogus value (-948597
10012 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10013 reports time overflow. See
10014 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
10015 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10016 * editfns.c: Include limits.h and intprops.h.
10017 (TIME_T_MIN, TIME_T_MAX): New macros.
10018 (time_overflow): Move earlier, to before first use.
10019 (hi_time, lo_time): New functions, for an accurate test for
10020 out-of-range times.
10021 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10022 (Fget_internal_run_time): Don't assume time_t fits in int.
10023 (make_time): Use list2 instead of Fcons twice.
10024 (Fdecode_time): More accurate test for out-of-range times.
10025 (check_tm_member): New function.
10026 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
10027 (lisp_time_argument): Don't rely on undefined left-shift and
10028 right-shift behavior when checking for time stamp overflow.
8be6f318 10029
fe31d94c
PE
10030 * editfns.c (time_overflow): New function, refactoring common code.
10031 (Fformat_time_string, Fdecode_time, Fencode_time):
10032 (Fcurrent_time_string): Use it.
10033
8be6f318
PE
10034 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10035 * dired.c (make_time): Move to ...
10036 * editfns.c (make_time): ... here.
10037 * systime.h: Note the move.
10038
09d9db2c 100392011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 10040
126bc0dc
YM
10041 * fringe.c (update_window_fringes): Remove unused variables.
10042
c47cbdfd
YM
10043 * unexmacosx.c (copy_data_segment): Also copy __got section.
10044 (Bug#8223)
10045
7ac80be9
EZ
100462011-03-12 Eli Zaretskii <eliz@gnu.org>
10047
c96bbc66 10048 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
10049 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10050 Constify `char *' arguments and their references according to
10051 prototypes in tparam.h.
10052
ecb0f94d 10053 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 10054
7ac80be9
EZ
10055 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10056 Adapt all references accordingly.
10057
10058 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10059
ef1fd07e
TT
100602011-03-11 Tom Tromey <tromey@redhat.com>
10061
10062 * buffer.c (syms_of_buffer): Remove obsolete comment.
10063
7ef4b50c
EZ
100642011-03-11 Eli Zaretskii <eliz@gnu.org>
10065
10066 * termhooks.h (encode_terminal_code): Declare prototype.
10067
10068 * msdos.c (encode_terminal_code): Don't declare prototype.
10069
10070 * term.c (encode_terminal_code): Now external again, used by
10071 w32console.c and msdos.c.
10072
44f230aa
SM
10073 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
10074 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 10075
4b1ec863 100762011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 10077
1714f52b 10078 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 10079
4b1ec863
PE
10080 * fringe.c (update_window_fringes): Mark locals as initialized
10081 (Bug#8227).
10082 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 10083
524c7aa6
PE
10084 * alloc.c (mark_fringe_data): Move decl from here ...
10085 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10086 to check its interface.
10087 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10088
a5c0af81 10089 * fontset.c (free_realized_fontset): Now static.
7519b8cd 10090 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 10091 (fontset_font): Mark local as initialized.
a9a06e0b 10092 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 10093
b4716021
PE
10094 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10095
811e9bac 10096 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 10097 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
10098 (x_own_selection, Fx_disown_selection_internal): Rename locals
10099 to avoid shadowing.
10100 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 10101
7e3ab302
PE
10102 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10103 so that the caller can use some name other than gcpro1.
10104 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
10105 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10106 (Fx_backspace_delete_keys_p):
10107 Use them to avoid shadowing, and rename vars to avoid shadowing.
10108 (x_decode_color, x_set_name, x_window): Now static.
6b437900 10109 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 10110 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
10111 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10112 Remove unused locals.
7e3ab302
PE
10113 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10114 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10115 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10116 macros.
f78faa98 10117
e2b13473
PE
10118 * xterm.h (x_mouse_leave): New decl.
10119
77f23912
PE
10120 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10121 Remove unused functions.
cdf4ba58
PE
10122 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10123 (x_calc_absolute_position): Now static.
7411c686 10124 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 10125 Don't declare local "event" unless it's used.
ed7bf3a5
PE
10126 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10127 unless they are used.
38d0b34a
PE
10128 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10129 (x_fatal_error_signal): Remove; not used.
a6067996
PE
10130 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10131 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10132 (x_error_catcher, x_connection_closed, x_error_handler):
10133 (x_error_quitter, xembed_send_message, x_iconify_frame):
10134 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 10135 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 10136 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 10137
44f230aa
SM
10138 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10139 Rename or move locals to avoid shadowing.
6b463e58 10140 (tty_defined_color, merge_face_heights): Now static.
5967d051 10141 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
10142 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10143 does not deduce is never used uninitialized.
73719eba
PE
10144 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10145 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 10146
426994c3 10147 * terminal.c (store_terminal_param): Now static.
5489860b 10148
032f1620 10149 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 10150 (set_frame_menubar): Remove unused local.
d4323972 10151 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
10152 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10153 since they might point to immutable storage.
281585b0
PE
10154 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10155 since it's unused otherwise.
032f1620 10156
367c19e5 10157 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 10158 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
10159 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10160 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 10161 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
10162 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10163 does not deduce are never used uninitialized.
70739cbe 10164
07b48fa9
PE
10165 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10166
8868a238 10167 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
10168 * window.c (window_loop, size_window):
10169 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 10170
7e5cf297 10171 * window.c (display_buffer): Now static.
d6550a9f
PE
10172 (size_window): Mark variables that gcc -Wuninitialized
10173 does not deduce are never used uninitialized.
a586633d
PE
10174 * window.h (check_all_windows): New decl, to forestall
10175 gcc -Wmissing-prototypes diagnostic.
5b555da1 10176 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 10177
f6095868
PE
10178 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10179 shadowing.
10180 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
10181 Include <limits.h>.
10182 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10183 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
10184 (load_charset_map): Mark variables that gcc -Wuninitialized
10185 does not deduce are never used uninitialized.
53df7c11 10186 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 10187
f38b440c
PE
10188 * coding.c (coding_set_source, coding_set_destination):
10189 Use "else { /* comment */ }" rather than "else /* comment */;"
10190 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
10191 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10192 a block, when the outer 'i' will do.
10193 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10194 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10195 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10196 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10197 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10198 Rename locals to avoid shadowing.
10199 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
10200 * coding.c (emacs_mule_char, encode_invocation_designation):
10201 Now static, since they're not used elsewhere.
413bb2db 10202 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 10203 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
10204 (decode_coding_emacs_mule): Mark variables that gcc
10205 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
10206 (detect_coding_iso_2022): Initialize a local variable that might
10207 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 10208 this initialization is needed. (Bug#8211)
5f58e762
PE
10209 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10210 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10211 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10212 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10213 Remove unused macros.
f38b440c 10214
232b38b9 10215 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 10216 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 10217 * character.c (string_count_byte8): Likewise.
232b38b9 10218
fb90da1b
PE
10219 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10220 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10221
fb93dbc2
PE
10222 * chartab.c (copy_sub_char_table): Now static, since it's not used
10223 elsewhere.
5c156ace
PE
10224 (sub_char_table_ref_and_range, char_table_ref_and_range):
10225 Rename locals to avoid shadowing.
bbcd0949 10226 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 10227
7d3b3862 10228 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 10229 (BIDI_BOB): Remove unused macro.
7d3b3862 10230
6be7d3da
PE
10231 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10232 deduce are never used uninitialized.
c2ed9c8b 10233 * term.c (encode_terminal_code): Likewise.
6be7d3da 10234
75f8807f 10235 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 10236
50938595
PE
10237 * tparam.h: New file.
10238 * term.c, tparam.h: Include it.
10239 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10240 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10241 Move these decls to tparam.h, and make them agree with what
10242 is actually in tparam.c. The previous trick of using incompatible
10243 decls in different modules does not conform to the C standard.
10244 All callers of tparam changed to use tparam's actual API.
10245 * tparam.c (tparam1, tparam, tgoto):
10246 Use const pointers where appropriate.
10247
fbceeba2
PE
10248 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10249 * cm.h (struct cm): Likewise.
10250 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10251 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10252 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10253 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10254 (turn_on_face, init_tty): Likewise.
10255 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 10256
7f3f1250
PE
10257 * term.c (term_mouse_position): Rename local to avoid shadowing.
10258
e6ca6543
PE
10259 * alloc.c (mark_ttys): Move decl from here ...
10260 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10261
c40f8d15
AS
102622011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10263
10264 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10265
cfe0661d
JB
102662011-03-09 Juanma Barranquero <lekktu@gmail.com>
10267
10268 * search.c (compile_pattern_1): Remove argument regp, unused since
10269 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10270 (compile_pattern): Don't pass it.
10271
0afb4571
J
102722011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10273
10274 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10275 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10276 for ! HAVE_GTK3.
10277 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10278
10279 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10280
10281 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10282 gdk_window_get_screen, gdk_window_get_geometry,
10283 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10284 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10285 (xg_get_pixbuf_from_pixmap): New function.
10286 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10287 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10288 Call xg_get_pixbuf_from_pixmap instead of
10289 gdk_pixbuf_get_from_drawable.
10290 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10291 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10292 (xg_check_special_colors): Use GtkStyleContext and its functions
10293 for HAVE_GTK3.
10294 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10295 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10296 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
10297 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10298 Call gtk_widget_get_preferred_size.
0afb4571
J
10299 (xg_frame_resized): gdk_window_get_geometry only takes 5
10300 parameters.
44f230aa
SM
10301 (xg_win_to_widget, xg_event_is_for_menubar):
10302 Call gdk_x11_window_lookup_for_display.
0afb4571
J
10303 (xg_set_widget_bg): New function.
10304 (delete_cb): New function.
895009e1 10305 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 10306 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
10307 (xg_set_background_color): Call xg_set_widget_bg.
10308 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10309 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10310 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10311 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10312 if ! HAVE_GTK3.
10313 (update_frame_tool_bar): Call gtk_widget_hide.
10314 (xg_initialize): Use GDK_KEY_g.
10315
10316 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10317 if ! HAVE_GTK3
10318 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10319
10320 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10321 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10322 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10323
1c2cc4ef
JB
103242011-03-08 Juanma Barranquero <lekktu@gmail.com>
10325
10326 * w32xfns.c (select_palette): Check success of RealizePalette against
10327 GDI_ERROR, not zero.
10328
33383987 10329See ChangeLog.11 for earlier changes.
aac0c6e3
MR
10330
10331;; Local Variables:
10332;; coding: utf-8
aac0c6e3
MR
10333;; End:
10334
2f097256 10335 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
10336
10337 This file is part of GNU Emacs.
10338
10339 GNU Emacs is free software: you can redistribute it and/or modify
10340 it under the terms of the GNU General Public License as published by
10341 the Free Software Foundation, either version 3 of the License, or
10342 (at your option) any later version.
10343
10344 GNU Emacs is distributed in the hope that it will be useful,
10345 but WITHOUT ANY WARRANTY; without even the implied warranty of
10346 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10347 GNU General Public License for more details.
10348
10349 You should have received a copy of the GNU General Public License
10350 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.