* xfaces.c (Qframe_set_background_mode): Now static.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0a0d27fb
PE
12011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2
19d5c50c
PE
3 * xfaces.c (Qframe_set_background_mode): Now static.
4 * dispextern.h (Qframe_set_background_mode): Remove decl.
5
0a0d27fb
PE
6 * process.c (Fnetwork_interface_info): Declare local only if needed.
7
377538cb
JD
82011-08-13 Jan Djärv <jan.h.d@swipnet.se>
9
10 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
11 (Fnetwork_interface_list): Allocate in increments of bytes instead
12 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
13 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
14 sockaddr.
15 (struct ifflag_def): notrailers is smart on OSX.
16 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
17 Get hardware address with getifaddrs if available.
18
08fff70c
EZ
192011-08-12 Eli Zaretskii <eliz@gnu.org>
20
21 * xdisp.c (iterate_out_of_display_property): xassert that
22 IT->position is set to within IT->object's boundaries. Break from
23 the loop as soon as EOB is reached; avoids infloops in redisplay
24 when IT->position is set up wrongly due to some bug. Set
25 IT->current to match the bidi iterator unconditionally.
26 (push_display_prop): Allow GET_FROM_STRING as IT->method on
27 entry. Force push_it to save on the stack the current
28 buffer/string position, to be restored by pop_it. Fix flags in
29 the iterator structure wrt the object coming from a display
30 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
31 properties. (Bug#9284)
32
7be1c708 332011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 34
7be1c708
CY
35 * fontset.c (fontset_get_font_group): Add proper type checks.
36 (Bug#9172)
aac0c6e3 37
7be1c708 382011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 39
7be1c708
CY
40 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
41 and LC_VERSION_MIN_MACOSX.
42 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
43 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 44
97bb72a6
EZ
452011-08-08 Eli Zaretskii <eliz@gnu.org>
46
47 * xdisp.c (forward_to_next_line_start): Allow to use the
757664a4
EZ
48 no-display-properties-and-no-overlays under bidi display. Set
49 disp_pos in the bidi iterator to avoid searches for display
50 properties and overlays.
97bb72a6 51
d5617611
CY
522011-08-08 Chong Yidong <cyd@stupidchicken.com>
53
37e11a63
CY
54 * editfns.c (Fset_time_zone_rule): Document relationship with the
55 setenv function.
56
d5617611
CY
57 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
58 the font entity extracted from the cache (Bug#8109).
59
58872834
CY
602011-08-07 Chong Yidong <cyd@stupidchicken.com>
61
62 * composite.c (autocmp_chars): Don't reset point. That is done by
63 restore_point_unwind (Bug#5984).
64
75bfc667
JL
652011-08-07 Juri Linkov <juri@jurta.org>
66
67 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
68 to show the arg `TIME' instead of `TIMEVAL'.
69
d1410150
EZ
702011-08-06 Eli Zaretskii <eliz@gnu.org>
71
72 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
73 display property strides EOL and includes a newline, as in
74 longlines-mode. (Bug#9254)
75b771e4
EZ
75 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
76 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
77
78 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
79 is non-zero, even if the data buffer is NULL. Fixes a crash in
80 vertical-motion with longlines-mode. (Bug#9254)
81
35928349
EZ
822011-08-05 Eli Zaretskii <eliz@gnu.org>
83
ec7cc85b
EZ
84 * bidi.c <bidi_cache_total_alloc>: Now static.
85 (bidi_initialize): Initialize bidi_cache_total_alloc.
86
35928349
EZ
87 *xdisp.c (display_line): Release buffer allocated for shelved bidi
88 cache. (Bug#9221)
89
90 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
91 amount allocated this far in `bidi_cache_total_alloc'.
92 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
93 non-zero, only free the data buffer without restoring the cache
94 contents. All callers changed.
95
96 * dispextern.h (bidi_unshelve_cache): Update prototype.
97
98 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
99 (move_it_in_display_line, move_it_to)
100 (move_it_vertically_backward, move_it_by_lines): Replace the call
101 to xfree to an equivalent call to bidi_unshelve_cache.
102 (move_it_in_display_line_to): Fix logic of returning
412b6358 103 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 104
e2e2423b
EZ
1052011-08-05 Eli Zaretskii <eliz@gnu.org>
106
107 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
108 came from a string character with a `cursor' property. (Bug#9229)
109
ae9e757a
JD
1102011-08-04 Jan Djärv <jan.h.d@swipnet.se>
111
112 * Makefile.in (LIB_PTHREAD): New variable.
113 (LIBES): Add LIB_PTHREAD (Bug#9216).
114
115 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
116 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
117
213bd7f2
AS
1182011-08-04 Andreas Schwab <schwab@linux-m68k.org>
119
120 * regex.c (re_iswctype): Remove some redundant boolean
121 conversions.
122
99aaf75f
JD
1232011-08-04 Jan Djärv <jan.h.d@swipnet.se>
124
125 * xterm.c (x_find_topmost_parent): New function.
126 (x_set_frame_alpha): Find topmost parent window with
127 x_find_topmost_parent and set the property there also (bug#9181).
128 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
129
c74e9d86
PE
1302011-08-04 Paul Eggert <eggert@cs.ucla.edu>
131
132 * callproc.c (Fcall_process): Avoid vfork clobbering
133 the local vars buffer, coding_systems, current_dir.
134
640c8776
SM
1352011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
136
137 * keymap.c (Fmake_composed_keymap): Move to subr.el.
138
f26d0e4c
PE
1392011-08-03 Paul Eggert <eggert@cs.ucla.edu>
140
8a10d76c
PE
141 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
142 so that it is not optimized away.
143
f26d0e4c
PE
144 * xdisp.c (compute_display_string_pos): Remove unused local.
145
55439c61
EZ
1462011-08-02 Eli Zaretskii <eliz@gnu.org>
147
148 Fix slow cursor motion and scrolling in large buffers with
149 selective display, like Org Mode buffers. (Bug#9218)
150
151 * dispextern.h (struct bidi_it): New member disp_prop_p.
152
153 * xdisp.c: Remove one-slot cache of display string positions.
154 (compute_display_string_pos): Accept an additional argument
155 DISP_PROP_P; callers changed. Scan at most 5K characters forward
156 for a display string or property. If found, set DISP_PROP_P
157 non-zero.
158
159 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
160 DISP_PROP_P, and pass it to compute_display_string_pos.
161 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
162 non-zero. All callers of bidi_fetch_char changed.
163
fb33fa43
SM
1642011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
165
166 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
167
b099e063
DM
1682010-12-03 Don March <don@ohspite.net>
169
170 * keymap.c (Fdefine_key): Fix non-prefix key error message when
171 last character M-[char] is translated to ESC [char] (bug#7541).
172
5cc7f7af
KH
1732011-08-02 Kenichi Handa <handa@m17n.org>
174
d0fffa3f 175 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
176
177 * chartab.c (uniprop_table): Make it non-static.
178
525d5e6e
EZ
1792011-08-01 Eli Zaretskii <eliz@gnu.org>
180
181 * xdisp.c (forward_to_next_line_start): Accept additional argument
182 BIDI_IT_PREV, and store into it the state of the bidi iterator had
183 on the newline.
184 (reseat_at_next_visible_line_start): Use the bidi iterator state
185 returned by forward_to_next_line_start to restore the state of
186 it->bidi_it after backing up to previous newline. (Bug#9212)
187
31011111
AS
1882011-07-30 Andreas Schwab <schwab@linux-m68k.org>
189
190 * regex.c (re_comp): Protoize.
191 (re_exec): Fix return type.
192 (regexec): Fix type of `ret'. (Bug#9203)
193
e5d76069
PE
1942011-07-29 Paul Eggert <eggert@cs.ucla.edu>
195
196 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
197 This is needed if max-image-size is a floating-point number.
198
9a79b20c
AS
1992011-07-28 Andreas Schwab <schwab@linux-m68k.org>
200
201 * print.c (print_object): Print empty symbol as ##.
202
203 * lread.c (read1): Read ## as empty symbol.
204
d8c2fa78
AA
2052011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
206
207 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
208 setting frame foreground color (Bug#9175).
209 (x_set_background_color): Likewise.
210
ffe57a7a
AA
211 * nsmenu.m (-setText): Size tooltip dimensions precisely to
212 contents (Bug#9176).
213 (EmacsTooltip -init): Remove bezels and add shadows to
214 tooltip windows.
215
bf3492a5
AA
216 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
217 or scroll bar (Bug#8470).
218
d55e9c53
AA
219 * nsfont.m (nsfont_open): Remove assignment to voffset and
220 unnecessary vars hshink, expand, hd, full_height, min_height.
221 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
222
223 * nsterm.h (nsfont_info): Remove voffset field.
224
d8c2fa78 2252011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
226
227 Implement strike-through and overline on NextStep (Bug#8863).
228
229 * nsfont.m (nsfont_open): Use underline position provided by font,
230 instead of hard-coded value of 2.
231 (nsfont_draw): Call ns_draw_text_decoration instead.
232
233 * nsterm.h: Add declaration for ns_draw_text_decoration.
234
235 * nsterm.m (ns_draw_text_decoration): New function for drawing
236 underline, overline, and strike-through.
237 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
238 ns_draw_text_decoration. Change treatment of cursor drawing to
239 accomodate underlining, etc.
240
4cc60b9b
EZ
2412011-07-28 Eli Zaretskii <eliz@gnu.org>
242
bc7ece87
EZ
243 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
244 default.
4cc60b9b 245
476371c4
PE
2462011-07-28 Paul Eggert <eggert@cs.ucla.edu>
247
66606eea
PE
248 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
249 Without this fix, if a signal arrives just after memory fills up,
250 'malloc' might be invoked reentrantly.
251
476371c4
PE
252 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
253 In other words, assume that every image size is allowed, on non-X
254 hosts. This assumption is probably wrong, but it lets Emacs compile.
255
f3fcc40d
AS
2562011-07-28 Andreas Schwab <schwab@linux-m68k.org>
257
258 * regex.c (re_iswctype): Convert return values to boolean.
259
350c992f
EZ
2602011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
261
262 * xdisp.c (compute_display_string_pos): Don't use cached display
263 string position if the buffer had its restriction changed.
264 (Bug#9184)
265
5266b4bb
PE
2662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
267
268 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
269
2573a837 2702011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 271
41f55ccd 272 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 273
39e378da
PE
274 * bidi.c: Integer size and overflow fixes.
275 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
276 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
277 (bidi_cache_find_level_change, bidi_cache_ensure_space)
278 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
279 (bidi_find_other_level_edge):
280 Use ptrdiff_t instead of EMACS_INT where either will do.
281 This works better on 32-bit hosts configured --with-wide-int.
282 (bidi_cache_ensure_space): Check for size-calculation overflow.
283 Use % rather than repeated addition, for better worst-case speed.
284 Don't set bidi_cache_size until after xrealloc returns, because it
285 might not return.
286 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
287 (bidi_cache_ensure_space): Also check that the bidi cache size
288 does not exceed that of the largest Lisp string or buffer. See Eli
289 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 290
5e927815
PE
291 * alloc.c (__malloc_size_t): Remove.
292 All uses replaced by size_t. See Andreas Schwab's note
293 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
294
ca4aa935
PE
295 * image.c: Improve checking for integer overflow.
296 (check_image_size): Assume that f is nonnull, since
297 it is always nonnull in practice. This is one less thing to
298 worry about when checking for integer overflow later.
299 (x_check_image_size): New function, which checks for integer
300 overflow issues inside X.
301 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
302 This removes the need for a memory_full check.
303 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
304 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
305 (xbm_read_bitmap_data): Change locals back to 'int', since
306 their values must fit in 'int'.
307 (xpm_load_image, png_load, tiff_load):
308 Invoke x_create_x_image_and_pixmap earlier,
309 to avoid much needless work if the image is too large.
310 (tiff_load): Treat overly large images as if
311 x_create_x_image_and_pixmap failed, not as malloc failures.
312 (gs_load): Use x_check_image_size.
313
5f8f9cc2
PE
314 * gtkutil.c: Omit integer casts.
315 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
316 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
317
5adf60bc
PE
318 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
319
c8907a93
PE
320 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
321 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
322 would wrongly return t on a 64-bit host.
323
e3c25c68
PE
324 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
325 The plain *_OVERFLOW macros run afoul of GCC bug 49705
326 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
327 and therefore cause GCC to emit a bogus diagnostic in some cases.
328
3f791afe
PE
329 * image.c: Integer signedness and overflow and related fixes.
330 This is not an exhaustive set of fixes, but it's time to
331 record what I've got.
332 (lookup_pixel_color, check_image_size): Remove redundant decls.
333 (check_image_size): Don't assume that arbitrary EMACS_INT values
334 fit in 'int', or that arbitrary 'double' values fit in 'int'.
335 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
336 (tiff_load, imagemagick_load_image):
337 Check for overflow in size calculations.
338 (x_create_x_image_and_pixmap): Remove unnecessary test for
339 xmalloc returning NULL; that can't happen.
340 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
341 (xpm_color_bucket): Use better integer hashing function.
342 (xpm_cache_color): Don't possibly over-allocate memory.
343 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
344 (gif_memory_source):
345 Use ptrdiff_t, not int or size_t, to record sizes.
346 (png_load): Don't assume values greater than 2**31 fit in 'int'.
347 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
348 either works, as we prefer signed integers.
349 (tiff_read_from_memory, tiff_write_from_memory):
350 Return tsize_t, not size_t, since that's what the TIFF API wants.
351 (tiff_read_from_memory): Don't fail simply because the read would
352 go past EOF; instead, return a short read.
353 (tiff_load): Omit no-longer-needed casts.
354 (Fimagemagick_types): Don't assume size fits into 'int'.
355
3cc5a532
PE
356 Improve hashing quality when configured --with-wide-int.
357 * fns.c (hash_string): New function, taken from sxhash_string.
358 Do not discard information about ASCII character case; this
359 discarding is no longer needed.
360 (sxhash-string): Use it. Change sig to match it. Caller changed.
361 * lisp.h: Declare it.
362 * lread.c (hash_string): Remove, since we now use fns.c's version.
363 The fns.c version returns a wider integer if --with-wide-int is
364 specified, so this should help the quality of the hashing a bit.
365
b312a492
PE
366 * emacs.c: Integer overflow minor fix.
367 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
368 Define only if GNU_LINUX.
369 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
370
dfd153ae
PE
371 * dispnew.c: Integer signedness and overflow fixes.
372 Remove unnecessary forward decls, that were a maintenance hassle.
373 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
374 All uses changed.
375 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
376 (scrolling_window): Use ptrdiff_t, not int, for byte count.
377 (prepare_desired_row, line_draw_cost):
378 Use int, not unsigned, where either works.
379 (save_current_matrix, restore_current_matrix):
380 Use ptrdiff_t, not size_t, where either works.
381 (init_display): Check for overflow more accurately, and without
382 relying on undefined behavior.
383
a81d11a3
PE
384 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
385 Remove, replacing with the new symbols in lisp.h. All uses changed.
386 * fileio.c (make_temp_name):
387 * filelock.c (lock_file_1, lock_file):
388 * xdisp.c (message_dolog):
389 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
390 Use pMd etc. instead.
391 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
392 replacing the pWIDE etc. symbols removed from editfns.c.
393
3300e6fd
PE
394 * keyboard.h (num_input_events): Now uintmax_t.
395 This is (very slightly) less likely to mess up due to wraparound.
396 All uses changed.
397
fd05c7e9
PE
398 * buffer.c: Integer signedness fixes.
399 (alloc_buffer_text, enlarge_buffer_text):
400 Use ptrdiff_t rather than size_t when either will do, as we prefer
401 signed integers.
402
903fe15d
PE
403 * alloc.c: Integer signedness and overflow fixes.
404 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
405 (__malloc_size_t): Default to size_t, not to int.
406 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
407 (Fgarbage_collect, mark_object_loop_halt, mark_object):
408 Prefer ptrdiff_t to size_t when either would do, as we prefer
409 signed integers.
410 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
411 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
412 Now const. Initialize with values that are in range even if char
413 is signed.
414 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
415 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
416 These functions do the right thing with sizes > 2**32.
417 (check_depth): Now ptrdiff_t, not int.
418 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
419 Adjust to new way of storing sizes. Check for size overflow bugs
420 in rest of code.
421 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
422 slightly wrong anyway, as it missed one instance of
423 XMALLOC_OVERRUN_CHECK_OVERHEAD.
424 (refill_memory_reserve): Omit needless cast to size_t.
425 (mark_object_loop_halt): Mark as externally visible.
426
ac82cc6a
PE
427 * xselect.c: Integer signedness and overflow fixes.
428 (Fx_register_dnd_atom, x_handle_dnd_message):
429 Use ptrdiff_t, not size_t, since we prefer signed.
430 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
431 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
432 x_dnd_atoms_size and x_dnd_atoms_length.
433
c2d1e36d
PE
434 * doprnt.c: Prefer signed to unsigned when either works.
435 * eval.c (verror):
436 * doprnt.c (doprnt):
437 * lisp.h (doprnt):
438 * xdisp.c (vmessage):
439 Use ptrdiff_t, not size_t, when using or implementing doprnt,
440 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
441 prefer signed arithmetic to avoid comparison confusion.
442 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
443 but is a bit tricky.
444
0e926e56
PE
445 Assume freestanding C89 headers, string.h, stdlib.h.
446 * data.c, doprnt.c, floatfns.c, print.c:
447 Include float.h unconditionally.
448 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
449 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
450 * regex.c: Likewise for stddef.h, string.h.
451 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
452 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
453 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
454 (STDC_HEADERS): Remove obsolete defines.
455 * sysdep.c: Include limits.h unconditionally.
456
9cfdb3ec
PE
457 Assume support for memcmp, memcpy, memmove, memset.
458 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
459 * regex.c (memcmp, memcpy):
460 Remove; we assume C89 now.
461
462 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
463 (__malloc_safe_bcopy): Remove; no longer needed.
464
cf950e6b 465 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
466 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
467 well either way, and we prefer signed to unsigned.
468
dbf38e02
LMI
4692011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
470
471 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
472 closes the connection while we're reading (bug#9182).
473
d6f0886c
JD
4742011-07-25 Jan Djärv <jan.h.d@swipnet.se>
475
476 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
477 are specified (Bug#9168).
478
2eb1f9e6
PE
4792011-07-25 Paul Eggert <eggert@cs.ucla.edu>
480
481 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
482 Found by GCC static checking and --with-wide-int on a 32-bit host.
483
22381272 4842011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
485
486 * xdisp.c (compute_display_string_pos): Fix logic of caching
487 previous display string position. Initialize cached_prev_pos to
488 -1. Fixes slow-down at the beginning of a buffer.
489
f25e39b4
EZ
4902011-07-24 Eli Zaretskii <eliz@gnu.org>
491
492 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
493 for attrs[LFACE_FONTSET_INDEX].
494
04c4b52e
PE
4952011-07-23 Paul Eggert <eggert@cs.ucla.edu>
496
497 * xml.c (parse_region): Remove unused local
498 that was recently introduced.
499
c1734fbd
EZ
5002011-07-23 Eli Zaretskii <eliz@gnu.org>
501
be18c5a5
EZ
502 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
503 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
504
c1734fbd
EZ
505 * xdisp.c (move_it_in_display_line_to): Record the best matching
506 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
507 exit if none of the characters scanned was an exact match.
508 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
509 when exact match is impossible due to invisible text, and the
510 lines are truncated.
511
a258d627
JD
5122011-07-23 Jan Djärv <jan.h.d@swipnet.se>
513
514 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
515 for OSX >= 10.7.
516
b6d5a689
EZ
5172011-07-22 Eli Zaretskii <eliz@gnu.org>
518
0f74f785
EZ
519 Fix a significant slow-down of cursor motion with C-n, C-p,
520 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
521 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 522 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
523 (next_element_from_buffer): Call compute_stop_pos_backwards to
524 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
525 base_level_stop.
526 (reseat): Don't look for prev_stop, as that could mean a very long
527 run.
528 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
529 <cached_disp_overlay_modiff>: Cache for last found display string
530 position.
551918c1 531 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
532 about the same buffer in the same area of character positions, and
533 the buffer wasn't changed since the time the display string
534 position was cached.
551918c1 535
b2d0c91a
EZ
5362011-07-22 Eli Zaretskii <eliz@gnu.org>
537
538 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
539 is an integer, which is important for empty lines. (Bug#9149)
540
043604ee
CY
5412011-07-22 Chong Yidong <cyd@stupidchicken.com>
542
543 * frame.c (Fmodify_frame_parameters): In tty case, update the
544 default face if necessary (Bug#4238).
545
da4adb04
CY
5462011-07-21 Chong Yidong <cyd@stupidchicken.com>
547
548 * editfns.c (Fstring_to_char): No need to explain what a character
549 is in the docstring (Bug#6576).
550
9abd0532
LMI
5512011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
552
553 * xml.c (parse_region): Make sure we always return a tree.
554
36881d16
HK
5552011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
556
557 * xml.c (parse_region): If a document contains only comments,
558 return that, too.
559
1e98674d
LMI
5602011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
561
562 * xml.c (make_dom): Return comments, too.
563
590bd467
PE
5642011-07-19 Paul Eggert <eggert@cs.ucla.edu>
565
566 Port to OpenBSD.
567 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
568 and the surrounding thread.
569 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
570 rather than fgets, and retry after EINTR. Otherwise, 'emacs
571 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
572 timer goes off.
573 * s/openbsd.h (BROKEN_SIGIO): Define.
574 * unexelf.c (unexec) [__OpenBSD__]:
575 Don't update the .mdebug section of the Alpha COFF symbol table.
576
f41628b2
LMI
5772011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
578
579 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
580 (bug#8460).
581
b59b67c5
PE
5822011-07-18 Paul Eggert <eggert@cs.ucla.edu>
583
15e3a074
PE
584 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
585 This fixes some race conditions on the permissions of any newly
586 created file.
587
41bed37d
PE
588 * alloc.c (valid_pointer_p): Use pipe, not open.
589 This fixes some permissions issues when debugging.
590
b59b67c5
PE
591 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
592 If fchown fails to set both uid and gid, try to set just gid,
593 as that is sometimes allowed. Adjust the file's mode to eliminate
594 setuid or setgid bits that are inappropriate if fchown fails.
595
925a6be7
SM
5962011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
597
598 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
599 to compare Lisp_Objects.
600 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
601 global_gnutls_log_level, don't mistake it for a Lisp_Object.
602 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
603
52968808
AS
6042011-07-17 Andreas Schwab <schwab@linux-m68k.org>
605
0a6a104b
AS
606 * lread.c (read_integer): Unread even EOF character.
607 (read1): Likewise. Properly record start position of symbol.
608
52968808
AS
609 * lread.c (read1): Read `#:' as empty uninterned symbol if no
610 symbol character follows.
611
9e381cdd
PE
6122011-07-17 Paul Eggert <eggert@cs.ucla.edu>
613
614 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
615 This works around a problem with the previous change to Fcopy_file.
616 Recent glibc declares fchown with __attribute__((warn_unused_result)),
617 and without this change, GCC might complain about discarding
618 fchown's return value.
619
b5641435
JB
6202011-07-16 Juanma Barranquero <lekktu@gmail.com>
621
622 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
623
a8031457
PE
6242011-07-16 Paul Eggert <eggert@cs.ucla.edu>
625
626 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
627
dd889327
LMI
6282011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
629
750c33f7
LMI
630 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
631 it's used from the C level.
632
dd889327
LMI
633 * process.c: Use the same condition for POLL_FOR_INPUT in both
634 keyboard.c and process.c (bug#1858).
635
87e86684
LM
6362011-07-09 Lawrence Mitchell <wence@gmx.li>
637
638 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
639 (Fgnutls_boot): Use it.
640
64348f40
AS
6412011-07-15 Andreas Schwab <schwab@linux-m68k.org>
642
643 * doc.c (Fsubstitute_command_keys): Revert last change.
644
1d698799
LMI
6452011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
646
f863868c
LMI
647 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
648 quotes the next character, and doesn't affect other longer
649 sequences (bug#8935).
650
1d698799
LMI
651 * lread.c (syms_of_lread): Clarify that is isn't only
652 `eval-buffer' and `eval-defun' that's affected by
653 `lexical-binding' (bug#8460).
654
aa4b6df6
EZ
6552011-07-15 Eli Zaretskii <eliz@gnu.org>
656
657 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
658 bidi redisplay when a line includes both an image and is
659 truncated.
660
5d856da6
PE
6612011-07-14 Paul Eggert <eggert@cs.ucla.edu>
662
ad6042bb
PE
663 Fix minor problems found by static checking.
664 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
665 (elsz): Now a signed constant, not a size_t var. We prefer signed
666 types to unsigned, to avoid integer comparison confusion. Without
667 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
668 "cannot optimize loop, the loop counter may overflow", a symptom
669 of the confusion.
f00bbb22 670 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
671 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
672
6468f31c
LMI
6732011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
674
49080b10
LMI
675 * search.c (Fre_search_backward): Mention `case-fold-search' in
676 all the re_search_* functions (bug#8138).
677
6468f31c
LMI
678 * keyboard.c (Fopen_dribble_file): Document when the file is
679 closed (bug#8056).
680
c965adc5
EZ
6812011-07-14 Eli Zaretskii <eliz@gnu.org>
682
df9733bf
EZ
683 * bidi.c (bidi_dump_cached_states): Fix format of displaying
684 bidi_cache_idx.
685
0bb23927
EZ
686 Support bidi reordering of display and overlay strings.
687 * xdisp.c (compute_display_string_pos)
688 (compute_display_string_end): Accept additional argument STRING.
689 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
690 (reseat_to_string): Initialize bidi_it->string.s and
691 bidi_it->string.schars.
692 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
693 NULL (avoids a crash in bidi_paragraph_init).
694 Initialize itb.string.lstring.
0bb23927
EZ
695 (init_iterator): Call bidi_init_it only of a valid
696 buffer position was specified. Initialize paragraph_embedding to
697 L2R.
698 (reseat_to_string): Initialize the bidi iterator.
699 (display_string): If we need to ignore text properties of
700 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
701 original value of -1 will not work with bidi.)
702 (compute_display_string_pos): First arg is now struct
703 `text_pos *'; all callers changed. Support display properties on
704 Lisp strings.
705 (compute_display_string_end): Support display properties on Lisp
706 strings.
707 (init_iterator, reseat_1, reseat_to_string): Initialize the
708 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
709 when iterating on a string not from display properties).
640c8776
SM
710 (compute_display_string_pos, compute_display_string_end):
711 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
712 arrow keys.
713 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
714 base_level_stop; instead, set base_level_stop to BEGV.
715 Fixes crashes in vertical-motion.
0bb23927
EZ
716 (next_element_from_buffer): Improve commentary for when
717 the iterator is before prev_stop.
718 (init_iterator): Initialize bidi_p from the default value of
719 bidi-display-reordering, not from buffer-local value. Use the
720 buffer-local value only if initializing for buffer iteration.
721 (handle_invisible_prop): Support invisible properties on strings
722 that are being bidi-reordered.
723 (set_iterator_to_next): Support bidi reordering of C strings and
724 Lisp strings.
725 (next_element_from_string): Support bidi reordering of Lisp
726 strings.
727 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
728 (display_string): Support display of R2L glyph rows.
729 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
730 (init_iterator): Don't initialize it->bidi_p for strings
731 here.
732 (reseat_to_string): Initialize it->bidi_p for strings here.
733 (next_element_from_string, next_element_from_c_string)
734 (next_element_from_buffer): Add xassert's for correspondence
735 between IT's object being iterated and it->bidi_it.string
736 structure.
737 (face_before_or_after_it_pos): Support bidi iteration.
738 (next_element_from_c_string): Handle the case of the first string
739 character that is not the first one in the visual order.
740 (get_visually_first_element): New function, refactored from common
741 parts of next_element_from_buffer, next_element_from_string, and
742 next_element_from_c_string.
743 (tool_bar_lines_needed, redisplay_tool_bar)
744 (display_menu_bar): Force left-to-right direction. Add a FIXME
745 comment for making that be controlled by a user option.
746 (push_it, pop_it): Save and restore the state of the
747 bidi iterator. Save and restore the bidi_p flag.
748 (pop_it): Iterate out of display property for string iteration as
749 well.
750 (iterate_out_of_display_property): Support iteration over strings.
751 (handle_single_display_spec): Set up it->bidi_it for iteration
752 over a display string, and call bidi_init_it.
753 (handle_single_display_spec, next_overlay_string)
754 (get_overlay_strings_1, push_display_prop): Set up the bidi
755 iterator for displaying display or overlay strings.
756 (forward_to_next_line_start): Don't use the shortcut if
757 bidi-iterating.
758 (back_to_previous_visible_line_start): If handle_display_prop
759 pushed the iterator stack, restore the internal state of the bidi
760 iterator by calling bidi_pop_it same number of times.
761 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
762 and we are bidi-iterating, don't decrement the iterator position;
763 instead, set the first_elt flag in the bidi iterator, to produce
764 the same effect.
765 (reseat_1): Remove redundant setting of string_from_display_prop_p.
766 (push_display_prop): xassert that we are iterating a buffer.
767 (push_it, pop_it): Save and restore paragraph_embedding member.
768 (handle_single_display_spec, next_overlay_string)
769 (get_overlay_strings_1, reseat_1, reseat_to_string)
770 (push_display_prop): Set up the `unibyte' member of bidi_it.string
771 correctly. Don't assume unibyte strings are not bidi-reordered.
772 (compute_display_string_pos)
773 (compute_display_string_end): Fix handling the case of C string.
774 (push_it, pop_it): Save and restore from_disp_prop_p.
775 (handle_single_display_spec, push_display_prop): Set the
776 from_disp_prop_p flag.
777 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
778 (pop_it): Call iterate_out_of_display_property only if we are
779 popping after iteration over a string that came from a display
780 property. Fix a typo in popping stretch info. Add an assertion
781 for verifying that the iterator position is in sync with the bidi
782 iterator.
783 (handle_single_display_spec, get_overlay_strings_1)
784 (push_display_prop): Fix initialization of paragraph direction for
785 string when that of the parent object is not yet determined.
786 (reseat_1): Call bidi_init_it to resync the bidi
787 iterator with IT's position. (Bug#7616)
788 (find_row_edges): If ROW->start.pos gives position
789 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
790 (handle_stop, back_to_previous_visible_line_start, reseat_1):
791 Reset the from_disp_prop_p flag.
792 (SAVE_IT, RESTORE_IT): New macros.
793 (pos_visible_p, face_before_or_after_it_pos)
794 (back_to_previous_visible_line_start)
795 (move_it_in_display_line_to, move_it_in_display_line)
796 (move_it_to, move_it_vertically_backward, move_it_by_lines)
797 (try_scrolling, redisplay_window, display_line): Use them when
798 saving a temporary copy of the iterator and restoring it back.
799 (back_to_previous_visible_line_start, reseat_1)
800 (init_iterator): Empty the bidi cache "stack".
801 (move_it_in_display_line_to): If iterator ended up at
802 EOL, but we never saw any buffer positions smaller than
803 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
804 motion in bidi-reordered lines.
805 (move_it_in_display_line_to): Record prev_method and prev_pos
806 immediately before the call to set_iterator_to_next. Fixes cursor
807 motion in bidi-reordered lines with stretch glyphs and strings
808 displayed in margins. (Bug#8133) (Bug#8867)
809 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
810 TO_CHARPOS.
640c8776
SM
811 (pos_visible_p): Support positions in bidi-reordered lines.
812 Save and restore bidi cache.
0bb23927
EZ
813
814 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
815 (bidi_paragraph_info): Delete unused struct.
816 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
817 (bidi_cache_start): New variable.
818 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
819 to zero.
820 (bidi_cache_fetch_state, bidi_cache_search)
821 (bidi_cache_find_level_change, bidi_cache_iterator_state)
822 (bidi_cache_find, bidi_peek_at_next_level)
823 (bidi_level_of_next_char, bidi_find_other_level_edge)
824 (bidi_move_to_visually_next): Compare cache index with
825 bidi_cache_start rather than with zero.
826 (bidi_fetch_char): Accept new argument STRING; all callers
827 changed. Support iteration over a string. Support strings with
828 display properties. Support unibyte strings. Fix the type of
829 `len' according to what STRING_CHAR_AND_LENGTH expects.
830 (bidi_paragraph_init, bidi_resolve_explicit_1)
831 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
832 (bidi_level_of_next_char, bidi_move_to_visually_next):
833 Support iteration over a string.
0bb23927
EZ
834 (bidi_set_sor_type, bidi_resolve_explicit_1)
835 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
836 can now be zero (for strings); special values 0 and -1 were
837 changed to -1 and -2, respectively.
838 (bidi_char_at_pos): New function.
839 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
840 Call it instead of FETCH_MULTIBYTE_CHAR.
841 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
842 initialized to valid values.
843 (bidi_init_it): Don't initialize charpos and bytepos with invalid
844 values.
845 (bidi_level_of_next_char): Allow the sentinel "position" to pass
846 the test for valid cached positions. Fix the logic for looking up
847 the sentinel state in the cache. GCPRO the Lisp string we are
848 iterating.
849 (bidi_push_it, bidi_pop_it): New functions.
850 (bidi_initialize): Initialize the bidi cache start stack pointer.
851 (bidi_cache_ensure_space): New function, refactored from part of
852 bidi_cache_iterator_state. Don't assume the required size is just
853 one BIDI_CACHE_CHUNK away.
854 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
855 (bidi_count_bytes, bidi_char_at_pos): New functions.
856 (bidi_cache_search): Don't assume bidi_cache_last_idx is
857 always valid if bidi_cache_idx is valid.
858 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
859 is valid if it's going to be used.
860 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
861 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
862 (bidi_cache_find_level_change, bidi_cache_ensure_space)
863 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
864 (bidi_find_other_level_edge, bidi_cache_start_stack):
865 All variables related to cache indices are now EMACS_INT.
c965adc5 866
0bb23927
EZ
867 * dispextern.h (struct bidi_string_data): New structure.
868 (struct bidi_it): New member `string'. Make flag members be 1-bit
869 fields, and put them last in the struct.
640c8776
SM
870 (compute_display_string_pos, compute_display_string_end):
871 Update prototypes.
0bb23927
EZ
872 (bidi_push_it, bidi_pop_it): Add prototypes.
873 (struct iterator_stack_entry): New members bidi_p,
874 paragraph_embedding, and from_disp_prop_p.
875 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
876 (bidi_shelve_cache, bidi_unshelve_cache):
877 Declare prototypes.
0bb23927
EZ
878
879 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
880 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
881 and vector-like objects.
882
883 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
884 cache around display iteration.
885
886 * window.c (Fwindow_end, window_scroll_pixel_based)
887 (displayed_window_lines, Frecenter): Save and restore the bidi
888 cache around display iteration.
889
3bbd2265
LMI
8902011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
891
892 * editfns.c (Fdelete_region): Clarify the use of the named
893 parameters (bug#6788).
894
adc47434
MR
8952011-07-14 Martin Rudalics <rudalics@gmx.at>
896
897 * indent.c (Fvertical_motion): Set and restore w->pointm when
898 saving and restoring the window's buffer (Bug#9006).
899
837c31f8
LMI
9002011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
901
902 * editfns.c (Fstring_to_char): Clarify just what is returned
903 (bug#6576). Text by Eli Zaretskii.
904
ac389d0c
JB
9052011-07-13 Juanma Barranquero <lekktu@gmail.com>
906
907 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
908
0be0ce47
EZ
9092011-07-13 Eli Zaretskii <eliz@gnu.org>
910
911 * buffer.c (mmap_find): Fix a typo.
912
cd18e7e3
JB
9132011-07-13 Johan Bockgård <bojohan@gnu.org>
914
915 Fix execution of x selection hooks.
916 * xselect.c (Qx_lost_selection_functions)
917 (Qx_sent_selection_functions): New vars.
918 (syms_of_xselect): DEFSYM them.
919 (x_handle_selection_request): Pass Qx_sent_selection_functions
920 rather than Vx_sent_selection_functions to Frun_hook_with_args.
921 (x_handle_selection_clear,x_clear_frame_selections):
922 Pass Qx_lost_selection_functions rather than
923 Vx_lost_selection_functions to Frun_hook_with_args.
924
47ea7f44
PE
9252011-07-13 Paul Eggert <eggert@cs.ucla.edu>
926
ac389d0c 927 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
928 The old code sometimes used this field without initializing it.
929
47ea7f44
PE
930 * alloc.c (gc_sweep): Don't read past end of array.
931 In theory, the old code could also have corrupted Emacs internals,
932 though it'd be very unlikely.
933
bc985c87
AS
9342011-07-12 Andreas Schwab <schwab@linux-m68k.org>
935
936 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 937 argument. (Bug#4026)
bc985c87 938
0cf34688
LMI
9392011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
940
b3dadd76
LMI
941 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
942 key" (bug#4257).
943
0cf34688
LMI
944 * window.c (Fset_window_start): Doc fix (bug#4199).
945 (Fset_window_hscroll): Ditto.
946
270768cd
PE
9472011-07-12 Paul Eggert <eggert@cs.ucla.edu>
948
077e3dda 949 Fix minor new problems caught by GCC 4.6.1.
270768cd 950 * term.c (init_tty): Remove unused local.
490011a6 951 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 952 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 953 not used otherwise.
270768cd 954
b1f58454
CY
9552011-07-12 Chong Yidong <cyd@stupidchicken.com>
956
957 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
958
22b9578d
LMI
9592011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
960
6e70ab07
LMI
961 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
962 are the mini-buffer and the echo area (bug#3320).
963
22b9578d
LMI
964 * term.c (init_tty): Remove support for supdup, c10 and perq
965 terminals, which are no longer supported (bug#1482).
966
8974cc9f
JB
9672011-07-10 Johan Bockgård <bojohan@gnu.org>
968
969 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
970
a560d974
JD
9712011-07-10 Jan Djärv <jan.h.d@swipnet.se>
972
973 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
974 for non-popups (Bug#3642).
975
1dae0f0a
AS
9762011-07-10 Andreas Schwab <schwab@linux-m68k.org>
977
268c2c36 978 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 979 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
980 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
981 * cm.c (losecursor): Likewise.
1dae0f0a
AS
982 * data.c (fmod): Likewise.
983 * dispnew.c (swap_glyphs_in_rows): Likewise.
984 * emacs.c (memory_warning_signal): Likewise.
985 * floatfns.c (float_error): Likewise.
986 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
987 (otf_open, font_otf_capability, generate_otf_features)
988 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
989 Likewise.
990 * image.c (pbm_read_file): Likewise.
991 * indent.c (string_display_width): Likewise.
992 * intervals.c (check_for_interval, search_for_interval)
993 (inc_interval_count, count_intervals, root_interval)
994 (adjust_intervals_for_insertion, make_new_interval): Likewise.
995 * lread.c (defalias): Likewise.
268c2c36 996 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
997 * regex.c (set_image_of_range_1, set_image_of_range)
998 (regex_grow_registers): Likewise.
999 * sysdep.c (strerror): Likewise.
1000 * termcap.c (valid_filename_p, tprint, main): Likewise.
1001 * tparam.c (main): Likewise.
1002 * unexhp9k800.c (run_time_remap, save_data_space)
1003 (update_file_ptrs, read_header, write_header, calculate_checksum)
1004 (copy_file, copy_rest, display_header): Likewise.
1005 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1006 Likewise.
1007 * xdisp.c (check_it): Likewise.
1008 * xfaces.c (register_color, unregister_color, unregister_colors):
1009 Likewise.
1010 * xfns.c (print_fontset_result): Likewise.
1011 * xrdb.c (member, fatal, main): Likewise.
1012
99033785
PE
10132011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1014
1015 Fix minor problems found by static checking (Bug#9031).
1016 * chartab.c (char_table_set_range, map_sub_char_table):
1017 Remove unused locals.
1018 (uniprop_table): Now static.
1019 * composite.c (_work_char): Remove unused static var.
1020
9cb2ac56
JB
10212011-07-09 Juanma Barranquero <lekktu@gmail.com>
1022
1023 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1024
f25661f0
JD
10252011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1026
1027 * gtkutil.c (qttip_cb): Remove code without function.
1028
8278c4fe
EZ
10292011-07-09 Eli Zaretskii <eliz@gnu.org>
1030
1031 * w32.c (pthread_sigmask): New stub.
1032
1692ae2d 10332011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1034
8a6ebd58 1035 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1036 sigprocmask is portable only for single-threaded applications, and
1037 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1038 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1039 (LIBES): Use it.
1040 * callproc.c (Fcall_process):
1041 * process.c (create_process):
1042 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1043 Use pthread_sigmask, not sigprocmask.
123403e4 1044
1b854618
JD
10452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1046
1047 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1048 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1049 wrong (Bug#8591).
1050
3fe4b549
JD
10512011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1052
0ce7e563
JD
1053 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1054 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1055 (xg_hide_tooltip): Fix comment.
1056
3fe4b549
JD
1057 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1058 in registerServicesMenuSendTypes.
1059 (validRequestorForSendType): Don't check ns_return_types.
1060
1061 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1062 ns_return_type.
1063
5df75e47
JR
10642011-07-08 Jason Rumney <jasonr@gnu.org>
1065
1066 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1067 frame struct members of non-existent frames (Bug#6284).
1068
699c10bd
JD
10692011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1070
4393663b
JD
1071 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1072 variable firstTime not needed on OSX >= 10.6.
1073 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1074 >= 10.5. Use setKnobProportion, setDoubleValue.
1075
1076 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1077 (MAC_OS_X_VERSION_10_5): Define if not defined.
1078 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1079 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1080 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1081
1082 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1083 cString and lossyCString on OSX >= 10.4
1084
1085 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1086 sizeToFit on OSX >= 10.2.
1087
1088 * nsimage.m (allocInitFromFile): Don't use deprecated method
1089 bestRepresentationForDevice on OSX >= 10.6.
1090
1091 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1092 to avoid warning.
1093
1094 * emacs.c: Declare unexec_init_emacs_zone.
1095
a63e0781
JD
1096 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1097
699c10bd
JD
1098 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1099
1100 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1101 on svcsMenu (Bug#8842).
1102
1103 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1104 ns_return_types.
1105 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1106
1107 * nsterm.m (QUTF8_STRING): Declare.
1108 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1109 (validRequestorForSendType): Return type is (id).
1110 Change indexOfObjectIdenticalTo to indexOfObject.
1111 Check if we have local selection before returning self (Bug#8842).
1112 (writeSelectionToPasteboard): Put local selection into paste board
1113 if we have a local selection (Bug#8842).
1114 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1115
1116 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1117 (ns_get_local_selection): Declare.
1118
54e10184
LMI
11192011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1120
9888ff71
LMI
1121 * keymap.c (describe_map_tree): Don't insert a double newline at
1122 the end of the buffer (bug#1169) and return whether we inserted
1123 something.
1124
54e10184
LMI
1125 * callint.c (Fcall_interactively): Change "reading args" to
1126 "providing args" to try to clarify what it does (bug#1010).
1127
15fa4783
KH
11282011-07-07 Kenichi Handa <handa@m17n.org>
1129
1130 * composite.c (composition_compute_stop_pos): Ignore a static
1131 composition starting before CHARPOS (Bug#8915).
1132
1133 * xdisp.c (handle_composition_prop): Likewise.
1134
a8815b00
EZ
11352011-07-07 Eli Zaretskii <eliz@gnu.org>
1136
1137 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1138 (Bug#9015)
1139
ef7b981d 11402011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1141
1142 * character.h (unicode_category_t): New enum type.
1143
1144 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1145 (Qchar_code_property_table): New variable.
1146 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1147 (UNIPROP_COMPRESSED_FORM_P): New macros.
1148 (char_table_ascii): Uncompress the compressed values.
1149 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1150 Uncompress the compressed values.
ac389d0c 1151 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1152 (char_table_ref_and_range): Uncompress the compressed values.
1153 (sub_char_table_set): New arg is_uniprop. Callers changed.
1154 Uncompress the compressed values.
1155 (sub_char_table_set_range): Args changed. Callers changed.
1156 (char_table_set_range): Adjuted for the above change.
1157 (map_sub_char_table): Delete args default_val and parent. Add arg
1158 top. Give decoded values to a Lisp function.
640c8776 1159 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1160 values to a Lisp function. Gcpro more variables.
1161 (uniprop_table_uncompress)
1162 (uniprop_decode_value_run_length): New functions.
1163 (uniprop_decoder, uniprop_decoder_count): New variables.
1164 (uniprop_get_decoder, uniprop_encode_value_character)
1165 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1166 New functions.
1167 (uniprop_encoder, uniprop_encoder_count): New variables.
1168 (uniprop_get_encoder, uniprop_table)
1169 (Funicode_property_table_internal, Fget_unicode_property_internal)
1170 (Fput_unicode_property_internal): New functions.
1171 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1172 Sunicode_property_table_internal, Sget_unicode_property_internal,
1173 and Sput_unicode_property_internal. Defvar_lisp
1174 char-code-property-alist.
1175
640c8776 1176 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1177 Vunicode_category_table.
1178
640c8776 1179 * font.c (font_range): Adjust for the change of
c805dec0
KH
1180 Vunicode_category_table.
1181
76b397fb
DN
11822011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1183
1184 * m/iris4d.h: Remove file, move contents ...
1185 * s/irix6-5.h: ... here.
1186
22b4128e
PE
11872011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1188
1189 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1190 * alloc.c (mark_buffer):
1191 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1192 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1193 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1194 This isn't true in general, and it's particularly not true
1195 if Emacs is configured with --with-wide-int.
1196 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1197 New macros, used in the buffer.c change.
1198
869795d6
JD
11992011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1200
1201 * xsettings.c: Use both GConf and GSettings if both are available.
1202 (store_config_changed_event): Add comment.
1203 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1204 (store_tool_bar_style_changed): New functions.
1205 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1206 (struct xsettings): Move font inside HAVE_XFT.
1207 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1208 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1209 Move inside HAVE_XFT.
640c8776 1210 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1211 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1212 also.
1213 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1214 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1215 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1216 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1217 (parse_settings): Move check for font inside HAVE_XFT.
1218 (read_settings, apply_xft_settings): Add comment.
1219 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1220 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1221 call store_font_name_changed.
1222 (xft_settings_event): Add comment.
1223 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1224 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1225 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1226 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1227 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1228 (xsettings_get_system_font, xsettings_get_system_normal_font):
1229 Add comment.
869795d6 1230
d8ed26bd
PE
12312011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1232
1233 Random fixes. E.g., (random) never returned negative values.
1234 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1235 subseconds part to the entropy, as that's a bit more random.
1236 Prefer signed to unsigned, since the signedness doesn't matter and
1237 in general we prefer signed. When given a limit, use a
1238 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1239 latter isn't right if USE_2_TAGS_FOR_INTS.
1240 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1241 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1242
cabf1cac
SM
12432011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1244
1245 * textprop.c (text_property_stickiness):
1246 Obey Vtext_property_default_nonsticky.
1247 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1248 * w32fns.c (syms_of_w32fns):
1249 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1250
6e9b2be9
PE
12512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1252
1253 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1254 This is more efficient than Ffile_directory_p and avoids a minor race.
1255
90186c68
LMI
12562011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1257
7c301272
LMI
1258 * buffer.c (Foverlay_put): Say what the return value is
1259 (bug#7835).
1260
c4f2d8d4
LMI
1261 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1262 is a directory before asking whether to use the file name
1263 (bug#7564).
ad637907
LMI
1264 (barf_or_query_if_file_exists): Make the "File is a directory"
1265 error be more correct.
c4f2d8d4 1266
90186c68
LMI
1267 * fns.c (Frequire): Remove the mention of the .gz files, since
1268 that's installation-specific, but keep the mention of
1269 `get-load-suffixes'.
1270
da64016e
PE
12712011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1272
1273 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1274 Report string overflow if the output is too long.
1275
7d47b580
JB
12762011-07-04 Juanma Barranquero <lekktu@gmail.com>
1277
a555cb87
JB
1278 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1279 (syms_of_gnutls): Remove duplicate DEFSYM for
1280 Qgnutls_bootprop_verify_hostname_error, an error for
1281 Qgnutls_bootprop_verify_error (which is no longer used).
1282
7d47b580
JB
1283 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1284 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1285 Also (re)move comments that are misplaced or no longer relevant.
1286
1e49bfab
LMI
12872011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1288
1289 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1290
1485f4c0
CY
12912011-07-03 Chong Yidong <cyd@stupidchicken.com>
1292
1293 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1294 and background color parameters if they have been changed.
1295
a9ab721e
LMI
12962011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1297
1298 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1299
cf7cff57
PE
13002011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1301
2e13213d
PE
1302 * xsettings.c (SYSTEM_FONT): Define only when used.
1303 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1304
cf7cff57
PE
1305 * keymap.c (access_keymap_1): Now static.
1306
7a8e04f7
CY
13072011-07-02 Chong Yidong <cyd@stupidchicken.com>
1308
1309 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1310 leave any prefix arg for the up event (Bug#1586).
1311
61352f62
LMI
13122011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1313
69bb1ef7
LMI
1314 * lread.c (syms_of_lread): Mention single symbols defined by
1315 `defvar' or `defconst' (bug#7154).
1316
61352f62 1317 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1318 (Frequire): Mention get-load-suffixes.
61352f62 1319
28545e04
MR
13202011-07-02 Martin Rudalics <rudalics@gmx.at>
1321
1322 * window.h (window): Remove clone_number slot.
1323 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1324 Remove.
1325 (make_parent_window, make_window, saved_window)
1326 (Fset_window_configuration, save_window_save): Don't deal with
1327 clone numbers.
1328 * buffer.c (Qclone_number): Remove declaration.
1329 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1330
3349e122
SM
13312011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1332
1333 Add multiple inheritance to keymaps.
1334 * keymap.c (Fmake_composed_keymap): New function.
1335 (Fset_keymap_parent): Simplify.
1336 (fix_submap_inheritance): Remove.
1337 (access_keymap_1): New function extracted from access_keymap to handle
1338 embedded parents and handle lists of maps.
1339 (access_keymap): Use it.
1340 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1341 (Fcopy_keymap): Handle embedded parents.
1342 (Fcommand_remapping, define_as_prefix): Simplify.
1343 (Fkey_binding): Simplify.
1344 (syms_of_keymap): Move minibuffer-local-completion-map,
1345 minibuffer-local-filename-completion-map,
1346 minibuffer-local-must-match-map, and
1347 minibuffer-local-filename-must-match-map to Elisp.
1348 (syms_of_keymap): Defsubr make-composed-keymap.
1349 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1350 (parse_menu_item): Trivial simplification.
1351
3279eb87
GM
13522011-07-01 Glenn Morris <rgm@gnu.org>
1353
1354 * Makefile.in (SETTINGS_LIBS): Fix typo.
1355
4550efdf
KI
13562011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1357
1358 * coding.c (Fencode_coding_string): Record the last coding system
1359 used, as the function doc string says (bug#8738).
1360
0949d2b6
JD
13612011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1362
1363 * xsettings.c (store_monospaced_changed): Take new font as arg and
1364 check for change against current_mono_font.
1365 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1366 (emacs_settings_constructor, emacs_settings_get_property)
1367 (emacs_settings_set_property, emacs_settings_class_init)
1368 (emacs_settings_init, gsettings_obj): Remove.
1369 (something_changedCB): New function for HAVE_GSETTINGS.
1370 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1371 with value as argument.
1372 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1373 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1374 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1375 "changed".
1376
1377 * xgselect.c: Add defined (HAVE_GSETTINGS).
1378 (xgselect_initialize): Ditto.
1379
1380 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1381 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1382 xg_select.
1383
bbc6b304
PE
13842011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1385
1386 * eval.c (struct backtrace): Simplify and port the data structure.
1387 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1388 signed bit field, as this assumption is not portable and it makes
1389 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1390 "char debug_on_exit : 1" as this is not portable either; instead,
1391 use the portable "unsigned int debug_on_exit : 1". Remove unused
1392 member evalargs. Remove obsolete comments about cc bombing out.
1393
9851bfc5
JD
13942011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1395
51bb811f 1396 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1397 Let HAVE_GSETTINGS override HAVE_GCONF.
1398 (store_monospaced_changed): New function.
1399 (EMACS_SETTINGS): A new type derived from GObject to handle
1400 GSettings notifications.
1401 (emacs_settings_constructor, emacs_settings_get_property)
1402 (emacs_settings_set_property, emacs_settings_class_init):
1403 New functions.
1404 (gsettings_client, gsettings_obj): New variables.
1405 (GSETTINGS_SCHEMA): New define.
1406 (something_changedCB): Call store_monospaced_changed.
1407 (init_gsettings): New function.
1408 (xsettings_initialize): Call init_gsettings.
1409 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1410 to NULL.
1411
640c8776 1412 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1413 GCONF_CFLAGS/LIBS.
1414
5386012d
MR
14152011-06-29 Martin Rudalics <rudalics@gmx.at>
1416
1417 * window.c (resize_root_window, grow_mini_window)
1418 (shrink_mini_window): Rename Qresize_root_window to
1419 Qwindow_resize_root_window and Qresize_root_window_vertically to
1420 Qwindow_resize_root_window_vertically.
1421
f13e0b08
PE
14222011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1423
1424 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1425
94515237
JB
14262011-06-27 Juanma Barranquero <lekktu@gmail.com>
1427
1428 * makefile.w32-in: Redesign dependencies so they reflect more
1429 clearly which files are directly included by each source file,
1430 and not through other includes.
1431
e43b6e43
MR
14322011-06-27 Martin Rudalics <rudalics@gmx.at>
1433
1434 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1435 (sort_overlays, overlay_strings): When an overlay's clone number
1436 matches the window's clone number process the overlay even if
1437 the overlay's window property doesn't match the current window.
1438
d68443dc
MR
1439 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1440 (Fwindow_hchild): Rename to Fwindow_left_child.
1441 (Fwindow_next): Rename to Fwindow_next_sibling.
1442 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1443 (resize_window_check): Rename to window_resize_check.
1444 (resize_window_apply): Rename to window_resize_apply.
1445 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1446 (Fdelete_other_windows_internal, resize_frame_windows)
1447 (Fsplit_window_internal, Fdelete_window_internal)
1448 (grow_mini_window, shrink_mini_window)
1449 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1450
c7e73be5
JD
14512011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1452
1453 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1454 (emacs_fixed_set_min_size): Remove.
1455 (emacs_fixed_new): Take frame as argument.
1456
1457 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1458 (_EmacsFixedPrivate): Remove minwidth/height.
1459 Add struct frame *f.
1460 (emacs_fixed_init): Initialize priv->f.
1461 (get_parent_class, emacs_fixed_set_min_size): Remove.
1462 (emacs_fixed_new): Set priv->f to argument.
1463 (emacs_fixed_get_preferred_width)
1464 (emacs_fixed_get_preferred_height): Use min_width/height from
1465 frames size_hint to set minimum and natural (Bug#8919).
1466 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1467 and use min_width/height from frames size_hint to set
1468 min_width/height (Bug#8919).
1469
1470 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1471 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1472 Fix indentation.
c7e73be5 1473
cf99dcf8
EZ
14742011-06-26 Eli Zaretskii <eliz@gnu.org>
1475
1476 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1477 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1478 called at ZV.
1479
029529ac
CY
14802011-06-26 Chong Yidong <cyd@stupidchicken.com>
1481
1482 * process.c (wait_reading_process_output): Bypass select if
1483 waiting for a cell while ignoring keyboard input, and input is
1484 pending. Suggested by Jan Djärv (Bug#8869).
1485
7a7ef429
PE
14862011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1487
1488 Use gnulib's dup2 module instead of rolling our own.
1489 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1490
11fdef7d 14912011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1492
1493 * dispnew.c (scrolling_window): Before scrolling, turn off a
1494 mouse-highlight in the window being scrolled.
1495
cd3520a4
JB
14962011-06-24 Juanma Barranquero <lekktu@gmail.com>
1497
1498 Move DEFSYM to lisp.h and use everywhere.
1499
1500 * character.h (DEFSYM): Move declaration...
1501 * lisp.h (DEFSYM): ...here.
1502
1503 * gnutls.c:
1504 * minibuf.c:
1505 * w32menu.c:
1506 * w32proc.c:
1507 * w32select.c: Don't include character.h.
1508
1509 * alloc.c (syms_of_alloc):
1510 * buffer.c (syms_of_buffer):
1511 * bytecode.c (syms_of_bytecode):
1512 * callint.c (syms_of_callint):
1513 * casefiddle.c (syms_of_casefiddle):
1514 * casetab.c (init_casetab_once):
1515 * category.c (init_category_once, syms_of_category):
1516 * ccl.c (syms_of_ccl):
1517 * cmds.c (syms_of_cmds):
1518 * composite.c (syms_of_composite):
1519 * dbusbind.c (syms_of_dbusbind):
1520 * dired.c (syms_of_dired):
1521 * dispnew.c (syms_of_display):
1522 * doc.c (syms_of_doc):
1523 * editfns.c (syms_of_editfns):
1524 * emacs.c (syms_of_emacs):
1525 * eval.c (syms_of_eval):
1526 * fileio.c (syms_of_fileio):
1527 * fns.c (syms_of_fns):
1528 * frame.c (syms_of_frame):
1529 * fringe.c (syms_of_fringe):
1530 * insdel.c (syms_of_insdel):
1531 * keymap.c (syms_of_keymap):
1532 * lread.c (init_obarray, syms_of_lread):
1533 * macros.c (syms_of_macros):
1534 * msdos.c (syms_of_msdos):
1535 * print.c (syms_of_print):
1536 * process.c (syms_of_process):
1537 * search.c (syms_of_search):
1538 * sound.c (syms_of_sound):
1539 * syntax.c (init_syntax_once, syms_of_syntax):
1540 * terminal.c (syms_of_terminal):
1541 * textprop.c (syms_of_textprop):
1542 * undo.c (syms_of_undo):
1543 * w32.c (globals_of_w32):
1544 * window.c (syms_of_window):
1545 * xdisp.c (syms_of_xdisp):
1546 * xfaces.c (syms_of_xfaces):
1547 * xfns.c (syms_of_xfns):
1548 * xmenu.c (syms_of_xmenu):
1549 * xsettings.c (syms_of_xsettings):
1550 * xterm.c (syms_of_xterm): Use DEFSYM.
1551
4228cf16
TZ
15522011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1553
cd3520a4 1554 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1555
7fcccf1e
PE
15562011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1557
7efb4e0e
PE
1558 Integer and buffer overflow fixes (Bug#8873).
1559
ff5844ad
PE
1560 * print.c (printchar, strout): Check for string overflow.
1561 (PRINTPREPARE, printchar, strout):
1562 Don't set size unless allocation succeeds.
1563
90532f02
PE
1564 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1565 for sizes. Check for string overflow more accurately.
1566 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1567
6d84508d
PE
1568 * macros.c: Integer and buffer overflow fixes.
1569 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1570 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1571 Use ptrdiff_t, not int, for sizes.
1572 Don't increment bufsize until after realloc succeeds.
1573 Check for size-calculation overflow.
1574 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1575
437b2cb4
PE
1576 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1577
8b9ac8b4
PE
1578 * lread.c: Integer overflow fixes.
1579 (read_integer): Radix is now EMACS_INT, not int,
1580 to improve quality of diagnostics for out-of-range radices.
1581 Calculate buffer size correctly for out-of-range radices.
1582 (read1): Check for integer overflow in radices, and in
1583 read-circle numbers.
82cb60d3
PE
1584 (read_escape): Avoid int overflow.
1585 (Fload, openp, read_buffer_size, read1)
1586 (substitute_object_recurse, read_vector, read_list, map_obarray):
1587 Use ptrdiff_t, not int, for sizes.
1588 (read1): Use EMACS_INT, not int, for sizes.
20270765 1589 Check for size overflow.
8b9ac8b4 1590
7fcccf1e
PE
1591 * image.c (cache_image): Check for size arithmetic overflow.
1592
bfbbd7e7
PE
1593 * lread.c: Integer overflow issues.
1594 (saved_doc_string_size, saved_doc_string_length)
1595 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1596 Now ptrdiff_t, not int.
1597 (read1): Don't assume doc string length fits in int. Check for
1598 out-of-range doc string lengths.
1599 (read_list): Don't assume file position fits in int.
39019e54 1600 (read_escape): Check for hex character overflow.
bfbbd7e7 1601
4e323265
LL
16022011-06-22 Leo Liu <sdl.web@gmail.com>
1603
1604 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1605 Move to minibuffer.el.
1606
85fece3e
PE
16072011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1608
20b84ce9 1609 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1610 The following patches are for when GLYPH_DEBUG && !XASSERT.
1611 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1612 * dispnew.c (flush_stdout):
1613 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1614 Mark as externally visible.
1615 * dispnew.c (check_window_matrix_pointers): Now static.
1616 * dispnew.c (window_to_frame_vpos):
1617 * xfns.c (unwind_create_frame):
1618 * xterm.c (x_check_font): Remove unused local.
1619 * scroll.c (CHECK_BOUNDS):
1620 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1621 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1622 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1623 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1624 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1625 Now static.
1626 (debug_method_add): Use va_list and vsprintf rather than relying
1627 on undefined behavior with wrong number of arguments.
1628 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1629 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1630 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1631 since we're not interested in debugging glyphs with old libraries.
1632 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1633 GCC 4.6.0's static checking.
1634
0766b489
PE
16352011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1636
31fd4b32
PE
1637 Integer overflow and signedness fixes (Bug#8873).
1638 A few related buffer overrun fixes, too.
1639
b79e8648
PE
1640 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1641
0766b489
PE
1642 * dispextern.h (struct face.stipple):
1643 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1644 (x_bitmap_mask, x_allocate_bitmap_record)
1645 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1646 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1647 (x_create_bitmap_from_xpm_data):
1648 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1649 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1650 (.bitmaps_last):
1651 * xfaces.c (load_pixmap):
1652 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1653 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1654 (.bitmaps_last, struct x_output.icon_bitmap):
1655 Use ptrdiff_t, not int, for bitmap indexes.
1656 (x_allocate_bitmap_record): Check for size overflow.
1657 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1658
b081724f
PE
1659 Use ptrdiff_t, not int, for overlay counts.
1660 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1661 * editfns.c (overlays_around, get_pos_property):
1662 * textprop.c (get_char_property_and_overlay):
1663 * xdisp.c (next_overlay_change, note_mouse_highlight):
1664 * xfaces.c (face_at_buffer_position):
21514da7
PE
1665 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1666 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1667 (Fnext_overlay_change, Fprevious_overlay_change)
1668 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1669 Use ptrdiff_t, not int, for sizes.
21514da7 1670 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1671
3de73e5e
PE
1672 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1673
2606c57b
PE
1674 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1675 (x_session_initialize): Do not assume string length fits in int.
1676
aaafe47a
PE
1677 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1678 This is unlikely, but can occur if DPI is outlandish.
1679
2674ddc8 1680 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1681 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1682
28154962
PE
1683 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1684 * xrdb.c (magic_file_p, search_magic_path):
1685 Omit last arg SUFFIX; it was always 0. All callers changed.
1686 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1687
7de51af5
PE
1688 * xfont.c (xfont_match): Avoid need for strlen.
1689
25ed6cc3
PE
1690 * xfns.c: Don't assume strlen fits in int.
1691 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1692
4eab31dd
PE
1693 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1694 not unsigned long, as we prefer signed integers. All callers changed.
1695 Detect integer overflow in repeat count.
1696 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1697 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1698
171e2a58
PE
1699 * termcap.c: Don't assume sizes fit in int and never overflow.
1700 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1701 (gobble_line): Check for size-calculation overflow.
1702
ad39faca 1703 * minibuf.c (Fread_buffer):
6e5bb2dc 1704 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1705 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1706 Don't assume string length fits in int.
1707
52c61c22 1708 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1709 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1710
b5b8c9e5
PE
1711 * font.c: Don't assume string length fits in int.
1712 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1713 Use ptrdiff_t, not int.
ccd6111c
PE
1714 (font_intern_prop): Don't assume string length fits in int.
1715 Don't assume integer property fits in fixnum.
1716 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1717
882f0d81 1718 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1719 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1720 Reformulate so as not to need the command string.
1721 Invoke gzip -cd rather than gunzip, as it's more portable.
1722 (lock_info_type, lock_file_1, lock_file):
1723 Don't assume pid_t and time_t fit in unsigned long.
1724 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1725 (current_lock_owner): Prefer signed type for sizes.
1726 Use memcpy, not strncpy, where memcpy is what is really wanted.
1727 Don't assume (via atoi) that time_t and pid_t fit in int.
1728 Check for time_t and/or pid_t out of range, e.g., via a network share.
1729 Don't alloca where an auto var works fine.
1730
93f4cf88
PE
1731 * fileio.c: Fix some integer overflow issues.
1732 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1733 Don't assume string length fits in int.
1734 (directory_file_name): Don't assume string length fits in long.
1735 (make_temp_name): Don't assume pid fits in int, or that its print
1736 length is less than 20.
1737
f3e92b69
PE
1738 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1739
1bfdaf10
PE
1740 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1741
35016e9a
PE
1742 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1743
3d1e65a1
PE
1744 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1745 We prefer signed integers, even for size calculations.
1746
0b963a93
PE
1747 * emacs.c: Don't assume string length fits in 'int'.
1748 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1749 (main): Don't invoke strlen when not needed.
1750
573f4b54
PE
1751 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1752 (XD_DEBUG_MESSAGE): Don't waste a byte.
1753
989f33ba
PE
1754 * callproc.c (getenv_internal_1, getenv_internal)
1755 (Fgetenv_internal):
965d34eb
PE
1756 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1757
e4d29b33
PE
1758 * lread.c (invalid_syntax): Omit length argument.
1759 All uses changed. This doesn't fix a bug, but it simplifies the
1760 code away from its former Hollerith-constant appearance, and it's
1761 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1762 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1763
eb49b136
PE
1764 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1765 This didn't break anything, but it didn't help either.
1766 It's confusing to put a bogus integer in a place where the actual
1767 value does not matter.
9f62aeb1 1768 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1769 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1770
15375a22
PE
1771 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1772 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1773 implementation.
b61cc01c
PE
1774 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1775 We prefer signed types, and the value cannot exceed the EMACS_INT
1776 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1777 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1778 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1779 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1780
53b2623d
PE
1781 * indent.c (sane_tab_width): New function.
1782 (current_column, scan_for_column, Findent_to, position_indentation)
1783 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1784 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1785
51cab52b 1786 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1787
f2ed8a70
PE
1788 * lisp.h (lint_assume): New macro.
1789 * composite.c (composition_gstring_put_cache):
1790 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1791
abe80cc6
PE
1792 * editfns.c, insdel.c:
1793 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1794
b02c740e
PE
1795 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1796
ebc96716
PE
1797 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1798
b4e50fa0 1799 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1800 Use much-faster test for byte-length change.
311d5d7c 1801 Don't assume string byte-length fits in 'int'.
a4cf38e4 1802 Check that character arg fits in 'int'.
85461888 1803 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1804
c0c1ee9f
PE
1805 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1806
a498d7f4
PE
1807 * fns.c (concat): Catch string overflow earlier.
1808 Do not rely on integer wraparound.
1809
51cab52b
PE
1810 * dispextern.h (struct it.overlay_strings_charpos)
1811 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1812 * xdisp.c (forward_to_next_line_start)
1813 (back_to_previous_visible_line_start)
1814 (reseat_at_next_visible_line_start, next_element_from_buffer):
1815 Don't arbitrarily truncate the value of 'selective' to int.
1816
76031fad
PE
1817 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1818
5eb55db9
PE
1819 * composite.c: Don't truncate sizes to 'int'.
1820 (composition_gstring_p, composition_reseat_it)
1821 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1822 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1823 not EMACS_UINT, for indexes.
5eb55db9 1824
0703a717
PE
1825 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1826
d6202519
PE
1827 * buffer.c: Include <verify.h>.
1828 (struct sortvec.priority, struct sortstr.priority):
8961a454 1829 Now EMACS_INT, not int.
c20998a7 1830 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1831 (struct sortstr.size, record_overlay_string)
1832 (struct sortstrlist.size, struct sortlist.used):
1833 Don't truncate size to int.
1834 (record_overlay_string): Check for size-calculation overflow.
d6202519 1835 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1836
d5a19415
JM
18372011-06-22 Jim Meyering <meyering@redhat.com>
1838
029529ac 1839 Don't leak an XBM-image-sized buffer
d5a19415
JM
1840 * image.c (xbm_load): Free the image buffer after using it.
1841
a9041e6c
PE
18422011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1843
1844 Port to Sun C.
1845 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1846 that Sun C diagnosed.
1847 * fns.c (secure_hash): Fix pointer signedness issue.
1848 * intervals.c (static_offset_intervals): New function.
1849 (offset_intervals): Use it.
1850
7f3f739f
LL
18512011-06-21 Leo Liu <sdl.web@gmail.com>
1852
1853 * deps.mk (fns.o):
1854 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1855 sha512.h.
1856
1857 * fns.c (secure_hash): Rename from crypto_hash_function and change
1858 the first arg to accept symbols.
5b66d427 1859 (Fsecure_hash): New primitive.
7f3f739f
LL
1860 (syms_of_fns): New symbols.
1861
76147d94
DD
18622011-06-20 Deniz Dogan <deniz@dogan.se>
1863
1864 * process.c (Fset_process_buffer): Clarify return value in
1865 docstring.
1866
7d7d0045
CY
18672011-06-18 Chong Yidong <cyd@stupidchicken.com>
1868
1869 * dispnew.c (add_window_display_history): Use BVAR.
1870
1871 * xdisp.c (debug_method_add): Use BVAR.
1872 (check_window_end, dump_glyph_matrix, dump_glyph)
1873 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1874
1875 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1876 Likewise.
1877
1878 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1879 check till after the cache is created in init_frame_faces.
1880
ff2bc410
SM
18812011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1882
1883 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1884
28177add
PE
18852011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1886
dd3482fe
PE
1887 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1888 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1889 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1890
393d71f3 1891 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1892 * fileio.c (Finsert_file_contents):
1893 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1894 Remove the old (too-loose) buffer overflow checks.
1895 They weren't needed, since make_gap checks for buffer overflow.
1896 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1897 The old code merely checked for Emacs fixnum overflow, and relied
1898 on undefined (wraparound) behavior. The new code avoids undefined
1899 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1900
2e6813b0 1901 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1902 Tune. Don't use wider integers than needed. Don't use alloca.
1903 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1904
599a9e4f
PE
1905 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1906
99561444
PE
1907 * insdel.c, lisp.h (buffer_overflow): New function.
1908 (insert_from_buffer_1, replace_range, replace_range_2):
1909 * insdel.c (make_gap_larger):
1910 * editfns.c (Finsert_char):
1911 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1912
28177add
PE
1913 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1914
e69dafad
PE
19152011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1916
a7af7fde 1917 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1918
b1c46f02
PE
1919 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1920 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1921
e69dafad
PE
1922 * fileio.c: Don't assume EMACS_INT fits in off_t.
1923 (emacs_lseek): New static function.
1924 (Finsert_file_contents, Fwrite_region): Use it.
1925 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1926
566684ea
PE
1927 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1928
e6966cd6
PE
1929 * fns.c: Don't overflow int when computing a list length.
1930 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1931 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1932 truncation on 64-bit hosts. Check for QUIT every
1933 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1934 faster and is responsive enough.
1935 (Flength): Report an error instead of overflowing an integer.
1936 (Fsafe_length): Return a float if the value is not representable
1937 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1938 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1939 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1940
dd0b0efb
PE
1941 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1942 (header_size, word_size): New constants.
1943 (allocate_vectorlike): Don't check size overflow here.
1944 (allocate_vector): Check it here instead, since this is the only
1945 caller of allocate_vectorlike that could cause overflow.
1946 Check that the new vector's length is representable as a fixnum.
1947
86fe5cfe
PE
1948 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1949 The previous code was bogus. For example, next_almost_prime (32)
1950 returned 39, which is undesirable as it is a multiple of 3; and
1951 next_almost_prime (24) returned 25, which is a multiple of 5 so
1952 why was the code bothering to check for multiples of 7?
1953
80e88859
PE
1954 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1955
4a2f0ad6
PE
1956 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1957
f66c7cf8
PE
1958 Variadic C functions now count arguments with ptrdiff_t.
1959 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1960 Back then I didn't know that the Emacs coding style prefers signed int.
1961 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1962 were being counted with int, which may truncate counts on 64-bit
1963 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1964 * lisp.h (struct Lisp_Subr.function.aMANY)
1965 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1966 Arg counts are now ptrdiff_t, not size_t.
1967 All variadic functions and their callers changed accordingly.
1968 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1969 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1970 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1971 * callint.c (Fcall_interactively): Check arg count for overflow,
1972 to avoid potential buffer overrun. Use signed char, not 'int',
1973 for 'varies' array, so that we needn't bother to check its size
1974 calculation for overflow.
1975 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1976 * eval.c (apply_lambda):
1977 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1978 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1979 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1980
a1759b76
PE
1981 * callint.c (Fcall_interactively): Don't use index var as event count.
1982
d96be9fc
PE
1983 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1984 * mem-limits.h (SIZE): Remove; no longer used.
1985
a690a978 1986 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1987
578c21e6
PE
1988 Remove unnecessary casts.
1989 * xterm.c (x_term_init):
1990 * xfns.c (x_set_border_pixel):
1991 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1992 These aren't needed now that we assume ANSI C.
1993
96f53c6c
PE
1994 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1995 It's more likely to cause problems (due to unsigned overflow)
1996 than to cure them.
1997
83c77d31
PE
1998 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1999
ee2079f1
PE
2000 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2001
6da65536
PE
2002 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2003
7147c4a4
PE
2004 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2005
193e32d9
PE
2006 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2007
e5533da6
PE
2008 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2009
9910e595
PE
2010 GLYPH_CODE_FACE returns EMACS_INT, not int.
2011 * dispextern.h (merge_faces):
2012 * xfaces.c (merge_faces):
01103c44
PE
2013 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2014 Don't assume EMACS_INT fits in int.
9910e595 2015
2638320e
PE
2016 * character.h (CHAR_VALID_P): Remove unused parameter.
2017 * fontset.c, lisp.h, xdisp.c: All uses changed.
2018
045eb8d9
PE
2019 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2020
c1f134b5
PE
2021 * fns.c (concat): Minor tuning based on overflow analysis.
2022 This doesn't fix any bugs. Use int to hold character, instead
2023 of constantly refetching from Emacs object. Use XFASTINT, not
2024 XINT, for value known to be a character. Don't bother comparing
2025 a single byte to 0400, as it's always less.
2026
395fcb93 2027 * floatfns.c (Fexpt):
327eeec8
PE
2028 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2029
abbd3d23
PE
2030 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2031 for characters.
2032
684a03ef
PE
2033 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2034
0fed43f3
PE
2035 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2036 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2037 incorrectly succeed when S was a string, because 4294967386 was
2038 truncated before it was used.
2039
8fd02eb7
PE
2040 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2041 Otherwise, an out-of-range integer could cause undefined behavior
2042 on a 64-bit host.
2043
f8c86b69
PE
2044 * composite.c: Use int, not EMACS_INT, for characters.
2045 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2046 EMACS_INT, for values that are known to be in character range.
2047 This doesn't fix any bugs but is the usual style inside Emacs and
2048 may generate better code on 32-bit machines.
2049
34206dd2
PE
2050 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2051 This is for reasons similar to the recent CHAR_STRING fix.
2052 * charset.c (Fencode_char): Check that character arg is actually
2053 a character. Pass an int to ENCODE_CHAR.
2054 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2055 wider than 'int', as a compile-time check to prevent future regressions
2056 in this area.
2057
c5958d4c 2058 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2059
2060 Make sure a 64-bit char is never passed to CHAR_STRING.
2061 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2062 by silently ignoring the top 32 bits, allowing some values
2063 that were far too large to be valid characters.
2064 * character.h: Include <verify.h>.
2065 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2066 arguments are no wider than unsigned, as a compile-time check
2067 to prevent future regressions in this area.
2068 * data.c (Faset):
01103c44 2069 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2070 (Fsubst_char_in_region):
2071 * fns.c (concat):
2072 * xdisp.c (decode_mode_spec_coding):
2073 Adjust to CHAR_STRING's new requirement.
2074 * editfns.c (Finsert_char, Fsubst_char_in_region):
2075 * fns.c (concat): Check that character args are actually
2076 characters. Without this test, these functions did the wrong
2077 thing with wildly out-of-range values on 64-bit hosts.
2078
d37ca623
PE
2079 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2080 These casts should not be needed on 32-bit hosts, either.
2081 * keyboard.c (read_char):
2082 * lread.c (Fload): Remove casts to unsigned.
2083
ea204efb
PE
2084 * lisp.h (UNSIGNED_CMP): New macro.
2085 This fixes comparison bugs on 64-bit hosts.
2086 (ASCII_CHAR_P): Use it.
2087 * casefiddle.c (casify_object):
01103c44 2088 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2089 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2090 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2091 * dispextern.h (FACE_FROM_ID):
2092 * keyboard.c (read_char): Use UNSIGNED_CMP.
2093
41cb286c
PE
2094 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2095 not to EMACS_INT, to avoid GCC warning.
2096
4a1b9832
PE
2097 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2098
55daad71
PE
2099 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2100 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2101 isn't needed on 32-bit machines.
8f95c75c 2102
01103c44
PE
2103 * buffer.c (Fgenerate_new_buffer_name):
2104 Use EMACS_INT for count, not int.
0ceccced 2105 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2106
2107 * data.c (Qcompiled_function): Now static.
2108
c6f072e7
PE
2109 * window.c (window_body_lines): Now static.
2110
20ce5912
PE
2111 * image.c (gif_load): Rename local to avoid shadowing.
2112
9c4c5f81
PE
2113 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2114 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2115 * alloc.c (make_save_value): Integer argument is now of type
2116 ptrdiff_t, not int.
2117 (mark_object): Use ptrdiff_t, not int.
2118 * lisp.h (pD): New macro.
2119 * print.c (print_object): Use it.
2120
c0c5c8ae
PE
2121 * alloc.c: Use EMACS_INT, not int, to count objects.
2122 (total_conses, total_markers, total_symbols, total_vector_size)
2123 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2124 (total_free_floats, total_floats, total_free_intervals)
2125 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2126 Now EMACS_INT, not int. All uses changed.
2127 (Fgarbage_collect): Compute overall total using a double, so that
2128 integer overflow is less likely to be a problem. Check for overflow
2129 when converting back to an integer.
5a25e253
PE
2130 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2131 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2132 These were 'int' variables that could overflow on 64-bit hosts;
2133 they were never used, so remove them instead of repairing them.
211a0b2a 2134 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2135 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2136 Previously, this ceilinged at INT_MAX, but that doesn't work on
2137 64-bit machines.
e46bb31a 2138 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2139
c78baabf 2140 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2141 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2142 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2143 when a (possibly-narrower) signed value would do just as well.
2144 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2145
c9d624c6
PE
2146 * alloc.c: Catch some string size overflows that we were missing.
2147 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2148 for convenience in STRING_BYTES_MAX.
2149 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2150 The definition here is exact; the one in lisp.h was approximate.
2151 (allocate_string_data): Check for string overflow. This catches
2152 some instances we weren't catching before. Also, it catches
2153 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2154 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2155 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2156
c9d624c6
PE
2157 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2158 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2159 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2160
353032ce
PE
2161 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2162
2bccce07
PE
2163 * alloc.c (Fmake_string): Check for out-of-range init.
2164
0ac30604
SM
21652011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2166
2167 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2168
c195f2de
JD
21692011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2170
2171 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2172 xg_get_default_scrollbar_width.
2173
2174 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2175 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2176 (style_changed_cb): Call update_theme_scrollbar_width and call
2177 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2178 all frames (Bug#8505).
2179 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2180 Call gtk_window_set_resizable if HAVE_GTK3.
2181 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2182 and height if HAVE_GTK3 (Bug#8505).
2183 (scroll_bar_width_for_theme): New variable.
2184 (update_theme_scrollbar_width): New function.
2185 (xg_get_default_scrollbar_width): Move code to
2186 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2187 (xg_initialize): Call update_theme_scrollbar_width.
2188
2189 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2190
2191 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2192
e10ac9f1
MR
21932011-06-12 Martin Rudalics <rudalics@gmx.at>
2194
2195 * frame.c (make_frame): Call other_buffer_safely instead of
2196 other_buffer.
2197
2198 * window.c (temp_output_buffer_show): Call display_buffer with
2199 second argument Vtemp_buffer_show_specifiers and reset latter
2200 immediately after the call.
2201 (Vtemp_buffer_show_specifiers): New variable.
2202 (auto_window_vscroll_p, next_screen_context_lines)
2203 (Vscroll_preserve_screen_position): Remove leading asterisks from
2204 doc-strings.
2205
2d3c217e 22062011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2207
7b7f97e8 2208 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2209 * buffer.c (Qclone_number): Remove for now, as it's unused.
2210 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2211 (record_buffer): Remove unused local.
2212 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2213 (set_frame_buffer_list): Remove; unused.
2214 * frame.h (other_visible_frames): Remove decl.
2215 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2216 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2217 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2218 if HAVE_GPM.
2219 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2220 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2221 Define only if HAVE_GPM.
2222 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2223 (update_hints_inhibit): Remove; never set. All uses removed.
2224 * widgetprv.h (emacsFrameClassRec): Remove decl.
2225 * window.c (delete_deletable_window): Now returns void, since it
2226 wasn't returning anything.
2227 (compare_window_configurations): Remove unused locals.
2228 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2229 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2230 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2231 the same widths as pointers. This follows up on the 2011-05-06 patch.
2232 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2233 * xterm.h: Likewise.
2234 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2235
1384b89e
JB
22362011-06-12 Juanma Barranquero <lekktu@gmail.com>
2237
2238 * makefile.w32-in: Update dependencies.
2239 (LISP_H): Add lib/intprops.h.
2240
1100a63c
CY
22412011-06-11 Chong Yidong <cyd@stupidchicken.com>
2242
2243 * image.c (gif_load): Add animation frame delay to the metadata.
2244 (syms_of_image): Use DEFSYM. New symbol `delay'.
2245
6198ccd0
MR
22462011-06-11 Martin Rudalics <rudalics@gmx.at>
2247
2248 * window.c (delete_deletable_window): Re-add.
2249 (Fset_window_configuration): Rewrite to handle dead buffers and
2250 consequently deletable windows.
2251 (window_tree, Fwindow_tree): Remove. Supply functionality in
2252 window.el.
2253 (compare_window_configurations): Simplify code.
2254
b6e3633c
AS
22552011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2256
1ab0dee5
AS
2257 * image.c (imagemagick_load_image): Fix type mismatch.
2258 (Fimagemagick_types): Likewise.
2259
b6e3633c
AS
2260 * window.h (replace_buffer_in_windows): Declare.
2261
9397e56f
MR
22622011-06-11 Martin Rudalics <rudalics@gmx.at>
2263
2264 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2265 Qclone_number. Remove external declaration of Qdelete_window.
2266 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2267 code.
640c8776
SM
2268 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2269 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2270 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2271 buffer list implementation.
2272 (other_buffer_safely): New function.
2273 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2274 calls to replace_buffer_in_windows and
2275 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2276 if allowed.
2277 (record_buffer): Inhibit quitting and rewrite using quittable
2278 functions. Run Qbuffer_list_update_hook if allowed.
2279 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2280 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2281 Move switch-to-buffer to window.el.
9397e56f
MR
2282 (bury-buffer): Move to window.el.
2283 (Vbuffer_list_update_hook): New variable.
2284
2285 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2286 section.
2287
2288 * window.h (resize_frame_windows): Move up in code.
2289 (Fwindow_frame): Remove EXFUN.
2290 (replace_buffer_in_all_windows): Remove prototype.
2291 (replace_buffer_in_windows_safely): Add prototype.
2292
2293 * window.c: Declare Qdelete_window static again. Move down
2294 declaration of select_count.
2295 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2296 (Fother_window): Move to window.el.
2297 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2298 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2299 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2300 window.el.
2301 (replace_buffer_in_windows): Implement by calling
2302 Qreplace_buffer_in_windows.
2303 (replace_buffer_in_all_windows): Remove with some functionality
2304 moved into replace_buffer_in_windows_safely.
2305 (replace_buffer_in_windows_safely): New function.
2306 (select_window_norecord, select_frame_norecord): Move in front
2307 of run_window_configuration_change_hook. Remove now obsolete
2308 declarations.
640c8776
SM
2309 (Fset_window_buffer): Rewrite doc-string.
2310 Call Qrecord_window_buffer.
9397e56f
MR
2311 (keys_of_window): Move binding for other-window to window.el.
2312
b50691aa
CY
23132011-06-11 Chong Yidong <cyd@stupidchicken.com>
2314
2315 * dispextern.h (struct image): Replace data member, whose int_val
2316 and ptr_val fields were not used by anything, with a single
2317 lisp_val object.
2318
2319 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2320 (gif_clear_image, gif_load, imagemagick_load_image)
2321 (gs_clear_image, gs_load): Callers changed.
2322
3f754b86
PE
23232011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2324
cca69397
PE
2325 * buffer.h: Include <time.h>, for time_t.
2326 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2327
109e28d0
PE
2328 Fix minor problems found by static checking.
2329
60737f02
PE
2330 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2331
4b66faf3
PE
2332 Make identifiers static if they are not used in other modules.
2333 * data.c (Qcompiled_function, Qframe, Qvector):
2334 * image.c (QimageMagick, Qsvg):
2335 * minibuf.c (Qmetadata):
2336 * window.c (resize_window_check, resize_root_window): Now static.
2337 * window.h (resize_window_check, resize_root_window): Remove decls.
2338
109e28d0
PE
2339 * window.c (window_deletion_count, delete_deletable_window):
2340 Remove; unused.
46a4ce9e
PE
2341 (window_body_lines): Now static.
2342 (Fdelete_other_windows_internal): Mark vars as initialized.
2343 Make sure 'resize_failed' is initialized.
2344 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2345 (resize_window_apply): Remove unused local.
2346 * window.h (delete_deletable_window): Remove decl.
2347
109e28d0 2348 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2349 (imagemagick_load_image): Fix pointer signedness problem by changing
2350 last arg from unsigned char * to char *. All uses changed.
2351 Also, fix a local for similar reasons.
2352 Remove unused locals. Remove locals to avoid shadowing.
2353 (fn_rsvg_handle_free): Remove; unused.
2354 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2355 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2356
3f754b86
PE
2357 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2358
2547adb1
CY
23592011-06-10 Chong Yidong <cyd@stupidchicken.com>
2360
2361 * image.c (gif_load): Fix omitted cast error introduced by
2362 2011-06-06 change.
2363
2c8e37d4
MR
23642011-06-10 Martin Rudalics <rudalics@gmx.at>
2365
2366 * window.h (resize_proportionally, orig_total_lines)
2367 (orig_top_line): Remove from window structure.
2368 (set_window_height, set_window_width, change_window_heights)
2369 (Fdelete_window): Remove prototypes.
2370 (resize_frame_windows): Remove duplicate declaration.
2371
440a42e3
EZ
23722011-06-10 Eli Zaretskii <eliz@gnu.org>
2373
2374 * window.h (resize_frame_windows, resize_window_check)
2375 (delete_deletable_window, resize_root_window)
2376 (resize_frame_windows): Declare prototypes.
2377
2378 * window.c (resize_window_apply): Make definition be "static" to
2379 match the prototype.
2380
562dd5e9
MR
23812011-06-10 Martin Rudalics <rudalics@gmx.at>
2382
2383 * window.c: Remove declarations of Qwindow_size_fixed,
2384 window_min_size_1, window_min_size_2, window_min_size,
2385 size_window, window_fixed_size_p, enlarge_window, delete_window.
2386 Remove static from declaration of Qdelete_window, it's
2387 temporarily needed by Fbury_buffer.
2388 (replace_window): Don't assign orig_top_line and
2389 orig_total_lines.
2390 (Fdelete_window, delete_window): Remove. Window deletion is
2391 handled by window.el.
640c8776
SM
2392 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2393 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2394 (Fdelete_other_windows): Remove. Deleting other windows is
2395 handled by window.el.
2396 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2397 handled in window.el.
2398 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2399 Window minimum sizes are handled in window.el.
2400 (shrink_windows, size_window, set_window_height)
2401 (set_window_width, change_window_heights, window_height)
2402 (window_width, CURBEG, CURSIZE, enlarge_window)
2403 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2404 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2405 handled in window.el.
2406 (make_dummy_parent): Rename to make_parent_window and give it a
2407 second argument horflag.
2408 (make_window): Don't set resize_proportionally any more.
2409 (Fsplit_window): Remove. Windows are split in window.el.
2410 (save_restore_action, save_restore_orig_size)
2411 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2412 Resize mini windows in window.el.
2413 (grow_mini_window, shrink_mini_window): Implement by calling
2414 Qresize_root_window_vertically, resize_window_check and
2415 resize_window_apply.
640c8776
SM
2416 (saved_window, Fset_window_configuration, save_window_save):
2417 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2418 resize_proportionally.
2419 (window_min_height, window_min_width): Move to window.el.
2420 (keys_of_window): Move bindings for delete-other-windows,
2421 split-window, delete-window and enlarge-window to window.el.
2422
2423 * buffer.c: Temporarily extern Qdelete_window.
2424 (Fbury_buffer): Temporarily call Qdelete_window instead of
2425 Fdelete_window (Fbury_buffer will move to window.el soon).
2426
2427 * frame.c (set_menu_bar_lines_1): Remove code handling
2428 orig_top_line and orig_total_lines.
2429
2430 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2431 set_window_height but set heights directly.
2432 (change_frame_size_1): Use resize_frame_windows.
2433
2434 * xdisp.c (init_xdisp): Don't use set_window_height but set
2435 heights directly.
2436
640c8776
SM
2437 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2438 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2439 run_window_configuration_change_hook.
2440
2441 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2442 instead of change_window_heights and run
2443 run_window_configuration_change_hook.
2444
1a13852e
MR
24452011-06-09 Martin Rudalics <rudalics@gmx.at>
2446
2447 * window.c (replace_window): Rename second argument REPLACEMENT to
2448 NEW. New third argument SETFLAG. Rewrite.
2449 (delete_window, make_dummy_parent): Call replace_window with
2450 third argument 1.
2451 (window_list_1): Move down in code.
2452 (run_window_configuration_change_hook): Move set_buffer part
2453 before select_frame_norecord part in order to unwind correctly.
2454 Rename count1 to count.
2455 (recombine_windows, delete_deletable_window, resize_root_window)
2456 (Fdelete_other_windows_internal)
2457 (Frun_window_configuration_change_hook, make_parent_window)
2458 (resize_window_check, resize_window_apply, Fresize_window_apply)
2459 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2460 (Fdelete_window_internal, Fresize_mini_window_internal):
2461 New functions.
1a13852e
MR
2462 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2463
f3d1777e
MR
24642011-06-08 Martin Rudalics <rudalics@gmx.at>
2465
496e208e
MR
2466 * window.h (window): Add some new members to window structure -
2467 normal_lines, normal_cols, new_total, new_normal, clone_number,
2468 splits, nest, prev_buffers, next_buffers.
2469 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2470 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2471
f3d1777e
MR
2472 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2473 Remove.
496e208e
MR
2474 (make_dummy_parent): Set new members of windows structure.
2475 (make_window): Move down in code. Handle new members of window
2476 structure.
2477 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2478 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2479 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2480 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2481 (Fset_window_next_buffers, Fset_window_clone_number):
2482 New functions.
496e208e
MR
2483 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2484 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2485 Doc-string fixes.
2486 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2487 Argument WINDOW can be now internal window too.
2488 (Fwindow_use_time): Move up in code.
2489 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2490 Rewrite doc-string.
2491 (Fset_window_configuration, saved_window)
2492 (Fcurrent_window_configuration, save_window_save): Handle new
2493 members of window structure.
b9e809c2
MR
2494 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2495 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2496 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2497 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2498 Qget_mru_window, Qresize_root_window,
2499 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2500 Qauto_buffer_name; staticpro them.
f3d1777e 2501
abde8f8c
MR
25022011-06-07 Martin Rudalics <rudalics@gmx.at>
2503
2504 * window.c (Fwindow_total_size, Fwindow_left_column)
2505 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2506 (Fwindow_list_1): New functions.
2507 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2508 (Fwindow_width, Fscroll_left, Fscroll_right):
2509 Use window_body_cols instead of window_box_text_cols.
2510 (delete_window, Fset_window_configuration):
2511 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
2512 (delete_all_subwindows): Take a window as argument and not a
2513 structure. Rewrite.
190b47e6
MR
2514 (window_loop): Remove handling of GET_LRU_WINDOW and
2515 GET_LARGEST_WINDOW.
2516 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2517
2518 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2519 window_box_text_cols. delete_all_subwindows now takes a
2520 Lisp_Object as argument.
abde8f8c 2521
640c8776
SM
2522 * indent.c (compute_motion, Fcompute_motion):
2523 Use window_body_cols instead of window_box_text_cols.
abde8f8c 2524
fa8a67e6
MR
2525 * frame.c (delete_frame): Call delete_all_subwindows with root
2526 window as argument.
2527
a54e3482
DC
25282011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2529
2530 * fns.c (Fputhash): Document return value.
2531
60002bf5
CY
25322011-06-06 Chong Yidong <cyd@stupidchicken.com>
2533
2534 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2535
0c671da6 25362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2537
b862a52a 2538 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2539
be44ca6c
PE
2540 Check for overflow when converting integer to cons and back.
2541 * charset.c (Fdefine_charset_internal, Fdecode_char):
2542 Use cons_to_unsigned to catch overflow.
2543 (Fencode_char): Use INTEGER_TO_CONS.
2544 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2545 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2546 * data.c (long_to_cons, cons_to_long): Remove.
2547 (cons_to_unsigned, cons_to_signed): New functions.
2548 These signal an error for invalid or out-of-range values.
2549 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2550 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2551 * font.c (Ffont_variation_glyphs):
2552 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2553 * lisp.h: Include <intprops.h>.
2554 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2555 (cons_to_signed, cons_to_unsigned): New decls.
2556 (long_to_cons, cons_to_long): Remove decls.
2557 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2558 (Fprimitive_undo): Use CONS_TO_INTEGER.
2559 * xfns.c (Fx_window_property): Likewise.
2560 * xselect.c: Include <limits.h>.
2561 (x_own_selection, selection_data_to_lisp_data):
2562 Use INTEGER_TO_CONS.
2563 (x_handle_selection_request, x_handle_selection_clear)
2564 (x_get_foreign_selection, Fx_disown_selection_internal)
2565 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2566 (lisp_data_to_selection_data): Use cons_to_unsigned.
2567 (x_fill_property_data): Use cons_to_signed.
2568 Report values out of range.
2569
d1f3d2af
PE
2570 Check for buffer and string overflow more precisely.
2571 * buffer.h (BUF_BYTES_MAX): New macro.
2572 * lisp.h (STRING_BYTES_MAX): New macro.
2573 * alloc.c (Fmake_string):
2574 * character.c (string_escape_byte8):
2575 * coding.c (coding_alloc_by_realloc):
2576 * doprnt.c (doprnt):
2577 * editfns.c (Fformat):
2578 * eval.c (verror):
2579 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2580 since they may not be the same number.
2581 * editfns.c (Finsert_char):
2582 * fileio.c (Finsert_file_contents):
2583 Likewise for BUF_BYTES_MAX.
2584
dd52fcea
PE
2585 * image.c: Use ptrdiff_t, not int, for sizes.
2586 (slurp_file): Switch from int to ptrdiff_t.
2587 All uses changed.
2588 (slurp_file): Check that file size fits in both size_t (for
2589 malloc) and ptrdiff_t (for sanity and safety).
2590
7f9bbdbb
PE
2591 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2592 if b->modtime has its maximal value.
2593
dfe18f82
PE
2594 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2595
84acfcf0
PE
2596 Don't assume time_t can fit into int.
2597 * buffer.h (struct buffer.modtime): Now time_t, not int.
2598 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2599 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2600
ccd9a01a
PE
2601 Minor fixes for signed vs unsigned integers.
2602 * character.h (MAYBE_UNIFY_CHAR):
2603 * charset.c (maybe_unify_char):
2604 * keyboard.c (read_char, reorder_modifiers):
2605 XINT -> XFASTINT, since the integer must be nonnegative.
2606 * ftfont.c (ftfont_spec_pattern):
2607 * keymap.c (access_keymap, silly_event_symbol_error):
2608 XUINT -> XFASTINT, since the integer must be nonnegative.
2609 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2610 since it makes no difference and we prefer signed.
2611 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2612 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2613 nonnegative.
2614
d6d100dd
SM
26152011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2616
2617 * window.h (Fwindow_frame): Declare.
2618
2b6148e4
PE
26192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2620
2621 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2622 (SPARE_MEMORY): Always define.
2623 (LARGE_REQUEST): Remove.
2624 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2625
f230ecc9
MR
26262011-06-06 Martin Rudalics <rudalics@gmx.at>
2627
727e958e
MR
2628 * lisp.h: Move EXFUNS for Fframe_root_window,
2629 Fframe_first_window and Fset_frame_selected_window to window.h.
2630
2631 * window.h: Move EXFUNS for Fframe_root_window,
2632 Fframe_first_window and Fset_frame_selected_window here from
2633 lisp.h.
2634
2635 * frame.c (Fwindow_frame, Fframe_first_window)
2636 (Fframe_root_window, Fframe_selected_window)
2637 (Fset_frame_selected_window): Move to window.c.
2638 (Factive_minibuffer_window): Move to minibuf.c.
2639 (Fother_visible_frames_p): New function.
2640
2641 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2642
f230ecc9
MR
2643 * window.c (decode_window, decode_any_window): Move up in code.
2644 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2645 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2646 (Fwindow_buffer): Move up and rewrite doc-string.
2647 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2648 (Fwindow_prev): New functions.
727e958e
MR
2649 (Fwindow_frame): Move here from frame.c. Accept any window as
2650 argument.
2651 (Fframe_root_window, Fframe_first_window)
2652 (Fframe_selected_window): Move here from frame.c. Accept frame
2653 or arbitrary window as argument. Update doc-strings.
2654 (Fminibuffer_window): Move up in code.
2655 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2656 (Fset_frame_selected_window): Move here from frame.c.
2657 Marginal rewrite.
727e958e
MR
2658 (Fselected_window, select_window, Fselect_window): Move up in
2659 code. Minor doc-string fixes.
f230ecc9 2660
4d09bcf6
PE
26612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2662
2663 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2664 Do not assume that spare memory exists; that assumption is valid
2665 only if SYSTEM_MALLOC.
2666 (LARGE_REQUEST): New macro, so that the issue of large requests
2667 is separated from the issue of spare memory.
2668
810928a2
AS
26692011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2670
172418ad
AS
2671 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2672 format. (Bug#8806)
2673
43f862f7
AS
2674 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2675
810928a2
AS
2676 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2677 before statements.
2678
a059fe24
JD
26792011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2680
2681 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2682
2683 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2684
2685 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2686 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2687
989bf368
JB
26882011-06-05 Juanma Barranquero <lekktu@gmail.com>
2689
2690 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2691
4b80f674
CY
26922011-06-04 Chong Yidong <cyd@stupidchicken.com>
2693
2694 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2695 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2696 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2697 New error handlers.
4b80f674
CY
2698 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2699 Obey Vx_select_enable_clipboard_manager. Catch errors in
2700 x_clipboard_manager_save (Bug#8779).
2701 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2702 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2703
99a33b77 27042011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2705
2706 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2707
99a33b77 27082011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2709
2710 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2711 in the current matrix if keep_current_p is non-zero.
2712
8264569d
EZ
27132011-06-04 Eli Zaretskii <eliz@gnu.org>
2714
2715 * bidi.c (bidi_level_of_next_char): Fix last change.
2716
57f97249
EZ
27172011-06-03 Eli Zaretskii <eliz@gnu.org>
2718
fec2107c 2719 Support bidi reordering of text covered by display properties.
57f97249 2720
fec2107c
EZ
2721 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2722 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2723 (bidi_cache_search, bidi_cache_iterator_state)
2724 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2725 (bidi_level_of_next_char, bidi_move_to_visually_next):
2726 Support character positions inside a run of characters covered by a
fec2107c
EZ
2727 display string.
2728 (bidi_paragraph_init, bidi_resolve_explicit_1)
2729 (bidi_level_of_next_char): Call bidi_fetch_char and
2730 bidi_fetch_char_advance instead of FETCH_CHAR and
2731 FETCH_CHAR_ADVANCE.
2732 (bidi_init_it): Initialize new members.
2733 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2734 definitions.
2735 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2736 instead of using explicit *_CHAR codes.
d6d100dd
SM
2737 (bidi_resolve_explicit, bidi_resolve_weak):
2738 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2739 bidirectional text is supported only in multibyte buffers.
2740 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2741 it to initialize the frame_window_p member of struct bidi_it.
2742 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2743 (bidi_resolve_explicit, bidi_resolve_weak)
2744 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2745 bidi_it->nchars is non-positive.
2746 (bidi_level_of_next_char): Don't try to lookup the cache for the
2747 next/previous character if nothing is cached there yet, or if we
2748 were just reseat()'ed to a new position.
c40e2fb2 2749
0e14fe90
EZ
2750 * xdisp.c (set_cursor_from_row): Set start and stop points
2751 according to the row's direction when priming the loop that looks
2752 for the glyph on which to display cursor.
2753 (single_display_spec_intangible_p): Function deleted.
2754 (display_prop_intangible_p): Reimplement to call
2755 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2756 Accept 3 additional arguments needed by handle_display_spec.
2757 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2758 values: lists, `(when COND...)' forms, etc.
2759 (single_display_spec_string_p): Support property values that are
2760 lists with the argument STRING its top-level element.
2761 (display_prop_string_p): Fix the condition for processing a
2762 property that is a list to be consistent with handle_display_spec.
fec2107c 2763 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2764 last portion of handle_display_prop.
2765 (compute_display_string_pos): Accept additional argument
2766 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2767 value of a `display' property is a "replacing spec".
2768 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2769 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2770 the display property, but just return a value indicating whether
2771 the display property will replace the characters it covers.
2772 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2773 frame_window_p members of struct bidi_it.
d6d100dd
SM
2774 (compute_display_string_pos, compute_display_string_end):
2775 New functions.
fec2107c
EZ
2776 (push_it): Accept second argument POSITION, where pop_it should
2777 jump to continue iteration.
2778 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2779
fec2107c
EZ
2780 * keyboard.c (adjust_point_for_property): Adjust the call to
2781 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2782
2783 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2784 (bidi_init_it): Update prototypes.
2785 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2786 (compute_display_string_pos, compute_display_string_end):
2787 Declare prototypes.
fec2107c
EZ
2788 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2789 EMACS_INT.
fc6f18ce 2790
40087514 27912011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2792
57f53182
PE
2793 Malloc failure behavior now depends on size of allocation.
2794 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2795 * lisp.h: Change signatures accordingly.
2796 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2797 All callers changed. (Bug#8762)
2798
2799 * gnutls.c: Use Emacs's memory allocators.
2800 Without this change, the gnutls library would invoke malloc etc.
2801 directly, which causes problems on non-SYNC_INPUT hosts, and which
2802 runs afoul of improving memory_full behavior. (Bug#8761)
2803 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2804 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2805 xfree instead of the default malloc, realloc, free.
2806 (Fgnutls_boot): No need to check for memory allocation failure,
2807 since xmalloc does that for us.
2808
ac32cd99 2809 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2810 * category.c (hash_get_category_set):
2811 * ccl.c (ccl_driver):
2812 * charset.c (Fdefine_charset_internal):
2813 * charset.h (struct charset.hash_index):
2814 * composite.c (get_composition_id, gstring_lookup_cache)
2815 (composition_gstring_put_cache):
2816 * composite.h (struct composition.hash_index):
2817 * dispextern.h (struct image.hash):
2818 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2819 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2820 (hashfn_equal, hashfn_user_defined, make_hash_table)
2821 (maybe_resize_hash_table, hash_lookup, hash_put)
2822 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2823 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2824 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2825 * image.c (make_image, search_image_cache, lookup_image)
2826 (xpm_put_color_table_h):
2827 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2828 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2829 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2830 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2831 * alloc.c (allocate_vectorlike):
2832 Check for overflow in vector size calculations.
2833 * ccl.c (ccl_driver):
2834 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2835 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2836 need to be updated by these changes.
40087514
PE
2837 * fns.c (make_hash_table, maybe_resize_hash_table):
2838 Check for integer overflow with large hash tables.
0de4bb68
PE
2839 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2840 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2841 (SXHASH_REDUCE): New macro.
2842 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2843 Use it instead of discarding useful hash info with large hash values.
2844 (sxhash_float): New function.
2845 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2846 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2847 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2848 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2849 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2850 Adjust signatures to match updated version of code.
2851 (consing_since_gc): Now EMACS_INT, since a single hash table can
2852 use more than INT_MAX bytes.
2853
698d32e2
DN
28542011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2855
2856 Make it possible to build with GCC-4.6+ -O2 -flto.
2857
2858 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2859
fd6fa53f
SM
28602011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2861
2862 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2863 Call minibuffer-inactive-mode.
2864
864db017
JB
28652011-05-31 Juanma Barranquero <lekktu@gmail.com>
2866
2867 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2868 Update dependencies.
2869
2ad0baf4
DN
28702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2871
2872 * data.c (init_data): Remove code for UTS, this system is not
2873 supported anymore.
2874
4fcc2638
DN
28752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2876
2877 Don't force ./temacs to start in terminal mode.
2878
2879 * frame.c (make_initial_frame): Initialize faces in all cases, not
2880 only when CANNOT_DUMP is defined.
2881 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2882
c56e0fd5
DN
28832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2884
2885 * dispnew.c (add_window_display_history): Use const for the string
2886 pointer. Remove declaration, not needed.
2887
333d54da 28882011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2889
55d4c1b2 2890 Use 'inline', not 'INLINE'.
333d54da 2891 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2892 * alloc.c, fontset.c (INLINE): Remove.
2893 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2894 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2895 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2896 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2897 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2898
738db178
DN
28992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2900
2901 Make it possible to run ./temacs.
2902
2903 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2904 syms_of_callproc does the same thing. Remove test for
2905 "initialized", do it in the caller.
2906 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2907
620c53a6
SM
29082011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2909
2910 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2911 (read_minibuf): Use get_minibuffer.
2912 (syms_of_minibuf): Use DEFSYM.
2913 (Qmetadata): New var.
2914 * data.c (Qbuffer): Don't make it static.
2915 (syms_of_data): Use DEFSYM.
2916
e003a292
PE
29172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2918
2919 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2920 (CCL_CODE_MIN): New macro.
2921
ed008a6d
PE
29222011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2923
3687c2ef
PE
2924 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2925
ed008a6d
PE
2926 * eval.c (Qdebug): Now static.
2927 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2928 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2929 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2930
d66c4c7c
CY
29312011-05-29 Chong Yidong <cyd@stupidchicken.com>
2932
2933 * image.c: Various fixes to ImageMagick code comments.
2934 (Fimagemagick_types): Doc fix.
2935
5fbc2025
PE
29362011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2937
0196f88a
PE
2938 Minor fixes prompted by GCC 4.6.0 warnings.
2939
2940 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2941
5fbc2025
PE
2942 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2943 (x_clipboard_manager_save_all): Move extern decl to ...
2944 * xterm.h: ... here, so that it can be checked for consistency.
2945
1dd3c2d9
CY
29462011-05-29 Chong Yidong <cyd@stupidchicken.com>
2947
2948 * xselect.c (x_clipboard_manager_save_frame)
2949 (x_clipboard_manager_save_all): New functions.
2950 (Fx_clipboard_manager_save): Lisp function deleted.
2951
2952 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2953 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2954
2955 * xterm.h: Update prototype.
2956
5ba6571d
WX
29572011-05-28 William Xu <william.xwl@gmail.com>
2958
2959 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2960 exiting (Bug#8239).
2961
3eaff834
JM
29622011-05-28 Jim Meyering <meyering@redhat.com>
2963
e1900994 2964 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2965 * fns.c (to_uchar): Define.
2966 (crypto_hash_function): Use it to convert some newly-signed
2967 variables to unsigned, to avoid sign-extension bugs. For example,
2968 without this change, (md5 "truc") would evaluate to
2969 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2970 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2971 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2972
0f6990a7
PE
29732011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2974
2975 Integer overflow fixes.
c8a9ca5a 2976
08686060
PE
2977 * dbusbind.c: Serial number integer overflow fixes.
2978 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2979 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2980 to hold a serial number that is too large for a fixnum.
2981 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2982 Check for serial numbers out of range. Decode any serial number
59568bf0 2983 that was so large that it became a float. (Bug#8722)
08686060 2984
2d1fc3c7
PE
2985 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2986 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2987 Use XFASTINT rather than XUINT when numbers are nonnegative.
2988 (xd_append_arg, Fdbus_method_return_internal):
2989 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2990 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2991 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2992 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2993 (Bug#8722)
2d1fc3c7 2994
c8a9ca5a
PE
2995 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2996
519e1d69
PE
2997 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2998
30569699
PE
2999 ccl: add integer overflow checks
3000 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3001 (IN_INT_RANGE): New macros.
3002 (ccl_driver): Use them to check for integer overflow when
3003 decoding a CCL program. Many of the new checks are whether XINT (x)
3004 fits in int; it doesn't always, on 64-bit hosts. The new version
3005 doesn't catch all possible integer overflows, but it's an
847044ea 3006 improvement. (Bug#8719)
30569699 3007
c11285dc
PE
3008 * alloc.c (make_event_array): Use XINT, not XUINT.
3009 There's no need for unsigned here.
3010
fdccd48e
PE
3011 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3012 This follows up to the 2011-05-06 change that substituted uintptr_t
3013 for EMACS_INT. This case wasn't caught back then.
3014
37910ab2
PE
3015 Rework Fformat to avoid integer overflow issues.
3016 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3017 now (part of C89). Include <verify.h>.
3018 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3019 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3020 (Fformat): Avoid the prepass trying to compute sizes; it was only
3021 approximate and thus did not catch overflow reliably. Instead, walk
3022 through the format just once, formatting and computing sizes as we go,
3023 checking for integer overflow at every step, and allocating a larger
3024 buffer as needed. Keep track separately whether the format is
3025 multibyte. Keep only the most-recently calculated precision, rather
3026 than them all. Record whether each argument has been converted to
3027 string. Use EMACS_INT, not int, for byte and char and arg counts.
3028 Support field widths and precisions larger than INT_MAX. Avoid
3029 sprintf's undefined behavior with conversion specifications such as %#d
3030 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3031 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3032 formatting out-of-range floating point numbers with int
9173deec 3033 formats. (Bug#8668)
37910ab2 3034
2e6578fb
PE
3035 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3036
0ae6bdee
PE
3037 * data.c: Avoid integer truncation in expressions involving floats.
3038 * data.c: Include <intprops.h>.
3039 (arith_driver): When there's an integer overflow in an expression
3040 involving floating point, convert the integers to floating point
3041 so that the resulting value does not suffer from catastrophic
3042 integer truncation. For example, on a 64-bit host (* 4
3043 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3044 Do not rely on undefined behavior after integer overflow.
3045
de883a70
PE
3046 merge count_size_as_multibyte, parse_str_to_multibyte
3047 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3048 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3049 Check for integer overflow.
3050 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3051 since it's now a duplicate of the other. This is more of
3052 a character than a buffer op, so better that it's in character.c.
3053 * fns.c, print.c: Adjust to above changes.
3054
2ff916cb
PE
30552011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3056
3057 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3058
f1b54466
PE
30592011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3060
fb1ac845
PE
3061 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3062 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3063 (x_clipboard_manager_save): Now static.
3064 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3065
f1b54466
PE
3066 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3067 (crypto_hash_function): Now static.
3068 Fix pointer signedness problems. Avoid unnecessary initializations.
3069
a9f737ee
CY
30702011-05-27 Chong Yidong <cyd@stupidchicken.com>
3071
3072 * termhooks.h (Vselection_alist): Make it terminal-local.
3073
3074 * terminal.c (create_terminal): Initialize it.
3075
3076 * xselect.c: Support for clipboard managers.
3077 (Vselection_alist): Move to termhooks.h as terminal-local var.
3078 (LOCAL_SELECTION): New macro.
3079 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3080 (symbol_to_x_atom): Remove gratuitous arg.
3081 (x_handle_selection_request, lisp_data_to_selection_data)
3082 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3083 (x_own_selection, x_get_local_selection, x_convert_selection):
3084 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3085 (some_frame_on_display): Delete unused function.
3086 (Fx_own_selection_internal, Fx_get_selection_internal)
3087 (Fx_disown_selection_internal, Fx_selection_owner_p)
3088 (Fx_selection_exists_p): New optional frame arg.
3089 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3090 (x_handle_selection_clear): Don't treat other terminals with the
3091 same keyboard specially. Use the terminal-local Vselection_alist.
3092 (x_clear_frame_selections): Use Frun_hook_with_args.
3093
3094 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3095
3096 * xterm.h: Add support for those atoms.
3097
e067f0c1
CY
30982011-05-26 Chong Yidong <cyd@stupidchicken.com>
3099
3100 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3101 (converted_selections, conversion_fail_tag): New global variables.
3102 (x_selection_request_lisp_error): Free the above.
3103 (x_get_local_selection): Remove unnecessary code.
3104 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3105 of converted selections stored in converted_selections.
3106 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3107 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3108 (x_convert_selection): New function.
3109 (x_handle_selection_event): Simplify.
3110 (x_get_foreign_selection): Don't ignore incoming requests while
3111 waiting for an answer; this will fail when we implement
3112 SAVE_TARGETS, and seems unnecessary anyway.
3113 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3114 (Vx_sent_selection_functions): Doc fix.
3115
0f4aebc0
LL
31162011-05-26 Leo Liu <sdl.web@gmail.com>
3117
3118 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3119
e61124cd
YM
31202011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3121
3122 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3123
3124 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3125 for fringe update if it has periodic bitmap.
ac389d0c 3126 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3127 and fringe_bitmap_periodic_p.
3128
3129 * fringe.c (get_fringe_bitmap_data): New function.
3130 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3131 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3132 row. Mark glyph row for fringe update if periodicity changed.
3133
3134 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3135 for fringe update unless it has periodic bitmap.
3136
f16d9837
KH
31372011-05-25 Kenichi Handa <handa@m17n.org>
3138
3139 * xdisp.c (get_next_display_element): Set correct it->face_id for
3140 a static composition.
3141
e1b90ef6
LL
31422011-05-24 Leo Liu <sdl.web@gmail.com>
3143
3144 * deps.mk (fns.o):
3145 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3146
3147 * fns.c (crypto_hash_function, Fsha1): New function.
3148 (Fmd5): Use crypto_hash_function.
3149 (syms_of_fns): Add Ssha1.
3150
7400048f
PE
31512011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3152
3153 * gnutls.c: Remove unused macros.
3154 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3155 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3156 Remove macros that are defined and never used.
3157 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3158
abb71cf4
CY
31592011-05-22 Chong Yidong <cyd@stupidchicken.com>
3160
3161 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3162 (Fx_get_selection_internal): Minor cleanup.
3163 (Fx_own_selection_internal): Rename arguments for consistency with
3164 select.el.
3165
6307db39
PE
31662011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3167
3168 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3169
f3d4e0a4
CY
31702011-05-22 Chong Yidong <cyd@stupidchicken.com>
3171
3172 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3173
4d8ade89
YM
31742011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3175
3176 * dispnew.c (scrolling_window): Don't exclude the case that the
3177 last enabled row in the desired matrix touches the bottom boundary.
3178
32078c8d
GM
31792011-05-21 Glenn Morris <rgm@gnu.org>
3180
3181 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3182 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3183 and add some more files.
32078c8d 3184
7285dc67
EZ
31852011-05-20 Eli Zaretskii <eliz@gnu.org>
3186
3187 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3188 report_file_error introduced by the change from 2011-05-07.
3189
89d1bd22
PE
31902011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3191
3192 * systime.h (Time): Define only if emacs is defined.
3193 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3194 where the include path doesn't have X11/X.h by default. See
3195 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3196
e23640bb 31972011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3198
3199 * composite.c (find_automatic_composition): Fix previous change.
3200
b9704ad9
GM
32012011-05-20 Glenn Morris <rgm@gnu.org>
3202
3203 * lisp.mk: New file, split from Makefile.in.
3204 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3205 (shortlisp): Remove.
3206 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3207
4a720484
GM
32082011-05-19 Glenn Morris <rgm@gnu.org>
3209
3210 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3211 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3212 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3213 (lisp): Set the order to that of loadup.el.
3214 (shortlisp): Make it a copy of $lisp.
3215 (SOME_MACHINE_LISP): Remove.
3216 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3217 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3218
a28d4396
KH
32192011-05-18 Kenichi Handa <handa@m17n.org>
3220
3221 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3222 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3223 (find_automatic_composition): Mostly rewrite for efficiency.
3224
a2b1fa8e
JB
32252011-05-18 Juanma Barranquero <lekktu@gmail.com>
3226
3227 * makefile.w32-in: Update dependencies.
3228
8e1f5610
CS
32292011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3230
3231 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3232 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3233
7025ee00 32342011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3235
cdfa6eab
PE
3236 Fix some integer overflow issues, such as string length overflow.
3237
06d6db33
PE
3238 * insdel.c (count_size_as_multibyte): Check for string overflow.
3239
2b4560a8
PE
3240 * character.c (lisp_string_width): Check for string overflow.
3241 Use EMACS_INT, not int, for string indexes and lengths; in
3242 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3243 the resulting string length overflows an EMACS_INT; instead,
3244 report a string overflow if no precision given. When checking for
3245 precision exhaustion, use a check that cannot possibly have
3246 integer overflow. (Bug#8675)
3247 * character.h (lisp_string_width): Adjust to new signature.
3248
cb93f9be
PE
3249 * alloc.c (string_overflow): New function.
3250 (Fmake_string): Use it. This doesn't change behavior, but saves
3251 a few bytes and will simplify future changes.
3252 * character.c (string_escape_byte8): Likewise.
3253 * lisp.h (string_overflow): New decl.
3254
1a1f3366
PE
3255 Fixups, following up to the user-interface timestamp change.
3256 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3257 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3258 * msdos.c (mouse_get_pos): Likewise.
3259 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3260 * w32gui.h (Time): Define by including "systime.h" rather than by
3261 declaring it ourselves. (Bug#8664)
3262
d4e3e4d3
PE
3263 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3264 * image.c (clear_image_cache): Likewise.
3265
f6a24d19
PE
3266 * term.c (term_mouse_position): Don't assume time_t wraparound.
3267
08dc5ae6
PE
3268 Be more systematic about user-interface timestamps.
3269 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3270 and sometimes 'EMACS_UINT', to represent these timestamps.
3271 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3272 This makes the code easier to follow, and makes it easier to catch
3273 integer overflow bugs such as Bug#8664.
3274 * frame.c (Fmouse_position, Fmouse_pixel_position):
3275 Use Time, not unsigned long, for user-interface timestamps.
3276 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3277 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3278 * keyboard.h (last_event_timestamp): Likewise.
3279 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3280 * menu.h (xmenu_show): Likewise.
3281 * term.c (term_mouse_position): Likewise.
3282 * termhooks.h (struct input_event.timestamp): Likewise.
3283 (struct terminal.mouse_position_hook): Likewise.
3284 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3285 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3286 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3287 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3288 what it was before.
3289 * menu.h, termhooks.h: Include "systime.h", for Time.
3290
8e55734a
PE
3291 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3292 Don't assume that the difference between two unsigned long values
3293 can fit into an integer. At this point, we know button_down_time
3294 <= event->timestamp, so the difference must be nonnegative, so
3295 there's no need to cast the result if double-click-time is
3296 nonnegative, as it should be; check that it's nonnegative, just in
3297 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3298 apart (about 25 days). (Bug#8664)
8e55734a 3299
841f1b75 3300 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3301 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3302
3e26f69c
PE
3303 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3304 that always fit in int. Use a sentinel instead of a counter, to
3305 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3306 * frame.h (struct frame): Use int for menu_bar_items_used
3307 instead of EMACS_INT, since it always fits in int.
3e26f69c 3308
5cc152c0
PE
3309 * menu.c (grow_menu_items): Check for int overflow.
3310
d89eb65e
PE
3311 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3312
5235bd3e
PE
3313 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3314 Before, the code was not consistent. These values cannot exceed
3315 2**31 - 1 so there's no need to make them unsigned.
3316 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3317 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3318 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3319 as modifiers.
3320 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3321
bc827e23
PE
3322 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3323 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3324 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3325 presumably because the widths might not match.
3326
78eb494e
PE
3327 * window.c (size_window): Avoid needless test at loop start.
3328
04f2d78b
CB
33292011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3330
3331 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3332
d2fc7e3d 33332011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3334
3335 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3336
d2fc7e3d 33372011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3338
3339 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3340 `width' to `bar_area_x' and `bar_area_width', respectively.
3341 (x_scroll_run): Take account of fringe background extension.
3342
04f2d78b
CB
3343 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3344 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3345 `bar_area_width', respectively.
3346 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3347 background extension.
3348
79b70037
GM
33492011-05-10 Jim Meyering <meyering@redhat.com>
3350
3351 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3352
2f142cc5
JB
33532011-05-10 Juanma Barranquero <lekktu@gmail.com>
3354
3355 * image.c (Finit_image_library): Return t for built-in image types,
3356 like pbm and xbm. (Bug#8640)
3357
57679c86
AS
33582011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3359
3360 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3361
888c9e86
EZ
33622011-05-07 Eli Zaretskii <eliz@gnu.org>
3363
b0512a1d
EZ
3364 * w32console.c (Fset_screen_color): Doc fix.
3365 (Fget_screen_color): New function.
3366 (syms_of_ntterm): Defsubr it.
3367
7285dc67
EZ
3368 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3369 unlink the temporary file if Fcall_process didn't create it in the
3370 first place.
3371 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3372 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3373 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3374 cue to call_process_cleanup not to close that handle.
3375
4d3fcc8e
BK
33762011-05-07 Ben Key <bkey76@gmail.com>
3377
3378 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3379 one of two shell specific rules, either bootstrap-temacs-CMD or
3380 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3381 to the previous implementation of the bootstrap-temacs rule.
3382 The bootstrap-temacs-CMD rule is similar to the previous
3383 implementation of the bootstrap-temacs rule except that it
3384 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3385 variable.
3386
3387 These changes, along with some changes to nt/configure.bat,
3388 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3389 earlier fix to add support for --cflags and --ldflags options
3390 that include quotes so that it works whether make uses cmd or
3391 sh as the shell.
3392
b4289b64
MA
33932011-05-06 Michael Albinus <michael.albinus@gmx.de>
3394
3395 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3396 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3397 is a constant.
3398 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3399 a string. Handle both cases.
3400 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3401 (Fdbus_register_method): Use Qinvalid_function.
3402
af4c0e28
JB
34032011-05-06 Juanma Barranquero <lekktu@gmail.com>
3404
3405 * makefile.w32-in: Update dependencies.
3406 (LISP_H): Add inttypes.h and stdin.h.
3407 (PROCESS_H): Add unistd.h.
3408
c51453d9
EZ
34092011-05-06 Eli Zaretskii <eliz@gnu.org>
3410
3411 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3412 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3413
8ff0ac3c 34142011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3415
4c4b566b
PE
3416 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3417
aab2b9b5
PE
3418 * term.c (vfatal): Remove stray call to va_end.
3419 It's not needed and the C Standard doesn't allow it here anyway.
3420
c378da0b
PE
3421 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3422 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3423
288b08c7
PE
3424 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3425 bytes.
3426
e3601888
PE
3427 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3428
db6c0e74
PE
3429 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3430
dd5963ea
PE
3431 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3432
88c9450f
PE
3433 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3434
2f9442b8
PE
3435 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3436
c032b5f8
PE
3437 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3438 * charset.c (Fdefine_charset_internal): Don't initialize
3439 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3440 32-bit int (Bug#8600).
a108c10b
PE
3441
3442 * lread.c (read_integer): Be more consistent with string-to-number.
3443 Use string_to_number to do the actual conversion; this avoids
3444 rounding errors and fixes some other screwups. Without this fix,
3445 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3446 (digit_to_number): Move earlier, for benefit of read_integer.
3447 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3448 not a digit in any supported base. (Bug#8602)
a108c10b 3449
ad5f9eea
PE
3450 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3451
aec1708a
PE
3452 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3453 to match comment at start of function. This also removes a
3454 GCC warning about overflow in a 32+64-bit port.
3455
47be4ab5
PE
3456 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3457
371cac43
PE
3458 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3459 Reported by Stefan Monnier in
3460 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3461 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3462 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3463
d01a7826
PE
3464 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3465 (EMACS_UINTPTR): Likewise, with uintptr_t.
3466
7fd47d5c
PE
3467 * lisp.h: Prefer 64-bit EMACS_INT if available.
3468 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3469 on 32-bit hosts that have 64-bit int, so that they can access
3470 large files.
122b0c86
PE
3471 However, temporarily disable this change unless the temporary
3472 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3473
8727937b
PE
3474 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3475
8ac068ac
PE
3476 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3477 This removes an assumption that EMACS_INT and long are the same
3478 width as pointers. The assumption is true for Emacs porting targets
3479 now, but we want to make other targets possible.
3480 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3481 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3482 In the rest of the code, change types of integers that hold casted
3483 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3484 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3485 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3486 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3487 No need to cast type when ORing.
3488 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3489 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3490 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3491 assume EMACS_INT is the same width as char *.
3492 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3493 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3494 Remove no-longer-needed casts.
3495 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3496 (xg_tool_bar_help_callback, xg_make_tool_item):
3497 Use EMACS_INTPTR to hold an integer
3498 that will be cast to void *; this can avoid a GCC warning
3499 if EMACS_INT is not the same width as void *.
3500 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3501 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3502 (current_message_1, set_message_1):
3503 Use a local to convert to proper width without a cast.
3504 * xmenu.c (dialog_selection_callback): Likewise.
3505
ede49d71
PE
3506 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3507 Also, don't assume VALBITS / RAND_BITS is less than 5,
3508 and don't rely on undefined behavior when shifting a 1 left into
3509 the sign bit.
3510 * lisp.h (get_random): Change signature to match.
3511
2f30ecd0
PE
3512 * lread.c (hash_string): Use size_t, not int, for hash computation.
3513 Normally we prefer signed values; but hashing is special, because
3514 it's better to use unsigned division on hash table sizes so that
3515 the remainder is nonnegative. Also, size_t is the natural width
3516 for hashing into memory. The previous code used 'int', which doesn't
3517 retain enough info to hash well into very large tables.
3518 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3519
2a866e7b
PE
3520 * dbusbind.c: Don't possibly lose pointer info when converting.
3521 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3522 Use XPNTR rather than XHASH, so that the high-order bits of
3523 the pointer aren't lost when converting through void *.
3524
51639eac
PE
3525 * eval.c (Fautoload): Don't double-shift a pointer.
3526
92394119
PE
3527 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3528
dbdb9a7c
JB
35292011-05-06 Juanma Barranquero <lekktu@gmail.com>
3530
3531 * gnutls.c (DEF_GNUTLS_FN):
3532 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3533
db7a0b4f
AS
35342011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3535
3536 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3537 marker. (Bug#8610)
3538
f7ff1b0f 35392011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3540
3541 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3542 New version that can reserve upto 2GB of heap space.
3543
f7ff1b0f 35442011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3545
3546 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3547
639c109b
TZ
35482011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3549
3550 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3551 `gnutls_certificate_set_x509_key_file'.
3552
d2127135
JB
35532011-05-05 Juanma Barranquero <lekktu@gmail.com>
3554
3555 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3556 Update dependencies.
3557
e968f4f3
JB
35582011-05-04 Juanma Barranquero <lekktu@gmail.com>
3559
3560 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3561 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3562 Remove unused parameter `fildes'.
3563 * process.c (read_process_output, send_process): Don't pass it.
3564
84d358f0
JB
35652011-05-04 Juanma Barranquero <lekktu@gmail.com>
3566
3567 Fix previous change: the library cache is defined in w32.c.
3568 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3569 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3570
0898ca10
JB
35712011-05-04 Juanma Barranquero <lekktu@gmail.com>
3572
3573 Implement dynamic loading of GnuTLS on Windows.
3574
3575 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3576 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3577 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3578 Declare.
3579
3580 * gnutls.c (Qgnutls_dll): Define.
3581 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3582 (gnutls_*): Declare function pointers.
3583 (init_gnutls_functions): New function to initialize function pointers.
3584 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3585 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3586 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3587 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3588 (emacs_gnutls_write, emacs_gnutls_read)
3589 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3590 (Fgnutls_available_p): New function.
3591 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3592 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3593 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3594
3595 * image.c: Include w32.h.
3596 (Vimage_type_cache): Delete.
3597 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3598 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3599 (w32_delayed_load): Move to w32.c.
3600
3601 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3602
3603 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3604 (w32_delayed_load): Move from image.c. When loading a library, record
3605 its filename in the :loaded-from property of the library id.
3606 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3607 Initialize and staticpro them.
3608 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3609
3610 * process.c: Include lisp.h before w32.h, not after.
3611 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3612 instead of gnutls_record_check_pending.
3613
3614 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3615
ff4de4aa
TZ
36162011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3617
3618 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3619 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3620 as passed in.
3621
abe95abb
JD
36222011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3623
3624 * xterm.c (x_set_frame_alpha): Do not set property on anything
3625 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3626
e16e55d4
JB
36272011-05-02 Juanma Barranquero <lekktu@gmail.com>
3628
3629 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3630
bafcf6a5
JB
36312011-05-02 Juanma Barranquero <lekktu@gmail.com>
3632
3633 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3634 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3635 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3636 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3637 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3638 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3639 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3640 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3641 (Qgnutls_bootprop_callbacks_verify): Make static.
3642
e7a6747f
AS
36432011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3644
19ed11ba
AS
3645 * callproc.c: Indentation fixup.
3646
e7a6747f 3647 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3648 (wait_for_termination, interruptible_wait_for_termination):
3649 Move after wait_for_termination_1.
e7a6747f 3650
1ef14cb4
LMI
36512011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3652
3653 * sysdep.c (interruptible_wait_for_termination): New function
3654 which is like wait_for_termination, but allows keyboard
3655 interruptions.
3656
3657 * callproc.c (Fcall_process): Add (:file "file") as an option for
3658 the STDOUT buffer.
3659 (Fcall_process_region): Ditto.
3660
330d880c
EZ
36612011-04-30 Eli Zaretskii <eliz@gnu.org>
3662
8db90b73
EZ
3663 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3664 rather than `XVECTOR (FOO)->size'.
3665
330d880c
EZ
3666 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3667 inttypes.h, as a gnulib replacement is used if it not available in
3668 system headers.
3669
15cbd324
EZ
36702011-04-21 Eli Zaretskii <eliz@gnu.org>
3671
3672 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3673 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3674 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3675
3676 * coding.c (coding_alloc_by_realloc): Error out if destination
3677 will grow beyond MOST_POSITIVE_FIXNUM.
3678 (decode_coding_emacs_mule): Abort if there isn't enough place in
3679 charbuf for the composition carryover bytes. Reserve an extra
3680 space for up to 2 characters produced in a loop.
3681 (decode_coding_iso_2022): Abort if there isn't enough place in
3682 charbuf for the composition carryover bytes.
3683
36842011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3685
ae940cca
EZ
3686 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3687 aborting when %lld or %lll format is passed.
3688 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3689 %llo or %llx format is passed. (Bug#8545)
3690
03ab8921
EZ
3691 * window.c (window_scroll_line_based): Use a marker instead of
3692 simple variables to record original value of point. (Bug#7952)
3693
afda1437
EZ
3694 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3695 produced by %s or %c overflows available buffer space. (Bug#8545)
3696
f76dee0c
PE
36972011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3698
3699 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3700 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3701
fdc5744d
JB
37022011-04-28 Juanma Barranquero <lekktu@gmail.com>
3703
3704 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3705
638f053a
JB
37062011-04-28 Juanma Barranquero <lekktu@gmail.com>
3707
3708 * keyboard.c (Qdelayed_warnings_hook): Define.
3709 (command_loop_1): Run `delayed-warnings-hook'
3710 if Vdelayed_warnings_list is non-nil.
3711 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3712 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3713
d178f871
EZ
37142011-04-28 Eli Zaretskii <eliz@gnu.org>
3715
3716 * doprnt.c (doprnt): Don't return value smaller than the buffer
3717 size if the message was truncated. (Bug#8545).
3718
b124fd93
JB
37192011-04-28 Juanma Barranquero <lekktu@gmail.com>
3720
3721 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3722 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3723
e810457d
PE
37242011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3725
3726 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3727
ea51cceb
JB
37282011-04-27 Juanma Barranquero <lekktu@gmail.com>
3729
3730 * makefile.w32-in: Update dependencies.
3731
94dcfacf
EZ
37322011-04-27 Eli Zaretskii <eliz@gnu.org>
3733
3734 Improve `doprnt' and its usage. (Bug#8545)
3735 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3736 `format_end'. Remove support for %l as a conversion specifier.
3737 Don't use xrealloc. Improve diagnostics when the %l size modifier
3738 is used. Update the commentary.
3739
3740 * eval.c (verror): Simplify calculation of size_t.
3741
3742 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3743 messages.
3744
f61f41d7
PE
37452011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3746
3747 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3748 change.
3749
96fb4434
PE
37502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3751
3752 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3753 This makes this file independent of the recent pseudovector change.
3754
671875da 37552011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3756
69e9b5a3
PE
3757 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3758
b5f869a7 3759 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3760 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3761 Remove unused local.
c8926152 3762 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3763
841a1577 3764 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3765 GCC 4.6.0 optimizes based on type-based alias analysis.
3766 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3767 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3768 != &v->size, and therefore "v->size = 1; b->size = 2; return
3769 v->size;" must therefore return 1. This assumption is incorrect
3770 for Emacs, since it type-puns struct Lisp_Vector * with many other
3771 types. To fix this problem, this patch adds a new type struct
f904488f 3772 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3773 and pseudovectors, and helps optimizing compilers not get fooled
3774 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3775 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3776 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3777 the size member.
eab3844f
PE
3778 (XSETPVECTYPE): Rewrite in terms of new macro.
3779 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3780 This is a bit clearer, and further avoids the possibility of
3781 undesirable aliasing.
3782 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3783 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3784 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3785 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3786 (ASIZE): Now uses header.size rather than size.
3787 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3788 to avoid the hassle of writing XVECTOR (foo)->header.size.
3789 (struct vectorlike_header): New type.
eab3844f
PE
3790 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3791 object, to help avoid aliasing.
3792 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3793 (SUBRP): Likewise, since Lisp_Subr is a special case.
3794 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3795 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3796 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3797 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3798 changed to be "header.size" and "header.next".
3799 * buffer.h (struct buffer): Likewise.
3800 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3801 * frame.h (struct frame): Likewise.
3802 * process.h (struct Lisp_Process): Likewise.
3803 * termhooks.h (struct terminal): Likewise.
3804 * window.c (struct save_window_data, struct saved_window): Likewise.
3805 * window.h (struct window): Likewise.
3806 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3807 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3808 * buffer.c (init_buffer_once): Likewise.
3809 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3810 special case.
3811 * process.c (Fformat_network_address): Use local var for size,
3812 for brevity.
3813
0df1eac5
PE
3814 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3815
847ab9d1 3816 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3817 * data.c (atof): Remove decl; no longer used or needed.
3818 (digit_to_number): Move to lread.c.
3819 (Fstring_to_number): Use new string_to_number function, to be
3820 consistent with how the Lisp reader treats infinities and NaNs.
3821 Do not assume that floating-point numbers represent EMACS_INT
3822 without losing information; this is not true on most 64-bit hosts.
3823 Avoid double-rounding errors, by insisting on integers when
3824 parsing non-base-10 numbers, as the documentation specifies.
3825 * lisp.h (string_to_number): New decl, replacing ...
3826 (isfloat_string): Remove.
bc0a5c13 3827 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3828 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3829 appears to have been a coding error. Similarly, do not accept
3830 strings like +-1e0 as floating point numbers. Do not report
3831 overflow for integer overflows unless the base is not 10 which
3832 means we have no simple and reliable way to continue.
3833 Break out the floating-point parsing into a new
3834 function string_to_number, so that Fstring_to_number parses
3835 floating point numbers consistently with the Lisp reader.
04f2d78b 3836 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3837 (E_CHAR, EXP_INT): Remove, replacing with ...
3838 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3839 (string_to_number): New function, replacing isfloat_string.
3840 This function checks for valid syntax and produces the resulting
3841 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3842 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3843 so that overflow for non-base-10 numbers is reported only when
3844 there's no portable and simple way to convert to floating point.
452f4150 3845
67769ffc
PE
3846 * textprop.c (set_text_properties_1): Rewrite for clarity,
3847 and to avoid GCC warning about integer overflow.
3848
c20db43f
PE
3849 * intervals.h (struct interval): Use EMACS_INT for members
3850 where EMACS_UINT might cause problems. See
3851 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3852 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3853 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3854 All uses changed.
37aa2f85
PE
3855 (offset_intervals): Tell GCC not to worry about length overflow
3856 when negating a negative length.
c20db43f 3857
2538aa2f
PE
3858 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3859 (overrun_check_free): Likewise.
3860
f2d3008d
PE
3861 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3862 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3863 word size.
3864
ec8df744
PE
3865 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3866 (gnutls_make_error): Rename local to avoid shadowing.
3867 (gnutls_emacs_global_deinit): ifdef out; not used.
3868 (Fgnutls_boot): Use const for pointer to readonly storage.
3869 Comment out unused local. Fix pointer signedness problems.
3870
640ee02d
PE
3871 * lread.c (openp): Don't stuff size_t into an 'int'.
3872 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3873 about possible signed overflow.
3874
6048fb2a
PE
3875 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3876 (GDK_KEY_g): Don't define if already defined.
3877 (xg_prepare_tooltip): Avoid pointer signedness problem.
3878 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3879
fa3c87e1
PE
3880 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3881 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3882
2172544b
PE
3883 * xfns.c (Fx_window_property): Simplify a bit,
3884 to make a bit faster and to avoid GCC 4.6.0 warning.
3885 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3886
9b821a21
PE
3887 * fns.c (internal_equal): Don't assume size_t fits in int.
3888
3c616cfa
PE
3889 * alloc.c (compact_small_strings): Tighten assertion a little.
3890
c2982e87
PE
3891 Replace pEd with more-general pI, and fix some printf arg casts.
3892 * lisp.h (pI): New macro, generalizing old pEd macro to other
3893 conversion specifiers. For example, use "...%"pI"d..." rather
3894 than "...%"pEd"...".
3895 (pEd): Remove. All uses replaced with similar uses of pI.
3896 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3897 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3898 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3899 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3900 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3901 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3902 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3903 64-bit hosts.
3904 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3905 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3906 * print.c (safe_debug_print, print_object): Likewise.
3907 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3908 to int.
6f04d126
PE
3909 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3910 avoiding the 0 flag, which is not portable.
c2982e87
PE
3911 * process.c (Fmake_network_process): Use pI to avoid cast.
3912 * region-cache.c (pp_cache): Likewise.
3913 * xdisp.c (decode_mode_spec): Likewise.
3914 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3915 behavior on 64-bit hosts with printf arg.
6f04d126 3916 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3917 (x_stop_queuing_selection_requests): Likewise.
3918 (x_get_window_property): Don't truncate byte count to an 'int'
3919 when tracing.
0b432f21 3920
5e073ec7
PE
3921 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3922 here, since it parses constructs like leading '-' and spaces,
3923 which are not wanted; and it overflows with large numbers.
3924 Instead, simply match F[0-9]+, which is what is wanted anyway.
3925
36372bf9
PE
3926 * alloc.c: Remove unportable assumptions about struct layout.
3927 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3928 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3929 (allocate_vectorlike, make_pure_vector): Use the new macros,
3930 plus offsetof, to remove unportable assumptions about struct layout.
3931 These assumptions hold on all porting targets that I know of, but
3932 they are not guaranteed, they're easy to remove, and removing them
3933 makes further changes easier.
3934
0b432f21
PE
3935 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3936 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3937 (string_overrun_cookie): Now const. Use initializers that
3938 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3939 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3940 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3941 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3942 multiple of sizeof (EMACS_INT); it need not be, if
3943 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3944 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3945
895009e1
JB
39462011-04-26 Juanma Barranquero <lekktu@gmail.com>
3947
3948 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3949
6a7a1b0b
TZ
39502011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3951
3952 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3953 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3954 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3955
841a1577 39562011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3957
3958 * lisp.h (Qdebug): List symbol.
895009e1 3959 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3960 * keyboard.c (debug-on-event): New variable.
3961 (handle_user_signal): Break into debugger when debug-on-event
3962 matches the current signal symbol.
3963
f2d3ba6f
DN
39642011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3965
3966 * alloc.c (check_sblock, check_string_bytes)
3967 (check_string_free_list): Convert to standard C.
3968
42ce4c63
TZ
39692011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3970
3971 * w32.c (emacs_gnutls_push): Fix typo.
3972
825cd63c
EZ
39732011-04-25 Eli Zaretskii <eliz@gnu.org>
3974
fb11d64d
EZ
3975 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3976 "cast to pointer from integer of different size".
3977
825cd63c
EZ
3978 Improve doprnt and its use in verror. (Bug#8545)
3979 * doprnt.c (doprnt): Document the set of format control sequences
3980 supported by the function. Use SAFE_ALLOCA instead of always
3981 using `alloca'.
3982
3983 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3984 is one byte too soon. Don't use xrealloc; instead xfree and
3985 xmalloc anew.
3986
e061a11b
TZ
39872011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3988
3989 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3990 callbacks stage.
3991
3992 * gnutls.c: Renamed global_initialized to
3993 gnutls_global_initialized. Added internals for the
3994 :verify-hostname-error, :verify-error, and :verify-flags
3995 parameters of `gnutls-boot' and documented those parameters in the
3996 docstring. Start callback support.
9173deec
JB
3997 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3998 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3999 on error. Return error code.
e061a11b
TZ
4000 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4001 (emacs_gnutls_read): Likewise.
4002 (Fgnutls_boot): Return handshake error code.
4003 (emacs_gnutls_handle_error): New function.
4004 (wsaerror_to_errno): Likewise.
4005
4006 * w32.h (emacs_gnutls_pull): Add prototype.
4007 (emacs_gnutls_push): Likewise.
4008
4009 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4010 (emacs_gnutls_push): Likewise.
4011
40122011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4013
4014 * process.c (wait_reading_process_output): Check if GnuTLS
4015 buffered some data internally if no FDs are set for TLS
4016 connections.
4017
4018 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4019 (LIBS): Link to USER_LIBS.
4020 ($(BLD)/gnutls.$(0)): New target.
4021
fa6996bc
EZ
40222011-04-24 Eli Zaretskii <eliz@gnu.org>
4023
eb35682e
EZ
4024 * xdisp.c (handle_single_display_spec): Rename the
4025 display_replaced_before_p argument into display_replaced_p, to
4026 make it consistent with the commentary. Fix typos in the
4027 commentary.
4028
e2ad650c
EZ
4029 * textprop.c (syms_of_textprop): Remove dead code.
4030 (copy_text_properties): Delete obsolete commentary about an
4031 interface that was deleted long ago. Fix typos in the description
4032 of arguments.
4033
1b2de274
EZ
4034 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4035 to changes in oldXMenu/XMenu.h from 2011-04-16.
4036 <menu_help_message, prev_menu_help_message>: Constify.
4037 (IT_menu_make_room): menu->help_text is now `const char **';
4038 adjust.
4039
4040 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4041 to changes in oldXMenu/XMenu.h from 2011-04-16.
4042 (struct XMenu): Declare `help_text' `const char **'.
4043
4044 * xfaces.c <Qunspecified>: Make extern again.
4045
4046 * syntax.c: Include sys/types.h before including regex.h, as
4047 required by Posix.
4048
762b15be
EZ
4049 * doc.c (get_doc_string): Improve the format passed to `error'.
4050
4051 * doprnt.c (doprnt): Improve commentary.
4052
4053 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4054
4055 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4056 them with etags.
4057
f1052e5d
EZ
4058 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4059 changes in globals.h immediately force recompilation.
762b15be
EZ
4060 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4061 $(CURDIR)/s/ms-w32.h.
4062 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4063
fa6996bc
EZ
4064 * character.c (Fchar_direction): Function deleted.
4065 (syms_of_character): Don't defsubr it.
4066 <char-direction-table>: Deleted.
4067
e6c3da20
EZ
40682011-04-23 Eli Zaretskii <eliz@gnu.org>
4069
4070 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4071 * doprnt.c: Include limits.h.
4072 (SIZE_MAX): New macro.
04f2d78b
CB
4073 (doprnt): Return a size_t value. 2nd arg is now size_t.
4074 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4075 Improve overflow protection. Support `l' modifier for integer
4076 conversions. Support %l conversion. Don't assume an EMACS_INT
4077 argument for integer conversions and for %c.
4078
4079 * lisp.h (doprnt): Restore prototype.
4080
4081 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4082 $(SRC)/character.h.
4083
4084 * Makefile.in (base_obj): Add back doprnt.o.
4085
4086 * deps.mk (doprnt.o): Add back prerequisites.
4087 (callint.o): Depend on character.h.
4088
4089 * eval.c (internal_lisp_condition_case): Include the handler
4090 representation in the error message.
4091 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4092 when breaking from the loop.
4093
4094 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4095
4096 * callint.c (Fcall_interactively): When displaying error message
4097 about invalid control letter, pass the character's codepoint, not
4098 a pointer to its multibyte form. Improve display of the character
4099 in octal and display also its hex code.
4100
4101 * character.c (char_string): Use %x to display the (unsigned)
4102 codepoint of an invalid character, to avoid displaying a bogus
4103 negative value.
4104
4105 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4106 `error', not SYMBOL_NAME itself.
4107
4108 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4109 character arguments to `error'.
4110
4111 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4112 to `error' in error message about FINAL_CHAR argument. Make sure
4113 FINAL_CHAR is a character, and use %c when it is passed as
4114 argument to `error'.
4115
4ffd0d6b 41162011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4117
4118 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4119
4120 * w32.c: Include <time.h>.
4121 (sys_localtime): New function.
4122
4ffd0d6b 41232011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4124
4125 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4126
4ffd0d6b 4127 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4128
4ffd0d6b 41292011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4130
4ffd0d6b
GM
4131 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4132 zombies (Bug#8467).
aac0c6e3 4133
04c56954
EZ
41342011-04-19 Eli Zaretskii <eliz@gnu.org>
4135
4136 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4137 gl_state.e_property when gl_state.object is Qt.
4138
4139 * insdel.c (make_gap_larger): Remove limitation of buffer size
4140 to <= INT_MAX.
4141
16a43933
CY
41422011-04-18 Chong Yidong <cyd@stupidchicken.com>
4143
4144 * xdisp.c (lookup_glyphless_char_display)
4145 (produce_glyphless_glyph): Handle cons cell entry in
4146 glyphless-char-display.
4147 (Vglyphless_char_display): Document it.
4148
4149 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4150 glyphless-char-display.
4151
4581706e
CY
41522011-04-17 Chong Yidong <cyd@stupidchicken.com>
4153
4154 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4155
4156 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4157
4158 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4159 definition for no-X builds.
4160
4887c6e2 41612011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4162
fd35b6f9
PE
4163 Static checks with GCC 4.6.0 and non-default toolkits.
4164
5c1ccb01
PE
4165 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4166
006c5daa
PE
4167 * process.c (keyboard_bit_set): Define only if SIGIO.
4168 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4169 (send_process): Repair possible setjmp clobbering.
4170
efc736d3
PE
4171 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4172
4e2fe2e6
PE
4173 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4174
f97334a2
PE
4175 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4176
4e75f29d
PE
4177 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4178 Define only if needed.
4179
90efadd1
PE
4180 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4181 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4182 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4183
3c647824
PE
4184 * dispextern.h (struct redisplay_interface): Rename param
4185 to avoid shadowing.
e264f262 4186 * termhooks.h (struct terminal): Likewise.
761383f4 4187 * xterm.c (xembed_send_message): Likewise.
3c647824 4188
b58c5c4a
PE
4189 * insdel.c (make_gap_smaller): Define only if
4190 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4191
cad59032
PE
4192 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4193 it.
4194
c339dc2e
PE
4195 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4196 so that we aren't warned about unused symbols.
4197
91a3e27b
PE
4198 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4199
399c71d3 4200 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4201
8ffc96f5
PE
4202 * xfns.c (x_real_positions): Mark locals as initialized.
4203
eef9bc79
PE
4204 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4205
098db9dd
PE
4206 * xterm.c: Fix problems found by static analysis with other toolkits.
4207 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4208 (x_dispatch_event): Declare static if USE_GTK, and
4209 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4210 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4211 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4212 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4213 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4214
eb18f6cc
PE
4215 * xmenu.c (menu_help_callback): Pointer type fixes.
4216 Use const pointers when pointing at readonly data. Avoid pointer
4217 signedness clashes.
4218 (FALSE): Remove unused macro.
4219 (update_frame_menubar): Remove unused decl.
4220
1fe72bf8
PE
4221 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4222
60d9e1db
PE
4223 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4224 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4225 (single_menu_item): Rename local to avoid shadowing.
4226
39261c26
PE
4227 * keyboard.c (make_lispy_event): Remove unused local var.
4228
018c5e19
PE
4229 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4230 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4231
63d2b86e
PE
4232 * bitmaps: Change bitmaps from unsigned char back to the X11
4233 compatible char. Avoid the old compiler warnings about
4234 out-of-range initializers by using, for example, '\xab' rather
4235 than 0xab.
4236
aefd87e1
PE
4237 * xgselect.c (xgselect_initialize): Check vs interface
4238 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4239
bf501fb9
PE
4240 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4241
e9829fdf
PE
4242 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4243 to read-only memory.
4244
1086c095
PE
4245 * fns.c (vector): Remove; this old hack is no longer needed.
4246
2baccd04 4247 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4248 Remove unused var.
dde42981 4249 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4250
72391843 4251 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4252
436c16df 4253 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4254 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4255 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4256
92bb796d 4257 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4258 (x_term_init): Remove local to avoid shadowing.
92bb796d 4259
764430a3 4260 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4261
4262 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4263 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4264
d1dfb56c
EZ
42652011-04-16 Eli Zaretskii <eliz@gnu.org>
4266
c4354cb4
EZ
4267 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4268
d1dfb56c
EZ
4269 Fix regex.c, syntax.c and friends for buffers > 2GB.
4270 * syntax.h (struct gl_state_s): Declare character position members
4271 EMACS_INT.
4272
4273 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4274
04f2d78b
CB
4275 * textprop.c (verify_interval_modification, interval_of):
4276 Declare arguments EMACS_INT.
d1dfb56c
EZ
4277
4278 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4279 EMACS_INT.
4280
4281 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4282
4283 * indent.c (Fvertical_motion): Local variable it_start is now
4284 EMACS_INT.
4285
4286 * regex.c (re_match, re_match_2, re_match_2_internal)
4287 (bcmp_translate, regcomp, regexec, print_double_string)
4288 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4289 (re_compile_pattern, re_exec): Declare arguments and local
4290 variables `size_t' and `ssize_t' and return values `regoff_t', as
4291 appropriate.
4292 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4293 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4294 <compile_stack_type>: `size' and `avail' are now `size_t'.
4295
4296 * regex.h <regoff_t>: Use ssize_t, not int.
4297 (re_search, re_search_2, re_match, re_match_2): Arguments that
4298 specify buffer/string position and length are now ssize_t and
4299 size_t. Return type is regoff_t.
4300
613052cd
BK
43012011-04-16 Ben Key <bkey76@gmail.com>
4302
4303 * nsfont.m: Fixed bugs in ns_get_family and
4304 ns_descriptor_to_entity that were caused by using free to
4305 deallocate memory blocks that were allocated by xmalloc (via
4306 xstrdup). This caused Emacs to crash when compiled with
4307 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4308 --enable-checking=xmallocoverrun). xfree is now used to
4309 deallocate these memory blocks.
4310
4170f62f 43112011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4312
71b41406
PE
4313 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4314
9587a89d
PE
4315 emacs_write: Accept and return EMACS_INT for sizes.
4316 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4317 et seq.
4318 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4319 Accept and return EMACS_INT.
4320 (emacs_gnutls_write): Return the number of bytes written on
4321 partial writes.
4322 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4323 (emacs_read, emacs_write): Remove check for negative size, as the
4324 Emacs source code has been audited now.
9587a89d
PE
4325 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4326 (emacs_read, emacs_write): Use it.
273a5f82
PE
4327 * process.c (send_process): Adjust to the new signatures of
4328 emacs_write and emacs_gnutls_write. Do not attempt to store
4329 a byte offset into an 'int'; it might overflow.
9587a89d 4330 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4331
3e047f51
PE
4332 * sound.c: Don't assume sizes fit in 'int'.
4333 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4334 Return EMACS_INT, not int.
3e047f51 4335 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4336 Accept EMACS_INT, not int.
4337 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4338 record read return values.
4339
cc39a9db
BK
43402011-04-15 Ben Key <bkey76@gmail.com>
4341
c9d0ec6d
JB
4342 * keyboard.c (Qundefined): Don't declare static since it is used
4343 in nsfns.m.
4344 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4345 static since they are used in nsfont.m.
cc39a9db 4346
6c60eb9f
SM
43472011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4348
4349 * process.c (Qprocessp): Don't declare static.
4350 * lisp.h (Qprocessp): Declare again.
4351
7990b61a
JB
43522011-04-15 Juanma Barranquero <lekktu@gmail.com>
4353
4354 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4355
5d4cb038
PE
43562011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4357
8bd7b830 4358 Improve C-level modularity by making more things 'static'.
cd64ea1d 4359
e3b27b31
PE
4360 Don't publish debugger-only interfaces to other modules.
4361 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4362 (verify_bytepos, count_markers): Move decls to the only modules
4363 that need them.
4364 * region-cache.h (pp_cache): Likewise.
4365 * window.h (check_all_windows): Likewise.
4366 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4367
5d4cb038
PE
4368 * sysdep.c (croak): Now static, if
4369 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4370 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4371
4372 * alloc.c (refill_memory_reserve): Now static if
4373 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4374 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4375
e87b6180
PE
4376 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4377 Define only if USE_LUCID.
4378
ac64929e
PE
4379 * xrdb.c (x_customization_string, x_rm_string): Now static.
4380
6f37259d
PE
4381 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4382 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4383
1683e3ab
PE
4384 * xdisp.c (draw_row_with_mouse_face): Now static.
4385 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4386
de9c2632
PE
4387 * window.h (check_all_windows): Mark externally visible.
4388
2b96acb7
PE
4389 * window.c (window_deletion_count): Now static.
4390
4391 * undo.c: Make symbols static if they're not exported.
4392 (last_undo_buffer, last_boundary_position, pending_boundary):
4393 Now static.
4394
50436f33
PE
4395 * textprop.c (interval_insert_behind_hooks): Now static.
4396 (interval_insert_in_front_hooks): Likewise.
4397
64520e5c
PE
4398 * term.c: Make symbols static if they're not exported.
4399 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4400 (max_frame_lines, tty_set_terminal_modes):
4401 (tty_reset_terminal_modes, tty_turn_off_highlight):
4402 (get_tty_terminal): Now static.
4403 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4404 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4405 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4406 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4407 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4408
1fa53021
PE
4409 * sysdep.c: Make symbols static if they're not exported.
4410 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4411 Now static.
4412 (sigprocmask_set, full_mask): Remove; unused.
4413 (wait_debugging): Mark as visible.
4414 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4415 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4416
d4b43b22
PE
4417 * syntax.c (syntax_temp): Define only if !__GNUC__.
4418
b7c513d0
PE
4419 * sound.c (current_sound_device, current_sound): Now static.
4420
989b29ad
PE
4421 * search.c (searchbufs, searchbuf_head): Now static.
4422
13a55a78
PE
4423 * scroll.c (scroll_cost): Remove; unused.
4424 * dispextern.h (scroll_cost): Remove decl.
4425
de68a1fc
PE
4426 * region-cache.h (pp_cache): Mark as externally visible.
4427
40ccffa6
PE
4428 * process.c: Make symbols static if they're not exported.
4429 (process_tick, update_tick, create_process, chan_process):
4430 (Vprocess_alist, proc_buffered_char, datagram_access):
4431 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4432 (deactivate_process): Mark defn as static, as well as decl.
4433 * lisp.h (create_process): Remove decl.
4434 * process.h (chan_process, Vprocess_alist): Remove decls.
4435
ad64fc97
PE
4436 * print.c: Make symbols static if they're not exported.
4437 (print_depth, new_backquote_output, being_printed, print_buffer):
4438 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4439 (print_interval, print_number_index, initial_stderr_stream):
4440 Now static.
4441 * lisp.h (Fprinc): Remove decl.
4442 (debug_output_compilation_hack): Mark as externally visible.
4443
adddb265
PE
4444 * sysdep.c (croak): Move decl from here to syssignal.h.
4445 * syssignal.h (croak): Put it here, so the API can be checked when
4446 'croak' is called from dissociate_if_controlling_tty.
4447
1717ede2
PE
4448 * minibuf.c: Make symbols static if they're not exported.
4449 (minibuf_save_list, choose_minibuf_frame): Now static.
4450 * lisp.h (choose_minibuf_frame): Remove decl.
4451
fa5fb2bc
PE
4452 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4453
1e3890d1
PE
4454 * lread.c: Make symbols static if they're not exported.
4455 (read_objects, initial_obarray, oblookup_last_bucket_number):
4456 Now static.
4457 (make_symbol): Remove; unused.
4458 * lisp.h (initial_obarray, make_symbol): Remove decls.
4459
8a1414fa
PE
4460 * keyboard.c: Make symbols static if they're not exported.
4461 (single_kboard, recent_keys_index, total_keys, recent_keys):
4462 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4463 (this_single_command_key_start, echoing, last_auto_save):
4464 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4465 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4466 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4467 (Vlispy_mouse_stem, double_click_count):
4468 Now static.
4469 (force_auto_save_soon): Define only if SIGDANGER.
4470 (ignore_mouse_drag_p): Now static if
4471 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4472 (print_help): Remove; unused.
4473 (stop_character, last_timer_event): Mark as externally visible.
4474 * keyboard.h (ignore_mouse_drag_p): Declare only if
4475 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4476 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4477 * lisp.h (echoing): Remove decl.
4478 (force_auto_save_soon): Declare only if SIGDANGER.
4479 * xdisp.c (redisplay_window): Simplify code, to make it more
4480 obvious that ignore_mouse_drag_p is not accessed if !defined
4481 USE_GTK && !defined HAVE_NS.
4482
93ea6e8f
PE
4483 * intervals.c: Make symbols static if they're not exported.
4484 (merge_properties_sticky, merge_interval_right, delete_interval):
4485 Now static.
4486 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4487
77382fcc
PE
4488 * insdel.c: Make symbols static if they're not exported.
4489 However, leave prepare_to_modify_buffer alone. It's never
4490 called from outside this function, but that appears to be a bug.
4491 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4492 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4493 (adjust_after_replace_noundo): Remove; unused.
4494 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4495 (signal_before_change): Remove decls.
77382fcc 4496
9306c32e
PE
4497 * indent.c (val_compute_motion, val_vmotion): Now static.
4498
cd44d2eb
PE
4499 * image.c: Make symbols static if they're not exported.
4500 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4501 if USE_GTK.
4502 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4503 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4504
ad9a7a06
PE
4505 * fringe.c (standard_bitmaps): Now static.
4506 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4507
81626931
PE
4508 * frame.c: Make symbols static if they're not exported.
4509 (x_report_frame_params, make_terminal_frame): Now static.
4510 (get_frame_param): Now static, unless HAVE_NS.
4511 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4512 (x_get_resource_string): Remove; not used.
4513 * frame.h (make_terminal_frame, x_report_frame_params):
4514 (x_get_resource_string); Remove decls.
4515 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4516 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4517
239f9db9
PE
4518 * font.c, fontset.c: Make symbols static if they're not exported.
4519 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4520 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4521 * font.c (font_close_object): Now static.
4522 * font.h (font_close_object): Remove.
4523 * fontset.c (FONTSET_OBJLIST): Remove.
4524 (free_realized_fontset) #if-0 the body, which does nothing.
4525 (face_suitable_for_char_p): #if-0, as it's never called.
4526 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4527 * xfaces.c (face_at_string_position):
4528 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4529 since 0 is always ASCII.
4530
dfcf3579
PE
4531 * fns.c (weak_hash_tables): Now static.
4532
5045092b
PE
4533 * fileio.c: Make symbols static if they're not exported.
4534 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4535 (Vwrite_region_annotation_buffers): Now static.
4536
57a96f5c
PE
4537 * eval.c: Make symbols static if they're not exported.
4538 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4539 * lisp.h (backtrace_list): Remove decl.
4540
35f08c38
PE
4541 * emacs.c: Make symbols static if they're not exported.
4542 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4543 (fatal_error_code, fatal_error_signal_hook, standard_args):
4544 Now static.
4545 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4546 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4547 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4548 * lisp.h (fatal_error_signal_hook): Remove decl.
4549 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4550
f44bd759
PE
4551 * editfns.c: Move a (normally-unused) function to its only use.
4552 * editfns.c, lisp.h (get_operating_system_release): Remove.
4553 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4554 worth the hassle of breaking this out.
4555
b532497d
PE
4556 * xterm.c: Make symbols static if they're not exported.
4557 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4558 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4559 (x_destroy_window, x_delete_display):
4560 Now static.
4561 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4562 (x_mouse_leave): Remove; unused.
4563 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4564 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4565 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4566 Remove decls.
4567 (x_mouse_leave): Declare only if WINDOWSNT.
4568 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4569 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4570 USE_X_TOOLKIT.
4571
1675728f
PE
4572 * ftxfont.c: Make symbols static if they're not exported.
4573 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4574 HAVE_FREETYPE.
4575 * font.h (ftxfont_driver): Likewise.
4576
e4cebfca
PE
4577 * xfns.c: Make symbols static if they're not exported.
4578 (x_last_font_name, x_display_info_for_name):
4579 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4580 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4581 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4582 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4583 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4584 (last_show_tip_args): Now static.
4585 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4586 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4587 (x_screen_planes): Remove; unused.
4588 * dispextern.h (x_screen_planes): Remove decl.
4589
5bf46f05
PE
4590 * dispnew.c: Make symbols static if they're not exported.
4591 * dispextern.h (redraw_garbaged_frames, scrolling):
4592 (increment_row_positions): Remove.
4593 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4594 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4595 Now static.
4596 (redraw_garbaged_frames): Remove; unused.
4597
435f4c28
PE
4598 * xfaces.c: Make symbols static if they're not exported.
4599 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4600 Remove decls.
4601 * xterm.h (defined_color): Remove decls.
4602 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4603 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4604 (menu_face_changed_default, defined_color, free_realized_face):
4605 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4606 (ascii_face_of_lisp_face): Remove; unused.
4607
8524aef3
PE
4608 * xdisp.c: Make symbols static if they're not exported.
4609 * dispextern.h (scratch_glyph_row, window_box_edges):
4610 (glyph_to_pixel_coords, set_cursor_from_row):
4611 (get_next_display_element, set_iterator_to_next):
4612 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4613 (show_mouse_face): Remove decls
4614 * frame.h (message_buf_print): Likewise.
4615 * lisp.h (pop_message, set_message, check_point_in_composition):
4616 Likewise.
4617 * xterm.h (set_vertical_scroll_bar): Likewise.
4618 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4619 (message_buf_print, scratch_glyph_row, displayed_buffer):
4620 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4621 (get_next_display_element, show_mouse_face, window_box_edges):
4622 (frame_to_window_pixel_xy, check_point_in_composition):
4623 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4624 (glyph_to_pixel_coords): Remove; unused.
4625
16390cd2
PE
4626 * dired.c (file_name_completion): Now static.
4627
4628 * dbusbind.c (xd_in_read_queued_messages): Now static.
4629
a25f4dfa
PE
4630 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4631 * data.c (circular_list_error): Remove.
4632
14a9c8df
PE
4633 * commands.h (last_point_position, last_point_position_buffer):
4634 (last_point_position_window): Remove decls.
4635 * keyboard.c: Make these variables static.
4636
04f2d78b
CB
4637 * coding.h (coding, code_convert_region, encode_coding_gap):
4638 Remove decls.
74ab6df5
PE
4639 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4640 (iso_code_class, detect_coding, code_convert_region): Now static.
4641 (encode_coding_gap): Remove; unused.
4642
38dfbee1
PE
4643 * chartab.c (chartab_chars, chartab_bits): Now static.
4644
a2cb4e63
PE
4645 * charset.h (charset_iso_8859_1): Remove decl.
4646 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4647 Now static.
4648
127198fd
PE
4649 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4650 * ccl.c (Vccl_program_table): Now static.
4651 (check_ccl_update): Remove; unused.
4652
d85b608f
PE
4653 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4654 * category.h: ... from here.
4655 * category.c (check_category_table, set_category_set): Now static.
4656
31cd66f3
PE
4657 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4658 * lisp.h: Remove these decls.
4659
c358e587
PE
4660 * buffer.c (buffer_count): Remove unused var.
4661
e78aecca
PE
4662 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4663 so that it's not optimized away.
4664 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4665 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4666 exported only to the debugger.
4667
e192d7d3 4668 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4669 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4670
92470028
PE
4671 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4672 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4673 was inaccessible from Lisp.
4674 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4675 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4676
244ed907
PE
4677 alloc.c: Import and export fewer symbols, and remove unused items.
4678 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4679 is defined.
4680 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4681 it's not optimized away by whole-program optimization.
4682 (message_enable_multibyte, free_misc): Remove.
4683 (catchlist, handlerlist, mark_backtrace):
4684 Declare only if BYTE_MARK_STACK.
4685 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4686 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4687 (message_enable_multibyte): Remove decl.
4688 (free_misc, interval_free_list, float_block, float_block_index):
4689 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4690 (cons_free_list, last_marked_index):
4691 Now static.
4692 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4693 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4694 (mark_backtrace): Define only if BYTE_MARK_STACK.
4695 * xdisp.c (message_enable_multibyte): Now static.
4696
61c2b50e 4697 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4698 This makes it easier for human readers (and static analyzers)
4699 to see whether these variables are used from other modules.
4700 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4701 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4702 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4703 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4704 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4705 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4706 * xmenu.c, xselect.c:
4707 Declare Q* vars static if they are not used in other modules.
4708 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4709 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4710 Remove decls of unexported vars.
4711 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4712
95c82688
PE
4713 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4714
16a97296
PE
4715 Make Emacs functions such as Fatom 'static' by default.
4716 This makes it easier for human readers (and static analyzers)
4717 to see whether these functions can be called from other modules.
4718 DEFUN now defines a static function. To make the function external
4719 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4720 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4721 (Finit_image_library):
16a97296
PE
4722 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4723 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4724 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4725 Remove decls, since these functions are now static.
4726 (Funintern, Fget_internal_run_time): New decls, since these functions
4727 were already external.
95c82688 4728
16a97296
PE
4729 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4730 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4731 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4732 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4733 * keyboard.c, keymap.c, lread.c:
4734 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4735 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4736 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4737 Mark functions with DEFUE instead of DEFUN,
4738 if they are used in other modules.
4739 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4740 decls for now-static functions.
4741 * buffer.h (Fdelete_overlay): Remove decl.
4742 * callproc.c (Fgetenv_internal): Mark as internal.
4743 * composite.c (Fremove_list_of_text_properties): Remove decl.
4744 (Fcomposition_get_gstring): New forward static decl.
4745 * composite.h (Fcomposite_get_gstring): Remove decl.
4746 * dired.c (Ffile_attributes): New forward static decl.
4747 * doc.c (Fdocumntation_property): New forward static decl.
4748 * eval.c (Ffetch_bytecode): New forward static decl.
4749 (Funintern): Remove extern decl; now in .h file where it belongs.
4750 * fileio.c (Fmake_symbolic_link): New forward static decl.
4751 * image.c (Finit_image_library): New forward static decl.
4752 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4753 * intervals.h (Fprevious_property_change):
4754 (Fremove_list_of_text_properties): Remove decls.
4755 * keyboard.c (Fthis_command_keys): Remove decl.
4756 (Fcommand_execute): New forward static decl.
4757 * keymap.c (Flookup_key): New forward static decl.
4758 (Fcopy_keymap): Now static.
4759 * keymap.h (Flookup_key): Remove decl.
4760 * process.c (Fget_process): New forward static decl.
4761 (Fprocess_datagram_address): Mark as internal.
4762 * syntax.c (Fsyntax_table_p): New forward static decl.
4763 (skip_chars): Remove duplicate decl.
4764 * textprop.c (Fprevious_property_change): New forward static decl.
4765 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4766 Now internal.
4767 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4768 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4769
785bbd42
PE
4770 * editfns.c (Fformat): Remove unreachable code.
4771
8b913b57
AS
47722011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4773
4774 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4775 change. (Bug#8496)
4776
a6744a35
EZ
47772011-04-13 Eli Zaretskii <eliz@gnu.org>
4778
4779 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4780 when at ZV. (Bug#8487)
4781
e7974947
AS
47822011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4783
baad03f0
AS
4784 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4785 (Bug#8437)
4786 * keyboard.c (parse_tool_bar_item): Likewise.
4787 * sound.c (sound_cleanup, alsa_close): Likewise.
4788 * termcap.c (tgetent): Likewise.
4789 * xfns.c (x_default_font_parameter): Likewise.
4790 * xsettings.c (read_and_apply_settings): Likewise.
4791
e7974947
AS
4792 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4793 (overrun_check_free): Protoize.
4794
28272684
PE
47952011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4796
4797 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4798 since callers should never pass a negative size.
4799 Change the signature to match that of plain 'read' and 'write'; see
4800 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4801 * lisp.h: Update prototypes of emacs_write and emacs_read.
4802
11997c76
EZ
48032011-04-11 Eli Zaretskii <eliz@gnu.org>
4804
4805 * xdisp.c (redisplay_window): Don't try to determine the character
4806 position of the scroll margin if the window start point w->startp
e896f03c 4807 is outside the buffer's accessible region. (Bug#8468)
11997c76 4808
8a2cbd72
EZ
48092011-04-10 Eli Zaretskii <eliz@gnu.org>
4810
4811 Fix write-region and its subroutines for buffers > 2GB.
4812 * fileio.c (a_write, e_write): Modify declaration of arguments and
4813 local variables to support buffers larger than 2GB.
4814 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4815
4816 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4817 argument, local variables, and return value.
4818
4819 * lisp.h: Update prototypes of emacs_write and emacs_read.
4820
4821 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4822
4073e537 48232011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4824
1ebfdcb6
PE
4825 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4826
b2ded58d
PE
4827 Fix more problems found by GCC 4.6.0's static checks.
4828
7d66342c
PE
4829 * xdisp.c (vmessage): Use a better test for character truncation.
4830
bbf47d44
PE
4831 * charset.c (load_charset_map): <, not <=, for optimization,
4832 and to avoid potential problems with integer overflow.
9248994d 4833 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4834 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4835 * editfns.c (Fformat): Likewise.
1e69125e 4836 * syntax.c (skip_chars): Likewise.
3befa583 4837
e3019616
PE
4838 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4839 This also lets GCC 4.6.0 generate slightly better loop code.
4840
becfa255
PE
4841 * callint.c (Fcall_interactively): <, not <=, for optimization.
4842 (Fcall_interactively): Count the number of arguments produced,
4843 not the number of arguments given. This is simpler and lets GCC
4844 4.6.0 generate slightly better code.
4845
dae0cd48
PE
4846 * ftfont.c: Distingish more carefully between FcChar8 and char.
4847 The previous code passed unsigned char * to a functions like
4848 strlen and xstrcasecmp that expect char *, which does not
4849 conform to the C standard.
4850 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4851 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4852 char * when the C standard requires it.
4853
76032d70
PE
4854 * keyboard.c (read_char): Remove unused var.
4855
eb3f1cc8
PE
4856 * eval.c: Port to Windows vsnprintf (Bug#8435).
4857 Include <limits.h>.
4858 (SIZE_MAX): Define if the headers do not.
4859 (verror): Do not give up if vsnprintf returns a negative count.
4860 Instead, grow the buffer. This ports to Windows vsnprintf, which
4861 does not conform to C99. Problem reported by Eli Zaretskii.
4862 Also, simplify the allocation scheme, by avoiding the need for
4863 calling realloc, and removing the ALLOCATED variable.
4864
70476b54
PE
4865 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4866
12020a9e
PE
4867 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4868 But keep the doprint source code for now, as we might revamp it
4869 and use it again (Bug#8435).
ea6c7ae6
PE
4870 * lisp.h (doprnt): Remove.
4871 * Makefile.in (base_obj): Remove doprnt.o.
4872 * deps.mk (doprnt.o): Remove.
4873
5fdb398c
PE
4874 error: Print 32- and 64-bit integers portably (Bug#8435).
4875 Without this change, on typical 64-bit hosts error ("...%d...", N)
4876 was used to print both 32- and 64-bit integers N, which relied on
4877 undefined behavior.
4878 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4879 New macro.
4880 * lisp.h (error, verror): Mark as printf-like functions.
4881 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4882 Report overflow in size calculations when allocating printf buffer.
4883 Do not truncate output string at its first null byte.
4884 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4885 Truncate the output at a character boundary, since vsnprintf does not
4886 do that.
4887 * charset.c (check_iso_charset_parameter): Convert internal
4888 character to string before calling 'error', since %c now has the
4889 printf meaning.
4890 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4891 overflow when computing char to be passed to 'error'. Do not
4892 pass Lisp_Object to 'error'; pass the integer instead.
4893 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4894 formatted with plain %d.
4895
b189fa66
PE
4896 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4897
bff87ef0
PE
4898 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4899
7e2cac20
PE
4900 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4901
ce4d90b5
PE
4902 * xterm.c (x_catch_errors): Remove duplicate declaration.
4903
266c9547
PE
4904 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4905
79c49ad2
PE
4906 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4907
368f4090
JM
49082011-04-10 Jim Meyering <meyering@redhat.com>
4909
4910 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4911 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4912 return ssize_t not "int", and use size_t as the buffer length.
4913 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4914 * gnutls.h: Update declarations.
4915 * process.c (read_process_output): Use ssize_t, to match.
4916 (send_process): Likewise.
4917
a32d4040
CY
49182011-04-09 Chong Yidong <cyd@stupidchicken.com>
4919
4920 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4921
8546720e 49222011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4923
04f2d78b
CB
4924 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4925 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4926
8546720e
GM
4927 * xterm.c (handle_one_xevent):
4928 * xmenu.c (create_and_show_popup_menu):
4929 * xselect.c (x_decline_selection_request)
4930 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4931
0a2f5c1a 49322011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4933
4934 Fix some uses of `int' instead of EMACS_INT.
4935 * search.c (string_match_1, fast_string_match)
4936 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4937 (scan_buffer, find_next_newline_no_quit)
4938 (find_before_next_newline, search_command, Freplace_match)
4939 (Fmatch_data): Make some `int' variables be EMACS_INT.
4940
4941 * xdisp.c (display_count_lines): 3rd argument and return value now
4942 EMACS_INT. All callers changed.
4943 (pint2hrstr): Last argument is now EMACS_INT.
4944
4945 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4946 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4947 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4948 (decode_coding_utf_16, decode_coding_emacs_mule)
4949 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4950 (decode_coding_ccl, decode_coding_charset)
4951 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4952 (decode_coding_iso_2022, decode_coding_emacs_mule)
4953 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4954 <char_offset, last_offset>: Declare EMACS_INT.
4955 (encode_coding_utf_8, encode_coding_utf_16)
4956 (encode_coding_emacs_mule, encode_invocation_designation)
4957 (encode_designation_at_bol, encode_coding_iso_2022)
4958 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4959 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4960 Declare EMACS_INT.
4961 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4962 (encode_invocation_designation): Last argument P_NCHARS is now
4963 EMACS_INT.
4964 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4965 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4966
4967 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4968 All users changed.
4969
4970 * ccl.c (Fccl_execute_on_string): Declare some variables
4971 EMACS_INT.
4972
8546720e 49732011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4974
4975 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4976
4e19a977
CS
49772011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4978
4979 * process.c (Fformat_network_address): Doc fix.
4980
87302331
R
49812011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4982
4983 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4984
cbb59342
CY
49852011-04-08 Chong Yidong <cyd@stupidchicken.com>
4986
4987 * keyboard.c (read_char): Call Lisp function help-form-show,
4988 instead of using internal_with_output_to_temp_buffer.
4989 (Qhelp_form_show): New var.
e0d38eeb 4990 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4991
4992 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4993
4994 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4995
e67a13ab
CY
49962011-04-06 Chong Yidong <cyd@stupidchicken.com>
4997
04f2d78b
CB
4998 * process.c (Flist_processes): Remove to Lisp.
4999 (list_processes_1): Delete.
e67a13ab 5000
973f782d
EZ
50012011-04-06 Eli Zaretskii <eliz@gnu.org>
5002
7c106b1e
EZ
5003 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5004
973f782d
EZ
5005 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5006
41cf7d1a 50072011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5008
ca23cc88
PE
5009 Fix more problems found by GCC 4.6.0's static checks.
5010
f390e2d5
PE
5011 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5012
42eea0d0
PE
5013 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5014
b69769da 5015 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5016
f9541e84
PE
5017 * xdisp.c (vmessage): Mark as a printf-like function.
5018
13841b55
PE
5019 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5020
c136c10f
PE
5021 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5022
5e2d4a30
PE
5023 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5024 printf-like functions.
5025 (tiff_load): Add casts to remove these marks before passing them
5026 to system-supplied API.
5027
583f48b9
PE
5028 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5029
b25d760e
PE
5030 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5031 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5032 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5033 directly, rather than having caller test rule sign. This avoids
5034 some unnecessary tests.
5035 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5036 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5037 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5038
bc7b6697 5039 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5040 (xfont_open): Avoid unnecessary tests.
bc7b6697 5041
27ccc379
PE
5042 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5043
dcd5c89a
PE
5044 * composite.h, composite.c (composition_gstring_put_cache):
5045 Use EMACS_INT, not int, for length.
5046
b13a45c6
PE
5047 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5048 breaking out part of COMPOSITION_DECODE_RULE.
5049 (COMPOSITION_DECODE_RULE): Use it.
5050 * composite.c (get_composition_id): Remove unused local vars,
5051 by using the new macro.
5052
1e792e4d
PE
5053 * textprop.c (set_text_properties_1): Change while to do-while,
5054 since the condition is always true at first.
5055
dc6c6455 5056 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5057 (interval_deletion_adjustment): Return unsigned value.
5058 All uses changed.
dc6c6455 5059
aba7731a
PE
5060 * process.c (list_processes_1, create_pty, read_process_output):
5061 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5062 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5063 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5064 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5065 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5066
fdfc4bf3
PE
5067 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5068
fca8fe46 5069 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5070 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5071
06a0259a 5072 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5073 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5074 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5075
e7b9e80f
PE
5076 * print.c (print_error_message): Avoid int overflow.
5077
56201685
PE
5078 * font.c (font_list_entities): Redo for clarity,
5079 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5080
78834453 5081 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5082 (font_score): Avoid potential overflow in diff calculation.
78834453 5083
0bc0b309 5084 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5085 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5086
e610eaca
PE
5087 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5088
b895abce
PE
5089 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5090 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5091 can always succeed if overflow has undefined behavior.
5092
1f1d9321 5093 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5094 (wordify): Omit three unnecessary tests.
1f1d9321 5095
c59478bc
PE
5096 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5097 All callers changed. This avoids the need for an unused var.
5098
79b73827
PE
5099 * casefiddle.c (casify_region): Remove var that is set but not used.
5100
a4db5dfe
PE
5101 * dired.c (file_name_completion): Remove var that is set but not used.
5102
43aae36e
PE
5103 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5104
2a47c44d 5105 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5106 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5107
a37c69bf
PE
5108 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5109 Check for integer overflow on size calculations.
5110
328ab8e7
PE
5111 * buffer.c (Fprevious_overlay_change): Remove var that is set
5112 but not used.
5113
e5a2a5cb
PE
5114 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5115 Remove vars that are set but not used.
8d84a6eb 5116 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5117 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5118
a60e5f68
PE
5119 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5120
f661cb61 5121 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5122 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5123
f0397f5a
PE
5124 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5125 that are set but not used.
5126
8664db06 5127 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5128 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5129
6abdaa4a
PE
5130 * xselect.c (x_get_local_selection, x_handle_property_notify):
5131 Remove vars that are set but not used.
5132
0ce7538d 5133 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5134 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5135
9ae848fc
PE
5136 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5137 Remove var that is set but not used.
0b918413
PE
5138 (scroll_bar_windows_size): Now size_t, not int.
5139 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5140 Check for overflow.
9ae848fc 5141
a5a62657
PE
5142 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5143 (map_tty_color) [!defined MSDOS]: Likewise.
5144
5c5cdd39
PE
5145 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5146
66ebf983
PE
5147 * coding.c: Remove vars that are set but not used.
5148 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5149 All callers changed.
5150 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5151 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5152 (decode_coding_charset): Remove vars that are set but not used.
5153
1be4d761
PE
5154 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5155 that is set but not used.
5156
47553fa8
PE
5157 * print.c (print_object): Remove var that is set but not used.
5158
1f7196bf 5159 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5160 The gnulib version avoids calling malloc in the usual case,
5161 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5162 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5163 * filelock.c (current_lock_owner): Likewise.
5164 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5165 * sysdep.c: Include allocator.h, careadlinkat.h.
5166 (emacs_no_realloc_allocator): New static constant.
5167 (emacs_readlink): New function.
fdb61804
PE
5168 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5169 ../lib/careadlinkat.h.
d1fdcab7 5170
f84c17c7
SM
51712011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5172
5173 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5174 first non-nil return value).
5175
ef3862ad
JD
51762011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5177
5178 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5179 if not defined (Bug#8403).
5180
376a7006
JB
51812011-04-02 Juanma Barranquero <lekktu@gmail.com>
5182
5183 * xdisp.c (display_count_lines): Remove parameter `start',
5184 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5185 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5186 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5187 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5188 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5189 and thereabouts. All callers changed.
5190 (get_per_char_metric): Remove parameter `f', unused since
5191 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5192
6ca3801d
JM
51932011-04-02 Jim Meyering <meyering@redhat.com>
5194
5195 do not dereference NULL upon failed strdup
5196 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5197 (ns_get_family): Likewise.
5198
d8e2b5ba
JB
51992011-04-02 Juanma Barranquero <lekktu@gmail.com>
5200
5201 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5202
8c74fcbd
JD
52032011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5204
5205 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5206 later (Bug#8403).
5207
7200d79c
SM
52082011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5209
03408648 5210 Add lexical binding.
7200d79c 5211
03408648
SM
5212 * window.c (Ftemp_output_buffer_show): New fun.
5213 (Fsave_window_excursion):
5214 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5215
5216 * lread.c (lisp_file_lexically_bound_p): New function.
5217 (Fload): Bind Qlexical_binding.
5218 (readevalloop): Remove `evalfun' arg.
5219 Bind Qinternal_interpreter_environment.
5220 (Feval_buffer): Bind Qlexical_binding.
5221 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5222 Mark as dynamic.
5223 (syms_of_lread): Declare `lexical-binding'.
5224
5225 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5226
5227 * keyboard.c (eval_dyn): New fun.
5228 (menu_item_eval_property): Use it.
ca105506
SM
5229
5230 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5231
03408648
SM
5232 * fns.c (concat, mapcar1): Accept byte-code-functions.
5233
5234 * eval.c (Fsetq): Handle lexical vars.
5235 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5236 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5237 (FletX, Flet): Obey lexical binding.
5238 (Fcommandp): Handle closures.
5239 (Feval): New `lexical' arg.
5240 (eval_sub): New function extracted from Feval. Use it almost
5241 everywhere where Feval was used. Look up vars in lexical env.
5242 Handle closures.
5243 (Ffunctionp): Move from subr.el.
5244 (Ffuncall): Handle closures.
5245 (apply_lambda): Remove `eval_flags'.
5246 (funcall_lambda): Handle closures and new byte-code-functions.
5247 (Fspecial_variable_p): New function.
5248 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5249 but without exporting it to Lisp.
23aba0ea 5250
23aba0ea 5251 * doc.c (Fdocumentation, store_function_docstring):
03408648 5252 * data.c (Finteractive_form): Handle closures.
23aba0ea 5253
03408648
SM
5254 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5255 interactive spec.
ba83908c 5256
04f2d78b
CB
5257 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5258 New byte-codes.
03408648
SM
5259 (exec_byte_code): New function extracted from Fbyte_code to handle new
5260 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5261
03408648 5262 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5263
03408648 5264 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5265
e2abce01
JB
52662011-03-31 Juanma Barranquero <lekktu@gmail.com>
5267
5268 * xdisp.c (redisplay_internal): Fix prototype.
5269
63696a73 52702011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5271
63696a73 5272 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5273 (try_scrolling): Use it when setting scroll_limit.
5274 Limit scrolling to 100 screen lines.
63696a73
EZ
5275 (redisplay_window): Even when falling back on "recentering",
5276 position point in the window according to scroll-conservatively,
5277 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5278
5279 (try_scrolling): When point is above the window, allow searching
5280 as far as scroll_max, or one screenful, to compute vertical
5281 distance from PT to the scroll margin position. This prevents
5282 try_scrolling from unnecessarily failing when
5283 scroll-conservatively is set to a value slightly larger than the
5284 window height. Clean up the case of PT below the margin at bottom
5285 of window: scroll_max can no longer be INT_MAX. When aggressive
5286 scrolling is in use, don't let point enter the opposite scroll
5287 margin as result of the scroll.
5288 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5289 threshold of 100 lines for never-recentering scrolling.
5290
e4cc2dfc
JB
52912011-03-31 Juanma Barranquero <lekktu@gmail.com>
5292
5293 * dispextern.h (move_it_by_lines):
5294 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5295 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5296 (message_log_check_duplicate): Remove parameters `prev_bol' and
5297 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5298 (redisplay_internal): Remove parameter `preserve_echo_area',
5299 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5300
5301 * indent.c (Fvertical_motion):
5302 * window.c (window_scroll_pixel_based, Frecenter):
5303 Don't pass `need_y_p' to `move_it_by_lines'.
5304
1c470562
SM
53052011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5306
44f230aa
SM
5307 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5308 steal a few bits to be more compact.
5309 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5310 Remove unneeded casts.
5311
1c470562
SM
5312 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5313
888adce9
ZK
53142011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5315
5316 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5317 binding" message (bug#7967).
5318
f838ed7b
PE
53192011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5320
77861b95
PE
5321 Fix more problems found by GCC 4.6.0's static checks.
5322
de6dbc14
PE
5323 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5324 Remove unused local var.
5325
f838ed7b
PE
5326 * editfns.c (Fmessage_box): Remove unused local var.
5327
792c7b2b
PE
5328 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5329 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5330 Omit unused local vars.
c499e557 5331 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5332 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5333 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5334 Omit unused local var.
5335
ba0165e1
PE
5336 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5337 Don't assume string length fits in int.
32ad8845 5338 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5339 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5340
3c59b4c9
PE
5341 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5342 instead of alloca (Bug#8344).
5343
a3eed478 5344 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5345 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5346
eb4d412d
PE
5347 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5348
1658b401
PE
5349 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5350 concerns.
5351
5352 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5353
5354 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5355
9a2c6e05
PE
5356 * keyboard.c (syms_of_keyboard): Use the same style as later
5357 in this function when indexing through an array. This also
5358 works around GCC bug 48267.
5359
03d0a109
PE
5360 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5361
44f730c8
PE
5362 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5363
fe75f926
PE
5364 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5365 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5366
ffa8c828
PE
5367 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5368 This avoids undefined behavior on integer overflow, and is a bit
5369 more convenient anyway since it is compared to a size_t variable.
5370
c5101a77
PE
5371 Variadic C functions now count arguments with size_t, not int.
5372 This avoids an unnecessary limitation on 64-bit machines, which
5373 caused (substring ...) to crash on large vectors (Bug#8344).
5374 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5375 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5376 All variadic functions and their callers changed accordingly.
c5101a77
PE
5377 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5378 * data.c (arith_driver, float_arith_driver): Likewise.
5379 * editfns.c (general_insert_function): Likewise.
5380 * eval.c (struct backtrace.nargs, interactive_p)
5381 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5382 (funcall_lambda, mark_backtrace): Likewise.
5383 * fns.c (concat): Likewise.
5384 * frame.c (x_set_frame_parameters): Likewise.
5385 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5386 0 if not found, not -1. All callers changed.
5387
dd3f25f7
PE
5388 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5389 (stack_copy_size): Now size_t, not int.
5390 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5391
461c2ab9
JB
53922011-03-28 Juanma Barranquero <lekktu@gmail.com>
5393
5394 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5395 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5396 All callers changed.
5397
5398 * lisp.h (multibyte_char_to_unibyte):
5399 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5400 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5401 * character.h (CHAR_TO_BYTE8):
5402 * cmds.c (internal_self_insert):
5403 * editfns.c (general_insert_function):
5404 * keymap.c (push_key_description):
5405 * search.c (Freplace_match):
5406 * xdisp.c (message_dolog, set_message_1): All callers changed.
5407
f6d62986
SM
54082011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5409
5410 * keyboard.c (safe_run_hook_funcall): New function.
5411 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5412 don't set the hook to nil, but remove the offending function instead.
5413 (Qcommand_hook_internal): Remove, unused.
5414 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5415 Vcommand_hook_internal.
5416
5417 * eval.c (enum run_hooks_condition): Remove.
5418 (funcall_nil, funcall_not): New functions.
5419 (run_hook_with_args): Call each function through a `funcall' argument.
5420 Remove `cond' argument, now redundant.
5421 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5422 (Frun_hook_with_args_until_failure): Adjust accordingly.
5423 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5424
1db5b1ad
JB
54252011-03-28 Juanma Barranquero <lekktu@gmail.com>
5426
5427 * dispextern.h (string_buffer_position): Remove declaration.
5428
5429 * print.c (strout): Remove parameter `multibyte', unused since
5430 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5431
5432 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5433 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5434 All callers changed.
5435
5436 * w32.c (_wsa_errlist): Use braces for struct initializers.
5437
5438 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5439 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5440 All callers changed.
5441 (string_buffer_position): Likewise. Also, make static (it's never
5442 used outside xdisp.c).
5443 (cursor_row_p): Remove parameter `w', unused since
5444 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5445 (decode_mode_spec): Remove parameter `precision', introduced during
5446 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5447 All callers changed.
5448
5ffb62aa
JD
54492011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5450
5451 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5452
461c2ab9 54532011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5454
5455 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5456 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5457 (ns_update_auto_hide_menu_bar): New functions.
5458 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5459 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5460 ns_constrain_all_frames.
5461 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5462 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5463
5c380ffb
JD
54642011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5465
5466 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5467
9af30bdf
GM
54682011-03-27 Glenn Morris <rgm@gnu.org>
5469
5470 * syssignal.h: Replace RETSIGTYPE with void.
5471 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5472 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5473 Replace SIGTYPE with void everywhere.
5474 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5475 * s/template.h (SIGTYPE): Remove commented out definition.
5476
e2abce01
JB
54772011-03-26 Eli Zaretskii <eliz@gnu.org>
5478
5479 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5480 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5481
f868cd8a
JB
54822011-03-26 Juanma Barranquero <lekktu@gmail.com>
5483
59eb0929
JB
5484 * w32.c (read_unc_volume): Use parameter `henum', instead of
5485 global variable `wget_enum_handle'.
5486
5487 * keymap.c (describe_vector): Remove parameters `indices' and
5488 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5489 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5490
f868cd8a
JB
5491 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5492
5493 * keyboard.c (timer_check): Remove parameter `do_it_now',
5494 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5495 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5496 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5497
5498 * keyboard.c (read_char):
5499 * w32menu.c (w32_menu_display_help):
5500 * xmenu.c (show_help_event, menu_help_callback):
5501 Adjust calls to `show_help_echo'.
5502
5503 * gtkutil.c (xg_maybe_add_timer):
5504 * keyboard.c (readable_events):
5505 * process.c (wait_reading_process_output):
5506 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5507
5508 * insdel.c (adjust_markers_gap_motion):
5509 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5510 (gap_left, gap_right): Don't call it.
5511
2ecf6fdb
CY
55122011-03-25 Chong Yidong <cyd@stupidchicken.com>
5513
5514 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5515 incurred during fontification.
5516
6b1f9ba4
JB
55172011-03-25 Juanma Barranquero <lekktu@gmail.com>
5518
5519 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5520 (DEFVAR_PER_BUFFER): Don't pass it.
5521
5522 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5523 (scrolling_window): Don't pass it.
5524
0f4a96b5
JB
55252011-03-25 Juanma Barranquero <lekktu@gmail.com>
5526
5527 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5528
5529 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5530 and `suffix'.
5531 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5532 of variables specific to SELinux and computation of `encoded_absname'.
5533
5534 * image.c (XPutPixel): Remove unused variable `height'.
5535
5536 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5537
5538 * unexw32.c (get_section_info): Remove unused variable `section'.
5539
5540 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5541 (system_process_attributes): Remove unused variable `sess'.
5542 (sys_read): Remove unused variable `err'.
5543
5544 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5545 (w32_wnd_proc): Remove unused variable `isdead'.
5546 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5547 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5548 (x_create_tip_frame): Remove unused variable `tem'.
5549
5550 * w32inevt.c (w32_console_read_socket):
5551 Remove unused variable `no_events'.
5552
5553 * w32term.c (x_draw_composite_glyph_string_foreground):
5554 Remove unused variable `width'.
5555
1149507c
JB
55562011-03-24 Juanma Barranquero <lekktu@gmail.com>
5557
5558 * w32term.c (x_set_glyph_string_clipping):
5559 Don't pass uninitialized region to CombineRgn.
5560
9c88f339
JB
55612011-03-23 Juanma Barranquero <lekktu@gmail.com>
5562
5563 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5564 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5565 (Fx_close_connection): Remove unused variable `i'.
5566
5567 * w32font.c (w32font_draw): Return number of glyphs.
5568 (w32font_open_internal): Remove unused variable `i'.
5569 (w32font_driver): Add missing initializer.
5570
5571 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5572 (fill_in_menu): Remove unused variable `items_added'.
5573
5574 * w32term.c (last_mouse_press_frame): Remove static global variable.
5575 (w32_clip_to_row): Remove unused variable `f'.
5576 (x_delete_terminal): Remove unused variable `i'.
5577
5578 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5579 (NOTHING): Remove unused static global variable.
5580 (uniscribe_check_otf): Remove unused variable `table'.
5581 (uniscribe_font_driver): Add missing initializers.
5582
dee091a3
JD
55832011-03-23 Julien Danjou <julien@danjou.info>
5584
5585 * term.c (Fsuspend_tty, Fresume_tty):
5586 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5587 * window.c (temp_output_buffer_show):
5588 * insdel.c (signal_before_change):
5589 * frame.c (Fhandle_switch_frame):
5590 * fileio.c (Fdo_auto_save):
5591 * emacs.c (Fkill_emacs):
5592 * editfns.c (save_excursion_restore):
5593 * cmds.c (internal_self_insert):
5594 * callint.c (Fcall_interactively):
5595 * buffer.c (Fkill_all_local_variables):
5596 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5597 Use Frun_hooks.
0f4a96b5 5598 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5599 unconditionnaly since it does the check itself.
5600
2c520ab5 56012011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5602
c9c49752
PE
5603 Fix more problems found by GCC 4.5.2's static checks.
5604
8abc3f12
PE
5605 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5606 the first time through the loop, since we know p0 < p1 then.
5607 This also avoids a gcc -Wstrict-overflow warning.
5608
a2d26660
PE
5609 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5610 leading to a memory leak, possible in functions like
5611 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5612 of objects (Bug#8318).
a2d26660 5613
916c72e9
PE
5614 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5615 that could (at least in theory) be that large.
5616
19ab8a18
PE
5617 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5618 This is less likely to overflow, and avoids undefined behavior if
5619 overflow does occur. All callers changed. Use strtoul to scan
5620 for the unsigned long integer.
b7cbbd6f
PE
5621 (pint2hrstr): Simplify and tune code slightly.
5622 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5623
f0641eff
PE
5624 * scroll.c (do_scrolling): Work around GCC bug 48228.
5625 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5626
7f650bb9
PE
5627 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5628 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5629 (validate_x_resource_name): Simplify count usage.
5630 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5631
37dd57d1
PE
5632 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5633 fail (Bug#8306).
81e56e61 5634
699979fc 5635 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5636
401bf9b4
PE
5637 * process.c (Fmake_network_process): Use socklen_t, not int,
5638 where POSIX says socklen_t is required in portable programs.
5639 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5640 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5641 (Fmake_network_process, server_accept_connection):
5642 (wait_reading_process_output, read_process_output):
5643 Likewise.
5644
b93aacde
PE
5645 * process.c: Rename or move locals to avoid shadowing.
5646 (list_processes_1, Fmake_network_process):
5647 (read_process_output_error_handler, exec_sentinel_error_handler):
5648 Rename or move locals.
4dc343ee 5649 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5650 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5651 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5652 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5653 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5654
af8a867c 5655 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5656 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5657 Include tparam.h instead, since it declares them.
af8a867c
PE
5658 * cm.h (PC): Remove extern decl; tparam.h now does this.
5659 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5660 * terminfo.c: Include tparam.h, to check interfaces.
5661 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5662 (tparam): Adjust signature to match interface in tparam.h;
5663 this removes some undefined behavior. Check that outstring and len
5664 are zero, which they always are with Emacs.
5665 * tparam.h (PC, BC, UP): New extern decls.
5666
0248044d 5667 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5668 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5669
8ff096c1 5670 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5671 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5672 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5673 (ftfont_list): Remove unused local.
49eaafba
PE
5674 (get_adstyle_property, ftfont_pattern_entity):
5675 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5676 Rename locals to avoid shadowing.
8ff096c1 5677
e2be39f6
PE
5678 * xfont.c (xfont_list_family): Mark var as initialized.
5679
c9735e30
PE
5680 * xml.c (make_dom): Now static.
5681
8f5201ae
PE
5682 * composite.c (composition_compute_stop_pos): Rename local to
5683 avoid shadowing.
b246f932
PE
5684 (composition_reseat_it): Remove unused locals.
5685 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5686 (composition_update_it): Mark var as initialized.
11b61122
PE
5687 (find_automatic_composition): Mark vars as initialized,
5688 with a FIXME (Bug#8290).
8f5201ae 5689
760fbc2c
PE
5690 character.h: Rename locals to avoid shadowing.
5691 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5692 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5693 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5694 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5695 to avoid shadowing.
5696
ff08eb85
PE
5697 * textprop.c (property_change_between_p): Remove; unused.
5698
fc7bf025
PE
5699 * intervals.c (interval_start_pos): Now static.
5700
235d7abc
PE
5701 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5702
44f230aa
SM
5703 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5704 Rename locals to avoid shadowing.
3e7d6594 5705
50060332
PE
5706 * sound.c (wav_play, au_play, Fplay_sound_internal):
5707 Fix pointer signedness.
d01f234b 5708 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5709 (wav_play): Initialize a variable to 0, to prevent undefined
5710 behavior (Bug#8278).
50060332 5711
c4fc4e30
PE
5712 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5713
918436ed
PE
5714 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5715
c939f91b
PE
5716 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5717 clobbering (Bug#8298).
b9c7f648
PE
5718 * sysdep.c (sys_subshell): Likewise.
5719 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5720
6bd8c144
PE
5721 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5722 This should get cleaned up, so that child_setup has the
5723 same signature on all platforms.
5724
7710357c 5725 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5726 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5727
c59da222
CY
57282011-03-22 Chong Yidong <cyd@stupidchicken.com>
5729
5730 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5731 not to be necessary, and produces flickering.
5732
66b87493
GM
57332011-03-20 Glenn Morris <rgm@gnu.org>
5734
5735 * config.in: Remove file.
5736
45b6f6d5
JB
57372011-03-20 Juanma Barranquero <lekktu@gmail.com>
5738
5739 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5740 are now in src/globals.h.
5741 (syms_of_minibuf): Remove spurious & from previous change.
5742
3ec03f7e
LL
57432011-03-20 Leo <sdl.web@gmail.com>
5744
5745 * minibuf.c (completing-read-function): New variable.
5746 (completing-read-default): Rename from completing-read.
5747 (completing-read): Call completing-read-function.
5748
b14e3e21
CY
57492011-03-19 Juanma Barranquero <lekktu@gmail.com>
5750
5751 * xfaces.c (Fx_load_color_file):
5752 Read color file from absolute filename (bug#8250).
5753
f2b726e6
JB
57542011-03-19 Juanma Barranquero <lekktu@gmail.com>
5755
5756 * makefile.w32-in: Update dependencies.
5757
09f6ff02
EZ
57582011-03-17 Eli Zaretskii <eliz@gnu.org>
5759
5760 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5761
29a6015a
PE
57622011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5763
a3a6c54e
PE
5764 Fix more problems found by GCC 4.5.2's static checks.
5765
b766f867
PE
5766 * process.c (make_serial_process_unwind, send_process_trap):
5767 (sigchld_handler): Now static.
5768
be02381c
PE
5769 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5770 That way, the code declares only the vars that it needs.
5771 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5772 * s/cygwin.h (PTY_ITERATION): Likewise.
5773 * s/darwin.h (PTY_ITERATION): Likewise.
5774 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5775
57048744
PE
5776 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5777 * process.c (allocate_pty): Don't declare stb unless it's needed.
5778
7914961c 5779 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5780 (CONSTANTLIM): Remove; unused.
5781 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5782 Define only if needed.
7914961c 5783
b3967b18
PE
5784 * unexelf.c (unexec): Name an expression,
5785 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5786 Use a different way to cause a compilation error if anyone uses
5787 n rather than nn, a way that does not involve shadowing.
73366a00 5788 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5789
29a6015a
PE
5790 * deps.mk (unexalpha.o): Remove; unused.
5791
43cfc33e 5792 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5793 * unexec.h: New file.
ce701a33
PE
5794 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5795 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5796 Depend on unexec.h.
5797 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5798 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5799 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5800 Change as necessary to match prototype in unexec.h.
ce701a33 5801
01f44d5a
PE
5802 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5803 shadowing.
4f63c6bb 5804 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5805
a6670b0b
PE
5806 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5807 Rename locals to avoid shadowing.
5808
cef2010d 5809 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5810 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5811
d4d7173a
PE
5812 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5813
f08b802a
PE
5814 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5815 warning when compiling print.c.
5816
3ddb0639
PE
5817 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5818 instead of using an uninitialized var.
5ad03b97 5819 (font_sort_entities): Mark var as initialized.
3ddb0639 5820
170a2692
PE
5821 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5822
e663c700
PE
5823 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5824 pointers to constants.
89bc529a 5825 (font_parse_fcname): Remove unused vars.
7b81e2d0 5826 (font_delete_unmatched): Now static.
ea838e10 5827 (font_get_spec): Remove; unused.
13a547c6
PE
5828 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5829 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5830 Rename or move locals to avoid shadowing.
e663c700 5831
2a80c887 5832 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5833 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5834
1384fa33 5835 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5836 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5837
8b2c52e9
PE
5838 * alloc.c (mark_backtrace): Move decl from here ...
5839 * lisp.h: ... to here, so that it can be checked.
5840
475545b5 5841 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5842 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5843 (lisp_indirect_variable): Name an expression,
5844 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5845 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5846
b1349114 5847 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5848 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5849 Use const pointer when appropriate.
b1349114 5850
a2928364
PE
5851 * lisp.h (get_system_name, get_operating_system_release):
5852 Move decls here, to check interfaces.
5853 * process.c (get_operating_system_release): Move decl to lisp.h.
5854 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5855 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5856 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5857 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5858 (Fformat_time_string, Fencode_time, Finsert_char):
5859 (Ftranslate_region_internal, Fformat):
5860 Rename or remove local vars to avoid shadowing.
9710023e 5861 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5862
a415e694
PE
5863 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5864 avoid shadowing.
5865
8ef4622d
PE
5866 * lisp.h (eassert): Check that the argument compiles, even if
5867 ENABLE_CHECKING is not defined.
5868
946f9a5b
PE
5869 * data.c (Findirect_variable): Name an expression, to avoid
5870 gcc -Wbad-function-cast warning.
112396d6 5871 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5872 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5873 (Fmake_variable_buffer_local, Fmake_local_variable):
5874 Mark variables as initialized.
52746918 5875 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5876
e5aab7e7 5877 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5878 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5879 Rename locals to avoid shadowing.
dff45157
PE
5880 (mark_stack): Move local variables into the #ifdef region where
5881 they're used.
7bc26fdb
PE
5882 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5883 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5884 needed otherwise.
5885 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5886 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5887 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5888
e5aab7e7
PE
5889 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5890 avoids undefined behavior in theory.
5891
4da60324
PE
5892 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5893
88043301
PE
5894 Use functions, not macros, for up- and down-casing (Bug#8254).
5895 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5896 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5897 to use the following functions instead of these macros.
5898 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5899 EMACS_INT, since callers assume the returned value fits in int.
5900 (upcase1): Likewise, for UPCASE_TABLE.
5901 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5902 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5903 the race-condition problem in the old DOWNCASE.
88043301 5904
19ed5445
PE
5905 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5906 Rename locals to avoid shadowing.
5907 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5908 (regex_compile, re_search_2, re_match_2_internal):
5909 Remove unused local vars.
952db0d7
PE
5910 (FREE_VAR): Rewrite so as not to use empty "else",
5911 which gcc can warn about.
da053e48 5912 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5913 (RETALLOC_IF): Define only if needed.
5914 (WORDCHAR_P): Likewise. This one is never needed, but is used
5915 only in a comment talking about a compiler bug, so put inside
5916 the #if 0 of that comment.
5917 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5918 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5919 Remove; unused.
19ed5445 5920
1f3561e4 5921 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5922 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5923 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5924
ded6f8f7
PE
5925 * search.c (simple_search): Remove unused var.
5926
dbd37a95
PE
5927 * dired.c (compile_pattern): Move decl from here ...
5928 * lisp.h: ... to here, so that it can be checked.
5929 (struct re_registers): New forward decl.
5930
7e47afad
PE
5931 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5932
85f24f61
PE
5933 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5934 All uses changed.
5935 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5936 Rename locals to avoid shadowing.
5671df8f 5937 (Fvertical_motion): Mark locals as initialized.
85f24f61 5938
181aa2be 5939 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5940 (casify_region): Mark local as initialized.
181aa2be 5941
930d429c
PE
5942 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5943
7082eac6
PE
5944 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5945 New macros, so that the caller can use some names other than
5946 gcpro1, gcpro2, etc.
5947 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5948 of the new macros.
5949 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5950 argument, for consistency with GCPRO2_VAR, etc: it is now the
5951 prefix of the variable, not the variable itself. All uses
5952 changed.
38b2c076
PE
5953 * dired.c (directory_files_internal, file_name_completion):
5954 Rename locals to avoid shadowing.
5955
15206ed9
PE
5956 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5957 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5958 dired.c's scmp function, had undefined behavior.
5959 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5960 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5961 * buffer.h: ... to here, because these macros use current_buffer,
5962 and the new implementation with inline functions needs to have
5963 current_buffer in scope now, rather than later when the macros
5964 are used.
5965 (downcase, upcase1): New static inline functions.
5966 (DOWNCASE, UPCASE1): Reimplement using these functions.
5967 This avoids undefined behavior in expressions like
5968 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5969 from race conditions in accessing the global variables
5970 case_temp1 and case_temp2.
5971 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5972 * lisp.h (case_temp1, case_temp2): Remove their decls.
5973 * character.h (ASCII_CHAR_P): Move from here ...
5974 * lisp.h: ... to here, so that the inline functions mentioned
5975 above can use them.
5976
4a6bea26
PE
5977 * dired.c (directory_files_internal_unwind): Now static.
5978
f14b7e14
PE
5979 * fileio.c (file_name_as_directory, directory_file_name):
5980 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5981 Now static.
2893f146
PE
5982 (file_name_as_directory): Use const pointers when appropriate.
5983 (Fexpand_file_name): Likewise. In particular, newdir might
5984 point at constant storage, so make it a const pointer.
fd4ead52 5985 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5986 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5987 signedness issues.
f839df0c
PE
5988 (Fset_file_times, Finsert_file_contents, auto_save_error):
5989 Rename locals to avoid shadowing.
f14b7e14 5990
5716756e 5991 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5992 (Ftry_completion, Fall_completions): Rename or remove locals
5993 to avoid shadowing.
5716756e 5994
b4c3046a
PE
5995 * marker.c (bytepos_to_charpos): Remove; unused.
5996
b45db522
PE
5997 * lisp.h (verify_bytepos, count_markers): New decls,
5998 so that gcc does not warn that these functions aren't declared.
5999
85876d07
PE
6000 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6001 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6002 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6003 (copy_text): Remove unused local var.
85876d07 6004
03d78a21 6005 * filelock.c (within_one_second): Now static.
b3dd38ab 6006 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6007
5df8f01b
PE
6008 * buffer.c (fix_overlays_before): Mark locals as initialized.
6009 (fix_start_end_in_overlays): Likewise. This function should be
6010 simplified by using pointers-to-pointers, but that's a different
6011 matter.
b1d876f1 6012 (switch_to_buffer_1): Now static.
8f54f30a
PE
6013 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6014 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6015
a70072c9 6016 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6017 Fix pointer signedness issue.
edced198
PE
6018 (sys_subshell): Mark local as volatile if checking for lint,
6019 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6020 (MAXPATHLEN): Define only if needed.
a70072c9 6021
a0977c44
PE
6022 * process.c (serial_open, serial_configure): Move decls from here ...
6023 * systty.h: ... to here, so that they can be checked.
6024
a884fdcc
PE
6025 * fns.c (get_random, seed_random): Move extern decls from here ...
6026 * lisp.h: ... to here, so that they can be checked.
6027
604efe86 6028 * sysdep.c (reset_io): Now static.
b8950c94 6029 (wait_for_termination_signal): Remove; unused.
604efe86 6030
38fc62d9
PE
6031 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6032 (copy_keymap_item, append_key, push_text_char_description):
6033 Now static.
1004a21a 6034 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6035 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6036 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6037 (describe_map_tree):
6038 Rename locals to avoid shadowing.
38fc62d9 6039
2f2650da
PE
6040 * keyboard.c: Declare functions static if they are not used elsewhere.
6041 (echo_char, echo_dash, cmd_error, top_level_2):
6042 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6043 (read_char, kbd_buffer_get_event, make_lispy_position):
6044 (make_lispy_event, make_lispy_movement, apply_modifiers):
6045 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6046 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6047 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6048 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6049 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6050
a053e86c 6051 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6052 (mark_kboards): Move decl here ...
6053 * alloc.c (mark_kboards): ... from here.
a053e86c 6054
4752793e
PE
6055 * lisp.h (force_auto_save_soon): New decl.
6056
74f10ca7 6057 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6058 (DEFINE_DUMMY_FUNCTION): New macro.
6059 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6060 Use it.
c03cd23f
PE
6061 (main): Add casts to avoid warnings
6062 if GCC considers string literals to be constants.
74f10ca7 6063
022e70d4
PE
6064 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6065
59d6fe83
PE
6066 * dbusbind.c: Pointer signedness fixes.
6067 (xd_signature, xd_append_arg, xd_initialize):
6068 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6069 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6070 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6071 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6072
78320123
PE
6073 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6074 if GCC considers string literals to be constants.
49cebcca 6075 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6076
35ac2a97
SM
60772011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6078
fb103ca9
SM
6079 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6080 (print_preprocess, print_object): New macro to fix last change.
6081
35ac2a97
SM
6082 * print.c (print_preprocess): Don't forget font objects.
6083
62973b41
JB
60842011-03-16 Juanma Barranquero <lekktu@gmail.com>
6085
6086 * emacs.c (USAGE3): Doc fixes.
6087
0e48bb22
AS
60882011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6089
6090 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6091 structure.
6092
7684e57b
JB
60932011-03-14 Juanma Barranquero <lekktu@gmail.com>
6094
6095 * lisp.h (VWindow_system, Qfile_name_history):
6096 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6097 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6098 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6099
6100 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6101 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6102
6103 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6104 * w32console.c (detect_input_pending, read_input_pending)
6105 (encode_terminal_code):
6106 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6107 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6108 (w32_system_caret_y, Qfile_name_history):
6109 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6110 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6111 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6112 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6113 * w32proc.c (Qlocal, report_file_error):
6114 * w32term.c (Vwindow_system, updating_frame):
6115 * w32uniscribe.c (initialized, uniscribe_font_driver):
6116 Remove unneeded extern declarations.
6117
2aa46d6c
CY
61182011-03-14 Chong Yidong <cyd@stupidchicken.com>
6119
c96bbc66 6120 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6121
cffc6f3b
CY
61222011-03-13 Chong Yidong <cyd@stupidchicken.com>
6123
6124 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6125 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6126 These macros can no longer be used for assignment.
6127
44f230aa
SM
6128 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6129 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6130 (record_buffer_markers, fetch_buffer_markers): New functions for
6131 recording and fetching special buffer markers.
6132 (set_buffer_internal_1, set_buffer_temp): Use them.
6133
6134 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6135
6136 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6137
6138 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6139 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6140
6141 * xdisp.c (hscroll_window_tree):
6142 (reconsider_clip_changes): Use PT instead of BUF_PT.
6143
d251f04b
EZ
61442011-03-13 Eli Zaretskii <eliz@gnu.org>
6145
6146 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6147 $(EMACS_ROOT)/lib/intprops.h.
6148
f0c77cd1
PE
61492011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6150
3eca4629
PE
6151 Fix more problems found by GCC 4.5.2's static checks.
6152
7c86ee98
PE
6153 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6154 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6155 (xg_free_frame_widgets): Make it clear that a local variable is
6156 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6157 (gdk_window_get_screen): Make it clear that this macro is needed
6158 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6159 (int_gtk_range_get_value): New function, which avoids a diagnostic
6160 from gcc -Wbad-function-cast.
6161 (xg_set_toolkit_scroll_bar_thumb): Use it.
6162 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6163 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6164 (get_utf8_string, xg_get_file_with_chooser):
6165 Rename locals to avoid shadowing.
6166 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6167
41729b81
PE
6168 * xgselect.c (xg_select): Remove unused var.
6169
f0c77cd1
PE
6170 * image.c (four_corners_best): Mark locals as initialized.
6171 (gif_load): Initialize transparent_p to zero (Bug#8238).
6172 Mark another local as initialized.
ec6cf4c6 6173 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6174
ce0ad53d 6175 * image.c (clear_image_cache): Now static.
d5d5a617 6176 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6177 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6178 (x_edge_detection): Remove unnecessary cast that
6179 gcc -Wbad-function-cast diagnoses.
2037898d 6180 (gif_load): Fix pointer signedness.
6ae141d6
PE
6181 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6182 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6183
33383987 61842011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6185
d32df629
PE
6186 Improve quality of tests for time stamp overflow.
6187 For example, without this patch (encode-time 0 0 0 1 1
6188 1152921504606846976) returns the obviously-bogus value (-948597
6189 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6190 reports time overflow. See
6191 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6192 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6193 * editfns.c: Include limits.h and intprops.h.
6194 (TIME_T_MIN, TIME_T_MAX): New macros.
6195 (time_overflow): Move earlier, to before first use.
6196 (hi_time, lo_time): New functions, for an accurate test for
6197 out-of-range times.
6198 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6199 (Fget_internal_run_time): Don't assume time_t fits in int.
6200 (make_time): Use list2 instead of Fcons twice.
6201 (Fdecode_time): More accurate test for out-of-range times.
6202 (check_tm_member): New function.
6203 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6204 (lisp_time_argument): Don't rely on undefined left-shift and
6205 right-shift behavior when checking for time stamp overflow.
8be6f318 6206
fe31d94c
PE
6207 * editfns.c (time_overflow): New function, refactoring common code.
6208 (Fformat_time_string, Fdecode_time, Fencode_time):
6209 (Fcurrent_time_string): Use it.
6210
8be6f318
PE
6211 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6212 * dired.c (make_time): Move to ...
6213 * editfns.c (make_time): ... here.
6214 * systime.h: Note the move.
6215
09d9db2c 62162011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6217
126bc0dc
YM
6218 * fringe.c (update_window_fringes): Remove unused variables.
6219
c47cbdfd
YM
6220 * unexmacosx.c (copy_data_segment): Also copy __got section.
6221 (Bug#8223)
6222
7ac80be9
EZ
62232011-03-12 Eli Zaretskii <eliz@gnu.org>
6224
c96bbc66 6225 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6226 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6227 Constify `char *' arguments and their references according to
6228 prototypes in tparam.h.
6229
ecb0f94d 6230 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6231
7ac80be9
EZ
6232 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6233 Adapt all references accordingly.
6234
6235 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6236
ef1fd07e
TT
62372011-03-11 Tom Tromey <tromey@redhat.com>
6238
6239 * buffer.c (syms_of_buffer): Remove obsolete comment.
6240
7ef4b50c
EZ
62412011-03-11 Eli Zaretskii <eliz@gnu.org>
6242
6243 * termhooks.h (encode_terminal_code): Declare prototype.
6244
6245 * msdos.c (encode_terminal_code): Don't declare prototype.
6246
6247 * term.c (encode_terminal_code): Now external again, used by
6248 w32console.c and msdos.c.
6249
44f230aa
SM
6250 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6251 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6252
4b1ec863 62532011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6254
1714f52b 6255 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6256
4b1ec863
PE
6257 * fringe.c (update_window_fringes): Mark locals as initialized
6258 (Bug#8227).
6259 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6260
524c7aa6
PE
6261 * alloc.c (mark_fringe_data): Move decl from here ...
6262 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6263 to check its interface.
6264 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6265
a5c0af81 6266 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6267 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6268 (fontset_font): Mark local as initialized.
a9a06e0b 6269 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6270
b4716021
PE
6271 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6272
811e9bac 6273 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6274 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6275 (x_own_selection, Fx_disown_selection_internal): Rename locals
6276 to avoid shadowing.
6277 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6278
7e3ab302
PE
6279 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6280 so that the caller can use some name other than gcpro1.
6281 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6282 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6283 (Fx_backspace_delete_keys_p):
6284 Use them to avoid shadowing, and rename vars to avoid shadowing.
6285 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6286 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6287 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6288 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6289 Remove unused locals.
7e3ab302
PE
6290 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6291 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6292 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6293 macros.
f78faa98 6294
e2b13473
PE
6295 * xterm.h (x_mouse_leave): New decl.
6296
77f23912
PE
6297 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6298 Remove unused functions.
cdf4ba58
PE
6299 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6300 (x_calc_absolute_position): Now static.
7411c686 6301 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6302 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6303 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6304 unless they are used.
38d0b34a
PE
6305 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6306 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6307 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6308 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6309 (x_error_catcher, x_connection_closed, x_error_handler):
6310 (x_error_quitter, xembed_send_message, x_iconify_frame):
6311 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6312 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6313 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6314
44f230aa
SM
6315 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6316 Rename or move locals to avoid shadowing.
6b463e58 6317 (tty_defined_color, merge_face_heights): Now static.
5967d051 6318 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6319 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6320 does not deduce is never used uninitialized.
73719eba
PE
6321 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6322 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6323
426994c3 6324 * terminal.c (store_terminal_param): Now static.
5489860b 6325
032f1620 6326 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6327 (set_frame_menubar): Remove unused local.
d4323972 6328 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6329 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6330 since they might point to immutable storage.
281585b0
PE
6331 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6332 since it's unused otherwise.
032f1620 6333
367c19e5 6334 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6335 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6336 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6337 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6338 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6339 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6340 does not deduce are never used uninitialized.
70739cbe 6341
07b48fa9
PE
6342 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6343
8868a238 6344 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6345 * window.c (window_loop, size_window):
6346 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6347
7e5cf297 6348 * window.c (display_buffer): Now static.
d6550a9f
PE
6349 (size_window): Mark variables that gcc -Wuninitialized
6350 does not deduce are never used uninitialized.
a586633d
PE
6351 * window.h (check_all_windows): New decl, to forestall
6352 gcc -Wmissing-prototypes diagnostic.
5b555da1 6353 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6354
f6095868
PE
6355 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6356 shadowing.
6357 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6358 Include <limits.h>.
6359 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6360 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6361 (load_charset_map): Mark variables that gcc -Wuninitialized
6362 does not deduce are never used uninitialized.
53df7c11 6363 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6364
f38b440c
PE
6365 * coding.c (coding_set_source, coding_set_destination):
6366 Use "else { /* comment */ }" rather than "else /* comment */;"
6367 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6368 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6369 a block, when the outer 'i' will do.
6370 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6371 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6372 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6373 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6374 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6375 Rename locals to avoid shadowing.
6376 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6377 * coding.c (emacs_mule_char, encode_invocation_designation):
6378 Now static, since they're not used elsewhere.
413bb2db 6379 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6380 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6381 (decode_coding_emacs_mule): Mark variables that gcc
6382 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6383 (detect_coding_iso_2022): Initialize a local variable that might
6384 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6385 this initialization is needed. (Bug#8211)
5f58e762
PE
6386 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6387 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6388 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6389 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6390 Remove unused macros.
f38b440c 6391
232b38b9 6392 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6393 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6394 * character.c (string_count_byte8): Likewise.
232b38b9 6395
fb90da1b
PE
6396 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6397 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6398
fb93dbc2
PE
6399 * chartab.c (copy_sub_char_table): Now static, since it's not used
6400 elsewhere.
5c156ace
PE
6401 (sub_char_table_ref_and_range, char_table_ref_and_range):
6402 Rename locals to avoid shadowing.
bbcd0949 6403 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6404
7d3b3862 6405 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6406 (BIDI_BOB): Remove unused macro.
7d3b3862 6407
6be7d3da
PE
6408 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6409 deduce are never used uninitialized.
c2ed9c8b 6410 * term.c (encode_terminal_code): Likewise.
6be7d3da 6411
75f8807f 6412 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6413
50938595
PE
6414 * tparam.h: New file.
6415 * term.c, tparam.h: Include it.
6416 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6417 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6418 Move these decls to tparam.h, and make them agree with what
6419 is actually in tparam.c. The previous trick of using incompatible
6420 decls in different modules does not conform to the C standard.
6421 All callers of tparam changed to use tparam's actual API.
6422 * tparam.c (tparam1, tparam, tgoto):
6423 Use const pointers where appropriate.
6424
fbceeba2
PE
6425 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6426 * cm.h (struct cm): Likewise.
6427 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6428 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6429 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6430 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6431 (turn_on_face, init_tty): Likewise.
6432 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6433
7f3f1250
PE
6434 * term.c (term_mouse_position): Rename local to avoid shadowing.
6435
e6ca6543
PE
6436 * alloc.c (mark_ttys): Move decl from here ...
6437 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6438
c40f8d15
AS
64392011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6440
6441 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6442
cfe0661d
JB
64432011-03-09 Juanma Barranquero <lekktu@gmail.com>
6444
6445 * search.c (compile_pattern_1): Remove argument regp, unused since
6446 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6447 (compile_pattern): Don't pass it.
6448
0afb4571
J
64492011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6450
6451 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6452 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6453 for ! HAVE_GTK3.
6454 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6455
6456 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6457
6458 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6459 gdk_window_get_screen, gdk_window_get_geometry,
6460 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6461 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6462 (xg_get_pixbuf_from_pixmap): New function.
6463 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6464 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6465 Call xg_get_pixbuf_from_pixmap instead of
6466 gdk_pixbuf_get_from_drawable.
6467 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6468 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6469 (xg_check_special_colors): Use GtkStyleContext and its functions
6470 for HAVE_GTK3.
6471 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6472 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6473 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6474 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6475 Call gtk_widget_get_preferred_size.
0afb4571
J
6476 (xg_frame_resized): gdk_window_get_geometry only takes 5
6477 parameters.
44f230aa
SM
6478 (xg_win_to_widget, xg_event_is_for_menubar):
6479 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6480 (xg_set_widget_bg): New function.
6481 (delete_cb): New function.
895009e1 6482 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6483 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6484 (xg_set_background_color): Call xg_set_widget_bg.
6485 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6486 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6487 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6488 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6489 if ! HAVE_GTK3.
6490 (update_frame_tool_bar): Call gtk_widget_hide.
6491 (xg_initialize): Use GDK_KEY_g.
6492
6493 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6494 if ! HAVE_GTK3
6495 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6496
6497 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6498 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6499 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6500
1c2cc4ef
JB
65012011-03-08 Juanma Barranquero <lekktu@gmail.com>
6502
6503 * w32xfns.c (select_palette): Check success of RealizePalette against
6504 GDI_ERROR, not zero.
6505
33383987 6506See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6507
6508;; Local Variables:
6509;; coding: utf-8
aac0c6e3
MR
6510;; End:
6511
33383987 6512 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6513
6514 This file is part of GNU Emacs.
6515
6516 GNU Emacs is free software: you can redistribute it and/or modify
6517 it under the terms of the GNU General Public License as published by
6518 the Free Software Foundation, either version 3 of the License, or
6519 (at your option) any later version.
6520
6521 GNU Emacs is distributed in the hope that it will be useful,
6522 but WITHOUT ANY WARRANTY; without even the implied warranty of
6523 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6524 GNU General Public License for more details.
6525
6526 You should have received a copy of the GNU General Public License
6527 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.